Context Navigation

(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::isolatedContextWeakCallback):
(WebCore):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::installDOMWindow):

bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isolated):
(V8DOMWindowShell):

bindings/v8/V8PerContextData.h:
bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

11:41 PM Changeset in webkit [135483] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: simplify the _updateChunksForRanges routine
https://bugs.webkit.org/show_bug.cgi?id=102927

Reviewed by Vsevolod Vlasov.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.detachFromDOM):
(WebInspector.TextEditorMainChunk.prototype.anchorElement):

11:35 PM Changeset in webkit [135482] by haraken@chromium.org

5 edits in trunk/Source/WebCore

[V8] WebCoreStringResourceBase should be located in V8StringResource.h
https://bugs.webkit.org/show_bug.cgi?id=103002

Reviewed by Adam Barth.

Currently WebCoreStringResourceBase is mis-located in V8ValueCache.h.
It should be in V8StringResource.h.

No tests. No change in behavior.

bindings/v8/V8StringResource.cpp:

(WebCore::WebCoreStringResourceBase::toWebCoreStringResourceBase):
(WebCore):
(WebCore::WebCoreStringResourceBase::visitStrings):

bindings/v8/V8StringResource.h:

(WebCore):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::webcoreString):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCore::WebCoreStringResourceBase::memoryConsumption):
(WebCoreStringResource16):
(WebCore::WebCoreStringResource16::WebCoreStringResource16):
(WebCoreStringResource8):
(WebCore::WebCoreStringResource8::WebCoreStringResource8):

bindings/v8/V8ValueCache.cpp:
bindings/v8/V8ValueCache.h:

(WebCore):

11:33 PM Changeset in webkit [135481] by commit-queue@webkit.org

5 edits
2 deletes in trunk

Unreviewed, rolling out r135464.
http://trac.webkit.org/changeset/135464
https://bugs.webkit.org/show_bug.cgi?id=103026

breaks gtk bot (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

Source/WebCore:

dom/Element.cpp:
dom/Element.h:

(Element):

dom/Element.idl:

LayoutTests:

fast/dom/shadow/shadow-aware-create-shadow-root-expected.txt: Removed.
fast/dom/shadow/shadow-aware-create-shadow-root.html: Removed.

11:08 PM Changeset in webkit [135480] by Vineet

2 edits in trunk/Tools

Unreviewed. Adding myself to committers.py.

Scripts/webkitpy/common/config/committers.py:

11:04 PM Changeset in webkit [135479] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

bindings/v8/ScriptController.cpp:

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

bindings/v8/V8PerContextData.h:
bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

10:45 PM Changeset in webkit [135478] by commit-queue@webkit.org

7 edits
4 adds in trunk

Numeric identifiers of events should not be globally sequential
https://bugs.webkit.org/show_bug.cgi?id=102244

Patch by Cosmin Truta <ctruta@rim.com> on 2012-11-21
Reviewed by Alexey Proskuryakov.

Source/WebCore:

The functions setTimeout, setInterval and navigator.geolocation.watchPosition
are currently returning values that are unique across all JavaScript execution
contexts, due to their dependency on global variables.
Such a guarantee is unnecessarily strong. In this patch, we constrain uniqueness
to these functions' own script execution context only.

Tests: fast/dom/Geolocation/watchPosition-unique.html

fast/dom/Window/setTimeout-setInterval-unique.html

Modules/geolocation/Geolocation.cpp:

(WebCore): Remove firstAvailableWatchId.
(WebCore::Geolocation::watchPosition): Get new watchID from script execution context.
(WebCore::Geolocation::clearWatch): Invalid watchID means less than or equal to 0.

Modules/geolocation/Geolocation.h:

(Geolocation): Renamed the argument of Geolocation::clearWatch to WatchID.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::ScriptExecutionContext): Update initialization.
(WebCore::ScriptExecutionContext::newUniqueID): Add.

dom/ScriptExecutionContext.h:

(ScriptExecutionContext): Add m_sequentialID.
(WebCore::ScriptExecutionContext::addTimeout): Inline.
(WebCore::ScriptExecutionContext::removeTimeout): Inline.
(WebCore::ScriptExecutionContext::findTimeout): Inline.

page/DOMTimer.cpp:

(WebCore): Remove timeoutId.
(WebCore::DOMTimer::DOMTimer): Get new timeoutId from script execution context.

LayoutTests:

Ensured that the results of setTimeout(), setInterval() and
navigator.geolocation.watchPosition() are strictly positive
and unique within their script execution context.

fast/dom/Geolocation/watchPosition-unique-expected.txt: Added.
fast/dom/Geolocation/watchPosition-unique.html: Added.
fast/dom/Window/setTimeout-setInterval-unique-expected.txt: Added.
fast/dom/Window/setTimeout-setInterval-unique.html: Added.

10:18 PM Changeset in webkit [135477] by ryuan.choi@samsung.com

2 edits in trunk

[EFL] Remove unnecessary definition, -DENABLE_SPELLCHECK=1
https://bugs.webkit.org/show_bug.cgi?id=102988

Patch by Ryuan Choi <ryuan.choi@gmail.com> on 2012-11-21
Reviewed by Laszlo Gombos.

Removed -DENABLE_SPELLCHECK=1 because feature macros are controlled by
WEBKIT_OPTION_XXX and cmakeconfig.h.cmake.

Source/cmake/OptionsEfl.cmake:

10:18 PM Changeset in webkit [135476] by rniwa@webkit.org

16 edits in trunk/Source/WebCore

CollectionType and DynamicNodeList::NodeListType should be merged
https://bugs.webkit.org/show_bug.cgi?id=102983

Reviewed by Antti Koivisto.

Merged DynamicNodeList::NodeListType (for live NodeList) into CollectionType.

dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

dom/Document.cpp:

(WebCore::Document::registerNodeListCache):
(WebCore::Document::unregisterNodeListCache):
(WebCore::Document::getItems):

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::DynamicNodeListCacheBase):
(WebCore::DynamicNodeListCacheBase::hasIdNameCache): Added. Returns iff this is a HTMLCollection.
(WebCore::DynamicNodeListCacheBase::invalidateCache):
(WebCore::DynamicNodeList::DynamicNodeList):
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):

dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::~MicroDataItemList):

dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

dom/Node.cpp:

(WebCore::Node::getElementsByTagName):
(WebCore::Node::getElementsByName):
(WebCore::Node::getElementsByClassName):
(WebCore::Node::radioNodeList):
(WebCore::Node::propertyNodeList):

dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName): No longer converts CollectionType to
a NodeListType equivalent since two enums have been merged.
(WebCore::NodeListsNodeData::cacheWithAtomicName): Ditto.
(WebCore::NodeListsNodeData::addCacheWithName): Ditto.
(WebCore::NodeListsNodeData::removeCacheWithAtomicName): Ditto.
(WebCore::NodeListsNodeData::removeCacheWithName): Ditto.
(WebCore::NodeListsNodeData::namedNodeListKey): Ignore types before FirstNodeCollectionType
to minimize the hash conflicts.

dom/PropertyNodeList.cpp:

(WebCore::PropertyNodeList::~PropertyNodeList):

dom/TagNodeList.cpp:

(WebCore::TagNodeList::~TagNodeList):

html/CollectionType.h:

(WebCore::isNodeList): Added.

html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::isAcceptableElement):
(WebCore::DynamicNodeListCacheBase::iterateForNextNode):
(WebCore::DynamicNodeListCacheBase::itemBeforeOrAfter):

html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::~LabelsNodeList):

html/RadioNodeList.cpp:

(WebCore::RadioNodeList::~RadioNodeList):

10:06 PM Changeset in webkit [135475] by tkent@chromium.org

4788 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium*//*.png

<Omit the file list>

9:08 PM Changeset in webkit [135474] by tkent@chromium.org

339 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-linux//*.png

<Omit the file list>

8:58 PM Changeset in webkit [135473] by tkent@chromium.org

299 edits in trunk/LayoutTests

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-win//*.png

<Omit the file list>

8:49 PM Changeset in webkit [135472] by tkent@chromium.org

1820 edits in trunk/LayoutTests/platform/chromium-mac

2012-11-21 Kent Tamura <tkent@chromium.org>

[Chromium] Correct svn:mime-type for platform/chromium-mac//*.png

<Omit the file list>

8:34 PM Changeset in webkit [135471] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

IndexedDB: Obtain ScriptState from IDL binding generator
https://bugs.webkit.org/show_bug.cgi?id=102552

Patch by Michael Pruett <michael@68k.org> on 2012-11-21
Reviewed by Kentaro Hara.

Obtain ScriptState from IDL binding generator rather than directly
calling ScriptState::current() since that method does not exist
in JSC.

Tests: storage/indexeddb/*

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):

Modules/indexeddb/IDBObjectStore.h:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):
(IDBObjectStore):

Modules/indexeddb/IDBObjectStore.idl:

8:30 PM Changeset in webkit [135470] by tkent@chromium.org

1 edit in trunk/LayoutTests/ChangeLog

[Chromium] Correct svn:mime-type for platform/chromium-mac//*.png

<Omit the file list>

8:23 PM Changeset in webkit [135469] by fpizlo@apple.com

73 edits in trunk/Source

Rename dataLog() and dataLogV() to dataLogF() and dataLogFV()
https://bugs.webkit.org/show_bug.cgi?id=103001

Rubber stamped by Dan Bernstein.

Source/JavaScriptCore:

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):
(JSC::LinkBuffer::dumpLinkStatistics):
(JSC::LinkBuffer::dumpCode):

assembler/LinkBuffer.h:

(JSC):

assembler/SH4Assembler.h:

(JSC::SH4Assembler::vprintfStdoutInstr):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecodeCommentAndNewLine):
(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::printStructure):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::dumpStatistics):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::reoptimize):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::CodeBlock::shouldOptimizeNow):
(JSC::CodeBlock::tallyFrequentExitSites):
(JSC::CodeBlock::dumpValueProfiles):

bytecode/Opcode.cpp:

(JSC::OpcodeStats::~OpcodeStats):

bytecode/SamplingTool.cpp:

(JSC::SamplingFlags::stop):
(JSC::SamplingRegion::dumpInternal):
(JSC::SamplingTool::dump):

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeStateAtTail):
(JSC::DFG::AbstractState::mergeToSuccessors):

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::dump):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::makeSafe):
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::CFAPhase::performForwardCFA):

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):
(JSC::DFG::CFGSimplificationPhase::fixPhis):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::removePotentiallyDeadPhiReference):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::endIndexForPureCSE):
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGCapabilities.cpp:

(JSC::DFG::debugFail):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::paintUnreachableCode):

dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixDoubleEdge):

dfg/DFGGraph.cpp:

(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::predictArgumentTypes):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOperations.cpp:
dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

dfg/DFGPhase.h:

(JSC::DFG::runAndLog):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

dfg/DFGRegisterBank.h:

(JSC::DFG::RegisterBank::dump):

dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::use):
(JSC::DFG::ScoreBoard::dump):

dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecutionWithConditionalDirection):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):
(JSC::DFG::SpeculativeJIT::dump):
(JSC::DFG::SpeculativeJIT::checkConsistency):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):

dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

dfg/DFGValidate.cpp:

(Validate):
(JSC::DFG::Validate::reportValidationContext):
(JSC::DFG::Validate::dumpData):
(JSC::DFG::Validate::dumpGraphIfAppropriate):

dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::logEvent):
(JSC::DFG::VariableEventStream::reconstruct):

dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

heap/Heap.cpp:
heap/HeapStatistics.cpp:

(JSC::HeapStatistics::logStatistics):
(JSC::HeapStatistics::showObjectStatistics):

heap/MarkStack.h:
heap/MarkedBlock.h:
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::validate):

interpreter/CallFrame.cpp:

(JSC::CallFrame::dumpCaller):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpForInstructions):

jit/JITStubRoutine.h:

(JSC):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jit/JumpReplacementWatchpoint.cpp:

(JSC::JumpReplacementWatchpoint::fireInternal):

llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::handleHostCall):
(JSC::LLInt::setUpCall):

profiler/Profile.cpp:

(JSC::Profile::debugPrintData):
(JSC::Profile::debugPrintDataSampleStyle):

profiler/ProfileNode.cpp:

(JSC::ProfileNode::debugPrintData):
(JSC::ProfileNode::debugPrintDataSampleStyle):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::dumpRegExpTrace):

runtime/RegExp.cpp:

(JSC::RegExp::matchCompareWithInterpreter):

runtime/SamplingCounter.cpp:

(JSC::AbstractSamplingCounter::dump):

runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::PropertyMapStatisticsExitLogger::~PropertyMapStatisticsExitLogger):

tools/CodeProfile.cpp:

(JSC::CodeProfile::report):

tools/ProfileTreeNode.h:

(JSC::ProfileTreeNode::dumpInternal):

yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::dumpDisjunction):

Source/WebCore:

No change in behavior, so no new tests.

platform/KURLWTFURL.cpp:

(WebCore::KURL::print):

Source/WTF:

wtf/DataLog.cpp:

(WTF::dataLogFV):
(WTF::dataLogF):
(WTF::dataLogFString):

wtf/DataLog.h:

(WTF):

wtf/HashTable.cpp:

(WTF::HashTableStats::dumpStats):

wtf/HashTable.h:

(WTF::HashTable::Stats::dumpStats):

wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

wtf/StackStats.cpp:

(WTF::StackStats::initialize):
(WTF::StackStats::PerThreadStats::PerThreadStats):
(WTF::StackStats::CheckPoint::CheckPoint):
(WTF::StackStats::CheckPoint::~CheckPoint):
(WTF::StackStats::probe):
(WTF::StackStats::LayoutCheckPoint::LayoutCheckPoint):

wtf/text/WTFString.cpp:

(String::show):

8:11 PM Changeset in webkit [135468] by commit-queue@webkit.org

5 edits
10 adds in trunk/Source/WebCore

[EFL] Refactor GraphicsContext3DEFL.
https://bugs.webkit.org/show_bug.cgi?id=101291.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DEfl creates GraphicsContext3DPrivate, which acts as its platform Layer.
GraphicsContext3DPrivate needs to handle the following cases:
1) To provide an off-screen buffer for accelerated composition.
2) Render to a current context.
3) To render directly to host window. (currently not supported.)

Before this patch Evas was used to provide us an off-screen context and buffer. GLX was used in
the other supported case. Evas acts as a glue layer to provide us with appropriate
GL bindings (OpenGL functions), GL context and drawable (surface/offscreenbuffer).
However, primitive rendering is handled by TextureMapper and OpenGLShims is used to load the needed GL functions.

It would be for our advantage to be able to take in to use any optimisations/extensions
provided by underlying drivers, specific to a platform (e.g. GLX_MESA_copy_sub_buffer etc.).
This patch introduces an abstraction layer to make it easy to add support for any GL backend (GLX, EGL etc.)
and do any platform specific optimizations as needed without complicating GraphicsContext3DPrivate class.
Two new classes are added with this implementation, GLPlatformContext and GLPlatformSurface.
GraphicsContext3DPrivate would create and own a GLPlatformContext and GLPlatformSurface.

GLPlatformContext encapsulates an OpenGL context hiding any platform specific management.
It uses GL extension ARB_robustness (when available) to detect driver resets.
It defines a simple interface for things that need to be handled by the context. Support
for multi-threaded usage and shared context-group would be added later.

GLPlatformSurface encapsulates an OpenGL drawable hiding any platform specific management.
It defines a simple interface for things that need to be handled by the surface.
It creates an off-screen rendering area. Any GLPlatformContext (compatible with the surface)
can be used to render into this off-screen area.

This patch also adds GLX implementation. To keep the patch to minimum EGL support would be added in another changeset.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::makeContextCurrent):
(WebCore::GraphicsContext3D::setContextLostCallback):

platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(GraphicsContext3DPrivate::releaseResources):
(GraphicsContext3DPrivate::setContextLostCallback):
(GraphicsContext3DPrivate::platformGraphicsContext3D):
(GraphicsContext3DPrivate::makeContextCurrent):
(GraphicsContext3DPrivate::createGraphicsSurfaces):
(GraphicsContext3DPrivate::copyToGraphicsSurface):
(GraphicsContext3DPrivate::graphicsSurfaceToken):

platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

platform/graphics/opengl/GLDefs.h: Added.

(WebCore):

platform/graphics/opengl/GLPlatformContext.cpp: Added.

(WebCore):
(WebCore::GLPlatformContext::createContext):
(WebCore::GLPlatformContext::createOffScreenContext):
(WebCore::GLPlatformContext::createCurrentContextWrapper):
(WebCore::GLPlatformContext::GLPlatformContext):
(WebCore::GLPlatformContext::~GLPlatformContext):
(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::isValid):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::handle):
(WebCore::GLPlatformContext::isCurrentContext):
(WebCore::GLPlatformContext::initialize):
(WebCore::GLPlatformContext::getCurrent):
(WebCore::GLPlatformContext::platformMakeCurrent):
(WebCore::GLPlatformContext::platformReleaseCurrent):
(WebCore::GLPlatformContext::destroy):

platform/graphics/opengl/GLPlatformContext.h: Added.

(WebCore):
(GLPlatformContext):

platform/graphics/opengl/GLPlatformSurface.cpp: Added.

(WebCore):
(WebCore::GLPlatformSurface::createOffscreenSurface):
(WebCore::GLPlatformSurface::createTransportSurface):
(WebCore::GLPlatformSurface::GLPlatformSurface):
(WebCore::GLPlatformSurface::~GLPlatformSurface):
(WebCore::GLPlatformSurface::handle):
(WebCore::GLPlatformSurface::geometry):
(WebCore::GLPlatformSurface::sharedDisplay):
(WebCore::GLPlatformSurface::configuration):
(WebCore::GLPlatformSurface::swapBuffers):
(WebCore::GLPlatformSurface::copyTexture):
(WebCore::GLPlatformSurface::updateContents):
(WebCore::GLPlatformSurface::setGeometry):
(WebCore::GLPlatformSurface::destroy):

platform/graphics/opengl/GLPlatformSurface.h: Added.

(WebCore):
(GLPlatformSurface):

GLXOffScreenContext creates an off-screen context. This is used when
renderstyle is RenderOffscreen.
It uses GL extension GLX_ARB_create_context (when available)
to create a context else falls back to use glXCreateNewContext.

platform/graphics/surfaces/glx/GLXContext.cpp: Added.

(WebCore):
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::~GLXOffScreenContext):
(WebCore::GLXOffScreenContext::isCurrentContext):
(WebCore::GLXOffScreenContext::platformMakeCurrent):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):
(WebCore::GLXOffScreenContext::destroy):

GLXCurrentContextWrapper acts as a wrapper for current context.
This is used when renderstyle is RenderToCurrentGLContext.

platform/graphics/surfaces/glx/GLXContext.h: Added.

(WebCore):
(GLXCurrentContextWrapper):
(WebCore::GLXCurrentContextWrapper::GLXCurrentContextWrapper):
(WebCore::GLXCurrentContextWrapper::~GLXCurrentContextWrapper):
(GLXOffScreenContext):

platform/graphics/surfaces/glx/GLXSurface.cpp: Added.

(WebCore):
(WebCore::GLXSurface::GLXSurface):
(WebCore::GLXSurface::~GLXSurface):
(WebCore::GLXSurface::visualInfo):
(WebCore::GLXSurface::xWindow):
(WebCore::GLXSurface::pBufferConfiguration):
(WebCore::GLXSurface::transportSurfaceConfiguration):
(WebCore::GLXSurface::isXRenderExtensionSupported):

GLXTransportSurface creates Window and uses it as an off-screen surface.
Any GLContext that was created with respect to configuration can be used
to render into this.
This is used when contents of the buffer are to be provided to UI Process
for display.

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::~GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::swapBuffers):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::initialize):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXTransportSurface::freeResources):

GLXPBuffer, Creates a GL surface (PBuffer) used for offscreen rendering.
Any GLContext that was created with respect to configuration can be used
to render into this.

(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::~GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):
(WebCore::GLXPBuffer::destroy):
(WebCore::GLXPBuffer::freeResources):

platform/graphics/surfaces/glx/GLXSurface.h: Added.

(WebCore):

Creates X resources which are shared between surface and context.

(SharedX11Resources):
(WebCore::SharedX11Resources::create):
(WebCore::SharedX11Resources::deref):
(WebCore::SharedX11Resources::getXWindow):
(WebCore::SharedX11Resources::display):
(WebCore::SharedX11Resources::visualInfo):
(WebCore::SharedX11Resources::createConfig):
(WebCore::SharedX11Resources::pBufferContextConfig):
(WebCore::SharedX11Resources::surfaceContextConfig):
(WebCore::SharedX11Resources::isXRenderExtensionSupported):
(WebCore::SharedX11Resources::SharedX11Resources):
(WebCore::SharedX11Resources::~SharedX11Resources):
(GLXSurface):
(GLXTransportSurface):
(GLXPBuffer):

8:01 PM Changeset in webkit [135467] by tkent@chromium.org

41 edits
24 adds in trunk/LayoutTests

[Chromium] Rebaselin for recent forms changes.

platform/chromium-linux-x86/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png: Added.
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png: Added.
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png: Added.
platform/chromium/TestExpectations:

7:47 PM Changeset in webkit [135466] by fpizlo@apple.com

10 edits
1 add in trunk/Source/JavaScriptCore

It should be possible to say disassemble(stuff) instead of having to say if (!tryToDisassemble(stuff)) dataLog("I failed")
https://bugs.webkit.org/show_bug.cgi?id=103010

Reviewed by Anders Carlsson.

You can still say tryToDisassemble(), which will tell you if it failed; you can then
decide what to do instead. But it's better to say disassemble(), which will just print
the instruction ranges if tryToDisassemble() failed. This is particularly appropriate
since that's what all previous users of tryToDisassemble() would have done in some
form or another.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpDisassembly):

disassembler/Disassembler.cpp: Added.

(JSC):
(JSC::disassemble):

disassembler/Disassembler.h:

(JSC):

jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpDisassembly):

7:45 PM Changeset in webkit [135465] by akling@apple.com

29 edits in trunk/Source/WebCore

Re-virtualize CSSRule.
<http://webkit.org/b/103003>

Reviewed by Anders Carlsson.

Make CSSRule virtual once again, since it's no longer important to keep it as small as possible.
StyleRuleBase and its various subclasses are the relevant ones now.

css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::CSSCharsetRule):
(WebCore::CSSCharsetRule::reportMemoryUsage):

css/CSSCharsetRule.h:

(WebCore::CSSCharsetRule::~CSSCharsetRule):
(WebCore::CSSCharsetRule::encoding):
(WebCore::CSSCharsetRule::setEncoding):

css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::CSSFontFaceRule):
(WebCore::CSSFontFaceRule::reattach):
(WebCore::CSSFontFaceRule::reportMemoryUsage):

css/CSSFontFaceRule.h:

(CSSFontFaceRule):

css/CSSImportRule.cpp:

(WebCore::CSSImportRule::CSSImportRule):
(WebCore::CSSImportRule::reportMemoryUsage):
(WebCore::CSSImportRule::reattach):
(WebCore):

css/CSSImportRule.h:

(CSSImportRule):

css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::CSSMediaRule):
(WebCore::CSSMediaRule::reattach):
(WebCore::CSSMediaRule::reportMemoryUsage):

css/CSSMediaRule.h:

(CSSMediaRule):

css/CSSPageRule.cpp:

(WebCore::CSSPageRule::CSSPageRule):
(WebCore::CSSPageRule::reattach):
(WebCore::CSSPageRule::reportMemoryUsage):

css/CSSPageRule.h:

(CSSPageRule):

css/CSSRule.cpp:

(SameSizeAsCSSRule):
(WebCore::CSSRule::reportMemoryUsage):

css/CSSRule.h:

(WebCore::CSSRule::~CSSRule):
(CSSRule):
(WebCore::CSSRule::CSSRule):

css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::reattach):
(WebCore::CSSStyleRule::reportMemoryUsage):

css/CSSStyleRule.h:

(CSSStyleRule):
(WebCore::CSSStyleRule::type):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::rules):

css/CSSUnknownRule.h:

(WebCore::CSSUnknownRule::CSSUnknownRule):
(WebCore::CSSUnknownRule::~CSSUnknownRule):

css/StyleResolver.cpp:

(WebCore::collectCSSOMWrappers):

css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::WebKitCSSKeyframeRule):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reattach):
(WebCore):

css/WebKitCSSKeyframeRule.h:

(WebKitCSSKeyframeRule):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::reattach):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):

css/WebKitCSSKeyframesRule.h:

(WebKitCSSKeyframesRule):

css/WebKitCSSRegionRule.cpp:

(WebCore::WebKitCSSRegionRule::WebKitCSSRegionRule):
(WebCore::WebKitCSSRegionRule::reattach):
(WebCore::WebKitCSSRegionRule::reportMemoryUsage):

css/WebKitCSSRegionRule.h:

(WebKitCSSRegionRule):

css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::WebKitCSSViewportRule):
(WebCore::WebKitCSSViewportRule::reattach):
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):

css/WebKitCSSViewportRule.h:
inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::asCSSStyleRule):
(WebCore::InspectorCSSAgent::collectStyleSheets):

inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

7:15 PM Changeset in webkit [135464] by morrita@google.com

5 edits
2 adds in trunk

[Shadow DOM] Implement Element::createShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=102911

Reviewed by Kentaro Hara.

Source/WebCore:

Added an API implementation and exposed it.

This is basically an alias of the ShadowRoot constructor, which
will be removed as bug 102913.

Test: fast/dom/shadow/shadow-aware-create-shdow-root.html

dom/Element.cpp:

(WebCore::Element::createShadowRoot):
(WebCore):

dom/Element.h:

(Element):

dom/Element.idl:

LayoutTests:

The coverage might not seem comprehensive at a glance. However,
this is just an alias of ShadowRoot constructor and there are
bunch of test cases which cover it.

As bug 102913 will convert such callsites to use createShadowRoot(),
the API will get be covered well then.

fast/dom/shadow/shadow-aware-create-shdow-root-expected.txt: Added.
fast/dom/shadow/shadow-aware-create-shdow-root.html: Added. Further ShadowAware API will come here.

7:08 PM Changeset in webkit [135463] by commit-queue@webkit.org

2 edits in trunk

[EFL] GLX detection is broken.
https://bugs.webkit.org/show_bug.cgi?id=102687.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-11-21
Reviewed by Laszlo Gombos.

HAVE_GLX is enabled only if WebGL is enabled. This is wrong and we should
explicitly test for GLX support.
This patch makes changes so that we check for glx.h header and sets HAVE_GLX flag appropriately.

Source/cmake/OptionsEfl.cmake:

7:05 PM Changeset in webkit [135462] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

dumpOperands() claims that it needs a non-const Operands& when that is completely false
https://bugs.webkit.org/show_bug.cgi?id=103005

Reviewed by Eric Carlson.

bytecode/Operands.h:

(JSC::dumpOperands):
(JSC):

6:06 PM Changeset in webkit [135461] by commit-queue@webkit.org

11 edits in trunk/Source/WebKit2

[EFL][WK2] Use consistent class names in the clients
https://bugs.webkit.org/show_bug.cgi?id=102684

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

WebKit EFL classes do not use '_' since r135117 but '_' is still remained
in some clients classes. This patch removed the '_' to make class names
to be consistent.

UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):

UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::didFail):

UIProcess/efl/FormClientEfl.cpp:

(WebKit::FormClientEfl::willSubmitForm):

UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

UIProcess/efl/PagePolicyClientEfl.cpp:

(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):

UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):

UIProcess/efl/RequestManagerClientEfl.cpp:

(WebKit::EwkUrlSchemeHandler::EwkUrlSchemeHandler):
(WebKit::RequestManagerClientEfl::didReceiveURIRequest):
(WebKit::RequestManagerClientEfl::registerURLSchemeHandler):

UIProcess/efl/RequestManagerClientEfl.h:

(RequestManagerClientEfl):

UIProcess/efl/ResourceLoadClientEfl.cpp:

(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):

UIProcess/efl/ResourceLoadClientEfl.h:

(ResourceLoadClientEfl):

5:21 PM Changeset in webkit [135460] by danakj@chromium.org

2 edits in trunk/LayoutTests

Remove crashing expectation for css3/filters/effect-reference-ordering-hw.html
https://bugs.webkit.org/show_bug.cgi?id=102898

Unreviewed test expectations.

platform/chromium/TestExpectations:

5:06 PM Changeset in webkit [135459] by commit-queue@webkit.org

8 edits in trunk

[chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
https://bugs.webkit.org/show_bug.cgi?id=100061

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

On Android we're using a different pixel scaling implementation
(WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
platforms. In this mode, we don't make use of device-independent pixels. Device
scale factor is provided to WebKit and get merged into page scale factor. Other
than that device scale factor should have no effects on rendering.

Source/WebKit/chromium:

src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

src/PageWidgetDelegate.h:
src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::shouldApplyDeviceScaleFactorInCompositor):
(WebKit):

src/WebViewImpl.h:

(WebViewImpl):

Tools:

DumpRenderTree/chromium/WebPreferences.cpp:

(WebPreferences::applyTo):

4:50 PM Changeset in webkit [135458] by simonjam@chromium.org

7 edits in trunk/Source/WebCore

[Resource Timing] Populate PerformanceResourceTiming structs with timing data
https://bugs.webkit.org/show_bug.cgi?id=102862

Reviewed by Tony Gentilcore.

This allows CachedResourceLoader to pass in all of the necessary values and populates
them in the PerformanceResourceTiming struct. A follow up patch will actually call
addResourceTiming() as necessary.

Tests: http/tests/w3c/webperf/submission/resource-timing

page/Performance.cpp:

(WebCore::Performance::addResourceTiming): Accept all necessary timing data.

page/Performance.h:

(WebCore):
(Performance):

page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::PerformanceEntry):

page/PerformanceEntry.h:

(PerformanceEntry):

page/PerformanceResourceTiming.cpp:

(WebCore::monotonicTimeToDocumentMilliseconds):
(WebCore):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::initiatorType): Return the spec'd values.
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

page/PerformanceResourceTiming.h:

(WebCore::PerformanceResourceTiming::create):
(PerformanceResourceTiming):

4:46 PM Changeset in webkit [135457] by fpizlo@apple.com

11 edits
2 adds in trunk/Source/JavaScriptCore

Baseline JIT's disassembly should be just as pretty as the DFG's
https://bugs.webkit.org/show_bug.cgi?id=102873

Reviewed by Sam Weinig.

Integrated the CodeBlock's bytecode dumper with the JIT's disassembler. Also fixed
some type goof-ups (instructions are not in a Vector<Instruction> so using a Vector
iterator makes no sense) and stream-lined some things (you don't actually need a
full-fledged ExecState* to dump bytecode).

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printUnaryOp):
(JSC::CodeBlock::printBinaryOp):
(JSC::CodeBlock::printConditionalJump):
(JSC::CodeBlock::printGetByIdOp):
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::printPutByIdOp):
(JSC::CodeBlock::dump):
(JSC):
(JSC::CodeBlock::CodeBlock):

bytecode/CodeBlock.h:

(CodeBlock):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpCallFrame):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):

jit/JIT.h:

(JIT):

jit/JITDisassembler.cpp: Added.

(JSC):
(JSC::JITDisassembler::JITDisassembler):
(JSC::JITDisassembler::~JITDisassembler):
(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::dumpForInstructions):
(JSC::JITDisassembler::dumpDisassembly):

jit/JITDisassembler.h: Added.

(JSC):
(JITDisassembler):
(JSC::JITDisassembler::setStartOfCode):
(JSC::JITDisassembler::setForBytecodeMainPath):
(JSC::JITDisassembler::setForBytecodeSlowPath):
(JSC::JITDisassembler::setEndOfSlowPath):
(JSC::JITDisassembler::setEndOfCode):

4:44 PM Changeset in webkit [135456] by morrita@google.com

3 edits
2 adds in trunk

[Shadow DOM][V8] Assertion failure when shadow host is reclaimed before ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=102893

Reviewed by Kentaro Hara.

Source/WebCore:

Due to bug 88834, shadow hosts can be reclaimed before
corresponding ShadowRoots are. This breaks an invariant, that is,
the host is always available for any ShadowRoot. This change adds
guards for the possibly broken invariant.

Since bug 88834 is planned to be fixed shortly, this change
doesn't aim to fix this problem by make it work correctly, but
just lays a safety net which is needed until the root cause is
gone.

Test: fast/dom/shadow/host-wrapper-reclaimed.html

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML):
(WebCore::ShadowRoot::setApplyAuthorStyles):
(WebCore::ShadowRoot::setResetStyleInheritance):
(WebCore::ShadowRoot::childrenChanged):

LayoutTests:

fast/dom/shadow/host-wrapper-reclaimed-expected.txt: Added.
fast/dom/shadow/host-wrapper-reclaimed.html: Added.

4:28 PM Changeset in webkit [135455] by krit@webkit.org

9 edits
1 move in trunk/Source/WebCore

Make CachedSVGDocumentReference independent of FilterOperation
https://bugs.webkit.org/show_bug.cgi?id=102967

Reviewed by Antti Koivisto.

Make CachedSVGDocumentReference independent of FilterOperation to reuse the code for clip-path and masking.

No new tests, refactoring.

GNUmakefile.list.am: Move CachedSVGDocumentReference to it's proper location and it to the projects.
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):

loader/cache/CachedSVGDocumentReference.h: Renamed from Source/WebCore/css/CachedSVGDocumentReference.h.

(WebCore):
(CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::document):

platform/graphics/filters/FilterOperation.h: Rename data() and setData() to

cachedSVGDocumentReference() and its setter. Adapt other classes.

(WebCore::FilterOperation::ReferenceFilterOperation::cachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(ReferenceFilterOperation):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayerFilterInfo::updateReferenceFilterClients):

4:25 PM Changeset in webkit [135454] by dbates@webkit.org

3 edits
4 adds in trunk

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

Fixes an issue where we inadvertently didn't check the length of
a JavaScript string for overflow.

runtime/Operations.h:

(JSC::jsString):
(JSC::jsStringFromArguments):

LayoutTests:

Add tests to ensure that we handle concatenating large strings.

fast/js/concat-large-strings-crash-expected.txt: Added.
fast/js/concat-large-strings-crash.html: Added.
fast/js/concat-large-strings-crash2-expected.txt: Added.
fast/js/concat-large-strings-crash2.html: Added.

4:20 PM Changeset in webkit [135453] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove #include "ewk_view_private.h" in PageViewportControllerClientEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=102773

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

PageViewportControllerClientEfl.cpp doesn't need to include ewk_view_private.h.

UIProcess/efl/PageViewportControllerClientEfl.cpp:

4:18 PM Changeset in webkit [135452] by simonjam@chromium.org

12 edits in trunk/Source/WebCore

Remove the concept of initiatorDocument from CachedResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=102855

Reviewed by Sam Weinig.

It turns out this isn't necessary for the new implementation of Resource Timing. Instead,
we can get at it from the CachedResourceLoader. I don't think anyone else needed it either.

No new tests. This was never used.

css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::load):

css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::cachedShader):

html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::PreloadTask::preload):

loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setInitiator):

loader/cache/CachedResourceRequest.h:

(CachedResourceRequest):

loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

4:16 PM Changeset in webkit [135451] by fsamuel@chromium.org

2 edits in trunk/LayoutTests

Add fast/events/context-nodrag.html to Chromium Mac TestExpectations

No review.

platform/chromium/TestExpectations:

4:13 PM Changeset in webkit [135450] by simonjam@chromium.org

6 edits
26 adds in trunk/LayoutTests

[Resource Timing] Create W3C-style test suite
https://bugs.webkit.org/show_bug.cgi?id=84883

Reviewed by Tony Gentilcore.

The tests are designed to be upstreamed. Eventually, the local ones will be replaced by the official upstream versions.

http/tests/w3c/webperf/resources/Ahem.ttf: Added.
http/tests/w3c/webperf/resources/all_resource_types.htm: Added.
http/tests/w3c/webperf/resources/blank_image.png: Added.
http/tests/w3c/webperf/resources/empty_script.js: Added.
http/tests/w3c/webperf/resources/generate_resource.php: Added.
http/tests/w3c/webperf/resources/gray_bg.css: Added.

(body):

http/tests/w3c/webperf/resources/green_frame.htm: Added.
http/tests/w3c/webperf/resources/inject_resource_test.html: Added.
http/tests/w3c/webperf/resources/nested.css: Added.

(@font-face):
(ol):

http/tests/w3c/webperf/resources/webperftestharness.js:

(test_greater_or_equals):
(test_fail):
(test_resource_entries):

http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt: Added.
http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html: Added.
platform/chromium/TestExpectations: Skip these new tests until the flag is flipped.

4:03 PM Changeset in webkit [135449] by allan.jensen@digia.com

2 edits in trunk/Source/WebKit/qt

Position in QWebHitTestResult does not match documentation
https://bugs.webkit.org/show_bug.cgi?id=102909

Reviewed by Simon Hausmann.

Correct documentation and simplify using the new innerNodeFrame method.

Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

4:02 PM Changeset in webkit [135448] by fsamuel@chromium.org

2 edits in trunk/LayoutTests

Add fast/events/context-nodrag.html to Mac TestExpectations

No review.

platform/mac/TestExpectations:

4:02 PM Changeset in webkit [135447] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r135437.
http://trac.webkit.org/changeset/135437
https://bugs.webkit.org/show_bug.cgi?id=102986

This patch causes crash to some layout tests (Requested by
jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

4:00 PM Changeset in webkit [135446] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980

Patch by Genevieve Mak <gmak@rim.com> on 2012-11-21
Reviewed by Rob Buis.

Reviewed Internally by George Staikos, Mike Lattanzio and Mike Fenton.
Get rid of unneeded methods and simplify code.
Send click if getting context over an empty text field
so that it will be focused and have a caret.
PR #242781

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::touchEvent):
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPage::touchEventCancel):

Api/WebPage.h:
WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
(BlackBerry::WebKit::TouchEventHandler::sendClickAtFatFingersPoint):
(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
(BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):

WebKitSupport/TouchEventHandler.h:

(TouchEventHandler):

3:32 PM Changeset in webkit [135445] by akling@apple.com

3 edits in trunk/Source/WebCore

Style sharing: Compare class lists via SpaceSplitString instead of string comparison.
<http://webkit.org/b/102982>

Reviewed by Antti Koivisto.

Add an operator!= to SpaceSplitString and use that check if two elements are eligible
for style sharing instead of comparing the fastGetAttribute(classAttr) return values.
This works because SpaceSplitString maps equal strings to the same data internally.

css/StyleResolver.cpp:

(WebCore::haveIdenticalStyleAffectingAttributes):

dom/SpaceSplitString.h:

(WebCore::SpaceSplitString::operator!=):
(SpaceSplitString):

3:30 PM Changeset in webkit [135444] by commit-queue@webkit.org

4 edits
1 add in trunk/LayoutTests

Multi-frame CUR file test hangs on mac port
https://bugs.webkit.org/show_bug.cgi?id=101811

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-21
Reviewed by Alexey Proskuryakov.

Fix tests to not hang on unexpected image load failure.
Expect multi-frame CUR files to fail to load on Mac.

fast/events/mouse-cursor.html:
fast/events/mouse-cursor-multiframecur.html:
platform/mac/TestExpectations:
platform/mac/fast/events/mouse-cursor-multiframecur-expected.txt: Added.

3:21 PM Changeset in webkit [135443] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor changing children code in CoordinatedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102896

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

When changing children, we don't need to sync a layer state because
there is no more need to send the parent ID every time the layer tree
hierarchy changes. So this patch removes didChangeLayerState() in
methods which change children.

In addition, purgeBackingStores() does not need to call didChangeChildren()
because purgeBackingStores() does not change children.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setChildren):
(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::removeFromParent):
(WebCore::CoordinatedGraphicsLayer::purgeBackingStores):

3:09 PM Changeset in webkit [135442] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Use m_webView->size() for viewport update
https://bugs.webkit.org/show_bug.cgi?id=102764

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

m_webView->client()->windowRect() returns the outer rect of the browser
window, which includes the decorations such as the title bar.
We should use the size of the WebView for layout and rendering purpose.

Existing tests are updated to work without windowRect().

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

tests/WebFrameTest.cpp:

3:01 PM Changeset in webkit [135441] by kpiascik@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent screen from dimming on device when inspector front-end is connected
https://bugs.webkit.org/show_bug.cgi?id=102978

Reviewed by Rob Buis.

Internal PR 200848
We prevent screen from going dim when the front-end is connected and return to normal when
the front-end disconnects.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::enableWebInspector):
(BlackBerry::WebKit::WebPage::disableWebInspector):

2:53 PM Changeset in webkit [135440] by commit-queue@webkit.org

21 edits in trunk/Source/WebCore

Unreviewed, rolling out r135338, r135359, and r135378.
http://trac.webkit.org/changeset/135338
http://trac.webkit.org/changeset/135359
http://trac.webkit.org/changeset/135378
https://bugs.webkit.org/show_bug.cgi?id=102981

Likely caused a 10% regression in
dromaeo_domcoreattr/dom_attr_getAttribute (Requested by abarth
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):
(ConvertToV8Parameter):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod3Callback):
(WebCore::TestObjV8Internal::overloadedMethod11Callback):
(WebCore::TestObjV8Internal::overloadedMethod12Callback):
(WebCore::TestObjV8Internal::strictFunctionCallback):
(WebCore::TestObjV8Internal::variadicStringMethodCallback):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor4Callback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

bindings/v8/V8BindingMacros.h:
bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::prepareBase):
(WebCore::V8Parameter::object):
(WebCore::::prepare):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

2:42 PM Changeset in webkit [135439] by commit-queue@webkit.org

3 edits
5 adds in trunk

Invalidate non-composited content host when page scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=100718

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-21
Reviewed by Adam Barth.

During a scale change, non-composited content layer doesn't get invalidated
automatically by the transformation change on RenderView. Need to force
update non-composited contents ourself.

Source/WebCore:

Test: compositing/repaint/page-scale-repaint.html

page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

LayoutTests:

compositing/repaint/page-scale-repaint-expected.png: Added.
compositing/repaint/page-scale-repaint-expected.txt: Added.
compositing/repaint/page-scale-repaint.html: Added.
compositing/repaint/resources/grid.png: Added.

2:40 PM Changeset in webkit [135438] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Yet another EFL & GTK+ build fix after r135429.

html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::create):

2:36 PM Changeset in webkit [135437] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Node::createRenderer should never return null
https://bugs.webkit.org/show_bug.cgi?id=102975

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

Node::createRenderer should never return null, instead Node::rendererIsNeeded
should return false if a node doesn't wish to have a renderer. This method
never actually returns null right now, but the code makes it look like it
could.

No new tests, just refactoring.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):

2:34 PM Changeset in webkit [135436] by fsamuel@chromium.org

6 edits
2 adds in trunk

Clear MousePressed state on context menu to avoid initiating a drag
https://bugs.webkit.org/show_bug.cgi?id=101786

Reviewed by Ojan Vafai.

Source/WebCore:

If a user initiates a drag via left mouse down, brings up the context menu,
and then cancels the context menu while keeping the left mouse button down,
then the drag operation will continue. This does not match the platform
conventions on Windows, Linux or Mac .

This change cancels the drag if the context menu is about to be displayed.

Test: fast/events/context-nodrag.html

page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEvent):

Tools:

DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::EventSender::EventSender):
(WebTestRunner::EventSender::contextClick):
Only send a MouseUp on Windows. Keep the current mouse pressed state when
calling up a context menu.

LayoutTests:

This change cancels the drag if the context menu is about to be displayed.

fast/events/context-nodrag.html: Added.
fast/events/context-nodrag-expected.txt: Added.

2:31 PM Changeset in webkit [135435] by Patrick Gansterer

3 edits
1 delete in trunk/Source/WebCore

Use MIMETypeRegistryWin for WinCE port too
https://bugs.webkit.org/show_bug.cgi?id=102977

Reviewed by Laszlo Gombos.

r135217 made MIMETypeRegistryWin compile on WinCE too,
which allows us to get rid of MIMETypeRegistryWinCE.

PlatformWinCE.cmake:
WebCore.gypi:
platform/wince/MIMETypeRegistryWinCE.cpp: Removed.

2:24 PM Changeset in webkit [135434] by commit-queue@webkit.org

4 edits in trunk

REGRESSION(r135212): Fix crash due to an infinite rect.
https://bugs.webkit.org/show_bug.cgi?id=102891

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Source/WebKit2:

When CoordinatedGraphicsLayer has a 3D transform, tiledBackingStoreVisibleRect()
can calculate an infinite rect. However, TiledBackingStore cannot handle the
infinite rect. This patch clamps the infinite rect to avoid crash in
TiledBackingStore.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::clampToContentsRectIfRectIsInfinite):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):

LayoutTests:

fast/multicol/span/positioned-child-not-removed-crash.html now passes on
EFL.

platform/efl-wk2/TestExpectations:

2:24 PM Changeset in webkit [135433] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

2:21 PM Changeset in webkit [135432] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary ternaries in createRendererIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=102974

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-21
Reviewed by Ojan Vafai.

parentRenderer, nextRenderer and previousRenderer all handle flow
threads automatically so there's no reason to duplicate the check in
createRendererIfNeeded.

Note that while these methods first check the node for a renderer and
then delegate to the flow thread the node never has a renderer when
calling createRendererIfNeeded per the assertion at the top so this
change is equivalent.

No new tests, just refactoring.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererIfNeeded):

2:02 PM Changeset in webkit [135431] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

EFL and GTK+ build fix after r135429.

dom/Element.cpp:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

1:52 PM Changeset in webkit [135430] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations to resolve lint failures.

platform/chromium/TestExpectations:

1:38 PM Changeset in webkit [135429] by rniwa@webkit.org

15 edits in trunk/Source/WebCore

HTMLCollection should use the same storage as DynamicNodeList
https://bugs.webkit.org/show_bug.cgi?id=102886

Reviewed by Antti Koivisto.

This patch removes ElementRareData::m_collection. HTMLCollections are now held by
NodeListNodeData in NodeRareData like DynamicNodeLists. This simplifies several
Element and Node functions where we used to call into both ElementRareData and
NodeRareData to invalidate caches.

This is a refactoring and there should be no behavioral change.

dom/DynamicNodeList.h:
dom/Element.cpp:

(WebCore::ElementRareData::ensureCachedHTMLCollection):

dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::cachedHTMLCollection):
(WebCore::ElementRareData::removeCachedHTMLCollection):

dom/Node.cpp:

(WebCore::Node::invalidateNodeListCachesInAncestors):

dom/NodeRareData.h:

(NodeListsNodeData):
(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::cacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::adoptTreeScope):
(WebCore::NodeListsNodeData::namedNodeListKey):

dom/TreeScopeAdopter.cpp:

(WebCore::TreeScopeAdopter::moveTreeToNewScope):

html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::create):

html/HTMLFormControlsCollection.h:

(HTMLFormControlsCollection):

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::create):

html/HTMLOptionsCollection.h:

(HTMLOptionsCollection::create):

html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection::create):

html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::create):

html/HTMLTableRowsCollection.h:

(HTMLTableRowsCollection):

1:29 PM Changeset in webkit [135428] by akling@apple.com

2 edits in trunk/Source/WebCore

Update incorrect assertion in ImmutableElementAttributeData(MutableElementAttributeData).
<http://webkit.org/b/102972>

Reviewed by Antti Koivisto.

Manipulation by editing code may cause an element to have mutable inline style, and this is fine.

Change the assertion to confirm that the inline style doesn't have a CSSOM wrapper attached,
which is where real problems would happen.

Fixes an assertion on editing/undo/replace-by-span-then-remove.html

dom/ElementAttributeData.cpp:

(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

12:37 PM Changeset in webkit [135427] by kpiascik@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't add empty rects to the tap highlight region.
https://bugs.webkit.org/show_bug.cgi?id=102966

Reviewed by George Staikos.

Internal PR 246960
Tap highlight is way too large sometimes.
When we add an empty rect it inflates by 2 and causes the tap region to extend to the origin.

WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):

12:32 PM ViewportInteractionTopics edited by tmpsantos@gmail.com

(diff)

12:29 PM Changeset in webkit [135426] by haraken@chromium.org

8 edits in trunk

Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

12:24 PM Changeset in webkit [135425] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Source/WTF/wtf/Assertions.cpp: fix build on a uClibc system
https://bugs.webkit.org/show_bug.cgi?id=102946

Patch by Anthony G. Basile <blueness@gentoo.org> on 2012-11-21
Reviewed by Tony Chang.

Webkit-Gtk fails to build on a uClibc system because
Assertions.cpp assumes that all Linux systems have execinfo.h
and provide backtrace(). This is not necessarily the case for
uClibc which can be configured without these. This patch
refines the check for OS(LINUX) to prevent this breakage.
Originally reported at https://bugs.gentoo.org/441674

wtf/Assertions.cpp:

12:13 PM Changeset in webkit [135424] by jsbell@chromium.org

96 edits
3 deletes in trunk

Remove IDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=102514

Reviewed by Adam Barth.

Source/WebCore:

After the WebKit implementation landed, the IndexedDB spec changed from defining new
exception codes with constants hanging off an interface to using DOM4-styled named
DOMExceptions. Remove the IDBDatabaseException interface and set codes for IDB-specific
exceptions to 0. (The .idl file is retained pending general ExceptionCode cleanup.)

Also remove IDBRequest.errorCode which was used for reporting asynchronous errors;
IDBRequest.error - a DOMError - should be used instead.

No new tests - covered by plenty of existing tests which have been updated.

Modules/indexeddb/DOMWindowIndexedDatabase.idl: Don't expose the interface.
Modules/indexeddb/IDBCursor.idl: Remove reference to IDBDatabaseException.
Modules/indexeddb/IDBDatabase.idl: Ditto.
Modules/indexeddb/IDBDatabaseException.cpp:

(IDBDatabaseExceptionNameDescription): Use either a DOMException code or 0.
(WebCore::IDBDatabaseException::initializeDescription):
(WebCore::IDBDatabaseException::getLegacyErrorCode):

Modules/indexeddb/IDBFactory.idl: Remove reference to IDBDatabaseException.
Modules/indexeddb/IDBIndex.idl: Ditto.
Modules/indexeddb/IDBKeyRange.idl: Ditto.
Modules/indexeddb/IDBObjectStore.idl: Ditto.
Modules/indexeddb/IDBRequest.idl: Ditto.
Modules/indexeddb/IDBTransaction.idl: Ditto.
Modules/indexeddb/WorkerContextIndexedDatabase.idl: Don't expose the interface.
bindings/v8/IDBBindingUtilities.cpp: Remove unneeded #include.

LayoutTests:

Remove references to IDBDatabaseException - DOMExceptions should be thrown with code 0 and
a name. Remove references to IDBRequest.errorCode - IDBRequest.error is the new hawtness,
and already tested for. Ensure those objects/properties are gone in removed.html

storage/indexeddb/basics-expected.txt:
storage/indexeddb/basics-workers-expected.txt:
storage/indexeddb/constants.html: Removed.
storage/indexeddb/constants-expected.txt: Removed.
storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/cursor-continue-dir-expected.txt:
storage/indexeddb/cursor-continue-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/deleteIndex-expected.txt:
storage/indexeddb/exceptions-expected.txt:
storage/indexeddb/factory-cmp-expected.txt:
storage/indexeddb/get-keyrange-expected.txt:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-basics-workers-expected.txt:
storage/indexeddb/index-count-expected.txt:
storage/indexeddb/index-unique-expected.txt:
storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/key-generator-expected.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keyrange-expected.txt:
storage/indexeddb/mozilla/add-twice-failure-expected.txt:
storage/indexeddb/mozilla/bad-keypath-expected.txt:
storage/indexeddb/mozilla/clear-expected.txt:
storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
storage/indexeddb/mozilla/readonly-transactions-expected.txt:
storage/indexeddb/mozilla/resources/add-twice-failure.js:
storage/indexeddb/mozilla/resources/bad-keypath.js:
storage/indexeddb/mozilla/resources/clear.js:
storage/indexeddb/mozilla/resources/indexes.js: Elide obsolete comment.
storage/indexeddb/mozilla/resources/key-requirements-delete-null-key.js:
storage/indexeddb/mozilla/resources/key-requirements-inline-and-passed.js:
storage/indexeddb/mozilla/resources/key-requirements-put-no-key.js:
storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
storage/indexeddb/mozilla/resources/readonly-transactions.js:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/objectstore-count-expected.txt:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/readonly-expected.txt:
storage/indexeddb/removed-expected.txt:
storage/indexeddb/resources/basics.js:
storage/indexeddb/resources/constants.js: Removed.
storage/indexeddb/resources/create-and-remove-object-store.js:
storage/indexeddb/resources/cursor-continue-dir.js:
storage/indexeddb/resources/cursor-continue.js:
storage/indexeddb/resources/cursor-update.js:
storage/indexeddb/resources/deleteIndex.js:
storage/indexeddb/resources/exceptions.js:
storage/indexeddb/resources/factory-cmp.js:
storage/indexeddb/resources/get-keyrange.js:
storage/indexeddb/resources/index-basics.js:
storage/indexeddb/resources/index-count.js:
storage/indexeddb/resources/index-unique.js:
storage/indexeddb/resources/intversion-close-in-upgradeneeded.js:
storage/indexeddb/resources/invalid-keys.js:
storage/indexeddb/resources/key-generator.js:
storage/indexeddb/resources/key-type-array.js:
storage/indexeddb/resources/keypath-edges.js:
storage/indexeddb/resources/keyrange.js:
storage/indexeddb/resources/objectstore-autoincrement.js:
storage/indexeddb/resources/objectstore-basics.js:
storage/indexeddb/resources/objectstore-count.js:
storage/indexeddb/resources/open-cursor.js:
storage/indexeddb/resources/readonly.js:
storage/indexeddb/resources/removed.js:
storage/indexeddb/resources/shared.js:
storage/indexeddb/resources/transaction-abort.js:
storage/indexeddb/resources/transaction-active-flag.js:
storage/indexeddb/resources/transaction-basics.js:
storage/indexeddb/resources/transaction-complete-workers.js:
storage/indexeddb/resources/transaction-error.js:
storage/indexeddb/resources/transaction-read-only.js:
storage/indexeddb/transaction-abort-expected.txt:
storage/indexeddb/transaction-active-flag-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-complete-workers-expected.txt:
storage/indexeddb/transaction-error-expected.txt:
storage/indexeddb/transaction-read-only-expected.txt:

12:10 PM Changeset in webkit [135423] by wjmaclean@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Fix indenting in RenderThemeChromiumSkia.h.
https://bugs.webkit.org/show_bug.cgi?id=102965

Reviewed by Adam Barth.

Much of RenderThemeChromiumSkia.h was indented too far, making the
file confusing to read. This CL removes the extra indents.

rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia):

11:52 AM Changeset in webkit [135422] by mifenton@rim.com

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Switch to point instead of VisiblePosition comparison for input bounds check
https://bugs.webkit.org/show_bug.cgi?id=102962

Reviewed by Rob Buis.

PR 247270.

Switch from using VisiblePosition to determine if we are in a node
to a comparison of the field bounds. This fixes the case where
there is no node before the target node to match.

Reviewed Internally by Gen Mak.

WebKitSupport/DOMSupport.cpp:
WebKitSupport/DOMSupport.h:
WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

11:05 AM Changeset in webkit [135421] by akling@apple.com

7 edits in trunk/Source/WebCore

Make it possible for elements with different tag names to share attribute data.
<http://webkit.org/b/102845>

Reviewed by Antti Koivisto.

Allow all elements to share ElementAttributeData with one another. This means that the elements
in this hypothetical markup will all point to the same attribute data:

<div class="foo">

<span class="foo">

<hr class="foo"/>

</span>

</div>

This optimization happens at the expense of an old one. We no longer share attribute data
between elements that have presentation attributes, since they map to different CSS properties
depending on what tag they're attached to. These are mostly used in ye olde web 1.0 content
though, and we should prefer optimizing in favor of modern markup. The global cache for
presentation attribute style in StyledElement.cpp still prevents redundant parsing.

On the upside, excluding elements with presentation attributes from the data cache means that
we can move one pointer (m_presentationAttributeStyle) from ImmutableElementAttributeData
to MutableElementAttributeData.

800kB progression on Membuster3.

dom/Document.h:
dom/Document.cpp:

(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheKey):
(WebCore::Document::cachedImmutableAttributeData):

dom/Element.cpp:

(WebCore::Element::parserSetAttributes):

Don't use the element's tag name in the key for the immutable attribute data cache.

(WebCore::Element::cloneAttributesFromElement):

Prevent cloneNode() from converting mutable attribute data to immutable if it has
presentation attributes.

dom/ElementAttributeData.cpp:

(WebCore::ImmutableElementAttributeData::ImmutableElementAttributeData):

Add an assertion that mutable-to-immutable conversion never happens with presentation
attribute style present.

(WebCore::ElementAttributeData::ElementAttributeData):
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):

dom/ElementAttributeData.h:

(ElementAttributeData):
(MutableElementAttributeData):
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):

Move the RefPtr<StylePropertySet> that holds presentation attribute-derived style
from the common ElementAttributeData base class to MutableElementAttributeData.

dom/StyledElement.cpp:

(WebCore::StyledElement::attributeChanged):

Always dirty the presentation attribute style when a presentation attribute changes.

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

Force promotion to mutable attribute data when it turns out that we need to hang a
StylePropertySet with the presentation attribute style off of it.

10:54 AM Changeset in webkit [135420] by reed@google.com

2 edits in trunk/LayoutTests

update expectations in advance of skia deps roll
https://bugs.webkit.org/show_bug.cgi?id=102964

Reviewed by NOBODY. expectations change only.

platform/chromium/TestExpectations:

10:53 AM Changeset in webkit [135419] by Antti Koivisto

4 edits in trunk/Source/WebCore

Replace NodeRendererFactory class with a function
https://bugs.webkit.org/show_bug.cgi?id=102950

Reviewed by Andreas Kling.

Simplify the code by turning NodeRendererFactory single-use class into function of NodeRenderingContext.

dom/Node.cpp:

(WebCore::Node::createRendererIfNeeded):

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererIfNeeded):

dom/NodeRenderingContext.h:

(NodeRenderingContext):
(WebCore::NodeRenderingContext::style):
(WebCore):

10:52 AM Changeset in webkit [135418] by wjmaclean@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Change default tap highlight color for Chromium Windows & Linux.
https://bugs.webkit.org/show_bug.cgi?id=102939

Reviewed by Adam Barth.

Change default tap highlight colour on Chromium Win/Linux to be 18% black.

rendering/RenderThemeChromiumSkia.h:

(RenderThemeChromiumSkia): Override platformTapHighlightColor() to change default highlight colour.

10:43 AM Changeset in webkit [135417] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] webkit_unit_tests should depend on forwarder2 for Android
https://bugs.webkit.org/show_bug.cgi?id=102934

Reviewed by Tony Chang.

Running webkit_unit_tests and TestWebKitAPI in the WebKit tree will defer
to the test runner used by Chromium, which in turn relies on forwarder2.
forwarder2 will eventually be required by layout tests as well.

WebKitUnitTests.gyp:

10:21 AM Changeset in webkit [135416] by tony@chromium.org

2 edits in trunk/Source/WebCore

Relayout the slider track when a data list is set
https://bugs.webkit.org/show_bug.cgi?id=102851

Reviewed by Ojan Vafai.

Previously, we would relayout the <input>. Once we fix bug 102352, this
causes the slider track to not relayout. It should relayout because it
draws the data list tick marks and needs to provide space for them.

No new tests, not testable until bug 102352 is fixed. Specifically,
fast/forms/datalist/update-range-with-datalist.html reveals the bug.

html/RangeInputType.cpp:

(WebCore::RangeInputType::listAttributeTargetChanged):

10:20 AM Changeset in webkit [135415] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r135409.
http://trac.webkit.org/changeset/135409
https://bugs.webkit.org/show_bug.cgi?id=102959

This patch causes compiling error to Chromium build (Requested
by jianli_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

tests/IDBRequestTest.cpp:

(WebCore::TEST):

10:09 AM Changeset in webkit [135414] by commit-queue@webkit.org

8 edits in trunk/Source

[chromium] Add flag to enable/disable touch adjustment at runtime.
https://bugs.webkit.org/show_bug.cgi?id=102534

Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-21
Reviewed by Antonio Gomes.

Source/WebCore:

Add setting for enabling or disabling touch adjustment. Note that for
touch adjustment to apply, the compile flag must also be enabled. A
compile only option is insufficient as it does not allow developers to
quickly test the impact of touch adjustemnt without recompiling. Nor
does it allow end users to disable touch adjustemnt if they find that
touch adjustment is not working well for a particular site.

No new tests required.

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::handleGestureTap): Move enable check to adjustGesturePosition.
(WebCore::EventHandler::shouldApplyTouchAdjustment): Checks if touch adjustment is enabled.
(WebCore):
(WebCore::EventHandler::adjustGesturePosition): Add check for enabling of touch adjustment.
(WebCore::EventHandler::sendContextMenuEventForGesture): Move enable check to adjustGesturePosition.

page/EventHandler.h:

(EventHandler):

page/Settings.in:

Source/WebKit/chromium:

Add setting for enabling or disabling touch adjustment.
For touch adjustemnt to apply, the compile option must
also be enabled.

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setEnableTouchAdjustment):
(WebKit):

src/WebSettingsImpl.h:

(WebSettingsImpl):

9:58 AM Changeset in webkit [135413] by Philippe Normand

2 edits in trunk/Source/WebCore

Unreviewed, build fix after r135410.

html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addCue): Prevent unused parameter error.

9:34 AM Changeset in webkit [135412] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Ctrl+A closes breakpoint condition editor
https://bugs.webkit.org/show_bug.cgi?id=102906

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-11-21
Reviewed by Pavel Feldman.

Check if e.target has no ancestors with className
"webkit-line-decorations" in DefaultTextEditor._handleKeyDown

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype._handleKeyDown): Add check

9:28 AM Changeset in webkit [135411] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Avoid creating degenerate cubics at corners of rounded rects.
https://bugs.webkit.org/show_bug.cgi?id=102945

Patch by Tom Hudson <tomhudson@chromium.org> on 2012-11-21
Reviewed by Stephen White.

Covered by existing layout tests.

platform/graphics/Path.cpp:

(Path::addBeziersForRoundedRect):

9:18 AM Changeset in webkit [135410] by eric.carlson@apple.com

14 edits
3 adds in trunk/Source/WebCore

In-band text tracks infrastructure
https://bugs.webkit.org/show_bug.cgi?id=102830

Reviewed by Philippe Normand.

Add the infrastructure necessary to allow a port-specific media engine to expose in-band text
tracks.

No new tests, this patch only adds plumbing. Existing tests verify that these changes don't
break existing functionality.

CMakeLists.txt: Add new project files.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState): Call processInbandTextTracks when readyState reaches

HAVE_METADATA

(WebCore::HTMLMediaElement::processInbandTextTracks): Fetch the in-band text tracks from the

media player and processes them.

html/HTMLMediaElement.h:

html/track/InbandTextTrack.cpp: Added.
html/track/InbandTextTrack.h: Added.
html/track/InbandTextTrackPrivate.h: Added.

html/track/TextTrack.h:

(TextTrack):
(WebCore::TextTrack::clearClient): Remove virtual, it is unnecessary
(WebCore::TextTrack::mode): Make virtual so derived classes can override.
(WebCore::TextTrack::setMode): Ditto.

html/track/TextTrackList.cpp:

(TextTrackList::length): Update to deal with in-band tracks.
(TextTrackList::getTrackIndex): Ditto.
(TextTrackList::getTrackIndexRelativeToRenderedTracks): Ditto.
(TextTrackList::item): Ditto.
(TextTrackList::invalidateTrackIndexesAfterTrack): New, invalidate the cached track indexes of

all tracks after another.

(TextTrackList::append): Update to deal with in-band tracks.
(TextTrackList::remove): Update to deal with in-band tracks.
(TextTrackList::scheduleAddTrackEvent): Remove typo.

html/track/TextTrackList.h:

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getTextTracks): New, pass through to the media engine.
(WebCore::MediaPlayer::setTextTrackClient):

platform/graphics/MediaPlayer.h:

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setPreload): Cleanup.
(WebCore::MediaPlayerPrivateInterface::sourceEndOfStream): Ditto.
(WebCore::MediaPlayerPrivateInterface::getTextTracks): New client method.
(WebCore::MediaPlayerPrivateInterface::setTextTrackClient): Ditto.

9:17 AM Changeset in webkit [135409] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

IDBRequestTest needs a v8 context
https://bugs.webkit.org/show_bug.cgi?id=102941

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Jochen Eisinger.

Added v8 context to IDBRequestTest tests.

tests/IDBRequestTest.cpp:

(IDBRequestTest):
(WebKit::IDBRequestTest::IDBRequestTest):
(WebKit::IDBRequestTest::context):
(WebKit::IDBRequestTest::scriptExecutionContext):
(WebKit):
(WebKit::TEST_F):

8:01 AM Changeset in webkit [135408] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] gardening: fast/writing-mode/japanese-ruby-* are flaky
https://bugs.webkit.org/show_bug.cgi?id=102921

Unreviewed gardening: several tests fail if run after any test that
changes font family mappings. Mark them flaky.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

platform/efl-wk2/TestExpectations:

7:58 AM Changeset in webkit [135407] by commit-queue@webkit.org

4 edits in trunk/Source

Source/WebCore: [Qt] MinGW: Explicitly add OpenGL library dependencies
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

Adding the dependencies to WebKit1 is too late, because linking will have already failed. Also make sure that
the we link against OpenGLES1 e.g. for Angle.

WebCore.pri:

Source/WebKit: [Qt] MinGW: Don't add OpenGL library dependencies here
https://bugs.webkit.org/show_bug.cgi?id=102924

Patch by Kai Koehne <kai.koehne@digia.com> on 2012-11-21
Reviewed by Simon Hausmann.

As the comment suggests the dependency is already for WebCore, so add it there instead.

WebKit1.pri:

7:55 AM Changeset in webkit [135406] by peter@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

DEPS:

7:45 AM Changeset in webkit [135405] by allan.jensen@digia.com

25 edits in trunk/Source

Source/WebCore: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Splits the point() method in HitTestResult into two, innerNodeFramePoint and mainFramePoint().
To do this HitTestResult no longer inherits publically from HitTestLocation, which should also
help to later separate the two classes completely.

Many of the call-sites of hitTestResultAtPoint confuses which coordinates the point is in.
These have not have been fixed in this patch, and they should be audited by the individual ports.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::nodesFromRect):

page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::hitTestResultAtPoint):

Set and maintain pointInMainFrame on the HitTestResult.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::HitTestResult):

Construct pointInMainFrame as a copy of pointInInnerNodeFrame. This is correct
for all hit-tests outside of the recursion in EventHandler::hitTestResultAtPoint.

(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::innerNodeFrame):
(WebCore::HitTestResult::append):

rendering/HitTestResult.h:

(WebCore::HitTestLocation::point):
(HitTestResult):

Inherits protected now from HitTestLocation to avoid exposing the ambiguous
point() and roundedPoint() methods.
HitTestResult will be split completely from HitTestLocation in a later patch.

(WebCore::HitTestResult::isRectBasedTest):
(WebCore::HitTestResult::pointInMainFrame):
(WebCore::HitTestResult::roundedPointInMainFrame):
(WebCore::HitTestResult::setPointInMainFrame):
(WebCore::HitTestResult::pointInInnerNodeFrame):
(WebCore::HitTestResult::roundedPointInInnerNodeFrame):
(WebCore::HitTestResult::localPoint):
(WebCore::HitTestResult::setLocalPoint):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

Source/WebKit/chromium: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::mouseDidMoveOverElement):

src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::characterIndexForPoint):

Source/WebKit/efl: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/gtk: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switched to using point in innerNodeFrame. While the use here seems wrong it has been
left functionally unchanged to be fixed by a later patch.

webkit/webkithittestresult.cpp:

(WebKit::kit):

Source/WebKit/mac: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::showContextMenu):

Source/WebKit/qt: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Api/qwebframe.cpp:

(QWebHitTestResultPrivate::QWebHitTestResultPrivate):

Api/qwebpage.cpp:

(QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch):

Source/WebKit/win: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

WebView.cpp:

(WebView::handleContextMenuEvent):

Source/WebKit2: Disambiguate innerNodeFramePoint and mainFramePoint
https://bugs.webkit.org/show_bug.cgi?id=98139

Reviewed by Julien Chaffraix.

Switch to using HitTestResult::innerNodeFrame and HitTestResult::innerNodeFramePoint.

WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::characterIndexForPoint):

7:30 AM Changeset in webkit [135404] by Simon Hausmann

2 edits in trunk/Source/WebKit2

Unreviewed Qt/Windows build fix.
https://bugs.webkit.org/show_bug.cgi?id=102787

Remove inclusion of QtQml, which drags in QtNetwork, which drags in qnetworksession.h, which
defines a member function called "interface". Since windows headers also define a pre-processor
macro called "interface", it has to do that. However we have now a dependency between combaseapi.h,
which #defines interface and is included earlier (before qnetworksession.h) and shlwapi.h, which _needs_
the interface macro and is included afterwards. Since this module-wide QtQml inclusion is unnecessary
and just slows down the build, this patch removes it.

UIProcess/API/qt/qwebkittest_p.h:

7:30 AM Changeset in webkit [135403] by wjmaclean@chromium.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Link highlight should display for at least 100ms, and fadeout on GestureTap/Longpress.
https://bugs.webkit.org/show_bug.cgi?id=102823

Reviewed by Adrienne Walker.

Link highlights sometimes disappear so quickly they barely display. Modify
so that the highlight is displayed for minimum 100ms before fading out, and
also fadeout (as opposed to abrupt clear) on GestureTap and GestureLongPress.

src/LinkHighlight.cpp:

(WebKit::LinkHighlight::LinkHighlight):
(WebKit::LinkHighlight::startHighlightAnimationIfNeeded): Check if min duration achieved, if not add time to fadeout animation.

src/LinkHighlight.h:

(LinkHighlight):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent): Fadeout instead of clear on GestureTap and GestureLongPress.

7:29 AM ViewportInteractionTopics edited by allan.jensen@digia.com

(diff)

7:28 AM ViewportInteractionTopics edited by allan.jensen@digia.com

(diff)

7:26 AM ViewportInteractionTopics edited by allan.jensen@digia.com

(diff)

7:17 AM Changeset in webkit [135402] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Reverted expectation changes from r135380 and marked css3/filters/effect-reference-ordering-hw.html as crashing
https://bugs.webkit.org/show_bug.cgi?id=102898

platform/chromium/TestExpectations:

7:11 AM Changeset in webkit [135401] by commit-queue@webkit.org

6 edits in trunk/Source/WebKit2

Coordinated Graphics: refactor LayerTreeRenderer::syncRemoteContent().
https://bugs.webkit.org/show_bug.cgi?id=102900

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Noam Rosenthal.

Currently, QQuickWebPage::updatePaintNode() calls
LayerTreeRenderer::syncRemoteContent() with locking the main thread.
syncRemoteContent() is heavy, so we should not call syncRemoteContent() in
updatePaintNode(). Calling syncRemoteContent() in the painting thread is
thread-safe because syncRemoteContent() does not access any data
structures, which the main thread use.

After this patch, syncRemoteContent() is used only internally, so
syncRemoteContent() becomes private.

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::displayTimerFired):

UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPage::updatePaintNode):

UIProcess/API/qt/raw/qrawwebview.cpp:

(QRawWebView::paint):

UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::paintToCurrentGLContext):
(WebKit::LayerTreeRenderer::ensureRootLayer):

UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

7:10 AM Changeset in webkit [135400] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening: svg/foreignObject/viewport-foreignobject-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=102931

Unreviewed gardening.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

platform/efl/TestExpectations:

7:08 AM Changeset in webkit [135399] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

[WK2] Viewport meta tag broken after r134801
https://bugs.webkit.org/show_bug.cgi?id=102801

Reviewed by Kenneth Rohde Christiansen.

If the initial-scale attribute is not explicitly specified it is left -1 by the
viewport meta algorithm and if the content is not scalable the min and max scales
are restricted by restrictScaleFactorToInitialScaleIfNotUserScalable() which resulted
in negative scales on the UI side.
Make sure that the minimum scale to fit the viewport is calculated before restricting
the scales and use this scale as the initial scale if no explicit initial scale was set.

UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

7:07 AM Changeset in webkit [135398] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
https://bugs.webkit.org/show_bug.cgi?id=102895

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Change the link order so it wont override the new operator on gtest.
Looks like it was crashing because an allocator mismatch (using libc's
new and later fastMalloc delete. Thanks to Kangil Han for hinting on
the fastMalloc issue.

TestWebKitAPI/CMakeLists.txt:

6:46 AM Changeset in webkit [135397] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Now that offending patch has been rolled out reenable IDBRequestTest.EventsAfterStopping
https://bugs.webkit.org/show_bug.cgi?id=102929

tests/IDBRequestTest.cpp:

(WebCore::TEST):

6:40 AM Changeset in webkit [135396] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r135383.
http://trac.webkit.org/changeset/135383
https://bugs.webkit.org/show_bug.cgi?id=102935

IDBRequestTest.* unit tests are failing (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

6:32 AM WebKitEFLLayoutTest edited by tmpsantos@gmail.com

(diff)

6:30 AM WebKitEFLLayoutTest edited by tmpsantos@gmail.com

(diff)

6:27 AM Changeset in webkit [135395] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

Unreviewed gardening, unskip a now passing test.

platform/mac-wk2/TestExpectations:
platform/qt-5.0-wk2/TestExpectations:

6:24 AM Changeset in webkit [135394] by gyuyoung.kim@samsung.com

9 edits
12 adds in trunk/Source

[EFL][WK2] Support Context Menu
https://bugs.webkit.org/show_bug.cgi?id=96200

Reviewed by Laszlo Gombos.

Source/WebCore:

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):
EFL port also doesn't hide unavailable menus as gtk port.

Source/WebKit2:

This patch supports WK2 EFL's context menu as WK1 implementation because we can't use elementary in inside WebKit.
Only basic functionalities of context menu are supported. Beside this implementation follows GTK's implementation.
For example, ewk_context_menu_new, ewk_context_menu_item_append, ewk_context_menu_item_remove are supported.

In addition, ewk_defines.h file is added in order to support cross inclusion as GTK port.

PlatformEfl.cmake:
UIProcess/API/efl/EWebKit2.h:
UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::showContextMenu):
(EwkViewImpl::hideContextMenu):

UIProcess/API/efl/EwkViewImpl.h:

(WebKit):
(EwkViewImpl):

UIProcess/API/efl/ewk_context_menu.cpp: Added.

(EwkContextMenu::EwkContextMenu):
(EwkContextMenu::~EwkContextMenu):
(EwkContextMenu::hide):
(Ewk_Context_Menu::appendItem):
(Ewk_Context_Menu::removeItem):
(EwkContextMenu::contextMenuItemSelected):
(ewk_context_menu_new):
(ewk_context_menu_new_with_items):
(ewk_context_menu_item_append):
(ewk_context_menu_item_remove):
(ewk_context_menu_hide):
(ewk_context_menu_items_get):
(ewk_context_menu_item_select):

UIProcess/API/efl/ewk_context_menu.h: Added.
UIProcess/API/efl/ewk_context_menu_item.cpp: Added.

(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new):
(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_type_get):
(ewk_context_menu_item_type_set):
(ewk_context_menu_item_action_get):
(ewk_context_menu_item_action_set):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_title_set):
(ewk_context_menu_item_checked_get):
(ewk_context_menu_item_checked_set):
(ewk_context_menu_item_enabled_get):
(ewk_context_menu_item_enabled_set):

UIProcess/API/efl/ewk_context_menu_item.h: Added.
UIProcess/API/efl/ewk_context_menu_item_private.h: Added.

(EwkContextMenuItem):
(EwkContextMenuItem::create):
(EwkContextMenuItem::action):
(EwkContextMenuItem::setAction):
(EwkContextMenuItem::title):
(EwkContextMenuItem::setTitle):
(EwkContextMenuItem::type):
(EwkContextMenuItem::setType):
(EwkContextMenuItem::checked):
(EwkContextMenuItem::setChecked):
(EwkContextMenuItem::enabled):
(EwkContextMenuItem::setEnabled):

UIProcess/API/efl/ewk_context_menu_private.h: Added.

(WebKit):
(EwkContextMenu):
(EwkContextMenu::create):
(EwkContextMenu::items):

UIProcess/API/efl/ewk_defines.h: Added.
UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/test_ewk2_context_menu.cpp: Added.

(checkBasicContextMenuItem):
(showContextMenu):
(TEST_F):

UIProcess/efl/ContextMenuClientEfl.cpp: Added.

(toContextClientEfl):
(ContextMenuClientEfl::ContextMenuClientEfl):
(ContextMenuClientEfl::getContextMenuFromProposedMenu):

UIProcess/efl/ContextMenuClientEfl.h: Added.

(WebKit):
(ContextMenuClientEfl):
(WebKit::ContextMenuClientEfl::create):

UIProcess/efl/PageClientBase.cpp:

(WebKit::PageClientBase::createContextMenuProxy):

UIProcess/efl/WebContextMenuProxyEfl.cpp: Added.

(WebKit):
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::~WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::showContextMenu):
(WebKit::WebContextMenuProxyEfl::hideContextMenu):
(WebKit::WebContextMenuProxyEfl::contextMenuItemSelected):

UIProcess/efl/WebContextMenuProxyEfl.h: Added.

(WebKit):
(WebContextMenuProxyEfl):
(WebKit::WebContextMenuProxyEfl::create):

6:03 AM Changeset in webkit [135393] by fmalita@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Unreviewed Mac build fix after http://trac.webkit.org/changeset/135390.

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::drawInnerPath):

5:53 AM Changeset in webkit [135392] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL][WK2] Gardening: css3/device-adapt/opera/constrain-006 and -007 fail
https://bugs.webkit.org/show_bug.cgi?id=102923

Unreviewed gardening: these two still fail after using fixed layout in WTR.

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-21

platform/efl-wk2/TestExpectations:

5:45 AM Changeset in webkit [135391] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Disable failing test.
https://bugs.webkit.org/show_bug.cgi?id=102929

tests/IDBRequestTest.cpp:

(WebCore::TEST):

5:42 AM Changeset in webkit [135390] by fmalita@chromium.org

20 edits in trunk/Source

[Skia] Encapsulate access to PlatformContextSkia's SkCanvas
https://bugs.webkit.org/show_bug.cgi?id=102694

Reviewed by Stephen White.

Source/WebCore:

Add SkCanvas-equivalent methods to PlatformContextSkia, and refactor direct canvas call
sites to use these wrappers instead. This reduces the number of canvas() users from 90+
to 22 (mostly theme/ui code).

No new tests: refactoring only.

platform/chromium/PlatformThemeChromiumLinux.cpp:

(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

platform/graphics/chromium/FontChromiumWin.cpp:
platform/graphics/chromium/TransparencyWin.cpp:

(WebCore::TransparencyWin::computeLayerSize):
(WebCore::TransparencyWin::compositeOpaqueComposite):
(WebCore::TransparencyWin::compositeTextComposite):
(WebCore::TransparencyWin::makeLayerOpaque):

platform/graphics/filters/skia/FEBlendSkia.cpp:

(WebCore::FEBlend::platformApplySkia):

platform/graphics/filters/skia/FEColorMatrixSkia.cpp:

(WebCore::FEColorMatrix::platformApplySkia):

platform/graphics/filters/skia/FEComponentTransferSkia.cpp:

(WebCore::FEComponentTransfer::platformApplySkia):

platform/graphics/filters/skia/FELightingSkia.cpp:

(WebCore::FELighting::platformApplySkia):

platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::drawGlyphs):
(WebCore::Font::drawComplexText):

platform/graphics/skia/FontSkia.cpp:

(WebCore::Font::drawGlyphs):

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::drawOuterPath):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::platformFillEllipse):
(WebCore::GraphicsContext::platformStrokeEllipse):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

platform/graphics/skia/ImageSkia.cpp:

(WebCore::drawResampledBitmap):
(WebCore::hasNon90rotation):
(WebCore::paintSkBitmap):
(WebCore::Image::drawPattern):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::save):
(WebCore::PlatformContextSkia::beginLayerClippedToImage):
(WebCore::PlatformContextSkia::restore):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::couldUseLCDRenderedText):

platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):
(WebCore::PlatformContextSkia::layerBitmap):
(WebCore):
(WebCore::PlatformContextSkia::readPixels):
(WebCore::PlatformContextSkia::writePixels):
(WebCore::PlatformContextSkia::isDrawingToLayer):
(WebCore::PlatformContextSkia::isVector):
(WebCore::PlatformContextSkia::clipPath):
(WebCore::PlatformContextSkia::clipRect):
(WebCore::PlatformContextSkia::getClipBounds):
(WebCore::PlatformContextSkia::setMatrix):
(WebCore::PlatformContextSkia::getTotalMatrix):
(WebCore::PlatformContextSkia::concat):
(WebCore::PlatformContextSkia::rotate):
(WebCore::PlatformContextSkia::scale):
(WebCore::PlatformContextSkia::translate):
(WebCore::PlatformContextSkia::drawBitmap):
(WebCore::PlatformContextSkia::drawBitmapRect):
(WebCore::PlatformContextSkia::drawOval):
(WebCore::PlatformContextSkia::drawPath):
(WebCore::PlatformContextSkia::drawPoints):
(WebCore::PlatformContextSkia::drawRect):
(WebCore::PlatformContextSkia::drawIRect):
(WebCore::PlatformContextSkia::drawPosText):
(WebCore::PlatformContextSkia::drawPosTextH):
(WebCore::PlatformContextSkia::drawTextOnPath):

platform/graphics/skia/SkiaFontWin.cpp:

(WebCore::skiaDrawText):
(WebCore::paintSkiaText):

platform/graphics/skia/SkiaUtils.cpp:

(WebCore::ClipRectToCanvas):

platform/graphics/skia/SkiaUtils.h:

(WebCore):

Source/WebKit/chromium:

Use PlatformContextSkia's wrapper methods instead of accessing the canvas directly.

tests/TransparencyWinTest.cpp:

(WebCore::getPixelAt):
(WebCore::clearTopLayerAlphaChannel):
(WebCore::clearTopLayerAlphaPixel):
(WebCore::TEST):

5:32 AM Changeset in webkit [135389] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip s now passing test.

platform/qt-5.0-wk2/TestExpectations:
platform/qt/TestExpectations:

5:24 AM Changeset in webkit [135388] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Reset the slider thumb location before every layout of the slider container
https://bugs.webkit.org/show_bug.cgi?id=102817

Reviewed by Tony Chang.

The location of the slider thumb is set by the slider container
assuming the slider thumb has been laid out. When this happens,
the location of the slider thumb is reset during the layout
ignoring any previous location set. If the slider thumb is not
laid out, the previous value is added to the new one by the slider
container.

html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::layout): Reset the location of
the slider thumb before calling RenderFlexibleBox::layout().

5:00 AM Changeset in webkit [135387] by haraken@chromium.org

9 edits in trunk

Unreviewed, rolling out r135340.
http://trac.webkit.org/changeset/135340
https://bugs.webkit.org/show_bug.cgi?id=102492

It broke Safari's internal build

Source/WebCore:

bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

Tools:

WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):
(GenerateModule):
(GenerateInterface):
(finish):

4:37 AM Changeset in webkit [135386] by pfeldman@chromium.org

5 edits in trunk

Web Inspector: reparenting view does not detach from the previous parent.
https://bugs.webkit.org/show_bug.cgi?id=102902

Reviewed by Vsevolod Vlasov.

Source/WebCore:

inspector/front-end/View.js:

(WebInspector.View.prototype.show):

LayoutTests:

inspector/view-events.html:

4:30 AM Changeset in webkit [135385] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt-5.0/TestExpectations:

4:26 AM Changeset in webkit [135384] by loislo@chromium.org

11 edits in trunk/Source/WebCore

Web Inspector: NMI add instrumentation to widely used ActiveDOMObjects. XMLHttpRequest, Prerenderer, HTMLMediaElement and DOMTimer.
https://bugs.webkit.org/show_bug.cgi?id=102818

Reviewed by Vsevolod Vlasov.

Our test bot counts pointers which don't match with objects allocated by tcmalloc.
This counter becomes nonzero after instrumenting ActiveDOMObject class.
It happens because it is the base class for many other classes (~30).
And almost all these classes use multiple inheritance.

dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

dom/DocumentEventQueue.cpp:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::reportMemoryUsage):
(WebCore):

html/HTMLMediaElement.h:
loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):
(WebCore):

loader/Prerenderer.h:

(Prerenderer):

page/DOMTimer.cpp:

(WebCore::DOMTimer::reportMemoryUsage):
(WebCore):

page/DOMTimer.h:

(DOMTimer):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::reportMemoryUsage):
(WebCore):

xml/XMLHttpRequest.h:

(XMLHttpRequest):

4:24 AM Changeset in webkit [135383] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[V8] Add context checks to WorldContextHandle and V8DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=101573

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Added a bunch of assertions to ensure the problems with IndexedDB
contexts cannot reemerge.

No new tests. No change in functionality.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore):
(WebCore::V8DOMWindowShell::assertContextHasCorrectPrototype):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):
(WebCore::V8DOMWindowShell::isolated):

bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

4:19 AM Changeset in webkit [135382] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test, update an expected file.

platform/qt-5.0/TestExpectations:
platform/qt-5.0/editing/selection/click-left-of-rtl-wrapping-text-expected.txt:

4:04 AM Changeset in webkit [135381] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt/TestExpectations:

3:57 AM Changeset in webkit [135380] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Mark css3/filters/effect-reference-ordering-hw.html as crashing after crrev.com/168998

platform/chromium/TestExpectations:

3:56 AM FeatureFlags edited by tkent@chromium.org

Don't use https for lists.webkit.org (diff)

3:48 AM Changeset in webkit [135379] by commit-queue@webkit.org

5 edits in trunk/Source

WebMediaStreamComponent: Add assignment and copy operators
https://bugs.webkit.org/show_bug.cgi?id=102915

Patch by Harald Alvestrand <hta@google.com> on 2012-11-21
Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebMediaStreamComponent.h:

(WebKit::WebMediaStreamComponent::WebMediaStreamComponent):
(WebKit::WebMediaStreamComponent::operator=):
(WebMediaStreamComponent):

Source/WebCore:

Tests that use this functionality are being submitted to Chrome.

platform/chromium/support/WebMediaStreamComponent.cpp:

(WebKit::WebMediaStreamComponent::assign):
(WebKit):

platform/chromium/support/WebMediaStreamDescriptor.cpp:

3:43 AM Changeset in webkit [135378] by haraken@chromium.org

21 edits in trunk/Source/WebCore

[V8] Remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
https://bugs.webkit.org/show_bug.cgi?id=102917

Reviewed by Adam Barth.

Now EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
are equivalent. We can remove STRING_TO_V8PARAMETER_EXCEPTION_BLOCK().
To make a code generate change smaller, this patch also renames
STRING_TO_V8PARAMETER_EXCEPTION_BLOCK_VOID() to EXCEPTION_BLOCK_VOID().
I will rename these macros in a follow-up patch.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateEventConstructorCallback):
(ConvertToV8Parameter):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageCallback):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionCallback):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

bindings/scripts/test/V8/V8TestInterface.cpp:

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor4Callback):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

bindings/v8/V8BindingMacros.h:
bindings/v8/V8StringResource.h:

(V8Parameter):

bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::profileCallback):
(WebCore::V8Console::profileEndCallback):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallback):

bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getExtensionCallback):

3:38 AM ViewportInteractionTopics edited by kenneth@webkit.org

(diff)

3:25 AM Changeset in webkit [135377] by haraken@chromium.org

4 edits
2 adds in trunk/Source/WebCore

[V8] Move V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer
https://bugs.webkit.org/show_bug.cgi?id=102899

Reviewed by Adam Barth.

This is an incremental step to kill WorkerContextExecutionProxy.
As commented by abarth in bug 97066, we move
V8DOMWindowShell::initializeV8IfNeeded() to V8Initializer.
This patch renames initializeV8IfNeeded() to initializeMainThreadIfNeeded()
because we will add initializeWorkerIfNeeded() in a follow-up patch.

No tests. No change in behavior.

UseV8.cmake:
WebCore.gypi:
bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8Initializer.cpp: Added.

(WebCore):
(WebCore::findFrame):
(WebCore::reportFatalError):
(WebCore::reportUncaughtException):
(WebCore::reportUnsafeJavaScriptAccess):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):

bindings/v8/V8Initializer.h: Added.

(WebCore):
(V8Initializer):

3:23 AM Changeset in webkit [135376] by Csaba Osztrogonác

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip a now passing test.

platform/qt-5.0-wk2/TestExpectations:
platform/qt/TestExpectations:

3:14 AM Changeset in webkit [135375] by gyuyoung.kim@samsung.com

5 edits in trunk

[EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
https://bugs.webkit.org/show_bug.cgi?id=101526

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Separate out ENABLE_WEBGL. It is not ready to be enabled by default.

Source/cmake/OptionsEfl.cmake:

Tools:

Reviewed by Kenneth Rohde Christiansen.

Turn on WTF_USE_TILED_BACKING_STORE for EFL port.

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.

3:00 AM Changeset in webkit [135374] by apavlov@chromium.org

5 edits in trunk

Turn -webkit-text-emphasis into a shorthand property
https://bugs.webkit.org/show_bug.cgi?id=102879

Reviewed by Antti Koivisto.

Source/WebCore:

-webkit-text-emphasis value is no longer empty.

css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue): Reconstruct the -webkit-text-emphasis value based on the longhands.

LayoutTests:

Update expected results.

fast/css/parsing-text-emphasis-expected.txt:
fast/css/parsing-text-emphasis.html:

3:00 AM Changeset in webkit [135373] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-1.11.2

Tagging the WebKitGTK+ 1.11.2 release

2:55 AM Changeset in webkit [135372] by commit-queue@webkit.org

6 edits in trunk

[EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
https://bugs.webkit.org/show_bug.cgi?id=102867

Patch by Jongseok Yang <js45.yang@samsung.com> on 2012-11-21
Reviewed by Gyuyoung Kim.

Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.

ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.

Source/WebKit2:

UIProcess/API/efl/ewk_view.cpp:

(ewk_view_encoding_custom_get):
(ewk_view_encoding_custom_set):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

Tools:

MiniBrowser/efl/main.c:

(on_key_down):

2:54 AM Changeset in webkit [135371] by tkent@chromium.org

8 edits
9 copies in branches/chromium/1312

Merge 135131 - input.value="" should clear date/time input elements with partial values
https://bugs.webkit.org/show_bug.cgi?id=102645

Reviewed by Kentaro Hara.

Source/WebCore:

Tests: fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html

fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html
fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::setValue):
If the new value is an empty string and sub-fields has values, we should
update the UI value to the empty state.

html/DateTimeFieldsState.h:

(WebCore::DateTimeFieldsState::hasAnyValue):
Added. It returns true if one or more sub-fields are not empty.

LayoutTests:

Add tests for each of date/time input types.
Add them to TextExpectations for platforms without ENABLE_INPUT_MULTIPLE_FIELDS_UI.

fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Added.
fast/forms/resources/multiple-fields-value-set-empty.js: Added.
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Added.
fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Added.
platform/chromium-android/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:

TBR=tkent@chromium.org
Review URL: https://codereview.chromium.org/11421028

2:50 AM Changeset in webkit [135370] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, unskip now passing tests.

platform/qt-5.0-wk2/TestExpectations:

2:36 AM Changeset in webkit [135369] by haraken@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Build fix.

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

2:24 AM Changeset in webkit [135368] by haraken@chromium.org

3 edits
3 moves in trunk/Source/WebCore

[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

UseV8.cmake: This file is already out of sync.
WebCore.gypi:
bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

2:19 AM Changeset in webkit [135367] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[V8] Inspector does not callback IDB methods in context
https://bugs.webkit.org/show_bug.cgi?id=101725

Patch by Dan Carney <dcarney@google.com> on 2012-11-21
Reviewed by Adam Barth.

Inserted v8 context before calling out to IDB.

No new tests.

inspector/InspectorIndexedDBAgent.cpp:

(WebCore::InspectorIndexedDBAgent::requestDatabaseNamesForFrame):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):

2:17 AM Changeset in webkit [135366] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(134048): TiledBackingStore must create tiles when the contents rect is changed.
https://bugs.webkit.org/show_bug.cgi?id=102035

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-21
Reviewed by Kenneth Rohde Christiansen.

Before r134048, the visibleRect contained information of both the viewport and
the contents rect. Now the visible rect is related to only the viewport. So
TiledBackingStore::coverWithTilesIfNeeded() early returns even if the contents
rect is changed, because changing the contents rect is independent on changing
both a trajectory vector and the visible rect.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::coverWithTilesIfNeeded):

2:12 AM Changeset in webkit [135365] by dgrogan@chromium.org

6 edits in trunk/LayoutTests

IndexedDB: remove setVersion from inspector tests
https://bugs.webkit.org/show_bug.cgi?id=102850

Reviewed by Vsevolod Vlasov.

setVersion was contained so the conversion to upgradeneeded was
straightforward.

http/tests/inspector/indexeddb/database-data-expected.txt:
http/tests/inspector/indexeddb/database-structure-expected.txt:
http/tests/inspector/indexeddb/indexeddb-test.js:

(.request.onsuccess.onSuccess.request.onupgradeneeded):
(.request.onsuccess.onSuccess.request.onsuccess):
(.request.onsuccess):
(doWithVersionTransaction):

http/tests/inspector/indexeddb/resources-panel-expected.txt:

1:56 AM Changeset in webkit [135364] by commit-queue@webkit.org

10 edits
1 add in trunk/LayoutTests

Unreviewed, rolling out r135307.
http://trac.webkit.org/changeset/135307
https://bugs.webkit.org/show_bug.cgi?id=102905

Jussi said this doesn't definitively fix things, so revert for
now. (Requested by rakuco on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-21

animations/resources/stop-animation-on-suspend-subframe.html:
animations/stop-animation-on-suspend.html:
platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt-arm/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

1:39 AM Changeset in webkit [135363] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Request preview tuning: enable json preview for text/html XHRs
https://bugs.webkit.org/show_bug.cgi?id=102892

Reviewed by Alexander Pavlov.

inspector/front-end/RequestPreviewView.js:

(WebInspector.RequestPreviewView.prototype._jsonView):
(WebInspector.RequestPreviewView.prototype._htmlView):
(WebInspector.RequestPreviewView.prototype._createPreviewView):

1:38 AM Changeset in webkit [135362] by haraken@chromium.org

7 edits in trunk/Source/WebCore

[V8] Remove manually written v8::TryCatches in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=102883

Reviewed by Adam Barth.

We can replace them with the EXCEPTION_BLOCK() macro or its friends.

No new tests. This patch shouldn't change any behavior.

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

1:26 AM Changeset in webkit [135361] by haraken@chromium.org

3 edits
5 moves in trunk/Source/WebCore

Unreviewed, rolling out r135358.
http://trac.webkit.org/changeset/135358
https://bugs.webkit.org/show_bug.cgi?id=102881

It broke Chromium/Linux build

UseV8.cmake:
WebCore.gypi:
bindings/v8/custom/V8HTMLImageElementConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.cpp.

(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

bindings/v8/custom/V8HTMLImageElementConstructor.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementCustom.h.

(WebCore):
(V8HTMLImageElementConstructor):

bindings/v8/custom/V8IntentConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentCustom.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8MessageChannelConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8WebKitPointConstructor.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointCustom.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

1:09 AM Changeset in webkit [135360] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unused parameters on ScrollingCoordinator.cpp
https://bugs.webkit.org/show_bug.cgi?id=102884

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-21
Reviewed by Kentaro Hara.

Because the 'scrollingLayerPositionAction' parameter is not used when !USE(ACCELERATED_COMPOSITING),
use UNUSED_PARAM macro to fix build warning -Wunused-parameter

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateMainFrameScrollPosition):

1:08 AM Changeset in webkit [135359] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] Replace V8Parameter::prepare() with V8Parameter::operator=()
https://bugs.webkit.org/show_bug.cgi?id=102870

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.
By replacing V8Parameter::prepare() with V8Parameter::operator=(),
we can make EXCEPTION_BLOCK() and STRING_TO_V8PARAMETER_EXCEPTION_BLOCK()
equivalent (except for a return value).

Tests: fast/workers/worker-constructor.html

storage/websql/sql-error-codes.html
inspector/console/alert-toString-exception.html
http/tests/websocket/tests/hybi/send-throw.html

bindings/v8/V8BindingMacros.h:
bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::=):

1:06 AM Changeset in webkit [135358] by haraken@chromium.org

3 edits
5 moves in trunk/Source/WebCore

[V8] Rename v8/custom/*Constructor.cpp to v8/custom/*Custom.cpp
https://bugs.webkit.org/show_bug.cgi?id=102881

Reviewed by Adam Barth.

Writing constructorCallback()s in *Custom.cpp is a convention of
custom bindings of JSC and V8. We can rename v8/custom/*Constructor.cpp
to v8/custom/*Custom.cpp.

No tests. No change in behavior.

UseV8.cmake: This file is already out of sync.
WebCore.gypi:
bindings/v8/custom/V8HTMLImageElementCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.cpp.

(WebCore):
(WebCore::v8HTMLImageElementConstructorCallback):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

bindings/v8/custom/V8HTMLImageElementCustom.h: Renamed from Source/WebCore/bindings/v8/custom/V8HTMLImageElementConstructor.h.

(WebCore):
(V8HTMLImageElementConstructor):

bindings/v8/custom/V8IntentCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8IntentConstructor.cpp.

(WebCore):
(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8MessageChannelCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8MessageChannelConstructor.cpp.

(WebCore):
(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8WebKitPointCustom.cpp: Renamed from Source/WebCore/bindings/v8/custom/V8WebKitPointConstructor.cpp.

(WebCore):
(WebCore::V8WebKitPoint::constructorCallbackCustom):

1:04 AM Changeset in webkit [135357] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] throttle wait icon in the ui
https://bugs.webkit.org/show_bug.cgi?id=102685

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-21
Reviewed by Vsevolod Vlasov.

Do not show the wait icon for small operations during the replay to reduce flickering.

inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype._enableWaitIcon):

12:51 AM Changeset in webkit [135356] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated test expectations.

platform/chromium/TestExpectations:

12:23 AM Changeset in webkit [135355] by commit-queue@webkit.org

4 edits
1 delete in trunk

Enable datalist UI for input types datetime and datetime-local
https://bugs.webkit.org/show_bug.cgi?id=102882

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-21
Reviewed by Kent Tamura.

Source/WebCore:

Enabling datalist UI for input types datetime and datetime-local.

No new tests yet. Tests will be added later in Bug 102888.

platform/text/PlatformLocale.cpp:

(WebCore::Locale::formatDateTime): Support datetime and datetime-local types.

rendering/RenderThemeChromiumCommon.cpp:

(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Add datetime and datetimelocal to the list.

LayoutTests:

Removed expectation of failure.

platform/chromium/fast/forms/datalist/input-list-expected.txt: Removed.

Nov 20, 2012:

10:50 PM Changeset in webkit [135354] by haraken@chromium.org

4 edits
1 delete in trunk/Source/WebCore

[V8] Remove v8/custom/V8XMLHttpRequestConstructor.cpp
https://bugs.webkit.org/show_bug.cgi?id=102876

Reviewed by Sam Weinig.

It doesn't make sense to have one custom cpp file for
XXX::constructorCallback() only. We can move XXX::constructorCallback()
in v8/custom/V8XXXConstructor.cpp to v8/custom/V8XXXCustom.cpp
and thus remove v8/custom/V8XXXConstructor.cpp.

Note: Some XXX::constructorCallback()s are already written in
v8/custom/V8XXXCustom.cpp. JSC already has almost all
XXX::constructorCallback()s in js/JSXXXCustom.cpp.

No tests. No change in behavior.

UseV8.cmake:
WebCore.gypi:
bindings/v8/custom/V8XMLHttpRequestConstructor.cpp: Removed.
bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):
(WebCore):

10:48 PM Changeset in webkit [135353] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Fixed webkit_lint complaints about overlapping entries in Chromium TestExpectations.

platform/chromium/TestExpectations:

10:10 PM Changeset in webkit [135352] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed morning gardening, skip a new security
timeouting test to paint the bots green.

platform/qt/TestExpectations:

10:07 PM Changeset in webkit [135351] by haraken@chromium.org

16 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
bindings/scripts/test/CPP/WebDOMTestException.cpp:
bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
bindings/scripts/test/CPP/WebDOMTestNode.cpp:
bindings/scripts/test/CPP/WebDOMTestObj.cpp:
bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateVoidCallback):
(WebCore::TestObjV8Internal::withScriptStateObjCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesCallback):

10:05 PM Changeset in webkit [135350] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r133859.
http://trac.webkit.org/changeset/133859
https://bugs.webkit.org/show_bug.cgi?id=102875

This patch makes API test broken (Requested by gyuyoung on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

Source/cmake/OptionsEfl.cmake:

Tools:

Scripts/webkitperl/FeatureList.pm:

9:32 PM Changeset in webkit [135349] by commit-queue@webkit.org

23 edits in trunk/Source/WebKit2

[EFL][WK2] Remove unnecessary #include in API test
https://bugs.webkit.org/show_bug.cgi?id=102674

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Laszlo Gombos.

Removed duplicated header files from the API test cases.
Now, EWK2UnitTestBase.h includes the basic header files,
so test cases may only include this one and add the addtional
header files if necessary.

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.h:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestMain.cpp:
UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:
UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
UIProcess/API/efl/tests/test_ewk2_context.cpp:
UIProcess/API/efl/tests/test_ewk2_context_history_callbacks.cpp:
UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_database_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_download_job.cpp:
UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:
UIProcess/API/efl/tests/test_ewk2_favicon_database.cpp:
UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
UIProcess/API/efl/tests/test_ewk2_intents.cpp:
UIProcess/API/efl/tests/test_ewk2_object.cpp:
UIProcess/API/efl/tests/test_ewk2_popup_menu.cpp:
UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp:
UIProcess/API/efl/tests/test_ewk2_settings.cpp:
UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp:
UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
UIProcess/API/efl/tests/test_ewk2_view.cpp:

9:26 PM Changeset in webkit [135348] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL][WK2][WTR] Unskip passed cases under css3/device-adapt/opera/
https://bugs.webkit.org/show_bug.cgi?id=102868

Unreviewed, EFL gardening.

As BUG 102517 has been resolved, we can move those from EFL common to WK1 only.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-20

platform/efl-wk1/TestExpectations:
platform/efl/TestExpectations:

9:23 PM Changeset in webkit [135347] by weinig@apple.com

11 edits in trunk/Source/WebKit2

Simplify WebConnection by removing its underlying CoreIPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=102771

Reviewed by Anders Carlsson.

Instead of having WebConnection subclasses own the CoreIPC::Connection,
move back to having the WebProcess and WebProcessProxy own it (and be
its Connection::Client) and use the new MessageReceiver class to vend
messages to the WebConnection.

Shared/WebConnection.cpp:

(WebKit::WebConnection::WebConnection):
(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::didClose):
(WebKit::WebConnection::didReceiveMessage):

Shared/WebConnection.h:

Make WebConnection both a MessageReceiver and MessageSender
and add virtual functions for derived classes to fill in.

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::create):
(WebKit::WebConnectionToWebProcess::WebConnectionToWebProcess):
(WebKit::WebConnectionToWebProcess::invalidate):
(WebKit::WebConnectionToWebProcess::decodeMessageBody):
(WebKit::WebConnectionToWebProcess::connection):
(WebKit::WebConnectionToWebProcess::destinationID):
(WebKit::WebConnectionToWebProcess::hasValidConnection):

UIProcess/WebConnectionToWebProcess.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::fromConnection):
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::addMessageReceiver):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::didFinishLaunching):

UIProcess/WebProcessProxy.h:

(WebKit::WebProcessProxy::connection):
(WebProcessProxy):
(WebKit::WebProcessProxy::webConnection):

WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::create):
(WebKit::WebConnectionToUIProcess::WebConnectionToUIProcess):
(WebKit):
(WebKit::WebConnectionToUIProcess::invalidate):
(WebKit::WebConnectionToUIProcess::connection):
(WebKit::WebConnectionToUIProcess::destinationID):
(WebKit::WebConnectionToUIProcess::hasValidConnection):

WebProcess/WebConnectionToUIProcess.h:

(WebConnectionToUIProcess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initialize):
(WebKit::WebProcess::terminate):

WebProcess/WebProcess.h:

(WebKit::WebProcess::connection):
(WebKit::WebProcess::webConnectionToUIProcess):
Move the CoreIPC::Connection back to the processes.

9:02 PM Changeset in webkit [135346] by haraken@chromium.org

14 edits in trunk

[V8] Introduce constructorCallbackCustom()
https://bugs.webkit.org/show_bug.cgi?id=102763

Reviewed by Adam Barth.

Source/WebCore:

Currently custom constructors have the following code:

v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

INC_STATS("DOM.XXX.Constructor");
if (!args.IsConstructCall())

return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());

if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)

return args.Holder();

/* body of the constructor */;

}

To avoid duplicating the same logic in all custom constructors,
this patch changes the generated code as follows:

Generated automatically
v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

INC_STATS("DOM.XXX.Constructor");
${maybeObserveFeature} Newly supported for custom constructors.
if (!args.IsConstructCall())

return throwTypeError("DOM object constructor cannot be called as a function.", args.GetIsolate());

if (ConstructorMode::current() == ConstructorMode::WrapExistingObject)

return args.Holder();

V8XXX::constructorCallbackCustom(args);

}

Written manually
v8::Handle<v8::Value> V8XXX::constructorCallback(const v8::Arguments& args) {

/* body of the constructor */;

}

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(HasCustomConstructor):
(GenerateCustomConstructorCallback):
(GenerateImplementation):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):

bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

bindings/v8/custom/V8IntentConstructor.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

bindings/v8/custom/V8MessageChannelConstructor.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

bindings/v8/custom/V8WebKitPointConstructor.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

LayoutTests:

Updated a test result.

platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:

8:54 PM Changeset in webkit [135345] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r135263): Fix a wrong argument for udat_close
https://bugs.webkit.org/show_bug.cgi?id=102856

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Fixed a bug that passed wrong pointer to udat_close.

No new tests. No changes in behavior.

platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): Close correct object.

7:58 PM Changeset in webkit [135344] by gyuyoung.kim@samsung.com

2 edits in trunk/Websites/webkit.org

Add Samsung to security vendor member list
https://bugs.webkit.org/show_bug.cgi?id=102863

Reviewed by Sam Weinig.

security/security-group-members.html: Add Samsung members.

7:21 PM Changeset in webkit [135343] by commit-queue@webkit.org

11 edits
4 adds in trunk

[EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
https://bugs.webkit.org/show_bug.cgi?id=99114

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-20
Reviewed by Gyuyoung Kim.

Source/WebKit2:

Added Ewk_Window_Features API so that we can create new windows
with various window features such as location, size, toolbar, menubar,
statusbar, locationbar, scrollbar, resizable, and fullscreen.

UI client callbacks related to window features also implemented
so that it is possible to retrieve the window object property values.

PlatformEfl.cmake:
UIProcess/API/efl/EWebKit2.h:
UIProcess/API/efl/EwkViewCallbacks.h:

(EwkViewCallbacks):

UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::windowFeatures):
(EwkViewImpl::createNewPage):
(EwkViewImpl::closePage):

UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):

UIProcess/API/efl/ewk_view.h:
UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::toolbarsAreVisible):
(WebKit):
(WebKit::PageUIClientEfl::setToolbarsAreVisible):
(WebKit::PageUIClientEfl::menuBarIsVisible):
(WebKit::PageUIClientEfl::setMenuBarIsVisible):
(WebKit::PageUIClientEfl::statusBarIsVisible):
(WebKit::PageUIClientEfl::setStatusBarIsVisible):
(WebKit::PageUIClientEfl::isResizable):
(WebKit::PageUIClientEfl::setIsResizable):
(WebKit::PageUIClientEfl::PageUIClientEfl):

UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

Tools:

Implemented window_create and window_close smartcallback functions.

MiniBrowser/efl/main.c:

(on_window_create):
(on_window_close):
(window_create):

7:13 PM Changeset in webkit [135342] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Need spellcheck suggestions even if continuous check is off.
https://bugs.webkit.org/show_bug.cgi?id=102535

Patch by Rachel Blum <groby@chromium.org> on 2012-11-20
Reviewed by Hajime Morita.

Make sure the context menu always has suggestions for misspelled words.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

6:34 PM Changeset in webkit [135341] by fpizlo@apple.com

3 edits in trunk/Source/WTF

DFG should be able to cache closure calls
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added support to the meta allocator for easily querying whether an address falls within
a certain allocated chunk. Also added a useful debug routine to SentinelLinkedList,
which can be used to check if a node is on a particular list.

wtf/MetaAllocatorHandle.h:

(MetaAllocatorHandle):
(WTF::MetaAllocatorHandle::containsIntegerAddress):
(WTF::MetaAllocatorHandle::contains):

wtf/SentinelLinkedList.h:

(SentinelLinkedList):
(WTF::::isOnList):
(WTF):

6:32 PM Changeset in webkit [135340] by haraken@chromium.org

8 edits in trunk

Remove $outputDir and $outputHeadersDir from global variables of code generators
https://bugs.webkit.org/show_bug.cgi?id=102492

Reviewed by Adam Barth.

$outputDir and $outputHeadersDir are used in WriteData() only.
We don't need to use global variables for them.

No tests. No change in behavior.

bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
(FileNamePrefix):

bindings/scripts/CodeGeneratorCPP.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorGObject.pm:

(new):
(WriteData):
(GenerateInterface):

bindings/scripts/CodeGeneratorJS.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorObjC.pm:

(new):
(GenerateInterface):
(WriteData):

bindings/scripts/CodeGeneratorV8.pm:

(new):
(GenerateInterface):
(WriteData):

6:15 PM Changeset in webkit [135339] by abarth@webkit.org

2 edits in trunk/Source/WebCore

7% regression in dromaeo_domcorequery/dom_query_getElementsByTagNamenot_in_document
https://bugs.webkit.org/show_bug.cgi?id=102852

Reviewed by Kentaro Hara.

In http://trac.webkit.org/changeset/135208/, we lost the early-exit
check for whether isolatedWorldsExist() in this code path. This
regression points to benchmarks that we can further improve by
continuing to merge the general ScriptWrappable code path with the Node
code path.

bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

5:58 PM Changeset in webkit [135338] by haraken@chromium.org

3 edits in trunk/Source/WebCore

[V8] Change a return type of V8Parameter::prepare() from bool to void
https://bugs.webkit.org/show_bug.cgi?id=102805

Reviewed by Adam Barth.

This is an incremental step for V8Parameter refactoring.

V8Parameter::prepare() is always called just after V8Parameter's
constructor. So I want to move the logic of V8Parameter::prepare()
to V8Parameter's constructor. In preparation for that (i.e. because
a constructor cannot return any value), this patch changes the return
type of V8Parameter::prepare() from bool to void.

Tests: fast/workers/worker-constructor.html

storage/websql/sql-error-codes.html
inspector/console/alert-toString-exception.html
http/tests/websocket/tests/hybi/send-throw.html
etc

bindings/v8/V8BindingMacros.h:
bindings/v8/V8StringResource.h:

(V8Parameter):
(WebCore::V8Parameter::prepareBase): This patch removes a TryCatch block.
This change is safe because (1) all V8Parameter::prepareBase() in the code base
is called inside STRING_TO_V8PARAMETER_EXCEPTION_BLOCK(), and because
(2) STRING_TO_V8PARAMETER_EXCEPTION_BLOCK() has a TryCatch block.
(Note: In a follow-up patch I'm planning to refactor the macros.)
(WebCore::::prepare): I will remove this method shortly.

5:35 PM Changeset in webkit [135337] by adamk@chromium.org

10 edits in trunk

[JSC] MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102744

Reviewed by Adam Barth.

Source/WebCore:

This is the JSC side of the change landed for V8 in r135228.
It ensures MutationObserver wrapper objects are kept alive as long as
any observed nodes.

bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Keep MutationObserver wrappers alive
if any of their observed nodes' roots is an opaque root.

dom/MutationObserver.idl: Add JSCustomIsReachable

LayoutTests:

Remove suppressions for wrapper dropoff tests.

platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

5:29 PM Changeset in webkit [135336] by fpizlo@apple.com

25 edits
2 adds in trunk/Source/JavaScriptCore

DFG should be able to cache closure calls (part 2/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Added caching of calls where the JSFunction* varies, but the Structure* and ExecutableBase*
stay the same. This is accomplished by replacing the branch that compares against a constant
JSFunction* with a jump to a closure call stub. The closure call stub contains a fast path,
and jumps slow directly to the virtual call thunk.

Looks like a 1% win on V8v7.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::unlink):

bytecode/CallLinkInfo.h:

(CallLinkInfo):
(JSC::CallLinkInfo::isLinked):
(JSC::getCallLinkInfoBytecodeIndex):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):

bytecode/CodeBlock.h:

(JSC::CodeBlock::getCallLinkInfo):
(CodeBlock):
(JSC::CodeBlock::isIncomingCallAlreadyLinked):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addJSCall):
(JSC::DFG::JITCompiler::JSCallRecord::JSCallRecord):
(JSCallRecord):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGRepatch.cpp:

(JSC::DFG::linkSlowFor):
(DFG):
(JSC::DFG::dfgLinkFor):
(JSC::DFG::dfgLinkSlowFor):
(JSC::DFG::dfgLinkClosureCall):

dfg/DFGRepatch.h:

(DFG):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGThunks.cpp:

(DFG):
(JSC::DFG::linkClosureCallThunkGenerator):

dfg/DFGThunks.h:

(DFG):

heap/Heap.h:

(Heap):
(JSC::Heap::jitStubRoutines):

heap/JITStubRoutineSet.h:

(JSC::JITStubRoutineSet::size):
(JSC::JITStubRoutineSet::at):
(JITStubRoutineSet):

jit/ClosureCallStubRoutine.cpp: Added.

(JSC):
(JSC::ClosureCallStubRoutine::ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::~ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::markRequiredObjectsInternal):

jit/ClosureCallStubRoutine.h: Added.

(JSC):
(ClosureCallStubRoutine):
(JSC::ClosureCallStubRoutine::structure):
(JSC::ClosureCallStubRoutine::executable):
(JSC::ClosureCallStubRoutine::codeOrigin):

jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):

jit/GCAwareJITStubRoutine.h:

(GCAwareJITStubRoutine):
(JSC::GCAwareJITStubRoutine::isClosureCall):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

5:11 PM Changeset in webkit [135335] by rniwa@webkit.org

2 edits in trunk/LayoutTests

REGRESSION(r131106): magnitude-perf.js calls bind on undefined
https://bugs.webkit.org/show_bug.cgi?id=102848

Reviewed by Tony Gentilcore.

Check the existence of performance.now before calling bind on it.

resources/magnitude-perf.js:

(Magnitude._runIteration):

4:45 PM Changeset in webkit [135334] by ojan@chromium.org

3 edits in trunk/Tools

Simplify builder filters now that we have lists of which builders run which tests
https://bugs.webkit.org/show_bug.cgi?id=102849

Reviewed by Dirk Pranke.

We only need filters when we load the same master for multiple groups in the
same test type, i.e. when we need to only include some of the builders that run
a given test suite on a given master.

Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
Now just make it a method on BuilderGroup.

TestResultServer/static-dashboards/builders.js:

(BuilderGroup.prototype.append):
(BuilderGroup.prototype.setup):
(BuilderGroup.prototype._defaultBuilder):
(BuilderGroup.prototype.master):
(requestBuilderList):
(isChromiumWebkitTipOfTreeTestRunner):
(isChromiumWebkitDepsTestRunner):
(loadBuildersList):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

4:45 PM Changeset in webkit [135333] by dgrogan@chromium.org

5 edits in trunk/LayoutTests

IndexedDB: remove setVersion from pending-version-change-on-exit.html
https://bugs.webkit.org/show_bug.cgi?id=102457

Reviewed by Tony Chang.

This test doesn't work in single-process mode because of
http://wkb.ug/82776. We run it in content_shell in chromium.

platform/chromium/TestExpectations:
storage/indexeddb/pending-version-change-on-exit-expected.txt:
storage/indexeddb/pending-version-change-on-exit.html:
storage/indexeddb/resources/pending-version-change-on-exit.js:

(request.onblocked):

4:35 PM Changeset in webkit [135332] by jsbell@chromium.org

6 edits in trunk/Source/WebCore

IndexedDB: Move control of transaction completion to front end
https://bugs.webkit.org/show_bug.cgi?id=100903

Reviewed by Tony Chang.

"When a transaction can no longer become active, the implementation must attempt to
commit it" - that is, all requests have dispatched success/error events and no further
requests have been made. Previously, this was done by the back end waiting for events
from the front end, but the front end can more efficiently make the decision.

There should be no detectable behavior change.

Tests: storage/indexeddb/transaction-*.html

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::setActive):
(WebCore::IDBTransaction::registerRequest):

Modules/indexeddb/IDBTransaction.h:
Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::hasPendingTasks): Added.
(WebCore::IDBTransactionBackendImpl::didCompleteTaskEvents):
(WebCore::IDBTransactionBackendImpl::run):
(WebCore::IDBTransactionBackendImpl::taskEventTimerFired):

4:27 PM Changeset in webkit [135331] by ojan@chromium.org

2 edits in trunk/Tools

Remove perfav master for webkit_unit_tests and test_shell_tests.
There are no bots on this master that run these tests.

TestResultServer/static-dashboards/builders.js:

4:22 PM Changeset in webkit [135330] by fpizlo@apple.com

9 edits in trunk/Source/JavaScriptCore

DFG should be able to cache closure calls (part 1/2)
https://bugs.webkit.org/show_bug.cgi?id=102662

Reviewed by Gavin Barraclough.

Add ability to revert a jump replacement back to
branchPtrWithPatch(Condition, RegisterID, TrustedImmPtr). This is meant to be
a mandatory piece of functionality for all assemblers. I also renamed some of
the functions for reverting jump replacements back to
patchableBranchPtrWithPatch(Condition, Address, TrustedImmPtr), so as to avoid
confusion.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::BadReg):
(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3):

assembler/LinkBuffer.h:

(JSC):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARMv7):
(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):
(JSC::MacroAssemblerARMv7::startOfPatchableBranchPtrWithPatchOnAddress):

assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerX86::revertJumpReplacementToBranchPtrWithPatch):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::startOfBranchPtrWithPatchOnRegister):
(JSC::MacroAssemblerX86_64::startOfPatchableBranchPtrWithPatchOnAddress):
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::revertJumpReplacementToBranchPtrWithPatch):

assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::startOfBranchPtrWithPatchOnRegister):
(RepatchBuffer):
(JSC::RepatchBuffer::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::RepatchBuffer::revertJumpReplacementToBranchPtrWithPatch):

assembler/X86Assembler.h:

(JSC::X86Assembler::revertJumpTo_cmpl_ir_force32):
(X86Assembler):

dfg/DFGRepatch.cpp:

(JSC::DFG::replaceWithJump):
(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

4:20 PM Changeset in webkit [135329] by haraken@chromium.org

4 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests results.

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::constructorCallback):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):

4:12 PM Changeset in webkit [135328] by hclam@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Chromium build fix.

Removed unnecessary mutex unlock that triggered crash on Linux debug build.

Chromium Linux Debug layout tests should be green:
platform/chromium/virtual/deferred/fast/images/image-in-map.html

platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):

4:07 PM Changeset in webkit [135327] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Fix another typo. I need to checking that type() != NodeListCollectionType,
not that type() >= FirstNodeCollectionType.

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):

3:56 PM Changeset in webkit [135326] by ojan@chromium.org

3 edits in trunk/Tools

Remove special case for layout tests when builders fail to load
https://bugs.webkit.org/show_bug.cgi?id=102842

Reviewed by Tony Chang.

Now that we load only builders that actually run the given test
type, we can reliably show errors to the users because it
represents a broken bot.

TestResultServer/static-dashboards/loader.js:

3:50 PM Changeset in webkit [135325] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[V8] Pass ScriptState::current() to functions marked with CallWith=ScriptState
https://bugs.webkit.org/show_bug.cgi?id=102739

Patch by Michael Pruett <michael@68k.org> on 2012-11-20
Reviewed by Kentaro Hara.

Previously EmptyScriptState rather than ScriptState::current()
was passed to functions marked with [CallWith=ScriptState].
Since the EmptyScriptState has a null v8::Context, any functions
which depended upon a valid v8::Context would fail.

No new tests. Covered by existing tests.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateCallWith):
(GenerateFunctionCallString):

bindings/v8/ScriptState.h:

(WebCore::ScriptState::clearException): Added.

3:47 PM Changeset in webkit [135324] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

platform/win/WindowsExtras.h: Switch to direct include of <ObjBase.h>, as is done in other <shlwapi.h> includes.

3:45 PM Changeset in webkit [135323] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

Fix typos. Apparently XCode failed to text-replace earlier when it was busy making a snapshot :(

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):

3:42 PM Changeset in webkit [135322] by haraken@chromium.org

2 edits in trunk/Source/WebCore

[V8] Introduce GenerateConstructorHeader() to CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=102806

Reviewed by Adam Barth.

This is an incremental step for introducing constructorCallbackCustom().
(See bug 102763.) This patch adds GenerateConstructorHeader()
that generates a common code for constructors.

No tests. No change in behavior.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateConstructorHeader):

3:40 PM Changeset in webkit [135321] by rniwa@webkit.org

5 edits in trunk/Source/WebCore

HTMLCollection's cache should not be invalidated when id or name attributes are changed
https://bugs.webkit.org/show_bug.cgi?id=102843

Reviewed by Eric Seidel.

When an id or name attribute changes, only invaliate id and name cache maps when the collection
doesn't depend on id and name attributes (e.g. document.images).

Unfortunately, I could not create a reliable test for this performance problem.

dom/DynamicNodeList.cpp:

(WebCore::DynamicNodeListCacheBase::invalidateIdNameCacheMaps):

dom/DynamicNodeList.h:

(WebCore::DynamicNodeListCacheBase::invalidateCache):
(DynamicNodeListCacheBase):

dom/ElementRareData.h:

(WebCore::ElementRareData::clearHTMLCollectionCaches):

html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):

3:38 PM Changeset in webkit [135320] by adamk@chromium.org

3 edits in trunk/Source/WebCore

[v8] Avoid unnecessary call to ToObject() in Callback constructors
https://bugs.webkit.org/show_bug.cgi?id=102831

Reviewed by Adam Barth.

The code already asserted that the argument was an object, so calling
ToObject() is unnecessary: a simple Cast() suffices.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):

bindings/scripts/test/V8/V8TestCallback.h:

(WebCore::V8TestCallback::create):

3:34 PM Changeset in webkit [135319] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Animated gifs pause on scroll or zoom and sometimes don't resume after scroll or zoom completes
https://bugs.webkit.org/show_bug.cgi?id=102838

Patch by Andrew Lo <anlo@rim.com> on 2012-11-20
Reviewed by Rob Buis.

Internally reviewed by Adam Treat.
Internal PR244646
When entering scrolling & zooming, we suspend regular render jobs
in order to pause animations. When finishing scrolling or zooming,
dispatch a render job in order to resume those animations.

If an animation requests a repaint while the backing store is suspended,
add the regular render job to the render queue so that it can be
processed later.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

3:27 PM Changeset in webkit [135318] by rjkroege@chromium.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Use embedder-supported gesture curves
https://bugs.webkit.org/show_bug.cgi?id=100884

Reviewed by James Robinson.

Use embedder-provided gesture animation curves via WebKit api interfaces.
Tested by existing tests.

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleGestureFling):
(WebKit::WebCompositorInputHandlerImpl::scrollBy):

src/WebCompositorInputHandlerImpl.h:

(WebCompositorInputHandlerImpl):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::scrollBy):
(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::transferActiveWheelFlingAnimation):

src/WebViewImpl.h:

(WebCore):
(WebKit):
(WebViewImpl):

2:54 PM Changeset in webkit [135317] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Build fix after r135316

platform/network/curl/AuthenticationChallenge.h: Update stub implementations to match Apple Windows port.

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Add

missing identifier argument.

(WebCore::AuthenticationChallenge::setAuthenticationClient): Supply

missing set method.

2:50 PM Changeset in webkit [135316] by tony@chromium.org

4 edits in trunk/Source

When calling DocumentStyleSheetCollection::addUserSheet, pass in a user sheet
https://bugs.webkit.org/show_bug.cgi?id=102835

Reviewed by Ojan Vafai.

After r135082, Chromium browser_tests were triggering the ASSERT in
StyleResolver::collectRulesFromUserStyleSheets. Add an ASSERT that will
trigger earlier and make it clear in the Chromium code that we're always
inserting user level styles.

Source/WebCore:

No new tests, no behavior change except no longer triggering the StyleResolver ASSERT
in Chromium browser_tests.

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::addUserSheet):

Source/WebKit/chromium:

src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet):

2:41 PM Changeset in webkit [135315] by commit-queue@webkit.org

9 edits
4 adds in trunk/Source/WebKit/chromium

Provide page/window coordinates to plugin's local coordinates translation in WebPluginContainer.
https://bugs.webkit.org/show_bug.cgi?id=102339

Patch by Istiaque Ahmed <lazyboy@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

This change will allow converting a page's window coordinates to plugins's local coordinates,
taking CSS transformations into account. Embedder page of the plugin can use this information
for targetting elements inside the plugin (e.g. devtools can inspect a specific element at the
local coordinate position inside plugin).

WebKit.gyp:
WebKit.gypi:
public/WebNode.h:

(WebKit):

public/WebPluginContainer.h:

(WebKit):
(WebPluginContainer):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::executeCommand):
(WebKit::WebFrameImpl::printBegin):
(WebKit::WebFrameImpl::isPrintScalingDisabledForPlugin):

src/WebNode.cpp:

(WebKit::WebNode::pluginContainer):
(WebKit):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::windowToLocalPoint):
(WebKit):

src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

tests/FakeWebPlugin.cpp: Added.

(WebKit):
(WebKit::FakeWebPlugin::FakeWebPlugin):
(WebKit::FakeWebPlugin::~FakeWebPlugin):
(WebKit::FakeWebPlugin::initialize):
(WebKit::FakeWebPlugin::destroy):

tests/FakeWebPlugin.h: Added.

(WebKit):
(FakeWebPlugin):

tests/WebPluginContainerTest.cpp: Added.

(WebKit):
(WebPluginContainerTest):
(WebKit::WebPluginContainerTest::WebPluginContainerTest):
(WebKit::WebPluginContainerTest::TearDown):
(WebKit::getWebPluginContainer):
(WebKit::TEST_F):

tests/data/plugin_container.html: Added.

2:39 PM Changeset in webkit [135314] by commit-queue@webkit.org

21 edits
1 add in trunk

[CSS Exclusions] Support outside-shape value on shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101108

Patch by Bear Travis <betravis@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Source/WebCore:

Shape-inside can potentially be: 'auto' | 'outside-shape' | <shape> | <url>.
Webkit currently supports the value 'auto' (null) and <shape> (a BasicShape*).
This patch adds support for the value 'outside-shape.' It adds the ExclusionShapeValue
class, which may be any of the three values: 'auto', 'outside-shape', or <shape>.
Bug 102738 tracks adding <url> support.

Modifying existing tests:
LayoutTests/fast/exclusions/parsing-wrap-shape-inside.html
LayoutTests/fast/exclusions/parsing-wrap-shape-outside.html

GNUmakefile.list.am: Adding ExclusionShapeValue.h to the build files.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

(WebCore):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Modifying code to use
ExclusionShapeValue* rather than the previous BasicShape* values.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Handle the outside-shape value.

css/CSSValueKeywords.in: Adding outside-shape value.
css/StyleBuilder.cpp:

(WebCore):
(WebCore::ApplyPropertyExclusionShape::setValue): Modify code to use
ExclusionShapeValue* rather than BasicShape*.
(WebCore::ApplyPropertyExclusionShape::applyValue): Ditto.
(WebCore::ApplyPropertyExclusionShape::createHandler): Ditto.

page/animation/CSSPropertyAnimation.cpp: Ditto.

(WebCore::blendFunc): Ditto.
(WebCore::PropertyWrapperExclusionShape::PropertyWrapperExclusionShape): Ditto.
(WebCore::CSSPropertyAnimation::ensurePropertyMap): Ditto.

rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::isExclusionShapeInsideInfoEnabledForRenderBlock):
Ditto.
(WebCore::ExclusionShapeInsideInfo::computeShapeSize): Ditto.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Ditto.

rendering/RenderBlock.h:

(RenderBlock):

rendering/style/ExclusionShapeValue.h: Added.

(WebCore):
(ExclusionShapeValue): New type to represent the possible values of shape-inside
and shape-outside. Only shape-inside can have a value of 'outside-shape.'
(WebCore::ExclusionShapeValue::~ExclusionShapeValue):
(WebCore::ExclusionShapeValue::type): Returns the value type.
(WebCore::ExclusionShapeValue::shape): Returns <shape> value's BasicShape*.
(WebCore::ExclusionShapeValue::operator==):
(WebCore::ExclusionShapeInfo::createShapeValue):
(WebCore::ExclusionShapeInfo::createOutsideValue):
(WebCore::ExclusionShapeValue::ExclusionShapeValue):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):

LayoutTests:

Adding tests to make sure the 'outside-shape' value properly applies only to the
shape-inside property.

fast/exclusions/parsing-wrap-shape-inside-expected.txt:
fast/exclusions/parsing-wrap-shape-outside-expected.txt:
fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
fast/exclusions/script-tests/parsing-wrap-shape-outside.js:

2:27 PM Changeset in webkit [135313] by hclam@chromium.org

7 edits in trunk/Source

[chromium] Make lazy image decoding thread-safe
https://bugs.webkit.org/show_bug.cgi?id=102721

Reviewed by Stephen White.

Source/WebCore:

Added mutex to LazyDecodingPixelRef such that there is no parallel
onLockPixels() running on multiple threads.

Added mutex to ImageFrameGenerator to protect the use of raw image
data.

The result is that we can decode on threads other than the main
thread while data is being supplied on the main thread.

New unit test:
DeferredImageDecoderTest.decodeOnOtherThread

platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::setData):
(WebCore::ImageFrameGenerator::decodeAndScale):

platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):

platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

Source/WebKit/chromium:

Added a new unit test to verify that lazy image decoding operates
correctly on non-main threads.

tests/DeferredImageDecoderTest.cpp:

(Rasterizer):
(WebCore):
(WebCore::rasterizeMain):
(WebCore::TEST_F):

2:25 PM Changeset in webkit [135312] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[Qt] Build fix after r135217.
https://bugs.webkit.org/show_bug.cgi?id=102787

platform/win/WindowsExtras.h: Add #undef of NOSHLWAPI to

allow include of <ObjBase.h> needed by Qt build.

2:25 PM Changeset in webkit [135311] by jianli@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Updated chromium test expectations.

platform/chromium/TestExpectations:

2:08 PM Changeset in webkit [135310] by commit-queue@webkit.org

39 edits
1 delete in trunk/Source

Unreviewed, rolling out r135295.
http://trac.webkit.org/changeset/135295
https://bugs.webkit.org/show_bug.cgi?id=102834

This patch causes assertion to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
loader/FrameLoadRequest.cpp: Removed.
loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(FrameLoadRequest):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::load):

loader/FrameLoader.h:

(FrameLoader):

page/DragController.cpp:

(WebCore::DragController::performDrag):

plugins/PluginView.cpp:

(WebCore::PluginView::performRequest):

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):

src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

ewk/ewk_frame.cpp:

(ewk_frame_uri_set):
(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

webkit/webkitwebframe.cpp:

(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

Plugins/WebPluginController.mm:
WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAlternateHtml):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

WebView.cpp:

(WebView::load):

Source/WebKit/wx:

WebFrame.cpp:

(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::linkClicked):

1:47 PM Changeset in webkit [135309] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Unreviewed, rolling out r135293.
http://trac.webkit.org/changeset/135293
https://bugs.webkit.org/show_bug.cgi?id=102832

This patch causes crash to some layout tests on chromium
(Requested by jianli on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

bindings/v8/DOMWrapperWorld.cpp:
bindings/v8/DOMWrapperWorld.h:
bindings/v8/ScriptController.cpp:

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore):
(WebCore::isolatedContextWeakCallback):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8DOMWindowShell.h:

(WebCore::V8DOMWindowShell::isolated):
(V8DOMWindowShell):

bindings/v8/V8PerContextData.h:
bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

1:10 PM Changeset in webkit [135308] by dgrogan@chromium.org

12 edits in trunk

IndexedDB: Remove legacy enum-based constants from IDL
https://bugs.webkit.org/show_bug.cgi?id=85315

Reviewed by Adam Barth.

Source/WebCore:

These were only present in an earlier working draft of the spec and have
been removed for 8 months. See
http://lists.w3.org/Archives/Public/public-webapps/2012JanMar/0957.html

Tests - legacy-constants.html

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::stringToDirection):

Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stringToMode):

Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

storage/indexeddb/constants-expected.txt:
storage/indexeddb/cursor-overloads-expected.txt:
storage/indexeddb/cursor-overloads.html:
storage/indexeddb/legacy-constants-expected.txt:
storage/indexeddb/resources/constants.js:

(test):

storage/indexeddb/resources/legacy-constants.js:

(testObsoleteConstants):

1:00 PM Changeset in webkit [135307] by commit-queue@webkit.org

10 edits
1 delete in trunk/LayoutTests

animations/stop-animation-on-suspend.html sometimes fails on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49182

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-20
Reviewed by Antti Koivisto.

stop-animation-on-suspend incorrectly assumed that animation in a subframe would start
roughly at document load. Keep both animations (one in main frame, one in iframe) paused
until the iframe is loaded: this way they should run synchronised enough.

Also increase the tolerance of the test slightly: measuring timing like this is inherently flaky.

Remove failure expectation from all TestExpectations and remove the clearly wrong expected
result for chromium-mac.

animations/resources/stop-animation-on-suspend-subframe.html:
animations/stop-animation-on-suspend.html:
platform/chromium/TestExpectations:
platform/chromium-mac/animations/stop-animation-on-suspend-expected.txt:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt-arm/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

12:33 PM Changeset in webkit [135306] by reed@google.com

2 edits in trunk/LayoutTests

update TestExpectations before a skia change
https://bugs.webkit.org/show_bug.cgi?id=102829

Reviewed by NOBODY. expectations change only.

optimization for rectangular blurs (with holes) changes some images in the low bit. mark for rebaselining.

platform/chromium/TestExpectations:

11:59 AM Changeset in webkit [135305] by commit-queue@webkit.org

7 edits
1 add in trunk

Store MutationObserver callback in a hidden property for V8
https://bugs.webkit.org/show_bug.cgi?id=102555

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Adam Barth.

Test for reference cycle leaks with mutation observers. There doesn't seem
to be a way to check this for v8, but if you manually run you can see if it
leaks observers.

ManualTests/leak-cycle-observer-wrapper.html: Added.

Source/WebCore:

To prevent circular reference leaks we should store the MutationObserver
callback in a hidden property on the wrapper of the observer.

This is done by extending the code generator to support a new owner
argument to ::create() that lets you set the owner of the callback where
the hidden property should be stored.

Test: ManualTests/leak-cycle-observer-wrapper.html

bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackHeader):
(GenerateCallbackImplementation):

bindings/scripts/test/V8/V8TestCallback.cpp: rebaselined.
bindings/scripts/test/V8/V8TestCallback.h: rebaselined.
bindings/v8/V8HiddenPropertyName.h:
bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallback):

11:58 AM Changeset in webkit [135304] by ojan@chromium.org

10 edits
4 adds in trunk/Tools

Generate a list of builders/test suites from the buildbot json
https://bugs.webkit.org/show_bug.cgi?id=102443

Reviewed by Dirk Pranke.

Instead of the cludgy things we do now to track which bots run which tests,
we generate all that data from the buildbots' json files.
This is the minimal amount to keep everything working. Once this lands,
we can also do a bunch of followup cleanup.

For now we commit the generated data. In theory, in the future, we could
have the test results server generate the data on the fly.

For the sake of easily understanding what changes when we run the generate script,
also checkin a pretty printed version of the output. The pretty printed version
is too large to serve as part of the flakiness dashboard though.

This also has the benefit of making the dashboard load much faster since
we no longer ever need to block on requests to buildbot.

TestResultServer/generate_builders_json.py: Added.

(master_json_url):
(builder_json_url):
(cached_build_json_url):
(fetch_json):
(insert_builder_and_test_data):
(main):

TestResultServer/generate_builders_json_unittest.py: Added.

(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_master_json_url):
(GenerateBuildersJsonTest.test_builder_json_url):
(GenerateBuildersJsonTest.test_cached_build_json_url):
(GenerateBuildersJsonTest.test_generate_json_data):
(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):

TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
TestResultServer/static-dashboards/builders.js:

(LOAD_BUILDBOT_DATA):
(BuilderGroup):
(BuilderGroup.prototype.append):
(BuilderGroup.prototype.master):
(requestBuilderList):

TestResultServer/static-dashboards/builders.jsonp: Added.
TestResultServer/static-dashboards/builders_unittests.js: Added.
TestResultServer/static-dashboards/dashboard_base.js:
TestResultServer/static-dashboards/flakiness_dashboard.js:

(showPopupForBuild):
(htmlForTestResults):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(loadExpectationsLayoutTests):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

TestResultServer/static-dashboards/loader.js:
TestResultServer/static-dashboards/loader_unittests.js:
TestResultServer/static-dashboards/run-embedded-unittests.html:
TestResultServer/static-dashboards/run-unittests.html:
TestResultServer/static-dashboards/timeline_explorer.html:

11:46 AM Changeset in webkit [135303] by inferno@chromium.org

3 edits
2 adds in trunk

Crash in FrameLoader::stopLoading.
https://bugs.webkit.org/show_bug.cgi?id=99504

Reviewed by Nate Chapin.

Source/WebCore:

Frame can be blown away in unload event handler. Need
to protect it with a RefPtr.

Test: fast/frames/frame-unload-crash2.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

LayoutTests:

fast/frames/frame-unload-crash2-expected.txt: Added.
fast/frames/frame-unload-crash2.html: Added.

11:29 AM Changeset in webkit [135302] by commit-queue@webkit.org

4 edits in trunk/Tools

[WTR][Qt] Enable fixedLayout when needed by the test
https://bugs.webkit.org/show_bug.cgi?id=102811

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Create a flickable view for CSS Device Adaptation tests. This is
crucial for testing them since they will change the size of the
viewport.

WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

WebKitTestRunner/qt/PlatformWebViewQt.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):

WebKitTestRunner/qt/main.cpp:

(main):

11:12 AM Changeset in webkit [135301] by krit@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary FilterOperations header from RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=102821

Reviewed by Ojan Vafai.

No new tests, simple refactoring.

rendering/RenderBoxModelObject.cpp:

11:04 AM ViewportInteractionTopics created by Noam Rosenthal

10:54 AM Changeset in webkit [135300] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] fix FPS counter disappearing when changing page
https://bugs.webkit.org/show_bug.cgi?id=102532

Patch by Eberhard Graether <egraether@google.com> on 2012-11-20
Reviewed by Pavel Feldman.

When changing the page with opened WebInspector and active FPS counter the WebInspector is
reloaded before the WebView switches to accelerated compositing, so the showFPSCounter call
to WebLayerTreeView is not yet possible. This fix saves the showFPSCounter value in the
WebSettings so it can be read when accelerated compositing is activated.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setShowFPSCounter):

10:49 AM Changeset in webkit [135299] by tsepez@chromium.org

3 edits
2 adds in trunk

XSSAuditor::decodedSnippetForJavaScript stopping when comma encountered.
https://bugs.webkit.org/show_bug.cgi?id=102587

Reviewed by Adam Barth.

Source/WebCore:

Rather than returning an empty fragment, continue processing the body
of a script tag when the decoded fragment reduces to nothing.

Test: http/tests/security/xssAuditor/script-tag-with-actual-comma.html

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::decodedSnippetForJavaScript):

LayoutTests:

http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt: Added.
http/tests/security/xssAuditor/script-tag-with-actual-comma.html: Added.

10:46 AM Changeset in webkit [135298] by pfeldman@chromium.org

1 edit in branches/chromium/1312/Source/WebCore/inspector/front-end/ElementsTreeOutline.js

Merge 134605 - Web Inspector: "Reveal in Element Panel" doesn't work if Elements panel hasn't been opened
https://bugs.webkit.org/show_bug.cgi?id=102219

Reviewed by Alexander Pavlov.

Force elements module load upon context menu invocation.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired.focusElement):
(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):

TBR=pfeldman@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11414088

10:42 AM Changeset in webkit [135297] by pfeldman@chromium.org

1 edit in branches/chromium/1312/Source/WebCore/inspector/front-end/ObjectPropertiesSection.js

Merge 134595 - Web Inspector: context menu on ObjectPropertyTreeElement's values is masked by the section.
https://bugs.webkit.org/show_bug.cgi?id=102212

Reviewed by Vsevolod Vlasov.

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.enableContextMenu):

TBR=pfeldman@chromium.org
BUG=161156
Review URL: https://chromiumcodereview.appspot.com/11416111

10:40 AM Changeset in webkit [135296] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

[CSS Exclusions] writing-mode:vertical-rl shape-inside tests are incorrectly configured
https://bugs.webkit.org/show_bug.cgi?id=102729

Patch by Hans Muller <hmuller@adobe.com> on 2012-11-20
Reviewed by Dirk Schulze.

Corrected the dimensions of the border elements in two exclusions tests. They
define a rectangle that's five pixels larger than the tests' rectangular
shape-inside exclusions shapes. They now enclose the shape-inside element's
text contents.

fast/exclusions/shape-inside/shape-inside-polygon-rectangle-expected.html:
fast/exclusions/shape-inside/shape-inside-polygon-rectangle.html:
fast/exclusions/shape-inside/shape-inside-vertical-text-expected.html:
fast/exclusions/shape-inside/shape-inside-vertical-text.html:

10:30 AM Changeset in webkit [135295] by simonjam@chromium.org

39 edits
1 add in trunk/Source

Consolidate FrameLoader::load() into one function taking a FrameLoadRequest
https://bugs.webkit.org/show_bug.cgi?id=102151

Reviewed by Adam Barth.

Source/WebCore:

There's a FIXME that we have too many FrameLoader::load*() functions. This patch consolidates 3 into 1.
There are still a few more load functions that will be consolidated later. Using FrameLoadRequest as
the interface into FrameLoader will also provide a place to pass in the initiator. Finally, this matches
the refactoring done with CachedResourceRequest and CachedResourceLoader.

No new tests. No change in functionality.

WebCore.exp.in:
loader/FrameLoadRequest.h:

(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::setLockHistory): These are former arguments to load().
(WebCore::FrameLoadRequest::lockHistory): Ditto.
(FrameLoadRequest):
(WebCore::FrameLoadRequest::setShouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::shouldCheckNewWindowPolicy): Ditto.
(WebCore::FrameLoadRequest::substituteData): Ditto.
(WebCore::FrameLoadRequest::setSubstituteData): Ditto.
(WebCore::FrameLoadRequest::hasSubstituteData): Ditto.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::load): No change in behavior, just merged it all into one function.

loader/FrameLoader.h:

(FrameLoader):

page/DragController.cpp:

(WebCore::DragController::performDrag):

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPagePrivate::loadString):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadRequest):
(WebKit::WebFrameImpl::loadData):

src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::initializeLoader):

Source/WebKit/efl:

ewk/ewk_frame.cpp:

(_ewk_frame_contents_set_internal):

Source/WebKit/gtk:

webkit/webkitwebframe.cpp:

(webkit_web_frame_load_uri):
(webkit_web_frame_load_data):
(webkit_web_frame_load_request):

Source/WebKit/mac:

Plugins/WebPluginController.mm:
WebView/WebFrame.mm:

(-[WebFrame loadRequest:]):
(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::QWebFrame):
(QWebFrame::load):
(QWebFrame::setHtml):
(QWebFrame::setContent):

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setAlternateHtml):
(qt_dump_set_accepts_editing):

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::callErrorPageExtension):

Source/WebKit/win:

WebFrame.cpp:

(WebFrame::loadRequest):
(WebFrame::loadData):

Source/WebKit/wince:

WebView.cpp:

(WebView::load):

Source/WebKit/wx:

WebFrame.cpp:

(WebKit::WebFrame::SetPageSource):

Source/WebKit2:

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):

10:30 AM Changeset in webkit [135294] by kareng@chromium.org

9 edits in branches/chromium/1312/Source/WebCore/platform/graphics

Revert 135211 - Merge 134871
BUG=157875
Review URL: https://codereview.chromium.org/11299089

TBR=cevans@google.com

10:26 AM Changeset in webkit [135293] by commit-queue@webkit.org

11 edits in trunk/Source/WebCore

Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637

Patch by Dan Carney <dcarney@google.com> on 2012-11-20
Reviewed by Adam Barth.

V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.

No new tests. No change in functionality.

bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):

bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):

bindings/v8/ScriptController.cpp:

bindings/v8/ScriptController.h:

(ScriptController):

bindings/v8/V8Binding.h:

(WebCore::worldForEnteredContextIfIsolated):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

bindings/v8/V8PerContextData.h:
bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

10:24 AM Changeset in webkit [135292] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[GTK] fast/hidpi/video-controls-in-hidpi.html and fast/layers/video-layer.html need new baseline
https://bugs.webkit.org/show_bug.cgi?id=102815

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

Added new GTK baseline for those tests.

platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:

New GTK baseline

platform/gtk/fast/layers/video-layer-expected.txt: New GTK

baseline

9:58 AM Changeset in webkit [135291] by mkwst@chromium.org

6 edits in trunk/Source/WebCore

Remove '#include "ScriptCallStackFactory.h"' include when unnecessary.
https://bugs.webkit.org/show_bug.cgi?id=102812

Reviewed by Jochen Eisinger.

"ScriptCallStackFactory.h" is included in a few files where it doesn't
seem to be required. Since I'm in the process of centralizing stack
trace generation anyway, I'll just clean this up as a drive-by.

bindings/js/JSConsoleCustom.cpp:
bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8WorkerContextCustom.cpp:
loader/FrameLoader.cpp:

Removed "ScriptCallStackFactory.h".

bindings/js/ScheduledAction.cpp:

This also included (but didn't use) "ScriptCallStack.h". I've
removed it as well.

9:44 AM Changeset in webkit [135290] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Merge checks for creating renderers into shouldCreateRenderer
https://bugs.webkit.org/show_bug.cgi?id=102768

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Ojan Vafai.

Merge the checks for if renderers should be created into shouldCreateRenderer
so simplify the code and ensure correctness if doing
NodeRenderingContext(node).shouldCreateRenderer() in other places in webkit.

No new tests, just refactoring.

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRendererFactory::createRendererIfNeeded):

9:25 AM Changeset in webkit [135289] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Gardening.

Temporarily mark fast/multicol/span/positioned-child-not-removed-crash.html
as crashing while the regression is addressed.

platform/efl-wk2/TestExpectations:

9:16 AM Changeset in webkit [135288] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=102804

Patch by peavo@outlook.com <peavo@outlook.com> on 2012-11-20
Reviewed by Alexey Proskuryakov.

win/WebKit2CFLite.def:

9:14 AM Changeset in webkit [135287] by commit-queue@webkit.org

10 edits in trunk

[WTR] WebKitTestRunner should be able to run tests using fixed layout
https://bugs.webkit.org/show_bug.cgi?id=102517

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-20
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Update EFL private API so we can create a view with fixed layout. We
can keep this as private as I don't see a real life use case for it
outside WTR and the WebInspector.

UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):

UIProcess/API/C/efl/WKView.h:
UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

UIProcess/API/efl/ewk_view_private.h:
UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

WTR will now request the creation of a view that has a page using
fixed layout for CSS Device Adaptation tests, but this feature might
be used in the future by any other test that requires a mobile-like type
of viewport (i.e. Viewport META tests should be ported).

The viewport type of the other tests remains unchanged and is restored
when the runner leaves the device-adapt/ folder.

WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

WebKitTestRunner/TestInvocation.cpp:

(WTR):
(WTR::shouldUseFixedLayout):
(WTR::updateLayoutType):
(WTR::TestInvocation::invoke):

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
(WTR):

8:32 AM Changeset in webkit [135286] by yoli@rim.com

2 edits in trunk/Source/JavaScriptCore

[ARMv7] Neither linkCall() nor linkPointer() should flush code.
https://bugs.webkit.org/show_bug.cgi?id=99213

Reviewed by George Staikos.

LinkBuffer doesn't need to flush code during linking. It will
eventually flush the whole executable. Fixing this gives >%5
sunspider boost (on QNX).

Also make replaceWithLoad() and replaceWithAddressComputation() flush
only when necessary.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):
(JSC::ARMv7Assembler::relinkCall):
(JSC::ARMv7Assembler::repatchInt32):
(JSC::ARMv7Assembler::repatchPointer):
(JSC::ARMv7Assembler::replaceWithLoad): Flush only after it did write.
(JSC::ARMv7Assembler::replaceWithAddressComputation): Flush only after it did write.
(JSC::ARMv7Assembler::setInt32):
(JSC::ARMv7Assembler::setPointer):

8:31 AM Changeset in webkit [135285] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: simplify? damaged region computation in the editor
https://bugs.webkit.org/show_bug.cgi?id=102688

Reviewed by Vsevolod Vlasov.

This change simplifies the damaged region computation. Drive-by make _getSelection work properly.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._handleCut):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber.compareLineRowOffsetTops):
(WebInspector.TextEditorChunkedPanel.prototype._findFirstVisibleLineNumber):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey.get var):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._getSelection):
(WebInspector.TextEditorMainPanel.prototype._restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._positionToSelection):
(WebInspector.TextEditorMainPanel.prototype._handleMutations):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._assertDOMMatchesTextModel):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):
(WebInspector.TextEditorMainChunk):
(WebInspector.TextEditorMainChunk.prototype.addDecoration):
(WebInspector.TextEditorMainChunk.prototype.get endLine):
(WebInspector.TextEditorMainChunk.prototype.lineRowContainingLine):
(WebInspector.TextEditorMainChunk.prototype.expandedLineRow):

8:26 AM Changeset in webkit [135284] by pfeldman@chromium.org

3 edits in branches/chromium/1312/Source/WebCore/inspector

Merge 134577 - Web Inspector: highlight is not updating as one edits CSS properties
https://bugs.webkit.org/show_bug.cgi?id=102191

Reviewed by Alexander Pavlov.

We should update highlight upon layout / style recalculation.

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didRecalculateStyleImpl):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::enable):
(WebCore::InspectorPageAgent::disable):
(WebCore::InspectorPageAgent::domContentEventFired):
(WebCore::InspectorPageAgent::didPaint):
(WebCore::InspectorPageAgent::didLayout):
(WebCore::InspectorPageAgent::didScroll):
(WebCore):
(WebCore::InspectorPageAgent::didRecalculateStyle):

inspector/InspectorPageAgent.h:

TBR=pfeldman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11413088

8:20 AM Changeset in webkit [135283] by allan.jensen@digia.com

3 edits in trunk/Source/WebKit2

[Qt] PageViewportControllerClient::didChangeViewportAttributes called twice
https://bugs.webkit.org/show_bug.cgi?id=102790

Reviewed by Kenneth Rohde Christiansen.

Change updateMinimumScaleToFit to no longer call PageViewportControllerClient::didChangeViewportAttributes,
but instead return whether it has changed the minimumScaleToFit.

UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeContentsSize):
(WebKit::PageViewportController::updateMinimumScaleToFit):

UIProcess/PageViewportController.h:

(PageViewportController):

8:10 AM Changeset in webkit [135282] by allan.jensen@digia.com

2 edits in trunk/Source/WebKit2

[Qt] No test of double-click to zoom out
https://bugs.webkit.org/show_bug.cgi?id=102810

Reviewed by Kenneth Rohde Christiansen.

Adds tests of zoom-stack behaviour, the ability to restore previous zoom levels. It tests
that zoom out always goes to lower zoom levels.

UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:

8:08 AM Changeset in webkit [135281] by Carlos Garcia Campos

2 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.2 release

configure.ac: Bump tarball version number, not updated in

previous commit by mistake.

8:02 AM Changeset in webkit [135280] by allan.jensen@digia.com

2 edits in trunk/Source/WebKit2

[Qt] Large areas highlighted on touch
https://bugs.webkit.org/show_bug.cgi?id=97216

Reviewed by Simon Hausmann.

Restrict highlighting of scripted event-handlers to inline elements only.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):

8:02 AM Changeset in webkit [135279] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update NEWS and configure.ac for 1.11.2 release

configure.ac: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 1.11.2.

7:56 AM Changeset in webkit [135278] by yael@webkit.org

3 edits
1 add in trunk/LayoutTests

Unreviewed gardening.
Update results for compositing/geometry/vertical-scroll-composited.html after 133898.
Mark animations/negative-delay.html as flaky.
Remove a few passing tests from TextExpectations.

platform/efl/TestExpectations:
platform/efl/compositing/geometry/vertical-scroll-composited-expected.png: Added.
platform/efl/compositing/geometry/vertical-scroll-composited-expected.txt:

7:35 AM Changeset in webkit [135277] by arv@chromium.org

4 edits in trunk/Source/WebCore

Remove historical enums from ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=102095

Reviewed by Ojan Vafai.

Remove unused enums from ExceptionCode.

No new tests. No tests affected.

Modules/intents/NavigatorIntents.cpp:

(WebCore::NavigatorIntents::webkitStartActivity): The error type for this is unspecified.

dom/DOMCoreException.cpp:
dom/ExceptionCode.h:

7:34 AM Changeset in webkit [135276] by schenney@chromium.org

9 edits
1 delete in trunk/LayoutTests

[Chromium] Expectations update

Unreviewed test expectations update.

Some results for calendar and month picker may not be up-to-date for the slow bots.

platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.png: Removed.
platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:

6:11 AM Changeset in webkit [135275] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] REGRESSION(r128174): Fast build path doesn't work now
https://bugs.webkit.org/show_bug.cgi?id=100360

Reviewed by Tor Arne Vestbø.

Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.

Scripts/webkitdirs.pm:

(buildQMakeProjects):

6:02 AM Changeset in webkit [135274] by keishi@webkit.org

7 edits in trunk

Week picker width is too small
https://bugs.webkit.org/show_bug.cgi?id=102766

Reviewed by Kent Tamura.

Source/WebCore:

The width of week picker was too small because we were forgetting about
the week number column when calculating the desired width.

No new tests. Covered by week-picker-appearance*.html.

Resources/pagepopups/calendarPicker.css:

(.week-mode .week-column): Needs to be table-cell.

Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium/TestExpectations:

5:40 AM Changeset in webkit [135273] by Philippe Normand

18 edits in trunk

[GTK] no volume slider in HTML5 media element controls
https://bugs.webkit.org/show_bug.cgi?id=97192

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

r115829 was causing this regression so it was partially
reverted. The revert causes some small regressions, in the tests
but it is better to have the volume slider shown.

Source/WebCore:

css/mediaControlsGtk.css:

(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Partially reverted
r115829.

LayoutTests:

platform/gtk-wk2/TestExpectations: Updated because it causes

some new regressions

platform/gtk/TestExpectations: Updated because it causes some

new regressions

platform/gtk/media/audio-controls-rendering-expected.txt: Updated
platform/gtk/media/controls-after-reload-expected.txt: Updated
platform/gtk/media/controls-strict-expected.txt: Updated
platform/gtk/media/controls-styling-expected.txt: Updated
platform/gtk/media/controls-styling-strict-expected.txt: Updated
platform/gtk/media/controls-without-preload-expected.txt: Updated
platform/gtk/media/media-controls-clone-expected.txt: Updated
platform/gtk/media/video-controls-rendering-expected.txt: Updated
platform/gtk/media/video-display-toggle-expected.txt: Updated
platform/gtk/media/video-empty-source-expected.txt: Updated
platform/gtk/media/video-no-audio-expected.txt: Updated
platform/gtk/media/video-volume-slider-expected.txt: Updated
platform/gtk/media/video-zoom-controls-expected.txt: Updated

5:17 AM Changeset in webkit [135272] by allan.jensen@digia.com

3 edits in trunk/Source/WebKit2

[Qt] Zoom logic confused by page and pinch resize
https://bugs.webkit.org/show_bug.cgi?id=102803

Reviewed by Kenneth Rohde Christiansen.

Clear the zoom-out stack after page resize, and ensure the zoom logic can still detect
zoom-out and zoom-back when the zoom-out stack is empty.

UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::clearRelativeZoomState):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):

UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

3:36 AM Changeset in webkit [135271] by Antti Koivisto

7 edits in trunk/Source/WebCore

Collect user style sheets in DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=102683

Reviewed by Andreas Kling.

Move the user stylesheet collection logic from StyleResolver to DocumentStyleSheetCollection.

css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):

css/StyleResolver.h:

(StyleResolver):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateStyleResolver):

Factor the StyleResolver updating code to function.

(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

Collect the user style sheets. Some renaming and other minor refactoring.

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::activeUserStyleSheets):

Add activeUserStyleSheets vector that contains all user stylesheets from different sources,
similar to activeAuthorStyleSheets.

(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):

3:24 AM Changeset in webkit [135270] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unneeded optimization in Element::isInTopLayer
https://bugs.webkit.org/show_bug.cgi?id=102772

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

There's no reason to worry about calling elementRareData() multiple
times in this non performance sensitive code path as it's only used
in HTMLDialogElement's showModal and close methods.

No new tests, just simplification.

dom/Element.cpp:

(WebCore::Element::setIsInTopLayer):

3:18 AM Changeset in webkit [135269] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Simplify Element::isSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=102779

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

isSpellCheckingEnabled contains logic that duplicates parentOrHostElement
and can be simplified by just calling that.

No new tests, just simplification.

dom/Element.cpp:

(WebCore::Element::isSpellCheckingEnabled):

3:09 AM Changeset in webkit [135268] by kihong.kwon@samsung.com

7 edits in trunk/Source/WebCore

Apply DeviceController as parent class of DeviceMotionController.
https://bugs.webkit.org/show_bug.cgi?id=102578

Reviewed by Hajime Morita.

DeviceController needs to be applied as parent class of DeviceMotionController
because DeviceController which is extracted as parent class of
DeviceMotionController and DeviceOrientationController is already added.
Therefore duplicated implementation can be removed.

Covered by existing tests.

dom/DeviceMotionClient.h:
dom/DeviceMotionController.cpp:

(WebCore::DeviceMotionController::DeviceMotionController):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
(WebCore::DeviceMotionController::deviceMotionClient):
(WebCore::DeviceMotionController::hasLastData):
(WebCore::DeviceMotionController::getLastEvent):
(WebCore::DeviceMotionController::from):
(WebCore):

dom/DeviceMotionController.h:

(WebCore):
(WebCore::DeviceMotionController::~DeviceMotionController):
(DeviceMotionController):

dom/Document.cpp:

Remove all implementations which are related DeviceOrientationEvnet and DeviceMotionEvent.
Because DeviceController checks suspend and stop status of active dom object before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):

loader/EmptyClients.h:
page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

2:24 AM Changeset in webkit [135267] by commit-queue@webkit.org

2 edits
2 moves
1 add in trunk/Tools

[EFL][GTK]Sharing accessibility support in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=99011

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-20
Reviewed by Martin Robinson.

Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.

WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.

(WTR::AccessibilityController::logAccessibilityEvents):

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.

1:56 AM Changeset in webkit [135266] by haraken@chromium.org

2 edits in trunk/Source/WebCore

[V8] Remove V8ParameterBase
https://bugs.webkit.org/show_bug.cgi?id=102774

Reviewed by Adam Barth.

V8ParameterBase is a redundant indirection.
We can flatten methods of V8ParameterBase to V8Parameter.

No tests. No change in behavior.

bindings/v8/V8StringResource.h:

(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::toString):
(WebCore::::prepare):

1:21 AM Changeset in webkit [135265] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Mark inspector/profiler/cpu-profiler-profiling-without-inspector.html
as crashing.

platform/chromium/TestExpectations:

12:20 AM Changeset in webkit [135264] by zandobersek@gmail.com

2 edits in trunk/Tools

webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693

Reviewed by Dirk Pranke.

When checking code coverage, the unit tests should not be run in parallel
as this causes the tracing functions (set via sys.settrace in the coverage
module) being overriden, resulting in incorrect coverage reports.

Scripts/webkitpy/test/main.py:

(Tester._run_tests):

12:16 AM Changeset in webkit [135263] by commit-queue@webkit.org

12 edits
4 adds in trunk

Use localized date-time format in datetime input
https://bugs.webkit.org/show_bug.cgi?id=102769

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Source/WebCore:

Move the implementation of Locale::dateTimeFormatWithSeconds and Locale::dateTimeFormatWithoutSeconds
to its subclasses and use platform-specific methods to get date-time pattern.
Because Windows does not provide an API to get date-time pattern. We use fixed "{date} {time}"
pattern for Windows.

Test: fast/forms/datetime/datetime-appearance-l10n.html

platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::initializeDateTimeFormat): Retrieve datetime formats too.
(WebCore::LocaleICU::dateTimeFormatWithSeconds): Added.
(WebCore):
(WebCore::LocaleICU::dateTimeFormatWithoutSeconds): Added.

platform/text/LocaleICU.h:

(LocaleICU): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

platform/text/LocaleNone.cpp:

(LocaleNone):
(WebCore::LocaleNone::dateTimeFormatWithSeconds): Added. Always returns "dd/MM/yyyyy HH:mm:ss".
(WebCore):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds): Added. Always returns "dd/MM/yyyyy HH:mm".

platform/text/PlatformLocale.cpp:

(WebCore): Remove dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() as these are now pure virtual.

platform/text/PlatformLocale.h:

(Locale): Make dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() pure virtual.

platform/text/mac/LocaleMac.h:

(LocaleMac): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::dateTimeFormatterWithSeconds): Added.
(WebCore):
(WebCore::LocaleMac::dateTimeFormatterWithoutSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithoutSeconds): Added.

platform/text/win/LocaleWin.cpp:

(WebCore::LocaleWin::dateTimeFormatWithSeconds): Copied from original Locale::dateTimeFormatWithSeconds().
(WebCore):
(WebCore::LocaleWin::dateTimeFormatWithoutSeconds): Copied from original Locale::dateTimeFormatWithoutSeconds().

platform/text/win/LocaleWin.h:

(LocaleWin): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

LayoutTests:

fast/forms/datetime/datetime-appearance-l10n-expected.txt: Added.
fast/forms/datetime/datetime-appearance-l10n.html: Added. We can confirm vi-vn have time-date ordering.
platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
platform/chromium/TestExpectations:

12:12 AM Changeset in webkit [135262] by vsevik@chromium.org

2 edits in branches/chromium/1312/Source/WebCore/inspector/front-end

Merge 134944 - Web Inspector: Workaround to show shortcuts for panels that hasn't been loaded.
https://bugs.webkit.org/show_bug.cgi?id=102488

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-16
Reviewed by Vsevolod Vlasov.

Panels are lazily loaded / instantiated.
Panel constructors register keyboard shortcuts.

When user open shortcuts screen all panel should be loaded.
Otherwise some shortcuts will be missing.

inspector/front-end/ShortcutsScreen.js: Added callback invokation.
inspector/front-end/inspector.js:

Provided callback that loads all panels.

TBR=commit-queue@webkit.org
BUG=160943
Review URL: https://codereview.chromium.org/11413082

12:09 AM Changeset in webkit [135261] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r135257.
http://trac.webkit.org/changeset/135257
https://bugs.webkit.org/show_bug.cgi?id=102777

Broke Chromium Debug compilation (Requested by yurys on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-20

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getNode):

12:06 AM Changeset in webkit [135260] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Revert r133149: breaks revision reverting
https://bugs.webkit.org/show_bug.cgi?id=102672

Reviewed by Yury Semikhatsky.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onFormattedChanged):
(WebInspector.JavaScriptSourceFrame.prototype._onWorkingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._innerSetContent):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed