Timeline
Nov 24, 2012:
- 11:25 PM Changeset in webkit [135666] by
-
- 3 edits in trunk/Source/WTF
Chromium should use TCMalloc on Mac to go fast
https://bugs.webkit.org/show_bug.cgi?id=102866
Reviewed by Eric Seidel.
This patch enables TCMalloc for some WebKit objects. It improves
dom-modify on Mac by 5-10%.
On non-Mac platforms, Chromium already uses TCMalloc throughout the
project. Unfortunately, we haven't yet figured out how to turn TCMalloc
on globally on Mac because the approach we use for other platforms makes
some OS X APIs sad.
The next best thing would be to enable TCMalloc for WebKit by
overriding the global new and delete operator, as is done on apple-mac
and other platforms. Unfortunately, we cannot use that approach either
because the Chromium WebKit API is not memory tight.
Fortunately, WebKit has a mechanism for selectively enabling TCMalloc
for a selection of objects by overriding the new and delete operators
on those objects. This patch opts chromium-mac into that scheme by
setting the appropriate preprocessor macros.
- WTF.gyp/WTF.gyp:
- wtf/Platform.h:
- 8:49 PM Changeset in webkit [135665] by
-
- 2 edits in trunk/Websites/webkit.org
Substitute "use" for "user" in sentence about naming convention for
enum members so that it reads well.
- coding/coding-style.html:
- 8:13 PM Changeset in webkit [135664] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Find-on-page keeps stale pointer
https://bugs.webkit.org/show_bug.cgi?id=103190
Patch by Andy Chen <andchen@rim.com> on 2012-11-24
Reviewed by Rob Buis.
Find on page: pendingScopingEffort stores stale pointer when frames unload,
we need to cancel those scoping efforts.
PR 250807.
Internally reviewed by Yongxin Dai and Mike Fenton.
- WebKitSupport/InPageSearchManager.cpp:
(InPageSearchManager::DeferredScopeStringMatches):
(BlackBerry::WebKit::InPageSearchManager::frameUnloaded):
- 6:52 PM Changeset in webkit [135663] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Refactor RenderThemeEfl::paintThemePart()
https://bugs.webkit.org/show_bug.cgi?id=103192
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Refactor RenderThemeEfl::paintThemePart() so that:
- Some C'ism is removed
- RTL related code is moved to applyEdjeRTLState()
- evas_render() is called instead of evas_render_updates() to avoid creating uselessly update rects.
No new tests, no behavior change for layout tests.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::applyEdjeRTLState):
(WebCore):
(WebCore::RenderThemeEfl::paintThemePart):
- platform/efl/RenderThemeEfl.h:
(RenderThemeEfl):
- 6:38 PM Changeset in webkit [135662] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Layout test comes to crash on WK1
https://bugs.webkit.org/show_bug.cgi?id=103170
Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Switch off accelerated compositing for WK1 because GraphicsContext3D is
missing direct rendering implementation that is required for EFL WK1.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 6:22 PM Changeset in webkit [135661] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Remove traces of MediaControlRootElement
https://bugs.webkit.org/show_bug.cgi?id=103174
Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-11-24
Reviewed by Adam Barth.
Now that nothing is using MediaControlRootElement any more,
we can remove the FIXME and MediaControlRootElement enum left
over from bug 88871.
- public/WebContextMenuData.h:
- 6:18 PM Changeset in webkit [135660] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Stop the mess with DECLARE_EWK_VIEW_CALLBACK arg type definition
https://bugs.webkit.org/show_bug.cgi?id=103187
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Now the client should pass to DECLARE_EWK_VIEW_CALLBACK macro exacly the
same arg type s/he wants to have in the Ewk_View callback.
- UIProcess/API/efl/EwkViewCallbacks.h:
(EvasObjectHolder):
(EwkViewCallbacks::EvasObjectHolder::EvasObjectHolder):
(EwkViewCallbacks):
- 3:05 PM Changeset in webkit [135659] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Avoid access violation when frame is NULL.
https://bugs.webkit.org/show_bug.cgi?id=68753
BitmapImage::drawFrameMatchingSourceSize causes an access violation
if BitmapImage::frameAtIndex returns NULL. (Found by David Delaune).
Reviewed by Simon Fraser.
- platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Check for null
cairo_surface_t pointer and avoid dereferencing.
- 2:25 PM Changeset in webkit [135658] by
-
- 3 edits in trunk/Source/WebCore
[EFL] Refactor RenderThemeEfl::getThemePartFromCache()
https://bugs.webkit.org/show_bug.cgi?id=103186
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Refactor getThemePartFromCache() so that a list is used
for the cache instead of a vector. The function moves
items to the head of the container which is much more
efficient with a list than a vector.
The list ordering is also slightly altered so that the
cached parts that were used last come first. Previously,
they were sorted by creation time which may cause an
item to be removed from the cache because it is older
even if is was used recently.
This patch also gets rid of some code duplication at the
end of the function.
No new tests, no behavior change.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::ThemePartCacheEntry::create): Return
a smart pointer instead of a raw pointer.
(WebCore::RenderThemeEfl::getThemePartFromCache):
(WebCore::RenderThemeEfl::clearThemePartCache): Rename
flushThemePartCache to clearThemePartCache for clarity.
(WebCore::RenderThemeEfl::loadTheme):
(WebCore::RenderThemeEfl::RenderThemeEfl):
(WebCore::RenderThemeEfl::~RenderThemeEfl):
- platform/efl/RenderThemeEfl.h:
(ThemePartCacheEntry):
(RenderThemeEfl):
- 12:34 PM Changeset in webkit [135657] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] RTSP should use the same MediaDocument as HTTP videos.
https://bugs.webkit.org/show_bug.cgi?id=103185
RIM PR 250114
Patch by Liam Quinn <lquinn@rim.com> on 2012-11-24
Reviewed by George Staikos.
Make our MediaPlayer implementation indicate that it supports RTSP. That way, DOMImplementation::createDocument will create the same MediaDocument as is used for HTTP videos.
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
- 12:31 PM Changeset in webkit [135656] by
-
- 3 edits in trunk/Source/WebCore
Put computed style 'font-family' values in the CSSValuePool.
<http://webkit.org/b/103184>
Reviewed by Ojan Vafai.
Use CSSValuePool::createFontFamilyValue() when handing out 'font-family' values from CSSComputedStyleDeclaration.
This avoids creating extra CSSPrimitiveValue objects since we already have these in the pool from parsing.
Also added a max capacity to the font-family cache (using random eviction.)
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForFamily):
- css/CSSValuePool.cpp:
(WebCore::CSSValuePool::createFontFamilyValue):
- 11:35 AM Changeset in webkit [135655] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Text not selected when input field focused.
https://bugs.webkit.org/show_bug.cgi?id=103182
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-24
Reviewed by George Staikos.
Reviewed Internally by: Mike Fenton, Eli Fidler
PR #250163
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
- 11:24 AM Changeset in webkit [135654] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: updated expectations for failures in:
- http/tests/local/drag-over-remote-content.html
https://bugs.webkit.org/show_bug.cgi?id=103181
- media/video-seek-past-end-playing.html
https://bugs.webkit.org/show_bug.cgi?id=103183
- platform/chromium/TestExpectations:
- 9:15 AM Changeset in webkit [135653] by
-
- 11 edits in trunk/Tools
Add the --order option to NRWT
https://bugs.webkit.org/show_bug.cgi?id=102229
Reviewed by Dirk Pranke.
The --order option controls in what order the gathered tests will be run.
There are 3 options:
- natural, the tests are sorted in natural order,
- random, the tests are sorted in random order,
- none, the tests are kept in the order in which they were specified through
arguments or the test list.
The natural option is the default one and maintains the current behavior.
The none option is primarily intended to be used with the --test-list option,
with the test list file expected to list specific test names.
When a directory is specified as one of the paths from under which tests should
be gathered and the none option is used, that path will expand to all the tests
under it, with these tests sorted in the natural order.
Using --order=random duplicated the behavior of the --randomize-order option, so
the latter is removed.
This patch also incorporates the change with which makes it is possible to specify
a test via arguments or the test list multiple tests and then have the test run
that many times.
- Scripts/webkitpy/common/find_files.py:
(find): Accept an optional sorting key that is used to sort files found in the directories
that the given paths specify.
(_normalized_find): Both paths that are then searched for the tests and the tests that
were found are now kept in lists. This makes it possible to run a test multiple times
by specifying it multiple times through arguments or the test list file.
(_normalized_find.sort_by_directory_key):
- Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
(LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
(LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.init): The Sharder class no longer needs a test path separator.
(Sharder.init): Ditto.
(Sharder._resize_shards):
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
(SharderTests.get_shards): Modify the Shader initializing as required.
(SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
are now moved to the base Port unit tests.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
the new --order option.
- Scripts/webkitpy/layout_tests/port/base.py:
(Port.tests): This method should now return a list of all the tests found in the specified
paths.
(Port._real_tests): A list is required, so no conversion to a set is made.
(Port):
(Port.test_key): Place this method here for now, but it should really move into a separate
module.
(Port._natural_sort_key): Ditto.
(Port._natural_sort_key.tryint):
(Port._virtual_tests): A list is required, so the function now operates on that rather than
on a set.
- Scripts/webkitpy/layout_tests/port/base_unittest.py:
(PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
list rather than an empty set.
(PortTest.test_dont_require_http_server):
(NaturalCompareTest): The natural sorting unit tests are placed here for now.
(NaturalCompareTest.assert_cmp):
(NaturalCompareTest.test_natural_compare):
(KeyCompareTest): The test name key unit tests are placed here for now.
(KeyCompareTest.assert_cmp):
(KeyCompareTest.test_test_key):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
by using --order=random.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
various aspects of this change.
(MainTest.test_natural_order):
(MainTest):
(MainTest.test_natural_order_test_specified_multiple_times):
(MainTest.test_random_order):
(MainTest.test_random_order_test_specified_multiple_times):
(MainTest.test_no_order):
(MainTest.test_no_order_test_specified_multiple_times):
(MainTest.test_no_order_with_directory_entries_in_natural_order):
- Scripts/webkitpy/tool/commands/queries.py:
(PrintExpectations.execute): Operate on a set of tests when printing out expectations.
- 8:46 AM Changeset in webkit [135652] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Check errors in EwkView callbacks usage at compile time
https://bugs.webkit.org/show_bug.cgi?id=103177
Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-24
Reviewed by Kenneth Rohde Christiansen.
Errors in EwkView callbacks usage are now checked at compile time.
- UIProcess/API/efl/EwkViewCallbacks.h:
(CallBack):
(EwkViewCallbacks::CallBack::CallBack):
(EwkViewCallbacks::CallBack::call):
- 7:32 AM Changeset in webkit [135651] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed, rolling out r135648 and r135649.
http://trac.webkit.org/changeset/135648
http://trac.webkit.org/changeset/135649
https://bugs.webkit.org/show_bug.cgi?id=103176
This change cannot be built with a qt-minimal configuration.
(Requested by zalbisser on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- 7:11 AM Changeset in webkit [135650] by
-
- 3 edits in trunk/Source/WebCore
It's confusing that return values of 'bool Node::dispatchEvent(...)' and 'bool Node::dispatchMouseEvent(..)' have the opposite meanings.
https://bugs.webkit.org/show_bug.cgi?id=103058
Reviewed by Ojan Vafai.
Refactor MouseEventDispatchMediator::dispatchEvent() and
EventHandler::dispatchMouseEvent() so that they return bool
which has the same meaning of the return value of
Node::dispatchEvent().
No tests. No change in behavior.
- dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
- 7:11 AM Changeset in webkit [135649] by
-
- 2 edits in trunk/Source/WebKit/qt
Unreviewed Qt build fix:
Make sure QGLWidget definition is available.
- WebCoreSupport/PageClientQt.cpp:
- 6:41 AM Changeset in webkit [135648] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] Make sure the QGLWidget context is current when creating the TextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103142
When creating the TextureMapperGL for WK1 we have to make sure
that the GL context provided by the QGLWidget is current.
Otherwise the GraphicsContext3DQt created by TextureMapperGL will pick up
the wrong pointer by calling QOpenGLContext::currentContext().
Reviewed by Kenneth Rohde Christiansen.
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
- 3:28 AM Changeset in webkit [135647] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- 2:50 AM Changeset in webkit [135646] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r135600.
http://trac.webkit.org/changeset/135600
https://bugs.webkit.org/show_bug.cgi?id=103173
It made EFL API test is failed (Requested by gyuyoung_mbp on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-24
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/efl/PlatformUtilities.cpp:
(TestWebKitAPI::Util::sleep):
- TestWebKitAPI/efl/PlatformWebView.cpp:
- 2:05 AM Changeset in webkit [135645] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Too many tests come to crashe after build 7830 on
EFL Linux 64-bit Release bot.
- platform/efl-wk1/TestExpectations:
- 12:51 AM Changeset in webkit [135644] by
-
- 11 edits in releases/WebKitGTK/webkit-1.10
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435
Reviewed by Martin Robinson.
More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.
.:
- GNUmakefile.am: add variable that will hold the list of source files
for libWebCorePlatform .
Source/WebCore:
- GNUmakefile.am: add new libWebCorePlatform convenience library.
- GNUmakefile.list.am: move list of platform/* files to its own variable.
Source/WebKit/gtk:
- GNUmakefile.am: link libWebCorePlatform into libwebkitgtk
Source/WebKit2:
- GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk
Tools:
- GNUmakefile.am: link libWebCorePlatform into DRT
Conflicts:
Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.list.am
Nov 23, 2012:
- 10:40 PM Changeset in webkit [135643] by
-
- 3 edits in trunk/Source/WebCore
Fix unused parameter compile warnings
https://bugs.webkit.org/show_bug.cgi?id=103167
Patch by Kangil Han <kangil.han@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.
Remove compile warning messages by omitting parameter name and using UNUSED_PARAM.
- accessibility/atk/WebKitAccessibleHyperlink.cpp:
(webkitAccessibleHyperlinkIsSelectedLink):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextAfterOffset):
(webkitAccessibleTextGetTextAtOffset):
(webkitAccessibleTextGetTextBeforeOffset):
(webkitAccessibleTextGetOffsetAtPoint):
- 10:13 PM Changeset in webkit [135642] by
-
- 5 edits in trunk/Source
Unreviewed, rolling out r135575.
http://trac.webkit.org/changeset/135575
https://bugs.webkit.org/show_bug.cgi?id=103169
It made all tests assert (Requested by Ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
Source/WebKit2:
- qt/MainQt.cpp:
(WebKit):
(main):
- 9:18 PM Changeset in webkit [135641] by
-
- 2 edits in trunk/Source/WebCore
listMarkerText() should create 8 bit strings when possible
https://bugs.webkit.org/show_bug.cgi?id=103011
Reviewed by Filip Pizlo.
Made processing of marker text items use 8 bit strings where possible in order to reduce 16 bit strings.
Changes covered by existing tests.
- rendering/RenderListMarker.cpp:
(WebCore::toRoman): Changed character constants and buffer to build string to LChar's
(WebCore::toAlphabeticOrNumeric): Made a template based on character type.
(WebCore::toSymbolic): Made a template based on character type.
(WebCore::toAlphabetic): Made a template based on character type.
(WebCore::toNumeric): Added character type template parameter.
(WebCore::listMarkerText): Changed character constants to LChar where possible.
- 7:16 PM Changeset in webkit [135640] by
-
- 21 edits4 adds in trunk/Source
Any function that can log things should be able to easily log them to a memory buffer as well
https://bugs.webkit.org/show_bug.cgi?id=103000
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Change all users of WTF::dataFile() to expect a PrintStream& rather than a FILE*.
- bytecode/Operands.h:
(JSC::OperandValueTraits::dump):
(JSC::dumpOperands):
(JSC):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::dump):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::dump):
- dfg/DFGCommon.h:
(JSC::DFG::NodeIndexTraits::dump):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::dump):
- dfg/DFGVariableEvent.cpp:
(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):
- dfg/DFGVariableEvent.h:
(VariableEvent):
- disassembler/Disassembler.h:
(JSC):
(JSC::tryToDisassemble):
- disassembler/UDis86Disassembler.cpp:
(JSC::tryToDisassemble):
Source/WTF:
We have a number of places where we pass around a FILE* as a target to which to print
some logging information. But the purpose of passing FILE* instead of always assuming
that we should dump to stderr is that it may be sometimes useful to send the logging
information elsewhere. Unfortunately, FILE* isn't quite powerful enough: it's combersome
to use it to send logging to a string, for example.
We could get around this by using <iostream> and <sstream>, but so far this aspect of
C++ has not been part of the WebKit coding conventions. Personally I find <iostream>
awkward due to its abuse of operator overloading.
So this patch introduces the PrintStream abstract class, which offers printf-like
functionality while completely abstracting the destination and mechanism of the printing
output. It would be trivial to implement a StringPrintStream, for example. This will feed
into work on https://bugs.webkit.org/show_bug.cgi?id=102999.
This also sets us up for creating templatized print() and println() methods that will
allow us to say things like out.print("count = ", count, "\n"), but that is the topic
of https://bugs.webkit.org/show_bug.cgi?id=103009.
This patch also changes dataLog() to use FilePrintStream internally, and WTF::dataFile()
now returns a FilePrintStream&. Any previous users of WTF::dataFile() have been changed
to expect a PrintStream&.
- GNUmakefile.list.am:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/DataLog.cpp:
(WTF):
(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):
(WTF::dataLogV):
(WTF::dataLogString):
- wtf/DataLog.h:
(WTF):
- wtf/FilePrintStream.cpp: Added.
(WTF):
(WTF::FilePrintStream::FilePrintStream):
(WTF::FilePrintStream::~FilePrintStream):
(WTF::FilePrintStream::vprintf):
(WTF::FilePrintStream::flush):
- wtf/FilePrintStream.h: Added.
(WTF):
(FilePrintStream):
(WTF::FilePrintStream::file):
- wtf/PrintStream.cpp: Added.
(WTF):
(WTF::PrintStream::PrintStream):
(WTF::PrintStream::~PrintStream):
(WTF::PrintStream::printf):
(WTF::PrintStream::print):
(WTF::PrintStream::println):
(WTF::PrintStream::flush):
(WTF::print):
- wtf/PrintStream.h: Added.
(WTF):
(PrintStream):
(WTF::print):
(WTF::println):
- 5:30 PM Changeset in webkit [135639] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Define platform limitations in platform layer
https://bugs.webkit.org/show_bug.cgi?id=103160
Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-23
Reviewed by Rob Buis.
Taking length as const unsigned in checkSpellingOfStringAsync.
This value is unchanging and should never be less than 0, even
in an error case.
Internally reviewed by Mike Fenton.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
- 4:42 PM Changeset in webkit [135638] by
-
- 12 edits in trunk/Source
Remove unused ScrollByPixelVelocity
https://bugs.webkit.org/show_bug.cgi?id=102840
Reviewed by Sam Weinig.
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=80311 wrongly introduced a new
kind of scroll: "ScrollByPixelVelocity". This code is not used on any platform
and will not be of use in the future so this patch removes it.
No new tests: code removal/cleanup.
- page/EventHandler.cpp:
(WebCore::EventHandler::defaultWheelEventHandler):
(WebCore::EventHandler::handleGestureEvent):
- platform/PlatformWheelEvent.h:
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::handleWheelEvent):
- platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::scroll):
(WebCore::ScrollAnimatorNone::cancelAnimations):
(WebCore::ScrollAnimatorNone::animationTimerFired):
- platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
- platform/ScrollTypes.h:
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scroll):
Source/WebKit/chromium:
Removed test for deleted code.
- tests/ScrollAnimatorNoneTest.cpp:
Source/WTF:
The GESTURE_ANIMATION feature turns on code in WebCore is unused.
Remove it.
No new tests: code removal/cleanup.
- wtf/Platform.h:
- 3:20 PM Changeset in webkit [135637] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: updated test expectations for failure in
- svg/batik/text/textPosition2.svg
https://bugs.webkit.org/show_bug.cgi?id=103148
- platform/chromium/TestExpectations:
- 3:02 PM Changeset in webkit [135636] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: text failures in:
- inspector/console/command-line-api-inspect.html
- inspector/runtime/runtime-localStorage-getProperties.html
https://bugs.webkit.org/show_bug.cgi?id=103161
- platform/chromium/TestExpectations:
- 2:39 PM Changeset in webkit [135635] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: update test expectations for
svg/hixie/perf/007.xml
- platform/chromium/TestExpectations:
- 2:24 PM Changeset in webkit [135634] by
-
- 1 edit1 move1 add in trunk/LayoutTests
[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104
Patch by Alexis Menard <alexis@webkit.org> on 2012-11-23
Reviewed by Julien Chaffraix.
Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).
- fast/backgrounds/background-position-parsing-2-expected.txt:
- fast/backgrounds/background-position-parsing-2.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 2:04 PM Changeset in webkit [135633] by
-
- 2 edits in trunk/Source/WebCore
Removing unnecessary RenderBox friend access in RenderObject
https://bugs.webkit.org/show_bug.cgi?id=103159
Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2012-11-23
Reviewed by Eric Seidel.
RenderObject has several classes marked as friend, between them,
there is RenderBox which is derived from it indirectly and is not accessing
its forefather private data making unnecessary the 'friend' access level.
No new tests, no changes in functionality.
- rendering/RenderObject.h:
(RenderObject):
- 1:24 PM Changeset in webkit [135632] by
-
- 34 edits in trunk
[CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
https://bugs.webkit.org/show_bug.cgi?id=102104
Reviewed by Julien Chaffraix.
.:
Protect the new feature behind a feature flag.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- configure.ac:
Source/JavaScriptCore:
Protect the new feature behind a feature flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Implement the parsing of the CSS3 background-position property which
allows to specify up to four values to position the background. It is
documented here :
http://www.w3.org/TR/css3-background/#the-background-position . I
decided to split up the patch is two pieces, the parsing and later I
will do the rendering. I kept the old code as much as possible (i.e.
the two values parsing) as it is used not only by background-position
but by few other properties. The new four values support is only valid
on the property itself but does not work on the shorthand.
Opera has already implemented this feature.
I extended backgrounds/background-position-parsing-2.html to cover the
new possible values as well as buggy values.
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- GNUmakefile.features.am:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFillPositionComponent): Modify this function
to allow creation of CSS primitive values with not only percentage or
length but with keywords also as the new <position> type allows to
specify keywords, for example top 30px right 20px.
(WebCore):
(WebCore::isValueConflictingWithCurrentEdge):
(WebCore::isBackgroundPositionKeyword):
(WebCore::CSSParser::parse3ValuesBackgroundPosition):
(WebCore::CSSParser::parse4ValuesBackgroundPosition):
(WebCore::CSSParser::parseFillBackgroundPosition): This function counts
the number of words for the property value and call dedicated parsing
functions for each case. Note that in case of two values we just call the old CSS 2.1
method.
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillProperty): Only call the new parsing
function if the feature is activated otherwise fallback to the old code
path.
- css/CSSParser.h:
Source/WebKit/chromium:
Protect the new feature behind a feature flag.
- features.gypi:
Source/WebKit/mac:
Protect the new feature behind a feature flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Protect the new feature behind a feature flag.
- Configurations/FeatureDefines.xcconfig:
Tools:
Protect the new feature behind a feature flag.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
WebKitLibraries:
Protect the new feature behind a feature flag.
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
LayoutTests:
Add new tests to cover the new parsing for the background position
property. For now the computed style checks are commented out because
the rendering part of the feature is not yet implemented (i.e.
FillLayer does not contain yet the feature and this is what
CSSComputedStyleDeclaration is using).
- fast/backgrounds/background-position-parsing-2-expected.txt:
- fast/backgrounds/background-position-parsing-2.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:32 AM Changeset in webkit [135631] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening.
Adding failure expectation for fast/dom/shadow/host-wrapper-reclaimed.html.
- platform/gtk/TestExpectations:
- 11:17 AM Changeset in webkit [135630] by
-
- 2 edits in trunk/LayoutTests
Unreviewed: updated test expecations -- additional failures in
- fast/text/large-text-composed-char.html
- fast/text/text-letter-spacing.html
- http/tests/inspector/indexeddb/database-data.html
and new failures:
- fast/frames/frame-unload-crash2.html
- platform/chromium/TestExpectations:
- 10:43 AM Changeset in webkit [135629] by
-
- 26 edits2 adds in trunk
Adding occlusion detection to reduce overdraw in RenderBox background rendering
https://bugs.webkit.org/show_bug.cgi?id=102557
Reviewed by Stephen White.
Source/WebCore:
Adding hasAlpha method to all classes dervived from CSSImageValue and
StyleImage, in order to support occlusion testing.
This allows the FillLayer recursion to stop early when an opaque layer
is encountered while applying a CSS background style. This also allows
the elimination of background color application when the background is
completely covered by an image. The optimization also skips the
clearing of the page's root element when the page background is
entirely covered by an image (e.g a tiled bitmap or a gradient)
Test: fast/backgrounds/background-opaque-images-over-color.html
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageHasAlpha):
(WebCore):
(WebCore::CSSCrossfadeValue::isPending):
(WebCore::CSSCrossfadeValue::hasAlpha):
- css/CSSCrossfadeValue.h:
(CSSCrossfadeValue):
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::hasAlpha):
(WebCore):
- css/CSSGradientValue.h:
(CSSGradientValue):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::hasAlpha):
(WebCore):
- css/CSSImageGeneratorValue.h:
(CSSImageGeneratorValue):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::hasAlpha):
(WebCore):
- css/CSSImageValue.h:
(WebCore):
(CSSImageValue):
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::currentFrameHasAlpha):
Test whether a cached image has alpha, with side effect of ensuring
the image is in cache. (new method)
(WebCore):
- loader/cache/CachedImage.h:
(CachedImage):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
Added layer recursion early exit when an opaque layer is encountered.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Eliminated background color fill when the layer contains an opaque
image that covers the entire RenderBox.
- rendering/style/FillLayer.cpp:
(WebCore::FillLayer::hasOpaqueImage):
Returns true if the layer's image is known to be fully opaque.
(WebCore):
(WebCore::FillLayer::hasRepeatXY):
- rendering/style/FillLayer.h:
(FillLayer):
- rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::hasAlpha):
(WebCore):
- rendering/style/StyleCachedImage.h:
(StyleCachedImage):
- rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::hasAlpha):
(WebCore):
- rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::hasAlpha):
(WebCore):
- rendering/style/StyleGeneratedImage.h:
(StyleGeneratedImage):
- rendering/style/StyleImage.h:
(StyleImage):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::hasAlpha):
LayoutTests:
New test exercises different CSS background style use cases that
are candidates for optimization by occlusion culling.
- fast/backgrounds/background-opaque-images-over-color-expected.txt: Added.
- fast/backgrounds/background-opaque-images-over-color.html: Added.
- platform/chromium/TestExpectations:
- 10:39 AM Changeset in webkit [135628] by
-
- 2 edits in trunk/LayoutTests
Gardening: updated expectations (pass/timeout) for
week-multiple-fields-preserve-value-after-history-back.html
https://bugs.webkit.org/show_bug.cgi?id=103152
- platform/chromium/TestExpectations:
- 10:17 AM Changeset in webkit [135627] by
-
- 2 edits in trunk/LayoutTests
[EFL] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.
Skipping Accessibility tests for wk1/wk2.
Some of the implementation is still missing.
- platform/efl/TestExpectations:
- 9:15 AM Changeset in webkit [135626] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my e-mail address.
- Scripts/webkitpy/common/config/committers.py:
- 9:13 AM Changeset in webkit [135625] by
-
- 4 edits2 adds in trunk
Page background color bleeds through inner edge of div border with rounded edges
https://bugs.webkit.org/show_bug.cgi?id=103089
Reviewed by Stephen White.
Source/WebCore:
Test that verifies whether a RenderBoxEdge is more than 2 pixels wide
was applying the content scale factor backwards, so the
obscuresBackgroundEdge was falsely passing for downsized boxes.
Test: fast/backgrounds/gradient-background-leakage-2.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::BorderEdge::obscuresBackgroundEdge):
LayoutTests:
New layout test to verify that there is no color bleeding between
a div element's border and background when there are rounded corners
an a scale that reduces a thick border down to a width of less than
two pixels.
- fast/backgrounds/gradient-background-leakage-2-expected.txt: Added.
- fast/backgrounds/gradient-background-leakage-2.html: Added.
- platform/chromium/TestExpectations:
- 9:10 AM Changeset in webkit [135624] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: Match the behavior of selfOrAncestorHaveNonAffineTransforms() to its name.
https://bugs.webkit.org/show_bug.cgi?id=103097
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.
CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms() does
not check its ancestor. This patch makes this method check its ancestor
to match its name.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
- 9:06 AM Changeset in webkit [135623] by
-
- 2 edits in trunk/LayoutTests
Gardening: update expectations for fast/events/stopPropagation-submit.html flaky
https://bugs.webkit.org/show_bug.cgi?id=103149
- platform/chromium/TestExpectations:
- 8:57 AM Changeset in webkit [135622] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: LayerTreeRenderer::removeTile() does not remove tiles actually.
https://bugs.webkit.org/show_bug.cgi?id=103030
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.
LayerTreeRenderer::removeTile() must add a backing store into
m_backingStoresWithPendingBuffers. Otherwise, tiles are not removed.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::removeTile):
- 8:54 AM Changeset in webkit [135621] by
-
- 2 edits in trunk
[CMake] Add support for winflexbison distribution
https://bugs.webkit.org/show_bug.cgi?id=102551
Reviewed by Laszlo Gombos.
Since GnuWin32 does not provide recent versions of bision and flex supporting
the alternative winflexbison distribution is the prefered option.
- Source/cmake/WebKitMacros.cmake:
- 8:51 AM Changeset in webkit [135620] by
-
- 7 edits in trunk/Source
[TexMap] Remove dependency of TextureMapperLayer on GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103046
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.
Source/WebCore:
It is a preparation patch for Threaded Coordinated Graphics on WK1.
We want to make TextureMapperLayer into an actor model. After making an actor
model, GraphicsLayerTextureMapper and LayerTreeRenderer will communicate with
TextureMapperLayer using message passing. In the first step, we want to hide
GraphicsLayerTextureMapper from TextureMapperLayer.
There are 2 kinds of dependencies of TextureMapperLayer in GraphicsLayerTextureMapper.
- To query layer states
- To paint layer contents
In this patch, we removed the second dependency. Currently, TextureMapperLayer
requests painting contents to GraphicsLayerTextureMapper in WK1 while
Coordinated Graphics prepares the contents in LayerTreeRenderer. This patch
makes WK1 prepare the contents in GraphicsLayerTextureMapper like
LayerTreeRenderer.
We will remove the first dependency in a follow-up patch.
Covered by existing layout tests.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly):
(WebCore::GraphicsLayerTextureMapper::flushCompositingState):
(WebCore):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingState):
(WebCore::GraphicsLayerTextureMapper::didFlushCompositingStateRecursive):
(WebCore::GraphicsLayerTextureMapper::updateBackingStore):
(WebCore::GraphicsLayerTextureMapper::prepareBackingStore):
(WebCore::GraphicsLayerTextureMapper::shouldHaveBackingStore):
(WebCore::GraphicsLayerTextureMapper::drawRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::setDebugBorder):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
(WebCore::GraphicsLayerTextureMapper::setHasOwnBackingStore):
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::rootLayer):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::textureMapper):
(WebCore):
(WebCore::TextureMapperLayer::flushCompositingState):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore):
(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):
(WebCore::TextureMapperLayer::setBackingStore):
(State):
(WebCore::TextureMapperLayer::State::State):
Source/WebKit2:
This patch makes GraphicsLayerTextureMapper create its own backing
store. However, LayerTreeRenderer also creates its own backing store. So
when LayerTreeRenderer uses GraphicsLayerTextureMapper,
LayerTreeRenderer needs GraphicsLayerTextureMapper to not create its own
backing store.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::getBackingStore):
- 8:47 AM Changeset in webkit [135619] by
-
- 10 edits in trunk
[EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=100757
Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-23
Reviewed by Laszlo Gombos.
Tools:
Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
Updating CMake files due to changes from Bug 99011.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR::AccessibilityController::AccessibilityController):
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityController.h:
(AccessibilityController):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
- WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
LayoutTests:
Unskipping EFL Accessiblity tests for wk2.
- platform/efl-wk1/TestExpectations:
- platform/efl/TestExpectations:
- 8:40 AM Changeset in webkit [135618] by
-
- 5 edits in trunk/Source/WebCore
[ENCHANT] Infinite loop when end word position is not found
https://bugs.webkit.org/show_bug.cgi?id=103139
Reviewed by Martin Robinson.
Covered by existing tests in editing/spelling.
- editing/visible_units.cpp:
(WebCore::isLogicalStartOfWord): Make it private again.
(WebCore::islogicalEndOfWord): Ditto.
- editing/visible_units.h:
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::checkSpellingOfWord): Helper funtion
to check a word inside a string using the loaded dictionaries.
(WebCore::TextCheckerEnchant::checkSpellingOfString): Optimize and
simply the code by using the word iterator to iterate the
words.
- platform/text/enchant/TextCheckerEnchant.h:
(TextCheckerEnchant):
- 8:38 AM Changeset in webkit [135617] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: test expectations failures.
https://bugs.webkit.org/show_bug.cgi?id=103148
- platform/chromium/TestExpectations:
- 8:37 AM Changeset in webkit [135616] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r135486): ASSERT(isMainThread()) hit in LayerTreeRenderer::setActive(bool)
https://bugs.webkit.org/show_bug.cgi?id=103077
Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-23
Reviewed by Noam Rosenthal.
Currently, the painting thread uses purgeGLResources() and setActive().
QQuickWebPage::updatePaintNode() indirectly calls both methods after
locking the main thread.
This patch changes two points.
- Remove ASSERT(isMainThread()) in methods that the painting thread can
call.
- Make purgeGLResources() and setActive() call methods of
LayerTreeCoordinatorProxy via dispatchOnMainThread().
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::renderNextFrame):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit):
(WebKit::LayerTreeRenderer::purgeBackingStores):
(WebKit::LayerTreeRenderer::setActive):
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
- 8:27 AM Changeset in webkit [135615] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Meta viewport can't be changed dynamically
https://bugs.webkit.org/show_bug.cgi?id=103098
Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
PR: 237072
Reset m_userPerformedManualZoom and enable
m_shouldZoomToInitialScaleAfterLoadFinished so that we can relayout the
page and zoom it to fit the screen when we dynamically change the meta
viewport after the load is finished.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):
- 8:15 AM Changeset in webkit [135614] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening: update expectations for now crashing test
visibility-simple-canvas2d-layer.html
https://bugs.webkit.org/show_bug.cgi?id=98086
- platform/chromium/TestExpectations:
- 8:11 AM Changeset in webkit [135613] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Drop Synchronous Mouse Events
https://bugs.webkit.org/show_bug.cgi?id=102980
Patch by Genevieve Mak <gmak@rim.com> on 2012-11-23
Reviewed by Rob Buis.
Reviewed Internally by George Staikos and Mike Lattanzio.
Don't send actual Touch Events to fullscreen plugins unless
its a Touch Cancel, DoubleTap or TouchHold.
Instead send mouse events as long as its a single finger.
PR #242781
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchEventToFullScreenPlugin):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::dispatchTouchPointAsMouseEventToFullScreenPlugin):
- 7:36 AM Changeset in webkit [135612] by
-
- 4 edits in trunk
[EFL] Define WTF_PLATFORM_EFL in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=101482
Patch by Laszlo Gombos <Laszlo Gombos> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
.:
Remove the definition of WTF_PLATFORM_EFL from the build system to
make the EFL port consistent with other ports.
- Source/cmake/OptionsEfl.cmake:
Source/WTF:
Define WTF_PLATFORM_EFL in Platform.h to be consistent with
other ports.
- wtf/Platform.h:
- 7:34 AM Changeset in webkit [135611] by
-
- 2 edits in trunk/Source/WebCore
[Qt] GraphicsContext3DQt makes wrong surface current.
https://bugs.webkit.org/show_bug.cgi?id=103136
blitMultisampleFramebufferAndRestoreContext restores
the wrong surface in case the currentContext is the same
as m_platformContext.
In this case we would reset the bound surface to NULL.
Instead we should just leave the context unchanged.
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::blitMultisampleFramebufferAndRestoreContext):
- 7:32 AM Changeset in webkit [135610] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix the ARM traditional build after r135330
https://bugs.webkit.org/show_bug.cgi?id=102871
Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-11-23
Reviewed by Zoltan Herczeg.
Added missing functionality to traditional ARM architecture.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::revertJump):
(ARMAssembler):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::startOfPatchableBranchPtrWithPatchOnAddress):
(JSC::MacroAssemblerARM::startOfBranchPtrWithPatchOnRegister):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::revertJumpReplacementToBranchPtrWithPatch):
- 7:15 AM Changeset in webkit [135609] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2][AC] EwkViewImpl::transformToScreen() does not retrieve the Ecore_X_Window properly
https://bugs.webkit.org/show_bug.cgi?id=103133
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
If accelerated compositing is enabled, EwkViewImpl::transformToScreen() should
attempt to retrieve the Ecore_X_Window using ecore_evas_gl_x11_window_get() first
and only fall back to ecore_evas_software_x11_window_get().
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::transformToScreen):
- 7:13 AM Changeset in webkit [135608] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: remove total item from NMI snapshot grid
https://bugs.webkit.org/show_bug.cgi?id=101926
Patch by Alexei Filippov <alph@chromium.org> on 2012-11-23
Reviewed by Yury Semikhatsky.
- inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotDataGrid):
- 7:11 AM Changeset in webkit [135607] by
-
- 2 edits in trunk/Source/WebCore
[Qt] GraphicsContext3DQt should not overwrite glClearColor of sharing context.
https://bugs.webkit.org/show_bug.cgi?id=103135
In case we use GraphicsContext3DQt to render into or
read from an existing context, we should not reset
the glClearColor on construction.
Otherwise we might overwrite an existing definition from
the sharing context.
Reviewed by Kenneth Rohde Christiansen.
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
- 7:01 AM Changeset in webkit [135606] by
-
- 6 edits2 adds in trunk
Web Inspector: damaging last chunk does not remove its garbage from DOM
https://bugs.webkit.org/show_bug.cgi?id=103132
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Removing everything between undamaged chunks, not registered chunk rows.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainChunk.prototype.updateCollapsedLineRow):
(WebInspector.TextEditorMainChunk.prototype.firstElement):
(WebInspector.TextEditorMainChunk.prototype.lastElement):
LayoutTests:
- inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests.InspectorTest.dumpEditorModel):
(initialize_EditorTests.InspectorTest.dumpEditorDOM):
(initialize_EditorTests):
- inspector/editor/text-editor-remove-chunks-from-dom-expected.txt: Added.
- inspector/editor/text-editor-remove-chunks-from-dom.html: Added.
- inspector/editor/text-editor-selection-expected.txt:
- inspector/editor/text-editor-selection.html:
- 6:55 AM Changeset in webkit [135605] by
-
- 3 edits in trunk/Source/WebCore
RenderLayer minor clean-up: replace raw pointers with OwnPtrs.
https://bugs.webkit.org/show_bug.cgi?id=103134
Reviewed by Eric Seidel.
I found that RenderLayer still uses raw pointers to the objects which it owns.
Looks like these pointers could be replaced with OwnPtrs.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateNormalFlowList):
(WebCore::RenderLayer::collectLayers):
(WebCore::RenderLayer::styleChanged):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::marquee):
(WebCore::RenderLayer::posZOrderList):
(WebCore::RenderLayer::negZOrderList):
(WebCore::RenderLayer::normalFlowList):
(RenderLayer):
(WebCore::RenderLayer::clearZOrderLists):
- 6:31 AM WebKitGTK/AddingNewWebKit2API edited by
- Add rules to not use the C API (diff)
- 6:24 AM WebKitGTK/AddingNewWebKit2API edited by
- Document WEBKIT_DEFINE_ macros (diff)
- 6:22 AM Changeset in webkit [135604] by
-
- 2 edits in trunk/Source/WebCore
[EFL][AC] Mouse cursor is not updated when accelerated compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=103131
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
Make sure we try to get the Ecore_X_Window using ecore_evas_gl_x11_window_get()
in applyFallbackCursor() if accelerated compositing is enabled instead of
using ecore_evas_software_x11_window_get(). This fixes mouse cursor update
when accelerated compositing is enabled.
No new tests, no behavior change for layout tests.
- platform/efl/EflScreenUtilities.cpp:
(WebCore::applyFallbackCursor):
- 6:08 AM Changeset in webkit [135603] by
-
- 18 edits2 adds in trunk
Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
https://bugs.webkit.org/show_bug.cgi?id=102510
Reviewed by Pavel Feldman.
Source/JavaScriptCore:
Added new symbols for the methods that have moved into .../wtf/MemoryInstrumentation.cpp
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
Source/WebCore:
Added necessary includes where MemoryObjectInfo declaration is required.
- platform/audio/FFTFrame.cpp:
- rendering/style/RenderStyle.cpp:
- rendering/style/StyleRareInheritedData.cpp:
- rendering/style/StyleRareNonInheritedData.cpp:
Source/WTF:
Moved MemoryObjectInfo into separate header. Moved definition of MemoryInstrumentation
methods that depend on MemoryObjectInfo declaration into MemoryInstrumentation.cpp to
make MemoryInstrumentation require only forward declaration of MemoryObjectInfo.
- GNUmakefile.list.am:
- WTF.gypi:
- WTF.pro:
- WTF.vcproj/WTF.vcproj:
- wtf/CMakeLists.txt:
- wtf/MemoryInstrumentation.cpp: Added.
(WTF):
(WTF::MemoryInstrumentation::MemoryInstrumentation):
(WTF::MemoryInstrumentation::~MemoryInstrumentation):
(WTF::MemoryInstrumentation::getObjectType): this method allows to get object type without
pulling in MemoryObjectInfo.h and all its dependencies.
(WTF::MemoryInstrumentation::callReportObjectInfo):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::InstrumentedPointerBase):
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::init):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
- wtf/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addRootObject):
(InstrumentedPointerBase):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(InstrumentedPointer):
(WTF::MemoryInstrumentation::addObject): we now pass owner's MemoryObjectInfo in all places
where we report objects pointed by the owner.
(WTF::MemoryInstrumentation::OwningTraits::addObject):
(WTF::MemoryClassInfo::MemoryClassInfo):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::::InstrumentedPointer):
(WTF::::callReportMemoryUsage):
- wtf/MemoryObjectInfo.h: Added.
(WTF):
(MemoryObjectInfo):
(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::objectType):
(WTF::MemoryObjectInfo::objectSize):
(WTF::MemoryObjectInfo::reportedPointer):
(WTF::MemoryObjectInfo::memoryInstrumentation):
(WTF::MemoryObjectInfo::reportObjectInfo):
Tools:
Added missing includes.
- TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
- 6:05 AM Changeset in webkit [135602] by
-
- 2 edits in trunk/Source/WebKit/qt
tst_qwebpage fails after QMimeDatabase patch
https://bugs.webkit.org/show_bug.cgi?id=103125
Reviewed by Simon Hausmann.
Replace the static extension->mimetype table with a QMimeDatabase lookup
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):
(tst_QWebPage::supportedContentType):
- 5:44 AM Changeset in webkit [135601] by
-
- 11 edits in trunk/Source/WebCore
Remove V8DOMWindowShell::getEntered
https://bugs.webkit.org/show_bug.cgi?id=96637
Patch by Dan Carney <dcarney@google.com> on 2012-11-23
Reviewed by Adam Barth.
V8DOMWindowShell::getEntered was refactored so that the window shell
no longer has to be kept alive by a v8 context. Instead, only
the DOMWrapperWorld will be kept alive.
No new tests. No change in functionality.
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::isolatedWorldWeakCallback):
(WebCore):
(WebCore::DOMWrapperWorld::makeContextWeak):
(WebCore::DOMWrapperWorld::setIsolatedWorldField):
- bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::isolated):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::existingWindowShell):
(WebCore::ScriptController::windowShell):
(WebCore::ScriptController::evaluateInIsolatedWorld):
(WebCore::ScriptController::currentWorldContext):
(WebCore::ScriptController::collectIsolatedContexts):
- bindings/v8/ScriptController.h:
(ScriptController):
- bindings/v8/V8Binding.h:
(WebCore::worldForEnteredContextIfIsolated):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::destroyIsolatedShell):
(WebCore::V8DOMWindowShell::disposeContext):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
- bindings/v8/V8DOMWindowShell.h:
(V8DOMWindowShell):
- bindings/v8/V8PerContextData.h:
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- 5:38 AM Changeset in webkit [135600] by
-
- 4 edits in trunk/Tools
[EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=103123
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
WebKit2 API test ResponsivenessTimerDoesntFireEarly.
- TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
test.
- TestWebKitAPI/efl/PlatformUtilities.cpp:
(TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
test case is passing 0.5 seconds to sleep.
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
(TestWebKitAPI):
- 5:25 AM Changeset in webkit [135599] by
-
- 9 edits in trunk/Source/WebCore
Web Inspector: Refine JsDoc in ProfilesPanel.js
https://bugs.webkit.org/show_bug.cgi?id=103042
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-23
Reviewed by Yury Semikhatsky.
I'm going to make profiler output typed.
This will require some amount of refactoring.
Before refactoring I would like to make things
unambiguous by adding JsDoc where they are missing.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._onToggleProfiling):
Added to eliminate parameter type ambiguity.
- 5:11 AM Changeset in webkit [135598] by
-
- 12 edits in trunk
Correct input[type=number] value sanitization for user-input
https://bugs.webkit.org/show_bug.cgi?id=103018
Reviewed by Kentaro Hara.
Source/WebCore:
If a number field has non-number string, HTMLInputElement::value is not
updated and returns the past valid value. It doesn't match to the value
sanitization algorithm defined by the HTML standard [1], and Opera's
behavior. We should sanitize non-number strings to "".
[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-attribute.html#number-state-(type=number)
The value sanitization algorithm is as follows: If the value of the
element is not a valid floating-point number, then set it to the empty
string instead.
No new tests. Update existing tests;
fast/forms/number/number-commit-valid-only.html and
fast/forms/number/number-unacceptable-style.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::subtreeHasChanged):
Remove isAcceptableValue check.
- html/HTMLInputElement.h:
(HTMLInputElement): isAcceptableValue is no longer needed.
- html/InputType.cpp: Remove isAcceptableValue.
- html/InputType.h: Ditto.
- html/NumberInputType.cpp: Ditto.
(WebCore::NumberInputType::hasUnacceptableValue):
Fold the isAcceptableValue content into this.
- html/NumberInputType.h:
(NumberInputType): Remove isAcceptableValue.
LayoutTests:
- fast/forms/number/number-commit-valid-only-expected.txt:
- fast/forms/number/number-commit-valid-only.html:
Update the expected HTMLInputElement::value results.
- fast/forms/number/number-unacceptable-style-expected.txt:
- fast/forms/number/number-unacceptable-style.html:
Add some checks for HTMLInputElement::value.
- 5:11 AM Changeset in webkit [135597] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] JavaScriptCore JIT build is broken since r130839
Add missing implementation for sh4 arch.
https://bugs.webkit.org/show_bug.cgi?id=101479
Patch by Julien BRIANCEAU <jbrianceau@nds.com> on 2012-11-23
Reviewed by Filip Pizlo.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8Signed):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Signed):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::store16):
(JSC::MacroAssemblerSH4::moveDoubleToInts):
(JSC::MacroAssemblerSH4::moveIntsToDouble):
(JSC::MacroAssemblerSH4::loadFloat):
(JSC::MacroAssemblerSH4::loadDouble):
(JSC::MacroAssemblerSH4::storeFloat):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::addDouble):
(JSC::MacroAssemblerSH4::convertFloatToDouble):
(JSC::MacroAssemblerSH4::convertDoubleToFloat):
(JSC::MacroAssemblerSH4::urshift32):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::sublRegReg):
(JSC::SH4Assembler::subvlRegReg):
(JSC::SH4Assembler::floatfpulfrn):
(JSC::SH4Assembler::fldsfpul):
(JSC::SH4Assembler::fstsfpul):
(JSC::SH4Assembler::dcnvsd):
(SH4Assembler):
(JSC::SH4Assembler::movbRegMem):
(JSC::SH4Assembler::sizeOfConstantPool):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::printInstr):
(JSC::SH4Assembler::printBlockInstr):
- 4:57 AM Changeset in webkit [135596] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r135592.
http://trac.webkit.org/changeset/135592
https://bugs.webkit.org/show_bug.cgi?id=103126
broke Chromium Mac compilation (Requested by yurys on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-23
- WebCore.gypi:
- 4:55 AM Changeset in webkit [135595] by
-
- 14 edits in trunk
[WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
https://bugs.webkit.org/show_bug.cgi?id=86881
Patch by Wojciech Bielawski <w.bielawski@samsung.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
InjectedBundle API extended to retrieve contextMenu entries names.
WebContextMenu exteded with function to retrieve menu items.
This API is required by layout tests.
Common code in WebContextMenu.cpp moved to separate method menuItemsWithUserData().
Behaviour of dependend methods is unchanged.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageGetContextMenuEntriesNames):
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::items):
(WebKit):
- WebProcess/WebPage/WebContextMenu.h:
(WebContextMenu):
Tools:
eventSender object extended with contextClick() method in WebKitTestRunner.
contextClick() method returns an array of menu items objects with field 'title' containing title of single
context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
delivered in this patch.
- WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick):
(WTR):
- WebKitTestRunner/InjectedBundle/EventSendingController.h:
(EventSendingController):
LayoutTests:
Added expected results for two tests for EFL platform. Test expectations changed
for EFL WK1/WK2 and GTK platforms
- platform/efl/TestExpectations:
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/gkt-wk2/TestExpectations:
- platform/gtk/editing/selection/5354455-2-expected.txt:
- platform/efl/editing/selection/5354455-2-expected.txt: Added.
- platform/efl/fast/events/context-no-deselect-expected.txt: Added.
- 4:54 AM Changeset in webkit [135594] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InputHandler::ensureFocusTextElementVisible incorrectly used y coordinate as x coordinate
https://bugs.webkit.org/show_bug.cgi?id=103091
Patch by Andrew Lo <anlo@rim.com> on 2012-11-23
Reviewed by Yong Li.
Internally reviewed by Mike Fenton.
Internal PR249523
Incorrectly used y coordinate as x coordinate in
InputHandler::ensureFocusTextElementVisible.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 4:48 AM Changeset in webkit [135593] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Fix Chromium Win compilation after r135580.
https://bugs.webkit.org/show_bug.cgi?id=101772
- tests/WebFrameTest.cpp:
- 4:38 AM Changeset in webkit [135592] by
-
- 2 edits in trunk/Source/WebCore
Remove references to non-chromium entries from WebCore.gypi (part 2)
https://bugs.webkit.org/show_bug.cgi?id=103124
Reviewed by Pavel Feldman.
- WebCore.gypi: removed references to gtk, cocoa, posix, ios, cf, win and mac
- 4:20 AM Changeset in webkit [135591] by
-
- 8 edits in trunk/Source/WebCore
Web Inspector: [Canvas] add startCapturing and stopCapturing methods to protocol
https://bugs.webkit.org/show_bug.cgi?id=103053
Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-11-23
Reviewed by Pavel Feldman.
Add startCapturing and stopCapturing methods to the protocol to instrument several canvas frames in a row.
Drive-by: support start offset index in retrieving trace logs in the backend as well as "alive" flag.
- inspector/InjectedScriptCanvasModule.cpp:
(WebCore::InjectedScriptCanvasModule::captureFrame):
(WebCore):
(WebCore::InjectedScriptCanvasModule::startCapturing):
(WebCore::InjectedScriptCanvasModule::callStartCapturingFunction):
(WebCore::InjectedScriptCanvasModule::stopCapturing):
(WebCore::InjectedScriptCanvasModule::dropTraceLog):
(WebCore::InjectedScriptCanvasModule::callVoidFunctionWithTraceLogIdArgument):
(WebCore::InjectedScriptCanvasModule::traceLog):
- inspector/InjectedScriptCanvasModule.h:
(InjectedScriptCanvasModule):
- inspector/InjectedScriptCanvasModuleSource.js:
(.):
- inspector/Inspector.json:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::startCapturing):
(WebCore):
(WebCore::InspectorCanvasAgent::stopCapturing):
(WebCore::InspectorCanvasAgent::getTraceLog):
- inspector/InspectorCanvasAgent.h:
(InspectorCanvasAgent):
- inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
- 4:15 AM Changeset in webkit [135590] by
-
- 3 edits in trunk/LayoutTests
[EFL] Newly added tests in r135436 and r135456 are failng
https://bugs.webkit.org/show_bug.cgi?id=103112
Unreviewed EFL gardening.
Skip new failing tests introduced in r135436 and r135456.
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-23
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 4:09 AM Changeset in webkit [135589] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening, skip failing tests.
- platform/qt-5.0-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 4:08 AM Changeset in webkit [135588] by
-
- 11 edits in trunk/Source/WebCore
Web Inspector: dispatch events upon certain user actions on inspector's notification services
https://bugs.webkit.org/show_bug.cgi?id=103114
Reviewed by Pavel Feldman.
Add a bunch of WebInspector.UserMetrics.UserAction, so platform-specific code can wire to user actions
without breaking too often.
- inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
- inspector/front-end/NetworkItemView.js:
(WebInspector.NetworkItemView.prototype._tabSelected.set WebInspector):
(WebInspector.NetworkItemView.prototype._tabSelected):
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._sortItems):
(WebInspector.NetworkDataGridNode.prototype.select):
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.revertToOriginal):
(WebInspector.UISourceCode.prototype.revertAndClearHistory):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
- inspector/front-end/UserMetrics.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.js:
(WebInspector._requestZoom.set var):
(WebInspector._requestZoom):
- 3:52 AM Changeset in webkit [135587] by
-
- 5 edits4 adds in trunk
WebSocket's MessageEvent.origin attribute is an empty string
https://bugs.webkit.org/show_bug.cgi?id=102889
Patch by Christophe Dumez <Christophe Dumez> on 2012-11-23
Reviewed by Kentaro Hara.
Source/WebCore:
Fix WebSocket implementation so that the message event's origin
attribute is properly set to the Unicode serialization of the
origin of the URL that was passed to the WebSocket object's
constructor, instead of an empty string.
The new behavior is according to the specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#feedback-from-the-protocol
It also matches the behavior of Firefox.
Tests: http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html
http/tests/websocket/tests/hybi/send-onmessage-origin.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::didReceiveMessage):
(WebCore::WebSocket::didReceiveBinaryData):
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::MessageEvent):
- dom/MessageEvent.h:
(WebCore::MessageEvent::create):
(MessageEvent):
LayoutTests:
Add layout tests to check that the message event's origin attribute
is set to the Unicode serialization of the origin of the URL that
was passed to the WebSocket object's constructor, as per the
WebSocket specification.
- http/tests/websocket/tests/hybi/send-blob-onmessage-origin-expected.txt: Added.
- http/tests/websocket/tests/hybi/send-blob-onmessage-origin.html: Added.
- http/tests/websocket/tests/hybi/send-onmessage-origin-expected.txt: Added.
- http/tests/websocket/tests/hybi/send-onmessage-origin.html: Added.
- 3:31 AM Changeset in webkit [135586] by
-
- 5 edits in trunk
Web Inspector: No "Save Heap Snapshot" option after canceling save to file dialog.
https://bugs.webkit.org/show_bug.cgi?id=100916
Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-22
Reviewed by Yury Semikhatsky.
Source/WebCore:
Fixed order of operations - now receiver is assigned only when save
dialog responds.
- inspector/front-end/HeapSnapshotView.js: Fixed order of operations.
LayoutTests:
Extracted "injectMockProfile" method and reused it in new test.
- inspector/profiler/heap-snapshot-loader-expected.txt: Added test case.
- inspector/profiler/heap-snapshot-loader.html:
Refactored and added new test case.
- 3:29 AM Changeset in webkit [135585] by
-
- 5 edits in trunk
[Qt] Compiling against QtWebkit API requires QT_DLL to be defined
https://bugs.webkit.org/show_bug.cgi?id=102942
Reviewed by Tor Arne Vestbø.
Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
to follow the same rules as other Qt 5 modules, with the exception that instead of
QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
in other cross-platform header files to determine the correct meaning of export
macros.
Source/WebKit/qt:
- Api/qwebkitglobal.h:
Tools:
- qmake/mkspecs/features/default_post.prf:
- qmake/mkspecs/features/win32/default_post.prf:
- 3:27 AM Changeset in webkit [135584] by
-
- 4 edits in trunk
[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069
Reviewed by Simon Hausmann.
Source/WebCore:
The subframe loading logic depends on that script extensions are not recognized,
so avoid recognizing them in getMIMETypeForExtension which is used for pre-load
mimetype detection.
- platform/qt/MIMETypeRegistryQt.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
LayoutTests:
Unskip the last of test regressions now passing.
- platform/qt/TestExpectations:
- 3:22 AM Changeset in webkit [135583] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r135455): Compilation without SVG enabled broken
https://bugs.webkit.org/show_bug.cgi?id=103108
Reviewed by Yury Semikhatsky.
Move SVG-only code behind #if ENABLE(SVG) that was accidentially moved
outside of the #if block during the refactoring.
- platform/graphics/filters/FilterOperation.h:
(ReferenceFilterOperation):
- 3:17 AM Changeset in webkit [135582] by
-
- 10 edits in trunk
[Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
https://bugs.webkit.org/show_bug.cgi?id=103111
Reviewed by Kenneth Rohde Christiansen.
This function was added as a slot during Qt 4.x times because adding
virtual functions breaks binary compatibility. This constraint is gone
with the initial release of WebKit with Qt 5, and therefore we can
make it virtual now.
The change is fully source compatible as existing "re-implementations"
as slots will now be called through it being a virtual function. They
become unused slots.
Source/WebKit/qt:
- Api/qwebpage.cpp:
(QWebPagePrivate::shouldInterruptJavaScript):
- Api/qwebpage.h:
- Api/qwebpage_p.h:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::shouldInterruptJavaScript):
- WebCoreSupport/QWebPageAdapter.h:
(QWebPageAdapter):
- tests/qwebpage/tst_qwebpage.cpp:
(JSTestPage::shouldInterruptJavaScript):
(JSTestPage):
Tools:
- DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::WebPage::shouldInterruptJavaScript):
(WebPage):
- QtTestBrowser/webpage.h:
(WebPage):
- 3:17 AM Changeset in webkit [135581] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Updated test expectations.
- platform/chromium/TestExpectations:
- 3:15 AM Changeset in webkit [135580] by
-
- 7 edits in trunk/Source
[chromium] Remove WebScreenInfo.{horizontal,vertical}DPI
https://bugs.webkit.org/show_bug.cgi?id=101772
Patch by Sami Kyostila <skyostil@chromium.org> on 2012-11-23
Reviewed by Adam Barth.
Now that nothing is using WebScreenInfo.{horizontal,vertical}DPI we can simply
remove them.
Source/Platform:
- chromium/public/WebScreenInfo.h:
(WebKit::WebScreenInfo::WebScreenInfo):
Source/WebKit/chromium:
- src/mac/WebScreenInfoFactory.mm:
(WebKit::WebScreenInfoFactory::screenInfo):
- src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- src/x11/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):
- 3:10 AM Changeset in webkit [135579] by
-
- 2 edits in trunk/LayoutTests
fast/events/mouseover-button.html never releases a mouse button
https://bugs.webkit.org/show_bug.cgi?id=103041
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
mouseover-button.html released the wrong mouse button so subsequent
tests would fail: This includes at least svg/text/select-*.svg .
- fast/events/mouseover-button.html:
- 2:59 AM Changeset in webkit [135578] by
-
- 3 edits2 adds in trunk
REGRESSION (r128633): td changes size during re-layout of table although it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=102802
Patch by Julian Pastarmov <pastarmovj@chromium.org> on 2012-11-23
Reviewed by Ojan Vafai.
Source/WebCore:
The bug was caused by incorrectly rewriting a nested condition which caused the else
clause to trigger in wrong cases.
Test: fast/table/nested-tables-with-div-offset.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computePercentageLogicalHeight):
Reverted wrong combination of nested if statements.
LayoutTests:
This test checks that table layout of some nested tables in quirks mode is computed correctly.
- fast/table/nested-tables-with-div-offset-expected.txt: Added.
- fast/table/nested-tables-with-div-offset.html: Added.
- 2:30 AM Changeset in webkit [135577] by
-
- 4 edits1 add in trunk
[Qt] REGRESSION(r135507): It made 13 tests fail
https://bugs.webkit.org/show_bug.cgi?id=103069
Reviewed by Simon Hausmann.
Source/WebCore:
Fix regression in recognizing MHTML on some platforms.
- platform/qt/MIMETypeRegistryQt.cpp:
(ExtensionMap):
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):
LayoutTests:
Unskip fixed test and update one benign change.
- platform/qt/TestExpectations:
- platform/qt/fast/preloader/script-expected.txt: Added.
- 2:18 AM Changeset in webkit [135576] by
-
- 4 edits in trunk
[Qt] REGRESSION(r135515): 3 appcache tests still failing
https://bugs.webkit.org/show_bug.cgi?id=103073
Rubber-stamped by Simon Hausmann.
Source/WebKit/qt:
Another sneaky typo.
- Api/qwebpage.cpp:
(QWebPagePrivate::applicationCacheQuotaExceeded):
LayoutTests:
- platform/qt/TestExpectations: Unskipped the affected tests.
- 2:17 AM Changeset in webkit [135575] by
-
- 5 edits in trunk/Source
[Qt] Avoid initializing PlatformStrategies twice.
Rubber-stamped by Simon Hausmann.
This fixes another regression introduced in r135515:
initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
since it can be called from WebKit2 to initialize QStyle for testing.
This would then lead to things such as PlatformStrategies being
initialized twice.
Source/WebKit/qt:
- Api/qwebpage.cpp: Explicitely call initializeWebCoreQt().
(QWebPagePrivate::QWebPagePrivate):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebKit::initializeWebKitQt):
Source/WebKit2:
- qt/MainQt.cpp: No need to initialize anything if we're not using QStyle.
(WebKit):
(main):
- 2:14 AM Changeset in webkit [135574] by
-
- 4 edits3 adds in trunk
Web Inspector: ctrl+end in editor does not select the last symbol.
https://bugs.webkit.org/show_bug.cgi?id=103078
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Test: inspector/editor/text-editor-selection.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._handleScrollChanged):
(WebInspector.DefaultTextEditor.prototype.overrideViewportForTest):
(WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype._scrollTop):
(WebInspector.TextEditorChunkedPanel.prototype._clientHeight):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
LayoutTests:
- inspector/editor/editor-test.js: Added.
(initialize_EditorTests.InspectorTest.createTestEditor):
(initialize_EditorTests.InspectorTest.dumpEditorChunks):
(initialize_EditorTests):
- inspector/editor/text-editor-selection-expected.txt: Added.
- inspector/editor/text-editor-selection.html: Added.
- 1:57 AM Changeset in webkit [135573] by
-
- 2 edits in trunk/Source/WebCore
Remove references to non-chromium entries from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=103103
Reviewed by Pavel Feldman.
- WebCore.gypi: Removed references to files specific for wince, cairo, qt, wx and efl.
- 1:55 AM Changeset in webkit [135572] by
-
- 4 edits2 moves6 adds in trunk/LayoutTests
Unreviewed. Updated test expectations.
- platform/chromium-linux/fast/repaint/line-flow-with-floats-in-regions-expected.png: Added.
- platform/chromium-linux/fast/writing-mode/text-orientation-basic-expected.png: Added.
- platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
- platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-landscape-expected.png: Added.
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
- platform/chromium/TestExpectations:
- platform/efl-wk1/fast/transforms/transformed-focused-text-input-expected.png: Renamed from LayoutTests/platform/efl/fast/transforms/transformed-focused-text-input-expected.png.
- platform/efl-wk1/fast/writing-mode/text-orientation-basic-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/text-orientation-basic-expected.png.
- 1:45 AM Changeset in webkit [135571] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: inspector overlay is always updated when inspector is open
https://bugs.webkit.org/show_bug.cgi?id=103106
Reviewed by Pavel Feldman.
Provide empty size into the InspectorOverlay if the metrics emulation is disabled,
so that it will not get painted in all cases.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::webViewResized): Call InspectorPageAgent::webViewResized() rather than InspectorOverlay::resize().
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::webViewResized): Provide empty size into InspectorOverlay::resize() if device metrics are not emulated.
- inspector/InspectorPageAgent.h:
- 1:29 AM Changeset in webkit [135570] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening after r135532. It made 3 tests fail.
https://bugs.webkit.org/show_bug.cgi?id=103073
Patch by János Badics <János Badics> on 2012-11-23
- platform/qt/TestExpectations:
- 1:22 AM Changeset in webkit [135569] by
-
- 8 edits1 add1 delete in trunk
[EFL] Platform support for Accessibility feature.
https://bugs.webkit.org/show_bug.cgi?id=100848
Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-11-23
Reviewed by Gyuyoung Kim.
.:
Add support for ATK library.
- Source/cmake/FindATK.cmake: Added.
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
Add EFL platform's definitions to enable proper accessibility routines.
No new tests. Covered by existing layout tests.
- PlatformEfl.cmake: Add accessibility/atk content to compilation.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
- accessibility/AccessibilityObject.h:
(AccessibilityObject):
- accessibility/efl/AccessibilityObjectEfl.cpp: Removed. No needed platform specific implementation. ATK shared implementation will be used.
Source/WTF:
Enable HAVE(ACCESSIBILITY) ifdefs so that EFL port can use it.
- wtf/Platform.h:
- 1:13 AM Changeset in webkit [135568] by
-
- 11 edits3 moves1 add in trunk/LayoutTests
Unreviewed. Update test expectations.
- platform/chromium-mac-lion/fast/css/input-search-padding-expected.png:
- platform/chromium-mac-lion/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
- platform/chromium-mac-lion/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
- platform/chromium-mac-snowleopard/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-mac/fast/css/input-search-padding-expected.png:
- platform/chromium-mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
- platform/chromium-mac/svg/batik/text/xmlSpace-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
- platform/chromium-win/svg/batik/text/xmlSpace-expected.png:
- platform/efl-wk1/fast/css/input-search-padding-expected.png: Renamed from LayoutTests/platform/efl/fast/css/input-search-padding-expected.png.
- platform/efl-wk1/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png.
- platform/efl-wk1/svg/batik/text/xmlSpace-expected.png: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.png.
- 1:12 AM Changeset in webkit [135567] by
-
- 5 edits in trunk/Source/WebKit/qt
Unreviewed trivial Qt/Win build fix:
Include FormState.h/HTMLFormElement.h in the FrameLoaderClient
declaration because MSVC needs it. Also fix Q_DECL_EXPORT declarations
for functions that are supposed to be exported.
- Api/qwebelement.cpp:
- WebCoreSupport/FrameLoaderClientQt.h:
- WebCoreSupport/InitWebCoreQt.h:
(WebKit):
- WebCoreSupport/InitWebKitQt.h:
(WebKit):
- 1:10 AM EFLWebKit edited by
- (diff)
- 1:00 AM Changeset in webkit [135566] by
-
- 1 edit2 moves8 adds in trunk/LayoutTests
Unreviewed. Update test expectations.
- platform/chromium-mac-lion/fast/css/font-weight-1-expected.png: Added.
- platform/chromium-mac-lion/fast/css/font-weight-1-expected.txt: Added.
- platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/css/font-weight-1-expected.txt: Added.
- platform/chromium-mac/fast/css/font-weight-1-expected.png: Added.
- platform/chromium-mac/fast/css/font-weight-1-expected.txt: Added.
- platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
- platform/chromium-win/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/chromium/fast/css/font-weight-1-expected.png.
- platform/chromium-win/platform/chromium/virtual/deferred/fast/images/pdf-as-image-expected.png: Added.
- platform/efl-wk1/fast/css/font-weight-1-expected.png: Renamed from LayoutTests/platform/efl/fast/css/font-weight-1-expected.png.
- 12:30 AM Changeset in webkit [135565] by
-
- 31 edits in trunk/Source/WebKit2
[GTK] Use custom private macros to define GObjects
https://bugs.webkit.org/show_bug.cgi?id=99705
Reviewed by Martin Robinson.
Add WEBKIT_DEFINE_TYPE macros, similar and compatible with
G_DEFINE_TYPE macros, to define GObject types. These macros also
define the init and finalize functions reducing the GObject
boilerplate and hiding the placement new syntax that causes some
confusion. The patch replaces the use of G_DEFINE_TYPE macros by
WEBKIT_DEFINE_TYPE ones and removes the init and finalize
implementations, moving custom code when needed to the private
struct constructor/destructor or constructed/dispose virtual
methods when appropriate.
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
- UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
(webkit_back_forward_list_item_class_init):
- UIProcess/API/gtk/WebKitContextMenu.cpp:
(webkitContextMenuDispose):
(webkit_context_menu_class_init):
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
(_WebKitContextMenuItemPrivate::~_WebKitContextMenuItemPrivate):
(_WebKitContextMenuItemPrivate):
(webkit_context_menu_item_class_init):
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(_WebKitCookieManagerPrivate):
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_class_init):
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(webkit_favicon_database_class_init):
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
(webkitFileChooserRequestDispose):
(webkit_file_chooser_request_class_init):
- UIProcess/API/gtk/WebKitFindController.cpp:
(webkit_find_controller_class_init):
- UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
(webkitFormSubmissionRequestDispose):
(webkit_form_submission_request_class_init):
- UIProcess/API/gtk/WebKitGeolocationPermissionRequest.cpp:
(webkitGeolocationPermissionRequestDispose):
(webkit_geolocation_permission_request_class_init):
- UIProcess/API/gtk/WebKitHitTestResult.cpp:
(webkit_hit_test_result_class_init):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
(webkit_navigation_policy_decision_class_init):
- UIProcess/API/gtk/WebKitPlugin.cpp:
(_WebKitPluginPrivate::~_WebKitPluginPrivate):
(_WebKitPluginPrivate):
(webkit_plugin_class_init):
- UIProcess/API/gtk/WebKitPolicyDecision.cpp:
(webkitPolicyDecisionDispose):
(webkit_policy_decision_class_init):
(webkit_policy_decision_use):
(webkit_policy_decision_ignore):
(webkit_policy_decision_download):
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):
(_WebKitPrintOperationPrivate):
(webkit_print_operation_class_init):
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
(webkit_response_policy_decision_class_init):
- UIProcess/API/gtk/WebKitSecurityManager.cpp:
(webkit_security_manager_class_init):
- UIProcess/API/gtk/WebKitSettings.cpp:
(_WebKitSettingsPrivate::_WebKitSettingsPrivate):
(_WebKitSettingsPrivate):
(webkit_settings_class_init):
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkit_uri_request_class_init):
- UIProcess/API/gtk/WebKitURIResponse.cpp:
(webkit_uri_response_class_init):
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkit_uri_scheme_request_class_init):
- UIProcess/API/gtk/WebKitWebContext.cpp:
- UIProcess/API/gtk/WebKitWebInspector.cpp:
(_WebKitWebInspectorPrivate::~_WebKitWebInspectorPrivate):
(_WebKitWebInspectorPrivate):
(webkit_web_inspector_class_init):
- UIProcess/API/gtk/WebKitWebResource.cpp:
(webkit_web_resource_class_init):
- UIProcess/API/gtk/WebKitWebView.cpp:
(_WebKitWebViewPrivate::~_WebKitWebViewPrivate):
(_WebKitWebViewPrivate):
(webkitWebViewConstructed):
(webkitWebViewDispose):
(webkit_web_view_class_init):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate):
(_WebKitWebViewBasePrivate::~_WebKitWebViewBasePrivate):
(webkitWebViewBaseDispose):
(webkitWebViewBaseConstructed):
(webkit_web_view_base_class_init):
- UIProcess/API/gtk/WebKitWebViewBaseAccessible.cpp:
(webkit_web_view_base_accessible_class_init):
- UIProcess/API/gtk/WebKitWindowProperties.cpp:
(webkit_window_properties_class_init):
- 12:06 AM Changeset in webkit [135564] by
-
- 14 edits3 adds in trunk
Expose DOM interface for CSS Device Adaptation
https://bugs.webkit.org/show_bug.cgi?id=95966
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-23
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Added V8 and JSC bindings for CSS Device Adapation.
Test: css3/device-adapt/opera/cssom-001.xhtml
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
- css/CSSRule.idl:
- css/WebKitCSSViewportRule.idl: Added.
- page/DOMWindow.idl:
LayoutTests:
Imported a test submitted by Opera that tests the exposed interface.
- css3/device-adapt/opera/cssom-001-expected.txt: Added.
- css3/device-adapt/opera/cssom-001.xhtml: Added.
- platform/efl/fast/js/global-constructors-expected.txt:
