⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 14, 2013:

11:55 PM Changeset in webkit [139721] by tkent@chromium.org
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139038

REGRESSION(r137406): Text inside an empty optgroup prevents subsequent options from appearing
​https://bugs.webkit.org/show_bug.cgi?id=106298

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/forms/select/select-empty-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):
Traverse to the first element within the 'current' only if it exists.

LayoutTests:

  • fast/forms/select/select-empty-optgroup-expected.html: Added.
  • fast/forms/select/select-empty-optgroup.html: Added.

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11881046

11:47 PM Changeset in webkit [139720] by tkent@chromium.org
  • 4 edits in branches/chromium/1364

Merge 139151

REGRESSION(r135836): Invalid user input for input[type=number] should be cleared by input.value=""
​https://bugs.webkit.org/show_bug.cgi?id=106284

Reviewed by Hajime Morita.

Source/WebCore:

No new tests. Updates fast/forms/number/number/validity-badinput.html.

  • html/NumberInputType.cpp:

(WebCore::NumberInputType::setValue):
If the new sanitized value is empty and innerTextValue is a bad input
(it means !valueChanged && !innerTextValue().isEmpty() because the new
sanitized value is empty), we need to update innerTextValue with the
empty string.

  • html/NumberInputType.h:

(NumberInputType): Declare setValue.

LayoutTests:

  • fast/forms/number/number-validity-badinput.html:

Add a test case.

  • fast/forms/number/number-validity-badinput-expected.txt:

TBR=​tkent@chromium.org
Review URL: ​https://codereview.chromium.org/11884049

11:20 PM Changeset in webkit [139719] by dominicc@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Unreviewed gardening.

Roll Chromium to r176801.

  • DEPS: Rollin' on the river.
10:53 PM Changeset in webkit [139718] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add XP image expectations for this test; see
<​https://bugs.webkit.org/show_bug.cgi?id=106875>:

svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

  • platform/chromium/TestExpectations:
10:15 PM Changeset in webkit [139717] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Remove nonexistent file in ANGLE Xcode project

  • ANGLE.xcodeproj/project.pbxproj: Remove references to

ossource_nspr.cpp which was removed in r139665.

9:29 PM Changeset in webkit [139716] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add Lion Debug crash expectations for this test; see
<​https://bugs.webkit.org/show_bug.cgi?id=106869>:

fast/mediastream/RTCPeerConnection-events.html

  • platform/chromium/TestExpectations:
9:25 PM Changeset in webkit [139715] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: stub out show_results_html for mock ports
​https://bugs.webkit.org/show_bug.cgi?id=106848

Reviewed by Ojan Vafai.

We were accidentally using the underlying ports'
show_results_html_file() implementation, which would, unsurprisingly,
fail in many cases (e.g., running mock-efl on the mac).

No test added since we don't generally add tests for the mock
implementation.

  • Scripts/webkitpy/layout_tests/port/mock_drt.py:

(MockDRTPort.show_results_html_file):

9:22 PM Changeset in webkit [139714] by commit-queue@webkit.org
  • 6 edits in trunk

Implement ID selector matching for the WebVTT ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=105481

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-14
Reviewed by Eric Carlson.

Source/WebCore:

Implemented matching cue WebVTT elements by an identifier. Identifiers of all WebVTT nodes in the rendering tree for
a given cue are set to match the cue identifier.

Existing tests were modified to cover this case.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

LayoutTests:

  • media/track/captions-webvtt/styling.vtt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching.html:
9:17 PM Changeset in webkit [139713] by pilgrim@chromium.org
  • 1 edit
    1 delete in trunk/Source/WebKit/chromium

[Chromium] Remove unused public/platform/WebColorName.h
​https://bugs.webkit.org/show_bug.cgi?id=106865

Reviewed by Adam Barth.

This file is no longer referenced anywhere in WebKit or Chromium.

  • public/platform/WebColorName.h: Removed.
9:16 PM Changeset in webkit [139712] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

Changing clean_working_directory/clean_local_commits and related
functions to have consistent naming.

​https://bugs.webkit.org/show_bug.cgi?id=104198

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/scm.py:
  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  • Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
9:15 PM Changeset in webkit [139711] by pilgrim@chromium.org
  • 2 edits in trunk/Source/WebCore

[Chromium] Use explicit WebKit prefixes in BlobRegistryProxy
​https://bugs.webkit.org/show_bug.cgi?id=106859

Reviewed by Adam Barth.

As requested in ​https://bugs.webkit.org/show_bug.cgi?id=106831#c2

  • platform/network/chromium/BlobRegistryProxy.cpp:

(WebCore::BlobRegistryProxy::registerBlobURL):

9:06 PM Changeset in webkit [139710] by mvujovic@adobe.com
  • 2 edits in trunk/Source/WebCore

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed build fix for GTK after ​http://trac.webkit.org/changeset/139702

  • GNUmakefile.am:
7:49 PM Changeset in webkit [139709] by dominicc@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Update test expectations for these tests:

fast/images/zoomed-offset-size.html
media/track/track-css-cue-lifetime.html
svg/custom/foreign-object-skew.svg
svg/custom/foreign-object-skew.svg

  • platform/chromium/TestExpectations:
7:46 PM Changeset in webkit [139708] by dominicc@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline these tests:

scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.html

after r139686. Note in TestExpectations image failure for
non-fast-scrollable-region-transformed-iframe.html on SnowLeopard
Debug; see <​https://bugs.webkit.org/show_bug.cgi?id=106858>

  • platform/chromium-mac-lion/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/chromium/TestExpectations:
7:40 PM Changeset in webkit [139707] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Yet another unreviewed attempted QT build fix, this time because
it's falling over on Filters.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore):
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel):

7:12 PM Changeset in webkit [139706] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix.

  • CMakeLists.txt:
7:02 PM Changeset in webkit [139705] by dino@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Unreviewed QT build fix.

  • ANGLE.pri:
7:00 PM Changeset in webkit [139704] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Tools

Fix EWS GCE build scripts to detect which zone is available
​https://bugs.webkit.org/show_bug.cgi?id=106524

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-14
Reviewed by Adam Barth.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/GoogleComputeEngine/findzone.sh: Added.
6:49 PM Changeset in webkit [139703] by rafaelw@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

fast/dom/HTMLTemplateElement/inertContents.html is flaky on Debug Chromium bots
​https://bugs.webkit.org/show_bug.cgi?id=106810

Reviewed by Levi Weintraub.

This patch reverts the test for inertContents back to a non-flaky version which did not
attempt to assert that images are prevented from loaded.

  • fast/dom/HTMLTemplateElement/inertContents-expected.txt:
  • fast/dom/HTMLTemplateElement/inertContents.html:
  • platform/chromium/TestExpectations:
  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Removed.
6:45 PM Changeset in webkit [139702] by dino@apple.com
  • 7 edits in trunk/Source

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Unreviewed attempted build fix.

Source/ThirdParty/ANGLE:

Remove the copy files stage. Make khrplatform.h a public header.

  • ANGLE.xcodeproj/project.pbxproj:
  • include/GLSLANG/ShaderLang.h:

Source/WebKit:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

  • PlatformEfl.cmake:

Source/WebKit2:

The khrplatform.h file is now a public header without a directory
prefix. Update the include path to look in the right place.

  • PlatformEfl.cmake:
6:44 PM Changeset in webkit [139701] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Blur the label background of a snapshotted plugin
​https://bugs.webkit.org/show_bug.cgi?id=106630

Reviewed by Simon Fraser.

When we are showing a label indicating the plugin has been snapshotted,
slightly blur the snapshot behind the label so that it is more clear. I expect
that if/when other ports pick up this code, we'll need to separate the
UI treatment somewhat, but this is ok for a first step.

  • rendering/RenderSnapshottedPlugIn.cpp:

(RenderSnapshottedPlugInBlurFilter): Private class to use FEGaussianBlur to blur an image.
(WebCore::RenderSnapshottedPlugInBlurFilter::create):
(WebCore::RenderSnapshottedPlugInBlurFilter::setSourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::sourceImageRect):
(WebCore::RenderSnapshottedPlugInBlurFilter::filterRegion):
(WebCore::RenderSnapshottedPlugInBlurFilter::output):
(WebCore::RenderSnapshottedPlugInBlurFilter::RenderSnapshottedPlugInBlurFilter):
(WebCore::RenderSnapshottedPlugInBlurFilter::apply):
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New member variable to hold a cached version of a preblurred snapshot.
(WebCore::RenderSnapshottedPlugIn::~RenderSnapshottedPlugIn): Remember to remove the preblurred image from the cache.
(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Zero the preblurred version if it exists.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Either paint snapshot or blurred snapshot with label.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): New method to paint a full sized snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshot):
(WebCore::snapshottedPluginImageForLabelDisplay): Static function to produce the blurred snapshot.
(WebCore::RenderSnapshottedPlugIn::paintReplacedSnapshotWithLabel): Calls paintSnapshot with the blurred snapshot on Mac.

  • rendering/RenderSnapshottedPlugIn.h:
6:08 PM Changeset in webkit [139700] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Adding an error string to AmbiguousCommitError.
​https://bugs.webkit.org/show_bug.cgi?id=106846

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-01-14
Reviewed by Adam Barth.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(AmbiguousCommitError.init):

6:06 PM Changeset in webkit [139699] by leviw@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed gardening. Adding mac expectatons after r139686.

  • platform/chromium-mac/scrollingcoordinator: Added.
  • platform/chromium-mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
5:58 PM Changeset in webkit [139698] by pilgrim@chromium.org
  • 4 edits
    2 moves in trunk/Source

[Chromium] Move BlobRegistryProxy into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106831

Reviewed by Adam Barth.

Part of a larger refactoring series to remove layering violations
in Chromium. See tracking bug 106829.

Source/WebCore:

  • WebCore.gypi:
  • platform/network/chromium/BlobRegistryProxy.cpp: Added.

(WebCore):
(WebCore::blobRegistry):
(WebCore::BlobRegistryProxy::BlobRegistryProxy):
(WebCore::BlobRegistryProxy::registerBlobURL):
(WebCore::BlobRegistryProxy::unregisterBlobURL):

  • platform/network/chromium/BlobRegistryProxy.h: Added.

(WebCore):
(BlobRegistryProxy):
(WebCore::BlobRegistryProxy::loadResourceSynchronously):
(WebCore::BlobRegistryProxy::~BlobRegistryProxy):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/BlobRegistryProxy.cpp: Removed.
  • src/BlobRegistryProxy.h: Removed.
5:40 PM Changeset in webkit [139697] by dpranke@chromium.org
  • 3 edits in trunk/Tools

kill whole lighttpd process tree for chromium win
​https://bugs.webkit.org/show_bug.cgi?id=106838

Reviewed by Tony Chang.

Land a speculative fix for lighttpd.exe hanging on some chromium bots;
I think a test is causing a httpd server child process to wedge and
killing the parent httpd server process isn't sufficient to ensure
that the children are also killed.

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd._check_and_kill):

  • Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:

(TestHttpServer.test_start_cmd):
(TestHttpServer):
(TestHttpServer.test_win32_start_and_stop):
(TestHttpServer.test_win32_start_and_stop.wait_for_action):
(TestHttpServer.test_win32_start_and_stop.mock_returns):
(TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):

5:36 PM Changeset in webkit [139696] by leviw@chromium.org
  • 8 edits in trunk

Source/WebCore: Rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrack.idl:

LayoutTests: Speculatively rolling out r139618. Appears to be causing sporadic crashes on Debug bots.

  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
5:31 PM Changeset in webkit [139695] by leviw@chromium.org
  • 2 edits in trunk/Source/WebCore

Rolling out r139678. This triggered a number of WebAudio crashes on Debug bots.

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

5:22 PM Changeset in webkit [139694] by leviw@chromium.org
  • 22 edits
    3 deletes in trunk

Source/WebCore: Rolling out r139683. It broke a bunch of webkit_unit_tests.

Source/WebKit/win: Rolling out r139683. It broke a bunch of webkit_unit_tests.

5:19 PM Changeset in webkit [139693] by ojan@chromium.org
  • 3 edits in trunk/Source/WebCore

RenderListItem does not need to override computePreferredLogicalWidth
​https://bugs.webkit.org/show_bug.cgi?id=106839

Reviewed by Levi Weintraub.

Apparently there was a time when the list marker was considered part of
the list item's preferred width, but that is no longer the case.
This code was added in r3421. The code around preferred widths has change
a lot since then.

  • rendering/RenderListItem.cpp:
  • rendering/RenderListItem.h:
5:17 PM Changeset in webkit [139692] by commit-queue@webkit.org
  • 9 edits in trunk

Implement element type selectors for the WebVTT ::cue pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=105480

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-14
Reviewed by Antti Koivisto.

Source/WebCore:

Implemented tag matching for the WebVTT specific tags "c" and "v". All common html tags like "b" and "i" are
handled without any changes to the code. Creating a rendering tree and DOM tree now use different code paths.
They both are made by cloning and modifying the tree produced by the parser. Voice tags now use spans for both
rendering and DOM trees to conform to specs. Since this changes a lot of code little refactoring has been
done. Removed m_hasInnerTimestamps since it is no longer needed, it doesn't affect anything. m_documentFragment
was renamed to m_webVTTNodeTree.

Existing tests were modified to cover this case.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue):
(WebCore::TextTrackCue::setText): rename m_documentFragment to m_webVTTNodeTree
(WebCore::TextTrackCue::createWebVTTNodeTree): parse the cue if it hasn't been parsed before.
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): clone and prepare a node for using in the DOM tree according to specs.
(WebCore::TextTrackCue::getCueAsHTML): get a DOM tree for the cue.
(WebCore::TextTrackCue::createCueRenderingTree): create a rendering tree (main tree is just being cloned for now).
(WebCore::TextTrackCue::markFutureAndPastNodes): tightening the argument type.
(WebCore::TextTrackCue::updateDisplayTree):
(WebCore::TextTrackCue::getDisplayTree): code cleanup, removed m_hasInnerTimeStamps.

  • html/track/TextTrackCue.h:

(WebCore::TextTrackCue::voiceElementTagName):
(TextTrackCue):
(WebCore::TextTrackCue::classElementTagName):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken): type of the newly created elements was changed to Element to avoid hitting
an assertion when cloning because a cloned element will not have HTMLElement type for elements with "v" and "c" tag.

LayoutTests:

  • media/track/captions-webvtt/styling.vtt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching.html:
  • media/track/track-webvtt-tc026-voice.html: voice elements should be spans according to specs.
5:13 PM Changeset in webkit [139691] by wangxianzhu@chromium.org
  • 6 edits
    2 adds in trunk

Sometimes RenderLayer::updateNeedsCompositedScrolling is not called
​https://bugs.webkit.org/show_bug.cgi?id=106271

Reviewed by Simon Fraser.

Source/WebCore:

  1. If a layer has no out-of-flow descendant, m_hasOutOfFlowPositionedDescendant won't change and won't trigger updateNeedsCompositedScrolling in updateDescendantDependentFlags. Set m_hasOutOfFlowPositionedDescendantDirty to true and call updateNeedsCompositedScrolling when the dirty flag becomes false from true.
  2. When the content size changes causing change of scrollable status, updateNeedsCompositedScrolling should also be called.

Test: compositing/overflow/dynamic-composited-scrolling-status.html

  • page/FrameView.cpp:

(WebCore::FrameView::addScrollableArea): Returns whether the scrollable area has just been newly added.
(WebCore::FrameView::removeScrollableArea): Returns whether the scrollable area has just been removed.

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer): Changed the initial value of m_hasOutOfFlowPositionedDescendantDirty to true to make sure m_hasOutOfFlowPositionedDescendant will be updated initially.
(WebCore::RenderLayer::updateDescendantDependentFlags): Call updateNeedsCompositedScrolling when m_hasOutOfFlowPositionedDescendantDirty is true.
(RenderLayer::updateScrollableAreaSet): Calls updateNeedsCompositedScrolling() when scrollable status changes.

  • rendering/RenderLayer.h:

(RenderLayer):

LayoutTests:

  • compositing/overflow/dynamic-composited-scrolling-status-expected.txt: Added.
  • compositing/overflow/dynamic-composited-scrolling-status.html: Added.
5:02 PM Changeset in webkit [139690] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

EFL build fix after r139681.

  • dom/NodeRareData.h:

(WebCore::NodeMicroDataTokenLists::NodeMicroDataTokenLists):

5:00 PM Changeset in webkit [139689] by thakis@chromium.org
  • 2 edits in trunk/Tools

[chromium] Enable update-webkit --chromium --ninja on windows
​https://bugs.webkit.org/show_bug.cgi?id=106836

Reviewed by Eric Seidel.

After running this, build-webkit --chromium will use ninja to build.
Apparently there are some minor issues with that still, so it's
not quite ready for use yet.

  • Scripts/webkitdirs.pm:

(determineIsChromiumNinja):
(buildChromium):

4:56 PM Changeset in webkit [139688] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG should not forget that it had proved something to be a constant during a merge just because it's merging against the empty value
​https://bugs.webkit.org/show_bug.cgi?id=106727

Reviewed by Oliver Hunt.

The problem was this statement:

if (m_value != other.m_value)

m_value = JSValue();


This is well-intentioned, in the sense that if we want our abstract value (i.e. this) to become the superset of the other
abstract value, and the two abstract values have proven different constants, then our abstract value should rescind its
claim that it has been proven to be constant. But this misses the special case that if the other abstract value is
completely clear (meaning that it wishes to contribute zero information and so the superset operation shouldn't change
this), it will have a clear m_value. So, the code prior to this patch would rescind the constant proof even though it
didn't have to.

This comes up rarely and I don't believe it will be a performance win, but it is good to have the CFA been consistently
precise as often as possible.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::merge):

4:53 PM Changeset in webkit [139687] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

Python implementation reports "MemoryError" instead of doing things
​https://bugs.webkit.org/show_bug.cgi?id=106690

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The bug was that the CFA was assuming that a variable is dead at the end of a basic block and hence doesn't need to
be merged to the next block if the last mention of the variable was dead. This is almost correct, except that it
doesn't work if the last mention is a GetLocal - the GetLocal itself may be dead, but that doesn't mean that the
variable is dead - it may still be live. The appropriate thing to do is to look at the GetLocal's Phi. If the
variable is used in the next block then the next block will have a reference to the last mention in our block unless
that last mention is a GetLocal, in which case it will link to the Phi. Doing it this way captures everything that
the CFA wants: if the last use is a live GetLocal then the CFA needs to consider the GetLocal itself for possible
refinements to the proof of the value in the variable, but if the GetLocal is dead, then this must mean that the
variable is not mentioned in the block but may still be "passed through" it, which is what the Phi will tell us.
Note that it is not possible for the GetLocal to refer to anything other than a Phi, and it is also not possible
for the last mention of a variable to be a dead GetLocal while there are other mentions that aren't dead - if
there had been SetLocals or GetLocals prior to the dead one then the dead one wouldn't have been emitted by the
parser.

This also fixes a similar bug in the handling of captured variables. If a variable is captured, then it doesn't
matter if the last mention is dead, or not. Either way, we already know that a captured variable will be live in
the next block, so we must merge it no matter what.

Finally, this change makes the output of Operands dumping a bit more verbose: it now prints the variable name next
to each variable's dump. I've often found the lack of this information confusing particularly for operand dumps
that involve a lot of variables.

  • bytecode/Operands.h:

(JSC::dumpOperands):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::mergeStateAtTail):

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: Added.
  • fast/js/dfg-cfa-merge-with-dead-use-at-tail.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: Added.

(foo):

4:51 PM Changeset in webkit [139686] by commit-queue@webkit.org
  • 3 edits
    14 adds in trunk

Correct FrameView::scrollableAreaBoundingBox() calculation in the presence of transforms
​https://bugs.webkit.org/show_bug.cgi?id=105075

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

As mentioned by the FIXME comment, we need to ask the renderer for the
absolute bounding box of a frame for correct transformation.
This fixes the bug that iframe cannot be scrolled properly when it is
transformed.

Source/WebCore:

Tests: scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html

  • page/FrameView.cpp:

(WebCore::FrameView::scrollableAreaBoundingBox):

LayoutTests:

  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html: Added.
  • scrollingcoordinator/resources/non-fast-scrollable-region-testing.js: Added.

(runNonFastScrollableRegionTest):

4:45 PM Changeset in webkit [139685] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12524710> Update sandbox rules after r128003
​https://bugs.webkit.org/show_bug.cgi?id=106840

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb.in:
4:12 PM Changeset in webkit [139684] by leviw@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed gardening. Fixing Mac results for fast/repaint/overhanging-float-detach-repaint.html.

  • platform/chromium-mac-lion/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • platform/chromium-mac/fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
4:10 PM Changeset in webkit [139683] by Nate Chapin
  • 24 edits
    3 adds in trunk

.: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

  • Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().

Source/WebCore: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

Test: http/tests/cache/cached-main-resource.html

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.

  • dom/Document.h:

(Document):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since

MainResourceLoader will take care of it.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,

ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.

(WebCore::MainResourceLoader::identifier):

  • loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader

to better describe when it is used.

  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".

  • loader/cache/CachedRawResource.h:

(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::addClientToSet):: Don't return cached data for a main resource synchronously

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::canReuse):
(CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):
(WebCore):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/win: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667

Reviewed by Antti Koivisto.

  • WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.

LayoutTests: Enable reuse of cached main resources
​https://bugs.webkit.org/show_bug.cgi?id=105667.

Reviewed by Antti Koivisto.

  • http/tests/cache/cached-main-resource-expected.txt: Added.
  • http/tests/cache/cached-main-resource.html: Added.
  • http/tests/cache/resources/cacheable-iframe.php: Added.
  • http/tests/inspector/resource-har-pages-expected.txt:
  • http/tests/loading/redirect-methods-expected.txt:
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
  • http/tests/misc/link-rel-icon-beforeload-expected.txt:
4:09 PM Changeset in webkit [139682] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix vcproj file. Missing file tag after ​http://trac.webkit.org/changeset/139541.

3:57 PM Changeset in webkit [139681] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Move functions from NodeRareData to ElementRareData and other classes
​https://bugs.webkit.org/show_bug.cgi?id=106679

Reviewed by Benjamin Poulain.

Moved tab index related functions from NodeRareData to ElementRareData since only
HTMLElement uses them, and moved related functions on Node to Element accordingly.

Also replaced transientMutationObserverRegistry and ensureTransientMutationObserverRegistry
by ensureMutationObserverData, and moved micro-data related member functions into
NodeMicroDataTokenLists, and moved NodeMutationObserverData and NodeMicroDataTokenLists
out of NodeRareData as they're used outside of NodeRareData now.

The intention is to move more code into NodeMutationObserverData and NodeMicroDataTokenLists
in the follow up patches so that they can detect the removability of NodeRareData.

No new tests are added since there should be no behavior changes.

  • dom/Element.cpp:

(WebCore::Element::clearTabIndexExplicitlyIfNeeded):
(WebCore::Element::setTabIndexExplicitly):
(WebCore::Element::tabIndex):
(WebCore::Element::supportsFocus):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::tabIndex):
(WebCore::ElementRareData::setTabIndexExplicitly):
(WebCore::ElementRareData::tabIndexSetExplicitly):
(WebCore::ElementRareData::clearTabIndexExplicitly):

  • dom/Node.cpp:

(WebCore::Node::tabIndex):
(WebCore::Node::supportsFocus):
(WebCore::Node::mutationObserverRegistry):
(WebCore::Node::transientMutationObserverRegistry):
(WebCore::Node::registerMutationObserver):
(WebCore::Node::registerTransientMutationObserver):
(WebCore::Node::itemProp):
(WebCore::Node::setItemProp):
(WebCore::Node::itemRef):
(WebCore::Node::setItemRef):
(WebCore::Node::itemType):
(WebCore::Node::setItemType):

  • dom/Node.h:

(Node):

  • dom/NodeRareData.h:

(NodeMutationObserverData):
(WebCore::NodeMutationObserverData::create):
(NodeMicroDataTokenLists):
(WebCore::NodeMicroDataTokenLists::create):
(WebCore::NodeMicroDataTokenLists::itemProp):
(WebCore::NodeMicroDataTokenLists::itemRef):
(WebCore::NodeMicroDataTokenLists::itemType):
(NodeRareData):
(WebCore::NodeRareData::mutationObserverData):
(WebCore::NodeRareData::ensureMutationObserverData):
(WebCore::NodeRareData::ensureMicroDataTokenLists):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

3:53 PM Changeset in webkit [139680] by ojan@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary setNeedsLayoutAndPrefWidthsRecalc from RenderTable
​https://bugs.webkit.org/show_bug.cgi?id=106832

Reviewed by Levi Weintraub.

These are both called from locations that either set these bits themselves
or clearly don't need these bits set (e.g. computePreferredLogicalWidths).

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::splitColumn):
(WebCore::RenderTable::appendColumn):

3:50 PM Changeset in webkit [139679] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: use the same search path for baselines and TestExpectations on apple mac
​https://bugs.webkit.org/show_bug.cgi?id=105599

Reviewed by Ryosuke Niwa.

Bug 105583 revealed some confusion due to the fact that the Apple
Mac port used a different list of directories to search for baselines
and TestExpectations files (actually, pretty much every port does).

It seems like a good idea to use the same list for both by default, but
making this happen will affect every port in slightly different ways, so
we'll try this on the Apple Mac port first.

Note that the effective changes for this are that:
1) The apple mac port will look in platform/wk2 for baselines where
it didn't before (it will look after looking in mac-wk2 but before
the non-wk2 dirs)
2) The apple mac-snowleopard port will use the expectations in
mac-lion as well as the expectations in mac-snowleopard, although
I'm not even sure if mac-snowleopard is still supported ...

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_baseline_search_path):
(MacPort.expectations_files):

  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_baseline_search_path):

3:49 PM Changeset in webkit [139678] by crogers@google.com
  • 2 edits in trunk/Source/WebCore

Switch AudioDestinationChromium over to new createAudioDevice() method
​https://bugs.webkit.org/show_bug.cgi?id=106816

Reviewed by James Robinson.

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

3:49 PM Changeset in webkit [139677] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/image/zoomed-offset-size.html as slow on debug.

  • platform/chromium/TestExpectations:
3:44 PM Changeset in webkit [139676] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/borders/outline-alpha-inline.html as failing image results.
Likely Stephen Schenney's skia changes are to blame.

  • platform/chromium/TestExpectations:
3:13 PM Changeset in webkit [139675] by commit-queue@webkit.org
  • 10 edits in trunk/Source/WebKit2

[EFL] REGRESSION(r139189): MiniBrowser renders abnormally with -r option.
​https://bugs.webkit.org/show_bug.cgi?id=106512

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-14
Reviewed by Kenneth Rohde Christiansen.

PageViewportController handles only pageScaleFactor after r139189. So
PageViewportControllerClientEFL calls EwkView::setScaleFactor() with
pageScaleFactor instead of pageScaleFactor * deviceScaleFactor.

This patch makes EwkView handle pageScaleFactor.

  1. EwkView uses pageScaleFactor * deviceScaleFactor when drawing in

the device unit.

  1. EwkView uses pageScaleFactor when notifying the scale to

PageViewportController.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::EwkViewImpl):
(EwkViewImpl::deviceScaleFactor):
(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl):
(EwkViewImpl::setPageScaleFactor):
(EwkViewImpl::pageScaleFactor):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didRenderFrame):

  • UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::updateViewportSize):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):
(WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
(WebKit::PageViewportControllerClientEfl::didResumeContent):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::setPageScaleFactor):

  • UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

3:11 PM Changeset in webkit [139674] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[TexMap] Use a premuliplied color in TextureMapperGL.
​https://bugs.webkit.org/show_bug.cgi?id=105786

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-01-14
Reviewed by Noam Rosenthal.

Source/WebCore:

TextureMapperGL always uses a premultiplied color, so we must convert
an unmultiplied color to a premultiplied color before setting the uniform value of
colorLocation.

Test: compositing/background-color/background-color-alpha-with-opacity.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawSolidColor):
(WebCore::prepareFilterProgram):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::blendWithOpacity):
(WebCore):
(WebCore::TextureMapperLayer::paintSelf):

TextureMapperLayer must not convert solidColor to premultiplied
color, because TextureMapperImageBuffer expects unmultiplied color.

LayoutTests:

Created new tests for composited background colors with fractional
number opacity. This test is similar to background-color-alpha.html

  • compositing/background-color/background-color-alpha-with-opacity-expected.html: Added.
  • compositing/background-color/background-color-alpha-with-opacity.html: Added.
3:02 PM Changeset in webkit [139673] by arko@motorola.com
  • 3 edits
    2 adds in trunk

Microdata: REGRESSION(r138725): Causes crash in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=106828

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should hold PropertyNodeList in RefPtr<PropertyNodeList>.

Test: fast/dom/MicroData/propertiescollection-crash.html

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

LayoutTests:

  • fast/dom/MicroData/propertiescollection-crash-expected.txt: Added.
  • fast/dom/MicroData/propertiescollection-crash.html: Added.
2:57 PM Changeset in webkit [139672] by Lucas Forschler
  • 3 edits in tags/Safari-537.26/Source/WebKit2

Merged r139655.

2:48 PM Changeset in webkit [139671] by schenney@chromium.org
  • 2 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Rebaseline after Skia changes

Unreviewed expectatiosn update for two remaining tests.

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-win/fast/borders/outline-alpha-inline-expected.png: Added.
  • platform/chromium/fast/borders/outline-alpha-inline-expected.png: Removed.
2:46 PM Changeset in webkit [139670] by cevans@google.com
  • 3 edits in branches/chromium/1364/Source/WebCore/platform/image-encoders/skia

Merge 138170
BUG=162551
Review URL: ​https://codereview.chromium.org/11876030

2:44 PM Changeset in webkit [139669] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Positioned children of an overflow:visible container should ignore scroll offset when updating layer position
​https://bugs.webkit.org/show_bug.cgi?id=106814

Source/WebCore:

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes ​http://crbug.com/167985

Test: fast/overflow/overflow-visible-should-ignore-scroll.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

LayoutTests:

This patch fixes a bug in RenderLayer::updateLayerPosition that
scrollLeft / scrollTop of a block should only be effective when the
block has overflow clipping. The bug results in rendering artifacts
and triggers a RenderGeometryMap assertion falure.

Fixes ​http://crbug.com/167985

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-14
Reviewed by Simon Fraser.

  • fast/overflow/overflow-visible-should-ignore-scroll-expected.html: Added.
  • fast/overflow/overflow-visible-should-ignore-scroll.html: Added.
2:41 PM Changeset in webkit [139668] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium mac rebaseline for r139659.

  • platform/chromium-mac/platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt:
2:41 PM Changeset in webkit [139667] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FCC appears when switching search engine providers
​https://bugs.webkit.org/show_bug.cgi?id=106824

Magnifying glass appears when switching search engine providers

PR 279178

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-01-14
Reviewed by Rob Buis.
Internal Reviewed by Mike Fenton.

We need to make sure fatfinger is touching a textfield when we tell notifyCaretChanged
to show the FCC.

This behaviour is accidentally regressed in the fix in PR 267177, causing the FCC to show
when the user touches an element that is not a textfield and changes the caret in the inputbar..

Tested that the behaviour in 267177 isn't reproducible and the FCC isn't invoked when we switch
search engine providers.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

2:40 PM Changeset in webkit [139666] by alecflett@chromium.org
  • 44 edits
    12 deletes in trunk/Source

IndexedDB: Remove IDBObjectStore/IndexBackendImpl and support functions
​https://bugs.webkit.org/show_bug.cgi?id=106605

Source/WebCore:

Remove all uses of IDBObjectStoreBackendInterface and IDBIndexBackend*,
as they are no longer used after recent refactoring.

Reviewed by Darin Fisher.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBCallbacks.h:

(WebCore):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createObjectStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(WebCore):
(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBIndex.cpp:
  • Modules/indexeddb/IDBIndexBackendInterface.h: Removed.
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::add):
(WebCore::IDBObjectStore::put):

  • Modules/indexeddb/IDBObjectStore.h:

(IDBObjectStore):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::makeIndexWriters):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.h:

(WebCore::IDBObjectStoreBackendImpl::IndexWriter::IndexWriter):
(IndexWriter):
(IDBObjectStoreBackendImpl):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransaction.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all references to IDBObjectStoreBackend* and IDBIndexBackend*
as they no longer exist in WebCore.

Reviewed by Darin Fisher.

  • WebKit.gyp:
  • public/WebIDBCallbacks.h:

(WebKit):

  • public/WebIDBDatabase.h:

(WebKit):
(WebKit::WebIDBDatabase::metadata):

  • public/WebIDBFactory.h:

(WebIDBFactory):

  • public/WebIDBIndex.h: Removed.
  • public/WebIDBObjectStore.h: Removed.
  • public/WebIDBTransaction.h:
  • src/IDBCallbacksProxy.cpp:
  • src/IDBDatabaseBackendProxy.cpp:
  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBFactoryBackendProxy.cpp:
  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/IDBIndexBackendProxy.cpp: Removed.
  • src/IDBIndexBackendProxy.h: Removed.
  • src/IDBObjectStoreBackendProxy.cpp: Removed.
  • src/IDBObjectStoreBackendProxy.h: Removed.
  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:

(IDBTransactionBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::put):
(WebKit::WebIDBDatabaseImpl::setIndexKeys):

  • src/WebIDBDatabaseImpl.h:

(WebKit):
(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • src/WebIDBIndexImpl.cpp: Removed.
  • src/WebIDBIndexImpl.h: Removed.
  • src/WebIDBObjectStoreImpl.cpp: Removed.
  • src/WebIDBObjectStoreImpl.h: Removed.
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::TEST):

  • tests/IDBDatabaseBackendTest.cpp:
2:34 PM Changeset in webkit [139665] by mvujovic@adobe.com
  • 52 edits
    33 adds
    74 deletes in trunk/Source

[ANGLE] Update ANGLE in WebKit
​https://bugs.webkit.org/show_bug.cgi?id=106274

Reviewed by Dean Jackson.

Update ANGLE to r1641.

Source/ThirdParty/ANGLE:

ANGLE parsers were generated with Bison 2.3.

Additionally, perform the following changes to WebKit's ANGLE build system. Note that these
changes only apply to WebKit's copy of ANGLE, and do not need to be upstreamed to ANGLE.
(a) Remove all files in the libEGL and libGLESv2 directories because nobody is using them.

Add a README in each directory to explain why their contents are not copied over from
ANGLE. This simplifies updating ANGLE in the future.

(b) Remove the build_angle.xcodeproj file that no-one is using. It appears it was copied

over from a gyp build of ANGLE. The Mac build uses ANGLE.xcodeproj.

(c) Remove duplicate file entries in ANGLE.xcodeproj. Change its Xcode group structure to

match ANGLE's directory structure.

(d) Add a Copy Files task to ANGLE.xcodeproj to put the khrplatform.h header in the right

place so ShaderLang.h can find it. ShaderLang.h is copied to
<BuildDir>/usr/local/include/ANGLE/ShaderLang.h during the Copy Headers task, and it
includes "KHR/khrplatform.h". Thus, we need to copy khrplatform.h to
<BuildDir>/usr/local/include/ANGLE/KHR/khrplatform.h.

Additionally, make one build fix in ANGLE source that should be upstreamed to ANGLE:
(1) Before this patch in ExpressionParser.y, we toggled the "-Wpragmas" flag so compilers

could ignore the pragmas that they didn't understand instead of generating an error.
However, clang does not understand "-Wpragmas" itself. Instead, tt understands
"-Wunknown-pragmas". Now, instead of trying to temporarily ignore pragmas, we apply the
right flags to the right compiler versions. The new code in ExpressionParser.y looks
like:

"""
Turn off uninitialized variable warnings triggered by the auto-generated pplval variable.
 On gcc 4.7+, The flag is called "-Wmaybe-uninitialized".
On clang and gcc < 4.7, the flag is called "-Wuninitialized".

#if !defined(clang) && ((GNUC == 4 && GNU_C_MINOR >= 7)
GNUC >= 5)

#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
#else
#pragma GCC diagnostic ignored "-Wuninitialized"
#endif
"""

  • ANGLE.plist:
  • ANGLE.pri:
  • ANGLE.xcodeproj/project.pbxproj:
  • DerivedSources.pri:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h:
  • src/build_angle.xcodeproj/project.pbxproj: Removed.
  • src/common/angleutils.h:
  • src/common/debug.cpp:

(gl::ScopedPerfEventHelper::ScopedPerfEventHelper):

  • src/common/debug.h:
  • src/common/version.h:
  • src/compiler/Compiler.cpp:

(TCompiler::Init):
(TCompiler::compile):
(TCompiler::clearResults):
(TCompiler::collectAttribsUniforms):
(TCompiler::enforcePackingRestrictions):

  • src/compiler/Diagnostics.cpp:

(TDiagnostics::TDiagnostics):
(TDiagnostics::writeInfo):
(TDiagnostics::print):

  • src/compiler/Diagnostics.h:

(TDiagnostics::numErrors):
(TDiagnostics::numWarnings):
(TDiagnostics):

  • src/compiler/DirectiveHandler.h:
  • src/compiler/HashNames.h: Added.
  • src/compiler/Intermediate.cpp:

(TIntermTraverser::hash):

  • src/compiler/OutputESSL.cpp:

(TOutputESSL::TOutputESSL):

  • src/compiler/OutputESSL.h:

(TOutputESSL):

  • src/compiler/OutputGLSL.cpp:

(TOutputGLSL::TOutputGLSL):

  • src/compiler/OutputGLSL.h:

(TOutputGLSL):

  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::TOutputGLSLBase):
(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeFunctionParameters):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitSymbol):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashName):
(TOutputGLSLBase::hashVariableName):
(TOutputGLSLBase::hashFunctionName):

  • src/compiler/OutputGLSLBase.h:

(TOutputGLSLBase):

  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitBranch):
(sh::OutputHLSL::handleExcessiveLoop):

  • src/compiler/OutputHLSL.h:

(OutputHLSL):

  • src/compiler/ParseHelper.cpp:

(TParseContext::error):
(TParseContext::nonInitConstErrorCheck):
(PaParseStrings):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):
(TParseContext):
(TParseContext::numErrors):

  • src/compiler/RenameFunction.h:

(RenameFunction::visitAggregate):

  • src/compiler/ShHandle.h:

(TCompiler::getHashFunction):
(TCompiler::getNameMap):
(TCompiler::getSymbolTable):
(TCompiler):

  • src/compiler/ShaderLang.cpp:

(ShInitBuiltInResources):
(ShGetInfo):
(ShGetNameHashingEntry):

  • src/compiler/SymbolTable.cpp:

(TType::TType):
(TType::isStructureContainingArrays):

  • src/compiler/SymbolTable.h:

(TSymbolTable::findBuiltIn):
(TSymbolTable):

  • src/compiler/TranslatorESSL.cpp:

(TranslatorESSL::translate):

  • src/compiler/TranslatorGLSL.cpp:

(TranslatorGLSL::translate):

  • src/compiler/Types.h:

(TType):
(TPublicType):
(TPublicType::setBasic):
(TPublicType::setAggregate):
(TPublicType::setArray):
(TPublicType::isStructureContainingArrays):

  • src/compiler/UnfoldShortCircuit.cpp:

(sh::UnfoldShortCircuit::visitBinary):

  • src/compiler/VariableInfo.cpp:

(getVariableInfo):
(getUserDefinedVariableInfo):
(TVariableInfo::TVariableInfo):
(CollectAttribsUniforms::CollectAttribsUniforms):
(CollectAttribsUniforms::visitAggregate):

  • src/compiler/VariableInfo.h:

(TVariableInfo):
(CollectAttribsUniforms):

  • src/compiler/VariablePacker.cpp: Added.

(VariablePacker::GetNumComponentsPerRow):
(VariablePacker::GetNumRows):
(TVariableInfoComparer::operator()):
(VariablePacker::makeColumnFlags):
(VariablePacker::fillColumns):
(VariablePacker::searchColumn):
(VariablePacker::CheckVariablesWithinPackingLimits):

  • src/compiler/VariablePacker.h: Added.

(VariablePacker):

  • src/compiler/VersionGLSL.cpp:

(TVersionGLSL::visitAggregate):

  • src/compiler/VersionGLSL.h:

(TVersionGLSL):

  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(string_input):
(glslang_finalize):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/intermediate.h:

(TIntermTraverser):

  • src/compiler/osinclude.h:

(OS_GetTLSValue):

  • src/compiler/ossource_nspr.cpp:
  • src/compiler/preprocessor/DiagnosticsBase.cpp: Added.

(pp):
(pp::Diagnostics::~Diagnostics):
(pp::Diagnostics::report):
(pp::Diagnostics::severity):
(pp::Diagnostics::message):

  • src/compiler/preprocessor/DiagnosticsBase.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Diagnostics.h.

(pp):
(Diagnostics):

  • src/compiler/preprocessor/DirectiveHandlerBase.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveHandlerBase.cpp.

(pp):
(pp::DirectiveHandler::~DirectiveHandler):

  • src/compiler/preprocessor/DirectiveHandlerBase.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveHandler.h.

(pp):
(DirectiveHandler):

  • src/compiler/preprocessor/DirectiveParser.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveParser.cpp.

(getDirective):
(isConditionalDirective):
(isEOD):
(skipUntilEOD):
(isMacroNameReserved):
(isMacroPredefined):
(pp):
(DefinedParser):
(pp::DefinedParser::DefinedParser):
(pp::DefinedParser::lex):
(pp::DirectiveParser::DirectiveParser):
(pp::DirectiveParser::lex):
(pp::DirectiveParser::parseDirective):
(pp::DirectiveParser::parseDefine):
(pp::DirectiveParser::parseUndef):
(pp::DirectiveParser::parseIf):
(pp::DirectiveParser::parseIfdef):
(pp::DirectiveParser::parseIfndef):
(pp::DirectiveParser::parseElse):
(pp::DirectiveParser::parseElif):
(pp::DirectiveParser::parseEndif):
(pp::DirectiveParser::parseError):
(pp::DirectiveParser::parsePragma):
(pp::DirectiveParser::parseExtension):
(pp::DirectiveParser::parseVersion):
(pp::DirectiveParser::parseLine):
(pp::DirectiveParser::skipping):
(pp::DirectiveParser::parseConditionalIf):
(pp::DirectiveParser::parseExpressionIf):
(pp::DirectiveParser::parseExpressionIfdef):

  • src/compiler/preprocessor/DirectiveParser.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/DirectiveParser.h.

(pp):
(DirectiveParser):
(ConditionalBlock):
(pp::DirectiveParser::ConditionalBlock::ConditionalBlock):

  • src/compiler/preprocessor/ExpressionParser.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.cpp.

(yysyntax_error):
(yylex):
(yyerror):
(pp):
(pp::ExpressionParser::ExpressionParser):
(pp::ExpressionParser::parse):

  • src/compiler/preprocessor/ExpressionParser.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.h.

(pp):
(ExpressionParser):

  • src/compiler/preprocessor/ExpressionParser.y: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/ExpressionParser.y.
  • src/compiler/preprocessor/Input.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Input.cpp.

(pp):
(pp::Input::Input):
(pp::Input::read):

  • src/compiler/preprocessor/Input.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Input.h.

(pp):
(Input):
(pp::Input::count):
(pp::Input::string):
(pp::Input::length):
(Location):
(pp::Input::Location::Location):
(pp::Input::readLoc):

  • src/compiler/preprocessor/Lexer.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Lexer.cpp.

(pp):
(pp::Lexer::~Lexer):

  • src/compiler/preprocessor/Lexer.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Lexer.h.

(pp):
(Lexer):

  • src/compiler/preprocessor/Macro.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Macro.cpp.

(pp):
(pp::Macro::equals):

  • src/compiler/preprocessor/Macro.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Macro.h.

(pp):
(pp::Macro::Macro):
(Macro):

  • src/compiler/preprocessor/MacroExpander.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.cpp.

(pp):
(TokenLexer):
(pp::TokenLexer::TokenLexer):
(pp::TokenLexer::lex):
(pp::MacroExpander::MacroExpander):
(pp::MacroExpander::~MacroExpander):
(pp::MacroExpander::lex):
(pp::MacroExpander::getToken):
(pp::MacroExpander::ungetToken):
(pp::MacroExpander::isNextTokenLeftParen):
(pp::MacroExpander::pushMacro):
(pp::MacroExpander::popMacro):
(pp::MacroExpander::expandMacro):
(pp::MacroExpander::collectMacroArgs):
(pp::MacroExpander::replaceMacroParams):

  • src/compiler/preprocessor/MacroExpander.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/MacroExpander.h.

(pp):
(MacroExpander):
(MacroContext):
(pp::MacroExpander::MacroContext::MacroContext):
(pp::MacroExpander::MacroContext::empty):
(pp::MacroExpander::MacroContext::get):
(pp::MacroExpander::MacroContext::unget):

  • src/compiler/preprocessor/Preprocessor.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Preprocessor.cpp.

(pp):
(PreprocessorImpl):
(pp::PreprocessorImpl::PreprocessorImpl):
(pp::Preprocessor::Preprocessor):
(pp::Preprocessor::~Preprocessor):
(pp::Preprocessor::init):
(pp::Preprocessor::predefineMacro):
(pp::Preprocessor::lex):

  • src/compiler/preprocessor/Preprocessor.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Preprocessor.h.

(pp):
(Preprocessor):

  • src/compiler/preprocessor/SourceLocation.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/SourceLocation.h.

(pp):
(pp::SourceLocation::SourceLocation):
(SourceLocation):
(pp::SourceLocation::equals):
(pp::operator==):
(pp::operator!=):

  • src/compiler/preprocessor/Token.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Token.cpp.

(pp):
(pp::Token::reset):
(pp::Token::equals):
(pp::Token::setAtStartOfLine):
(pp::Token::setHasLeadingSpace):
(pp::Token::setExpansionDisabled):
(pp::Token::iValue):
(pp::Token::uValue):
(pp::Token::fValue):
(pp::operator<<):

  • src/compiler/preprocessor/Token.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Token.h.

(pp):
(pp::Token::Token):
(Token):
(pp::Token::atStartOfLine):
(pp::Token::hasLeadingSpace):
(pp::Token::expansionDisabled):
(pp::operator==):
(pp::operator!=):

  • src/compiler/preprocessor/Tokenizer.cpp: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.cpp.

(yy_buffer_state):
(yy_trans_info):
(yyguts_t):
(yy_get_previous_state):
(yy_try_NUL_trans):
(input):
(pprestart):
(pp_switch_to_buffer):
(pp_load_buffer_state):
(pp_create_buffer):
(pp_delete_buffer):
(pp_init_buffer):
(pp_flush_buffer):
(pppush_buffer_state):
(pppop_buffer_state):
(ppensure_buffer_stack):
(pp_scan_buffer):
(pp_scan_string):
(pp_scan_bytes):
(yy_fatal_error):
(ppget_extra):
(ppget_lineno):
(ppget_column):
(ppget_in):
(ppget_out):
(ppget_leng):
(ppget_text):
(ppset_extra):
(ppset_lineno):
(ppset_column):
(ppset_in):
(ppset_out):
(ppget_debug):
(ppset_debug):
(ppget_lval):
(ppset_lval):
(ppget_lloc):
(ppset_lloc):
(pplex_init):
(pplex_init_extra):
(yy_init_globals):
(pplex_destroy):
(yy_flex_strncpy):
(yy_flex_strlen):
(ppalloc):
(pprealloc):
(ppfree):
(pp):
(pp::Tokenizer::Tokenizer):
(pp::Tokenizer::~Tokenizer):
(pp::Tokenizer::init):
(pp::Tokenizer::setFileNumber):
(pp::Tokenizer::setLineNumber):
(pp::Tokenizer::lex):
(pp::Tokenizer::initScanner):
(pp::Tokenizer::destroyScanner):

  • src/compiler/preprocessor/Tokenizer.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.h.

(pp):
(Tokenizer):
(Context):

  • src/compiler/preprocessor/Tokenizer.l: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/Tokenizer.l.
  • src/compiler/preprocessor/atom.c: Removed.
  • src/compiler/preprocessor/atom.h: Removed.
  • src/compiler/preprocessor/compile.h: Removed.
  • src/compiler/preprocessor/cpp.c: Removed.
  • src/compiler/preprocessor/cpp.h: Removed.
  • src/compiler/preprocessor/cppstruct.c: Removed.
  • src/compiler/preprocessor/generate_parser.sh: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/generate_parser.sh.
  • src/compiler/preprocessor/memory.c: Removed.
  • src/compiler/preprocessor/memory.h: Removed.
  • src/compiler/preprocessor/new/DiagnosticsBase.cpp: Removed.
  • src/compiler/preprocessor/new/new_file.cpp: Removed.
  • src/compiler/preprocessor/new/new_file2.cpp: Removed.
  • src/compiler/preprocessor/new/preprocessor.vcproj: Removed.
  • src/compiler/preprocessor/numeric_lex.h: Added.

(pp):
(pp::numeric_base_int):
(pp::numeric_lex_int):
(pp::numeric_lex_float):

  • src/compiler/preprocessor/parser.h: Removed.
  • src/compiler/preprocessor/pp_utils.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/preprocessor/new/pp_utils.h.
  • src/compiler/preprocessor/preprocess.h: Removed.
  • src/compiler/preprocessor/scanner.c: Removed.
  • src/compiler/preprocessor/scanner.h: Removed.
  • src/compiler/preprocessor/slglobals.h: Removed.
  • src/compiler/preprocessor/symbols.c: Removed.
  • src/compiler/preprocessor/symbols.h: Removed.
  • src/compiler/preprocessor/tokens.c: Removed.
  • src/compiler/preprocessor/tokens.h: Removed.
  • src/libEGL/Config.cpp: Removed.
  • src/libEGL/Config.h: Removed.
  • src/libEGL/Display.cpp: Removed.
  • src/libEGL/Display.h: Removed.
  • src/libEGL/README: Added.
  • src/libEGL/Surface.cpp: Removed.
  • src/libEGL/Surface.h: Removed.
  • src/libEGL/libEGL.cpp: Removed.
  • src/libEGL/libEGL.def: Removed.
  • src/libEGL/libEGL.rc: Removed.
  • src/libEGL/libEGL.vcproj: Removed.
  • src/libEGL/main.cpp: Removed.
  • src/libEGL/main.h: Removed.
  • src/libEGL/resource.h: Removed.
  • src/libGLESv2/Blit.cpp: Removed.
  • src/libGLESv2/Blit.h: Removed.
  • src/libGLESv2/Buffer.cpp: Removed.
  • src/libGLESv2/Buffer.h: Removed.
  • src/libGLESv2/Context.cpp: Removed.
  • src/libGLESv2/Context.h: Removed.
  • src/libGLESv2/Fence.cpp: Removed.
  • src/libGLESv2/Fence.h: Removed.
  • src/libGLESv2/Framebuffer.cpp: Removed.
  • src/libGLESv2/Framebuffer.h: Removed.
  • src/libGLESv2/HandleAllocator.cpp: Removed.
  • src/libGLESv2/HandleAllocator.h: Removed.
  • src/libGLESv2/IndexDataManager.cpp: Removed.
  • src/libGLESv2/IndexDataManager.h: Removed.
  • src/libGLESv2/Program.cpp: Removed.
  • src/libGLESv2/Program.h: Removed.
  • src/libGLESv2/ProgramBinary.cpp: Removed.
  • src/libGLESv2/ProgramBinary.h: Removed.
  • src/libGLESv2/Query.cpp: Removed.
  • src/libGLESv2/Query.h: Removed.
  • src/libGLESv2/README: Added.
  • src/libGLESv2/Renderbuffer.cpp: Removed.
  • src/libGLESv2/Renderbuffer.h: Removed.
  • src/libGLESv2/ResourceManager.cpp: Removed.
  • src/libGLESv2/ResourceManager.h: Removed.
  • src/libGLESv2/Shader.cpp: Removed.
  • src/libGLESv2/Shader.h: Removed.
  • src/libGLESv2/Texture.cpp: Removed.
  • src/libGLESv2/Texture.h: Removed.
  • src/libGLESv2/VertexDataManager.cpp: Removed.
  • src/libGLESv2/VertexDataManager.h: Removed.
  • src/libGLESv2/libGLESv2.cpp: Removed.
  • src/libGLESv2/libGLESv2.def: Removed.
  • src/libGLESv2/libGLESv2.rc: Removed.
  • src/libGLESv2/libGLESv2.vcproj: Removed.
  • src/libGLESv2/main.cpp: Removed.
  • src/libGLESv2/main.h: Removed.
  • src/libGLESv2/mathutil.h: Removed.
  • src/libGLESv2/resource.h: Removed.
  • src/libGLESv2/utilities.cpp: Removed.
  • src/libGLESv2/utilities.h: Removed.
  • src/libGLESv2/vertexconversion.h: Removed.

Source/WebCore:

Update the files used in the EFL and GTK builds.

No new tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Source/WebKit:

  • PlatformEfl.cmake: Add ANGLE/include to the include directories list because ShaderLang.h

now includes "KHR/khrplatform.h", which is located in ANGLE/include/KHR/khrplatform.h.

Source/WebKit2:

  • PlatformEfl.cmake: Add ANGLE/include to the include directories list because ShaderLang.h

now includes "KHR/khrplatform.h", which is located in ANGLE/include/KHR/khrplatform.h.

2:23 PM Changeset in webkit [139664] by jchaffraix@webkit.org
  • 3 edits
    3 adds in trunk

REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
​https://bugs.webkit.org/show_bug.cgi?id=105861

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/repaint/overhanging-float-detach-repaint.html

The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

  • fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
  • fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
  • fast/repaint/overhanging-float-detach-repaint.html: Added.
2:21 PM Changeset in webkit [139663] by dmazzoni@google.com
  • 14 edits
    3 adds in trunk

AX: Need to implement ColorWellRole
​https://bugs.webkit.org/show_bug.cgi?id=106756

Reviewed by Chris Fleizach.

Source/WebCore:

Maps input type=color to the accessible role ColorWellRole.
Adds a new accessor to AccessibilityObject to get the color
value in a cross-platform way that doesn't require parsing.

Test: accessibility/color-well.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isColorWell):
(AccessibilityObject):
(WebCore::AccessibilityObject::colorValue):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • html/HTMLInputElement.cpp:

(WebCore):
(WebCore::HTMLInputElement::isColorControl):

  • html/HTMLInputElement.h:

(HTMLInputElement):

Source/WebKit/chromium:

Adds an accessibility interface to access the value of a
color control.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::colorValue):
(WebKit):

Tools:

Returns a string representation of the value of a color
when the role is Color Well, to make it easy to write layout
tests for color controls.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

LayoutTests:

Adds a test of accessibility attributes for input type=color.

  • accessibility/color-well.html: Added.
  • platform/chromium/accessibility/color-well-expected.txt: Added.
  • platform/mac/accessibility/color-well-expected.txt: Added.
2:14 PM Changeset in webkit [139662] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139345
BUG=169006
Review URL: ​https://codereview.chromium.org/11884035

2:11 PM Changeset in webkit [139661] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139457
BUG=168969
Review URL: ​https://codereview.chromium.org/11879026

1:45 PM Changeset in webkit [139660] by schenney@chromium.org
  • 5 edits
    6 adds
    7 deletes in trunk/LayoutTests

Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Unreviewed expectations clean-up.

These files apparently need new baselines after the dashing optimization was removed.
It's a little odd, so maybe the expectations for that bug were hiding these failures.
Finally, hindi-spacing may be a flakey test.

  • platform/chromium-linux-x86/fast/text/international/hindi-spacing-expected.png: Removed.
  • platform/chromium-linux/fast/borders/border-image-01-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-longhand-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-repeat-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-scrambled-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-slices-expected.png: Added.
  • platform/chromium-linux/fast/borders/border-image-source-expected.png: Added.
  • platform/chromium-linux/fast/css/continuationCrash-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-win-xp/fast/borders/border-image-01-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-longhand-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-repeat-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-scrambled-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-slices-expected.png: Removed.
  • platform/chromium-win-xp/fast/borders/border-image-source-expected.png: Removed.
1:40 PM Changeset in webkit [139659] by eae@chromium.org
  • 5 edits
    2 adds in trunk

offsetWidth/height incorrect for images when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=106624

Source/WebCore:

Reviewed by Levi Weintraub.

offsetWidth and height are incorrect for images at certain zoom
levels due to flooring the values ones adjusted for zoom.
By rounding the value instead we avoid the problem and return
the right size.

Test: fast/images/zoomed-offset-size.html

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):
Change to round (as opposed to floor) the zoom adjusted value.

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):
Add LayoutUnit version of adjustForAbsoluteZoom to avoid float
conversion.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for offsetWidth/Height for zoomed image.

  • fast/images/zoomed-offset-size-expected.txt: Added.
  • fast/images/zoomed-offset-size.html: Added.
1:38 PM Changeset in webkit [139658] by dmazzoni@google.com
  • 4 edits in trunk

Chromium: Error in AccessibilityUIElement::intValueGetterCallback
​https://bugs.webkit.org/show_bug.cgi?id=106682

Reviewed by Chris Fleizach.

Tools:

Modify Chromium's DRT implementation of intValue to return a
different value depending on the role.

There are actually platform-specific differences in what should
be returned in the "value" of an object, so Chromium normally keeps
these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
but this is a fine simplification to make cross-platform tests easier.

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:

(WebTestRunner::AccessibilityUIElement::intValueGetterCallback):

LayoutTests:

Unskip accessibility/heading-level.html now that the bug is fixed.

  • platform/chromium/TestExpectations:
1:37 PM Changeset in webkit [139657] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139100
BUG=167780
Review URL: ​https://codereview.chromium.org/11879024

1:31 PM Changeset in webkit [139656] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 139444
BUG=161240
Review URL: ​https://codereview.chromium.org/11886026

1:31 PM Changeset in webkit [139655] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

NetworkProcess scheduler never resumes resource loads that were postponed
due to connection limit
​https://bugs.webkit.org/show_bug.cgi?id=106821

Reviewed by Brady Eidson.

  • NetworkProcess/NetworkResourceLoadScheduler.cpp: (WebKit::NetworkResourceLoadScheduler::servePendingRequests):
  • NetworkProcess/NetworkResourceLoadScheduler.h: Remove an uninitialized variable that could prevent loading.
1:31 PM Changeset in webkit [139654] by schenney@chromium.org
  • 391 edits
    2 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures of W3C tests. This should be the last.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Removed.
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac-lion/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Removed.
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
  • platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win-xp/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.png:
1:22 PM Changeset in webkit [139653] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 138988
BUG=138988
Review URL: ​https://codereview.chromium.org/11876028

1:21 PM Changeset in webkit [139652] by pilgrim@chromium.org
  • 4 edits
    2 moves in trunk/Source

[Chromium] Move AudioDestinationChromium into WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106803

Reviewed by Adam Barth.

This doesn't really belong in WebKit/chromium/src since it defines
things directly in the WebCore namespace.

Source/WebCore:

  • WebCore.gypi:
  • platform/audio/chromium/AudioDestinationChromium.cpp: Added.

(WebCore):
(WebCore::AudioDestination::create):
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
(WebCore::AudioDestinationChromium::~AudioDestinationChromium):
(WebCore::AudioDestinationChromium::start):
(WebCore::AudioDestinationChromium::stop):
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationChromium::render):
(WebCore::AudioDestinationChromium::provideInput):

  • platform/audio/chromium/AudioDestinationChromium.h: Added.

(WebCore):
(AudioDestinationChromium):
(WebCore::AudioDestinationChromium::isPlaying):
(WebCore::AudioDestinationChromium::sampleRate):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/AudioDestinationChromium.cpp: Removed.
  • src/AudioDestinationChromium.h: Removed.
1:16 PM Changeset in webkit [139651] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/rendering/InlineIterator.h

Merge 139213
BUG=156096
Review URL: ​https://codereview.chromium.org/11886025

1:14 PM Changeset in webkit [139650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Fix indentation for GStreamer supported MIME types list
​https://bugs.webkit.org/show_bug.cgi?id=106812

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-01-14
Reviewed by Philippe Normand.

No tests. No change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
1:11 PM Changeset in webkit [139649] by schenney@chromium.org
  • 301 edits
    12 adds
    9 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures all but W3C tests.

  • platform/chromium-linux-x86/svg/custom/image-small-width-height-expected.png: Removed.
  • platform/chromium-linux/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-linux/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-linux/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-linux/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-linux/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-linux/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-linux/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-linux/svg/batik/text/textProperties-expected.png:
  • platform/chromium-linux/svg/batik/text/textStyles-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-linux/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-linux/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-linux/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-linux/svg/custom/fill-fallback-expected.png:
  • platform/chromium-linux/svg/custom/focus-ring-expected.png:
  • platform/chromium-linux/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-linux/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-linux/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-linux/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-linux/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-linux/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-linux/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-linux/svg/custom/invalid-css-expected.png:
  • platform/chromium-linux/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-linux/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-linux/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-linux/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-linux/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-linux/svg/custom/non-scaling-stroke-expected.png: Added.
  • platform/chromium-linux/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-linux/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-linux/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-linux/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-linux/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-linux/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-linux/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-linux/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-linux/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-linux/svg/custom/use-detach-expected.png:
  • platform/chromium-linux/svg/custom/use-on-text-expected.png:
  • platform/chromium-linux/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-lion/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-lion/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-lion/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-lion/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-lion/svg/carto.net/selectionlist-expected.png: Added.
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-lion/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-lion/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac-lion/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac-lion/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac-lion/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-lion/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac-lion/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac-lion/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-lion/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-lion/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac-lion/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac-lion/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac-lion/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac-lion/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac-lion/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac-lion/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac-lion/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-mac-lion/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac-lion/svg/custom/use-detach-expected.png:
  • platform/chromium-mac-lion/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac-snowleopard/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac-snowleopard/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-mac/svg/as-background-image/background-image-tiled-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-mac/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
  • platform/chromium-mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-mac/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png:
  • platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-mac/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-mac/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-mac/svg/batik/text/textProperties-expected.png:
  • platform/chromium-mac/svg/batik/text/textStyles-expected.png:
  • platform/chromium-mac/svg/carto.net/combobox-expected.png:
  • platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-mac/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-mac/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-mac/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-mac/svg/custom/deep-dynamic-updates-expected.png:
  • platform/chromium-mac/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-mac/svg/custom/fill-fallback-expected.png:
  • platform/chromium-mac/svg/custom/focus-ring-expected.png:
  • platform/chromium-mac/svg/custom/gradient-add-stops-expected.png:
  • platform/chromium-mac/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-mac/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-mac/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stop-style-change-expected.png:
  • platform/chromium-mac/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-mac/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/chromium-mac/svg/custom/group-opacity-expected.png:
  • platform/chromium-mac/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-mac/svg/custom/invalid-css-expected.png:
  • platform/chromium-mac/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-mac/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-mac/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-mac/svg/custom/js-update-stop-expected.png:
  • platform/chromium-mac/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-mac/svg/custom/large-bounding-box-percents-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-mac/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-mac/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png:
  • platform/chromium-mac/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-mac/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-mac/svg/custom/resource-client-removal-expected.png:
  • platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-mac/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-mac/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-mac/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-mac/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-mac/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-mac/svg/custom/uri-reference-handling-expected.png: Added.
  • platform/chromium-mac/svg/custom/use-detach-expected.png:
  • platform/chromium-mac/svg/custom/use-on-text-expected.png:
  • platform/chromium-mac/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-mac/svg/custom/xlink-custom-namespace-expected.png: Added.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-1-expected.png: Added.
  • platform/chromium-win-xp/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win-xp/svg/custom/image-small-width-height-expected.png: Removed.
  • platform/chromium-win-xp/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
  • platform/chromium-win/svg/as-background-image/background-image-tiled-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-1-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-2-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-3-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-6-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
  • platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
  • platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
  • platform/chromium-win/svg/as-image/svg-as-relative-image-with-explicit-size-expected.png:
  • platform/chromium-win/svg/batik/masking/maskRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/gradientLimit-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-expected.png:
  • platform/chromium-win/svg/batik/paints/patternRegions-positioned-objects-expected.png:
  • platform/chromium-win/svg/batik/text/smallFonts-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect2-expected.png:
  • platform/chromium-win/svg/batik/text/textEffect3-expected.png:
  • platform/chromium-win/svg/batik/text/textFeatures-expected.png:
  • platform/chromium-win/svg/batik/text/textProperties-expected.png:
  • platform/chromium-win/svg/batik/text/textStyles-expected.png:
  • platform/chromium-win/svg/carto.net/combobox-expected.png:
  • platform/chromium-win/svg/carto.net/selectionlist-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/css/mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/custom/circular-marker-reference-2-expected.png:
  • platform/chromium-win/svg/custom/clone-element-with-animated-svg-properties-expected.png:
  • platform/chromium-win/svg/custom/dasharrayOrigin-expected.png:
  • platform/chromium-win/svg/custom/deep-dynamic-updates-expected.png:
  • platform/chromium-win/svg/custom/dominant-baseline-hanging-expected.png:
  • platform/chromium-win/svg/custom/fill-fallback-expected.png:
  • platform/chromium-win/svg/custom/focus-ring-expected.png:
  • platform/chromium-win/svg/custom/gradient-add-stops-expected.png: Added.
  • platform/chromium-win/svg/custom/gradient-cycle-detection-expected.png:
  • platform/chromium-win/svg/custom/gradient-deep-referencing-expected.png:
  • platform/chromium-win/svg/custom/gradient-rotated-bbox-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-corner-cases-expected.png:
  • platform/chromium-win/svg/custom/gradient-stop-style-change-expected.png: Added.
  • platform/chromium-win/svg/custom/gradient-stroke-width-expected.png:
  • platform/chromium-win/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png:
  • platform/chromium-win/svg/custom/group-opacity-expected.png:
  • platform/chromium-win/svg/custom/image-small-width-height-expected.png:
  • platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/chromium-win/svg/custom/invalid-css-expected.png:
  • platform/chromium-win/svg/custom/invalid-uri-stroke-expected.png:
  • platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
  • platform/chromium-win/svg/custom/js-update-bounce-expected.png:
  • platform/chromium-win/svg/custom/js-update-gradient-expected.png:
  • platform/chromium-win/svg/custom/js-update-stop-expected.png:
  • platform/chromium-win/svg/custom/js-update-stop-linked-gradient-expected.png:
  • platform/chromium-win/svg/custom/large-bounding-box-percents-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-preserveAspectRatio-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-viewTarget-expected.png:
  • platform/chromium-win/svg/custom/linking-a-03-b-zoomAndPan-expected.png:
  • platform/chromium-win/svg/custom/non-circular-marker-reference-expected.png:
  • platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
  • platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png:
  • platform/chromium-win/svg/custom/recursive-gradient-expected.png:
  • platform/chromium-win/svg/custom/relative-sized-content-with-resources-expected.png:
  • platform/chromium-win/svg/custom/resource-client-removal-expected.png: Added.
  • platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
  • platform/chromium-win/svg/custom/stroke-fallback-expected.png:
  • platform/chromium-win/svg/custom/stroke-opacity-update-expected.png:
  • platform/chromium-win/svg/custom/stroked-pattern-expected.png:
  • platform/chromium-win/svg/custom/text-repaint-including-stroke-expected.png:
  • platform/chromium-win/svg/custom/text-rotated-gradient-expected.png:
  • platform/chromium-win/svg/custom/transformed-pattern-clamp-svg-root-expected.png:
  • platform/chromium-win/svg/custom/uri-reference-handling-expected.png: Added.
  • platform/chromium-win/svg/custom/use-detach-expected.png:
  • platform/chromium-win/svg/custom/use-on-text-expected.png:
  • platform/chromium-win/svg/custom/use-setAttribute-crash-expected.png:
  • platform/chromium-win/svg/custom/xlink-custom-namespace-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/svg/custom/gradient-add-stops-expected.png: Removed.
  • platform/chromium/svg/custom/gradient-stop-style-change-expected.png: Removed.
  • platform/chromium/svg/custom/resource-client-removal-expected.png: Removed.
  • platform/chromium/svg/custom/uri-reference-handling-expected.png: Removed.
  • platform/chromium/svg/custom/xlink-custom-namespace-expected.png: Removed.
  • platform/efl/svg/custom/gradient-deep-referencing-expected.png: Removed.
  • platform/gtk/svg/custom/gradient-deep-referencing-expected.png: Removed.
  • svg/custom/gradient-deep-referencing-expected.png: Added.
1:11 PM Changeset in webkit [139648] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/page/FrameView.cpp

Merge 139365
BUG=153184
Review URL: ​https://codereview.chromium.org/11885028

1:08 PM Changeset in webkit [139647] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/page/FrameView.cpp

Merge 139365
BUG=153184
Review URL: ​https://codereview.chromium.org/11889016

1:04 PM Changeset in webkit [139646] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/dom/Document.cpp

Merge 139470
BUG=146145
Review URL: ​https://codereview.chromium.org/11891002

1:03 PM Changeset in webkit [139645] by cevans@google.com
  • 1 edit in branches/chromium/1312/Source/WebCore/dom/Document.cpp

Merge 139470
BUG=146145
Review URL: ​https://codereview.chromium.org/11889015

12:49 PM Changeset in webkit [139644] by schenney@chromium.org
  • 286 edits
    1 add
    3 deletes in trunk/LayoutTests

[Chromium] More test expectations for Skia changes

Unreviewed test expectations update.

SVG failures in directories after dynamic-updates now fixed.

  • platform/chromium-linux-x86/svg/dynamic-updates: Removed.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-linux/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-linux/svg/filters/feDropShadow-expected.png:
  • platform/chromium-linux/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-linux/svg/hixie/error/017-expected.png:
  • platform/chromium-linux/svg/hixie/perf/005-expected.png:
  • platform/chromium-linux/svg/hixie/perf/006-expected.png:
  • platform/chromium-linux/svg/text/selection-background-color-expected.png:
  • platform/chromium-linux/svg/text/selection-styles-expected.png:
  • platform/chromium-linux/svg/text/small-fonts-3-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-linux/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-linux/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-lion/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac-lion/svg/hixie/error/017-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/005-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/006-expected.png:
  • platform/chromium-mac-lion/svg/hixie/perf/007-expected.png:
  • platform/chromium-mac-lion/svg/text/selection-background-color-expected.png:
  • platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
  • platform/chromium-mac-lion/svg/text/small-fonts-3-expected.png:
  • platform/chromium-mac-lion/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-lion/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-lion/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-lion/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-lion/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-lion/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-lion/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-lion/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac-snowleopard/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/chromium-mac/svg/filters/feDropShadow-expected.png:
  • platform/chromium-mac/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-mac/svg/filters/feTile-expected.png:
  • platform/chromium-mac/svg/hixie/error/017-expected.png:
  • platform/chromium-mac/svg/hixie/perf/005-expected.png:
  • platform/chromium-mac/svg/hixie/perf/006-expected.png:
  • platform/chromium-mac/svg/hixie/perf/007-expected.png:
  • platform/chromium-mac/svg/repaint/inner-svg-change-viewBox-expected.png:
  • platform/chromium-mac/svg/text/selection-background-color-expected.png:
  • platform/chromium-mac/svg/text/selection-styles-expected.png:
  • platform/chromium-mac/svg/text/small-fonts-3-expected.png:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/transforms/animated-path-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-mac/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-image-tiled-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium-win-xp/svg/dynamic-updates: Removed.
  • platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-in-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-operator-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-dom-radius-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-in-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-operator-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFEMorphologyElement-svgdom-radius-call-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-x2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y1-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-dom-y2-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-x2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y1-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-y2-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cx-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-cy-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fx-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-fy-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientTransform-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-gradientUnits-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-dom-r-attr-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cx-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-cy-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fx-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-fy-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientUnits-prop-expected.png:
  • platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-r-prop-expected.png:
  • platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png:
  • platform/chromium-win/svg/filters/feDropShadow-expected.png:
  • platform/chromium-win/svg/filters/feImage-late-indirect-update-expected.png:
  • platform/chromium-win/svg/filters/feTile-expected.png:
  • platform/chromium-win/svg/hixie/error/017-expected.png:
  • platform/chromium-win/svg/hixie/perf/005-expected.png:
  • platform/chromium-win/svg/hixie/perf/006-expected.png:
  • platform/chromium-win/svg/repaint/inner-svg-change-viewBox-expected.png: Added.
  • platform/chromium-win/svg/text/selection-background-color-expected.png:
  • platform/chromium-win/svg/text/selection-styles-expected.png:
  • platform/chromium-win/svg/text/small-fonts-3-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
  • platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
  • platform/chromium-win/svg/wicd/sizing-flakiness-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
  • platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-image-tiled-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/chromium-win/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/svg/repaint/inner-svg-change-viewBox-expected.png: Removed.
12:42 PM Changeset in webkit [139643] by commit-queue@webkit.org
  • 2 edits in trunk

Do not hardcode -ldl in OPENGL_LIBS
​https://bugs.webkit.org/show_bug.cgi?id=96602

Patch by Alexandre Rostovtsev <​tetromino@gentoo.org> on 2013-01-14
Reviewed by Philippe Normand.

Some non-Linux systems, e.g. FreeBSD, have dlopen() as part of their
libc, and do not use a separate libdl.

  • configure.ac:
12:35 PM Changeset in webkit [139642] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use correct size for DrawingBuffer readback
​https://bugs.webkit.org/show_bug.cgi?id=106744

Patch by John Bauman <​jbauman@chromium.org> on 2013-01-14
Reviewed by Kenneth Russell.

The value getInternalFramebufferSize is bogus if there's a
DrawingBuffer, so use size() instead.

  • platform/graphics/chromium/DrawingBufferChromium.cpp:

(WebCore::DrawingBuffer::paintCompositedResultsToCanvas):

12:25 PM Changeset in webkit [139641] by jsbell@chromium.org
  • 11 edits in trunk/Source/WebCore

Bindings: Remove special cases for DOMString[]
​https://bugs.webkit.org/show_bug.cgi?id=106506

Remove special in binding code generators that map DOMString[] to DOMStringList.
Array (T[]) and sequence (sequence<T>) are supported enough now that to be used
for Internals, which is the only IDL that needed updating.

Reviewed by Adam Barth.

Tests: fast/forms/file/selected-files-from-history-state.html

fast/forms/state-restore-broken-state.html
fast/forms/state-restore-skip-stateless.html

Bindings test results updated for JS/V8.

  • bindings/scripts/CodeGenerator.pm: Remove redundant IsArrayType (use GetArrayType instead)

(IsRefPtrType): Array and Sequence types are not RefPtr types.

  • bindings/scripts/CodeGeneratorJS.pm:

(IndexGetterReturnsStrings): Remove special case for DOMString[].
(AddIncludesForType): Skip Array types, just like Sequence types. (Should probably recurse
for the base type, but not needed for now.)
(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(GetNativeTypeForCallbacks): Ditto.
(JSValueToNative): Ditto.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheckExpression): s/IsArrayType/GetArrayType/
(GetNativeType): Remove special case for DOMString[].
(JSValueToNative): Ditto.
(GetV8HeaderName): Ditto.
(IsWrapperType):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore::jsTestObjPrototypeFunctionStringArrayFunction):
(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

  • bindings/scripts/test/TestObj.idl: Added explicit new cases for DOMStringList
  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::domStringListFunctionCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • testing/Internals.cpp:

(WebCore::Internals::formControlStateOfPreviousHistoryItem):
(WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
(WebCore::Internals::iconURLs):
(WebCore::Internals::getReferencedFilePaths):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl: Produce DOMString[], consume sequence<DOMString> to match tests.
12:23 PM Changeset in webkit [139640] by kbr@google.com
  • 3 edits in branches/chromium/1364

Merge 139459

[Chromium] WebGL typed array constructor crashes on exception
​https://bugs.webkit.org/show_bug.cgi?id=106308

Reviewed by Kentaro Hara.

Source/WebCore:

Check for empty handles (indicating exception thrown) after calls
into V8 VM.

Added new case from Khronos typed array conformance tests to
fast/canvas/webgl/array-unit-tests.html.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):

Check for empty handles after calls into V8 VM.

LayoutTests:

Updated typed array tests to latest version from Khronos repository.

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html:

TBR=​kbr@google.com
Review URL: ​https://codereview.chromium.org/11889014

12:17 PM Changeset in webkit [139639] by esprehn@chromium.org
  • 9 edits in trunk/Source/WebCore

Clean up WebVTTNodeType code
​https://bugs.webkit.org/show_bug.cgi?id=106714

Reviewed by Tony Chang.

There's no reason for so many methods just to compare some enums.
The existing code can also be simplified quite a bit.

No new tests, just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):

  • dom/Element.cpp:

(WebCore::Element::webVTTNodeType):
(WebCore::Element::setWebVTTNodeType):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::setWebVTTNodeType):
(WebCore::ElementRareData::webVTTNodeType):
(ElementRareData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

  • html/track/TextTrack.h:
  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes):

12:16 PM Changeset in webkit [139638] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r139218): Flaky assertion in WebCore::StorageTask::StorageTask releasing memory
​https://bugs.webkit.org/show_bug.cgi?id=106718

Reviewed by Andreas Kling.

Type assertion was missing a new type.

  • storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):

11:55 AM Changeset in webkit [139637] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Removing entry for editing/spelling/spellcheck-sequencenum.html
in Chromium test expectations. Tony fixed the issue in r139636.

  • platform/chromium/TestExpectations:
11:53 AM Changeset in webkit [139636] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

Layout Test editing/spelling/spellcheck-sequencenum.html is flaky on Debug Win Chromium Bot
​https://bugs.webkit.org/show_bug.cgi?id=106806

Reviewed by Levi Weintraub.

This test manually calls waitUntilDone and uses js-test-pre.js/js-test-post.js. This confuses
the timing of the "PASS successfullyParsed is true" output. Fix this by using the helper
functions in js-test-pre.js for waitUntilDone/notifyDone.

  • editing/spelling/spellcheck-sequencenum-expected.txt:
  • editing/spelling/spellcheck-sequencenum.html:
  • platform/win/editing/spelling/spellcheck-sequencenum-expected.txt: Removed.
11:45 AM Changeset in webkit [139635] by simonjam@chromium.org
  • 5 edits
    3 copies in branches/chromium/1364

Merge 139509

Restore old semantics to webkitRequestAnimationFrame callbacks
​https://bugs.webkit.org/show_bug.cgi?id=106697

Reviewed by James Robinson.

Source/WebCore:

Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.

Test: fast/animation/request-animation-frame-prefix.html

  • dom/RequestAnimationFrameCallback.h:

(RequestAnimationFrameCallback):

  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/animation/request-animation-frame-prefix-expected.txt: Added.
  • fast/animation/request-animation-frame-prefix.html: Added.
  • fast/animation/script-tests/request-animation-frame-prefix.js: Added.

(busyWait):
(window.webkitRequestAnimationFrame):

TBR=​simonjam@chromium.org
Review URL: ​https://codereview.chromium.org/11876026

11:43 AM Changeset in webkit [139634] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

[REGRESSION] Dev Tools popup for Workers forgets sizes/shows tiny in top left
​https://bugs.webkit.org/show_bug.cgi?id=106807

Reviewed by Pavel Feldman.

Open dedicated worker inspector 600x600 by default and remember its size
after resizing.

  • inspector/front-end/Settings.js:
  • inspector/front-end/WorkerManager.js:
11:24 AM Changeset in webkit [139633] by wangxianzhu@chromium.org
  • 3 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 139028

[Chromium] Expose compositedScrollingForFramesEnabled setting in WebKit API
​https://bugs.webkit.org/show_bug.cgi?id=106262

Reviewed by James Robinson.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setCompositedScrollingForFramesEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11882024

11:23 AM Changeset in webkit [139632] by wangxianzhu@chromium.org
  • 5 edits
    2 copies in branches/chromium/1364

Merge 139024

Add a setting to enable composited scrolling for frames
​https://bugs.webkit.org/show_bug.cgi?id=104950

Reviewed by James Robinson.

Source/WebCore:

Test: compositing/iframes/iframe-composited-scrolling.html

  • page/FrameView.cpp:

(WebCore::FrameView::usesCompositedScrolling): Returns true if compositedScrollingForFramesEnabled and the frame is in forced compositing mode (which is set when forced compositing mode and compositing for scrollable frames are enabled), so that ScrollingCoordinator won't include the region of the frame in the nonFastScrollableRegion.
(WebCore):

  • page/FrameView.h:

(FrameView):

  • page/Settings.in: Add compositedScrollingForFramesEnabled setting.
  • page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated): Changed the comment about which ScrollableAreas are non-fast-scrollable.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll): Let ScrollongCoordinator know when the scrolling changes for a frame with composited scrolling enabled.

LayoutTests:

Test case to ensure iframes are not added into nonFastScrollableRegion when acceleratedCompositingForScrollableFramesEnabled and compositedScrollingForFramesEnabled.

  • compositing/iframes/iframe-composited-scrolling-expected.txt: Added.
  • compositing/iframes/iframe-composited-scrolling.html: Added.

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11880030

11:21 AM Changeset in webkit [139631] by wangxianzhu@chromium.org
  • 9 edits in branches/chromium/1364/Source

Merge 138991

Add window.internals.nonFastScrollableRects for testing scrollable areas in fast/slow paths
​https://bugs.webkit.org/show_bug.cgi?id=105546

Reviewed by James Robinson.

.:

Export the new symbol.

  • Source/autotools/symbols.filter:

Source/WebCore:

No new tests. Added test API for new tests of other bugs.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):
(WebCore):

  • page/Page.h:

(WebCore):
(Page):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Change to public to allow Page::nonFastScrollableRects to access.

  • page/scrolling/ScrollingCoordinator.h:

(ScrollingCoordinator):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):
(WebCore):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Export the new symbol.

  • win/WebKit2.def.in:

TBR=​wangxianzhu@chromium.org
Review URL: ​https://codereview.chromium.org/11875020

11:11 AM Changeset in webkit [139630] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

11:09 AM Changeset in webkit [139629] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Zoom is still possible when user-scalable=no
​https://bugs.webkit.org/show_bug.cgi?id=106809

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by George Staikos.

PR: 274566
On wordpress.com, the contents were rendered at the width 343 which was
1 css pixel larger than the expected device-width 342 so that we didn't
respect the viewport.
There was a RenderBlock on the page which contained "\n" and an
inline-block. "\n" took 0.78 width and the inline-block took 342 width
and they were unfortunately placed in the same InlineBox which caused
the contents width 1 css pixels larger than the device-width.
Allow the contents width to be 1 css pixel larger and still respect the
viewport in such a special case.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::respectViewport):

11:04 AM Changeset in webkit [139628] by Lucas Forschler
  • 1 copy in tags/Safari-537.26

New Tag.

11:04 AM Changeset in webkit [139627] by jochen@chromium.org
  • 10 edits in trunk/Tools

[chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=106785

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):

  • DumpRenderTree/chromium/DRTTestRunner.h:

(DRTTestRunner):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestProxyBase):
(WebTestRunner::WebTestProxy::setStatusText):
(WebTestRunner::WebTestProxy::didStopLoading):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::TestRunner::dumpWindowStatusChanges):
(WebTestRunner::TestRunner::dumpProgressFinishedCallback):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didStopLoading):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didStopLoading):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

10:57 AM Changeset in webkit [139626] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking fast/dom/HTMLTemplateElement/inertContents.html
as flaky on Chromium Debug bots.

  • platform/chromium/TestExpectations:
10:51 AM Changeset in webkit [139625] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

IndexedDB: Fix test for error message in storage/indexeddb/transaction-complete-workers.html
​https://bugs.webkit.org/show_bug.cgi?id=106805

Patch by Michael Pruett <​michael@68k.org> on 2013-01-14
Reviewed by Tony Chang.

V8 prepends "Uncaught " to uncaught exceptions, while JSC does not.
Either form of the error message should be acceptable.

  • storage/indexeddb/transaction-complete-workers.html:
10:28 AM Changeset in webkit [139624] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking editing/spelling/spellcheck-sequencenum.html
as flaky on Chromium Win Debug bots.

  • platform/chromium/TestExpectations:
10:08 AM Changeset in webkit [139623] by schenney@chromium.org
  • 4 edits in trunk

Re-enabling the SK_DISABLE_DASHING_OPTIMIZATION flag for Skia

Source/WebKit/chromium:

Unreviewed build fix.

It turns out that the change behind this flag causes crashes and image errors.

  • skia_webkit.gyp:

LayoutTests:

Unreviewed expectations clean-up.

Removing the expectations associated with the flag.

  • platform/chromium/TestExpectations:
9:43 AM Changeset in webkit [139622] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in associateObjectWithWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=106784

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

9:40 AM Changeset in webkit [139621] by haraken@chromium.org
  • 4 edits in trunk/Source

[V8] Make an Isolate parameter mandatory in ScriptDebugServer::interruptAndRun()
​https://bugs.webkit.org/show_bug.cgi?id=106779

Reviewed by Adam Barth.

This is one of steps to make an Isolate parameter mandatory.

No tests. No change in behavior.

Source/WebCore:

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

Source/WebKit/chromium:

  • src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgent::interruptAndDispatch):

9:40 AM Changeset in webkit [139620] by leviw@chromium.org
  • 2 edits
    2 copies in branches/chromium/1364

Merge 139479

RenderGeometryMap and TransformState disagree with sub-pixel layout and translations
​https://bugs.webkit.org/show_bug.cgi?id=106047

Reviewed by Simon Fraser.

Source/WebCore:

Mirror RenderGeometryMap's optimization for integer-translated transforms in TransformState.
This avoids the current behavior where the two can disagree on mappings, since RenderGeometryMap
pixel-snapped later when a translation occurred between two sub-pixel containers.

Test: fast/layers/geometry-map-transform-state-translation-mismatch.html

  • platform/graphics/transforms/TransformState.h:

(WebCore::TransformState::setQuad): Clear accumulatedOffset when setting a new quad. Note: this
implementation only works properly when only tracking a quad.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::applyTransform): apply integral translations to the accumulatedOffset
for performance and consistency with RenderGeometryMap.

LayoutTests:

  • fast/layers/geometry-map-transform-state-translation-mismatch-expected.txt: Added.
  • fast/layers/geometry-map-transform-state-translation-mismatch.html: Added.

TBR=​leviw@chromium.org
Review URL: ​https://codereview.chromium.org/11880024

9:30 AM Changeset in webkit [139619] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in wrap()
​https://bugs.webkit.org/show_bug.cgi?id=106783

Reviewed by Adam Barth.

Now it's safe to make an Isolate parameter in wrap().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestObj.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::wrap):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::wrap):

9:28 AM Changeset in webkit [139618] by tommyw@google.com
  • 8 edits in trunk

MediaStream API: Update MediaStreamTrack::readyState to match specification
​https://bugs.webkit.org/show_bug.cgi?id=106781

Reviewed by Adam Barth.

Source/WebCore:

MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.

Existing tests expanded to cover patch.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::processTrack):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):

  • Modules/mediastream/MediaStreamTrack.h:

(MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
9:25 AM Changeset in webkit [139617] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/LayoutTests

Web Inspector: add text editor formatter test
​https://bugs.webkit.org/show_bug.cgi?id=106705

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adds a test checking text editor formatting.
The test creates a new text editor and fills it in with some
code by the means of simulated key and textInput events.

  • inspector/editor/text-editor-formatter-expected.txt: Added.
  • inspector/editor/text-editor-formatter.html: Added.
8:46 AM Changeset in webkit [139616] by vsevik@chromium.org
  • 4 edits
    1 move
    4 adds in trunk

Web Inspector: Audit Tool's False Positive on Set-Cookie header
​https://bugs.webkit.org/show_bug.cgi?id=106794

Reviewed by Pavel Feldman.

Source/WebCore:

Header value is now returned as undefined if there is no such header as it was before regression.

Test: http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html

  • inspector/front-end/AuditRules.js:

(WebInspector.AuditRules.CSSRuleBase.prototype.sheetsCallback): Drive-by fix, callback should be called even when there is no headers.

  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype._headerValue):

LayoutTests:

  • http/tests/inspector/audits/resources/abe.png: Renamed from LayoutTests/inspector/audits/resources/abe.png.
  • http/tests/inspector/audits/set-cookie-header-audit-no-false-positive-expected.txt: Added.
  • http/tests/inspector/audits/set-cookie-header-audit-no-false-positive.html: Added.
8:33 AM Changeset in webkit [139615] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Do not pass nil when initializing legible output
​https://bugs.webkit.org/show_bug.cgi?id=106799

Reviewed by Jessie Berlin.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): -[AVPlayerItemLegibleOutput initWithDependencyFactory:mediaSubtypesForNativeRepresentation:]

wants an empty NSArray rather than nil.

7:37 AM Changeset in webkit [139614] by aandrey@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI: add control buttons for doing the replay steps
​https://bugs.webkit.org/show_bug.cgi?id=106788

Reviewed by Pavel Feldman.

Adding UI control buttons for doing the Canvas replay steps.
Drive-by: fixed a bug in DataGrid (found by the JSCompiler).

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype._createControlButton):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayFirstStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._enableWaitIcon):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileType.prototype._updateDecorationElement):

  • inspector/front-end/DOMExtension.js:

(Element.prototype.enableStyleClass):

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype.setRootNode):
(WebInspector.DataGrid.prototype._startEditingColumnOfDataGridNode):
(WebInspector.DataGrid.prototype.moveToNextIfNeeded):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGridNode):

  • inspector/front-end/canvasProfiler.css:

(.canvas-replay-image):
(.canvas-replay-image.wait):
(.canvas-replay-controls):
(.canvas-replay-log):
(.canvas-control-button):
(.canvas-control-button:active):
(.canvas-control-button:disabled):
(.canvas-control-button img):
(.canvas-replay-first-step img):
(.canvas-replay-next-step img):
(.canvas-replay-prev-step img):
(.canvas-replay-last-step img):

7:24 AM Changeset in webkit [139613] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Web Inspector: devtools front-end doesn't have focus in TestShell
​https://bugs.webkit.org/show_bug.cgi?id=106778

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Focus devTools window after loadURL method.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::runFileTest):

6:11 AM EFLWebKit/SubpixelRebaseline edited by dominik.rottsches@intel.com
pixel tests (diff)
6:11 AM EFLWebKit edited by thiago.santos@intel.com
(diff)
6:06 AM EFLWebKit/SubpixelRebaseline created by dominik.rottsches@intel.com
Subpixel Rebaseline initial proposal
5:52 AM Changeset in webkit [139612] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
​https://bugs.webkit.org/show_bug.cgi?id=106573

Patch by Raphael Kubo da Costa <​raphael.kubo.da.costa@intel.com> on 2013-01-14
Reviewed by Philippe Normand.

Similarly to what's been described in bug 106569, we're building
from release tarballs, so there's no reason to regenerate the
autoconf-related stuff with autogen.sh, especially since we might
run into trouble with automake 1.13 and deprecated macros.

  • efl/jhbuild.modules:
5:31 AM Changeset in webkit [139611] by tommyw@google.com
  • 22 edits
    3 deletes in trunk

MediaStream API: Update the track accessors on MediaStream to match the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=106660

Reviewed by Adam Barth.

Source/WebCore:

The spec has significantly changed how tracks are accessed from a MediaStream:
​http://dev.w3.org/2011/webrtc/editor/getusermedia.html

In short: the attributes audioTrack/videoTrack that returned special MediaStreamTrackLists have been
replaced by the functions getAudioTracks()/getVideoTracks that return standard sequences of
MediaStreamTracks.

Existing tests updated and expanded to cover patch.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::readyState):
(WebCore):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::getTrackById):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::contextDestroyed):
(WebCore::MediaStream::scheduleDispatchEvent):
(WebCore::MediaStream::scheduledEventTimerFired):

  • Modules/mediastream/MediaStream.h:

(MediaStream):
(WebCore::MediaStream::getAudioTracks):
(WebCore::MediaStream::getVideoTracks):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrackList.cpp: Removed.
  • Modules/mediastream/MediaStreamTrackList.h: Removed.
  • Modules/mediastream/MediaStreamTrackList.idl: Removed.
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createMediaStreamSource):

  • WebCore.gypi:
  • dom/EventTargetFactory.in:
  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::addAudioComponent):
(WebCore::MediaStreamDescriptor::removeAudioComponent):
(WebCore::MediaStreamDescriptor::addVideoComponent):
(WebCore::MediaStreamDescriptor::removeVideoComponent):

LayoutTests:

Updating and expanding tests for the new getAudioTracks()/getVideoTracks().

  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
  • fast/mediastream/MediaStreamTrack.html:
  • fast/mediastream/MediaStreamTrackList-expected.txt:
  • fast/mediastream/MediaStreamTrackList.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html:
  • webaudio/mediastreamaudiosourcenode-expected.txt:
  • webaudio/mediastreamaudiosourcenode.html:
5:08 AM Changeset in webkit [139610] by haraken@chromium.org
  • 8 edits in trunk/Source/WebCore

[V8] Add m_isolate to ScriptController, WorkerScriptController and V8DOMWindowShell
​https://bugs.webkit.org/show_bug.cgi?id=106771

Reviewed by Adam Barth.

This is one of the steps to pass an Isolate everywhere.

No tests. No change in behavior.

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::windowShell):

  • bindings/v8/ScriptController.h:

(ScriptController):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::create):
(WebCore::V8DOMWindowShell::V8DOMWindowShell):
(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWindowShell.h:

(V8DOMWindowShell):

  • bindings/v8/V8Initializer.cpp:

(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::V8Initializer::initializeWorker):

  • bindings/v8/V8Initializer.h:

(V8Initializer):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::initializeContextIfNeeded):

5:01 AM Changeset in webkit [139609] by jocelyn.turcotte@digia.com
  • 2 edits
    4 deletes in trunk/Tools

[Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
​https://bugs.webkit.org/show_bug.cgi?id=104909

Reviewed by Simon Hausmann.

To be able to build redistribuable binary packages, Qt's configure switches
-qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
dynamically link to optional system libraries.
QtWebKit is doing its own configure checks for those libraries, thus adding a
runtime dependency that might not be fulfilled if the packager's machine had
those libraries while the user's machine won't.

Since in most cases where WebKit will want to use those system libraries, Qt will
also be using them, remove these configure tests from WebKit.

  • qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
  • qmake/config.tests/libjpeg/libjpeg.pro: Removed.
  • qmake/config.tests/libpng/libpng.cpp: Removed.
  • qmake/config.tests/libpng/libpng.pro: Removed.
  • qmake/mkspecs/features/features.prf:
4:54 AM Changeset in webkit [139608] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
​https://bugs.webkit.org/show_bug.cgi?id=106574

Reviewed by Laszlo Gombos.

Rely on a more recent stable release, which includes support for
Lua 5.2 in Edje and other assorted minor fixes.

While here, also use the "configure" script to build the libraries
instead of relying on autogen.sh, which is not really needed with
a release tarball and may have problems with automake 1.13.

  • efl/jhbuild.modules:
4:36 AM Changeset in webkit [139607] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: [Styles] Color names parsed inside "background-image" values
​https://bugs.webkit.org/show_bug.cgi?id=106770

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/styles/url-color-swatch.html

Spaces were not allowed in url(...) CSS property values.

  • inspector/front-end/StylesSidebarPane.js:

LayoutTests:

  • inspector/styles/url-color-swatch-expected.txt: Added.
  • inspector/styles/url-color-swatch.html: Added.
4:10 AM Changeset in webkit [139606] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Web Inspector: fix DRT to deliver simulated events to devtools front-end
​https://bugs.webkit.org/show_bug.cgi?id=106650

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Add separated m_devToolsTestInterfaces object to testShell which is
bind to devTools webview.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::showDevTools):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
(TestShell::createNewWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

4:05 AM Changeset in webkit [139605] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

Web Inspector: InspectorTest.createTestEditor should not set any text in editor
​https://bugs.webkit.org/show_bug.cgi?id=106772

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Add InspectorTest.fillEditorWithText helper method and remove this
functionality from InspectorTest.createTestEditor method.

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.createTestEditor): Removed functionality for setting editor text.
(initialize_EditorTests.InspectorTest.fillEditorWithText): Added.

  • inspector/editor/text-editor-remove-chunks-from-dom.html:
  • inspector/editor/text-editor-selection.html:
  • inspector/editor/text-editor-type-over-decoration.html:
4:03 AM Changeset in webkit [139604] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new asserting test to paint the bots green.

  • platform/qt/TestExpectations:
3:57 AM Changeset in webkit [139603] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/src/js/devTools.css

Merge 139413

Web Inspector [chromium]: toolbar border is missing on non-Mac in docked-to-bottom mode
​https://bugs.webkit.org/show_bug.cgi?id=106560

Reviewed by Vsevolod Vlasov.

  • src/js/devTools.css:

(body.dock-to-bottom.platform-mac #toolbar):

TBR=​pfeldman@chromium.org
BUG=169438
Review URL: ​https://codereview.chromium.org/11878018

3:53 AM Changeset in webkit [139602] by pfeldman@chromium.org
  • 4 edits
    2 copies in branches/chromium/1364

Merge 139416

Web Inspector [chromium]: Debugger.globalObjectCleared is not dispatched on reload after renderer swap
​https://bugs.webkit.org/show_bug.cgi?id=106555

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Wrong ::enable was made virtual in the InspectorDebuggerAgent.

Test: inspector/debugger/debugger-scripts-reload.html

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::enable):
(WebCore::PageDebuggerAgent::disable):

  • inspector/PageDebuggerAgent.h:

(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest):

  • inspector/debugger/debugger-scripts-reload-expected.txt: Added.
  • inspector/debugger/debugger-scripts-reload.html: Added.

TBR=​pfeldman@chromium.org
BUG=169437
Review URL: ​https://codereview.chromium.org/11876015

3:10 AM Changeset in webkit [139601] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Pass an Isolate to associateObjectWithWrapper()
​https://bugs.webkit.org/show_bug.cgi?id=106773

Reviewed by Adam Barth.

In preparation for making an Isolate parameter mandatory
in associateObjectWithWrapper(), this patch passes an
Isolate to associateObjectWithWrapper().

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

3:02 AM Changeset in webkit [139600] by kbalazs@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] plugin tests assert in debug
​https://bugs.webkit.org/show_bug.cgi?id=106659

Reviewed by Benjamin Poulain.

Fixed the misuse of String::split.

  • Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:

(WebKit::truncateToSingleLine):
Add an assert to make sure this function works well. I just walked there
while debugging the bug, and although it was innocent, adding this assertion
is logical.

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::scanPlugin):
The ASSERT was wrong. We have three lines, each ends in a newline, so split
with allowEmptyEntries=true will devide it to 4 substrings.

2:44 AM Changeset in webkit [139599] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Call Isolate::GetCurrent() in a callback from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=106766

Reviewed by Adam Barth.

The objective is to pass an Isolate everywhere.
Given that a callback from WebCore is an entry point to V8,
we can call Isolate::GetCurrent() at the head of the callback
and pass it to other places. (In practice, handleEvent() is
the only callback used in the current WebKit.)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithNoParam):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
(WebCore::V8TestCallback::callbackWithStringList):
(WebCore::V8TestCallback::callbackWithBoolean):
(WebCore::V8TestCallback::callbackRequiresThisToPass):

2:15 AM Changeset in webkit [139598] by tommyw@google.com
  • 9 edits in trunk

MediaStream API: Change MediaStream::readyState to an boolean attribute called ended.
​https://bugs.webkit.org/show_bug.cgi?id=106568

Reviewed by Adam Barth.

Source/WebCore:

See specification: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html

Existings tests updated to cover patch.

  • Modules/mediastream/LocalMediaStream.cpp:

(WebCore::LocalMediaStream::stop):

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::ended):
(WebCore::MediaStream::streamEnded):

  • Modules/mediastream/MediaStream.h:

(MediaStream):
(WebCore::MediaStream::isLocal):

  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrackList.cpp:

(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):

LayoutTests:

  • fast/mediastream/LocalMediaStream-onended-expected.txt:
  • fast/mediastream/LocalMediaStream-onended.html:
2:13 AM Changeset in webkit [139597] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Styles] HTML color names not converted to RGB/HEX/HSL when "Color format" feature used
​https://bugs.webkit.org/show_bug.cgi?id=106767

Reviewed by Vsevolod Vlasov.

We used to render named colors as names regardless of the selected color format option.

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

1:55 AM Changeset in webkit [139596] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash caused by incomplete cleanup of regions information for anonymous block
​https://bugs.webkit.org/show_bug.cgi?id=106191

Patch by Andrei Bucur <​abucur@adobe.com> on 2013-01-14
Reviewed by Abhishek Arya.

Source/WebCore:

When an anonymous block is no longer required it is removed from the render tree and deleted. For example, this can happen when an anonymous block children change
from inlines to blocks. The patch updates the removeLeftoverAnonymousBlock function to delete the flow thread information attached to the obsolete anonymous block.
The removeFromRenderFlowThread() function is recursive and it needs to be called after the anonymous block children were reparented and the child list cleared.
I've also placed the children reset operation before clearing the parent because the latter also deletes the inRenderFlowThread flag from the object and it makes
flow thread ownership detection impossible.

Tests: fast/regions/remove-leftover-anon-block-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeLeftoverAnonymousBlock):

LayoutTests:

  • fast/regions/remove-leftover-anon-block-crash-expected.txt: Added.
  • fast/regions/remove-leftover-anon-block-crash.html: Added.
1:52 AM Changeset in webkit [139595] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate parameter mandatory in v8DateOrNull()
​https://bugs.webkit.org/show_bug.cgi?id=106765

Reviewed by Adam Barth.

This is one of the efforts to kill all optional Isolate parameters.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::v8DateOrNull):

1:49 AM Changeset in webkit [139594] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Allow nesting of at-rules
​https://bugs.webkit.org/show_bug.cgi?id=106696

Patch by Pablo Flouret <​pablof@motorola.com> on 2013-01-14
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

​http://dev.w3.org/csswg/css3-conditional/ introduces the
concept of grouping rules, and allows for them to be nested. In
particular, this change affects @media (and is needed for @supports as
well).

Test: fast/css/nested-at-rules.html

  • css/CSSGrammar.y.in:

Move media to the block_valid_rule list.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::addRulesFromSheet):

  • css/RuleSet.h:

Rip out the rule-adding loop into a new method, for added
cleanliness and recursing.

LayoutTests:

  • fast/css/nested-at-rules-expected.txt: Added.
  • fast/css/nested-at-rules.html: Added.
1:44 AM Changeset in webkit [139593] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Add domain column
​https://bugs.webkit.org/show_bug.cgi?id=106757

Patch by Eugene Klyuchnikov <​eustas@chromium.org> on 2013-01-14
Reviewed by Pavel Feldman.

Adding new column will ease domain tracking / sorting.

  • inspector/front-end/NetworkPanel.js: Added column.
  • inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.get domain): Added getter.

1:30 AM Changeset in webkit [139592] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Sheriffbot command aliases need test cases
​https://bugs.webkit.org/show_bug.cgi?id=106754

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-14
Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

(SheriffBotTest.test_command_aliases):

1:23 AM Changeset in webkit [139591] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo error in the comments in PlatformContextSkia.h
​https://bugs.webkit.org/show_bug.cgi?id=105612

Patch by Qiankun Miao <​qiankun.miao@intel.com> on 2013-01-14
Reviewed by Stephen White.

"If false we're rendering to a GraphicsContext for a web page, if false
we're not (as is the case when rendering to a canvas object)." is
self-contradictory. The second "flase" in the comments should be
"true". If true, we're rendering to an ImageBuffer which has a canvas
object.

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

1:12 AM Changeset in webkit [139590] by loislo@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 3/3
​https://bugs.webkit.org/show_bug.cgi?id=106764

Reviewed by Vsevolod Vlasov.

Last three classes with not instrumented members were fixed.

  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::reportMemoryUsage):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

12:21 AM Changeset in webkit [139589] by loislo@chromium.org
  • 20 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: fix instrumentation for already instrumented classes 2/N
​https://bugs.webkit.org/show_bug.cgi?id=106546

Reviewed by Vsevolod Vlasov.

Many nontrivial class members were added into reportMemoryUsage methods.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaList::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

Jan 13, 2013:

11:18 PM Changeset in webkit [139588] by noel.gordon@gmail.com
  • 6 edits
    2 deletes in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg everywhere

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-mac-lion/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/chromium/TestExpectations:
11:01 PM Changeset in webkit [139587] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/render-counter-text.html as flaky
on EFL port since it sometimes crashes.

  • platform/efl/TestExpectations:
10:58 PM Changeset in webkit [139586] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

DFG phases that store per-node information should store it in Node itself rather than using a secondary vector
​https://bugs.webkit.org/show_bug.cgi?id=106753

Reviewed by Geoffrey Garen.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::dump):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::forNode):
(AbstractState):

  • dfg/DFGCFGSimplificationPhase.cpp:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::performSubstitution):
(JSC::DFG::CSEPhase::setReplacement):
(CSEPhase):

  • dfg/DFGNode.h:

(Node):

10:33 PM Changeset in webkit [139585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Allow users to misspell the "sheriffs" command in sheriffbot
​https://bugs.webkit.org/show_bug.cgi?id=106628

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Steve Block.

  • Scripts/webkitpy/tool/bot/irc_command.py:
10:28 PM Changeset in webkit [139584] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Marking media/track/track-css-cue-lifetime.html as a flaky timeout on Debug
Chromium bots.

  • platform/chromium/TestExpectations:
10:05 PM Changeset in webkit [139583] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Web Inspector: [Chromium] DevToolsSanityTest.TestNoScriptDuplicatesOnPanelSwitch fails
​https://bugs.webkit.org/show_bug.cgi?id=106755

Reviewed by Alexander Pavlov.

  • src/js/Tests.js:

(.TestSuite.prototype.nonAnonymousUISourceCodes_.filterOutService):
(.TestSuite.prototype.nonAnonymousUISourceCodes_):

8:42 PM Changeset in webkit [139582] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add a public function WebPage::isLoading()
​https://bugs.webkit.org/show_bug.cgi?id=106751

PR 274392

Patch by Xiaobo Wang <​xbwang@torchmobile.com.cn> on 2013-01-13
Reviewed by George Staikos.

Need to get the load state in WebPageClient when resolving PR 274392.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isLoading):
(WebKit):

  • Api/WebPage.h:
8:23 PM Changeset in webkit [139581] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit/efl

[EFL] Unreviewed build fix after r139541
​https://bugs.webkit.org/show_bug.cgi?id=106749

undefined reference to `JSC::JSCell::methodTable() const'

Patch by KwangYong Choi <​ky0.choi@samsung.com> on 2013-01-13

  • ewk/ewk_js.cpp:
  • ewk/ewk_view.cpp:
7:32 PM Changeset in webkit [139580] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make "gardeners" an alias for "sheriffs" in sherrifbot
​https://bugs.webkit.org/show_bug.cgi?id=106627

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/tool/bot/irc_command.py:
6:22 PM Changeset in webkit [139579] by dpranke@chromium.org
  • 2 edits in trunk/Tools

[chromium] webkitpy-test: executive.py stringify_args error on the release test bot
​https://bugs.webkit.org/show_bug.cgi?id=105380

Reviewed by Eric Seidel.

Fix a regression introduced in r137692 where we were double-encoding
the arguments to popen(); this was only an issue on windows, where
we would try to encode something to mbcs, then try to encode it
to unicode as if the input as ascii.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.run_command):

6:18 PM Changeset in webkit [139578] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

State who told sheriffbot to roll the Chromium deps and to what revision
​https://bugs.webkit.org/show_bug.cgi?id=106626

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_roll_chromium_deps):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_chromium_deps_roll):

  • Scripts/webkitpy/tool/commands/roll.py:

(RollChromiumDEPS._prepare_state):
(PostChromiumDEPSRoll):
(PostChromiumDEPSRoll._prepare_state):

  • Scripts/webkitpy/tool/commands/roll_unittest.py:

(PostRollCommandsTest.test_prepare_state):

  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:

(PrepareChangeLogForDEPSRoll.run):

4:57 PM Changeset in webkit [139577] by kerz@chromium.org
  • 6 edits
    1 copy in branches/chromium/1364

Merge 139282

Make caret repainting container-aware
​https://bugs.webkit.org/show_bug.cgi?id=103955

Patch by Tien-Ren Chen <​trchen@chromium.org> on 2013-01-09
Reviewed by Simon Fraser.

Source/WebCore:

Only invalidate local rects on the caret's repaint container,
instead of invalidating an absolute rect on the whole view.

Test: fast/repaint/caret-with-transformation.html

  • editing/FrameSelection.cpp:

(WebCore::caretRendersInsideNode):
(WebCore::caretRenderer):
(WebCore::FrameSelection::caretRenderer):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::FrameSelection::recomputeCaretRect):
(WebCore::CaretBase::invalidateCaretRect):
(WebCore::FrameSelection::focusedOrActiveStateChanged):

  • editing/FrameSelection.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

  • rendering/RenderView.h:

LayoutTests:

The caret repaint padding has been removed. Needs rebaseline.
Added test that carets should be repainted correctly on a transformed element.

  • fast/repaint/caret-with-transformation.html: Added.
  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11886010

4:52 PM Changeset in webkit [139576] by kerz@chromium.org
  • 3 edits
    2 copies in branches/chromium/1364

Merge 138902

MediaControls::show() should make controls opaque
​https://bugs.webkit.org/show_bug.cgi?id=106034

Patch by Min Qin <​qinmin@chromium.org> on 2013-01-05
Reviewed by Eric Carlson.

Source/WebCore:

When a video enters fullscreen, webkit starts a timer to make the control transparent when the timer expires.
If the user exits fullscreen while the timer expires, webkit will call mediaControls::show().
However, show() actually displays nothing as the control is transparent.
The user had to move his mouse outside the video rect and move it back in order to show the controls.
Simply clicking/moving the mouse inside the video rect will not make the control opaque.
Test: media/video-controls-visible-exiting-fullscreen.html

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::show):

LayoutTests:

Add tests to check that video controls are shown when exiting from fullscreen.

  • media/video-controls-visible-exiting-fullscreen-expected.txt: Added.
  • media/video-controls-visible-exiting-fullscreen.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/11875012

4:29 PM Changeset in webkit [139575] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Alan Cutter as contributor
​https://bugs.webkit.org/show_bug.cgi?id=106747

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-01-13
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/config/committers.py:
4:16 PM Changeset in webkit [139574] by noel.gordon@gmail.com
  • 2 edits
    3 copies
    2 adds in trunk/LayoutTests

[chromium] Optimize svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux and win

Unreviewed w/end gardening.

  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-linux-x86/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
  • platform/chromium-win-xp/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
1:48 PM Changeset in webkit [139573] by leviw@chromium.org
  • 7 edits
    2 deletes in trunk

Source/WebCore: Unreviewed gardening. Rolling out r139537. It broke platforms without sub-pixel layout.

  • dom/Element.cpp:

(WebCore::Element::offsetWidth):
(WebCore::Element::offsetHeight):
(WebCore::Element::clientWidth):
(WebCore::Element::clientHeight):

  • rendering/RenderObject.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

  • rendering/style/RenderStyle.h:

(WebCore::adjustLayoutUnitForAbsoluteZoom):

LayoutTests: Unreviewed gardening. Rolling out 139537. It broke platforms not using sub-
pixel layout.

  • fast/images/zoomed-offset-size.html: Removed.
  • fast/images/zoomed-offset-size-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/qt/TestExpectations
1:00 PM Changeset in webkit [139572] by Lucas Forschler
  • 4 edits in branches/safari-536.28-branch/Source

Versioning.

12:54 PM Changeset in webkit [139571] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.9

New Tag.

9:18 AM Changeset in webkit [139570] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Fix CONFIG missing link_pkgconfig on Windows
​https://bugs.webkit.org/show_bug.cgi?id=106647

Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
properly on Windows because they are added to PKGCONFIG but
CONFIG does not contain link_pkgconfig.

This is because link_pkgconfig is added in unix/default_pre.prf
which is only used for UNIX platforms. To fix this, move it to
the general default_pre.prf.

Patch by Jonathan Liu <​net147@gmail.com> on 2013-01-13
Reviewed by Simon Hausmann.

  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
7:24 AM Changeset in webkit [139569] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on linux

Unreviewed w/end gardening.

  • platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium/TestExpectations:
6:39 AM Changeset in webkit [139568] by noel.gordon@gmail.com
  • 3 edits in trunk/LayoutTests

[chromium] Rebaseline svg/W3C-SVG-1.1/animate-elem-80-t.svg on win

Unreviewed w/end gardening.

  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
  • platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
5:13 AM Changeset in webkit [139567] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark 2 tests as failing on EFL port due to a regression in
r139537. Those tests started failing on GTK and Qt as well.

  • platform/efl/TestExpectations:
4:56 AM Changeset in webkit [139566] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark accessibility/heading-level.html as failing on EFL port.
This test was added in r139534.

  • platform/efl-wk2/TestExpectations:
4:49 AM Changeset in webkit [139565] by Christophe Dumez
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform-specific baseline for fast/dom/HTMLTemplateElement/inertContents.html.
Our port and WKTR do not display the failing URL if it is null.

  • platform/efl/fast/dom/HTMLTemplateElement/inertContents-expected.txt: Added.
4:39 AM Changeset in webkit [139564] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark inspector/debugger/debugger-script-preprocessor.html as
flakey on EFL port since it gives a different output for
every run. This test was added in r139405.

  • platform/efl/TestExpectations:
4:27 AM Changeset in webkit [139563] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark media/video-controls-captions.html as failing on EFL port
due to additional checks added in r139547.

  • platform/efl/TestExpectations:
4:25 AM Changeset in webkit [139562] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Styling disappears from the cue that's being styled by ::cue pseudo element
​https://bugs.webkit.org/show_bug.cgi?id=106723

Patch by Dima Gorbik <​dgorbik@apple.com> on 2013-01-13
Reviewed by Antti Koivisto.

Source/WebCore:

Fixes a regression caused by r138966. Setting a pseudoId in TextTrackCue::updateDisplayTree for m_allDocumentNodes
was triggering recalculating styles the next run loop. Now when this was removed we append the WebVTT tree after its children have
been marked by markFutureAndPastNodes so that correct styles are set within this append call.

Test: media/track/track-css-cue-lifetime.html

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::markFutureAndPastNodes): changing the type of the first argument because DocumentFragment is not a subclass
of Element.
(WebCore::TextTrackCue::updateDisplayTree): appending the WebVTT rendering tree after its children have been marked properly.

  • html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

  • media/track/captions-webvtt/styling-lifetime.vtt: Added.
  • media/track/track-css-cue-lifetime-expected.txt: Added.
  • media/track/track-css-cue-lifetime.html: Added.
1:46 AM Changeset in webkit [139561] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, skip new failing tests to paint the bots green.

  • platform/qt/TestExpectations:
Note: See TracTimeline for information about the timeline view.