Timeline
Jan 17, 2013:
- 11:14 PM Changeset in webkit [140103] by
-
- 3 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::LiveNodeListBase::invalidateCache
https://bugs.webkit.org/show_bug.cgi?id=106958
Reviewed by Ryosuke Niwa.
Need to update node lists that nodes in shadow dom trees have
when document is changed.
No new tests; it is difficult to reproduce crash by using
DumpRenderTree. Manually tested by using attached repro.html.
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::adoptTreeScope):
Added to adopt node lists when tree scope is changed.
(WebCore::NodeListsNodeData::adoptDocument):
Renamed the original adoptTreeScope to adoptDocument.
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
If document scope is not changed, modify to invoke adoptTreeScope.
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
Modify to invoked adoptDocument.
- 9:11 PM Changeset in webkit [140102] by
-
- 2 edits in trunk/Source/WebCore
Search for a selected word should trigger _performSearch to populate
search results
https://bugs.webkit.org/show_bug.cgi?id=106423
Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2013-01-17
Reviewed by Pavel Feldman.
No new tests as this is a UI related change.
- inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.showSearchField):
- 9:07 PM Changeset in webkit [140101] by
-
- 3 edits4 adds in trunk
Ensure the parser adopts foster-parented children into the document of their parent.
https://bugs.webkit.org/show_bug.cgi?id=107023
Reviewed by Adam Barth.
Source/WebCore:
Tests: fast/parser/foster-parent-adopted.html
fast/parser/foster-parent-adopted2.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::fosterParent):
LayoutTests:
This patch adopts the child into the parent's document after foster parenting to prevent a child from ending up in the tree with the wrong document.
- fast/parser/foster-parent-adopted-expected.txt: Added.
- fast/parser/foster-parent-adopted.html: Added.
- fast/parser/foster-parent-adopted2-expected.txt: Added.
- fast/parser/foster-parent-adopted2.html: Added.
- 8:41 PM Changeset in webkit [140100] by
-
- 2 edits in trunk/Tools
[BlackBerry] DRT - Accept http/file URL when running drt-launcher from command line
https://bugs.webkit.org/show_bug.cgi?id=107107
PR 282192
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-01-17
Reviewed by Rob Buis.
The DRT application will convert relative/absolute file path to
file://<real-file-path> format, so we only check for http/file prefix.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::isFullUrl):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
- 8:03 PM Changeset in webkit [140099] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Conditionalize usage of env_idb.h to fix build for non-Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=107182
No new tests. This is a build fix.
- platform/leveldb/LevelDBDatabase.cpp: Use the default environment for non-Chromium
ports instead of the Chromium-specific one provided by env_idb.h.
- 8:01 PM Changeset in webkit [140098] by
-
- 2 edits in trunk/Source/WebCore
Update GraphicsContext to support winding rule in clip operator for Chromium
https://bugs.webkit.org/show_bug.cgi?id=106872
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-17
Reviewed by Dirk Schulze.
Added support for winding to clip() and canvasClip() functions.
No new tests, no change in behavior.
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clip): Call clipPath() instead with winding rule.
(WebCore::GraphicsContext::canvasClip): Honor the winding rule.
- 7:57 PM Changeset in webkit [140097] by
-
- 27 edits29 deletes in trunk
Revert r122824 for a while
https://bugs.webkit.org/show_bug.cgi?id=97867
Reviewed by Hajime Morita.
Source/WebCore:
In r122824, we have introduced ImageInnerElement for making an image element ShadowDOM-available.
However, it turned out that making a replaced-element ShadowDOM-available has a lot of difficulty.
So we would like to postpone it for a while.
Since that patch makes an image element really complicated, we would like to revert it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- css/html.css:
- html/HTMLImageElement.cpp:
(WebCore):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::createRenderer):
(WebCore::HTMLImageElement::attach):
- html/HTMLImageElement.h:
(WebCore):
(HTMLImageElement):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::HTMLImageLoader):
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::sourceURI):
(WebCore::HTMLImageLoader::notifyFinished):
- html/HTMLImageLoader.h:
(HTMLImageLoader):
- html/HTMLInputElement.h:
- html/HTMLObjectElement.h:
- html/HTMLPlugInElement.h:
(WebCore):
- html/HTMLPlugInImageElement.h:
- html/HTMLTagNames.in:
- html/HTMLVideoElement.h:
- html/shadow/ImageInnerElement.cpp: Removed.
- html/shadow/ImageInnerElement.h: Removed.
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::~ImageLoader):
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::renderImageResource):
(WebCore::ImageLoader::updatedHasPendingEvent):
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
(WebCore::ImageLoader::dispatchPendingLoadEvent):
(WebCore::ImageLoader::dispatchPendingErrorEvent):
- loader/ImageLoader.h:
(WebCore):
(ImageLoader):
(WebCore::ImageLoader::element):
- loader/ImageLoaderClient.h: Removed.
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
- rendering/RenderImage.h:
(WebCore):
(RenderImage):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
- svg/SVGImageElement.h:
(SVGImageElement):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::SVGImageLoader):
(WebCore::SVGImageLoader::dispatchLoadEvent):
(WebCore::SVGImageLoader::sourceURI):
- svg/SVGImageLoader.h:
(SVGImageLoader):
LayoutTests:
- fast/dom/shadow/select-image-with-shadow-expected.txt: Removed.
- fast/dom/shadow/select-image-with-shadow.html: Removed.
- fast/dom/shadow/shadowdom-for-image-alt-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-alt-update-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-alt-update.html: Removed.
- fast/dom/shadow/shadowdom-for-image-alt.html: Removed.
- fast/dom/shadow/shadowdom-for-image-content-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-content.html: Removed.
- fast/dom/shadow/shadowdom-for-image-dynamic-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-dynamic.html: Removed.
- fast/dom/shadow/shadowdom-for-image-event-click-expected.txt: Removed.
- fast/dom/shadow/shadowdom-for-image-event-click.html: Removed.
- fast/dom/shadow/shadowdom-for-image-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-in-shadowdom-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-in-shadowdom.html: Removed.
- fast/dom/shadow/shadowdom-for-image-map-expected.txt: Removed.
- fast/dom/shadow/shadowdom-for-image-map.html: Removed.
- fast/dom/shadow/shadowdom-for-image-style-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-style.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-multiple-shadow-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-multiple-shadow.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-pseudo-id-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-pseudo-id.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-width-and-height-expected.html: Removed.
- fast/dom/shadow/shadowdom-for-image-with-width-and-height.html: Removed.
- fast/dom/shadow/shadowdom-for-image.html: Removed.
- 7:53 PM Changeset in webkit [140096] by
-
- 2 edits in trunk/LayoutTests
Remove non-existant test from Mac's TestExpectations
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-01-17
- platform/mac/TestExpectations:
track-cue-rendering-inner-timestamps.html has been removed.
drag-and-drop-autoscroll.html was introduced in a patch that has been reverted.
- 7:46 PM Changeset in webkit [140095] by
-
- 7 edits in trunk
REGRESSION (r139444): Crashes in three accessibility tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=106922
Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-01-17
Reviewed by Chris Fleizach.
Source/WebCore:
r139444 exposed an infinite loop that was just waiting to happen.
Currently, getting the role value of an ARIA table row involves
getting the parent table via parentObjectUnignored() which in turn
can lead to the role value of the table row being checked. Moving
the roleValue() logic to determineAccessibilityRole() avoids this.
This fix, however, introduced a regression when an accessible row
was examined without having first examined the parent table for
non-ARIA tables. Now that it is safe to call parentObjectUnignored(),
the parentTable() method used for ARIA table rows can also be used
by non-ARIA table rows.
No new tests; instead unskipped the three crashing tests.
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::determineAccessibilityRole):
- accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):
LayoutTests:
- platform/gtk/TestExpectations: Unskipped the three failing tests
- 7:44 PM Changeset in webkit [140094] by
-
- 2 edits in trunk/Source/WebCore
Update GraphicsContext to support winding rule in clip operator for QT
https://bugs.webkit.org/show_bug.cgi?id=106873
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-17
Reviewed by Dirk Schulze.
Added support for winding to clip() and canvasClip() functions.
No new tests, no change in behavior.
- platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::clip): Use passed in winding rule.
(WebCore::GraphicsContext::canvasClip): Rename variable.
- 7:35 PM Changeset in webkit [140093] by
-
- 3 edits in trunk/Tools
Flakiness dashboard: Add ChromiumFYI master
https://bugs.webkit.org/show_bug.cgi?id=107180
Patch by Frank Farzan <frankf@chromium.org> on 2013-01-17
Reviewed by Ojan Vafai.
This is needed to enable Chrome Android bots
to upload results for instrumentation tests.
- TestResultServer/generate_builders_json.py:
(main):
- TestResultServer/static-dashboards/builders.jsonp:
- 7:29 PM Changeset in webkit [140092] by
-
- 3 edits in trunk/Tools
Add Chrome on Android instrumentation test types to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=106964
Patch by Frank Farzan <frankf@chromium.org> on 2013-01-17
Reviewed by Ojan Vafai.
Specifically, add these test types:
androidwebview_instrumentation_tests
chromiumtestshell_instrumentation_tests
contentshell_instrumentation_tests
Also, add ChromiumFYI to the list of masters.
- TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
- TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):
- 7:23 PM Changeset in webkit [140091] by
-
- 2 edits in trunk/Source/WebCore
Update GraphicsContext to support winding rule in clip operator for Cairo
https://bugs.webkit.org/show_bug.cgi?id=107065
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-17
Reviewed by Dirk Schulze.
Added support for winding to clip() and canvasClip() functions.
No new tests, no change in behavior.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clip): Use passed in winding rule.
(WebCore::GraphicsContext::canvasClip): Rename variable.
- 7:22 PM Changeset in webkit [140090] by
-
- 10 edits2 adds in trunk
Track subframe count to avoid traversing the tree when there's no subframes
https://bugs.webkit.org/show_bug.cgi?id=101821
Reviewed by Ojan Vafai.
Source/WebCore:
Make removeChild 9-14% faster by not walking the descendants looking for
frames when there's known to be no frames.
This is a more generalized version of the fix in Bug 101619 that only
avoided this walk when the whole document had no frames. This patch extends
it to skip traversing subtrees that have no frames by tracking the number of
frames in subtrees and then only walking those subtrees that are known to
contain frames in removeChild.
Test: fast/frames/parser-append-subframe-count.html
- dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
(WebCore::parserAppendChild):
(WebCore::parserRemoveChild):
(WebCore::parserInsertBefore):
The parser may move nodes without doing frame disconnection so we
must maintain the connected subframe count manually during these
mutations.
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::collectFrameOwners):
Renamed from collectDescendant() to better reflect what it really does.
(WebCore::ChildFrameDisconnector::disconnectCollectedFrameOwners):
Renamed from disconnect() to better reflect what it really does.
(WebCore::ChildFrameDisconnector::disconnect):
New method that does the collection of frame owners on either the root
or only it's descendants.
- dom/Node.cpp:
(WebCore::Node::connectedSubframeCount):
(WebCore::Node::incrementConnectedSubframeCount):
(WebCore::Node::decrementConnectedSubframeCount):
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::connectedSubframeCount):
(WebCore::NodeRareData::incrementConnectedSubframeCount):
(WebCore::NodeRareData::decrementConnectedSubframeCount):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setContentFrame):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
LayoutTests:
Add a test that when frames are moved around by the parser and not actually
detached we keep the subframe counters of ancestors consistent.
- fast/frames/parser-append-subframe-count-expected.txt: Added.
- fast/frames/parser-append-subframe-count.html: Added.
- 7:20 PM Changeset in webkit [140089] by
-
- 7 edits in trunk/Tools
Fixing webkitpy's SCM unit tests.
https://bugs.webkit.org/show_bug.cgi?id=106429
Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-17
Reviewed by Eric Seidel.
- Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
(SCMDetectorTest.test_detect_scm_system):
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.in_working_directory):
(Git.read_git_config):
(Git._assert_can_squash):
(Git.remote_branch_ref):
- Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(GitSVNTest.test_commit_with_message_multiple_local_commits_always_squash):
(GitTestWithMock):
(GitTestWithMock.make_scm):
(GitTestWithMock.test_create_patch):
- Scripts/webkitpy/common/system/outputcapture.py:
(OutputCapture.assert_outputs):
(OutputCaptureTestCaseBase):
- Scripts/webkitpy/test/printer.py:
(Printer.configure):
- 7:00 PM Changeset in webkit [140088] by
-
- 2 edits1 add in trunk/PerformanceTests
Unreviewed, re-land r140051.
I overzealously rolled this out; the test was intended to be
skipped, but was not skipped because of a typo in Skipped. See
<https://bugs.webkit.org/show_bug.cgi?id=107210>
- Parser/html-parser-srcdoc.html: Added.
- Skipped: Big-P Parser.
- 6:39 PM Changeset in webkit [140087] by
-
- 13 edits in trunk/Source
[WK2] Minimum layout width auto-sizing should use FrameView::enableAutoSizeMode so that it can shrink the viewport
https://bugs.webkit.org/show_bug.cgi?id=107200
<rdar://problem/12849029>
Reviewed by Simon Fraser.
Make use of FrameView's auto-size mode to allow WKView's computed intrinsic content
size to shrink below the current viewport size.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setMinimumLayoutWidth): Forward minimumLayoutWidth changes to WebPage.
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry): Remove minimumLayoutWidth argument on updateGeometry.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Enable auto-size mode on the new FrameView if needed.
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::updateGeometry): Remove minimumLayoutWidth argument.
- WebProcess/WebPage/DrawingArea.messages.in: Remove minimumLayoutWidth argument on updateGeometry.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Initialize m_minimumLayoutWidth to 0.
(WebKit::WebPage::setMinimumLayoutWidth): Keep track of minimumLayoutWidth on WebPage. Update auto-sizing state if needed.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::minimumLayoutWidth):
- WebProcess/WebPage/WebPage.messages.in: Add SetMinimumLayoutWidth.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Remove storage for m_minimumLayoutWidth. We can get it from WebPage instead.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged): Grab minimumLayoutWidth from WebPage.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Don't setSize() if auto-sizing is enabled; FrameView will do the right thing.
- WebCore.exp.in: Export FrameView::enableAutoSize(...).
- 6:33 PM Changeset in webkit [140086] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: Clean up JSValue.mm
https://bugs.webkit.org/show_bug.cgi?id=107163
Reviewed by Darin Adler.
m_context is no longer weak, so there is now a lot of dead code in in JSValue.mm, and a wasted message send
on every API call. In the head of just about every method in JSValue.mm we're doing:
JSContext *context = [self context];
if (!context)
return nil;
This is getting a retained copy of the context, which is no longer necessary now m_context is no longer weak.
We can just delete all these lines from all functions doing this, and where they were referring to the local
variable 'context', instead we can just access m_context directly.
Since we're already going to be modifying most of JSValue.mm, we'll also do the following:
1) context @property is no longer weak – the context property is declared as:
@property(readonly, weak) JSContext *context;
This is really only informative (since we're not presently synthesizing the ivar), but it is now misleading.
We should change it to:
@property(readonly, retain) JSContext *context;
2) the JSContext ivar and accessor can be automatically generated. Since we're no longer doing anything
special with m_context, we can just let the compiler handle the ivar for us. We'll delete:
JSContext *m_context;
and:
- (JSContext *)context {
return m_context;
}
and find&replace "m_context" to "_context" in JSValue.mm.
- API/APIJSValue.h:
- API/JSValue.mm:
(-[JSValue toObject]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue defineProperty:descriptor:]):
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
(-[JSValue objectForKeyedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
(-[JSValue description]):
- 6:22 PM Changeset in webkit [140085] by
-
- 2 edits in trunk/LayoutTests
[chromium] Unreviewed gardening.
This test times out on Win7 dbg half of the time:
fast/js/toString-and-valueOf-override.html
Mark it as Timeout.
- platform/chromium/TestExpectations:
- 6:20 PM Changeset in webkit [140084] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177561.
- DEPS:
- 6:16 PM Changeset in webkit [140083] by
-
- 4 edits in trunk/Tools
Flakiness dashboard assumes there must be ToT tests
https://bugs.webkit.org/show_bug.cgi?id=107155
Remove group as a default parameter, since we can't actually know
the name of a group initially. Instead, introduces
currentBuilderGroupName which returns the current builder group
if it has been explicitly set, or picks the first one available
as a default. Allows us to remove some extra code tracking this
stuff as well.
Reviewed by Ojan Vafai.
- TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(currentBuilderGroupName):
(currentBuilderGroup):
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(platformAndBuildType):
- TestResultServer/static-dashboards/loader.js:
(.):
- 6:13 PM Changeset in webkit [140082] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Broaden the failure expectations of these tests:
scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
These fail pixel tests by painting the system theme scrollbar; see
<http://bugs.webkit.org/show_bug.cgi?id=106858>
- platform/chromium/TestExpectations:
- 6:09 PM Changeset in webkit [140081] by
-
- 2 edits in trunk/Source/WebKit2
Do not track user interaction for plugins that are not snapshotted
https://bugs.webkit.org/show_bug.cgi?id=107211
<rdar://problem/12967277>
Reviewed by Dean Jackson.
When the user interacts with a snapshotted plug-in, we extend that plug-in origin's
expiration date. However, plug-ins may not be snapshotted for other reasons than the
user's initial opt-in. In this case, that plug-in's origin might be not be in the cached
table. This is an edge case that was not initially considered.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Convert the assertion to an if
check, and return early if the entry is not found in the cache table.
- 6:06 PM Changeset in webkit [140080] by
-
- 3 edits4 deletes in trunk
Unreviewed, rolling out r139402.
http://trac.webkit.org/changeset/139402
https://bugs.webkit.org/show_bug.cgi?id=107212
Perf regression on DOMDivWalk (Requested by falken_ on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
Source/WebCore:
- dom/Element.cpp:
(WebCore::Element::removedFrom):
(WebCore::Element::setIsInTopLayer):
LayoutTests:
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer-expected.html: Removed.
- fast/dom/HTMLDialogElement/removed-element-is-removed-from-top-layer.html: Removed.
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd-expected.html: Removed.
- fast/dom/HTMLDialogElement/top-layer-stacking-correct-order-remove-readd.html: Removed.
- 6:00 PM Changeset in webkit [140079] by
-
- 2 edits in trunk/Source/WebCore
BackgroundHTMLParser should go 18% faster on html-parser-srcdoc benchmark
https://bugs.webkit.org/show_bug.cgi?id=107201
Reviewed by Tony Gentilcore.
Prior to this patch, we would tokenize all the input before delivering
any tokens to the main thread. Effectively, that prevented the
background parser from running in parallel with the main thread.
This patch causes us to send tokens to the main thread periodically.
The constant in this patch is somewhat arbitrary. We'll need to tune it
later with more realistic workloads.
This patch improves the performance of the html-parser-srcdoc benchmark
by 18%. (This patch is based on Eric's work in
https://github.com/tonygentilcore/webkit/commit/072331194520c7770b5e34baefbbbba948834971.)
- html/parser/BackgroundHTMLParser.cpp:
(WebCore):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- 5:58 PM Changeset in webkit [140078] by
-
- 2 edits1 delete in trunk/PerformanceTests
Unreviewed, rolling out r140051.
http://trac.webkit.org/changeset/140051
https://bugs.webkit.org/show_bug.cgi?id=107210
html-parser-srcdoc.html failing on Chromium Linux Perf and
Chromium Mac Perf with a lot of error spew about blocked
script execution in 'about:srcdoc' (Requested by dominicc on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
- Parser/html-parser-srcdoc.html: Removed.
- Skipped:
- 5:47 PM Changeset in webkit [140077] by
-
- 2 edits in trunk/LayoutTests
[chromium] Test expectations update
https://bugs.webkit.org/show_bug.cgi?id=107209
Mark this test as crash on debug builds:
fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html
This crash seems to be caused by r140024.
- platform/chromium/TestExpectations:
- 5:35 PM Changeset in webkit [140076] by
-
- 2 edits in trunk/Source/WebKit/chromium
[chromium] Disable a unit test
https://bugs.webkit.org/show_bug.cgi?id=107206
Unreviewed. Disable a failing test due to 140025.
- tests/WebFrameTest.cpp:
- 5:34 PM Changeset in webkit [140075] by
-
- 4 edits6 adds in trunk
Top layer fails for inline elements
https://bugs.webkit.org/show_bug.cgi?id=106538
Reviewed by Hajime Morita.
Source/WebCore:
This patch makes position 'static' and 'relative' compute to
'absolute' for elements in the top layer, as mandated by the
Fullscreen spec.[1] By doing so, we also fix a crash that occurred in
RenderLayer::rebuildZOrderLists when an inline element wrapped in an
anonymous block was added to the top layer.
[1]: http://fullscreen.spec.whatwg.org/#new-stacking-layer
Tests: fast/dom/HTMLDialogElement/element-removed-from-top-layer-has-original-position.html
fast/dom/HTMLDialogElement/top-layer-position-relative.html
fast/dom/HTMLDialogElement/top-layer-position-static.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Set position 'absolute'
for an element in the top layer. Typically, absolutely positioned
elements also automatically get display 'block', but it seems we must do
that manually here. We require display 'block' to ensure the renderer is not
considered inline and consequently wrapped in an anonymous block.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::rebuildZOrderLists): Check node() so we don't
crash on, e.g., an anonymous block. We don't expect top layer
renderers to have anonymous blocks anymore, but we nevertheless
shouldn't crash if some other renderer is parented by RenderView.
LayoutTests:
- fast/dom/HTMLDialogElement/element-removed-from-top-layer-has-original-position-expected.html: Added.
- fast/dom/HTMLDialogElement/element-removed-from-top-layer-has-original-position.html: Added.
- fast/dom/HTMLDialogElement/top-layer-position-relative-expected.html: Added.
- fast/dom/HTMLDialogElement/top-layer-position-relative.html: Added.
- fast/dom/HTMLDialogElement/top-layer-position-static-expected.html: Added.
- fast/dom/HTMLDialogElement/top-layer-position-static.html: Added.
- 5:29 PM Changeset in webkit [140074] by
-
- 2 edits in trunk/LayoutTests
[chromium] Test expectations update
https://bugs.webkit.org/show_bug.cgi?id=107204
Mark this test as flaky:
fast/events/touch/multi-touch-inside-iframes.html
- platform/chromium/TestExpectations:
- 5:07 PM Changeset in webkit [140073] by
-
- 2 edits in trunk/Source/WebCore
Fix crash accessing RenderView's layer's backing when not composited
https://bugs.webkit.org/show_bug.cgi?id=107203
Reviewed by Benjamin Poulain.
The RenderView isn't always layer-backed in WebKit1, so null-check the backing.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged):
- 4:41 PM Changeset in webkit [140072] by
-
- 1 edit3 copies in branches/chromium/1312
Merge 139664
REGRESSION (r132591): Underpainting @ uofmchildrenshospital.org
https://bugs.webkit.org/show_bug.cgi?id=105861
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/repaint/overhanging-float-detach-repaint.html
The issue comes from overhanging float not contributing to their containing block's
overflow. This meant that repaint() would ignore them leading to an under-repaint.
The fix is simple: force all the overhanging floats to repaint themselves.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
LayoutTests:
- fast/repaint/overhanging-float-detach-repaint-expected.png: Added.
- fast/repaint/overhanging-float-detach-repaint-expected.txt: Added.
- fast/repaint/overhanging-float-detach-repaint.html: Added.
- 4:39 PM Changeset in webkit [140071] by
-
- 5 edits3 copies in branches/chromium/1312
Merge 139509
Restore old semantics to webkitRequestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=106697
Reviewed by James Robinson.
Source/WebCore:
Sites that use GWT <= 2.4 are buggy and rely on Date.now()-like callback values.
We'll restore that behavior to the prefixed version of webkitRequestAnimationFrame.
requestAnimationFrame will continue to follow the spec.
Test: fast/animation/request-animation-frame-prefix.html
- dom/RequestAnimationFrameCallback.h:
(RequestAnimationFrameCallback):
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::requestAnimationFrame):
(WebCore):
(WebCore::DOMWindow::webkitRequestAnimationFrame):
- page/DOMWindow.h:
(DOMWindow):
- page/DOMWindow.idl:
LayoutTests:
- fast/animation/request-animation-frame-prefix-expected.txt: Added.
- fast/animation/request-animation-frame-prefix.html: Added.
- fast/animation/script-tests/request-animation-frame-prefix.js: Added.
(busyWait):
(window.webkitRequestAnimationFrame):
TBR=simonjam@chromium.org
Review URL: https://codereview.chromium.org/12021005
- 4:35 PM Changeset in webkit [140070] by
-
- 10 edits1 add in trunk
Remove NodeListsNodeData when it's no longer needed
https://bugs.webkit.org/show_bug.cgi?id=107074
Reviewed by Darin Adler.
PerformanceTests:
Added a micro benchmark to see the benefit of removing NodeListsNodeData.
The test traverses all elements in the html5 specification page and accesses childNodes.
Don't enable this test for now since it's really a micro benchmark specifically
designed to test this patch.
- DOM/TraverseChildNodes.html: Added.
- Skipped: Don't enable newly added test by default.
- resources/results-template.html: Compare against the unscaled unit (e.g. "bytes") as
opposed to scaled units such as "K bytes".
- resources/runner.js:
(.start): Moved the code to call currentTest.setup from measureRunsPerSecondOnce so that
it'll be ran for all test types, namely of PerfTestRunner.measureTime.
(.measureRunsPerSecondOnce):
Source/WebCore:
Remove NodeListsNodeData when the last node list is removed from it.
If we detect that we have only one node list left in the data structure,
we'll simply destroy the entire "this" object to free up the memory space.
This reduced the memory usage of the micro benchmark by roughly 3%.
Performance Tests: DOM/TraverseChildNodes.html
- dom/Node.cpp:
(WebCore::Node::clearNodeLists): Added.
- dom/Node.h:
- dom/NodeRareData.h:
(WebCore::NodeListsNodeData::removeChildNodeList):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCacheWithQualifiedName):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList): Added.
Removes "this" NodeListsNodeData if there is only one node list left.
Tools:
Generalize the warning a little so that it's also ignored on PerformanceTests/DOM/TraverseChildNodes.html
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest):
- 4:22 PM Changeset in webkit [140069] by
-
- 3 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderBlock::checkFloatsInCleanLine
https://bugs.webkit.org/show_bug.cgi?id=90802
Reviewed by Julien Chaffraix.
Source/WebCore:
Test: fast/multicol/float-not-removed-crash.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildrenTo):
- When fullRemoveInsert is True, make sure to clear the
floating objects from our list (similar to positioned objects).
Our children are getting moved to another block and we won't
get notified when they are going away.
- Remove the redundant hasPositionedObjects check since it
is already done inside removePositionedObjects.
LayoutTests:
- fast/multicol/float-not-removed-crash-expected.txt: Added.
- fast/multicol/float-not-removed-crash.html: Added.
- 4:10 PM Changeset in webkit [140068] by
-
- 17 edits22 adds in trunk
Make it possible for the root background to be painted into its own GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=107177
Source/WebCore:
Reviewed by Dave Hyatt.
Make it possible to paint the root background into its own GraphicsLayer, and enable
this when the root background has background-images that are all background-attachment: fixed.
This is a step towards optimizing scrolling on pages with fixed root backgrounds.
Tests: platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html
platform/mac/tiled-drawing/fixed-background/fixed-body-background.html
platform/mac/tiled-drawing/fixed-background/fixed-html-background.html
platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html
- rendering/PaintInfo.h:
(WebCore::PaintInfo::skipRootBackground): Utility function to check the paintBehavior flag.
(WebCore::PaintInfo::paintRootBackgroundOnly): Ditto.
- rendering/PaintPhase.h: New paint behavior flags to indicate that we should skip painting
the root background, and only paint the root background.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paint): When we're only painting the root background, avoid painting column
rules, and bail early.
(WebCore::RenderBlock::paintObject): Don't paint children if we're just painting the root background.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleWillChange): If this box can paint the root background, tell the compositor
when the fixedness of those backgrounds changes.
(WebCore::RenderBox::paintRootBoxFillLayers): If the paintBehavior flag is set to skip painting the root
background, bail. This will be true for the non-background GraphicsLayers which are painting the root.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): We can bail early if we're not a root-like renderer and the
flag is set to paint the root background only. This avoids walking the whole layer tree when just painting
into the root background GraphicsLayer.
Migrate layer paint flags into PaintBehavior flags, and use them.
- rendering/RenderLayer.h: Layer painting flags that replicate the paintBehavior flags.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking): Init the m_backgroundLayerPaintsFixedRootBackground bit.
(WebCore::RenderLayerBacking::~RenderLayerBacking): Clear the background layer.
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer): No need to handle the transparent background
stuff here. We'll do it later in updateRootLayerConfiguration().
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Actually make a background layer now
if the compositor says we should.
Call updateRootLayerConfiguration() to adjust the background color and opaqueness of the background/primary layers.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Parent the m_backgroundLayer in the containment layer,
not m_graphicsLayer (this is a bug fix).
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::setBackgroundLayerPaintsFixedRootBackground):
(WebCore::RenderLayerBacking::paintingPhaseForPrimaryLayer):
(WebCore::RenderLayerBacking::updateBackgroundColor): This no longer needs to update the tile cache
background color; updateRootLayerConfiguration() does this now.
(WebCore::RenderLayerBacking::updateRootLayerConfiguration): Update the opaqueness and background color
of the background and/or main graphics layers.
(WebCore::RenderLayerBacking::setContentsNeedDisplay): Invalidate the background layer if we have one.
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Invalidate the background layer if we have one.
This will be optimized to only repaint the background if it was the background that changed.
(WebCore::RenderLayerBacking::paintIntoLayer): Take a GraphicsLayer, not a RenderLayer argument.
Adjust the paintFlags if we're being asked to paint the background layer, or if we have one, but are painting the foreground.
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
- rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::backgroundLayer):
(WebCore::RenderLayerBacking::backgroundLayerPaintsFixedRootBackground):
(RenderLayerBacking):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootFixedBackgroundsChanged): If we're told that the fixed-ness of
the root background changed and we're using a TileCache, we need to re-evaluate compositing (this could be
optimized to only update the root layer).
(WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer): For the root (RenderView's) layer,
check whether the renderer that will paint the root (taking background propagation into account) has
background images that are all fixed.
(WebCore::RenderLayerCompositor::fixedRootBackgroundLayer): Accessor for the GraphicsLayer that paints
the root background (will be used later).
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hasEntirelyFixedBackground): Returns true there are background images
and all are fixed.
- rendering/RenderObject.h:
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations): This function paints a solid color if we know that the root
isn't going to fill the viewport; we want to avoid this painting if we're not painting the root background
in this pass.
- rendering/style/RenderStyle.cpp:
(WebCore::allLayersAreFixed):
(WebCore::RenderStyle::hasEntirelyFixedBackground): New helper function.
- rendering/style/RenderStyle.h:
LayoutTests:
Reviewed by Dave Hyatt.
New tests with results for a fixed root background layer when using tiled drawing.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-body-layer.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-opacity-html.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-transformed-html.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background-zoomed.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-body-background.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-html-background.html: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.png: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt: Added.
- platform/mac/tiled-drawing/fixed-background/fixed-non-propagated-body-background.html: Added.
- 4:10 PM Changeset in webkit [140067] by
-
- 2 edits in trunk/Tools
Ref test images are upside-down in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=105457
Reviewed by Sam "Speedy" Weinig.
The bitmap context created in TestInvocation::dumpPixelsAndCompareWithExpected()
from the window snapshot contained a flipped copy of the image, causing all ref
and pixel images to be upside-down.
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- 4:10 PM Changeset in webkit [140066] by
-
- 2 edits in trunk/Source/WebCore
Allow PaintInfo to carry all PaintBehavior flags
https://bugs.webkit.org/show_bug.cgi?id=106980
Reviewed by Beth Dakin.
In r139908 I missed one instance of the PaintInfo constructor that should take PaintBehaviorNormal
instead of "false".
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
- 4:08 PM Changeset in webkit [140065] by
-
- 2 edits in trunk/LayoutTests
[chromium] Test expectations update
Unreviewed build fix. Update test expectations to reflect crashing tests:
http/tests/appcache/fail-on-update.html
http/tests/appcache/fail-on-update-2.html
- platform/chromium/TestExpectations:
- 4:06 PM Changeset in webkit [140064] by
-
- 2 edits in trunk/Source/WebCore
[Template] Avoid reading beyond the end of the buffer in preload scanner when check for </template>
https://bugs.webkit.org/show_bug.cgi?id=107143
Reviewed by Adam Barth.
This patch corrects to use AtomicString constructor which takes an explicit size. Additionally, the logic
for exiting early is slightly improved.
No new tests.
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::PreloadTask::PreloadTask):
(WebCore::HTMLPreloadScanner::processToken):
- 4:04 PM Changeset in webkit [140063] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Match initializing members in GraphicsLayerTransform to initializing members in GraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=107090
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-17
Reviewed by Noam Rosenthal.
GraphicsLayer initializes m_anchorPoint to FloatPoint3D(0.5, 0.5, 0) and
m_preserves3D to false, while GraphicsLayerTransform initializes m_anchorPoint
to FloatPoint3D(0, 0, 0) and m_flattening (= !m_preserves3D) to false. It is a
potential bug. This patch corrects initialization of GraphicsLayerTransform.
Covered by existing compositing pixel tests.
- platform/graphics/GraphicsLayerTransform.cpp:
(WebCore::GraphicsLayerTransform::GraphicsLayerTransform):
- 3:52 PM Changeset in webkit [140062] by
-
- 2 edits in trunk/Source/WebCore
ScriptDebugServer::didExecuteProgram should not try to pop stack if there is no stack to pop
https://bugs.webkit.org/show_bug.cgi?id=107186
Reviewed by Geoffrey Garen.
No new tests, because I'm not sure how to test this. I can repro it on a gnarly web site,
but I don't know how to create a reduced case that triggers it.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::didExecuteProgram):
- 3:49 PM Changeset in webkit [140061] by
-
- 2 edits in tags/Safari-537.26.1/Source/WebCore
Merged r139927. <rdar://problem/12979104>
- 3:25 PM Changeset in webkit [140060] by
-
- 1 edit in trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
Build fix. Bad merge.
- 3:23 PM Changeset in webkit [140059] by
-
- 2 edits in trunk/Source/WebCore
[GTK] IndexedDB: Add LevelDB headers to include path if IndexedDB is enabled
https://bugs.webkit.org/show_bug.cgi?id=107181
Patch by Michael Pruett <michael@68k.org> on 2013-01-17
Reviewed by Martin Robinson.
No new tests as this is just a build change.
- GNUmakefile.am:
- 3:21 PM Changeset in webkit [140058] by
-
- 2 edits in trunk/Source/WebCore
The threaded html parser hangs when parsing empty documents (and about:blank)
https://bugs.webkit.org/show_bug.cgi?id=107160
Reviewed by Tony Gentilcore.
This is covered by many existing tests including the html5lib suite.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::finish):
- 3:17 PM Changeset in webkit [140057] by
-
- 3 edits2 adds in trunk
imageSmoothingEnabled frequent, unpredictable crashes
https://bugs.webkit.org/show_bug.cgi?id=107161
Patch by Alexis Hetu <sugoi@chromium.org> on 2013-01-17
Reviewed by Stephen White.
Source/WebCore:
Added a NULL pointer check to fix a crash.
Test: fast/canvas/canvas-imageSmoothingEnabled-zero-size.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
LayoutTests:
Added a layout test for setting image smoothing enabled on a 0 sized
canvas.
- fast/canvas/canvas-imageSmoothingEnabled-zero-size-expected.txt: Added.
- fast/canvas/canvas-imageSmoothingEnabled-zero-size.html: Added.
- 3:08 PM Changeset in webkit [140056] by
-
- 5 edits2 deletes in trunk
Unreviewed, rolling out r140049.
http://trac.webkit.org/changeset/140049
https://bugs.webkit.org/show_bug.cgi?id=107187
Breaks lots of stuff (Requested by schenney on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
Source/WebCore:
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::setPreserveAspectRatioString):
(WebCore):
(WebCore::SVGViewSpec::viewTarget):
(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):
- svg/SVGViewSpec.h:
(SVGViewSpec):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
- svg/SVGViewSpec.idl:
LayoutTests:
- svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Removed.
- svg/dom/SVGViewSpec-invalid-ref-crash.html: Removed.
- 3:06 PM Changeset in webkit [140055] by
-
- 4 edits in trunk/Source/WebCore
Threaded parser hangs when encountering an unmatched </script> tag
https://bugs.webkit.org/show_bug.cgi?id=107170
Reviewed by Adam Barth.
The bug was that the BackgroundHTMLParser naively yields to the
main thread every time it encounters a </script>
(as we may have to run script on the main thread). However, not every
</script> results in script execution, so the main thread needs to know
how to tell the BackgroundHTMLParser to continue in cases where no
script execution is needed.
This whole infrastructure will be replaced when we let the BackgroundHTMLParser
continue speculatively tokenizing after yielding.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::TokenDelivery::TokenDelivery):
(TokenDelivery):
(WebCore::TokenDelivery::execute):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didReceiveTokensFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- 3:02 PM Changeset in webkit [140054] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r139516): NetworkResourceLoadScheduler::receivedRedirect is not called.
Rubber-stamped by Brady Eidson.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::willSendRequest): Reverted a small part of r139516.
- 2:55 PM Changeset in webkit [140053] by
-
- 2 edits in trunk/Source/WebKit2
Coordinated Graphics: Remove redundant behaviors in LayerTreeRenderer.
https://bugs.webkit.org/show_bug.cgi?id=107084
Patch by Huang Dongsung <luxtella@company100.net> on 2013-01-17
Reviewed by Noam Rosenthal.
There are two changes.
- It is redundant to call GraphicsLayer::removeFromParent() or
GraphicsLayer::removeAllChildren() before deleting GraphicsLayer, because the
destructor of GraphicsLayerTextureMapper removes a parent and all children.
- LayerTreeRenderer::setRootLayerID() does not need to remove all children of
rootLayer because this method can be called only once.
- UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::purgeGLResources):
- 2:54 PM Changeset in webkit [140052] by
-
- 1 edit in trunk/Source/WebKit2/Shared/WebPreferencesStore.h
Fix build.
- 2:53 PM Changeset in webkit [140051] by
-
- 2 edits1 add in trunk/PerformanceTests
Add a version of the html-parser benchmark which uses srcdoc instead of document.write so it tests the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=107158
Reviewed by Ryosuke Niwa.
Currently this test even opts-in to the threaded parser if available.
We'll remove that line when the threaded parser becomes default or goes away.
- Parser/html-parser-srcdoc.html: Added.
- 2:52 PM Changeset in webkit [140050] by
-
- 2 edits in trunk/Source/WebCore
Stop the background parser when canceling parsing to avoid crashing on many layout tests
https://bugs.webkit.org/show_bug.cgi?id=107159
Reviewed by Adam Barth.
Covered by many existing tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::stopParsing):
- 2:51 PM Changeset in webkit [140049] by
-
- 5 edits2 adds in trunk
SVGViewSpec fails when corresponding element has been removed
https://bugs.webkit.org/show_bug.cgi?id=106957
Reviewed by Dirk Schulze.
Source/WebCore:
When JS holds an SVGViewSpec object while deleting the object that
defines the spec (an SVGSVGElement, or one of a few others) the
pointer to the target is cleared in the SVGViewSpec but the methods
that serve JS queries do not check and try to access the now null
target. This atch fixes the prooblem, throwing JS exceptions where
possible and returning null where necessary.
Test: svg/dom/SVGViewSpec-invalid-ref-crash.html
- svg/SVGViewSpec.cpp:
(WebCore):
(WebCore::SVGViewSpec::viewTarget): Check for null target and throw an exception.
(WebCore::SVGViewSpec::transform): Check for null target and return
null. It is not possible to throw an exception here because it leads
to an invalid cast in the code generated from IDLs.
(WebCore::SVGViewSpec::viewBoxAnimated): Check for null target and throw an exception.
(WebCore::SVGViewSpec::preserveAspectRatioAnimated): Check for null target and throw an exception.
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper): ASSERT non-null target
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper): ASSERT non-null target
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper): ASSERT non-null target
- svg/SVGViewSpec.h:
(SVGViewSpec): Add Exception arguments to getter methods.
- svg/SVGViewSpec.idl: Mark attributes as throwing exceptions.
LayoutTests:
Test for the situation in which the target of an SVGViewSpec is
removed while the view spec lives on in JS.
- svg/dom/SVGViewSpec-invalid-ref-crash-expected.txt: Added.
- svg/dom/SVGViewSpec-invalid-ref-crash.html: Added.
- 2:46 PM Changeset in webkit [140048] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Remove unnecessary call to IDBDatabaseBackendInterface::metadata()
https://bugs.webkit.org/show_bug.cgi?id=107142
Reviewed by Kentaro Hara.
This call isn't necessary, and probably slipped through an earlier review
because of the mention of 'm_metadata'.
No new tests, as this code has no side effects and all tests sill pass.
- Modules/indexeddb/IDBIndex.cpp:
(WebCore::IDBIndex::count):
- 2:41 PM Changeset in webkit [140047] by
-
- 6 edits in trunk/Source/WebCore
Table layout does not need to explicitly call computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=106931
Reviewed by Julien Chaffraix.
Code shouldn't need to explicitly call computePreferredLogicalWidths.
It should only get called as a by-product of calling minPreferredLogicalWidth
or maxPreferredLogicalWidth.
Instead, make it clear that the calling code is just trying to clear
preferred width dirty bits.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
The computePreferredLogicalWidths call on the table cell is redundant
with the minPreferredLogicalWidth call on the next line.
- rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::calcWidthArray):
We only need to clear the dirty bit here. Table cells don't use
their preferred widths in fixed table layout calculations.
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits):
- rendering/RenderTableCol.h:
- 2:38 PM Changeset in webkit [140046] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] InRegionScroller should notify client before it deletes all the scrollables
https://bugs.webkit.org/show_bug.cgi?id=107162
Reviewed by Rob Buis.
Internally reviewed by Gen Mak and Mike Fenton.
Move the notification code from notifyInRegionScrollStopped() to reset() as there are
other places where reset() gets called.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::reset):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped):
- 2:35 PM Changeset in webkit [140045] by
-
- 4 edits4 adds in trunk
[CSS Grid Layout] Updating -webkit-grid-rows or -webkit-grid-columns doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=107062
Reviewed by Tony Chang.
Source/WebCore:
Tests: fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html
fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html
This change makes -webkit-grid-rows and -webkit-grid-columns dynamic change properly
relayout their children, thus making them work!
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutGridItems):
Fixed the logic to force a grid item relayout if the grid area size changes. This is the
safest approach as margins or paddings can also be a percent of the grid area's size.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
Fixed a dumb mistake.
LayoutTests:
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update-expected.txt: Added.
- fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html: Added.
- fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update-expected.txt: Added.
- fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html: Added.
- 2:32 PM Changeset in webkit [140044] by
-
- 9 edits in trunk/Source
Make logging console messages to STDOUT work in WebKit2 via a new setting.
https://bugs.webkit.org/show_bug.cgi?id=107157
Reviewed by Joseph Pecoraro.
Source/WebCore:
- page/Console.cpp:
(WebCore::Console::addMessage): Check logsPageMessagesToSystemConsoleEnabled().
(WebCore::internalAddMessage): Ditto. Refactored to return early and drop printExceptions argument.
(WebCore::Console::error): Removed call to shouldPrintExceptions().
(WebCore::Console::log): Ditto.
(WebCore::Console::warn): Ditto.
(WebCore::Console::dir): Ditto.
(WebCore::Console::dirxml): Ditto.
(WebCore::Console::clear): Ditto.
(WebCore::Console::trace): Ditto.
(WebCore::Console::assertCondition): Ditto.
- page/Settings.in: Added logsPageMessagesToSystemConsoleEnabled.
Source/WebKit2:
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLogsPageMessagesToSystemConsoleEnabled): Added.
(WKPreferencesGetLogsPageMessagesToSystemConsoleEnabled): Added.
- UIProcess/API/C/WKPreferencesPrivate.h:
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Enable logging in debug builds.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set new setting in WebCore.
- 2:31 PM Changeset in webkit [140043] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix selection handle appearance for RTL text.
https://bugs.webkit.org/show_bug.cgi?id=107043
Reviewed by Rob Buis.
PR 263585.
Invert the reported selection handle position if to match
the visual order instead of the logical order to create the
desired appearance for RTL text and directional selections.
Reviewed Internally by Gen Mak and Nima Ghanavatian.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 2:28 PM Changeset in webkit [140042] by
-
- 2 edits in branches/chromium/1312/Source/WebCore
Manual merge of bugfix from trunk in r133903
- 2:23 PM Changeset in webkit [140041] by
-
- 2 edits in trunk/LayoutTests
[chromium] Fix layout test expectations.
Not reviewed. Update layout test expectations.
http/tests/appcache/fail-on-update.html is crashing, mark it so.
- platform/chromium/TestExpectations:
- 2:17 PM Changeset in webkit [140040] by
-
- 2 edits in trunk/Source/WTF
Teach Functional.h about WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=107105
Reviewed by Anders Carlsson.
A common pattern in cross-thread communication is to call member
functions of an object on a remote thread. If the caller's reference to
the object on the remote thread is a WeakPtr, the caller usually wants
to validate that the object still exists when the call actually takes
place.
It's possible to do this manually for every cross-thread call, but that
is tiresome and error prone. Instead, we can teach bind to validate
WeakPtr arguments when passed as the "this" parameter to a member
function.
- wtf/Functional.h:
(WTF::ParamStorageTraits::validate):
- 2:06 PM Changeset in webkit [140039] by
-
- 101 edits in trunk/Source
Unreviewed, rolling out r140023.
http://trac.webkit.org/changeset/140023
https://bugs.webkit.org/show_bug.cgi?id=107176
Broke some tests (Requested by anttik on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
Source/WebCore:
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createReplacementRunIn):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
- rendering/RenderDeprecatedFlexibleBox.h:
(RenderDeprecatedFlexibleBox):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
- rendering/RenderDetailsMarker.h:
(RenderDetailsMarker):
- rendering/RenderDialog.h:
(WebCore::RenderDialog::RenderDialog):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::RenderFieldset):
- rendering/RenderFieldset.h:
(RenderFieldset):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.cpp:
(RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
(RenderFullScreen::RenderFullScreen):
(RenderFullScreen::wrapRenderer):
- rendering/RenderFullScreen.h:
(RenderFullScreen):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
- rendering/RenderGrid.h:
(RenderGrid):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::addChildIgnoringContinuation):
- rendering/RenderInline.h:
(RenderInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
(WebCore::RenderLayer::createReflection):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
(WebCore::RenderListItem::styleDidChange):
- rendering/RenderListItem.h:
(RenderListItem):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::RenderListMarker):
- rendering/RenderListMarker.h:
(RenderListMarker):
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):
- rendering/RenderMediaControlElements.h:
(RenderMediaVolumeSliderContainer):
(RenderMediaControlTimeDisplay):
(RenderTextTrackContainerElement):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h:
(WebCore::RenderObject::setIsAnonymous):
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(RenderRegion):
- rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::RenderRegionSet):
- rendering/RenderRegionSet.h:
(RenderRegionSet):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
- rendering/RenderReplica.h:
(RenderReplica):
- rendering/RenderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
- rendering/RenderRuby.h:
(RenderRubyAsInline):
(RenderRubyAsBlock):
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
- rendering/RenderRubyBase.h:
(RenderRubyBase):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
- rendering/RenderRubyRun.h:
(RenderRubyRun):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
- rendering/RenderRubyText.h:
(RenderRubyText):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::createAnonymousWithParentRenderer):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
- rendering/RenderTableCaption.h:
(RenderTableCaption):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::createAnonymousWithParentRenderer):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
- rendering/RenderTableCol.h:
(RenderTableCol):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
(WebCore::RenderTableRow::createAnonymousWithParentRenderer):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::createAnonymousWithParentRenderer):
- rendering/RenderTableSection.h:
(RenderTableSection):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
- rendering/RenderTextControl.h:
(RenderTextControl):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
- rendering/RenderWidget.h:
(RenderWidget):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
- rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createRenderer):
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::RenderSVGBlock):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGTSpan.cpp:
(WebCore::RenderSVGTSpan::RenderSVGTSpan):
- rendering/svg/RenderSVGTSpan.h:
(RenderSVGTSpan):
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
- rendering/svg/RenderSVGTextPath.h:
(RenderSVGTextPath):
Source/WebKit/chromium:
- tests/RenderTableCellTest.cpp:
- tests/RenderTableRowTest.cpp:
- 1:55 PM Changeset in webkit [140038] by
-
- 7 edits in trunk/Source/WebKit2
Each NetworkConnectionToWebProcess should keep its own map of NetworkResourceLoaders
https://bugs.webkit.org/show_bug.cgi?id=107166
Reviewed by Alexey Proskuryakov.
NetworkConnectionToWebProcess now keeps its own id->loader map so it can directly address them as needed:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::~NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::removeLoadIdentifier):
- NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkResourceLoadScheduler no longer keeps an identifier -> loader map:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleResourceLoad):
(WebKit::NetworkResourceLoadScheduler::removeLoadIdentifier):
- NetworkProcess/NetworkResourceLoadScheduler.h:
There is no longer such a thing as NetworkConnectionToWebProcessObserver:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::connectionToWebProcessDidClose):
- NetworkProcess/NetworkResourceLoader.h:
- 1:50 PM Changeset in webkit [140037] by
-
- 4 edits in trunk/Source/WebCore
Fix a logic error in AuthenticationChallengeMac
https://bugs.webkit.org/show_bug.cgi?id=107164
Reviewed by Brady Eidson.
No new tests, as this is not currently observable.
- platform/network/cf/AuthenticationCF.cpp: (WebCore::createCF): Added a FIXME about making this more like Mac counterpart.
- platform/network/cf/AuthenticationChallenge.h: (AuthenticationChallenge): Corrected an slightly misleading explanation.
- platform/network/mac/AuthenticationMac.mm: (WebCore::AuthenticationChallenge::setAuthenticationClient): Don't create a dummy m_nsChallenge object in place of a nil one.
- 1:37 PM Changeset in webkit [140036] by
-
- 11 edits in trunk/Source/WebCore
Remove unused finishWasCalled() method
https://bugs.webkit.org/show_bug.cgi?id=107148
Reviewed by Eric Seidel.
Based on patch by Eric Seidel.
No new tests because no new functionality.
- dom/DocumentParser.h:
(DocumentParser):
- dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::append):
- html/parser/HTMLDocumentParser.cpp:
- html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
- html/parser/HTMLViewSourceParser.cpp:
- html/parser/HTMLViewSourceParser.h:
(HTMLViewSourceParser):
- xml/parser/NewXMLDocumentParser.cpp:
(WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
(WebCore::NewXMLDocumentParser::finish):
- xml/parser/NewXMLDocumentParser.h:
(NewXMLDocumentParser):
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
- 1:23 PM Changeset in webkit [140035] by
-
- 3 edits in trunk/Source/WebKit/chromium
[chromium] Double-tap zoom should take into account accessibility fontScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=107123
Patch by John Mellor <johnme@chromium.org> on 2013-01-17
Reviewed by Adam Barth.
Platforms which support Text Autosizing (currently just Chrome for
Android) may provide a textAutosizingFontScaleFactor (defaults to 1.0).
This value is intended to be chosen by the user to indicate how large
they want text to appear, for example Chrome for Android has a "Text
scaling" slider in Settings > Accessibility that lets you choose a value
in the range 50% - 200% (defaults to 100%*).
For text in wide columns that typically gets autosized, this value is
applied by multiplying the textAutosizingMultiplier computed for each
cluster by the textAutosizingFontScaleFactor. Double-tap zoom will fit
the column to the screen (ignoring the textAutosizingFontScaleFactor)
since the column is wide. This part already works.
For text in narrow columns that doesn't get autosized, the
textAutosizingFontScaleFactor is not applied through Text Autosizing,
and instead needs to be applied by adjusting the double-tap zoom level.
When double-tapping on narrow columns, instead of fitting the column to
the screen (which would often zoom in excessively far), the existing
logic in computeScaleAndScrollForHitRect applies a maximum zoom level
called the legibleScale. This value needs to be multiplied by the
textAutosizingFontScaleFactor, so that we zoom in proportionately
further on non-autosized narrow columns, hence the effective text size
(taking into account zoom) will have increased in proportion to the
textAutosizingFontScaleFactor as expected.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
Multiplies legibleScale (the maximum zoom level) by the
textAutosizingFontScaleFactor.
- tests/WebFrameTest.cpp:
Added WebFrameTest.DivAutoZoomScaleFontScaleFactorTest based on
WebFrameTest.DivAutoZoomScaleBoundsTest to test the interaction
between textAutosizingFontScaleFactor and the double-tap zoom logic.
Also did minor cleanup to WebFrameTest.DivAutoZoomScaleBoundsTest.
- 1:11 PM Changeset in webkit [140034] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
[chromium] Layout test rebaselines.
Not reviewed. Rebaselines to fix build.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- 1:08 PM Changeset in webkit [140033] by
-
- 2 edits in trunk/Source/WebKit2
Remove an incorrect ASSERT() after r140002.
Reviewed by Simon Fraser.
setRootCompositingLayer(null) is valid now.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 12:55 PM Changeset in webkit [140032] by
-
- 5 edits in trunk/Source/WebCore
MathML padding overrides only need to be on RenderMathMLRoot
https://bugs.webkit.org/show_bug.cgi?id=107151
Reviewed by Tony Chang.
RenderMathMLRoot is the only class that uses these.
No need for them to be on the generic MathML superclass.
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::RenderMathMLRoot):
(WebCore::RenderMathMLRoot::paddingTop):
(WebCore::RenderMathMLRoot::paddingBottom):
(WebCore::RenderMathMLRoot::paddingLeft):
(WebCore::RenderMathMLRoot::paddingRight):
(WebCore::RenderMathMLRoot::paddingBefore):
(WebCore::RenderMathMLRoot::paddingAfter):
(WebCore::RenderMathMLRoot::paddingStart):
(WebCore::RenderMathMLRoot::paddingEnd):
- rendering/mathml/RenderMathMLRoot.h:
- 12:51 PM Changeset in webkit [140031] by
-
- 4 edits in trunk/Source/JavaScriptCore
Objective-C API: Clean up JSValue
https://bugs.webkit.org/show_bug.cgi?id=107156
Reviewed by Oliver Hunt.
JSContext m_protectCounts, protect, unprotect are all now unnecessary overhead, and should all be removed.
These exist to handle the context going away before the value does; the context needs to be able to unprotect
values early. Since the value is now keeping the context alive there is no longer any danger of this happening;
instead we should just protect/unprotect the value in JSValue's init/dealloc methods.
- API/JSContext.mm:
(-[JSContext dealloc]):
- API/JSContextInternal.h:
- API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
- 12:45 PM Changeset in webkit [140030] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG Node::ref() and Node::deref() should not return bool, and should have postfixRef variants
https://bugs.webkit.org/show_bug.cgi?id=107147
Reviewed by Mark Hahnenberg.
This small refactoring will enable a world where ref() returns Node*, which is useful for
https://bugs.webkit.org/show_bug.cgi?id=106868. Also, while this refactoring does lead to
slightly less terse code, it's also slightly more self-explanatory. I could never quite
remember what the meaning of the bool return from ref() and deref() was.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::collectGarbage):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::ref):
(JSC::DFG::Graph::deref):
- dfg/DFGNode.h:
(JSC::DFG::Node::ref):
(Node):
(JSC::DFG::Node::postfixRef):
(JSC::DFG::Node::deref):
(JSC::DFG::Node::postfixDeref):
- 12:40 PM Changeset in webkit [140029] by
-
- 6 edits in trunk/Source
32-bit build for Qt5 on Mac OS fails.
https://bugs.webkit.org/show_bug.cgi?id=107094
We need to define NS_BUILD_32_LIKE_64 for 32-bit build for Mac OS.
Fixed 32-bit build detection for support Qt5.
Source/WebCore:
Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
Reviewed by Benjamin Poulain.
- Target.pri:
Source/WebKit:
Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
Reviewed by Benjamin Poulain.
- WebKit1.pro:
Source/WebKit2:
Patch by Poul Sysolyatin <psytonx@gmail.com> on 2013-01-17
Reviewed by Benjamin Poulain.
- Target.pri:
- 12:38 PM Changeset in webkit [140028] by
-
- 3 edits in trunk/LayoutTests
[Chromium] svg/custom/foreign-object-skew-expected.png differs Debug/Release on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=99138
Unreviewed test expectations update.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png: Use the Release result.
- platform/chromium/TestExpectations: Mark the test as failing, and won't fix.
- 12:37 PM Changeset in webkit [140027] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Prevent crash dereferencing null if script context has stopped
https://bugs.webkit.org/show_bug.cgi?id=107146
Reviewed by Tony Chang.
We have crash reports from Chromium users (but no local repro) for a crash coming
from IDBRequest::dispatchEvent() that looks like it's calling toV8Context() after
the script execution context has stopped. The dispatch shouldn't be occurring
and we ASSERT as such, but something weird is going on during Worker tear down.
If this patch prevents the crash it would indicate that stop() is called before
dispatchEvent() which shouldn't be happening, and would let us continue chasing
the issue.
No new tests - this shouldn't be happening.
- Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::dispatchEvent):
- 12:37 PM Changeset in webkit [140026] by
-
- 3 edits in trunk/Tools
Replaced specifiers variable with is_debug in builders.py
https://bugs.webkit.org/show_bug.cgi?id=107057
Patch by Timothy Loh <timloh@google.com> on 2013-01-17
Reviewed by Dirk Pranke.
Replaced specifiers variable with is_debug in builders.py to simplify
Bug 106259. The other specifiers are not used elsewhere in the code.
Fixed builder_name_for_port_name to return a debug builder if we don't
have a release builder.
- Scripts/webkitpy/layout_tests/port/builders.py:
(all_port_names):
(builder_name_for_port_name):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineExpectations.test_rebaseline_expectations):
- 12:26 PM Changeset in webkit [140025] by
-
- 4 edits in trunk/Source/WebKit/chromium
[chromium] Make new-style page scale work with fixed layout
https://bugs.webkit.org/show_bug.cgi?id=106951
Reviewed by Adam Barth.
This makes non-CSS-transform page scaling work with fixed-layout mode,
including viewport tag support.
- dispatchViewportPropertiesDidChange() now works entirely with DIP
pixels instead of physical pixels, and is made compatible with
separating deviceScaleFactor from pageScaleFactor.
- In this mode, the "layout viewport" size in the pinch-zoom model is
made a first-class concept separate from the device size. This
is a viewport with the same aspect ratio as the device but with the
layout width of the page. This viewport is used:
- As FrameView::visibleContentRect.
- Returned from WebView::size().
- Given to the compositor as layoutViewportSize.
- m_deviceScaleInCompositor is deleted as it's clearer to use the
applyDeviceScaleInCompositor setting directly.
- src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::size):
(WebKit):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::layoutSize):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::dipSize):
(WebKit::WebViewImpl::didChangeContentsSize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
(WebViewImpl):
- 12:20 PM Changeset in webkit [140024] by
-
- 6 edits8 adds in trunk
Nested fixed position element not staying with parent
https://bugs.webkit.org/show_bug.cgi?id=65477
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/inline/fixed-pos-moves-with-abspos-inline-parent.html
fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html
fast/inline/fixed-pos-moves-with-abspos-parent.html
fast/inline/fixed-pos-with-transform-container-moves-with-abspos-parent.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::simplifiedLayout):
If an absolute position element inside a relative positioned container moves, and the absolute element has a fixed position
child, neither the container nor the fixed element learn of the movement since posChildNeedsLayout() is only marked as far as the
relative positioned container. So if our positioned objects list can contain fixed position elements perform the
checks in markFixedPositionObjectForLayoutIfNeeded for each fixed pos object in the container's positioned object list.
(WebCore::RenderBlock::markFixedPositionObjectForLayoutIfNeeded):
For a fixed position element in the positioned objects list that has a static x or y position check for an absolute positioned ancestor
and if we find one, see if the static x or y position of the fixed pos element has changed. If it has, mark it for layout.
(WebCore):
(WebCore::RenderBlock::layoutPositionedObjects):
A fixed position element with an absolute position ancestor has no way of learning if the latter has changed position. So perform the
checks in markFixedPositionObjectForLayoutIfNeeded for each fixed pos object in the container's positioned object list.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Use new helper function canContainFixedPositionObjects().
- rendering/RenderObject.h:
(WebCore::RenderObject::canContainFixedPositionObjects):
(RenderObject):
LayoutTests:
- fast/inline/fixed-pos-moves-with-abspos-inline-parent-expected.txt: Added.
- fast/inline/fixed-pos-moves-with-abspos-inline-parent.html: Added.
- fast/inline/fixed-pos-moves-with-abspos-parent-expected.txt: Added.
- fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor-expected.txt: Added.
- fast/inline/fixed-pos-moves-with-abspos-parent-relative-ancestor.html: Added.
- fast/inline/fixed-pos-moves-with-abspos-parent.html: Added.
- fast/inline/fixed-pos-with-transform-container-moves-with-abspos-parent-expected.txt: Added.
- fast/inline/fixed-pos-with-transform-container-moves-with-abspos-parent.html: Added.
- 12:14 PM Changeset in webkit [140023] by
-
- 100 edits in trunk/Source
Make renderer constructors take Element where possible
https://bugs.webkit.org/show_bug.cgi?id=107138
Reviewed by David Hyatt.
Tighter typing prevents bugs and enables optimizations.
The patch changes how anonymous rendererer are constructed. Previously Document* as the node parameter
indicated that the renderer was anonymous. This forced the code to operate on ContainerNodes (Document
is not an Element). Now anonymous renderers are constructed by passing null and the document is set by
separate setDocumentForAnonymous() call. The patch uses RenderFoo::createAnonymous() pattern consistently.
Most constructors are switched to take Element. RenderBlock still takes ContainerNode due to a few subclasses
(RenderView and RenderFlowThread) that pass in a Document.
- page/FrameView.cpp:
(WebCore::FrameView::updateScrollCorner):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::createAnonymous):
(WebCore):
(WebCore::RenderBlock::createReplacementRunIn):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
(WebCore::RenderDeprecatedFlexibleBox::createAnonymous):
(WebCore):
- rendering/RenderDeprecatedFlexibleBox.h:
(RenderDeprecatedFlexibleBox):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
- rendering/RenderDetailsMarker.h:
(RenderDetailsMarker):
- rendering/RenderDialog.h:
(WebCore::RenderDialog::RenderDialog):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::RenderFieldset):
- rendering/RenderFieldset.h:
(RenderFieldset):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
- rendering/RenderFlowThread.cpp:
(WebCore):
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.cpp:
(RenderFullScreenPlaceholder::RenderFullScreenPlaceholder):
(RenderFullScreen::RenderFullScreen):
(RenderFullScreen::createAnonymous):
(RenderFullScreen::wrapRenderer):
- rendering/RenderFullScreen.h:
(RenderFullScreen):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
- rendering/RenderGrid.h:
(RenderGrid):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::createAnonymous):
(WebCore):
- rendering/RenderImage.h:
(RenderImage):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::createAnonymous):
(WebCore):
(WebCore::RenderInline::addChildIgnoringContinuation):
- rendering/RenderInline.h:
(RenderInline):
(WebCore::RenderInline::node):
Add version with covariant Element return type.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateScrollCornerStyle):
(WebCore::RenderLayer::updateResizerStyle):
(WebCore::RenderLayer::createReflection):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
(WebCore::RenderListItem::styleDidChange):
- rendering/RenderListItem.h:
(RenderListItem):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::RenderListMarker):
(WebCore::RenderListMarker::createAnonymous):
(WebCore):
- rendering/RenderListMarker.h:
(RenderListMarker):
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):
- rendering/RenderMediaControlElements.h:
(RenderMediaVolumeSliderContainer):
(RenderMediaControlTimeDisplay):
(RenderTextTrackContainerElement):
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):
- rendering/RenderMultiColumnBlock.h:
(RenderMultiColumnBlock):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
(WebCore::RenderMultiColumnSet::createAnonymous):
(WebCore):
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
- rendering/RenderObject.h:
Passed in null node indicates that the renderer is anonymous. Remove now unnecessary setIsAnonymous() function.
(WebCore::RenderObject::isAnonymous):
(WebCore::RenderObject::setDocumentForAnonymous):
(RenderObject):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(RenderRegion):
- rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::RenderRegionSet):
- rendering/RenderRegionSet.h:
(RenderRegionSet):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
(WebCore::RenderReplica::createAnonymous):
(WebCore):
- rendering/RenderReplica.h:
(RenderReplica):
- rendering/RenderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
- rendering/RenderRuby.h:
(RenderRubyAsInline):
(RenderRubyAsBlock):
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
(WebCore::RenderRubyBase::createAnonymous):
(WebCore):
- rendering/RenderRubyBase.h:
(RenderRubyBase):
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
- rendering/RenderRubyRun.h:
(RenderRubyRun):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
- rendering/RenderRubyText.h:
(RenderRubyText):
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::updateScrollbarPart):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
(WebCore::RenderScrollbarPart::createAnonymous):
(WebCore):
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::createAnonymousWithParentRenderer):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
- rendering/RenderTableCaption.h:
(RenderTableCaption):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::createAnonymousWithParentRenderer):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
- rendering/RenderTableCol.h:
(RenderTableCol):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
(WebCore::RenderTableRow::createAnonymousWithParentRenderer):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
(WebCore::RenderTableSection::createAnonymousWithParentRenderer):
- rendering/RenderTableSection.h:
(RenderTableSection):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
- rendering/RenderTextControl.h:
(RenderTextControl):
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
- rendering/RenderWidget.h:
(RenderWidget):
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
(WebCore::RenderMathMLBlock::createAnonymousMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
(RenderMathMLBlock):
- rendering/mathml/RenderMathMLFenced.cpp:
(WebCore::RenderMathMLFenced::createMathMLOperator):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
(WebCore::RenderMathMLOperator::updateFromElement):
(WebCore::RenderMathMLOperator::createGlyph):
- rendering/mathml/RenderMathMLOperator.h:
(RenderMathMLOperator):
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
- rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createRenderer):
- rendering/svg/RenderSVGBlock.cpp:
(WebCore::RenderSVGBlock::RenderSVGBlock):
- rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
- rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
- rendering/svg/RenderSVGTSpan.cpp:
(WebCore::RenderSVGTSpan::RenderSVGTSpan):
- rendering/svg/RenderSVGTSpan.h:
(RenderSVGTSpan):
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
- rendering/svg/RenderSVGTextPath.h:
(RenderSVGTextPath):
- 12:05 PM Changeset in webkit [140022] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Update Authentication Type and Scheme implementation
https://bugs.webkit.org/show_bug.cgi?id=107045
PR #281292
Reviewed by Yong Li.
Reviewed internally by Joe Mason. A typo is also fixed by Joe Mason.
The BlackBerry platform layer has defined both authentication type and authentication scheme.
This patch is adapting the porting layer to the platform layer change.
No functionalities changed no new tests.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- 12:02 PM Changeset in webkit [140021] by
-
- 12 edits143 adds in trunk
[GTK] Build with LevelDB when IndexedDB is enabled
https://bugs.webkit.org/show_bug.cgi?id=103220
Patch by Martin Robinson <mrobinson@igalia.com> on 2013-01-17
Reviewed by Gustavo Noronha Silva.
.:
- configure.ac: Detect whether the IndexedDatabase feature is enabled. We cannot
use the typical approach for feature detection since we need to adjust the automake
file output based on whether or not IndexedDatabase is enabled.
Source/ThirdParty:
Add the leveldb 1.9.0 source code to the ThirdParty dependencies.
We cannot depend on leveldb provided by the distribution, because
it sometimes breaks API compatibility.
- leveldb: Imported from the 1.9.0 leveldb source tarball.
Source/WebCore:
No new tests. This is just a build change. IndexedDatabase support
is already covered by the suite of storage layout tests.
- GNUmakefile.am: Add the leveldb convenience library.
- GNUmakefile.list.am: Add the list of sources.
Source/WebKit/gtk:
- GNUmakefile.am: When IndexedDatabase is enabled add the leveldb convenience
library to the shared library link phase.
Source/WebKit2:
- GNUmakefile.am: When IndexedDatabase is enabled add the leveldb convenience
library to the shared library link phase.
Tools:
- Scripts/webkitpy/style/checker.py: Do not style check the leveldb source code
as it does not conform to WebKit style.
- 11:53 AM Changeset in webkit [140020] by
-
- 2 edits in tags/Safari-537.26.1/Source/WebKit2
Merged r139943. <rdar://problem/12513871>
- 11:52 AM Changeset in webkit [140019] by
-
- 3 edits in trunk/Source/WebCore
Wire BackgroundHTMLParser to HTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=107140
Reviewed by Adam Barth.
With this patch, we now pass the majority of html5lib and fast/parser tests with threaded HTML parsing enabled.
No new tests because covered by existing fast/parser tests.
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::TokenDelivery::execute):
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::processingData):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::feedTokens):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::hasPreloadScanner):
(WebCore::HTMLDocumentParser::shouldUseThreading):
- 11:49 AM Changeset in webkit [140018] by
-
- 2 edits in tags/Safari-537.26.1/Source/WebKit2
Merged r139960. <rdar://problem/12951765>
- 11:48 AM Changeset in webkit [140017] by
-
- 5 edits in trunk/Source/WebCore
MediaStream API: Move all ExtraDataContainers into anonymous namespaces
https://bugs.webkit.org/show_bug.cgi?id=107128
Reviewed by Kentaro Hara.
Tests not needed.
- platform/chromium/support/WebMediaStreamDescriptor.cpp:
- platform/chromium/support/WebMediaStreamSource.cpp:
- platform/chromium/support/WebRTCSessionDescriptionRequest.cpp:
- platform/chromium/support/WebRTCVoidRequest.cpp:
- 11:47 AM Changeset in webkit [140016] by
-
- 22 edits3 copies in tags/Safari-537.26.1/Source
Merged r139935. <rdar://problem/12951765>
- 11:42 AM Changeset in webkit [140015] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: InstrumentingAgents should be registered in InspectorInstrumentation only when there is a front-end
https://bugs.webkit.org/show_bug.cgi?id=107127
Reviewed by Vsevolod Vlasov.
InspectorInstrumentation::registerInstrumentingAgents is called when front-end
is connected to corresponding InspectorController. When the front-end disconnects
InspectorInstrumentation::unregisterInstrumentingAgents is called.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
- 11:35 AM Changeset in webkit [140014] by
-
- 6 edits18 adds in trunk
[CSS Regions] Content flows incorrectly in autoheight regions with min/max-height set
https://bugs.webkit.org/show_bug.cgi?id=102099
Patch by Andrei Bucur <abucur@adobe.com> on 2013-01-17
Reviewed by David Hyatt.
Source/WebCore:
The current layout algorithm for auto-height regions is gives wrong results when the max-height property is set on them. The reason is we
consider the max-height restriction too late in the layout, when applying a forced break. This is what happens when content is laid out
in an auto-height region.
- The content flows without a limit until a forced break appears. If there's no forced break in the content, one is forced anyway at the end
of the layout.
- The region where the forced break is placed is not always the one where content is laid out because of max-height restrictions.
- All the regions with max-height are iterated and their height accumulated until the break offset is reached and the region at that point is ended.
This gives wrong results because the forced break position in the content was computed assuming there's only one region where the content is laid out.
The regions with max-height could have generated unforced breaks at their height and the forced break actually should have a different position.
This patch changes the algorithm in this way:
- From the flow thread perspective all the regions start with a height: max-height for auto-height regions (or LayoutSize.max()/2 if not defined)
or the fixed height value when specified.
- When the content is laid out, if there's no forced break, the height of the content is correctly estimated because the layout sees unforced breaks
at the max-height values.
- If a forced break appears, the affected region can be obtained only by looking at the break offset in the region chain. If the region has auto-height,
its height is updated by the forced break.
- At the end of the layout, there's the additional task to clear the height of all the regions that didn't receive content. This can be done optimally
without adding a new iteration through the regions by attaching to the RegionOverset computation loop.
Tests: fast/regions/autoheight-maxheight-mixed-break.html
fast/regions/autoheight-maxheight-simple-break.html
fast/regions/autoheight-maxheight-simple-nobreak.html
fast/regions/autoheight-minmaxheight-mixed-break-hbt.html
fast/regions/autoheight-minmaxheight-mixed-break-vlr.html
fast/regions/autoheight-minmaxheight-mixed-break-vrl.html
fast/regions/autoheight-minmaxheight-mixed-break.html
fast/regions/autoheight-minmaxheight-simple-break.html
fast/regions/autoheight-minmaxheight-simple-nobreak.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::computeLogicalHeight):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::pageLogicalHeightForOffset):
(WebCore::RenderFlowThread::pageRemainingLogicalHeightForOffset):
(WebCore::RenderFlowThread::computeOverflowStateForRegions): Attach to the loop in this function to clear the overrideLogicalHeight on empty regions.
(WebCore):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect): Add an ASSERT that a region always has overrideLogicalHeight or a fixed height.
(WebCore::RenderFlowThread::initializeRegionsOverrideLogicalContentHeight): A new function that updates the region chain height to use the max-height value
for auto-height regions.
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::pageLogicalHeight): the decorations size is incorrectly considered in the page height.
(WebCore):
(WebCore::RenderRegion::maxPageLogicalHeight): new function that returns the max page size for a region. It shouldn't be called too often
or the returned value can be cached
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent): the decorations size is incorrectly considered in the logical height of
the flow thread content.
- rendering/RenderRegion.h:
(RenderRegion):
LayoutTests:
All the tests have a description about how the breaking should happen. They pass if the height of the region chain is
correctly computed by using the max-height, min-height, height and writing mode conditions.
- fast/regions/autoheight-maxheight-mixed-break-expected.txt: Added.
- fast/regions/autoheight-maxheight-mixed-break.html: Added.
- fast/regions/autoheight-maxheight-simple-break-expected.txt: Added.
- fast/regions/autoheight-maxheight-simple-break.html: Added.
- fast/regions/autoheight-maxheight-simple-nobreak-expected.txt: Added.
- fast/regions/autoheight-maxheight-simple-nobreak.html: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-hbt.html: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-vlr.html: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-mixed-break-vrl.html: Added.
- fast/regions/autoheight-minmaxheight-mixed-break.html: Added.
- fast/regions/autoheight-minmaxheight-simple-break-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-simple-break.html: Added.
- fast/regions/autoheight-minmaxheight-simple-nobreak-expected.txt: Added.
- fast/regions/autoheight-minmaxheight-simple-nobreak.html: Added.
- 11:35 AM Changeset in webkit [140013] by
-
- 3 edits in tags/Safari-537.26.1/Source/WebKit2
Merge patch for <rdar://problem/13007758>
- 11:30 AM Changeset in webkit [140012] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Open resource dialog has poor performance.
https://bugs.webkit.org/show_bug.cgi?id=107122
Reviewed by Pavel Feldman.
Open resource dialog does not make linear number of relayouts on highlight anymore.
Replaced localeCompare with string compare since it is significantly faster.
- inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._highlightItems):
(WebInspector.OpenResourceDialog.compareFunction):
(WebInspector.OpenResourceDialog):
- 11:27 AM Changeset in webkit [140011] by
-
- 2 edits in trunk/Source/WebKit/chromium
Unreviewed. Rolled Chromium DEPS to r177369. Requested by
ajuma via sheriffbot.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
- DEPS:
- 11:26 AM Changeset in webkit [140010] by
-
- 6 edits4 adds in trunk
Add ontransitionend attribute on HTML elements.
https://bugs.webkit.org/show_bug.cgi?id=107134
Reviewed by Simon Fraser.
Source/WebCore:
Add ontransitionend attribute on HTML elements to match the prefixed
attribute onwebkittransitionend. As it uses the same plumbing as a
regular event listener, it behaves the same which means that if
ontransitionend only is defined then only the code attached to this
attribute will be called, if only onwebkittransitionend is defined then
only the code attached to this attribute will be called and finally if
both attributes are defined then only the code attached to the
unprefixed attribute will be called.
Tests: transitions/transition-end-event-unprefixed-03.html
transitions/transition-end-event-unprefixed-04.html
- html/HTMLAttributeNames.in:
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute):
- page/DOMWindow.h:
(DOMWindow):
- page/DOMWindow.idl: only define the property if the unprefixing is
turn on.
LayoutTests:
Add tests to cover the new attribute. It also make sure that event if
we use the old attribute and the new one at the same time only the new
event handler will be called.
- transitions/transition-end-event-unprefixed-03-expected.txt: Added.
- transitions/transition-end-event-unprefixed-03.html: Added.
- transitions/transition-end-event-unprefixed-04-expected.txt: Added.
- transitions/transition-end-event-unprefixed-04.html: Added.
- 11:25 AM Changeset in webkit [140009] by
-
- 10 edits2 copies in tags/Safari-537.26.1/Source/WebKit2
Merged r139888. <rdar://problem/13007758>
- 11:23 AM Changeset in webkit [140008] by
-
- 2 edits in tags/Safari-537.26.1/Source/WebCore
Merged r139800. <rdar://problem/12961725>
- 11:15 AM Changeset in webkit [140007] by
-
- 4 edits2 adds in trunk
Widows and orphans test4 fails if isolated
https://bugs.webkit.org/show_bug.cgi?id=106006
Patch by Andrei Bucur <abucur@adobe.com> on 2013-01-17
Reviewed by Dean Jackson.
Source/WebCore:
To determine if the orphans condition is not respected, every time a fragmentation break is encountered adjustLinePositionForPagination() is called for the current line.
If the index on the line in the block is smaller than the number of orphans specified in the style object, the block is shifted in the next fragmentainer. The index of
the line is obtained by calling RenderBlock::lineCount. However, this only works in a full layout when lineCount() will coincidentally return the index of the line.
In subsequent layouts, during the determineStartPosition() phase, lineCount() returns all the lines in the block so the orphans condition is never triggered.
The patch modifies the lineCount() function to have two optional parameters. The first parameter is the line where lineCount should stop counting lines. The second
is an output boolean parameter indicating if the line was found or not. This change makes the lineCount() more flexible and allows retreiving the index of a
specific line (e.g. the index of the current line inside adjustLinePositionForPagination()).
Tests: fast/multicol/orphans-relayout.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineCount): See the detailed description.
(WebCore::RenderBlock::adjustLinePositionForPagination): Make use of the modified lineCount() function.
- rendering/RenderBlock.h:
(RenderBlock):
LayoutTests:
This is the "Basic Orphans" test extracted from fast/multicol/widows-and-orphans.html. It was minimized and modified to include a relayout step.
- fast/multicol/orphans-relayout-expected.txt: Added.
- fast/multicol/orphans-relayout.html: Added.
- 11:13 AM Changeset in webkit [140006] by
-
- 4 edits in trunk
REGRESSION (r137487): Crashes in editing/execCommand/indent-paragraphs.html on GTK, EFL
https://bugs.webkit.org/show_bug.cgi?id=105042
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Explicitly handle the situation where the creation of a SoupURI fails. This
can happen if the URI is invalid. In that case the constructor returns null.
No new tests. This patch unskips a failing test.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupRequestAndMessageForHandle): Handle a null Soup URI.
LayoutTests:
Unskip a test which is now passing.
- platform/gtk/TestExpectations:
- 11:09 AM Changeset in webkit [140005] by
-
- 24 edits3 adds in trunk
.: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Antti Koivisto.
- Source/autotools/symbols.filter: Expose MemoryCache::resourceForURL().
Source/WebCore: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Antti Koivisto.
Test: http/tests/cache/cached-main-resource.html
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::hasManifest): Returns true if the <html> element has a non-empty manifest attribute.
- dom/Document.h:
(Document):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Don't send delegate callbacks for cache hit here, since
MainResourceLoader will take care of it.
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::didFinishLoading): Don't try to cache loads from the application cache.
(WebCore::MainResourceLoader::load): Ensure we create a resource load identifier for cache hits. Also,
ensure we correctly popualate fragment identifiers in the ResourceRequest reported to DocumentLoader.
(WebCore::MainResourceLoader::identifier):
- loader/MainResourceLoader.h: Rename m_substituteDataLoadIdentifier to m_identifierForLoadWithoutResourceLoader
to better describe when it is used.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient): Synthesize redirect notifications for cache hits if necessary.
(WebCore::CachedRawResource::willSendRequest): Note the redirects we received.
(WebCore::CachedRawResource::canReuse): Don't reuse a resource if the redirect chain included a "Cache-control: no-store".
- loader/cache/CachedRawResource.h:
(CachedRawResource):
(RedirectPair):
(WebCore::CachedRawResource::RedirectPair::RedirectPair):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::addClientToSet):: Don't return cached data for a main resource synchronously
- loader/cache/CachedResource.h:
(WebCore::CachedResource::canReuse):
(CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Permit cache reuse for main resources.
- testing/Internals.cpp:
(WebCore::Internals::isLoadingFromMemoryCache):
(WebCore):
- testing/Internals.h:
(Internals):
- testing/Internals.idl:
Source/WebKit/win: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667
Reviewed by Antti Koivisto.
- WebKit.vcproj/WebKitExports.def.in: Expose some MemoryCache symbols for use in Internals.
LayoutTests: Enable reuse of cached main resources
https://bugs.webkit.org/show_bug.cgi?id=105667.
Reviewed by Antti Koivisto.
- http/tests/cache/cached-main-resource-expected.txt: Added.
- http/tests/cache/cached-main-resource.html: Added.
- http/tests/cache/resources/cacheable-iframe.php: Added.
- http/tests/inspector/resource-har-pages-expected.txt:
- http/tests/loading/redirect-methods-expected.txt:
- http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
- http/tests/misc/link-rel-icon-beforeload-expected.txt:
- 11:06 AM Changeset in webkit [140004] by
-
- 3 edits in trunk/Tools
[EFL][WK2] Fix misuse of ASSERT on ecore_evas_init()
https://bugs.webkit.org/show_bug.cgi?id=107119
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-01-17
Reviewed by Laszlo Gombos.
Do not use ASSERT on ecore_evas_init(), since the expression inside
the macro compiles out of release builds.
- TestWebKitAPI/PlatformEfl.cmake: Enable API test UserMessage.
- TestWebKitAPI/efl/PlatformWebView.cpp:
(TestWebKitAPI::initEcoreEvas): Remove ASSERT on ecore_evas_init().
- 11:04 AM Changeset in webkit [140003] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: [Network] Remove boilerplate CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=107121
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-17
Reviewed by Vsevolod Vlasov.
There are rules that are used for filtration and styling
whose selectors should be autogenerated.
- inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._injectStyles):
- inspector/front-end/networkLogView.css:
- 11:02 AM BuildingQtOnWindows edited by
- Update the sparse-checkout section. (diff)
- 11:01 AM Changeset in webkit [140002] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] TiledCoreAnimationDrawingArea should unparent its layer tree when requested
https://bugs.webkit.org/show_bug.cgi?id=107108
<rdar://problem/12549879>
Reviewed by Darin Adler and Simon Fraser.
Currently, TiledCoreAnimationDrawingArea returns early if asked to unparent
its layer tree, to prevent flashing when switching tabs. We have new plans
to alleviate the flashing, but first, we should reinstate unparenting the root layer,
to allow underlying libraries to better manage the memory backing all compositing layers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
- 10:58 AM Changeset in webkit [140001] by
-
- 4 edits in trunk/Source
Fix the Mac build sans ENABLE(CSS_FILTERS)
Reviewed by Darin Adler.
Include FloatRect in RemoteGraphicsLayer.mm; it's included by chance currently,
via something that must be compiled out without CSS_FILTERS (or SVG, or shaders, or something).
- WebProcess/WebPage/mac/RemoteGraphicsLayer.mm:
Move an export from a USE(ACCELERATED_COMPOSITING) block to a ENABLE(CSS_FILTERS)
block, to match the code that backs it.
- WebCore.exp.in:
- 10:56 AM Changeset in webkit [140000] by
-
- 23 edits1 copy in tags/Safari-537.26.1
Merged r139796. <rdar://problem/12597159>
- 10:52 AM Changeset in webkit [139999] by
-
- 4 edits in trunk
[Mac] svg/custom/text-use-click-crash.xhtml added by r139029 hits assertion in enclosingTextFormControl
https://bugs.webkit.org/show_bug.cgi?id=106361
Reviewed by Darin Adler.
Source/WebCore:
When ASSERT hit in enclosingTextFormControl(Position), position.anchorNode() was /use/shadow-root/text,
and position.anchorType() was PositionIsBeforeAnchor. In this case, position.containerNode() should be
ShadowRoot if SHADOW_DOM flag is enabled. However, SHADOW_DOM flag is not enabled in mac port,
position.containerNode() returns 0. This hits ASSERT.
We have two options to solve this problem. (1) is to allow Position to have ShadowRoot as a container node,
but this will affect a lot of code. (2) is to loosen ASSERT condition.
I've chosen (2) option in this patch.
Test: svg/custom/text-use-click-crash.xhtml should cover this.
- html/HTMLTextFormControlElement.cpp:
(WebCore::enclosingTextFormControl):
LayoutTests:
Removed crash test expectation.
- platform/mac/TestExpectations:
- 10:50 AM Changeset in webkit [139998] by
-
- 14 edits in trunk
Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot"
https://bugs.webkit.org/show_bug.cgi?id=104545
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-17
Reviewed by Yury Semikhatsky.
Source/WebCore:
This change will allow stronger typing of profiler output.
- inspector/Inspector.json:
Split "getProfile" to "getCPUProfile" and "getHeapSnapshot".
- inspector/InspectorProfilerAgent.cpp: Ditto.
- inspector/InspectorProfilerAgent.h: Ditto.
- inspector/front-end/CPUProfileView.js: Adopd changes.
- inspector/front-end/HeapSnapshotView.js: Ditto.
Source/WebKit/chromium:
Adopt changes: mimic old behavior.
- src/WebDevToolsAgentImpl.cpp: Adopt signature changes.
Tools:
Adopt signature changes.
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(ProfilerAgent.getCPUProfile): Renamed.
(ProfilerAgent.getHeapSnapshot): Added.
LayoutTests:
Adopted new method signatures.
- inspector/profiler/heap-snapshot-get-profile-crash.html:
Adopted new method signatures.
- inspector/profiler/heap-snapshot-loader.html: Ditto.
- inspector/profiler/heap-snapshot-test.js: Ditto.
- 10:47 AM Changeset in webkit [139997] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: [Network] Memory leaks when user walks between requests.
https://bugs.webkit.org/show_bug.cgi?id=107114
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-17
Reviewed by Vsevolod Vlasov.
Unregister event listeners when view is detached.
- inspector/front-end/RequestCookiesView.js: Fixed memory leak.
- inspector/front-end/RequestHeadersView.js: Ditto.
- inspector/front-end/RequestTimingView.js: Ditto.
- 10:44 AM Changeset in webkit [139996] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Timeline] REGRESSION: Sidebar shrinks when user switches to memory statistics mode.
https://bugs.webkit.org/show_bug.cgi?id=105857
Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-01-17
Reviewed by Pavel Feldman.
Fix: do not apply constraints to sidebar width while view is offscreen;
constraint check will be applied when view goes visible.
- inspector/front-end/SidebarView.js:
(WebInspector.SidebarView.prototype.applyConstraints): Check if view is
offscreen.
- 10:43 AM Changeset in webkit [139995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=107113
Skipping test with missing expectation result.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-01-17
- platform/efl-wk2/TestExpectations:
- 10:40 AM Changeset in webkit [139994] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [Spectrum] Color picker in CSS editor does not update textual color value
https://bugs.webkit.org/show_bug.cgi?id=107110
Reviewed by Vsevolod Vlasov.
The Spectrum picker was never told to update the textual color upon user-initiated color changes.
- inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):
- 10:40 AM Changeset in webkit [139993] by
-
- 2 edits in trunk/Source/JavaScriptCore
Added svn:ignore=*.pyc, so that ud_opcode.pyc and ud_optable.pyc don't show up
in svn stat.
- disassembler/udis86: Added property svn:ignore.
- 10:37 AM Changeset in webkit [139992] by
-
- 2 edits in trunk
[EFL][CMAKE] Compress resource files of inspector
https://bugs.webkit.org/show_bug.cgi?id=106210
Patch by Seokju Kwon <Seokju Kwon> on 2013-01-17
Reviewed by Gyuyoung Kim.
Add compressing JavaScript
for smaller package and faster connection of remote web inspector.
- Source/PlatformEfl.cmake:
- 10:36 AM Changeset in webkit [139991] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary public method TiledBackingStore::supportsAlpha()
https://bugs.webkit.org/show_bug.cgi?id=107067
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-17
Reviewed by Kentaro Hara.
This patch removes unnecessary public method TiledBackingStore::supportsAlpha()
because supportsAlpha() is never called from other classes.
No new tests, no change in behavior.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::setSupportsAlpha):
- platform/graphics/TiledBackingStore.h:
(TiledBackingStore):
- 10:34 AM Changeset in webkit [139990] by
-
- 2 edits in trunk/Source/WebCore
[V8] Remove a --es5_readonly flag from V8 initialization and address duplicated code
https://bugs.webkit.org/show_bug.cgi?id=106790
Patch by Peter Rybin <peter.rybin@gmail.com> on 2013-01-17
Reviewed by Kentaro Hara.
Couple of statements are moved to a newly created method. Old V8 flag setter is removed
according to FIXME and per V8 change http://code.google.com/p/v8/source/detail?r=12415
- bindings/v8/V8Initializer.cpp:
(WebCore::initializeV8Common): newly created method
(WebCore):
(WebCore::V8Initializer::initializeMainThreadIfNeeded):
(WebCore::V8Initializer::initializeWorker):
- 10:33 AM Changeset in webkit [139989] by
-
- 3 edits2 adds in trunk
Fix texImage2D from a WebGL canvas.
https://bugs.webkit.org/show_bug.cgi?id=106941
Patch by John Bauman <jbauman@chromium.org> on 2013-01-17
Reviewed by Kenneth Russell.
Source/WebCore:
Clear the copied image whenever the canvas is modified, even if using
accelerated compositing.
Test: fast/canvas/webgl/tex-image-webgl.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::markContextChanged):
LayoutTests:
Add test to ensure doing teximage2d from a webgl canvas works. This
test is the same as a webgl conformance test.
- fast/canvas/webgl/tex-image-webgl-expected.txt: Added.
- fast/canvas/webgl/tex-image-webgl.html: Added.
- 10:29 AM Changeset in webkit [139988] by
-
- 2 edits in trunk/Source/WebCore
[AC] Memory leak in GLXConfigSelector::createConfig()
https://bugs.webkit.org/show_bug.cgi?id=106657
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-01-17
Reviewed by Laszlo Gombos.
Free the memory returned by glXGetVisualFromFBConfig() using
XFree to avoid a memory leak.
No new tests. No change in behavior.
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::createConfig):
- 10:28 AM Changeset in webkit [139987] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r139929.
http://trac.webkit.org/changeset/139929
https://bugs.webkit.org/show_bug.cgi?id=107141
Speculative fix didn't work (Requested by jsbell on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-17
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- 10:22 AM Changeset in webkit [139986] by
-
- 3 edits in trunk/LayoutTests
[Chromium] Test expectations update after Skia shader changes
Unreviewed new GPU expectations
- platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
- platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
- 10:08 AM Changeset in webkit [139985] by
-
- 8 edits in trunk/Source
Don't use NSApplication run loop in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=107061
Reviewed by Anders Carlsson.
Only WebProcess and PluginProcess should use Cocoa APIs that require the run loop.
- PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializePluginProcess):
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeProcess):
- 9:27 AM Changeset in webkit [139984] by
-
- 8 edits4 copies in branches/chromium/1364
Merge 139461
RenderLayerCompositor should let ScrollingCoordinator update main thread scrolling reasons after change of layers
https://bugs.webkit.org/show_bug.cgi?id=105652
Reviewed by Simon Fraser.
Source/WebCore:
Let ScrollingCoordinator know the change of ViewportConstrainedNotCompositedReason in time.
By the way moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to RenderLayer::ViewportConstrainedNotCompositedReason.
Tests: compositing/layer-creation/fixed-position-in-view-dynamic.html
compositing/layer-creation/fixed-position-out-of-view-dynamic.html
- page/scrolling/ScrollingCoordinator.cpp:
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasons):
(WebCore::ScrollingCoordinator::mainThreadScrollingReasonsAsText):
- page/scrolling/ScrollingCoordinator.h:
(ScrollingCoordinator):
- page/scrolling/mac/ScrollingCoordinatorMac.h:
(WebCore::ScrollingCoordinatorMac::hasVisibleSlowRepaintViewportConstrainedObjects):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::logThreadedScrollingMode):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintLayer):
- rendering/RenderLayer.h:
(RenderLayer): Moved RenderLayerCompositor::FixedPositionLayerNotCompositedReason to here and renamed it to ViewportConstrainedNotCompositedReason.
(WebCore::RenderLayer::setViewportConstrainedNotCompositedReason):
(WebCore::RenderLayer::viewportConstrainedNotCompositedReason):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBacking): Now updates ViewportConstrainedNotCompositedReason here instead of in computeCompositingRequirements before so that the reason is updated in time.
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::needsToBeComposited):
(WebCore::RenderLayerCompositor::requiresCompositingLayer):
(WebCore::RenderLayerCompositor::reasonForCompositing):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::reportMemoryUsage):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
LayoutTests:
Tests to ensure mainThreadScrollingReasons are correctly updated after a fixed element is dynamically inserted into the DOM tree.
- compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Added.
- compositing/layer-creation/fixed-position-in-view-dynamic.html: Added.
- compositing/layer-creation/fixed-position-out-of-view-dynamic-expected.txt: Added.
- compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Added.
TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/11970041
- 8:38 AM Changeset in webkit [139983] by
-
- 2 edits in trunk/LayoutTests
[Chromium} Removing extraneous expectations
Unreviewed expectations clean-up
- platform/chromium/TestExpectations:
- 8:37 AM Changeset in webkit [139982] by
-
- 2 edits in trunk/Source/WTF
Fix vprintf_stderr_common() to compile with -Wshorten-64-to-32
<http://webkit.org/b/107126>
Reviewed by Darin Adler.
Fixes the following build error:
Assertions.cpp:92:22: error: implicit conversion loses integer precision: 'CFIndex' (aka 'long') to 'int' [-Werror,-Wshorten-64-to-32]
int length = CFStringGetMaximumSizeForEncoding(CFStringGetLength(str), kCFStringEncodingUTF8);
~
1 error generated.
- wtf/Assertions.cpp:
(vprintf_stderr_common): Use CFIndex type instead of int for the
return value of CFStringGetMaximumSizeForEncoding().
- 8:34 AM Changeset in webkit [139981] by
-
- 3 edits1 add in trunk/LayoutTests
[Chromium] Final rebaselines after Skia flags changed
https://bugs.webkit.org/show_bug.cgi?id=106833
https://bugs.webkit.org/show_bug.cgi?id=99138
Unreviewed test expectations update
- platform/chromium-linux/fast/borders/outline-alpha-inline-expected.png: Added.
- platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
- platform/chromium/TestExpectations:
- 8:15 AM Changeset in webkit [139980] by
-
- 5 edits in trunk
Web Inspector: fix DefaultTextEditor's broken backspace
https://bugs.webkit.org/show_bug.cgi?id=107130
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-17
Reviewed by Pavel Feldman.
Source/WebCore:
Remove css "position: relative;" style from "webkit-line-content" class, which
somehow brakes editing experience. Remove "height: 100%" from text-editor-overlay-highlight
class and cast necessary height via inserting " " into overlay span elements.
No new tests: no change in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
- inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
LayoutTests:
Fix test expected results to correspond to changes.
- inspector/editor/text-editor-highlight-regexp-expected.txt:
- 7:54 AM Changeset in webkit [139979] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adjust and move expectations for tests in svg/ and tables/ as
necessary to cover current testing situation for both WebKit1 and WebKit2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 4:39 AM Changeset in webkit [139978] by
-
- 15 edits1 add in trunk
Web Inspector: Introduce FileSystemWorkspaceProvider to allow showing files from file system in workspace.
https://bugs.webkit.org/show_bug.cgi?id=107021
Reviewed by Pavel Feldman.
Source/WebCore:
Added FileSystemWorkspaceProvider that populates workspace with files
loaded from file systems registered in FileSystemMapping and listens
for FileSystemAdded / FileSystemRemoved events to update workspace.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype.urlForURI):
(WebInspector.FileMapping.MappingEntry.prototype.urlForURI):
- inspector/front-end/FileSystemMapping.js:
(WebInspector.FileSystemMapping.prototype.uriForPath):
(WebInspector.FileSystemMapping.prototype.addEventListener):
(WebInspector.FileSystemMapping.prototype.removeEventListener):
(WebInspector.FileSystemMappingImpl):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):
- inspector/front-end/FileSystemWorkspaceProvider.js: Added.
- inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel):
(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
- inspector/front-end/externs.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
- inspector/front-end/navigatorView.css:
(.navigator-other-tree-item .icon):
LayoutTests:
- inspector/file-mapping-expected.txt:
- 4:25 AM Changeset in webkit [139977] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Removing 4 crash expectations that are obsolete.
- platform/gtk/TestExpectations:
- 3:08 AM Changeset in webkit [139976] by
-
- 2 edits in trunk/Source/WebKit/chromium
Web Inspector: add WebDeToolsAgentImpl as task observer on reattach
https://bugs.webkit.org/show_bug.cgi?id=107106
Reviewed by Pavel Feldman.
Register WebDevToolsAgentImpl as task observer when it client is reattached.
- src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::reattach):
- 2:32 AM Changeset in webkit [139975] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Allow to run spellcheck-input-search-crash.html for WK2-EFL.
This test passes after r135595.
It's skipped by global platform/wk2/TestExpectations.
- platform/efl-wk2/TestExpectations:
- 2:19 AM FeatureFlags edited by
- Update comment for forms-related flags (diff)
- 2:04 AM Changeset in webkit [139974] by
-
- 11 edits in trunk/Source/WTF
[Autotools] Unify WTF sources list regardless of the target OS, Unicode backend
https://bugs.webkit.org/show_bug.cgi?id=105886
Reviewed by Gustavo Noronha Silva.
Rather than including files in the sources list in an OS-specific way,
guard specific files with OS(UNIX|WINDOWS), USE((GLIB|ICU)_UNICODE) guards
and include all of them in the list.
Proper comments for namespace and #if guard closings are also added or adjusted
where necessary in the affected files.
- GNUmakefile.list.am:
- wtf/OSAllocatorPosix.cpp: Add OS(UNIX) guards.
- wtf/OSAllocatorWin.cpp: Add OS(WINDOWS) guards.
- wtf/ThreadSpecificWin.cpp: Ditto.
- wtf/ThreadingWin.cpp: Ditto.
- wtf/unicode/glib/UnicodeGLib.cpp: Add USE(GLIB_UNICODE) guards.
(WTF):
- wtf/unicode/glib/UnicodeGLib.h: Ditto.
(WTF):
- wtf/unicode/icu/CollatorICU.cpp: Style changes.
- wtf/unicode/icu/UnicodeIcu.h: Add USE(ICU_UNICODE) guards.
(WTF):
- wtf/win/OwnPtrWin.cpp: Add OS(WINDOWS) guards.
- 2:03 AM FeatureFlags edited by
- Graduate MUTATION_OBSERVERS, add SPEECH_SYNTHESIS and THREADED_HTML_PARSER (diff)
- 1:58 AM Changeset in webkit [139973] by
-
- 4 edits in trunk/Tools
[GTK][EFL] NWRT should check that Xvfb is installed
https://bugs.webkit.org/show_bug.cgi?id=71767
Reviewed by Dirk Pranke.
EFL and GTK ports now check that Xvfb is installed before running
layout tests. The command line used to check whether Xvfb is present
is a simplewhich Xvfbthat should return 0 as the exit code upon
success.
- Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.show_results_html_file):
(EflPort):
(EflPort.check_sys_deps):
- Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.check_sys_deps):
- Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver):
(XvfbDriver.check_xvfb):
- 1:07 AM Changeset in webkit [139972] by
-
- 4 edits in trunk/Source/WebCore
Web Inspector: add createOption method to WebInspector.StatusBarComboBox
https://bugs.webkit.org/show_bug.cgi?id=107102
Reviewed by Vsevolod Vlasov.
- inspector/front-end/CPUProfileView.js:
- inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._addFrame):
(WebInspector.ConsoleView.prototype._appendContextOption):
- inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype.set state):
(WebInspector.StatusBarButton.prototype.set visible):
(WebInspector.StatusBarComboBox.prototype.createOption):
- 12:25 AM Changeset in webkit [139971] by
-
- 5 edits in trunk
[EFL][GTK] checkSpellingOfString treats the multiple words as spelled correctly
https://bugs.webkit.org/show_bug.cgi?id=106662
Reviewed by Antonio Gomes.
Source/WebCore:
No new tests, covered by spelling-backspace-between-lines.html.
TextCheckerEnchant::checkSpellingOfString() method, treats the multiple words
as spelled correctly if one of them is ok. For example, string such as
"OK zz OK" is spelled correctly!
The method at the beginning assumes that the given string is spelled correctly,
then it iterates over the words to find out the misspelled location and length
in the whole string. In checkSpellingOfWord, if the word is ok, we mark
it as spelled correctly and we do return to check the next words. In the fact,
the location and length of the previously misspelled words are overwritten.
- platform/text/enchant/TextCheckerEnchant.cpp:
(WebCore::TextCheckerEnchant::checkSpellingOfWord):
Update of the word's misspeling location and length was moved out the loop.
(WebCore::TextCheckerEnchant::checkSpellingOfString):
Stop checking the next words If the current word is misspelled, to do not overwrite
its misspelled location and length.
LayoutTests:
- platform/efl-wk2/TestExpectations:
Allow running spelling-backspace-between-lines.html for WebKit2-EFL as it's
skipped by platform/wk2/TestExpectations.
- platform/gtk/TestExpectations:
Unskipping spelling-backspace-between-lines.html for WebKit-GTK+.
- 12:14 AM Changeset in webkit [139970] by
-
- 6 edits3 adds in trunk
WebSpeech: implement voices list
https://bugs.webkit.org/show_bug.cgi?id=107014
Reviewed by Adam Barth.
Source/WebCore:
Add in the Mac side code to return a list of voices.
Adds a layout test, which is skipped for now, until the feature is enabled.
Test: platform/mac/fast/speechsynthesis/speech-synthesis-voices.html
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
- Modules/speech/SpeechSynthesis.h:
(SpeechSynthesis):
- Modules/speech/mac/SpeechSynthesisMac.mm:
(WebCore::SpeechSynthesis::initializeVoiceList):
LayoutTests:
- platform/mac/TestExpectations:
- platform/mac/fast/speechsynthesis: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-voices-expected.txt: Added.
- platform/mac/fast/speechsynthesis/speech-synthesis-voices.html: Added.
Jan 16, 2013:
- 11:35 PM Changeset in webkit [139969] by
-
- 4 edits in trunk/Tools
sheriffbot can't tell me who "kov" is
https://bugs.webkit.org/show_bug.cgi?id=106184
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Eric Seidel.
Added glob style searching to the CommitterList contributors_by_search_string function so exact matches are favoured.
- Scripts/webkitpy/common/config/committers.py:
(Account.matches_glob):
(CommitterList.contributors_by_search_string):
- Scripts/webkitpy/common/config/committers_unittest.py:
(CommittersTest.test_committer_lookup):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Whois):
- 11:35 PM Changeset in webkit [139968] by
-
- 2 edits in trunk/Source/WebKit2
Update sandbox rules after r128003
https://bugs.webkit.org/show_bug.cgi?id=106840
Reviewed by Darin Adler.
- WebProcess/com.apple.WebProcess.sb.in: Additional Lion only fixes.
- 11:23 PM Changeset in webkit [139967] by
-
- 10 edits in trunk/Source/WebCore
Update GraphicsContext to support winding rule in clip operator for Core Graphics
https://bugs.webkit.org/show_bug.cgi?id=106871
Patch by Rik Cabanier <cabanier@adobe.com> on 2013-01-16
Reviewed by Dirk Schulze.
Changed the interface to GraphicsContext so it's possible to pass the winding
rule to canvasClip() and clip().
No new tests, no change in functionality.
- WebCore.exp.in: Change signature of canvasClip function.
- platform/graphics/GraphicsContext.h: Change canvasClip and clip signature with default winding rule.
- platform/graphics/cairo/GraphicsContextCairo.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/cg/GraphicsContextCG.cpp: Update interface with new signature and implement winding rules.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/openvg/GraphicsContextOpenVG.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/qt/GraphicsContextQt.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/skia/GraphicsContextSkia.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/wince/GraphicsContextWinCE.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- platform/graphics/wx/GraphicsContextWx.cpp: Update interface with new signature so it still compiles.
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
- 11:20 PM Changeset in webkit [139966] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177350.
- DEPS:
- 9:31 PM Changeset in webkit [139965] by
-
- 2 edits in trunk/Tools
Use xcrun to find path to make for Mac port
<http://webkit.org/b/107091>
Reviewed by Dan Bernstein.
- Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort._build_java_test_support): Call self.make_command().
(MacPort.make_command): Add. Call xcrun_find().
(MacPort.nm_command): Use self.xcrun_find().
(MacPort.xcrun_find): Add. Extract from nm_command().
- 9:25 PM Changeset in webkit [139964] by
-
- 3 edits2 adds in trunk
NoEventDispatchAssertion in ContainerNode::removeChildren is too strict
https://bugs.webkit.org/show_bug.cgi?id=106985
Reviewed by Ryosuke Niwa.
Source/WebCore:
This change narrowed the lifetime of NoEventDispatchAssertion in removeChildren().
It is as safe as other mutation method even after this change: childrenChanged() and
ChildNodeRemovalNotifier are used outside the assertion scope.
Test: svg/custom/use-mutation-crash.xhtml
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChildren):
LayoutTests:
- svg/custom/use-mutation-crash-expected.txt: Added.
- svg/custom/use-mutation-crash.xhtml: Added.
- 9:16 PM Changeset in webkit [139963] by
-
- 2 edits in trunk/Source/WebKit/chromium
Fix build break for Android webview.
https://bugs.webkit.org/show_bug.cgi?id=107072
Patch by Kristian Monsen <kristianm@google.com> on 2013-01-16
Reviewed by Steve Block.
Add extra guards when checking for OS=="Android" to make sure it is not included
for webview.
- WebKitUnitTests.gyp:
- 9:13 PM Changeset in webkit [139962] by
-
- 2 edits in trunk/Source/WebCore
[Refactoring] HTMLTextFormControlElement should use shadowHost instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=106533
Reviewed by Kent Tamura.
Since Node::shadowAncestorNode() is deprecated, we would like to use Node::shadowHost().
No new tests, simple refactoring.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange): Here, startPosition and endPosition is in ShadowDOM,
converting shadowAncestorNode to shadowHost is safe.
(WebCore::enclosingTextFormControl): Actually ASSERT in this method is wrong since shadowAncestorNode() does not
return NULL. This should be shadowHost().
- 8:58 PM Changeset in webkit [139961] by
-
- 4 edits in trunk
Make debug-safari --target-web-process work again
https://bugs.webkit.org/show_bug.cgi?id=107088
Reviewed by Anders Carlsson.
Source/WebKit2:
--target-web-process was made harder to use during recent refactoring
by requiring users to pass a -ui-process-name parameter in addition to
the -client-executable. Instead, we should conjure up that name from
the information we already have at our disposal.
- WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMainDelegate::getConnectionIdentifier):
Simplify by making the non-client-executable path use the base
class implementation.
(WebKit::WebProcessMainDelegate::getClientIdentifier):
Ditto.
(WebKit::WebProcessMainDelegate::getClientProcessName):
Added. Create a client process name (its actually not too important what it is, as it
is only used to show a name in Activity Monitor) from the passed in client executable
path.
Tools:
- Scripts/webkitdirs.pm:
(execMacWebKitAppForDebugging):
The shim is now called SecItemShim.
- 8:52 PM Changeset in webkit [139960] by
-
- 2 edits in trunk/Source/WebKit2
Fix crashes on the bots.
The WebKit LoaderStrategy for loading synchronously was only implemented
for the case where you have a network process. When you don't, we should
be using the base implementation.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously):
- 8:35 PM Changeset in webkit [139959] by
-
- 4 edits in trunk/Source/WebCore
Disable an ASSERT for the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=107087
Reviewed by Adam Barth.
Since tokenizing happens on the background thread, when the tree builder runs there isn't a valid tokenizer for which to check the state.
The background parser has minimal code to update its tokenizer's state properly.
No new tests because covered by existing fast/parser tests.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
(HTMLParserOptions):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processEndTag):
- 8:22 PM Changeset in webkit [139958] by
-
- 5 edits2 adds in trunk
Attr.ownerDocument should change if its parent's owner did
https://bugs.webkit.org/show_bug.cgi?id=97644
Reviewed by Darin Adler.
Source/WebCore:
moveTreeToNewScope() didn't traverse its Attr instances. But it should.
Test: fast/dom/Attr/parent-adopt-node.html
- dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::getExistingAttrs):
(WebCore):
- dom/ElementAttributeData.h:
(ElementAttributeData):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
LayoutTests:
- fast/dom/Attr/parent-adopt-node-expected.txt: Added.
- fast/dom/Attr/parent-adopt-node.html: Added.
- 8:00 PM Changeset in webkit [139957] by
-
- 4 edits in trunk/Tools
GCE build scripts don't take working directory into account when calling findzone.sh
https://bugs.webkit.org/show_bug.cgi?id=106962
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Adam Barth.
- EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
- EWSTools/GoogleComputeEngine/build-commit-queue.sh:
- EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
- 7:59 PM Changeset in webkit [139956] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177310.
- DEPS:
- 7:52 PM Changeset in webkit [139955] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to adjust the scale and scroll position after leaving fullscreen mode if there's
device rotation in fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=107085
Reviewed by George STaikos.
Also internally reviewed by Jacky Jiang.
We saved the scale and scroll position before entering full screen mode, so that we can restore
them after leaving fullscreen mode, because entering fullscreen mode automatically changes the
scale to make the video to fit to the viewport. But if there's device rotation during the fullscreen,
the scale and scroll position saved before may or may not apply anymore, we need to adjust the
scale and/or scroll position if needed to make sure no over-scale or over-scroll in the new orientation.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
- Api/WebPage_p.h:
(WebPagePrivate):
- 7:42 PM Changeset in webkit [139954] by
-
- 2 edits in trunk/Source/WebCore
Address tonyg's feedback on BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107086
Reviewed by Tony Gentilcore.
As requested in https://bugs.webkit.org/show_bug.cgi?id=107083#c5
- html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(TokenDelivery):
(WebCore::TokenDelivery::TokenDelivery):
(WebCore::TokenDelivery::execute):
- 7:36 PM Changeset in webkit [139953] by
-
- 5 edits in trunk/Source/WebCore
Introduce a method to build the tree from a CompactHTMLToken
https://bugs.webkit.org/show_bug.cgi?id=107082
Reviewed by Adam Barth.
No new tests because covered by existing fast/parser tests.
- html/parser/HTMLDocumentParser.cpp:
(WebCore):
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- html/parser/HTMLDocumentParser.h:
- html/parser/HTMLToken.h:
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
(AtomicMarkupTokenBase):
- 7:25 PM Changeset in webkit [139952] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix following r139918.
Add speech synthesis to include path and WebCore vcproj file.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreCommon.vsprops:
- 7:08 PM Changeset in webkit [139951] by
-
- 2 edits in trunk/Source/WebCore
Switch AudioDestinationChromium over to new createAudioDevice() method
https://bugs.webkit.org/show_bug.cgi?id=106816
Reviewed by James Robinson.
- platform/audio/chromium/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
- 6:55 PM Changeset in webkit [139950] by
-
- 9 edits2 adds in trunk/Source/WebCore
Introduce BackgroundHTMLParser for parsing HTML on a background thread
https://bugs.webkit.org/show_bug.cgi?id=107083
Reviewed by Eric Seidel.
This patch contains a basic version of an HTML parser that runs on a
background thread. The parser passes the majority of the tests in
fast/parser and a large number of the subtests in html5lib.
Notably absent from this early version of the parser is speculation
(which will eventually replace preload scanning) and atomization (which
we suspect will be important for performance). Our plan is to introduce
those elements in subsequent patches.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/BackgroundHTMLParser.cpp: Added.
(WebCore):
(WebCore::checkThatTokensAreSafeToSendToAnotherThread):
(WebCore::parserMap):
(WebCore::ParserMap::backgroundParsers):
(WebCore::ParserMap::mainThreadParsers):
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::append):
(WebCore::BackgroundHTMLParser::continueParsing):
(WebCore::BackgroundHTMLParser::finish):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(TokenDelivery):
(WebCore::TokenDelivery::execute):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):
(WebCore::BackgroundHTMLParser::createPartial):
(WebCore::BackgroundHTMLParser::stopPartial):
(WebCore::BackgroundHTMLParser::appendPartial):
(WebCore::BackgroundHTMLParser::continuePartial):
(WebCore::BackgroundHTMLParser::finishPartial):
- html/parser/BackgroundHTMLParser.h: Added.
(WebCore):
(BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::create):
(ParserMap):
(WebCore::ParserMap::identifierForParser):
- html/parser/HTMLDocumentParser.cpp:
(WebCore):
(WebCore::HTMLDocumentParser::didReceiveTokensFromBackgroundParser):
- html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):
- 6:32 PM Changeset in webkit [139949] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG 32_64 backend doesn't check for hasArrayStorage() in NewArrayWithSize
https://bugs.webkit.org/show_bug.cgi?id=107081
Reviewed by Michael Saboff.
This bug led to the 32_64 backend emitting contiguous allocation code to allocate
ArrayStorage arrays. This then led to all manner of heap corruption, since
subsequent array accesses would be accessing the contiguous array "as if" it was
an arraystorage array.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 6:26 PM Changeset in webkit [139948] by
-
- 2 edits in trunk/Source/WebKit2
Update Owners file.
- Owners:
- 6:25 PM Changeset in webkit [139947] by
-
- 4 edits in trunk/Source/WebKit2
Remove unused AddLoadInProgress message
https://bugs.webkit.org/show_bug.cgi?id=107077
Reviewed by Dan Bernstein.
Dead code is dead.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- 6:20 PM Changeset in webkit [139946] by
-
- 2 edits in trunk/Source/WebCore
[soup] Fix build warning in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=107063
Patch by Donghyun Kim <dhkim715@hotmail.com> on 2013-01-16
Reviewed by Martin Robinson.
The restartedCallback has unused parameter 'message',
remove the parameter name to fix 'unused parameter' build warning.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
- 6:18 PM Changeset in webkit [139945] by
-
- 8 edits2 adds in trunk/Source/WebCore
Introduce a CompactHTMLToken for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=107069
Reviewed by Adam Barth.
This class is used for transporting tokens from the parser thread to the main thread where they are fed to the tree builder.
No new tests because covered by existing fast/parser tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/CompactHTMLToken.cpp: Added.
(WebCore):
(WebCore::CompactHTMLToken::CompactHTMLToken):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):
- html/parser/CompactHTMLToken.h: Added.
(WebCore):
(CompactAttribute):
(WebCore::CompactAttribute::CompactAttribute):
(WebCore::CompactAttribute::name):
(WebCore::CompactAttribute::value):
(CompactHTMLToken):
(WebCore::CompactHTMLToken::type):
(WebCore::CompactHTMLToken::data):
(WebCore::CompactHTMLToken::selfClosing):
(WebCore::CompactHTMLToken::attributes):
(WebCore::CompactHTMLToken::publicIdentifier):
(WebCore::CompactHTMLToken::systemIdentifier):
- xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::data):
(MarkupTokenBase):
- 6:05 PM Changeset in webkit [139944] by
-
- 7 edits2 adds in trunk/Source/WebCore
Introduce HTMLParserThread to be able to parse on a background thread
https://bugs.webkit.org/show_bug.cgi?id=107071
Reviewed by Tony Gentilcore.
This patch introduces a simple thread class that we can use to parse
HTML. This patch is unlikely to be the final design because we'll
likely want to use libdispatch or some other platform-specific thread
pool. However, this implementation is enough to let us work on the
parser-specific aspects of this feature.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- html/parser/HTMLParserThread.cpp: Added.
(WebCore):
(WebCore::HTMLParserThread::HTMLParserThread):
(WebCore::HTMLParserThread::~HTMLParserThread):
(WebCore::HTMLParserThread::start):
(WebCore::HTMLParserThread::stop):
(WebCore::HTMLParserThread::shared):
(WebCore::HTMLParserThread::postTask):
(WebCore::HTMLParserThread::threadStart):
(WebCore::HTMLParserThread::runLoop):
- html/parser/HTMLParserThread.h: Added.
(WebCore):
(HTMLParserThread):
(WebCore::HTMLParserThread::create):
(WebCore::HTMLParserThread::threadId):
- 5:57 PM Changeset in webkit [139943] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when destroying a plug-in with pending URL requests
https://bugs.webkit.org/show_bug.cgi?id=107075
<rdar://problem/12513871>
Reviewed by Sam Weinig.
In PluginView::destroyPluginAndReset, make sure to cancel any outstanding URL requests since the PluginView
object will stay around and would otherwise start loading URLs from stopped plug-ins.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::start):
Assert that the plug-in is alive.
(WebKit::PluginView::destroyPluginAndReset):
Empty out the pending URL requests vector and stop the timer.
- 5:38 PM Changeset in webkit [139942] by
-
- 2 edits in trunk/Source/WebCore
WebCore::ScriptRunner::timerFired() is reported to crash.
https://bugs.webkit.org/show_bug.cgi?id=92211
Reviewed by Darin Adler.
This is a speculative fix to address some crash reports.
Here is my rough guess.
The crash report says there is a PendingScript instance whose m_element is null.
- It happens only if the instance is created through the default constructor,
- that could happen if m_pendingAsyncScripts doesn't contains matched PendingScript in ScriptRunner::notifyScriptReady(),
- that could happen when notifyScriptReady() is called more than once.
- It turns out that the call site, ScriptElement::notifyFinished(), could be called multiple times since it doesn't remove itself from the CachedResource, which is done separately in ScriptElement::execute().
- So if notifyFinished() is called before execute(), it could happen
This change added a guard to prevent notifyFinished() from being invoked multiple times.
We should watch if these crash reports disappear.
No new tests. I couldn't create any repro for this.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::notifyFinished):
- 5:36 PM Changeset in webkit [139941] by
-
- 2 edits in trunk/Source/WebCore
Fix mac build system warnings introduced by r139866
https://bugs.webkit.org/show_bug.cgi?id=107056
Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-16
Reviewed by Benjamin Poulain.
warning: no rule to process file '$(PROJECT_DIR)/css/CSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
warning: no rule to process file '$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSCSSSupportsRule.h' of type sourcecode.c.h for architecture x86_64
{JS,}CSSSupportsRule.h somehow ended up marked as sources in the XCode
project.
No new tests. Build warning fix.
- WebCore.xcodeproj/project.pbxproj:
- 5:32 PM Changeset in webkit [139940] by
-
- 3 edits in trunk/Source/WebCore
Merge RenderObjectChildList::appendChildNode and insertChildNode
https://bugs.webkit.org/show_bug.cgi?id=106392
Reviewed by Eric Seidel.
insertChildNode and appendChildNode are nearly identical methods and
we can combine them into insertChildNode and handle cases where the
renderer to insert before is null as if it was an append.
No new tests, just refactoring.
- rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h:
(RenderObjectChildList):
(WebCore::RenderObjectChildList::appendChildNode):
Now inline and delegates to insertChildNode.
- 5:21 PM Changeset in webkit [139939] by
-
- 2 edits in trunk/Source/WebCore
Cursor stops blinking after clicking on scrollbar
https://bugs.webkit.org/show_bug.cgi?id=106470
Reviewed by Ojan Vafai.
Restore the caret blinking when doing a mouseup on a
scrollbar so scrolling a textarea doesn't cause the
caret to freeze.
No new tests, there doesn't seem to be any way to test
cursor blinking.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
- 5:18 PM Changeset in webkit [139938] by
-
- 3 edits in trunk/Source/WebCore
Teach HTMLParserOptions about Settings::threadedHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107068
Reviewed by Tony Gentilcore.
We use this option to enable the threaded HTML parser at runtime.
- html/parser/HTMLParserOptions.cpp:
(WebCore::HTMLParserOptions::HTMLParserOptions):
- html/parser/HTMLParserOptions.h:
(HTMLParserOptions):
- 5:11 PM Changeset in webkit [139937] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] PageUIClientEfl should keep in sync with WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=107060
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-01-16
Reviewed by Benjamin Poulain.
Rearrange the order of functions in PageUIClientEfl.
Rename closePage() to close().
- UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::close):
- UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::close):
(WebKit::PageUIClientEfl::takeFocus):
(WebKit::PageUIClientEfl::focus):
(WebKit::PageUIClientEfl::unfocus):
(WebKit::PageUIClientEfl::getWindowFrame):
(WebKit::PageUIClientEfl::setWindowFrame):
(WebKit::PageUIClientEfl::createNewPage):
(WebKit::PageUIClientEfl::showColorPicker):
(WebKit::PageUIClientEfl::hideColorPicker):
- UIProcess/efl/PageUIClientEfl.h:
(PageUIClientEfl):
- 4:48 PM Changeset in webkit [139936] by
-
- 2 edits in trunk/Tools
start-queue.sh does not pass remaining parameters correctly
https://bugs.webkit.org/show_bug.cgi?id=107054
Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-16
Reviewed by Adam Barth.
start-queue.sh now passes all remaining params to the webkit-patch command.
Previously only one additional queue parameter could be sent.
- EWSTools/start-queue.sh:
- 4:45 PM Changeset in webkit [139935] by
-
- 22 edits2 copies1 add in trunk/Source
Synchronous XMLHTTPRequests need to go to the NetworkProcess.
<rdar://problem/12951765> and https://bugs.webkit.org/show_bug.cgi?id=106826
Reviewed by Sam Weinig and Alexey Proskuryakov.
Source/WebCore:
No new tests (No changes to any config that is currently tested)
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously): Consult the LoaderStrategy when strategies are
being used.
- loader/LoaderStrategy.cpp:
(WebCore::LoaderStrategy::loadResourceSynchronously): Defaults to using ResourceHandle directly.
- loader/LoaderStrategy.h:
Break out the StoredCredentials enum to a new header:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleTypes.h:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::loadResourceSynchronously): Entry point for WebCore to get
synchronous requests to the NetworkProcess.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad): Create a SyncNetworkResourceLoader
and schedule it.
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::scheduleSyncNetworkResourceLoader):
(WebKit::NetworkResourceLoadScheduler::servePendingRequestsForHost): Serve synchronous loaders
before async loaders.
- NetworkProcess/NetworkResourceLoadScheduler.h:
A class that encapsulates a synchronous load request and the CoreIPC reply to be made once it is complete:
- NetworkProcess/SyncNetworkResourceLoader.cpp: Added.
(WebKit::SyncNetworkResourceLoader::SyncNetworkResourceLoader):
(WebKit::SyncNetworkResourceLoader::start):
- NetworkProcess/SyncNetworkResourceLoader.h: Copied from Source/WebKit2/NetworkProcess/HostRecord.h.
(WebKit::SyncNetworkResourceLoader::create):
(WebKit::SyncNetworkResourceLoader::setIdentifier):
(WebKit::SyncNetworkResourceLoader::identifier):
(WebKit::SyncNetworkResourceLoader::loadParameters):
Add a second queue of sync loaders:
- NetworkProcess/HostRecord.h:
(WebKit::HostRecord::syncLoadersPending):
Add comments to explicitly spell out the current reliance on some messages that are currently synchronous:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::willSendRequest):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpace):
- WebKit2.xcodeproj/project.pbxproj:
- 4:37 PM Changeset in webkit [139934] by
-
- 2 edits in trunk/Source/WebCore
Explicitly set msvs_cygwin_shell to true for bison rule
https://bugs.webkit.org/show_bug.cgi?id=107058
Patch by Robert Iannucci <iannucci@chromium.org> on 2013-01-16
Reviewed by Tony Chang.
Currently, msvs_cygwin_shell is set to 1 by default. This patch
explicitly sets it on the actions which will break if msvs_cygwin_shell
were set to 0. This is in preparation for changing the default value of
msvs_cygwin_shell, which in turn is in preparation of the removal of
cygwin as a buld-system requirement.
Since this change will have no semantic effect, no new tests are
required.
A previous instance of this bug is here:
https://bugs.webkit.org/show_bug.cgi?id=106706
- WebCore.gyp/WebCore.gyp:
- 4:05 PM Changeset in webkit [139933] by
-
- 2 edits in trunk/Source/WebCore
Fix the warning for the exported Objective-C binding of DOMCSSSupportsRule
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-01-16
Rubber-stamped by Simon Fraser.
- WebCore.exp.in: r139866 exported the Objective-C class DOMCSSSupportsRule
without #ifdefing the symbol between its feature flag.
- 3:57 PM Changeset in webkit [139932] by
-
- 4 edits2 adds in trunk
Cues not rendered when they should be
https://bugs.webkit.org/show_bug.cgi?id=106943
Patch by Victor Carbune <vcarbune@chromium.org> on 2013-01-16
Reviewed by Eric Carlson.
Source/WebCore:
Forced rendering update, even if the active set of cues didn't change.
Test: media/track/track-cue-rendering-mode-changed.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): If exiting early,
update the cues rendered by the text track container.
(WebCore::HTMLMediaElement::textTrackModeChanged): Trigger update of the
re-checking the active cues and render the ones not yet on screen.
LayoutTests:
- media/track/track-cue-rendering-mode-changed-expected.txt: Added.
- media/track/track-cue-rendering-mode-changed.html: Added.
- media/video-controls-captions-expected.txt: Updated.
- 3:23 PM Changeset in webkit [139931] by
-
- 3 edits in trunk/Source/WebKit2
WebProcess should not access ~/Library/Caches/com.apple.WebProcess
https://bugs.webkit.org/show_bug.cgi?id=107055
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in: Remove the rule allowing access.
- WebProcess/mac/WebProcessMac.mm: (WebKit::WebProcess::platformInitializeWebProcess): Use a correct cache directory even if NetworkProcess is in use. Not all loading has moved to this process yet.
- 3:15 PM Changeset in webkit [139930] by
-
- 2 edits in trunk/Source/WebCore
Force a rebuild of RenderObject
Unreviewed. One bot is using old object file. Change RenderObject.cpp to force it
to build the file again.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-01-16
- rendering/RenderObject.cpp:
(WebCore::addLayers):
(WebCore::RenderObject::findNextLayer):
- 3:11 PM Changeset in webkit [139929] by
-
- 2 edits in trunk/Source/WebCore
IndexedDB: Possible null ScriptExecutionContext passed to callbacks during frame destruction
https://bugs.webkit.org/show_bug.cgi?id=107050
Reviewed by Tony Chang.
Temporary code to defend against null contexts. Will either refute a hypothesis, or we'll
need to make a more systemic fix elsewhere. Either way it will be removed in a few days.
We're unable to repro, but watching crash reports from users. One possible source is
that during page tear-down WorkerScriptController::controllerForContext() returns null
(there's a comment about that case) leading to a null context.
No new tests - this shouldn't be happening.
- Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::createIndex):
- 3:08 PM Changeset in webkit [139928] by
-
- 3 edits in trunk/Source/WebCore
Simplify validation and data copying in WebGLBuffer
https://bugs.webkit.org/show_bug.cgi?id=106975
Reviewed by Dean Jackson.
Re-landing after testing locally; was not able to reproduce the
crash seen once with the earlier patch.
No new tests; covered by existing tests. Ran WebGL layout tests and conformance tests.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferSubData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
Change signatures of associateBufferDataImpl and associateBufferSubDataImpl.
- 2:52 PM Changeset in webkit [139927] by
-
- 2 edits in trunk/Source/WebCore
Fix a crash when printing console messages to STDOUT.
https://bugs.webkit.org/show_bug.cgi?id=107039
Reviewed by Joseph Pecoraro.
- page/Console.cpp:
(WebCore::internalAddMessage): Don't release the RefPtr early. Also log the line number
and convert non-string arguments to strings when printing them.
- 2:39 PM Changeset in webkit [139926] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add missing sys/mman.h include on Mac
https://bugs.webkit.org/show_bug.cgi?id=98089
Patch by Jonathan Liu <net147@gmail.com> on 2013-01-16
Reviewed by Darin Adler.
The madvise function and MADV_FREE constant require sys/mman.h.
- jit/ExecutableAllocatorFixedVMPool.cpp:
- 2:31 PM Changeset in webkit [139925] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove bogus assert in GeolocationClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=105651
Patch by Joe Mason <jmason@rim.com> on 2013-01-16
Reviewed by Darin Adler.
GeolocationClientBlackBerry::cancelPermissionRequest contains an ASSERT that the origin is
in m_geolocationRequestMap. But it's perfectly valid for the origin to not be in the map -
for instance, if GeolocationClientBlackBerry::requestPermission returned immediately,
without putting it in the map, because geolocation was disabled. In this case the correct
thing to do is just return - there is nothing to be done to cancel the permission.
- WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::cancelPermissionRequest):
- 2:08 PM Changeset in webkit [139924] by
-
- 2 edits in trunk/Tools
check-webkit-style script cannot running in Chinese windows.
https://bugs.webkit.org/show_bug.cgi?id=87548
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-01-16
Reviewed by Darin Adler.
- Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo._win_version_tuple_from_cmd):
- 2:05 PM Changeset in webkit [139923] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r139914.
http://trac.webkit.org/changeset/139914
https://bugs.webkit.org/show_bug.cgi?id=106975
Caused crashes in compositing/visibility/visibility-simple-
webgl-layer.html
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferData):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
(WebCore::WebGLBuffer::associateBufferSubData):
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
- 1:58 PM Changeset in webkit [139922] by
-
- 3 edits in trunk/Source/WebCore
Monitor usage of unprefixed and prefixed DOM events for CSS Transitions.
https://bugs.webkit.org/show_bug.cgi?id=107004
Reviewed by Adam Barth.
Monitor the usage of transitionEnd events as well as
webkitTransitionEnd events so we can know in the future how much the
prefixed version is used to remove it becomes irrelevant.
No new tests : no behavior changes, we're just adding monitoring.
- dom/EventTarget.cpp:
(WebCore):
(WebCore::EventTarget::fireEventListeners):
- page/FeatureObserver.h:
- 1:52 PM Changeset in webkit [139921] by
-
- 2 edits in trunk/Source/WTF
Use GCC's implementation of atomicIncrement/Decrement on Mac
https://bugs.webkit.org/show_bug.cgi?id=106976
Reviewed by Filip Pizlo.
- wtf/Atomics.h:
GCC and LLVM have builtin for atomic ADD and SUB: sync_add_and_fetch,
sync_sub_and_fetch.
Using them let the compiler just generate the atomic operations inline
instead of generating a function call to LibC. It also simplify the
code a bit.
- 1:50 PM Changeset in webkit [139920] by
-
- 102 edits in trunk/Source/WebCore
Tighten RenderLayerModelObject subclass constructors to operate on ContainerNodes.
https://bugs.webkit.org/show_bug.cgi?id=107041
Reviewed by Simon Fraser.
In rendering code only Nodes that are not ContainerNodes are used by RenderText. Tighter typing is better in general.
It also enables better code generation (especially with Document* moving from Node to ContainerNode).
This patch tightens constuctors for better static type checking. It also overrides node() with a covariant ContainerNode* return type
version in RenderLayerModelObject. RenderObject::createObject() is tightened to take Element*.
This patch does not change Node* usage in non-construction code (expect for the node() override).
With some further work it should be possible to tighten most of the rendering tree to operate on Elements for even less branchiness.
- dom/Document.cpp:
(WebCore::Document::attach):
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderThumb::RenderSliderThumb):
(WebCore::RenderSliderContainer::RenderSliderContainer):
- html/shadow/SliderThumbElement.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
- rendering/RenderBlock.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::RenderBox):
- rendering/RenderBox.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::RenderBoxModelObject):
- rendering/RenderBoxModelObject.h:
- rendering/RenderButton.cpp:
(WebCore::RenderButton::RenderButton):
- rendering/RenderButton.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::RenderDetailsMarker):
- rendering/RenderDetailsMarker.h:
- rendering/RenderDialog.h:
(WebCore::RenderDialog::RenderDialog):
- rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::RenderFieldset):
- rendering/RenderFieldset.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::RenderFlexibleBox):
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
- rendering/RenderFlowThread.h:
- rendering/RenderFullScreen.cpp:
(RenderFullScreen::RenderFullScreen):
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::RenderGrid):
- rendering/RenderGrid.h:
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
- rendering/RenderImage.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
- rendering/RenderInline.h:
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::RenderLayerModelObject):
- rendering/RenderLayerModelObject.h:
(WebCore::RenderLayerModelObject::node):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::RenderListItem):
- rendering/RenderListItem.h:
- rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderTextTrackContainerElement::RenderTextTrackContainerElement):
- rendering/RenderMediaControlElements.h:
- rendering/RenderMultiColumnBlock.cpp:
(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):
- rendering/RenderMultiColumnSet.h:
(RenderMultiColumnSet):
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
- rendering/RenderNamedFlowThread.h:
(RenderNamedFlowThread):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createObject):
- rendering/RenderObject.h:
(RenderObject):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
- rendering/RenderRegion.h:
(RenderRegion):
- rendering/RenderRegionSet.cpp:
(WebCore::RenderRegionSet::RenderRegionSet):
- rendering/RenderRegionSet.h:
(RenderRegionSet):
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::RenderReplaced):
- rendering/RenderReplaced.h:
(RenderReplaced):
- rendering/RenderReplica.cpp:
(WebCore::RenderReplica::RenderReplica):
(WebCore::RenderReplica::~RenderReplica):
- rendering/RenderReplica.h:
- rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::RenderRubyAsInline):
(WebCore::RenderRubyAsBlock::RenderRubyAsBlock):
- rendering/RenderRuby.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::RenderRubyBase):
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::RenderRubyRun):
- rendering/RenderRubyRun.h:
(RenderRubyRun):
- rendering/RenderRubyText.cpp:
(WebCore::RenderRubyText::RenderRubyText):
- rendering/RenderRubyText.h:
(RenderRubyText):
- rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::RenderScrollbarPart):
- rendering/RenderScrollbarPart.h:
(RenderScrollbarPart):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::RenderSearchField):
- rendering/RenderSearchField.h:
(RenderSearchField):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
- rendering/RenderTable.h:
(RenderTable):
- rendering/RenderTableCaption.cpp:
(WebCore::RenderTableCaption::RenderTableCaption):
- rendering/RenderTableCaption.h:
(RenderTableCaption):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::RenderTableCell):
- rendering/RenderTableCell.h:
(RenderTableCell):
- rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::RenderTableCol):
- rendering/RenderTableCol.h:
(RenderTableCol):
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::RenderTableRow):
- rendering/RenderTableRow.h:
(RenderTableRow):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::RenderTableSection):
- rendering/RenderTableSection.h:
(RenderTableSection):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::RenderTextControl):
- rendering/RenderTextControl.h:
- rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::RenderTextControlMultiLine):
- rendering/RenderTextControlMultiLine.h:
(RenderTextControlMultiLine):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::RenderTextTrackCue):
- rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
- rendering/RenderView.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::RenderWidget):
- rendering/RenderWidget.h:
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::RenderMathMLBlock):
- rendering/mathml/RenderMathMLBlock.h:
(WebCore::RenderMathMLTable::RenderMathMLTable):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::RenderMathMLOperator):
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow):
- rendering/mathml/RenderMathMLRow.h:
(RenderMathMLRow):
(WebCore::RenderSVGInline::RenderSVGInline):
- rendering/svg/RenderSVGInline.h:
- rendering/svg/RenderSVGTSpan.cpp:
(WebCore::RenderSVGTSpan::RenderSVGTSpan):
- rendering/svg/RenderSVGTSpan.h:
- rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
- rendering/svg/RenderSVGTextPath.h:
- 1:47 PM Changeset in webkit [139919] by
-
- 5 edits1 delete in trunk/Source/WebKit2
Remove CoreIPCMessageKinds.h
https://bugs.webkit.org/show_bug.cgi?id=107048
Reviewed by Beth Dakin.
Use named IPC messages instead.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/CoreIPCMessageKinds.h: Removed.
- Platform/CoreIPC/MessageID.h:
(MessageID):
(CoreIPC::MessageID::stripMostSignificantBit):
(CoreIPC::MessageID::operator==):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::receiveSourceEventHandler):
- WebKit2.xcodeproj/project.pbxproj:
- 1:45 PM Changeset in webkit [139918] by
-
- 7 edits17 adds in trunk/Source/WebCore
Stub out WebSpeech synthesis
https://bugs.webkit.org/show_bug.cgi?id=106847
Reviewed by Adam Barth.
This adds in the necessary IDLs and stubs out the code for the WebSpeech
synthesis specification.
It does not turn on the feature in any platform, but it can be enabled
and built for Mac.
The feature flag is SPEECH_SYNTHESIS.
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- Modules/speech/DOMWindowSpeechSynthesis.cpp: Added.
(WebCore::DOMWindowSpeechSynthesis::DOMWindowSpeechSynthesis):
(WebCore::DOMWindowSpeechSynthesis::~DOMWindowSpeechSynthesis):
(WebCore::DOMWindowSpeechSynthesis::from):
(WebCore::DOMWindowSpeechSynthesis::speechSynthesis):
- Modules/speech/DOMWindowSpeechSynthesis.h: Added.
- Modules/speech/DOMWindowSpeechSynthesis.idl: Added.
- Modules/speech/SpeechSynthesis.cpp: Added.
(WebCore::SpeechSynthesis::create):
(WebCore::SpeechSynthesis::SpeechSynthesis):
- Modules/speech/SpeechSynthesis.h: Added.
(SpeechSynthesis):
(WebCore::SpeechSynthesis::getVoices):
- Modules/speech/SpeechSynthesis.idl: Added.
- Modules/speech/SpeechSynthesisEvent.cpp: Added.
(WebCore::SpeechSynthesisEvent::create):
(WebCore::SpeechSynthesisEvent::SpeechSynthesisEvent):
- Modules/speech/SpeechSynthesisEvent.h: Added.
(SpeechSynthesisEvent):
(WebCore::SpeechSynthesisEvent::charIndex):
(WebCore::SpeechSynthesisEvent::elapsedTime):
(WebCore::SpeechSynthesisEvent::name):
- Modules/speech/SpeechSynthesisEvent.idl: Added.
- Modules/speech/SpeechSynthesisUtterance.cpp: Added.
(WebCore::SpeechSynthesisUtterance::create):
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::scriptExecutionContext):
(WebCore::SpeechSynthesisUtterance::interfaceName):
- Modules/speech/SpeechSynthesisUtterance.h: Added.
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
- Modules/speech/SpeechSynthesisUtterance.idl: Added.
- Modules/speech/SpeechSynthesisVoice.cpp: Added.
(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):
- Modules/speech/SpeechSynthesisVoice.h: Added.
(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):
- Modules/speech/SpeechSynthesisVoice.idl: Added.
- Modules/speech/mac: Added.
- Modules/speech/mac/SpeechSynthesisMac.mm: Added.
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- dom/EventNames.in:
- dom/EventTargetFactory.in:
- 1:33 PM Changeset in webkit [139917] by
-
- 10 edits1 delete in trunk
Unreviewed, rolling out r139853.
http://trac.webkit.org/changeset/139853
https://bugs.webkit.org/show_bug.cgi?id=107049
Broke the ChromeOS ppapi_unittests (Requested by leviw on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-16
Source/WebCore:
- inspector/Inspector.json:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
- inspector/InspectorPageAgent.cpp:
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
LayoutTests:
- inspector-protocol/page/frameScheduledNavigation-expected.txt: Removed.
- inspector-protocol/page/frameScheduledNavigation.html: Removed.
- inspector-protocol/page/frameStartedLoading-expected.txt: Removed.
- inspector-protocol/page/frameStartedLoading.html: Removed.
- 1:28 PM BuildingGtk edited by
- Add libwebp-dev to the list of packages to install (diff)
- 1:23 PM Changeset in webkit [139916] by
-
- 2 edits in trunk
[CMake] Report actual values for feature configuration (instead of the default)
https://bugs.webkit.org/show_bug.cgi?id=107010
Reviewed by Laszlo Gombos.
- Source/cmake/WebKitFeatures.cmake:
- 1:18 PM Changeset in webkit [139915] by
-
- 2 edits1 move2 adds in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Adding results for platform/chromium/compositing/rounded-corners.html.
- platform/chromium-mac/platform/chromium/compositing/rounded-corners-expected.png: Added.
- platform/chromium-win/platform/chromium/compositing/rounded-corners-expected.png: Added.
- platform/chromium/TestExpectations:
- platform/chromium/platform/chromium/compositing/rounded-corners-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/compositing/rounded-corners-expected.txt.
- 1:09 PM Changeset in webkit [139914] by
-
- 3 edits in trunk/Source/WebCore
Simplify validation and data copying in WebGLBuffer
https://bugs.webkit.org/show_bug.cgi?id=106975
Reviewed by Dean Jackson.
No new tests; covered by existing tests. Ran WebGL layout tests and conformance tests.
- html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
Take (void*, int) pair instead of ArrayBuffer and offset. Simplifies code significantly.
(WebCore::WebGLBuffer::associateBufferSubData):
Pass down base pointers and sizes rather than ArrayBuffer and optional offset.
- html/canvas/WebGLBuffer.h:
(WebGLBuffer):
Change signatures of associateBufferDataImpl and associateBufferSubDataImpl.
- 12:58 PM Changeset in webkit [139913] by
-
- 2 edits in trunk/Tools
Delete an extraneous print statement.
https://bugs.webkit.org/show_bug.cgi?id=106562
Delete the extraneous print statement introduced in r139841.
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- 12:27 PM Changeset in webkit [139912] by
-
- 2 edits in trunk/Tools
Please reinstate --pixel
https://bugs.webkit.org/show_bug.cgi?id=101995
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-01-16
Reviewed by Dirk Pranke.
Add the '--pixel' and '--no-pixel' options for NRWT as aliases for
the '--pixel-tests' (or '-p') and '--no-pixel-tests' options respectively.
Some developers are still used to these options that were available in the ORWT.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 12:25 PM Changeset in webkit [139911] by
-
- 10 edits2 adds in trunk
inconsistency in drawImage with target rect negative dimensions.
https://bugs.webkit.org/show_bug.cgi?id=100026
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-16
Reviewed by Dean Jackson.
PerformanceTests:
Create a drawImage performance test. There is no significative change
in performance: 27144.6851528 runs/s without the patch; 27153.517612
runs/s with the patch. Test is currently skipped.
- Canvas/drawimage.html: Added.
- Skipped:
Source/WebCore:
Remove -1, -1 special case in drawImage and drawImageBuffer. Replace
all -1 -1 arguments calls to with the correct rectangle dimensions.
Remove FloatRect(0, 0, -1, -1) default argument for srcRect, and
instead, add new overloaded functions to create a FloatRect from image
size.
Replace -1 -1 arguments calls in FEComposite::platformApplySoftware
with correct rectangle dimensions.
Replace ImageGStreamer rect method (which may return -1 -1 rectangle)
with cropRect method, and make caller check for rectangle emptiness.
- fast/canvas/drawImage-with-negative-source-destination-expected.txt:
- fast/canvas/drawImage-with-negative-source-destination.js:
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::platformApplySoftware):
- platform/graphics/gstreamer/ImageGStreamer.h:
(WebCore::ImageGStreamer::rect):
LayoutTests:
Add a drawImage check for a destination rectangle with -1px
width/height. When drawing to (1, 1, -1, -1) rectangle, first
(top-left) pixel should have been and been the only one drawn into.
- fast/canvas/drawImage-with-negative-source-destination-expected.txt:
- fast/canvas/drawImage-with-negative-source-destination.js:
- 12:12 PM Changeset in webkit [139910] by
-
- 17 edits in tags/Safari-537.26.1/Source
Merged r139822. <rdar://problem/12843164>
- 12:04 PM Changeset in webkit [139909] by
-
- 4 edits in tags/Safari-537.26.1/Source
Versioning.
- 12:00 PM Changeset in webkit [139908] by
-
- 7 edits in trunk/Source/WebCore
Allow PaintInfo to carry all PaintBehavior flags
https://bugs.webkit.org/show_bug.cgi?id=106980
Reviewed by Sam Weinig.
PaintInfo has a single boolean for forceBlackText, but I'll be adding additional
paint behaviors that I'd like to access from PaintInfo, so it makes sense for
PaintInfo to just include the set of PaintBehavior flags.
Also add default values in the constructor arguments for rarely used parameters.
No behavior change, no tests.
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint): Use the forceBlackText() function.
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint): Call forceBlackText().
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo): Pass PaintBehavior rather than a forceBlackText boolean.
(WebCore::PaintInfo::forceBlackText): Return true if the behavior flags contain PaintBehaviorForceBlackText.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended): Pass PaintBehaviorForceBlackText instead of 'true'
when painting for background-clip: text.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents): Pass PaintBehaviorNormal where we used to pass 'false',
and omit default 0 parameters.
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::renderSubtreeToImageBuffer): PaintBehaviorNormal and remove default params.
- 11:58 AM Changeset in webkit [139907] by
-
- 1 copy in tags/Safari-537.26.1
New Tag.
- 11:57 AM Changeset in webkit [139906] by
-
- 17 edits in tags/Safari-537.26/Source
Rollout r139905.
- 11:49 AM Changeset in webkit [139905] by
-
- 17 edits in tags/Safari-537.26/Source
Merge 139822. <rdar://problem/12843164>
- 11:48 AM Changeset in webkit [139904] by
-
- 5 edits in trunk
LinkHighlight should use touch adjustment to match active state on GestureTapDown.
https://bugs.webkit.org/show_bug.cgi?id=107032
Reviewed by Adam Barth.
Source/WebKit/chromium:
LinkHighlight node selection should produce results that match the node marked
active during GestureTapDown.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::bestTouchLinkNode):
- tests/LinkHighlightTest.cpp:
(WebCore::TEST):
LayoutTests:
- platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-multi-line.html:
- 11:26 AM Changeset in webkit [139903] by
-
- 2 edits in trunk/Source/WebCore
Add a missing #if to fix the Mac build sans ENABLE_CSS_FILTERS.
Rubber-stamped by Simon Fraser.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::cloneLayer):
- 11:25 AM Changeset in webkit [139902] by
-
- 4 edits in trunk
Remove --shark* support from sunspider/run-sunspider now that Shark is dead
https://bugs.webkit.org/show_bug.cgi?id=99512
Reviewed by Darin Adler.
PerformanceTests/SunSpider:
I tried to use --instruments, but that also seems broken (in the same way before/after this patch).
- sunspider:
(runTestsOnce):
Tools:
- Scripts/run-sunspider:
- 11:23 AM Changeset in webkit [139901] by
-
- 1 edit2 deletes in trunk/Tools
Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
https://bugs.webkit.org/show_bug.cgi?id=106036
Reviewed by Darin Adler.
- Scripts/webkitpy/webkitpy.pyproj: Removed.
- Scripts/webkitpy/webkitpy.sln: Removed.
- 11:21 AM Changeset in webkit [139900] by
-
- 34 edits in trunk/Source
[V8] Make a creationContext parameter of toV8() mandatory
https://bugs.webkit.org/show_bug.cgi?id=107020
Reviewed by Adam Barth.
Source/WebCore:
Currently a creationContext parameter of toV8() is optional:
Handle<Value> toV8(..., Handle<Object> creationContext = Handle<Object>(), ...) {
...;
}
On the other hand, looking at the implementation of
V8WrapperInstantiationScope:
explicit V8WrapperInstantiationScope(v8::Handle<v8::Object> creationContext)
: m_didEnterContext(false)
, m_context(v8::Context::GetCurrent())
{
if (creationContext.IsEmpty()) We do nothing for this case!
return;
v8::Handle<v8::Context> contextForWrapper = creationContext->CreationContext();
if (contextForWrapper == m_context)
return;
m_context = v8::Local<v8::Context>::New(contextForWrapper);
m_didEnterContext = true;
m_context->Enter();
}
we're assuming that a creationContext parameter is passed
to toV8() when a creationContext exists. In other words,
if we forget to pass a creationContext parameter, we will
end up with creating an object on the current context, which
is wrong. To avoid the mistake, we should make the
creationContext parameter mandatory. When we really do not
have a creationContext, we can pass Handle<Object>() explicitly.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8):
- bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
- bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
- bindings/v8/ScriptController.cpp:
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
- bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
- bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
- bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::getReceiverObject):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentProperty):
- bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
- bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
- bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::getReceiverObject):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
- css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
- testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):
Source/WebKit/chromium:
We pass Handle<Object>() to a creationContext parameter of
toV8() when we do not have a creationContext.
No tests. No change in behavior.
- src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::windowObjectCleared):
- src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
- src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):
- 11:19 AM Changeset in webkit [139899] by
-
- 18 edits in trunk/Source
Add a Setting to disable QTKit media engine.
https://bugs.webkit.org/show_bug.cgi?id=106972
Reviewed by Eric Carlson.
Source/WebCore:
Allow the MediaPlayerPrivateQTKit engine to be disabled by adding a
runtime setting to Settings. Make the setting 'live' by requerying the
installed media engines when the setting changes.
- WebCore.exp.in: Add new symbols to export list.
- page/Settings.cpp: Add new gQTKitEnabled global.
(WebCore::Settings::setAVFoundationEnabled): Requery media engines.
(WebCore::Settings::setQTKitEnabled): Ditto. Setter for global setting variable.
- page/Settings.h:
(WebCore::Settings::isQTKitEnabled): Getter for same.
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Check isQTKitEnabled() before adding
MediaPlayerPrivateQTKit engine.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requeryMediaEngines): Pass through to MediaPlayer.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Take an optional requery options parameter.
(WebCore::MediaPlayer::requeryMediaEngines): Pass through to installedMediaEngines().
- platform/graphics/MediaPlayer.h:
Source/WebKit/mac:
Add WebKit API to set QTKit enabled setting from user defaults.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set WebCore settings based on user defaults.
(-[WebPreferences setQTKitEnabled:]): Pass through to WebCore.
(-[WebPreferences isQTKitEnabled]): Ditto.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Synchronize WebKit/WebCore settings.
Source/WebKit2:
Add a WebKit2 API to access WebCore QTKitEnabled settings.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetQTKitEnabled): Pass through to WebCore.
(WKPreferencesGetQTKitEnabled): Ditto.
- UIProcess/API/C/WKPreferences.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Synchronize WebKit2/WebCore settings.
- 11:07 AM Changeset in webkit [139898] by
-
- 6 edits in branches/chromium/1364
Merge 138808
Existence of window.Touch can break websites mobile device detection
https://bugs.webkit.org/show_bug.cgi?id=106071
Source/WebCore:
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
- page/DOMWindow.idl:
LayoutTests:
Revert http://trac.webkit.org/changeset/135562 for now while I work
on a slightly safer version.
Patch by Rick Byers <rbyers@chromium.org> on 2013-01-04
Reviewed by Ojan Vafai.
- fast/events/touch/document-create-touch-list-expected.txt:
- fast/events/touch/script-tests/document-create-touch-list.js:
- platform/efl/fast/js/global-constructors-expected.txt:
- platform/qt-5.0/fast/js/global-constructors-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
TBR=rbyers@chromium.org
Review URL: https://codereview.chromium.org/11970016
- 11:04 AM Changeset in webkit [139897] by
-
- 4 edits2 copies in trunk/Source/WebKit/chromium
[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
https://bugs.webkit.org/show_bug.cgi?id=106863
Reviewed by Adam Barth.
These are not being moved into the new top-level Platform
directory, so into public they go.
- WebKit.gyp:
- public/WebArrayBufferView.h: Added.
(v8):
(WebKit):
(WebArrayBufferView):
(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):
- public/WebSerializedScriptValue.h: Added.
(v8):
(WebKit):
(WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::operator=):
(WebKit::WebSerializedScriptValue::isNull):
- public/platform/WebArrayBufferView.h:
- public/platform/WebSerializedScriptValue.h:
- 10:44 AM Changeset in webkit [139896] by
-
- 5 edits in trunk/Source/WebCore
[gstreamer] Some media tests occasionally crash with gstreamer 1.0 backend
https://bugs.webkit.org/show_bug.cgi?id=106551
Reviewed by Philippe Normand.
ImageGStreamerCairo was passing mapped memory to
cairo_image_surface_create_for_data() and then unmapping it straight
away even though the cairo_surface_t is still used. The cairo
documentation states:
"The output buffer must be kept around until the cairo_surface_t is
destroyed or cairo_surface_finish() is called on the surface."
This patch keeps the GstBuffer memory mapped until the ImageGStreamer
is destroyed so that the internal cairo_surface_t stays valid while
avoiding copying the image data.
No new tests, already covered by existing tests.
- platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstBuffer):
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF): Add support for using GRefPtr with GstBuffer.
- platform/graphics/gstreamer/ImageGStreamer.h:
(ImageGStreamer):
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
- 10:37 AM Changeset in webkit [139895] by
-
- 5 edits in trunk
[Chromium] Remove hardcoded chromium_*.jar in gyp files
https://bugs.webkit.org/show_bug.cgi?id=104049
Patch by Chris Hopman <cjhopman@chromium.org> on 2013-01-16
Reviewed by Eric Seidel.
Targets with dependencies (direct/indirect) on a java target receive
the chromium_*.jar paths in the variable input_jars_paths. Targets
should use that rather than hardcoding where they think the jar will
be. These can be passed directly to ant as INPUT_JARS_PATHS rather
than as --jars to generate_native_test.py.
Source/WebKit/chromium:
- WebKitUnitTests.gyp:
Tools:
- DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
- TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
- 10:32 AM Changeset in webkit [139894] by
-
- 2 edits in trunk/Source/WebCore
Use SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
https://bugs.webkit.org/show_bug.cgi?id=107016
Reviewed by James Robinson.
No new tests. existing tests exercise this code.
The default constructor is being deprecated, so this change is also part of that effort,
though it is a perf-improvement regardless, since we avoid making a new (temp) matrix.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
- 10:32 AM Changeset in webkit [139893] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Marking several tests as crashing on Debug builds following
r139853.
- platform/chromium/TestExpectations:
- 10:23 AM Changeset in webkit [139892] by
-
- 7 edits in trunk/LayoutTests
Unreveiwed gardening. Updating expectations following r139865.
- platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
- 10:02 AM Changeset in webkit [139891] by
-
- 4 edits in trunk/Source/WebCore
RenderListMarker::computePreferredLogicalWidth should not be public
https://bugs.webkit.org/show_bug.cgi?id=106956
Reviewed by Tony Chang.
RenderListItem was calling computePreferredLogicalWidths for the side
effects of updating the marker content and margins. Instead, call
updateMarginsAndContent directly.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
The isImage() codepath never calls computePreferredLogicalWidths, so we need to make
sure the content and margins are updated.
(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMarginsAndContent):
- rendering/RenderListMarker.h:
- 10:00 AM Changeset in webkit [139890] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931
Patch by Claudio Saavedra <Claudio Saavedra> on 2013-01-16
Reviewed by Martin Robinson.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): Move the NULL-safeguard to a
place where it actually makes sense.
- 9:49 AM Changeset in webkit [139889] by
-
- 2 edits in trunk/Source/WebCore
West-panning cursor does not match resize cursor, unlike all other directions
https://bugs.webkit.org/show_bug.cgi?id=89405
Patch by Avi Drissman <avi@google.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.
Existing manual tests.
- platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):
- 9:44 AM Changeset in webkit [139888] by
-
- 10 edits2 copies in trunk/Source/WebKit2
Groundwork to enable process suppression by default on Mac
https://bugs.webkit.org/show_bug.cgi?id=106513
Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.
Process suppression has so far been controlled by a user default and
disabled by default. This patch provides the groundwork to enable it by
default and adds a private API to enable/disable it on a per-context
basis.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Add comment about
initilization of application occlusion state.
- UIProcess/API/C/mac/WKContextPrivateMac.cpp: Added.
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
Add private API to enable/disable process suppression on a per-context
basis.
- UIProcess/API/C/mac/WKContextPrivateMac.h: Added.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Check if owning
context has process suppression enabled before updating application
occlusion state.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching): Ditto.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Check if
process suppression is enabled for global child processes before
updating application occlusion state.
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Ditto.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::create): Remove call to
initializeProcessSuppressionSupport, since platformInitialize has been
modified to perform initialization.
(WebKit::WebContext::WebContext): Initialize new member variable
m_processSuppressionEnabled to false.
- UIProcess/WebContext.h:
(WebKit::WebContext::processSuppressionEnabled): Remove "Support"
from the method name.
- UIProcess/mac/WebContextMac.mm:
(WebKit::updateGlobalChildProcessesApplicationOcclusionState):
(WebKit::applicationOcclusionStateChanged): Update the application
occlusion state of child processes having process suppresion enabled.
(WebKit::applicationBecameVisible):
(WebKit::applicationBecameOccluded):
Simplify by moving code to applicationOcclusionStateChanged.
(WebKit::registerOcclusionNotificationHandlers): Fix typos.
(WebKit::unregisterOcclusionNotificationHandlers): Add
method to unregister occlusion notification handlers when no context
has process suppression enabled.
(WebKit::enableOcclusionNotifications):
(WebKit::disableOcclusionNotifications):
(WebKit::enableProcessSuppressionForGlobalChildProcesses):
(WebKit::disableProcessSuppressionForGlobalChildProcesses):
(WebKit::processSuppressionIsEnabledForAnyContext):
(WebKit::processSuppressionIsEnabledForAllContexts):
(WebKit::WebContext::platformInitialize): Disable process suppression
for global child processes since process suppression is disabled for a
context on construction.
(WebKit::WebContext::setProcessSuppressionEnabled):
(WebKit::WebContext::updateChildProcessesApplicationOcclusionState):
(WebKit::WebContext::applicationIsOccluded):
(WebKit::WebContext::processSuppressionEnabledForGlobalChildProcesses):
(WebKit::WebContext::processSuppressionEnabledChanged): Update child
processes application occlusion state, enable/disable occlusion
notifications and enable/disable process suppression for global child
processes.
- WebKit2.xcodeproj/project.pbxproj:
- 8:56 AM Changeset in webkit [139887] by
-
- 5 edits in trunk
Web Inspector: array grouping does not work for float number keys
https://bugs.webkit.org/show_bug.cgi?id=106998
Reviewed by Pavel Feldman.
Source/WebCore:
Now we do the array index check according to the ECMAScript 5, section 15.4:
"A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 232-1."
- inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):
LayoutTests:
- inspector/console/console-big-array-expected.txt:
- inspector/console/console-big-array.html:
- 8:54 AM Changeset in webkit [139886] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: Show formatted content of JSON request
https://bugs.webkit.org/show_bug.cgi?id=106900
Patch by Sergey Ryazanov <serya@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
"Request payload" section showed raw content for POST requests.
This change show it in structured format if it's JSON parsable.
Raw format is also available.
- inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshQueryString):
(WebInspector.RequestHeadersView.prototype._refreshFormData):
(WebInspector.RequestHeadersView.prototype.toggleViewSource):
(WebInspector.RequestHeadersView.prototype._refreshParams):
- 8:48 AM Changeset in webkit [139885] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: UISourceCode scriptFile / styleFile should be reset on navigation (debugger or css model reset).
https://bugs.webkit.org/show_bug.cgi?id=107008
Reviewed by Pavel Feldman.
ScriptFiles and styleFiles are now reset and disposed on UISourceCodes on corresponding models reset.
StyleSourceMapping now tries to setup mapping for newly added resource as well as for uiSourceCodes previously.
- inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._mainFrameCreatedOrNavigated):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._unbindUISourceCodeFromScripts):
(WebInspector.ResourceScriptMapping.prototype._initialize):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):
(WebInspector.ResourceScriptFile.prototype.dispose):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
- inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._debuggerReset):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StylesSourceMapping.prototype._initialize):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleFile.prototype.dispose):
- 8:26 AM Changeset in webkit [139884] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552
Reverting 139877. It made a couple of API tests fail.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient):
(_WebKitWebSrcPrivate):
(webKitWebSrcFinalize):
(webKitWebSrcStop):
(StreamingClient::didReceiveData):
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):
- 8:00 AM Changeset in webkit [139883] by
-
- 5 edits in trunk
Web Inspector: cookies with empty value are parsed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=107012
Reviewed by Pavel Feldman.
Source/WebCore:
Require cookie value to be a string, not a non-empty string, before
employing legacy compatibility hack of treating bare token as value
for the cookie with an empty name.
- inspector/front-end/CookieParser.js:
(WebInspector.CookieParser.prototype._addCookie):
LayoutTests:
- inspector/cookie-parser-expected.txt:
- inspector/cookie-parser.html:
- 7:35 AM Changeset in webkit [139882] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed EFL build fix after r139877.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferDataPointer): Add const modifier to webkitGstMapInfoQuarkString.
- 7:26 AM Changeset in webkit [139881] by
-
- 3 edits in trunk/LayoutTests
Web Inspector: create helper InspectorTest method to dump editor HTML
https://bugs.webkit.org/show_bug.cgi?id=107007
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
Add helper method to dump textEditor HTML.
- inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.dumpEditorHTML): Added.
- inspector/editor/text-editor-highlight-regexp.html:
- 7:20 AM Changeset in webkit [139880] by
-
- 5 edits in trunk
Web Inspector: [Extensions API] remove inspectedWindow.onReset event
https://bugs.webkit.org/show_bug.cgi?id=107009
Reviewed by Vsevolod Vlasov.
Source/WebCore:
- inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.InspectorExtensionAPI):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.initExtensions):
LayoutTests:
- inspector/extensions/extensions-api-expected.txt: removed webInspector.onReset.
- 7:13 AM Changeset in webkit [139879] by
-
- 5 edits in trunk
Web Inspector: fix text-editor-highlight-regexp test
https://bugs.webkit.org/show_bug.cgi?id=107006
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Source/WebCore:
Use 'height: 100%' instead of pixel values on highlight spans to bring in some platform independency in test expectations.
No new tests: no changes in behaviour.
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
- inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.webkit-line-content):
LayoutTests:
Fixing test expectations: no more height style.
- inspector/editor/text-editor-highlight-regexp-expected.txt:
- 7:06 AM Changeset in webkit [139878] by
-
- 6 edits in trunk/Source
[Qt] Use the shared HistoryItem serialization for QWebHistory
https://bugs.webkit.org/show_bug.cgi?id=106671
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
This allows a few things missing from the previous serialization code
to function while using commonly maintained code:
- The itemSequenceNumber and documentSequenceNumber that were needed to properly restore same-document navigations
- The form data
- The navigation hierarchy mapping the frame tree
- history/HistoryItem.h:
(HistoryItem):
- history/qt/HistoryItemQt.cpp:
(QDataStreamCoder):
(WebCore):
(WebCore::QDataStreamCoder::QDataStreamCoder):
(WebCore::QDataStreamCoder::encodeBytes):
(WebCore::QDataStreamCoder::encodeBool):
(WebCore::QDataStreamCoder::encodeUInt32):
(WebCore::QDataStreamCoder::encodeUInt64):
(WebCore::QDataStreamCoder::encodeInt32):
(WebCore::QDataStreamCoder::encodeInt64):
(WebCore::QDataStreamCoder::encodeFloat):
(WebCore::QDataStreamCoder::encodeDouble):
(WebCore::QDataStreamCoder::encodeString):
(WebCore::QDataStreamCoder::decodeBytes):
(WebCore::QDataStreamCoder::decodeBool):
(WebCore::QDataStreamCoder::decodeUInt32):
(WebCore::QDataStreamCoder::decodeUInt64):
(WebCore::QDataStreamCoder::decodeInt32):
(WebCore::QDataStreamCoder::decodeInt64):
(WebCore::QDataStreamCoder::decodeFloat):
(WebCore::QDataStreamCoder::decodeDouble):
(WebCore::QDataStreamCoder::decodeString):
(WebCore::HistoryItem::restoreState):
(WebCore::WebCore::HistoryItem::saveState):
Source/WebKit/qt:
Bump the serialization version and change the code to abort the
restore of a previous stream version rather than trying to keep the
support of restoring previous versions. This is mainly to simplify
things given that HistoryItem itself aborts in that case.
- Api/qwebhistory.cpp:
(operator<<):
(operator>>):
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::serialize_2): Modify the test to cover same-document navigations.
(tst_QWebHistory::restoreIncompatibleVersion1): Add a previous version
hard-coded stream to verify that the deserialization doesn't hang or
crash.
- 6:15 AM Changeset in webkit [139877] by
-
- 7 edits in trunk/Source/WebCore
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-01-15
Reviewed by Philippe Normand.
Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.
No behaviour change, covered by existing tests.
- platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.
- platform/graphics/gstreamer/GStreamerVersioning.h:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
- platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.
- 5:55 AM Changeset in webkit [139876] by
-
- 5 edits in trunk/Source
[Qt] Crash in WebCore::CachedFrame::destroy
https://bugs.webkit.org/show_bug.cgi?id=104525
Reviewed by Adam Barth.
Source/WebCore:
Add an assert to increase the chances of catching this crash
early on in the future.
- dom/Document.cpp:
(WebCore::Document::takeDOMWindowFrom):
Source/WebKit/qt:
Remove the call to HistoryController::setCurrentItem which is ultimately
causing the initial empty document of a page to be added to the page cache.
This re-introduce the bug that was fixed by this line, which will be
properly fixed in a follow-up patch.
- Api/qwebhistory.cpp:
(operator>>):
- tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::saveAndRestore_crash_4): Cover the crash.
- 5:50 AM Changeset in webkit [139875] by
-
- 8 edits in trunk/Tools
[chromium] move setMockDeviceOrientation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106895
Patch by Dan Carney <dcarney@google.com> on 2013-01-16
Reviewed by Jochen Eisinger.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setDeviceOrientation):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceOrientation):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 5:30 AM QtWebKitGardening edited by
- Add community support section (diff)
- 5:17 AM Changeset in webkit [139874] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Updating or removing a few stale expectations.
Adding two failure expectations for MicroData tests that are
failing after r139673.
- platform/gtk/TestExpectations:
- 5:11 AM Changeset in webkit [139873] by
-
- 6 edits in trunk/Source/WebCore
Web Inspector: fix Сlosure warnings in devTools front-end
https://bugs.webkit.org/show_bug.cgi?id=106993
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Add missing annotations and rename Element.remove() method to avoid collision with HTMLSelectElement.remove() method.
No new tests: no change in behaviour.
- inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.getChildNodes):
- inspector/front-end/DOMExtension.js:
(Element.prototype.removeSelf):
(removeSubsequentNodes):
- inspector/front-end/DefaultTextEditor.js:
- inspector/front-end/SettingsScreen.js:
(WebInspector.OverridesSettingsTab):
- inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer):
- 4:41 AM Changeset in webkit [139872] by
-
- 8 edits in trunk/Tools
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
- DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
(WebTestRunner::WebTestDelegate::setFocus):
(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
(WebTestRunner::WebTestDelegate::pathToLocalResource):
(WebTestRunner::WebTestDelegate::setLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
(WebTestRunner):
(WebTestRunner::TestRunner::setWindowIsKey):
(WebTestRunner::TestRunner::pathToLocalResource):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::setPOSIXLocale):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::taskList):
(TestRunner):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::setFocus):
(WebViewHost::setAcceptAllCookies):
(WebViewHost::pathToLocalResource):
(WebViewHost::setLocale):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 4:16 AM Changeset in webkit [139871] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: fix backward compatibility issues with Element.remove() method
https://bugs.webkit.org/show_bug.cgi?id=106996
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.
Add javascript implementations for CharacterData.prototype.remove and DocumentType.prototype.remove.
No new tests: no change in behaviour.
- inspector/front-end/DOMExtension.js:
- 4:13 AM Changeset in webkit [139870] by
-
- 2 edits in trunk/Source/WebCore
GraphicsSurfaceGLX is leaking an XWindow
https://bugs.webkit.org/show_bug.cgi?id=107002
The XWindow created as a backing surface for
the GraphicsSurfaceGLX needs to be destroyed
together with the GraphicsSurface.
Reviewed by Noam Rosenthal.
- platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::clear):
- 4:02 AM Changeset in webkit [139869] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Marking compositing/layer-creation/overlap-animation-container as failure
after it started failing in r139794, might just need a rebaseline but first let's have
someone familiar with AC look at it.
- platform/efl/TestExpectations:
- 4:00 AM Changeset in webkit [139868] by
-
- 2 edits in trunk/Tools
[GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769
Reviewed by Martin Robinson.
Return an empty array instead of "" in
jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
will not be recognized as a valid command when the returned array
is directly passed to perl's system() call.
- Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
- 3:51 AM Changeset in webkit [139867] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Doesn't build with GCC 4.7+
https://bugs.webkit.org/show_bug.cgi?id=106999
Reviewed by Csaba Osztrogonác.
Correct GNU_C_MINOR macro to GNUC_MINOR.
- src/compiler/preprocessor/ExpressionParser.y:
- 3:30 AM Changeset in webkit [139866] by
-
- 37 edits5 adds in trunk
Implement CSSSupportsRule
https://bugs.webkit.org/show_bug.cgi?id=104822
Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-16
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
http://dev.w3.org/csswg/css3-conditional/#the-csssupportsrule-interface
Right now, @supports is not implemented as a proper CSSRule. Apart from
the CSSOM implications it gives wrong results when, for instance, an
@supports rule is nested inside a @media rule.
Test: css3/supports-cssom.html
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
Add CSSSupportsRule.* and associated files.
- bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
- bindings/objc/DOMCSS.mm:
(kitClass):
- bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
Create the correct wrappers for the rule.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
- css/CSSParser.h:
Create the supports rule when parsing and add it where it corresponds,
instead of directly adding the child rules to the stylesheet.
- css/CSSPropertySourceData.h:
- css/CSSRule.h:
- css/CSSRule.idl:
Add SUPPORTS_RULE type to enums.
- css/CSSSupportsRule.cpp: Added.
(WebCore::CSSSupportsRule::CSSSupportsRule):
(WebCore::CSSSupportsRule::~CSSSupportsRule):
(WebCore::CSSSupportsRule::cssText):
(WebCore::CSSSupportsRule::conditionText):
- css/CSSSupportsRule.h: Added.
(WebCore::CSSSupportsRule::create):
- css/CSSSupportsRule.idl: Added.
DOM interface.
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
Add rules included in the @supports rule.
- css/StyleResolver.cpp:
(WebCore::collectCSSOMWrappers):
Collect CSSSupportsRule wrappers.
- css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleSupports::StyleRuleSupports):
- css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::isSupportsRule):
(StyleRuleSupports):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleSupports::conditionText):
(WebCore::StyleRuleSupports::conditionIsSupported):
(WebCore::StyleRuleSupports::copy):
(WebCore::toStyleRuleSupports):
New subclass of StyleRuleBlock: StyleRuleSupports.
- css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
- inspector/InspectorStyleSheet.cpp:
(flattenSourceData):
(WebCore::asCSSRuleList):
Handle @supports rules where needed.
LayoutTests:
- css3/supports-cssom-expected.txt: Added.
- css3/supports-cssom.html: Added.
- css3/supports-expected.txt:
- css3/supports.html:
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 3:04 AM Changeset in webkit [139865] by
-
- 7 edits2 adds in trunk
INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing appearance
https://bugs.webkit.org/show_bug.cgi?id=106983
Reviewed by Kentaro Hara.
Source/WebCore:
For example, we show a read-only hour field and a read-only minutes
field for <input type=time min="17:00" step=86400> because the step
value is 24 hours and the hour field can be only 17. However, we need to
provide a way to clear the value of the time field in such case. We
shouldn't make the hour field read-only if no other fields are editable.
- We don't make hour fields read-only for input[type=time].
- We make hour fields read-only for input[type=datetime-local] only if year, month, or day field is editable. e.g. <input type=datetime-local min=2013-01-16T17:00 step=86400>:
The hour field is read-only, and year/month/day fields are editable.
<input type=datetime-local min=2013-01-16T17:00 max=2013-01-16T18:00 step=86400>:
The hour field is editable, and year/month/day fields are read-only.
Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
- html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Declare new functions.
(WebCore::DateTimeEditBuilder::getRangeOfDayOfMonthField):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldReadOnly):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
If the type is "time", we don't make hour fields read-only.
Otherwise, we don't make hour fields read-only if year/month/day fields
are read-only. Note that we don't need to check read-only status of year
and month fields explicitly here because a day field can be read-only
only if the year field and the month field are read-only.
LayoutTests:
Note: We don't add tests for input[type=datetime] now because the WHATWG
specification might be changed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Added.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Added.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
Update test cases for new behavior. We should not make hour fields
read-only for input[type=time].
- platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Ditto.
- platform/chromium/TestExpectations: Add time-appearance-basic.html.
- 2:59 AM Changeset in webkit [139864] by
-
- 2 edits in trunk/Source/WebCore
[TexMap] Composited CSS shaders crash when using non-GL TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=106796
Reviewed by Noam Rosenthal.
Fail gracefully when FilterEffectRenderer fails to build the filter effects.
- platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):
- 2:47 AM Changeset in webkit [139863] by
-
- 3 edits6 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2013-01-16
- platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added. Rebaseline after r139798.
- platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added. Rebaseline after r139798.
- platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt: Added. Rebaseline after r139794.
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Rebaseline after r139798.
- platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline after r139798.
- 2:43 AM Changeset in webkit [139862] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Store project UISourceCodes in a map with uri as a key for faster lookup.
https://bugs.webkit.org/show_bug.cgi?id=106911
Reviewed by Pavel Feldman.
- inspector/front-end/Workspace.js:
(WebInspector.Project):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):
- 2:42 AM Changeset in webkit [139861] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening.
Removed fast/events/drag-and-drop-autoscroll from Test expectations after rollout in r139503.
ScrollingCoordinator tests moved to TestExpectations after r139686.
Border size rendering change in r139798 requires a rebaseline for
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm &
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
but they fail to generate pixel results - see bug 106992.
PropertyCollection tests skipped for now after r139756
- platform/efl/TestExpectations:
- 2:26 AM Changeset in webkit [139860] by
-
- 15 edits3 adds in trunk
Web Inspector: Introduce file mapping allowing to map network loaded scripts and stylesheets to file system files.
https://bugs.webkit.org/show_bug.cgi?id=106795
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced file mapping for inspector.
FileMapping is essentially an array of MappingEntries where each MappingEntry is a pair of urlPrefix and pathPrefix.
When scripts and stylesheets are mapped to uiSourceCodes FileMapping methods are used to establish
prefix based matching with file system uiSourceCodes if possible.
Test: inspector/file-mapping.html
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
(WebInspector.CompilerScriptMapping.prototype._bindUISourceCode):
(WebInspector.CompilerScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
- inspector/front-end/FileMapping.js: Added.
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.hasMappingForURL):
(WebInspector.FileMapping.prototype.uriForURL):
(WebInspector.FileMapping.prototype.urlForURI):
(WebInspector.FileMapping.prototype.setMappings):
(WebInspector.FileMapping.prototype.mappings):
(WebInspector.FileMapping.prototype._deserialize):
(WebInspector.FileMapping.prototype._serialize):
(WebInspector.FileMapping.MappingEntry):
(WebInspector.FileMapping.MappingEntry.deserialize):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURL):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURI):
(WebInspector.FileMapping.MappingEntry.prototype.uriForURL):
(WebInspector.FileMapping.MappingEntry.prototype.urlForURI):
(WebInspector.FileMapping.MappingEntry.prototype.serialize):
- inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
- inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
- inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(_addURLMapping):
(rawLocationToUILocation):
(_reset):
(WebInspector.SASSSourceMapping.MappingEntry):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/Workspace.js:
- inspector/front-end/inspector.html:
- inspector/front-end/inspector.js:
LayoutTests:
- inspector/file-mapping-expected.txt: Added.
- inspector/file-mapping.html: Added.
- 2:19 AM Changeset in webkit [139859] by
-
- 36 edits in trunk
Web Inspector: Introduce UISourceCode.originURL().
https://bugs.webkit.org/show_bug.cgi?id=106909
Reviewed by Pavel Feldman.
Source/WebCore:
Introduced originURL on UISourceCode showing where UISourceCode in workspace was loaded from.
This is neeeded to distinguish it from network request url used by mappings.
- inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
- inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
- inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
- inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
- inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement):
- inspector/front-end/SASSSourceMapping.js:
(uiLocationToRawLocation):
- inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
- inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes.comparator):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
- inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
- inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.uiLocationToRawLocation):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tooltipForFile):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.originURL):
(WebInspector.UISourceCode.prototype.urlChanged):
(WebInspector.UISourceCode.prototype.contentURL):
(WebInspector.Revision.prototype.contentURL):
- inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):
LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
- http/tests/inspector/network/network-request-revision-content.html:
- http/tests/inspector/workspace-test.js:
- inspector/debugger/breakpoint-manager.html:
- inspector/debugger/dynamic-script-tag.html:
- inspector/debugger/linkifier.html:
- inspector/debugger/live-edit-breakpoints.html:
- inspector/debugger/script-snippet-model.html:
- inspector/debugger/scripts-file-selector.html:
- inspector/debugger/scripts-panel.html:
- inspector/debugger/scripts-sorting.html:
- inspector/debugger/source-frame-count.html:
- inspector/debugger/source-url-comment.html:
- inspector/debugger/ui-source-code-display-name.html:
- inspector/debugger/ui-source-code.html:
- inspector/styles/styles-history.html:
- inspector/uisourcecode-revisions.html:
- 2:16 AM Changeset in webkit [139858] by
-
- 4 edits94 moves23 adds in trunk
[EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=106969
Reviewed by Benjamin Poulain.
.:
- Source/PlatformEfl.cmake: Change DefaultTheme path.
- Source/cmake/OptionsEfl.cmake: ditto.
Source/WebCore:
DefaultTheme is used by both EFL WK1 and WK2 ports. So, WebCore/platform/efl is appropriate place for it.
- platform/efl/DefaultTheme/CMakeLists.txt: Renamed from Source/WebKit/efl/DefaultTheme/CMakeLists.txt.
- platform/efl/DefaultTheme/default.edc: Renamed from Source/WebKit/efl/DefaultTheme/default.edc.
- platform/efl/DefaultTheme/widget/button/button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/button.edc.
- platform/efl/DefaultTheme/widget/button/img_button_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_focus.png.
- platform/efl/DefaultTheme/widget/button/img_button_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_hover.png.
- platform/efl/DefaultTheme/widget/button/img_button_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_normal.png.
- platform/efl/DefaultTheme/widget/button/img_button_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_press.png.
- platform/efl/DefaultTheme/widget/check/check.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/check.edc.
- platform/efl/DefaultTheme/widget/check/img_check_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png.
- platform/efl/DefaultTheme/widget/check/img_check_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png.
- platform/efl/DefaultTheme/widget/check/img_check_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off.png.
- platform/efl/DefaultTheme/widget/check/img_check_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_focus.png.
- platform/efl/DefaultTheme/widget/check/img_check_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_hover.png.
- platform/efl/DefaultTheme/widget/check/img_check_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on.png.
- platform/efl/DefaultTheme/widget/check/img_check_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_focus.png.
- platform/efl/DefaultTheme/widget/check/img_check_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_hover.png.
- platform/efl/DefaultTheme/widget/combo/combo.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo.edc.
- platform/efl/DefaultTheme/widget/combo/combo_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus.png.
- platform/efl/DefaultTheme/widget/combo/combo_focus_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover.png.
- platform/efl/DefaultTheme/widget/combo/combo_hover_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal.png.
- platform/efl/DefaultTheme/widget/combo/combo_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal_button.png.
- platform/efl/DefaultTheme/widget/combo/combo_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press.png.
- platform/efl/DefaultTheme/widget/combo/combo_press_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press_button.png.
- platform/efl/DefaultTheme/widget/combo/icon.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/icon.png.
- platform/efl/DefaultTheme/widget/entry/entry.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/entry.edc.
- platform/efl/DefaultTheme/widget/entry/img_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_focused.png.
- platform/efl/DefaultTheme/widget/entry/img_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_hovered.png.
- platform/efl/DefaultTheme/widget/entry/img_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_normal.png.
- platform/efl/DefaultTheme/widget/file/file.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file.edc.
- platform/efl/DefaultTheme/widget/file/file_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_focus.png.
- platform/efl/DefaultTheme/widget/file/file_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_hover.png.
- platform/efl/DefaultTheme/widget/file/file_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_normal.png.
- platform/efl/DefaultTheme/widget/file/file_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_press.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc.
- platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png.
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc.
- platform/efl/DefaultTheme/widget/progressbar/bt_base.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/bt_base.png.
- platform/efl/DefaultTheme/widget/progressbar/progressbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/progressbar.edc.
- platform/efl/DefaultTheme/widget/progressbar/shelf_inset.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/shelf_inset.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_focus.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_hover.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_focus.png.
- platform/efl/DefaultTheme/widget/radio/img_radio_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_hover.png.
- platform/efl/DefaultTheme/widget/radio/radio.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/radio.edc.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar.edc.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png.
- platform/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png.
- platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png.
- platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png.
- platform/efl/DefaultTheme/widget/search/cancel/search_cancel.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/search_cancel.edc.
- platform/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png.
- platform/efl/DefaultTheme/widget/search/decoration/search_decoration.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/search_decoration.edc.
- platform/efl/DefaultTheme/widget/search/field/field_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_focused.png.
- platform/efl/DefaultTheme/widget/search/field/field_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_hovered.png.
- platform/efl/DefaultTheme/widget/search/field/field_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_normal.png.
- platform/efl/DefaultTheme/widget/search/field/search_field.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/search_field.edc.
- platform/efl/DefaultTheme/widget/slider/slider.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider.edc.
- platform/efl/DefaultTheme/widget/slider/slider_fill_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_fill_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_thumb_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_v.png.
- platform/efl/DefaultTheme/widget/slider/slider_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_v.png.
- platform/efl/DefaultTheme/widget/spinner/sp_bg.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_bg.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_default.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_hover.png.
- platform/efl/DefaultTheme/widget/spinner/sp_down_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_pressed.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_default.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_hover.png.
- platform/efl/DefaultTheme/widget/spinner/sp_up_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_pressed.png.
- platform/efl/DefaultTheme/widget/spinner/spinner.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/spinner.edc.
- 2:07 AM Changeset in webkit [139857] by
-
- 2 edits1 delete in trunk/LayoutTests
REGRESSION(r139835): fast/js/integer-division-neg2tothe32-by-neg1.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106991
Unreviewed gardening, updated expected file.
- fast/js/integer-division-neg2tothe32-by-neg1-expected.txt:
- platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Removed.
- 2:06 AM Changeset in webkit [139856] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to 177117.
- DEPS:
- 2:05 AM Changeset in webkit [139855] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding a failure expectation for fast/js/integer-division-neg2tothe32-by-neg1.html.
The test started failing after r139835.
- platform/gtk/TestExpectations:
- 2:02 AM Changeset in webkit [139854] by
-
- 7 edits in trunk/Source/WebCore
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916
Reviewed by Adam Barth.
This is one of steps to remove optional Isolate parameters.
No tests. No change in behavior.
- bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
(WebCore):
(WebCore::SerializedScriptValue::deserializeForInspector):
- bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
- bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
- bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
- bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):
- 1:50 AM Changeset in webkit [139853] by
-
- 10 edits5 adds in trunk
[Inspector] Add events for tracking page loads and scheduled navigations.
https://bugs.webkit.org/show_bug.cgi?id=104168
Patch by Ken Kania <kkania@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
These events are needed for clients who need to be aware of when a page is
navigating or about to navigate. Some clients may wish to prevent interaction
with the page during this time. Two of the new events track loading start and
stop, as measured by the ProgressTracker. The other two events track when a
page has a new scheduled navigation and when it no longer has a scheduled
navigation. These latter two events won't allow the client to determine if
a load is going to happen in all circumstances, but is sufficient for many cases.
Source/WebCore:
Tests: inspector-protocol/page/frameScheduledNavigation.html
inspector-protocol/page/frameStartedLoading.html
- inspector/Inspector.json:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore):
(WebCore::InspectorPageAgent::frameStoppedLoading):
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
- inspector/InspectorPageAgent.h:
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
- loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
LayoutTests:
- inspector-protocol/page/frameScheduledNavigation-expected.txt: Added.
- inspector-protocol/page/frameScheduledNavigation.html: Added.
- inspector-protocol/page/frameStartedLoading-expected.txt: Added.
- inspector-protocol/page/frameStartedLoading.html: Added.
- 1:47 AM Changeset in webkit [139852] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
Rebaselining after r139798.
- platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
- platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
- 1:45 AM Changeset in webkit [139851] by
-
- 2 edits in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test on Linux after r139798:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
- platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
- 1:42 AM Changeset in webkit [139850] by
-
- 8 edits in trunk/Tools
[chromium] add title text direction attribute to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=106907
Reviewed by Adam Barth.
- DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
- DumpRenderTree/chromium/DRTTestRunner.h:
- DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTitleTextDirection):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTitleTextDirection):
(WebTestRunner):
- DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
- DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):
- 1:34 AM Changeset in webkit [139849] by
-
- 8 edits in trunk
MediaStream API: Update MediaStreamTrack::readyState to match specification
https://bugs.webkit.org/show_bug.cgi?id=106781
Reviewed by Kentaro Hara.
Source/WebCore:
MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.
Existing tests expanded to cover patch.
- Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):
- Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
- Modules/mediastream/MediaStreamTrack.idl:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- 1:24 AM Changeset in webkit [139848] by
-
- 5 edits in trunk
Web Inspector: array grouping does not work for big and negative number keys
https://bugs.webkit.org/show_bug.cgi?id=106891
Reviewed by Pavel Feldman.
Source/WebCore:
Fixing array grouping for arrays that contain big or negative number representations as object keys.
- inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):
LayoutTests:
- inspector/console/console-big-array-expected.txt:
- inspector/console/console-big-array.html:
- 1:13 AM Changeset in webkit [139847] by
-
- 1 edit1 add in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Rebaseline this test after r139835:
fast/js/integer-division-neg2tothe32-by-neg1.html
- platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.
- 1:07 AM Changeset in webkit [139846] by
-
- 8 edits in trunk/LayoutTests
Unreviewed gardening.
Adjusting failure expectations for fast/harness/sample-fail-mismatch-reftest.html
on all ports. The expectation for the test is now marked as a WontFix image failure.
r139786 reintroduced the possibility of running tests marked as WontFix if there is
another expectation (like Failure, ImageOnlyFailure) listed for the test.
This specific test tests that the harness correctly behaves in a case of a mismatch
reftest that matches with its baseline (i.e. that an image failure is reported). As
such every port should run it to ensure correct behavior of the ImageDiff tool in combination
with NRWT.
- platform/chromium/TestExpectations:
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 1:01 AM Changeset in webkit [139845] by
-
- 8 edits2 moves26 adds4 deletes in trunk/LayoutTests
[Chromium] Unreviewed gardening.
Baseline (and rebaseline on Linux) these tests introduced in
r139836:
fast/gradients/unprefixed-color-stop-units.html
fast/gradients/unprefixed-color-stops.html
fast/gradients/unprefixed-generated-gradients.html
fast/gradients/unprefixed-gradient-parsing.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
fast/gradients/unprefixed-list-item-gradient.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-repeating-end-fill.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-repeating-radial-gradients.html
fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html
- platform/chromium-linux/fast/gradients/unprefixed-color-stop-units-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-color-stops-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-generated-gradients-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-linear-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients2-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-radial-gradients3-expected.png: Removed.
- platform/chromium-linux/fast/gradients/unprefixed-repeating-linear-gradient-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-repeating-radial-gradients-expected.png:
- platform/chromium-linux/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Removed.
- platform/chromium-mac-lion/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac-snowleopard/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-color-stops-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
- platform/chromium-mac/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-color-stops-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-list-item-gradient-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-list-item-gradient-expected.png.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-repeating-end-fill-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-repeating-end-fill-expected.png.
- platform/chromium-win/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
- platform/chromium-win/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
- 12:48 AM Changeset in webkit [139844] by
-
- 5 edits2 adds in trunk
Web Inspector: highlight regexp API for DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=106801
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.
Source/WebCore:
Add highlightRegexp and removeRegexpHighlight methods to DefaultTextEditor that highlight
all occurrences of given regexp in text with given css class.
Highlight is done via spans positioned absolutely over the regexp occurences in text.
Test: inspector/editor/text-editor-highlight-regexp.html
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRegex):
(WebInspector.DefaultTextEditor.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._repaintVisibleChunks):
(WebInspector.TextEditorMainPanel.prototype._findRegexOccurrences):
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
- inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.highlightRegex):
(WebInspector.TextEditor.prototype.removeRegexHighlight):
- inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.debug-fadeout):
LayoutTests:
New layout test to verify DefaultTextEditor highlight regexp API.
- inspector/editor/text-editor-highlight-regexp-expected.txt: Added.
- inspector/editor/text-editor-highlight-regexp.html: Added.
- 12:23 AM Changeset in webkit [139843] by
-
- 2 edits2 copies in branches/chromium/1364
Merge 139419
Connect UserGestureIndicator for mousedown and mouseup events
https://bugs.webkit.org/show_bug.cgi?id=105138
Reviewed by Adam Barth.
Source/WebCore:
Ports that consume user gestures to prevent certain types of pop-ups
need to be able to connect mousedown and mouseup events, otherwise, a
single mouse click will allow for opening multiple pop-ups.
Note that a mousedown is not always followed by a mouseup and vice
versa, e.g. when the mousedown results in a context menu being shown, or
something is dragged into the page.
Test: platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/EventHandler.h:
LayoutTests:
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events-expected.txt: Added.
- platform/chromium/fast/events/popup-allowed-from-gesture-only-once-two-events.html: Added.
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/11975006
- 12:05 AM Changeset in webkit [139842] by
-
- 2 edits in trunk/Source/WebKit/chromium
[Chromium] Unreviewed gardening.
Roll Chromium to r177080.
- DEPS:
- 12:02 AM Changeset in webkit [139841] by
-
- 3 edits in trunk/Tools
NRWT still confused about test count with --repeat-each and --iterations
https://bugs.webkit.org/show_bug.cgi?id=106562
Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-16
Reviewed by Dirk Pranke.
Fix the printed unique test count and skipped count. This
seems to have broken in r127688 ("NRWT lies about the number
of tests that it's skipping when used with --repeat-each").
Also add a test for print_found()
- Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
- Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_details):
(Testprinter):
(Testprinter.test_found):
