⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 13, 2013:

11:51 PM Changeset in webkit [142855] by hayato@chromium.org
  • 21 edits
    22 adds in trunk

[Shadow DOM] Implements a '::distributed()' pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=82169

Reviewed by Dimitri Glazkov.

Source/WebCore:

Implements a '::distributed()' pseudo element.
See the Shadow DOM specification and the filed bug for the detail.

For example, suppose we are given the following DOM tree and shadow tree:

  • <A>
    • <B>
      • <C>

[A's ShadowRoot]

<D>

  • <style>

E content::distributed(B C) { color: green; }

  • <E>
    • <content> (Node B is distributed to this insertion point.)

In this case, the style rule defined in the shadow tree matches node 'C'.

A '::distributed()' pseudo element can not be a pseudo class since
an intersection between matched_elements(some_selector) and
matched_elements(some_selector::distributed(...)) is always an
empty set. A '::distributed()' pseudo element is the first-ever
*functional* pseudo element which takes a parameter, which can be
a selector.

This rule crosses the shadow boundary from a shadow tree to the
tree of its shadow host. That means a rule which includes
'::distributed()' pseudo element is defined in shadow tree, but
the node which is matched in the rule, the subject of the
selector, is outside of the shadow tree. Therefore, we cannot
predict where the subject of the selector will be beforehand.
Current CSS implementation assumes the subject of the selector
must exist in the current scope.

To overcome this issue, DocumentRuleSets now has a instance of
ShadowDistributedRules class. A style rule will be stored in this
instance if the rule includes a '::distributed()' pseudo element.
This class also keeps track of each RuleSet by mapping it with a
scope where the rule was originally defined. In the example, the
scope is A's ShadowRoot. The scope is used to check whether the
left-most matched element (in the example, it's a node 'E') exists
in the scope.

Internally, a '::distributed' pseudo element is represented by a
newly introduced 'ShadowDistributed' relation. That makes an
implementation of SelectorChecker::checkSelector() much simpler.
A transformation from a distributed pseudo element to a
ShadowDistributed is done in parsing stage of CSS.

Since '::distributed()' is an experimental feature, it's actually
prefixed with '-webkit-' and guarded by SHADOW_DOM flag.

Tests: fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html

fast/dom/shadow/distributed-pseudo-element-match-all.html
fast/dom/shadow/distributed-pseudo-element-match-descendant.html
fast/dom/shadow/distributed-pseudo-element-nested.html
fast/dom/shadow/distributed-pseudo-element-no-match.html
fast/dom/shadow/distributed-pseudo-element-reprojection.html
fast/dom/shadow/distributed-pseudo-element-scoped.html
fast/dom/shadow/distributed-pseudo-element-support-selector.html
fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html
fast/dom/shadow/distributed-pseudo-element-with-any.html
fast/dom/shadow/distributed-pseudo-element.html

  • css/CSSGrammar.y.in:

CSS Grammar was updated to support '::distrbuted(selector)'.
This pseudo element is the first pseudo element which can take a selector as a parameter.

  • css/CSSParser.cpp:

(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Here we are converting a '::distributed' pseudo element into a
ShadowDistributed relation internally. To support the conversion,
these rewriteSpecifiersXXX functions (formally called
updateSpecifiersXXX) now return the specifiers which may be
converted.
(WebCore::CSSParser::rewriteSpecifiers):

  • css/CSSParser.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::CSSParserSelector):

  • css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::functionArgumentSelector):
To hold an intermediate selector which appears at the position of an argument in
functional pseudo element when parsing CSS.
(WebCore::CSSParserSelector::setFunctionArgumentSelector):
(WebCore::CSSParserSelector::isDistributedPseudoElement):

  • css/CSSSelector.cpp:

Add new pseudo element, PseudoDistributed, and its internal representation, ShadowDistributed relation.
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:

(CSSSelector):
(WebCore):
(WebCore::CSSSelector::isDistributedPseudoElement):
(WebCore::CSSSelector::isShadowDistributed):

  • css/CSSSelectorList.cpp:

(WebCore):
(SelectorHasShadowDistributed):
(WebCore::SelectorHasShadowDistributed::operator()):
(WebCore::CSSSelectorList::hasShadowDistributedAt):

  • css/CSSSelectorList.h:

(CSSSelectorList):

  • css/DocumentRuleSets.cpp:

(WebCore):
(WebCore::ShadowDistributedRules::addRule):
Every CSS rule which includes '::distributed(...)' should be managed by calling this function.
(WebCore::ShadowDistributedRules::collectMatchRequests):
(WebCore::DocumentRuleSets::resetAuthorStyle):

  • css/DocumentRuleSets.h:

(WebCore):
(ShadowDistributedRules):
(WebCore::ShadowDistributedRules::clear):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::shadowDistributedRules)
DocumentRuleSets owns an instance of ShadowDistributedRules.

  • css/RuleSet.cpp:

(WebCore::RuleSet::addChildRules):
Updated to check whether the rule contains '::distributed()' or not.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
Support ShadowDistributed relation. Check all possible insertion points where a node is distributed.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::SelectorCheckingContext::SelectorCheckingContext):
Adds enum of BehaviorAtBoundary. '::distributed()' is the only
rule which uses 'CrossedBoundary' since it is the only rule which
crosses shadow boundaries.
(SelectorCheckingContext):

  • css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectIdentifierHashes):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::ruleMatches):

  • css/StyleResolver.h:

(MatchRequest):
(WebCore::MatchRequest::MatchRequest): Add behaviorAtBoundary field.
(WebCore):
(StyleResolver):

  • html/shadow/InsertionPoint.cpp:

(WebCore::collectInsertionPointsWhereNodeIsDistributed):
(WebCore):

  • html/shadow/InsertionPoint.h:

(WebCore):

LayoutTests:

  • fast/dom/shadow/distributed-pseudo-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-for-shadow-element.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-all.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-match-descendant.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-nested.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-no-match.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-reprojection.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-scoped.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-support-selector.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-used-in-selector-list.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any-expected.html: Added.
  • fast/dom/shadow/distributed-pseudo-element-with-any.html: Added.
  • fast/dom/shadow/distributed-pseudo-element.html: Added.
11:41 PM Changeset in webkit [142854] by Gregg Tavares
  • 1 edit
    126 adds in trunk/LayoutTests

Add WebGL Conformance Tests more folder.
https://bugs.webkit.org/show_bug.cgi?id=109118

Reviewed by Kenneth Russell.

  • webgl/conformance/more/conformance/constants-expected.txt: Added.
  • webgl/conformance/more/conformance/constants.html: Added.
  • webgl/conformance/more/conformance/getContext-expected.txt: Added.
  • webgl/conformance/more/conformance/getContext.html: Added.
  • webgl/conformance/more/conformance/methods-expected.txt: Added.
  • webgl/conformance/more/conformance/methods.html: Added.
  • webgl/conformance/more/conformance/webGLArrays-expected.txt: Added.
  • webgl/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/conformance/more/functions/bindBuffer-expected.txt: Added.
  • webgl/conformance/more/functions/bindBuffer.html: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero-expected.txt: Added.
  • webgl/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/conformance/more/functions/bufferData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferData.html: Added.
  • webgl/conformance/more/functions/bufferSubData-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubData.html: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/conformance/more/functions/isTests-expected.txt: Added.
  • webgl/conformance/more/functions/isTests.html: Added.
  • webgl/conformance/more/functions/isTestsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixels-expected.txt: Added.
  • webgl/conformance/more/functions/readPixels.html: Added.
  • webgl/conformance/more/functions/texImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2D.html: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformMatrix-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformf-expected.txt: Added.
  • webgl/conformance/more/functions/uniformf.html: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/conformance/more/functions/uniformfBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/conformance/more/functions/uniformi-expected.txt: Added.
  • webgl/conformance/more/functions/uniformi.html: Added.
  • webgl/conformance/more/functions/uniformiBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttrib-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointer-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/more/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_linkonly.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/all_tests_sequential.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-A.js: Added.

(ArgGenerators.activeTexture.generate):
(ArgGenerators.activeTexture.checkArgValidity):
(ArgGenerators.activeTexture.teardown):
(ArgGenerators.attachShader.generate):
(ArgGenerators.attachShader.checkArgValidity):
(ArgGenerators.attachShader.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B1.js: Added.

(ArgGenerators.bindAttribLocation.generate):
(ArgGenerators.bindAttribLocation.checkArgValidity):
(ArgGenerators.bindAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B2.js: Added.

(ArgGenerators.bindBuffer.generate):
(ArgGenerators.bindBuffer.checkArgValidity):
(ArgGenerators.bindBuffer.cleanup):
(ArgGenerators.bindFramebuffer.generate):
(ArgGenerators.bindFramebuffer.checkArgValidity):
(ArgGenerators.bindFramebuffer.cleanup):
(ArgGenerators.bindRenderbuffer.generate):
(ArgGenerators.bindRenderbuffer.checkArgValidity):
(ArgGenerators.bindRenderbuffer.cleanup):
(ArgGenerators.bindTexture.generate):
(ArgGenerators.bindTexture.checkArgValidity):
(ArgGenerators.bindTexture.cleanup):
(ArgGenerators.blendColor.generate):
(ArgGenerators.blendColor.teardown):
(ArgGenerators.blendEquation.generate):
(ArgGenerators.blendEquation.checkArgValidity):
(ArgGenerators.blendEquation.teardown):
(ArgGenerators.blendEquationSeparate.generate):
(ArgGenerators.blendEquationSeparate.checkArgValidity):
(ArgGenerators.blendEquationSeparate.teardown):
(ArgGenerators.blendFunc.generate):
(ArgGenerators.blendFunc.checkArgValidity):
(ArgGenerators.blendFunc.teardown):
(ArgGenerators.blendFuncSeparate.generate):
(ArgGenerators.blendFuncSeparate.checkArgValidity):
(ArgGenerators.blendFuncSeparate.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B3.js: Added.

(ArgGenerators.bufferData.setup):
(ArgGenerators.bufferData.generate):
(ArgGenerators.bufferData.checkArgValidity):
(ArgGenerators.bufferData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-B4.js: Added.

(ArgGenerators.bufferSubData.setup):
(ArgGenerators.bufferSubData.generate):
(ArgGenerators.bufferSubData.checkArgValidity):
(ArgGenerators.bufferSubData.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-C.js: Added.

(ArgGenerators.checkFramebufferStatus.generate):
(ArgGenerators.checkFramebufferStatus.checkArgValidity):
(ArgGenerators.checkFramebufferStatus.cleanup):
(ArgGenerators.clear.generate):
(ArgGenerators.clear.checkArgValidity):
(ArgGenerators.clearColor.generate):
(ArgGenerators.clearColor.teardown):
(ArgGenerators.clearDepth.generate):
(ArgGenerators.clearDepth.teardown):
(ArgGenerators.clearStencil.generate):
(ArgGenerators.clearStencil.teardown):
(ArgGenerators.colorMask.generate):
(ArgGenerators.colorMask.teardown):
(ArgGenerators.createBuffer.generate):
(ArgGenerators.createBuffer.returnValueCleanup):
(ArgGenerators.createFramebuffer.generate):
(ArgGenerators.createFramebuffer.returnValueCleanup):
(ArgGenerators.createProgram.generate):
(ArgGenerators.createProgram.returnValueCleanup):
(ArgGenerators.createRenderbuffer.generate):
(ArgGenerators.createRenderbuffer.returnValueCleanup):
(ArgGenerators.createShader.generate):
(ArgGenerators.createShader.checkArgValidity):
(ArgGenerators.createShader.returnValueCleanup):
(ArgGenerators.createTexture.generate):
(ArgGenerators.createTexture.returnValueCleanup):
(ArgGenerators.cullFace.generate):
(ArgGenerators.cullFace.checkArgValidity):
(ArgGenerators.cullFace.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-D_G.js: Added.

(ArgGenerators.deleteBuffer.generate):
(ArgGenerators.deleteBuffer.checkArgValidity):
(ArgGenerators.deleteBuffer.cleanup):
(ArgGenerators.deleteFramebuffer.generate):
(ArgGenerators.deleteFramebuffer.checkArgValidity):
(ArgGenerators.deleteFramebuffer.cleanup):
(ArgGenerators.deleteProgram.generate):
(ArgGenerators.deleteProgram.checkArgValidity):
(ArgGenerators.deleteProgram.cleanup):
(ArgGenerators.deleteRenderbuffer.generate):
(ArgGenerators.deleteRenderbuffer.checkArgValidity):
(ArgGenerators.deleteRenderbuffer.cleanup):
(ArgGenerators.deleteShader.generate):
(ArgGenerators.deleteShader.checkArgValidity):
(ArgGenerators.deleteShader.cleanup):
(ArgGenerators.deleteTexture.generate):
(ArgGenerators.deleteTexture.checkArgValidity):
(ArgGenerators.deleteTexture.cleanup):
(ArgGenerators.depthFunc.generate):
(ArgGenerators.depthFunc.checkArgValidity):
(ArgGenerators.depthFunc.teardown):
(ArgGenerators.depthMask.generate):
(ArgGenerators.depthMask.teardown):
(ArgGenerators.depthRange.generate):
(ArgGenerators.depthRange.teardown):
(ArgGenerators.detachShader.generate):
(ArgGenerators.detachShader.checkArgValidity):
(ArgGenerators.detachShader.cleanup):
(ArgGenerators.disable.generate):
(ArgGenerators.disable.checkArgValidity):
(ArgGenerators.disable.cleanup):
(ArgGenerators.disableVertexAttribArray.generate):
(ArgGenerators.disableVertexAttribArray.checkArgValidity):
(ArgGenerators.enable.generate):
(ArgGenerators.enable.checkArgValidity):
(ArgGenerators.enable.cleanup):
(ArgGenerators.enableVertexAttribArray.generate):
(ArgGenerators.enableVertexAttribArray.checkArgValidity):
(ArgGenerators.enableVertexAttribArray.cleanup):
(ArgGenerators.finish.generate):
(ArgGenerators.flush.generate):
(ArgGenerators.frontFace.generate):
(ArgGenerators.frontFace.checkArgValidity):
(ArgGenerators.frontFace.cleanup):
(ArgGenerators.generateMipmap.setup):
(ArgGenerators.generateMipmap.generate):
(ArgGenerators.generateMipmap.checkArgValidity):
(ArgGenerators.generateMipmap.teardown):
(ArgGenerators.getAttachedShaders.setup):
(ArgGenerators.getAttachedShaders.generate):
(ArgGenerators.getAttachedShaders.checkArgValidity):
(ArgGenerators.getAttachedShaders.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-G_I.js: Added.

(ArgGenerators.getAttribLocation.generate):
(ArgGenerators.getAttribLocation.checkArgValidity):
(ArgGenerators.getAttribLocation.cleanup):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-L_S.js: Added.

(ArgGenerators.lineWidth.generate):
(ArgGenerators.lineWidth.teardown):
(ArgGenerators.pixelStorei.generate):
(ArgGenerators.pixelStorei.checkArgValidity):
(ArgGenerators.pixelStorei.teardown):
(ArgGenerators.polygonOffset.generate):
(ArgGenerators.polygonOffset.teardown):
(ArgGenerators.sampleCoverage.generate):
(ArgGenerators.sampleCoverage.teardown):
(ArgGenerators.scissor.generate):
(ArgGenerators.scissor.checkArgValidity):
(ArgGenerators.scissor.teardown):
(ArgGenerators.stencilFunc.generate):
(ArgGenerators.stencilFunc.checkArgValidity):
(ArgGenerators.stencilFunc.teardown):
(ArgGenerators.stencilFuncSeparate.generate):
(ArgGenerators.stencilFuncSeparate.checkArgValidity):
(ArgGenerators.stencilFuncSeparate.teardown):
(ArgGenerators.stencilMask.generate):
(ArgGenerators.stencilMask.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/argGenerators-S_V.js: Added.

(ArgGenerators.stencilMaskSeparate.generate):
(ArgGenerators.stencilMaskSeparate.checkArgValidity):
(ArgGenerators.stencilMaskSeparate.teardown):
(ArgGenerators.stencilOp.generate):
(ArgGenerators.stencilOp.checkArgValidity):
(ArgGenerators.stencilOp.teardown):
(ArgGenerators.stencilOpSeparate.generate):
(ArgGenerators.stencilOpSeparate.checkArgValidity):
(ArgGenerators.stencilOpSeparate.teardown):
(ArgGenerators.texImage2D.setup):
(ArgGenerators.texImage2D.generate):
(ArgGenerators.texImage2D.checkArgValidity):
(ArgGenerators.texImage2D.teardown):
(ArgGenerators.texParameterf.generate):
(ArgGenerators.texParameterf.checkArgValidity):
(ArgGenerators.texParameteri.generate):
(ArgGenerators.texParameteri.checkArgValidity):
(ArgGenerators.viewport.generate):
(ArgGenerators.viewport.checkArgValidity):
(ArgGenerators.viewport.teardown):

  • webgl/resources/webgl_test_files/conformance/more/conformance/badArgsArityLessThanArgc.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/constants.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/fuzzTheAPI.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/getContext.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/methods.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI.js: Added.

(Array.from):
(Array.prototype.has):
(Array.prototype.random):
(castToInt):
(constCheck.a.has):
(constCheck):
(isBufferData):
(isVertexAttribute):
(isValidName):
(randomWebGLArray):
(randomArrayBuffer):
(randomBufferData):
(randomSmallWebGLArray):
(randomBufferSubData):
(randomColor):
(randomName):
(randomVertexAttribute):
(randomBool):
(randomStencil):
(randomLineWidth):
(randomImage):
(mutateArgs):
(argGeneratorTestRunner):

  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPIBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/webGLArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/opengl_web.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/demos/video.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBuffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bindFramebufferLeaveNonZero.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubData.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferSubDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTests.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/isTestsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixels.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTMLBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrix.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformMatrixBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformf.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfArrayLen1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformfBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformi.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/uniformiBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointer.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/vertexAttribPointerBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/arrayOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/longLoops.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/uniformOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/glsl/unusedAttribsUniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/index.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/CPUvsGPU.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/bandwidth.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsGCPause.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsMatrixMult.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/performance/jsToGLOverhead.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/unit.css: Added.

(.ok):
(.fail):
(canvas):
(#test-status):
(#test-log):
(#test-log > div):
(#test-log h2):
(#test-log h3):
(#test-log p):

  • webgl/resources/webgl_test_files/conformance/more/unit.js: Added.

(.window.console.log):
(.window.console.error):
(Tests.startUnit):
(Tests.setup):
(Tests.teardown):
(Tests.endUnit):
(.):
(Object.toSource):

  • webgl/resources/webgl_test_files/conformance/more/util.js: Added.

(loadTexture):
(getShader):
(loadShaderArray):
(loadShader):
(getGLErrorAsString):
(checkError):
(throwError):
(Math.cot):
(Matrix.newIdentity):
(Matrix.newIdentity3x3):
(Matrix.copyMatrix):
(Matrix.to3x3):
(Matrix.inverseON):
(Matrix.inverseTo3x3):
(Matrix.inverseTo3x3InPlace):
(Matrix.inverse3x3):
(Matrix.inverse3x3InPlace):
(Matrix.frustum):
(Matrix.perspective):
(Matrix.mul4x4):
(Matrix.mul4x4InPlace):
(Matrix.mulv4):
(Matrix.rotate):
(Matrix.rotateInPlace):
(Matrix.scale):
(Matrix.scale3):
(Matrix.scale1):
(Matrix.scale3InPlace):
(Matrix.scale1InPlace):
(Matrix.scaleInPlace):
(Matrix.translate3):
(Matrix.translate):
(Matrix.translate3InPlace):
(Matrix.translateInPlace):
(Matrix.lookAt):
(Matrix.transpose4x4):
(Matrix.transpose4x4InPlace):
(Matrix.transpose3x3):
(Matrix.transpose3x3InPlace):
(Vec3.make):
(Vec3.copy):
(Vec3.add):
(Vec3.sub):
(Vec3.negate):
(Vec3.direction):
(Vec3.normalizeInPlace):
(Vec3.normalize):
(Vec3.scale):
(Vec3.dot):
(Vec3.inner):
(Vec3.cross):
(Shader):
(Shader.prototype.destroy):
(Shader.prototype.compile):
(Shader.prototype.use):
(Shader.prototype.uniform1fv):
(Shader.prototype.uniform2fv):
(Shader.prototype.uniform3fv):
(Shader.prototype.uniform4fv):
(Shader.prototype.uniform1f):
(Shader.prototype.uniform2f):
(Shader.prototype.uniform3f):
(Shader.prototype.uniform4f):
(Shader.prototype.uniform1iv):
(Shader.prototype.uniform2iv):
(Shader.prototype.uniform3iv):
(Shader.prototype.uniform4iv):
(Shader.prototype.uniform1i):
(Shader.prototype.uniform2i):
(Shader.prototype.uniform3i):
(Shader.prototype.uniform4i):
(Shader.prototype.uniformMatrix4fv):
(Shader.prototype.uniformMatrix3fv):
(Shader.prototype.uniformMatrix2fv):
(Shader.prototype.attrib):
(Shader.prototype.uniform):
(Filter):
(Filter.prototype.apply):
(VBO):
(VBO.prototype.setData):
(VBO.prototype.destroy):
(VBO.prototype.init):
(VBO.prototype.use):
(VBO.prototype.draw):
(FBO):
(FBO.prototype.destroy):
(FBO.prototype.init):
(FBO.prototype.getTempCanvas):
(FBO.prototype.use):
(GLError):
(makeGLErrorWrapper):
(wrapGLContext.wrap.getError):
(getGLContext):
(assertSomeGLError):
(assertThrowNoGLError):
(Quad.makeVBO):
(.gl):
(Quad.getCachedVBO):
(deleteShader):
(Cube.create):
(Cube.makeVBO):
(Cube.getCachedVBO):
(Sphere.create.vert):
(Sphere.create):
(initGL_CONTEXT_ID):

11:36 PM Changeset in webkit [142853] by Gregg Tavares
  • 1 edit
    45 adds in trunk/LayoutTests

Add the WebGL Conformance Tests extensions folder.
https://bugs.webkit.org/show_bug.cgi?id=109117

Reviewed by Kenneth Russell.

  • webgl/conformance/extensions/ext-texture-filter-anisotropic-expected.txt: Added.
  • webgl/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/conformance/extensions/get-extension-expected.txt: Added.
  • webgl/conformance/extensions/get-extension.html: Added.
  • webgl/conformance/extensions/oes-element-index-uint-expected.txt: Added.
  • webgl/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/conformance/extensions/oes-standard-derivatives-expected.txt: Added.
  • webgl/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/conformance/extensions/oes-texture-float-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video-expected.txt: Added.
  • webgl/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/conformance/extensions/oes-texture-float.html: Added.
  • webgl/conformance/extensions/oes-vertex-array-object-expected.txt: Added.
  • webgl/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/conformance/extensions/webgl-debug-shaders-expected.txt: Added.
  • webgl/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/conformance/extensions/webgl-depth-texture-expected.txt: Added.
  • webgl/conformance/extensions/webgl-depth-texture.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/ext-texture-filter-anisotropic.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/get-extension.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-standard-derivatives.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-texture-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/oes-vertex-array-object.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-s3tc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-renderer-info.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-debug-shaders.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-depth-texture.html: Added.
11:31 PM Changeset in webkit [142852] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark new WebGL conformance tests added in r142847 as failing for
EFL WK2.

  • platform/efl-wk2/TestExpectations:
11:10 PM Changeset in webkit [142851] by Gregg Tavares
  • 1 edit
    454 adds in trunk/LayoutTests

Add the WebGL Conformance Tests ogles folder.
https://bugs.webkit.org/show_bug.cgi?id=109116

Reviewed by Kenneth Russell.

  • webgl/conformance/ogles/GL/abs/abs_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002-expected.txt: Added.
  • webgl/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126-expected.txt: Added.
  • webgl/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001-expected.txt: Added.
  • webgl/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004-expected.txt: Added.
  • webgl/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012-expected.txt: Added.
  • webgl/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026-expected.txt: Added.
  • webgl/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120-expected.txt: Added.
  • webgl/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/abs_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/abs/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/all_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/all/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/any_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/any/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/array_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/array/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/biConstants_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biConstants/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/biuDepthRange/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/built_in_varying_array_out_of_bounds_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/built_in_varying_array_out_of_bounds/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/ceil_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/ceil/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/clamp_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/clamp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_009_to_010.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/cos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cos/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/cross_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/cross/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/default_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/default/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/degrees_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/degrees/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/discard_001_to_002.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/discard/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/distance_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/distance/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/dot_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/dot/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/equal_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/equal/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/exp_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/exp2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/exp2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/faceforward_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/faceforward/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/floor_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/floor/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/fract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/fract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/functions_121_to_126.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/functions/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FragCoord/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/gl_FrontFacing_001_to_001.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/gl_FrontFacing/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/greaterThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/greaterThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/greaterThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/inversesqrt/inversesqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/length/length_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThan/lessThan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/lessThanEqual/lessThanEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat/mat_041_to_046.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mat3/mat3_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/matrixCompMult/matrixCompMult_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/max/max_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/min/min_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mix/mix_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/mod/mod_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/normalize/normalize_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/not/not_001_to_004.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/notEqual/notEqual_009_to_012.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/operators/operators_025_to_026.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/pow/pow_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/radians/radians_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/reflect/reflect_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/refract/refract_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sign/sign_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sin/sin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/sqrt/sqrt_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/step/step_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/struct/struct_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_017_to_024.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_025_to_032.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_033_to_040.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_041_to_048.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_049_to_056.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_057_to_064.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_065_to_072.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_073_to_080.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_081_to_088.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_089_to_096.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_097_to_104.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_105_to_112.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/swizzlers/swizzlers_113_to_120.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/tan/tan_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_009_to_016.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec/vec_017_to_018.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/input.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/vec3/vec3_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/README.md: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/mustpass.run.txt: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/process-ogles2-tests.py: Added.

(Log):
(TransposeMatrix):
(GetValidTypeName):
(WriteOpen):
(TxtWriter):
(TxtWriter.init):
(TxtWriter.Write):
(TxtWriter.Close):
(ReadFileAsLines):
(ReadFile):
(Chunkify):
(GetText):
(GetElementText):
(GetBoolElement):
(GetModel):
(RelativizePaths):
(CopyFile):
(CopyShader):
(IsOneOf):
(CheckForUnknownTags):
(IsFileWeWant):
(TestReader):
(TestReader.to):
(TestReader.init):
(TestReader.Print):
(TestReader.MakeOutPath):
(TestReader.ReadTests):
(TestReader.ReadTest):
(TestReader.ProcessTest):
(TestReader.WriteTests):
(CopyShaders):
(Process_compare):
(Process_shaderload):
(Process_extension):
(Process_createtests):
(Process_GL2Test):
(Process_uniformquery):
(Process_egl_image_external):
(Process_dismount):
(Process_build):
(Process_coverage):
(Process_attributes):
(Process_fixed):
(main):

10:56 PM Changeset in webkit [142850] by Gregg Tavares
  • 1 edit
    592 adds in trunk/LayoutTests

Add WebGL Conformance Tests glsl folder.
https://bugs.webkit.org/show_bug.cgi?id=109115

Reviewed by Kenneth Russell.

  • webgl/conformance/glsl/functions/glsl-function-abs-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-length-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert-expected.txt: Added.
  • webgl/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3-expected.txt: Added.
  • webgl/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden-expected.txt: Added.
  • webgl/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch-expected.txt: Added.
  • webgl/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/conformance/glsl/misc/large-loop-compile-expected.txt: Added.
  • webgl/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link-expected.txt: Added.
  • webgl/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/conformance/glsl/misc/shared-expected.txt: Added.
  • webgl/conformance/glsl/misc/shared.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum-expected.txt: Added.
  • webgl/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits-expected.txt: Added.
  • webgl/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert-expected.txt: Added.
  • webgl/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj-expected.txt: Added.
  • webgl/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-frontfacing.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-abs.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-acos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-asin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan-xy.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-atan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-ceil.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-clamp-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cos.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-cross.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-distance.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-dot.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-faceforward.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-floor.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-fract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-length.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-lessThan.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-max-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-min-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mix-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-mod-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-normalize.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-reflect.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-refract.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sign.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-sin.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-float.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-step-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/add_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_int_to_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec2_to_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec3_to_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/assign_ivec4_to_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/construct_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/divide_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/function_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/greater_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/less_than_equal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/multiply_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/not_equal_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_mat4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_int_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/subtract_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_int_float.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec2_vec2.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec3_vec3.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/implicit/ternary_ivec4_vec4.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/matrices/glsl-mat4-to-mat3.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/attrib-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/embedded-struct-definitions-forbidden.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/foo: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-2types-of-textures-on-same-unit.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-function-nodes.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-long-variable-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/glsl-vertex-branch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/include.vs: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/large-loop-compile.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii-comments.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/non-ascii.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/re-compile-re-link.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-256-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-define.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-257-character-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-_webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-arbitrary-indexing.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-uniform.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-array.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-attrib-struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-clipvertex.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-comma-conditional-assignment.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping-negative.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-conditional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-default-precision.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-define-line-continuation.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx-no-ext.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-dfdx.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-do-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-error-directive.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-explicit-int-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-float-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-for-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-frag-depth.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-recursion.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-function-scoped-struct.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-functional-scoping.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glcolor.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-1.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-gles-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-glprojectionmatrix.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-hex-int-constant-macro.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-implicit-vec3-to-vec4-cast.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-include.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-int-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-invalid-identifier.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-ivec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-limited-indexing.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-long-line.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-ascii-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-quoted-error.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-too-many-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-undefined-preprocessor-symbol.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-uniform-in-loop-condition.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec2-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec3-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-return-value.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-vec4-vec3-vec4-conditional.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-100.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-120.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-version-130.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-webgl-identifier.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-while-loop.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-without-precision.frag.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-uniforms.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-mis-matching-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-missing-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shared.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-exceeds-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/struct-nesting-under-maximum.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/uniform-location-length-limits.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/_webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_field.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_function.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_preprocessor_reserved.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_struct.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/reserved/webgl_variable.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2d-bias.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dlod.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/samplers/glsl-function-texture2dproj.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-fragcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-frontfacing.html: Added.
10:17 PM Changeset in webkit [142849] by haraken@chromium.org
  • 45 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom methods
https://bugs.webkit.org/show_bug.cgi?id=109678

Reviewed by Adam Barth.

Currently V8 directly calls back custom methods written
in custom binding files. This makes it impossible for code
generators to hook custom methods (e.g. Code generators cannot
insert a code for FeatureObservation into custom methods).
To solve the problem, we should generate wrapper methods for
custom methods.

No tests. No change in behavior.

  • page/DOMWindow.idl: Removed overloaded methods. The fact that methods in an IDL

file are overloaded but they are not overloaded in custom bindings confuses code
generators. (For some reason, this problem hasn't appeared before this change.)

  • xml/XMLHttpRequest.idl: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateEventListenerCallback):
(GenerateFunctionCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod3Callback):
(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customMethodWithArgsCallback):
(WebCore::TestObjV8Internal::classMethod2Callback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::clearDataCallbackCustom):
(WebCore::V8Clipboard::setDragImageCallbackCustom):

  • bindings/v8/custom/V8ConsoleCustom.cpp:

(WebCore::V8Console::traceCallbackCustom):
(WebCore::V8Console::assertCallbackCustom):
(WebCore::V8Console::profileCallbackCustom):
(WebCore::V8Console::profileEndCallbackCustom):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallbackCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallbackCustom):
(WebCore::V8DOMWindow::removeEventListenerCallbackCustom):
(WebCore::V8DOMWindow::postMessageCallbackCustom):
(WebCore::V8DOMWindow::toStringCallbackCustom):
(WebCore::V8DOMWindow::releaseEventsCallbackCustom):
(WebCore::V8DOMWindow::captureEventsCallbackCustom):
(WebCore::V8DOMWindow::showModalDialogCallbackCustom):
(WebCore::V8DOMWindow::openCallbackCustom):
(WebCore::V8DOMWindow::setTimeoutCallbackCustom):
(WebCore::V8DOMWindow::setIntervalCallbackCustom):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::getInt8CallbackCustom):
(WebCore::V8DataView::getUint8CallbackCustom):
(WebCore::V8DataView::setInt8CallbackCustom):
(WebCore::V8DataView::setUint8CallbackCustom):

  • bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::V8DedicatedWorkerContext::postMessageCallbackCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::initDeviceMotionEventCallbackCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallbackCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallbackCustom):
(WebCore::V8Document::createTouchListCallbackCustom):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::V8Geolocation::getCurrentPositionCallbackCustom):
(WebCore::V8Geolocation::watchPositionCallbackCustom):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore::V8HTMLAllCollection::itemCallbackCustom):
(WebCore::V8HTMLAllCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallbackCustom):
(WebCore::V8HTMLCanvasElement::toDataURLCallbackCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::writeCallbackCustom):
(WebCore::V8HTMLDocument::writelnCallbackCustom):
(WebCore::V8HTMLDocument::openCallbackCustom):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::V8HTMLFormControlsCollection::namedItemCallbackCustom):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallbackCustom):
(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::setSelectionRangeCallbackCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::namedItemCallbackCustom):
(WebCore::V8HTMLOptionsCollection::removeCallbackCustom):
(WebCore::V8HTMLOptionsCollection::addCallbackCustom):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::removeCallbackCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallbackCustom):
(WebCore::V8History::replaceStateCallbackCustom):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::inspectedObjectCallbackCustom):
(WebCore::V8InjectedScriptHost::internalConstructorNameCallbackCustom):
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallbackCustom):
(WebCore::V8InjectedScriptHost::typeCallbackCustom):
(WebCore::V8InjectedScriptHost::functionDetailsCallbackCustom):
(WebCore::V8InjectedScriptHost::getInternalPropertiesCallbackCustom):
(WebCore::V8InjectedScriptHost::getEventListenersCallbackCustom):
(WebCore::V8InjectedScriptHost::inspectCallbackCustom):
(WebCore::V8InjectedScriptHost::databaseIdCallbackCustom):
(WebCore::V8InjectedScriptHost::storageIdCallbackCustom):
(WebCore::V8InjectedScriptHost::evaluateCallbackCustom):
(WebCore::V8InjectedScriptHost::setFunctionVariableValueCallbackCustom):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallbackCustom):
(WebCore::V8InspectorFrontendHost::portCallbackCustom):
(WebCore::V8InspectorFrontendHost::showContextMenuCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordActionTakenCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordPanelShownCallbackCustom):
(WebCore::V8InspectorFrontendHost::recordSettingChangedCallbackCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::evaluateCallbackCustom):
(WebCore::V8JavaScriptCallFrame::restartCallbackCustom):
(WebCore::V8JavaScriptCallFrame::setVariableValueCallbackCustom):
(WebCore::V8JavaScriptCallFrame::scopeTypeCallbackCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):
(WebCore::V8Location::reloadCallbackCustom):
(WebCore::V8Location::replaceCallbackCustom):
(WebCore::V8Location::assignCallbackCustom):
(WebCore::V8Location::valueOfCallbackCustom):
(WebCore::V8Location::toStringCallbackCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallbackCustom):
(WebCore::V8MessageEvent::webkitInitMessageEventCallbackCustom):

  • bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::V8MessagePort::postMessageCallbackCustom):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallbackCustom):
(WebCore::V8Node::replaceChildCallbackCustom):
(WebCore::V8Node::removeChildCallbackCustom):
(WebCore::V8Node::appendChildCallbackCustom):

  • bindings/v8/custom/V8NotificationCenterCustom.cpp:

(WebCore::V8NotificationCenter::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8NotificationCustom.cpp:

(WebCore::V8Notification::requestPermissionCallbackCustom):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallbackCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::convertToSpecifiedUnitsCallbackCustom):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::V8WebGLRenderingContext::getAttachedShadersCallbackCustom):
(WebCore::V8WebGLRenderingContext::getBufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getExtensionCallbackCustom):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getRenderbufferParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallbackCustom):
(WebCore::V8WebGLRenderingContext::getTexParameterCallbackCustom):
(WebCore::V8WebGLRenderingContext::getUniformCallbackCustom):
(WebCore::V8WebGLRenderingContext::getVertexAttribCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform1ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform2ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform3ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniform4ivCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::uniformMatrix4fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib1fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib2fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib3fvCallbackCustom):
(WebCore::V8WebGLRenderingContext::vertexAttrib4fvCallbackCustom):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::V8WorkerContext::importScriptsCallbackCustom):
(WebCore::V8WorkerContext::setTimeoutCallbackCustom):
(WebCore::V8WorkerContext::setIntervalCallbackCustom):

  • bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::V8Worker::postMessageCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::openCallbackCustom):
(WebCore::V8XMLHttpRequest::sendCallbackCustom):

  • bindings/v8/custom/V8XSLTProcessorCustom.cpp:

(WebCore::V8XSLTProcessor::setParameterCallbackCustom):
(WebCore::V8XSLTProcessor::getParameterCallbackCustom):
(WebCore::V8XSLTProcessor::removeParameterCallbackCustom):

10:04 PM Changeset in webkit [142848] by commit-queue@webkit.org
  • 8 edits in trunk

JSObject for ChannelSplitterNode and ChannelMergerNode are not created.
https://bugs.webkit.org/show_bug.cgi?id=109542

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

Source/WebCore:

"JSGenerateToJSObject" should be included in IDL files
of ChannelSplitterNode and ChannelMergerNode in WebAudio.
This ensures html files to access corresponding objects.

  • Modules/webaudio/ChannelMergerNode.idl:
  • Modules/webaudio/ChannelSplitterNode.idl:

LayoutTests:

Test cases updated to check validity of ChannelSplitterNode
and ChannelMergerNode Objects.

  • webaudio/audiochannelmerger-basic-expected.txt:
  • webaudio/audiochannelmerger-basic.html:
  • webaudio/audiochannelsplitter-expected.txt:
  • webaudio/audiochannelsplitter.html:
9:49 PM Changeset in webkit [142847] by Gregg Tavares
  • 3 edits
    249 adds in trunk/LayoutTests

Adds failing WebGL Conformance Tests.
https://bugs.webkit.org/show_bug.cgi?id=109075

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • platform/mac/TestExpectations:
  • webgl/conformance/canvas/buffer-offscreen-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/conformance/canvas/buffer-preserve-test-expected.txt: Added.
  • webgl/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/conformance/canvas/drawingbuffer-test-expected.txt: Added.
  • webgl/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/conformance/canvas/to-data-url-test-expected.txt: Added.
  • webgl/conformance/canvas/to-data-url-test.html: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer-expected.txt: Added.
  • webgl/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/conformance/context/context-creation-and-destruction-expected.txt: Added.
  • webgl/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype-expected.txt: Added.
  • webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/conformance/glsl/literals/float_literal.vert-expected.txt: Added.
  • webgl/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names-expected.txt: Added.
  • webgl/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings-expected.txt: Added.
  • webgl/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord-expected.txt: Added.
  • webgl/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V-expected.txt: Added.
  • webgl/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/conformance/more/functions/drawArrays-expected.txt: Added.
  • webgl/conformance/more/functions/drawArrays.html: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds-expected.txt: Added.
  • webgl/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/conformance/more/functions/drawElements-expected.txt: Added.
  • webgl/conformance/more/functions/drawElements.html: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML-expected.txt: Added.
  • webgl/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008-expected.txt: Added.
  • webgl/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006-expected.txt: Added.
  • webgl/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test-expected.txt: Added.
  • webgl/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/conformance/programs/program-test-expected.txt: Added.
  • webgl/conformance/programs/program-test.html: Added.
  • webgl/conformance/reading/read-pixels-test-expected.txt: Added.
  • webgl/conformance/reading/read-pixels-test.html: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment-expected.txt: Added.
  • webgl/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/conformance/rendering/gl-scissor-test-expected.txt: Added.
  • webgl/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/conformance/rendering/more-than-65536-indices-expected.txt: Added.
  • webgl/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/conformance/rendering/multisample-corruption-expected.txt: Added.
  • webgl/conformance/rendering/multisample-corruption.html: Added.
  • webgl/conformance/rendering/point-size-expected.txt: Added.
  • webgl/conformance/rendering/point-size.html: Added.
  • webgl/conformance/state/gl-object-get-calls-expected.txt: Added.
  • webgl/conformance/state/gl-object-get-calls.html: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats-expected.txt: Added.
  • webgl/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/conformance/textures/gl-pixelstorei-expected.txt: Added.
  • webgl/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/conformance/textures/origin-clean-conformance-expected.txt: Added.
  • webgl/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551-expected.txt: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/conformance/textures/texture-active-bind-2-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/conformance/textures/texture-active-bind-expected.txt: Added.
  • webgl/conformance/textures/texture-active-bind.html: Added.
  • webgl/conformance/textures/texture-mips-expected.txt: Added.
  • webgl/conformance/textures/texture-mips.html: Added.
  • webgl/conformance/textures/texture-npot-video-expected.txt: Added.
  • webgl/conformance/textures/texture-npot-video.html: Added.
  • webgl/conformance/textures/texture-size-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit-expected.txt: Added.
  • webgl/conformance/textures/texture-size-limit.html: Added.
  • webgl/conformance/textures/texture-size.html: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays-expected.txt: Added.
  • webgl/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/conformance/uniforms/uniform-default-values-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/conformance/uniforms/uniform-location-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-location.html: Added.
  • webgl/conformance/uniforms/uniform-samplers-test-expected.txt: Added.
  • webgl/conformance/uniforms/uniform-samplers-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/buffer-preserve-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/drawingbuffer-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/canvas/to-data-url-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-attribute-preserve-drawing-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/context/context-creation-and-destruction.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/functions/glsl-function-smoothstep-gentype.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/literals/float_literal.vert.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-uniform-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-varying-packing-restrictions.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-array-of-structs-containing-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-global-variable-precision-mismatch.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-non-reserved-words.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-short-circuiting-operators.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shader-with-similar-uniform-array-names.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/misc/shaders-with-varyings.html: Added.
  • webgl/resources/webgl_test_files/conformance/glsl/variables/gl-pointcoord.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-A.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B1.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B2.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B3.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-B4.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-C.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-D_G.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-G_I.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-L_S.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/conformance/quickCheckAPI-S_V.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/bufferDataBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2D.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/copyTexSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/deleteBufferBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawArraysOutOfBounds.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElements.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/drawElementsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/readPixelsBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DBadArgs.html: Added.
  • webgl/resources/webgl_test_files/conformance/more/functions/texSubImage2DHTML.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/acos/acos_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/asin/asin_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/atan/atan_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/control_flow/control_flow_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log/log_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/log2/log2_001_to_008.html: Added.
  • webgl/resources/webgl_test_files/conformance/ogles/GL/smoothstep/smoothstep_001_to_006.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/gl-bind-attrib-location-long-names-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/programs/program-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/reading/read-pixels-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/renderbuffers/framebuffer-object-attachment.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/gl-scissor-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/more-than-65536-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/multisample-corruption.html: Added.
  • webgl/resources/webgl_test_files/conformance/rendering/point-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/state/gl-object-get-calls.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/copy-tex-image-2d-formats.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/gl-pixelstorei.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/origin-clean-conformance.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-image.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/tex-image-and-sub-image-2d-with-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind-2.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-active-bind.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-mips.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-npot-video.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size-limit.html: Added.
  • webgl/resources/webgl_test_files/conformance/textures/texture-size.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/gl-uniform-arrays.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-default-values.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-location.html: Added.
  • webgl/resources/webgl_test_files/conformance/uniforms/uniform-samplers-test.html: Added.
8:17 PM Changeset in webkit [142846] by Vineet
  • 4 edits in trunk/Source/WebCore

[Regression] After r142831 collection-null-like-arguments.html layout test failing
https://bugs.webkit.org/show_bug.cgi?id=109780

Reviewed by Kentaro Hara.

No new tests. LayoutTests/fast/dom/collection-null-like-arguments.html
Should pass now.

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Return null for namedItem() only.

(WebCore::getNamedItems):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLFormControlsCollection::namedItem):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):
(WebCore::JSHTMLOptionsCollection::namedItem):

7:45 PM Changeset in webkit [142845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix indentation error in MediaPlayerPrivateGStreamer.h
https://bugs.webkit.org/show_bug.cgi?id=109768

Patch by Soo-Hyun Choi <sh9.choi@samsung.com> on 2013-02-13
Reviewed by Kentaro Hara.

No new tests as this patch just changes indentation style.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::hasVideo):
(WebCore::MediaPlayerPrivateGStreamer::hasAudio):
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):

7:44 PM Changeset in webkit [142844] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening
https://bugs.webkit.org/show_bug.cgi?id=109779

Rebaseline http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html
on Linux after r142683.

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13

  • platform/chromium-linux/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
7:31 PM Changeset in webkit [142843] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

TokenPreloadScanner should be (mostly!) thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109760

Reviewed by Eric Seidel.

This patch makes the bulk of TokenPreloadScanner thread-safe. The one
remaining wart is processPossibleBaseTag because it wants to grub
around in the base tag's attributes. I have a plan for that, but it's
going to need to wait for the next patch.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(WebCore):

6:36 PM Changeset in webkit [142842] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/Tools

Unreviewed. Add separate DumpRenderTree VS2010 solution file.

  • DumpRenderTree/DumpRenderTree.vcxproj: Added property svn:ignore.
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree.sln: Added.
6:30 PM Changeset in webkit [142841] by jamesr@google.com
  • 6 edits in trunk

[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

  • chromium/public/WebUnitTestSupport.h:

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

6:16 PM Changeset in webkit [142840] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

StartTagScanner should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=109750

Reviewed by Eric Seidel.

This patch weens the StartTagScanner off AtomicString using two
techniques:

1) This patch creates an enum to represent the four tag names that the

StartTagScanner needs to understand. Using an enum is better than
using an AtomicString because we can use the enum on both the main
thread and on the background thread.

2) For attributes, this patch uses threadSafeMatch. We're not able to

use threadSafeMatch everywhere due to performance, but using it for
attributes appears to be ok becaues we only call threadSafeMatch on
the attributes of "interesting" tags.

I tested the performance of this patch using
PerformanceTests/Parser/html-parser.html and did not see any slowdown.
(There actually appeared to be a <1% speedup, but I'm attributing that
to noise.)

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::identifierFor):
(WebCore):
(WebCore::inititatorFor):
(WebCore::StartTagScanner::StartTagScanner):
(WebCore::StartTagScanner::processAttributes):
(StartTagScanner):
(WebCore::StartTagScanner::createPreloadRequest):
(WebCore::StartTagScanner::processAttribute):
(WebCore::StartTagScanner::charset):
(WebCore::StartTagScanner::resourceType):
(WebCore::StartTagScanner::shouldPreload):
(WebCore::HTMLPreloadScanner::processToken):

6:11 PM Changeset in webkit [142839] by andersca@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

Remove StringPairVector
https://bugs.webkit.org/show_bug.cgi?id=109778

Reviewed by Ryosuke Niwa.

Our message generation scripts can handle nested template parameter types now,
so we no longer need to use StringPairVector.

  • Shared/StringPairVector.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willSubmitForm):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

5:58 PM Changeset in webkit [142838] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Better build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:57 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:56 PM Changeset in webkit [142837] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Coordinated Graphics: a long page is scaled vertically while loading.
https://bugs.webkit.org/show_bug.cgi?id=109645

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-13
Reviewed by Noam Rosenthal.

When loading http://www.w3.org/TR/xpath-datamodel/, Coordinated Graphics draws
vertically scaled contents. It is because there is the difference between the
size of a layer and the size of CoordinatedBackingStore.

Currently, CoordinatedGraphicsScene notifies the size to CoordinatedBackingStore
at the moment of creating, updating and removing a tile. However, it is not
necessary to send tile-related messages when the size of layer is changed.
So this patch resets the size of CoordinatedBackingStore when receiving the
message that is created when the size is changed: SyncLayerState.

There is no current way to reliably test flicker issues.

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Add m_pendingSize to set m_size at the moment of flushing. After http://webkit.org/b/108294, m_pendingSize will be removed because the bug makes CoordinatedGraphicsScene execute all messages at the moment of flushing.

(WebCore::CoordinatedBackingStore::setSize):
(WebCore::CoordinatedBackingStore::commitTileOperations):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::prepareContentBackingStore):
(WebCore::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebCore::CoordinatedGraphicsScene::resetBackingStoreSizeToLayerSize):
(WebCore::CoordinatedGraphicsScene::createTile):
(WebCore::CoordinatedGraphicsScene::removeTile):
(WebCore::CoordinatedGraphicsScene::updateTile):

5:50 PM Changeset in webkit [142836] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

PlugIn Autostart should expire in 30 days, not half a day
https://bugs.webkit.org/show_bug.cgi?id=109767

Reviewed by Brian Weinstein.

We forgot to multiply by 60 seconds in a minute.

  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:
5:49 PM Changeset in webkit [142835] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Message generation should handle nested templates
https://bugs.webkit.org/show_bug.cgi?id=109771

Reviewed by Ryosuke Niwa.

Make it possible to have nested class template types as message parameters and
correctly gather all the needed headers and argument coder headers.

  • Scripts/webkit2/messages.py:

(class_template_headers):
Recursively figure out the types and template headers needed for a given type.

(argument_coder_headers_for_type):
(headers_for_type):
Call class_template_headers.

  • Scripts/webkit2/messages_unittest.py:

(CoreIPC):

  • Scripts/webkit2/parser.py:

(split_parameters_string):
(parse_parameters_string):

5:48 PM EnableFormFeatures edited by tkent@chromium.org
(diff)
5:43 PM Changeset in webkit [142834] by haraken@chromium.org
  • 35 edits in trunk/Source/WebCore

[V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(),
and XXXAccessorSetter() to XXXAttrSetterCustom()
https://bugs.webkit.org/show_bug.cgi?id=109679

Reviewed by Adam Barth.

For naming consistency and clarification.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateHeaderCustomCall):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(WebCore::TestObjV8Internal::customAttrAttrSetter):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

  • bindings/v8/custom/V8BiquadFilterNodeCustom.cpp:

(WebCore::V8BiquadFilterNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAttrSetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrGetterCustom):
(WebCore::V8CanvasRenderingContext2D::fillStyleAttrSetterCustom):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAttrGetterCustom):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAttrGetterCustom):
(WebCore::V8Coordinates::altitudeAccuracyAttrGetterCustom):
(WebCore::V8Coordinates::headingAttrGetterCustom):
(WebCore::V8Coordinates::speedAttrGetterCustom):

  • bindings/v8/custom/V8CustomEventCustom.cpp:

(WebCore::V8CustomEvent::detailAttrGetterCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::locationAttrSetterCustom):
(WebCore::V8DOMWindow::openerAttrSetterCustom):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::rotationRateAttrGetterCustom):
(WebCore::V8DeviceMotionEvent::intervalAttrGetterCustom):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::betaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::gammaAttrGetterCustom):
(WebCore::V8DeviceOrientationEvent::absoluteAttrGetterCustom):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAttrGetterCustom):
(WebCore::V8Document::locationAttrSetterCustom):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAttrGetterCustom):
(WebCore::V8Event::clipboardDataAttrGetterCustom):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAttrGetterCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::allAttrSetterCustom):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAttrGetterCustom):
(WebCore::V8HTMLElement::itemValueAttrSetterCustom):

  • bindings/v8/custom/V8HTMLFrameElementCustom.cpp:

(WebCore::V8HTMLFrameElement::locationAttrSetterCustom):

  • bindings/v8/custom/V8HTMLInputElementCustom.cpp:

(WebCore::V8HTMLInputElement::selectionStartAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionStartAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionEndAttrSetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrGetterCustom):
(WebCore::V8HTMLInputElement::selectionDirectionAttrSetterCustom):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAttrGetterCustom):
(WebCore::V8HTMLLinkElement::sizesAttrSetterCustom):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAttrSetterCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAttrGetterCustom):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::scopeChainAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::thisObjectAttrGetterCustom):
(WebCore::V8JavaScriptCallFrame::typeAttrGetterCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::hashAttrSetterCustom):
(WebCore::V8Location::hostAttrSetterCustom):
(WebCore::V8Location::hostnameAttrSetterCustom):
(WebCore::V8Location::hrefAttrSetterCustom):
(WebCore::V8Location::pathnameAttrSetterCustom):
(WebCore::V8Location::portAttrSetterCustom):
(WebCore::V8Location::protocolAttrSetterCustom):
(WebCore::V8Location::searchAttrSetterCustom):
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):
(WebCore::V8MessageEvent::portsAttrGetterCustom):

  • bindings/v8/custom/V8OscillatorNodeCustom.cpp:

(WebCore::V8OscillatorNode::typeAttrSetterCustom):

  • bindings/v8/custom/V8PannerNodeCustom.cpp:

(WebCore::V8PannerNode::panningModelAttrSetterCustom):
(WebCore::V8PannerNode::distanceModelAttrSetterCustom):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAttrGetterCustom):

  • bindings/v8/custom/V8SVGLengthCustom.cpp:

(WebCore::V8SVGLength::valueAttrGetterCustom):
(WebCore::V8SVGLength::valueAttrSetterCustom):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAttrGetterCustom):

  • bindings/v8/custom/V8WebKitAnimationCustom.cpp:

(WebCore::V8WebKitAnimation::iterationCountAttrGetterCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseTextAttrGetterCustom):
(WebCore::V8XMLHttpRequest::responseAttrGetterCustom):

5:35 PM Changeset in webkit [142833] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). To solve the problem,
we should generate wrapper methods for custom getters/setters.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

5:32 PM Changeset in webkit [142832] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix.

  • API/tests/testapi.c:

(assertEqualsAsNumber):
(main):

5:31 PM Changeset in webkit [142831] by Vineet
  • 10 edits
    2 adds in trunk

HTMLCollections namedItem() methods should return null than undefined for empty collections.
https://bugs.webkit.org/show_bug.cgi?id=104096

Reviewed by Kentaro Hara.

As per specification namedItem() should return null if collection is empty.
Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-dom-interfaces.html#htmlallcollection

Source/WebCore:

Test: fast/dom/htmlcollection-namedItem.html

  • bindings/js/JSHTMLAllCollectionCustom.cpp: Returning null.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::getNamedItems):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLAllCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp: Ditto.

(WebCore::V8HTMLOptionsCollection::namedItemCallback):

LayoutTests:

  • fast/dom/HTMLFormElement/move-option-between-documents-expected.txt:
  • fast/dom/HTMLFormElement/move-option-between-documents.html:
  • fast/dom/htmlcollection-namedItem-expected.txt: Added.
  • fast/dom/htmlcollection-namedItem.html: Added.
5:31 PM Changeset in webkit [142830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Make WebKit2 Derived Sources work with SDK identifiers too
https://bugs.webkit.org/show_bug.cgi?id=109763

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • WebKit2.xcodeproj/project.pbxproj: Pass SDKROOT=${SDKROOT} to DerivedSources.make
5:25 PM Changeset in webkit [142829] by tonyg@chromium.org
  • 7 edits in trunk

Fix svg/in-html/script-write.html with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=109495

Reviewed by Eric Seidel.

Source/WebCore:

This patch makes the background parser's simulateTreeBuilder() more realistic.

  1. The HTMLTreeBuilder does not call the updateStateFor() setState()s when in foreign content mode so we shouldn't do it when simulating the tree builder.
  2. HTMLTreeBuilder::processTokenInForeignContent has a list of tags which exit foreign content mode. We need to respect those.
  3. Support the <foreignObject> tag which enters and leaves foreign content mode.
  4. The tree builder sets state to DataState upon a </script> tag when not in foreign content mode. We need to do the same.

This involved creating a namespace stack where we push upon entering each namespace and pop upon leaving.
We are in foreign content if the topmost namespace is SVG or MathML.

This fixes svg/in-html/script-write.html and likely others.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::getAttributeItem): Returns the attribute of the given name. Necessary to test for <font> attributes in simulateTreeBuilder.
(WebCore):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

LayoutTests:

Added 3 new test cases:

  1. Test the behavior of a plaintext tag inside an svg foreignObject. It applies to the remainder of the document. This behavior seems a little wonky, but it matches our current behavior and Firefox's behavior.
  2. Test that we don't blindly go into HTML mode after </foreignObject>.
  3. Test that unmatched </foreignObject>s are ignored.
  • html5lib/resources/webkit02.dat:
5:17 PM Changeset in webkit [142828] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

TestWebKitAPI fails to build for iphonesimulator: 'CFNetwork/CFNetworkDefs.h' file not found
https://bugs.webkit.org/show_bug.cgi?id=109766

Patch by David Farler <dfarler@apple.com> on 2013-02-13
Reviewed by David Kilzer.

  • TestWebKitAPI/Configurations/Base.xcconfig:
  • Don't search Mac OS X header search paths when building on iOS
5:11 PM Changeset in webkit [142827] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
<http://webkit.org/b/109756>

Reviewed by Antti Koivisto.

Remove this to prevent callers from accidentally causing elements to convert to UniqueElementData.
There are two call sites (Attr and HTMLSelectElement) that legitimately need to mutate Attribute
objects in-place, they now use Element::ensureUniqueElementData()->getAttributeItem() directly instead.

Small progression on Membuster3, mostly for peace of mind.

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/Element.h:

(Element):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::getPresentationAttribute):

5:07 PM Changeset in webkit [142826] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Stronger ElementData pointer typing.
<http://webkit.org/b/109752>

Reviewed by Antti Koivisto.

Use ShareableElementData/UniqueElementData pointers instead of generic ElementData pointers
where possible. Moved some methods from base class into leaf classes that don't make sense
for both classes.

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::ShareableElementData::createWithAttributes):
(WebCore::UniqueElementData::create):
(WebCore::ElementData::makeUniqueCopy):
(WebCore::UniqueElementData::makeShareableCopy):

  • dom/Element.h:

(ElementData):
(ShareableElementData):
(UniqueElementData):
(Element):
(WebCore::Element::ensureUniqueElementData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::rebuildPresentationAttributeStyle):

5:03 PM Changeset in webkit [142825] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Reschedule shared CFRunLoopTimer instead of reconstructing it
https://bugs.webkit.org/show_bug.cgi?id=109765

Reviewed by Andreas Kling and Anders Carlsson.

Using CFRunLoopTimerSetNextFireDate is over 2x faster than deleting and reconstructing timers.

  • platform/mac/SharedTimerMac.mm:

(WebCore):
(WebCore::PowerObserver::restartSharedTimer):
(WebCore::sharedTimer):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

5:02 PM Changeset in webkit [142824] by eae@chromium.org
  • 6 edits
    2 adds in trunk

getComputedStyle returns truncated value for margin-right
https://bugs.webkit.org/show_bug.cgi?id=109759

Source/WebCore:

Reviewed by Tony Chang.

Due to an unfortunate cast in CSSComputedStyleDeclaration::
getPropertyCSSValue getComputedStyle returns truncated styles
for margin-right in cases where it isn't set to a specific pixel
value.

Test: fast/sub-pixel/computedstylemargin.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Change type of temporary value variable to float to prevent loss of precision.

LayoutTests:

Reviewed by Tony Chang.

Add test for getComputedStyle with fractional margin values.

  • fast/sub-pixel/computedstylemargin-expected.txt: Added.
  • fast/sub-pixel/computedstylemargin.html: Added.
4:59 PM Changeset in webkit [142823] by mvujovic@adobe.com
  • 14 edits
    1 add in trunk/Source

[CSS Filters] Refactor filter outsets into a class
https://bugs.webkit.org/show_bug.cgi?id=109330

Source/WebCore:

Reviewed by Dean Jackson.

In filters related code, we're often operating on 4 ints representing the top, right,
bottom, and left filter outsets. These outsets come from a filter like blur or drop-shadow.
This patch packages those ints and their related operations into a class called
IntRectExtent.

Here are some signs that we should make a class to hold those 4 ints:
1) In RenderLayer.cpp, we have a expandRectForFilterOutsets function, which looks like

feature envy.

2) RenderStyle and other classes have methods like getFilterOutsets which set the 4 ints by

reference. The calling code has to define 4 ints, which looks bloated.

3) To fix bug 109098, we will need to check if filter outsets changed, which sounds like a

nice job for an inequality operator. (https://bugs.webkit.org/show_bug.cgi?id=109098)

No new tests. No change in behavior. Just refactoring.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/IntRectExtent.h: Added.

(WebCore):
(IntRectExtent):
(WebCore::IntRectExtent::IntRectExtent):
(WebCore::IntRectExtent::top):
(WebCore::IntRectExtent::setTop):
(WebCore::IntRectExtent::right):
(WebCore::IntRectExtent::setRight):
(WebCore::IntRectExtent::bottom):
(WebCore::IntRectExtent::setBottom):
(WebCore::IntRectExtent::left):
(WebCore::IntRectExtent::setLeft):
(WebCore::IntRectExtent::expandRect):
(WebCore::IntRectExtent::isZero):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::operator+=):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::outsets):

  • platform/graphics/filters/FilterOperations.h:

(FilterOperations):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::intermediateSurfaceRect):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::FilterEffectRenderer):
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::computeSourceImageRectForDirtyRect):

  • rendering/FilterEffectRenderer.h:

(FilterEffectRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/style/RenderStyle.h:

Source/WebKit/chromium:

Update FilterOperations unit tests to use new interface for getting filter outsets.

Reviewed by Dean Jackson.

  • tests/FilterOperationsTest.cpp:

(WebKit::TEST):

4:56 PM Changeset in webkit [142822] by abarth@webkit.org
  • 3 edits in trunk/Source/WebCore

Factor HTMLTokenScanner out of HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109754

Reviewed by Eric Seidel.

This patch is just a mechanical separation of the per-token "scanning"
logic from HTMLPreloadScanner into a separate class.
HTMLPreloadScanner's job is now to keep track of the input stream and
to pump the tokenizer.

This factorization class will let us use HTMLTokenScanner on the
background thread (once we finish making it thread-safe). In a follow
up patch, I'll move HTMLTokenScanner to its own file.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLTokenScanner::HTMLTokenScanner):
(WebCore::HTMLTokenScanner::~HTMLTokenScanner):
(WebCore::HTMLTokenScanner::processPossibleTemplateTag):
(WebCore::HTMLTokenScanner::processPossibleStyleTag):
(WebCore::HTMLTokenScanner::processPossibleBaseTag):
(WebCore::HTMLTokenScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):
(WebCore):
(WebCore::HTMLPreloadScanner::~HTMLPreloadScanner):
(WebCore::HTMLPreloadScanner::appendToEnd):
(WebCore::HTMLPreloadScanner::scan):

  • html/parser/HTMLPreloadScanner.h:

(HTMLTokenScanner):
(WebCore::HTMLTokenScanner::setPredictedBaseElementURL):
(HTMLPreloadScanner):
(WebCore):

4:37 PM Changeset in webkit [142821] by leviw@chromium.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r125794) - inline-children-root-linebox-crash asserts in Chromium debug
https://bugs.webkit.org/show_bug.cgi?id=94256

Unreviewed test expectations update. Re-enabling inline-children-root-linebox-crash
as it was fixed by r139479.

  • platform/chromium/TestExpectations:
4:12 PM Changeset in webkit [142820] by esprehn@chromium.org
  • 7 edits
    2 adds in trunk

ASSERT(!renderer()->needsLayout()) when calling Element::focus() with generated content
https://bugs.webkit.org/show_bug.cgi?id=109616

Reviewed by Julien Chaffraix.

Source/WebCore:

Test: fast/css-generated-content/quote-layout-focus-crash.html

In some cases RenderQuote may mark itself and containing blocks as needing layout
during a layout, but then one of it's containing blocks will mark itself as having
finished layout so the RenderQuote and potentially some of it's ancestor renderers
needLayout(), but the ancestors above those do not.

Until we have proper pre-layout tasks we should just walk the list of quotes
right before layout and mark all their ancestors as needing layout if the quote
needs layout.

  • dom/Document.cpp:

(WebCore::Document::updateLayout): Call markQuoteContainingBlocksForLayoutIfNeeded.
(WebCore::Document::implicitClose): Call markQuoteContainingBlocksForLayoutIfNeeded.

  • rendering/RenderQuote.h:

(WebCore::RenderQuote::next): Added.

  • rendering/RenderView.cpp:

(WebCore::RenderView::markQuoteContainingBlocksForLayoutIfNeeded): Added.

  • rendering/RenderView.h:

(RenderView):

LayoutTests:

  • fast/block/float/float-not-removed-from-pre-block-expected.txt: Changed output.
  • fast/css-generated-content/quote-layout-focus-crash-expected.txt: Added.
  • fast/css-generated-content/quote-layout-focus-crash.html: Added.
4:02 PM Changeset in webkit [142819] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

EME: MediaPlayer::keyNeede() should return a bool indicating whether an event listener was triggered.
https://bugs.webkit.org/show_bug.cgi?id=109701

Reviewed by Eric Carlson.

Clients of MediaPlayer may need to do cleanup if calling keyNeeded()
results in no event listener being triggered. Return a bool (like the
v1 equivalent keyNeeded method) to indicate this.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::keyNeeded):

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerKeyNeeded):

3:57 PM Changeset in webkit [142818] by Martin Robinson
  • 3 edits in trunk

Try once again to fix the build after r142756

  • Source/autotools/PrintBuildConfiguration.m4: Do not try to print the GStreamer version

in the build output.

  • Source/autotools/SetupAutoconfHeader.m4: Remove the last reference to have_gstreamer.
3:53 PM Changeset in webkit [142817] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more buildfix for !ENABLE(PLUGIN_PROCESS) platforms.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

3:44 PM Changeset in webkit [142816] by inferno@chromium.org
  • 4 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), Bad cast in RenderBox::computeLogicalHeight

https://bugs.webkit.org/show_bug.cgi?id=107748

Reviewed by Levi Weintraub.

Source/WebCore:

Make sure that body renderer is not an inline-block display
when determining that it stretches to viewport or when paginated
content needs base height.

Test: fast/block/body-inline-block-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight):

  • rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

LayoutTests:

  • fast/block/body-inline-block-crash-expected.txt: Added.
  • fast/block/body-inline-block-crash.html: Added.
3:43 PM Changeset in webkit [142815] by shawnsingh@chromium.org
  • 2 edits in trunk/Source/WebCore

Fix debug assertion being triggered because we may access dirty normalFlowList.
https://bugs.webkit.org/show_bug.cgi?id=109740

A debug assertion in RenderLayer.h is being hit when trying to
access the normalFlowList when it is dirty. This is caused by a
new recursion that I added in RenderLayerBacking::hasVisibleNonCompositingDescendant(),
but I overlooked the need to call updateLayerListsIfNeeded()
recursively as well.

Reviewed by Simon Fraser.

No test, because there's no reliable way to test this (same as bug 85512).

  • rendering/RenderLayerBacking.cpp:

(WebCore::hasVisibleNonCompositingDescendant):
(WebCore::RenderLayerBacking::hasVisibleNonCompositingDescendantLayers):

3:37 PM Changeset in webkit [142814] by roger_fong@apple.com
  • 3 adds in trunk/Tools/TestWebKitAPI/TestWebKitAPI.vcxproj

Unreviewed. Add some missing property sheets for TestWebKitAPI.

  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props: Added.
3:37 PM Changeset in webkit [142813] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Yet another build fix

3:34 PM Changeset in webkit [142812] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed Qt-Mac and Qt-Win buildfix after r142768.

Patch by Csaba Osztrogonác <Csaba Osztrogonác> on 2013-02-13

  • WebProcess/WebProcess.h:

(WebKit):

3:09 PM Changeset in webkit [142811] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Don't restart shared timer if both the current and the new fire time are in the past
https://bugs.webkit.org/show_bug.cgi?id=109731

Reviewed by Andreas Kling.

In 40-50% of cases we reschedule the shared timer both the old and the new fire time have already passed. This can happen at least when rescheduling
a zero duration timer and when stopping a timer that was ready to fire.

We can skip rescheduling in this case, the shared timer will fire immediately anyway.

Scheduling timers calls into platform layer and can be slow. This about halves the time under setSharedTimerFireInterval in PLT3
for ~0.1% total CPU time reduction.

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::ThreadTimers):
(WebCore::ThreadTimers::setSharedTimer):
(WebCore::ThreadTimers::updateSharedTimer):
(WebCore::ThreadTimers::sharedTimerFiredInternal):

  • platform/ThreadTimers.h:

(ThreadTimers):

3:01 PM Changeset in webkit [142810] by zandobersek@gmail.com
  • 79 edits in trunk

The 'global isinf/isnan' compiler quirk required when using clang with libstdc++
https://bugs.webkit.org/show_bug.cgi?id=109325

Reviewed by Anders Carlsson.

Prefix calls to the isinf and isnan methods with std::, declaring we want to use the
two methods as they're provided by the C++ standard library being used.

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeNumber):

  • JSCTypedArrayStubs.h:

(JSC):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::constantNaN):

  • offlineasm/cloop.rb:
  • runtime/DateConstructor.cpp:

(JSC::dateUTC): Also include an opportunistic style fix.

  • runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

  • runtime/DatePrototype.cpp:

(JSC::dateProtoFuncGetMilliSeconds):
(JSC::dateProtoFuncGetUTCMilliseconds):
(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetYear):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toInteger):

  • runtime/JSDateMath.cpp:

(JSC::getUTCOffset):
(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseDate):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN):

  • runtime/MathObject.cpp:

(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
(JSC::mathProtoFuncPow):

  • runtime/PropertyDescriptor.cpp:

(JSC::sameValue):

Source/WebCore:

No new tests as there's no change in functionality.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::totalPitchRate):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::setValue):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::isValidNumber):

  • Modules/webaudio/PannerNode.cpp:

(WebCore::fixNANs):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/js/JSDataViewCustom.cpp:

(WebCore::getDataViewMember):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::setTimeout):
(WebCore::setMaximumAge):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength):

  • bindings/js/JSWebKitPointCustom.cpp:

(WebCore::JSWebKitPointConstructor::constructJSWebKitPoint):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getByIndex):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::classMethodWithClampCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

  • bindings/v8/V8Binding.cpp:

(WebCore::toInt32):
(WebCore::toUInt32):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::createPositionOptions):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertValueToQVariant):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::translate):
(WebCore::WebKitCSSMatrix::scale):
(WebCore::WebKitCSSMatrix::rotate):
(WebCore::WebKitCSSMatrix::rotateAxisAngle):
(WebCore::WebKitCSSMatrix::skewX):
(WebCore::WebKitCSSMatrix::skewY):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::percentLoaded):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):

  • html/MediaController.cpp:

(MediaController::duration):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::clearColor):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::addCue):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::floatFeature): Also include an opportunistic style fix.

  • platform/CalculationValue.cpp:

(WebCore::CalculationValue::evaluate):

  • platform/Decimal.cpp:

(WebCore::Decimal::fromDouble):

  • platform/Length.cpp:

(WebCore::Length::nonNanCalculatedValue):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/Reverb.cpp:

(WebCore::calculateNormalizationScale):

  • platform/graphics/Font.cpp:

(WebCore::Font::width):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::isLiveStream):

  • platform/graphics/gpu/LoopBlinnMathUtils.cpp:

(LoopBlinnMathUtils):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::maxTimeSeekable):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):

  • platform/graphics/opentype/OpenTypeVerticalData.cpp:

(WebCore::OpenTypeVerticalData::getVerticalTranslationsForGlyphs):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):
(WebCore::TransformationMatrix::clampedBoundsOfProjectedQuad):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • rendering/RenderMediaControlsChromium.cpp:

(WebCore::paintMediaSlider):
(WebCore::paintMediaVolumeSlider):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMediaSliderTrack):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::beginElementAt):
(WebCore::SVGAnimationElement::endElementAt):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setCurrentTime):

  • svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::addBeginTime):
(WebCore::SVGSMILElement::addEndTime):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSubstring::evaluate):
(WebCore::XPath::FunRound::round):

  • xml/XPathValue.cpp:

(WebCore::XPath::Value::toBoolean): Also include an opportunistic style fix.
(WebCore::XPath::Value::toString):

Source/WebKit/chromium:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WebKit/mac:

  • tests/DecimalTest.cpp:

(TEST_F):

Source/WTF:

  • wtf/Compiler.h: Remove the global isinf/isnan compiler quirk definitions. They're not required anymore.
  • wtf/DateMath.cpp: Move the workaround for isinf on Solaris into the std namespace. Ditto for isinf and isnan

when using MSVC. Stop bringing the isinf and isnan methods into the global scope when using other configurations.
(WTF::parseDateFromNullTerminatedCharacters):

  • wtf/IntegralTypedArrayBase.h:

(WTF::IntegralTypedArrayBase::set):

  • wtf/MathExtras.h:

(std):
(std::isinf):
(wtf_fmod):
(wtf_pow):
(doubleToInteger):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):

  • wtf/Uint8ClampedArray.h:

(WTF::Uint8ClampedArray::set):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(setAppCacheMaximumSizeCallback):
(setApplicationCacheOriginQuotaCallback):
(setDatabaseQuotaCallback):

2:57 PM Changeset in webkit [142809] by eric.carlson@apple.com
  • 16 edits
    1 add in trunk

[Mac] Caption menu should have only one item selected
https://bugs.webkit.org/show_bug.cgi?id=109730

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, media/track/track-user-preferences.html was modified to test the changes.

  • CMakeLists.txt: Add CaptionUserPreferences.cpp.
  • GNUmakefile.list.am: Ditto.
  • Target.pri: Ditto.
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_processingPreferenceChange.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Only end up with one selected track when

called because of a preferences change.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Call setClosedCaptionsVisible instead

of calling markCaptionAndSubtitleTracksAsUnconfigured directly.

(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Process all tracks,

not just track elements.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferences.cpp: Added so the functionality can be tested in DRT.

(WebCore::CaptionUserPreferences::registerForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::unregisterForPreferencesChangedCallbacks):
(WebCore::CaptionUserPreferences::setUserPrefersCaptions):
(WebCore::CaptionUserPreferences::captionPreferencesChanged):
(WebCore::CaptionUserPreferences::preferredLanguages):
(WebCore::CaptionUserPreferences::setPreferredLanguage):
(WebCore::CaptionUserPreferences::displayNameForTrack):

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::registerForPreferencesChangedCallbacks): Moved some logic

to base class.

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged): Ditto.

LayoutTests:

  • media/track/track-user-preferences-expected.txt:
  • media/track/track-user-preferences.html: Update test to check for reactions to preferences.
2:54 PM Changeset in webkit [142808] by aelias@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[chromium] Fix scaling in WebViewImpl::handleGestureEvent
https://bugs.webkit.org/show_bug.cgi?id=109671

Reviewed by James Robinson.

My last patch broke a bunch of things in handleGestureEvent that
assumed the event came in scaled, most notably tap highlight and
double-tap zoom. Switch those to PlatformGestureEvent.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::handleGestureEvent):
(WebKit::WebViewImpl::bestTapNode):
(WebKit::WebViewImpl::enableTapHighlight):

  • src/WebViewImpl.h:

(WebViewImpl):

  • tests/LinkHighlightTest.cpp:

(WebCore::TEST):

2:54 PM Changeset in webkit [142807] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove bogus ASSERT in WebFrameProxy::didStartProvisionalLoad
https://bugs.webkit.org/show_bug.cgi?id=109733

Reviewed by Sam Weinig.

After http://trac.webkit.org/changeset/142555, this ASSERT is
triggering on these tests:

fast/dom/window-load-crash.html
fast/frames/seamless/seamless-hyperlink-named.html
fast/frames/seamless/seamless-hyperlink.html

The ASSERT appears to be bogus. This patch removes it.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

2:46 PM Changeset in webkit [142806] by weinig@apple.com
  • 17 edits
    1 copy
    4 moves
    2 adds
    14 deletes in trunk/Source/WebKit2

Consolidate main functions in WebKit2 now that they are all identical
https://bugs.webkit.org/show_bug.cgi?id=109748

Reviewed by Anders Carlsson.

  • Consolidates all the LegacyProcess main functions into ChildProcessMain.mm
  • Consolidates all the XPCService main functions into XPCServiceMain.mm and XPCServiceMain.Development.mm
  • Rename existing ChildProcessMain.h/mm to ChildProcessEntryPoint.h/mm to match the XPCService ones.
  • Switch LegacyProcess to use the "entry point in the plist" idiom, instead of hard coding each one, again matching the XPCService.
  • Configurations/BaseLegacyProcess.xcconfig: Add base configuration to hold common legacy process options.
  • Configurations/BaseXPCService.xcconfig:
  • Configurations/NetworkProcess.xcconfig:
  • Configurations/OfflineStorageProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/SharedWorkerProcess.xcconfig:
  • Configurations/WebContentProcess.xcconfig: Renamed form WebProcess.xcconfig.
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm: Removed.
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm:
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Removed.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Removed.
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h: Removed.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: Replaced.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h: Removed.
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm:
  • SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm: Removed.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
2:43 PM Changeset in webkit [142805] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Exclusions] ExclusionPolygon reflex vertices should constrain the first fit location.
https://bugs.webkit.org/show_bug.cgi?id=107568

Patch by Hans Muller <hmuller@adobe.com> on 2013-02-13
Reviewed by Dirk Schulze.

Source/WebCore:

The ExclusionPolygon::firstIncludedIntervalLogicalTop() method now includes offset edges
for each of the polygon's reflex vertices. The motivation for this change is explained
here: http://hansmuller-webkit.blogspot.com/2013/01/getting-to-point-reflex-vertices.html.

Test: fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::isReflexVertex): Given three vertices that represent a pair of connected polygon edges, return true if the second vertex is a reflex vertex.
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This method now includes offset edges for reflex vertices.

  • rendering/ExclusionPolygon.h:

(WebCore::OffsetPolygonEdge::OffsetPolygonEdge): Added a constructor for creating an OffsetPolygonEdge given a reflex vertex.
(WebCore::OffsetPolygonEdge::edgeIndex): Changed this property from unsigned to int. Now using -1 to indicate that the offset edge doesn't correspond to a single polygon edge.

LayoutTests:

In this carefully contrived test case, the Y coordinate of the origin of the line
of text is only computed correctly if the constraints implied by the polygon's
reflex vertices are considered.

  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-first-fit-reflex.html: Added.
2:40 PM Changeset in webkit [142804] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Change another use of (SpecCell & ~SpecString) to SpecObject.

Reviewed by Mark Hahnenberg.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

2:40 PM Changeset in webkit [142803] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

CSSPreloadScanner should not depend on HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=109742

Reviewed by Eric Seidel.

There's no need for the CSSPreloadScanner to depend on HTMLToken. On
the background thread, we'll likely want to use a CompactHTMLToken for
preload scanning, so this dependency is problematic. This patch also
teaches the CSSPreloadScanner how to scan LChars.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::~CSSPreloadScanner):
(WebCore):
(WebCore::CSSPreloadScanner::scan):

  • html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::HTMLPreloadScanner::processToken):

2:39 PM Changeset in webkit [142802] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Tools

cr-linux debug should use clang and maybe be a components build
https://bugs.webkit.org/show_bug.cgi?id=108512

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

Modified GCE cr-linux-debug-ews bot build scripts to configure clang over gcc for build performance.
Build bots will update clang with each bot cycle.
Updated GCE image paths to suit gcutil 1.6.1.

  • EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-clang-linux.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
  • EWSTools/start-queue.sh:
2:39 PM Changeset in webkit [142801] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix !ENABLE(BLOB) build.

Reviewed by NOBODY (OOPS!).

  • fileapi/ThreadableBlobRegistry.cpp: (WebCore::ThreadableBlobRegistry::getCachedOrigin):
  • page/SecurityOrigin.cpp: (WebCore::getCachedOrigin):
2:36 PM Changeset in webkit [142800] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Mark Hahnenberg.

If you add it to the list of relevant node types, you also need to make sure
it's listed as either hasChild or one of the other kinds. Otherwise you get
an assertion. This is causing test failures in run-javascriptcore-tests.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::MinifiedNode::hasChild):

2:31 PM Changeset in webkit [142799] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking a few tests as slow on the debug builds. This shall prevent them timing out unnecessarily.

  • platform/gtk/TestExpectations:
2:17 PM Changeset in webkit [142798] by jchaffraix@webkit.org
  • 14 edits
    4 adds in trunk

[CSS Grid Layout] Adding or removing grid items doesn't properly recompute the track sizes
https://bugs.webkit.org/show_bug.cgi?id=109100

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-removal-track-breadth-update.html

The test uncovered several bugs in our implementation that is fixed as part
of this change. They will be detailed below.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Added this function to share the code between minContentForChild and maxContentForChild.
Also forced a relayout in this case to avoid getting a wrong answer (e.g. the logical height
constrained by the previous layout's grid breadth).

(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Updated to use logicalContentHeightForChild.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated to match the specification and set max breadth to current breadth per the specification.
This made us over-grow some cases in the test.

(WebCore::RenderGrid::distributeSpaceToTracks):
Updated to match the specification and use an extra variable to do the intermediate spreading. Also removed
a now unneeded max. This fixes the case of multiple grid items in the same grid area that was completely broken.

(WebCore::RenderGrid::layoutGridItems):
Added a FIXME about always relaying out content sized tracks' children.

  • rendering/RenderGrid.h:

Added logicalContentHeightForChild.

LayoutTests:

  • fast/css-grid-layout/grid-item-addition-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-addition-track-breadth-update.html: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update-expected.txt: Added.
  • fast/css-grid-layout/grid-item-removal-track-breadth-update.html: Added.

New tests.

  • fast/css-grid-layout/resources/grid.css:

(.constrainedContainer):
(.unconstrainedContainer):
Added these class to share them with other tests.

  • fast/css-grid-layout/auto-content-resolution-columns.html:
  • fast/css-grid-layout/auto-content-resolution-rows.html:
  • fast/css-grid-layout/implicit-columns-auto-resolution.html:
  • fast/css-grid-layout/implicit-position-dynamic-change.html:
  • fast/css-grid-layout/implicit-rows-auto-resolution.html:
  • fast/css-grid-layout/minmax-max-content-resolution-columns.html:
  • fast/css-grid-layout/minmax-max-content-resolution-rows.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
  • fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:

Removed constrainedContainer definition as it was moved to grid.css.

2:12 PM Changeset in webkit [142797] by schenney@chromium.org
  • 4 edits in trunk/LayoutTests

[Chromium] Rebasline after r142765

Unreviewed test expectations update.

The change caused sub-pixel changing in SVG-as-image positions.

  • platform/chromium-mac-lion/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-mac-snowleopard/svg/as-background-image/svg-as-background-5-expected.png:
  • platform/chromium-win/svg/as-background-image/svg-as-background-5-expected.png:
2:03 PM Changeset in webkit [142796] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

Clean up some style nits in HTMLPreloadScanner
https://bugs.webkit.org/show_bug.cgi?id=109738

Reviewed by Tony Gentilcore.

This patch just fixes a few style nits I noticed when reading through
the code.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::StartTagScanner):
(WebCore::HTMLPreloadScanner::processPossibleStyleTag):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::isSafeToSendToAnotherThread):

  • html/parser/HTMLResourcePreloader.h:

(PreloadRequest):
(WebCore::PreloadRequest::PreloadRequest):
(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):

2:02 PM Changeset in webkit [142795] by alecflett@chromium.org
  • 6 edits
    1 delete in trunk

Unreviewed, rolling out r142747.
http://trac.webkit.org/changeset/142747
https://bugs.webkit.org/show_bug.cgi?id=109746

broke component build (Requested by alecf_gardening on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
1:56 PM Changeset in webkit [142794] by Christophe Dumez
  • 8 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using WebString in ewk_cookie_manager, ewk_form_submission_request and ewk_text_checker
https://bugs.webkit.org/show_bug.cgi?id=108794

Reviewed by Alexey Proskuryakov.

Stop using WebString in ewk_cookie_manager, ewk_form_submission_request
and ewk_text_checker as it is internal C++ API. WKString and
WKEinaSharedString are used instead.

  • UIProcess/API/cpp/efl/WKEinaSharedString.cpp:

(WKEinaSharedString::leakString): Add leakString() method to
WKEinaSharedString so that we can conveniently convert a WKString to a
Eina shared string and take ownership of it.

  • UIProcess/API/cpp/efl/WKEinaSharedString.h:
  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(getHostnamesWithCookiesCallback):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(EwkFormSubmissionRequest::copyFieldValue):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):

  • UIProcess/API/efl/ewk_form_submission_request_private.h:

(EwkFormSubmissionRequest):

  • UIProcess/API/efl/ewk_text_checker.cpp:

(checkSpellingOfString):
(guessesForWord):
(learnWord):
(ignoreWord):

  • UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:

(TEST_F): Add API test for new WKEinaSharedString::leakString() method.

1:55 PM Changeset in webkit [142793] by leviw@chromium.org
  • 3 edits
    2 adds in trunk

Bidi-Isolated inlines can cause subsequent content to not be rendered
https://bugs.webkit.org/show_bug.cgi?id=108137

Reviewed by Eric Seidel.

Source/WebCore:

First step in fixing how inline isolates behave with collapsed spaces.
webkit.org/b/109624 tracks the overarching issue.

Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html

  • rendering/InlineIterator.h:

(WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while
ignoring spaces, ensure we leave it considering them again. This can result in
including spaces that should be ignored following the isolate on the line, but
failing to do so results in those contents not being rendered at all.

LayoutTests:

  • fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added.
  • fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added.
1:49 PM Changeset in webkit [142792] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109744

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

1:48 PM Changeset in webkit [142791] by akling@apple.com
  • 16 edits in trunk/Source/WebCore

Better names for ElementAttributeData & subclasses.
<http://webkit.org/b/109529>

Reviewed by Antti Koivisto.

  • ElementAttributeData => ElementData

Because ElementAttributeData won't be a good name once we move some non-attribute related
things to this structure.

  • ImmutableElementAttributeData => ShareableElementData

These objects can be shared with other Elements that have the same attribute name/value pairs.

  • MutableElementAttributeData => UniqueElementData

These objects contain data that is unique to a specific Element, and cannot be shared with
other Elements. This is what's important about it, not that its underlying storage is mutable.

  • attributeData() -> elementData()
  • updatedAttributeData() -> elementDataWithSynchronizedAttributes()
  • ensureUpdatedAttributeData() -> ensureElementDataWithSynchronizedAttributes()
  • mutableAttributeData() -> ensureUniqueElementData()

Ride-along renames. Much less vague than previous names IMO.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

  • dom/Attr.cpp:

(WebCore::Attr::elementAttribute):

  • dom/DocumentSharedObjectPool.cpp:

(WebCore::ShareableElementDataCacheKey::ShareableElementDataCacheKey):
(WebCore::ShareableElementDataCacheKey::operator!=):
(WebCore::ShareableElementDataCacheEntry::ShareableElementDataCacheEntry):
(ShareableElementDataCacheEntry):
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):

  • dom/DocumentSharedObjectPool.h:

(DocumentSharedObjectPool):

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::attributes):
(WebCore::Element::getAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::attributeChanged):
(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):
(WebCore::Element::parserSetAttributes):
(WebCore::Element::hasAttributes):
(WebCore::Element::hasEquivalentAttributes):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::Element::addAttributeInternal):
(WebCore::Element::getAttributeNode):
(WebCore::Element::getAttributeNodeNS):
(WebCore::Element::hasAttribute):
(WebCore::Element::hasAttributeNS):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::getURLAttribute):
(WebCore::Element::getNonEmptyURLAttribute):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::createUniqueElementData):
(WebCore::Element::reportMemoryUsage):
(WebCore::ElementData::deref):
(WebCore::ElementData::ElementData):
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ElementData::createShareableWithAttributes):
(WebCore::ElementData::createUnique):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
(WebCore::ElementData::makeMutableCopy):
(WebCore::ElementData::makeImmutableCopy):
(WebCore::ElementData::setPresentationAttributeStyle):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::isEquivalent):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::ElementData::getAttributeItemIndexSlowCase):

  • dom/Element.h:

(ElementData):
(WebCore::ElementData::isUnique):
(ShareableElementData):
(UniqueElementData):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::elementData):
(Element):
(WebCore::Element::elementDataWithSynchronizedAttributes):
(WebCore::Element::ensureElementDataWithSynchronizedAttributes):
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
(WebCore::Element::hasAttributesWithoutUpdate):
(WebCore::Element::idForStyleResolution):
(WebCore::Element::classNames):
(WebCore::Element::attributeCount):
(WebCore::Element::attributeItem):
(WebCore::Element::getAttributeItem):
(WebCore::Element::updateInvalidAttributes):
(WebCore::Element::hasID):
(WebCore::Element::hasClass):
(WebCore::Element::ensureUniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::presentationAttributeStyle):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::attributeItem):

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::compareDocumentPosition):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::ensureMutableInlineStyle):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::inlineStyleCSSOMWrapper):
(WebCore::StyledElement::setInlineStyleFromString):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::addSubresourceAttributeURLs):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::inlineStyle):
(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • html/ClassList.cpp:

(WebCore::ClassList::classNames):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::updateAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):

1:47 PM Changeset in webkit [142790] by jochen@chromium.org
  • 9 edits in trunk/Tools

[chromium] fix TestRunner build with enable_webrtc=0
https://bugs.webkit.org/show_bug.cgi?id=109700

Reviewed by Tony Chang.

We can't use ENABLE() macros in the TestRunner library, however,
ENABLE_WEBRTC is defined by build/common.gypi, so we can use it.

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::userMediaClient):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
1:40 PM Changeset in webkit [142789] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

Rearranged the code somewhat to reduce the number of
DFG related ifdefs.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

1:36 PM Changeset in webkit [142788] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash when encountering <object style="resize:both;">
https://bugs.webkit.org/show_bug.cgi?id=109728

Source/WebCore:

See also https://code.google.com/p/chromium/issues/detail?id=175535
This bug can be reproduced on
http://dramalink.net/tudou.y/?xink=162601060

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

Test: fast/css/resize-object-crash.html

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):
Only call paintResizer() if we have a layer and canResize() is true

LayoutTests:

See also https://code.google.com/p/chromium/issues/detail?id=175535

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-13
Reviewed by Eric Seidel.

  • fast/css/resize-object-crash-expected.txt: Added.
  • fast/css/resize-object-crash.html: Added.
1:33 PM Changeset in webkit [142787] by arko@motorola.com
  • 3 edits in trunk/Source/WebCore

[Microdata] HTMLPropertiesCollection code cleanup
https://bugs.webkit.org/show_bug.cgi?id=109721

Reviewed by Ryosuke Niwa.

Removed forward declaration of DOMStringList class.
Removed unused findRefElements() method declaration.
Also Removed unused parameter Element* from updatePropertyCache() method.

No new test since no change in behavior.

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateNameCache):

  • html/HTMLPropertiesCollection.h:

(WebCore):
(HTMLPropertiesCollection):
(WebCore::HTMLPropertiesCollection::updatePropertyCache):

1:30 PM Changeset in webkit [142786] by commit-queue@webkit.org
  • 9 edits in trunk

[WebGL][EFL][GTK][Qt]Add support for OES_vertex_array_object.
https://bugs.webkit.org/show_bug.cgi?id=109382

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-13
Reviewed by Kenneth Russell.

Source/WebCore:

Covered by fast/canvas/webgl/oes-vertex-array-object.html

This patch adds support for using Vertex Array Object with OpenGl.
The patch adds support for loading necessary opengl functions
and support for checking GL_ARB_vertex_array_object. The support
for OES_vertex_array_object is advertised if GL_ARB_vertex_array_object is
supported.

  • platform/graphics/OpenGLShims.cpp:

(WebCore::initializeOpenGLShims):

  • platform/graphics/OpenGLShims.h:

(_OpenGLFunctionTable):
Added support for loading the necessary functions.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::createVertexArrayOES):
(WebCore::Extensions3DOpenGL::deleteVertexArrayOES):
(WebCore::Extensions3DOpenGL::isVertexArrayOES):
(WebCore::Extensions3DOpenGL::bindVertexArrayOES):
(WebCore::Extensions3DOpenGL::supportsExtension):

(WebCore):
(WebCore::Extensions3DOpenGL::isVertexArrayObjectSupported):

  • platform/graphics/opengl/Extensions3DOpenGL.h:

(Extensions3DOpenGL):

LayoutTests:

Enable oes-vertex-array-object for EFL port.

  • fast/canvas/webgl/oes-vertex-array-object-expected.txt:
  • fast/canvas/webgl/oes-vertex-array-object.html:
  • platform/efl/TestExpectations:
1:29 PM Changeset in webkit [142785] by roger_fong@apple.com
  • 4 edits
    3 copies
    11 adds in trunk

TestWebKitAPI, record-memory and gtest-md projects and property sheets for VS2010.
https://bugs.webkit.org/show_bug.cgi?id=107034

Reviewed by Brent Fulgham.

  • TestWebKitAPI/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Added.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPostBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd.
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIPreBuild.cmd: Copied from Tools/TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd.
  • win/record-memory: Added.
  • win/record-memory/main.cpp: Copied from Tools/record-memory-win/main.cpp.
  • win/record-memory/record-memory.vcxproj: Added.
  • win/record-memory/record-memory.vcxproj.filters: Added.
  • win/record-memory/record-memoryCommon.props: Added.
  • win/record-memory/record-memoryDebug.props: Added.
  • win/record-memory/record-memoryRelease.props: Added.
  • gtest/msvc/gtest-md.vcxproj: Added.
  • gtest/msvc/gtest-md.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKit.sln:
1:29 PM Changeset in webkit [142784] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the Lion build.

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

1:27 PM Changeset in webkit [142783] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove support for the DispatchOnConnectionQueue message attribute
https://bugs.webkit.org/show_bug.cgi?id=109743

Reviewed by Sam Weinig.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC):

  • Scripts/webkit2/messages.py:

(handler_function):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
1:22 PM Changeset in webkit [142782] by commit-queue@webkit.org
  • 7 edits
    2 deletes in trunk/Source

chromium: remove CompositorHUDFontAtlas
https://bugs.webkit.org/show_bug.cgi?id=109328

Patch by Eberhard Graether <egraether@google.com> on 2013-02-13
Reviewed by James Robinson.

After switching the HudLayer to use skia's font rendering the
CompositorHUDFontAtlas has become obsolete. This change removes
this class and the related WebLayerTreeView API.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
  • platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
1:17 PM Changeset in webkit [142781] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

StorageManager should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109741

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
(WebKit::StorageManager::processWillCloseConnection):
(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
1:15 PM Changeset in webkit [142780] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ForwardInt32ToDouble is not in DFG::MinifiedNode's list of relevant node types
https://bugs.webkit.org/show_bug.cgi?id=109726

Reviewed by Gavin Barraclough.

This is asymptomatic because ForwardInt32ToDouble is only used in SetLocals, in
which case the value is already stored to the stack. Still, we should fix this.

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

1:00 PM Changeset in webkit [142779] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG LogicalNot/Branch peephole removal and inversion ignores the possibility of things exiting
https://bugs.webkit.org/show_bug.cgi?id=109489

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

If things can exit between the LogicalNot and the Branch then don't peephole.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Reviewed by Mark Hahnenberg.

  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit-expected.txt: Added.
  • fast/js/dfg-branch-logical-not-peephole-around-osr-exit.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-branch-logical-not-peephole-around-osr-exit.js: Added.

(foo):

12:58 PM Changeset in webkit [142778] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

EventDispatcher should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109736

Reviewed by Andreas Kling.

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::create):
(WebKit):
(WebKit::EventDispatcher::EventDispatcher):
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebPage/EventDispatcher.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:

(WebKit):
(WebKit::WebProcess::eventDispatcher):
(WebProcess):

12:52 PM Changeset in webkit [142777] by Martin Robinson
  • 2 edits in trunk

Try to fix the build after r142756

  • Source/autotools/SetupAutomake.m4: Instead of using the (now gone) have_gstreamer

variable, activate GStreamer if either web audio or web video is enabled.

12:51 PM Changeset in webkit [142776] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r142768.

r142768 broke the EFL WK2 build due to wrong member initialization
order in the WebProcess constructor initialization list.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

12:34 PM Changeset in webkit [142775] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Small update to speech bubble for captions menu [Mac]
https://bugs.webkit.org/show_bug.cgi?id=109641

Reviewed by Eric Carlson

Small adjustment to the embedded SVG that draws a speech bubble
for the captions button. Remove a polygon that was so small
it looked like a rendering error.

  • css/mediaControlsQuickTime.css:

(video::-webkit-media-controls-toggle-closed-captions-button):

12:34 PM Changeset in webkit [142774] by dino@apple.com
  • 9 edits in trunk

Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648

Reviewed by Eric Carlson.

Source/WebCore:

Add a virtual override to the platform-specific
defaultEventHandler to intercept any click in the controls,
and hide the captions menu if it is showing.

Test: media/video-controls-captions-trackmenu-hide-on-click.html

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::defaultEventHandler): Override from MediaControls. Hide

captions menu if a click event comes in.

  • html/shadow/MediaControlsApple.h:

LayoutTests:

New test for captions menu. Skip it everywhere but Mac.

  • media/video-controls-captions-trackmenu-hide-on-click.html: Added.
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
12:32 PM Changeset in webkit [142773] by tommyw@google.com
  • 10 edits in trunk

MediaStream API: Use the source id when creating new tracks
https://bugs.webkit.org/show_bug.cgi?id=109688

Reviewed by Adam Barth.

Source/Platform:

Added id to initialize and renamed audio/videoSources to audio/videoTracks.

  • chromium/public/WebMediaStream.h:

(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):

  • chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

Source/WebCore:

This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.

Covered by existing tests.

  • platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):

  • platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::initialize):
(WebKit):

  • platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Tools:

Switching mock to new API.

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

12:23 PM Changeset in webkit [142772] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

Use fancy new Vector-based String constructors in the WebVTT parser
https://bugs.webkit.org/show_bug.cgi?id=109619

Reviewed by Benjamin Poulain.

No change in behavior. Added some FIXMEs for future perf optimization.

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::constructTreeFromToken):

12:14 PM Changeset in webkit [142771] by bfulgham@webkit.org
  • 6 edits in trunk/Tools

[Windows] Unreviewed VS2010 fix to add $(ConfigurationBuildDir)/private
to include paths, to match VS2005 build behavior.

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
12:11 PM Changeset in webkit [142770] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

WebKit ignores column-rules wider than column-gap
https://bugs.webkit.org/show_bug.cgi?id=15553

Paint column rules even if they are wider than the gap.
Rules wider than the gap should just overlap with column contents.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-02-13
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/rule-thicker-than-gap.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintColumnRules):

LayoutTests:

  • fast/multicol/rule-thicker-than-gap-expected.html: Added.
  • fast/multicol/rule-thicker-than-gap.html: Added.
12:08 PM Changeset in webkit [142769] by oliver@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Remove unnecessary indirection to non-local variable access operations
https://bugs.webkit.org/show_bug.cgi?id=109724

Reviewed by Filip Pizlo.

Linked bytecode now stores a direct pointer to the resolve operation
vectors, so the interpreter no longer needs a bunch of indirection to
to perform non-local lookup.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/Instruction.h:
  • dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canInlineOpcode):

  • dfg/DFGGraph.h:

(ResolveGlobalData):
(ResolveOperationData):
(PutToBaseOperationData):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_put_to_base):
(JSC::JIT::emit_op_resolve):
(JSC::JIT::emitSlow_op_resolve):
(JSC::JIT::emit_op_resolve_base):
(JSC::JIT::emitSlow_op_resolve_base):
(JSC::JIT::emit_op_resolve_with_base):
(JSC::JIT::emitSlow_op_resolve_with_base):
(JSC::JIT::emit_op_resolve_with_this):
(JSC::JIT::emitSlow_op_resolve_with_this):
(JSC::JIT::emitSlow_op_put_to_base):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_put_to_base):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
12:08 PM Changeset in webkit [142768] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make PluginProcessConnectionManager a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109727

Reviewed by Andreas Kling.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::create):
(WebKit):
(WebKit::PluginProcessConnectionManager::PluginProcessConnectionManager):
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
(WebKit::WebProcess::pluginProcessConnectionManager):

  • WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

12:05 PM Changeset in webkit [142767] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r182150. Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • DEPS:
11:56 AM Changeset in webkit [142766] by eric@webkit.org
  • 3 edits in trunk/Source/WTF

Don't copy Vector<UChar> when passing to new String methods from bug 109617
https://bugs.webkit.org/show_bug.cgi?id=109708

Reviewed by Tony Gentilcore.

Thanks for the catch Darin.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::create8BitIfPossible):

11:44 AM Changeset in webkit [142765] by pdr@google.com
  • 14 edits
    6 adds in trunk

Replace SVG bitmap cache with directly-rendered SVG
https://bugs.webkit.org/show_bug.cgi?id=106159

Reviewed by Tim Horton.

Source/WebCore:

This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
http://ie.microsoft.com/testdrive/Performance/Chalkboard/

On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(http://philbit.com/SvgImagePerformance/viewport.html):

without patch: ~20FPS
with patch: ~55FPS

The bitmap SVG image cache had several shortcomings:

  • The bitmap cache prevented viewport rendering. (WK104693)
  • Bitmap memory usage was high. (WK106484)
  • Caching animating images was expensive.

This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

Tests: svg/as-image/svg-image-scaled.html

svg/as-image/svg-image-viewbox.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):

SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):

drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:

the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed

SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.

(WebCore::SVGImage::drawPatternForContainer):

For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.

(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):

  • svg/graphics/SVGImage.h:

(WebCore):
(SVGImage):

  • svg/graphics/SVGImageCache.cpp:

Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.

To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.

Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.

(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):

Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.

(WebCore::SVGImageCache::imageForRenderer):

A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.

  • svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

  • svg/graphics/SVGImageForContainer.cpp: Added.

(WebCore):

SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.

(WebCore::SVGImageForContainer::size):

This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

  • svg/graphics/SVGImageForContainer.h: Added.

(WebCore):
(SVGImageForContainer):

In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

LayoutTests:

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

  • platform/chromium/TestExpectations:
  • svg/as-image/svg-image-scaled-expected.html: Added.
  • svg/as-image/svg-image-scaled.html: Added.
  • svg/as-image/svg-image-viewbox-expected.html: Added.
  • svg/as-image/svg-image-viewbox.html: Added.
11:30 AM Changeset in webkit [142764] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Avoid updating timer heap when nothing changes
https://bugs.webkit.org/show_bug.cgi?id=109630

Reviewed by Andreas Kling.

When the fire time of a Timer is changed we remove it from the timer heap and reinsert it. This is pretty slow.
Turns out that in ~80% of cases we are already in the heap and the insertion position is the same as the
original position. We can check if anything is actually going to change before doing this work.

This makes starting a timer ~30% faster in average, ~0.1% progression in PLT3.

  • platform/Timer.cpp:

(TimerHeapLessThanFunction):
(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::parentHeapPropertyHolds):
(WebCore):
(WebCore::childHeapPropertyHolds):
(WebCore::TimerBase::hasValidHeapPosition):

The code here assumes that STL heap is a normal binary heap. If there is a different implementation
somewhere the assertions will catch it.

(WebCore::TimerBase::updateHeapIfNeeded):

Skip updating the heap if it is already valid.

(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(TimerBase):

11:18 AM Changeset in webkit [142763] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Make SecItemShimProxy be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109719

Reviewed by Sam Weinig.

This adds a WantsConnection message attribute to be used for messages whose handlers
should take the connection the message was delivered to.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::handleMessage):
Add new handleMessage overload.

  • Scripts/webkit2/messages.py:

(async_message_statement):
(generate_message_handler):
Handle the WantsMessage attribute.

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::shared):
Use dispatch_once and adoptRef.

(WebKit::SecItemShimProxy::SecItemShimProxy):
Initialize the queue.

(WebKit::SecItemShimProxy::initializeConnection):
Add the proxy as a work queue message receiver.

(WebKit::SecItemShimProxy::secItemRequest):
This no longer needs to call out to a dispatch queue, it's already on a queue.

  • UIProcess/mac/SecItemShimProxy.messages.in:

This doesn't need to be a legacy receiver. Also, add the WantsConnection message.

10:51 AM Changeset in webkit [142762] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r142736.
http://trac.webkit.org/changeset/142736
https://bugs.webkit.org/show_bug.cgi?id=109716

Broke ABI, nightly builds crash on launch (Requested by ap on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

10:49 AM Changeset in webkit [142761] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[GTK] Remove remaining dead code from the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109707

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Source/WebCore:

  • platform/KURL.cpp:

(WebCore::appendEncodedHostname):

  • platform/text/TextEncoding.cpp:

(WebCore::TextEncoding::encode):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::buildBaseTextCodecMaps):
(WebCore::extendTextCodecMaps):

Source/WTF:

  • wtf/unicode/Unicode.h:
10:37 AM Changeset in webkit [142760] by wangxianzhu@chromium.org
  • 4 edits
    1 add in trunk

.: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects.
https://bugs.webkit.org/show_bug.cgi?id=108695

Add a manual test. Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

Reviewed by Abhishek Arya.

  • ManualTests/scrolling-coordinator-viewport-constrained-crash.html: Added.

Source/WebCore: Heap-use-after-free in WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects
https://bugs.webkit.org/show_bug.cgi?id=108695

See comments of RenderLayerModelObject::willBeDestroyed() below for details.

Reviewed by Abhishek Arya.

Test: ManulTests/scrolling-coordinator-viewport-constrained-crash.html
Unable to write a normal layout test because
1) must waitUntilDone() to reproduce the crash but the redirected URL can't notifyDone();
2) Can't use a frame to contain the test because ScrollingCoordinator handles only the main frame.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed): Moved removeViewportConstrainedObject() call into RenderLayerModelObject::willBeDestroyed() because only RenderLayerModelObjects can be added as viewportConstrainedObjects.

  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::willBeDestroyed): Changed this->view() (then view->frameView()) to this->frame() (then frame->view()) because when willBeDestroyed() is called, the document has set its renderView to 0 thus this->view() will return 0, causing removeViewportConstrainedObject() not called and a deleted RenderLayerModelObject in FrameView's viewportConstrainedObjects.

9:49 AM Changeset in webkit [142759] by fmalita@chromium.org
  • 17 edits in trunk

[SVG] OOB access in SVGListProperty::replaceItemValues()
https://bugs.webkit.org/show_bug.cgi?id=109293

Source/WebCore:

Replacing a list property item with itself should be a no-op. This patch updates the related
APIs and logic to detect the self-replace case and prevent removal of the item from the list.

To avoid scanning the list multiple times, removeItemFromList() is updated to operate on
indices and a findItem() method is added to resolve an item to an index.

Reviewed by Dirk Schulze.

No new tests: updated existing tests cover the change.

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::findItem):
(SVGAnimatedListPropertyTearOff):
(WebCore::SVGAnimatedListPropertyTearOff::removeItemFromList):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::findItem):
(SVGAnimatedPathSegListPropertyTearOff):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
Add a findItem() delegating method, and update removeItemFromList() to use the new
index-based API.

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::insertItemBeforeValues):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValues):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(SVGListProperty):
Updated to handle the no-op case for insertItemBefore() & replaceItem().

  • svg/properties/SVGListPropertyTearOff.h:

(WebCore::SVGListPropertyTearOff::findItem):
(WebCore::SVGListPropertyTearOff::removeItemFromList):
Index-based API updates.

(WebCore::SVGListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue):
Detect the self-replace case and return without removing the item from the list.

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::findItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):

  • svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemValue):
(WebCore::SVGStaticListPropertyTearOff::processIncomingListItemWrapper):
Index-based API updates.

LayoutTests:

Updated tests to cover the crash and new behavior.

Reviewed by Dirk Schulze.

  • svg/dom/SVGLengthList-basics-expected.txt:
  • svg/dom/SVGLengthList-basics.xhtml:
  • svg/dom/SVGNumberList-basics-expected.txt:
  • svg/dom/SVGNumberList-basics.xhtml:
  • svg/dom/SVGPointList-basics-expected.txt:
  • svg/dom/SVGPointList-basics.xhtml:
  • svg/dom/SVGTransformList-basics-expected.txt:
  • svg/dom/SVGTransformList-basics.xhtml:
9:46 AM Changeset in webkit [142758] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Cleanup of graphics related code in EwkView
https://bugs.webkit.org/show_bug.cgi?id=109377

Reviewed by Anders Carlsson.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

Initialize the evasGL dependencies here and
set m_isAccelerated to false if this fails.

Set the coordinated graphics scene as active
when using fixed layout.

(EwkView::setSize):

Add a method to set the size and user-viewport
transform from the outside. The idea is moving
this to our pure WK C API in the future.

(EwkView::transformFromScene):
(EwkView::transformToScene):

Update the transform methods to use the user-
viewport transform.

(EwkView::paintToCurrentGLContext):
(EwkView::paintToCairoSurface):

Add methods to paint to either the current GL context
or to a given cairo_surface_t (for software fallback
cases).

(EwkView::displayTimerFired):

Clean up and use the two above methods.

(EwkView::scheduleUpdateDisplay):

Use the new size() methods instead of using the
smart-object data directly.

(EwkView::createGLSurface):

Make this method use size() to query the surface size
and avoid creating the context (done in ctor now).
Also avoid using the smart-object data directly.

(EwkView::enterAcceleratedCompositingMode):
(EwkView::exitAcceleratedCompositingMode):

Turn on/off the use of the coord. graphics scene.

(EwkView::handleEvasObjectCalculate):

Use the new setSize and setUserViewportTransform.

(EwkView::takeSnapshot):

  • UIProcess/API/efl/EwkView.h:

(WebCore):
(EwkView):
(EwkView::size):
(EwkView::setUserViewportTransform):
(EwkView::userViewportTransform):

Add the new method definitions and rename isHardwareAccelerated
to isAccelerated which fits better with the naming in WebCore.

9:26 AM Changeset in webkit [142757] by tasak@google.com
  • 6 edits in trunk

Source/WebCore: [Refactoring] StyleResolver::State should have methods to access its member variables.
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

Made all member variables private and added methods to access the
variables, because most of the member variables are read-only.
We don't need to update those read-only variables while resolving
styles.

No new tests, because just refactoring.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::State::initElement):
(WebCore::StyleResolver::initElement):
Modified to invoke m_state.initElement if a given element is
different from current m_state's element.
(WebCore::StyleResolver::State::initForStyleResolve):
Moved from StyleResolver.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
Changed ASSERT in the first line. ASSERT(m_state.parentStyle) would be
wrong, because it depends on previous resolving. However,
initForStyleResolve will also update m_state.parentStyle. No code in
pseudoStyleForElement depends on previous resolving state.
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
Added one more parameter, dynamicPseudo, because dynamicPseudo in
State class is just used for returning matched pseudo style from
this ruleMatches to collectMatchingRulesForList. No need to keep
dynamicPseudo while resolving styles.
(WebCore::StyleResolver::checkRegionSelector):
Removed m_pseudoStyle = NOPSEUDO, because this method uses just
SelectorChecker::matched. SelectorChecker doesn't see StyleResolver's
m_pseudoStyle directly. Need to use SelectorCheckerContext. So no
need to set m_pseudoStyle to be NOPSEUDO.
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::State::State):
(State):
(WebCore::StyleResolver::State::clear):
Modified to use clear at the end of styleForElement.
(WebCore::StyleResolver::State::document):
(WebCore::StyleResolver::State::element):
(WebCore::StyleResolver::State::styledElement):
(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::State::style):
(WebCore::StyleResolver::State::takeStyle):
(WebCore::StyleResolver::State::ensureRuleList):
(WebCore::StyleResolver::State::takeRuleList):
(WebCore::StyleResolver::State::parentNode):
(WebCore::StyleResolver::State::setParentStyle):
(WebCore::StyleResolver::State::parentStyle):
(WebCore::StyleResolver::State::rootElementStyle):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::setSameOriginOnly):
(WebCore::StyleResolver::State::isSameOriginOnly):
(WebCore::StyleResolver::State::pseudoStyle):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::distributedToInsertionPoint):
(WebCore::StyleResolver::State::setElementAffectedByClassRules):
(WebCore::StyleResolver::State::elementAffectedByClassRules):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::applyPropertyToRegularStyle):
(WebCore::StyleResolver::State::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::State::pendingImageProperties):
(WebCore::StyleResolver::State::pendingSVGDocuments):
(WebCore::StyleResolver::State::setHasPendingShaders):
(WebCore::StyleResolver::State::hasPendingShaders):
(WebCore::StyleResolver::State::setLineHeightValue):
(WebCore::StyleResolver::State::lineHeightValue):
(WebCore::StyleResolver::State::setFontDirty):
(WebCore::StyleResolver::State::fontDirty):
(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::State::hasUAAppearance):
(WebCore::StyleResolver::State::borderData):
(WebCore::StyleResolver::State::backgroundData):
(WebCore::StyleResolver::State::backgroundColor):
(WebCore::StyleResolver::State::fontDescription):
(WebCore::StyleResolver::State::parentFontDescription):
(WebCore::StyleResolver::State::setFontDescription):
(WebCore::StyleResolver::State::setZoom):
(WebCore::StyleResolver::State::setEffectiveZoom):
(WebCore::StyleResolver::State::setTextSizeAdjust):
(WebCore::StyleResolver::State::setWritingMode):
(WebCore::StyleResolver::State::setTextOrientation):
fontDescription, ... and setTextOrientation were moved from
StyleResolver.
(WebCore::StyleResolver::State::matchedRules):
(WebCore::StyleResolver::State::addMatchedRule):
Moved from StyleResolver.
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
These fontDescription, ..., setTextOrientation are wrappers to
invoke State's methods. StyleBuilder still depends on StyleResolver
and invokes these methods. So we need these wrappers.

LayoutTests: [Refactoring] StyleResolver::State should have methods to access its me
https://bugs.webkit.org/show_bug.cgi?id=108563

Reviewed by Antti Koivisto.

  • inspector/styles/region-style-crash-expected.txt:

Rebaseline. Since inspector hasn't supported CSS region styles yet,
region-style-crash.html has no CSS region styles as its result.

9:24 AM Changeset in webkit [142756] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] Remove support for compiling with GStreamer 0.10
https://bugs.webkit.org/show_bug.cgi?id=109593

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-13
Reviewed by Philippe Normand.

Remove support for building WebKitGTK+ with GStreamer 0.10. We
can simplify things greatly because we don't have to worry any
longer about selecting one GStreamer API set.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/Versions.m4:
9:21 AM Changeset in webkit [142755] by allan.jensen@digia.com
  • 8 edits in trunk/Source

[Qt] window.open passes height and width parameters even if not defined in a page
https://bugs.webkit.org/show_bug.cgi?id=107705

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Do not override width or height of 0, as that indicates default size, and not minimum size.

Tested by tst_qwebpage.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::adjustWindowRect):

Source/WebKit/efl:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::setWindowRect):

Source/WebKit/gtk:

Do not resize window when default size is requested.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::setWindowRect):

Source/WebKit/qt:

Test that minimum size is applied only when the requested size is too small,
not when default is requested.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(TestPage):
(TestPage::TestPage):
(TestPage::createWindow):
(TestPage::slotGeometryChangeRequested):
(tst_QWebPage::openWindowDefaultSize):

9:01 AM Changeset in webkit [142754] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

The 2D Canvas functions fillText()/strokeText() should display nothing when maxWidth is less then or equal to zero
https://bugs.webkit.org/show_bug.cgi?id=102656

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-13
Reviewed by Dirk Schulze.

The functions fillText()/strokeText() should not display anything when
maxWidth is less than or equal to zero, according to spec :
http://www.w3.org/TR/2dcontext/#text-preparation-algorithm

Source/WebCore:

Test: fast/canvas/canvas-fillText-maxWidth-zero.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

  • fast/canvas/canvas-fillText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-fillText-invalid-maxWidth.html: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth-expected.txt: Added.
  • fast/canvas/canvas-strokeText-invalid-maxWidth.html: Added.
  • fast/canvas/script-tests/canvas-fillText-invalid-maxWidth.js: Added.
  • fast/canvas/script-tests/canvas-strokeText-invalid-maxWidth.js: Added.
8:47 AM Changeset in webkit [142753] by sergio@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Provide the same custom expectations as all the other
platforms. This likely means that there is a bug in the code or
that the expected result is incorrect.

  • platform/gtk/TestExpectations:
  • platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
8:25 AM Changeset in webkit [142752] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add acceleration ratios for the deltas to WebMouseWheelEvents.
https://bugs.webkit.org/show_bug.cgi?id=109611

The deltas in mousewheel events generated by track can be accelerated (e.g. when
scrolling repeatedly). Keep track of the ratio of the acceleration since that is
useful for some tasks (e.g. overflow navigation gesture).

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2013-02-13
Reviewed by Adam Barth.

  • public/WebInputEvent.h:

(WebKit::WebMouseWheelEvent::WebMouseWheelEvent):

  • src/WebInputEvent.cpp:

(SameSizeAsWebMouseWheelEvent):

8:23 AM Changeset in webkit [142751] by zherczeg@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

replaceWithJump should not decrease the offset by 1 on ARM traditional.
https://bugs.webkit.org/show_bug.cgi?id=109689

Reviewed by Zoltan Herczeg.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::replaceWithJump):

8:16 AM Changeset in webkit [142750] by Christophe Dumez
  • 13 edits
    4 copies in trunk/Source/WebKit2

[EFL][WK2] Introduce WKViewClient C API
https://bugs.webkit.org/show_bug.cgi?id=109559

Reviewed by Anders Carlsson.

This patch introduces the WKViewClient C API for EFL's WKView. The purpose of
this new C API is to eventually remove the interdependency between EFL's
PageClient and EwkView. When completed, PageClient should only interact with
WebView and not be aware of EwkView so that we have a clean separation between
internal WebKit2 classes and our EFL Ewk API implementation.

This patch is only a first step towards this goal as there is a lot of work
to do to achieve complete separation between EwkView and PageClient. The purpose
of this patch is to introduce the needed architecture which will later be
extended by introducing new WKViewClient callbacks.

  • PlatformEfl.cmake: Add new ViewClientEfl.cpp and WebViewClient.cpp to EFL's CMake

configuration.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetViewClient):

  • UIProcess/API/C/efl/WKView.h: Introduce new WKViewClient C API.
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Initialize ViewClientEfl.

  • UIProcess/API/efl/EwkView.h: Add new ViewClientEfl member.

(WebKit):
(EwkView):

  • UIProcess/API/efl/EwkViewCallbacks.h: Update ContentsSizeChanged smart callback to

accept a WKSize in parameter instead of an IntRect.

  • UIProcess/efl/PageClientBase.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientBase::view):
(WebKit::PageClientBase::setViewNeedsDisplay):

  • UIProcess/efl/PageClientBase.h:

(WebKit):
(PageClientBase):

  • UIProcess/efl/PageClientDefaultImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientDefaultImpl::didChangeContentsSize):

  • UIProcess/efl/PageClientLegacyImpl.cpp: Start calling WKViewClient callbacks instead of

interacting directly with EwkView to avoid violating API layering.
(WebKit::PageClientLegacyImpl::didChangeContentsSize):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit):
(WebKit::ViewClientEfl::toEwkView):
(WebKit::ViewClientEfl::viewNeedsDisplay):
(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):

  • UIProcess/efl/ViewClientEfl.h: Introduce new ViewClientEfl which handles WKViewClient callbacks

and interacts with EwkView.
(WebKit):
(ViewClientEfl):
(WebKit::ViewClientEfl::create):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::initializeClient):
(WebKit):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::didChangeContentsSize):

  • UIProcess/efl/WebView.h: Add new WebViewClient member and corresponding methods to interact

with it.
(WebView):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):

  • UIProcess/efl/WebViewClient.h: Add new WebViewClient APIClient for WKViewClient.

(WebCore):
(WebKit):

8:15 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
8:12 AM Changeset in webkit [142749] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[GTK][AC] Implement basic transform animations with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=109363

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-02-13
Reviewed by Gustavo Noronha Silva.

Implement basic transform animation with clutter ac backend.
GraphicsLayerClutter is almost same with GraphicsLayerCA. And PlatformClutterAnimation
interfaces are also similar with PlatformCAAnimation, but they are implemented
with native clutter APIs. Clutter backend AC supports a basic single transform animation
with this patch now, but additive animation combination and keyframe animation
are not supported yet.

Covered by existing animation tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetTransform):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::isTransformTypeTransformationMatrix):
(WebCore):
(WebCore::isTransformTypeFloatPoint3D):
(WebCore::isTransformTypeNumber):
(WebCore::getTransformFunctionValue):
(WebCore::getValueFunctionNameForTransformOperation):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::appendToUncommittedAnimations):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(GraphicsLayerClutter):

  • platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::toClutterActorPropertyString):
(WebCore):
(WebCore::PlatformClutterAnimation::supportsValueFunction):
(WebCore::PlatformClutterAnimation::duration):
(WebCore::PlatformClutterAnimation::setDuration):
(WebCore::PlatformClutterAnimation::setAdditive):
(WebCore::PlatformClutterAnimation::valueFunction):
(WebCore::PlatformClutterAnimation::setValueFunction):
(WebCore::PlatformClutterAnimation::setFromValue):
(WebCore::PlatformClutterAnimation::setToValue):
(WebCore::PlatformClutterAnimation::timeline):
(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addOpacityTransition):
(WebCore::PlatformClutterAnimation::addTransformTransition):
(WebCore::PlatformClutterAnimation::addAnimationForKey):

  • platform/graphics/clutter/PlatformClutterAnimation.h:

(PlatformClutterAnimation):

7:57 AM Changeset in webkit [142748] by mikhail.pozdnyakov@intel.com
  • 4 edits in trunk

[WK2][EFL][WTR] Regression(r141836): WTR crashes on exit
https://bugs.webkit.org/show_bug.cgi?id=109456

Reviewed by Anders Carlsson.

Source/WebKit2:

WebView destructor now considers the situation if its WebPageProxy
instance had been closed from outside the class (explicitly
by client code).

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::~WebView):

Tools:

WebView instance must not live longer than EwkView, as EwkView owns
objects that page proxy refers to, doing otherwise leads to a crash.

Test controller has own ptr containing WebView. Invoking of ewk_shutdown()
leads to evas objects deletion. So, the problem was that test controller was
deleted after ewk_shutdown() had been called in main() function causing
crashes on WTR exit.

The patch introduces a scope for test controller so that it is deleted first.

  • WebKitTestRunner/efl/main.cpp:

(main):

7:30 AM Changeset in webkit [142747] by loislo@chromium.org
  • 6 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):
(Client):
(WebCore::HeapGraphSerializer::Client::~Client):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore):
(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.

(TestWebKitAPI):
(HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
(TestWebKitAPI::HeapGraphReceiver::printGraph):
(TestWebKitAPI::HeapGraphReceiver::dumpNodes):
(TestWebKitAPI::HeapGraphReceiver::dumpEdges):
(TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
(TestWebKitAPI::HeapGraphReceiver::dumpStrings):
(TestWebKitAPI::HeapGraphReceiver::serializer):
(TestWebKitAPI::HeapGraphReceiver::chunkPart):
(TestWebKitAPI::HeapGraphReceiver::dumpPart):
(TestWebKitAPI::HeapGraphReceiver::stringValue):
(TestWebKitAPI::HeapGraphReceiver::intValue):
(TestWebKitAPI::HeapGraphReceiver::nodeToString):
(TestWebKitAPI::HeapGraphReceiver::edgeToString):
(TestWebKitAPI::HeapGraphReceiver::printNode):
(Helper):
(TestWebKitAPI::Helper::Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::Helper::addEdge):
(TestWebKitAPI::Helper::done):
(Object):
(TestWebKitAPI::Helper::Object::Object):
(TestWebKitAPI::TEST):
(Owner):
(TestWebKitAPI::Owner::Owner):
(TestWebKitAPI::Owner::reportMemoryUsage):

7:27 AM Changeset in webkit [142746] by yurys@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: add experimental native heap graph to Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=109687

Reviewed by Alexander Pavlov.

Added experimentatl support for native heap graph on the Timeline panel.
Native memory usage data is collected after each top level task and can
be displayed instead of DOM counters graph on the Timeline panel if
corresponding experiment is enabled in the inspector settings.

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorTimelineAgent.cpp:

(TimelineAgentState):
(WebCore::InspectorTimelineAgent::setIncludeDomCounters):
(WebCore):
(WebCore::InspectorTimelineAgent::setIncludeNativeMemoryStatistics):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):

  • inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/TimelinePanel.js:
7:25 AM Changeset in webkit [142745] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fixed colorpicker editing and scrolling.
https://bugs.webkit.org/show_bug.cgi?id=109434.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

The color picker scrolling logic relied on the fixed DOM structure which changed with the introduction of
SidebarPaneStack (https://bugs.webkit.org/show_bug.cgi?id=108183).
Added a special CSS class to mark the scroll target.

No new tests.

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylePropertyTreeElement.prototype.updateTitle.):

  • inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane):

6:27 AM Changeset in webkit [142744] by atwilson@chromium.org
  • 4 edits in trunk/LayoutTests

Unreviewed chromium expectation changes resulting from r142719.

  • platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
  • platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
6:19 AM Changeset in webkit [142743] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix js compilation warnings in TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109685

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-13
Reviewed by Alexander Pavlov.

Mark last argument of _applySuggestion function as optional.

No new tests: no change in behaviour.

  • inspector/front-end/TextPrompt.js:
6:09 AM Changeset in webkit [142742] by thiago.santos@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl/TestExpectations:
6:04 AM Changeset in webkit [142741] by atwilson@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium expectation changes.
Fallout from r142683.

  • platform/chromium-win/http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
6:03 AM Changeset in webkit [142740] by benm@google.com
  • 13 edits
    1 copy
    6 deletes in branches/chromium/1364

Merge 141769

Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

  • features.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

  • tests/data/non-fast-scrollable.html:
  • tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.

TBR=skyostil@chromium.org
Review URL: https://codereview.chromium.org/12254005

5:45 AM Changeset in webkit [142739] by commit-queue@webkit.org
  • 30 edits
    5 adds in trunk

Implement css-conditional's CSS.supports()
https://bugs.webkit.org/show_bug.cgi?id=100324

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-13
Reviewed by Antti Koivisto.

Source/WebCore:

http://dev.w3.org/csswg/css3-conditional/#the-css-interface

The supports() method provides the css @supports rule's corresponding
dom api.
The patch also adds the CSS interface on DOMWindow, which holds "useful
CSS-related functions that do not belong elsewhere". This is where
supports() lives.

Test: css3/supports-dom-api.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/gobject/GNUmakefile.am:
  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

Add DOMWindowCSS.* to the build systems.

  • bindings/scripts/CodeGenerator.pm:

(WK_lcfirst):

Handle CSS prefixes correctly (s/cSS/css/).

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::detectAtToken):

  • css/CSSParser.h:

webkit_supports_condition parses just the condition part of an
@supports rule and evaluates it, outputting whether the condition
is supported or not.

  • css/CSSAllInOne.cpp:
  • css/DOMWindowCSS.cpp: Added.
  • css/DOMWindowCSS.h: Added.
  • css/DOMWindowCSS.idl: Added.

The CSS interface object.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::css):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

window.CSS

LayoutTests:

  • css3/supports-dom-api-expected.txt: Added.
  • css3/supports-dom-api.html: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
5:15 AM Changeset in webkit [142738] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Web Inspector: Simplify SplitView to rely more on CSS
https://bugs.webkit.org/show_bug.cgi?id=109426

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-13
Reviewed by Vsevolod Vlasov.

Simplified Javascript code by moving large part of the layout logic into CSS rules. The patch is larger than it
should be because one of the clients (TimelinePanel) is breaking SplitView incapsulation by reparenting its
resizer.

No new tests.

  • inspector/front-end/SidebarView.js:

(WebInspector.SidebarView):

  • inspector/front-end/SplitView.js:

(WebInspector.SplitView):
(WebInspector.SplitView.prototype._innerSetVertical):
(WebInspector.SplitView.prototype.setSecondIsSidebar):
(WebInspector.SplitView.prototype._showOnly):
(WebInspector.SplitView.prototype._removeAllLayoutProperties):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/cssNamedFlows.css:

(.css-named-flow-collections-view .split-view-sidebar):
(.css-named-flow-collections-view .split-view-sidebar .sidebar-content):
(.css-named-flow-collections-view .split-view-sidebar .selection):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before, .css-named-flow-collections-view .region-empty:before, .css-named-flow-collections-view .region-fit::before, .css-named-flow-collections-view .region-overset::before):
(.css-named-flow-collections-view .split-view-sidebar .named-flow-overflow::before):

  • inspector/front-end/splitView.css:

(.split-view-contents.maximized):
(.split-view-vertical .split-view-contents):
(.split-view-vertical .split-view-contents-first):
(.split-view-vertical .split-view-contents-first.maximized):
(.split-view-vertical .split-view-contents-second):
(.split-view-vertical .split-view-contents-second.maximized):
(.split-view-horizontal .split-view-contents):
(.split-view-horizontal .split-view-contents-first):
(.split-view-horizontal .split-view-contents-first.maximized):
(.split-view-horizontal .split-view-contents-second):
(.split-view-horizontal .split-view-contents-second.maximized):
(.split-view-vertical .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-vertical .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-first:not(.maximized)):
(.split-view-horizontal .split-view-sidebar.split-view-contents-second:not(.maximized)):
(.split-view-vertical .split-view-resizer):
(.split-view-horizontal .split-view-resizer):

  • inspector/front-end/timelinePanel.css:

(.timeline.split-view-vertical .split-view-resizer):
(#timeline-container .split-view-sidebar):

4:57 AM Changeset in webkit [142737] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r142730.
http://trac.webkit.org/changeset/142730
https://bugs.webkit.org/show_bug.cgi?id=109666

chromium browser tests are failing

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

3:59 AM Changeset in webkit [142736] by gyuyoung.kim@samsung.com
  • 11 edits in trunk

[WK2] Remove web intents callbacks
https://bugs.webkit.org/show_bug.cgi?id=109654

Reviewed by Benjamin Poulain.

Web intents was removed by r142549.

Source/WebKit2:

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:

(attachLoaderClientToView):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::InjectedBundlePage):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

3:39 AM Changeset in webkit [142735] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

OpenCL implementation of Flood SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=109580

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-13
Reviewed by Zoltan Herczeg.

  • Target.pri:
  • platform/graphics/filters/FEFlood.h:

(FEFlood):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore):
(WebCore::PROGRAM_STR):
(WebCore::FilterContextOpenCL::compileFill):
(WebCore::FilterContextOpenCL::fill):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFEFlood.cpp: Added.

(WebCore):
(WebCore::FEFlood::platformApplyOpenCL):

3:19 AM Changeset in webkit [142734] by mkwst@chromium.org
  • 11 edits
    1 copy
    2 adds in trunk

location.href does not throw SECURITY_ERR when accessed across origins with JSC bindings
https://bugs.webkit.org/show_bug.cgi?id=43891

Reviewed by Adam Barth.

Source/WebCore:

Other browsers (IE, Firefox, and Opera) throw an exception when accessing
properties of a Location object across origins, as the spec suggests[1].
WebKit is currently the outlier.

This has a few negative effects: developers are forced to hack around
access violations in two ways rather than having a single code path, and
(more annoyingly) developers are unable to avoid generating the error
message. See every ad on the internet for the effect on the console. :)

This patch adds a SECURITY_ERR exception to these access violations,
which is the first step towards getting rid of the console spam. Getting
rid of the message entirely will require a solution to
http://wkbug.com/98050.

A fairly inconclusive thread[2] on webkit-dev popped up in 2010 and
trailed off without reaching conclusion. A more recent thread reached
agreement that this patch seems like a reasonable thing to do[3].

This is the JSC half of the patch. V8 is coming in http://wkbug.com/43892

[1]: http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#security-location
[2]: https://lists.webkit.org/pipermail/webkit-dev/2010-August/013880.html
[2]: https://lists.webkit.org/pipermail/webkit-dev/2012-February/023636.html

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get.html:
  • http/tests/security/resources/cross-frame-access.js:

(accessThrowsException):

  • http/tests/security/resources/cross-frame-iframe-callback-explicit-domain-DENY.html:
  • http/tests/security/resources/cross-frame-iframe-for-location-get-test.html:

Adjusting tests to check for exceptions, and adjusting expectations to match.

  • platform/chromium/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt: Copied from LayoutTests/http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt.
  • platform/chromium/http/tests/security/cross-frame-access-location-get-expected.txt: Added.
  • platform/chromium/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt: Copied from LayoutTests/http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt.

V8 fails at the moment: http://wkbug.com/43892

2:59 AM Changeset in webkit [142733] by vsevik@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed test fix: removed redundant testRunnet.notifyDone() call that was causing other test failures.

  • inspector/script-execution-state-change-notification.html:
2:45 AM Changeset in webkit [142732] by zandobersek@gmail.com
  • 9 edits
    3 adds in trunk/LayoutTests

Unreviewed GTK gardening.
Rebaselining tests after the DOM4 Events constructors and CSS image-set
support were enabled.

  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
  • platform/gtk/fast/events/constructors: Added.
  • platform/gtk/fast/events/constructors/mouse-event-constructor-expected.txt: Added.
  • platform/gtk/fast/events/constructors/wheel-event-constructor-expected.txt: Added.
  • platform/gtk/fast/hidpi/image-set-border-image-comparison-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-border-image-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-in-content-dynamic-expected.txt:
  • platform/gtk/fast/hidpi/image-set-out-of-order-expected.txt:
  • platform/gtk/fast/hidpi/image-set-simple-expected.txt:
  • platform/gtk/fast/hidpi/image-set-without-specified-width-expected.txt:
2:39 AM Changeset in webkit [142731] by atwilson@chromium.org
  • 10 edits in trunk/Source

Unreviewed Chromium gyp-file cleanup after glib backend removal.
https://bugs.webkit.org/show_bug.cgi?id=109672

Removed references to GLib unicode backend:

Source/WebCore:

  • WebCore.gypi:

Source/WebKit/gtk:

  • gyp/Configuration.gypi.in:
  • gyp/Dependencies.gyp:
  • gyp/JavaScriptCore.gyp:
  • gyp/WTF.gyp:

Source/WTF:

  • WTF.gyp/WTF.gyp:
  • WTF.gypi:
2:04 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:58 AM calendar-picker.png attached to EnableFormFeatures by tkent@chromium.org
1:54 AM multiple-fields-example.png attached to EnableFormFeatures by tkent@chromium.org
1:50 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:43 AM Changeset in webkit [142730] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Generate wrapper methods for custom getters/setters
https://bugs.webkit.org/show_bug.cgi?id=109666

Reviewed by Adam Barth.

Currently V8 directly calls back custom getters/setters written
in custom binding files. This makes it impossible for code generators
to hook custom getters/setters (e.g. Code generators cannot insert a code
for FeatureObservation into custom getters/setters). We should generate
wrapper methods for custom getters/setters.

In the future, I will insert TRACE_EVENT() macros into these wrapper methods
to profile DOM getters/setters/methods.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetter):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetter):
(WebCore):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::customAttrAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::customAttrAttrSetter):
(WebCore):

1:28 AM EnableFormFeatures edited by tkent@chromium.org
(diff)
1:27 AM Changeset in webkit [142729] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests.

  • platform/qt/TestExpectations:
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM WikiStart edited by tkent@chromium.org
(diff)
1:21 AM EnableFormFeatures created by tkent@chromium.org
1:15 AM WikiStart edited by tkent@chromium.org
(diff)
12:24 AM Changeset in webkit [142728] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668

Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

12:10 AM Changeset in webkit [142727] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] There is no XXXConstructor that requires a custom getter
https://bugs.webkit.org/show_bug.cgi?id=109667

Reviewed by Adam Barth.

Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

Feb 12, 2013:

11:34 PM Changeset in webkit [142726] by morrita@google.com
  • 3 edits
    2 adds in trunk

[Internals] setShadowDOMEnabled() shouldn't be used except a few tests.
https://bugs.webkit.org/show_bug.cgi?id=109642

Reviewed by Kent Tamura.

Source/WebCore:

InternalSettings.setShadowDOMEnabled() shouldn't be called after
any relevant DOM bindings are touched. However for fuzzers, it
isn't trivial to regulate its behavior.

This change whitelists the URL of running test for prevent
unintended API calls. This doesn't hurt the Internals usability
since the API is called from just a couple of tests and the number
isn't expected to grow.

Test: fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html

  • testing/InternalSettings.cpp:

(WebCore::urlIsWhitelisted):
(WebCore):
(WebCore::InternalSettings::setShadowDOMEnabled):

LayoutTests:

  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist-expected.txt: Added.
  • fast/dom/shadow/shadow-dom-enabled-flag-whitelist.html: Added.
11:24 PM Changeset in webkit [142725] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/version-controller-expected.txt: Added.
  • inspector/version-controller.html: Added.
10:30 PM Changeset in webkit [142724] by commit-queue@webkit.org
  • 9 edits
    5 deletes in trunk

[GTK] Remove the GLib unicode backend
https://bugs.webkit.org/show_bug.cgi?id=109627

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Benjamin Poulain.

.:

Remove references to the GLib unicode backend from configuration.

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/ReadCommandLineArguments.m4:
  • Source/autotools/SetupAutoconfHeader.m4:
  • Source/autotools/SetupAutomake.m4:

Source/WebCore:

Remove references to the GLib unicode backend from WebCore.

  • GNUmakefile.list.am: Update the source list.
  • platform/text/gtk/TextBreakIteratorGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.cpp: Removed.
  • platform/text/gtk/TextCodecGtk.h: Removed.

Source/WTF:

Remove references to the GLib unicode backend from WTF.

  • GNUmakefile.list.am: Remove GLib unicode files from the source list.
  • wtf/unicode/glib/UnicodeGLib.cpp: Removed.
  • wtf/unicode/glib/UnicodeGLib.h: Removed.
10:21 PM Changeset in webkit [142723] by fpizlo@apple.com
  • 7 edits
    3 deletes in trunk/LayoutTests

Eradicate fast/js/dfg-poison-fuzz.html
https://bugs.webkit.org/show_bug.cgi?id=109660

Unreviewed.

I haven't seen this test fail in ages. And I've seen a lot of DFG bugs!

This is a super expensive test for one bug that used to be in the DFG but that has
since been thoroughly eradicated. Likely the plethora of other DFG tests cover that
bug. Heck, I'm not even sure if the code that this covers is even in the repository
anymore.

In the spirit of not having super expensive and mostly useless tests, I'm removing
this test.

  • fast/js/dfg-poison-fuzz-expected.txt: Removed.
  • fast/js/dfg-poison-fuzz.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-poison-fuzz.js: Removed.
  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
10:16 PM Changeset in webkit [142722] by Lucas Forschler
  • 4 edits in trunk/Source

Versioning.

10:15 PM Changeset in webkit [142721] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: crash when accessing AccessibilityScrollbar after page has been unloaded
https://bugs.webkit.org/show_bug.cgi?id=109524

Reviewed by Ryosuke Niwa.

AX clients can hold onto AccesibilityScrollbar references that reference parent
AccessibilityScrollViews that have already gone away.

AccessibilityScrollView is not calling detachFromParent after it is removed, which
leads to a crash. The fix is to clearChildren() when an object is deallocated.

I could not create a test because the crash only manifests over multiple page loads.

  • accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::detach):
10:13 PM Changeset in webkit [142720] by Lucas Forschler
  • 1 copy in tags/Safari-537.31

New Tag.

10:09 PM Changeset in webkit [142719] by hayato@chromium.org
  • 4 edits in trunk/Source/WebCore

Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=109650

Reviewed by Dimitri Glazkov.

Set FocusEvent.relatedTarget in its constructor so that each
EventDispatchMediator can use FocusEvent.relatedTarget rather than
its redundant m_{old,new}FocusedNode member variable.

I've also removed FIXME comments, mentioning bug 109261, since I
can not reproduce the issue.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
(WebCore::Node::dispatchFocusEvent):
(WebCore::Node::dispatchBlurEvent):

9:17 PM Changeset in webkit [142718] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Remove unnecessary and confusing includes from StreamBuffer.h.
https://bugs.webkit.org/show_bug.cgi?id=109652

Patch by Takeshi Yoshino <tyoshino@google.com> on 2013-02-12
Reviewed by Benjamin Poulain.

StreamBuffer.h is using OwnPtr for storing Vectors into a Deque.
FixedArray.h and PassOwnPtr.h are included but not used.

VectorTraits defines how to move OwnPtr in Vector. It's done by memcpy.
So, there's no need for PassOwnPtr (Deque<PassOwnPtr<Vector<char> > >
is even slower).

  • wtf/StreamBuffer.h:
9:10 PM Changeset in webkit [142717] by tasak@google.com
  • 6 edits in trunk/Source/WebCore

[Refactoring] Make SelectorChecker::mode a constructor parameter.
https://bugs.webkit.org/show_bug.cgi?id=109653

Reviewed by Dimitri Glazkov.

No new tests, because just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
Made mode a constructor parameter.

  • css/SelectorChecker.h:

Removed setMode.
(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::ContentSelectorChecker):

8:58 PM Changeset in webkit [142716] by keishi@webkit.org
  • 6 edits
    3 copies in branches/chromium/1364

Merge 142572

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

  • Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

  • Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

TBR=keishi@webkit.org

8:38 PM Changeset in webkit [142715] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[Chromium] Rebaseline suggestion-picker layout tests
https://bugs.webkit.org/show_bug.cgi?id=109647

Unreviewed rebaseline.
Text position differences, imperceptible to human sight.
Test failures possibly caused by: http://trac.webkit.org/changeset/142659

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-12

  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
8:27 PM Changeset in webkit [142714] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Remove Element::ensureAttributeData().
<http://webkit.org/b/109643>

Reviewed by Anders Carlsson.

  • dom/Element.h:
  • dom/Element.cpp:

(WebCore::Element::classAttributeChanged):
(WebCore::Element::shouldInvalidateDistributionWhenAttributeChanged):

Use attributeData() instead of ensureAttributeData(), it's already guaranteed to exist in
both these functions as they are called in response to attribute changes.

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

Use mutableAttributeData() instead of ensureAttributeData() when invalidating animated
SVG attributes. While I can't find any bugs caused by this, an element with property animations
shouldn't share attribute data with other elements.

8:25 PM Changeset in webkit [142713] by hayato@chromium.org
  • 3 edits in trunk/Source/WebCore

Make {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator type safe.
https://bugs.webkit.org/show_bug.cgi?id=109561

Reviewed by Dimitri Glazkov.

Use FocusEvent rather than Event in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.

No new tests. No change in functionality.

  • dom/FocusEvent.cpp:

(WebCore::FocusEventDispatchMediator::create):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):

  • dom/FocusEvent.h:

(FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::event):
(BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::event):
(FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::event):
(FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::event):

8:24 PM Changeset in webkit [142712] by eric@webkit.org
  • 10 edits in trunk/Source/WebCore

Fix HTMLToken::Attribute member naming and update callsites to use Vector-based String functions
https://bugs.webkit.org/show_bug.cgi?id=109638

Reviewed by Adam Barth.

Darin Adler noted in:
https://bugs.webkit.org/show_bug.cgi?id=109408#c4
that HTMLToken::Attribute (then MarkupTokenBase::Attribute)
was a struct, yet incorrectly used m_ for its public members.

This patch fixes the members to not have the m_, and since I was
touching all callers, I also updated all callers to use modern
Vector-based String creation/append functions instead of manually
calling UChar*, size_t versions.

There should be no behavior change to this patch. Where I saw
performance/memory bugs, I noted them with FIXMEs to keep
this change simple.

  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::processTagToken):

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::processMeta):
(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::StartTagScanner::processAttributes):
(WebCore::HTMLPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::processPossibleBaseTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLToken.h:

(Range):
(Attribute):
(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::startIndex):
(WebCore::HTMLToken::endIndex):
(WebCore::HTMLToken::end):
(WebCore::HTMLToken::nameString):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::beginAttributeName):
(WebCore::HTMLToken::endAttributeName):
(WebCore::HTMLToken::beginAttributeValue):
(WebCore::HTMLToken::endAttributeValue):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::eraseValueOfAttribute):

  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::nameForAttribute):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):

8:08 PM Changeset in webkit [142711] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController):

7:59 PM Changeset in webkit [142710] by yosin@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Build fix for Chromium-Win.
Add #include <functional> for std::bind1st.

  • tests/PrerenderingTest.cpp:
7:26 PM Changeset in webkit [142709] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebKit/chromium/features.gypi

Merge 141193
BUG=175910
Review URL: https://codereview.chromium.org/12250029

7:05 PM Changeset in webkit [142708] by cevans@google.com
  • 163 edits in branches/chromium/1364/Source

Merge 141034
BUG=175910
Review URL: https://codereview.chromium.org/12251015

6:42 PM Changeset in webkit [142707] by Nate Chapin
  • 7 edits
    3 adds in trunk

REGRESSION: Reloading a local file doesn't pick up changes
https://bugs.webkit.org/show_bug.cgi?id=109344

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/cache/reload-main-resource.php

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):
(WebCore::CachedResourceLoader::cachePolicy): Don't use subresourceCachePolicy()

for main resources.

  • loader/cache/CachedResourceLoader.h:

(CachedResourceLoader):

LayoutTests:

  • http/tests/cache/reload-main-resource-expected.txt: Added.
  • http/tests/cache/reload-main-resource.php: Added.
  • http/tests/cache/resources/reload-main-resource-iframe.php: Added.
  • http/tests/misc/favicon-loads-with-images-disabled-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

  • http/tests/misc/link-rel-icon-beforeload-expected.txt: This test

was being loaded from memory cache in spite of being loaded via reload. We
shouldn't do that.

6:40 PM Changeset in webkit [142706] by Martin Robinson
  • 3 edits
    5 adds
    1 delete in trunk/Source/WebKit/gtk

[GTK] Connect the gyp build to autoconf
https://bugs.webkit.org/show_bug.cgi?id=109360

Reviewed by Dirk Pranke.

Move Configuration.gypi to Configuration.gypi.in and allow autoconf to
fill in variables during a configuration phase. Also add some scripts
to support connecting autoconf up to the gyp build. This allows us
to have a very autotools-esque experience.

  • gyp/Configuration.gypi: Removed.
  • gyp/Configuration.gypi.in: Added. Fleshed out Configuration.gypi to include

dependency CFLAGS and LIBS directly from configure. Due to the way we are
generating the gyp build now, we also need to include an absolute path to
the build directory. Fixing bugs in gyp should allow us to avoid this in the
future.

  • gyp/Dependencies.gyp: Added this file which holds external dependency targets.

We could consider auto-generating this at some point.

  • gyp/JavaScriptCore.gyp: Remove references to the old Configuration.gypi.

It's now included via the command-line -I flag. Update to support the new
s/default/global/g terminology for variables.

  • gyp/WTF.gyp: Remove the dependency targets as this is now handled entirely

by autoconf.

  • gyp/autogen.sh: Added. Set up the build directory and kick off autoconf.
  • gyp/configure.ac: Added. An autoconf build that re-uses much of our

existing autoconf setup.

  • gyp/run-gyp: Added. Script for invoking gyp for out-of-tree builds.
6:39 PM Changeset in webkit [142705] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
https://bugs.webkit.org/show_bug.cgi?id=109549

Reviewed by Tony Chang.

Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).

  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

  • editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
mode code with that function.
(WebCore::Editor::rangeForPoint):

  • editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.

  • editing/htmlediting.cpp:
  • editing/htmlediting.h:
  • editing/markup.cpp:

(WebCore::createMarkupInternal): Extracted from createMarkup.
(WebCore::createMarkup):

6:39 PM Changeset in webkit [142704] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

[WK2] Page reloading will crash UIProcess after WebProcess was killed
https://bugs.webkit.org/show_bug.cgi?id=109305

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-02-12
Reviewed by Benjamin Poulain.

Source/WebKit2:

Re-initialize the pointer to a WebInspectorProxy object before calling
initializeWebPage().

When the WebProcess crashes, WebPageProxy::processDidCrash() will
set WebInspectorProxy pointer to null, which later is accessed by
initializeWebPage(). This patch avoids a crash scenario where
calls into a null pointer would be made.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::reattachToWebProcess):

Tools:

Adding a new test to simulate the case of WebProcess crash followed by a trying
to load a new page.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):

6:22 PM Changeset in webkit [142703] by benjamin@webkit.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Mac rebaseline for r142638.

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-12
Reviewed by Benjamin Poulain.

  • platform/mac-lion/accessibility/table-attributes-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Removed.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Removed.
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Added.
6:20 PM Changeset in webkit [142702] by rafaelw@chromium.org
  • 3 edits in trunk/LayoutTests

[HTMLTemplateElement] Change template.dat serialization format
https://bugs.webkit.org/show_bug.cgi?id=109635

Reviewed by Eric Seidel.

The serialization format now uses 'content' instead of '#document-fragment' to
denote template contents.

  • html5lib/resources/template.dat:
  • resources/dump-as-markup.js:

(Markup._get):

6:13 PM Changeset in webkit [142701] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[iOS] Enable PAGE_VISIBILITY_API
https://bugs.webkit.org/show_bug.cgi?id=109399

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-02-12
Reviewed by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
6:10 PM Changeset in webkit [142700] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Update a comment in NetworkProcess to be more accurate.

Rubberstamped by Sam Weinig.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didClose):

5:53 PM Changeset in webkit [142699] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/bindings/v8/ScriptWrappable.h

Merge 140575
BUG=171893
Review URL: https://codereview.chromium.org/12225160

5:43 PM Changeset in webkit [142698] by akling@apple.com
  • 12 edits
    2 deletes in trunk/Source/WebCore

Move ElementAttributeData into Element.cpp/h
<http://webkit.org/b/109610>

Reviewed by Anders Carlsson.

Removed ElementAttributeData.cpp/h and moved the class itself into Element headquarters.
In the near future, Element should be the only client of this class, and thus it won't
be necessary for other classes to know anything about it.

  • dom/ElementAttributeData.cpp: Removed.
  • dom/ElementAttributeData.h: Removed.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/DocumentSharedObjectPool.cpp:
  • dom/Element.cpp:
  • dom/Element.h:
  • workers/SharedWorker.cpp:
  • Modules/webdatabase/DatabaseManager.cpp: Add ExceptionCode.h since Element.h doesn't pull it in anymore.
5:37 PM Changeset in webkit [142697] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Build fix for VS2010 WebKit solution.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:28 PM Changeset in webkit [142696] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

SecItemShim should be a WorkQueueMessageReceiver
https://bugs.webkit.org/show_bug.cgi?id=109636

Reviewed by Sam Weinig.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
Add a helper function for dispatching a work queue message receiver message.

(CoreIPC::Connection::processIncomingMessage):
Check if there are any work queue message receivers registered for this message.

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::shared):
Use dispatch_once instead of the AtomicallyInitializedStatic macro.

(WebKit::SecItemShim::SecItemShim):
Initialize the queue.

(WebKit::SecItemShim::secItemResponse):
Remove the connection parameter.

(WebKit::SecItemShim::initializeConnection):
Register the shim object as a work queue message receiver.

  • Shared/mac/SecItemShim.h:

Inherit from WorkQueueMessageReceiver.

  • Shared/mac/SecItemShim.messages.in:

Remove LegacyReceiver and DispatchOnConnectionQueue.

5:25 PM Changeset in webkit [142695] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Renamed SpecObjectMask to SpecObject.

Rubber stamped by Mark Hahnenberg.

"SpecObjectMask" is a weird name considering that a bunch of the other speculated
types are also masks, but don't have "Mask" in the name.

  • bytecode/SpeculatedType.h:

(JSC):
(JSC::isObjectSpeculation):
(JSC::isObjectOrOtherSpeculation):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

5:13 PM Changeset in webkit [142694] by thakis@chromium.org
  • 7 edits in trunk/LayoutTests

Remove webintents from TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=109620

Reviewed by James Robinson.

  • platform/chromium/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-mac-wk2/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
5:10 PM Changeset in webkit [142693] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Make Plug-in XPC services "join existing sessions"
<rdar://problem/13196448>

Reviewed by Mark Rowe.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
5:00 PM Changeset in webkit [142692] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

Update WebKitDirs.pm for new Windows paths
https://bugs.webkit.org/show_bug.cgi?id=107714

Reviewed by Daniel Bates.

  • Scripts/webkitdirs.pm: For each existing Windows environment

variable, also include creation of the 'new' variables. The
'old' variables will be removed in a future update.
(windowsSourceSourceDir): New helper routine to return the
actual 'Source' folder of the WebKit source tree.

4:58 PM Changeset in webkit [142691] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Crash when scrolling soon after page starts loading
https://bugs.webkit.org/show_bug.cgi?id=109631
<rdar://problem/13157533&13159627&13196727>

Reviewed by Anders Carlsson.

Make the scrolling tree more robust when the root state node,
and/or scrolling node are null. This can happen if we try to
handle a wheel event before we've done the first scrolling
tree commit.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::commit): Handle the case where
m_rootStateNode is null. We'll still commit, but the state tree
will have no state nodes.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::handleWheelEvent): Null-check m_rootNode.
(WebCore::ScrollingTree::commitNewTreeState): Handle a null root node.
(WebCore::ScrollingTree::updateTreeFromStateNode): If the rood state node
is null, just clear the map and null out the root scrolling node.

  • page/scrolling/ScrollingTree.h: m_debugInfoLayer was unused.
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ensureRootStateNodeForFrameView): It may be possible
to get here before we've registered the root scroll layer, in which case scrollLayerID()
will be 0. Assert to see if this can ever happen.
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeAsText): Handle case of rootStateNode()
being null.

4:58 PM Changeset in webkit [142690] by weinig@apple.com
  • 4 edits
    16 copies
    11 adds in trunk/Source/WebKit2

Add skeleton of the OfflineStorageProcess
https://bugs.webkit.org/show_bug.cgi?id=109615

Reviewed by Anders Carlsson.

This adds the skeleton of a new process to contain Database and Local Storage
backends in (hence, offline storage). We're adding a new process, rather than
using the Network or UIProcesses, to allow us to tightly sandbox these activities
away from networking and full filesystem access.

  • Configurations/OfflineStorageProcess.xcconfig: Added.
  • Configurations/OfflineStorageService.Development.xcconfig: Added.
  • Configurations/OfflineStorageService.xcconfig: Added.
  • DerivedSources.make:
  • OfflineStorageProcess: Added.
  • OfflineStorageProcess/EntryPoint: Added.
  • OfflineStorageProcess/EntryPoint/mac: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/Info.plist: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm: Added.
  • OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageServiceEntryPoint.mm: Added.
  • OfflineStorageProcess/OfflineStorageProcess.cpp: Added.
  • OfflineStorageProcess/OfflineStorageProcess.h: Added.
  • OfflineStorageProcess/OfflineStorageProcess.messages.in: Added.
  • OfflineStorageProcess/mac: Added.
  • OfflineStorageProcess/mac/OfflineStorageProcessMac.mm: Added.

(WebKit::OfflineStorageProcess::initializeProcessName):
(WebKit::OfflineStorageProcess::initializeSandbox):

  • OfflineStorageProcess/mac/com.apple.WebKit.OfflineStorage.sb: Added.
  • Shared/OfflineStorage: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.cpp: Added.
  • Shared/OfflineStorage/OfflineStorageProcessCreationParameters.h: Added.
  • Scripts/webkit2/messages.py:

(struct_or_class):
Added OfflineStorageProcessCreationParameters.

  • WebKit2.xcodeproj/project.pbxproj:
4:41 PM Changeset in webkit [142689] by eric@webkit.org
  • 4 edits in trunk/Source/WTF

Teach more WTF string classes about vectors with inline capacity
https://bugs.webkit.org/show_bug.cgi?id=109617

Reviewed by Benjamin Poulain.

The HTML and WebVTT parsers use constructions like:
AtomicString name(m_name.data(), m_name.size())
all over the place because they use inline capacity
on the parse vectors for performance.

This change just add the necessary template variants
to the related String constructors/methods in WTF so that
this parser code can just pass the vector directly instead.

I'll do the actual parser cleanups in follow-up patches to keep things simple.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):

  • wtf/text/StringImpl.h:

(StringImpl):
(WTF::StringImpl::create8BitIfPossible):

  • wtf/text/WTFString.h:

(String):
(WTF::String::make8BitFrom16BitSource):
(WTF):
(WTF::append):

4:23 PM Changeset in webkit [142688] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Fix build warning after r142579
https://bugs.webkit.org/show_bug.cgi?id=109547

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-12
Reviewed by Alexey Proskuryakov.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::didChangeContentsSize):

4:10 PM Changeset in webkit [142687] by Raymond Toy
  • 3 edits in trunk/Source/WebCore

Synchronize setting of panner node model and processing
https://bugs.webkit.org/show_bug.cgi?id=109599

Reviewed by Chris Rogers.

No new tests.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
3:53 PM Changeset in webkit [142686] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Remove webintents from TestExpectations on mac - directory no longer exists.

  • platform/mac/TestExpectations:
3:53 PM Changeset in webkit [142685] by dino@apple.com
  • 7 edits in trunk/Source/WebCore

Add class name for snapshotted plugin based on dimensions
https://bugs.webkit.org/show_bug.cgi?id=108369

Reviewed by Simon Fraser.

As the size of the plugin changes, the Shadow Root for the snapshot
might want to toggle different interfaces. Expose "tiny", "small",
"medium" and "large" classes on the Shadow. (The dimensions are
currently chosen fairly arbitrarily).

Because we only know the dimensions after layout, we set up
a post layout task to add the class. Luckily there already was
a post layout task for plugins - I just updated it to handle
both real and snapshotted plugins. This involved modifying
the list of RenderEmbeddedObjects in FrameView to take generic
RenderObjects, and decide which type they are when calling
the update method.

  • html/HTMLPlugInImageElement.cpp: Some new dimensions for the various size thresholds.

(WebCore::classNameForShadowRootSize): New static function that returns a class name

after examining the size of the object.

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Sets the class name for

the shadow root. This is called in the post layout task.

(WebCore::shouldPlugInShowLabelAutomatically): Use new size names.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Ditto.

  • html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New method updateSnapshotInfo.

  • page/FrameView.cpp:

(WebCore::FrameView::addWidgetToUpdate): Change RenderEmbeddedObject* to RenderObject*.
(WebCore::FrameView::removeWidgetToUpdate): Ditto
(WebCore::FrameView::updateWidget): Branch based on EmbeddedObject vs SnapshottedPlugIn. Call

plugin snapshot update if necessary.

(WebCore::FrameView::updateWidgets): Handle both EmbeddedObject and SnapshottedPlugIn cases.

  • page/FrameView.h: Change RenderEmbeddedObject* to RenderObject* for post layout widget updates.
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::layout): New virtual override. If size has changed, ask the

FrameView to recalculate size after layout.

  • rendering/RenderSnapshottedPlugIn.h: New layout() method.
3:53 PM Changeset in webkit [142684] by alecflett@chromium.org
  • 2 edits in trunk/Tools

Fix signedness in WebTestProxy
https://bugs.webkit.org/show_bug.cgi?id=109623

Reviewed by Adam Barth.

Fix signedness problem, using size_t instead of int.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3:44 PM Changeset in webkit [142683] by mkwst@chromium.org
  • 14 edits
    11 adds in trunk

Implement script MIME restrictions for X-Content-Type-Options: nosniff
https://bugs.webkit.org/show_bug.cgi?id=71851

Reviewed by Adam Barth.

Source/WebCore:

This patch adds support for 'X-Content-Type-Options: nosniff' when
deciding whether or not to execute a given chunk of JavaScript. If the
header is present, script will only execute if it matches a predefined
set of MIME types[1] that are deemed "executable". Scripts served with
types that don't match the list will not execute.

IE introduced this feature, and Gecko is working on an implementation[2]
now. There's been some discussion on the WHATWG list about formalizing
the specification for this feature[3], but nothing significant has been
decided.

This implementation's list of acceptible MIME types differs from IE's:
it matches the list of supported JavaScript MIME types defined in
MIMETypeRegistry::initializeSupportedJavaScriptMIMETypes()[4]. In
particular, the VBScript types are not accepted, and
'text/javascript1.{1,2,3}' are accepted, along with 'text/livescript'.

This feature is locked tightly behind the ENABLE_NOSNIFF flag, which is
currently only enabled on the Chromium port.

[1]: http://msdn.microsoft.com/en-us/library/gg622941(v=vs.85).aspx
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=471020
[3]: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-November/037974.html
[4]: http://trac.webkit.org/browser/trunk/Source/WebCore/platform/MIMETypeRegistry.cpp?rev=142086#L307

Tests: http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html

http/tests/security/contentTypeOptions/nosniff-script-allowed.html
http/tests/security/contentTypeOptions/nosniff-script-blocked.html
http/tests/security/contentTypeOptions/nosniff-script-without-content-type-allowed.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

Before executing script, ensure that it shouldn't be blocked due to
its MIME type. If it is blocked, write an error message to the
console.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeType):

Make scripts' MIME type available outside the context of
CachedScript in order to correctly populate error messages we write
to the console in ScriptElement::executeScript

(WebCore):
(WebCore::CachedScript::mimeTypeAllowedByNosniff):

  • loader/cache/CachedScript.h:

(CachedScript):

A new method which checks the resource's HTTP headers to set the
'nosniff' disposition, and compares the resource's MIME type against
the list of allowed executable types. Returns true iff the script
is allowed.

  • platform/network/HTTPParsers.cpp:

(WebCore):
(WebCore::parseContentTypeOptionsHeader):

  • platform/network/HTTPParsers.h:

Adds a new enum which relates the sniffable status of the resource,
and a method to parse the HTTP header.

LayoutTests:

  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/invalid-content-type-options-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-allowed.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-blocked.html: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked-expected.txt: Added.
  • http/tests/security/contentTypeOptions/nosniff-script-without-content-type-blocked.html: Added.
  • http/tests/security/contentTypeOptions/resources/script-with-header.pl: Added.

New tests!

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:

Skip the new tests on platforms where ENABLE_NOSNIFF isn't yet
enabled (everything other than Chromium).

3:38 PM Changeset in webkit [142682] by jpetsovits@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Assume setScrollingOrZooming() to be called on the WebKit thread.
https://bugs.webkit.org/show_bug.cgi?id=109614
Internal PR 294513

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

With this further simplification of threading assumptions,
we can get rid of atomic integer access as well as the
backing store mutex which was otherwise unused.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::resumeBackingStoreUpdates):
(BlackBerry::WebKit::BackingStorePrivate::isScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):

  • Api/BackingStore_p.h:

(BackingStorePrivate):

3:35 PM Changeset in webkit [142681] by Raymond Toy
  • 2 edits in trunk/Tools

Add alias

3:28 PM Changeset in webkit [142680] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1364

Merge 141858
BUG=174020
Review URL: https://codereview.chromium.org/12250020

3:23 PM Changeset in webkit [142679] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CFA doesn't filter precisely enough for CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=109618

Reviewed by Mark Hahnenberg.

The backend speculates object for this case, but the CFA was filtering on
(SpecCell & ~SpecString) | SpecOther.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

3:10 PM Changeset in webkit [142678] by Christophe Dumez
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Reenable ewk_auth_request API tests
https://bugs.webkit.org/show_bug.cgi?id=108451

Reviewed by Benjamin Poulain.

ewk_auth_request API tests were temporarily disabled after
the C API for resource loading was removed from WebKit2.
This patches updates the tests so that they no longer rely
on the resource loading events and renables them.

This patch also corrects the naming of the static variables
in the test to follow more closely the WebKit coding style.

  • PlatformEfl.cmake:
  • UIProcess/API/efl/tests/test_ewk2_auth_request.cpp:

(serverCallback):
(TEST_F):
(onLoadFinished):

3:09 PM Changeset in webkit [142677] by jpetsovits@rim.com
  • 11 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Eliminate the direct rendering option.
https://bugs.webkit.org/show_bug.cgi?id=109608
RIM PR 293298

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

It added a lot of complexity and we're not going to use it anymore.
This patch removes direct rendering functionality from
WebKit/blackberry together with the assumption that blitting on the
WebKit thread is possible or acceptable. It now isn't anymore.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::slowScroll):
(BlackBerry::WebKit::BackingStorePrivate::scroll):
(BlackBerry::WebKit::BackingStorePrivate::shouldPerformRenderJobs):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderAndBlitImmediately):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::invalidateWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):
(BlackBerry::WebKit::BackingStorePrivate::setScrollingOrZooming):
(BlackBerry::WebKit::BackingStorePrivate::didRenderContent):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::scheduleCompositingRun):

  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::animationFrameChanged):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebSettings.cpp:

(WebKit):

  • Api/WebSettings.h:
  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::renderRegularRenderJobs):
(BlackBerry::WebKit::RenderQueue::renderScrollZoomJobs):

  • WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::initialize):

3:05 PM Changeset in webkit [142676] by cevans@google.com
  • 1 edit in branches/chromium/1364/Source/WebCore/Modules/webaudio/AudioScheduledSourceNode.cpp

Merge 140879
BUG=172243
Review URL: https://codereview.chromium.org/12217152

2:57 PM Changeset in webkit [142675] by tkent@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/css/html.css

Merge 142076

REGRESSION(r141195): INPUT_MULTIPLE_FIELDS_UI: Space in a placeholder string is removed
https://bugs.webkit.org/show_bug.cgi?id=109132

Reviewed by Hajime Morita.

<input type=date> should be shown in Japanese UI as:
[ ?\229?\185?\180 /?\230?\156?\136/?\230?\151?\165]
But it is shown wrongly since r141195:
/?\230?\156?\136/?\230?\151?\165

We should use white-space:pre.

No new tests. This change is not testable in WebKit because this
requires a Japanese-localized UI string of Chromium.

  • css/html.css:

(input::-webkit-datetime-edit-fields-wrapper):
Use white-space:pre instead of nowrap.

TBR=tkent@chromium.org
BUG=crbug.com/174827
Review URL: https://codereview.chromium.org/12211140

2:56 PM Changeset in webkit [142674] by eae@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for r142638, garden-o-matic screwed up the original rebaseline :(

  • platform/chromium-mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium-win-xp/fast/dom/Window: Added.
  • platform/chromium-win-xp/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
2:44 PM Changeset in webkit [142673] by abarth@webkit.org
  • 7 edits in trunk/Source/WebCore

Threaded HTML parser should pass the remaining fast/tokenizer tests
https://bugs.webkit.org/show_bug.cgi?id=109607

Reviewed by Eric Seidel.

This patch fixes some edge cases involving document.write. Previously,
we would drop input characters on the floor if the tokenizer wasn't
able to consume them synchronously. In this patch, we send the unparsed
characters to the background thread for consumption after rewinding the
input stream.

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::canTakeNextToken):
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::finish):

  • html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::closeWithoutMarkingEndOfFile):
(HTMLInputStream):

2:17 PM Changeset in webkit [142672] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Introduce a WorkQueueMessageReceiver class as a replacement for QueueClient
https://bugs.webkit.org/show_bug.cgi?id=109612

Reviewed by Andreas Kling.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addWorkQueueMessageReceiver):
(CoreIPC):
(CoreIPC::Connection::removeWorkQueueMessageReceiver):
(CoreIPC::Connection::addWorkQueueMessageReceiverOnConnectionWorkQueue):
(CoreIPC::Connection::removeWorkQueueMessageReceiverOnConnectionWorkQueue):

  • Platform/CoreIPC/Connection.h:

(Connection):

2:16 PM Changeset in webkit [142671] by dgrogan@chromium.org
  • 2 edits in branches/chromium/1364/Source/WebKit/chromium

Merge 142564
pre-requisite to merging https://src.chromium.org/viewvc/chrome?view=rev&revision=182008

IndexedDB: Add UnknownError to WebIDBDatabaseException
https://bugs.webkit.org/show_bug.cgi?id=109519

Reviewed by Adam Barth.

  • public/WebIDBDatabaseException.h:
  • src/AssertMatchingEnums.cpp:

TBR=dgrogan@chromium.org
BUG=174895
Review URL: https://codereview.chromium.org/12212148

1:59 PM Changeset in webkit [142670] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] CSS animations stop running during zoom
https://bugs.webkit.org/show_bug.cgi?id=109606

Patch by Andrew Lo <anlo@rim.com> on 2013-02-12
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

Internal PR 286160.
New BackingStore API for suspending/resuming geometry updates.

This is needed because we want to allow render jobs to continue during
zoom, but we don't want to allow geometry updates during zoom.

Prevent scroll/zoom render jobs from being added to the queue if
the tile is outside the expanded content rect.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::suspendGeometryUpdates):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::resumeGeometryUpdates):
(BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect):
(BlackBerry::WebKit::BackingStore::suspendGeometryUpdates):
(BlackBerry::WebKit::BackingStore::resumeGeometryUpdates):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • WebKitSupport/RenderQueue.cpp:

(BlackBerry::WebKit::RenderQueue::addToScrollZoomQueue):

1:51 PM QtWebKitBugs edited by jocelyn.turcotte@digia.com
(diff)
1:36 PM Changeset in webkit [142669] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix for !ENABLE(INSPECTOR) platforms after r142654.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::scriptsEnabled):

1:32 PM Changeset in webkit [142668] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Typo fix after r142663.

  • GNUmakefile.list.am:
1:28 PM Changeset in webkit [142667] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

1:26 PM Changeset in webkit [142666] by Lucas Forschler
  • 1 copy in branches/safari-536.29-branch

New Branch.

1:24 PM Changeset in webkit [142665] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/inspector.js

Merge 141890

Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.

Quick fix for regression.

  • inspector/front-end/inspector.js:

Avoid "exit route" when URL is a profile URL.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12223108

1:21 PM Changeset in webkit [142664] by Christophe Dumez
  • 8 edits in trunk

Remove remaining traces of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=109586

Reviewed by Eric Seidel.

.:

Remove references to Web Intents from CMake files as the functionality
was removed in r142549.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Remove remaining traces of Web Intents as the functionality was
removed in r142549.

No new tests, no behavior change for layout tests.

  • GNUmakefile.features.am.in:
  • html/HTMLTagNames.in:

Source/WebKit/blackberry:

Remove remaining traces of Web Intents from Blackberry port
configuration as the functionality was removed in r142549.

  • WebCoreSupport/AboutDataEnableFeatures.in:
1:19 PM Changeset in webkit [142663] by Csaba Osztrogonác
  • 7 edits in trunk/Source/WebKit2

[WK2] Unreviewed trivial buildfix after r142630 and r142651.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching):

  • UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):

1:17 PM Changeset in webkit [142662] by luiz@webkit.org
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist

Adding myself to watch lists.

Unreviewed.

  • Scripts/webkitpy/common/config/watchlist:
1:15 PM Changeset in webkit [142661] by pfeldman@chromium.org
  • 3 edits in branches/chromium/1364

Merge 142128

Web Inspector: [Regression] Map.size() returns negative values.
https://bugs.webkit.org/show_bug.cgi?id=109174

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/utilities.js:

LayoutTests:

  • inspector/map-expected.txt:
  • inspector/map.html:

TBR=vsevik@chromium.org
Review URL: https://codereview.chromium.org/12208136

1:07 PM Changeset in webkit [142660] by pfeldman@chromium.org
  • 1 edit in branches/chromium/1364/Source/WebCore/inspector/front-end/CallStackSidebarPane.js

Merge 142127

Web Inspector: break details are only rendered upon first debugger pause.
https://bugs.webkit.org/show_bug.cgi?id=109193

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.prototype.update):

TBR=pfeldman@chromium.org
Review URL: https://codereview.chromium.org/12225145

1:06 PM Changeset in webkit [142659] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r136967): Combination of float and clear yields to bad layout
https://bugs.webkit.org/show_bug.cgi?id=109476

Reviewed by Levi Weintraub.

Source/WebCore:

Test: fast/block/margin-collapse/self-collapsing-block-with-float-children.html

The change made at http://trac.webkit.org/changeset/136967 only needs to worry about the first floated
child of a self-collapsing block. The ones that follow are not affected by its margins.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-children-expected.txt: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-children.html: Added.
1:03 PM Changeset in webkit [142658] by eae@chromium.org
  • 7 edits
    10 adds
    2 deletes in trunk/LayoutTests

Unreviewed rebaseline for r142638.

  • platform/chromium-linux-x86/fast/dom/Window: Removed.
  • platform/chromium-linux-x86/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt: Removed.
  • platform/chromium-mac/fast/dom/Window/webkitConvertPoint-expected.txt:
  • platform/chromium-win/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/mac-lion/accessibility: Added.
  • platform/mac-lion/accessibility/table-attributes-expected.txt: Added.
  • platform/mac-lion/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-lion/accessibility/table-sections-expected.txt: Added.
  • platform/mac-lion/fast/dom/Window: Added.
  • platform/mac-lion/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac-wk2/accessibility/table-cell-spans-expected.txt: Added.
  • platform/mac-wk2/fast/dom/Window: Added.
  • platform/mac-wk2/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac/accessibility/image-link-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt:
1:01 PM Changeset in webkit [142657] by leviw@chromium.org
  • 3 edits
    2 adds in trunk
ASSERTION FAILED: !object
object->isBox(), UNKNOWN in WebCore::RenderListItem::positionListMarker

https://bugs.webkit.org/show_bug.cgi?id=108699

Reviewed by Abhishek Arya.

Source/WebCore:

RenderListItems performs special management of its children to maintain list markers. Splitting a flow
through a list item results in assumptions made inside RenderListItem failing, so for now, avoid splitting
flows when inside one.

Test: fast/multicol/span/list-multi-column-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

  • fast/multicol/span/list-multi-column-crash-expected.txt: Added.
  • fast/multicol/span/list-multi-column-crash.html: Added.
12:56 PM Changeset in webkit [142656] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Change the queue client base class to be private everywhere
https://bugs.webkit.org/show_bug.cgi?id=109604

Reviewed by Andreas Kling.

Move connection queue client registration inside of the respective queue client classes.

Also, it's too late to add queue clients in ChildProcessProxy::didFinishLaunching, so do this in
ChildProcessProxy::connectionWillOpen instead.

Finally, assert that queue clients are only being added and removed from the client thread.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::addQueueClient):
(CoreIPC::Connection::removeQueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initializeConnection):
(WebKit):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::connectionWillOpen):
(WebKit):
(WebKit::NetworkProcessProxy::connectionWillClose):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:

(NetworkProcessProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::didFinishLaunching):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::initializeConnection):
(WebKit):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit):

  • WebProcess/Plugins/PluginProcessConnectionManager.h:

(PluginProcessConnectionManager):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::initializeConnection):
(WebKit):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

12:56 PM Changeset in webkit [142655] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::Internals):

12:45 PM Changeset in webkit [142654] by vivek.vg@samsung.com
  • 10 edits
    2 adds in trunk

Web Inspector: JavaScript execution disabled by browser/UA should be notified to the front-end
https://bugs.webkit.org/show_bug.cgi?id=109402

Reviewed by Yury Semikhatsky.

Source/WebCore:

Whenever the UA/Browser changes the Script Execution state of a page, it should notify the
inspector front-end. Added the InspectorInstrumentation method didScriptExecutionStateChange
to achieve this. Also the state change triggered by the inspector should be ignored to avoid
infinite loop.

Test: inspector/script-execution-state-change-notification.html

  • inspector/Inspector.json:
  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::scriptsEnabledImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::setScriptExecutionDisabled):
(WebCore::InspectorPageAgent::scriptsEnabled):
(WebCore):

  • inspector/InspectorPageAgent.h:

(InspectorPageAgent):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
(WebInspector.PageDispatcher.prototype.scriptsEnabled):

  • page/Settings.cpp:

(WebCore::Settings::setScriptEnabled):

LayoutTests:

Tests that whenever Script Execution state is changed outside inspector, its notified to the Inspector front-end.

  • inspector/script-execution-state-change-notification-expected.txt: Added.
  • inspector/script-execution-state-change-notification.html: Added.
12:23 PM Changeset in webkit [142653] by jsbell@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] IndexedDB/Worker crash during shutdown
https://bugs.webkit.org/show_bug.cgi?id=109467

Reviewed by Tony Chang.

If the message queue has already been terminated, don't bother scheduling
a new error event that will never be delivered. Speculative fix for the
issue, which only repros in multiprocess ports and so far only on some
platforms.

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB): Early exit.

12:14 PM Changeset in webkit [142652] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Cache timer heap pointer to timers
https://bugs.webkit.org/show_bug.cgi?id=109597

Reviewed by Andreas Kling.

Accessing timer heap through thread global storage is slow (~0.1% in PLT3). We can cache the heap pointer to
each TimerBase. There are not huge numbers of timers around so memory is not an issue and many timers are heavily reused.

  • platform/Timer.cpp:

(WebCore::threadGlobalTimerHeap):
(WebCore::TimerHeapReference::operator=):
(WebCore::TimerHeapIterator::checkConsistency):
(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::checkHeapIndex):
(WebCore::TimerBase::setNextFireTime):

  • platform/Timer.h:

(WebCore::TimerBase::timerHeap):
(TimerBase):

12:12 PM Changeset in webkit [142651] by beidson@apple.com
  • 17 edits
    2 adds in trunk/Source/WebKit2

Add WKContext API to retrieve basic network process statistics
https://bugs.webkit.org/show_bug.cgi?id=109329

Reviewed by Sam Weinig.

This patch adds a WKContextGetStatisticsWithOptions which allows the client to ask for
certain types of statistics.

It also expands the "get statistics" callback mechanism to allow for a statistics request
to be answered by multiple child processes.

That mechanism still has some rough edges but will eventually allow for getting statistics
from multiple web processes, as well.

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::pendingRequestCount):
(WebKit::HostRecord::activeLoadCount):

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::getNetworkProcessStatistics):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::hostsPendingCount):
(WebKit::NetworkResourceLoadScheduler::loadsPendingCount):
(WebKit::NetworkResourceLoadScheduler::hostsActiveCount):
(WebKit::NetworkResourceLoadScheduler::loadsActiveCount):

  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):

  • Shared/Downloads/DownloadManager.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetStatistics):
(WKContextGetStatisticsWithOptions):

  • UIProcess/API/C/WKContext.h:
  • UIProcess/StatisticsRequest.cpp: Added.

(WebKit::StatisticsRequest::StatisticsRequest):
(WebKit::StatisticsRequest::~StatisticsRequest):
(WebKit::StatisticsRequest::addOutstandingRequest):
(WebKit::addToDictionaryFromHashMap):
(WebKit::createDictionaryFromHashMap):
(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/StatisticsRequest.h: Added.

(WebKit::StatisticsRequest::create):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::networkingProcessConnection):
(WebKit::WebContext::getStatistics):
(WebKit::WebContext::requestWebContentStatistics):
(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::didGetStatistics):

  • UIProcess/WebContext.h:
  • UIProcess/WebContext.messages.in:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::getWebCoreStatistics):

  • WebKit2.xcodeproj/project.pbxproj:
11:56 AM Changeset in webkit [142650] by Martin Robinson
  • 2 edits in trunk/Source/JavaScriptCore

Fix the gyp build of JavaScriptCore.

  • JavaScriptCore.gypi: Added some missing DFG files to the source list.
11:46 AM Changeset in webkit [142649] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r142387.
http://trac.webkit.org/changeset/142387
https://bugs.webkit.org/show_bug.cgi?id=109601

caused all layout and jscore tests on windows to fail
(Requested by kling on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(UnlinkedCodeBlock):

11:39 AM Changeset in webkit [142648] by abarth@webkit.org
  • 4 edits in trunk/Source/WebCore

BackgroundHTMLParser::resumeFrom should take a struct
https://bugs.webkit.org/show_bug.cgi?id=109598

Reviewed by Eric Seidel.

This patch is purely a syntatic change that paves the way for fixing
the partial-entity document.write tests. To fix those tests, we'll need
to pass more information to resumeFrom, but we're hitting the argument
limits in Functional.h. Rather than adding yet more arguments, this
patch moves to a single argument that's a struct.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):

  • html/parser/BackgroundHTMLParser.h:

(Checkpoint):
(BackgroundHTMLParser):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::didFailSpeculation):

11:35 AM Changeset in webkit [142647] by esprehn@chromium.org
  • 3 edits in trunk/Source/WebCore

rootRenderer in FrameView is really RenderView
https://bugs.webkit.org/show_bug.cgi?id=109510

Reviewed by Eric Seidel.

The global function rootRenderer(FrameView*) is really just a way
to get the RenderView from the Frame so replace it with a renderView()
method and replace usage of the word "root" with renderView so it's
obvious the root we're talking about is the renderView. This is an
important distinction to make since we also have rootRenderer in the code
for the documentElement()'s renderer and we also have a "layout root" which
is entirely different.

No new tests, just refactoring.

  • page/FrameView.cpp:

(WebCore::FrameView::rootRenderer): Removed.
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::updateCompositingLayersAfterStyleChange):
(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::clearBackingStores):
(WebCore::FrameView::restoreBackingStores):
(WebCore::FrameView::usesCompositedScrolling):
(WebCore::FrameView::layerForHorizontalScrollbar):
(WebCore::FrameView::layerForVerticalScrollbar):
(WebCore::FrameView::layerForScrollCorner):
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::scrollLayerID):
(WebCore::FrameView::layerForOverhangAreas):
(WebCore::FrameView::flushCompositingStateForThisFrame):
(WebCore::FrameView::hasCompositedContent):
(WebCore::FrameView::enterCompositingMode):
(WebCore::FrameView::isSoftwareRenderable):
(WebCore::FrameView::didMoveOnscreen):
(WebCore::FrameView::willMoveOffscreen):
(WebCore::FrameView::layout):
(WebCore::FrameView::embeddedContentBox):
(WebCore::FrameView::contentsInCompositedLayer):
(WebCore::FrameView::scrollContentsFastPath):
(WebCore::FrameView::scrollContentsSlowPath):
(WebCore::FrameView::maintainScrollPositionAtAnchor):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
(WebCore::FrameView::visibleContentsResized):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::needsLayout):
(WebCore::FrameView::setNeedsLayout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::updateControlTints):
(WebCore::FrameView::paintContents):
(WebCore::FrameView::forceLayoutForPagination):
(WebCore::FrameView::adjustPageHeightDeprecated):
(WebCore::FrameView::resetTrackedRepaints):
(WebCore::FrameView::isVerticalDocument):
(WebCore::FrameView::isFlippedDocument):

  • page/FrameView.h:

(WebCore::FrameView::renderView): Added.

11:27 AM Changeset in webkit [142646] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][Introspection] GObject bindings for DataTransferItemList - one add() method must be removed from .idl
https://bugs.webkit.org/show_bug.cgi?id=109180

Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-12
Reviewed by Xan Lopez.

When compiling WebKit with --enable-introspection and generating GObject bindings
for DataTransferItemList we must disable one add() method, because GObject is
based on C and C does not allow two functions with the same name.

No tests needed.

  • bindings/scripts/CodeGeneratorGObject.pm:
11:13 AM Changeset in webkit [142645] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Background size width specified in viewport percentage units not working
https://bugs.webkit.org/show_bug.cgi?id=109536

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Corrected the check for viewport percentage unit while calculating
background image width.

Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

Added a test for background image width specified in viewport percentage unit.

  • fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
  • fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
11:04 AM Changeset in webkit [142644] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Build fix.

Add back the files to the Xcode project that were removed in r142580.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
10:50 AM Changeset in webkit [142643] by jochen@chromium.org
  • 14 edits
    1 copy in trunk/Tools

[chromium] move text dump generation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109575

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebKit):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestCommon.h.

(WebTestRunner::normalizeLayoutTestURL):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestCommon.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::checkResponseMimeType):
(WebTestRunner):
(WebTestRunner::TestRunner::shouldDumpAsText):
(WebTestRunner::TestRunner::shouldGeneratePixelResults):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::captureTree):
(WebTestRunner):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::dump):
(TestShell::captureHistoryForWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::captureHistoryForWindow):

  • DumpRenderTree/chromium/WebViewHost.h:
10:49 AM Changeset in webkit [142642] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Heap-use-after-free in WebCore::DeleteButtonController::enable
https://bugs.webkit.org/show_bug.cgi?id=109447

Reviewed by Ryosuke Niwa.

RefPtr frame pointer since it can get deleted due to mutation events
fired inside AppendNodeCommand::doUnapply.

No new tests. Testcase is hard to minimize due to recursive
calls with DOMNodeRemovedFromDocument mutation event.

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

10:43 AM Changeset in webkit [142641] by eric@webkit.org
  • 26 edits
    1 add
    1 delete in trunk/Source/WebCore

Remove HTMLTokenTypes header (and split out AtomicHTMLToken.h from HTMLToken.h)
https://bugs.webkit.org/show_bug.cgi?id=109525

Reviewed by Adam Barth.

We no longer need a separate HTMLTokenTypes class now that NEW_XML is gone.
However, to remove HTMLTokenTypes, I had to split AtomicHTMLToken.h from
HTMLToken.h (to fix a circular dependancy).

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addSource):

  • html/parser/AtomicHTMLToken.h: Added.

(WebCore):
(AtomicHTMLToken):
(WebCore::AtomicHTMLToken::create):
(WebCore::AtomicHTMLToken::forceQuirks):
(WebCore::AtomicHTMLToken::type):
(WebCore::AtomicHTMLToken::name):
(WebCore::AtomicHTMLToken::setName):
(WebCore::AtomicHTMLToken::selfClosing):
(WebCore::AtomicHTMLToken::getAttributeItem):
(WebCore::AtomicHTMLToken::attributes):
(WebCore::AtomicHTMLToken::characters):
(WebCore::AtomicHTMLToken::charactersLength):
(WebCore::AtomicHTMLToken::isAll8BitData):
(WebCore::AtomicHTMLToken::comment):
(WebCore::AtomicHTMLToken::publicIdentifier):
(WebCore::AtomicHTMLToken::systemIdentifier):
(WebCore::AtomicHTMLToken::clearExternalCharacters):
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
(WebCore::AtomicHTMLToken::initializeAttributes):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::simulateTreeBuilder):

  • html/parser/CompactHTMLToken.cpp:

(WebCore::CompactHTMLToken::CompactHTMLToken):

  • html/parser/CompactHTMLToken.h:

(WebCore::CompactHTMLToken::type):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertForeignElement):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore::isStartOrEndTag):
(WebCore::HTMLPreloadScanner::processToken):

  • html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::start):
(WebCore::HTMLSourceTracker::sourceForToken):

  • html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::HTMLStackItem):

  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::clear):
(WebCore::HTMLToken::isUninitialized):
(WebCore::HTMLToken::type):
(WebCore::HTMLToken::makeEndOfFile):
(WebCore::HTMLToken::data):
(WebCore::HTMLToken::name):
(WebCore::HTMLToken::appendToName):
(WebCore::HTMLToken::forceQuirks):
(WebCore::HTMLToken::setForceQuirks):
(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::publicIdentifier):
(WebCore::HTMLToken::systemIdentifier):
(WebCore::HTMLToken::setPublicIdentifierToEmptyString):
(WebCore::HTMLToken::setSystemIdentifierToEmptyString):
(WebCore::HTMLToken::appendToPublicIdentifier):
(WebCore::HTMLToken::appendToSystemIdentifier):
(WebCore::HTMLToken::selfClosing):
(WebCore::HTMLToken::setSelfClosing):
(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::addNewAttribute):
(WebCore::HTMLToken::appendToAttributeName):
(WebCore::HTMLToken::appendToAttributeValue):
(WebCore::HTMLToken::attributes):
(WebCore::HTMLToken::eraseValueOfAttribute):
(WebCore::HTMLToken::ensureIsCharacterToken):
(WebCore::HTMLToken::characters):
(WebCore::HTMLToken::appendToCharacter):
(WebCore::HTMLToken::comment):
(WebCore::HTMLToken::beginComment):
(WebCore::HTMLToken::appendToComment):
(WebCore::HTMLToken::eraseCharacters):
(HTMLToken):

  • html/parser/HTMLTokenTypes.h: Removed.
  • html/parser/HTMLTokenizer.cpp:

(WebCore::AtomicHTMLToken::usesName):
(WebCore::AtomicHTMLToken::usesAttributes):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore::HTMLTokenizer::nextToken):

  • html/parser/HTMLTokenizer.h:

(WebCore::HTMLTokenizer::saveEndTagNameIfNeeded):
(WebCore::HTMLTokenizer::haveBufferedCharacterToken):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processToken):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processFakeStartTag):
(WebCore::HTMLTreeBuilder::processFakeEndTag):
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope):
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
(WebCore):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTagForInTable):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacter):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::defaultForBeforeHead):
(WebCore::HTMLTreeBuilder::defaultForInHead):
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript):
(WebCore::HTMLTreeBuilder::defaultForAfterHead):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::updateTokenizerState):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::insertFakePreElement):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):

10:40 AM Changeset in webkit [142640] by commit-queue@webkit.org
  • 8 edits in trunk

Handle error recovery in @supports
https://bugs.webkit.org/show_bug.cgi?id=103934

Patch by Pablo Flouret <pablof@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Tests 021, 024, 031, and 033 in
http://hg.csswg.org/test/file/5f94e4b03ed9/contributors/opera/submitted/css3-conditional
fail because there's no explicit error recovery in @support's grammar.
Opera and Firefox pass the tests.

No new tests, modified css3/supports{,-cssom}.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
(WebCore::CSSParser::popSupportsRuleData):

  • css/CSSParser.h:

LayoutTests:

  • css3/supports-cssom.html:
  • css3/supports-expected.txt:
  • css3/supports.html:
10:34 AM Changeset in webkit [142639] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] guard against NULL languages array
https://bugs.webkit.org/show_bug.cgi?id=109595

Reviewed by Dean Jackson.

No new tests, existing tests won't crash if this is correct.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::preferredLanguages):

9:40 AM Changeset in webkit [142638] by eae@chromium.org
  • 9 edits
    4 adds in trunk

TransformState::move should not round offset to int
https://bugs.webkit.org/show_bug.cgi?id=108266

Source/WebCore:

Reviewed by Simon Fraser.

Currently TransformState::move rounds the offset to the nearest
integer values, this results in operations using TransformState
to compute a position to misreport the location, specifically
Element:getBoundingClientRect and repaint rects. Sizes are
handled correctly and do not have the same problem.

Tests: fast/sub-pixel/boundingclientrect-subpixel-margin.html

fast/sub-pixel/clip-rect-box-consistent-rounding.html

  • page/FrameView.cpp:

(WebCore::FrameView::convertFromRenderer):
Change to use pixel snapping instead of enclosing box. All other
code paths use pixelSnappedIntRect to align the rects to device
pixels however this used enclosingIntRect (indirectly through
the FloatQuad::enclosingBoundingBox call).
Without the rounding in TransformState this causes repaint rects
for elements on subpixel bounds to be too large by up to one
pixel on each axis. For normal repaints this isn't really a
problem but in scrollContentsSlowPath it can result in moving
too large a rect.

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::translateTransform):
(WebCore::TransformState::translateMappedCoordinates):
Change to take a LayoutSize instead of an IntSize.

(WebCore::TransformState::move):
(WebCore::TransformState::applyAccumulatedOffset):

  • platform/graphics/transforms/TransformState.h:

Remove rounding logic and use original, more precise, value.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer):
Remove rounding logic and use original, more precise, value.

LayoutTests:

Reviewed by Simon Fraser.

Add new tests for Element::boundingClientRect and clip rects for
elements on subpixel boundaries.

  • fast/dom/Window/webkitConvertPoint.html:
  • platform/chromium-linux/fast/dom/Window/webkitConvertPoint-expected.txt:

Update test and expectations to take new rounding into account.

  • fast/sub-pixel/boundingclientrect-subpixel-margin-expected.txt: Added.
  • fast/sub-pixel/boundingclientrect-subpixel-margin.html: Added.

Add test ensuring that boundingClientRect returns accurate and
precise (as opposed to rounded) metrics.

  • fast/sub-pixel/clip-rect-box-consistent-rounding-expected.html: Added.
  • fast/sub-pixel/clip-rect-box-consistent-rounding.html: Added.

Add test ensuring that clip rects and elements use consistent rounding.

9:37 AM Changeset in webkit [142637] by jberlin@webkit.org
  • 8 edits
    1 delete in trunk

Rollout r142618, it broke all the Mac builds.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(WebCore):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
9:34 AM Changeset in webkit [142636] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG CompareEq optimization should be retuned
https://bugs.webkit.org/show_bug.cgi?id=109545

Reviewed by Mark Hahnenberg.

  • Made the object-to-object equality case work again by hoisting the if statement for it. Previously, object-to-object equality would be compiled as object-to-object-or-other.


  • Added AbstractState guards for most of the type checks that the object equality code uses.


Looks like a hint of a speed-up on all of the things.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):

9:05 AM Changeset in webkit [142635] by rafaelw@chromium.org
  • 5 edits in trunk

[HTMLTemplateElement] <template> inside of <head> may not create <body> if EOF is hit
https://bugs.webkit.org/show_bug.cgi?id=109338

Reviewed by Adam Barth.

Source/WebCore:

This patch adds the logic to clear the stack of open elements back to the first <template> when EOF
is hit. This allows a <body> to be generated if the initial <template> was opened inside of <head>.

Tests added to html5lib.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore):
(WebCore::HTMLTreeBuilder::popAllTemplates):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
9:04 AM Changeset in webkit [142634] by Martin Robinson
  • 5 edits in trunk

[GTK] Remove the enable-debug-feature configuration option
https://bugs.webkit.org/show_bug.cgi?id=109539

Reviewed by Philippe Normand.

Remove the --enable-debug-feature option from configuration. It doesn't
do anything that --enable-debug doesn't.

  • Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
  • Source/autotools/ReadCommandLineArguments.m4: Ditto.
  • Source/autotools/SetupAutoconfHeader.m4: Ditto.
  • Source/autotools/SetupAutomake.m4: Ditto.
8:59 AM Changeset in webkit [142633] by keishi@webkit.org
  • 5 edits
    6 copies in branches/chromium/1364

Merge 142111

Source/WebCore: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=109136

Reviewed by Kent Tamura.

Calendar picker was using the "Clear" button to calculate the window width.
Since it doesn't exist when the input element has a required attribute,
it was throwing an error. This patch fixes the width calculating logic.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html

platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html

  • Resources/pagepopups/calendarPicker.css:

(.today-clear-area):

  • Resources/pagepopups/calendarPicker.js:

(CalendarPicker.prototype.fixWindowSize): Fixing the logic to calculate
the width. We don't want to use clear button because it doesn't exist
when a value is required.

LayoutTests: REGRESSION (r140778): Calendar Picker doesn't open when the element has the required attribute
https://bugs.webkit.org/show_bug.cgi?id=108055

Reviewed by Kent Tamura.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html: Added.
  • platform/chromium/TestExpectations:

TBR=keishi@webkit.org

8:59 AM Changeset in webkit [142632] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix after r142540 and r142518

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::didReceivePluginProcessConnectionManagerMessageOnConnectionWorkQueue):
This function was added to the header in r142518 but not implemented in that revision.
It wasn't a problem until r142540 started using it.
Add a stub implementation for it.

8:58 AM Changeset in webkit [142631] by dmazzoni@google.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: i < size(), UNKNOWN in WebCore::AccessibilityMenuListPopup::didUpdateActiveOption
https://bugs.webkit.org/show_bug.cgi?id=109452

Reviewed by Chris Fleizach.

Source/WebCore:

Send the accessibility childrenChanged notification in
HTMLSelectElement::setRecalcListItems instead of in childrenChanged
so that all possible codepaths are caught.

Test: accessibility/insert-selected-option-into-select-causes-crash.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

LayoutTests:

Add test to ensure a crash doesn't happen if a selected option
is added to a select element, which was triggering a code path where
the DOM has added a new child of the select but the accessibility
object never got updated.

  • accessibility/insert-selected-option-into-select-causes-crash-expected.txt: Added.
  • accessibility/insert-selected-option-into-select-causes-crash.html: Added.
8:55 AM Changeset in webkit [142630] by beidson@apple.com
  • 7 edits in trunk/Source/WebKit2

Make PluginProcessProxy a ChildProcessProxy.
https://bugs.webkit.org/show_bug.cgi?id=109513

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.h: Inherit from ThreadSafeRefCounted.
  • UIProcess/Network/NetworkProcessProxy.h: Don't inherit from RefCounted.
  • UIProcess/WebProcessProxy.h: Don't inherit from ThreadSafeRefCounted
  • UIProcess/Plugins/PluginProcessProxy.h: Don't inherit from RefCounted, do inherit from ChildProcessProxy

Rely on ChildProcessProxy for process launcher management and launch options:

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::PluginProcessProxy):
(WebKit::PluginProcessProxy::getLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessConnection):
(WebKit::PluginProcessProxy::getSitesWithData):
(WebKit::PluginProcessProxy::clearSiteData):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
(WebKit::PluginProcessProxy::getPluginProcessSerialNumber):

8:53 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
8:49 AM QtWebKit edited by jocelyn.turcotte@digia.com
General layouting and point users to the Qt bug tracker to report bugs (diff)
8:48 AM QtWebKitBugs edited by jocelyn.turcotte@digia.com
General cleanup related to bugs now being tracked in the Qt bug tracker (diff)
8:45 AM Changeset in webkit [142629] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off
<https://bugs.webkit.org/show_bug.cgi?id=109534>

Fixes the following build failure:

WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient'
bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)


  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldShowDeleteInterface): Protect with
ENABLE(DELETION_UI) macro.

8:18 AM Changeset in webkit [142628] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13196331> NetworkProcess deny mach-lookup com.apple.PowerManagement.control

Reviewed by Sam Weinig.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
8:01 AM Changeset in webkit [142627] by commit-queue@webkit.org
  • 13 edits in trunk

Web Inspector: for event listener provide handler function value in protocol and in UI
https://bugs.webkit.org/show_bug.cgi?id=109284

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-12
Reviewed by Yury Semikhatsky.

Source/WebCore:

The feature implies that we include a real handler function value into event listener description.
Protocol description, inspector DOM agent (with V8 and JSC backends) and front-end is patched accordingly.

  • bindings/js/ScriptEventListener.cpp:

(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):

  • bindings/js/ScriptEventListener.h:

(WebCore):

  • bindings/v8/ScriptEventListener.cpp:

(WebCore::eventListenerHandler):
(WebCore):
(WebCore::eventListenerHandlerScriptState):

  • bindings/v8/ScriptEventListener.h:

(WebCore):

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/front-end/DOMAgent.js:

(WebInspector.DOMNode.prototype.eventListeners):

  • inspector/front-end/EventListenersSidebarPane.js:

(WebInspector.EventListenersSidebarPane.prototype.update):
(.):

LayoutTests:

Test is rebased.

  • inspector/elements/event-listener-sidebar-expected.txt:
  • inspector/elements/event-listeners-about-blank-expected.txt:
7:56 AM Changeset in webkit [142626] by yurys@chromium.org
  • 8 edits
    1 add in trunk/Source/WebCore

Web Inspector: add initial implementation of native memory graph to Timeline
https://bugs.webkit.org/show_bug.cgi?id=109578

Reviewed by Alexander Pavlov.

This change adds inital implementation of native memory graph UI. The graph
will be shown in the same place as DOM counters graph on the Timeline panel.

Added NativeMemoryGraph.js that reuses parts of DOM counters graph
implementation. MemoryStatistics.js was refactor to allow sharing
more code between DOM counters and native memory graph.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype._createCurrentValuesBar):
(WebInspector.MemoryStatistics.prototype._createCounterUIList):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getNodeCount):
(WebInspector.MemoryStatistics.prototype._createCounterUIList.getListenerCount):
(WebInspector.MemoryStatistics.prototype._canvasHeight):
(WebInspector.MemoryStatistics.prototype._updateSize):
(WebInspector.MemoryStatistics.prototype._highlightCurrentPositionOnGraphs):
(WebInspector.MemoryStatistics.prototype._drawMarker):

  • inspector/front-end/NativeMemoryGraph.js: Added.

(WebInspector.NativeMemoryGraph):
(WebInspector.NativeMemoryCounterUI):
(WebInspector.NativeMemoryCounterUI.prototype._hslToString):
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
(WebInspector.NativeMemoryCounterUI.prototype.clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._createCurrentValuesBar):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList.getCounterValue):
(WebInspector.NativeMemoryGraph.prototype._createCounterUIList):
(WebInspector.NativeMemoryGraph.prototype._canvasHeight):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded.addStatistics):
(WebInspector.NativeMemoryGraph.prototype._onRecordAdded):
(WebInspector.NativeMemoryGraph.prototype._draw):
(WebInspector.NativeMemoryGraph.prototype._clearCurrentValueAndMarker):
(WebInspector.NativeMemoryGraph.prototype._updateCurrentValue):
(WebInspector.NativeMemoryGraph.prototype._restoreImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._saveImageUnderMarker):
(WebInspector.NativeMemoryGraph.prototype._drawMarker):
(WebInspector.NativeMemoryGraph.prototype._maxCounterValue):
(WebInspector.NativeMemoryGraph.prototype._resetTotalValues):
(WebInspector.NativeMemoryGraph.prototype.valueGetter):
(WebInspector.NativeMemoryGraph.prototype._drawGraph):
(WebInspector.NativeMemoryGraph.prototype._discardImageUnderMarker):

  • inspector/front-end/TimelinePanel.js:
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/timelinePanel.css:

(#memory-graphs-canvas-container.dom-counters .resources-dividers):
(.memory-category-value):

7:53 AM Changeset in webkit [142625] by yurys@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Fix Chromium compilation after r142618.

  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::HeapGraphReceiver::printNode):

7:33 AM Changeset in webkit [142624] by kareng@chromium.org
  • 4 edits in branches/chromium/1410/Source/WebCore/bindings/v8

Merge 142565

[V8] ScheduledAction::m_context can be empty, so we shouldn't
retrieve an Isolate by using m_context->GetIsolate()
https://bugs.webkit.org/show_bug.cgi?id=109523

Reviewed by Adam Barth.

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=175307#makechanges

Currently ScheduledAction is retrieving an Isolate by using m_context->GetIsolate().
This can crash because ScheduledAction::m_context can be empty. Specifically,
ScheduledAction::m_context is set to ScriptController::currentWorldContext(),
which can return an empty handle when a frame does not exist. In addition,
'if(context.IsEmpty())' in ScheduledAction.cpp implies that it can be empty.

Alternately, we should pass an Isolate explicitly when a ScheduledAction is instantiated.

No tests. The Chromium crash report doesn't provide enough information
to reproduce the bug.

  • bindings/v8/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore):
(WebCore::ScheduledAction::~ScheduledAction):

  • bindings/v8/ScheduledAction.h:

(ScheduledAction):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::WindowSetTimeoutImpl):

  • bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::SetTimeoutOrInterval):

TBR=haraken@chromium.org
Review URL: https://codereview.chromium.org/12211130

7:29 AM Changeset in webkit [142623] by kareng@chromium.org
  • 1 add in branches/chromium/1410/codereview.settings

for easy drovering into m26

7:28 AM Changeset in webkit [142622] by kareng@chromium.org
  • 1 copy in branches/chromium/1410

branching for m27

7:18 AM Changeset in webkit [142621] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Web Inspector: refactor some reusable functionality from BraceHighlighter
https://bugs.webkit.org/show_bug.cgi?id=109574

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Pavel Feldman.

Source/WebCore:

New test: inspector/editor/text-editor-brace-highlighter.html

Extract functionality which, for given line and cursor position, will
return position for a brace that should be highlighted. Add a layout
test to verify brace highlighter funcionality.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.activeBraceColumnForCursorPosition):
(WebInspector.TextEditorMainPanel.BraceHighlightController.prototype.handleSelectionChange):

  • inspector/front-end/TextUtils.js:

(WebInspector.TextUtils.isOpeningBraceChar):
(WebInspector.TextUtils.isClosingBraceChar):
(WebInspector.TextUtils.isBraceChar):

LayoutTests:

Add layout test to verify brace highlighter functionality.

  • inspector/editor/text-editor-brace-highlighter-expected.txt: Added.
  • inspector/editor/text-editor-brace-highlighter.html: Added.
7:06 AM Changeset in webkit [142620] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

[GTK] Add an optional moduleset with hard to get packages (including libsecret)
https://bugs.webkit.org/show_bug.cgi?id=109195

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-12
Reviewed by Philippe Normand.

Add an optional moduleset that includes libsecret. This moduleset will
be used to install some annoyingly hard to obtain dependencies on older
distributions.

  • gtk/jhbuild-optional.modules: Added.
  • gtk/jhbuild.modules: Add a reference to the new moduleset file.
6:58 AM Changeset in webkit [142619] by atwilson@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectation update.
https://bugs.webkit.org/show_bug.cgi?id=109581

  • platform/chromium/TestExpectations: mark debugger-script-preprocessor.html as crashy.
6:53 AM Changeset in webkit [142618] by loislo@chromium.org
  • 8 edits
    1 add in trunk

Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
https://bugs.webkit.org/show_bug.cgi?id=109554

Source/WebCore:

In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.

Drive by fix: I introduced a client interface for the HeapGraphSerializer.
It helps me to do the tests for the serializer.

Reviewed by Yury Semikhatsky.

It is covered by newly added tests in TestWebKitAPI.

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::pushUpdate):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::toNodeId):
(WebCore::HeapGraphSerializer::addRootNode):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializerClient):
(WebCore::HeapGraphSerializerClient::~HeapGraphSerializerClient):
(HeapGraphSerializer):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getProcessMemoryDistributionImpl):

Tools:

In some cases leaves have no pointer. As example when we report a leaf via addPrivateBuffer.
This patch has new set of tests for HeapGraphSerializer.

Reviewed by Yury Semikhatsky.

  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
6:51 AM Changeset in webkit [142617] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed followup to r142606, the EFL port also enables the CSS image-set
feature so the new configuration option's default value should reflect that.

  • Scripts/webkitperl/FeatureList.pm:
6:40 AM Changeset in webkit [142616] by rgabor@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC asserting with long parameter list functions in debug mode on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=109565

Reviewed by Zoltan Herczeg.

Increase the value of sequenceGetByIdSlowCaseInstructionSpace to 80.

  • jit/JIT.h:
6:33 AM Changeset in webkit [142615] by atwilson@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed chromium rebaselines after r142586.

  • platform/chromium-mac/fast/canvas/webgl/webgl-layer-update-expected.png: Added.
6:29 AM Changeset in webkit [142614] by vsevik@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Introduce version controller to migrate settings versions.
https://bugs.webkit.org/show_bug.cgi?id=109553

Reviewed by Yury Semikhatsky.

Source/WebCore:

This patch introduces version controller that could be used to migrate inspector settings.

Test: inspector/version-controller.html

  • inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.VersionController):
(WebInspector.VersionController.prototype.set _methodsToRunToUpdateVersion):
(WebInspector.VersionController.prototype._updateVersionFrom0To1):

  • inspector/front-end/inspector.js:

LayoutTests:

  • inspector/version-controller-expected.txt: Added.
  • inspector/version-controller.html: Added.
6:19 AM Changeset in webkit [142613] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: File system should produce more verbose error messages and recover from errors
https://bugs.webkit.org/show_bug.cgi?id=109571

Reviewed by Alexander Pavlov.

Error handler prints original file system call params now.
Added callbacks to error handler to recover from errors.

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
(WebInspector.FileSystemUtils.errorMessage):
(.fileSystemLoaded):
(.fileEntryLoaded):
(.errorHandler):
(WebInspector.FileSystemUtils.requestFileContent):
(WebInspector.FileSystemUtils.setFileContent):
(WebInspector.FileSystemUtils._readDirectory):
(.innerCallback):
(WebInspector.FileSystemUtils._requestEntries):

6:17 AM Changeset in webkit [142612] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Get rid of unnecessary complexity in FileSystemUtil: remove _getDirectory() method.
https://bugs.webkit.org/show_bug.cgi?id=109567

Reviewed by Alexander Pavlov.

The code in this method was redundant as the same result could be achieved by using File System API directly.

  • inspector/front-end/FileSystemProjectDelegate.js:
6:15 AM Changeset in webkit [142611] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [SuggestBox] SuggestBox not hidden when prefix is empty and there is preceding input
https://bugs.webkit.org/show_bug.cgi?id=109568

Reviewed by Vsevolod Vlasov.

The suggestbox would get hidden in the case of empty input, yet it should get hidden
in the case of empty user-entered prefix (which is a wider notion.)

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

6:04 AM Changeset in webkit [142610] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebCore

Web Inspector: separate SuggestBox from TextPrompt
https://bugs.webkit.org/show_bug.cgi?id=109430

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Alexander Pavlov.

Create WebInspector.SuggestBoxDelegate interface and
refactor TextPrompt to use this interface. Separate SuggestBox into
WebInspector.SuggestBox namespace and put it into its own file.

No new tests: no change in behaviour.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/compile-front-end.py:
  • inspector/front-end/SuggestBox.js: Added.

(WebInspector.SuggestBoxDelegate):
(WebInspector.SuggestBoxDelegate.prototype.applySuggestion):
(WebInspector.SuggestBoxDelegate.prototype.acceptSuggestion):
(WebInspector.SuggestBoxDelegate.prototype.userEnteredText):
(WebInspector.SuggestBox):
(WebInspector.SuggestBox.prototype.get visible):
(WebInspector.SuggestBox.prototype.get hasSelection):
(WebInspector.SuggestBox.prototype._onscrollresize):
(WebInspector.SuggestBox.prototype._updateBoxPositionWithExistingAnchor):
(WebInspector.SuggestBox.prototype._updateBoxPosition):
(WebInspector.SuggestBox.prototype._onboxmousedown):
(WebInspector.SuggestBox.prototype.hide):
(WebInspector.SuggestBox.prototype.removeFromElement):
(WebInspector.SuggestBox.prototype._applySuggestion):
(WebInspector.SuggestBox.prototype.acceptSuggestion):
(WebInspector.SuggestBox.prototype._selectClosest):
(WebInspector.SuggestBox.prototype.updateSuggestions):
(WebInspector.SuggestBox.prototype._onItemMouseDown):
(WebInspector.SuggestBox.prototype._createItemElement):
(WebInspector.SuggestBox.prototype._updateItems):
(WebInspector.SuggestBox.prototype._selectItem):
(WebInspector.SuggestBox.prototype._canShowBox):
(WebInspector.SuggestBox.prototype._rememberRowCountPerViewport):
(WebInspector.SuggestBox.prototype._completionsReady):
(WebInspector.SuggestBox.prototype.upKeyPressed):
(WebInspector.SuggestBox.prototype.downKeyPressed):
(WebInspector.SuggestBox.prototype.pageUpKeyPressed):
(WebInspector.SuggestBox.prototype.pageDownKeyPressed):
(WebInspector.SuggestBox.prototype.enterKeyPressed):
(WebInspector.SuggestBox.prototype.tabKeyPressed):

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.userEnteredText):
(WebInspector.TextPrompt.prototype._attachInternal):
(WebInspector.TextPrompt.prototype._completionsReady):
(WebInspector.TextPrompt.prototype.applySuggestion):
(WebInspector.TextPrompt.prototype._applySuggestion):
(WebInspector.TextPrompt.prototype.enterKeyPressed):
(WebInspector.TextPrompt.prototype.upKeyPressed):
(WebInspector.TextPrompt.prototype.downKeyPressed):
(WebInspector.TextPrompt.prototype.pageUpKeyPressed):
(WebInspector.TextPrompt.prototype.pageDownKeyPressed):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:56 AM Changeset in webkit [142609] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] Enable CSS Variables feature in development builds
https://bugs.webkit.org/show_bug.cgi?id=109474

Reviewed by Martin Robinson.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature on development

builds of the GTK port.

LayoutTests:

  • platform/gtk/TestExpectations: Remove the expectations for tests that now pass.
5:49 AM Changeset in webkit [142608] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540

Reviewed by Noam Rosenthal.

Adds basysKom copyright info to TextureMapperFPSCounter header.

  • platform/graphics/texmap/TextureMapperFPSCounter.cpp:
  • platform/graphics/texmap/TextureMapperFPSCounter.h:
5:27 AM Changeset in webkit [142607] by commit-queue@webkit.org
  • 5 edits in trunk

Unreviewed, rolling out r142531.
http://trac.webkit.org/changeset/142531
https://bugs.webkit.org/show_bug.cgi?id=109569

Causes html5lib/run-template layout test to crash. (Requested
by atwilson_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-12

Source/WebCore:

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processEndOfFile):

  • html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

LayoutTests:

  • html5lib/resources/template.dat:
5:25 AM Changeset in webkit [142606] by zandobersek@gmail.com
  • 6 edits
    1 delete in trunk

[GTK] Enable CSS image-set support in development builds
https://bugs.webkit.org/show_bug.cgi?id=109475

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - majority of the related tests now passes.

  • GNUmakefile.features.am.in: Add the feature define for the CSS image-set feature

with the define value defaulting to 0. The value gets overridden with 1 in development
builds, meaning the feature is enabled under that configuration.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.

Note that the Mac port also enables the feature but does so in Platform.h as the feature
is also enabled for the iOS port which can't at the moment be detected via webkitperl.

LayoutTests:

  • platform/gtk/TestExpectations: Reclassify two failures that now fail due to

cursor images not loading while the other expectations are removed as the tests
now pass.

  • platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Removed. The generic

expectation now matches the test output.

5:23 AM Changeset in webkit [142605] by zandobersek@gmail.com
  • 6 edits in trunk

[GTK] Enable DOM4 events constructors in development builds
https://bugs.webkit.org/show_bug.cgi?id=109471

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - the related tests now pass.

  • GNUmakefile.features.am.in: Add the feature define for the DOM4 events

constructors feature, its value defaulting to 0. This value is overridden
with 1 in development builds, effectively enabling the feature.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Enable the feature for the GTK port as well.

LayoutTests:

  • platform/gtk/TestExpectations: Remove the failure expectations, the related

tests now pass.

5:06 AM Changeset in webkit [142604] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for the GTK port after r142595.
Adding the TextureMapperFPSCounter files to the list of build targets
in case of using the OpenGL texture mapper.

  • GNUmakefile.list.am:
4:04 AM Changeset in webkit [142603] by caseq@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in extension server and API
https://bugs.webkit.org/show_bug.cgi?id=109563

Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ExtensionAPI.js: drive-by: make sure we fail if extensionServer is not defined in outer scope.
  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):

  • inspector/front-end/externs.js: add extensionServer
3:13 AM Changeset in webkit [142602] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed -- suppress stray console message that emerged after r142486.

  • inspector/extensions/extensions-events.html:
3:08 AM Changeset in webkit [142601] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Remove unnecessary variables from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=109558

Reviewed by Daniel Bates.

A small cleanup, removing unused variables for which the related configuration
options were already removed.

  • Scripts/webkitperl/FeatureList.pm:
3:06 AM Changeset in webkit [142600] by zandobersek@gmail.com
  • 9 edits in trunk

Remove ENABLE_XHR_RESPONSE_BLOB handling from various build systems
https://bugs.webkit.org/show_bug.cgi?id=109481

Reviewed by Daniel Bates.

The ENABLE_XHR_RESPONSE_BLOB feature define was removed from the code
back in r120574. There are still occurrences of it in various build systems
which should all be removed as they are useless.

.:

  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

  • features.gypi:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
2:58 AM Changeset in webkit [142599] by rniwa@webkit.org
  • 6 edits
    2 moves
    2 deletes in trunk/LayoutTests

REGRESSION(r142576): It made fast/dom/Element/id-in-deletebutton.html fail on Qt.
https://bugs.webkit.org/show_bug.cgi?id=109557

Build fix. Also move this test into platform/mac as done in r142559.

  • fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • fast/dom/Element/id-in-deletebutton.html: Removed.
  • platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/editing/deleting/id-in-deletebutton-expected.txt: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton-expected.txt.
  • platform/mac/editing/deleting/id-in-deletebutton.html: Copied from LayoutTests/fast/dom/Element/id-in-deletebutton.html.
  • platform/win/fast/dom/Element/id-in-deletebutton-expected.txt: Removed.
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
2:49 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
2:34 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu
(diff)
2:06 AM Changeset in webkit [142598] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix !ENABLE(INSPECTOR) builds after r142575

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-12

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willDispatchEvent):

2:04 AM Changeset in webkit [142597] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: move showWhitespace option into experiments
https://bugs.webkit.org/show_bug.cgi?id=109552

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-12
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Remove "show whitespace" setting and add it to experiments.

No new tests: fixed an existing test to verify changes.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SettingsScreen.js:

(WebInspector.GenericSettingsTab):

LayoutTests:

Fix layout test to switch on experiment instead of toggling one of the
options.

  • inspector/editor/text-editor-show-whitespace-expected.txt:
  • inspector/editor/text-editor-show-whitespace.html:
1:40 AM Changeset in webkit [142596] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Add error checking into OpenCL version of SVG filters.
https://bugs.webkit.org/show_bug.cgi?id=107444

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-12
Reviewed by Zoltan Herczeg.

In case of an error the program runs through all the remaining filters by doing nothing.
After that deletes the results of every filter and starts software rendering.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore):
(WebCore::FilterEffect::applyAll): At software rendering this is a simple inline methode, but at OpenCL rendering it releases OpenCL things. If we have an error remove filter's results and start software rendering.
(WebCore::FilterEffect::clearResultsRecursive):
(WebCore::FilterEffect::openCLImageToImageBuffer):
(WebCore::FilterEffect::createOpenCLImageResult):
(WebCore::FilterEffect::transformResultColorSpace):

  • platform/graphics/filters/FilterEffect.h:

(FilterEffect):
(WebCore::FilterEffect::applyAll):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore::FilterContextOpenCL::isFailed):
(WebCore):
(WebCore::FilterContextOpenCL::freeResources):
(WebCore::FilterContextOpenCL::destroyContext):
(WebCore::FilterContextOpenCL::compileTransformColorSpaceProgram):
(WebCore::FilterContextOpenCL::openCLTransformColorSpace):
(WebCore::FilterContextOpenCL::compileProgram):
(WebCore::FilterContextOpenCL::freeResource):

  • platform/graphics/gpu/opencl/FilterContextOpenCL.h:

(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(WebCore::FilterContextOpenCL::setInError):
(WebCore::FilterContextOpenCL::inError):
(FilterContextOpenCL):
(WebCore::FilterContextOpenCL::RunKernel::RunKernel):
(WebCore::FilterContextOpenCL::RunKernel::addArgument):
(WebCore::FilterContextOpenCL::RunKernel::run):
(RunKernel):

  • platform/graphics/gpu/opencl/OpenCLFEColorMatrix.cpp:

(WebCore::FilterContextOpenCL::compileFEColorMatrix):
(WebCore::FEColorMatrix::platformApplyOpenCL):

  • platform/graphics/gpu/opencl/OpenCLFETurbulence.cpp:

(WebCore::FilterContextOpenCL::compileFETurbulence):
(WebCore::FETurbulence::platformApplyOpenCL):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

1:34 AM Changeset in webkit [142595] by commit-queue@webkit.org
  • 22 edits
    2 adds in trunk/Source

[TexMap] Apply frames-per-second debug counter to WK1.
https://bugs.webkit.org/show_bug.cgi?id=109540

Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-12
Reviewed by Noam Rosenthal.

Source/WebCore:

r142524 implemented frames-per-second debug counter on WK2. This patch
applies frames-per-second debug counter to WK1 also.

Visual debugging feature, no need for new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperFPSCounter.cpp: Added.

(WebCore):
(WebCore::TextureMapperFPSCounter::TextureMapperFPSCounter):
(WebCore::TextureMapperFPSCounter::updateFPSAndDisplay):

  • platform/graphics/texmap/TextureMapperFPSCounter.h: Added.

(WebCore):
(TextureMapperFPSCounter):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::TextureMapperGL::drawNumber):

Rename from drawRepaintCounter to drawNumber.

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::TextureMapperImageBuffer::drawNumber):

  • platform/graphics/texmap/TextureMapperImageBuffer.h:

(TextureMapperImageBuffer):

  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:

(WebCore::CoordinatedBackingStore::drawRepaintCounter):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Move frames-per-second debug counter code to TextureMapperFPSCounter.

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::paintToGraphicsContext):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/efl:

Make AcceleratedCompositingContextEfl use TextureMapperFPSCounter.

  • WebCoreSupport/AcceleratedCompositingContextEfl.cpp:

(WebCore::AcceleratedCompositingContext::renderLayers):

  • WebCoreSupport/AcceleratedCompositingContextEfl.h:

(AcceleratedCompositingContext):

Source/WebKit/gtk:

Make AcceleratedCompositingContext use TextureMapperFPSCounter.

  • WebCoreSupport/AcceleratedCompositingContext.h:
  • WebCoreSupport/AcceleratedCompositingContextGL.cpp:

(WebKit::AcceleratedCompositingContext::compositeLayersToContext):

Source/WebKit/qt:

Make TextureMapperLayerClientQt use TextureMapperFPSCounter.

  • WebCoreSupport/TextureMapperLayerClientQt.cpp:

(TextureMapperLayerClientQt::renderCompositedLayers):

  • WebCoreSupport/TextureMapperLayerClientQt.h:

(TextureMapperLayerClientQt):

1:20 AM Changeset in webkit [142594] by yurys@chromium.org
  • 3 edits
    4 adds in trunk

Web Inspector: stack trace is cut at native bind if inspector is closed
https://bugs.webkit.org/show_bug.cgi?id=109427

Reviewed by Pavel Feldman.

Source/WebCore:

Only top frame is collected instead of full stack trace when inspector
front-end is closed to avoid expensive operations when exceptions are
thrown.

Test: http/tests/inspector-enabled/console-exception-while-no-inspector.html

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

LayoutTests:

Test that stack trace for uncaught exceptions is collected when inspector
front-end is closed.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
  • http/tests/inspector-enabled/console-exception-while-no-inspector.html: Added.
  • platform/chromium/http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Added.
12:47 AM Changeset in webkit [142593] by jochen@chromium.org
  • 17 edits
    12 moves in trunk

[chromium] move webrtc mocks to testrunner library
https://bugs.webkit.org/show_bug.cgi?id=109041

Reviewed by Adam Barth.

Tools:

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(WebKitSupportTestEnvironment):
(WebKitSupportTestEnvironment::mockPlatform):
(main):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:

(MockWebKitPlatformSupport::setInterfaces):
(MockWebKitPlatformSupport::createMediaStreamCenter):
(MockWebKitPlatformSupport::createRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/MockWebKitPlatformSupport.h:

(WebTestRunner):
(MockWebKitPlatformSupport):

  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestRunner):
(WebTestRunner::WebTestProxy::showContextMenu):
(WebTestRunner::WebTestProxy::userMediaClient):

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.cpp.

(WebTestRunner::MockConstraints::verifyConstraints):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Renamed from Tools/DumpRenderTree/chromium/MockConstraints.h.

(WebKit):
(WebTestRunner):
(MockConstraints):

  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp.

(WebTestRunner):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::queryMediaStreamSources):
(WebTestRunner::MockWebMediaStreamCenter::didEnableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didDisableMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didAddMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
(WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
(MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebAudioDestinationConsumer::~MockWebAudioDestinationConsumer):
(WebTestRunner::MockWebMediaStreamCenter::didCreateMediaStream):

  • DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Renamed from Tools/DumpRenderTree/chromium/MockWebMediaStreamCenter.h.

(WebKit):
(WebTestRunner):
(MockWebMediaStreamCenter):
(WebTestRunner::MockWebMediaStreamCenter::MockWebMediaStreamCenter):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp.

(WebTestRunner):
(DTMFSenderToneTask):
(WebTestRunner::DTMFSenderToneTask::DTMFSenderToneTask):
(WebTestRunner::MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::setClient):
(WebTestRunner::MockWebRTCDTMFSenderHandler::currentToneBuffer):
(WebTestRunner::MockWebRTCDTMFSenderHandler::canInsertDTMF):
(WebTestRunner::MockWebRTCDTMFSenderHandler::insertDTMF):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h.

(WebTestRunner):
(MockWebRTCDTMFSenderHandler):
(WebTestRunner::MockWebRTCDTMFSenderHandler::taskList):
(WebTestRunner::MockWebRTCDTMFSenderHandler::clearToneBuffer):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.cpp.

(WebTestRunner):
(DataChannelReadyStateTask):
(WebTestRunner::DataChannelReadyStateTask::DataChannelReadyStateTask):
(WebTestRunner::MockWebRTCDataChannelHandler::MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::setClient):
(WebTestRunner::MockWebRTCDataChannelHandler::bufferedAmount):
(WebTestRunner::MockWebRTCDataChannelHandler::sendStringData):
(WebTestRunner::MockWebRTCDataChannelHandler::sendRawData):
(WebTestRunner::MockWebRTCDataChannelHandler::close):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCDataChannelHandler.h.

(WebTestRunner):
(MockWebRTCDataChannelHandler):
(WebTestRunner::MockWebRTCDataChannelHandler::taskList):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp.

(WebTestRunner):
(RTCSessionDescriptionRequestSuccededTask):
(WebTestRunner::RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
(RTCSessionDescriptionRequestFailedTask):
(WebTestRunner::RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
(RTCStatsRequestSucceededTask):
(WebTestRunner::RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
(RTCVoidRequestTask):
(WebTestRunner::RTCVoidRequestTask::RTCVoidRequestTask):
(RTCPeerConnectionStateTask):
(WebTestRunner::RTCPeerConnectionStateTask::RTCPeerConnectionStateTask):
(RemoteDataChannelTask):
(WebTestRunner::RemoteDataChannelTask::RemoteDataChannelTask):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::initialize):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createOffer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createAnswer):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setLocalDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::setRemoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::localDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::remoteDescription):
(WebTestRunner::MockWebRTCPeerConnectionHandler::updateICE):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addICECandidate):
(WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
(WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDataChannel):
(WebTestRunner::MockWebRTCPeerConnectionHandler::createDTMFSender):
(WebTestRunner::MockWebRTCPeerConnectionHandler::stop):

  • DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Renamed from Tools/DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h.

(WebKit):
(WebTestRunner):
(MockWebRTCPeerConnectionHandler):
(WebTestRunner::MockWebRTCPeerConnectionHandler::taskList):
(WebTestRunner::MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::delegate):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::createMediaStreamCenter):
(WebTestRunner):
(WebTestRunner::WebTestInterfaces::createWebRTCPeerConnectionHandler):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::userMediaClient):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.cpp.

(WebTestRunner):
(UserMediaRequestTask):
(WebTestRunner::UserMediaRequestTask::UserMediaRequestTask):
(MockExtraData):
(WebTestRunner::WebUserMediaClientMock::WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::requestUserMedia):
(WebTestRunner::WebUserMediaClientMock::cancelUserMediaRequest):

  • DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/WebUserMediaClientMock.h.

(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

LayoutTests:

Temporarily disable two WebRTC tests that fail due to a bug in
webkit_support's getCurrentTimeMillsecond.

  • platform/chromium/TestExpectations:
12:34 AM Changeset in webkit [142592] by tkent@chromium.org
  • 16 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Mouse click not on sub-fields in multiple fields input should not move focus
https://bugs.webkit.org/show_bug.cgi?id=109544

Reviewed by Kentaro Hara.

Source/WebCore:

This is similar to Bug 108914, "Should not move focus if the element
already has focus." We fixed a focus() case in Bug 108914. However we
still have the problem in a case of focusing by mouse click.

The fix for Bug 108914 intercepted focus() function to change the
behavior. However focus-by-click doesn't call focus(), but calls
FocusController::setFocusedNode. To fix this problem, we introduce
oldFocusedNode argument to handleFocusEvent, and
BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent restores the
focus to oldFocusedNode if oldFocusedNode is one of sub-fields.
handleFocusEvent is called whenever the focused node is changed.

We don't need InputType::willCancelFocus any more because the new code
in handleFocusEvent covers it.

Tests: Update fast/forms/time-multiple-fields/time-multiple-fields-focus.html.

  • html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add oldFocusedNode argument.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
Pass oldFocusedNode to handleFocusEvent.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • Add oldFocusedNode argument to handleFocusEvent.
  • Remove focus() override.
  • html/HTMLInputElement.cpp: Remove focus() override.

(WebCore::HTMLInputElement::handleFocusEvent):
Pass oldFocusedNode to InputType::handleFocusEvent.

  • html/InputType.cpp: Remove willCancelFocus.

(WebCore::InputType::handleFocusEvent):
Add oldFocusedNode argument.

  • html/InputType.h:

(InputType): Ditto.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent): Ditto.

  • html/PasswordInputType.h:

(PasswordInputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Remove willCancelFocus, and add oldFocusedNode argument to handleFocusEvent.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
Pass oldFocusedNode to DateTimeEditElement::focusByOwner if the
direction is FocusDirectionNone.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Add oldFocusedNode argument to focusByOwner.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusByOwner):
If oldFocusedNode is one of sub-fields, focus on it again.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-focus.html:

Add test to click a delimiter.

12:07 AM Changeset in webkit [142591] by tasak@google.com
  • 5 edits in trunk/Source/WebCore

[Refactoring] Make m_selectorChecker in StyleResolver an on-stack object.
https://bugs.webkit.org/show_bug.cgi?id=108595

Reviewed by Eric Seidel.

StyleResolver uses SelectorChecker's mode to change its resolving mode.
However it is a state of StyleResolver. StyleResolver should have the
mode and make SelectorChecker instance on a stack while required.

No new tests, just refactoring.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheck):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::matchesFocusPseudoClass):
Changed to static class function, because these methods never use
"this".
(WebCore):

  • css/SelectorChecker.h:

(SelectorChecker):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
Now, matchesFocusPseudoClass is not a static method of
SelectorChecker, so replaced "m_selectorChecker." with
"SelectorChecker::".
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
Use m_mode instead of m_selectorChecker.mode().
Also use document()->inQuirksMode() instead of
m_selectoChecker.strictParsing().
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
Created an on-stack SelectorChecker object and used it to check
selectors.

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::State):
Added m_mode, this keeps m_selectorChecker's mode.
(State):
(StyleResolver):
Removed m_selectorChecker.

12:03 AM Changeset in webkit [142590] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Disabling WebFrameTest.ReplaceMisspelledRange on Android because it crashes
https://bugs.webkit.org/show_bug.cgi?id=109548

Unreviewed gardening.

  • tests/WebFrameTest.cpp:
Note: See TracTimeline for information about the timeline view.