Timeline

Feb 25, 2013:

11:57 PM Changeset in webkit [144014] by rniwa@webkit.org

• 2 edits in trunk/Tools

Another fix attempt after r143991 since having \r? after a greedy match doesn't help.

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.value_from_svn_info):

11:56 PM Changeset in webkit [144013] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

11:47 PM Changeset in webkit [144012] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Coordinated Graphics: remove redundant update of non compositing layer.
​https://bugs.webkit.org/show_bug.cgi?id=110444

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-02-25
Reviewed by Noam Rosenthal.

Currently, we update non compositing layer when the page scrolled. However, it
is not needed, because TiledBackingStore can scroll without tile update.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

11:42 PM Changeset in webkit [144011] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION(r143981): Crash in WebFrameLoaderClient::dispatchDidStartProvisionalLoad()
​https://bugs.webkit.org/show_bug.cgi?id=110848

Reviewed by Ryosuke Niwa.

NULL-check the result of document->documentElement().

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

11:21 PM Changeset in webkit [144010] by abarth@webkit.org

• 9 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=110784

Unreviewed.

This patch restores the code that I rolled out in
​http://trac.webkit.org/changeset/143960 and
​http://trac.webkit.org/changeset/143983. Rolling out those patches did
not heal the bot.

• dom/Element.cpp:

(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore):
(WebCore::UniqueElementData::attributeItem):

• dom/Element.h:

(ElementData):
(UniqueElementData):
(WebCore::isShadowHost):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):

• html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

• html/parser/CSSPreloadScanner.cpp:

(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

• html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::createCheckpoint):
(WebCore::TokenPreloadScanner::rewindTo):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):

• html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):
(WebCore::TokenPreloadScanner::isSafeToSendToAnotherThread):
(WebCore::TokenPreloadScanner::Checkpoint::Checkpoint):
(Checkpoint):

11:01 PM Changeset in webkit [144009] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

10:32 PM Changeset in webkit [144008] by noel.gordon@gmail.com

• 2 edits in trunk/Tools

GCE EWS bots failing intermittently on HTTP 502 error while updating their status
​https://bugs.webkit.org/show_bug.cgi?id=110845

Unreviewed EWS bot fix.

Switch the Queue Status Server address the EWS bots use to a more direct URL that
doesn't seem to be having problems from GCE like queues.webkit.org.

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-02-25

• Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

10:24 PM TestExpectations edited by glenn@skynav.com

editorial cleanup (diff)

10:13 PM TestExpectations edited by glenn@skynav.com

editorial cleanup (diff)

10:10 PM TestExpectations edited by glenn@skynav.com

describe how to learn which expectations files apply (diff)

10:00 PM TestExpectations edited by glenn@skynav.com

editorial cleanup; add info on generic test expectations file (diff)

9:57 PM TestExpectations edited by glenn@skynav.com

editorial cleanup (diff)

9:54 PM TestExpectations edited by glenn@skynav.com

editorial cleanup (diff)

9:53 PM Changeset in webkit [144007] by crogers@google.com

• 2 edits in trunk/Source/WebCore

AudioDestinationChromium should pass in inputDeviceId when creating WebKit::WebAudioDevice
​https://bugs.webkit.org/show_bug.cgi?id=110796

Reviewed by Kenneth Russell.

• platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestinationChromium::AudioDestinationChromium):

9:51 PM TestExpectations edited by glenn@skynav.com

clarify usage of WontFix | Skip (diff)

9:49 PM TestExpectations edited by glenn@skynav.com

ensure grammaticality (diff)

9:47 PM TestExpectations edited by glenn@skynav.com

qualify "equivalent" (diff)

9:36 PM Creating and Submitting Layout Tests and Patches edited by glenn@skynav.com

add description about using webkit-patch upload instead of svn-create-patch (diff)

9:06 PM Changeset in webkit [144006] by mark.lam@apple.com

• 25 edits
  4 deletes in trunk/Source/WebCore

Need a more robust WebSQL disk usage computation.
​https://bugs.webkit.org/show_bug.cgi?id=110805.

Reviewed by Geoffrey Garen.

• Changed DatabaseTracker::usageForOrigin() to compute the disk usage for a specified origin by fetching database sizes from the file system instead of using cached file size values.

• The OriginQuotaManager and OriginUsageRecord are no longer needed. Updated build files to reflect this.

• Removed getMaxSizeForDatabase() from DatabaseManager, DatabaseServer, and AbstractDatabaseServer since it is only needed in the backend.

• DatabaseTracker::getMaxSizeForDatabase() now calls usageForOrigin() to get the disk usage for its computation.

• The performance difference for this changes is a 1.6% degradation per additional database whose size needs to be fetched. This is a worst case estimated based on the disk-stat-speed-test.html benchmark (attached to bugzilla). The benchmark writes an average of 16 bytes per transaction. Most real-world transactions will likely write more content than that. Since disk write IO time will dominate over memory read time for fetching the file size, the degradation ratio will only reduce with larger workloads.

No layout test, but there is a quota-test.html attached to bugzilla.
The test is a webpage that can be loaded into multiple tabs to
consuming storage space. While the test is running, we can run a
"du -k; du -k *" on the database directory to verify that the total
disk usage does not far exceed the allowed quota (some small error
is expected). Without this change, each database from each tab may
exceed the quota by that same maginitude of error.

• CMakeLists.txt:
• GNUmakefile.list.am:
• Modules/webdatabase/AbstractDatabaseServer.h:
• Modules/webdatabase/Database.cpp:
• Modules/webdatabase/Database.h:
• Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::maximumSize):

• Modules/webdatabase/DatabaseManager.cpp:
• Modules/webdatabase/DatabaseManager.h:
• Modules/webdatabase/DatabaseServer.cpp:
• Modules/webdatabase/DatabaseServer.h:
• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::hasAdequateQuotaForOrigin):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::usageForOrigin):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):

• Modules/webdatabase/DatabaseTracker.h:
• Modules/webdatabase/OriginQuotaManager.cpp: Removed.
• Modules/webdatabase/OriginQuotaManager.h: Removed.
• Modules/webdatabase/OriginUsageRecord.cpp: Removed.
• Modules/webdatabase/OriginUsageRecord.h: Removed.
• Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):

• Modules/webdatabase/SQLTransactionBackendSync.cpp:

(WebCore::SQLTransactionBackendSync::executeSQL):

• Modules/webdatabase/SQLTransactionClient.cpp:
• Modules/webdatabase/SQLTransactionClient.h:
• Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:
• Target.pri:
• WebCore.gyp/WebCore.gyp:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:

8:25 PM Changeset in webkit [144005] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r143654): some jquery test asserts on 32 bit debug build
​https://bugs.webkit.org/show_bug.cgi?id=110756

Reviewed by Geoffrey Garen.

TypeOf does speculations manually, so it should mark its JSValueOperand as doing ManualOperandSpeculation.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:13 PM Changeset in webkit [144004] by benjamin@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

[JSC] Upstream iOS Stack bound checking
​https://bugs.webkit.org/show_bug.cgi?id=110813

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-02-25
Reviewed by Filip Pizlo.

On iOS, the StackBounds cannot be cached because the stack
can be in one of two threads (the web thread or the UI thread).

We simply always consider the current stack bound when testing
stack boundaries.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
(BytecodeGenerator):

• parser/Parser.cpp:

(JSC::::Parser):

• parser/Parser.h:

(JSC::Parser::canRecurse):
(Parser):

8:04 PM Changeset in webkit [144003] by Bruno de Oliveira Abinader

• 3 edits in trunk/Source/WebCore

[texmap] Rename TextureMapperGL::ClipStack::init to reset
​https://bugs.webkit.org/show_bug.cgi?id=110783

Reviewed by Noam Rosenthal.

Functions named init() are usually called inside ctor's to initialize
member variables that were unable to be assigned on an initialization
list, which is not the case, and also because reset() better reflects
the behavior (clears the clip stack and assigns a value to the initial
clip state).

No behavior changes, thus covered by existing tests.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::initializeDepthBuffer):

• platform/graphics/texmap/TextureMapperGL.h:

(ClipStack):

7:18 PM Changeset in webkit [144002] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

Add expandedToParagraph() method to WebRange
​https://bugs.webkit.org/show_bug.cgi?id=110618

Patch by Rouslan Solomakhin <​rouslan@chromium.org> on 2013-02-25
Reviewed by Adam Barth.

Add a method expandedToParagraph() to WebRange to return a copy of the
range expanded to paragraph boundaries. This method is to be used to
query the spelling context around the misspelled word under cursor.

• public/WebRange.h:

(WebRange): Added expandedToParagraph() method declaration.

• src/WebRange.cpp:

(WebKit::WebRange::expandedToParagraph): Added method to copy range, expand the copied range to paragraph boundaries, and return the resulting range.
(WebKit): Added expandedToParagraph() method definition.

7:02 PM Changeset in webkit [144001] by rniwa@webkit.org

• 2 edits in trunk/Source/WTF

Build fix attempt after r143996.

• wtf/FastMalloc.cpp:

(WTF):

6:36 PM Changeset in webkit [144000] by abarth@webkit.org

• 5 edits in trunk/Source/WebCore

Threaded HTML parser should pass fast/parser/iframe-sets-parent-to-javascript-url.html
​https://bugs.webkit.org/show_bug.cgi?id=110637

Reviewed by Eric Seidel.

With the main thread parser, we always parse the first chunk of content
returned as the result of evaluating a JavaScript URL synchronously. In
particular, if the first chunk has an inline script, we'll execute it
synchronously.

Previous to this patch, the threaded parser would always parse this
content asynchronously. It's conceivable that there could be some
content relying on the synchronous behavior, so this patch introduces
the notion of "pinning" a parser to the main thread and uses that
concept to force the result of JavaScript URLs to be parsed on the main
thread (which is probably desirable anyway because they're likely to be
quite short).

This patch fixes fast/parser/iframe-sets-parent-to-javascript-url.html
and fast/dom/javascript-url-crash-function.html with the threaded
parser with --enable-threaded-html-parser.

• dom/DocumentParser.h:

(WebCore::DocumentParser::pinToMainThread):
(DocumentParser):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore):
(WebCore::HTMLDocumentParser::pinToMainThread):

• html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

6:33 PM Changeset in webkit [143999] by jberlin@webkit.org

• 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Anders Carlsson.

• English.lproj/Localizable.strings:

6:25 PM Changeset in webkit [143998] by jamesr@google.com

• 2 edits in trunk/Source/WebKit/chromium

[chromium] WebViewImpl::m_client can be null in some unit tests, check it before calling
​https://bugs.webkit.org/show_bug.cgi?id=110834

Reviewed by Adrienne Walker.

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):

6:25 PM Changeset in webkit [143997] by roger_fong@apple.com

• 2 edits in trunk/Source/WTF

Unreviewed. Fix script to use WEBKIT_SOURCE for VS2010 property sheets instead of WEBKIT_LIBRARIES.

• WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:

6:13 PM Changeset in webkit [143996] by oliver@apple.com

• 2 edits in trunk/Source/WTF

Add cookies to FastMalloc spans
​https://bugs.webkit.org/show_bug.cgi?id=110827

Reviewed by Michael Saboff.

Add a cookie to spans, and move some of the hardening around so
that it's more useful.

• wtf/FastMalloc.cpp:

(WTF::internalEntropyValue):
(WTF::spanInitializerCookie):
(WTF::Span::initCookie):
(WTF::Span::clearCookie):
(WTF::Span::isValid):
(Span):
(WTF::NewSpan):
(WTF::DeleteSpan):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

6:10 PM Changeset in webkit [143995] by dpranke@chromium.org

• 2 edits in trunk/Tools

Forgot to delete a no-longer-needed unit test after r143980.

Unreviewed, build fix.

• Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:

(ChromiumWinTest.test_path_to_image_diff):

6:10 PM Changeset in webkit [143994] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

For JSVALUE32_64, maxOffsetRelativeToPatchedStorage() doesn't compute the maximum negative offset
​https://bugs.webkit.org/show_bug.cgi?id=110828

Reviewed by Oliver Hunt.

• runtime/JSObject.h:

(JSC::maxOffsetRelativeToPatchedStorage): Only add the OBJECT_OFFSETOF(tag) for positive offsets.
That way this function will return the offset farthest from 0 needed to access either the payload
or tag.

6:06 PM Changeset in webkit [143993] by commit-queue@webkit.org

• 5 edits
  4 adds in trunk

Flexbox should ignore firstLetter pseudo element.
​https://bugs.webkit.org/show_bug.cgi?id=105126

Patch by Xueqing Huang <​huangxueqing@baidu.com> on 2013-02-25
Reviewed by Tony Chang.

Source/WebCore:

The CSS WG decided that first-line and first-letter should not
apply to flex containers.
​http://dev.w3.org/csswg/css3-flexbox/issue-cr-2012#issue-13

tests:
css3/flexbox/flexbox-ignore-firstLetter.html
css3/flexbox/flexbox-ignore-container-firstLetter.html

• rendering/RenderBlock.cpp:

(WebCore::findFirstLetterBlock):

LayoutTests:

The CSS WG decided that first-line and first-letter should not
apply to flex containers.
​http://dev.w3.org/csswg/css3-flexbox/issues-cr-2012#issue-13

• css3/flexbox/flexbox-ignore-container-firstLetter-expected.txt: Added.
• css3/flexbox/flexbox-ignore-container-firstLetter.html: Added.
• css3/flexbox/flexbox-ignore-firstLetter-expected.txt: Added.
• css3/flexbox/flexbox-ignore-firstLetter.html: Added.
• css3/flexbox/inline-flex-crash-expected.txt:
• css3/flexbox/inline-flex-crash2-expected.txt:

5:35 PM Changeset in webkit [143992] by zmo@google.com

• 2 edits in branches/chromium/1410/Source/WebCore

Merge 142545

WEBGL_compressed_texture_s3tc extension can be enabled even when not supported
​https://bugs.webkit.org/show_bug.cgi?id=109508

Reviewed by Kenneth Russell.

• html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension): Check whether the extension support is there before returning the extension pointer.

TBR=​zmo@google.com
Review URL: ​https://codereview.chromium.org/12334083

5:24 PM Changeset in webkit [143991] by rniwa@webkit.org

• 2 edits in trunk/Tools

Build fix. run-perf-tests was reporting with revision numbers ending with \r.
Don't include \r at the end of svn info lines on Windows.

This is similar to r143839.

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.value_from_svn_info):

5:22 PM Changeset in webkit [143990] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Lots of unnecessary DidLayout notifications when scrolling zoomed page with iframes
​https://bugs.webkit.org/show_bug.cgi?id=110824

Reviewed by Tim Horton.

RenderWidget::setWidgetGeometry() compares the old and new frame rects to decide
if the geometry changed. However, it use implicit IntRect->LayoutRect promotion in
the comparison, and then roundedIntRect() in setting. Thus the code would think
that the geometry changed, even when the final assigned frame did not.

Fix by computing the new frame using roundedIntRect(), and using that to determine
whether the geometry changed.

No way to test DidLayout notifications in DRT/WTR.

• rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

5:13 PM Changeset in webkit [143989] by simonjam@chromium.org

• 10 edits
  22 moves
  3 adds in trunk

[Resource Timing] Update test suite so it can be exported to the W3C
​https://bugs.webkit.org/show_bug.cgi?id=107343

Reviewed by Tony Gentilcore.

Tools:

• Scripts/export-w3c-performance-wg-tests: Clean up output.
• Scripts/import-w3c-performance-wg-tests:

LayoutTests:

• http/tests/w3c/webperf/resources/webperftestharness.js: Removed unneeded functions and moved new ones to extension.
• http/tests/w3c/webperf/resources/webperftestharnessextension.js:

(test_resource_entries):

• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_cached.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_connection_reuse.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_dynamic_insertion.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_frame_initiator_type.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_data_url.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_ignore_failures.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_initiator_types.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_redirects.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_reparenting.html.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types-expected.txt: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types-expected.txt.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types.html: Renamed from LayoutTests/http/tests/w3c/webperf/submission/resource-timing/html/test_resource_script_types.html.
• platform/chromium/TestExpectations: Moved directories...
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/qt/TestExpectations:

5:06 PM Changeset in webkit [143988] by andersca@apple.com

• 16 edits in trunk

Source/WebKit2: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

• UIProcess/API/C/WKPage.cpp:

(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):
Add two new API key getters.

• UIProcess/API/C/WKPage.h:

Add a new callback and deprecate the old callback.

• UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
Make the pluginInformationDictionary a static member function of WebPageProxy so it
can be called from WebUIClient as well.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):
Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

• UIProcess/WebPageProxy.messages.in:

Pass along more information; the frame and page URLs.

• UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::unavailablePluginButtonClicked):
Call the new callback if it's supported.

• UIProcess/WebUIClient.h:

(WebUIClient):

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Update for API changes.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):
Ensure that the pluginspage attribute is a valid URL.

Tools: Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):

• WebKitTestRunner/TestController.h:

(TestController):

4:50 PM Changeset in webkit [143987] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

Remove browser patching mechanism for handling javascript dialogs in chromium port
​https://bugs.webkit.org/show_bug.cgi?id=110531

Patch by Ken Kania <​kkania@chromium.org> on 2013-02-25
Reviewed by Pavel Feldman.

• public/WebDevToolsAgent.h:
• src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):

4:49 PM Changeset in webkit [143986] by jpfau@apple.com

• 37 edits
  7 adds in trunk

Optionally partition cache to prevent using cache for tracking
​https://bugs.webkit.org/show_bug.cgi?id=110269

Reviewed by Maciej Stachowiak.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage

Source/WebCore:

Implement memory cache partitioning by passing the cache name through
resource requests into a new version of resourceForURL.

Test: http/tests/cache/partitioned-cache.html

• Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
• WebCore.exp.in: Export new functions for WKSI and test suite
• WebCore.xcodeproj/project.pbxproj:
• html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Retrofit for new resourceForRequest function

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource): Retrofit for new resourceForRequest function

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR): Retrofit for new resourceForRequest function

• loader/DocumentLoader.h:

(DocumentLoader):
(WebCore::DocumentLoader::recordMemoryCacheLoadForFutureClientNotification): Retrofit for new resourceForRequest function
(WebCore::DocumentLoader::takeMemoryCacheLoadsForClientNotification): Retrofit for new resourceForRequest function

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache): Retrofit for new resourceForRequest function
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Retrofit for new resourceForRequest function

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Retrofit for new resourceForRequest function

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::~CachedResource):

• loader/cache/CachedResource.h: Retrofit for new resourceForRequest function

(CachedResource):
(WebCore::CachedResource::cachePartition):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::requestResource): Retrofit for new resourceForRequest function
(WebCore::CachedResourceLoader::loadResource): Retrofit for new resourceForRequest function

• loader/cache/MemoryCache.cpp:

(WebCore):
(WebCore::partitionName): Add function for determining absolute partition name
(WebCore::MemoryCache::add): Retrofit for partition mapping
(WebCore::MemoryCache::revalidationSucceeded): Retrofit for partition mapping
(WebCore::MemoryCache::resourceForURL): Call into new resourceForRequest
(WebCore::MemoryCache::resourceForRequest): Retrofit for partition mapping
(WebCore::MemoryCache::evict): Retrofit for partition mapping
(WebCore::MemoryCache::removeResourcesWithOrigin): Retrofit for partition mapping
(WebCore::MemoryCache::getOriginsWithCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeUrlFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCache): Retrofit for partition mapping
(WebCore::MemoryCache::removeRequestFromCacheImpl): Retrofit for partition mapping
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Add function for calling removeRequestFromCacheImpl that takes a CrossThreadResourceRequestData
(WebCore::MemoryCache::getStatistics): Retrofit for partition mapping
(WebCore::MemoryCache::setDisabled): Retrofit for partition mapping

• loader/cache/MemoryCache.h:

(MemoryCache):

• page/SecurityOrigin.cpp:

(WebCore):
(WebCore::SecurityOrigin::cachePartition): Add function for determining the cache partition name

• page/SecurityOrigin.h:

(SecurityOrigin):

• platform/PublicSuffix.h: Added.

(WebCore):

• platform/mac/PublicSuffixMac.mm: Added.

(WebCore):
(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:
• platform/network/cf/ResourceRequest.h:

(ResourceRequest):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition):
(CrossThreadResourceRequestData):

• platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doPlatformCopyData): Pass through cache partition name
(WebCore):
(WebCore::ResourceRequest::doPlatformAdopt): Pass through cache partition name

• platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest): Pass through cache partition name
(WebCore::ResourceRequest::doUpdatePlatformRequest): Pass through cache partition name

Source/WebKit/mac:

Update WKSI bindings and add feature defines.

• Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Update WKSI bindings and add feature defines.

• Configurations/FeatureDefines.xcconfig: Add defines for cache partitioning and public suffix list usage
• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Tools:

Add test suite for public suffix functions on Mac.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.

(TestWebKitAPI):
(TestWebKitAPI::TEST_F):

WebKitLibraries:

Update WKSI bindings.

• WebKitSystemInterface.h:
• libWebKitSystemInterfaceLion.a:
• libWebKitSystemInterfaceMountainLion.a:

LayoutTests:

Added tests for ensuring the cache partitioning functions

• http/tests/cache/partitioned-cache-expected.txt: Added.
• http/tests/cache/partitioned-cache.html: Added.
• http/tests/cache/resources/echo-cookie.cgi: Added.
• http/tests/cache/resources/partitioned-cache-loader.html: Added.

4:44 PM Changeset in webkit [143985] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[chromium] Plumb WebViewImpl's compositor scheduling suppression out to WebWidgetClient
​https://bugs.webkit.org/show_bug.cgi?id=110640

Patch by James Robinson <​jamesr@chromium.org> on 2013-02-25
Reviewed by Adrienne Walker.

This plumbs the WebViewImpl::m_suppressInvalidations logic out to the WebWidgetClient so
it can be implemented by the embedder. The existing logic is left in place for now,
once the embedder side has landed WebViewImpl will be purely a pass-through.

• public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::suppressCompositorScheduling):

• src/WebViewImpl.cpp:

(WebKit::WebViewImpl::suppressInvalidations):
(WebKit::WebViewImpl::setRootGraphicsLayer):

4:21 PM Changeset in webkit [143984] by jer.noble@apple.com

• 10 edits in trunk/Source

Normalize ENABLE_ENCRYPTED_MEDIA definitions across all FeatureDefines files.
​https://bugs.webkit.org/show_bug.cgi?id=110806

Source/WebCore:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

• Configurations/FeatureDefines.xcconfig:

Fix some build errors which occurred when both ENCRYPTED_MEDIA and
ENCRYPTED_MEDIA_V2 were enabled:

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitGenerateKeyRequest):
(WebCore::HTMLMediaElement::webkitAddKey):

• page/DOMWindow.idl:

Source/WebKit/mac:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

Reviewed by Alexey Proskuryakov.

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Alexey Proskuryakov.

Ensure both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 are enabled on macosx_1090.

• wtf/FeatureDefines.h:

4:12 PM Changeset in webkit [143983] by abarth@webkit.org

• 3 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=110784

Reviewed by Eric Seidel.

This patch reverts ​http://trac.webkit.org/changeset/143014 to see if
that's the cause of the PLT regression. If it's not the cause, I'll
roll it back in.

• dom/Element.cpp:

(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::ElementData::addAttribute):
(WebCore::ElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):

• dom/Element.h:

(ElementData):
(UniqueElementData):
(WebCore::ElementData::mutableAttributeVector):
(WebCore):
(WebCore::ElementData::immutableAttributeArray):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):

3:48 PM Changeset in webkit [143982] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Full screen mode should not exit when application resigns active state.
​https://bugs.webkit.org/show_bug.cgi?id=106129

Reviewed by Darin Adler.

Now that full screen windows get their own full screen space, there is no reason to exit full
screen mode when the application resigns active state. Instead, the windowserver will bring the
space containing the newly active application to the foreground. The user can then swipe back
to the full screen space (or use Mission Control) to get back to the full screen window.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController windowDidLoad]): Remove the applicationDidResignActive: notification from WKFullScreenWindowController.

3:39 PM Changeset in webkit [143981] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Safari shows empty window and paints webpage in full-screen background
​https://bugs.webkit.org/show_bug.cgi?id=103712

Reviewed by Darin Adler.

When canceling full screen mode due to a provisional load, exit normally instead of closing the
full screen window controller. Additionally, to ensure full screen is cancelled when the enclosing
frame around a full screen iframe is navigated, check to see if the navigating document contains
a full screen element, rather than checking whether the document itself is full screen.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

3:36 PM Changeset in webkit [143980] by dpranke@chromium.org

• 2 edits in trunk/Tools

nrwt: reenable multiple http shards on chromium win
​https://bugs.webkit.org/show_bug.cgi?id=110814

Reviewed by Tony Chang.

The underlying bug in DumpRenderTree that was causing us to look for a
pac file and timeout under load was fixed a while ago.

• Scripts/webkitpy/layout_tests/port/chromium_win.py:

(ChromiumWinPort.relative_test_filename):

3:32 PM Changeset in webkit [143979] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Page::m_isInWindow is uninitialized
​https://bugs.webkit.org/show_bug.cgi?id=110807

Reviewed by Simon Fraser.

Ideally m_isInWindow and m_isOnscreen would default to false, and be flipped to true
when the Page is put in-window or on-screen. However, only the Mac port seems to ever
call setIsInWindow/didMoveOnscreen. So, we have to default to true and flip it to false
immediately after construction on Mac.

This is just matching the behaviour of the existing m_isOnscreen.

• page/Page.cpp:

(WebCore::Page::Page): Initialize m_isInWindow to true.

3:02 PM Changeset in webkit [143978] by dpranke@chromium.org

• 2 edits in trunk/Tools

Make ninja the default w/ build-webkit --chromium on windows.
​https://bugs.webkit.org/show_bug.cgi?id=110731

Unreviewed - TBR'ing thakis :).

• Scripts/update-webkit-chromium:

2:58 PM Changeset in webkit [143977] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Fix build.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

2:38 PM Changeset in webkit [143976] by andersca@apple.com

• 13 edits in trunk

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

• UIProcess/API/C/WKPage.h:
• UIProcess/WebLoaderClient.cpp:

(WebKit::pluginInformationDictionary):
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):

• UIProcess/WebLoaderClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didFailToInitializePlugin):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

2:27 PM Changeset in webkit [143975] by eric@webkit.org

• 8 edits
  18 copies
  11 moves
  28 adds
  44 deletes in trunk/LayoutTests

Move html5lib/run-test* into html5lib/generated in preparation for generating these harnesses
​https://bugs.webkit.org/show_bug.cgi?id=110795

Reviewed by Ojan Vafai.

• html5lib/generated/run-template-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-template.html: Added.
• html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/html5lib/run-test7-expected.txt.
• html5lib/generated/run-tests1.html: Added.
• html5lib/generated/run-tests10-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests10.html: Added.
• html5lib/generated/run-tests11-expected.txt: Renamed from LayoutTests/html5lib/run-test11-expected.txt.
• html5lib/generated/run-tests11.html: Added.
• html5lib/generated/run-tests12-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests12.html: Added.
• html5lib/generated/run-tests14-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests14.html: Added.
• html5lib/generated/run-tests15-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests15.html: Added.
• html5lib/generated/run-tests16-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests16.html: Added.
• html5lib/generated/run-tests17-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests17.html: Added.
• html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/html5lib/run-test18-expected.txt.
• html5lib/generated/run-tests18.html: Added.
• html5lib/generated/run-tests19-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests19.html: Added.
• html5lib/generated/run-tests2-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests2.html: Added.
• html5lib/generated/run-tests20-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests20.html: Added.
• html5lib/generated/run-tests21-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests21.html: Added.
• html5lib/generated/run-tests22-expected.txt: Renamed from LayoutTests/html5lib/run-test10-expected.txt.
• html5lib/generated/run-tests22.html: Added.
• html5lib/generated/run-tests23-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests23.html: Added.
• html5lib/generated/run-tests24-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests24.html: Added.
• html5lib/generated/run-tests25-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests25.html: Added.
• html5lib/generated/run-tests26-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests26.html: Added.
• html5lib/generated/run-tests3-expected.txt: Renamed from LayoutTests/html5lib/run-test14-expected.txt.
• html5lib/generated/run-tests3.html: Added.
• html5lib/generated/run-tests4-expected.txt: Renamed from LayoutTests/html5lib/run-test12-expected.txt.
• html5lib/generated/run-tests4.html: Added.
• html5lib/generated/run-tests5-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests5.html: Added.
• html5lib/generated/run-tests6-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests6.html: Added.
• html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/html5lib/run-test1-expected.txt.
• html5lib/generated/run-tests7.html: Added.
• html5lib/generated/run-tests8-expected.txt: Copied from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests8.html: Added.
• html5lib/generated/run-tests9-expected.txt: Renamed from LayoutTests/html5lib/run-template-expected.txt.
• html5lib/generated/run-tests9.html: Added.
• html5lib/run-template.html: Removed.
• html5lib/run-test1.html: Removed.
• html5lib/run-test10.html: Removed.
• html5lib/run-test11.html: Removed.
• html5lib/run-test12.html: Removed.
• html5lib/run-test14.html: Removed.
• html5lib/run-test15-expected.txt: Removed.
• html5lib/run-test15.html: Removed.
• html5lib/run-test16-expected.txt: Removed.
• html5lib/run-test16.html: Removed.
• html5lib/run-test17-expected.txt: Removed.
• html5lib/run-test17.html: Removed.
• html5lib/run-test18.html: Removed.
• html5lib/run-test19-expected.txt: Removed.
• html5lib/run-test19.html: Removed.
• html5lib/run-test2-expected.txt: Removed.
• html5lib/run-test2.html: Removed.
• html5lib/run-test20-expected.txt: Removed.
• html5lib/run-test20.html: Removed.
• html5lib/run-test21-expected.txt: Removed.
• html5lib/run-test21.html: Removed.
• html5lib/run-test22-expected.txt: Removed.
• html5lib/run-test22.html: Removed.
• html5lib/run-test23-expected.txt: Removed.
• html5lib/run-test23.html: Removed.
• html5lib/run-test24-expected.txt: Removed.
• html5lib/run-test24.html: Removed.
• html5lib/run-test25-expected.txt: Removed.
• html5lib/run-test25.html: Removed.
• html5lib/run-test26-expected.txt: Removed.
• html5lib/run-test26.html: Removed.
• html5lib/run-test3-expected.txt: Removed.
• html5lib/run-test3.html: Removed.
• html5lib/run-test4-expected.txt: Removed.
• html5lib/run-test4.html: Removed.
• html5lib/run-test5-expected.txt: Removed.
• html5lib/run-test5.html: Removed.
• html5lib/run-test6-expected.txt: Removed.
• html5lib/run-test6.html: Removed.
• html5lib/run-test7.html: Removed.
• html5lib/run-test8-expected.txt: Removed.
• html5lib/run-test8.html: Removed.
• html5lib/run-test9-expected.txt: Removed.
• html5lib/run-test9.html: Removed.
• platform/chromium/TestExpectations:
• platform/chromium/html5lib/generated/run-tests1-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test7-expected.txt.
• platform/chromium/html5lib/generated/run-tests18-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test18-expected.txt.
• platform/chromium/html5lib/generated/run-tests7-expected.txt: Renamed from LayoutTests/platform/chromium/html5lib/run-test1-expected.txt.
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:

2:21 PM Changeset in webkit [143974] by haraken@chromium.org

• 3 edits in trunk/Source/WebCore

Unreviewed build fix after r143965.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedConstructorCallback):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor):

2:15 PM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

2:12 PM Changeset in webkit [143973] by kov@webkit.org

• 2 edits in trunk/Source/WebCore

Build fix for gtk2-based library.

Reviewed by Martin Robinson.

• platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h

include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.

2:06 PM Changeset in webkit [143972] by commit-queue@webkit.org

• 8 edits
  2 deletes in trunk/Source

Unreviewed, rolling out r143936.
​http://trac.webkit.org/changeset/143936
​https://bugs.webkit.org/show_bug.cgi?id=110789

Causes webkit_unit_tests failures on android dbg (Requested by
vollick on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-25

Source/WebCore:

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::decodingHalted):
(WebCore):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):

• platform/image-decoders/gif/GIFImageDecoder.h:

(GIFImageDecoder):

• platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::doLZW):
(GIFImageReader::read):

• platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::globalColormapSize):

Source/WebKit/chromium:

• WebKit.gyp:
• WebKit.gypi:
• tests/GIFImageDecoderTest.cpp: Removed.
• tests/data/broken.gif: Removed.

1:48 PM Changeset in webkit [143971] by Lucas Forschler

• 2 edits in tags/Safari-537.31.9/Source/WebKit2

Merged r143829. <rdar://problem/13236883>

1:47 PM Changeset in webkit [143970] by roger_fong@apple.com

• 4 edits in trunk/Source

Unreviewed. VS2010 solution build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
• JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:

1:44 PM Changeset in webkit [143969] by Lucas Forschler

• 4 edits in tags/Safari-537.31.9/Source

Versioning.

1:40 PM Changeset in webkit [143968] by Lucas Forschler

• 1 copy in tags/Safari-537.31.9

New Tag.

1:31 PM Changeset in webkit [143967] by haraken@chromium.org

• 11 edits in trunk/Source/WebCore

[V8] Generate a wrapper function for method callbacks
​https://bugs.webkit.org/show_bug.cgi?id=110769

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for xxxMethod(), like this:

For non-custom methods
void xxxMethodCallback(...) {

xxxMethod(...);

}

For custom methods
void xxxMethodCallback(...) {

return xxxMethodCustom(...);

}

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethodCallback):
(Float64ArrayV8Internal):
(WebCore::Float64ArrayV8Internal::setMethodCallback):
(WebCore):
(WebCore::ConfigureV8Float64ArrayTemplate):

• bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethodCallback):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::postMessageMethodCallback):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

• bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::TestCustomNamedGetterV8Internal::anotherFunctionMethodCallback):
(TestCustomNamedGetterV8Internal):
(WebCore):

• bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::itemMethodCallback):
(TestEventTargetV8Internal):
(WebCore::TestEventTargetV8Internal::addEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerMethodCallback):
(WebCore::TestEventTargetV8Internal::dispatchEventMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestEventTargetTemplate):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalMethod1MethodCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalMethod2MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod3MethodCallback):
(WebCore::TestInterfaceV8Internal::supplementalMethod4MethodCallback):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):

• bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::TestMediaQueryListListenerV8Internal::methodMethodCallback):
(TestMediaQueryListListenerV8Internal):
(WebCore):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::voidMethodMethodCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::longMethodMethodCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::objMethodMethod):
(WebCore::TestObjV8Internal::objMethodMethodCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestObjV8Internal::methodReturningSequenceMethodCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethodCallback):
(WebCore::TestObjV8Internal::serializedValueMethodCallback):
(WebCore::TestObjV8Internal::optionsObjectMethodCallback):
(WebCore::TestObjV8Internal::methodWithExceptionMethodCallback):
(WebCore::TestObjV8Internal::customMethodMethodCallback):
(WebCore::TestObjV8Internal::customMethodWithArgsMethodCallback):
(WebCore::TestObjV8Internal::addEventListenerMethodCallback):
(WebCore::TestObjV8Internal::removeEventListenerMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateVoidExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionMethodCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesMethodCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonOptionalArgAndTwoOptionalArgsMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsUndefinedMethodCallback):
(WebCore::TestObjV8Internal::methodWithOptionalStringIsNullStringMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithNonCallbackArgAndCallbackArgMethodCallback):
(WebCore::TestObjV8Internal::methodWithCallbackAndOptionalArgMethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod1MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod2MethodCallback):
(WebCore::TestObjV8Internal::conditionalMethod3MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodMethodCallback):
(WebCore::TestObjV8Internal::classMethodWithOptionalMethodCallback):
(WebCore::TestObjV8Internal::classMethod2MethodCallback):
(WebCore::TestObjV8Internal::overloadedMethod1MethodCallback):
(WebCore::TestObjV8Internal::classMethodWithClampMethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeMethod2MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod1MethodCallback):
(WebCore::TestObjV8Internal::enabledPerContextMethod2MethodCallback):
(WebCore::TestObjV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestObjV8Internal::domStringListFunctionMethodCallback):
(WebCore::TestObjV8Internal::getSVGDocumentMethodCallback):
(WebCore::TestObjV8Internal::convert1MethodCallback):
(WebCore::TestObjV8Internal::convert2MethodCallback):
(WebCore::TestObjV8Internal::convert4MethodCallback):
(WebCore::TestObjV8Internal::convert5MethodCallback):
(WebCore::TestObjV8Internal::mutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestObjV8Internal::orangeMethodCallback):
(WebCore::TestObjV8Internal::strictFunctionMethodCallback):
(WebCore::TestObjV8Internal::variadicStringMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicDoubleMethodMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListMethodCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListMethodCallback):
(WebCore):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethodCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::multiTransferListMethodCallback):
(WebCore::TestTypedefsV8Internal::setShadowMethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithSequenceArgMethodCallback):
(WebCore::TestTypedefsV8Internal::nullableArrayArgMethodCallback):
(WebCore::TestTypedefsV8Internal::funcWithClampMethodCallback):
(WebCore::TestTypedefsV8Internal::immutablePointFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunctionMethodCallback):
(WebCore::TestTypedefsV8Internal::stringArrayFunction2MethodCallback):
(WebCore::TestTypedefsV8Internal::methodWithExceptionMethodCallback):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):

1:29 PM Changeset in webkit [143966] by pdr@google.com

• 2 edits in trunk/LayoutTests

Remove two stale entries from TestExpectations

Unreviewed patch of test expectations.

• platform/chromium/TestExpectations:

1:28 PM Changeset in webkit [143965] by haraken@chromium.org

• 11 edits in trunk/Source/WebCore

[V8] Generate a wrapper method for constructor callbacks
​https://bugs.webkit.org/show_bug.cgi?id=110765

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros
into DOM bindings. This patch introduces an indirection
function for constructor(), like this:

For non-custom constructors
void constructorCallback(...) {

return constructor(...);

}

For custom constructors
void constructorCallback(...) {

return constructorCustom(...);

}

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateConstructor):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateNamedConstructor):
(GenerateConstructorHeader):
(GenerateImplementation):

• bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::constructor):
(Float64ArrayV8Internal):
(WebCore::V8Float64Array::constructorCallback):

• bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::constructor):
(WebCore):
(WebCore::V8TestEventConstructor::constructorCallback):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::constructor):
(TestInterfaceV8Internal):
(WebCore::V8TestInterface::constructorCallback):

• bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructorCallback):

• bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::TestNodeV8Internal::constructor):
(TestNodeV8Internal):
(WebCore::V8TestNode::constructorCallback):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::constructor):
(TestObjV8Internal):
(WebCore::V8TestObj::constructorCallback):

• bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor4):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore):
(WebCore::V8TestOverloadedConstructors::constructorCallback):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::constructor):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::constructor):
(TestTypedefsV8Internal):
(WebCore::V8TestTypedefs::constructorCallback):

1:26 PM Changeset in webkit [143964] by haraken@chromium.org

• 6 edits in trunk/Source/WebCore

[V8] Generate xxxAttrSetterCallback()
​https://bugs.webkit.org/show_bug.cgi?id=110726

Reviewed by Adam Barth.

This is one of steps to insert TRACE_EVENT_STATE() macros into DOM bindings.
This patch introduces an indirection function for xxxAttrSetter(), like this:

For non-custom setters
void xxxAttrSetterCallback(...) {

xxxAttrSetter(...);

}

For custom setters.
void xxxAttrSetterCallback(...) {

return xxxAttrSetterCustom(...);

}

No tests. No change in behavior.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):

• bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallback):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallback):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallback):
(WebCore):

• bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::createAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallback):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetterCallback):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetterCallback):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallback):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallback):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallback):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallback):
(WebCore::TestObjV8Internal::idAttrSetterCallback):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):

• bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallback):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallback):
(WebCore):

• bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallback):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallback):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallback):
(WebCore):

1:24 PM Changeset in webkit [143963] by pdr@google.com

• 16 edits in trunk/LayoutTests

Rebaseline 3 svg/as-image/ tests

Unreviewed rebaseline of test expectations.

• platform/chromium-linux/svg/as-image/animated-svg-as-image-expected.png:
• platform/chromium-linux/svg/as-image/animated-svg-as-image-same-image-expected.png:
• platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
• platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-expected.png:
• platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-same-image-expected.png:
• platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
• platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-expected.png:
• platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-same-image-expected.png:
• platform/chromium-mac-snowleopard/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
• platform/chromium-mac/svg/as-image/animated-svg-as-image-expected.png:
• platform/chromium-mac/svg/as-image/animated-svg-as-image-same-image-expected.png:
• platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-1-expected.png:
• platform/chromium-win/svg/as-image/animated-svg-as-image-expected.png:
• platform/chromium-win/svg/as-image/animated-svg-as-image-same-image-expected.png:
• platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-1-expected.png:

1:16 PM Changeset in webkit [143962] by timothy_horton@apple.com

• 8 edits in trunk/Source/WebKit2

PDFPlugin: Tab between text annotations
​https://bugs.webkit.org/show_bug.cgi?id=106539
<rdar://problem/12751789>

Reviewed by Darin Adler.

Use [PDFLayerController activateNextAnnotation:] to advance focus when the tab key is hit while inside a PDF form.

Also, a drive-by fix to make the lifetime of PDFPluginAnnotationEventListener's m_annotation pointer more explicit.

• WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add activateNextAnnotation: SPI.
• WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin): Add focus(Next|Previous)Annotation.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::focusNextAnnotation): Ask PDFLayerController to focus the next annotation.
(WebKit::PDFPlugin::focusPreviousAnnotation): Ask PDFLayerController to focus the next annotation.

• WebProcess/Plugins/PDF/PDFPluginAnnotation.h: Drive-by, initialize m_parent to 0.

(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::setAnnotation): Added.

• WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach): Use eventNames() instead of string literals.
(WebKit::PDFPluginAnnotation::~PDFPluginAnnotation): Clear the event listener's reference to its annotation.
(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent): Null-check the event listener's annotation.

• WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:

(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotation): Create our PDFPluginTextAnnotationEventListener.
(PDFPluginTextAnnotationEventListener): Added an event listener (for keydown events in form fields).
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::create):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::setTextAnnotation):
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::PDFPluginTextAnnotationEventListener):

• WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation): Unregister our keydown event listener.
(WebKit::PDFPluginTextAnnotation::createAnnotationElement): Register our keydown event listener.
(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener::handleEvent): Ask PDFPlugin to focus
the next/previous annotation when the tab key is pressed (Shift-Tab goes backwards).

1:13 PM Changeset in webkit [143961] by abarth@webkit.org

• 2 edits in trunk/Source/WebCore

Build fix for Debug.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::startBackgroundParser):

12:58 PM Changeset in webkit [143960] by abarth@webkit.org

• 6 edits in trunk/Source/WebCore

6% regression in intl1 page cycler on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=110784

Reviewed by Eric Seidel.

This patch attempts to heal the regression by reverting all the changes
to the preload scanner up to (and including)
​http://trac.webkit.org/changeset/143020/.

• html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::resumeFrom):
(WebCore::BackgroundHTMLParser::pumpTokenizer):
(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

• html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::scan):
(WebCore::CSSPreloadScanner::emitRule):

• html/parser/CSSPreloadScanner.h:

(CSSPreloadScanner):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::isStartTag):
(WebCore):
(WebCore::isStartOrEndTag):
(WebCore::TokenPreloadScanner::identifierFor):
(WebCore::TokenPreloadScanner::inititatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::processPossibleTemplateTag):
(WebCore::TokenPreloadScanner::processPossibleStyleTag):
(WebCore::TokenPreloadScanner::processPossibleBaseTag):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):

• html/parser/HTMLPreloadScanner.h:

(TokenPreloadScanner):

12:54 PM Changeset in webkit [143959] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

<rdar://problem/12976385> Remove rule to silence attempts to create the ~/Library/Caches/com.apple.WebKit2.WebProcessService directory

Reviewed by Anders Carlsson.

• WebProcess/com.apple.WebProcess.sb.in: Remove the obsolete rule. We no longer have a "WebProcessService".

12:48 PM Changeset in webkit [143958] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

DFG::Edge should have more bits for UseKind, and DFG::Allocator should be simpler
​https://bugs.webkit.org/show_bug.cgi?id=110722

Reviewed by Oliver Hunt.

This rolls out the DFG::Allocator part of ​http://trac.webkit.org/changeset/143654,
and changes Edge to have more room for UseKinds and possibly other things.

This is performance-neutral on both 32-bit and 64-bit. It reduces the size of
DFG::Node on 64-bit (by virtue of getting rid of the 16-byte alignment of Node)
and increases it slightly on 32-bit (by 4 bytes total - 16-byte alignment led to
80 bytes, but the base size of Node plus the 12 bytes of new m_encodedWords in
Edge gets 84 bytes). But, it will mean that we don't have to increase Node by
another 16 bytes if we ever want to add more UseKinds or other things to Edge.

• dfg/DFGAllocator.h:

(DFG):
(Allocator):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::::Allocator):
(JSC::DFG::::~Allocator):
(JSC::DFG::::allocate):
(JSC::DFG::::free):
(JSC::DFG::::freeAll):
(JSC::DFG::::reset):
(JSC::DFG::::indexOf):
(JSC::DFG::::allocatorOf):
(JSC::DFG::::bumpAllocate):
(JSC::DFG::::freeListAllocate):
(JSC::DFG::::allocateSlow):
(JSC::DFG::::freeRegionsStartingAt):
(JSC::DFG::::startBumpingIn):

• dfg/DFGEdge.h:

(JSC::DFG::Edge::Edge):
(Edge):
(JSC::DFG::Edge::node):
(JSC::DFG::Edge::setNode):
(JSC::DFG::Edge::useKindUnchecked):
(JSC::DFG::Edge::setUseKind):
(JSC::DFG::Edge::operator==):
(JSC::DFG::Edge::operator!=):
(JSC::DFG::Edge::makeWord):

• dfg/DFGNodeAllocator.h:

(DFG):

12:27 PM Changeset in webkit [143957] by pdr@google.com

• 2 edits
  2 copies in branches/chromium/1410

Merge 143640

Stop starting animations when leaving a page
​https://bugs.webkit.org/show_bug.cgi?id=110257

Reviewed by Stephen Chenney.

Source/WebCore:

SVGImage::resetAnimation() incorrectly started animations which could cause a crash
when leaving the page. This patch fixes resetAnimation to only stop the animation,
similar to BitmapImage::resetAnimation().

Additionally, this patch removes an unneeded call to Document::updateStyleForAllDocuments()
that was present in the animation loop. This makes the animation code more resistant to
similar bugs in the future.

Both of these changes are functionally covered with existing tests.

Test: svg/animations/reset-animation-crash.html

• svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::updateAnimations):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::resetAnimation):

LayoutTests:

• svg/animations/reset-animation-crash-expected.html: Added.
• svg/animations/reset-animation-crash.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/12310113

12:23 PM Changeset in webkit [143956] by pdr@google.com

• 12 edits
  6 copies in branches/chromium/1410

Merge 142765

Replace SVG bitmap cache with directly-rendered SVG
​https://bugs.webkit.org/show_bug.cgi?id=106159

Reviewed by Tim Horton.

Source/WebCore:

This patch removes the caching of SVG bitmaps so SVG images are rendered directly. This
enables WebKit to pass the IE Chalkboard demo in 10s on a Z620:
​http://ie.microsoft.com/testdrive/Performance/Chalkboard/

On a simple scaled SVG benchmark similar to the IE10 Chalkboard demo
(​http://philbit.com/SvgImagePerformance/viewport.html):

without patch: ~20FPS
with patch: ~55FPS

The bitmap SVG image cache had several shortcomings:

• The bitmap cache prevented viewport rendering. (WK104693)
• Bitmap memory usage was high. (WK106484)
• Caching animating images was expensive.

This change removes almost all of the SVGImageCache implementation, replacing it with
directly-rendered SVG. Instead of caching bitmaps, an SVGImageForContainer is cached which
is a thin wrapper around an SVG image with the associated container size and scale.
When rendering patterns (e.g., tiled backgrounds), a temporary bitmap is used for
performance. This change also removes the redraw timer of the old cache, instead relying
on the SVG image to notify clients if the image changes (e.g., during animations).

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

Tests: svg/as-image/svg-image-scaled.html

svg/as-image/svg-image-viewbox.html

• CMakeLists.txt:
• GNUmakefile.list.am:
• Target.pri:
• WebCore.gypi:
• WebCore.vcproj/WebCore.vcproj:
• WebCore.xcodeproj/project.pbxproj:
• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::lookupOrCreateImageForRenderer):
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::changedInRect):

SVG images are no longer special-cased here. When the SVG image changes, users are
notified through this function, and users can then request their content to be redrawn.

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::drawForContainer):

drawForContainer lays out the SVG content for a specific container size and renders it.
The logic is fairly straightforward but a note about the scales and zooms here:

the destination rect parameter is zoomed but not scaled
the source rect parameter is zoomed but not scaled
the context is scaled but not zoomed

SVGImage::draw(...) only accepts a source and destination rect but does not consider
scale or zoom. Therefore, drawForContainer removes the zoom component from the source
so SVGImage::draw(...) will draw from the pre-zoom source to the post-zoom destination.

(WebCore::SVGImage::drawPatternForContainer):

For performance, drawPatternForContainer renders the SVG content onto a bitmap, then
has the bitmap image draw the pattern. This is necessary because drawPattern is used
for tiling.

(WebCore):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
(WebCore::SVGImage::resetAnimation):
(WebCore::SVGImage::reportMemoryUsage):

• svg/graphics/SVGImage.h:

(WebCore):
(SVGImage):

• svg/graphics/SVGImageCache.cpp:

Instead of storing a SizeAndScales values for each renderer, a SVGImageForContainer
is stored which is just a thin wrapper around an SVG image that contains container
sizing information. By combining the image and size information, the two maps of
SVGImageCache have been merged into one.

To make this patch easier to review, SVGImageCache still exists and works similar to
how it did before the patch. Now, SVGImageCache simply stores the SVGImageForContainers.
In a followup patch it will be removed.

Note: the redraw timer of SVGImageCache has been removed because animation
invalidation is now properly propagated back to the image clients.

(WebCore):
(WebCore::SVGImageCache::SVGImageCache):
(WebCore::SVGImageCache::~SVGImageCache):
(WebCore::SVGImageCache::removeClientFromCache):
(WebCore::SVGImageCache::setContainerSizeForRenderer):
(WebCore::SVGImageCache::imageSizeForRenderer):

Previously, this function returned the scaled image size which was incorrect. The image
size is used by clients such as GraphicsContext2D to determine the source size
for drawing the image. draw() accepts zoomed but not scaled values, so this has been
changed.

(WebCore::SVGImageCache::imageForRenderer):

A FIXME has been added here to not set the scale on every lookup. This can be improved
by setting the page scale factor in setContainerSizeForRenderer() in a future patch.

• svg/graphics/SVGImageCache.h:

(WebCore):
(SVGImageCache):

• svg/graphics/SVGImageForContainer.cpp: Added.

(WebCore):

SVGImageForContainer is a thin wrapper around an SVG image. The lifetime of the
SVGImage will be longer than the image cache.

(WebCore::SVGImageForContainer::size):

This is the only logic in SVGImageForContainer. The size returned needs to be zoomed
but not scaled because it is used (e.g., by RenderImage) to pass back into draw() which
takes zoomed but not scaled values.

(WebCore::SVGImageForContainer::draw):
(WebCore::SVGImageForContainer::drawPattern):

• svg/graphics/SVGImageForContainer.h: Added.

(WebCore):
(SVGImageForContainer):

In a future patch SVGImageForContainer can be made immutable but without a refactoring
for not setting the page scale factor in SVGImageCache::lookupOrCreateImageForRenderer,
setters are needed.

(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::containerSize):
(WebCore::SVGImageForContainer::pageScale):
(WebCore::SVGImageForContainer::zoom):
(WebCore::SVGImageForContainer::setSize):
(WebCore::SVGImageForContainer::setZoom):
(WebCore::SVGImageForContainer::setPageScale):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(WebCore::SVGImageForContainer::destroyDecodedData):
(WebCore::SVGImageForContainer::decodedSize):

LayoutTests:

This patch fixes two existing bugs (WK99481 and WK104189) that were due to caching bitmaps
at a fixed size. A test has been added for each of these bugs.

• platform/chromium/TestExpectations:
• svg/as-image/svg-image-scaled-expected.html: Added.
• svg/as-image/svg-image-scaled.html: Added.
• svg/as-image/svg-image-viewbox-expected.html: Added.
• svg/as-image/svg-image-viewbox.html: Added.

TBR=​pdr@google.com
Review URL: ​https://codereview.chromium.org/12319101

12:23 PM Changeset in webkit [143955] by fpizlo@apple.com

• 14 edits in trunk/Source/JavaScriptCore

The DFG special case checks for isCreatedThisArgument are fragile
​https://bugs.webkit.org/show_bug.cgi?id=110535

Reviewed by Oliver Hunt.

There may be many situations in which we want to force a variable to never be
unboxed. Capturing is one such case, and the created this argument is another.
Previously all code that dealt with this issue had to query both scenarios.

Now DFG::VariableAccessData knows these things. You just have to ask
VariableAccessData for whether a variable should be unboxed. Anyone wishing to
force a variable to never be unboxed just tells VariableAccessData.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):

• dfg/DFGCFGSimplificationPhase.cpp:

(CFGSimplificationPhase):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:

(Graph):

• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

• dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeIsCaptured):
(JSC::DFG::VariableAccessData::mergeShouldNeverUnbox):
(VariableAccessData):
(JSC::DFG::VariableAccessData::shouldNeverUnbox):
(JSC::DFG::VariableAccessData::shouldUnboxIfPossible):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):

11:50 AM FeatureFlags edited by Laszlo Gombos

CSS_REGIONS - see r88148 (diff)

11:36 AM Changeset in webkit [143954] by mark.lam@apple.com

• 2 edits in trunk/Source/WebCore

Changed DatabaseTracker::getMaxSizeForDatabase() to return the previous
database size instead of 0 when the quota limit has been reached.
​https://bugs.webkit.org/show_bug.cgi?id=110557.

Reviewed by Geoffrey Garen.

Testing of concurrent multi-process consumption of database quota shows that
returning a value of 0 when the quota is exceeded still allows some databases
to run away with unbounded growth. However, if getMaxSizeForDatabase() returns
the existing database size, the underlying sqlite3 database will successfully
reject new growth.

The value returned by DatabaseTracker::getMaxSizeForDatabase() is used to set
the SQLite3 database size using a sql command "PRAGMA max_page_count = <size>".
The SQLite3 documentation on this pragma says, "The maximum page count cannot
be reduced below the current database size."

It is undefined what setting it to a reduced size will do. So, we're changing
getMaxSizeForDatabase() to return the existing size instead.

No new tests.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::getMaxSizeForDatabase):

11:29 AM Changeset in webkit [143953] by thakis@chromium.org

• 2 edits in trunk/Tools

Fix python unit tests after yoli's email address update in ​http://trac.webkit.org/changeset/143922
​https://bugs.webkit.org/show_bug.cgi?id=110775

Unreviewed, basically a rebaseline.

• Scripts/webkitpy/common/config/watchlist:

11:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

11:27 AM Changeset in webkit [143952] by Carlos Garcia Campos

• 3 edits
  3 adds in releases/WebKitGTK/webkit-2.0

Merge r143931 - [soup] "Too many redirects" error loading chat in plus.google.com
​https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

• http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
• http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
• http/tests/cookies/set-cookie-on-redirect.html: Added.

11:23 AM Changeset in webkit [143951] by thakis@chromium.org

• 2 edits in trunk/Tools

[chromium] Try to get the webkit builder to use msvs again
​https://bugs.webkit.org/show_bug.cgi?id=110771

Reviewed by Eric Seidel.

The msvs gyp generator apparently doesn't write the sln file on every
run, so check the vcxproj file instead.

• Scripts/webkitdirs.pm:

(determineIsChromiumNinja):

11:14 AM Changeset in webkit [143950] by tony@chromium.org

• 3 edits in trunk/Source/WebCore

Refactor logic for relaying out children out of RenderBlock::styleDidChange
​https://bugs.webkit.org/show_bug.cgi?id=110661

Reviewed by David Hyatt.

Instead of having styleDidChange need to know which children to mark as needing layout,
use a bool to keep track of border and padding width changes so at layout time, we know
we need to set relayoutChildren=true.

We steal a bit from m_lineHeight reducing the possible line height from around 500 million pixels
to 250 million pixels.

No new tests, this should be covered by fast/block/positioning/border-change-relayout-test.html and
fast/block/dynamic-padding-border.html.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock): Fix indent and initialize m_hasBorderOrPaddingLogicalWidthChanged.
(WebCore::RenderBlock::styleDidChange): Remove logic for setting children as needing layout.
(WebCore::RenderBlock::updateLogicalWidthAndColumnWidth): Return true if border or padding width changed.

• rendering/RenderBlock.h:

(RenderBlock): Steal a bit from m_lineHeight and give it to m_hasBorderOrPaddingLogicalWidthChanged.

10:56 AM Changeset in webkit [143949] by ggaren@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Do one lookup per code cache insertion instead of two
​https://bugs.webkit.org/show_bug.cgi?id=110674

Reviewed by Sam Weinig.

Deployed the idiomatic "add null value" trick to avoid a second hash
lookup when inserting an item.

• runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): Factored this into a helper function
to improve clarity and get some code off the hot path.

(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode): Use the add() API
to avoid two hash lookups. Be sure to remove items if parsing fails,
otherwise we'll leave nulls in the table. (I'm guessing that caching parse
errors is not a win.)

• runtime/CodeCache.h:

(JSC::SourceCodeValue::SourceCodeValue):
(CodeCacheMap):
(JSC::CodeCacheMap::add): Combined find() and set() into add().

(JSC::CodeCacheMap::remove):
(JSC::CodeCacheMap::age):
(JSC::CodeCacheMap::prune): Refactored to support above changes.

10:56 AM Changeset in webkit [143948] by alexis@webkit.org

• 5 edits in trunk

transition-property property doesn't accept "all, <IDENT>".
​https://bugs.webkit.org/show_bug.cgi?id=110074

Reviewed by Dean Jackson.

Source/WebCore:

​http://dev.w3.org/csswg/css3-transitions/#transition-property-property
allows all, <IDENT> as a value for the transition-property property. In
fact thanks to ​http://trac.webkit.org/changeset/143019 we correctly
implemented that behavior for transition shorthand property while
fixing bugs on the previous implementation. We did introduce a
AnimationParseContext to track whether the parsing of the
transition-property was finished or not in relation to the keyword.
This patch extend that mechanism to the longhand by renaming the
boolean and the functions to use it in the context class and set it
correctly while parsing the longhand property.

Test: LayoutTests/transitions/transitions-parsing.html

• css/CSSParser.cpp:

(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitAnimationPropertyKeyword):
(WebCore::AnimationParseContext::animationPropertyKeywordAllowed):
(AnimationParseContext):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty): We can remove the
condition inShorthand() here, if 'none' is parsed then no more keyword
can appear, if 'all' is parsed then we can continue the parsing but
invalidate the property if another keyword is encountered. These
conditions are valid for the shorthand and the longhand.

LayoutTests:

Extend exising test to cover the bug.

• transitions/transitions-parsing-expected.txt:
• transitions/transitions-parsing.html:

10:39 AM Changeset in webkit [143947] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Texmap] LayoutTests/compositing/animation/state-at-end-event-transform-layer.html shows a red square where it shouldn't
​https://bugs.webkit.org/show_bug.cgi?id=110685

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-02-25
Reviewed by Martin Robinson.

Removed m_shouldUpdateCurrentTransformFromGraphicsLayer etc., as they don't do
what they're supposed to do. No flickers observed.

LayoutTests/compositing/animation/state-at-end-event-transform-layer.html now works correctly.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setAnimatedTransform):
(WebCore::TextureMapperLayer::setAnimatedOpacity):
(WebCore::TextureMapperLayer::setAnimatedFilters):
(WebCore::TextureMapperLayer::syncAnimations):

• platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::TextureMapperLayer):
(TextureMapperLayer):

10:27 AM Changeset in webkit [143946] by thakis@chromium.org

• 2 edits in trunk/Tools

[chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
​https://bugs.webkit.org/show_bug.cgi?id=110767

Reviewed by Eric Seidel.

The tester runs gyp, which generates out/Release/build.ninja. The bot
scripts use existence (and timestamp) of that file to decide if the
current build is supposed to be ninja or xcodebuild. The file exists,
so the snapshot is extracted to out/Release. The snapshot doesn't
contain build.ninja however due to
​http://trac.webkit.org/changeset/140375 , so after extracting the
snapshot the scripts think that this is an xcodebuild build. So remove
the part of that revision that removed ninja files from the archive,
and the bots should be happy again.

• BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

10:24 AM Changeset in webkit [143945] by jer.noble@apple.com

• 6 edits in trunk/Source/WebCore

AVFoundation.framework and QTKit.framework are lazy-loaded on every WebProcess launch
​https://bugs.webkit.org/show_bug.cgi?id=110725

Reviewed by Eric Carlson.

When settings are changed, do not re-query the media engines (which causes their respective
frameworks to load). Instead, merely clear any previously loaded media engines so that
the media engine list will be re-queried the next time installedMediaEngines() is called.

(WebCore::MediaPlayer::resetMediaEngines): Renamed from requeryMediaEngines.

• platform/graphics/MediaPlayer.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::resetMediaEngines): Ditto.

• html/HTMLMediaElement.h:
• page/Settings.cpp:

(WebCore::Settings::setAVFoundationEnabled): Call renamed method.
(WebCore::Settings::setQTKitEnabled): Ditto.

• platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines): Only clear out previously queried engines.

10:21 AM Changeset in webkit [143944] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Try to fix the Windows gyp build after r143937

• WebCore.gypi: Update the filename in the source list.

10:13 AM Changeset in webkit [143943] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add isInputMode() method to WebPage class.
​https://bugs.webkit.org/show_bug.cgi?id=110754

Patch by Yongxin Dai <​yodai@rim.com> on 2013-02-25
Reviewed by Rob Buis.

PR #262569.

There is a case we need to know if the active node is content editable
from TouchHandlerWebKitThread class. WebPage::isInputMode() just delegates
InputHandler::isInputMode().

Reviewed Internally by Mike Fenton.

• Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::isInputMode):
(WebKit):

• Api/WebPage.h:

10:10 AM Changeset in webkit [143942] by mifenton@rim.com

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Force form submission when implicit submission fails.
​https://bugs.webkit.org/show_bug.cgi?id=110627

Reviewed by Rob Buis.

PR 286023.

When implicit form submission does not submit the form
do a direct submission of the form.

Reviewed Internally by Nima Ghanavatian.

• WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::updateFormState):

10:08 AM Changeset in webkit [143941] by jchaffraix@webkit.org

• 8 edits in trunk/Source/WebCore

[CSS Grid Layout] Refactor RenderStyle's grid position storage in preparation to supporting spanning
​https://bugs.webkit.org/show_bug.cgi?id=110651

Reviewed by Ojan Vafai.

The current code stores grid-{row|column} as a single GridPosition value. While this works well currently,
we want to be able to handle 2 GridPosition as this enables row / column spanning.

That's what this refactoring achieves: it replaces the internal storage by a GridPositions that contains a
single GridPosition for now. The rest is mechanical updates.

Refactoring covered by existing tests.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPositions):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added the simple wrapper valueForGridPositions and updated the rest of the code.

• css/StyleResolver.cpp:

(WebCore::createGridPositions):
(WebCore::StyleResolver::applyProperty):
Ditto with createGridPositions.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionsForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionsForChild):
Updated the code after adding the indirection: s/GridPosition/GridPositions/ and
use the firstPosition helper.

• rendering/RenderGrid.h:
• rendering/style/GridPosition.h:

(WebCore::GridPositions::GridPositions):
(WebCore::GridPositions::firstPosition):
(WebCore::GridPositions::operator==):
Added this class to add the indirection. For now, it only wraps the single GridPosition.

• rendering/style/RenderStyle.h:
• rendering/style/StyleGridItemData.h:

Updated to store / take / return a GridPositions.

10:02 AM Changeset in webkit [143940] by Dimitri Glazkov

• 13 edits in trunk/Source/WebCore

Revert r143840 because it caused flaky crashes.
​https://bugs.webkit.org/show_bug.cgi?id=110766

9:57 AM Changeset in webkit [143939] by ap@apple.com

• 4 edits in trunk/Source/WebCore

Remove an obsolete workaround for relaxing 3rd party cookie policy
​https://bugs.webkit.org/show_bug.cgi?id=110664

Reviewed by Benjamin Poulain.

Removed shouldRelaxThirdPartyCookiePolicy(). This workaround is no longer needed,
because CFNetwork performs the same check starting with 10.6.8.

Also, the workaround was not quite correct and harmful for performance, as it
was always changing main document URL to an untrue value, which caused ResourceRequest
regeneration.

• platform/network/ResourceHandle.h:
• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

9:47 AM Changeset in webkit [143938] by vsevik@chromium.org

• 3 edits in trunk/Source/WebCore

WebInspector: Do not keep track of resources unless they have a valid loader identifier.
​https://bugs.webkit.org/show_bug.cgi?id=110761

Reviewed by Pavel Feldman.

• inspector/NetworkResourcesData.cpp:

(WebCore::NetworkResourcesData::responseReceived):
(WebCore::NetworkResourcesData::setResourceType):
(WebCore::NetworkResourcesData::resourceType):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::addCachedResource):
(WebCore::NetworkResourcesData::addResourceSharedBuffer):
(WebCore::NetworkResourcesData::data):
(WebCore::NetworkResourcesData::xhrReplayData):
(WebCore::NetworkResourcesData::setXHRReplayData):
(WebCore::NetworkResourcesData::reuseXHRReplayData):
(WebCore::NetworkResourcesData::resourceDataForRequestId):
(WebCore::NetworkResourcesData::ensureNoDataForRequestId):
(WebCore::NetworkResourcesData::ensureFreeSpace):

• inspector/NetworkResourcesData.h:

(NetworkResourcesData):

9:30 AM Changeset in webkit [143937] by commit-queue@webkit.org

• 4 edits
  1 move
  1 add in trunk/Source/WebCore

[EFL][GTK] Move text selection/focus notification for a11y from gtk to atk directory
​https://bugs.webkit.org/show_bug.cgi?id=110221

Patch by Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2013-02-25
Reviewed by Martin Robinson.

Share implementation between efl and gtk.
Update build with changes made.

• GNUmakefile.list.am: Change WebCore/editing/gtk/FrameSelectionGtk.cpp to WebCore/editing/atk/FrameSelectionAtk.cpp to build.
• PlatformEfl.cmake: Add WebCore/editing/atk to include directories, add Webcore/editing/atk/FrameSelectionAtk.cpp to build.
• editing/FrameSelection.h: Omit notifyAccessibilityForSelectionChange() stub for EFL port.

(WebCore):

• editing/atk/FrameSelectionAtk.cpp: Renamed from Source/WebCore/editing/gtk/FrameSelectionGtk.cpp.

(WebCore):
(WebCore::emitTextSelectionChange):
(WebCore::maybeEmitTextFocusChange):
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

9:27 AM Changeset in webkit [143936] by hclam@chromium.org

• 8 edits
  2 adds in trunk/Source

GIFImageReader to read from source data directly
​https://bugs.webkit.org/show_bug.cgi?id=109662

Reviewed by Stephen White.

Source/WebCore:

This is the first patch to improve GIF image decoding.

GIFImageReader has an internal 256 bytes buffer to saving incoming
bytes. This mechanism is out-dated because WebKit holds the entire
file in memory and it is not necessary to hold data in an intermediate
buffer.

This is also a blocker for later work to parse and decode GIF
incrementally.

This change removed the imtermediate 'hold' buffer and uses an index
for data position to keep track of parsing of the GIF file. Buffer for
global colormap and local colormap are also removed because they can be
referenced from the data stream.

This change is tested by:

Layout tests
All tests passed under fast/images.

Unit tests
Added GIFImageDecoderTest for Chromium.

Local testing
I tested this implementation against a set of 50k GIF images and
there's no crashes and produces bit-exact results as previous code.

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::decode):

• platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::doLZW):
(GIFImageReader::decode):
(GIFImageReader::decodeInternal):
(GIFImageReader::setRemainingBytes):

• platform/image-decoders/gif/GIFImageReader.h:

(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::setData):
(GIFImageReader):
(GIFImageReader::globalColormap):
(GIFImageReader::localColormap):
(GIFImageReader::localColormapSize):
(GIFImageReader::data):
(GIFImageReader::colormap):

Source/WebKit/chromium:

Added the following unit tests to test new logic in GIFImageDecoder:

GIFImageDecoderTest.decodeTwoFrames
Test that it can decode a multi-frame GIF image correctly.

GIFImageDecoderTest.parseAndDecode
First perform a parse operation and then a decode operation. Expect
that parse and decode operates correctly.

GIFImageDecoderTest.parseByteByByte
Test that multi-frame GIF image can be parsed correctly byte by byte.

GIFImageDecoderTest.parseAndDecodeByteByByte
Run a loop to feed decoder byte by byte, perform a parse and then
decode operation and make sure frames are decoded correctly.

GIFImageDecoderTest.brokenSecondFrame
Decode a GIF image with second frame broken. Expect that the first
frame can be decoded correctly.

• WebKit.gyp:
• WebKit.gypi:
• tests/GIFImageDecoderTest.cpp: Added.

(WebKit):
(WebKit::readFile):
(WebKit::TEST):

• tests/data/broken.gif: Added.

9:14 AM Changeset in webkit [143935] by abecsi@webkit.org

• 7 edits in trunk/Source/WebKit2

[Qt][WK2] Remove unneeded method didResumeContent from PageViewportController clients
​https://bugs.webkit.org/show_bug.cgi?id=110751

Reviewed by Jocelyn Turcotte.

This is a clean-up in the PageViewportController clients that removes leftover
code from previous design that is partially unused and unnecessary, to simplify
the interaction between PageViewportController and clients.

• UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::resumeContent):

• UIProcess/PageViewportControllerClient.h:

(PageViewportControllerClient):

• UIProcess/efl/PageViewportControllerClientEfl.cpp:
• UIProcess/efl/PageViewportControllerClientEfl.h:

(PageViewportControllerClientEfl):

• UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::resumeAndUpdateContent):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):

• UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

9:05 AM Changeset in webkit [143934] by peter@chromium.org

• 20 edits
  2 copies in branches/chromium/1410

Merge 143356

Text Autosizing: prevent oscillation of font sizes during autosizing
​https://bugs.webkit.org/show_bug.cgi?id=108205

Patch by Tim Volodine <​timvolodine@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

On some websites autosized font-sizes oscillate due to layouts caused by
hovering or incremental page loading (and on other sites font sizes do
eventually stabilize, but it takes many layouts before they reach a steady
size). To prevent all these cases, we no longer allow the autosizing
multiplier to change after it has been set (to a value other than 1).

This won't always give exactly the same results, but testing on 2000 top
sites shows that this makes little difference in practice, and it prevents
these very jarring cases. As a happy side-effect, this speeds up layouts
as font sizes change less.

Test: fast/text-autosizing/oscillation-javascript-fontsize-change.html

• page/FrameView.cpp:

(WebCore::FrameView::setFrameRect):

• page/Settings.cpp:

(WebCore::Settings::setTextAutosizingFontScaleFactor):

• rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::recalculateMultipliers):
(WebCore):
(WebCore::TextAutosizer::processContainer):

• rendering/TextAutosizer.h:

(TextAutosizer):

LayoutTests:

Added overflow-y:hidden to some existing tests, since previously those tests
would start off with incorrect multipliers (because mainFrame->view()-layoutSize()
is initially 785 instead of 800 as ScrollView wrongly guesses a scrollbar will
be needed), and then the multipliers would get corrected on a subsequent layout.
Now that we don't allow the multiplier to change after being set, it needs to be
right first time.
Also added specific oscillation test triggered by javascript.

• fast/text-autosizing/constrained-height-body-expected.html:
• fast/text-autosizing/constrained-height-body.html:
• fast/text-autosizing/constrained-then-float-ancestors-expected.html:
• fast/text-autosizing/constrained-then-float-ancestors.html:
• fast/text-autosizing/constrained-then-position-fixed-ancestors-expected.html:
• fast/text-autosizing/constrained-then-position-fixed-ancestors.html:
• fast/text-autosizing/nested-em-line-height-expected.html:
• fast/text-autosizing/nested-em-line-height.html:
• fast/text-autosizing/oscillation-javascript-fontsize-change-expected.html: Added.
• fast/text-autosizing/oscillation-javascript-fontsize-change.html: Added.
• fast/text-autosizing/simple-paragraph-expected.html:
• fast/text-autosizing/simple-paragraph.html:
• fast/text-autosizing/span-child-expected.html:
• fast/text-autosizing/span-child.html:
• fast/text-autosizing/unwrappable-blocks-expected.html:
• fast/text-autosizing/unwrappable-blocks.html:
• fast/text-autosizing/unwrappable-inlines-expected.html:
• fast/text-autosizing/unwrappable-inlines.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12310107

8:59 AM Changeset in webkit [143933] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size.
​https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <​tijiang@rim.com> on 2013-02-25
Reviewed by Rob Buis.

Fix a typo in function names.

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

8:56 AM Changeset in webkit [143932] by peter@chromium.org

• 4 edits in branches/chromium/1410

Merge 143318

[Text Autosizing] Combine narrow descendants of a cluster into groups that should be autosized with the same multiplier.
​https://bugs.webkit.org/show_bug.cgi?id=109825

Source/WebCore:

Enhancement of the approach introduced in ​https://bugs.webkit.org/show_bug.cgi?id=109573.
Instead of using the same text size multiplier for all narrow descendants of any autosizing
cluster, group the descendants by how much narrower they are than the cluster's
|blockContainingAllText| and process each group separately with a different multiplier for
each one.
For example, we want nested comments on the page to be autosized as a group but separately
from a sidebar on the same page.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

Updated the existing test to verify the patch.

• rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Splits the narrow descendants of the autosizing cluster into groups before processing
each group individually.

(WebCore::TextAutosizer::getNarrowDescendantsGroupedByWidth):

Sorts the narrow descendants of the given cluster into groups, combining them by the
difference between their content widths. If sorted by width, two consecutive nodes
belong to the same group if their width difference is no greater than 100 CSS units.

• rendering/TextAutosizer.h:

New method definitions.

LayoutTests:

Verify that narrow descendants are grouped and autosized separately according to the
difference between the descendant's width and the width of its enclosing cluster's
|blockContainingAllText|.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-19
Reviewed by Kenneth Rohde Christiansen.

• fast/text-autosizing/narrow-descendants-combined-expected.html:
• fast/text-autosizing/narrow-descendants-combined.html:

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12317102

8:56 AM Changeset in webkit [143931] by sergio@webkit.org

• 3 edits
  3 adds in trunk

[soup] "Too many redirects" error loading chat in plus.google.com
​https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

• http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
• http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
• http/tests/cookies/set-cookie-on-redirect.html: Added.

8:52 AM Changeset in webkit [143930] by peter@chromium.org

• 2 edits
  2 copies in branches/chromium/1410

Merge 142866

[Text Autosizing] Process narrow descendants with the same multiplier for the font size.
​https://bugs.webkit.org/show_bug.cgi?id=109573

Source/WebCore:

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

Combine narrow descendants of the same autosizing cluster into a group that is autosized
with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we want them all to share the same multiplier, as
if they were a single cluster.

Test: fast/text-autosizing/narrow-descendants-combined.html

• rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::processClusterInternal):

Common implementation for processCluster() and processCompositeCluster that accepts the
text width and whether the cluster should be autosized as parameters instead of
calculating it inline.

(WebCore::TextAutosizer::processCluster):

Calculates the text width for a single cluster and whether it should be autosized, then
calls processClusterInternal() to apply the multiplier and process the cluster's
descendants.

(WebCore::TextAutosizer::processCompositeCluster):

Calculates the text width for a group of renderers and if the group should be autosized,
then calls processClusterInternal() repeatedly with the same multiplier to apply it and
process all the descendants of the group.

(WebCore::TextAutosizer::clusterShouldBeAutosized):

Calls the multiple renderers version to avoid code duplication.

(WebCore::TextAutosizer::compositeClusterShouldBeAutosized):

The multiple renderers version of clusterShouldBeAutosized.

• rendering/TextAutosizer.h:

Updated method declarations.

LayoutTests:

Test to verify that all narrow descendants of a cluster are autosized with the same
multiplier.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-14
Reviewed by Julien Chaffraix.

• fast/text-autosizing/narrow-descendants-combined-expected.html: Added.
• fast/text-autosizing/narrow-descendants-combined.html: Added.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12326104

8:51 AM Changeset in webkit [143929] by thakis@chromium.org

• 2 edits in trunk/Tools

Fix tests after r143910
​https://bugs.webkit.org/show_bug.cgi?id=110757

Reviewed by Andreas Kling.

While here, also add a test for the bug r143910 fixed.

• Scripts/webkitpy/common/system/executive_unittest.py:

(ScriptErrorTest.test_message_with_output):
(ScriptErrorTest):
(ScriptErrorTest.test_message_with_tuple):

8:46 AM Changeset in webkit [143928] by peter@chromium.org

• 1 edit in branches/chromium/1410/Source/WebCore/rendering/TextAutosizer.cpp

Merge 142534

[Text Autosizing] Collect narrow descendants and process them separately. Refactoring for
a change to follow.
​https://bugs.webkit.org/show_bug.cgi?id=109054

Preparational change to combine narrow descendants of the same autosizing cluster into
groups by the width difference between the descendant and the block containing all text of
the parent autosizing cluster. The groups will be autosized with the same multiplier.

For example, on sites with a sidebar, sometimes the paragraphs next to the sidebar will have
a large margin individually applied (via a CSS selector), causing them all to individually
appear narrower than their enclosing blockContainingAllText. Rather than making each of
these paragraphs into a separate cluster, we eventually want to be able to merge them back
together into one (or a few) descendant clusters.

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-11
Reviewed by Julien Chaffraix.

No behavioral changes thus no new tests or test changes.

• rendering/TextAutosizer.cpp:

(TextAutosizingClusterInfo): Vector of narrow descendants.
(WebCore::TextAutosizer::processCluster): Process narrow descendants separately.
(WebCore::TextAutosizer::processContainer):

Remember narrow descendants of the parent cluster for later processing.

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12315083

8:09 AM Changeset in webkit [143927] by thakis@chromium.org

• 2 edits in trunk/Tools

[chromium] Apparently built-product-archive is written in Python, not Perl :-/
​https://bugs.webkit.org/show_bug.cgi?id=110755

Reviewed by Jochen Eisinger.

• BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

7:51 AM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

7:50 AM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

7:49 AM Changeset in webkit [143926] by akling@apple.com

• 52 edits in trunk/Source

Reduce amount of code that includes StylePropertySet.h
<​http://webkit.org/b/101149>

Reviewed by Antti Koivisto.

Source/WebCore:

StylePropertySet.h and dependents were getting included by the majority of WebKit
through either StyledElement.h or CSSStyleDeclaration.h. This change removes those includes
and moves inclusion to .cpp files instead. After this change, it's possible to hack most
of WebCore/css/ and rebuild <100 files instead of >1000.

The only real code change in here is changing CSSStyleDeclaration::cssPropertyMatches()
to take a CSSPropertyID/CSSValue* combo instead of a StylePropertySet::Reference.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::cssPropertyMatches):

• css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

• css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::cssPropertyMatches):

• css/PropertySetCSSStyleDeclaration.h:
• css/SelectorChecker.h:
• css/SelectorCheckerFastPath.cpp:
• css/SelectorFilter.cpp:
• css/SelectorFilter.h:
• css/StylePropertySet.cpp:

(WebCore::StylePropertySet::propertyMatches):
(WebCore::StylePropertySet::removeEquivalentProperties):

• css/StylePropertySet.h:
• css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::MatchedProperties):
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):

• css/StyleResolver.h:

(MatchedProperties):

• css/StyleRule.cpp:
• css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::~ViewportStyleResolver):

• css/ViewportStyleResolver.h:

(ViewportStyleResolver):

• css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::StyleKeyframe):
(WebCore::StyleKeyframe::~StyleKeyframe):

• css/WebKitCSSKeyframeRule.h:

(StyleKeyframe):

• dom/Attr.cpp:
• dom/Document.cpp:
• dom/Element.cpp:
• dom/StyledElement.cpp:

(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):

• dom/StyledElement.h:

(StyledElement):

• editing/FrameSelection.cpp:
• editing/RemoveCSSPropertyCommand.cpp:

(WebCore::RemoveCSSPropertyCommand::~RemoveCSSPropertyCommand):

• editing/RemoveCSSPropertyCommand.h:

(RemoveCSSPropertyCommand):

• editing/RemoveFormatCommand.cpp:
• html/HTMLBodyElement.cpp:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::addHTMLLengthToStyle):
(WebCore::HTMLElement::addHTMLColorToStyle):

• html/HTMLElement.h:

(HTMLElement):

• html/HTMLFontElement.cpp:
• html/HTMLHRElement.cpp:
• html/HTMLPreElement.cpp:
• html/HTMLTableElement.cpp:
• html/HTMLTablePartElement.cpp:
• html/canvas/CanvasStyle.cpp:
• html/shadow/MediaControlElementTypes.cpp:
• inspector/InspectorStyleSheet.cpp:
• page/PageSerializer.cpp:
• rendering/RenderTableCell.cpp:
• svg/SVGAnimateElement.cpp:
• svg/SVGElementRareData.h:
• svg/SVGFontFaceElement.cpp:

Source/WebKit/gtk:

• WebCoreSupport/EditorClientGtk.cpp:

Source/WebKit/mac:

• WebCoreSupport/WebEditorClient.mm:
• WebView/WebFrame.mm:
• WebView/WebView.mm:

Source/WebKit2:

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

7:46 AM Changeset in webkit [143925] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip asserting tests.
​https://bugs.webkit.org/show_bug.cgi?id=110756

• platform/qt/TestExpectations:

7:42 AM Changeset in webkit [143924] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r143895.
​http://trac.webkit.org/changeset/143895
​https://bugs.webkit.org/show_bug.cgi?id=110758

broke a bunch of tests (Requested by thakis on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-25

• Scripts/update-webkit-chromium:

7:22 AM Changeset in webkit [143923] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

Web Inspector: Remove CPU profile from a group causes exception
​https://bugs.webkit.org/show_bug.cgi?id=110466

Patch by Alexei Filippov <​alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

WebInspector.ProfilesPanel._removeProfileHandle did not handle
profile removal from a group. The fix takes care of this case.

Test: inspector/profiler/cpu-profiler-profile-removal.html

Source/WebCore:

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

LayoutTests:

• inspector/profiler/cpu-profiler-profile-removal-expected.txt: Added.
• inspector/profiler/cpu-profiler-profile-removal.html: Added.

7:15 AM Changeset in webkit [143922] by yoli@rim.com

• 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed. Edit my personal info.

• Scripts/webkitpy/common/config/committers.py:

7:10 AM Changeset in webkit [143921] by caseq@chromium.org

• 2 edits in trunk/Source/WebKit/chromium

Unreviewed follow-up to r143725, reduce chances test flakes on a slow box.

• src/js/Tests.js:

(.TestSuite.prototype.testPageOverlayUpdate.step2):

6:53 AM Changeset in webkit [143920] by mkwst@chromium.org

• 3 edits
  1 copy
  1 move
  40 adds
  13 deletes in trunk/LayoutTests

XSSAuditor tests shouldn't depend on IFrames's load order.
​https://bugs.webkit.org/show_bug.cgi?id=110737

Reviewed by Jochen Eisinger.

Various tests under http/tests/security/xssAuditor actually wrap up
multiple test cases under a single HTML file by loading a variety of
IFrames. Currently, the error messages that these tests expect aren't
detailed enough to distinguish between the order in which the IFrames
load: they all generate the same error, so the ordering is irrelevant.

Before we increase the error message detail in webkit.org/b/110733, we
need to ensure that these tests don't rely on load order. One option
is to serialize the IFrame loading by chaining onload events, but that
seems like a slow way of doing things. This patch takes a different
approach, breaking the multiple-IFrame tests into many single-IFrame
tests (which should be more shardable, and actually execute more quickly
in the long run).

• http/tests/security/xssAuditor/open-iframe-src-expected.txt: Removed.
• http/tests/security/xssAuditor/open-iframe-src.html: Removed.
• http/tests/security/xssAuditor/open-script-src-expected.txt: Removed.
• http/tests/security/xssAuditor/open-script-src.html: Removed.
• http/tests/security/xssAuditor/property-escape-comment-expected.txt: Removed.
• http/tests/security/xssAuditor/property-escape-comment.html: Removed.
• http/tests/security/xssAuditor/property-escape-entity-expected.txt: Removed.
• http/tests/security/xssAuditor/property-escape-entity.html: Removed.
• http/tests/security/xssAuditor/property-escape-quote-expected.txt: Removed.
• http/tests/security/xssAuditor/property-escape-quote.html: Removed.
• http/tests/security/xssAuditor/script-tag-with-comma-expected.txt: Removed.
• http/tests/security/xssAuditor/script-tag-with-comma.html: Removed.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt: Removed.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated.html: Removed.

Removed these tests, breaking them into multiple single-IFrame HTML files.

• http/tests/security/xssAuditor/open-iframe-src-01.html: Added.
• http/tests/security/xssAuditor/open-iframe-src-02.html: Added.
• http/tests/security/xssAuditor/open-script-src-01-expected.txt: Added.
• http/tests/security/xssAuditor/open-script-src-01.html: Added.
• http/tests/security/xssAuditor/open-script-src-02-expected.txt: Added.
• http/tests/security/xssAuditor/open-script-src-02.html: Added.
• http/tests/security/xssAuditor/open-script-src-03-expected.txt: Added.
• http/tests/security/xssAuditor/open-script-src-03.html: Added.
• http/tests/security/xssAuditor/open-script-src-04-expected.txt: Added.
• http/tests/security/xssAuditor/open-script-src-04.html: Added.
• http/tests/security/xssAuditor/property-escape-comment-01-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-comment-01.html: Added.
• http/tests/security/xssAuditor/property-escape-comment-02-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-comment-02.html: Added.
• http/tests/security/xssAuditor/property-escape-comment-03-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-comment-03.html: Added.
• http/tests/security/xssAuditor/property-escape-entity-01-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-entity-01.html: Added.
• http/tests/security/xssAuditor/property-escape-entity-02-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-entity-02.html: Added.
• http/tests/security/xssAuditor/property-escape-entity-03-expected.txt: Added.
• http/tests/security/xssAuditor/property-escape-entity-03.html: Added.
• http/tests/security/xssAuditor/property-escape-quote-01.html: Added.
• http/tests/security/xssAuditor/property-escape-quote-02.html: Added.
• http/tests/security/xssAuditor/property-escape-quote-03.html: Added.
• http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt: Added.
• http/tests/security/xssAuditor/script-tag-with-comma-01.html: Added.
• http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt: Added.
• http/tests/security/xssAuditor/script-tag-with-comma-02.html: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt: Added.
• http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html: Added.
• http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html: Added.

These tests perform the same validation as the combined tests, they
simply do it without introducing load-order dependencies.

6:38 AM Changeset in webkit [143919] by tommyw@google.com

• 6 edits in branches/chromium/1410/Source

Merge 142773

MediaStream API: Use the source id when creating new tracks
​https://bugs.webkit.org/show_bug.cgi?id=109688

Reviewed by Adam Barth.

Source/Platform:

Added id to initialize and renamed audio/videoSources to audio/videoTracks.

• chromium/public/WebMediaStream.h:

(WebKit):
(WebMediaStream):
(WebKit::WebMediaStream::audioSources):
(WebKit::WebMediaStream::videoSources):

• chromium/public/WebMediaStreamTrack.h:

(WebMediaStreamTrack):

Source/WebCore:

This patch reuses the ids from the source when creating tracks instead of creating a new one.
This was requested by the chromium port to greatly simplify their implementation.
In the longer run the API should be rewritten to only use tracks instead of sources.

Covered by existing tests.

• platform/chromium/support/WebMediaStream.cpp:

(WebKit::WebMediaStream::audioTracks):
(WebKit::WebMediaStream::videoTracks):
(WebKit::WebMediaStream::initialize):
(WebKit):

• platform/chromium/support/WebMediaStreamTrack.cpp:

(WebKit::WebMediaStreamTrack::initialize):
(WebKit):

• platform/mediastream/MediaStreamComponent.h:

(WebCore::MediaStreamComponent::create):
(MediaStreamComponent):
(WebCore::MediaStreamComponent::MediaStreamComponent):
(WebCore):

• platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::create):
(MediaStreamDescriptor):
(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

Tools:

Switching mock to new API.

• DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:

(WebTestRunner::WebUserMediaClientMock::requestUserMedia):

TBR=​dharani@google.com
Review URL: ​https://codereview.chromium.org/12326102

6:14 AM Changeset in webkit [143918] by akling@apple.com

• 2 edits in trunk/Tools

Unreviewed, fix simple mistake in r143903.
<​http://webkit.org/b/110746>

Reviewed by Andreas Kling.

Pass git revision, not svn revision, to git shell command.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit):

6:06 AM Changeset in webkit [143917] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit/chromium

[Chromium] Disable registerProtocolHandler on Android
​https://bugs.webkit.org/show_bug.cgi?id=110481

Patch by Anton Vayvod <​avayvod@chromium.org> on 2013-02-25
Reviewed by Julien Chaffraix.

Chromium for Android has been exposing registerProtocolHandler, but the feature wasn't
actually wired up internally. Disable the feature to avoid breaking feature detection until
we can implement it properly. Previous attempt is at ​http://trac.webkit.org/changeset/133465
See the discussion of the future implementation at ​http://crbug.com/156386

• features.gypi: Disable the flag for Android, enable it only for non-Android platforms.

• src/ChromeClientImpl.h: Declaration is now guarded by the flag, not to break Android.

6:06 AM Changeset in webkit [143916] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

5:59 AM Changeset in webkit [143915] by thakis@chromium.org

• 2 edits in trunk/Tools

[chromium] Let built-product-archive log which directory it's archiving from and extracting to
​https://bugs.webkit.org/show_bug.cgi?id=110748

Reviewed by Jochen Eisinger.

One of the mac testers runs DRT from out/ but WebKitUnitTests from
xcodebuild. I'm trying to understand what's going on.

• BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

5:50 AM Changeset in webkit [143914] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

5:37 AM Changeset in webkit [143913] by loislo@chromium.org

• 13 edits in trunk

Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
​https://bugs.webkit.org/show_bug.cgi?id=110599

Reviewed by Yury Semikhatsky.

Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
that were given us via MemoryInstrumentation calls.
So I extended client api with registerString method that pushes the strings
down to the serializer.

Source/WebCore:

• css/InspectorCSSOMWrappers.h:
• inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNodeImpl):
(WebCore::HeapGraphSerializer::reportEdgeImpl):
(WebCore::HeapGraphSerializer::registerString):
(WebCore::HeapGraphSerializer::registerTypeString):
(WebCore::HeapGraphSerializer::addRootNode):

• inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

• inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::registerString):
(WebCore):

• inspector/MemoryInstrumentationImpl.h:

(MemoryInstrumentationClientImpl):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

Source/WTF:

• wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):

• wtf/MemoryObjectInfo.h:

(WTF::MemoryObjectInfo::MemoryObjectInfo):
(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::classNameId):
(WTF::MemoryObjectInfo::setName):
(WTF::MemoryObjectInfo::nameId):
(MemoryObjectInfo):

Tools:

• TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
• TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::Helper::Helper):
(Helper):
(TestWebKitAPI::Helper::addNode):
(TestWebKitAPI::TEST):

5:21 AM Changeset in webkit [143912] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

5:20 AM Changeset in webkit [143911] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

Add a scrollbar class for the new calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=110589

Reviewed by Kent Tamura.

Adding a scrollbar to be used in the new calendar picker (Bug 109439).

No new tests. Code is not used yet.

• Resources/pagepopups/calendarPicker.js:

(ScrubbyScrollBar):
(ScrubbyScrollBar.prototype.height):
(ScrubbyScrollBar.prototype.setHeight):
(ScrubbyScrollBar.prototype.setThumbHeight): Sets the height of the scroll bar thumb.
(ScrubbyScrollBar.prototype._setThumbPositionFromEvent): Sets the thumb position from a mouse event.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(ScrubbyScrollBar.prototype.onThumbStyleTopAnimationStep): Animates the thumb back to the center position.
(ScrubbyScrollBar.prototype.onScrollTimer): Fires repeatedly while the thumb is being dragged.

5:16 AM Changeset in webkit [143910] by thakis@chromium.org

• 2 edits in trunk/Tools

Make ScriptError not crash when args is a tuple
​https://bugs.webkit.org/show_bug.cgi?id=110747

Reviewed by Jochen Eisinger.

I'm trying to understand the error on
​http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
better. I'll likely have to revert the ninja switch on windows, but
having error reporting code that doesn't itself crash sounds like a
good thing to have anyways.

The problem is that '%s' % (1, 2) errors out, and args is sometimes a
tuple not a list.

• Scripts/run-chromium-webkit-unit-tests:
• Scripts/webkitpy/common/system/executive.py:

(ScriptError.init):

5:13 AM Changeset in webkit [143909] by commit-queue@webkit.org

• 11 edits in trunk/Source/JavaScriptCore

[BlackBerry][ARM] Fix cast-align warnings in JavaScriptCore
​https://bugs.webkit.org/show_bug.cgi?id=110738

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-02-25
Reviewed by Rob Buis.

Use reinterpret_cast_ptr instead of reinterpret_cast for
pointers.

• dfg/DFGOperations.cpp:
• heap/CopiedBlock.h:

(JSC::CopiedBlock::zeroFillWilderness):

• heap/WeakBlock.h:

(JSC::WeakBlock::asWeakImpl):
(JSC::WeakBlock::asFreeCell):
(JSC::WeakBlock::weakImpls):

• heap/WeakImpl.h:

(JSC::WeakImpl::asWeakImpl):

• interpreter/JSStack.cpp:

(JSC::JSStack::disableErrorStackReserve):

• interpreter/JSStack.h:

(JSC::JSStack::reservationEnd):

• runtime/ArrayStorage.h:

(JSC::ArrayStorage::from):

• runtime/Butterfly.h:

(JSC::Butterfly::indexingPayload):

• runtime/IndexingHeader.h:

(JSC::IndexingHeader::propertyStorage):

• runtime/JSActivation.h:

(JSC::JSActivation::tearOff):
(JSC::JSActivation::isTornOff):
(JSC::JSActivation::storage):

5:10 AM Changeset in webkit [143908] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

5:02 AM Changeset in webkit [143907] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

4:56 AM Changeset in webkit [143906] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

4:47 AM FeatureFlags edited by tkent@chromium.org

CUSTOM_ELEMENTS (diff)

4:36 AM Changeset in webkit [143905] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[EFL] Align feature defaults
​https://bugs.webkit.org/show_bug.cgi?id=110715

Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
OptionsEfl.cmake.

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-25
Reviewed by Gyuyoung Kim.

• Scripts/webkitperl/FeatureList.pm:

4:31 AM Changeset in webkit [143904] by loislo@chromium.org

• 3 edits in trunk/Source/WebCore

Unreviewed. Fix of closure type annotations.

• inspector/front-end/UISourceCode.js:
• inspector/front-end/utilities.js:

4:26 AM Changeset in webkit [143903] by rniwa@webkit.org

• 7 edits in trunk/Tools

run-perf-tests reports wrong commit time
​https://bugs.webkit.org/show_bug.cgi?id=110746

Reviewed by Andreas Kling.

The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
of when the subdirectory was last modified.

Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
insufficient since running "svn log -r <revision>" on a partial checkout only returns
an empty result if the revision didn't modify the subdirectory.

For git, there is no partial checkout, so we just need to pass in "-r" option to keep
the interface compatible with svn.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.timestamp_of_latest_commit):

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.timestamp_of_latest_commit):

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.timestamp_of_latest_commit):

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_timestamp_of_latest_commit):

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.timestamp_of_latest_commit):

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

3:45 AM Changeset in webkit [143902] by eustas@chromium.org

• 4 edits in trunk/Source/WebCore

Web Inspector: [Network] Timeline bars and dividers are positioned in different coordinate systems.
​https://bugs.webkit.org/show_bug.cgi?id=109943

Reviewed by Pavel Feldman.

Look at network log: red bar (on load) is positioned to the right of
the last required load.

This is incorrect. For exmaple, in case of short event it should be
positioned in the center of the bar.

• inspector/front-end/DataGrid.js:

Fix - hidden columns can have non-zero width.

• inspector/front-end/NetworkPanel.js: Use correct width for calculator.
• inspector/front-end/networkLogView.css: Removed parasite paddinds.

Extracted common absolute "paddings".

3:31 AM Changeset in webkit [143901] by keishi@webkit.org

• 2 edits in trunk/Source/WebCore

Add list view for new calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=110140

Reviewed by Kent Tamura.

Adding list view class to be used in the new calendar picker (Bug 109439).

No new tests. Code is not yet used.

• Resources/pagepopups/calendarPicker.js:

(ListCell): One row inside the list view. We reuse
list cells to avoid animation hiccups caused by memory allocation.
(ListCell.prototype._recycleBin): Returns array to
store thrown away list cells so we can reuse them.
(ListCell.prototype.throwAway): Hides the cell and puts it in the recycle bin.
(ListCell.prototype.show):
(ListCell.prototype.hide): Hide the cell when we don't need the cell any more.
(ListCell.prototype.width):
(ListCell.prototype.setWidth):
(ListCell.prototype.position):
(ListCell.prototype.setPosition): Sets the CSS transform to position the cell.
(ListCell.prototype.setSelected): Adds selected CSS class.
(ListView): Shows a scrolling list.
(ListView.prototype.onAnimationFrameWillFinish): Calls updateCells if the cells need to be updated.
(ListView.prototype.setNeedsUpdateCells): Mark the cells as need to be updated.
(ListView.prototype.cellAtRow): Returns the cell at a given row. If the cell is not visible and doesn't exist, returns undefined.
(ListView.prototype.rowAtScrollOffset): The row that is displayed at the given scroll offset.
(ListView.prototype.scrollOffsetForRow): The scroll offset for the top of a given row.
(ListView.prototype.addCellIfNecessary): Adds the cell for a given row.
(ListView.prototype.prepareNewCell): Prepares a new or recycled cell for a given row.
(ListView.prototype.throwAwayCell): Throws a way a cell.
(ListView.prototype.firstVisibleRow): The first visible row at the top of the view.
(ListView.prototype.lastVisibleRow): The last visible row at the bottom of the view.
(ListView.prototype.scrollViewDidChangeContentOffset):
(ListView.prototype.scrollViewDidChangeHeight):
(ListView.prototype.scrollViewDidChangePartition):
(ListView.prototype.updateCells): Updates all the cells that are visible.
(ListView.prototype.width):
(ListView.prototype.setWidth):
(ListView.prototype.height):
(ListView.prototype.setHeight):
(ListView.prototype.onClick): Clicking on a row selects it.
(ListView.prototype.select):
(ListView.prototype.deselect):
(ListView.prototype.scrollToRow): Scrolls to a given row.

2:53 AM Changeset in webkit [143900] by commit-queue@webkit.org

• 15 edits in trunk

Web Inspector: move profile type specific code out of ProfilesPanel (refactor)
​https://bugs.webkit.org/show_bug.cgi?id=110597

Patch by Alexei Filippov <​alph@chromium.org> on 2013-02-25
Reviewed by Yury Semikhatsky.

Move profile type specific functionality out of ProfilesPanel class.
This is a first part of WebInspector.ProfilesPanel refactoring.

No new tests as the functionality isn't changed.

Source/WebCore:

• English.lproj/localizedStrings.js:
• inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.addProfileHeader):
(WebInspector.CPUProfileType.prototype.removeProfile):
(WebInspector.CPUProfileType.prototype._requestProfilesFromBackend):
(WebInspector.CPUProfileType.prototype.resetProfiles):
(WebInspector.CPUProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.CPUProfileType.prototype.finishHeapSnapshot):
(WebInspector.CPUProfileType.prototype.reportHeapSnapshotProgress):

• inspector/front-end/CSSSelectorProfileView.js:

(WebInspector.CSSSelectorProfileType.prototype.buttonClicked):
(WebInspector.CSSSelectorProfileType.prototype._startRecordingProfile):
(WebInspector.CSSSelectorProfileType.prototype._stopRecordingProfile):

• inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileType.prototype.buttonClicked):
(WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
(WebInspector.CanvasProfileType.prototype._startFrameCapturing):
(WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
(WebInspector.CanvasProfileType.prototype._reset):
(WebInspector.CanvasProfileType.prototype.removeProfile):
(WebInspector.CanvasProfileHeader.prototype.dispose):

• inspector/front-end/HeapSnapshotView.js:

(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.addProfileHeader):
(WebInspector.HeapSnapshotProfileType.prototype.addHeapSnapshotChunk):
(WebInspector.HeapSnapshotProfileType.prototype.finishHeapSnapshot):
(WebInspector.HeapSnapshotProfileType.prototype.reportHeapSnapshotProgress):
(WebInspector.HeapSnapshotProfileType.prototype.resetProfiles):
(WebInspector.HeapSnapshotProfileType.prototype.removeProfile):
(WebInspector.HeapSnapshotProfileType.prototype._requestProfilesFromBackend):
(WebInspector.HeapProfileHeader.prototype._updateTransferProgress):

• inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType):
(WebInspector.NativeSnapshotProfileType.prototype.addNativeSnapshotChunk):

• inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileType):
(WebInspector.ProfileType.prototype.buttonClicked):
(WebInspector.ProfileType.prototype.get description):
(WebInspector.ProfileType.prototype.getProfiles):
(WebInspector.ProfileType.prototype.getProfile):
(WebInspector.ProfileType.prototype._makeKey):
(WebInspector.ProfileType.prototype.addProfile):
(WebInspector.ProfileType.prototype.removeProfile):
(WebInspector.ProfileType.prototype.findTemporaryProfile):
(WebInspector.ProfileType.prototype._reset):
(WebInspector.ProfileType.prototype._requestProfilesFromBackend):
(WebInspector.ProfileHeader):
(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._loadFromFile):
(WebInspector.ProfilesPanel.prototype.toggleRecordButton):
(WebInspector.ProfilesPanel.prototype._populateAllProfiles):
(WebInspector.ProfilesPanel.prototype.wasShown):
(WebInspector.ProfilesPanel.prototype._profilerWasEnabled):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onAddProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onRemoveProfileHeader):
(WebInspector.ProfilesPanel.prototype._registerProfileType.onProgressUpdated):
(WebInspector.ProfilesPanel.prototype._registerProfileType):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._createTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype.getProfile):
(WebInspector.ProfilesPanel.prototype.showProfile):
(WebInspector.ProfilesPanel.prototype._getAllProfiles):
(WebInspector.ProfilesPanel.prototype._searchableViews):
(WebInspector.ProfilesPanel.prototype.searchCanceled):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype._reportProfileProgress):

LayoutTests:

• inspector/profiler/canvas2d/canvas-replay-log-grid.html:
• inspector/profiler/heap-snapshot-inspect-dom-wrapper-expected.txt:
• inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
• inspector/profiler/heap-snapshot-loader.html:
• inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

• inspector/profiler/profiler-test.js:

(initialize_ProfilerTest.InspectorTest.startProfilerTest.startTest):
(initialize_ProfilerTest.InspectorTest.startProfilerTest):

2:40 AM Changeset in webkit [143899] by kadam@inf.u-szeged.hu

• 4 edits
  4 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped failing tests.

• platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Removed.
• platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt: Removed.
• platform/qt-5.0/fast/forms/select-baseline-expected.png: Removed.
• platform/qt-5.0/fast/forms/select-baseline-expected.txt: Removed.
• platform/qt/TestExpectations:
• platform/qt/fast/forms/select-baseline-expected.png: Update after r143836.
• platform/qt/fast/forms/select-baseline-expected.txt: Update after r143836.

2:33 AM Changeset in webkit [143898] by jochen@chromium.org

• 3 edits in trunk/Tools

[chromium] move WebRuntimeFeatures configuration to TestRunner library
​https://bugs.webkit.org/show_bug.cgi?id=110712

Reviewed by Nico Weber.

• DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

2:04 AM Changeset in webkit [143897] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

1:56 AM Changeset in webkit [143896] by zarvai@inf.u-szeged.hu

• 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip tests after r143800.

• platform/qt/TestExpectations:

1:48 AM Changeset in webkit [143895] by thakis@chromium.org

• 2 edits in trunk/Tools

Make ninja the default build system for build-webkit --chromium on windows
​https://bugs.webkit.org/show_bug.cgi?id=110731

Reviewed by Jochen Eisinger.

With ​http://crbug.com/169945 fixed, this should now work.

• Scripts/update-webkit-chromium:

1:48 AM Changeset in webkit [143894] by loislo@chromium.org

• 2 edits in trunk/Source/WebCore

Unreviewed fix of type annotation for this._liveLocations.

• inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):

1:42 AM Changeset in webkit [143893] by tkent@chromium.org

• 6 edits in trunk/Source/WebCore

Fix style errors in WebCore/editing/{htmlediting,markup,visible_units}.*
​https://bugs.webkit.org/show_bug.cgi?id=110721

Reviewed by Ryosuke Niwa.

No new tests. This should not make any bahevior changes.

• editing/htmlediting.cpp:

(WebCore::lowestEditableAncestor):
(WebCore):
(WebCore::isSpecialElement):
(WebCore::enclosingListChild):
(WebCore::canMergeLists):
(WebCore::tabSpanNode):
(WebCore::isNodeRendered):
(WebCore::caretMaxOffset):

• editing/htmlediting.h:

(WebCore):

• editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendElement):

• editing/markup.h:

(WebCore):

• editing/visible_units.cpp:

(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::previousBoundary):
(WebCore::endOfLine):
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
(WebCore::nextSentencePositionBoundary):
(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

1:41 AM Changeset in webkit [143892] by zandobersek@gmail.com

• 3 edits
  2 deletes in trunk/LayoutTests

Unreviewed GTK gardening.

• platform/gtk/TestExpectations: Giving up on individually listing slow sputnik tests, replaced all

the expectations with a single one covering the whole directory in both release and debug builds.
Also removing duplicate expectations and adding an expectation for tests that require custom elements support.

• platform/gtk/editing/selection/extend-by-sentence-001-expected.txt: Rebaselining.
• platform/gtk/media/audio-controls-rendering-expected.png: Removed. Requires a new baseline.
• platform/gtk/media/audio-controls-rendering-expected.txt: Removed. Ditto.

1:29 AM Changeset in webkit [143891] by vsevik@chromium.org

• 2 edits in trunk/LayoutTests

Unreviewed chromium test expectations update.

• platform/chromium/TestExpectations:

1:11 AM Changeset in webkit [143890] by keishi@webkit.org

• 6 edits
  3 copies in branches/chromium/1410

Merge 142572

REGRESSION (r140778):Calendar Picker buttons are wrong when rtl
​https://bugs.webkit.org/show_bug.cgi?id=109158

Reviewed by Kent Tamura.

Source/WebCore:

The calendar picker button's icon and position where wrong when rtl.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html

• Resources/pagepopups/calendarPicker.css:

(.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side.
(.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side.
(.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side.

• Resources/pagepopups/calendarPicker.js:

(YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl.
(YearMonthController.prototype._attachRightButtonsTo): Ditto.

LayoutTests:

• platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added.
• platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
• platform/chromium/TestExpectations:
• platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added.
• platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added.

TBR=​keishi@webkit.org

1:10 AM Changeset in webkit [143889] by loislo@chromium.org

• 7 edits in trunk

Web Inspector: Improve speed of Linkifier.reset operation.
​https://bugs.webkit.org/show_bug.cgi?id=110696

Reviewed by Yury Semikhatsky.

Linkifier calls Location.dispose N times and each dispose method calls Array.remove
which scans entire array and does splice. So the complexity of Linkifier.reset
is O(N^{2). I replaced the arrays with Set and got O(N) complexity.}

Drive by fix: The identifier generator was slightly changed.
Now it produces identifiers that couldn't be converted into a number.
So the engine will never convert Set/Map object into an array.

Source/WebCore:

• inspector/front-end/Script.js:

(WebInspector.Script):
(WebInspector.Script.prototype.updateLocations):
(WebInspector.Script.prototype.createLiveLocation):

• inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.addLiveLocation):
(WebInspector.UISourceCode.prototype.updateLiveLocations):

• inspector/front-end/utilities.js:

LayoutTests:

• inspector/debugger/callstack-placards-discarded.html:
• inspector/debugger/linkifier.html:

12:49 AM WebKitGTK/2.0.x edited by sergio@webkit.org

(diff)

12:09 AM Changeset in webkit [143888] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ChromeClientBlackBerry: fix variable names
​https://bugs.webkit.org/show_bug.cgi?id=110562

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-02-25
Reviewed by Rob Buis.

manager was incorrectly renamed back to tracker in r138696:
​http://trac.webkit.org/changeset/138696/trunk/Source/WebKit/blackberry/WebCoreSupport/ChromeClientBlackBerry.cpp

• WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):

Feb 24, 2013:

11:35 PM Changeset in webkit [143887] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] GeolocationClientBlackBerry: add missing headers
​https://bugs.webkit.org/show_bug.cgi?id=110563

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-02-24
Reviewed by Benjamin Poulain.

Frame.h and SecurityOrigin.h are necessary since r136969.
GeolocationPosition.h since r132360.

• WebCoreSupport/GeolocationClientBlackBerry.cpp:

11:27 PM Changeset in webkit [143886] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r143797.
​http://trac.webkit.org/changeset/143797
​https://bugs.webkit.org/show_bug.cgi?id=110724

Causes assertion failures in multiple tests. (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-02-24

• dom/DocumentParser.h:

(DocumentParser):

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

• html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::shouldUseThreading):

• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

11:00 PM Changeset in webkit [143885] by morrita@google.com

• 13 edits in trunk/Source/WebCore

Rollout r143556, it regressed html5-full-render perf.
​https://bugs.webkit.org/show_bug.cgi?id=110719

Unreviewed rollout.

• css/BasicShapeFunctions.cpp:

(WebCore::convertToLength):
(WebCore::basicShapeForValue):

• css/BasicShapeFunctions.h:

(WebCore):

• css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::gradientWithStylesResolved):

• css/CSSGradientValue.h:

(CSSGradientValue):

• css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):

• css/CSSToStyleMap.h:

(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):

• css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

• css/StyleBuilder.cpp:

(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):

• css/StyleBuilder.h:

(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):

• css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
(WebCore::StyleResolver::reportMemoryUsage):

• css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::hasParentNode):
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
(State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::styleMap):
(WebCore::StyleResolver::fontDescription):
(WebCore::StyleResolver::parentFontDescription):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):

7:57 PM Changeset in webkit [143884] by eric.carlson@apple.com

• 6 edits in trunk/Source/WebCore

[Mac] cleanup MediaPlayerPrivateAVFoundation and InbandTextTrackPrivateAVF
​https://bugs.webkit.org/show_bug.cgi?id=110716

Reviewed by Alexey Proskuryakov.

No new tests, no functionality changed.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Take AVFInbandTrackParent*

instead of MediaPlayerPrivateAVFoundation*.

(WebCore::InbandTextTrackPrivateAVF::processCue): Pass new cues directly to the client.
(WebCore::InbandTextTrackPrivateAVF::disconnect): m_player -> m_owner.
(WebCore::InbandTextTrackPrivateAVF::setMode): m_player -> m_owner.

• platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::addGenericCue): Delete, no longer needed.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Don't include

CachedResourceClient.h, it isn't needed.

7:38 PM Changeset in webkit [143883] by noel.gordon@gmail.com

• 3 edits in branches/chromium/1410/Source/WebCore

Merge 143363

Update FeatureObserver on top level navigation in addition to page destruction.
​https://bugs.webkit.org/show_bug.cgi?id=109874

Patch by Kassy Coan <​kassycoan@chromium.org> on 2013-02-19
Reviewed by Adam Barth.

No new tests. Only effect is to histogram more frequently.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchDidCommitLoad):

• page/FeatureObserver.cpp:

(WebCore::FeatureObserver::~FeatureObserver):
(WebCore):
(WebCore::FeatureObserver::updateMeasurements):
(WebCore::FeatureObserver::didCommitLoad):

• page/FeatureObserver.h:

(FeatureObserver):

TBR=​commit-queue@webkit.org
Review URL: ​https://codereview.chromium.org/12340046

6:02 PM Changeset in webkit [143882] by kihong.kwon@samsung.com

• 6 edits in trunk

Add an ASSERT to didChangeDeviceProximity
​https://bugs.webkit.org/show_bug.cgi?id=110317

Reviewed by Hajime Morrita.

Source/WebCore:

Add An ASSERT to didChangeDeviceProximity function to check range of value.

Change exist test cases.

• Modules/proximity/DeviceProximityController.cpp:

(WebCore::DeviceProximityController::didChangeDeviceProximity):

LayoutTests:

Fix wrong test cases which are found by ASSERT insertion.

• proximity/basic-operation-expected.txt:
• proximity/basic-operation.html:
• proximity/resources/event-after-navigation-new.html:

4:14 PM Changeset in webkit [143881] by ap@apple.com

• 4 edits in trunk/Source

Clarify meaning of default default encoding localizable string
​https://bugs.webkit.org/show_bug.cgi?id=110714

Reviewed by Eric Carlson.

• English.lproj/Localizable.strings: This string is only used on Windows, and it's very confusing to everyone involved.

2:40 PM Changeset in webkit [143880] by mkwst@chromium.org

• 9 edits
  63 adds in trunk

CSP 1.1: Experiment with 'reflected-xss' directive.
​https://bugs.webkit.org/show_bug.cgi?id=104479

Reviewed by Adam Barth.

Source/WebCore:

Content Security Policy 1.1 defines a 'reflected-xss' directive that
works in much the same way as WebKit's current 'X-XSS-Protection'
header[1]. This patch implements the new directive by parsing it
inside ContentSecurityPolicy, and exposing that state to XSSAuditor.

XSSAuditor now grabs the CSP directive's state, and mixes it with the
X-XSS-Protection header's state to determine how the page should be
handled. Moreover, both headers' states are now expressed in terms of
ContentSecurityPolicy::ReflectedXSSDisposition.

[1]: ​https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#reflected-xss--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html

http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html

• html/parser/XSSAuditor.cpp:

(WebCore::combineXSSProtectionHeaderAndCSP):

Given both headers' states, return the state which the XSSAuditor
should use when parsing a page. Blocking overrides filtering, which
overrides disabling.

(WebCore):
(WebCore::XSSAuditor::init):

Process the 'X-XSS-Protection' header before grabbing the CSP
header's state. Both are passed into the new
combineXSSProtectionHeaderAndCSP method to generate the final
state that ought to be used.

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::filterToken):

• html/parser/XSSAuditor.h:

Switch to ContentSecurityPolicy::ReflectedXSSDisposition internally
in XSSAuditor.

• page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::reflectedXSSDisposition):

Enum defining the possible state of the 'reflected-xss' CSP directive.

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::parseReflectedXSS):

Given a 'reflected-xss' directive's value, set the
ReflectedXSSDisposition into a new property on the CSPDirectiveList.

(WebCore):
(WebCore::CSPDirectiveList::addDirective):

Accept 'reflected-xss' as a valid directive if we're in
experimental mode.

(WebCore::ContentSecurityPolicy::reflectedXSSDisposition):

Expose the directive's state via the public API.

(WebCore::ContentSecurityPolicy::reportInvalidReflectedXSS):

Generate console errors when invalid reflected-xss directive values
are encounted during parsing.

• page/ContentSecurityPolicy.h:
• platform/network/HTTPParsers.cpp:

(WebCore::parseXSSProtectionHeader):

• platform/network/HTTPParsers.h:

(WebCore):

Start using ContentSecurityPolicy::ReflectedXSSDisposition rather
than the XSSProtectionDisposition enum.

LayoutTests:

• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-unset.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-allow.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/1.1/reflected-xss-parsing.html: Added.
• http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js: Added.

(testMixedHeader):
(frameLoaded):
(frameErrored):

• http/tests/security/xssAuditor/resources/echo-intertag.pl:

Added the ability to send an 'X-WebKit-CSP' header to test 'reflected-xss' behavior.

1:11 PM Changeset in webkit [143879] by commit-queue@webkit.org

• 2 edits in trunk

[EFL] Rename ENABLE_REGIONS to ENABLE_CSS_REGIONS
​https://bugs.webkit.org/show_bug.cgi?id=110699

Patch by Laszlo Gombos <Laszlo Gombos> on 2013-02-24
Reviewed by Andreas Kling.

Fix a typo. ENABLE_REGIONS is called ENABLE_CSS_REGIONS
throughout the project.

• Source/cmake/OptionsEfl.cmake:

12:33 PM Changeset in webkit [143878] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit/win

REGRESSION(r143837): Broke build on AppleWin ​http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29.
​https://bugs.webkit.org/show_bug.cgi?id=110713

Unreviewed.

• WebKit.vcproj/WebKitExports.def.in: Add the missing symbol after r143837.

12:31 PM Changeset in webkit [143877] by zandobersek@gmail.com

• 16 edits in trunk/Source/WebCore

Updating GObject bindings baselines after r143863.

Unreviewed.

• bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:

11:51 AM Changeset in webkit [143876] by Lucas Forschler

• 4 edits in tags/Safari-537.31.8/Source/WebCore

Merged r143656. 13281269

11:01 AM Changeset in webkit [143875] by zandobersek@gmail.com

• 5 edits
  1 add
  1 delete in trunk

[GTK] Stop generating UserAgentGtk.h
​https://bugs.webkit.org/show_bug.cgi?id=110582

Reviewed by Martin Robinson.

.:

• configure.ac: Provide the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines in the autotoolsconfig.h

header, containing the user agent versions that are to be used in the user agent string. The
WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION name is avoided as the same defines are specified in the
webkitversion.h API header (but are not accessible from the WebCore layer). The UserAgentGtk.h
header is also not generated anymore from the input file.

Source/WebCore:

No new tests - no new functionality.

• GNUmakefile.list.am: Move the UserAgentGtk.h build target from the derived sources list to

the list of the WebCore platform sources.

• platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent): Rename WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION to
USER_AGENT_GTK_(MAJOR|MINOR)_VERSION.

• platform/gtk/UserAgentGtk.h: Renamed from Source/WebCore/platform/gtk/UserAgentGtk.h.in.

Same as the input file expect for removed WEBKIT_USER_AGENT_(MAJOR|MINOR)_VERSION defines that
are now replaced by using the USER_AGENT_GTK_(MAJOR|MINOR)_VERSION defines placed in autotoolsconfig.h.

10:19 AM Changeset in webkit [143874] by Lucas Forschler

• 2 edits in tags/Safari-537.31.8/Source/WebCore

Merged r143825. <rdar://problem/13258596>

10:16 AM Changeset in webkit [143873] by Lucas Forschler

• 11 edits
  4 copies in tags/Safari-537.31.8

Merged r143821. <rdar://problem/12944761>

10:13 AM Changeset in webkit [143872] by Lucas Forschler

• 4 edits in tags/Safari-537.31.8/Source

Merged r143816. <rdar://problem/13096456>

10:09 AM Changeset in webkit [143871] by Lucas Forschler

• 4 edits in tags/Safari-537.31.8/Source

Versioning.

10:06 AM Changeset in webkit [143870] by Lucas Forschler

• 1 copy in tags/Safari-537.31.8

New Tag.

9:42 AM Changeset in webkit [143869] by kov@webkit.org

• 34 edits in trunk

[GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=110702

Reviewed by Martin Robinson.

Source/WebCore:

No tests. Build fix, no behaviour change.

• platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,

which contains the GTK_API_VERSION_2 define now.

Source/WebKit/gtk:

• tests/testapplicationcache.c: include autotoolsconfig.h.
• tests/testatk.c: ditto.
• tests/testatkroles.c: ditto.
• tests/testcontextmenu.c: ditto.
• tests/testcopyandpaste.c: ditto.
• tests/testdomdocument.c: ditto.
• tests/testdomdomwindow.c: ditto.
• tests/testdomnode.c: ditto.
• tests/testdownload.c: ditto.
• tests/testfavicondatabase.c: ditto.
• tests/testglobals.c: ditto.
• tests/testhittestresult.c: ditto.
• tests/testhttpbackend.c: ditto.
• tests/testkeyevents.c: ditto.
• tests/testloading.c: ditto.
• tests/testmimehandling.c: ditto.
• tests/testnetworkrequest.c: ditto.
• tests/testnetworkresponse.c: ditto.
• tests/testwebbackforwardlist.c: ditto.
• tests/testwebdatasource.c: ditto.
• tests/testwebframe.c: ditto.
• tests/testwebhistoryitem.c: ditto.
• tests/testwebinspector.c: ditto.
• tests/testwebplugindatabase.c: ditto.
• tests/testwebresource.c: ditto.
• tests/testwebsettings.c: ditto.
• tests/testwebview.c: ditto.
• tests/testwindow.c: ditto.

Tools:

• GtkLauncher/main.c: include autotoolsconfig.h.
• Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of

the include ordering check, since it uses autotoolsconfig.h which needs to
come first.

8:45 AM Changeset in webkit [143868] by akling@apple.com

• 8 edits in trunk/Source

StyledElement: Don't expose a mutable direct interface to the inline style.
<​http://webkit.org/b/110711>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove the ability to grab at a mutable StylePropertySet* for a StyledElement's inline style
from the outside world. It's now private and returns MutableStylePropertySet* for future convenience.

Three paths to changing the inline style remain:

• Setting the "style" attribute
• Via CSSOM (element.style)
• setInlineStyleProperty/removeInlineStyleProperty helpers

• dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):

• dom/StyledElement.h:

(StyledElement):

• editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::handleStyleSpans):

• html/canvas/CanvasStyle.cpp:

(WebCore::currentColor):

Source/WebKit/qt:

QWebElement::styleProperty() is a read-only method, so rewrite it to use StyledElement::inlineStyle().

• Api/qwebelement.cpp:

(QWebElement::styleProperty):

8:42 AM Changeset in webkit [143867] by keishi@webkit.org

• 3 edits
  2 adds in trunk

Add methods to date types for new calendar picker
​https://bugs.webkit.org/show_bug.cgi?id=110454

Reviewed by Kent Tamura.

Source/WebCore:

Adding some methods to date types as part of the calendar picker redesign (Bug 109439).

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html

• Resources/pagepopups/calendarPicker.js:

(createUTCDate):
(DateType): Base class for Day, Week and Month.
(Day): Simplified constructor to only accept year, month, date.
(Day.createFromValue): Creates a new Day from a value.
(Day.createFromDate): Throw an error if the given date is invalid.
(Day.createFromDay):
(Day.prototype.equals): Accept non Day objects.
(Day.prototype.previous): Modified to take an offset value.
(Day.prototype.next): Ditto.
(Day.prototype.firstDay): Returns the first day in the range. For Day's case, returns itself.
(Day.prototype.middleDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.lastDay): Returns the middle day in the range. For Day's case, returns itself.
(Day.prototype.valueOf):
(Day.prototype.weekDay): Returns the week day.
(Week): Simplified constructor to only accept year, month, date.
(Week.createFromValue):
(Week.createFromDate):
(Week.createFromDay):
(Week.weekOneStartDateForYear):
(Week.weekOneStartDayForYear):
(Week._numberOfWeeksSinceDate):
(Week.prototype.equals):
(Week.prototype.previous):
(Week.prototype.next):
(Week.prototype.firstDay): Returns the first day in the week.
(Week.prototype.middleDay): Returns the the day for Thursday.
(Week.prototype.lastDay): Returns the last day in the week.
(Week.prototype.valueOf):
(Month):
(Month.createFromValue):
(Month.createFromDate):
(Month.createFromDay):
(Month.prototype.containsDay):
(Month.prototype.equals):
(Month.prototype.previous):
(Month.prototype.next):
(Month.prototype.firstDay): Returns the first day in the month.
(Month.prototype.middleDay): Returns the middle day in the month.
(Month.prototype.lastDay): Returns the last day in the month.
(Month.prototype.valueOf):
(Month.prototype.toLocaleString): Moved location.
(Month.prototype.toShortLocaleString): Returns the month string in short format.
(CalendarPicker): Use createFromValue.
(YearMonthController.prototype.setMonth): Ditto.
(YearMonthController.prototype.moveRelatively): Ditto.

LayoutTests:

• platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types-expected.txt: Added.
• platform/chromium/fast/forms/calendar-picker/calendar-picker-date-types.html: Added. Unit tests for date types.

7:23 AM Changeset in webkit [143866] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] FatFingers: move rectForPoint() from HitTestResult to HitTestLocation
​https://bugs.webkit.org/show_bug.cgi?id=110570

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-02-24
Reviewed by Allan Sandfeld Jensen.

HitTestResult is no longer a HitTestLocation:
​http://trac.webkit.org/changeset/135710/trunk/Source/WebCore/rendering/HitTestResult.h

• WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::fingerRectForPoint):

5:21 AM Changeset in webkit [143865] by morrita@google.com

• 23 edits
  3 copies
  20 adds in trunk

[Custom Elements] Implement bare-bone document.register()
​https://bugs.webkit.org/show_bug.cgi?id=100229

Reviewed by Adam Barth.

Source/WebCore:

This change implements a prefixed version of document.register(), with minimal feature support.

• The feature is guarded by ENABLE(CUSTOM_ELEMENTS) and RuntimeEnabledFeatures::customDOMElementsEnabled().
• This bare-bone version only recognizes "name" and "prototype" parameters. It doesn't support default value of "prototype" parameter.
• Currently only V8 is supported. JSC binding needs its own binding implementation.

Major new classes under dom/:

The dom module gets two new classes:

• CustomElementConstructor: A return value of document.register() which holds the custom element definition.
• CustomElementRegistry: A collection of CustomElementConstructor objects. CustomElementRegistry instance is created per Document and is owned by the Document.

CustomElementConstructor knows the definition of each custom
element, which is registered by document.register(). The name and
other options are held by this object. CustomElementRegistry owns a set
of the registered constructors. The registry guarantees invariants
like validity and uniqueness of the element names.

A change on make_names.pl

This change tweaks make_names.pl (or generated HTMLElementFactory)
to hook the creations of unknown elements. Some of element names
which come to the fallback path can be one of registered custom
element.

[V8WrapAsFunction] extended attribute:

The document.register() API returns a constructor
function. However, the V8 binding currently doesn't support it. To
make it possible, this change introduces "V8WrapAsFunction"
extended attribute for annotating CustomElementConstructor IDL
interface.

V8WrapAsFunction wraps the annotated interface with a JavaScript
function, which calls the original object as a function, or as a
constructor depends on the context.

With this wrapper function, there are two levels of indirection
between native C++ object and author-visible JS function:

[JS Adaptor Function] <-(hidden property)-> [JS Wrapper Object] -(internal field)-> [C++ Native object]

The code generator generates the binding code which deals with
this indirection. Also, there is a set of helper functions in
V8AdaptorFunction.h/cpp which takes care of this indirection.
V8DOMWrapper.cpp/h works as a facade for these APIs and is used from
the generated code.

This redundancy comes from limitations of both V8 bindings and V8
embedding API. See bug 108138 for details.

V8HTMLCustomElement

Unlike built-in HTML elements, any custom element has no
corresponding C++ class. Instead, document.register() should allow
passing a prototype object for the elements being registered.

V8HTMLCustomElement handles this lack of native class. It behaves
like a native side proxy of non-native HTMLElement subclasses. It
connects each custom element to an appropriate native element,
which is HTMLElement at this time. This restriction will be
relaxed later. See Bug 110436 for details.

Custom DOM elements and multiple worlds

In this patch, custom element registration and instantiation is not allowed
in non-main world and document.register() API just fails there.

Reviewed by Adam Barth.

Tests: fast/dom/custom/document-register-basic.html

fast/dom/custom/document-register-reentrant-null-constructor.html
fast/dom/custom/document-register-reentrant-returning-fake.html
fast/dom/custom/document-register-reentrant-throwing-constructor.html

• DerivedSources.make:
• WebCore.gypi:
• bindings/generic/RuntimeEnabledFeatures.cpp:
• bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

• bindings/scripts/IDLAttributes.txt:
• bindings/v8/CustomElementHelpers.cpp: Added.

(WebCore::CustomElementHelpers::initializeConstructorWrapper):
(WebCore::hasNoBuiltinsInPrototype):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::isFeatureAllowed):

• bindings/v8/CustomElementHelpers.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(CustomElementHelpers):

• bindings/v8/V8AdaptorFunction.cpp: Added.

(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::configureTemplate):
(WebCore::V8AdaptorFunction::invocationCallback):
(WebCore::V8AdaptorFunction::wrap):

• bindings/v8/V8AdaptorFunction.h: Added.

(V8AdaptorFunction):
(WebCore::V8AdaptorFunction::unwrap):
(WebCore::V8AdaptorFunction::get):

• bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::configureTemplate):

• bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::toFunction):
(WebCore::V8DOMWrapper::fromFunction):

• bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):

• bindings/v8/V8HTMLCustomElement.cpp: Added.

(WebCore::V8HTMLCustomElement::createWrapper):

• bindings/v8/V8HTMLCustomElement.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(V8HTMLCustomElement):
(WebCore::V8HTMLCustomElement::toV8):
(WebCore::HTMLCustomElement::toV8):

• bindings/v8/V8HiddenPropertyName.h:
• bindings/v8/custom/V8CustomElementConstructorCustom.cpp: Added.

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

• dom/CustomElementConstructor.cpp: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::~CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):

• dom/CustomElementConstructor.h: Copied from Source/WebCore/bindings/v8/V8HiddenPropertyName.h.

(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::tagName):
(WebCore::CustomElementConstructor::name):

• dom/CustomElementConstructor.idl: Added.
• dom/CustomElementRegistry.cpp: Added.

(WebCore::CustomElementRegistry::CustomElementRegistry):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::constructorOf):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):
(WebCore::CustomElementRegistry::document):

• dom/CustomElementRegistry.h: Added.

(CustomElementRegistry):

• dom/Document.cpp:

(WebCore::Document::removedLastRef):
(WebCore::Document::registerElement):
(WebCore::Document::registry):

• dom/Document.h:

(Document):

• dom/make_names.pl:

(printWrapperFactoryCppFile):

• html/HTMLDocument.idl:

Source/WebKit/chromium:

Added enableCustomDOMElements flag.

• features.gypi:
• public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

• src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCustomDOMElements):
(WebKit):
(WebKit::WebRuntimeFeatures::isCustomDOMElementsEnabled):

Tools:

Added enableCustomDOMElements flag.

• DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

• fast/dom/custom/document-register-basic-expected.txt: Added.
• fast/dom/custom/document-register-basic.html: Added.
• fast/dom/custom/document-register-reentrant-null-constructor-expected.txt: Added.
• fast/dom/custom/document-register-reentrant-null-constructor.html: Added.
• fast/dom/custom/document-register-reentrant-returning-fake-expected.txt: Added.
• fast/dom/custom/document-register-reentrant-returning-fake.html: Added.
• fast/dom/custom/document-register-reentrant-throwing-constructor-expected.txt: Added.
• fast/dom/custom/document-register-reentrant-throwing-constructor.html: Added.
• fast/dom/custom/resources/document-register-fuzz.js: Added.
• platform/mac/TestExpectations:

5:18 AM Changeset in webkit [143864] by eustas@chromium.org

• 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Shrink CPU bars to make it easier to see frame information popup.
​https://bugs.webkit.org/show_bug.cgi?id=110561

Reviewed by Pavel Feldman.

Area that causes frame information popup is overly "shaded" by CPU bars.

• inspector/front-end/timelinePanel.css:

(.timeline-cpu-bars .timeline-graph-bar): Reduce height and opacity.

5:01 AM Changeset in webkit [143863] by akling@apple.com

• 26 edits
  3 copies in trunk/Source

Reduce include graph of JSDOMBinding.h
<​http://webkit.org/b/110709>

Reviewed by Antti Koivisto.

Source/WebCore:

Move WebCore::root(Foo*) to the custom JSFooCustom.h headers.
This reduces the number of headers pulled in by JSDOMBinding.h.

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSRuleCustom.cpp:
• bindings/js/JSCSSRuleCustom.h: Added.

(WebCore::root):

• bindings/js/JSCSSRuleListCustom.cpp:
• bindings/js/JSCSSStyleDeclarationCustom.h:

(WebCore::root):

• bindings/js/JSDOMBinding.h:
• bindings/js/JSMediaListCustom.h: Added.

(WebCore::root):

• bindings/js/JSMutationObserverCustom.cpp:
• bindings/js/JSNodeCustom.h:

(WebCore::root):

• bindings/js/JSSVGElementInstanceCustom.cpp:
• bindings/js/JSStyleSheetCustom.h: Added.

(WebCore::root):

• bindings/js/JSTextTrackCustom.h:
• bindings/js/JSTextTrackListCustom.cpp:
• bindings/js/JSXPathResultCustom.cpp:
• bindings/js/SerializedScriptValue.cpp:
• bindings/scripts/CodeGeneratorGObject.pm:

(Generate):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorObjC.pm:

(AddIncludesForType):

• css/CSSRule.idl:
• css/CSSStyleDeclaration.idl:
• css/MediaList.idl:
• css/StyleSheet.idl:
• editing/mac/EditorMac.mm:

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

Source/WebKit2:

• Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

• WebProcess/Storage/StorageAreaProxy.cpp:

12:39 AM Changeset in webkit [143862] by benjamin@webkit.org

• 2 edits in trunk/LayoutTests

Add timeout to the Chromium expectation of state-url-sets-links-visited.html

Unreviewed.

• platform/chromium/TestExpectations: Since Chromium's DRT does not support

computedStyleIncludingVisitedInfo, the test can also timeout as it will
raise an exception before invoking finishJSTest.