⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 2, 2013:

11:31 PM Changeset in webkit [144560] by beidson@apple.com
  • 10 edits in branches/safari-534.59-branch

Merge r143790

2013-02-22 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>


Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
11:13 PM Changeset in webkit [144559] by zandobersek@gmail.com
  • 4 edits in trunk

REGRESSION (r144517): IndexedDB layout test failures on GTK
​https://bugs.webkit.org/show_bug.cgi?id=111243

Reviewed by Martin Robinson.

Source/WebCore:

Changes to the custom JSC bindings for IDBAny are required after r144517,
specifically the case of IDBAny object having the KeyPathType type has to be covered.
These changes are analogous to those made to the V8 bindings in the mentioned commit.

No new tests - already covered by existing tests.

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
(WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.

LayoutTests:

  • platform/gtk/TestExpectations: Removing failure expectations for IDB tests that again pass.
10:59 PM Changeset in webkit [144558] by beidson@apple.com
  • 4 edits
    2 adds in branches/safari-534.59-branch

Merge r142919

2013-02-14 Anders Carlsson <​andersca@apple.com>

Add WKContextIsPlugInUpdateAvailable
​https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
  • WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
10:55 PM Changeset in webkit [144557] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Another try at fixing the build.

10:33 PM Changeset in webkit [144556] by beidson@apple.com
  • 9 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r142017

2013-02-06 Anders Carlsson <​andersca@apple.com>

Pass the document source URL to the pluginLoadPolicy callback
​https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
10:31 PM Changeset in webkit [144555] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix build.

10:24 PM Changeset in webkit [144554] by beidson@apple.com
  • 5 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r141923

2013-02-05 Anders Carlsson <​andersca@apple.com>

WebKit clients should be able to override loading of blocked plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
9:55 PM Changeset in webkit [144553] by Darin Adler
  • 16 edits in trunk/Source

Cut down the number of source files that depend on Clipboard.h
​https://bugs.webkit.org/show_bug.cgi?id=110030

Reviewed by Ryosuke Niwa.

Source/WebCore:

I am doing some work on Clipboard and it's better to recompile 50 files
each time we touch the header instead of 700. Also cut down on includes
of DragState.h.

  • WebCore.exp.in: Updated for new MouseEvent::create function.
  • dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

  • dom/ClipboardEvent.h: Forward declared Clipboard instead of including

Clipboard.h. Also made some overrides private because they can be.

  • dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
  • dom/MouseEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.
(WebCore::MouseEvent::create): Made the create function non-inline
since we can't compile it without including Clipboard.h and we don't
want to include Clipboard.h in the header. This is not so commonly
used or so hot that this needs to be inlined.

  • dom/MouseEvent.h: Forward declared Clipboard instead of including

Clipboard.h. Made MouseEvent::create a non-inline function and also
used overloading instead of default arguments, since we can't compile
a default argument of type PassRefPtr<Clipboard> without including
Clipboard.h.

  • dom/WheelEvent.cpp: Added include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

  • dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used

in this header. Previously we'd get it indirectly from including a header
that included Clipboard.h.

  • editing/Editor.cpp: Added include of Clipboard.h since we use it here

and the world no longer includes it everywhere.

  • inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.

We used to get this indirectly through Clipboard.h.

  • inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h

and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
Also removed unneeded include of <wtf/RefPtr.h>.

  • inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.

We used to get this indirectly through Clipboard.h.

  • loader/PingLoader.cpp: Added include of ResourceResponse.h.

We used to get this indirectly through Clipboard.h.

  • page/DragController.cpp: Added include of DragState.h.

We used to get this indirectly through EventHandler.h

  • page/EventHandler.h: Forward declared DragState and Element instead of

including DragState.h. Also added an include of LayoutPoint.h, which we
used to get indirectly through DragState.h.

Source/WebKit/chromium:

  • src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h

here. We used to get this indirectly through Clipboard.h.

Source/WebKit/mac:

  • WebView/WebPDFView.mm: Add include of Clipboard.h since we use it

here and the world no longer includes it everywhere.

9:47 PM Changeset in webkit [144552] by Darin Adler
  • 13 edits
    1 add in trunk

StringHasher functions require alignment that call sites do not all guarantee
​https://bugs.webkit.org/show_bug.cgi?id=110171

Reviewed by Benjamin Poulain.

Source/WebCore:

  • platform/graphics/WidthCache.h:

(WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
addCharactersAssumingAligned to make sure we don't slow this call site down.
It's safe since this code always adds characters two at a time.

Source/WTF:

The StringHasher class is optimized for clients who pass it two characters at
a time. However, the function named addCharacters did not make this clear to
clients, and one calculateStringHashAndLengthFromUTF8MaskingTop8Bits got it wrong.
Fix by making addCharacters work regardless of hasher alignment and adding a new
function, addCharactersAssumingAligned, for use when we want a faster path and can
guarantee we are adding characters two at a time.

  • wtf/StringHasher.h:

(WTF::StringHasher::addCharactersAssumingAligned): Renamed the addCharacters function
addCharactersAssumingAligned, since it only works if the hasher is currently aligned,
meaning it contains an even number of characters. The function already asserts
that this is true, but the calculateStringHashAndLengthFromUTF8MaskingTop8Bits
function was using it in cases where the assertion could fire. Also updated to
call addCharactersInternal by its new name. Also added some new overloads that take
data pointers and lengths so callers can always use addCharactersAssumingAligned
instead of addCharacters if they know the hasher is aligned.
(WTF::StringHasher::addCharacter): Updated to call the public
addCharactersAssumingAligned function since that's simpler and a bit cleaner.
(WTF::StringHasher::addCharacters): Added functions with this name that handle
the case where the hasher is not aligned. These will be called by existing call sites
that were formerly using the function named addCharactersAssumingAligned above.
Also add an overload that works with the default converter automatically.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Changed to call
addCharactersAssumingAligned to eliminate copied and pasted code. The hasher is empty,
so definitely aligned.
(WTF::StringHasher::computeHash): Ditto.
(WTF::StringHasher::addCharactersInternal): Renamed from addCharactersToHash, since
the former name did not make clear how this differs from the public functions.
The real difference is that this is like addCharactersAssumingAligned, but without
the assertion, so addCharactersAssumingAligned is called instead, even within the
class's implementation.

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.gypi:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/WTF.pro:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:

Added the StringHasher.cpp file.

  • TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests

for the functions in the StringHasher class.

8:05 PM Changeset in webkit [144551] by beidson@apple.com
  • 19 edits
    1 add in branches/safari-534.59-branch

Merge r141486

2013-01-31 Brian Weinstein <​bweinstein@apple.com>

Add a call to the page UI client to determine if a plug-in should load
​https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>

Source/WebKit2:

Reviewed by Anders Carlsson.

This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.

  • UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to

m_uiClient.shouldInstantiatePlugin.

  • UIProcess/WebPageProxy.h:
  • UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if

the client function isn't defined, and call the function if it is.

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new

client function.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy. (WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and

send the message to the WebPageProxy, not the WebProcessProxy.

  • WebProcess/WebPage/WebPage.h:

Tools:

Add entries for the new function in the necessary structs.

Reviewed by Anders Carlsson.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
6:53 PM Changeset in webkit [144550] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit2 is missing the setShowsURLsInToolTips preference
​https://bugs.webkit.org/show_bug.cgi?id=111259
<rdar://problem/12991891>

Reviewed by Maciej Stachowiak.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShowsURLsInToolTipsEnabled):
(WKPreferencesGetShowsURLsInToolTipsEnabled):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Pipe it through.

5:45 PM Changeset in webkit [144549] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

XSSAuditor has a subtle race condition when used with the threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=111253

Reviewed by Eric Seidel.

We were refing and derefing a StringImpl for a main-thread
AtomicString. Using QualifiedNames on the background thread is very
fragile and we should figure out a more robust solution.

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):

4:57 PM Changeset in webkit [144548] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Export a missing symbol after r144547.

Unreviewed.

  • WebKit.vcproj/WebKitExports.def.in:
4:08 PM Changeset in webkit [144547] by benjamin@webkit.org
  • 47 edits in trunk

Move computedStyleIncludingVisitedInfo from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=109772

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-02
Reviewed by Andreas Kling.

Source/WebCore:

The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
it is better defined on Internals than on TestRunner.

  • testing/Internals.cpp:

(WebCore::Internals::computedStyleIncludingVisitedInfo):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/blackberry:

  • WebKitSupport/DumpRenderTreeSupport.cpp:
  • WebKitSupport/DumpRenderTreeSupport.h:

(DumpRenderTreeSupport):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests.

  • fast/history/multiple-classes-visited.html:
  • fast/history/nested-visited-test.html:
  • fast/history/self-is-visited.html:
  • fast/history/sibling-visited-test.html:
  • fast/loader/stateobjects/state-url-sets-links-visited.html:
  • platform/win/TestExpectations: unskip the tests.
  • platform/chromium/TestExpectations:
3:42 PM Changeset in webkit [144546] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
<​http://webkit.org/b/106059>

Fixes the following build failure:

Undefined symbols for architecture armv7:

"ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:

-[WebFrame javaScriptContext] in WebFrame.o
ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o

ld: symbol(s) not found for architecture armv7

  • WebCore.exp.in: Export ScriptController::javaScriptContext()

even more unconditionally.

3:36 PM Changeset in webkit [144545] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r143637): Predeclare JSContext as an Objective-C class
<​http://webkit.org/b/106059>

Fixes the following build failure:

In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:215:64: error: expected a type

  • (void)webView:(WebView *)webView didCreateJavaScriptContext:(JSContext *)context forFrame:(WebFrame *)frame;


1 error generated.

  • WebView/WebFrameLoadDelegate.h: Add @class JSContext

declaration.

1:06 PM Changeset in webkit [144544] by eric@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove two unnecessary mallocs from the main-thread-parser code path
​https://bugs.webkit.org/show_bug.cgi?id=111249

Reviewed by Adam Barth.

I noticed these while fixing up our Vector -> String conversions
but never went back to fix the FIXME.

AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
if the represented string is already in the AtomicString table. It
also handles 8bit vs. 16bit and empty() just like nameString() does.

I also removed a 3rd caller to nameString() in the XSSAuditor which
was causing an unnecessary malloc in both the main and background
thread parser paths.

  • html/parser/AtomicHTMLToken.h:

(WebCore::AtomicHTMLToken::AtomicHTMLToken):

  • html/parser/HTMLToken.h:
  • html/parser/XSSAuditor.cpp:

(WebCore):
(WebCore::threadSafeMatch):
(WebCore::hasName):

10:09 AM Changeset in webkit [144543] by eric@webkit.org
  • 2 edits in trunk/Source/WebCore

constructTreeFromCompactHTMLToken should call clearExternalCharacters
​https://bugs.webkit.org/show_bug.cgi?id=111248

Reviewed by Adam Barth.

I don't know how to write a test for this. It's possible characters()
is never accessed from HTMLStackItem::token(), but it's better to be
safe than sorry here.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):

7:02 AM Changeset in webkit [144542] by rwlbuis@webkit.org
  • 3 edits
    2 adds in trunk

Text overflow ellipsis wrong color when using webkit-text-fill-color
​https://bugs.webkit.org/show_bug.cgi?id=54841

Reviewed by David Hyatt.

Source/WebCore:

Take -webkit-text-fill-color into account for ellipsis painting.

Test: fast/css/text-overflow-ellipsis-color.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

LayoutTests:

Add reftest for using -webkit-text-fill-color in combination with text-overflow:ellipsis.

  • fast/css/text-overflow-ellipsis-color-expected.html: Added.
  • fast/css/text-overflow-ellipsis-color.html: Added.
6:39 AM Changeset in webkit [144541] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Unskip some passing tests.

  • platform/efl/TestExpectations: Remove tests that pass after

r140006 and r139217.

4:36 AM Changeset in webkit [144540] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebKit/win

Redo r144538 (after r144530).

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebPlatformStrategies.cpp:
3:59 AM Changeset in webkit [144539] by tkent@chromium.org
  • 10 edits in branches/chromium/1410

Merge 144352

REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
​https://bugs.webkit.org/show_bug.cgi?id=110974

Reviewed by Kentaro Hara.

Source/WebCore:

Input elements with the multiple fields UI require flexible box
layout.

  • If display:inline or display:inline-block is specified, we replace it with display:inline-flex.
  • If display:block is specified, we replace it with display:flex.
  • If other display value is specified, we use it as is, but it won't wrap inside an input element because we have display:inline-block for ::-webkit-calendar-pixker-indicaotor.

r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.

Tests: Update fast/forms/date/date-apparance-basic.html

  • css/html.css:

(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.

  • html/InputType.cpp:

(WebCore::InputType::customStyleForRenderer): Added.

  • html/InputType.h:

(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.

LayoutTests:

  • fast/forms/date/date-appearance-basic-expected.txt:
  • fast/forms/date/date-appearance-basic.html:
  • platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:

TBR=​tkent@chromium.org
BUG=crbug.com/178175

2:14 AM Changeset in webkit [144538] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/win

Yet another build fix attempt after r144530.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
  • WebCoreSupport/WebPlatformStrategies.cpp:
1:54 AM Changeset in webkit [144537] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Another build fix attempt after r144530.

  • WebCoreSupport/WebFrameNetworkingContext.cpp:
1:07 AM Changeset in webkit [144536] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a typo in my previous commit (r144534).

  • platform/win/PasteboardWin.cpp:
1:02 AM Changeset in webkit [144535] by nayankk@motorola.com
  • 22 edits
    2 copies
    5 adds in trunk

[WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
​https://bugs.webkit.org/show_bug.cgi?id=110818

Reviewed by Kenneth Russell.

As per OES_texture_half_float specification texImage2D and texSubImage2D entry
points taking ArrayBufferView should extended to accept null with the pixel type
HALF_FLOAT_OES.

Source/WebCore:

Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html

fast/canvas/webgl/oes-texture-half-float.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::getName):
(WebCore::OESTextureHalfFloat::create):

  • html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(OESTextureHalfFloat):

  • html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/Extensions3D.h:

(Extensions3D):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/GraphicsTypes3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::texImage2D):

LayoutTests:

  • fast/canvas/webgl/constants.html:
  • fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-not-supported.html: Added.
  • fast/canvas/webgl/oes-texture-half-float.html: Added.
12:57 AM Changeset in webkit [144534] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Windows build fix attempt after r144530.

  • platform/win/PasteboardWin.cpp:

Mar 1, 2013:

11:52 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
(diff)
11:51 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Update roadmap (diff)
11:46 PM Changeset in webkit [144533] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix the build after r144530.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Include the header for the

base class.

11:00 PM Changeset in webkit [144532] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for IndexedDB tests

that regressed on platforms using JavaScriptCore with r144517.

10:41 PM Changeset in webkit [144531] by tdanderson@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove unused member variable m_useLatchedEventNode from PlatformWheelEvent.h
​https://bugs.webkit.org/show_bug.cgi?id=107314

Reviewed by Darin Adler.

EventHandler::handleGestureScrollCore() was removed in ​http://trac.webkit.org/changeset/140177,
and this was the only place where the member variable |m_useLatchedEventNode| in
PlatformWheelEvent was mutated. This variable is no longer needed and so it should be removed.

No change in behavior, so no new tests needed.

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::useLatchedEventNode):
(PlatformWheelEvent):

10:36 PM Changeset in webkit [144530] by ap@apple.com
  • 208 edits
    7 adds in trunk/Source

Reduce amount of rebuilding when touching networking headers
​https://bugs.webkit.org/show_bug.cgi?id=111035

Reviewed by Eric Seidel.

This uses a number of common unsurprising techniques. One interesting observation
is that including CachedResource related headers is very expensive. We can usually
get away with their Client counterparts, and with CachedResourceHandle.

  • page/Frame.cpp:
  • page/Frame.h: Don't include FrameLoader, greatly reducing include graph for most non-loader files. This required making Frame::init() non-inline - I'm not sure why it ever was.
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h: Even though FrameLoader is logically on loading side of WebCore, it's included in too many places. Not including PolicyChecker.h and ResourceHandle.h was among the largest wins. As a future improvement, we should probably convert other members to OwnPtrs.
  • css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
  • loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h, not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
  • loader/cache/CachedFont.h:
  • loader/cache/CachedFontClient.h: Added.
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedRawResourceClient.h: Added.
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGDocumentClient.h: Added. These types were defining client types in the same headers, making it impossible to avoid including networking headers through CachedResource. Moved clients into separate files.
  • plugins/PluginStream.h:
  • plugins/PluginStreamClient.h: Added. Similar situation here.
  • loader/cache/CachedResourceHandle.cpp:
  • loader/cache/CachedResourceHandle.h: Moved functions that need to know about CachedResource to .cpp file. This is another huge win. Added a destructor, so that CachedResource woudn't be needed in all files that include CachedResourceHandle.
  • loader/cache/CachedSVGDocumentReference.cpp: Added.
  • loader/cache/CachedSVGDocumentReference.h: Moved constructor and virtual function implementations to a .cpp file - they need not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h: Avoid including CachedSVGDocumentReference.h. This is not such a big win now that CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly rendering code that it seems best to cut any ties with resources and loading. Added a virtual destrutor in .cpp file, because inline destructors in polymorphic classes are generally harmful (due to code bloat).
  • plugins/PluginRequest.h: Added.
  • plugins/PluginView.h: Moved PluginRequest into a separate file, it was out of place in a view hierarchy class file.
  • rendering/RenderImageResource.cpp:
  • rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. Thre is no win from having them inline, and now we don't need CachedImage.h in the header.
  • rendering/style/StyleCustomFilterProgram.cpp: Added.
  • rendering/style/StyleCustomFilterProgram.h: Ditto.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:
  • dom/Clipboard.cpp:
  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:
  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:
  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/MemoryCache.cpp:
  • loader/cache/MemoryCache.h:
  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/DragController.cpp:
  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginView.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp: Many self-evident changes - removing unnecessary header includes, adding smaller more local ones that are now necessary.
10:14 PM Changeset in webkit [144529] by hyatt@apple.com
  • 4 edits
    6 adds in trunk

[New Multicolumn] Transformed objects inside fragmented transparent objects don't render
​https://bugs.webkit.org/show_bug.cgi?id=111221.

Reviewed by Simon Fraser.

Source/WebCore:

Improve transparencyClipBox so that it understands when moving into descendants
that it does in fact have to break up the transformed clip rect across the
fragments.

Make sure when handling fragmented transforms using multiple paints that
the test that determines the extent of the transform within the fragments
uses transparencyClipBox. This gives us an accurate set of columns that the
final transformed result will paint across.

Tests: fast/multicol/mixed-opacity-fixed-test.html

fast/multicol/mixed-opacity-test.html
fast/multicol/transform-inside-opacity.html

  • rendering/RenderLayer.cpp:

(WebCore::transparencyClipBox):
(WebCore::expandClipRectForDescendantsAndReflection):
Break transformed boxes up into fragments when they are
being requested by an ancestor.

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):

  • rendering/RenderLayer.h:

(RenderLayer):
Modify collectFragments so that we pass in the correct range
within the columns that can possibly cover the fragmented
transformed box.

LayoutTests:

  • fast/multicol/mixed-opacity-fixed-test-expected.html: Added.
  • fast/multicol/mixed-opacity-fixed-test.html: Added.
  • fast/multicol/mixed-opacity-test-expected.html: Added.
  • fast/multicol/mixed-opacity-test.html: Added.
  • fast/multicol/transform-inside-opacity-expected.html: Added.
  • fast/multicol/transform-inside-opacity.html: Added.
9:53 PM Changeset in webkit [144528] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove call to set task priority of WebKit2 processes on Mac
​https://bugs.webkit.org/show_bug.cgi?id=111239

Patch by Kiran Muppala <​cmuppala@apple.com> on 2013-03-01
Reviewed by Darin Adler.

Remove call to set task prioirty of WebKit2 processes on Mac as it
is no longer necessary.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize): Remove call to setpriority().

9:23 PM Changeset in webkit [144527] by loislo@chromium.org
  • 11 edits in trunk

Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
​https://bugs.webkit.org/show_bug.cgi?id=110943

Reviewed by Yury Semikhatsky.

Unfortunately in many cases raw pointer may point to an object that has been deleted.
There is no working solution to solve this problem in general.
It could be solved only on case by case basis.

Source/WebCore:

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportLeaf):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::FrameData::reportMemoryUsage):

  • platform/graphics/skia/MemoryInstrumentationSkia.cpp:

(reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(WTF::MemoryInstrumentation::addObject):
(WTF::MemoryInstrumentation::MemberTypeTraits::addObject):
(WTF::MemoryClassInfo::addMember):
(WTF::MemoryInstrumentation::addObjectImpl):

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

Tools:

  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:

(TestWebKitAPI::TEST):

9:18 PM Changeset in webkit [144526] by haraken@chromium.org
  • 9 edits
    2 adds in trunk

Style recalculation takes too long when adding whitespace text nodes
​https://bugs.webkit.org/show_bug.cgi?id=110786

Reviewed by Darin Adler.

Source/WebCore:

This takes 216 msec.
for (var i = 0; i < 1500; ++i) {

document.body.appendChild(document.createTextNode('x'));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode('x'));

}

But this takes 25.3 seconds.
for (var i = 0; i < 1500; ++i) {

document.body.appendChild(document.createTextNode(' '));
document.body.appendChild(document.createElement('div'));
document.body.appendChild(document.createTextNode(' '));

}

The reason is that we do not create renderers for empty text
nodes and thus we are hitting the worst O(N2) case in Node::attach().
(See FIXME in Node::attach().)

This patch adds a logic to bail out the loop to avoid the O(N2) case.
Specifically, the patch bails out the loop if we encounter a text node
for which we again decided not to create a renderer. This bail out is
reasonable because the fact that we again decided not to create a renderer
for the text node indicates that there will be no affect of the result
of Text::textRendererIsNeeded() of the rest of the sibling nodes.

Performance test: ​https://bugs.webkit.org/attachment.cgi?id=190545
Performance result in Chromium/Linux: 25.3 sec => 48 msec !

Test: perf/append-text-nodes-without-renderers.html (for performance)

fast/dynamic/create-renderer-for-whitespace-only-text.html (for correctness)

The loop was introduced in r29054. We have to make sure that
all layout tests that were updated in r29054 pass with this patch.
See ​http://trac.webkit.org/changeset/29054.

  • dom/Node.cpp:

(WebCore::Node::attach):

LayoutTests:

  • fast/html/details-nested-2-expected.txt: Sometimes anonymous blocks are left without

being cleaned up (for some reason). With this patch, one anonymouse block is removed at
the clean-up phase (for some reason). Anyway the new behavior is an expected behavior.

  • platform/chromium-mac/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/chromium-win/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/efl/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/mac/fast/html/details-nested-2-expected.txt: Ditto.
  • platform/qt/fast/html/details-nested-2-expected.txt: Ditto.
  • perf/append-text-nodes-without-renderers-expected.txt: Added. For performance test.
  • perf/append-text-nodes-without-renderers.html: Added. Ditto.
9:17 PM Changeset in webkit [144525] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Add a missing symbol after r144524.

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-03-01

  • WebKit.vcproj/WebKitExports.def.in:
9:06 PM Changeset in webkit [144524] by commit-queue@webkit.org
  • 40 edits in trunk

Source/WebCore: Moved markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

TestRunner framework is an old way of testing webkit, it would be
better to incorporate the testing frame directly into the WebCore itself
as to make it more compatible with WK2.

  • testing/Internals.cpp:

(WebCore::Internals::markerTextForListItem):
(WebCore):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/efl: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

Source/WebKit/qt: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests: Move markerTextForListItem from TestRunner to Internals
​https://bugs.webkit.org/show_bug.cgi?id=110939

Patch by Jason Anderssen <​janderssen@gmail.com> on 2013-03-01
Reviewed by Benjamin Poulain.

  • fast/lists/resources/dump-list.js:

(dumpListItemAsHTML):
(testListItemMarkerEqualsListItemText):

  • fast/lists/w3-css3-list-styles-numeric.html:
7:44 PM Changeset in webkit [144523] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r185662. Requested by
"James Robinson" <​jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

  • DEPS:
6:35 PM Changeset in webkit [144522] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk

Don't leak Documents when using MutationObserver from extensions
​https://bugs.webkit.org/show_bug.cgi?id=111234

Patch by Elliott Sprehn <Elliott Sprehn> on 2013-03-01
Reviewed by Adam Barth.

.:

  • ManualTests/leak-observer-nonmain-world.html: Added.

Source/WebCore:

MutationObserverCallback holds a WorldContextHandle which secretly isn't
a handle to anything when it's for the main world. When it's for a non-main
world though, like those used in extensions, it becomes a strong reference
to the v8::Context which results in leaks by creating cycles:

MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.

Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
get the v8::Context from that inside handleEvent.

Tests: ManualTests/leak-observer-nonmain-world.html

  • bindings/v8/V8Binding.cpp:

(WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.

  • bindings/v8/V8Binding.h:
  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):

  • bindings/v8/V8MutationCallback.h:

(V8MutationCallback):

5:31 PM Changeset in webkit [144521] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

BUILD FIX: testapi should link to Foundation, not CoreFoundation

link to Foundation.framework instead of CoreFoundation.framework
since it uses NS types.

5:16 PM Changeset in webkit [144520] by betravis@adobe.com
  • 6 edits in trunk/Source/WebCore

[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
​https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.

  • rendering/RenderBlock.h:

(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

5:08 PM Changeset in webkit [144519] by tdanderson@chromium.org
  • 15 edits
    4 copies
    8 adds in trunk

EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
​https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html

fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):

By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.

(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):

  • page/EventHandler.h:

(EventHandler):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

  • fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
  • fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
  • fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
  • fast/events/touch/gesture/touch-gesture-scroll-page.html:

I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.

  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
  • platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.

These four new layout tests verify that a non-scrollable body will not scroll,
as reported in ​https://bugs.webkit.org/show_bug.cgi?id=109316.

5:05 PM Changeset in webkit [144518] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
​https://bugs.webkit.org/show_bug.cgi?id=111232

Patch by David Dorwin <​ddorwin@chromium.org> on 2013-03-01
Reviewed by Adam Barth.

This patch reverts r143827, which causes a crash in failure conditions:
​http://crbug.com/178848

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::destoryPage):

5:04 PM Changeset in webkit [144517] by alecflett@chromium.org
  • 4 edits in trunk/Source/WebCore

IndexedDB: Avoid ScriptValue copies in IDBAny
​https://bugs.webkit.org/show_bug.cgi?id=111002

Reviewed by Adam Barth.

This avoids some v8 handle thrashing in the long term,
and protects us against some crashes in the short term.

The crashes will be fixed in
​https://bugs.webkit.org/show_bug.cgi?id=110206.

  • Modules/indexeddb/IDBAny.cpp:

(WebCore::IDBAny::createNull):
(WebCore::IDBAny::createString):
(WebCore::IDBAny::IDBAny):
(WebCore::IDBAny::scriptValue):

  • Modules/indexeddb/IDBAny.h:

(WebCore::IDBAny::create):
(IDBAny):
(WebCore::IDBAny::keyPath):

  • bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8):
(WebCore):

5:01 PM Changeset in webkit [144516] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
5:00 PM Changeset in webkit [144515] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream smart selection
​https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <​shuwu@rim.com> on 2013-03-01
Reviewed by Rob Buis.

  1. Extend the touch hold text selection to next paragraph.
  2. Draw and expand overlay over text as touch hold selection expands.

Select paragraph when it's entirely covered by overlay.

  1. Start scrolling at a constant rate when the end of

next pargraph is not in the viewport.

Reviewed Internally By Genevieve Mak and Mike Fenton.
PR 217897 238485 258279 279042 299779

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPage::expandSelection):
(WebKit):
(BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):

  • Api/WebPage.h:
  • Api/WebPageClient.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::isInvalidLine):
(WebKit):
(BlackBerry::WebKit::isInvalidParagraph):
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::drawOverlay):
(BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):

4:55 PM Changeset in webkit [144514] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
3:46 PM Changeset in webkit [144513] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

  • platform/win/TestExpectations:
3:22 PM Changeset in webkit [144512] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
​https://bugs.webkit.org/show_bug.cgi?id=111224

  • platform/chromium/TestExpectations:
3:05 PM Changeset in webkit [144511] by beidson@apple.com
  • 14 edits in branches/safari-536.29-branch

Merge 143988

2013-02-25 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.


  • UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.


  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

  • UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.

Tools:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
  • WebKitTestRunner/TestController.h: (TestController):
2:55 PM Changeset in webkit [144510] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Don't use legacy test names when returning results from PerfTest.run
​https://bugs.webkit.org/show_bug.cgi?id=111148

Reviewed by Dirk Pranke.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.name): Renamed from metric.
(PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
(PerfTest.run): Use metric name instead of the legacy name to store iteration values.
(ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_time_metric):
(TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.init):
(PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
to obtain the trac URL instead of hard coding it.
(PerfTestsRunner._run_tests_set):

2:53 PM Changeset in webkit [144509] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark more flaky tests related to scrollbar ordering
​https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

  • platform/chromium/TestExpectations:
2:42 PM Changeset in webkit [144508] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Support padding, margin and border for internal UA cue styling
​https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Note: This patch is identical to the previously commited one,
as it was rolled back without related tests failing.

Test: media/track/track-cue-rendering-with-padding.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Added.
  • media/track/track-cue-rendering-with-padding.html: Added.
2:39 PM Changeset in webkit [144507] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r125809): CFStrings created via StringImpl::createCFString() might reference freed memory when Objective-C garbage collection is enabled
​https://bugs.webkit.org/show_bug.cgi?id=111219

Reviewed by Benjamin Poulain.

StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
order to create CFString without making an unnecessary copy. In order
to ensure that the the StringImpl's backing buffer isn't deallocated
while the CFString is still alive, we use a custom CFAllocator to
ref/deref the StringImpl at the appropriate times.

However, custom allocators aren't supported when Objective-C garbage
collection is enabled, so in this case we use the default CF allocator.
Since we can't guarantee the lifetime of the StringImpl in this case,
we should just fall back to copying the string, as we did prior to r125809.

  • platform/text/cf/StringImplCF.cpp:

(garbageCollectionEnabled): Moved the check for whether garbage
collection is enabled from StringWrapperCFAllocator::create() to here.
(WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
(WTF::StringImpl::createCFString): If garbage collection is enabled,
call the variants of CFStringCreate that copy the string.

2:38 PM Changeset in webkit [144506] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Expose more of the configuration step to the gyp build
​https://bugs.webkit.org/show_bug.cgi?id=111213

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Expose more of the configuration phase to the gyp build, including WebKit features
and binary paths.

  • gyp/Configuration.gypi.in: Add templatized gyp variables for the new configuration bits.
  • gyp/autogen.sh: Properly link up the WebKit features script. So we can access it

relatively as if we were at the top-level of the source directory.

  • gyp/configure.ac: Export the WebKit features.
2:26 PM Changeset in webkit [144505] by beidson@apple.com
  • 13 edits in branches/safari-536.29-branch

Merge 143976

2013-02-25 Anders Carlsson <​andersca@apple.com>

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
2:22 PM Changeset in webkit [144504] by Chris Fleizach
  • 1 edit
    68 adds in trunk/LayoutTests

AX: Upstream iOS Accessibility layout tests
​https://bugs.webkit.org/show_bug.cgi?id=111187

Reviewed by David Kilzer.

Upstream the latest iOS Accessibility layout tests.

  • platform/iphone-simulator: Added.
  • platform/iphone-simulator/accessibility: Added.
  • platform/iphone-simulator/accessibility/accessibility-aria-table-children-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-aria-table-children.html: Added.
  • platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer.html: Added.
  • platform/iphone-simulator/accessibility/accessibility-hint-expected.txt: Added.
  • platform/iphone-simulator/accessibility/accessibility-hint.html: Added.
  • platform/iphone-simulator/accessibility/aria-pressed-state-expected.txt: Added.
  • platform/iphone-simulator/accessibility/aria-pressed-state.html: Added.
  • platform/iphone-simulator/accessibility/centerpoint-expected.txt: Added.
  • platform/iphone-simulator/accessibility/centerpoint.html: Added.
  • platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element-expected.txt: Added.
  • platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element.html: Added.
  • platform/iphone-simulator/accessibility/focus-change-notifications-expected.txt: Added.
  • platform/iphone-simulator/accessibility/focus-change-notifications.html: Added.
  • platform/iphone-simulator/accessibility/header-elements-expected.txt: Added.
  • platform/iphone-simulator/accessibility/header-elements.html: Added.
  • platform/iphone-simulator/accessibility/identifier-expected.txt: Added.
  • platform/iphone-simulator/accessibility/identifier.html: Added.
  • platform/iphone-simulator/accessibility/internal-link-expected.txt: Added.
  • platform/iphone-simulator/accessibility/internal-link.html: Added.
  • platform/iphone-simulator/accessibility/link-with-images-text-expected.txt: Added.
  • platform/iphone-simulator/accessibility/link-with-images-text.html: Added.
  • platform/iphone-simulator/accessibility/link-with-only-image-expected.txt: Added.
  • platform/iphone-simulator/accessibility/link-with-only-image.html: Added.
  • platform/iphone-simulator/accessibility/math-expected.txt: Added.
  • platform/iphone-simulator/accessibility/math.html: Added.
  • platform/iphone-simulator/accessibility/mixed-checkboxes-expected.txt: Added.
  • platform/iphone-simulator/accessibility/mixed-checkboxes.html: Added.
  • platform/iphone-simulator/accessibility/no-child-link-header-expected.txt: Added.
  • platform/iphone-simulator/accessibility/no-child-link-header.html: Added.
  • platform/iphone-simulator/accessibility/non-contiguous-link-expected.txt: Added.
  • platform/iphone-simulator/accessibility/non-contiguous-link.html: Added.
  • platform/iphone-simulator/accessibility/password-value-expected.txt: Added.
  • platform/iphone-simulator/accessibility/password-value.html: Added.
  • platform/iphone-simulator/accessibility/placeholder-value-expected.txt: Added.
  • platform/iphone-simulator/accessibility/placeholder-value.html: Added.
  • platform/iphone-simulator/accessibility/popup-button-value-label-expected.txt: Added.
  • platform/iphone-simulator/accessibility/popup-button-value-label.html: Added.
  • platform/iphone-simulator/accessibility/radio-button-expected.txt: Added.
  • platform/iphone-simulator/accessibility/radio-button.html: Added.
  • platform/iphone-simulator/accessibility/secure-text-field-expected.txt: Added.
  • platform/iphone-simulator/accessibility/secure-text-field.html: Added.
  • platform/iphone-simulator/accessibility/selected-buttons-expected.txt: Added.
  • platform/iphone-simulator/accessibility/selected-buttons.html: Added.
  • platform/iphone-simulator/accessibility/selected-text-expected.txt: Added.
  • platform/iphone-simulator/accessibility/selected-text.html: Added.
  • platform/iphone-simulator/accessibility/tab-role-expected.txt: Added.
  • platform/iphone-simulator/accessibility/tab-role.html: Added.
  • platform/iphone-simulator/accessibility/table-cell-for-row-col-expected.txt: Added.
  • platform/iphone-simulator/accessibility/table-cell-for-row-col.html: Added.
  • platform/iphone-simulator/accessibility/table-cell-ranges-expected.txt: Added.
  • platform/iphone-simulator/accessibility/table-cell-ranges.html: Added.
  • platform/iphone-simulator/accessibility/tables-lists-expected.txt: Added.
  • platform/iphone-simulator/accessibility/tables-lists.html: Added.
  • platform/iphone-simulator/accessibility/text-line-no-ignored-elements-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-line-no-ignored-elements.html: Added.
  • platform/iphone-simulator/accessibility/text-marker-list-item-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-marker-list-item.html: Added.
  • platform/iphone-simulator/accessibility/text-marker-validation-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-marker-validation.html: Added.
  • platform/iphone-simulator/accessibility/text-role-expected.txt: Added.
  • platform/iphone-simulator/accessibility/text-role.html: Added.
  • platform/iphone-simulator/accessibility/textfield-in-axvalue-expected.txt: Added.
  • platform/iphone-simulator/accessibility/textfield-in-axvalue.html: Added.
  • platform/iphone-simulator/accessibility/url-test-expected.txt: Added.
  • platform/iphone-simulator/accessibility/url-test.html: Added.
2:14 PM Changeset in webkit [144503] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed AppleWin build fix.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

2:03 PM Changeset in webkit [144502] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/WebCore

[GTK] Allow sharing the WebCore include list with the Chromium build
​https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

  • WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
  • WebCore.gypi: Added shared include directories.
2:02 PM Changeset in webkit [144501] by beidson@apple.com
  • 11 edits in branches/safari-536.29-branch/Source

Merge 143815

2013-02-22 Anders Carlsson <​andersca@apple.com>

pluginLoadStrategy should take a WKDictionaryRef for extensibility
​https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

Source/WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

Source/WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
2:02 PM Changeset in webkit [144500] by roger_fong@apple.com
  • 1 edit
    5 adds in trunk/Tools

Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
​https://bugs.webkit.org/show_bug.cgi?id=111202

This is useful for running VCExpress builds from command line because there is
no unified solution output, only per project build logs.
The project will be run as the last project in the solution.

  • win/AssembleBuildLogs: Added.
  • win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
  • win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
  • win/AssembleBuildLogs/AssembleLogs.cmd: Added.
  • win/AssembleBuildLogs/README: Added.
2:00 PM Changeset in webkit [144499] by ap@apple.com
  • 11 edits
    8 adds in trunk/Source

Make in-memory blobs work in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=111132

Reviewed by Sam Weinig.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::registerBlobURL): (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL): (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
  • NetworkProcess/NetworkConnectionToWebProcess.h: Implement BlobRegistry interface by using BlobRegistryImpl (same one as used in WebProcess in non-PPT mode).
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Added three messages needed for BlobRegistry.
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcessPlatformStrategies.cpp: Added.
  • NetworkProcess/NetworkProcessPlatformStrategies.h: Added. Added a mostly empty platform strategy, just for FormData to talk to BlobRegistry. Perhaps we'll find a way to avoid this WebCore code path in NetworkProcess, because we obviously know which registry implementation is in use in this process.
  • Shared/FileAPI: Added.
  • Shared/FileAPI/BlobRegistrationData.cpp: Added.
  • Shared/FileAPI/BlobRegistrationData.h: Added. Added a class for passing BlobData and extension handles over IPC. This uses a trick with mutable a member to avoid copying decoded BlobStorageData.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/FileAPI: Added.
  • WebProcess/FileAPI/BlobRegistryProxy.cpp: Added.
  • WebProcess/FileAPI/BlobRegistryProxy.h: Added. A proxy implementation of BlobRegistry that just sends requests over IPC. We only need async ones.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::createBlobRegistry):
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h: Create an appropriate BlobRegistry.
1:53 PM Changeset in webkit [144498] by eric@webkit.org
  • 19 edits in trunk/Source

Threaded HTML Parser has an extra copy of every byte from the network
​https://bugs.webkit.org/show_bug.cgi?id=111135

Reviewed by Adam Barth.

Source/WebCore:

Every LayoutTest executes this code in threaded parsing mode.

  • dom/DecodedDataDocumentParser.cpp:

(WebCore::DecodedDataDocumentParser::appendBytes):

  • Pass ownership of the decoded string to the parser.

(WebCore::DecodedDataDocumentParser::flush):

  • Same.
  • dom/DecodedDataDocumentParser.h:

(DecodedDataDocumentParser):

  • dom/Document.cpp:

(WebCore::Document::setContent):

  • dom/DocumentParser.h:

(DocumentParser):

  • dom/RawDataDocumentParser.h:

(WebCore::RawDataDocumentParser::append):

  • html/FTPDirectoryDocument.cpp:

(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::append):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::append):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::append):

  • html/parser/HTMLViewSourceParser.h:

(HTMLViewSourceParser):

  • html/parser/TextDocumentParser.cpp:

(WebCore::TextDocumentParser::append):

  • html/parser/TextDocumentParser.h:

(TextDocumentParser):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::append):

  • xml/parser/XMLDocumentParser.h:

(XMLDocumentParser):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::resumeParsing):

Source/WTF:

The threaded html parser needs to accept ownership
of a string buffer. The easiest way to do this seemed
to be to use a PassRefPtr<StringImpl>, but there was no way
to generated one from a String (easily), so I added one.

  • wtf/text/WTFString.h:

(WTF::String::releaseImpl):

1:44 PM Changeset in webkit [144497] by hyatt@apple.com
  • 21 edits
    2 adds in trunk

[New Multicolumn] Change inRenderFlowThread to follow containing block chain
​https://bugs.webkit.org/show_bug.cgi?id=111206

Reviewed by Simon Fraser.

Source/WebCore:

This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
the containing block chain instead of the parent chain when outside of layout.
(It already did the right thing when called during layout.)

By removing inRenderFlowThread (which was following the parent chain), all
code that is checking for flow thread containment now correctly uses the
containing block chain. This allows for content to escape in-flow flow threads
and do the right thing without asserting.

Test: fast/multicol/positioned-outside-of-columns.html

  • dom/WebKitNamedFlow.cpp:

(WebCore::inFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContent):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::setStaticInlinePositionForChild):
(WebCore::RenderBlock::logicalWidthChangedInRegions):
(WebCore::RenderBlock::clampToStartAndEndRegions):

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
(LineLayoutState):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectInFlowRegion):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderLayer.cpp:

(WebCore::accumulateOffsetTowardsAncestor):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::canBeComposited):

  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::willBeRemovedFromTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):

  • rendering/RenderObject.h:

(RenderObject):
(WebCore::RenderObject::flowThreadContainingBlock):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::setObjectStyleInRegion):

  • rendering/RenderView.cpp:

(WebCore::RenderView::addChild):
(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::setSelection):

  • rendering/RenderView.h:

(WebCore::RenderView::pushLayoutState):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):

LayoutTests:

  • fast/multicol/positioned-outside-of-columns-expected.html: Added.
  • fast/multicol/positioned-outside-of-columns.html: Added.
1:36 PM Changeset in webkit [144496] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Uncomment ENABLE_SVG guards to avoid having WebKitPluginProcess link
against libWebCoreSVG.la when SVG is disabled.

Rubber-stamped by Gustavo Noronha.

  • GNUmakefile.am:
1:32 PM Changeset in webkit [144495] by weinig@apple.com
  • 15 edits in trunk/Source

Add SPI for marking a WebView as doing things on behalf of another process
​https://bugs.webkit.org/show_bug.cgi?id=111125

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
Set the sourceApplicationAuditData on the URL connection if available.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::sourceApplicationAuditData):

  • WebView/WebView.mm:

(-[WebView _setSourceApplicationAuditData:]):
(-[WebView _sourceApplicationAuditData]):

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate dealloc]):

  • WebView/WebViewPrivate.h:

Add SPI for setting a source application for a WebView.

Source/WebKit2:

  • NetworkProcess/mac/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
Stub out sourceApplicationAuditData() client function.

1:31 PM Changeset in webkit [144494] by zhajiang@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Screen went black while navigating back/forward on the reddit.com page
​https://bugs.webkit.org/show_bug.cgi?id=111192

Patch by Jacky Jiang <​zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

PR: 299783
When going back to the previous reddit.com page, the actual contents
size was much less than the history contents size. However, we expanded
the actual contents size to history contents size which caused a huge
black area below the actual contents.
To fix that, don't restore the contents size from history contents size
and scroll back to the valid contents area if we are about to overscroll.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

1:26 PM Changeset in webkit [144493] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Increase number of patches processed before clean building on WinEWS bots.

  • EWSTools/start-queue-win.sh:
1:25 PM Changeset in webkit [144492] by beidson@apple.com
  • 10 edits in branches/safari-536.29-branch

Merge r143790

2013-02-22 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>


Reviewed by Sam Weinig.

Move the pluginLoadPolicy callback to the page loader client where it belongs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Move pluginLoadPolicy to the page loader client
​https://bugs.webkit.org/show_bug.cgi?id=110635

Reviewed by Sam Weinig.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
1:18 PM Changeset in webkit [144491] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

[Windows] Unreviewed VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor files to the project.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
1:18 PM Changeset in webkit [144490] by commit-queue@webkit.org
  • 1 edit
    3 adds in trunk/Source/ThirdParty/ANGLE

[GTK] Add ANGLE to the GTK+ gyp build
​https://bugs.webkit.org/show_bug.cgi?id=111128

Patch by Martin Robinson <​mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Add files that build an ANGLE static library for GTK+ using gyp.

  • ANGLE.gyp/ANGLE.gyp: Added.
  • ANGLE.gypi: Added.
1:14 PM Changeset in webkit [144489] by mhahnenberg@apple.com
  • 5 edits
    2 deletes in trunk/Source/JavaScriptCore

Objective-C API: Passing JS functions to Objective-C callbacks causes JSValue to leak
​https://bugs.webkit.org/show_bug.cgi?id=107836

Reviewed by Oliver Hunt.

We've decided to remove support for this feature from the API because there's no way to automatically manage
the memory for clients in a satisfactory manner. Clients can still pass JS functions to Objective-C methods,
but the methods must accept plain JSValues instead of Objective-C blocks.

We now ignore functions that are part of a protocol that inherits from JSExport that accept blocks as arguments.

  • API/JSBlockAdaptor.h: Removed.
  • API/JSBlockAdaptor.mm: Removed.
  • API/ObjCCallbackFunction.mm:

(ArgumentTypeDelegate::typeBlock): Return nil to signal that we want to ignore this function when copying it
to the object from the protocol.

  • API/tests/testapi.mm: Added a test to make sure that we ignore methods declared as part of a JSExport-ed protocol

that have block arguments.
(-[TestObject bogusCallback:]):

1:07 PM Changeset in webkit [144488] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Improve input bounds clipping for search fields.
​https://bugs.webkit.org/show_bug.cgi?id=111204

Reviewed by Rob Buis.

PR 292673.

Use the standardized InputHandler function to get the
bounds of an input field so that search fields are
truncated smaller to account for the X.

Reviewed Internally by Gen Mak.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

1:02 PM Changeset in webkit [144487] by betravis@adobe.com
  • 7 edits
    2 adds in trunk

[css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
​https://bugs.webkit.org/show_bug.cgi?id=108128

Reviewed by David Hyatt.

Source/WebCore:

Ensure that blocks lay out when their parent's shape-inside changes.
ExclusionShapeInsideInfo now stores an additional flag indicating whether
the shape has changed and its block's children require layout. Each block
can look up the flag via LayoutState to determine whether it needs to lay
out its children.

Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
if the shape has changed.
(ExclusionShapeInfo):

  • rendering/ExclusionShapeInsideInfo.h:

(WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
layout is necessary.
(WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
the layout flag.

  • rendering/RenderBlock.cpp:

(WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
(WebCore):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
indicating whether regions or exclusions updates should cause a relayout.
(WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
changed.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
class method.
(WebCore::LineWidth::LineWidth): Changing to use class method.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

LayoutTests:

Test that setting and resetting shape-inside and shape-outside correctly lay out
content inside of child blocks.

  • fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-dynamic-nested.html: Added.
12:57 PM Changeset in webkit [144486] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
​https://bugs.webkit.org/show_bug.cgi?id=111209

Reviewed by Oliver Hunt.

Even if it is then everything will work just fine. It's not necessary to check the ref count here.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

12:49 PM Changeset in webkit [144485] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getComputedStyle not implemented for -webkit-column-rule shorthand
​https://bugs.webkit.org/show_bug.cgi?id=111203

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-01
Reviewed by Alexis Menard.

Source/WebCore:

Implement getComputedStyle for -webkit-column-rule property.

Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to check getComputedStyle for -webkit-column-rule.

  • fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-column-rule.html: Added.
12:46 PM Changeset in webkit [144484] by hyatt@apple.com
  • 6 edits in trunk/Source/WebCore

REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
​https://bugs.webkit.org/show_bug.cgi?id=111117

Make sure the allocated vector has a capacity of 1, since that is
far and away the most common case.

Reviewed by Andreas Kling.

  • rendering/RenderFlowThread.h:

(WebCore):

  • rendering/RenderLayer.h:

(WebCore):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::collectLayerFragments):

  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderRegion.h:

(WebCore):
(WebCore::RenderRegion::collectLayerFragments):

12:43 PM Changeset in webkit [144483] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=111211.
<rdar://problem/8772758>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we build a SharedBuffer from an NSData
we have obtained manipulating data from the pasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):

12:42 PM Changeset in webkit [144482] by beidson@apple.com
  • 4 edits
    2 adds in branches/safari-536.29-branch

Merge r142919

2013-02-14 Anders Carlsson <​andersca@apple.com>

Add WKContextIsPlugInUpdateAvailable
​https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>

Reviewed by Sam Weinig.

Source/WebKit2:

  • UIProcess/API/C/mac/WKContextPrivateMac.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
  • WebKit2.xcodeproj/project.pbxproj:

WebKitLibraries:

Roll WebKitSystemInterface DEPS.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
12:40 PM Changeset in webkit [144481] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

DFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
​https://bugs.webkit.org/show_bug.cgi?id=111205

Reviewed by Oliver Hunt.

I don't understand the intuition behind setLocalStoreElimination() validating that the SetLocal's ref count
is 1. I believe this is a hold-over from when setLocalStoreElimination() would match one SetLocal to another,
and then try to eliminate the first SetLocal. But that's not how it works now. Now, setLocalStoreElimination()
is actually Flush elimination: it eliminates any Flush that anchors a SetLocal if it proves that every path
from the SetLocal to the Flush is devoid of operations that may observe the local. It doesn't actually kill
the SetLocal itself: if the SetLocal is live because of other things (other Flushes or GetLocals in other
basic blocks), then the SetLocal will naturally still be alive because th Flush was only keeping the SetLocal
alive by one count rather than being solely responsible for its liveness.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

12:32 PM Changeset in webkit [144480] by Lucas Forschler
  • 18 edits in tags/Safari-537.31.12/Source

Merged r144397. <rdar://problem/13291412>

12:26 PM Changeset in webkit [144479] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Crash at WebCore::SharedBuffer::hasPlatformData during paste.
​https://bugs.webkit.org/show_bug.cgi?id=111207.
<rdar://problem/13024528>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we get a SharedBuffer from the pasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):

12:04 PM Changeset in webkit [144478] by rniwa@webkit.org
  • 5 edits in trunk/Tools

Don't return statistics in PerfTest.run
​https://bugs.webkit.org/show_bug.cgi?id=111145

Reviewed by Dirk Pranke.

Simply return a list of values obtained in each iteration from PerfTest.run.
Also simplify various methods as needed.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.init): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
as needed from PerfTestsRunner._generate_results_dict.

(PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
that we don't have to worry about the backward compatibility here.

(PerfTestMetric.iteration_values): Added.
(PerfTestMetric.unit): Added.
(PerfTestMetric.metric_to_unit):
(PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.

(PerfTest.run):
(PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestMetric.test_init_set_missing_unit):
(TestPerfTestMetric.test_init_set_time_metric): Added.
(TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
(TestPerfTestMetric.test_append):
(TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
test cases and it's not critical to keep math right as they're not used in output JSON anymore.
(TestPerfTest._assert_results_are_correct):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._generate_results_dict):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.

11:51 AM Changeset in webkit [144477] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Rename MovHint to MovHintEvent so I can create a NodeType called MovHint

Rubber stamped by Mark Hahnenberg.

This is similar to the SetLocal/SetLocalEvent naming scheme, where SetLocal is the
NodeType and SetLocalEvent is the VariableEventKind.

  • dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump):

  • dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::operand):
(VariableEvent):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

11:23 AM Changeset in webkit [144476] by enne@google.com
  • 2 edits in trunk/LayoutTests

[chromium] Mark rtl-iframe-absolute-overflow-scrolled as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

  • platform/chromium/TestExpectations:
11:17 AM Changeset in webkit [144475] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.

  • platform/network/BlobRegistryImpl.cpp:
11:13 AM Changeset in webkit [144474] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Session cookies should not be persistent.
​https://bugs.webkit.org/show_bug.cgi?id=111060

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-01
Reviewed by Brent Fulgham.

Curl saves both persistent cookies, and session cookies to the cookie file.
The session cookies should be deleted before starting a new session.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
(WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.

  • platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.
11:04 AM Changeset in webkit [144473] by beidson@apple.com
  • 8 edits in branches/safari-536.29-branch/Source/WebKit2

Merge r142017

2013-02-06 Anders Carlsson <​andersca@apple.com>

Pass the document source URL to the pluginLoadPolicy callback
​https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>

Reviewed by Andreas Kling.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
10:53 AM Changeset in webkit [144472] by beidson@apple.com
  • 5 edits in branches/safari-536.29-branch/Source/WebKit2

Merge r141923

2013-02-05 Anders Carlsson <​andersca@apple.com>

WebKit clients should be able to override loading of blocked plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
  • UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
  • UIProcess/WebUIClient.h: (WebUIClient):
10:32 AM Changeset in webkit [144471] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.12/Source

Versioning.

10:28 AM Changeset in webkit [144470] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.12

New Tag.

10:11 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
10:10 AM Changeset in webkit [144469] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r143973 - Build fix for gtk2-based library.

Reviewed by Martin Robinson.

  • platform/gtk/WidgetRenderingContext.cpp: move gtk2 check to after the config.h

include, which is the one that includes autotoolsconfig.h, where the gtk2 define
lives.

10:07 AM Changeset in webkit [144468] by Carlos Garcia Campos
  • 34 edits in releases/WebKitGTK/webkit-2.0

Merge r143869 - [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
​https://bugs.webkit.org/show_bug.cgi?id=110702

Reviewed by Martin Robinson.

Source/WebCore:

No tests. Build fix, no behaviour change.

  • platform/gtk/GtkVersioning.h: include the autotoolsconfig.h header,

which contains the GTK_API_VERSION_2 define now.

Source/WebKit/gtk:

  • tests/testapplicationcache.c: include autotoolsconfig.h.
  • tests/testatk.c: ditto.
  • tests/testatkroles.c: ditto.
  • tests/testcontextmenu.c: ditto.
  • tests/testcopyandpaste.c: ditto.
  • tests/testdomdocument.c: ditto.
  • tests/testdomdomwindow.c: ditto.
  • tests/testdomnode.c: ditto.
  • tests/testdownload.c: ditto.
  • tests/testfavicondatabase.c: ditto.
  • tests/testglobals.c: ditto.
  • tests/testhittestresult.c: ditto.
  • tests/testhttpbackend.c: ditto.
  • tests/testkeyevents.c: ditto.
  • tests/testloading.c: ditto.
  • tests/testmimehandling.c: ditto.
  • tests/testnetworkrequest.c: ditto.
  • tests/testnetworkresponse.c: ditto.
  • tests/testwebbackforwardlist.c: ditto.
  • tests/testwebdatasource.c: ditto.
  • tests/testwebframe.c: ditto.
  • tests/testwebhistoryitem.c: ditto.
  • tests/testwebinspector.c: ditto.
  • tests/testwebplugindatabase.c: ditto.
  • tests/testwebresource.c: ditto.
  • tests/testwebsettings.c: ditto.
  • tests/testwebview.c: ditto.
  • tests/testwindow.c: ditto.

Tools:

  • GtkLauncher/main.c: include autotoolsconfig.h.
  • Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of

the include ordering check, since it uses autotoolsconfig.h which needs to
come first.

9:57 AM Changeset in webkit [144467] by vsevik@chromium.org
  • 13 edits
    2 adds
    2 deletes in trunk

Web Inspector: Navigator should show tree element for each folder in the source path.
​https://bugs.webkit.org/show_bug.cgi?id=108943

Reviewed by Pavel Feldman.

Source/WebCore:

NavigatorView now renders tree element for each folder in uiSourceCode uri.
Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
ScriptsNavigator has horizontal scroll now.
Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').

Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html

  • English.lproj/localizedStrings.js:
  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.iconClassForType):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getProjectNode):
(WebInspector.NavigatorView.prototype._createProjectNode):
(WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
(WebInspector.NavigatorView.prototype._getFolderNode):
(WebInspector.NavigatorView.prototype._createFolderNode):
(WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
(WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.rename):
(WebInspector.NavigatorView.prototype.reset):
(.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.type):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement):
(WebInspector.NavigatorTreeNode):
(WebInspector.NavigatorTreeNode.prototype.treeElement):
(WebInspector.NavigatorTreeNode.prototype.dispose):
(WebInspector.NavigatorTreeNode.prototype.isRoot):
(WebInspector.NavigatorTreeNode.prototype.hasChildren):
(WebInspector.NavigatorTreeNode.prototype.populate):
(WebInspector.NavigatorTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorTreeNode.prototype.didAddChild):
(WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorTreeNode.prototype.isPopulated):
(WebInspector.NavigatorTreeNode.prototype.isEmpty):
(WebInspector.NavigatorTreeNode.prototype.child):
(WebInspector.NavigatorTreeNode.prototype.children):
(WebInspector.NavigatorTreeNode.prototype.appendChild):
(WebInspector.NavigatorTreeNode.prototype.removeChild):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorRootTreeNode):
(WebInspector.NavigatorRootTreeNode.prototype.isRoot):
(WebInspector.NavigatorRootTreeNode.prototype.treeElement):
(WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
(WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorUISourceCodeTreeNode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
(WebInspector.NavigatorFolderTreeNode):
(WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
(WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
(WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
(WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
(WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):

  • inspector/front-end/ScriptsNavigator.js:
  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.displayName):

  • inspector/front-end/navigatorView.css:

(.navigator > ol):
(.navigator .base-navigator-tree-element-title):
(.navigator-tabbed-pane .navigator-container):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):

  • inspector/debugger/navigator-view-expected.txt: Added.
  • inspector/debugger/navigator-view.html: Added.
  • inspector/debugger/scripts-file-selector-expected.txt: Removed.
  • inspector/debugger/scripts-file-selector.html: Removed.
  • inspector/debugger/scripts-panel-expected.txt:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
9:49 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
9:48 AM Changeset in webkit [144466] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/LayoutTests

Merge r144045 - REGRESSION (r143931): set-cookie-on-redirect.html breaks subsequent tests
​https://bugs.webkit.org/show_bug.cgi?id=110844

Patch by Sergio Villar Senin <​svillar@igalia.com> on 2013-02-26
Reviewed by Alexey Proskuryakov.

Clean up cookies at the beginning and after finishing the test in
order not to break other tests behavior.

  • http/tests/cookies/resources/set-cookie-on-redirect.php: clear cookie before returning.
  • http/tests/cookies/set-cookie-on-redirect.html: clear all cookies before starting the test.
9:43 AM Changeset in webkit [144465] by anilsson@rim.com
  • 36 edits
    5 deletes in trunk/Source/WebCore

[BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
​https://bugs.webkit.org/show_bug.cgi?id=111072

Reviewed by Rob Buis.

BlackBerry PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Rob Buis
Robin Cao
Michael Carmody
Max Feil
Eli Fidler
Antonio Gomes
Jacky Jiang
Mike Lattanzio
Yong Li
Andrew Lo
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Cosmin Truta

Covered by existing tests.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerWebKitThread::deleteTextures):
(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
(WebCore):
(WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::clearBuffer):

  • platform/graphics/blackberry/CanvasLayerWebKitThread.h:

(WebCore):
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):

  • platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

  • platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:

(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:

(Graphics):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.h:

(Graphics):
(EGLImageLayerWebKitThread):

  • platform/graphics/blackberry/FloatRectBlackBerry.cpp:

(WebCore::FloatRect::normalized):
(WebCore):

  • platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::getImageData):
(WebCore):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

  • platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::ImageFrame::asNewNativeImage):
(WebCore):
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::invalidatePlatformData):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

  • platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
(WebCore::LayerCompositingThread::commitPendingTextureUploads):
(WebCore):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(Graphics):
(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(Graphics):
(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::contentsTexture):
(WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):

  • platform/graphics/blackberry/LayerData.h:

(WebCore::LayerData::LayerData):
(WebCore::LayerData::contentsResolutionIndependent):
(LayerData):
(WebCore::LayerData::layerProgram):
(WebCore::LayerData::isContainerForFixedPositionLayers):
(WebCore::LayerData::isFixedToTop):
(WebCore::LayerData::isFixedToLeft):
(WebCore::LayerData::frameVisibleRect):
(WebCore::LayerData::frameContentsSize):
(WebCore::LayerData::contentsScale):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::glRound):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::createProgram):
(WebCore::LayerRenderer::useProgram):
(WebCore::LayerRenderer::useLayerProgram):

  • platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::ensureTexture):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):

  • platform/graphics/blackberry/LayerTile.h:

(LayerTile):
(WebCore::LayerTile::renderState):
(WebCore::LayerTile::needsRender):
(WebCore::LayerTile::setNeedsRender):
(WebCore::LayerTile::setRenderPending):
(WebCore::LayerTile::setRenderDone):

  • platform/graphics/blackberry/LayerTileIndex.h:
  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::createBuffer):
(WebCore::LayerTiler::willCommit):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::setNeedsBacking):
(WebCore::LayerTiler::contentsTexture):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::tileSize):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(WebCore::LayerTiler::needsRender):
(WebCore::LayerTiler::removeUpdateContentsJobs):

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationsStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore):
(WebCore::LayerWebKitThread::addOverlay):
(WebCore::LayerWebKitThread::insert):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayerOrOverlay):
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
(WebCore::LayerWebKitThread::removeAll):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::releaseLayerResources):

  • platform/graphics/blackberry/LayerWebKitThread.h:

(WebCore::LayerWebKitThread::insertSublayer):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::isMask):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
(WebCore::LayerWebKitThread::setFixedToTop):
(WebCore::LayerWebKitThread::setFixedToLeft):
(WebCore::LayerWebKitThread::setFrameVisibleRect):
(WebCore::LayerWebKitThread::setFrameContentsSize):
(WebCore::LayerWebKitThread::setLayerProgram):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivate::prepareForRendering):
(WebCore):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::MediaPlayerPrivate::isProcessingUserGesture):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
(WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
(WebCore::MediaPlayerPrivate::onExitFullscreen):
(WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
(WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:

(BlackBerry):
(Platform):
(Graphics):
(MediaPlayerPrivate):

  • platform/graphics/blackberry/PluginLayerWebKitThread.cpp:

(WebCore::PluginLayerWebKitThread::setPluginView):

  • platform/graphics/blackberry/Texture.cpp:

(WebCore::Texture::Texture):
(WebCore::Texture::updateContents):
(WebCore::Texture::setContentsToColor):
(WebCore::Texture::protect):

  • platform/graphics/blackberry/Texture.h:

(Texture):
(WebCore::Texture::textureId):
(WebCore::Texture::isDirty):
(WebCore::Texture::hasTexture):
(WebCore::Texture::sizeInBytes):
(WebCore::Texture::setTextureId):
(WebCore::Texture::setSize):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::clear):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::updateContents):

  • platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

  • platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
  • platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
  • platform/graphics/blackberry/skia/PlatformSupport.h: Removed.
9:30 AM Changeset in webkit [144464] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Fix the Mac build with the current qtbase/dev branch
​https://bugs.webkit.org/show_bug.cgi?id=111190

Reviewed by Allan Sandfeld Jensen.

QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
changes in qtbase to support iOS.

Having only WebCore defining it to 10.5 would create a mismatch of
ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
while linking both together at the end.

Fix it by removing the statement which isn't needed anymore.
qtbase/mkspecs/common/mac-minimum-version.conf already defines
10.6 as the minimum Mac version.

  • Target.pri:
9:06 AM Changeset in webkit [144463] by vsevik@chromium.org
  • 7 edits in trunk

Web Inspector: [Regression] Snippets renaming is broken.
​https://bugs.webkit.org/show_bug.cgi?id=111181

Reviewed by Alexander Pavlov.

Source/WebCore:

  • inspector/front-end/NavigatorView.js:
  • inspector/front-end/ScriptSnippetModel.js:
  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.set _fileRenamed):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.rename):

LayoutTests:

  • inspector/debugger/script-snippet-model.html:
9:04 AM Changeset in webkit [144462] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Fix a misspelled word in RenderObject.h. staticly -> statically.

Reviewed by Dean Jackson.

  • rendering/RenderObject.h:

(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):

8:58 AM Changeset in webkit [144461] by hyatt@apple.com
  • 9 edits in trunk/Source/WebCore

[New Multicolumn] Change flow thread containment to be a state.
​https://bugs.webkit.org/show_bug.cgi?id=111110

Change m_inRenderFlowThread from a single bit to an actual state. This
will let us track whether we're inside a multicolumn (in-flow) flow thread
or a named (out-of-flow) flow thread. In the former case, we're going to have
to do more work to maintain this state, but for now I've kept all the logic
the same just for the initial landing.

Reviewed by Andreas Kling.

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::clone):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::clone):

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):

  • rendering/RenderObject.h:

(WebCore::RenderObject::setParent):
(RenderObject):
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::flowThreadState):
(WebCore::RenderObject::setFlowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):

  • rendering/RenderView.cpp:

(WebCore::RenderView::addChild):

8:46 AM Changeset in webkit [144460] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix.

Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
8:28 AM Changeset in webkit [144459] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
<​http://webkit.org/b/109331>

Fixes the following build failures:

Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)


Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)


2 errors generated.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
macros.

8:24 AM Changeset in webkit [144458] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[v8] ScriptValue has dangerous copy semantics
​https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <​dcarney@google.com> on 2013-03-01
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

  • bindings/v8/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):

  • bindings/v8/SharedPersistent.h:
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::InjectedScriptHost::scriptValueAsNode):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAttrGetterCustom):

7:49 AM Changeset in webkit [144457] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skipped failing test.
7:47 AM Changeset in webkit [144456] by jchaffraix@webkit.org
  • 3 edits in trunk/Source/WebCore

Add FeatureObserver for marquee and reflection
​https://bugs.webkit.org/show_bug.cgi?id=111118

Reviewed by Simon Fraser.

Refactoring covered by existing tests.

  • page/FeatureObserver.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::styleChanged):
Added some instrumentation for reflection and marquee as they are both prefixed and this would help
to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
overflow: -webkit-marquee (CSSOverflowMarquee).

7:37 AM Changeset in webkit [144455] by apavlov@chromium.org
  • 16 edits in trunk

Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
​https://bugs.webkit.org/show_bug.cgi?id=111165

Reviewed by Vsevolod Vlasov.

Source/WebCore:

A plain string security origin value has been replaced by WebInspector.SecurityOrigin all over the code,
containing a URL (which holds a stringified security origin) and an identifier (which is now used
as a key in place of the stringified security origin in various maps). To avoid the ResourceTreeModel
code clutter, the security origin tracking code has been extracted into a separate type,
WebInspector.SecurityOriginTracker, which works as a helper on the ResourceTreeModel.

No new tests, as it is a refactoring.

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDatabaseView.prototype._refreshDatabase):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype.securityOriginForId):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.SecurityOriginTracker):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._bindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._unbindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._detachMainFrame):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOriginForId):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOrigins):
(WebInspector.ResourceTreeFrame.prototype._navigate):
(WebInspector.SecurityOrigin.prototype.id):
(WebInspector.SecurityOrigin.prototype.url):
(WebInspector.SecurityOrigin.prototype.uiTitle):
(WebInspector.SecurityOrigin.prototype.toProtocol):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):

LayoutTests:

Follow the string -> object conversion of the security origin.

  • http/tests/inspector-enabled/dom-storage-open.html:
  • http/tests/inspector/filesystem/delete-entry.html:
  • http/tests/inspector/filesystem/request-filesystem-root.html:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names.html:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
7:25 AM Changeset in webkit [144454] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Reverse the base and extent of a selection when reversing its handles
​https://bugs.webkit.org/show_bug.cgi?id=111098

Reviewed by Yong Li.

PR283969
Swap the base and extent if base does not come first, and set the new selection.

Internally reviewed by Mike Fenton

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):

7:15 AM Changeset in webkit [144453] by eustas@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
​https://bugs.webkit.org/show_bug.cgi?id=108930

Reviewed by Pavel Feldman.

This feature will help developers to focus on events
that caused CPU bar.

  • inspector/front-end/Popover.js: Added "arrowDirection" parameter.
  • inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid): Added "curtains".

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
when mouse is over CPU bar.

  • inspector/front-end/timelinePanel.css: Added "curtains" style rules.
7:10 AM Changeset in webkit [144452] by rakuco@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix sign comparison warning/error after r144340.
​https://bugs.webkit.org/show_bug.cgi?id=111164

Reviewed by Mark Hahnenberg.

gcc (both 4.2.1 and 4.7.2) complain about comparing signed and
unsigned terms (clang accepts it just fine).

Work around that by casting the 1 to an uintptr_t as well.

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

6:47 AM Changeset in webkit [144451] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
Relanding fixed r144449.
​https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.

  • inspector/front-end/StylesSidebarPane.js: Add navigation code.

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

6:34 AM Changeset in webkit [144450] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r144449.
​http://trac.webkit.org/changeset/144449
​https://bugs.webkit.org/show_bug.cgi?id=111175

Breaks style-related inspector tests (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSProperty.prototype.setDisabled):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
(.event):
(.isRevert):

6:12 AM Changeset in webkit [144449] by apavlov@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
​https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.

  • inspector/front-end/StylesSidebarPane.js: Add navigation code.

(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

6:02 AM Changeset in webkit [144448] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, update image expectation again

  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
5:38 AM Changeset in webkit [144447] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r144443.
​http://trac.webkit.org/changeset/144443
​https://bugs.webkit.org/show_bug.cgi?id=111169

Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested
by toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

  • css/mediaControls.css:

(video::-webkit-media-text-track-display):

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside):
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet):

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Removed.
  • media/track/track-cue-rendering-with-padding.html: Removed.
5:30 AM Changeset in webkit [144446] by commit-queue@webkit.org
  • 208 edits
    7 deletes in trunk/Source

Unreviewed, rolling out r144422 and r144424.
​http://trac.webkit.org/changeset/144422
​http://trac.webkit.org/changeset/144424
​https://bugs.webkit.org/show_bug.cgi?id=111167

Caused over 20 tests to fail assertion on Chromium Win port as
ASSERTION FAILED: m_platformRequestUpdated (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:

(WebCore):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):

  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:
  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:

(WebCore):

  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:

(WebCore):

  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:

(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):

  • loader/cache/CachedFontClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):

  • loader/cache/CachedRawResourceClient.h: Removed.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceHandle.cpp:
  • loader/cache/CachedResourceHandle.h:

(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):

  • loader/cache/CachedSVGDocumentClient.h: Removed.
  • loader/cache/CachedSVGDocumentReference.cpp: Removed.
  • loader/cache/CachedSVGDocumentReference.h:

(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):

  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/MemoryCache.cpp:
  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/DragController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::reportMemoryUsage):

  • page/Frame.h:

(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):

  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginRequest.h: Removed.
  • plugins/PluginStream.h:

(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):

  • plugins/PluginStreamClient.h: Removed.
  • plugins/PluginView.cpp:
  • plugins/PluginView.h:

(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):

  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::RenderImageResource):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.cpp: Removed.
  • rendering/style/StyleCustomFilterProgram.h:

(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):

  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/gtk:

  • webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/NetworkResourceLoader.h:

(WebCore):

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
4:59 AM Changeset in webkit [144445] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening, cleanup lint errors #2
Remove duplicated entries.

  • platform/chromium/TestExpectations:
4:57 AM Changeset in webkit [144444] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix closure compiler warnings in ProfilesPanel
​https://bugs.webkit.org/show_bug.cgi?id=111163

Patch by Alexei Filippov <​alph@chromium.org> on 2013-03-01
Reviewed by Vsevolod Vlasov.

  • inspector/front-end/ProfileLauncherView.js:

(WebInspector.ProfileLauncherView.prototype.addProfileType):

  • inspector/front-end/ProfilesPanel.js:
4:32 AM Changeset in webkit [144443] by vcarbune@chromium.org
  • 4 edits
    2 adds in trunk

Support padding, margin and border for internal UA cue styling
​https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Test: media/track/track-cue-rendering-with-padding.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

  • media/track/track-cue-rendering-with-padding-expected.txt: Added.
  • media/track/track-cue-rendering-with-padding.html: Added.
4:26 AM Changeset in webkit [144442] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening

  • platform/chromium/TestExpectations:
4:17 AM Changeset in webkit [144441] by allan.jensen@digia.com
  • 4 edits in trunk

[Qt] Enable LINK_PREFETCH
​https://bugs.webkit.org/show_bug.cgi?id=111158

Reviewed by Simon Hausmann.

Tools:

  • qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip tests depending on LINK_PREFETCH.

  • platform/qt/TestExpectations:
4:13 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:05 AM Changeset in webkit [144440] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Fix failing API tests after r143935
​https://bugs.webkit.org/show_bug.cgi?id=111086

Reviewed by Jocelyn Turcotte.

Convert a leftorver resume call to the new resumeAndUpdateContent() call
in PageViewportControllerClientQt so that the notifications about zoom
animation state changes reach the API tests.

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):

4:04 AM Changeset in webkit [144439] by eustas@chromium.org
  • 7 edits in trunk

Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
​https://bugs.webkit.org/show_bug.cgi?id=110819

Reviewed by Pavel Feldman.

To create event divider TimelinePresentation model checks if record
frame is main frame. With this patch check is moved to backend and
result is saved in record to avoid incoherence.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
Record "isMainFrame" flag.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createMarkData):
Added data object constructor.

  • inspector/TimelineRecordFactory.h: Ditto.
  • inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.isEventDivider):
Use saved flag value instead of comparing with "current" main frame.

4:01 AM Changeset in webkit [144438] by allan.jensen@digia.com
  • 2 edits in trunk/Tools

[Qt] Update features.pri with new features
​https://bugs.webkit.org/show_bug.cgi?id=111157

Reviewed by Jocelyn Turcotte.

  • qmake/mkspecs/features/features.pri:
3:46 AM Changeset in webkit [144437] by eustas@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
​https://bugs.webkit.org/show_bug.cgi?id=111077

Reviewed by Pavel Feldman.

Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.

3:39 AM Changeset in webkit [144436] by g.czajkowski@samsung.com
  • 20 edits
    2 adds in trunk/Source/WebKit2

[WK2] Asynchronous spell checking implementation
​https://bugs.webkit.org/show_bug.cgi?id=109577

Patch by Grzegorz Czajkowski <​g.czajkowski@samsung.com>, Mariusz Grzegorczyk <​mariusz.g@samsung.com> on 2013-03-01
Reviewed by Enrica Casucci.

Associate the abstract 'WebCore::TextCheckingRequest' object with the unique identifier
on WebProcess side. The request data from the 'TextCheckingRequest' are retrieved and
passed to the UIProcess. The WK2 client (TextChecker{Gtk/Mac/Efl/Qt}.cpp) gets
the 'TextCheckerCompletion' object with the request data and possibility to notify
the WebProcess about the spelling results.
Finally, the WebPage object calls on the proper 'TextCheckingRequest' object
didSuccess/didCancel method to notify the WebCore about the spelling result.

  • CMakeLists.txt:
  • GNUmakefile.list.am:

Add 'TextCheckerCompletion.{h/cpp}' to the WebKit2 cmake based and
WK2-Gtk+ builds.

  • Scripts/webkit2/messages.py:

(headers_for_type):
Add exception for 'TextCheckingRequestData' class to properly find header
file for it.

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:

Teach 'ArgumentCoder' how to encode/decode 'TextCheckingRequestData' class.

  • Target.pri:

Add 'TextCheckerCompletion.{h/cpp}' to the WK2-Qt build.

  • UIProcess/TextChecker.h:

Add 'requestCheckingOfString' method to the TextChecker's interface.

  • UIProcess/TextCheckerCompletion.cpp: Added.

(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):

(WebKit::TextCheckerCompletion::spellDocumentTag):
Return the WebPageProxy's spellDocumentTag as the client might be
interested in from which page the request came.

(WebKit::TextCheckerCompletion::textCheckingRequestData):
Allow to retrieve 'TextCheckingRequestData' object.

(WebKit::TextCheckerCompletion::didFinishCheckingText):
(WebKit::TextCheckerCompletion::didCancelCheckingText):
Notify the 'WebPageProxy' object that the given request has been
handled or canceled.

  • UIProcess/TextCheckerCompletion.h: Added.

Introduce a new class for WK2 to retrieve the request data and
call didFinishCheckingText/didCancelCheckingText.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestCheckingOfString):
Create 'TextCheckerCompletion' object and pass it
to the 'TextChecker::requestCheckingOfString' method.

(WebKit::WebPageProxy::didFinishCheckingText):
(WebKit::WebPageProxy::didCancelCheckingText):
Send the messages to WebProcess that the given request has been
handled or canceled.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):
Add public declarations for 'didFinishCheckingText', 'didCancelCheckingText'.
Add private declarations for 'requestCheckingOfString'.
Move the 'spellDocumentTag()' method to to the public section to be
accessible from 'TextCheckerCompletion' class.

  • UIProcess/WebPageProxy.messages.in:

A new entry for 'RequestCheckingOfString'.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):

  • UIProcess/qt/TextCheckerQt.cpp:

(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
Add dummy implementations for 'requestCheckingOfString'.

  • WebKit2.xcodeproj/project.pbxproj:

Add 'TextCheckerCompletion.{h/cpp} to Mac build.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::generateTextCheckingRequestID):
Helper function to generate the unique identifier for the abstract
'TextCheckingRequest' object.

(WebKit::WebEditorClient::requestCheckingOfString):
Associate 'TextCheckingRequest' with the unique identifier and add them
to the map object.
Get the request data and send it to the UIProcess.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addTextCheckingRequest):
Add the identifier and the request to the map object.

(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
Call didSucceed/didCancel on the 'TextCheckingRequest' to notify the WebCore
about spellcheking results.
Remove the request from the map object.

  • WebProcess/WebPage/WebPage.h:

Add declarations for 'addTextCheckingRequest', 'didFinishCheckingText' and
'didCancelCheckingText.'

  • WebProcess/WebPage/WebPage.messages.in:

Add a new entry for DidFinishCheckingText, DidCancelCheckingText.

3:36 AM Changeset in webkit [144435] by vsevik@chromium.org
  • 4 edits in trunk/LayoutTests

Flaky test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html
​https://bugs.webkit.org/show_bug.cgi?id=111123

Reviewed by Alexander Pavlov.

  • TestExpectations:
  • http/tests/inspector/resource-tree/resource-request-content-while-loading.html:
  • platform/chromium/TestExpectations:
2:33 AM Changeset in webkit [144434] by apavlov@chromium.org
  • 18 edits
    5 adds in trunk

Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
​https://bugs.webkit.org/show_bug.cgi?id=110732

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/selector-line.html

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::sizetExtractor): Utility for binary search.
(WebCore::ContentSearchUtils::textPositionFromOffset): Converts absolute raw text offset into line:column.
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines): Refactor.
(WebCore::ContentSearchUtils::lineEndings): Factored out of getRegularExpressionMatchesByLines.
(WebCore::ContentSearchUtils::buildObjectForSearchMatch): Drive-by: pass String by reference.

  • inspector/ContentSearchUtils.h:
  • inspector/Inspector.json: Use line:column for SourceRange boundaries rather than raw offsets.
  • inspector/InspectorStyleSheet.cpp:

(ParsedStyleSheet::text): ASSERT(m_hasText).
(WebCore::InspectorStyle::buildObjectForStyle): Supply the lineEndings argument.
(WebCore::buildSourceRangeObject): Follow the protocol change.
(WebCore::InspectorStyle::setPropertyText): Refactor.
(WebCore::InspectorStyle::toggleProperty): Ditto.
(WebCore::InspectorStyle::styleText): Ditto.
(WebCore::InspectorStyle::populateAllProperties): Ditto.
(WebCore::InspectorStyle::styleWithProperties): Convert relative property range offsets into absolute ones.
(WebCore::InspectorStyle::extractSourceData): Factored out.
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Supply the lineEndings argument.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList): Ditto.
(WebCore::InspectorStyleSheet::lineEndings): Compute line endings for ordinary stylesheets.
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings): Ditto for bogus inline style stylesheets.

  • inspector/InspectorStyleSheet.h:
  • inspector/front-end/AuditRules.js: Removed the byte counting for unused CSS.
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSRule): Set selector rawLocation based on the selectorList range or sourceLine.
(WebInspector.CSSRule.prototype._setRawLocation): Added.

  • inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype._bindUISourceCode): Fix call order when binding scss sourcecodes.

LayoutTests:

Changed tests have been rebaselined to follow the new source range structure.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.InspectorTest.rangeText): Fix source range dumping format.

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-noimages-functional-expected.txt:
  • inspector/styles/get-set-stylesheet-text-expected.txt:
  • inspector/styles/parse-stylesheet-errors-expected.txt:
  • inspector/styles/resources/selector-line.css: Added.
  • inspector/styles/resources/selector-line.css.map: Added.
  • inspector/styles/resources/selector-line.scss: Added.
  • inspector/styles/selector-line-expected.txt: Added.
  • inspector/styles/selector-line.html: Added.
  • inspector/styles/styles-new-API-expected.txt:
  • inspector/styles/styles-source-offsets-expected.txt:
  • inspector/styles/styles-source-offsets.html:
2:19 AM Changeset in webkit [144433] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] put WebTestProxy::scheduleComposite back in place
​https://bugs.webkit.org/show_bug.cgi?id=111146

Reviewed by Nico Weber.

The call was removed in ​http://trac.webkit.org/changeset/144398 because
DRT doesn't need it. However, content shell depends on this call.

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::scheduleComposite):

2:13 AM Changeset in webkit [144432] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Get rid of two silly static null Strings
​https://bugs.webkit.org/show_bug.cgi?id=111151

Reviewed by Eric Seidel.

We have a global null String through nullAtom, there is no need
for local static null strings.

  • page/Page.cpp:

(WebCore::Page::groupName):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::markerText):

2:03 AM Changeset in webkit [144431] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Add a missing #include.
1:45 AM Changeset in webkit [144430] by mkwst@chromium.org
  • 5 edits
    1 add in trunk/LayoutTests

[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
​https://bugs.webkit.org/show_bug.cgi?id=111052

Reviewed by Alexey Proskuryakov.

Currently, this test is failing to output the textual content of the
'data:' URL to which the test navigates. Replacing this 'data:' URL
with a "real" HTML file ensures that Mac WK1 behaves the same way as
the other ports for this test.

This doesn't really address the issue raised: navigation to a 'data:'
URL should behave in the same way as a "real" URL; filed
​http://wkbug.com/111152 to track that issue.

  • http/tests/xmlhttprequest/resources/navigation-target.html: Added.

Add an actual file to which we can navigate.

  • http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
  • http/tests/xmlhttprequest/navigation-should-abort.html:

Navigate to the new HTML file during the test rather than an inlined
data: URL.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:

Remove the expectations set in r144277.

1:44 AM Changeset in webkit [144429] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk-wk1/TestExpectations: Removing expectation for the fast/canvas/canvas-currentPath-crash.html test.
  • platform/gtk/media/video-playing-and-pause-expected.txt: Rebaselining.
1:37 AM Changeset in webkit [144428] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix code-mirror experiment to work in debug mode
​https://bugs.webkit.org/show_bug.cgi?id=111064

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-01
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

Improve importScript function to try load a script from the root
directory iff its loading from the given path failed.

  • inspector/front-end/utilities.js:
1:18 AM Changeset in webkit [144427] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] capture a WebGL extension by it's name in lower case
​https://bugs.webkit.org/show_bug.cgi?id=110745

Reviewed by Pavel Feldman.

WebGL's getExtension accepts a name that is tested against an ASCII case-insensitive match.
Just force lower case for extension names.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

1:07 AM Changeset in webkit [144426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

Fix definition of DatePickerClient::setValue()
​https://bugs.webkit.org/show_bug.cgi?id=110336

Patch by Alberto Garcia <​albgarcia@rim.com> on 2013-03-01
Reviewed by Carlos Garcia Campos.

The definition of DatePickerClient::setValue() introduced in
r142987 does not match the prototype.

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValue):

12:47 AM Changeset in webkit [144425] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

XSSAuditor should use threadSafeMatch when relevant.
​https://bugs.webkit.org/show_bug.cgi?id=111099

Reviewed by Adam Barth.

Given the work on breaking parsing out into a background thread, we
should compare QualifiedNames in a thread-safe manner. Rather than
casting the result of QualifiedName::localName to a String, we can
call out to threadSafeMatch to do the comparison.

This patch leaves one use of equalIgnoringNullity in
XSSAuditor::findAttributeWithName. That usage seems safe, since we're
creating a new string against which to compare.

  • html/parser/XSSAuditor.cpp:

(WebCore::hasName):

Replace call to equalIgnoringNullity(Vector<UChar...>, String)
with threadSafeMatch(String, QualifiedName).

12:23 AM Changeset in webkit [144424] by jochen@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r144422): Broke compilation on chromium-mac
​https://bugs.webkit.org/show_bug.cgi?id=111150

Unreviewed build fix.

  • src/WebFrameImpl.h:

(WebCore):

Note: See TracTimeline for information about the timeline view.