Timeline
Mar 3, 2013:
- 11:57 PM Changeset in webkit [144602] by
-
- 6 edits in trunk/Source
[EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
https://bugs.webkit.org/show_bug.cgi?id=108034
Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-03
Reviewed by Laszlo Gombos.
Covered by existing WebGL tests.
Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
is identified during compile time. This is ok, when using GLX. We might not
have support for XCompositeWindow when using EGL and GLES2.0. This patch
makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
GLX guard to the parts of code dependent on XCompositeWindow support.
- platform/graphics/opengl/GLPlatformSurface.cpp:
- platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::findMatchingConfig):
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
- platform/graphics/surfaces/glx/X11Helper.h:
- 11:44 PM Changeset in webkit [144601] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: [PageAgent] can't find frame by security origin.
https://bugs.webkit.org/show_bug.cgi?id=110849
Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.
Reviewed by Vsevolod Vlasov.
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
- 11:28 PM Changeset in webkit [144600] by
-
- 16 edits in trunk
Unreviewed, rolling out r144455.
http://trac.webkit.org/changeset/144455
https://bugs.webkit.org/show_bug.cgi?id=111165
A simpler solution to the SecurityOrigin -> localStorage
lookup exists
Source/WebCore:
- inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
- inspector/front-end/ExtensionAuditCategory.js:
- inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):
- inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
- inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDatabaseView.prototype._refreshDatabase):
- inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):
- inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):
LayoutTests:
- http/tests/inspector-enabled/dom-storage-open.html:
- http/tests/inspector/filesystem/delete-entry.html:
- http/tests/inspector/filesystem/request-filesystem-root.html:
- http/tests/inspector/indexeddb/database-data.html:
- http/tests/inspector/indexeddb/database-names.html:
- http/tests/inspector/indexeddb/database-structure.html:
- http/tests/inspector/resource-tree/resource-tree-events.html:
- 11:09 PM Changeset in webkit [144599] by
-
- 3 edits in trunk/Source/WebKit2
PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication
https://bugs.webkit.org/show_bug.cgi?id=111258
Reviewed by Alexey Proskuryakov.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(-[WKPDFLayerControllerDelegate openWithNativeApplication]):
Rename from openWithPreview to openWithNativeApplication to match PDFKit.
- 10:53 PM Changeset in webkit [144598] by
-
- 10 edits in trunk/Source/WebCore
Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
https://bugs.webkit.org/show_bug.cgi?id=110133
Reviewed by Pavel Feldman.
We now check if file system based uiSourceCode content was updated externally when
UISourceCodeFrame is shown or inspector window is focused.
If there is no working copy being edited right now we replace old content with the new one silently.
Otherwise ask user if he wants to replace his working copy with the new content.
- English.lproj/localizedStrings.js:
- WebCore.vcproj/WebCore.vcproj:
- inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.editRange):
- inspector/front-end/FileSystemProjectDelegate.js:
(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
(WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):
- inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):
- inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):
- inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
- inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
- inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype.wasShown):
(WebInspector.UISourceCodeFrame.prototype.willHide):
(WebInspector.UISourceCodeFrame.prototype._windowFocused):
(WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):
- inspector/front-end/Workspace.js:
(WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.Project.prototype.requestUpdatedFileContent):
- 10:34 PM Changeset in webkit [144597] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium gardening
Remove failure annotation on tests which was already fixed.
- platform/chromium/TestExpectations:
- 10:28 PM Changeset in webkit [144596] by
-
- 5 edits in trunk
[Mac] Get rid of a useless method from DOMHTMLInputElement
https://bugs.webkit.org/show_bug.cgi?id=111279
Reviewed by Sam Weinig.
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
setValueForUser: is already privately exposed by DOMHTMLInputElement,
no need to have it twice.
Tools:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setValueForUser):
The method _setValueForUser: was added for testing. This feature is already
exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
in real use cases. Get rid of the method created for testing, use the real thing
instead.
- 9:51 PM Changeset in webkit [144595] by
-
- 3 edits2 adds in trunk
createAttribute/setAttributeNode does not properly normalize case
https://bugs.webkit.org/show_bug.cgi?id=90341
Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-03
Reviewed by Darin Adler.
Source/WebCore:
setAttributeNode() verifies for existing attributes in a case sensitive
manner. Thus, it would add another attribute if specified in a case
different from the existing one. Instead, like setAttribute(), it too
should modify the existing attribute's value.
Test: fast/dom/Element/setAttributeNode-case-insensitivity.html
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
Made changes to check for an existing attribute by converting the
specified attribute's localName to lowercase.
LayoutTests:
- fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Added.
- fast/dom/Element/setAttributeNode-case-insensitivity.html: Added.
Testcase for verifying that setAttributeNode() checks against existing
attributes in a case insensitive manner. It updates the value of an
existing attribute (in lower case) with that of the one set using
setAttributeNode() (in upper case).
The test also verifies the behavior of attributes when specified with
namespace and prefix.
- 5:42 PM Changeset in webkit [144594] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Rebaselined run-bindings-tests.
- bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
- bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
- 5:39 PM Changeset in webkit [144593] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r144590.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateSecurityCheckFunctions):
- 5:36 PM Changeset in webkit [144592] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r144587.
- bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
- bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
- 4:16 PM Changeset in webkit [144591] by
-
- 3 edits in trunk/Source/WebCore
[V8] HTMLDocument.all should have [Replaceable]
https://bugs.webkit.org/show_bug.cgi?id=111230
Reviewed by Adam Barth.
(Although HTMLDocument.all is already removed from the spec,)
it is expected to behave as a [Replaceable] attribute. By adding
a [Replaceable] IDL attribute, we can remove custom implementation
of HTMLDocument.all.
I confimed that exactly the same code is generated for .all getter
and setter.
No tests. No change in behavior.
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- html/HTMLDocument.idl:
- 4:12 PM Changeset in webkit [144590] by
-
- 5 edits in trunk/Source/WebCore
[V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
https://bugs.webkit.org/show_bug.cgi?id=111225
Reviewed by Adam Barth.
indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
except for DOMWindow's ones.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateImplementation):
(GenerateSecurityCheckFunctions):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedSecurityCheckCustom):
(WebCore::V8DOMWindow::indexedSecurityCheckCustom):
- bindings/v8/custom/V8HistoryCustom.cpp:
- bindings/v8/custom/V8LocationCustom.cpp:
- 4:11 PM Changeset in webkit [144589] by
-
- 2 edits in trunk/Source/JavaScriptCore
Shrink JSC::HashTable entries.
<http://webkit.org/b/111275>
<rdar://problem/13333511>
Reviewed by Anders Carlsson.
Move the Intrinsic value out of the function-specific part of the union,
and store it next to m_attributes. Reduces the size of HashEntry by 8 bytes.
990 kB progression on Membuster3. (PTUS: 797 kB)
- runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
(HashEntry):
- 4:09 PM Changeset in webkit [144588] by
-
- 2 edits in trunk/Source/WebCore
[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=111214
Reviewed by Adam Barth.
$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
For clarification, it should be renamed to $implContentInternals.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateImplementation):
(WriteData):
- 4:05 PM Changeset in webkit [144587] by
-
- 12 edits in trunk/Source/WebCore
[V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
https://bugs.webkit.org/show_bug.cgi?id=111212
Reviewed by Adam Barth.
The rename I did in r142424 was wrong. Given that getWorld() returns 0
for the main world, it should be named isolatedWorld(). Similarly,
given that getWorldForEnteredContext() returns 0 for the main world,
it should be named isolatedWorldForEnteredContext().
No tests. No change in behavior.
- bindings/v8/CustomElementHelpers.cpp:
(WebCore::CustomElementHelpers::isFeatureAllowed):
- bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::current):
- bindings/v8/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::makeContextWeak):
- bindings/v8/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::isolatedWorld):
- bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):
- bindings/v8/V8Binding.h:
(WebCore::isolatedWorldForEnteredContext):
- bindings/v8/WorldContextHandle.cpp:
(WebCore::WorldContextHandle::WorldContextHandle):
- bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8SVGDocumentCustom.cpp:
(WebCore::wrap):
- bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::constructorCustom):
- 3:56 PM Changeset in webkit [144586] by
-
- 14 edits in branches/safari-534.59-branch
Merge r143988
2013-02-25 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
Reviewed by Beth Dakin.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.
- UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.
- UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.
(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.
(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.
- UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.
Tools:
Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>
Reviewed by Beth Dakin.
Update for WebKit2 changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
- WebKitTestRunner/TestController.h: (TestController):
- 3:54 PM Changeset in webkit [144585] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always.
https://bugs.webkit.org/show_bug.cgi?id=110298
Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-03
Reviewed by Kenneth Rohde Christiansen.
Currently, EFL and Qt turn on ApplyDeviceScaleFactorInCompositor when using
fixed layout, but ApplyDeviceScaleFactorInCompositor is not related to fixed
layout. It is confusing that a platform WebView deals with device view size or
DIP view size case by case. So this patch always turns on
ApplyDeviceScaleFactorInCompositor.
In addition, move the code that turns on ScrollingCoordinatorEnabled to
CoordinatedLayerTreeHost.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
We should make WebPage know new DIP size.
(EwkView::setSize):
When we set ApplyDeviceScaleFactorInCompositor to true, make WebPage
know the DIP size as a view size.
- UIProcess/efl/WebView.cpp:
(WebKit::WebView::updateViewportSize):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
WebPage sends the DIP size to Web Process even when we don't use fixed layout.
- 3:52 PM Changeset in webkit [144584] by
-
- 4 edits in trunk/Source/WebCore
[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
https://bugs.webkit.org/show_bug.cgi?id=111223
Reviewed by Adam Barth.
HTMLDocument::getNamedProperty() is used by DOMWindowShell.
It can be a static method in DOMWindowShell.
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
- bindings/v8/V8DOMWindowShell.cpp:
(WebCore::getNamedProperty):
(WebCore):
(WebCore::getter):
- bindings/v8/custom/V8HTMLDocumentCustom.cpp:
- 3:19 PM Changeset in webkit [144583] by
-
- 24 edits in trunk
Some perf. tests have variances that differ greatly between runs
https://bugs.webkit.org/show_bug.cgi?id=97510
Reviewed by Benjamin Poulain.
PerformanceTests:
In order to control the number of iterations and processes to use from run-perf-tests, always use 20
iterations on all tests except Dromaeo, where even doing 5 iterations is prohibitively slow, by default.
Without this change, it'll become extremely hard for us to tweak the number of iterations and processes
to use from run-perf-tests.
- Animation/balls.html:
- DOM/DOMTable.html:
- DOM/resources/dom-perf.js:
(runBenchmarkSuite.PerfTestRunner.measureTime):
- Dromaeo/resources/dromaeorunner.js:
- Layout/floats_100_100.html:
- Layout/floats_100_100_nested.html:
- Layout/floats_20_100.html:
- Layout/floats_20_100_nested.html:
- Layout/floats_2_100.html:
- Layout/floats_2_100_nested.html:
- Layout/floats_50_100.html:
- Layout/floats_50_100_nested.html:
- Layout/subtree-detaching.html:
- Parser/html5-full-render.html:
- SVG/SvgHitTesting.html:
- resources/runner.js:
- resources/results-template.html:
Tools:
Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
environment on test results (we run each instance after one another, not in parallel).
We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
iterations as it was done previously in single process. These values are hard-coded in perftest.py
and runner.js but they are to be configurable in the future.
Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
metric now reports an array of the length 4 with each element containing an array of 5 iteration
values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.append_group): Renamed from append.
(PerfTestMetric.grouped_iteration_values): Added.
(PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
(PerfTest.init): Takes the number of processes (drivers) to run tests with.
This parameter is only used by SingleProcessPerfTest.
(PerfTest.run): Repeat tests using different driver processes.
(PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
We instead use _ensure_metrics to obtain the matched metrics and store the data there.
(PerfTest._ensure_metrics): Added.
(SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
instances of DumpRenderTree/WebKitTestRunner takes too long.
(SingleProcessPerfTest.init):
(ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
(PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
- Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
_run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
(TestPerfTestMetric.test_append): Updated per name and added some test cases for
grouped_iteration_values.
(TestPerfTest._assert_results_are_correct):
(TestSingleProcessPerfTest): Added.
(TestSingleProcessPerfTest.test_use_only_one_process):
(TestSingleProcessPerfTest.test_use_only_one_process.run_single):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
sample standard deviations since we're now running tests 4 times.
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
LayoutTests:
Use dromaeoIterationCount now that we no longer support iterationCount.
- fast/harness/perftests/runs-per-second-iterations.html:
- 3:02 PM Changeset in webkit [144582] by
-
- 13 edits in branches/safari-534.59-branch
Merge r143976
2013-02-25 Anders Carlsson <andersca@apple.com>
Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Source/WebKit2:
Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):
Tools:
Update for WebKit2 API changes.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
- 2:15 PM Changeset in webkit [144581] by
-
- 6 edits in trunk
[chromium] Remove WebLayerTreeView::setViewportSize call
https://bugs.webkit.org/show_bug.cgi?id=110727
Reviewed by James Robinson.
After https://codereview.chromium.org/12328080 lands,
setViewportSize is called from the Chromium side. The multiplication
by deviceScaleFactor here was prone to off-by-one errors.
The layoutSize() function was only used here so delete it as well.
DumpRenderTree WebViewHost must now call this method as well.
Source/WebKit/chromium:
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateLayerTreeViewport):
- src/WebViewImpl.h:
(WebViewImpl):
Tools:
- DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::updateViewportSize):
- DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
- 2:15 PM Changeset in webkit [144580] by
-
- 4 edits in trunk/Source/WebKit2
Shared Web Workers have an incorrect visible process name
https://bugs.webkit.org/show_bug.cgi?id=111277
Reviewed by Dan Bernstein.
- SharedWorkerProcess/SharedWorkerProcess.cpp:
(WebKit::SharedWorkerProcess::initializeSharedWorkerProcess):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:
(WebKit::SharedWorkerProcess::initializeProcessName):
The SharedWorkerProcess is not an internet plug-in!
- 12:43 PM Changeset in webkit [144579] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r144565. Reverted r144533.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
- 11:57 AM Changeset in webkit [144578] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the Qt build after r144498
https://bugs.webkit.org/show_bug.cgi?id=111272
Reviewed by Eric Seidel.
Update the Qt version of the XML parser to call the new API.
- xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::resumeParsing):
(WebCore::XMLDocumentParser::appendFragmentSource):
- 11:36 AM Changeset in webkit [144577] by
-
- 2 edits in trunk/Source/WebCore
Plug-ins that are appropriately large w.r.t page size should autostart
https://bugs.webkit.org/show_bug.cgi?id=111242
Reviewed by Brady Eidson.
A "full-page" plug-in site should never snapshot. The trick is
how to determine what is full-page. This change implements the
following algorithm.
- The plug-in is in the main frame (not an iframe).
- The plug-in is sized with width and height 100%.
- The displayed area of the plug-in is more than 96% of the viewport area.
This is definitely not foolproof. For example, zombo.com has a slight
border around its plug-in. As the window size gets smaller, the body margin
takes up more than 5% of the width or height, and the plug-in doesn't pass
the tests above.
- html/HTMLPlugInImageElement.cpp:
(WebCore): New static constant: sizingFullPageThresholdPercentage
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements
the rules described above.
- 10:27 AM Changeset in webkit [144576] by
-
- 12 edits in branches/safari-534.59-branch/Source
Merge r143815
2013-02-22 Anders Carlsson <andersca@apple.com>
pluginLoadStrategy should take a WKDictionaryRef for extensibility
https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>
Reviewed by Jessie Berlin.
../WebCore:
Export a symbol needed by WebKit2.
- WebCore.exp.in:
../WebKit2:
Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.
- UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 8:16 AM Changeset in webkit [144575] by
-
- 2 edits in trunk/Source/WebCore
[Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
https://bugs.webkit.org/show_bug.cgi?id=111267
Reviewed by Kentaro Hara.
Allow empty definitions.
- bindings/scripts/IDLParser.pm:
(Parse):
- 7:59 AM Changeset in webkit [144574] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)
Fixes the following build failures:
In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'
Vector<RefPtr<Element> > m_internalSVGReferences;
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type
Vector<RefPtr<Element> > m_internalSVGReferences;
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]
Vector<RefPtr<Element> > m_internalSVGReferences;
3 errors generated.
- rendering/RenderLayerFilterInfo.h: Include Element.h within
ENABLE(SVG). Move ENABLE(SVG) block below unconditional
headers.
- 4:05 AM Changeset in webkit [144573] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix attempt after r144547.
- WebKit.vcproj/WebKitExports.def.in:
- 3:47 AM Changeset in webkit [144572] by
-
- 23 edits3 deletes in trunk
Unreviewed, rolling out r144567.
http://trac.webkit.org/changeset/144567
https://bugs.webkit.org/show_bug.cgi?id=111266
Does not compile on apple-win (Requested by abarth on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-03
.:
- Source/autotools/symbols.filter:
Source/WebCore:
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- loader/icon/IconController.h:
(IconController):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/chromium:
- public/WebFrame.h:
- src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::iconURLs):
- src/WebFrameImpl.h:
(WebFrameImpl):
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
LayoutTests:
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
- fast/dom/icon-url-list-apple-touch.html: Removed.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- platform/chromium-android/fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
- 3:06 AM Changeset in webkit [144571] by
-
- 8 edits in trunk/Source
CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
https://bugs.webkit.org/show_bug.cgi?id=111254
Reviewed by Adam Barth.
Source/WebCore:
We'd like to ensure that early adopters don't get stuck on a prefixed
header; when CSP 1.1 is baked enough to be supported in multiple
browsers, everything should Just Work™.
This patch changes WebKit's behavior regarding CSP_NEXT features.
Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
This patch exposes those features on the canonical header, assuming
that the runtime flag is set. This shouldn't have any effect at all on
ports that haven't yet enabled CSP_NEXT, and will simply clear the way
for a clean deployment to a wider audience once the specification
process is further along.
This change shouldn't have any effect on the existing tests: they
should run just as they did before. The next step will be to adjust
the LayoutTests for 1.1 to prefer the canonical header, but I'll do
that in another patch to reduce churn.
Related, the enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument):
Use the new enum names.
- page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::addDirective):
Drop the 'm_experimental' property from CSPDirectiveList; we'll
control the behavior via the runtime flag from now on.
Also, this fixes a small bug in 'addDirective()': we never threw
unrecognized directive errors for users who were sending the
prefixed header. Oops!
(WebCore::ContentSecurityPolicy::deprecatedHeaderType):
Use the new enum names.
- page/ContentSecurityPolicy.h:
Redefine the enum for clarity: 'PrefixedReport' and 'Report'
rather than 'ReportAllDirectives' and 'ReportStableDirectives'.
Source/WebKit/chromium:
The enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.
- public/WebContentSecurityPolicy.h:
- src/AssertMatchingEnums.cpp:
Rename the Chromium side of the enums.
- 2:47 AM Changeset in webkit [144570] by
-
- 4 edits in trunk/Source
Source/WebCore: Another Windows build fix attempt after r144567.
Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.
- testing/Internals.idl:
Source/WebKit/win: That was a wrong fix. Revert r144569.
- WebKit.vcproj/WebKitExports.def.in:
- 2:34 AM Changeset in webkit [144569] by
-
- 2 edits in trunk/Source/WebKit/win
Windows build fix attempt after r144567.
- WebKit.vcproj/WebKitExports.def.in:
- 2:12 AM Changeset in webkit [144568] by
-
- 116 edits in trunk/Source
Unreviewed attempted build fix. Adds back some includes removed in
http://trac.webkit.org/changeset/144565.
Source/WebCore:
- Modules/mediastream/RTCPeerConnection.cpp:
- bindings/ScriptControllerBase.cpp:
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
(WebCore):
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/FrameLoader.cpp:
- loader/MainResourceLoader.cpp:
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheHost.cpp:
- loader/cache/CachedResource.cpp:
- loader/icon/IconController.cpp:
- page/DOMWindowExtension.cpp:
- page/Frame.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginView.cpp:
- rendering/HitTestResult.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResource.cpp:
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
(WebCore):
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
(WebCore):
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 1:54 AM Changeset in webkit [144567] by
-
- 20 edits3 adds in trunk
<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
https://bugs.webkit.org/show_bug.cgi?id=109061
Patch by Ruslan Abdikeev <aruslan@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
.:
- Source/autotools/symbols.filter:
Source/WebCore:
Test: fast/dom/icon-url-list-apple-touch.html
Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.
- WebCore.exp.in:
- dom/Document.cpp:
(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):
- dom/Document.h:
(Document):
- loader/icon/IconController.cpp:
(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):
- testing/Internals.cpp:
(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().
- fast/dom/icon-url-change.html:
- fast/dom/icon-url-list-apple-touch-expected.txt: Added.
- fast/dom/icon-url-list-apple-touch.html: Added.
- fast/dom/icon-url-list.html:
- fast/dom/icon-url-property.html:
- 1:28 AM Changeset in webkit [144566] by
-
- 4 edits2 adds in trunk
CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
https://bugs.webkit.org/show_bug.cgi?id=111208
Reviewed by Adam Barth.
Source/WebCore:
Developers in the wild have been observed to serve a report-only CSP
header with a policy that doesn't contain a 'report-uri' directive.
This has zero effect, of course, and we should help them understand
that by throwing a warning up on the console.
Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::isReportOnly): Added.
(WebCore::CSPDirectiveList::reportURIs): Added.
(WebCore::CSPDirectiveList::create):
After creating a CSPDirectiveList, check whether it's in
report-only mode without a report-uri. If so, warn the developer.
(WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.
Write an exciting message to the console, warning the developer
about her expensive no-op machine.
LayoutTests:
- http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html: Added.
- 1:16 AM Changeset in webkit [144565] by
-
- 206 edits7 deletes in trunk/Source
Unreviewed rollout of http://trac.webkit.org/r144530
As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
large number of ASSERTs in chromium-win.
Source/WebCore:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/mediastream/RTCPeerConnection.cpp:
- Modules/notifications/Notification.cpp:
- Target.pri:
- WebCore.exp.in:
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/ScriptControllerBase.cpp:
- bindings/js/JSNodeCustom.cpp:
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptSourceCode.h:
(WebCore):
- bindings/objc/DOM.mm:
- bindings/v8/ScriptController.cpp:
- bindings/v8/V8DOMWindowShell.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
- css/CSSFontFaceSource.h:
- css/CSSFontSelector.cpp:
- css/WebKitCSSSVGDocumentValue.cpp:
- css/WebKitCSSSVGDocumentValue.h:
(WebCore):
- dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
- dom/ContainerNode.cpp:
- dom/DOMImplementation.cpp:
- dom/PendingScript.h:
- dom/ScriptElement.cpp:
- dom/ScriptElement.h:
- history/CachedFrame.cpp:
- html/DOMURL.cpp:
- html/HTMLAnchorElement.cpp:
- html/HTMLAppletElement.cpp:
- html/HTMLElement.cpp:
- html/HTMLEmbedElement.cpp:
- html/HTMLFrameSetElement.cpp:
- html/HTMLHtmlElement.cpp:
- html/HTMLImageElement.cpp:
- html/HTMLObjectElement.cpp:
- html/HTMLPlugInElement.cpp:
- html/ImageDocument.cpp:
- html/ImageInputType.cpp:
- html/MediaDocument.cpp:
- html/PluginDocument.cpp:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
- html/parser/HTMLConstructionSite.cpp:
- html/parser/HTMLParserOptions.cpp:
- html/parser/HTMLScriptRunner.h:
- html/parser/XSSAuditor.cpp:
- html/parser/XSSAuditorDelegate.cpp:
- inspector/InspectorDebuggerAgent.cpp:
- inspector/InspectorFileSystemAgent.cpp:
- inspector/InspectorFrontendHost.cpp:
- inspector/InspectorInstrumentation.h:
(WebCore):
- inspector/InspectorPageAgent.cpp:
- inspector/NetworkResourcesData.cpp:
- inspector/NetworkResourcesData.h:
(WebCore):
- loader/CookieJar.cpp:
- loader/CrossOriginAccessControl.cpp:
- loader/CrossOriginAccessControl.h:
(WebCore):
- loader/CrossOriginPreflightResultCache.h:
- loader/DocumentThreadableLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
- loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
- loader/ImageLoader.cpp:
- loader/ImageLoader.h:
- loader/LinkLoader.h:
(WebCore):
- loader/MainResourceLoader.cpp:
- loader/MainResourceLoader.h:
(WebCore):
- loader/MixedContentChecker.cpp:
- loader/PingLoader.cpp:
- loader/PolicyChecker.h:
(WebCore):
- loader/ProgressTracker.cpp:
- loader/SubframeLoader.cpp:
- loader/SubresourceLoader.cpp:
- loader/TextTrackLoader.cpp:
- loader/TextTrackLoader.h:
(WebCore):
- loader/ThreadableLoader.h:
- loader/appcache/ApplicationCacheGroup.cpp:
- loader/appcache/ApplicationCacheGroup.h:
(WebCore):
- loader/appcache/ApplicationCacheHost.cpp:
- loader/archive/cf/LegacyWebArchive.cpp:
- loader/cache/CachedFont.cpp:
- loader/cache/CachedFont.h:
(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):
- loader/cache/CachedFontClient.h: Removed.
- loader/cache/CachedImage.cpp:
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):
- loader/cache/CachedRawResourceClient.h: Removed.
- loader/cache/CachedResource.cpp:
- loader/cache/CachedResourceHandle.cpp:
(WebCore):
- loader/cache/CachedResourceHandle.h:
(WebCore):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
- loader/cache/CachedSVGDocument.h:
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):
- loader/cache/CachedSVGDocumentClient.h: Removed.
- loader/cache/CachedSVGDocumentReference.cpp: Removed.
- loader/cache/CachedSVGDocumentReference.h:
(WebCore):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
- loader/cache/CachedStyleSheetClient.h:
(WebCore):
- loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
- loader/chromium/CachedRawResourceChromium.cpp:
- loader/icon/IconController.cpp:
- loader/icon/IconLoader.h:
- loader/mac/ResourceLoaderMac.mm:
- page/DOMWindowExtension.cpp:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore):
(WebCore::Frame::reportMemoryUsage):
- page/Frame.h:
(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):
- page/PerformanceNavigation.cpp:
- page/PerformanceTiming.cpp:
- page/PointerLockController.cpp:
- page/Settings.cpp:
- page/animation/CSSPropertyAnimation.cpp:
- platform/chromium/PasteboardChromium.cpp:
- platform/efl/ErrorsEfl.cpp:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/filters/FilterOperation.cpp:
(WebCore):
- platform/graphics/filters/FilterOperation.h:
(WebCore):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/gtk/ErrorsGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
- platform/gtk/PasteboardHelper.h:
- platform/mac/ClipboardMac.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/HTMLConverter.mm:
- platform/mac/PasteboardMac.mm:
- platform/network/AuthenticationChallengeBase.cpp:
- platform/network/cf/CookieJarCFNet.cpp:
- platform/network/cf/ResourceRequestCFNet.cpp:
- platform/network/mac/CookieStorageMac.mm:
- platform/qt/PasteboardQt.cpp:
- plugins/DOMMimeType.cpp:
- plugins/PluginRequest.h: Removed.
- plugins/PluginStream.h:
(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):
- plugins/PluginStreamClient.h: Removed.
- plugins/PluginView.cpp:
- plugins/PluginView.h:
(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
- rendering/HitTestResult.cpp:
- rendering/InlineFlowBox.cpp:
- rendering/RenderBox.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderImage.cpp:
- rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::RenderImageResource):
(WebCore):
- rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):
- rendering/RenderImageResourceStyleImage.cpp:
- rendering/RenderLayer.cpp:
- rendering/RenderLayerBacking.cpp:
- rendering/RenderLayerFilterInfo.h:
(WebCore):
- rendering/RenderListItem.cpp:
- rendering/RenderListMarker.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- rendering/RenderTableCol.cpp:
- rendering/RenderTableRow.cpp:
- rendering/RenderTableSection.cpp:
- rendering/style/StyleCachedShader.h:
- rendering/style/StyleCustomFilterProgram.cpp: Removed.
- rendering/style/StyleCustomFilterProgram.h:
(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
- svg/SVGFEImageElement.h:
- svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
- svg/SVGImageLoader.cpp:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/graphics/SVGImageCache.cpp:
- testing/MockPagePopupDriver.cpp:
- xml/XSLStyleSheet.h:
(WebCore):
- xml/XSLTProcessorLibxslt.cpp:
- xml/parser/XMLDocumentParser.cpp:
- xml/parser/XMLDocumentParser.h:
- xml/parser/XMLDocumentParserLibxml2.cpp:
Source/WebKit/chromium:
- src/ApplicationCacheHost.cpp:
- src/AssociatedURLLoader.cpp:
- src/EditorClientImpl.cpp:
- src/SharedWorkerRepository.cpp:
- src/WebDataSourceImpl.cpp:
- src/WebFrameImpl.h:
(WebCore):
- src/WebNode.cpp:
- src/WebSharedWorkerImpl.cpp:
- tests/FrameLoaderClientImplTest.cpp:
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- ewk/ewk_frame.cpp:
Source/WebKit/gtk:
- webkit/webkitwebpolicydecision.cpp:
Source/WebKit/mac:
- DOM/WebDOMOperations.mm:
- Misc/WebNSPasteboardExtras.mm:
- WebCoreSupport/WebFrameNetworkingContext.mm:
- WebView/WebRenderLayer.mm:
- WebView/WebRenderNode.mm:
Source/WebKit/qt:
- WebCoreSupport/NotificationPresenterClientQt.cpp:
- WebCoreSupport/QWebPageAdapter.cpp:
Source/WebKit2:
- NetworkProcess/HostRecord.h:
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/NetworkResourceLoader.h:
(WebCore):
- Shared/WebRenderLayer.cpp:
- Shared/WebRenderObject.cpp:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
- WebProcess/WebPage/mac/WebPageMac.mm:
- WebProcess/WebProcess.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- 12:56 AM Changeset in webkit [144564] by
-
- 2 edits in trunk/Source/WebKit/chromium
WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779
Patch by Ankur Taly <ataly@google.com> on 2013-03-03
Reviewed by Kentaro Hara.
- WebKit.gyp:
- 12:52 AM Changeset in webkit [144563] by
-
- 4 edits in trunk/Source/WebCore
[V8] Remove TranslateParameter() from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=111218
Reviewed by Adam Barth.
TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
but there is no non-custom method that uses TimeoutHandler.
The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
However, the latest spec uses 'any' instead of TimeoutHandler.
http://dev.w3.org/html5/spec-LC/timers.html
Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
(Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
in custom bindings.)
No tests. No change in behavior.
- bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
- page/DOMWindow.idl:
- workers/WorkerContext.idl:
- 12:46 AM Changeset in webkit [144562] by
-
- 4 edits1 add in trunk/Source
keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
https://bugs.webkit.org/show_bug.cgi?id=85642
Source/WebCore:
Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.
Patch by James Weatherall <wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
- platform/chromium/KeyCodeConversionGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
Source/WebKit/chromium:
Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.
Patch by James Weatherall <wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.
- WebKit.gypi:
- tests/KeyCodeConversionTestGtk.cpp: Added.
(WebCore):
(WebCore::TEST):
- 12:33 AM Changeset in webkit [144561] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION(144520): Does not compile on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=111261
Unreviewed rollout of http://trac.webkit.org/changeset/144520. This
patch does not compile for chromium-win. See the bug for the compile
error.
- rendering/ExclusionShapeInsideInfo.cpp:
- rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentRange):
(WebCore::LineSegmentRange::LineSegmentRange):
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::exclusionShapeInsideInfo):
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
- rendering/RenderBlock.h:
(WebCore):
(RenderBlock):
(RenderBlockRareData):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine):
Mar 2, 2013:
- 11:31 PM Changeset in webkit [144560] by
-
- 10 edits in branches/safari-534.59-branch
Merge r143790
2013-02-22 Anders Carlsson <andersca@apple.com>
Source/WebKit2:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
<rdar://problem/13265303>
Reviewed by Sam Weinig.
Move the pluginLoadPolicy callback to the page loader client where it belongs.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebLoaderClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h: (WebLoaderClient):
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit):
- UIProcess/WebUIClient.h: (WebUIClient):
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage):
Tools:
Move pluginLoadPolicy to the page loader client
https://bugs.webkit.org/show_bug.cgi?id=110635
Reviewed by Sam Weinig.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 11:13 PM Changeset in webkit [144559] by
-
- 4 edits in trunk
REGRESSION (r144517): IndexedDB layout test failures on GTK
https://bugs.webkit.org/show_bug.cgi?id=111243
Reviewed by Martin Robinson.
Source/WebCore:
Changes to the custom JSC bindings for IDBAny are required after r144517,
specifically the case of IDBAny object having the KeyPathType type has to be covered.
These changes are analogous to those made to the V8 bindings in the mentioned commit.
No new tests - already covered by existing tests.
- bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS): A helper function that wraps an IDBKeyPath into a JSValue.
(WebCore): Shuffle the order inside the switch statement a bit to match the V8 custom bindings.
Cover the case where the IDBAny object has the KeyPathType, calling the new helper method.
LayoutTests:
- platform/gtk/TestExpectations: Removing failure expectations for IDB tests that again pass.
- 10:59 PM Changeset in webkit [144558] by
-
- 4 edits2 adds in branches/safari-534.59-branch
Merge r142919
2013-02-14 Anders Carlsson <andersca@apple.com>
Add WKContextIsPlugInUpdateAvailable
https://bugs.webkit.org/show_bug.cgi?id=109862
<rdar://problem/13173140>
Reviewed by Sam Weinig.
Source/WebKit2:
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm: Renamed from Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.cpp. (WKContextGetProcessSuppressionEnabled): (WKContextSetProcessSuppressionEnabled): (WKContextIsPlugInUpdateAvailable):
- WebKit2.xcodeproj/project.pbxproj:
WebKitLibraries:
Roll WebKitSystemInterface DEPS.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 10:55 PM Changeset in webkit [144557] by
-
- 2 edits in trunk/Source/WebCore
Another try at fixing the build.
- 10:33 PM Changeset in webkit [144556] by
-
- 9 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r142017
2013-02-06 Anders Carlsson <andersca@apple.com>
Pass the document source URL to the pluginLoadPolicy callback
https://bugs.webkit.org/show_bug.cgi?id=109084
<rdar://problem/13154516>
Reviewed by Andreas Kling.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebPageProxy.h: (WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
- 10:31 PM Changeset in webkit [144555] by
-
- 2 edits in trunk/Source/WebCore
Try to fix build.
- 10:24 PM Changeset in webkit [144554] by
-
- 5 edits in branches/safari-534.59-branch/Source/WebKit2
Merge r141923
2013-02-05 Anders Carlsson <andersca@apple.com>
WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>
Reviewed by Sam Weinig.
Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath):
- UIProcess/WebUIClient.cpp: (WebKit::toWKPluginLoadPolicy): (WebKit): (WebKit::toPluginModuleLoadPolicy): (WebKit::WebUIClient::pluginLoadPolicy):
- UIProcess/WebUIClient.h: (WebUIClient):
- 9:55 PM Changeset in webkit [144553] by
-
- 16 edits in trunk/Source
Cut down the number of source files that depend on Clipboard.h
https://bugs.webkit.org/show_bug.cgi?id=110030
Reviewed by Ryosuke Niwa.
Source/WebCore:
I am doing some work on Clipboard and it's better to recompile 50 files
each time we touch the header instead of 700. Also cut down on includes
of DragState.h.
- WebCore.exp.in: Updated for new MouseEvent::create function.
- dom/ClipboardEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- dom/ClipboardEvent.h: Forward declared Clipboard instead of including
Clipboard.h. Also made some overrides private because they can be.
- dom/DataTransferItem.h: Removed unneeded include of Clipboard.h.
- dom/MouseEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
(WebCore::MouseEvent::create): Made the create function non-inline
since we can't compile it without including Clipboard.h and we don't
want to include Clipboard.h in the header. This is not so commonly
used or so hot that this needs to be inlined.
- dom/MouseEvent.h: Forward declared Clipboard instead of including
Clipboard.h. Made MouseEvent::create a non-inline function and also
used overloading instead of default arguments, since we can't compile
a default argument of type PassRefPtr<Clipboard> without including
Clipboard.h.
- dom/WheelEvent.cpp: Added include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- dom/WheelEvent.h: Forward declare PlatformWheelEvent since it is used
in this header. Previously we'd get it indirectly from including a header
that included Clipboard.h.
- editing/Editor.cpp: Added include of Clipboard.h since we use it here
and the world no longer includes it everywhere.
- inspector/InspectorDebuggerAgent.cpp: Added include of CachedResource.h.
We used to get this indirectly through Clipboard.h.
- inspector/InspectorFrontendHost.cpp: Added includes of ResourceError.h
and ResourceResponse.h. We used to get these indirectly through Clipboard.h.
Also removed unneeded include of <wtf/RefPtr.h>.
- inspector/NetworkResourcesData.cpp: Added include of CachedResource.h.
We used to get this indirectly through Clipboard.h.
- loader/PingLoader.cpp: Added include of ResourceResponse.h.
We used to get this indirectly through Clipboard.h.
- page/DragController.cpp: Added include of DragState.h.
We used to get this indirectly through EventHandler.h
- page/EventHandler.h: Forward declared DragState and Element instead of
including DragState.h. Also added an include of LayoutPoint.h, which we
used to get indirectly through DragState.h.
Source/WebKit/chromium:
- src/SharedWorkerRepository.cpp: Add include of ResourceResponse.h
here. We used to get this indirectly through Clipboard.h.
Source/WebKit/mac:
- WebView/WebPDFView.mm: Add include of Clipboard.h since we use it
here and the world no longer includes it everywhere.
- 9:47 PM Changeset in webkit [144552] by
-
- 13 edits1 add in trunk
StringHasher functions require alignment that call sites do not all guarantee
https://bugs.webkit.org/show_bug.cgi?id=110171
Reviewed by Benjamin Poulain.
Source/WebCore:
- platform/graphics/WidthCache.h:
(WebCore::WidthCache::SmallStringKey::SmallStringKey): Use the newly added
addCharactersAssumingAligned to make sure we don't slow this call site down.
It's safe since this code always adds characters two at a time.
Source/WTF:
The StringHasher class is optimized for clients who pass it two characters at
a time. However, the function named addCharacters did not make this clear to
clients, and one calculateStringHashAndLengthFromUTF8MaskingTop8Bits got it wrong.
Fix by making addCharacters work regardless of hasher alignment and adding a new
function, addCharactersAssumingAligned, for use when we want a faster path and can
guarantee we are adding characters two at a time.
- wtf/StringHasher.h:
(WTF::StringHasher::addCharactersAssumingAligned): Renamed the addCharacters function
addCharactersAssumingAligned, since it only works if the hasher is currently aligned,
meaning it contains an even number of characters. The function already asserts
that this is true, but the calculateStringHashAndLengthFromUTF8MaskingTop8Bits
function was using it in cases where the assertion could fire. Also updated to
call addCharactersInternal by its new name. Also added some new overloads that take
data pointers and lengths so callers can always use addCharactersAssumingAligned
instead of addCharacters if they know the hasher is aligned.
(WTF::StringHasher::addCharacter): Updated to call the public
addCharactersAssumingAligned function since that's simpler and a bit cleaner.
(WTF::StringHasher::addCharacters): Added functions with this name that handle
the case where the hasher is not aligned. These will be called by existing call sites
that were formerly using the function named addCharactersAssumingAligned above.
Also add an overload that works with the default converter automatically.
(WTF::StringHasher::computeHashAndMaskTop8Bits): Changed to call
addCharactersAssumingAligned to eliminate copied and pasted code. The hasher is empty,
so definitely aligned.
(WTF::StringHasher::computeHash): Ditto.
(WTF::StringHasher::addCharactersInternal): Renamed from addCharactersToHash, since
the former name did not make clear how this differs from the public functions.
The real difference is that this is like addCharactersAssumingAligned, but without
the assertion, so addCharactersAssumingAligned is called instead, even within the
class's implementation.
Tools:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.gypi:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/WTF.pro:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
Added the StringHasher.cpp file.
- TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
for the functions in the StringHasher class.
- 8:05 PM Changeset in webkit [144551] by
-
- 19 edits1 add in branches/safari-534.59-branch
Merge r141486
2013-01-31 Brian Weinstein <bweinstein@apple.com>
Add a call to the page UI client to determine if a plug-in should load
https://bugs.webkit.org/show_bug.cgi?id=108407
<rdar://problem/13066332>
Source/WebKit2:
Reviewed by Anders Carlsson.
This patch adds a client call to the WKPageUIClient to be called to determine
whether or not a plug-in should load.
- UIProcess/API/C/WKPage.h: Add shouldLoadPlugin.
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Moved from WebProcessProxy, and added a call to
m_uiClient.shouldInstantiatePlugin.
- UIProcess/WebPageProxy.h:
- UIProcss/WebPageProxy.messages.in: Moved GetPluginPath from WebProcessProxy to WebPageProxy.
- UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getPluginPath): Moved to WebPageProxy.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::shouldInstantiatePlugin): Return that we should load the plug-in if
the client function isn't defined, and call the function if it is.
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Add an entry for the new
client function.
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): Send the message to the WebPageProxy, not the WebProcessProxy. (WebKit::WebPage::canPluginHandleResponse): Made a member function, so it can call sendSync, and
send the message to the WebPageProxy, not the WebProcessProxy.
- WebProcess/WebPage/WebPage.h:
Tools:
Add entries for the new function in the necessary structs.
Reviewed by Anders Carlsson.
- MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
- 6:53 PM Changeset in webkit [144550] by
-
- 5 edits in trunk/Source/WebKit2
WebKit2 is missing the setShowsURLsInToolTips preference
https://bugs.webkit.org/show_bug.cgi?id=111259
<rdar://problem/12991891>
Reviewed by Maciej Stachowiak.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetShowsURLsInToolTipsEnabled):
(WKPreferencesGetShowsURLsInToolTipsEnabled):
- UIProcess/API/C/WKPreferencesPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe it through.
- 5:45 PM Changeset in webkit [144549] by
-
- 2 edits in trunk/Source/WebCore
XSSAuditor has a subtle race condition when used with the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=111253
Reviewed by Eric Seidel.
We were refing and derefing a StringImpl for a main-thread
AtomicString. Using QualifiedNames on the background thread is very
fragile and we should figure out a more robust solution.
- html/parser/XSSAuditor.cpp:
(WebCore::findAttributeWithName):
- 4:57 PM Changeset in webkit [144548] by
-
- 2 edits in trunk/Source/WebKit/win
Export a missing symbol after r144547.
Unreviewed.
- WebKit.vcproj/WebKitExports.def.in:
- 4:08 PM Changeset in webkit [144547] by
-
- 47 edits in trunk
Move computedStyleIncludingVisitedInfo from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=109772
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-02
Reviewed by Andreas Kling.
Source/WebCore:
The function computedStyleIncludingVisitedInfo() is purely internal to WebCore,
it is better defined on Internals than on TestRunner.
- testing/Internals.cpp:
(WebCore::Internals::computedStyleIncludingVisitedInfo):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit/blackberry:
- WebKitSupport/DumpRenderTreeSupport.cpp:
- WebKitSupport/DumpRenderTreeSupport.h:
(DumpRenderTreeSupport):
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
Source/WebKit/gtk:
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
- WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
- WebCoreSupport/DumpRenderTreeSupportQt.h:
Source/WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
- WebProcess/WebPage/WebFrame.h:
(WebFrame):
Tools:
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
- DumpRenderTree/TestRunner.h:
(TestRunner):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
- DumpRenderTree/efl/TestRunnerEfl.cpp:
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
- DumpRenderTree/mac/TestRunnerMac.mm:
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
- DumpRenderTree/win/TestRunnerWin.cpp:
- DumpRenderTree/wx/TestRunnerWx.cpp:
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
LayoutTests:
Update the tests.
- fast/history/multiple-classes-visited.html:
- fast/history/nested-visited-test.html:
- fast/history/self-is-visited.html:
- fast/history/sibling-visited-test.html:
- fast/loader/stateobjects/state-url-sets-links-visited.html:
- platform/win/TestExpectations: unskip the tests.
- platform/chromium/TestExpectations:
- 3:42 PM Changeset in webkit [144546] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r143637): Export ScriptController::javaScriptContext() on iOS
<http://webkit.org/b/106059>
Fixes the following build failure:
Undefined symbols for architecture armv7:
"ZN7WebCore16ScriptController17javaScriptContextEv", referenced from:
-[WebFrame javaScriptContext] in WebFrame.o
ZN20WebFrameLoaderClient35dispatchDidClearWindowObjectInWorldEPN7WebCore15DOMWrapperWorldE in WebFrameLoaderClient.o
ld: symbol(s) not found for architecture armv7
- WebCore.exp.in: Export ScriptController::javaScriptContext()
even more unconditionally.
- 3:36 PM Changeset in webkit [144545] by
-
- 2 edits in trunk/Source/WebKit/mac
BUILD FIX (r143637): Predeclare JSContext as an Objective-C class
<http://webkit.org/b/106059>
Fixes the following build failure:
In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:215:64: error: expected a type
- (void)webView:(WebView *)webView didCreateJavaScriptContext:(JSContext *)context forFrame:(WebFrame *)frame;
1 error generated.
- WebView/WebFrameLoadDelegate.h: Add @class JSContext
declaration.
- 1:06 PM Changeset in webkit [144544] by
-
- 4 edits in trunk/Source/WebCore
Remove two unnecessary mallocs from the main-thread-parser code path
https://bugs.webkit.org/show_bug.cgi?id=111249
Reviewed by Adam Barth.
I noticed these while fixing up our Vector -> String conversions
but never went back to fix the FIXME.
AtomicString(Vector<UChar, capacity>) is smart enough to avoid mallocing
if the represented string is already in the AtomicString table. It
also handles 8bit vs. 16bit and empty() just like nameString() does.
I also removed a 3rd caller to nameString() in the XSSAuditor which
was causing an unnecessary malloc in both the main and background
thread parser paths.
- html/parser/AtomicHTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
- html/parser/HTMLToken.h:
- html/parser/XSSAuditor.cpp:
(WebCore):
(WebCore::threadSafeMatch):
(WebCore::hasName):
- 10:09 AM Changeset in webkit [144543] by
-
- 2 edits in trunk/Source/WebCore
constructTreeFromCompactHTMLToken should call clearExternalCharacters
https://bugs.webkit.org/show_bug.cgi?id=111248
Reviewed by Adam Barth.
I don't know how to write a test for this. It's possible characters()
is never accessed from HTMLStackItem::token(), but it's better to be
safe than sorry here.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::constructTreeFromCompactHTMLToken):
- 7:02 AM Changeset in webkit [144542] by
-
- 3 edits2 adds in trunk
Text overflow ellipsis wrong color when using webkit-text-fill-color
https://bugs.webkit.org/show_bug.cgi?id=54841
Reviewed by David Hyatt.
Source/WebCore:
Take -webkit-text-fill-color into account for ellipsis painting.
Test: fast/css/text-overflow-ellipsis-color.html
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
LayoutTests:
Add reftest for using -webkit-text-fill-color in combination with text-overflow:ellipsis.
- fast/css/text-overflow-ellipsis-color-expected.html: Added.
- fast/css/text-overflow-ellipsis-color.html: Added.
- 6:39 AM Changeset in webkit [144541] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unskip some passing tests.
- platform/efl/TestExpectations: Remove tests that pass after
- 4:36 AM Changeset in webkit [144540] by
-
- 4 edits in trunk/Source/WebKit/win
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- WebCoreSupport/WebFrameNetworkingContext.h:
- WebCoreSupport/WebPlatformStrategies.cpp:
- 3:59 AM Changeset in webkit [144539] by
-
- 10 edits in branches/chromium/1410
Merge 144352
REGRESSION: INPUT_MULTIPLE_FIELDS_UI: Changing CSS display property on input[type=date] unexpectedly makes another line for ::-webkit-calendar-picker-indicator
https://bugs.webkit.org/show_bug.cgi?id=110974
Reviewed by Kentaro Hara.
Source/WebCore:
Input elements with the multiple fields UI require flexible box
layout.
- If display:inline or display:inline-block is specified, we replace it with display:inline-flex.
- If display:block is specified, we replace it with display:flex.
- If other display value is specified, we use it as is, but it won't wrap inside an input element because we have display:inline-block for ::-webkit-calendar-pixker-indicaotor.
r144184 was incomplete. It avoided the wrapping issue, but it
didn't make spin buttons and calendar arrows right-aligned.
Tests: Update fast/forms/date/date-apparance-basic.html
- css/html.css:
(input::-webkit-calendar-picker-indicator):
Add display:inline-block in orde to avoid line-wrapping.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::customStyleForRenderer):
Move the code to BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer.
- html/InputType.cpp:
(WebCore::InputType::customStyleForRenderer): Added.
- html/InputType.h:
(InputType): Add customStyleForRenderer, and remove
shouldApplyLocaleDirection.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::customStyleForRenderer):
Moved the code from HTMLInputElement::customStyleForRenderer, and
add display property updatting code.
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
Add customStyleForRenderer, and remove shouldApplyLocaleDirection.
LayoutTests:
- fast/forms/date/date-appearance-basic-expected.txt:
- fast/forms/date/date-appearance-basic.html:
- platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
- platform/chromium/TestExpectations:
TBR=tkent@chromium.org
BUG=crbug.com/178175
- 2:14 AM Changeset in webkit [144538] by
-
- 3 edits in trunk/Source/WebKit/win
Yet another build fix attempt after r144530.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- WebCoreSupport/WebPlatformStrategies.cpp:
- 1:54 AM Changeset in webkit [144537] by
-
- 2 edits in trunk/Source/WebKit/win
Another build fix attempt after r144530.
- WebCoreSupport/WebFrameNetworkingContext.cpp:
- 1:07 AM Changeset in webkit [144536] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in my previous commit (r144534).
- platform/win/PasteboardWin.cpp:
- 1:02 AM Changeset in webkit [144535] by
-
- 22 edits2 copies5 adds in trunk
[WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView.
https://bugs.webkit.org/show_bug.cgi?id=110818
Reviewed by Kenneth Russell.
As per OES_texture_half_float specification texImage2D and texSubImage2D entry
points taking ArrayBufferView should extended to accept null with the pixel type
HALF_FLOAT_OES.
Source/WebCore:
Tests: fast/canvas/webgl/oes-texture-half-float-not-supported.html
fast/canvas/webgl/oes-texture-half-float.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.gypi:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::toJS):
- bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toV8Object):
- html/canvas/OESTextureHalfFloat.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(WebCore::OESTextureHalfFloat::OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::~OESTextureHalfFloat):
(WebCore::OESTextureHalfFloat::getName):
(WebCore::OESTextureHalfFloat::create):
- html/canvas/OESTextureHalfFloat.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
(WebCore):
(OESTextureHalfFloat):
- html/canvas/OESTextureHalfFloat.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
- html/canvas/WebGLExtension.h:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncData):
- html/canvas/WebGLRenderingContext.h:
(WebCore):
(WebGLRenderingContext):
- html/canvas/WebGLRenderingContext.idl:
- platform/graphics/Extensions3D.h:
(Extensions3D):
- platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsTypes3D.h:
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D):
LayoutTests:
- fast/canvas/webgl/constants.html:
- fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-not-supported-expected.txt: Added.
- fast/canvas/webgl/oes-texture-half-float-not-supported.html: Added.
- fast/canvas/webgl/oes-texture-half-float.html: Added.
- 12:57 AM Changeset in webkit [144534] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix attempt after r144530.
- platform/win/PasteboardWin.cpp:
