⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 4, 2013:

11:59 PM Changeset in webkit [144734] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2013-03-04 Kinuko Yasuda <​kinuko@chromium.org>

Unreviewed, adding crashing test to the expectations.

  • platform/chromium/TestExpectations:
11:56 PM Changeset in webkit [144733] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove deprecated WebTestRunner::setFocus API
​https://bugs.webkit.org/show_bug.cgi?id=111354

Reviewed by James Robinson.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):

11:44 PM Changeset in webkit [144732] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-text-stroke returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=111018

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.

Source/WebCore:

Test: fast/css/getPropertyValue-webkit-text-stroke.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added test for getPropertyValue("-webkit-text-stroke").

  • fast/css/getPropertyValue-webkit-text-stroke-expected.txt: Added.
  • fast/css/getPropertyValue-webkit-text-stroke.html: Added.
11:42 PM Changeset in webkit [144731] by jochen@chromium.org
  • 7 edits in trunk/Tools

Run the bindings generation tests on EWS and CQ bots
​https://bugs.webkit.org/show_bug.cgi?id=111358

Reviewed by Adam Barth.

The tests are super fast and not flaky.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_bindings_tests_command):

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_webkit_tests_command):
(MockPort):
(MockPort.run_bindings_tests_command):

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:
11:33 PM Changeset in webkit [144730] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getPropertyValue for -webkit-columns returns null, should compute the shorthand value
​https://bugs.webkit.org/show_bug.cgi?id=111011

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexander Pavlov.

Source/WebCore:

Test: fast/css/getPropertyValue-columns.html

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):

LayoutTests:

Added test for getPropertyValue("-webkit-columns").

  • fast/css/getPropertyValue-columns-expected.txt: Added.
  • fast/css/getPropertyValue-columns.html: Added.
11:31 PM Changeset in webkit [144729] by vsevik@chromium.org
  • 5 edits in trunk

Web Inspector: Do not accumulate file system files, add them to workspace immediately
​https://bugs.webkit.org/show_bug.cgi?id=111325

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.populate.fileLoaded):
(WebInspector.FileSystemProjectDelegate.prototype.populate):

  • inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem.prototype.innerCallback):
(WebInspector.IsolatedFileSystem.prototype.requestFilesRecursive):

LayoutTests:

  • inspector/file-system-project.html:
11:20 PM Changeset in webkit [144728] by kinuko@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix attempt.

floor method is ambigious so explicitly specify the type.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

11:13 PM Changeset in webkit [144727] by Chris Fleizach
  • 16 edits
    2 adds in trunk

AX: cellForColumnAndRow fails for tables with hidden table cells
​https://bugs.webkit.org/show_bug.cgi?id=110050

Reviewed by Tim Horton.

Source/WebCore:

If a table had hidden cells, then accessibility code was being confused in a few ways.
1) The cellForColumnAndRow method would return the wrong information since that was

using the RenderTableSection to retrieve a cell, which did not have the same data as the AXTable

2) The way we were adding children made it impossible to determine column and row range because we

would skip rows that had hidden children

3) AccessibilityARIAGrid and AccessibilityTable were using different methods for cellForColumnAndRow

The fix does a few things to make things right:
1) Always add an accessibility row, even if there are no visible cells in that row.
2) Have one method for AXTable and AXARIAGrid for cellForColumnAndRow.
3) Change cellForColumnAndRow to query the accessibility children rather than the RenderTableSection in determining the row, col info.
4) cellForColumnAndRow should use unsigned values instead of int values.

Test: accessibility/table-with-hidden-head-section.html

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore):

  • accessibility/AccessibilityARIAGrid.h:

(AccessibilityARIAGrid):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):

  • accessibility/AccessibilityARIAGridCell.h:

(AccessibilityARIAGridCell):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTable.h:

(WebCore):
(AccessibilityTable):

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::rowIndexRange):
(WebCore::AccessibilityTableCell::columnIndexRange):

  • accessibility/AccessibilityTableCell.h:

(AccessibilityTableCell):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetColumnAtIndex):
(webkitAccessibleTableGetRowAtIndex):
(webkitAccessibleTableGetColumnExtentAt):
(webkitAccessibleTableGetRowExtentAt):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

  • rendering/RenderTableSection.h:

(RenderTableSection):
(WebCore::RenderTableSection::rowRendererAt):

Source/WebKit/chromium:

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::cellColumnIndex):
(WebKit::WebAccessibilityObject::cellColumnSpan):
(WebKit::WebAccessibilityObject::cellRowIndex):
(WebKit::WebAccessibilityObject::cellRowSpan):

LayoutTests:

  • accessibility/table-with-hidden-head-section-expected.txt: Added.
  • accessibility/table-with-hidden-head-section.html: Added.
  • platform/chromium/TestExpectations:
10:57 PM Changeset in webkit [144726] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getAttribute does not behave correctly for mixed-case attributes on HTML elements
​https://bugs.webkit.org/show_bug.cgi?id=105713

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-04
Reviewed by Andreas Kling.

Source/WebCore:

getAttribute() and getAttributeNode() APIs do not convert the
passed attribute name to lowercase before comparing against the
existing attributes.
The specification however states that the passed name should
be converted to ASCII lowercase before checking for the existence
of the given attribute. [www.w3.org/TR/domcore/#dom-element-getattribute]

Test: fast/dom/Element/getAttribute-case-insensitivity.html

  • dom/Element.h:

(WebCore::ElementData::getAttributeItemIndex):
getAttributeItemIndex() accepts a bool param 'shouldIgnoreAttributeCase'
which specifies whether the attribute's case should be ignored
before comparison. But inspite of this param's value we still carry
out a case sensitive search.
Have modified the same to convert the passed attribute's name to
lowercase if 'shouldIgnoreAttributeCase' is true.

LayoutTests:

  • fast/dom/Element/getAttribute-case-insensitivity-expected.txt: Added.
  • fast/dom/Element/getAttribute-case-insensitivity.html: Added.

Layout test added for verifying that getAttribute() and getAttributeNode()
APIs convert the passed attribute name to lowercase before comparing
against the existing attributes.

10:35 PM Changeset in webkit [144725] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Chromium] Add runtime flag for font load events
​https://bugs.webkit.org/show_bug.cgi?id=111296

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-04
Reviewed by Kent Tamura.

Add a runtime feature flag for FontLoader interface (disabled by default),
and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFontLoadEvents):
(WebKit):
(WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):

10:31 PM Changeset in webkit [144724] by jsbell@chromium.org
  • 5 edits in trunk/LayoutTests

[V8] Add LayoutTests for SerializedScriptValue Int32/Uint32 cases
​https://bugs.webkit.org/show_bug.cgi?id=111364

Reviewed by Kentaro Hara.

A lack of layout tests for SerializedScriptValue special cases let
crbug.com/179280 slip in and out un-noticed. Rectify the situation.

  • platform/chromium/fast/storage/serialized-script-value-expected.txt:
  • platform/chromium/fast/storage/serialized-script-value.html:
  • storage/indexeddb/structured-clone-expected.txt:
  • storage/indexeddb/structured-clone.html:
10:14 PM Changeset in webkit [144723] by commit-queue@webkit.org
  • 15 edits
    3 copies
    3 adds in trunk

WEBGL_compressed_texture_atc implementation
​https://bugs.webkit.org/show_bug.cgi?id=110496

Patch by Brandon Jones <​bajones@google.com> on 2013-03-04
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-atc.html

Exposes the WEBGL_compressed_texture_atc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

  • CMakeLists.txt:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureATC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::~WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::getName):
(WebCore::WebGLCompressedTextureATC::create):
(WebCore::WebGLCompressedTextureATC::supported):

  • html/canvas/WebGLCompressedTextureATC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTextureATC):

  • html/canvas/WebGLCompressedTextureATC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

  • html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

  • platform/graphics/Extensions3D.h:

LayoutTests:

  • webgl/conformance/extensions/webgl-compressed-texture-atc-expected.txt: Added.
  • webgl/conformance/extensions/webgl-compressed-texture-atc.html: Added.
  • webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-atc.html: Added.
10:12 PM Changeset in webkit [144722] by eustas@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Exceptions when WebInspector run in hosted mode.
​https://bugs.webkit.org/show_bug.cgi?id=111326

Reviewed by Pavel Feldman.

Source/WebCore:

There is bug in commands code generation in InspectorBackend.js
As a consequence all protocol enums have wrong names and cause
exception when refererenced.

Currently protocol enums are referenced only from NetworkManager.

Test: inspector/inspector-backend-commands-generation.html

  • inspector/front-end/InspectorBackend.js:

(InspectorBackendClass.prototype.loadFromJSONIfNeeded):
Use static method to generate code.
(InspectorBackendClass._generateCommands):
Extracted from loadFromJSONIfNeeded. Typo fixed.

LayoutTests:

Test runtime commands code generator output.

  • inspector/inspector-backend-commands-generation-expected.txt: Added.
  • inspector/inspector-backend-commands-generation.html: Added.
10:09 PM Changeset in webkit [144721] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.1

New Tag.

10:04 PM Changeset in webkit [144720] by crogers@google.com
  • 12 edits in trunk/Source

Source/Platform: Add audio hardware support for multi-channel by implementing AudioDestinationNode.maxChannelCount
​https://bugs.webkit.org/show_bug.cgi?id=111385

Reviewed by James Robinson.

  • chromium/public/Platform.h:

(WebKit::Platform::audioHardwareOutputChannels):

Source/WebCore: Add audio hardware support for multi-channel output by implementing AudioDestinationNode.maxChannelCount
​https://bugs.webkit.org/show_bug.cgi?id=111385

Reviewed by James Robinson.

See specification details for .maxChannelCount:
​https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioDestinationNode

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::maxChannelCount):

  • Modules/webaudio/AudioDestinationNode.idl:
  • Modules/webaudio/AudioNode.h:

Implement .maxChannelCount attribute.

(AudioNode):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::initialize):
(WebCore::DefaultAudioDestinationNode::createDestination):
(WebCore::DefaultAudioDestinationNode::enableInput):
Call to createDestination() now takes no argument.
Instead we maintain a member variable for the input device ID.
(WebCore::DefaultAudioDestinationNode::maxChannelCount):
(WebCore::DefaultAudioDestinationNode::setChannelCount):
Check port-specific hardware support for maxChannelCount(),
and allow setting the channel count based on what the hardware
supports.

  • platform/audio/AudioDestination.h:

(AudioDestination):

  • platform/audio/chromium/AudioDestinationChromium.cpp:

(WebCore::AudioDestination::maxChannelCount):
(WebCore::AudioDestinationChromium::render):
Call into chromium WebKit API: audioHardwareOutputChannels().

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestination::maxChannelCount):
Add basic implementation for maxChannelCount() only supporting stereo output.
Later, the mac port can support more than this with some small improvements to AudioDestinationMac.

9:55 PM Changeset in webkit [144719] by eric@webkit.org
  • 2 edits in trunk/Tools

run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
​https://bugs.webkit.org/show_bug.cgi?id=111384

Reviewed by Ryosuke Niwa.

Sometimes I want to know why various LayoutTests are slow
without having to convert them into PerformanceTests in order
to use our fancy profiling. The Driver already knows how to
do the right thing, we just need to expose the options to the user.

Handling of these options is already unittested in the perftests_unittest.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

9:31 PM Changeset in webkit [144718] by eustas@chromium.org
  • 2 edits in branches/chromium/1410/Source/WebCore

Merge 144437

Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
​https://bugs.webkit.org/show_bug.cgi?id=111077

Reviewed by Pavel Feldman.

Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.

  • inspector/front-end/DataGrid.js:

(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.

TBR=​eustas@chromium.org
Review URL: ​https://codereview.chromium.org/12414004

9:27 PM Changeset in webkit [144717] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

BUILD FIX (r144662): Import JSBase.h in WebFrameLoadDelegate.h
<​http://webkit.org/b/111269>

Fixes the following build failure:

In file included from Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:11:
In file included from Source/WebKit/mac/WebView/WebFrameLoadDelegatePrivate.h:29:
Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:41:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED


Source/WebKit/mac/WebView/WebFrameLoadDelegate.h:207:5: error: 'JSC_OBJC_API_ENABLED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if JSC_OBJC_API_ENABLED


2 errors generated.

  • WebView/WebFrameLoadDelegate.h: Include JSBase.h.
9:24 PM Changeset in webkit [144716] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk/Tools

check-webkit-style says "Have to enable auto props in the subversion config file"
​https://bugs.webkit.org/show_bug.cgi?id=107724

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Added a standard svn config file for WebKit developers to use.
Updated the style and commit queue bot build scripts to load this file.

  • EWSTools/GoogleComputeEngine/build-commit-queue.sh:
  • EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
  • EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
  • svn-config: Added.
9:23 PM Changeset in webkit [144715] by kinuko@chromium.org
  • 19 edits in trunk/LayoutTests

Rebaseline 4 virtual/softwarecompositing tests.

Unreviewed rebaseline of test expectations.

  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/vertical-scroll-composited-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
8:57 PM Changeset in webkit [144714] by abarth@webkit.org
  • 6 edits
    2 adds in trunk

Background HTML parser can rewind the tokenizer after end-of-file
​https://bugs.webkit.org/show_bug.cgi?id=111365

Reviewed by Eric Seidel.

Source/WebCore:

Prior to this patch, it was possible to call didFailSpeculation after
processing the end-of-file token because checkForSpeculationFailure
didn't zero out m_tokenizer in some control paths.

This patch renames checkForSpeculationFailure to validateSpeculations
and ensures that it always takes ownership of the main thread's
HTMLTokenizer.

This patch also adds a number of ASSERTs to make sure the parser state
machine stays in the correct configuration (e.g., that we don't have a
main thread tokenizer while we're supposed to be tokenizing on the
background thread).

Test: fast/parser/document-write-fighting-eof.html

  • html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::append):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

LayoutTests:

  • fast/parser/document-write-fighting-eof.html: Added.
8:37 PM Changeset in webkit [144713] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Make sure that clearOwnerNode also clears StyleResolver references (via didMutate).
​https://bugs.webkit.org/show_bug.cgi?id=109446

Patch by Tim 'mithro' Ansell <​mithro@mithis.com> on 2013-03-04
Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/css/stylesheet.innerHTML-calls-didmutate.html

  • css/CSSStyleSheet.h:

LayoutTests:

  • fast/css/stylesheet.innerHTML-calls-didmutate-expected.txt: Added.
  • fast/css/stylesheet.innerHTML-calls-didmutate.html: Added.
7:49 PM Changeset in webkit [144712] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r185990. Requested by
jamesr_ via sheriffbot.

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-04

  • DEPS:
7:40 PM Changeset in webkit [144711] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewd build fix after r144701.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):

7:23 PM Changeset in webkit [144710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix some style issues in RenderLayerCompositor
​https://bugs.webkit.org/show_bug.cgi?id=111369

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

Just style fix, no test needed

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::frameViewDidScroll):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

7:17 PM Changeset in webkit [144709] by tdanderson@chromium.org
  • 3 edits in trunk/Source/WebCore

Revert changes to RenderLayer::scrollByRecursively() that were added for gesture-scrolling
​https://bugs.webkit.org/show_bug.cgi?id=111007

Reviewed by Simon Fraser.

Due to ​http://trac.webkit.org/changeset/144519 landing, the changes made to RenderLayer in
​http://trac.webkit.org/changeset/142057,
​http://trac.webkit.org/changeset/140177, and
​http://trac.webkit.org/changeset/142195
are no longer necessary (as RenderLayer::scrollByRecursively() is not used for
gesture-scrolling) and should be reverted.

No change in behavior, so no new tests needed.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollByRecursively):

  • rendering/RenderLayer.h:
7:05 PM Changeset in webkit [144708] by akling@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

Unused Structure property tables waste 14MB on Membuster.
<​http://webkit.org/b/110854>
<rdar://problem/13292104>

Reviewed by Geoffrey Garen.

Turn PropertyTable into a GC object and have Structure drop unpinned tables when marking.
14 MB progression on Membuster3.

Added PropertyTable.cpp.

  • runtime/PropertyTable.cpp: Added.

(JSC::PropertyTable::create):
(JSC::PropertyTable::clone):
(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::destroy):
(JSC::PropertyTable::~PropertyTable):
(JSC::PropertyTable::visitChildren):

Moved marking of property table values here from Structure::visitChildren().

  • runtime/WriteBarrier.h:

(JSC::WriteBarrierBase::get):

Move m_cell to a local before using it multiple times. This avoids a multiple-access race when
Structure::checkOffsetConsistency() is used in assertions on the main thread while a marking thread
zaps the property table.

  • runtime/Structure.h:

(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::materializePropertyMapIfNecessaryForPinning):

  • runtime/StructureInlines.h:

(JSC::Structure::propertyTable):

Added a getter for the Structure's PropertyTable that ASSERTs GC currently isn't active.
Because GC can zap an unpinned property table at any time, it's not entirely safe to access it.
Renamed the variable itself to m_propertyTableUnsafe to force call sites into explaining themselves.

(JSC::Structure::putWillGrowOutOfLineStorage):
(JSC::Structure::checkOffsetConsistency):

Moved these out of Structure.h to break header dependency cycle between Structure/PropertyTable.

  • runtime/Structure.cpp:

(JSC::Structure::visitChildren):

Null out m_propertyTable if the table is unpinned. This'll cause the table to get GC'd.

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Add a global propertyTableStructure.

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::createStructure):
(JSC::PropertyTable::copy):

Make PropertyTable a GC object.

  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::despecifyDictionaryFunction):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::changePrototypeTransition):
(JSC::Structure::despecifyFunctionTransition):
(JSC::Structure::attributeChangeTransition):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::sealTransition):
(JSC::Structure::freezeTransition):
(JSC::Structure::preventExtensionsTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::isSealed):
(JSC::Structure::isFrozen):
(JSC::Structure::flattenDictionaryStructure):
(JSC::Structure::pin):
(JSC::Structure::copyPropertyTable):
(JSC::Structure::copyPropertyTableForPinning):
(JSC::Structure::get):
(JSC::Structure::despecifyFunction):
(JSC::Structure::despecifyAllFunctions):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
(JSC::Structure::getPropertyNamesFromStructure):
(JSC::Structure::checkConsistency):

6:48 PM Changeset in webkit [144707] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r144701.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):

6:46 PM Changeset in webkit [144706] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r143643): Buttons containing floats render differently
​https://bugs.webkit.org/show_bug.cgi?id=110933

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-04
Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/button-with-float.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::expandsToEncloseOverhangingFloats):
Also include new flexbox as a renderer that needs to enclose
overhanging floats. Flex boxes establish a block formatting context,
so they need to contain floats:
​http://dev.w3.org/csswg/css3-flexbox/#flex-items

LayoutTests:

  • css3/flexbox/float-inside-flexitem-expected.html: Added.
  • css3/flexbox/float-inside-flexitem.html: Added.
  • fast/forms/button-with-float-expected.html: Added.
  • fast/forms/button-with-float.html: Added.
6:34 PM Changeset in webkit [144705] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[chromium] Switch to new webkit_support::CreateLayerTreeView interface
​https://bugs.webkit.org/show_bug.cgi?id=111285

Patch by James Robinson <​jamesr@chromium.org> on 2013-03-04
Reviewed by Adrienne Walker.

This removes the need for WebCompositorSupport::initialize and exposes
slightly fewer entry points across the repository boundary.

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::webCompositorThread):
(TestShell):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):

5:58 PM Changeset in webkit [144704] by eric@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

Add PerformanceTest for document startup via iframe append/remove
​https://bugs.webkit.org/show_bug.cgi?id=111389

Reviewed by Kentaro Hara.

We'd like pages with lots of iframes to be fast.
This test shows that at least for V8/Chromium we spend
all our time booting v8.

On my 32-core linux machine I see about 70 runs/sec in
Release and 5 runs/sec in Debug.

  • DOM/iframe-append-remove.html: Added.
5:54 PM Changeset in webkit [144703] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Support WebSpeech - Speech Synthesis
​https://bugs.webkit.org/show_bug.cgi?id=106742

Build fix.

  • Modules/speech/SpeechSynthesis.cpp:
5:45 PM Changeset in webkit [144702] by rafaelw@chromium.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r144595.
​http://trac.webkit.org/changeset/144595
​https://bugs.webkit.org/show_bug.cgi?id=90341

Causing multiple crashes in fast/dom/Element/* tests (hits
assert in Attr.cp:215)

Source/WebCore:

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):

LayoutTests:

  • fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Removed.
  • fast/dom/Element/setAttributeNode-case-insensitivity.html: Removed.
5:42 PM Changeset in webkit [144701] by haraken@chromium.org
  • 9 edits in trunk/Source

[chromium] Implement TRACE_EVENT macros for sampling profiling
​https://bugs.webkit.org/show_bug.cgi?id=110932

Reviewed by Adam Barth.

We are implementing TRACE_EVENT macros for sampling profiling.
It works in the following mechanism:

  • Chromium defines global state variables for sampling profiling.

(i.e. g_trace_state0, g_trace_state1, g_trace_state2 in trace_event.h)

  • WebKit gets the addresses of the global state variables at the

initialization step. (i.e. EventTracer::initialize())

  • WebKit updates the global states by using TRACE_EVENT_SAMPLING_STATE()

macros every time WebKit changes its state. (e.g. DOM attribute
getters/setters/methods)

  • A sampling thread running in Chrome reads the global states

periodically and visualizes the profiling results into about://tracing.

This patch implements (1) a WebKit API to get the addresses of
the global states and (2) the TRACE_EVENT_SAMPLING_STATE() macro.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):
(WebKit::Platform::getTraceSamplingState):

Source/WebCore:

No tests. The sampling profiler is not enabled in Chrome by default.
I manually inserted TRACE_EVENT_SAMPLING_STATE() macros and
confirmed that the sampling profiling is working as expected.

  • platform/EventTracer.cpp:

(WebCore::EventTracer::initialize):
(WebCore::EventTracer::getTraceCategoryEnabledFlag):
(WebCore):

  • platform/EventTracer.h:

(WebCore):
(EventTracer):

  • platform/chromium/EventTracerChromium.cpp:

(WebCore):
(WebCore::EventTracer::initialize):

  • platform/chromium/TraceEvent.h:

Source/WebKit/chromium:

  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

5:39 PM FeatureFlags edited by jer.noble@apple.com
(diff)
5:17 PM Changeset in webkit [144700] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.
5:16 PM Changeset in webkit [144699] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Get rid of some AppleWin VS2010 build warnings.

  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
5:13 PM Changeset in webkit [144698] by Chris Fleizach
  • 11 edits in trunk

Support WebSpeech - Speech Synthesis
​https://bugs.webkit.org/show_bug.cgi?id=106742

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Enable speech synthesis for the Mac.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

Unskip speech synthesis tests.

  • fast/dom/script-tests/constructed-objects-prototypes.js:

(constructorPropertiesOnWindow):

  • platform/mac/TestExpectations:
4:55 PM Changeset in webkit [144697] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS

Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]

NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];

~

1 error generated.

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import

AccessibilityCommonMac.h.

4:42 PM Changeset in webkit [144696] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
​https://bugs.webkit.org/show_bug.cgi?id=109061

Patch by Ruslan Abdikeev <​aruslan@chromium.org> on 2013-03-04
Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/icon-url-list-apple-touch.html

Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Added.
  • fast/dom/icon-url-list-apple-touch.html: Added.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
4:31 PM Changeset in webkit [144695] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

UI process storage areas should hold on to storage maps
​https://bugs.webkit.org/show_bug.cgi?id=111374

Reviewed by Beth Dakin.

Pass the session storage quota size through to the storage area constructor and
create a StorageMap with the given quota size.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::create):
(WebKit::StorageManager::StorageArea::StorageArea):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::create):
(WebKit::StorageManager::SessionStorageNamespace::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::createSessionStorageNamespaceInternal):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

4:22 PM Changeset in webkit [144694] by jpfau@apple.com
  • 3 edits
    3 adds in trunk

Cache partitioning does not affect iframe MainResources
​https://bugs.webkit.org/show_bug.cgi?id=111022

Reviewed by David Kilzer.

Source/WebCore:

Set the partition of a main resource request if in a subframe.

Test: http/tests/cache/partitioned-cache-iframe.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

LayoutTests:

These tests results are for the case in which the cache is not
partitioned, as no shipping ports have cache partitioning enabled

  • http/tests/cache/partitioned-cache-iframe-expected.txt: Added.
  • http/tests/cache/partitioned-cache-iframe.html: Added.
  • http/tests/cache/resources/random-cached-iframe.cgi: Added.
3:51 PM Changeset in webkit [144693] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r144675.

Work around picky/old C++ compilers by separating the '>>' in
nested templates with a space.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):

3:51 PM Changeset in webkit [144692] by rafaelw@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening.

  • platform/chromium/TestExpectations: Marking all html5lib/generated/ as crashing.
3:47 PM Changeset in webkit [144691] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

More work on UI side storage
​https://bugs.webkit.org/show_bug.cgi?id=111370

Reviewed by Andreas Kling.

Add a DispatchStorageEvent message and begin hooking it up.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::findStorageArea):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/Storage/StorageManager.messages.in:
  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::setItem):
(WebKit::StorageAreaProxy::dispatchStorageEvent):
(WebKit):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageAreaProxy.messages.in:
3:45 PM Changeset in webkit [144690] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

AX: user agent shadow roots for plugins should be 'accessible'
​https://bugs.webkit.org/show_bug.cgi?id=111339

Reviewed by Tim Horton.

If a plugin element uses a user agent shadow element, we should make that shadow element
into a button with the title and subtitle put together, and use that as the label. This
will probably be the best accessibility experience.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

3:45 PM Changeset in webkit [144689] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

CSS3 calc: identify divide by zero cases at parse time
​https://bugs.webkit.org/show_bug.cgi?id=80411

Patch by Alan Cutter <​alancutter@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Added tests to check whether divide by 0 cases are caught.

  • css3/calc/catch-divide-by-0-expected.txt: Added.
  • css3/calc/catch-divide-by-0.html: Added.
3:36 PM Changeset in webkit [144688] by alokp@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Form controls on composited layers are not painted properly
​https://bugs.webkit.org/show_bug.cgi?id=111366

Reviewed by James Robinson.

Set PlatformContextSkia::m_drawingToImageBuffer which is used as a hint to properly blend GDI-painted bitmap.

  • platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

3:25 PM Changeset in webkit [144687] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Give ViewportConstraints classes copy constructors
​https://bugs.webkit.org/show_bug.cgi?id=111367

Reviewed by Beth Dakin.

Downstream code requires that ViewportConstraints objects have
copy constructors, so add them.

Also clean up some redundant initialization of stack objects
in RenderLayerCompositor.

No behavior change.

  • page/scrolling/ScrollingConstraints.h:

(WebCore::ViewportConstraints::ViewportConstraints):
(ViewportConstraints):
(WebCore::FixedPositionViewportConstraints::FixedPositionViewportConstraints):
(FixedPositionViewportConstraints):
(WebCore::StickyPositionViewportConstraints::StickyPositionViewportConstraints):
(StickyPositionViewportConstraints):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints):

3:23 PM Changeset in webkit [144686] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.13/Source/WebKit2

Merge r144659. <rdar://problem/13326713>

3:21 PM Changeset in webkit [144685] by beidson@apple.com
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r144114

2013-02-26 Anders Carlsson <​andersca@apple.com>

Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
​https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>

Reviewed by Beth Dakin.

Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.

  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
3:19 PM Changeset in webkit [144684] by beidson@apple.com
  • 2 edits in branches/safari-536.29-branch/Source/WebKit2

Merge 144114

2013-02-26 Anders Carlsson <​andersca@apple.com>

Fix a copy/paste error in WebLoaderClient::didBlockInsecurePluginVersion
​https://bugs.webkit.org/show_bug.cgi?id=110914
<rdar://problem/13297581>

Reviewed by Beth Dakin.

Pass kWKErrorCodeInsecurePlugInVersion to the pluginDidFail callback.

  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
3:12 PM Changeset in webkit [144683] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. AppleWin build fix.

  • html/parser/XSSAuditor.cpp:

(WebCore::isSemicolonSeparatedAttribute):

3:09 PM Changeset in webkit [144682] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSParser: Avoid temporary String when parsing hex colors.
<​http://webkit.org/b/111341>

Reviewed by Anders Carlsson.

Templatize CSSParser::fastParseColor() so we can pass a CSSParserString as the color name.
This avoids creating a temporary WTF::String from the parser string.

  • css/CSSParser.cpp:

(WebCore::CSSParser::fastParseColor):

  • css/CSSParser.h:
  • css/CSSParserValues.h:

(CSSParserString):

3:07 PM Changeset in webkit [144681] by jchaffraix@webkit.org
  • 13 edits
    1 copy
    1 add in trunk

[CSS Grid Layout] Add parsing for grid-{start|before}
​https://bugs.webkit.org/show_bug.cgi?id=110988

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/grid-item-start-before-get-set.html

Refactored how we store internally grid-{row|column} to be based on grid-{before|start}.
This is required as grid-{row|column} are shorthands for resp. grid-{before|after} and grid-{start|end}
in the specification and will also be in the code. That means a lot of methods were renamed to be more
aligned with the new design.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Added the code to parse, apply and get back the new properties. Also
some renaming after the internal naming change below.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleGridItemData.cpp:

(WebCore::StyleGridItemData::StyleGridItemData):

  • rendering/style/StyleGridItemData.h:

(WebCore::StyleGridItemData::operator==):
Updated the naming now that we manipulate grid-{before|start} instead of grid-{row|column}.

LayoutTests:

  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:

Extended the test to make sure that both grid-column (resp. grid-row) and grid-start (resp. grid-before) are
in sync.

  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-item-start-before-get-set.html: Added

Add this test for grid-{start|before}, similar to LayoutTests/fast/css-grid-layout/grid-item-column-row-get-set.html.

2:44 PM Changeset in webkit [144680] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed build fix: wrap references to PluginInfoStore with
guards for platforms which do not enable NETSCAPE_PLUGIN_AP.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):

  • UIProcess/WebContext.h:
2:41 PM Changeset in webkit [144679] by Chris Fleizach
  • 8 edits
    2 adds in trunk

WebSpeech: change voiceURI to voice
​https://bugs.webkit.org/show_bug.cgi?id=110773

Reviewed by Tim Horton.

Source/WebCore:

Change the voiceURI property to a voice property that takes a SpeechSynthesisVoice.
This was recently added to the errata of the WebSpeech spec.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html

  • Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::SpeechSynthesisUtterance::voice):
(WebCore::SpeechSynthesisUtterance::setVoice):

  • Modules/speech/SpeechSynthesisUtterance.h:

(SpeechSynthesisUtterance):

  • Modules/speech/SpeechSynthesisUtterance.idl:
  • Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::platformVoice):
(SpeechSynthesisVoice):

  • platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):

  • platform/PlatformSpeechSynthesisUtterance.h:

(WebCore::PlatformSpeechSynthesisUtterance::voice):
(WebCore::PlatformSpeechSynthesisUtterance::setVoice):
(PlatformSpeechSynthesisUtterance):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):

LayoutTests:

  • platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice-expected.txt: Added.
  • platform/mac/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html: Added.
2:29 PM Changeset in webkit [144678] by beidson@apple.com
  • 2 edits in branches/safari-536.29-branch/Source/WebKit2

Merge 144659

2013-03-04 Anders Carlsson <​andersca@apple.com>

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
2:28 PM Changeset in webkit [144677] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Filename passed to FormData.append() takes precedence over filename in
File.
​https://bugs.webkit.org/show_bug.cgi?id=111255

Patch by Victor Costan <​costan@gmail.com> on 2013-03-04
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/local/formdata/send-form-data-with-filename.html

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems): changed to implement the
behavior in the XMLHttpRequest W3C spec.

LayoutTests:

(runTest):

  • http/tests/local/formdata/send-form-data-with-filename-expected.txt: Added.
  • http/tests/local/formdata/send-form-data-with-filename.html: Added.
  • http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Updated

to reflect the behavior specified in the XMLHttpRequest W3C spec.

  • platform/wk2/TestExpectations: newly added test doesn't work in

WebKit2 because beginDragWithFiles is not implemented

2:26 PM Changeset in webkit [144676] by beidson@apple.com
  • 2 edits in branches/safari-534.59-branch/Source/WebKit2

Merge r144659

2013-03-04 Anders Carlsson <​andersca@apple.com>

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked):
2:25 PM Changeset in webkit [144675] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Create and destroy storage areas in the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111361

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
Keep track of listener connection and storage area ID pairs.

(WebKit::StorageManager::StorageArea::~StorageArea):
Assert that we don't have any listeners left.

(WebKit::StorageManager::StorageArea::addListener):
Add the pair to the set of listeners.

(WebKit::StorageManager::StorageArea::removeListener):
Remove the pair from the set of listeners.

(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
Given an origin, look up or create the storage area.

(WebKit::StorageManager::createStorageArea):
Create the storage area if it doesn't already exist.

(WebKit::StorageManager::destroyStorageArea):
Look up the storage area and destroy it.

  • UIProcess/Storage/StorageManager.h:

Add a map of open storage areas.

2:16 PM Changeset in webkit [144674] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Canvas and DOM go out of sync
​https://bugs.webkit.org/show_bug.cgi?id=107701

Patch by Alexis Hetu <​sugoi@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/canvas/canvas-overflow-hidden-animation.html

Added an update of the current compositor from the layer's stacking
container when the layer itself isn't a stacking container.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
Added an update of the stacking container of the owning layer of the
layer backing when the owning layer isn't a stacking container itself.

LayoutTests:

Added a new layout test for moving an object (a div) within a div that
has the "overflow:hidden" property.

  • fast/canvas/canvas-overflow-hidden-animation-expected.html: Added.
  • fast/canvas/canvas-overflow-hidden-animation.html: Added.
2:15 PM Changeset in webkit [144673] by jamesr@google.com
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium DEPS 185662 -> 185963

Roll roll roll the deps

Gently from downstream.

Merrily merrily merrily merrily

Green bots are but a dream.

  • DEPS:
2:08 PM Changeset in webkit [144672] by jer.noble@apple.com
  • 10 edits in trunk/Source/WebKit2

Add API to allow WK2 clients to query the list of installed plug-ins.
​https://bugs.webkit.org/show_bug.cgi?id=111245

Reviewed by Alexey Proskuryakov.

Add API in WKContext, implemented by WebContext, that allows callers to register a callback
retrieve an array containing installed plugin information. This API is exposed through WebContext
because it owns the PluginInfoStore used to fulfill the request.

Bump the WKContextClient API by 1:

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKContext.h:

Add a client protocol to PluginInfoStore to notify the client when plugIn information has been
successfully loaded:

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::PluginInfoStore): Initialize m_client to 0.
(WebKit::PluginInfoStore::loadPluginsIfNecessary): If the client is present, notify after loading the plugin store.

  • UIProcess/Plugins/PluginInfoStore.h:

(WebKit::PluginInfoStoreClient::~PluginInfoStoreClient): Default destructor.
(WebKit::PluginInfoStoreClient::PluginInfoStoreClient): Default constructor.
(WebKit::PluginInfoStore::setClient): Simple setter.
(WebKit::PluginInfoStore::client): Simple getter.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext): Set self as the client of PluginInfoStore.
(WebKit::WebContext::~WebContext): Clear the client of PluginInfoStore.
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins): Pass the callback to own client.

  • UIProcess/WebContext.h:
  • UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::plugInInformationBecameAvailable): Pass the callback to the registered WK callback, if present.

  • UIProcess/WebContextClient.h:
2:05 PM Changeset in webkit [144671] by ap@apple.com
  • 9 edits in trunk/Source/WebCore

Small BlobResourceHandle cleanup
​https://bugs.webkit.org/show_bug.cgi?id=111352

Reviewed by Sam Weinig.

  1. Don't use PassRefPtr<BlobStorageData> when ownership is not being passed.
  2. Added OVERRIDE to some functions.
  3. Added const to ResourceHandle::firstRequest().
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::loadResourceSynchronously):
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::getBlobDataFromURL):

  • platform/network/BlobRegistryImpl.h:

(BlobRegistryImpl):

  • platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::createAsync):
(WebCore::BlobResourceHandle::loadResourceSynchronously):

  • platform/network/BlobResourceHandle.h:

(BlobResourceHandle):

  • platform/network/FormData.cpp:

(WebCore::appendBlobResolved):

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::firstRequest):

  • platform/network/ResourceHandle.h:

(ResourceHandle):

1:54 PM Changeset in webkit [144670] by timothy_horton@apple.com
  • 17 edits in trunk/Source/WebKit2

PDFPlugin: Hook up Services
​https://bugs.webkit.org/show_bug.cgi?id=111246
<rdar://problem/13062672>

Reviewed by Alexey Proskuryakov.

Make the Application->Services menu work when the focused selection is a PDFPlugin.

  • Shared/EditorState.cpp:

(WebKit::EditorState::encode):
(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(WebKit::EditorState::EditorState):
(EditorState):
Add isInPlugin property to EditorState.

  • UIProcess/API/mac/WKView.mm:

(-[WKView validRequestorForSendType:returnType:]):
If the selection is currently in a Plugin, we only currently have the ability
to retrieve the selection as a plain-text string, so restrict sendType to NSStringPboardType.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:
  • WebProcess/Plugins/Plugin.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Add getStringSelection.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:

Add pdfLayerController:didChangeSelection: delegate method.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

(PDFPlugin):
Add getStringSelection and notifySelectionChanged.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate pdfLayerController:didChangeSelection:]):
Forward selection change notifications to our PDFPlugin.

(WebKit::PDFPlugin::notifySelectionChanged):
Forward selection change notifications to our WebPage.

(WebKit::PDFPlugin::getStringSelection):
Retrieve PDFLayerController's selection as a plain text string.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::countFindMatches):
(WebKit::PluginView::findString):
Drive-bys, check for existance and initialization of the plugin before using it.

(WebKit::PluginView::getStringSelection): Added.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection):
Use didChangeSelection instead of sending the EditorStateChanged message directly.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState):
If a plugin is focused and has a selection, return a EditorState that reflects that.
Since PDFs aren't editable (when editing annotations, the plugin doesn't have focus),
I'm not adding support for the editing-related properties when a plugin has focus.

(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::pluginViewForFrame):
Make these class methods instead of static functions so we can use them from
WebPageMac too, instead of duplicating code there.

(WebKit::WebPage::didChangeSelection): Added.

  • WebProcess/WebPage/WebPage.h:

Add didChangeSelection and [focused]PluginViewForFrame.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getStringSelectionForPasteboard):
Defer to the focused plugin (if it exists) when retrieving the plain-text selection.

1:54 PM Changeset in webkit [144669] by vsevik@chromium.org
  • 5 edits in trunk/Source/WebCore

Web Inspector: Introduce WebInspector.EventTarget interface for interfaces that dispatch events.
​https://bugs.webkit.org/show_bug.cgi?id=111320

Reviewed by Pavel Feldman.

  • inspector/front-end/Object.js:

(WebInspector.EventTarget):
(WebInspector.EventTarget.prototype.addEventListener):
(WebInspector.EventTarget.prototype.removeEventListener):
(WebInspector.EventTarget.prototype.removeAllListeners):
(WebInspector.EventTarget.prototype.hasEventListeners):
(WebInspector.EventTarget.prototype.dispatchEventToListeners):

  • inspector/front-end/ResourceScriptMapping.js:
  • inspector/front-end/UISourceCode.js:
  • inspector/front-end/Workspace.js:

(WebInspector.ProjectDelegate.prototype.searchInFileContent):

1:47 PM Changeset in webkit [144668] by mhahnenberg@apple.com
  • 8 edits in trunk/Source

Remove contextInternalContext from JSContextInternal.h
​https://bugs.webkit.org/show_bug.cgi?id=111356

Reviewed by Geoffrey Garen.

We don't need it any more since we have globalContextRef in JSContext.

Source/JavaScriptCore:

  • API/JSContext.mm:
  • API/JSContextInternal.h:
  • API/JSValue.mm:

(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):
(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):
(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):
(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):
(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):
(valueToObject):
(objectToValueWithoutCopy):
(objectToValue):
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
(-[JSValue description]):

  • API/JSWrapperMap.mm:

(createObjectWithCustomBrand):
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSWrapperMap jsWrapperForObject:]):

  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::call):
(objCCallbackFunctionForInvocation):

Source/WebKit/mac:

  • WebView/WebScriptWorld.mm:

(+[WebScriptWorld scriptWorldForJavaScriptContext:]):

1:44 PM Changeset in webkit [144667] by tsepez@chromium.org
  • 3 edits
    2 adds in trunk

XSSAuditor bypass with --> comment syntax.
​https://bugs.webkit.org/show_bug.cgi?id=111349

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/open-iframe-src-03.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
Adds ">" to the list of terminating characters, so that comments of
the form --> end the snippet we seek to match.

LayoutTests:

  • http/tests/security/xssAuditor/open-iframe-src-03-expected.txt: Added.
  • http/tests/security/xssAuditor/open-iframe-src-03.html: Added.
1:42 PM Changeset in webkit [144666] by vsevik@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Modal dialogs sometimes lose focus.
​https://bugs.webkit.org/show_bug.cgi?id=111317

Reviewed by Pavel Feldman.

setCurrentFocusElement doesn't give focus to an element anymore
if modal glass pane is shown and element is not inside it.

  • inspector/front-end/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.prototype._hide):

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype.defaultFocusedElement):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.defaultFocusedElement):

  • inspector/front-end/UIUtils.js:

(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
(WebInspector.setCurrentFocusElement):

  • inspector/front-end/dialog.css:
1:39 PM Changeset in webkit [144665] by junov@google.com
  • 1 edit
    3 copies in branches/chromium/1410

Merge 144196

REGRESSION (r134631) of border-radius percentage with border pixel
​https://bugs.webkit.org/show_bug.cgi?id=110889

Reviewed by Simon Fraser.

Source/WebCore:

Fixing background color filling to handle "non renderable" rounded
rectangles.

Test: fast/borders/border-radius-percent.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding new pixel test to verify the correct rendering of
rounded rectangle backgrounds with inner border radii that
exceed the dimensions of the inner edge of the border.

  • fast/borders/border-radius-percent-expected.txt: Added.
  • fast/borders/border-radius-percent.html: Added.
  • platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added.
  • platform/chromium/TestExpectations:

TBR=​junov@google.com
Review URL: ​https://codereview.chromium.org/12390064

1:38 PM Changeset in webkit [144664] by mikhail.pozdnyakov@intel.com
  • 12 edits
    2 adds in trunk

[WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
​https://bugs.webkit.org/show_bug.cgi?id=109828

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Providing WKViewClient with Web Process crash and Web Process relaunch
callbacks brings better design as WebView should not be aware of
EFL-specific code handling the corresponding events.

The implementation of the mentioned Web Process callbacks was also added.

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewSetThemePath):

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::webProcessCrashed):
(WebKit):
(WebKit::ViewClientEfl::webProcessDidRelaunch):
(WebKit::ViewClientEfl::ViewClientEfl):

  • UIProcess/efl/ViewClientEfl.h:

(ViewClientEfl):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::setThemePath):

Accepts WTF::String instead of WKStringRef as it is
more appropriate for C++ API implementation class.

(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):

  • UIProcess/efl/WebView.h:

(WebView):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit::WebViewClient::webProcessCrashed):
(WebKit):
(WebKit::WebViewClient::webProcessDidRelaunch):

  • UIProcess/efl/WebViewClient.h:

Tools:

Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
callbacks.

  • TestWebKitAPI/CMakeLists.txt:

Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
considered.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::webProcessCrashed):
(TestWebKitAPI::webProcessDidRelaunch):
(TestWebKitAPI::setViewClient):
(TestWebKitAPI::TEST):

1:16 PM Changeset in webkit [144663] by roger_fong@apple.com
  • 5 edits in trunk/Source

Unreviewed. AppleWin build fix.

  • WebKit.vcxproj/FeatureDefines.props:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebCore.vcxproj/WebCore.vcxproj:
1:11 PM Changeset in webkit [144662] by Laszlo Gombos
  • 4 edits in trunk/Source

JSC_OBJC_API_ENABLED should be removed from FeatureDefines.h
​https://bugs.webkit.org/show_bug.cgi?id=111269

Reviewed by Mark Hahnenberg.

Source/WebKit/mac:

Include JavaScriptCore/JSBase.h for the definition of JSC_OBJC_API_ENABLED.

  • WebView/WebDelegateImplementationCaching.h:

Source/WTF:

JSC_OBJC_API_ENABLED flag was added to FeatureDefines.h (r143637)
so that it could be used in WebCore.exp.in to determine whether
or not we should be exporting certain symbols based on whether
the WebKit-related portion of the JSC ObjC API was enabled.

It turned out conditionally including certain symbols didn't
work when building fat binaries, so it's not even necessary any more.

  • wtf/FeatureDefines.h: Remove JSC_OBJC_API_ENABLED.
1:02 PM Changeset in webkit [144661] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[v8] add isolate parameter to heap statistics calls
​https://bugs.webkit.org/show_bug.cgi?id=111308

Patch by Dan Carney <​dcarney@google.com> on 2013-03-04
Reviewed by Jochen Eisinger.

No new tests.

  • bindings/v8/ScriptGCEvent.cpp:

(WebCore::ScriptGCEvent::getHeapSize):
(WebCore::ScriptGCEvent::getUsedHeapSize):

  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::checkMemoryUsage):

12:42 PM Changeset in webkit [144660] by jochen@chromium.org
  • 4 edits in trunk/Source

[chromium] remove deprecated hyphenation methods from Platform
​https://bugs.webkit.org/show_bug.cgi?id=111101

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/Platform.h:

(Platform):

Source/WebCore:

  • platform/text/chromium/Hyphenation.cpp:

(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):

12:33 PM Changeset in webkit [144659] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Complete the plug-in URL string before sending it to the UI process
​https://bugs.webkit.org/show_bug.cgi?id=111355
<rdar://problem/13326713>

Reviewed by Andreas Kling.

If the URL is not absolute, we won't be able to find it by path extension in the plug-in info store.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::unavailablePluginButtonClicked):

12:22 PM Changeset in webkit [144658] by beidson@apple.com
  • 5 edits in branches/safari-534.59-branch

<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts

Rubberstamped by Anders Carlsson.

Source/WebKit2:

  • UIProcess/API/C/WKPage.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

12:07 PM Changeset in webkit [144657] by Chris Fleizach
  • 4 edits
    3 adds in trunk/Tools

AX: Upstream iOS Accessibility DumpRenderTree changes
​https://bugs.webkit.org/show_bug.cgi?id=111220

Reviewed by David Kilzer.

Upstream the iOS changes for accessibility in DumpRenderTree.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(headerElementAtIndexCallback):
(linkedElementCallback):
(elementsForRangeCallback):
(increaseTextSelectionCallback):
(decreaseTextSelectionCallback):
(assistiveTechnologySimulatedFocusCallback):
(stringForSelectionCallback):
(getIPhoneLabelCallback):
(getIPhoneHintCallback):
(getIPhoneValueCallback):
(getIPhoneIdentifierCallback):
(getIPhoneTraitsCallback):
(getIPhoneIsElementCallback):
(getIPhoneElementTextPositionCallback):
(getIPhoneElementTextLengthCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ios: Added.
  • DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.

(AccessibilityController::AccessibilityController):
(AccessibilityController::~AccessibilityController):
(AccessibilityController::elementAtPoint):
(AccessibilityController::focusedElement):
(AccessibilityController::rootElement):
(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):
(AccessibilityController::setLogFocusEvents):
(AccessibilityController::setLogScrollingStartEvents):
(AccessibilityController::setLogValueChangeEvents):
(AccessibilityController::setLogAccessibilityEvents):
(AccessibilityController::addNotificationListener):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.

(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::~AccessibilityUIElement):
(concatenateAttributeAndValue):
(AccessibilityUIElement::iphoneLabel):
(AccessibilityUIElement::iphoneHint):
(AccessibilityUIElement::iphoneValue):
(AccessibilityUIElement::iphoneIdentifier):
(AccessibilityUIElement::iphoneTraits):
(AccessibilityUIElement::iphoneIsElement):
(AccessibilityUIElement::iphoneElementTextPosition):
(AccessibilityUIElement::iphoneElementTextLength):
(AccessibilityUIElement::url):
(AccessibilityUIElement::x):
(AccessibilityUIElement::y):
(AccessibilityUIElement::width):
(AccessibilityUIElement::height):
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):
(AccessibilityUIElement::getChildren):
(AccessibilityUIElement::getChildrenWithRange):
(AccessibilityUIElement::childrenCount):
(AccessibilityUIElement::elementAtPoint):
(AccessibilityUIElement::indexOfChild):
(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::headerElementAtIndex):
(AccessibilityUIElement::linkedElement):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::increaseTextSelection):
(AccessibilityUIElement::decreaseTextSelection):
(AccessibilityUIElement::stringForSelection):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
(AccessibilityUIElement::elementsForRange):
(AccessibilityUIElement::getLinkedUIElements):
(AccessibilityUIElement::getDocumentLinks):
(AccessibilityUIElement::attributesOfLinkedUIElements):
(AccessibilityUIElement::attributesOfDocumentLinks):
(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::isPressActionSupported):
(AccessibilityUIElement::isIncrementActionSupported):
(AccessibilityUIElement::isDecrementActionSupported):
(AccessibilityUIElement::boolAttributeValue):
(AccessibilityUIElement::isAttributeSettable):
(AccessibilityUIElement::isAttributeSupported):
(AccessibilityUIElement::parameterizedAttributeNames):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::intValue):
(AccessibilityUIElement::minValue):
(AccessibilityUIElement::maxValue):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::insertionPointLineNumber):
(AccessibilityUIElement::isEnabled):
(AccessibilityUIElement::isRequired):
(AccessibilityUIElement::isFocused):
(AccessibilityUIElement::isSelected):
(AccessibilityUIElement::isExpanded):
(AccessibilityUIElement::isChecked):
(AccessibilityUIElement::hierarchicalLevel):
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::lineForIndex):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowCount):
(AccessibilityUIElement::columnCount):
(AccessibilityUIElement::indexInTable):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::assistiveTechnologySimulatedFocus):
(AccessibilityUIElement::setSelectedTextRange):
(AccessibilityUIElement::increment):
(AccessibilityUIElement::decrement):
(AccessibilityUIElement::showMenu):
(AccessibilityUIElement::press):
(AccessibilityUIElement::accessibilityValue):
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
(_accessibilityNotificationCallback):
(AccessibilityUIElement::addNotificationListener):
(AccessibilityUIElement::removeNotificationListener):
(AccessibilityUIElement::isFocusable):
(AccessibilityUIElement::isSelectable):
(AccessibilityUIElement::isMultiSelectable):
(AccessibilityUIElement::isSelectedOptionActive):
(AccessibilityUIElement::isVisible):
(AccessibilityUIElement::isOffScreen):
(AccessibilityUIElement::isCollapsed):
(AccessibilityUIElement::isIgnored):
(AccessibilityUIElement::hasPopup):
(AccessibilityUIElement::takeFocus):
(AccessibilityUIElement::takeSelection):
(AccessibilityUIElement::addSelection):
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::numberAttributeValue):

12:06 PM Changeset in webkit [144656] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Use initialization from literal for MediaFeatureNames
​https://bugs.webkit.org/show_bug.cgi?id=111283

Reviewed by Andreas Kling.

  • css/MediaFeatureNames.cpp:

(WebCore::MediaFeatureNames::init):
Initialization from literal is faster and use less memory. The names are
defined statically in MediaFeatureNames.h.

Also use the NotNull placement new to avoid a branch on silly allocators.

11:45 AM Changeset in webkit [144655] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

(tests) flexbox/resources.css should use unprefixed properties, for firefox
​https://bugs.webkit.org/show_bug.cgi?id=111010

Patch by Christian Biesinger <​cbiesinger@chromium.org> on 2013-03-04
Reviewed by Tony Chang.

Search & replace to remove -moz- prefixes, as per
​https://developer.mozilla.org/en-US/docs/CSS/Using_CSS_flexible_boxes:
"Gecko implementation is unprefixed (and is no longer behind a
preference as of Firefox 20)"

  • css3/flexbox/resources/flexbox.css:

(.flexbox):
(.inline-flexbox):
(.flex-none):
(.flex-auto):
(.flex-one):
(.row):
(.row-reverse):
(.column):
(.column-reverse):
(.wrap):
(.wrap-reverse):
(.align-content-flex-start):
(.align-content-flex-end):
(.align-content-center):
(.align-content-space-between):
(.align-content-space-around):
(.align-content-stretch):
(.align-items-flex-start):
(.align-items-flex-end):
(.align-items-center):
(.align-items-baseline):
(.align-items-stretch):
(.align-self-auto):
(.align-self-flex-start):
(.align-self-flex-end):
(.align-self-center):
(.align-self-baseline):
(.align-self-stretch):
(.justify-content-flex-start):
(.justify-content-flex-end):
(.justify-content-center):
(.justify-content-space-between):
(.justify-content-space-around):

11:44 AM Changeset in webkit [144654] by skyostil@chromium.org
  • 2 edits in trunk/Source/Platform

[chromium] Add ability to wait on async upload completion
​https://bugs.webkit.org/show_bug.cgi?id=110987

Reviewed by James Robinson.

Add a graphics context entry point for waiting on asynchronous upload
completion. The wait is performed server-side so the call is
non-blocking.

See ​https://codereview.chromium.org/12210129/

  • chromium/public/WebGraphicsContext3D.h:

(WebKit::WebGraphicsContext3D::waitAsyncTexImage2DCHROMIUM):

11:42 AM Changeset in webkit [144653] by beidson@apple.com
  • 7 edits in branches/safari-536.29-branch

<rdar://problem/13337144> - Update 536.29 branch Loader and UI client layouts

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKPage.h:

Tools:

  • MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

11:32 AM Changeset in webkit [144652] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit2

[GTK] Some WebKit2 GTK+ unit tests are failing in 32 bits bot
​https://bugs.webkit.org/show_bug.cgi?id=111346

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-03-04
Reviewed by Martin Robinson.

The problem is the use of a temporary CString object in the macro
g_assert_cmpstr. It's a common mistake because we usually forget
that g_assert_cmpstr is not a function but a macro, that expands
to multiple lines. This patch adds a new macro ASSERT_CMP_CSTRING
with the same implementation that g_assert_cmpstr, but using
CStrings instead of const char*. It fixes all the cases where a
temporary CString was used in g_assert_cmpstr, and uses the new
macro also for the cases where we were caching the CString just
for g_assert_cmpstr.

  • UIProcess/API/gtk/tests/TestDownloads.cpp:

(testDownloadRemoteFile):

  • UIProcess/API/gtk/tests/TestInspectorServer.cpp:

(testInspectorServerPageList):

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:
  • UIProcess/API/gtk/tests/TestMain.h:
  • UIProcess/API/gtk/tests/TestResources.cpp:
  • UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:

(testGetFaviconURI):

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(assertThatUserAgentIsSentInHeaders):
(testWebKitSettingsUserAgent):

11:30 AM Changeset in webkit [144651] by jsbell@chromium.org
  • 29 edits in trunk/Source/WebCore

[V8] Unreviewed. Rebaselined run-bindings-tests following r144617

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::TestActiveDOMObjectV8Internal::TestActiveDOMObjectDomainSafeFunctionSetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructorConstructor):
(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::installPerContextPrototypeProperties):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):

  • bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

11:20 AM Changeset in webkit [144650] by Lucas Forschler
  • 2 edits in tags/Safari-537.31.13/Source/WebCore

Merged r144577. <rdar://problem/13328176>

11:04 AM Changeset in webkit [144649] by tony@chromium.org
  • 4 edits
    1 delete in trunk/Source

Unreviewed, rolling out r144562.
​http://trac.webkit.org/changeset/144562
​https://bugs.webkit.org/show_bug.cgi?id=85642

Caused KeyPadInsert faluires in webkit_unittests

Source/WebCore:

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

  • WebKit.gypi:
  • tests/KeyCodeConversionTestGtk.cpp: Removed.
11:01 AM Changeset in webkit [144648] by Lucas Forschler
  • 4 edits in tags/Safari-537.31.13/Source

Versioning.

10:59 AM Changeset in webkit [144647] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

getComputedStyle not implemented for -webkit-columns shorthand
​https://bugs.webkit.org/show_bug.cgi?id=111236

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-03-04
Reviewed by Alexis Menard.

Source/WebCore:

Implement getComputedStyle for -webkit-columns shorthand.

Test: fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to check getComputedStyle for -webkit-columns.

  • fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-webkit-columns-shorthand.html: Added.
10:56 AM Changeset in webkit [144646] by leviw@chromium.org
  • 5 edits in trunk/Source

Add support for 8 bit TextRuns on Chromium Linux & Mac
​https://bugs.webkit.org/show_bug.cgi?id=99393

Reviewed by Eric Seidel.

Source/WebCore:

Adding support for 8 bit TextRuns for Mac and Linux Chromium. To accomplish this,
8 bit text runs are upconverted to 16 bit in the complex text path during string
normalization, as HarfBuzz operates on UChars.

Windows has platfom assumptions that TextRuns are 16 bit that need to be addressed
before enabling this optimization.

No new tests. No change in behavior.

(WebCore::HarfBuzzShaperBase::setNormalizedBuffer):

  • platform/graphics/harfbuzz/HarfBuzzShaperBase.h:
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::normalizeCharacters):
(WebCore::HarfBuzzShaper::HarfBuzzShaper):

Source/WebKit/chromium:

Enabling 8 bit text runs for Linux and Mac platforms.

  • features.gypi:
10:50 AM Changeset in webkit [144645] by Lucas Forschler
  • 1 copy in tags/Safari-537.31.13

New Tag.

10:49 AM Changeset in webkit [144644] by alexis@webkit.org
  • 5 edits in trunk

transition-property property and transition shorthand property doesn't accept "all, all".
​https://bugs.webkit.org/show_bug.cgi?id=111201

Reviewed by Simon Fraser.

Source/WebCore:

Relax the parsing of transition-property to allow all, all as a value.
It is not very useful per say but it is possible by the spec and we
align with Firefox, IE and Opera.

Test: LayoutTests/transitions/transitions-parsing.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationProperty):

LayoutTests:

Updated the tests to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
10:34 AM Changeset in webkit [144643] by peter@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Add a new dependency on jsr-305 for Android
​https://bugs.webkit.org/show_bug.cgi?id=111340

Unreviewed build fix; new Android dependency. This is
currently breaking gyp generation on the Android bots.

  • DEPS:
10:23 AM Changeset in webkit [144642] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
​https://bugs.webkit.org/show_bug.cgi?id=111229

Patch by Min Qin <​qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap):

9:46 AM Changeset in webkit [144641] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add simple vector traits for JSC::Identifier.
<​http://webkit.org/b/111323>

Reviewed by Geoffrey Garen.

Identifiers are really just Strings, giving them simple vector traits makes
Vector move them with memcpy() instead of churning the refcounts.

  • runtime/Identifier.h:

(WTF):

9:41 AM Changeset in webkit [144640] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Upstream selection start animation.
​https://bugs.webkit.org/show_bug.cgi?id=111335

Patch by Iris Wu <​shuwu@rim.com> on 2013-03-04
Reviewed by Rob Buis.

PR 219960

To indicate selection starts, we draw an overlay rect larger than
the selected word at the start of selection. Then shrink it down
to the actual size.

Reviewed Internally by Genevieve Mak and Andrew Lo and Mike Fenton.

  • Api/WebAnimation.cpp:

(BlackBerry::WebKit::WebAnimation::shrinkAnimation):
(WebKit):

  • Api/WebAnimation.h:
  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::selectionHighlight):
(WebKit):

  • Api/WebPage.h:
  • Api/WebPage_p.h:

(WebPagePrivate):

  • Api/WebTapHighlight.h:
  • WebKitSupport/DefaultTapHighlight.cpp:

(WebKit):
(BlackBerry::WebKit::shrinkAnimationName):
(BlackBerry::WebKit::DefaultTapHighlight::draw):

  • WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::textGranularityFromSelectionExpansionType):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::selectNodeIfFatFingersResultIsLink):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):

9:29 AM Changeset in webkit [144639] by vollick@chromium.org
  • 8 edits in trunk

ASSERTION FAILED: m_clipRectsCache->m_respectingOverflowClip[clipRectsType] == (clipRectsContext.respectOverflowClip == RespectOverflowClip) in RenderLayer.
​https://bugs.webkit.org/show_bug.cgi?id=108257

Reviewed by David Hyatt.

Source/WebCore:

With composited scrolling we paint both with and without respecting
overflow clip. To prevent collisions in the clip cache, and to prevent
throwing away cached clips unnecessarily, we keep two copies of the
clip cache -- one for when overflow clip is respected, and one for
when it isn't.

No new tests. Covered by existing tests (in debug):

compositing/overflow/automatically-opt-into-composited-scrolling.html
compositing/overflow/composited-scrolling-creates-a-stacking-container.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):

No longer asserts that our 'respect overflow clip' status is
consistent. It also gets and sets the clip cache using the clip rect
context rather than just the clip rect type.

(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):
(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(WebCore::ClipRectsCache::getIndex):

Get and set the cached clip rects using the context rather than
type.

(WebCore::RenderLayer::clipRects):

We now cache twice as many clip rects.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

ShouldRespectOverflowClip was moved out of RenderLayer.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::clearClipRects):

  • rendering/RenderLayer.h:

(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::ClipRectsCache::getClipRects):
(WebCore::ClipRectsCache::setClipRects):
(ClipRectsCache):
(WebCore::ClipRectsCache::getIndex):
(WebCore::RenderLayer::clipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

LayoutTests:

  • platform/efl-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
9:24 AM Changeset in webkit [144638] by acolwell@chromium.org
  • 7 edits in trunk/Source

Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
​https://bugs.webkit.org/show_bug.cgi?id=111195

Reviewed by Adam Barth.

Source/WebCore:

No new tests. No user visible behavior changed.

  • platform/graphics/SourceBufferPrivate.h:

(SourceBufferPrivate):

Source/WebKit/chromium:

  • public/WebSourceBuffer.h:

(WebSourceBuffer):

  • src/SourceBufferPrivateImpl.cpp:

(WebKit::SourceBufferPrivateImpl::abort):

  • src/SourceBufferPrivateImpl.h:

(SourceBufferPrivateImpl):

  • src/WebMediaPlayerClientImpl.cpp:

(WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::abort):

9:16 AM Changeset in webkit [144637] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

[New Multicolumn] Eliminate the unique multicolumn flow thread style creation function
​https://bugs.webkit.org/show_bug.cgi?id=111338

Reviewed by Allan Jensen.

There is nothing special about a multi-column flow thread style now, so we can just
use the existing anonymous style creation function.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore):
(WebCore::RenderMultiColumnBlock::addChild):

9:06 AM Changeset in webkit [144636] by mario@webkit.org
  • 9 edits in trunk/Source/WebCore

[GTK] WebCore::returnString is unsafe and should be removed!
​https://bugs.webkit.org/show_bug.cgi?id=110423

Reviewed by Martin Robinson.

Remove returnString() and replace it in callers with a new
function that will cache and return the values of string
properties for ATK interfaces in the private section of the
wrapper AtkObject WebKitAccessible.

  • accessibility/atk/WebKitAccessibleUtil.cpp: Remove returnString().
  • accessibility/atk/WebKitAccessibleUtil.h: Ditto.
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(_WebKitAccessiblePrivate): New private structure to store cached
values of string property for the different ATK interfaces.
(cacheAndReturnAtkProperty): New helper function to make sure the
returned const gchar* value is previously cached in the private
section of the wrapper AtkObject.
(webkitAccessibleGetName): Use the new helper function.
(webkitAccessibleGetDescription): Ditto.
(webkitAccessibleInit): Initialize pointer to private structure.
(webkitAccessibleFinalize): Remove unneeded code.
(webkitAccessibleClassInit): Add private struct to class type/

  • accessibility/atk/WebKitAccessibleWrapperAtk.h:

(_WebKitAccessible): New member pointing to the private structure,
made the new helper function cacheAndReturnAtkProperty() available
to external callers (implementation files for ATK interfaces).
(AtkCachedProperty): New enum to allow reusing code when calling
cacheAndReturnAtkProperty() to cache and return different properties.

  • accessibility/atk/WebKitAccessibleInterfaceAction.cpp:

(webkitAccessibleActionGetKeybinding): Replace calls to returnString()
with calls to the new helper function cacheAndReturnAtkProperty().
(webkitAccessibleActionGetName): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(documentAttributeValue): Ditto.
(webkitAccessibleDocumentGetLocale): Ditto.

  • accessibility/atk/WebKitAccessibleInterfaceImage.cpp:

(webkitAccessibleImageGetImageDescription): Ditto.

Remove returnString() from WebKitAccessibleHyperlink (which is not
an AtkObject, but a GObject) as well, replacing it in callers with
simple code that will cache and return the required values in the
private section of these kind of objects.

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(_WebKitAccessibleHyperlinkPrivate): Added two new fields to cache
string values for the key binding and name properties from the
AtkAction interface, which is implemented by AtkHyperlink.
(webkitAccessibleHyperlinkActionGetKeybinding): Cache the string
value for the key binding before returning a const gchar* pointer.
(webkitAccessibleHyperlinkActionGetName): Ditto.
(webkitAccessibleHyperlinkGetURI): Do not cache the URI here, as
this function returns a gchar* that will be owned by the caller.

9:04 AM Changeset in webkit [144635] by jochen@chromium.org
  • 7 edits in trunk/Tools

[chromium] pass all focus handling methods through the WebTestDelegate
​https://bugs.webkit.org/show_bug.cgi?id=111328

Reviewed by Nico Weber.

In content_shell, the focus handling is asynchronous. To allow for
switching the focus synchronously between WebViews, we need to intercept
didFocus and didBlur and forward it to the WebTestDelegate.

  • DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:

(WebTestDelegate):
(WebTestRunner::WebTestDelegate::setFocus):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didFocus):
(WebTestRunner::WebTestProxy::didBlur):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::setWindowIsKey):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::didFocus):
(WebTestRunner):
(WebTestRunner::WebTestProxyBase::didBlur):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didFocus):
(WebViewHost::didBlur):
(WebViewHost::setFocus):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

8:50 AM Changeset in webkit [144634] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Curl] Compile fix after r144216
​https://bugs.webkit.org/show_bug.cgi?id=111305

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-03-04
Reviewed by Brent Fulgham.

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::cfURLRequest): Added new parameter.

8:43 AM Changeset in webkit [144633] by hyatt@apple.com
  • 5 edits
    2 adds in trunk

[New Multicolumn] Make sure region styling works for columns inside regions.
​https://bugs.webkit.org/show_bug.cgi?id=111276

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/regions/region-styling-in-columns.html

  • rendering/RenderFlowThread.cpp:

(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
(WebCore::CurrentRenderFlowThreadMaintainer::~CurrentRenderFlowThreadMaintainer):

  • rendering/RenderFlowThread.h:

(CurrentRenderFlowThreadMaintainer):
Fix the CurrentRenderFlowThreadMaintainer so that it saves off the old render flow thread
and restores it when done. This effectively makes flow thread layout a push/pop stack,
since with in-flow threads, this is allowed. We assert that a nested flow thread is
in-flow to preserve the invariant that you can't nest CSS Regions flow thread.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::computeChildrenStyleInRegion):
Add isInFlowRenderFlowThread() to the anonymous check to make sure a style gets made
for the nested flow thread.

LayoutTests:

  • fast/regions/region-style-in-columns-expected.html: Added.
  • fast/regions/region-style-in-columns.html: Added.
8:36 AM Changeset in webkit [144632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: WebInspector.AceTextEditor throws a warning
​https://bugs.webkit.org/show_bug.cgi?id=111315

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Add WebInspector.AceTextEditor to externs.js to suppress closure
compilation warning.

No new tests: no change in behaviour.

  • inspector/front-end/externs.js:

(WebInspector.AceTextEditor):

8:22 AM Changeset in webkit [144631] by Antoine Quint
  • 4 edits in trunk/Source/WebCore

Fix debug build under certain configurations, cause was
​http://trac.webkit.org/changeset/144624.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):

  • inspector/InspectorLayerTreeAgent.h:

(WebCore):
(WebCore::InspectorLayerTreeAgent::create):
(InspectorLayerTreeAgent):

8:22 AM Changeset in webkit [144630] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Deque: Free internal buffer in clear().
<​http://webkit.org/b/111316>
<rdar://problem/13336675>

Reviewed by Antti Koivisto.

525 kB progression on Membuster3.

  • wtf/Deque.h:

(WTF::::clear):

8:21 AM Changeset in webkit [144629] by kadam@inf.u-szeged.hu
  • 37 edits
    4 copies
    76 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Updated platform specific expected files and png results.

  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/layer-due-to-layer-children-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Added.
  • platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
  • platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.txt: Added.
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png:
  • platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png: Added.
  • platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/reflection-repaint-test-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/region-painting-via-layout-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/position-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/position-after-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
  • platform/qt-5.0-wk2/svg/custom/visibility-override-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/big-sized-filter-2-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/filterRes1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
  • platform/qt-5.0-wk2/svg/filters/filterRes1-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/filterRes3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png.
  • platform/qt-5.0-wk2/svg/filters/filterRes3-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png.
  • platform/qt-5.0-wk2/svg/filters/parent-children-with-same-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/shadow-on-filter-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
  • platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt: Added.
8:04 AM Changeset in webkit [144628] by Claudio Saavedra
  • 2 edits in trunk/Tools

[GTK] No need to manually add system paths to jhbuildrc
​https://bugs.webkit.org/show_bug.cgi?id=110850

Reviewed by Gustavo Noronha Silva.

  • gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild

already takes care of.

7:53 AM Changeset in webkit [144627] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r141240) Crash in PluginPackage::fetchInfo
​https://bugs.webkit.org/show_bug.cgi?id=111322

Reviewed by Simon Hausmann.

Do not try to load blacklisted plugins.

  • plugins/qt/PluginPackageQt.cpp:

(WebCore::PluginPackage::fetchInfo):

7:09 AM Changeset in webkit [144626] by alexis@webkit.org
  • 15 edits in trunk

transition properties can't be found in CSSStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=110011

Reviewed by Antti Koivisto.

Source/WebCore:

The previous approach for handling the unprefixing was to alias the
unprefixed properties with the prefixed ones in CSSPropertyNames.in.
Unfortunately it will alias the properties in the parsing code which will just
identically parse the two versions. This means that when we populate StylePropertySet
we do not have information whether we just parsed the prefixed, the
unprefixed properties or we parsed both. The patch takes another
approach by creating two distinct sets of properties (unprefixed and
prefixed). Each properties have their own id and we now handle them in
the parsing code as disctints properties and add both versions to the
declared style. In order to avoid properties getting out of sync,
this patch adds few facilities to StylePropertySet to update the
prefixed and the unprefixed entries. Finally the style resolution
happens only for the prefixed version (to limit the size of this patch)
and the unprefixed versions are not resolved. This is to avoid creating
the animation objects twice for the resolved style.

Test : transitions/transitions-parsing.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::addPropertyWithPrefixingVariant): Always add the
prefixed and the unprefixed property even if only one is specified.
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTransitionShorthand): Add both prefixed and
unprefixed longhands to the declarated style.
(WebCore::CSSParser::parseAnimationProperty):

  • css/CSSParser.h:

(CSSParser):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSProperty.h:

(WebCore:: prefixingVariantForPropertyId): This function takes a given
property id and returns its prefixed or unprefixed id if it exists. If
not it returns the same id.
(WebCore):

  • css/CSSPropertyNames.in:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::removeShorthandProperty):
(WebCore::StylePropertySet::removeProperty):
(WebCore::StylePropertySet::removeProperty): Remove
also the prefixed or unprefixed shorthand if it exists.
(WebCore):
(WebCore::StylePropertySet::setProperty):
(WebCore::StylePropertySet:: appendPrefixingVariantProperty):
(WebCore::StylePropertySet::setPrefixingVariantProperty): If it
exists a unprefixed or prefixed counterpart of the property we're
trying to set, then we update the other one.
(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::mergeAndOverrideOnConflict):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StylePropertyShorthand.cpp:

(WebCore::transitionShorthand):
(WebCore):
(WebCore::shorthandForProperty): Define the transitions unprefixed
longhands.

  • css/StylePropertyShorthand.h:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): StyleBuilder will handle the
resolution and the creation of the animations for the style. As the
declarated style now contains declarations for the prefixed and
unprefixed property we do not want to resolve two times and create duplicate animations.
Therefore when we try to resolve the unprefixed version we just bail out.

LayoutTests:

Updated layout test to cover the bug.

  • transitions/transitions-parsing-expected.txt:
  • transitions/transitions-parsing.html:
7:07 AM Changeset in webkit [144625] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: CPU Flame Chart: reveal profiler DataGrid node when user clicks on a FlameChart item.
​https://bugs.webkit.org/show_bug.cgi?id=111309

Reviewed by Yury Semikhatsky.

  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._revealProfilerNode):

  • inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onClick):

6:07 AM Changeset in webkit [144624] by Antoine Quint
  • 7 edits
    4 deletes in trunk

Web Inspector: remove existing LayerTreeAgent protocol APIs
​https://bugs.webkit.org/show_bug.cgi?id=111251

Source/WebCore:

In order to eventually provide a more useful API for the LayerTreeAgent
that will be done in followup bugs, we remove the current API exposed by
the agent providing a clean slate that will make future patches easier
to read. Additionally, we remove the "childLayers" property on the Layer
object since we will no longer be providing a hierarchy of layers, but
rather a flat list of layers attached to a node and its descendants.

No new tests since we're removing the APIs exposed by the LayerTreeAgent.
Subsequent patches will add tests as new APIs are added.

Reviewed by Timothy Hatcher.

  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

  • inspector/InspectorLayerTreeAgent.h:

(InspectorLayerTreeAgent):

LayoutTests:

Remove existing tests since they're testing API that we're
removing.

Reviewed by Timothy Hatcher.

  • inspector-protocol/layer-tree-expected.txt: Removed.
  • inspector-protocol/layer-tree-generated-content-expected.txt: Removed.
  • inspector-protocol/layer-tree-generated-content.html: Removed.
  • inspector-protocol/layer-tree.html: Removed.
5:54 AM Changeset in webkit [144623] by li.yin@intel.com
  • 5 edits in trunk

MediaStream.ended must return true when it is created with ended tracks.
​https://bugs.webkit.org/show_bug.cgi?id=111293

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: ​http://dev.w3.org/2011/webrtc/editor/getusermedia.html#MediaStream-ended
When a MediaStream object is created, its ended attribute must be set to false,
unless it is being created using the MediaStream() constructor whose arguments
are lists of MediaStreamTrack objects that are all ended, in which case the
MediaStream object must be created with its ended attribute set to true.

Test: fast/mediastream/MediaStreamConstructor.html

  • platform/mediastream/MediaStreamDescriptor.h:

(WebCore::MediaStreamDescriptor::MediaStreamDescriptor):

LayoutTests:

  • fast/mediastream/MediaStreamConstructor-expected.txt:
  • fast/mediastream/MediaStreamConstructor.html:
5:34 AM Changeset in webkit [144622] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

Web Inspector: Adding new rules broken if a <style> tag is added to document dynamically
​https://bugs.webkit.org/show_bug.cgi?id=111299

Reviewed by Pavel Feldman.

Source/WebCore:

The CSSStyleSheet instance should be retrieved directly from the HTMLStyleElement just created,
not from the document.styleSheets list.

Test: inspector/styles/add-new-rule-with-style-after-body.html

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

LayoutTests:

  • inspector/styles/add-new-rule-with-style-after-body-expected.txt: Added.
  • inspector/styles/add-new-rule-with-style-after-body.html: Added.
5:15 AM Changeset in webkit [144621] by loislo@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Unreviewed. Fix for closure type annotations.

  • inspector/front-end/FlameChart.js:
5:07 AM Changeset in webkit [144620] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Build fix when compiling with GLES2 support enabled.
​https://bugs.webkit.org/show_bug.cgi?id=111291

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-04
Reviewed by Kenneth Rohde Christiansen.

This patch fixes build issues when compiling with GLES2
support. As part of the fix the patch removes Evas specific
workaround of using GLX with EGL in PlatformContext as GLES2
is the main target with EGL.

  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLCurrentContextWrapper::GLCurrentContextWrapper):

  • platform/graphics/texmap/TextureMapper.h:
5:00 AM Changeset in webkit [144619] by kinuko@chromium.org
  • 2 edits in trunk/Tools

[chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
​https://bugs.webkit.org/show_bug.cgi?id=111284

Disabling the failing two tests on Android.

Reviewed by Jochen Eisinger.

  • TestWebKitAPI/Tests/WTF/StringHasher.cpp:

(TestWebKitAPI):
(TestWebKitAPI::TEST):

4:39 AM Changeset in webkit [144618] by loislo@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Web Inspector: implement Flame Chart for CPU profiler.
​https://bugs.webkit.org/show_bug.cgi?id=111162

Reviewed by Yury Semikhatsky.

It is an initial implementation. The next step is to provide
function names and other stats about the hovered item.

  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/compile-front-end.py:
  • inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):

  • inspector/front-end/FlameChart.js: Added.

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype.findNodeCallback):
(WebInspector.FlameChart.prototype._coordinatesToNode):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._rootNodes):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._drawNode):
(WebInspector.FlameChart.prototype._forEachNode):
(WebInspector.FlameChart.prototype._drawBar):
(WebInspector.FlameChart.prototype.update):

  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/flameChart.css: Added.

(.flame-chart):

4:26 AM Changeset in webkit [144617] by commit-queue@webkit.org
  • 25 edits in trunk/Source/WebCore

[V8] Add a "context type" parameter to GetTemplate and ConfigureV8SomethingTemplate functions
​https://bugs.webkit.org/show_bug.cgi?id=110875

The parameter will later be used for generating specialized V8
bindings for the 3 different world types (main world, isolated
work, worker).

Patch by Marja Hölttä <​marja@chromium.org> on 2013-03-04
Reviewed by Kentaro Hara.

No new tests (no changes in behavior yet).

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateNamedConstructor):
(GenerateImplementation):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):

  • bindings/v8/DOMDataStore.h:

(DOMDataStore):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore):
(WebCore::DOMWrapperWorld::setInitializingWindow):
(WebCore::DOMWrapperWorld::DOMWrapperWorld):
(WebCore::DOMWrapperWorld::contextHasCorrectPrototype):

  • bindings/v8/DOMWrapperWorld.h:

(DOMWrapperWorld):
(WebCore::DOMWrapperWorld::getWorld):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::retrieveFrameWithGlobalObjectCheck):

  • bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):
(WebCore::V8AdaptorFunction::wrap):

  • bindings/v8/V8AdaptorFunction.h:

(V8AdaptorFunction):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMWindow):
(WebCore::toScriptExecutionContext):
(WebCore::worldType):
(WebCore):
(WebCore::worldTypeInMainThread):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::createWrapper):

  • bindings/v8/V8Initializer.cpp:

(WebCore::findFrame):

  • bindings/v8/V8PerContextData.cpp:

(WebCore::V8PerContextData::constructorForTypeSlowCase):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::WorkerScriptController):
(WebCore::WorkerScriptController::controllerForContext):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore::WrapperTypeInfo::getTemplate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAttrGetterCustom):
(WebCore::V8DOMWindow::eventAttrSetterCustom):
(WebCore::V8DOMWindow::toStringMethodCustom):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
(WebCore::toV8):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8HTMLImageElementConstructor.h:

(V8HTMLImageElementConstructor):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventMethodCustom):

4:13 AM Changeset in webkit [144616] by kinuko@chromium.org
  • 2 edits in trunk/LayoutTests

2013-03-04 Kinuko Yasuda <​kinuko@chromium.org>

[Chromium] Unreviewed, removing failure test expectations for passing tests.

  • platform/chromium/TestExpectations:
3:45 AM Changeset in webkit [144615] by commit-queue@webkit.org
  • 6 edits
    9 adds in trunk/Source

Web Inspector: add Ace editor experiment
​https://bugs.webkit.org/show_bug.cgi?id=111191

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Source/WebCore:

No new tests.

Add Ace text editor experiment.

  • WebCore.gypi:
  • inspector/front-end/AceTextEditor.js: Added.
  • inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/ace/ace.js: Added.
  • inspector/front-end/ace/acedevtools.css: Added.
  • inspector/front-end/ace/mode_css.js: Added.
  • inspector/front-end/ace/mode_html.js: Added.
  • inspector/front-end/ace/mode_javascript.js: Added.
  • inspector/front-end/ace/theme_textmate.js: Added.
  • inspector/front-end/ace/LICENSE.txt: Added.

Source/WebKit/chromium:

Add target to concatenate js files for Ace Text Editor.

  • WebKit.gyp:
3:40 AM Changeset in webkit [144614] by commit-queue@webkit.org
  • 22 edits in trunk

Add build flag for FontLoader
​https://bugs.webkit.org/show_bug.cgi?id=111289

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-04
Reviewed by Benjamin Poulain.

Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

  • features.gypi:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:
3:25 AM Changeset in webkit [144613] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

XSSAuditor should strip dangerous attributes from SMIL animation elements.
​https://bugs.webkit.org/show_bug.cgi?id=111071

Reviewed by Adam Barth.

Source/WebCore:

SMIL animation elements can, amusingly enough, animate the 'href' of a
link. This patch teaches XSSAuditor how to deal with the
semicolon-separated 'animation[values]' attribute in order to ensure
that it doesn't contain JavaScript URLs that could be animated into
place for an unsuspecting user to click on.

Test: http/tests/security/xssAuditor/svg-animate.html

  • html/parser/XSSAuditor.cpp:

(WebCore::isSemicolonSeparatedAttribute): Added.

This returns true if the given attribute is SVGNames::valuesAttr,
but makes it possible to easily extend the list with additional
attributes with this strange property.

(WebCore::semicolonSeparatedValueContainsJavaScriptURL): Added.

Given a semicolon-separated string, determine if it contains any
JavaScript URLs.

(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):

When looking for dangerousness, determine whether or not we should
be comparing against each member of a semicolon-separated list.

LayoutTests:

  • http/tests/security/xssAuditor/resources/echo-intertag.pl:

Add a new mode that dumps an element and its attributes, which is a
bit more robust than adding a new mode for each attribute type we're
interested in.

  • http/tests/security/xssAuditor/svg-animate-expected.txt: Added.
  • http/tests/security/xssAuditor/svg-animate.html: Added.
3:09 AM Changeset in webkit [144612] by anilsson@rim.com
  • 1 edit
    16 adds in trunk/Source/WebCore

[BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration
​https://bugs.webkit.org/show_bug.cgi?id=111153

Reviewed by Rob Buis.

BlackBerry PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Rob Buis
Robin Cao
Eli Fidler
Mike Lattanzio
Yong Li
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos

Covered by existing tests.

  • platform/graphics/blackberry/FontBlackBerry.cpp: Added.

(FSFixedToFloat):
(FloatToFSFixed):
(WebCore):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawGlyphs):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawEmphasisMarksForComplexText):
(WebCore::Font::canExpandAroundIdeographsInComplexText):

  • platform/graphics/blackberry/FontCacheBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontCache::platformInit):
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):
(WebCore::FontCache::getTraitsInFamily):
(WebCore::getFamilyNameStringFromFontDescriptionAndFamily):
(WebCore::fontWeightToFontconfigWeight):
(WebCore::FontCache::createFontPlatformData):

  • platform/graphics/blackberry/FontCustomPlatformData.h: Added.

(WebCore):
(FontCustomPlatformData):

  • platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::FontCustomPlatformData::supportsFormat):
(WebCore::createFontCustomPlatformData):

  • platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::~FontPlatformData):
(WebCore::FontPlatformData::name):
(WebCore::FontPlatformData::applyState):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::FontPlatformData::description):
(WebCore::FontPlatformData::harfbuzzFace):
(WebCore::FontPlatformData::scaledFont):
(WebCore::FontPlatformData::setFakeBold):
(WebCore::FontPlatformData::setFakeItalic):
(WebCore::FontPlatformData::platformFontHandle):
(WebCore::FontPlatformData::isFixedPitch):

  • platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp: Added.

(WebCore):
(WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::~WorldTypeScopedPtr):
(WebCore::WorldTypeScopedPtr::get):
(WebCore::GlyphPage::fill):

  • platform/graphics/blackberry/GradientBlackBerry.cpp: Added.

(WebCore):
(WebCore::totalStopsNeeded):
(WebCore::fillStops):
(WebCore::Gradient::platformGradient):
(WebCore::Gradient::platformDestroy):
(WebCore::Gradient::fill):
(WebCore::Gradient::setPlatformGradientSpaceTransform):

  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp: Added.

(WebCore):
(GraphicsContextPlatformPrivate):
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::platformContext):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::setIsAcceleratedContext):
(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore::GraphicsContext::getCTM):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::scale):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::strokeArc):
(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::supportsTransparencyLayers):
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::GraphicsContext::setAlpha):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::addRoundedRectClip):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::clipBounds):
(WebCore::GraphicsContext::addInnerRoundedRectClip):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformTextDrawingMode):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setImageInterpolationQuality):
(WebCore::GraphicsContext::imageInterpolationQuality):

  • platform/graphics/blackberry/ITypeUtils.h: Added.

(floatToITypeFixed):
(intToITypeFixed):
(iTypeFixedToFloat):

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp: Added.

(WebCore):
(WebCore::makeBufferCurrent):
(WebCore::getImageDataInternal):
(WebCore::ImageBufferData::getImageData):
(WebCore::flushAndDraw):
(WebCore::ImageBufferData::draw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::platformLayer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/blackberry/ImageBufferDataBlackBerry.h: Added.

(WebCore):
(ImageBufferData):

  • platform/graphics/blackberry/PathBlackBerry.cpp: Added.

(WebCore):
(WebCore::scratchContext):
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::operator=):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):

  • platform/graphics/blackberry/PatternBlackBerry.cpp: Added.

(WebCore):
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
(WebCore::Pattern::setPlatformPatternSpaceTransform):

  • platform/graphics/blackberry/PlatformSupport.cpp: Added.

(WebCore):
(WebCore::PlatformSupport::getFontFamilyForCharacters):

  • platform/graphics/blackberry/PlatformSupport.h: Added.

(WebCore):
(PlatformSupport):
(FontFamily):

  • platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp: Added.

(WebCore):
(WebCore::FSFixedToFloat):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::createScaledFontData):
(WebCore::SimpleFontData::smallCapsFontData):
(WebCore::SimpleFontData::emphasisMarkFontData):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::platformBoundsForGlyph):
(WebCore::SimpleFontData::platformWidthForGlyph):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

2:12 AM Changeset in webkit [144611] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Marking a few layout tests as flaky.
2:07 AM Changeset in webkit [144610] by adam.bergkvist@ericsson.com
  • 3 edits
    2 adds
    2 deletes in trunk

MediaStream API: local addTrack() and removeTrack() operations should not fire events.
​https://bugs.webkit.org/show_bug.cgi?id=111079

Reviewed by Adam Barth.

Source/WebCore:

Removed the scheduling of "addtrack" and "removetrack" events by
addTrack and removeTrack(). Replaced the test since the old test was
driven by the event firing removed by this patch.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):

LayoutTests:

Replaced the test since the old test was driven by the event firing
removed by this patch.

  • fast/mediastream/MediaStream-add-remove-tracks-expected.txt: Added.
  • fast/mediastream/MediaStream-add-remove-tracks.html: Added.
  • fast/mediastream/MediaStreamTrackList-expected.txt: Removed.
  • fast/mediastream/MediaStreamTrackList.html: Removed.
1:39 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:37 AM Changeset in webkit [144609] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK][WK2] Add document-loaded signal to WebKitWebPage
​https://bugs.webkit.org/show_bug.cgi?id=110614

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-04
Reviewed by Carlos Garcia Campos.

Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded.

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.

1:36 AM Changeset in webkit [144608] by apavlov@chromium.org
  • 5 edits in trunk

Web Inspector: touchmove not emulated inside iframe
​https://bugs.webkit.org/show_bug.cgi?id=111292

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
should be dispatched on a subframe.

  • page/EventHandler.cpp:

(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

LayoutTests:

  • fast/events/touch/emulated-touch-iframe.html:
  • fast/events/touch/resources/emulated-touch-iframe2.html:
1:33 AM Changeset in webkit [144607] by mkwst@chromium.org
  • 15 edits in trunk/Source/WebCore

Long URLs in error messages should be shortened
​https://bugs.webkit.org/show_bug.cgi?id=111133

Reviewed by Jochen Eisinger.

When generating console messages, we're often copying the page's URL
in order to add detail about where the error occurred. Generally, this
is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
more memory than we should, and impacting performance.

This patch adds an 'elidedString()' method to KURL for use in this
sort of case; when generating console messages, we should insert the
elided URL rather than the full URL.

This shouldn't change any visible behavior; we're already visually
eliding URLs in console messages for URLs above 150 characters. This
patch simply changes the underlying string to ensure that no URL is
over 1k in length to begin with.

  • platform/KURL.cpp:

(WebCore::KURL::elidedString): Added.

  • platform/KURL.h:

An exciting new method that gives you the same result as string()
for URLs less than 1k long, and elides the middle of URLs longer
than 1k by replacing everything but the first and last 0.5k with
"...".

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):

Use 'KURL::elidedString()' rather than 'KURL::string()'

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

Here, we're doing the same as above, but it enables us to throw
away the asUTF8() function entirely by switching to makeString
rather than String::format.

1:22 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:19 AM Changeset in webkit [144606] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r144070 - [WK2][GTK] REGRESSION (r143463): unit test failure in WebKit2APITests/TestContextMenu
​https://bugs.webkit.org/show_bug.cgi?id=110869

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-26
Reviewed by Martin Robinson.

Test was failing because of new media controls needs more space to be
painted than just 10x10 pixels.

  • UIProcess/API/gtk/tests/TestContextMenu.cpp:

(testContextMenuDefaultMenu): Modified test in order to give more space
to the media controls.

1:18 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
Add some changes on track for WK2 (diff)
12:37 AM Changeset in webkit [144605] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source

Web Inspector: add runtime flag to determine if inspector's source files were flattened.
​https://bugs.webkit.org/show_bug.cgi?id=111184

Patch by Andrey Lushnikov <​lushnikov@chromium.org> on 2013-03-04
Reviewed by Pavel Feldman.

Source/WebCore:

  • Add a file "buildSystemOnly.js" which will be included into

devtools.html only by GYP build system. This script sets a single flag
which essentially means that inspector source files were run
through a build system and flattened.

  • Update "importScript" and "registerRequiredCSS" functions to correct

paths according to the "flattenImports" flag.

No new tests: no change in behaviour.

  • WebCore.gypi:
  • inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):

  • inspector/front-end/View.js:

(WebInspector.View.prototype.registerRequiredCSS):

  • inspector/front-end/buildSystemOnly.js: Added.
  • inspector/front-end/utilities.js:

Source/WebKit/chromium:

Included "buildSystemOnly.js" in devtools.html by generate_devtools_html.py script.

  • WebKit.gyp:
  • scripts/generate_devtools_html.py: Add script tag to include buildSystemOnly.js

(write_devtools_html):

12:36 AM Changeset in webkit [144604] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.
​https://bugs.webkit.org/show_bug.cgi?id=111290

  • platform/qt/TestExpectations: Skipped failing test after r144461.
12:06 AM Changeset in webkit [144603] by vsevik@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Fix front-end compilation
​https://bugs.webkit.org/show_bug.cgi?id=111286

Reviewed by Alexander Pavlov.

  • inspector/InjectedScriptSource.js:
  • inspector/front-end/FileSystemProjectDelegate.js:
  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):

Mar 3, 2013:

11:57 PM Changeset in webkit [144602] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[EFL][WebGL] Add proper checks to enable GraphicsSurface usage on EGL without XCompositeWindow.
​https://bugs.webkit.org/show_bug.cgi?id=108034

Patch by Kondapally Kalyan <​kalyan.kondapally@intel.com> on 2013-03-03
Reviewed by Laszlo Gombos.

Covered by existing WebGL tests.

Currently, we set GRAPHICS_SURFACE to true if support for XCompositeWindow
is identified during compile time. This is ok, when using GLX. We might not
have support for XCompositeWindow when using EGL and GLES2.0. This patch
makes changes so that GRAPHICS_SURFACE is always enabled with EGL and adds
GLX guard to the parts of code dependent on XCompositeWindow support.

  • platform/graphics/opengl/GLPlatformSurface.cpp:
  • platform/graphics/surfaces/glx/GLXConfigSelector.h:

(WebCore::GLXConfigSelector::findMatchingConfig):

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):

  • platform/graphics/surfaces/glx/X11Helper.h:
11:44 PM Changeset in webkit [144601] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [PageAgent] can't find frame by security origin.
​https://bugs.webkit.org/show_bug.cgi?id=110849

Use toRawString() in order to compare Frames' SecurityOrigins for storage-related goals.

Reviewed by Vsevolod Vlasov.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):

11:28 PM Changeset in webkit [144600] by apavlov@chromium.org
  • 16 edits in trunk

Unreviewed, rolling out r144455.
​http://trac.webkit.org/changeset/144455
​https://bugs.webkit.org/show_bug.cgi?id=111165

A simpler solution to the SecurityOrigin -> localStorage
lookup exists

Source/WebCore:

  • inspector/front-end/DOMStorage.js:

(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):

  • inspector/front-end/ExtensionAuditCategory.js:
  • inspector/front-end/FileSystemModel.js:

(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):

  • inspector/front-end/IndexedDBModel.js:

(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):

  • inspector/front-end/IndexedDBViews.js:

(WebInspector.IDBDatabaseView.prototype._refreshDatabase):

  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeFrame):
(WebInspector.ResourceTreeFrame.prototype._navigate):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):

LayoutTests:

  • http/tests/inspector-enabled/dom-storage-open.html:
  • http/tests/inspector/filesystem/delete-entry.html:
  • http/tests/inspector/filesystem/request-filesystem-root.html:
  • http/tests/inspector/indexeddb/database-data.html:
  • http/tests/inspector/indexeddb/database-names.html:
  • http/tests/inspector/indexeddb/database-structure.html:
  • http/tests/inspector/resource-tree/resource-tree-events.html:
11:09 PM Changeset in webkit [144599] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

PDFPlugin: Rename delegate method from openWithPreview to openWithNativeApplication
​https://bugs.webkit.org/show_bug.cgi?id=111258

Reviewed by Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate openWithNativeApplication]):
Rename from openWithPreview to openWithNativeApplication to match PDFKit.

10:53 PM Changeset in webkit [144598] by vsevik@chromium.org
  • 10 edits in trunk/Source/WebCore

Web Inspector: Let user know when file system based uiSourceCode was changed on disk.
​https://bugs.webkit.org/show_bug.cgi?id=110133

Reviewed by Pavel Feldman.

We now check if file system based uiSourceCode content was updated externally when
UISourceCodeFrame is shown or inspector window is focused.
If there is no working copy being edited right now we replace old content with the new one silently.
Otherwise ask user if he wants to replace his working copy with the new content.

  • English.lproj/localizedStrings.js:
  • WebCore.vcproj/WebCore.vcproj:
  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.editRange):

  • inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype._contentRequestFinished):
(WebInspector.FileSystemProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.contentCallback):
(WebInspector.FileSystemProjectDelegate.prototype.searchInFileContent):

  • inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.willHide):

  • inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.requestUpdatedFileContent):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.setContent):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.checkContentUpdated.updatedContentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):

  • inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.wasShown):
(WebInspector.UISourceCodeFrame.prototype.willHide):
(WebInspector.UISourceCodeFrame.prototype._windowFocused):
(WebInspector.UISourceCodeFrame.prototype._checkContentUpdated):

  • inspector/front-end/Workspace.js:

(WebInspector.ProjectDelegate.prototype.requestUpdatedFileContent):
(WebInspector.Project.prototype.requestUpdatedFileContent):

10:34 PM Changeset in webkit [144597] by toyoshim@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium gardening

Remove failure annotation on tests which was already fixed.

  • platform/chromium/TestExpectations:
10:28 PM Changeset in webkit [144596] by benjamin@webkit.org
  • 5 edits in trunk

[Mac] Get rid of a useless method from DOMHTMLInputElement
​https://bugs.webkit.org/show_bug.cgi?id=111279

Reviewed by Sam Weinig.

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • DOM/WebDOMOperationsPrivate.h:

setValueForUser: is already privately exposed by DOMHTMLInputElement,
no need to have it twice.

Tools:

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setValueForUser):
The method _setValueForUser: was added for testing. This feature is already
exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
in real use cases. Get rid of the method created for testing, use the real thing
instead.

9:51 PM Changeset in webkit [144595] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

createAttribute/setAttributeNode does not properly normalize case
​https://bugs.webkit.org/show_bug.cgi?id=90341

Patch by Arpita Bahuguna <​a.bah@samsung.com> on 2013-03-03
Reviewed by Darin Adler.

Source/WebCore:

setAttributeNode() verifies for existing attributes in a case sensitive
manner. Thus, it would add another attribute if specified in a case
different from the existing one. Instead, like setAttribute(), it too
should modify the existing attribute's value.

Test: fast/dom/Element/setAttributeNode-case-insensitivity.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeNode):
Made changes to check for an existing attribute by converting the
specified attribute's localName to lowercase.

LayoutTests:

  • fast/dom/Element/setAttributeNode-case-insensitivity-expected.txt: Added.
  • fast/dom/Element/setAttributeNode-case-insensitivity.html: Added.

Testcase for verifying that setAttributeNode() checks against existing
attributes in a case insensitive manner. It updates the value of an
existing attribute (in lower case) with that of the one set using
setAttributeNode() (in upper case).
The test also verifies the behavior of attributes when specified with
namespace and prefix.

5:42 PM Changeset in webkit [144594] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests.

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::indexedSecurityCheck):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::namedSecurityCheck):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

5:39 PM Changeset in webkit [144593] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r144590.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateSecurityCheckFunctions):

5:36 PM Changeset in webkit [144592] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r144587.

  • bindings/v8/V8Binding.cpp:

(WebCore::toV8Context):

  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):

4:16 PM Changeset in webkit [144591] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] HTMLDocument.all should have [Replaceable]
​https://bugs.webkit.org/show_bug.cgi?id=111230

Reviewed by Adam Barth.

(Although HTMLDocument.all is already removed from the spec,)
it is expected to behave as a [Replaceable] attribute. By adding
a [Replaceable] IDL attribute, we can remove custom implementation
of HTMLDocument.all.

I confimed that exactly the same code is generated for .all getter
and setter.

No tests. No change in behavior.

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
  • html/HTMLDocument.idl:
4:12 PM Changeset in webkit [144590] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] indexedSecurityCheck() and namedSecurityCheck() should be auto-generated
​https://bugs.webkit.org/show_bug.cgi?id=111225

Reviewed by Adam Barth.

indexedSecurityCheck() and namedSecurityCheck() should be auto-generated,
except for DOMWindow's ones.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateSecurityCheckFunctions):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::namedSecurityCheckCustom):
(WebCore::V8DOMWindow::indexedSecurityCheckCustom):

  • bindings/v8/custom/V8HistoryCustom.cpp:
  • bindings/v8/custom/V8LocationCustom.cpp:
4:11 PM Changeset in webkit [144589] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Shrink JSC::HashTable entries.
<​http://webkit.org/b/111275>
<rdar://problem/13333511>

Reviewed by Anders Carlsson.

Move the Intrinsic value out of the function-specific part of the union,
and store it next to m_attributes. Reduces the size of HashEntry by 8 bytes.

990 kB progression on Membuster3. (PTUS: 797 kB)

  • runtime/Lookup.h:

(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):
(HashEntry):

4:09 PM Changeset in webkit [144588] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Rename $implContentDecls to $implContentInternals in CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=111214

Reviewed by Adam Barth.

$implContentDecls stores generated code that is put in a namespace 'XXXV8Internal'.
For clarification, it should be renamed to $implContentInternals.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateConstructorGetter):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetterCallback):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateEventConstructor):
(GenerateTypedArrayConstructor):
(GenerateImplementation):
(WriteData):

4:05 PM Changeset in webkit [144587] by haraken@chromium.org
  • 12 edits in trunk/Source/WebCore

[V8] Rename getWorld() to isolatedWorld(), and getWorldForEnteredContext() to isolatedWorldForEnteredContext()
​https://bugs.webkit.org/show_bug.cgi?id=111212

Reviewed by Adam Barth.

The rename I did in r142424 was wrong. Given that getWorld() returns 0
for the main world, it should be named isolatedWorld(). Similarly,
given that getWorldForEnteredContext() returns 0 for the main world,
it should be named isolatedWorldForEnteredContext().

No tests. No change in behavior.

  • bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::isFeatureAllowed):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::current):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::DOMWrapperWorld::makeContextWeak):

  • bindings/v8/DOMWrapperWorld.h:

(WebCore::DOMWrapperWorld::isolatedWorld):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):
(WebCore::ScriptController::currentWorldContext):

  • bindings/v8/V8Binding.h:

(WebCore::isolatedWorldForEnteredContext):

  • bindings/v8/WorldContextHandle.cpp:

(WebCore::WorldContextHandle::WorldContextHandle):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8SVGDocumentCustom.cpp:

(WebCore::wrap):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCustom):

3:56 PM Changeset in webkit [144586] by beidson@apple.com
  • 14 edits in branches/safari-534.59-branch

Merge r143988

2013-02-25 Anders Carlsson <​andersca@apple.com>

Source/WebKit2:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationPluginspageAttributeURLKey): (WKPageGetPluginInformationPluginURLKey): Add two new API key getters.


  • UIProcess/API/C/WKPage.h: Add a new callback and deprecate the old callback.


  • UIProcess/WebLoaderClient.cpp: (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy): Make the pluginInformationDictionary a static member function of WebPageProxy so it can be called from WebUIClient as well.


  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): Pass the bundle version as well.

(WebKit::WebPageProxy::pluginInformationPluginspageAttributeURLKey):
(WebKit::WebPageProxy::pluginInformationPluginURLKey):
Add two new keys.

(WebKit::WebPageProxy::pluginInformationDictionary):
Handle more keys.

(WebKit::WebPageProxy::unavailablePluginButtonClicked):
Get the plug-in bundle identifier and version.

  • UIProcess/WebPageProxy.messages.in: Pass along more information; the frame and page URLs.
  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::unavailablePluginButtonClicked): Call the new callback if it's supported.
  • UIProcess/WebUIClient.h: (WebUIClient):
  • UIProcess/mac/WebInspectorProxyMac.mm: (WebKit::WebInspectorProxy::platformCreateInspectorPage): Update for API changes.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::unavailablePluginButtonClicked): Ensure that the pluginspage attribute is a valid URL.

Tools:

Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110821
<rdar://problem/13265303>

Reviewed by Beth Dakin.

Update for WebKit2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions): (WTR::TestController::unavailablePluginButtonClicked):
  • WebKitTestRunner/TestController.h: (TestController):
3:54 PM Changeset in webkit [144585] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[EFL][QT][WK2] Turn on ApplyDeviceScaleFactorInCompositor always.
​https://bugs.webkit.org/show_bug.cgi?id=110298

Patch by Huang Dongsung <​luxtella@company100.net> on 2013-03-03
Reviewed by Kenneth Rohde Christiansen.

Currently, EFL and Qt turn on ApplyDeviceScaleFactorInCompositor when using
fixed layout, but ApplyDeviceScaleFactorInCompositor is not related to fixed
layout. It is confusing that a platform WebView deals with device view size or
DIP view size case by case. So this patch always turns on
ApplyDeviceScaleFactorInCompositor.

In addition, move the code that turns on ScrollingCoordinatorEnabled to
CoordinatedLayerTreeHost.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::setDeviceScaleFactor):

We should make WebPage know new DIP size.

(EwkView::setSize):

When we set ApplyDeviceScaleFactorInCompositor to true, make WebPage
know the DIP size as a view size.

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::updateViewportSize):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::DrawingAreaImpl):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

WebPage sends the DIP size to Web Process even when we don't use fixed layout.

3:52 PM Changeset in webkit [144584] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Move HTMLDocument::getNamedProperty() to DOMWindowShell
​https://bugs.webkit.org/show_bug.cgi?id=111223

Reviewed by Adam Barth.

HTMLDocument::getNamedProperty() is used by DOMWindowShell.
It can be a static method in DOMWindowShell.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::getNamedProperty):
(WebCore):
(WebCore::getter):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:
3:19 PM Changeset in webkit [144583] by rniwa@webkit.org
  • 24 edits in trunk

Some perf. tests have variances that differ greatly between runs
​https://bugs.webkit.org/show_bug.cgi?id=97510

Reviewed by Benjamin Poulain.

PerformanceTests:

In order to control the number of iterations and processes to use from run-perf-tests, always use 20
iterations on all tests except Dromaeo, where even doing 5 iterations is prohibitively slow, by default.
Without this change, it'll become extremely hard for us to tweak the number of iterations and processes
to use from run-perf-tests.

  • Animation/balls.html:
  • DOM/DOMTable.html:
  • DOM/resources/dom-perf.js:

(runBenchmarkSuite.PerfTestRunner.measureTime):

  • Dromaeo/resources/dromaeorunner.js:
  • Layout/floats_100_100.html:
  • Layout/floats_100_100_nested.html:
  • Layout/floats_20_100.html:
  • Layout/floats_20_100_nested.html:
  • Layout/floats_2_100.html:
  • Layout/floats_2_100_nested.html:
  • Layout/floats_50_100.html:
  • Layout/floats_50_100_nested.html:
  • Layout/subtree-detaching.html:
  • Parser/html5-full-render.html:
  • SVG/SvgHitTesting.html:
  • resources/runner.js:
  • resources/results-template.html:

Tools:

Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
environment on test results (we run each instance after one another, not in parallel).

We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
iterations as it was done previously in single process. These values are hard-coded in perftest.py
and runner.js but they are to be configurable in the future.

Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
metric now reports an array of the length 4 with each element containing an array of 5 iteration
values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.

Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.append_group): Renamed from append.
(PerfTestMetric.grouped_iteration_values): Added.
(PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.

(PerfTest.init): Takes the number of processes (drivers) to run tests with.
This parameter is only used by SingleProcessPerfTest.

(PerfTest.run): Repeat tests using different driver processes.
(PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
We instead use _ensure_metrics to obtain the matched metrics and store the data there.
(PerfTest._ensure_metrics): Added.

(SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
instances of DumpRenderTree/WebKitTestRunner takes too long.
(SingleProcessPerfTest.init):

(ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.

(PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect

_run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.

(TestPerfTestMetric.test_append): Updated per name and added some test cases for
grouped_iteration_values.

(TestPerfTest._assert_results_are_correct):

(TestSingleProcessPerfTest): Added.
(TestSingleProcessPerfTest.test_use_only_one_process):
(TestSingleProcessPerfTest.test_use_only_one_process.run_single):

(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of

sample standard deviations since we're now running tests 4 times.
(MainTest._test_run_with_json_output.mock_upload_json):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

LayoutTests:

Use dromaeoIterationCount now that we no longer support iterationCount.

  • fast/harness/perftests/runs-per-second-iterations.html:
3:02 PM Changeset in webkit [144582] by beidson@apple.com
  • 13 edits in branches/safari-534.59-branch

Merge r143976

2013-02-25 Anders Carlsson <​andersca@apple.com>

Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
​https://bugs.webkit.org/show_bug.cgi?id=110793
<rdar://problem/13265303>

Reviewed by Sam Weinig.

Source/WebKit2:

Add a new pluginDidFail callback that takes a WKDictionaryRef and also pass in the
frame and page URLs.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit::pluginInformationDictionary): (WebKit::WebLoaderClient::didFailToInitializePlugin): (WebKit::WebLoaderClient::didBlockInsecurePluginVersion): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailToInitializePlugin): (WebKit::WebPageProxy::didBlockInsecurePluginVersion):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::didFailToInitializePlugin):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin):

Tools:

Update for WebKit2 API changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m: (-[WK2BrowserWindowController awakeFromNib]):
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createWebViewWithOptions):
2:15 PM Changeset in webkit [144581] by aelias@chromium.org
  • 6 edits in trunk

[chromium] Remove WebLayerTreeView::setViewportSize call
​https://bugs.webkit.org/show_bug.cgi?id=110727

Reviewed by James Robinson.

After ​https://codereview.chromium.org/12328080 lands,
setViewportSize is called from the Chromium side. The multiplication
by deviceScaleFactor here was prone to off-by-one errors.
The layoutSize() function was only used here so delete it as well.

DumpRenderTree WebViewHost must now call this method as well.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::updateLayerTreeViewport):

  • src/WebViewImpl.h:

(WebViewImpl):

Tools:

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::initializeLayerTreeView):
(WebViewHost::setWindowRect):
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::updateViewportSize):

  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

2:15 PM Changeset in webkit [144580] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Shared Web Workers have an incorrect visible process name
​https://bugs.webkit.org/show_bug.cgi?id=111277

Reviewed by Dan Bernstein.

  • SharedWorkerProcess/SharedWorkerProcess.cpp:

(WebKit::SharedWorkerProcess::initializeSharedWorkerProcess):

  • SharedWorkerProcess/SharedWorkerProcess.h:

(SharedWorkerProcess):

  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:

(WebKit::SharedWorkerProcess::initializeProcessName):
The SharedWorkerProcess is not an internet plug-in!

12:43 PM Changeset in webkit [144579] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix after r144565. Reverted r144533.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
11:57 AM Changeset in webkit [144578] by abarth@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the Qt build after r144498
​https://bugs.webkit.org/show_bug.cgi?id=111272

Reviewed by Eric Seidel.

Update the Qt version of the XML parser to call the new API.

  • xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::resumeParsing):
(WebCore::XMLDocumentParser::appendFragmentSource):

11:36 AM Changeset in webkit [144577] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Plug-ins that are appropriately large w.r.t page size should autostart
​https://bugs.webkit.org/show_bug.cgi?id=111242

Reviewed by Brady Eidson.

A "full-page" plug-in site should never snapshot. The trick is
how to determine what is full-page. This change implements the
following algorithm.

  • The plug-in is in the main frame (not an iframe).
  • The plug-in is sized with width and height 100%.
  • The displayed area of the plug-in is more than 96% of the viewport area.

This is definitely not foolproof. For example, zombo.com has a slight
border around its plug-in. As the window size gets smaller, the body margin
takes up more than 5% of the width or height, and the plug-in doesn't pass
the tests above.

  • html/HTMLPlugInImageElement.cpp:

(WebCore): New static constant: sizingFullPageThresholdPercentage
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Implements

the rules described above.

10:27 AM Changeset in webkit [144576] by beidson@apple.com
  • 12 edits in branches/safari-534.59-branch/Source

Merge r143815

2013-02-22 Anders Carlsson <​andersca@apple.com>

pluginLoadStrategy should take a WKDictionaryRef for extensibility
​https://bugs.webkit.org/show_bug.cgi?id=110656
<rdar://problem/13265303>

Reviewed by Jessie Berlin.

../WebCore:

Export a symbol needed by WebKit2.

  • WebCore.exp.in:

../WebKit2:

Change pluginLoadStrategy to take a WKDictionaryRef instead of a number of parameters;
this lets us add more plug-in information if needed. Also add the page URL and rename documentURL to frameURL.

  • UIProcess/API/C/WKPage.cpp: (WKPageGetPluginInformationBundleIdentifierKey): (WKPageGetPluginInformationBundleVersionKey): (WKPageGetPluginInformationDisplayNameKey): (WKPageGetPluginInformationFrameURLKey): (WKPageGetPluginInformationMIMETypeKey): (WKPageGetPluginInformationPageURLKey):
  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebLoaderClient.cpp: (WebKit): (WebKit::WebLoaderClient::pluginLoadPolicy):
  • UIProcess/WebLoaderClient.h: (WebLoaderClient):
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::getPluginPath): (WebKit::WebPageProxy::pluginInformationBundleIdentifierKey): (WebKit): (WebKit::WebPageProxy::pluginInformationBundleVersionKey): (WebKit::WebPageProxy::pluginInformationDisplayNameKey): (WebKit::WebPageProxy::pluginInformationFrameURLKey): (WebKit::WebPageProxy::pluginInformationMIMETypeKey): (WebKit::WebPageProxy::pluginInformationPageURLKey):
  • UIProcess/WebPageProxy.h: (WebPageProxy):
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::createPlugin): (WebKit::WebPage::canPluginHandleResponse):
8:16 AM Changeset in webkit [144575] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Win] IDLParser.pm fails to parse OESTextureHalfFloat and causes a build failure
​https://bugs.webkit.org/show_bug.cgi?id=111267

Reviewed by Kentaro Hara.

Allow empty definitions.

  • bindings/scripts/IDLParser.pm:

(Parse):

7:59 AM Changeset in webkit [144574] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

BUILD FIX: RenderLayerFilterInfo.h needs to include Element.h with ENABLE(SVG)

Fixes the following build failures:

In file included from Source/WebCore/rendering/RenderLayerFilterInfo.cpp:33:
Source/WebCore/rendering/RenderLayerFilterInfo.h:118:19: error: use of undeclared identifier 'Element'

Vector<RefPtr<Element> > m_internalSVGReferences;


Source/WebCore/rendering/RenderLayerFilterInfo.h:118:28: error: expected a type

Vector<RefPtr<Element> > m_internalSVGReferences;


Source/WebCore/rendering/RenderLayerFilterInfo.h:118:30: error: private field 'm_internalSVGReferences' is not used [-Werror,-Wunused-private-field]

Vector<RefPtr<Element> > m_internalSVGReferences;


3 errors generated.

  • rendering/RenderLayerFilterInfo.h: Include Element.h within

ENABLE(SVG). Move ENABLE(SVG) block below unconditional
headers.

4:05 AM Changeset in webkit [144573] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r144547.

  • WebKit.vcproj/WebKitExports.def.in:
3:47 AM Changeset in webkit [144572] by commit-queue@webkit.org
  • 23 edits
    3 deletes in trunk

Unreviewed, rolling out r144567.
​http://trac.webkit.org/changeset/144567
​https://bugs.webkit.org/show_bug.cgi?id=111266

Does not compile on apple-win (Requested by abarth on
#webkit).

Patch by Sheriff Bot <​webkit.review.bot@gmail.com> on 2013-03-03

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • loader/icon/IconController.h:

(IconController):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/chromium:

  • public/WebFrame.h:
  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::iconURLs):

  • src/WebFrameImpl.h:

(WebFrameImpl):

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
  • fast/dom/icon-url-list-apple-touch.html: Removed.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
  • platform/chromium-android/fast/dom/icon-url-list-apple-touch-expected.txt: Removed.
3:06 AM Changeset in webkit [144571] by mkwst@chromium.org
  • 8 edits in trunk/Source

CSP 1.1: Support CSP 1.1 directives on the unprefixed header.
​https://bugs.webkit.org/show_bug.cgi?id=111254

Reviewed by Adam Barth.

Source/WebCore:

We'd like to ensure that early adopters don't get stuck on a prefixed
header; when CSP 1.1 is baked enough to be supported in multiple
browsers, everything should Just Work™.

This patch changes WebKit's behavior regarding CSP_NEXT features.
Currently, they're only exposed on the prefixed header ('X-WebKit-CSP').
This patch exposes those features on the canonical header, assuming
that the runtime flag is set. This shouldn't have any effect at all on
ports that haven't yet enabled CSP_NEXT, and will simply clear the way
for a clean deployment to a wider audience once the specification
process is further along.

This change shouldn't have any effect on the existing tests: they
should run just as they did before. The next step will be to adjust
the LayoutTests for 1.1 to prefer the canonical header, but I'll do
that in another patch to reduce churn.

Related, the enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):

Use the new enum names.

  • page/ContentSecurityPolicy.cpp:

(CSPDirectiveList):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::addDirective):

Drop the 'm_experimental' property from CSPDirectiveList; we'll
control the behavior via the runtime flag from now on.

Also, this fixes a small bug in 'addDirective()': we never threw
unrecognized directive errors for users who were sending the
prefixed header. Oops!

(WebCore::ContentSecurityPolicy::deprecatedHeaderType):

Use the new enum names.

  • page/ContentSecurityPolicy.h:

Redefine the enum for clarity: 'PrefixedReport' and 'Report'
rather than 'ReportAllDirectives' and 'ReportStableDirectives'.

Source/WebKit/chromium:

The enum names no longer made sense: the difference between the
canonical 'Content-Security-Policy' header and 'X-WebKit-CSP' is the
prefix, not the functionality. This patch renames them for clarity.

  • public/WebContentSecurityPolicy.h:
  • src/AssertMatchingEnums.cpp:

Rename the Chromium side of the enums.

2:47 AM Changeset in webkit [144570] by rniwa@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: Another Windows build fix attempt after r144567.
Try touching the IDL file in a hope it'll regenerate JSInternals.cpp.

  • testing/Internals.idl:

Source/WebKit/win: That was a wrong fix. Revert r144569.

  • WebKit.vcproj/WebKitExports.def.in:
2:34 AM Changeset in webkit [144569] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r144567.

  • WebKit.vcproj/WebKitExports.def.in:
2:12 AM Changeset in webkit [144568] by abarth@webkit.org
  • 116 edits in trunk/Source

Unreviewed attempted build fix. Adds back some includes removed in
​http://trac.webkit.org/changeset/144565.

Source/WebCore:

  • Modules/mediastream/RTCPeerConnection.cpp:
  • bindings/ScriptControllerBase.cpp:
  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/FrameLoader.cpp:
  • loader/MainResourceLoader.cpp:
  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/cache/CachedResource.cpp:
  • loader/icon/IconController.cpp:
  • page/DOMWindowExtension.cpp:
  • page/Frame.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginView.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:
  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:

(WebCore):

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
1:54 AM Changeset in webkit [144567] by commit-queue@webkit.org
  • 20 edits
    3 adds in trunk

<link rel="apple-touch-icon"> tag is not honored on CNN.com, workflowy.com etc
​https://bugs.webkit.org/show_bug.cgi?id=109061

Patch by Ruslan Abdikeev <​aruslan@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: fast/dom/icon-url-list-apple-touch.html

Added iconTypes parameter to Document::iconURLs().
Added Document::shortcutIconURLs() with original semantics of iconURLs().
Fixed IconController.cpp to provide iconTypesMask to iconURLs().
Renamed iconTypes to iconTypesMask to make the meaning clearer.

  • WebCore.exp.in:
  • dom/Document.cpp:

(WebCore::Document::shortcutIconURLs):
(WebCore):
(WebCore::Document::iconURLs):

  • dom/Document.h:

(Document):

  • loader/icon/IconController.cpp:

(WebCore::IconController::iconURL):
(WebCore::IconController::urlsForTypes):

  • testing/Internals.cpp:

(WebCore::Internals::iconURLs):
(WebCore::Internals::shortcutIconURLs):
(WebCore):
(WebCore::Internals::allIconURLs):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Added test for apple-touch-icon in allIconURLs().
Changed iconURLs() to shortcutIconURLs().

  • fast/dom/icon-url-change.html:
  • fast/dom/icon-url-list-apple-touch-expected.txt: Added.
  • fast/dom/icon-url-list-apple-touch.html: Added.
  • fast/dom/icon-url-list.html:
  • fast/dom/icon-url-property.html:
1:28 AM Changeset in webkit [144566] by mkwst@chromium.org
  • 4 edits
    2 adds in trunk

CSP: Throw a warning when a '*-report-only' header doesn't contain a 'report-uri' directive.
​https://bugs.webkit.org/show_bug.cgi?id=111208

Reviewed by Adam Barth.

Source/WebCore:

Developers in the wild have been observed to serve a report-only CSP
header with a policy that doesn't contain a 'report-uri' directive.
This has zero effect, of course, and we should help them understand
that by throwing a warning up on the console.

Test: http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::isReportOnly): Added.
(WebCore::CSPDirectiveList::reportURIs): Added.
(WebCore::CSPDirectiveList::create):

After creating a CSPDirectiveList, check whether it's in
report-only mode without a report-uri. If so, warn the developer.

(WebCore::ContentSecurityPolicy::reportMissingReportURI): Added.

Write an exciting message to the console, warning the developer
about her expensive no-op machine.

LayoutTests:

  • http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/report-only-report-uri-missing.html: Added.
1:16 AM Changeset in webkit [144565] by abarth@webkit.org
  • 206 edits
    7 deletes in trunk/Source

Unreviewed rollout of ​http://trac.webkit.org/r144530
As described in ​https://bugs.webkit.org/show_bug.cgi?id=111167 and
​https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
large number of ASSERTs in chromium-win.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.cpp:
  • Modules/notifications/Notification.cpp:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/ScriptControllerBase.cpp:
  • bindings/js/JSNodeCustom.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptSourceCode.h:

(WebCore):

  • bindings/objc/DOM.mm:
  • bindings/v8/ScriptController.cpp:
  • bindings/v8/V8DOMWindowShell.cpp:
  • bindings/v8/custom/V8DOMWindowCustom.cpp:
  • css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:
  • css/WebKitCSSSVGDocumentValue.cpp:
  • css/WebKitCSSSVGDocumentValue.h:

(WebCore):

  • dom/Clipboard.cpp:

(WebCore::Clipboard::Clipboard):

  • dom/ContainerNode.cpp:
  • dom/DOMImplementation.cpp:
  • dom/PendingScript.h:
  • dom/ScriptElement.cpp:
  • dom/ScriptElement.h:
  • history/CachedFrame.cpp:
  • html/DOMURL.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAppletElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHtmlElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/ImageDocument.cpp:
  • html/ImageInputType.cpp:
  • html/MediaDocument.cpp:
  • html/PluginDocument.cpp:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLConstructionSite.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • html/parser/HTMLScriptRunner.h:
  • html/parser/XSSAuditor.cpp:
  • html/parser/XSSAuditorDelegate.cpp:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorFileSystemAgent.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.h:

(WebCore):

  • inspector/InspectorPageAgent.cpp:
  • inspector/NetworkResourcesData.cpp:
  • inspector/NetworkResourcesData.h:

(WebCore):

  • loader/CookieJar.cpp:
  • loader/CrossOriginAccessControl.cpp:
  • loader/CrossOriginAccessControl.h:

(WebCore):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/DocumentThreadableLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):

  • loader/ImageLoader.cpp:
  • loader/ImageLoader.h:
  • loader/LinkLoader.h:

(WebCore):

  • loader/MainResourceLoader.cpp:
  • loader/MainResourceLoader.h:

(WebCore):

  • loader/MixedContentChecker.cpp:
  • loader/PingLoader.cpp:
  • loader/PolicyChecker.h:

(WebCore):

  • loader/ProgressTracker.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubresourceLoader.cpp:
  • loader/TextTrackLoader.cpp:
  • loader/TextTrackLoader.h:

(WebCore):

  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:

(WebCore):

  • loader/appcache/ApplicationCacheHost.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:

(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):

  • loader/cache/CachedFontClient.h: Removed.
  • loader/cache/CachedImage.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:

(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):

  • loader/cache/CachedRawResourceClient.h: Removed.
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResourceHandle.cpp:

(WebCore):

  • loader/cache/CachedResourceHandle.h:

(WebCore):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):

  • loader/cache/CachedSVGDocument.h:

(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):

  • loader/cache/CachedSVGDocumentClient.h: Removed.
  • loader/cache/CachedSVGDocumentReference.cpp: Removed.
  • loader/cache/CachedSVGDocumentReference.h:

(WebCore):
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):

  • loader/cache/CachedStyleSheetClient.h:

(WebCore):

  • loader/cache/MemoryCache.h:

(WebCore):
(MemoryCache):

  • loader/chromium/CachedRawResourceChromium.cpp:
  • loader/icon/IconController.cpp:
  • loader/icon/IconLoader.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/DOMWindowExtension.cpp:
  • page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore):
(WebCore::Frame::reportMemoryUsage):

  • page/Frame.h:

(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):

  • page/PerformanceNavigation.cpp:
  • page/PerformanceTiming.cpp:
  • page/PointerLockController.cpp:
  • page/Settings.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • platform/chromium/PasteboardChromium.cpp:
  • platform/efl/ErrorsEfl.cpp:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/filters/FilterOperation.cpp:

(WebCore):

  • platform/graphics/filters/FilterOperation.h:

(WebCore):
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
  • platform/gtk/ErrorsGtk.cpp:
  • platform/gtk/PasteboardGtk.cpp:
  • platform/gtk/PasteboardHelper.h:
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm:
  • platform/mac/HTMLConverter.mm:
  • platform/mac/PasteboardMac.mm:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • platform/network/mac/CookieStorageMac.mm:
  • platform/qt/PasteboardQt.cpp:
  • plugins/DOMMimeType.cpp:
  • plugins/PluginRequest.h: Removed.
  • plugins/PluginStream.h:

(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):

  • plugins/PluginStreamClient.h: Removed.
  • plugins/PluginView.cpp:
  • plugins/PluginView.h:

(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):

  • rendering/HitTestResult.cpp:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderEmbeddedObject.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::RenderImageResource):
(WebCore):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):

  • rendering/RenderImageResourceStyleImage.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerFilterInfo.h:

(WebCore):

  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderSnapshottedPlugIn.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/style/StyleCachedShader.h:
  • rendering/style/StyleCustomFilterProgram.cpp: Removed.
  • rendering/style/StyleCustomFilterProgram.h:

(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):

  • svg/SVGFEImageElement.h:
  • svg/SVGFontFaceUriElement.h:

(SVGFontFaceUriElement):

  • svg/SVGImageLoader.cpp:
  • svg/SVGUseElement.cpp:
  • svg/SVGUseElement.h:
  • svg/graphics/SVGImageCache.cpp:
  • testing/MockPagePopupDriver.cpp:
  • xml/XSLStyleSheet.h:

(WebCore):

  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/chromium:

  • src/ApplicationCacheHost.cpp:
  • src/AssociatedURLLoader.cpp:
  • src/EditorClientImpl.cpp:
  • src/SharedWorkerRepository.cpp:
  • src/WebDataSourceImpl.cpp:
  • src/WebFrameImpl.h:

(WebCore):

  • src/WebNode.cpp:
  • src/WebSharedWorkerImpl.cpp:
  • tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • ewk/ewk_frame.cpp:

Source/WebKit/gtk:

  • webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:
  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebFrameNetworkingContext.mm:
  • WebView/WebRenderLayer.mm:
  • WebView/WebRenderNode.mm:

Source/WebKit/qt:

  • WebCoreSupport/NotificationPresenterClientQt.cpp:
  • WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

  • NetworkProcess/HostRecord.h:
  • NetworkProcess/NetworkResourceLoadScheduler.h:
  • NetworkProcess/NetworkResourceLoader.h:

(WebCore):

  • Shared/WebRenderLayer.cpp:
  • Shared/WebRenderObject.cpp:
  • WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/WebProcess.cpp:
  • WebProcess/soup/WebProcessSoup.cpp:
12:56 AM Changeset in webkit [144564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

WebKit API for enabling DOM logging for certain worlds
​https://bugs.webkit.org/show_bug.cgi?id=110779

Patch by Ankur Taly <​ataly@google.com> on 2013-03-03
Reviewed by Kentaro Hara.

  • WebKit.gyp:
12:52 AM Changeset in webkit [144563] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Remove TranslateParameter() from CodeGeneratorV8.pm
​https://bugs.webkit.org/show_bug.cgi?id=111218

Reviewed by Adam Barth.

TranslateParameter() does nothing. It tries to convert TimeoutHandler to DOMString,
but there is no non-custom method that uses TimeoutHandler.

The only place where TimeoutHandler is used in the WebKit IDL is setTimeout() and setInterval().
However, the latest spec uses 'any' instead of TimeoutHandler.
​http://dev.w3.org/html5/spec-LC/timers.html
Thus, this patch updates the IDL declarations of setTimeout() and setInterval()
according to the spec. By this change, TimeoutHandler is gone away from the WebKit IDL.
(Anyway this IDL change has no effect, because setTimeout() and setInterval() are written
in custom bindings.)

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
12:46 AM Changeset in webkit [144562] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

keydown and keyup events have zero keycode for some numeric pad keys under Chromium on Linux
​https://bugs.webkit.org/show_bug.cgi?id=85642

Source/WebCore:

Add missing key mappings for GDK_KP_Begin, GDK_KP_Insert, GDK_KP_Delete and GDK_ISO_Level3_Shift.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

  • platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Source/WebKit/chromium:

Add tests to verify that the fixed keys generate the same keyCode values as their equivalents.

Patch by James Weatherall <​wez@chromium.org> on 2013-03-03
Reviewed by Adam Barth.

  • WebKit.gypi:
  • tests/KeyCodeConversionTestGtk.cpp: Added.

(WebCore):
(WebCore::TEST):

12:33 AM Changeset in webkit [144561] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

REGRESSION(144520): Does not compile on chromium-win
​https://bugs.webkit.org/show_bug.cgi?id=111261

Unreviewed rollout of ​http://trac.webkit.org/changeset/144520. This
patch does not compile for chromium-win. See the bug for the compile
error.

  • rendering/ExclusionShapeInsideInfo.cpp:
  • rendering/ExclusionShapeInsideInfo.h:

(WebCore):
(LineSegmentRange):
(WebCore::LineSegmentRange::LineSegmentRange):
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::exclusionShapeInsideInfo):
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):

  • rendering/RenderBlock.h:

(WebCore):
(RenderBlock):
(RenderBlockRareData):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForLine):

Note: See TracTimeline for information about the timeline view.