⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Apr 23, 2013:

8:18 PM Changeset in webkit [149016] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG CFA filters CheckFunction in a really weird way, and assumes that the function's structure won't change
​https://bugs.webkit.org/show_bug.cgi?id=115077

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

The filtering did three things that are unusual:

1) AbstractValue::filterByValue() assumed that the passed value's structure wouldn't change, in

the sense that at it assumed it could use that value's *current* structure to do structure
filtering. Filtering by structure only makes sense if you can prove that the given value will
always have that structure (for example by either using a watchpoing or emitting code that
checks that structure at run-time).


2) AbstractValue::filterByValue() and the CheckFunction case in AbstractState::executeEffects()

tried to invalidate the CFA based on whether the filtration led to an empty value. This is
well-intentioned, but it's not how the CFA currently works. It's inconsistent with other
parts of the CFA. We shouldn't introduce this feature into just one kind of filtration and
not have it elsewhere.


3) The attempt to detect when the value was empty was actually implemented incorrectly. It

relied on AbstractValue::validate(). That method says that a concrete value does not belong
to the abstract value if it has a different structure. This makes sense for the other place
where AbstractValue::validate() is called: during OSR entry, where we are talking about a
JSValue that we see *right now*. It doesn't make sense in the CFA, since in the CFA any
value we observe in the code is a value whose structure may change when the code starts
running, and so we cannot use the value's current structure to infer things about the code
when it starts running.


I fixed the above problems by (1) changing filterByValue() to not filter the structure, (2)
changing filterByValue() and the CheckFunction case to not invalidate the CFA, and (3)
making sure that nobody else was misusing AbstractValue::validate() (they weren't).

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filterByValue):

LayoutTests:

Reviewed by Oliver Hunt.

This hilarious test fails prior to the rest of this patch.

  • fast/js/dfg-check-function-change-structure-expected.txt: Added.
  • fast/js/dfg-check-function-change-structure.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-check-function-change-structure.js: Added.

(foo):
(bar):

6:59 PM Changeset in webkit [149015] by tkent@chromium.org
  • 5 edits
    2 deletes in trunk/Source/WebCore

Remove TextFieldDecoration feature
​https://bugs.webkit.org/show_bug.cgi?id=115068

Reviewed by Andreas Kling.

Only Chromium port used this feature.

  • dom/Element.h: Remove isTextFieldDecoration.
  • html/InputType.cpp:

(WebCore::InputType::destroyShadowSubtree):
Update a comment.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.

  • html/shadow/TextFieldDecorationElement.cpp: Removed.
  • html/shadow/TextFieldDecorationElement.h: Removed.
  • page/ChromeClient.h:

(ChromeClient): Remove willAddTextFieldDecorationsTo and
addTextFieldDecorationsTo

6:23 PM Changeset in webkit [149014] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Default ParserError() initialiser doesn't initialise all fields
​https://bugs.webkit.org/show_bug.cgi?id=115074

Reviewed by Joseph Pecoraro.

Only the jsc command prompt depended on this, but we'll fix it to
be on the safe side.

  • parser/ParserError.h:

(JSC::ParserError::ParserError):

6:10 PM Changeset in webkit [149013] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Micro-optimize Length::initFromLength().
<​http://webkit.org/b/115073>

From Blink r148621 by <​timloh@chromium.org>:

This appears to improve html5-full-render by 1-2% on my system (gcc 4.6.3) by using memcpy
instead of copying members (and branching to copy the union).

  • platform/Length.h:

(WebCore::Length::initFromLength):

6:06 PM Changeset in webkit [149012] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Add missing copyright header to ColorChooserClient.h
​https://bugs.webkit.org/show_bug.cgi?id=115067

Reviewed by Andreas Kling.

  • platform/ColorChooserClient.h:

This was added in 2011 by a Google employee.
​http://trac.webkit.org/changeset/103168

5:55 PM Changeset in webkit [149011] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Call the correct superclass in RenderSlider::layout().
<​http://webkit.org/b/115071>

From Blink r147850 by <​cbiesinger@chromium.org>:

The superclass is RenderFlexibleBox, not RenderBlock.

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::layout):

5:53 PM Changeset in webkit [149010] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Add platform support for -webkit-background-blend-mode to CG context with background color
​https://bugs.webkit.org/show_bug.cgi?id=114412

Patch by Mihai Tica <​mitica@adobe.com> on 2013-04-23
Reviewed by Darin Adler.

Source/WebCore:

Tests: css3/compositing/effect-background-blend-mode-color.html, css3/compositing/effect-background-blend-mode-color2.html

This patch adds support for blending on background colors to the Core Graphics port of WebKit.

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):

  • platform/graphics/GraphicsContext.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

LayoutTests:

Adding pixel tests for -webkit-background-blend-mode with bg-color
effect-background-blend-mode-color.html uses accelerated compositing
effect-background-blend-mode-color2.html uses software rendering

  • css3/compositing/effect-background-blend-mode-color-expected.txt: Added.
  • css3/compositing/effect-background-blend-mode-color.html: Added.
  • platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Added.
  • css3/compositing/effect-background-blend-mode-color2-expected.txt: Added.
  • css3/compositing/effect-background-blend-mode-color2.html: Added.
  • platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Added.
5:33 PM Changeset in webkit [149009] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an unused member variable erroneously added in r149007.

  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(LogicalSelectionOffsetCaches):

5:20 PM Changeset in webkit [149008] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Build break after r149004
​https://bugs.webkit.org/show_bug.cgi?id=115066

Reviewed by Tim Horton.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged):
Added dummy method for new virtual method.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost): Ditto.

5:18 PM Changeset in webkit [149007] by rniwa@webkit.org
  • 9 edits
    1 add in trunk/Source/WebCore

logicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth() multiple times
​https://bugs.webkit.org/show_bug.cgi?id=113479

Reviewed by David Hyatt.

Introduced LogicalSelectionOffsetCaches to cache the containing blocks and their logical left and right
selection offsets in computing selection gaps. An instance of this class stores the containing block for
each position type and caches their logical selection offsets when none of their block ancestors up until
its nearest selection root do no have any floating objects or regions and exclusions.

When blockSelectionGaps recurses to another level, it creates a new cache instance by "inheriting"
(like RenderStyle) from the old cache, overriding those containing blocks that are replaced by "this".

This eliminates the need to traverse containing block ancestors in RenderBlock::logicalLeftSelectionOffset
and RenderBlock::logicalRightSelectionOffset, and improves WebKit's performance by roughly 20%.

Performance Tests: Interactive/SelectAll.html

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/LogicalSelectionOffsetCaches.h: Added.

(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Moved from RenderObject.h.
(WebCore::isNonRenderBlockInline): Ditto.
(WebCore::containingBlockForFixedPosition): Extracted from RenderObject::containingBlock.
(WebCore::containingBlockForAbsolutePosition): Ditto.
(WebCore::containingBlockForObjectInFlow): Ditto.

(WebCore::LogicalSelectionOffsetCaches): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock): Added. m_hasFloatsOrRegions is
or'ed with itself when ContainingBlockInfo is copy constructed since m_hasFloatsOrRegions needs be true
for a block when any of its containing block ancestors have floats or regions.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::block): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::cache): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset): Added. Caches
the logical selection offset if it hasn't.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset): Ditto.

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches): The first constructor is used
for a selection root. The second one is used for inheriting from another cache. In the latter case,
copy all containing block information except ones that need to be overridden by this block.
(WebCore::LogicalSelectionOffsetCaches::containingBlockInfo): Returns a ContainingBlockInfo based on
object's position value.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps): Exit before instantiating a new LogicalSelectionOffsetCaches
if there is no child to recurse.
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset): Use LogicalSelectionOffsetCaches to get its containing
block and its logical selection offset.
(WebCore::RenderBlock::logicalRightSelectionOffset): Ditto.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock): Extracted code into LogicalSelectionOffsetCaches.h.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::lineSelectionGap):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox):

4:44 PM Changeset in webkit [149006] by Simon Fraser
  • 3 edits in trunk/Source/WebKit2

Turn off tiled drawing in the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=115064

Reviewed by Tim Horton.

We get little benefit from making the Web Inspector use tiled drawing;
it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
Not using tiled drawing also means that we won't make compositing
layers for position: -webkit-sticky, which avoids a number of issues
with compositing layer proliferation in the inspector.

Also turn off accelerated drawing, since that pref will force a single
compositing layer.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup):

  • UIProcess/mac/WebInspectorProxyMac.mm:
4:35 PM Changeset in webkit [149005] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] forced subtitle track should change when audio track language changes
​https://bugs.webkit.org/show_bug.cgi?id=115043

Reviewed by Jer Noble.

No new tests, it isn't possible to test this automatically because there is currently no way
to enable/disable audio tracks.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Set m_forcedOrAutomaticSubtitleTrackLanguage.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Call markCaptionAndSubtitleTracksAsUnconfigured

after a delay if the language of the primary audio track changes.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): markCaptionAndSubtitleTracksAsUnconfigured API change.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Take parameter to allow

the reconfiguration to happen after a delay to avoid doing it during a callback from the
media engine. Clear the ConfigureTextTracks bit in m_pendingActionFlags to cancel any pending
asynch configuration.

  • html/HTMLMediaElement.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Clean up logic.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Call characteristicChanged when

the primary audio track language changes.

4:02 PM Changeset in webkit [149004] by Simon Fraser
  • 6 edits in trunk/Source/WebKit2

When the web page transparency changes, DrawingAreaImpl needs to know about it
​https://bugs.webkit.org/show_bug.cgi?id=115062

Reviewed by Tim Horton.

The non-composited contents layer owned by LayerTreeHostMac needs to
be marked as opaque or not depending on whether the WebPage draws
a background (or transparent background). It computed this at creation,
but did not dynamically update the state. Fix it so it does.

This fixes cases of garbage pixels in the Web Inspector toolbar area
in some configurations.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::pageBackgroundTransparencyChanged):

  • WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

  • WebProcess/WebPage/LayerTreeHost.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.h:
  • WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::pageBackgroundTransparencyChanged):

3:43 PM Changeset in webkit [149003] by hmuller@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Exclusions] Improve ExclusionPolygon smart pointer safety
​https://bugs.webkit.org/show_bug.cgi?id=114984

Reviewed by Dirk Schulze.

Assign newly allocated objects to PassOwnPtrs as early as possible to reduce the
chances of future leaks. No new tests were added, this change adds no new functionality.

  • rendering/ExclusionPolygon.cpp:

(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
(WebCore::ExclusionPolygon::shapePaddingBounds):
(WebCore::ExclusionPolygon::shapeMarginBounds):

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

3:36 PM Changeset in webkit [149002] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Revert "Throttle resize events during live window resize."
<​http://webkit.org/b/114292>
<rdar://problem/13411454>
<rdar://problem/13694839>

Reviewed by Geoffrey Garen.

It appears that this caused more glitches than it helped resize performance.

  • page/FrameView.h:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEvent):

Turn the null-check of m_frame into an assertion since this method is
no longer called asynchronously.

(WebCore::FrameView::willEndLiveResize):

Ninja fix: call up to the closest superclass implementation.

3:34 PM Changeset in webkit [149001] by Christophe Dumez
  • 10 edits
    1 copy
    1 move
    4 adds
    13 deletes in trunk

Global constructors should be configurable and not enumerable
​https://bugs.webkit.org/show_bug.cgi?id=110573

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update JSObject::deleteProperty() so that mark to set the property
value to undefined if it is in static hashtable of properties. The
previous code was not doing anything in this case and this meant
we could not remove builtin DOMWindow properties such as
"ProgressEvent" even if marked as Deletable.

  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

  • runtime/Lookup.h:

(JSC):
(JSC::putEntry):
(JSC::lookupPut):

Source/WebCore:

Update JSC Code generator so that global constructors now have the following
attributes:
{ Writable: true, Enumerable: false, Configurable: true }
instead of previously:
{ Writable: true, Enumerable: true, Configurable: false }

The new behavior is according to the Web IDL specification (section 4.4):
​http://dev.w3.org/cvsweb/~checkout~/2006/webapi/WebIDL/Overview.html?rev=1.617;content-type=text%2Fhtml#es-interfaces

This also matches the behavior of Firefox.

Tests: fast/js/global-constructors-attributes.html

fast/js/global-constructors-deletable.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):

LayoutTests:

Add new tests to make sure that the global constructors have the
right attributes and to check that they are 'Deletable'.

  • canvas/philip/tests/type.delete-expected.txt: Removed.
  • canvas/philip/tests/type.delete.html: Removed. It was checking that global constructor

could NOT be deleted, which is no longer according to the Web IDL specification.

  • fast/dom/constructed-objects-prototypes-expected.txt:
  • fast/dom/script-tests/constructed-objects-prototypes.js: Update test to hardcode a few

global constructors as they are no longer enumerable.

  • fast/js/getOwnPropertyDescriptor-expected.txt:
  • fast/js/global-constructors.html: Removed. It was relying on the global constructors

to be 'Enumerable', which is not to the latest Web IDL specification.

  • fast/js/global-constructors-attributes-expected.txt: Added.
  • fast/js/global-constructors-attributes.html: Added.
  • fast/js/global-constructors-deletable-expected.txt: Added.
  • fast/js/global-constructors-deletable.html: Added.
  • fast/js/global-constructors-expected.txt: Removed.
  • fast/js/resources/getOwnPropertyDescriptor.js:
  • fast/js/script-tests/global-constructors-attributes.js: Added.
  • fast/js/script-tests/global-constructors-deletable.js: Added.
  • fast/js/script-tests/global-constructors.js: Removed.
  • platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
  • platform/efl/fast/js/global-constructors-expected.txt: Removed.
  • platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
  • platform/gtk/fast/js/global-constructors-expected.txt: Removed.
  • platform/mac/fast/js/global-constructors-expected.txt: Removed.
  • platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
  • platform/qt/fast/js/global-constructors-expected.txt: Removed.
  • platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
  • platform/win/fast/js/global-constructors-expected.txt: Removed.
3:23 PM Changeset in webkit [149000] by dgrogan@chromium.org
  • 2 edits in trunk/Tools

Unreviewed. Remove myself from watchlist.

  • Scripts/webkitpy/common/config/watchlist:
3:18 PM Changeset in webkit [148999] by ggaren@apple.com
  • 16 edits
    3 adds in trunk

Source/JavaScriptCore: Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

This covers a few cases like:

  • while (true) { }
  • while (1) { }
  • if (x) break;
  • if (x) continue;
  • if (boolean_expr == boolean_const) { }
  • if (boolean_expr == 1_or_0) { }
  • if (bitop == 1_or_0) { }

This also works, but will bring shame on your family:

  • while ("hello world") { }

No change on the benchmarks we track, but a 2.5X speedup on a microbenchmark
that uses these techniques.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldEmitDebugHooks): Updated ancillary code
for interface simplifications.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ConstantNode::emitBytecodeInConditionContext): Constants can
jump unconditionally when used within a condition context.

(JSC::ConstantNode::emitBytecode):
(JSC::StringNode::jsValue): Gave constants a common base class so I
could implement their codegen just once.

(JSC::BinaryOpNode::emitBytecodeInConditionContext):
(JSC::canFoldToBranch):
(JSC::BinaryOpNode::tryFoldToBranch): Fold (!/=)= and (!/=)== where
appropriate. A lot of cases are not appropriate because of the surprising
type conversion semantics of ==. For example, if (number == true) { } is
not the same as if (number) { } because the former will up-convert true
to number and then do numeric comparison.

(JSC::singleStatement):
(JSC::IfElseNode::tryFoldBreakAndContinue):
(JSC::IfElseNode::emitBytecode):
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget): Fold "if (expression) break" and
"if (expression) continue" into direct jumps from expression.

  • parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::createIfStatement):

  • parser/NodeConstructors.h:

(JSC::ConstantNode::ConstantNode):
(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfElseNode::IfElseNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isConstant):
(JSC::ExpressionNode::isBoolean):
(JSC::StatementNode::isBreak):
(JSC::StatementNode::isContinue):
(ConstantNode):
(JSC::ConstantNode::isPure):
(JSC::ConstantNode::isConstant):
(NullNode):
(JSC::NullNode::jsValue):
(JSC::BooleanNode::value):
(JSC::BooleanNode::isBoolean):
(JSC::BooleanNode::jsValue):
(JSC::NumberNode::value):
(NumberNode):
(JSC::NumberNode::jsValue):
(StringNode):
(BinaryOpNode):
(IfElseNode):
(ContinueNode):
(JSC::ContinueNode::isContinue):
(BreakNode):
(JSC::BreakNode::isBreak):

  • parser/Parser.cpp:

(JSC::::parseIfStatement):

  • parser/ResultType.h:

(JSC::ResultType::definitelyIsBoolean):
(ResultType):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

  • runtime/JSCell.h:
  • runtime/JSCellInlines.h:

(JSC::JSCell::pureToBoolean): Updated for interface changes above.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

  • wtf/TriState.h:

(WTF::triState):
(WTF):

LayoutTests: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
​https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a performance test for interesting branch types.

  • fast/js/regress/branch-fold-expected.txt: Added.
  • fast/js/regress/branch-fold.html: Added.
  • fast/js/regress/script-tests/branch-fold.js: Added.
3:01 PM Changeset in webkit [148998] by Simon Fraser
  • 4 edits
    4 adds in trunk

Don't create compositing layers for sticky position unless using the ScrollingCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=115060

Source/WebCore:

Reviewed by Tim Horton.

Creating compositing layers for sticky position elements is only useful
when we're using a ScrollingCoordinator, so don't create them if
we're not in a frame that uses a scrolling coordinator.

Tests: compositing/layer-creation/no-compositing-for-sticky.html

platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Tim Horton.

Tests that we create layers for sticky position when in tiled drawing mode,
and that we have no layers when not.

  • compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
  • compositing/layer-creation/no-compositing-for-sticky.html: Added.
  • platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html: Added.
2:59 PM Changeset in webkit [148997] by Christophe Dumez
  • 34 edits
    1 copy
    2 adds in trunk

'length' property of DOM bindings functions returns wrong value
​https://bugs.webkit.org/show_bug.cgi?id=110569

Reviewed by Geoffrey Garen.

Source/WebCore:

Make the 'length' property of Function objects and Interface
objects behave according to the latest Web IDL specification
editor draft:
​http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
​http://dev.w3.org/2006/webapi/WebIDL/#es-operations

As a result, only mandatory arguments are taken into account
when computing the value for the 'length' property. This
behavior is consistent with Firefox and Blink.

Tests: fast/js/constructor-length.html

fast/js/function-length.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateConstructorHelperMethods):
Update the JSC code generator to only account for mandatory parameters
when computing the value for the 'length' property of Function objects
and constructors.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore):
Rebaseline bindings tests results.

  • fileapi/Blob.idl:

Remove 'ConstructorParameters=2' extended attribute as the correct value
is 0, given that a Blob can be constructed without parameter.

  • html/canvas/DataView.idl:

Update ConstructorParameters extended attribute value from 3 to 1 as only
one of the 3 parameters is mandatory.

  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:

Remove 'ConstructorParameters=1' extended attribute from interfaces using
'ConstructorTemplate=TypedArray' as the bindings generator now properly
compute the number of constructor parameters for such interfaces.

  • page/WebKitPoint.idl:

Remove 'ConstructorParameters=2' extended attribute as the correct value
should be 0, given that a WebKitPoint can be constructed without parameters.

LayoutTests:

Update fast/js/constructor-length.html test case now that only
mandatory arguments are considered for the constructor length.

Also add a new fast/js/function-length.html test to make sure
that the 'length' property of Function objects from DOM
bindings behaves according to the Web IDL specification as
this was not covered by existing tests.

  • fast/files/blob-constructor-expected.txt: Rebaseline.
  • fast/files/script-tests/blob-constructor.js: Update test now that Blob constructor

length is 0 instead of 2.

  • fast/js/constructor-length.html:
  • fast/js/function-length-expected.txt: Added.
  • fast/js/function-length.html: Added.
  • platform/blackberry/fast/js/constructor-length-expected.txt: Rebaseline.
  • platform/efl/TestExpectations: Unskip fast/js/constructor-length.html for EFL port.
  • platform/efl/fast/js/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/fast/js/constructor-length-expected.txt.
  • platform/gtk/fast/js/constructor-length-expected.txt: Rebaseline.
  • platform/mac/fast/js/constructor-length-expected.txt: Rebaseline.
  • platform/qt/fast/js/constructor-length-expected.txt: Rebaseline.
2:58 PM Changeset in webkit [148996] by commit-queue@webkit.org
  • 6 edits in trunk

NRWT: confusing warning about a line being in a Skipped file when it is really just listed
in _missing_symbol_to_skipped_tests in base.py
​https://bugs.webkit.org/show_bug.cgi?id=108884

Patch by Jessie Berlin <​jberlin@apple.com> on 2013-04-23
Reviewed by Tim Horton.

Tools:

Remove symbol-based skipped list detection.

  • Scripts/webkitpy/port/base.py:

(Port._missing_feature_to_skipped_tests):
(Port._skipped_tests_for_unsupported_features):

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.test_path_to_test_expectations_file):

LayoutTests:

Explicitly skip the mhtml tests on the Mac and Win ports.

  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
2:56 PM Changeset in webkit [148995] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r148922): Crash opening web archives or loading web pages
​https://bugs.webkit.org/show_bug.cgi?id=115061
<rdar://problem/13714228>

Reviewed by Sam Weinig.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
Calling ResourceLoader::didReceiveResponse can cause the WebResourceLoader object to go away,
so protect it here and guard against a null core loader.

2:35 PM Changeset in webkit [148994] by benjamin@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebKit

Remove the WebKit layer of wxWebKit
​https://bugs.webkit.org/show_bug.cgi?id=115006

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Anders Carlsson.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

  • wx/WebBrowserShell.cpp: Removed.
  • wx/WebBrowserShell.h: Removed.
  • wx/WebDOMSelection.cpp: Removed.
  • wx/WebDOMSelection.h: Removed.
  • wx/WebEdit.cpp: Removed.
  • wx/WebEdit.h: Removed.
  • wx/WebFrame.cpp: Removed.
  • wx/WebFrame.h: Removed.
  • wx/WebFramePrivate.h: Removed.
  • wx/WebKitDefines.h: Removed.
  • wx/WebKitSupport/ChromeClientWx.cpp: Removed.
  • wx/WebKitSupport/ChromeClientWx.h: Removed.
  • wx/WebKitSupport/ContextMenuClientWx.cpp: Removed.
  • wx/WebKitSupport/ContextMenuClientWx.h: Removed.
  • wx/WebKitSupport/DragClientWx.cpp: Removed.
  • wx/WebKitSupport/DragClientWx.h: Removed.
  • wx/WebKitSupport/EditCommandWx.h: Removed.
  • wx/WebKitSupport/EditorClientWx.cpp: Removed.
  • wx/WebKitSupport/EditorClientWx.h: Removed.
  • wx/WebKitSupport/FrameLoaderClientWx.cpp: Removed.
  • wx/WebKitSupport/FrameLoaderClientWx.h: Removed.
  • wx/WebKitSupport/FrameNetworkingContextWx.h: Removed.
  • wx/WebKitSupport/InspectorClientWx.cpp: Removed.
  • wx/WebKitSupport/InspectorClientWx.h: Removed.
  • wx/WebSettings.cpp: Removed.
  • wx/WebSettings.h: Removed.
  • wx/WebView.cpp: Removed.
  • wx/WebView.h: Removed.
  • wx/WebViewPrivate.h: Removed.
  • wx/bindings/python/samples/simple.py: Removed.
  • wx/bindings/python/webview.i: Removed.
  • wx/bindings/python/wscript: Removed.
  • wx/wscript: Removed.
2:24 PM Changeset in webkit [148993] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Minor String usage fixes in WebCore/platform
​https://bugs.webkit.org/show_bug.cgi?id=115021

Reviewed by Andreas Kling.

Use ASCIILiteral when possible + minor fixes.

  • platform/ContentType.cpp:

(WebCore::ContentType::codecs):

  • platform/ContentType.h:

(ContentType):

  • platform/Decimal.cpp:

(WebCore::Decimal::toString):

  • platform/KURL.cpp:

(WebCore::KURL::setProtocol):

2:18 PM Changeset in webkit [148992] by krit@webkit.org
  • 4 edits
    6 adds in trunk

Pick up color and mat values in custom shaders
​https://bugs.webkit.org/show_bug.cgi?id=115046

Reviewed by Dean Jackson.

Source/WebCore:

The custom filter functions accept color values and mat2-4 functions
as parameter types. These were implemented in CSS already.
This patch picks up the values and applies them as uniforms to the
custom shader program.

Tests: css3/filters/custom/custom-filter-color.html

css3/filters/custom/custom-filter-matN.html

  • platform/graphics/filters/CustomFilterRenderer.cpp:

(WebCore::CustomFilterRenderer::bindProgramColorParameters): Set uniform for color values.
(WebCore):
(WebCore::CustomFilterRenderer::bindProgramMatrixParameters): Set uniform for mat2-4 values.
(WebCore::CustomFilterRenderer::bindProgramParameters): Call color and matrix functions.

  • platform/graphics/filters/CustomFilterRenderer.h:

(WebCore):
(CustomFilterRenderer):

LayoutTests:

Test that the CSS defined color values and mat2-4 functions get
set as uniforms in shader programs.

  • css3/filters/custom/custom-filter-color-expected.html: Added.
  • css3/filters/custom/custom-filter-color.html: Added.
  • css3/filters/custom/custom-filter-matN-expected.html: Added.
  • css3/filters/custom/custom-filter-matN.html: Added.
2:04 PM Changeset in webkit [148991] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
​https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>

Reviewed by Simon Fraser.

Stop the primary plugin detection timer if the WebPage is torn down.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

1:58 PM Changeset in webkit [148990] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebCore

Remove redundant code in ViewportArguments::resolve
​https://bugs.webkit.org/show_bug.cgi?id=115054

Patch by Jacky Jiang <​zhajiang@blackberry.com>.
Reviewed by Kenneth Rohde Christiansen.

Remove redundant code "result.orientation = orientation;".

  • dom/ViewportArguments.cpp:

(WebCore::ViewportArguments::resolve):

1:54 PM Changeset in webkit [148989] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Simplify the baseline JIT loop hint call site.
​https://bugs.webkit.org/show_bug.cgi?id=115052.

Reviewed by Geoffrey Garen.

Moved the watchdog timer check after the JIT optimization check. This
ensures that the JIT opimization counter is incremented on every loop
hint even if the watchdog timer fires.

Removed the code that allows the JIT OSR to happen if the watchdog
timer fires but does not result in a termination. It is extremely rare
that the JIT optimization counter would trigger an OSR on the same pass
as when the watchdog timer fire. If it does happen, we'll simply hold
off on servicing the watchdog timer until the next pass (because it's
not time critical).

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):

1:51 PM Changeset in webkit [148988] by Simon Fraser
  • 3 edits
    2 adds in trunk

Tiled layers clipped inside nested transform/preserve-3d hierarchies
​https://bugs.webkit.org/show_bug.cgi?id=115044

Source/WebCore:

Reviewed by Dean Jackson.

The optimization added in r139479 to call move() for integral translation
transforms hit a bug in TransformState::move(). If m_accumulatedTransform is
not null, we have to apply it.

Test: compositing/visible-rect/flipped-preserve-3d.html

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::move):

LayoutTests:

Reviewed by Dean Jackson.

Testcase that dumps visible rects for tiled layers inside nested
transformed/preserve-3d hierarchies.

  • compositing/visible-rect/flipped-preserve-3d-expected.txt: Added.
  • compositing/visible-rect/flipped-preserve-3d.html: Added.
1:39 PM Changeset in webkit [148987] by Claudio Saavedra
  • 8 edits
    22 adds in trunk

Ctrl+Shift+Right in Windows should select the spacing after the word
​https://bugs.webkit.org/show_bug.cgi?id=110487

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/deleting/smart-editing-disabled-win.html

editing/execCommand/remove-format-multiple-elements-win.html
editing/execCommand/toggle-link-win.html
editing/execCommand/toggle-unlink-win.html
editing/selection/extend-selection-enclosing-block-win.html
editing/style/make-text-writing-direction-inline-win.html
editing/style/push-down-font-styles-win.html
editing/style/push-down-implicit-styles-around-list-win.html

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::nextWordPositionForPlatform): New method
that takes platform-specific editing behaviour in order to decide
what the next word position is, that is, for Windows, skip
spacing, for all other platforms, behave as currently.
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft): Use the new method
in all of the above.

  • editing/FrameSelection.h: Declare the new method.

LayoutTests:

  • editing/deleting/smart-editing-disabled-win-expected.txt: Added.
  • editing/deleting/smart-editing-disabled-win.html: Added.
  • editing/execCommand/query-command-state-expected.txt:
  • editing/execCommand/remove-format-multiple-elements-win-expected.txt: Added.
  • editing/execCommand/remove-format-multiple-elements-win.html: Added.
  • editing/execCommand/script-tests/query-command-state.js:

(runTests): Update to reflect new editing behavior in Windows.

  • editing/execCommand/script-tests/remove-format-multiple-elements-win.js: Added.
  • editing/execCommand/script-tests/toggle-link-win.js: Added.
  • editing/execCommand/script-tests/toggle-unlink-win.js: Added.
  • editing/execCommand/toggle-link-win-expected.txt: Added.
  • editing/execCommand/toggle-link-win.html: Added.
  • editing/execCommand/toggle-unlink-win-expected.txt: Added.
  • editing/execCommand/toggle-unlink-win.html: Added.
  • editing/selection/extend-selection-enclosing-block-win-expected.txt: Added.
  • editing/selection/extend-selection-enclosing-block-win.html: Added.
  • editing/selection/resources/extend-selection.js:

(extendSelectionWithinBlockWin): Method to test behavior in windows.
(extendAndLogSelectionWithinBlock): Add test support for Windows.

  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:

Add test support for Windows editing behavior.

  • editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
  • editing/style/make-text-writing-direction-inline-win.html: Added.
  • editing/style/push-down-font-styles-win-expected.txt: Added.
  • editing/style/push-down-font-styles-win.html: Added.
  • editing/style/push-down-implicit-styles-around-list-win-expected.txt: Added.
  • editing/style/push-down-implicit-styles-around-list-win.html: Added.
  • editing/style/script-tests/make-text-writing-direction-inline-win.js: Added.
  • editing/style/script-tests/push-down-font-styles-win.js: Added.
  • editing/style/script-tests/push-down-implicit-styles-around-list-win.js: Added.
1:24 PM Changeset in webkit [148986] by zoltan@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
​https://bugs.webkit.org/show_bug.cgi?id=115053

Unreviewed gardening.

  • platform/qt/TestExpectations: Skip failing tests.
1:17 PM Changeset in webkit [148985] by roger_fong@apple.com
  • 4 edits in trunk/Source

AppleWin build fix.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • WTF.vcproj/WTF.vcproj:
12:59 PM Changeset in webkit [148984] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Inline SelectorQuery::matches, SelectorQuery::queryAll, SelectorQuery::queryFirst
​https://bugs.webkit.org/show_bug.cgi?id=115012

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

Each of these function has a single call site:
-SelectorQuery::matches from Element::webkitMatchesSelector.
-SelectorQuery::queryAll from Node::querySelectorAll.
-SelectorQuery::queryFirst from Node::querySelector.

Having a dedicated method to jump to was a little overkill.

  • dom/SelectorQuery.cpp:
  • dom/SelectorQuery.h:

(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):

12:51 PM Changeset in webkit [148983] by benjamin@webkit.org
  • 1 edit
    7 deletes in trunk/Source/WebCore

Remove wxWebKit's folders from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=115007

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

  • accessibility/wx/AccessibilityObjectWx.cpp: Removed.
  • editing/wx/EditorWx.cpp: Removed.
  • page/wx/DragControllerWx.cpp: Removed.
  • page/wx/EventHandlerWx.cpp: Removed.
  • platform/graphics/wx/ColorWx.cpp: Removed.
  • platform/graphics/wx/FloatRectWx.cpp: Removed.
  • platform/graphics/wx/FontCacheWx.cpp: Removed.
  • platform/graphics/wx/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/wx/FontCustomPlatformData.h: Removed.
  • platform/graphics/wx/FontPlatformData.h: Removed.
  • platform/graphics/wx/FontPlatformDataWx.cpp: Removed.
  • platform/graphics/wx/FontPlatformDataWxMac.mm: Removed.
  • platform/graphics/wx/FontWx.cpp: Removed.
  • platform/graphics/wx/GlyphMapWx.cpp: Removed.
  • platform/graphics/wx/GradientWx.cpp: Removed.
  • platform/graphics/wx/GraphicsContextWx.cpp: Removed.
  • platform/graphics/wx/IconWx.cpp: Removed.
  • platform/graphics/wx/ImageBufferDataWx.h: Removed.
  • platform/graphics/wx/ImageBufferWx.cpp: Removed.
  • platform/graphics/wx/ImageWx.cpp: Removed.
  • platform/graphics/wx/IntPointWx.cpp: Removed.
  • platform/graphics/wx/IntRectWx.cpp: Removed.
  • platform/graphics/wx/IntSizeWx.cpp: Removed.
  • platform/graphics/wx/PathWx.cpp: Removed.
  • platform/graphics/wx/SimpleFontDataWx.cpp: Removed.
  • platform/graphics/wx/TransformationMatrixWx.cpp: Removed.
  • platform/image-decoders/wx/ImageDecoderWx.cpp: Removed.
  • platform/wx/ClipboardWx.cpp: Removed.
  • platform/wx/ClipboardWx.h: Removed.
  • platform/wx/ContextMenuItemWx.cpp: Removed.
  • platform/wx/ContextMenuWx.cpp: Removed.
  • platform/wx/CursorWx.cpp: Removed.
  • platform/wx/DragDataWx.cpp: Removed.
  • platform/wx/DragImageWx.cpp: Removed.
  • platform/wx/EventLoopWx.cpp: Removed.
  • platform/wx/FileSystemWx.cpp: Removed.
  • platform/wx/KeyEventWin.cpp: Removed.
  • platform/wx/KeyboardEventWx.cpp: Removed.
  • platform/wx/LanguageWx.cpp: Removed.
  • platform/wx/LocalDC.h: Removed.
  • platform/wx/LocalizedStringsWx.cpp: Removed.
  • platform/wx/LoggingWx.cpp: Removed.
  • platform/wx/MimeTypeRegistryWx.cpp: Removed.
  • platform/wx/MouseEventWx.cpp: Removed.
  • platform/wx/MouseWheelEventWx.cpp: Removed.
  • platform/wx/PasteboardWx.cpp: Removed.
  • platform/wx/PopupMenuWx.cpp: Removed.
  • platform/wx/PopupMenuWx.h: Removed.
  • platform/wx/RenderThemeWx.cpp: Removed.
  • platform/wx/RunLoopWx.cpp: Removed.
  • platform/wx/SSLKeyGeneratorWx.cpp: Removed.
  • platform/wx/ScreenWx.cpp: Removed.
  • platform/wx/ScrollViewWx.cpp: Removed.
  • platform/wx/ScrollbarThemeWx.cpp: Removed.
  • platform/wx/ScrollbarThemeWx.h: Removed.
  • platform/wx/SearchPopupMenuWx.cpp: Removed.
  • platform/wx/SearchPopupMenuWx.h: Removed.
  • platform/wx/SharedBufferWx.cpp: Removed.
  • platform/wx/SharedTimerWx.cpp: Removed.
  • platform/wx/SoundWx.cpp: Removed.
  • platform/wx/SystemTimeWx.cpp: Removed.
  • platform/wx/TemporaryLinkStubs.cpp: Removed.
  • platform/wx/TextBreakIteratorInternalICUWx.cpp: Removed.
  • platform/wx/WidgetWx.cpp: Removed.
  • platform/wx/wxcode/cairo/non-kerned-drawing.cpp: Removed.
  • platform/wx/wxcode/fontprops.cpp: Removed.
  • platform/wx/wxcode/fontprops.h: Removed.
  • platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp: Removed.
  • platform/wx/wxcode/gtk/fontprops.cpp: Removed.
  • platform/wx/wxcode/gtk/non-kerned-drawing.cpp: Removed.
  • platform/wx/wxcode/gtk/scrollbar_render.cpp: Removed.
  • platform/wx/wxcode/mac/carbon/fontprops.mm: Removed.
  • platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp: Removed.
  • platform/wx/wxcode/mac/carbon/scrollbar_render.cpp: Removed.
  • platform/wx/wxcode/non-kerned-drawing.h: Removed.
  • platform/wx/wxcode/scrollbar_render.h: Removed.
  • platform/wx/wxcode/win/fontprops.cpp: Removed.
  • platform/wx/wxcode/win/non-kerned-drawing.cpp: Removed.
  • platform/wx/wxcode/win/scrollbar_render.cpp: Removed.
  • plugins/wx/PluginDataWx.cpp: Removed.
12:44 PM Changeset in webkit [148982] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

AppleWin VS2010 build fix.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
12:29 PM WebKitGTK/2.0.x edited by kov@webkit.org
gcc-related build fixes (diff)
12:28 PM Changeset in webkit [148981] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Remove unused code of RefCounted after chromium removal
​https://bugs.webkit.org/show_bug.cgi?id=115009

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Ryosuke Niwa.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::refCount):
(RefCountedBase):
It looks like addressOfCount() is no longer needed.
Also change the type back to unsigned as it make more sense.

12:21 PM Changeset in webkit [148980] by benjamin@webkit.org
  • 10 edits
    4 deletes in trunk/Tools

Remove wxWebKit support from the Tools
​https://bugs.webkit.org/show_bug.cgi?id=115005

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.

The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/config.h:
  • DumpRenderTree/wscript: Removed.
  • DumpRenderTree/wx/DumpRenderTreeWx.cpp: Removed.
  • DumpRenderTree/wx/DumpRenderTreeWx.h: Removed.
  • DumpRenderTree/wx/GCControllerWx.cpp: Removed.
  • DumpRenderTree/wx/TestRunnerWx.cpp: Removed.
  • DumpRenderTree/wx/WorkQueueItemWx.cpp: Removed.
  • Scripts/build-dumprendertree:
  • Scripts/build-jsc:

(buildMyProject):

  • Scripts/build-webkit:
  • Scripts/old-run-webkit-tests:
  • Scripts/run-launcher:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(determineConfigurationProductDir):
(determinePassedArchitecture):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):

  • Scripts/webkitpy/common/config/contributionareas.py:
  • waf/build/build_utils.py: Removed.
  • waf/build/settings.py: Removed.
  • waf/build/waf_extensions.py: Removed.
  • waf/build/wxpresets.py: Removed.
  • wx/browser/browser.cpp: Removed.
  • wx/browser/wscript: Removed.
  • wx/install-unix-extras: Removed.
  • wx/packaging/build-debian-installer.py: Removed.
  • wx/packaging/build-mac-installer.py: Removed.
  • wx/packaging/build-win-installer.py: Removed.
  • wx/packaging/debian/changelog: Removed.
  • wx/packaging/debian/compat: Removed.
  • wx/packaging/debian/control: Removed.
  • wx/packaging/debian/copyright: Removed.
  • wx/packaging/debian/python-webkitwx.install: Removed.
  • wx/packaging/debian/rules: Removed.
  • wx/packaging/wxWebKitInstaller.iss.in: Removed.
12:15 PM Changeset in webkit [148979] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

RetainPtr.h should compile with -Wshorten-64-to-32
<​http://webkit.org/b/115047>

Reviewed by Anders Carlsson.

Fixes the following warning:

RetainPtr.h:318:20: error: implicit conversion loses integer precision: 'CFHashCode' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

return CFHash(o.get());

  • wtf/RetainPtr.h:

(WTF::RetainPtrObjectHash::hash): Cast return value of CFHash()
to unsigned. This has no effect on 32-bit architectures, but
takes the lower 32-bits of the CFHashCode (unsigned long) on
64-bit architectures, which is what happens implicitly now.

12:12 PM Changeset in webkit [148978] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
​https://bugs.webkit.org/show_bug.cgi?id=114952

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2013-04-23
Reviewed by Rob Buis.

Do not assume that Batch requests are only created whe input field
is focused, the Editor can also create Batch requests when pasting
a selection.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Remove invalid assert.

12:09 PM Changeset in webkit [148977] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk/LayoutTests

Remove fast/js/i18n-bindings-locale.html
​https://bugs.webkit.org/show_bug.cgi?id=115024

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-23
Reviewed by Geoffrey Garen.

Remove V8-i18n-extension test(r78095) from all ports.

  • fast/js/i18n-bindings-locale-expected.txt: Removed.
  • fast/js/i18n-bindings-locale.html: Removed.
  • fast/js/script-tests/i18n-bindings-locale.js: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
11:57 AM Changeset in webkit [148976] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebCore

AppleWin build fix.

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::create):
(WebCore):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

11:23 AM Changeset in webkit [148975] by zoltan@webkit.org
  • 17 edits
    2 adds in trunk

[CSS Exclusions] shape-inside overflow should be pushed to the outside of the content box
​https://bugs.webkit.org/show_bug.cgi?id=114526

Reviewed by David Hyatt.

Source/WebCore:

The specification has changed to define shape-outside as the inverse of an exclusion. Overflowing content
should not overlap the shape, and it should be pushed outside the content box. This change affects several
tests, but only one new has been added. In this change I'm not intended to include the behavior change for
shape-inside on CSS Regions, I'm going to fix that in a follow up patch.

Tests: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Modified.

fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified.
fast/exclusions/shape-inside/shape-inside-empty.html: Modified.
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
fast/exclusions/shape-inside/shape-inside-overflow.html: Modified.
fast/exclusions/shape-inside/shape-inside-percentage.html: Modified.
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Modified.

  • rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::clearSegments): Shape-outside's code uses shape-inside codepaths, when that happens we need to provide a
way to reset the m_segments member.
(WebCore::ExclusionShapeInfo::shapeContainingBlockHeight): The containing block's height is stored in m_shapeLogicalHeight, I added a
function to get this value when we need it to calculate the content box's bottom position.
(ExclusionShapeInfo):
(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds):
(WebCore::ExclusionShapeInfo::lineWithinShapeBounds): Add function to test whether a whole line is within a shape or not.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Overflowing content should start under the content box.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Since we use shape-inside codepaths for shape-outside in layoutRunsAndFloatsInRange function
and for shape-outside is not a requirement to check the line's bottom position is within the shape we might end up with some extra segments here.
In this case we should clear segments, since we don't want to apply any horizontal offsets on the overflowing content.

LayoutTests:

Update and add tests for the new behavior.

  • fast/exclusions/resources/rounded-rectangle.js:

(generateString): Modify the function to not generate overflow content.

  • fast/exclusions/shape-inside/shape-inside-bottom-edge-expected.html:
  • fast/exclusions/shape-inside/shape-inside-bottom-edge.html:
  • fast/exclusions/shape-inside/shape-inside-empty-expected.html:
  • fast/exclusions/shape-inside/shape-inside-empty.html:
  • fast/exclusions/shape-inside/shape-inside-overflow-expected.html:
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
  • fast/exclusions/shape-inside/shape-inside-overflow.html:
  • fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
  • fast/exclusions/shape-inside/shape-inside-percentage.html:
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
  • fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html:
  • fast/regions/shape-inside/shape-inside-on-additional-regions.html: This test is not intented to test the overflow behavior from

shape-inside on regions, so I set the shape's height to the container's height.

11:00 AM Changeset in webkit [148974] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: Update public header documentation
​https://bugs.webkit.org/show_bug.cgi?id=114841

Reviewed by Geoffrey Garen.

Added documentation for the newly added object lifetime-related stuff.

  • API/JSManagedValue.h:
  • API/JSVirtualMachine.h:
10:50 AM Changeset in webkit [148973] by robert@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

checkLayout() should error out if no data-expected* attributes were found
​https://bugs.webkit.org/show_bug.cgi?id=114900

Reviewed by Ojan Vafai.

If checkLayout() doesn't find any attributes checking the node's layout then error out
instead of assuming the test has passed. This will ensure data-* attributes containing
typos don't register as a pass.

  • fast/check-layout-error-no-attributes-expected.txt: Added.
  • fast/check-layout-error-no-attributes.html: Added.
  • resources/check-layout.js:

(.):

10:08 AM Changeset in webkit [148972] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Simplify BackForwardListBlackBerry::clear
​https://bugs.webkit.org/show_bug.cgi?id=115029

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.

Simplify the implementation of the clear method. Instead of asking
the WebCore implementation to search each item and delete it, set
the capacity of the list to zero directly, which will do the same
thing but more efficiently.

No change in behavior, no new tests.

  • WebCoreSupport/BackForwardListBlackBerry.cpp:

(WebCore::BackForwardListBlackBerry::clear):

9:20 AM Changeset in webkit [148971] by zeno.albisser@digia.com
  • 2 edits in trunk/Tools

[Qt] Fix test_build_check for Qt on Mac after r148075.
​https://bugs.webkit.org/show_bug.cgi?id=115038

Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_build_check):

run-webkit-tests is supposed to fail, if it is run on a different
platform than specified on the command line.
However, Qt allows exactly this for Qt-platforms to allow comparing
of test results of different baselines.
Before r148075 "chromium-linux-x86" was used for testing.
This patch changes the port_name to gtk when running the test on mac.

9:13 AM Changeset in webkit [148970] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Avoid computing style twice when element has no existing style
​https://bugs.webkit.org/show_bug.cgi?id=115042

Reviewed by Andreas Kling.

We currently compute element style twice if we end up having to reattach, first in recalcStyle and then
again during attach(). We can easily avoid this in common case where the element has no existing style
(usually because it is display:none).

  • dom/Element.cpp:

(WebCore::Element::recalcStyle):

Don't compute the style and diff if there is no existing style. There is nothing to diff against.
Instead just call reattach() directly, we ended up doing that anyway with the existing code.

9:03 AM Changeset in webkit [148969] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Do not access BackForwardListImpl from DRT
​https://bugs.webkit.org/show_bug.cgi?id=115041

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.

Source/WebKit/blackberry:

Export the necessary functionality in our BackForwardList port
client in order for DRT to work.

  • WebCoreSupport/BackForwardListBlackBerry.cpp:

(WebCore::BackForwardListBlackBerry::backListWithLimit):
(WebCore):
(WebCore::BackForwardListBlackBerry::forwardListWithLimit):
(WebCore::BackForwardListBlackBerry::capacity):

  • WebCoreSupport/BackForwardListBlackBerry.h:

(BackForwardListBlackBerry):

Tools:

Use the right class to access the bflist functionality.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::dumpBackForwardListForWebView):

8:53 AM Changeset in webkit [148968] by commit-queue@webkit.org
  • 11 edits in trunk

WebSocket: Return type of send() should be void if hybi-10 protocol is chosen
​https://bugs.webkit.org/show_bug.cgi?id=65850

Patch by Lamarque V. Souza <​Lamarque.Souza@basyskom.com> on 2013-04-23
Reviewed by Alexey Proskuryakov.

Source/WebCore:

WebSocket API draft changed the return type of send() from boolean to void based on Simon
Pieters' post to WHATWG. Firefox 8 and IE 10 already follow the specification, hence it should
make sense for us to do the same when hybi protocol is used.

Original patch by Yuta Kitamura <​yutak@chromium.org>

Tests: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)

http/tests/websocket/tests/hybi/send-after-close-on-unload.html (updated)

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.idl:

LayoutTests:

Update tests and test results because WebSocket.send() now returns undefined when
the hybi WebSocket protocol is used.

  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
  • http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
  • http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
  • http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
8:11 AM Changeset in webkit [148967] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

ScrollbarThemeComposite depends on Page/FrameView/ChromeClient
​https://bugs.webkit.org/show_bug.cgi?id=21361

Reviewed by Andreas Kling.

Remove unused header includes.

  • platform/ScrollbarThemeComposite.cpp:
8:08 AM Changeset in webkit [148966] by Carlos Garcia Campos
  • 16 edits in trunk

[GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=112160

Reviewed by Andreas Kling.

Source/WebCore:

  • platform/network/soup/GOwnPtrSoup.cpp:

(WTF::SoupMessageHeaders): Add freeOwnedGPtr implementation for
SoupMessageHeaders.
(WTF):

  • platform/network/soup/GOwnPtrSoup.h:

(WTF):

  • platform/network/soup/ResourceRequest.h:

(ResourceRequest):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageHeaders): New function
to update the given SoupMessageHeaders with the ResourceRequest
headers.
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): New
function to update the ResourceRequest headers with the given
SoupMessageHeaders.
(WebCore::ResourceRequest::updateSoupMessage): Use
updateSoupMessageHeaders() to update the headers.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage): Use
updateFromSoupMessageHeaders to update the headers.

Source/WebKit2:

It allows to load requests with custom headers, or to update the
headers of a request before being sent to the server in the
WebKitWebPage::send-request callback.

  • UIProcess/API/gtk/WebKitURIRequest.cpp:

(_WebKitURIRequestPrivate): Add SoupMessageHeaders.
(webkit_uri_request_get_http_headers): Return the HTTP headers of
the request as a SoupMessageHeaders if the request is HTTP. A new
SoupMessageHeaders is created on demand using the existing headers
of the request.
(webkitURIRequestGetResourceRequest): Instead of returning a const
reference of the internal ResourceRequest, set a request passed as
a reference and update its HTTP headers using the
SoupMessageHeaders if present.

  • UIProcess/API/gtk/WebKitURIRequest.h:
  • UIProcess/API/gtk/WebKitURIRequestPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Update to the new
webkitURIRequestGetResourceRequest API.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

webkit_uri_request_get_http_headers symbol.

  • UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(testWebPageURI):
(testURIRequestHTTPHeaders):
(serverCallback):
(beforeAll):

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Update to the new
webkitURIRequestGetResourceRequest API.

Tools:

  • MiniBrowser/gtk/GNUmakefile.am: Add missing libsoup flags to

CPPFLAGS.

7:55 AM Changeset in webkit [148965] by akling@apple.com
  • 3 edits
    2 adds in trunk

Clear StyleResolver state before returning from styleForElement().
<​http://webkit.org/b/115035>

Reviewed by Antti Koivisto.

From Blink r148687 by <​inferno@chromium.org>.

Source/WebCore:

A cached element pointer in the resolver state was causing confusion because
in some cases a subsequent call to styleForElement() would use a pointer to
a different object that is at the same memory address as the previous one.

Test: fast/css/reload-non-styled-element-crash.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):

LayoutTests:

  • fast/css/reload-non-styled-element-crash-expected.txt: Added.
  • fast/css/reload-non-styled-element-crash.html: Added.
7:54 AM Changeset in webkit [148964] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

XSSAuditor performance regression due to threaded parser changes.
<​http://webkit.org/b/115037>
<rdar://problem/13716069>

Reviewed by Anders Carlsson.

From Blink r148792 by <​abarth@chromium.org>:

The refactoring we did for the threaded parser introduced a performance
regression in innerHTML because we'd boot up the XSSAuditor for fragment
parsing. This CL returns to our earlier behavior of not booting up the
XSSAuditor when parsing fragments.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::initForFragment):

  • html/parser/XSSAuditor.h:

(XSSAuditor):

7:45 AM Changeset in webkit [148963] by mikhail.pozdnyakov@intel.com
  • 7 edits
    6 moves
    5 adds in trunk

[WK2] Make EFL WKView API shareable between ports
​https://bugs.webkit.org/show_bug.cgi?id=114734

Reviewed by Anders Carlsson.

Source/WebKit2:

EFL-independent part of WKView API (and its implementation) is now
shareable between ports that use Coordinated Graphics and put to
CoordinatedGraphics folders.

  • PlatformEfl.cmake:
  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.cpp.

(WKViewCreate):
(WKViewInitialize):
(WKViewGetSize):
(WKViewSetSize):
(WKViewSetViewClient):
(WKViewIsFocused):
(WKViewSetIsFocused):
(WKViewIsVisible):
(WKViewSetIsVisible):
(WKViewGetContentScaleFactor):
(WKViewSetContentScaleFactor):
(WKViewGetContentPosition):
(WKViewSetContentPosition):
(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewGetPage):
(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):
(WKViewExitFullScreen):

  • UIProcess/API/C/CoordinatedGraphics/WKView.h: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.h.
  • UIProcess/API/C/efl/WKViewEfl.cpp: Added.

(WKViewPaintToCairoSurface):
(WKViewCreateSnapshot):

  • UIProcess/API/C/efl/WKViewEfl.h: Added.
  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/CoordinatedGraphics/WebView.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebView.cpp.

(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setSize):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):
(WebKit::WebView::setUserViewportTranslation):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::setShowsAsSource):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
(WebKit::WebView::initializeClient):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::dipSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

  • UIProcess/CoordinatedGraphics/WebView.h: Renamed from Source/WebKit2/UIProcess/efl/WebView.h.

(WebCore):
(WebKit):
(WebView):
(WebKit::WebView::size):
(WebKit::WebView::isFocused):
(WebKit::WebView::isVisible):
(WebKit::WebView::setContentScaleFactor):
(WebKit::WebView::contentScaleFactor):
(WebKit::WebView::setContentPosition):
(WebKit::WebView::contentPosition):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):

  • UIProcess/CoordinatedGraphics/WebViewClient.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.cpp.

(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):
(WebKit::WebViewClient::webProcessCrashed):
(WebKit::WebViewClient::webProcessDidRelaunch):
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit::WebViewClient::didChangeTooltip):

  • UIProcess/CoordinatedGraphics/WebViewClient.h: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.h.

(WebCore):
(WebKit):

  • UIProcess/efl/WebViewEfl.cpp: Added.

(WebKit):
(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):
(WebKit::WebViewEfl::setEwkView):
(WebKit::WebViewEfl::paintToCairoSurface):
(WebKit::WebViewEfl::createPopupMenuProxy):
(WebKit::WebViewEfl::createContextMenuProxy):
(WebKit::WebViewEfl::setCursor):
(WebKit::WebViewEfl::updateTextInputState):
(WebKit::WebViewEfl::handleDownloadRequest):

  • UIProcess/efl/WebViewEfl.h: Added.

(WebKit):
(WebViewEfl):
(WebKit::WebViewEfl::ewkView):

Tools:

  • TestWebKitAPI/PlatformEfl.cmake:
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

Updated project files accordingly to updated WKView API files
structure.

7:23 AM Changeset in webkit [148962] by akling@apple.com
  • 2 edits in trunk/Tools

Add Benjamin Poulain's @apple.com address to his entry. Unreviewed.

  • Scripts/webkitpy/common/config/contributors.json:
7:21 AM Changeset in webkit [148961] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Speed up ElementData::getAttributeItem(), which is hot.
<​http://webkit.org/b/115031>

Reviewed by Antti Koivisto.

From Blink r148622 by <​cevans@chromium.org>.

The previous version had a couple of issues:

  • Incurred new WTF::Vector::operator[] checks.
  • Had a branch in _every_ loop iteration that checked whether the storage was Vector or array[] backed.

Both these issues are fixed, and CloneNodes.html seems reliably at +2%.
I also believe GetElement.html is maybe +1%.

For WebKit, also applied the same optimization to getAttributeItemIndex().

  • dom/Element.h:

(WebCore::ElementData::attributeBase):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):

5:07 AM Changeset in webkit [148960] by allan.jensen@digia.com
  • 1 edit
    4 adds in trunk/LayoutTests

Baselines for fast/css/image-rendering.html

Unreviewed gardening.

  • fast/css/image-rendering-expected.png: Added.
  • fast/css/image-rendering-expected.txt: Added.
  • platform/gtk-wk1/fast/css/image-rendering-expected.txt: Added.
4:58 AM Changeset in webkit [148959] by charles.wei@torchmobile.com.cn
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Need to send out change event for date/color picker
​https://bugs.webkit.org/show_bug.cgi?id=114942

Reviewed by Carlos Garcia Campos.

We need to instruct the FormControlElements to send out 'change' event
when the user makes the selection and closes the PagePopup for date/color.

  • WebCoreSupport/ColorPickerClient.cpp:

(WebCore::ColorPickerClient::setValueAndClosePopup):

  • WebCoreSupport/DatePickerClient.cpp:

(WebCore::DatePickerClient::setValueAndClosePopup):

3:29 AM Changeset in webkit [148958] by allan.jensen@digia.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove the text expecation again to force the bots to fail and generate png expectations.

Unreviewed ungardening.

  • fast/css/image-rendering-expected.txt: Removed.
3:00 AM Changeset in webkit [148957] by zandobersek@gmail.com
  • 20 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148944.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/table/giantRowspan-expected.txt:
  • platform/gtk/fast/table/giantRowspan2-expected.png:
  • platform/gtk/fast/table/giantRowspan2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/gtk/tables/mozilla/core/bloomberg-expected.png:
  • platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
  • platform/gtk/tables/mozilla/core/row_span-expected.png:
  • platform/gtk/tables/mozilla/core/row_span-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
2:50 AM Changeset in webkit [148956] by Antoine Quint
  • 23 edits
    2 adds in trunk

Initial advance of text runs should be taken into account
​https://bugs.webkit.org/show_bug.cgi?id=114949

Reviewed by Darin Adler.

Source/WebCore:

Keep track of complex text runs' initial advance by adding a new
member to GlyphBuffer and adding the initial advance of any non-first
text run to the advance of the last glyph added for the previous text run.
Additionally, we now correctly handle advance values in the y-axis.

Test: fast/text/complex-initial-advance.html

  • WebCore.exp.in:

Add support for new WebKitSystemInterface API.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):
Take into account the buffer's initial advance in the y-axis to adjust
the point at which to draw the buffers. Additionally, keep track of advances
on the y-axis as well as the x-axis (which we already were doing) as we iterate
through glyphs and adjust the start point.
(WebCore::Font::drawEmphasisMarks):
Adopt change of GlyphBuffer::advanceAt() return type.

  • platform/graphics/GlyphBuffer.h:

Removing the WINCE-specific GlyphBufferAdvance struct since heights are now necessary.
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
New default constructor for GlyphBufferAdvance to support the m_initialAdvance member.
(WebCore::GlyphBuffer::setInitialAdvance):
(WebCore::GlyphBuffer::initialAdvance):
New APIs to get and set the initial advance for a glyph buffer.
(WebCore::GlyphBuffer::advanceAt):
Return a GlyphBufferAdvance rather than a float which used to be only
the glyph buffer's x-axis advance. This is necessary to handle deltas
on the y-axis as well (see WebCore::Font::drawGlyphBuffer).

  • platform/graphics/GlyphBuffer.h:

(GlyphBuffer):
(WebCore::GlyphBuffer::setInitialAdvance):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):
Adopt change of GlyphBuffer::advanceAt() return type.

  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::advance):
When processing the first text run, set that run's initial advance as
the glyph buffer's initial advance.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Represent the initial advance for a text run by adjusting the advance
of the last glyph of the previous text run in the glyph buffer.

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::initialAdvance):
(ComplexTextRun):
New API to read the inital advance of a complex text run.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Obtain the text run's initial advance via the new wkCTRunGetInitialAdvance
WebKitSystemInterface API.

  • platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Add support for the new wkCTRunGetInitialAdvance WebKitSystemInterface API.

  • platform/wx/wxcode/cairo/non-kerned-drawing.cpp:

(WebCore::drawTextWithSpacing):
Adopt change of GlyphBuffer::advanceAt() return type.

  • rendering/svg/SVGTextRunRenderingContext.cpp:

(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.

Source/WebKit/mac:

Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:

LayoutTests:

  • fast/text/complex-initial-advance-expected.html: Added.
  • fast/text/complex-initial-advance.html: Added.
2:42 AM Changeset in webkit [148955] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for two DOM4 constructors tests

that started failing after enabling the subpixel layout due to LayoutUnit overflows.

2:05 AM Changeset in webkit [148954] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] EFL gardening
​https://bugs.webkit.org/show_bug.cgi?id=115013

Remove editing/selection/doubleclick-whitespace-crash.html and
editing/selection/doubleclick-whitespace-img-crash.html from TestExpectations
after r144221.

Unreviewed, EFL gardening.

Patch by Jinwoo Song <​jinwoo7.song@samsung.com> on 2013-04-23

  • platform/efl-wk2/TestExpectations:
2:02 AM Changeset in webkit [148953] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[Texmap] Don't paint to an intermediate surface when the result is going to be clipped out completely.
​https://bugs.webkit.org/show_bug.cgi?id=115015

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Allan Sandfeld Jensen.

Maintain a clipBounds rectangle in TextureMapper, and test it against the bounds of an intermediate
surface before it is painted.
This allows us to opt out completely of painting into the surface if the result is going to be optimized
out by the GPU clipping.

Covered by tests in compositing/overlap-blending.

  • platform/graphics/texmap/TextureMapper.h:

(TextureMapper):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clipBounds):
(WebCore):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

1:58 AM Changeset in webkit [148952] by commit-queue@webkit.org
  • 8 edits in trunk/Source

[Coordinated Graphics] Remove the lockAnimations code path
​https://bugs.webkit.org/show_bug.cgi?id=114899

Source/WebCore:

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.

Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.

No new tests, removing functionality that wasn't tested in the first place.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::commitSceneState):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

(CoordinatedGraphicsScene):

Source/WebKit2:

Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
1:33 AM Changeset in webkit [148951] by allan.jensen@digia.com
  • 3 edits in trunk/Source/WebKit/qt

[Qt][WK1] MemoryCache is not cleaned by default
​https://bugs.webkit.org/show_bug.cgi?id=111443

Reviewed by Jocelyn Turcotte.

Enable deletion of dead resources in the memory cache as long as the MemoryCache is enabled.

This can be disabled or tuned using the dynamic property "_q_deadDecodedDataDeletionInterval".
The default is set to match that of most other ports and WK2 with cache in WebBrowsing mode.

  • Api/qwebsettings.cpp:

(QWebSettings::setObjectCacheCapacities):

  • WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

1:31 AM Changeset in webkit [148950] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Changing failure mark to skip after r148948.

  • platform/qt/TestExpectations:
1:17 AM Changeset in webkit [148949] by allan.jensen@digia.com
  • 11 edits
    3 moves
    7 adds
    3 deletes in trunk

Respect image-rendering setting for determing image-rendering quality
​https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the CSS4 values as they are not ready for implementation yet.
We still parse the -webkit-crisp-edges and SVG compatibility values to
be closer to the the partial support in Gecko and Presto.

Tests: fast/css/image-rendering-canvas.html

fast/css/image-rendering-parsing.html
fast/css/image-rendering.html
fast/css/optimize-contrast-image.html

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):

  • css/CSSValueKeywords.in:
  • css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

  • rendering/style/RenderStyleConstants.h:

Tools:

Remove CSS4 Images option. It is not ready for implementation.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Moved the two tests of image-rendering out of CSS3 since it was removed from the final recommendation.
Added tests of the supported values, and upgraded one test to a reference test so that it now tests
that -webkit-optimize-contrast gets converted to and treated as -webkit-crisp-edges.

Baselines for fast/css/image-rendering.html will be uploaded later when the bots have generated them.

  • css3/images/optimize-contrast-image-expected.png: Removed.
  • css3/images/optimize-contrast-image-expected.txt: Removed.
  • fast/css/image-rendering-canvas-expected.png: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.png.
  • fast/css/image-rendering-canvas-expected.txt: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.txt.
  • fast/css/image-rendering-canvas.html: Renamed from LayoutTests/css3/images/optimize-contrast-canvas.html.
  • fast/css/image-rendering-expected.txt: Added.
  • fast/css/image-rendering-parsing-expected.txt: Added.
  • fast/css/image-rendering-parsing.html: Renamed from LayoutTests/fast/css/image-set-parsing.html.
  • fast/css/image-rendering.html: Added.
  • fast/css/optimize-contrast-image-expected.html: Added.
  • fast/css/optimize-contrast-image.html: Renamed from LayoutTests/css3/images/optimize-contrast-image.html.
  • fast/css/script-tests/image-rendering-parsing.js: Added.

(testImageRendering):

1:07 AM Changeset in webkit [148948] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations:
12:48 AM Changeset in webkit [148947] by rniwa@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r148923.
​http://trac.webkit.org/changeset/148923
​https://bugs.webkit.org/show_bug.cgi?id=115020

The patch causes multiple failures in CSS, canvas tests
(Requested by zdobersek on #webkit).

Source/WebCore:

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

LayoutTests:

  • fast/canvas/script-tests/shadow-image.js: Removed.
  • fast/canvas/shadow-image-expected.txt: Removed.
  • fast/canvas/shadow-image.html: Removed.
12:01 AM Changeset in webkit [148946] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several test cases that are no longer crashing after r148945.

  • platform/efl/TestExpectations:

Apr 22, 2013:

11:51 PM Changeset in webkit [148945] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Assertion Failures in Coordinated Graphics after r148433
​https://bugs.webkit.org/show_bug.cgi?id=114731

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-22
Reviewed by Gyuyoung Kim.

The assert is incorrect. In some cases in coordinated graphics we may have a backing store
and drawsContent would be set to false.

No new tests.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):

11:36 PM Changeset in webkit [148944] by commit-queue@webkit.org
  • 29 edits
    2 adds in trunk

table's text aligned on top instead of center because of rowspan
​https://bugs.webkit.org/show_bug.cgi?id=18092

Patch by Suchit Agrawal <​a.suchit@samsung.com> on 2013-04-22
Reviewed by Beth Dakin.

Source/WebCore:

Last row in the rowspan is not getting the height of rowspan cell because there is not
enough rows present below rowspan cell and we are strictly applying height of rowspan
to the row which should lay last in the rowspan based of rowspan value.

When row contains rowspan cell and it is last row of the table then
rowspan height is adding to last row of the table.

Test: fast/table/Rowspan-value-more-than-number-of-rows-present.html

It calculates logical height of the rows in the table.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Added test cases, based on rowspan issue.

  • fast/table/Rowspan-value-more-than-number-of-rows-present-expected.txt: Added.
  • fast/table/Rowspan-value-more-than-number-of-rows-present.html: Added.

Test cases need to do rebaseline in efl, gtk and mac platforms.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:

Test case results are updated in qt platform.

  • platform/qt/fast/table/giantRowspan-expected.png:
  • platform/qt/fast/table/giantRowspan-expected.txt:
  • platform/qt/fast/table/giantRowspan2-expected.png:
  • platform/qt/fast/table/giantRowspan2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133756-1-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/qt/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.png:
  • platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/qt/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/qt/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt/tables/mozilla/core/bloomberg-expected.txt:
  • platform/qt/tables/mozilla/core/row_span-expected.png:
  • platform/qt/tables/mozilla/core/row_span-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • tables/mozilla/core/bloomberg-expected.txt:
  • tables/mozilla/core/row_span-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
9:52 PM Changeset in webkit [148943] by mihnea@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Regions] Region's float parent doesn't size according to region size but to content node size
​https://bugs.webkit.org/show_bug.cgi?id=111332

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/regions/intrinsic-sized-regions.html

fast/regions/region-with-float-parent.html

The patch ensures that the computation of region's preferred widths
takes into account the region width/min-width if these values are specified.
Also implemented the computation of intrinsic widths for a region,
based on the min/max preferred widths of the associated flow thread.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::computeIntrinsicLogicalWidths):
(WebCore):
(WebCore::RenderRegion::computePreferredLogicalWidths):

  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

Added tests for intrinsic and preferred width computation for region.

  • fast/regions/intrinsic-sized-regions-expected.txt: Added.
  • fast/regions/intrinsic-sized-regions.html: Added.
  • fast/regions/region-with-float-parent-expected.txt: Added.
  • fast/regions/region-with-float-parent.html: Added.
9:47 PM Changeset in webkit [148942] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix a typo in MacroAssemblerARMv7.h.
​https://bugs.webkit.org/show_bug.cgi?id=115011.

Reviewed by Geoffrey Garen.

  • assembler/ARMAssembler.h: Fix a comment.
  • assembler/ARMv7Assembler.h: Added some comments.
  • assembler/MacroAssemblerARMv7.h:
    • ARMAssembler::PL should be ARMv7Assembler::ConditionPL.
8:32 PM Changeset in webkit [148941] by Patrick Gansterer
  • 3 edits in trunk/Source/WTF

[CMake] Move NullPtr.cpp from PlatformWinCE.cmake to CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=114557

Reviewed by Laszlo Gombos.

This file is not specific to Windwos CE. Move it the the general
CMakeLists.txt so other ports can use it to. It does not affect
ports which do not need it, since it contains a preprocessor guard.

  • wtf/CMakeLists.txt:
  • wtf/PlatformWinCE.cmake:
7:33 PM Changeset in webkit [148940] by jberlin@webkit.org
  • 4 edits in trunk/Source/WebKit

Speculative Windows build fix.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
7:03 PM Changeset in webkit [148939] by jberlin@webkit.org
  • 7 edits in trunk/LayoutTests

Remove references to the inspector/profiler/memory-instrumentation tests removed in r148921

Rubber-stamped by Benjamin Poulain.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
6:10 PM Changeset in webkit [148938] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Need WebKit SPI to detect whether a page contains form controls
<rdar://problem/13686661>
​https://bugs.webkit.org/show_bug.cgi?id=115003

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFrameContainsAnyFormControls):

  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

  • WebProcess/WebPage/WebFrame.h:
5:43 PM Changeset in webkit [148937] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] REGRESSION (r142806): "Just Leaking" Console errors on launch
​https://bugs.webkit.org/show_bug.cgi?id=115002
<rdar://problem/13254212>

Reviewed by Sam Weinig.

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm: (WebKit::BootstrapMain): Added an autorelease pool for code that uses Objective-C.
5:16 PM Changeset in webkit [148936] by fpizlo@apple.com
  • 7 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Create an equivalent of Structure::get() that can work from a compilation thread
​https://bugs.webkit.org/show_bug.cgi?id=114987

Reviewed by Geoffrey Garen.

This completes the work started by r148570. That patch made it possible to do
Structure::get() without modifying Structure. This patch takes this further, and
makes this thread-safe (for non-uncacheable-dictionaries) via
Structure::getConcurrently(). This method not only doesn't modify Structure, but
also ensures that any concurrent attempts to add to, remove from, or steal the
table from that structure doesn't mess up the result of the call. The call may
return invalidOffset even if a property is *just* about to be added, but it will
never do the reverse: if it returns a property then you can be sure that the
structure really does have that property and always will have it.

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • runtime/PropertyMapHashTable.h:

(PropertyTable):
(JSC::PropertyTable::findConcurrently):
(JSC):
(JSC::PropertyTable::add):
(JSC::PropertyTable::remove):
(JSC::PropertyTable::reinsert):
(JSC::PropertyTable::rehash):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):

  • runtime/Structure.cpp:

(JSC::Structure::findStructuresAndMapForMaterialization):
(JSC::Structure::getConcurrently):

  • runtime/Structure.h:

(Structure):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

5:16 PM Changeset in webkit [148935] by Martin Robinson
  • 3 edits in trunk/Source/WebKit/gtk

Try to fix the build after enabling gobject-introspection

  • GNUmakefile.am: Disable --warn-error for WebKit1 until we can work out all gir failures.
  • webkit/webkitwebplugin.cpp: Skip this API for introspection because it return a GSList

of pointer (non-boxed) types.

5:10 PM Changeset in webkit [148934] by mrowe@apple.com
  • 2 edits in trunk/Tools

<​http://webkit.org/b/114989> Add a user default to allow use of the Safari binary rather than SafariForWebKitDevelopment

Reviewed by Anders Carlsson.

  • Scripts/webkitdirs.pm:

(skipSafariExecutableEntitlementChecks): Look for the SkipSafariExecutableEntitlementChecks default in the
/Library/Preferences/org.webkit.BuildConfiguration preference domain.
(safariPathFromSafariBundle): If the user default is set asking us to skip the entitlement checks, return
the path to the regular Safari binary.

4:50 PM Changeset in webkit [148933] by jberlin@webkit.org
  • 4 edits in trunk/Source/WebCore

Debug build fix.

Rubber-stamped by Ryosuke Niwa.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(WebCore):
(WebCore::InspectorMemoryAgent::create):
(InspectorMemoryAgent):

4:42 PM Changeset in webkit [148932] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Address review feedback I forgot to address in r148929
​https://bugs.webkit.org/show_bug.cgi?id=114480

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): Rework the "what" comment into a more useful "why" comment.

4:40 PM Changeset in webkit [148931] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

Unreviewed Efl build fix after r148921

  • TestWebKitAPI/CMakeLists.txt:
4:34 PM Changeset in webkit [148930] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Second Mac debug build fix after r148921

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-22

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

4:28 PM Changeset in webkit [148929] by beidson@apple.com
  • 5 edits
    14 adds in trunk

REGRESSION (r141136): Wiki "Random article" function very broken.
<rdar://problem/13229985> and ​https://bugs.webkit.org/show_bug.cgi?id=114480

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/navigation/redirect-to-random-url-versus-memory-cache.html

If we are performing a conditional GET to revalidate a resource and there's a redirect,
check to see if the redirect is to a different URL than the final URL of the resource.

If the URLs differ then we should make the redirect-request unconditional and do a normal load.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::makeUnconditional):

  • platform/network/ResourceRequestBase.h:

(ResourceRequestBase):

LayoutTests:

  • http/tests/navigation/redirect-to-random-url-versus-memory-cache-expected.txt: Added.
  • http/tests/navigation/redirect-to-random-url-versus-memory-cache.html: Added.
  • http/tests/navigation/resources/randomredirects/0.php: Added.
  • http/tests/navigation/resources/randomredirects/1.php: Added.
  • http/tests/navigation/resources/randomredirects/2.php: Added.
  • http/tests/navigation/resources/randomredirects/3.php: Added.
  • http/tests/navigation/resources/randomredirects/4.php: Added.
  • http/tests/navigation/resources/randomredirects/5.php: Added.
  • http/tests/navigation/resources/randomredirects/6.php: Added.
  • http/tests/navigation/resources/randomredirects/7.php: Added.
  • http/tests/navigation/resources/randomredirects/8.php: Added.
  • http/tests/navigation/resources/randomredirects/9.php: Added.
  • http/tests/navigation/resources/randomredirects/randomredirect.php: Added.
4:27 PM Changeset in webkit [148928] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Another Windows build fix after r148921

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-22

  • AccessibleBase.cpp: Add missing header include.
4:26 PM Changeset in webkit [148927] by Lucas Forschler
  • 2 edits in branches/safari-536.30-branch/LayoutTests

Skip svg/custom/mask-invalidation.svg on Mac
<rdar://problem/13711076>

Patch by David Farler <​dfarler@apple.com> on 2013-04-22

  • platform/mac/Skipped:

Skip svg/custom/mask-invalidation.svg

4:25 PM Changeset in webkit [148926] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add branchAdd32 missing implementation in SH4 base JIT.
This should fix SH4 build, broken since r148893.
​https://bugs.webkit.org/show_bug.cgi?id=114993.

Patch by Julien Brianceau <​jbrianceau@nds.com> on 2013-04-22
Reviewed by Oliver Hunt.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):
(MacroAssemblerSH4):

4:12 PM Changeset in webkit [148925] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac debug build fix after r148921

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-22

  • page/animation/CompositeAnimation.cpp:
4:08 PM Changeset in webkit [148924] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Windows build fix after r148921

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2013-04-22

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
4:06 PM Changeset in webkit [148923] by Martin Robinson
  • 3 edits
    3 adds in trunk

[Cairo] Canvas-shadow behavior is not being as expected
​https://bugs.webkit.org/show_bug.cgi?id=108897

Patch by Rashmi Shyamasundar <​rashmi.s2@samsung.com> on 2013-04-22
Reviewed by Martin Robinson.

Source/WebCore:

Use the pattern-extend-mode "CAIRO_EXTEND_NONE" instead of "CAIRO_EXTEND_PAD" in
PlatformContextCairo::drawSurfaceToContext().

In the function PlatformContextCairo::drawSurfaceToContext(), a pattern is being
created from the source surface and this pattern is drawn onto the destination
context. There is no gradient involved. Hence the extend mode for filling the
pattern should be "CAIRO_EXTEND_NONE". If we use the extend mode
"CAIRO_EXTEND_PAD" in PlatformContextCairo::drawSurfaceToContext(), the original
image area is also filled with the shadow color which is not the expected behavior.

Test: fast/canvas/canvas-image-shadow.html

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

LayoutTests:

Test to verify the shadow of an image drawn on canvas.
This test uses an image whose size is smaller than,
the size of the rectangle which should be filled with the image.

  • fast/canvas/canvas-image-shadow-expected.txt: Added.
  • fast/canvas/canvas-image-shadow.html: Added.
  • fast/canvas/green.png: Added.
  • fast/canvas/script-tests/canvas-image-shadow.js: Added.

(draw):

3:56 PM Changeset in webkit [148922] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

Web process should decide when to continue main resource loads
​https://bugs.webkit.org/show_bug.cgi?id=114995

Reviewed by Sam Weinig.

Main resource loads can be converted to downloads, so we need the ability to let the web process decide when
to continue loading after a response has been received.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):
For non-main resources, just call continueDidReceiveResponse directly; there's no need to ping-pong to the web process in that case.

(WebKit::NetworkResourceLoader::continueDidReceiveResponse):
Just call ResourceHandle::continueDidReceiveResponse.

  • NetworkProcess/NetworkResourceLoader.messages.in:

Add ContinueDidReceiveResponse message.

  • NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):
Initialize m_isLoadingMainResource.

  • NetworkProcess/SchedulableLoader.h:

(WebKit::SchedulableLoader::isLoadingMainResource):
Add getter.

(SchedulableLoader):
Move m_shouldClearReferrerOnHTTPSToHTTPRedirect next to the rest of the booleans.

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(NetworkResourceLoadParameters):
Add isMainResource flag.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
Pass the cached resource to scheduleLoad.

(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
Pass null to scheduleLoad.

(WebKit::WebResourceLoadScheduler::scheduleLoad):
Initialize isMainResource.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
If this is a main resource load, send back a ContinueDidReceiveResponse message.

3:52 PM Changeset in webkit [148921] by benjamin@webkit.org
  • 395 edits
    30 deletes in trunk

Remove the memory instrumentation code
​https://bugs.webkit.org/show_bug.cgi?id=114931

Reviewed by Andreas Kling.

.:

  • Source/autotools/symbols.filter:

Source/JavaScriptCore:

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

Source/WebCore:

The Memory Instrumentation code is unfinished and has already
become out of sync the objects it is supposed to represent.

The current approach does not seem maintainable, it is better to
remove it before someone gets hurt.

By removing the code, the binary become 1240976 bytes smaller.
Yep, almost 1 Mb, bringing WebCore to the size it has 5 months ago :)

  • MostWebCoreFiles: remove the support for memory instrumentation.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

Source/WTF:

On Mac x86_64, the code removal cause the binary to be
9224 bytes smaller.

  • GNUmakefile.list.am:
  • WTF.pro:
  • WTF.vcproj/WTF.vcproj:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Forward.h:
  • wtf/ListHashSet.h:

(ListHashSet):
(ListHashSetNodeAllocator):
(WTF::ListHashSetNodeAllocator::pool):
(WTF::ListHashSetNodeAllocator::pastPool):

  • wtf/MemoryInstrumentation.cpp: Removed.
  • wtf/MemoryInstrumentation.h: Removed.
  • wtf/MemoryInstrumentationArrayBufferView.h: Removed.
  • wtf/MemoryInstrumentationHashCountedSet.h: Removed.
  • wtf/MemoryInstrumentationHashMap.h: Removed.
  • wtf/MemoryInstrumentationHashSet.h: Removed.
  • wtf/MemoryInstrumentationListHashSet.h: Removed.
  • wtf/MemoryInstrumentationSequence.h: Removed.
  • wtf/MemoryInstrumentationString.h: Removed.
  • wtf/MemoryInstrumentationVector.h: Removed.
  • wtf/MemoryObjectInfo.h: Removed.
  • wtf/text/AtomicString.h:
  • wtf/text/StringImpl.h:

(WTF::StringImpl::isASCIILiteral):

  • wtf/text/WTFString.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Removed.

LayoutTests:

  • inspector/profiler/memory-instrumentation-cached-images-expected.txt: Removed.
  • inspector/profiler/memory-instrumentation-cached-images.html: Removed.
  • inspector/profiler/memory-instrumentation-canvas-expected.txt: Removed.
  • inspector/profiler/memory-instrumentation-canvas.html: Removed.
  • inspector/profiler/memory-instrumentation-external-array-expected.txt: Removed.
  • inspector/profiler/memory-instrumentation-external-array.html: Removed.
  • inspector/profiler/memory-instrumentation-external-string-expected.txt: Removed.
  • inspector/profiler/memory-instrumentation-external-string.html: Removed.
  • inspector/profiler/memory-instrumentation-test.js: Removed.
3:39 PM Changeset in webkit [148920] by betravis@adobe.com
  • 3 edits
    2 adds in trunk

Do not reuse ExclusionShapeInsideInfo in a recursive region layout
​https://bugs.webkit.org/show_bug.cgi?id=114467

Reviewed by David Hyatt.

Source/WebCore:

Elements that respect shape-inside that have inline children should not reuse an
ExclusionShapeInsideInfo for their children's layout. This patch adds the test
for regions. See the details for non-region layout in bug 104582.
​https://bugs.webkit.org/show_bug.cgi?id=104582

Test: fast/regions/shape-inside/shape-inside-recursive-layout.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Do not look up a region's
ExclusionShapeInsideInfo if a block is already respecting shape-inside.

LayoutTests:

Test that for various types of inline containers do not reuse
ExclusionShapeInsideInfo when laying out their children.

  • fast/regions/shape-inside/shape-inside-recursive-layout-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-recursive-layout.html: Added.
3:36 PM Changeset in webkit [148919] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Plugin Snapshotting: Don't consume insane amounts of time detecting the primary plugin
​https://bugs.webkit.org/show_bug.cgi?id=114994
<rdar://problem/13696269>

Reviewed by Anders Carlsson.

On some pages, we currently waste a lot of time on every subframe load
and every addPluginView doing primary plugin detection. This patch
attempts to address this via a few minor changes:

  • Only allow detection after the main frame's didFinishLoad comes, instead of the first subframe.
  • Only explicitly detect on the main frame's didFinishLoad (not subframes).
  • Coalesce calls to determinePrimarySnapshottedPlugIn from both addPluginView

(in case JS is adding lots of plugins in a loop) and didFinishLoad.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addPluginView): Coalesce calls to determinePrimarySnapshottedPlugIn.
(WebKit::WebPage::didFinishLoad):
Coalesce calls to determinePrimarySnapshottedPlugIn.
Bail on subframe loads, we're only interested in the main frame being complete.
(WebKit::WebPage::determinePrimarySnapshottedPlugInTimerFired):
Call determinePrimarySnapshottedPlugIn.

  • WebProcess/WebPage/WebPage.h:

Add m_determinePrimarySnapshottedPlugInTimer and determinePrimarySnapshottedPlugInTimerFired

3:29 PM Changeset in webkit [148918] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Fix r148773.

  • platform/mac-lion/TestExpectations:
3:21 PM Changeset in webkit [148917] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profiles.

Reviewed by Anders Carlsson.

Unbreak Lion, which doesn't provide detailed control over IPC.

  • WebProcess/com.apple.WebProcess.sb.in:
3:15 PM Changeset in webkit [148916] by Martin Robinson
  • 9 edits in trunk

[GTK] Enable introspection always for developer builds
​https://bugs.webkit.org/show_bug.cgi?id=114983

Reviewed by Gustavo Noronha Silva.

.:

  • Source/autotools/SetupAutoconfHeader.m4: No longer expose the ENABLE_INTROSPECTION

autoconf header variable. It isn't used and it means that when introspection is enabled
or disabled, there is an unnecessary full rebuild.

Source/WebKit/gtk:

  • GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate

warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet to avoid printing lots of output to
non-verbose builds.

Source/WebKit2:

  • GNUmakefile.am: Make warnings during gir scanning cause the build to fail. Eliminate

warnings about deprecated API that the g-ir-scanner uses when generating
the scanner program. Use --quiet.

Tools:

  • Scripts/webkitdirs.pm:

(runAutogenForAutotoolsProjectIfNecessary): Always enable introspection
when using build-webkit.

  • gtk/jhbuildrc: Enable documentation for all jhbuild modules and explicitly

choose the memory gsettings backend while in the jhbuild. This eliminates
warnings from programs that fall back to the memory backend.

3:07 PM Changeset in webkit [148915] by betravis@adobe.com
  • 3 edits in trunk/LayoutTests

[css exclusions] shape-inside-recursive-layout.html should not yet test display: inline-grid
​https://bugs.webkit.org/show_bug.cgi?id=114986

Reviewed by Dirk Schulze.

Because the inline-grid value is not yet supported, the test case is falling back to
display: block. This causes an incorrect layout, as block and inline content react to
shape-inside differently.

  • fast/exclusions/shape-inside/shape-inside-recursive-layout-expected.html:
  • fast/exclusions/shape-inside/shape-inside-recursive-layout.html:
2:54 PM Changeset in webkit [148914] by Martin Robinson
  • 6 edits in trunk/Source

[GTK] Fix remaining introspection warnings
​https://bugs.webkit.org/show_bug.cgi?id=114980

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

  • bindings/gobject/WebKitDOMCustom.h: Add scope and transfer annotations and flesh

out gtkdoc for completeness.

  • bindings/gobject/WebKitDOMEventTarget.h:

(_WebKitDOMEventTargetIface): Ditto and also align virtual method names with those used
for the concrete ones.

Source/WebKit/gtk:

  • webkit/webkitspellchecker.h:

(_WebKitSpellCheckerInterface): Align the name of the check_spelling_of_string virtual
method with the concrete method to avoid a g-ir-scanner warning.

  • webkit/webkitversion.h.in: Skip WEBKITGTK_API_VERSION for introspection because it

doesn't follow the appropriate namespace name.

2:45 PM Changeset in webkit [148913] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Make it easier to extend NetworkResourceLoadParameters
​https://bugs.webkit.org/show_bug.cgi?id=114992

Reviewed by Sam Weinig.

Turn NetworkResourceLoadParameters into a struct which matches all our other parameter classes in WebKit2. Fill in the struct manually
instead of having a constructor with 9 parameters.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):
(WebKit::NetworkConnectionToWebProcess::performSynchronousLoad):

  • NetworkProcess/SchedulableLoader.cpp:

(WebKit::SchedulableLoader::SchedulableLoader):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters):
(WebKit::NetworkResourceLoadParameters::encode):
(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(NetworkResourceLoadParameters):

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

2:19 PM Changeset in webkit [148912] by timothy_horton@apple.com
  • 11 edits
    2 adds in trunk/Source

PDFPlugin: Support unlocking encrypted PDFs
​https://bugs.webkit.org/show_bug.cgi?id=114938
<rdar://problem/12872888>

Reviewed by Alexey Proskuryakov and Oliver Hunt.

If we try to load an encrypted PDF, we need to provide a sane mechanism
through which the user can provide the password. Add a slightly-below-center
password field to match PDFKit's normal behavior.

  • WebKit2.xcodeproj/project.pbxproj: Add PDFPluginPasswordField.{h,mm}
  • WebProcess/Plugins/PDF/PDFLayerControllerDetails.h: Add attemptToUnlockWithPassword:
  • WebProcess/Plugins/PDF/PDFPlugin.h:

Add createPasswordEntryForm, attemptToUnlockPDF, m_passwordField.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(annotationStyle): Make #annotationContainer a flexbox that centers its contents.
This won't affect the normal absolutely-positioned form fields, but the inline
password field will be centered vertically and horizontally.

(WebKit::PDFPlugin::pdfDocumentDidLoad):
If the document is locked when loaded, create a password field.

(WebKit::PDFPlugin::createPasswordEntryForm):
Create a PDFPluginPasswordField and attach it to the document.

(WebKit::PDFPlugin::attemptToUnlockPDF):
Try to unlock the PDF with the given password. If this succeeds, remove
the password field and relayout the scroll view.

(WebKit::PDFPlugin::calculateSizes):
Make the document 0x0 if it is locked, preventing scrolling.

(WebKit::PDFPlugin::handleMouseEvent):
Don't pass mouse events to PDFLayerController while it is locked,
as it has no useful events to provide, and will try to present a
dialog asking for the password if we let a click through.

  • WebProcess/Plugins/PDF/PDFPluginAnnotation.h:

(WebKit::PDFPluginAnnotation::eventListener): Added.

  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::handleEvent):
Move event-handling code here from PDFPluginAnnotationEventListener::handleEvent
so that subclasses can override this instead of having to have their own
event listeners (this is also why we now expose eventListener()).

(WebKit::PDFPluginAnnotation::PDFPluginAnnotationEventListener::handleEvent):
Forward the event to our owning PDFPluginAnnotation.

  • WebProcess/Plugins/PDF/PDFPluginPasswordField.h: Added.

(WebKit::PDFPluginPasswordField::PDFPluginPasswordField):

  • WebProcess/Plugins/PDF/PDFPluginPasswordField.mm: Added.

(WebKit::PDFPluginPasswordField::create):
(WebKit::PDFPluginPasswordField::~PDFPluginPasswordField):
Unregister for keyup.

(WebKit::PDFPluginPasswordField::createAnnotationElement):
Register for keyup, and set our element's class to "password".

(WebKit::PDFPluginPasswordField::updateGeometry):
Added. Override updateGeometry and do nothing, as the password field
has a geometry defined by CSS instead of by the PDF content.

(WebKit::PDFPluginPasswordField::handleEvent):
If the enter/return key is pressed, attempt to unlock the PDF. Also,
we do not call either of our superclass' implementations of handleEvent,
because blurring the password field should not destroy it, and tabbing
between fields has no relevance when there can only be one field.

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:

(WebKit::PDFPluginTextAnnotation::PDFPluginTextAnnotationEventListener):
Removed. We now share our superclass' event listener.

(WebKit::PDFPluginTextAnnotation::textAnnotation): Const.

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::~PDFPluginTextAnnotation):
PDFPluginTextAnnotation no longer has its own event listener,
so there's nothing left to clear here. Just make sure to unregister
our event from PDFPluginAnnotation's shared event listener!

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
Ensure that we can create a PDFPluginTextAnnotation with a null annotation.

(WebKit::PDFPluginTextAnnotation::commit): Use value().
(WebKit::PDFPluginTextAnnotation::value):
Factor retrieving the value of the form control out of commit().

(WebKit::PDFPluginTextAnnotation::handleEvent):
Call up to PDFPluginAnnotation's handler so that defocus destroys the annotation.

Export HTMLNames::typeAttr.

  • WebCore.exp.in:
1:46 PM Changeset in webkit [148911] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Slow/beachballing when using the find bar on a page with plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=114990
<rdar://problem/12832313>

Reviewed by Tim Horton.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::notifyWidget):
Call shouldCreateTransientPaintingSnapshot().

(WebKit::PluginView::shouldCreateTransientPaintingSnapshot):
Don't create a painting snapshot if we're asked to paint the find indicator.

  • WebProcess/Plugins/PluginView.h:

Add new member function.

1:40 PM Changeset in webkit [148910] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profiles.

Reviewed by Sam Weinig.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
1:39 PM Changeset in webkit [148909] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update about:config lists
​https://bugs.webkit.org/show_bug.cgi?id=114967

Patch by Eli Fidler <​efidler@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/AboutDataHaveFeatures.in:
  • WebCoreSupport/AboutDataUseFeatures.in:
1:39 PM Changeset in webkit [148908] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Use-after-free in CompositeEditCommand::cloneParagraphUnderNewElement
​https://bugs.webkit.org/show_bug.cgi?id=114911

Reviewed by Oliver Hunt.

Back ported ​https://src.chromium.org/viewvc/blink?revision=148680&view=revision.

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

1:29 PM Changeset in webkit [148907] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

[Mac] "automatic" track selection should only select a track that matches user language
​https://bugs.webkit.org/show_bug.cgi?id=114976

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-automatic-subtitles.html

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): When in "automatic" mode, only

consider text tracks that match the user's preferred language when the primary audio track
does not.

LayoutTests:

  • media/track/track-automatic-subtitles-expected.txt: Added.
  • media/track/track-automatic-subtitles.html: Added.
  • platform/mac/TestExpectations: Skip track-user-preferences.html, the logic is no longer

correct for the Mac port.

1:02 PM Changeset in webkit [148906] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Cancelling load may cause deadlock in -[AVPlayerItem release]
​https://bugs.webkit.org/show_bug.cgi?id=114962

Reviewed by Eric Carlson.

Work around a bug in AVAssetResourceLoader by using a generic, non-main dispatch queue
to recieve AVAssetResourceLoaderDelegate callbacks, and then marshalling those
callbacks to the main thread asynchronously.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::globalLoaderDelegateQueue): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Use the new global queue.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):

Marshall the request to the main queue, and return YES (wait) immediately.

1:01 PM Changeset in webkit [148905] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't kill our XPC services in response to memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=114985
<rdar://problem/13229217>

Reviewed by Mark Rowe.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):
Call xpc_transaction_begin() so we'll never be killed by the kernel when there's memory pressure;
we prefer to manage our own lifetime thank you very much!

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::platformInitialize):
Remove call to disable sudden termination.

12:54 PM Changeset in webkit [148904] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13681842> [Mac] Tweak WebProcess sandbox profile to use
system-graphics function when available.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:
12:52 PM Changeset in webkit [148903] by zandobersek@gmail.com
  • 13 edits in trunk

[GTK] Set up libPlatform.la
​https://bugs.webkit.org/show_bug.cgi?id=114168

Reviewed by Martin Robinson.

.:

  • GNUmakefile.am: Define the platform_cppflags and platform_sources variables.

Source/Platform:

  • GNUmakefile.am: Set up the libPlatform.la static library to build the source files listed in platform_sources.

As with the libPlatformGtk.la library, only the Source/WebCore/platform and its subdirectories are allowed to be
searched for headers to include, providing a convenient way to detect any platform violations. These directories
are listed in the platform_webcore_cppflags variable.

Source/WebCore:

No new tests - no new functionality.

  • GNUmakefile.am: Also add the LevelDB-specific cppflags to the platform_cppflags if required as the LevelDB

code is now built into the new libPlatform.la library.

  • GNUmakefile.list.am: Build a small set of non-GTK-specific platform source files that are already free of

platform violations into the new libPlatform.la library.

Source/WebKit/gtk:

  • GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library.

Source/WebKit2:

  • GNUmakefile.am: Add the new libPlatform.la library to the libwebkitgtk library. Link the WebKitPluginProcess

executable against libPlatform.la as well.

Tools:

  • GNUmakefile.am: Link the DumpRenderTree executable against both libPlatform.la and libPlatformGtk.la libraries.
12:47 PM Changeset in webkit [148902] by weinig@apple.com
  • 6 edits
    7 adds in trunk/Source/WebKit2

Hard code plug-in sandbox profile lookup directories and move
the profiles to WebKit2.

Reviewed by Anders Carlsson.

  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:

(WebKit::PluginProcessMainDelegate::getExtraInitializationData):

  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Stop passing the sandbox-profile-directory-path to the plug-in process.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::loadSandboxProfileForDirectory):
(WebKit::loadSandboxProfile):
(WebKit::PluginProcess::initializeSandbox):
Hard code the plug-in sandbox profile lookup to only look in the WebKit2 bundle
and /System/Library/Sandbox/Profiles/.

  • Resources/PlugInSandboxProfiles: Added.

Add profiles.

  • WebKit2.xcodeproj/project.pbxproj:

Copy the profiles to the bundle.

12:37 PM Changeset in webkit [148901] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebKit2

Refactor creation of the full screen window into an (overridable) method.
​https://bugs.webkit.org/show_bug.cgi?id=110369

Reviewed by Eric Carlson.

Add a new WKView method -(NSWindow)createFullScreenWindow which can be overridden
by subclasses to provide custom full screen windows to the WKFullScreenWindowController.

  • UIProcess/API/mac/WKView.mm:

(-[WKView fullScreenWindowController]):
(-[WKView createFullScreenWindow]):

  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:]):

12:13 PM Changeset in webkit [148900] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

StringImpl.h should compile with -Wshorten-64-to-32
<​http://webkit.org/b/114970>

Reviewed by Darin Adler.

Fixes the following warnings with -Wshorten-64-to-32:

StringImpl.h:317:25: error: implicit conversion loses integer precision: 'uintptr_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

unsigned hash = reinterpret_cast<uintptr_t>(this);


  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl): Add static_cast<uint32_t>() to
formalize taking the lower 32-bits of the pointer value on
64-bit architectures.

11:40 AM Changeset in webkit [148899] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix broken 32-bit build to green the bots.
​https://bugs.webkit.org/show_bug.cgi?id=114968.

Unreviewed.

Basically, I moved a JIT::emit_op_loop_hint() and JIT::emitSlow_op_loop_hint()
into common code where they belong, instead of the 64-bit specific section.

Also fixed some SH4 assertions failures which were also caused by
​https://bugs.webkit.org/show_bug.cgi?id=114963. Thanks to Julien Brianceau
for pointing this out.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):

  • jit/JITOpcodes.cpp:

(JSC):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):

11:23 AM Changeset in webkit [148898] by aestes@apple.com
  • 5 edits in trunk

Range.getClientRects() should not include rects for partially selected elements
​https://bugs.webkit.org/show_bug.cgi?id=76839

Reviewed by Sam Weinig.

Source/WebCore:

CSSOM says that Range.getClientRects() should include the border boxes
of each element selected by the range. However, we were also
incorrectly including border boxes for partially selected elements.
For instance, consider the following selection:

<div>line one<br>line two</div>
-------------

The <div> is two lines tall, but only the first line is selected.
Despite this, we'd include the <div>'s border box since its start tag
was included in the selection.

Fix this by excluding partially selected elements. This is accomplished
by skipping over elements that come after the start boundary point of
the range but are ancestors of the end boundary point.

Added test cases to LayoutTests/fast/dom/Range/getClientRects.html.

  • dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

LayoutTests:

  • fast/dom/Range/getClientRects-expected.txt: Updated expected result.
  • fast/dom/Range/getClientRects.html: Added new test cases.
11:21 AM Changeset in webkit [148897] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2013-04-22 Oliver Hunt <​oliver@apple.com>

Perform null check before trying to use the result of readline()

RS=Gavin

  • jsc.cpp: (runInteractive):
11:19 AM Changeset in webkit [148896] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2013-04-22 Oliver Hunt <​oliver@apple.com>

Fix assertions to account for new Vector layout

RS=Gavin

  • llint/LLIntData.cpp: (JSC::LLInt::Data::performAssertions):
11:11 AM Changeset in webkit [148895] by eric.carlson@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed Mac gardening. Update a test and results now that forced text
tracks are supported.

  • media/track/track-in-band-expected.txt:
  • media/track/track-in-band.html:
10:56 AM Changeset in webkit [148894] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Crash on OS X when shift clicking outside of input
​https://bugs.webkit.org/show_bug.cgi?id=104058

Patch by Yi Shen <​max.hong.shen@gmail.com> on 2013-04-22
Reviewed by Chang Shu.

Source/WebCore:

Shift clicking outside of a focused div while removing the focused div from
the dom tree at the same time may hit a null visible position, which should
not be used to calculate the text distance with the new selection's start and
end position. Otherwise, the browser may crash.

Test: editing/selection/crash-on-shift-click.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventSingleClick):

LayoutTests:

Add test for shift click crash issue.

  • editing/selection/crash-on-shift-click-expected.txt: Added.
  • editing/selection/crash-on-shift-click.html: Added.
10:37 AM Changeset in webkit [148893] by mark.lam@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
​https://bugs.webkit.org/show_bug.cgi?id=114963.

Reviewed by Oliver Hunt.

SH4 parts contributed by Julien Brianceau.

  • assembler/ARMAssembler.h:
  • assembler/MacroAssemblerARM.h:
  • assembler/MacroAssemblerARMv7.h:
  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchAdd32):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchAdd32):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/SH4Assembler.h:
  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::emitEnterOptimizationCheck):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_enter):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_enter):

10:02 AM Changeset in webkit [148892] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Scrollbar should not depend on EventHandler, Frame and FrameView
​https://bugs.webkit.org/show_bug.cgi?id=114941

Reviewed by Darin Adler.

It's a layering violation that Scrollbar uses EventHandler, Frame
and FrameView. Frame is used to get the EventHandler that is used
to set mousePressed to false after a Scrollbar::mouseUp(). This is
not really needed, since EventHandler already sets m_mousePressed
to false when calling Scrollbar::mouseUp(). The PopupMenu windows
implementation also calls Scrollbar::mouseUp(), but that scrollbar
is not inside a FrameView.

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::isScrollViewScrollbar):
isScrollViewScrollbar() is a method of ScrollView so we don't need
to cast to FrameView.
(WebCore::Scrollbar::mouseUp): Remove EventHandler ussage.

10:00 AM Changeset in webkit [148891] by akling@apple.com
  • 7 edits in trunk/Source

Shrink baseline size of WTF::Vector on 64-bit by switching to unsigned capacity and size.
<​http://webkit.org/b/97268>
<rdar://problem/12376519>

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Update LLInt WTF::Vector offset constants to match the new memory layout.

  • llint/LowLevelInterpreter.asm:

Source/WebCore:

  • CMakeLists.txt: Add a workaround for GCC 4.6.x in Release mode so it

does not crash.

Source/WTF:

Shrink Vector by 8 bytes on 64-bit by using 32-bit capacity and size.
Vector now inherits from VectorBuffer instead of having a VectorBuffer member;
this is necessary for m_size to fall into the padding after the base class members.

The WTF::Vector API still uses size_t.

Based on Blink r148313 by <​cevans@chromium.org>.

  • wtf/SizeLimits.cpp:
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(VectorBufferBase):
(WTF::VectorBuffer::shouldReallocateBuffer):
(Vector):
(WTF::Vector::Vector):
(WTF::Vector::capacity):
(WTF::Vector::at):
(WTF::Vector::data):
(WTF::Vector::swap):
(WTF::::Vector):
(WTF::::reserveCapacity):
(WTF::::tryReserveCapacity):
(WTF::::reserveInitialCapacity):
(WTF::::shrinkCapacity):
(WTF::::releaseBuffer):

9:43 AM Changeset in webkit [148890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] URL decode data: URLs before passing to the platform media player.
​https://bugs.webkit.org/show_bug.cgi?id=114887

Patch by John Griggs <​jgriggs@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Pass data URL through URL decoding before passing to platform media player. PR 313635.

Reviewed internally by Liam Quinn

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

9:40 AM Changeset in webkit [148889] by jberlin@webkit.org
  • 1 edit
    1 copy
    1 move
    2 adds in trunk/LayoutTests

Fix an incorrect rebaseline done in r148830.

Instead of updating the cross platform wk2 results, r148830 should have added efl wk2
specific results. Move the previous mac wk2 specific results into the mac wk2 platform
directory.

  • platform/efl-wk2/loader/go-back-cached-main-resource-expected.txt: Renamed from LayoutTests/platform/wk2/loader/go-back-cached-main-resource-expected.txt.
  • platform/mac-wk2/loader/go-back-cached-main-resource-expected.txt: Downloaded from the mac-wk2 bots.
9:32 AM Changeset in webkit [148888] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Memory barrier support should also ensure that we always do a compiler fence
​https://bugs.webkit.org/show_bug.cgi?id=114934

Reviewed by Michael Saboff.

This is a cherry-pick merge of the WTF part of r148836 from the dfgFourthTier
branch. It fixes a memory ordering bug that is likely asymptomatic, but
nonetheless real: TCSpinLock expects that using a memoryBarrierBeforeUnlock()
prior to setting lockword_ to 0 will ensure that the assignment to lockword_
won't get floated above any of the stores in the critical section. While that
memory barrier does indeed do the right thing on ARM, it doesn't do the right
thing on other architectures: it turns into empty code that the compiler blows
away, which is fine for the hardware since X86 won't reorder that store - but
it's not fine for the compiler, which may still do its own reorderings.

The WTF part of r148836 fixes this by using a compiler fence: an empty asm
volatile block that is marked as clobbering memory.

Instead of doing a separate surgical fix in trunk, I decided to merge the
whole WTF change over, to make merging easier in the future.

Performance testing of this change in dfgFourthTier showed no regression.

  • wtf/Atomics.h:

(WTF::compilerFence):
(WTF::armV7_dmb):
(WTF::armV7_dmb_st):
(WTF::loadLoadFence):
(WTF::loadStoreFence):
(WTF::storeLoadFence):
(WTF::storeStoreFence):
(WTF::memoryBarrierAfterLock):
(WTF::memoryBarrierBeforeUnlock):
(WTF::x86_mfence):

9:03 AM Changeset in webkit [148887] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebKit2

[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
​https://bugs.webkit.org/show_bug.cgi?id=111848

Reviewed by Anders Carlsson.

This allow applications to set a custom directory for the disk
cache.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_disk_cache_directory):

  • UIProcess/API/gtk/WebKitWebContext.h:
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
  • UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):
(main): Use a different temporary disk cache directory for every
test.

8:57 AM Changeset in webkit [148886] by Carlos Garcia Campos
  • 6 edits in trunk/Source/WebKit2

[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial parameters
​https://bugs.webkit.org/show_bug.cgi?id=111845

Reviewed by Anders Carlsson.

Move the cache initialization to platformInitializeWebProcess() to
create the cache using the directory received from the UI
process. This allows to add public API to set a different disk
cache directory from the UI process.

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultDiskCacheDirectory): Return
default disk cache directory.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDiskCacheDirectory): Ditto.

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Remove soup cache initialization.

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Ditto.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Initialize
soup cache.

8:43 AM Changeset in webkit [148885] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Update BatteryClientBlackBerry to use our port's new listener interface
​https://bugs.webkit.org/show_bug.cgi?id=114892

Patch by Otto Derek Cheung <​otcheung@rim.com> on 2013-04-22
Reviewed by Rob Buis.
PR 328147

Modify the client so we only have one listener for battery change events.
The dispatch of different event listeners are handled by BatteryController.

  • WebCoreSupport/BatteryClientBlackBerry.cpp:

(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::onStatusChange):

  • WebCoreSupport/BatteryClientBlackBerry.h:

(BatteryClientBlackBerry):

8:31 AM Changeset in webkit [148884] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

WTF::AtomicString::find() should take unsigned 'start' argument
<​http://webkit.org/b/114958>

Reviewed by Darin Adler.

Fixes the following warnings with -Wshorten-64-to-32:

AtomicString.h:113:76: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

size_t find(UChar c, size_t start = 0) const { return m_string.find(c, start); }


AtomicString.h:115:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

{ return m_string.find(s, start, caseSentitive); }


AtomicString.h:117:35: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]

{ return m_string.find(s, start, caseSentitive); }


  • wtf/text/AtomicString.h:

(WTF::AtomicString::find): Change type of 'start' argument from
size_t to unsigned.

8:20 AM Changeset in webkit [148883] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Fix build warning when GESTURE_EVENTS is ON.
​https://bugs.webkit.org/show_bug.cgi?id=114812

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2013-04-22
Reviewed by Andreas Kling.

Handle GestureSingleTap in the event type switch.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

8:02 AM Changeset in webkit [148882] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Update layout test verifying Tab behaves correctly after linking to fragment ID
​https://bugs.webkit.org/show_bug.cgi?id=114645

Patch by Mario Sanchez Prada <​mario.prada@samsung.com> on 2013-04-22
Reviewed by Chris Fleizach.

  • fast/dom/fragment-activation-focuses-target.html: Updated test.
  • fast/dom/fragment-activation-focuses-target-expected.txt: Updated expectations.
7:26 AM Changeset in webkit [148881] by commit-queue@webkit.org
  • 16 edits in trunk

fix build warning(unused parameter)
​https://bugs.webkit.org/show_bug.cgi?id=114855

Patch by Xuefei Ren <​xren@blackberry.com> on 2013-04-22
Reviewed by Rob Buis.

Source/WebCore:

remove warning(unused parameter) in
Source/WebCore/platform/graphics/blackberry

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:

(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):

  • platform/graphics/blackberry/FontBlackBerry.cpp:

(WebCore::Font::offsetForPositionForComplexText):

  • platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getTraitsInFamily):

  • platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:

(WebCore::GraphicsContext::drawConvexPolygon):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clipConvexPolygon):
(WebCore::GraphicsContext::setURLForRect):
(WebCore::GraphicsContext::setPlatformStrokeColor):
(WebCore::GraphicsContext::setPlatformFillColor):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

  • platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::flushAndDraw):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::platformTransformColorSpace):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::drawTile):

  • platform/graphics/blackberry/PathBlackBerry.cpp:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::clipPath):

  • platform/graphics/blackberry/PatternBlackBerry.cpp:

(WebCore::Pattern::platformPattern):

Source/WebKit/blackberry:

remove warning(unused parameter) in
Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::extractedTextRequest):

Tools:

remove warning(unused parameter) in
Tools/DumpRenderTree/blackberry/EventSender.cpp

  • DumpRenderTree/blackberry/EventSender.cpp:

(getDragModeCallback):

7:24 AM Changeset in webkit [148880] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
​https://bugs.webkit.org/show_bug.cgi?id=114741

Patch by Xan Lopez <​xlopez@igalia.com> on 2013-04-22
Reviewed by George Staikos.

Consider the case where a ResourceHandle won't have a FilterStream
object associated (for example, Blob objects) instead of ASSERTing
pointlessly when asking our network layer for such an object.

This partially fixes fast/dom/HTMLAnchorElement/anchor-nodownload-set.html

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

7:19 AM Changeset in webkit [148879] by mifenton@rim.com
  • 5 edits
    2 adds in trunk

[BlackBerry] Add additional datalist support.
​https://bugs.webkit.org/show_bug.cgi?id=114883

Reviewed by Rob Buis.

PR 210083.

Source/WebCore:

Extend support for datalist to include all non-popup input types.

Re-enabling fast/forms/datalist/input-list

Internally Reviewed by Otto Cheung.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::supportsDataListUI):

Source/WebKit/blackberry:

Properly set state when opening a Date/Time popup and simplify
the logic for showing datalist options.

Internally Reviewed by Otto Cheung.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openDatePopup):
(BlackBerry::WebKit::InputHandler::showTextInputTypeSuggestionBox):

LayoutTests:

Fix results for fast/forms/datalist/input-list.

Internally Reviewed by Otto Cheung.

  • platform/blackberry/fast/forms/datalist/input-list-expected.txt: Added.
5:39 AM Changeset in webkit [148878] by abucur@adobe.com
  • 1 edit
    56 adds in trunk/LayoutTests

[CSS Regions] Add tests for lists and counters
​https://bugs.webkit.org/show_bug.cgi?id=103975

Reviewed by Andreas Kling.

Lists and counters work correctly with regions since r148026 (​http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.

  • fast/regions/counters/extract-list-items-001-expected.html: Added.
  • fast/regions/counters/extract-list-items-001.html: Added.
  • fast/regions/counters/extract-list-items-002-expected.html: Added.
  • fast/regions/counters/extract-list-items-002.html: Added.
  • fast/regions/counters/extract-list-items-003-expected.html: Added.
  • fast/regions/counters/extract-list-items-003.html: Added.
  • fast/regions/counters/extract-list-items-004-expected.html: Added.
  • fast/regions/counters/extract-list-items-004.html: Added.
  • fast/regions/counters/extract-list-items-005-expected.html: Added.
  • fast/regions/counters/extract-list-items-005.html: Added.
  • fast/regions/counters/extract-list-items-006-expected.html: Added.
  • fast/regions/counters/extract-list-items-006.html: Added.
  • fast/regions/counters/extract-list-items-007-expected.html: Added.
  • fast/regions/counters/extract-list-items-007.html: Added.
  • fast/regions/counters/extract-list-items-008-expected.html: Added.
  • fast/regions/counters/extract-list-items-008.html: Added.
  • fast/regions/counters/extract-list-items-009-expected.html: Added.
  • fast/regions/counters/extract-list-items-009.html: Added.
  • fast/regions/counters/extract-list-items-010-expected.html: Added.
  • fast/regions/counters/extract-list-items-010.html: Added.
  • fast/regions/counters/extract-list-items-011-expected.html: Added.
  • fast/regions/counters/extract-list-items-011.html: Added.
  • fast/regions/counters/extract-list-items-012-expected.html: Added.
  • fast/regions/counters/extract-list-items-012.html: Added.
  • fast/regions/counters/extract-list-items-013-expected.html: Added.
  • fast/regions/counters/extract-list-items-013.html: Added.
  • fast/regions/counters/extract-list-items-014-expected.html: Added.
  • fast/regions/counters/extract-list-items-014.html: Added.
  • fast/regions/counters/extract-list-items-015-expected.html: Added.
  • fast/regions/counters/extract-list-items-015.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs.html: Added.
  • fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
  • fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
  • fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
  • fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
4:51 AM Changeset in webkit [148877] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening. css3-device-adaptation doesn't work for WK1 EFL properly.

  • platform/efl-wk1/TestExpectations: Added tests related to css3-device-adaptation.
4:42 AM Changeset in webkit [148876] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark IndexedDB test as crashing in Release mode and fix duplicate line in
TestExpectations.

  • platform/efl/TestExpectations:
3:56 AM Changeset in webkit [148875] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL WK1 gardening. Skip pasteboard tests because EFL WK1 doesn't support it yet.

  • platform/efl-wk1/TestExpectations:
3:51 AM Changeset in webkit [148874] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip several compositing test cases on EFL WK2 due to regression in
r148748.

  • platform/efl-wk2/TestExpectations:
3:41 AM Changeset in webkit [148873] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Add several regressions to TestExpectations to make the tree green.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
3:32 AM Changeset in webkit [148872] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Fix expected result for several test cases.

  • platform/efl/TestExpectations:
3:07 AM Changeset in webkit [148871] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Unskipping the fast/sub-pixel layout tests.

Removing failure expectations for tests that are passing after the subpixel layout was enabled.

2:58 AM Changeset in webkit [148870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Add dummy implementations of DragData::droppedFileSystemId()
​https://bugs.webkit.org/show_bug.cgi?id=114861

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

  • platform/blackberry/DragDataBlackBerry.cpp:

(WebCore):
(WebCore::DragData::droppedFileSystemId):

2:20 AM Changeset in webkit [148869] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations: Skip a failing reftest after r148859.
  • platform/qt/fast/borders/rtl-border-04-expected.png: Update after r148791.
  • platform/qt/fast/borders/rtl-border-04-expected.txt: Update after r148791.
2:14 AM Changeset in webkit [148868] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Unskip fast/exclusions tests after r148594.

  • platform/qt/TestExpectations:
2:11 AM Changeset in webkit [148867] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
​https://bugs.webkit.org/show_bug.cgi?id=114939

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

This was added in r129308.

  • DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:

(AccessibilityController::accessibleElementById):

2:07 AM Changeset in webkit [148866] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] accessibility/language-attribute.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=112030

Unreviewed, EFL gardening.

Unskipping accessibility/language-attribute.html after r148737.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-04-22

  • platform/efl-wk2/TestExpectations:
2:05 AM Changeset in webkit [148865] by commit-queue@webkit.org
  • 15 edits
    6 adds in trunk

Source/WebCore: [CSS Regions] Elements in a region should be assignable to a named flow
​https://bugs.webkit.org/show_bug.cgi?id=74144

Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22
Reviewed by David Hyatt.

DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.

NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.

Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.

RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.

Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.

fast/regions/region-content-flown-into-region.html
fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.

  • dom/Element.cpp:

(WebCore::Element::moveToFlowThreadIsNeeded):

  • dom/Element.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):

  • dom/NodeRenderingContext.h:

(NodeRenderingContext):

  • dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
  • dom/Text.cpp:

(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.

  • dom/Text.h:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):

  • rendering/FlowThreadController.h:
  • rendering/RenderObject.h:

(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).

  • rendering/RenderRegion.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.

  • svg/SVGElement.h:

LayoutTests: [CSS Regions] Elements in a region should be assignable to a named flow
​https://bugs.webkit.org/show_bug.cgi?id=74144

Reviewed by David Hyatt.

  • fast/regions/flow-body-in-html-expected.txt: Added.

Patch by Mihai Maerean <Mihai Maerean> on 2013-04-22

  • fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
  • fast/regions/region-content-flown-into-region-expected.txt: Added.
  • fast/regions/region-content-flown-into-region.html: Added.
  • fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
  • fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
1:59 AM Changeset in webkit [148864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Gradient: add PlatformGradient definition for BlackBerry
​https://bugs.webkit.org/show_bug.cgi?id=114727

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

  • platform/graphics/Gradient.h:

(Graphics):

1:58 AM FeatureFlags edited by rtakacs@inf.u-szeged.hu
(diff)
1:32 AM Changeset in webkit [148863] by abucur@adobe.com
  • 13 edits in trunk

Use DOM ordering for list counts
​https://bugs.webkit.org/show_bug.cgi?id=110352

Reviewed by Elliott Sprehn.

Source/WebCore:

Currently the list items ordering is made by traversing the render tree. This gives bad results for:

  • list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
  • list items matched to insertion points inside a shadow tree. The insertion point may be a child of a

list so the numbering gets broken.

To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.

In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: ​https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: ​https://bugs.webkit.org/show_bug.cgi?id=103975

Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html

  • dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):

  • dom/Node.h:

(Node):

  • dom/NodeTraversal.cpp:

(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

  • dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

  • rendering/RenderListItem.cpp:

(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.

  • fast/dom/shadow/shadow-and-list-elements-expected.html:
  • fast/lists/positioned-count-crash-expected.txt:
12:57 AM Changeset in webkit [148862] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix multiple definition of ImageBuffer::platformLayer() in the BlackBerry port
​https://bugs.webkit.org/show_bug.cgi?id=114936

Patch by Alberto Garcia <​agarcia@igalia.com> on 2013-04-22
Reviewed by Carlos Garcia Campos.

We already have a definition in ImageBufferBlackBerry.cpp.

  • platform/graphics/ImageBuffer.cpp:

(WebCore):

12:49 AM Changeset in webkit [148861] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Cleanup TestExpectations to pass --lint-test-files
​https://bugs.webkit.org/show_bug.cgi?id=114927

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-22

  • platform/gtk/TestExpectations:
12:29 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
12:25 AM Changeset in webkit [148860] by Carlos Garcia Campos
  • 9 edits in trunk

[WebKit2] Plugins without a MIME Type fail to load
​https://bugs.webkit.org/show_bug.cgi?id=112834

Reviewed by Benjamin Poulain.

Source/WebKit2:

The problem is that when the plugin is created and the MIME Type
is empty, since the MIME Type guessed in the UI process using the
plugin extension is not passed to the WebProcess, when the plugin
is instantiated, the value of NPMIMEType parameter passed to
NPP_New is NULL, and NPERR_INVALID_INSTANCE_ERROR is returned.
GetPluginPath message has been renamed to FindPlugin, since it
doesn't only return the path but also the new MIME Type and load
policy.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin): Receive an output newMIMEType
parameter that is passed to PluginModuleInfo::findPlugin() so that
in case of guessing the MIME Type, the new one is passed back to
the WebProcess.

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createPlugin): Pass the MIME Type
from the parameters to WebPage::createPlugin.
(WebKit::WebFrameLoaderClient::recreatePlugin): Pass a newMIMEType
parameter to WebPage::createPlugin.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Add newMIMEType out parameter and
pass it to the FindPlugin message.
(WebKit::WebPage::canPluginHandleResponse): Pass newMIMEType to
FindPlugin message.

  • WebProcess/WebPage/WebPage.h:

(WebPage):

LayoutTests:

  • platform/wk2/TestExpectations: Unskip

plugins/no-mime-with-valid-extension.html.

Note: See TracTimeline for information about the timeline view.