Timeline
Apr 24, 2013:
- 11:42 PM Changeset in webkit [149093] by
-
- 5 edits in trunk
Back references don't work in pattern attribute
https://bugs.webkit.org/show_bug.cgi?id=105875
Reviewed by Geoffrey Garen.
Source/WebCore:
This imports a part of Blink r148951.
Tests: Update fast/forms/ValidityState-patternMismatch.html
- html/BaseTextInputType.cpp:
(WebCore::BaseTextInputType::patternMismatch):
Don't use capturing parentheses. They affected back references in
pattern attribute values.
LayoutTests:
- fast/forms/ValidityState-patternMismatch-expected.txt:
- fast/forms/ValidityState-patternMismatch.html:
- 10:41 PM Changeset in webkit [149092] by
-
- 2 edits in trunk/Tools
Remove checking chromium from run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=115139
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.
- Scripts/run-webkit-tests:
(useNewRunWebKitTests):
- 10:30 PM Changeset in webkit [149091] by
-
- 5 edits in trunk/Source
PDFPlugin: Cursor should become an i-beam when over selectable text
https://bugs.webkit.org/show_bug.cgi?id=115018
<rdar://problem/12645012>
Reviewed by Alexey Proskuryakov.
- WebProcess/Plugins/PDF/PDFPlugin.h:
Add updateCursor(), the UpdateCursorMode and HitTestResult enums, and
storage for the last PDF hit test result.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::updateCursor):
Hit test the PDF. If there is a word under the cursor, use the I-beam cursor,
otherwise, use the default pointer cursor. This approximates PDFKit's behavior,
though does not match it precisely in the case of annotations.
Only send the cursor update to the UIProcess if it is a change, or if
we're explicitly asked to update.
(WebKit::PDFPlugin::handleMouseEvent):
If we're processing a mouse moved event, update the cursor if needed.
(WebKit::PDFPlugin::handleMouseEnterEvent):
If the cursor just moved over the PDFPlugin, force-update the cursor,
even if it matches the previously-set cursor (because something else
likely updated the cursor while it was not over the PDFPlugin).
- WebCore.exp.in: Export the I-beam and arrow cursors.
- 9:56 PM Changeset in webkit [149090] by
-
- 1 edit559 adds297 deletes in trunk/LayoutTests
Roll out AppleWin re-baselines from r149088.
- 7:59 PM Changeset in webkit [149089] by
-
- 11 edits in trunk/Source/JavaScriptCore
Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.
Reviewed by Geoffrey Garen.
The strategy is to add a speculation check to the DFG generated code to
test if the watchdog timer has fired or not. If the watchdog timer has
fired, the generated code will do an OSR exit to the baseline JIT, and
let it handle servicing the watchdog timer.
If the watchdog is not enabled, this speculation check will not be
emitted.
- API/tests/testapi.c:
(currentCPUTime_callAsFunction):
(extendTerminateCallback):
(main):
- removed try/catch statements so that we can test the watchdog on the DFG.
- added JS bindings to a native currentCPUTime() function so that the timeout tests can be more accurate.
- also shortened the time values so that the tests can complete sooner.
- bytecode/ExitKind.h:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- runtime/Watchdog.cpp:
(JSC::Watchdog::setTimeLimit):
- 7:44 PM Changeset in webkit [149088] by
-
- 103 edits2046 adds1760 deletes in trunk/LayoutTests
Unreviewed optimize-baselines for mac and win.
- 7:09 PM Changeset in webkit [149087] by
-
- 17 edits in trunk/Tools
Pixel tests in SVG are all broken in WK2
https://bugs.webkit.org/show_bug.cgi?id=114218
Reviewed by Darin Adler.
Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.
Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.
Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::setShouldPaintBrokenImage):
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/efl/DumpRenderTree.cpp:
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(webInspectorShowWindow):
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createPagedBitmapContext):
- DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):
- DumpRenderTree/qt/TestRunnerQt.cpp:
- DumpRenderTree/qt/TestRunnerQt.h:
- DumpRenderTree/win/DumpRenderTree.cpp:
(sizeWebViewForCurrentTest):
- DumpRenderTree/wx/DumpRenderTreeWx.cpp:
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
- WebKitTestRunner/TestController.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::sizeWebViewForCurrentTest):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):
- 6:32 PM Changeset in webkit [149086] by
-
- 2 edits in trunk/Source/WebKit2
Page Overlays shouldn't waste time flushing layers if we're not going to use it
https://bugs.webkit.org/show_bug.cgi?id=115145
Reviewed by Simon Fraser.
Don't flush the page overlay layer when it's installed - it starts out
with paintContents=false, so we don't really need a CALayer yet. We'll
flush later if need be.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
- 6:32 PM Changeset in webkit [149085] by
-
- 5 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: AbstractValue methods that deal with watchpoints should have access to Graph, so that in debug mode, Graph can track the history of watchpoint states and detect races
https://bugs.webkit.org/show_bug.cgi?id=115084
Reviewed by Geoffrey Garen.
The idea is that as part of https://bugs.webkit.org/show_bug.cgi?id=115083, I'll have
Graph record the initial state of a watchpoint at the time that we decide to take
advantage of it; then I will use this to disable any watchpoint-related assertions
in debug mode. Note that this "watchpoint cache" will only be maintained in debug
mode, so there will be no release performance implications. But to do this, I need to
ensure that all of the places that reason about watchpoints have access to Graph.
For example, I'll want AbstractValue::setFuturePossibleStructure to record the state
of the watchpoint in Graph so that subsequent assertions can check if the watchpoint's
state had changed since that decision was made.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):
- dfg/DFGAbstractState.h:
(JSC::DFG::AbstractState::trySetConstant):
- dfg/DFGAbstractValue.cpp: Added.
(DFG):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::dump):
- dfg/DFGAbstractValue.h:
(DFG):
(AbstractValue):
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::filterByValue):
- 6:27 PM Changeset in webkit [149084] by
-
- 3 edits2 adds in trunk
Garbage at the top of http://www.technologyreview.com after scrolling
https://bugs.webkit.org/show_bug.cgi?id=114825
Source/WebCore:
Reviewed by Tim Horton.
Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
but then not painting anything into it. On this page, the element is
toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
failed to consider that as something that can cause backgrounds not to be opaque.
For the bug to happen, some subtle interactions with r142012 come into play
for the layer to remain visible, hence the slightly complex testcase.
Test: compositing/contents-opaque/visibility-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Tim Horton.
Test that sets visibility:hidden on an element with some complex
configuration of layer children, and dumps the layer tree to check
that the contents are not marked as opaque.
- compositing/contents-opaque/visibility-hidden-expected.txt: Added.
- compositing/contents-opaque/visibility-hidden.html: Added.
- 6:27 PM Changeset in webkit [149083] by
-
- 2 edits in trunk/Source/WebCore
Dump layer opaqueness in the Compositing log output
https://bugs.webkit.org/show_bug.cgi?id=115132
Reviewed by Tim Horton.
It's useful to see whether we consider layers to be opaque in the Compositing
log channel output, so dump it.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
- 6:26 PM Changeset in webkit [149082] by
-
- 5 edits in trunk/Source/JavaScriptCore
Special thunks for math functions should work on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=115144
Reviewed by Gavin Barraclough and Oliver Hunt.
The only hard bit here was ensuring that we implemented the very special
"cheap C call" convention on ARMv7.
- assembler/AbstractMacroAssembler.h:
(JSC::isARMv7s):
(JSC):
(JSC::isX86):
- dfg/DFGCommon.h:
- jit/SpecializedThunkJIT.h:
(SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):
- jit/ThunkGenerators.cpp:
(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):
- 5:51 PM Changeset in webkit [149081] by
-
- 2 edits in trunk/Source/WebCore
Add efl to JSInspectorFrontendHost::port()
https://bugs.webkit.org/show_bug.cgi?id=115137
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Timothy Hatcher.
No new tests, because there is no change in behavior.
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::port):
- 5:44 PM Changeset in webkit [149080] by
-
- 3 edits in trunk/Source/WebCore
Function parameter quotePair can be passed by reference
https://bugs.webkit.org/show_bug.cgi?id=115089
Reviewed by Alexey Proskuryakov.
Minor performance patch.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::addPair):
- rendering/style/QuotesData.h:
(QuotesData):
- 5:17 PM Changeset in webkit [149079] by
-
- 10 edits in trunk/Source/WebCore
Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
https://bugs.webkit.org/show_bug.cgi?id=115140
Reviewed by Beth Dakin.
No new tests (No behavior change).
This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
in all CachedResource subclasses besides CachedFont (which already has an implementation).
- loader/cache/CachedCSSStyleSheet.h:
- loader/cache/CachedImage.h:
- loader/cache/CachedRawResource.h:
- loader/cache/CachedResource.h:
- loader/cache/CachedSVGDocument.h:
- loader/cache/CachedScript.h:
- loader/cache/CachedShader.h:
- loader/cache/CachedTextTrack.h:
- loader/cache/CachedXSLStyleSheet.h:
- 5:10 PM Changeset in webkit [149078] by
-
- 2 edits in trunk/Source/JavaScriptCore
Misc bugfix and cleaning in sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115022.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-24
Reviewed by Oliver Hunt.
Remove unused add32() and sub32() with scratchreg parameter to avoid
confusion as this function prototype means another behaviour.
Remove unused "void push(Address)" function which seems quite buggy.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::and32): Cosmetic change.
(JSC::MacroAssemblerSH4::lshift32): Cosmetic change.
(JSC::MacroAssemblerSH4::or32): Cosmetic change.
(JSC::MacroAssemblerSH4::xor32): Cosmetic change.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load32): Cosmetic change.
(JSC::MacroAssemblerSH4::load8Signed): Fix invalid offset upper limit
when using r0 register and cosmetic changes.
(JSC::MacroAssemblerSH4::load8): Reuse load8Signed to avoid duplication.
(JSC::MacroAssemblerSH4::load16): Fix invalid offset upper limit when
using r0 register, fix missing offset shift and cosmetic changes.
(JSC::MacroAssemblerSH4::store32): Cosmetic change.
(JSC::MacroAssemblerSH4::branchAdd32): Store result value before branch.
- 4:46 PM Changeset in webkit [149077] by
-
- 2 edits in trunk/Source/WebKit2
Further unreviewed build fix; CFNetwork.framework is the one which Lion
refuses to link against.
- WebKit2.xcodeproj/project.pbxproj:
- 4:32 PM Changeset in webkit [149076] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix; link against CoreServices.framework instead of against
CoreFoundation.framework directly, to make the linker happy on Lion.
- WebKit2.xcodeproj/project.pbxproj:
- 4:31 PM Changeset in webkit [149075] by
-
- 2 edits in trunk/LayoutTests
Fix invalid test names in jsc-test-list
<http://webkit.org/b/115136>
Reviewed by Geoffrey Garen.
This shell script finds all the invalid tests listed in
LayoutTests/fast/js/jsc-test-list:
$ for F in
cat LayoutTests/fast/js/jsc-test-list; do if [ ! -f LayoutTests/$F.html ]; then echo $F; fi; done
fast/js/dfg-double-addition-simplify-to-int.html
fast/js/dfg-mul-big-integers-with-small-integer-and-bitor
fast/js/dfg-mul-big-integers-with-small-integer-and-detect-overflow
fast/js/dfg-mul-big-integers-with-small-integer
fast/js/dfg-value-to-int32-with-side-effects
- fast/js/jsc-test-list: Fix invalid test names by removing
*.html suffix or stray "s" characters.
- 4:20 PM Changeset in webkit [149074] by
-
- 9 edits3 copies2 adds in trunk/Source/WebKit2
WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858
Reviewed by Eric Carlson. Rubber stamped by Brady Eidson.
AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.
Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:
- Shared/mac/CookieStorageShimLibrary.h: Added
(CookieStorageShimCallbacks):
- Shared/mac/CookieStorageShimLibrary.cpp: Added.
(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose
the CFNetwork call, and pass to the registered callback.
(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.
Add a helper singleton class which will talk to the shim through the
registered callbacks:
- Shared/mac/CookieStorageShim.h: Added
(WebKit::CookieStorageShim::CookieStorageShim):
- Shared/mac/CookieStorageShim.cpp: Added.
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request
over to the NetworkProcess.
(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.
Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Rename the WebProcess's shim from SecItemShim -> WebProcessShim:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::addDYLDEnvironmentAdditions):
- WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:
- Shared/mac/DyldInterpose.h: Added.
- PluginProcess/mac/PluginProcessShim.mm:
- WebProcess/mac/SecItemShimLibrary.mm:
Add new files to the project:
- WebKit2.xcodeproj/project.pbxproj:
- 3:50 PM Changeset in webkit [149073] by
-
- 4 edits in trunk
[EFL] Fix build error after r148963.
https://bugs.webkit.org/show_bug.cgi?id=115126
Reviewed by Laszlo Gombos.
Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h
Source/WebKit2:
- PlatformEfl.cmake:
Tools:
- TestWebKitAPI/PlatformEfl.cmake:
- 3:42 PM Changeset in webkit [149072] by
-
- 13 edits in trunk/Source/JavaScriptCore
[WIN] Remove pthread from Visual Studio files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114864
Reviewed by Brent Fulgham.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
- JavaScriptCore.vcproj/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.vsprops:
- JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
- JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops:
- JavaScriptCore.vcproj/testapi/testapiCommon.vsprops:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props:
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
- JavaScriptCore.vcxproj/jsc/jscCommon.props:
- JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
- JavaScriptCore.vcxproj/testapi/testapiCommon.props:
- JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props:
- 3:39 PM Changeset in webkit [149071] by
-
- 4 edits3 adds in trunk
DFG should keep the operand to create_this alive if it's emitting code for create_this
https://bugs.webkit.org/show_bug.cgi?id=115133
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
The DFG must model bytecode liveness, or else OSR exit is going to have a really bad time.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
LayoutTests:
Reviewed by Mark Hahnenberg.
This test crashes prior to my change.
- fast/js/dfg-allocation-profile-watch-point-exit-expected.txt: Added.
- fast/js/dfg-allocation-profile-watch-point-exit.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js: Added.
(Foo):
(foo):
- 3:35 PM Changeset in webkit [149070] by
-
- 5 edits in trunk/Source/WebCore
Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
<rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131
Reviewed by Alexey Proskuryakov.
No new tests (Not a tested config, nor are disk cache issues currently testable).
- loader/cache/CachedResource.h:
(WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.
- loader/cache/CachedFont.cpp:
(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.
- loader/cache/CachedFont.h:
- 3:22 PM Changeset in webkit [149069] by
-
- 2 edits in branches/safari-536.30-branch/LayoutTests
<rdar://problem/12952167> 11G56: “AVF Info: …” logged to stdout
- platform/mac-lion/Skipped: Skipped all tests that were failing due to AVF info being printed.
- 3:05 PM Changeset in webkit [149068] by
-
- 5 edits in trunk/LayoutTests
fast/js/global-constructors.html was deleted in r149001, removing it from
TextExpectations too.
- platform/mac/TestExpectations:
- platform/qt-arm/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 2:43 PM Changeset in webkit [149067] by
-
- 13 edits in trunk
Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd:
- JavaScriptCore.vcxproj/JavaScriptCorePreLink.cmd:
- JavaScriptCore.vcxproj/jsc/jscPostBuild.cmd:
- JavaScriptCore.vcxproj/jsc/jscPreLink.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
- JavaScriptCore.vcxproj/testRegExp/testRegExpPostBuild.cmd:
- JavaScriptCore.vcxproj/testRegExp/testRegExpPreLink.cmd:
- JavaScriptCore.vcxproj/testapi/testapiPreLink.cmd:
- WTF.vcxproj/build-generated-files.sh:
- win/tools/vsprops/common.props:
- 2:37 PM Changeset in webkit [149066] by
-
- 12 edits in trunk/Source/WebCore
Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
a circle
https://bugs.webkit.org/show_bug.cgi?id=115124
-and corresponding-
<rdar://problem/13168957>
Reviewed by Anders Carlsson.
With http://trac.webkit.org/changeset/119834 we started calling
ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection
API on a zero-delay timer instead of calling it right away. This prevented some
crashes that we saw whenever this was called during a layout. However, that delay,
combined with the particulars of contentAreaScrolledInDirection cause this bug
where sometimes the scrollbars in an iframe will fade out very noticeably when
scrolling in a circle.
This change makes it so we will only use the zero-delay timer if the
ScrollableArea is not currently handling a wheel event. If it IS handling a wheel
event, then we will send the notifications to AppKit right away. I confirmed that
this change did not reintroduce the old crashes.
Keep track of whether we are currently handling a wheel event with the new member
variable m_isHandlingWheelEvent.
- page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):
- page/EventHandler.h:
(WebCore::EventHandler::isHandlingWheelEvent):
(EventHandler):
To prevent layering violations, the ScrollableArea sub-classes will have to access
this information from the EventHandler.
- page/FrameView.cpp:
(WebCore::FrameView::isHandlingWheelEvent):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::isHandlingWheelEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isHandlingWheelEvent):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isHandlingWheelEvent):
- rendering/RenderListBox.h:
sendContentAreaScrolledSoon() can be private. Also add new function
sendContentAreaScrolled().
- platform/mac/ScrollAnimatorMac.h:
(ScrollAnimatorMac):
If the ScrollableArea is handling a wheel event, call
sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):
Re-factored to use sendContentAreaScrolled()
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):
- 2:35 PM Changeset in webkit [149065] by
-
- 2 edits in trunk/Source/WebCore
Fix a merge error in r149007 (was missing a null check added in r148777).
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::containingBlockForAbsolutePosition):
- 2:33 PM Changeset in webkit [149064] by
-
- 2 edits in trunk/Source/WebKit2
Crash when trying to determine the length of an invalid message
https://bugs.webkit.org/show_bug.cgi?id=115127
<rdar://problem/13700736>
Reviewed by Beth Dakin.
Use message instead of incomingMessage since incomingMessage will always be null.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- 1:38 PM Changeset in webkit [149063] by
-
- 4 edits in trunk/Source/WebCore
Battery API won't return updated battery status until client calls didChangeBatteryStatus
https://bugs.webkit.org/show_bug.cgi?id=114891
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-24
Reviewed by Rob Buis.
The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
or other get functions will always return the default values until the next battery status
change object gets passed to the controller.
We need to update the manager when we attach it to the controller, and update all
existing managers when the controller receives it's first battery status object.
- Modules/battery/BatteryController.cpp:
(WebCore::BatteryController::addListener):
(WebCore::BatteryController::updateBatteryStatus):
- Modules/battery/BatteryManager.cpp:
(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
(WebCore):
- Modules/battery/BatteryManager.h:
(BatteryManager):
- 1:11 PM Changeset in webkit [149062] by
-
- 2 edits in trunk/Source/WebCore
Clean up unused code in ViewportArguments.h
https://bugs.webkit.org/show_bug.cgi?id=115121
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-24.
Reviewed by Benjamin Poulain.
The target-densityDPI emulation implementation has been removed by
r147893, so clean up the remaining code as well.
- dom/ViewportArguments.h:
- 1:03 PM Changeset in webkit [149061] by
-
- 5 edits in trunk/Source/WebCore
ElementData should use 'unsigned' attribute indices.
<http://webkit.org/b/115103>
Reviewed by Antti Koivisto.
Switch to using 'unsigned' for attribute indices. This gives consistent behavior
on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.
Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.
- dom/Element.cpp:
(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::getAttributeItemIndexSlowCase):
- dom/Element.h:
(ElementData):
(UniqueElementData):
(Element):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::attributeCount):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::length):
- dom/NamedNodeMap.h:
(NamedNodeMap):
- 1:00 PM Changeset in webkit [149060] by
-
- 2 edits in trunk/Source/WebCore
ElementData::attributeItem() should bounds-check the index.
<http://webkit.org/b/115076>
Reviewed by Antti Koivisto.
Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.
- dom/Element.h:
(WebCore::ElementData::attributeItem):
- 12:59 PM Changeset in webkit [149059] by
-
- 2 edits in trunk/Source/WebCore
Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
<http://webkit.org/b/115122>
Reviewed by Antti Koivisto.
StylePropertySet::setProperty() handles empty strings by removing the property entirely.
If there was no property to remove, it shouldn't claim that it changed something, as that
will cause the CSSOM wrapper to mark the element for style recalc.
A common idiom that triggers this is excessive use of { element.style.display = ; }
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
- 12:50 PM Changeset in webkit [149058] by
-
- 3 edits2 adds in trunk
Moving word boundaries backwards fails when there is a text node starting with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=115070
Reviewed by Alexey Proskuryakov.
Source/WebCore:
The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
"I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".
Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
languages like Hebrew and some of European languages, there could be many accents and combining characters
between split into multiple text nodes as one variant is seen in the newly added test case.
Test: editing/selection/previous-word-boundary-across-text-nodes.html
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
LayoutTests:
Added a test case for moving bacwkards with a word granurality across multiple text nodes.
Some test cases still fail since this patch only implements a work around.
- editing/selection/previous-word-boundary-across-text-nodes-expected.txt: Added.
- editing/selection/previous-word-boundary-across-text-nodes.html: Added.
- 12:46 PM Changeset in webkit [149057] by
-
- 3 edits in trunk/Source/WebCore
Do not use static string in DiagnosticLoggingKeys
https://bugs.webkit.org/show_bug.cgi?id=115093
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-24
Reviewed by Andreas Kling.
The code is not hot enough to justify keeping the memory around.
This removes 3kb from the binary on x86_64.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
- page/DiagnosticLoggingKeys.h:
(DiagnosticLoggingKeys):
- 12:38 PM Changeset in webkit [149056] by
-
- 22 edits in trunk/Source/WebCore
Remove wxWebKit #ifdefs from WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=115081
Reviewed by Geoffrey Garen.
- platform/graphics/BitmapImage.h:
(BitmapImage):
- platform/graphics/Color.h:
(Color):
- platform/graphics/FloatRect.h:
(FloatRect):
- platform/graphics/FloatSize.h:
(FloatSize):
- platform/graphics/FontPlatformData.h:
- platform/graphics/GlyphBuffer.h:
(WebCore):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):
- platform/graphics/Gradient.h:
- platform/graphics/GraphicsContext.h:
(GraphicsContext):
- platform/graphics/Image.cpp:
(WebCore::Image::drawTiled):
- platform/graphics/ImageBufferData.h:
- platform/graphics/IntPoint.h:
(IntPoint):
- platform/graphics/IntRect.h:
- platform/graphics/IntSize.h:
(IntSize):
- platform/graphics/NativeImagePtr.h:
(WebCore):
- platform/graphics/Path.h:
- platform/graphics/Pattern.h:
- platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/transforms/AffineTransform.h:
(AffineTransform):
- platform/graphics/transforms/TransformationMatrix.h:
(TransformationMatrix):
- 12:36 PM Changeset in webkit [149055] by
-
- 4 edits in trunk/Source/WebCore
Remove wxWebKit #ifdefs from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=115080
Reviewed by Geoffrey Garen.
- plugins/PluginView.h:
(PluginView):
- plugins/mac/PluginViewMac.mm:
(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::platformStart):
- plugins/win/PluginViewWin.cpp:
(windowHandleForPageClient):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):
- 12:35 PM Changeset in webkit [149054] by
-
- 4 edits in trunk/Source/WebCore
Remove wxWebKit #ifdefs from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=115079
Reviewed by Geoffrey Garen.
- page/FrameView.cpp:
(WebCore::FrameView::wheelEvent):
- page/Settings.cpp:
(WebCore):
- page/Settings.h:
(Settings):
- 12:34 PM Changeset in webkit [149053] by
-
- 2 edits in trunk/Source/WTF
Use post-branch store for RefCountedBase::derefBase
https://bugs.webkit.org/show_bug.cgi?id=115078
Reviewed by Andreas Kling.
- wtf/RefCounted.h:
(WTF::RefCountedBase::derefBase): This makes the assembly easier to follow.
- 11:34 AM Changeset in webkit [149052] by
-
- 5 edits in trunk
[GTK] Use stamp files for generate-forwarding-headers makefile rules
https://bugs.webkit.org/show_bug.cgi?id=115118
Reviewed by Martin Robinson.
Source/WebKit2:
Use a stamp file for the WebKit2 forwarding generator rule. Also
fix the rule dependencies that pointed to a non existent variable.
- GNUmakefile.am:
Tools:
Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.
- TestWebKitAPI/GNUmakefile.am:
- WebKitTestRunner/GNUmakefile.am:
- 11:33 AM Changeset in webkit [149051] by
-
- 12 edits2 adds in trunk
AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
https://bugs.webkit.org/show_bug.cgi?id=114547
Reviewed by David Kilzer.
Source/WebCore:
We want iOS to speak the landmark type.
I've moved the landmark role description to the base Mac class and exposed
these localized strings to iOS (the ones used to return landmark descriptions).
I've also updated the accessibilityLabel to account for landmark type, but also
handle multiple label sources more gracefully by appending commas, which changed a few
tests in minor ways.
Test: platform/iphone-simulator/accessibility/landmark-type.html
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityLabel]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):
- platform/LocalizedStrings.cpp:
(WebCore):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
- platform/LocalizedStrings.h:
(WebCore):
LayoutTests:
- platform/iphone-simulator/accessibility/landmark-type-expected.txt: Added.
- platform/iphone-simulator/accessibility/landmark-type.html: Added.
- platform/iphone-simulator/accessibility/link-with-images-text-expected.txt:
- platform/iphone-simulator/accessibility/link-with-images-text.html:
Minor change to accomodate trimming of white space.
- platform/iphone-simulator/accessibility/math-expected.txt:
- platform/iphone-simulator/accessibility/math.html:
Math objects now include "math" as the landmark type.
- 11:16 AM Changeset in webkit [149050] by
-
- 2 edits in trunk/Source/JavaScriptCore
32-bit build fix.
Unreviewed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): Explicitly
truncate to 32-bit to avoid compiler warnings. It's safe to truncate
because the payload of a boolean is the low bits on both 64-bit and 32-bit.
- 11:06 AM Changeset in webkit [149049] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
https://bugs.webkit.org/show_bug.cgi?id=115094
Reviewed by Tim Horton.
The method was introduced in r149004 (and a stub implementation for the GTK port added in r149017).
Implement the method for the GTK port in the same manner it is implemented under the Mac port,
calling setContentsOpaque on the non-composited content layer.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):
- 10:50 AM Changeset in webkit [149048] by
-
- 2 edits in trunk/Tools
[GTK] Update build dependencies
https://bugs.webkit.org/show_bug.cgi?id=115111
Patch by Simon Pena <simon.pena@samsung.com> on 2013-04-24
Reviewed by Martin Robinson.
The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.
- gtk/install-dependencies: Added a dependency on libegl1-mesa
for both apt and yum.
- 10:43 AM Changeset in webkit [149047] by
-
- 2 edits in trunk/Source/WebCore
CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
<http://webkit.org/b/115116>
<rdar://problem/13727709>
Reviewed by Simon Fraser.
The logic that dirties the style if there's a relevant attribute selector in the document
shouldn't run if the attribute is being overwritten with an identical value.
Move this into willModifyAttribute() instead, since we need access to both the old and the new value.
This reduces unnecessary style recalculation in Mac App Store content.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):
- 10:07 AM Changeset in webkit [149046] by
-
- 2 edits in trunk/Tools
Remove the Chromium-specific helper from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=114996
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Dirk Pranke.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
- 9:12 AM Changeset in webkit [149045] by
-
- 3 edits1 add in trunk/Tools
[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
https://bugs.webkit.org/show_bug.cgi?id=114850
Patch by Sergio Correia <Sergio Correia> on 2013-04-24
Reviewed by Andreas Kling.
Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.
That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.
This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.
This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.
(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):
- 9:08 AM Changeset in webkit [149044] by
-
- 2 edits in trunk/Source/WebKit2
2013-04-24 Simon Cooper <scooper@apple.com>
<rdar://problem/13614117> Refine the Flash Player profile
https://bugs.webkit.org/show_bug.cgi?id=115016
Reviewed by Alexey Proskuryakov.
Add some refinements to the Flash Player profile. Make a non-/ home
directory work. Fixes that allow file uploading via user selected files.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- 8:59 AM Changeset in webkit [149043] by
-
- 6 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not clear focus on a node when tapping on form controls
https://bugs.webkit.org/show_bug.cgi?id=115055
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-24
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::doFatFingers):
- 8:49 AM Changeset in webkit [149042] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Fixes the San Angeles demo on khronos.org
https://bugs.webkit.org/show_bug.cgi?id=115106
Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-24
Reviewed by Rob Buis
Internally Reviewed by Jeremy Nicholl and Arvid Nilsson
Fixes a bug in which the currently bound vertex array object's vertex array
state was being modified as opposed to the default vertex array state.
- platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(EGLImageLayerWebKitThread::blitToFrontBuffer):
- 8:48 AM Changeset in webkit [149041] by
-
- 8 edits in trunk
Filled out more cases of branch folding in the DFG
https://bugs.webkit.org/show_bug.cgi?id=115088
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
No change on the benchmarks we track, but a 3X speedup on a
microbenchmark that uses these techniques.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock): (!/=)= and (!/=)== can constant
fold all types, not just numbers, because true constants have no
side effects when type-converted at runtime.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateBoolean): Added support for fixing up
boolean uses, like we do for other types like number.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare): Peephole fuse
boolean compare and/or compare-branch, now that we have the types for
them.
- dfg/DFGSpeculativeJIT.h: Updated declarations.
LayoutTests:
- fast/js/regress/script-tests/branch-fold.js:
(g): Added some boolean and constant-folded cases.
- 8:44 AM Changeset in webkit [149040] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Fold RenderThemeMacShared into RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=115086
Reviewed by Anders Carlsson.
No intended functionality change.
- WebCore.xcodeproj/project.pbxproj:
- rendering/RenderThemeMac.h:
(RenderThemeMac):
(WebCore::RenderThemeMac::supportsControlTints):
(WebCore::RenderThemeMac::scrollbarControlSizeForPart):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors):
(WebCore::RenderThemeMac::supportsClosedCaptioning):
(WebCore::RenderThemeMac::updateActiveState):
- rendering/RenderThemeMac.mm:
(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
(WebCore):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformFocusRingColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMac::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::systemColor):
(WebCore::RenderThemeMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::updateCheckedState):
(WebCore::RenderThemeMac::updateEnabledState):
(WebCore::RenderThemeMac::updateFocusedState):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintTextArea):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::popupButtonMargins):
(WebCore::RenderThemeMac::popupButtonSizes):
(WebCore::RenderThemeMac::popupButtonPadding):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
(WebCore::RenderThemeMac::levelIndicatorStyleFor):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::menuListSizes):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::searchFieldSizes):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::cancelButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
(WebCore::RenderThemeMac::fileListNameForWidth):
- rendering/RenderThemeMacShared.h: Removed.
- rendering/RenderThemeMacShared.mm: Removed.
- 8:38 AM CoordinatedGraphicsSystem edited by
- (diff)
- 8:36 AM Changeset in webkit [149039] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Visible rect doesn't update after resizing a window.
https://bugs.webkit.org/show_bug.cgi?id=115096
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.
Once we set actor's a clip rect, we should update the rect when resizing the actor.
No new tests since no new functionality.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setSize):
- 8:34 AM Changeset in webkit [149038] by
-
- 2 edits in trunk/Source/WebCore
[GTK][AC] Fix unexpected clear of ClutterContent.
https://bugs.webkit.org/show_bug.cgi?id=115099
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.
adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
it would be cleared unexpectedly by smart pointer when escaping a function.
No new tests, no functionality changed.
- platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):
- 8:30 AM Changeset in webkit [149037] by
-
- 2 edits in trunk/Source/WebKit/win
Wild build fix attempt.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 8:26 AM Changeset in webkit [149036] by
-
- 2 edits in trunk/Source/WebKit2
[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=115098
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-24
Reviewed by Martin Robinson.
r148963 introduced a new WKView.h header in a directory not listed
as a platform prefix in generate-forwarding-headers.pl.
- Scripts/generate-forwarding-headers.pl: Replace unused chromium
plaform prefix with CoordinatedGraphics that is used now.
- 8:15 AM Changeset in webkit [149035] by
-
- 7 edits1 delete in trunk/Source/WebKit
Assertion failure (crash in release) attempting to delete database storage in WK1 without
creating a WebView first
https://bugs.webkit.org/show_bug.cgi?id=115065
Reviewed by Brady Eidson.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Remove WebDatabaseManagerInternal.h.
Source/WebKit/mac:
Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager.
- Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager init]):
Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to
WebPlatformStrategies::initializeIfNecessary.
- Storage/WebDatabaseManagerInternal.h: Removed.
- WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
Change "initialize" to "initalizeIfNecessary".
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::initializeIfNecessary):
Only call setPlatformStrategies once.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
Updated for the name change from initialize to initializeIfNecessary.
Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager
sharedWebDatabaseManager].
(+[WebView _setLoadResourcesSerially:]):
Updated for the name change from initialize to initializeIfNecessary.
- 7:27 AM Changeset in webkit [149034] by
-
- 2 edits in trunk/Source/WebCore
DOMFileSystemBase: fix multiple definitions in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114950
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-24
Reviewed by Xan Lopez.
The following methods are already defined in DOMFileSystemBlackBerry.cpp:
crackFileSystemURL()
createFileSystemURL()
isValidType()
supportsToURL()
- Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore):
- 7:10 AM Changeset in webkit [149033] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] Add support for JPEG image quality during encoding.
https://bugs.webkit.org/show_bug.cgi?id=105773
Patch by George Staikos <gstaikos@rim.com> on 2013-04-24
Reviewed by Xan Lopez.
PR 271611
Internally reviewed by Liam Quinn.
Pass the quality flag into the encoder, with a default of 65
Covered by existing tests.
- platform/image-encoders/JPEGImageEncoder.cpp:
(WebCore::compressRGBABigEndianToJPEG):
- platform/image-encoders/JPEGImageEncoder.h:
(WebCore):
- 6:54 AM Changeset in webkit [149032] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-24
Reviewed by Gyuyoung Kim.
Added unit tests for ewk_settings APIs.
- tests/test_ewk_setting.cpp:
(TEST_F):
- 6:11 AM Changeset in webkit [149031] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
https://bugs.webkit.org/show_bug.cgi?id=115036
Reviewed by Benjamin Poulain.
- platform/graphics/GraphicsContext3D.cpp:
(WebCore):
- 6:03 AM Changeset in webkit [149030] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/js/constructor-length.html for EFL port after
r148997.
- platform/efl/fast/js/constructor-length-expected.txt:
- 5:33 AM Changeset in webkit [149029] by
-
- 3 edits in trunk/Source/WebCore
Remove unnecessary MutableStylePropertySet casts.
<http://webkit.org/b/115075>
Reviewed by Geoffrey Garen.
Get rid of some now-unneeded static_casts that were left from the StylePropertySet
refactoring last weekend.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::setProperty):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
- 5:17 AM Changeset in webkit [149028] by
-
- 2 edits in trunk/Source/WebCore
[Minor code cleanup] Remove duplicated condition check
https://bugs.webkit.org/show_bug.cgi?id=115082
Reviewed by Andreas Kling.
areRectsPartiallyAligned() has duplicated condition check, so remove it.
- page/SpatialNavigation.cpp:
(WebCore::areRectsPartiallyAligned):
- 5:01 AM Changeset in webkit [149027] by
-
- 2 edits in trunk/Tools
[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
https://bugs.webkit.org/show_bug.cgi?id=115095
Reviewed by Antonio Gomes.
Use different subfolders under DumpRenderTree Temp folder for every
functionality (icon database, cache, localstorage, ...). This makes
sure there is no conflict between the functionalities.
In EFL's case, libsoup cache was causing problems for the icon
database if sharing the same folder.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
- 4:21 AM Changeset in webkit [149026] by
-
- 7 edits in trunk/Source/WebCore
[EFL] Fix build warnings caused by missing images attributes for default buttons
https://bugs.webkit.org/show_bug.cgi?id=114955
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-24
Reviewed by Gyuyoung Kim.
Added default image for each button from mediacontrol catalog.
No new tests, because there is no change in behavior.
- platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
- platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
- platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
- platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
- platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
- platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
- 3:54 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:53 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:50 AM Changeset in webkit [149025] by
-
- 2 edits in trunk/Source/WebKit2
Web Inspector: Add number to list from remote web inspector.
https://bugs.webkit.org/show_bug.cgi?id=115014
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.
- UIProcess/InspectorServer/front-end/inspectorPageIndex.html:
- 3:48 AM Changeset in webkit [149024] by
-
- 23 edits in trunk/LayoutTests
[EFL] Rebaselining after r148944
https://bugs.webkit.org/show_bug.cgi?id=115085
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
- platform/efl/TestExpectations:
- platform/efl/fast/table/giantRowspan-expected.txt:
- platform/efl/fast/table/giantRowspan2-expected.png:
- platform/efl/fast/table/giantRowspan2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8858-expected.png:
- platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/row_span-expected.png:
- platform/efl/tables/mozilla/core/row_span-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- 2:01 AM Changeset in webkit [149023] by
-
- 3 edits in trunk/LayoutTests
Fix test style issues following the commit of
https://bugs.webkit.org/show_bug.cgi?id=114412
Unreviewed gardening.
- css3/compositing/effect-background-blend-mode-color.html:
- css3/compositing/effect-background-blend-mode-color2.html:
- 1:44 AM Changeset in webkit [149022] by
-
- 2 edits in trunk/Source/WebKit2
--minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: decode is not a member of WebCore::TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=114367
Patch by Vlad Vasilyeu <vasvlad@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.
Include WebCoreArgumentCoders.h to WebEditorClientEfl.cpp from
WebKit2/Shared/ for successfully building with option --minimal
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
- 1:23 AM Changeset in webkit [149021] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix with gstreamer 0.10.x after r147555.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 1:11 AM Changeset in webkit [149020] by
-
- 6 edits6 copies in trunk
Roll depsHHHHChangeLogs.
- 1:09 AM Changeset in webkit [149019] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
https://bugs.webkit.org/show_bug.cgi?id=115092
Reviewed by Carlos Garcia Campos.
With the Skia backend, we had an optimization to detect solid color
layers. The Skia code has been purged, but these bits remained. With
BlackBerry::Platform::Graphics::PlatformGraphicsContext, only the solid
color will be drawn anyway, so we don't need to detect such layers at
the WebCore level. Fixed by removing the setContentsToColor flavor of
LayerTiler::TextureJob.
BlackBerry::WebKit::WebOverlay still uses
TextureCacheCompositingThread::textureForColor() so that one can stay
for now.
This was dead code so no new tests.
- platform/graphics/blackberry/LayerTile.cpp:
- platform/graphics/blackberry/LayerTile.h:
(LayerTile):
- platform/graphics/blackberry/LayerTiler.cpp:
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::performTileJob):
- platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::TextureJob::setContents):
(TextureJob):
- 12:43 AM Changeset in webkit [149018] by
-
- 4 edits in trunk/Source
[GTK] Move image decoders, some other GStreamer, Cairo and Soup sources to libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115050
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Add the image-decoders directory and its subdirectories to the list of header inclusion directories.
List the Cairo, GStreamer and Libsoup cppflags under the cppflags libPlatform uses for compiling its sources.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.list.am: Move the image decoders source files and a couple of GStreamer, Cairo and Libsoup source
files under the libPlatform's list of files to build. All of these are already free of platform layer violations.
- 12:25 AM Changeset in webkit [149017] by
-
- 3 edits in trunk/Source/WebKit2
Build break after r149004
https://bugs.webkit.org/show_bug.cgi?id=115091
Reviewed by Csaba Osztrogonác.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):
(WebKit): Add dummy method for new virtual method.
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk): Ditto.
Apr 23, 2013:
- 8:18 PM Changeset in webkit [149016] by
-
- 5 edits3 adds in trunk
DFG CFA filters CheckFunction in a really weird way, and assumes that the function's structure won't change
https://bugs.webkit.org/show_bug.cgi?id=115077
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
The filtering did three things that are unusual:
1) AbstractValue::filterByValue() assumed that the passed value's structure wouldn't change, in
the sense that at it assumed it could use that value's *current* structure to do structure
filtering. Filtering by structure only makes sense if you can prove that the given value will
always have that structure (for example by either using a watchpoing or emitting code that
checks that structure at run-time).
2) AbstractValue::filterByValue() and the CheckFunction case in AbstractState::executeEffects()
tried to invalidate the CFA based on whether the filtration led to an empty value. This is
well-intentioned, but it's not how the CFA currently works. It's inconsistent with other
parts of the CFA. We shouldn't introduce this feature into just one kind of filtration and
not have it elsewhere.
3) The attempt to detect when the value was empty was actually implemented incorrectly. It
relied on AbstractValue::validate(). That method says that a concrete value does not belong
to the abstract value if it has a different structure. This makes sense for the other place
where AbstractValue::validate() is called: during OSR entry, where we are talking about a
JSValue that we see *right now*. It doesn't make sense in the CFA, since in the CFA any
value we observe in the code is a value whose structure may change when the code starts
running, and so we cannot use the value's current structure to infer things about the code
when it starts running.
I fixed the above problems by (1) changing filterByValue() to not filter the structure, (2)
changing filterByValue() and the CheckFunction case to not invalidate the CFA, and (3)
making sure that nobody else was misusing AbstractValue::validate() (they weren't).
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::filterByValue):
LayoutTests:
Reviewed by Oliver Hunt.
This hilarious test fails prior to the rest of this patch.
- fast/js/dfg-check-function-change-structure-expected.txt: Added.
- fast/js/dfg-check-function-change-structure.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-check-function-change-structure.js: Added.
(foo):
(bar):
- 6:59 PM Changeset in webkit [149015] by
-
- 5 edits2 deletes in trunk/Source/WebCore
Remove TextFieldDecoration feature
https://bugs.webkit.org/show_bug.cgi?id=115068
Reviewed by Andreas Kling.
Only Chromium port used this feature.
- dom/Element.h: Remove isTextFieldDecoration.
- html/InputType.cpp:
(WebCore::InputType::destroyShadowSubtree):
Update a comment.
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
Remove call sites of willAddTextFieldDecorationsTo and addTextFieldDecorationsTo.
- html/shadow/TextFieldDecorationElement.cpp: Removed.
- html/shadow/TextFieldDecorationElement.h: Removed.
- page/ChromeClient.h:
(ChromeClient): Remove willAddTextFieldDecorationsTo and
addTextFieldDecorationsTo
- 6:23 PM Changeset in webkit [149014] by
-
- 2 edits in trunk/Source/JavaScriptCore
Default ParserError() initialiser doesn't initialise all fields
https://bugs.webkit.org/show_bug.cgi?id=115074
Reviewed by Joseph Pecoraro.
Only the jsc command prompt depended on this, but we'll fix it to
be on the safe side.
- parser/ParserError.h:
(JSC::ParserError::ParserError):
- 6:10 PM Changeset in webkit [149013] by
-
- 2 edits in trunk/Source/WebCore
Micro-optimize Length::initFromLength().
<http://webkit.org/b/115073>
From Blink r148621 by <timloh@chromium.org>:
This appears to improve html5-full-render by 1-2% on my system (gcc 4.6.3) by using memcpy
instead of copying members (and branching to copy the union).
- platform/Length.h:
(WebCore::Length::initFromLength):
- 6:06 PM Changeset in webkit [149012] by
-
- 2 edits in trunk/Source/WebCore
Add missing copyright header to ColorChooserClient.h
https://bugs.webkit.org/show_bug.cgi?id=115067
Reviewed by Andreas Kling.
- platform/ColorChooserClient.h:
This was added in 2011 by a Google employee.
http://trac.webkit.org/changeset/103168
- 5:55 PM Changeset in webkit [149011] by
-
- 2 edits in trunk/Source/WebCore
Call the correct superclass in RenderSlider::layout().
<http://webkit.org/b/115071>
From Blink r147850 by <cbiesinger@chromium.org>:
The superclass is RenderFlexibleBox, not RenderBlock.
- rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout):
- 5:53 PM Changeset in webkit [149010] by
-
- 5 edits6 adds in trunk
Add platform support for -webkit-background-blend-mode to CG context with background color
https://bugs.webkit.org/show_bug.cgi?id=114412
Patch by Mihai Tica <mitica@adobe.com> on 2013-04-23
Reviewed by Darin Adler.
Source/WebCore:
Tests: css3/compositing/effect-background-blend-mode-color.html, css3/compositing/effect-background-blend-mode-color2.html
This patch adds support for blending on background colors to the Core Graphics port of WebKit.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::fillRoundedRect):
- platform/graphics/GraphicsContext.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests:
Adding pixel tests for -webkit-background-blend-mode with bg-color
effect-background-blend-mode-color.html uses accelerated compositing
effect-background-blend-mode-color2.html uses software rendering
- css3/compositing/effect-background-blend-mode-color-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-color.html: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Added.
- css3/compositing/effect-background-blend-mode-color2-expected.txt: Added.
- css3/compositing/effect-background-blend-mode-color2.html: Added.
- platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Added.
- 5:33 PM Changeset in webkit [149009] by
-
- 2 edits in trunk/Source/WebCore
Remove an unused member variable erroneously added in r149007.
- rendering/LogicalSelectionOffsetCaches.h:
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
(LogicalSelectionOffsetCaches):
- 5:20 PM Changeset in webkit [149008] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Build break after r149004
https://bugs.webkit.org/show_bug.cgi?id=115066
Reviewed by Tim Horton.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::pageBackgroundTransparencyChanged):
Added dummy method for new virtual method.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost): Ditto.
- 5:18 PM Changeset in webkit [149007] by
-
- 9 edits1 add in trunk/Source/WebCore
logicalLeftSelectionGap and logicalRightSelectionGap call availableLogicalWidth() multiple times
https://bugs.webkit.org/show_bug.cgi?id=113479
Reviewed by David Hyatt.
Introduced LogicalSelectionOffsetCaches to cache the containing blocks and their logical left and right
selection offsets in computing selection gaps. An instance of this class stores the containing block for
each position type and caches their logical selection offsets when none of their block ancestors up until
its nearest selection root do no have any floating objects or regions and exclusions.
When blockSelectionGaps recurses to another level, it creates a new cache instance by "inheriting"
(like RenderStyle) from the old cache, overriding those containing blocks that are replaced by "this".
This eliminates the need to traverse containing block ancestors in RenderBlock::logicalLeftSelectionOffset
and RenderBlock::logicalRightSelectionOffset, and improves WebKit's performance by roughly 20%.
Performance Tests: Interactive/SelectAll.html
- GNUmakefile.list.am:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
- rendering/LogicalSelectionOffsetCaches.h: Added.
(WebCore::isContainingBlockCandidateForAbsolutelyPositionedObject): Moved from RenderObject.h.
(WebCore::isNonRenderBlockInline): Ditto.
(WebCore::containingBlockForFixedPosition): Extracted from RenderObject::containingBlock.
(WebCore::containingBlockForAbsolutePosition): Ditto.
(WebCore::containingBlockForObjectInFlow): Ditto.
(WebCore::LogicalSelectionOffsetCaches): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::ContainingBlockInfo): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::setBlock): Added. m_hasFloatsOrRegions is
or'ed with itself when ContainingBlockInfo is copy constructed since m_hasFloatsOrRegions needs be true
for a block when any of its containing block ancestors have floats or regions.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::block): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::cache): Added.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalLeftSelectionOffset): Added. Caches
the logical selection offset if it hasn't.
(WebCore::LogicalSelectionOffsetCaches::ContainingBlockInfo::logicalRightSelectionOffset): Ditto.
(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches): The first constructor is used
for a selection root. The second one is used for inheriting from another cache. In the latter case,
copy all containing block information except ones that need to be overridden by this block.
(WebCore::LogicalSelectionOffsetCaches::containingBlockInfo): Returns a ContainingBlockInfo based on
object's position value.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps): Exit before instantiating a new LogicalSelectionOffsetCaches
if there is no child to recurse.
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset): Use LogicalSelectionOffsetCaches to get its containing
block and its logical selection offset.
(WebCore::RenderBlock::logicalRightSelectionOffset): Ditto.
- rendering/RenderBlock.h:
(WebCore::RenderBlock):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock): Extracted code into LogicalSelectionOffsetCaches.h.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::lineSelectionGap):
- rendering/RootInlineBox.h:
(WebCore::RootInlineBox):
- 4:44 PM Changeset in webkit [149006] by
-
- 3 edits in trunk/Source/WebKit2
Turn off tiled drawing in the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=115064
Reviewed by Tim Horton.
We get little benefit from making the Web Inspector use tiled drawing;
it doesn't scroll the main frame, so doesn't benefit from the ScrollingCoordinator.
Not using tiled drawing also means that we won't make compositing
layers for position: -webkit-sticky, which avoids a number of issues
with compositing layer proliferation in the inspector.
Also turn off accelerated drawing, since that pref will force a single
compositing layer.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup):
- UIProcess/mac/WebInspectorProxyMac.mm:
- 4:35 PM Changeset in webkit [149005] by
-
- 5 edits in trunk/Source/WebCore
[Mac] forced subtitle track should change when audio track language changes
https://bugs.webkit.org/show_bug.cgi?id=115043
Reviewed by Jer Noble.
No new tests, it isn't possible to test this automatically because there is currently no way
to enable/disable audio tracks.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackGroup): Set m_forcedOrAutomaticSubtitleTrackLanguage.
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged): Call markCaptionAndSubtitleTracksAsUnconfigured
after a delay if the language of the primary audio track changes.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): markCaptionAndSubtitleTracksAsUnconfigured API change.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Take parameter to allow
the reconfiguration to happen after a delay to avoid doing it during a callback from the
media engine. Clear the ConfigureTextTracks bit in m_pendingActionFlags to cancel any pending
asynch configuration.
- html/HTMLMediaElement.h:
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Clean up logic.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Call characteristicChanged when
the primary audio track language changes.
- 4:02 PM Changeset in webkit [149004] by
-
- 6 edits in trunk/Source/WebKit2
When the web page transparency changes, DrawingAreaImpl needs to know about it
https://bugs.webkit.org/show_bug.cgi?id=115062
Reviewed by Tim Horton.
The non-composited contents layer owned by LayerTreeHostMac needs to
be marked as opaque or not depending on whether the WebPage draws
a background (or transparent background). It computed this at creation,
but did not dynamically update the state. Fix it so it does.
This fixes cases of garbage pixels in the Web Inspector toolbar area
in some configurations.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::pageBackgroundTransparencyChanged):
- WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
- WebProcess/WebPage/LayerTreeHost.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::pageBackgroundTransparencyChanged):
- 3:43 PM Changeset in webkit [149003] by
-
- 3 edits in trunk/Source/WebCore
[CSS Exclusions] Improve ExclusionPolygon smart pointer safety
https://bugs.webkit.org/show_bug.cgi?id=114984
Reviewed by Dirk Schulze.
Assign newly allocated objects to PassOwnPtrs as early as possible to reduce the
chances of future leaks. No new tests were added, this change adds no new functionality.
- rendering/ExclusionPolygon.cpp:
(WebCore::computeShapePaddingBounds):
(WebCore::computeShapeMarginBounds):
(WebCore::ExclusionPolygon::shapePaddingBounds):
(WebCore::ExclusionPolygon::shapeMarginBounds):
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
- 3:36 PM Changeset in webkit [149002] by
-
- 3 edits in trunk/Source/WebCore
Revert "Throttle resize events during live window resize."
<http://webkit.org/b/114292>
<rdar://problem/13411454>
<rdar://problem/13694839>
Reviewed by Geoffrey Garen.
It appears that this caused more glitches than it helped resize performance.
- page/FrameView.h:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::sendResizeEvent):
Turn the null-check of m_frame into an assertion since this method is
no longer called asynchronously.
(WebCore::FrameView::willEndLiveResize):
Ninja fix: call up to the closest superclass implementation.
- 3:34 PM Changeset in webkit [149001] by
-
- 10 edits1 copy1 move4 adds13 deletes in trunk
Global constructors should be configurable and not enumerable
https://bugs.webkit.org/show_bug.cgi?id=110573
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Update JSObject::deleteProperty() so that mark to set the property
value to undefined if it is in static hashtable of properties. The
previous code was not doing anything in this case and this meant
we could not remove builtin DOMWindow properties such as
"ProgressEvent" even if marked as Deletable.
- runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
- runtime/Lookup.h:
(JSC):
(JSC::putEntry):
(JSC::lookupPut):
Source/WebCore:
Update JSC Code generator so that global constructors now have the following
attributes:
{ Writable: true, Enumerable: false, Configurable: true }
instead of previously:
{ Writable: true, Enumerable: true, Configurable: false }
The new behavior is according to the Web IDL specification (section 4.4):
http://dev.w3.org/cvsweb/~checkout~/2006/webapi/WebIDL/Overview.html?rev=1.617;content-type=text%2Fhtml#es-interfaces
This also matches the behavior of Firefox.
Tests: fast/js/global-constructors-attributes.html
fast/js/global-constructors-deletable.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
LayoutTests:
Add new tests to make sure that the global constructors have the
right attributes and to check that they are 'Deletable'.
- canvas/philip/tests/type.delete-expected.txt: Removed.
- canvas/philip/tests/type.delete.html: Removed. It was checking that global constructor
could NOT be deleted, which is no longer according to the Web IDL specification.
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/script-tests/constructed-objects-prototypes.js: Update test to hardcode a few
global constructors as they are no longer enumerable.
- fast/js/getOwnPropertyDescriptor-expected.txt:
- fast/js/global-constructors.html: Removed. It was relying on the global constructors
to be 'Enumerable', which is not to the latest Web IDL specification.
- fast/js/global-constructors-attributes-expected.txt: Added.
- fast/js/global-constructors-attributes.html: Added.
- fast/js/global-constructors-deletable-expected.txt: Added.
- fast/js/global-constructors-deletable.html: Added.
- fast/js/global-constructors-expected.txt: Removed.
- fast/js/resources/getOwnPropertyDescriptor.js:
- fast/js/script-tests/global-constructors-attributes.js: Added.
- fast/js/script-tests/global-constructors-deletable.js: Added.
- fast/js/script-tests/global-constructors.js: Removed.
- platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
- platform/efl/fast/js/global-constructors-expected.txt: Removed.
- platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
- platform/gtk/fast/js/global-constructors-expected.txt: Removed.
- platform/mac/fast/js/global-constructors-expected.txt: Removed.
- platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
- platform/qt/fast/js/global-constructors-expected.txt: Removed.
- platform/win/fast/dom/constructed-objects-prototypes-expected.txt: Removed.
- platform/win/fast/js/global-constructors-expected.txt: Removed.
- 3:23 PM Changeset in webkit [149000] by
-
- 2 edits in trunk/Tools
Unreviewed. Remove myself from watchlist.
- Scripts/webkitpy/common/config/watchlist:
- 3:18 PM Changeset in webkit [148999] by
-
- 16 edits3 adds in trunk
Source/JavaScriptCore: Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057
Reviewed by Filip Pizlo.
This covers a few cases like:
- while (true) { }
- while (1) { }
- if (x) break;
- if (x) continue;
- if (boolean_expr == boolean_const) { }
- if (boolean_expr == 1_or_0) { }
- if (bitop == 1_or_0) { }
This also works, but will bring shame on your family:
- while ("hello world") { }
No change on the benchmarks we track, but a 2.5X speedup on a microbenchmark
that uses these techniques.
- JavaScriptCore.order: Order!
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::shouldEmitDebugHooks): Updated ancillary code
for interface simplifications.
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstantNode::emitBytecodeInConditionContext): Constants can
jump unconditionally when used within a condition context.
(JSC::ConstantNode::emitBytecode):
(JSC::StringNode::jsValue): Gave constants a common base class so I
could implement their codegen just once.
(JSC::BinaryOpNode::emitBytecodeInConditionContext):
(JSC::canFoldToBranch):
(JSC::BinaryOpNode::tryFoldToBranch): Fold (!/=)= and (!/=)== where
appropriate. A lot of cases are not appropriate because of the surprising
type conversion semantics of ==. For example, if (number == true) { } is
not the same as if (number) { } because the former will up-convert true
to number and then do numeric comparison.
(JSC::singleStatement):
(JSC::IfElseNode::tryFoldBreakAndContinue):
(JSC::IfElseNode::emitBytecode):
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget): Fold "if (expression) break" and
"if (expression) continue" into direct jumps from expression.
- parser/ASTBuilder.h:
(ASTBuilder):
(JSC::ASTBuilder::createIfStatement):
- parser/NodeConstructors.h:
(JSC::ConstantNode::ConstantNode):
(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfElseNode::IfElseNode):
- parser/Nodes.h:
(JSC::ExpressionNode::isConstant):
(JSC::ExpressionNode::isBoolean):
(JSC::StatementNode::isBreak):
(JSC::StatementNode::isContinue):
(ConstantNode):
(JSC::ConstantNode::isPure):
(JSC::ConstantNode::isConstant):
(NullNode):
(JSC::NullNode::jsValue):
(JSC::BooleanNode::value):
(JSC::BooleanNode::isBoolean):
(JSC::BooleanNode::jsValue):
(JSC::NumberNode::value):
(NumberNode):
(JSC::NumberNode::jsValue):
(StringNode):
(BinaryOpNode):
(IfElseNode):
(ContinueNode):
(JSC::ContinueNode::isContinue):
(BreakNode):
(JSC::BreakNode::isBreak):
- parser/Parser.cpp:
(JSC::::parseIfStatement):
- parser/ResultType.h:
(JSC::ResultType::definitelyIsBoolean):
(ResultType):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
- runtime/JSCell.h:
- runtime/JSCellInlines.h:
(JSC::JSCell::pureToBoolean): Updated for interface changes above.
Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057
Reviewed by Filip Pizlo.
Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.
- wtf/TriState.h:
(WTF::triState):
(WTF):
LayoutTests: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057
Reviewed by Filip Pizlo.
Added a performance test for interesting branch types.
- fast/js/regress/branch-fold-expected.txt: Added.
- fast/js/regress/branch-fold.html: Added.
- fast/js/regress/script-tests/branch-fold.js: Added.
- 3:01 PM Changeset in webkit [148998] by
-
- 4 edits4 adds in trunk
Don't create compositing layers for sticky position unless using the ScrollingCoordinator
https://bugs.webkit.org/show_bug.cgi?id=115060
Source/WebCore:
Reviewed by Tim Horton.
Creating compositing layers for sticky position elements is only useful
when we're using a ScrollingCoordinator, so don't create them if
we're not in a frame that uses a scrolling coordinator.
Tests: compositing/layer-creation/no-compositing-for-sticky.html
platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
Reviewed by Tim Horton.
Tests that we create layers for sticky position when in tiled drawing mode,
and that we have no layers when not.
- compositing/layer-creation/no-compositing-for-sticky-expected.txt: Added.
- compositing/layer-creation/no-compositing-for-sticky.html: Added.
- platform/mac-wk2/tiled-drawing/sticky/sticky-layers-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/sticky/sticky-layers.html: Added.
- 2:59 PM Changeset in webkit [148997] by
-
- 34 edits1 copy2 adds in trunk
'length' property of DOM bindings functions returns wrong value
https://bugs.webkit.org/show_bug.cgi?id=110569
Reviewed by Geoffrey Garen.
Source/WebCore:
Make the 'length' property of Function objects and Interface
objects behave according to the latest Web IDL specification
editor draft:
http://dev.w3.org/2006/webapi/WebIDL/#es-interface-call
http://dev.w3.org/2006/webapi/WebIDL/#es-operations
As a result, only mandatory arguments are taken into account
when computing the value for the 'length' property. This
behavior is consistent with Firefox and Blink.
Tests: fast/js/constructor-length.html
fast/js/function-length.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateConstructorHelperMethods):
Update the JSC code generator to only account for mandatory parameters
when computing the value for the 'length' property of Function objects
and constructors.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::finishCreation):
(WebCore):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
(WebCore):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
Rebaseline bindings tests results.
- fileapi/Blob.idl:
Remove 'ConstructorParameters=2' extended attribute as the correct value
is 0, given that a Blob can be constructed without parameter.
- html/canvas/DataView.idl:
Update ConstructorParameters extended attribute value from 3 to 1 as only
one of the 3 parameters is mandatory.
- html/canvas/Float32Array.idl:
- html/canvas/Float64Array.idl:
- html/canvas/Int16Array.idl:
- html/canvas/Int32Array.idl:
- html/canvas/Int8Array.idl:
- html/canvas/Uint16Array.idl:
- html/canvas/Uint32Array.idl:
- html/canvas/Uint8Array.idl:
- html/canvas/Uint8ClampedArray.idl:
Remove 'ConstructorParameters=1' extended attribute from interfaces using
'ConstructorTemplate=TypedArray' as the bindings generator now properly
compute the number of constructor parameters for such interfaces.
- page/WebKitPoint.idl:
Remove 'ConstructorParameters=2' extended attribute as the correct value
should be 0, given that a WebKitPoint can be constructed without parameters.
LayoutTests:
Update fast/js/constructor-length.html test case now that only
mandatory arguments are considered for the constructor length.
Also add a new fast/js/function-length.html test to make sure
that the 'length' property of Function objects from DOM
bindings behaves according to the Web IDL specification as
this was not covered by existing tests.
- fast/files/blob-constructor-expected.txt: Rebaseline.
- fast/files/script-tests/blob-constructor.js: Update test now that Blob constructor
length is 0 instead of 2.
- fast/js/constructor-length.html:
- fast/js/function-length-expected.txt: Added.
- fast/js/function-length.html: Added.
- platform/blackberry/fast/js/constructor-length-expected.txt: Rebaseline.
- platform/efl/TestExpectations: Unskip fast/js/constructor-length.html for EFL port.
- platform/efl/fast/js/constructor-length-expected.txt: Copied from LayoutTests/platform/mac/fast/js/constructor-length-expected.txt.
- platform/gtk/fast/js/constructor-length-expected.txt: Rebaseline.
- platform/mac/fast/js/constructor-length-expected.txt: Rebaseline.
- platform/qt/fast/js/constructor-length-expected.txt: Rebaseline.
- 2:58 PM Changeset in webkit [148996] by
-
- 6 edits in trunk
NRWT: confusing warning about a line being in a Skipped file when it is really just listed
in _missing_symbol_to_skipped_tests in base.py
https://bugs.webkit.org/show_bug.cgi?id=108884
Patch by Jessie Berlin <jberlin@apple.com> on 2013-04-23
Reviewed by Tim Horton.
Tools:
Remove symbol-based skipped list detection.
- Scripts/webkitpy/port/base.py:
(Port._missing_feature_to_skipped_tests):
(Port._skipped_tests_for_unsupported_features):
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_path_to_test_expectations_file):
LayoutTests:
Explicitly skip the mhtml tests on the Mac and Win ports.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 2:56 PM Changeset in webkit [148995] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r148922): Crash opening web archives or loading web pages
https://bugs.webkit.org/show_bug.cgi?id=115061
<rdar://problem/13714228>
Reviewed by Sam Weinig.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
Calling ResourceLoader::didReceiveResponse can cause the WebResourceLoader object to go away,
so protect it here and guard against a null core loader.
- 2:35 PM Changeset in webkit [148994] by
-
- 1 edit1 delete in trunk/Source/WebKit
Remove the WebKit layer of wxWebKit
https://bugs.webkit.org/show_bug.cgi?id=115006
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Anders Carlsson.
The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.
- wx/WebBrowserShell.cpp: Removed.
- wx/WebBrowserShell.h: Removed.
- wx/WebDOMSelection.cpp: Removed.
- wx/WebDOMSelection.h: Removed.
- wx/WebEdit.cpp: Removed.
- wx/WebEdit.h: Removed.
- wx/WebFrame.cpp: Removed.
- wx/WebFrame.h: Removed.
- wx/WebFramePrivate.h: Removed.
- wx/WebKitDefines.h: Removed.
- wx/WebKitSupport/ChromeClientWx.cpp: Removed.
- wx/WebKitSupport/ChromeClientWx.h: Removed.
- wx/WebKitSupport/ContextMenuClientWx.cpp: Removed.
- wx/WebKitSupport/ContextMenuClientWx.h: Removed.
- wx/WebKitSupport/DragClientWx.cpp: Removed.
- wx/WebKitSupport/DragClientWx.h: Removed.
- wx/WebKitSupport/EditCommandWx.h: Removed.
- wx/WebKitSupport/EditorClientWx.cpp: Removed.
- wx/WebKitSupport/EditorClientWx.h: Removed.
- wx/WebKitSupport/FrameLoaderClientWx.cpp: Removed.
- wx/WebKitSupport/FrameLoaderClientWx.h: Removed.
- wx/WebKitSupport/FrameNetworkingContextWx.h: Removed.
- wx/WebKitSupport/InspectorClientWx.cpp: Removed.
- wx/WebKitSupport/InspectorClientWx.h: Removed.
- wx/WebSettings.cpp: Removed.
- wx/WebSettings.h: Removed.
- wx/WebView.cpp: Removed.
- wx/WebView.h: Removed.
- wx/WebViewPrivate.h: Removed.
- wx/bindings/python/samples/simple.py: Removed.
- wx/bindings/python/webview.i: Removed.
- wx/bindings/python/wscript: Removed.
- wx/wscript: Removed.
- 2:24 PM Changeset in webkit [148993] by
-
- 5 edits in trunk/Source/WebCore
Minor String usage fixes in WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=115021
Reviewed by Andreas Kling.
Use ASCIILiteral when possible + minor fixes.
- platform/ContentType.cpp:
(WebCore::ContentType::codecs):
- platform/ContentType.h:
(ContentType):
- platform/Decimal.cpp:
(WebCore::Decimal::toString):
- platform/KURL.cpp:
(WebCore::KURL::setProtocol):
- 2:18 PM Changeset in webkit [148992] by
-
- 4 edits6 adds in trunk
Pick up color and mat values in custom shaders
https://bugs.webkit.org/show_bug.cgi?id=115046
Reviewed by Dean Jackson.
Source/WebCore:
The custom filter functions accept color values and mat2-4 functions
as parameter types. These were implemented in CSS already.
This patch picks up the values and applies them as uniforms to the
custom shader program.
Tests: css3/filters/custom/custom-filter-color.html
css3/filters/custom/custom-filter-matN.html
- platform/graphics/filters/CustomFilterRenderer.cpp:
(WebCore::CustomFilterRenderer::bindProgramColorParameters): Set uniform for color values.
(WebCore):
(WebCore::CustomFilterRenderer::bindProgramMatrixParameters): Set uniform for mat2-4 values.
(WebCore::CustomFilterRenderer::bindProgramParameters): Call color and matrix functions.
- platform/graphics/filters/CustomFilterRenderer.h:
(WebCore):
(CustomFilterRenderer):
LayoutTests:
Test that the CSS defined color values and mat2-4 functions get
set as uniforms in shader programs.
- css3/filters/custom/custom-filter-color-expected.html: Added.
- css3/filters/custom/custom-filter-color.html: Added.
- css3/filters/custom/custom-filter-matN-expected.html: Added.
- css3/filters/custom/custom-filter-matN.html: Added.
- 2:04 PM Changeset in webkit [148991] by
-
- 2 edits in trunk/Source/WebKit2
Web process crashes at WebPage::determinePrimarySnapshottedPlugInTimerFired + 8
https://bugs.webkit.org/show_bug.cgi?id=115056
<rdar://problem/13719543>
Reviewed by Simon Fraser.
Stop the primary plugin detection timer if the WebPage is torn down.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
- 1:58 PM Changeset in webkit [148990] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant code in ViewportArguments::resolve
https://bugs.webkit.org/show_bug.cgi?id=115054
Patch by Jacky Jiang <zhajiang@blackberry.com>.
Reviewed by Kenneth Rohde Christiansen.
Remove redundant code "result.orientation = orientation;".
- dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
- 1:54 PM Changeset in webkit [148989] by
-
- 2 edits in trunk/Source/JavaScriptCore
Simplify the baseline JIT loop hint call site.
https://bugs.webkit.org/show_bug.cgi?id=115052.
Reviewed by Geoffrey Garen.
Moved the watchdog timer check after the JIT optimization check. This
ensures that the JIT opimization counter is incremented on every loop
hint even if the watchdog timer fires.
Removed the code that allows the JIT OSR to happen if the watchdog
timer fires but does not result in a termination. It is extremely rare
that the JIT optimization counter would trigger an OSR on the same pass
as when the watchdog timer fire. If it does happen, we'll simply hold
off on servicing the watchdog timer until the next pass (because it's
not time critical).
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- 1:51 PM Changeset in webkit [148988] by
-
- 3 edits2 adds in trunk
Tiled layers clipped inside nested transform/preserve-3d hierarchies
https://bugs.webkit.org/show_bug.cgi?id=115044
Source/WebCore:
Reviewed by Dean Jackson.
The optimization added in r139479 to call move() for integral translation
transforms hit a bug in TransformState::move(). If m_accumulatedTransform is
not null, we have to apply it.
Test: compositing/visible-rect/flipped-preserve-3d.html
- platform/graphics/transforms/TransformState.cpp:
(WebCore::TransformState::move):
LayoutTests:
Reviewed by Dean Jackson.
Testcase that dumps visible rects for tiled layers inside nested
transformed/preserve-3d hierarchies.
- compositing/visible-rect/flipped-preserve-3d-expected.txt: Added.
- compositing/visible-rect/flipped-preserve-3d.html: Added.
- 1:39 PM Changeset in webkit [148987] by
-
- 8 edits22 adds in trunk
Ctrl+Shift+Right in Windows should select the spacing after the word
https://bugs.webkit.org/show_bug.cgi?id=110487
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: editing/deleting/smart-editing-disabled-win.html
editing/execCommand/remove-format-multiple-elements-win.html
editing/execCommand/toggle-link-win.html
editing/execCommand/toggle-unlink-win.html
editing/selection/extend-selection-enclosing-block-win.html
editing/style/make-text-writing-direction-inline-win.html
editing/style/push-down-font-styles-win.html
editing/style/push-down-implicit-styles-around-list-win.html
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::nextWordPositionForPlatform): New method
that takes platform-specific editing behaviour in order to decide
what the next word position is, that is, for Windows, skip
spacing, for all other platforms, behave as currently.
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft): Use the new method
in all of the above.
- editing/FrameSelection.h: Declare the new method.
LayoutTests:
- editing/deleting/smart-editing-disabled-win-expected.txt: Added.
- editing/deleting/smart-editing-disabled-win.html: Added.
- editing/execCommand/query-command-state-expected.txt:
- editing/execCommand/remove-format-multiple-elements-win-expected.txt: Added.
- editing/execCommand/remove-format-multiple-elements-win.html: Added.
- editing/execCommand/script-tests/query-command-state.js:
(runTests): Update to reflect new editing behavior in Windows.
- editing/execCommand/script-tests/remove-format-multiple-elements-win.js: Added.
- editing/execCommand/script-tests/toggle-link-win.js: Added.
- editing/execCommand/script-tests/toggle-unlink-win.js: Added.
- editing/execCommand/toggle-link-win-expected.txt: Added.
- editing/execCommand/toggle-link-win.html: Added.
- editing/execCommand/toggle-unlink-win-expected.txt: Added.
- editing/execCommand/toggle-unlink-win.html: Added.
- editing/selection/extend-selection-enclosing-block-win-expected.txt: Added.
- editing/selection/extend-selection-enclosing-block-win.html: Added.
- editing/selection/resources/extend-selection.js:
(extendSelectionWithinBlockWin): Method to test behavior in windows.
(extendAndLogSelectionWithinBlock): Add test support for Windows.
- editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
Add test support for Windows editing behavior.
- editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
- editing/style/make-text-writing-direction-inline-win.html: Added.
- editing/style/push-down-font-styles-win-expected.txt: Added.
- editing/style/push-down-font-styles-win.html: Added.
- editing/style/push-down-implicit-styles-around-list-win-expected.txt: Added.
- editing/style/push-down-implicit-styles-around-list-win.html: Added.
- editing/style/script-tests/make-text-writing-direction-inline-win.js: Added.
- editing/style/script-tests/push-down-font-styles-win.js: Added.
- editing/style/script-tests/push-down-implicit-styles-around-list-win.js: Added.
- 1:24 PM Changeset in webkit [148986] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
https://bugs.webkit.org/show_bug.cgi?id=115053
Unreviewed gardening.
- platform/qt/TestExpectations: Skip failing tests.
- 1:17 PM Changeset in webkit [148985] by
-
- 4 edits in trunk/Source
AppleWin build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- WTF.vcproj/WTF.vcproj:
- 12:59 PM Changeset in webkit [148984] by
-
- 3 edits in trunk/Source/WebCore
Inline SelectorQuery::matches, SelectorQuery::queryAll, SelectorQuery::queryFirst
https://bugs.webkit.org/show_bug.cgi?id=115012
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.
Each of these function has a single call site:
-SelectorQuery::matches from Element::webkitMatchesSelector.
-SelectorQuery::queryAll from Node::querySelectorAll.
-SelectorQuery::queryFirst from Node::querySelector.
Having a dedicated method to jump to was a little overkill.
- dom/SelectorQuery.cpp:
- dom/SelectorQuery.h:
(WebCore::SelectorQuery::matches):
(WebCore::SelectorQuery::queryAll):
(WebCore::SelectorQuery::queryFirst):
- 12:51 PM Changeset in webkit [148983] by
-
- 1 edit7 deletes in trunk/Source/WebCore
Remove wxWebKit's folders from WebCore
https://bugs.webkit.org/show_bug.cgi?id=115007
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.
The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.
- accessibility/wx/AccessibilityObjectWx.cpp: Removed.
- editing/wx/EditorWx.cpp: Removed.
- page/wx/DragControllerWx.cpp: Removed.
- page/wx/EventHandlerWx.cpp: Removed.
- platform/graphics/wx/ColorWx.cpp: Removed.
- platform/graphics/wx/FloatRectWx.cpp: Removed.
- platform/graphics/wx/FontCacheWx.cpp: Removed.
- platform/graphics/wx/FontCustomPlatformData.cpp: Removed.
- platform/graphics/wx/FontCustomPlatformData.h: Removed.
- platform/graphics/wx/FontPlatformData.h: Removed.
- platform/graphics/wx/FontPlatformDataWx.cpp: Removed.
- platform/graphics/wx/FontPlatformDataWxMac.mm: Removed.
- platform/graphics/wx/FontWx.cpp: Removed.
- platform/graphics/wx/GlyphMapWx.cpp: Removed.
- platform/graphics/wx/GradientWx.cpp: Removed.
- platform/graphics/wx/GraphicsContextWx.cpp: Removed.
- platform/graphics/wx/IconWx.cpp: Removed.
- platform/graphics/wx/ImageBufferDataWx.h: Removed.
- platform/graphics/wx/ImageBufferWx.cpp: Removed.
- platform/graphics/wx/ImageWx.cpp: Removed.
- platform/graphics/wx/IntPointWx.cpp: Removed.
- platform/graphics/wx/IntRectWx.cpp: Removed.
- platform/graphics/wx/IntSizeWx.cpp: Removed.
- platform/graphics/wx/PathWx.cpp: Removed.
- platform/graphics/wx/SimpleFontDataWx.cpp: Removed.
- platform/graphics/wx/TransformationMatrixWx.cpp: Removed.
- platform/image-decoders/wx/ImageDecoderWx.cpp: Removed.
- platform/wx/ClipboardWx.cpp: Removed.
- platform/wx/ClipboardWx.h: Removed.
- platform/wx/ContextMenuItemWx.cpp: Removed.
- platform/wx/ContextMenuWx.cpp: Removed.
- platform/wx/CursorWx.cpp: Removed.
- platform/wx/DragDataWx.cpp: Removed.
- platform/wx/DragImageWx.cpp: Removed.
- platform/wx/EventLoopWx.cpp: Removed.
- platform/wx/FileSystemWx.cpp: Removed.
- platform/wx/KeyEventWin.cpp: Removed.
- platform/wx/KeyboardEventWx.cpp: Removed.
- platform/wx/LanguageWx.cpp: Removed.
- platform/wx/LocalDC.h: Removed.
- platform/wx/LocalizedStringsWx.cpp: Removed.
- platform/wx/LoggingWx.cpp: Removed.
- platform/wx/MimeTypeRegistryWx.cpp: Removed.
- platform/wx/MouseEventWx.cpp: Removed.
- platform/wx/MouseWheelEventWx.cpp: Removed.
- platform/wx/PasteboardWx.cpp: Removed.
- platform/wx/PopupMenuWx.cpp: Removed.
- platform/wx/PopupMenuWx.h: Removed.
- platform/wx/RenderThemeWx.cpp: Removed.
- platform/wx/RunLoopWx.cpp: Removed.
- platform/wx/SSLKeyGeneratorWx.cpp: Removed.
- platform/wx/ScreenWx.cpp: Removed.
- platform/wx/ScrollViewWx.cpp: Removed.
- platform/wx/ScrollbarThemeWx.cpp: Removed.
- platform/wx/ScrollbarThemeWx.h: Removed.
- platform/wx/SearchPopupMenuWx.cpp: Removed.
- platform/wx/SearchPopupMenuWx.h: Removed.
- platform/wx/SharedBufferWx.cpp: Removed.
- platform/wx/SharedTimerWx.cpp: Removed.
- platform/wx/SoundWx.cpp: Removed.
- platform/wx/SystemTimeWx.cpp: Removed.
- platform/wx/TemporaryLinkStubs.cpp: Removed.
- platform/wx/TextBreakIteratorInternalICUWx.cpp: Removed.
- platform/wx/WidgetWx.cpp: Removed.
- platform/wx/wxcode/cairo/non-kerned-drawing.cpp: Removed.
- platform/wx/wxcode/fontprops.cpp: Removed.
- platform/wx/wxcode/fontprops.h: Removed.
- platform/wx/wxcode/gdiplus/non-kerned-drawing.cpp: Removed.
- platform/wx/wxcode/gtk/fontprops.cpp: Removed.
- platform/wx/wxcode/gtk/non-kerned-drawing.cpp: Removed.
- platform/wx/wxcode/gtk/scrollbar_render.cpp: Removed.
- platform/wx/wxcode/mac/carbon/fontprops.mm: Removed.
- platform/wx/wxcode/mac/carbon/non-kerned-drawing.cpp: Removed.
- platform/wx/wxcode/mac/carbon/scrollbar_render.cpp: Removed.
- platform/wx/wxcode/non-kerned-drawing.h: Removed.
- platform/wx/wxcode/scrollbar_render.h: Removed.
- platform/wx/wxcode/win/fontprops.cpp: Removed.
- platform/wx/wxcode/win/non-kerned-drawing.cpp: Removed.
- platform/wx/wxcode/win/scrollbar_render.cpp: Removed.
- plugins/wx/PluginDataWx.cpp: Removed.
- 12:44 PM Changeset in webkit [148982] by
-
- 3 edits in trunk/Source/WebCore
AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 12:29 PM WebKitGTK/2.0.x edited by
- gcc-related build fixes (diff)
- 12:28 PM Changeset in webkit [148981] by
-
- 2 edits in trunk/Source/WTF
Remove unused code of RefCounted after chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115009
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Ryosuke Niwa.
- wtf/RefCounted.h:
(WTF::RefCountedBase::refCount):
(RefCountedBase):
It looks like addressOfCount() is no longer needed.
Also change the type back to unsigned as it make more sense.
- 12:21 PM Changeset in webkit [148980] by
-
- 10 edits4 deletes in trunk/Tools
Remove wxWebKit support from the Tools
https://bugs.webkit.org/show_bug.cgi?id=115005
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-23
Reviewed by Andreas Kling.
The wxWebKit port is no longer actively maintained by Kevin
on webkit.org. Remove the code until new maintainers resume the work.
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/config.h:
- DumpRenderTree/wscript: Removed.
- DumpRenderTree/wx/DumpRenderTreeWx.cpp: Removed.
- DumpRenderTree/wx/DumpRenderTreeWx.h: Removed.
- DumpRenderTree/wx/GCControllerWx.cpp: Removed.
- DumpRenderTree/wx/TestRunnerWx.cpp: Removed.
- DumpRenderTree/wx/WorkQueueItemWx.cpp: Removed.
- Scripts/build-dumprendertree:
- Scripts/build-jsc:
(buildMyProject):
- Scripts/build-webkit:
- Scripts/old-run-webkit-tests:
- Scripts/run-launcher:
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(determineConfigurationProductDir):
(determinePassedArchitecture):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
- Scripts/webkitpy/common/config/contributionareas.py:
- waf/build/build_utils.py: Removed.
- waf/build/settings.py: Removed.
- waf/build/waf_extensions.py: Removed.
- waf/build/wxpresets.py: Removed.
- wx/browser/browser.cpp: Removed.
- wx/browser/wscript: Removed.
- wx/install-unix-extras: Removed.
- wx/packaging/build-debian-installer.py: Removed.
- wx/packaging/build-mac-installer.py: Removed.
- wx/packaging/build-win-installer.py: Removed.
- wx/packaging/debian/changelog: Removed.
- wx/packaging/debian/compat: Removed.
- wx/packaging/debian/control: Removed.
- wx/packaging/debian/copyright: Removed.
- wx/packaging/debian/python-webkitwx.install: Removed.
- wx/packaging/debian/rules: Removed.
- wx/packaging/wxWebKitInstaller.iss.in: Removed.
- 12:15 PM Changeset in webkit [148979] by
-
- 2 edits in trunk/Source/WTF
RetainPtr.h should compile with -Wshorten-64-to-32
<http://webkit.org/b/115047>
Reviewed by Anders Carlsson.
Fixes the following warning:
RetainPtr.h:318:20: error: implicit conversion loses integer precision: 'CFHashCode' (aka 'unsigned long') to 'unsigned int' [-Werror,-Wshorten-64-to-32]
return CFHash(o.get());
- wtf/RetainPtr.h:
(WTF::RetainPtrObjectHash::hash): Cast return value of CFHash()
to unsigned. This has no effect on 32-bit architectures, but
takes the lower 32-bits of the CFHashCode (unsigned long) on
64-bit architectures, which is what happens implicitly now.
- 12:12 PM Changeset in webkit [148978] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Invalid assert in InputHandler::requestCheckingOfString()
https://bugs.webkit.org/show_bug.cgi?id=114952
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-23
Reviewed by Rob Buis.
Do not assume that Batch requests are only created whe input field
is focused, the Editor can also create Batch requests when pasting
a selection.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
Remove invalid assert.
- 12:09 PM Changeset in webkit [148977] by
-
- 7 edits3 deletes in trunk/LayoutTests
Remove fast/js/i18n-bindings-locale.html
https://bugs.webkit.org/show_bug.cgi?id=115024
Patch by Seokju Kwon <Seokju Kwon> on 2013-04-23
Reviewed by Geoffrey Garen.
Remove V8-i18n-extension test(r78095) from all ports.
- fast/js/i18n-bindings-locale-expected.txt: Removed.
- fast/js/i18n-bindings-locale.html: Removed.
- fast/js/script-tests/i18n-bindings-locale.js: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 11:57 AM Changeset in webkit [148976] by
-
- 4 edits in trunk/Source/WebCore
AppleWin build fix.
- inspector/InspectorAllInOne.cpp:
- inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::create):
(WebCore):
- inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
- 11:23 AM Changeset in webkit [148975] by
-
- 17 edits2 adds in trunk
[CSS Exclusions] shape-inside overflow should be pushed to the outside of the content box
https://bugs.webkit.org/show_bug.cgi?id=114526
Reviewed by David Hyatt.
Source/WebCore:
The specification has changed to define shape-outside as the inverse of an exclusion. Overflowing content
should not overlap the shape, and it should be pushed outside the content box. This change affects several
tests, but only one new has been added. In this change I'm not intended to include the behavior change for
shape-inside on CSS Regions, I'm going to fix that in a follow up patch.
Tests: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Modified.
fast/exclusions/shape-inside/shape-inside-bottom-edge.html: Modified.
fast/exclusions/shape-inside/shape-inside-empty.html: Modified.
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
fast/exclusions/shape-inside/shape-inside-overflow.html: Modified.
fast/exclusions/shape-inside/shape-inside-percentage.html: Modified.
fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html: Modified.
- rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::clearSegments): Shape-outside's code uses shape-inside codepaths, when that happens we need to provide a
way to reset the m_segments member.
(WebCore::ExclusionShapeInfo::shapeContainingBlockHeight): The containing block's height is stored in m_shapeLogicalHeight, I added a
function to get this value when we need it to calculate the content box's bottom position.
(ExclusionShapeInfo):
(WebCore::ExclusionShapeInfo::lineOverlapsShapeBounds):
(WebCore::ExclusionShapeInfo::lineWithinShapeBounds): Add function to test whether a whole line is within a shape or not.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Overflowing content should start under the content box.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Since we use shape-inside codepaths for shape-outside in layoutRunsAndFloatsInRange function
and for shape-outside is not a requirement to check the line's bottom position is within the shape we might end up with some extra segments here.
In this case we should clear segments, since we don't want to apply any horizontal offsets on the overflowing content.
LayoutTests:
Update and add tests for the new behavior.
- fast/exclusions/resources/rounded-rectangle.js:
(generateString): Modify the function to not generate overflow content.
- fast/exclusions/shape-inside/shape-inside-bottom-edge-expected.html:
- fast/exclusions/shape-inside/shape-inside-bottom-edge.html:
- fast/exclusions/shape-inside/shape-inside-empty-expected.html:
- fast/exclusions/shape-inside/shape-inside-empty.html:
- fast/exclusions/shape-inside/shape-inside-overflow-expected.html:
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html: Added.
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html: Added.
- fast/exclusions/shape-inside/shape-inside-overflow.html:
- fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
- fast/exclusions/shape-inside/shape-inside-percentage.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004-expected.html:
- fast/exclusions/shape-inside/shape-inside-rounded-rectangle-004.html:
- fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html:
- fast/regions/shape-inside/shape-inside-on-additional-regions.html: This test is not intented to test the overflow behavior from
shape-inside on regions, so I set the shape's height to the container's height.
- 11:00 AM Changeset in webkit [148974] by
-
- 3 edits in trunk/Source/JavaScriptCore
Objective-C API: Update public header documentation
https://bugs.webkit.org/show_bug.cgi?id=114841
Reviewed by Geoffrey Garen.
Added documentation for the newly added object lifetime-related stuff.
- API/JSManagedValue.h:
- API/JSVirtualMachine.h:
- 10:50 AM Changeset in webkit [148973] by
-
- 2 edits2 adds in trunk/LayoutTests
checkLayout() should error out if no data-expected* attributes were found
https://bugs.webkit.org/show_bug.cgi?id=114900
Reviewed by Ojan Vafai.
If checkLayout() doesn't find any attributes checking the node's layout then error out
instead of assuming the test has passed. This will ensure data-* attributes containing
typos don't register as a pass.
- fast/check-layout-error-no-attributes-expected.txt: Added.
- fast/check-layout-error-no-attributes.html: Added.
- resources/check-layout.js:
(.):
- 10:08 AM Changeset in webkit [148972] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Simplify BackForwardListBlackBerry::clear
https://bugs.webkit.org/show_bug.cgi?id=115029
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.
Simplify the implementation of the clear method. Instead of asking
the WebCore implementation to search each item and delete it, set
the capacity of the list to zero directly, which will do the same
thing but more efficiently.
No change in behavior, no new tests.
- WebCoreSupport/BackForwardListBlackBerry.cpp:
(WebCore::BackForwardListBlackBerry::clear):
- 9:20 AM Changeset in webkit [148971] by
-
- 2 edits in trunk/Tools
[Qt] Fix test_build_check for Qt on Mac after r148075.
https://bugs.webkit.org/show_bug.cgi?id=115038
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_build_check):
run-webkit-tests is supposed to fail, if it is run on a different
platform than specified on the command line.
However, Qt allows exactly this for Qt-platforms to allow comparing
of test results of different baselines.
Before r148075 "chromium-linux-x86" was used for testing.
This patch changes the port_name to gtk when running the test on mac.
- 9:13 AM Changeset in webkit [148970] by
-
- 2 edits in trunk/Source/WebCore
Avoid computing style twice when element has no existing style
https://bugs.webkit.org/show_bug.cgi?id=115042
Reviewed by Andreas Kling.
We currently compute element style twice if we end up having to reattach, first in recalcStyle and then
again during attach(). We can easily avoid this in common case where the element has no existing style
(usually because it is display:none).
- dom/Element.cpp:
(WebCore::Element::recalcStyle):
Don't compute the style and diff if there is no existing style. There is nothing to diff against.
Instead just call reattach() directly, we ended up doing that anyway with the existing code.
- 9:03 AM Changeset in webkit [148969] by
-
- 5 edits in trunk
[BlackBerry] Do not access BackForwardListImpl from DRT
https://bugs.webkit.org/show_bug.cgi?id=115041
Patch by Xan Lopez <xlopez@igalia.com> on 2013-04-23
Reviewed by Carlos Garcia Campos.
Source/WebKit/blackberry:
Export the necessary functionality in our BackForwardList port
client in order for DRT to work.
- WebCoreSupport/BackForwardListBlackBerry.cpp:
(WebCore::BackForwardListBlackBerry::backListWithLimit):
(WebCore):
(WebCore::BackForwardListBlackBerry::forwardListWithLimit):
(WebCore::BackForwardListBlackBerry::capacity):
- WebCoreSupport/BackForwardListBlackBerry.h:
(BackForwardListBlackBerry):
Tools:
Use the right class to access the bflist functionality.
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::dumpBackForwardListForWebView):
- 8:53 AM Changeset in webkit [148968] by
-
- 11 edits in trunk
WebSocket: Return type of send() should be void if hybi-10 protocol is chosen
https://bugs.webkit.org/show_bug.cgi?id=65850
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-23
Reviewed by Alexey Proskuryakov.
Source/WebCore:
WebSocket API draft changed the return type of send() from boolean to void based on Simon
Pieters' post to WHATWG. Firefox 8 and IE 10 already follow the specification, hence it should
make sense for us to do the same when hybi protocol is used.
Original patch by Yuta Kitamura <yutak@chromium.org>
Tests: http/tests/websocket/tests/hybi/bufferedAmount-after-close.html (updated)
http/tests/websocket/tests/hybi/send-after-close-on-unload.html (updated)
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
- Modules/websockets/WebSocket.h:
- Modules/websockets/WebSocket.idl:
LayoutTests:
Update tests and test results because WebSocket.send() now returns undefined when
the hybi WebSocket protocol is used.
- http/tests/websocket/tests/hybi/bufferedAmount-after-close-expected.txt:
- http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy-expected.txt:
- http/tests/websocket/tests/hybi/bufferedAmount-after-close-in-busy.html:
- http/tests/websocket/tests/hybi/bufferedAmount-after-close.html:
- http/tests/websocket/tests/hybi/send-after-close-on-unload-expected.txt:
- http/tests/websocket/tests/hybi/send-after-close-on-unload.html:
- 8:11 AM Changeset in webkit [148967] by
-
- 2 edits in trunk/Source/WebCore
ScrollbarThemeComposite depends on Page/FrameView/ChromeClient
https://bugs.webkit.org/show_bug.cgi?id=21361
Reviewed by Andreas Kling.
Remove unused header includes.
- platform/ScrollbarThemeComposite.cpp:
- 8:08 AM Changeset in webkit [148966] by
-
- 16 edits in trunk
[GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=112160
Reviewed by Andreas Kling.
Source/WebCore:
- platform/network/soup/GOwnPtrSoup.cpp:
(WTF::SoupMessageHeaders): Add freeOwnedGPtr implementation for
SoupMessageHeaders.
(WTF):
- platform/network/soup/GOwnPtrSoup.h:
(WTF):
- platform/network/soup/ResourceRequest.h:
(ResourceRequest):
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessageHeaders): New function
to update the given SoupMessageHeaders with the ResourceRequest
headers.
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): New
function to update the ResourceRequest headers with the given
SoupMessageHeaders.
(WebCore::ResourceRequest::updateSoupMessage): Use
updateSoupMessageHeaders() to update the headers.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage): Use
updateFromSoupMessageHeaders to update the headers.
Source/WebKit2:
It allows to load requests with custom headers, or to update the
headers of a request before being sent to the server in the
WebKitWebPage::send-request callback.
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(_WebKitURIRequestPrivate): Add SoupMessageHeaders.
(webkit_uri_request_get_http_headers): Return the HTTP headers of
the request as a SoupMessageHeaders if the request is HTTP. A new
SoupMessageHeaders is created on demand using the existing headers
of the request.
(webkitURIRequestGetResourceRequest): Instead of returning a const
reference of the internal ResourceRequest, set a request passed as
a reference and update its HTTP headers using the
SoupMessageHeaders if present.
- UIProcess/API/gtk/WebKitURIRequest.h:
- UIProcess/API/gtk/WebKitURIRequestPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_request): Update to the new
webkitURIRequestGetResourceRequest API.
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add
webkit_uri_request_get_http_headers symbol.
- UIProcess/API/gtk/tests/TestLoaderClient.cpp:
(testWebPageURI):
(testURIRequestHTTPHeaders):
(serverCallback):
(beforeAll):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(willSendRequestForFrame): Update to the new
webkitURIRequestGetResourceRequest API.
Tools:
- MiniBrowser/gtk/GNUmakefile.am: Add missing libsoup flags to
CPPFLAGS.
- 7:55 AM Changeset in webkit [148965] by
-
- 3 edits2 adds in trunk
Clear StyleResolver state before returning from styleForElement().
<http://webkit.org/b/115035>
Reviewed by Antti Koivisto.
From Blink r148687 by <inferno@chromium.org>.
Source/WebCore:
A cached element pointer in the resolver state was causing confusion because
in some cases a subsequent call to styleForElement() would use a pointer to
a different object that is at the same memory address as the previous one.
Test: fast/css/reload-non-styled-element-crash.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForElement):
LayoutTests:
- fast/css/reload-non-styled-element-crash-expected.txt: Added.
- fast/css/reload-non-styled-element-crash.html: Added.
- 7:54 AM Changeset in webkit [148964] by
-
- 4 edits in trunk/Source/WebCore
XSSAuditor performance regression due to threaded parser changes.
<http://webkit.org/b/115037>
<rdar://problem/13716069>
Reviewed by Anders Carlsson.
From Blink r148792 by <abarth@chromium.org>:
The refactoring we did for the threaded parser introduced a performance
regression in innerHTML because we'd boot up the XSSAuditor for fragment
parsing. This CL returns to our earlier behavior of not booting up the
XSSAuditor when parsing fragments.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser):
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::initForFragment):
- html/parser/XSSAuditor.h:
(XSSAuditor):
- 7:45 AM Changeset in webkit [148963] by
-
- 7 edits6 moves5 adds in trunk
[WK2] Make EFL WKView API shareable between ports
https://bugs.webkit.org/show_bug.cgi?id=114734
Reviewed by Anders Carlsson.
Source/WebKit2:
EFL-independent part of WKView API (and its implementation) is now
shareable between ports that use Coordinated Graphics and put to
CoordinatedGraphics folders.
- PlatformEfl.cmake:
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.cpp.
(WKViewCreate):
(WKViewInitialize):
(WKViewGetSize):
(WKViewSetSize):
(WKViewSetViewClient):
(WKViewIsFocused):
(WKViewSetIsFocused):
(WKViewIsVisible):
(WKViewSetIsVisible):
(WKViewGetContentScaleFactor):
(WKViewSetContentScaleFactor):
(WKViewGetContentPosition):
(WKViewSetContentPosition):
(WKViewSetUserViewportTranslation):
(WKViewUserViewportToContents):
(WKViewPaintToCurrentGLContext):
(WKViewGetPage):
(WKViewSetDrawsBackground):
(WKViewGetDrawsBackground):
(WKViewSetDrawsTransparentBackground):
(WKViewGetDrawsTransparentBackground):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewSetShowsAsSource):
(WKViewGetShowsAsSource):
(WKViewExitFullScreen):
- UIProcess/API/C/CoordinatedGraphics/WKView.h: Renamed from Source/WebKit2/UIProcess/API/C/efl/WKView.h.
- UIProcess/API/C/efl/WKViewEfl.cpp: Added.
(WKViewPaintToCairoSurface):
(WKViewCreateSnapshot):
- UIProcess/API/C/efl/WKViewEfl.h: Added.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/API/efl/EwkView.h:
- UIProcess/CoordinatedGraphics/WebView.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebView.cpp.
(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setSize):
(WebKit::WebView::setFocused):
(WebKit::WebView::setVisible):
(WebKit::WebView::setUserViewportTranslation):
(WebKit::WebView::userViewportToContents):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::setShowsAsSource):
(WebKit::WebView::showsAsSource):
(WebKit::WebView::exitFullScreen):
(WebKit::WebView::initializeClient):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::transformFromScene):
(WebKit::WebView::transformToScene):
(WebKit::WebView::coordinatedGraphicsScene):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::dipSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
- UIProcess/CoordinatedGraphics/WebView.h: Renamed from Source/WebKit2/UIProcess/efl/WebView.h.
(WebCore):
(WebKit):
(WebView):
(WebKit::WebView::size):
(WebKit::WebView::isFocused):
(WebKit::WebView::isVisible):
(WebKit::WebView::setContentScaleFactor):
(WebKit::WebView::contentScaleFactor):
(WebKit::WebView::setContentPosition):
(WebKit::WebView::contentPosition):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):
- UIProcess/CoordinatedGraphics/WebViewClient.cpp: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.cpp.
(WebKit):
(WebKit::WebViewClient::viewNeedsDisplay):
(WebKit::WebViewClient::didChangeContentsSize):
(WebKit::WebViewClient::webProcessCrashed):
(WebKit::WebViewClient::webProcessDidRelaunch):
(WebKit::WebViewClient::didChangeContentsPosition):
(WebKit::WebViewClient::didRenderFrame):
(WebKit::WebViewClient::didCompletePageTransition):
(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit::WebViewClient::didChangeTooltip):
- UIProcess/CoordinatedGraphics/WebViewClient.h: Renamed from Source/WebKit2/UIProcess/efl/WebViewClient.h.
(WebCore):
(WebKit):
- UIProcess/efl/WebViewEfl.cpp: Added.
(WebKit):
(WebKit::WebView::create):
(WebKit::WebViewEfl::WebViewEfl):
(WebKit::WebViewEfl::setEwkView):
(WebKit::WebViewEfl::paintToCairoSurface):
(WebKit::WebViewEfl::createPopupMenuProxy):
(WebKit::WebViewEfl::createContextMenuProxy):
(WebKit::WebViewEfl::setCursor):
(WebKit::WebViewEfl::updateTextInputState):
(WebKit::WebViewEfl::handleDownloadRequest):
- UIProcess/efl/WebViewEfl.h: Added.
(WebKit):
(WebViewEfl):
(WebKit::WebViewEfl::ewkView):
Tools:
- TestWebKitAPI/PlatformEfl.cmake:
- WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
Updated project files accordingly to updated WKView API files
structure.
- 7:23 AM Changeset in webkit [148962] by
-
- 2 edits in trunk/Tools
Add Benjamin Poulain's @apple.com address to his entry. Unreviewed.
- Scripts/webkitpy/common/config/contributors.json:
- 7:21 AM Changeset in webkit [148961] by
-
- 2 edits in trunk/Source/WebCore
Speed up ElementData::getAttributeItem(), which is hot.
<http://webkit.org/b/115031>
Reviewed by Antti Koivisto.
From Blink r148622 by <cevans@chromium.org>.
The previous version had a couple of issues:
- Incurred new WTF::Vector::operator[] checks.
- Had a branch in _every_ loop iteration that checked whether the storage was Vector or array[] backed.
Both these issues are fixed, and CloneNodes.html seems reliably at +2%.
I also believe GetElement.html is maybe +1%.
For WebKit, also applied the same optimization to getAttributeItemIndex().
- dom/Element.h:
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::getAttributeItemIndex):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::attributeItem):
- 5:07 AM Changeset in webkit [148960] by
-
- 1 edit4 adds in trunk/LayoutTests
Baselines for fast/css/image-rendering.html
Unreviewed gardening.
- fast/css/image-rendering-expected.png: Added.
- fast/css/image-rendering-expected.txt: Added.
- platform/gtk-wk1/fast/css/image-rendering-expected.txt: Added.
- 4:58 AM Changeset in webkit [148959] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to send out change event for date/color picker
https://bugs.webkit.org/show_bug.cgi?id=114942
Reviewed by Carlos Garcia Campos.
We need to instruct the FormControlElements to send out 'change' event
when the user makes the selection and closes the PagePopup for date/color.
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::setValueAndClosePopup):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValueAndClosePopup):
- 3:29 AM Changeset in webkit [148958] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove the text expecation again to force the bots to fail and generate png expectations.
Unreviewed ungardening.
- fast/css/image-rendering-expected.txt: Removed.
- 3:00 AM Changeset in webkit [148957] by
-
- 20 edits in trunk/LayoutTests
Unreviewed GTK gardening. Rebaselining after r148944.
- platform/gtk/TestExpectations:
- platform/gtk/fast/table/giantRowspan-expected.txt:
- platform/gtk/fast/table/giantRowspan2-expected.png:
- platform/gtk/fast/table/giantRowspan2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/gtk/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug220536-expected.png:
- platform/gtk/tables/mozilla/bugs/bug220536-expected.txt:
- platform/gtk/tables/mozilla/bugs/bug8858-expected.txt:
- platform/gtk/tables/mozilla/core/bloomberg-expected.png:
- platform/gtk/tables/mozilla/core/bloomberg-expected.txt:
- platform/gtk/tables/mozilla/core/row_span-expected.png:
- platform/gtk/tables/mozilla/core/row_span-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- 2:50 AM Changeset in webkit [148956] by
-
- 23 edits2 adds in trunk
Initial advance of text runs should be taken into account
https://bugs.webkit.org/show_bug.cgi?id=114949
Reviewed by Darin Adler.
Source/WebCore:
Keep track of complex text runs' initial advance by adding a new
member to GlyphBuffer and adding the initial advance of any non-first
text run to the advance of the last glyph added for the previous text run.
Additionally, we now correctly handle advance values in the y-axis.
Test: fast/text/complex-initial-advance.html
- WebCore.exp.in:
Add support for new WebKitSystemInterface API.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
Take into account the buffer's initial advance in the y-axis to adjust
the point at which to draw the buffers. Additionally, keep track of advances
on the y-axis as well as the x-axis (which we already were doing) as we iterate
through glyphs and adjust the start point.
(WebCore::Font::drawEmphasisMarks):
Adopt change of GlyphBuffer::advanceAt() return type.
- platform/graphics/GlyphBuffer.h:
Removing the WINCE-specific GlyphBufferAdvance struct since heights are now necessary.
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
New default constructor for GlyphBufferAdvance to support the m_initialAdvance member.
(WebCore::GlyphBuffer::setInitialAdvance):
(WebCore::GlyphBuffer::initialAdvance):
New APIs to get and set the initial advance for a glyph buffer.
(WebCore::GlyphBuffer::advanceAt):
Return a GlyphBufferAdvance rather than a float which used to be only
the glyph buffer's x-axis advance. This is necessary to handle deltas
on the y-axis as well (see WebCore::Font::drawGlyphBuffer).
- platform/graphics/GlyphBuffer.h:
(GlyphBuffer):
(WebCore::GlyphBuffer::setInitialAdvance):
- platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advanceOneCharacter):
Adopt change of GlyphBuffer::advanceAt() return type.
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::advance):
When processing the first text run, set that run's initial advance as
the glyph buffer's initial advance.
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):
Represent the initial advance for a text run by adjusting the advance
of the last glyph of the previous text run in the glyph buffer.
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::initialAdvance):
(ComplexTextRun):
New API to read the inital advance of a complex text run.
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Obtain the text run's initial advance via the new wkCTRunGetInitialAdvance
WebKitSystemInterface API.
- platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Add support for the new wkCTRunGetInitialAdvance WebKitSystemInterface API.
- platform/wx/wxcode/cairo/non-kerned-drawing.cpp:
(WebCore::drawTextWithSpacing):
Adopt change of GlyphBuffer::advanceAt() return type.
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::drawSVGGlyphs):
Adopt change of GlyphBuffer::advanceAt() return type.
Source/WebKit/mac:
Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2:
Adding support for new method CTRunGetInitialAdvance in WebKitSystemInterface.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
LayoutTests:
- fast/text/complex-initial-advance-expected.html: Added.
- fast/text/complex-initial-advance.html: Added.
- 2:42 AM Changeset in webkit [148955] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for two DOM4 constructors tests
that started failing after enabling the subpixel layout due to LayoutUnit overflows.
- 2:05 AM Changeset in webkit [148954] by
-
- 2 edits in trunk/LayoutTests
[EFL] EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=115013
Remove editing/selection/doubleclick-whitespace-crash.html and
editing/selection/doubleclick-whitespace-img-crash.html from TestExpectations
after r144221.
Unreviewed, EFL gardening.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-23
- platform/efl-wk2/TestExpectations:
- 2:02 AM Changeset in webkit [148953] by
-
- 6 edits in trunk/Source/WebCore
[Texmap] Don't paint to an intermediate surface when the result is going to be clipped out completely.
https://bugs.webkit.org/show_bug.cgi?id=115015
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Allan Sandfeld Jensen.
Maintain a clipBounds rectangle in TextureMapper, and test it against the bounds of an intermediate
surface before it is painted.
This allows us to opt out completely of painting into the surface if the result is going to be optimized
out by the GPU clipping.
Covered by tests in compositing/overlap-blending.
- platform/graphics/texmap/TextureMapper.h:
(TextureMapper):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::clipBounds):
(WebCore):
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperImageBuffer.h:
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
- 1:58 AM Changeset in webkit [148952] by
-
- 8 edits in trunk/Source
[Coordinated Graphics] Remove the lockAnimations code path
https://bugs.webkit.org/show_bug.cgi?id=114899
Source/WebCore:
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.
Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.
No new tests, removing functionality that wasn't tested in the first place.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:
(WebCore::CoordinatedGraphicsScene::CoordinatedGraphicsScene):
(WebCore::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebCore::CoordinatedGraphicsScene::commitSceneState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:
(CoordinatedGraphicsScene):
Source/WebKit2:
Remove locking/unlocking animations and checks for the lock state.
The animation locking has been tested to create not-so-smooth animations,
while the use case where the composited animations run out of sync from
the non-composited animations is very rare and unnoticeable.
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-04-23
Reviewed by Benjamin Poulain.
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
- UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::flushPendingLayerChanges):
(WebKit::CoordinatedLayerTreeHost::performScheduledLayerFlush):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- 1:33 AM Changeset in webkit [148951] by
-
- 3 edits in trunk/Source/WebKit/qt
[Qt][WK1] MemoryCache is not cleaned by default
https://bugs.webkit.org/show_bug.cgi?id=111443
Reviewed by Jocelyn Turcotte.
Enable deletion of dead resources in the memory cache as long as the MemoryCache is enabled.
This can be disabled or tuned using the dynamic property "_q_deadDecodedDataDeletionInterval".
The default is set to match that of most other ports and WK2 with cache in WebBrowsing mode.
- Api/qwebsettings.cpp:
(QWebSettings::setObjectCacheCapacities):
- WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):
- 1:31 AM Changeset in webkit [148950] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Changing failure mark to skip after r148948.
- platform/qt/TestExpectations:
- 1:17 AM Changeset in webkit [148949] by
-
- 11 edits3 moves7 adds3 deletes in trunk
Respect image-rendering setting for determing image-rendering quality
https://bugs.webkit.org/show_bug.cgi?id=113405
Reviewed by Benjamin Poulain.
Source/WebCore:
Remove the CSS4 values as they are not ready for implementation yet.
We still parse the -webkit-crisp-edges and SVG compatibility values to
be closer to the the partial support in Gecko and Presto.
Tests: fast/css/image-rendering-canvas.html
fast/css/image-rendering-parsing.html
fast/css/image-rendering.html
fast/css/optimize-contrast-image.html
- css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):
- css/CSSValueKeywords.in:
- css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
- rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/style/RenderStyleConstants.h:
Tools:
Remove CSS4 Images option. It is not ready for implementation.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Moved the two tests of image-rendering out of CSS3 since it was removed from the final recommendation.
Added tests of the supported values, and upgraded one test to a reference test so that it now tests
that -webkit-optimize-contrast gets converted to and treated as -webkit-crisp-edges.
Baselines for fast/css/image-rendering.html will be uploaded later when the bots have generated them.
- css3/images/optimize-contrast-image-expected.png: Removed.
- css3/images/optimize-contrast-image-expected.txt: Removed.
- fast/css/image-rendering-canvas-expected.png: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.png.
- fast/css/image-rendering-canvas-expected.txt: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.txt.
- fast/css/image-rendering-canvas.html: Renamed from LayoutTests/css3/images/optimize-contrast-canvas.html.
- fast/css/image-rendering-expected.txt: Added.
- fast/css/image-rendering-parsing-expected.txt: Added.
- fast/css/image-rendering-parsing.html: Renamed from LayoutTests/fast/css/image-set-parsing.html.
- fast/css/image-rendering.html: Added.
- fast/css/optimize-contrast-image-expected.html: Added.
- fast/css/optimize-contrast-image.html: Renamed from LayoutTests/css3/images/optimize-contrast-image.html.
- fast/css/script-tests/image-rendering-parsing.js: Added.
(testImageRendering):
- 1:07 AM Changeset in webkit [148948] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations:
- 12:48 AM Changeset in webkit [148947] by
-
- 3 edits3 deletes in trunk
Unreviewed, rolling out r148923.
http://trac.webkit.org/changeset/148923
https://bugs.webkit.org/show_bug.cgi?id=115020
The patch causes multiple failures in CSS, canvas tests
(Requested by zdobersek on #webkit).
Source/WebCore:
- platform/graphics/cairo/PlatformContextCairo.cpp:
(WebCore::PlatformContextCairo::drawSurfaceToContext):
LayoutTests:
- fast/canvas/script-tests/shadow-image.js: Removed.
- fast/canvas/shadow-image-expected.txt: Removed.
- fast/canvas/shadow-image.html: Removed.
- 12:01 AM Changeset in webkit [148946] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip several test cases that are no longer crashing after r148945.
- platform/efl/TestExpectations:
