Timeline
May 20, 2013:
- 11:39 PM Changeset in webkit [150423] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 11:39 PM Changeset in webkit [150422] by
-
- 1 delete in tags/Safari-537.43
- 11:16 PM Changeset in webkit [150421] by
-
- 8 edits in trunk
[GTK] Fix concatenations of string literals that are not C++11-compliant
https://bugs.webkit.org/show_bug.cgi?id=116449
Reviewed by Martin Robinson.
Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
is simply a matter of separating the string and the string literal that are being concatenated with a space.
Source/WebCore:
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:
- platform/gtk/FileSystemGtk.cpp:
(WebCore::sharedResourcesPath):
Source/WebKit2:
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrint):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
Tools:
- ImageDiff/gtk/ImageDiff.cpp:
(printImage):
- 11:13 PM Changeset in webkit [150420] by
-
- 2 edits in trunk/Tools
[GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
https://bugs.webkit.org/show_bug.cgi?id=116450
Reviewed by Martin Robinson.
The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
TestWebKitAPI programs when compiling them.
- TestWebKitAPI/GNUmakefile.am:
- 11:11 PM Changeset in webkit [150419] by
-
- 2 edits in trunk/Source/WTF
Use 'typeof' keyword to avoid problems when compiling in C++11 standard compliance
https://bugs.webkit.org/show_bug.cgi?id=116447
Reviewed by Darin Adler.
The 'typeof' keyword is a GNU C extension which becomes unavailable when compiling in ANSI or specific standard mode
(such as -std=c++11). The 'typeof' keyword should be used instead as it's available in all modes both under GCC and Clang.
- wtf/FastMalloc.cpp:
(WTF): Replace the 'typeof' keyword with 'typeof'.
- 11:08 PM Changeset in webkit [150418] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822
https://bugs.webkit.org/show_bug.cgi?id=116442
Reviewed by Martin Robinson.
- loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes): Like EFL and Qt, register the application/x-mimearchive mime type as a MHTML archive type
and stop propagating the message/rfc822 mime type as such. This also removes a couple of PLATFORM ifdefs.
- 10:57 PM Changeset in webkit [150417] by
-
- 18 edits in trunk/Source/WebCore
Minor String fixes in CSS
https://bugs.webkit.org/show_bug.cgi?id=116291
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-20
Reviewed by Darin Adler.
Some trival changes to make up for a bad day :)
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::customCssText):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::customCssText):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::cssText):
- css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::customCssText):
- css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::customCssText):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
- css/CSSPropertySourceData.cpp:
(WebCore::CSSPropertySourceData::toString):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::generateSelectorText):
- css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::type):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::customCssText):
(WebCore::CSSValueList::customSerializeResolvingVariables):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::serialize):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCssText):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
- css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::customCssText):
- css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::customCssText):
- 10:50 PM Changeset in webkit [150416] by
-
- 2 edits in trunk/Tools
Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=116492
Reviewed by Dirk Pranke.
Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
to memory pressure on the machine.
This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
for a subsequent patch just to make things easier to follow.
- Scripts/webkitpy/port/driver.py:
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.has_crashed):
(DriverProxy.stop):
- 10:33 PM Changeset in webkit [150415] by
-
- 2 edits in trunk/Tools
Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
https://bugs.webkit.org/show_bug.cgi?id=116423
Reviewed by Ryosuke Niwa.
EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:55 PM Changeset in webkit [150414] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 9:52 PM Changeset in webkit [150413] by
-
- 9 edits7 deletes in trunk
Remove remaining link-prerender code
https://bugs.webkit.org/show_bug.cgi?id=116429
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-20
Reviewed by Darin Adler.
Tools:
Link prerendering code was removed in r150356.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
LayoutTests:
Remove test cases related to link-prerender.
- fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Removed.
- fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Removed.
- fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Removed.
- fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Removed.
- fast/dom/HTMLLinkElement/resources/empty.html: Removed.
- fast/dom/HTMLLinkElement/resources/empty2.html: Removed.
- fast/dom/HTMLLinkElement/resources/simple-prerender.html: Removed.
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 9:51 PM Changeset in webkit [150412] by
-
- 1 delete in tags/Safari-537.43
- 9:50 PM Changeset in webkit [150411] by
-
- 1 copy in tags/Safari-537.43/trunk
New Tag.
- 9:50 PM Changeset in webkit [150410] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 9:49 PM Changeset in webkit [150409] by
-
- 1 delete in tags/Safari-537.43
- 9:42 PM Changeset in webkit [150408] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r150384.
http://trac.webkit.org/changeset/150384
https://bugs.webkit.org/show_bug.cgi?id=116513
Not ready for primetime. (Requested by kling on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-20
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 9:35 PM Changeset in webkit [150407] by
-
- 4 edits in trunk/Source
Versioning.
- 9:34 PM Changeset in webkit [150406] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Below tests don't come to crash anymore after r150368.
But, pending-activity.html still comes to crash on wk2.
storage/indexeddb/pending-activity.html
storage/indexeddb/transaction-coordination-across-databases.html
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 9:30 PM Changeset in webkit [150405] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 8:58 PM Changeset in webkit [150404] by
-
- 6 edits in trunk/Tools
commit-queue should check for oops in changelog entries
https://bugs.webkit.org/show_bug.cgi?id=116395
Reviewed by Martin Robinson.
Make changelog validation fail when it contains oops!.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask._validate_changelog):
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/steps/validatechangelogs.py:
(ValidateChangeLogs.options):
(ValidateChangeLogs._check_changelog_diff):
(ValidateChangeLogs._changelog_contains_oops):
(ValidateChangeLogs.run):
- Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
(ValidateChangeLogsTest._assert_start_line_produces_output):
(ValidateChangeLogsTest.test_check_changelog_diff):
(ValidateChangeLogsTest):
(ValidateChangeLogsTest.test_changelog_contains_oops):
- 8:43 PM Changeset in webkit [150403] by
-
- 1 edit4 adds in trunk/LayoutTests
Add tests for named access checks on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=116512
Reviewed by Geoffrey Garen.
Merge https://chromium.googlesource.com/chromium/blink/+/9207625a100abe9b72333ac5dba02b38ca5f4466
- http/tests/security/xss-DENIED-window-name-alert-expected.txt: Added.
- http/tests/security/xss-DENIED-window-name-alert.html: Added.
- http/tests/security/xss-DENIED-window-name-navigator-expected.txt: Added.
- http/tests/security/xss-DENIED-window-name-navigator.html: Added.
- 8:18 PM Changeset in webkit [150402] by
-
- 3 edits2 adds in trunk
Null pointer deference in WebCore::AppendNodeCommand::create
https://bugs.webkit.org/show_bug.cgi?id=116479
Source/WebCore:
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/5cb43002a44f67a60ecf5a7ed76de2d0bcf89eb2
DeleteSelection::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss() make style and link elements
to be the direct children of the editable root. However, these style and link elements are not necessary editable
and WebKit crashes when they are not.
Test: editing/deleting/delete-uneditable-style.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
LayoutTests:
Reviewed by Andreas Kling.
Add a regression test.
- editing/deleting/delete-uneditable-style-expected.txt: Added.
- editing/deleting/delete-uneditable-style.html: Added.
- 8:13 PM Changeset in webkit [150401] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable SuperRegion
https://bugs.webkit.org/show_bug.cgi?id=116362
Rubber stamped by Geoff Garen.
- heap/Region.h:
- 7:39 PM Changeset in webkit [150400] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove SharedMemoryGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=116457
Reviewed by Andreas Kling.
- Platform/gtk/SharedMemoryGtk.cpp: Removed.
- 7:29 PM Changeset in webkit [150399] by
-
- 9 edits in trunk/Source/WebCore
Scrollbars still show sometimes even when WKPageSetSuppressScrollbarAnimations()
is set
https://bugs.webkit.org/show_bug.cgi?id=116493
-and corresponding-
<rdar://problem/13912871>
Reviewed by Dean Jackson.
We need to be more aggressive with our approach since AppKit may still ask the
scrollbars to paint here.
scrollbarAnimationsAreSuppressed() will allow us to find out if the setting has
been set.
- page/FrameView.cpp:
(WebCore::FrameView::scrollbarAnimationsAreSuppressed):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarAnimationsAreSuppressed):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarAnimationsAreSuppressed):
- rendering/RenderListBox.h:
Don’t allow animations if scrollbars are suppressed.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
Call cancelAnimations() to prevent a just-started animation from continuing.
(WebCore::ScrollAnimatorMac::finishCurrentScrollAnimations):
- 7:07 PM Changeset in webkit [150398] by
-
- 8 edits3 adds in trunk
Expose a way to know when forms are added to a page or when form controls are added to a form
in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add the new callbacks as part of version 2 of the WKBundlePageFormClient.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
Pass the message along to the client if the client has a handler.
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAssociateFormControls):
Tell the injected bundle form client for the page.
(WebKit::WebChromeClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
Add tests for the new callbacks.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
(TestWebKitAPI::nullJavaScriptCallback):
A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
being passed in for the callback.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
After receiving the message that didAssociateFormControls callback was invoked from adding
the form in the onload handler, tell the page to add a password field to the form, which
should also invoke didAssociateFormControls callback.
(TestWebKitAPI::setInjectedBundleClient):
Register to receive messages.
(TestWebKitAPI::TEST):
Load associate-form-controls.html and wait until the didAssociateFormControls callback has
been invoked for both adding the form and for adding a password field to the form.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
(TestWebKitAPI::shouldNotifyOnFormChanges):
Return true so the didAssociateFormControls callback is invoked.
(TestWebKitAPI::didAssociateFormControls):
Tell the UI process.
(TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
(TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
Add a form in response to the onload event. Add a button that will add the password field
for manual testing.
- 7:04 PM Changeset in webkit [150397] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r150386): [WK2] loader/go-back-cached-main-resource.html fails
https://bugs.webkit.org/show_bug.cgi?id=116491
Add a test expectation.
- platform/wk2/TestExpectations:
- 6:53 PM Changeset in webkit [150396] by
-
- 2 edits in trunk/Source/WebCore
Avoid caret repaints if we're not showing carets anyway.
<http://webkit.org/b/116489>
Reviewed by Simon Fraser.
When moving the selection, check if we're inside a contenteditable element (or in caret browsing mode)
before repainting the caret's previous location.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):
- 6:43 PM Changeset in webkit [150395] by
-
- 6 edits2 adds in trunk
position:sticky should stick for the enclosing overflow ancestor
https://bugs.webkit.org/show_bug.cgi?id=100054
Source/WebCore:
Reviewed by Beth Dakin.
Make position: -webkit-sticky be constrained by an enclosing ancestor
with non-visible overflow if there is one, rather than being constained
always by the viewport.
Test: fast/css/sticky/sticky-top-overflow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Rename
viewportRect to constrainingRect, since it isn't just about the viewport any more.
Fix an issue where just adding stickyLocation to absContainerFrame.location() was
incorrect when the container is scrolled; we also have to take the scroll offset
into account, and that offset is stored in the layer tree.
(WebCore::RenderBoxModelObject::stickyPositionOffset):
Look for an enclosing layer with overflow clipping, and, if found, use it to
compute the sticky constraint rect.
- rendering/RenderLayer.h: Add a helpful IncludeSelfOrNot, and fix several member functions
to use it place of hard-to-read boolean arguments.
Add enclosingOverflowClipLayer(IncludeSelfOrNot).
(WebCore::RenderLayer::ancestorCompositingLayer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingOverflowClipLayer): New function, finds the enclosing
layer with overflow clip.
(WebCore::RenderLayer::enclosingCompositingLayer): Use IncludeSelfOrNot.
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint): Ditto.
(WebCore::RenderLayer::enclosingFilterLayer): Ditto.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor): Use IncludeSelfOrNot.
(WebCore::isViewportConstrainedFixedOrStickyLayer): Renamed from isRootmostFixedOrStickyLayer
and moved up so we can use it in requiresCompositingForPosition().
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Only make sticky composited if
it's viewport-constrained.
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints): Declare StickyPositionViewportConstraints
one line down to just before it gets used.
LayoutTests:
Reviewed by Beth Dakin.
Reference test for sticky behavior inside overflow:.
- fast/css/sticky/sticky-top-overflow-expected.html: Added.
- fast/css/sticky/sticky-top-overflow.html: Added.
- 6:25 PM Changeset in webkit [150394] by
-
- 2 edits in trunk/Source/WebCore
Remove DISABLE_ROUNDED_CORNER_CLIPPING
https://bugs.webkit.org/show_bug.cgi?id=115531
Patch by Jeff Rogers <jrogers@blackberry.com> on 2013-05-20
Reviewed by Andreas Kling.
BlackBerry port is no longer using this.
- rendering/RenderLayer.cpp:
(WebCore::inContainingBlockChain):
(WebCore::RenderLayer::clipToRect):
- 5:57 PM Changeset in webkit [150393] by
-
- 6 edits2 adds in trunk/LayoutTests
Add a test that inserting a character inside a URL doesn't move caret per auto correction
https://bugs.webkit.org/show_bug.cgi?id=116458
Reviewed by Darin Adler.
Add a test. This is broken on Safari 6 but fixed on ToT.
- editing/inserting/inserting-slash-inside-url-with-smart-link-expected.txt: Added.
- editing/inserting/inserting-slash-inside-url-with-smart-link.html: Added.
- platform/mac-wk2/TestExpectations:
- 5:49 PM Changeset in webkit [150392] by
-
- 2 edits in trunk/LayoutTests
[GTK][WK2] Unflag tests related to layoutTestController.setSmartInsertDeleteEnabled
https://bugs.webkit.org/show_bug.cgi?id=116433
Unreviewed gardening.
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-20
- platform/gtk-wk2/TestExpectations: Unflag tests as they are passing
since r150289.
- 5:24 PM Changeset in webkit [150391] by
-
- 2 edits in trunk/Tools
[EFL][JHBUILD] Make sure eet is built before evas
https://bugs.webkit.org/show_bug.cgi?id=116440
Reviewed by Gyuyoung Kim.
Mark eet as a dependency of evas since evas requires eet to enable some of its
functionality.
- efl/jhbuild.modules:
- 5:10 PM Changeset in webkit [150390] by
-
- 2 edits in trunk/LayoutTests
[Mac] [WK2] storage/websql/open-database-creation-callback-isolated-world.html, statement-error-callback-isolated-world.html,
and transaction-success-callback-isolated-world.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=116478
Add flaky test expectations.
- platform/mac-wk2/TestExpectations:
- 5:07 PM Changeset in webkit [150389] by
-
- 2 edits in trunk/LayoutTests
svg/batik/text/textEffect.svg is flaky on Mountain Lion builders
https://bugs.webkit.org/show_bug.cgi?id=116477
Add a failing test expectation.
- platform/mac/TestExpectations:
- 4:43 PM Changeset in webkit [150388] by
-
- 12 edits in trunk/Source
Clients should have a way to extend rendering suppression
https://bugs.webkit.org/show_bug.cgi?id=116463
<rdar://problem/13738496>
Reviewed by Andy Estes.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageExtendIncrementalRenderingSuppression): Added.
(WKBundlePageStopExtendingIncrementalRenderingSuppression): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
These only have any effect if SuppressesIncrementalRendering is also enabled.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Inform the FrameView if there are any outstanding rendering suppression tokens.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::extendIncrementalRenderingSuppression):
Return the next available rendering suppression token.
Add it to the list of active tokens.
Inform the FrameView that we want to suppress rendering.
(WebKit::WebPage::stopExtendingIncrementalRenderingSuppression):
Remove the given token from the list of active tokens.
Un-suppress rendering if appropriate.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldExtendIncrementalRenderingSuppression):
Return if there are any active rendering suppression tokens.
- WebCore.exp.in:
Export FrameView::setVisualUpdatesAllowedByClient.
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
Move rendering-suppression watchdog into setVisualUpdatesAllowed(bool).
setVisualUpdatesAllowed(ReadyState) should not re-enable visual updates
if the client is itself disabling visual updates.
(WebCore::Document::visualUpdatesSuppressionTimerFired):
If the watchdog fires and the client is still disabling visual
updates, we should not re-enable visual updates, but instead
wait for the client.
(WebCore::Document::setVisualUpdatesAllowedByClient):
Actually re-enable visual updates if we deferred the re-enabling above
(when the page finishes loading, but the client had them disabled).
- dom/Document.h:
(Document): Add setVisualUpdatesAllowedByClient.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView): Visual updates are allowed by default.
(WebCore::FrameView::setVisualUpdatesAllowedByClient):
Forward through to the document, but we also need to persist the state
here in FrameView so that it survives through navigation.
- page/FrameView.h:
(WebCore::FrameView::setVisualUpdatesAllowedByClient): Added.
(WebCore::FrameView::visualUpdatesAllowedByClient): Added.
Added storage for m_visualUpdatesAllowedByClient.
- 4:30 PM Changeset in webkit [150387] by
-
- 16 edits in trunk
[CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values
https://bugs.webkit.org/show_bug.cgi?id=116349
Reviewed by Alexandru Chiculita.
Source/WebCore:
Add support for parsing image URI values for the shape-inside and shape-outside CSS properties.
Extended the ExclusionShapeValue class to support tracking the property's StyleImage value.
The ExclusionShapeValue::type enums were changed from all upper case to "Intercase" by order
of the style bot.
The existing CSS parsing tests were extended to check URI values.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyExclusionShape::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- rendering/style/ExclusionShapeValue.h:
(WebCore::ExclusionShapeValue::createImageValue):
(ExclusionShapeValue):
(WebCore::ExclusionShapeValue::image):
(WebCore::ExclusionShapeValue::setImage):
(WebCore::ExclusionShapeValue::ExclusionShapeValue):
LayoutTests:
Check that shape values specified with a URI are parsed correctly.
- fast/exclusions/parsing-wrap-shape-inside-expected.txt:
- fast/exclusions/parsing-wrap-shape-outside-expected.txt:
- fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
- fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
- 4:28 PM Changeset in webkit [150386] by
-
- 5 edits in trunk
WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
https://bugs.webkit.org/show_bug.cgi?id=116125
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-20
Reviewed by Tim Horton.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::pathSuitableForTestResult):
Changed string operations to match _drt_descriptionSuitableForTestResult.
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
Pass the main frame's URL to pathSuitableForTestResult.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
Added WKBundlePageRef to willPerformClientRedirectForFrame.
LayoutTests:
- platform/wk2/TestExpectations:
Unskipped working tests.
- 4:05 PM Changeset in webkit [150385] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to editing/selection/user-drag-element-and-user-select-none.html
after r150354. The failure is tracked by the bug 116473.
- 3:55 PM Changeset in webkit [150384] by
-
- 3 edits in trunk/Source/WebKit2
PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
<http://webkit.org/b/116464>
<rdar://problem/10103795>
Reviewed by Anders Carlsson.
Give the web process a 10 second chance to exit nicely after closing the last tab belonging to it.
This code only runs if there was something on the page (e.g an unload/beforeunload event handler)
preventing the UI process from killing it right away.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::forcefulTerminationTimerFired):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 2:38 PM Changeset in webkit [150383] by
-
- 5 edits10 adds in trunk
[CSSRegions] Fix offsetLeft / offsetTop for elements inside named flow
https://bugs.webkit.org/show_bug.cgi?id=115899
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-20
Reviewed by David Hyatt.
Source/WebCore:
Elements in named flows that have the body as their offsetParent, need to compute their
offsetLeft and offsetTop values relative to the body.
Tests: fast/regions/offsetLeft-offsetTop-in-multiple-regions.html
fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html
fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html
fast/regions/offsetLeft-offsetTop-in-region-float.html
fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
- rendering/RenderFlowThread.cpp:
(WebCore):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
- rendering/RenderFlowThread.h:
LayoutTests:
Added tests for the implementation of offsetLeft and offsetTop for objects inside named flows
for which the offsetParent is the body.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float.html: Added.
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html: Added.
- 2:17 PM Changeset in webkit [150382] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed TestExpectation cleanup. Reordered lines
to match Mac version to make it easier to understand what features
are uniquely missing in Windows port.
- platform/win/TestExpectations: Reordering of lines, adds some
bug ID's to existing skipped tests.
- 2:10 PM Changeset in webkit [150381] by
-
- 6 edits in trunk/Source/JavaScriptCore
Make C API more robust against null contexts
https://bugs.webkit.org/show_bug.cgi?id=116462
Reviewed by Anders Carlsson.
Handle null contexts in a non-crashy way. It's a bug to ever call the
API with a null context, and the absence of a context means we can't
produce a meaningful result, so we still assert in debug builds.
Now where possible we detect and early return, returning null for any
pointer type, NaN for doubles, and false for any boolean result.
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSReportExtraMemoryCost):
- API/JSContextRef.cpp:
(JSContextGetGlobalObject):
(JSContextGetGroup):
(JSContextGetGlobalContext):
(JSContextCreateBacktrace):
- API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCopyPropertyNames):
- API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueMakeFromJSONString):
(JSValueCreateJSONString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
- API/JSWeakObjectMapRefPrivate.cpp:
- 1:42 PM Changeset in webkit [150380] by
-
- 3 edits in trunk/Tools
fix w3c test importer unit tests after r150324
https://bugs.webkit.org/show_bug.cgi?id=116459
Reviewed by Ryosuke Niwa.
This patch fixes the unit tests to not actually call out to
'hg' (by using a mock executive) and also changes the real
directory we crawl from Source/WebCore/css to
Tools/Scripts/webkitpy/w3c to run much more quickly. We should
still change this to a mock filesystem, but that's a separate change.
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.init):
(TestImporter.load_changeset):
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
- 1:34 PM Changeset in webkit [150379] by
-
- 2 edits2 adds in trunk/Source/WebKit2
Add helper function for converting a KeyedCodingValue to a CFTypeRef
https://bugs.webkit.org/show_bug.cgi?id=116461
Reviewed by Tim Horton.
- Shared/cf/KeyedCodingValueCF.cpp: Added.
- Shared/cf/KeyedCodingValueCF.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:00 PM Changeset in webkit [150378] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r149457): some fast/exclusions tests are failing
https://bugs.webkit.org/show_bug.cgi?id=115511
Reviewed by Andreas Kling.
Unskipping the exclusions tests on Qt. They were fixed by https://bugs.webkit.org/show_bug.cgi?id=116115.
- platform/qt/TestExpectations:
- 12:55 PM Changeset in webkit [150377] by
-
- 2 edits3 adds in trunk/Source/WebKit2
Begin stubbing out a new KeyedEncoder class
https://bugs.webkit.org/show_bug.cgi?id=116456
Reviewed by Sam Weinig.
This class (and it's coming counterpart, KeyedDecoder) will be used for serializing
object graphs to a tree-like structure of dictionaries. It is up to individual ports to
serialize them further (for example, on Mac they could be serialized to CFPropertyList objects).
This will be used for serializing session storage state but I hope that it can be used for serializing
back forward state in the future as our current implementation of back forward state serialization
is fragile and depends on our IPC layer's binary encoding(!).
- Shared/KeyedCodingValue.h: Added.
- Shared/KeyedEncoder.cpp: Added.
- Shared/KeyedEncoder.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 12:13 PM Changeset in webkit [150376] by
-
- 4 edits in trunk/Tools
Unreviewed EFL build fix.
Fix linking errors due to undefined symbols on Ubuntu 13.04.
- DumpRenderTree/efl/CMakeLists.txt:
- EWebLauncher/CMakeLists.txt:
- MiniBrowser/efl/CMakeLists.txt:
- 12:00 PM Changeset in webkit [150375] by
-
- 3 edits4 adds in trunk
[CSS Regions][CSS Exclusions] shape-inside on regions should respect positioned shapes and overflow
https://bugs.webkit.org/show_bug.cgi?id=116252
Reviewed by David Hyatt.
Regions should respect shape-inside properties which have specified top offset. Since the content which overflows from the
shape should be pushed after the content box (for details check out r148975), I implemented overflowthe behavior for simple
cases when you have only one region. I'm going to implement it for additional regions in a follow up patch.
Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Handle the flow thread case, push the overflowing content after the
content box. Respect existing shape-inside on region tests.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Set the correct logical top position for the shape-inside in
the case of regions. Respect the region's margins and paddings.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html: Added.
- 11:45 AM Changeset in webkit [150374] by
-
- 2 edits in trunk/LayoutTests
[GTK] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=116419
Unreviewed GTK gardening.
Remove one of two http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-20
- platform/gtk/TestExpectations:
- 11:10 AM Changeset in webkit [150373] by
-
- 11 edits in trunk/Source/WebCore
Remove custom binding for the Clipboard clearData function
https://bugs.webkit.org/show_bug.cgi?id=116421
Reviewed by Andreas Kling.
- bindings/js/JSClipboardCustom.cpp: Removed the clearData binding.
- dom/Clipboard.idl: Removed [Custom].
- dom/Clipboard.cpp:
(WebCore::Clipboard::clearData): Renamed from clearAllData.
- dom/Clipboard.h: Rename clearAllData to clearData so we just use
overloading for the one with and without a MIME type.
- platform/ios/ClipboardIOS.h: Rename clearAllData to clearData.
- platform/ios/ClipboardIOS.mm:
(WebCore::ClipboardIOS::clearData): Ditto.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::clearData). Ditto.
- platform/qt/ClipboardQt.h: Ditto.
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::clearData): Ditto.
- platform/win/ClipboardWin.h: Ditto.
- 10:21 AM Changeset in webkit [150372] by
-
- 2 edits in trunk/Source/WebCore
[iOS] media/event-queue-crash.html ASSERTs in notifyChildInserted
https://bugs.webkit.org/show_bug.cgi?id=116444
Reviewed by Jer Noble.
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureMediaControls): Only create media controls when the
element is in a Document.
- 9:47 AM Changeset in webkit [150371] by
-
- 9 edits2 adds in trunk
[Mac] captions menu should behave more like a menu
https://bugs.webkit.org/show_bug.cgi?id=116436
Reviewed by Eric Carlson.
Let the captions menu behave more like a native Mac menu by hiding it when
clicking anywhere on the page and preventing the page from scrolling when
attempting to scroll the captions menu when it cannot scroll in the requested
direction.
Test: media/video-controls-captions-trackmenu-hide-on-click-outside.html
- dom/EventListener.h:
Add the new MediaControlsAppleEventListenerType.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::defaultEventHandler):
(WebCore::MediaControlsApple::hide):
(WebCore::MediaControlsApple::makeTransparent):
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility):
(WebCore::MediaControlsApple::reportedError):
(WebCore::MediaControlsApple::toggleClosedCaptionTrackList):
Use the hideClosedCaptionTrackList() and showClosedCaptionTrackList()
methods to hide and show the captions menu instead of calling hide()
and show() directly on m_closedCaptionsContainer.
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
Show the m_closedCaptionsContainer and register a "mousewheel" event
listener on it as well as a "click" event listener on the entire document.
(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
Hide the m_closedCaptionsContainer and remove the "mousewheel" event
listener on it as well as the "click" event listener on the entire document.
(WebCore::MediaControlsApple::shouldClosedCaptionsContainerPreventPageScrolling):
New private utility to determine whether the m_closedCaptionsContainer can scroll
in the provided scroll direction.
(WebCore::MediaControlsApple::eventListener):
Obtain the event listener used for "mousewheel" and "click" event handlers.
(WebCore::MediaControlsAppleEventListener::handleEvent):
Event handler for the "mousewheel" and "click" events. If we get a "click" event, we
toggle the captions menu visibility and if we get a "mousewheel" event, we call into
shouldClosedCaptionsContainerPreventPageScrolling() to see if we can scroll in the
current scroll direction, and if not prevent the event from resulting in a scroll by
calling preventDefault().
(WebCore::MediaControlsAppleEventListener::operator==):
Required for the successful subclassing of EventListener.
- html/shadow/MediaControlsApple.h:
(MediaControlsAppleEventListener):
(WebCore::MediaControlsAppleEventListener::create):
(WebCore::MediaControlsAppleEventListener::cast):
(WebCore::MediaControlsAppleEventListener::MediaControlsAppleEventListener):
New subclass of EventListener required to provide a custom event listener for the
"mousewheel" and "click" events registered in showClosedCaptionTrackList() and
hideClosedCaptionTrackList().
- 9:39 AM Changeset in webkit [150370] by
-
- 3 edits3 adds in trunk
[Cairo] Canvas-shadow behavior is not being as expected
https://bugs.webkit.org/show_bug.cgi?id=108897
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-05-18
Reviewed by Martin Robinson.
Source/WebCore:
ShadowBlur::endShadowLayer copies the image from shadowContext to cairoContext.
CairoContext-path should be empty for doing this copy. Otherwise, the
original-image area will also get filled with the shadow.
Test: fast/canvas/canvas-image-shadow.html
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow):
LayoutTests:
Test to verify the shadow of an image drawn on canvas.
This test uses an image whose size is smaller than,
the size of the rectangle which should be filled with the image.
- fast/canvas/canvas-image-shadow-expected.txt: Added.
- fast/canvas/canvas-image-shadow.html: Added.
- fast/canvas/script-tests/canvas-image-shadow.js: Added.
(draw):
- 9:21 AM Changeset in webkit [150369] by
-
- 4 edits in trunk/Source/WebKit2
Bump WKBundlePageLoaderClient version number so as not to break some clients
https://bugs.webkit.org/show_bug.cgi?id=116426
Reviewed by Anders Carlsson.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 9:00 AM Changeset in webkit [150368] by
-
- 6 edits in trunk
[EFL] Reenabled INDEXED_DATABASE after r150344
https://bugs.webkit.org/show_bug.cgi?id=116430
Reviewed by Gyuyoung Kim.
.:
Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
build was fixed in r150344.
- Source/cmake/OptionsEfl.cmake:
Tools:
Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
build was fixed in r150344.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip indexeddb layout tests for EFL port now that the functionality
is reenabled at compile time.
- platform/efl/TestExpectations:
- 7:44 AM Changeset in webkit [150367] by
-
- 4 edits in trunk/Source
Synchronize FeatureDefines.xcconfig
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Remove
ENABLE_LINK_PRERENDER. This was missed in r150356.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Add a newline to the
end of the file.
- 6:44 AM Changeset in webkit [150366] by
-
- 10 edits in trunk
-webkit-text-underline-position should not be inherited
https://bugs.webkit.org/show_bug.cgi?id=116363
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-20
Reviewed by Dean Jackson.
Source/WebCore:
Specification says text-underline-position should not be inherited.
No new tests, this updates existing tests.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Make
CSSPropertyWebkitTextUnderlinePosition return false.
- rendering/style/RenderStyle.h: Treat TextUnderlinePosition as
non-inherited.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==): Remove m_textUnderlinePosition.
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==): Add m_textUnderlinePosition.
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Update expected results.
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
- fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js:
- 6:36 AM Changeset in webkit [150365] by
-
- 3 edits in trunk/Source/WebCore
Add compile asserts for the size of RootInlineBox and InlineTextbox
https://bugs.webkit.org/show_bug.cgi?id=116337
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-20
Reviewed by Darin Adler.
Add compile asserts to ensure RootInlineBox and InlineTextbox stay small.
- rendering/InlineTextBox.cpp:
(SameSizeAsInlineTextBox):
(WebCore):
- rendering/RootInlineBox.cpp:
(SameSizeAsRootInlineBox):
(WebCore):
- 5:03 AM Changeset in webkit [150364] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Adding failure expectations for spelling tests.
- platform/efl-wk2/TestExpectations:
- 3:45 AM WebKit Team edited by
- (diff)
- 3:11 AM Changeset in webkit [150363] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-double-clicked-word.html passes after r150289.
- platform/efl-wk2/TestExpectations:
- 2:37 AM Changeset in webkit [150362] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LocalizedStringsBlackBerry: add dummy text track strings
https://bugs.webkit.org/show_bug.cgi?id=116300
Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-20
Reviewed by Rob Buis.
These are dummy implementations necessary to make WebKit link.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::weekFormatInLDML):
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
- 1:30 AM Changeset in webkit [150361] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
https://bugs.webkit.org/show_bug.cgi?id=116302
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-20
Reviewed by Rob Buis.
TiledImage is now the NativeImage of the BlackBerry port.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- 1:02 AM EFLWebKit edited by
- buildbots (diff)
- 1:01 AM EFLWebKitBuildBots edited by
- (diff)
- 1:00 AM EFLWebKitBuildBots edited by
- removing cq requestees. (diff)
- 1:00 AM EFLWebKitBuildBots edited by
- removing intel gardeners (diff)
- 12:24 AM WebKitGTK/2.0.x edited by
- (diff)
May 19, 2013:
- 11:48 PM Changeset in webkit [150360] by
-
- 2 edits in trunk/Tools
[EFL] init/shutdown should be paired in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=116427
Reviewed by Christophe Dumez.
Added ecore_file_shutdown() for cleanup of ecore_file.
Removed edje_init and ecore_evas_init because it was in ewk_init().
- EWebLauncher/main.c:
(main):
- 5:50 PM Changeset in webkit [150359] by
-
- 18 edits in branches/dfgFourthTier
CheckArrays should be hoisted
https://bugs.webkit.org/show_bug.cgi?id=116353
Source/JavaScriptCore:
Performance neutral. This will be more important when we start depending on CheckArray for flat arrays.
Reviewed by Filip Pizlo.
- dfg/DFGAbstractState.cpp: Add ForwardCheckArray to wherever we had a CheckArray before.
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::isContravenedByStructure): Checks if the ArrayMode derived from a specific Structure
would contradict the ArrayModes that would be filtered by the current ArrayMode. This is used to detect
if any specific CheckStructures would contradict our CheckArray so that we can defer to the CheckStructure's
judgment.
- dfg/DFGByteCodeParser.cpp: Fill in checkArrayHoistingFailed where we previously exited due to a BadIndexingType.
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h: New ForwardCheckArray node type.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp: Refactored most of TypeCheckHoistingPhase into separate functions, some
of which are now generic to both CheckStructure and CheckArray hoisting while others are specific to one or the
other. Both of the non-zero CheckBallot values must be 1 because we use them as an index into an array of
length 2 inside the VariableAccessData.
(CheckData): Moved structure outside of TypeCheckHoistingPhase so that ArrayTypeCheck and StructureTypeCheck
can access it. Also added new fields for tracking ArrayModes. We need the m_arrayModeIsValid because there
isn't a good sentinel value for "this ArrayMode is invalid and meaningless" like there is for m_structure.
We need m_arrayModeHoistingOkay for when we want to permanently disable hoisting for that particular variable.
(JSC::DFG::CheckData::CheckData):
(JSC::DFG::CheckData::disableCheckArrayHoisting): Helper function for disabling CheckArray hoisting for a
specific CheckData.
(JSC::DFG::TypeCheckHoistingPhase::run): We now do both CheckStructure and CheckArray hoisting, although we prefer
CheckStructure hoisting when given the possibility to do both.
(TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::clearVariableVotes): Clears all of the VariableAccessData votes since they
can only have two types of votes at any particular time.
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks): Very similar to identifyRedundantStructureChecks,
but with a few different nodes that are important, namely CheckArray (instead of CheckStructure) and the Arrayify-like
nodes always disable hoisting since they always change the IndexingType.
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingForVariablesWithInsufficientVotes):
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):
(JSC::DFG::TypeCheckHoistingPhase::disableCheckArrayHoisting): Helper that looks up the CheckData for the
specified variable and disables CheckArray hoisting on it.
(JSC::DFG::TypeCheckHoistingPhase::shouldConsiderForHoisting):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::TypeCheckHoistingPhase::noticeCheckArray):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode): We want to take CheckStructure nodes
into account when hoisting CheckArrays, so we make sure that if we contradict what a CheckStructure says then we
give up on hoisting the CheckArray.
(JSC::DFG::ArrayTypeCheck::isValidToHoist):
(ArrayTypeCheck): Structure that houses some of the specifics on how to hoist CheckArrays. This structure
is used a template argument to allow some of the very similar code to statically parameterized and reused
for both CheckStructure and CheckArray hoisting.
(JSC::DFG::ArrayTypeCheck::disableHoisting):
(JSC::DFG::ArrayTypeCheck::isContravenedByValue):
(JSC::DFG::ArrayTypeCheck::hasEnoughVotesToHoist):
(JSC::DFG::ArrayTypeCheck::hoistingPreviouslyFailed):
(JSC::DFG::StructureTypeCheck::isValidToHoist):
(StructureTypeCheck): Same as ArrayTypeCheck, but specific to CheckStructure hoisting.
(JSC::DFG::StructureTypeCheck::disableHoisting):
(JSC::DFG::StructureTypeCheck::isContravenedByValue):
(JSC::DFG::StructureTypeCheck::hasEnoughVotesToHoist):
(JSC::DFG::StructureTypeCheck::hoistingPreviouslyFailed):
- dfg/DFGUnificationPhase.cpp: Added merging of whether or not CheckArray hoisting failed.
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeCheckArrayHoistingFailed):
(VariableAccessData):
(JSC::DFG::VariableAccessData::checkArrayHoistingFailed):
- runtime/Options.h:
LayoutTests:
Added a microbenchmark to JSRegress that specifically targets CheckArray hoisting.
We get a 25% improvement on it.
Reviewed by Filip Pizlo.
- fast/js/regress/check-array-hoisting-expected.txt: Added.
- fast/js/regress/check-array-hoisting.html: Added.
- fast/js/regress/script-tests/check-array-hoisting.js: Added.
(f):
- 5:04 PM Changeset in webkit [150358] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Improve string use in PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116418
Reviewed by Sam Weinig.
Did a Ben Poulain all over this file.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText): Add the newline separately to the string builder.
Prepending it to the string first just does more allocations for no good reason.
(WebCore::Pasteboard::documentFragment): Use emptyString() instead of "" and use
ASCIILiteral where appropriate.
(WebCore::cocoaTypeFromHTMLClipboardType): More ASCIILiteral.
(WebCore::Pasteboard::clear): Use early return instead of a nested if here.
Use emptyString() instead of "".
(WebCore::addHTMLClipboardTypesForCocoaType): More ASCIILiteral.
- 4:56 PM Changeset in webkit [150357] by
-
- 2 edits in trunk/Tools
[EFL] Add command line option to MiniBrowser to set user agent
https://bugs.webkit.org/show_bug.cgi?id=116387
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-19
Reviewed by Christophe Dumez.
We need this option to compare the rendering differences according to different user agents.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 3:57 PM Changeset in webkit [150356] by
-
- 32 edits6 deletes in trunk
Remove link prerendering code
https://bugs.webkit.org/show_bug.cgi?id=116415
Reviewed by Darin Adler.
.:
This code was only used by Chromium and is dead now.
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
- dom/EventNames.h:
(WebCore):
- html/HTMLLinkElement.cpp:
- html/HTMLLinkElement.h:
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
- html/LinkRelAttribute.h:
(LinkRelAttribute):
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::~LinkLoader):
(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):
- loader/LinkLoader.h:
(WebCore):
(LinkLoader):
- loader/LinkLoaderClient.h:
(LinkLoaderClient):
- loader/Prerenderer.cpp: Removed.
- loader/Prerenderer.h: Removed.
- loader/PrerendererClient.cpp: Removed.
- loader/PrerendererClient.h: Removed.
- platform/PrerenderClient.h: Removed.
- platform/PrerenderHandle.h: Removed.
Source/WebKit/blackberry:
This code was only used by Chromium and is dead now.
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/mac:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
This code was only used by Chromium and is dead now.
- wtf/FeatureDefines.h:
- 3:52 PM Changeset in webkit [150355] by
-
- 12 edits in trunk/Source/WebCore
Change the terminology used by rendering code when painting a given node and its children from "paintingRoot" to "subtreePaintRoot"
https://bugs.webkit.org/show_bug.cgi?id=116417
Reviewed by Sam Weinig.
PaintInfo and RenderLayer code referred to a "paintingRoot". This is only set when
FrameView::setNodeToDraw() has been called and is used to restrict painting to
some part of the subtree, but it could easily be misinterpreted, and confused with
the "rootLayer" used by RenderLayer (which is usually not the layer associated with
the paintingRoot).
Change the terminology from "paintingRoot" to "subtreePaintRoot" root to make the
purpose of this variable more obvious.
No behavior change.
- page/FrameView.cpp: Add a comment for setNodeToDraw(); in future this should
be called setSubtreePaintRoot() or something. Not done in this patch to avoid
risk; this function is exported from WebCore.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):
(WebCore::PaintInfo::shouldPaintWithinRoot):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
- rendering/RenderObject.cpp: Add a comment to recommend changing the name of
paintingRootRect() to refer to a subtree paint. Not done in this patch to avoid
risk; this function is exported from WebCore.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- 2:51 PM Changeset in webkit [150354] by
-
- 5 edits in trunk/Source/WebCore
Use Element instead of Node in DragState, also redo DragState struct
https://bugs.webkit.org/show_bug.cgi?id=116411
Reviewed by Sam Weinig.
The drag source is an element, so use RefPtr<Element> instead of RefPtr<Node>.
Also, the entire drag state is about dragging, so no need for the word "drag" in the
name of its members. Also, it's a struct, so the members don't need m_ prefixes.
- page/DragController.cpp: Removed unneeded include of Node.h since it's included by
Element.h, which is also included.
(WebCore::DragController::draggableElement): Renamed from Node to Element and changed
the types and names of arguments accordingly. Also made this function handle a
startElement of 0 so callers don't need to. Also updated for changes to DragState members.
(WebCore::DragController::startDrag): Updated for changes to DragState members.
Since dragSource can only be an element, was able to get rid of isElementNode checks.
- page/DragController.h: Fixed style of forward declarations of structs. Updated for
change of draggableNode to draggableElement. Also removed declarations of nonexistent
selectionDraggingRect and doDrag functions.
- page/DragState.h: Rewrote practically this whole header. Added an include of Element
instead of Node since that's what we use now. Removed includes that are redundant.
There's no problem copying a DragState, so removed WTF_MAKE_NONCOPYABLE. There's no need
to allocate a DragState on the heap, so removed WTF_MAKE_FAST_ALLOCATED. The event dispatch
boolean is never set to a constant, so there's no need for a policy enum; it can just be
a boolean. Removed the "m_" prefixes from the struct members, since this is a struct with
public members and we don't use the prefix in those cases. Removed the word "drag" from the
struct member names since this entire struct is about dragging and has drag in its name.
Left the comments mostly intact, even though I'm not certain of their value.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent): Updated for changes to DragState.
(WebCore::EventHandler::eventMayStartDrag):
Use innerElement instead of innerNode to call draggableElement instead of draggableNode.
(WebCore::EventHandler::updateDragAndDrop): Updated for changes to DragState.
(WebCore::EventHandler::cancelDragAndDrop): Ditto.
(WebCore::EventHandler::handleWheelEvent): Added FIXME.
(WebCore::EventHandler::dragHysteresisExceeded): Updated for changes to DragState.
(WebCore::EventHandler::freeClipboard): Updated for changes to DragState. Also re-added
code to release the clipboard object, which is needed here to avoid keeping it around in
memory until the next drag.
(WebCore::EventHandler::dragSourceEndedAt): Updated for changes to DragState.
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Ditto.
(WebCore::EventHandler::dispatchDragSrcEvent): Ditto.
(WebCore::EventHandler::handleDrag): Updated for changes to DragState. Use innerElement
instead of innerNode to call draggableElement instead of draggableNode. No longer need to
null check innerElement because draggableElement does that. Removed unneeded else that was
setting m_dragSrc to zero since it's guaranteed to already be zero.
- 1:38 PM Changeset in webkit [150353] by
-
- 20 edits in trunk/Source
Remove ChromeClient::webView()
https://bugs.webkit.org/show_bug.cgi?id=116054
Source/WebCore:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- loader/EmptyClients.h:
- page/ChromeClient.h:
(ChromeClient):
Source/WebKit/blackberry:
Reviewed by Andreas Kling.
This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Source/WebKit/efl:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WebKit/gtk:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
Source/WebKit/mac:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit/qt:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):
Source/WebKit/win:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit/wince:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):
- 11:40 AM Changeset in webkit [150352] by
-
- 2 edits in trunk/Tools
Unreviewed, addressing test-webkitpy failures after r150317.
- Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
- 8:40 AM Changeset in webkit [150351] by
-
- 6 edits1 delete in trunk/Source/WebCore
Eliminate the Editor::newGeneralClipboard function
https://bugs.webkit.org/show_bug.cgi?id=116410
Reviewed by Andreas Kling.
This is one of the clean-ups made possible by the changes to the DOM clipboard class.
I had been waiting until all the platforms were moved over to it, but it turns out to be
easy to do this now, just with #ifdefs.
- PlatformBlackBerry.cmake: Deleted EditorBlackBerry.cpp.
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent): Call Clipboard::createForCopyAndPaste directly when
using the new version of the Clipboard class. Also some small style cleanup nearby.
- editing/blackberry/EditorBlackBerry.cpp: Removed. The only function in this file was
newGeneralClipboard.
- editing/mac/EditorMac.mm: Deleted newGeneralClipboard.
- platform/efl/ClipboardEfl.cpp: Ditto.
- platform/gtk/ClipboardGtk.cpp: Ditto.
- 7:56 AM Changeset in webkit [150350] by
-
- 2 edits in trunk/Source/WebCore
GtkSelectionData length is off by one
https://bugs.webkit.org/show_bug.cgi?id=113962
Reviewed by Anders Carlsson.
No new tests. Since drag data is interpreted as a null-terminated string
this is difficult to test with a C program and we have no infrastructure
built for using GIR tests.
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData): Instead of including the null
character in the paste data length, just include the string. This matches the behavior
of Firefox.
