Context Navigation

Move IDL extended attributes to their correct location according to the
latest Web IDL specification. We used to be inconsistent in the positioning
of the extended attributes. This simplifies a lot the code of the IDL parser
and makes our IDL files more standard.

Based on Blink r148345 by Kentaro Hara <haraken@chromium.org>.

No new tests, no behavior change.

Modules/encryptedmedia/MediaKeyMessageEvent.idl:
Modules/notifications/Notification.idl:
Modules/speech/SpeechSynthesisVoice.idl:
bindings/scripts/IDLParser.pm:

(parseDefinitions):
(parseInterfaceMembers):
(parseInterfaceMember):
(parseDictionaryMembers):
(parseAttributeOrOperationOrIterator):
(parseAttribute):

css/CSSFontFaceLoadEvent.idl:
dom/Document.idl:
dom/Element.idl:
dom/Node.idl:
html/HTMLBodyElement.idl:
html/HTMLEmbedElement.idl:
html/HTMLFrameSetElement.idl:
html/HTMLMediaElement.idl:
html/HTMLSelectElement.idl:
html/HTMLSourceElement.idl:
page/DOMWindow.idl:
svg/SVGElementInstance.idl:
svg/SVGScriptElement.idl:
testing/TypeConversions.idl:

6:32 PM Changeset in webkit [151713] by jberlin@webkit.org

2 edits in trunk/Source/WebCore

Let the script to update the Localizable.strings file do the reordering it wants to do.

Rubber-stamped by Anders Carlsson.

English.lproj/Localizable.strings:

6:15 PM Changeset in webkit [151712] by Brent Fulgham

3 edits in trunk/Source/WebCore

[Windows] Unreviewed gardening -- show missing AccessibilityNodeObject source
files in Visual Studio.

WebCore.vcxproj/WebCore.vcxproj: Add missing files.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

6:12 PM Changeset in webkit [151711] by achristensen@apple.com

2 edits
1 add in trunk/Tools

Working on coverage script, added xml to json data extraction script.
https://bugs.webkit.org/show_bug.cgi?id=117648

This is part of a new test code coverage analysis tool. This compiles WebKit to generate
coverage data, runs the tests, and collects all of the data in json format.

Reviewed by Stephanie Lewis.

Scripts/generate-coverage-data:

(parseGcovrOutput):
(getFileHitsAndBranches):
(addLineCounts):
(createResultName):

Scripts/webkitpy/tool/gcovr: Added.

5:51 PM Changeset in webkit [151710] by ryuan.choi@samsung.com

3 edits in trunk/Tools

Unreviewed build fix after r151699.

TestWebKitAPI/CMakeLists.txt:
WebKitTestRunner/CMakeLists.txt:

Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h

5:36 PM Changeset in webkit [151709] by oliver@apple.com

3 edits
3 adds in trunk

Going to google.com/trends causes a crash
https://bugs.webkit.org/show_bug.cgi?id=117602

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

When handling op_throw, etc we need to flush the variables and arguments
for the entire inline stack, not just the top frame.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushAllArgumentsAndCapturedVariablesInInlineStack):
(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Make sure we correctly initialise the appropriate argument registers,
and make sure we perform the tearoff correctly.

fast/js/inline-arguments-tear-off-expected.txt: Added.
fast/js/inline-arguments-tear-off.html: Added.
fast/js/script-tests/inline-arguments-tear-off.js: Added.

(g):
(f):
(doStuff):

5:12 PM Changeset in webkit [151708] by roger_fong@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed. Fix a typo that may be causing some test failures.

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):

4:39 PM Changeset in webkit [151707] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r151513.
http://trac.webkit.org/changeset/151513
https://bugs.webkit.org/show_bug.cgi?id=117763

It causes assertions in debug (Requested by benjaminp on
#webkit).

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):

4:16 PM Changeset in webkit [151706] by roger_fong@apple.com

145 edits
1 move in trunk

Replace tools32 folder with tools and update WebKit Windows solution accordingly.
<rdar://problem/14118143>.

Rubberstamped by Brent Fulgham.

3:50 PM Changeset in webkit [151705] by benjamin@webkit.org

3 edits in trunk/LayoutTests

Rebaseline after system update

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-06-18

http/tests/cache/partitioned-cache-expected.txt:
http/tests/cache/partitioned-cache-iframe-expected.txt:

System fix, the tests pass.

3:44 PM Changeset in webkit [151704] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Infrequent uncaught exception with debugger popovers breaks inspector
https://bugs.webkit.org/show_bug.cgi?id=117755

Create the ZERO_SIZE and ZERO_RECT objects after we've setup the Size
and Rect prototypes, so they get the expected methods. We then need to
handle the ZERO_RECT case better, and not attempt to draw a background
in a canvas with a 0 size, which would produce an exception.

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-18
Reviewed by Timothy Hatcher.

UserInterface/Geometry.js:
UserInterface/Popover.js:

(WebInspector.Popover.prototype._update):

3:31 PM Changeset in webkit [151703] by zoltan@webkit.org

3 edits in trunk/Source/WebCore

[CSS Shapes] Remove lineOverflowsFromShapeInside boolean from RenderBlock::layoutRunsAndFloatsInRange function
https://bugs.webkit.org/show_bug.cgi?id=117757

Reviewed by David Hyatt.

We don't need keep lineOverflowsFromShapeInside boolean in RenderBlock::layoutRunsAndFloatsInRange and in its
helpers because it's easy to decide whether we are in an shape content overflow state or not, so I got rid of
lineOverflowsFromShapeInside's occurences and updated the affected functions.

Covered by existing overflow tests in fast/exclusions/shape-inside and fast/regions/shape-inside.

rendering/RenderBlock.h: Update helper's definition.
rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox): Add condition when overflow is already positioned.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Remove lineOverflowsFromShapeInside.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Remove lineOverflowsFromShapeInside.

3:03 PM Changeset in webkit [151702] by commit-queue@webkit.org

3 edits
3 adds in trunk

widthMediaFeatureEval ends up with null FrameView during iframe unload.
https://bugs.webkit.org/show_bug.cgi?id=117754

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-18
Reviewed by Geoffrey Garen.

Ensure that MediaQueryEvaluator checks against NULL FrameView.

While frames are being unloaded, the Frame object does not necessarily have valid
FrameView anymore. Layout on the main frame can end up querying media values on such child
frames, while detaching.

Source/WebCore:

Test: fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html

css/MediaQueryEvaluator.cpp:

(WebCore::orientationMediaFeatureEval):
(WebCore::aspect_ratioMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
(WebCore::MediaQueryEvaluator::eval):

LayoutTests:

fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery-expected.txt: Added.
fast/frames/crash-when-child-iframe-forces-layout-during-unload-and-sibling-frame-has-mediaquery.html: Added.
fast/frames/resources/child-iframe-forces-parent-layout-on-unload.html: Added.

3:01 PM Changeset in webkit [151701] by andersca@apple.com

15 edits in trunk/Source/WebKit2

Make it possible to set a minimum height for auto-layout
https://bugs.webkit.org/show_bug.cgi?id=117758
<rdar://problem/12849080>

Reviewed by Tim Horton.

Change a bunch of minimumLayoutWidth declarations to minimumLayoutSize and add a new minimumLayoutSize property.
If minimumLayoutSize.height is greater than zero, use it to set the minimum layout size on the frame view.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
UIProcess/API/mac/WKView.mm:

(-[WKView _setIntrinsicContentSize:]):
(-[WKView minimumLayoutWidth]):
(-[WKView setMinimumLayoutWidth:]):
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]):
(-[WKView minimumSizeForAutoLayout]):
(-[WKView setMinimumSizeForAutoLayout:]):

UIProcess/API/mac/WKViewPrivate.h:
UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::minimumLayoutSizeDidChange):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setMinimumLayoutSize):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::minimumLayoutSize):

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::minimumLayoutSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
(WebKit::TiledCoreAnimationDrawingAreaProxy::intrinsicContentSizeDidChange):
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setMinimumLayoutSize):

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::minimumLayoutSize):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

2:53 PM Changeset in webkit [151700] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

sandbox violation when Flash runs for the first time
https://bugs.webkit.org/show_bug.cgi?id=117753
<rdar://problem/14165466>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-18
Reviewed by Alexey Proskuryakov.

Allow flash to try and change the ownership of directories it has just created.

Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:

2:39 PM Changeset in webkit [151699] by Beth Dakin

11 edits
1 add in trunk/Source

Expose a getMediaType method in WebKit
https://bugs.webkit.org/show_bug.cgi?id=117667

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-18
Reviewed by Brady Eidson.

Source/WebCore:

WebCore.exp.in: Updated to add a symbol for

HitTestResult::mediaIsVideo method
and alphabetize the list of exposed methods.

Source/WebKit2:

GNUmakefile.list.am:
Target.pri:

Updated to include the added header file InjectedBundleHitTestResultMediaType.h

UIProcess/API/C/WKAPICast.h:

(WebKit::toBundleHitTestResultMediaType):
(WebKit::toAPI):
Added methods to convert between BundleHitTestResultMediaType
and WKBundleHitTestResultMediaType.

WebKit2.xcodeproj/project.pbxproj: Updated to include

InjectedBundleHitTestResultMediaType.h in the WebKit2 project.

WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetMediaType): Exposes the method getMediaType and
hooks into InjectedBundleHitTestResult::getMediaType.

WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:

WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::getMediaType): Added to return
what type, if any, a media element is.

WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

WebProcess/InjectedBundle/InjectedBundleHitTestResultMediaType.h: Added

to contain new BundleHitTestResultMediaType enums.

2:34 PM Changeset in webkit [151698] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Remove unused bool argument from ReplacementFragment's constructor
https://bugs.webkit.org/show_bug.cgi?id=117752

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/265586d9f154a9dff657511d09926429b8e1b53d.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplaceSelectionCommand::doApply):

2:29 PM Changeset in webkit [151697] by eric.carlson@apple.com

13 edits in trunk

Not all subtitle tracks are SDH
https://bugs.webkit.org/show_bug.cgi?id=117738

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated.

html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::isSDH): New.

html/track/InbandTextTrack.h: Add isSDH override.
html/track/TextTrack.h:

page/CaptionUserPreferencesMac.mm:

(WebCore::trackDisplayName): Only add "SDH" label if a track claims to be SDH.

platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::isSDH): New.

platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::isSDH): Return true if track has both "transcribes

spoken dialog for accessibility" and "describes music and sound for accessibility"
characteristics.

LayoutTests:

media/video-controls-captions-trackmenu-localized.html:
media/video-controls-captions-trackmenu-sorted.html:
platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

2:25 PM Changeset in webkit [151696] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Simplify FormKeyGenerator::willDeleteForm
https://bugs.webkit.org/show_bug.cgi?id=117751

Reviewed by Antti Koivisto.

Merge https://chromium.googlesource.com/chromium/blink/+/c6399efb9da863eb1d1fc98b17ef925998b985ac

html/FormController.cpp:

(WebCore::FormKeyGenerator::willDeleteForm):

2:25 PM Changeset in webkit [151695] by rniwa@webkit.org

3 edits
1 add in trunk

REGRESSION(r147602): Search text field doesn't render selection when it has some :focus rules
https://bugs.webkit.org/show_bug.cgi?id=117747

Reviewed by Kent Tamura.

ManualTests/search-select-all-with-focus-style.html: Added.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/7ff656c8239ce3b125246abcc8b149a603fcff28

r147612 added setNeedsLayout(true, MarkOnlyThis) for
TextControlInnerTextElement renderer. It's ok for input[type=text]
because RenderTextControlSingleLine also has needsLayout flag, and it
has only the inner text renderer as a child.

As for input[type=search], it doesn't work. Renderer structure for
input[type=search] is:

RenderTextControlSingleLine
└Renderer for TextControlInnerContainer

└Renderer for TextControlInnerElement

└Renderer for TextControlInnerTextElement

After r147612, there is a case that only RenderTextControlSingleLine
and TextControlInnerTextElement renderer have needsLayout flag, and
others don't. It won't trigger layout for
TextControlInnerTextElement renderer.

We should set needsLayout flags of TextControlInnerContainer renderer
and TextControlInnerElement renderer by MarkContainingBlockChain.

Manual Tests: search-select-all-with-focus-style.html
(I tried but couldn't make a test that works in DRT)

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::styleDidChange):

1:40 PM Changeset in webkit [151694] by dino@apple.com

2 edits in trunk/Source/WebCore

Attempted build fix for non-Mac.

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData):

1:28 PM Changeset in webkit [151693] by dino@apple.com

10 edits
5 adds in trunk

Synthesized vertical italics on rotated glyphs are transformed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=117726

Reviewed by Enrica Casucci.

Source/WebCore:

If a font does not have italic glyphs, and is in a vertical flow, then
the synthesis of italics was skewing in the wrong direction. While here,
ensure that no CJK text will get italics in vertical layout.

This is a topic under discussion in the CSS Working Group. The resolution
at the June 2013 face-to-face was that:

italics in Japanese (and Chinese) text are rare in vertical layout
most people wanted Latin text to italicize in the direction of the line flow

The final behaviour was left undefined, but we consider the change here
to be sufficient for now. In all cases, the best solution is to avoid
synthesized italics by specifying a font that includes such forms.

Tests: fast/text/international/synthesized-italic-vertical-latin.html

fast/text/international/synthesized-italic-vertical.html

platform/graphics/FontGlyphs.cpp:

(WebCore::glyphDataAndPageForCJKCharacterWithoutSyntheticItalic): New function

that makes a new glyph data pair that is marked as NOT using a synthesized italic.

(WebCore::FontGlyphs::glyphDataAndPageForCharacter): If this is a CJK character and

has a synthesized oblique, then run it through the function above to make a new glyph data pair.

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::nonSyntheticItalicFontData): Creates/returns a new SimpleFontData that will

not synthesize italics.

platform/graphics/SimpleFontData.h: New method nonSyntheticItalicFontData.
platform/graphics/mac/FontMac.mm:

(WebCore::Font::drawGlyphs): This is the actual bug fix. If you are in a vertical flow, the

skew direction should be downwards, not leftwards.

LayoutTests:

Two new tests. One ensures that CJK characters do not get italics
when vertical. The other ensures that Latin text does get italics in
a font that is not synthesized, but unfortunately has to be a pixel test.
The latter is skipped on non-Mac since they don't support
synthesized obliques in FontPlatformData.

fast/text/international/synthesized-italic-vertical-expected.html: Added.
fast/text/international/synthesized-italic-vertical-latin.html: Added.
fast/text/international/synthesized-italic-vertical.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/fast/text/international/synthesized-italic-vertical-latin-expected.txt: Added.
platform/qt/TestExpectations:
platform/win/TestExpectations:

1:28 PM Changeset in webkit [151692] by roger_fong@apple.com

4 edits in trunk/Source/WebKit

Unreviewed. Build fix for Mac and Win

1:14 PM Changeset in webkit [151691] by roger_fong@apple.com

3 edits
6 adds in trunk/Source

Re-implement WebFrameNetworkingContext.
<rdar://problem/13174821>.

Reviewed by Alexey Proskuryakov.

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h: Added.

(WebKit::WebFrameNetworkingContext::create):
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: Added.

(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebKit::WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebKit::WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::blockedError):
(WebKit::WebFrameNetworkingContext::storageSession):

WebCoreSupport/WebFrameNetworkingContext.h: Added.

(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebFrameNetworkingContext::userAgent):

WebCoreSupport/WebFrameNetworkingContext.mm: Added.

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::needsSiteSpecificQuirks):
(WebFrameNetworkingContext::localFileContentSniffingEnabled):
(WebFrameNetworkingContext::scheduledRunLoopPairs):
(WebFrameNetworkingContext::sourceApplicationAuditData):
(WebFrameNetworkingContext::blockedError):
(WebFrameNetworkingContext::storageSession):

1:05 PM Changeset in webkit [151690] by ap@apple.com

3 edits
6 deletes in trunk/Source

<rdar://problem/13174821> Remove files with an incorrect license.

Rubber-stamped by Maciej Stachowiak.

This will break the build, stay tuned for a fix coming soon.

12:58 PM Changeset in webkit [151689] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WTF

PackedIntVector: check template arguments at compile time
https://bugs.webkit.org/show_bug.cgi?id=117737

Use 'COMPILE_ASSERT' instead of 'ASSERT' in PackedIntVector class
constructor.

Reviewed by Sam Weinig.

wtf/PackedIntVector.h:

(WTF::PackedIntVector::PackedIntVector):

12:38 PM Changeset in webkit [151688] by timothy@apple.com

3 edits in trunk/Source/WebInspectorUI

If the tree outline is processing a selection currently, then don't change the selection.

This is needed to allow breakpoints tree elements to be selected without jumping back to
selecting the resource tree element.

https://bugs.webkit.org/show_bug.cgi?id=117746

Reviewed by Joseph Pecoraro.

UserInterface/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar):

UserInterface/TreeOutline.js:

(TreeElement.prototype.select):

11:49 AM Changeset in webkit [151687] by timothy@apple.com

14 edits
1 add in trunk/Source/WebInspectorUI

Update breakpoints to match Xcode 5.

This updates the breakpoint images, line colors, and moves breakpoints toggle button
to the Debugger sidebar navigation bar.

https://bugs.webkit.org/show_bug.cgi?id=117723

Reviewed by Joseph Pecoraro.

Localizations/en.lproj/localizedStrings.js: Updated.
UserInterface/DebuggerSidebarPanel.css: Removed custom toggle button rules.
UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):

UserInterface/Images/Breakpoint.png: Updated.
UserInterface/Images/Breakpoints.pdf: Added.
UserInterface/Images/Breakpoint@2x.png: Updated.
UserInterface/Images/BreakpointButton.pdf: Updated.
UserInterface/Images/BreakpointInactive.png: Updated.
UserInterface/Images/BreakpointInactive@2x.png: Updated.
UserInterface/Images/BreakpointInactiveButton.pdf: Updated.
UserInterface/Images/InstructionPointer.png: Updated.
UserInterface/Images/InstructionPointer@2x.png: Updated.
UserInterface/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .error): Updated background-color and removed box-shadow.
(.source-code.text-editor > .CodeMirror .warning): Ditto.

UserInterface/TextEditor.css:

(.text-editor > .CodeMirror .has-breakpoint .CodeMirror-linenumber::before): Changed left position to 0.
(.text-editor > .CodeMirror .execution-line .CodeMirror-linenumber::after): Updated position.
(.text-editor > .CodeMirror .execution-line): Updated background-color and removed box-shadow.

10:51 AM Changeset in webkit [151686] by commit-queue@webkit.org

2 edits in trunk/Websites/webkit.org

The page title of technical-articles.html is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=117727

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-06-18
Reviewed by Ryosuke Niwa.

Changed the page title of technical-articles.html to "WebKit Technical Articles".

coding/technical-articles.html:

10:38 AM Changeset in webkit [151685] by commit-queue@webkit.org

5 edits
2 deletes in trunk

Unreviewed, rolling out r151549.
http://trac.webkit.org/changeset/151549
https://bugs.webkit.org/show_bug.cgi?id=117741

broke selection in the web inspector source after scrolling
(Requested by smfr on #webkit).

Source/WebCore:

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

rendering/RenderLayerModelObject.cpp:
rendering/RenderLayerModelObject.h:

LayoutTests:

fast/repaint/change-overflow-and-display-of-relative-expected.txt: Removed.
fast/repaint/change-overflow-and-display-of-relative.html: Removed.

9:09 AM BuildingGtk edited by Manuel Rego Casasnovas

Add link to WebKitGTK+ main page in trac.webkit.org (diff)

8:16 AM Changeset in webkit [151684] by commit-queue@webkit.org

3 edits
2 adds in trunk

<video> element delays document load event for ~ 3 seconds
https://bugs.webkit.org/show_bug.cgi?id=90272

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-18
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-preload-no-delay-loadevent.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad):
No need to delay document load event here when preload="none"

LayoutTests:

media/media-preload-no-delay-loadevent-expected.txt: Added.
media/media-preload-no-delay-loadevent.html: Added.

6:16 AM Changeset in webkit [151683] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.1.2

Tagging the WebKitGTK+ 2.1.2 release

6:04 AM Changeset in webkit [151682] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Remove comment about possibility of handling ObjCPolymorphic (it's used by ObjC bindings only)
https://bugs.webkit.org/show_bug.cgi?id=117546

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-18
Reviewed by Xan Lopez.

According to the WebKit IDL spec the modifier ObjCPolymorphic only
applies to the Objective-C bindings generator

bindings/scripts/CodeGeneratorGObject.pm:

(IsPolymorphic): Remove comment. Search parameter 'type' in array, instead of
concatening a series of 'or' conditionals.

5:24 AM Changeset in webkit [151681] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix after r151673
https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

Removed a spurious semicolon in the video sink caps definition.

No new tests, no behavior change.

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

4:23 AM Changeset in webkit [151680] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[WebSpeech] Speech Recognition requires convertValue support in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=117731

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-18
Reviewed by Christophe Dumez.

Build fails after enabling ENABLE_SCRIPTED_SPEECH feature. This patch
resolves the issue.

No new tests. No change in behaviour.

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSDictionary.h:

3:30 AM Changeset in webkit [151679] by Carlos Garcia Campos

4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.1.2 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 2.1.2.

2:35 AM Changeset in webkit [151678] by zarvai@inf.u-szeged.hu

2 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaseline and skipping some tests.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-18

platform/qt-5.0-wk2/fast/repaint/table-cell-collapsed-border-scroll-expected.png: Added.
platform/qt/TestExpectations:
platform/qt/fast/repaint/table-cell-collapsed-border-scroll-expected.txt: Added.

2:13 AM Changeset in webkit [151677] by mary.wu@torchmobile.com.cn

2 edits in trunk/Source/WebCore

[BlackBerry] only notify download client when download error
https://bugs.webkit.org/show_bug.cgi?id=117687

Reviewed by Rob Buis.

When met network error in downloading, we notify the error to download
client through download stream, we shouldn't notify page client the error.
RIM JIRA 419985

platform/network/blackberry/NetworkJob.cpp:

(WebCore::NetworkJob::shouldNotifyClientFailed):

1:35 AM Changeset in webkit [151676] by mario@webkit.org

2 edits in trunk/Source/WebCore

Shader compiler not properly configured for GLES on cairo based ports
https://bugs.webkit.org/show_bug.cgi?id=117705

Reviewed by Martin Robinson.

Configure the shader compiler with SH_ESSL_OUTPUT for GLESv2
compliant platforms, and with SH_GLSL_OUTPUT otherwise.

platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

1:29 AM Changeset in webkit [151675] by Christophe Dumez

2 edits in trunk/Source/WebCore

touching any idl rebuilds all derived sources
https://bugs.webkit.org/show_bug.cgi?id=117708

Reviewed by Kentaro Hara.

Fix preprocess-idls.pl script to update the following files only
if they have changed:
DerivedSources/WebCore/supplemental_dependency.tmp
DerivedSources/WebCore/DOMWindowConstructors.idl
DerivedSources/WebCore/WorkerContextConstructors.idl

This avoids triggering uselessly bindings generation for all IDL
files whenever an IDL file is touched.

No new tests, no behavior change.

bindings/scripts/preprocess-idls.pl:

(WriteFileIfChanged):
(GeneratePartialInterface):

1:18 AM Changeset in webkit [151674] by commit-queue@webkit.org

6 edits in trunk

[GTK][GStreamer] Fullscreen option in video element context menu not working
https://bugs.webkit.org/show_bug.cgi?id=105191

Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

Source/autotools/SetupAutoconfHeader.m4: Removed the use of

fullscreen native media controls.

LayoutTests:

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

platform/gtk-wk1/TestExpectations:

fullscreen/video-controls-drag.html does not time out anymore.

platform/gtk-wk2/TestExpectations:

media/video-display-aspect-ratio.html crashes sometimes.

platform/gtk/TestExpectations:

media/video-playing-and-pause.html was already flaky.

1:09 AM Changeset in webkit [151673] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GStreamer] [texmap] upload a video buffer into the video texture
https://bugs.webkit.org/show_bug.cgi?id=116042

Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

This patch prepares more quickly the texture when the video frame is
already in the GPU memory.

It is done using a new buffer's metadata available in GStreamer 1.2,
and its purpose is to upload buffers into a OpenGL texture.

If the decoder provides buffers with this metadata, the buffer will be
uploaded into the texture used for the video display and it will be
rendered, avoiding a expensive mem copies. This is particularly useful
for Full HD videos, where all the processing and display will be done
in the GPU.

No new tests, covered by existing tests.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkProposeAllocation):

12:20 AM Changeset in webkit [151672] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Mark two tests that are flakily timing out as slow.

12:02 AM Changeset in webkit [151671] by aestes@apple.com

2 edits in trunk/Source/WTF

A static_assert() in RetainPtr.h sometimes causes the build to fail.

Wrap the first argument to a static_assert() in parentheses since it
contains a comma, which sometimes tricks the preprocessor into thinking
the macro is being passed three arguments rather than two.

Reviewed by Brian Weinstein.

wtf/RetainPtr.h:

(WTF::RetainPtr::RetainPtr):

12:00 AM Changeset in webkit [151670] by zandobersek@gmail.com

2 edits in trunk/Source/WTF

REGRESSION (r149184): Build errors in RefPtr.h when building with Clang, C++98 standard
https://bugs.webkit.org/show_bug.cgi?id=116352

Reviewed by Anders Carlsson.

Use the has_feature macro instead of the has_extension one when detecting what features the Clang compiler
that's being used is capable to provide. With the project moving onto using C++11 throughout its components,
there currently exist cases where C++11-specific functionality (for instance std::move) is used despite being
guarded by compiler-specific feature guards that still get enabled even when compiling in C++98 with Clang.
The problematic features are enabled because they're available as C++98 language extensions by Clang.

Using has_feature instead enables the feature guard only if the tested feature is actually standardized in
the currently used language standard.

wtf/Compiler.h:

Jun 17, 2013:

11:24 PM Changeset in webkit [151669] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Extra whitespace in blank line in PlatformPopupMenuData.cpp
https://bugs.webkit.org/show_bug.cgi?id=117627

Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-06-17
Reviewed by Brent Fulgham.

Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::decode):
Removing extra space

11:09 PM Changeset in webkit [151668] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[curl] Set the http response status text
https://bugs.webkit.org/show_bug.cgi?id=117307

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-17
Reviewed by Brent Fulgham.

No new tests, covered by existing ones.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback):

10:59 PM Changeset in webkit [151667] by Brent Fulgham

1 edit
4 adds in trunk/LayoutTests

[Windows] Unreviewed AX gardening of windows-specific results.

platform/win/accessibility/aria-combobox-expected.txt: Added.
platform/win/aria-labelledby-on-input-expected.txt: Added.
platform/win/aria-menubar-menuitems-expected.txt: Added.
platform/win/aria-roles-expected.txt: Added.

10:59 PM Changeset in webkit [151666] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Remove unneeded WebCore namespace in FrameLoaderClientEfl
https://bugs.webkit.org/show_bug.cgi?id=117718

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-17
Reviewed by Christophe Dumez.

WebCoreSupport/FrameLoaderClientEfl.cpp: Remove 'using namespace WebCore'.

6:30 PM Changeset in webkit [151665] by Brent Fulgham

5 edits
3 adds in trunk

AX: Correct accessibility role when -webkit-box:display is used.
https://bugs.webkit.org/show_bug.cgi?id=117706

Reviewed by Chris Fleizach.

Source/WebCore:

accessibility/box-styled-lists.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole): If HTML token is
of the list element type, treat it as a ListItemRole accessibility role, regardless
of what specific renderer is being used.

LayoutTests:

accessibility/box-styled-lists.html: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/accessibility/box-styled-lists-expected.txt: Added.
platform/win/TestExpectations:
platform/win/accessibility/box-styled-lists-expected.txt: Added.

6:19 PM Changeset in webkit [151664] by rniwa@webkit.org

2 edits
1 add in trunk/LayoutTests

Mac rebaseline.

fast/repaint/table-cell-collapsed-border-scroll-expected.png:
fast/repaint/table-cell-collapsed-border-scroll-expected.txt:

6:08 PM Changeset in webkit [151663] by rniwa@webkit.org

9 edits
2 adds in trunk/Source/WTF

Initialize AtomicStringTable in WTFThreadData's constructor
https://bugs.webkit.org/show_bug.cgi?id=117671

Reviewed by Geoffrey Garen.

Extracted AtomicStringTable from AtomicString.cpp into AtomicStringTable.h/cpp
and made WTFThreadDada::WTFThreadData create the atomic string table for the thread.

This eliminates a branch from stringTable() in AtomicString.cpp.

GNUmakefile.list.am:
WTF.pro:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

wtf/text/AtomicString.cpp:

(WTF::stringTable):

wtf/text/AtomicStringTable.cpp: Added.

(WTF::AtomicStringTable::create):
(WTF::AtomicStringTable::destroy):

wtf/text/AtomicStringTable.h: Added.

(WTF::AtomicStringTable::table):

5:54 PM Changeset in webkit [151662] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Add some UNUSED_PARAMs to RenderBlock.cpp so that it builds properly if CSS_EXCLUSIONS is disabled.
https://bugs.webkit.org/show_bug.cgi?id=117722.
Rubberstamped by Jon Lee.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

5:41 PM Changeset in webkit [151661] by Beth Dakin

9 edits in trunk/Source

PageBanners appear over HTML5 video when media element is in full screen mode
https://bugs.webkit.org/show_bug.cgi?id=117721
-and corresponding-
<rdar://problem/13686998>

Reviewed by Sam Weinig.

Source/WebCore:

Update the scrolling tree when a header/footer has been removed.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):

Source/WebKit2:

When an element enters fullscreen, hide the banners. Show them again when the
element exits fullscreen.

WebProcess/FullScreen/WebFullScreenManager.cpp:

(WebKit::WebFullScreenManager::willEnterFullScreen):
(WebKit::WebFullScreenManager::willExitFullScreen):

Handle hiding and showing by removing or re-creating a parent layer for m_layer.

WebProcess/WebPage/PageBanner.cpp:

(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):

WebProcess/WebPage/PageBanner.h:
WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::hide):
(WebKit::PageBanner::showIfHidden):
(WebKit::PageBanner::mouseEvent):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::hidePageBanners):
(WebKit::WebPage::showPageBanners):

WebProcess/WebPage/WebPage.h:

5:23 PM Changeset in webkit [151660] by roger_fong@apple.com

8 edits in trunk/Source

Modify Windows makefiles to copy some bin output into Program Files.
https://bugs.webkit.org/show_bug.cgi?id=117714.
<rdar://problem/14179054>

Reviewed by Brent Fulgham.

WTF.vcxproj/WTF.make:
JavaScriptCore.vcxproj/JavaScriptCore.make:
WebCore.vcxproj/WebCore.make:
WebKit.vcxproj/WebKit.make:

5:09 PM Changeset in webkit [151659] by roger_fong@apple.com

12 edits
1 add in tags/Safari-537.45.1

Disable some feature flags and update test expectations.
<rdar://problem/14171207>.

Rubberstamped by Jon Lee.

Configurations/FeatureDefines.xcconfig:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

platform/mac/TestExpectations:
platform/mac/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
platform/mac/fast/js/constructor-length-expected.txt:

4:50 PM Changeset in webkit [151658] by msaboff@apple.com

12 edits in branches/dfgFourthTier/Source/JavaScriptCore

FTL: Add another temp register regT4 to JSInterfaceJIT
https://bugs.webkit.org/show_bug.cgi?id=117719

Reviewed by Geoffrey Garen.

Made the dedicated bucketCounterRegister to be regT4 and then used regT4 wherever
bucketCounterRegister had been used. Since it is masked whenever it is used and
we are looking for some randomness in the register anyway, we can use it without
any issues.

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::JIT::emitValueProfilingSite):

jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):

jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):

jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_get_argument_by_val):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_get_argument_by_val):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):

jit/JITPropertyAccess32_64.cpp:

jit/JITStubCall.h:

(JSC::JITStubCall::callWithValueProfiling):

jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

3:42 PM Changeset in webkit [151657] by mvujovic@adobe.com

2 edits in trunk/Source/WebCore

Crash in loadPendingShaders
https://bugs.webkit.org/show_bug.cgi?id=117665

Reviewed by Dean Jackson.

Speculative fix because the crash reports do not contain a test case.

Rearrange the conditions to check m_state.hasPendingShaders() first. Additionally, check if
m_state.style() is non-null.

No new tests. We don't know how to reproduce this crash yet.

css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingShaders):

2:50 PM Changeset in webkit [151656] by commit-queue@webkit.org

19 edits in trunk/Source

REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
https://bugs.webkit.org/show_bug.cgi?id=20599

Add a "Download Video"/"Download Audio" context menu item to download media
elements.

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-17
Reviewed by Beth Dakin.

Source/WebCore:

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

English.lproj/Localizable.strings: Updated to

include localizable strings for "Download Video" and "Download Audio".

page/ContextMenuController.cpp: Updated to

include and handle a "Download Video/Audio" context menu item.

platform/ContextMenuItem.h:

platform/LocalizedStrings.cpp:
platform/LocalizedStrings.h:
platform/efl/LocalizedStringsEfl.cpp:
platform/gtk/LocalizedStringsGtk.cpp:
platform/qt/LocalizedStringsQt.cpp:

Updated to include localizable strings for "Download Video" and "Download Audio".

Source/WebKit/efl:

WebCoreSupport/AssertMatchingEnums.cpp:
ewk/ewk_contextmenu.h:

Updated to include new EWK enum type for "Download Video/Audio" context menu item.

Source/WebKit2:

Shared/API/c/WKContextMenuItemTypes.h: Updated to include

an enum type for the "Download Video/Audio" context menu item.

Shared/API/c/WKSharedAPICast.h: Updated to associate

the enums in WebKit and WebCore that handle the "Download Video/Audio"
context menu item.

UIProcess/API/efl/ewk_context_menu.cpp:
UIProcess/API/efl/ewk_context_menu_item.cpp:
UIProcess/API/efl/ewk_context_menu_item.h:

Updated to include new EWK enum type for "Download Video/Audio" context menu item.

UIProcess/WebPageProxy.cpp: Updated to

handle the "Download Video/Audio" context menu item mouse click
and download the media item in the UI process.

2:27 PM Changeset in webkit [151655] by Lucas Forschler

5 edits in tags/Safari-537.45.1/Source

Versioning.

2:22 PM Changeset in webkit [151654] by Lucas Forschler

1 copy in tags/Safari-537.45.1

New Tag.

2:18 PM Changeset in webkit [151653] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][CSS Shaders] Use forwarding header for TextureMapperPlatformCompiledProgram.h
https://bugs.webkit.org/show_bug.cgi?id=117712

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-17
Reviewed by Noam Rosenthal.

Shared/CoordinatedGraphics/WebCustomFilterProgramProxy.h:

1:23 PM Changeset in webkit [151652] by zoltan@webkit.org

8 edits
2 copies in trunk

[CSS Shapes] Consider bottom borders when calculating the position of the overflow
https://bugs.webkit.org/show_bug.cgi?id=117663

Reviewed by Alexandru Chiculita.

When you have a shape and the content overflows from the shape we need to push the overflow below the content box,
not below the border box. We didn't consider the bottom borders of the content box, now I fixed it too and the overflow
just starts after the content box. I added a new helper function called pushShapeContentOverflowBelowTheContentBox. Now
both the shape in flow thread and the shape overflow use the same function. I added a new test and modified the existing
tests to cover all the affected cases.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
Existing overflow tests also modified to test the behavior:

fast/exclusions/shape-inside/shape-inside-empty-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine):
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread):

LayoutTests:

fast/exclusions/shape-inside/shape-inside-empty-expected.html:
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content-expected.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html.
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-block-content.html: Copied from LayoutTests/fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html.
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html:
fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html:

11:54 AM Changeset in webkit [151651] by mark.lam@apple.com

24 edits
4 adds in branches/dfgFourthTier/Source

Rolling r151456, r151420 back in with some fixes.
https://bugs.webkit.org/show_bug.cgi?id=117390.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

New changes on top of the old patch:

Renamed CallFrame::beginAt() to CallFrame::find(), and also provide a version that takes a CallFrame* to search for.

There are 3 types of users of the StackIterator. We need to cater
to each of these as follows:

Users who want a stack trace
- Here we need to start iterating from vm.topCallFrame.
- To do this, create the StackIterator as follows:

StackIterator iter = vm.topCallFrame->begin();

Users who want their caller frame
- Here we need to start iterating from the specified CallFrame*.
- To do this, create the StackIterator as follows:

StackIterator iter = callFrame->begin();

Users who want the frame of a specific JSFunction object
- Here we need to start iterating from vm.topCallFrame and find the frame that has a callee matching the specified JSFunction*.
- To do this, create the StackIterator as follows:

StackIterator iter = exec->find(functionObj);

The previous layout test failures were due to conflation of case 1
and 2. They are now handled appropriately.

Fixed a pre-existing layout test crash in inspector/profiler/cpu-profiler-agent-crash-on-start.html.

API/JSContextRef.cpp:

(JSContextCreateBacktrace):

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
interpreter/CallFrame.cpp:
interpreter/CallFrame.h:

(JSC::ExecState::setInlineCallFrame):
(ExecState):

interpreter/CallFrameInlines.h:

(JSC::CallFrame::begin):
(JSC::CallFrame::find):
(JSC::CallFrame::end):

interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::debug):

interpreter/Interpreter.h:

(Interpreter):

interpreter/StackIterator.cpp: Added.

(JSC::StackIterator::StackIterator):
(JSC::StackIterator::gotoNextFrame):
(JSC::StackIterator::find):
(JSC::StackIterator::Frame::codeType):
(JSC::StackIterator::Frame::functionName):
(JSC::StackIterator::Frame::sourceURL):
(JSC::StackIterator::Frame::toString):
(JSC::StackIterator::Frame::bytecodeOffset):
(JSC::StackIterator::Frame::line):
(JSC::StackIterator::Frame::column):
(JSC::StackIterator::Frame::arguments):
(JSC::StackIterator::Frame::retrieveExpressionInfo):
(JSC::StackIterator::Frame::logicalFrame):
(JSC::StackIterator::Frame::logicalCallerFrame):
(JSC::jitTypeName):
(JSC::printIndents):
(JSC::printif):
(JSC::StackIterator::Frame::print):
(debugPrintCallFrame):

interpreter/StackIterator.h: Added.

(StackIterator::Frame):
(JSC::StackIterator::Frame::create):
(JSC::StackIterator::Frame::isJSFrame):
(JSC::StackIterator::Frame::callFrame):

interpreter/StackIteratorPrivate.h: Added.

(StackIterator):
(JSC::StackIterator::operator*):
(JSC::StackIterator::operator->):
(JSC::StackIterator::operator==):
(JSC::StackIterator::operator!=):
(JSC::StackIterator::operator++):
(JSC::StackIterator::end):

jsc.cpp:

(functionJSCStack):

profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

profiler/ProfileNode.h:

(ProfileNode):

runtime/JSFunction.cpp:

(JSC::retrieveArguments):
(JSC::JSFunction::argumentsGetter):
(JSC::skipOverBoundFunctions):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::defineOwnProperty):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):

runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetPrototypeOf):

runtime/Operations.h:

Source/WebCore:

No new tests.

ForwardingHeaders/interpreter/StackIterator.h: Copied from Source/WebCore/ForwardingHeaders/interpreter/StackIterator.h.
bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStack):

11:53 AM Changeset in webkit [151650] by betravis@adobe.com

2 edits
2 adds in trunk/LayoutTests

[CSS Exclusions] Implement text alignment for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=101086

Reviewed by Alexandru Chiculita.

Adding tests to make sure that shape-inside layout correctly supports
the different values of text-align.

fast/exclusions/resources/multi-segment-polygon.js:

(createOrInsert):

fast/exclusions/shape-inside/shape-inside-text-align-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-text-align.html: Added.

11:17 AM Changeset in webkit [151649] by fpizlo@apple.com

8 edits
1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support Switch
https://bugs.webkit.org/show_bug.cgi?id=117704

Reviewed by Oliver Hunt.

bytecode/CodeBlock.h:

(JSC::CodeBlock::clearImmediateSwitchJumpTables):

ftl/FTLAbbreviations.h:

(JSC::FTL::buildFPToSI):
(JSC::FTL::buildSwitch):
(JSC::FTL::addCase):
(FTL):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLink.cpp:

(JSC::FTL::link):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(LowerDFGToLLVM):

ftl/FTLOutput.h:

(JSC::FTL::Output::fpToInt):
(JSC::FTL::Output::fpToInt32):
(Output):
(JSC::FTL::Output::switchInstruction):

ftl/FTLSwitchCase.h: Added.

(FTL):
(SwitchCase):
(JSC::FTL::SwitchCase::SwitchCase):
(JSC::FTL::SwitchCase::value):
(JSC::FTL::SwitchCase::target):

11:06 AM Changeset in webkit [151648] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

Cache FatFinger Text Result.
https://bugs.webkit.org/show_bug.cgi?id=107403.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-17
Reviewed by Rob Buis.

Internally Reviewed by Genevieve Mak.
Cache the FatFinger text result for later use in TouchEventHandler.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::contextNode):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

WebKitSupport/TouchEventHandler.h:

(BlackBerry::WebKit::TouchEventHandler::cacheTextResult):
(TouchEventHandler):

11:05 AM Changeset in webkit [151647] by igor.o@sisa.samsung.com

4 edits
6 adds in trunk

[CSS Regions] ::before and ::after pseudo-elements are not displayed for regions
https://bugs.webkit.org/show_bug.cgi?id=80163

Source/WebCore:

When the implementation of the before/after was moved to the DOM, before/after generated
content stoppped to work with css regions. The problem happens when:

RenderRegion can not have children and when the PseudoElement::attach tries to create a renderer for the

generated content, it fails.

RenderRegion::canHaveGeneratedChildren should not be false because regions can have generated content.

Reviewed by David Hyatt.

Tests: fast/regions/region-dynamic-after-before.html

fast/regions/region-generated-content-before-after.html

dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::shouldCreateRenderer):

rendering/RenderRegion.h:

LayoutTests:

Add two simple tests verifying if region works with before/after generated content.

Reviewed by David Hyatt.

fast/regions/region-dynamic-after-before.html: Added.
fast/regions/region-generated-content-before-after.html: Added.
platform/mac/fast/regions/region-dynamic-after-before-expected.png: Added.
platform/mac/fast/regions/region-dynamic-after-before-expected.txt: Added.
platform/mac/fast/regions/region-generated-content-before-after-expected.png: Added.
platform/mac/fast/regions/region-generated-content-before-after-expected.txt: Added.

10:53 AM Changeset in webkit [151646] by mrowe@apple.com

4 edits
1 copy in trunk/Source/WebKit2

<rdar://problem/13145014> Allow CoreIPC messages to transmit importance boosts

Transmitting the importance boost from the UI process to the web process is particularly
important when disabling process suppression on a web process, as it will minimize the
delays that can occur before the message instructing process suppression to be disabled
is processed by the web process.

We keep the importance boost alive for the duration of the CoreIPC message handler. We
achieve this by having an ImportanceAssertion object that owns the assertion, and whose
lifetime is tied to that of the MessageDecoder.

Reviewed by Anders Carlsson.

Platform/CoreIPC/MessageDecoder.cpp:

(CoreIPC::MessageDecoder::setImportanceAssertion): Associate an importance assertion
with this message.

Platform/CoreIPC/MessageDecoder.h:
Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::open): Mark our receive port as allowing importance boosts to be received.
(CoreIPC::Connection::receiveSourceEventHandler):

Platform/CoreIPC/mac/ImportanceAssertion.h:

(CoreIPC::ImportanceAssertion::create):
(CoreIPC::ImportanceAssertion::~ImportanceAssertion): Release the assertion.
(CoreIPC::ImportanceAssertion::ImportanceAssertion): Take an assertion if a boost was present in
the Mach message.

10:08 AM Writing Layout Tests for DumpRenderTree edited by bfulgham@webkit.org

(diff)

9:40 AM Changeset in webkit [151645] by mrowe@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/14051357> Web processes sometimes remain in a suppressed
state after their window is unoccluded.

The code in WKView that responds to occlusion notifications was incorrectly
treating the window's occlusion state as being an enum rather than the set of
flags that it is.

Reviewed by Oliver Hunt.

UIProcess/API/mac/WKView.mm:

(-[WKView _windowDidChangeOcclusionState:]): Test only the visibility state.
(-[WKView setWindowOcclusionDetectionEnabled:]): Ditto.

9:22 AM Changeset in webkit [151644] by fpizlo@apple.com

9 edits
6 adds in branches/dfgFourthTier

fourthTier: Add CFG simplification for Switch
https://bugs.webkit.org/show_bug.cgi?id=117677

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This is for completeness. It only speeds up a microbenchmark at this point.
Broadly, we want all control constructs to be known to the CFG simplifier.

dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::noBlocks):
(JSC::DFG::CFGSimplificationPhase::oneBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

runtime/JSCJSValue.h:

(JSValue):

runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureStrictEqual):
(JSC):

Source/WTF:

Reviewed by Mark Hahnenberg.

wtf/TriState.h:
wtf/text/StringImpl.h:

LayoutTests:

Reviewed by Mark Hahnenberg.

fast/js/regress/script-tests/switch-constant.js: Added.

(foo):
(bar):

fast/js/regress/script-tests/switch.js: Added.

(foo):
(bar):

fast/js/regress/switch-constant-expected.txt: Added.
fast/js/regress/switch-constant.html: Added.
fast/js/regress/switch-expected.txt: Added.
fast/js/regress/switch.html: Added.

8:26 AM Changeset in webkit [151643] by michael.bruning@digia.com

2 edits in trunk/Source/WebCore

[Mac] Remove unmaintained GStreamer specific video code.
https://bugs.webkit.org/show_bug.cgi?id=117694

Reviewed by Philippe Normand.

No new tests, no behaviour change.

platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController setMediaElement:]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):

7:35 AM Changeset in webkit [151642] by michael.bruning@digia.com

35 edits
6 deletes in trunk

[Qt] Remove Qt specific QTKIT flagged code.
https://bugs.webkit.org/show_bug.cgi?id=117635

Reviewed by Simon Hausmann.

Due to disabling QTKIT for Qt in r151546, the
code the flags that are not taken into account
anymore and the code that has been rendered
unreachable by this are removed.

Source/widgetsapi.pri:

Source/WebCore:

No new tests, no behavioural change.

Target.pri:
WebCore.exp.in:
page/Settings.cpp:
page/Settings.h:
platform/KURL.h:
platform/SharedBuffer.h:
platform/cf/KURLCFNet.cpp:

(WebCore::KURL::fileSystemPath):

platform/cf/SharedBufferCF.cpp:
platform/graphics/FloatSize.h:
platform/graphics/IntRect.h:
platform/graphics/IntSize.h:
platform/graphics/MediaPlayer.cpp:

(WebCore::installedMediaEngines):

platform/graphics/cg/FloatSizeCG.cpp:
platform/graphics/cg/IntRectCG.cpp:
platform/graphics/mac/MediaPlayerPrivateQTKit.h:
platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::paint):
(-[WebCoreMovieObserver layerHostChanged:]):

platform/mac/SharedBufferMac.mm:

(+[WebCoreSharedBufferData initialize]):
(WebCore::SharedBuffer::createWithContentsOfFile):

Source/WebKit:

WebKit1.pro:

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/qt:

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):

WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/FullScreenVideoQt.cpp:

(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::isValid):

WebCoreSupport/FullScreenVideoQt.h:
WebCoreSupport/InitWebCoreQt.cpp:

(WebCore::initializeWebCoreQt):

WebCoreSupport/QTKitFullScreenVideoHandler.h: Removed.
WebCoreSupport/QTKitFullScreenVideoHandler.mm: Removed.
WebCoreSupport/WebSystemInterface.h: Removed.
WebCoreSupport/WebSystemInterface.mm: Removed.

Source/WebKit2:

Target.pri:
UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

WebProcess/WebCoreSupport/qt/WebSystemInterface.h: Removed.
WebProcess/WebCoreSupport/qt/WebSystemInterface.mm: Removed.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/qt/WebProcessMainQt.cpp:

(WebKit::WebProcessMainQt):

7:32 AM Changeset in webkit [151641] by sergio@webkit.org

2 edits in trunk/LayoutTests

Remove invalid checks from block-cursor-overtype-mode.html
https://bugs.webkit.org/show_bug.cgi?id=117587

Reviewed by Darin Adler.

The test uses an array of ">" "<" symbols to perform comparisons
between consecutive positions of the block cursor. Since those
checks are done for each pair of consecutive characters the total
amount of checks is lengthOfTheWord - 1. We were adding an extra
symbol that was not used at all in the test.

editing/selection/block-cursor-overtype-mode.html:

6:57 AM Changeset in webkit [151640] by allan.jensen@digia.com

4 edits in trunk/Source/WebCore

REGRESSSION(r151632) : Build error on ASSERT(WTF_USE_GRAMMAR_CHECKING)
https://bugs.webkit.org/show_bug.cgi?id=117692

Reviewed by Jocelyn Turcotte.

Ifdef the feature-depending code and fix the assertions to check runtime conditions.

editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::markBadGrammar):

editing/TextCheckingHelper.cpp:

(WebCore::findBadGrammars):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::markAllBadGrammar):
(WebCore::checkTextOfParagraph):

editing/TextCheckingHelper.h:

6:43 AM Changeset in webkit [151639] by kangil.han@samsung.com

2 edits in trunk/Tools

Unreviewed. Add my email to a DOM watchlist.

Scripts/webkitpy/common/config/watchlist:

6:32 AM Changeset in webkit [151638] by g.czajkowski@samsung.com

19 edits in trunk/Source

Unreviewed, rolling out r151632.
http://trac.webkit.org/changeset/151632
https://bugs.webkit.org/show_bug.cgi?id=117585

Debug build error ASSERT(WTF_USE_GRAMMAR_CHECKING) for non MAC
platforms

Source/WebCore:

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::createAndAppendSpellingAndGrammarSubMenu):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):

platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

platform/LocalizedStrings.h:
platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):
(WebCore::contextMenuItemTagCheckGrammarWithSpelling):

Source/WebKit/gtk:

webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

Source/WebKit/mac:

WebCoreSupport/WebContextMenuClient.mm:

(fixMenusReceivedFromOldClients):

Source/WebKit2:

Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

UIProcess/API/efl/ewk_context_menu_item.cpp:

(getEwkActionFromWKTag):

UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(onContextMenuShow):
(TEST_F):

UIProcess/API/gtk/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):

Source/WTF:

wtf/Platform.h:

5:24 AM Changeset in webkit [151637] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

Unreviewed. Fix make distcheck.

GNUmakefile.list.am: Remove non existent files from compilation

and add a missing header file.

2:44 AM Changeset in webkit [151636] by zarvai@inf.u-szeged.hu

1 edit
2 moves in trunk/LayoutTests

[Qt] Unreviewed gardening. Correcting rebaselining after r151634.

platform/qt-5.0-wk2/compositing/repaint/fixed-background-scroll-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt.
platform/qt-5.0-wk2/compositing/repaint/positioned-movement-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt.

1:39 AM Changeset in webkit [151635] by Carlos Garcia Campos

3 edits in trunk

Unreviewed. Rename gobject_introspection_required variable.

As gobject_introspection_required_version for consistency with all
other required_version variables.

Source/autotools/FindDependencies.m4:
Source/autotools/Versions.m4:

1:17 AM Changeset in webkit [151634] by zarvai@inf.u-szeged.hu

1 edit
3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining repaint tests, see bug 115372.

platform/qt-5.0-wk2/fast/repaint/change-overflow-and-display-of-relative-expected.txt: Rebaselining after r151549.
platform/qt-5.0-wk2/fast/repaint/fixed-background-scroll-expected.txt: Rebaselining after r151624.
platform/qt-5.0-wk2/fast/repaint/positioned-movement-expected.txt: Rebaselining after r151622.

12:43 AM Changeset in webkit [151633] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed GTK gardening.

Scripts/run-gtk-tests:

(TestRunner): Skip three WebKit2APITests suites that are currently timing out.

12:28 AM Changeset in webkit [151632] by g.czajkowski@samsung.com

19 edits in trunk/Source

Context menu grammar checking items are available when GRAMMAR_CHECKING macro is off
https://bugs.webkit.org/show_bug.cgi?id=117585

Reviewed by Anders Carlsson.

Source/WebCore:

Do not add "Check Grammar With Spelling" and "Ignore Grammar" to the context menu
when GRAMMAR_CHECKING is off.
Replace "Spelling and Grammar" with "Spelling" as the sub menu title and "Show/Hide Spelling
and Grammar" with "Show/Hide Spelling" when GRAMMAR_CHECKING is off.

Additionally, guard grammar checking in context menu code to not necessarily
compile it.

No new layout tests because every port has a different way of showing
spelling/grammar context menu items.

page/ContextMenuController.cpp:

platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

platform/LocalizedStrings.h:
platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

platform/qt/LocalizedStringsQt.cpp:

(WebCore::contextMenuItemTagCheckGrammarWithSpelling):
(WebCore::contextMenuItemTagSpellingMenu):
(WebCore::contextMenuItemTagShowSpellingPanel):

Source/WebKit/gtk:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

webkit/webkitglobals.cpp:

(webkit_context_menu_item_get_action):

Source/WebKit/mac:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

WebCoreSupport/WebContextMenuClient.mm:

(fixMenusReceivedFromOldClients):

Source/WebKit2:

Add GRAMMAR_CHECKING guard to the context menu grammar items.

Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):

UIProcess/API/efl/ewk_context_menu_item.cpp:

(getEwkActionFromWKTag):

UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

(checkSpellingItemsAvailability):
Change callback name, to be consistent with a newly added.

(checkSpellingAndGrammarSubmenuAvailability):
(checkGrammarWithSpellingItemAvailability):
Add two unit tests for EFL to check whether context menu grammar items are
available only when GRAMMAR_CHECKING macro is enabled.

UIProcess/API/gtk/WebKitContextMenuActions.cpp:

(webkitContextMenuActionGetActionTag):
(webkitContextMenuActionGetForContextMenuItem):
(webkitContextMenuActionGetLabel):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::contextMenuItemSelected):

Source/WTF:

Enable GRAMMAR_CHECKING for WebKit ports that use/implement it.

wtf/Platform.h:

12:23 AM Changeset in webkit [151631] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk-wk1/TestExpectations: Add a crashing expectation for a test that most likely regressed with r151021.
platform/gtk/TestExpectations: Add failure expectations for a couple of tests failing due to stack size misbehavior.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed