⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 3, 2013:

11:48 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
11:44 PM Changeset in webkit [152390] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Coordinated Graphics] Don't use && operator in ASSERT
​https://bugs.webkit.org/show_bug.cgi?id=118377

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-07-03
Reviewed by Noam Rosenthal.

We don't use && opeartor in ASSERT because it's impossible to know which
condition caused the assertion.

  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:

(WebCore::CoordinatedBackingStoreTile::swapBuffers):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):

11:20 PM Changeset in webkit [152389] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Support some more editing keyboard events
​https://bugs.webkit.org/show_bug.cgi?id=118346

Patch by KyungTae Kim <​ktf.kim@samsung.com> on 2013-07-03
Reviewed by Gyuyoung Kim.

For editable contents, support the shortcuts for copy, page, cut, select all, undo and redo.

  • platform/efl/EflKeyboardUtilities.cpp:
10:28 PM Changeset in webkit [152388] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: Items the img aria role aren't inserting an object replacement character
​https://bugs.webkit.org/show_bug.cgi?id=118259

Source/WebCore:

Reviewed by Tim Horton.

VoiceOver relies on object replacement characters being emitted when asking for selected text.
This has worked if a real <img> is used, but if role="img" is used on a <div>, for example,
no emission is performed, which leads to missed elements in text.

Test: platform/mac/accessibility/aria-image-emits-object-replacement.html

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):
(WebCore::TextIterator::advance):

LayoutTests:

Reviewed by Reviewed by Tim Horton.

  • accessibility/non-native-image-crash-expected.txt:
  • platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt: Added.
  • platform/mac/accessibility/aria-image-emits-object-replacement.html: Added.
  • platform/mac/accessibility/img-fallsback-to-title-expected.txt:

Update expected tests where role="img" now emits replacement character.

9:31 PM Changeset in webkit [152387] by kangil.han@samsung.com
  • 6 edits in trunk/Source/WebCore

Adopt is/toHTMLMapElement for code cleanup
​https://bugs.webkit.org/show_bug.cgi?id=118235

Reviewed by Andreas Kling.

To enhance readability, this patch adopts is/toHTMLMapElement.
This also helps out to reduce duplicated use of static_cast.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getImageMap):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLMapElement.h:

(WebCore::isHTMLMapElement):
(WebCore::toHTMLMapElement):

5:47 PM Changeset in webkit [152386] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed build correction after r15283.

  • WebCorePrefix.h: Remove include directive for CGFloat.h, as it

is not present in all Windows build environments.

5:39 PM Changeset in webkit [152385] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Exclude unsupported QuartzCore Features.
​https://bugs.webkit.org/show_bug.cgi?id=118374

Reviewed by Anders Carlsson.

  • WebCore.vcxproj/WebCoreCG.props: Exclude a few non-Windows

concepts from the QuartzCore headers.

5:03 PM Changeset in webkit [152384] by barraclough@apple.com
  • 5 edits in trunk/Source/WebCore

Simplify PageThrottler ownership.
​https://bugs.webkit.org/show_bug.cgi?id=118372

Reviewed by Sam Weinig.

  • page/Page.cpp:

(WebCore::Page::~Page):

  • 'clearPage' method removed - just clear the own pointer.
  • page/Page.h:
    • make m_pageThrottler an OwnPtr.
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::~PageThrottler):

  • moved 'setThrottled(false)' from 'clearPage' (removed).

(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):

  • no need to check 'm_page'
  • page/PageThrottler.h:

(WebCore::PageThrottler::create):

  • create a PassOwnPtr, not PassRefPtr.
5:01 PM Changeset in webkit [152383] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Updates to support changes in CoreGraphics libraries.
​https://bugs.webkit.org/show_bug.cgi?id=118373

Reviewed by Anders Carlsson.

  • WebCorePrefix.h: Include definitions for isnan/round/roundf for versions of

Visual Studio that do not provide them natively.

4:56 PM Changeset in webkit [152382] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Implement mechanism to detect (partially) hidden blocked plugins.
​https://bugs.webkit.org/show_bug.cgi?id=117998

Patch by Gordon Sheridan <​gordon_sheridan@apple.com> on 2013-07-03
Reviewed by Dean Jackson.

Source/WebCore:

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::replacementTextRect):
Added private method for calculating the size of the replacement text for blocked plugins.

(WebCore::RenderEmbeddedObject::isReplacementObscured):
Added public method to determine if the EMBED element used for a blocked plugin is inaccessible to the user.

  • rendering/RenderEmbeddedObject.h:

Declare the two new methods mentioned above.

  • WebCore.exp.in:

Export RenderEmbeddedObject::isReplacementObscured().

Source/WebKit2:

  • Shared/Plugins/Netscape/PluginInformation.h:
  • Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::plugInInformationReplacementObscuredKey):
Add key for plugInInformation dictionaries.

(WebKit::createPluginInformationDictionary):
Add boolean parameter identifying whether the replacement for a blocked plugin is obscured, and add it to the dictionary.

  • Shared/API/c/WKPluginInformation.h:
  • Shared/API/c/WKPluginInformation.cpp:

(WKPluginInformationReplacementObscuredKey):
Provide the C API for the plugInInformationReplacementObscuredKey().

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Add bool replacementObscured parameter to pass on argument to createPluginInformationDictionary().

  • UIProcess/WebPageProxy.messages.in:

Add bool replacementObscured parameter to DidBlockInsecurePluginVersion() message.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):
Invoke isReplacementObscured() method for blocked plugins.

4:38 PM Changeset in webkit [152381] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Unreviewed build correction.

  • WTF.vcxproj/copy-files.cmd: Limit path (for this file) to DOS-only to avoid

the Cygwin variant of rmdir from being used.

4:13 PM Changeset in webkit [152380] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Guard remaining calls to decodeURIComponent with a try/catch.

​https://bugs.webkit.org/show_bug.cgi?id=118371

Reviewed by Joseph Pecoraro.

  • UserInterface/Main.js:

(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):

  • UserInterface/Utilities.js:

(arrayResult):
(queryString):

3:33 PM Changeset in webkit [152379] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152375. <rdar://problem/14349560>

3:31 PM Changeset in webkit [152378] by Lucas Forschler
  • 2 edits in tags/Safari-537.48.2/Source/WebKit2

Merged r152375. <rdar://problem/14349560>

3:30 PM Changeset in webkit [152377] by Lucas Forschler
  • 5 edits in tags/Safari-537.48.2/Source

Versioning.

3:28 PM Changeset in webkit [152376] by Lucas Forschler
  • 1 copy in tags/Safari-537.48.2

New Tag.

3:28 PM Changeset in webkit [152375] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
<rdar://problem/14349560> Flash Player: deny ipc-posix-sem MacromediaSemaphoreDig on many sites

Reviewed by Sam Weinig.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: semaphore-owner doesn't appear to work the way we need it to, removing it (at least for now).
1:19 PM Changeset in webkit [152374] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Ran update-webkit-localizable-strings.

Rubber-stamped by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
1:16 PM Changeset in webkit [152373] by dfarler@apple.com
  • 1 edit
    1 add in trunk/Tools

Add Makefile to WebKitLauncher
​https://bugs.webkit.org/show_bug.cgi?id=118365

Reviewed by Mark Rowe.

  • WebKitLauncher/Makefile: Added.
12:45 PM Changeset in webkit [152372] by ap@apple.com
  • 2 edits in branches/safari-537-branch/LayoutTests

Skipping inspector tests that had other expectations, because specific rules override
general rules, and we need to skip all inspector tests.
<rdar://problem/12318375>

  • platform/mac/TestExpectations:
11:50 AM Changeset in webkit [152371] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[ATK] Leak: more leaks in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=118362

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.

Free the memory created by g_strdup_printf.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::language):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::language):

11:40 AM Changeset in webkit [152370] by ap@apple.com
  • 2 edits in branches/safari-537-branch/Tools

Merged r152195.

11:06 AM Changeset in webkit [152369] by commit-queue@webkit.org
  • 4 edits in trunk

WebTextCheckerClient doesn't initialize output arguments.
​https://bugs.webkit.org/show_bug.cgi?id=83683

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-03
Reviewed by Martin Robinson.

Source/WebKit2:

Callers of checkSpellingOfString and checkGrammarOfString expect
certain default values when no misspelled (or bad grammar) string
is found. They try to do that by initialising the reply arguments
that go into the IPC calls, but these values are ultimately ignored (see
HandleMessage.h, where the replyArguments are declared).

In the past, this seems to have led to various issues, (see
TextCheckingHelper::findFirstMisspelling in TextCheckingHelper.cpp),
where these return values are asserted and checked to be in the right range.

This patch initialises the values, so even if no available client
implements the methods (or if the implementation forgets to do it) the callers
will have their expected output.

However, and for a general case, we probably need a way to tell the caller
that any existing value in the output arguments will be ignored.

  • UIProcess/WebTextCheckerClient.cpp:

(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):

LayoutTests:

Unskip editing/pasteboard/pasting-empty-html-falls-back-to-text.html, which no longer
crashes after the fix.

  • platform/gtk-wk2/TestExpectations:
10:45 AM Changeset in webkit [152368] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152317. <rdar://problem/14309423>

10:35 AM Changeset in webkit [152367] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
​https://bugs.webkit.org/show_bug.cgi?id=116867

Reviewed by Anders Carlsson.

We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.

There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

10:28 AM Changeset in webkit [152366] by jer.noble@apple.com
  • 2 edits in trunk/Tools

Xcode often gets in a state where the debugger is completely unresponsive
​https://bugs.webkit.org/show_bug.cgi?id=118157

The GetPointeeData() operations we use to retrieve strings is extremely expensive.
Rather than pull the character data out of the debugger one byte at a time
through the GetPointeeData() API, retrieve the memory contents of the string through
the ReadMemory() API, and convert the retrieved memory into a python string.

Reviewed by Anders Carlsson.

  • lldb/lldb_webkit.py:

(lldb_init_module.lldb_webkit):
(guess_string_length):
(ustring_to_string):
(lstring_to_string):

10:28 AM Changeset in webkit [152365] by ap@apple.com
  • 2 edits in branches/safari-537-branch/LayoutTests

Skip inspector tests, because they are failing with production builds.
<rdar://problem/12318375>

  • platform/mac/TestExpectations:
10:10 AM Changeset in webkit [152364] by Lucas Forschler
  • 5 edits in tags/Safari-537.48.1/Source

Versioning.

10:07 AM Changeset in webkit [152363] by Lucas Forschler
  • 1 copy in tags/Safari-537.48.1

New Tag.

10:05 AM Changeset in webkit [152362] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

Unreviewed, rolling out r152356.
​http://trac.webkit.org/changeset/152356
​https://bugs.webkit.org/show_bug.cgi?id=118361

Broke JSCore tests (Requested by andersca on #webkit).

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::create):

  • wtf/text/StringImpl.h:
10:03 AM Changeset in webkit [152361] by Lucas Forschler
  • 1 delete in tags/Safari-537.48.1

Remove Tag.

9:48 AM Changeset in webkit [152360] by Lucas Forschler
  • 5 edits in branches/safari-537-branch/Source

Versioning.

9:46 AM Changeset in webkit [152359] by Lucas Forschler
  • 5 edits in tags/Safari-537.48.1/Source

Versioning.

9:43 AM Changeset in webkit [152358] by Lucas Forschler
  • 1 copy in tags/Safari-537.48.1

New Tag.

9:12 AM Changeset in webkit [152357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Output arguments used in IPC calls should be returned initialised
​https://bugs.webkit.org/show_bug.cgi?id=118354

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-03
Reviewed by Anders Carlsson.

When Download::shouldDecodeSourceDataOfMIMEType and Download::retrieveDestinationWithSuggestedFilename
call DownloadProxy::shouldDecodeSourceDataOfMIMEType and DownloadProxy::decideDestinationWithSuggestedFilename
through IPC, they assume the output arguments result and allowOverwrite have
been initialised.

This patch initialises these arguments also in the unlikely event that a
m_webContext is not available.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):

9:03 AM EFLWebKit edited by Sergio Correia
Added a short paragraph linking to the instructions on how to work … (diff)
8:49 AM PythonGuidelines edited by Sergio Correia
Added section on how to work with distros that come with Python 3 as … (diff)
8:38 AM Changeset in webkit [152356] by mikhail.pozdnyakov@intel.com
  • 3 edits in trunk/Source/WTF

Remove code duplication from StringImpl create()/reallocate() methods
​https://bugs.webkit.org/show_bug.cgi?id=118355

Reviewed by Anders Carlsson.

StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):

  • wtf/text/StringImpl.h:
8:28 AM Changeset in webkit [152355] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix after r152340.

  • WebCore.exp.in:
7:52 AM Changeset in webkit [152354] by sergio@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][GTK] Invalid ASSERTs in WebResources loading code
​https://bugs.webkit.org/show_bug.cgi?id=118352

Reviewed by Carlos Garcia Campos.

The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.

The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewGetLoadingWebResource):

7:18 AM Changeset in webkit [152353] by kangil.han@samsung.com
  • 15 edits in trunk/Source/WebCore

Append overloading function for isFooElement
​https://bugs.webkit.org/show_bug.cgi?id=118334

Reviewed by Antti Koivisto.

Node::hasTagName needs additional isElementNode() check when it is triggered.
So conversion from Element* to Node* in isFooElement should be avoided.
Therefore, to support both Node* and Element* as an argument of isFooElement,
this patch appends overloading inline function.

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):

  • dom/Node.cpp:

(WebCore::Node::numberOfScopedHTMLStyleChildren):

  • html/HTMLAnchorElement.h:

(WebCore::isHTMLAnchorElement):

  • html/HTMLAreaElement.h:

(WebCore::isHTMLAreaElement):

  • html/HTMLAudioElement.h:

(WebCore::isHTMLAudioElement):

  • html/HTMLFormElement.h:

(WebCore::isHTMLFormElement):

  • html/HTMLImageElement.h:

(WebCore::isHTMLImageElement):

  • html/HTMLInputElement.h:

(WebCore::isHTMLInputElement):

  • html/HTMLLabelElement.h:

(WebCore::isHTMLLabelElement):

  • html/HTMLOptGroupElement.h:

(WebCore::isHTMLOptGroupElement):

  • html/HTMLOptionElement.h:

(WebCore::isHTMLOptionElement):

  • html/HTMLStyleElement.h:

(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

  • html/HTMLTextAreaElement.h:

(WebCore::isHTMLTextAreaElement):

6:54 AM Changeset in webkit [152352] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

Gif: zero filling should use memset instead of setRGBA for every pixel
​https://bugs.webkit.org/show_bug.cgi?id=118350

Patch by Balazs Kelemen <​b.kelemen@samsung.com> on 2013-07-03
Reviewed by Allan Sandfeld Jensen.

No new tests. Actually it is not covered by existing tests. Surprisingly we haven't got pixel
tests for animated images. Given that this patch is pretty trivial I don't think it's worth the
cost to start introducing such tests.
I added a manual test: animated-gif-dispose-background.html.

GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels.
This is extremely ineffecient. The use case for this code path is not frequent on the web
but it's still better to fix it.

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::zeroFillFrameRect):

  • platform/image-decoders/ImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::initFrameBuffer):
Fixed indentation in addition.

5:59 AM Changeset in webkit [152351] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

TextureUnit code optimization
​https://bugs.webkit.org/show_bug.cgi?id=117868

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.

According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.

No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):

  • html/canvas/WebGLRenderingContext.h:
3:50 AM Changeset in webkit [152350] by Christophe Dumez
  • 21 edits in trunk/Source/WebCore

Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
​https://bugs.webkit.org/show_bug.cgi?id=118305

Reviewed by Kentaro Hara.

Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:

No new tests, no behavior change.

  • CMakeLists.txt:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • svg/SVGFEBlendElement.idl:
  • svg/SVGFEColorMatrixElement.idl:
  • svg/SVGFEComponentTransferElement.idl:
  • svg/SVGFECompositeElement.idl:
  • svg/SVGFEConvolveMatrixElement.idl:
  • svg/SVGFEDiffuseLightingElement.idl:
  • svg/SVGFEDisplacementMapElement.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEFloodElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEImageElement.idl:
  • svg/SVGFEMergeElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFEOffsetElement.idl:
  • svg/SVGFESpecularLightingElement.idl:
  • svg/SVGFETileElement.idl:
  • svg/SVGFETurbulenceElement.idl:
3:19 AM Changeset in webkit [152349] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Fix cast-align warnings in FastMalloc.cpp
​https://bugs.webkit.org/show_bug.cgi?id=117991

Reviewed by Mark Hahnenberg.

  • wtf/FastMalloc.cpp:
3:13 AM Changeset in webkit [152348] by commit-queue@webkit.org
  • 6 edits in trunk/Source

H&R Block 2010 Help window can not be reopened.
​https://bugs.webkit.org/show_bug.cgi?id=118342

Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-03
Reviewed by Antti Koivisto.

​http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.

Source/WebCore:

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsHRBlock):

  • platform/RuntimeApplicationChecks.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):

3:06 AM Changeset in webkit [152347] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Further build fixing for build configurations that disable CSS regions support.

  • dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
3:00 AM Changeset in webkit [152346] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.

  • svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
  • svg/SVGElement.h: Ditto.
2:35 AM WebKitGTK/2.0.x edited by tpopela@redhat.com
(diff)
2:33 AM WebKitGTK/2.0.x edited by tpopela@redhat.com
(diff)
2:02 AM Changeset in webkit [152345] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
​https://bugs.webkit.org/show_bug.cgi?id=118300

Based on patch by Zoltán Árvai <​zarvai@inf.u-szeged.hu>

Patch by Radu Stavila <​stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.

Fixed CSS_REGIONS guard.

  • dom/Element.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):

1:43 AM Changeset in webkit [152344] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Migrate WebKitWebContext to GTask
​https://bugs.webkit.org/show_bug.cgi?id=117153

Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):

1:03 AM Changeset in webkit [152343] by Christophe Dumez
  • 15 edits in trunk/Source/WebCore

Move SVGTests attributes parsing to SVGGraphicsElement
​https://bugs.webkit.org/show_bug.cgi?id=118292

Reviewed by Darin Adler.

Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.

No new tests, no behavior change.

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):

  • svg/SVGClipPathElement.cpp:

(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):

  • svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):

  • svg/SVGForeignObjectElement.cpp:

(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):

  • svg/SVGGElement.cpp:

(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):

  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):

  • svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):

  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):

12:44 AM Changeset in webkit [152342] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-03

  • platform/qt/TestExpectations:
12:30 AM Changeset in webkit [152341] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Let F5 refresh the page in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=117638

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.

Also use the correct icon for the refresh button that was already there.

  • MiniBrowser/gtk/BrowserWindow.c:

(browser_window_init):

Jul 2, 2013:

10:54 PM Changeset in webkit [152340] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
​https://bugs.webkit.org/show_bug.cgi?id=118280

Reviewed by Darin Adler.

Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):

10:30 PM Changeset in webkit [152339] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG::Node::m_opInfo2 should also be a uintptr_t
​https://bugs.webkit.org/show_bug.cgi?id=118340

Reviewed by Sam Weinig.

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):

10:21 PM Changeset in webkit [152338] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source

Unreviewed, fix 32-bit build.

Source/JavaScriptCore:

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::comparePtr):
(MacroAssembler):

  • dfg/DFGBinarySwitch.cpp:

(JSC::DFG::BinarySwitch::advance):

  • dfg/DFGBinarySwitch.h:

(JSC::DFG::BinarySwitch::caseValue):

Source/WTF:

  • wtf/Platform.h:
10:07 PM Changeset in webkit [152337] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
​https://bugs.webkit.org/show_bug.cgi?id=118299

Reviewed by Andreas Kling.

Did cleanups.

  • dom/QualifiedName.cpp:

(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.

8:45 PM Changeset in webkit [152336] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Have fewer Arrayify's
​https://bugs.webkit.org/show_bug.cgi?id=118335

Reviewed by Mark Hahnenberg.

A lot of Arrayify's arise because some program saw Int32 arrays early on in
execution, but then they all got converted to Double arrays and the program
will never see Int32 arrays ever again. Prior to this change you would always
have an Arrayify in this case. But with this change, the first time that an
ArrayProfile is about to go polymorphic in computeUpdatedPrediction(), it
instead forcibly monomorphises itself to the latest-seen structure.
Thereafter it will never again perform this monomorphisation. This is
controlled by ArrayProfile::m_didPerformFirstRunPruning. This is a 5%
speed-up on Kraken/imaging-gaussian-blur with the FTL enabled, and it
unblocks a bunch of stuff we want to do in the future because it makes a
bunch of loops effect-free.

We will still want to implement Arrayify hoisting in the future, but this is
great anyway because it's better to not have Arrayifications than it is to
have hoisted Arrayifications.

  • bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):

  • bytecode/ArrayProfile.h:

(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):

8:19 PM Changeset in webkit [152335] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
​https://bugs.webkit.org/show_bug.cgi?id=118337

Reviewed by Benjamin Poulain.

-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.

However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.

Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.

Fix by ensuring that -webkit-overflow-scrolling: touch only affects elements which
are actually scrollable.

Also move the code that does this to below the code that adjust overflow style
for different elements.

  • css/StyleResolver.cpp:

(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):

7:45 PM Changeset in webkit [152334] by kalyan.kondapally@intel.com
  • 2 edits in trunk/Tools
5:48 PM Changeset in webkit [152333] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r152318.
​http://trac.webkit.org/changeset/152318
​https://bugs.webkit.org/show_bug.cgi?id=118333

This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).

Source/WebCore:

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):

LayoutTests:

  • media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
  • media/track/track-legacyapi-with-automatic-mode.html: Removed.
5:39 PM Changeset in webkit [152332] by Lucas Forschler
  • 11 edits in branches/safari-537-branch/Source

Merged r152328. <rdar://problem/14320278>

5:32 PM Changeset in webkit [152331] by dfarler@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Adding myself to contributors.json.

  • Scripts/webkitpy/common/config/contributors.json:
5:20 PM Changeset in webkit [152330] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Change event should not be dispatched by clicking a scrollbar of select listbox
​https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>

Patch by Ruth Fong <​ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/forms/select/listbox-click-on-scrollbar.html

Merge the following:
​http://src.chromium.org/viewvc/blink?view=revision&revision=151689
​https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)

(WebCore::HTMLSelectElement::listBoxOnChange):

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.

LayoutTests:

Merge the following:
​http://src.chromium.org/viewvc/blink?view=revision&revision=151689
​https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f

  • fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
  • fast/forms/select/listbox-click-on-scrollbar.html: Added.

Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.

5:18 PM Changeset in webkit [152329] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Preparing Windows WebGL build system.
​https://bugs.webkit.org/show_bug.cgi?id=118325

Reviewed by Brent Fulgham.

  • WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.
5:06 PM Changeset in webkit [152328] by jberlin@webkit.org
  • 11 edits in trunk/Source

The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
​https://bugs.webkit.org/show_bug.cgi?id=118330

Reviewed by Anders Carlsson.

Source/WebCore:

  • WebCore.exp.in:

Expose a symbol so it can be used in WebKit2.

Source/WebKit2:

Add another key value pair to the dictionary passed to the callback.

  • Shared/API/c/WKPluginInformation.cpp:

(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):

  • Shared/API/c/WKPluginInformation.h:
  • Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.

  • Shared/Plugins/Netscape/PluginInformation.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.

4:04 PM Changeset in webkit [152327] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/LayoutTests

Merged r152288. <rdar://problem/14338353>

3:54 PM Changeset in webkit [152326] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: add option to disable OSR entry in loops
​https://bugs.webkit.org/show_bug.cgi?id=118329

Reviewed by Mark Hahnenberg.

This adds that option, and also makes the OSR exit reoptimization trigger rely less on
OSR entry failing. Now even if we never attempt OSR entry but our execution counter gets
high after a small number of OSR exits, we will recompile.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):

  • dfg/DFGOperations.cpp:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):

  • runtime/Options.h:

(JSC):

3:18 PM Changeset in webkit [152325] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Added getProcAddress implementation for Windows in OpenGLShims.
​https://bugs.webkit.org/show_bug.cgi?id=118312

Reviewed by Brent Fulgham.

  • platform/graphics/OpenGLShims.cpp:

(WebCore::getProcAddress): Added for Windows.

3:12 PM Changeset in webkit [152324] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

media/unsupported-rtsp.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=118327

Reviewed by Eric Carlson.

Fixes the media/unsupported-rtsp.html test.

Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::notifyFinished):

2:58 PM Changeset in webkit [152323] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed compile error in non-X11 platforms using EGL.
​https://bugs.webkit.org/show_bug.cgi?id=118323

Reviewed by Brent Fulgham.

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).

2:45 PM Changeset in webkit [152322] by dfarler@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.

  • platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.

"Unknown SDH" -> "Unknown".

2:24 PM Changeset in webkit [152321] by dfarler@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.

  • platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:

WaveTable -> PeriodicWave

1:43 PM Changeset in webkit [152320] by commit-queue@webkit.org
  • 22 edits in trunk

[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
​https://bugs.webkit.org/show_bug.cgi?id=118300

Patch by Radu Stavila <​stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.

  • dom/Element.cpp:

(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::isRegisteredWithNamedFlow):

  • dom/Node.h:
  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):

  • dom/NodeRenderingContext.h:
  • dom/PseudoElement.h:
  • dom/Text.cpp:

(WebCore::Text::textRendererIsNeeded):

  • dom/Text.h:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):

  • rendering/FlowThreadController.h:
  • rendering/RenderObject.h:
  • rendering/RenderRegion.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::shouldMoveToFlowThread):

  • svg/SVGElement.h:

LayoutTests:

  • fast/regions/flow-body-in-html.html:
  • fast/regions/region-content-flown-into-region-expected.html:
  • fast/regions/region-content-flown-into-region.html:
  • fast/regions/universal-selector-children-to-the-same-region.html:
1:30 PM Changeset in webkit [152319] by dfarler@apple.com
  • 2 edits in trunk/LayoutTests

Skip cache partitioning tests on Lion.

Rubber stamped by Jeffrey Pfau.

  • platform/mac-lion/TestExpectations:

http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html

1:28 PM Changeset in webkit [152318] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
​https://bugs.webkit.org/show_bug.cgi?id=118319

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-legacyapi-with-automatic-mode.html

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"

logic when captions were enabled with .webkitClosedCaptionsVisible.

LayoutTests:

  • media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
  • media/track/track-legacyapi-with-automatic-mode.html: Added.
1:07 PM Changeset in webkit [152317] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

security/block-test.html fails when NetworkProcess is enabled
​https://bugs.webkit.org/show_bug.cgi?id=118320
<rdar://problem/14309423>

Reviewed by Geoff Garen.

  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::wasBlocked): (WebKit::NetworkResourceLoader::cannotShowURL): Implemented missing ResourceHandleClient functions.
12:51 PM Changeset in webkit [152316] by adachan@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
​https://bugs.webkit.org/show_bug.cgi?id=118268

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.

12:50 PM Changeset in webkit [152315] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Always flip the coordinate system before drawing NSViews from Widget::paint
​https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>

Reviewed by Beth Dakin.

Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.

Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

12:47 PM Changeset in webkit [152314] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
​https://bugs.webkit.org/show_bug.cgi?id=118316

Reviewed by Geoffrey Garen.

This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):

12:30 PM Changeset in webkit [152313] by robert@webkit.org
  • 3 edits
    2 adds in trunk

empty inlines should not affect line-wrapping
​https://bugs.webkit.org/show_bug.cgi?id=25638

Reviewed by David Hyatt.

Source/WebCore:

Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.

Test: fast/text/whitespace/inline-whitespace-wrapping-11.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.
12:30 PM Changeset in webkit [152312] by Lucas Forschler
  • 1 copy in tags/Safari-537.48

New Tag.

12:29 PM Changeset in webkit [152311] by Lucas Forschler
  • 1 delete in tags/Safari-537.48

Remove Tag.

12:27 PM Changeset in webkit [152310] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152199. <rdar://problem/14287209>

12:24 PM Changeset in webkit [152309] by Lucas Forschler
  • 13 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152141. <rdar://problem/14283900>

12:21 PM Changeset in webkit [152308] by Lucas Forschler
  • 6 edits in branches/safari-537-branch/Source/WebInspectorUI

Merged r152136. <rdar://problem/13899156>

12:17 PM Changeset in webkit [152307] by commit-queue@webkit.org
  • 6 edits
    2 copies in trunk/Source

Implement CoordinatedSurface for Threaded Coordinated Graphics
​https://bugs.webkit.org/show_bug.cgi?id=109661

Patch by Jae Hyun Park <​jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.

This is a preparation patch for Threaded Coordianted Graphics.

This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.

Source/WebCore:

  • platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:

(WebCore::CoordinatedSurface::CoordinatedSurface):

  • platform/graphics/texmap/coordinated/CoordinatedSurface.h:

(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):

  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.

(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):

  • platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.

Source/WebKit2:

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
12:09 PM Changeset in webkit [152306] by ggaren@apple.com
  • 4 edits in trunk/Source

plainText() is O(N2)
​https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • editing/TextIterator.cpp:

(WebCore::plainText): Linear growth for a vector data type is O(N2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.

Source/WTF:

  • wtf/text/StringBuilder.cpp:

(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.

(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N2).

Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.

12:00 PM Changeset in webkit [152305] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: since the FTL disassembly hacks cannot distinguish between code and data, the LLVM disassembler symbol table callback should be able to deal gracefully with arbitrary garbage
​https://bugs.webkit.org/show_bug.cgi?id=118313

Reviewed by Mark Hahnenberg.

Give it a mode where we can still crash on unrecognized reference types, so that we might
implement them in the future, but by default just print some stuff and keep going.

  • disassembler/LLVMDisassembler.cpp:

(JSC):
(JSC::symbolLookupCallback):

11:15 AM Changeset in webkit [152304] by Lucas Forschler
  • 1 copy in tags/Safari-537.48

New Tag.

11:14 AM Changeset in webkit [152303] by timothy_horton@apple.com
  • 6 edits
    3 adds in trunk

constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
​https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>

Reviewed by Anders Carlsson.

Test: compositing/geometry/fixed-position-flipped-writing-mode.html

WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.

Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).

The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.

Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.

Disable the test on Mac WebKit1 because of ​https://bugs.webkit.org/show_bug.cgi?id=118269.

  • compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
  • compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
  • platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
11:00 AM Changeset in webkit [152302] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/LayoutTests

Merged r152184. <rdar://problem/14304814>

10:54 AM Changeset in webkit [152301] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source

fourthTier: FTL should use the equivalent of llvm opt -O2 by default
​https://bugs.webkit.org/show_bug.cgi?id=118311

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Use a PassManagerBuilder instead of rolling our own.

This boosts our speed-up by another 5% or so.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • runtime/Options.h:

(JSC):

Source/WTF:

Reviewed by Mark Hahnenberg.

  • wtf/LLVMHeaders.h:
10:53 AM Changeset in webkit [152300] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build correction for 'DebugSuffix' target.

  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the

DEBUGSUFFIX definition to the nmake instance to be available during script processing.

10:37 AM Changeset in webkit [152299] by Christophe Dumez
  • 16 edits
    2 deletes in trunk/Source/WebCore

Remove SVGStyledLocatableElement class
​https://bugs.webkit.org/show_bug.cgi?id=118283

Reviewed by Dirk Schulze.

Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).

No new tests, no behavior change.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetGnuVTableOffsetForType):

  • svg/SVGAllInOne.cpp:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):

  • svg/SVGElement.h:
  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):

  • svg/SVGGraphicsElement.h:
  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::localCoordinateSpaceTransform):

  • svg/SVGStyledLocatableElement.cpp: Removed.
  • svg/SVGStyledLocatableElement.h: Removed.
9:50 AM Changeset in webkit [152298] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[ATK] Leak: leaks in AccessibilityUIElement
​https://bugs.webkit.org/show_bug.cgi?id=118297

Fixed memory leak.

Patch by Brian Holt <​brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::stringValue):

9:26 AM Changeset in webkit [152297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Curl] Crash after download.
​https://bugs.webkit.org/show_bug.cgi?id=118303

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.

We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.

  • platform/network/curl/CurlDownload.cpp:

(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):

  • platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.
9:21 AM Changeset in webkit [152296] by mario@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed gardening. Added new common expectations for test after r151665.

  • accessibility/box-styled-lists-expected.txt: Added shared expectation.
  • platform/efl/TestExpectations: Removed failure expectation.
  • platform/gtk/TestExpectations: Ditto.
9:19 AM Changeset in webkit [152295] by bw80.lee@samsung.com
  • 4 edits in trunk/Tools

Fix WebKitTestRunner crashes.
​https://bugs.webkit.org/show_bug.cgi?id=117630

Reviewed by Darin Adler.

Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().

Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::run):

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpWebProcessUnresponsiveness):

  • WebKitTestRunner/TestInvocation.h:
9:13 AM Changeset in webkit [152294] by mario@webkit.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.

  • accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
  • platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
8:00 AM Changeset in webkit [152293] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
​https://bugs.webkit.org/show_bug.cgi?id=118295

Patch by Radu Stavila <​stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.

Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.

A larger patch's test (​https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderSVGBlock):

  • rendering/svg/RenderSVGBlock.h:
7:32 AM Changeset in webkit [152292] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitLibraries

Unreviewed, rolling out r152233.
​http://trac.webkit.org/changeset/152233
​https://bugs.webkit.org/show_bug.cgi?id=118304

hopeful attempt to restore windows buildage (Requested by
kling on #webkit).

  • win/tools/vsprops/debugsuffix.props:
7:04 AM Changeset in webkit [152291] by abucur@adobe.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaseline background blend mode default test result.

  • platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:
6:48 AM Changeset in webkit [152290] by kangil.han@samsung.com
  • 6 edits in trunk/Source/WebCore

is/toHTMLStyleElement should use Element* for its argument
​https://bugs.webkit.org/show_bug.cgi?id=118286

Reviewed by Andreas Kling.

To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Node.cpp:

(WebCore::Node::numberOfScopedHTMLStyleChildren):

  • html/HTMLStyleElement.h:

(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):

6:36 AM Changeset in webkit [152289] by mikhail.pozdnyakov@intel.com
  • 3 edits in trunk/Source/WTF

Avoid code duplication inside String::append()
​https://bugs.webkit.org/show_bug.cgi?id=118290

Reviewed by Anders Carlsson.

The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.

  • wtf/text/WTFString.cpp:

(WTF::String::appendInternal):
(WTF::String::append):

  • wtf/text/WTFString.h:
6:31 AM Changeset in webkit [152288] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<​http://webkit.org/b/118301>

5:53 AM Changeset in webkit [152287] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Skip 3 MathML tests that are failing after r152235.
<​http://webkit.org/b/118298>

5:20 AM Changeset in webkit [152286] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
​https://bugs.webkit.org/show_bug.cgi?id=118271

Reviewed by Andreas Kling.

Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.

No new tests since there should be no behavioral change.

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):

  • editing/EditingStyle.h:
4:56 AM Changeset in webkit [152285] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

Introduce toSVGInlineTextBox
​https://bugs.webkit.org/show_bug.cgi?id=118289

Reviewed by Andreas Kling.

As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().

Blink merge from ​https://src.chromium.org/viewvc/blink?view=rev&revision=153345

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::positionForPoint):

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineTextBox.h:

(WebCore::toSVGInlineTextBox):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGInlineTextBoxes):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):

  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):

4:50 AM Changeset in webkit [152284] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Simplify SVGTextContentElement::elementFromRenderer()
​https://bugs.webkit.org/show_bug.cgi?id=118284

Reviewed by Andreas Kling.

Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.

No new tests, no behavior change.

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::elementFromRenderer):

4:19 AM Changeset in webkit [152283] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
​https://bugs.webkit.org/show_bug.cgi?id=118249

Reviewed by Allan Sandfeld Jensen.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::updateContents):

4:04 AM Changeset in webkit [152282] by allan.jensen@digia.com
  • 6 edits in trunk

[Qt][WK1] Support WebGL with EGL on Linux
​https://bugs.webkit.org/show_bug.cgi?id=118251

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Let GraphicsContext3D work without a GraphicsSurface.

  • Target.pri:
  • platform/graphics/OpenGLShims.cpp:

(WebCore::getProcAddress):

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):

Tools:

  • qmake/mkspecs/features/features.prf:
12:43 AM Changeset in webkit [152281] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
​https://bugs.webkit.org/show_bug.cgi?id=118057

Patch by Catalin Badea <​badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.

Source/WebCore:

Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.

Test: fast/regions/autoheight-flexbox.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):

  • rendering/RenderFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):

  • rendering/RenderView.cpp:

LayoutTests:

Add test for auto-height regions and flexbox containers.

  • fast/regions/autoheight-flexbox-expected.html: Added.
  • fast/regions/autoheight-flexbox.html: Added.
Note: See TracTimeline for information about the timeline view.