Timeline
Jul 4, 2013:
- 11:53 PM Changeset in webkit [152408] by
-
- 2 edits in trunk/Tools
[EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
https://bugs.webkit.org/show_bug.cgi?id=118370
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Add fallback to software X11 engine if opengl_x11 engine creation fails.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(initEcoreEvas):
- 2:17 PM Changeset in webkit [152407] by
-
- 3 edits in trunk/Source/WebKit2
Paint the page background if we haven't received our first update
https://bugs.webkit.org/show_bug.cgi?id=118402
<rdar://problem/13893308>
Reviewed by Simon Fraser.
Make sure that we always paint something when we haven't received our first update from the web process.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):
- 1:28 PM Changeset in webkit [152406] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, add a helpful comment for why DCE is needed in the FTL.
I believe I've now twice down the experiment of disabling DCE in the FTL,
only to realize that this can't work, and that DCE is needed. I'd kind of
like to not make that mistake again.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 12:53 PM Changeset in webkit [152405] by
-
- 3 edits in trunk/Source/WebKit/mac
Add a method to get unreachable URL from WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=118399
Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not
loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL.
We can add a method to always return the unreachableURL regardless if the frame has loaded or not.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-07-04
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _unreachableURL]):
- WebView/WebFramePrivate.h:
- 11:48 AM Changeset in webkit [152404] by
-
- 16 edits2 deletes in trunk
Have SVGTextContentElement inherit SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118351
Reviewed by Dirk Schulze.
Source/WebCore:
Have SVGTextContentElement inherit SVGGraphicsElement instead of
SVGStyledElement in order to match the latest SVG2 specification:
https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement
This patch also removes the SVGTransformable and SVGLocatable IDL
interfaces as they are no longer needed (were merged into
SVGGraphicsElement in the latest specification).
This is one step towards getting rid of multiple inheritance in
SVG, and complying with the latest SVG2 specification.
No new tests, covered by existing tests.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGLocatable.idl: Removed.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::isSupportedAttribute):
(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
(WebCore::SVGTextElement::animatedLocalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextElement.idl:
- svg/SVGTransformable.idl: Removed.
LayoutTests:
Fix conversion to absolute (user agent) coordinates in the svg/text
tests to use SVGGraphicsElement::getScreenCTM() instead of
SVGGraphicsElement::getTransformToElement(). The previous code was
working until now due to a bug in getTransformToElement(), which
was not taking into consideration the CTM of the SVGTextElement (as
it was not recognized as a "locatable" element). Now that
SVGTextElement inherits from SVGGraphicsElement, it is properly
recognized as a "locatable" element by getTransformToElement().
- svg/text/resources/SelectionTestCase.js:
(toAbsoluteCoordinates):
- svg/text/selection-doubleclick.svg:
- 11:42 AM Changeset in webkit [152403] by
-
- 2 edits in trunk/Source/WebKit2
Crash when createPluginInternal ends up destroying the plug-in
https://bugs.webkit.org/show_bug.cgi?id=118397
<rdar://problem/14155051>
Reviewed by Simon Fraser.
Keep the WebProcessConnection object alive while calling createPluginInternal and handle
the IPC connection going away.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):
- 11:33 AM WebKitGTK/StartHacking edited by
- (diff)
- 11:00 AM Changeset in webkit [152402] by
-
- 3 edits in trunk/Source/WebCore
Remove PageThrottler::m_activeThrottleBlockers
https://bugs.webkit.org/show_bug.cgi?id=118375
Reviewed by Mark Rowe.
This is simply m_activityTokens.size().
Also, fold preventThrottling into addActivityToken & allowThrottling into removeActivityToken
(these should no longer be called directly, and should not be public).
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- removed m_activeThrottleBlockers
(WebCore::PageThrottler::startThrottleHysteresisTimer):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::addActivityToken):
- added functionality from preventThrottling
(WebCore::PageThrottler::removeActivityToken):
- added functionality from allowThrottling
- page/PageThrottler.h:
- removed preventThrottling, allowThrottling, and m_activeThrottleBlockers.
- 8:52 AM WebKitGTK/StartHacking edited by
- Minor correction in documentation section (diff)
- 8:51 AM Changeset in webkit [152401] by
-
- 5 edits in trunk/Source/WebCore
Take document height into account when determining when it is considered visually non-empy
https://bugs.webkit.org/show_bug.cgi?id=118272
Reviewed by Darin Adler.
The current visually non-empy mechanism takes into account only the amount of contents in renderers.
Add a simple layout dependency so that we don't consider page non-empty until the document height
exceed a (low) height threshold (or the load completes).
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Don't send layout callbacks until we have actually some content.
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
Factor into functions.
- page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
The size is not known but the estimate provided here is always bigger than the threshold so
the functionality is unchanged.
- 8:50 AM WebKitGTK/StartHacking edited by
- Added documentation section. (diff)
- 8:33 AM Changeset in webkit [152400] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r152399.
Add missing header include for SVGNames.h.
- svg/SVGImageElement.h:
- 7:09 AM WebKitGTK/SpeedUpBuild edited by
- Minor typo fix in gold section (diff)
- 7:07 AM WebKitGTK/SpeedUpBuild edited by
- Minor fix in gold (diff)
- 7:06 AM WebKitGTK/SpeedUpBuild edited by
- Adding gold section (diff)
- 7:00 AM WebKitGTK/StartHacking edited by
- Recommending to use the gold linker (diff)
- 6:58 AM Changeset in webkit [152399] by
-
- 4 edits in trunk/Source/WebCore
Change static_cast<SVGImageElement*> with toSVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=118387
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can
be changed with toSVGImageElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
(WebCore::RenderSVGImage::paintForeground):
- svg/SVGImageElement.h:
(WebCore::toSVGImageElement):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
- 6:18 AM Changeset in webkit [152398] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.
Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
- 5:10 AM Changeset in webkit [152397] by
-
- 7 edits in trunk
[ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Source/WebCore:
Use AtkAttributeSet* instead of GSList*.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale):
Tools:
Fixed memory leaks for AtkAttributeSet by calling
atk_attribute_set_free().
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(getAtkAttributeSetAsString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::childElementById):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::getAtkAttributeSetAsString):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
- 3:03 AM Changeset in webkit [152396] by
-
- 4 edits in trunk/Source
[ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Do not expose a '\n' character for every visual line break.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): Removed wrong code.
Source/WebKit/gtk:
Added new unit test to make sure we exposed line breaks properly.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithWrappedLines): New unit test.
(main): Added new test to the test suite.
- 2:12 AM Changeset in webkit [152395] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
[CMake] Add generation of JITStubs for x86_64 MSVC
https://bugs.webkit.org/show_bug.cgi?id=116666
Reviewed by Laszlo Gombos.
Also move the generation for ARM CPU into the CMakeLists.txt,
since it's compiler specific and not dedicated to Windows CE.
- CMakeLists.txt:
- PlatformWinCE.cmake: Removed.
- 2:05 AM Changeset in webkit [152394] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Gardening. Unskip tests related with editing
https://bugs.webkit.org/show_bug.cgi?id=118379
Unreviewed gardening.
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-04
- platform/efl-wk2/TestExpectations: Unskip editing/selection/doubleclick-beside-cr-span.html and editing/selection/doubleclick-whitespace.html, which are passed after r150289
- platform/efl/editing/style/5065910-expected.txt: Removed (wrong expected result).
- platform/efl/editing/style/5065910-expected.png: Removed (wrong expected result).
- 1:52 AM Changeset in webkit [152393] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=118120
Reviewed by Gyuyoung Kim.
Since WTF is a static library linked to JavaScriptCore on all CMake ports
we need to define STATICALLY_LINKED_WITH_WTF for all of them.
This makes only a difference for Windows, since WTF_EXPORT and WTF_IMPORT
are the same on all other platforms.
- CMakeLists.txt:
- 1:08 AM Changeset in webkit [152392] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port FileSystemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=117935
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/FileSystemWin.cpp:
(WebCore::storageDirectory):
- platform/wince/FileSystemWinCE.cpp: Removed.
- 12:44 AM Changeset in webkit [152391] by
-
- 3 edits2 adds in trunk
[GStreamer] support preload="metadata"
https://bugs.webkit.org/show_bug.cgi?id=116817
Reviewed by Eric Carlson.
Source/WebCore:
Add appropriate behavior for preload="metadata". Delay enabling download buffering
until playback is started in this case. This behavior fits with the standard quite
well and this is the most exact match we can get (at least without adding too much
extra complexity). What matters mostly is that we can avoid loading the media
before playback but we have the first frame and the metadata.
Test: media/video-load-preload-metadata.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Set |m_preload| to |Auto|
so we will start download buffering if we did not start it yet.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto.
(MediaPlayerPrivateGStreamer::setDownloadBuffering): Only start download
buffering if |m_preload == Auto|. Also make sure we don't clear the download
flag once we started downloading because it would result in not well defined
behavior and it does not really makes sense.
(MediaPlayerPrivateGStreamer::setPreload): Set download buffering accordingly.
LayoutTests:
- media/video-load-preload-metadata.html: Added.
Jul 3, 2013:
- 11:48 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:44 PM Changeset in webkit [152390] by
-
- 3 edits in trunk/Source/WebCore
[Coordinated Graphics] Don't use && operator in ASSERT
https://bugs.webkit.org/show_bug.cgi?id=118377
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-03
Reviewed by Noam Rosenthal.
We don't use && opeartor in ASSERT because it's impossible to know which
condition caused the assertion.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStoreTile::swapBuffers):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
- 11:20 PM Changeset in webkit [152389] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Support some more editing keyboard events
https://bugs.webkit.org/show_bug.cgi?id=118346
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-03
Reviewed by Gyuyoung Kim.
For editable contents, support the shortcuts for copy, page, cut, select all, undo and redo.
- platform/efl/EflKeyboardUtilities.cpp:
- 10:28 PM Changeset in webkit [152388] by
-
- 5 edits2 adds in trunk
AX: Items the img aria role aren't inserting an object replacement character
https://bugs.webkit.org/show_bug.cgi?id=118259
Source/WebCore:
Reviewed by Tim Horton.
VoiceOver relies on object replacement characters being emitted when asking for selected text.
This has worked if a real <img> is used, but if role="img" is used on a <div>, for example,
no emission is performed, which leads to missed elements in text.
Test: platform/mac/accessibility/aria-image-emits-object-replacement.html
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
(WebCore::TextIterator::advance):
LayoutTests:
Reviewed by Reviewed by Tim Horton.
- accessibility/non-native-image-crash-expected.txt:
- platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt: Added.
- platform/mac/accessibility/aria-image-emits-object-replacement.html: Added.
- platform/mac/accessibility/img-fallsback-to-title-expected.txt:
Update expected tests where role="img" now emits replacement character.
- 9:31 PM Changeset in webkit [152387] by
-
- 6 edits in trunk/Source/WebCore
Adopt is/toHTMLMapElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118235
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLMapElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
- html/HTMLMapElement.h:
(WebCore::isHTMLMapElement):
(WebCore::toHTMLMapElement):
- 5:47 PM Changeset in webkit [152386] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build correction after r15283.
- WebCorePrefix.h: Remove include directive for CGFloat.h, as it
is not present in all Windows build environments.
- 5:39 PM Changeset in webkit [152385] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Exclude unsupported QuartzCore Features.
https://bugs.webkit.org/show_bug.cgi?id=118374
Reviewed by Anders Carlsson.
- WebCore.vcxproj/WebCoreCG.props: Exclude a few non-Windows
concepts from the QuartzCore headers.
- 5:03 PM Changeset in webkit [152384] by
-
- 5 edits in trunk/Source/WebCore
Simplify PageThrottler ownership.
https://bugs.webkit.org/show_bug.cgi?id=118372
Reviewed by Sam Weinig.
- page/Page.cpp:
(WebCore::Page::~Page):
- 'clearPage' method removed - just clear the own pointer.
- page/Page.h:
- make m_pageThrottler an OwnPtr.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler):
- moved 'setThrottled(false)' from 'clearPage' (removed).
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
- no need to check 'm_page'
- page/PageThrottler.h:
(WebCore::PageThrottler::create):
- create a PassOwnPtr, not PassRefPtr.
- 5:01 PM Changeset in webkit [152383] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Updates to support changes in CoreGraphics libraries.
https://bugs.webkit.org/show_bug.cgi?id=118373
Reviewed by Anders Carlsson.
- WebCorePrefix.h: Include definitions for isnan/round/roundf for versions of
Visual Studio that do not provide them natively.
- 4:56 PM Changeset in webkit [152382] by
-
- 13 edits in trunk/Source
Implement mechanism to detect (partially) hidden blocked plugins.
https://bugs.webkit.org/show_bug.cgi?id=117998
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-03
Reviewed by Dean Jackson.
Source/WebCore:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::replacementTextRect):
Added private method for calculating the size of the replacement text for blocked plugins.
(WebCore::RenderEmbeddedObject::isReplacementObscured):
Added public method to determine if the EMBED element used for a blocked plugin is inaccessible to the user.
- rendering/RenderEmbeddedObject.h:
Declare the two new methods mentioned above.
- WebCore.exp.in:
Export RenderEmbeddedObject::isReplacementObscured().
Source/WebKit2:
- Shared/Plugins/Netscape/PluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationReplacementObscuredKey):
Add key for plugInInformation dictionaries.
(WebKit::createPluginInformationDictionary):
Add boolean parameter identifying whether the replacement for a blocked plugin is obscured, and add it to the dictionary.
- Shared/API/c/WKPluginInformation.h:
- Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationReplacementObscuredKey):
Provide the C API for the plugInInformationReplacementObscuredKey().
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Add bool replacementObscured parameter to pass on argument to createPluginInformationDictionary().
- UIProcess/WebPageProxy.messages.in:
Add bool replacementObscured parameter to DidBlockInsecurePluginVersion() message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Invoke isReplacementObscured() method for blocked plugins.
- 4:38 PM Changeset in webkit [152381] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/copy-files.cmd: Limit path (for this file) to DOS-only to avoid
the Cygwin variant of rmdir from being used.
- 4:13 PM Changeset in webkit [152380] by
-
- 3 edits in trunk/Source/WebInspectorUI
Guard remaining calls to decodeURIComponent with a try/catch.
https://bugs.webkit.org/show_bug.cgi?id=118371
Reviewed by Joseph Pecoraro.
- UserInterface/Main.js:
(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):
- UserInterface/Utilities.js:
(arrayResult):
(queryString):
- 3:33 PM Changeset in webkit [152379] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:31 PM Changeset in webkit [152378] by
-
- 2 edits in tags/Safari-537.48.2/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:30 PM Changeset in webkit [152377] by
-
- 5 edits in tags/Safari-537.48.2/Source
Versioning.
- 3:28 PM Changeset in webkit [152376] by
-
- 1 copy in tags/Safari-537.48.2
New Tag.
- 3:28 PM Changeset in webkit [152375] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
<rdar://problem/14349560> Flash Player: deny ipc-posix-sem MacromediaSemaphoreDig on many sites
Reviewed by Sam Weinig.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: semaphore-owner doesn't appear to work the way we need it to, removing it (at least for now).
- 1:19 PM Changeset in webkit [152374] by
-
- 2 edits in trunk/Source/WebInspectorUI
Ran update-webkit-localizable-strings.
Rubber-stamped by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- 1:16 PM Changeset in webkit [152373] by
-
- 1 edit1 add in trunk/Tools
Add Makefile to WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=118365
Reviewed by Mark Rowe.
- WebKitLauncher/Makefile: Added.
- 12:45 PM Changeset in webkit [152372] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skipping inspector tests that had other expectations, because specific rules override
general rules, and we need to skip all inspector tests.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 11:50 AM Changeset in webkit [152371] by
-
- 3 edits in trunk/Tools
[ATK] Leak: more leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118362
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.
Free the memory created by g_strdup_printf.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):
- 11:40 AM Changeset in webkit [152370] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152195.
- 11:06 AM Changeset in webkit [152369] by
-
- 4 edits in trunk
WebTextCheckerClient doesn't initialize output arguments.
https://bugs.webkit.org/show_bug.cgi?id=83683
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Martin Robinson.
Source/WebKit2:
Callers of checkSpellingOfString and checkGrammarOfString expect
certain default values when no misspelled (or bad grammar) string
is found. They try to do that by initialising the reply arguments
that go into the IPC calls, but these values are ultimately ignored (see
HandleMessage.h, where the replyArguments are declared).
In the past, this seems to have led to various issues, (see
TextCheckingHelper::findFirstMisspelling in TextCheckingHelper.cpp),
where these return values are asserted and checked to be in the right range.
This patch initialises the values, so even if no available client
implements the methods (or if the implementation forgets to do it) the callers
will have their expected output.
However, and for a general case, we probably need a way to tell the caller
that any existing value in the output arguments will be ignored.
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):
LayoutTests:
Unskip editing/pasteboard/pasting-empty-html-falls-back-to-text.html, which no longer
crashes after the fix.
- platform/gtk-wk2/TestExpectations:
- 10:45 AM Changeset in webkit [152368] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152317. <rdar://problem/14309423>
- 10:35 AM Changeset in webkit [152367] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867
Reviewed by Anders Carlsson.
We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.
There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
- 10:28 AM Changeset in webkit [152366] by
-
- 2 edits in trunk/Tools
Xcode often gets in a state where the debugger is completely unresponsive
https://bugs.webkit.org/show_bug.cgi?id=118157
The GetPointeeData() operations we use to retrieve strings is extremely expensive.
Rather than pull the character data out of the debugger one byte at a time
through the GetPointeeData() API, retrieve the memory contents of the string through
the ReadMemory() API, and convert the retrieved memory into a python string.
Reviewed by Anders Carlsson.
- lldb/lldb_webkit.py:
(lldb_init_module.lldb_webkit):
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
- 10:28 AM Changeset in webkit [152365] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skip inspector tests, because they are failing with production builds.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 10:10 AM Changeset in webkit [152364] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 10:07 AM Changeset in webkit [152363] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 10:05 AM Changeset in webkit [152362] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r152356.
http://trac.webkit.org/changeset/152356
https://bugs.webkit.org/show_bug.cgi?id=118361
Broke JSCore tests (Requested by andersca on #webkit).
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 10:03 AM Changeset in webkit [152361] by
-
- 1 delete in tags/Safari-537.48.1
Remove Tag.
- 9:48 AM Changeset in webkit [152360] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 9:46 AM Changeset in webkit [152359] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 9:43 AM Changeset in webkit [152358] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 9:12 AM Changeset in webkit [152357] by
-
- 2 edits in trunk/Source/WebKit2
Output arguments used in IPC calls should be returned initialised
https://bugs.webkit.org/show_bug.cgi?id=118354
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Anders Carlsson.
When Download::shouldDecodeSourceDataOfMIMEType and Download::retrieveDestinationWithSuggestedFilename
call DownloadProxy::shouldDecodeSourceDataOfMIMEType and DownloadProxy::decideDestinationWithSuggestedFilename
through IPC, they assume the output arguments result and allowOverwrite have
been initialised.
This patch initialises these arguments also in the unlikely event that a
m_webContext is not available.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
- 9:03 AM EFLWebKit edited by
- Added a short paragraph linking to the instructions on how to work … (diff)
- 8:49 AM PythonGuidelines edited by
- Added section on how to work with distros that come with Python 3 as … (diff)
- 8:38 AM Changeset in webkit [152356] by
-
- 3 edits in trunk/Source/WTF
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355
Reviewed by Anders Carlsson.
StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 8:28 AM Changeset in webkit [152355] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix after r152340.
- WebCore.exp.in:
- 7:52 AM Changeset in webkit [152354] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352
Reviewed by Carlos Garcia Campos.
The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.
The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetLoadingWebResource):
- 7:18 AM Changeset in webkit [152353] by
-
- 15 edits in trunk/Source/WebCore
Append overloading function for isFooElement
https://bugs.webkit.org/show_bug.cgi?id=118334
Reviewed by Antti Koivisto.
Node::hasTagName needs additional isElementNode() check when it is triggered.
So conversion from Element* to Node* in isFooElement should be avoided.
Therefore, to support both Node* and Element* as an argument of isFooElement,
this patch appends overloading inline function.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
- html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
- html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
- html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
- html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):
- 6:54 AM Changeset in webkit [152352] by
-
- 4 edits2 adds in trunk
Gif: zero filling should use memset instead of setRGBA for every pixel
https://bugs.webkit.org/show_bug.cgi?id=118350
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-07-03
Reviewed by Allan Sandfeld Jensen.
No new tests. Actually it is not covered by existing tests. Surprisingly we haven't got pixel
tests for animated images. Given that this patch is pretty trivial I don't think it's worth the
cost to start introducing such tests.
I added a manual test: animated-gif-dispose-background.html.
GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels.
This is extremely ineffecient. The use case for this code path is not frequent on the web
but it's still better to fix it.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::zeroFillFrameRect):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
Fixed indentation in addition.
- 5:59 AM Changeset in webkit [152351] by
-
- 3 edits in trunk/Source/WebCore
TextureUnit code optimization
https://bugs.webkit.org/show_bug.cgi?id=117868
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.
According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.
No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
- html/canvas/WebGLRenderingContext.h:
- 3:50 AM Changeset in webkit [152350] by
-
- 21 edits in trunk/Source/WebCore
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118305
Reviewed by Kentaro Hara.
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEConvolveMatrixElement.idl:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.idl:
- 3:19 AM Changeset in webkit [152349] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warnings in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=117991
Reviewed by Mark Hahnenberg.
- wtf/FastMalloc.cpp:
- 3:13 AM Changeset in webkit [152348] by
-
- 6 edits in trunk/Source
H&R Block 2010 Help window can not be reopened.
https://bugs.webkit.org/show_bug.cgi?id=118342
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-03
Reviewed by Antti Koivisto.
http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.
Source/WebCore:
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsHRBlock):
- platform/RuntimeApplicationChecks.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):
- 3:06 AM Changeset in webkit [152347] by
-
- 2 edits in trunk/Source/WebCore
Further build fixing for build configurations that disable CSS regions support.
- dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- 3:00 AM Changeset in webkit [152346] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.
- svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- svg/SVGElement.h: Ditto.
- 2:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:02 AM Changeset in webkit [152345] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Based on patch by Zoltán Árvai <zarvai@inf.u-szeged.hu>
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.
Fixed CSS_REGIONS guard.
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- 1:43 AM Changeset in webkit [152344] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebContext to GTask
https://bugs.webkit.org/show_bug.cgi?id=117153
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):
- 1:03 AM Changeset in webkit [152343] by
-
- 15 edits in trunk/Source/WebCore
Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292
Reviewed by Darin Adler.
Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.
No new tests, no behavior change.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):
- 12:44 AM Changeset in webkit [152342] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-03
- platform/qt/TestExpectations:
- 12:30 AM Changeset in webkit [152341] by
-
- 2 edits in trunk/Tools
[GTK] Let F5 refresh the page in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117638
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.
Also use the correct icon for the refresh button that was already there.
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):
