Timeline
Jul 19, 2013:
- 11:43 PM Changeset in webkit [152941] by
-
- 15 edits9 adds in trunk
Pages should not be able to abuse users inside beforeunload handlers.
<rdar://problem/14475779> and https://bugs.webkit.org/show_bug.cgi?id=118871.
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Tests: fast/loader/show-only-one-beforeunload-dialog.html
http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin.html
http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin.html
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::handleBeforeUnloadEvent):
(WebCore::FrameLoader::shouldCloseFiringBeforeUnloadEvent): Renamed from fireBeforeUnloadEvent.
Add logic to enforce "1 beforeunload dialog per navigation" as well as "iframes can only show beforeunload
dialogs if their entire ancestry's security origins match the navigating frame."
- loader/FrameLoader.h:
- loader/FrameLoader.h:
Add the ability for Page to know when any frame is dispatching beforeunload:
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::incrementFrameHandlingBeforeUnloadEventCount):
(WebCore::Page::decrementFrameHandlingBeforeUnloadEventCount):
(WebCore::Page::isAnyFrameHandlingBeforeUnloadEvent):
- page/Page.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::print): Disallow if any frame is in beforeunload dispatch.
(WebCore::DOMWindow::alert): Ditto.
(WebCore::DOMWindow::confirm): Ditto.
(WebCore::DOMWindow::prompt): Ditto.
(WebCore::DOMWindow::showModalDialog): Ditto.
LayoutTests:
In addition to the new tests, updated some results of previous tests that were relying on "alert"
as a poor man's logging method.
- fast/events/onbeforeunload-focused-iframe-expected.txt:
- fast/events/onbeforeunload-focused-iframe.html:
- fast/events/onunload-clears-onbeforeunload-expected.txt:
- fast/events/onunload-clears-onbeforeunload.html:
- fast/loader/page-dismissal-modal-dialogs-expected.txt:
- fast/loader/page-dismissal-modal-dialogs.html:
- fast/loader/recursive-before-unload-crash-expected.txt:
- fast/loader/recursive-before-unload-crash.html:
- fast/loader/resources/iframe-with-beforeunload.html: Added.
- fast/loader/show-only-one-beforeunload-dialog-expected.txt: Added.
- fast/loader/show-only-one-beforeunload-dialog.html: Added.
- http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin-expected.txt: Added.
- http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin.html: Added.
- http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin-expected.txt: Added.
- http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin.html: Added.
- http/tests/misc/resources/iframe-with-beforeunload.html: Added.
- http/tests/misc/resources/notify-done.html: Added.
- 11:42 PM Changeset in webkit [152940] by
-
- 4 edits in releases/WebKitGTK/webkit-2.0
Unreviewed. Update NEWS and Versions.m4 for 2.0.4 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.0.4.
- 8:37 PM Changeset in webkit [152939] by
-
- 5 edits in trunk
AX: VoiceOver not detecting misspelled words don't work in all cases
https://bugs.webkit.org/show_bug.cgi?id=118924
Reviewed by Tim Horton.
Source/WebCore:
VoiceOver is now looking for a new misspelled attribute.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetSpelling):
(AXAttributedStringAppendText):
Tools:
Make the misspelled detection dependent on both types of attributes being present.
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::attributedStringRangeIsMisspelled):
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
- 7:59 PM Changeset in webkit [152938] by
-
- 2 edits in trunk/Source/WebCore
Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue
https://bugs.webkit.org/show_bug.cgi?id=118930
Reviewed by Andreas Kling.
Extracted two functions as a preparation to fix bugs 118032 and 118618.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::nodeOrItsAncestorNeedsStyleRecalc):
(WebCore::computeRenderStyleForProperty):
(WebCore::ComputedStyleExtractor::propertyValue):
- 7:53 PM Changeset in webkit [152937] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Structure::isValidOffset() should be able to tell you if you're loading a valid JSValue, and not just not crashing
https://bugs.webkit.org/show_bug.cgi?id=118911
Reviewed by Geoffrey Garen.
We could also have a separate method like "willNotCrash(offset)", but that's not
what isValidOffset() is intended to mean.
- runtime/Structure.h:
(JSC::Structure::isValidOffset):
- 6:32 PM Changeset in webkit [152936] by
-
- 2 edits in trunk/Tools
<rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
Unreviewed.
Rebaseline pagination test after http://trac.webkit.org/changeset/152911
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
- 5:58 PM Changeset in webkit [152935] by
-
- 3 edits in trunk/Source/WebCore
Cache style declaration CSSOM wrappers directly on MutableStylePropertySet.
<http://webkit.org/b/118883>
Reviewed by Gavin Barraclough
Merge https://chromium.googlesource.com/chromium/blink/+/183bcd51eb0e79cab930cf46695df05dc793630f
From Blink r153700 by <ager@chromium.org>:
In my measurements the mapping is adding more overhead than just having a field
in all MutableStylePropertySet objects. So this saves memory and makes access
faster.
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::StylePropertySet::hasCSSOMWrapper):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):
- css/StylePropertySet.h:
(WebCore::StylePropertySet::StylePropertySet):
- 5:11 PM Changeset in webkit [152934] by
-
- 3 edits in trunk/Tools
Improved code coverage generation.
https://bugs.webkit.org/show_bug.cgi?id=118926
Reviewed by Tim Horton.
- Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
- Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
(generateReport): Moved report generation to a subroutine.
- 4:30 PM Changeset in webkit [152933] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix on Windows after r152930.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Added missing close paren.
- 4:08 PM Changeset in webkit [152932] by
-
- 2 edits in trunk/LayoutTests
Some compositing tests fail on ML WK2 Debugi
https://bugs.webkit.org/show_bug.cgi?id=118925
Unreviewed.
- platform/mac-wk2/TestExpectations:
- 3:46 PM Changeset in webkit [152931] by
-
- 2 edits in trunk/Tools
Make Perl tools work when using git bisect with Git branch build setup
https://bugs.webkit.org/show_bug.cgi?id=118512
Reviewed by Martin Robinson.
The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
during a git bisect session with a Git branch build setup (i.e. git config
core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
specific build of WebKit because they cannot determine the branch Git is on (since
git bisect puts Git into a detached HEAD state). We should teach our tooling to
parse the file .git/BISECT_START (created by git bisect start) for the name of the
branch Git was on when we began a git bisect session. Then the tools can determine
the path to the built WebKit.
- Scripts/VCSUtils.pm:
(gitDirectory): Added.
(gitBisectStartBranch): Added.
(gitBranch): Modified to call gitBisectStartBranch() when we have a detached
HEAD (e.g. running git bisect).
(determineVCSRoot): Modified to call gitDirectory() to determine the path to
the .git directory in the Git checkout.
- 3:44 PM Changeset in webkit [152930] by
-
- 3 edits in trunk/Source/WebKit
Added 64-bit symbols to WebKitExports.def.in for 64-bit Windows builds
and a macro to only use them for 64-bit builds.
https://bugs.webkit.org/show_bug.cgi?id=118887
Reviewed by Brent Fulgham.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Added 64-bit symbols.
- WebKit.vcxproj/WebKitExportGenerator/make-export-file-generator:
Added support for new symbolWithPointer macro.
- 3:07 PM Changeset in webkit [152929] by
-
- 2 edits1 add in trunk/Source/ThirdParty/ANGLE
Generate derived files in ANGLE at build time rather than when updating from upstream.
https://bugs.webkit.org/show_bug.cgi?id=118872
Reviewed by Mark Rowe.
- ANGLE.xcodeproj/project.pbxproj: Made Derived Sources target which calls DerivedSources.make,
moved generated files into Derived Sources group.
- DerivedSources.make: Added.
- 2:51 PM Changeset in webkit [152928] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip failing tests to make WinEWS bots happy.
- platform/win/TestExpectations:
- 2:40 PM Changeset in webkit [152927] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Avoid passing addresses of temporaries to Windows API.
https://bugs.webkit.org/show_bug.cgi?id=118917
Reviewed by Anders Carlsson.
The temporary Vector returned by String::charactersWithNullTermination
was going out of scope before its first use, causing Windows API to
receive garbage memory.
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
- platform/win/PasteboardWin.cpp:
(WebCore::createGlobalHDropContent):
- platform/win/SSLKeyGeneratorWin.cpp:
(WebCore::WebCore::signedPublicKeyAndChallengeString):
- 1:54 PM Changeset in webkit [152926] by
-
- 2 edits in trunk/LayoutTests
Unskip flaky tests on AppleWin.
Flakiness is not an issue with the tests themselves but with the test infrastructure.
- platform/win/TestExpectations:
- 1:32 PM Changeset in webkit [152925] by
-
- 2 edits in trunk/Source/WebCore
[CSS Shapes] Remove lineWithinShapeBounds() from ShapeInfo since it's no longer used
https://bugs.webkit.org/show_bug.cgi?id=118913
Reviewed by Andreas Kling.
No new tests, no behavior change.
- rendering/shapes/ShapeInfo.h: Remove lineWithinShapeBounds().
- 1:30 PM Changeset in webkit [152924] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip some flaky tests on AppleWin port.
- platform/win/TestExpectations:
- 1:14 PM Changeset in webkit [152923] by
-
- 3 edits17 adds48 deletes in trunk/LayoutTests
More conversions from MathML pixel tests to reftests.
https://bugs.webkit.org/show_bug.cgi?id=118853
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-19
Reviewed by Chris Fleizach.
- mathml/presentation/fenced-expected.html: Added.
- mathml/presentation/fenced-mi-expected.html: Added.
- mathml/presentation/fenced-mi.html: Added.
- mathml/presentation/fenced-mi.xhtml: Removed.
- mathml/presentation/fenced.html: Added.
- mathml/presentation/fenced.xhtml: Removed.
- mathml/presentation/mroot-pref-width-expected.html: Added.
- mathml/presentation/mroot-pref-width.html:
- mathml/presentation/row-alignment.xhtml: Removed.
- mathml/presentation/style-border-padding-background-expected.html: Added.
- mathml/presentation/style-border-padding-background.html: Added.
- mathml/presentation/style-color-sqrt-expected-mismatch.html: Added.
- mathml/presentation/style-color-sqrt.html: Added.
- mathml/presentation/style.xhtml: Removed.
- mathml/presentation/tables-columnalign-expected.html: Added.
- mathml/presentation/tables-columnalign.html: Added.
- mathml/presentation/tables-simple-expected.html: Added.
- mathml/presentation/tables-simple.html: Added.
- mathml/presentation/tables-spans-dynamic-expected.html: Added.
- mathml/presentation/tables-spans-dynamic.html: Added.
- mathml/presentation/tables-spans-expected.html: Added.
- mathml/presentation/tables-spans.html: Added.
- mathml/presentation/tables.xhtml: Removed.
- mathml/xHeight.xhtml: Removed.
- platform/efl/mathml/presentation/fenced-expected.png: Removed.
- platform/efl/mathml/presentation/fenced-expected.txt: Removed.
- platform/efl/mathml/presentation/fenced-mi-expected.png: Removed.
- platform/efl/mathml/presentation/fenced-mi-expected.txt: Removed.
- platform/efl/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/efl/mathml/presentation/mroot-pref-width-expected.txt: Removed.
- platform/efl/mathml/presentation/row-alignment-expected.png: Removed.
- platform/efl/mathml/presentation/row-alignment-expected.txt: Removed.
- platform/efl/mathml/presentation/style-expected.png: Removed.
- platform/efl/mathml/presentation/style-expected.txt: Removed.
- platform/efl/mathml/presentation/tables-expected.png: Removed.
- platform/efl/mathml/presentation/tables-expected.txt: Removed.
- platform/efl/mathml/xHeight-expected.png: Removed.
- platform/efl/mathml/xHeight-expected.txt: Removed.
- platform/gtk/mathml/presentation/fenced-expected.png: Removed.
- platform/gtk/mathml/presentation/fenced-expected.txt: Removed.
- platform/gtk/mathml/presentation/fenced-mi-expected.png: Removed.
- platform/gtk/mathml/presentation/fenced-mi-expected.txt: Removed.
- platform/gtk/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Removed.
- platform/gtk/mathml/presentation/row-alignment-expected.png: Removed.
- platform/gtk/mathml/presentation/row-alignment-expected.txt: Removed.
- platform/gtk/mathml/presentation/style-expected.png: Removed.
- platform/gtk/mathml/presentation/style-expected.txt: Removed.
- platform/gtk/mathml/presentation/tables-expected.png: Removed.
- platform/gtk/mathml/presentation/tables-expected.txt: Removed.
- platform/gtk/mathml/xHeight-expected.png: Removed.
- platform/gtk/mathml/xHeight-expected.txt: Removed.
- platform/mac/TestExpectations:
- platform/mac/mathml/presentation/fenced-expected.png: Removed.
- platform/mac/mathml/presentation/fenced-expected.txt: Removed.
- platform/mac/mathml/presentation/fenced-mi-expected.png: Removed.
- platform/mac/mathml/presentation/fenced-mi-expected.txt: Removed.
- platform/mac/mathml/presentation/mroot-pref-width-expected.png: Removed.
- platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Removed.
- platform/mac/mathml/presentation/row-alignment-expected.png: Removed.
- platform/mac/mathml/presentation/row-alignment-expected.txt: Removed.
- platform/mac/mathml/presentation/style-expected.png: Removed.
- platform/mac/mathml/presentation/style-expected.txt: Removed.
- platform/mac/mathml/presentation/tables-expected.png: Removed.
- platform/mac/mathml/presentation/tables-expected.txt: Removed.
- platform/mac/mathml/xHeight-expected.png: Removed.
- platform/mac/mathml/xHeight-expected.txt: Removed.
- 1:04 PM Changeset in webkit [152922] by
-
- 4 edits2 adds in trunk/Source/WebKit2
[GTK] Need a way to enable region based columns from the command line
https://bugs.webkit.org/show_bug.cgi?id=116611
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-19
Reviewed by Martin Robinson.
Add an environment variable to enable experimental features.
This provides a means to enable experimental features without polluting
the public API.
Environment variable name: WEBKITGTK_EXPERIMENTAL_FEATURES
Format: WEBKITGTK_EXPERIMENTAL_FEATURES="<feature1>=1,<feature2>=1,..."
Or, to enable all experimental features: WEBKITGTK_EXPERIMENTAL_FEATURES=all
So far the only feature is region based columns (implement multicol using
the CSS regions implementation rather than ColumnInfo & co) - REGION_BASED_COLUMNS.
Example: WEBKITGTK_EXPERIMENTAL_FEATURES="REGION_BASED_COLUMNS=1"
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsConstructed):
(webkit_settings_class_init):
- UIProcess/gtk/ExperimentalFeatures.cpp: Added.
(WebKit):
(Setting):
(WebKit::ExperimentalFeatures::ExperimentalFeatures):
(WebKit::ExperimentalFeatures::isEnabled):
(WebKit::ExperimentalFeatures::setEnableByName):
(WebKit::ExperimentalFeatures::parseEnvironment):
- UIProcess/gtk/ExperimentalFeatures.h: Added.
(WebKit):
(ExperimentalFeatures):
- 12:43 PM Changeset in webkit [152921] by
-
- 40 edits in trunk
Added x64 configuration to Visual Studio build.
https://bugs.webkit.org/show_bug.cgi?id=118888
Reviewed by Brent Fulgham.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
- JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
- JavaScriptCore.vcxproj/jsc/jsc.vcxproj:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
Source/ThirdParty:
- gtest/msvc/gtest-md.vcxproj:
Source/WebCore:
- WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCoreGenerated.vcxproj:
- WebCore.vcxproj/WebCoreTestSupport.vcxproj:
Source/WebKit:
- WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
- WebKit.vcxproj/WebKit.sln:
- WebKit.vcxproj/WebKit/WebKit.vcxproj:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
- WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
Source/WTF:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.vcxproj/WTFGenerated.vcxproj:
Tools:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
- win/record-memory/record-memory.vcxproj:
- 12:42 PM Changeset in webkit [152920] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip some flaky tests on AppleWin port.
- platform/win/TestExpectations:
- 12:21 PM Changeset in webkit [152919] by
-
- 5 edits2 adds in trunk
Spatial Navigation handling of space key in <select> appears to confuse listIndex and optionIndex.
https://bugs.webkit.org/show_bug.cgi?id=99525
Source/WebCore:
HTMLSelect Element inherently contains the logic to focus option node and thus, implementing an explicit logic to find the focus index is not required.
Patch by Abhijeet Kandalkar <abhijeet.k@samsung.com> on 2013-07-19
Reviewed by Joseph Pecoraro.
Test: fast/spatial-navigation/snav-multiple-select-optgroup.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- page/SpatialNavigation.cpp:
(WebCore::canScrollInDirection):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
LayoutTests:
Added testcase to test support of option group within HTMLSelect element.
Patch by Abhijeet Kandalkar <abhijeet.k@samsung.com> on 2013-07-19
Reviewed by Joseph Pecoraro.
- fast/spatial-navigation/snav-multiple-select-optgroup-expected.txt: Added.
- fast/spatial-navigation/snav-multiple-select-optgroup.html: Added.
- 11:56 AM Changeset in webkit [152918] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152877. <rdar://problem/14271327>
- 11:55 AM Changeset in webkit [152917] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152818. <rdar://problem/14473897>
- 11:54 AM Changeset in webkit [152916] by
-
- 12 edits12 copies in branches/safari-537-branch
Merged r152813. <rdar://problem/14473897>
- 11:51 AM Changeset in webkit [152915] by
-
- 2 edits in tags/Safari-537.51.3/Source/WebKit2
Merged r152877. <rdar://problem/14271327>
- 11:49 AM Changeset in webkit [152914] by
-
- 3 edits in tags/Safari-537.51.3/Source/JavaScriptCore
Merged r152818. <rdar://problem/14473897>
- 11:46 AM Changeset in webkit [152913] by
-
- 12 edits12 copies in tags/Safari-537.51.3
Merged r152813. <rdar://problem/14473897>
- 11:38 AM Changeset in webkit [152912] by
-
- 5 edits in tags/Safari-537.51.3/Source
Versioning.
- 11:37 AM Changeset in webkit [152911] by
-
- 14 edits50 adds in trunk
OSX: ePub: Unable to select text in vertical Japanese book
https://bugs.webkit.org/show_bug.cgi?id=118864
<rdar://problem/14109351>
Reviewed by Dan Bernstein and Sam Weinig.
Source/WebCore:
This patch fixes all of the various writing-mode and pagination combinations
so that the columns are painted in the correct location. The code that sets up
the initial painting translation offset in the block direction and that advances
that offset has been pulled into two helper functions, initialBlockOffsetForPainting
and blockDeltaForPaintingNextColumn, and that code is now shared by the four call
sites that need it (painting and hit testing in RenderBlock and painting and hit testing
in RenderLayer).
This patch also backs out the maximumScrollPosition change, since it only occurred because
of incorrect sizing of the RenderView, and this sizing issue has now been corrected by
ensuring that computeLogicalHeight() always makes sure you are the size of the viewport
and does not shrink you to the column height.
There was also a race condition that caused pagination to be incorrect if layout occurred
before the html/body renderer that set the writing-mode were available. When this happened,
the writing mode got propagated up to the view, but the column styles didn't get
adjusted to compensate for the writing mode change.
Added tests for every pagination and writing-mode combination in fast/multicol/pagination.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForDocument):
(WebCore::StyleResolver::adjustRenderStyle):
Move setStylesForPaginationMode into RenderStyle and make it a member function. This is
necessary so that the style can be adjusted dynamically to fix the race condition mentioned
above.
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
Back out this change since the symptom it was fixing only occurred because the logical
height of the view was being set incorrectly.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
Patch the column code that sets up the initial page height to use the pagination API's
page height rather than the viewport logical height. This allows the view to still match
the viewport in dimensions rather than being incorrectly sized to the column height.
(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
Two new helper functions used to set up the block direction paint/hit testing translation.
The major bug fix that occurred in this code is that the old block axis code didn't handle
reversal correctly and it also used physical coordinates to try to determine the translation
offset, when you really need to use logical coordinates in the original writing mode coordinate
system to determine the offset.
(WebCore::RenderBlock::paintColumnContents):
Patched to call the new helper functions.
(WebCore::ColumnRectIterator::ColumnRectIterator):
(WebCore::ColumnRectIterator::adjust):
(WebCore::ColumnRectIterator::update):
Patched to call the new helper functions.
- rendering/RenderBlock.h:
Add the two new helper functions to the RenderBlock header.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
If the writing mode of the html/body propagates to the viewport and changes its writing mode,
also change our column styles to match if we're in paginated mode.
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
Call the new pageOrViewLogicalHeight function on RenderView instead of
RenderBox::viewLogicalHeightForPercentages (which is now removed).
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
Patched to use the two new helper functions for block direction paint offset setup and
advancement.
- rendering/RenderView.cpp:
(WebCore::RenderView::pageOrViewLogicalHeight):
New helper function that does what viewLogicalHeightForPercentages used to do but also
handles returning the page length for block axis column progression. Again, this is to
allow the view to retain its correct size (matching the viewport).
(WebCore::RenderView::viewLogicalHeight):
Back out the code that made the view grow or shrink to the size of the Pagination API page
length when the progression was block axis. This was the source of most of the scroll origin
and scrolling issues.
- rendering/RenderView.h:
Add the new pageOrViewLogicalHeight() function.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setColumnStylesFromPaginationMode):
This is the old StyleResolver function for setting up the column styles. It's in RenderStyle
now so that it can be called at any time to change a style rather than only at style resolution
time.
- rendering/style/RenderStyle.h:
Declaration of the setColumnStylesFromPaginationMode function.
LayoutTests:
- fast/multicol/pagination: Added.
- fast/multicol/pagination/BottomToTop-bt.html: Added.
- fast/multicol/pagination/BottomToTop-lr.html: Added.
- fast/multicol/pagination/BottomToTop-rl.html: Added.
- fast/multicol/pagination/BottomToTop-tb.html: Added.
- fast/multicol/pagination/LeftToRight-bt.html: Added.
- fast/multicol/pagination/LeftToRight-lr.html: Added.
- fast/multicol/pagination/LeftToRight-rl.html: Added.
- fast/multicol/pagination/LeftToRight-tb.html: Added.
- fast/multicol/pagination/RightToLeft-bt.html: Added.
- fast/multicol/pagination/RightToLeft-lr.html: Added.
- fast/multicol/pagination/RightToLeft-rl.html: Added.
- fast/multicol/pagination/RightToLeft-tb.html: Added.
- fast/multicol/pagination/TopToBottom-bt.html: Added.
- fast/multicol/pagination/TopToBottom-lr.html: Added.
- fast/multicol/pagination/TopToBottom-rl.html: Added.
- fast/multicol/pagination/TopToBottom-tb.html: Added.
- platform/mac/fast/multicol/pagination: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.txt: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png: Added.
- platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.txt: Added.
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
- platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
- 11:31 AM Changeset in webkit [152910] by
-
- 1 copy in tags/Safari-537.51.3
New Tag.
- 11:14 AM Changeset in webkit [152909] by
-
- 13 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Structure should be able to tell you if it's valid to load at a given offset from any object with that structure
https://bugs.webkit.org/show_bug.cgi?id=118878
Reviewed by Oliver Hunt.
- Change Structure::isValidOffset() to actually answer the question "If I attempted to load from an object of this structure, at this offset, would I commit suicide or would I get back some kind of value?"
- Change StorageAccessData::offset to use a PropertyOffset. It should have been that way from the start.
- Fix PutStructure so that it sets haveStructures in all of the cases that it should.
- Make GetByOffset also reference the base object in addition to the butterfly.
The future use of this power will be to answer questions like "If I hoisted this
GetByOffset or PutByOffset to this point, would it cause crashes, or would it be
fine?"
I don't currently plan to use this power to perform validation, since the CSE has
the power to eliminate CheckStructure's that the CFA wouldn't be smart enough to
remove - both in the case of StructureSets where size >= 2 and in the case of
CheckStructures that match across PutStructures. At first I tried to write a
validator that was aware of this, but the validation code got way too complicated
and I started having nightmares of spurious assertion bugs being filed against me.
This also changes some of the code for how we hash FunctionExecutable's for debug
dumps, since that code still had some thread-safety issues. Basically, the
concurrent JIT needs to use the CodeBlock's precomputed hash and never call anything
that could transitively try to compute the hash from the source code. The source
code is a string that may be lazily computed, and that involves all manner of thread
unsafe things.
- bytecode/CodeOrigin.cpp:
(JSC::InlineCallFrame::hash):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.h:
(StorageAccessData):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToGetByOffset):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):
- runtime/FunctionExecutableDump.cpp:
(JSC::FunctionExecutableDump::dump):
- runtime/Structure.h:
(Structure):
(JSC::Structure::isValidOffset):
- 10:52 AM Changeset in webkit [152908] by
-
- 9 edits in trunk/Source
[Curl] Http response code 401 (Authentication required) is not handled.
https://bugs.webkit.org/show_bug.cgi?id=118849
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-19
Reviewed by Brent Fulgham.
The current Curl implementation does not handle a 401 response.
When receiving http code 401, we need to give a notification that authorization is required, by calling the appropriate notification method.
This gives a WebKit client the possibility to present a password dialog to the user.
In response to this, we should provide Curl with the given username and password, so another request can be sent with the given credentials.
Source/WebCore:
- platform/network/ResourceHandle.h:
Added method to check if credential storage should be used.
- platform/network/ResourceHandleInternal.h:
Added member to keep track of number of authentication failures.
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::shouldUseCredentialStorage):
Added method to check if credential storage should be used.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
Implement method; notify client when authentication is required.
(WebCore::ResourceHandle::receivedCredential):
Implement method; provide Curl with password and username when available.
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
Implement method; reset Curl username and password.
(WebCore::ResourceHandle::receivedCancellation):
Implement method; notify client that authorization has been cancelled.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isHttpAuthentication):
Added function to check if http code is an 'Authorization required' code.
(WebCore::getProtectionSpace):
Added function to initialize a protection space object from a Curl handle and a response object.
(WebCore::headerCallback):
Notify client when authorization is required.
(WebCore::ResourceHandleManager::applyAuthenticationToRequest):
Added method to set Curl username and password.
(WebCore::ResourceHandleManager::initializeHandle):
Use method to set Curl username and password.
- platform/network/curl/ResourceHandleManager.h:
Added method to set Curl username and password.
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Implement empty method; use the same implementation as the CFNetwork version does,
notify delegate when authorization is required.
- WebURLAuthenticationChallengeSenderCurl.cpp:
(WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
Implement empty method; use the same implementation as the CFNetwork version does.
(WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
Implement empty method; use the same implementation as the CFNetwork version does.
(WebURLAuthenticationChallengeSender::useCredential):
Implement empty method; use the same implementation as the CFNetwork version does.
- 10:47 AM Changeset in webkit [152907] by
-
- 3 edits2 adds in trunk
Hover doesn't work for block elements inside a href element
https://bugs.webkit.org/show_bug.cgi?id=118907
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-19
Reviewed by David Hyatt.
Source/WebCore:
Added test for hovering block elements inside a href element.
Test: fast/css/hover-display-block.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hoverAncestor):
LayoutTests:
Don't skip all anonymous objects when searching for the hover ancestor, only the ones
directly flowed into a region.
- fast/css/hover-display-block-expected.txt: Added.
- fast/css/hover-display-block.html: Added.
- 10:46 AM Changeset in webkit [152906] by
-
- 5 edits in trunk
[CSS Shapes] Clear overflowing line's segments in pushShapeContentOverflowBelowTheContentBox
https://bugs.webkit.org/show_bug.cgi?id=118002
Reviewed by David Hyatt.
When the last line in the shape overlaps with the shape bottom boundaries we need to clear the computed segments. (We need to compute
the segments anyway, since shape-outside's code uses the same code path to determine its segments and the line containing is not a
requirement in that case.) Rather then doing the job in RenderBlock::LineBreaker::nextLineBreak I moved the functionality to its correct
place to pushShapeContentOverflowBelowTheContentBox. Now all the overflow related functionality is located in one function. I fixed the
corresponding layout test.
Source/WebCore:
Tests: I modified shape-inside-overflow.html.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::pushShapeContentOverflowBelowTheContentBox): Remove segments if line overlaps with the shape's boundaries.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Move segments clear logic to pushShapeContentOverflowBelowContentBox.
LayoutTests:
- fast/shapes/shape-inside/shape-inside-overflow-expected.html:
- fast/shapes/shape-inside/shape-inside-overflow.html:
- 10:43 AM Changeset in webkit [152905] by
-
- 2 edits in trunk/Source/WebCore
TrailingObjects shouldn't shrink vector capacity in a loop
https://bugs.webkit.org/show_bug.cgi?id=118322
Reviewed by Darin Adler.
This seems to take about 3% off the profile of loading a large text file.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::TrailingObjects::clear): clear() has the built-in side effect
of throwing away existing capacity. Use shrink(0) to indicate that we
want to keep our existing capacity.
- 10:40 AM Changeset in webkit [152904] by
-
- 7 edits in trunk/LayoutTests
[CSS Shapes][CSS Regions] Modify existing tests to test overflow also when padding is applied on the container
https://bugs.webkit.org/show_bug.cgi?id=117881
Reviewed by David Hyatt.
Currently, we don't have tests which test the overflow behavior when there is padding applied on the container.
I modified the existing tests to cover these cases as well and increase our test coverage.
- fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
- fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html:
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html:
- 10:33 AM Changeset in webkit [152903] by
-
- 3 edits in trunk/Tools
Add a couple people to the MathML watchlist
https://bugs.webkit.org/show_bug.cgi?id=118909
Reviewed by Andreas Kling.
Add a couple people to the MathML watchlist and add Kalyan's other
email address to fix style checker warnings about the watchlist
contents.
- Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
list of contributors and add Kalyan's second email address.
- Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
watchlist.
- 9:13 AM Changeset in webkit [152902] by
-
- 3 edits in trunk/LayoutTests
Update test expectations for MathML after r152840.
https://bugs.webkit.org/show_bug.cgi?id=118053
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-19
Reviewed by Chris Fleizach.
- TestExpectations: unskip mspace tests
- platform/mac/TestExpectations: ImageOnlyFailure for mspace-units
- 8:21 AM Changeset in webkit [152901] by
-
- 7 edits3 adds in trunk/LayoutTests
[GTK] Unreviewed gardening. Update expectations after r152793, r152777 and r152872
https://bugs.webkit.org/show_bug.cgi?id=118906
Unreviewed GTK gardening.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-19
- platform/gtk/TestExpectations: Mark svg/animations/svgenum-animation-6.html as flaky, and
mathml/presentation/bug95404.html, introduced in r152777, as ImageOnlyFailure.
- platform/gtk/editing/pasteboard/emacs-cntl-y-001-expected.txt: New baseline after r152872.
- platform/gtk/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Ditto.
- platform/gtk/fast/dom/Range/getClientRects-expected.txt: Ditto.
- platform/gtk/fast/js/function-length-expected.txt: Ditto.
- platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added after r152872.
- platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added after r152872.
- platform/gtk/tables/mozilla/marvin/backgr_index-expected.txt: New baseline after r152793.
- 6:37 AM Changeset in webkit [152900] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] More unreviewed cleanup for pixel tester bot.
- platform/qt-5.0-wk2/TestExpectations:
- 6:27 AM Changeset in webkit [152899] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed cleanup for pixel tester bot.
- platform/qt-5.0-wk2/TestExpectations:
- 5:46 AM Changeset in webkit [152898] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Merge decamelizations fix ups in the GObject DOM bindings code generator
https://bugs.webkit.org/show_bug.cgi?id=117543
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-07-19
Reviewed by Carlos Garcia Campos.
Ensure that all the code that calls to decamelize() applies the same fix ups
Now all functions that need to decamelize a string should simply call
to decamelize(). This function calls to FixUpDecamelize to apply some
fix ups.
- bindings/scripts/CodeGeneratorGObject.pm:
(decamelize): decamelizes a string and applies fix ups
(FixUpDecamelize): applies a series of fix ups to a decamelized string
(GetParentGObjType): moved fix ups to FixUpDecamelize()
(GenerateProperties): simply call to decamelize
(GenerateHeader): simply call to decamelize
(GetGReturnMacro): simply call to decamelize
(GenerateFunction): simply call to decamelize
(GenerateCFile): simply call to decamelize
(GenerateEventTargetIface): simply call to decamelize
- 5:18 AM Changeset in webkit [152897] by
-
- 2 edits in trunk/Tools
[GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
https://bugs.webkit.org/show_bug.cgi?id=118895
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-19
Reviewed by Philippe Normand.
In r152782 an uri is used to create an string representation without checking first if it
is valid. That fails later when the string is used to check for existing redirections. This
patch ensures that the uri is valid before using it.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(willSendRequestCallback): Ensure an uri is valid before using it.
- 5:13 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:11 AM Changeset in webkit [152896] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2
Merge r152340 - [WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280
Reviewed by Darin Adler.
Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
- 5:09 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:07 AM Changeset in webkit [152895] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r151674 - [GTK][GStreamer] Fullscreen option in video element context menu not working
https://bugs.webkit.org/show_bug.cgi?id=105191
.:
Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.
- Source/autotools/SetupAutoconfHeader.m4: Removed the use of
fullscreen native media controls.
- 4:52 AM Changeset in webkit [152894] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed.
Fix an assertion failure which causes debug bots to fail.
- platform/network/NetworkStateNotifier.cpp:
(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):
- 3:31 AM Changeset in webkit [152893] by
-
- 4 edits in trunk
[GTK] media/video-seek-multiple.html is failing
https://bugs.webkit.org/show_bug.cgi?id=117580
Patch by Miguel Gomez <magomez@igalia.com> on 2013-07-19
Reviewed by Philippe Normand.
Source/WebCore:
When receiving several seek calls in a row, ensure that the final position
is the one requested in the last call received.
Already covered in test media/video-seek-multiple.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::seek):
LayoutTests:
Change expectation for media/video-seek-multiple.html test
- platform/gtk/TestExpectations:
- 3:28 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:26 AM Changeset in webkit [152892] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r149543 - [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
https://bugs.webkit.org/show_bug.cgi?id=115575
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-05-03
Reviewed by Philippe Normand.
No new tests needed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
Using extern debug category.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
Declaring debug category as not static.
- 3:21 AM WebKitGTK/2.0.x edited by
- (diff)
- 3:19 AM Changeset in webkit [152891] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.0
Merge r148131 - Clicking on the volume slider of HTML5 elements is pausing sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/click-volume-bar-not-pausing.html
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.
LayoutTests:
Added test.
- media/click-volume-bar-not-pausing-expected.txt: Added.
- media/click-volume-bar-not-pausing.html: Added.
- 3:13 AM Changeset in webkit [152890] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
Merge r152712 - [GTK] Remove compile warnings about GTK+ API deprecated after 3.6
https://bugs.webkit.org/show_bug.cgi?id=118237
Reviewed by Philippe Normand.
We depend on GTK+3.6 so we are not interested in compile warnings
about deprecated API after 3.6
- Source/autotools/SetupAutoconfHeader.m4: Define
GDK_VERSION_MIN_REQUIRED in config.h.
- 2:10 AM Changeset in webkit [152889] by
-
- 9 edits in trunk/Source/WebCore
Use explicit HTMLFrameElementBase cast and introduce toHTMLFrameElementBase
https://bugs.webkit.org/show_bug.cgi?id=118873
Reviewed by Ryosuke Niwa.
It should be HTMLFrameElementBase that embraces both HTMLFrameElement and HTMLIFrameElement.
This also makes correct toFooElement possible.
Next, to avoid direct use of static_cast, this patch introduces toHTMLFrameElementBase for code cleanup.
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::didNotifySubtreeInsertions):
- html/HTMLFrameElementBase.h:
(WebCore::toHTMLFrameElementBase):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
- page/EventHandler.cpp:
(WebCore::targetIsFrame):
- page/FrameView.cpp:
(WebCore::FrameView::init):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
- rendering/RenderLayer.cpp:
(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):
- 1:38 AM WebKitGTK/2.0.x edited by
- (diff)
- 1:36 AM Changeset in webkit [152888] by
-
- 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore
Merge r152552 - Fix build against GTK+ 2.0
https://bugs.webkit.org/show_bug.cgi?id=117895
Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-07-10
Reviewed by Martin Robinson.
GTK2 build fails for undefined GDK_IS_X11_DISPLAY
GTK 2.0 does define GDK_WINDOWING_X11,but GDK_IS_X11_DISPLAY is not
present in GTK+ 2.0. A dummy defines is sufficient, as GTK 2.0 is not
that multiple backend aware anyway...
- platform/gtk/GtkVersioning.h: Define GDK_IS_X11_DISPLAY for GTK+ 2.0 and compatibility for gtk_widget_get_preferred_size()
- plugins/gtk/gtk2xtbin.c: Include config.h
- 1:22 AM Changeset in webkit [152887] by
-
- 5 edits1 copy in trunk/LayoutTests
[Qt] Unreviewed gardening. Rebase failing tests.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-19
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/marvin/backgr_index-expected.txt.
- platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/qt/http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
- platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
Jul 18, 2013:
- 11:53 PM Changeset in webkit [152886] by
-
- 2 edits in trunk/Source/WebCore
Bindings generation tests are failing
https://bugs.webkit.org/show_bug.cgi?id=118877
Reviewed by Kentaro Hara.
I inadvertently removed the wrong part of the if statement
in r152845, causing hasAttribute() to be used unconditionally
for reflected boolean attributes instead of fastHasAttribute().
This patch fixes the issue.
No new tests, covered by bindings tests.
- bindings/scripts/CodeGenerator.pm:
(GetterExpression):
- 10:07 PM Changeset in webkit [152885] by
-
- 16 edits in trunk/Source/WebCore
WorkerGlobalScope should support onoffline/ononline event handlers
https://bugs.webkit.org/show_bug.cgi?id=118832
Reviewed by Alexey Proskuryakov.
HTML5 spec says that WorkerGlobalScope should support
onoffline/ononline event handlers as stated in
http://www.whatwg.org/specs/web-apps/current-work/multipage/offline.html#event-offline
Modified NetworkStateNotifier to support multiple callbacks and added a
callback to dispatch offline and online events to WorkerGlobalScope
when network state is changed.
No new test because the current test infrastructure does not provide a
mock network state notifier.
- page/Page.cpp:
(WebCore::networkStateChanged):
Change the function to take an additional argument, isOnLine so that we
can remove a call to NetworkStateNotifier::onLine().
(WebCore::Page::Page):
Use NetworkStateNotifier::addNetworkStateChangeListener which
allows us to add multiple callbacks.
- platform/network/NetworkStateNotifier.cpp:
(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):
Replace NetworkStateNotifier::setNetworkStateChangedFunction with
NetworkStateNotifier::addNetworkStateChangeListener.
(WebCore::NetworkStateNotifier::notifyNetworkStateChange):
A helper method to notify all registered network state change
callbacks.
- platform/network/NetworkStateNotifier.h:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/blackberry/NetworkStateNotifierBlackBerry.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
(WebCore::NetworkStateNotifier::networkStateChange):
- platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::networkInterfaceChanged):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/mac/NetworkStateNotifierMac.cpp:
(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/qt/NetworkStateNotifierQt.cpp:
(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/network/win/NetworkStateNotifierWin.cpp:
(WebCore::NetworkStateNotifier::addressChanged):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
Replace m_networkStateChangedFunction() with notifyNetworkStateChange().
- workers/Worker.cpp:
(WebCore::networkStateChanged):
Notify network state change by iterating all Workers.
(WebCore::Worker::Worker):
Initialize allWorkers and add networkStateChanged to
NetworkStateNotifier in first invocation. Add this Worker to
allWorkers.
(WebCore::Worker::~Worker):
Remove this Worker from allWorkers.
(WebCore::Worker::notifyNetworkStateChange):
- workers/Worker.h:
- workers/WorkerGlobalScope.h:
Add onoffline and ononline event handlers.
- workers/WorkerGlobalScope.idl:
Add onoffline and ononline event handlers
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::NotifyNetworkStateChangeTask::create):
(WebCore::NotifyNetworkStateChangeTask::NotifyNetworkStateChangeTask):
(WebCore::NotifyNetworkStateChangeTask::performTask):
A subclass of ScriptExecutionContext::Task to dispatch offline and
online events to WorkerGlobalScope.
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
Notify network state change using ScriptExecutionContext::postTask to
dispatch events across threads.
- workers/WorkerMessagingProxy.h:
- 8:58 PM Changeset in webkit [152884] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r152876.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):
- 8:34 PM Changeset in webkit [152883] by
-
- 2 edits in trunk/Source/WTF
Fix the build after r152881
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::lower):
- 8:30 PM Changeset in webkit [152882] by
-
- 2 edits in trunk/Source/JavaScriptCore
CodeBlock DFG entry list isn't getting shrunk-to-fit after linking.
<http://webkit.org/b/118875>
<rdar://problem/14488577>
Reviewed by Geoffrey Garen.
Move the CodeBlock::shrinkToFit() call out of JITCompiler::link() and to the call sites
so SpeculativeJIT::linkOSREntries() can fill in CodeBlock::m_dfgData->osrEntry first.
886 kB progression on <http://twitter.com/awesomekling>
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- 8:24 PM Changeset in webkit [152881] by
-
- 2 edits in trunk/Source/WTF
Little cleaning of StringImpl::lower() and StringImpl::upper() for ARM
https://bugs.webkit.org/show_bug.cgi?id=118831
Reviewed by Gavin Barraclough.
Clean lower() and upper() before trying some optimizations:
-Prefix the code with the empty() case. Otherwise, each descending loop starts with
a check for length == 0.
-Change ored to a 32 bits registers. ARM only has 32 bits registers and access to full word.
To keep the value a UChar, the compiler is adding a bunch of useless value & 0xffff in the loops.
-Change the pointer based loops for index based loops. The compiler does a mighty job at optimizing
those for each architecture. No need to make the code more complex.
-Don't perform the check for int32 unless we need to. The only code limited to int is Unicode::toLower.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::lower):
(WTF::StringImpl::upper):
- 8:04 PM Changeset in webkit [152880] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: AbstractInterpreter should explicitly ask AbstractState to create new AbstractValues for newly born nodes
https://bugs.webkit.org/show_bug.cgi?id=118880
Reviewed by Sam Weinig.
It should be possible to have an AbstractState that is backed by a HashMap. But to
do this, the AbstractInterpreter should explicitly ask for new nodes to be added to
the map, since otherwise the idiom of getting a reference to the AbstractValue
returned by forNode() would cause really subtle memory corruption bugs.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::::executeEffects):
- dfg/DFGInPlaceAbstractState.h:
(JSC::DFG::InPlaceAbstractState::createValueForNode):
(InPlaceAbstractState):
- 7:19 PM Changeset in webkit [152879] by
-
- 11 edits5 adds2 deletes in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Decouple the way that CFA stores its state from the way it does abstract interpretation
https://bugs.webkit.org/show_bug.cgi?id=118835
Reviewed by Oliver Hunt.
This separates AbstractState into two things:
- InPlaceAbstractState, which can tell you the abstract state of anything you might care about, and uses the old AbstractState's algorithms and data structures for doing so.
- AbstractInterpreter<AbstractStateType>, which can execute a DFG::Node* with respect to an AbstractStateType. Currently we always use AbstractStateType = InPlaceAbstractState. But we could drop in an other class that supports basic primitives like forNode() and variables().
This is important because:
- We want to hoist things out of loops.
- We don't know what things rely on what type checks.
- We only want to hoist type checks out of loops if they aren't clobbered.
- We may want to still hoist things that depended on those type checks, if it's safe to do those things based on the CFA state at the tail of the loop pre-header.
- We don't want things to rely on their type checks by way of a token, because that's just weird.
So, we want to be able to have a special form of the CFA that can
incrementally update a basic block's state-at-tail, and we want to be able to
do this for multiple blocks simultaneously. This requires *not* storing the
per-node state in the nodes themselves, but instead using the at-tail HashMap
directly.
Hence we need to have a way of making the abstract interpreter (i.e.
AbstractState::execute) polymorphic with respect to state representation. Put
another way, we need to separate the way that abstract state is represented
from the way DFG IR is abstractly interpreted.
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGAbstractInterpreter.h: Added.
(DFG):
(AbstractInterpreter):
(JSC::DFG::AbstractInterpreter::forNode):
(JSC::DFG::AbstractInterpreter::variables):
(JSC::DFG::AbstractInterpreter::needsTypeCheck):
(JSC::DFG::AbstractInterpreter::filterEdgeByUse):
(JSC::DFG::AbstractInterpreter::filter):
(JSC::DFG::AbstractInterpreter::filterArrayModes):
(JSC::DFG::AbstractInterpreter::filterByValue):
(JSC::DFG::AbstractInterpreter::trySetConstant):
(JSC::DFG::AbstractInterpreter::filterByType):
- dfg/DFGAbstractInterpreterInlines.h: Added.
(DFG):
(JSC::DFG::::AbstractInterpreter):
(JSC::DFG::::~AbstractInterpreter):
(JSC::DFG::::booleanResult):
(JSC::DFG::::startExecuting):
(JSC::DFG::::executeEdges):
(JSC::DFG::::verifyEdge):
(JSC::DFG::::verifyEdges):
(JSC::DFG::::executeEffects):
(JSC::DFG::::execute):
(JSC::DFG::::clobberWorld):
(JSC::DFG::::clobberCapturedVars):
(JSC::DFG::::clobberStructures):
(JSC::DFG::::dump):
(JSC::DFG::::filter):
(JSC::DFG::::filterArrayModes):
(JSC::DFG::::filterByValue):
- dfg/DFGAbstractState.cpp: Removed.
- dfg/DFGAbstractState.h: Removed.
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::CFAPhase):
(JSC::DFG::CFAPhase::performBlockCFA):
(CFAPhase):
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(ConstantFoldingPhase):
- dfg/DFGInPlaceAbstractState.cpp: Added.
(DFG):
(JSC::DFG::InPlaceAbstractState::InPlaceAbstractState):
(JSC::DFG::InPlaceAbstractState::~InPlaceAbstractState):
(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
(JSC::DFG::setLiveValues):
(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::reset):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail):
(JSC::DFG::InPlaceAbstractState::merge):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):
(JSC::DFG::InPlaceAbstractState::mergeVariableBetweenBlocks):
- dfg/DFGInPlaceAbstractState.h: Added.
(DFG):
(InPlaceAbstractState):
(JSC::DFG::InPlaceAbstractState::forNode):
(JSC::DFG::InPlaceAbstractState::variables):
(JSC::DFG::InPlaceAbstractState::block):
(JSC::DFG::InPlaceAbstractState::didClobber):
(JSC::DFG::InPlaceAbstractState::isValid):
(JSC::DFG::InPlaceAbstractState::setDidClobber):
(JSC::DFG::InPlaceAbstractState::setIsValid):
(JSC::DFG::InPlaceAbstractState::setBranchDirection):
(JSC::DFG::InPlaceAbstractState::setFoundConstants):
(JSC::DFG::InPlaceAbstractState::haveStructures):
(JSC::DFG::InPlaceAbstractState::setHaveStructures):
- dfg/DFGMergeMode.h: Added.
(DFG):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::backwardTypeCheck):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateStringIdentAndLoadStorage):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
- ftl/FTLLowerDFGToLLVM.cpp:
(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateNumber):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(LowerDFGToLLVM):
- 7:12 PM Changeset in webkit [152878] by
-
- 20 edits2 adds in trunk/Source/WebKit2
[WK2] Share Qt port's codes to find zoomable area with CoordinatedGraphics.
https://bugs.webkit.org/show_bug.cgi?id=118585
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-07-18
Reviewed by Anders Carlsson.
The function to find zoomable area is needed in order to implement the
feature to scale for double-tap gesture. The WK2 EFL and NIX port want
to use that function, so extract the code from the Qt port, make it
usable in the CoordinatedGraphics and add API and callback.
- CMakeLists.txt:
- Target.pri:
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewFindZoomableAreaForRect):
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::didFindZoomableArea):
- UIProcess/API/efl/EwkView.h:
- UIProcess/CoordinatedGraphics/WebPageProxyCoordinatedGraphics.cpp: Added.
(WebKit::WebPageProxy::findZoomableAreaForPoint):
(WebKit::WebPageProxy::didFindZoomableArea):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didFindZoomableArea):
(WebKit::WebView::findZoomableAreaForPoint):
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/CoordinatedGraphics/WebViewClient.cpp:
(WebKit::WebViewClient::didFindZoomableArea):
- UIProcess/CoordinatedGraphics/WebViewClient.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didFindZoomableArea):
(WebKit::ViewClientEfl::ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
- UIProcess/qt/WebPageProxyQt.cpp:
- WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp: Added.
(WebKit::WebPage::findZoomableAreaForPoint):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 6:32 PM Changeset in webkit [152877] by
-
- 2 edits in trunk/Source/WebKit2
Flash Player: deny file-read-data /Library/Application Support/Macromedia/FlashAuthor.cfg
https://bugs.webkit.org/show_bug.cgi?id=118874
<rdar://problem/14271327>
Patch by Simon Cooper <scooper@apple.com> on 2013-07-18
Reviewed by Alexey Proskuryakov.
Silently deny access to FlashAuthor.cfg. This location contains
files containing lists of paths that Flash Player will
"allow" access to (without asking the user). Since the plugin
sandbox won't permit the access to the listed paths it is better
to silently block attempts to read this "whitelist".
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- 6:08 PM Changeset in webkit [152876] by
-
- 7 edits in trunk/Source/WebCore
[Media] Share more code between Mac and Windows implementation files.
https://bugs.webkit.org/show_bug.cgi?id=118801
Reviewed by Eric Carlson.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::clearTextTracks): Move
implementation from ObjC file to parent file.
(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):
Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
Remove duplicate implementation.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
Ditto.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Ditto.
- 6:06 PM Changeset in webkit [152875] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed, rolling out r152801.
http://trac.webkit.org/changeset/152801
https://bugs.webkit.org/show_bug.cgi?id=118876
Un-rebaseline some plugin tests since r152789 was rolled out
(Requested by rfong on #webkit).
- platform/win/editing/pasteboard/paste-noplugin-expected.txt: Removed.
- platform/win/platform/win/plugins/draws-gradient-expected.txt:
- 5:35 PM Changeset in webkit [152874] by
-
- 4 edits in trunk
Make sure to link against _debug binaries when appropriate.
<rdar://problem/14473010>.
- win/tools/vsprops/debugsuffix.props:
- gtest/msvc/gtest-md.vcxproj:
- 4:58 PM Changeset in webkit [152873] by
-
- 2 edits in trunk/LayoutTests
Compositing pattern tests fail on Lion WK1 Debug.
https://bugs.webkit.org/show_bug.cgi?id=118870
Unreviewed.
Update Lion expectations after http://trac.webkit.org/changeset/152470
- platform/mac-lion/TestExpectations:
- 4:32 PM Changeset in webkit [152872] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG shouldn't create CheckStructures for array accesses except if the ArrayMode implies an original array access
https://bugs.webkit.org/show_bug.cgi?id=118867
Reviewed by Mark Hahnenberg.
This allows us to kill off a bunch of code in the parser, in fixup, and to simplify
ArrayProfile.
It also makes it easier to ask any array-using node how to create its type check.
Doing this required fixing a bug in LowLevelInterpreter64, where it was storing into
an array profile, thinking that it was storing into a value profile. Reshuffling the
fields in ArrayProfile revealed this.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::updateAllPredictions):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::updateAllArrayPredictions):
- dfg/DFGArrayMode.h:
(ArrayMode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getArrayModeConsideringSlowPath):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):
- llint/LowLevelInterpreter64.asm:
- 4:24 PM Changeset in webkit [152871] by
-
- 87 edits2 copies4 adds in trunk
Fixed ASSERTION FAILED: callFrame == vm->topCallFrame in JSC::Interpreter::addStackTraceIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=118498
Patch by Chris Curtis <chris_curtis@apple.com> on 2013-07-18
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- jit/JITStubs.cpp:
(throwExceptionFromOpCall):
Created new throwExceptionFromOpCall that takes in a functor that contains
a function pointer (to create the errorObject) instead of a JSValue. Inside
of throwExceptionFromOpCall the topCallFrame is being rolled back in order
to handle the error throw. By passing the function pointer in, we can defer
the creation of the error object until after topCallFrame has been rolled
back. This allows the error object to be created with the appropriate top
frame.
DEFINE_STUB_FUNCTION(void*, stack_check):
DEFINE_STUB_FUNCTION(void*, op_call_arityCheck):
DEFINE_STUB_FUNCTION(void*, op_construct_arityCheck):
DEFINE_STUB_FUNCTION(EncodedJSValue, op_call_NotJSFunction):
DEFINE_STUB_FUNCTION(EncodedJSValue, op_construct_NotJSConstruct):
(JSC::ErrorFunctor::~ErrorFunctor):
(JSC::ErrorWithExecFunctor::ErrorWithExecFunctor):
(JSC::ErrorWithExecFunctor::operator()):
(JSC::ErrorWithExecAndCalleeFunctor::ErrorWithExecAndCalleeFunctor):
(JSC::ErrorWithExecAndCalleeFunctor::operator()):
(JSC::ErrorWithExceptionFunctor::ErrorWithExceptionFunctor):
(JSC::ErrorWithExceptionFunctor::operator()):
(JSC::throwExceptionFromOpCall):
In order to eliminate the need to duplicate code, an error functor was
created for the 3 different throwExceptionFromOpCall handles.
- The exception needs to be created, and the function pointer takes 1
parameter(callFrame->callerFrame()).
- The exception needs to be created, and the function pointer takes 2
parameters (callFrame->callerFrame(), callFrame.calleeAsValue()).
- The exception is already created. In this case, At the time when
the error functor is called, vm.exception is returned.
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/ExceptionHelpers.cpp:
(JSC::errorDescriptionForValue):
(JSC::createError):
(JSC::createInvalidParameterError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
- runtime/ExceptionHelpers.h:
The function toString() was being used to stringify an object for an exception
message. If the user wrote a toString() for that object, then the system would
continue to evaluate that code. A new helper function was created to prevent
the system to continue execution and exception creation from that execution.
LayoutTests:
New Tests to see if JSC evaluates user code after exception creation
- fast/js/not-a-constructor-to-string-expected.txt: Added.
- fast/js/not-a-constructor-to-string.html: Added.
- fast/js/not-a-function-to-string-expected.txt: Added.
- fast/js/not-a-function-to-string.html: Added.
Modified test output of the object that was being evaluated at the time of the
error. Only the error message has changed.
- fast/dom/MutationObserver/mutation-record-constructor-expected.txt:
- fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
- fast/dom/Range/getClientRects-expected.txt:
- fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
- fast/dom/SelectorAPI/dumpNodeList-expected.txt:
- fast/dom/call-a-constructor-as-a-function-expected.txt:
- fast/dom/setPrimitiveValue-exceptions-expected.txt:
- fast/events/window-onerror-exception-in-attr-expected.txt:
- fast/forms/select-namedItem-expected.txt:
- fast/js/arguments-expected.txt:
- fast/js/array-prototype-properties-expected.txt:
- fast/js/basic-strict-mode-expected.txt:
- fast/js/date-toisostring-expected.txt:
- fast/js/delete-getters-setters-expected.txt:
- fast/js/dfg-check-structure-elimination-for-non-cell-expected.txt:
- fast/js/dfg-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt:
- fast/js/dfg-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt:
- fast/js/dfg-inline-arguments-use-from-all-the-places-broken-expected.txt:
- fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-when-both-proven-final-object-expected.txt:
- fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-when-proven-final-object-expected.txt:
- fast/js/exception-expression-offset-expected.txt:
- fast/js/exception-for-nonobject-expected.txt:
- fast/js/exception-thrown-from-new-expected.txt:
- fast/js/function-bind-expected.txt:
- fast/js/instance-of-immediates-expected.txt:
- fast/js/object-prototype-properties-expected.txt:
- fast/regex/cross-frame-callable-expected.txt:
- fast/xsl/transform-xhr-doc-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
- http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
- http/tests/security/document-all-expected.txt:
- http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:
- http/tests/security/window-named-proto-expected.txt:
- inspector/console/console-exception-stack-traces-expected.txt:
- platform/efl/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/efl/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/efl/fast/events/updateLayoutForHitTest-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/gtk/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/gtk/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/gtk/fast/events/updateLayoutForHitTest-expected.txt:
- platform/gtk/svg/custom/createelement-expected.txt:
- platform/gtk/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/mac-wk2/editing/spelling/markers-expected.txt:
- platform/mac-wk2/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added.
- platform/mac-wk2/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
- platform/mac/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/mac/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
- platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.txt:
- platform/qt/svg/custom/createelement-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
- platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:
- plugins/npruntime/object-from-destroyed-plugin-expected.txt:
- plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt:
- plugins/npruntime/plugin-scriptable-object-invoke-default-expected.txt:
- sputnik/Conformance/08_Types/8.6_The_Object_Type/8.6.2_Internal_Properties_and_Methods/S8.6.2_A7-expected.txt:
- sputnik/Conformance/13_Function_Definition/S13_A17_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T1-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A1_T2-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/S15.1_A2_T1-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.2_Object.prototype.toString/S15.2.4.2_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.3_Object.prototype.toLocaleString/S15.2.4.3_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.4_Object.prototype.valueOf/S15.2.4.4_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.5_Object.prototype.hasOwnProperty/S15.2.4.5_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.6_Object.prototype.isPrototypeOf/S15.2.4.6_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/15.2.4.7_Object.prototype.propertyIsEnumerable/S15.2.4.7_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A3-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.2_Object/15.2.4/S15.2.4_A4-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/15.3.4.2_Function.prototype.toString/S15.3.4.2_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.3_Function/15.3.4/S15.3.4_A5-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.12_String.prototype.search/S15.5.4.12_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.13_String.prototype.slice/S15.5.4.13_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.15_String.prototype.substring/S15.5.4.15_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.17_String.prototype.toLocaleLowerCase/S15.5.4.17_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.7_String.prototype.indexOf/S15.5.4.7_A7-expected.txt:
- sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/15.5.4.8_String.prototype.lastIndexOf/S15.5.4.8_A7-expected.txt:
- svg/custom/createelement-expected.txt:
- svg/custom/use-nested-missing-target-removed-expected.txt:
- svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
- 3:17 PM Changeset in webkit [152870] by
-
- 3 edits1 add in trunk/Tools
Add extract-localizable-js-strings and use it for WebInspectorUI.
https://bugs.webkit.org/show_bug.cgi?id=118851
Reviewed by Joseph Pecoraro.
- Scripts/extract-localizable-js-strings: Added.
- Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
- Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
the WebInspectorUI project.
- 3:12 PM Changeset in webkit [152869] by
-
- 2 edits in trunk/Source/WebCore
Fixed compile errors for non-Cairo platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118536
Reviewed by Brent Fulgham.
- platform/graphics/egl/GLContextEGL.cpp: Added #if USE(CAIRO) around cairo.h.
(WebCore::GLContextEGL::~GLContextEGL): Added #if USE(CAIRO) around cairo_device_destroy call.
- 3:06 PM Changeset in webkit [152868] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLInt get_argument_by_val for JSVALUE64 stores into the array profile when it meant to store into the value profile
https://bugs.webkit.org/show_bug.cgi?id=118865
Reviewed by Mark Hahnenberg.
- llint/LowLevelInterpreter64.asm:
- 3:00 PM Changeset in webkit [152867] by
-
- 2 edits in trunk/Source/WebCore
New PDFPlugin doesn't support WebKitOmitPDFSupport, acts as if Plug-ins are off
https://bugs.webkit.org/show_bug.cgi?id=118858
Reviewed by Eric Carlson.
Expand the scope of rejecting non video/ or audio/ MIME types when
filling the MIME type cache.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::shouldRejectMIMEType): Added utility function.
- 2:58 PM Changeset in webkit [152866] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Ensure that the plugin layer is removed completely when the PluginProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=118862
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
Add m_pluginProcessHasCrashed.
(WebKit::PluginView::platformLayer):
Don't return the plugin's layer if it has crashed.
(WebKit::PluginView::pluginProcessCrashed):
Set m_pluginProcessHasCrashed.
Cause a style recalc so that we rebuild the layer tree; our layer won't be included.
- WebProcess/Plugins/PluginView.h:
Add m_pluginProcessHasCrashed.
- 2:47 PM Changeset in webkit [152865] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build correction.
- 2:14 PM Changeset in webkit [152864] by
-
- 2 edits in trunk/Tools
Unreviewed windows build fix.
- 2:12 PM Changeset in webkit [152863] by
-
- 1 edit74 adds2 deletes in trunk/Source/ThirdParty/ANGLE
Added previously unincluded files from ANGLE r2426 with these exceptions:
No gyp files are included. No WebKit ports use them.
ANGLE.sln is not included. I will not use that.
translator_common and translator_hlsl projects and filters are not included.
I will need to make a customized translator project that uses the GLSL translator instead of the HLSL.
https://bugs.webkit.org/show_bug.cgi?id=118833
Reviewed by Dean Jackson.
- src/compiler/builtin_symbols.json: Added.
- src/compiler/generate_builtin_symbol_table.py: Added.
(parseBuiltin):
- src/libEGL: Replaced.
- src/libEGL/Config.cpp: Added.
(egl::Config::Config):
(egl::Config::setDefaults):
(egl::Config::set):
(egl::Config::getHandle):
(egl::SortConfig::SortConfig):
(egl::SortConfig::scanForWantedComponents):
(egl::SortConfig::wantedComponentsSize):
(egl::SortConfig::operator()):
(egl::ConfigSet::ConfigSet):
(egl::ConfigSet::add):
(egl::ConfigSet::size):
(egl::ConfigSet::getConfigs):
(egl::ConfigSet::get):
- src/libEGL/Config.h: Added.
- src/libEGL/Display.cpp: Added.
(egl::Display::getDisplay):
(egl::Display::Display):
(egl::Display::~Display):
(egl::Display::initialize):
(egl::Display::terminate):
(egl::Display::startScene):
(egl::Display::endScene):
(egl::Display::getConfigs):
(egl::Display::getConfigAttrib):
(egl::Display::createDevice):
(egl::Display::initializeDevice):
(egl::Display::resetDevice):
(egl::Display::createWindowSurface):
(egl::Display::createOffscreenSurface):
(egl::Display::createContext):
(egl::Display::restoreLostDevice):
(egl::Display::destroySurface):
(egl::Display::destroyContext):
(egl::Display::notifyDeviceLost):
(egl::Display::isDeviceLost):
(egl::Display::isInitialized):
(egl::Display::isValidConfig):
(egl::Display::isValidContext):
(egl::Display::isValidSurface):
(egl::Display::hasExistingWindowSurface):
(egl::Display::getMinSwapInterval):
(egl::Display::getMaxSwapInterval):
(egl::Display::getDevice):
(egl::Display::getDeviceCaps):
(egl::Display::getAdapterIdentifier):
(egl::Display::testDeviceLost):
(egl::Display::testDeviceResettable):
(egl::Display::sync):
(egl::Display::allocateEventQuery):
(egl::Display::freeEventQuery):
(egl::Display::getMultiSampleSupport):
(egl::Display::getDXT1TextureSupport):
(egl::Display::getDXT3TextureSupport):
(egl::Display::getDXT5TextureSupport):
(egl::Display::getDepthTextureSupport):
(egl::Display::getFloat32TextureSupport):
(egl::Display::getFloat16TextureSupport):
(egl::Display::getLuminanceTextureSupport):
(egl::Display::getLuminanceAlphaTextureSupport):
(egl::Display::getTextureFilterAnisotropySupport):
(egl::Display::getBufferPool):
(egl::Display::getTexturePool):
(egl::Display::getEventQuerySupport):
(egl::Display::getDefaultPresentParameters):
(egl::Display::initExtensionString):
(egl::Display::getExtensionString):
(egl::Display::initVendorString):
(egl::Display::getVendorString):
(egl::Display::shareHandleSupported):
(egl::Display::createVertexShader):
(egl::Display::compileShaderSource):
(egl::Display::createPixelShader):
(egl::Display::getVertexTextureSupport):
(egl::Display::getNonPower2TextureSupport):
(egl::Display::getOcclusionQuerySupport):
(egl::Display::getInstancingSupport):
- src/libEGL/Display.h: Added.
(getComparableOSVersion):
(egl::Display::isD3d9ExDevice):
- src/libEGL/README: Removed.
- src/libEGL/ShaderCache.h: Added.
(egl::ShaderCache::ShaderCache):
(egl::ShaderCache::~ShaderCache):
(egl::ShaderCache::initialize):
(egl::ShaderCache::create):
(egl::ShaderCache::clear):
(egl::ShaderCache::createShader):
- src/libEGL/Surface.cpp: Added.
(egl::Surface::Surface):
(egl::Surface::~Surface):
(egl::Surface::initialize):
(egl::Surface::release):
(egl::Surface::resetSwapChain):
(egl::Surface::swapRect):
(egl::Surface::getWindowHandle):
(egl::SurfaceWindowProc):
(egl::Surface::subclassWindow):
(egl::Surface::unsubclassWindow):
(egl::Surface::checkForOutOfDateSwapChain):
(egl::Surface::convertInterval):
(egl::Surface::swap):
(egl::Surface::postSubBuffer):
(egl::Surface::getWidth):
(egl::Surface::getHeight):
(egl::Surface::isPostSubBufferSupported):
(egl::Surface::getRenderTarget):
(egl::Surface::getDepthStencil):
(egl::Surface::getOffscreenTexture):
(egl::Surface::setSwapInterval):
(egl::Surface::getTextureFormat):
(egl::Surface::getTextureTarget):
(egl::Surface::setBoundTexture):
(egl::Surface::getBoundTexture):
(egl::Surface::getFormat):
- src/libEGL/Surface.h: Added.
(egl::Surface::getShareHandle):
- src/libEGL/libEGL.cpp: Added.
(validateDisplay):
(validateConfig):
(validateContext):
(validateSurface):
- src/libEGL/libEGL.def: Added.
- src/libEGL/libEGL.rc: Added.
- src/libEGL/libEGL.vcxproj: Added.
- src/libEGL/libEGL.vcxproj.filters: Added.
- src/libEGL/main.cpp: Added.
(DllMain):
(egl::setCurrentError):
(egl::getCurrentError):
(egl::setCurrentAPI):
(egl::getCurrentAPI):
(egl::setCurrentDisplay):
(egl::getCurrentDisplay):
(egl::setCurrentDrawSurface):
(egl::getCurrentDrawSurface):
(egl::setCurrentReadSurface):
(egl::getCurrentReadSurface):
(error):
- src/libEGL/main.h: Added.
(error):
(success):
- src/libEGL/resource.h: Added.
- src/libGLESv2: Replaced.
- src/libGLESv2/BinaryStream.h: Added.
(gl::BinaryInputStream::BinaryInputStream):
(gl::BinaryInputStream::read):
(gl::BinaryInputStream::skip):
(gl::BinaryInputStream::offset):
(gl::BinaryInputStream::error):
(gl::BinaryInputStream::endOfStream):
(gl::BinaryOutputStream::BinaryOutputStream):
(gl::BinaryOutputStream::write):
(gl::BinaryOutputStream::length):
(gl::BinaryOutputStream::data):
- src/libGLESv2/Blit.cpp: Added.
(gl::Blit::Blit):
(gl::Blit::~Blit):
(gl::Blit::initGeometry):
(gl::Blit::setShader):
(gl::Blit::setVertexShader):
(gl::Blit::setPixelShader):
(gl::Blit::getSurfaceRect):
(gl::Blit::boxFilter):
(gl::Blit::copy):
(gl::Blit::formatConvert):
(gl::Blit::setFormatConvertShaders):
(gl::Blit::copySurfaceToTexture):
(gl::Blit::setViewport):
(gl::Blit::setCommonBlitState):
(gl::Blit::render):
(gl::Blit::saveState):
(gl::Blit::restoreState):
- src/libGLESv2/Blit.h: Added.
- src/libGLESv2/Buffer.cpp: Added.
(gl::Buffer::Buffer):
(gl::Buffer::~Buffer):
(gl::Buffer::bufferData):
(gl::Buffer::bufferSubData):
(gl::Buffer::getStaticVertexBuffer):
(gl::Buffer::getStaticIndexBuffer):
(gl::Buffer::invalidateStaticData):
(gl::Buffer::promoteStaticUsage):
- src/libGLESv2/Buffer.h: Added.
(gl::Buffer::data):
(gl::Buffer::size):
(gl::Buffer::usage):
- src/libGLESv2/Context.cpp: Added.
(gl::makeStaticString):
(gl::Context::Context):
(gl::Context::~Context):
(gl::Context::makeCurrent):
(gl::Context::markAllStateDirty):
(gl::Context::markDxUniformsDirty):
(gl::Context::markContextLost):
(gl::Context::isContextLost):
(gl::Context::setClearColor):
(gl::Context::setClearDepth):
(gl::Context::setClearStencil):
(gl::Context::setCullFace):
(gl::Context::isCullFaceEnabled):
(gl::Context::setCullMode):
(gl::Context::setFrontFace):
(gl::Context::setDepthTest):
(gl::Context::isDepthTestEnabled):
(gl::Context::setDepthFunc):
(gl::Context::setDepthRange):
(gl::Context::setBlend):
(gl::Context::isBlendEnabled):
(gl::Context::setBlendFactors):
(gl::Context::setBlendColor):
(gl::Context::setBlendEquation):
(gl::Context::setStencilTest):
(gl::Context::isStencilTestEnabled):
(gl::Context::setStencilParams):
(gl::Context::setStencilBackParams):
(gl::Context::setStencilWritemask):
(gl::Context::setStencilBackWritemask):
(gl::Context::setStencilOperations):
(gl::Context::setStencilBackOperations):
(gl::Context::setPolygonOffsetFill):
(gl::Context::isPolygonOffsetFillEnabled):
(gl::Context::setPolygonOffsetParams):
(gl::Context::setSampleAlphaToCoverage):
(gl::Context::isSampleAlphaToCoverageEnabled):
(gl::Context::setSampleCoverage):
(gl::Context::isSampleCoverageEnabled):
(gl::Context::setSampleCoverageParams):
(gl::Context::setScissorTest):
(gl::Context::isScissorTestEnabled):
(gl::Context::setDither):
(gl::Context::isDitherEnabled):
(gl::Context::setLineWidth):
(gl::Context::setGenerateMipmapHint):
(gl::Context::setFragmentShaderDerivativeHint):
(gl::Context::setViewportParams):
(gl::Context::setScissorParams):
(gl::Context::setColorMask):
(gl::Context::setDepthMask):
(gl::Context::setActiveSampler):
(gl::Context::getReadFramebufferHandle):
(gl::Context::getDrawFramebufferHandle):
(gl::Context::getRenderbufferHandle):
(gl::Context::getArrayBufferHandle):
(gl::Context::getActiveQuery):
(gl::Context::setEnableVertexAttribArray):
(gl::Context::getVertexAttribState):
(gl::Context::setVertexAttribState):
(gl::Context::getVertexAttribPointer):
(gl::Context::getVertexAttributes):
(gl::Context::setPackAlignment):
(gl::Context::getPackAlignment):
(gl::Context::setUnpackAlignment):
(gl::Context::getUnpackAlignment):
(gl::Context::setPackReverseRowOrder):
(gl::Context::getPackReverseRowOrder):
(gl::Context::createBuffer):
(gl::Context::createProgram):
(gl::Context::createShader):
(gl::Context::createTexture):
(gl::Context::createRenderbuffer):
(gl::Context::createFramebuffer):
(gl::Context::createFence):
(gl::Context::createQuery):
(gl::Context::deleteBuffer):
(gl::Context::deleteShader):
(gl::Context::deleteProgram):
(gl::Context::deleteTexture):
(gl::Context::deleteRenderbuffer):
(gl::Context::deleteFramebuffer):
(gl::Context::deleteFence):
(gl::Context::deleteQuery):
(gl::Context::getBuffer):
(gl::Context::getShader):
(gl::Context::getProgram):
(gl::Context::getTexture):
(gl::Context::getRenderbuffer):
(gl::Context::getReadFramebuffer):
(gl::Context::getDrawFramebuffer):
(gl::Context::bindArrayBuffer):
(gl::Context::bindElementArrayBuffer):
(gl::Context::bindTexture2D):
(gl::Context::bindTextureCubeMap):
(gl::Context::bindReadFramebuffer):
(gl::Context::bindDrawFramebuffer):
(gl::Context::bindRenderbuffer):
(gl::Context::useProgram):
(gl::Context::linkProgram):
(gl::Context::setProgramBinary):
(gl::Context::beginQuery):
(gl::Context::endQuery):
(gl::Context::setFramebufferZero):
(gl::Context::setRenderbufferStorage):
(gl::Context::getFramebuffer):
(gl::Context::getFence):
(gl::Context::getQuery):
(gl::Context::getArrayBuffer):
(gl::Context::getElementArrayBuffer):
(gl::Context::getCurrentProgramBinary):
(gl::Context::getTexture2D):
(gl::Context::getTextureCubeMap):
(gl::Context::getSamplerTexture):
(gl::Context::getBooleanv):
(gl::Context::getFloatv):
(gl::Context::getIntegerv):
(gl::Context::getQueryParameterInfo):
(gl::Context::applyRenderTarget):
(gl::Context::applyState):
(gl::Context::applyVertexBuffer):
(gl::Context::applyIndexBuffer):
(gl::Context::applyShaders):
(gl::Context::applyTextures):
(gl::Context::readPixels):
(gl::Context::clear):
(gl::Context::drawArrays):
(gl::Context::drawElements):
(gl::Context::sync):
(gl::Context::drawLineLoop):
(gl::Context::recordInvalidEnum):
(gl::Context::recordInvalidValue):
(gl::Context::recordInvalidOperation):
(gl::Context::recordOutOfMemory):
(gl::Context::recordInvalidFramebufferOperation):
(gl::Context::getError):
(gl::Context::getResetStatus):
(gl::Context::isResetNotificationEnabled):
(gl::Context::supportsShaderModel3):
(gl::Context::getMaximumPointSize):
(gl::Context::getMaximumVaryingVectors):
(gl::Context::getMaximumVertexTextureImageUnits):
(gl::Context::getMaximumCombinedTextureImageUnits):
(gl::Context::getMaximumFragmentUniformVectors):
(gl::Context::getMaxSupportedSamples):
(gl::Context::getNearestSupportedSamples):
(gl::Context::supportsEventQueries):
(gl::Context::supportsOcclusionQueries):
(gl::Context::supportsDXT1Textures):
(gl::Context::supportsDXT3Textures):
(gl::Context::supportsDXT5Textures):
(gl::Context::supportsFloat32Textures):
(gl::Context::supportsFloat32LinearFilter):
(gl::Context::supportsFloat32RenderableTextures):
(gl::Context::supportsFloat16Textures):
(gl::Context::supportsFloat16LinearFilter):
(gl::Context::supportsFloat16RenderableTextures):
(gl::Context::getMaximumRenderbufferDimension):
(gl::Context::getMaximumTextureDimension):
(gl::Context::getMaximumCubeTextureDimension):
(gl::Context::getMaximumTextureLevel):
(gl::Context::supportsLuminanceTextures):
(gl::Context::supportsLuminanceAlphaTextures):
(gl::Context::supportsDepthTextures):
(gl::Context::supports32bitIndices):
(gl::Context::supportsNonPower2Texture):
(gl::Context::supportsInstancing):
(gl::Context::supportsTextureFilterAnisotropy):
(gl::Context::supportsDerivativeInstructions):
(gl::Context::getTextureMaxAnisotropy):
(gl::Context::getCurrentReadFormatType):
(gl::Context::detachBuffer):
(gl::Context::detachTexture):
(gl::Context::detachFramebuffer):
(gl::Context::detachRenderbuffer):
(gl::Context::getIncompleteTexture):
(gl::Context::skipDraw):
(gl::Context::isTriangleMode):
(gl::Context::setVertexAttrib):
(gl::Context::setVertexAttribDivisor):
(gl::Context::initExtensionString):
(gl::Context::getExtensionString):
(gl::Context::initRendererString):
(gl::Context::getRendererString):
(gl::Context::blitFramebuffer):
(gl::VertexDeclarationCache::VertexDeclarationCache):
(gl::VertexDeclarationCache::~VertexDeclarationCache):
(gl::VertexDeclarationCache::applyDeclaration):
(gl::VertexDeclarationCache::markStateDirty):
- src/libGLESv2/Context.h: Added.
(gl::VertexAttribute::VertexAttribute):
(gl::VertexAttribute::typeSize):
(gl::VertexAttribute::stride):
(gl::Context::getBlitter):
(gl::Context::getDeviceCaps):
- src/libGLESv2/D3DConstantTable.cpp: Added.
(gl::D3DConstant::D3DConstant):
(gl::D3DConstant::~D3DConstant):
(gl::D3DConstant::addStructMembers):
(gl::D3DConstantTable::D3DConstantTable):
(gl::D3DConstantTable::~D3DConstantTable):
(gl::D3DConstantTable::getConstant):
(gl::D3DConstantTable::getConstantByName):
- src/libGLESv2/D3DConstantTable.h: Added.
(gl::D3DConstantTable::error):
(gl::D3DConstantTable::constants):
- src/libGLESv2/Fence.cpp: Added.
(gl::Fence::Fence):
(gl::Fence::~Fence):
(gl::Fence::isFence):
(gl::Fence::setFence):
(gl::Fence::testFence):
(gl::Fence::finishFence):
(gl::Fence::getFenceiv):
- src/libGLESv2/Fence.h: Added.
- src/libGLESv2/Float16ToFloat32.cpp: Added.
(gl::float16ToFloat32):
- src/libGLESv2/Float16ToFloat32.py: Added.
(convertMantissa):
(convertExponent):
(convertOffset):
- src/libGLESv2/Framebuffer.cpp: Added.
(gl::Framebuffer::Framebuffer):
(gl::Framebuffer::~Framebuffer):
(gl::Framebuffer::lookupRenderbuffer):
(gl::Framebuffer::setColorbuffer):
(gl::Framebuffer::setDepthbuffer):
(gl::Framebuffer::setStencilbuffer):
(gl::Framebuffer::detachTexture):
(gl::Framebuffer::detachRenderbuffer):
(gl::Framebuffer::getRenderTargetSerial):
(gl::Framebuffer::getRenderTarget):
(gl::Framebuffer::getDepthStencil):
(gl::Framebuffer::getDepthbufferSerial):
(gl::Framebuffer::getStencilbufferSerial):
(gl::Framebuffer::getColorbuffer):
(gl::Framebuffer::getDepthbuffer):
(gl::Framebuffer::getStencilbuffer):
(gl::Framebuffer::getNullColorbuffer):
(gl::Framebuffer::getColorbufferType):
(gl::Framebuffer::getDepthbufferType):
(gl::Framebuffer::getStencilbufferType):
(gl::Framebuffer::getColorbufferHandle):
(gl::Framebuffer::getDepthbufferHandle):
(gl::Framebuffer::getStencilbufferHandle):
(gl::Framebuffer::hasStencil):
(gl::Framebuffer::completeness):
(gl::DefaultFramebuffer::DefaultFramebuffer):
(gl::Framebuffer::getSamples):
(gl::DefaultFramebuffer::completeness):
- src/libGLESv2/Framebuffer.h: Added.
- src/libGLESv2/HandleAllocator.cpp: Added.
(gl::HandleAllocator::HandleAllocator):
(gl::HandleAllocator::~HandleAllocator):
(gl::HandleAllocator::setBaseHandle):
(gl::HandleAllocator::allocate):
(gl::HandleAllocator::release):
- src/libGLESv2/HandleAllocator.h: Added.
- src/libGLESv2/IndexDataManager.cpp: Added.
(gl::IndexDataManager::IndexDataManager):
(gl::IndexDataManager::~IndexDataManager):
(gl::convertIndices):
(gl::computeRange):
(gl::IndexDataManager::prepareIndexData):
(gl::IndexDataManager::indexSize):
(gl::IndexDataManager::typeSize):
(gl::IndexDataManager::getCountingIndices):
(gl::IndexBuffer::IndexBuffer):
(gl::IndexBuffer::~IndexBuffer):
(gl::IndexBuffer::getBuffer):
(gl::IndexBuffer::getSerial):
(gl::IndexBuffer::issueSerial):
(gl::IndexBuffer::unmap):
(gl::StreamingIndexBuffer::StreamingIndexBuffer):
(gl::StreamingIndexBuffer::~StreamingIndexBuffer):
(gl::StreamingIndexBuffer::map):
(gl::StreamingIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::StaticIndexBuffer):
(gl::StaticIndexBuffer::~StaticIndexBuffer):
(gl::StaticIndexBuffer::map):
(gl::StaticIndexBuffer::reserveSpace):
(gl::StaticIndexBuffer::lookupType):
(gl::StaticIndexBuffer::lookupRange):
(gl::StaticIndexBuffer::addRange):
- src/libGLESv2/IndexDataManager.h: Added.
(gl::IndexBuffer::size):
(gl::StaticIndexBuffer::IndexRange::operator<):
- src/libGLESv2/Program.cpp: Added.
(gl::AttributeBindings::AttributeBindings):
(gl::AttributeBindings::~AttributeBindings):
(gl::InfoLog::InfoLog):
(gl::InfoLog::~InfoLog):
(gl::InfoLog::getLength):
(gl::InfoLog::getLog):
(gl::InfoLog::appendSanitized):
(gl::InfoLog::append):
(gl::InfoLog::reset):
(gl::Program::Program):
(gl::Program::~Program):
(gl::Program::attachShader):
(gl::Program::detachShader):
(gl::Program::getAttachedShadersCount):
(gl::AttributeBindings::bindAttributeLocation):
(gl::Program::bindAttributeLocation):
(gl::Program::link):
(gl::AttributeBindings::getAttributeBinding):
(gl::Program::unlink):
(gl::Program::isLinked):
(gl::Program::getProgramBinary):
(gl::Program::setProgramBinary):
(gl::Program::release):
(gl::Program::addRef):
(gl::Program::getRefCount):
(gl::Program::getProgramBinaryLength):
(gl::Program::getInfoLogLength):
(gl::Program::getInfoLog):
(gl::Program::getAttachedShaders):
(gl::Program::getActiveAttribute):
(gl::Program::getActiveAttributeCount):
(gl::Program::getActiveAttributeMaxLength):
(gl::Program::getActiveUniform):
(gl::Program::getActiveUniformCount):
(gl::Program::getActiveUniformMaxLength):
(gl::Program::flagForDeletion):
(gl::Program::isFlaggedForDeletion):
(gl::Program::validate):
(gl::Program::isValidated):
- src/libGLESv2/Program.h: Added.
- src/libGLESv2/ProgramBinary.cpp: Added.
(gl::str):
(gl::Uniform::Uniform):
(gl::Uniform::~Uniform):
(gl::Uniform::isArray):
(gl::UniformLocation::UniformLocation):
(gl::ProgramBinary::ProgramBinary):
(gl::ProgramBinary::~ProgramBinary):
(gl::ProgramBinary::getSerial):
(gl::ProgramBinary::issueSerial):
(gl::ProgramBinary::getPixelShader):
(gl::ProgramBinary::getVertexShader):
(gl::ProgramBinary::getAttributeLocation):
(gl::ProgramBinary::getSemanticIndex):
(gl::ProgramBinary::getUsedSamplerRange):
(gl::ProgramBinary::usesPointSize):
(gl::ProgramBinary::getSamplerMapping):
(gl::ProgramBinary::getSamplerTextureType):
(gl::ProgramBinary::getUniformLocation):
(gl::ProgramBinary::setUniform1fv):
(gl::ProgramBinary::setUniform2fv):
(gl::ProgramBinary::setUniform3fv):
(gl::ProgramBinary::setUniform4fv):
(gl::transposeMatrix):
(gl::ProgramBinary::setUniformMatrix2fv):
(gl::ProgramBinary::setUniformMatrix3fv):
(gl::ProgramBinary::setUniformMatrix4fv):
(gl::ProgramBinary::setUniform1iv):
(gl::ProgramBinary::setUniform2iv):
(gl::ProgramBinary::setUniform3iv):
(gl::ProgramBinary::setUniform4iv):
(gl::ProgramBinary::getUniformfv):
(gl::ProgramBinary::getUniformiv):
(gl::ProgramBinary::dirtyAllUniforms):
(gl::ProgramBinary::applyUniforms):
(gl::ProgramBinary::compileToBinary):
(gl::ProgramBinary::packVaryings):
(gl::ProgramBinary::linkVaryings):
(gl::ProgramBinary::load):
(gl::ProgramBinary::save):
(gl::ProgramBinary::getLength):
(gl::ProgramBinary::link):
(gl::ProgramBinary::linkAttributes):
(gl::ProgramBinary::linkUniforms):
(gl::ProgramBinary::defineUniform):
(gl::ProgramBinary::createUniform):
(gl::ProgramBinary::decorateAttribute):
(gl::ProgramBinary::undecorateUniform):
(gl::ProgramBinary::applyUniformnbv):
(gl::ProgramBinary::applyUniformnfv):
(gl::ProgramBinary::applyUniform1iv):
(gl::ProgramBinary::applyUniform2iv):
(gl::ProgramBinary::applyUniform3iv):
(gl::ProgramBinary::applyUniform4iv):
(gl::ProgramBinary::applyUniformniv):
(gl::ProgramBinary::isValidated):
(gl::ProgramBinary::getActiveAttribute):
(gl::ProgramBinary::getActiveAttributeCount):
(gl::ProgramBinary::getActiveAttributeMaxLength):
(gl::ProgramBinary::getActiveUniform):
(gl::ProgramBinary::getActiveUniformCount):
(gl::ProgramBinary::getActiveUniformMaxLength):
(gl::ProgramBinary::validate):
(gl::ProgramBinary::validateSamplers):
(gl::ProgramBinary::getDxDepthRangeLocation):
(gl::ProgramBinary::getDxDepthLocation):
(gl::ProgramBinary::getDxCoordLocation):
(gl::ProgramBinary::getDxHalfPixelSizeLocation):
(gl::ProgramBinary::getDxFrontCCWLocation):
(gl::ProgramBinary::getDxPointsOrLinesLocation):
(gl::ProgramBinary::Sampler::Sampler):
- src/libGLESv2/ProgramBinary.h: Added.
(gl::Uniform::RegisterInfo::RegisterInfo):
(gl::Uniform::RegisterInfo::set):
(gl::UniformLocation::UniformLocation):
- src/libGLESv2/Query.cpp: Added.
(gl::Query::Query):
(gl::Query::~Query):
(gl::Query::begin):
(gl::Query::end):
(gl::Query::getResult):
(gl::Query::isResultAvailable):
(gl::Query::getType):
(gl::Query::testQuery):
- src/libGLESv2/Query.h: Added.
- src/libGLESv2/README: Removed.
- src/libGLESv2/Renderbuffer.cpp: Added.
(gl::RenderbufferInterface::RenderbufferInterface):
(gl::RenderbufferInterface::addProxyRef):
(gl::RenderbufferInterface::releaseProxy):
(gl::RenderbufferInterface::getRedSize):
(gl::RenderbufferInterface::getGreenSize):
(gl::RenderbufferInterface::getBlueSize):
(gl::RenderbufferInterface::getAlphaSize):
(gl::RenderbufferInterface::getDepthSize):
(gl::RenderbufferInterface::getStencilSize):
(gl::RenderbufferTexture2D::RenderbufferTexture2D):
(gl::RenderbufferTexture2D::~RenderbufferTexture2D):
(gl::RenderbufferTexture2D::addProxyRef):
(gl::RenderbufferTexture2D::releaseProxy):
(gl::RenderbufferTexture2D::getRenderTarget):
(gl::RenderbufferTexture2D::getDepthStencil):
(gl::RenderbufferTexture2D::getWidth):
(gl::RenderbufferTexture2D::getHeight):
(gl::RenderbufferTexture2D::getInternalFormat):
(gl::RenderbufferTexture2D::getD3DFormat):
(gl::RenderbufferTexture2D::getSamples):
(gl::RenderbufferTexture2D::getSerial):
(gl::RenderbufferTextureCubeMap::RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::~RenderbufferTextureCubeMap):
(gl::RenderbufferTextureCubeMap::addProxyRef):
(gl::RenderbufferTextureCubeMap::releaseProxy):
(gl::RenderbufferTextureCubeMap::getRenderTarget):
(gl::RenderbufferTextureCubeMap::getDepthStencil):
(gl::RenderbufferTextureCubeMap::getWidth):
(gl::RenderbufferTextureCubeMap::getHeight):
(gl::RenderbufferTextureCubeMap::getInternalFormat):
(gl::RenderbufferTextureCubeMap::getD3DFormat):
(gl::RenderbufferTextureCubeMap::getSamples):
(gl::RenderbufferTextureCubeMap::getSerial):
(gl::Renderbuffer::Renderbuffer):
(gl::Renderbuffer::~Renderbuffer):
(gl::Renderbuffer::addRef):
(gl::Renderbuffer::release):
(gl::Renderbuffer::getRenderTarget):
(gl::Renderbuffer::getDepthStencil):
(gl::Renderbuffer::getWidth):
(gl::Renderbuffer::getHeight):
(gl::Renderbuffer::getInternalFormat):
(gl::Renderbuffer::getD3DFormat):
(gl::Renderbuffer::getRedSize):
(gl::Renderbuffer::getGreenSize):
(gl::Renderbuffer::getBlueSize):
(gl::Renderbuffer::getAlphaSize):
(gl::Renderbuffer::getDepthSize):
(gl::Renderbuffer::getStencilSize):
(gl::Renderbuffer::getSamples):
(gl::Renderbuffer::getSerial):
(gl::Renderbuffer::setStorage):
(gl::RenderbufferStorage::RenderbufferStorage):
(gl::RenderbufferStorage::~RenderbufferStorage):
(gl::RenderbufferStorage::getRenderTarget):
(gl::RenderbufferStorage::getDepthStencil):
(gl::RenderbufferStorage::getWidth):
(gl::RenderbufferStorage::getHeight):
(gl::RenderbufferStorage::getInternalFormat):
(gl::RenderbufferStorage::getD3DFormat):
(gl::RenderbufferStorage::getSamples):
(gl::RenderbufferStorage::getSerial):
(gl::RenderbufferStorage::issueSerial):
(gl::RenderbufferStorage::issueCubeSerials):
(gl::Colorbuffer::Colorbuffer):
(gl::Colorbuffer::~Colorbuffer):
(gl::Colorbuffer::getRenderTarget):
(gl::DepthStencilbuffer::DepthStencilbuffer):
(gl::DepthStencilbuffer::~DepthStencilbuffer):
(gl::DepthStencilbuffer::getDepthStencil):
(gl::Depthbuffer::Depthbuffer):
(gl::Depthbuffer::~Depthbuffer):
(gl::Stencilbuffer::Stencilbuffer):
(gl::Stencilbuffer::~Stencilbuffer):
- src/libGLESv2/Renderbuffer.h: Added.
(gl::RenderbufferInterface::~RenderbufferInterface):
- src/libGLESv2/ResourceManager.cpp: Added.
(gl::ResourceManager::ResourceManager):
(gl::ResourceManager::~ResourceManager):
(gl::ResourceManager::addRef):
(gl::ResourceManager::release):
(gl::ResourceManager::createBuffer):
(gl::ResourceManager::createShader):
(gl::ResourceManager::createProgram):
(gl::ResourceManager::createTexture):
(gl::ResourceManager::createRenderbuffer):
(gl::ResourceManager::deleteBuffer):
(gl::ResourceManager::deleteShader):
(gl::ResourceManager::deleteProgram):
(gl::ResourceManager::deleteTexture):
(gl::ResourceManager::deleteRenderbuffer):
(gl::ResourceManager::getBuffer):
(gl::ResourceManager::getShader):
(gl::ResourceManager::getTexture):
(gl::ResourceManager::getProgram):
(gl::ResourceManager::getRenderbuffer):
(gl::ResourceManager::setRenderbuffer):
(gl::ResourceManager::checkBufferAllocation):
(gl::ResourceManager::checkTextureAllocation):
(gl::ResourceManager::checkRenderbufferAllocation):
- src/libGLESv2/ResourceManager.h: Added.
- src/libGLESv2/Shader.cpp: Added.
(gl::Shader::Shader):
(gl::Shader::~Shader):
(gl::Shader::getHandle):
(gl::Shader::setSource):
(gl::Shader::getInfoLogLength):
(gl::Shader::getInfoLog):
(gl::Shader::getSourceLength):
(gl::Shader::getTranslatedSourceLength):
(gl::Shader::getSourceImpl):
(gl::Shader::getSource):
(gl::Shader::getTranslatedSource):
(gl::Shader::isCompiled):
(gl::Shader::getHLSL):
(gl::Shader::addRef):
(gl::Shader::release):
(gl::Shader::getRefCount):
(gl::Shader::isFlaggedForDeletion):
(gl::Shader::flagForDeletion):
(gl::Shader::initializeCompiler):
(gl::Shader::releaseCompiler):
(gl::Shader::parseVaryings):
(gl::Shader::uncompile):
(gl::Shader::compileToHLSL):
(gl::Shader::parseType):
(gl::Shader::compareVarying):
(gl::VertexShader::VertexShader):
(gl::VertexShader::~VertexShader):
(gl::VertexShader::getType):
(gl::VertexShader::uncompile):
(gl::VertexShader::compile):
(gl::VertexShader::getSemanticIndex):
(gl::VertexShader::parseAttributes):
(gl::FragmentShader::FragmentShader):
(gl::FragmentShader::~FragmentShader):
(gl::FragmentShader::getType):
(gl::FragmentShader::compile):
- src/libGLESv2/Shader.h: Added.
(gl::Varying::Varying):
(gl::Attribute::Attribute):
- src/libGLESv2/Texture.cpp: Added.
(gl::ConvertTextureInternalFormat):
(gl::IsTextureFormatRenderable):
(gl::GetTextureUsage):
(gl::MakeValidSize):
(gl::CopyLockableSurfaces):
(gl::Image::Image):
(gl::Image::~Image):
(gl::Image::redefine):
(gl::Image::createSurface):
(gl::Image::lock):
(gl::Image::unlock):
(gl::Image::isRenderableFormat):
(gl::Image::getD3DFormat):
(gl::Image::getSurface):
(gl::Image::setManagedSurface):
(gl::Image::updateSurface):
(gl::Image::loadData):
(gl::Image::loadAlphaData):
(gl::Image::loadAlphaFloatData):
(gl::Image::loadAlphaHalfFloatData):
(gl::Image::loadLuminanceData):
(gl::Image::loadLuminanceFloatData):
(gl::Image::loadLuminanceHalfFloatData):
(gl::Image::loadLuminanceAlphaData):
(gl::Image::loadLuminanceAlphaFloatData):
(gl::Image::loadLuminanceAlphaHalfFloatData):
(gl::Image::loadRGBUByteData):
(gl::Image::loadRGB565Data):
(gl::Image::loadRGBFloatData):
(gl::Image::loadRGBHalfFloatData):
(gl::Image::loadRGBAUByteData):
(gl::Image::loadRGBA4444Data):
(gl::Image::loadRGBA5551Data):
(gl::Image::loadRGBAFloatData):
(gl::Image::loadRGBAHalfFloatData):
(gl::Image::loadBGRAData):
(gl::Image::loadCompressedData):
(gl::Image::copy):
(gl::TextureStorage::TextureStorage):
(gl::TextureStorage::~TextureStorage):
(gl::TextureStorage::isRenderTarget):
(gl::TextureStorage::isManaged):
(gl::TextureStorage::getPool):
(gl::TextureStorage::getUsage):
(gl::TextureStorage::getTextureSerial):
(gl::TextureStorage::issueTextureSerial):
(gl::TextureStorage::getLodOffset):
(gl::Texture::Texture):
(gl::Texture::~Texture):
(gl::Texture::setMinFilter):
(gl::Texture::setMagFilter):
(gl::Texture::setWrapS):
(gl::Texture::setWrapT):
(gl::Texture::setMaxAnisotropy):
(gl::Texture::setUsage):
(gl::Texture::getMinFilter):
(gl::Texture::getMagFilter):
(gl::Texture::getWrapS):
(gl::Texture::getWrapT):
(gl::Texture::getMaxAnisotropy):
(gl::Texture::getUsage):
(gl::Texture::isMipmapFiltered):
(gl::Texture::setImage):
(gl::Texture::setCompressedImage):
(gl::Texture::subImage):
(gl::Texture::subImageCompressed):
(gl::Texture::getTexture):
(gl::Texture::hasDirtyParameters):
(gl::Texture::hasDirtyImages):
(gl::Texture::resetDirty):
(gl::Texture::getTextureSerial):
(gl::Texture::getRenderTargetSerial):
(gl::Texture::isImmutable):
(gl::Texture::getLodOffset):
(gl::Texture::creationLevels):
(gl::Texture::levelCount):
(gl::Texture::getBlitter):
(gl::Texture::copyToRenderTarget):
(gl::TextureStorage2D::TextureStorage2D):
(gl::TextureStorage2D::~TextureStorage2D):
(gl::TextureStorage2D::getSurfaceLevel):
(gl::TextureStorage2D::getBaseTexture):
(gl::TextureStorage2D::getRenderTargetSerial):
(gl::Texture2D::Texture2D):
(gl::Texture2D::~Texture2D):
(gl::Texture2D::addProxyRef):
(gl::Texture2D::releaseProxy):
(gl::Texture2D::getTarget):
(gl::Texture2D::getWidth):
(gl::Texture2D::getHeight):
(gl::Texture2D::getInternalFormat):
(gl::Texture2D::getD3DFormat):
(gl::Texture2D::redefineImage):
(gl::Texture2D::setImage):
(gl::Texture2D::bindTexImage):
(gl::Texture2D::releaseTexImage):
(gl::Texture2D::setCompressedImage):
(gl::Texture2D::commitRect):
(gl::Texture2D::subImage):
(gl::Texture2D::subImageCompressed):
(gl::Texture2D::copyImage):
(gl::Texture2D::copySubImage):
(gl::Texture2D::storage):
(gl::Texture2D::isSamplerComplete):
(gl::Texture2D::isMipmapComplete):
(gl::Texture2D::isCompressed):
(gl::Texture2D::isDepth):
(gl::Texture2D::getBaseTexture):
(gl::Texture2D::createTexture):
(gl::Texture2D::updateTexture):
(gl::Texture2D::convertToRenderTarget):
(gl::Texture2D::generateMipmaps):
(gl::Texture2D::getRenderbuffer):
(gl::Texture2D::getRenderTarget):
(gl::Texture2D::getDepthStencil):
(gl::Texture2D::getStorage):
(gl::TextureStorageCubeMap::TextureStorageCubeMap):
(gl::TextureStorageCubeMap::~TextureStorageCubeMap):
(gl::TextureStorageCubeMap::getCubeMapSurface):
(gl::TextureStorageCubeMap::getBaseTexture):
(gl::TextureStorageCubeMap::getRenderTargetSerial):
(gl::TextureCubeMap::TextureCubeMap):
(gl::TextureCubeMap::~TextureCubeMap):
(gl::TextureCubeMap::addProxyRef):
(gl::TextureCubeMap::releaseProxy):
(gl::TextureCubeMap::getTarget):
(gl::TextureCubeMap::getWidth):
(gl::TextureCubeMap::getHeight):
(gl::TextureCubeMap::getInternalFormat):
(gl::TextureCubeMap::getD3DFormat):
(gl::TextureCubeMap::setImagePosX):
(gl::TextureCubeMap::setImageNegX):
(gl::TextureCubeMap::setImagePosY):
(gl::TextureCubeMap::setImageNegY):
(gl::TextureCubeMap::setImagePosZ):
(gl::TextureCubeMap::setImageNegZ):
(gl::TextureCubeMap::setCompressedImage):
(gl::TextureCubeMap::commitRect):
(gl::TextureCubeMap::subImage):
(gl::TextureCubeMap::subImageCompressed):
(gl::TextureCubeMap::isSamplerComplete):
(gl::TextureCubeMap::isCubeComplete):
(gl::TextureCubeMap::isMipmapCubeComplete):
(gl::TextureCubeMap::isCompressed):
(gl::TextureCubeMap::getBaseTexture):
(gl::TextureCubeMap::createTexture):
(gl::TextureCubeMap::updateTexture):
(gl::TextureCubeMap::convertToRenderTarget):
(gl::TextureCubeMap::setImage):
(gl::TextureCubeMap::faceIndex):
(gl::TextureCubeMap::redefineImage):
(gl::TextureCubeMap::copyImage):
(gl::TextureCubeMap::copySubImage):
(gl::TextureCubeMap::storage):
(gl::TextureCubeMap::generateMipmaps):
(gl::TextureCubeMap::getRenderbuffer):
(gl::TextureCubeMap::getRenderTarget):
(gl::TextureCubeMap::getStorage):
- src/libGLESv2/Texture.h: Added.
(gl::Image::markDirty):
(gl::Image::markClean):
(gl::Image::getWidth):
(gl::Image::getHeight):
(gl::Image::getInternalFormat):
(gl::Image::isDirty):
- src/libGLESv2/TextureSSE2.cpp: Added.
(gl::Image::loadRGBAUByteDataSSE2):
(gl::Image::loadAlphaDataSSE2):
- src/libGLESv2/VertexDataManager.cpp: Added.
(gl::elementsInBuffer):
(gl::VertexDataManager::VertexDataManager):
(gl::VertexDataManager::~VertexDataManager):
(gl::VertexDataManager::writeAttributeData):
(gl::VertexDataManager::prepareVertexData):
(gl::VertexDataManager::spaceRequired):
(gl::VertexDataManager::checkVertexCaps):
(gl::VertexDataManager::typeIndex):
(gl::VertexBuffer::VertexBuffer):
(gl::VertexBuffer::~VertexBuffer):
(gl::VertexBuffer::unmap):
(gl::VertexBuffer::getBuffer):
(gl::VertexBuffer::getSerial):
(gl::VertexBuffer::issueSerial):
(gl::ArrayVertexBuffer::ArrayVertexBuffer):
(gl::ArrayVertexBuffer::~ArrayVertexBuffer):
(gl::ArrayVertexBuffer::addRequiredSpace):
(gl::StreamingVertexBuffer::StreamingVertexBuffer):
(gl::StreamingVertexBuffer::~StreamingVertexBuffer):
(gl::StreamingVertexBuffer::map):
(gl::StreamingVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::StaticVertexBuffer):
(gl::StaticVertexBuffer::~StaticVertexBuffer):
(gl::StaticVertexBuffer::map):
(gl::StaticVertexBuffer::reserveRequiredSpace):
(gl::StaticVertexBuffer::lookupAttribute):
(gl::VertexDataManager::formatConverter):
- src/libGLESv2/VertexDataManager.h: Added.
(gl::ArrayVertexBuffer::size):
(gl::VertexDataManager::dirtyCurrentValue):
- src/libGLESv2/libGLESv2.cpp: Added.
(validImageSize):
(checkTextureFormatType):
(validateSubImageParams2D):
(validateSubImageParamsCube):
(validReadFormatType):
- src/libGLESv2/libGLESv2.def: Added.
- src/libGLESv2/libGLESv2.rc: Added.
- src/libGLESv2/libGLESv2.vcxproj: Added.
- src/libGLESv2/libGLESv2.vcxproj.filters: Added.
- src/libGLESv2/main.cpp: Added.
(DllMain):
(gl::makeCurrent):
(gl::getContext):
(gl::getNonLostContext):
(gl::getDisplay):
(gl::getDevice):
(gl::checkDeviceLost):
(error):
- src/libGLESv2/main.h: Added.
(error):
- src/libGLESv2/mathutil.h: Added.
(gl::Vector4::Vector4):
(gl::isPow2):
(gl::log2):
(gl::ceilPow2):
(gl::clamp):
(gl::clamp01):
(gl::unorm):
(gl::supportsSSE2):
(gl::float32ToFloat16):
- src/libGLESv2/resource.h: Added.
- src/libGLESv2/shaders: Added.
- src/libGLESv2/shaders/Blit.ps: Added.
- src/libGLESv2/shaders/Blit.vs: Added.
- src/libGLESv2/shaders/componentmaskps.h: Added.
- src/libGLESv2/shaders/flipyvs.h: Added.
- src/libGLESv2/shaders/generate_shaders.bat: Added.
- src/libGLESv2/shaders/luminanceps.h: Added.
- src/libGLESv2/shaders/passthroughps.h: Added.
- src/libGLESv2/shaders/standardvs.h: Added.
- src/libGLESv2/utilities.cpp: Added.
(gl::UniformExternalComponentCount):
(gl::UniformInternalComponentCount):
(gl::UniformComponentType):
(gl::UniformComponentSize):
(gl::UniformInternalSize):
(gl::UniformExternalSize):
(gl::VariableRowCount):
(gl::VariableColumnCount):
(gl::AllocateFirstFreeBits):
(gl::ComputePitch):
(gl::ComputeCompressedPitch):
(gl::ComputeCompressedSize):
(gl::IsCompressed):
(gl::IsDepthTexture):
(gl::IsStencilTexture):
(gl::ComputePixelSize):
(gl::IsCubemapTextureTarget):
(gl::IsInternalTextureTarget):
(gl::ConvertSizedInternalFormat):
(gl::ExtractFormat):
(gl::ExtractType):
(gl::IsColorRenderable):
(gl::IsDepthRenderable):
(gl::IsStencilRenderable):
(gl::IsFloat32Format):
(gl::IsFloat16Format):
(es2dx::ConvertComparison):
(es2dx::ConvertColor):
(es2dx::ConvertBlendFunc):
(es2dx::ConvertBlendOp):
(es2dx::ConvertStencilOp):
(es2dx::ConvertTextureWrap):
(es2dx::ConvertCullMode):
(es2dx::ConvertCubeFace):
(es2dx::ConvertColorMask):
(es2dx::ConvertMagFilter):
(es2dx::ConvertMinFilter):
(es2dx::ConvertPrimitiveType):
(es2dx::ConvertRenderbufferFormat):
(es2dx::GetMultisampleTypeFromSamples):
(dx2es::GetStencilSize):
(dx2es::GetAlphaSize):
(dx2es::GetRedSize):
(dx2es::GetGreenSize):
(dx2es::GetBlueSize):
(dx2es::GetDepthSize):
(dx2es::GetSamplesFromMultisampleType):
(dx2es::IsFormatChannelEquivalent):
(dx2es::ConvertReadBufferFormat):
(dx2es::ConvertBackBufferFormat):
(dx2es::ConvertDepthStencilFormat):
(dx::IsCompressedFormat):
(dx::ComputeRowSize):
(getTempPath):
(writeFile):
- src/libGLESv2/utilities.h: Added.
(isDeviceLostError):
- src/libGLESv2/vertexconversion.h: Added.
(gl::Identity::convert):
(gl::Cast::convert):
(gl::Normalize::convert):
(gl::FixedToFloat::convert):
(gl::SimpleDefaultValues::zero):
(gl::SimpleDefaultValues::one):
(gl::NormalizedDefaultValues::zero):
(gl::NormalizedDefaultValues::one):
(gl::VertexDataConverter::convertArray):
(gl::VertexDataConverter::pointerAddBytes):
(gl::VertexDataConverter::copyComponent):
- 1:38 PM Changeset in webkit [152862] by
-
- 4 edits in trunk/Source/WebKit2
<rdar://problem/13886443> Assertion failures in NetworkProcess in SandboxExtension::revoke when aborting SyncNetworkResourceLoader
<rdar://problem/13826348> ASSERT(!m_useCount) fails in NetworkProcess at SandboxExtension::~SandboxExtension
https://bugs.webkit.org/show_bug.cgi?id=118855
Reviewed by Brady Eidson.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::cleanup): (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::didFail): Moved sandbox extension invalidation to cleanup() meaning that we won't fail to do this when aborting a loader that currently loading from network.
- NetworkProcess/SchedulableLoader.cpp: (WebKit::SchedulableLoader::SchedulableLoader): (WebKit::SchedulableLoader::consumeSandboxExtensions): (WebKit::SchedulableLoader::invalidateSandboxExtensions):
- NetworkProcess/SchedulableLoader.h: Keep track of whether sandbox extensions are consumed, we don't want to revoke extensions that were never consumed (as used to be the case with sync loaders, and would be with async ones after the above fix). Also, get rid of extensions immediately when invalidating, we won't need them again.
- 1:30 PM Changeset in webkit [152861] by
-
- 17 edits6 adds in trunk
[Windows] Support in-band text tracks.
https://bugs.webkit.org/show_bug.cgi?id=103770.
- 1:28 PM Changeset in webkit [152860] by
-
- 2 edits in trunk/Tools
Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
- Scripts/webkitpy/common/config/ews.json:
- 12:07 PM Changeset in webkit [152859] by
-
- 9 edits1 add in trunk
Make atob() / btoa() argument non optional
https://bugs.webkit.org/show_bug.cgi?id=118844
Reviewed by Kentaro Hara.
Source/WebCore:
According to the latest specification, the argument to atob() / btoa()
should not be optional:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#windowbase64
This patch makes WebKit behave according to the specification. The argument
is also mandatory in Firefox, IE10 and Blink.
atob() / btoa() are also moved to their own WindowBase64 interface which
the Window interface implements. This does not change the behavior but
this is closer to the specification and it will make exposing those
methods to workers easier later on.
No new tests, already covered by:
fast/dom/Window/atob-btoa.html
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- page/DOMWindow.idl:
- page/WindowBase64.idl: Added.
LayoutTests:
Update and rebaseline fast/dom/Window/atob-btoa.html as atob() /
btoa() 's behavior has changed to match the specification and
the behavior in other browsers.
- fast/dom/Window/atob-btoa-expected.txt:
- fast/dom/Window/atob-btoa.html:
- 11:58 AM Changeset in webkit [152858] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::createMarkup()
https://bugs.webkit.org/show_bug.cgi?id=118847
Reviewed by Ryosuke Niwa.
Also check that we have a containingBlock() for the renderer() so that we
may safely call node() on it.
- editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):
- 11:54 AM Changeset in webkit [152857] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: CFA should consider live-at-head for clobbering and dumping
https://bugs.webkit.org/show_bug.cgi?id=118857
Reviewed by Mark Hahnenberg.
- clobberStructures() was not considering nodes live-at-head when in SSA form. This means it would fail to clobber some structures.
- dump() was not considering nodes live-at-head when in SSA form. This means it wouldn't dump everything that you might be interested in.
- AbstractState::m_currentNode is a useless variable and we should get rid of it.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::AbstractState):
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::reset):
(JSC::DFG::AbstractState::startExecuting):
(JSC::DFG::AbstractState::clobberStructures):
(JSC::DFG::AbstractState::dump):
- dfg/DFGAbstractState.h:
(AbstractState):
- 11:36 AM Changeset in webkit [152856] by
-
- 3 edits in branches/safari-537-branch/Source/JavaScriptCore
Merged r152807. <rdar://problem/14472115>
- 11:34 AM Changeset in webkit [152855] by
-
- 3 edits in tags/Safari-537.51.2/Source/JavaScriptCore
Merged r152807. <rdar://problem/14472115>
- 11:33 AM Changeset in webkit [152854] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152805. <rdar://problem/14173389>
- 11:31 AM Changeset in webkit [152853] by
-
- 2 edits in tags/Safari-537.51.2/Source/WebKit2
Merged r152805. <rdar://problem/14173389>
- 11:26 AM Changeset in webkit [152852] by
-
- 2 edits in trunk/Tools
REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=118854
<rdar://problem/14081339>
Reviewed by David Kilzer.
Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
listen on these ports so that we can run tests that use port 8443 and 8080.
- Scripts/old-run-webkit-tests:
(configureAndOpenHTTPDIfNeeded):
- 11:05 AM Changeset in webkit [152851] by
-
- 5 edits in tags/Safari-537.51.2/Source
Versioning.
- 11:03 AM Changeset in webkit [152850] by
-
- 1 copy in tags/Safari-537.51.2
New Tag.
- 10:45 AM Changeset in webkit [152849] by
-
- 1 edit16 adds14 deletes in trunk/LayoutTests
Convert MathML fraction tests to reftests.
https://bugs.webkit.org/show_bug.cgi?id=118812
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-07-18
Reviewed by Chris Fleizach.
fractions-vertical-alignment and fractions are converted to reftests.
- mathml/presentation/fractions-box-expected.html: Added.
- mathml/presentation/fractions-box.html: Added.
- mathml/presentation/fractions-color-expected-mismatch.html: Added.
- mathml/presentation/fractions-color.html: Added.
- mathml/presentation/fractions-invalid-expected.html: Added.
- mathml/presentation/fractions-invalid.html: Added.
- mathml/presentation/fractions-linethickness-expected.html: Added.
- mathml/presentation/fractions-linethickness.html: Added.
- mathml/presentation/fractions-mrow-expected.html: Added.
- mathml/presentation/fractions-mrow.html: Added.
- mathml/presentation/fractions-numalign-denomalign-expected.html: Added.
- mathml/presentation/fractions-numalign-denomalign.html: Added.
- mathml/presentation/fractions-positions-expected.html: Added.
- mathml/presentation/fractions-positions.html: Added.
- mathml/presentation/fractions-vertical-alignment-expected.html: Added.
- mathml/presentation/fractions-vertical-alignment.html: Added.
- mathml/presentation/fractions-vertical-alignment.xhtml: Removed.
- mathml/presentation/fractions.xhtml: Removed.
- platform/efl/mathml/presentation/fractions-expected.png: Removed.
- platform/efl/mathml/presentation/fractions-expected.txt: Removed.
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/efl/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
- platform/gtk/mathml/presentation/fractions-expected.png: Removed.
- platform/gtk/mathml/presentation/fractions-expected.txt: Removed.
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
- platform/mac/mathml/presentation/fractions-expected.png: Removed.
- platform/mac/mathml/presentation/fractions-expected.txt: Removed.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png: Removed.
- platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt: Removed.
- 9:50 AM Changeset in webkit [152848] by
-
- 4 edits in trunk/Source
CodeBlock::m_argumentValueProfiles wastes a lot of memory.
<http://webkit.org/b/118852>
<rdar://problem/14481659>
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
Use Vector::resizeToFit() for CodeBlock::m_argumentValueProfiles. We don't need any padding
for growth, since we won't be appending to it anyway.
921 KB progression on <http://twitter.com/awesomekling>
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setNumParameters):
Source/WTF:
Add Vector::resizeToFit(size), like resize() but without growth padding.
- wtf/Vector.h:
(WTF::::resizeToFit):
- 8:44 AM Changeset in webkit [152847] by
-
- 4 edits in trunk/LayoutTests
fullscreen/full-screen-iframe-with-max-width-height.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=118820
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-18
Reviewed by Andreas Kling.
Don't start the test until after the iframe has finished loading.
- fullscreen/full-screen-iframe-with-max-width-height-expected.txt:
- fullscreen/full-screen-iframe-with-max-width-height.html:
- platform/mac/TestExpectations:
- 8:39 AM Changeset in webkit [152846] by
-
- 5 edits in trunk
Only the first call to 'stop' method of AudioBufferSourceNode must be entertained.
https://bugs.webkit.org/show_bug.cgi?id=118776
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-07-18
Reviewed by Jer Noble.
Source/WebCore:
Subsequent calls to 'stop' for a AudioSourceBufferNode throws an exception.
End time set by first 'stop' method is used for processing.
No new tests. audiobuffersource-exception.html is updated.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::stop):
LayoutTests:
Test case updated to check subsequent calls to 'stop' for a given AudioBufferSourceNode.
- webaudio/audiobuffersource-exception-expected.txt:
- webaudio/audiobuffersource-exception.html:
- 7:51 AM Changeset in webkit [152845] by
-
- 2 edits in trunk/Source/WebCore
Simplify SVG animated type handling in the JSC bindings generator
https://bugs.webkit.org/show_bug.cgi?id=118845
Reviewed by Kentaro Hara.
Simplify IsSVGAnimatedType subroutine in the bindings generator so that
we no longer need to hardcode SVG animated types. Also remove the
CanUseFastAttribute subroutine as it is equivalent to IsSVGAnimatedType.
This allows us to simplify the GetterExpression subroutine so that
we can use fastHasAttribute() unconditionally for boolean type.
No new tests, no behavior change.
- bindings/scripts/CodeGenerator.pm:
(IsSVGAnimatedType):
(GetterExpression):
- 7:45 AM WebKitGTK/2.0.x edited by
- (diff)
- 7:24 AM Changeset in webkit [152844] by
-
- 14 edits in trunk/Source/WebCore
Use [ImplementedAs] instead of special casing in the bindings generators
https://bugs.webkit.org/show_bug.cgi?id=118848
Reviewed by Kentaro Hara.
In several instances, special casing were used in the bindings generator to avoid
name clashes in the implementation. The [ImplementedBy] IDL extended attribute is
meant to solve this issue so we now use it instead.
No new tests, no behavior change.
- bindings/scripts/CodeGenerator.pm:
(WK_ucfirst):
(AttributeNameForGetterAndSetter):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(NativeToJSValue):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- svg/SVGAElement.idl:
- svg/SVGFECompositeElement.cpp:
(WebCore::SVGFECompositeElement::SVGFECompositeElement):
(WebCore::SVGFECompositeElement::parseAttribute):
(WebCore::SVGFECompositeElement::setFilterEffectAttribute):
(WebCore::SVGFECompositeElement::build):
- svg/SVGFECompositeElement.h:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
(WebCore::SVGFEMorphologyElement::parseAttribute):
(WebCore::SVGFEMorphologyElement::setFilterEffectAttribute):
(WebCore::SVGFEMorphologyElement::build):
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGTransform.cpp:
(WebCore::SVGTransform::updateSVGMatrix):
- svg/SVGTransform.h:
- svg/SVGTransform.idl:
- 7:03 AM Changeset in webkit [152843] by
-
- 5 edits in trunk/Source/WebKit/qt
[Qt][WK1] Mark failing API tests as XFAIL
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-18
Reviewed by Csaba Osztrogonác.
- tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::widgetsRenderingThroughCache):
(tst_QGraphicsWebView::windowResizeEvent):
- tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::addElementToHead):
- tests/qwebframe/tst_qwebframe.cpp:
(tst_QWebFrame::setHtmlWithImageResource):
(tst_QWebFrame::setHtmlWithStylesheetResource):
(tst_QWebFrame::setHtmlWithJSAlert):
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::geolocationRequestJS):
(tst_QWebPage::popupFormSubmission):
(tst_QWebPage::originatingObjectInNetworkRequests):
(tst_QWebPage::testStopScheduledPageRefresh):
- 6:05 AM Changeset in webkit [152842] by
-
- 2 edits in trunk/LayoutTests
Unskip mathml tests after r152840.
https://bugs.webkit.org/show_bug.cgi?id=118842
Unreviewed.
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-18
- platform/mac/TestExpectations:
- 4:01 AM WebKitGTK/WebKit2Roadmap edited by
- (diff)
- 2:35 AM Changeset in webkit [152841] by
-
- 29 edits in trunk/Source/WebKit2
Remove PDFViewController and WKView "custom representations"
https://bugs.webkit.org/show_bug.cgi?id=118720
Reviewed by Alexey Proskuryakov.
PDFViewController was the only implementation of
a "custom representation" for a WKView. As it has
been superceded by PDFPlugin, we can remove both
PDFViewController and the notion of a WKView custom
representation.
- UIProcess/API/gtk/PageClientImpl.cpp:
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/mac/PDFViewController.h: Removed.
- UIProcess/API/mac/PDFViewController.mm: Removed.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm:
- UIProcess/API/mac/WKView.mm:
(-[WKView accessibilityFocusedUIElement]):
(-[WKView accessibilityHitTest:]):
(-[WKView accessibilityAttributeValue:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/API/qt/raw/qrawwebview_p_p.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/DrawingAreaProxyImpl.cpp:
- UIProcess/DrawingAreaProxyImpl.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::supportsTextEncoding):
(WebKit::WebPageProxy::supportsTextZoom):
(WebKit::WebPageProxy::setTextZoomFactor):
(WebKit::WebPageProxy::setPageZoomFactor):
(WebKit::WebPageProxy::setPageAndTextZoomFactors):
(WebKit::WebPageProxy::findString):
(WebKit::WebPageProxy::countStringMatches):
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::textZoomFactor):
(WebKit::WebPageProxy::pageZoomFactor):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/qt/QtPageClient.h:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::committedLoad):
(WebKit::WebFrameLoaderClient::finishedLoading):
(WebKit::WebFrameLoaderClient::transitionToCommittedFromCachedFrame):
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/DrawingArea.messages.in:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::setNeedsDisplayInRect):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaImpl::display):
- WebProcess/WebPage/DrawingAreaImpl.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
- mac/WebKit2.order:
- 2:09 AM Changeset in webkit [152840] by
-
- 10 edits2 adds in trunk
Incorrect calculated width for mspace.
https://bugs.webkit.org/show_bug.cgi?id=118601
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-18
Reviewed by Chris Fleizach.
Source/WebCore:
Use intrinsic logical widths to size <mspace> properly.
This patch also fixes an assert on isPreferredLogicalHeightDirty() which occurs
while layouting <mspace>. The assert fix is required, so that the sizing can be
fixed.
Test: mathml/presentation/mspace-prefered-width.html
- rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::parseMathMLLength): switch to LayoutUnits.
(WebCore::parseMathMLNamedSpace): switch to LayoutUnits.
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLSpace.cpp:
(WebCore::RenderMathMLSpace::computeIntrinsicLogicalWidths):
- rendering/mathml/RenderMathMLSpace.h:
LayoutTests:
Use intrinsic logical widths to size <mspace> properly.
This patch also fixes an assert on isPreferredLogicalHeightDirty(), which occurs
while layouting <mspace>. The assert fix is required, so that the sizing can be
fixed.
- mathml/presentation/mspace-prefered-width-expected.html: Added.
- mathml/presentation/mspace-prefered-width.html: Added.
- platform/mac/mathml/presentation/fractions-expected.png: Rebaseline: float->LayoutUnit.
- platform/mac/mathml/presentation/fractions-expected.txt: Rebaseline: float->LayoutUnit.
- 1:45 AM Changeset in webkit [152839] by
-
- 2 edits in trunk/Source/WebCore
willWriteSelectionToPasteboard and willPerformDragSourceAction editing callbacks are not called for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=118828
Reviewed by Gavin Barraclough.
Call these two callbacks when we start a drag and drop.
No new tests for now but we should start logging these callbacks in DRT and WTR's EditorClients.
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- 1:28 AM Changeset in webkit [152838] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118797
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.
Some mouseClick methods are used in test_ewk2_color_picker.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(EWK2ColorPickerTest::clickButton):
(TEST_F):
- 1:05 AM Changeset in webkit [152837] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Replace getRect() to pixelSnappedBoundingBox().
https://bugs.webkit.org/show_bug.cgi?id=118588
Patch by Eunmi Lee <eunmi15.lee@samsung.com> on 2013-07-18
Reviewed by Noam Rosenthal.
The Node::getRect() function was removed in the
http://trac.webkit.org/changeset/128006, so use
pixelSnappedBoundingBox() instead.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::findZoomableAreaForPoint):
- 1:04 AM Changeset in webkit [152836] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: !listItems().size() m_activeSelectionAnchorIndex >= 0 in WebCore::HTMLSelectElement::updateListBoxSelection https://bugs.webkit.org/show_bug.cgi?id=118591
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-07-18
Reviewed by Kent Tamura.
Source/WebCore:
Test: fast/forms/select/selectall-command-crash.html
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::selectAll):
We should return this function if activeSelectionAnchorIndex is not valid index
LayoutTests:
- fast/forms/select/selectall-command-crash-expected.txt: Added.
- fast/forms/select/selectall-command-crash.html: Added.
- 1:01 AM Changeset in webkit [152835] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_context_menu.cpp
https://bugs.webkit.org/show_bug.cgi?id=118796
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.
Some mouseClick methods are used in test_ewk2_context_menu.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(EWK2ContextMenuTest::testContextMenu):
(EWK2ContextMenuTest::testContextMenuForRemoveAndAppend):
(EWK2ContextMenuTest::testContextMenuForSubmenu):
(EWK2ContextMenuTest::finishTest):
(EWK2ContextMenuTest::showContextMenu):
(TEST_F):
- 12:51 AM Changeset in webkit [152834] by
-
- 6 edits in trunk
[EFL] Refactor spin.edc not to use offset
https://bugs.webkit.org/show_bug.cgi?id=118830
Reviewed by Gyuyoung Kim.
Source/WebCore:
EDJE allows offset to specify the pixel based position,
but it's not good way if you want to locate object like arrow top or bottom.
Instead, this patch uses align property.
- platform/efl/DefaultTheme/widget/spinner/spinner.edc:
LayoutTests:
Updated pixel tests reults.
- platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
- platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
- 12:29 AM Changeset in webkit [152833] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_file_chooser_request.cpp
https://bugs.webkit.org/show_bug.cgi?id=118792
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.
Some mouseClick methods are used in test_ewk2_file_chooser_request.cpp.
But it is difficult to understand what they mean.
So i would like to replace those with more meaningful method for readability.
- UIProcess/API/efl/tests/test_ewk2_file_chooser_request.cpp:
(EWK2FileChooserRequestTest::clickFileInput):
(TEST_F):
- 12:27 AM Changeset in webkit [152832] by
-
- 2 edits in trunk/Source/WebCore
[gstreamer] Avoid calls to g_slist_index in webKitWebAudioSrcLoop()
https://bugs.webkit.org/show_bug.cgi?id=118827
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-07-18
Reviewed by Philippe Normand.
webKitWebAudioSrcLoop() currently calls g_slist_index for each element
to get its index in a list it's iterating over. g_list_index function uses
a sequential search to find that element, which is clearly unecessary.
This patch adds a local variable to store the current index and use it
instead of calling g_slist_index function.
No new tests, no behavior changes.
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcLoop):
- 12:27 AM Changeset in webkit [152831] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Move all the static methods into EWK2TextCheckerTest in test_ewk2_text_checker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118790
Patch by Dong-Gwan Kim <donggwan.kim@samsung.com> on 2013-07-18
Reviewed by Christophe Dumez.
All the static methods should be moved to EWK2TextCheckerTest.
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(EWK2TextCheckerTest::resetCallbacksExecutionStats):
(EWK2TextCheckerTest::onTimeout):
(EWK2TextCheckerTest::onSettingChange):
(EWK2TextCheckerTest::onSpellDocumentTag):
(EWK2TextCheckerTest::onSpellDocumentTagClose):
(EWK2TextCheckerTest::onSpellingCheck):
(EWK2TextCheckerTest::onSpellingForKnownWord):
(EWK2TextCheckerTest::onWordGuesses):
(EWK2TextCheckerTest::onWordLearn):
(EWK2TextCheckerTest::onWordIgnore):
(EWK2TextCheckerTest::findContextMenuItem):
(EWK2TextCheckerTest::checkCorrectnessOfSpellingItems):
(EWK2TextCheckerTest::toogleCheckSpellingWhileTyping):
(EWK2TextCheckerTest::checkClientSuggestionsForWord):
(EWK2TextCheckerTest::selectLearnSpelling):
(EWK2TextCheckerTest::selectIgnoreSpelling):
(EWK2TextCheckerTest::countContextMenuItems):
(EWK2TextCheckerTest::clickButton):
(EWK2TextCheckerTest::showContextMenu):
(EWK2TextCheckerTest::selectFirstWord):
