⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 20, 2013:

6:45 PM Changeset in webkit [152949] by Brent Fulgham
  • 2 edits
    1 delete in trunk/Source/JavaScriptCore

[Windows] Remove unneeded custom stdint.h now that we build on VS2010.
​https://bugs.webkit.org/show_bug.cgi?id=118868.

Reviewed by Anders Carlsson.

  • os-win32/stdint.h: Removed.
  • GNUmakefile.list.am: Removed reference to os-win32/stdint.h
6:02 PM Changeset in webkit [152948] by benjamin@webkit.org
  • 6 edits in trunk/Source/WebCore

Add ASCIILiteral() on strings allocated often enough to appear in my Instruments
​https://bugs.webkit.org/show_bug.cgi?id=118937

Reviewed by Alexey Proskuryakov.

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState):
(WebCore::BaseCheckableInputType::fallbackValue):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

5:31 PM Changeset in webkit [152947] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Tools

fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
​https://bugs.webkit.org/show_bug.cgi?id=118947

Reviewed by Dan Bernstein.

  • Scripts/copy-webkitlibraries-to-product-directory:
3:23 PM Changeset in webkit [152946] by dino@apple.com
  • 43 edits
    1 move
    3 adds
    77 deletes in trunk/Source

Updated ANGLE is leaking like a sieve
​https://bugs.webkit.org/show_bug.cgi?id=118939

Rollout 152863, r152821, r152929 and r152755.

Source/ThirdParty/ANGLE:

  • ANGLE.plist:
  • ANGLE.xcodeproj/project.pbxproj:
  • DerivedSources.make: Removed.
  • GNUmakefile.am:
  • Target.pri:
  • include/GLSLANG/ShaderLang.h:
  • src/compiler/BaseTypes.h:

(getQualifierString):

  • src/compiler/Common.h:

(EncodeSourceLoc):
(DecodeSourceLoc):

  • src/compiler/Compiler.cpp:

(TCompiler::TCompiler):
(TCompiler::Init):
(TCompiler::compile):
(TCompiler::detectRecursion):

  • src/compiler/ConstantUnion.h:

(ConstantUnion::ConstantUnion):

  • src/compiler/DetectCallDepth.cpp: Removed.
  • src/compiler/DetectRecursion.cpp: Added.

(DetectRecursion::FunctionNode::FunctionNode):
(DetectRecursion::FunctionNode::getName):
(DetectRecursion::FunctionNode::addCallee):
(DetectRecursion::FunctionNode::detectRecursion):
(DetectRecursion::DetectRecursion):
(DetectRecursion::~DetectRecursion):
(DetectRecursion::visitAggregate):
(DetectRecursion::detectRecursion):
(DetectRecursion::findFunctionByName):

  • src/compiler/DetectRecursion.h: Renamed from Source/ThirdParty/ANGLE/src/compiler/DetectCallDepth.h.
  • src/compiler/Diagnostics.cpp:

(TDiagnostics::writeInfo):

  • src/compiler/ForLoopUnroll.cpp:

(ForLoopUnroll::evaluateIntConstant):

  • src/compiler/InfoSink.cpp:

(TInfoSinkBase::prefix):
(TInfoSinkBase::location):
(TInfoSinkBase::message):

  • src/compiler/InfoSink.h:
  • src/compiler/Initialize.cpp:

(BuiltInFunctionsCommon):
(BuiltInFunctionsVertex):
(TBuiltIns::initialize):
(IdentifyBuiltIns):
(InitExtensionBehavior):

  • src/compiler/Intermediate.cpp:

(TIntermediate::addSymbol):
(TIntermediate::addBinaryMath):
(TIntermediate::addAssign):
(TIntermediate::addIndex):
(TIntermediate::addUnaryMath):
(TIntermediate::setAggregateOperator):
(TIntermediate::addConversion):
(TIntermediate::growAggregate):
(TIntermediate::makeAggregate):
(TIntermediate::addSelection):
(TIntermediate::addComma):
(TIntermediate::addConstantUnion):
(TIntermediate::addSwizzle):
(TIntermediate::addLoop):
(TIntermediate::addBranch):
(TIntermUnary::promote):
(TIntermBinary::promote):
(CompareStruct):
(CompareStructure):
(TIntermConstantUnion::fold):
(TIntermediate::promoteConstantUnion):

  • src/compiler/OutputGLSL.cpp:

(TOutputGLSL::writeVariablePrecision):

  • src/compiler/OutputGLSL.h:
  • src/compiler/OutputGLSLBase.cpp:

(TOutputGLSLBase::writeVariableType):
(TOutputGLSLBase::writeConstantUnion):
(TOutputGLSLBase::visitBinary):
(TOutputGLSLBase::visitAggregate):
(TOutputGLSLBase::getTypeName):
(TOutputGLSLBase::hashFunctionName):

  • src/compiler/OutputGLSLBase.h:
  • src/compiler/OutputHLSL.cpp:

(sh::OutputHLSL::OutputHLSL):
(sh::OutputHLSL::header):
(sh::OutputHLSL::visitSymbol):
(sh::OutputHLSL::visitBinary):
(sh::OutputHLSL::visitAggregate):
(sh::OutputHLSL::visitSelection):
(sh::OutputHLSL::visitLoop):
(sh::OutputHLSL::handleExcessiveLoop):
(sh::OutputHLSL::typeString):
(sh::OutputHLSL::initializer):
(sh::OutputHLSL::addConstructor):
(sh::OutputHLSL::writeConstantUnion):
(sh::OutputHLSL::decorateField):

  • src/compiler/OutputHLSL.h:
  • src/compiler/ParseHelper.cpp:

(TParseContext::parseVectorFields):
(TParseContext::parseMatrixFields):
(TParseContext::error):
(TParseContext::warning):
(TParseContext::assignError):
(TParseContext::unaryOpError):
(TParseContext::binaryOpError):
(TParseContext::precisionErrorCheck):
(TParseContext::lValueErrorCheck):
(TParseContext::globalErrorCheck):
(TParseContext::reservedErrorCheck):
(TParseContext::constructorErrorCheck):
(TParseContext::voidErrorCheck):
(TParseContext::boolErrorCheck):
(TParseContext::samplerErrorCheck):
(TParseContext::structQualifierErrorCheck):
(TParseContext::parameterSamplerErrorCheck):
(TParseContext::containsSampler):
(TParseContext::arraySizeErrorCheck):
(TParseContext::arrayQualifierErrorCheck):
(TParseContext::arrayTypeErrorCheck):
(TParseContext::arrayErrorCheck):
(TParseContext::arraySetMaxSize):
(TParseContext::nonInitConstErrorCheck):
(TParseContext::nonInitErrorCheck):
(TParseContext::paramErrorCheck):
(TParseContext::extensionErrorCheck):
(TParseContext::handleExtensionDirective):
(TParseContext::handlePragmaDirective):
(TParseContext::findFunction):
(TParseContext::executeInitializer):
(TParseContext::addConstructor):
(TParseContext::constructBuiltIn):
(TParseContext::constructStruct):
(TParseContext::addConstVectorNode):
(TParseContext::addConstMatrixNode):
(TParseContext::addConstArrayNode):
(TParseContext::addConstStruct):
(TParseContext::enterStructDeclaration):
(TParseContext::structNestingErrorCheck):

  • src/compiler/ParseHelper.h:

(TParseContext::TParseContext):
(TParseContext::pragma):

  • src/compiler/PoolAlloc.cpp:

(TPoolAllocator::allocate):

  • src/compiler/ShHandle.h:
  • src/compiler/ShaderLang.cpp:

(ShInitBuiltInResources):

  • src/compiler/SymbolTable.cpp:

(TType::TType):
(TType::buildMangledName):
(TType::getStructSize):
(TType::computeDeepestStructNesting):
(TType::isStructureContainingArrays):
(TSymbolTableLevel::relateToExtension):
(TSymbol::TSymbol):
(TVariable::TVariable):
(TVariable::clone):
(TFunction::TFunction):
(TFunction::clone):
(TSymbolTableLevel::clone):
(TSymbolTable::copyTable):

  • src/compiler/SymbolTable.h:

(TVariable::TVariable):
(TVariable::updateArrayInformationType):
(TVariable::getArrayInformationType):
(TParameter::copyParam):
(TFunction::relateToExtension):
(TFunction::getExtension):

  • src/compiler/Types.h:

(NewPoolTTypeList):
(TType::TType):
(TType::copyType):
(TType::clone):
(TType::getObjectSize):
(TType::getMaxArraySize):
(TType::setMaxArraySize):
(TType::clearArrayness):
(TType::setArrayInformationType):
(TType::getArrayInformationType):
(TType::getStruct):
(TType::setStruct):
(TType::getTypeName):
(TType::setTypeName):
(TType::isField):
(TType::getFieldName):
(TType::setFieldName):
(TType::getMangledName):
(TType::getDeepestStructNesting):
(TPublicType::setBasic):

  • src/compiler/VariableInfo.cpp:

(getUserDefinedVariableInfo):

  • src/compiler/builtin_symbol_table.cpp: Removed.
  • src/compiler/builtin_symbol_table.h: Removed.
  • src/compiler/builtin_symbols.json: Removed.
  • src/compiler/generate_builtin_symbol_table.py: Removed.
  • src/compiler/glslang.l:
  • src/compiler/glslang.y:
  • src/compiler/glslang_lex.cpp:

(yy_get_previous_state):
(yy_try_NUL_trans):
(yy_push_state):
(yy_pop_state):
(yy_top_state):
(string_input):
(check_type):
(reserved_word):
(yyerror):
(glslang_scan):

  • src/compiler/glslang_tab.cpp:
  • src/compiler/glslang_tab.h:
  • src/compiler/intermOut.cpp:

(TOutputTraverser::visitUnary):
(TOutputTraverser::visitAggregate):
(TOutputTraverser::visitConstantUnion):

  • src/compiler/intermediate.h:

(TIntermNode::TIntermNode):
(TIntermNode::getLine):
(TIntermNode::setLine):
(TIntermNode::~TIntermNode):
(TIntermConstantUnion::setUnionArrayPointer):
(TIntermAggregate::TIntermAggregate):
(TIntermAggregate::setEndLine):
(TIntermAggregate::getEndLine):
(TIntermTraverser::TIntermTraverser):
(TIntermTraverser::incrementDepth):

  • src/compiler/localintermediate.h:
  • src/compiler/parseConst.cpp:

(TConstTraverser::visitSymbol):
(TConstTraverser::visitBinary):
(TConstTraverser::visitUnary):
(TConstTraverser::visitAggregate):
(TConstTraverser::visitSelection):
(TConstTraverser::visitConstantUnion):
(TConstTraverser::visitLoop):
(TConstTraverser::visitBranch):
(TIntermediate::parseConstTree):

  • src/compiler/timing/RestrictVertexShaderTiming.cpp:

(RestrictVertexShaderTiming::visitSymbol):

  • src/libEGL/Config.cpp: Removed.
  • src/libEGL/Config.h: Removed.
  • src/libEGL/Display.cpp: Removed.
  • src/libEGL/Display.h: Removed.
  • src/libEGL/README: Added.
  • src/libEGL/ShaderCache.h: Removed.
  • src/libEGL/Surface.cpp: Removed.
  • src/libEGL/Surface.h: Removed.
  • src/libEGL/libEGL.cpp: Removed.
  • src/libEGL/libEGL.def: Removed.
  • src/libEGL/libEGL.rc: Removed.
  • src/libEGL/libEGL.vcxproj: Removed.
  • src/libEGL/libEGL.vcxproj.filters: Removed.
  • src/libEGL/main.cpp: Removed.
  • src/libEGL/main.h: Removed.
  • src/libEGL/resource.h: Removed.
  • src/libGLESv2/BinaryStream.h: Removed.
  • src/libGLESv2/Blit.cpp: Removed.
  • src/libGLESv2/Blit.h: Removed.
  • src/libGLESv2/Buffer.cpp: Removed.
  • src/libGLESv2/Buffer.h: Removed.
  • src/libGLESv2/Context.cpp: Removed.
  • src/libGLESv2/Context.h: Removed.
  • src/libGLESv2/D3DConstantTable.cpp: Removed.
  • src/libGLESv2/D3DConstantTable.h: Removed.
  • src/libGLESv2/Fence.cpp: Removed.
  • src/libGLESv2/Fence.h: Removed.
  • src/libGLESv2/Float16ToFloat32.cpp: Removed.
  • src/libGLESv2/Float16ToFloat32.py: Removed.
  • src/libGLESv2/Framebuffer.cpp: Removed.
  • src/libGLESv2/Framebuffer.h: Removed.
  • src/libGLESv2/HandleAllocator.cpp: Removed.
  • src/libGLESv2/HandleAllocator.h: Removed.
  • src/libGLESv2/IndexDataManager.cpp: Removed.
  • src/libGLESv2/IndexDataManager.h: Removed.
  • src/libGLESv2/Program.cpp: Removed.
  • src/libGLESv2/Program.h: Removed.
  • src/libGLESv2/ProgramBinary.cpp: Removed.
  • src/libGLESv2/ProgramBinary.h: Removed.
  • src/libGLESv2/Query.cpp: Removed.
  • src/libGLESv2/Query.h: Removed.
  • src/libGLESv2/README: Added.
  • src/libGLESv2/Renderbuffer.cpp: Removed.
  • src/libGLESv2/Renderbuffer.h: Removed.
  • src/libGLESv2/ResourceManager.cpp: Removed.
  • src/libGLESv2/ResourceManager.h: Removed.
  • src/libGLESv2/Shader.cpp: Removed.
  • src/libGLESv2/Shader.h: Removed.
  • src/libGLESv2/Texture.cpp: Removed.
  • src/libGLESv2/Texture.h: Removed.
  • src/libGLESv2/TextureSSE2.cpp: Removed.
  • src/libGLESv2/VertexDataManager.cpp: Removed.
  • src/libGLESv2/VertexDataManager.h: Removed.
  • src/libGLESv2/libGLESv2.cpp: Removed.
  • src/libGLESv2/libGLESv2.def: Removed.
  • src/libGLESv2/libGLESv2.rc: Removed.
  • src/libGLESv2/libGLESv2.vcxproj: Removed.
  • src/libGLESv2/libGLESv2.vcxproj.filters: Removed.
  • src/libGLESv2/main.cpp: Removed.
  • src/libGLESv2/main.h: Removed.
  • src/libGLESv2/mathutil.h: Removed.
  • src/libGLESv2/resource.h: Removed.
  • src/libGLESv2/shaders/Blit.ps: Removed.
  • src/libGLESv2/shaders/Blit.vs: Removed.
  • src/libGLESv2/shaders/componentmaskps.h: Removed.
  • src/libGLESv2/shaders/flipyvs.h: Removed.
  • src/libGLESv2/shaders/generate_shaders.bat: Removed.
  • src/libGLESv2/shaders/luminanceps.h: Removed.
  • src/libGLESv2/shaders/passthroughps.h: Removed.
  • src/libGLESv2/shaders/standardvs.h: Removed.
  • src/libGLESv2/utilities.cpp: Removed.
  • src/libGLESv2/utilities.h: Removed.
  • src/libGLESv2/vertexconversion.h: Removed.

Source/WebCore:

  • CMakeLists.txt:
11:39 AM Changeset in webkit [152945] by fpizlo@apple.com
  • 4 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: StringObjectUse uses structures, and CSE should know that
​https://bugs.webkit.org/show_bug.cgi?id=118940

Reviewed by Geoffrey Garen.

This is asymptomatic right now, but we should fix it.

(JSC::DFG::CSEPhase::putStructureStoreElimination):

  • dfg/DFGEdgeUsesStructure.h: Added.

(DFG):
(EdgeUsesStructure):
(JSC::DFG::EdgeUsesStructure::EdgeUsesStructure):
(JSC::DFG::EdgeUsesStructure::operator()):
(JSC::DFG::EdgeUsesStructure::result):
(JSC::DFG::edgesUseStructure):

  • dfg/DFGUseKind.h:

(DFG):
(JSC::DFG::usesStructure):

10:58 AM Changeset in webkit [152944] by fpizlo@apple.com
  • 9 edits
    13 adds in branches/dfgFourthTier

fourthTier: String GetByVal out-of-bounds handling is so wrong
​https://bugs.webkit.org/show_bug.cgi?id=118935

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Bunch of String GetByVal out-of-bounds fixes:

  • Even if the string proto chain is sane, we need to watch out for negative indices. They may get values or call getters in the prototypes, since proto sanity doesn't check for negative indexed properties, as they are not technically indexed properties.


  • GetByVal String out-of-bounds does in fact clobberWorld(). CSE should be given this information.


  • GetByVal String out-of-bounds does in fact clobberWorld(). CFA should be given this information.


Also fixed some other things:

  • If the DFG is disabled, the testRunner should pretend that we've done a bunch of DFG compiles. That's necessary to prevent the tests from timing out.


  • Disassembler shouldn't try to dump source code since it's not safe in the concurrent JIT.
  • API/JSCTestRunnerUtils.cpp:

(JSC::numberOfDFGCompiles):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpHeader):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::byValIsPure):

  • dfg/DFGSaneStringGetByValSlowPathGenerator.h: Added.

(DFG):
(SaneStringGetByValSlowPathGenerator):
(JSC::DFG::SaneStringGetByValSlowPathGenerator::SaneStringGetByValSlowPathGenerator):
(JSC::DFG::SaneStringGetByValSlowPathGenerator::generateInternal):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

LayoutTests:

Reviewed by Geoffrey Garen.

  • fast/js/dfg-string-out-of-bounds-check-structure-expected.txt: Added.
  • fast/js/dfg-string-out-of-bounds-check-structure.html: Added.
  • fast/js/dfg-string-out-of-bounds-cse-expected.txt: Added.
  • fast/js/dfg-string-out-of-bounds-cse.html: Added.
  • fast/js/dfg-string-out-of-bounds-negative-check-structure-expected.txt: Added.
  • fast/js/dfg-string-out-of-bounds-negative-check-structure.html: Added.
  • fast/js/dfg-string-out-of-bounds-negative-proto-value-expected.txt: Added.
  • fast/js/dfg-string-out-of-bounds-negative-proto-value.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-string-out-of-bounds-check-structure.js: Added.

(foo):

  • fast/js/script-tests/dfg-string-out-of-bounds-cse.js: Added.

(foo):

  • fast/js/script-tests/dfg-string-out-of-bounds-negative-check-structure.js: Added.

(foo):
(while):

  • fast/js/script-tests/dfg-string-out-of-bounds-negative-proto-value.js: Added.

(foo):

12:26 AM Changeset in webkit [152943] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Pagination: Do not paint the baseBackgroundColor if asked to skipRootBackground.
​https://bugs.webkit.org/show_bug.cgi?id=118933

Reviewed by Simon Fraser.

Captions rendered through TextTrackRepresentation are rendered with a background
color when in paginated views. Do not fill the paint area with the
baseBackgroundColor when the paint flags include SkipRootBackground.

  • rendering/RenderView.cpp:

(WebCore::RenderView::paint):

12:02 AM Changeset in webkit [152942] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.0.4

Tagging the WebKitGTK+ 2.0.4 release

Jul 19, 2013:

11:43 PM Changeset in webkit [152941] by beidson@apple.com
  • 15 edits
    9 adds in trunk

Pages should not be able to abuse users inside beforeunload handlers.
<rdar://problem/14475779> and ​https://bugs.webkit.org/show_bug.cgi?id=118871.

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: fast/loader/show-only-one-beforeunload-dialog.html

http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin.html
http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::handleBeforeUnloadEvent):
(WebCore::FrameLoader::shouldCloseFiringBeforeUnloadEvent): Renamed from fireBeforeUnloadEvent.

Add logic to enforce "1 beforeunload dialog per navigation" as well as "iframes can only show beforeunload
dialogs if their entire ancestry's security origins match the navigating frame."

  • loader/FrameLoader.h:
  • loader/FrameLoader.h:

Add the ability for Page to know when any frame is dispatching beforeunload:

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::incrementFrameHandlingBeforeUnloadEventCount):
(WebCore::Page::decrementFrameHandlingBeforeUnloadEventCount):
(WebCore::Page::isAnyFrameHandlingBeforeUnloadEvent):

  • page/Page.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::print): Disallow if any frame is in beforeunload dispatch.
(WebCore::DOMWindow::alert): Ditto.
(WebCore::DOMWindow::confirm): Ditto.
(WebCore::DOMWindow::prompt): Ditto.
(WebCore::DOMWindow::showModalDialog): Ditto.

LayoutTests:

In addition to the new tests, updated some results of previous tests that were relying on "alert"
as a poor man's logging method.

  • fast/events/onbeforeunload-focused-iframe-expected.txt:
  • fast/events/onbeforeunload-focused-iframe.html:
  • fast/events/onunload-clears-onbeforeunload-expected.txt:
  • fast/events/onunload-clears-onbeforeunload.html:
  • fast/loader/page-dismissal-modal-dialogs-expected.txt:
  • fast/loader/page-dismissal-modal-dialogs.html:
  • fast/loader/recursive-before-unload-crash-expected.txt:
  • fast/loader/recursive-before-unload-crash.html:
  • fast/loader/resources/iframe-with-beforeunload.html: Added.
  • fast/loader/show-only-one-beforeunload-dialog-expected.txt: Added.
  • fast/loader/show-only-one-beforeunload-dialog.html: Added.
  • http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-matching-ancestor-securityorigin.html: Added.
  • http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin-expected.txt: Added.
  • http/tests/misc/iframe-beforeunload-dialog-not-matching-ancestor-securityorigin.html: Added.
  • http/tests/misc/resources/iframe-with-beforeunload.html: Added.
  • http/tests/misc/resources/notify-done.html: Added.
11:42 PM Changeset in webkit [152940] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 2.0.4 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.0.4.
8:37 PM Changeset in webkit [152939] by Chris Fleizach
  • 5 edits in trunk

AX: VoiceOver not detecting misspelled words don't work in all cases
​https://bugs.webkit.org/show_bug.cgi?id=118924

Reviewed by Tim Horton.

Source/WebCore:

VoiceOver is now looking for a new misspelled attribute.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetSpelling):
(AXAttributedStringAppendText):

Tools:

Make the misspelled detection dependent on both types of attributes being present.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::attributedStringRangeIsMisspelled):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):

7:59 PM Changeset in webkit [152938] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Extract computeRenderStyleForProperty and nodeOrItsAncestorNeedsStyleRecalc from ComputedStyleExtractor::propertyValue
​https://bugs.webkit.org/show_bug.cgi?id=118930

Reviewed by Andreas Kling.

Extracted two functions as a preparation to fix bugs 118032 and 118618.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::nodeOrItsAncestorNeedsStyleRecalc):
(WebCore::computeRenderStyleForProperty):
(WebCore::ComputedStyleExtractor::propertyValue):

7:53 PM Changeset in webkit [152937] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure::isValidOffset() should be able to tell you if you're loading a valid JSValue, and not just not crashing
​https://bugs.webkit.org/show_bug.cgi?id=118911

Reviewed by Geoffrey Garen.

We could also have a separate method like "willNotCrash(offset)", but that's not
what isValidOffset() is intended to mean.

  • runtime/Structure.h:

(JSC::Structure::isValidOffset):

6:32 PM Changeset in webkit [152936] by Stephanie Lewis
  • 2 edits in trunk/Tools

<rdar://problem/14499595> pagination wk2 api test failing on ML (118928)

Unreviewed.

Rebaseline pagination test after ​http://trac.webkit.org/changeset/152911

  • TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::didLayout):

5:58 PM Changeset in webkit [152935] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Cache style declaration CSSOM wrappers directly on MutableStylePropertySet.
<​http://webkit.org/b/118883>

Reviewed by Gavin Barraclough

Merge ​https://chromium.googlesource.com/chromium/blink/+/183bcd51eb0e79cab930cf46695df05dc793630f
From Blink r153700 by <​ager@chromium.org>:

In my measurements the mapping is adding more overhead than just having a field
in all MutableStylePropertySet objects. So this saves memory and makes access
faster.

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::MutableStylePropertySet):
(WebCore::MutableStylePropertySet::~MutableStylePropertySet):
(WebCore::StylePropertySet::hasCSSOMWrapper):
(WebCore::MutableStylePropertySet::cssStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureCSSStyleDeclaration):
(WebCore::MutableStylePropertySet::ensureInlineCSSStyleDeclaration):

  • css/StylePropertySet.h:

(WebCore::StylePropertySet::StylePropertySet):

5:11 PM Changeset in webkit [152934] by achristensen@apple.com
  • 3 edits in trunk/Tools

Improved code coverage generation.
​https://bugs.webkit.org/show_bug.cgi?id=118926

Reviewed by Tim Horton.

  • Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
  • Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.

(generateReport): Moved report generation to a subroutine.

4:30 PM Changeset in webkit [152933] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix on Windows after r152930.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Added missing close paren.
4:08 PM Changeset in webkit [152932] by Stephanie Lewis
  • 2 edits in trunk/LayoutTests

Some compositing tests fail on ML WK2 Debugi
​https://bugs.webkit.org/show_bug.cgi?id=118925

Unreviewed.

  • platform/mac-wk2/TestExpectations:
3:46 PM Changeset in webkit [152931] by dbates@webkit.org
  • 2 edits in trunk/Tools

Make Perl tools work when using git bisect with Git branch build setup
​https://bugs.webkit.org/show_bug.cgi?id=118512

Reviewed by Martin Robinson.

The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
during a git bisect session with a Git branch build setup (i.e. git config
core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
specific build of WebKit because they cannot determine the branch Git is on (since
git bisect puts Git into a detached HEAD state). We should teach our tooling to
parse the file .git/BISECT_START (created by git bisect start) for the name of the
branch Git was on when we began a git bisect session. Then the tools can determine
the path to the built WebKit.

  • Scripts/VCSUtils.pm:

(gitDirectory): Added.
(gitBisectStartBranch): Added.
(gitBranch): Modified to call gitBisectStartBranch() when we have a detached
HEAD (e.g. running git bisect).
(determineVCSRoot): Modified to call gitDirectory() to determine the path to
the .git directory in the Git checkout.

3:44 PM Changeset in webkit [152930] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Added 64-bit symbols to WebKitExports.def.in for 64-bit Windows builds
and a macro to only use them for 64-bit builds.
​https://bugs.webkit.org/show_bug.cgi?id=118887

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Added 64-bit symbols.
  • WebKit.vcxproj/WebKitExportGenerator/make-export-file-generator:

Added support for new symbolWithPointer macro.

3:07 PM Changeset in webkit [152929] by achristensen@apple.com
  • 2 edits
    1 add in trunk/Source/ThirdParty/ANGLE

Generate derived files in ANGLE at build time rather than when updating from upstream.
​https://bugs.webkit.org/show_bug.cgi?id=118872

Reviewed by Mark Rowe.

  • ANGLE.xcodeproj/project.pbxproj: Made Derived Sources target which calls DerivedSources.make,

moved generated files into Derived Sources group.

  • DerivedSources.make: Added.
2:51 PM Changeset in webkit [152928] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip failing tests to make WinEWS bots happy.

  • platform/win/TestExpectations:
2:40 PM Changeset in webkit [152927] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Windows] Avoid passing addresses of temporaries to Windows API.
​https://bugs.webkit.org/show_bug.cgi?id=118917

Reviewed by Anders Carlsson.

The temporary Vector returned by String::charactersWithNullTermination
was going out of scope before its first use, causing Windows API to
receive garbage memory.

  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):

  • platform/win/PasteboardWin.cpp:

(WebCore::createGlobalHDropContent):

  • platform/win/SSLKeyGeneratorWin.cpp:

(WebCore::WebCore::signedPublicKeyAndChallengeString):

1:54 PM Changeset in webkit [152926] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unskip flaky tests on AppleWin.
Flakiness is not an issue with the tests themselves but with the test infrastructure.

  • platform/win/TestExpectations:
1:32 PM Changeset in webkit [152925] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shapes] Remove lineWithinShapeBounds() from ShapeInfo since it's no longer used
​https://bugs.webkit.org/show_bug.cgi?id=118913

Reviewed by Andreas Kling.

No new tests, no behavior change.

  • rendering/shapes/ShapeInfo.h: Remove lineWithinShapeBounds().
1:30 PM Changeset in webkit [152924] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip some flaky tests on AppleWin port.

  • platform/win/TestExpectations:
1:14 PM Changeset in webkit [152923] by commit-queue@webkit.org
  • 3 edits
    17 adds
    48 deletes in trunk/LayoutTests

More conversions from MathML pixel tests to reftests.
​https://bugs.webkit.org/show_bug.cgi?id=118853

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-07-19
Reviewed by Chris Fleizach.

  • mathml/presentation/fenced-expected.html: Added.
  • mathml/presentation/fenced-mi-expected.html: Added.
  • mathml/presentation/fenced-mi.html: Added.
  • mathml/presentation/fenced-mi.xhtml: Removed.
  • mathml/presentation/fenced.html: Added.
  • mathml/presentation/fenced.xhtml: Removed.
  • mathml/presentation/mroot-pref-width-expected.html: Added.
  • mathml/presentation/mroot-pref-width.html:
  • mathml/presentation/row-alignment.xhtml: Removed.
  • mathml/presentation/style-border-padding-background-expected.html: Added.
  • mathml/presentation/style-border-padding-background.html: Added.
  • mathml/presentation/style-color-sqrt-expected-mismatch.html: Added.
  • mathml/presentation/style-color-sqrt.html: Added.
  • mathml/presentation/style.xhtml: Removed.
  • mathml/presentation/tables-columnalign-expected.html: Added.
  • mathml/presentation/tables-columnalign.html: Added.
  • mathml/presentation/tables-simple-expected.html: Added.
  • mathml/presentation/tables-simple.html: Added.
  • mathml/presentation/tables-spans-dynamic-expected.html: Added.
  • mathml/presentation/tables-spans-dynamic.html: Added.
  • mathml/presentation/tables-spans-expected.html: Added.
  • mathml/presentation/tables-spans.html: Added.
  • mathml/presentation/tables.xhtml: Removed.
  • mathml/xHeight.xhtml: Removed.
  • platform/efl/mathml/presentation/fenced-expected.png: Removed.
  • platform/efl/mathml/presentation/fenced-expected.txt: Removed.
  • platform/efl/mathml/presentation/fenced-mi-expected.png: Removed.
  • platform/efl/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/efl/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/efl/mathml/presentation/mroot-pref-width-expected.txt: Removed.
  • platform/efl/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/efl/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/efl/mathml/presentation/style-expected.png: Removed.
  • platform/efl/mathml/presentation/style-expected.txt: Removed.
  • platform/efl/mathml/presentation/tables-expected.png: Removed.
  • platform/efl/mathml/presentation/tables-expected.txt: Removed.
  • platform/efl/mathml/xHeight-expected.png: Removed.
  • platform/efl/mathml/xHeight-expected.txt: Removed.
  • platform/gtk/mathml/presentation/fenced-expected.png: Removed.
  • platform/gtk/mathml/presentation/fenced-expected.txt: Removed.
  • platform/gtk/mathml/presentation/fenced-mi-expected.png: Removed.
  • platform/gtk/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/gtk/mathml/presentation/mroot-pref-width-expected.txt: Removed.
  • platform/gtk/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/gtk/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/gtk/mathml/presentation/style-expected.png: Removed.
  • platform/gtk/mathml/presentation/style-expected.txt: Removed.
  • platform/gtk/mathml/presentation/tables-expected.png: Removed.
  • platform/gtk/mathml/presentation/tables-expected.txt: Removed.
  • platform/gtk/mathml/xHeight-expected.png: Removed.
  • platform/gtk/mathml/xHeight-expected.txt: Removed.
  • platform/mac/TestExpectations:
  • platform/mac/mathml/presentation/fenced-expected.png: Removed.
  • platform/mac/mathml/presentation/fenced-expected.txt: Removed.
  • platform/mac/mathml/presentation/fenced-mi-expected.png: Removed.
  • platform/mac/mathml/presentation/fenced-mi-expected.txt: Removed.
  • platform/mac/mathml/presentation/mroot-pref-width-expected.png: Removed.
  • platform/mac/mathml/presentation/mroot-pref-width-expected.txt: Removed.
  • platform/mac/mathml/presentation/row-alignment-expected.png: Removed.
  • platform/mac/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/mac/mathml/presentation/style-expected.png: Removed.
  • platform/mac/mathml/presentation/style-expected.txt: Removed.
  • platform/mac/mathml/presentation/tables-expected.png: Removed.
  • platform/mac/mathml/presentation/tables-expected.txt: Removed.
  • platform/mac/mathml/xHeight-expected.png: Removed.
  • platform/mac/mathml/xHeight-expected.txt: Removed.
1:04 PM Changeset in webkit [152922] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk/Source/WebKit2

[GTK] Need a way to enable region based columns from the command line
​https://bugs.webkit.org/show_bug.cgi?id=116611

Patch by Morten Stenshorne <​mstensho@opera.com> on 2013-07-19
Reviewed by Martin Robinson.

Add an environment variable to enable experimental features.

This provides a means to enable experimental features without polluting
the public API.

Environment variable name: WEBKITGTK_EXPERIMENTAL_FEATURES

Format: WEBKITGTK_EXPERIMENTAL_FEATURES="<feature1>=1,<feature2>=1,..."
Or, to enable all experimental features: WEBKITGTK_EXPERIMENTAL_FEATURES=all

So far the only feature is region based columns (implement multicol using
the CSS regions implementation rather than ColumnInfo & co) - REGION_BASED_COLUMNS.

Example: WEBKITGTK_EXPERIMENTAL_FEATURES="REGION_BASED_COLUMNS=1"

  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed):
(webkit_settings_class_init):

  • UIProcess/gtk/ExperimentalFeatures.cpp: Added.

(WebKit):
(Setting):
(WebKit::ExperimentalFeatures::ExperimentalFeatures):
(WebKit::ExperimentalFeatures::isEnabled):
(WebKit::ExperimentalFeatures::setEnableByName):
(WebKit::ExperimentalFeatures::parseEnvironment):

  • UIProcess/gtk/ExperimentalFeatures.h: Added.

(WebKit):
(ExperimentalFeatures):

12:43 PM Changeset in webkit [152921] by achristensen@apple.com
  • 40 edits in trunk

Added x64 configuration to Visual Studio build.
​https://bugs.webkit.org/show_bug.cgi?id=118888

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Source/ThirdParty:

  • gtest/msvc/gtest-md.vcxproj:

Source/WebCore:

  • WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCoreGenerated.vcxproj:
  • WebCore.vcxproj/WebCoreTestSupport.vcxproj:

Source/WebKit:

  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.vcxproj/WTFGenerated.vcxproj:

Tools:

  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
  • DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
  • WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
  • win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
  • win/record-memory/record-memory.vcxproj:
12:42 PM Changeset in webkit [152920] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip some flaky tests on AppleWin port.

  • platform/win/TestExpectations:
12:21 PM Changeset in webkit [152919] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Spatial Navigation handling of space key in <select> appears to confuse listIndex and optionIndex.
​https://bugs.webkit.org/show_bug.cgi?id=99525

Source/WebCore:

HTMLSelect Element inherently contains the logic to focus option node and thus, implementing an explicit logic to find the focus index is not required.

Patch by Abhijeet Kandalkar <​abhijeet.k@samsung.com> on 2013-07-19
Reviewed by Joseph Pecoraro.

Test: fast/spatial-navigation/snav-multiple-select-optgroup.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):

LayoutTests:

Added testcase to test support of option group within HTMLSelect element.

Patch by Abhijeet Kandalkar <​abhijeet.k@samsung.com> on 2013-07-19
Reviewed by Joseph Pecoraro.

  • fast/spatial-navigation/snav-multiple-select-optgroup-expected.txt: Added.
  • fast/spatial-navigation/snav-multiple-select-optgroup.html: Added.
11:56 AM Changeset in webkit [152918] by Lucas Forschler
  • 2 edits in branches/safari-537-branch/Source/WebKit2

Merged r152877. <rdar://problem/14271327>

11:55 AM Changeset in webkit [152917] by Lucas Forschler
  • 3 edits in branches/safari-537-branch/Source/JavaScriptCore

Merged r152818. <rdar://problem/14473897>

11:54 AM Changeset in webkit [152916] by Lucas Forschler
  • 12 edits
    12 copies in branches/safari-537-branch

Merged r152813. <rdar://problem/14473897>

11:51 AM Changeset in webkit [152915] by Lucas Forschler
  • 2 edits in tags/Safari-537.51.3/Source/WebKit2

Merged r152877. <rdar://problem/14271327>

11:49 AM Changeset in webkit [152914] by Lucas Forschler
  • 3 edits in tags/Safari-537.51.3/Source/JavaScriptCore

Merged r152818. <rdar://problem/14473897>

11:46 AM Changeset in webkit [152913] by Lucas Forschler
  • 12 edits
    12 copies in tags/Safari-537.51.3

Merged r152813. <rdar://problem/14473897>

11:38 AM Changeset in webkit [152912] by Lucas Forschler
  • 5 edits in tags/Safari-537.51.3/Source

Versioning.

11:37 AM Changeset in webkit [152911] by hyatt@apple.com
  • 14 edits
    50 adds in trunk

OSX: ePub: Unable to select text in vertical Japanese book
​https://bugs.webkit.org/show_bug.cgi?id=118864
<rdar://problem/14109351>

Reviewed by Dan Bernstein and Sam Weinig.

Source/WebCore:

This patch fixes all of the various writing-mode and pagination combinations
so that the columns are painted in the correct location. The code that sets up
the initial painting translation offset in the block direction and that advances
that offset has been pulled into two helper functions, initialBlockOffsetForPainting
and blockDeltaForPaintingNextColumn, and that code is now shared by the four call
sites that need it (painting and hit testing in RenderBlock and painting and hit testing
in RenderLayer).

This patch also backs out the maximumScrollPosition change, since it only occurred because
of incorrect sizing of the RenderView, and this sizing issue has now been corrected by
ensuring that computeLogicalHeight() always makes sure you are the size of the viewport
and does not shrink you to the column height.

There was also a race condition that caused pagination to be incorrect if layout occurred
before the html/body renderer that set the writing-mode were available. When this happened,
the writing mode got propagated up to the view, but the column styles didn't get
adjusted to compensate for the writing mode change.

Added tests for every pagination and writing-mode combination in fast/multicol/pagination.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForDocument):
(WebCore::StyleResolver::adjustRenderStyle):
Move setStylesForPaginationMode into RenderStyle and make it a member function. This is
necessary so that the style can be adjusted dynamically to fix the race condition mentioned
above.

  • page/FrameView.cpp:

(WebCore::FrameView::maximumScrollPosition):
Back out this change since the symptom it was fixing only occurred because the logical
height of the view was being set incorrectly.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
Patch the column code that sets up the initial page height to use the pagination API's
page height rather than the viewport logical height. This allows the view to still match
the viewport in dimensions rather than being incorrectly sized to the column height.

(WebCore::RenderBlock::initialBlockOffsetForPainting):
(WebCore::RenderBlock::blockDeltaForPaintingNextColumn):
Two new helper functions used to set up the block direction paint/hit testing translation.
The major bug fix that occurred in this code is that the old block axis code didn't handle
reversal correctly and it also used physical coordinates to try to determine the translation
offset, when you really need to use logical coordinates in the original writing mode coordinate
system to determine the offset.

(WebCore::RenderBlock::paintColumnContents):
Patched to call the new helper functions.

(WebCore::ColumnRectIterator::ColumnRectIterator):
(WebCore::ColumnRectIterator::adjust):
(WebCore::ColumnRectIterator::update):
Patched to call the new helper functions.

  • rendering/RenderBlock.h:

Add the two new helper functions to the RenderBlock header.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
If the writing mode of the html/body propagates to the viewport and changes its writing mode,
also change our column styles to match if we're in paginated mode.

(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
Call the new pageOrViewLogicalHeight function on RenderView instead of
RenderBox::viewLogicalHeightForPercentages (which is now removed).

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
Patched to use the two new helper functions for block direction paint offset setup and
advancement.

  • rendering/RenderView.cpp:

(WebCore::RenderView::pageOrViewLogicalHeight):
New helper function that does what viewLogicalHeightForPercentages used to do but also
handles returning the page length for block axis column progression. Again, this is to
allow the view to retain its correct size (matching the viewport).

(WebCore::RenderView::viewLogicalHeight):
Back out the code that made the view grow or shrink to the size of the Pagination API page
length when the progression was block axis. This was the source of most of the scroll origin
and scrolling issues.

  • rendering/RenderView.h:

Add the new pageOrViewLogicalHeight() function.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setColumnStylesFromPaginationMode):
This is the old StyleResolver function for setting up the column styles. It's in RenderStyle
now so that it can be called at any time to change a style rather than only at style resolution
time.

  • rendering/style/RenderStyle.h:

Declaration of the setColumnStylesFromPaginationMode function.

LayoutTests:

  • fast/multicol/pagination: Added.
  • fast/multicol/pagination/BottomToTop-bt.html: Added.
  • fast/multicol/pagination/BottomToTop-lr.html: Added.
  • fast/multicol/pagination/BottomToTop-rl.html: Added.
  • fast/multicol/pagination/BottomToTop-tb.html: Added.
  • fast/multicol/pagination/LeftToRight-bt.html: Added.
  • fast/multicol/pagination/LeftToRight-lr.html: Added.
  • fast/multicol/pagination/LeftToRight-rl.html: Added.
  • fast/multicol/pagination/LeftToRight-tb.html: Added.
  • fast/multicol/pagination/RightToLeft-bt.html: Added.
  • fast/multicol/pagination/RightToLeft-lr.html: Added.
  • fast/multicol/pagination/RightToLeft-rl.html: Added.
  • fast/multicol/pagination/RightToLeft-tb.html: Added.
  • fast/multicol/pagination/TopToBottom-bt.html: Added.
  • fast/multicol/pagination/TopToBottom-lr.html: Added.
  • fast/multicol/pagination/TopToBottom-rl.html: Added.
  • fast/multicol/pagination/TopToBottom-tb.html: Added.
  • platform/mac/fast/multicol/pagination: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.txt: Added.
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.png:
  • platform/mac/fast/multicol/shrink-to-column-height-for-pagination-expected.txt:
11:31 AM Changeset in webkit [152910] by Lucas Forschler
  • 1 copy in tags/Safari-537.51.3

New Tag.

11:14 AM Changeset in webkit [152909] by fpizlo@apple.com
  • 13 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Structure should be able to tell you if it's valid to load at a given offset from any object with that structure
​https://bugs.webkit.org/show_bug.cgi?id=118878

Reviewed by Oliver Hunt.

  • Change Structure::isValidOffset() to actually answer the question "If I attempted to load from an object of this structure, at this offset, would I commit suicide or would I get back some kind of value?"


  • Change StorageAccessData::offset to use a PropertyOffset. It should have been that way from the start.


  • Fix PutStructure so that it sets haveStructures in all of the cases that it should.


  • Make GetByOffset also reference the base object in addition to the butterfly.


The future use of this power will be to answer questions like "If I hoisted this
GetByOffset or PutByOffset to this point, would it cause crashes, or would it be
fine?"

I don't currently plan to use this power to perform validation, since the CSE has
the power to eliminate CheckStructure's that the CFA wouldn't be smart enough to
remove - both in the case of StructureSets where size >= 2 and in the case of
CheckStructures that match across PutStructures. At first I tried to write a
validator that was aware of this, but the validation code got way too complicated
and I started having nightmares of spurious assertion bugs being filed against me.

This also changes some of the code for how we hash FunctionExecutable's for debug
dumps, since that code still had some thread-safety issues. Basically, the
concurrent JIT needs to use the CodeBlock's precomputed hash and never call anything
that could transitively try to compute the hash from the source code. The source
code is a string that may be lazily computed, and that involves all manner of thread
unsafe things.

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::hash):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetByOffset):
(JSC::DFG::ByteCodeParser::handlePutByOffset):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(StorageAccessData):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetByOffset):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compilePutByOffset):

  • runtime/FunctionExecutableDump.cpp:

(JSC::FunctionExecutableDump::dump):

  • runtime/Structure.h:

(Structure):
(JSC::Structure::isValidOffset):

10:52 AM Changeset in webkit [152908] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Curl] Http response code 401 (Authentication required) is not handled.
​https://bugs.webkit.org/show_bug.cgi?id=118849

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-07-19
Reviewed by Brent Fulgham.

The current Curl implementation does not handle a 401 response.
When receiving http code 401, we need to give a notification that authorization is required, by calling the appropriate notification method.
This gives a WebKit client the possibility to present a password dialog to the user.
In response to this, we should provide Curl with the given username and password, so another request can be sent with the given credentials.

Source/WebCore:

  • platform/network/ResourceHandle.h:

Added method to check if credential storage should be used.

  • platform/network/ResourceHandleInternal.h:

Added member to keep track of number of authentication failures.

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::shouldUseCredentialStorage):

Added method to check if credential storage should be used.

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):

Implement method; notify client when authentication is required.

(WebCore::ResourceHandle::receivedCredential):

Implement method; provide Curl with password and username when available.

(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):

Implement method; reset Curl username and password.

(WebCore::ResourceHandle::receivedCancellation):

Implement method; notify client that authorization has been cancelled.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::isHttpAuthentication):

Added function to check if http code is an 'Authorization required' code.

(WebCore::getProtectionSpace):

Added function to initialize a protection space object from a Curl handle and a response object.

(WebCore::headerCallback):

Notify client when authorization is required.

(WebCore::ResourceHandleManager::applyAuthenticationToRequest):

Added method to set Curl username and password.

(WebCore::ResourceHandleManager::initializeHandle):

Use method to set Curl username and password.

  • platform/network/curl/ResourceHandleManager.h:

Added method to set Curl username and password.

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):

Implement empty method; use the same implementation as the CFNetwork version does,
notify delegate when authorization is required.

  • WebURLAuthenticationChallengeSenderCurl.cpp:

(WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):

Implement empty method; use the same implementation as the CFNetwork version does.

(WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):

Implement empty method; use the same implementation as the CFNetwork version does.

(WebURLAuthenticationChallengeSender::useCredential):

Implement empty method; use the same implementation as the CFNetwork version does.

10:47 AM Changeset in webkit [152907] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Hover doesn't work for block elements inside a href element
​https://bugs.webkit.org/show_bug.cgi?id=118907

Patch by Radu Stavila <​stavila@adobe.com> on 2013-07-19
Reviewed by David Hyatt.

Source/WebCore:

Added test for hovering block elements inside a href element.

Test: fast/css/hover-display-block.html

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::hoverAncestor):

LayoutTests:

Don't skip all anonymous objects when searching for the hover ancestor, only the ones
directly flowed into a region.

  • fast/css/hover-display-block-expected.txt: Added.
  • fast/css/hover-display-block.html: Added.
10:46 AM Changeset in webkit [152906] by zoltan@webkit.org
  • 5 edits in trunk

[CSS Shapes] Clear overflowing line's segments in pushShapeContentOverflowBelowTheContentBox
​https://bugs.webkit.org/show_bug.cgi?id=118002

Reviewed by David Hyatt.

When the last line in the shape overlaps with the shape bottom boundaries we need to clear the computed segments. (We need to compute
the segments anyway, since shape-outside's code uses the same code path to determine its segments and the line containing is not a
requirement in that case.) Rather then doing the job in RenderBlock::LineBreaker::nextLineBreak I moved the functionality to its correct
place to pushShapeContentOverflowBelowTheContentBox. Now all the overflow related functionality is located in one function. I fixed the
corresponding layout test.

Source/WebCore:

Tests: I modified shape-inside-overflow.html.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::pushShapeContentOverflowBelowTheContentBox): Remove segments if line overlaps with the shape's boundaries.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Move segments clear logic to pushShapeContentOverflowBelowContentBox.

LayoutTests:

  • fast/shapes/shape-inside/shape-inside-overflow-expected.html:
  • fast/shapes/shape-inside/shape-inside-overflow.html:
10:43 AM Changeset in webkit [152905] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

TrailingObjects shouldn't shrink vector capacity in a loop
​https://bugs.webkit.org/show_bug.cgi?id=118322

Reviewed by Darin Adler.

This seems to take about 3% off the profile of loading a large text file.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::TrailingObjects::clear): clear() has the built-in side effect
of throwing away existing capacity. Use shrink(0) to indicate that we
want to keep our existing capacity.

10:40 AM Changeset in webkit [152904] by zoltan@webkit.org
  • 7 edits in trunk/LayoutTests

[CSS Shapes][CSS Regions] Modify existing tests to test overflow also when padding is applied on the container
​https://bugs.webkit.org/show_bug.cgi?id=117881

Reviewed by David Hyatt.

Currently, we don't have tests which test the overflow behavior when there is padding applied on the container.
I modified the existing tests to cover these cases as well and increase our test coverage.

  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
  • fast/shapes/shape-inside/shape-inside-overflow-fixed-dimensions.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html:
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html:
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html:
10:33 AM Changeset in webkit [152903] by Martin Robinson
  • 3 edits in trunk/Tools

Add a couple people to the MathML watchlist
​https://bugs.webkit.org/show_bug.cgi?id=118909

Reviewed by Andreas Kling.

Add a couple people to the MathML watchlist and add Kalyan's other
email address to fix style checker warnings about the watchlist
contents.

  • Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the

list of contributors and add Kalyan's second email address.

  • Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML

watchlist.

9:13 AM Changeset in webkit [152902] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Update test expectations for MathML after r152840.
​https://bugs.webkit.org/show_bug.cgi?id=118053

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-07-19
Reviewed by Chris Fleizach.

  • TestExpectations: unskip mspace tests
  • platform/mac/TestExpectations: ImageOnlyFailure for mspace-units
8:21 AM Changeset in webkit [152901] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/LayoutTests

[GTK] Unreviewed gardening. Update expectations after r152793, r152777 and r152872
​https://bugs.webkit.org/show_bug.cgi?id=118906

Unreviewed GTK gardening.

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-19

  • platform/gtk/TestExpectations: Mark svg/animations/svgenum-animation-6.html as flaky, and

mathml/presentation/bug95404.html, introduced in r152777, as ImageOnlyFailure.

  • platform/gtk/editing/pasteboard/emacs-cntl-y-001-expected.txt: New baseline after r152872.
  • platform/gtk/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt: Ditto.
  • platform/gtk/fast/dom/Range/getClientRects-expected.txt: Ditto.
  • platform/gtk/fast/js/function-length-expected.txt: Ditto.
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-expected.txt: Added after r152872.
  • platform/gtk/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added after r152872.
  • platform/gtk/tables/mozilla/marvin/backgr_index-expected.txt: New baseline after r152793.
6:37 AM Changeset in webkit [152900] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] More unreviewed cleanup for pixel tester bot.

  • platform/qt-5.0-wk2/TestExpectations:
6:27 AM Changeset in webkit [152899] by zarvai@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed cleanup for pixel tester bot.

  • platform/qt-5.0-wk2/TestExpectations:
5:46 AM Changeset in webkit [152898] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Merge decamelizations fix ups in the GObject DOM bindings code generator
​https://bugs.webkit.org/show_bug.cgi?id=117543

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-07-19
Reviewed by Carlos Garcia Campos.

Ensure that all the code that calls to decamelize() applies the same fix ups

Now all functions that need to decamelize a string should simply call
to decamelize(). This function calls to FixUpDecamelize to apply some
fix ups.

  • bindings/scripts/CodeGeneratorGObject.pm:

(decamelize): decamelizes a string and applies fix ups
(FixUpDecamelize): applies a series of fix ups to a decamelized string
(GetParentGObjType): moved fix ups to FixUpDecamelize()
(GenerateProperties): simply call to decamelize
(GenerateHeader): simply call to decamelize
(GetGReturnMacro): simply call to decamelize
(GenerateFunction): simply call to decamelize
(GenerateCFile): simply call to decamelize
(GenerateEventTargetIface): simply call to decamelize

5:18 AM Changeset in webkit [152897] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
​https://bugs.webkit.org/show_bug.cgi?id=118895

Patch by Simon Pena <​simon.pena@samsung.com> on 2013-07-19
Reviewed by Philippe Normand.

In r152782 an uri is used to create an string representation without checking first if it
is valid. That fails later when the string is used to check for existing redirections. This
patch ensures that the uri is valid before using it.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(willSendRequestCallback): Ensure an uri is valid before using it.

5:13 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:11 AM Changeset in webkit [152896] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r152340 - [WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
​https://bugs.webkit.org/show_bug.cgi?id=118280

Reviewed by Darin Adler.

Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):

5:09 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
5:07 AM Changeset in webkit [152895] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge r151674 - [GTK][GStreamer] Fullscreen option in video element context menu not working
​https://bugs.webkit.org/show_bug.cgi?id=105191

.:

Fullscreen with native controls is outdated and even broken in
[GTK][WK2], so they are deactivated for now.

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-06-18
Reviewed by Philippe Normand.

  • Source/autotools/SetupAutoconfHeader.m4: Removed the use of

fullscreen native media controls.

4:52 AM Changeset in webkit [152894] by kseo@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed.

Fix an assertion failure which causes debug bots to fail.

  • platform/network/NetworkStateNotifier.cpp:

(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):

3:31 AM Changeset in webkit [152893] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] media/video-seek-multiple.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=117580

Patch by Miguel Gomez <​magomez@igalia.com> on 2013-07-19
Reviewed by Philippe Normand.

Source/WebCore:

When receiving several seek calls in a row, ensure that the final position
is the one requested in the last call received.

Already covered in test media/video-seek-multiple.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::seek):

LayoutTests:

Change expectation for media/video-seek-multiple.html test

  • platform/gtk/TestExpectations:
3:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:26 AM Changeset in webkit [152892] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r149543 - [GStreamer] GStreamer log crashes in MediaPlayerPrivateGStreamerBase because of uninitialized category
​https://bugs.webkit.org/show_bug.cgi?id=115575

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-05-03
Reviewed by Philippe Normand.

No new tests needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

Using extern debug category.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Declaring debug category as not static.

3:21 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
3:19 AM Changeset in webkit [152891] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.0

Merge r148131 - Clicking on the volume slider of HTML5 elements is pausing sometimes
​https://bugs.webkit.org/show_bug.cgi?id=112548

Patch by Xabier Rodriguez Calvar <​calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/click-volume-bar-not-pausing.html

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.

LayoutTests:

Added test.

  • media/click-volume-bar-not-pausing-expected.txt: Added.
  • media/click-volume-bar-not-pausing.html: Added.
3:13 AM Changeset in webkit [152890] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.0

Merge r152712 - [GTK] Remove compile warnings about GTK+ API deprecated after 3.6
​https://bugs.webkit.org/show_bug.cgi?id=118237

Reviewed by Philippe Normand.

We depend on GTK+3.6 so we are not interested in compile warnings
about deprecated API after 3.6

  • Source/autotools/SetupAutoconfHeader.m4: Define

GDK_VERSION_MIN_REQUIRED in config.h.

2:10 AM Changeset in webkit [152889] by kangil.han@samsung.com
  • 9 edits in trunk/Source/WebCore

Use explicit HTMLFrameElementBase cast and introduce toHTMLFrameElementBase
​https://bugs.webkit.org/show_bug.cgi?id=118873

Reviewed by Ryosuke Niwa.

It should be HTMLFrameElementBase that embraces both HTMLFrameElement and HTMLIFrameElement.
This also makes correct toFooElement possible.
Next, to avoid direct use of static_cast, this patch introduces toHTMLFrameElementBase for code cleanup.

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::didNotifySubtreeInsertions):

  • html/HTMLFrameElementBase.h:

(WebCore::toHTMLFrameElementBase):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadSubframe):

  • page/EventHandler.cpp:

(WebCore::targetIsFrame):

  • page/FrameView.cpp:

(WebCore::FrameView::init):

  • rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

  • rendering/RenderLayer.cpp:

(WebCore::frameElementAndViewPermitScroll):
(WebCore::RenderLayer::scrollRectToVisible):

1:38 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
1:36 AM Changeset in webkit [152888] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r152552 - Fix build against GTK+ 2.0
​https://bugs.webkit.org/show_bug.cgi?id=117895

Patch by Dominique Leuenberger <​dimstar@opensuse.org> on 2013-07-10
Reviewed by Martin Robinson.

GTK2 build fails for undefined GDK_IS_X11_DISPLAY
GTK 2.0 does define GDK_WINDOWING_X11,but GDK_IS_X11_DISPLAY is not
present in GTK+ 2.0. A dummy defines is sufficient, as GTK 2.0 is not
that multiple backend aware anyway...

  • platform/gtk/GtkVersioning.h: Define GDK_IS_X11_DISPLAY for GTK+ 2.0 and compatibility for gtk_widget_get_preferred_size()
  • plugins/gtk/gtk2xtbin.c: Include config.h
1:22 AM Changeset in webkit [152887] by zarvai@inf.u-szeged.hu
  • 5 edits
    1 copy in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebase failing tests.

Patch by Gabor Abraham <​abrhm@inf.u-szeged.hu> on 2013-07-19

  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.txt: Copied from LayoutTests/platform/qt/tables/mozilla/marvin/backgr_index-expected.txt.
  • platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
  • platform/qt/http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
  • platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:
Note: See TracTimeline for information about the timeline view.