Timeline
Nov 21, 2013:
- 9:12 PM Changeset in webkit [159681] by
-
- 3 edits2 deletes in trunk/Source
Remove ANGLEGenerated from Windows build.
https://bugs.webkit.org/show_bug.cgi?id=124759
Patch by Alex Christensen <achristensen@webkit.org> on 2013-11-21
Reviewed by Darin Adler.
Source/ThirdParty/ANGLE:
- ANGLE.vcxproj/ANGLEGenerated.vcxproj: Removed.
- ANGLE.vcxproj/ANGLEGenerated.vcxproj.filters: Removed.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Remove references to ANGLEGenerated.vcxproj.
- 9:03 PM Changeset in webkit [159680] by
-
- 6 edits2 adds in trunk
Map the dir attribute to the CSS direction property.
https://bugs.webkit.org/show_bug.cgi?id=124572.
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-11-21
Reviewed by Darin Adler.
Source/WebCore:
Test: mathml/presentation/mstyle-css-attributes.html
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPresentationAttribute): reorder attributes
(WebCore::MathMLElement::collectStyleForPresentationAttribute): reorder tags that accept dir
(WebCore::MathMLElement::isMathMLToken): add an inline function to test that a tag corresponds to a MathML Token Element.
- mathml/MathMLElement.h:
Follow-up work to address Darin's comments.
LayoutTests:
- mathml/presentation/direction-overall-expected.html: test that dir does not apply to msqrt
- mathml/presentation/direction-overall.html:
- mathml/presentation/mstyle-css-attributes-expected.html: Added.
- mathml/presentation/mstyle-css-attributes.html: Added.
Add more tests for presentation attributes on mstyle.
- 9:01 PM Changeset in webkit [159679] by
-
- 116 edits in trunk
Remove ENABLE_WORKERS
https://bugs.webkit.org/show_bug.cgi?id=105784
.:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/WebCore:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
Source/WebKit:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/efl:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- ewk/ewk_settings.cpp:
(ewk_settings_memory_cache_clear):
Source/WebKit/win:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- WebWorkersPrivate.cpp:
(WebWorkersPrivate::workerThreadCount):
Source/WTF:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- wtf/FeatureDefines.h:
- wtf/nix/FeatureDefinesNix.h:
Tools:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- Scripts/webkitperl/FeatureList.pm:
WebKitLibraries:
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-21
Reviewed by Darin Adler.
- win/tools/vsprops/FeatureDefines.props:
- win/tools/vsprops/FeatureDefinesCairo.props:
- 8:42 PM Changeset in webkit [159678] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r159632.
- platform/network/curl/SSLHandle.cpp:
(WebCore::certVerifyCallback):
Fixed template syntax.
- 8:24 PM Changeset in webkit [159677] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a typo (requriements->requirements).
- runtime/StackAlignment.h:
- 8:22 PM Changeset in webkit [159676] by
-
- 2 edits in trunk/Tools
Try to fix buildbot Dashboard for people who have not hidden anything.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
Add a null check for hidden platforms.
- 8:17 PM Changeset in webkit [159675] by
-
- 7 edits in trunk/Tools
Remove chrome/chromium related things from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=124493
Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2013-11-21
Reviewed by Darin Adler.
- Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.assert_mock_port_works):
- Scripts/webkitpy/port/base.py:
(Port.to.setup_environ_for_server):
- Scripts/webkitpy/port/mac_unittest.py:
(test_tests_for_other_platforms):
- Scripts/webkitpy/port/mock_drt.py:
(MockTestShell.output_for_test):
- Scripts/webkitpy/tool/bot/irc_command.py:
(Restart.execute):
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- 8:05 PM Changeset in webkit [159674] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix build after r159656
https://bugs.webkit.org/show_bug.cgi?id=124755
Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Gyuyoung Kim.
Page title was moved to page load state.
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):
- 7:56 PM Changeset in webkit [159673] by
-
- 1 edit1 add in trunk/Source/ThirdParty/ANGLE
Unreviewed build fix.
- src/libGLESv2/Constants.h: Added from checkout a60e0805721f62c28a55faf2df74472cc5fc91fc.
- 7:49 PM Changeset in webkit [159672] by
-
- 3 edits in trunk/Tools
In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
https://bugs.webkit.org/show_bug.cgi?id=124717
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-21
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/style/filereader.py:
(TextFileReader.process_file):
- Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_process_filedoes_not_exist):
- 7:17 PM Changeset in webkit [159671] by
-
- 13 edits in trunk
Web Inspector: [CSS Shapes] Refactor highlighting code to decrease Shapes API surface
https://bugs.webkit.org/show_bug.cgi?id=124737
Reviewed by Timothy Hatcher.
Source/WebCore:
Add a virtual method to Shapes, buildPath, that can be used to build the
path (in the Shape coordinate system) for display in the Inspector. This allows us
to remove methods such as type(), polygon(), and logicalRx/Ry() which exposed the
inner workings of the Shapes classes. Also covers the addition of the BoxShape type.
Refactoring, existing test is inspector-protocol/model/highlight-shape-outside.html.
- inspector/InspectorOverlay.cpp:
(WebCore::appendPathCommandAndPoints): Points need to be translated from shape space
to renderer space using ShapeInfo.
(WebCore::buildObjectForShapeOutside): Add the ShapeOutsideInfo to the path info struct.
- rendering/shapes/BoxShape.cpp:
(WebCore::BoxShape::buildPath): Build the path for a BoxShape.
- rendering/shapes/BoxShape.h:
- rendering/shapes/PolygonShape.cpp:
(WebCore::PolygonShape::buildPath): Build the path for a PolygonShape.
- rendering/shapes/PolygonShape.h:
- rendering/shapes/RasterShape.h:
- rendering/shapes/RectangleShape.cpp:
(WebCore::RectangleShape::buildPath): Build the path for a RectangleShape.
- rendering/shapes/RectangleShape.h:
- rendering/shapes/Shape.h:
LayoutTests:
The shapes paths are now drawn in shape-coordinate space before being translated to
renderer space. With different writing modes, shapes may have their coordinates
translated. For example, a rectangle specified as four points [top left, top right,
bottom right, bottom left] in vertical-lr space would appear as [top left, bottom left,
bottom right, top right] in horizontal-tb space. Adjusting the previous tests, and
adding a test for the new box value.
- inspector-protocol/model/highlight-shape-outside-expected.txt:
- inspector-protocol/model/highlight-shape-outside.html:
- 7:12 PM Changeset in webkit [159670] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeBlock::m_numCalleeRegisters need to honor native stack alignment.
https://bugs.webkit.org/show_bug.cgi?id=124754.
Reviewed by Filip Pizlo.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::newRegister):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- 7:04 PM Changeset in webkit [159669] by
-
- 13 edits in trunk
<https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
All modern versions of Xcode set it appropriately for our needs.
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Tools:
- MiniBrowser/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 7:01 PM Changeset in webkit [159668] by
-
- 2 edits2 adds in trunk/Tools
webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
https://bugs.webkit.org/show_bug.cgi?id=124676
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-21
Reviewed by Daniel Bates.
checkForArgumentAndRemoveFromArrayRef functions was removing wrong
elements when there were more then one occurrence of that argument.
E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
{b, a}, when it should be {b, c}.
- Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
- Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
- 7:01 PM Changeset in webkit [159667] by
-
- 4 edits in trunk/Source
[GTK] Unreviewed buildfix after r159614 and r159656.
Source/WebCore:
- bindings/gobject/WebKitDOMCustom.cpp: Add missing header
Source/WebKit2:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList): Use the page load state to get page title.
- 6:59 PM Changeset in webkit [159666] by
-
- 2 edits in trunk/Source/WebCore
Fix WinCairo unreachable code warnings in SimpleLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=124704
Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-21
Reviewed by Antti Koivisto.
Fix unreachable code warnings using conditional directives.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
- 6:57 PM Changeset in webkit [159665] by
-
- 12 edits in trunk/Source
<https://webkit.org/b/124701> Fix an error in a few Xcode configuration setting files.
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
- 6:56 PM Changeset in webkit [159664] by
-
- 2 edits in trunk/Tools
Update build-webkit after r159550.
- Scripts/webkitperl/FeatureList.pm:
- 6:55 PM Changeset in webkit [159663] by
-
- 8 edits in trunk/Source
<https://webkit.org/b/124700> Fix some deprecation warnings.
Reviewed by Anders Carlsson.
Source/WebCore:
- platform/mac/HTMLConverter.mm:
(fileWrapperForURL): Move off a deprecated NSFileWrapper method.
Source/WebKit/mac:
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::startStream): Move off a deprecated NSData method.
- WebView/WebDataSource.mm:
(-[WebDataSource _fileWrapperForURL:]): Move off a deprecated NSFileWrapper method.
- WebView/WebHTMLView.mm:
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
Source/WebKit2:
- UIProcess/API/mac/WKView.mm:
(-[WKView namesOfPromisedFilesDroppedAtDestination:]): Move off a deprecated NSFileWrapper method.
- 6:53 PM Changeset in webkit [159662] by
-
- 3 edits in trunk/LayoutTests
[EFL] Layout tests with editing need to be rebaselined.
https://bugs.webkit.org/show_bug.cgi?id=124751
Unreviewed, EFL rebaseline.
editing/input/reveal-caret-of-multiline-contenteditable.html test is rebaselined after r137239.
editing/selection/5354455-2.html test is rebaselined after r133000.
Rebaseline the expected results to suit editing-related performance in EFL.
Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-21
- platform/efl-wk1/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
- platform/efl/editing/selection/5354455-2-expected.txt:
- 6:38 PM Changeset in webkit [159661] by
-
- 2 edits in trunk/Tools
Update apple builders.
- 6:20 PM Changeset in webkit [159660] by
-
- 2 edits49 adds in trunk/LayoutTests
Import some W3C tests for HTML template element
https://bugs.webkit.org/show_bug.cgi?id=124699
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
Imported the shared resources for web-platform-tests/html-templates as well as tests under
serializing-html-templates and template-element at a274ad93ef5dc02ac042e0a5d58327d4135178ac.
- ChangeLog: Added.
- html-templates/resources/end-template-tag-in-body.html: Added.
- html-templates/resources/end-template-tag-in-head.html: Added.
- html-templates/resources/frameset-end-tag.html: Added.
- html-templates/resources/head-template-contents-div-no-end-tag.html: Added.
- html-templates/resources/head-template-contents-table-no-end-tag.html: Added.
- html-templates/resources/html-start-tag.html: Added.
- html-templates/resources/template-child-nodes-div.xhtml: Added.
- html-templates/resources/template-child-nodes-nested.xhtml: Added.
- html-templates/resources/template-contents-attribute.html: Added.
- html-templates/resources/template-contents-body.html: Added.
- html-templates/resources/template-contents-div-no-end-tag.html: Added.
- html-templates/resources/template-contents-empty.html: Added.
- html-templates/resources/template-contents-frameset.html: Added.
- html-templates/resources/template-contents-head.html: Added.
- html-templates/resources/template-contents-html.html: Added.
- html-templates/resources/template-contents-nested.html: Added.
- html-templates/resources/template-contents-table-no-end-tag.html: Added.
- html-templates/resources/template-contents-text.html: Added.
- html-templates/resources/template-contents.html: Added.
- html-templates/resources/template-descendant-body.html: Added.
- html-templates/resources/template-descendant-frameset.html: Added.
- html-templates/resources/template-descendant-head.html: Added.
- html-templates/resources/two-templates.html: Added.
- html-templates/serializing-html-templates/outerhtml-expected.txt: Added.
- html-templates/serializing-html-templates/outerhtml.html: Added.
- html-templates/template-element/content-attribute-expected.txt: Added.
- html-templates/template-element/content-attribute.html: Added.
- html-templates/template-element/node-document-changes-expected.txt: Added.
- html-templates/template-element/node-document-changes.html: Added.
- html-templates/template-element/template-as-a-descendant-expected.txt: Added.
- html-templates/template-element/template-as-a-descendant.html: Added.
- html-templates/template-element/template-content-expected.txt: Added.
- html-templates/template-element/template-content-node-document-expected.txt: Added.
- html-templates/template-element/template-content-node-document.html: Added.
- html-templates/template-element/template-content.html: Added.
- html-templates/template-element/template-descendant-body-expected.txt: Added.
- html-templates/template-element/template-descendant-body.html: Added.
- html-templates/template-element/template-descendant-frameset-expected.txt: Added.
- html-templates/template-element/template-descendant-frameset.html: Added.
- html-templates/template-element/template-descendant-head-expected.txt: Added.
- html-templates/template-element/template-descendant-head.html: Added.
- html-templates/testcommon.js: Added.
LayoutTests:
- imported/w3c/: Added.
- platform/win/TestExpectations: Skip the imported tests since the template element is disabled on Windows.
- 6:12 PM Changeset in webkit [159659] by
-
- 3 edits in trunk/Tools
Don't fetch hidden platforms on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124750
Reviewed by Tim Horton.
If a platform is hidden, don't fetch its data. If it
becomes unhidden, try to fetch immediately (unless
you've recently fetched).
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
- 5:29 PM Changeset in webkit [159658] by
-
- 2 edits in trunk/Source/WebKit2
Didn't mean to commit this.
- UIProcess/PageLoadState.h:
- 5:16 PM Changeset in webkit [159657] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Unreviewed gardening to hide annoying *.user files when.
- ANGLE.vcxproj: Added property svn:ignore.
- 5:13 PM Changeset in webkit [159656] by
-
- 6 edits in trunk/Source/WebKit2
Move page title handling to the page load state
https://bugs.webkit.org/show_bug.cgi?id=124748
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopyTitle):
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didCommitLoad):
(WebKit::PageLoadState::title):
(WebKit::PageLoadState::setTitle):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveTitleForFrame):
- UIProcess/WebPageProxy.h:
- 5:11 PM Changeset in webkit [159655] by
-
- 4 edits in trunk/Source/JavaScriptCore
ARM64: Implement push/pop equivalents in LLInt
https://bugs.webkit.org/show_bug.cgi?id=124721
Reviewed by Filip Pizlo.
Added pushLRAndFP and popLRAndFP that push and pop the link register and frame pointer register.
These ops emit code just like what the compiler emits in the prologue and epilogue. Also changed
pushCalleeSaves and popCalleeSaves to use the same store pair and load pair instructions to do
the actually pushing and popping. Finally changed the implementation of push and pop to raise
an exception since we don't have (or need) a single register push or pop.
- llint/LowLevelInterpreter64.asm:
- offlineasm/arm64.rb:
- offlineasm/instructions.rb:
- 4:46 PM Changeset in webkit [159654] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSC: Removed unused opcodes from offline assembler
https://bugs.webkit.org/show_bug.cgi?id=124749
Reviewed by Mark Hahnenberg.
Removed the unused, X86 only peekq and pokeq.
- offlineasm/instructions.rb:
- offlineasm/x86.rb:
- 4:31 PM Changeset in webkit [159653] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(159395) Fix branch8(…, AbsoluteAddress, …) in ARM64 MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=124688
Reviewed by Geoffrey Garen.
Changed handling of the address for the load8() in the branch8(AbsoluteAddress) to be like
the rest of the branchXX(AbsoluteAddress) fucntions.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branch8):
- 3:55 PM Changeset in webkit [159652] by
-
- 4 edits in trunk/Source/JavaScriptCore
BytecodeGenerator should align the stack according to native conventions
https://bugs.webkit.org/show_bug.cgi?id=124735
Reviewed by Mark Lam.
- bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::registerOffset):
(JSC::CallArguments::argumentCountIncludingThis):
- bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
- 3:24 PM Changeset in webkit [159651] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix; export symbol for WebCore::provideDeviceOrientationTo()
Add the symbol ZN7WebCore26provideDeviceOrientationToEPNS_4PageEPNS_23DeviceOrientationClientE.
- WebCore.exp.in:
- 3:21 PM Changeset in webkit [159650] by
-
- 2 edits in trunk/Source/WebCore
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard
https://bugs.webkit.org/show_bug.cgi?id=124741
Reviewed by Alexey Proskuryakov.
Add !USE(NETWORK_CFDATA_ARRAY_CALLBACK)-guard around code that is unused
when building with feature NETWORK_CFDATA_ARRAY_CALLBACK.
Additionally, add a declaration for allocateSegment() with attribute WARN_UNUSED_RETURN
to have the compiler warn when the return value of this function is unused. Together with
warnings treated as errors this change will prevent a memory leak.
- platform/SharedBuffer.cpp:
- 3:20 PM Changeset in webkit [159649] by
-
- 5 edits in trunk/Source
Remove unused functions from WebCore and WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124739
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- editing/markup.cpp: Remove unused functions isHTMLBlockElement and
ancestorToRetainStructureAndAppearanceWithNoRenderer.
- rendering/InlineElementBox.cpp: Append newline to the end of the file.
Source/WebKit2:
Remove unused functions autoreleased({WKURLRequestRef, WKURLResponseRef}).
- UIProcess/API/mac/WKBrowsingContextController.mm:
- 3:19 PM Changeset in webkit [159648] by
-
- 16 edits11 adds in trunk/Source/WebCore
Only generate isObservable() when IDL specifies GenerateIsReachable
https://bugs.webkit.org/show_bug.cgi?id=124729
Reviewed by Geoffrey Garen.
We should only generate the static inline function isObservable() when the IDL
specifies GenerateIsReachable. Otherwise, this function is unused.
Added a new test IDL TestGenerateIsReachable.idl and expected results to test that
we generate isObservable() when an IDL specifies GenerateIsReachable. Additionally,
rebased existing test results.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestGenerateIsReachablePrivate.h: Added.
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Removed unused function isObservable().
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
- bindings/scripts/test/JS/JSTestEventConstructor.cpp: Ditto.
- bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
- bindings/scripts/test/JS/JSTestException.cpp: Ditto.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp: Added.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.h: Added.
- bindings/scripts/test/JS/JSTestInterface.cpp: Removed unused function isObservable().
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp: Ditto.
- bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp: Ditto.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
- bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
- bindings/scripts/test/JS/JSattribute.cpp: Ditto.
- bindings/scripts/test/JS/JSreadonly.cpp: Ditto.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Added.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Added.
- bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Added.
- bindings/scripts/test/TestGenerateIsReachable.idl: Added.
- 2:31 PM Changeset in webkit [159647] by
-
- 37 edits4 moves in trunk/Source/WebKit2
Rename PlatformCertificateInfo to CertificateInfo
https://bugs.webkit.org/show_bug.cgi?id=124150
Reviewed by Darin Adler.
- GNUmakefile.list.am:
- NetworkProcess/AsynchronousNetworkLoaderClient.cpp:
(WebKit::AsynchronousNetworkLoaderClient::didReceiveResponse):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- NetworkProcess/NetworkResourceLoader.cpp:
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
(WKCertificateInfoGetCertificateChain):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
- Shared/Authentication/AuthenticationManager.h:
- Shared/Authentication/AuthenticationManager.messages.in:
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebCertificateInfo.h:
(WebKit::WebCertificateInfo::create):
(WebKit::WebCertificateInfo::certificateInfo):
(WebKit::WebCertificateInfo::WebCertificateInfo):
- Shared/mac/CertificateInfo.h: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificateChain):
- Shared/mac/CertificateInfo.mm: Renamed from Source/WebKit2/Shared/mac/PlatformCertificateInfo.mm.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
(WebKit::CertificateInfo::dump):
- Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- Shared/soup/CertificateInfo.cpp: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.cpp.
(WebKit::CertificateInfo::CertificateInfo):
(WebKit::CertificateInfo::~CertificateInfo):
(WebKit::CertificateInfo::encode):
(WebKit::CertificateInfo::decode):
- Shared/soup/CertificateInfo.h: Renamed from Source/WebKit2/Shared/soup/PlatformCertificateInfo.h.
(WebKit::CertificateInfo::certificate):
(WebKit::CertificateInfo::tlsErrors):
- Shared/soup/WebCoreArgumentCodersSoup.cpp:
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):
- UIProcess/API/gtk/WebKitCertificateInfo.cpp:
(webkitCertificateInfoGetCertificateInfo):
- UIProcess/API/gtk/WebKitCertificateInfoPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_get_tls_info):
- UIProcess/Authentication/AuthenticationChallengeProxy.cpp:
(WebKit::AuthenticationChallengeProxy::useCredential):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::allowSpecificHTTPSCertificateForHost):
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didCommitLoad):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didCommitLoadForFrame):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Network/WebResourceLoader.h:
- WebProcess/Network/WebResourceLoader.messages.in:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::allowSpecificHTTPSCertificateForHost):
- 2:28 PM Changeset in webkit [159646] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][GTK][WK2] Build fix after r159641
https://bugs.webkit.org/show_bug.cgi?id=124742
Patch by Sergio Correia <Sergio Correia> on 2013-11-21
Reviewed by Csaba Osztrogonác.
Should fetch activeURL from page load state.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewUpdateURI):
- UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp:
(WebKit::WebInspectorServer::buildPageList):
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::buildPageList):
- 2:26 PM WebKitGTK/Debugging edited by
- (diff)
- 1:57 PM Changeset in webkit [159645] by
-
- 9 edits in trunk/Source/WebCore
Add a new mode to extend the tile cache beyond the page
https://bugs.webkit.org/show_bug.cgi?id=124216
Reviewed by Simon Fraser.
This patch makes it possible to give the tile cache a margin of tiles. If there is
a margin of tiles, this patch paints those tiles with the background color. Note
that this patch does not actually give the tile cache a margin at this time.
You opt into a margined tiled cache by called setTileMargins() with number of
pixels that the margin on that side should be.
- platform/graphics/TiledBacking.h:
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
(WebCore::TileController::tilesWouldChangeForVisibleRect):
TileController::bounds() now computes the bounds INCLUDING the margin.
(WebCore::TileController::bounds):
adjustRectAtTileIndexForMargin() is a new function that is required to get the
rect size for tiles in the margin right. rectForTileIndex() assumes all tiles
strive to be the size of m_tileSize, but now margin tiles will be whatever the
margin sizes were set to.
(WebCore::TileController::adjustRectAtTileIndexForMargin):
(WebCore::TileController::rectForTileIndex):
This is another instance where m_tileSize is not always the right size to use.
(WebCore::TileController::getTileIndexRangeForRect):
The tile coverage rect now might include the margin tiles. Only include them in
slow-scrolling mode if the current position is within one tile of the edge.
(WebCore::TileController::computeTileCoverageRect):
tileSizeForCoverageRect() does not make sense in a world where the coverage rect
will include margin. Instead, this patch implements the current strategy more
explicitly by returning the visibleRect in the slow scrolling case, and in the
process this patch also re-names tileSizeForCoverageRect() to computeTileSize()
since it no longer takes a coverageRect.
(WebCore::TileController::computeTileSize):
(WebCore::TileController::revalidateTiles):
New setters and getters for the tile margins on each side.
(WebCore::TileController::setTileMargins):
(WebCore::TileController::hasMargins):
(WebCore::TileController::topMarginHeight):
(WebCore::TileController::bottomMarginHeight):
(WebCore::TileController::leftMarginWidth):
(WebCore::TileController::rightMarginWidth):
New function to add margin onto the composited bounds if there is one.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::tiledBackingHasMargin):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::compositedBoundsIncludingMargin):
- rendering/RenderLayerBacking.h:
Do not set masks to bounds if there is a margin on the root layer.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::mainFrameBackingIsTiledWithMargin):
- rendering/RenderLayerCompositor.h:
Allow background color to paint into the margin tiles.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
- 1:55 PM Changeset in webkit [159644] by
-
- 6 edits4 adds in trunk
Implement WebCrypto wrapKey
https://bugs.webkit.org/show_bug.cgi?id=124738
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html
crypto/subtle/aes-cbc-wrap-rsa.html
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::exportKey): Factored out the actual operation that can be chained with
encryption for wrapKey.
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey): Fixed a memory leak in failure code path.
- crypto/SubtleCrypto.idl: Added wrapKey.
LayoutTests:
- crypto/subtle/aes-cbc-wrap-rsa-expected.txt: Added.
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Added.
- crypto/subtle/aes-cbc-wrap-rsa-non-extractable.html: Added.
- crypto/subtle/aes-cbc-wrap-rsa.html: Added.
- crypto/subtle/aes-export-key-expected.txt:
- crypto/subtle/hmac-export-key-expected.txt:
There is no longer a console message, the error is in an exception.
- 1:11 PM Changeset in webkit [159643] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, preemptive build fix.
- runtime/StackAlignment.h:
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
- 1:07 PM Changeset in webkit [159642] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
JSC should know what the stack alignment conventions are
https://bugs.webkit.org/show_bug.cgi?id=124736
Reviewed by Mark Lam.
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/StackAlignment.h: Added.
(JSC::stackAlignmentBytes):
(JSC::stackAlignmentRegisters):
- 12:30 PM Changeset in webkit [159641] by
-
- 6 edits in trunk/Source/WebKit2
Fetch all page loading related URLs from the page load state
https://bugs.webkit.org/show_bug.cgi?id=124732
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKPage.cpp:
(WKPageCopyActiveURL):
(WKPageCopyProvisionalURL):
(WKPageCopyCommittedURL):
- UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController unreachableURL]):
- UIProcess/PageLoadState.h:
(WebKit::PageLoadState::provisionalURL):
(WebKit::PageLoadState::url):
(WebKit::PageLoadState::unreachableURL):
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- 12:03 PM Changeset in webkit [159640] by
-
- 1 edit2 adds in trunk/LayoutTests
Added test for :hover and javascript events on the visual overflow of a region.
[CSS Regions] Content in a region's visible overflow does not trigger :hover state, nor JavaScript events
https://bugs.webkit.org/show_bug.cgi?id=112010
Reviewed by Antti Koivisto.
- fast/regions/hover-and-js-in-visual-overflow-expected.html: Added.
- fast/regions/hover-and-js-in-visual-overflow.html: Added.
- 12:00 PM Changeset in webkit [159639] by
-
- 8 edits2 adds in trunk/Source/WebKit2
Hook up WebProcess-side of getOrEstablishIDBDatabaseMetadata
https://bugs.webkit.org/show_bug.cgi?id=124698
Reviewed by Anders Carlsson.
With this change the IDB API in WebKit2 using the DatabaseProcess finally does something observable:
window.indexedDB.open() sends an error to Javascript.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Continue calling back to the
WebProcess with dummy data, but include the request ID for reference.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
Add a new class that wraps a completion callback function and gives it a unique integer identifier.
It also allows for wrapping an abort callback function (in case a connection is lost, for example).
It is templated to flexibly handle any callback function signature.
- Shared/AsyncRequest.cpp: Added.
(WebKit::generateRequestID):
(WebKit::AsyncRequest::AsyncRequest):
(WebKit::AsyncRequest::~AsyncRequest):
(WebKit::AsyncRequest::setAbortHandler):
(WebKit::AsyncRequest::requestAborted):
(WebKit::AsyncRequest::clearAbortHandler):
- Shared/AsyncRequest.h: Added.
(WebKit::AsyncRequest::requestID):
(WebKit::AsyncRequest::requestCompleted):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata): Wrap the completion handler in an
AsyncRequest and save off the request for later use.
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Send the results to the AsyncRequest.
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- WebKit2.xcodeproj/project.pbxproj:
- 11:43 AM Changeset in webkit [159638] by
-
- 4 edits in trunk/Source/WebKit2
Move activeURL getter to PageLoadState
https://bugs.webkit.org/show_bug.cgi?id=124690
Reviewed by Tim Horton.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::activeURL):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::activeURL):
- 11:05 AM Changeset in webkit [159637] by
-
- 13 edits4 adds in trunk
Implement WebCrypto unwrapKey
https://bugs.webkit.org/show_bug.cgi?id=124725
Reviewed by Anders Carlsson.
Source/WebCore:
Tests: crypto/subtle/aes-cbc-unwrap-failure.html
crypto/subtle/aes-cbc-unwrap-rsa.html
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
- bindings/js/JSCryptoAlgorithmDictionary.h:
Removed calls for wrap/unwrap parameter parsing, these are just the same as encrypt/decrypt.
- bindings/js/JSCryptoOperationData.cpp:
(WebCore::cryptoOperationDataFromJSValue):
- bindings/js/JSCryptoOperationData.h:
- crypto/CryptoKeySerialization.h:
More Vector<char> elimination.
- bindings/js/JSDOMPromise.cpp:
- bindings/js/JSDOMPromise.h:
Removed unneccessary copy constructor and assignment operator, they are no diffdrent
than compiler generated ones.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::cryptoKeyUsagesFromJSValue): Minor style fixes.
(WebCore::JSSubtleCrypto::encrypt): Ditto.
(WebCore::JSSubtleCrypto::decrypt): Ditto.
(WebCore::JSSubtleCrypto::sign): Ditto.
(WebCore::JSSubtleCrypto::verify): Ditto.
(WebCore::JSSubtleCrypto::generateKey): Ditto.
(WebCore::importKey): Separated actual import operation and the parts that read
arguments from ExecState, and call the promise. Logically, this should be outside
of bindings code even, but JWK makes that quite challenging.
(WebCore::JSSubtleCrypto::importKey): This only does the more mundane arguments
and return parts now.
(WebCore::JSSubtleCrypto::exportKey): Minor style fixes.
(WebCore::JSSubtleCrypto::unwrapKey): Chain decrypt and import.
- crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::encryptForWrapKey):
(WebCore::CryptoAlgorithm::decryptForUnwrapKey):
- crypto/CryptoAlgorithm.h:
There are algorithms that expose wrap/unwrap, but not encrypt/decrypt. These will
override these new functions, and leave encrypt/decrypt to raise NOT_SUPPORTED_ERR.
- crypto/SubtleCrypto.idl: Added unwrapKey.
LayoutTests:
- crypto/subtle/aes-cbc-unwrap-failure-expected.txt: Added.
- crypto/subtle/aes-cbc-unwrap-failure.html: Added.
- crypto/subtle/aes-cbc-unwrap-rsa-expected.txt: Added.
- crypto/subtle/aes-cbc-unwrap-rsa.html: Added.
- 11:02 AM Changeset in webkit [159636] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r159633.
http://trac.webkit.org/changeset/159633
https://bugs.webkit.org/show_bug.cgi?id=124726
it broke 10 webkitpy tests (Requested by dino_ on #webkit).
- Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):
- 10:32 AM Changeset in webkit [159635] by
-
- 4 edits in trunk/Source/JavaScriptCore
[MIPS] Build fails since r159545.
https://bugs.webkit.org/show_bug.cgi?id=124716
Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-11-21
Reviewed by Michael Saboff.
Add missing implementations in MacroAssembler and LLInt for MIPS.
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::sync):
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::store8):
(JSC::MacroAssemblerMIPS::memoryFence):
- offlineasm/mips.rb:
- 10:21 AM Changeset in webkit [159634] by
-
- 5 edits in trunk/Source/WebKit2
Clean up WebKit2 initialization
https://bugs.webkit.org/show_bug.cgi?id=124696
Reviewed by Sam Weinig.
Call InitializeWebKit2() everywhere we need to do one-time
initialization in WebKit2, rather than having a hotch-potch
of init code.
- Shared/APIObject.cpp:
(API::Object::Object):
- UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm: Removed an unused #include.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::create):
- 9:44 AM Changeset in webkit [159633] by
-
- 2 edits in trunk/Tools
Remove the stderr_write attribute from StyleProcessorConfiguration.
https://bugs.webkit.org/show_bug.cgi?id=124703
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.
- Scripts/webkitpy/style/checker.py:
(check_webkit_style_configuration):
(CheckerDispatcher.dispatch):
(StyleProcessorConfiguration):
(StyleProcessorConfiguration.init):
(StyleProcessorConfiguration.write_style_error):
- 9:43 AM Changeset in webkit [159632] by
-
- 2 edits in trunk/Source/WebCore
[curl]Improve ssl certificate storage and check
https://bugs.webkit.org/show_bug.cgi?id=124569
Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-21
Reviewed by Brent Fulgham.
Storage and check the whole certificate chain, not just the root certificate.
- platform/network/curl/SSLHandle.cpp:
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::pemData):
(WebCore::certVerifyCallback):
- 9:41 AM Changeset in webkit [159631] by
-
- 21 edits in trunk/Source/WebKit2
Reverted r159603, as it appears to have caused Safari’s Web processes to crash on launch.
Requested by Sam Weinig.
- Scripts/webkit2/messages.py:
(struct_or_class):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- Shared/mac/ObjCObjectGraphCoders.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::encodeMessageBody):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::sendToAllProcessesInGroup):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPageGroup):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
- 9:36 AM Changeset in webkit [159630] by
-
- 15 edits in trunk/Source
[WinCairo] Building ANGLE libraries fails.
https://bugs.webkit.org/show_bug.cgi?id=124679
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-21
Reviewed by Brent Fulgham.
Source/ThirdParty/ANGLE:
Added/removed files to/from project, and re-added constants.h file.
- ANGLE.vcxproj/libEGL.vcxproj:
- ANGLE.vcxproj/libEGL.vcxproj.filters:
- ANGLE.vcxproj/libGLESv2.vcxproj:
- ANGLE.vcxproj/libGLESv2.vcxproj.filters:
- ANGLE.vcxproj/libGLESv2Common.props:
- ANGLE.vcxproj/translator_common.vcxproj:
- ANGLE.vcxproj/translator_common.vcxproj.filters:
- ANGLE.vcxproj/translator_glsl.vcxproj:
- ANGLE.vcxproj/translator_glsl.vcxproj.filters:
- ANGLE.vcxproj/translator_hlsl.vcxproj:
- ANGLE.vcxproj/translator_hlsl.vcxproj.filters:
- src/libGLESv2/libGLESv2.def:
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKitCFLite.props: Link with translator_hlsl.lib.
- 9:11 AM Changeset in webkit [159629] by
-
- 4 edits in trunk/Source/JavaScriptCore
Fix sh4 build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124713
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-21
Reviewed by Michael Saboff.
Add missing implementations in macro assembler and LLINT for sh4.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8):
(JSC::MacroAssemblerSH4::store8):
(JSC::MacroAssemblerSH4::memoryFence):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::synco):
- offlineasm/sh4.rb: Handle "memfence" opcode.
- 8:50 AM Changeset in webkit [159628] by
-
- 1 edit4 adds in trunk/LayoutTests
Added test for the overflow of a region being painted across multiple tiles.
Added test for correct repainting of a region's overflow.
[CSS Regions] Overflow areas from regions do not redraw
https://bugs.webkit.org/show_bug.cgi?id=117329
Reviewed by Antti Koivisto.
- fast/regions/regions-overflow-tile-expected.html: Added.
- fast/regions/regions-overflow-tile.html: Added.
- fast/repaint/repaint-regions-overflow-expected.txt: Added.
- fast/repaint/repaint-regions-overflow.html: Added.
- 8:48 AM WebKitGTK/Debugging edited by
- (diff)
- 8:45 AM WebKitGTK/Debugging edited by
- (diff)
- 8:44 AM WebKitGTK/Debugging edited by
- (diff)
- 8:13 AM BuildingGtk edited by
- (diff)
- 8:12 AM BuildingGtk edited by
- (diff)
- 8:12 AM BuildingGtk edited by
- (diff)
- 8:11 AM BuildingGtk edited by
- (diff)
- 8:00 AM WebKitGTK/StartHacking edited by
- (diff)
- 7:43 AM Changeset in webkit [159627] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSS Regions] Float get sliced if its container has forced break and is less tall than float
https://bugs.webkit.org/show_bug.cgi?id=124205
Added test for the case when a float is overflowing a region due to a forced break.
Reviewed by Antti Koivisto.
- fast/regions/float-slicing-on-forced-break-expected.html: Added.
- fast/regions/float-slicing-on-forced-break.html: Added.
- 7:17 AM Changeset in webkit [159626] by
-
- 3 edits2 adds in trunk
Fix hover area for divs with css transforms
https://bugs.webkit.org/show_bug.cgi?id=124647
Patch by Mihai Maerean <Mihai Maerean> on 2013-11-21
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
Non transformed layers are now being hit last, not through or in-between transformed layers.
The paint order says that the divs creating stacking contexts (including transforms) are painted after the
other siblings so they should be hit tested in the reverse order. Also, a rotated div in a non-rotated parent
should be hit in its entire area, not hit its parent's background, even if the z-coordinate is negative where
the mouse is located.
Test: transforms/3d/hit-testing/hover-rotated-negative-z.html
- rendering/RenderLayer.cpp:
(WebCore::computeZOffset):
LayoutTests:
- transforms/3d/hit-testing/hover-rotated-negative-z.html: Added.
- transforms/3d/hit-testing/hover-rotated-negative-z-expected.txt: Added.
- 6:58 AM Changeset in webkit [159625] by
-
- 1 edit2 adds in trunk/LayoutTests
Created test for positioned fragmented content which overflows the regions.
[CSS Regions] Fragmented content that is relatively positioned get sliced (and overflows in the next region)
https://bugs.webkit.org/show_bug.cgi?id=117122
Reviewed by Antti Koivisto.
- fast/regions/positioned-fragmented-content-expected.html: Added.
- fast/regions/positioned-fragmented-content.html: Added.
- 6:57 AM Changeset in webkit [159624] by
-
- 1 edit2 adds in trunk/LayoutTests
Added test for visual overflow with transformed content in regions.
[CSS Regions] Transform applied to content node causes overflow to be hidden
https://bugs.webkit.org/show_bug.cgi?id=116242
Reviewed by Antti Koivisto.
- fast/regions/region-visual-overflow-transform-expected.html: Added.
- fast/regions/region-visual-overflow-transform.html: Added.
- 6:53 AM Changeset in webkit [159623] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Release compilation fails when defining "LOG_DISABLED=0"
https://bugs.webkit.org/show_bug.cgi?id=124661
Patch by Andres Gomez <Andres Gomez> on 2013-11-21
Reviewed by Mario Sanchez Prada.
In a "Debug" build the CString.h header comes from another
indirect dependency. Now, we explicitly add this missing include.
- html/HTMLTrackElement.cpp: Explicitly adding missing include.
- 6:52 AM Changeset in webkit [159622] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fix accessibility media-element expectation
https://bugs.webkit.org/show_bug.cgi?id=124711
Unreviewed EFL gardening.
Changing main element AXRole AXUnknown -> AXEmbedded.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-11-21
- platform/efl/accessibility/media-element-expected.txt:
- 6:25 AM Changeset in webkit [159621] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Update baselines after r159575.
- platform/efl/fast/block/float/024-expected.txt:
- platform/efl/fast/block/margin-collapse/025-expected.txt:
- platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 5:52 AM Changeset in webkit [159620] by
-
- 3 edits2 adds in trunk
Fix Range.insertNode when the inserted node is in the same container as the Range
https://bugs.webkit.org/show_bug.cgi?id=123957
Reviewed by Antti Koivisto.
Source/WebCore:
Inspired by https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb
When a node from the same container is inserted, we can't simply adjust m_end with the offset.
Compute m_start and m_end from the inserted nodes instead.
Also, don't adjust m_start and m_end to nodes outside of the document if the inserted nodes had been
removed by mutation events.
Test: fast/dom/Range/range-insertNode-same-container.html
- dom/Range.cpp:
(WebCore::Range::insertNode):
LayoutTests:
Merge https://chromium.googlesource.com/chromium/blink/+/fb6ca1f488703e8d4f20ce6449cc8ea210be6edb
Used better labels between divs, and added more evalAndLog and shouldBe so that
the expected result is self-explanatory.
- fast/dom/Range/range-insertNode-same-container-expected.txt: Added.
- fast/dom/Range/range-insertNode-same-container.html: Added.
- 5:46 AM Changeset in webkit [159619] by
-
- 4 edits2 adds in trunk
nextBoundary and previousBoundary are very slow when there is a password field
https://bugs.webkit.org/show_bug.cgi?id=123973
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/57366eec5e3edea54062d4e74c0e047f8681dbad
When iterating through DOM nodes nextBoundary and previousBoundary convert the contents of nodes using
text security to a sequence of 'x' characters. The SimplifiedBackwardsTextIterator and TextIterator
may iterate past node boundaries. Before this patch, the transformation was done looking at the starting
node rather than the current node. In some situations, this replaced all boundaries with 'x' and caused
the text iterator to continue iterating and transforming until the extent of the document.
Test: editing/deleting/password-delete-performance.html
- editing/TextIterator.h:
(WebCore::SimplifiedBackwardsTextIterator::node):
- editing/VisibleUnits.cpp:
(WebCore::previousBoundary):
(WebCore::nextBoundary):
LayoutTests:
- editing/deleting/password-delete-performance-expected.txt: Added.
- editing/deleting/password-delete-performance.html: Added.
- 5:43 AM Changeset in webkit [159618] by
-
- 3 edits2 adds in trunk
HTML parser should not associate elements inside templates with forms
https://bugs.webkit.org/show_bug.cgi?id=117779
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/45aadf7ee7ee010327eb692066cf013315ef3ed7
When parsing <form><template><input>, the previous behavior was to associate the <input> with the <form>,
even though they're not in the same tree (or even the same document).
This patch changes that by checking, prior to creating a form control element, whether the element to be
created lives in a document with a browsing context.
We don't update m_form as needed to faithfully match the HTML5 specification's form element pointer
http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#form-element-pointer
and its algorithm for creating and inserting nodes:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#creating-and-inserting-nodes
While this leaves isindex's reference to form element pointer stale:
http://www.whatwg.org/specs/web-apps/current-work/multipage/tree-construction.html#isindex
The HTML5 specification matches the behaviors of Chrome and Firefox so we leave it as is.
Test: fast/dom/HTMLTemplateElement/no-form-association.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::createHTMLElement):
LayoutTests:
- fast/dom/HTMLTemplateElement/no-form-association-expected.txt: Added.
- fast/dom/HTMLTemplateElement/no-form-association.html: Added.
- 5:22 AM Changeset in webkit [159617] by
-
- 4 edits in trunk/Tools
PerfTestRunner._generate_results_dict shouldn't depend on test objects
https://bugs.webkit.org/show_bug.cgi?id=124623
Removed the dependency on test objects from results JSON generation.
This allows single test.run to return metrics for multiple tests
Reviewed by Antti Koivisto.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.init): Takes the test path and test name.
(PerfTestMetric.path): Added.
(PerfTestMetric.test_file_name): Added.
(PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
(PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
The path is going to have the names of subtests at the end once we support them.
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
(TestPerfTestMetric.test_init_set_time_metric): Ditto.
(TestPerfTestMetric.test_has_values): Ditto.
(TestPerfTestMetric.test_append): Ditto.
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict): Only use metrics.
(_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
- 4:56 AM WebKitGTK/StartHacking edited by
- (diff)
- 4:26 AM Changeset in webkit [159616] by
-
- 2 edits in trunk/Tools
REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
https://bugs.webkit.org/show_bug.cgi?id=124697
Reviewed by Ryosuke Niwa.
- Scripts/webkitdirs.pm:
(checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
before trying to access to the first element.
- 12:52 AM Changeset in webkit [159615] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Cannot scroll in option menu when it larger than the screen
https://bugs.webkit.org/show_bug.cgi?id=124671
Reviewed by Martin Robinson.
The problem is that the popup menu is not resized to fit in the
screen, so it doesn't scroll and some of the items are offscreen
so they can't be selected either. GTK+ automatically resizes the
popup menus to fit in the work area, but only when the menu is
already positioned.
- platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::popUp): Schedule a resize of the popup
menu right after showing it once it has a position.
- 12:38 AM Changeset in webkit [159614] by
-
- 12 edits3 copies in trunk
[GTK] Mark all deprecated symbols in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=124406
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Move deprecated API from WebKitDOMCustom to a new file
WebKitDOMDeprecated leaving in WebKitDOMCustom only the
non-deprecated API that is not autogenerated. Also added the
deprecation decorations and tags in the documentation.
- bindings/gobject/GNUmakefile.am:
- bindings/gobject/WebKitDOMCustom.cpp:
- bindings/gobject/WebKitDOMCustom.h:
- bindings/gobject/WebKitDOMCustom.symbols:
- bindings/gobject/WebKitDOMDeprecated.cpp: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp.
(webkit_dom_blob_webkit_slice):
(webkit_dom_html_element_get_id):
(webkit_dom_html_element_set_id):
(webkit_dom_html_element_get_class_name):
(webkit_dom_html_element_set_class_name):
(webkit_dom_html_element_get_class_list):
(webkit_dom_html_form_element_dispatch_form_change):
(webkit_dom_html_form_element_dispatch_form_input):
(webkit_dom_webkit_named_flow_get_overflow):
(webkit_dom_element_get_webkit_region_overflow):
(webkit_dom_webkit_named_flow_get_content_nodes):
(webkit_dom_webkit_named_flow_get_regions_by_content_node):
(webkit_dom_bar_info_get_property):
(webkit_dom_bar_info_class_init):
(webkit_dom_bar_info_init):
(webkit_dom_bar_info_get_visible):
(webkit_dom_console_get_memory):
(webkit_dom_css_style_declaration_get_property_css_value):
(webkit_dom_document_get_webkit_hidden):
(webkit_dom_document_get_webkit_visibility_state):
(webkit_dom_html_document_open):
(webkit_dom_html_element_set_item_id):
(webkit_dom_html_element_get_item_id):
(webkit_dom_html_element_get_item_ref):
(webkit_dom_html_element_get_item_prop):
(webkit_dom_html_element_set_item_scope):
(webkit_dom_html_element_get_item_scope):
(webkit_dom_html_element_get_item_type):
(webkit_dom_html_style_element_set_scoped):
(webkit_dom_html_style_element_get_scoped):
(webkit_dom_html_properties_collection_get_property):
(webkit_dom_html_properties_collection_class_init):
(webkit_dom_html_properties_collection_init):
(webkit_dom_html_properties_collection_item):
(webkit_dom_html_properties_collection_named_item):
(webkit_dom_html_properties_collection_get_length):
(webkit_dom_html_properties_collection_get_names):
(webkit_dom_node_get_attributes):
(webkit_dom_node_has_attributes):
(webkit_dom_memory_info_get_property):
(webkit_dom_memory_info_class_init):
(webkit_dom_memory_info_init):
(webkit_dom_memory_info_get_total_js_heap_size):
(webkit_dom_memory_info_get_used_js_heap_size):
(webkit_dom_memory_info_get_js_heap_size_limit):
(webkit_dom_micro_data_item_value_class_init):
(webkit_dom_micro_data_item_value_init):
(webkit_dom_performance_get_memory):
(webkit_dom_property_node_list_get_property):
(webkit_dom_property_node_list_class_init):
(webkit_dom_property_node_list_init):
(webkit_dom_property_node_list_item):
(webkit_dom_property_node_list_get_length):
(webkit_dom_html_media_element_get_start_time):
(webkit_dom_html_media_element_get_initial_time):
(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):
- bindings/gobject/WebKitDOMDeprecated.h: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.h.
- bindings/gobject/WebKitDOMDeprecated.symbols: Copied from Source/WebCore/bindings/gobject/WebKitDOMCustom.symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateFunction): Do not include deprecation guards in the cpp file.
- bindings/scripts/gobject-generate-headers.pl: Do not create
fordward declarations for non-existent classes like Custom and
Deprecated.
- bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
(webkit_dom_test_event_target_dispatch_event):
Tools:
- Scripts/webkitpy/style/checker.py: Add special case for
WebKitDOMDeprecated.
- gtk/generate-gtkdoc:
(get_webkit2_options): Use the prefix of the methods as namespace,
since this is what gtkdoc expects to sort the index.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Ditto.
- gtk/generate-webkitdom-doc-files:
(WebKitDOMDocGenerator): Add a global list of deleted objects.
(WebKitDOMDocGenerator.write_deleted_classes): New method to write
the documentation for classes that are deprecated because they
have been removed.
(WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
for deleted classes too.
(WebKitDOMDocGeneratorSections.init): Build a list of
deprecated symbols using the given symbols file.
(WebKitDOMDocGeneratorSections._deleted_class): Returns the
deleted class corresponding to the given function.
(WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
dictionary of deprecated symbols for every class.
(WebKitDOMDocGeneratorSections.write_section): Add also the
deprecated symbols in every section.
(WebKitDOMDocGeneratorSections.write_deleted_classes): Add
sections for deleted classes too.
Nov 20, 2013:
- 11:52 PM Changeset in webkit [159613] by
-
- 6 edits in trunk/Source/WebCore
[CoordinatedGraphics] Use std::unique_ptrs rather than OwnPtrs
https://bugs.webkit.org/show_bug.cgi?id=124692
Reviewed by Noam Rosenthal.
No new tests, covered by existing ones.
- platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::TiledBackingStore):
- platform/graphics/TiledBackingStore.h:
- platform/graphics/TiledBackingStoreBackend.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::createBackingStore):
- platform/graphics/texmap/coordinated/CoordinatedTile.h:
- 11:46 PM Changeset in webkit [159612] by
-
- 3 edits in trunk/Tools
check-webkit-style should support C++11 rvalue references.
https://bugs.webkit.org/show_bug.cgi?id=123406
Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.
- Scripts/webkitpy/style/checkers/cpp.py:
(check_style):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(Cpp11StyleTest):
(Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
- 11:04 PM Changeset in webkit [159611] by
-
- 15 edits1 copy in trunk/Source
Add more infrastructure for ServerConnection communication between Web and Database processes
https://bugs.webkit.org/show_bug.cgi?id=124693
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):
(WebKit::DatabaseToWebProcessConnection::removeDatabaseProcessIDBConnection): Added for WebProcess to be able
to invalidate the DatabaseProcess side of a server connection.
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
(WebKit::DatabaseProcessIDBConnection::disconnectedFromWebProcess): Added for future cleanup.
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata): Callback to the WebProcess, even if
it is just dummy data for now.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
(WebKit::DatabaseProcessIDBConnection::create):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::create): Register the new object with the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::~WebIDBServerConnection): Remove from the WebToDatabaseProcessConnection.
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata): Callback from the DatabaseProcess,
a no-op for now.
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in: Copied from Source/WebKit2/DatabaseProcess/DatabaseToWebProcessConnection.messages.in.
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage):
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::registerWebIDBServerConnection): Hold a collection of all
server connections for messaging.
(WebKit::WebToDatabaseProcessConnection::removeWebIDBServerConnection): Remove a connection from the collection,
and also message the DatabaseProcess that it’s gone away.
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
Project files, etc etc:
- DerivedSources.make:
- Scripts/webkit2/messages.py:
(struct_or_class):
- WebKit2.xcodeproj/project.pbxproj:
- 11:00 PM Changeset in webkit [159610] by
-
- 4 edits in trunk
Hoist <template> to head when found between </head> and <body> for consistency with <script>
https://bugs.webkit.org/show_bug.cgi?id=123949
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495
Move template elements between head and body elements into the head to be consistent with script elements.
The HTML5 specification was changed in http://html5.org/tools/web-apps-tracker?from=8217&to=8218.
Inline comments below are cited from https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002
and https://codereview.chromium.org/25900003 for clarity.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTag): Add the template element to the list of elements to be hoisted into
the head element.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
Replace the assertion that isParsingFragment is true when item->node() == m_tree.openElements()->rootNode() since,
with this change, we can now invoke resetInsertionMode when parsing a normal document (not fragment) and there is
only the html element on the stack of open elements.
For the second change, consider: <head></head><template>
This example breaks in the old HTML parser because the template element is handled by "after head" state which
pushes the head element back on, processes the template element for "in head", then pops the head element off.
EOF is reached, which processes a fake close tag for the template element, which pops the template element off
and resets the insertion mode appropriately
The problem here is that "reset the insertion mode" is going to inspect the bottom-most element on the stack which
is now the html element and it will set the mode to "before head". Nothing good happens after this.
We fix this problem by having the reset algorithm check if the head element pointer is set, and if so, go to after
head instead of before head.
LayoutTests:
Merge https://chromium.googlesource.com/chromium/blink/+/835fb468fd211054a920fb7612a6dc5043662495
and added two more test cases discussed in https://www.w3.org/Bugs/Public/show_bug.cgi?id=23002.
- html5lib/resources/template.dat:
- 10:57 PM Changeset in webkit [159609] by
-
- 51 edits1 copy18 adds5 deletes in trunk
[CSS Regions] Implement visual overflow for first & last regions
https://bugs.webkit.org/show_bug.cgi?id=118665
Source/WebCore:
In order to properly propagate the visual overflow of elements flowed inside regions,
the responsiblity of painting and hit-testing content inside flow threads has been
moved to the flow thread layer's level.
Each region keeps the associated overflow with each box in the RenderBoxRegionInfo
structure, including one for the flow thread itself. This data is used during
painting and hit-testing.
Reviewed by David Hyatt.
Tests: fast/regions/overflow-first-and-last-regions-in-container-hidden.html
fast/regions/overflow-first-and-last-regions.html
fast/regions/overflow-nested-regions.html
fast/regions/overflow-region-float.html
fast/regions/overflow-region-inline.html
fast/regions/overflow-region-transform.html
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::setLayoutOverflow):
(WebCore::InlineFlowBox::setVisualOverflow):
- rendering/InlineFlowBox.h:
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::paintObject):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):
(WebCore::RenderBlock::updateRegionRangeForBoxChild):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::hasNextPage):
(WebCore::RenderBlockFlow::relayoutForPagination):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::positionNewFloatOnLine):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::addVisualOverflow):
(WebCore::RenderBox::isUnsplittableForPagination):
(WebCore::RenderBox::overflowRectForPaintRejection):
- rendering/RenderBox.h:
(WebCore::RenderBox::canHaveOutsideRegionRange):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- rendering/RenderBoxModelObject.h:
- rendering/RenderBoxRegionInfo.h:
(WebCore::RenderBoxRegionInfo::createOverflow):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):
(WebCore::RenderFlowThread::mapFromLocalToFlowThread):
(WebCore::RenderFlowThread::mapFromFlowThreadToLocal):
(WebCore::RenderFlowThread::decorationsClipRectForBoxInRegion):
(WebCore::RenderFlowThread::flipForWritingModeLocalCoordinates):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
(WebCore::RenderFlowThread::addRegionsVisualOverflow):
(WebCore::CurrentRenderFlowThreadMaintainer::CurrentRenderFlowThreadMaintainer):
- rendering/RenderFlowThread.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForRegionAndReflection):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
(WebCore::RenderLayer::parentClipRects):
(WebCore::RenderLayer::calculateRects):
(WebCore::RenderLayer::intersectsDamageRect):
(WebCore::RenderLayer::updateDescendantsLayerListsIfNeeded):
(WebCore::RenderLayer::repaintIncludingDescendants):
(WebCore::RenderLayer::paintNamedFlowThreadInsideRegion):
(WebCore::RenderLayer::paintFlowThreadIfRegion):
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):
- rendering/RenderLayer.h:
(WebCore::ClipRect::inflateX):
(WebCore::ClipRect::inflateY):
(WebCore::ClipRect::inflate):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::addOverflowFromChildren):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
(WebCore::RenderMultiColumnSet::repaintFlowThreadContent):
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::createStyle):
(WebCore::RenderNamedFlowFragment::namedFlowThread):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderOverflow.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::flowThreadPortionOverflowRect):
(WebCore::RenderRegion::flowThreadPortionLocation):
(WebCore::RenderRegion::regionContainerLayer):
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::computeOverflowFromFlowThread):
(WebCore::RenderRegion::repaintFlowThreadContent):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::ensureOverflowForBox):
(WebCore::RenderRegion::rectFlowPortionForBox):
(WebCore::RenderRegion::addLayoutOverflowForBox):
(WebCore::RenderRegion::addVisualOverflowForBox):
(WebCore::RenderRegion::layoutOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):
- rendering/RenderRegion.h:
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::shouldPaint):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::paint):
LayoutTests:
Rebased some tests due to regions layers changes.
Updated some tests to increase clarity. Some of them were only passing because two
regions were close together and the fact that an element was being painted
inside the wrong region was not visible. Floats are now also unsplittable.
- bottom-overflow-out-of-first-region
- float-pushed-width-change-2
- float-pushed-width-change
- webkit-flow-float-unable-to-push
Changed top-overflow-out-of-second-region to reftest.
Added new tests for testing the visual overflow in different situations
(transformed, inline, opacity, floating).
Reviewed by David Hyatt.
- fast/regions/bottom-overflow-out-of-first-region-expected.html:
- fast/regions/bottom-overflow-out-of-first-region.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html:
- fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html:
- fast/regions/element-in-named-flow-absolute-from-fixed-expected.txt:
- fast/regions/element-in-named-flow-fixed-from-absolute-expected.txt:
- fast/regions/element-inflow-fixed-from-outflow-static-expected.txt:
- fast/regions/element-outflow-static-from-inflow-fixed-expected.txt:
- fast/regions/float-pushed-width-change-2-expected.html:
- fast/regions/float-pushed-width-change-2.html:
- fast/regions/float-pushed-width-change-expected.html:
- fast/regions/float-pushed-width-change.html:
- fast/regions/layers/dynamic-layer-added-with-no-layout-expected.txt: Added.
- fast/regions/layers/dynamic-layer-removed-with-no-layout-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-horizontal-bt-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-vertical-lr-expected.txt: Added.
- fast/regions/layers/regions-promoted-to-layers-vertical-rl-expected.txt: Added.
- fast/regions/outline-sides-in-region-expected.html:
- fast/regions/outline-sides-in-region.html:
- fast/regions/overflow-first-and-last-regions-expected.html: Added.
- fast/regions/overflow-first-and-last-regions-in-container-hidden-expected.html: Added.
- fast/regions/overflow-first-and-last-regions-in-container-hidden.html: Added.
- fast/regions/overflow-first-and-last-regions.html: Added.
- fast/regions/overflow-last-region-expected.html: Removed.
- fast/regions/overflow-last-region.html: Removed.
- fast/regions/overflow-nested-regions-expected.html: Added.
- fast/regions/overflow-nested-regions.html: Added.
- fast/regions/overflow-region-float-expected.html: Added.
- fast/regions/overflow-region-float.html: Added.
- fast/regions/overflow-region-inline-expected.html: Added.
- fast/regions/overflow-region-inline.html: Added.
- fast/regions/overflow-region-transform-expected.html: Added.
- fast/regions/overflow-region-transform.html: Added.
- fast/regions/overflow-scrollable-rotated-fragment-expected.html:
- fast/regions/overflow-scrollable-rotated-fragment.html:
- fast/regions/top-overflow-out-of-second-region-expected.html: Copied from LayoutTests/fast/regions/top-overflow-out-of-second-region.html.
- fast/regions/top-overflow-out-of-second-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html:
- fast/regions/webkit-flow-float-unable-to-push.html:
- platform/gtk/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
- platform/gtk/TestExpectations: Add new test expectations for failing tests.
- platform/efl/TestExpectations: Add new test expectations for failing tests.
- platform/mac-wk2/TestExpectations:
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
- platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
- 10:22 PM Changeset in webkit [159608] by
-
- 2 edits in trunk/LayoutTests
Test a template element appearing after a closing body tag in html5lib
https://bugs.webkit.org/show_bug.cgi?id=123864
Reviewed by Antti Koivisto.
Merge https://chromium.googlesource.com/chromium/blink/+/019d5daa14314972ac6b3e42e9446823ad9cffd2
- html5lib/resources/template.dat:
- 10:10 PM Changeset in webkit [159607] by
-
- 4 edits in trunk
[HTML parser] reset insertion mode appropriate must check for "in select in table" mode
https://bugs.webkit.org/show_bug.cgi?id=123850
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/2cb7523df57dfb48111f6aa16b7138cd54024ba7
The HTML specification has been updated to detect encountering a template element inside of a select element,
which in turn is inside of a table element. In this case, the select element will cause the parser to be in
"InSelectInTable" mode. Thus when the template element closes, it should return to that mode.
The fix here is that resetInsertionModeAppropriately must continue looking up the stack if the first node is
select element to see whether the select element is inside of a table element.
Test: html5lib/resources/template.dat
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
LayoutTests:
- html5lib/resources/template.dat:
- 9:46 PM Changeset in webkit [159606] by
-
- 2 edits in trunk/Source/WebCore
Build fix for last commit.
https://bugs.webkit.org/show_bug.cgi?id=124634.
Not reviewed.
No new tests.
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
- 9:29 PM Changeset in webkit [159605] by
-
- 63 edits3 adds1 delete in trunk/Source
Introducing VMEntryScope to update the VM stack limit.
https://bugs.webkit.org/show_bug.cgi?id=124634.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Introduced USE(SEPARATE_C_AND_JS_STACK) (defined in Platform.h). Currently, it is hardcoded to use separate C and JS stacks. Once we switch to using the C stack for JS frames, we'll need to fix this to only be enabled when ENABLE(LLINT_C_LOOP).
- Stack limits are now tracked in the VM.
Logically, there are 2 stack limits:
- m_stackLimit for the native C stack, and
- m_jsStackLimit for the JS stack.
If USE(SEPARATE_C_AND_JS_STACK), then the 2 limits are the same
value, and are implemented as 2 fields in a union.
- The VM native stackLimit is set as follows:
- Initially, the VM sets it to the limit of the stack of the thread that instantiated the VM. This allows the parser and bytecode generator to run before we enter the VM to execute JS code.
- Upon entry into the VM to execute JS code (via one of the Interpreter::execute...() functions), we instantiate a VMEntryScope that sets the VM's stackLimit to the limit of the current thread's stack. The VMEntryScope will automatically restore the previous entryScope and stack limit upon destruction.
If USE(SEPARATE_C_AND_JS_STACK), the JSStack's methods will set the VM's
jsStackLimit whenever it grows or shrinks.
- The VM now provides a isSafeToRecurse() function that compares the current stack pointer against its native stackLimit. This subsumes and obsoletes the VMStackBounds class.
- The VMEntryScope class also subsumes DynamicGlobalObjectScope for tracking the JSGlobalObject that we last entered the VM with.
- Renamed dynamicGlobalObject() to vmEntryGlobalObject() since that is the value that the function retrieves.
- Changed JIT and LLINT code to do stack checks against the jsStackLimit in the VM class instead of the JSStack.
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
- API/JSContextRef.cpp:
(JSGlobalContextRetain):
(JSGlobalContextRelease):
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- debugger/Debugger.cpp:
(JSC::Debugger::detach):
(JSC::Debugger::recompileAllJSFunctions):
(JSC::Debugger::pauseIfNeeded):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::vmEntryGlobalObject):
- debugger/DebuggerCallFrame.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGOSREntry.cpp:
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLOSREntry.cpp:
- heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::deleteAllCompiledCode):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/CallFrame.cpp:
(JSC::CallFrame::vmEntryGlobalObject):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::Interpreter::unwind):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::debug):
- interpreter/JSStack.cpp:
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
- interpreter/JSStack.h:
- interpreter/JSStackInlines.h:
(JSC::JSStack::shrink):
(JSC::JSStack::grow):
- Moved these inlined functions here from JSStack.h. It reduces some #include dependencies of JSSTack.h which had previously resulted in some EWS bots' unhappiness with this patch.
(JSC::JSStack::updateStackLimit):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileLoadVarargs):
- jit/JITOperations.cpp:
- llint/LLIntSlowPaths.cpp:
- llint/LowLevelInterpreter.asm:
- parser/Parser.cpp:
(JSC::::Parser):
- parser/Parser.h:
(JSC::Parser::canRecurse):
- runtime/CommonSlowPaths.h:
- runtime/Completion.cpp:
(JSC::evaluate):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- runtime/JSGlobalObject.cpp:
- runtime/JSGlobalObject.h:
- runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::throwException):
- runtime/VM.h:
(JSC::VM::addressOfJSStackLimit):
(JSC::VM::jsStackLimit):
(JSC::VM::setJSStackLimit):
(JSC::VM::stackLimit):
(JSC::VM::setStackLimit):
(JSC::VM::isSafeToRecurse):
- runtime/VMEntryScope.cpp: Added.
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
(JSC::VMEntryScope::requiredCapacity):
- runtime/VMEntryScope.h: Added.
(JSC::VMEntryScope::globalObject):
- runtime/VMStackBounds.h: Removed.
Source/WebCore:
No new tests.
Renamed dynamicGlobalObject() to vmEntryGlobalObject().
Replaced uses of DynamicGlobalObjectScope with VMEntryScope.
- ForwardingHeaders/runtime/VMEntryScope.h: Added.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- bindings/js/JSCryptoAlgorithmBuilder.cpp:
(WebCore::JSCryptoAlgorithmBuilder::add):
- bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::create):
- bindings/js/JSDOMBinding.cpp:
(WebCore::firstDOMWindow):
- bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
- bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
- bindings/js/JavaScriptCallFrame.h:
(WebCore::JavaScriptCallFrame::vmEntryGlobalObject):
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::recompileAllJSFunctions):
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::evaluateBreakpointAction):
(WebCore::ScriptDebugServer::handlePause):
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
- bindings/objc/WebScriptObject.mm:
(WebCore::addExceptionToConsole):
- bridge/c/c_utility.cpp:
(JSC::Bindings::convertValueToNPVariant):
- bridge/objc/objc_instance.mm:
(ObjcInstance::moveGlobalExceptionToExecState):
- bridge/objc/objc_runtime.mm:
(JSC::Bindings::convertValueToObjcObject):
- bridge/objc/objc_utility.mm:
(JSC::Bindings::convertValueToObjcValue):
Source/WebKit/mac:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::sourceParsed):
Source/WTF:
- wtf/Platform.h:
- wtf/StackBounds.h:
(WTF::StackBounds::StackBounds):
- 8:45 PM Changeset in webkit [159604] by
-
- 19 edits in trunk/Source/WebCore
Generate toHTMLFooElement() to clean up static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=124571
Reviewed by Ryosuke Niwa.
Though there are a lot of clean up commits before, there are still
use of static_cast<HTMLFooElement*>. To clean up them, we need to generate
toHTMLDetails|Meta|Summary|TableCaptionElement().
Additionally, other static_cast<> are removed as well.
No new tests, no behavior changes.
- html/HTMLDetailsElement.h:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::selectNextSourceChild):
- html/HTMLMetaElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetCallback):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::detailsElement):
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::caption):
- html/HTMLTagNames.in:
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::summaryElement):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::handleFallbackContent):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
- page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):
- page/SpatialNavigation.cpp:
(WebCore::frameOwnerElement):
- 8:09 PM Changeset in webkit [159603] by
-
- 21 edits in trunk/Source/WebKit2
WebPageGroup's should keep track of what processes they are being used by
https://bugs.webkit.org/show_bug.cgi?id=124556
Reviewed by Dan Bernstein.
- Scripts/webkit2/messages.py:
(struct_or_class):
Mark WebPageGroupData as a struct.
- Shared/UserMessageCoders.h:
- Shared/mac/ObjCObjectGraphCoders.h:
- Shared/mac/ObjCObjectGraphCoders.mm:
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
- UIProcess/WebConnectionToWebProcess.cpp:
- UIProcess/WebContext.cpp:
- UIProcess/WebContextUserMessageCoders.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
Pass the WebProcess/WebProcessProxy to both encode and decode.
- Shared/WebPageCreationParameters.h:
Pass the page group by ID when creating a page, as it will have had its own
creation message sent already.
- UIProcess/WebPageGroup.cpp:
- UIProcess/WebPageGroup.h:
Keep track of processes.
- UIProcess/WebProcessProxy.cpp:
- UIProcess/WebProcessProxy.h:
Keep track of the page groups used by the process.
- WebProcess/WebPage/WebPage.cpp:
Get the already created page group on creation.
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
Explicitly create page groups in the WebProcess.
- 6:00 PM Changeset in webkit [159602] by
-
- 4 edits in trunk/Tools
Allow settings to be shown/hidden on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124694
Reviewed by Tim Horton.
In preparation for more options/buttons, allow the page to
show or hide all the interactive things using a little gear icon
in the top left corner.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
(Settings.prototype.toggleSettingsDisplay):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(div.cellButton.hide):
(div.cellButton.unhide):
(.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
(.settings):
(.settings:hover):
(.settings-visible .settings):
- 5:59 PM Changeset in webkit [159601] by
-
- 2 edits in trunk/Tools
No need to base64 SVG on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124687
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.good .bubble.pictogram):
- 5:59 PM Changeset in webkit [159600] by
-
- 3 edits in trunk/Tools
Make links look more like links on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124686
Reviewed by Tim Horton.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
(.queue-view .queueLabel:hover):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
(.status-line.linked .label:hover):
- 5:39 PM Changeset in webkit [159599] by
-
- 2 edits in trunk/Tools
Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
https://bugs.webkit.org/show_bug.cgi?id=124581
Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-20
Reviewed by Daniel Bates.
Some subroutines are replicating code from checkForArgument
functions instead of reusing them as is being done by all other functions.
- Scripts/webkitdirs.pm:
(determineXcodeSDK): Added.
(determinePassedConfiguration): Added.
(determinePassedArchitecture): Added.
(checkForArgumentAndRemoveFromARGV): Added.
(checkForArgumentAndRemoveFromARGVGettingValue): Added.
- 5:28 PM Changeset in webkit [159598] by
-
- 8 edits in trunk/Source/WebKit2
IDB related cleanup in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=124691
Reviewed by Enrica Casucci.
- WebIDBServerConnection.cpp should use the WebCore namespace and get rid of "WebCore::" throughout
- "backendIndentifier" should be renamed to "serverConnectionIdentifier" throughout
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::establishIDBConnection):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::DatabaseProcessIDBConnection):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
(WebKit::DatabaseProcessIDBConnection::create):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::generateServerConnectionIdentifier):
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::setIndexKeys):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
(WebKit::WebIDBServerConnection::cursorPrefetchIteration):
(WebKit::WebIDBServerConnection::cursorPrefetchReset):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 5:11 PM Changeset in webkit [159597] by
-
- 3 edits in trunk/Source/WebKit2
Add argument coders for IDBDatabaseMetadata classes
https://bugs.webkit.org/show_bug.cgi?id=124689
Reviewed by Anders Carlsson.
Add coders for:
- IDBDatabaseMetadata
- IDBIndexMetadata
- IDBKeyPath
- IDBObjectStoreMetadata
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
- 5:07 PM Changeset in webkit [159596] by
-
- 5 edits2 adds in trunk
Clear TemplateContentDocumentFragment::m_host when HTMLTemplateElement is destroyed
https://bugs.webkit.org/show_bug.cgi?id=122806
Reviewed by Antti Koivisto.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/858ed5f6341de9d900768c1f4668fcfce870c52e
The document fragment of a template element outlives the element itself.
Clear the host property on the document fragment when that happens.
Test: fast/dom/HTMLTemplateElement/content-outlives-template-crash.html
- dom/TemplateContentDocumentFragment.h:
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::~HTMLTemplateElement):
- html/HTMLTemplateElement.h:
LayoutTests:
- fast/dom/HTMLTemplateElement/content-outlives-template-crash-expected.txt: Added.
- fast/dom/HTMLTemplateElement/content-outlives-template-crash.html: Added.
- 4:54 PM Changeset in webkit [159595] by
-
- 3 edits2 deletes in trunk/Tools
Delete baseline optimizer
https://bugs.webkit.org/show_bug.cgi?id=122333
Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/baselineoptimizer.py: Removed.
- Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._files_to_add):
(AbstractParallelRebaselineCommand._rebaseline):
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineJson.test_rebaseline_all):
(TestRebaselineJson.test_rebaseline_debug):
(TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
- 4:42 PM Changeset in webkit [159594] by
-
- 5 edits in branches/safari-537.73-branch/Source
Versioning.
- 4:42 PM Changeset in webkit [159593] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Win] JavaScript JIT crash (with DFG enabled).
https://bugs.webkit.org/show_bug.cgi?id=124675
Reviewed by Geoffrey Garen.
Similar to the change in r159427, changed linkClosureCall to use regT0/regT1 (payload/tag) for the callee.
linkForThunkGenerator already expected the callee in regT0/regT1, but changed the comment to reflect that.
- jit/Repatch.cpp:
(JSC::linkClosureCall):
- jit/ThunkGenerators.cpp:
(JSC::linkForThunkGenerator):
- 4:41 PM Changeset in webkit [159592] by
-
- 1 copy in tags/Safari-537.73.13
New Tag.
- 4:28 PM Changeset in webkit [159591] by
-
- 16 edits2 adds in trunk
AX: Implement CSS -webkit-alt property (text alternative for generated content pseudo-elements ::before and ::after)
https://bugs.webkit.org/show_bug.cgi?id=120188
Reviewed by Dean Jackson.
Source/WebCore:
Add a -webkit-alt CSS property that can be used to label Image content or Text content for accessibility clients.
To accomplish this, it sets the string in the RenderStyle. Then when the ContentData creates an anonymous renderer,
it sets that string on the TextFragment or RenderImage, which can be queried by accessibility code.
Test: platform/mac/accessibility/webkit-alt-for-css-content.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
(WebCore::objectInclusionFromAltText):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::altTextToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAlt):
- css/CSSParser.h:
- css/CSSPropertyNames.in:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- rendering/RenderImage.h:
(WebCore::RenderImage::altText):
(WebCore::RenderImage::setAltText):
- rendering/RenderTextFragment.h:
- rendering/style/ContentData.cpp:
(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):
- rendering/style/ContentData.h:
(WebCore::ContentData::setAltText):
(WebCore::ContentData::altText):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent):
(WebCore::RenderStyle::setContentAltText):
(WebCore::RenderStyle::contentAltText):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareNonInheritedData.h:
LayoutTests:
- platform/mac/accessibility/webkit-alt-for-css-content-expected.txt: Added.
- platform/mac/accessibility/webkit-alt-for-css-content.html: Added.
- 4:05 PM Changeset in webkit [159590] by
-
- 2 edits in trunk/Source/WebCore
Use compile flag SH_UNFOLD_SHORT_CIRCUIT when compiling shaders.
https://bugs.webkit.org/show_bug.cgi?id=124684.
Reviewed by Brent Fulgham.
Existing test webgl/1.0.2/conformance/glsl/misc/shader-with-short-circuiting-operators.html
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
- 3:55 PM Changeset in webkit [159589] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Updated expected result following
https://bugs.webkit.org/show_bug.cgi?id=124666
- platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
- platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 3:36 PM Changeset in webkit [159588] by
-
- 5 edits2 copies in branches/safari-537.73-branch
Merged r159481. <rdar://problem/15517466>
- 3:25 PM Changeset in webkit [159587] by
-
- 8 edits2 adds in trunk/Source/WebCore
[curl] Improve detecting and handling of SSL related errors
https://bugs.webkit.org/show_bug.cgi?id=119436
Patch by Robert Sipka <sipka@inf.u-szeged.hu> on 2013-11-20
Reviewed by Brent Fulgham.
Set the exact SSL verification error on CURL
and store the enabled domain with certificate.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
- platform/network/curl/ResourceError.h:
(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors):
(WebCore::ResourceError::setSSLErrors):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::setHostAllowsAnyHTTPSCertificate):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::initializeHandle):
- platform/network/curl/SSLHandle.cpp: Added.
(WebCore::allowsAnyHTTPSCertificateHosts):
(WebCore::sslIgnoreHTTPSCertificate):
(WebCore::sslCertificateFlag):
(WebCore::pemData):
(WebCore::certVerifyCallback):
(WebCore::sslctxfun):
(WebCore::setSSLVerifyOptions):
- platform/network/curl/SSLHandle.h: Added.
- 3:22 PM Changeset in webkit [159586] by
-
- 4 edits in trunk
Enable PageLoadTest assertions again
https://bugs.webkit.org/show_bug.cgi?id=124681
Reviewed by Tim Horton.
Source/WebKit2:
Remove an overzealous assertion and re-enable assertions in PageLoadState again.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::didCommitLoad):
Remove assertion - it's fine for a page to have a null URL.
(WebKit::PageLoadState::didFinishLoad):
Ditto.
(WebKit::PageLoadState::didFailLoad):
Update the state.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Actually install all-content-in-one-iframe.html, noticed while debugging this assertion.
- 2:55 PM Changeset in webkit [159585] by
-
- 16 edits in trunk
[css shapes] Parse new circle shape syntax
https://bugs.webkit.org/show_bug.cgi?id=124618
Reviewed by Antti Koivisto.
Source/WebCore:
Implement parsing of the new cicle shape syntax. The implementation of
the old syntax has been move aside as deprecated, and will be removed
once the new syntax is stable.
Updated existing parsing tests to cover this.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForCenterCoordinate): Create a CSSPrimitiveValue from a
BasicShapeCenterCoordinate.
(WebCore::valueForBasicShape): Convert new basic shape and rename old
one.
(WebCore::convertToCenterCoordinate): Create a
BasicShapeCenterCoordinate from a CSSPrimitiveValue.
(WebCore::basicShapeForValue): Convert new shape value and rename old
one.
- css/CSSBasicShapes.cpp:
(WebCore::buildCircleString): Build a new circle string.
(WebCore::CSSBasicShapeCircle::cssText): Serialize the new circle
shape.
(WebCore::CSSBasicShapeCircle::equals): Compare new circle shapes.
(WebCore::CSSBasicShapeCircle::serializeResolvingVariables):
- css/CSSBasicShapes.h:
(WebCore::CSSBasicShapeCircle::CSSBasicShapeCircle): Add class for new
circle shape.
(WebCore::CSSDeprecatedBasicShapeCircle::create): Renamed to move out
of the way of the new circle implementation.
(WebCore::CSSDeprecatedBasicShapeCircle::centerX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::centerY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::radius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterX): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setCenterY): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::setRadius): Ditto.
(WebCore::CSSDeprecatedBasicShapeCircle::CSSDeprecatedBasicShapeCircle): Ditto.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeRadius): Parse the radius for the new
circle syntax. Will also be used by the new ellipse syntax.
(WebCore::CSSParser::parseBasicShapeCircle): Parse the new circle
syntax.
(WebCore::CSSParser::parseDeprecatedBasicShapeCircle): Rename to make
way for the new implementation.
(WebCore::isDeprecatedBasicShape): Check if we have a new circle or an
old circle.
(WebCore::CSSParser::parseBasicShape): Update to parse the new circle
syntax.
- css/CSSParser.h:
- css/CSSValueKeywords.in: Add support for the new circle keywords.
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
- rendering/style/BasicShapes.cpp: Deprecate old circle and add stub
for layout code.
(WebCore::DeprecatedBasicShapeCircle::path): Rename to make way for
the new implementation.
(WebCore::DeprecatedBasicShapeCircle::blend): Rename to make way for
the new implementation.
(WebCore::BasicShapeCircle::path): Create path for new circle shape.
(WebCore::BasicShapeCircle::blend): Interpolate the new circle shape.
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate):
Represent an x or y coordinate for the center of a new circle,
since it can be either a keyword along with an offset that cannot
be resolved until layout time or an ordinary Length. This will
also be used by the new ellipse implementation.
(WebCore::BasicShapeCenterCoordinate::keyword):
(WebCore::BasicShapeCenterCoordinate::length):
(WebCore::BasicShapeCenterCoordinate::blend): Interpolate.
(WebCore::BasicShapeRadius::BasicShapeRadius): Represent the radius of
a new circle shape since it can either be a straightforward Length or
a keyword that cannot be resolved until layout time.
(WebCore::BasicShapeRadius::value):
(WebCore::BasicShapeRadius::type):
(WebCore::BasicShapeRadius::blend): Interpolate.
(WebCore::BasicShapeCircle::centerX):
(WebCore::BasicShapeCircle::centerY):
(WebCore::BasicShapeCircle::radius):
(WebCore::BasicShapeCircle::setCenterX):
(WebCore::BasicShapeCircle::setCenterY):
(WebCore::BasicShapeCircle::setRadius):
(WebCore::BasicShapeCircle::BasicShapeCircle): New circle class.
(WebCore::DeprecatedBasicShapeCircle::create): Rename to make room for
new circle implementation.
(WebCore::DeprecatedBasicShapeCircle::DeprecatedBasicShapeCircle): Ditto.
LayoutTests:
Test that the new circle shape syntax is properly parsed.
- fast/shapes/parsing/parsing-shape-inside-expected.txt:
- fast/shapes/parsing/parsing-shape-outside-expected.txt:
- fast/shapes/parsing/parsing-test-utils.js:
- fast/masking/parsing-clip-path-shape-expected.txt:
- fast/masking/parsing-clip-path-shape.html:
- 2:22 PM Changeset in webkit [159584] by
-
- 4 edits in trunk/Source/WebKit2
PageLoadState should keep track of unreachable URLs
https://bugs.webkit.org/show_bug.cgi?id=124677
Reviewed by Dan Bernstein.
- UIProcess/PageLoadState.cpp:
(WebKit::PageLoadState::reset):
(WebKit::PageLoadState::didStartProvisionalLoad):
(WebKit::PageLoadState::didFailProvisionalLoad):
(WebKit::PageLoadState::setUnreachableURL):
- UIProcess/PageLoadState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadAlternateHTMLString):
- 2:21 PM Changeset in webkit [159583] by
-
- 7 edits4 adds in trunk/Source/WebCore
[CSS Shapes] Add BoxShape and FloatRoundingRect classes
https://bugs.webkit.org/show_bug.cgi?id=124368
Reviewed by Dean Jackson.
Added the BoxShape class. It's now used to represent shape-outside box
values: [margin/border/padding/content]-box. BoxShape depends on a new
FloatRoundedRect class, which is a float analog of the existing (int)
RoundedRect class. The FloatRoundedRect class contains the same basic
methods and accessors as BorderRect and adds a set of four methods,
for example topLeftCorner(), that return a FloatRect that represents the
bounds of one elliptical corner. I also added a method, xInterceptsAtY()
that returns two X coordinates of the intersection between a horizontal
line and the rounded rectangle.
No new tests, this is just an internal refactoring.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FloatRoundedRect.cpp: Added.
(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::Radii::isZero):
(WebCore::FloatRoundedRect::Radii::scale):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::cornerRectIntercept):
(WebCore::FloatRoundedRect::xInterceptsAtY):
- platform/graphics/FloatRoundedRect.h: Added.
(WebCore::FloatRoundedRect::Radii::Radii):
(WebCore::FloatRoundedRect::Radii::setTopLeft):
(WebCore::FloatRoundedRect::Radii::setTopRight):
(WebCore::FloatRoundedRect::Radii::setBottomLeft):
(WebCore::FloatRoundedRect::Radii::setBottomRight):
(WebCore::FloatRoundedRect::Radii::topLeft):
(WebCore::FloatRoundedRect::Radii::topRight):
(WebCore::FloatRoundedRect::Radii::bottomLeft):
(WebCore::FloatRoundedRect::Radii::bottomRight):
(WebCore::FloatRoundedRect::Radii::expand):
(WebCore::FloatRoundedRect::Radii::shrink):
(WebCore::FloatRoundedRect::rect):
(WebCore::FloatRoundedRect::radii):
(WebCore::FloatRoundedRect::isRounded):
(WebCore::FloatRoundedRect::isEmpty):
(WebCore::FloatRoundedRect::setRect):
(WebCore::FloatRoundedRect::setRadii):
(WebCore::FloatRoundedRect::move):
(WebCore::FloatRoundedRect::inflate):
(WebCore::FloatRoundedRect::expandRadii):
(WebCore::FloatRoundedRect::shrinkRadii):
(WebCore::FloatRoundedRect::topLeftCorner):
(WebCore::FloatRoundedRect::topRightCorner):
(WebCore::FloatRoundedRect::bottomLeftCorner):
(WebCore::FloatRoundedRect::bottomRightCorner):
(WebCore::operator==):
- rendering/shapes/BoxShape.cpp: Added.
(WebCore::BoxShape::BoxShape):
(WebCore::BoxShape::getExcludedIntervals):
(WebCore::BoxShape::getIncludedIntervals):
(WebCore::BoxShape::firstIncludedIntervalLogicalTop):
- rendering/shapes/BoxShape.h: Added.
- rendering/shapes/Shape.cpp:
(WebCore::createBoxShape):
(WebCore::Shape::createShape):
- 1:44 PM Changeset in webkit [159582] by
-
- 2 edits in trunk/Source/WebKit2
Remote Layer Tree: 100% repro crasher on the IPC thread when creating lots of layers
https://bugs.webkit.org/show_bug.cgi?id=124643
Reviewed by Anders Carlsson.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::sendOutgoingMessage):
Dynamically allocate storage for the message if needed.
- 1:29 PM Changeset in webkit [159581] by
-
- 2 edits in trunk/Source/WebKit2
machMessageSize uses sizeof(mach_msg_ool_ports_descriptor_t) for out-of-line *memory*
https://bugs.webkit.org/show_bug.cgi?id=124644
Reviewed by Anders Carlsson.
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::machMessageSize):
mach_msg_ool_descriptor_t is the correct type, given that
out-of-line memory descriptors use the mach_msg_ool_descriptor_t
member of the mach_msg_descriptor_t union.
- 1:24 PM Changeset in webkit [159580] by
-
- 4 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=124637
Unreviewed. Adding HTMLTemplateElement to global constructor
test, but this time for more platforms. I'm not sure if
GTK and EFL need this too.
- platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
- 1:23 PM Changeset in webkit [159579] by
-
- 5 edits4 adds in trunk
Simple line layout should support floats
https://bugs.webkit.org/show_bug.cgi?id=124666
Reviewed by Dave Hyatt.
Source/WebCore:
Tests: fast/text/simple-lines-float-compare.html
fast/text/simple-lines-float.html
- rendering/line/LineWidth.h:
(WebCore::LineWidth::logicalLeftOffset):
Expose the left offset so we don't need to recompute it.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::computeLineLeft):
Include the left offset from floats.
(WebCore::SimpleLineLayout::createTextRuns):
Keep the flow height updated during the loop as LineWidth reads the current position from there.
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
We now bake the border and the padding to the line left offset. No need to add it during resolve.
LayoutTests:
- fast/text/simple-lines-float-compare-expected.html: Added.
- fast/text/simple-lines-float-compare.html: Added.
- fast/text/simple-lines-float-expected.html: Added.
- fast/text/simple-lines-float.html: Added.
- 1:18 PM Changeset in webkit [159578] by
-
- 27 edits in trunk/Source/WebCore
Use std::function callbacks in CryptoAlgorithm instead of JS promises
https://bugs.webkit.org/show_bug.cgi?id=124673
Reviewed by Anders Carlsson.
To implement key wrapping/unwrapping, we'll need to chain existing operations.
It's much easier to do with C++ callbacks than with functions fulfilling JS
promises directly.
Also, this will decouple CryptoAlgorithm from JS, which is nice.
SubtleCrypto IDL says that all functions return Promise<any>, but in reality,
there is very little polymorphism, the only function whose return type depends
on algorithm is generateKey (it can create a Key or a KeyPair).
- bindings/js/JSDOMPromise.cpp:
(WebCore::PromiseWrapper::PromiseWrapper):
(WebCore::PromiseWrapper::operator=):
- bindings/js/JSDOMPromise.h:
Made it copyable, as each crypto function wraps the promise in success and failure
functional objects now.
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::generateKey):
(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::exportKey):
- crypto/CryptoAlgorithm.cpp:
(WebCore::CryptoAlgorithm::encrypt):
(WebCore::CryptoAlgorithm::decrypt):
(WebCore::CryptoAlgorithm::sign):
(WebCore::CryptoAlgorithm::verify):
(WebCore::CryptoAlgorithm::digest):
(WebCore::CryptoAlgorithm::generateKey):
(WebCore::CryptoAlgorithm::deriveKey):
(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::importKey):
- crypto/CryptoAlgorithm.h:
- crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
- crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
(WebCore::CryptoAlgorithmAES_CBC::generateKey):
(WebCore::CryptoAlgorithmAES_CBC::importKey):
- crypto/algorithms/CryptoAlgorithmAES_CBC.h:
- crypto/algorithms/CryptoAlgorithmHMAC.cpp:
(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):
- crypto/algorithms/CryptoAlgorithmHMAC.h:
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey):
- crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
- crypto/algorithms/CryptoAlgorithmSHA1.cpp:
(WebCore::CryptoAlgorithmSHA1::digest):
- crypto/algorithms/CryptoAlgorithmSHA1.h:
- crypto/algorithms/CryptoAlgorithmSHA224.cpp:
(WebCore::CryptoAlgorithmSHA224::digest):
- crypto/algorithms/CryptoAlgorithmSHA224.h:
- crypto/algorithms/CryptoAlgorithmSHA256.cpp:
(WebCore::CryptoAlgorithmSHA256::digest):
- crypto/algorithms/CryptoAlgorithmSHA256.h:
- crypto/algorithms/CryptoAlgorithmSHA384.cpp:
(WebCore::CryptoAlgorithmSHA384::digest):
- crypto/algorithms/CryptoAlgorithmSHA384.h:
- crypto/algorithms/CryptoAlgorithmSHA512.cpp:
(WebCore::CryptoAlgorithmSHA512::digest):
- crypto/algorithms/CryptoAlgorithmSHA512.h:
- crypto/keys/CryptoKeyRSA.h:
- crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):
- crypto/mac/CryptoAlgorithmHMACMac.cpp:
(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
- crypto/mac/CryptoKeyRSAMac.cpp:
(WebCore::CryptoKeyRSA::generatePair):
- 1:15 PM Changeset in webkit [159577] by
-
- 4 edits in trunk/Source/JavaScriptCore
ARMv7: Crash due to use after free of AssemblerBuffer
https://bugs.webkit.org/show_bug.cgi?id=124611
Reviewed by Geoffrey Garen.
Changed JITFinalizer constructor to take a MacroAssemblerCodePtr instead of a Label.
In finalizeFunction(), we use that value instead of calculating it from the label.
- assembler/MacroAssembler.cpp:
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::JITFinalizer):
(JSC::DFG::JITFinalizer::finalizeFunction):
- dfg/DFGJITFinalizer.h:
- 1:02 PM Changeset in webkit [159576] by
-
- 2 edits in trunk/Tools
Remove some obsolete logic from WebKit.app.
Reviewed by Alexey Proskuryakov.
- WebKitLauncher/WebKitNightlyEnabler.m:
(poseAsWebKitApp): Remove a pre-10.6 codepath.
(enableWebKitNightlyBehaviour): Remove a 10.4-specific codepath.
- 11:26 AM Changeset in webkit [159575] by
-
- 10 edits2 adds in trunk
REGRESSION(r127163): Respect clearance set on ancestors when placing floats
https://bugs.webkit.org/show_bug.cgi?id=119979
Reviewed by David Hyatt.
Source/WebCore:
Refactor the way self-collapsing blocks with clearance are positioned so that they
get the correct logical-top position during margin-collapsing.
Test: fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::marginOffsetForSelfCollapsingBlock):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
- rendering/RenderBlockFlow.h:
LayoutTests:
- fast/block/float/clear-negative-margin-top-expected.html:
- fast/block/float/clear-negative-margin-top.html:
- fast/block/margin-collapse/self-collapsing-block-with-float-descendants-expected.html: Added.
- fast/block/margin-collapse/self-collapsing-block-with-float-descendants.html: Added.
- platform/mac/fast/block/float/024-expected.txt:
- platform/mac/fast/block/margin-collapse/025-expected.txt:
- platform/mac/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
- platform/mac/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
- 11:08 AM WebKitGTK/2.2.x edited by
- I would like to integrate this patch in the release, but, as mrobinson … (diff)
- 11:03 AM Changeset in webkit [159574] by
-
- 2 edits in trunk/LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=124637
Unreviewed. Adding HTMLTemplateElement to global constructor
test after r159550.
- js/dom/global-constructors-attributes-expected.txt:
- 11:01 AM WebKitGTK/2.2.x edited by
- (diff)
- 10:57 AM Changeset in webkit [159573] by
-
- 3 edits in trunk/LayoutTests
Unreviewed. Trying to fix tests added in r159545.
- js/regress/global-var-const-infer-fire-from-opt.html:
- js/regress/global-var-const-infer.html:
- 10:44 AM Changeset in webkit [159572] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove Chromium as user agent and claim to be Safari in OS X
https://bugs.webkit.org/show_bug.cgi?id=124229
Reviewed by Martin Robinson.
http://www.duolingo.com/ doesn't get render correctly because it uses
Chrome/Chromium specific variables, added after it was forked. Because
of this, it is necessary to remove the Chrome/Chromium identification
in the user agent. Also, from now on, by default, The GTK+ port will
claim to be Safari in OS X to avoid loading wrong resources.
- platform/gtk/UserAgentGtk.cpp:
(WebCore::standardUserAgent):
- 10:32 AM Changeset in webkit [159571] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix CPU(ARM_TRADITIONAL) build after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124649
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-20
Reviewed by Michael Saboff.
Add missing memoryFence, load8 and store8 implementations in macro assembler.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::dmbSY):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::memoryFence):
- 10:26 AM Changeset in webkit [159570] by
-
- 21 edits in trunk/Source/WebCore
Unreviewed, rolling out r159551.
http://trac.webkit.org/changeset/159551
https://bugs.webkit.org/show_bug.cgi?id=124669
made many tests asserts (Requested by anttik on #webkit).
- html/HTMLDetailsElement.h:
- html/HTMLMediaElement.cpp:
(HTMLMediaElement::selectNextSourceChild):
- html/HTMLMetaElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::updateWidgetCallback):
- html/HTMLSummaryElement.cpp:
(WebCore::HTMLSummaryElement::detailsElement):
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::caption):
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableSectionElement.h:
- html/HTMLTagNames.in:
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/shadow/DetailsMarkerControl.cpp:
(WebCore::DetailsMarkerControl::summaryElement):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::handleFallbackContent):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
- page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):
- page/SpatialNavigation.cpp:
(WebCore::frameOwnerElement):
- 10:24 AM Changeset in webkit [159569] by
-
- 6 edits2 moves in trunk/Source/WebCore
Move LineWidth.{h,cpp} into rendering/line
<https://webkit.org/b/124448>
Reviewed by David Hyatt.
In r159354 I introduced line directory. Now it's time to move the helper classes of RenderBlockLineLayout into 'line' subdirectory.
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- rendering/line/LineWidth.cpp: Renamed from Source/WebCore/rendering/LineWidth.cpp.
(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::fitsOnLine):
(WebCore::LineWidth::fitsOnLineIncludingExtraWidth):
(WebCore::LineWidth::fitsOnLineExcludingTrailingWhitespace):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
(WebCore::LineWidth::commit):
(WebCore::LineWidth::applyOverhang):
(WebCore::LineWidth::fitBelowFloats):
(WebCore::LineWidth::setTrailingWhitespaceWidth):
(WebCore::LineWidth::updateCurrentShapeSegment):
(WebCore::LineWidth::computeAvailableWidthFromLeftAndRight):
(WebCore::LineWidth::fitsOnLineExcludingTrailingCollapsedWhitespace):
- rendering/line/LineWidth.h: Renamed from Source/WebCore/rendering/LineWidth.h.
(WebCore::LineWidth::currentWidth):
(WebCore::LineWidth::uncommittedWidth):
(WebCore::LineWidth::committedWidth):
(WebCore::LineWidth::availableWidth):
(WebCore::LineWidth::addUncommittedWidth):
(WebCore::LineWidth::shouldIndentText):
- 10:09 AM Changeset in webkit [159568] by
-
- 7 edits in trunk/Source/WebCore
Alphabetization followup to r159567
Reviewed by style-bot :(
- Modules/indexeddb/IDBDatabaseBackend.h:
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- inspector/InspectorIndexedDBAgent.cpp:
- 10:02 AM Changeset in webkit [159567] by
-
- 13 edits1 move in trunk/Source/WebCore
Rename IDBMetadata.h to IDBDatabaseMetadata.h
https://bugs.webkit.org/show_bug.cgi?id=124668
Reviewed by Dean Jackson.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackend.h:
- Modules/indexeddb/IDBDatabaseMetadata.h: Renamed from Source/WebCore/Modules/indexeddb/IDBMetadata.h.
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
(WebCore::IDBDatabaseMetadata::IDBDatabaseMetadata):
- Modules/indexeddb/IDBIndex.h:
- Modules/indexeddb/IDBObjectStore.h:
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/IDBTransaction.h:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
- Modules/indexeddb/leveldb/IDBIndexWriterLevelDB.h:
- inspector/InspectorIndexedDBAgent.cpp:
- 9:57 AM Changeset in webkit [159566] by
-
- 2 edits in trunk/Source/WebCore
Remove bogus assertions in updateNameForTreeScope and updateNameForDocument
https://bugs.webkit.org/show_bug.cgi?id=124639
Reviewed by Darin Adler.
Removed assertions. We can't assert that the element in a tree scope or a document
since these two functions are called from removedFrom.
- dom/Element.cpp:
(WebCore::Element::updateNameForTreeScope):
(WebCore::Element::updateNameForDocument):
- 9:02 AM Changeset in webkit [159565] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
- platform/efl/TestExpectations: Add new test expectations for failing tests.
- 8:02 AM Changeset in webkit [159564] by
-
- 4 edits in trunk/Source/JavaScriptCore
[armv7][arm64] Speculative build fix after r159545.
https://bugs.webkit.org/show_bug.cgi?id=124646
Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-20
Reviewed by Filip Pizlo.
- assembler/ARMv7Assembler.h:
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::memoryFence):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::memoryFence):
- 8:00 AM Changeset in webkit [159563] by
-
- 14 edits in trunk/Source
Cleanup getOrEstablishIDBDatabaseMetadata and stub it out in WK2
https://bugs.webkit.org/show_bug.cgi?id=124635
Reviewed by Tim Horton.
Source/WebCore:
getOrEstablishIDBDatabaseMetadata() should not have to take a database name parameter because the
server connection should already know what database name it represents.
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::openInternalAsync):
- Modules/indexeddb/IDBServerConnection.h:
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:
(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):
- Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):
Source/WebKit2:
Stub out the message for getOrEstablishIDBDatabaseMetadata in the DatabaseProcess.
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::establishConnection):
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::fromSecurityOrigin):
- Shared/SecurityOriginData.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::WebIDBServerConnection):
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- 7:49 AM Changeset in webkit [159562] by
-
- 4 edits in trunk/Tools
Moved stray urls from svn.py and statusserver.py into common.config.urls
https://bugs.webkit.org/show_bug.cgi?id=124650
Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-20
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/checkout/scm/svn.py:
(SVNRepository):
- Scripts/webkitpy/common/config/urls.py:
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer.init):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(_generate_results_dict):
- 7:44 AM Changeset in webkit [159561] by
-
- 5 edits1 add in trunk
[EFL] <video> and <audio> should be accessible.
https://bugs.webkit.org/show_bug.cgi?id=124494
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-11-20
Reviewed by Gyuyoung Kim.
Source/WebCore:
Adding descriptions of media-element controls.
- platform/efl/LocalizedStringsEfl.cpp:
(WebCore::localizedMediaControlElementString):
LayoutTests:
Added new accessibility baseline for accessibility/media-elemen.html.
- platform/efl-wk1/TestExpectations: test is no longer failing.
- platform/efl-wk2/TestExpectations: test is no longer failing.
- platform/efl/accessibility/media-element-expected.txt: Added.
- 7:14 AM Changeset in webkit [159560] by
-
- 3 edits in trunk/Source/WebCore
Don't paint simple text runs outside the paint rect
https://bugs.webkit.org/show_bug.cgi?id=124651
Reviewed by Anders Carlsson.
This speeds up partial paints for long text paragraphs.
Also add the same optimization for hit testing.
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::paintFlow):
Iterate over the run range that needs painting.
(WebCore::SimpleLineLayout::hitTestFlow):
Iterate over the line range that needs painting.
- rendering/SimpleLineLayoutResolver.h:
(WebCore::SimpleLineLayout::Range::Range):
(WebCore::SimpleLineLayout::Range::begin):
(WebCore::SimpleLineLayout::Range::end):
Add Range type.
(WebCore::SimpleLineLayout::RunResolver::Iterator::Iterator):
(WebCore::SimpleLineLayout::RunResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advance):
(WebCore::SimpleLineLayout::RunResolver::Iterator::advanceLines):
Optimize case where runCount==lineCount. In this case we can just directly jump
to the right run/line.
(WebCore::SimpleLineLayout::RunResolver::begin):
(WebCore::SimpleLineLayout::RunResolver::end):
(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):
(WebCore::SimpleLineLayout::RunResolver::rangeForRect):
Get the range corresponding to a rect. This currently cares about y coordinates only.
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator++):
(WebCore::SimpleLineLayout::LineResolver::Iterator::operator*):
(WebCore::SimpleLineLayout::LineResolver::rangeForRect):
- 6:55 AM Changeset in webkit [159559] by
-
- 3 edits4 adds in trunk
Cannot animate "points" attribute for <svg:polygon>
https://bugs.webkit.org/show_bug.cgi?id=21371
Reviewed by Antti Koivisto.
Source/WebCore:
Ensure we use animated list of points for SVG <polygon> and <polyline> elements
when we build the path used to draw them, otherwise the animated changes won't
be rendered and the base value will be used.
Tests: svg/animations/polygon-set.svg
svg/animations/polyline-set.svg
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):
LayoutTests:
New tests covering the actual application of the animated value
for the "points" attribute of the SVG <polygon> and <polyline> elements.
- svg/animations/polygon-set-expected.svg: Added.
- svg/animations/polygon-set.svg: Added.
- svg/animations/polyline-set-expected.svg: Added.
- svg/animations/polyline-set.svg: Added.
- 3:12 AM Changeset in webkit [159558] by
-
- 2 edits in trunk/LayoutTests
Configurability test of prototype's properties in fast/dom/webidl-operations-on-node-prototype.html is wrong
https://bugs.webkit.org/show_bug.cgi?id=124602
Reviewed by Darin Adler.
The test case landed in r159100 checks, among other tests, for configurability of properties on the Node's
interface prototype object. The test deletes the tested property from the prototype object and checks that
the property is undefined. This works for the Node's prototype object but is not technically correct since
there might be a property with the same identifier that's located upwards on the prototype chain.
Rather than testing that the property on the prototype object is undefined after it is deleted, a failure
should be reported if the value of the property remains the same even after it's deleted from the object.
- fast/dom/webidl-operations-on-node-prototype.html:
- 2:35 AM Changeset in webkit [159557] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
ANGLE doesn't build with bison 3.0
https://bugs.webkit.org/show_bug.cgi?id=124642
Patch by Sergio Correia <Sergio Correia> on 2013-11-20
Reviewed by Gyuyoung Kim.
This is a reedition of r154109, now that ANGLE source has been updated
in r159533.
- src/compiler/glslang.y: Use %lex-param to set YYLEX_PARAM and stop
using the deprecated YYID macro.
- 2:35 AM Changeset in webkit [159556] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Do not use deprecated callbacks in WebKitPolicyClient
https://bugs.webkit.org/show_bug.cgi?id=124648
Reviewed by Philippe Normand.
Fixes compile warnings for uninitialized callbacks.
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
(decidePolicyForNavigationAction): Add originatingFrame parameter.
(decidePolicyForNewWindowAction): Renamed for consistency.
(decidePolicyForResponse): Add canShowMIMEType parameter.
(attachPolicyClientToView): Add new callbacks.
- 1:48 AM Changeset in webkit [159555] by
-
- 2 edits in trunk/Source/ThirdParty/ANGLE
Unreviewed. Fix GTK build.
- GNUmakefile.am: Remove duplicated entries.
- 1:22 AM Changeset in webkit [159554] by
-
- 4 edits in trunk
Unreviewed, rolling out r159496.
http://trac.webkit.org/changeset/159496
https://bugs.webkit.org/show_bug.cgi?id=124641
It caused warning and build break with cmake lower than 2.8.8
(Requested by ryuan on #webkit).
.:
- Source/cmake/OptionsEfl.cmake:
Tools:
- MiniBrowser/efl/CMakeLists.txt:
- 12:47 AM Changeset in webkit [159553] by
-
- 11 edits in trunk/Source/WebCore
[CSSRegions] Move region styling code into RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=122957
Reviewed by Mihnea Ovidenie.
The patch moves all the region styling functionality outside of RenderRegion
to RenderNamedFlowFragment and outside of RenderFlowThread to RenderNamedFlowThread.
This generates a couple of undesired casts that will be removed in later patches
when everything CSS Regions specific will be located inside RenderNamedFlowThread
and RenderNamedFlowFragment (e.g. the move of the isValid flag, the auto-height
code etc.).
The painting function was also moved from RenderRegion to RenderNamedFlowFragment. It
was only used by the CSS Regions code. The new multi-column implementation has its own
painting mechanism.
Tests: No changed functionality, just refactorings.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::removeFlowChildInfo):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
- rendering/RenderFlowThread.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::RenderNamedFlowFragment):
(WebCore::RenderNamedFlowFragment::styleDidChange):
(WebCore::RenderNamedFlowFragment::checkRegionStyle):
(WebCore::RenderNamedFlowFragment::computeStyleInRegion):
(WebCore::RenderNamedFlowFragment::computeChildrenStyleInRegion):
(WebCore::RenderNamedFlowFragment::setObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::clearObjectStyleInRegion):
(WebCore::RenderNamedFlowFragment::setRegionObjectsRegionStyle):
(WebCore::RenderNamedFlowFragment::restoreRegionObjectsOriginalStyle):
(WebCore::shouldPaintRegionContentsInPhase):
(WebCore::RenderNamedFlowFragment::paintObject):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::checkRegionsWithStyling):
(WebCore::RenderNamedFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderNamedFlowThread::removeFlowChildInfo):
- rendering/RenderNamedFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::attachRegion):
- rendering/RenderRegion.h:
- rendering/RenderTreeAsText.cpp:
(WebCore::writeRenderRegionList):
- 12:30 AM Changeset in webkit [159552] by
-
- 2 edits in trunk/Tools
[EFL] libseccomp-2.0.0 doesn't support ARM architecture
https://bugs.webkit.org/show_bug.cgi?id=124412
Reviewed by Gyuyoung Kim.
Update libseccomp to a newer 2.1.0 version.
- efl/jhbuild.modules:
