⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 28, 2013:

11:51 PM Changeset in webkit [159864] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics][WK2] Correct wrong usage of m_contentPosition variable in the WebView.
​https://bugs.webkit.org/show_bug.cgi?id=118548

Patch by Eunmi Lee <​eunmi15.lee@samsung.com> on 2013-11-28
Reviewed by Noam Rosenthal.

CoordinatedGraphics uses its own scaling logic - contents scaling - and
WebView of CoordinatedGraphics maintains contents position by scaling
with contents scaling factor.
However transformToScene() and updateViewportSize() of WebView regard
the contents position as a non-scaled value, so it should be fixed.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::transformToScene):
(WebKit::WebView::updateViewportSize):

7:42 PM Changeset in webkit [159863] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL] PageViewportController does not need to be unique_ptr instance
​https://bugs.webkit.org/show_bug.cgi?id=124993

Reviewed by Gyuyoung Kim.

PageViewportController and PageViewportControllerEfl have same life cycle
with EwkView. So, we don't need to make them as unique_ptr instance.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectCalculate):
(EwkView::scrollBy):

  • UIProcess/API/efl/EwkView.h:

(EwkView::pageViewportController):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeContentsSize):
(WebKit::ViewClientEfl::didChangeContentsPosition):
(WebKit::ViewClientEfl::didRenderFrame):
(WebKit::ViewClientEfl::didCompletePageTransition):
(WebKit::ViewClientEfl::didChangeViewportAttributes):

5:35 PM Changeset in webkit [159862] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Build fix after r159859
​https://bugs.webkit.org/show_bug.cgi?id=124992

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-28
Reviewed by Gyuyoung Kim.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::didCommitLoadForMainFrame): Added.

  • UIProcess/API/gtk/PageClientImpl.h:
5:02 PM Changeset in webkit [159861] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebKit2

[EFL] Build fix after r159859
​https://bugs.webkit.org/show_bug.cgi?id=124991

Reviewed by Gyuyoung Kim.

Redefined newly added pure virtual function in PageClient class after r159859.

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::didCommitLoadForMainFrame):

  • UIProcess/CoordinatedGraphics/WebView.h:
3:25 PM Changeset in webkit [159860] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/WebCore

Rename InlineIterator::m_obj and make it private
​https://bugs.webkit.org/show_bug.cgi?id=124837

Reviewed by Antti Koivisto.

InlineIterator has been exported m_obj as public though there is a getter function.
Besides *object* name isn't ambigious. So, changed it with m_renderer and renderer().
Additionally, setRenderer() is added as well.

No new tests, no behavior changes.

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::setObject):
(WebCore::operator==):
(WebCore::operator!=):
(WebCore::InlineBidiResolver::appendRun):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendRunsForObject):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::matchedEndLine):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::TrailingObjects::updateMidpointsForTrailingBoxes):
(WebCore::BreakingContext::BreakingContext):
(WebCore::BreakingContext::currentObject):
(WebCore::BreakingContext::initializeForCurrentObject):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleOutOfFlowPositioned):
(WebCore::BreakingContext::handleFloat):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::iteratorIsBeyondEndOfRenderCombineText):
(WebCore::ensureCharacterGetsLineBox):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::canBreakAtThisPosition):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
(WebCore::checkMidpoints):
(WebCore::BreakingContext::handleEndOfLine):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipTrailingWhitespace):
(WebCore::LineBreaker::skipLeadingWhitespace):

  • rendering/line/LineInlineHeaders.h:

(WebCore::skipNonBreakingSpace):
(WebCore::requiresLineBox):

2:23 PM WebKitGTK/Debugging edited by Andres Gomez
(diff)
1:01 PM Changeset in webkit [159859] by weinig@apple.com
  • 14 edits
    1 add in trunk/Source/WebKit2

Perform some spring cleaning to WKContentView and WKView
​https://bugs.webkit.org/show_bug.cgi?id=124961

Reviewed by Dan Bernstein.

  • Store the PageClientImpl in a std::unique_ptr.
  • Remove the WKBrowsingContextController internal load delegate. Replace its use with a new PageClient function, didCommitLoadForMainFrame.
  • Fix typo in the WKContentViewDelegate. contentViewdidCommitLoadForMainFrame -> contentViewDidCommitLoadForMainFrame.
  • Add initializers for WKContentView and WKView that take WKContextRefs and WKPageGroupRefs to match the Mac WKView. These are needed for WebKitTestRunner.
  • Require a WKProcessGroup (or WKContextRef) and a WKBrowsingContextGroup (or WKPageGroupRef).
  • Stop caching the WKProcessGroup and WKBrowsingContextGroup on the WKContentView.
  • Remove incorrect implementations of initWithCoder.
  • Make WKContentView lazily create its WKBrowsingContextController wrapper.
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::didCommitLoadForMainFrame):
(WebKit::PageClientImpl::mainDocumentDidReceiveMobileDocType):

  • UIProcess/API/ios/WKContentView.h:
  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView initWithCoder:]):
(-[WKContentView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKContentView browsingContextController]):
(-[WKContentView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView _didReceiveMobileDocTypeForMainFrame]):
(-[WKContentView _didChangeViewportArguments:WebCore::]):
(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _pageRef]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:]):
(-[WKContentView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/API/ios/WKContentViewPrivate.h: Added.
  • UIProcess/API/ios/WKView.mm:

(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
(-[WKView initWithFrame:processGroup:browsingContextGroup:relatedToView:]):
(-[WKView contentViewDidCommitLoadForMainFrame:]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):
(-[WKView pageRef]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didCommitLoadForMainFrame):

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didCommitLoadForFrame):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKViewPrivate.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

12:59 PM Changeset in webkit [159858] by Antti Koivisto
  • 1 edit
    2 deletes in trunk/LayoutTests

Remove an oddly named css variables test

Rubber-stamped by Andreas Kling.

  • css3/filters/reference-filter-update-after-remove-expected.txt: Removed.
  • css3/filters/reference-filter-update-after-remove.html: Removed.
12:55 PM Changeset in webkit [159857] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WTF

Nix Upstream: Updating Nix WTF files
​https://bugs.webkit.org/show_bug.cgi?id=124980

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Just to sync our private repo files and the trunk, as part of the upstream process.

  • wtf/DisallowCType.h:
  • wtf/PlatformNix.cmake:
  • wtf/nix/FeatureDefinesNix.h:
  • wtf/nix/PlatformNix.h:
  • wtf/nix/RunLoopNix.cpp: Added.
12:53 PM Changeset in webkit [159856] by Antti Koivisto
  • 158 edits
    2 moves in trunk

Rename StylePropertySet to StyleProperties
​https://bugs.webkit.org/show_bug.cgi?id=124990

Reviewed by Andreas Kling.

"Set" does not add useful information here. Use less clunky plural name.

12:33 PM Changeset in webkit [159855] by nrotem@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Revert the X86 assembler peephole changes
​https://bugs.webkit.org/show_bug.cgi?id=124988

Reviewed by Csaba Osztrogonác.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::branchAdd32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:43 AM Changeset in webkit [159854] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

Nix Upstream: Adding EditorNix to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=124984

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

No new tests needed.

  • PlatformNix.cmake:
  • editing/nix/EditorNix.cpp: Added.
11:35 AM Changeset in webkit [159853] by Csaba Osztrogonác
  • 274 edits
    2 adds in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase EFL results (and the remaining Mac) after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • fast/table/anonymous-table-section-removed.html: Updated.
  • platform/efl/accessibility/table-attributes-expected.txt: Added.
  • platform/efl/accessibility/table-sections-expected.txt: Added.
  • platform/efl/fast/forms/input-value-expected.png:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/table/[...]:
  • platform/efl/tables/[...]:
  • platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
11:33 AM Changeset in webkit [159852] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Building EFL Webkit again with mediastream enabled
​https://bugs.webkit.org/show_bug.cgi?id=124930

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • CMakeLists.txt:
11:03 AM Changeset in webkit [159851] by Csaba Osztrogonác
  • 147 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/table/[...]:
  • platform/mac/tables/[...]:
10:54 AM Changeset in webkit [159850] by Csaba Osztrogonác
  • 269 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Rebase GTK results after r159848.

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • platform/gtk/accessibility/table-detection-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/table/[...]:
  • platform/gtk/tables/[...]:
9:43 AM Changeset in webkit [159849] by zoltan@webkit.org
  • 2 edits in trunk/Source/WebCore

[Win] Update vcxproj.filters, since LineInfo.h and LineLayoutState.h have been moved to rendering/line
​https://bugs.webkit.org/show_bug.cgi?id=124959

Reviewed by Brent Fulgham.

Update WebCore.vcxproj.filters, since LineInfo.h (r155628) and LineLayoutState.h (158121) have been moved to rendering/line.

No new tests, no behavior change.

  • WebCore.vcxproj/WebCore.vcxproj.filters:
9:40 AM Changeset in webkit [159848] by Csaba Osztrogonác
  • 4 edits in trunk

RenderTableSection Blink merge asserting
​https://bugs.webkit.org/show_bug.cgi?id=124857

Patch by Laszlo Vidacs <​lac@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Source/WebCore:

Use border spacing at the end of all sections.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

Skipped tests enabled.

8:55 AM Changeset in webkit [159847] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Unreviewed, rolling out r159839.
​http://trac.webkit.org/changeset/159839
​https://bugs.webkit.org/show_bug.cgi?id=124974

run-webkit-tests doesn't generate pretty diff (Requested by
Ossy on #webkit).

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.pretty_patch_available):
(Port.check_pretty_patch):
(Port.variable):
(Port.variable.pretty_patch_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

8:35 AM Changeset in webkit [159846] by Michał Pakuła vel Rutka
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/TestExpectations: Added test expectations for failing tests.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Added.
  • platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Added.
8:20 AM Changeset in webkit [159845] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Buildfix after r159824 for GCC 4.6
​https://bugs.webkit.org/show_bug.cgi?id=124968

Patch by Éva Balázsfalvi <​balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

Added explicit "friend class", because GCC 4.6 doesn't support extended friend declaration (c++11)

  • Shared/APIObject.h:
8:19 AM Changeset in webkit [159844] by Antti Koivisto
  • 3 edits in trunk/LayoutTests

No need to skip css variables tests as they were removed.

  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
8:02 AM Changeset in webkit [159843] by Gustavo Noronha Silva
  • 3 edits in trunk/Source/WebKit/gtk

REGRESSION(r154658): webkit_web_view_get_view_source_mode always returns false
​https://bugs.webkit.org/show_bug.cgi?id=124954

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-28
Reviewed by Carlos Garcia Campos.

  • tests/testwebview.c: new test to ensure setting and getting source mode work as intended.
  • webkit/webkitwebview.cpp:

(webkit_web_view_get_view_source_mode): actually return the value we query from WebCore.

7:46 AM Changeset in webkit [159842] by Antti Koivisto
  • 60 edits
    3 deletes in trunk

Remove feature: CSS variables
​https://bugs.webkit.org/show_bug.cgi?id=114119

.:

Reviewed by Andreas Kling.

  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Reviewed by Andreas Kling.

The feature is unmaintained and it is getting in the way of refactoring. Code quality is not up to
WebKit standards either.

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSBasicShapes.cpp:
  • css/CSSBasicShapes.h:
  • css/CSSCalculationValue.cpp:

(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::determineCategory):
(WebCore::CSSCalcBinaryOperation::primitiveType):

  • css/CSSCalculationValue.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::createPrimitiveNumericValue):
(WebCore::CSSParser::parseValidPrimitive):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseReflect):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::realLex):

  • css/CSSParser.h:
  • css/CSSParserMode.h:
  • css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::primitiveType):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::getStringValue):
(WebCore::CSSPrimitiveValue::customCSSText):
(WebCore::CSSPrimitiveValue::equals):

  • css/CSSPrimitiveValue.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::convertToLength):

  • css/CSSProperty.cpp:
  • css/CSSProperty.h:

(WebCore::CSSProperty::CSSProperty):

  • css/CSSReflectValue.cpp:
  • css/CSSReflectValue.h:
  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::setCssText):

  • css/CSSValueList.cpp:
  • css/CSSValueList.h:
  • css/CSSVariableValue.h: Removed.
  • css/Pair.h:
  • css/Rect.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::asText):
(WebCore::StylePropertySet::PropertyReference::cssName):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyProperty):

  • css/StyleResolver.h:
  • css/WebKitCSSTransformValue.cpp:
  • css/WebKitCSSTransformValue.h:

(WebCore::WebKitCSSTransformValue::equals):

  • css/makeprop.pl:
  • page/Settings.cpp:

(WebCore::Settings::Settings):

  • page/Settings.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleVariableData.h: Removed.
  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit/mac:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Reviewed by Andreas Kling.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Reviewed by Andreas Kling.

  • wtf/FeatureDefines.h:

Tools:

Reviewed by Andreas Kling.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Reviewed by Andreas Kling.

  • fast/css/variables: Removed.
  • fast/css/variables/border-width-expected.html: Removed.
  • fast/css/variables/border-width.html: Removed.
  • fast/css/variables/build-supports-variables-expected.txt: Removed.
  • fast/css/variables/build-supports-variables.html: Removed.
  • fast/css/variables/calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc-expected.html: Removed.
  • fast/css/variables/calc-inside-calc.html: Removed.
  • fast/css/variables/calc-invalid-value-expected.html: Removed.
  • fast/css/variables/calc-invalid-value.html: Removed.
  • fast/css/variables/calc-invalid-variable-expected.html: Removed.
  • fast/css/variables/calc-invalid-variable.html: Removed.
  • fast/css/variables/calc-negated-variable-expected.html: Removed.
  • fast/css/variables/calc-negated-variable.html: Removed.
  • fast/css/variables/calc-vw-crash-expected.txt: Removed.
  • fast/css/variables/calc-vw-crash.html: Removed.
  • fast/css/variables/calc.html: Removed.
  • fast/css/variables/case-sensitive-expected.html: Removed.
  • fast/css/variables/case-sensitive.html: Removed.
  • fast/css/variables/colors-test-expected.html: Removed.
  • fast/css/variables/colors-test.html: Removed.
  • fast/css/variables/complex-cycle-expected.html: Removed.
  • fast/css/variables/complex-cycle.html: Removed.
  • fast/css/variables/computed-style-expected.html: Removed.
  • fast/css/variables/computed-style.html: Removed.
  • fast/css/variables/deferred-image-load-from-variable-expected.txt: Removed.
  • fast/css/variables/deferred-image-load-from-variable.html: Removed.
  • fast/css/variables/inherited-values-expected.html: Removed.
  • fast/css/variables/inherited-values.html: Removed.
  • fast/css/variables/inline-styles-expected.html: Removed.
  • fast/css/variables/inline-styles.html: Removed.
  • fast/css/variables/invalid-font-reference-expected.txt: Removed.
  • fast/css/variables/invalid-font-reference.html: Removed.
  • fast/css/variables/invalid-shorthand-expected.html: Removed.
  • fast/css/variables/invalid-shorthand.html: Removed.
  • fast/css/variables/invalid-value-list-crash-expected.txt: Removed.
  • fast/css/variables/invalid-value-list-crash.html: Removed.
  • fast/css/variables/invalid-variable-value-expected.html: Removed.
  • fast/css/variables/invalid-variable-value.html: Removed.
  • fast/css/variables/multi-level-cycle-expected.html: Removed.
  • fast/css/variables/multi-level-cycle.html: Removed.
  • fast/css/variables/redefinition-expected.html: Removed.
  • fast/css/variables/redefinition.html: Removed.
  • fast/css/variables/root-background-size-expected.html: Removed.
  • fast/css/variables/root-background-size.html: Removed.
  • fast/css/variables/shorthand-expected.html: Removed.
  • fast/css/variables/shorthand.html: Removed.
  • fast/css/variables/simple-cycle-expected.html: Removed.
  • fast/css/variables/simple-cycle.html: Removed.
  • fast/css/variables/transform-test-expected.html: Removed.
  • fast/css/variables/transform-test.html: Removed.
  • fast/css/variables/undefined-expected.html: Removed.
  • fast/css/variables/undefined.html: Removed.
  • fast/css/variables/use-before-defined-expected.html: Removed.
  • fast/css/variables/use-before-defined.html: Removed.
  • fast/css/variables/var-filter-expected.txt: Removed.
  • fast/css/variables/var-filter.html: Removed.
  • fast/css/variables/var-inside-box-reflect-expected.html: Removed.
  • fast/css/variables/var-inside-box-reflect.html: Removed.
  • fast/css/variables/var-inside-pair-expected.html: Removed.
  • fast/css/variables/var-inside-pair.html: Removed.
  • fast/css/variables/var-inside-quad-expected.html: Removed.
  • fast/css/variables/var-inside-quad.html: Removed.
  • fast/css/variables/var-inside-shape-expected.html: Removed.
  • fast/css/variables/var-inside-shape.html: Removed.
  • fast/css/variables/var-inside-shorthand-expected.html: Removed.
  • fast/css/variables/var-inside-shorthand.html: Removed.
  • fast/css/variables/variable-chain-expected.html: Removed.
  • fast/css/variables/variable-chain.html: Removed.
  • fast/css/variables/variable-unparseable-value-crash-expected.txt: Removed.
  • fast/css/variables/variable-unparseable-value-crash.html: Removed.
7:27 AM Changeset in webkit [159841] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[EFL] Layout tests need to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=124879

Unreviewed, EFL rebaseline.

EFL tests need to be rebaselined after r159747

Patch by Jongwoo Choi <​jw0330.choi@samsung.com> on 2013-11-28

  • platform/efl/fast/table/011-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-expected.txt:
  • platform/efl/fast/table/tableInsideCaption-expected.txt:
7:15 AM Changeset in webkit [159840] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Updating RTCPeerConnectionHandlerMock after r159769
​https://bugs.webkit.org/show_bug.cgi?id=124947

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-28
Reviewed by Philippe Normand.

Adding its create function back, in order to run RTCPeerConnection LayoutTests.

No new tests needed.

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::create):

  • platform/mock/RTCPeerConnectionHandlerMock.h:
7:14 AM Changeset in webkit [159839] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Move PrettyPatch related code to prettypatch.py
​https://bugs.webkit.org/show_bug.cgi?id=124937

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

This code seems to have a better place here than in Port, since PrettyPatch already knows
pretty_patch_path, and this also unifies the usage of PrettyPatch

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.init):
(PrettyPatch.pretty_diff):
(PrettyPatch):
(PrettyPatch.pretty_patch_available):
(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.wdiff_available):
(Port.check_image_diff):
(Port.wdiff_text):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_pretty_patch_os_error):
(PortTest.test_pretty_patch_script_error):

6:20 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
6:09 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
5:46 AM Changeset in webkit [159838] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Checkout should own the scm object in Host
​https://bugs.webkit.org/show_bug.cgi?id=124943

Patch by Dániel Bátyai <​Batyai.Daniel@stud.u-szeged.hu> on 2013-11-28
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/host.py:

(Host.init):
(Host.initialize_scm):
(Host.scm):

5:41 AM WebKitGTK/2.2.x edited by Gustavo Noronha Silva
(diff)
4:40 AM Changeset in webkit [159837] by Gustavo Noronha Silva
  • 9 edits in trunk

[GTK] Support custom types for drag and drop data
​https://bugs.webkit.org/show_bug.cgi?id=124659

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.com> on 2013-11-27
Reviewed by Martin Robinson.

Source/WebCore:

Covered by fast/events/drag-customData.html.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes): returns a hash map with all custom types set.
(WebCore::DataObjectGtk::clearAllExceptFilenames): clear custom types.

  • platform/gtk/DataObjectGtk.h:

(WebCore::DataObjectGtk::hasUnknownTypeData): returns whether custom types are set.
(WebCore::DataObjectGtk::unknownTypeData): returns the data for a custom type.
(WebCore::DataObjectGtk::setUnknownTypeData): sets the data for a custom type.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeString): handle unknown types as custom.
(WebCore::Pasteboard::writePasteboard): ditto.
(WebCore::Pasteboard::hasData): also check for custom types.
(WebCore::Pasteboard::types): also obtain the list of custom types.
(WebCore::Pasteboard::readString): handle unknown types as custom.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::initGdkAtoms): new unknown atom.
(WebCore::PasteboardHelper::PasteboardHelper): add custom type to the list of targets.
(WebCore::PasteboardHelper::fillSelectionData): turns any custom types' data into a GVariant, which
is in turn serialized to a single string for GtkSelectionData to hold.
(WebCore::PasteboardHelper::targetListForDataObject): add custom data to the target list if any is
set.
(WebCore::PasteboardHelper::fillDataObjectFromDropData): retrieve the custom types and their data
from the serialized GVariant string held by GtkSelectionData.
(WebCore::PasteboardHelper::dropAtomsForContext): handle custom types.

Source/WebKit2:

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::encodeDataObject): encode the unknown types data.
(CoreIPC::decodeDataObject): decode the unknown types data.

LayoutTests:

  • platform/gtk/TestExpectations: remove failure expectation for test that now passes.
4:22 AM WebKitGTK/2.2.x edited by tpopela@redhat.com
(diff)
2:28 AM Changeset in webkit [159836] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Typo fix after r159834 to fix 32 bit builds.

Patch by Peter Gal <​galpeter@inf.u-szeged.hu> on 2013-11-28
Reviewed by Csaba Osztrogonác.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Nov 27, 2013:

11:40 PM Changeset in webkit [159835] by nrotem@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add a bunch of early exits and local optimizations to the x86 assembler.
​https://bugs.webkit.org/show_bug.cgi?id=124904

Reviewed by Filip Pizlo.

  • assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):
(JSC::MacroAssemblerX86::add64):
(JSC::MacroAssemblerX86::or32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::or32):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::or32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::or64):
(JSC::MacroAssemblerX86_64::xor64):

11:10 PM Changeset in webkit [159834] by fpizlo@apple.com
  • 31 edits
    12 adds in trunk

Infer one-time scopes
​https://bugs.webkit.org/show_bug.cgi?id=124812

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This detects JSActivations that are created only once. The JSActivation pointer is then
baked into the machine code.

This takes advantage of the one-time scope inference to reduce the number of
indirections needed to get to a closure variable in case where the scope is only
allocated once. This isn't really a speed-up since in the common case the total number
of instruction bytes needed to load the scope from the stack is about equal to the
number of instruction bytes needed to materialize the absolute address of a scoped
variable. But, this is a necessary prerequisite to
​https://bugs.webkit.org/show_bug.cgi?id=124630, so it's probably a good idea anyway.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/Instruction.h:
  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecode/Watchpoint.h:

(JSC::WatchpointSet::notifyWrite):
(JSC::InlineWatchpointSet::notifyWrite):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitResolveScope):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::scopedVarLoadElimination):
(JSC::DFG::CSEPhase::scopedVarStoreElimination):
(JSC::DFG::CSEPhase::getLocalLoadElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetRegisters):

  • dfg/DFGGraph.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::varNumber):
(JSC::DFG::Node::hasSymbolTable):
(JSC::DFG::Node::symbolTable):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetClosureRegisters):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/JSActivation.h:

(JSC::JSActivation::create):

  • runtime/JSScope.cpp:

(JSC::abstractAccess):
(JSC::JSScope::abstractResolve):

  • runtime/JSScope.h:

(JSC::ResolveOp::ResolveOp):

  • runtime/JSVariableObject.h:

(JSC::JSVariableObject::registers):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):

  • runtime/SymbolTable.h:

LayoutTests:

Reviewed by Oliver Hunt.

  • js/regress/infer-one-time-closure-expected.txt: Added.
  • js/regress/infer-one-time-closure-ten-vars-expected.txt: Added.
  • js/regress/infer-one-time-closure-ten-vars.html: Added.
  • js/regress/infer-one-time-closure-two-vars-expected.txt: Added.
  • js/regress/infer-one-time-closure-two-vars.html: Added.
  • js/regress/infer-one-time-closure.html: Added.
  • js/regress/infer-one-time-deep-closure-expected.txt: Added.
  • js/regress/infer-one-time-deep-closure.html: Added.
  • js/regress/script-tests/infer-one-time-closure-ten-vars.js: Added.
  • js/regress/script-tests/infer-one-time-closure-two-vars.js: Added.
  • js/regress/script-tests/infer-one-time-closure.js: Added.
  • js/regress/script-tests/infer-one-time-deep-closure.js: Added.
8:34 PM Changeset in webkit [159833] by weinig@apple.com
  • 7 edits in trunk/Source/WebKit2

Give the PageClient a chance to handle geolocation permission requests if the UIClient doesn't handle it
​https://bugs.webkit.org/show_bug.cgi?id=124955

Reviewed by Dan Bernstein.

Use the new PageClient function to remove the need for WKContentView to take over the WKPageUIClient.

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _decidePolicyForGeolocationRequestFromOrigin:frame:request:]):
(-[WKContentView _commonInitWithProcessGroup:browsingContextGroup:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

7:23 PM Changeset in webkit [159832] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the iOS build.

  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:
  • UIProcess/API/ios/WKGeolocationProviderIOSObjCSecurityOrigin.mm:
7:14 PM Changeset in webkit [159831] by weinig@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit

Fix the iOS build.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj:

../WebKit/mac:

  • WebView/WebAllowDenyPolicyListener.h: Added.
  • WebView/WebUIDelegatePrivate.h:

Move the WebAllowDenyPolicyListener protocol to its own file.

6:25 PM Changeset in webkit [159830] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Add accessors for the WKProcessGroup and WKBrowsingContextGroup on the WKBrowsingContextController
​https://bugs.webkit.org/show_bug.cgi?id=124953

Reviewed by Dan Bernstein.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController processGroup]):
(-[WKBrowsingContextController browsingContextGroup]):
Add accessors.

6:03 PM Changeset in webkit [159829] by weinig@apple.com
  • 6 edits
    1 add in trunk/Source/WebKit2

Make WKProcessGroup work with WKObject wrapping
​https://bugs.webkit.org/show_bug.cgi?id=124952

Reviewed by Dan Bernstein.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKProcessGroup.

  • UIProcess/API/mac/WKProcessGroup.mm:

(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
(-[WKProcessGroup API::]):
(-[WKProcessGroup _contextRef]):
(-[WKProcessGroup _geolocationProvider]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline

  • UIProcess/API/mac/WKProcessGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::create):
(WebKit::WebContext::WebContext):

  • UIProcess/WebContext.h:

Make the WebContext constructor public (for use with Object::constructInWrapper) and remove unused ProcessModel parameter.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

5:20 PM Changeset in webkit [159828] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] The remote inspector does not show the base page.
​https://bugs.webkit.org/show_bug.cgi?id=124942

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-27
Reviewed by Gyuyoung Kim.

On EFL the remote inspector does not show the base page about
which pages are available for debug. This should be fixed for
further inspector development.

  • Source/PlatformEfl.cmake:
5:05 PM Changeset in webkit [159827] by eric.carlson@apple.com
  • 37 edits
    9 adds in trunk

Allow the QuickTime plug-in to be replaced by script in an isolated word
​https://bugs.webkit.org/show_bug.cgi?id=124900

Reviewed by Dean Jackson.

Source/WebCore:

Test: plugins/quicktime-plugin-replacement.html

  • CMakeLists.txt: Add new Modules path.
  • DerivedSources.make: Add new files.
  • GNUmakefile.am: Add new Modules path.
  • GNUmakefile.list.am: Add new header.
  • WebCore.vcxproj/WebCore.vcxproj: Add new header.
  • WebCore.vcxproj/WebCoreCommon.props: Add new Modules path.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • Modules/plugins: Added.
  • Modules/plugins/PluginReplacement.h: Added. Defines the interface for a plug-in replacement.

Create a replacement for the QuickTime plug-in.

  • Modules/plugins/QuickTimePluginReplacement.cpp: Added.
  • Modules/plugins/QuickTimePluginReplacement.css: Added.
  • Modules/plugins/QuickTimePluginReplacement.h: Added.
  • Modules/plugins/QuickTimePluginReplacement.idl: Added.
  • Modules/plugins/QuickTimePluginReplacement.js: Added.

Allow plug-in replacement to be enabled at runtime.

  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setPluginReplacementEnabled):
(WebCore::RuntimeEnabledFeatures::pluginReplacementEnabled):

  • bindings/js/JSDOMBinding.h:

(WebCore::toJS): Add toJS(... const String& ...).

  • bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObject): Give a plug-in replacement a first shot at defining the

script interface.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Call base class requestObject.

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::fileSize): New, passthrough to media engine.

  • html/HTMLMediaElement.h:
  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Call base class requestObject.

Moved some logic that was previously used only for creating a plug-in snapshot to the base
class so it can be shared by a plug-in replacement.

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize timer used to swap renderers.
(WebCore::HTMLPlugInElement::createRenderer): Allow plug-in replacement to create the renderer.
(WebCore::HTMLPlugInElement::swapRendererTimerFired): Create a shadow root.
(WebCore::HTMLPlugInElement::setDisplayState): Set the new state, prime the swap renderer

timer if necessary.

(WebCore::HTMLPlugInElement::didAddUserAgentShadowRoot): Tell the plug-in replacement to

install itself in the new shadow DOM.

(WebCore::registeredPluginReplacements): Return vector of all registered plug-in replacements.
(WebCore::registerPluginReplacement): Add a plug-in replacement.
(WebCore::pluginReplacementForType): Find a plug-in replacement for a MIME type.
(WebCore::HTMLPlugInElement::requestObject): If there is a plug-in replacement for the MIME type,

create it and set the display state.

(WebCore::HTMLPlugInElement::scriptObjectForPluginReplacement): Return the script object for

the current plug-in replacement, if any.

  • html/HTMLPlugInElement.h:

Move some plug-in snapshot code into the base class.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): No need to initialize timer.
(WebCore::HTMLPlugInImageElement::setDisplayState): Call base class.
(WebCore::HTMLPlugInImageElement::createRenderer): Ditto.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Ditto.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Remove unnecessary class name.
(WebCore::HTMLPlugInImageElement::requestObject): New.

  • html/HTMLPlugInImageElement.h:
  • html/HTMLVideoElement.h: Make createRenderer public so the QuickTime plug-in replacement can

call it.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::fileSize): New.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): totalBytes returns an unsigned long long.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::fileSize):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes): Return an unsigned long long.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes): Ditto.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): Backup the plug-in replacement runtime setting.
(WebCore::InternalSettings::Backup::restoreTo): Restore it.
(WebCore::InternalSettings::setPluginReplacementEnabled): Set it.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

  • platform/efl/TestExpectations: Skip the new test.
  • platform/gtk/TestExpectations: Ditto.
  • platform/wincairo/TestExpectations: Ditto.
  • plugins/quicktime-plugin-replacement.html: Added.
  • plugins/quicktime-plugin-replacement-expected.txt: Added.
  • plugins/resources/orange.mov: Replace movie compressed with ancient (and deprecated)

animated gif codec with one compressed with H.264 codec.

4:22 PM Changeset in webkit [159826] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Finally fix some obvious Bartlett bugs
​https://bugs.webkit.org/show_bug.cgi?id=124951

Reviewed by Mark Hahnenberg.

Sanitize the stack (i.e. zero parts of it known to be dead) at three key points:

  • GC.


  • At beginning of OSR entry.


  • Just as we finish preparing OSR entry. This clears those slots on the stack that could have been live in baseline but that are known to be dead in DFG.


This is as much as a 2x speed-up on splay if you run it in certain modes, and run it
for a long enough interval. It appears to fix all instances of the dreaded exponential
heap growth that splay gets into when some stale pointer stays around.

This doesn't have much of an effect on real-world programs. This bug has only ever
manifested in splay and for that reason we thus far opted against fixing it. But splay
is, for what it's worth, the premiere GC stress test in JavaScript - so making sure we
can run it without pathologies - even when you tweak its configuration - is probably
fairly important.

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::noticeOSREntry):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSREntry.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • interpreter/JSStack.cpp:

(JSC::JSStack::JSStack):
(JSC::JSStack::sanitizeStack):

  • interpreter/JSStack.h:
3:15 PM Changeset in webkit [159825] by fpizlo@apple.com
  • 15 edits
    1 add in trunk

Do bytecode validation as part of testing
​https://bugs.webkit.org/show_bug.cgi?id=124913

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Also fix some small bugs in the bytecode liveness analysis that I found by doing
this validation thingy.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::validate):
(JSC::CodeBlock::beginValidationDidFail):
(JSC::CodeBlock::endValidationDidFail):

  • bytecode/CodeBlock.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/Options.h:

Source/WTF:

Reviewed by Oliver Hunt.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/FastBitVector.cpp: Added.

(WTF::FastBitVector::dump):

  • wtf/FastBitVector.h:

(WTF::FastBitVector::resize):
(WTF::FastBitVector::bitCount):
(WTF::FastBitVector::arrayLength):

Tools:

Reviewed by Oliver Hunt.

  • Scripts/run-jsc-stress-tests:
2:48 PM Changeset in webkit [159824] by weinig@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

Make WKBrowsingContextGroup work with WKObject wrapping
​https://bugs.webkit.org/show_bug.cgi?id=124948

Reviewed by Dan Bernstein.

  • Adds mechanism to use the inline data wrapping mechanism when the Objective-C wrapper is created by the caller (rather than by Object::newObject).
  • Adopts the mechanism for WKBrowsingContextGroup.
  • Shared/APIObject.h:

(API::Object::constructInWrapper):
Add a helper which does a forwarding placement-new into the API::Object of the passed in wrapper, after which it sets up m_wrapper.

(API::TypedObject::operator new):
Add a operator new to for placement-new. Also make TypedObject friends with Object so that constructInWrapper can call this.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Add support for WKBrowsingContextGroup.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup API::]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup allowsJavaScript]):
(-[WKBrowsingContextGroup setAllowsJavaScript:]):
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):
(-[WKBrowsingContextGroup allowsPlugIns]):
(-[WKBrowsingContextGroup setAllowsPlugIns:]):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserStyleSheets]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):
(-[WKBrowsingContextGroup removeAllUserScripts]):
(-[WKBrowsingContextGroup _pageGroupRef]):
Convert from wrapping the C-SPI type to storing the bits of the wrapped object inline (modeled on WKBackForwardList).

  • UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.

(WebKit::wrapper):
Add wrapper() helper and declare conformance to the WKObject protocol.

  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::create):
(WebKit::WebPageGroup::WebPageGroup):

  • UIProcess/WebPageGroup.h:

Make the WebPageGroup constructor public (for use with Object::constructInWrapper) and move being set in the webPageGroupMap()
to the constructor.

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

1:03 PM Changeset in webkit [159823] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Adding MediaConstraintsMock class
​https://bugs.webkit.org/show_bug.cgi?id=124902

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-27
Reviewed by Eric Carlson.

Validate constraints used in RTCPeerConnection LayoutTests

Source/WebCore:

Existing test was updated.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • platform/mock/MediaConstraintsMock.cpp: Added.
  • platform/mock/MediaConstraintsMock.h: Added.
  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::validateRequestConstraints): Now using MediaConstraintsMock
(WebCore::MockMediaStreamCenter::createMediaStream): Ditto.

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::initialize): Ditto.

LayoutTests:

  • fast/mediastream/RTCPeerConnection-expected.txt:
12:19 PM Changeset in webkit [159822] by betravis@adobe.com
  • 10 edits in trunk

[CSS Shapes] Shape-Inside Should Default to 'auto'
​https://bugs.webkit.org/show_bug.cgi?id=124851

Reviewed by Alexandru Chiculita.

Source/WebCore:

The current shape-inside specification has the property default to the 'auto'
value, not 'outside-shape'.

Updated tests are under fast/shapes.

  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:

LayoutTests:

Update tests to reflect a default shape-inside value of 'auto'.

  • fast/shapes/css-shapes-disabled-expected.txt:
  • fast/shapes/css-shapes-disabled.html:
  • fast/shapes/parsing/parsing-shape-inside-expected.txt:
  • fast/shapes/parsing/parsing-shape-inside.html:
  • fast/shapes/parsing/parsing-shape-lengths-expected.txt:
  • fast/shapes/parsing/parsing-shape-lengths.html:
12:17 PM Changeset in webkit [159821] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Shapes] shape-inside rectangle layout can fail
​https://bugs.webkit.org/show_bug.cgi?id=124784

Reviewed by Andreas Kling.

Source/WebCore:

Apply LayoutUnit::fromFloatCeil() consistently in RectangleShape::firstIncludedIntervalLogicalTop().

Test: fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html

  • rendering/shapes/RectangleShape.cpp:

(WebCore::RectangleShape::firstIncludedIntervalLogicalTop):

LayoutTests:

Regression test.

  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top.html: Added.
11:02 AM Changeset in webkit [159820] by commit-queue@webkit.org
  • 2 edits
    2 deletes in trunk/Source

Remove Qt-specific .qrc files
​https://bugs.webkit.org/show_bug.cgi?id=124944

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-27
Reviewed by Andreas Kling.

Source/WebCore:

No new tests needed.

  • WebCore.qrc: Removed.

Source/WebKit2:

  • WebKit2.qrc: Removed.
9:41 AM Changeset in webkit [159819] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
​https://bugs.webkit.org/show_bug.cgi?id=124940

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Martin Robinson.

xserver-font-utils is needed for building gtk port dependencies
with jhbuild.

  • gtk/install-dependencies: Added xserver-font-utils to jhbuild

dependecies.

9:24 AM Changeset in webkit [159818] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
​https://bugs.webkit.org/show_bug.cgi?id=124938

Patch by Andres Gomez <Andres Gomez> on 2013-11-27
Reviewed by Philippe Normand.

Added needed git dependency for building the gtk port with
jhbuild. Also, the dependencies needed for building the gtk port
are now sorted alphabetically.

  • gtk/install-dependencies: Added git as jhbuild dependency and

sorted dependencies alphabetically.

8:35 AM Changeset in webkit [159817] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

Remove Sparc specific code.
​https://bugs.webkit.org/show_bug.cgi?id=124941

Patch by Tamas Gergely <​tgergely.u-szeged@partner.samsung.com> on 2013-11-27
Reviewed by Michael Saboff.

Sparc is not supported, remove leftover code.

  • wtf/Platform.h:
  • wtf/dtoa/utils.h:
8:23 AM WebKitGTK/Releasing edited by Andres Gomez
(diff)
8:22 AM WebKitGTK/StartHacking edited by Andres Gomez
(diff)
8:16 AM WebKitGTK/Releasing edited by Andres Gomez
(diff)
8:12 AM Changeset in webkit [159816] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix after r159805.

  • resources/runner.js:
8:09 AM WebKitGTK/StableRelease created by Andres Gomez
8:02 AM WebKitGTK edited by Andres Gomez
(diff)
7:55 AM Changeset in webkit [159815] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run_webkit_tests.py: error: no such option: --wincairo
​https://bugs.webkit.org/show_bug.cgi?id=124927

Patch by Jozsef Berta <​jberta@inf.u-szeged.hu> on 2013-11-27
Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports

the layout testing on wincairo, so it is turned off.

7:10 AM Changeset in webkit [159814] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Structure::m_staticFunctionReified should be a single bit.
<​https://webkit.org/b/124912>

Shave 8 bytes off of JSC::Structure by jamming m_staticFunctionReified
into the bitfield just above.

Reviewed by Antti Koivisto.

7:05 AM Changeset in webkit [159813] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSActivation constructor should use NotNull placement new.
<​https://webkit.org/b/124909>

Knock a null check outta the storage initialization loop.

Reviewed by Antti Koivisto.

6:34 AM Changeset in webkit [159812] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for flaky tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
5:04 AM Changeset in webkit [159811] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Programs/WebKit2APITests/TestWebKitSettings unit test is failing
​https://bugs.webkit.org/show_bug.cgi?id=124924

Reviewed by Carlos Garcia Campos.

'Chrome'/'Chromium' substrings were removed from the user agent string in r159572, meaning the unit
test shouldn't check for those two substrings anymore. Instead, 'Safari' (as until now) and 'AppleWebKit'
substrings should be checked for.

  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettingsUserAgent):

4:21 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas
Fix typo (diff)
3:48 AM WebKitGTK/SpeedUpBuild edited by Manuel Rego Casasnovas
Add documentation about icecc (diff)
2:47 AM Changeset in webkit [159810] by calvaris@igalia.com
  • 3 edits
    2 adds in trunk

[GStreamer] Invalid command line error when visiting www.chessbase.com
​https://bugs.webkit.org/show_bug.cgi?id=124715

Reviewed by Philippe Normand.

Source/WebCore:

We were not handling the HTTP errors in the WebKit GStreamer
source and therefore the 404 error page was being 'decoded'. As no
decoder could be found (for obvious reasons), playback failed, but
it should be failing for the source not being found instead of the
decoding problem.

Test: http/tests/media/video-error-does-not-exist.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::handleResponseReceived): Handle HTTP errors in
the source and raise a GStreamer error to the pipeline.

LayoutTests:

Copied and adapted for HTTP from
media/video-error-does-not-exist.html.

  • http/tests/media/video-error-does-not-exist-expected.txt: Added.
  • http/tests/media/video-error-does-not-exist.html: Added.
12:43 AM Changeset in webkit [159809] by svillar@igalia.com
  • 8 edits
    2 adds in trunk

[CSS Grid Layout] Fix positioning of grid items with margins
​https://bugs.webkit.org/show_bug.cgi?id=124345

Reviewed by David Hyatt.

From Blink r157925 and r158041 by <​jchaffraix@chromium.org>

Source/WebCore:

Test: fast/css-grid-layout/grid-item-margin-resolution.html

Adds margin start/before to the positions of grid items (removing
several FIXME's in the current code). This means calling
findChildLogicalPosition() after the layout in order to have the
right values for the margins.

In order to match flexbox and author's intents we're also
including the margins of grid items in the intrinsic size of the
grid. That's why flexbox's marginLogicalPositionForChild() is
moved up to RenderBlock in order to share it with RenderGrid.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::marginIntrinsicLogicalWidthForChild): Moved
from RenderFlexibleBox::marginLogicalWidthForChild().

  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredTrackWidth):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::findChildLogicalPosition):

LayoutTests:

New test case for grid items margin resolution. Extended the
preferred logical widths checks with grid items with margins.

  • fast/css-grid-layout/grid-item-margin-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-item-margin-resolution.html: Added.
  • fast/css-grid-layout/grid-preferred-logical-widths-expected.txt:
  • fast/css-grid-layout/grid-preferred-logical-widths.html:
12:31 AM Changeset in webkit [159808] by svillar@igalia.com
  • 7 edits
    2 adds in trunk

[CSS Grid Layout] Support grid-definition-{rows|columns} repeat() syntax
​https://bugs.webkit.org/show_bug.cgi?id=103312

Reviewed by Andreas Kling.

PerformanceTests:

Use the repeat() syntax to build the huge grids used by the
performance tests.

  • Layout/auto-grid-lots-of-data.html:
  • Layout/fixed-grid-lots-of-data.html:

Source/WebCore:

Added support for the repeat() syntax inside
grid-definition-{rows|columns} by just adding the repeated values
to our list of column|row definitions.

The parsing of <track-name> was refactored in a new function as
it's used now in three different places. The <track-size> parsing
was also refactored to share it with the repeat() parsing.

Test: fast/css-grid-layout/grid-element-repeat-get-set.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridTrackNames):
(WebCore::CSSParser::parseGridTrackList):
(WebCore::CSSParser::parseGridTrackRepeatFunction):
(WebCore::CSSParser::parseGridTrackSize):

  • css/CSSParser.h:

LayoutTests:

Based on Blink r153155 by <​jchaffraix@chromium.org>. Some code was
refactored in a helper function to have a more compact test.

  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-element-repeat-get-set.html: Added.
Note: See TracTimeline for information about the timeline view.