Timeline
Jan 15, 2014:
- 11:37 PM Changeset in webkit [162118] by
-
- 10 edits in trunk/Source
[GTK][EFL][NIX] Do not use PrintContext, Frame and DocumentLoader in Errors
https://bugs.webkit.org/show_bug.cgi?id=127047
Reviewed by Martin Robinson.
Source/WebCore:
Using PrintContext, Frame and DocumentLoader in platform is a
layering violation.
Change printing error methods to receive a failing URL instead of
receiving a PrintContext that was used only to get the failing
URL.
- platform/efl/ErrorsEfl.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/efl/ErrorsEfl.h:
- platform/gtk/ErrorsGtk.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/gtk/ErrorsGtk.h:
- platform/nix/ErrorsNix.cpp:
(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):
- platform/nix/ErrorsNix.h:
Source/WebKit2:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
(WebKit::WebPrintOperationGtk::frameURL): Helper function to get
the URL of the frame being printed.
(WebKit::WebPrintOperationGtk::print): Use frameURL() as failing
URL for printing errors.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- 11:33 PM Changeset in webkit [162117] by
-
- 11 edits26 adds in trunk
[CSS Regions] Enable accelerated compositing for fixed elements in named flows
https://bugs.webkit.org/show_bug.cgi?id=125144
Reviewed by David Hyatt.
Source/WebCore:
Add support for compositing for fixed positioned element that are collected
inside a named flow. Prior to this patch, the fixed positioned elements were
positioned and sized properly but only in the non-compositing scenario.
Tests: compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html
compositing/regions/fixed-in-diff-named-flows-zIndex.html
compositing/regions/fixed-in-named-flow-clip-descendant.html
compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html
compositing/regions/fixed-in-named-flow-from-outflow.html
compositing/regions/fixed-in-named-flow-got-transformed-parent.html
compositing/regions/fixed-in-named-flow-lost-transformed-parent.html
compositing/regions/fixed-in-named-flow-overlap-composited.html
compositing/regions/fixed-in-named-flow-position-changed.html
compositing/regions/fixed-in-named-flow-transformed-parent.html
compositing/regions/fixed-in-named-flow-zIndex.html
compositing/regions/fixed-in-named-flow.html
compositing/regions/fixed-transformed-in-named-flow.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionForCompositedLayer):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
- rendering/RenderLayerCompositor.h:
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderNamedFlowThread.h:
LayoutTests:
Added new tests and made the existing tests for fixed positioned elements use the
non-compositing mode.
- compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt: Added.
- compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html: Added.
- compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html: Added.
- compositing/regions/fixed-in-diff-named-flows-zIndex.html: Added.
- compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-clip-descendant.html: Added.
- compositing/regions/fixed-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html: Added.
- compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-from-outflow.html: Added.
- compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-got-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-lost-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-overlap-composited.html: Added.
- compositing/regions/fixed-in-named-flow-position-changed-expected.html: Added.
- compositing/regions/fixed-in-named-flow-position-changed.html: Added.
- compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Added.
- compositing/regions/fixed-in-named-flow-transformed-parent.html: Added.
- compositing/regions/fixed-in-named-flow-zIndex-expected.html: Added.
- compositing/regions/fixed-in-named-flow-zIndex.html: Added.
- compositing/regions/fixed-in-named-flow.html: Added.
- compositing/regions/fixed-transformed-in-named-flow-expected.txt: Added.
- compositing/regions/fixed-transformed-in-named-flow.html: Added.
- fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html:
- fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html:
- fast/regions/repaint/element-inflow-fixed-from-outflow-static.html:
- fast/regions/repaint/element-outflow-static-from-inflow-fixed.html:
- 11:19 PM Changeset in webkit [162116] by
-
- 4 edits in trunk/Source
Fix the iOS build after r162114
Unreviewed.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
Source/WebCore:
- WebCore.exp.in: Move the symbol to the right section and add the missing symbols for iOS.
Source/WebKit/mac:
- WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
- 11:00 PM Changeset in webkit [162115] by
-
- 3 edits4 adds in trunk
[CSS Regions] Fix painting when the composited region has overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=124887
Patch by Mihai Maerean <Mihai Maerean> on 2014-01-15
Reviewed by Alexandru Chiculita.
Source/WebCore:
When the layer of the region is composited, the region receives a GraphicsLayer of its own
so the clipping coordinates (caused by overflow:hidden) must be relative to the
GraphicsLayer coordinates in which the region gets painted.
Also, while the painting is done relative to the location of the region's content box, the
clipping is bound to the padding box of the region.
Tests: compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html
compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFlowThreadIfRegion):
LayoutTests:
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div-expected.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html: Added.
- compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region-expected.html: Added.
- 10:42 PM Changeset in webkit [162114] by
-
- 13 edits3 adds in trunk/Source
Move user agent code to WebCore and unify some code between OS X and iOS
https://bugs.webkit.org/show_bug.cgi?id=127080
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-15
Reviewed by Sam Weinig.
Source/WebCore:
Move the duplicated code from WebView and WebPageProxy to two files
in WebCore: UserAgentMac and UserAgentIOS.
- Configurations/WebCore.xcconfig:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- page/ios/UserAgentIOS.mm: Added.
(WebCore::platformSystemRootDirectory):
(WebCore::osMarketingVersion):
(WebCore::standardUserAgentWithApplicationName):
- page/mac/UserAgent.h: Added.
- page/mac/UserAgentMac.mm: Added.
(WebCore::systemMarketingVersionForUserAgentString):
(WebCore::standardUserAgentWithApplicationName):
- platform/ios/WebCoreSystemInterfaceIOS.h:
- platform/ios/WebCoreSystemInterfaceIOS.mm:
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebView/WebView.mm:
(userVisibleWebKitVersionString):
(+[WebView _standardUserAgentWithApplicationName:]):
(-[WebView _setUIWebViewUserAgentWithBuildVersion:]):
Source/WebKit2:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::standardUserAgent):
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 9:27 PM Changeset in webkit [162113] by
-
- 2 edits in trunk/Source/WebCore
Fix windows build.
- platform/text/TextAllInOne.cpp:
- 9:05 PM Changeset in webkit [162112] by
-
- 11 edits in trunk/Source
[iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge
https://bugs.webkit.org/show_bug.cgi?id=127069
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-15
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj:
Export XPCConnection because it is needed by RemoteInspector.h.
- inspector/remote/RemoteInspectorXPCConnection.h:
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::startDisabled):
(Inspector::RemoteInspector::shared):
Allow RemoteInspector singleton to start disabled.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView allowsRemoteInspection]):
Implement with RemoteInspector.h SPIs.
(-[WebView setAllowsRemoteInspection:]):
(-[WebView setHostApplicationBundleId:name:]):
Still unimplemented, update comment.
(-[WebView _didCommitLoadForFrame:]):
Remove dead path, WebCore now pushes updates on navigations.
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
(-[WebViewPrivate init]):
Remove now unused ivar.
- 8:29 PM Changeset in webkit [162111] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Use timestamp when event occurs for touch events.
https://bugs.webkit.org/show_bug.cgi?id=126424
Reviewed by Gyuyoung Kim.
Current time is used for touch event's timestamp instead of timestamp
when event occurs. Timestamp of touch event is used to implement flick
gesture, so it should be real value for accurate gesture processing.
- UIProcess/API/efl/EwkView.cpp:
Function names for handling touch events are changed to distinguish
mouse events and multi events.
(EwkView::setTouchEventsEnabled):
(EwkView::feedTouchEvents):
(EwkView::handleMouseDownForTouch):
(EwkView::handleMouseUpForTouch):
(EwkView::handleMouseMoveForTouch):
(EwkView::handleMultiDownForTouch):
(EwkView::handleMultiUpForTouch):
(EwkView::handleMultiMoveForTouch):
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/GestureRecognizer.cpp:
(WebKit::GestureHandler::handlePan):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):
- UIProcess/API/efl/GestureRecognizer.h:
- 8:06 PM Changeset in webkit [162110] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. EFL Gardening.
- platform/efl-wk1/TestExpectations:
Unskipped some tests in svg/dynamic-updates which are passing now.
- 7:59 PM Changeset in webkit [162109] by
-
- 8 edits1 delete in trunk/Source/WebCore
TextBreakIterator's should support Latin-1 for all iterator types (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=126856
Reviewed by Ryosuke Niwa.
Move the contents of TextBreakIteratorICU.cpp to TextBreakIterator.cpp and remove TextBreakIteratorICU.cpp.
- CMakeLists.txt:
- GNUmakefile.list.am:
- PlatformGTK.cmake:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/text/TextBreakIterator.cpp:
- platform/text/TextBreakIteratorICU.cpp: Removed.
- 7:40 PM Changeset in webkit [162108] by
-
- 4 edits in trunk/Source/WebCore
MediaSessionManager shouldn't use std::map
https://bugs.webkit.org/show_bug.cgi?id=127003
Reviewed by Sam Weinig.
No new tests, no functional change.
Use an array instead of std::map.
- platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::addRestriction):
(WebCore::MediaSessionManager::removeRestriction):
(WebCore::MediaSessionManager::restrictions):
(WebCore::MediaSessionManager::sessionWillBeginPlayback):
- platform/audio/MediaSessionManager.h:
- 6:18 PM Changeset in webkit [162107] by
-
- 9 edits in trunk/Source
Change Page, FocusController to use ViewState
https://bugs.webkit.org/show_bug.cgi?id=126533
Unreviewed rollout, this caused a regression.
Source/WebCore:
- WebCore.exp.in:
- page/FocusController.cpp:
(WebCore::FocusController::FocusController):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContentIsVisible):
- page/FocusController.h:
(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::setIsInWindow):
(WebCore::Page::setIsVisuallyIdle):
(WebCore::Page::setIsVisible):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/Page.h:
(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewIsVisible):
(WebKit::WebPage::setFocused):
(WebKit::WebPage::setIsInWindow):
(WebKit::WebPage::setViewStateInternal):
(WebKit::WebPage::setIsVisuallyIdle):
- WebProcess/WebPage/WebPage.h:
- 6:04 PM Changeset in webkit [162106] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=127072
Don't autorelease wrapper object (WebProcessPlugInScriptWorld) for InjectedBundleScriptWorld::normalWorld().
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Geoffrey Garen.
In [WKWebProcessPlugInScriptWorld normalWorld], InjectedBundleScriptWorld::normalWorld() returns a static
instance, autoreleasing its wrapper object could cause a dangling pointer and crash later.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:
(+[WKWebProcessPlugInScriptWorld normalWorld]):
- 5:51 PM Changeset in webkit [162105] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] Resizing and entering/exiting full screen draws garbage
https://bugs.webkit.org/show_bug.cgi?id=127077
Reviewed by Dean Jackson.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs): Simplified logic regarding FBO switching.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Make sure a few things
are turned off that might affect blitting data from one FBO to another.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture): Actually turn dithering off!
(WebCore::GraphicsContext3D::reshape): Mark the context as dirty when resizing so that
the GL view is redrawn during resizing events.
- 5:06 PM Changeset in webkit [162104] by
-
- 5 edits in trunk/Source/WebKit2
[iOS] Properly exclude the shim dylibs this time
https://bugs.webkit.org/show_bug.cgi?id=127075
Reviewed by Anders Carlsson.
BaseLegacyProcess.xcconfig was setting EXCLUDED_SOURCE_FILE_NAMES in
conflict with what I added in r161918, and I misspelled the setting
name in two instances. Fix these two bugs.
Also remove a vestigial OTHER_LDFLAGS from WebContentProcess.xcconfig
while we're here.
- Configurations/BaseLegacyProcess.xcconfig:
- Configurations/NetworkProcess.xcconfig:
- Configurations/PluginProcess.xcconfig:
- Configurations/WebContentProcess.xcconfig:
- 4:52 PM Changeset in webkit [162103] by
-
- 16 edits2 adds in trunk/Source/WebKit2
Support WebSelections in WK2 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=127015
Reviewed by Benjamin Poulain.
This is the first step towards adding support for selections in
non editable content on iOS for WK2.
In particular, this patch adds the basic plumbing to decide which
gesture recognizers are enabled and adds empty stubs for the gestures
that we'll need to support.
There are two separate assistants for selections, one to be used
in editable text (UIWKTextInteractionAssistant) and one for non editable
text (UIWKSelectionAssistant) and they are mutually exclusive.
UIWKSelectionAssistant is created at the time the view is created,
and swapped with UIWKTextInteraction assistant
only when an editable element is focused and the keyboard appears on screen.
gestureRecognizerShouldBegin is the delegate call used to decide which gestures
should begin based on the position the gesture occurred at.
We want to avoid as much as possible synchronous calls to the WebProcess to
retrieve information about the content and in order to do so, we take advantage
of the order in which the gesture recognizers will trigger, based on the delay
configured at initialization.
The first gesture to trigger is highlightLongPress, followed by longpress in the
active assistant and longpress in the WKInteractionView.
There are two different scenarios for highlighlongpress based on which assistant is
currently active.
UIWKSelectionAssistant is active:
We send a request to the WebProcess to get information on the position
and we return YES, allowing the gesture to start.
We delegate to the WebProcess the proper handling of highlight based on the element.
When longPress gesture fires for the assistant, we assume we have received the reply to our
previous request, if not we fetch the information synchronously.
We are then able to make an informed decision about whether
or not to start the gesture. If the reply is NO, the third and last long press
gesture can be evaluated to decide whether to show the action sheet or simply generate
a click event.
UIWKTextInteractionAssistant is active:
In this case we must have information about the position immediately and we issue
a synchronous request to the WebProcess.
If we are not interacting with the same node, we return NO.
Then the longpress gesture fires for the assistant which performs the same check.
If the node is the same, the loupe gesture will start, otherwise the last longpress
gesture will be evaluated to decide about showing the action sheet or generating a
click event.
- Scripts/webkit2/messages.py:
- Shared/InteractionInformationAtPosition.cpp: Added.
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h: Added.
(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):
- UIProcess/API/ios/PageClientImplIOS.h:
- UIProcess/API/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::positionInformationDidChange):
- UIProcess/API/ios/WKContentView.mm:
(-[WKContentView _positionInformationDidChange:]):
- UIProcess/API/ios/WKContentViewInternal.h:
- UIProcess/API/ios/WKInteractionView.h:
- UIProcess/API/ios/WKInteractionView.mm:
(-[WKInteractionView initWithFrame:]):
(-[WKInteractionView dealloc]):
(-[WKInteractionView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKInteractionView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(isSamePair):
(-[WKInteractionView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKInteractionView _showImageSheet]):
(-[WKInteractionView _showLinkSheet]):
(-[WKInteractionView _actionForLongPress]):
(-[WKInteractionView ensurePositionInformationIsUpToDate:]):
(-[WKInteractionView gestureRecognizerShouldBegin:]):
(-[WKInteractionView hasSelectablePositionAtPoint:]):
(-[WKInteractionView pointIsInAssistedNode:]):
(-[WKInteractionView _longPressRecognized:]):
(-[WKInteractionView _doubleTapRecognized:]):
(-[WKInteractionView _twoFingerDoubleTapRecognized:]):
(-[WKInteractionView _twoFingerPanRecognized:]):
(-[WKInteractionView useSelectionAssistantWithMode:]):
(-[WKInteractionView _positionInformationDidChange:]):
(-[WKInteractionView interactionAssistant]):
(-[WKInteractionView _startAssistingKeyboard]):
(-[WKInteractionView _stopAssistingKeyboard]):
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::didReceivePositionInformation):
(WebKit::WebPageProxy::getPositionInformation):
(WebKit::WebPageProxy::requestPositionInformation):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::requestPositionInformation):
- 4:27 PM Changeset in webkit [162102] by
-
- 10 edits3 deletes in tags/Safari-538.12
Rollout r161455. <rdar://problem/15828719>
- 4:14 PM Changeset in webkit [162101] by
-
- 2 edits in tags/Safari-538.12/Source/WebCore
Rollout r161778. <rdar://problem/15828719>
- 4:08 PM Changeset in webkit [162100] by
-
- 2 edits in trunk/Source/WebKit2
https://bugs.webkit.org/show_bug.cgi?id=127066
Add WKBrowsingContextHandle.h to WebKit2 private headers.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Dan Bernstein.
Add WKBrowsingContextHandle.h to WebKit2 private headers so that WebKit2 client
can use WKBrowsingContextHandle class.
- WebKit2.xcodeproj/project.pbxproj:
- 4:07 PM Changeset in webkit [162099] by
-
- 6 edits in trunk
Remove unnecessary call to webGLContextCreated
https://bugs.webkit.org/show_bug.cgi?id=127000
Reviewed by Brent Fulgham.
Source/WebCore:
Note that the functionality of webGLContextCreated will be handled by webGLPolicyForSite now.
Tests: Unskipping tests skipped in r162002.
- html/HTMLCanvasElement.cpp: Remove webGLContextCreated call.
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderClient.h:
Have the returned load policy default to WebGLAllow so as to not break clients that don't implement the method.
(WebCore::FrameLoaderClient::webGLPolicyForSite):
webGLPolicyForSite is now assuming the role of webGLContextCreated as well, pass in the whole site URL instead of just the host.
- page/ChromeClient.h: Remove webGLContextCreated method.
(WebCore::ChromeClient::decrementActivePageCount):
LayoutTests:
- platform/mac/TestExpectations: Unskipping tests skipped in r162002.
- 3:51 PM Changeset in webkit [162098] by
-
- 14 edits in trunk/Source/WebCore
Repeating background images should continue into margin tiles
https://bugs.webkit.org/show_bug.cgi?id=127021
-and corresponding-
<rdar://problem/15571300>
Reviewed by Simon Fraser.
This patch makes repeating background images continue into margin tiles.
RenderObject::repaintRectangle() now takes an addition bool parameter which
indicates whether or not the repaint rect should be clipped to the layer size.
- WebCore.exp.in:
These new functions on FrameView provide a way for code in the render tree to know
if the TiledBacking has a margin. tiledBacking() is now const. It should have
always been const, and it needs to be const to make these new functions const.
- page/FrameView.cpp:
(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::hasExtendedBackground):
(WebCore::FrameView::extendedBackgroundRect):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::tiledBacking):
If we’re painting the root background and it is an extended background, we need to
inflate the repaint rect to span the extended background.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::repaintLayerRectsForImage):
To get the phase right on repeated background images on a page with margin tiles,
we need to make sure we factor the size of the margin tiles into the left and top
values that we use when calculating background image geometry.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
setBackingNeedsRepaintInRect() now takes GraphicsLayer::ShouldClipToLayer as a
parameter, just like setBackingNeedsRepaint().
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
setContentsNeedDisplayInRect() also takes a GraphicsLayer::ShouldClipToLayer now,
and it passes that information down to the GraphicsLayer.
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):
- rendering/RenderLayerBacking.h:
These two RenderObject functions now take an optional bool parameter which
indicates whether or not the rect should be clipped to the layer size. They use a
bool instead of the GraphicsLayer enum in order to avoid including GraphicsLayer.h
from within RenderObject.h. This seems like a simpler solution than adding a new
stand-alone file for this very simple enum.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintRectangle):
- rendering/RenderObject.h:
RenderView::backgroundRect needs to return the extendedBackgroundRect when it had
one.
- rendering/RenderView.cpp:
(WebCore::RenderView::backgroundRect):
- 3:26 PM Changeset in webkit [162097] by
-
- 5 edits in trunk/Source/WebKit2
toStringVector static function definition should not be redundant.
https://bugs.webkit.org/show_bug.cgi?id=126872.
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-15
Reviewed by Anders Carlsson.
toStringVector function was declared twice in InjectedBundle.cpp and WebPageGroup.cpp as static.
In order to remove redundant definition this function was moved into API::Array.
- Shared/APIArray.cpp:
(API::Array::toStringVector):
- Shared/APIArray.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::WebPageGroup::addUserStyleSheet):
(WebKit::WebPageGroup::addUserScript):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
- 3:22 PM Changeset in webkit [162096] by
-
- 15 edits3 adds in trunk
Web Inspector: capture probe samples on the backend
https://bugs.webkit.org/show_bug.cgi?id=126668
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Add the 'probe' breakpoint action to the protocol. Change the setBreakpoint
commands to return a list of assigned breakpoint action identifiers
Add a type for breakpoint action identifiers. Add an event for sending
captured probe samples to the inspector frontend.
- inspector/protocol/Debugger.json:
Source/WebCore:
Test: inspector-protocol/debugger/setProbe-multiple-actions.html
Add the probe breakpoint action type. A probe action
evaluates an expression on the script call frame, and
the result is aggregated on a per-probe basis. Each
evaluated expression result is called a probe sample.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::evaluateBreakpointAction): Teach
the debug server to evaluate a probe.
(WebCore::ScriptDebugServer::dispatchDidSampleProbe): Added.
(WebCore::ScriptDebugServer::handleBreakpointHit): Increment a hit count.
(WebCore::ScriptDebugServer::getActionsForBreakpoint):
- bindings/js/ScriptDebugServer.h:
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::objectGroupForBreakpointAction): Added. Create an object
group for each breakpoint action. Currently only probes make objects.
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enable): Remove stale comment.
(WebCore::breakpointActionTypeForString): Add new case.
(WebCore::InspectorDebuggerAgent::breakpointActionsFromProtocol): Make
this a member function instead of a static function, so it can increment
the breakpoint action identifier counter.
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::setBreakpoint): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::removeBreakpoint): Release object
groups for any actions that were associated with the removed breakpoint.
(WebCore::InspectorDebuggerAgent::didSampleProbe): Added.
(WebCore::InspectorDebuggerAgent::clearResolvedBreakpointState): Renamed from clear().
(WebCore::InspectorDebuggerAgent::didClearGlobalObject): Renamed from reset().
- inspector/InspectorDebuggerAgent.h:
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
- inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpointAction::ScriptBreakpointAction): Add identifier member.
- inspector/ScriptDebugListener.h:
Source/WebInspectorUI:
- UserInterface/InspectorJSBackendCommands.js: Add probe enumeration value.
LayoutTests:
Add protocol tests for setting and hitting the probe breakpoint action type.
- inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
- inspector-protocol/debugger/setBreakpoint-actions.html:
- inspector-protocol/debugger/setProbe-multiple-actions-expected.txt: Added.
- inspector-protocol/debugger/setProbe-multiple-actions.html: Added.
- inspector-protocol/resources/probe-helper.js: Added.
(ProbeHelper.simplifiedProbeSample):
- 3:01 PM Changeset in webkit [162095] by
-
- 9 edits in tags/Safari-538.12/Source
Rollout 161609. <rdar://problem/15826281>
- 2:58 PM Changeset in webkit [162094] by
-
- 2 edits in trunk/Source/WebKit/mac
More iOS build fixing.
- WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
Removed a now unused local variable.
- 2:53 PM Changeset in webkit [162093] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix for iOS.
- WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):
Update a remaining call site of _updatePrivateBrowsingStateFram:to:.
- 2:43 PM Changeset in webkit [162092] by
-
- 2 edits in trunk/Tools
DumpRenderTree doesn't disable web preferences autosave
https://bugs.webkit.org/show_bug.cgi?id=127062
Reviewed by Dan Bernstein.
- DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
Do it.
- 2:35 PM Changeset in webkit [162091] by
-
- 2 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
- WebView/WebPreferences.mm: (-[WebPreferences _updatePrivateBrowsingStateTo:]):
Added a null check to fix Safari crash on startup when extensions are enabled.
- 2:25 PM Changeset in webkit [162090] by
-
- 2 edits in trunk/Tools
Improve filter-build-webkit, especially for iOS builds
https://bugs.webkit.org/show_bug.cgi?id=81046
Reviewed by Joseph Pecoraro.
Lots of updates to the filtering rules, mostly from the
iOS build output. Other highlights include:
- ignoring escape sequences for color ouput
- detecting escaped spaces in file name regexps
- Scripts/filter-build-webkit:
(shouldIgnoreLine):
- 2:16 PM Changeset in webkit [162089] by
-
- 12 edits1 add in branches/jsCStack/Source/JavaScriptCore
reentrant-caching sometimes fails with LLInt disabled
https://bugs.webkit.org/show_bug.cgi?id=126781
Reviewed by Michael Saboff.
The lookupExceptionHandler->genericUnwind->handleUncaughtException paths need to
be resilient against the frame from which we claim to be throwing the exception
being the sentinel frame.
Also attempted to add a test that pinpoints the problem, but it didn't cause a
crash either before or after my change. That's fine, I figured it would be good to
have more coverage for madness like this.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArguments):
- jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- jit/Repatch.cpp:
(JSC::tryBuildGetByIDList):
- jit/ThunkGenerators.cpp:
(JSC::throwExceptionFromCallSlowPathGenerator):
- llint/LowLevelInterpreter64.asm:
- tests/stress/recurse-infinitely-on-getter.js: Added.
(.var):
- 1:39 PM Changeset in webkit [162088] by
-
- 8 edits in trunk
REGRESSION (r158369): Some pop-up windows open at incorrect size (affects GMail, theblaze.com)
https://bugs.webkit.org/show_bug.cgi?id=126289
Reviewed by Anders Carlson.
Partial revert of https://bugs.webkit.org/show_bug.cgi?id=123557.
On window.open, update page when the UIProcess sends the create message
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
- creation paraments are not preserved at window.open.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::setViewStateInternal):
- WebProcess/WebPage/WebPage.h:
- add interface to update page.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
- if we try to create a page that already exists, update the current page's view state.
LayoutTests:
- platform/mac-wk2/TestExpectations:
- test is bad (results in DRT don't reflect in browser behaviour).
- 1:30 PM Changeset in webkit [162087] by
-
- 3 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
Reviewed by Sam Weinig.
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.
- WebView/WebPreferences.mm: Track how many WebPreferences objects use private
browsing, and only delete the private session when there are none any more.
- 1:21 PM Changeset in webkit [162086] by
-
- 2 edits in trunk/Source/WTF
[GTK] v2.3.3 fails to build in Debian / FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=126502
Reviewed by Mark Lam.
- wtf/Platform.h: Add LLINT support to FreeBSD.
- 12:13 PM Changeset in webkit [162085] by
-
- 2 edits in trunk/Source/WebCore
[WebGL] Validation function for compressed formats incorrect
https://bugs.webkit.org/show_bug.cgi?id=127023
Reviewed by Dean Jackson.
No new tests. Covered by existing WebGL compressed texture tests.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData): Revise to match specifications.
- 12:09 PM Changeset in webkit [162084] by
-
- 17 edits3 deletes in trunk/Source
Remove the CSS selector profiler.
<https://webkit.org/b/127039>
Source/WebCore:
The selector profiler was painting a mostly fictional picture of what
selectors we were spending time on. It never really grokked the fast
path selectors, nor did it understand recent additions like the extra
cascading pass or the selector JIT.
Somewhat ironically, this may end up making some selectors run faster
since it removes a number of brances in hot code.
Reviewed by Sam Weinig.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
- css/ElementRuleCollector.h:
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
- inspector/InspectorInstrumentation.h:
- inspector/protocol/CSS.json:
Source/WebInspectorUI:
Purge selector profiler code from the new Web Inspector UI.
Reviewed by Sam Weinig.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/CSSSelectorProfileObject.js: Removed.
- UserInterface/CSSSelectorProfileType.js: Removed.
- UserInterface/CSSSelectorProfileView.js: Removed.
- UserInterface/ContentView.js:
(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):
- UserInterface/InspectorWebBackendCommands.js:
- UserInterface/InstrumentSidebarPanel.js:
(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
(WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
(WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
- UserInterface/Main.html:
- UserInterface/ProfileManager.js:
(WebInspector.ProfileManager):
(WebInspector.ProfileManager.prototype.initialize):
(WebInspector.ProfileManager.prototype._checkForInterruptions):
(WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
- WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
- 11:01 AM Changeset in webkit [162083] by
-
- 4 edits7 adds in trunk
[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188
Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-15
Reviewed by Chris Fleizach.
Source/WebCore:
When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.
Tests: svg/custom/conditional-processing-1.svg
svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html
- svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.
(WebCore::SVGSwitchElement::childShouldCreateRenderer):
- svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.
(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):
LayoutTests:
conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.
- svg/custom/conditional-processing-1-expected.svg: Added.
- svg/custom/conditional-processing-1.svg: Added.
- svg/custom/conditional-processing-2-expected.html: Added.
- svg/custom/conditional-processing-2.html: Added.
- svg/dom/SVGTests-expected.txt: Added.
- svg/dom/SVGTests.html: Added.
- svg/dom/script-tests/SVGTests.js: Added.
- 11:00 AM Changeset in webkit [162082] by
-
- 2 edits1 copy1 delete in trunk/LayoutTests
AX: Merge layout test from Mac and GTK checking accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=126685
Fix Mac test results.
- platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Removed.
This test was merged into another, but its Mountain Lion results were not moved accordingly.
- platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Copied from LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt.
Custom results with a different role for "dl".
- platform/mac/accessibility/roles-exposed-expected.txt: Changed to have results that
are correct forward looking.
- 10:37 AM Changeset in webkit [162081] by
-
- 2 edits in trunk/Source/WebKit/mac
[iOS] Missing RenderObject::style() symbol in WebDOMOperations.mm
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"ZNK7WebCore12RenderObject5styleEv", referenced from:
-[DOMNode(WebDOMNodeOperations) isHorizontalWritingMode] in WebDOMOperations.o
- DOM/WebDOMOperations.mm: Include RenderElement.h instead of
RenderObject.h since the inline RenderObject::style() method
moved to the former header.
- 10:29 AM Changeset in webkit [162080] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r162066.
http://trac.webkit.org/changeset/162066
https://bugs.webkit.org/show_bug.cgi?id=127056
The added test still fails on some bots (Requested by ap on
#webkit).
Source/WebCore:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
- platform/efl/TestExpectations:
- 10:23 AM Changeset in webkit [162079] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix intialization order of ResourceResponse constructor
Fixes the following build failure:
WebCore/platform/network/mac/ResourceResponseMac.mm:83:7: error: field 'm_nsResponse' will be initialized after field 'm_initLevel' [-Werror,-Wreorder]
, m_nsResponse(nsResponse)
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::ResourceResponse): Reorder member
initializers to match the order that they are defined in the
header.
- 10:11 AM Changeset in webkit [162078] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Comment out part of r162036 which broke WebGL on many ports.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- 10:03 AM Changeset in webkit [162077] by
-
- 2 edits1 delete in trunk/LayoutTests
Unreviewed test correctino for webgl compressed textures.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt:
- platform/mac-mountainlion/fast/canvas: Removed.
- platform/mac-mountainlion/fast/canvas/webgl: Removed.
- platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
- 9:53 AM Changeset in webkit [162076] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add failure test expectations for reftests added in r161626.
- platform/efl/TestExpectations:
- 9:46 AM Changeset in webkit [162075] by
-
- 3 edits in trunk/Source/WebKit/mac
Unreviewed, rolling out r162054.
http://trac.webkit.org/changeset/162054
https://bugs.webkit.org/show_bug.cgi?id=127053
Causes assertion failures in DumpRenderTree (Requested by ap
on #webkit).
- WebView/WebPreferences.mm:
(-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):
(+[WebPreferences standardPreferences]):
(-[WebPreferences dealloc]):
(-[WebPreferences setPrivateBrowsingEnabled:]):
(-[WebPreferences _invalidateCachedPreferences]):
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
- 9:45 AM Changeset in webkit [162074] by
-
- 3 edits in trunk/Source/WTF
Get rid of RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=127051
Reviewed by Antti Koivisto.
It's not used anywhere anymore, get rid of it.
- wtf/RefCounted.h:
- wtf/SizeLimits.cpp:
- 9:37 AM Changeset in webkit [162073] by
-
- 7 edits2 adds in trunk
[GTK] Web process sometimes crashes when printing in synchronous mode
https://bugs.webkit.org/show_bug.cgi?id=126979
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When printing synchronously in GTK+ we need to make sure that we
have a list of Printers before starting the print operation. Getting
the list of printers is done synchronously by GTK+, but using a
nested main loop that might process IPC messages comming from the
UI process like EndPrinting. When the EndPrinting message is
received while the printer list is being populated, the print
operation is finished unexpectely and the web process crashes. The
PrinterListGtk class gets the list of printers in the constructor
so we just need to ensure there's an instance alive during the
synchronous print operation. In case of asynchronous printing the
printer list will be created during the print operation without
any risk, because the EndPrinting message is not sent until the
printing callback has been received in the UI process.
- GNUmakefile.list.am: Add new files to compilation.
- PlatformGTK.cmake: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::print): Ensure PrinterListGtk is created
before the synchronous printing and destroyed afterwards.
- WebProcess/WebPage/gtk/PrinterListGtk.cpp: Added.
(WebKit::PrinterListGtk::shared): Return the singleton.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Callback
called by gtk_enumerate_printers() when a new printer is found.
(WebKit::PrinterListGtk::PrinterListGtk): Call
gtk_enumerate_printers() in syhchronous mode.
(WebKit::PrinterListGtk::~PrinterListGtk):
(WebKit::PrinterListGtk::addPrinter): Add the printer to the list
and set the default printer if needed.
(WebKit::PrinterListGtk::findPrinter): Find the printer for the
given name.
- WebProcess/WebPage/gtk/PrinterListGtk.h: Added.
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Use
PrinterListGtk class to find the printer instead of calling
gtk_enumerate_printers().
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskip
/webkit2/WebKitPrintOperation/close-after-print.
- 9:22 AM Changeset in webkit [162072] by
-
- 2 edits in trunk/LayoutTests
Merged some subpixel skipped tests. Unreviewed.
webkit.org/b/126894 is a duplicate of webkit.org/b/126892
- platform/mac/TestExpectations:
- 9:19 AM Changeset in webkit [162071] by
-
- 3 edits in trunk/Source/WebCore
WordMeasurement is a struct, not a class
https://bugs.webkit.org/show_bug.cgi?id=125373
Reviewed by Anders Carlsson.
Change class to struct, because there is no reason for WordMeasurement to be a class.
No new tests, no behavior change.
- rendering/RenderBlockFlow.h:
- rendering/line/BreakingContextInlineHeaders.h:
- 9:10 AM Changeset in webkit [162070] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed test fix for Mountain Lion WebGL behavior.
Add Mountain Lion expected output matching ML's output of INVALID_OPERATION for improperly-sized textures.
- platform/mac-mountainlion/fast/canvas: Added.
- platform/mac-mountainlion/fast/canvas/webgl: Added.
- platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- 9:03 AM Changeset in webkit [162069] by
-
- 5 edits2 adds in trunk/Source/WebKit/gtk
[GTK][WK1] Add ProgressTrackerClient implementation
https://bugs.webkit.org/show_bug.cgi?id=127048
Reviewed by Anders Carlsson.
In r162034, the progress tracker client was separated from FrameLoaderClient into the
ProgressTrackerClient class. This patch adds the WebKit layer implementation of that
class for GTK-WK1 that's practically identical to the client implementation that was
in use under WebKit::FrameLoaderClient.
- GNUmakefile.am:
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
- WebCoreSupport/ProgressTrackerClientGtk.cpp: Added.
(WebKit::ProgressTrackerClient::ProgressTrackerClient):
(WebKit::ProgressTrackerClient::progressTrackerDestroyed):
(WebKit::ProgressTrackerClient::progressStarted):
(WebKit::ProgressTrackerClient::progressEstimateChanged):
(WebKit::ProgressTrackerClient::progressFinished):
- WebCoreSupport/ProgressTrackerClientGtk.h: Added.
- webkit/webkitwebview.cpp:
(webkit_web_view_init):
- 9:01 AM Changeset in webkit [162068] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed GTK gardening. Removing an unneeded GTK-specific baseline
for a layout test that was fixed proper in r161549.
- platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Removed.
- 5:15 AM Changeset in webkit [162067] by
-
- 1 edit2 moves1 add2 deletes in trunk/LayoutTests
AX: Merge layout test from Mac and GTK checking accessibility roles
https://bugs.webkit.org/show_bug.cgi?id=126685
Reviewed by Chris Fleizach.
Merged GTK and Mac tests into one cross-platform test that is
aware of the platform-specific differences by declaring which
elements are supported in which platforms and which platform
specific roles (if it's the case) should be expected.
- accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt.
- accessibility/roles-exposed.html: Added.
- platform/gtk/accessibility/roles-exposed.html: Removed.
- platform/mac/accessibility/role-subrole-roledescription.html: Removed.
- platform/mac/accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt.
- 4:32 AM Changeset in webkit [162066] by
-
- 6 edits2 adds in trunk
Source/WebCore: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
- svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
LayoutTests: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
Tests now use rectangles instead of circles for SVGs.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
- css3/compositing/background-blend-mode-data-uri-svg-image.html:
- platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
- 3:26 AM Changeset in webkit [162065] by
-
- 4 edits2 adds in trunk/PerformanceTests
[CSS Regions] Add performance tests for selection with mixed content
https://bugs.webkit.org/show_bug.cgi?id=126427
Reviewed by Ryosuke Niwa.
Add new performance tests for selection in CSS Regions mixing regular
content with regions. 2 new tests are added, one checking select all
command and another simulating a user selection passing through all the
paragraphs (similar to Layout/RegionsSelection.html).
Test are skipped for now while implementation of selection in CSS
Regions is still evolving.
- Layout/RegionsExtendingSelectionMixedContent.html: Added.
- Layout/RegionsSelectAllMixedContent.html: Added.
- Layout/resources/regions.css:
(.regular):
- Layout/resources/regions.js:
- Skipped:
- 2:30 AM Changeset in webkit [162064] by
-
- 3 edits2 adds in trunk
[CSS Regions] Hit-testing goes through clipped layer in fast/regions/overflow-first-and-last-regions-in-container-hidden.html
https://bugs.webkit.org/show_bug.cgi?id=126886
Reviewed by Mihnea Ovidenie.
Source/WebCore:
Currently, when hit testing a location inside a flow thread we ignore the clipping rectangle of
the region. This leads to false positives when the location is over the clipped out content of a
flow thread. The patch verifies that the location is inside the clipping rectangle of the region before
forwarding the hit test verification to the flow thread layer.
Test: fast/regions/hover-and-js-in-visual-overflow-hidden.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestFlowThreadIfRegion):
LayoutTests:
Add a test that verifies you can't hover an element flowed inside a region but found inside
the hidden overflow of the region.
- fast/regions/hover-and-js-in-visual-overflow-hidden-expected.html: Added.
- fast/regions/hover-and-js-in-visual-overflow-hidden.html: Added.
- 2:28 AM Changeset in webkit [162063] by
-
- 3 edits in trunk/Source/WebCore
Suspend resource requests during computedStyle
https://bugs.webkit.org/show_bug.cgi?id=127034
Reviewed by Andreas Kling.
We have some cases where getting computed style leads to crashes in loadPendingImages.
This is probably caused by load callbacks resulting in re-entering WebKit and killing the StyleResolver.
As a speculative fix suspend resource loads (and so callbacks) when getting the computed style.
We do similar suspension during style recalc for the same reason.
- dom/Document.cpp:
(WebCore::Document::styleForElementIgnoringPendingStylesheets):
- loader/ResourceLoadScheduler.h:
(WebCore::ResourceLoadScheduler::Suspender::Suspender):
(WebCore::ResourceLoadScheduler::Suspender::~Suspender):
- 2:14 AM Changeset in webkit [162062] by
-
- 7 edits3 adds in trunk
DocumentFragment should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115641
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-15
Reviewed by Ryosuke Niwa.
Source/WebCore:
http://www.w3.org/TR/2013/WD-dom-20131107/#interface-documentfragment
This allows us to donew DocumentFragmentinstead of
document.createDocumentFragment().
Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/86855c44a5a127716840fb377281b1c428e5eb2d%5E%21
Test: fast/dom/DocumentFragment/document-fragment-constructor.html
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::create):
- dom/DocumentFragment.h:
- dom/DocumentFragment.idl:
LayoutTests:
- fast/dom/DocumentFragment/document-fragment-constructor-expected.txt: Added.
- fast/dom/DocumentFragment/document-fragment-constructor.html: Added.
- fast/dom/dom-constructors-expected.txt:
- fast/dom/dom-constructors.html:
- 2:01 AM Changeset in webkit [162061] by
-
- 6 edits2 adds in trunk/Source/WebKit
[EFL][WK1] Implement ProgressTrackerClientEfl to fix the crash
https://bugs.webkit.org/show_bug.cgi?id=127031
Reviewed by Gyuyoung Kim.
Source/WebKit:
- PlatformEfl.cmake: Added ProgressTrackerClientEfl.cpp into source lists.
Source/WebKit/efl:
Implmemented and moved ProgressTrackerClient logic from FrameLoaderClientEfl.
ProgressTrackerClient should be indenpendent instance since r162034
- WebCoreSupport/FrameLoaderClientEfl.cpp:
- WebCoreSupport/FrameLoaderClientEfl.h:
- WebCoreSupport/ProgressTrackerClientEfl.cpp:
(WebCore::ProgressTrackerClientEfl::ProgressTrackerClientEfl):
(WebCore::ProgressTrackerClientEfl::progressTrackerDestroyed):
(WebCore::ProgressTrackerClientEfl::progressStarted):
(WebCore::ProgressTrackerClientEfl::progressEstimateChanged):
(WebCore::ProgressTrackerClientEfl::progressFinished):
- WebCoreSupport/ProgressTrackerClientEfl.h: Added.
- ewk/ewk_view.cpp:
(_ewk_view_priv_new):
- 1:58 AM WebKitGTK/2.2.x edited by
- (diff)
- 1:55 AM Changeset in webkit [162060] by
-
- 4 edits in trunk/Tools
[EFL] Change test font installed path to webkitgtk-font-tests
https://bugs.webkit.org/show_bug.cgi?id=126723
Reviewed by Gyuyoung Kim.
I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
hard-coded in FontManagement.cpp#105
- DumpRenderTree/PlatformEfl.cmake:
- WebKitTestRunner/PlatformEfl.cmake:
- efl/jhbuild.modules:
- 1:45 AM Changeset in webkit [162059] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set
https://bugs.webkit.org/show_bug.cgi?id=126577
Patch by Tomas Popela <tpopela@redhat.com> on 2014-01-15
Reviewed by Carlos Garcia Campos.
As in http://trac.webkit.org/changeset/152483, but this time for
WebKit2. When WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER is set we need to
disable the MemoryCache completely to prevent caching of the resources.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformSetCacheModel):
- 12:01 AM Changeset in webkit [162058] by
-
- 9 edits2 adds in trunk
Make DoYouEvenBench runnable by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=127030
Reviewed by Andreas Kling.
PerformanceTests:
Added Full.html that runs 5 iterations of DoYouEvenBench. This is the canonical DoYouEvenBench,
which is also runnable by run-perf-tests.
- DoYouEvenBench/Full.html: Added.
- DoYouEvenBench/benchmark.html:
(startTest): Updated the code to account for the fact old measuredValues is pushed down to tests
property and we now have total property so that we don't have to manually compute the total.
- DoYouEvenBench/resources/benchmark-report.js: Added. When we're inside a DRT/WTR, use
PerfTestRunner to output that can be parsed by run-perf-tests. Do the same when the query part
or the fragment part of the current URL is "webkit" for debugging purposes.
- DoYouEvenBench/resources/benchmark-runner.js:
(BenchmarkRunner):
(BenchmarkRunner.prototype._appendFrame): Position the frame at (0, 0) inside DRT and WTR since
we have exactly 800px by 600px inside those two test runners. Also always insert the iframe as
the first child of body to avoid inserting it after the pre inserted by the test runner.
(BenchmarkRunner.prototype.step): Initializes _measuredValues.
(BenchmarkRunner.prototype.runAllSteps): Merged callNextStep in benchmark.html.
(BenchmarkRunner.prototype.runMultipleIterations): Added.
(BenchmarkRunner.prototype._runTestAndRecordResults): Compute the grand total among suites.
Also push down the sync and async time into tests property for consistency.
(BenchmarkRunner.prototype._finalize):
- Dromaeo/resources/dromaeorunner.js:
(DRT.testObject): Renamed dromaeoIterationCount to customIterationCount as this option is also
used by DoYouEvenBench.
- resources/runner.js: Ditto.
(.finish): Spit out the aggregator name.
Tools:
Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
":Total" to appear at the end of a test name. We don't do anything with it for now.
- Scripts/webkitpy/performance_tests/perftest.py:
(PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
to the JSON in a follow up patch for the perf dashboard.
(PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
LayoutTests:
Use customIterationCount as it has been renamed from dromaeoIterationCount.
- fast/harness/perftests/runs-per-second-iterations.html:
Jan 14, 2014:
- 11:56 PM Changeset in webkit [162057] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] UI process crashes when closing the window right after printing with javascript
https://bugs.webkit.org/show_bug.cgi?id=126981
Reviewed by Gustavo Noronha Silva.
The UI process crashes because when the page is closed, the web
view is destroyed before the print operation has actually
finished. Use a weak pointer to make sure the web view pointer is
set to NULL when the it's destroyed and emit the finished callback
always so that the user can clean up the operation even when the
web view has been closed.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted):
- 11:47 PM Changeset in webkit [162056] by
-
- 6 edits in trunk
[GTK] UI process crashes when the web process crashes while printing
https://bugs.webkit.org/show_bug.cgi?id=126977
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
When the web process crashes, the printing callback is
invalidated, so the function is called with a NULL error.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Check wkError is not NULL before
trying to use it.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewPrintFrame): Set the print mode of the operation
before emitting the print signal.
Tools:
Add new test case to check that closing the window right after
printing works. It's skipped for now, because this patch only
fixes the UI process crash, but not the web process one.
- Scripts/run-gtk-tests:
(TestRunner): Skip
/webkit2/WebKitPrintOperation/close-after-print.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintOperationPrintPrinter):
(findPrintToFilePrinter):
(testPrintOperationPrint):
(testPrintOperationErrors):
(testPrintOperationCloseAfterPrint):
(beforeAll):
- 11:41 PM Changeset in webkit [162055] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r161980.
CachedResourcesLoader.h should not belong to the CSS_SHADERS flag since it is used
out of the flag so it causes a compile failure when svg and css shaders are concurrently disabled.
- css/StyleResolver.cpp:
- 11:18 PM Changeset in webkit [162054] by
-
- 3 edits in trunk/Source/WebKit/mac
Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019
Reviewed by Sam Weinig.
- WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private
browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.
- WebView/WebPreferences.mm: Track how many WebPreferences objects use private
browsing, and only delete the private session when there are none any more.
- 11:00 PM Changeset in webkit [162053] by
-
- 3 edits in trunk/Source/WebKit/mac
Fix the iOS build after r162034.
- WebCoreSupport/WebProgressTrackerClient.mm:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 10:51 PM Changeset in webkit [162052] by
-
- 4 edits in trunk/Source/WebCore
Pack ResourceResponse harder.
<https://webkit.org/b/127005>
Re-arrange the members of ResourceResponse to reduce padding,
shrinking it by 8 bytes.
This nudges CachedResource and CachedImage into smaller size
classes, yielding a ~700 kB progression on Membuster3.
Reviewed by Anders Carlsson.
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::ResourceResponseBase):
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
- 10:50 PM Changeset in webkit [162051] by
-
- 23 edits2 deletes in trunk
Remove unnecessary WebkitCSSSVGDocumentValue
https://bugs.webkit.org/show_bug.cgi?id=126997
Reviewed by Andreas Kling.
Source/WebCore:
Removing redundant code path. WebkitCSSSVGDocumentValue
can be expressed by a CSSPrimitiveValue.
No new tests.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseFilter):
- css/CSSValue.cpp:
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h:
- css/WebKitCSSSVGDocumentValue.cpp: Removed.
- css/WebKitCSSSVGDocumentValue.h: Removed.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForFilter):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCSSText):
LayoutTests:
Update results after use of CSSPrimitiveValue.
- css3/filters/filter-property-computed-style-expected.txt:
- css3/filters/filter-property-expected.txt:
- css3/filters/filter-property-parsing-expected.txt:
- css3/filters/script-tests/filter-property-computed-style.js:
- css3/filters/script-tests/filter-property-parsing.js:
- css3/filters/script-tests/filter-property.js:
- fast/filter-image/parse-filter-image-expected.txt:
- fast/filter-image/parse-filter-image.html:
- 10:43 PM Changeset in webkit [162050] by
-
- 5 edits4 adds in trunk
[CSSRegions] Incorrect repaint of fixed element with transformed parent
https://bugs.webkit.org/show_bug.cgi?id=125756
Reviewed by Simon Fraser.
Source/WebCore:
When collecting the layers for fixed positioned elements with named flow
as a containing block, use layers collection at named flow layer level
instead of relying on the positioned elements collection.
With this approach, there are situations with nested named flows laid out in
auto-height regions and thus assuming 2 step layouts, in which is enough to lay
out the inner named flow once instead of twice with a performance gain.
In such situations, the layers lists for the inner named flow are not yet updated
when collectFixedPositionedLayers is called to paint the fixed positioned layers.
Therefore I called updateLayerListsIfNeeded for all named flows layers, via the flow thread controller, before inspecting the named flow layers to avoid hitting the assertions when
accessing the named flows layers lists.
Tests: fast/regions/repaint/fixed-in-named-flow-cb-changed.html
fast/regions/repaint/fixed-in-named-flow-cb-changed2.html
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/FlowThreadController.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
LayoutTests:
Add tests for a fixed positioned element with a parent that:
- dynamically gets a transform, in which case the fixed positioned element should be positioned
relative to its parent
- dynamically loses its transform, in which case the fixed positioned element should be positioned
relative to the view.
- fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.html: Added.
- fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Added.
- 10:36 PM Changeset in webkit [162049] by
-
- 4 edits in trunk
Unreviewed test fix.
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Emit
error state expected by Khronos test suite.
LayoutTests:
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Use same
failure mode as the khronos test suite.
- 10:34 PM Changeset in webkit [162048] by
-
- 2 edits in trunk/Source/WebKit/mac
Stop cmp from spewing useless info during postprocess-headers.sh.
- postprocess-headers.sh: Pass -s to silence cmp since we only care about the
exit status.
- 10:31 PM Changeset in webkit [162047] by
-
- 20 edits4 copies in trunk/Source
IDB: create object store support
<rdar://problem/15779639> and https://bugs.webkit.org/show_bug.cgi?id=127011
Reviewed by Anders Carlsson.
Source/WebCore:
Split the 3 objects declared in IDBDatabaseMetadata into their own header files:
- Modules/indexeddb/IDBDatabaseMetadata.h:
- Modules/indexeddb/IDBIndexMetadata.h:
(WebCore::IDBIndexMetadata::IDBIndexMetadata):
- Modules/indexeddb/IDBObjectStoreMetadata.h:
(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):
Add cross thread copying for IDBDatabaseMetadata:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBIndexMetadata>::copy):
(WebCore::IDBObjectStoreMetadata>::copy):
- platform/CrossThreadCopier.h:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
Add messaging/callback infrastructure for creating object stores:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::createObjectStore):
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::didCreateObjectStore):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::didChangeDatabaseVersion):
(WebKit::UniqueIDBDatabase::didCreateObjectStore):
(WebKit::UniqueIDBDatabase::didCompleteBoolRequest):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
- DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
Add serialization helpers to save/restore an IDBKeyPath to/from disk:
- DatabaseProcess/IndexedDB/IDBSerialization.cpp:
(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):
- DatabaseProcess/IndexedDB/IDBSerialization.h:
Add object store metadata to the schema, and save/restore the metadata:
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
- Scripts/webkit2/messages.py:
(struct_or_class):
- WebKit2.xcodeproj/project.pbxproj:
- 10:21 PM Changeset in webkit [162046] by
-
- 6 edits5 adds in branches/jsCStack/Source/JavaScriptCore
FTL slow path calls in inline caches should be down with exceptions
https://bugs.webkit.org/show_bug.cgi?id=127020
Not yet reviewed.
This just adds the relatively straight-forward glue code for emitting an exception
check on FTL IC slow paths and then jumping to the exception handling path.
Note that half of the attached tests failed before this change, often in very
funny ways, since the FTL IC slow paths previously just ignored exceptions. The
other half of the tests were some combination of accidental passes (because if you
ignore the exception but someone else along some path checks it then it will be
thrown and things will seem OK) and inadequate FTL coverage (so they would have
failed if the FTL supported GetByIdFlush for example).
Also updated some copyright notices that I previously forgot about.
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLJITFinalizer.cpp:
- ftl/FTLSlowPathCall.cpp:
(JSC::FTL::storeCodeOrigin):
(JSC::FTL::callOperation):
- ftl/FTLSlowPathCall.h:
- ftl/FTLState.h:
- tests/stress/get-by-id-throw-from-getter-through-optimized-code.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code-that-does-not-exit.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code.js: Added.
(foo):
(makeWithGetter.return):
(makeWithGetter):
- tests/stress/ic-throw-through-optimized-code.js: Added.
(foo):
- tests/stress/put-by-id-throw-through-optimized-code.js: Added.
(foo):
- 10:10 PM Changeset in webkit [162045] by
-
- 2 edits in trunk
Only use color in make output when it’s going to a terminal.
Reviewed by Mark Rowe.
- Makefile.shared:
- 9:43 PM Changeset in webkit [162044] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Unreviewed build fix after r162034
- GNUmakefile.list.am:
- 8:26 PM Changeset in webkit [162043] by
-
- 4 edits in trunk/Source
[iOS] Crash in NavigatorBase::vendor loading apple.com
https://bugs.webkit.org/show_bug.cgi?id=127028
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Daniel Bates.
Source/WebCore:
Export function pointers to be filled in with WebKitSystemInterface functions.
- WebCore.exp.in:
Source/WebKit/mac:
Fill in iOS WebKitSystemInterface functions.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 8:22 PM Changeset in webkit [162042] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for CMake based ports after r162034.
- CMakeLists.txt:
- 7:56 PM Changeset in webkit [162041] by
-
- 4 edits in trunk/Source
Build fix after r162034
Rubber-stamped by Benjamin Poulain.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp:
- 7:39 PM Changeset in webkit [162040] by
-
- 2 edits in trunk/LayoutTests
Merged some subpixel skipped tests. Unreviewed.
webkit.org/b/126893 is a duplicate of webkit.org/b/126892
- platform/mac/TestExpectations:
- 7:08 PM Changeset in webkit [162039] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Resource finish time is sometimes earlier than response received time.
https://bugs.webkit.org/show_bug.cgi?id=127027
Reviewed by Joseph Pecoraro.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didFinishLoading): Use currentTime() and not the
passed in finishTime.
- 7:04 PM Changeset in webkit [162038] by
-
- 2 edits in trunk/Source/WebCore
Follow up build fix attempt.
- WebCore.exp.in:
- 6:59 PM Changeset in webkit [162037] by
-
- 1 copy in tags/Safari-538.12
New Tag.
- 6:58 PM Changeset in webkit [162036] by
-
- 6 edits in trunk/Source/WebCore
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.
Reviewed by Brent Fulgham.
- WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
- html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.
(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.
If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.
- 6:57 PM Changeset in webkit [162035] by
-
- 7 edits3 adds in branches/jsCStack/Source/JavaScriptCore
FTL should be cool with runtime functions throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=127018
Reviewed by Geoffrey Garen.
This just adds the appropriate exception throwing off-ramp to the FTL. There's no
way to express that off-ramp in LLVM IR, so we just use a stackmap that we fill
with a jump to our own off-ramp. It's easy!
The throw-through-optimized-code test already worked because the architecture of
the FTL allows our existing unwinding to "just work". The
runtime-throw-through-optimized-code test used to crash but now works. The
empty-function test currently covers the case where there won't be any exception
handlers, though that will cease to be the case once we have real stack checks.
But even then the test will be useful - an overly optimizable function leads to
many otherwise-needed stackmaps not being emitted, so this will always test some
fun corner cases in FTL::fixFunctionBasedOnStackMaps().
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::entrypoint):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::callCheck):
- ftl/FTLState.h:
- tests/stress/empty-function.js: Added.
(foo):
- tests/stress/runtime-throw-through-optimized-code.js: Added.
(foo):
(bar):
- tests/stress/throw-through-optimized-code.js: Added.
(foo):
(bar):
- 6:43 PM Changeset in webkit [162034] by
-
- 14 edits3 copies1 add in trunk/Source
Create separate progress tracker clients
https://bugs.webkit.org/show_bug.cgi?id=127025
Reviewed by Sam Weinig.
Source/WebCore:
- loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::~ProgressTracker):
- loader/ProgressTrackerClient.h:
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
- WebCoreSupport/WebProgressTrackerClient.mm: Added.
(WebProgressTrackerClient::WebProgressTrackerClient):
(WebProgressTrackerClient::progressTrackerDestroyed):
(WebProgressTrackerClient::willChangeEstimatedProgress):
(WebProgressTrackerClient::didChangeEstimatedProgress):
(WebProgressTrackerClient::progressStarted):
(WebProgressTrackerClient::progressEstimateChanged):
(WebProgressTrackerClient::progressFinished):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit2:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
(WebKit::WebProgressTrackerClient::WebProgressTrackerClient):
(WebKit::WebProgressTrackerClient::progressTrackerDestroyed):
(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressEstimateChanged):
(WebKit::WebProgressTrackerClient::progressFinished):
- WebProcess/WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- 6:26 PM Changeset in webkit [162033] by
-
- 2 edits in trunk/Source/WTF
And yet another build fix.
- wtf/SizeLimits.cpp:
- 6:21 PM Changeset in webkit [162032] by
-
- 2 edits in trunk/Source/WTF
Another build fix.
- wtf/SizeLimits.cpp:
- 6:03 PM Changeset in webkit [162031] by
-
- 3 edits in trunk/Source/WebCore
[WebGL] WebGLRenderingContext::validateCompressedTexDimensions improperly calculates values
https://bugs.webkit.org/show_bug.cgi?id=126926
Reviewed by Dean Jackson.
Test coverage in fast/canvas/webgl/webgl-compressed-texture-size-limit.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::compressedTexImage2D): Pass target to
validation function.
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Revise
calculation to also confirm size is in bounds.
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions): Pass
target to validation function.
- html/canvas/WebGLRenderingContext.h: Modify signature.
- 5:58 PM Changeset in webkit [162030] by
-
- 2 edits in trunk/Source/WebCore
On iOS, we never want to make scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=127024
<rdar://problem/15745768>
Reviewed by Dean Jackson.
On platforms that delegate scrolling, don't try to make layers
for scrollbars.
This fixes a crash in RenderLayerCompositor::updateOverflowControlsLayers()
where m_overflowControlsHostLayer is null.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):
- 5:39 PM Changeset in webkit [162029] by
-
- 4 edits in trunk/Source/WebKit
Correct grave mistake in updating the pbxproj file rather than xcconfig.
Source/WebKit:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/WebKit.xcconfig:
- 5:35 PM Changeset in webkit [162028] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Make WebPageProxy's setUserAgent private
https://bugs.webkit.org/show_bug.cgi?id=127013
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-14
Reviewed by Anders Carlsson.
- UIProcess/WebPageProxy.h:
The API to modify the user agent already has 3 "setters":
-standardUserAgent
-setApplicationNameForUserAgent
-setCustomUserAgent
The method WebPageProxy::setUserAgent() is supposed to be internal, not used directly.
Using it directly would cause unexpected behaviors, for example:
-Set the user agent with setUserAgent.
-Set CustomUserAgent.
-Reset CustomUserAgent.
->The user agent is now standardUserAgent instead of the user agent defined initially.
- 4:52 PM Changeset in webkit [162027] by
-
- 6 edits in trunk/Source
Source/WebCore: Avoid PLATFORM() macros in exported headers.
- platform/ios/WebEvent.h:
Source/WebKit/ios: Avoid PLATFORM() macros in exported headers.
- WebView/WebPDFViewPlaceholder.h:
Source/WebKit/mac: #define ENABLE_DASHBOARD_SUPPORT for iOS.
- WebView/WebViewPrivate.h:
- 4:46 PM Changeset in webkit [162026] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Build fix for 32-bit simulator and device
CGFloat is defined to be float, double for 32-bit, and 64-bit devices respectively.
Because WebCore::createCGColorWithDeviceWhite() takes CGFloat arguments we need to
list both the float and double-variants of this symbol in WebCore.exp.in. Currently
we only list the version whose arguments are of type double.
- WebCore.exp.in:
- 4:28 PM Changeset in webkit [162025] by
-
- 2 edits in trunk/Source/WebKit
Attempt to fix 32-bit Mac build.
- WebKit.xcodeproj/project.pbxproj:
- 4:17 PM Changeset in webkit [162024] by
-
- 9 edits in trunk/Source
Source/WebCore: Clean up exports and headers for iOS.
Don't use ENABLE() macro in an exported header.
- platform/ios/wak/WAKResponder.h:
Source/WebKit/ios: Clean up exports and headers for iOS.
- Misc/WebNSStringDrawing.h: Don't use PLATFORM() macro in an exported header.
- WebCoreSupport/WebFrameIOS.h: Ditto.
- WebCoreSupport/WebSelectionRect.h: Ditto.
Source/WebKit/mac: Clean up exports and headers for iOS.
Need to export WebArchivePboardType on Mac and iOS.
- WebKit.exp:
- WebKit.mac.exp:
- 4:13 PM Changeset in webkit [162023] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Move symbol ZN7WebCore34registerQLPreviewConverterIfNeededEP5NSURLP8NSStringP6NSData to
section USE(QUICK_LOOK)
- WebCore.exp.in:
- 4:07 PM Changeset in webkit [162022] by
-
- 3 edits in trunk/Source/WebCore
Clean up DNSResolveQueue
https://bugs.webkit.org/show_bug.cgi?id=127007
Reviewed by Geoffrey Garen.
Move the shared() getter out of line and make it use NeverDestroyed.
Add a Timer member variable instead of inheriting from TimerBase.
Use std::atomic<int> for the m_requestsInFlight member variable.
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):
- platform/network/DNSResolveQueue.h:
(WebCore::DNSResolveQueue::decrementRequestCount):
- 4:00 PM Changeset in webkit [162021] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix header availability checks on iOS
https://bugs.webkit.org/show_bug.cgi?id=127016
Reviewed by Andy Estes.
Make DOMTouch* and DOMGesture* headers public headers on iOS,
and fix MigrateHeaders.make to skip availability checks when
building for iOS.
- MigrateHeaders.make:
- 4:00 PM Changeset in webkit [162020] by
-
- 2 edits in trunk/Source/WebCore
Two more exports for iOS.
- WebCore.exp.in:
- 3:22 PM Changeset in webkit [162019] by
-
- 2 edits in trunk/Source/WebKit/mac
Need to #import <WebCore/QuickLook.h>.
- WebView/WebDataSource.mm:
- 3:05 PM Changeset in webkit [162018] by
-
- 2 edits in trunk/Source/WTF
[iOS] Enable WTF_USE_UIKIT_EDITING
- wtf/Platform.h:
- 3:03 PM Changeset in webkit [162017] by
-
- 13 edits in trunk/Source/JavaScriptCore
Copying should be generational
https://bugs.webkit.org/show_bug.cgi?id=126555
Reviewed by Geoffrey Garen.
This patch adds support for copying to our generational collector. Eden collections
always trigger copying. Full collections use our normal fragmentation-based heuristics.
The way this works is that the CopiedSpace now has the notion of an old generation set of CopiedBlocks
and a new generation of CopiedBlocks. During each mutator cycle new CopiedSpace allocations reside
in the new generation. When a collection occurs, those blocks are moved to the old generation.
One key thing to remember is that both new and old generation objects in the MarkedSpace can
refer to old or new generation allocations in CopiedSpace. This is why we must fire write barriers
when assigning to an old (MarkedSpace) object's Butterfly.
- heap/CopiedAllocator.h:
(JSC::CopiedAllocator::tryAllocateDuringCopying):
- heap/CopiedBlock.h:
(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::didEvacuateBytes):
(JSC::CopiedBlock::isOld):
(JSC::CopiedBlock::didPromote):
- heap/CopiedBlockInlines.h:
(JSC::CopiedBlock::reportLiveBytes):
(JSC::CopiedBlock::reportLiveBytesDuringCopying):
- heap/CopiedSpace.cpp:
(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::didStartFullCollection):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::CopiedSpace::isPagedOut):
- heap/CopiedSpace.h:
(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::recycleEvacuatedBlock):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::startedCopying):
- heap/CopyVisitor.cpp:
(JSC::CopyVisitor::copyFromShared):
- heap/CopyVisitorInlines.h:
(JSC::CopyVisitor::allocateNewSpace):
(JSC::CopyVisitor::allocateNewSpaceSlow):
- heap/GCThreadSharedData.cpp:
(JSC::GCThreadSharedData::didStartCopying):
- heap/Heap.cpp:
(JSC::Heap::copyBackingStores):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::copyLater):
- heap/TinyBloomFilter.h:
(JSC::TinyBloomFilter::add):
- 3:01 PM Changeset in webkit [162016] by
-
- 4 edits in trunk/Source
[iOS] Enable QuickLook
https://bugs.webkit.org/show_bug.cgi?id=126954
Reviewed by David Kilzer.
Source/WebKit/mac:
Remove empty implementation for quickLookContentForURL: since we always enable QuickLook on iOS.
- WebView/WebView.mm:
(-[WebView quickLookContentForURL:]):
Source/WTF:
- wtf/Platform.h:
- 2:56 PM Changeset in webkit [162015] by
-
- 5 edits in trunk/Source/WebKit
Source/WebKit/ios: Remove .objc_class_name_WebInspectorXPCWrapper from export on iOS build.
- WebKit.iOS.exp:
Source/WebKit/mac: Move some Mac-only exports to WebKit.mac.exp for iOS build.
- WebKit.exp:
- WebKit.mac.exp:
- 2:55 PM Changeset in webkit [162014] by
-
- 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog
Updated review status on some bugs
- 2:44 PM Changeset in webkit [162013] by
-
- 3 edits in trunk/Source/WebKit/mac
Move some Mac-only exports to WebKit.mac.exp for iOS build.
- WebKit.exp:
- WebKit.mac.exp:
- 2:38 PM Changeset in webkit [162012] by
-
- 2 edits in trunk/Source/WebCore
One more buildfix after r161999.
- Modules/webaudio/MediaStreamAudioSource.h:
- 2:34 PM Changeset in webkit [162011] by
-
- 7 edits in trunk/Source
Source/WebCore: Export ZN7WebCore11FileChooser16chooseMediaFilesERKN3WTF6VectorINS1_6StringELm0ENS1_15CrashOnOverflowEEERKS3_PNS_4IconE
to fix WK1 iOS linking.
- WebCore.exp.in:
Source/WebKit/ios: Fix WK1 iOS build: need implementations of these functions in WebInspectorClientIOS.
- WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorClient::indicate):
(WebInspectorClient::hideIndication):
Source/WebKit/mac: Fix iOS WK1 linking.
- Configurations/WebKit.xcconfig: We do need WebOpenPanelResultListener
on iOS.
- WebCoreSupport/WebOpenPanelResultListener.mm: Need <WebCore/Icon.h>
- 2:33 PM Changeset in webkit [162010] by
-
- 2 edits in trunk/Tools
[WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
https://bugs.webkit.org/show_bug.cgi?id=127002
Reviewed by David Kilzer.
- Scripts/webkitdirs.pm:
(setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
- 2:20 PM Changeset in webkit [162009] by
-
- 4 edits in trunk/Source
Source/WebCore: iOS build fixing: export required by iOS WebKit1.
- WebCore.exp.in:
Source/WebKit/mac: iOS build fixing: link WebKit against Security.framework on iOS.
- Configurations/WebKit.xcconfig:
- 2:18 PM Changeset in webkit [162008] by
-
- 4 edits1 add in trunk/Source/WebKit
[WK1] Allow generated export files on iOS
https://bugs.webkit.org/show_bug.cgi?id=127008
Reviewed by Simon Fraser.
Source/WebKit:
Modify the export file generation rule to read from
a shared and platform-specific input file.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Add a new Mac-only symbol file.
- WebKit.exp: To begin, move the WebIcon* into the Mac-specific exports.
- WebKit.mac.exp: Added. New file holds Mac-only symbols.
- 2:13 PM Changeset in webkit [162007] by
-
- 27 edits in trunk
Unreviewed, rolling out r162000.
http://trac.webkit.org/changeset/162000
https://bugs.webkit.org/show_bug.cgi?id=127009
API versioning is wrong (Requested by rfong on #webkit).
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
- loader/FrameLoaderClient.h:
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
Source/WebKit2:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebLoaderClient.cpp:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
Tools:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
- 2:11 PM Changeset in webkit [162006] by
-
- 3 edits3 adds in trunk
ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
https://bugs.webkit.org/show_bug.cgi?id=126990.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseConstDeclarationList):
- We were missing an error check after attempting to parse an initializer expression. This is now fixed.
LayoutTests:
- js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
- js/dom/parse-syntax-error-in-initializer.html: Added.
- js/resources/parse-syntax-error-in-initializer.js: Added.
- Added bug test case as a regression test.
- 2:10 PM Changeset in webkit [162005] by
-
- 2 edits in trunk/Source/WebKit2
Speculative buildfix after r161999.
- Shared/APIObject.h:
- 1:53 PM Changeset in webkit [162004] by
-
- 5 edits in branches/safari-537.60-branch/Source
Versioning.
- 1:50 PM Changeset in webkit [162003] by
-
- 1 copy in tags/Safari-537.60.13
New Tag.
- 1:46 PM Changeset in webkit [162002] by
-
- 2 edits in trunk/LayoutTests
Skip some tests that now fail after r162000.
https://bugs.webkit.org/show_bug.cgi?id=127000.
- platform/mac/TestExpectations:
- 1:42 PM Changeset in webkit [162001] by
-
- 5 edits in trunk/Source/WebCore
[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
https://bugs.webkit.org/show_bug.cgi?id=126719
Reviewed by Dirk Schulze.
The standard location for conversions to/from CSSPrimitiveValues is CSSPrimitiveValueMappings.
This patch moves the conversion for LayoutBoxes from BasicShapeFunctions to
CSSPrimitiveValueMappings.h.
Refactoring, no new tests.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
- 1:41 PM Changeset in webkit [162000] by
-
- 27 edits in trunk
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.
Reviewed by Brent Fulgham.
- WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
- html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.
(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.
If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.
Boiler plate code for sending messages to and from the UI and Web Process.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.
- loader/FrameLoaderTypes.h:
- page/ChromeClient.h:
(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy):
- UIProcess/API/C/WKPageLoaderClient.h:
- UIProcess/API/C/WKPageUIClient.h:
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::webGLLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webGLContextCreated):
(WebKit::WebPageProxy::webGLPolicyForHost):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::webGLContextCreated):
- UIProcess/WebUIClient.h:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::webGLContextCreated):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForHost):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp: A sendSync is used here to get the webGLPolicyForHost message sent between the Web and UI process.
In the future this will be replaced with a strategy is non-blocking.
(WebKit::WebPage::getWebGLPolicyForHost):
- WebProcess/WebPage/WebPage.h:
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 1:38 PM Changeset in webkit [161999] by
-
- 9 edits1 delete in trunk/Source
Get rid of ThreadRestrictionVerifier
https://bugs.webkit.org/show_bug.cgi?id=127004
Reviewed by Sam Weinig.
Source/WebCore:
Remove now unneeded calls.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):
Source/WTF:
The ThreadRestrictionVerifier mechanism has been turned off for a while
since it doesn't really have a good solution for objects that are passed between threads.
Instead of having dead code in the tree, just get rid of it.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
- wtf/ThreadRestrictionVerifier.h: Removed.
- 1:19 PM Changeset in webkit [161998] by
-
- 3 edits in trunk/Source/WebKit2
WebKit2 leaks sudden termination assertions when a page with unload handlers is closed.
<https://webkit.org/b/126974> / <rdar://problem/15812954>
When a page with an unload handler is loaded, the web process tells the UI process that it
should disable sudden termination. However, when the page is closed the connection between
the web and UI process is torn down before the web content has a chance to tell the UI
process to reenable sudden termination.
Reviewed by Anders Carlsson.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::~WebProcessProxy): Balance any outstanding disableSuddenTermination calls.
(WebKit::WebProcessProxy::enableSuddenTermination): Decrement the count.
(WebKit::WebProcessProxy::disableSuddenTermination): Increment the count.
- UIProcess/WebProcessProxy.h:
- 12:59 PM Changeset in webkit [161997] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()
https://bugs.webkit.org/show_bug.cgi?id=126999
<rdar://problem/15810305>
Reviewed by Joseph Pecoraro.
Fixes an issue where we may crash when subsequently accessing WebCore::QLPreviewConverterDictionary()
or WebCore::QLContentDictionary(). Currently neither of these functions retain'ed the NSMutable dictionary
returned by [NSMutableDictionary dictionary]. Instead, we should allocate and initialize NSMutableDictionary
directly to ensure that the dictionary is retained.
- platform/network/ios/QuickLook.mm:
(QLPreviewConverterDictionary):
(QLContentDictionary):
- 12:52 PM Changeset in webkit [161996] by
-
- 4 edits2 adds in trunk
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error
LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
- 12:28 PM Changeset in webkit [161995] by
-
- 4 edits in trunk/Source/WebCore
WebCore icon database appears to leak sudden termination assertions
<https://webkit.org/b/126971> / <rdar://problem/15808797>
Introduce an RAII wrapper around disableSuddenTermination / enableSuddenTermination
and adopt it in IconDatabase to address the incorrect management of sudden termination.
IconDatabase now owns up to two SuddenTerminationDisabler objects. One ensures that
sudden termination is disabled while we're waiting on the sync timer to fire. The second
ensures that sudden termination is disabled while we're waiting on the sync thread to
process any pending work.
Reviewed by Alexey Proskuryakov.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Disable sudden termination until the sync thread
has finished this unit of work.
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Disable sudden termination until the
sync timer has fired.
(WebCore::IconDatabase::syncTimerFired): Clear the member variable to reenable sudden termination.
(WebCore::IconDatabase::syncThreadMainLoop): Taken ownership of the SuddenTerminationDisabler
instance when we start processing a unit of work. Discard the object when our work is complete.
- loader/icon/IconDatabase.h:
- platform/SuddenTermination.h:
(WebCore::SuddenTerminationDisabler::SuddenTerminationDisabler): Disable sudden termination when created.
(WebCore::SuddenTerminationDisabler::~SuddenTerminationDisabler): Enable it when destroyed.
- 12:23 PM Changeset in webkit [161994] by
-
- 12 edits in trunk/Source
Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
https://bugs.webkit.org/show_bug.cgi?id=126995
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::listingForDebuggable):
For each WebView, list the parent process. Listing the parent per WebView
is already supported back when we supported processes that could host WebViews
for multiple applications.
- inspector/remote/RemoteInspectorConstants.h:
Add a separate key for the bundle identifier, separate from application identifier.
- inspector/remote/RemoteInspectorDebuggable.cpp:
(Inspector::RemoteInspectorDebuggable::info):
- inspector/remote/RemoteInspectorDebuggable.h:
(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess):
If a RemoteInspectorDebuggable has a non-zero parent process identifier
it is a proxy for the parent process.
Source/WebCore:
- inspector/InspectorClient.h:
(WebCore::InspectorClient::parentProcessIdentifier):
Client method intended for WebKit2 so a WebProcess can link to its UIProcess.
- page/PageDebuggable.h:
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::parentProcessIdentifier):
Provide parent process identifier if there is one.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorClient.h:
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::parentProcessIdentifier):
WebProcesses are proxies for a parent UIProcess.
- 12:17 PM Changeset in webkit [161993] by
-
- 2 edits in trunk/Source/WTF
Enable the experimental selector code generator by default
https://bugs.webkit.org/show_bug.cgi?id=126953
Reviewed by Gavin Barraclough.
- wtf/Platform.h:
Enable CSS_SELECTOR_JIT on OS X x86_64 by default.
The feature is not ready to ship but it is stable enough to enable
for the bots and nightly.
- 12:14 PM Changeset in webkit [161992] by
-
- 2 edits in trunk/Source/WebKit2
iOS WebKit2 build fixes, part 3
- WebKit2.xcodeproj/project.pbxproj:
Remove some files from the 'All' target that should never have been a part of it.
- 12:07 PM Changeset in webkit [161991] by
-
- 4 edits in trunk/Source
iOS WebKit2 build fixes, part 2
- WebKit2.xcodeproj/project.pbxproj:
Add some missing files.
- WebCore.exp.in:
Export some more symbols.
- 11:50 AM Changeset in webkit [161990] by
-
- 2 edits in trunk/Tools
[GTK] Skip FontConfig initialization in WebKitTestRunner if requested
https://bugs.webkit.org/show_bug.cgi?id=120110
Reviewed by Martin Robinson.
Skip the FontConfig settings initialization in WebKitTestRunner if the
WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
This is useful when profiling the WebKitTestRunner execution, where at the startup
this step takes considerable amount of time and disturbs the profiling output.
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeFontConfigSetting):
- 11:41 AM Changeset in webkit [161989] by
-
- 12 edits2 copies in branches/safari-537.60-branch
Merge r154470
2013-08-22 Simon Fraser <Simon Fraser>
compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
https://bugs.webkit.org/show_bug.cgi?id=119825
Source/WebCore:
Reviewed by Tim Horton.
r137526 and some earlier commits attempted to avoid unconditionally
repainting layers when their size changes, because this was causing
TiledBacking layers to repaint when the document size changed.
However, the approach required that we have good information about
whether size changes require a repaint, which in some cases is hard
to determine, especially when RenderLayer changes affect our
decisions about which layers are composited.
Fix by pushing the decision about whether to repaint on size change
into GraphicsLayer. The default is to repaint on size change,
but GraphicsLayer provides a function that can be overridden to
modify this behavior; GraphicsLayerCA does so to avoid repaints
when layers with TiledBackings get resized.
Test: compositing/repaint/repaint-on-layer-grouping-change.html
- WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
- platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::setSize):
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
- platform/graphics/ca/GraphicsLayerCA.h:
- rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes care of repainting for us now, so we can remove all the conditional code.
LayoutTests:
Reviewed by Tim Horton.
Test that dumps repaint rects on layers after visibility changes affect
the layer hierarchy.
- compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
- compositing/repaint/repaint-on-layer-grouping-change.html: Added.
- compositing/repaint/resize-repaint-expected.txt: Update result.
- 11:21 AM Changeset in webkit [161988] by
-
- 12 edits in trunk
Add ENABLE(WEB_REPLAY) feature flag to the build system
https://bugs.webkit.org/show_bug.cgi?id=126949
Patch by Brian J. Burg <Brian Burg> on 2014-01-14
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h: for now, disable the flag by default.
Tools:
- Scripts/webkitperl/FeatureList.pm:
- 11:19 AM Changeset in webkit [161987] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::MediaSourcePrivateAVFObjC::hasAudio const + 13
https://bugs.webkit.org/show_bug.cgi?id=126768
Reviewed by Eric Carlson.
Null-check m_mediaSourcePrivate before calling.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
- 11:13 AM Changeset in webkit [161986] by
-
- 5 edits in trunk/Tools
REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
https://bugs.webkit.org/show_bug.cgi?id=126702
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Alexey Proskuryakov.
Resolve regression and remove a FIXME comment that is already fixed.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.open_text_file_for_reading):
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_file):
- Scripts/webkitpy/style/filereader.py:
(TextFileReader._read_lines):
- Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_count_delete_only_file):
(TextFileReaderTest):
(TextFileReaderTest.test_process_malformed_file):
- 10:59 AM Changeset in webkit [161985] by
-
- 1 edit1 move in trunk/Source/WebKit2
Move WKView.mm to WKViewIOS.mm as 161950 was supposed to do.
- UIProcess/API/ios/WKView.mm: Removed.
- UIProcess/API/ios/WKViewIOS.mm: Copied from UIProcess/API/ios/WKView.mm.
- 10:59 AM Changeset in webkit [161984] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Playback rate is not set when pipeline is not ready.
https://bugs.webkit.org/show_bug.cgi?id=126692
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Philippe Normand.
No new tests. Covered by existing tests.
Added new method updatePlaybackRate which is called when playback rate change is possible.
Added m_lastPlaybackRate in order to retrieve last correct playback rate and notify upper
layers about that setting playback rate failed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- 10:42 AM Changeset in webkit [161983] by
-
- 2 edits in trunk/Source/WTF
[Win] Application name in user agent string is truncated.
https://bugs.webkit.org/show_bug.cgi?id=126810
Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-14
Reviewed by Anders Carlsson.
- wtf/text/StringConcatenate.h:
(WTF::tryMakeString): Add missing 8 bit check for last argument.
- 10:39 AM Changeset in webkit [161982] by
-
- 4 edits2 deletes in trunk
Unreviewed, rolling out r161978.
http://trac.webkit.org/changeset/161978
https://bugs.webkit.org/show_bug.cgi?id=126992
Test case causes crash on some hardware (Requested by bfulgham
on #webkit).
Source/WebCore:
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
LayoutTests:
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.
- 10:19 AM Changeset in webkit [161981] by
-
- 6 edits4 deletes in trunk
Unreviewed, rolling out r161964 and r161965.
http://trac.webkit.org/changeset/161964
http://trac.webkit.org/changeset/161965
https://bugs.webkit.org/show_bug.cgi?id=126988
Tests do not pass on the bots because of slight color
differences. The tests should be redone with squared results
and blending that leads to stable colors. (Requested by krit_
on #webkit).
Source/WebCore:
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImage.h:
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
- css3/compositing/background-blend-mode-crossfade-image-expected.html: Removed.
- css3/compositing/background-blend-mode-crossfade-image.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
- 10:16 AM Changeset in webkit [161980] by
-
- 11 edits4 adds in trunk
[CSS Shapes] Shape images are now <image> types, not just URIs
https://bugs.webkit.org/show_bug.cgi?id=125224
Reviewed by Andreas Kling.
Source/WebCore:
Added support for image-set valued shapes. Added an optional ResourceLoaderOptions
parameter to CSSImageSetValue::cachedImageSet() to enable CORS-enabled fetch of
image-set images. This change is based on a similar patch for ordinary shape image values:
https://bugs.webkit.org/show_bug.cgi?id=123114.
Tests: fast/shapes/shape-inside/shape-inside-image-set.html
fast/shapes/shape-outside-floats/shape-outside-image-set.html
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
- css/CSSImageSetValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingShapeImage):
- css/StyleResolver.h:
- rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):
LayoutTests:
- fast/shapes/shape-inside/shape-inside-image-set-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-image-set.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-set-expected.html: Added.
- fast/shapes/shape-outside-floats/shape-outside-image-set.html: Added.
- 10:09 AM Changeset in webkit [161979] by
-
- 19 edits in trunk/Source/WebCore
AX: Modernize AccessibilityChildrenVector loops
https://bugs.webkit.org/show_bug.cgi?id=126915
Reviewed by Anders Carlsson.
Change appropriate for loops to use the new style.
Use auto where appropriate.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
- accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore::AccessibilityARIAGridRow::headerObject):
- accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::addChildren):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::ariaLabeledByText):
- accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::clearChildren):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::ariaFlowToElements):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::visibleRows):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::cellForColumnAndRow):
- accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
- accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(convertToNSArray):
(convertStringsToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):
- 9:53 AM Changeset in webkit [161978] by
-
- 4 edits2 adds in trunk
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error
LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925
Reviewed by Dean Jackson.
- fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
- fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
- fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
- 9:41 AM Changeset in webkit [161977] by
-
- 2 edits in trunk/LayoutTests
Unreviewed Mac TestExpectations update.
<https://webkit.org/b/126890> is duplicate of <https://webkit.org/b/126889>
- platform/mac/TestExpectations: Mark it as such.
- 9:30 AM Changeset in webkit [161976] by
-
- 8 edits in trunk/Source/WebKit2
[GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=126130
Reviewed by Anders Carlsson.
We need to notify the network process when the user preferred
languages have changed to update the SoupSession accordingly.
- NetworkProcess/NetworkProcess.h: Add
userPreferredLanguagesChanged when using soup network backend.
- NetworkProcess/NetworkProcess.messages.in: Add
UserPreferredLanguagesChanged message when using soup network
backend.
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::userPreferredLanguagesChanged): Update
the SoupSession to use the given languages.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call
userPreferredLanguagesChanged() when initialization parameters
contain languages.
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Remove unnedded WebCore prefix.
(WebKit::NetworkProcess::clearCacheForAllOrigins): Simplify using
a single line.
- Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Encode the
languages vector.
(WebKit::NetworkProcessCreationParameters::decode): Decode the
languages vector.
- Shared/Network/NetworkProcessCreationParameters.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::languageChanged): Send a message also to the
network process.
- UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebContext::platformInitializeNetworkProcess): Set
languages initial parameter.
- 9:16 AM Changeset in webkit [161975] by
-
- 2 edits in branches/jsCStack/Source/JavaScriptCore
Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES).
https://bugs.webkit.org/show_bug.cgi?id=126959.
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm:
- The LLINT sanitizeStackForVM() is not needed by the C loop, and will cause a build failure in the non-computed goto C loop build. This is now fixed by excluding the LLINT sanitizeStackForVM() from the C loop build.
- 9:02 AM Changeset in webkit [161974] by
-
- 5 edits in trunk/Source
[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference
https://bugs.webkit.org/show_bug.cgi?id=126966
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
We don't really need to modify the Vector just to ignore the C
locale.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::buildAcceptLanguages): Rework it to not modify the
passed vector to ignore the C locale when it's present.
(WebCore::SoupNetworkSession::setAcceptLanguages): Use const Vector<String>&.
- platform/network/soup/SoupNetworkSession.h:
Source/WebKit2:
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::setSoupSessionAcceptLanguage): Use const Vector<String>&.
- 8:41 AM Changeset in webkit [161973] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement::potentiallyPlaying can be more simple.
https://bugs.webkit.org/show_bug.cgi?id=111
Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Eric Carlson.
Tests: No new tests, just refactorings.
Expression is simplified because the first 'if' statement depends on the same condition
as pausedToBuffer value.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 8:29 AM Changeset in webkit [161972] by
-
- 2 edits1 copy in tags/Safari-538.11.1/Source/JavaScriptCore
Merged r161574. <rdar://problem/15762689>
- 8:29 AM Changeset in webkit [161971] by
-
- 5 edits in trunk/Source
Remove deprecated DeferrableOneShotTimer constructor.
<https://webkit.org/b/126984>
Source/WebCore:
Remove the deprecated constructor for callback functions that take
the timer by pointer instead of by reference.
This shrinks DeferrableOneShotTimer by 8 bytes.
Reviewed by Anders Carlsson.
- platform/Timer.h:
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):
Source/WebKit2:
Reviewed by Anders Carlsson.
- WebProcess/Plugins/PluginView.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):
Take the timer by reference so we can use the new constructor.
- 8:21 AM Changeset in webkit [161970] by
-
- 4 edits2 copies in tags/Safari-538.11.1
Merged r161404. <rdar://problem/15398575>
- 8:03 AM Changeset in webkit [161969] by
-
- 5 edits in tags/Safari-538.11.1/Source
Versioning.
- 8:00 AM Changeset in webkit [161968] by
-
- 1 copy in tags/Safari-538.11.1
New Tag.
- 7:58 AM Changeset in webkit [161967] by
-
- 7 edits in trunk/Source/WebCore
Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133
Reviewed by Antti Koivisto.
Clean-up the pendingSVGDocuments code in StyleResolver.
CachedSVGDocumentReference is responsible for requesting the
SVG document instead of WebKitCSSSVGDocumentValue.
CachedSVGDocumentReference can be used by other SVG resource like
clip-path and mask now so that these may load external resources
as well.
WebKitCSSSVGDocumentValue does not provide any further value
and will be removed in the next patch.
Refactoring, no new test cases.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):
- css/StyleResolver.h: Replace Map with a Set.
(WebCore::StyleResolver::State::pendingSVGDocuments): Use the Set from now on.
- loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):
- loader/cache/CachedSVGDocumentReference.h: Is responsible for
requesting the SVG document.
(WebCore::CachedSVGDocumentReference::create):
(WebCore::CachedSVGDocumentReference::loadRequested):
- platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::createCachedSVGDocumentReference):
- platform/graphics/filters/FilterOperation.h:
- 7:45 AM Changeset in webkit [161966] by
-
- 4 edits in trunk
[ATK] AXChildrenChanged notification handling is a performance black hole
https://bugs.webkit.org/show_bug.cgi?id=126970
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Remove code that is causing a huge performance problem when
loading big pages, just to be able to emit the children-changed:add
signal at the exact time a child is added.
This removal does not imply that the signal won't be ever emitted,
just that it will be emitted a bit later (when the new child is
asynchronously added to the tree), which should be good enough
anyway for Accessible Technologies, without impacting perfformance
in such a negative way.
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Removed
extremely expensive referring loop when AXChildrenChanged is received.
LayoutTests:
Because of the removal of the referring test when
AXChildrenChanged is received, the children-changed:add signal is
now emitted later, so we need to reorder the expectations.
- accessibility/children-changed-sends-notification-expected.txt: Updated.
- 7:41 AM Changeset in webkit [161965] by
-
- 3 edits2 adds in trunk
Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-crossfade-image.html
- platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.
LayoutTests: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied.
https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-crossfade-image-expected.html: Added.
- css3/compositing/background-blend-mode-crossfade-image.html: Added.
- 7:38 AM Changeset in webkit [161964] by
-
- 5 edits2 adds in trunk
Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
Test: css3/compositing/background-blend-mode-data-uri-svg-image.html
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
- svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
- svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.
LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
https://bugs.webkit.org/show_bug.cgi?id=118894
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.
- css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Added.
- css3/compositing/background-blend-mode-data-uri-svg-image.html: Added.
- 7:35 AM Changeset in webkit [161963] by
-
- 2 edits in trunk/Source/WebCore
Remove accidentally added PLATFORM(QT) from Source/WebCore/editing/EditorCommand.cpp after r161638
https://bugs.webkit.org/show_bug.cgi?id=126980
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Andreas Kling.
- editing/EditorCommand.cpp:
(WebCore::createCommandMap):
- 7:20 AM Changeset in webkit [161962] by
-
- 3 edits in trunk/Source/JavaScriptCore
[EFL] FTL buildfix, add missing includes
https://bugs.webkit.org/show_bug.cgi?id=126641
Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Csaba Osztrogonác.
- ftl/FTLOSREntry.cpp:
- ftl/FTLOSRExitCompiler.cpp:
- 7:13 AM Changeset in webkit [161961] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSSRegions] Test dynamic change of position for fixed element in named flow
https://bugs.webkit.org/show_bug.cgi?id=126807
Reviewed by Dirk Schulze.
- fast/regions/fixed-in-named-flow-position-changed-expected.html: Added.
- fast/regions/fixed-in-named-flow-position-changed.html: Added.
- 6:51 AM Changeset in webkit [161960] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index
https://bugs.webkit.org/show_bug.cgi?id=126978
Reviewed by Antti Koivisto.
Return the list of fixed positioned layers sorted by z-index from
FlowThreadController::collectFixedPositionedLayers instead of manually sort it
every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows).
Refactoring covered by existing regions tests.
- rendering/FlowThreadController.cpp:
(WebCore::compareZIndex):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
- 6:20 AM Changeset in webkit [161959] by
-
- 2 edits9 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Added missing baselines for some regions tests.
- platform/gtk/TestExpectations: Unskip tests as new baselines have been added.
- platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
- platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
- platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
- platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
- platform/gtk/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
- platform/gtk/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
- platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
- 5:26 AM Changeset in webkit [161958] by
-
- 2 edits in trunk/Source/WebCore
Pack ResourceLoaderOptions harder.
<https://webkit.org/b/126972>
Make all ResourceLoaderOptions members bitfields to reduce padding,
shrinking it from 28 to 4 bytes.
Reviewed by Antti Koivisto.
- loader/ResourceLoaderOptions.h:
- 5:14 AM Changeset in webkit [161957] by
-
- 1 edit5 adds in trunk/LayoutTests
Unreviewed GTK gardening.
Added missing baselines for some regions tests.
- platform/gtk/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
- platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
- platform/gtk/fast/regions/iframe-html-collected-expected.txt: Added.
- 3:51 AM Changeset in webkit [161956] by
-
- 2 edits2 adds in trunk/Tools
[GTK] Parse Valgrind xml leak files
https://bugs.webkit.org/show_bug.cgi?id=119446
Reviewed by Alejandro G. Castro.
Parse the xml files generated by Valgrind to yield useful
information about the memory leaks.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init):
(GtkPort.setup_test_run): Clear the previous output files before new
run.
(GtkPort.print_leaks_summary):
- Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
Parse the xml files generated by Valgrind and summarise leaks
into an easily understandable list.
(get_text_of):
(get_CDATA_of):
(gather_frames):
(ValgrindError):
(ValgrindError.init):
(ValgrindError.str):
(ValgrindError.unique_string):
(ValgrindError.error_hash):
(ValgrindError.hash):
(ValgrindError.eq):
(LeakDetectorValgrind):
(LeakDetectorValgrind.init):
(LeakDetectorValgrind._parse_leaks_output):
(LeakDetectorValgrind.leaks_files_in_results_directory):
(LeakDetectorValgrind.clean_leaks_files_from_results_directory):
(LeakDetectorValgrind.parse_and_print_leaks_detail):
- Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
(make_mock_valgrind_output):
(make_mock_incomplete_valgrind_output):
(make_mock_valgrind_results):
(make_mock_valgrind_results_incomplete):
(make_mock_valgrind_results_empty):
(make_mock_valgrind_results_misformatted):
(mock_run_cppfilt_command):
(LeakDetectorValgrindTest):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
- 2:39 AM Changeset in webkit [161955] by
-
- 2 edits in trunk/Source/WebCore
Pack ResourceError harder.
<https://webkit.org/b/126969>
Re-arrange the members of ResourceError to reduce padding,
shrinking it by 8 bytes.
Reviewed by Antti Koivisto.
- platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::ResourceErrorBase):
- 2:35 AM Changeset in webkit [161954] by
-
- 4 edits in trunk/Source/WebCore
Pack RenderLayer harder.
<https://webkit.org/b/126967>
Re-arrange the members of ScrollableArea a bit so that RenderLayer
can combine its bitfields with the ones in ScrollableArea.
This makes RenderLayer fit into a snugger size class, saving 32 bytes
per layer.
296 kB progression on Membuster3.
Reviewed by Antti Koivisto.
- platform/ScrollableArea.cpp:
- platform/ScrollableArea.h:
Put bitfield members at the end of ScrollableArea so inheriting
classes can synergize with the padding.
- rendering/RenderLayer.h:
Make m_blendMode a bitfield to avoid bloating the class.
- 12:35 AM Changeset in webkit [161953] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: RemoteInspector::updateDebuggable may miss a push
https://bugs.webkit.org/show_bug.cgi?id=126965
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::updateDebuggable):
Always push an update. If a debuggable went from allowed to
not allowed, we would have missed pushing an update.
