Context Navigation

← Previous Period
Next Period →

Timeline

Feb 4, 2014:

11:11 PM Changeset in webkit [163431] by rniwa@webkit.org

2 edits
4 copies in trunk

PerformanceTests: Undelete the "build" directory erroneously removed in r163427.

DoYouEvenBench/resources/todomvc/labs/architecture-examples/react/bower_components/director/build:

LayoutTests: Undelete the "build" directories erroneously removed in r163427.

webgl/1.0.2/conformance/ogles/GL/build:
webgl/1.0.2/resources/webgl_test_files/conformance/ogles/GL/build:
webgl/resources/webgl_test_files/conformance/ogles/GL/build:

11:00 PM Changeset in webkit [163430] by rniwa@webkit.org

2 edits in trunk/PerformanceTests

Revert the change made in r162216 as it broke the benchmark on shipping Safari.

DoYouEvenBench/resources/benchmark-runner.js:

9:36 PM Changeset in webkit [163429] by rniwa@webkit.org

18 edits
5 adds
2 deletes in trunk/PerformanceTests

DoYouEvenBench: Update Ember.js test case
https://bugs.webkit.org/show_bug.cgi?id=128227

Reviewed by Benjamin Poulain.

Updated the Ember.js TodoMVC implementation.

DoYouEvenBench/resources/tests.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower.json:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/ember-data/ember-data.js: Added.
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/index.html:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/app.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/helpers/pluralize.js: Added.
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Removed.
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/models/store.js: Removed.
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/models/todo.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/router.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/js/views/todos_view.js: Added.
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/readme.md:
DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/test.html:

9:32 PM Changeset in webkit [163428] by mark.lam@apple.com

5 edits in trunk/Source

The stack limit computation does not work for Windows.
<https://webkit.org/b/128226>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

llint/LowLevelInterpreter.cpp:

(JSC::CLoopRegister::CLoopRegister):
(JSC::CLoop::execute):

Suppressed some compiler warnings for the C loop build.
runtime/VM.cpp:

(JSC::VM::updateStackLimitWithReservedZoneSize):

Use the new StackBounds::recursionLimit() to compute the stack limit the right way.

Source/WTF:

The current stack limit computation assumes that the stack is allocated
in high memory. On Windows, the stack seems to be allocated very near
address 0, and is smaller in size than our Options::maxPerThreadStackUsage().
This combination triggers a bug where StackBounds::recursionLimit()
underflows and computes a limit address that is ridiculously high in memory.
The net effect is that the Windows port thinks its out of stack space all
the time.

We now check for potential underflows in StackBounds and return an
appropriate limit address.

wtf/StackBounds.h:

(WTF::StackBounds::recursionLimit):

8:59 PM Changeset in webkit [163427] by akling@apple.com

79 edits
14 deletes in trunk

Remove <iframe seamless> support.
<https://webkit.org/b/128213>

Rubber-stamped by Antti Koivisto.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rubber-stamped by Antti Koivisto.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Seamless iframes were behind a runtime flag that we never enabled,
and the only other engine that implemented them (Blink) recently
removed them. Since the feature is very invasive, let's take it
out for now.

Rubber-stamped by Antti Koivisto.

Configurations/FeatureDefines.xcconfig:
accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::parentObjectIfExists):
(WebCore::AccessibilityRenderObject::parentObject):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

bindings/generic/RuntimeEnabledFeatures.h:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::populatePseudoTypeByNameMap):
(WebCore::CSSSelector::extractPseudoType):

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

css/html.css:

(iframe):

dom/Document.cpp:

(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::implicitOpen):
(WebCore::Document::initSecurityContext):

dom/Document.h:
dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

dom/SecurityContext.cpp:

(WebCore::SecurityContext::SecurityContext):

dom/SecurityContext.h:
html/HTMLAttributeNames.in:
html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::HTMLIFrameElement):
(WebCore::HTMLIFrameElement::isPresentationAttribute):
(WebCore::HTMLIFrameElement::parseAttribute):

html/HTMLIFrameElement.h:
html/HTMLIFrameElement.idl:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::findFrameForNavigation):

page/FrameView.cpp:

(WebCore::FrameView::calculateScrollbarModesForLayout):
(WebCore::FrameView::isInChildFrameWithFrameFlattening):

page/Location.cpp:

(WebCore::Location::setLocation):

rendering/RenderBox.h:

(WebCore::RenderBox::stretchesToViewport):

rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::shouldComputeSizeAsReplaced):
(WebCore::RenderIFrame::isInlineBlockOrInlineTable):
(WebCore::RenderIFrame::flattenFrame):
(WebCore::RenderIFrame::layout):

rendering/RenderIFrame.h:
rendering/RenderView.cpp:

(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::layout):

rendering/RenderView.h:
style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

style/StyleResolveTree.cpp:

(WebCore::Style::resolveTree):

Source/WebKit/efl:

Rubber-stamped by Antti Koivisto.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:
ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

Rubber-stamped by Antti Koivisto.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit/mac:

Rubber-stamped by Antti Koivisto.

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:
WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

Rubber-stamped by Antti Koivisto.

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

Rubber-stamped by Antti Koivisto.

Configurations/FeatureDefines.xcconfig:
WebProcess/InjectedBundle/API/c/WKBundle.cpp:
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:
WebProcess/InjectedBundle/InjectedBundle.h:

Source/WTF:

Rubber-stamped by Antti Koivisto.

wtf/FeatureDefines.h:

Tools:

Rubber-stamped by Antti Koivisto.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

Scripts/webkitperl/FeatureList.pm:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitLibraries:

Rubber-stamped by Antti Koivisto.

win/tools/vsprops/FeatureDefines.props:

LayoutTests:

Rubber-stamped by Antti Koivisto.

fast/frames/seamless/resources/css-cascade-child.html: Removed.
fast/frames/seamless/resources/done.html: Removed.
fast/frames/seamless/resources/nested-seamless.html: Removed.
fast/frames/seamless/resources/percent-square.html: Removed.
fast/frames/seamless/resources/quirks-square.html: Removed.
fast/frames/seamless/resources/span.html: Removed.
fast/frames/seamless/resources/square.html: Removed.
fast/frames/seamless/resources/two-inline-blocks.html: Removed.
fast/frames/seamless/seamless-basic-expected.txt: Removed.
fast/frames/seamless/seamless-basic.html: Removed.
fast/frames/seamless/seamless-body-margin-expected.txt: Removed.
fast/frames/seamless/seamless-body-margin.html: Removed.
fast/frames/seamless/seamless-border-padding-expected.txt: Removed.
fast/frames/seamless/seamless-border-padding.html: Removed.
fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt: Removed.
fast/frames/seamless/seamless-contenteditable-not-inherited.html: Removed.
fast/frames/seamless/seamless-css-cascade-expected.txt: Removed.
fast/frames/seamless/seamless-css-cascade.html: Removed.
fast/frames/seamless/seamless-custom-font-pruning-crash-expected.txt: Removed.
fast/frames/seamless/seamless-custom-font-pruning-crash.html: Removed.
fast/frames/seamless/seamless-designMode-expected.txt: Removed.
fast/frames/seamless/seamless-designMode.html: Removed.
fast/frames/seamless/seamless-document-write-expected.txt: Removed.
fast/frames/seamless/seamless-document-write.html: Removed.
fast/frames/seamless/seamless-float-expected.txt: Removed.
fast/frames/seamless/seamless-float.html: Removed.
fast/frames/seamless/seamless-form-get-expected.txt: Removed.
fast/frames/seamless/seamless-form-get-named-expected.txt: Removed.
fast/frames/seamless/seamless-form-get-named.html: Removed.
fast/frames/seamless/seamless-form-get-override-expected.txt: Removed.
fast/frames/seamless/seamless-form-get-override.html: Removed.
fast/frames/seamless/seamless-form-get.html: Removed.
fast/frames/seamless/seamless-form-post-expected.txt: Removed.
fast/frames/seamless/seamless-form-post-named-expected.txt: Removed.
fast/frames/seamless/seamless-form-post-named.html: Removed.
fast/frames/seamless/seamless-form-post-override-expected.txt: Removed.
fast/frames/seamless/seamless-form-post-override.html: Removed.
fast/frames/seamless/seamless-form-post.html: Removed.
fast/frames/seamless/seamless-hyperlink-expected.txt: Removed.
fast/frames/seamless/seamless-hyperlink-named-expected.txt: Removed.
fast/frames/seamless/seamless-hyperlink-named.html: Removed.
fast/frames/seamless/seamless-hyperlink-override-expected.txt: Removed.
fast/frames/seamless/seamless-hyperlink-override.html: Removed.
fast/frames/seamless/seamless-hyperlink.html: Removed.
fast/frames/seamless/seamless-inherited-document-style-expected.txt: Removed.
fast/frames/seamless/seamless-inherited-document-style.html: Removed.
fast/frames/seamless/seamless-inherited-origin-expected.txt: Removed.
fast/frames/seamless/seamless-inherited-origin.html: Removed.
fast/frames/seamless/seamless-inline-expected.txt: Removed.
fast/frames/seamless/seamless-inline.html: Removed.
fast/frames/seamless/seamless-min-max-expected.txt: Removed.
fast/frames/seamless/seamless-min-max.html: Removed.
fast/frames/seamless/seamless-nested-crash-expected.txt: Removed.
fast/frames/seamless/seamless-nested-crash.html: Removed.
fast/frames/seamless/seamless-nested-expected.txt: Removed.
fast/frames/seamless/seamless-nested.html: Removed.
fast/frames/seamless/seamless-percent-height-expected.txt: Removed.
fast/frames/seamless/seamless-percent-height.html: Removed.
fast/frames/seamless/seamless-quirks-expected.txt: Removed.
fast/frames/seamless/seamless-quirks.html: Removed.
fast/frames/seamless/seamless-sandbox-flag-expected.txt: Removed.
fast/frames/seamless/seamless-sandbox-flag.html: Removed.
fast/frames/seamless/seamless-sandbox-srcdoc-expected.txt: Removed.
fast/frames/seamless/seamless-sandbox-srcdoc.html: Removed.
fast/frames/seamless/seamless-srcdoc-expected.txt: Removed.
fast/frames/seamless/seamless-srcdoc.html: Removed.
fast/frames/seamless/seamless-window-location-expected.txt: Removed.
fast/frames/seamless/seamless-window-location-href-expected.txt: Removed.
fast/frames/seamless/seamless-window-location-href.html: Removed.
fast/frames/seamless/seamless-window-location-replace-expected.txt: Removed.
fast/frames/seamless/seamless-window-location-replace.html: Removed.
fast/frames/seamless/seamless-window-location-sandbox-expected.txt: Removed.
fast/frames/seamless/seamless-window-location-sandbox.html: Removed.
fast/frames/seamless/seamless-window-location.html: Removed.
fast/frames/seamless/seamless-window-open-expected.txt: Removed.
fast/frames/seamless/seamless-window-open-override-expected.txt: Removed.
fast/frames/seamless/seamless-window-open-override.html: Removed.
fast/frames/seamless/seamless-window-open.html: Removed.
fast/multicol/resources/seamless.html: Removed.
fast/multicol/seamless-flowed-through-columns-expected.html: Removed.
fast/multicol/seamless-flowed-through-columns.html: Removed.
fast/regions/resources/seamless.html: Removed.
fast/regions/seamless-iframe-flowed-into-regions-expected.html: Removed.
fast/regions/seamless-iframe-flowed-into-regions.html: Removed.
http/tests/security/seamless/resources/square.html: Removed.
http/tests/security/seamless/seamless-cross-origin-expected.txt: Removed.
http/tests/security/seamless/seamless-cross-origin.html: Removed.
http/tests/security/seamless/seamless-sandbox-srcdoc-expected.txt: Removed.
http/tests/security/seamless/seamless-sandbox-srcdoc.html: Removed.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:

8:22 PM Changeset in webkit [163426] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG::operationTypeOf() needs to set the VM::topCallFrame.
<https://webkit.org/b/128228>

Reviewed by Mark Hahnenberg.

dfg/DFGOperations.cpp:
operationTypeOf() can end up calling into WebCore which may in turn call back to JSC, and need a valid VM::topCallFrame. So, we need to set the value of VM::topCallFrame at the top of operationTypeOf().

8:22 PM Changeset in webkit [163425] by timothy_horton@apple.com

6 edits
4 adds
2 deletes in trunk/Source

[iOS][wk2] Make development builds of WebKit work on device
https://bugs.webkit.org/show_bug.cgi?id=128230

Reviewed by Anders Carlsson.

Configurations/NetworkService.Development.xcconfig:
Configurations/WebContentService.Development.xcconfig:
NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist.
NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist: Copied from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist.
WebKit2.xcodeproj/project.pbxproj:
WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist: Renamed from Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist.
WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: Renamed from Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist.

The Development services should match the non-Development version's behavior
of having separate plists for OS X and iOS.

platform/RuntimeApplicationChecksIOS.mm:

(WebCore::applicationIsWebProcess):
Add WebContent.Development as an additional name for the WebContent process.

8:10 PM Changeset in webkit [163424] by zoltan@webkit.org

2 edits
4 adds in trunk/PerformanceTests

[CSS Shapes] Add initial performance test for shape-outside: content-box
https://bugs.webkit.org/show_bug.cgi?id=128190

Reviewed by Ryosuke Niwa.

I've introduced Shapes subdirectory in Layout, every CSS Shapes related performance tests should
go there in the future. The initial performance tests uses 'shape-outside: content-box' in order
to tests the code paths of the Shapes implementation. I also introduced shapes.js, which allows us
to easily add new, simple performance tests for shape-outside.

The entire progress is tracked under #128188 meta bug.

Layout/Shapes/ShapeOutsideContentBox.html: Added.
Layout/Shapes/resources/shapes.css: Added.
Layout/Shapes/resources/shapes.js: Added.
Skipped: We skip running the tests by default for now.

7:20 PM Changeset in webkit [163423] by fpizlo@apple.com

2 edits in trunk/Tools

Fix build when the script is called from Xcode.

Scripts/copy-webkitlibraries-to-product-directory:

6:56 PM Changeset in webkit [163422] by Alan Bujtas

2 edits in trunk/LayoutTests

And one more test to tag with ImageOnlyFailure.

TestExpectations:

5:54 PM Changeset in webkit [163421] by Alan Bujtas

2 edits in trunk/LayoutTests

Some tests introduced by 163415 need ImageOnlyFailure tag.

Unreviewed gardering.

TestExpectations:

5:35 PM Changeset in webkit [163420] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix !ENABLE(JIT) builds after r163418

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::reoptimizationRetryCounter): Return 0 if there's no way for us to reoptimize.

5:28 PM Changeset in webkit [163419] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Reduce boilerplate in BlockAllocator.h
https://bugs.webkit.org/show_bug.cgi?id=128222

Reviewed by Filip Pizlo.

There are a lot of template specializations for the various types of HeapBlocks
in BlockAllocator.h. We could reduce the spew by using a macro.

heap/BlockAllocator.h:

5:03 PM Changeset in webkit [163418] by fpizlo@apple.com

13 edits
3 adds
3 deletes in trunk

DFG PutByVal on typed arrays should detect OutOfBounds sooner
https://bugs.webkit.org/show_bug.cgi?id=128162

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Just wire the m_outOfBounds flag in ArrayProfile into the OutOfBounds speculation in
DFG::ArrayMode for typed arrays.

Also make it possible to have tests for convergence.

Also turn one of the LayoutTests/js/dfg- tests into a stress test because it
was relying on a specific number of recompiles. Stress tests instead take
the approach of just running for a while. That's more robust.

bytecode/CodeBlock.h:
dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::fromObserved):
(JSC::DFG::ArrayMode::refine):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::withSpeculationFromProfile):
(JSC::DFG::ArrayMode::withProfile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

jsc.cpp:

(GlobalObject::finishCreation):
(functionReoptimizationRetryCount):

runtime/TestRunnerUtils.cpp:

(JSC::getExecutableForFunction):
(JSC::getSomeBaselineCodeBlockForFunction):
(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):

runtime/TestRunnerUtils.h:
tests/stress/float32-repeat-out-of-bounds.js: Added.

(foo):

tests/stress/int8-repeat-out-of-bounds.js: Added.

(foo):

tests/stress/string-out-of-bounds-negative-proto-value.js: Added.

(foo):

Tools:

Reviewed by Mark Hahnenberg.

Add a defautNoEagerRun, which is intended to be used for convergence tests.

Scripts/run-jsc-stress-tests:

LayoutTests:

Reviewed by Mark Hahnenberg.

dfg-string-out-of-blahblah was moved to JSC/tests/stress.

dfg-convert-this-dom-window was using dfgShouldBe() incorrectly and this got revealed
by my TestRunnerUtils refactoring.

js/dfg-string-out-of-bounds-negative-proto-value-expected.txt: Removed.
js/dfg-string-out-of-bounds-negative-proto-value.html: Removed.
js/script-tests/dfg-convert-this-dom-window.js:
js/script-tests/dfg-string-out-of-bounds-negative-proto-value.js: Removed.

4:26 PM Changeset in webkit [163417] by beidson@apple.com

12 edits in trunk

IDB: indexeddb/mozilla/add-twice-failure.html fails
<rdar://problem/15982569> and https://bugs.webkit.org/show_bug.cgi?id=128208

Reviewed by Tim Horton.

Source/WebCore:

Covered specifically by indexeddb/mozilla/add-twice-failure.html and a handful of others.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onError): Improve logging.

Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::abort): Improve logging.

Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::PutOperation::perform): Don’t abort the transaction when an error occurred.

WebCore.exp.in:

Source/WebKit2:

Note that besides making indexeddb/mozilla/add-twice-failure.html pass this also makes some other tests
pass and also improves the failure modes of others.

A full accounting of which tests pass is coming soon.

DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::putRecordInBackingStore): After checking for existence of the key and before

adding the record, remove any previous record. (Defined by the spec, found exploring this test).

DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore): Implement this.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord): Add a form to be used as mentioned above in

UniqueIDBDatabase::putRecordInBackingStore.

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore): CAST the key argument properly.
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore): Ditto.

DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:

LayoutTests:

platform/mac-wk2/TestExpectations: Reenable this test for WK2

4:23 PM Changeset in webkit [163416] by andersca@apple.com

3 edits in trunk/Source/WTF

Store StringImpl substring backpointers as tail data
https://bugs.webkit.org/show_bug.cgi?id=128220

Reviewed by Geoffrey Garen.

This lets us get rid of m_substringBuffer from the union.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::getData16SlowCase):

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createSubstringSharingImpl8):
(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::cost):
(WTF::StringImpl::costDuringGC):
(WTF::StringImpl::substringBuffer):

4:09 PM Changeset in webkit [163415] by commit-queue@webkit.org

32 edits
1 copy
32 adds
6 deletes in trunk

Use srcset's pixel density to determine intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=123832

Patch by Yoav Weiss <yoav@yoav.ws> on 2014-02-04
Reviewed by Dean Jackson.

The patch is a port of a similar Blink patch: https://codereview.chromium.org/25105004
According to the spec "When an img element has a current pixel density that is not 1.0,
the element's image data must be treated as if its resolution, in device pixels per CSS pixels,
was the current pixel density."

Source/WebCore:

I've added that support using the following changes:

bestFitSourceForImageAttributes now returns the image candidate to HTMLImageElement.
HTMLImageElement passes the devicePixelRatio data to RenderImage, which stores it.
Bitmap images are scaled using the devicePixelRatio at RenderImageResource's intrinsicSize() and imageSize().
SVG images are scaled using the devicePixelRatio at RenderReplaced::computeAspectRatioInformationForRenderBox.
Canvas support added at CanvasRenderingContext2D::size.

Tests: fast/hidpi/image-srcset-intrinsic-size.html

fast/hidpi/image-srcset-png-canvas.html
fast/hidpi/image-srcset-png.html
fast/hidpi/image-srcset-relative-svg-canvas-2x.html
fast/hidpi/image-srcset-relative-svg.html
fast/hidpi/image-srcset-space-left-nomodifier.html
fast/hidpi/image-srcset-svg-canvas-2x.html
fast/hidpi/image-srcset-svg-canvas.html
fast/hidpi/image-srcset-svg.html
fast/hidpi/image-srcset-svg2.html

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::createRenderer):

html/HTMLImageElement.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::size):
(WebCore::CanvasRenderingContext2D::drawImage):

html/parser/HTMLParserIdioms.cpp:

(WebCore::compareByScaleFactor):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

html/parser/HTMLParserIdioms.h:

(WebCore::ImageWithScale::ImageWithScale):
(WebCore::ImageWithScale::imageURL):
(WebCore::ImageWithScale::scaleFactor):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):

rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):

rendering/RenderImage.h:

(WebCore::RenderImage::setImageDevicePixelRatio):
(WebCore::RenderImage::imageDevicePixelRatio):

rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::imageSize):
(WebCore::RenderImageResource::intrinsicSize):
(WebCore::RenderImageResource::getImageSize):

rendering/RenderImageResource.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeAspectRatioInformationForRenderBox):

LayoutTests:

Layout test changes include modifications of existing tests to accomodate the new image dimensions, as well as new tests for this
specific functionality.

fast/hidpi/image-srcset-change-dynamically-from-js-2x-expected.txt:
fast/hidpi/image-srcset-change-dynamically-from-js-2x.html:
fast/hidpi/image-srcset-data-escaped-srcset-expected.txt:
fast/hidpi/image-srcset-data-escaped-srcset.html:
fast/hidpi/image-srcset-data-src.html:
fast/hidpi/image-srcset-data-srcset.html:
fast/hidpi/image-srcset-fraction.html:
fast/hidpi/image-srcset-intrinsic-size-expected.txt: Added.
fast/hidpi/image-srcset-intrinsic-size.html: Added.
fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt:
fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
fast/hidpi/image-srcset-invalid-inputs.html:
fast/hidpi/image-srcset-invalid-inputs-expected.txt: Added.
fast/hidpi/image-srcset-only-src-attribute-expected.txt: Added.
fast/hidpi/image-srcset-only-src-attribute.html:
fast/hidpi/image-srcset-png-canvas-expected.html: Added.
fast/hidpi/image-srcset-png-canvas.html: Added.
fast/hidpi/image-srcset-png-expected.html: Added.
fast/hidpi/image-srcset-png.html: Added.
fast/hidpi/image-srcset-relative-svg-expected.html: Added.
fast/hidpi/image-srcset-relative-svg.html: Added.
fast/hidpi/image-srcset-remove-dynamically-from-js.html:
fast/hidpi/image-srcset-simple-2x-expected.txt:
fast/hidpi/image-srcset-simple-2x.html:
fast/hidpi/image-srcset-space-left-nomodifier-expected.txt: Added.
fast/hidpi/image-srcset-space-left-nomodifier.html: Copied from LayoutTests/fast/hidpi/image-srcset-data-srcset.html.
fast/hidpi/image-srcset-svg-expected.html: Added.
fast/hidpi/image-srcset-svg.html: Added.
fast/hidpi/image-srcset-svg2-expected.html: Added.
fast/hidpi/image-srcset-svg2.html: Added.
fast/hidpi/resources/green-400-px-square.png: Added.
fast/hidpi/resources/relativesrcset.svg: Added.
fast/hidpi/resources/srcset-helper.js:

(runTest):

fast/hidpi/resources/srcset.png: Added.
fast/hidpi/resources/srcset.svg: Added.
fast/hidpi/resources/srcset_100px.svg: Added.
fast/hidpi/resources/svg_canvas_helper.js: Added.

(drawCanvas):

fast/hidpi/resources/svg_tests.css: Added.

(.test):
(.test img, .test canvas):
(.test .stats):
(.expected, .actual):

platform/mac/fast/hidpi/image-srcset-only-src-attribute-expected.png: Removed.
platform/mac/fast/hidpi/image-srcset-only-src-attribute-expected.txt: Removed.

The following tests were added, but skipped, since they reveal an unrelated SVG on canvas rendering issue:

fast/hidpi/image-srcset-svg-canvas-2x-expected.html: Added.
fast/hidpi/image-srcset-svg-canvas-2x.html: Added.
fast/hidpi/image-srcset-svg-canvas-expected.html: Added.
fast/hidpi/image-srcset-svg-canvas.html: Added.
fast/hidpi/image-srcset-relative-svg-canvas-2x-expected.html: Added.
fast/hidpi/image-srcset-relative-svg-canvas-2x.html: Added.
fast/hidpi/image-srcset-relative-svg-canvas-expected.html: Added.
fast/hidpi/image-srcset-relative-svg-canvas.html: Added.

4:08 PM Changeset in webkit [163414] by mhahnenberg@apple.com

9 edits
2 adds
1 delete in trunk/Source/JavaScriptCore

Refactor MarkStackArray to allow more than JSCells to be stored
https://bugs.webkit.org/show_bug.cgi?id=128203

Reviewed by Geoffrey Garen.

This patch refactors MarkStackArray into a separate template class named GCSegmentedArray.
This class allows subclassing to add functionality that only MarkStackArray wants.
Since it uses the JSC BlockAllocator instead of FastMalloc, this class can be used during
conservative stack scanning, which disallows using FastMalloc.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/BlockAllocator.h:
heap/GCSegmentedArray.h: Added.

(JSC::GCArraySegment::GCArraySegment):
(JSC::GCArraySegment::data):

heap/GCSegmentedArrayInlines.h: Added.

(JSC::GCSegmentedArray<T>::GCSegmentedArray):
(JSC::GCSegmentedArray<T>::~GCSegmentedArray):
(JSC::GCSegmentedArray<T>::clear):
(JSC::GCSegmentedArray<T>::expand):
(JSC::GCSegmentedArray<T>::refill):
(JSC::GCSegmentedArray<T>::fillVector):
(JSC::GCArraySegment<T>::create):
(JSC::GCSegmentedArray<T>::postIncTop):
(JSC::GCSegmentedArray<T>::preDecTop):
(JSC::GCSegmentedArray<T>::setTopForFullSegment):
(JSC::GCSegmentedArray<T>::setTopForEmptySegment):
(JSC::GCSegmentedArray<T>::top):
(JSC::GCSegmentedArray<T>::validatePrevious):
(JSC::GCSegmentedArray<T>::append):
(JSC::GCSegmentedArray<T>::canRemoveLast):
(JSC::GCSegmentedArray<T>::removeLast):
(JSC::GCSegmentedArray<T>::isEmpty):
(JSC::GCSegmentedArray<T>::size):

heap/MarkStack.cpp:

(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackArray::~MarkStackArray):
(JSC::MarkStackArray::donateSomeCellsTo):
(JSC::MarkStackArray::stealSomeCellsFrom):

heap/MarkStack.h:
heap/MarkStackInlines.h:

3:57 PM Changeset in webkit [163413] by ggaren@apple.com

41 edits in trunk

Rolled out <http://trac.webkit.org/changeset/163280>:

Source/WebCore:

Push DOM attributes into the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=127969

It caused performance regressions, and broken websites on iOS.

Reviewed by Geoffrey Garen.

bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::nameGetter):
(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::putDelegate):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(InstanceOverridesGetOwnPropertySlot):
(PrototypeOverridesGetOwnPropertySlot):
(GenerateAttributesHashTable):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectConstructor):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::jsTestCustomNamedGetterConstructor):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::getOwnPropertySlot):
(WebCore::jsTestEventConstructorConstructor):

bindings/scripts/test/JS/JSTestEventConstructor.h:
bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetConstructor):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::jsTestExceptionConstructor):

bindings/scripts/test/JS/JSTestException.h:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::getOwnPropertySlot):
(WebCore::jsTestGenerateIsReachableConstructor):

bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::jsTestInterfaceConstructor):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):
(WebCore::jsTestMediaQueryListListenerConstructor):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::getOwnPropertySlot):
(WebCore::jsTestNamedConstructorConstructor):

bindings/scripts/test/JS/JSTestNamedConstructor.h:
bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNode::getOwnPropertySlot):
(WebCore::jsTestNodeConstructor):

bindings/scripts/test/JS/JSTestNode.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjConstructor):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::getOwnPropertySlot):
(WebCore::jsTestOverloadedConstructorsConstructor):

bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsPrototype::getOwnPropertySlot):
(WebCore::jsTestTypedefsConstructor):

bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::getOwnPropertySlot):
(WebCore::jsattributeConstructor):

bindings/scripts/test/JS/JSattribute.h:
bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::getOwnPropertySlot):
(WebCore::jsreadonlyConstructor):

bindings/scripts/test/JS/JSreadonly.h:

LayoutTests:

Push DOM attributes into the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=127969

It caused performance regressions, and broken websites on iOS.

Reviewed by Geoffrey Garen.

fast/dom/Geolocation/enabled-expected.txt:
fast/dom/Geolocation/script-tests/enabled.js:
fast/dom/wrapper-classes-expected.txt:
http/tests/security/cross-frame-access-enumeration-expected.txt:
js/dom/constructor-attributes-expected.txt:
js/dom/delete-syntax-expected.txt:
js/dom/dom-attributes-on-mismatch-type-expected.txt:
js/dom/dom-attributes-on-mismatch-type.html:
js/dom/dom-static-property-for-in-iteration-expected.txt:
js/dom/script-tests/constructor-attributes.js:
js/dom/script-tests/delete-syntax.js:

3:55 PM Changeset in webkit [163412] by mitz@apple.com

7 edits in trunk/Source/WebKit2

[Cocoa] Expose more WKWebProcessPlugInNodeHandle properties
https://bugs.webkit.org/show_bug.cgi?id=128219

Reviewed by Anders Carlsson.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h: Declared new

properties.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(-[WKWebProcessPlugInNodeHandle elementBounds]): Added.
(-[WKWebProcessPlugInNodeHandle HTMLInputElementIsAutoFilled]): Added.
(-[WKWebProcessPlugInNodeHandle setHTMLInputElementIsAutoFilled:]): Added.
(-[WKWebProcessPlugInNodeHandle HTMLInputELementIsUserEdited]): Added.
(-[WKWebProcessPlugInNodeHandle HTMLTextAreaELementIsUserEdited]): Added.
(-[WKWebProcessPlugInNodeHandle HTMLTableCellElementCellAbove]): Added.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandleInternal.h: Rolled

Internal category into the class extension.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.h: Declared

-clearWrappers.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:

(-[WKWebProcessPlugInScriptWorld clearWrappers]): Added. Calls through to clearWrappers().

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorldInternal.h: Rolled

Internal category into the class extension.

3:50 PM Changeset in webkit [163411] by fpizlo@apple.com

2 edits in trunk/Tools

export-llvm-build should work with git checkouts
https://bugs.webkit.org/show_bug.cgi?id=128217

Reviewed by Mark Hahnenberg.

If svn export fails, just do ditto.

Scripts/export-llvm-build:

3:40 PM Changeset in webkit [163410] by andersca@apple.com

9 edits in trunk/Source

Rename the substring sharing StringImpl::create variants to better indicate what they do
https://bugs.webkit.org/show_bug.cgi?id=128214

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

runtime/JSString.h:

(JSC::jsSingleCharacterSubstring):
(JSC::jsSubstring8):
(JSC::jsSubstring):

runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

runtime/StringPrototype.cpp:

(JSC::jsSpliceSubstrings):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::replaceUsingStringSearch):

Source/WTF:

wtf/text/AtomicString.cpp:

(WTF::SubstringTranslator::translate):

wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reifyString):
(WTF::StringBuilder::resize):

wtf/text/StringImpl.h:

(WTF::StringImpl::createSubstringSharingImpl8):
(WTF::StringImpl::createSubstringSharingImpl):

wtf/text/WTFString.cpp:

(WTF::String::substringSharingImpl):

3:33 PM Changeset in webkit [163409] by ap@apple.com

2 edits in trunk/Source/WebKit2

webKitCookieStorageCopyRequestHeaderFieldsForURL builds an empty Cookie header when there are no cookies
https://bugs.webkit.org/show_bug.cgi?id=128201

Reviewed by Sam Weinig.

Shared/mac/CookieStorageShim.mm: (WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

Return null when NetworkProcess provided a null string, don't build a header dictionary
with an empty Cookie value.

3:33 PM Changeset in webkit [163408] by Alan Bujtas

4 edits in branches/safari-537.74-branch/LayoutTests

Fix src path for js-test-*.js

Unreviewed.

fast/css/pending-image-crash.xhtml:
js/array-splice-with-holes.html:
platform/mac/accessibility/text-marker-for-bounds.html:

3:31 PM Changeset in webkit [163407] by ap@apple.com

8 edits
2 adds in trunk/Source

WebCrypto HMAC verification uses a non-constant-time memcmp
https://bugs.webkit.org/show_bug.cgi?id=128198
<rdar://problem/15976961>

Reviewed by Oliver Hunt.

Source/WebCore:

crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::CryptoAlgorithmHMAC::platformVerify):

Use a constant time memcmp.

Source/WTF:

Added a "constant time" memcmp that doesn't depend on data. The name is somewhat
strange, as the function is of course O(length) and not constant time at all,
but apparently this is how everyone calls such functions.

GNUmakefile.list.am:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/CryptographicUtilities.cpp: Added. (WTF::constantTimeMemcmp):
wtf/CryptographicUtilities.h: Added.

3:24 PM Changeset in webkit [163406] by Simon Fraser

3 edits in trunk/Source/WebCore

Add WK2 event handling path for iOS, and make Mac and iOS code more similar
https://bugs.webkit.org/show_bug.cgi?id=128199

Reviewed by Sam Weinig.

EventHandlerIOS need some changes for WebKit2, where we have no native
widget. Merge those changes from EventHandlerMac.

Make a few drive-by changes to match EventHandlerMac behavior.

Clean up EventHandlerMac, removing trailing whitespace and fixing
the odd comment.

page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::EventHandler::passSubframeEventToSubframe):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::mouseDown):
(WebCore::EventHandler::mouseMoved):
(WebCore::frameHasPlatformWidget):
(WebCore::EventHandler::passMousePressEventToSubframe):
(WebCore::EventHandler::passMouseMoveEventToSubframe):
(WebCore::EventHandler::passMouseReleaseEventToSubframe):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWidgetMouseDownEventToWidget):
(WebCore::EventHandler::passMouseDownEventToWidget):
(WebCore::findViewInSubviews):
(WebCore::EventHandler::eventLoopHandleMouseUp):
(WebCore::EventHandler::passWheelEventToWidget):
(WebCore::EventHandler::mouseMoved):

3:21 PM Changeset in webkit [163405] by andersca@apple.com

3 edits
3 adds in trunk/Source/WebKit2

Add a WKNavigationAction object
https://bugs.webkit.org/show_bug.cgi?id=128212

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKNavigationAction.h: Added.

(NS_ENUM):

UIProcess/API/Cocoa/WKNavigationAction.mm: Added.
UIProcess/API/Cocoa/WKNavigationActionInternal.h: Added.
UIProcess/Cocoa/NavigationState.mm:

(WebKit::toWKNavigationType):
(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

WebKit2.xcodeproj/project.pbxproj:

2:41 PM Changeset in webkit [163404] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add back/forward related methods to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128209

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView canGoBack]):
(-[WKWebView canGoForward]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):

2:22 PM Changeset in webkit [163403] by mhahnenberg@apple.com

1 edit in trunk/Source/JavaScriptCore/ChangeLog

Remove conflict markers from ChangeLog

1:52 PM Changeset in webkit [163402] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

[OSX] Limit progress bar's dimensions to ushort
https://bugs.webkit.org/show_bug.cgi?id=128019

Wordaround a crash in Quartz until <rdar://problem/15855086> is fixed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-04
Reviewed by Sam Weinig.

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::progressBarRectForBounds):

1:50 PM Changeset in webkit [163401] by andersca@apple.com

9 edits in trunk/Source

Rename StringImpl::getCharacters to StringImpl::characters
https://bugs.webkit.org/show_bug.cgi?id=128205

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Update for WTF changes.

runtime/JSStringJoiner.cpp:

(JSC::joinStrings):

runtime/StringPrototype.cpp:

(JSC::splitStringByOneCharacterImpl):

Source/WebCore:

Update for WTF changes.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createTextRuns):

Source/WTF:

This lets us use StringImpl::getCharacters for the upconverting version.
Also, change StringImpl::characters<UChar>() to call characters16() instead of deprecatedCharacters()
and audit all call sites to make sure we weren't relying on upconversion anywhere.

wtf/text/AtomicString.cpp:

(WTF::findString):

wtf/text/StringImpl.cpp:

(WTF::StringImpl::simplifyMatchedCharactersToSpace):

wtf/text/StringImpl.h:

(WTF::StringImpl::characters<LChar>):
(WTF::StringImpl::characters<UChar>):

1:40 PM Changeset in webkit [163400] by enrica@apple.com

2 edits in trunk/Source/WebKit2

WK: Cannot select text inside clickable containers.
https://bugs.webkit.org/show_bug.cgi?id=128197
<rdar://problem/15970890>

Reviewed by Simon Fraser.

When retrieving position information, we first try to
find the node responding to click events because we want
to know whether we are on a link or an image to show
the appropriate action sheet.
We could still have a node responding to click events if
for example we have a DIV with a click handler but that
doesn't require any special handling and we still need to
perform regular hit testing.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

1:39 PM Changeset in webkit [163399] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix a mismatch of uint64_t and size_t on 32-bit platforms.

ftl/FTLDWARFDebugLineInfo.h:

1:32 PM Changeset in webkit [163398] by andersca@apple.com

6 edits in trunk/Source

Rename equalNonNull to equal and make it take const StringImpl& instead
https://bugs.webkit.org/show_bug.cgi?id=128206

Reviewed by Andreas Kling.

Source/WebCore:

html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):
(WebCore::threadSafeMatch):

Source/WTF:

wtf/text/StringHash.h:

(WTF::StringHash::equal):

wtf/text/StringImpl.cpp:

(WTF::stringImplContentEqual):
(WTF::equal):

wtf/text/StringImpl.h:

1:27 PM Changeset in webkit [163397] by mhahnenberg@apple.com

4 edits
2 adds in trunk/Source/JavaScriptCore

JSC needs to be able to parse DWARF debug_line info
https://bugs.webkit.org/show_bug.cgi?id=127394

Reviewed by Geoffrey Garen.

If we want to encode IR maps in the DWARF debug line info metadata generated by LLVM,
we'll need to know how to decode the .debug_line DWARF section. This patch implements
an interpreter for the .debug_line DWARF section in accordance with the version 3 spec
published at http://www.dwarfstd.org.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLDWARFDebugLineInfo.cpp: Added.

(JSC::FTL::DebugLineInterpreter::DebugLineInterpreter):
(JSC::FTL::read):
(JSC::FTL::DebugLineInterpreter::parseULEB128):
(JSC::FTL::DebugLineInterpreter::parseSLEB128):
(JSC::FTL::DebugLineInterpreter::run):
(JSC::FTL::DebugLineInterpreter::parsePrologue):
(JSC::FTL::DebugLineInterpreter::parseIncludeDirectories):
(JSC::FTL::DebugLineInterpreter::parseFileEntries):
(JSC::FTL::DebugLineInterpreter::parseFileEntry):
(JSC::FTL::DebugLineInterpreter::interpretStatementProgram):
(JSC::FTL::DebugLineInterpreter::interpretOpcode):
(JSC::FTL::DebugLineInterpreter::printLineInfo):
(JSC::FTL::DebugLineInterpreter::resetInterpreterState):

ftl/FTLDWARFDebugLineInfo.h: Added.

(JSC::FTL::DebugLineInterpreter::Prologue::Prologue):

ftl/FTLValueRange.cpp: Random build fix for !ENABLE(FTL_JIT).

12:28 PM Changeset in webkit [163396] by andersca@apple.com

2 edits in trunk/Source/WTF

Get rid of StringImpl::m_buffer
https://bugs.webkit.org/show_bug.cgi?id=128200

Reviewed by Michael Saboff.

Trade one lousy hack for another by changing the CreateEmptyUnique StringImpl
constructor to initialize its character buffer to point to m_length instead
since it will always be null.

Also change it to be an 8-bit string because why not.

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):

11:59 AM WebInspectorCodingStyleGuide edited by BJ Burg

Tip about event naming convention (diff)

11:36 AM Changeset in webkit [163395] by Lucas Forschler

41 edits in tags/Safari-538.16.1

Rollout 163280.

11:32 AM Changeset in webkit [163394] by andersca@apple.com

7 edits in trunk/Source

Rename String::getCharacters to String::characters
https://bugs.webkit.org/show_bug.cgi?id=128196

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Update for WTF::String changes.

yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):

Source/WebCore:

Update for WTF::String changes.

dom/Document.cpp:

(WebCore::canonicalizedTitle):

Source/WTF:

This means String::characters() will end up calling either characters8() or characters16() which
makes more logical sense. It also frees up the getCharacters name so we can use it for a new function
that will do upconversion.

wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendUninitializedSlow):

wtf/text/WTFString.h:

(WTF::String::characters<LChar>):
(WTF::String::characters<UChar>):

11:22 AM Changeset in webkit [163393] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Fix Release build after r163390.

platform/audio/MediaSession.cpp: Add "#if !LOG_DISABLED" around logging-only function.

11:21 AM WebInspectorCodingStyleGuide edited by BJ Burg

Organize the various advices, add nits about forEach vs. for..of and … (diff)

11:10 AM Changeset in webkit [163392] by Brent Fulgham

9 edits
1 copy in branches/safari-537.75-branch

Source/WebCore: Build fix after last branch merge.

WebCore.vcxproj/WebCore.vcxproj: Correct bad merge of media build steps.

Source/WebInspectorUI: Merge r154395.

2013-08-20 Brent Fulgham <Brent Fulgham>

<http://webkit.org/b/120098> [Windows] Enable the New Web Inspector

Reviewed by Brian Weinstein.

Add a new project to copy files to the appropriate spots in the
Windows port.

WebInspectorUI.vcxproj: Added.
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Added.
WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Added.
WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: Added.
WebInspectorUI.vcxproj/WebInspectorUIPreBuild.cmd: Added.

Source/WebKit: Merge r154395.

2013-08-20 Brent Fulgham <Brent Fulgham>

<https://webkit.org/b/120098> [Windows] Enable the new Web Inspector

Reviewed by Brian Weinstein.

WebKit.vcxproj/WebKit.sln: Add reference to the new WebInspectorUI project so that it will be included in new distributions.

Source/WebKit/win: Merge r154394

2013-08-20 Brent Fulgham <Brent Fulgham>

<https://webkit.org/b/120098> [Windows] Enable the New Web Inspector

Reviewed by Brian Weinstein.

WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::openInspectorFrontend): Use the new inspector if present in the WebKit distribution. (WebInspectorFrontendClient::localizedStringsURL): Use the new Web Inspector's localized strings (if present).

11:09 AM Changeset in webkit [163391] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

ASSERT in speculateMachineInt on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=128155

Reviewed by Filip Pizlo.

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

11:09 AM Changeset in webkit [163390] by eric.carlson@apple.com

23 edits
2 adds
2 deletes in trunk

Refine MediaSession interruptions
https://bugs.webkit.org/show_bug.cgi?id=128125

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-background-playback.html

WebCore.exp.in: Export applicationWillEnterForeground and applicationWillEnterBackground for

Internals.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::play): Ask the media session if playback is allowed instead of check

to see if it is interrupted directly.

(WebCore::HTMLMediaElement::pause): Ask the media session if pausing is allowed instead of check

to see if it is interrupted directly.

(WebCore::HTMLMediaElement::mediaType): Return media type based on media characteristics once

the information is available.

(WebCore::HTMLMediaElement::resumePlayback): New.

html/HTMLMediaElement.h:

html/HTMLMediaSession.cpp:

(WebCore::restrictionName): New, use for logging only.
(WebCore::HTMLMediaSession::addBehaviorRestriction): Log restriction changes.
(WebCore::HTMLMediaSession::removeBehaviorRestriction): Ditto.

html/HTMLMediaSession.h:

platform/audio/MediaSession.cpp:

(WebCore::stateName): New, used for logging.
(WebCore::MediaSession::MediaSession): Don't cache client media type because it can change.
(WebCore::MediaSession::setState): Log state changes.
(WebCore::MediaSession::beginInterruption): Remember the current state in case we want to use it

to restore state when the interruption ends.

(WebCore::MediaSession::endInterruption): Resume playback if appropriate.
(WebCore::MediaSession::clientWillBeginPlayback): Track the client's playback state.
(WebCore::MediaSession::clientWillPausePlayback): Ditto.
(WebCore::MediaSession::mediaType): Ask client for state.

platform/audio/MediaSession.h:

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager): m_interruptions -> m_interrupted.
(WebCore::MediaSessionManager::beginInterruption): Don't assume interruptions are always balanced.
(WebCore::MediaSessionManager::endInterruption): Ditto.
(WebCore::MediaSessionManager::addSession):
(WebCore::MediaSessionManager::applicationWillEnterBackground): Interrupt client if it is not

allowed to play in the background.

(WebCore::MediaSessionManager::applicationWillEnterForeground): End client interruption if it

was stopped by an interruption.

platform/audio/MediaSessionManager.h:

platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS): Clear the helper callback.
(WebCore::MediaSessionManageriOS::resetRestrictions): Mark video as not allowed to play

while the application is in the background. Register for application suspend/resume
notifications.

(-[WebMediaSessionHelper clearCallback]): Set _callback to nil.
(-[WebMediaSessionHelper applicationWillEnterForeground:]): New, notify client of application

state change.

(-[WebMediaSessionHelper applicationWillResignActive:]): Ditto.

platform/audio/mac/AudioDestinationMac.h: Add resumePlayback.

testing/Internals.cpp:

(WebCore::Internals::applicationWillEnterForeground): New, simulate application context switch.
(WebCore::Internals::applicationWillEnterBackground): Ditto.
(WebCore::Internals::setMediaSessionRestrictions): Add "BackgroundPlaybackNotPermitted" restriction.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export applicationWillEnterForeground

and applicationWillEnterBackground for Internals.

LayoutTests:

media/video-background-playback-expected.txt: Added.
media/video-background-playback.html: Added.
media/video-interruption-active-when-element-created-expected.txt: Removed.
media/video-interruption-active-when-element-created.html: Removed.
media/video-interruption-with-resume-allowing-play-expected.txt:
media/video-interruption-with-resume-allowing-play.html:
media/video-interruption-with-resume-not-allowing-play-expected.txt:
media/video-interruption-with-resume-not-allowing-play.html:

10:56 AM WebInspectorCodingStyleGuide edited by BJ Burg

nit about model/view layering, and when to spell out identifier (diff)

10:51 AM Changeset in webkit [163389] by akling@apple.com

15 edits
3 deletes in trunk

Remove CPP bindings generator.
<https://webkit.org/b/128189>

Scrub out some leftover Blackberry gunk.

Reviewed by Anders Carlsson.

Modules/webdatabase/SQLResultSet.idl:
bindings/cpp/WebDOMCString.cpp: Removed.
bindings/cpp/WebDOMCString.h: Removed.
bindings/cpp/WebDOMDOMWindowCustom.cpp: Removed.
bindings/cpp/WebDOMEventListenerCustom.cpp: Removed.
bindings/cpp/WebDOMEventTarget.cpp: Removed.
bindings/cpp/WebDOMEventTarget.h: Removed.
bindings/cpp/WebDOMHTMLCollectionCustom.cpp: Removed.
bindings/cpp/WebDOMHTMLDocumentCustom.cpp: Removed.
bindings/cpp/WebDOMHTMLOptionsCollectionCustom.cpp: Removed.
bindings/cpp/WebDOMNodeCustom.cpp: Removed.
bindings/cpp/WebDOMNodeFilterCustom.cpp: Removed.
bindings/cpp/WebDOMObject.h: Removed.
bindings/cpp/WebDOMString.cpp: Removed.
bindings/cpp/WebDOMString.h: Removed.
bindings/cpp/WebExceptionHandler.cpp: Removed.
bindings/cpp/WebExceptionHandler.h: Removed.
bindings/cpp/WebNativeEventListener.cpp: Removed.
bindings/cpp/WebNativeEventListener.h: Removed.
bindings/cpp/WebNativeNodeFilterCondition.cpp: Removed.
bindings/cpp/WebNativeNodeFilterCondition.h: Removed.
bindings/scripts/CodeGeneratorCPP.pm: Removed.
bindings/scripts/test/CPP/CPPTestSupplemental.cpp: Removed.
bindings/scripts/test/CPP/CPPTestSupplemental.h: Removed.
bindings/scripts/test/CPP/WebDOMFloat64Array.cpp: Removed.
bindings/scripts/test/CPP/WebDOMFloat64Array.h: Removed.
bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.h: Removed.
bindings/scripts/test/CPP/WebDOMTestCallback.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestCallback.h: Removed.
bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.h: Removed.
bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestEventConstructor.h: Removed.
bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestEventTarget.h: Removed.
bindings/scripts/test/CPP/WebDOMTestException.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestException.h: Removed.
bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestGenerateIsReachable.h: Removed.
bindings/scripts/test/CPP/WebDOMTestImplements.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestImplements.h: Removed.
bindings/scripts/test/CPP/WebDOMTestInterface.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestInterface.h: Removed.
bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.h: Removed.
bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestNamedConstructor.h: Removed.
bindings/scripts/test/CPP/WebDOMTestNode.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestNode.h: Removed.
bindings/scripts/test/CPP/WebDOMTestObj.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestObj.h: Removed.
bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.h: Removed.
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h: Removed.
bindings/scripts/test/CPP/WebDOMTestSupplemental.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestSupplemental.h: Removed.
bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp: Removed.
bindings/scripts/test/CPP/WebDOMTestTypedefs.h: Removed.
bindings/scripts/test/CPP/WebDOMattribute.cpp: Removed.
bindings/scripts/test/CPP/WebDOMattribute.h: Removed.
bindings/scripts/test/CPP/WebDOMreadonly.cpp: Removed.
bindings/scripts/test/CPP/WebDOMreadonly.h: Removed.
css/StyleSheet.idl:
dom/CustomEvent.idl:
dom/Document.idl:
dom/Event.idl:
dom/Node.idl:
dom/PopStateEvent.idl:
html/HTMLCanvasElement.idl:
html/HTMLInputElement.idl:
html/canvas/CanvasRenderingContext2D.idl:
page/DOMWindow.idl:
page/Location.idl:
workers/DedicatedWorkerGlobalScope.idl:

10:41 AM Changeset in webkit [163388] by enrica@apple.com

7 edits in trunk/Source/WebKit2

WK2: Selection callout bar does not scroll with the selection.
https://bugs.webkit.org/show_bug.cgi?id=128142
<rdar://problem/15970812>

Reviewed by Benjamin Poulain.

Adding notifications to WKContentView to all the delegates
for scrolling and zooming to let WKInteractionView about it.
This allows the interaction assistants to hide the callout
while scrolling or zooming and to fade it in again at the end.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillBeginZooming:withView:]):
(-[WKWebView scrollViewWillBeginDragging:]):

UIProcess/API/ios/WKContentView.h:
UIProcess/API/ios/WKContentView.mm:

(-[WKContentView didFinishScrollTo:]):
(-[WKContentView willStartZoomOrScroll]):
(-[WKContentView didZoomToScale:]):

UIProcess/API/ios/WKInteractionView.h:
UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView _willStartScrollingOrZooming]):
(-[WKInteractionView _didEndScrollingOrZooming]):

UIProcess/API/ios/WKViewIOS.mm:

(-[WKView scrollViewWillBeginZooming:withView:]):
(-[WKView scrollViewWillBeginDragging:]):

10:23 AM AddingFiles edited by BJ Burg

add instructions for windoze and Gmake (diff)

10:05 AM Changeset in webkit [163387] by mitz@apple.com

2 edits in trunk/Source/WebCore

iOS build fix.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

10:04 AM Changeset in webkit [163386] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Partially revert r162947 so that Document::topDocument() again Walk over the chain of
owner Elements. This fixes the crashes related to creating and accessing the AXObjectCache
of documents that were introduced in that revision, which determined the top document by
returning the Document of the main frame. This fails badly when the frame in question is cached.

Patch by Zan Dobersek <zdobersek@igalia.com> on 2014-02-04

dom/Document.cpp:

(WebCore::Document::topDocument):

10:00 AM Changeset in webkit [163385] by zandobersek@gmail.com

11 edits in trunk/Source/WebCore

Manage MediaQuery and MediaQueryExp classes through std::unique_ptr instead of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128117

Reviewed by Darin Adler.

Replace uses of OwnPtr for the MediaQuery and MediaQueryExp classes with std::unique_ptr.

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::parseMediaQuery):

css/CSSParser.h:
css/MediaList.cpp:

(WebCore::MediaQuerySet::parse):
(WebCore::MediaQuerySet::add):
(WebCore::MediaQuerySet::remove):
(WebCore::MediaQuerySet::addMediaQuery):
(WebCore::MediaList::item):
(WebCore::reportMediaQueryWarningIfNeeded):

css/MediaList.h:

(WebCore::MediaQuerySet::queryVector):

css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery):

css/MediaQuery.h:

(WebCore::MediaQuery::expressions):
(WebCore::MediaQuery::copy):

css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::eval):

css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::MediaQueryExp):

css/MediaQueryExp.h:

(WebCore::MediaQueryExp::copy):

9:56 AM Changeset in webkit [163384] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

GC timer should always do a FullCollection
https://bugs.webkit.org/show_bug.cgi?id=128186

Reviewed by Michael Saboff.

Right now the GC timer does whatever type of collection the next collection
would have been, which is almost always an EdenCollection. It then thinks
that it has done all of the work it was supposed to do and never schedules
another GC. Ideally we'd like to have some heuristics for the timer that
would schedule both EdenCollections and FullCollections, but the easiest
fix for now is to always do FullCollections since that will at least be
a non-regression.

heap/Heap.h:

(JSC::Heap::gcTimerDidFire):

runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::doWork):

9:50 AM Changeset in webkit [163383] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove SVG_DOM_OBJC_BINDINGS after r161638.
https://bugs.webkit.org/show_bug.cgi?id=128182

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-04
Reviewed by Andreas Kling.

Removed ENABLE(SVG_DOM_OBJC_BINDINGS).

No tests required.

bindings/objc/DOMUIKitExtensions.mm:

(-[DOMNode boundingBoxes]):
(-[DOMNode absoluteQuads]):

9:42 AM AddingFiles edited by BJ Burg

instructions for adding to CMake (diff)

9:27 AM Changeset in webkit [163382] by stavila@adobe.com

3 edits
2 adds in trunk

REGRESSION (r159609): Images are corrupted when hovering over buttons @ github.com
https://bugs.webkit.org/show_bug.cgi?id=127729

Reviewed by Antti Koivisto.

Source/WebCore:

When clipping a rect, the RenderLayer would not properly save the context when
the clipping rect is the same as the paint rect and the clipping rect
has radius.

Test: fast/regions/repaint/hover-border-radius.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::restoreClip):

LayoutTests:

Added test for the correct repainting of buttons with border radius when hovering.

fast/regions/repaint/hover-border-radius-expected.txt: Added.
fast/regions/repaint/hover-border-radius.html: Added.

8:48 AM Changeset in webkit [163381] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for two flaky media layout tests
https://bugs.webkit.org/show_bug.cgi?id=128183

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-02-04

platform/efl/TestExpectations:

8:39 AM Changeset in webkit [163380] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Code cleanup: remove leftover occurrence of ENABLE(GESTURE_EVENTS)
https://bugs.webkit.org/show_bug.cgi?id=128180

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-02-04
Reviewed by Csaba Osztrogonác.

Removed last occurrence of ENABLE(GESTURE_EVENTS).

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformHandleMouseEvent):

8:34 AM Changeset in webkit [163379] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

[CMAKE] Remove workaround for GCC 4.6
https://bugs.webkit.org/show_bug.cgi?id=128176

Reviewed by Csaba Osztrogonác.

Since r162126, WebKit requires at least 4.7.

CMakeLists.txt:

7:57 AM Changeset in webkit [163378] by zandobersek@gmail.com

6 edits in trunk/Source/WebCore

Manage RuleSet and RuleData classes through std::unique_ptr instead of OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=128116

Reviewed by Darin Adler.

Replace uses of OwnPtr for the RuleSet and RuleData classes with std::unique_ptr.

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):

css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::initUserStyle):
(WebCore::makeRuleSet):
(WebCore::DocumentRuleSets::resetAuthorStyle):

css/DocumentRuleSets.h:
css/RuleSet.cpp:

(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::addRegionRule):

css/RuleSet.h:

(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):

7:52 AM Changeset in webkit [163377] by commit-queue@webkit.org

23 edits
2 copies
2 deletes in trunk

Unreviewed, rolling out r163376.
http://trac.webkit.org/changeset/163376
https://bugs.webkit.org/show_bug.cgi?id=128184

Unexpected test failures. (Requested by eric_carlson on
#webkit).

Source/WebCore:

WebCore.exp.in:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

html/HTMLMediaElement.h:
html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::addBehaviorRestriction):
(WebCore::HTMLMediaSession::removeBehaviorRestriction):
(WebCore::HTMLMediaSession::clientWillBeginPlayback):

html/HTMLMediaSession.h:
platform/audio/MediaSession.cpp:

(WebCore::MediaSession::MediaSession):
(WebCore::MediaSession::beginInterruption):
(WebCore::MediaSession::endInterruption):

platform/audio/MediaSession.h:

(WebCore::MediaSession::mediaType):
(WebCore::MediaSession::setState):
(WebCore::MediaSessionClient::beginInterruption):
(WebCore::MediaSessionClient::endInterruption):

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::beginInterruption):
(WebCore::MediaSessionManager::endInterruption):
(WebCore::MediaSessionManager::addSession):

platform/audio/MediaSessionManager.h:
platform/audio/ios/MediaSessionManagerIOS.h:

(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS):

platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::resetRestrictions):
(-[WebMediaSessionHelper initWithCallback:]):

platform/audio/mac/AudioDestinationMac.h:
testing/Internals.cpp:

(WebCore::Internals::setMediaSessionRestrictions):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

media/video-background-playback-expected.txt: Removed.
media/video-background-playback.html: Removed.
media/video-interruption-active-when-element-created-expected.txt: Copied from LayoutTests/media/video-interruption-with-resume-allowing-play-expected.txt.
media/video-interruption-active-when-element-created.html: Copied from LayoutTests/media/video-interruption-with-resume-not-allowing-play.html.
media/video-interruption-with-resume-allowing-play-expected.txt:
media/video-interruption-with-resume-allowing-play.html:
media/video-interruption-with-resume-not-allowing-play-expected.txt:
media/video-interruption-with-resume-not-allowing-play.html:

6:59 AM Changeset in webkit [163376] by eric.carlson@apple.com

23 edits
2 adds
2 deletes in trunk

Refine MediaSession interruptions
https://bugs.webkit.org/show_bug.cgi?id=128125

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-background-playback.html

WebCore.exp.in: Export applicationWillEnterForeground and applicationWillEnterBackground for

Internals.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::play): Ask the media session if playback is allowed instead of check

to see if it is interrupted directly.

(WebCore::HTMLMediaElement::pause): Ask the media session if pausing is allowed instead of check

to see if it is interrupted directly.

(WebCore::HTMLMediaElement::mediaType): Return media type based on media characteristics once

the information is available.

(WebCore::HTMLMediaElement::resumePlayback): New.

html/HTMLMediaElement.h:

html/HTMLMediaSession.cpp:

(WebCore::restrictionName): New, use for logging only.
(WebCore::HTMLMediaSession::addBehaviorRestriction): Log restriction changes.
(WebCore::HTMLMediaSession::removeBehaviorRestriction): Ditto.

html/HTMLMediaSession.h:

platform/audio/MediaSession.cpp:

to restore state when the interruption ends.

platform/audio/MediaSession.h:

platform/audio/MediaSessionManager.cpp:

allowed to play in the background.

(WebCore::MediaSessionManager::applicationWillEnterForeground): End client interruption if it

was stopped by an interruption.

platform/audio/MediaSessionManager.h:

platform/audio/ios/MediaSessionManagerIOS.h:
platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::~MediaSessionManageriOS): Clear the helper callback.
(WebCore::MediaSessionManageriOS::resetRestrictions): Mark video as not allowed to play

while the application is in the background. Register for application suspend/resume
notifications.

(-[WebMediaSessionHelper clearCallback]): Set _callback to nil.
(-[WebMediaSessionHelper applicationWillEnterForeground:]): New, notify client of application

state change.

(-[WebMediaSessionHelper applicationWillResignActive:]): Ditto.

platform/audio/mac/AudioDestinationMac.h: Add resumePlayback.

testing/Internals.cpp:

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export applicationWillEnterForeground

and applicationWillEnterBackground for Internals.

LayoutTests:

media/video-background-playback-expected.txt: Added.
media/video-background-playback.html: Added.
media/video-interruption-active-when-element-created-expected.txt: Removed.
media/video-interruption-active-when-element-created.html: Removed.
media/video-interruption-with-resume-allowing-play-expected.txt:
media/video-interruption-with-resume-allowing-play.html:
media/video-interruption-with-resume-not-allowing-play-expected.txt:
media/video-interruption-with-resume-not-allowing-play.html:

6:50 AM Changeset in webkit [163375] by commit-queue@webkit.org

2 edits in trunk/Tools

[Automake] Add missing $(feature_defines) when generating InjectedBundle bindings
https://bugs.webkit.org/show_bug.cgi?id=128170

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

WebKitTestRunner/GNUmakefile.am: Add missing $(feature_defines) when

generating the InjectedBundle bindings. So the various ENABLE_* defines
are available there.

5:43 AM Changeset in webkit [163374] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for three flaky media layout tests
https://bugs.webkit.org/show_bug.cgi?id=128104

Unreviewed EFL gardening

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-02-04

platform/efl/TestExpectations:

4:42 AM Changeset in webkit [163373] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Ensure generated events have given modifiers GDK understands
https://bugs.webkit.org/show_bug.cgi?id=128171

Patch by Carlos Garnacho <carlosg@gnome.org> on 2014-02-04
Reviewed by Carlos Garcia Campos.

WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::webkitModifiersToGDKModifiers): Move around
(WTR::EventSenderProxy::createMouseButtonEvent):
(WTR::EventSenderProxy::keyDown): Use webkitModifiersToGDKModifiers to
translate WKEventModifiers.

3:54 AM Changeset in webkit [163372] by rgabor@webkit.org

3 edits in trunk/Tools

Fine tuning the ARM EFL bots
https://bugs.webkit.org/show_bug.cgi?id=128168

Reviewed by Csaba Osztrogonác.

BuildSlaveSupport/build.webkit.org-config/config.json: Add custom SVN mirror.
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(WaitForSVNServer): Make it not to halt before the first repository checkout.
(WaitForSVNServer.evaluateCommand):
(Factory.init): Disable kill-old-processes step on EFL ARM bots, because these
bots run on the same machine and they kill the processes of each other.

3:40 AM Changeset in webkit [163371] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for two flaky media layout tests
https://bugs.webkit.org/show_bug.cgi?id=127994

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-02-04

platform/efl/TestExpectations:

2:25 AM Changeset in webkit [163370] by eunmi15.lee@samsung.com

4 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_context needs to route InjectedBundle messages correctly.
https://bugs.webkit.org/show_bug.cgi?id=90772

Reviewed by Gyuyoung Kim.

Add APIs to post message to injected bundle and register callback to
get message from injected bundle. When callback is registered,
WKContextInjectedBundleClient is set to get messages from injected bundle.

UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(toEwkContext):
(EwkContext::didReceiveMessageFromInjectedBundle):
(EwkContext::didReceiveSynchronousMessageFromInjectedBundle):
(EwkContext::setMessageFromInjectedBundleCallback): register callback to get message from injected bundle.
(EwkContext::processReceivedMessageFromInjectedBundle): process message from injected bundle.
(ewk_context_message_post_to_injected_bundle):
(ewk_context_message_from_injected_bundle_callback_set):

UIProcess/API/efl/ewk_context.h:
UIProcess/API/efl/ewk_context_private.h:

2:10 AM Changeset in webkit [163369] by commit-queue@webkit.org

3 edits
4 adds in trunk

[CSS Regions] Fix Assert SHOULD NEVER BE REACHED in RenderLayer::enclosingElement()
https://bugs.webkit.org/show_bug.cgi?id=123329

Patch by Mihai Maerean <Mihai Maerean> on 2014-02-04
Reviewed by Mihnea Ovidenie.

Source/WebCore:

The flowthread doesn't have an enclosing element, so when hitting the layer of the
flowthread (e.g. the descent area of the RootInlineBox for the image flowed alone
inside the flow thread) we're letting the hit testing continue so it will hit the region.

Tests: fast/regions/assert-hit-test-image.html

fast/regions/auto-size/region-same-height-as-div-with-inline-child.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestContents):

LayoutTests:

fast/regions/assert-hit-test-image.html: Added.
fast/regions/assert-hit-test-image-expected.txt: Added.
fast/regions/auto-size/region-same-height-as-div-with-inline-child.html: Added.
fast/regions/auto-size/region-same-height-as-div-with-inline-child-expected.txt: Added.

12:53 AM Changeset in webkit [163368] by mihnea@adobe.com

3 edits
4 adds in trunk

ASSERTION FAILED: !object

(object->isRenderBlock())

https://bugs.webkit.org/show_bug.cgi?id=127687

Reviewed by Ryosuke Niwa.

Source/WebCore:

Currently, when computing the visible position for a point inside a region,
we transform the point into flow thread coordinates and delegate the processing
to the first child of the flow thread which we incorrectly assume is a block.
However, we can specify flow-into also on inline elements which leads to the
assertion.

Instead of delegating the processing to the first child when the flow thread
has children, delegate the computation of the visible position to the
flow thread and avoid any assumption about the nature of the flow thread
first child. If the flow thread does not have any children that should be
rendered by the region, let the region behave like an ordinary element
with no children.

Tests: fast/regions/selection/position-for-point-inline-content-node.html

fast/regions/selection/selection-ended-in-empty-region.html

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::positionForPoint):

LayoutTests:

Added test showing that the content of an inline content node, having
flow-into specified, can be properly selected without hitting the assertion.
Also added another test to make sure that when the selection starts
outside an empty region and ends inside the empty region, the region behaves
like an ordinary element with no children.

fast/regions/selection/position-for-point-inline-content-node-expected.txt: Added.
fast/regions/selection/position-for-point-inline-content-node.html: Added.
fast/regions/selection/selection-ended-in-empty-region-expected.txt: Added.
fast/regions/selection/selection-ended-in-empty-region.html: Added.

12:20 AM Changeset in webkit [163367] by jinwoo7.song@samsung.com

9 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using COMPILE_ASSERT_MATCHING_ENUM macros in EFL WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128156

Reviewed by Anders Carlsson.

UIProcess/API/efl/EwkView.cpp:

(EwkView::requestPopupMenu):

UIProcess/API/efl/ewk_context.cpp:

(toWKCacheModel):
(EwkContext::setCacheModel):

UIProcess/API/efl/ewk_cookie_manager.cpp:

(ewk_cookie_manager_persistent_storage_set):
(ewk_cookie_manager_accept_policy_set):

UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(toEwkNavigationType):
(toEventMouseButton):
(toEventModifierKeys):
(EwkNavigationPolicyDecision::EwkNavigationPolicyDecision):
(EwkNavigationPolicyDecision::navigationType):
(EwkNavigationPolicyDecision::mouseButton):
(EwkNavigationPolicyDecision::modifiers):
(ewk_navigation_policy_decision_download):

UIProcess/API/efl/ewk_navigation_policy_decision_private.h:

(EwkNavigationPolicyDecision::create):

UIProcess/API/efl/ewk_popup_menu_item.cpp:

(EwkPopupMenuItem::type):
(EwkPopupMenuItem::textDirection):

UIProcess/API/efl/ewk_private.h:
UIProcess/API/efl/ewk_view.cpp:

(toWKFindOptions):
(ewk_view_text_find):
(toWKPaginationMode):
(toEwkPaginationMode):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

Feb 3, 2014:

11:41 PM WebKitGTK/2.2.x edited by tpopela@redhat.com

(diff)

9:50 PM Changeset in webkit [163366] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Lift the FTL tier-up threshold from 25000 to 100000
https://bugs.webkit.org/show_bug.cgi?id=128158

Rubber stamped by Michael Saboff.

runtime/Options.h:

9:44 PM Changeset in webkit [163365] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix after http://trac.webkit.org/changeset/163364

DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getObjectStoreStatement): Args need the new names, and I need to save the file before committing. :(

9:42 PM Changeset in webkit [163364] by beidson@apple.com

2 edits in trunk/Source/WebKit2

IDB: HTML5 Rocks Indexed Database demo fails
https://bugs.webkit.org/show_bug.cgi?id=128157

Reviewed by Anders Carlsson (Provisional review by Jon Lee)

DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:

(WebKit::getIndexStatement): Only increment the open/closed counters if those keys exist.

Fix order of statements for no lower key.

(WebKit::getObjectStoreStatement): Only increment the open/closed counters if those keys exist.

9:10 PM Changeset in webkit [163363] by mark.lam@apple.com

2 edits
2 adds in trunk/LayoutTests

Need regression test for the debugger modifying locals in a DFG frame.
https://bugs.webkit.org/show_bug.cgi?id=128120.

Reviewed by Geoffrey Garen.

Regression test for https://bugs.webkit.org/show_bug.cgi?id=128112.

This test does the following:

Warm up a DFG function.
Sets a breakpoint in a function breakpointBasic() that will be called by the DFG function, but has never been called yet.
Call a driver function which in turn calls the DFG function, and expect the debugger to break.
At the breakpoint in breakpointBasic(), evaluate an expression on its caller i.e. the DFG function, and change a local variable in it.
Resume from the debugger, and let the DFG function and its driver function run to completion. The DFG function will return a value computed using the modified local.
At the end of the driver function, verify that the returned computed value reflects the modified value.

This test has been verified with tracing enabled to ensure that the test
DFG function was indeed DFG compiled, and that the test passed with the
expected results.

inspector-protocol/debugger/resources/breakpoint.js:

(notInlineable2):
(dfgWithoutInline2):
(callNotInlineable2):

inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local-expected.txt: Added.
inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html: Added.

9:05 PM Changeset in webkit [163362] by jae.park@company100.net

2 edits in trunk/Source/WebKit2

Use nullptr in ShareableBitmap
https://bugs.webkit.org/show_bug.cgi?id=128153

Reviewed by Gyuyoung Kim.

Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):

8:13 PM Changeset in webkit [163361] by mark.lam@apple.com

1 edit
2 adds in trunk/LayoutTests

Need regression test to ensure that the debugger does not attempt to execute a bad script from its console.
<https://webkit.org/b/128121>

Reviewed by Geoffrey Garen.

Regression test for https://bugs.webkit.org/show_bug.cgi?id=127600.

inspector-protocol/debugger/breakpoint-condition-with-bad-script-expected.txt: Added.
inspector-protocol/debugger/breakpoint-condition-with-bad-script.html: Added.
Sets up a breakpoint with a condition script. The condition script will fail to parse with a syntax error. I've tested that without the fix in http://trac.webkit.org/r162752, this will crash the VM. With the fix, it works fine.

8:08 PM Changeset in webkit [163360] by akling@apple.com

2 edits in trunk/Source/WebCore

Remove stray vestige from ::-webkit-distributed selector.
<https://webkit.org/b/128154>

Reviewed by Anders Carlsson.

css/CSSSelector.cpp:

(WebCore::CSSSelector::extractPseudoType):

7:47 PM Changeset in webkit [163359] by akling@apple.com

22 edits
3 deletes in trunk/Source/WebCore

Remove the CSS @host rule.
<https://webkit.org/b/128146>

The @host rule is no longer part of the spec, and besides this code
was behind ENABLE(SHADOW_DOM) so nobody was building it.

Reviewed by Anders Carlsson.

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
GNUmakefile.list.am:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJS):

bindings/objc/DOMCSS.mm:

(kitClass):

css/CSSAllInOne.cpp:
css/CSSGrammar.y.in:
css/CSSHostRule.cpp: Removed.
css/CSSHostRule.h: Removed.
css/CSSHostRule.idl: Removed.
css/CSSParser.cpp:

(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::detectAtToken):

css/CSSParser.h:
css/CSSRule.h:
css/CSSRule.idl:
css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

css/StyleResolver.h:
css/StyleRule.cpp:

(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):

css/StyleRule.h:
css/StyleSheetContents.cpp:

(WebCore::childRulesHaveFailedOrCanceledSubresources):

inspector/InspectorStyleSheet.cpp:

(flattenSourceData):
(WebCore::asCSSRuleList):

7:10 PM Changeset in webkit [163358] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Add title and hasOnlySecureContent properties to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128152

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView title]):
(-[WKWebView hasOnlySecureContent]):

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):
(WebKit::NavigationState::willChangeTitle):
(WebKit::NavigationState::didChangeTitle):
(WebKit::NavigationState::willChangeHasOnlySecureContent):
(WebKit::NavigationState::didChangeHasOnlySecureContent):

7:04 PM Changeset in webkit [163357] by Alan Bujtas

5 edits in trunk/Source/WebCore

Subpixel rendering: Do not query the scaling factor when the graphics context is invalid.
https://bugs.webkit.org/show_bug.cgi?id=128131

Reviewed by Simon Fraser.

No existing context to test it.

platform/graphics/GraphicsContext.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::platformInit):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::platformInit):

7:00 PM Changeset in webkit [163356] by bshafiei@apple.com

5 edits in tags/Safari-538.16.1/Source

Versioning.

6:58 PM Changeset in webkit [163355] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Fix spelling.

Shared/WebPreferencesStore.h:

6:56 PM Changeset in webkit [163354] by bshafiei@apple.com

1 copy in tags/Safari-538.16.1

New tag.

6:52 PM Changeset in webkit [163353] by weinig@apple.com

2 edits in trunk/Source/WebKit2

[WebKit2, iOS] Enable frame flattening by default on iOS
<rdar://problem/15975983>
https://bugs.webkit.org/show_bug.cgi?id=128151

Reviewed by Tim Horton.

Shared/WebPreferencesStore.h:

6:09 PM Changeset in webkit [163352] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[iOS][wk2] Temporarily disable accelerated drawing for canvas
https://bugs.webkit.org/show_bug.cgi?id=128147

Reviewed by Simon Fraser.

Shared/WebPreferencesStore.h:

Temporarily disable accelerated canvas for WebKit2 on iOS.

6:08 PM Changeset in webkit [163351] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

LLInt: Regex for pseudo-instructions is too big
https://bugs.webkit.org/show_bug.cgi?id=128148

Reviewed by Mark Lam.

offlineasm/instructions.rb:
offlineasm/parser.rb:

6:02 PM Changeset in webkit [163350] by andersca@apple.com

4 edits in trunk/Source/WebKit2

Add loading property to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128144

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView isLoading]):

UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::willChangeIsLoading):
(WebKit::NavigationState::didChangeIsLoading):

5:13 PM Changeset in webkit [163349] by andersca@apple.com

2 edits in trunk/Source/WTF

Fix Windows build.

wtf/text/StringImpl.h:

(WTF::StringImpl::tailOffset):

5:07 PM Changeset in webkit [163348] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Cairo] GraphicsContext::m_pixelSnappingFactor is uninitialized
https://bugs.webkit.org/show_bug.cgi?id=128102

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-02-03
Reviewed by Csaba Osztrogonác.

Initalize m_pixelSnappingFactor to 1

platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::GraphicsContext): Initialized pixelSnappingFactor to 1 and
fixed the coding style violation.

5:03 PM Changeset in webkit [163347] by andersca@apple.com

2 edits in trunk/Source/WTF

StringImpl::tailOffset() should return the offset right after m_hashAndFlags
https://bugs.webkit.org/show_bug.cgi?id=128141

Reviewed by Andreas Kling.

wtf/text/StringImpl.h:

(WTF::StringImpl::tailOffset):

5:02 PM Changeset in webkit [163346] by BJ Burg

8 edits
10 adds in trunk/Source

Fix for 128110

4:54 PM Changeset in webkit [163345] by mhahnenberg@apple.com

8 edits in trunk/Source/JavaScriptCore

Fix the cloop due to GenGC
https://bugs.webkit.org/show_bug.cgi?id=128137

Reviewed by Geoffrey Garen.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.cpp:

(JSC::CLoopRegister::operator JSCell*):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
offlineasm/cloop.rb:
offlineasm/instructions.rb:

4:45 PM Changeset in webkit [163344] by jinwoo7.song@samsung.com

2 edits in trunk/Source/WebCore

Remove unused code in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=128135

Reviewed by Darin Adler.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

4:40 PM Changeset in webkit [163343] by Brent Fulgham

4 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix after r162860.

platform/graphics/MediaPlayer.cpp: Prevent 64-bit build from using QuickTime SDK.
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Ditto.
platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h: Ditto.

4:37 PM Changeset in webkit [163342] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION (r163011-r163031): Web Inspector: Latest nightly crashes when showing the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=127901

Reviewed by Geoffrey Garen.

Set VM::topCallFrame before making calls to possible C++ code in
generateProtoChainAccessStub() and tryBuildGetByIDList().

jit/Repatch.cpp:

(JSC::generateProtoChainAccessStub):
(JSC::tryBuildGetByIDList):

4:37 PM Changeset in webkit [163341] by andersca@apple.com

3 edits in trunk/Source/WTF

More tail pointer consolidation
https://bugs.webkit.org/show_bug.cgi?id=128139

Reviewed by Andreas Kling.

Add a new tailOffset() function and reimplement allocationSize() and tailPointer()
in terms of it. Use tailPointer() instead of reinterpret_cast-ing this + 1.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitializedInternalNonEmpty):

wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::requiresCopy):
(WTF::StringImpl::allocationSize):
(WTF::StringImpl::tailOffset):
(WTF::StringImpl::tailPointer):

4:29 PM Changeset in webkit [163340] by rniwa@webkit.org

2 edits in trunk/Tools

kill-old-processes doesn't kill plugin processes
https://bugs.webkit.org/show_bug.cgi?id=128138

Reviewed by Andreas Kling.

Add plugin process names to the list of processes to kill.

BuildSlaveSupport/kill-old-processes:

(main):

4:26 PM Changeset in webkit [163339] by Gustavo Noronha Silva

2 edits in trunk/Source/WTF

[GTK][CMake] Enable SUBPIXEL_LAYOUT in FeatureDefines.h like EFL does
https://bugs.webkit.org/show_bug.cgi?id=128136

Reviewed by Martin Robinson.

wtf/FeatureDefines.h: enable SUBPIXEL_LAYOUT if it's not set, for GTK+.

4:21 PM AddingFiles created by BJ Burg

4:17 PM Changeset in webkit [163338] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Mac] WK1 Clients Only Latch on Momentum Scroll
https://bugs.webkit.org/show_bug.cgi?id=128133

Reviewed by Simon Fraser.

platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::useLatchedEventElement): Update
predicate to recognize the start and change phases of the wheel
event as latchable (not just momentum start/change).

4:13 PM Changeset in webkit [163337] by akling@apple.com

3 edits in trunk/Source/JavaScriptCore

Keep only captured symbols in CodeBlock symbol tables.
<https://webkit.org/b/128050>

Discard all uncaptured symbols at the end of codegen since only
the captured ones will be used after that point.

~2MB progression on Membuster OSUS.

Reviewed by Geoffrey Garen.

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::setSymbolTable):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

4:00 PM Changeset in webkit [163336] by Simon Fraser

2 edits in trunk/Source/WebKit2

Allow WK2 to read from NSUserDefaults when it has no prefs identifier
https://bugs.webkit.org/show_bug.cgi?id=128124

Reviewed by Sam Weinig.

WebPreferences would never read from NSUserDefaults if no identifier
had been set, but this prevents us from reading useful debugging prefs.

Fix to read pref names using a "WebKit2" prefix when no identifier
is set.

UIProcess/mac/WebPreferencesMac.mm:

(WebKit::makeKey):
(WebKit::WebPreferences::platformInitializeStore):

3:58 PM WikiStart edited by BJ Burg

add link: adding files (diff)

3:39 PM Changeset in webkit [163335] by jer.noble@apple.com

5 edits in trunk/Source/WebKit2

[WK2] Remove the VideoPluginProxyEnabled preference in WK2
https://bugs.webkit.org/show_bug.cgi?id=128128

Reviewed by Brady Eidson.

The plugin proxy is iOS WK1 only, and has no meaning in WebKit2. Just set the preference to false.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:
UIProcess/API/C/WKPreferencesRef.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

3:36 PM Changeset in webkit [163334] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix the LLInt C loop

Rubber stamped by Mark Lam.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_write_barrier_slow):

llint/LLIntSlowPaths.h:

3:35 PM Changeset in webkit [163333] by dino@apple.com

37 edits in trunk

Feature flag for shape-inside
https://bugs.webkit.org/show_bug.cgi?id=128001

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Add CSS_SHAPE_INSIDE flag.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add CSS_SHAPE_INSIDE flag.

I wrapped everything that is specific to shape-inside in
this flag. It is now possible to build with CSS Shapes enabled
but shape-inside disabled. CSS_SHAPE_INSIDE is dependent on
CSS_SHAPES, so disabling the latter should also disable the former.

Configurations/FeatureDefines.xcconfig:
css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseShapeProperty):

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::loadPendingImages):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::updateShapesBeforeBlockLayout):
(WebCore::RenderBlock::updateShapesAfterBlockLayout):

rendering/RenderBlock.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):

rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::constructBidiRunsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):

rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):

rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::createStyle):

rendering/RenderView.h:
rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::handleEndOfLine):

rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::nextLineBreak):

rendering/line/LineWidth.cpp:

(WebCore::LineWidth::LineWidth):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::LineWidth::fitBelowFloats):

rendering/line/LineWidth.h:
rendering/shapes/ShapeInsideInfo.cpp:
rendering/shapes/ShapeInsideInfo.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

Source/WebKit/mac:

Add CSS_SHAPE_INSIDE flag.

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add CSS_SHAPE_INSIDE flag.

Configurations/FeatureDefines.xcconfig:

Tools:

Add CSS_SHAPE_INSIDE flag, and -css-shape-inside build
flag.

Scripts/webkitperl/FeatureList.pm:

3:33 PM Changeset in webkit [163332] by andersca@apple.com

5 edits
1 add in trunk/Source/WebKit2

NavigationState should be a PageLoadState::Observer
https://bugs.webkit.org/show_bug.cgi?id=128130

Reviewed by Darin Adler.

This will make it easier to provide load related KVO properties on WKWebView.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

UIProcess/API/Cocoa/WKWebViewInternal.h: Added.
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::~NavigationState):
(WebKit::NavigationState::willChangeIsLoading):
(WebKit::NavigationState::didChangeIsLoading):
(WebKit::NavigationState::willChangeTitle):
(WebKit::NavigationState::didChangeTitle):
(WebKit::NavigationState::willChangeActiveURL):
(WebKit::NavigationState::didChangeActiveURL):
(WebKit::NavigationState::willChangeHasOnlySecureContent):
(WebKit::NavigationState::didChangeHasOnlySecureContent):
(WebKit::NavigationState::willChangeEstimatedProgress):
(WebKit::NavigationState::didChangeEstimatedProgress):

WebKit2.xcodeproj/project.pbxproj:

3:27 PM Changeset in webkit [163331] by Lucas Forschler

12 edits
2 copies in tags/Safari-538.16

Merged r163329.

3:12 PM Changeset in webkit [163330] by mhahnenberg@apple.com

2 edits in trunk/Source/WTF

Turn GenGC on
https://bugs.webkit.org/show_bug.cgi?id=128109

Reviewed by Oliver Hunt.

wtf/Platform.h: Initially it will only be enabled for X86-64.

3:10 PM Changeset in webkit [163329] by Brent Fulgham

12 edits
2 adds in trunk

REGRESSION (r163018): Can’t scroll in <select> lists
https://bugs.webkit.org/show_bug.cgi?id=128090

Source/WebCore:

The regression was caused by the fact that a new method scrollWithWheelEventLocation() was added
to RenderBox to replace the generic scroll() method for the particular case of scrolling using
the mouse wheel. This turned out to be a mistake because in the case of some elements, like select lists,
the scroll method was overriden and now the incorrect method was being called.
The solution was to remove the new method and just add two default parameters to the generic
scroll method.

Patch by Radu Stavila <stavila@adobe.com> on 2014-02-03
Reviewed by Simon Fraser.

Test: fast/scrolling/scroll-select-list.html

page/EventHandler.cpp:

(WebCore::scrollNode):

rendering/RenderBox.cpp:

(WebCore::RenderBox::scroll):

rendering/RenderBox.h:
rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::scroll):

rendering/RenderEmbeddedObject.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::scroll):

rendering/RenderListBox.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::scroll):

rendering/RenderTextControlSingleLine.h:

LayoutTests:

New test validates scrolling using the mouse wheel inside a select list.
This test is for the moment added as a ImageOnlyFailure expectation
because the current implementation of eventSender cannot simulate mouse wheel events.

Patch by Radu Stavila <stavila@adobe.com> on 2014-02-03
Reviewed by Simon Fraser.

TestExpectations:
fast/scrolling/scroll-select-list-expected.html: Added.
fast/scrolling/scroll-select-list.html: Added.

2:43 PM Changeset in webkit [163328] by oliver@apple.com

5 edits
3 adds in trunk

Deconstructed parameters aren't being placed in the correct scope
https://bugs.webkit.org/show_bug.cgi?id=128126

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Make sure we declare the bound parameter names as variables when
we reparse. In the BytecodeGenerator we now also directly ensure
that bound parameters are placed in the symbol table of the function
we're currently compiling. We then delay binding until just before
we start codegen for the body of the function so that we can ensure
the function has completely initialised all scope details.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):

bytecompiler/BytecodeGenerator.h:
parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::createBindingPattern):

LayoutTests:

Added tests for correct behaviour.

js/deconstructing-parameters-should-be-locals-expected.txt: Added.
js/deconstructing-parameters-should-be-locals.html: Added.
js/script-tests/deconstructing-parameters-should-be-locals.js: Added.

(description.value.string_appeared_here.readDeconstructedParameter):
(overwriteDeconstructedParameter):
(readCapturedDeconstructedParameter):
(overwriteCapturedDeconstructedParameter):

2:39 PM Changeset in webkit [163327] by zoltan@webkit.org

2 edits in trunk/Tools

Unreviewed. Reorder my e-mail addresses in contributors.json,
so bugzilla will auto complete my actual bugzilla username.

Scripts/webkitpy/common/config/contributors.json:

2:04 PM Changeset in webkit [163326] by andersca@apple.com

3 edits in trunk/Source/WTF

Consolidate StringImpl tail handling into two functions
https://bugs.webkit.org/show_bug.cgi?id=128122

Reviewed by Andreas Kling.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):

wtf/text/StringImpl.h:

(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::allocationSize):
(WTF::StringImpl::tailPointer):

1:52 PM Changeset in webkit [163325] by ap@apple.com

2 edits in trunk/Source/JavaScriptCore

Update JS whitespace definition for changes in Unicode 6.3
https://bugs.webkit.org/show_bug.cgi?id=127450

Reviewed by Oliver Hunt.

parser/Lexer.h: (JSC::Lexer<UChar>::isWhiteSpace): Part 2 of the fix, update lexer too.

1:51 PM Changeset in webkit [163324] by commit-queue@webkit.org

4 edits
2 adds in trunk/Source/JavaScriptCore

Added GetTypedArrayByteOffset to FTL
https://bugs.webkit.org/show_bug.cgi?id=127589

Patch by Matthew Mirman <mmirman@apple.com> on 2014-02-03
Reviewed by Filip Pizlo.

ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetTypedArrayByteOffset):

tests/stress/ftl-gettypedarrayoffset-simple.js: Added.

(foo):

tests/stress/ftl-gettypedarrayoffset-wasteful.js: Added.

(foo):

1:46 PM Changeset in webkit [163323] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

WebKit2 View Gestures: Two smart magnifications in a row without moving the mouse should zoom out
https://bugs.webkit.org/show_bug.cgi?id=128108
<rdar://problem/15914539>

Reviewed by Darin Adler.

UIProcess/mac/ViewGestureController.h:
UIProcess/mac/ViewGestureController.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::handleMagnificationGesture):
Clear the bit that tells us that we should do "smart" things (because the
last gesture was also a smart magnification gesture) when the user manually pinch-magnifies.

(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Zoom out if the mouse hasn't moved since the last pinch-magnification gesture.

12:59 PM Changeset in webkit [163322] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Debugger created JSActivations should account for CodeBlock::framePointerOffsetToGetActivationRegisters().
<https://webkit.org/b/128112>

Reviewed by Geoffrey Garen.

Currently, when the DebuggerCallFrame creates the JSActivation object
for a frame, it does not account for the framePointerOffsetToGetActivationRegisters()
offset that needs to be added for DFG frames.

Instead of special casing the fix in DebuggerCallFrame::scope(), we fix
this by adding CodeBlock::framePointerOffsetToGetActivationRegisters() to
callFrame->registers() in the JSActivation::create() method that does not
explicitly take a Register*. This ensures that JSActivation::create() will
always do the right thing instead of only being a special case for the
LLINT and baselineJIT.

Apart from the DebuggerCallFrame, this create() function is only called by
slow paths in the LLINT and baselineJIT. Hence, it is not performance
critical.

runtime/JSActivation.h:

(JSC::JSActivation::create):

12:39 PM Changeset in webkit [163321] by ggaren@apple.com

18 edits
3 adds in trunk

Simplified name scope creation for function expressions
https://bugs.webkit.org/show_bug.cgi?id=128031

Reviewed by Mark Lam.

Source/JavaScriptCore:

3X speedup on js/regress/script-tests/function-with-eval.js.

We used to emit bytecode to push a name into local scope every
time a function that needed such a name executed. Now, we push the name
into scope once on the function object, and leave it there.

This is faster, and it also reduces the number of variable resolution
modes you have to worry about when thinking about bytecode and the
debugger.

This patch is slightly complicated by the fact that we don't know if
a function needs a name scope until we parse its body. So, there's some
glue code in here to delay filling in a function's scope until we parse
its body for the first time.

bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::functionMode): Renamed
functionNameIsInScopeToggle to functionMode.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): No need to emit convert_this
when debugging. The debugger will perform the conversion as needed.

(JSC::BytecodeGenerator::resolveCallee):
(JSC::BytecodeGenerator::addCallee): Simplified this code by removing
the "my function needs a name scope, but didn't allocate one" mode.

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall): Pass a scope slot through to
CodeBlock generation, so we can add a function name scope if the parsed
function body requires one.

jit/JITOperations.cpp:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setUpCall): Ditto.

parser/NodeConstructors.h:

(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):

parser/Nodes.cpp:

(JSC::FunctionBodyNode::finishParsing):

parser/Nodes.h:

(JSC::FunctionBodyNode::functionMode): Updated for rename.

parser/ParserModes.h:

(JSC::functionNameIsInScope):
(JSC::functionNameScopeIsDynamic): Helper functions for reasoning about
how crazy JavaScript language semantics are.

runtime/ArrayPrototype.cpp:

(JSC::isNumericCompareFunction):
(JSC::attemptFastSort): Updated for interface changes above.

runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):
(JSC::FunctionExecutable::FunctionExecutable):

runtime/Executable.h:

(JSC::ScriptExecutable::prepareForExecution):
(JSC::FunctionExecutable::functionMode):

runtime/JSFunction.cpp:

(JSC::JSFunction::addNameScopeIfNeeded):

runtime/JSFunction.h:
runtime/JSNameScope.h:

(JSC::JSNameScope::create):
(JSC::JSNameScope::JSNameScope): Added machinery for pushing a function
name scope onto a function when we first discover that it's needed.

LayoutTests:

Added a performance regression test.

js/regress/function-with-eval-expected.txt: Added.
js/regress/function-with-eval.html: Added.
js/regress/script-tests/function-with-eval.js: Added.

(foo):
(bar):

12:34 PM Changeset in webkit [163320] by Chris Fleizach

3 edits
2 adds in trunk

AX: WebKit should support @headers/@id for complex accessible web tables
https://bugs.webkit.org/show_bug.cgi?id=128114

Reviewed by Darin Adler.

Source/WebCore:

Expose the headers attribute for table cells to accessibility.

Test: platform/mac/accessibility/table-headers-attribute.html

accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::columnHeaders):

LayoutTests:

platform/mac/accessibility/table-headers-attribute-expected.txt: Added.
platform/mac/accessibility/table-headers-attribute.html: Added.

12:26 PM Changeset in webkit [163319] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: RenderSVGGradientStop always has a SVGStopElement.
<https://webkit.org/b/128107>

RenderSVGGradientStop is never anonymous and always has a
corresponding SVGStopElement. Codify this by adding an element()
overload that returns an SVGStopElement&.

Also added missing overrides and made most functions private.

Reviewed by Darin Adler.

rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::styleDidChange):
(WebCore::RenderSVGGradientStop::gradientElement):

rendering/svg/RenderSVGGradientStop.h:
rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGGradientStop):

11:34 AM Changeset in webkit [163318] by ddkilzer@apple.com

4 edits in trunk/Source/WebCore

Remove CachedImageManual class
<http://webkit.org/b/128043>

Reviewed by Darin Adler.

Get rid of the CachedImageManual class by inlining its
functionality into CachedImage. This makes it possible to
de-virtual-ize isManual() (renamed to isManuallyCached()) and to
make CachedImage final. The size of CachedImage does not
increase because we turn an existing bool into a bitfield to add
an m_isManuallyCached bit, and create a static CachedImageClient
in MemoryCache.cpp as the "fake" client to keep the manually
cached image alive in the cache.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage): Set m_isManuallyCached
bitfield. For one overloaded constructor, move the
CachedImageManual code into the CachedImage constructor.
(WebCore::CachedImageManual::CachedImageManual): Remove.
(WebCore::CachedImage::mustRevalidateDueToCacheHeaders): Move
method from CachedImageManual to CachedImage, and put
ManuallyCached behavior behind a check.

loader/cache/CachedImage.h: Update includes. Make CachedImage

final. Add CachedImage::CacheBehaviorType enum when manually
cached images are created. Move CachedImageManual methods into
CachedImage, remove addFakeClient() and removeFakeClient()
methods (MemoryCache methods use addClient() and removeClient()
with a static CachedImageClient), and remove the
CachedImageManual class definition. Change
m_shouldPaintBrokenImage to a bitfield and add
m_isManuallyCached bitfield.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache): Use std::unique_ptr and
remove useless NULL check after calling CachedImage constructor.
(WebCore::MemoryCache::removeImageFromCache):

Update to use CachedImage class instead of CachedImageManual.

11:07 AM Changeset in webkit [163317] by zandobersek@gmail.com

18 edits in trunk/Source/WebCore

Move the webdatabase module source code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=127278

Reviewed by Antti Koivisto.

Replace the majority of OwnPtr uses in the webdatabase module with std::unique_ptr.
The only remaining uses are due to ScriptExecutionContext::Task subclasses.

Modules/webdatabase/AbstractSQLTransactionBackend.h:
Modules/webdatabase/Database.cpp:
Modules/webdatabase/DatabaseTask.h:
Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::DatabaseThread):

Modules/webdatabase/DatabaseThread.h:
Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):

Modules/webdatabase/DatabaseTracker.h:
Modules/webdatabase/OriginLock.cpp:
Modules/webdatabase/SQLStatement.cpp:
Modules/webdatabase/SQLStatement.h:
Modules/webdatabase/SQLStatementBackend.cpp:

(WebCore::SQLStatementBackend::create):
(WebCore::SQLStatementBackend::SQLStatementBackend):

Modules/webdatabase/SQLStatementBackend.h:
Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSQL):

Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::cleanupAfterTransactionErrorCallback):

Modules/webdatabase/SQLTransactionBackend.h:
Modules/webdatabase/SQLTransactionBackendSync.cpp:

(WebCore::SQLTransactionBackendSync::SQLTransactionBackendSync):
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::commit):
(WebCore::SQLTransactionBackendSync::rollback):

Modules/webdatabase/SQLTransactionBackendSync.h:

10:52 AM Changeset in webkit [163316] by akling@apple.com

4 edits in trunk/Source/WebCore

CTTE: Grab bag of SVGRenderTreeAsText cleanups.
<https://webkit.org/b/128099>

Made some of the DRT SVG functions take more specific types than
RenderObject. Removed some redundant casts.

Reviewed by Anders Carlsson.

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/svg/SVGRenderTreeAsText.h:
rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):
(WebCore::writeSVGContainer):

Make writeSVGResourceContainer() and writeSVGContainer() take the
final type instead of RenderObject.

(WebCore::writeStyle):
(WebCore::writePositionAndStyle):

Make these take RenderElement instead of RenderObject.

(WebCore::writeChildren):

Use child renderer iterator.

(WebCore::writeResources):

Remove unnecessary cast.

10:38 AM Changeset in webkit [163315] by Darin Adler

6 edits
5 deletes in trunk/Source/WTF

Remove Unicode.h
https://bugs.webkit.org/show_bug.cgi?id=128106

Reviewed by Anders Carlsson.

GNUmakefile.list.am: Removed files.
WTF.vcxproj/WTF.vcxproj: Ditto.
WTF.vcxproj/WTF.vcxproj.filters: Ditto.
WTF.xcodeproj/project.pbxproj: Ditto.
wtf/CMakeLists.txt: Ditto.

wtf/unicode/ScriptCodesFromICU.h: Removed.
wtf/unicode/Unicode.h: Removed.
wtf/unicode/UnicodeMacrosFromICU.h: Removed.
wtf/unicode/icu/UnicodeIcu.h: Removed.
wtf/unicode/wchar/UnicodeWchar.cpp: Removed.
wtf/unicode/wchar/UnicodeWchar.h: Removed.

10:37 AM Changeset in webkit [163314] by dbates@webkit.org

3 edits in trunk/Tools

WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when
iteration fails to load with HTTP 401 status code
https://bugs.webkit.org/show_bug.cgi?id=128077

Reviewed by Alexey Proskuryakov.

Similar to the fix for <https://bugs.webkit.org/show_bug.cgi?id=127849>, we should only prompt for
the HTTP credentials of a build bot so long as an earlier authentication request wasn't cancelled
(i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
presented for an iteration each time the update queue timer fires until a person successfully
authenticates. Instead we should update the authentication status of the build bot on receiving an
HTTP 401 response code such that we defer subsequent requests to load any resource from the access-
restricted build bot when the queue update timer fires.

A person must explicitly click the "unauthorized" status line shown for the queue associated with the
iteration in the dashboard and authenticate successfully for the iteration to be loaded once an
authentication request for an iteration is cancelled.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.update): Early return if the associated Buildbot was given invalid credentials.
Also notify the associated Buildbot and update the queue view when a load failed with an HTTP 401 status code.
(BuildbotIteration.prototype.loadLayoutTestResults): Ditto.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView): Modified to call BuildbotQueueView.prototype._unauthorizedAccess instead of
QueueView.prototype._updateSoon when event BuildbotQueue.Event.UnauthorizedAccess is received.
(BuildbotQueueView.prototype._unauthorizedAccess): Added.

10:08 AM Changeset in webkit [163313] by dbates@webkit.org

2 edits in trunk/Tools

WebKit Bot Watcher's Dashboard: Teach JSON.load() to interpret third argument as either an
option dictionary or a failure callback
https://bugs.webkit.org/show_bug.cgi?id=128080

Reviewed by Alexey Proskuryakov.

Currently JSON.load() takes a failure callback function as its third argument and
an option dictionary as its fourth argument. So, a caller that wants to ignore errors
and pass an option dictionary must pass null or a reference to an empty function for
the value of third argument. Instead, we should make the third argument polymorphic for
convenience. Then a caller can either pass a failure callback function or an option dictionary.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:

9:39 AM Changeset in webkit [163312] by Darin Adler

2 edits in trunk/Source/WebKit/win

Try to fix the WinCairo build.

WebDownloadCurl.cpp:

(WebDownload::didReceiveResponse): characters -> deprecatedCharacters.

9:39 AM Changeset in webkit [163311] by Darin Adler

1 edit in trunk/Source/WebKit2/ChangeLog

Try to fix 32-bit Mac build.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::convertStringToKeyCodes): Use deprecatedCharacters.

9:30 AM Changeset in webkit [163310] by Darin Adler

70 edits in trunk/Source

Stop using Unicode.h
https://bugs.webkit.org/show_bug.cgi?id=127633

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

parser/Lexer.h:
runtime/JSGlobalObjectFunctions.h:
yarr/YarrCanonicalizeUCS2.h:
yarr/YarrInterpreter.h:
yarr/YarrParser.h:
yarr/YarrPattern.h:

Removed includes of <wtf/unicode/Unicode.h>, adding includes of
ICU headers and <wtf/text/LChar.h> as needed to replace it.

Source/WebCore:

Modules/indexeddb/IDBKeyPath.cpp:
css/CSSFontFace.h:
css/CSSOMUtils.h:
css/CSSSegmentedFontFace.h:
css/CSSUnicodeRangeValue.h:
editing/Editor.cpp:
editing/SmartReplace.h:
html/parser/HTMLTokenizer.cpp:
loader/DocumentLoader.cpp:
page/ContextMenuController.cpp:
page/Settings.h:
platform/DateComponents.h:
platform/SharedBuffer.cpp:
platform/graphics/Color.h:
platform/graphics/FontCache.h:
platform/graphics/FontData.h:
platform/graphics/FontDescription.h:
platform/graphics/FontFastPath.cpp:
platform/graphics/FontGenericFamilies.h:
platform/graphics/FontGlyphs.cpp:
platform/graphics/GlyphMetricsMap.h:
platform/graphics/GlyphPage.h:
platform/graphics/GlyphPageTreeNode.cpp:
platform/graphics/GlyphPageTreeNode.h:
platform/graphics/SVGGlyph.cpp:
platform/graphics/WidthIterator.h:
platform/graphics/freetype/SimpleFontDataFreeType.cpp:
platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
platform/graphics/mac/ComplexTextController.h:
platform/graphics/win/QTMovie.h:
platform/graphics/wince/FontWinCE.cpp:
platform/text/BidiContext.h:
platform/text/Hyphenation.h:
platform/text/LocaleToScriptMapping.h:
platform/text/TextBoundaries.cpp:
platform/text/TextBoundaries.h:
platform/text/TextBreakIterator.h:
platform/text/TextCodec.h:
platform/text/TextEncoding.h:
platform/text/TextEncodingRegistry.h:
platform/text/TextStream.h:
platform/text/icu/UTextProvider.h:
platform/text/icu/UTextProviderLatin1.h:
platform/text/icu/UTextProviderUTF16.h:
platform/text/wchar/TextBreakIteratorWchar.cpp:
platform/win/WebCoreTextRenderer.cpp:
rendering/RootInlineBox.cpp:
rendering/SimpleLineLayout.cpp:
rendering/SimpleLineLayoutFunctions.cpp:
rendering/break_lines.h:
svg/SVGFontData.cpp:

Removed includes of <wtf/unicode/Unicode.h>, adding includes of
ICU headers and <wtf/text/LChar.h> as needed to replace it.

Source/WTF:

wtf/StringHasher.h:
wtf/dtoa.h:
wtf/text/ASCIIFastPath.h:
wtf/text/LChar.h:
wtf/text/StringBuffer.h:
wtf/text/StringImpl.h:
wtf/text/WTFString.cpp:
wtf/unicode/CharacterNames.h:
wtf/unicode/Collator.h:
wtf/unicode/UTF8.h:

Removed includes of <wtf/unicode/Unicode.h>, adding includes of
ICU headers and <wtf/text/LChar.h> as needed to replace it.

9:23 AM Changeset in webkit [163309] by jberlin@webkit.org

9 edits
6 deletes in trunk

Revert r163299 since it broke the ML 32-bit Release build

Source/WebCore:

html/HTMLAnchorElement.cpp:

(WebCore::parsePortFromStringPosition):
(WebCore::HTMLAnchorElement::hash):
(WebCore::HTMLAnchorElement::setHash):
(WebCore::HTMLAnchorElement::host):
(WebCore::HTMLAnchorElement::setHost):
(WebCore::HTMLAnchorElement::hostname):
(WebCore::HTMLAnchorElement::setHostname):
(WebCore::HTMLAnchorElement::pathname):
(WebCore::HTMLAnchorElement::setPathname):
(WebCore::HTMLAnchorElement::port):
(WebCore::HTMLAnchorElement::setPort):
(WebCore::HTMLAnchorElement::protocol):
(WebCore::HTMLAnchorElement::setProtocol):
(WebCore::HTMLAnchorElement::search):
(WebCore::HTMLAnchorElement::origin):
(WebCore::HTMLAnchorElement::setSearch):
(WebCore::HTMLAnchorElement::toString):

html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/URLUtils.idl:

LayoutTests:

fast/dom/HTMLAnchorElement/anchor-password-expected.txt: Removed.
fast/dom/HTMLAnchorElement/anchor-password.html: Removed.
fast/dom/HTMLAnchorElement/anchor-username-expected.txt: Removed.
fast/dom/HTMLAnchorElement/anchor-username.html: Removed.
fast/dom/HTMLAreaElement/area-password.html: Removed.
fast/dom/HTMLAreaElement/area-username.html: Removed.
js/dom/dom-static-property-for-in-iteration-expected.txt:
js/dom/dom-static-property-for-in-iteration.html:

6:51 AM Changeset in webkit [163308] by Lucas Forschler

5 edits in trunk/Source

Versioning.

6:48 AM Changeset in webkit [163307] by Lucas Forschler

1 copy in tags/Safari-538.16

New Tag.

6:38 AM Changeset in webkit [163306] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r163174 - Don't allocate a new XMLHttpRequestStaticData every time staticData() is called
https://bugs.webkit.org/show_bug.cgi?id=127996

Reviewed by Andreas Kling.

std::once_flag should be static.

xml/XMLHttpRequest.cpp:

(WebCore::staticData):

6:34 AM Changeset in webkit [163305] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.4/Source/WebInspectorUI

Merge r163086 - Web Inspector: Implement open/close Console window shortcut
https://bugs.webkit.org/show_bug.cgi?id=127896

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-01-30
Reviewed by Timothy Hatcher.

UserInterface/KeyboardShortcut.js:

(WebInspector.KeyboardShortcut.prototype.get displayName):
Bug: Option symbol should be displayed as Alternative symbol (\u2387)
in non Mac platforms.

UserInterface/Main.js:

(WebInspector.contentLoaded):
Create keyboard shortcut for toggling console window.

6:32 AM Changeset in webkit [163304] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r163081 - [SOUP] Fix the build if !ENABLE(WEB_TIMING)
https://bugs.webkit.org/show_bug.cgi?id=127906

Reviewed by Gustavo Noronha Silva.

platform/network/soup/SoupNetworkSession.cpp:

6:22 AM Changeset in webkit [163303] by Carlos Garcia Campos

16 edits in releases/WebKitGTK/webkit-2.4

Merge r163072 - Remove ENABLE(JAVASCRIPT_DEBUGGER) leftovers
https://bugs.webkit.org/show_bug.cgi?id=127845

Reviewed by Joseph Pecoraro.

Source/autotools/SetupWebKitFeatures.m4:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

5:54 AM Changeset in webkit [163302] by commit-queue@webkit.org

3 edits
2 adds in trunk

[CSS Regions] Fix selection and hover effect of content in region with overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=127101

Patch by Mihai Maerean <Mihai Maerean> on 2014-02-03
Reviewed by Mihnea Ovidenie.

Source/WebCore:

RenderNamedFlowFragments are not hit candidates. The hit test algorithm will pick the
parent layer, the one of the region.

Test: fast/regions/hover-overflow-hidden.html

rendering/RenderLayer.cpp:

(WebCore::isHitCandidate):

LayoutTests:

fast/regions/hover-overflow-hidden.html: Added.
fast/regions/hover-overflow-hidden-expected.html: Added.

5:43 AM Changeset in webkit [163301] by Carlos Garcia Campos

12 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r163037 - Consolidate page loading functions
https://bugs.webkit.org/show_bug.cgi?id=127847

Reviewed by Tim Horton.

Get rid of the loadURL functions (and the LoadURL message), rename
loadURLRequest to loadRequest and change it to take a ResourceRequest instead
of an API::URLRequest.

UIProcess/API/C/WKPage.cpp:

(WKPageLoadURL):
(WKPageLoadURLWithUserData):
(WKPageLoadURLRequest):
(WKPageLoadURLRequestWithUserData):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadRequest:userData:]):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadRequest:]):

UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_uri):
(webkit_web_view_load_request):

UIProcess/WebInspectorProxy.cpp:

(WebKit::decidePolicyForNavigationAction):
(WebKit::WebInspectorProxy::createInspectorPage):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):

UIProcess/WebPageProxy.h:
UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::restoreFromSessionStateData):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadRequest):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

5:23 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

4:48 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

4:45 AM WebKitGTK/2.4.x created by Carlos Garcia Campos

4:13 AM Changeset in webkit [163300] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.4

Branch WebKitGTK+ for 2.4

3:13 AM Changeset in webkit [163299] by mjs@apple.com

9 edits
6 adds in trunk

Adopt URLUtils interface and template in HTMLAnchorElement and HTMLAreaElement
https://bugs.webkit.org/show_bug.cgi?id=128067

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/dom/HTMLAnchorElement/anchor-password.html

fast/dom/HTMLAnchorElement/anchor-username.html
fast/dom/HTMLAreaElement/area-password.html
fast/dom/HTMLAreaElement/area-username.html

html/HTMLAnchorElement.cpp:
html/HTMLAnchorElement.h:

(WebCore::HTMLAnchorElement::setHref): Add version that takes
(and ignores) ExceptionCode. This is needed because the URLUtil
base interface is used for URL, which can throw an exception,
and HTMLAnchorElement, which cannot.

html/HTMLAnchorElement.idl: implement URLUtils
html/HTMLAreaElement.idl: implement URLUtils
html/URLUtils.idl: Treat null as empty string for href

LayoutTests:

New tests for the newly added attributes.

fast/dom/HTMLAnchorElement/anchor-password-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-password.html: Added.
fast/dom/HTMLAnchorElement/anchor-username-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-username.html: Added.
fast/dom/HTMLAreaElement/area-password.html: Added.
fast/dom/HTMLAreaElement/area-username.html: Added.

Update a test to handle the new anchor properties.

js/dom/dom-static-property-for-in-iteration-expected.txt:
js/dom/dom-static-property-for-in-iteration.html:

2:05 AM Changeset in webkit [163298] by k.czech@samsung.com

2 edits in trunk/Source/WebKit2

Build fix after r163289.

Unreviewed EFL build fix.

Use deprecatedCharacters.

UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::requestCheckingOfString):

1:31 AM Changeset in webkit [163297] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::convertStringToKeyCodes):

1:16 AM Changeset in webkit [163296] by k.czech@samsung.com

19 edits
2 adds in trunk

[ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
https://bugs.webkit.org/show_bug.cgi?id=127908

Reviewed by Chris Fleizach.

Source/WebCore:

Based on w3c, aria-controls could be exposed through ATK_RELATION_CONTROLLER_FOR.

Test: accessibility/aria-controls.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::supportsARIAControls):
(WebCore::AccessibilityObject::ariaControlsElements):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
(WebCore::AccessibilityRenderObject::supportsARIAControls):
(WebCore::AccessibilityRenderObject::ariaControlsElements):

accessibility/AccessibilityRenderObject.h:
accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkRelationSetFromCoreObject):

Tools:

Updated AccessibilityUIElement both in WKTR and DRT so that aria-controls support could be tested properly.
Added empty stubs to not break mac builds.

DumpRenderTree/AccessibilityUIElement.cpp:

(ariaControlsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(accessibilityElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::ariaControlsElementAtIndex):

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::ariaControlsElementAtIndex):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::ariaControlsElementAtIndex):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::ariaControlsElementAtIndex):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::accessibilityElementAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):

WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::ariaControlsElementAtIndex):

LayoutTests:

Tests whether aria-controls returns correct element at the given index.

accessibility/aria-controls-expected.txt: Added.
accessibility/aria-controls.html: Added.
platform/mac/TestExpectations: Skipped it, missing implementation.

1:02 AM Changeset in webkit [163295] by akling@apple.com

19 edits in trunk/Source/WebCore

RenderSVGResource::removeClientFromCache() should take RenderElement&.
<https://webkit.org/b/128097>

Text renderers never have resources associated with them.
This is yet another step towards enforcing that at compile-time
by making all the resource cache interfaces deal in RenderElement.

Also marked the RenderSVGResourceSolidColor class final.

Reviewed by Darin Adler.

rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):
(WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation):

rendering/svg/RenderSVGResource.h:
rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::removeClientFromCache):

rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::removeClientFromCache):

rendering/svg/RenderSVGResourceFilter.h:
rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::removeClientFromCache):

rendering/svg/RenderSVGResourceGradient.h:
rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::removeClientFromCache):

rendering/svg/RenderSVGResourceMarker.h:
rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::removeClientFromCache):

rendering/svg/RenderSVGResourceMasker.h:
rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::removeClientFromCache):

rendering/svg/RenderSVGResourcePattern.h:
rendering/svg/RenderSVGResourceSolidColor.h:
rendering/svg/SVGRenderSupport.cpp:

(WebCore::invalidateResourcesOfChildren):
(WebCore::SVGRenderSupport::layoutChildren):

rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::removeClientFromCache):

rendering/svg/SVGResources.h:

12:41 AM Changeset in webkit [163294] by mitz@apple.com

6 edits in trunk/Source

More iOS build fixing.

Source/WebCore:

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::linkifyPhoneNumbers):

page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot):

Source/WebKit/ios:

Misc/WebNSStringDrawing.mm:

(-[NSString web_drawAtPoint:forWidth:withFont:ellipsis:letterSpacing:includeEmoji:measureOnly:renderedStringOut:drawUnderline:]):
(-[NSString web_drawInRect:withFont:ellipsis:alignment:letterSpacing:lineSpacing:includeEmoji:truncationRect:measureOnly:renderedStringOut:drawUnderline:]):

12:27 AM Changeset in webkit [163293] by mitz@apple.com

2 edits in trunk/Source/JavaScriptCore

Correctly address Darin’s review comment on the last change.

runtime/Watchdog.h: Changed an OS(DARWIN) guard around formerly PLATFORM(MAC)-only member

variables to the equivalent OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK).

12:19 AM Changeset in webkit [163292] by berto@igalia.com

3 edits in trunk/Source/WebKit2

Fix wrong mix of fcntl commands and flags
https://bugs.webkit.org/show_bug.cgi?id=127842

Reviewed by Darin Adler.

We are mixing the commands to set file descriptor and file status
flags in a couple of fcntl() calls. FD_CLOEXEC must be set using
F_SETFD, and the access mode flags (O_RDONLY, O_WRONLY, O_RDWR)
with F_SETFL.

This combines patches by Guillem Jover and Sergio Correia.

Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::readBytesFromSocket):

Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::createHandle):

12:17 AM Changeset in webkit [163291] by mitz@apple.com

5 edits in trunk/Source/JavaScriptCore

Stop using PLATFORM(MAC) in JavaScriptCore except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128098

Reviewed by Darin Adler.

API/JSValueRef.cpp:

(JSValueUnprotect): Added an explicit !PLATFORM(IOS) in guards for the Evernote workaround,
which is only needed on OS X.

API/tests/testapi.c:

(main): Changed PLATFORM(MAC)

PLATFORM(IOS) guards to OS(DARWIN), because they were

surrounding tests for code that is itself guarded by OS(DARWIN).

runtime/Watchdog.h: Changed PLATFORM(MAC) to OS(DARWIN).

tools/CodeProfiling.cpp:

(JSC::CodeProfiling::begin): Changed PLATFORM(MAC) to
OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK).
(JSC::CodeProfiling::end): Ditto.

12:10 AM Changeset in webkit [163290] by Darin Adler

2 edits in trunk/Source/WebCore

Try to fix iOS build.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::parseToDateComponents):
Use deprecatedCharacters.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed