Timeline
Feb 17, 2014:
- 11:53 PM Changeset in webkit [164275] by
-
- 6 edits in trunk/Source/WebCore
[CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=128914
Reviewed by Antti Koivisto.
Moved named flow specific methods regionContainer() and regionContainerLayer() from
RenderRegion to RenderNamedFlowFragment and renamed them to fragmentContainer and
fragmentContainerLayer.
No new tests required.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::fragmentContainer):
(WebCore::RenderNamedFlowFragment::fragmentContainerLayer):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderRegion.cpp:
- rendering/RenderRegion.h:
- 11:17 PM Changeset in webkit [164274] by
-
- 4 edits in trunk/Source/WebCore
Move PublicURLMansger to std::unique_ptr.
https://bugs.webkit.org/show_bug.cgi?id=128891
Patch by Sangho Kim <thomas.kim@lge.com> on 2014-02-17
Reviewed by Anders Carlsson.
Use std::unique_ptr and std::make_unique in place of PassOwnPtr and adoptPtr in the PublicURLManager
- dom/ScriptExecutionContext.h:
- html/PublicURLManager.cpp:
(WebCore::PublicURLManager::create):
- html/PublicURLManager.h:
- 10:51 PM Changeset in webkit [164273] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed gtk build fix.
- GNUmakefile.list.am: Remove WebHistoryClient.cpp/h after r164230.
- 9:18 PM Changeset in webkit [164272] by
-
- 15 edits in trunk/Source
Expose a way to clear cookies modified after a given date
https://bugs.webkit.org/show_bug.cgi?id=128845
Patch by Ricky Mondello <Ricky Mondello> on 2014-02-17
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- WebCore.exp.in: Add a symbol.
- platform/network/PlatformCookieJar.h: Declare deleteAllCookiesModifiedAfterDate.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Add a stub.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Ditto.
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::deleteAllCookiesModifiedAfterDate): Ditto.
- platform/network/mac/CookieJarMac.mm: Add a category NSHTTPCookieStorage category with the method
used for time-based clearing so we can build on all platforms. For now, we'll check for support
at runtime.
(WebCore::deleteAllCookiesModifiedAfterDate): Added. Without foundation API, we'll ignore the passed-in
NetworkStorageSession.
Source/WebKit2:
- UIProcess/API/C/WKCookieManager.cpp:
(WKCookieManagerDeleteAllCookiesModifiedAfterDate): Added. Call out to the CookieManager.
- UIProcess/API/C/WKCookieManager.h: Declare WKCookieManagerDeleteAllCookiesModifiedAfterDate.
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedAfterDate): Added. Dispatch message to the
Network Process.
- UIProcess/WebCookieManagerProxy.h: Declare deleteAllCookiesModifiedAfterDate.
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::deleteAllCookiesModifiedAfterDate): Added. Call out to WebCore to finish the job.
- WebProcess/Cookies/WebCookieManager.h: Declare deleteAllCookiesModifiedAfterDate.
- WebProcess/Cookies/WebCookieManager.messages.in: Add new message.
- 9:13 PM Changeset in webkit [164271] by
-
- 18 edits3 copies4 moves1 add in trunk/Source/WebKit2
[EFL][WK2] Move and make WKColorPickerResultListener to EFL specific interface
https://bugs.webkit.org/show_bug.cgi?id=119120
Reviewed by Gyuyoung Kim.
WKColorPickerResultListener and related files are only used in EFL since added.
Indeed, it does not work since refactored common logic for ColorPicker in WebPageProxy.
This patch moved them to EFL specfic and refactor to work well.
- CMakeLists.txt: Moved WebColorPickerResultListenerProxy.cpp to PlatformEfl.cmake.
- GNUmakefile.list.am: Removed ColorPickerResultListener related files which are only for Efl from source list.
- PlatformEfl.cmake: Added ColorPickerResultListenerProxy related files and newly added files into source list.
- UIProcess/API/APIUIClient.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageUIClient):
- UIProcess/API/C/efl/WKColorPickerResultListener.cpp: Renamed from Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.cpp.
(WKColorPickerResultListenerGetTypeID):
(WKColorPickerResultListenerSetColor):
- UIProcess/API/C/efl/WKColorPickerResultListener.h: Renamed from Source/WebKit2/UIProcess/API/C/WKColorPickerResultListener.h.
- UIProcess/API/C/efl/WKViewEfl.cpp: Introduced WKColorPickerClient and setter.
(WKViewSetColorPickerClient):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/API/efl/tests/test_ewk2_color_picker.cpp: Enabled test case for color picker.
(TEST_F):
- UIProcess/WebPageProxy.cpp: Removed unnecessary WebColorPickerResultListenerProxy dependency.
- UIProcess/WebPageProxy.h: Ditto.
- UIProcess/efl/PageUIClientEfl.cpp: Removed color picker callbacks of PageUIClient.
(WebKit::PageUIClientEfl::PageUIClientEfl):
- UIProcess/efl/PageUIClientEfl.h:
- UIProcess/efl/ViewClientEfl.cpp: Registered callbacks of WKColorPickerClient.
(WebKit::ViewClientEfl::showColorPicker):
(WebKit::ViewClientEfl::endColorPicker):
(WebKit::ViewClientEfl::ViewClientEfl):
(WebKit::ViewClientEfl::~ViewClientEfl):
- UIProcess/efl/ViewClientEfl.h:
- UIProcess/efl/WebColorPickerClient.cpp: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerClient::showColorPicker):
(WebKit::WebColorPickerClient::endPicker):
- UIProcess/efl/WebColorPickerClient.h: Added.
- UIProcess/efl/WebColorPickerEfl.cpp: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerEfl::WebColorPickerEfl):
(WebKit::WebColorPickerEfl::endPicker):
(WebKit::WebColorPickerEfl::showColorPicker):
(WebKit::WebColorPickerEfl::setSelectedColor):
(WebKit::WebColorPickerEfl::didChooseColor):
- UIProcess/efl/WebColorPickerEfl.h: Copied from Source/WebKit2/UIProcess/efl/ViewClientEfl.h.
(WebKit::WebColorPickerEfl::create):
(WebKit::WebColorPickerEfl::~WebColorPickerEfl):
- UIProcess/efl/WebColorPickerResultListenerProxy.cpp: Renamed from Source/WebKit2/UIProcess/WebColorPickerResultListenerProxy.cpp.
(WebKit::WebColorPickerResultListenerProxy::WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::~WebColorPickerResultListenerProxy):
(WebKit::WebColorPickerResultListenerProxy::invalidate):
(WebKit::WebColorPickerResultListenerProxy::setColor):
- UIProcess/efl/WebColorPickerResultListenerProxy.h: Renamed from Source/WebKit2/UIProcess/WebColorPickerResultListenerProxy.h.
(WebKit::WebColorPickerResultListenerProxy::create):
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::initializeColorPickerClient):
(WebKit::WebViewEfl::createColorPicker):
- UIProcess/efl/WebViewEfl.h:
(WebKit::WebViewEfl::colorPickerClient):
- WebKit2.xcodeproj/project.pbxproj: Removed ColorPickerResultListener related files which are only for Efl from source list.
- 8:59 PM Changeset in webkit [164270] by
-
- 9 edits in trunk/Tools
Stop using PLATFORM(MAC) in DumpRenderTree except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128950
Reviewed by Anders Carlsson.
Changed all PLATFORM(MAC) instances that were not excluding iOS to PLATFORM(COCOA).
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityTextMarker.h:
- DumpRenderTree/AccessibilityUIElement.cpp:
- DumpRenderTree/AccessibilityUIElement.h:
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(computeMD5HashStringForBitmapContext):
- DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::~BitmapContext):
- DumpRenderTree/config.h:
- 8:20 PM Changeset in webkit [164269] by
-
- 12 edits1 delete in trunk
More ARM FTL glue
https://bugs.webkit.org/show_bug.cgi?id=128948
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- Configurations/Base.xcconfig: Allow for an header search directory for LLVM's generated files.
- Configurations/LLVMForJSC.xcconfig: Link the right things for ARM.
- assembler/ARM64Assembler.h: Builds fix.
(JSC::ARM64Assembler::fillNops):
- disassembler/LLVMDisassembler.cpp: Use the right target triples.
(JSC::tryToDisassembleWithLLVM):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps): Build fix.
- jit/GPRInfo.h: Builds fix.
- llvm/library/LLVMExports.cpp: Link the right things.
(initializeAndGetJSCLLVMAPI):
Source/WTF:
- wtf/Platform.h:
Tools:
- Scripts/configure-llvm: Removed. This isn't really practical now that we require a separate build directory.
- Scripts/copy-webkitlibraries-to-product-directory: Switch to using a separate build directory, and for setting a PATH before running LLVM's make.
- 8:10 PM Changeset in webkit [164268] by
-
- 3 edits2 adds in trunk
SelectorCompiler incorrectly saves a backtracking register for a child chain without descendant relation on the right
https://bugs.webkit.org/show_bug.cgi?id=128944
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-17
Reviewed by Andreas Kling.
Source/WebCore:
When resolving the backtracking relations, the value of ancestorPositionSinceDescendantRelation was incorrect for the
rightmost child chain.
What was happenning is updateChainStates() would increment ancestorPositionSinceDescendantRelation even if there was
no descendant relation previously in the chain. As a result, the second SelectorFragment in the fragment chain would
save a backtracking register.
Previously this would just be a wasted register but since r163850, the number of registers available for compilation
is defined by SelectorCompiler::minimumRegisterRequirements(). Since we would have one less register available than computed,
we could run out of register and RegisterAllocator would invoke WTFCrash to avoid generating incorrect code.
This patch fixes the issue by not updating ancestorPositionSinceDescendantRelation until the first descendant relation
is seen. There was no need to fix the Adjacent relation because adjacentPositionSinceIndirectAdjacentTreeWalk already
had the correct guard.
Test: fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::updateChainStates):
(WebCore::SelectorCompiler::isFirstAdjacent): The name was a bad copy-paste, fix it.
LayoutTests:
- fast/selectors/querySelector-rightmost-child-chain-attribute-matching-expected.txt: Added.
- fast/selectors/querySelector-rightmost-child-chain-attribute-matching.html: Added.
- 7:50 PM Changeset in webkit [164267] by
-
- 4 edits in trunk/Source/WebKit2
[iOS, WebKit2] Add settings and correct default values for settings important on iOS
https://bugs.webkit.org/show_bug.cgi?id=128947
Reviewed by Simon Fraser.
- Shared/WebPreferencesStore.cpp:
- Shared/WebPreferencesStore.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 6:50 PM Changeset in webkit [164266] by
-
- 9 edits in trunk
[CoordinatedGraphics][EFL] Remove view_source functions.
https://bugs.webkit.org/show_bug.cgi?id=128945
Reviewed by Anders Carlsson.
EFL port has been broken since r164254 because of removing view source files in WK2.
This patch is to follow to remove remained view source functions.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/efl/ewk_view.cpp:
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
- UIProcess/CoordinatedGraphics/WebView.cpp:
- UIProcess/CoordinatedGraphics/WebView.h:
- 6:31 PM Changeset in webkit [164265] by
-
- 4 edits9 adds in trunk
Constrain replaced element layout to from-intrinsic aspect ratio if specified
https://bugs.webkit.org/show_bug.cgi?id=128629
Reviewed by Simon Fraser.
Source/WebCore:
First pass at implementing -webkit-aspect-ratio: from-instrinsics;
After RenderReplaced has done layout, attempt to update the
resulting size to match the desired aspect ratio. This step
will only reduce the size of an element, and never below the
minimum dimensions.
Tests: fast/css/aspect-ratio/columns.html
fast/css/aspect-ratio/containers.html
fast/css/aspect-ratio/simple.html
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged): If we get an update
to our intrinsic dimensions, and layout depends on this, trigger
another layout pass.
- rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::layout): Implement the step described
above.
LayoutTests:
Three new tests that exercise aspect ratio on:
- normal content
- content that is constrained within a parent container
- content in columns (pages)
- fast/css/aspect-ratio/badchess-tall.png: Added.
- fast/css/aspect-ratio/badchess-wide.png: Added.
- fast/css/aspect-ratio/columns-expected.html: Added.
- fast/css/aspect-ratio/columns.html: Added.
- fast/css/aspect-ratio/containers-expected.html: Added.
- fast/css/aspect-ratio/containers.html: Added.
- fast/css/aspect-ratio/simple-expected.html: Added.
- fast/css/aspect-ratio/simple.html: Added.
- 6:03 PM Changeset in webkit [164264] by
-
- 5 edits in tags/Safari-538.16.7/Source
Versioning.
- 6:01 PM Changeset in webkit [164263] by
-
- 1 copy in tags/Safari-538.16.7
New Tag.
- 5:35 PM Changeset in webkit [164262] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- WebCore.exp.in:
- 5:32 PM Changeset in webkit [164261] by
-
- 8 edits in trunk/Source
Remove ENABLE_GLOBAL_FASTMALLOC_NEW
https://bugs.webkit.org/show_bug.cgi?id=127067
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- parser/Nodes.h:
Source/WebCore:
- platform/Timer.h:
Source/WTF:
Remove the global operator new/operator delete overrides. Having ALWAYS_INLINE operators
like we do is really undefined behavior according to the C++ standard and we've been lucky enough
to get away with it so far, but any code that calls operator new/operator delete inside from the C++ standard
library (not from headers that are included) will be mismatched and potentially crash. libc++ calls
delete in it's std::thread implementation for example.
The only supported way to override operator new and operator delete globally is to not use inline
functions, but that would mean that any application using WebKit would not be able to provide custom
operator new/operator delete functions so we'll just reuse the already existing infrastructure consisting
of the WTF_MAKE_FAST_ALLOCATED macro.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/FastMalloc.h:
- wtf/Platform.h:
- 4:56 PM Changeset in webkit [164260] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][wk2] Custom layers are sometimes put on-screen without being parented
https://bugs.webkit.org/show_bug.cgi?id=128935
<rdar://problem/16022336>
Reviewed by Sam Weinig.
- Platform/mac/LayerHostingContext.mm:
(WebKit::LayerHostingContext::createForExternalHostingProcess):
Give an explicit and unlikely display ID, so that the layer will never
be brought on-screen unless explicitly parented.
- 4:53 PM Changeset in webkit [164259] by
-
- 4 edits in trunk/Source/WebCore
Move iOS only Settings into Settings.in and make them not-iOS only
https://bugs.webkit.org/show_bug.cgi?id=128942
Reviewed by Tim Horton.
- page/Settings.cpp:
- page/Settings.h:
- page/Settings.in:
- 4:44 PM Changeset in webkit [164258] by
-
- 7 edits2 copies1 add in trunk/Source/WebKit2
Add history delegate to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=128930
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKHistoryDelegatePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
- UIProcess/API/Cocoa/WKProcessClass.mm:
(-[WKProcessClass initWithConfiguration:]):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _historyDelegate]):
(-[WKWebView _setHistoryDelegate:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/Cocoa/HistoryClient.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h.
- UIProcess/Cocoa/HistoryClient.mm: Added.
(WebKit::HistoryClient::HistoryClient):
(WebKit::HistoryClient::~HistoryClient):
(WebKit::HistoryClient::didNavigateWithNavigationData):
(WebKit::HistoryClient::didPerformClientRedirect):
(WebKit::HistoryClient::didPerformServerRedirect):
(WebKit::HistoryClient::didUpdateHistoryTitle):
(WebKit::HistoryClient::populateVisitedLinks):
(WebKit::HistoryClient::shouldTrackVisitedLinks):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::navigationStates):
(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::~NavigationState):
(WebKit::NavigationState::fromWebPage):
(WebKit::NavigationState::historyDelegate):
(WebKit::NavigationState::setHistoryDelegate):
(WebKit::NavigationState::didNavigateWithNavigationData):
(WebKit::NavigationState::didPerformClientRedirect):
(WebKit::NavigationState::didPerformServerRedirect):
(WebKit::NavigationState::didUpdateHistoryTitle):
- WebKit2.xcodeproj/project.pbxproj:
- 4:30 PM Changeset in webkit [164257] by
-
- 2 edits in trunk
[GTK] [CMake] JavaScriptCore crashes in JSC::eval
https://bugs.webkit.org/show_bug.cgi?id=128434
Reviewed by Anders Carlsson.
- Source/cmake/OptionsGTK.cmake: Add -fno-omit-frame-pointer to the GTK+ CMake
port as well as -fno-tree-dce, like it is used in the autotools build.
- 4:16 PM Changeset in webkit [164256] by
-
- 3 edits1 move1 add1 delete in trunk/Source/WebKit2
[WebKit2] Merge WebProcessMac and WebProcessIOS into WebProcessCocoa
https://bugs.webkit.org/show_bug.cgi?id=128939
Reviewed by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
Add/remove files/groups.
- WebProcess/WebProcess.h:
Change stopRunLoop() to be AppKit only.
- WebProcess/cocoa: Added.
- WebProcess/cocoa/WebProcessCocoa.mm: Copied from Source/WebKit2/WebProcess/mac/WebProcessMac.mm.
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeProcessName):
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::initializeSandbox):
(WebKit::WebProcess::updateActivePages):
- WebProcess/ios/WebProcessIOS.mm: Removed.
- WebProcess/mac/WebProcessMac.mm: Removed.
Copy mac/WebProcessMac.mm to cocoa/WebProcessCocoa.mm, and add #if USE(APPKIT) where appropriate.
- 4:08 PM Changeset in webkit [164255] by
-
- 22 edits in trunk/Source/WebKit2
Stop using isMainThread() in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=128940
<rdar://problem/15963666>
Reviewed by Enrica Casucci.
Since isMainThread() has a different meaning when the web thread is enabled on iOS,
just use RunLoop::isMain() to check if we're executing on the main thread.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::ensurePathExists):
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:
(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::shutdownBackingStore):
(WebKit::UniqueIDBDatabase::didShutdownBackingStore):
(WebKit::UniqueIDBDatabase::deleteDatabase):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::didOpenBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::didCompleteTransactionOperation):
(WebKit::UniqueIDBDatabase::changeDatabaseVersion):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::changeDatabaseVersionInBackingStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::clearObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::absoluteDatabaseDirectory):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::generateDatabaseId):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openSQLiteDatabaseAtPath):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getOrEstablishMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::establishTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::beginTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::commitTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::resetTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::rollbackTransaction):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::changeDatabaseVersion):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKeyNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::updateKeyGeneratorNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRange):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::count):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::openCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::iterateCursor):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::notifyCursorsOfChanges):
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::shared):
- NetworkProcess/HostRecord.cpp:
(WebKit::HostRecord::scheduleResourceLoader):
(WebKit::HostRecord::addLoaderInProgress):
(WebKit::HostRecord::removeLoader):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::removeLoader):
(WebKit::NetworkResourceLoadScheduler::receivedRedirect):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::willSendRequestAsync):
(WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync):
- NetworkProcess/NetworkResourceLoader.h:
(WebKit::NetworkResourceLoader::setHostRecord):
(WebKit::NetworkResourceLoader::hostRecord):
- NetworkProcess/mac/DiskCacheMonitor.mm:
(WebKit::DiskCacheMonitor::DiskCacheMonitor):
- Shared/AsyncRequest.cpp:
(WebKit::generateRequestID):
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::generateAuthenticationChallengeID):
(WebKit::AuthenticationManager::establishIdentifierForChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
- Shared/Downloads/mac/DownloadMac.mm:
(dispatchOnMainThread):
- Shared/Plugins/NPObjectProxy.cpp:
(WebKit::NPObjectProxy::~NPObjectProxy):
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
- Shared/SessionTracker.cpp:
(WebKit::staticSessionMap):
(WebKit::storageSessionToID):
(WebKit::identifierBase):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):
- UIProcess/APISession.cpp:
(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
- WebProcess/Cookies/WebCookieManager.cpp:
(WebKit::WebCookieManager::dispatchCookiesDidChange):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::open):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::generateServerConnectionIdentifier):
- WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::storageSession):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::dispatchWheelEvent):
- 3:53 PM Changeset in webkit [164254] by
-
- 43 edits7 deletes in trunk/Source
Remove view source code
https://bugs.webkit.org/show_bug.cgi?id=127233
Reviewed by Antti Koivisto.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- GNUmakefile.am:
- GNUmakefile.list.am:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::canExecuteScripts):
- css/CSSDefaultStyleSheets.cpp:
- css/CSSDefaultStyleSheets.h:
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):
(WebCore::DocumentRuleSets::collectFeatures):
- css/DocumentRuleSets.h:
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchUARules):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::appendAuthorStyleSheets):
(WebCore::StyleResolver::styleForElement):
- css/view-source.css: Removed.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
- dom/DOMImplementation.h:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
- html/HTMLAttributeNames.in:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
(WebCore::HTMLFrameElementBase::openURL):
- html/HTMLFrameElementBase.h:
- html/HTMLViewSourceDocument.cpp: Removed.
- html/HTMLViewSourceDocument.h: Removed.
- html/parser/HTMLToken.h:
- html/parser/HTMLViewSourceParser.cpp: Removed.
- html/parser/HTMLViewSourceParser.h: Removed.
- html/parser/TextViewSourceParser.cpp: Removed.
- html/parser/TextViewSourceParser.h: Removed.
- inspector/InspectorOverlayPage.css:
(.tag-name):
(.node-id):
(.class-name):
- loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::createDocument):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
- page/Frame.cpp:
(WebCore::Frame::Frame):
- page/Frame.h:
- xml/DOMParser.cpp:
(WebCore::DOMParser::parseFromString):
- xml/XMLViewer.css:
(.tag):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
Source/WebKit/mac:
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::inViewSourceMode):
(WebFrame::setInViewSourceMode):
- WebView.cpp:
(WebView::setInViewSourceMode):
(WebView::inViewSourceMode):
Source/WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:53 PM Changeset in webkit [164253] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening.
- platform/win/TestExpectations: Remove a few duplicate test statements, as well as
some removed test cases.
- 3:45 PM Changeset in webkit [164252] by
-
- 5 edits2 adds in trunk
box-shadows get truncated with a combination of transforms and clip: (affects Google Maps)
https://bugs.webkit.org/show_bug.cgi?id=128937
Source/WebCore:
Reviewed by Dean Jackson.
RenderLayer::calculateLayerBounds() incorrectly assumed that if localClipRect() returns
a non-infinite rect, that rect is OK to use as the compositing bounds.
That is not a valid assumption when clip() has a larger rect than the element (e.g.
with negative top/left in the rect). In that case, localClipRect() still just
returns the background rect, but we actually need a larger compositing layer
to show the unclipped parts of descendants.
Fix by detecting clip() that exceeds the renderer bounds, and when it does,
not early returning in the UseLocalClipRectIfPossible clause.
Test: compositing/geometry/css-clip-oversize.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::localClipRect): Do a convertToLayerCoords()
because we need offsetFromRoot later, and we can pass our value down to
calculateRects(). Compute clipExceedsBounds based on the CSS clip rect.
(WebCore::RenderLayer::calculateClipRects): Don't early return if clipExceedsBounds
is true.
- rendering/RenderLayer.h:
LayoutTests:
Reviewed by Dean Jackson.
Test with CSS clip() with a rect larger than the border box, and compositing.
- compositing/geometry/clip-expected.txt: New expectation. This is a progression.
- compositing/geometry/css-clip-oversize-expected.html: Added.
- compositing/geometry/css-clip-oversize.html: Added.
- 3:29 PM Changeset in webkit [164251] by
-
- 16 edits in trunk/Source/WebCore
Make TreeScope::rootNode return a reference
https://bugs.webkit.org/show_bug.cgi?id=128934
Reviewed by Andreas Kling.
It is never null.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
- dom/ContainerNode.h:
(WebCore::Node::isTreeScope):
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
(WebCore::DocumentOrderedMap::get):
(WebCore::DocumentOrderedMap::getAllElementsById):
- dom/EventDispatcher.cpp:
(WebCore::EventRelatedNodeResolver::moveToParentOrShadowHost):
(WebCore::eventTargetRespectingTargetRules):
(WebCore::shouldEventCrossShadowBoundary):
- dom/Node.cpp:
(WebCore::Node::containingShadowRoot):
(WebCore::Node::removedFrom):
- dom/ShadowRoot.h:
(WebCore::isShadowRoot):
- dom/TreeScope.h:
(WebCore::TreeScope::rootNode):
- page/DOMSelection.cpp:
(WebCore::DOMSelection::DOMSelection):
- page/DragController.cpp:
(WebCore::asFileInput):
- page/FocusController.cpp:
(WebCore::FocusNavigationScope::rootNode):
- 2:44 PM Changeset in webkit [164250] by
-
- 2 edits in trunk/Tools
[Win] There's another Windows SDK. Make sure we recognize it.
https://bugs.webkit.org/show_bug.cgi?id=128932
Reviewed by Tim Horton.
- Scripts/webkitpy/port/win.py:
(WinPort._ntsd_location):
- 2:26 PM Changeset in webkit [164249] by
-
- 3 edits2 adds in trunk
AX: Invalid cast in WebCore::AccessibilityTable::isDataTable (CRBug 280352)
<https://webkit.org/b/128925>
<rdar://problem/16087351>
Merged from Blink (patch by Dominic Mazzoni):
https://src.chromium.org/viewvc/blink?revision=159711&view=revision
Reviewed by Oliver Hunt.
Source/WebCore:
Don't cast to a table cell element unless we are sure it is one.
Test: accessibility/display-table-cell-causes-crash.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
LayoutTests:
- accessibility/display-table-cell-causes-crash-expected.txt: Added.
- accessibility/display-table-cell-causes-crash.html: Added.
- 2:12 PM Changeset in webkit [164248] by
-
- 19 edits in trunk/Source/WebCore
Node constructor should take Document reference
https://bugs.webkit.org/show_bug.cgi?id=128931
Reviewed by Geoff Garen.
- dom/Attr.cpp:
(WebCore::Attr::Attr):
- dom/CharacterData.h:
(WebCore::CharacterData::CharacterData):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/ContainerNode.h:
(WebCore::ContainerNode::ContainerNode):
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore::Node::Node):
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::DocumentFragment):
(WebCore::DocumentFragment::create):
- dom/DocumentFragment.h:
- dom/DocumentType.cpp:
(WebCore::DocumentType::DocumentType):
- dom/Element.h:
(WebCore::Element::Element):
- dom/Entity.h:
(WebCore::Entity::Entity):
- dom/EntityReference.cpp:
(WebCore::EntityReference::EntityReference):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::willBeDeletedFrom):
- dom/Node.h:
- dom/Notation.cpp:
- dom/Notation.h:
(WebCore::Notation::publicId):
(WebCore::Notation::systemId):
(WebCore::Notation::Notation):
Remove cruft from this non-instantiated class.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/TemplateContentDocumentFragment.h:
- 1:40 PM Changeset in webkit [164247] by
-
- 2 edits in trunk/Tools
webkitpy test fix on Mac after r164244.
It's somewhat crazy that we're trying to run unittests for Windows on Mac but whatever.
- Scripts/webkitpy/port/win.py:
(WinPort._ntsd_location):
- 12:58 PM Changeset in webkit [164246] by
-
- 3 edits in trunk/LayoutTests
Fix layout test added in r164232 to avoid bug 128929
and use rects which don't have minor rendering differences when
drawn into compositing layers.
- compositing/contents-opaque/opaque-with-clip-path-expected.html:
- compositing/contents-opaque/opaque-with-clip-path.html:
- 12:35 PM Changeset in webkit [164245] by
-
- 64 edits in trunk/Source
Replace uses of PassOwnPtr/OwnPtr with std::unique_ptr in WebCore/inspector
https://bugs.webkit.org/show_bug.cgi?id=128681
Reviewed by Timothy Hatcher.
Another step towards getting rid of PassOwnPtr/OwnPtr, now targeting
WebCore/inspector/*. Besides files in there, a few other files in
JavaScriptCore/inspector, WebKit/, WebKit2/WebProcess/WebCoreSupport/
and WebCore/testing were touched.
Source/JavaScriptCore:
- inspector/ContentSearchUtilities.cpp:
- inspector/ContentSearchUtilities.h:
- inspector/agents/InspectorConsoleAgent.cpp:
- inspector/agents/InspectorConsoleAgent.h:
Source/WebCore:
No new tests; no new behavior.
- WebCore.exp.in:
- inspector/CommandLineAPIHost.cpp:
- inspector/CommandLineAPIHost.h:
- inspector/DOMEditor.cpp:
- inspector/DOMPatchSupport.cpp:
- inspector/DOMPatchSupport.h:
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorCSSAgent.cpp:
- inspector/InspectorCSSAgent.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorDOMAgent.cpp:
- inspector/InspectorDOMAgent.h:
- inspector/InspectorDOMDebuggerAgent.h:
- inspector/InspectorDOMStorageAgent.h:
- inspector/InspectorDatabaseAgent.h:
- inspector/InspectorFrontendClientLocal.cpp:
- inspector/InspectorFrontendClientLocal.h:
- inspector/InspectorHeapProfilerAgent.h:
- inspector/InspectorHistory.cpp:
- inspector/InspectorHistory.h:
- inspector/InspectorIndexedDBAgent.h:
- inspector/InspectorInputAgent.h:
- inspector/InspectorLayerTreeAgent.h:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorMemoryAgent.h:
- inspector/InspectorOverlay.cpp:
- inspector/InspectorOverlay.h:
- inspector/InspectorProfilerAgent.cpp:
- inspector/InspectorProfilerAgent.h:
- inspector/InspectorResourceAgent.cpp:
- inspector/InspectorResourceAgent.h:
- inspector/InspectorStyleSheet.cpp:
- inspector/InspectorStyleSheet.h:
- inspector/InspectorTimelineAgent.h:
- inspector/InspectorWorkerAgent.cpp:
- inspector/PageConsoleAgent.cpp:
- inspector/PageRuntimeAgent.h:
- inspector/WebConsoleAgent.cpp:
- inspector/WorkerRuntimeAgent.h:
- testing/Internals.cpp:
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WebKit/efl:
- WebCoreSupport/InspectorClientEfl.cpp:
Source/WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.cpp:
Source/WebKit/ios:
- WebCoreSupport/WebInspectorClientIOS.mm:
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
- WebCoreSupport/WebInspectorClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
- 12:25 PM Changeset in webkit [164244] by
-
- 2 edits in trunk/Tools
[Win] Fall back to Windows symbol servers when necessary
https://bugs.webkit.org/show_bug.cgi?id=128926
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/port/win.py:
(WinPort):
(setup_crash_log_saving): Fall back to Microsoft Symbol Server when local symbols are
not specified.
- 12:23 PM Changeset in webkit [164243] by
-
- 6 edits2 adds in trunk/Source/JavaScriptCore
FTL should support ToPrimitive and the DFG should fold it correctly
https://bugs.webkit.org/show_bug.cgi?id=128892
Reviewed by Geoffrey Garen.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileToPrimitive):
- tests/stress/fold-to-primitive-in-cfa.js: Added.
(foo):
(.result.foo):
- tests/stress/fold-to-primitive-to-identity-in-cfa.js: Added.
(foo):
(.result.foo):
- 12:19 PM Changeset in webkit [164242] by
-
- 5 edits in trunk/Source/WebCore
Rename Document::m_selfOnlyRefCount to m_referencingNodeCount
https://bugs.webkit.org/show_bug.cgi?id=128916
Reviewed by Andreas Kling.
Make the name more informative. Also make it zero based (document is not considered to reference itself).
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::removedLastRef):
- dom/Document.h:
(WebCore::Document::increaseReferencingNodeCount):
(WebCore::Document::decreaseReferencingNodeCount):
(WebCore::Node::Node):
- dom/Node.cpp:
(WebCore::Node::~Node):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- 12:07 PM Changeset in webkit [164241] by
-
- 3 edits in trunk/Source/JavaScriptCore
Register preservation wrapper should know about the possibility of callee-saved FPRs
https://bugs.webkit.org/show_bug.cgi?id=128923
Reviewed by Mark Hahnenberg.
- jit/RegisterPreservationWrapperGenerator.cpp:
(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):
- jit/RegisterSet.cpp:
- 12:06 PM Changeset in webkit [164240] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed EFL build fix attempt
- CMakeLists.txt: Remove WebHistoryClient.cpp after r164230.
- 11:48 AM Changeset in webkit [164239] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build failure caused by missing jsmin module
https://bugs.webkit.org/show_bug.cgi?id=128742
Reviewed by Philippe Normand.
No new tests since no functionality changed.
- GNUmakefile.am: Relocate PYTHONPATH to make it meaningful.
- 11:46 AM HackingWebInspector edited by
- (diff)
- 11:45 AM Changeset in webkit [164238] by
-
- 2 edits in trunk/Source/JavaScriptCore
lr is a special register on ARM64
https://bugs.webkit.org/show_bug.cgi?id=128922
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::specialRegisters):
- 11:44 AM HackingWebInspector edited by
- (diff)
- 11:39 AM Changeset in webkit [164237] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix RegisterSet::calleeSaveRegisters() by making it correct on ARM64
https://bugs.webkit.org/show_bug.cgi?id=128921
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
- 11:39 AM HackingWebInspector edited by
- (diff)
- 11:36 AM Changeset in webkit [164236] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS selectors containing a color name shouldn't be considered for color editing
https://bugs.webkit.org/show_bug.cgi?id=128909
Reviewed by Joseph Pecoraro.
Disregard any text that might be contained within a CSS selector.
- UserInterface/CodeMirrorAdditions.js:
- 11:26 AM Changeset in webkit [164235] by
-
- 4 edits in trunk/Source
WebKitGTK+ should stop calling functions to set the view source mode
https://bugs.webkit.org/show_bug.cgi?id=128919
Reviewed by Carlos Garcia Campos.
This is a first step towards getting rid of the view source mode from WebCore.
View source shouldn't be a mode on the web page and can be implemented in other ways by
embedding apps. Furthermore, the inspector has an excellent view source mode.
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
(webkit_web_view_set_view_source_mode):
(webkit_web_view_get_view_source_mode):
Turn these into no-ops.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):
Turn these into no-ops.
- 11:22 AM Changeset in webkit [164234] by
-
- 3 edits2 adds in trunk
[CSS Regions] Make regions unsplittable
https://bugs.webkit.org/show_bug.cgi?id=128811
Reviewed by David Hyatt.
Source/WebCore:
At the moment, nested regions are not properly fragmented across regions. For the moment,
the regions will become unsplittable elements to avoid slicing. At a later time a proper
fragmentation algorithm should be written, also taking into consideration pagination strut.
Test: fast/regions/unsplittable-nested-region.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::isUnsplittableForPagination):
LayoutTests:
Added test for checking that nested regions are unsplittable.
- fast/regions/unsplittable-nested-region-expected.html: Added.
- fast/regions/unsplittable-nested-region.html: Added.
- 11:15 AM Changeset in webkit [164233] by
-
- 2 edits in trunk/Source/JavaScriptCore
RegisterSet::calleeSaveRegisters() should know about ARM64
https://bugs.webkit.org/show_bug.cgi?id=128918
Reviewed by Mark Hahnenberg.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
- 11:13 AM Changeset in webkit [164232] by
-
- 3 edits2 adds in trunk
Graphics buffer issue with clip-path and fixed positioned element
https://bugs.webkit.org/show_bug.cgi?id=126262
Source/WebCore:
Reviewed by Tim Horton.
If an element has a clip-path, backgroundIsKnownToBeOpaqueInRect() needs
to return false so that we don't try to make opaque compositing layers.
Test: compositing/contents-opaque/opaque-with-clip-path.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Tim Horton.
- compositing/contents-opaque/opaque-with-clip-path-expected.html: Added.
- compositing/contents-opaque/opaque-with-clip-path.html: Added.
- 11:10 AM Changeset in webkit [164231] by
-
- 5 edits10 adds in trunk
[CSS Regions] The box decorations of an element overflowing a region should be clipped at the border box, not the content box
https://bugs.webkit.org/show_bug.cgi?id=128815
Reviewed by Andrei Bucur.
Source/WebCore:
Elements flowed into a region should not be painted past the region's content box
if they continue to flow into another region in that direction.
If they do not continue into another region in that direction, they should be
painted all the way to the region's border box.
Regions with overflow:hidden will apply clip at the border box, not the content box.
Tests: fast/regions/box-decorations-over-region-padding-fragmented.html
fast/regions/box-decorations-over-region-padding-horiz-bt.html
fast/regions/box-decorations-over-region-padding-vert-lr.html
fast/regions/box-decorations-over-region-padding-vert-rl.html
fast/regions/box-decorations-over-region-padding.html
- rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::flowThreadPortionRectForClipping):
- rendering/RenderNamedFlowFragment.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::rectFlowPortionForBox):
LayoutTests:
Added tests for the painting of the borders of elements flowed into regions
over the region's padding area, for regions with overflow:hidden.
Tests were added for all writing modes.
- fast/regions/box-decorations-over-region-padding-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-fragmented-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-fragmented.html: Added.
- fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-horiz-bt.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-lr-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-lr.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-rl-expected.html: Added.
- fast/regions/box-decorations-over-region-padding-vert-rl.html: Added.
- fast/regions/box-decorations-over-region-padding.html: Added.
- 11:08 AM Changeset in webkit [164230] by
-
- 7 edits1 move1 delete in trunk/Source/WebKit2
Turn the history client into a fancy API::HistoryClient abstract base class
https://bugs.webkit.org/show_bug.cgi?id=128917
Reviewed by Andreas Kling.
- UIProcess/API/APIHistoryClient.h: Renamed from Source/WebKit2/UIProcess/WebHistoryClient.h.
(API::HistoryClient::~HistoryClient):
(API::HistoryClient::didNavigateWithNavigationData):
(API::HistoryClient::didPerformClientRedirect):
(API::HistoryClient::didPerformServerRedirect):
(API::HistoryClient::didUpdateHistoryTitle):
(API::HistoryClient::populateVisitedLinks):
(API::HistoryClient::shouldTrackVisitedLinks):
- UIProcess/API/C/WKContext.cpp:
(WKContextSetHistoryClient):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::setHistoryClient):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::populateVisitedLinks):
- UIProcess/WebContext.h:
(WebKit::WebContext::historyClient):
- UIProcess/WebHistoryClient.cpp: Removed.
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- 11:00 AM Changeset in webkit [164229] by
-
- 109 edits in trunk/Source/JavaScriptCore
Move back primary header includes next to config.h
https://bugs.webkit.org/show_bug.cgi?id=128912
Reviewed by Alexey Proskuryakov.
- dfg/DFGAbstractHeap.cpp:
- dfg/DFGAbstractValue.cpp:
- dfg/DFGArgumentsSimplificationPhase.cpp:
- dfg/DFGArithMode.cpp:
- dfg/DFGArrayMode.cpp:
- dfg/DFGAtTailAbstractState.cpp:
- dfg/DFGAvailability.cpp:
- dfg/DFGBackwardsPropagationPhase.cpp:
- dfg/DFGBasicBlock.cpp:
- dfg/DFGBinarySwitch.cpp:
- dfg/DFGBlockInsertionSet.cpp:
- dfg/DFGByteCodeParser.cpp:
- dfg/DFGCFAPhase.cpp:
- dfg/DFGCFGSimplificationPhase.cpp:
- dfg/DFGCPSRethreadingPhase.cpp:
- dfg/DFGCSEPhase.cpp:
- dfg/DFGCapabilities.cpp:
- dfg/DFGClobberSet.cpp:
- dfg/DFGClobberize.cpp:
- dfg/DFGCommon.cpp:
- dfg/DFGCommonData.cpp:
- dfg/DFGCompilationKey.cpp:
- dfg/DFGCompilationMode.cpp:
- dfg/DFGConstantFoldingPhase.cpp:
- dfg/DFGCriticalEdgeBreakingPhase.cpp:
- dfg/DFGDCEPhase.cpp:
- dfg/DFGDesiredIdentifiers.cpp:
- dfg/DFGDesiredStructureChains.cpp:
- dfg/DFGDesiredTransitions.cpp:
- dfg/DFGDesiredWatchpoints.cpp:
- dfg/DFGDesiredWeakReferences.cpp:
- dfg/DFGDesiredWriteBarriers.cpp:
- dfg/DFGDisassembler.cpp:
- dfg/DFGDominators.cpp:
- dfg/DFGEdge.cpp:
- dfg/DFGFailedFinalizer.cpp:
- dfg/DFGFinalizer.cpp:
- dfg/DFGFixupPhase.cpp:
- dfg/DFGFlushFormat.cpp:
- dfg/DFGFlushLivenessAnalysisPhase.cpp:
- dfg/DFGFlushedAt.cpp:
- dfg/DFGGraph.cpp:
- dfg/DFGGraphSafepoint.cpp:
- dfg/DFGInPlaceAbstractState.cpp:
- dfg/DFGIntegerCheckCombiningPhase.cpp:
- dfg/DFGInvalidationPointInjectionPhase.cpp:
- dfg/DFGJITCode.cpp:
- dfg/DFGJITCompiler.cpp:
- dfg/DFGJITFinalizer.cpp:
- dfg/DFGJumpReplacement.cpp:
- dfg/DFGLICMPhase.cpp:
- dfg/DFGLazyJSValue.cpp:
- dfg/DFGLivenessAnalysisPhase.cpp:
- dfg/DFGLongLivedState.cpp:
- dfg/DFGLoopPreHeaderCreationPhase.cpp:
- dfg/DFGMinifiedNode.cpp:
- dfg/DFGNaturalLoops.cpp:
- dfg/DFGNode.cpp:
- dfg/DFGNodeFlags.cpp:
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
- dfg/DFGOSREntry.cpp:
- dfg/DFGOSREntrypointCreationPhase.cpp:
- dfg/DFGOSRExit.cpp:
- dfg/DFGOSRExitBase.cpp:
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompiler32_64.cpp:
- dfg/DFGOSRExitCompiler64.cpp:
- dfg/DFGOSRExitCompilerCommon.cpp:
- dfg/DFGOSRExitJumpPlaceholder.cpp:
- dfg/DFGOSRExitPreparation.cpp:
- dfg/DFGPhase.cpp:
- dfg/DFGPlan.cpp:
- dfg/DFGPredictionInjectionPhase.cpp:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGResurrectionForValidationPhase.cpp:
- dfg/DFGSSAConversionPhase.cpp:
- dfg/DFGSSALoweringPhase.cpp:
- dfg/DFGSafepoint.cpp:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- dfg/DFGStackLayoutPhase.cpp:
- dfg/DFGStoreBarrierElisionPhase.cpp:
- dfg/DFGStrengthReductionPhase.cpp:
- dfg/DFGThreadData.cpp:
- dfg/DFGThunks.cpp:
- dfg/DFGTierUpCheckInjectionPhase.cpp:
- dfg/DFGToFTLDeferredCompilationCallback.cpp:
- dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
- dfg/DFGTypeCheckHoistingPhase.cpp:
- dfg/DFGUnificationPhase.cpp:
- dfg/DFGUseKind.cpp:
- dfg/DFGValidate.cpp:
- dfg/DFGValueSource.cpp:
- dfg/DFGVariableAccessDataDump.cpp:
- dfg/DFGVariableEvent.cpp:
- dfg/DFGVariableEventStream.cpp:
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
- dfg/DFGWatchpointCollectionPhase.cpp:
- dfg/DFGWorklist.cpp:
- heap/JITStubRoutineSet.cpp:
- jit/GCAwareJITStubRoutine.cpp:
- jit/JIT.cpp:
- jit/JITDisassembler.cpp:
- jit/JITOperations.cpp:
- jit/JITStubRoutine.cpp:
- jit/JITStubs.cpp:
- jit/TempRegisterSet.cpp:
- 10:59 AM Changeset in webkit [164228] by
-
- 6 edits in trunk/Source/JavaScriptCore
FTL OSR exit shouldn't make X86-specific assumptions
https://bugs.webkit.org/show_bug.cgi?id=128890
Reviewed by Mark Hahnenberg.
Mostly this is about not using push/pop, but instead using the more abstract pushToSave() and popToRestore() while reflecting on the stack alignment.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::pushToSaveImmediateWithoutTouchingRegisters):
(JSC::MacroAssembler::pushToSaveByteOffset):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::pushToSaveImmediateWithoutTouchingRegisters):
(JSC::MacroAssemblerARM64::pushToSaveByteOffset):
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLThunks.cpp:
(JSC::FTL::osrExitGenerationThunkGenerator):
- 10:48 AM Changeset in webkit [164227] by
-
- 7 edits in trunk
DataCue.data should be a copy of the input ArrayBuffer, not a pointer
https://bugs.webkit.org/show_bug.cgi?id=128886
Reviewed by Eric Carlson.
Source/WebCore:
No new tests, just updated existing track-datacue.html test.
- html/track/DataCue.cpp:
(WebCore::DataCue::DataCue): Add ExceptionCode and pass through to setData().
(WebCore::DataCue::data): Return a copy of m_data instead of a pointer.
(WebCore::DataCue::setData): Create a copy of the input data, or throw an exception if it's null.
- html/track/DataCue.h: Add ExceptionCode parameters to constructor and data setter.
- html/track/DataCue.idl: Same.
LayoutTests:
- media/track/track-datacue-expected.txt:
- media/track/track-datacue.html:
- 10:47 AM Changeset in webkit [164226] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, make this test pass without DFG. It was assuming that you always have DFG
and that it would always tier-up to the DFG - both wrong assumptions.
- tests/stress/tricky-array-bounds-checks.js:
(foo):
- 10:26 AM Changeset in webkit [164225] by
-
- 3 edits in trunk/Source/WebKit2
Try to fix iOS Debug builds without breaking Release builds.
- WebProcess/WebPage/PageBanner.cpp:
- WebProcess/WebPage/PageBanner.h:
- 9:18 AM Changeset in webkit [164224] by
-
- 5 edits in trunk/Source/WebCore
CounterContentData::counter() and ImageContentData::image() should return references
<http://webkit.org/b/128671>
Reviewed by Darin Adler.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::contentToCSSValue):
- Update to use references. Remove useless ASSERTs.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- Update to use references. StyleResolver::loadPendingImage() will be changed to take a reference in the near future.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::createFor):
- Update to use references. The auto keyword wanted to instantiate a StyleImage instead a reference, so it was replaced.
- rendering/style/ContentData.h:
(WebCore::ImageContentData::ImageContentData): Add ASSERT that
m_image is not NULL.
(WebCore::ImageContentData::image): Return a reference. Remove
useless overload with identical name.
(WebCore::ImageContentData::cloneInternal): Simplify by using
implicit PassRefPtr constructor.
(WebCore::operator==): Remove unneeded deref operators.
(WebCore::CounterContentData::counter): Return a reference.
(WebCore::CounterContentData::cloneInternal): Remove unneeded
deref operator.
(WebCore::operator==): Remove unneeded deref operators.
- 9:17 AM Changeset in webkit [164223] by
-
- 3 edits in trunk/Source/WebCore
[MediaControls][iOS] Make mediacontrols match the system inline controls
https://bugs.webkit.org/show_bug.cgi?id=128833
Reviewed by Eric Carlson.
Move items slightly, fix button sizes, font sizes, and colors to match the
inline controls from MoviePlayer.framework.
- Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-play-button.paused):
(audio::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-timeline::-webkit-slider-thumb):
(audio::-webkit-media-controls-time-remaining-display):
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.configureInlineControls): Do not add the status text.
(ControllerIOS.prototype.updateTime): Call updateProgress().
(ControllerIOS.prototype.progressFillStyle): Draw a slightly different color.
(ControllerIOS.prototype.updateProgress): Draw white to the left of the currentTime.
(ControllerIOS.prototype.formatTime): Single leading zero in the time display fields.
(ControllerIOS.prototype.handleTimelineChange): Call updateProgress().
- 8:18 AM Changeset in webkit [164222] by
-
- 2 edits in trunk
[GTK] MEDIA_CONTROLS_SCRIPT depends on VIDEO_TRACK
https://bugs.webkit.org/show_bug.cgi?id=128799
Reviewed by Philippe Normand.
MEDIA_CONTROLS_SCRIPT has a dependency on VIDEO_TRACK. So it causes a build break
if building with autotools. cmake system has enabled it as default. So I propose
enabling VIDEO_TRACK as well.
- Source/autotools/SetupWebKitFeatures.m4:
- 7:29 AM Changeset in webkit [164221] by
-
- 2 edits in trunk/Tools
Fix typos in Tools/efl/jhbuild.modules.
https://bugs.webkit.org/show_bug.cgi?id=128908
Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- efl/jhbuild.modules: 's/<deb /<dep /g'
- 7:17 AM Changeset in webkit [164220] by
-
- 2 edits in trunk/Source/WTF
Enable DFG_JIT on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128898
Patch by Ryan Lortie <desrt@desrt.ca> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h:
- 6:56 AM Changeset in webkit [164219] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening
Add test expectations for crashing and failing tests.
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 6:12 AM Changeset in webkit [164218] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2
Merge r162724 - [GTK] youtube HTML5 videos in fullscreen, after <Esc>, can't go fullscreen again
https://bugs.webkit.org/show_bug.cgi?id=127064
When pressing <Esc> or <f> at full screen, the WebView shall emit the
event webkitfullscreenchange, but wk2gtk does not emit it. This is
because the WebView manages directly the exit of the full screen.
With this patch the WebView calls requestExitFullScreen to the full
screen manager, instead of managing directly the exit of the full
screen, and the event webkitfullscreenchange will be dispatched
correctly.
Reviewed by Martin Robinson.
No tests are included because there is a bug in WKTR that prevents the
execution of a test for this patch. See
https://bugs.webkit.org/show_bug.cgi?id=127348
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseKeyPressEvent): Call
webkitWebViewBaseRequestExitFullScreen.
(webkitWebViewBaseRequestExitFullScreen): Added.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Ditto.
- 6:09 AM WebKitGTK/2.2.x edited by
- (diff)
- 5:23 AM Changeset in webkit [164217] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the CLoop build after r163760
https://bugs.webkit.org/show_bug.cgi?id=128900
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- llint/LLIntThunks.cpp:
- 5:14 AM Changeset in webkit [164216] by
-
- 2 edits in trunk/Source/JavaScriptCore
CLoop buildfix after r164207
https://bugs.webkit.org/show_bug.cgi?id=128899
Patch by Dániel Bátyai <Dániel Bátyai> on 2014-02-17
Reviewed by Csaba Osztrogonác.
- dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
- 3:24 AM WebKitGTK/2.2.x edited by
- (diff)
- 3:11 AM WebKitGTK/2.4.x edited by
- Add bug #126927 as a future merge candidate. (diff)
- 3:09 AM Changeset in webkit [164215] by
-
- 1 copy in releases/WebKitGTK/webkit-2.3.90
Tagging the WebKitGTK+ 2.3.90 release
- 2:57 AM Changeset in webkit [164214] by
-
- 3 edits2 adds in trunk
[CSS Grid Layout] Fix missing layout in flexible and content sized columns
https://bugs.webkit.org/show_bug.cgi?id=128672
Reviewed by Sergio Villar Senin.
Source/WebCore:
RenderGrid::logicalContentHeightForChild() is called for some items at the beginning of RenderGrid::layoutGridItems()
from RenderGrid::computeUsedBreadthOfGridTracks(). This causes that the comparison inside the for loop in
RenderGrid::layoutGridItems() does not detect width changes, so elements won't be marked as needsLayout.
So the comparison is done in RenderGrid::logicalContentHeightForChild() and the element is marked to perform a layout if
the width has changed.
The issue can be reproduced easily with a simple grid with one flexible or content sized column, all the available width
is not used. On top of that, when you resize the window the flexible or content sized columns are not updating their
size properly.
CSS Grid Layout perftest results are around 4% worse, which is expected as we're adding a missing layout.
Test: fast/css-grid-layout/flex-content-sized-column-use-available-width.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalContentHeightForChild): Check width changes and mark element as needed layout if required.
LayoutTests:
Add test that reproduce the issue for both cases flexible and content sized columns.
- fast/css-grid-layout/flex-content-sized-column-use-available-width-expected.html: Added.
- fast/css-grid-layout/flex-content-sized-column-use-available-width.html: Added.
- 2:54 AM Changeset in webkit [164213] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.3.90 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.3.90.
- 2:51 AM Changeset in webkit [164212] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4/Source
Unreviewed. Fix make distcheck.
Source/WebCore:
- GNUmakefile.list.am: Add missing header files.
Source/WebKit2:
- GNUmakefile.list.am: Add missing header files.
- 12:47 AM WebKitGTK/2.2.x edited by
- (diff)
- 12:32 AM Changeset in webkit [164211] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4
Merge r163954 - 'ar T' is not portable and breaks the build on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128596
Patch by Ryan Lortie <desrt@desrt.ca> on 2014-02-12
Reviewed by Gustavo Noronha Silva.
Create thin archives only if we are using GNU ar.
- Source/autotools/SetupLibtool.m4:
- 12:27 AM Changeset in webkit [164210] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r163875 - O_CLOEXEC in shm_open does not work on FreeBSD
https://bugs.webkit.org/show_bug.cgi?id=128572
Reviewed by Darin Adler.
The O_CLOEXEC is not supported by shm_open() and is also not
necessary since FD_CLOEXEC is already set by default when the new
file descriptor is created.
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::create):
- 12:25 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:21 AM Changeset in webkit [164209] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.4
Merge r163871 - [GStreamer] High playback rate causes crash
https://bugs.webkit.org/show_bug.cgi?id=128453
Patch by Piotr Grad <p.grad@samsung.com> on 2014-02-11
Reviewed by Philippe Normand.
Source/WebCore:
To high playback rate passed to GStreamer was causing crash.
Added guard in setRate method.
Test: media/video-extreme-playbackrate-crash.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::setRate):
LayoutTests:
Test checks if passing high playback rate causes crash.
- media/video-extreme-playbackrate-crash-expected.txt: Added.
- media/video-extreme-playbackrate-crash.html: Added.
- 12:20 AM WebKitGTK/2.4.x edited by
- (diff)
- 12:15 AM WebKitGTK/2.4.x edited by
- (diff)
Feb 16, 2014:
- 10:47 PM Changeset in webkit [164208] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, 32-bit build fix.
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::lshiftPtr):
- 10:35 PM Changeset in webkit [164207] by
-
- 40 edits9 adds in trunk
FTL should inline polymorphic heap accesses
https://bugs.webkit.org/show_bug.cgi?id=128795
Source/JavaScriptCore:
Reviewed by Oliver Hunt.
We now inline GetByIds that we know are pure but polymorphic. They manifest in DFG IR
as MultiGetByOffset, and in LLVM IR as a switch with a basic block for each kind of
read.
2% speed-up on Octane mostly due to a 18% speed-up on deltablue.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/ExitingJITType.cpp: Added.
(WTF::printInternal):
- bytecode/ExitingJITType.h:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::dump):
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::numVariants):
(JSC::GetByIdStatus::variants):
(JSC::GetByIdStatus::at):
(JSC::GetByIdStatus::operator[]):
- bytecode/GetByIdVariant.cpp: Added.
(JSC::GetByIdVariant::dump):
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h: Added.
(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::isSet):
(JSC::GetByIdVariant::operator!):
(JSC::GetByIdVariant::structureSet):
(JSC::GetByIdVariant::chain):
(JSC::GetByIdVariant::specificValue):
(JSC::GetByIdVariant::offset):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::emitPrototypeChecks):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::getByOffsetLoadElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.h:
(JSC::DFG::verboseCompilationEnabled):
(JSC::DFG::logCompilationChanges):
(JSC::DFG::shouldShowDisassembly):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::convertToConstant):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasMultiGetByOffsetData):
(JSC::DFG::Node::multiGetByOffsetData):
- dfg/DFGNodeType.h:
- dfg/DFGPhase.h:
(JSC::DFG::Phase::graph):
(JSC::DFG::runAndLog):
- dfg/DFGPlan.cpp:
(JSC::DFG::dumpAndVerifyGraph):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCompile.cpp:
(JSC::FTL::fixFunctionBasedOnStackMaps):
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
- ftl/FTLState.h:
(JSC::FTL::verboseCompilationEnabled):
(JSC::FTL::showDisassembly):
- jsc.cpp:
(GlobalObject::finishCreation):
(functionEffectful42):
- runtime/IntendedStructureChain.cpp:
(JSC::IntendedStructureChain::dump):
(JSC::IntendedStructureChain::dumpInContext):
- runtime/IntendedStructureChain.h:
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- tests/stress/fold-multi-get-by-offset-to-get-by-offset-with-watchpoint.js: Added.
(foo):
(bar):
- tests/stress/fold-multi-get-by-offset-to-get-by-offset.js: Added.
(foo):
(bar):
- tests/stress/multi-get-by-offset-proto-and-self.js: Added.
(foo):
(Foo):
Source/WTF:
Reviewed by Oliver Hunt.
- wtf/PrintStream.h:
(WTF::PointerDumpInContext::PointerDumpInContext):
(WTF::PointerDumpInContext::dump):
(WTF::pointerDumpInContext):
LayoutTests:
Reviewed by Oliver Hunt.
- js/regress/polymorphic-get-by-id-expected.txt: Added.
- js/regress/polymorphic-get-by-id.html: Added.
- js/regress/script-tests/polymorphic-get-by-id.js: Added.
(foo):
- 10:26 PM Changeset in webkit [164206] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, add a useful comment for this test.
- js/regress/script-tests/marsaglia-osr-entry.js:
- 10:25 PM Changeset in webkit [164205] by
-
- 7 edits in trunk/Source/JavaScriptCore
DFG::prepareOSREntry should be nice to the stack
https://bugs.webkit.org/show_bug.cgi?id=128883
Reviewed by Oliver Hunt.
Previously OSR entry had some FIXME's and some really badly commented-out code for
clearing stack entries to help GC. It also did some permutations on a stack frame
above us, in such a way that it wasn't obviously that we wouldn't clobber our own
stack frame. This function also crashed in ASan.
It just seems like there was too much badness to the whole idea of prepareOSREntry
directly editing the stack. So, I changed it to create a stack frame in a scratch
buffer on the side and then have some assembly code just copy it into place. This
works fine, fixes a FIXME, possibly fixes some stack clobbering, and might help us
make more progress with ASan.
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSREntry.h:
- dfg/DFGThunks.cpp:
(JSC::DFG::osrEntryThunkGenerator):
- dfg/DFGThunks.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOperations.cpp:
- 7:52 PM Changeset in webkit [164204] by
-
- 3 edits2 adds in trunk
Ensure that removing an iframe from the DOM tree disconnects its Frame.
<https://webkit.org/b/128889>
<rdar://problem/15671221>
Merged from Blink (patch by Adam Klein):
https://src.chromium.org/viewvc/blink?revision=156174&view=revision
Source/WebCore:
SubframeLoadingDisabler wasn't catching the case when an <iframe> was,
in its unload handler, removed and re-added to the same parent.
Fix this by using a count of SubframeLoadingDisablers that are on the
stack for a given root, rather than a simple boolean.
Test: fast/frames/reattach-in-unload.html
- html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::disabledSubtreeRoots):
LayoutTests:
- fast/frames/reattach-in-unload-expected.txt: Added.
- fast/frames/reattach-in-unload.html: Added.
- 7:19 PM Changeset in webkit [164203] by
-
- 3 edits4 adds in trunk
When applying style, attribute value matching should be case sensitive for SVG
https://bugs.webkit.org/show_bug.cgi?id=128882
Reviewed by Andreas Kling.
Source/WebCore:
SelectorChecker was incorrectly matching attribute values with a case insensitve comparison
in some cases.
The choice to use case sensitive matching was taking into account the document type but not
the element type. As a result, SVG (and likely MHTML) elements were incorrectly being tested
as if they were HTML element.
With the patch, WebKit also matches the behavior of Firefox, which is great.
Tests: fast/css/case-insensitive-attribute-with-svg.html
fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
LayoutTests:
- fast/css/case-insensitive-attribute-with-svg-expected.html: Added.
- fast/css/case-insensitive-attribute-with-svg.html: Added.
- fast/selectors/querySelector-case-insensitive-attribute-match-with-svg-expected.txt: Added.
- fast/selectors/querySelector-case-insensitive-attribute-match-with-svg.html: Added.
- 7:14 PM Changeset in webkit [164202] by
-
- 5 edits in trunk/Source/WebCore
Split compilation state between querySelector and CSS matching
https://bugs.webkit.org/show_bug.cgi?id=128869
Reviewed by Antti Koivisto.
Cleanup after recent changes:
-SelectorCompiler now has a SelectorContext defining if the code is compiled for QuerySelector
or for ElementRuleCollector.
-Generalize m_selectorCannotMatchAnything by making it part of the FunctionType. FunctionType now
fully represent the type of code generation and we don't rely implicitly on m_selectorFragments being
empty.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::compileSelector):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
There is no tree marking for QuerySelector, so we can generate a simple selector
for the sibling selectors.
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
The code is split to make it simpler. The classic code generation has been moved
to generateSelectorChecker().
The decision on what to generate is reduced to a simple switch-case.
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
The code that was previously in compile().
(WebCore::SelectorCompiler::SelectorCodeGenerator::markParentElementIfResolvingStyle):
We should not generate tree marking on querySelector traversal. Since the constructor
now generate a SimpleChecker, it would also be incorrect to attempt to access the checkingContext
on the stack.
We can just skip the marking entierly.
- cssjit/SelectorCompiler.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
With the changes of SelectorContext, we can no longer generate a complex checker for querySelector.
This code may come back in the future but at the moment it is useless.
- 7:11 PM Changeset in webkit [164201] by
-
- 2 edits in trunk/Source/WebCore
The FTP view is squished to the left
https://bugs.webkit.org/show_bug.cgi?id=128856
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-16
Reviewed by Andreas Kling.
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- 5:48 PM Changeset in webkit [164200] by
-
- 2 edits in trunk/Source/WebCore
[Coordinated Graphics] Make AreaAllocator fast allocated
https://bugs.webkit.org/show_bug.cgi?id=124995
Reviewed by Anders Carlsson.
AreaAllocator can be created and destroyed frequently (at least once per
frame) in case of animation with changing width or height. So, it's
better to make AreaAllocator fast allocated.
- platform/graphics/texmap/coordinated/AreaAllocator.h:
- 4:50 PM Changeset in webkit [164199] by
-
- 2 edits in trunk/Source/WebCore
[iOS] WebKit crashes if text is copied to pasteboard with style containing text-shadow
https://bugs.webkit.org/show_bug.cgi?id=128888
<rdar://problem/16065699>
Reviewed by Anders Carlsson.
Use the correct class on iOS so that we don't crash.
- platform/mac/HTMLConverter.mm:
(_shadowForShadowStyle):
- 2:59 PM Changeset in webkit [164198] by
-
- 4 edits in trunk/Source/WebCore
Atomicize frequently identical ResourceResponse string members.
<https://webkit.org/b/128887>
Store the mime type, text encoding and HTTP response status text in
AtomicStrings instead of Strings to deduplicate frequently occurring
values (e.g "text/html", "utf-8" and "OK".)
Reviewed by Geoffrey Garen.
- platform/network/ResourceResponseBase.h:
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):
- platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
- 2:45 PM Changeset in webkit [164197] by
-
- 2 edits in trunk/Source/WebKit2
Speculative iOS build fix.
- WebProcess/WebPage/mac/PageBannerMac.mm:
- 2:43 PM Changeset in webkit [164196] by
-
- 2 edits in trunk/Source/WebCore
Speculative iOS build fix.
- dom/Document.cpp:
(WebCore::Document::Document):
- 2:18 PM Changeset in webkit [164195] by
-
- 15 edits in trunk/Source/WebCore
Move document life time management from TreeScope to Document
https://bugs.webkit.org/show_bug.cgi?id=128877
Reviewed by Andreas Kling.
Document life time is managed in confusing manner by TreeScopes which are also inherited to ShadowRoots.
This patches moves the life time management to Document. Nodes in shadow trees selfOnlyRef the Document instead
of the ShadowRoot. ShadowRoot is treated like any other node and selfOnlyRefs the Document as well (which it
also did earlier, indirectly).
TreeScope is devirtualized.
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::collectMatchingRules):
Author stylesheets never match in UA shadow trees.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::removedLastRef):
- dom/Document.h:
(WebCore::Document::selfOnlyRef):
(WebCore::Document::selfOnlyDeref):
To avoid branches Document self-refs itself like all other Nodes. This is why deletion will now happen on ref count of 1.
(WebCore::Node::isDocumentNode):
(WebCore::Node::Node):
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::add):
- dom/Element.cpp:
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
- dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::removedLastRef):
- dom/Node.h:
(WebCore::Node::document):
(WebCore::Node::inDocument):
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::ShadowRoot):
(WebCore::ShadowRoot::~ShadowRoot):
- dom/ShadowRoot.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::TreeScope):
(WebCore::TreeScope::~TreeScope):
(WebCore::TreeScope::setParentTreeScope):
- dom/TreeScope.h:
(WebCore::TreeScope::documentScope):
Document can no longer ever be null.
(WebCore::TreeScope::rootNode):
(WebCore::TreeScope::setDocumentScope):
- dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveShadowTreeToNewDocument):
Manage Document selfOnlyRefs for nodes in shadow trees too.
(WebCore::TreeScopeAdopter::updateTreeScope):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
- dom/TreeScopeAdopter.h:
- 2:00 PM Changeset in webkit [164194] by
-
- 4 edits in trunk/Source/WebCore
setSelectionRange shouldn't directly instantiate VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=128881
Reviewed by Andreas Kling.
Added a new version of moveTo for setSelectionRange.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveTo): Added.
- editing/FrameSelection.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setSelectionRange): Use the newly added FrameSelection::moveTo
instead of manually instantiating VisibleSelection here.
- 1:38 PM Changeset in webkit [164193] by
-
- 2 edits in trunk/Source/WebKit2
Speculative iOS build fix.
- WebProcess/WebPage/PageBanner.h:
- 12:38 PM Changeset in webkit [164192] by
-
- 59 edits in trunk/Source
Stop using PLATFORM(MAC) in Source except where it means “OS X but not iOS”
https://bugs.webkit.org/show_bug.cgi?id=128885
Reviewed by Anders Carlsson.
Source/WebCore:
- loader/FrameLoaderClient.h: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- platform/Cursor.h: Changed PLATFORM(MAC) to USE(APPKIT) around uses of NSCursor.
- platform/LocalizedStrings.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- platform/graphics/PlatformLayer.h: Ditto.
- platform/graphics/cg/PDFDocumentImage.cpp: Ditto.
- rendering/RenderLayerCompositor.cpp: Ditto.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
Source/WebKit2:
- Configurations/WebKit2.xcconfig: Removed PageBannerMac.mm and WKBundlePageBannerMac.mm
from EXCLUDED_SOURCE_FILE_NAMES_iphoneos, now that these files are guarded with
!PLATFORM(IOS).
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WKBundleFrameCopyWebArchiveFilteringSubframes):
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm: Guarded with !PLATFORM(IOS).
- WebProcess/InjectedBundle/InjectedBundle.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h: Changed PLATFORM(MAC) to USE(FOUNDATION)
around use of NSBundle.
- WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h: Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):
- WebProcess/Network/WebResourceLoader.cpp: Ditto.
(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: Ditto.
(WebKit::NPN_GetValue):
(WebKit::NPN_SetValue):
(WebKit::initializeBrowserFuncs):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp: Ditto.
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::supportsSnapshotting):
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Ditto.
- WebProcess/Plugins/Plugin.cpp: Ditto.
(WebKit::Plugin::Parameters::encode):
(WebKit::Plugin::Parameters::decode):
- WebProcess/Plugins/Plugin.h: Ditto.
- WebProcess/Plugins/PluginController.h: Ditto.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp: Changed PLATFORM(MAC) to
USE(DARWIN) around use of Mach-based IPC.
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Plugins/PluginProxy.cpp: Chanegd PLATFORM(MAC) to PLATFORM(COCOA).
- WebProcess/Plugins/PluginProxy.h: Ditto.
- WebProcess/Plugins/PluginProxy.messages.in: Ditto.
- WebProcess/Plugins/PluginView.cpp: Ditto.
(WebKit::PluginView::destroyPluginAndReset):
(WebKit::PluginView::viewStateDidChange):
(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::pluginSnapshotTimerFired):
- WebProcess/Plugins/PluginView.h: Ditto.
- WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp: Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
(WebKit::WebChromeClient::windowRect):
- WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebContextMenuClient.h: Ditto.
- WebProcess/WebCoreSupport/WebDragClient.cpp: Ditto.
- WebProcess/WebCoreSupport/WebDragClient.h: Ditto.
- WebProcess/WebCoreSupport/WebEditorClient.cpp: Ditto.
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
- WebProcess/WebCoreSupport/WebEditorClient.h: Ditto.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: Ditto.
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
(WebKit::WebFrameLoaderClient::createPlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Ditto.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: Ditto.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h: Ditto.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: Removed PLATFORM(MAC).
(InitWebCoreSystemInterface):
- WebProcess/WebPage/DrawingArea.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h: Ditto.
- WebProcess/WebPage/DrawingArea.messages.in: Ditto.
- WebProcess/WebPage/EventDispatcher.cpp: Ditto.
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/LayerTreeHost.h: Ditto.
- WebProcess/WebPage/PageBanner.cpp: Added !PLATFORM(IOS)
- WebProcess/WebPage/PageBanner.h: Ditto.
- WebProcess/WebPage/WebFrame.cpp: Changed PLATFORM(MAC) to PLATFORM(COCOA).
- WebProcess/WebPage/WebFrame.h: Ditto.
- WebProcess/WebPage/WebInspector.cpp: Ditto.
(WebKit::WebInspector::WebInspector):
- WebProcess/WebPage/WebInspector.h: Ditto.
- WebProcess/WebPage/WebPage.cpp: Ditto.
(WebKit::WebPage::WebPage):
(WebKit::isContextClick):
(WebKit::WebPage::getSelectionAsWebArchiveData):
(WebKit::WebPage::getWebArchiveOfFrame):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::sendSetWindowFrame):
(WebKit::WebPage::beginPrinting):
(WebKit::WebPage::computePagesForPrinting):
- WebProcess/WebPage/WebPage.h: Ditto.
- WebProcess/WebPage/WebPage.messages.in: Ditto.
- WebProcess/WebPage/mac/PageBannerMac.mm: Guarded with !PLATFORM(IOS).
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Changed PLATFORM(MAC) to PLATFORM(COCOA).
(WebKit::WebProcess::initializeWebProcess): Ditto.
(WebKit::WebProcess::ensureNetworkProcessConnection): Changed PLATFORM(MAC) to OS(DARWIN).
(WebKit::WebProcess::ensurePrivateBrowsingSession): Changed PLATFORM(MAC) to
PLATFORM(COCOA).
(WebKit::WebProcess::destroyPrivateBrowsingSession): Ditto.
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Changed PLATFORM(MAC) to
OS(DARWIN).
(WebKit::WebProcess::nonVisibleProcessCleanupTimerFired): Changed PLATFORM(MAC) to
PLATFORM(COCOA)
- WebProcess/WebProcess.h: Ditto.
- WebProcess/WebProcess.messages.in: Removed PLATFORM(MAC) guard around
SetProcessSuppressionEnabled. Changed it to PLATFORM(COCOA) around SetQOS.
- 9:41 AM Changeset in webkit [164191] by
-
- 2 edits in trunk/Source/WebCore
Speculative iOS build fix after r164184.
- dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
- 1:11 AM Changeset in webkit [164190] by
-
- 2 edits in trunk/Source/WTF
Reintroduce const qualifiers for return types of (Filter|Transform)Iterator::operator*()
https://bugs.webkit.org/show_bug.cgi?id=126875
The const qualifiers for the return types of FilterIterator::operator*() and TransformIterator::operator*()
were removed in r161797 and r161802 because of compilation failures when using GCC and having an Iterator
type that already had the const qualifier. std::remove_const is now used to appease GCC and enforce the const
qualifier on the return type, regardless of the Iterator type and its qualifiers.
- wtf/IteratorAdaptors.h:
(WTF::FilterIterator::operator*):
(WTF::TransformIterator::operator*):
