Timeline

Mar 3, 2014:

11:36 PM Changeset in webkit [165042] by Martin Robinson

• 4 edits in trunk/Source/WebKit/gtk

[GTK] Fix some simple gtkdoc warnings for WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=129659

Reviewed by Carlos Garcia Campos.

• docs/webkitgtk-sections.txt: Make public some enum documentation that is used

in public APIs.

• webkit/webkitwebview.cpp: Fix typos and add documentation for enums previously

marked as private.
(webkit_web_view_class_init):

• webkit/webkitwebview.h: Ditto.

11:35 PM Changeset in webkit [165041] by Martin Robinson

• 2 edits in trunk/Source/WebCore

Fix the GTK+ CMake build

• PlatformGTK.cmake: Add a missing file to the source list.

10:57 PM Changeset in webkit [165040] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::close
​https://bugs.webkit.org/show_bug.cgi?id=129631

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-03
Reviewed by Timothy Hatcher.

Avoid deref() too early if a client calls close(). The xpc_connection_close
will cause another XPC_ERROR event to come in from the queue, deref then.
Likewise, protect multithreaded access to m_client. If a client calls
close() we want to immediately clear the pointer to prevent calls to it.

Overall the multi-threading aspects of RemoteInspectorXPCConnection are
growing too complicated for probably little benefit. We may want to
clean this up later.

• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::xpcConnectionFailed):

• inspector/remote/RemoteInspectorXPCConnection.h:
• inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeOnQueue):
(Inspector::RemoteInspectorXPCConnection::deserializeMessage):
(Inspector::RemoteInspectorXPCConnection::handleEvent):
(Inspector::RemoteInspectorXPCConnection::sendMessage):

10:52 PM Changeset in webkit [165039] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Match color of regex in source view with a popover
​https://bugs.webkit.org/show_bug.cgi?id=129645

Patch by Jonathan Wells <​jonowells@apple.com> on 2014-03-03
Reviewed by Timothy Hatcher.

• UserInterface/Views/LogContentView.css:

(.console-formatted-string):
(.console-formatted-regexp):

10:38 PM Changeset in webkit [165038] by msaboff@apple.com

• 2 edits in trunk/Source/JavaScriptCore

AbstractMacroAssembler::CachedTempRegister should start out invalid
​https://bugs.webkit.org/show_bug.cgi?id=129657

Reviewed by Filip Pizlo.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::AbstractMacroAssembler):

• Invalidate all cached registers in constructor as we don't know the contents of any register at the entry to the code we are going to generate.

10:37 PM Changeset in webkit [165037] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk

:active style is not cleared when its display property is set to none before mouse released.
​https://bugs.webkit.org/show_bug.cgi?id=129465

Patch by Sanghyup Lee <​sh53.lee@samsung.com> on 2014-03-03
Reviewed by Antonio Gomes.

Source/WebCore:

We currently clearing the :active style when element has a renderer.
This patch makes elements clear its active style regardless of renderer.

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

LayoutTests:

• fast/css/active-display-none-expected.txt: Added.
• fast/css/active-display-none.html: Added.

8:21 PM Changeset in webkit [165036] by akling@apple.com

• 2 edits in trunk/Source/JavaScriptCore

StructureOrOffset should be fastmalloced.
<​https://webkit.org/b/129640>

Reviewed by Geoffrey Garen.

• runtime/StructureIDTable.h:

8:11 PM Changeset in webkit [165035] by rniwa@webkit.org

• 2 edits in trunk/Websites/webkit.org

Use DYEBench v0.9 by default.

Rubber-stamped by Benjamin Poulain.

• perf/DoYouEvenBench/index.html:

7:24 PM Changeset in webkit [165034] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] WebPage::updateVisibleContentRects can set the position directly instead of using programmatic scrolling
​https://bugs.webkit.org/show_bug.cgi?id=129649

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):
Update my workaround from r165003. We should not use programmatic scrolling when the scroll position is changed
from the UI.

7:23 PM Changeset in webkit [165033] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Update UIScrollView's contentSize when a new layer tree is committed
​https://bugs.webkit.org/show_bug.cgi?id=129641

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
Previously, we relied on [UIScrollView setZoomScale:] to reset the contentSize for us.
In the cases where we would not go through [UIScrollView setZoomScale:], the UIScrollView's contentSize
did not match the actual WKContentView's area on screen.

6:22 PM Changeset in webkit [165032] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove 2 unnecessary includes from JSDOMBinding.h
<​https://webkit.org/b/129619>

Reviewed by Antti Koivisto.

• bindings/js/JSDOMBinding.h:

6:00 PM Changeset in webkit [165031] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

GraphicsContext::drawLineForText needs to be exported from WebCore.dylib for iOS builds
​https://bugs.webkit.org/show_bug.cgi?id=129647

Reviewed by NOBODY (This is a build fix).

Fixing after r165025 and r165016.

No new tests as this is a build fix.

• WebCore.exp.in:

5:53 PM Changeset in webkit [165030] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

[iOS] Start playback button misplaced
​https://bugs.webkit.org/show_bug.cgi?id=129628

Reviewed by Simon Fraser.

On YouTube embeds, while the video is loading it is placed into the DOM with a 0x0 size.
This causes the start playback button to be visible in the upper-left corner of the embed
area. The button wasn't visible previously (in plugin mode) because the plugin clipped its
drawing to its bounds, and so the <video> shadow should do the same.

• Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls):

5:45 PM Changeset in webkit [165029] by enrica@apple.com

• 2 edits in trunk/Source/WebCore

Build fix for iOS simulator.

• WebCore.exp.in:

5:29 PM Changeset in webkit [165028] by commit-queue@webkit.org

• 12 edits in trunk/Source

Forward application suspend resume notifications to the web process.
​https://bugs.webkit.org/show_bug.cgi?id=129356

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-03-03
Reviewed by Eric Carlson.

Source/WebCore:

• platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):
Observe UIApplicationDidBecomeActiveNotification,
WebUIApplicationDidBecomeActiveNotification,
WebUIApplicationWillEnterForegroundNotification, and
WebUIApplicationWillResignActiveNotification

(-[WebMediaSessionHelper applicationDidBecomeActive:]):
Resume session.

Source/WebKit2:

Repost UIApplicationWillEnterForegroundNotification,
UIApplicationDidBecomeActiveNotification and
UIApplicationWillResignActiveNotification from UIProcess to WebProcess.
As WebUIApplicationWillEnterForegroundNotification,
WebUIApplicationDidBecomeActiveNotification, and
WebUIApplicationWillResignActiveNotification

• UIProcess/WebPageProxy.h:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

• UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::]):
Observe notifications.

(-[WKContentView dealloc]):
Stop observing notifications.

(-[WKContentView _applicationWillResignActive:]):
Notify WebPageProxy of the event.

(-[WKContentView _applicationWillEnterForeground:]):
Notify WebPageProxy of the event.

(-[WKContentView _applicationDidBecomeActive:]):
Notify WebPageProxy of the event.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationWillEnterForeground):
Send corresponding Message to WebPage.

(WebKit::WebPageProxy::applicationWillResignActive):
Send corresponding Message to WebPage.

(WebKit::WebPageProxy::applicationDidBecomeActive):
Send corresponding Message to WebPage.

• WebProcess/WebPage/WebPage.h:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

• WebProcess/WebPage/WebPage.messages.in:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillResignActive):
Post corresponding NSNotification.

(WebKit::WebPage::applicationWillEnterForeground):
Post corresponding NSNotification.

(WebKit::WebPage::applicationDidBecomeActive):
Post corresponding NSNotification.

5:22 PM Changeset in webkit [165027] by commit-queue@webkit.org

• 46 edits in trunk/Source

Unreviewed, rolling out r165013.
​http://trac.webkit.org/changeset/165013
​https://bugs.webkit.org/show_bug.cgi?id=129646

New code is not thread safe, asserting on a worker test
(Requested by ap on #webkit).

Source/WebCore:

• WebCore.exp.in:
• editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

• html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource):

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR):

• loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):

• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):

• loader/cache/CachedFont.h:
• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

• loader/cache/CachedImage.h:
• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

• loader/cache/CachedRawResource.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):

• loader/cache/CachedResource.h:
• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):

• loader/cache/CachedSVGDocument.h:
• loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

• loader/cache/CachedScript.h:
• loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::CachedTextTrack):

• loader/cache/CachedTextTrack.h:
• loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

• loader/cache/CachedXSLStyleSheet.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationSucceeded):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::addImageToCache):
(WebCore::MemoryCache::removeImageFromCache):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromCacheImpl):
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::setDisabled):

• loader/cache/MemoryCache.h:
• platform/CrossThreadCopier.cpp:
• platform/CrossThreadCopier.h:
• platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::updateSnapshot):

• testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/mac/DiskCacheMonitor.h:
• NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor):

• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didCacheResource):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:

5:20 PM Changeset in webkit [165026] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Better Debugger popovers for RegExp values
​https://bugs.webkit.org/show_bug.cgi?id=129633

Patch by Jonathan Wells <​jonowells@apple.com> on 2014-03-03
Reviewed by Timothy Hatcher.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression.populate):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForRegExp):

5:20 PM Changeset in webkit [165025] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Fix the iOS Simulator build.

• WebCore.exp.in:

5:13 PM Changeset in webkit [165024] by Lucas Forschler

• 5 edits in branches/safari-537.75-branch/Source

Versioning.

5:11 PM Changeset in webkit [165023] by Lucas Forschler

• 1 copy in tags/Safari-537.75.5

New Tag.

5:00 PM Changeset in webkit [165022] by enrica@apple.com

• 8 edits in trunk/Source/WebKit2

[iOS WebKit2]: Text fields don't zoom in when focused
​https://bugs.webkit.org/show_bug.cgi?id=129632
<rdar://problem/16185230>

Reviewed by Benjamin Poulain.

When focusing the node we need to zoom and center it and possibly
scroll to make it visible.
On iPad we only scroll, without zooming.

• Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

• Shared/AssistedNodeInformation.h:

(WebKit::AssistedNodeInformation::AssistedNodeInformation):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _scrollToRect:withOrigin:minimumScrollDistance:]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView _startAssistingNode:]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

4:49 PM Changeset in webkit [165021] by msaboff@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Crash in JIT code while watching a video @ storyboard.tumblr.com
​https://bugs.webkit.org/show_bug.cgi?id=129635

Reviewed by Filip Pizlo.

Clear m_set before we set bits in the TempRegisterSet(const RegisterSet& other)
construtor.

• jit/TempRegisterSet.cpp:

(JSC::TempRegisterSet::TempRegisterSet): Clear map before setting it.

• jit/TempRegisterSet.h:

(JSC::TempRegisterSet::TempRegisterSet): Use new clearAll() helper.
(JSC::TempRegisterSet::clearAll): New private helper.

4:45 PM Changeset in webkit [165020] by Brent Fulgham

• 2 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix.
<rdar://problem/16197002>

• WebCore.vcxproj/WebCore.vcxproj: Exclude 64-bit assembly code when building

32-bit DebugSuffix target.

4:44 PM Changeset in webkit [165019] by weinig@apple.com

• 3 edits in trunk/Source/WebKit2

Fix ASSERT and leaks introduced in recent "Support IOS Accessibility in WK2" patch

Reviewed by Simon Fraser.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _accessibilityRegisterUIProcessTokens]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitializeAccessibility):

4:24 PM Changeset in webkit [165018] by Brent Fulgham

• 2 edits in branches/safari-537.75-branch/Source/JavaScriptCore

Unreviewed build fix.
<rdar://problem/16197002>

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Exclude 64-bit assembly code when building

32-bit DebugSuffix target.

4:08 PM Changeset in webkit [165017] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Don't try to parse legacy CSS gradients -- we don't support them.

​https://bugs.webkit.org/show_bug.cgi?id=129623

Reviewed by Joseph Pecoraro.

• UserInterface/Models/Gradient.js:

(WebInspector.Gradient.stopsWithComponents): Fix a possible exception on malformed stops.
(WebInspector.LinearGradient.linearGradientWithComponents): Return early for legacy gradients.

3:55 PM BuildBot edited by Martin Robinson

Remove references to nonexistent ports (diff)

3:49 PM Changeset in webkit [165016] by mmaxfield@apple.com

• 7 edits
  2 adds in trunk

Space between double underlines does not scale with font size
​https://bugs.webkit.org/show_bug.cgi?id=129521

Reviewed by Simon Fraser.

Source/WebCore:

This patch moves the logic about how far to draw the second underline (when text-decoration-style: double
is specified) from InlineTextBox to GraphicsContext, because GraphicsContext is the authoritative source
about how thick underlines should be. The space between the two underlines is set to the thickness of
each of the underlines.

This patch also deletes some unused code in InlineTextBox that was never getting triggered, in addition
to unifying drawLineForText with drawLinesForText. This didn't have any performance impact in my testing.

Test: fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html

• platform/graphics/GraphicsContext.h: drawLineForText takes a boolean for if we should draw double

underlines.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):

• platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawLineForText):

• rendering/InlineTextBox.cpp: Use new boolean argument

(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

This test renders large text with a double underline, but then barely clips off the bottom underline
using overflow: hidden. It makes sure that this is exactly the same as a single underline. If the
space between the two underlines does not scale with font size, it will appear as though there is a
single thick underline (because they will be drawn on top of each other) and will thus fail this test.

• fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales-expected.html: Added.
• fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html: Added.

3:36 PM Changeset in webkit [165015] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Composited masks not working on iOS after r164890
​https://bugs.webkit.org/show_bug.cgi?id=129630

Reviewed by Jer Noble.

Fix typo in UIView-related masks code; set the mask layer
on the view, not the maskView.

• Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

3:30 PM Changeset in webkit [165014] by Chris Fleizach

• 19 edits
  2 copies
  4 adds in trunk

AX: Support IOS Accessibility in WK2
​https://bugs.webkit.org/show_bug.cgi?id=129527

Reviewed by Sam Weinig.

Source/WebCore:

Update the iOS wrapper so that it can convert points to screen space in WebKit2.

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):

Source/WebKit2:

Implement enough AX hooks so that accessibility can work in WebKit2.

• Platform/IPC/Connection.h:
• Platform/IPC/mac/ConnectionMac.cpp:

(IPC::Connection::identifier):

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView _updateForScreen:]):
(-[WKContentView _setAccessibilityWebProcessToken:]):
(-[WKContentView _accessibilityRegisterUIProcessTokens]):
(-[WKContentView _didRelaunchProcess]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/Plugins/PDF/PDFPlugin.mm:
• WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.h: Added.
• WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm: Added.

(-[WKAccessibilityWebPageObject init]):
(-[WKAccessibilityWebPageObject _accessibilityCategoryInstalled:]):
(-[WKAccessibilityWebPageObject pageScale]):
(-[WKAccessibilityWebPageObject dealloc]):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformInitializeAccessibility):
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h.
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm.

(-[WKAccessibilityWebPageObjectBase accessibilityFocusedUIElement]):

• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.h: Added.
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: Added.

(-[WKAccessibilityWebPageObject accessibilityIsIgnored]):
(-[WKAccessibilityWebPageObject accessibilityAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[WKAccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[WKAccessibilityWebPageObject convertScreenPointToRootView:]):
(-[WKAccessibilityWebPageObject accessibilityActionNames]):
(-[WKAccessibilityWebPageObject accessibilityChildren]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
(-[WKAccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

• WebProcess/WebPage/mac/WebPageMac.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):

3:07 PM Changeset in webkit [165013] by commit-queue@webkit.org

• 46 edits in trunk/Source

Add support for sessions to MemoryCache.
​https://bugs.webkit.org/show_bug.cgi?id=127794

Patch by Martin Hock <​mhock@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

Source/WebCore:

• WebCore.exp.in:
• editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Initialize CachedImage with sessionID.

• html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Remove URL from MemoryCache for all sessions.

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource): Pass sessionID to MemoryCache.

• inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR): Ditto.

• loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable): Ditto.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Ditto.

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Initialize CachedImage with sessionID.

• loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Pass sessionID to MemoryCache.

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Constructor takes sessionID.

• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedFont.cpp: Ditto.

(WebCore::CachedFont::CachedFont):

• loader/cache/CachedFont.h:
• loader/cache/CachedImage.cpp: Ditto.

(WebCore::CachedImage::CachedImage):

• loader/cache/CachedImage.h:
• loader/cache/CachedRawResource.cpp: Ditto.

(WebCore::CachedRawResource::CachedRawResource):

• loader/cache/CachedRawResource.h:
• loader/cache/CachedResource.cpp: Ditto.

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource): Pass sessionID to MemoryCache.

• loader/cache/CachedResource.h:

(WebCore::CachedResource::sessionID):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource): Constructors take sessionID.
(WebCore::CachedResourceLoader::sessionID): Retrieve sessionID from page.
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Pass sessionID to MemoryCache.
(WebCore::CachedResourceLoader::requestResource): Initialize CachedCSSStyleSheet with sessionID.
(WebCore::CachedResourceLoader::revalidateResource): Initialize cached resource with sessionID.
(WebCore::CachedResourceLoader::loadResource): Pass sessionID to MemoryCache and initialize cached resource with sessionID.

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedSVGDocument.cpp: Constructor takes sessionID.

(WebCore::CachedSVGDocument::CachedSVGDocument):

• loader/cache/CachedSVGDocument.h:
• loader/cache/CachedScript.cpp: Ditto.

(WebCore::CachedScript::CachedScript):

• loader/cache/CachedScript.h:
• loader/cache/CachedTextTrack.cpp: Ditto.

(WebCore::CachedTextTrack::CachedTextTrack):

• loader/cache/CachedTextTrack.h:
• loader/cache/CachedXSLStyleSheet.cpp: Ditto.

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

• loader/cache/CachedXSLStyleSheet.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getSessionMap): Retrieve CachedResourceMap based on sessionID.
(WebCore::MemoryCache::add): Use sessionID from CachedResource parameter.
(WebCore::MemoryCache::revalidationSucceeded): Add sessionID parameter.
(WebCore::MemoryCache::resourceForURL): Ditto.
(WebCore::MemoryCache::resourceForRequest): Ditto, also move impl into impl method.
(WebCore::MemoryCache::resourceForRequestImpl): Add CachedResourceMap parameter.
(WebCore::MemoryCache::addImageToCache): Use default sessionID.
(WebCore::MemoryCache::removeImageFromCache): Ditto.
(WebCore::MemoryCache::evict): Use sessionID from CachedResource parameter.
(WebCore::MemoryCache::removeResourcesWithOrigin): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::getOriginsWithCache): Ditto.
(WebCore::MemoryCache::removeUrlFromCache): Add sessionID parameter.
(WebCore::MemoryCache::removeRequestFromCache): Ditto.
(WebCore::MemoryCache::removeRequestFromCacheImpl): Ditto.
(WebCore::MemoryCache::removeRequestFromSessionCaches): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Add sessionID parameter.
(WebCore::MemoryCache::getStatistics): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::setDisabled): Ditto.

• loader/cache/MemoryCache.h: Create another level for cache.
• platform/CrossThreadCopier.cpp: Allow copying SessionIDs across threads.

(WebCore::SessionID>::copy):

• platform/CrossThreadCopier.h:
• platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest): Remove trailing whitespace.

• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Initialize CachedImage with sessionID.

• testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache): Pass sessionID to MemoryCache.

Source/WebKit:

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

• NetworkProcess/NetworkResourceLoader.h: Add sessionID() method.

(WebKit::NetworkResourceLoader::sessionID):

• NetworkProcess/mac/DiskCacheMonitor.h: Add sessionID member.
• NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor): Send sessionID to NetworkProcessConnection::DidCacheResource.

• WebProcess/Network/NetworkProcessConnection.cpp: Add sessionID parameter to didCacheResource and pass to MemoryCache.

(WebKit::NetworkProcessConnection::didCacheResource):

• WebProcess/Network/NetworkProcessConnection.h: Ditto.
• WebProcess/Network/NetworkProcessConnection.messages.in: Ditto.

3:04 PM Changeset in webkit [165012] by timothy@apple.com

• 3 edits in trunk/Source/WebInspectorUI

Remove an innocuous error message and support default views for Resource and Debugger sidebars.

​https://bugs.webkit.org/show_bug.cgi?id=129622

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView): Added.

• UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView): Added.
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Don't log an error
if the tree element isn't a Script. We try to find any represented object, and it can fail.

2:42 PM Changeset in webkit [165011] by Simon Fraser

• 2 edits in trunk/Tools

Add Jeremy Jones to the contributors list as a contributor.

• Scripts/webkitpy/common/config/contributors.json:

2:34 PM Changeset in webkit [165010] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove unused DataView code from JSDOMBinding.h
<​https://webkit.org/b/129616>

Reviewed by Antti Koivisto.

• bindings/js/JSDOMBinding.h:

2:28 PM Changeset in webkit [165009] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[x86] Improve code generation of byte test
​https://bugs.webkit.org/show_bug.cgi?id=129597

Reviewed by Geoffrey Garen.

When possible, test the 8 bit register to itself instead of comparing it
to a literal.

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::test32):

2:12 PM Changeset in webkit [165008] by mark.lam@apple.com

• 5 edits
  2 adds in trunk

Web Inspector: debugger statements do not break.
<​https://webkit.org/b/129524>

Reviewed by Geoff Garen.

Source/JavaScriptCore:

Since we no longer call op_debug hooks unless there is a debugger request
made on the CodeBlock, the op_debug for the debugger statement never gets
serviced.

With this fix, we check in the CodeBlock constructor if any debugger
statements are present. If so, we set a m_hasDebuggerStatement flag that
causes the CodeBlock to show as having debugger requests. Hence,
breaking at debugger statements is now restored.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::hasDebuggerRequests):
(JSC::CodeBlock::clearDebuggerRequests):

LayoutTests:

• inspector-protocol/debugger/debugger-statement-expected.txt: Added.
• inspector-protocol/debugger/debugger-statement.html: Added.
• inspector-protocol/debugger/resources/breakpoint.js:

(debuggerStatement):

1:52 PM Changeset in webkit [165007] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Fix an exception caused by trying to access the DOM before it is loaded.

​https://bugs.webkit.org/show_bug.cgi?id=129617

Reviewed by Andreas Kling.

• UserInterface/Base/Main.js:

(WebInspector.loaded): Move global event listeners from here...
(WebInspector.contentLoaded): ... to here.

1:45 PM Changeset in webkit [165006] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Allow overflow-scroll to be one-finger scrolled until we hook up UIScrollViews
​https://bugs.webkit.org/show_bug.cgi?id=129621

Reviewed by Benjamin Poulain.

Temporary change to allow overflow:scroll to be scrolled in iOS WK2.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasAcceleratedTouchScrolling):

1:39 PM Changeset in webkit [165005] by mark.lam@apple.com

• 16 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: m_numBreakpoints >= numBreakpoints when deleting breakpoints.
<​https://webkit.org/b/129393>

Reviewed by Geoffrey Garen.

The issue manifests because the debugger will iterate all CodeBlocks in
the heap when setting / clearing breakpoints, but it is possible for a
CodeBlock to have been instantiate but is not yet registered with the
debugger. This can happen because of the following:

1. DFG worklist compilation is still in progress, and the target codeBlock is not ready for installation in its executable yet.

2. DFG compilation failed and we have a codeBlock that will never be installed in its executable, and the codeBlock has not been cleaned up by the GC yet.

The code for installing the codeBlock in its executable is the same code
that registers it with the debugger. Hence, these codeBlocks are not
registered with the debugger, and any pending breakpoints that would map
to that CodeBlock is as yet unset or will never be set. As such, an
attempt to remove a breakpoint in that CodeBlock will fail that assertion.

To fix this, we do the following:

1. We'll eagerly clean up any zombie CodeBlocks due to failed DFG / FTL compilation. This is achieved by providing a DeferredCompilationCallback::compilationDidComplete() that does this clean up, and have all sub classes call it at the end of their compilationDidComplete() methods.

2. Before the debugger or profiler iterates CodeBlocks in the heap, they will wait for all compilations to complete before proceeding. This ensures that:
   1. any zombie CodeBlocks would have been cleaned up, and won't be seen by the debugger or profiler.
   2. all CodeBlocks that the debugger and profiler needs to operate on will be "ready" for whatever needs to be done to them e.g. jettison'ing of DFG codeBlocks.

• bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::compilationDidComplete):

• bytecode/DeferredCompilationCallback.h:
• Provide default implementation method to clean up zombie CodeBlocks.

• debugger/Debugger.cpp:

(JSC::Debugger::forEachCodeBlock):

• Utility function to iterate CodeBlocks. It ensures that all compilations are complete before proceeding.

(JSC::Debugger::setSteppingMode):
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::recompileAllJSFunctions):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::clearDebuggerRequests):

• Use the utility iterator function.

• debugger/Debugger.h:
• dfg/DFGOperations.cpp:
• Added an assert to ensure that zombie CodeBlocks will be imminently cleaned up.

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):

• Remove unneeded code (that was not the best solution anyway) for ensuring that we don't generate new DFG codeBlocks after enabling the debugger or profiler. Now that we wait for compilations to complete before proceeding with debugger and profiler work, this scenario will never happen.

• dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

• Call the super class method to clean up zombie codeBlocks.

• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

• Call the super class method to clean up zombie codeBlocks.

• heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::remove):

• heap/CodeBlockSet.h:
• heap/Heap.h:

(JSC::Heap::removeCodeBlock):

• New method to remove a codeBlock from the codeBlock set.

• jit/JITOperations.cpp:
• Added an assert to ensure that zombie CodeBlocks will be imminently cleaned up.

• jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

• Call the super class method to clean up zombie codeBlocks.

• runtime/VM.cpp:

(JSC::VM::waitForCompilationsToComplete):

• Renamed from prepareToDiscardCode() to be clearer about what it does.

(JSC::VM::discardAllCode):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::setEnabledProfiler):

• Wait for compilation to complete before enabling the profiler.

• runtime/VM.h:

1:33 PM Changeset in webkit [165004] by BJ Burg

• 2 edits in trunk/LayoutTests

Inspector test dom/dom-search-crash.html times out in release builds
​https://bugs.webkit.org/show_bug.cgi?id=129462

Reviewed by Timothy Hatcher.

This test passes now, so stop skipping it.

• TestExpectations:

1:32 PM Changeset in webkit [165003] by benjamin@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Regression: ScrollView's scroll offset is never set after r164702
​https://bugs.webkit.org/show_bug.cgi?id=129620

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-03
Reviewed by Simon Fraser.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

1:11 PM Changeset in webkit [165002] by Antti Koivisto

• 7 edits
  4 adds in trunk

Find results on simple lines are not marked correctly
​https://bugs.webkit.org/show_bug.cgi?id=129586

Reviewed by Andreas Kling.

Source/WebCore:

Tests: editing/text-iterator/count-mark-lineboxes.html

editing/text-iterator/count-mark-simple-lines.html

TextIterator operating on simple lines failed to take the end of the range into account.
This also causes performance issues on long documents as range traversals would miss the end
node and end up going through the entire document.

• editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):

Stop when hitting the range end on simple text nodes.

(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):

Use hasRenderedText test instead of linebox-only firstTextBox.

• testing/Internals.cpp:

(WebCore::Internals::countMatchesForText):

• testing/Internals.h:
• testing/Internals.idl:

Add testing interface for counting and marking matches.

LayoutTests:

• editing/text-iterator/count-mark-lineboxes-expected.txt: Added.
• editing/text-iterator/count-mark-lineboxes.html: Added.
• editing/text-iterator/count-mark-simple-lines-expected.txt: Added.
• editing/text-iterator/count-mark-simple-lines.html: Added.

12:57 PM Changeset in webkit [165001] by benjamin@webkit.org

• 2 edits in trunk/Source/WebCore

SelectorQuery failing RightMostWithIdMatch are compiling their selectors for each execution
​https://bugs.webkit.org/show_bug.cgi?id=129601

Reviewed by Andreas Kling.

This caused a regression after r164924 for documents in quirks mode. Since those always fail
selectorForIdLookup(), they ended up compiling the selector every time they were called.

• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute):

12:47 PM Changeset in webkit [165000] by jer.noble@apple.com

• 6 edits in trunk/Source/WebCore

[Mac] Crash in MediaPlayer::rateChanged()
​https://bugs.webkit.org/show_bug.cgi?id=129548

Reviewed by Darin Adler.

WTF::bind will automatically ref the parameters added to it. But MediaPlayerPrivate-
AVFoundation and -MediaSOurceAVFObjC are not RefCounted, so by the time the bound
function is called, the underlying objects may have been freed.

Replace or augment callOnMainThread arguments with lambdas and weakPtrs so that
if the argument has been destroyed, its methods will not be called.

Make the MediaPlayerPrivateAVFoundation::Notification function type a std::function:

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):

Make createWeakPtr() public so that it can be called from non-class methods:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createWeakPtr):

Use a weakPtr to abort callOnMainThread() if the object has been destroyed:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::CMTimebaseEffectiveRateChangedCallback):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):

12:47 PM Changeset in webkit [164999] by jer.noble@apple.com

• 8 edits
  2 adds in trunk

[MSE] YouTube videos fail to play
​https://bugs.webkit.org/show_bug.cgi?id=129525

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-fudge-factor.html

Add a very simple playability metric to SourceBuffer. Track the number of seconds buffered
and use that metric to determine whether the MediaSource has buffered enough data to play
through.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::currentTime): Added simple accessor.
(WebCore::MediaSource::monitorSourceBuffers): Replace the functor-based iterators with lambdas.
(WebCore::MediaSource::addSourceBuffer): Drive-by fix; only add new source buffers to the

activeSourceBuffers list if those buffers are actually active.

• Modules/mediasource/MediaSource.h:
• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Initialize new ivars.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Measure the number of seconds buffered.
(WebCore::SourceBuffer::monitorBufferingRate): Use a simple Exponential moving average to

track the buffering rate.

(WebCore::SourceBuffer::hasCurrentTime): Return true if the current time is within 1/24 s

of a buffered range.

(WebCore::SourceBuffer::hasFutureTime): Moved from MediaSource.
(WebCore::SourceBuffer::canPlayThrough): Return true if the buffering rate is > 1s per

second, or if the rate is sufficient to keep up over the remaining time.

• Modules/mediasource/SourceBuffer.h:

LayoutTests:

• media/media-source/media-source-addsourcebuffer.html: Updated.
• media/media-source/media-source-addsourcebuffer-expected.txt: Updated.
• media/media-source/media-source-fudge-factor-expected.txt: Added.
• media/media-source/media-source-fudge-factor.html: Added.

12:24 PM Changeset in webkit [164998] by betravis@adobe.com

• 8 edits in trunk

[CSS Shapes] Serialize circle positions
​https://bugs.webkit.org/show_bug.cgi?id=129404

Reviewed by Dirk Schulze.

Source/WebCore:

Circle positions should always be present when serialized, and should
only have the 2 or 4-valued form. Keywords are converted to percentages
and simplified where possible. This patch adds some additional processing
that converts the parsed position into the serialized format, before
converting it to text. See ​http://dev.w3.org/csswg/css-shapes/#basic-shape-serialization.

Updated existing parsing tests.

• css/CSSBasicShapes.cpp:

(WebCore::serializePositionOffset): Convert a position offset to a serialized string.
The offset must be a pair, as generated by buildSerializablePositionOffset.
(WebCore::buildSerializablePositionOffset): Generates a keyword + offset pair for each
position offset. The keywords may later be dropped during serialization.
(WebCore::CSSBasicShapeCircle::cssText): Use the new serialization methods.

LayoutTests:

Modify each circle test to have a correctly serialized position.

• fast/masking/parsing-clip-path-shape-expected.html: Updated result.
• fast/masking/parsing-clip-path-shape.html: Updated test.
• fast/shapes/parsing/parsing-shape-inside-expected.txt: Updated results.
• fast/shapes/parsing/parsing-shape-outside-expected.txt: Updated results.
• fast/shapes/parsing/parsing-test-utils.js: Updated serialization results.

12:01 PM Changeset in webkit [164997] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Crash when going into video fullscreen on iOS
​https://bugs.webkit.org/show_bug.cgi?id=129613

Reviewed by Dean Jackson.

We shouldn't reparent a UIView's layer without unparenting
the view first.

• UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):

11:30 AM Changeset in webkit [164996] by Lucas Forschler

• 2 edits in tags/Safari-538.20.1/Source/WebCore

Merged r164873.

11:18 AM AddingFiles edited by BJ Burg

details on adding code generators for win and mac (diff)

11:07 AM Changeset in webkit [164995] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Optimize StylePropertiesSet::findPropertyIndex() to improve CSS properties performance
​https://bugs.webkit.org/show_bug.cgi?id=129605

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-03-03
Reviewed by Andreas Kling.

Merged from Blink (patch by Mikhail Pozdnyakov):
​https://src.chromium.org/viewvc/blink?view=revision&revision=167325

Avoid checking whether 'StylePropertiesSet' is mutable and accesing directly to its
data members to achieve performance improvements

Before the optimization applied:

mean: 3064.8337171934063 runs/s
median: 3097.5899379343855 runs/s
stdev: 66.89274074044187 runs/s
min: 2891.7479324362585 runs/s
max: 3113.288683440125 runs/s

After the optimization applied:

mean: 3343.8356114138105 runs/s
median: 3356.25682957446 runs/s
stdev: 36.297533087489036 runs/s
min: 3238.5468032264243 runs/s
max: 3368.664837531425 runs/s

Performance gain for the average value is approx. 9.1%, in the
range of the 10% - 8.2% for the min and max measured
values (Linux desktop x64).

• css/StyleProperties.cpp:

(WebCore::ImmutableStyleProperties::findPropertyIndex):
(WebCore::MutableStyleProperties::findPropertyIndex):

• css/StyleProperties.h:

(WebCore::toMutableStyleProperties):
(WebCore::toImmutableStyleProperties):
(WebCore::StyleProperties::findPropertyIndex):

11:02 AM Changeset in webkit [164994] by Lucas Forschler

• 5 edits in tags/Safari-538.20.1/Source

Versioning.

11:00 AM Changeset in webkit [164993] by Lucas Forschler

• 1 copy in tags/Safari-538.20.1

New Tag.

10:32 AM Changeset in webkit [164992] by krit@webkit.org

• 6 edits
  6 copies
  2 moves
  3 adds
  23 deletes in trunk/LayoutTests

Transform CSS clip-path pixel tests to ref tests
​https://bugs.webkit.org/show_bug.cgi?id=129607

Reviewed by Andreas Kling.

• css3/masking/clip-path-border-box.html:
• css3/masking/clip-path-circle-filter-expected.txt: Removed.
• css3/masking/clip-path-circle-overflow-expected.txt: Removed.
• css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
• css3/masking/clip-path-circle-overflow-hidden.html: Removed.
• css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
• css3/masking/clip-path-ellipse-expected.html: Renamed from LayoutTests/css3/masking/clip-path-circle-filter.html.
• css3/masking/clip-path-ellipse-expected.txt: Removed.
• css3/masking/clip-path-ellipse.html:
• css3/masking/clip-path-filter-expected.html: Added.
• css3/masking/clip-path-filter.html: Added.
• css3/masking/clip-path-inset-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
• css3/masking/clip-path-inset-expected.txt: Removed.
• css3/masking/clip-path-overflow-expected.html: Copied from LayoutTests/css3/masking/clip-path-circle-overflow.html.
• css3/masking/clip-path-overflow-hidden-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
• css3/masking/clip-path-overflow-hidden.html: Renamed from LayoutTests/css3/masking/clip-path-circle-overflow.html.
• css3/masking/clip-path-overflow.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
• css3/masking/clip-path-polygon-evenodd-expected.html: Added.
• css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
• css3/masking/clip-path-polygon-evenodd.html:
• css3/masking/clip-path-polygon-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
• css3/masking/clip-path-polygon-expected.txt: Removed.
• css3/masking/clip-path-polygon-nonzero-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
• css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
• css3/masking/clip-path-polygon-nonzero.html:
• css3/masking/clip-path-polygon.html:
• platform/efl/css3/masking/clip-path-circle-overflow-expected.png: Removed.
• platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
• platform/efl/css3/masking/clip-path-ellipse-expected.png: Removed.
• platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Removed.
• platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
• platform/gtk/css3/masking/clip-path-ellipse-expected.png: Removed.
• platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Removed.
• platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
• platform/mac/css3/masking/clip-path-ellipse-expected.png: Removed.
• platform/mac/css3/masking/clip-path-inset-expected.png: Removed.
• platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Removed.
• platform/mac/css3/masking/clip-path-polygon-expected.png: Removed.
• platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Removed.

10:24 AM Changeset in webkit [164991] by BJ Burg

• 2 edits in trunk/Source/JavaScriptCore

Another unreviewed build fix attempt for Windows after r164986.

We never told Visual Studio to copy over the web replay code generator scripts
and the generated headers for JavaScriptCore replay inputs as if they were
private headers.

• JavaScriptCore.vcxproj/copy-files.cmd:

10:20 AM Changeset in webkit [164990] by cavalcantii@gmail.com

• 2 edits in trunk/Tools

Update the email.

9:46 AM Changeset in webkit [164989] by BJ Burg

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for Windows after r164986.

• WebCore.vcxproj/build-generated-files.sh: Export WebReplayScripts

so that the build system knows how to find CodeGeneratorReplayInputs.py.

9:16 AM Changeset in webkit [164988] by abucur@adobe.com

• 21 edits in trunk

[CSS Regions] Overset computation is incorrect in some cases
​https://bugs.webkit.org/show_bug.cgi?id=129032

Reviewed by Mihnea Ovidenie.

Source/WebCore:

This patch reworks the way overset is computed for regions and named flows.

1. Regions overflow no longer trigger an overset changed event. This is because

the overflow of a box is contained within the region range of the box. The content
edge should be considered the logical bottom position of the content inside the
flow thread.

2. The regions events logic was moved from RenderFlowThread to RenderNamedFlowThread

and from RenderRegion to RenderNamedFlowFragment (including the regionOverset property).

3. The overset value of the named flow is no longer stored in the named flow. It is

extracted from the overset of the last region in the chain.

4. The regions overset is not computed every time the flow thread is laid out which

should improve performance for flows with many regions. With the patch, each region
computes the overset value during its layout when the flow thread is in the overflow
or the final layout phase.

5. The overset changed event is dispatched only at the end of the layout of the named flows,

after all the region overset changes have been considered. This means that the overset
event can't be dispatched in the middle of the auto-height processing algorithm that
requires multiple layout passes for the flow threads.

However, the region layout update event dispatch timing was not changed, it is dispatched
every time the flow thread has a layout. This preserves the current behavior of the event.

Tests: The old tests were modified to take into account the change.

• dom/Element.cpp:

(WebCore::Element::webkitRegionOverset):

• dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::overset):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForRegions):

• rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

• rendering/RenderFlowThread.h:
• rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::setRegionOversetState):
(WebCore::RenderNamedFlowFragment::regionOversetState):
(WebCore::RenderNamedFlowFragment::updateOversetState):

• rendering/RenderNamedFlowFragment.h:
• rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOverflow):
(WebCore::RenderNamedFlowThread::layout):
(WebCore::RenderNamedFlowThread::dispatchNamedFlowEvents):
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEventIfNeeded):

• rendering/RenderNamedFlowThread.h:

There's a new field called m_flowContentBottom that tracks the content bottom of the flow thread
after layout. This value is used to compute the overset value of the regions because it's not
affected by relative positioning or visual overflow such as shadows.

• rendering/RenderRegion.cpp:
• rendering/RenderRegion.h:

LayoutTests:

Adjust the tests to cope with the overset changes.

• fast/regions/cssom/element-region-overset-state-expected.txt:
• fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt:
• fast/regions/cssom/element-region-overset-state-vertical-rl.html:
• fast/regions/cssom/element-region-overset-state.html:

This test has a new case that verifies region clamping is correctly taken into account.

• fast/regions/cssom/webkit-named-flow-overset-expected.txt:
• fast/regions/cssom/webkit-named-flow-overset.html:

9:06 AM Changeset in webkit [164987] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] CodeGeneratorGObject.pm remove usage of undefined variable
​https://bugs.webkit.org/show_bug.cgi?id=129602

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-03-03
Reviewed by Martin Robinson.

Remove usage of undefined variable hdrPropIncludes in CodeGeneratorGObject.pm

• bindings/scripts/CodeGeneratorGObject.pm:

(WriteData):

9:01 AM Changeset in webkit [164986] by BJ Burg

• 18 edits
  11 copies
  14 adds in trunk/Source

Web Replay: upstream input storage, capture/replay machinery, and inspector domain
​https://bugs.webkit.org/show_bug.cgi?id=128782

Source/JavaScriptCore:

Reviewed by Timothy Hatcher.

Alter the replay inputs code generator so that it knows when it is necessary to
to include headers for HEAVY_SCALAR types such as WTF::String and WebCore::URL.

• JavaScriptCore.xcodeproj/project.pbxproj:
• replay/scripts/CodeGeneratorReplayInputs.py:

(Framework.fromString):
(Frameworks): Add WTF as an allowed framework for code generation.
(Generator.generate_includes): Include headers for HEAVY_SCALAR types in the header file.
(Generator.generate_includes.declaration):
(Generator.generate_includes.or):
(Generator.generate_type_forward_declarations): Skip HEAVY_SCALAR types.

Source/WebCore:

Reviewed by Timothy Hatcher, Joseph Pecoraro, and Andreas Kling.

No new tests yet, as they rely on infrastructure tracked in ​https://webkit.org/b/129190.

Replayable executions are organized into ReplaySessions, which can
contain several ReplaySessionSegments that divide overall execution
at main frame navigation boundaries. NondeterministicInput subclasses
are stored in SegmentedInputStorage according to the input's InputQueue.

Capture and playback are controlled at the page granularity by the Page's
ReplayController. The controller knows how to create new segments, replay to
arbitrary positions in the ReplaySession, and track the active InputCursor.

The capturing and replaying input cursor subclasses encapsulate state for
storing new inputs and loading/dispatching saved inputs, respectively.

The ReplayAgent and associated inspector protocol domain is the friendly
public API for programmatically capturing and replaying sessions.

• DerivedSources.make: Add replay inputs code generation target. Add the

replay domain specification to the list of inspector domains.

• ForwardingHeaders/replay/EncodedValue.h: Added.
• WebCore.xcodeproj/project.pbxproj: Add many files, and export

WebReplayScripts environment variable to DerivedSources.make.

• inspector/InspectorController.cpp: Add the replay agent.

(WebCore::InspectorController::InspectorController):

• inspector/InspectorInstrumentation.cpp:

Add events for segment lifecycle events, and loading/unloading of sessions
and segments, and capture/replay progress events. The replay controller
also needs to know about detached and committed frames.

(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::sessionCreatedImpl):
(WebCore::InspectorInstrumentation::sessionLoadedImpl):
(WebCore::InspectorInstrumentation::sessionModifiedImpl):
(WebCore::InspectorInstrumentation::segmentCreatedImpl):
(WebCore::InspectorInstrumentation::segmentCompletedImpl):
(WebCore::InspectorInstrumentation::segmentLoadedImpl):
(WebCore::InspectorInstrumentation::segmentUnloadedImpl):
(WebCore::InspectorInstrumentation::captureStartedImpl):
(WebCore::InspectorInstrumentation::captureStoppedImpl):
(WebCore::InspectorInstrumentation::playbackStartedImpl):
(WebCore::InspectorInstrumentation::playbackPausedImpl):
(WebCore::InspectorInstrumentation::playbackHitPositionImpl):
(WebCore::InspectorInstrumentation::replayAgentEnabled):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::replayAgentEnabled):
(WebCore::InspectorInstrumentation::sessionCreated):
(WebCore::InspectorInstrumentation::sessionLoaded):
(WebCore::InspectorInstrumentation::sessionModified):
(WebCore::InspectorInstrumentation::segmentCreated):
(WebCore::InspectorInstrumentation::segmentCompleted):
(WebCore::InspectorInstrumentation::segmentLoaded):
(WebCore::InspectorInstrumentation::segmentUnloaded):
(WebCore::InspectorInstrumentation::captureStarted):
(WebCore::InspectorInstrumentation::captureStopped):
(WebCore::InspectorInstrumentation::playbackStarted):
(WebCore::InspectorInstrumentation::playbackPaused):
(WebCore::InspectorInstrumentation::playbackHitPosition):

• inspector/InspectorReplayAgent.cpp: Added.

(WebCore::buildInspectorObjectForPosition):
(WebCore::buildInspectorObjectForInput):
(WebCore::buildInspectorObjectForSession):
(WebCore::SerializeInputToJSONFunctor::SerializeInputToJSONFunctor):
(WebCore::SerializeInputToJSONFunctor::~SerializeInputToJSONFunctor):
(WebCore::SerializeInputToJSONFunctor::operator()):
(WebCore::SerializeInputToJSONFunctor::returnValue):
(WebCore::buildInspectorObjectForSegment):
(WebCore::InspectorReplayAgent::InspectorReplayAgent):
(WebCore::InspectorReplayAgent::~InspectorReplayAgent):
(WebCore::InspectorReplayAgent::sessionState):
(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):
(WebCore::InspectorReplayAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorReplayAgent::frameNavigated):
(WebCore::InspectorReplayAgent::frameDetached):
(WebCore::InspectorReplayAgent::sessionCreated):
(WebCore::InspectorReplayAgent::sessionModified):
(WebCore::InspectorReplayAgent::sessionLoaded):
(WebCore::InspectorReplayAgent::segmentCreated):
(WebCore::InspectorReplayAgent::segmentCompleted):
(WebCore::InspectorReplayAgent::segmentLoaded):
(WebCore::InspectorReplayAgent::segmentUnloaded):
(WebCore::InspectorReplayAgent::captureStarted):
(WebCore::InspectorReplayAgent::captureStopped):
(WebCore::InspectorReplayAgent::playbackStarted):
(WebCore::InspectorReplayAgent::playbackPaused):
(WebCore::InspectorReplayAgent::playbackHitPosition):
(WebCore::InspectorReplayAgent::startCapturing):
(WebCore::InspectorReplayAgent::stopCapturing):
(WebCore::InspectorReplayAgent::replayToPosition):
(WebCore::InspectorReplayAgent::replayToCompletion):
(WebCore::InspectorReplayAgent::pausePlayback):
(WebCore::InspectorReplayAgent::cancelPlayback):
(WebCore::InspectorReplayAgent::switchSession):
(WebCore::InspectorReplayAgent::insertSessionSegment):
(WebCore::InspectorReplayAgent::removeSessionSegment):
Provide a public API for modifying sessions. This is the backend support
for user editing of replay sessions to add/remove specific segments.

(WebCore::InspectorReplayAgent::findSession):
(WebCore::InspectorReplayAgent::findSegment):
(WebCore::InspectorReplayAgent::getAvailableSessions):
(WebCore::InspectorReplayAgent::getSerializedSession):
(WebCore::InspectorReplayAgent::getSerializedSegment):
Most of the replay protocol domain speaks in terms of sesssion and
segment identifiers. These functions return the actual data associated
with these identifiers.

• inspector/InspectorReplayAgent.h: Added.
• inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

• inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorReplayAgent): Added.
(WebCore::InstrumentingAgents::setInspectorReplayAgent): Added.

• inspector/protocol/Replay.json: Added.

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::replayController): Added.

• platform/Logging.h: Add WebReplay logging channel.
• replay/AllReplayInputs.h: Added. Simplifies importing all input definitions.

• replay/CapturingInputCursor.cpp: Added.

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::~CapturingInputCursor):
(WebCore::CapturingInputCursor::create):
(WebCore::CapturingInputCursor::storeInput):
(WebCore::CapturingInputCursor::loadInput):
(WebCore::CapturingInputCursor::uncheckedLoadInput):

• replay/CapturingInputCursor.h: Added.

• replay/EventLoopInput.h:

(WebCore::EventLoopInputBase::EventLoopInputBase):
(WebCore::EventLoopInputBase::timestamp):
(WebCore::EventLoopInputBase::setTimestamp): Support deserialization.

• replay/EventLoopInputDispatcher.cpp: Added. This class encapsulates the timers

and measurements used to dispatch event loop inputs during replay.

(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):
(WebCore::EventLoopInputDispatcher::run):
(WebCore::EventLoopInputDispatcher::pause):
(WebCore::EventLoopInputDispatcher::timerFired):
(WebCore::EventLoopInputDispatcher::dispatchInputSoon):
(WebCore::EventLoopInputDispatcher::dispatchInput):

• replay/EventLoopInputDispatcher.h: Added.

(WebCore::EventLoopInputDispatcherClient::EventLoopInputDispatcherClient):
(WebCore::EventLoopInputDispatcherClient::~EventLoopInputDispatcherClient):

• replay/FunctorInputCursor.h: Added.

(WebCore::FunctorInputCursor::~FunctorInputCursor):
(WebCore::FunctorInputCursor::forEachInputInQueue):
(WebCore::FunctorInputCursor::FunctorInputCursor):
(WebCore::FunctorInputCursor::storeInput):
(WebCore::FunctorInputCursor::loadInput):
(WebCore::FunctorInputCursor::uncheckedLoadInput):

• replay/ReplayController.cpp: Added.

(WebCore::ReplayController::ReplayController):
(WebCore::ReplayController::switchSession):
(WebCore::ReplayController::createSegment):
(WebCore::ReplayController::completeSegment):
(WebCore::ReplayController::loadSegment):
(WebCore::ReplayController::unloadSegment):
(WebCore::ReplayController::startCapturing):
(WebCore::ReplayController::stopCapturing):
(WebCore::ReplayController::startPlayback):
(WebCore::ReplayController::pausePlayback):
(WebCore::ReplayController::cancelPlayback):
(WebCore::ReplayController::replayToPosition):
(WebCore::ReplayController::frameDetached):
(WebCore::ReplayController::frameNavigated):
(WebCore::ReplayController::loadedSession):
(WebCore::ReplayController::loadedSegment):
(WebCore::ReplayController::activeInputCursor):
(WebCore::ReplayController::dispatcher):
(WebCore::ReplayController::willDispatchInput):
(WebCore::ReplayController::didDispatchInput):
(WebCore::ReplayController::didDispatchFinalInput):

• replay/ReplayController.h: Added.

(WebCore::ReplayPosition::ReplayPosition):
(WebCore::ReplayPosition::operator<):
(WebCore::ReplayPosition::operator==):

• replay/ReplayInputCreationMethods.cpp: Added.

Static factory implementations for inputs belong here.
(WebCore::InitialNavigation::createFromPage):

• replay/ReplayInputDispatchMethods.cpp: Added.

All dispatch() implementations for generated replay inputs belong here.
(WebCore::BeginSegmentSentinel::dispatch):
(WebCore::EndSegmentSentinel::dispatch):
(WebCore::InitialNavigation::dispatch):

• replay/ReplayInputTypes.cpp:

(WebCore::ReplayInputTypes::ReplayInputTypes):

• replay/ReplayInputTypes.h: Define strings for WebCore inputs.

• replay/ReplaySession.cpp: Added.

(WebCore::ReplaySession::create):
(WebCore::ReplaySession::ReplaySession):
(WebCore::ReplaySession::~ReplaySession):
(WebCore::ReplaySession::appendSegment):
(WebCore::ReplaySession::insertSegment):
(WebCore::ReplaySession::removeSegment):

• replay/ReplaySession.h: Added.

(WebCore::ReplaySession::identifier):
(WebCore::ReplaySession::timestamp):
(WebCore::ReplaySession::size):
(WebCore::ReplaySession::at):
(WebCore::ReplaySession::begin):
(WebCore::ReplaySession::end):

• replay/ReplaySessionSegment.cpp: Added.

(WebCore::ReplaySessionSegment::create):
(WebCore::ReplaySessionSegment::ReplaySessionSegment):
(WebCore::ReplaySessionSegment::~ReplaySessionSegment):
(WebCore::ReplaySessionSegment::createCapturingCursor):
(WebCore::ReplaySessionSegment::createReplayingCursor):
(WebCore::ReplaySessionSegment::createFunctorCursor):

• replay/ReplaySessionSegment.h: Added.

(WebCore::ReplaySessionSegment::identifier):
(WebCore::ReplaySessionSegment::timestamp):

• replay/ReplayingInputCursor.cpp: Added.

(WebCore::ReplayingInputCursor::ReplayingInputCursor):
(WebCore::ReplayingInputCursor::~ReplayingInputCursor):
(WebCore::ReplayingInputCursor::create):
(WebCore::ReplayingInputCursor::storeInput):
(WebCore::ReplayingInputCursor::loadInput):
(WebCore::ReplayingInputCursor::uncheckedLoadInput):

• replay/ReplayingInputCursor.h: Added.

• replay/SegmentedInputStorage.cpp: Added.

(WebCore::queueTypeToLogPrefix):
(WebCore::jsonStringForInput):
(WebCore::offsetForInputQueue):
(WebCore::SegmentedInputStorage::SegmentedInputStorage):
(WebCore::SegmentedInputStorage::~SegmentedInputStorage):
(WebCore::SegmentedInputStorage::load):
(WebCore::SegmentedInputStorage::store):
(WebCore::SegmentedInputStorage::queueSize):

• replay/SegmentedInputStorage.h: Added.

• replay/SerializationMethods.cpp: Added.

Specializations of EncodingTraits for WebCore types belong here.

(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
(JSC::EncodingTraits<NondeterministicInputBase>::decodeValue):
(JSC::EncodingTraits<SecurityOrigin>::encodeValue):
(JSC::EncodingTraits<SecurityOrigin>::decodeValue):
(JSC::EncodingTraits<URL>::encodeValue):
(JSC::EncodingTraits<URL>::decodeValue):

• replay/SerializationMethods.h: Added.
• replay/WebInputs.json: Added.

In this inital patch, we define BeginSegmentSentinel,
EndSegmentSentinel, and InitialNavigation inputs.

5:47 AM Changeset in webkit [164985] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.3.91

Tagging the WebKitGTK+ 2.3.91 release

4:59 AM Changeset in webkit [164984] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.3.91 release.

.:

• Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

• NEWS: Added release notes for 2.3.91.

3:57 AM Changeset in webkit [164983] by graouts@webkit.org

• 5 edits in trunk/Source/WebCore

Respect SVG fragment identifiers in <img> src attribute
​https://bugs.webkit.org/show_bug.cgi?id=129387

Reviewed by Dirk Schulze.

Following Dirk Schulze's suggestion, we set the URL on the SVGImage itself and handle the URL's
fragment identifier at draw time in the SVGImage itself, which will provide a sounder base for
handling of fragment identifier in SVG resource URLs in CSS properties, and should also deal
with the crasher reported in ​http://webkit.org/b/129498 since there is a guaranteed Frame at the
time we call SVGImage::draw().

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

• svg/graphics/SVGImage.h:
• svg/graphics/SVGImageForContainer.cpp:
• svg/graphics/SVGImageForContainer.h:

2:32 AM Changeset in webkit [164982] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r164980 - [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
​https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

2:32 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

2:17 AM Changeset in webkit [164981] by lvidacs.u-szeged@partner.samsung.com

• 4 edits in trunk/Source/WebCore

Move function calls outside loop in dom
​https://bugs.webkit.org/show_bug.cgi?id=126525

Reviewed by Csaba Osztrogonác.

Store the result of length() in a local variable and use it in each iteration.

• dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::isXMLMIMEType):

• dom/ElementData.cpp:

(WebCore::UniqueElementData::UniqueElementData):

• dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability):

2:16 AM Changeset in webkit [164980] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
​https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

2:15 AM Changeset in webkit [164979] by commit-queue@webkit.org

• 4 edits in trunk

[cmake] *Names.cpp file should be regenerated after touching StaticString.pm
​https://bugs.webkit.org/show_bug.cgi?id=129031

Patch by Jozsef Berta <​jberta.u-szeged@partner.samsung.com> on 2014-03-03
Reviewed by Csaba Osztrogonác.

.:

• Source/cmake/WebKitMacros.cmake: Added a call for make_names.pm dependencies in GENERATE_FONT_NAMES and GENERATE_DOM_NAMES macros.

Source/WebCore:

• CMakeLists.txt: Added make_names.pl dependencies: bindings/scripts/Hasher.pm and bindings/scripts/StaticString.pm

1:07 AM Changeset in webkit [164978] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Revert r159999 - "Correct broken build on efl port with --no-netscape-plugin-api"

This reverts commit r159999.

12:43 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos

(diff)

12:36 AM Changeset in webkit [164977] by calvaris@igalia.com

• 4 edits in trunk/Source/WebCore

[GTK] Multimedia controls captions icon needs its own metaphor
​https://bugs.webkit.org/show_bug.cgi?id=129091

Reviewed by Martin Robinson.

As we got the new icon created, we used it with a fallback to the
old icon to keep run-time compatibility.

No new tests, current ones suffice.

• platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
Replicated RenderThemeGtk::paintMediaButton to check for the
necessary icon first and do the fallback to the old and stock
icons.

• platform/gtk/RenderThemeGtk2.cpp:

(WebCore::getStockIconForWidgetType): Added ASSERT for non-empty
icon name.
(WebCore::getStockSymbolicIconForWidgetType): Check for non empty
icon name before calling getStockIconForWidgetType. Fixed coding
style.

• platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStockIconForWidgetType): Added ASSERT for non-empty
icon name.
(WebCore::getStockSymbolicIconForWidgetType): Check for non empty
icon name before calling getStockIconForWidgetType. Fixed coding
style.

12:24 AM Changeset in webkit [164976] by Carlos Garcia Campos

• 4 edits
  1 add in releases/WebKitGTK/webkit-2.4

Merge r164973 - [GTK] WebKit2WebExtension GIR can't be used in vala
​https://bugs.webkit.org/show_bug.cgi?id=127179

Reviewed by Martin Robinson.

Add a different pkg-config file for the web extensions API.

.:

• configure.ac:

Source/WebKit2:

• GNUmakefile.am:
• webkit2gtk-web-extension.pc.in: Added.

12:22 AM Changeset in webkit [164975] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164940 - [GTK] Make impossible to build with <webkit2/webkit2.h> and <webkit2/webkit-web-extension.h> included together
​https://bugs.webkit.org/show_bug.cgi?id=129549

Reviewed by Martin Robinson.

Add a compile error to prevent mixing the UI and web process APIs.

• UIProcess/API/gtk/webkit2.h:
• WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

12:21 AM Changeset in webkit [164974] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164939 - [GTK] Remove the include dir of the C API from the WebKit2 pkg-config file
​https://bugs.webkit.org/show_bug.cgi?id=129543

Reviewed by Martin Robinson.

We are not installing the C API headers anymore.

• webkit2gtk.pc.in:

12:07 AM Changeset in webkit [164973] by Carlos Garcia Campos

• 6 edits
  1 add in trunk

[GTK] WebKit2WebExtension GIR can't be used in vala
​https://bugs.webkit.org/show_bug.cgi?id=127179

Reviewed by Martin Robinson.

Add a different pkg-config file for the web extensions API.

.:

• Source/cmake/OptionsGTK.cmake:
• configure.ac:

Source/WebKit2:

• GNUmakefile.am:
• PlatformGTK.cmake:
• webkit2gtk-web-extension.pc.in: Added.

Mar 2, 2014:

11:10 PM Changeset in webkit [164972] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Add a fallback path for compiling the remaining attribute checkers
​https://bugs.webkit.org/show_bug.cgi?id=129580

Reviewed by Darin Adler.

The remaining attribute checkers appear to be less common than the simple value match.
This patch adds them to SelectorCompiler for completeness but no attempt is made at optimizing them,
they all default to function calls.

If the assumption that those selectors are not common turn out to be incorrect, we should see
the function calls in profiles and optimize them as needed.

• css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
If we get anything but attribute match here, something has gone horribly wrong. Update the code
to fail if that were to happen.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Add the missing match type to the selector fragment.

Begin, End, Contain cannot match an empty value per specification. We can test that at compile time
and fail immediately. See ​http://www.w3.org/TR/css3-selectors/#attribute-substrings

List has the extra requirement that a value containing a space does not match anything. It also cannot
match with an empty string. See ​http://www.w3.org/TR/css3-selectors/#attribute-representation

(WebCore::SelectorCompiler::attributeValueBeginsWith):
(WebCore::SelectorCompiler::attributeValueContains):
(WebCore::SelectorCompiler::attributeValueEndsWith):
(WebCore::SelectorCompiler::attributeValueMatchHyphenRule):
(WebCore::SelectorCompiler::attributeValueSpaceSeparetedListContains):
The slow fallbacks.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
A generic code generator making function call to match an attribute value.

10:01 PM Changeset in webkit [164971] by fpizlo@apple.com

• 4 edits in trunk/Source/JavaScriptCore

PolymorphicPutByIdList should have a simpler construction API with basically a single entrypoint
​https://bugs.webkit.org/show_bug.cgi?id=129591

Reviewed by Michael Saboff.

• bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo): This function can figure out the slow path target for itself.
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList): This constuctor should be private, only from() should call it.
(JSC::PolymorphicPutByIdList::from):

• bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::stubRoutine):

• jit/Repatch.cpp:

(JSC::tryBuildPutByIdList): Don't pass the slow path target since it can be derived from the stubInfo.

9:42 PM Changeset in webkit [164970] by fpizlo@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Debugging improvements from my gbemu investigation session
​https://bugs.webkit.org/show_bug.cgi?id=129599

Reviewed by Mark Lam.

Various improvements from when I was investigating bug 129411.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor): Make the dataLog() statement print the actual multiplier.

• jsc.cpp:

(GlobalObject::finishCreation):
(functionDescribe): Make describe() return a string rather than printing the string.
(functionDescribeArray): Like describe(), but prints details about arrays.

9:33 PM Changeset in webkit [164969] by akling@apple.com

• 2 edits in trunk/Source/WebKit

Blind Windows build fix.

• WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Tweak JSDOMWindowBase::commonVM() return type to be a reference.

9:10 PM Changeset in webkit [164968] by akling@apple.com

• 45 edits in trunk/Source

JSDOMWindow::commonVM() should return a reference.
<​https://webkit.org/b/129293>

Source/JavaScriptCore:

Added a DropAllLocks constructor that takes VM& without null checks.

Reviewed by Geoff Garen.

Source/WebCore:

Since this function always returns a VM and never null, make it
return a reference instead. There are more VM getters that never
return null, but I tried to keep the patch from snowballing.

Reviewed by Geoff Garen.

8:49 PM Changeset in webkit [164967] by timothy@apple.com

• 5 edits in trunk

Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.

Adding the ASSERT back is tracked by ​https://webkit.org/b/129593.

​https://bugs.webkit.org/show_bug.cgi?id=129328

Reviewed by Sam Weinig.

Source/WebCore:

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):

LayoutTests:

• TestExpectations: Remove skipped tests.
• inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.

7:42 PM Changeset in webkit [164966] by BJ Burg

• 4 edits in trunk

Web Inspector model tests load wrong inspector page under WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=129460

Reviewed by Dan Bernstein.

Tools:

Don't unconditionally open the inspector before running an inspector test.
Instead, the test should request that the inspector open when it's ready.

This change was lost during a rebase, but is the same change made to
DumpRenderTree.

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests:

Stop skipping inspector/test-harness-trivially-works.html.

• platform/wk2/TestExpectations:

7:24 PM Changeset in webkit [164965] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r164961.
​http://trac.webkit.org/changeset/164961
​https://bugs.webkit.org/show_bug.cgi?id=129596

Caused many assertion failures (Requested by ap on #webkit).

• css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):

6:30 PM Changeset in webkit [164964] by Darin Adler

• 33 edits in trunk/Source

Streamline use of TextIterator, cutting down includes and use of soon-to-be-deleted functions
​https://bugs.webkit.org/show_bug.cgi?id=129592

Reviewed by Sam Weinig.

Source/WebCore:

• WebCore.exp.in: Re-sorted this file. Not sure how it got unsorted.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::stringForVisiblePositionRange): Call TextIterator::text
instead of TextIterator::length. Also removed unneeded special case for empty string
and exception code.
(WebCore::AccessibilityObject::lengthForVisiblePositionRange): Ditto.

• accessibility/AccessibilityObject.h: Include TextIteratorBehavior.h instead of

TextIterator.h.

• accessibility/AccessibilityRenderObject.cpp: Include TextIterator.h.

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Removed unneeded

TextIterator.h include.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Call
TextIterator::text instead of TextIterator::length.

• dom/Element.cpp: Include TextIterator.h.

• dom/Node.cpp: Include Range.h.

• dom/Position.cpp:

(WebCore::Position::isCandidate): Cast to RenderBlockFlow since that's what the
type check above does. Use a return statement instead of an else for better flow.
(WebCore::Position::leadingWhitespacePosition): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).
(WebCore::Position::trailingWhitespacePosition): Ditto.

• dom/Range.cpp:

(WebCore::Range::firstNode): Added a FIXME about code that clearly does not
belong. This is something we really need to fix.

• editing/AlternativeTextController.cpp: Include TextIterator.h.
• editing/ApplyStyleCommand.cpp: Ditto.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

• editing/Editor.h: Include TextIteratorBehavior.h instead of TextIterator.h.

• editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

• editing/SpellingCorrectionCommand.cpp: Include TextIterator.h.

• editing/TextIterator.h: Moved isCollapsibleWhitespace from here into

htmlediting.h and renamed it deprecatedIsCollapsibleWhitespace.

• editing/TextIterator.cpp: Call

deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

• editing/TypingCommand.cpp: Include TextIterator.h.

• editing/VisibleUnits.cpp:

(WebCore::previousBoundary): Call TextIterator::text instead of
TextIterator::length.
(WebCore::nextBoundary): Ditto.

• editing/htmlediting.cpp: Include TextIterator.h.

• editing/htmlediting.h: Removed non-helpful section comments.

Added FIXME about isWhitespace. Added deprecatedIsCollapsibleWhitespace,
formerly not deprecated and in TextIterator.h.

• editing/markup.cpp: Include TextIterator.h.

• html/HTMLTextAreaElement.cpp: Include TextIterator.h.

• page/ContextMenuController.cpp:

(WebCore::selectionContainsPossibleWord): Call TextIterator::text
instead of TextIterator::length and TextIterator::characterAt.

• page/EventHandler.cpp: Sorted conditional includes alphabetically by condition.

• platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]): Call TextIterator::text
instead of TextIterator::length.

Source/WebKit/win:

• WebCoreSupport/WebEditorClient.cpp: Added now-needed include.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp: Added now-needed include.
• WebProcess/WebPage/WebPage.cpp: Ditto.

6:27 PM Debugging With Xcode edited by BJ Burg

WKTR debugging tips (diff)

6:22 PM Debugging With Xcode edited by BJ Burg

(diff)

6:20 PM Debugging With LLDB or GDB edited by BJ Burg

(diff)

6:15 PM Debugging With Xcode created by BJ Burg

6:11 PM Debugging With LLDB or GDB created by BJ Burg

6:07 PM Changeset in webkit [164963] by enrica@apple.com

• 7 edits in trunk/Source/WebKit2

[iOS WebKit2] Keyboard deadlock when accepting/dismissing autocorrection.
​https://bugs.webkit.org/show_bug.cgi?id=129594
<rdar://problem/16168978>

Reviewed by Sam Weinig.

As a temporary fix, we are using a synchronous
message to accept autocorrection until we implement
a solution that processes these requests on a thread that
is not the main thread.

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applyAutocorrection):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applyAutocorrection):
(WebKit::WebPage::syncApplyAutocorrection):

6:05 PM WikiStart edited by BJ Burg

(diff)

6:03 PM WikiStart edited by BJ Burg

Simplify the different platform debugging page links (diff)

6:00 PM Changeset in webkit [164962] by ljaehun.lim@samsung.com

• 3 edits in trunk/Source/WTF

[EFL] Remove m_initEfl from RunLoop.
​https://bugs.webkit.org/show_bug.cgi?id=129568

Reviewed by Gyuyoung Kim.

We don't use m_initEfl except RunLoop constructor.

• wtf/RunLoop.h:
• wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::RunLoop):

5:56 PM Debugging With Visual Studio edited by BJ Burg

merge WK2 instructions (diff)

5:52 PM WikiStart edited by BJ Burg

(diff)

5:52 PM Debugging With Visual Studio edited by BJ Burg

Fold in details from separate page about DumpRenderTree + VS (diff)

5:48 PM Changeset in webkit [164961] by benjamin@webkit.org

• 3 edits in trunk/Source/WebCore

Add a fallback path for compiling the remaining attribute checkers
​https://bugs.webkit.org/show_bug.cgi?id=129580

Reviewed by Darin Adler.

The remaining attribute checkers appear to be less common than the simple value match.
This patch adds them to SelectorCompiler for completeness but no attempt is made at optimizing them,
they all default to function calls.

If the assumption that those selectors are not common turn out to be incorrect, we should see
the function calls in profiles and optimize them as needed.

• css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
If we get anything but attribute match here, something has gone horribly wrong. Update the code
to fail if that were to happen.

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Add the missing match type to the selector fragment.

Begin, End, Contain cannot match an empty value per specification. We can test that at compile time
and fail immediately. See ​http://www.w3.org/TR/css3-selectors/#attribute-substrings

List has the extra requirement that a value containing a space does not match anything. It also cannot
match with an empty string. See ​http://www.w3.org/TR/css3-selectors/#attribute-representation

(WebCore::SelectorCompiler::attributeValueBeginsWith):
(WebCore::SelectorCompiler::attributeValueContains):
(WebCore::SelectorCompiler::attributeValueEndsWith):
(WebCore::SelectorCompiler::attributeValueMatchHyphenRule):
(WebCore::SelectorCompiler::attributeValueSpaceSeparetedListContains):
The slow fallbacks.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
A generic code generator making function call to match an attribute value.

5:44 PM Debugging With Visual Studio edited by BJ Burg

restructure sections into wk1/wk2/test runners/misc. (diff)

5:37 PM Changeset in webkit [164960] by Darin Adler

• 2 edits in trunk/Source/WebCore

Fix build for case-sensitive file systems.

• platform/UserActivity.h: Runloop -> RunLoop.

5:24 PM Changeset in webkit [164959] by barraclough@apple.com

• 3 edits in trunk/Source/WebCore

HysteresisTimer should use WebCore::Timer
​https://bugs.webkit.org/show_bug.cgi?id=129587

Reviewed by Sam Weinig.

• platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::HysteresisActivity):
(WebCore::HysteresisActivity::hysteresisTimerFired):

• RunLoop::Timer -> WebCore::Timer.

• platform/UserActivity.h:

5:16 PM Changeset in webkit [164958] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

• UIProcess/ios/forms/WKFormSelectPopover.mm:

(adjustedFontSize):

5:02 PM Changeset in webkit [164957] by Darin Adler

• 10 edits
  1 add in trunk

Split TextIteratorBehavior into a separate header
​https://bugs.webkit.org/show_bug.cgi?id=129578

Reviewed by Sam Weinig.

Source/WebCore:

This is in preparation to greatly cut down on includes of TextIterator.h.

• GNUmakefile.list.am: Added new header.
• WebCore.vcxproj/WebCore.vcxproj: Ditto.
• WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
• WebCore.xcodeproj/project.pbxproj: Ditto.

• editing/FindOptions.h: Changed typedef to unsigned char;

there is no reason to store these in a 32-bit integer.

• editing/TextIterator.h: Added include of TextIteratorBehavior.h

and moved comments about the meanings of flag bits to their definition.

• editing/TextIteratorBehavior.h: Added.

• WebCore.exp.in: Updated for type changes.

Tools:

• Scripts/sort-export-file: Added special cases to the script so you can just paste link errors

from WebKit in and the script will add them in as unconditional exports. This makes the "add"
task easy, but the remove is still a bit of a pain.

4:30 PM Changeset in webkit [164956] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Page Cache is not enabled when using the modern WebKit2 API
​https://bugs.webkit.org/show_bug.cgi?id=129585

Reviewed by Dan Bernstein.

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool initWithConfiguration:]):
Default to CacheModelPrimaryWebBrowser until there is a way to configure it.

4:19 PM Changeset in webkit [164955] by enrica@apple.com

• 17 edits
  3 adds in trunk/Source

[iOS WebKit2] Form controls handling
​https://bugs.webkit.org/show_bug.cgi?id=129344
<rdar://problem/16053643>

Reviewed by Simon Fraser.

Source/WebCore:

Updates localizable strings and adds some exports.

• English.lproj/Localizable.strings:
• WebCore.exp.in:
• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Adding support for select elements on iOS.
There is full support on iPad, while on iPhone it is
still limited to single select with no groups.
The change also fixes the issue of the keyboard appearing
on screen for types of elements that are implemented with
a popover or a picker.

• Scripts/webkit2/messages.py:
• Shared/AssistedNodeInformation.cpp:

(WebKit::WKOptionItem::encode):
(WebKit::WKOptionItem::decode):
(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

• Shared/AssistedNodeInformation.h:

(WebKit::WKOptionItem::WKOptionItem):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputView]):
(-[WKContentView assistedNodeSelectOptions]):
(-[WKContentView _startAssistingNode:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setAssistedNodeSelectedIndex):

• UIProcess/ios/forms/WKFormSelectControl.h:
• UIProcess/ios/forms/WKFormSelectControl.mm: Added.

(-[WKFormSelectControl initWithView:]):
(+[WKFormSelectControl createPeripheralWithView:]):
(-[WKFormSelectControl assistantView]):
(-[WKFormSelectControl beginEditing]):
(-[WKFormSelectControl endEditing]):

• UIProcess/ios/forms/WKFormSelectPicker.mm: Added.

(-[WKSelectSinglePicker initWithView:]):
(-[WKSelectSinglePicker dealloc]):
(-[WKSelectSinglePicker controlView]):
(-[WKSelectSinglePicker controlBeginEditing]):
(-[WKSelectSinglePicker controlEndEditing]):
(-[WKSelectSinglePicker numberOfComponentsInPickerView:]):
(stringByTrimmingWhitespaceAndNewlines):
(-[WKSelectSinglePicker pickerView:numberOfRowsInComponent:]):
(-[WKSelectSinglePicker pickerView:attributedTitleForRow:forComponent:]):
(-[WKSelectSinglePicker pickerView:didSelectRow:inComponent:]):

• UIProcess/ios/forms/WKFormSelectPopover.mm: Added.

(stringWithWritingDirection):
(adjustedFontSize):
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController viewWillAppear:]):
(-[WKSelectTableViewController numberOfSectionsInTableView:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController populateCell:withItem:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectTableViewController hasText]):
(-[WKSelectTableViewController insertText:]):
(-[WKSelectTableViewController deleteBackward]):
(-[WKSelectPopover initWithView:hasGroups:]):
(-[WKSelectPopover dealloc]):
(-[WKSelectPopover controlView]):
(-[WKSelectPopover controlBeginEditing]):
(-[WKSelectPopover controlEndEditing]):
(-[WKSelectPopover _userActionDismissedPopover:]):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::innerFrameQuad):
(WebKit::WebPage::getPositionInformation):
(WebKit::hasFocusableNode):
(WebKit::WebPage::getAssistedNodeInformation):
(WebKit::WebPage::elementDidFocus):

4:03 PM Changeset in webkit [164954] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

CodeBlock::hasDebuggerRequests() should returning a bool instead of an int.
<​https://webkit.org/b/129584>

Reviewed by Darin Adler.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::hasDebuggerRequests):

3:14 PM Changeset in webkit [164953] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Clean up use of Options::enableConcurrentJIT().
<​https://webkit.org/b/129582>

Reviewed by Filip Pizlo.

DFG Driver was conditionally checking Options::enableConcurrentJIT()
only if ENABLE(CONCURRENT_JIT). Otherwise, it bypasses it with a local
enableConcurrentJIT set to false.

Instead we should configure Options::enableConcurrentJIT() to be false
in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always
check Options::enableConcurrentJIT(). This makes the code read a little
cleaner.

• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

3:13 PM Changeset in webkit [164952] by benjamin@webkit.org

• 10 edits in trunk/Source

[iOS][WK2] Pages using tiled compositing layers allocate too many tiles on zoom
​https://bugs.webkit.org/show_bug.cgi?id=129471

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-03-02
Reviewed by Simon Fraser.

Source/WebCore:

A few issues with TileController were causing sublayers of the root layers
to tile incorrect surfaces on zoom.

First, the exposedRect API was not updating the sublayers. The layers go correctly
into tiling mode, but the tiles cover the full document instead of the visible area.

The other major issue was the margins being applied to the coverage size in document
coordinates. Since each margin is 512px, the total coverage size after zoom was
gigantic.

To solve this, this patch switch from the exposedRect API to the generic concept
of VisibleExtentContentRect introduced for iOS WebKit1.

• WebCore.exp.in:
• platform/ScrollView.h:

Define a VisibleExtentContentRect on the scrollview itself when there is no
platformWidget().
The case with inside frame is untested due to stability issues :(.
(see <rdar://problem/16199219>)

• platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::computeTileCoverageRect):
Remove the margin from the tile coverage.

On iOS, m_tileCoverage is always zero at the moment. Previously, the tile coverage
was artificially extended by the margins. With the margins removed, I temporarily added
a factor of 1.5.
ViewUpdateDispatcher has all the information to compute a great tile coverage, I will need
a follow up patch to fix that.

• platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::visibleExtentContentRect):
(WebCore::ScrollView::setVisibleExtentContentRect):

Source/WebKit2:

• WebProcess/WebPage/DrawingArea.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):
A few interesting changes here:
-Now that we do not use setExposedRect, we can pass the exposed area directly

to the drawing area since everything is now in content coordinates :)

-The scale is now converted to float before being compared to the Page's scaleFactor.

The page's scalefactor being a float, the comparison was failing most of the time.

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setVisibleExtentContentRect):

2:35 PM Changeset in webkit [164951] by Darin Adler

• 5 edits
  1 add in trunk

Sort Mac platform export files so they merge better
​https://bugs.webkit.org/show_bug.cgi?id=129581

Reviewed by Sam Weinig.

Source/WebCore:

• WebCore.exp.in: Ran the new sort-export-file on this.

Source/WebKit/mac:

• WebKit.exp: Ran the new sort-export-file on this.

Tools:

• Scripts/sort-export-file: Added. Quickly whipped together script that sorts

Mac export files in a "canonical" order for this project.

2:26 PM Changeset in webkit [164950] by dino@apple.com

• 5 edits
  2 adds in trunk

Add protected casting to FilterOperation classes.
​https://bugs.webkit.org/show_bug.cgi?id=124062

Reviewed by Sam Weinig.

Source/WebCore:

Use the type cast macro generators to produce some toFilterOperation-style
functions, and then use them in our PlatformCA filter code.

Test: css3/filters/animation-from-initial-values-with-color-matrix.html

• platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Use the toFilterOperation methods, in

some cases removing the unnecessary double cast.
(PlatformCAFilters::filterValueForOperation):
(PlatformCAFilters::colorMatrixValueForFilter):

• platform/graphics/filters/FilterOperation.cpp:

(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicColorMatrixFilterOperation::operator==): Move this to the .cpp file so it can use the casting methods.
(WebCore::BasicComponentTransferFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::operator==): Ditto.

• platform/graphics/filters/FilterOperation.h: Add the casting macros.

LayoutTests:

• css3/filters/animation-from-initial-values-with-color-matrix-expected.html: Added.
• css3/filters/animation-from-initial-values-with-color-matrix.html: Added.

2:22 PM Changeset in webkit [164949] by commit-queue@webkit.org

• 5 edits
  4 adds in trunk

Fix srcset related bugs
​https://bugs.webkit.org/show_bug.cgi?id=129539

Source/WebCore:

Fixed a bug reported against Blink's srcset implementation at ​https://code.google.com/p/chromium/issues/detail?id=347998
When both src and srcset had only 1x descriptors and the DPR was higher than 1, the src's resource was picked.

Also fixed the invalid descriptor handling, which wasn't aligned with the spec, and therefore was not as forward compatible as it should be.
Invalid descriptors caused the entire resource to be ignored, rather than just the descriptors themselves.

Patch by Yoav Weiss <​yoav@yoav.ws> on 2014-03-02
Reviewed by Andreas Kling.

Tests: fast/hidpi/image-srcset-invalid-descriptor.html

fast/hidpi/image-srcset-src-selection-1x-both.html

• html/parser/HTMLParserIdioms.cpp:

(WebCore::parseDescriptors):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that:

1. Invalid srcset descriptors are handled according to the spec. The invalid descriptors are ignored, but the resource is not.
2. When both src and srcset have only 1x descriptors and the DPR is higher than 1, the srcset's resource is picked.

I've also fixed the invalid inputs test, which was faulty.

Patch by Yoav Weiss <​yoav@yoav.ws> on 2014-03-02
Reviewed by Andreas Kling.

• fast/hidpi/image-srcset-invalid-descriptor-expected.txt: Added.
• fast/hidpi/image-srcset-invalid-descriptor.html: Added.
• fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
• fast/hidpi/image-srcset-src-selection-1x-both-expected.txt: Added.
• fast/hidpi/image-srcset-src-selection-1x-both.html: Added.
• fast/hidpi/resources/srcset-helper.js:

(runTest):

12:44 PM Changeset in webkit [164948] by barraclough@apple.com

• 11 edits
  1 copy in trunk/Source/WebCore

Split UserActivity, simplify PageThrottler
​https://bugs.webkit.org/show_bug.cgi?id=129551

Reviewed by Darin Adler.

The class UserActivity currently implements two things – a hysteresis mechanism, and
an abstraction of NSActivity controlled by that mechanism. PageThrottler implements
its own hysteresis mechanism, which directly controls DOM timer throttling and also
controls a couple of UserActivities, giving a total of 3 separate hysteresis mechanisms,
layered two deep.

Split UserActivity into three, with HysteresisActivity implementing an abstract hysteresis
mechanism, UserActivity::Impl controlling the NSActivity, and then UserActivity combining
these two back together. The interface to UserActivity is unchanged.

Remove PageThrottler's bespoke hysteresis, replacing it with a use of HysteresisActivity.
Replace the two UserActivities with a single UserActivity::Impl, so there are no longer
layered hysteresis mechanisms.

• WebCore.exp.in:
  • exports changed.
• WebCore.xcodeproj/project.pbxproj:
  • added HysteresisActivity.h.
• page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

• if the page starts visible, begin activity. If it starts hidden throttle DOM timers.

(WebCore::PageThrottler::hiddenPageDOMTimerThrottlingStateChanged):

• when the DOM timer throttling setting changes, make sure we update.

(WebCore::PageThrottler::incrementActivityCount):
(WebCore::PageThrottler::decrementActivityCount):

• when m_activityCount changes update the hysteresis state.

(WebCore::PageThrottler::updateHysteresis):
(WebCore::PageThrottler::setViewState):

• when IsVisuallyIdle changes update the hysteresis state.

(WebCore::PageThrottler::started):
(WebCore::PageThrottler::stopped):

• callbacks from HysteresisActivity, these control m_activity and DOM timer throttling.

• page/PageThrottler.h:

(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):

• call impulse to temporarily enable the activity.

• platform/HysteresisActivity.h: Copied from Source/WebCore/platform/UserActivity.h.

(WebCore::HysteresisActivity::HysteresisActivity):

• constructor takes a delegate optionally a timeout.

(WebCore::HysteresisActivity::start):

• start activity immediately. If stopped, call started method on delegate. If in timeout period, cancel the timer.

(WebCore::HysteresisActivity::stop):

• stop activity after hysteresis. If started, initiate timeout period.

(WebCore::HysteresisActivity::impulse):

• ensure activity for at least the timeout period.

(WebCore::HysteresisActivity::hysteresisTimerFired):

• delayed stop - when the timer fires call stopped on the delegate.

• platform/UserActivity.cpp:

(WebCore::UserActivity::Impl::Impl):
(WebCore::UserActivity::Impl::beginActivity):
(WebCore::UserActivity::Impl::endActivity):

• nop implementation.

(WebCore::UserActivity::UserActivity):

• UserActivity maintains existing interface with hysteresis.

(WebCore::UserActivity::started):
(WebCore::UserActivity::stopped):

• callbacks from HysteresisTimer; forward to Impl.

• platform/UserActivity.h:
• platform/mac/UserActivityMac.mm:

(WebCore::UserActivity::Impl::Impl):

• UserActivity::Impl, abstraction for NSActivity without added hysteresis.

(WebCore::UserActivity::Impl::beginActivity):

• allocate NSActivity.

(WebCore::UserActivity::Impl::endActivity):

• release NSActivity.

12:34 PM Changeset in webkit [164947] by BJ Burg

• 5 edits in trunk/Source/WebCore

DocumentLoader should keep maps of ResourceLoaders instead of sets
​https://bugs.webkit.org/show_bug.cgi?id=129388

Reviewed by Darin Adler.

For web replay, we need to be able to pull a ResourceLoader instance by
identifier from the DocumentLoader. This is easy to do if we convert
ResourceLoaderSet to ResourceLoaderMap, keyed by the loader's identifier.

Added assertions whenever adding or removing from the map to ensure
that we don't try to add duplicates or resources with zero identifiers.

No new tests required. No functionality was added.

• loader/DocumentLoader.cpp:

(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::areAllLoadersPageCacheAcceptable):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::removeSubresourceLoader):
(WebCore::DocumentLoader::addPlugInStreamLoader):
(WebCore::DocumentLoader::removePlugInStreamLoader):
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):

• loader/DocumentLoader.h:
• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::create): Only add the loader
to the document loader's map if it initialized successfully.
The old code was probably leaking resource loaders that failed to
initialize.

• loader/mac/DocumentLoaderMac.cpp:

(WebCore::scheduleAll):
(WebCore::unscheduleAll):

11:52 AM Changeset in webkit [164946] by krit@webkit.org

• 9 edits in trunk/LayoutTests

Reactivate SVG mask-type tests for Mac
​https://bugs.webkit.org/show_bug.cgi?id=129577

Reviewed by Darin Adler.

Reduce mask-type tests to the minimum to test the feature.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• svg/masking/mask-type-alpha-expected.svg:
• svg/masking/mask-type-alpha.svg:
• svg/masking/mask-type-luminance-expected.svg:
• svg/masking/mask-type-luminance.svg:
• svg/masking/mask-type-not-set-expected.svg:
• svg/masking/mask-type-not-set.svg:

11:36 AM Changeset in webkit [164945] by Darin Adler

• 6 edits in trunk/Source

Change public text iterator API implementations to not depend on 16-bit character pointers
​https://bugs.webkit.org/show_bug.cgi?id=129566

Reviewed by Anders Carlsson.

Source/WebKit/mac:

• WebView/WebTextIterator.mm:

(-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
(-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
next text.
(-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
(-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
probably be removing TextIterator::length eventually.

Source/WebKit2:

• WebView/WebTextIterator.mm:

(-[WKDOMTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
(-[WKDOMTextIterator advance]): Clear out the upconverted text since we are moving on to the
next text.
(-[WKDOMTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
(-[WKDOMTextIterator currentTextLength]): Call TextIterator::text().length() since we will
probably be removing TextIterator::length eventually.

• WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed unneded include of TextIterator.h.
• WebProcess/WebPage/WebPage.cpp: Ditto.

10:25 AM Changeset in webkit [164944] by krit@webkit.org

• 5 edits in trunk/LayoutTests

Remove path to non-existent SVG clip-path test from TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=129574

Reviewed by Simon Fraser.

The test was transformed to a ref test and moved to a different location.
It passes on all platforms now.

• platform/gtk/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wk2/TestExpectations:

9:55 AM Changeset in webkit [164943] by commit-queue@webkit.org

• 8 edits in trunk

Support ENABLE_ENCRYPTED_MEDIA in cmake builds
​https://bugs.webkit.org/show_bug.cgi?id=129575

Patch by Dirkjan Ochtman <​d.ochtman@activevideo.com> on 2014-03-02
Reviewed by Philippe Normand.

.:

• Source/cmake/OptionsEfl.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

• Source/cmake/OptionsGTK.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

• Source/cmake/WebKitFeatures.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

• Source/cmakeconfig.h.cmake:

Added ENABLE_ENCRYPTED_MEDIA{,_V2} flags.

Source/WebCore:

No new tests, only fixes the build.

• CMakeLists.txt:

Add support for ENABLE_ENCRYPTED_MEDIA.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::close):
Assign nullptr instead of 0 to OwnPtr to appease gcc-4.7.

9:19 AM Changeset in webkit [164942] by Darin Adler

• 6 edits in trunk/Source/WTF

Cut down use of OwnPtr within WTF itself
​https://bugs.webkit.org/show_bug.cgi?id=129567

Reviewed by Sam Weinig.

• wtf/RefCounted.h: Removed OwnPtr includes.

• wtf/StreamBuffer.h: Removed OwnPtr includes and switched to use

std::make_unique and std::unique_ptr instead.

• wtf/Threading.cpp: Removed OwnPtr includes.
• wtf/ThreadingPthreads.cpp: Ditto.
• wtf/Vector.h: Ditto.

7:36 AM Changeset in webkit [164941] by thiago.lacerda@openbossa.org

• 7 edits
  1 delete in trunk/LayoutTests

Updating some WebRTC and MediaStream LayoutTests
​https://bugs.webkit.org/show_bug.cgi?id=129442

Reviewed by Eric Carlson.

Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated:

• MediaStreamTrack.html: checking hasOwnProperty in proto as well, until CustomGetter properties are moved to the prototype chain.
• RTCIceCandidate.html and RTCSessionDescription.html: JSON.stringify are not considering properties in proto, so remove this for now.

• fast/mediastream/MediaStreamTrack-expected.txt:
• fast/mediastream/MediaStreamTrack.html:
• fast/mediastream/RTCIceCandidate-expected.txt:
• fast/mediastream/RTCIceCandidate.html:
• fast/mediastream/RTCPeerConnection-have-local-answer.html: Removed. Other tests already test what this one was

testing

• fast/mediastream/RTCSessionDescription-expected.txt:
• fast/mediastream/RTCSessionDescription.html:

6:59 AM Changeset in webkit [164940] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit2

[GTK] Make impossible to build with <webkit2/webkit2.h> and <webkit2/webkit-web-extension.h> included together
​https://bugs.webkit.org/show_bug.cgi?id=129549

Reviewed by Martin Robinson.

Add a compile error to prevent mixing the UI and web process APIs.

• UIProcess/API/gtk/webkit2.h:
• WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

6:56 AM Changeset in webkit [164939] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] Remove the include dir of the C API from the WebKit2 pkg-config file
​https://bugs.webkit.org/show_bug.cgi?id=129543

Reviewed by Martin Robinson.

We are not installing the C API headers anymore.

• webkit2gtk.pc.in: