Timeline



Apr 9, 2014:

11:40 PM Changeset in webkit [167070] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r166860): ASSERTION FAILED: !isCalculated() on fast/css/image-set-value-not-removed-crash.html
​https://bugs.webkit.org/show_bug.cgi?id=131480

  • platform/mac/TestExpectations: Skipped the test in debug builds.
11:33 PM Changeset in webkit [167069] by commit-queue@webkit.org
  • 4 edits in trunk

Unreviewed, rolling out r167046.
​https://bugs.webkit.org/show_bug.cgi?id=131479

Caused 300+ failures on Mavericks WK1 tester (Requested by ap
on #webkit).

Reverted changeset:

Source/WebCore:

"Remove "System Font" from whitelisted DRT fonts and char
width calculations"
​https://bugs.webkit.org/show_bug.cgi?id=131411
​http://trac.webkit.org/changeset/167046

Tools:

"Remove "System Font" from whitelisted DRT fonts and char
width calculations"
​https://bugs.webkit.org/show_bug.cgi?id=131411
​http://trac.webkit.org/changeset/167046

11:25 PM Changeset in webkit [167068] by ap@apple.com
  • 2 edits in trunk/LayoutTests

[WK2] fast/repaint/obscured-background-no-repaint.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=131477

  • platform/mac-wk2/TestExpectations: Marked it as such.
11:25 PM Changeset in webkit [167067] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

11:22 PM Changeset in webkit [167066] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.28

New tag.

11:17 PM Changeset in webkit [167065] by ap@apple.com
  • 2 edits in trunk/LayoutTests

WebVTT tests don't work because of a 800x600 snapshot (but are very flaky anyway)
​https://bugs.webkit.org/show_bug.cgi?id=131476

  • platform/mac/TestExpectations: Skip them.
9:50 PM Changeset in webkit [167064] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build failure when #if USE(XPC_SERVICES) is false.
​https://bugs.webkit.org/show_bug.cgi?id=131474

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-04-09
Reviewed by Dan Bernstein.

Fix build.

  • UIProcess/ios/WebProcessProxyIOS.mm:

Add #if around BackgroundTabFlags ForegroundTabFlags to prevent unused variable error.

9:42 PM Changeset in webkit [167063] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build failure.
​https://bugs.webkit.org/show_bug.cgi?id=131473

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-04-09
Reviewed by Dan Bernstein.

Fix build failure.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(mediaSelectionOptions):

9:04 PM Changeset in webkit [167062] by ryuan.choi@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add API to set preferred languages
​https://bugs.webkit.org/show_bug.cgi?id=131435

Reviewed by Gyuyoung Kim.

Add ewk_context_preferred_languages_set to change the list of "Accept-Language".
This list is used to receive alternative version of contents, which is related
to specified languages from the contents provider.

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_preferred_languages_set):

  • UIProcess/API/efl/ewk_context.h:
  • UIProcess/API/efl/tests/test_ewk2_context.cpp:

(serverCallback):
(TEST_F): Added test case for ewk_context_preferred_languages_set

8:55 PM Changeset in webkit [167061] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Temporarily disable the JIT for the Windows port.
<​https://webkit.org/b/131470>

Reviewed by Brent Fulgham.

This is a temporary stop gap measure to green the Windows bots until
we have a fix for ​https://webkit.org/b/131182.

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

8:39 PM Changeset in webkit [167060] by benjamin@webkit.org
  • 15 edits in trunk/Source/WebKit2

[iOS][WK2] Add the initial WebProcess handling of animated resize for rotation
​https://bugs.webkit.org/show_bug.cgi?id=131469

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-04-09
Reviewed by Tim Horton.

Add the basic handling of dynamic resize from the WebProcess.

On animated resize, the UIProcess decides new target rects and scale. The information
is then passed to the WebProcess to update the content.

For various reason, the target rects and scale computed by the UIProcess can be incorrect
(for example, if viewport constraints limit the scale).

In those cases, the WebProcess has all the information to compute a better target. This patch
adds such a basic update mechanism.

Once the new values are computed, they are sent back to the UIProcess. If the rotation animation
is still ongoing, we do not want mess with it. What we do is set a temporary transform on the subviews
and restore the real value after the animation. The key is to have the two matrix multiplying to the end
value so that there is no visual difference.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _dynamicViewportUpdateChangedTargetToScale:position:]):
(setViewportConfigurationMinimumLayoutSize):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _setMinimumLayoutSizeOverride:]):
(-[WKWebView _beginAnimatedResizeToSize:obscuredInsets:minimumLayoutSizeOverride:]):
(-[WKWebView _endAnimatedResize]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):
(-[WKView setMinimumLayoutSizeOverride:]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::dynamicViewportUpdateChangedTarget):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView setMinimumLayoutSize:]): Deleted.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::dynamicViewportUpdateChangedTarget):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::dynamicViewportSizeUpdate):

7:38 PM Changeset in webkit [167059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[FTL] Emit multibyte NOPs on X86-64
​https://bugs.webkit.org/show_bug.cgi?id=131394

Patch by Juergen Ributzka <​juergen@apple.com> on 2014-04-09
Reviewed by Michael Saboff.

  • assembler/X86Assembler.h:

(JSC::X86Assembler::fillNops):

6:47 PM Changeset in webkit [167058] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after ​http://trac.webkit.org/changeset/167045

The file contained an invalid character.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::enterFullscreen):

6:11 PM April 2014 Meeting edited by Simon Fraser
(diff)
6:06 PM Changeset in webkit [167057] by dino@apple.com
  • 7 edits in trunk/Source/WebCore

[iOS] Media controls should resize as the user zooms
​https://bugs.webkit.org/show_bug.cgi?id=131322

Reviewed by Eric Carlson.

On iOS the media controls should remain the same size
independent of user zoom. Have the HTMLMediaElement optionally
register for updates in the page scale to apply an inverse
scale.

  • Modules/mediacontrols/MediaControlsHost.cpp: New exposed property that calls

back into HTMLMediaElement::mediaControlsDependOnPageScaleFactor.
(WebCore::MediaControlsHost::controlsDependOnPageScaleFactor):
(WebCore::MediaControlsHost::setControlsDependOnPageScaleFactor):

  • Modules/mediacontrols/MediaControlsHost.h: Keep a reference to the actual

controls from the JavaScript side so we can talk to it later.
(WebCore::MediaControlsHost::controllerJSValue):
(WebCore::MediaControlsHost::setControllerJSValue):

  • Modules/mediacontrols/MediaControlsHost.idl: Expose controlsDependOnPageScaleFactor.
  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-panel): Specify the transform origin so that
scaling will keep the controls pinned to the bottom left corner.
(audio::-webkit-media-controls-start-playback-button): Update to the correct size
and provide new artwork.
(audio::-webkit-media-controls-start-playback-button.failed): New artwork.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Tell the host that these controls care about the page scale.
(ControllerIOS.prototype.get pageScaleFactor): New getter.
(ControllerIOS.prototype.set pageScaleFactor): When set, update the play button and the panel.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript): Small naming cleanup.
(setPageScaleFactorProperty): Static helper to set a JS property value.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Keep a reference to the controls object,
and make sure to set the page scale factor on the controls.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): Implement the callback, telling
the controls object that it needs to relayout.

5:51 PM Changeset in webkit [167056] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix iOS build.

  • platform/graphics/ca/mac/TileController.mm:
5:48 PM Changeset in webkit [167055] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r165908): ~QuickLookHandle() tries to dereference a null ResourceHandle
​https://bugs.webkit.org/show_bug.cgi?id=131467

Reviewed by Tim Horton.

QuickLookHandle stored a ResourceHandle pointer in order to later
retrive the URL of its firstRequest(), but after r165908 we no longer
always have a ResourceHandle. Since firstRequest()'s URL is the only
thing we need from ResourceHandle, store it directly rather than a
ResourceHandle pointer. In the case where we create a QuickLookHandle
from a ResourceLoader rather than a ResourceHandle, pass the loader's
originalRequest(), which represents the same request as firstRequest()
(i.e. the request after willSendRequest() but before redirects).

  • platform/network/ios/QuickLook.h:
  • platform/network/ios/QuickLook.mm:

(WebCore::QuickLookHandle::QuickLookHandle):
(WebCore::QuickLookHandle::create):
(WebCore::QuickLookHandle::didFail):
(WebCore::QuickLookHandle::~QuickLookHandle):

5:18 PM Changeset in webkit [167054] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

AX: Bug in AccessibilityNodeObject::helpText
​https://bugs.webkit.org/show_bug.cgi?id=130386

Patch by James Craig <​jcraig@apple.com> on 2014-04-09
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/help-text.html

Ancestor loop was always checking attribute of original node rather than current node.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::helpText):

LayoutTests:

Tests accessibility help text in a variety of examples.

  • accessibility/help-text-expected.txt: Added.
  • accessibility/help-text.html: Added.
5:10 PM Changeset in webkit [167053] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed bot maintenance. Re-add a number of passing
tests, and turn off a few failures.

  • platform/win/TestExpectations:
4:51 PM Changeset in webkit [167052] by Chris Fleizach
  • 5 edits in trunk

Regression: AX: list heuristics sometimes determined as presentational even when explicit roles applied
​https://bugs.webkit.org/show_bug.cgi?id=131041

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When display:table is used on a list item, it inserts RenderObjects that can be ignored as the children
of the list. This allows normal list heuristics to be applied.

  • accessibility/AccessibilityTableCell.cpp:

(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):

LayoutTests:

  • accessibility/list-detection-expected.txt:
  • accessibility/list-detection.html:
4:37 PM Changeset in webkit [167051] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

Try to fix the GTK+ build after resetDragOperation rename

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDataReceived): Rename resetDragOperation to resetDragSession.
(dragExitedCallback): Ditto.

4:34 PM Changeset in webkit [167050] by Martin Robinson
  • 4 edits
    16 adds in trunk/LayoutTests

Rebaseline some tests for GTK+

  • platform/gtk/editing/input/scroll-viewport-page-up-down-expected.txt:
  • platform/gtk/fast/text/international/cjk-segmentation-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/cache-override-expected.txt: Added.
  • platform/gtk/inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Added.
  • platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/gtk/plugins/nested-plugin-objects-expected.txt: Added.
  • platform/gtk/plugins/netscape-destroy-plugin-script-objects-expected.txt: Added.
  • platform/gtk/sputnik/Unicode/Unicode_320/S7.6_A2.2_T2-expected.txt: Added.
  • platform/gtk/sputnik/Unicode/Unicode_320/S7.6_A5.2_T8-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/gtk/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/gtk/svg/custom/object-no-size-attributes-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.
4:16 PM Changeset in webkit [167049] by ggaren@apple.com
  • 3 edits in trunk/Source/WTF

Rolled back in r166972.

This time, we conditionally exclude linking against bmalloc in Production
builds. Production builds will not be able to link against bmalloc
until the Production build system has been updated to build bmalloc.

WTF should link against bmalloc
​https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Mark Rowe.

  • Configurations/WTF.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
4:11 PM Changeset in webkit [167048] by ggaren@apple.com
  • 4 edits in trunk/Source

Put bmalloc headers in the right place
​https://bugs.webkit.org/show_bug.cgi?id=131464

Reviewed by Mark Rowe.

../bmalloc:

  • Configurations/bmalloc.xcconfig: Set PRIVATE_HEADERS_FOLDER_PATH to

specify that we don't just want to dump all of our generically-named
headers into /usr/local/include.

../WTF:

  • wtf/FastMalloc.cpp: Use "<bmalloc/...>" syntax so we can find our

headers in <header-root>/usr/local/include/bmalloc/.

4:03 PM Changeset in webkit [167047] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

TileGrid should be PlatformCALayerClient instead of TileController
​https://bugs.webkit.org/show_bug.cgi?id=131456

Switch one more place to use removeTiles.

  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::revalidateTiles):

3:57 PM April 2014 Meeting edited by jfernandez@igalia.com
(diff)
3:54 PM Changeset in webkit [167046] by mmaxfield@apple.com
  • 4 edits in trunk

Remove "System Font" from whitelisted DRT fonts and char width calculations
​https://bugs.webkit.org/show_bug.cgi?id=131411

Reviewed by Tim Horton.

Covered by existing tests.

Source/WebCore:

  • platform/graphics/Font.cpp:

(WebCore::Font::hasValidAverageCharWidth):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(allowedFontFamilySet):

3:41 PM April 2014 Meeting edited by stearns@adobe.com
(diff)
3:40 PM April 2014 Meeting edited by stearns@adobe.com
(diff)
3:35 PM Changeset in webkit [167045] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fullscreen does two view controller changes at once
​https://bugs.webkit.org/show_bug.cgi?id=131432

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-04-09
Reviewed by Eric Carlson.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
delay -presentViewController on the main run loop to allow
previous view controller change to complete.

3:33 PM Changeset in webkit [167044] by commit-queue@webkit.org
  • 15 edits in trunk/Source

Enable fullscreen captions selection
​https://bugs.webkit.org/show_bug.cgi?id=131069

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-04-09
Reviewed by Eric Carlson.

Source/WebCore:

Enable media selection options from fullscreen. i.e. captions.

  • WebCore.exp.in:

Add exports for
setAudioMediaSelectionOptions
setLegibleMediaSelectionOptions
selectAudioMediaOption
selectLegibleMediaOption

  • platform/ios/WebVideoFullscreenInterface.h:

Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

(-[WebAVPlayerController dealloc]):
(-[WebAVPlayerController hasMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasMediaSelectionOptions]):
(-[WebAVPlayerController hasAudioMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasAudioMediaSelectionOptions]):
(-[WebAVPlayerController hasLegibleMediaSelectionOptions]):
(+[WebAVPlayerController keyPathsForValuesAffectingHasLegibleMediaSelectionOptions]):
(-[WebAVPlayerController currentAudioMediaSelectionOption]):
(-[WebAVPlayerController setCurrentAudioMediaSelectionOption:]):
(-[WebAVPlayerController currentLegibleMediaSelectionOption]):
(-[WebAVPlayerController setCurrentLegibleMediaSelectionOption:]):
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions):
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions):

  • platform/ios/WebVideoFullscreenModel.h:

Add selectAudioMediaOption/selectLegibleMediaOption

  • platform/ios/WebVideoFullscreenModelMediaElement.h:

Add selectAudioMediaOption/selectLegibleMediaOption

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

Add selectAudioMediaOption/selectLegibleMediaOption

(WebVideoFullscreenModelMediaElement::setMediaElement):
Send initial media selection options.

(WebVideoFullscreenModelMediaElement::selectAudioMediaOption):
Will be implemented when audio track slection is implemented.

(WebVideoFullscreenModelMediaElement::selectLegibleMediaOption):
Select corresponding text track on HTMLMediaElement.

Source/WebKit2:

Enable media selection in fullscreen.
setLegibleMediaSelectionOptions/setAudioMediaSelectionOptions provide a list of options.
selectAudioMediaOption/selectLegibleMediaOption change the selected option.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Add selectAudioMediaOption/selectLegibleMediaOption

  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

Add selectAudioMediaOption/selectLegibleMediaOption

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::selectAudioMediaOption):
Add selectAudioMediaOption

(WebKit::WebVideoFullscreenManagerProxy::selectLegibleMediaOption):
Add selectLegibleMediaOption

  • WebProcess/ios/WebVideoFullscreenManager.h:

Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

  • WebProcess/ios/WebVideoFullscreenManager.messages.in:

Add setAudioMediaSelectionOptions/setLegibleMediaSelectionOptions

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::setAudioMediaSelectionOptions):
Add setAudioMediaSelectionOptions

(WebKit::WebVideoFullscreenManager::setLegibleMediaSelectionOptions):
Add setLegibleMediaSelectionOptions

3:33 PM Changeset in webkit [167043] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

systemHiddenFontFamilySet in DRT is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=131414

Reviewed by Tim Horton.

It doesn't seem to affect test results on my machine.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(drt_NSFontManager_availableFonts):
(systemHiddenFontFamilySet): Deleted.

3:31 PM Changeset in webkit [167042] by zoltan@webkit.org
  • 1 edit
    2 adds in trunk/PerformanceTests

[CSS Shapes] Add no shapes version of RegionsShapes performance test
​https://bugs.webkit.org/show_bug.cgi?id=131455

Reviewed by Ryosuke Niwa.

This is a no shapes version of the RegionsShapes performance test. All the content
will wrap around the floating containers. This way we can compare the runtime/memory
usage of the RegionsShapes test with/without shapes. The test is skipped by default.

  • Layout/Shapes/RegionsShapesNoShapes.html: Added.
  • Layout/Shapes/resources/RegionsShapesContentNoShapes.html: Added.
3:29 PM Changeset in webkit [167041] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

TileGrid should be PlatformCALayerClient instead of TileController
​https://bugs.webkit.org/show_bug.cgi?id=131456

Reviewed by Tim Horton.

The client interface is for the tiles in the grid.

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::setContentsScale):
(WebCore::TileController::createTileLayer):
(WebCore::TileController::platformCALayerPaintContents): Deleted.
(WebCore::TileController::platformCALayerDeviceScaleFactor): Deleted.
(WebCore::TileController::platformCALayerShowDebugBorders): Deleted.
(WebCore::TileController::platformCALayerShowRepaintCounter): Deleted.
(WebCore::TileController::platformCALayerIncrementRepaintCount): Deleted.

  • platform/graphics/ca/mac/TileGrid.h:


Move repaint counter to TileGrid too.

  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::removeTiles):
(WebCore::TileGrid::removeAllSecondaryTiles):
(WebCore::TileGrid::removeTilesInCohort):

Cleaned up tile removal.

(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):
(WebCore::TileGrid::platformCALayerPaintContents):
(WebCore::TileGrid::platformCALayerDeviceScaleFactor):
(WebCore::TileGrid::platformCALayerShowDebugBorders):
(WebCore::TileGrid::platformCALayerShowRepaintCounter):
(WebCore::TileGrid::platformCALayerContentsOpaque):
(WebCore::TileGrid::platformCALayerIncrementRepaintCount):
(WebCore::queueTileForRemoval): Deleted.

3:24 PM Changeset in webkit [167040] by ap@apple.com
  • 15 edits in trunk/Source

Rename some dragging functions
​https://bugs.webkit.org/show_bug.cgi?id=131460

Reviewed by Tim Horton.

Source/WebCore:

Renamed performDrag to performDragOperation. This function is responsible for
accepting a drop, not for the whole drag.

The new name is not perfect either, but I think that it's better, and at least
it matches AppKit, like the other dragging destination functions already do.

  • WebCore.exp.in:
  • page/DragController.cpp:

(WebCore::DragController::performDragOperation):
(WebCore::DragController::performDrag): Deleted.

  • page/DragController.h:

Source/WebKit/mac:

Renamed performDrag to performDragOperation.

  • WebView/WebView.mm: (-[WebView performDragOperation:]):

Source/WebKit/win:

Renamed performDrag to performDragOperation.

  • WebView.cpp: (WebView::Drop):

Source/WebKit2:

Renamed performDrag to performDragOperation.

Also renamed resetDragOperation to resetDragSession, because it's m_dragSession
that it resets.

  • Shared/DragControllerAction.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDragDrop):

  • UIProcess/API/mac/WKView.mm:

(-[WKView draggingEntered:]):
(-[WKView draggingExited:]):
(-[WKView performDragOperation:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::performDragOperation):
(WebKit::WebPageProxy::performDrag): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::resetDragSession):
(WebKit::WebPageProxy::resetDragOperation): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

3:13 PM Changeset in webkit [167039] by barraclough@apple.com
  • 4 edits in trunk/Source/WebKit2

Update SPI for managing tabs
​https://bugs.webkit.org/show_bug.cgi?id=131453

Reviewed by Alexey Proskuryakov.

  • Configurations/WebKit2.xcconfig:
    • added AssertionServices
  • UIProcess/WebProcessProxy.h:
    • added m_assertion, m_assertionState.
  • UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::updateProcessState):

  • create BKSProcessAssertion to take an assertion.
3:12 PM Changeset in webkit [167038] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

WK2: Dictated words disappear after being inserted.
​https://bugs.webkit.org/show_bug.cgi?id=131458
<rdar://problem/16395011>

Reviewed by Benjamin Poulain.

The dictation engine treats selected text as text to be
removed. We need to ensure that the range selected to insert the
new text isn't reflected in the UI process until we are done
inserting the text.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::replaceDictatedText):

2:52 PM Changeset in webkit [167037] by mark.lam@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Unreviewed. Updated ChangeLog comment for r167031: <​http://trac.webkit.org/r167031>.

2:41 PM Changeset in webkit [167036] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Source/JavaScriptCore

Get rid of JITOperationWrappers.h header file.
​https://bugs.webkit.org/show_bug.cgi?id=131450

Patch by Julien Brianceau <​jbriance@cisco.com> on 2014-04-09
Reviewed by Michael Saboff.

JITOperationWrappers header file contains architecture specific code that is
not needed anymore, so get rid of it.

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGOperations.cpp:
  • jit/JITOperationWrappers.h: Removed.
  • jit/JITOperations.cpp:
2:39 PM Changeset in webkit [167035] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-04-09 Geoffrey Garen <​ggaren@apple.com>

Rolled back out r166972.

The production buildbots are still broken because the build-root script
doesn't build bmalloc.

  • WTF.xcodeproj/project.pbxproj:
2:31 PM Changeset in webkit [167034] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't offer "contact" actions in telephone number menus
<rdar://problem/16556907> and ​https://bugs.webkit.org/show_bug.cgi?id=131451

Reviewed by Tim Horton.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showTelephoneNumberMenu): Skip actions that have to do with contacts,

and skip separators too!

2:13 PM Changeset in webkit [167033] by Samuel White
  • 5 edits in trunk

AX: Initial text selection point should respect element focus.
​https://bugs.webkit.org/show_bug.cgi?id=131402

Reviewed by Chris Fleizach.

Source/WebCore:

No new tests, updated existing selection-initial to test this functionality.

Support the case where we want to set the initial selection and there's already a focused element.

  • page/EventHandler.cpp:

(WebCore::setKeyboardSelection):
(WebCore::handleKeyboardSelectionMovement):

LayoutTests:

Updating test to make sure initial selection respects the focused element when necessary. Now, if a VoiceOver user attempts to use
arrow keys to read text and selection isn't set, we will set initial selection before/after the focused element if one is present.

  • platform/mac/accessibility/selection-initial-expected.txt:
  • platform/mac/accessibility/selection-initial.html:
2:07 PM Changeset in webkit [167032] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed test fix: Don't double-release BSTR.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dump): Remove unneeded call to SysFreeString now that we are
using _bstr_t for this variable.

1:31 PM April 2014 Meeting edited by timothy_horton@apple.com
(diff)
1:29 PM April 2014 Meeting edited by Simon Fraser
(diff)
1:26 PM April 2014 Meeting edited by ddkilzer@apple.com
(diff)
1:23 PM Changeset in webkit [167031] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Ensure that LLINT accessing of the ProtoCallFrame is big endian friendly.
<​https://webkit.org/b/131449>

Reviewed by Mark Hahnenberg.

Change ProtoCallFrame::paddedArgCount to be of type uint32_t. The argCount
that it pads is of type int anyway. It doesn't need to be 64 bit. This
also makes it work with the LLINT which is loading it with a loadi
instruction.

We should add the PayLoadOffset to ProtoCallFrame::argCountAndCodeOriginValue
when loading the argCount.

  • interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::setPaddedArgCount):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:21 PM Changeset in webkit [167030] by Brent Fulgham
  • 15 edits in trunk/Tools

[Win] Various DumpRenderTree Fixes.
​https://bugs.webkit.org/show_bug.cgi?id=131446.

Reviewed by Tim Horton.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::helpText): Ditto.
(AccessibilityUIElement::intValue): Ditto.
(AccessibilityUIElement::isPressActionSupported): Ditto.
(AccessibilityUIElement::accessibilityValue): Ditto.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(DRTDesktopNotificationPresenter::AddRef): Ditto.
(DRTDesktopNotificationPresenter::Release): Ditto.
(DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
(DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
(DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
(DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpFrameScrollPosition): Ditto.
(dumpFramesAsText): Ditto.
(compareHistoryItems): Ditto.
(dumpHistoryItem): Ditto.
(dump): Ditto.
(resetDefaultsToConsistentValues): Ditto.
(resetWebViewToConsistentStateBeforeTesting): Ditto.
(runTest): Ditto.
(createWebViewAndOffscreenWindow): Ditto.

  • DumpRenderTree/win/EditingDelegate.cpp:

(EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(EditingDelegate::AddRef): Ditto.
(EditingDelegate::Release): Ditto.
(dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
(EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
(EditingDelegate::shouldEndEditingInDOMRange): Ditto.
(EditingDelegate::shouldInsertNode): Ditto.
(EditingDelegate::shouldInsertText): Ditto.
(EditingDelegate::shouldDeleteDOMRange): Ditto.
(EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
(EditingDelegate::shouldApplyStyle): Ditto.
(EditingDelegate::shouldChangeTypingStyle): Ditto.
(EditingDelegate::doPlatformCommand): Ditto.
(EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(EditingDelegate::webViewDidChange): Ditto.
(EditingDelegate::webViewDidEndEditing): Ditto.
(EditingDelegate::webViewDidChangeTypingStyle): Ditto.
(EditingDelegate::webViewDidChangeSelection): Ditto.
(EditingDelegate::checkSpellingOfString): Ditto.

  • DumpRenderTree/win/FrameLoadDelegate.cpp:

(descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(FrameLoadDelegate::FrameLoadDelegate): Ditto.
(FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(FrameLoadDelegate::AddRef): Ditto.
(FrameLoadDelegate::Release): Ditto.
(FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
(FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
(FrameLoadDelegate::didCommitLoadForFrame): Ditto.
(FrameLoadDelegate::didReceiveTitle): Ditto.
(FrameLoadDelegate::didChangeIcons): Ditto.
(delegatesWithDelayedWork): Ditto.
(FrameLoadDelegate::didFinishLoadForFrame): Ditto.
(FrameLoadDelegate::didFailLoadWithError): Ditto.
(FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
(FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
(FrameLoadDelegate::willCloseFrame): Ditto.
(FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
(FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
(FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
(FrameLoadDelegate::didDisplayInsecureContent): Ditto.
(FrameLoadDelegate::didRunInsecureContent): Ditto.

  • DumpRenderTree/win/FrameLoadDelegate.h:
  • DumpRenderTree/win/HistoryDelegate.cpp:

(HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(HistoryDelegate::updateHistoryTitle): Ditto.
(HistoryDelegate::populateVisitedLinksForWebView): Ditto.

  • DumpRenderTree/win/PolicyDelegate.cpp:

(dumpPath):
(PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(PolicyDelegate::AddRef): Ditto.
(PolicyDelegate::Release): Ditto.
(PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(PolicyDelegate::unableToImplementPolicyWithError): Ditto.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(ResourceLoadDelegate::AddRef): Ditto.
(ResourceLoadDelegate::Release): Ditto.
(ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
(ResourceLoadDelegate::willSendRequest): Ditto.
(ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
(ResourceLoadDelegate::didReceiveResponse): Ditto.
(ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
(ResourceLoadDelegate::didFailLoadingWithError): Ditto.

  • DumpRenderTree/win/TestRunnerWin.cpp: Ditto.

(TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(TestRunner::setUserStyleSheetLocation): Ditto.
(TestRunner::execCommand): Ditto.
(TestRunner::overridePreference): Ditto.
(TestRunner::evaluateScriptInIsolatedWorld): Ditto.

  • DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.

(TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(TextInputController::insertText): Ditto.

  • DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
(UIDelegate::AddRef): Ditto.
(UIDelegate::Release): Ditto.
(UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(UIDelegate::trackCustomPopupMenu): Ditto.
(UIDelegate::registerUndoWithTarget): Ditto.
(UIDelegate::removeAllActionsWithTarget): Ditto.
(UIDelegate::setActionTitle): Ditto.
(UIDelegate::undo): Ditto.
(UIDelegate::redo): Ditto.
(UIDelegate::canUndo): Ditto.
(UIDelegate::canRedo): Ditto.
(UIDelegate::printFrame): Ditto.
(UIDelegate::ftpDirectoryTemplatePath): Ditto.
(UIDelegate::webViewHeaderHeight): Ditto.
(UIDelegate::webViewFooterHeight): Ditto.
(UIDelegate::drawHeaderInRect): Ditto.
(UIDelegate::drawFooterInRect): Ditto.
(UIDelegate::webViewPrintingMarginRect): Ditto.
(UIDelegate::canRunModal): Ditto.
(UIDelegate::createModalDialog): Ditto.
(UIDelegate::runModal): Ditto.
(UIDelegate::isMenuBarVisible): Ditto.
(UIDelegate::setMenuBarVisible): Ditto.
(UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
(UIDelegate::paintCustomScrollbar): Ditto.
(UIDelegate::paintCustomScrollCorner): Ditto.
(UIDelegate::setFrame): Ditto.
(UIDelegate::webViewFrame): Ditto.
(UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
(UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
(UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
(UIDelegate::webViewAddMessageToConsole): Ditto.
(UIDelegate::doDragDrop): Ditto.
(UIDelegate::webViewGetDlgCode): Ditto.
(UIDelegate::createWebViewWithRequest): Ditto.
(UIDelegate::webViewClose): Ditto.
(UIDelegate::webViewFocus): Ditto.
(UIDelegate::webViewUnfocus): Ditto.
(UIDelegate::webViewPainted): Ditto.
(UIDelegate::exceededDatabaseQuota): Ditto.
(UIDelegate::embeddedViewWithArguments): Ditto.
(UIDelegate::webViewClosing): Ditto.
(UIDelegate::webViewSetCursor): Ditto.
(UIDelegate::webViewDidInvalidate): Ditto.
(UIDelegate::setStatusText): Ditto.
(UIDelegate::desktopNotificationsDelegate): Ditto.
(UIDelegate::drawBackground): Ditto.
(UIDelegate::decidePolicyForGeolocationRequest): Ditto.
(UIDelegate::didPressMissingPluginButton): Ditto.

  • DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.

(LoadItem::invoke): Switch to _bstr_t. Use JSStringCreateWithBSTR.
(LoadHTMLStringItem::invoke): Ditto.
(ScriptItem::invoke): Ditto.

12:48 PM Changeset in webkit [167029] by Lucas Forschler
  • 2 edits in tags/Safari-538.26.4/Source/WebCore

Merged r167023.

12:32 PM Changeset in webkit [167028] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLCollection::updateNamedElementCach iterates over items twice
​https://bugs.webkit.org/show_bug.cgi?id=131448

Reviewed by Andreas Kling.

Compute the length first and go through the cache interface to traverse through items.

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::updateNamedElementCache):

12:30 PM Changeset in webkit [167027] by Lucas Forschler
  • 5 edits in tags/Safari-538.26.4/Source

Versioning.

12:13 PM Changeset in webkit [167026] by Lucas Forschler
  • 1 copy in tags/Safari-538.26.4

New Tag.

11:43 AM Changeset in webkit [167025] by b.long@cablelabs.com
  • 24 edits
    2 copies
    3 adds in trunk

[GStreamer] Expose MPEG-TS metadata
​https://bugs.webkit.org/show_bug.cgi?id=122001

Reviewed by Eric Carlson.

.:

  • Source/cmake/FindGStreamer.cmake: Look for gstreamer-mpegts >= 1.3.0.
  • Source/cmake/OptionsEfl.cmake: Same.
  • Source/cmake/OptionsGTK.cmake: Same.

Source/WebCore:

Test: media/track/in-band/track-in-band-mpegts-metadata.html

  • CMakeLists.txt: Add InbandDataTextTrack.
  • PlatformGTK.cmake: Look for gstreamer-mpegts and use it if available.
  • WebCore.vcxproj/WebCore.vcxproj: Add InbandDataTextTrack.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Same.
  • WebCore.xcodeproj/project.pbxproj: Same.
  • html/track/DataCue.cpp:

(WebCore::DataCue::DataCue): Add a constructor using raw data.

  • html/track/DataCue.h:

(WebCore::DataCue::create): Same.

  • html/track/InbandDataTextTrack.cpp: Added, InbandTextTrack which implements addDataCue().
  • html/track/InbandDataTextTrack.h:
  • html/track/InbandGenericTextTrack.h: Move unimplemented methods to InbandTextTrack.
  • html/track/InbandWebVTTTextTrack.h: Same.
  • html/track/InbandTextTrack.h: Same, and add inBandMetadataTrackDispatchType.
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::create): Add constructor for InbandDataTextTrack.
(WebCore::InbandTextTrack::inBandMetadataTrackDispatchType): Added.

  • html/track/TextTrack.h:

(WebCore::TextTrack::inBandMetadataTrackDispatchType): Added (empty).

  • html/track/TextTrack.idl: Add inBandMetadataTrackDispatchType.
  • platform/graphics/InbandTextTrackPrivate.h: Add inBandMetadataTrackDispatchType and Data format.

(WebCore::InbandTextTrackPrivate::inBandMetadataTrackDispatchType):

  • platform/graphics/InbandTextTrackPrivateClient.h: Add addDataCue() method.
  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:

(WebCore::InbandMetadataTextTrackPrivateGStreamer::create): Allow specifying the cue format and id.

(WebCore::InbandMetadataTextTrackPrivateGStreamer::InbandMetadataTextTrackPrivateGStreamer): Same.

(WebCore::InbandMetadataTextTrackPrivateGStreamer::setInBandMetadataTrackDispatchType): Added.
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addDataCue): Added.
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addGenericCue): Added.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Check for MPEG-TS sections.
(WebCore::MediaPlayerPrivateGStreamer::processMpegTsSection): Add MPEG-TS section metadata, and get inBandMetadataTrackDispatchType from the PMT.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Explicitly use Generic CueFormat.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

LayoutTests:

  • media/content/user-private-streams.ts: Added.
  • media/track/in-band/track-in-band-mpegts-metadata-expected.txt: Added.
  • media/track/in-band/track-in-band-mpegts-metadata.html: Added.
11:41 AM Changeset in webkit [167024] by Chris Fleizach
  • 14 edits in trunk

AX: Make AXPress much more reliable on the Web
​https://bugs.webkit.org/show_bug.cgi?id=131426

Reviewed by Mario Sanchez Prada.

Source/WebCore:

AXPress fails when an event handler is on a node higher in the parent chain than the focused node.

We need to make AXPress more reliable by

1) Using the element that is focused as the target of the event
2) Search for the inner most control object when dispatching the event

Updated existing accessibility/press-works-on-control-types.html

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::press):

  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::press):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::performDefaultAction):

  • accessibility/AccessibilitySearchFieldButtons.cpp:

(WebCore::AccessibilitySearchFieldCancelButton::press):

  • accessibility/AccessibilitySearchFieldButtons.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButtonPart::press):

  • accessibility/AccessibilitySpinButton.h:

LayoutTests:

  • accessibility/press-works-on-control-types-expected.txt:
  • accessibility/press-works-on-control-types.html:
11:25 AM Changeset in webkit [167023] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

ContentFilterMac is broken when NE_FILTER_SOURCE is enabled.
<rdar://problem/15978793> and ​https://bugs.webkit.org/show_bug.cgi?id=131445

Reviewed by Andy Estes.

No new tests (Not a tested feature).

  • platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::needsMoreData): Only consider m_neFilterSourceStatus if m_neFilterSource exists.
(WebCore::ContentFilter::didBlockData): Ditto.

11:19 AM Changeset in webkit [167022] by zoltan@webkit.org
  • 2 edits
    5 adds in trunk/PerformanceTests

[CSS Shapes] Add no regions version of RegionsShapes performance test
​https://bugs.webkit.org/show_bug.cgi?id=131442

Reviewed by Ryosuke Niwa.

We would like have a no regions version for RegionsShapes performance test. The new
test produces similar layout to RegionsShapes.html without using regions. It is helpful
for us to do further comparisons when necessary. This test is skipped by default.

  • Layout/Shapes/RegionsShapesNoRegions.html: Added.
  • Layout/Shapes/resources/RegionsShapes.css: Added.

(html, body):
(.shape):
(#circleShape):
(#imageShape):
(#insetShape):
(#roundedInsetShape):
(#triangleLeft):
(#triangleRight):
(#selfIntersectingStar):
(#region1):
(#region2):
(#region3):

  • Layout/Shapes/resources/RegionsShapesContent.html:
  • Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth400.html: Added.
  • Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth600.html: Added.
  • Layout/Shapes/resources/RegionsShapesContentNoRegionsWidth800.html: Added.
11:15 AM Changeset in webkit [167021] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-04-09 Geoffrey Garen <​ggaren@apple.com>

Rolled back in r166972.

The iOS buildbot's scripts have been updated to build bmalloc, so the
build should now succeed on the bot.

Also renamed "Frameworks" to "Libraries" as suggested in a review comment.

WTF should link against bmalloc
​https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Michael Saboff.

This is required to build successfullly with bmalloc enabled.

  • WTF.xcodeproj/project.pbxproj:
10:28 AM Changeset in webkit [167020] by oliver@apple.com
  • 69 edits
    3 adds
    2 deletes in trunk

Rewrite Function.bind as a builtin
​https://bugs.webkit.org/show_bug.cgi?id=131083

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This change removes the existing function.bind implementation
entirely so JSBoundFunction is no more.

Instead we just return a regular JS closure with a few
private properties hanging off it that allow us to perform
the necessary bound function fakery. While most of this is
simple, a couple of key changes:

  • The parser and lexer now directly track whether they're parsing code for call or construct and convert the private name @IsConstructor into TRUETOK or FALSETOK as appropriate. This automatically gives us the ability to vary behaviour from within the builtin. It also leaves a lot of headroom for trivial future improvements.
  • The instanceof operator now uses the prototypeForHasInstance private name, and we have a helper function to ensure that all objects that need to can update their magical 'prototype' property pair correctly.
  • API/JSScriptRef.cpp:

(parseScript):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createBuiltinExecutable):

  • builtins/Function.prototype.js:

(bind.bindingFunction):
(bind.else.bindingFunction):
(bind):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):

  • bytecompiler/NodesCodegen.cpp:

(JSC::InstanceOfNode::emitBytecode):

  • interpreter/Interpreter.cpp:
  • parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer):
(JSC::Lexer<LChar>::parseIdentifier):
(JSC::Lexer<UChar>::parseIdentifier):

  • parser/Lexer.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseInner):

  • parser/Parser.h:

(JSC::parse):

  • parser/ParserModes.h:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

  • runtime/CommonIdentifiers.h:
  • runtime/Completion.cpp:

(JSC::checkSyntax):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::checkSyntax):

  • runtime/FunctionPrototype.cpp:

(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind): Deleted.

  • runtime/JSBoundFunction.cpp: Removed.
  • runtime/JSBoundFunction.h: Removed.
  • runtime/JSFunction.cpp:

(JSC::RetrieveCallerFunctionFunctor::RetrieveCallerFunctionFunctor):
(JSC::RetrieveCallerFunctionFunctor::operator()):
(JSC::retrieveCallerFunction):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::reset):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncSetTypeErrorAccessor):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):

Source/WebCore:

Switch WebCore to use the helper functions when defining the
prototype properties on DOM constructors, and update bindings
tests accordingly.

  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::finishCreation):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorHelperMethods):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::finishCreation):
(WebCore::JSTestNamedConstructorNamedConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::finishCreation):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::finishCreation):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::finishCreation):

LayoutTests:

Testing.

  • js/dom/function-bind-expected.txt:
  • js/regress/function-bind-expected.txt: Added.
  • js/regress/function-bind.html: Added.
  • js/regress/script-tests/function-bind.js: Added.

(foo):

10:23 AM Changeset in webkit [167019] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix. Replacing deprecated enum with AVPlayerViewControllerExitFullScreenReason.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController playerViewController:shouldDismissWithReason:]):

10:07 AM Changeset in webkit [167018] by stavila@adobe.com
  • 5 edits
    8 adds in trunk

[CSS Regions] Monolithic elements should not affect the layout of the content outside its region
​https://bugs.webkit.org/show_bug.cgi?id=130499

Reviewed by David Hyatt.

Source/WebCore:

When performing layout on an element flowed into regions, its logical height must not be incremented
past the region's logical bottom for monolithic elements in regions different than the last region their containing
block is fragmented into. This ensures that the following elements are correctly laid out
from the top of the next region.
This change must also be applied to floats in order to prevent text from avoiding part
of a float that did not actually made it into the current region, but instead overflowed
the previous one.

Tests: fast/regions/fragmentation-after-float-overflow-single-region.html

fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html
fast/regions/fragmentation-after-monolithic-overflow-single-region.html
fast/regions/fragmentation-after-monolithic-overflow.html

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::computePlacedFloatsTree):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::adjustBlockChildForPagination):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::applyAfterBreak): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow): Deleted.
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock): Deleted.
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild): Deleted.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::isBoxInDifferentRegionsAsFloat):

  • rendering/RenderFlowThread.h:

LayoutTests:

Added tests for different types of fragmentation following monolithic content
overflowing its region.
Rebased the webkit-flow-float-unable-to-push test as its expected result was not the correct one.

  • fast/regions/webkit-flow-float-unable-to-push-expected.html:
  • fast/regions/fragmentation-after-float-overflow-single-region-expected.html: Added.
  • fast/regions/fragmentation-after-float-overflow-single-region.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow-expected.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow-single-region-expected.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow-single-region.html: Added.
  • fast/regions/fragmentation-after-monolithic-overflow.html: Added.
10:05 AM Changeset in webkit [167017] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use std::array in AffineTransform, and get rid of setMatrix
​https://bugs.webkit.org/show_bug.cgi?id=131416

Reviewed by Sam Weinig.

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::AffineTransform):
(WebCore::AffineTransform::multiply):

  • platform/graphics/transforms/AffineTransform.h:

(WebCore::AffineTransform::setMatrix): Deleted.

9:58 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
9:53 AM Changeset in webkit [167016] by Carlos Garcia Campos
  • 6 edits
    1 delete in trunk/Source/WebCore

[GTK] Plugin process crashes when loading totem plugin
​https://bugs.webkit.org/show_bug.cgi?id=131357

Reviewed by Martin Robinson.

Remove netscape plugin implementation from WebCore that was only
used by WebKit1. This removes the conflict between the WebCore NPN
symbols and the ones used by the plugins.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • plugins/PluginViewNone.cpp:
  • plugins/gtk/PluginPackageGtk.cpp: Removed.
  • plugins/gtk/PluginViewGtk.cpp: Removed.
  • plugins/gtk/gtk2xtbin.c: Removed.
  • plugins/gtk/gtk2xtbin.h: Removed.
  • plugins/gtk/xembed.h: Removed.
9:47 AM Changeset in webkit [167015] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION (r166853): fast/preloader/document-write.html is very flaky
​https://bugs.webkit.org/show_bug.cgi?id=130942

  • platform/mac/TestExpectations: The offending code was re-landed, marking as

flaky again.

9:12 AM Changeset in webkit [167014] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

fullscreen controls first show a play button instead of a pause button
​https://bugs.webkit.org/show_bug.cgi?id=131430

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-04-09
Reviewed by Jer Noble.

isPlaying() is false while buffering, paused() isn't; use paused() for
the play button.

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement):
(WebVideoFullscreenModelMediaElement::handleEvent):
Use HTMLMediaElement::paused() instead of HTMLMediaElement::isPlaying()

8:47 AM Changeset in webkit [167013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove duplicated files and unnecessary conditions from UseJSC.cmake
​https://bugs.webkit.org/show_bug.cgi?id=131438

Patch by Eva Balazsfalvi <​evab.u-szeged@partner.samsung.com> on 2014-04-09
Reviewed by Csaba Osztrogonác.

No new tests required.

  • UseJSC.cmake:
8:08 AM Changeset in webkit [167012] by mario.prada@samsung.com
  • 6 edits in trunk

[GTK] Layout tests accessibility/children-changed-sends-notification.html and accessibility/notification-listeners.html fails
​https://bugs.webkit.org/show_bug.cgi?id=131380

Reviewed by Chris Fleizach.

Source/WebCore:

Don't emit signals for added objects that we know won't be exposed
to the accessibility hierarchy (e.g. static text).

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::attachWrapper): Add extra check and early return.

LayoutTests:

Updated TestExpectations file and update layout test that was not
correctly written, and expecting the signals in the wrong order.

  • platform/gtk/TestExpectations: Removed failure expectations.
  • accessibility/children-changed-sends-notification.html: Updated

test to make sure we touch the accessibility tree after adding a
<button> so we get the 'add' signal at the right moment.

  • accessibility/children-changed-sends-notification-expected.txt:

Updated expectations to expect the 'add' and 'remove' signals in
the right order.

8:05 AM Changeset in webkit [167011] by mario.prada@samsung.com
  • 4 edits in trunk

[AX][GTK] No new lines in some AX tests output
​https://bugs.webkit.org/show_bug.cgi?id=131294

Reviewed by Martin Robinson.

Source/WebCore:

Do not implement Hypetext or AtkText for the WebArea. Those
interfaces will be implemented by the containers (automatically
generated or not) for the different parts of the DOM and the
render subtree under this element anyway.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getInterfaceMaskFromObject): Make sure we don't apply
WAIHypertext nor WAIText to objects with role WebAreaRole.

LayoutTests:

Removed failure expectations for tests now passing.

  • platform/gtk/TestExpectations: Updated.
2:48 AM Changeset in webkit [167010] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

Stylechecker: False positive on inline asm code.
​https://bugs.webkit.org/show_bug.cgi?id=130570

Patch by Gergo Balogh <​gbalogh.u-szeged@partner.samsung.com> on 2014-04-09
Reviewed by Csaba Osztrogonác.

Disable stylechecking in asm blocks.

  • Scripts/webkitpy/style/checkers/cpp.py:

(process_line):
(_InlineASMState):
(_InlineASMState.init):
(_InlineASMState.process_line):
(_InlineASMState.isInside):
(_process_lines):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_member_initialization_list):

2:39 AM Changeset in webkit [167009] by mario.prada@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening for GTK.

Updated test expectations after r166175, which removed an <hr>
from the original test accessibility/lists.html.

  • platform/gtk/accessibility/lists-expected.txt: Updated
1:28 AM Changeset in webkit [167008] by Carlos Garcia Campos
  • 6 edits
    2 adds in trunk/Tools

[GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
​https://bugs.webkit.org/show_bug.cgi?id=131029

Reviewed by Philippe Normand.

Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
tests and remove the getWebKit1TestResoucesDir() method.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(testDownloadLocalFile): Use Test::getResourcesDir().
(testDownloadLocalFileError): Ditto.
(serverCallback): Ditto.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:

(serverCallback): Ditto.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(httpServerCallback): Ditto.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:

(serverCallback): Ditto.

  • TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
  • TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
  • TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::getWebKit1TestResoucesDir): Deleted.

12:37 AM Changeset in webkit [167007] by ap@apple.com
  • 5 edits
    21 adds in trunk

[WK2] HTTP authentication regression tests fail
​https://bugs.webkit.org/show_bug.cgi?id=81627
<rdar://problem/11079296>

Reviewed by Anders Carlsson.

Tools:

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
to pageLoaderClient structure.
(WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
for password based authentication (we do get server trust challenges on some tests,
which WKTR can't handle).
When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
calls won't be made, at least on CFNetwork based platforms.
(WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
make sense to associate auth requests with individual resources - there can be
multiple resources loading at once from the same protection space, so WebKit1 API
that had a resource identifier was inherently racy.

LayoutTests:

  • platform/mac-wk2/TestExpectations: Unskipped tests that now pass. Marked three

tests as failing, because enabling auth uncovered that they are failing
(in browser as well).

  • platform/wk2/http: Added.
  • platform/wk2/http/tests: Added.
  • platform/wk2/http/tests/loading: Added.
  • platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials: Added.
  • platform/wk2/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials-expected.txt.
  • platform/wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Copied from LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt.
  • platform/wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Copied from LayoutTests/http/tests/loading/basic-credentials-sent-automatically-expected.txt.
  • platform/wk2/http/tests/misc: Added.
  • platform/wk2/http/tests/misc/401-alternative-content-expected.txt: Copied from LayoutTests/http/tests/misc/401-alternative-content-expected.txt.
  • platform/wk2/http/tests/misc/authentication-redirect-1: Added.
  • platform/wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt.
  • platform/wk2/http/tests/misc/authentication-redirect-2: Added.
  • platform/wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt.
  • platform/wk2/http/tests/misc/authentication-redirect-4: Added.
  • platform/wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Copied from LayoutTests/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt.
  • platform/wk2/http/tests/security: Added.
  • platform/wk2/http/tests/security/401-logout: Added.
  • platform/wk2/http/tests/security/401-logout/401-logout-expected.txt: Copied from LayoutTests/http/tests/security/401-logout/401-logout-expected.txt.
  • platform/wk2/http/tests/xmlhttprequest: Added.
  • platform/wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/failed-auth-expected.txt.
  • platform/wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Copied from LayoutTests/http/tests/xmlhttprequest/remember-bad-password-expected.txt.

WebKit2 results are the same as WebKit1, except that they lack resource URL. That
is expected with WebKit2 API.

12:35 AM Changeset in webkit [167006] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r166975.

Do not use WebPage removed API to fix the build. Page overlays are
no broken, see ​https://bugs.webkit.org/show_bug.cgi?id=131433.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::paintContents):

12:32 AM April 2014 Meeting edited by abucur@adobe.com
(diff)
12:31 AM Changeset in webkit [167005] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build after r166965.

  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::WebDragClient::startDrag): Rename Clipboard to DataTransfer.

12:22 AM Changeset in webkit [167004] by ryuan.choi@samsung.com
  • 3 edits in trunk/Tools

[EFL] Change font path for DumpRenderTree and WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=131427

Reviewed by Gyuyoung Kim.

Since r166973, font path was changed.

  • DumpRenderTree/PlatformEfl.cmake:
  • WebKitTestRunner/PlatformEfl.cmake:

Apr 8, 2014:

11:31 PM Changeset in webkit [167003] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

nil should only be used for objects
​https://bugs.webkit.org/show_bug.cgi?id=131431

Patch by Conrad Shultz <Conrad Shultz> on 2014-04-08
Reviewed by Chris Fleizach.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
nil -> NO.

  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setMediaElement:]):
nil -> 0; change a NULL to nullptr while we're here.

11:25 PM Changeset in webkit [167002] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

Fix EFL Build errors since r166975.
​https://bugs.webkit.org/show_bug.cgi?id=131421

Patch by Hyowon Kim <​hw1008.kim@samsung.com> on 2014-04-08
Reviewed by Gyuyoung Kim.

This patch is just for fixing EFL build errors.
The page overlay functionality is not working yet.

  • CMakeLists.txt:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::display):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
(WebKit::CoordinatedLayerTreeHost::paintLayerContents):

  • WebProcess/WebPage/PageOverlayController.cpp:
  • WebProcess/WebPage/TapHighlightController.cpp:

(WebKit::TapHighlightController::hideHighlight):

11:18 PM Changeset in webkit [167001] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

[CSSRegions] Crash when video in region exits fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=131366

Reviewed by Andrei Bucur.

Source/WebCore:

After fix for ​https://bugs.webkit.org/show_bug.cgi?id=130392, we compute the region ranges
information for inline elements collected in named flows with associated region chains.
The algorithm for this computation, implemented in RenderFlowThread::getRegionRangeForBox,
walks up the render tree trying to find the top-most unsplittable box under the named flow
in the case where the region ranges information is not available.

As this traversal works properly only when the starting box is not detached from the render tree,
i changed the named flow information clearing in RenderBlock::collapseAnonymousBoxChild
to occur before the child to be collapsed is removed from the render tree.

Test: fast/regions/full-screen-video-in-region-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::collapseAnonymousBoxChild):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getRegionRangeForBox):

LayoutTests:

  • fast/regions/full-screen-video-in-region-crash-expected.txt: Added.
  • fast/regions/full-screen-video-in-region-crash.html: Added.
11:13 PM Changeset in webkit [167000] by ap@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Trying to unbreak flakiness dashboard after Gtk TextExpectations reshuffling.

  • platform/gtk-wk2/TestExpectations: Added.
10:25 PM Changeset in webkit [166999] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOS (redux).

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityARIAIsBusy]):
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):

10:23 PM Changeset in webkit [166998] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementCount]):

10:01 PM Changeset in webkit [166997] by Antti Koivisto
  • 7 edits
    2 adds in trunk/Source/WebCore

Factor tile coverage map into a class
​https://bugs.webkit.org/show_bug.cgi?id=131417

Reviewed by Tim Horton.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLayoutSublayersOfLayer):
(WebCore::PlatformCALayerClient::platformCALayerRespondsToLayoutChanges):
(WebCore::PlatformCALayerClient::platformCALayerAnimationStarted):
(WebCore::PlatformCALayerClient::platformCALayerContentsOrientation):
(WebCore::PlatformCALayerClient::platformCALayerShowDebugBorders):
(WebCore::PlatformCALayerClient::platformCALayerShowRepaintCounter):
(WebCore::PlatformCALayerClient::platformCALayerIncrementRepaintCount):
(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay):

Added default implementation to some of these to make clients less messy.

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::~TileController):
(WebCore::TileController::platformCALayerPaintContents):
(WebCore::TileController::setTiledScrollingIndicatorPosition):
(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::tiledScrollingIndicatorLayer):

  • platform/graphics/ca/mac/TileCoverageMap.h: Added.

(WebCore::TileCoverageMap::setPosition):
(WebCore::TileCoverageMap::layer):

  • platform/graphics/ca/mac/TileCoverageMap.mm: Added.


The new class.

(WebCore::TileCoverageMap::TileCoverageMap):
(WebCore::TileCoverageMap::~TileCoverageMap):
(WebCore::TileCoverageMap::update):
(WebCore::TileCoverageMap::platformCALayerPaintContents):
(WebCore::TileCoverageMap::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/mac/TileGrid.h:
  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::drawTileMapContents):

9:43 PM April 2014 Meeting edited by Simon Fraser
(diff)
9:07 PM April 2014 Meeting edited by bfulgham@webkit.org
(diff)
8:52 PM Changeset in webkit [166996] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Clip outer rounded border rect on device pixel boundaries.
​https://bugs.webkit.org/show_bug.cgi?id=131404

Reviewed by Simon Fraser.

Use device pixel snapped rectangle to clip out rounded rects, when not all sides are solid/double.
Snapping it to device pixel boundaries ensures that when we call drawRect(devicePixelSnappedRect) later,
it leaves no cruft behind.

Source/WebCore:

Test: fast/borders/hidpi-rounded-border-on-subpixel-position.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

LayoutTests:

  • fast/borders/hidpi-rounded-border-on-subpixel-position-expected.html: Added.
  • fast/borders/hidpi-rounded-border-on-subpixel-position.html: Added.
8:25 PM Changeset in webkit [166995] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r166479. 'bytes' is now abbreviated as 'B'.

  • public/js/helper-classes.js:

(PerfTestRuns.smallerIsBetter):

7:54 PM Changeset in webkit [166994] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Some CSS teaks.

  • public/common.css:

(#title):

  • public/index.html:

(#charts .pane):
(#charts .arrow):

7:27 PM April 2014 Meeting edited by rniwa@webkit.org
Add a hackathon idea (diff)
7:18 PM Changeset in webkit [166993] by jonlee@apple.com
  • 12 edits in trunk/Source

Turn MSE on by default
​https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>

Reviewed by Jer Noble.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • page/Settings.in: Add MEDIA_SOURCE conditional.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Set default to true.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebPreferencesStore.h: Set default to true.
  • UIProcess/API/C/WKPreferencesRefPrivate.h:
7:16 PM April 2014 Meeting edited by rniwa@webkit.org
Add a hackathon idea (diff)
6:45 PM Changeset in webkit [166992] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove an unused parameter from loadResource.

Reviewed by Darin Adler.

Since the CachedResourceRequest has the charset in it, we don't need to pass it separately to loadRequest.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
6:25 PM Changeset in webkit [166991] by ryuan.choi@samsung.com
  • 5 edits in trunk/Source

Unreviewed EFL build fix attempt since r166956

Source/WebCore:

  • page/efl/DragControllerEfl.cpp: Rename Clipboard to DataTransfer.

(WebCore::DragController::declareAndWriteDragImage):

Source/WebKit/efl:

  • WebCoreSupport/DragClientEfl.cpp: Rename Clipboard to DataTransfer.

(WebCore::DragClientEfl::willPerformDragSourceAction):
(WebCore::DragClientEfl::startDrag): Ditto.

  • WebCoreSupport/DragClientEfl.h:
6:11 PM Changeset in webkit [166990] by Simon Fraser
  • 3 edits
    2 adds in trunk

Source/WebCore: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
​https://bugs.webkit.org/show_bug.cgi?id=131412
<rdar://problem/16525044>

Reviewed by Tim Horton.

In r155998 we started to compute a root-relative transform in order to choose
a good contentsScale to avoid blurring on scaling.

However, the code failed to update this transform when passing over
GraphicsLayerCAs with no uncommitted changes, which caused us to choose
an incorrect contentsScale sometimes, resulting in blurriness.

Fix by updating the root-relative transform on layers with no uncommitted
changes.

Test: compositing/contents-scale/incremental-change.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):

LayoutTests: REGRESSION (r155998): Elements render at very low resolution with some 3d transforms
​https://bugs.webkit.org/show_bug.cgi?id=131412

Reviewed by Tim Horton.

Test that makes an incremental change to a layer property in a tree with
interesting 3d transforms.

  • compositing/contents-scale/incremental-change-expected.html: Added.
  • compositing/contents-scale/incremental-change.html: Added.
6:11 PM Changeset in webkit [166989] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Don't call CGPathAddPath with invalid CGAffineTransform objects
​https://bugs.webkit.org/show_bug.cgi?id=131413
<rdar://problem/16399645>

Reviewed by Darin Adler.

Covered by existing tests.

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::addPath):
Don't try to add the path if the affine transform isn't invertible.

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::isInvertible):
Handle infinite and NaN determinants.

(WebCore::AffineTransform::inverse):
Handle infinite and NaN determinants.

5:47 PM Changeset in webkit [166988] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-04-08 Geoffrey Garen <​ggaren@apple.com>

Stop linking WTF against bmalloc.

Reviewed by Enrica Casucci.

This seems to have broken an iOS buildbot script. Disable it for now
until we can fix the script.

  • WTF.xcodeproj/project.pbxproj:
5:40 PM Changeset in webkit [166987] by ggaren@apple.com
  • 2 edits in trunk/Tools

Fix the build-jsc build
​https://bugs.webkit.org/show_bug.cgi?id=131410

Reviewed by Michael Saboff.

  • Scripts/build-jsc: Make sure to build bmalloc before WTF, since

WTF depends on it.

5:38 PM Changeset in webkit [166986] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the typo in the previous commit.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

5:37 PM Changeset in webkit [166985] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r 166890): Crash inside WebKit::WebEditorClient::textFieldDidEndEditing
​https://bugs.webkit.org/show_bug.cgi?id=131409

Reviewed by Anders Carlsson.

Create an empty API::InjectedBundle::FormClient to avoid crashing inside
m_mainFrame->coreFrame()->loader().detachFromParent().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):

5:22 PM Changeset in webkit [166984] by Brian Burg
  • 3 edits
    1 add in trunk

Web Replay: memoize nondeterministic attributes of the Screen interface
​https://bugs.webkit.org/show_bug.cgi?id=131339

Reviewed by Timothy Hatcher.

.:

  • ManualTests/inspector/replay-window-screen.html: Added.

Source/WebCore:

The values from the screen interface are nondeterministic. Since we can't
change the physical screen dimensions, instead memoize values of attributes.

Test: ManualTests/inspector/replay-window-screen.html

  • page/Screen.idl: Add Nondeterministic attribute.
5:13 PM Changeset in webkit [166983] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=131408
Scrollbars layers don't dynamically update when device scale factor changes
-and corresponding-
<rdar://problem/16503875>

Reviewed by Tim Horton.

The scrollbar layers are not children of the RenderView's layer, so they were
completely skipped over by this function before. We need to start this higher up
the tree in the rootGraphicsLayer(), which will typically return the
m_overflowControlsHostLayer.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged):

5:12 PM Changeset in webkit [166982] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message
​https://bugs.webkit.org/show_bug.cgi?id=131406

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-04-08
Reviewed by Timothy Hatcher.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::stop):
(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
Provide a way to stop externally and a path to stop when in
the middle of handling a message already with the locked mutex.

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeFromMessage):
Provide a way to close externally and a path to close when in
the middle of handling a message already with a mutex.

5:06 PM Changeset in webkit [166981] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLConverter::aggregatedAttributesForAncestors should cache intermediate results
​https://bugs.webkit.org/show_bug.cgi?id=131400

Reviewed by Sam Weinig.

Instead of accumulating attributes from a character node to the highest ancestor,
recursively call aggregatedAttributesForElementAndItsAncestors so that aggregated
attributes are cached on each ancestor to eliminate the old O(n2) behavior.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::aggregatedAttributesForAncestors):
(HTMLConverter::aggregatedAttributesForElementAndItsAncestors): Extracted from aggregatedAttributesForAncestors.

4:53 PM Changeset in webkit [166980] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed CMake build fix after r166965.

  • UseJSC.cmake: Rename JSClipboardCustom.cpp to JSDataTransferCustom.cpp.
4:44 PM Changeset in webkit [166979] by Martin Robinson
  • 6 edits
    147 deletes in trunk

[GTK] Remove the WebKitGTK+ WebKit 1 code
​https://bugs.webkit.org/show_bug.cgi?id=131399

Reviewed by Anders Carlsson.

.:

  • Source/PlatformGTK.cmake: Remove WebKit1 dependency from dist target.
  • Source/cmake/OptionsGTK.cmake: Remove option to compile with GTK+2 or with WebKit2 disabled.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Remove references to WebKit1 source files from the list of

files with translatable strings.

Source/WebKit:

  • PlatformGTK.cmake: Removed.
  • gtk: Remove this entire directory.
4:40 PM Changeset in webkit [166978] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Unify and factor out page overlay implementations
​https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/PageOverlayController.cpp:

(WebKit::PageOverlayController::uninstallPageOverlay):
Don't turn fast scrolling back off unless the last overlay is removed.

4:36 PM Changeset in webkit [166977] by Martin Robinson
  • 3 edits
    36 deletes in trunk/Tools

[GTK] Remove WebKit1 unit tests
​https://bugs.webkit.org/show_bug.cgi?id=131359

Reviewed by Anders Carlsson.

Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
they were inadvertently left in ​http://trac.webkit.org/changeset/166504.

  • CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
  • Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
  • TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
  • TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
4:19 PM Changeset in webkit [166976] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Add a WKNavigationAction property indicating whether it resulted from processing a user gesture
​https://bugs.webkit.org/show_bug.cgi?id=131405
<rdar://problem/16535453>

Reviewed by Tim Horton.

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::NavigationActionData):
(WebKit::NavigationActionData::encode):
(WebKit::NavigationActionData::decode):

  • Shared/NavigationActionData.h:
  • UIProcess/API/Cocoa/WKNavigationActionInternal.h:
  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

4:09 PM Changeset in webkit [166975] by timothy_horton@apple.com
  • 19 edits
    2 adds in trunk/Source/WebKit2

Unify and factor out page overlay implementations
​https://bugs.webkit.org/show_bug.cgi?id=131353

Reviewed by Anders Carlsson.

Bring all of the PageOverlay code together in a single cross-platform
PageOverlayController, including hit-testing code from WebPage and painting
and layer-tree manipulation code from the DrawingArea.

This also makes all PageOverlays a single GraphicsLayer tree which can be
flushed and plugged into any DrawingArea in a straightforward manner.
We no longer have to watch for individual layers flipping into/out of tiling,
because they're hidden underneath the root PageOverlay GraphicsLayer.
Additionally, because GraphicsLayer is cross-platform, we can share
all of the fairly trivial but oft-repeated overlay management code.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/PageOverlayController.cpp: Added.
  • WebProcess/WebPage/PageOverlayController.h: Added.

(WebKit::PageOverlayController::rootLayer):
Add PageOverlayController.

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Remove PageOverlay-related code from the DrawingAreas.

  • WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
(WebKit::PageOverlay::clear):

  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
Use PageOverlayController instead of the DrawingArea/WebPage to manipulate page overlays.

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::pageOverlayController):
Remove PageOverlay-related code from WebPage.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded): Deleted.
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved): Deleted.
(WebKit::RemoteLayerTreeContext::flushOutOfTreeLayers): Deleted.
Remove the no-longer-necessary out-of-tree layer code.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageInstallPageOverlayWithAnimation):
(WKBundlePageUninstallPageOverlayWithAnimation):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::hideHighlight):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::hideFindUI):

  • WebProcess/WebPage/TelephoneNumberOverlayController.cpp:

(WebKit::TelephoneNumberOverlayController::createOverlayIfNeeded):
(WebKit::TelephoneNumberOverlayController::destroyOverlay):
Make use of the FadeMode enum.

3:59 PM Changeset in webkit [166974] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed gardening (Take 2): Prevent users from attempting
to build with known invalid cURL.

  • Scripts/webkitdirs.pm:

(checkInstalledTools): Check for 7.34.0 (the broken version), not
7.33.0 (the known good version).

3:52 PM Changeset in webkit [166973] by Martin Robinson
  • 3 edits
    3 moves
    1 add
    22 deletes in trunk/Tools

[GTK] Remove DumpRenderTree and GtkLauncher
​https://bugs.webkit.org/show_bug.cgi?id=131373

Reviewed by Andreas Kling.

Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
no longer necessary now that WebKit1 GTK+ will be removed.

  • CMakeLists.txt:
  • DumpRenderTree/PlatformGTK.cmake: Removed.
  • DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
  • DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
  • DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
  • DumpRenderTree/gtk/EditingCallbacks.h: Removed.
  • DumpRenderTree/gtk/EventSender.cpp: Removed.
  • DumpRenderTree/gtk/EventSender.h: Removed.
  • DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
  • DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
  • DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
  • DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
  • DumpRenderTree/gtk/TextInputController.cpp: Removed.
  • DumpRenderTree/gtk/TextInputController.h: Removed.
  • DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
  • GtkLauncher/CMakeLists.txt: Removed.
  • GtkLauncher/LauncherInspectorWindow.c: Removed.
  • GtkLauncher/LauncherInspectorWindow.h: Removed.
  • GtkLauncher/main.c: Removed.
  • GtkLauncher/simple.svg: Removed.
  • GtkLauncher/text.html: Removed.
  • WebKitTestRunner/PlatformGTK.cmake:
  • WebKitTestRunner/gtk/fonts/AHEM.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM.TTF.
  • WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
  • WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
3:51 PM Changeset in webkit [166972] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

WTF should link against bmalloc
​https://bugs.webkit.org/show_bug.cgi?id=131403

Reviewed by Michael Saboff.

This is required to build successfullly with bmalloc enabled.

  • WTF.xcodeproj/project.pbxproj:
3:46 PM Changeset in webkit [166971] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: Address stale FIXMEs concerning console in JSContext inspection
​https://bugs.webkit.org/show_bug.cgi?id=131398

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-04-08
Reviewed by Timothy Hatcher.

  • inspector/InjectedScriptSource.js:

The console object can be deleted from a page or JSContext,
so keep code that expects that it could have been deleted
to be resilient in those cases.

  • inspector/JSGlobalObjectScriptDebugServer.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:

Change the FIXMEs to NOTEs that explain why these functions
have empty implementations for JSContext inspection.

3:44 PM Changeset in webkit [166970] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix.

Return false instead of nil in a function that returns BOOL.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):

3:37 PM Changeset in webkit [166969] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Change WebPageProxy::CreateNewPage to take a NavigationActionData object
​https://bugs.webkit.org/show_bug.cgi?id=131401

Reviewed by Dan Bernstein.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(toWKNavigationType):

  • UIProcess/API/Cocoa/WKNavigationActionInternal.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::toWKNavigationType): Deleted.

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createWindow):

3:36 PM Changeset in webkit [166968] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Non-empty ranges misdetected as empty ranges, avoiding telephone number detection.
<rdar://problem/16553441> and ​https://bugs.webkit.org/show_bug.cgi?id=131397

Reviewed by Tim Horton.

No new tests (Only affects a currently untested Mac-only WK2 feature)

  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers): Fix detection of empty ranges so we don’t

early return erroneously.

3:27 PM Changeset in webkit [166967] by cavalcantii@gmail.com
  • 3 edits
    2 adds in trunk

[SVG] Fix CSS transform handling when zoomed
​https://bugs.webkit.org/show_bug.cgi?id=125836

Reviewed by Tim Horton.

Source/WebCore:

Tests: svg/zoom/page/zoom-css-transforms-expected.svg

svg/zoom/page/zoom-css-transforms.svg

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

  • svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform):

LayoutTests:

Adjusts CSS transforms when used in SVG to account for unexpected
translation scale. Backport from Chromium #174910.

  • svg/zoom/page/zoom-css-transforms-expected.svg: Added.
  • svg/zoom/page/zoom-css-transforms.svg: Added.
3:26 PM Changeset in webkit [166966] by hmuller@adobe.com
  • 3 edits
    4 adds in trunk

[CSS Shapes] large corner radius combined with 0 radius does not wrap properly
​https://bugs.webkit.org/show_bug.cgi?id=129739

Reviewed by Bem Jones-Bey.

Source/WebCore:

Corrected special case handling for shape-outside border-box values with border-radius
values that greater than or equal to the box's height.

Tests: fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html

fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::getExcludedIntervals):

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001-expected.txt: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-big-box-border-radius-002.html: Added.
3:06 PM Changeset in webkit [166965] by ap@apple.com
  • 64 edits
    6 moves in trunk

Source/WebCore: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

This is the name used in HTML5, and it's much better than the confusing Clipboard one.

Renamed related enums too, and made DataTransferAccessPolicy an enum class.

  • CMakeLists.txt:
  • Configurations/WebCore.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSClipboardCustom.cpp: Removed.
  • bindings/js/JSDataTransferCustom.cpp: Copied from Source/WebCore/bindings/js/JSClipboardCustom.cpp.

(WebCore::JSDataTransfer::types):
(WebCore::JSClipboard::types): Deleted.

  • bindings/js/JSEventCustom.cpp:
  • dom/Clipboard.cpp: Removed.
  • dom/Clipboard.h: Removed.
  • dom/Clipboard.idl: Removed.
  • dom/ClipboardAccessPolicy.h: Removed.
  • dom/ClipboardEvent.cpp:

(WebCore::ClipboardEvent::ClipboardEvent):

  • dom/ClipboardEvent.h:

(WebCore::ClipboardEvent::create):
(WebCore::ClipboardEvent::clipboard): Deleted.

  • dom/ClipboardMac.mm: Removed.
  • dom/DOMAllInOne.cpp:
  • dom/DataTransfer.cpp: Copied from Source/WebCore/dom/Clipboard.cpp.

(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy):
(WebCore::DataTransfer::canReadTypes):
(WebCore::DataTransfer::canReadData):
(WebCore::DataTransfer::canWriteData):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData):
(WebCore::DataTransfer::setData):
(WebCore::DataTransfer::types):
(WebCore::DataTransfer::files):
(WebCore::DataTransfer::dropEffect):
(WebCore::DataTransfer::setDropEffect):
(WebCore::DataTransfer::effectAllowed):
(WebCore::DataTransfer::setEffectAllowed):
(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::createForDragAndDrop):
(WebCore::DataTransfer::canSetDragImage):
(WebCore::DataTransfer::updateDragImage):
(WebCore::DataTransfer::createDragImage):
(WebCore::DragImageLoader::DragImageLoader):
(WebCore::DragImageLoader::imageChanged):
(WebCore::DataTransfer::sourceOperation):
(WebCore::DataTransfer::destinationOperation):
(WebCore::DataTransfer::setSourceOperation):
(WebCore::DataTransfer::setDestinationOperation):
(WebCore::Clipboard::Clipboard): Deleted.
(WebCore::Clipboard::createForCopyAndPaste): Deleted.
(WebCore::Clipboard::~Clipboard): Deleted.
(WebCore::Clipboard::setAccessPolicy): Deleted.
(WebCore::Clipboard::canReadTypes): Deleted.
(WebCore::Clipboard::canReadData): Deleted.
(WebCore::Clipboard::canWriteData): Deleted.
(WebCore::Clipboard::clearData): Deleted.
(WebCore::Clipboard::getData): Deleted.
(WebCore::Clipboard::setData): Deleted.
(WebCore::Clipboard::types): Deleted.
(WebCore::Clipboard::files): Deleted.
(WebCore::Clipboard::dropEffect): Deleted.
(WebCore::Clipboard::setDropEffect): Deleted.
(WebCore::Clipboard::effectAllowed): Deleted.
(WebCore::Clipboard::setEffectAllowed): Deleted.
(WebCore::Clipboard::setDragImage): Deleted.
(WebCore::Clipboard::createForDragAndDrop): Deleted.
(WebCore::Clipboard::canSetDragImage): Deleted.
(WebCore::Clipboard::updateDragImage): Deleted.
(WebCore::Clipboard::createDragImage): Deleted.
(WebCore::Clipboard::sourceOperation): Deleted.
(WebCore::Clipboard::destinationOperation): Deleted.
(WebCore::Clipboard::setSourceOperation): Deleted.
(WebCore::Clipboard::setDestinationOperation): Deleted.

  • dom/DataTransfer.h: Copied from Source/WebCore/dom/Clipboard.h.
  • dom/DataTransfer.idl: Copied from Source/WebCore/dom/Clipboard.idl.
  • dom/DataTransferAccessPolicy.h: Copied from Source/WebCore/dom/ClipboardAccessPolicy.h.
  • dom/DataTransferItemList.h:
  • dom/DataTransferMac.mm: Copied from Source/WebCore/dom/ClipboardMac.mm.

(WebCore::DataTransfer::createDragImage):
(WebCore::Clipboard::createDragImage): Deleted.

  • dom/Event.h:

(WebCore::Event::clipboardData):
(WebCore::Event::internalDataTransfer):
(WebCore::Event::clipboard): Deleted.

  • dom/Event.idl:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEvent::dataTransfer):

  • dom/MouseEvent.idl:
  • dom/WheelEvent.cpp:
  • editing/Editor.cpp:

(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::performCutOrCopy):
(WebCore::Editor::selectedTextForDataTransfer):
(WebCore::Editor::selectedTextForClipboard): Deleted.

  • editing/Editor.h:
  • editing/ios/EditorIOS.mm:

(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

  • loader/EmptyClients.h:
  • page/DragClient.h:
  • page/DragController.cpp:

(WebCore::DragController::dragExited):
(WebCore::DragController::performDrag):
(WebCore::DragController::tryDHTMLDrag):
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):

  • page/DragController.h:
  • page/DragState.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::hasFileOfType):
(WebCore::hasStringOfType):
(WebCore::hasDropZoneType):
(WebCore::findDropZone):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::cancelDragAndDrop):
(WebCore::EventHandler::performDragAndDrop):
(WebCore::EventHandler::freeDataTransfer):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::dispatchDragSrcEvent):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::freeClipboard): Deleted.

  • page/EventHandler.h:
  • page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::declareAndWriteDragImage):

  • page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/mac/DragControllerMac.mm:

(WebCore::DragController::declareAndWriteDragImage):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingDataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • page/win/DragControllerWin.cpp:

(WebCore::DragController::declareAndWriteDragImage):

  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingataTransfer):
(WebCore::EventHandler::createDraggingClipboard): Deleted.

  • platform/Pasteboard.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/PasteboardMac.mm:
  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeRangeToDataObject):
(WebCore::Pasteboard::writeSelection):

Source/WebKit/ios: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • WebView/WebPDFViewPlaceholder.mm:

Source/WebKit/mac: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm:

(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):

  • WebView/WebPDFView.mm:

Source/WebKit2: Fix build.

Patch by Anders Carlsson <​andersca@apple.com> on 2014-04-08

  • WebKit2Prefix.h:

LayoutTests: Rename Clipboard to DataTransfer
​https://bugs.webkit.org/show_bug.cgi?id=131371

Reviewed by Anders Carlsson.

  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
2:41 PM Changeset in webkit [166964] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix. Pass 0 instead of nil to the options parameter of addObserver:forKeyPath:options:context.

  • platform/graphics/ios/TextTrackRepresentationIOS.mm:

(-[WebCoreTextTrackRepresentationIOSHelper setParent:]):

2:33 PM Changeset in webkit [166963] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build.

  • WebKit2Prefix.h:
2:29 PM Changeset in webkit [166962] by Brent Fulgham
  • 5 edits
    1 move
    2 adds
    1 delete in trunk/Source/WebInspectorUI

[Windows] Generate Optimized WebInspectorUI in Release Build
​https://bugs.webkit.org/show_bug.cgi?id=120120

Reviewed by Timothy Hatcher.

  • Scripts/copy-user-interface-resources.pl: Copied from Scripts/copy-user-interface-resources.sh.
  • Scripts/copy-user-interface-resources.sh: Removed.
  • Scripts/remove-console-asserts.pl:
  • WebInspectorUI.vcxproj/WebInspectorUI.make: Added.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj: Switch to Makefile style.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters: Ditto.
  • WebInspectorUI.vcxproj/WebInspectorUIPostBuild.cmd: More work should

be done in the new build-webinspectorui.sh file.

  • WebInspectorUI.vcxproj/build-webinspectorui.sh: Added.
  • WebInspectorUI.xcodeproj/project.pbxproj:
2:22 PM Changeset in webkit [166961] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use an explicit class when decoding individual bundle parameters
​https://bugs.webkit.org/show_bug.cgi?id=131392
<rdar://problem/16213914>

Reviewed by Dan Bernstein.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::setBundleParameter):

2:18 PM Changeset in webkit [166960] by Brent Fulgham
  • 13 edits in trunk/LayoutTests

[Mac] Unreviewed test gardening.

Rebaseline scrolling tests to remove flakiness introduced by slight differences in
pixel scroll counts between WK1 and WK2 test runners.

  • platform/mac/fast/scrolling/scroll-div-latched-div-expected.txt:
  • platform/mac/fast/scrolling/scroll-div-latched-div.html:
  • platform/mac/fast/scrolling/scroll-div-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-div-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-iframe-latched-iframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-iframe-latched-iframe.html:
  • platform/mac/fast/scrolling/scroll-iframe-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-iframe-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-select-latched-mainframe-expected.txt:
  • platform/mac/fast/scrolling/scroll-select-latched-mainframe.html:
  • platform/mac/fast/scrolling/scroll-select-latched-select-expected.txt:
  • platform/mac/fast/scrolling/scroll-select-latched-select.html:
2:11 PM Changeset in webkit [166959] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Move a Mountain Lion declaration to the WebKit2 prefix header
​https://bugs.webkit.org/show_bug.cgi?id=131391

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKProcessPool.mm:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/mac/WebContextMac.mm:
  • WebKit2Prefix.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:
1:50 PM Changeset in webkit [166958] by Antti Koivisto
  • 12 edits in trunk/Source

Remove exposedRect from TileController
​https://bugs.webkit.org/show_bug.cgi?id=131378

Reviewed by Simon Fraser.

Source/WebCore:

Having two separate visible rectangles is confusing. We should compute one on higher level.

  • page/FrameView.cpp:

(WebCore::FrameView::setExposedRect):

Push exposed rect to tile controller by doing a layer flush (like the changed visible rect is normally passed).

  • platform/graphics/TiledBacking.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:


Remove exposedRect and just use visibleRect.

(WebCore::TileController::TileController):
(WebCore::TileController::setTiledScrollingIndicatorPosition):

Update the scrolling indicator position.

(WebCore::TileController::updateTileCoverageMap):
(WebCore::TileController::setExposedRect): Deleted.

  • platform/graphics/ca/mac/TileGrid.h:
  • platform/graphics/ca/mac/TileGrid.mm:

(WebCore::TileGrid::tilesWouldChangeForVisibleRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::scaledExposedRect): Deleted.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):

No need to push exposedRect anymore.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

Integrate exposed rect to visible rect when flushing layers.

Source/WebKit2:

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):

Update the visible rect for pageOverlayLayers by calling flushCompositingState. This way
tile controller visible rect updates always happens via compositing flush (we assert
for this in TileController::setVisibleRect).

1:36 PM Changeset in webkit [166957] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Added a bmalloc back-end for FastMalloc
​https://bugs.webkit.org/show_bug.cgi?id=131387

Reviewed by Andreas Kling.

We'll need to rethink some things if we adopt this back-end. For example,
fastMallocSize() and fastMallocGoodSize() are no longer real things. But,
this is enough to test for now.

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastCalloc):
(WTF::fastRealloc):
(WTF::fastFree):
(WTF::fastMallocSize):
(WTF::fastMallocGoodSize):
(WTF::tryFastMalloc):
(WTF::tryFastRealloc):
(WTF::tryFastCalloc):
(WTF::releaseFastMallocFreeMemory):
(WTF::fastMallocStatistics):

1:36 PM Changeset in webkit [166956] by ggaren@apple.com
  • 24 edits in trunk/Source/bmalloc

Made bmalloc more #include friendly
​https://bugs.webkit.org/show_bug.cgi?id=131386

Reviewed by Andreas Kling.

Marked a bunch of headers private so they can be used from client code
that #includes bmalloc.h.

Renamed ASSERT macros to BASSERT. This matches their header, which already
had to be renamed, and fixes conflicts with WTF's ASSERT macros.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocateSlowCase):

  • bmalloc/AsyncTask.h:

(bmalloc::Function>::runSlowCase):

  • bmalloc/BAssert.h:
  • bmalloc/BoundaryTag.h:

(bmalloc::BoundaryTag::setSize):

  • bmalloc/BoundaryTagInlines.h:

(bmalloc::validate):
(bmalloc::BoundaryTag::init):
(bmalloc::BoundaryTag::deallocate):
(bmalloc::BoundaryTag::splitLarge):
(bmalloc::BoundaryTag::allocate):

  • bmalloc/Chunk.h:
  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):

  • bmalloc/Deallocator.h:

(bmalloc::Deallocator::deallocateFastCase):

  • bmalloc/FixedVector.h:

(bmalloc::Capacity>::operator):
(bmalloc::Capacity>::push):
(bmalloc::Capacity>::pop):
(bmalloc::Capacity>::shrink):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateLarge):

  • bmalloc/LargeChunk.h:

(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::endTag):

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::concurrentRef):
(bmalloc::Line<Traits>::deref):

  • bmalloc/MediumAllocator.h:

(bmalloc::MediumAllocator::allocate):

  • bmalloc/ObjectType.h:

(bmalloc::isSmall):

  • bmalloc/Page.h:

(bmalloc::Page<Traits>::ref):
(bmalloc::Page<Traits>::deref):

  • bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getSlowCase):

  • bmalloc/SegregatedFreeList.cpp:

(bmalloc::SegregatedFreeList::SegregatedFreeList):
(bmalloc::SegregatedFreeList::insert):

  • bmalloc/SmallAllocator.h:

(bmalloc::SmallAllocator::allocate):
(bmalloc::SmallAllocator::refill):

  • bmalloc/Syscall.h:
  • bmalloc/VMAllocate.h:

(bmalloc::vmValidate):
(bmalloc::vmAllocate):
(bmalloc::vmDeallocatePhysicalPagesSloppy):

  • bmalloc/Vector.h:

(bmalloc::Vector<T>::operator):
(bmalloc::Vector<T>::pop):
(bmalloc::Vector<T>::shrink):

  • bmalloc/XLargeChunk.h:

(bmalloc::XLargeChunk::range):
(bmalloc::XLargeChunk::size):

1:32 PM Changeset in webkit [166955] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix corrupt APPLE_IMAGES_LICENSE.rtf after r165676.
​https://bugs.webkit.org/show_bug.cgi?id=131384

Reviewed by Joseph Pecoraro.

  • APPLE_IMAGES_LICENSE.rtf:
1:32 PM Changeset in webkit [166954] by mrowe@apple.com
  • 2 edits in trunk/Tools

XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
<​https://webkit.org/b/131388> / <rdar://problem/16291687>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitdirs.pm:

(runMacWebKitApp): Set XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
(execMacWebKitAppForDebugging): Ditto.

1:26 PM Changeset in webkit [166953] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Always do a full GC when simulating memory pressure.
<​https://webkit.org/b/129790>

To get more consistent accounting on automated memory testers,
add a synchronous GC as part of the simulated memory pressure event.

Reviewed by Geoffrey Garen.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

1:25 PM Changeset in webkit [166952] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix a goofy assertion to fix debug.

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::isSetter):
(JSC::PutByIdAccess::oldStructure):
(JSC::PutByIdAccess::chain):
(JSC::PutByIdAccess::stubRoutine):
(JSC::PutByIdAccess::customSetter):

1:24 PM Changeset in webkit [166951] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix. Pass 0 instead of nil to setRate: when pausing.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):

1:05 PM Changeset in webkit [166950] by mitz@apple.com
  • 4 edits in trunk

Added bmalloc to the WebKit workspace.
​https://bugs.webkit.org/show_bug.cgi?id=131362

Reviewed by Geoff Garen.

  • WebKit.xcworkspace/contents.xcworkspacedata:
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
1:04 PM Changeset in webkit [166949] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Update text expectations for failing tests:

accessibility/children-changed-sends-notification.html
accessibility/notification-listeners.html
fast/repaint/blend-mode-isolate-stacking-context.html
fast/repaint/hidpi-absolute-positioned-element-wrong-cliprect-after-move.html

Rebaseline fast/multicol/client-rects-expected.txt after r165991

Patch by Carlos Alberto Lopez Perez <​clopez@igalia.com> on 2014-04-08

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
1:03 PM Changeset in webkit [166948] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Fail silently if the LLVM dylib isn't found
​https://bugs.webkit.org/show_bug.cgi?id=131385

Reviewed by Mark Hahnenberg.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • llvm/InitializeLLVM.cpp:

(JSC::initializeLLVM):

  • llvm/InitializeLLVM.h:
  • llvm/InitializeLLVMPOSIX.cpp:

(JSC::initializeLLVMPOSIX):

12:56 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:52 PM WebKitGTK/KeepingTheTreeGreen edited by clopez@igalia.com
(diff)
12:48 PM Changeset in webkit [166947] by ggaren@apple.com
  • 4 edits in trunk

Build bmalloc on iOS too
​https://bugs.webkit.org/show_bug.cgi?id=131381

Reviewed by Andreas Kling.

.:

  • Source/Makefile: Build it.

Tools:

  • Scripts/build-webkit:
12:42 PM Changeset in webkit [166946] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

FlagsChanged events are not delivered to input methods when using async text input
​https://bugs.webkit.org/show_bug.cgi?id=131383

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKView.mm: (-[WKView _interpretKeyEvent:completionHandler:]):

The early return is no longer needed.

12:39 PM Changeset in webkit [166945] by fpizlo@apple.com
  • 9 edits
    4 adds in trunk

Repatch should support setters and plant calls to them directly
​https://bugs.webkit.org/show_bug.cgi?id=130750

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

All of the infrastructure was in place so this just enables setter optimization.

This is a 12x speed-up on setter microbenchmarks. This is a 1% speed-up on Octane.

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::visitWeak):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::setter):
(JSC::PutByIdAccess::customSetter): Deleted.

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeForStubInfo):

  • jit/Repatch.cpp:

(JSC::toString):
(JSC::kindFor):
(JSC::customFor):
(JSC::generateByIdStub):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):

  • runtime/JSObject.cpp:

(JSC::JSObject::put):

  • runtime/Lookup.h:

(JSC::putEntry):

  • runtime/PutPropertySlot.h:

(JSC::PutPropertySlot::setCacheableSetter):
(JSC::PutPropertySlot::isCacheableSetter):
(JSC::PutPropertySlot::isCacheableCustom):
(JSC::PutPropertySlot::setCacheableCustomProperty): Deleted.
(JSC::PutPropertySlot::isCacheableCustomProperty): Deleted.

  • tests/stress/setter.js: Added.

(foo):

LayoutTests:

Reviewed by Geoffrey Garen.

  • js/regress/script-tests/setter.js: Added.
  • js/regress/setter-expected.txt: Added.
  • js/regress/setter.html: Added.
12:26 PM Changeset in webkit [166944] by ggaren@apple.com
  • 1 edit
    1 delete in trunk/Source/bmalloc

2014-04-08 Geoffrey Garen <​ggaren@apple.com>

Removed an unused file.

Unreviewed.

  • bmalloc/AsyncTask.cpp: Removed.
12:12 PM Changeset in webkit [166943] by mark.lam@apple.com
  • 3 edits in trunk/Source/WebCore

Refactor to make JSMainThreadExecState's constructor and destructor private.
<​https://webkit.org/b/131372>

Reviewed by Mark Hahnenberg.

This is in preparation for subsequent patches to ensure that we don't
exit the VM with an exception still pending.

No new tests required. This is only a refactor of existing behavior.

  • bindings/js/JSDOMGlobalObjectTask.cpp:
  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::runTask):

12:07 PM Changeset in webkit [166942] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Clean up old protocol JSON files to better match the latest
​https://bugs.webkit.org/show_bug.cgi?id=131308

Reviewed by Joseph Pecoraro.

  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
12:00 PM Changeset in webkit [166941] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2 View Gestures (Swipe): Swipe-start hysteresis
​https://bugs.webkit.org/show_bug.cgi?id=127393
<rdar://problem/15876822>

Reviewed by Anders Carlsson.

We shouldn't start a swipe immediately upon very small scrolls in the correct direction,
because we don't want to get the user trapped in a swipe when they want to scroll.

We'll accumulate the scroll deltas and wait until the user has scrolled at least 15px horizontally.
In addition, we'll drop the swipe completely if any event has a vertical delta equal to half (or more)
of the horizontal delta.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::deltaIsSufficientToBeginSwipe):
(WebKit::ViewGestureController::handleScrollWheelEvent):
(WebKit::ViewGestureController::wheelEventWasNotHandledByWebCore):

11:26 AM Changeset in webkit [166940] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac][WK2] Videos do not have access to session cookies
​https://bugs.webkit.org/show_bug.cgi?id=129687

Reviewed by Eric Carlson.

Update the CookieStorageShim to track changes in underlying networking stack.

  • Shared/mac/CookieStorageShim.mm:

(WebKit::CookieStorageShim::initialize):
(-[WKNSURLSessionLocal _getCookieHeadersForTask:completionHandler:]):

11:22 AM Changeset in webkit [166939] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[WK2][iOS] Consecutive videos in full screen display only black
​https://bugs.webkit.org/show_bug.cgi?id=131316

Reviewed by Eric Carlson.

Update the MediaPlayer's full screen attributes whenever the underlying engine changes,
not just when the engine is initially created. Also, clear the videoLayer out of the
fullscreen layer when destroying the videoLayer.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer):

11:19 AM Changeset in webkit [166938] by commit-queue@webkit.org
  • 7 edits
    6 adds in trunk

[New Multicolumn] Child top margin sometimes ignored for column balancing
​https://bugs.webkit.org/show_bug.cgi?id=122754

Patch by Morten Stenshorne <​mstensho@opera.com> on 2014-04-08
Reviewed by David Hyatt.

Source/WebCore:

We need to set zero page logical height in LayoutState when column
height is unknown (when the columns haven't yet been
balanced). There's code that assumes that non-zero page height means
that page height is known. Lying about this makes the pagination code
believe that every top margin is adjacent to a column break, which
makes it eat and ignore all top margins.

This should be cleaned up, but it's easier to wait until the old
multicol code has been removed.

Tests: fast/multicol/break-in-scrollable.html

fast/multicol/newmulticol/leading-and-trailing-margin.html
fast/multicol/newmulticol/leading-margin.html

  • rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):

  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::isPageLogicalHeightKnown):

  • rendering/RenderMultiColumnFlowThread.h:

LayoutTests:

  • fast/multicol/break-in-scrollable-expected.html: Added.
  • fast/multicol/break-in-scrollable.html: Added.
  • fast/multicol/newmulticol/leading-and-trailing-margin-expected.html: Added.
  • fast/multicol/newmulticol/leading-and-trailing-margin.html: Added.
  • fast/multicol/newmulticol/leading-margin-expected.html: Added.
  • fast/multicol/newmulticol/leading-margin.html: Added.
11:06 AM Changeset in webkit [166937] by dino@apple.com
  • 6 edits in trunk/Source/WebCore

Allow elements to register for changes in page scale
​https://bugs.webkit.org/show_bug.cgi?id=131319

Reviewed by Eric Carlson.

Some parts of WebCore need to react to changes in the page
scale factor, such as resizing when the user zooms. A followup
patch will enable this for media controls - this simply lays
the groundwork.

At the moment we only allow HTMLMediaElements to register, but if
necessary this could be expanded in the future.

  • dom/Document.cpp: New methods to keep a list of HTMLMediaElements that

are interested in updates.
(WebCore::Document::registerForPageScaleFactorChangedCallbacks):
(WebCore::Document::unregisterForPageScaleFactorChangedCallbacks):
(WebCore::Document::pageScaleFactorChanged):

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::registerWithDocument): Add ourselves to the
the document's pageScale callback.
(WebCore::HTMLMediaElement::unregisterWithDocument): Remove ourselves from the
the document's pageScale callback.
(WebCore::HTMLMediaElement::setMediaControlsDependOnPageScaleFactor): Add/remove ourselves to/from
the callback if necessary.
(WebCore::HTMLMediaElement::pageScaleFactorChanged): The callback function. Empty for now.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::mediaControlsDependOnPageScaleFactor): Accessor.

  • page/Page.cpp:

(WebCore::Page::setPageScaleFactor): Tell all documents that the user has zoomed.

11:04 AM Changeset in webkit [166936] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add a way to tell whether a WKWebProcessPlugInNodeHandle is a text-type HTML input element
​https://bugs.webkit.org/show_bug.cgi?id=131374

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(-[WKWebProcessPlugInNodeHandle isTextField]): Added this getter. Calls
InjectedBundleNodeHandle::isTextField.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::isTextField): Added. Uses
WebCore::HTMLInputElement::isText, which is consistent with what
WebChromeClient::focusedElementChanged uses to decide whether to call didFocusTextField.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
10:45 AM Changeset in webkit [166935] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add a _certificateChain property to WKWebProcessPlugInFrame
​https://bugs.webkit.org/show_bug.cgi?id=131370

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame _certificateChain]): Added this getter, which uses the new
WebFrame::certificateInfo.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::certificateInfo): Added this getter.

  • WebProcess/WebPage/WebFrame.h:
10:36 AM Changeset in webkit [166934] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add a bundle form delegate method corresponding to textDidChangeInTextField
​https://bugs.webkit.org/show_bug.cgi?id=131369

Reviewed by Anders Carlsson.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Declared

new delegate method.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]): Added an override
of API::InjectedBundle::FormClient::textDidChangeInTextField which calls the new delegate
method.

10:17 AM Changeset in webkit [166933] by mitz@apple.com
  • 11 edits
    2 adds in trunk/Source

../WebKit/mac: WebKit part of [Cocoa] Add WKFormDelegate
​https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

  • MigrateHeaders.make: Added new WebKit2 headers to WEBKIT2_HEADERS.

../WebKit2: [Cocoa] Add WKFormDelegate
​https://bugs.webkit.org/show_bug.cgi?id=131343

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _formDelegate]): Added this accessor.
(-[WKWebView _setFormDelegate:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared _formDelegate property.
  • UIProcess/API/Cocoa/_WKFormDelegate.h: Added.
  • UIProcess/API/Cocoa/_WKFormInputSession.h: Added.
  • UIProcess/ios/WKContentView.h: Moved _webView ivar into the @interface…
  • UIProcess/ios/WKContentView.mm: …from the @implementation.
  • UIProcess/ios/WKContentViewInteraction.h: Added _formInputSession ivar and

formAccessoryView property.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession initWithContentView:userObject:]): Added.
(-[WKFormInputSession dealloc]): Added.
(-[WKFormInputSession userObject]): Added.
(-[WKFormInputSession isValid]): Added.
(-[WKFormInputSession accessoryViewCustomButtonTitle]): Added.
(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]): Added.
(-[WKFormInputSession invalidate]): Added.
(-[WKContentView cleanupInteraction]): Invalidate and release the input session.
(-[WKContentView formAccessoryView]): Added this accessor.
(-[WKContentView _startAssistingNode:userObject:]): Create an input session and message the
form delegate.
(-[WKContentView _stopAssistingNode]): Invalidate and release the input session.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Added

comment.

9:47 AM Changeset in webkit [166932] by Brent Fulgham
  • 2 edits in trunk/Tools

Unreviewed gardening: Prevent users from attempting
to build with known invalid cURL.

  • Scripts/webkitdirs.pm:

(checkInstalledTools): Block build attempts with bad
Cygwin tool set.

9:40 AM Changeset in webkit [166931] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Compile error in TextureMapper.h
​https://bugs.webkit.org/show_bug.cgi?id=131360

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2014-04-08
Reviewed by Brent Fulgham.

The TextureMapper class has pure virtual methods, and cannot be instantiated.

  • platform/graphics/texmap/TextureMapper.h:

(WebCore::TextureMapper::platformCreateAccelerated):

9:26 AM Changeset in webkit [166930] by Brent Fulgham
  • 3 edits
    97 moves
    12 adds in trunk/LayoutTests

[WebVTT] Begin Enabling W3C VTT Tests
​https://bugs.webkit.org/show_bug.cgi?id=131345

Reviewed by Darin Adler.

Move a number of tests out of 'opera' into a new 'w3c' folder.

  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt: Removed.
  • media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html: Removed.
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/addCue.html: Removed.
  • media/track/opera/interfaces/TextTrack/constants-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/constants.html: Removed.
  • media/track/opera/interfaces/TextTrack/cues-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/cues.html: Removed.
  • media/track/opera/interfaces/TextTrack/kind-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/kind.html: Removed.
  • media/track/opera/interfaces/TextTrack/label-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/label.html: Removed.
  • media/track/opera/interfaces/TextTrack/language-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/language.html: Removed.
  • media/track/opera/interfaces/TextTrack/mode-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/mode.html: Removed.
  • media/track/opera/interfaces/TextTrack/oncuechange-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/oncuechange.html: Removed.
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrack/removeCue.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/align.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/endTime.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/id.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/startTime.html: Removed.
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCue/track.html: Removed.
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCueList/getCueById.html: Removed.
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackCueList/length.html: Removed.
  • media/track/opera/interfaces/TextTrackList/length-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/length.html: Removed.
  • media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/onaddtrack.html: Removed.
  • media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Removed.
  • media/track/opera/interfaces/TextTrackList/onremovetrack.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/2_tracks.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_end.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/align_start.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/basic-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/basic.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/background.gif: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.mp4: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/media/white.webm: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/size_50.html: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt: Removed.
  • media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js: Removed.
  • media/track/w3c: Added.
  • media/track/w3c/interfaces: Added.
  • media/track/w3c/interfaces/HTMLMediaElement: Added.
  • media/track/w3c/interfaces/HTMLMediaElement/addTextTrack-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack-expected.txt.
  • media/track/w3c/interfaces/HTMLMediaElement/addTextTrack.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/addTextTrack.html.
  • media/track/w3c/interfaces/HTMLMediaElement/textTracks-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks-expected.txt.
  • media/track/w3c/interfaces/HTMLMediaElement/textTracks.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLMediaElement/textTracks.html.
  • media/track/w3c/interfaces/HTMLTrackElement: Added.
  • media/track/w3c/interfaces/HTMLTrackElement/default-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/default.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/default.html.
  • media/track/w3c/interfaces/HTMLTrackElement/label-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/label.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/label.html.
  • media/track/w3c/interfaces/HTMLTrackElement/readyState-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/readyState.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/readyState.html.
  • media/track/w3c/interfaces/HTMLTrackElement/srclang-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/srclang.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/srclang.html.
  • media/track/w3c/interfaces/HTMLTrackElement/track-expected.txt: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track-expected.txt.
  • media/track/w3c/interfaces/HTMLTrackElement/track.html: Copied from media/track/opera/interfaces/HTMLElement/HTMLTrackElement/track.html.
  • media/track/w3c/interfaces/TextTrack: Added.
  • media/track/w3c/interfaces/TextTrack/addCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/addCue-expected.txt.
  • media/track/w3c/interfaces/TextTrack/addCue.html: Copied from media/track/opera/interfaces/TextTrack/addCue.html.
  • media/track/w3c/interfaces/TextTrack/constants-expected.txt: Copied from media/track/opera/interfaces/TextTrack/constants-expected.txt.
  • media/track/w3c/interfaces/TextTrack/constants.html: Copied from media/track/opera/interfaces/TextTrack/constants.html.
  • media/track/w3c/interfaces/TextTrack/cues-expected.txt: Copied from media/track/opera/interfaces/TextTrack/cues-expected.txt.
  • media/track/w3c/interfaces/TextTrack/cues.html: Copied from media/track/opera/interfaces/TextTrack/cues.html.
  • media/track/w3c/interfaces/TextTrack/kind-expected.txt: Copied from media/track/opera/interfaces/TextTrack/kind-expected.txt.
  • media/track/w3c/interfaces/TextTrack/kind.html: Copied from media/track/opera/interfaces/TextTrack/kind.html.
  • media/track/w3c/interfaces/TextTrack/label-expected.txt: Copied from media/track/opera/interfaces/TextTrack/label-expected.txt.
  • media/track/w3c/interfaces/TextTrack/label.html: Copied from media/track/opera/interfaces/TextTrack/label.html.
  • media/track/w3c/interfaces/TextTrack/language-expected.txt: Copied from media/track/opera/interfaces/TextTrack/language-expected.txt.
  • media/track/w3c/interfaces/TextTrack/language.html: Copied from media/track/opera/interfaces/TextTrack/language.html.
  • media/track/w3c/interfaces/TextTrack/mode-expected.txt: Copied from media/track/opera/interfaces/TextTrack/mode-expected.txt.
  • media/track/w3c/interfaces/TextTrack/mode.html: Copied from media/track/opera/interfaces/TextTrack/mode.html.
  • media/track/w3c/interfaces/TextTrack/oncuechange-expected.txt: Copied from media/track/opera/interfaces/TextTrack/oncuechange-expected.txt.
  • media/track/w3c/interfaces/TextTrack/oncuechange.html: Copied from media/track/opera/interfaces/TextTrack/oncuechange.html.
  • media/track/w3c/interfaces/TextTrack/removeCue-expected.txt: Copied from media/track/opera/interfaces/TextTrack/removeCue-expected.txt.
  • media/track/w3c/interfaces/TextTrack/removeCue.html: Copied from media/track/opera/interfaces/TextTrack/removeCue.html.
  • media/track/w3c/interfaces/TextTrackCue: Added.
  • media/track/w3c/interfaces/TextTrackCue/align-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/align-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/align.html: Copied from media/track/opera/interfaces/TextTrackCue/align.html.
  • media/track/w3c/interfaces/TextTrackCue/endTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/endTime-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/endTime.html: Copied from media/track/opera/interfaces/TextTrackCue/endTime.html.
  • media/track/w3c/interfaces/TextTrackCue/id-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/id-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/id.html: Copied from media/track/opera/interfaces/TextTrackCue/id.html.
  • media/track/w3c/interfaces/TextTrackCue/pauseOnExit-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html: Copied from media/track/opera/interfaces/TextTrackCue/pauseOnExit.html.
  • media/track/w3c/interfaces/TextTrackCue/startTime-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/startTime-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/startTime.html: Copied from media/track/opera/interfaces/TextTrackCue/startTime.html.
  • media/track/w3c/interfaces/TextTrackCue/track-expected.txt: Copied from media/track/opera/interfaces/TextTrackCue/track-expected.txt.
  • media/track/w3c/interfaces/TextTrackCue/track.html: Copied from media/track/opera/interfaces/TextTrackCue/track.html.
  • media/track/w3c/interfaces/TextTrackCueList: Added.
  • media/track/w3c/interfaces/TextTrackCueList/getCueById-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt.
  • media/track/w3c/interfaces/TextTrackCueList/getCueById.html: Copied from media/track/opera/interfaces/TextTrackCueList/getCueById.html.
  • media/track/w3c/interfaces/TextTrackCueList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackCueList/length-expected.txt.
  • media/track/w3c/interfaces/TextTrackCueList/length.html: Copied from media/track/opera/interfaces/TextTrackCueList/length.html.
  • media/track/w3c/interfaces/TextTrackList: Added.
  • media/track/w3c/interfaces/TextTrackList/length-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/length-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/length.html: Copied from media/track/opera/interfaces/TextTrackList/length.html.
  • media/track/w3c/interfaces/TextTrackList/onaddtrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/onaddtrack.html: Copied from media/track/opera/interfaces/TextTrackList/onaddtrack.html.
  • media/track/w3c/interfaces/TextTrackList/onremovetrack-expected.txt: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt.
  • media/track/w3c/interfaces/TextTrackList/onremovetrack.html: Copied from media/track/opera/interfaces/TextTrackList/onremovetrack.html.
  • media/track/w3c/track: Added.
  • media/track/w3c/track/webvtt: Added.
  • media/track/w3c/track/webvtt/2_tracks-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks-ref.html.
  • media/track/w3c/track/webvtt/2_tracks.html: Copied from media/track/opera/track/webvtt/rendering/reftest/2_tracks.html.
  • media/track/w3c/track/webvtt/align_end-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end-ref.html.
  • media/track/w3c/track/webvtt/align_end.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_end.html.
  • media/track/w3c/track/webvtt/align_middle-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle-ref.html.
  • media/track/w3c/track/webvtt/align_middle.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle.html.
  • media/track/w3c/track/webvtt/align_middle_position_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_gt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_gt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_gt_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size-ref.html.
  • media/track/w3c/track/webvtt/align_middle_position_lt_50_size_gt_maximum_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_middle_position_lt_50_size_gt_maximum_size.html.
  • media/track/w3c/track/webvtt/align_start-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start-ref.html.
  • media/track/w3c/track/webvtt/align_start.html: Copied from media/track/opera/track/webvtt/rendering/reftest/align_start.html.
  • media/track/w3c/track/webvtt/audio_has_no_subtitles-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles-ref.html.
  • media/track/w3c/track/webvtt/audio_has_no_subtitles.html: Copied from media/track/opera/track/webvtt/rendering/reftest/audio_has_no_subtitles.html.
  • media/track/w3c/track/webvtt/background.gif: Copied from media/track/opera/track/webvtt/rendering/reftest/media/background.gif.
  • media/track/w3c/track/webvtt/basic-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic-ref.html.
  • media/track/w3c/track/webvtt/basic.html: Copied from media/track/opera/track/webvtt/rendering/reftest/basic.html.
  • media/track/w3c/track/webvtt/decode_escaped_entities-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities-ref.html.
  • media/track/w3c/track/webvtt/decode_escaped_entities.html: Copied from media/track/opera/track/webvtt/rendering/reftest/decode_escaped_entities.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_align_position_line_size_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_align_position_line_size_while_paused.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_cue_text_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_cue_text_while_paused.html.
  • media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused-ref.html.
  • media/track/w3c/track/webvtt/dom_override_remove_cue_while_paused.html: Copied from media/track/opera/track/webvtt/rendering/reftest/dom_override_remove_cue_while_paused.html.
  • media/track/w3c/track/webvtt/media: Added.
  • media/track/w3c/track/webvtt/media/white.mp4: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.mp4.
  • media/track/w3c/track/webvtt/media/white.webm: Copied from media/track/opera/track/webvtt/rendering/reftest/media/white.webm.
  • media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue-ref.html.
  • media/track/w3c/track/webvtt/one_line_cue_plus_wrapped_cue.html: Copied from media/track/opera/track/webvtt/rendering/reftest/one_line_cue_plus_wrapped_cue.html.
  • media/track/w3c/track/webvtt/size_50-expected.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50-ref.html.
  • media/track/w3c/track/webvtt/size_50.html: Copied from media/track/opera/track/webvtt/rendering/reftest/size_50.html.
  • media/track/w3c/track/webvtt/support: Added.
  • media/track/w3c/track/webvtt/support/2_cues_overlapping_completely_move_up.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/2_cues_overlapping_completely_move_up.vtt.
  • media/track/w3c/track/webvtt/support/align_end_long.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/align_end_long.vtt.
  • media/track/w3c/track/webvtt/support/foo.vtt: Copied from media/track/opera/track/webvtt/rendering/reftest/support/foo.vtt.
  • media/track/w3c/track/webvtt/support/refTestWait.js: Copied from media/track/opera/track/webvtt/rendering/reftest/support/refTestWait.js.
    • platform/eft/TestExpectations: Skip w3c tests.
    • platform/gtk/TestExpectations: Skip w3c tests.
9:19 AM Changeset in webkit [166929] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Subpixel rendering: Slow paint path for inlines should snap to device pixels.
​https://bugs.webkit.org/show_bug.cgi?id=131259

Reviewed by Simon Fraser.

InlineTextBox::paint needs to round to the same device pixel position as SimpleLineLayout does.

Source/WebCore:

Test: fast/inline/hidpi-slow-path-text-on-subpixel-position.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

  • rendering/TextPainter.h: Cleanup. No reason to have them as references here.

LayoutTests:

  • fast/inline/hidpi-slow-path-text-on-subpixel-position-expected.html: Added.
  • fast/inline/hidpi-slow-path-text-on-subpixel-position.html: Added.
9:09 AM Changeset in webkit [166928] by dbates@webkit.org
  • 4 edits in trunk/Source

Fallback to default storage session when there isn't a valid session ID
​https://bugs.webkit.org/show_bug.cgi?id=131326
<rdar://problem/16231679>

Reviewed by Alexey Proskuryakov.

Fixes and issue where we may use the wrong storage session after disabling
a private browsing session.

Currently WebKit1 and WebKit2 without NetworkProcess assume that there
is always a non-null private browsing storage session so long as the page
has a non-default session ID. Instead we should only use the private browsing
storage session when it's non-null and the page has a non-default session ID;
otherwise, we should use the default storage session. This change will make
the behavior in WebKit1 and WebKit2 without NetworkProcess consistent with
the behavior in WebKit2 with NetworkProcess.

Source/WebKit/mac:

  • WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::storageSession):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::storageSession):

9:01 AM Changeset in webkit [166927] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Keep 'webkitClosedCaptionsVisible' API in sync with captions display preferences
​https://bugs.webkit.org/show_bug.cgi?id=131344

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup) If we decide that captions should
be active (due to user preferences) make sure the 'webkitClosedCaptionsVisible' state
is turned on.

7:52 AM Changeset in webkit [166926] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Paint the filter effect result image on device pixel position.
​https://bugs.webkit.org/show_bug.cgi?id=131255

Reviewed by Simon Fraser.

This patch moves filter effect images from integral to device pixel position. However,
result images are still integral based.

Source/WebCore:

Test: css3/filters/hidpi-filter-is-on-subpixel-position.html

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

LayoutTests:

  • css3/filters/hidpi-filter-is-on-subpixel-position-expected.html: Added.
  • css3/filters/hidpi-filter-is-on-subpixel-position.html: Added.
7:50 AM Changeset in webkit [166925] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Make border images device pixel aware.
​https://bugs.webkit.org/show_bug.cgi?id=131209

Reviewed by Simon Fraser.

Snap border-image size and position to device pixels. It works both on generated and bitmap images.

Source/WebCore:

Test: fast/borders/hidpi-border-image-gradient-on-subpixels.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintNinePieceImage):

LayoutTests:

  • fast/borders/hidpi-border-image-gradient-on-subpixels-expected.html: Added.
  • fast/borders/hidpi-border-image-gradient-on-subpixels.html: Added.
5:21 AM WebKitGTK/KeepingTheTreeGreen edited by Andres Gomez
Added tanty shifts (diff)
5:09 AM Changeset in webkit [166924] by commit-queue@webkit.org
  • 9 edits in trunk

[SOUP] Control cookie management according ResourceRequest.allowCookies()
​https://bugs.webkit.org/show_bug.cgi?id=131026

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-04-08
Reviewed by Sergio Villar Senin.

Source/WebCore:

Added per soup-message disabling of cookie jar manager when related ResourceRequest does not allow cookies (e.g. some cross-origin requests).

Patch is covered by unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageMembers): Added disabling of cookie jar manager if cookies are not allowed.

Source/WebKit2:

Added setting of accept cookies policy for the current soup network session cookie jar and all tracked sessions.
Moved the implementation of cookie policy setting from WebCookieManager to WebFrameNetworkingContext.

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy): Moved implementation to WebCookieManager::platformSetHTTPCookieAcceptPolicy.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Moved implementation from WebCookieManager::platformSetHTTPCookieAcceptPolicy and set the cookie jar accept policy to the cookie jars of all sessions in addition to the default cookie jar.

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h: Added method prototype.

LayoutTests:

  • platform/efl/TestExpectations: Unskipped test http/tests/xmlhttprequest/cross-origin-cookie-storage.html.
  • platform/gtk/TestExpectations: Ditto.
5:05 AM Changeset in webkit [166923] by svillar@igalia.com
  • 3 edits
    4 adds in trunk

[CSS Grid Layout] Handle min/max height in the grid element
​https://bugs.webkit.org/show_bug.cgi?id=131302

Reviewed by Darin Adler.

Source/WebCore:

Removed a FIXME in the code as we're already handling min/max
height in the code. Added a couple of test cases to improve the
test coverage.

Merged from Blink r161876 by <​jchaffraix@chromium.org>

Tests: fast/css-grid-layout/flex-content-sized-columns-resize.html

fast/css-grid-layout/grid-element-min-max-height.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutGridItems):

LayoutTests:

Added test coverage for min/max height handling in the grid
item. Also added other test to cover a blind spot in our testing,
resizing of content sized columns with flexible breadths.

Merged from Blink r161876 by <​jchaffraix@chromium.org> and r166914 by <Manuel Rego Casasnovas>.

  • fast/css-grid-layout/flex-content-sized-columns-resize-expected.html: Added.
  • fast/css-grid-layout/flex-content-sized-columns-resize.html: Added.
  • fast/css-grid-layout/grid-element-min-max-height-expected.txt: Added.
  • fast/css-grid-layout/grid-element-min-max-height.html: Added.
3:58 AM WebKitGTK/KeepingTheTreeGreen edited by eocanha@igalia.com
(diff)
2:21 AM Changeset in webkit [166922] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] Remove unused RenderBox::clearRenderBoxRegionInfo
​https://bugs.webkit.org/show_bug.cgi?id=131352

Reviewed by Andrei Bucur.

No new tests, code clean-up.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearRenderBoxRegionInfo): Deleted.

  • rendering/RenderBox.h:
2:15 AM Changeset in webkit [166921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Buildfix after r166917
​https://bugs.webkit.org/show_bug.cgi?id=131351

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-04-08
Reviewed by Andrei Bucur.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

1:58 AM Changeset in webkit [166920] by Darin Adler
  • 13 edits in trunk/Source/WebCore

Fix assertions triggered by CSS calc changes in r166860
​https://bugs.webkit.org/show_bug.cgi?id=131346

Reviewed by Andrei Bucur.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusCornerValues): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::lineHeightFromStyle): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyBorderRadius::applyValue): Use isNegative and isZero rather
than calling value() unconditionally. Should make calculated values work better.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::is100Percent): Use isPercentNotCalculated() before code
that calls percent(), which won't work for a calculated length.

  • platform/Length.cpp:

(WebCore::CalculationValueMap::deref): Use adoptRef here instead of calling deref
immediately, so the deref will happen after calling remove. This makes the code
work properly even if it's reentered inside the calculation value's destructor.

  • platform/Length.h:

(WebCore::Length::percent): Change assert to isPercentNotCalculated, since the
value function this calls only works for non-calculated values anyway.
(WebCore::Length::isPercentNotCalculated): Added.
(WebCore::Length::isPercent): Changed to call isPercentNotCalculated.
(WebCore::Length::isSpecified): Changed to call isPercent.

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::apply): Use isPercentNotCalculated()
instead of type() == Percent; no behavior change.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Use isPercentNotCalculated()
before code that calls value() or percent(), which won't work for a calculated length.
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths): Ditto.
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth): Ditto.
(WebCore::AutoTableLayout::layout): Ditto.

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout): Ditto.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions): Ditto.

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows): Ditto.
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows): Ditto.

  • rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin): Use modern for loop. Also marked function static,
since it's private to this file.
(WebCore::RenderStyle::applyTransform): Use isPercentNotCalculated() instead of
type() == Percent; no behavior change. Also use a modern for loop and auto& to avoid
a really long type name.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation): Use isPercentNotCalculated()
before code that calls percent(), which won't work for a calculated length.

  • platform/Length.h:

(WebCore::Length::percent):
(WebCore::Length::isPercentNotCalculated):
(WebCore::Length::isPercent):
(WebCore::Length::isSpecified):

  • platform/graphics/transforms/TranslateTransformOperation.h:

(WebCore::TranslateTransformOperation::apply):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::layout):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateImageIntrinsicDimensions):

  • rendering/RenderTableSection.cpp:

(WebCore::updateLogicalHeightForCell):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToRows):

  • rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin):
(WebCore::RenderStyle::applyTransform):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):

1:15 AM Changeset in webkit [166919] by calvaris@igalia.com
  • 2 edits
    1 delete in trunk/Source/WebCore

[GTK] Remove media controls dead code
​https://bugs.webkit.org/show_bug.cgi?id=131300

Reviewed by Eric Carlson.

MediaControlsGtk.cpp is no longer used so we can remove it from
the repo.

No new tests needed.

  • PlatformGTK.cmake: Remove html/shadow/MediaControlsGtk.cpp from

compilation.

  • html/shadow/MediaControlsGtk.cpp: Removed.
1:13 AM Changeset in webkit [166918] by mihnea@adobe.com
  • 3 edits
    2 adds in trunk

[CSSRegions] Fixed positioned elements in named flows have fragmented content
​https://bugs.webkit.org/show_bug.cgi?id=130595

Reviewed by Darin Adler.

Source/WebCore:

Fixed positioned elements that have the named flow as parent are positioned
and sized relative to the viewport. Because of that, when the named flow
has an associated region chain, the fixed positioned elements should not
be fragmented.

By making a fixed positioned element with a named flow parent unsplittable
for fragmentation, we prevent this wrong behavior.

Test: fast/regions/fixed-pos-content-fragmented.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):

LayoutTests:

  • fast/regions/fixed-pos-content-fragmented-expected.html: Added.
  • fast/regions/fixed-pos-content-fragmented.html: Added.
1:05 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
12:59 AM Changeset in webkit [166917] by Chris Fleizach
  • 3 edits
    2 adds in trunk

Regression: AX: image labels no longer exposed to AX API in SVG test case
​https://bugs.webkit.org/show_bug.cgi?id=131208

Reviewed by Daniel Bates.

Source/WebCore:

accessibleNameForNode should work on any Element, not just HTML elements.

Test: accessibility/svg-labelledby.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

LayoutTests:

  • accessibility/svg-labelledby-expected.txt: Added.
  • accessibility/svg-labelledby.html: Added.
12:37 AM Changeset in webkit [166916] by Andres Gomez
  • 8 edits in trunk/Source

[GTK] [EFL] Build fails with GCC < 4.8.x
​https://bugs.webkit.org/show_bug.cgi?id=130585

Reviewed by Martin Robinson.

The behavior in lower versions of GCC seem to be related to
​http://www.open-std.org/jtc1/sc22/wg21/docs/lwg-active.html#2132.

Provided explicit casts for the failing ambiguous overloads.

Source/WebCore:

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcChangeState):
(webKitMediaVideoSrcNeedDataCb):
(webKitMediaAudioSrcNeedDataCb):
(webKitMediaVideoSrcEnoughDataCb):
(webKitMediaAudioSrcEnoughDataCb):
(webKitMediaVideoSrcSeekDataCb):
(webKitMediaAudioSrcSeekDataCb):

  • platform/gtk/GtkDragAndDropHelper.cpp:

(WebCore::GtkDragAndDropHelper::handleDragLeave):

  • platform/gtk/SharedTimerGtk.cpp:

(WebCore::setSharedTimerFireInterval):

Source/WTF:

  • wtf/gtk/MainThreadGtk.cpp:

(WTF::scheduleDispatchFunctionsOnMainThread):

  • wtf/gtk/RunLoopGtk.cpp:

(WTF::RunLoop::wakeUp): Provided lambda with a RefPtr instead of
ref and de-referring.

12:14 AM Changeset in webkit [166915] by gyuyoung.kim@samsung.com
  • 9 edits in trunk/Source

Change NavigatorContentUtils client ownership from port side to NavigatorContentUtils
​https://bugs.webkit.org/show_bug.cgi?id=131299

Reviewed by Darin Adler.

EFL and GTK ports have managed own client of NavigatorContentUtils though it is only passed to
NavigatorContentUtils. The NavigatorContentUtils has used the client to call port functions. So,
there is no reason port implementation needs to manage the ownership. To manage the client is
unnecessary work in current implementation.

Source/WebCore:

No new tests, no behavior changes.

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::NavigatorContentUtils::create):
(WebCore::provideNavigatorContentUtilsTo):

  • Modules/navigatorcontentutils/NavigatorContentUtils.h:
  • Modules/navigatorcontentutils/NavigatorContentUtilsClient.h:

Source/WebKit/efl:

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

  • webkit/webkitwebviewprivate.h:
Note: See TracTimeline for information about the timeline view.