Timeline



Jun 2, 2014:

11:51 PM Changeset in webkit [169558] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Add a verbose flag to binding tests
​https://bugs.webkit.org/show_bug.cgi?id=122303

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-06-02
Reviewed by Csaba Osztrogonác.

This patch will:

  • Add a verbose keyword argument to the BindingsTests constructor,
  • Add --no-verbose option to the run-bindigs-test.

Verbose mode, which is on by default, prints positive results to stdout as before.
When the --no-verbose option added to run-bindings-tests, positive results are not printed at all.

Original patch from Matthew Hanson <​matthew_hanson@apple.com>

  • Scripts/run-bindings-tests:

(main):

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.init):
(BindingsTests.detect_changes):

10:47 PM Changeset in webkit [169557] by jinwoo7.song@samsung.com
  • 11 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaseline after r169522.

  • platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
  • platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
  • svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
9:59 PM Changeset in webkit [169556] by jinwoo7.song@samsung.com
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaseline.

  • platform/efl/mathml/opentype/large-operators-LatinModern-expected.txt:
  • platform/efl/mathml/opentype/opentype-stretchy-expected.txt:
  • platform/efl/mathml/opentype/vertical-LatinModern-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
7:04 PM Changeset in webkit [169555] by jinwoo7.song@samsung.com
  • 1 edit
    1 move in trunk/LayoutTests

Unreviewed EFL gardening.

Move the EFL specific test result to platform directory.

  • platform/efl/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Renamed from LayoutTests/fast/events/ghostly-mousemoves-in-subframe-expected.txt.
6:59 PM Changeset in webkit [169554] by jinwoo7.song@samsung.com
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Added expectation result after r167684, r169257, and r169390.

  • fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
  • platform/efl/fast/box-shadow/hidpi-webkit-box-shadow-subpixel-position-expected.txt: Added.
  • platform/efl/fast/multicol/pagination/nested-transforms-expected.txt: Added.
6:26 PM Changeset in webkit [169553] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (iOS WebKit2): Single tap in pages with focus on load will clear the selection after the keyboard appears.
​https://bugs.webkit.org/show_bug.cgi?id=133465
<rdar://problem/17059189>

Reviewed by Benjamin Poulain.

If a page focuses an input field on load we don't bring the keyboard on screen
since the keyboard is only shown when the user interacts with the page with gestures.
Still the WebProcess sets the focus and the selection according to the rules.
We need to make sure the UI process doesn't accidentally clear this selection
when the user starts the interaction with the page.
This patch also improves the function that retrieves the autocorrection data
to be returned to the keyboard, making sure that we always send back a reply
even when we don't have a valid selection.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _singleTapCommited:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::requestAutocorrectionData):

6:15 PM Changeset in webkit [169552] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitLibraries

Error running copy-webkitlibraries-to-product-directory
<​http://webkit.org/b/133449>
<rdar://problem/17047638>

Reviewed by Filip Pizlo.

  • Makefile: Ignore the mysterious future. Use "@true" to

suppress the annoying "Nothing to be done for `libs'." message.

5:37 PM Changeset in webkit [169551] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] WebCore fails to build: platform/network/mac/ResourceHandleMac.mm:729:62: error: use of undeclared identifier '_CFURLConnectionCopyTimingData'
<​http://webkit.org/b/133445>
<rdar://problem/17090035>

Reviewed by Alexey Proskuryakov.

  • platform/network/mac/ResourceHandleMac.mm: Attempt to fix the

build by including a private header and local declaration.

4:44 PM Changeset in webkit [169550] by andersca@apple.com
  • 25 edits in trunk/Source

Change DeferrableOneShotTimer to use std::function instead of being a class template
​https://bugs.webkit.org/show_bug.cgi?id=133423

Reviewed by Antti Koivisto.

Source/WebCore:
Also, add a new constructor to DeferrableOneShotTimer that takes an std::function. Change the callback
to not pass a DeferrableOneShotTimer& anymore. Change the delay parameter to use std::chrono::milliseconds.

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):

  • css/CSSImageGeneratorValue.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):

  • html/HTMLPlugInImageElement.h:
  • loader/cache/CachedResource.cpp:

(WebCore::deadDecodedDataDeletionIntervalForResourceType):
(WebCore::CachedResource::destroyDecodedDataIfNeeded):
(WebCore::CachedResource::decodedDataDeletionTimerFired):

  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):

  • loader/cache/MemoryCache.h:

(WebCore::MemoryCache::setDeadDecodedDataDeletionInterval):
(WebCore::MemoryCache::deadDecodedDataDeletionInterval):

  • platform/Timer.h:

(WebCore::Timer::Timer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):

  • platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):

  • platform/graphics/cg/SubimageCacheWithTimer.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _setCacheModel:]):

Source/WebKit2:

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformSetCacheModel):

  • Shared/CacheModel.cpp:

(WebKit::calculateCacheSizes):

  • Shared/CacheModel.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformSetCacheModel):

3:18 PM Changeset in webkit [169549] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Round the UIScrollView content size to device pixel
​https://bugs.webkit.org/show_bug.cgi?id=133417
<rdar://problem/15922440>

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-06-02
Reviewed by Simon Fraser.

We should really have the scaled content size floored to device pixels, but that will be for another
time.
This patch ensure the content size as seen by the API is rounded to device pixels. The value is floored
to avoid showing partial pixels when the content is stable.

  • UIProcess/API/Cocoa/WKWebView.mm:

(floorFloatToPixels):
(roundScrollViewCountentSize):
(-[WKWebView _setHasCustomContentView:loadedMIMEType:WTF::]):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView scrollView:contentSizeForZoomScale:withProposedSize:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

3:13 PM Changeset in webkit [169548] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Move ifdef to the right place.

3:07 PM Changeset in webkit [169547] by benjamin@webkit.org
  • 8 edits
    2 adds in trunk

Make pseudo element matching for style resolution more JIT friendly
​https://bugs.webkit.org/show_bug.cgi?id=133441

Reviewed by Antti Koivisto.

Source/WebCore:
Sharing pseudo elements is a complicated mess shared between the SelectorChecker
and the RuleCollector.

For compiling pseudo element matching, it would be best if all the complexity could
be moved to compile time instead of runtime. It is also preferable to keep the compiler
independant of the RuleCollector implementation's detail.

This patch is a first step toward that goal. The main objective here is to make
"dynamicPseudo" completely internal to the SelectorChecker.
This is mostly a mechanical change, it is likely PseudoElement matching could be simplified
further but that is not attempted here.

Test: fast/css/style-sharing-empty-rule-modification.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):
The condition regarding pseudo element matching has been moved into SelectorChecker::match().

This creates an extra cost for querySelector(), but that should be fine since the vast majority
of selectors are JIT compiled and never use SelectorChecker in the first place.

(WebCore::ElementRuleCollector::collectMatchingRulesForList):
The loop is changed such that the tree marking (Style::setHasPseudoStyle) could be moved
to SelectorChecker.

The conditions about the security origin for getMatchedCSSRules() and the empty style rules
are moved prior to the call to ElementRuleCollector::ruleMatches(). This ensure we keep the same
behavior of not adding the pseudo style for empty rules (this could also help with tree marking
in general but empty rules are probably uncommon).

There is one behavior change from making this loop simpler: the SharingRules and StyleInvalidation
modes now update their ruleRange. It is useless but it is simpler.

  • css/ElementRuleCollector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively):
The tree marking has been moved here.

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::match):
The pseudo element matching has been moved here.

  • css/StyleResolver.h:

(WebCore::checkRegionSelector):

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):

LayoutTests:
Add more coverage for style sharing with empty rules, just in case.

  • fast/css/style-sharing-empty-rule-modification-expected.txt: Added.
  • fast/css/style-sharing-empty-rule-modification.html: Added.
2:54 PM Changeset in webkit [169546] by barraclough@apple.com
  • 3 edits in trunk/Source/WebKit2

Set default voucher for XPC client processes
​https://bugs.webkit.org/show_bug.cgi?id=133458

Reviewed by Geoff Garen.

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

  • add voucher_replace_default_voucher.
  • config.h:
    • add HAVE_VOUCHERS.
2:13 PM Changeset in webkit [169545] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Send external playback properties to fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=133366

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-06-02
Reviewed by Simon Fraser.

Source/WebCore:
Refactor property updates in WebVideoFullscreenModelMediaElement and update
setExternalPlayback on webkitcurrentplaybacktargetiswirelesschangedEvent.

  • WebCore.exp.in: Add export for setExternalPlayback.
  • platform/ios/WebVideoFullscreenInterface.h: add setExternalPlayback
  • platform/ios/WebVideoFullscreenInterfaceAVKit.h: add setExternalPlayback
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController isPlayingOnExternalScreen]): added
(+[WebAVPlayerController keyPathsForValuesAffectingPlayingOnExternalScreen]): added
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): added
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): added

  • platform/ios/WebVideoFullscreenModelMediaElement.h: add updateForEventName
  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

(WebVideoFullscreenModelMediaElement::setMediaElement): refactor property changes into updateForEventName()
(WebVideoFullscreenModelMediaElement::handleEvent): refactor property changes into updateForEventName()
(WebVideoFullscreenModelMediaElement::updateForEventName): remove duplicate code, implement for setExternalPlayback

Source/WebKit2:
Forward setExternalPlayback.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in: add setExternalPlaybackProperties
  • WebProcess/ios/WebVideoFullscreenManager.h: add setExternalPlaybackProperties
  • WebProcess/ios/WebVideoFullscreenManager.mm: add setExternalPlaybackProperties

(WebKit::WebVideoFullscreenManager::setExternalPlaybackProperties): added

1:53 PM Changeset in webkit [169544] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

WebCore build fix for webreplay
​https://bugs.webkit.org/show_bug.cgi?id=133401

Patch by Zsolt Borbely <​zsborbely.u-szeged@partner.samsung.com> on 2014-06-02
Reviewed by Darin Adler.

  • replay/MemoizedDOMResult.cpp:

(WebCore::MemoizedDOMResultBase::createFromEncodedResult):
Add a default nullptr return in order to avoid a gcc warning.
The warning is because of a non-void method that has a case which doesn't return.

  • replay/ReplayController.cpp:

(WebCore::ReplayController::setForceDeterministicSettings):
Guard the ScrollingCoordinator with the appropriate #ifdef.

  • replay/SerializationMethods.cpp:

Guard the KeypressCommand with COCOA as it is only present there.

1:42 PM Changeset in webkit [169543] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove unintentional changes to WKContentViewInteraction.mm
introduced in r169500.

Unreviewed.

  • UIProcess/ios/WKContentViewInteraction.mm:

(+[WKAutocorrectionContext autocorrectionContextWithData:markedText:selectedText:afterText:selectedRangeInMarkedText:]):

1:22 PM Changeset in webkit [169542] by ggaren@apple.com
  • 3 edits in trunk/Source/WebKit2

Address some review comments on bug 133408
​https://bugs.webkit.org/show_bug.cgi?id=133410

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKBackForwardListItem.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
1:08 PM Changeset in webkit [169541] by rniwa@webkit.org
  • 4 edits
    1 move in trunk

Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
​https://bugs.webkit.org/show_bug.cgi?id=133455

Reviewed by Timothy Hatcher.

PerformanceTests:

  • Speedometer/: Renamed from DoYouEvenBench.
  • Skipped: Updated the path for InteractiveRunner.html

Tools:
Since the perf. dashboard doesn't support following renamed benchmarks,
keep reporting Speedometer results as DoYouEvenBench results.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict):

12:57 PM Changeset in webkit [169540] by rniwa@webkit.org
  • 6 edits
    4 adds in trunk/PerformanceTests

Rename DoYouEvenBench 0.17 to Speedometer 1.0 and add a new look.
​https://bugs.webkit.org/show_bug.cgi?id=133455

Reviewed by Timothy Hatcher.

Renamed the benchmark to Speedometer and added the new look designed by Timothy Hatcher.

Also changed the unit of measurements from milliseconds to runs-per-minute averaged over the number
of the benchmark suites (7 for 1.0). You can divide 420000 by the old benchmark score (in milliseconds)
to get the new value for the set of tests that are enabled by default in 1.0. You can continue to see
results in milliseconds on Full.html#ms.

  • DoYouEvenBench/Full.html: Added a bunch of sections and the description of the benchmark.
  • DoYouEvenBench/resources/benchmark-report.js: Remove the newly added content when ran inside a DRT or

WTR so that run-perf-tests wouldn't error.

  • DoYouEvenBench/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._appendFrame): Call a newly added willAddTestFrame callback when it exists.

  • DoYouEvenBench/resources/gauge.png: Added.
  • DoYouEvenBench/resources/​gauge@2x.png: Added.
  • DoYouEvenBench/resources/logo.png: Added.
  • DoYouEvenBench/resources/​logo@2x.png: Added.
  • DoYouEvenBench/resources/main.css: Replaced the style.
  • DoYouEvenBench/resources/main.js:

(window.benchmarkClient.willAddTestFrame): Place the iframe right where #testContainer is shown.
(window.benchmarkClient.willRunTest): Show the name of the suite (e.g. EmberJS-TodoMVC) to run next.
(window.benchmarkClient.didRunSuites):
(window.benchmarkClient.willStartFirstIteration): Initialize _timeValues and _finishedTestCount now that
we have an UI to run the benchmark multiple times without reloading the page.
(window.benchmarkClient.didFinishLastIteration): Split into smaller pieces.
(window.benchmarkClient._computeResults): Computes the mean and the statistics for the given time values,
and also format them in a human readable form.
(window.benchmarkClient._computeResults.totalTimeInDisplayUnit): Converts ms to runs/min.
(window.benchmarkClient._computeResults.sigFigFromPercentDelta): Given a percentage error (e.g. 1%),
returns the number of significant digits required for the mean.
(window.benchmarkClient._computeResults.toSigFigPrecision): Calls toPrecision with the specified precision
constrained to be at least the number of non-decimal digits and at most 6.
(window.benchmarkClient._addDetailedResultsRow): Renamed from _addResult. It now takes the table to which
to add a row and the iteration number.
(window.benchmarkClient._updateGaugeNeedle): Added. Controls the angle of the speed indicator.
(window.benchmarkClient._populateDetailedResults): Added.
(window.benchmarkClient.prepareUI): Added. It adds an event listener to show a specified section when
the push state of the document changes, and shows a warning sign when the view port size is too small.
We do this inside a callback to avoid running it inside DRT / WTR.
(startBenchmark):
(showSection): Added.
(startTest): Added.
(showResultsSummary): Added.
(showResultDetails): Added.
(showAbout): Added.

12:57 PM Changeset in webkit [169539] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Further unreviewed GTK build fix after r169536.

Update the m_duration contructor in MediaSourceGStreamer.

  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::MediaSourceGStreamer):

12:50 PM Changeset in webkit [169538] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] -[WKWebView activeURL] is unused
​https://bugs.webkit.org/show_bug.cgi?id=133440

Reviewed by Mark Rowe.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView activeURL]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed the property declaration.
12:42 PM Changeset in webkit [169537] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r169536.

Update MediaSourceGStreamer to match new duration parameters.

  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::setDuration): Ditto.

  • platform/graphics/gstreamer/MediaSourceGStreamer.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
11:58 AM Changeset in webkit [169536] by jer.noble@apple.com
  • 11 edits in trunk/Source/WebCore

[MSE][Mac] Media does not generate 'ended' event when playing to duration.
​https://bugs.webkit.org/show_bug.cgi?id=133452

Reviewed by Eric Carlson.

Add a boundaryTimeObserver to the AVSampleBufferRenderSynchronizer to detect when
playback crosses the duration boundary, and pause in that event. Also refuse to begin
playback if the currentTime is beyond the duration. Also, pause playback if duration
becomes less than currentTime.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::playInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentTimeDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):

Update MediaSource::duration() and ::setDuration() to take and give MediaTimes rather than doubles:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::duration): double -> MediaTime.
(WebCore::MediaSource::setDuration): Ditto.
(WebCore::MediaSource::streamEndedWithError): Ditto.

  • platform/graphics/MediaSourcePrivate.h: Ditto.
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::duration): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::setDuration): Ditto.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource): Ditto.
(WebCore::MockMediaPlayerMediaSource::maxTimeSeekableDouble): Ditto.
(WebCore::MockMediaPlayerMediaSource::durationDouble): Ditto.
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime): Ditto.
(WebCore::MockMediaPlayerMediaSource::updateDuration): Ditto.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate): Ditto.
(WebCore::MockMediaSourcePrivate::duration): Ditto.
(WebCore::MockMediaSourcePrivate::setDuration): Ditto.

  • platform/mock/mediasource/MockMediaSourcePrivate.h:
11:19 AM Changeset in webkit [169535] by mhock@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed TestExpectations gardening after r169532.

Update fast/table/border-collapsing/collapsed-borders-adjoining-sections.html
from [ Failure ] to [ ImageOnlyFailure ].

10:39 AM Changeset in webkit [169534] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

Rename ImagePaintingContext to ImagePaintingOptions.
​https://bugs.webkit.org/show_bug.cgi?id=133451

Reviewed by Simon Fraser.

No change in functionality.

  • WebCore.exp.in:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):

  • platform/graphics/GraphicsContext.h:

(WebCore::ImagePaintingOptions::ImagePaintingOptions):
(WebCore::ImagePaintingContext::ImagePaintingContext): Deleted.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

10:22 AM Changeset in webkit [169533] by oliver@apple.com
  • 6 edits
    5 adds
    1 delete in trunk/Source/WebKit2

Restructure initial distinct sandbox profiles
​https://bugs.webkit.org/show_bug.cgi?id=133415

Reviewed by Alexey Proskuryakov.

Add support for manually instantiating the network and
content process sandboxes, and add initial profiles.
These profiles are completely generic so we can make sure
nothing is broken by enabling them.

This also adds a target to the WebKit2 project to correctly
process the profiles.

  • DatabaseProcess/ios/DatabaseProcessIOS.mm:

(WebKit::DatabaseProcess::initializeSandbox):

  • DatabaseProcess/ios/com.apple.WebKit.DatabasesIOS.sb: Removed.
  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::initializeSandbox):

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb: Added.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb: Added.
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeSandbox):

9:37 AM Changeset in webkit [169532] by Brent Fulgham
  • 4 edits in trunk

REGRESSION (r154622): Borders disappear when hovering over cells in table
​https://bugs.webkit.org/show_bug.cgi?id=133057
<rdar://problem/15922359>

Reviewed by Tim Horton.

Source/WebCore:

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders): Revert recent
non-edge collapsed border optimization due to drawing
regressions.

LayoutTests:

until we provide a permanent fix.

9:05 AM Changeset in webkit [169531] by Alan Bujtas
  • 14 edits in trunk/Source/WebCore

Provide better encapsulation for image related painting properties.
​https://bugs.webkit.org/show_bug.cgi?id=133434

Reviewed by Darin Adler.

Image related drawing property list keeps growing for the functions below and results in
multiple overloadings with seemingly random default parameters.

GraphicsContext::drawImage()
GraphicsContext::drawTiledImage()
GraphicsContext::drawImageBuffer()

This patch provides encapsulation for the image drawing properties. Encapsulation ensures that
introducing a new property does not result in yet another overloaded function.

No change in functionality.

  • WebCore.exp.in:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):

  • platform/graphics/GraphicsContext.h:

(WebCore::ImagePaintingContext::ImagePaintingContext):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::endShadowLayer):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

8:03 AM Changeset in webkit [169530] by commit-queue@webkit.org
  • 14 edits in trunk/Source/WebCore

Unreviewed, rolling out r169529.
​https://bugs.webkit.org/show_bug.cgi?id=133447

caused assert in drawImage() (Requested by zalan on #webkit).

Reverted changeset:

"Provide better encapsulation for image related painting
properties."
​https://bugs.webkit.org/show_bug.cgi?id=133434
​http://trac.webkit.org/changeset/169529

7:23 AM Changeset in webkit [169529] by Alan Bujtas
  • 14 edits in trunk/Source/WebCore

Provide better encapsulation for image related painting properties.
​https://bugs.webkit.org/show_bug.cgi?id=133434

Reviewed by Darin Adler.

Image related drawing property list keeps growing for the functions below and results in
multiple overloadings with seemingly random default parameters.

GraphicsContext::drawImage()
GraphicsContext::drawTiledImage()
GraphicsContext::drawImageBuffer()

This patch provides encapsulation for the image drawing properties. Encapsulation ensures that
introducing a new property does not result in yet another overloaded function.

No change in functionality.

  • WebCore.exp.in:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):

  • platform/graphics/GraphicsContext.h:

(WebCore::ImagePaintingContext::ImagePaintingContext):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::endShadowLayer):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

3:55 AM Changeset in webkit [169528] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Add mock DTMFSender support.
​https://bugs.webkit.org/show_bug.cgi?id=133298

Patch by Kiran <​kiran.guduru@samsung.com> on 2014-06-02
Reviewed by Eric Carlson.

Source/WebCore:
Implemented mock implementation for RTCPeerConnectionHandler. Now creating
RTCDTMFSenderHandlerMock and returning while creating DTMFSender instead of
returning null.

Test: fast/mediastream/RTCPeerConnection-dtmf.html.

  • CMakeLists.txt:
  • platform/mock/RTCDTMFSenderHandlerMock.cpp: Added.

(WebCore::RTCDTMFSenderHandlerMock::RTCDTMFSenderHandlerMock):
(WebCore::RTCDTMFSenderHandlerMock::setClient):
(WebCore::RTCDTMFSenderHandlerMock::insertDTMF):

  • platform/mock/RTCDTMFSenderHandlerMock.h: Added.
  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::createDTMFSender):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-dtmf-expected.txt:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
1:31 AM Changeset in webkit [169527] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] media controls should prevent 'click' events from reaching the page
​https://bugs.webkit.org/show_bug.cgi?id=133402

Reviewed by Eric Carlson.

When handling events, we events we need to return true in order
that the superclass gets the value and prevents the execution of
the default event handler in the page.

Test: media/media-controls-cancel-events.html

  • Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.handleMuteButtonMouseOver):
(ControllerGtk.prototype.handleVolumeBoxMouseOut):
(ControllerGtk.prototype.handleCaptionButtonClicked):
(ControllerGtk.prototype.handleCaptionButtonMouseOver):
(ControllerGtk.prototype.handleCaptionButtonShowMenu):
(ControllerGtk.prototype.handleCaptionButtonMouseOut):
(ControllerGtk.prototype.handleCaptionMouseOut): Return true to
prevent forwarding the event execution.

12:32 AM Changeset in webkit [169526] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Below test cases are passing after r169403.

  • fast/dom/webtiming-document-open.html
  • fast/dom/webtiming-navigate-within-document.html
  • platform/efl/TestExpectations:
12:00 AM Changeset in webkit [169525] by commit-queue@webkit.org
  • 3 edits
    8 adds in trunk

CSS JIT: add support for the "not" pseudo class
​https://bugs.webkit.org/show_bug.cgi?id=133314

Source/WebCore:
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-02
Reviewed by Benjamin Poulain.

Add :not pseudo class support to CSS JIT. Current implementation
doesn't support visitedMatchType. So when link pseudo class appears in
:not sub fragment, fallback to the non-JIT implementation.

Tests: fast/selectors/not-active-hover-quirks.html

fast/selectors/not-active-hover-strict.html
fast/selectors/pseudo-class-not.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::computeBacktrackingInformation):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementDataMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesNotPseudoClass):
(WebCore::SelectorCompiler::SelectorCodeGenerator::computeBacktrackingInformation): Deleted.

LayoutTests:
Add :not pseudo class support to CSS JIT. Current implementation
doesn't support visitedMatchType. So when link pseudo class appears in
:not sub fragment, fallback to the non-JIT implementation.

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-02
Reviewed by Benjamin Poulain.

  • fast/selectors/not-active-hover-quirks-expected.txt: Added.
  • fast/selectors/not-active-hover-quirks.html: Added.
  • fast/selectors/not-active-hover-strict-expected.txt: Added.
  • fast/selectors/not-active-hover-strict.html: Added.
  • fast/selectors/pseudo-class-not-expected.txt: Added.
  • fast/selectors/pseudo-class-not.html: Added.
  • fast/selectors/resources/not-hover-active-quirks-utility.js: Added.

(testQuerySelector):
(test):

  • fast/selectors/resources/not-hover-active-strict-utility.js: Added.

(testQuerySelector):
(test):

Jun 1, 2014:

11:52 PM Changeset in webkit [169524] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

gradient-background-leakage-hidpi.html and canvas-as-image-hidpi.html pass after r169445.

  • platform/efl-wk2/TestExpectations:
10:16 PM Changeset in webkit [169523] by jer.noble@apple.com
  • 19 edits
    2 adds in trunk

[MSE] Appends of overlapping sample data do not clear existing samples properly.
​https://bugs.webkit.org/show_bug.cgi?id=133435

Reviewed by Darin Adler.

Source/WebCore:
Test: media/media-source/media-source-overlapping-append.html

The MSE spec has a spec error in how it removes overlapping frames. The intention seems to be
to check for overlapping samples only when the incoming sample increases the highest presentation time
field. But due to a mismatch in the range of a sample, defined as [start, end), and the check, which
treats the end as inclusive, the overlapping check is almost never run.

Add the sample comparison logic to match [start, end) ranges, and rename the existing check to differentiate
it from the new one:

  • Modules/mediasource/SampleMap.cpp:

(WebCore::SamplePresentationTimeIsInsideRangeComparator::operator()):
(WebCore::SamplePresentationTimeIsWithinRangeComparator::operator()):
(WebCore::SampleMap::findSamplesBetweenPresentationTimes):
(WebCore::SampleMap::findSamplesWithinPresentationRange):

  • Modules/mediasource/SampleMap.h:

Update the overlapping check to occur whenever the highest presentation time increases, and update the
logic within that check to catch all overlapping frames.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
(WebCore::SourceBuffer::bufferedSamplesForTrackID):

  • Modules/mediasource/SourceBuffer.h:
  • WebCore.exp.in:

Add a dump method to MediaSample so that samples can be easily converted to a string for testing.

  • platform/MediaSample.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::presentationSize):
(WebCore::MediaSampleAVFObjC::dump):

Update the Mock MSE implementation to pass along a "generation" field, to aid in testing.

  • platform/mock/mediasource/MockBox.cpp:

(WebCore::MockSampleBox::MockSampleBox):

  • platform/mock/mediasource/MockBox.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockMediaSample::dump):

Add a method to internals to dump the buffered samples to string.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::bufferedSamplesForTrackID):

  • Modules/mediasource/SourceBuffer.h:
  • testing/Internals.cpp:

(WebCore::Internals::bufferedSamplesForTrackID):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WTF:
Add a dump method to MediaTime, so that MediaTimes can be easily converted to strings (for logging purposes).

  • wtf/MediaTime.cpp:

(WTF::MediaTime::dump):

  • wtf/MediaTime.h:

LayoutTests:

  • media/media-source/media-source-overlapping-append-expected.txt: Added.
  • media/media-source/media-source-overlapping-append.html: Added.
  • media/media-source/mock-media-source.js:
10:01 PM Changeset in webkit [169522] by commit-queue@webkit.org
  • 14 edits
    6 adds in trunk

getBBox() returns (0,0) when width or height is zero.
​https://bugs.webkit.org/show_bug.cgi?id=93290

Patch by Nikos Andronikos <​nikos.andronikos-webkit@cisra.canon.com.au> on 2014-06-01
Reviewed by Philip Rogers.

Source/WebCore:

The SVG spec states that a width or height of zero for rects, circles and
ellipses is valid but disables rendering of that shape.
In this case, getBBox() should return the actual bounding box of the element.
Previously, WebKit always returned (0,0,0,0) rather than the
correct bounding box. This patch fixes that.

Rects and ellipses both now follow the same behaviour where
the fall-back code path is only used when the shape will render (e.g. not
when a dimension <= 0).

This necessitates calling calculateRadiiAndCenter for ellipses even
when the calculated values will be discarded in the fall back code path.
But calculateRadiiAndCenter is cheap and this avoids making changes
elsewhere to stop CG drawing a zero width (or height) ellipse.

Tests: svg/custom/getBBox-js-circle-zerodimension.html

svg/custom/getBBox-js-ellipse-zerodimension.html
svg/custom/getBBox-js-rect-zerodimension.html

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::updateShapeFromElement):
Only follow fall-back code path when shape renders.

width
height==0 is not an error case so calculate bounding box.
  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):
Only follow fall-back code path when shape renders.

rx
ry==0 is not an error case so calculate bounding box.

LayoutTests:

  • platform/mac/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • svg/custom/getBBox-js-circle-zerodimension-expected.txt: Added.
  • svg/custom/getBBox-js-circle-zerodimension.html: Added.
  • svg/custom/getBBox-js-ellipse-zerodimension-expected.txt: Added.
  • svg/custom/getBBox-js-ellipse-zerodimension.html: Added.
  • svg/custom/getBBox-js-rect-zerodimension-expected.txt: Added.
  • svg/custom/getBBox-js-rect-zerodimension.html: Added.
6:53 PM Changeset in webkit [169521] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

EFL gardening. Unskip some iframe tests which have passed since buildbot OS bump up.

  • platform/efl-wk1/TestExpectations:
5:33 PM Changeset in webkit [169520] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Add SPI to get a WebArchive of the WKWebView
<rdar://problem/16748120>
​https://bugs.webkit.org/show_bug.cgi?id=133439

Reviewed by Anders Carlsson.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
4:07 PM Changeset in webkit [169519] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Don't scroll to non-integral scroll offsets
​https://bugs.webkit.org/show_bug.cgi?id=133436
<rdar://problem/17088336>

Reviewed by Darin Adler.

With the gradual migration of scroll offsets to floating point, we ended
up with a fully floating point code path been event scroll deltas and
setting scroll positions in the scrolling tree.

With some input devices (e.g. Logitech scrollwheel mice), the scroll deltas
come in with non-integral values, and that caused the scroll offset to be non-integral,
resulting in fuzzy layer contents. So round the scroll position.

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):

3:31 PM Changeset in webkit [169518] by andersca@apple.com
  • 20 edits in trunk/Source

Add a LazyNeverDestroyed class template and use it
​https://bugs.webkit.org/show_bug.cgi?id=133425

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • dfg/DFGFunctionWhitelist.cpp:

(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist):

  • dfg/DFGFunctionWhitelist.h:

Source/WebCore:

  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::guidMutex):

  • crypto/CryptoAlgorithmRegistry.cpp:

(WebCore::registryMutex):

  • inspector/WorkerDebuggerAgent.cpp:
  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlResponseHeaderWhitelist):

  • platform/network/NetworkStateNotifier.cpp:

(WebCore::networkStateNotifier):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::DefaultSharedWorkerRepository::instance):

  • workers/DefaultSharedWorkerRepository.h:
  • workers/WorkerThread.cpp:

(WebCore::threadSetMutex):

  • xml/XMLHttpRequest.cpp:

(WebCore::staticData):

Source/WebKit2:

  • Shared/mac/SecItemShim.cpp:

(WebKit::responseMap):

Source/WTF:
LazyNeverDestroyed is similar to NeverDestroyed, except it's lazily constructed
by calling construct(). This makes it useful for using inside std::call_once functions.

  • wtf/Forward.h:
  • wtf/NeverDestroyed.h:

(WTF::LazyNeverDestroyed::construct):
(WTF::LazyNeverDestroyed::operator T&):
(WTF::LazyNeverDestroyed::get):
(WTF::LazyNeverDestroyed::asPtr):
(WTF::LazyNeverDestroyed::MaybeRelax::MaybeRelax):

  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:

(WTF::atomicallyInitializedStaticMutex):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::cachedCollatorMutex):

2:12 PM Changeset in webkit [169517] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

DYEBench: Move test states into benchmarkClient and remove the closure
​https://bugs.webkit.org/show_bug.cgi?id=133438

Reviewed by Benjamin Poulain.

Moved all local variables in the closure wrapping benchmarkClient onto the object itself
and removed the closure to improve the readability of the code.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/main.js:

(window.benchmarkClient.willRunTest):
(window.benchmarkClient.didRunTest):
(window.benchmarkClient.didRunSuites):
(window.benchmarkClient.willStartFirstIteration):
(window.benchmarkClient.didFinishLastIteration):
(window.benchmarkClient._addResult): Moved.
(.): Deleted.

1:38 PM Changeset in webkit [169516] by rniwa@webkit.org
  • 2 edits
    2 adds in trunk/PerformanceTests

DYEBench: Split stylesheets and scripts in Full.html into separate files
​https://bugs.webkit.org/show_bug.cgi?id=133437

Reviewed by Benjamin Poulain.

Extracted main.js and main.css.

Also fixed a bug in startBenchmark that disabled suites were counted towards the total number of tests.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/main.css: Added.
  • DoYouEvenBench/resources/main.js: Added.

(.addResult):
(window.benchmarkClient):
(startBenchmark): Renamed from startTest.

9:30 AM Changeset in webkit [169515] by Alan Bujtas
  • 4 edits
    4 adds in trunk

Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.
​https://bugs.webkit.org/show_bug.cgi?id=133429

Reviewed by Simon Fraser.

Do not floor logical right/left values when selection gap is calculated for RenderBlocks.
It produces overlapping line/gap because the floored value is intersecting/too far from the
non-floored content selection rect.

Source/WebCore:
Tests: fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html

fast/inline/hidpi-selection-gap-overlaps-inline-selection.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):

LayoutTests:

  • platform/mac/TestExpectations: add ML failure due to font sizing. (Ahem can't be used here)
  • fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl-expected.html: Added.
  • fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html: Added.
  • fast/inline/hidpi-selection-gap-overlaps-inline-selection-expected.html: Added.
  • fast/inline/hidpi-selection-gap-overlaps-inline-selection.html: Added.
6:44 AM Changeset in webkit [169514] by rniwa@webkit.org
  • 9 edits in trunk/PerformanceTests

DYEBench: CSS parser warning at line 106 of base.css
​https://bugs.webkit.org/show_bug.cgi?id=133433

Reviewed by Maciej Stachowiak.

Removed the old filter CSS property for Internet Explorer. The latest Internet Explorer supports -ms-linear-gradient
on background CSS property anyways.

It's interesting that some of the tests only have -webkit- prefixes. Perhaps we should update those subtests.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css:

(#header:before):

  • DoYouEvenBench/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css:

(#header:before):

12:01 AM Changeset in webkit [169513] by rniwa@webkit.org
  • 3 edits in trunk/PerformanceTests

DYEBench: Ember.js assertion hit at line 20593
​https://bugs.webkit.org/show_bug.cgi?id=133431

Reviewed by Darin Adler.

The assertion was hit because ToDoMVC includes jQuery 2.1 and Ember.js 1.3.1 only recognizes jQuery 2.0.
Port the assertion from Ember.js 1.5.1 to suppress the assertion.

We should update the entire Ember.js at some point but this would do the job for now.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js:
Note: See TracTimeline for information about the timeline view.