Context Navigation

← Previous Period
Next Period →

Timeline

Jun 18, 2014:

10:54 PM Changeset in webkit [170143] by zandobersek@gmail.com

14 edits in trunk/Source/WebCore

ScriptExecutionContext::Task, FileThread::Task parameters should be values
https://bugs.webkit.org/show_bug.cgi?id=134035

Reviewed by Anders Carlsson.

r170106 and similar previous changesets enforced ScriptExecutionContext::Task and
FileThread::Task parameters as rvalue references. There's technically nothing wrong
with that, but since both classes are move-only it is also not strictly required.
Accepting these parameters as values is more common in C++ value semantics as well.

dom/Document.cpp:

(WebCore::Document::postTask):

dom/Document.h:
dom/ScriptExecutionContext.h:
fileapi/FileThread.cpp:

(WebCore::FileThread::postTask):

fileapi/FileThread.h:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::postTask):

workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):

workers/WorkerMessagingProxy.h:
workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::postTask):
(WebCore::WorkerRunLoop::postTaskAndTerminate):
(WebCore::WorkerRunLoop::postTaskForMode):
(WebCore::WorkerRunLoop::Task::create):
(WebCore::WorkerRunLoop::Task::Task):

workers/WorkerRunLoop.h:

10:37 PM Changeset in webkit [170142] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed. Fixing the GTK+ build after r170114.

UIProcess/API/gtk/WebKitAuthenticationRequest.cpp:

(webkit_authentication_request_get_proposed_credential):
The core() accessor has been renamed to credential().

9:34 PM Changeset in webkit [170141] by fpizlo@apple.com

17 edits
21 adds in branches/ftlopt

DFG AI and constant folder should be able to precisely prune MultiGetByOffset/MultiPutByOffset even if the base structure abstract value is not a singleton
https://bugs.webkit.org/show_bug.cgi?id=133918

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

This also adds pruning of PutStructure, since I basically had no choice but
to implement such logic within MultiPutByOffset.

Also adds a bunch of PutById cache status dumping to bytecode dumping.

bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::dumpInContext):

bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::structureSet):

bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::oldStructure):

bytecode/StructureSet.cpp:

(JSC::StructureSet::filter):
(JSC::StructureSet::filterArrayModes):

bytecode/StructureSet.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::changeStructure):
(JSC::DFG::AbstractValue::contains):

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::couldBeType):
(JSC::DFG::AbstractValue::isType):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addBaseCheck):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::freezeStrong):

dfg/DFGGraph.h:
dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::operator=):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):

tests/stress/fold-multi-get-by-offset-to-get-by-offset-without-folding-the-structure-check.js: Added.

(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):

tests/stress/fold-multi-put-by-offset-to-put-by-offset-without-folding-the-structure-check.js: Added.

(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):

tests/stress/prune-multi-put-by-offset-replace-or-transition-variant.js: Added.

(foo):
(fu):
(bar):
(baz):
(.bar):
(.baz):

LayoutTests:

js/regress/fold-multi-get-by-offset-to-get-by-offset-expected.txt: Added.
js/regress/fold-multi-get-by-offset-to-get-by-offset.html: Added.
js/regress/fold-multi-get-by-offset-to-poly-get-by-offset-expected.txt: Added.
js/regress/fold-multi-get-by-offset-to-poly-get-by-offset.html: Added.
js/regress/fold-multi-put-by-offset-to-poly-put-by-offset-expected.txt: Added.
js/regress/fold-multi-put-by-offset-to-poly-put-by-offset.html: Added.
js/regress/fold-multi-put-by-offset-to-put-by-offset-expected.txt: Added.
js/regress/fold-multi-put-by-offset-to-put-by-offset.html: Added.
js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset-expected.txt: Added.
js/regress/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.html: Added.
js/regress/fold-put-structure-expected.txt: Added.
js/regress/fold-put-structure.html: Added.
js/regress/script-tests/fold-multi-get-by-offset-to-get-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

js/regress/script-tests/fold-multi-get-by-offset-to-poly-get-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

js/regress/script-tests/fold-multi-put-by-offset-to-poly-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

js/regress/script-tests/fold-multi-put-by-offset-to-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

js/regress/script-tests/fold-multi-put-by-offset-to-replace-or-transition-put-by-offset.js: Added.

(foo):
(fu):
(bar):
(.bar):

js/regress/script-tests/fold-put-structure.js: Added.

(foo):
(fu):
(bar):
(.bar):

9:16 PM Changeset in webkit [170140] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Try to fix the Mountain Lion build.

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame):

8:11 PM Changeset in webkit [170139] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

Remove RemoteLayerBackingStore’s RemoteLayerTreeContext pointer
https://bugs.webkit.org/show_bug.cgi?id=134055

Reviewed by Simon Fraser.

Shared/mac/RemoteLayerBackingStore.h:
Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::~RemoteLayerBackingStore):
(WebKit::RemoteLayerBackingStore::ensureBackingStore):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::drawInContext):
Remove RemoteLayerBackingStore's RemoteLayerTreeContext pointer. Instead, use the PlatformCALayer's.
Pass the PlatformCALayer in to the constructor, and remove it from ensureBackingStore();
RemoteLayerBackingStore is (for now) strictly tied to a single layer.

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::ensureBackingStore):
(WebKit::PlatformCALayerRemote::updateBackingStore):

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

(WebKit::PlatformCALayerRemote::context):

7:19 PM Changeset in webkit [170138] by jcraig@apple.com

11 edits in trunk

Web Inspector: AXI: expose aria-relevant
https://bugs.webkit.org/show_bug.cgi?id=130913

Reviewed by Joseph Pecoraro.

Expose ARIA live region relevance in Web Inspector.
E.g. "Live: Assertive (Additions, Text)"

Source/WebCore:
Test: inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties): Support for liveRegionRelevant.

inspector/protocol/DOM.json: Defined enum values and array passed to client.

Source/WebInspectorUI:

Localizations/en.lproj/localizedStrings.js: New strings.
UserInterface/Models/DOMNode.js: One additional property passed.
UserInterface/Views/DOMNodeDetailsSidebarPanel.js: UI updates to support new property.

LayoutTests:

inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt: Minor update.
inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion-expected.txt: Updated with new output.
inspector-protocol/dom/getAccessibilityPropertiesForNode_liveRegion.html: Updated with new elements.

5:30 PM Changeset in webkit [170137] by mitz@apple.com

4 edits in trunk/Source/WebKit2

[Cocoa] Modernize one-method authentication
https://bugs.webkit.org/show_bug.cgi?id=134051

Reviewed by Anders Carlsson.

Instead of an NSURLConnection-style delegate method that takes a challenge and responds to
its sender, provide an NSURLSession-style method that takes a challenge and a completion
handler.

UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method, replacing

old unused method.

UIProcess/Cocoa/NavigationState.h: Renamed flag in m_navigationDelegateMethods struct.
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Check for new delegate method and update
new flag.

(WebKit::NavigationState::LoaderClient::canAuthenticateAgainstProtectionSpaceInFrame): If
the delegate implements the new method, return true (if it cannot handle the protection
space, it can reject it through the completion handler), except for server-trust
authentication, which is not supported yet.
(WebKit::NavigationState::LoaderClient::didReceiveAuthenticationChallengeInFrame): If the
delegate implements the new method, call it, passing a completion handler that calls the
right AuthenticationDecisionListener function based on its disposition and credential
parameters.

5:21 PM Changeset in webkit [170136] by Simon Fraser

10 edits in trunk

Add rebeccapurple to CSS named color list
https://bugs.webkit.org/show_bug.cgi?id=133804

Reviewed by Jer Noble.

Source/WebCore:

Add the named color "rebeccapurple" (#639).

css/SVGCSSValueKeywords.in:
platform/ColorData.gperf:

Source/WebInspectorUI:

Add the named color "rebeccapurple" (#639).

UserInterface/External/CodeMirror/css.js:
UserInterface/Models/CSSKeywordCompletions.js:
UserInterface/Models/Color.js:

LayoutTests:

Add the named color "rebeccapurple" (#639).

fast/css/named-colors-expected.txt:
fast/css/named-colors.html:

5:20 PM Changeset in webkit [170135] by jpfau@apple.com

4 edits in trunk

Fix flaky beforeload tests
https://bugs.webkit.org/show_bug.cgi?id=133685

Reviewed by David Kilzer.

Source/WebCore:

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):

LayoutTests:

platform/wk2/TestExpectations: Unskip tests that are no longer flaky

5:13 PM Changeset in webkit [170134] by andersca@apple.com

19 edits in trunk/Source

Make FrameLoadType a strongly typed enum
https://bugs.webkit.org/show_bug.cgi?id=134047

Reviewed by Andreas Kling.

Source/WebCore:

history/BackForwardController.cpp:

(WebCore::BackForwardController::goBackOrForward):
(WebCore::BackForwardController::goBack):
(WebCore::BackForwardController::goForward):

history/PageCache.cpp:

(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):

loader/FrameLoader.cpp:

(WebCore::isBackForwardLoadType):
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::isReplacing):
(WebCore::FrameLoader::setReplacing):
(WebCore::FrameLoader::subresourceCachePolicy):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):

loader/FrameLoaderTypes.h:
loader/HistoryController.cpp:

(WebCore::HistoryController::restoreDocumentState):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::isReplaceLoadTypeWithProvisionalItem):
(WebCore::HistoryController::isReloadTypeWithProvisionalItem):

loader/NavigationAction.cpp:

(WebCore::navigationType):

loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::PolicyChecker):
(WebCore::PolicyChecker::checkNavigationPolicy):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::cachePolicy):

loader/icon/IconController.cpp:

(WebCore::IconController::startLoader):

Source/WebKit/mac:

WebView/WebFrame.mm:

(toWebFrameLoadType):
(-[WebFrame _loadType]):

WebView/WebView.mm:

(-[WebView _loadBackForwardListFromOtherView:]):
(-[WebView goToBackForwardItem:]):

Source/WebKit/win:

WebView.cpp:

(WebView::goToBackForwardItem):
(WebView::loadBackForwardListFromOtherView):

Source/WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::shouldReuseCommittedSandboxExtension):
(WebKit::WebPage::didCommitLoad):

5:11 PM Changeset in webkit [170133] by andersca@apple.com

14 edits in trunk/Source/WebKit2

Simplify WebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=134049

Reviewed by Andreas Kling.

Shared/API/c/WKSecurityOrigin.cpp:

(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCopyDatabaseIdentifier):
(WKSecurityOriginCopyToString):
(WKSecurityOriginCopyProtocol):
(WKSecurityOriginCopyHost):
(WKSecurityOriginGetPort):

Shared/WebSecurityOrigin.h:

(WebKit::WebSecurityOrigin::securityOrigin):
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier): Deleted.
(WebKit::WebSecurityOrigin::protocol): Deleted.
(WebKit::WebSecurityOrigin::host): Deleted.
(WebKit::WebSecurityOrigin::port): Deleted.
(WebKit::WebSecurityOrigin::databaseIdentifier): Deleted.
(WebKit::WebSecurityOrigin::toString): Deleted.

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::deleteEntriesForOrigin):

UIProcess/Storage/StorageManager.h:
UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):

UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):

UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::didGetStorageDetailsByOrigin):

UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):

UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:window:]):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):

5:06 PM Changeset in webkit [170132] by achristensen@apple.com

4 edits in trunk/Source/WebCore

[curl] Unreviewed speculative build fix after r170021.

platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::setResponseFromCachedHeaders):
(WebCore::CurlCacheEntry::parseResponseHeaders):

platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::didReceiveHeader):

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::getProtectionSpace):
(WebCore::headerCallback):
Use HTTPHeaderName constants.

4:49 PM Changeset in webkit [170131] by Simon Fraser

5 edits in trunk/Source/WebCore

Move the removeNode() tree walking from ScrollingStateNote into ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=134043

Reviewed by Beth Dakin.

It's cleaner if ScrollingStateTree does the descendant walk when removing nodes.
We can simply start the "willBeRemoved" walk at the node in question.

Have willRemoveNode() just remove the node from the m_stateNodeMap directly, rather
than this happening in a separate walk of m_nodesRemovedSinceLastCommit.

page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::removeDescendant): Deleted.
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree): Deleted.

page/scrolling/ScrollingStateNode.h:
page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::detachNode):
(WebCore::ScrollingStateTree::clear):
(WebCore::ScrollingStateTree::removeNodeAndAllDescendants):
(WebCore::ScrollingStateTree::recursiveNodeWillBeRemoved):
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::removeNode): Deleted.

page/scrolling/ScrollingStateTree.h:

4:42 PM Changeset in webkit [170130] by achristensen@apple.com

7 edits
5 adds in trunk/Source

Add FTL to Windows build.
https://bugs.webkit.org/show_bug.cgi?id=134015

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

Added ftl source files.

JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:

Added ftl and llvm directories to include path.

JavaScriptCore.vcxproj/libllvmForJSC: Added.
JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.props: Added.
JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj: Added.
JavaScriptCore.vcxproj/libllvmForJSC/libllvmForJSC.vcxproj.filters: Added.
ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
MSVC doesn't like to divide by zero while compiling. Use std::nan instead.

llvm/InitializeLLVMWin.cpp: Added.

(JSC::initializeLLVMImpl):
Implemented dynamic loading and linking for Windows.

Source/WebKit:

WebKit.vcxproj/WebKit.sln:

Added libllvmForJSC with a dependency on JavaScriptCoreGenerated, but don't build it yet.

4:16 PM Changeset in webkit [170129] by mhahnenberg@apple.com

19 edits in branches/ftlopt/Source/JavaScriptCore

Remove CompoundType and LeafType
https://bugs.webkit.org/show_bug.cgi?id=134037

Reviewed by Filip Pizlo.

We don't use them for anything. We'll replace them with a generic CellType type for all
the objects that are JSCells, aren't JSObjects, and for which we generally don't care about
their JSType at runtime.

llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

runtime/ArrayBufferNeuteringWatchpoint.cpp:

(JSC::ArrayBufferNeuteringWatchpoint::createStructure):

runtime/Executable.h:

(JSC::ExecutableBase::createStructure):
(JSC::NativeExecutable::createStructure):

runtime/JSPromiseDeferred.h:

(JSC::JSPromiseDeferred::createStructure):

runtime/JSPromiseReaction.h:

(JSC::JSPromiseReaction::createStructure):

runtime/JSPropertyNameIterator.h:

(JSC::JSPropertyNameIterator::createStructure):

runtime/JSType.h:
runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):

runtime/MapData.h:

(JSC::MapData::createStructure):

runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::createStructure):

runtime/RegExp.h:

(JSC::RegExp::createStructure):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::createStructure):

runtime/Structure.cpp:

(JSC::Structure::Structure):

runtime/StructureChain.h:

(JSC::StructureChain::createStructure):

runtime/StructureRareData.cpp:

(JSC::StructureRareData::createStructure):

runtime/SymbolTable.h:

(JSC::SymbolTable::createStructure):

runtime/WeakMapData.h:

(JSC::WeakMapData::createStructure):

4:14 PM Changeset in webkit [170128] by achristensen@apple.com

2 edits in trunk/Source/WebCore

[iOS WebGL] Fixed WEBGL_compressed_texture_pvrtc.
https://bugs.webkit.org/show_bug.cgi?id=133561

Based on Blink r153971 by bajones@chromium.org.

Reviewed by Dean Jackson.

No new tests, but this should fix webgl-compressed-texture-pvrtc.html.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexDimensions):
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions):
Added checks for pvrtc.

4:13 PM Changeset in webkit [170127] by Lucas Forschler

3 edits in tags/Safari-538.41/Source/WebKit2

Merged r170126.

4:04 PM Changeset in webkit [170126] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add back WKPageRunJavaScriptInMainFrame_b for now
https://bugs.webkit.org/show_bug.cgi?id=134045
<rdar://problem/17368879>

Reviewed by Tim Horton.

Reverted changeset:

"Remove WKPageRunJavaScriptInMainFrame_b"
https://bugs.webkit.org/show_bug.cgi?id=133926
http://trac.webkit.org/changeset/169991

3:57 PM Changeset in webkit [170125] by andersca@apple.com

4 edits in trunk/Source/WebKit/win

Remove IWebFramePrivate::loadType
https://bugs.webkit.org/show_bug.cgi?id=134044

Reviewed by Tim Horton.

Interfaces/IWebFramePrivate.idl:
WebFrame.cpp:

(WebFrame::loadType): Deleted.
(WebFrame::unused2): Deleted.

WebFrame.h:

3:32 PM Changeset in webkit [170124] by andersca@apple.com

2 edits in trunk/Source/WebCore

Work around a Windows compiler crash.

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection):

3:32 PM Changeset in webkit [170123] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Simplify WebPageProxy::saveRecentSearches and WebPageProxy::loadRecentSearches
https://bugs.webkit.org/show_bug.cgi?id=134041

Reviewed by Andreas Kling.

UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

3:19 PM Changeset in webkit [170122] by timothy_horton@apple.com

2 edits in trunk/Tools

All of MiniBrowser's WKWebViews should share a configuration
https://bugs.webkit.org/show_bug.cgi?id=134017

Reviewed by Anders Carlsson.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
Share a single WKWebViewConfiguration between all of MiniBrowser's views.
This means that they'll share things like preferences, visited links, etc.
It also means that we'll properly share processes once we hit the process limit.

3:10 PM Changeset in webkit [170121] by benjamin@webkit.org

3 edits
6 adds in trunk

Subtrees with :first-child and :last-child are not invalidated when siblings are added/removed
https://bugs.webkit.org/show_bug.cgi?id=133934

Reviewed by Antti Koivisto.

Source/WebCore:
When adding/removing nodes on an element, we try to invalidate only the elements that are
affected. In the case of :first-child and :last-child, that optimizations is implemented
through two types of flags that are updated during style resolution.

The first flag is childrenAffectedByFirstChildRules (childrenAffectedByLastChildRules),
set on the parent of any element that could be affected by :first-child (:last-child).

The other part of the optimization is marking the style itself with firstChildState (lastChildState)
to further reduce invalidations.

The problem in this case happen with a subtree of element is detached. Since there is no renderer,
the computed style is resolved ad-hoc and stored directly on the element. When the element is moved,
the computed style was never cleared because the invalidation optimizations were not handling
elements without style.

Credit to Yusuke Suzuki for discovering the issue and creating test cases.

Tests: fast/css/getComputedStyle/empty-update-without-renderer.html

fast/css/getComputedStyle/first-child-update-without-renderer.html
fast/css/getComputedStyle/last-child-update-without-renderer.html

dom/Element.cpp:

(WebCore::checkForEmptyStyleChange):
Clean up: pull the style directly from the function instead of expection the call sites to do that.
Refine the checks to avoid invalidation.

(WebCore::checkForSiblingStyleChanges):
Do not early return if the parent is detached, the children may still need invalidation.

When there is no renderer, assume the worst first-child/last-child and force the invalidation.

(WebCore::Element::childrenChanged):

LayoutTests:

fast/css/getComputedStyle/empty-update-without-renderer-expected.txt: Added.
fast/css/getComputedStyle/empty-update-without-renderer.html: Added.
fast/css/getComputedStyle/first-child-update-without-renderer-expected.txt: Added.
fast/css/getComputedStyle/first-child-update-without-renderer.html: Added.
fast/css/getComputedStyle/last-child-update-without-renderer-expected.txt: Added.
fast/css/getComputedStyle/last-child-update-without-renderer.html: Added.

2:52 PM Changeset in webkit [170120] by dbates@webkit.org

7 edits
10 adds in trunk

REGRESSION (r167856): Unable to log into HSBC app
https://bugs.webkit.org/show_bug.cgi?id=133991
<rdar://problem/17044839>

Reviewed by David Kilzer.

Source/WebCore:
Following <http://trac.webkit.org/changeset/167856> we disallow "navigation to any URL that is
invalid, except for JavaScript URLs, which need not be valid." A byproduct of this policy
decision is that we no longer notify the WebKit client to about a navigation if the destination
URL is invalid. And some apps, including the HSBC app for iOS, have logic to intercept URLs
as a means to pass data from their WebView-embedded web app to the WebView. We should expose a
setting called allowNavigationToInvalidURL (disabled by default on all ports and conditionally
enabled on iOS) to toggle whether WebCore allows navigation to any URL, even if its invalid,
so as to not break clients that intercept URLs and have custom logic to handle them.

Tests: fast/loader/allow-redirect-to-invalid-url-using-javascript.html

fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html
fast/loader/disallow-redirect-to-invalid-url-using-javascript.html
fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html

loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::shouldScheduleNavigation): Modified to only validate
the URL when the setting allowNavigationToInvalidURL is disabled.

page/Settings.in: Added setting allowNavigationToInvalidURL (disabled by default).

Source/WebKit/mac:
Only enable the setting allowNavigationToInvalidURL for iOS app linked against WebKit/UIKit before iOS 8.

Misc/WebKitVersionChecks.h: Added macro constant WEBKIT_FIRST_VERSION_WITH_NAVIGATION_URL_VALIDATION.
WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Enable or disable the setting allowNavigationToInvalidURL as appropriate.

LayoutTests:
Add tests to ensure that the WebKit client will be notified to service a redirect to an invalid
URL when the setting allowNavigationToInvalidURL is enabled and will not be notified when
the setting is disabled.

fast/loader/allow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
fast/loader/allow-redirect-to-invalid-url-using-javascript.html: Added.
fast/loader/allow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
fast/loader/allow-redirect-to-invalid-url-using-meta-refresh.html: Added.
fast/loader/disallow-redirect-to-invalid-url-using-javascript-expected.txt: Added.
fast/loader/disallow-redirect-to-invalid-url-using-javascript.html: Added.
fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh-expected.txt: Added.
fast/loader/disallow-redirect-to-invalid-url-using-meta-refresh.html: Added.
fast/loader/resources/redirect-to-invalid-url-using-javascript.html: Added.
fast/loader/resources/redirect-to-invalid-url-using-meta-refresh.html: Added.

2:50 PM Changeset in webkit [170119] by achristensen@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix after r170107.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMod):
Use non-template sub for armv7s.

2:43 PM Changeset in webkit [170118] by Simon Fraser

17 edits in trunk/Source

Make ScrollingStateNodes refcounted, and other minor cleanup
https://bugs.webkit.org/show_bug.cgi?id=134040

Reviewed by Beth Dakin.

Source/WebCore:
Prepare for future scrolling frame gyrations by making
ScrollingStateNodes refcounted.

Rename ScrollingStateNode::removeChild() to removeDescendant()
since that's what it does. Also rename didRemoveNode() to willRemoveNode()
to better match the behavior.

Use 'auto' in more places.

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::syncChildPositions):

page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::create):
(WebCore::ScrollingStateFixedNode::clone):

page/scrolling/ScrollingStateFixedNode.h:
page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::create):
(WebCore::ScrollingStateFrameScrollingNode::clone):

page/scrolling/ScrollingStateFrameScrollingNode.h:
page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndReset):
(WebCore::ScrollingStateNode::appendChild):
(WebCore::ScrollingStateNode::removeDescendant):
(WebCore::ScrollingStateNode::willBeRemovedFromStateTree):
(WebCore::ScrollingStateNode::removeChild): Deleted.

page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::children):

page/scrolling/ScrollingStateOverflowScrollingNode.cpp:

(WebCore::ScrollingStateOverflowScrollingNode::create):
(WebCore::ScrollingStateOverflowScrollingNode::clone):

page/scrolling/ScrollingStateOverflowScrollingNode.h:
page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::create):
(WebCore::ScrollingStateStickyNode::clone):

page/scrolling/ScrollingStateStickyNode.h:
page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):
(WebCore::ScrollingStateTree::removeNode):
(WebCore::ScrollingStateTree::willRemoveNode):
(WebCore::ScrollingStateTree::didRemoveNode): Deleted.

page/scrolling/ScrollingStateTree.h:

(WebCore::ScrollingStateTree::setRootStateNode):

page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode):

Source/WebKit2:

Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):

2:41 PM Changeset in webkit [170117] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

-[JSContext setName:] leaks NSString
<http://webkit.org/b/134038>

Reviewed by Joseph Pecoraro.

Fixes the following static analyzer warning:

JavaScriptCore/API/JSContext.mm:200:73: warning: Potential leak of an object

JSStringRef nameJS = name ? JSStringCreateWithCFString((CFStringRef)[name copy]) : nullptr;

API/JSContext.mm:

(-[JSContext setName:]): Autorelease the copy of |name|.

2:40 PM Changeset in webkit [170116] by benjamin@webkit.org

2 edits in trunk/Source/WebKit2

[iOS][WK2] Do not add padding when magnifying replaced elements
https://bugs.webkit.org/show_bug.cgi?id=134019

Reviewed by Tim Horton.

Having margins for regular blocks make sense to improve readability. For replaced elements,
we should follow iOS's UI and display edge to edge.

UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):

2:38 PM Changeset in webkit [170115] by benjamin@webkit.org

7 edits in trunk/Source/WebKit2

[iOS][WK2] Re-sync didCommitLoadForMainFrame with its corresponding tile update
https://bugs.webkit.org/show_bug.cgi?id=134009

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-18
Reviewed by Tim Horton.

WKWebView assumed the first _didCommitLayerTree: after _didCommitLoadForMainFrame
had the state of the page being loaded.

This is not always true. Sometimes, a set of tiles can be rendering asynchronously while the next
page is loaded, and does not flush the queue until after didCommitLoadForMainFrame is executed.

Tim introduced a transactionID with each layer tree update. This patch uses that to synchronize
WKWebView with the right set of tiles.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:WebKit::]):
(-[WKWebView _updateVisibleContentRects]):

UIProcess/WebPageProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:

(WebKit::RemoteLayerTreeDrawingAreaProxy::nextLayerTreeTransactionID):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.messages.in:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::willCommitLayerTree):

WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

1:56 PM Changeset in webkit [170114] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Simplify WebCredential
https://bugs.webkit.org/show_bug.cgi?id=134036

Reviewed by Andreas Kling.

UIProcess/API/C/WKCredential.cpp:

(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
(WKCredentialCopyUser):

UIProcess/Authentication/AuthenticationChallengeProxy.cpp:

(WebKit::AuthenticationChallengeProxy::useCredential):

UIProcess/Authentication/WebCredential.cpp:

(WebKit::WebCredential::credential):
(WebKit::WebCredential::core): Deleted.
(WebKit::WebCredential::user): Deleted.

UIProcess/Authentication/WebCredential.h:

(WebKit::WebCredential::create): Deleted.

12:40 PM Changeset in webkit [170113] by andersca@apple.com

18 edits in trunk/Source

Adopt modern C++11 loops and fix WebArchive creation functions
https://bugs.webkit.org/show_bug.cgi?id=134032

Reviewed by Andreas Kling.

Source/WebCore:
Use modern loops in a couple of places, fix DocumentLoader::subresources() to return a Vector,
and stop using Vectors of PassRefPtrs.

WebCore.exp.in:
dom/Document.cpp:

(WebCore::Document::textInserted):
(WebCore::Document::textRemoved):
(WebCore::Document::textNodesMerged):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::subresources):
(WebCore::DocumentLoader::getSubresources): Deleted.

loader/DocumentLoader.h:
loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::dump):

loader/appcache/ApplicationCache.h:

(WebCore::ApplicationCache::resources):
(WebCore::ApplicationCache::begin): Deleted.
(WebCore::ApplicationCache::end): Deleted.

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):

loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::fallbackCacheGroupForURL):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::empty):
(WebCore::ApplicationCacheStorage::storeCopyOfCache):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

loader/archive/cf/LegacyWebArchive.h:
xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchDeferredEvents):

Source/WebKit/mac:

WebView/WebArchive.mm:

(-[WebArchive initWithMainResource:subresources:subframeArchives:]):

WebView/WebDataSource.mm:

(-[WebDataSource subresources]):

Source/WebKit2:

Shared/APIWebArchive.cpp:

(API::WebArchive::WebArchive):

12:19 PM Changeset in webkit [170112] by jonowells@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Style declaration editor: placeholder misaligned
https://bugs.webkit.org/show_bug.cgi?id=134012

Reviewed by Timothy Hatcher.

Removed a rule needed to align the placeholder for selectors in
the style declation text editors with no rules declared in
http://trac.webkit.org/changeset/170077. The necessary
rule has been added back to fix the issue.

UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):

12:19 PM Changeset in webkit [170111] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Give WKWebView on iOS a mobile user agent
https://bugs.webkit.org/show_bug.cgi?id=134034
<rdar://problem/17346489>

Reviewed by Enrica Casucci.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

12:14 PM Changeset in webkit [170110] by Joseph Pecoraro

2 edits in trunk/Source/WebKit2

Remove stale include, header was removed in r170101.

Unreviewed build fix.

Shared/API/Cocoa/WebKitPrivate.h:

11:57 AM Changeset in webkit [170109] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

DFGGraph::m_doubleConstantMap will not map 0 values correctly.
<https://webkit.org/b/133994>

Reviewed by Geoffrey Garen.

DFGGraph::m_doubleConstantsMap should not use a double as a key to its HashMap,
because it means two unfortunate things:

It will probably break for zero.
It will think that -0 is the same as +0 under some circumstances, size -0==+0 even though they are distinct values (for example 1/-0 != 1/+0).

The fix is to use std::unordered_map which does not require special empty
and deleted values, and to use the raw bits instead of the double value as
the key.

dfg/DFGGraph.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::addressOfDoubleConstant):

11:03 AM Changeset in webkit [170108] by andersca@apple.com

4 edits
1 add in trunk/Source

Add CF type cast function templates and use them in KeyedDecoder in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=134033

Reviewed by Sam Weinig.

Source/WebKit2:

Shared/cf/KeyedDecoder.cpp:

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::decodeBytes):
(WebKit::KeyedDecoder::decodeBool):
(WebKit::KeyedDecoder::decodeInt32):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeFloat):
(WebKit::KeyedDecoder::decodeDouble):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/cf/TypeCasts.h: Added.

(WTF::dynamic_cf_cast):
Returns null if the given CFTypeRef object doesn't have the right type.

(WTF::checked_cf_cast):
ASSERTs (with security implication) if the given CFTypeRef object is null or doesn't have the right type.

10:58 AM Changeset in webkit [170107] by achristensen@apple.com

5 edits in trunk/Source

Remove duplicate code using sdiv.
https://bugs.webkit.org/show_bug.cgi?id=133764

Reviewed by Daniel Bates.

Source/JavaScriptCore:

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::sdiv):
Make sdiv a template to match arm64.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
Remove duplicate code that was identical except for sdiv not being a template.

Source/WebCore:

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
Use template sdiv for apple armv7s and arm64.

10:53 AM Changeset in webkit [170106] by zandobersek@gmail.com

12 edits in trunk/Source/WebCore

ScriptExecutionContext::Task parameters should always be rvalue references
https://bugs.webkit.org/show_bug.cgi?id=133615

Reviewed by Darin Adler.

ScriptExecutionContext::Task parameters should be rvalue references as the
passed-in objects are always ScriptExecutionContext::Task rvalues that were
implicitly constructed from a lambda function or rvalues of objects that
derive from ScriptExecutionContext::Task.

This isn't really necessary since ScriptExecutionContext::Task is non-copyable
and we have to use move semantics anyway, but it makes it clear that these
objects are expiring rvalues that must be properly dealt with.

dom/Document.cpp:

(WebCore::Document::postTask):

dom/Document.h:
dom/ScriptExecutionContext.h:
workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::postTaskToLoader):
(WebCore::SharedWorkerProxy::postTaskForModeToWorkerGlobalScope):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::postTask):

workers/WorkerGlobalScope.h:
workers/WorkerLoaderProxy.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postTaskToLoader):
(WebCore::WorkerMessagingProxy::postTaskForModeToWorkerGlobalScope):

workers/WorkerMessagingProxy.h:
workers/WorkerRunLoop.cpp:

workers/WorkerRunLoop.h:

10:48 AM Changeset in webkit [170105] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] Bump the GLib and GTK+ dependencies in jhbuild-wayland.modules
https://bugs.webkit.org/show_bug.cgi?id=133971

Reviewed by Martin Robinson.

gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's required for

building for the Wayland target. The latest 3.12 version is required to match
the xdg_shell protocol version used in Weston 1.5. GLib dependency is bumped
as well due to GTK+ depending on a newer version.

10:21 AM Changeset in webkit [170104] by Lucas Forschler

4 edits in tags/Safari-538.41/Source/WebKit2

Merged r170100.

10:20 AM Changeset in webkit [170103] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[WinCairo] Compile errors when trying to compile CA code.
https://bugs.webkit.org/show_bug.cgi?id=134030

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-06-18
Reviewed by Simon Fraser.

WinCairo does not USE(CA).

WebCore.vcxproj/WebCore.vcxproj:
platform/graphics/ca/TileController.h:

10:08 AM Changeset in webkit [170102] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed, rolling out r170099.
https://bugs.webkit.org/show_bug.cgi?id=134031

Introduced a layouttest failure to the mac bots (Requested by
bradeeoh on #webkit).

Reverted changeset:

"Mark mathml/wbr-in-mroot-crash.html as "Timeout Pass""
https://bugs.webkit.org/show_bug.cgi?id=130353
http://trac.webkit.org/changeset/170099

10:02 AM Changeset in webkit [170101] by mitz@apple.com

6 edits
1 delete in trunk/Source/WebKit2

Remove the unused _WKBackForwardListDidChangeNotification.

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKBackForwardList.mm:
UIProcess/API/Cocoa/WKBackForwardListInternal.h:
UIProcess/API/Cocoa/WKBackForwardListPrivate.h: Removed.
UIProcess/Cocoa/NavigationState.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::LoaderClient::didChangeBackForwardList): Deleted.

WebKit2.xcodeproj/project.pbxproj:

8:09 AM Changeset in webkit [170100] by akling@apple.com

4 edits in trunk/Source/WebKit2

Set main thread QoS policies after IPC initialization.
<https://webkit.org/b/134014>

Something was flipping the QoS level back to "unspecified" after
setting it in the ChildProcess initialization code. Pending a better
understanding of what really happens, move the code to a later stage,
after IPC channels are up and running. Now the priority sticks.

Reviewed by Anders Carlsson.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

Shared/ChildProcess.cpp:

(WebKit::ChildProcess::initialize):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

6:03 AM WebKitGTK/2.4.x edited by berto@igalia.com

(diff)

12:45 AM Changeset in webkit [170099] by fred.wang@free.fr

3 edits in trunk/LayoutTests

Mark mathml/wbr-in-mroot-crash.html as "Timeout Pass"
https://bugs.webkit.org/show_bug.cgi?id=130353

Unreviewed gardening.

platform/efl/TestExpectations:
platform/mac/TestExpectations:

Jun 17, 2014:

11:54 PM Changeset in webkit [170098] by Lucas Forschler

5 edits in trunk/Source

Versioning.

11:52 PM Changeset in webkit [170097] by Lucas Forschler

1 copy in tags/Safari-538.41

New Tag.

11:21 PM Changeset in webkit [170096] by ryuan.choi@samsung.com

2 edits in trunk/Tools

[EFL] Turn on NOSNIFF in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=134010

Reviewed by Csaba Osztrogonác.

r164848 enabled NOSNIFF feature for EFL port but missed to change FeatureList.pm.

Scripts/webkitperl/FeatureList.pm: Turn on NOSNIFF for the EFL port.

11:19 PM Changeset in webkit [170095] by timothy_horton@apple.com

2 edits in trunk/Tools

MiniBrowser should show Web Content process pids in the window title
https://bugs.webkit.org/show_bug.cgi?id=134016

Reviewed by Sam Weinig.

MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):

9:27 PM Changeset in webkit [170094] by mitz@apple.com

3 edits in trunk/Source/WebKit2

[Cocoa] WKWebView's _privateBrowsingEnabled property is unused
https://bugs.webkit.org/show_bug.cgi?id=134013

Reviewed by Sam Weinig.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _privateBrowsingEnabled]): Deleted.
(-[WKWebView _setPrivateBrowsingEnabled:]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

7:48 PM Changeset in webkit [170093] by Alan Bujtas

2 edits in trunk/LayoutTests

Fix 'lint-test-files' warnings on run-webkit-test -2
https://bugs.webkit.org/show_bug.cgi?id=134011

Unreviewed.

Remove entries referring to non-existing files from TestExpectations.

platform/mac-wk2/TestExpectations:

7:30 PM Changeset in webkit [170092] by fpizlo@apple.com

17 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] PutStructure and PhantomPutStructure shouldn't leave the world in a clobbered state
https://bugs.webkit.org/show_bug.cgi?id=134002

Reviewed by Mark Hahnenberg.

The effect of this bug was that if we had a PutStructure or PhantomPutStructure then any
JSConstants would be in a Clobbered state, so we wouldn't take advantage of our knowledge
of the structure if that structure was watchable.

Also kill PhantomPutStructure.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransition):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

dfg/DFGNode.h:

(JSC::DFG::Node::hasTransition):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStructureAbstractValue.cpp:

(JSC::DFG::StructureAbstractValue::observeTransition):
(JSC::DFG::StructureAbstractValue::observeTransitions):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

dfg/DFGWatchableStructureWatchingPhase.cpp:

(JSC::DFG::WatchableStructureWatchingPhase::run):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePhantomPutStructure): Deleted.

6:35 PM Changeset in webkit [170091] by timothy_horton@apple.com

9 edits in trunk/Source

[iOS][wk2] Use ImageDocument to display subframe PDFs
https://bugs.webkit.org/show_bug.cgi?id=133944
<rdar://problem/17205983>

Reviewed by Dan Bates.

dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):
Make a ImageDocument to show our subframe PDF, if the setting is enabled.

html/ImageDocument.cpp:

(WebCore::ImageDocument::finishedParsing):
(WebCore::ImageDocument::createDocumentStructure):
Set the ResourceResponse on the ImageElement upon creation, instead of
when the load finishes. This way, when the internal CachedImage creates
its Image, it can have the correct MIME type for the response, and can
make a PDFDocumentImage if necessary.

We never noticed this before because CachedImage falls back to making a
BitmapImage, and that was the only case that was normally used.

Throw an explicit white background behind PDF ImageDocuments; PDFDocumentImage
paints with a transparent background, but when used as an ImageDocument
it seems reasonable to assume that there should be a white page background
(similar to what PDFPlugin and friends do).

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::createDocument):
Don't make a PDFDocument if we want to use an ImageDocument for this subframe PDF.

page/Settings.in:

platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isPDFMIMEType):

platform/MIMETypeRegistry.h:

Expose the already implemented pdfMIMETypes table just like all the rest.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Always use ImageDocument for subframe PDFs in WebKit2 on iOS.

6:16 PM Changeset in webkit [170090] by fpizlo@apple.com

12 edits
6 adds in branches/ftlopt

[ftlopt] DFG put_by_id should inline accesses with a slightly polymorphic base
https://bugs.webkit.org/show_bug.cgi?id=133964

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::appendVariant):
(JSC::PutByIdStatus::computeForStubInfo):

bytecode/PutByIdVariant.cpp:

(JSC::PutByIdVariant::oldStructureForTransition):
(JSC::PutByIdVariant::writesStructures):
(JSC::PutByIdVariant::reallocatesStorage):
(JSC::PutByIdVariant::attemptToMerge):
(JSC::PutByIdVariant::attemptToMergeTransitionWithReplace):
(JSC::PutByIdVariant::dumpInContext):

bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::PutByIdVariant):
(JSC::PutByIdVariant::replace):
(JSC::PutByIdVariant::transition):
(JSC::PutByIdVariant::structure):
(JSC::PutByIdVariant::oldStructure):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

dfg/DFGNode.cpp:

(JSC::DFG::MultiPutByOffsetData::writesStructures):
(JSC::DFG::MultiPutByOffsetData::reallocatesStorage):

ftl/FTLAbbreviations.h:

(JSC::FTL::getLinkage):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol):

LayoutTests:

js/regress/put-by-id-replace-and-transition-expected.txt: Added.
js/regress/put-by-id-replace-and-transition.html: Added.
js/regress/put-by-id-slightly-polymorphic-expected.txt: Added.
js/regress/put-by-id-slightly-polymorphic.html: Added.
js/regress/script-tests/put-by-id-replace-and-transition.js: Added.
js/regress/script-tests/put-by-id-slightly-polymorphic.js: Added.

5:32 PM Changeset in webkit [170089] by ryuan.choi@samsung.com

2 edits in trunk/Source/WebCore

Unreviewed build fix with ENABLE_NOSNIFF after r170021

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeTypeAllowedByNosniff):

5:28 PM Changeset in webkit [170088] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: PrettyPrinting regression on "var a=1"
https://bugs.webkit.org/show_bug.cgi?id=134001

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-17
Reviewed by Timothy Hatcher.

Previously operators did not get a token type. After a CodeMirror
update they now have a token type of "operator".

Tools/PrettyPrinting/CodeMirrorFormatters.js:
UserInterface/Views/CodeMirrorFormatters.js:

5:17 PM Changeset in webkit [170087] by andersca@apple.com

2 edits
1 add in trunk/Source/WebKit2

Make it possible to use -[NSBundle classNamed:] to find WebKitLegacy classes
https://bugs.webkit.org/show_bug.cgi?id=134008
<rdar://problem/17037600>

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/LegacyBundleForClass.mm: Added.
WebKit2.xcodeproj/project.pbxproj:

5:02 PM Changeset in webkit [170086] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r170082.
https://bugs.webkit.org/show_bug.cgi?id=134006

Breaks build. (Requested by mlam on #webkit).

Reverted changeset:

"DFGGraph::m_doubleConstantMap will not map 0 values
correctly."
https://bugs.webkit.org/show_bug.cgi?id=133994
http://trac.webkit.org/changeset/170082

5:02 PM Changeset in webkit [170085] by jonowells@apple.com

1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Added Jono Wells <jonowells@apple.com> to contributors.json file.

Scripts/webkitpy/common/config/contributors.json:

4:36 PM Changeset in webkit [170084] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Expose the location of website data
https://bugs.webkit.org/show_bug.cgi?id=134000
<rdar://problem/17350498>

Reviewed by Dan Bernstein.

Also, remove the bundle ID from the website data path for containerized apps.

Shared/mac/SandboxUtilities.cpp:

(WebKit::processIsAppSandboxed):

Shared/mac/SandboxUtilities.h:
UIProcess/API/Cocoa/WKProcessPool.mm:

(+[WKProcessPool _websiteDataURLForContainerWithURL:]):
(websiteDataDirectoryURL):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:

4:33 PM Changeset in webkit [170083] by commit-queue@webkit.org

12 edits in trunk/Source

Improve enter and exit fullscreen transition by using two step transition.
https://bugs.webkit.org/show_bug.cgi?id=133706

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-17
Reviewed by Simon Fraser.

Source/WebCore:
setupFullscreen, creates the fullscreen views ready to receive the video layer.
Once they are in place, didSetupFullscreen will move the video layer into the
new view hierarchy and initiate enterFullscreen to animate.

Reverse process for exit fullscreen.

WebCore.exp.in: Add exports.
platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController enterFullscreen:]):
Refactor into didSetupFullscreen.
(-[WebVideoFullscreenController didSetupFullscreen]):
Move the video layer once fullscreen is ready to receive it.
(-[WebVideoFullscreenController didExitFullscreen]):
Move the video layer back into we the web page, and initiate cleanup.
(-[WebVideoFullscreenController didCleanupFullscreen]):
Refactord cleanup from didExitFullscreen.

platform/ios/WebVideoFullscreenInterfaceAVKit.h: Add delcarations.
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
Refactored from enterFullscreen. Builds views ready to receive video layer.
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
Animates into fullscreen.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Animates from fullscreen. Cleanup is refactored into cleanupFullscreen()
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen):
Refactored from exitFullscreen(), removes views.

Source/WebKit2:
Add setupFullscreen()/didSetupFullscreen() and cleanupFullscreen()/didCleanupFullscreen()
to the proxies. And refactor enter/exit fullscreen to do some of the work in setup/cleanup.

UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Add four methods mentioned above.

UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

Add Setup/Cleanup functions.

UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID): does what enterFullscreen used to do.
(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): forward IPC.
(WebKit::WebVideoFullscreenManagerProxy::didSetupFullscreen): forward IPC.
(WebKit::WebVideoFullscreenManagerProxy::enterFullscreenWithID): changed to enterFullscreen

WebProcess/ios/WebVideoFullscreenManager.h: Add didSetup/didCleanup
WebProcess/ios/WebVideoFullscreenManager.messages.in: Add didSetup/didCleanup
WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::enterFullscreenForNode): refactored,
some implementation moves to didSetupFullscreen.
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
Moves the video layer over to the hosted layer, and initiates fullscreen.
(WebKit::WebVideoFullscreenManager::didExitFullscreen): refactored,
some implementation moves to didCleanupFullscreen, and initiates cleanup.
(WebKit::WebVideoFullscreenManager::didCleanupFullscreen):
Final cleanup refactored from didExitFullscreen()

4:05 PM Changeset in webkit [170082] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

DFGGraph::m_doubleConstantMap will not map 0 values correctly.
<https://webkit.org/b/133994>

Reviewed by Geoffrey Garen.

DFGGraph::m_doubleConstantsMap should not use a double as a key to its HashMap,
because it means two unfortunate things:

It will probably break for zero.
It will think that -0 is the same as +0 under some circumstances, size -0==+0 even though they are distinct values (for example 1/-0 != 1/+0).

The fix is to use std::unordered_map which does not require special empty
and deleted values, and to use the raw bits instead of the double value as
the key.

dfg/DFGGraph.h:
dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::addressOfDoubleConstant):

3:35 PM Changeset in webkit [170081] by tgergely.u-szeged@partner.samsung.com

2 edits in trunk/Source/WTF

Misused PLATFORM(MIDDLE_ENDIAN) and PLATFORM(BIG_ENDIAN).
https://bugs.webkit.org/show_bug.cgi?id=128301

Reviewed by Daniel Bates.

Endianness is a CPU attribute, not a PLATFORM. PLATFORM() macro is replaced to CPU().

wtf/text/ASCIIFastPath.h:

(WTF::copyLCharsFromUCharSource):

3:35 PM Changeset in webkit [170080] by jonowells@apple.com

21 edits in trunk/Source/WebInspectorUI

Web Inspector: Two lines in CSS rule are hidden until resize or click
https://bugs.webkit.org/show_bug.cgi?id=133951

Reviewed by Joseph Pecoraro.

Update to CodeMirror 4.2 fixed the issue.

Tools/PrettyPrinting/codemirror.js:
Tools/PrettyPrinting/css.js:
Tools/PrettyPrinting/javascript.js:
UserInterface/External/CodeMirror/clojure.js:
UserInterface/External/CodeMirror/closebrackets.js:
UserInterface/External/CodeMirror/codemirror.js:
UserInterface/External/CodeMirror/coffeescript.js:
UserInterface/External/CodeMirror/comment.js:
UserInterface/External/CodeMirror/css.js:
UserInterface/External/CodeMirror/htmlmixed.js:
UserInterface/External/CodeMirror/javascript.js:
UserInterface/External/CodeMirror/livescript.js:
UserInterface/External/CodeMirror/matchbrackets.js:
UserInterface/External/CodeMirror/overlay.js:
UserInterface/External/CodeMirror/placeholder.js:
UserInterface/External/CodeMirror/runmode.js:
UserInterface/External/CodeMirror/sass.js:
UserInterface/External/CodeMirror/searchcursor.js:
UserInterface/External/CodeMirror/sql.js:
UserInterface/External/CodeMirror/xml.js:

Update CodeMirror 4.1 to CodeMirror 4.2.0.

3:29 PM Changeset in webkit [170079] by oliver@apple.com

8 edits
3 adds in trunk

Fix error messages for incorrect hex literals
https://bugs.webkit.org/show_bug.cgi?id=133998

Reviewed by Mark Lam.

Source/JavaScriptCore:
Ensure that the error messages for bogus hex literals actually
make sense.

parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

parser/ParserTokens.h:

LayoutTests:
Update tests for sane error messages.

sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.1_T2-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T1-expected.txt:
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.3_Numeric_Literals/S7.8.3_A6.2_T2-expected.txt:

3:27 PM Changeset in webkit [170078] by commit-queue@webkit.org

7 edits in trunk

[GTK] Fix the handling of resize events after r169505.
https://bugs.webkit.org/show_bug.cgi?id=133517

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-17
Reviewed by Martin Robinson.

Tools:

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
need at least 900x640 pixels to pass.

Scripts/webkitpy/port/xvfbdriver_unittest.py:

(XvfbDriverTest.test_start_no_pixel_tests): Update resolution.
(XvfbDriverTest.test_start_pixel_tests): Update resolution.
(XvfbDriverTest.test_start_arbitrary_worker_number): Update resolution.
(XvfbDriverTest.test_start_next_worker): Update resolution.

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::PlatformWebView): gtk_widget_size_allocate should
be requested over the main widget instead of the window.
(WTR::PlatformWebView::resizeTo): Changed this to call setWindowFrame like
the Mac port.
(WTR::PlatformWebView::windowFrame): Remove legacy ifdef for GTK2.
(WTR::PlatformWebView::setWindowFrame): Set the size and position
of the Window and the web view.

LayoutTests:

platform/gtk/TestExpectations: Remove the expectations for the

tests that now pass.

platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:

Rebaseline results.

3:26 PM Changeset in webkit [170077] by jonowells@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: style declaration editor: visual highlight doesn't match actual selected text
https://bugs.webkit.org/show_bug.cgi?id=133965

Reviewed by Joseph Pecoraro.

Update styles for css style editor to fix highlighting visual mismatch glitch.

UserInterface/Views/CSSStyleDeclarationTextEditor.css:

(.css-style-text-editor > .CodeMirror .CodeMirror-placeholder):
(.css-style-text-editor > .CodeMirror pre):
(.css-style-text-editor.read-only > .CodeMirror pre):
Updated styles to eliminate highlight mismatch by adjusting the padding and
text-indent values.

3:17 PM Changeset in webkit [170076] by mmirman@apple.com

3 edits in trunk/Source/JavaScriptCore

Fixes bug where building JSC sometimes crashes at build-symbol-table-index.py. Also adds licenses.
https://bugs.webkit.org/show_bug.cgi?id=133814

Reviewed by Filip Pizlo.

Adds the "shopt -s nullglob" line necessary to prevent the loop in the shell
script from using "*.o" as a file when no other files in the directory exist.

build-symbol-table-index.sh: Added license.
copy-llvm-ir-to-derived-sources.sh: Added license and "shopt -s nullglob" line.

3:05 PM Changeset in webkit [170075] by eric.carlson@apple.com

3 edits in trunk/Source/WebKit2

[iOS] enable background audio in WK2
https://bugs.webkit.org/show_bug.cgi?id=133996

Reviewed by Jer Noble.

WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist: Mark as

allowed to play audio when in the background.

WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Ditto.

2:50 PM Changeset in webkit [170074] by weinig@apple.com

19 edits in trunk/Source/WebCore

Remove unnecessary Structure flags from generated bindings
https://bugs.webkit.org/show_bug.cgi?id=133992

Reviewed by Daniel Bates.

Remove OverridesVisitChildren flag from DOM prototype objects. They never implement visitChildren.
Remove OverridesGetOwnPropertySlot and ImplementsHasInstance from DOM constructor objects. getOwnPropertySlot is never implemented and ImplementsHasInstance is inherited automatically from DOMConstructorObject.
If we are not changing any flags, we now don't emit StructureFlags at all for the class.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePrototypeDeclaration):
(GenerateConstructorDeclaration):

bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObjectPrototype::JSTestActiveDOMObjectPrototype):
(WebCore::JSTestActiveDOMObjectConstructor::createStructure):

bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetterPrototype::JSTestCustomNamedGetterPrototype):
(WebCore::JSTestCustomNamedGetterConstructor::createStructure):

bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructorPrototype::JSTestEventConstructorPrototype):

bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTargetPrototype::JSTestEventTargetPrototype):
(WebCore::JSTestEventTargetConstructor::createStructure):

bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(WebCore::JSTestExceptionConstructor::createStructure):

bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachablePrototype::JSTestGenerateIsReachablePrototype):
(WebCore::JSTestGenerateIsReachableConstructor::createStructure):

bindings/scripts/test/JS/JSTestInterface.h:

(WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructorPrototype::JSTestNamedConstructorPrototype):
(WebCore::JSTestNamedConstructorConstructor::createStructure):

bindings/scripts/test/JS/JSTestNode.h:

(WebCore::JSTestNodePrototype::JSTestNodePrototype):

bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministicPrototype::JSTestNondeterministicPrototype):
(WebCore::JSTestNondeterministicConstructor::createStructure):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObjPrototype::JSTestObjPrototype):

bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructorsPrototype::JSTestOverloadedConstructorsPrototype):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefsPrototype::JSTestTypedefsPrototype):

bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattributePrototype::JSattributePrototype):
(WebCore::JSattributeConstructor::createStructure):

bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonlyPrototype::JSreadonlyPrototype):
(WebCore::JSreadonlyConstructor::createStructure):

2:48 PM Changeset in webkit [170073] by mmirman@apple.com

2 edits in trunk/Tools

Unreviewed. Added self to list of committers.

2:28 PM Changeset in webkit [170072] by mmaxfield@apple.com

17 edits
2 adds in trunk

[iOS] Input type=time elements styled with SVG fonts have 0 width
https://bugs.webkit.org/show_bug.cgi?id=133524

Reviewed by Simon Fraser.

Source/WebCore:
Refactor how the LocalizedDateCache returns maximum widths for input elements. Currently,
measuring the width of an SVG font requires a RenderObject for context, which the
LocalizedDateCache can't know about (it would be a platform violation). Instead, the
LocalizedDateCache can return the strings that it would use to measure the width, and the
caller can actually run the width computation.

Test: fast/forms/time-input-svg-font.html

platform/text/PlatformLocale.h:
platform/text/ios/LocalizedDateCache.h:
platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::maximumWidthForDateType): Take a delegate which can
measure text
(WebCore::LocalizedDateCache::calculateMaximumWidth): Perform maximum width
computation using delegate.

platform/text/mac/LocaleMac.h:
platform/text/mac/LocaleMac.mm:

(WebCore::LocaleMac::formatDateTime):
(WebCore::LocaleMac::maximumWidthForDateType): Deleted. Short-circuit this and go
directly to the LocalizedDateCache. This makes sense because we have to explicitly
insert computed values back into the cache in this new model.

rendering/RenderThemeIOS.mm:

(WebCore::adjustInputElementButtonStyle): Create a delegate and pass it to the
LocalizedDateCache

LayoutTests:
Simply render a variety of input elements with SVG fonts, and make sure they have sane widths. Note that this
test is not platform-specific, even though the bug is.

fast/forms/time-input-svg-font-expected.txt: Added.
fast/forms/time-input-svg-font.html: Added.

2:06 PM Changeset in webkit [170071] by Simon Fraser

24 edits
2 adds in trunk

[UI-side compositing] fix reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=133942

Reviewed by Tim Horton.

Source/WebCore:

Fix reflections on composited layers. There are two main set of changes.

First, a PlatformCALayerRemote which is a clone has to track the layer
it is a clone of, so it knows where to grab the contents from in the UI process.
This layer may be told that its contents need updating out of order during
recursiveBuildTransaction(), so we need some small changes in RemoteLayerTreeContext
to allow a layer to add itself to the set of layers requiring commit.

In the UI process, a new step is added to RemoteLayerTreeHost::updateLayerTree()
to go through clones, and copy their contents from the origin layer.

The second set of changes makes platformCALayerLayerDidDisplay() work for
UI-side compositing by not taking a PlatformLayer*, but instead a PlatformCALayer*.
PlatformCALayer::setContentsChanged() changed to copyContentsFromLayer() so we know
what the origin layer is.

Test: compositing/reflections/repaint-with-reflection.html

WebCore.exp.in:
platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::layerDidDisplay): Deleted.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerLayerDidDisplay): Deleted.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::layerDidDisplay):
(WebCore::GraphicsLayerCA::findOrMakeClone):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerLayerDidDisplay):

platform/graphics/ca/mac/PlatformCALayerMac.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::copyContentsFromLayer):
(PlatformCALayerMac::superlayer):
(PlatformCALayerMac::setContentsChanged): Deleted.

platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

(PlatformCALayerWinInternal::displayCallback):

platform/graphics/mac/WebLayer.mm:

(-[WebSimpleLayer display]):

Source/WebKit2:

Fix reflections on composited layers. There are two main set of changes.

In the UI process, a new step is added to RemoteLayerTreeHost::updateLayerTree()
to go through clones, and copy their contents from the origin layer.

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::display): Remove the early return so we can always
call platformCALayerLayerDidDisplay().

Shared/mac/RemoteLayerTreeTransaction.h:
Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::LayerProperties):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::encode):
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::dumpChangedLayers):

UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):

WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::clone):
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
(WebKit::PlatformCALayerRemote::copyContentsFromLayer):
(WebKit::PlatformCALayerRemote::setClonedLayer):
(WebKit::PlatformCALayerRemote::setContentsChanged): Deleted.

WebProcess/WebPage/mac/PlatformCALayerRemote.h:

(WebKit::PlatformCALayerRemote::properties):
(WebKit::PlatformCALayerRemote::context):

LayoutTests:

Test with a reflected div, that repaints on a timer to test backing
store updating on the clone.

compositing/reflections/repaint-with-reflection-expected.html: Added.
compositing/reflections/repaint-with-reflection.html: Added.

1:19 PM Changeset in webkit [170070] by andersca@apple.com

5 edits in trunk/Source/WebCore

Use strongly typed enums for AnimationState and AnimationInputState
https://bugs.webkit.org/show_bug.cgi?id=133988

Reviewed by Tim Horton.

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::AnimationBase):
(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::updatePlayState):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::beginAnimationUpdateTime):

page/animation/AnimationBase.h:

(WebCore::AnimationBase::clear):
(WebCore::AnimationBase::onAnimationStartResponse):
(WebCore::AnimationBase::waitingToStart):
(WebCore::AnimationBase::preActive):
(WebCore::AnimationBase::postActive):
(WebCore::AnimationBase::fillingForwards):
(WebCore::AnimationBase::paused):
(WebCore::AnimationBase::inPausedState):
(WebCore::AnimationBase::isNew):
(WebCore::AnimationBase::waitingForStartTime):
(WebCore::AnimationBase::waitingForStyleAvailable):
(WebCore::AnimationBase::isAnimatingProperty):
(WebCore::AnimationBase::styleAvailable):
(WebCore::AnimationBase::compositeAnimation):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::onAnimationEnd):
(WebCore::ImplicitAnimation::sendTransitionEvent):
(WebCore::ImplicitAnimation::reset):
(WebCore::ImplicitAnimation::setOverridden):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::sendAnimationEvent):

1:17 PM Changeset in webkit [170069] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Remove session state methods from WKBrowsingContextController
https://bugs.webkit.org/show_bug.cgi?id=133995

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKBrowsingContextController.h:
UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController sessionState]): Deleted.
(-[WKBrowsingContextController restoreFromSessionState:]): Deleted.

12:53 PM Changeset in webkit [170068] by commit-queue@webkit.org

6 edits in trunk

Unreviewed, rolling out r170058.
https://bugs.webkit.org/show_bug.cgi?id=133993

Caused 4 webkitpy failures on the bots (Requested by bradee-oh
on #webkit).

Reverted changeset:

"[GTK] Fix the handling of resize events after r169505."
https://bugs.webkit.org/show_bug.cgi?id=133517
http://trac.webkit.org/changeset/170058

12:17 PM Changeset in webkit [170067] by beidson@apple.com

3 edits in trunk/Source/WebKit2

Only show telephone number highlights if only one number is selected
<rdar://problem/16874568> and https://bugs.webkit.org/show_bug.cgi?id=133989

Reviewed by Tim Horton.

Add a flag to TelephoneNumberData to remember if it was hovered over:

WebProcess/WebPage/TelephoneNumberOverlayController.h:

(WebKit::TelephoneNumberData::hovered):
(WebKit::TelephoneNumberData::setHovered):
(WebKit::TelephoneNumberData::TelephoneNumberData):

WebProcess/WebPage/mac/TelephoneNumberOverlayControllerMac.mm:

(WebKit::TelephoneNumberOverlayController::drawRect): Only draw the highlight if one

phone number is selected.

(WebKit::TelephoneNumberOverlayController::mouseEvent): Update the hover state of the

current phone number, and setNeedsDisplay if the hover state changes.

(WebKit::TelephoneNumberOverlayController::clearHighlights):

12:04 PM Changeset in webkit [170066] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

Remove WKContentView _setFindIndicator:fadeOut:animate:
https://bugs.webkit.org/show_bug.cgi?id=133976

Reviewed by Anders Carlsson.

Find indicators are totally internal to FindController on iOS,
we don't need to push them to the content view via PageClient,
so this code was unused.

UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setFindIndicator):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _setFindIndicator:WebKit::fadeOut:animate:]): Deleted.

12:03 PM Changeset in webkit [170065] by akling@apple.com

7 edits in trunk/Source

Web process main thread priority is lower than some network process threads.
<https://webkit.org/b/133987>
<rdar://problem/17330300>

Source/WebKit2:
Mark the main thread as "user initiated" in process entry.

Reviewed by Maciej Stachowiak.

Shared/ChildProcess.cpp:

(WebKit::ChildProcess::initialize):

Source/WTF:
Bring all of our threads to the appropriate priority level by opting in to the
threading QoS APIs. By marking them "user initiated", they still yield to UI
interaction, but take priority over background tasks.

Reviewed by Maciej Stachowiak.

wtf/Platform.h:
wtf/Threading.cpp:

(WTF::setCurrentThreadIsUserInitiated):

wtf/Threading.h:
wtf/ThreadingPthreads.cpp:

(WTF::createThreadInternal):

12:01 PM Changeset in webkit [170064] by fpizlo@apple.com

8 edits in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Fold constant Phis
https://bugs.webkit.org/show_bug.cgi?id=133967

Reviewed by Mark Hahnenberg.

It's surprising but we didn't really do this before. Or, rather, we only did it
incidentally when we would likely crash if it ever happened.

Making this work required cleaning up the validater a bit, so I did that too. I also added
mayExit() validation for nodes that didn't have origin.forExit (i.e. nodes that end up in
the Phi header of basic blocks). But this required beefing up mayExit() a bit.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGAdjacencyList.h:

(JSC::DFG::AdjacencyList::isEmpty):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::fixUpsilons):

dfg/DFGInPlaceAbstractState.h:
dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):

dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateSSA):

12:00 PM Changeset in webkit [170063] by akling@apple.com

2 edits in trunk/Source/WebCore

Avoid synchronous layout in window.scrollTo(0,0) when already at (0,0)
<https://webkit.org/b/133893>

Going from 0,0 to 0,0 is a no-op since there is no way a layout will
affect the current scroll position.

We don't send scroll events when moving to the previous position,
so this change is not observable.

Reviewed by Anders Carlsson.

page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollTo):

11:02 AM Changeset in webkit [170062] by commit-queue@webkit.org

2 edits in trunk/Tools

Update import-w3c-tests to reflect current W3C test repo directory structure
https://bugs.webkit.org/show_bug.cgi?id=133460

Patch by Rebecca Hauck <rhauck@adobe.com> on 2014-06-17
Reviewed by Bem Jones-Bey.

Removed all references to test status, which are no longer reflected in the
directory names in the W3C CSS test repo. No tests are required for this
change, the existing tests pass.

Scripts/webkitpy/w3c/test_importer.py:

(main):
(TestImporter.init):
(TestImporter.find_importable_tests):
(TestImporter.setup_destination_directory):
(TestImporter.write_import_log):
(TestImporter.update_test_status): Deleted.

10:59 AM Changeset in webkit [170061] by achristensen@apple.com

2 edits in trunk/Source/WTF

Enable css jit for armv7 on iOS.
https://bugs.webkit.org/show_bug.cgi?id=133961
<rdar://problem/17310631>

Reviewed by Andreas Kling.

wtf/Platform.h:

Enable css jit for ARM thumb on iOS.

10:52 AM Changeset in webkit [170060] by fpizlo@apple.com

19 edits
2 adds in branches/ftlopt/Source/JavaScriptCore

[ftlopt] Get rid of NodeDoesNotExit and also get rid of StoreEliminationPhase
https://bugs.webkit.org/show_bug.cgi?id=133985

Reviewed by Michael Saboff and Mark Hahnenberg.

Store elimination phase has never been very profitable, and now that LLVM can do dead
store elimination for us, this phase is just completely pointless.

This phase is also the primary user of NodeDoesNotExit, which is a flag that the CFA
computes. It computes it poorly and we often get bugs in it. It's also a lot of code to
maintain.

This patch does introduce a new mayExit() calculator that is independent of the CFA and
should be enough for most of the previous NodeDoesNotExit users. Currently it's only used
for assertions in the DFG backend, but we could use it if we ever brought back any of the
other optimizations that previously relied upon NodeDoesNotExit.

This is performance-neutral, except for SunSpider, where it's a speed-up.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::filterEdgeByUse):
(JSC::DFG::AbstractInterpreter::filterByType):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::startExecuting):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase):
(JSC::DFG::CSEPhase::invalidationPointElimination):
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
(JSC::DFG::CSEPhase::performBlockCSE):
(JSC::DFG::performCSE):
(JSC::DFG::CSEPhase::globalVarStoreElimination): Deleted.
(JSC::DFG::CSEPhase::scopedVarStoreElimination): Deleted.
(JSC::DFG::CSEPhase::putStructureStoreElimination): Deleted.
(JSC::DFG::CSEPhase::putByOffsetStoreElimination): Deleted.
(JSC::DFG::CSEPhase::SetLocalStoreEliminationResult::SetLocalStoreEliminationResult): Deleted.
(JSC::DFG::performStoreElimination): Deleted.

dfg/DFGCSEPhase.h:
dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::resetExitStates): Deleted.

dfg/DFGGraph.h:
dfg/DFGMayExit.cpp: Added.

(JSC::DFG::mayExit):

dfg/DFGMayExit.h: Added.
dfg/DFGNode.h:

(JSC::DFG::Node::mergeFlags):
(JSC::DFG::Node::filterFlags):
(JSC::DFG::Node::setCanExit): Deleted.
(JSC::DFG::Node::canExit): Deleted.

dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

dfg/DFGNodeFlags.h:
dfg/DFGNodeType.h:
dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::terminateSpeculativeExecution):
(JSC::DFG::SpeculativeJIT::bail):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:49 AM Changeset in webkit [170059] by achristensen@apple.com

3 edits in trunk/Source/WebCore

Fix css jit register usage on armv7.
https://bugs.webkit.org/show_bug.cgi?id=133952

Reviewed by Benjamin Poulain.

cssjit/RegisterAllocator.h:

List r7 as a callee saved register, which it is.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateEpilogue):
Save r6, which is used as a temporary register and must be preserved.

10:49 AM Changeset in webkit [170058] by commit-queue@webkit.org

6 edits in trunk

[GTK] Fix the handling of resize events after r169505.
https://bugs.webkit.org/show_bug.cgi?id=133517

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-17
Reviewed by Martin Robinson.

Tools:

Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._start): Set the resolution of Xvfb to XGA (1024x768).
The tests css3/viewport-percentage-lengths/viewport-percentage-lengths-*.html
need at least 900x640 pixels to pass.

WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

LayoutTests:

platform/gtk/TestExpectations: Remove the expectations for the tests

that now pass.

platform/gtk/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt:

Rebaseline results.

10:29 AM Changeset in webkit [170057] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlock in enclosingBoxModelObject()
https://bugs.webkit.org/show_bug.cgi?id=133978

Patch by Miyoung Shin <myid.shin@samsung.com> on 2014-06-17
Reviewed by Andreas Kling.

Just a straightforward conversion from pointers to references.

No new tests, no behavior change.

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paint):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):

rendering/RenderObject.cpp:

(WebCore::RenderObject::enclosingBoxModelObject):

rendering/RenderObject.h:

10:23 AM Changeset in webkit [170056] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Add SPI to get the NSURLRequest from a WKNavigationResponse
https://bugs.webkit.org/show_bug.cgi?id=133984
<rdar://problem/17006399>

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKNavigationResponse.mm:

(-[WKNavigationResponse _request]):

UIProcess/API/Cocoa/WKNavigationResponseInternal.h:
UIProcess/API/Cocoa/WKNavigationResponsePrivate.h:
UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForResponse):

9:16 AM Changeset in webkit [170055] by mitz@apple.com

5 edits in trunk

String::isolatedCopy doesn’t return an isolated copy when used on an rvalue reference
https://bugs.webkit.org/show_bug.cgi?id=133968

Reviewed by Anders Carlsson.

Source/WTF:
Made the rvalue reference overload of isolatedCopy() non-const, so that std::move(*this) is
an rvalue reference that can be moved, rather than copied, into the returned String.

wtf/text/WTFString.cpp:

(WTF::String::isolatedCopy):

wtf/text/WTFString.h:

Tools:

TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST): Added a test that an isolated copy of an rvalue reference doesn’t
share an impl() with the original.

8:32 AM 001460c_20140521-043020_962862386.html attached to BuildingQtOnLinux by itsupport@camara.ie

6:29 AM Changeset in webkit [170054] by gyuyoung.kim@samsung.com

4 edits in trunk

[EFL][WK2] Skip failing EFL API tests
https://bugs.webkit.org/show_bug.cgi?id=133981

Reviewed by Csaba Osztrogonác.

UserMessage, WillLoad and test_ewk2_view have been failed since r169784.

Source/WebKit2:

PlatformEfl.cmake:

Tools:

TestWebKitAPI/PlatformEfl.cmake:

4:31 AM Changeset in webkit [170053] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Add expectations for three failing/flaky layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133977

Unreviewed EFL gardening.

Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-17

platform/efl/TestExpectations:

2:58 AM Changeset in webkit [170052] by zandobersek@gmail.com

2 edits in trunk

Remove the USE_GTK2=1 branch in OptionsGTK.cmake. This used to determine
GTK+ and GDK libraries and include directories for the GTK+ 2 dependency,
but we now only support GTK+ 3. The GTK+ 2 dependency is still required
by the plugin process, but it is searched and utilized separately.

Rubber-stamped by Carlos Garcia Campos.

Source/cmake/OptionsGTK.cmake:

12:49 AM Changeset in webkit [170051] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Cache the gst_query_get_n_buffering_ranges() return value for the for-loop conditional
https://bugs.webkit.org/show_bug.cgi?id=133953

Reviewed by Philippe Normand.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::buffered): Avoid the extra call in the for-loop
conditional expression by caching the return value of gst_query_get_n_buffering_ranges().

12:47 AM Changeset in webkit [170050] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Avoid Vector<char> copies in the OffsetBuffer constructor
https://bugs.webkit.org/show_bug.cgi?id=133956

Reviewed by Andreas Kling.

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::OffsetBuffer::OffsetBuffer): Take the Vector parameter by value and
move it into the member variable.
(WebCore::openFunc): Move the Vector object into the OffsetBuffer constructor.

12:43 AM Changeset in webkit [170049] by jer.noble@apple.com

3 edits
2 adds in trunk

[MSE] Overwritten samples are removed from buffered ranges using decode times; added samples using presentation times
https://bugs.webkit.org/show_bug.cgi?id=133959

Reviewed by Eric Carlson.

Source/WebCore:
Test: media/media-source/media-source-overlapping-append-buffered.html

Explicitly call presentationTime() on removed samples, rather than implicitly asking for the iterator's "first"
member. When iterating over samples, "first" can either be presentation time, or decode time, depending on which
iteration method is called. In the case of removing samples, this was using the decode time incorrectly.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

media/media-source/media-source-overlapping-append-buffered-expected.txt: Added.
media/media-source/media-source-overlapping-append-buffered.html: Added.

12:42 AM Changeset in webkit [170048] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix for the GTK+ port. Removing the *Callback::create() wrappings
for lambda callbacks that aren't required anymore after the changes in r170041.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_can_execute_editing_command):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_save):
(webkit_web_view_save_to_file):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed