Timeline



Jan 10, 2015:

3:29 PM Changeset in webkit [178243] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

build-webkit: silence output of 'which'
​https://bugs.webkit.org/show_bug.cgi?id=140278

Patch by Michael Catanzaro <Michael Catanzaro> on 2015-01-10
Reviewed by Daniel Bates.

Use a more elegent test for the existance of ninja and eclipse.

  • Scripts/webkitdirs.pm:

(commandExists): Don't assume the command supports --version
(canUseNinja): Use commandExists()
(canUseEclipse): Use commandExists()

2:02 PM Changeset in webkit [178242] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed build fix. Removed the stale code.

  • public/admin/triggerables.php:
1:57 PM Changeset in webkit [178241] by mitz@apple.com
  • 2 edits in trunk

[Xcode, iOS] Files are recompiled when alternating between using make and the Xcode IDE
​https://bugs.webkit.org/show_bug.cgi?id=140339

Reviewed by Mark Rowe.

  • Makefile.shared: Run xcodebuild with the same PATH with which the Xcode IDE runs. This

prevents unnecessary rebuilding due to PATH differences.

10:59 AM Changeset in webkit [178240] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix for !ENABLE(INSPECTOR) builds after r178201.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willReceiveResourceResponse):

6:57 AM Changeset in webkit [178239] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/win

[WinCairo] Accelerated compositing has stopped working.
​https://bugs.webkit.org/show_bug.cgi?id=140334

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2015-01-10
Reviewed by Brent Fulgham.

The method GraphicsLayerTextureMapper::flushCompositingStateForThisLayerOnly()
is not updating the backingstore anymore, we need to call the new method
GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers().

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::flushPendingLayerChanges):
(AcceleratedCompositingContext::flushAndRenderLayers):

4:07 AM Changeset in webkit [178238] by yoon@igalia.com
  • 3 edits in trunk/Source/WebKit2

[ThreadedCompositor] Prevent excessive rendering call.
​https://bugs.webkit.org/show_bug.cgi?id=140297

Reviewed by Žan Doberšek.

Not to waste CPU time on waiting V-Sync interval, the update timer of
compositing thread should be throttled.

In case of updating scene state, this update timer should be called as
soon as possible. However, when CoordinatedGraphicsScene requests update
viewport to advance the animations, this call should be scheduled for
a next frame.

No new tests. No change in functionality.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::setUpdateTimer):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::ThreadedCompositor::setNeedsDisplay):
(WebKit::ThreadedCompositor::updateViewport):
(WebKit::ThreadedCompositor::scheduleDisplayImmediately):
(WebKit::ThreadedCompositor::didChangeVisibleRect):
(WebKit::ThreadedCompositor::scheduleDisplayIfNeeded): Deleted.

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
12:49 AM Changeset in webkit [178237] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140327

Reviewed by Sam Weinig.

Move 'kerning' / 'paint-order' / 'stroke-dasharray' SVG CSS properties
to the new StyleBuilder by introducing the necessary converters in
StyleBuilderConverter.

  • css/CSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertSVGLength):
(WebCore::StyleBuilderConverter::convertSVGLengthVector):
(WebCore::StyleBuilderConverter::convertStrokeDashArray):
(WebCore::StyleBuilderConverter::convertPaintOrder):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::fromCSSPrimitiveValue):

  • svg/SVGLength.h:
12:01 AM Changeset in webkit [178236] by weinig@apple.com
  • 3 edits in trunk/Tools

Update the output format for run-api-tests
​https://bugs.webkit.org/show_bug.cgi?id=140332

Reviewed by Dan Bernstein.

Changes the output format for run-api-tests be a bit simpler (no longer
indented based on suite, as we were not really using suite very well) but
also include details in the case of failure.

Changes verbose mode to no longer spew out the gtest default printer output,
as the custom printer now includes the failure information.

  • Scripts/run-api-tests:

(runTestsBySuite):
(runTest):
Augment the custom gtest printer by replacing the tokens "PASS" and "FAIL"
with colorized variants and strip out leaks spew (the leaks can be added back using
the new --show-leaks argument).

  • TestWebKitAPI/TestsController.cpp:

(TestWebKitAPI::Printer::OnTestPartResult):
(TestWebKitAPI::Printer::OnTestEnd):
(TestWebKitAPI::TestsController::run):
Implement a custom result printer that just prints out the information we want.

Jan 9, 2015:

9:48 PM Changeset in webkit [178235] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the GTK and EFL builds.

  • CMakeLists.txt:
9:26 PM Changeset in webkit [178234] by rniwa@webkit.org
  • 13 edits
    7 adds in trunk/Websites/perf.webkit.org

Perf dashboard should have the ability to post A/B testing builds
​https://bugs.webkit.org/show_bug.cgi?id=140317

Rubber-stamped by Simon Fraser.

This patch adds the support for triggering A/B testing from the perf dashboard.

We add a few new tables to the database. "build_triggerables", which represents a set of builders
that accept A/B testing. "triggerable_repositories" associates each "triggerable" with a fixed set
of repositories for which an arbitrary revision can be specified for A/B testing.
"triggerable_configurations" specifies a triggerable available on a given test on a given platform.
"roots" table which specifies the revision used in a given root set in each repository.

  • init-database.sql: Added "build_triggerables", "triggerable_repositories",

"triggerable_configurations", and "roots" tables. Added references to "build_triggerables",
"platforms", and "tests" tables as well as columns to store status, status url, and creation time
to build_requests table. Also made each test group's name unique in a given analysis task as it
would be confusing to have multiple test groups of the same name.

  • public/admin/tests.php: Added the UI and the code to associate a test with a triggerable.
  • public/admin/triggerables.php: Added. Manages the list of triggerables as well as repositories

for which a specific revision can be set in an A/B testing on a given triggerable.

  • public/api/build-requests.php: Added. Returns the list of open build requests on a specified

triggerable. Also updates the status' and the status urls of specified build requests when
buildRequestUpdates is provided in the raw POST data.
(main):

  • public/api/runs.php:

(fetch_runs_for_config): Don't include results associated with a build request, meaning they are
results of an A/B testing.

  • public/api/test-groups.php:

(main): Use the newly added BuildRequestsFetcher. Also merged fetch_test_groups_for_task back.

  • public/api/triggerables.php: Added.

(main): Returns a list of triggerables or a triggerable associated with a given analysis task.

  • public/include/admin-header.php:
  • public/include/build-requests-fetcher.php: Added. Extracted from public/api/test-groups.php.

(BuildRequestsFetcher): This class abstracts the process of fetching a list of builds requests
and root sets used in those requests.D
(BuildRequestsFetcher::construct):
(BuildRequestsFetcher::fetch_for_task):
(BuildRequestsFetcher::fetch_for_group):
(BuildRequestsFetcher::fetch_incomplete_requests_for_triggerable):
(BuildRequestsFetcher::has_results):
(BuildRequestsFetcher::results):
(BuildRequestsFetcher::results_with_resolved_ids):
(BuildRequestsFetcher::results_internal):
(BuildRequestsFetcher::root_sets):
(BuildRequestsFetcher::fetch_roots_for_set):

  • public/include/db.php:

(Database::prefixed_column_names): Don't return "$prefix_" when there are no columns.
(Database::insert_row): Support taking an empty array for values. This is useful in "root_sets"
table since it only has the primary key, id, column.
(Database::select_or_insert_row):
(Database::update_or_insert_row):
(Database::update_row): Added.
(Database::_select_update_or_insert_row): Takes an extra argument specifying whether a new row
should be inserted when no row matches the specified criteria. This is used while updating
build_requests' status and url in public/api/build-requests.php since we shouldn't be inserting
new build requests in that API.
(Database::select_rows): Also use "1 == 1" in the select query when the query criteria is empty.
This is used in public/api/triggerables.php when no analysis task is specified.

  • public/include/json-header.php:

(find_triggerable_for_task): Added. Finds a triggerable available on a given test. We return the
triggerable associated with the closest ancestor of the test. Since issuing a new query for each
ancestor test is expensive, we retrieve triggerable for all ancestor tests at once and manually
find the closest ancestor with a triggerable.

  • public/include/report-processor.php:

(ReportProcessor::process):
(ReportProcessor::resolve_build_id): Associate a build request with the newly created build
if jobId or buildRequest is specified.

  • public/include/test-name-resolver.php:

(TestNameResolver::map_metrics_to_tests): Store the entire metric row instead of its name so that
test_exists_on_platform can use it. The last diff in public/admin/tests.php adopts this change.
(TestNameResolver::test_exists_on_platform): Added. Returns true iff the test has ever run on
a given platform.

  • public/include/test-path-resolver.php: Added.

(TestPathResolver): This class abstracts the ancestor chains of a test. It retrieves the entire
"tests" table to do this since there could be arbitrary number of ancestors for a given test.
This class is a lot more lightweight than TestNameResolver, which retrieves a whole bunch of tables
in order to compute full test metric names.
(TestPathResolver::construct):
(TestPathResolver::ancestors_for_test): Returns the ordered list of ancestors from the closest to
the highest (a test without a parent).
(TestPathResolver::path_for_test): Returns a test "path", the ordered list of test names from
the highest ancestor to the test itself.
(TestPathResolver::ensure_id_to_test_map): Fetches "tests" table to construct id_to_test_map.

  • public/privileged-api/create-test-group.php: Added. An API to create A/B testing groups.

(main):
(commit_sets_from_root_sets): Given a dictionary of repository names to a pair of revisions
for sets A and B respectively, returns a pair of arrays, each of which contains the corresponding
set of "commits" for sets A and B respectively. e.g. {"WebKit": [1, 2], "Safari": [3, 4]} will
result in WebKit commit at r1, Safari commit at r3], [WebKit commit at r2, Safari commit at r4.

  • public/v2/analysis.js:

(App.AnalysisTask.testGroups): Takes arguments so that set('testGroups') will invalidate the cache.
(App.AnalysisTask.triggerable): Added. Retrieves the triggerable associated with the task lazily.
(App.TestGroup.rootSets): Added. Returns the list of root set ids used in this A/B testing group.
(App.TestGroup.create): Added. Creates a new A/B testing group.
(App.Triggerable): Added.
(App.TriggerableAdapter): Added.
(App.TriggerableAdapter.buildURL): Added.
(App.BuildRequest.testGroup): Renamed from group.
(App.BuildRequest.orderLabel): Added. One-based index to be used in labels.
(App.BuildRequest.config): Added. Returns either 'A' or 'B' depending on the configuration used
in this build request.
(App.BuildRequest.status): Added.
(App.BuildRequest.statusLabel): Added. Returns a human friendly label for the current status.
(App.BuildRequest): Removed buildNumber, buildBuilder, as well as buildTime as they're unused.

  • public/v2/app.js:

(App.AnalysisTaskController.testGroups): Added.
(App.AnalysisTaskController.possibleRepetitionCounts): Added.
(App.AnalysisTaskController.updateRoots): Renamed from roots. This is also no longer a property
but an observer that updates "roots" property. Filter out the repositories that are not accepted
by the associated triggerable as they will be ignored.
(App.AnalysisTaskController.actions.createTestGroup): Added.

  • public/v2/index.html: Updated the UI, and added a form element to trigger createTestGroup action.
  • tools/sync-with-buildbot.py: Added. This scripts posts new builds on buildbot and reports back

the status of those builds to the perf dashboard. A similar script can be written to support
other continuous builds systems.
(main): Fetches the list of pending builds as well as currently running or completed builds from
a buildbot, and report new statuses of builds requests to the perf dashboard. It will then schedule
a single new build on each builder with no pending builds, and marks the set of open build requests
that have been scheduled to run on the buildbot but not found in the first step as stale.
(load_config): Loads a JSON that contains the configurations for each builder. e.g.
[

{

"platform": "mac-mavericks",
"test": ["Parser", "html5-full-render.html"],
"builder": "Trunk Syrah Production Perf AB Tests",
"arguments": {

"forcescheduler": "force-mac-mavericks-release-perf",
"webkit_revision": "$WebKit",
"jobid": "$buildRequest"

}

}

]

(find_request_updates): Return a list of build request status updates to make based on the pending
builds as well as in-progress and completed builds on each builder on the buildbot. When a build is
completed, we use the special status "failedIfNotCompleted" which results in "failed" status only
if the build request had not been completed. This is necessary because a failed build will not
report its failed-ness back to the perf dashboard in some cases; e.g. lost slave or svn up failure.
(update_and_fetch_build_requests): Submit the build request status updates and retrieve the list
of open requests the perf dashboard has.
(find_stale_request_updates): Compute the list of build requests that have been scheduled on the
buildbot but not found in find_request_updates. These build requests are lost. e.g. a master reboot
or human canceling a build may trigger such a state.
(schedule_request): Schedules a build with the arguments specified in the configuration JSON after
replacing repository names with their revisions and buildRequest with the build request id.
(config_for_request): Finds a builder for the test and the platform of a build request.
(fetch_json): Fetches a JSON from the specified URL, optionally with BasicAuth.
(property_value_from_build): Returns the value of a specific property in a buildbot build.
(request_id_from_build): Returns the build request id of a given buildbot build if there is one.

7:53 PM Changeset in webkit [178233] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CTTE: GeolocationController always has a client.
<​https://webkit.org/b/140330>

Reviewed by Anders Carlsson.

Change GeolocationController::m_client to be a reference and remove
a whole bunch of unnecessary null checks.

  • Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::GeolocationController):
(WebCore::GeolocationController::~GeolocationController):
(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
(WebCore::GeolocationController::lastPosition):
(WebCore::GeolocationController::viewStateDidChange):
(WebCore::provideGeolocationTo):

  • Modules/geolocation/GeolocationController.h:

(WebCore::GeolocationController::client):

6:44 PM Changeset in webkit [178232] by msaboff@apple.com
  • 3 edits
    4 adds in trunk

Breakpoint doesn't fire in this HTML5 game
​https://bugs.webkit.org/show_bug.cgi?id=140269

Reviewed by Mark Lam.

Source/JavaScriptCore:

When parsing a single line cached function, use the lineStartOffset of the
location where we found the cached function instead of the cached lineStartOffset.
The cache location's lineStartOffset has not been adjusted for any possible
containing functions.

This change is not needed for multi-line cached functions. Consider the
single line source:

function outer(){function inner1(){doStuff();}; (function inner2() {doMoreStuff()})()}

The first parser pass, we parse and cache inner1() and inner2() with a lineStartOffset
of 0. Later when we parse outer() and find inner1() in the cache, SourceCode start
character is at outer()'s outermost open brace. That is what we should use for
lineStartOffset for inner1(). When done parsing inner1() we set the parsing token
to the saved location for inner1(), including the lineStartOffset of 0. We need
to use the value of lineStartOffset before we started parsing inner1(). That is
what the fix does. When we parse inner2() the lineStartOffset will be correct.

For a multi-line function, the close brace is guaranteed to be on a different line
than the open brace. Hence, its lineStartOffset will not change with the change of
the SourceCode start character

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionInfo):

LayoutTests:

New tests that set breakpoints in functions with various line split
combinations.

  • inspector/debugger/breakpoint-columns-expected.txt: Added.
  • inspector/debugger/breakpoint-columns.html: Added.
  • inspector/debugger/resources/column-breakpoints-1.js: Added.

(columnTest1.x):
(columnTest1):
(columnTest2.x):
(columnTest2.f):
(columnTest3.x):
(columnTest3.f):
(runColumnTest1):
(runColumnTest2):
(runColumnTest3):

  • inspector/debugger/resources/column-breakpoints-2.js: Added.

(columnTest4.x):
(columnTest4.f):
(columnTest5.x):
(columnTest5):
(runColumnTest4):
(runColumnTest5):

6:12 PM Changeset in webkit [178231] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Calling clearSelection on a detached RenderObject leads to segfault.
​https://bugs.webkit.org/show_bug.cgi?id=140275

Reviewed by Simon Fraser.

We collect selection rects and compute selection gaps in order to
paint/clear selection. With certain content, we need to be able
to walk the tree up to a particular container to compute the selection rect.
However this container might not be available when the selection is part of a detached tree.
This is a null-check fix to ensure we don't crash in such cases, but in the long run
selection gaps and rect should be cached between two layouts so that we don't need to
keep collecting/recomputing them. Tracked here: webkit.org/b/140321

Source/WebCore:

Test: editing/selection/clearselection-on-detached-subtree-crash.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::containingBlockLogicalWidthForContent):
(WebCore::RenderBox::containingBlockLogicalHeightForContent):

  • rendering/RenderView.cpp:

(WebCore::RenderView::clearSelection):

LayoutTests:

  • editing/selection/clearselection-on-detached-subtree-crash-expected.txt: Added.
  • editing/selection/clearselection-on-detached-subtree-crash.html: Added.
6:00 PM Changeset in webkit [178230] by andersca@apple.com
  • 10 edits in trunk/Source/WebCore

Remove more sync database code
​https://bugs.webkit.org/show_bug.cgi?id=140328

Reviewed by Sam Weinig.

  • Modules/webdatabase/AbstractDatabaseServer.h:
  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::DatabaseBackendBase):

  • Modules/webdatabase/DatabaseBackendBase.h:

(WebCore::DatabaseBackendBase::isSyncDatabase): Deleted.

  • Modules/webdatabase/DatabaseBasicTypes.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseBackend):
(WebCore::DatabaseManager::openDatabase):

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::openDatabase):
(WebCore::DatabaseServer::createDatabase):

  • Modules/webdatabase/DatabaseServer.h:
5:50 PM Changeset in webkit [178229] by dbates@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the iOS build after <​http://trac.webkit.org/changeset/178213>
(​https://bugs.webkit.org/show_bug.cgi?id=140310)

Patch by Daniel Bates <​dabates@apple.com> on 2015-01-09

  • platform/spi/cocoa/CoreTextSPI.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemFont):

5:48 PM Changeset in webkit [178228] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Get rid of legacy StyleBuilder switch in StyleResolver.cpp
​https://bugs.webkit.org/show_bug.cgi?id=140315

Reviewed by Sam Weinig.

Get rid of legacy StyleBuilder switch in StyleResolver.cpp now that most
properties have been ported to the new generated StyleBuilder in previous
patches. The properties that remained in this switch were shorthand
properties or other properties that do not require any handling in the
StyleBuilder.

To achieve this, this patch introduces 2 parameters in
CSSPropertyNames.in:

  • SkipBuilder: Indicates that no StyleBuilder code should be generated for this property.
  • Shorthand: Indicates that this is a shorthand property, which therefore does not use the StyleBuilder. makeprop.pl will merely generate assertions for such properties, to validate that this is a shorthand property and that the StyleBuilder code is never reached.
  • css/CSSPropertyNames.in:
  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • css/makeprop.pl:
5:40 PM Changeset in webkit [178227] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.3.17

New tag.

5:29 PM Changeset in webkit [178226] by weinig@apple.com
  • 2 edits in trunk/Tools

TestWebKitAPI should print out the lists that fail at the end
​https://bugs.webkit.org/show_bug.cgi?id=140329

Reviewed by Tim Horton.

  • Scripts/run-api-tests:

(runTestsBySuite):
Print out failures and timeouts in all modes, not just verbose.

5:15 PM Changeset in webkit [178225] by Brent Fulgham
  • 6 edits in trunk/Source

[Win] Build fix after r178219.

Source/WebCore:

  • WebCore.vcxproj/WebCore.vcxproj: Remove PaintHooks.asm references in project file.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

Source/WebKit:

Update the project file settings to understand how to process assembly files.
Also tidy up the plugin code in the project hieararchy.

  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
5:04 PM Changeset in webkit [178224] by Joseph Pecoraro
  • 3 edits
    3 adds in trunk

Web Inspector: Uncaught Exception in ProbeManager deleting breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=140279
rdar://problem/19422299

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

  • runtime/MapData.cpp:

(JSC::MapData::replaceAndPackBackingStore):
The cell table also needs to have its values fixed.

LayoutTests:

  • js/map-repack-with-object-keys-expected.txt: Added.
  • js/map-repack-with-object-keys.html: Added.
  • js/script-tests/map-repack-with-object-keys.js: Added.
4:43 PM Changeset in webkit [178223] by akling@apple.com
  • 35 edits in trunk/Source/WebCore

Log which ActiveDOMObject(s) can't be suspended for PageCache.
<​https://webkit.org/b/139697>

Reviewed by Chris Dumez.

Give ActiveDOMObject a pure virtual activeDOMObjectName() so we can
find their names.

Dump the names of all the ActiveDOMObjects that fail to suspend when
we're trying to put a page into PageCache.

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
  • Modules/mediastream/RTCStatsRequestImpl.h:
  • Modules/mediastream/RTCVoidRequestImpl.h:
  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webdatabase/DatabaseContext.h:
  • Modules/websockets/WebSocket.h:
  • WebCore.exp.in:
  • css/FontLoader.h:
  • dom/ActiveDOMObject.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):

  • dom/ScriptExecutionContext.h:
  • fileapi/FileReader.h:
  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):

  • html/HTMLMarqueeElement.h:
  • html/HTMLMediaElement.h:
  • html/PublicURLManager.h:
  • html/canvas/WebGLRenderingContext.h:
  • page/EventSource.h:
  • page/SuspendableTimer.h:
  • workers/AbstractWorker.h:
  • xml/XMLHttpRequest.h:
4:34 PM Changeset in webkit [178222] by andersca@apple.com
  • 19 edits
    2 deletes in trunk/Source

Get rid of the database strategy
​https://bugs.webkit.org/show_bug.cgi?id=140322

Reviewed by Sam Weinig.

Source/WebCore:

  • CMakeLists.txt:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::ProposedDatabase::ProposedDatabase):
(WebCore::DatabaseManager::DatabaseManager):

  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/DatabaseStrategy.cpp: Removed.
  • platform/DatabaseStrategy.h: Removed.
  • platform/PlatformStrategies.h:

(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::databaseStrategy): Deleted.

Source/WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::createDatabaseStrategy): Deleted.

Source/WebKit/win:

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::createDatabaseStrategy): Deleted.

  • WebCoreSupport/WebPlatformStrategies.h:

Source/WebKit2:

  • NetworkProcess/NetworkProcessPlatformStrategies.cpp:

(WebKit::NetworkProcessPlatformStrategies::createDatabaseStrategy): Deleted.

  • NetworkProcess/NetworkProcessPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::createDatabaseStrategy): Deleted.
(WebKit::WebPlatformStrategies::getDatabaseServer): Deleted.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
4:30 PM Changeset in webkit [178221] by ggaren@apple.com
  • 2 edits in trunk/Tools

Make bmalloc work with ASan
​https://bugs.webkit.org/show_bug.cgi?id=140194

Reviewed by Mark Lam.

  • asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports

ASan automatically (by forwarding to system malloc at runtime).

4:20 PM Changeset in webkit [178220] by mitz@apple.com
  • 3 edits
    1 delete in trunk/Source/WebKit2

[Cocoa] Remove deprecated WKRenderingProgressEvents
​https://bugs.webkit.org/show_bug.cgi?id=140325

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKRenderingProgressEvents.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
4:16 PM Changeset in webkit [178219] by andersca@apple.com
  • 18 edits
    6 copies
    12 moves
    1 add
    1 delete in trunk/Source

Move the Windows only plug-in code to WebKit/win
​https://bugs.webkit.org/show_bug.cgi?id=140133

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKit.vcxproj:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:

Source/WebKit/win:

  • Plugins/PaintHooks.asm: Renamed from Source/WebCore/plugins/win/PaintHooks.asm.
  • Plugins/PluginDatabase.cpp: Renamed from Source/WebCore/plugins/PluginDatabase.cpp.

(WebCore::persistentPluginMetadataCachePath):
(WebCore::PluginDatabase::PluginDatabase):
(WebCore::PluginDatabase::installedPlugins):
(WebCore::PluginDatabase::isMIMETypeRegistered):
(WebCore::PluginDatabase::addExtraPluginDirectory):
(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::plugins):
(WebCore::PluginDatabase::preferredPluginCompare):
(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):
(WebCore::PluginDatabase::findPlugin):
(WebCore::PluginDatabase::setPreferredPluginForMIMEType):
(WebCore::PluginDatabase::fileExistsAndIsNotDisabled):
(WebCore::PluginDatabase::getDeletedPlugins):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::remove):
(WebCore::PluginDatabase::clear):
(WebCore::PluginDatabase::removeDisabledPluginFile):
(WebCore::PluginDatabase::addDisabledPluginFile):
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::fillBufferWithContentsOfFile):
(WebCore::readUTF8String):
(WebCore::readTime):
(WebCore::PluginDatabase::loadPersistentMetadataCache):
(WebCore::writeUTF8String):
(WebCore::writeTime):
(WebCore::PluginDatabase::updatePersistentMetadataCache):
(WebCore::PluginDatabase::isPersistentMetadataCacheEnabled):
(WebCore::PluginDatabase::setPersistentMetadataCacheEnabled):
(WebCore::PluginDatabase::persistentMetadataCachePath):
(WebCore::PluginDatabase::setPersistentMetadataCachePath):

  • Plugins/PluginDatabase.h: Renamed from Source/WebCore/plugins/PluginDatabase.h.

(WebCore::PluginDatabase::setPluginDirectories):
(WebCore::PluginDatabase::pluginDirectories):

  • Plugins/PluginDatabaseWin.cpp: Renamed from Source/WebCore/plugins/win/PluginDatabaseWin.cpp.

(WebCore::addPluginPathsFromRegistry):
(WebCore::PluginDatabase::getPluginPathsInDirectories):
(WebCore::parseVersionString):
(WebCore::compareVersions):
(WebCore::addMozillaPluginDirectories):
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addAdobeAcrobatPluginDirectory):
(WebCore::addJavaPluginDirectory):
(WebCore::safariPluginsDirectory):
(WebCore::addMacromediaPluginDirectories):
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

  • Plugins/PluginDebug.cpp: Renamed from Source/WebCore/plugins/PluginDebug.cpp.

(WebCore::prettyNameForNPError):
(WebCore::prettyNameForDrawingModel):
(WebCore::prettyNameForEventModel):
(WebCore::prettyNameForNPNVariable):
(WebCore::prettyNameForNPPVariable):
(WebCore::prettyNameForNPNURLVariable):

  • Plugins/PluginDebug.h: Renamed from Source/WebCore/plugins/PluginDebug.h.
  • Plugins/PluginMessageThrottlerWin.cpp: Renamed from Source/WebCore/plugins/win/PluginMessageThrottlerWin.cpp.

(WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::~PluginMessageThrottlerWin):
(WebCore::PluginMessageThrottlerWin::appendMessage):
(WebCore::PluginMessageThrottlerWin::processQueuedMessage):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):
(WebCore::PluginMessageThrottlerWin::allocateMessage):
(WebCore::PluginMessageThrottlerWin::isInlineMessage):
(WebCore::PluginMessageThrottlerWin::freeMessage):

  • Plugins/PluginMessageThrottlerWin.h: Renamed from Source/WebCore/plugins/win/PluginMessageThrottlerWin.h.
  • Plugins/PluginPackage.cpp: Renamed from Source/WebCore/plugins/PluginPackage.cpp.

(WebCore::PluginPackage::~PluginPackage):
(WebCore::PluginPackage::freeLibrarySoon):
(WebCore::PluginPackage::freeLibraryTimerFired):
(WebCore::PluginPackage::compare):
(WebCore::PluginPackage::PluginPackage):
(WebCore::PluginPackage::unload):
(WebCore::PluginPackage::unloadWithoutShutdown):
(WebCore::PluginPackage::setEnabled):
(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):
(WebCore::PluginPackage::determineQuirks):
(WebCore::PluginPackage::determineModuleVersionFromDescription):
(WebCore::getListFromVariantArgs):
(WebCore::makeSource):
(WebCore::NPN_Evaluate):
(WebCore::NPN_Invoke):
(WebCore::PluginPackage::initializeBrowserFuncs):
(WebCore::PluginPackage::hash):
(WebCore::PluginPackage::equal):
(WebCore::PluginPackage::compareFileVersion):
(WebCore::PluginPackage::ensurePluginLoaded):

  • Plugins/PluginPackage.h: Renamed from Source/WebCore/plugins/PluginPackage.h.

(WebCore::PluginPackage::name):
(WebCore::PluginPackage::description):
(WebCore::PluginPackage::path):
(WebCore::PluginPackage::fileName):
(WebCore::PluginPackage::parentDirectory):
(WebCore::PluginPackage::module):
(WebCore::PluginPackage::lastModified):
(WebCore::PluginPackage::mimeToDescriptions):
(WebCore::PluginPackage::mimeToExtensions):
(WebCore::PluginPackage::isEnabled):
(WebCore::PluginPackage::pluginFuncs):
(WebCore::PluginPackage::quirks):
(WebCore::PluginPackage::version):
(WebCore::PluginPackage::fullMIMEDescription):
(WebCore::PluginPackageHash::hash):
(WebCore::PluginPackageHash::equal):

  • Plugins/PluginPackageWin.cpp: Renamed from Source/WebCore/plugins/win/PluginPackageWin.cpp.

(WebCore::getVersionInfo):
(WebCore::PluginPackage::isPluginBlacklisted):
(WebCore::PluginPackage::determineQuirks):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
(WebCore::PluginPackage::hash):
(WebCore::PluginPackage::equal):
(WebCore::PluginPackage::NPVersion):

  • Plugins/PluginQuirkSet.h: Renamed from Source/WebCore/plugins/PluginQuirkSet.h.

(WebCore::PluginQuirkSet::PluginQuirkSet):
(WebCore::PluginQuirkSet::add):
(WebCore::PluginQuirkSet::contains):

  • Plugins/PluginStream.cpp: Renamed from Source/WebCore/plugins/PluginStream.cpp.

(WebCore::streams):
(WebCore::PluginStream::PluginStream):
(WebCore::PluginStream::~PluginStream):
(WebCore::PluginStream::start):
(WebCore::PluginStream::stop):
(WebCore::lastModifiedDate):
(WebCore::PluginStream::startStream):
(WebCore::PluginStream::ownerForStream):
(WebCore::PluginStream::cancelAndDestroyStream):
(WebCore::PluginStream::destroyStream):
(WebCore::PluginStream::delayDeliveryTimerFired):
(WebCore::PluginStream::deliverData):
(WebCore::PluginStream::sendJavaScriptStream):
(WebCore::PluginStream::didReceiveResponse):
(WebCore::PluginStream::didReceiveData):
(WebCore::PluginStream::didFail):
(WebCore::PluginStream::didFinishLoading):
(WebCore::PluginStream::wantsAllStreams):

  • Plugins/PluginStream.h: Renamed from Source/WebCore/plugins/PluginStream.h.

(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore::PluginStream::create):
(WebCore::PluginStream::setLoadManually):

  • Plugins/PluginView.cpp: Renamed from Source/WebCore/plugins/PluginView.cpp.

(WebCore::instanceMap):
(WebCore::scriptStringIfJavaScriptURL):
(WebCore::PluginView::popPopupsStateTimerFired):
(WebCore::PluginView::windowClipRect):
(WebCore::PluginView::setFrameRect):
(WebCore::PluginView::frameRectsChanged):
(WebCore::PluginView::clipRectChanged):
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::startOrAddToUnstartedList):
(WebCore::PluginView::start):
(WebCore::PluginView::mediaCanStart):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::stop):
(WebCore::PluginView::setCurrentPluginView):
(WebCore::PluginView::currentPluginView):
(WebCore::createUTF8String):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::requestTimerFired):
(WebCore::PluginView::scheduleRequest):
(WebCore::PluginView::load):
(WebCore::makeURL):
(WebCore::PluginView::getURLNotify):
(WebCore::PluginView::getURL):
(WebCore::PluginView::postURLNotify):
(WebCore::PluginView::postURL):
(WebCore::PluginView::newStream):
(WebCore::PluginView::write):
(WebCore::PluginView::destroyStream):
(WebCore::PluginView::status):
(WebCore::PluginView::setValue):
(WebCore::PluginView::invalidateTimerFired):
(WebCore::PluginView::pushPopupsEnabledState):
(WebCore::PluginView::popPopupsEnabledState):
(WebCore::PluginView::arePopupsAllowed):
(WebCore::PluginView::setJavaScriptPaused):
(WebCore::PluginView::npObject):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::disconnectStream):
(WebCore::PluginView::setParameters):
(WebCore::PluginView::PluginView):
(WebCore::PluginView::focusPluginElement):
(WebCore::PluginView::didReceiveResponse):
(WebCore::PluginView::didReceiveData):
(WebCore::PluginView::didFinishLoading):
(WebCore::PluginView::didFail):
(WebCore::PluginView::setCallingPlugin):
(WebCore::PluginView::isCallingPlugin):
(WebCore::PluginView::create):
(WebCore::PluginView::freeStringArray):
(WebCore::startsWithBlankLine):
(WebCore::locationAfterFirstBlankLine):
(WebCore::findEOL):
(WebCore::capitalizeRFC822HeaderFieldName):
(WebCore::parseRFC822HeaderFields):
(WebCore::PluginView::handlePost):
(WebCore::PluginView::invalidateWindowlessPluginRect):
(WebCore::PluginView::paintMissingPluginIcon):
(WebCore::PluginView::userAgent):
(WebCore::PluginView::userAgentStatic):
(WebCore::PluginView::lifeSupportTimerFired):
(WebCore::PluginView::keepAlive):
(WebCore::PluginView::getValueStatic):
(WebCore::PluginView::getValue):
(WebCore::getFrame):
(WebCore::PluginView::getValueForURL):
(WebCore::PluginView::setValueForURL):
(WebCore::PluginView::getAuthenticationInfo):
(WebCore::PluginView::privateBrowsingStateChanged):

  • Plugins/PluginView.h: Renamed from Source/WebCore/plugins/PluginView.h.

(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
(WebCore::PluginManualLoader::~PluginManualLoader):
(WebCore::PluginView::plugin):
(WebCore::PluginView::instance):
(WebCore::PluginView::status):
(WebCore::PluginView::streamDidFinishLoading):
(WebCore::PluginView::parentFrame):
(WebCore::PluginView::pluginsPage):
(WebCore::PluginView::mimeType):
(WebCore::PluginView::url):
(WebCore::PluginView::pluginWndProc):
(WebCore::PluginView::platformPluginWidget):
(WebCore::PluginView::setPlatformPluginWidget):
(WebCore::toPluginView):

  • Plugins/PluginViewWin.cpp: Renamed from Source/WebCore/plugins/win/PluginViewWin.cpp.

(windowHandleForPageClient):
(WebCore::PluginView::hookedBeginPaint):
(WebCore::PluginView::hookedEndPaint):
(WebCore::hook):
(WebCore::setUpOffscreenPaintingHooks):
(WebCore::registerPluginView):
(WebCore::PluginView::PluginViewWndProc):
(WebCore::isWindowsMessageUserGesture):
(WebCore::contentsToNativeWindow):
(WebCore::PluginView::wndProc):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::show):
(WebCore::PluginView::hide):
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleKeyboardEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setParentVisible):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::handlePostReadFile):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::invalidateRegion):
(WebCore::PluginView::forceRedraw):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::snapshot):

  • Plugins/npapi.cpp: Renamed from Source/WebCore/plugins/npapi.cpp.

(pluginViewForInstance):
(NPN_MemAlloc):
(NPN_MemFree):
(NPN_MemFlush):
(NPN_ReloadPlugins):
(NPN_RequestRead):
(NPN_GetURLNotify):
(NPN_GetURL):
(NPN_PostURLNotify):
(NPN_PostURL):
(NPN_NewStream):
(NPN_Write):
(NPN_DestroyStream):
(NPN_UserAgent):
(NPN_Status):
(NPN_InvalidateRect):
(NPN_InvalidateRegion):
(NPN_ForceRedraw):
(NPN_GetValue):
(NPN_SetValue):
(NPN_GetJavaEnv):
(NPN_GetJavaPeer):
(NPN_PushPopupsEnabledState):
(NPN_PopPopupsEnabledState):
(NPN_PluginThreadAsyncCall):
(NPN_GetValueForURL):
(NPN_SetValueForURL):
(NPN_GetAuthenticationInfo):
(NPN_PopUpContextMenu):

4:09 PM Changeset in webkit [178218] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.14.1

New tag.

4:00 PM Changeset in webkit [178217] by weinig@apple.com
  • 14 edits
    2 adds in trunk/Source/WebKit2

Move Navigation creation out of the Cocoa layer and down into the WebPageProxy level
​https://bugs.webkit.org/show_bug.cgi?id=140319

Reviewed by Anders Carlsson.

  • Adds WebNavigationState, a class at the WebPageProxy level to handle the creation and storage of Navigations. Starts moving some of the functionality from NavigationState there.
  • UIProcess/API/APINavigation.cpp:

(API::Navigation::Navigation):

  • UIProcess/API/APINavigation.h:

(API::Navigation::create):
(API::Navigation::navigationID):
Have each Navigation store its navigationID and generate it via the WebNavigationState
that is passed to the constructor.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _restoreFromSessionStateData:]):
(-[WKWebView _restoreSessionState:andNavigate:]):
Update for WebPageProxy functions returning the Navigations directly, rather than
the navigationID.

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::PolicyClient::decidePolicyForNavigationAction):
Remove creation of the load request navigation which is now handled by the WebPageProxy.

(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame):
(WebKit::NavigationState::LoaderClient::didDestroyNavigation):
(WebKit::NavigationState::LoaderClient::processDidCrash):
Change to get/take/remove Navigations from the WebPageProxy's WebNavigationState

(WebKit::NavigationState::createLoadRequestNavigation): Deleted.
(WebKit::NavigationState::createBackForwardNavigation): Deleted.
(WebKit::NavigationState::createReloadNavigation): Deleted.
(WebKit::NavigationState::createLoadDataNavigation): Deleted.
Move Navigation creation to WebNavigationState.

  • UIProcess/WebFrameListenerProxy.cpp:

(WebKit::WebFrameListenerProxy::WebFrameListenerProxy):
(WebKit::WebFrameListenerProxy::receivedPolicyDecision):

  • UIProcess/WebFrameListenerProxy.h:

(WebKit::WebFrameListenerProxy::navigation):
(WebKit::WebFrameListenerProxy::setNavigation):
(WebKit::WebFrameListenerProxy::navigationID): Deleted.
(WebKit::WebFrameListenerProxy::setNavigationID): Deleted.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::receivedPolicyDecision):

  • UIProcess/WebFrameProxy.h:

Store a Navigation rather than a navigationID on the WebFrameListenerProxy.

  • UIProcess/WebNavigationState.cpp: Added.

(WebKit::WebNavigationState::WebNavigationState):
(WebKit::WebNavigationState::~WebNavigationState):
(WebKit::WebNavigationState::createLoadRequestNavigation):
(WebKit::WebNavigationState::createBackForwardNavigation):
(WebKit::WebNavigationState::createReloadNavigation):
(WebKit::WebNavigationState::createLoadDataNavigation):
(WebKit::WebNavigationState::navigation):
(WebKit::WebNavigationState::takeNavigation):
(WebKit::WebNavigationState::didDestroyNavigation):
(WebKit::WebNavigationState::clearAllNavigations):

  • UIProcess/WebNavigationState.h: Added.

(WebKit::WebNavigationState::generateNavigationID):
New class to manage navigations.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goForward):
(WebKit::WebPageProxy::goBack):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::generateNavigationID): Deleted.
Create navigations directly rather than generating a navigation ID and letting
the API level create Navigation.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::navigationState):
Add WebNavigationState member and accessor.

  • WebKit2.xcodeproj/project.pbxproj:

Add WebNavigationState.h/cpp

3:57 PM Changeset in webkit [178216] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Another Windows build fix.

  • DerivedSources.cpp:
3:41 PM Changeset in webkit [178215] by Chris Dumez
  • 2 edits in trunk/LayoutTests

plugins/crash-restoring-plugin-page-from-page-cache.html and plugins/netscape-plugin-page-cache-works.html timing out on Intel Debug WebKit2 testers
​https://bugs.webkit.org/show_bug.cgi?id=81392

Reviewed by Alexey Proskuryakov.

Unskip those 2 plugins / page cache tests as they seem to be passing on
WK2 nowadays.

  • platform/wk2/TestExpectations:
3:40 PM Changeset in webkit [178214] by dbates@webkit.org
  • 4 edits in trunk

[iOS] Make DumpRenderTree build with public SDK
​https://bugs.webkit.org/show_bug.cgi?id=140311

Reviewed by Sam Weinig.

Source/WebKit2:

Add more SPI declarations.

  • Platform/spi/ios/UIKitSPI.h:

Tools:

Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
Additionally, remove unused header CoreGraphics/CGFontDB.h.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):

3:36 PM Changeset in webkit [178213] by enrica@apple.com
  • 8 edits in trunk

[iOS] Support additional text styles.
​https://bugs.webkit.org/show_bug.cgi?id=140310
rdar://problem/18568864

Reviewed by Joseph Pecoraro.

Source/WebCore:

Add support for three new text styles.

  • css/CSSValueKeywords.in:
  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemFont):

Source/WebInspectorUI:

Add support for three new text styles.

  • UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

Updates the existing test to include the new text styles.

  • platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle-expected.txt:
  • platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle.html:
3:35 PM Changeset in webkit [178212] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • bindings/js/JSBindingsAllInOne.cpp:
3:28 PM Changeset in webkit [178211] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Remove more worker database code
​https://bugs.webkit.org/show_bug.cgi?id=140320

Reviewed by Tim Horton.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):

3:16 PM Changeset in webkit [178210] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

After updating tests to use kerning, ligatures, and printer fonts, some tests fail
​https://bugs.webkit.org/show_bug.cgi?id=139968

  • platform/mac/TestExpectations: Add more flaky tests.
3:15 PM Changeset in webkit [178209] by andersca@apple.com
  • 11 edits
    15 deletes in trunk/Source/WebCore

Remove more sync database code
​https://bugs.webkit.org/show_bug.cgi?id=140318

Reviewed by Sam Weinig.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/webdatabase/DatabaseBackendSync.cpp: Removed.
  • Modules/webdatabase/DatabaseBackendSync.h: Removed.
  • Modules/webdatabase/DatabaseCallback.h:
  • Modules/webdatabase/DatabaseCallback.idl:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabaseSync): Deleted.

  • Modules/webdatabase/DatabaseManager.h:
  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::createDatabase):

  • Modules/webdatabase/DatabaseSync.cpp: Removed.
  • Modules/webdatabase/DatabaseSync.h: Removed.
  • Modules/webdatabase/DatabaseSync.idl: Removed.
  • Modules/webdatabase/SQLStatementSync.cpp: Removed.
  • Modules/webdatabase/SQLStatementSync.h: Removed.
  • Modules/webdatabase/SQLTransactionBackendSync.cpp: Removed.
  • Modules/webdatabase/SQLTransactionBackendSync.h: Removed.
  • Modules/webdatabase/SQLTransactionSync.cpp: Removed.
  • Modules/webdatabase/SQLTransactionSync.h: Removed.
  • Modules/webdatabase/SQLTransactionSync.idl: Removed.
  • Modules/webdatabase/SQLTransactionSyncCallback.h: Removed.
  • Modules/webdatabase/SQLTransactionSyncCallback.idl: Removed.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSQLTransactionSyncCustom.cpp: Removed.
2:39 PM Changeset in webkit [178208] by rniwa@webkit.org
  • 6 edits in trunk/Websites/perf.webkit.org

Cache-control should be set only on api/runs
​https://bugs.webkit.org/show_bug.cgi?id=140312

Reviewed by Andreas Kling.

Some JSON APIs such as api/analysis-tasks can't be cached even for a short period of time (e.g. a few minutes)
since they can be modified by the user on demand. Since only api/runs.php takes a long time to generate JSONs,
just set cache-control there instead of json-header.php which is used by other JSON APIs.

Also set date_default_timezone_set in db.php since we never use non-UTC timezone in our scripts.

  • public/api/analysis-tasks.php:
  • public/api/runs.php: Set the cache control headers.
  • public/api/test-groups.php:
  • public/include/db.php: Set the default timezone to UTC.
  • public/include/json-header.php: Don't set the cache control headers.
2:34 PM Changeset in webkit [178207] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r176441. rdar://problem/19409536

2:33 PM Changeset in webkit [178206] by bshafiei@apple.com
  • 4 edits
    1 copy in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174742. rdar://problem/19286019

2:32 PM Changeset in webkit [178205] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174299. rdar://problem/19286019

2:30 PM Changeset in webkit [178204] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r174081. rdar://problem/19286019

2:28 PM Changeset in webkit [178203] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r173975. rdar://problem/19286019

2:26 PM Changeset in webkit [178202] by bshafiei@apple.com
  • 6 edits in branches/safari-600.1.4.15-branch/Source/WebKit2

Merged r177163. rdar://problem/19273192

2:26 PM Changeset in webkit [178201] by commit-queue@webkit.org
  • 19 edits in trunk/Source

Web Inspector: Remove or use TimelineAgent Resource related event types
​https://bugs.webkit.org/show_bug.cgi?id=140155

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-01-09
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Remove unused / stale Timeline event types.

  • inspector/protocol/Timeline.json:

Source/WebCore:

Remove unused timeline events. The frontend was ignoring these events
and was often already getting nearly identical data from the Network domain.

  • WebCore.exp.in:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseButCanceledImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::didScheduleResourceRequestImpl): Deleted.
(WebCore::InspectorInstrumentation::willReceiveResourceDataImpl): Deleted.
(WebCore::InspectorInstrumentation::didReceiveResourceDataImpl): Deleted.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didScheduleResourceRequest): Deleted.
(WebCore::InspectorInstrumentation::willReceiveResourceData): Deleted.
(WebCore::InspectorInstrumentation::didReceiveResourceData): Deleted.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::toProtocol):
(WebCore::InspectorTimelineAgent::didScheduleResourceRequest): Deleted.
(WebCore::InspectorTimelineAgent::willSendResourceRequest): Deleted.
(WebCore::InspectorTimelineAgent::willReceiveResourceData): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveResourceData): Deleted.
(WebCore::InspectorTimelineAgent::willReceiveResourceResponse): Deleted.
(WebCore::InspectorTimelineAgent::didReceiveResourceResponse): Deleted.
(WebCore::InspectorTimelineAgent::didFinishLoadingResource): Deleted.

  • inspector/InspectorTimelineAgent.h:
  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createScheduleResourceRequestData): Deleted.
(WebCore::TimelineRecordFactory::createResourceSendRequestData): Deleted.
(WebCore::TimelineRecordFactory::createResourceReceiveResponseData): Deleted.
(WebCore::TimelineRecordFactory::createResourceFinishData): Deleted.
(WebCore::TimelineRecordFactory::createReceiveResourceData): Deleted.

  • inspector/TimelineRecordFactory.h:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

  • loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::notifyDidScheduleResourceRequest): Deleted.

  • loader/ResourceLoadScheduler.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didReceiveBuffer):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::didReceiveDataArray):

Source/WebKit2:

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad):

2:25 PM Changeset in webkit [178200] by rniwa@webkit.org
  • 5 edits in trunk/Websites/perf.webkit.org

api/report-commit should authenticate with a slave name and password
​https://bugs.webkit.org/show_bug.cgi?id=140308

Reviewed by Benjamin Poulain.

Use a slave name and a password to authenticate new commit reports.

  • public/api/report-commits.php:

(main):

  • public/include/json-header.php:

(verify_slave): Renamed and repurposed from verify_builder in report-commits.php. Now authenticates with
a slave name and a password instead of a builder name and a password.

  • tests/api-report-commits.js: Updated tests.
  • tools/pull-svn.py:

(main): Renamed variables.
(submit_commits): Submits slaveName and slavePassword instead of builderName and builderPassword.

2:24 PM Changeset in webkit [178199] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Fix the WebKit2 build with the public SDK

Forward declare class WebView.

  • Platform/spi/ios/UIKitSPI.h:
2:15 PM Changeset in webkit [178198] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update r177745, one of the review comments was not integrated

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-01-09

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesLangPseudoClass):
I cq+ before Dhi could make an update and this was left out.

2:14 PM Changeset in webkit [178197] by dbates@webkit.org
  • 3 edits
    6 copies
    290 adds
    2 deletes in trunk/LayoutTests

[iOS] Add iOS-specific tests and consolidate iOS-specific accessibility tests

Copied iOS-specific tests from directory LayoutTests/platform/ios-sim-deprecated/iphone
to LayoutTests/platform/ios-simulator/ios and fixed references to external JavaScript
scripts and external style sheets. Moved iOS-specific tests in directories LayoutTests/platform/ios-sim/accessibility
and LayoutTests/platform/ios-simulator/ios-accessibility into LayoutTests/platform/ios-simulator/ios/accessibility.

I will remove directory LayoutTests/platform/ios-sim-deprecated, including
LayoutTests/platform/ios-sim-deprecated/iphone, in a subsequent commit.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/ios/accessibility/press-fires-touch-events-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events-expected.txt.
  • platform/ios-simulator/ios/accessibility/press-fires-touch-events.html: Renamed from LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html.
  • platform/ios-simulator/ios/accessibility/set-value-expected.txt: Copied from LayoutTests/platform/ios-sim/accessibility/set-value-expected.txt.
  • platform/ios-simulator/ios/accessibility/set-value.html: Renamed from LayoutTests/platform/ios-sim/accessibility/set-value.html.
  • platform/ios-simulator/ios/compositing/overlap-page-scale-expected.txt: Added.

[...]

2:13 PM Changeset in webkit [178196] by akling@apple.com
  • 2 edits in trunk/LayoutTests

Mark css3/background/background-repeat-space-content.html as ImgaeOnlyFailure

This test is failing with a subtle pixel difference, need to figure out what's
going on, but results are not visually wrong.

2:00 PM Changeset in webkit [178195] by bshafiei@apple.com
  • 5 edits in branches/safari-600.3-branch/Source

Versioning.

1:57 PM Changeset in webkit [178194] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix error handling of ContentExtensionsManager when the top level input is unusable
​https://bugs.webkit.org/show_bug.cgi?id=140284

Reviewed by Andreas Kling.

There are a couple of ways the WebProcess would crash if the input
is really really bad:
-If the JSON is unreadable, we can have an exception or decodedRules can be null.
-On any of the error, we cannot return immediately or we will skip vm.clear().

This patch adds a branch to fix the first issue.

For the second issue, a new function, loadEncodedRules(), encapsulate all the early
returns to make sure we execute the end of loadExtension().

  • contentextensions/ContentExtensionsManager.cpp:

(WebCore::ContentExtensions::ExtensionsManager::loadEncodedRules):
(WebCore::ContentExtensions::ExtensionsManager::loadExtension):

1:25 PM Changeset in webkit [178193] by Bem Jones-Bey
  • 2 edits in trunk/Source/WebCore

Simplify LineWidth::wrapNextToShapeOutside()
​https://bugs.webkit.org/show_bug.cgi?id=140304

Reviewed by Zoltan Horvath.

This function used to manually check to see if the entire height of
the line would have enough space next to the float. However, the code
to compute the offsets will do this automatically (and probably a lot
faster), if the line height is passed in. This patch does just that.

No new tests, no behavior change.

  • rendering/line/LineWidth.cpp:

(WebCore::availableWidthAtOffset): Remove now unused override, allow

passing in lineHeight.

(WebCore::LineWidth::wrapNextToShapeOutside): Pass the lineHeight

when computing the available width, so we don't need to check
isWholeLineFit anymore.

(WebCore::isWholeLineFit): Deleted.

1:01 PM Changeset in webkit [178192] by Bem Jones-Bey
  • 3 edits
    2 adds in trunk

[CSS Shapes] content inside second shape area when two floats interact
​https://bugs.webkit.org/show_bug.cgi?id=137702

Reviewed by Zalan Bujtas.

Source/WebCore:

If a float has a shape-outside, we cannot assume that it has a uniform
width for the height of the float, so we cannot use simple line
layout.

Test: fast/shapes/shape-outside-floats/shape-outside-text-overlap-float.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): Don't use simple line layout

if we have shape-outside. Also, rename floatRenderer to
floatingObject, since the variable doesn't contain a renderer.

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-text-overlap-float-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-text-overlap-float.html: Added.
12:59 PM Changeset in webkit [178191] by Chris Dumez
  • 3 edits
    4 adds in trunk

Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache
​https://bugs.webkit.org/show_bug.cgi?id=140302

Reviewed by Andreas Kling.

Source/WebCore:

Allow HTTPS + 'Cache-control: no-store' sub-frames into the page cache.
We already restore 'no-store' sub-resources on history navigation from
the memory cache so there is no reason for our page cache policy to be
more restrictive.

We should align our memory cache / history navigation policy with our
page cache policy.

For now, 'no-store' main resources are not restored from either cache
(memory cache / page cache) on history navigation though. This behavior
does not change.

Test: http/tests/navigation/https-no-store-subframe-in-page-cache.html

  • history/PageCache.cpp:

(WebCore::logCanCacheFrameDecision):
(WebCore::PageCache::canCachePageContainingThisFrame):

LayoutTests:

Add a layout test to make sure a page is restored from the page cache
on history navigation, even though its has an HTTPS sub-frame with
"cache-control: no-cache".

  • http/tests/navigation/https-no-store-subframe-in-page-cache-expected.txt: Added.
  • http/tests/navigation/https-no-store-subframe-in-page-cache.html: Added.
  • http/tests/navigation/resources/https-no-store-subframe-in-page-cache.html: Added.
  • http/tests/navigation/resources/no-store-frame.php: Added.
12:57 PM Changeset in webkit [178190] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to trigger a rebuild of generated JS bindings.

  • bindings/scripts/CodeGeneratorJS.pm:
12:32 PM Changeset in webkit [178189] by Chris Dumez
  • 8 edits
    1 delete in trunk/Source/WebCore

Add support for SVG CSS Properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=140277

Reviewed by Andreas Kling.

Update the new StyleBuilder generator to add support for SVG CSS
Properties whose methods are on SVGRenderStyle instead of RenderStyle.

A new "SVG" parameter is now supported by makeprop.pl to correctly
generate such properties.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPropertyNames.in:
  • css/SVGCSSPropertyNames.in: Removed.

Merged SVG CSS properties into CSSPropertyNames.in. I personally don't
think having a separate file for SVG CSS properties is really helpful.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):
Drop legacy StyleBuilder code for several SVG properties and generate
them instead. Those are trivial and do not require any custom code or
converter.

  • css/StyleResolver.cpp:

Update the id of the first low-priority property.

  • css/makeprop.pl:

Add support for SVG CSS Properties whose methods are on SVGRenderStyle
instead of RenderStyle.

12:30 PM Changeset in webkit [178188] by andersca@apple.com
  • 7 edits
    8 deletes in trunk

Start removing Web Database support from workers
​https://bugs.webkit.org/show_bug.cgi?id=140271

Reviewed by Sam Weinig.

Source/WebCore:

Remove WorkerGlobalScopeWebDatabase which is the entry point for web database in workers.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp: Removed.
  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.h: Removed.
  • Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl: Removed.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Remove Web Database worker tests.

  • fast/workers/storage/change-version-handle-reuse-sync-expected.txt: Removed.
  • fast/workers/storage/change-version-handle-reuse-sync.html: Removed.
  • fast/workers/storage/change-version-handle-reuse-worker-expected.txt: Removed.
  • fast/workers/storage/change-version-handle-reuse-worker.html: Removed.
  • fast/workers/storage/change-version-sync-expected.txt: Removed.
  • fast/workers/storage/change-version-sync.html: Removed.
  • fast/workers/storage/empty-statement-sync-expected.txt: Removed.
  • fast/workers/storage/empty-statement-sync.html: Removed.
  • fast/workers/storage/execute-sql-args-sync-expected.txt: Removed.
  • fast/workers/storage/execute-sql-args-sync.html: Removed.
  • fast/workers/storage/execute-sql-args-worker-expected.txt: Removed.
  • fast/workers/storage/execute-sql-args-worker.html: Removed.
  • fast/workers/storage/executesql-accepts-only-one-statement-sync-expected.txt: Removed.
  • fast/workers/storage/executesql-accepts-only-one-statement-sync.html: Removed.
  • fast/workers/storage/interrupt-database-expected.txt: Removed.
  • fast/workers/storage/interrupt-database-sync-expected.txt: Removed.
  • fast/workers/storage/interrupt-database-sync.html-disabled: Removed.
  • fast/workers/storage/interrupt-database.html: Removed.
  • fast/workers/storage/multiple-databases-garbage-collection-expected.txt: Removed.
  • fast/workers/storage/multiple-databases-garbage-collection.html: Removed.
  • fast/workers/storage/multiple-transactions-expected.txt: Removed.
  • fast/workers/storage/multiple-transactions-on-different-handles-expected.txt: Removed.
  • fast/workers/storage/multiple-transactions-on-different-handles-sync-expected.txt: Removed.
  • fast/workers/storage/multiple-transactions-on-different-handles-sync.html: Removed.
  • fast/workers/storage/multiple-transactions-on-different-handles.html: Removed.
  • fast/workers/storage/multiple-transactions.html: Removed.
  • fast/workers/storage/open-database-creation-callback-sync-expected.txt: Removed.
  • fast/workers/storage/open-database-creation-callback-sync.html: Removed.
  • fast/workers/storage/open-database-empty-version-sync-expected.txt: Removed.
  • fast/workers/storage/open-database-empty-version-sync.html: Removed.
  • fast/workers/storage/open-database-inputs-sync-expected.txt: Removed.
  • fast/workers/storage/open-database-inputs-sync.html: Removed.
  • fast/workers/storage/open-database-set-empty-version-sync-expected.txt: Removed.
  • fast/workers/storage/open-database-set-empty-version-sync.html: Removed.
  • fast/workers/storage/open-database-while-transaction-in-progress-expected.txt: Removed.
  • fast/workers/storage/open-database-while-transaction-in-progress-sync-expected.txt: Removed.
  • fast/workers/storage/open-database-while-transaction-in-progress-sync.html: Removed.
  • fast/workers/storage/open-database-while-transaction-in-progress.html: Removed.
  • fast/workers/storage/read-and-write-transactions-dont-run-together-expected.txt: Removed.
  • fast/workers/storage/read-and-write-transactions-dont-run-together.html: Removed.
  • fast/workers/storage/resources/change-version-handle-reuse-sync.js: Removed.
  • fast/workers/storage/resources/change-version-sync-1.js: Removed.
  • fast/workers/storage/resources/change-version-sync-2.js: Removed.
  • fast/workers/storage/resources/database-worker-controller.js: Removed.
  • fast/workers/storage/resources/database-worker.js: Removed.
  • fast/workers/storage/resources/empty-statement-sync.js: Removed.
  • fast/workers/storage/resources/execute-sql-args-sync.js: Removed.
  • fast/workers/storage/resources/executesql-accepts-only-one-statement-sync.js: Removed.
  • fast/workers/storage/resources/interrupt-database-sync.js: Removed.
  • fast/workers/storage/resources/interrupt-database.js: Removed.
  • fast/workers/storage/resources/multiple-transactions-on-different-handles-sync.js: Removed.
  • fast/workers/storage/resources/multiple-transactions-sync.js: Removed.
  • fast/workers/storage/resources/open-database-creation-callback-sync.js: Removed.
  • fast/workers/storage/resources/open-database-empty-version-sync.js: Removed.
  • fast/workers/storage/resources/open-database-inputs-sync.js: Removed.
  • fast/workers/storage/resources/open-database-set-empty-version-sync.js: Removed.
  • fast/workers/storage/resources/open-database-while-transaction-in-progress-sync.js: Removed.
  • fast/workers/storage/resources/sql-data-types-sync.js: Removed.
  • fast/workers/storage/resources/sql-exception-codes-sync.js: Removed.
  • fast/workers/storage/resources/test-authorizer-sync.js: Removed.
  • fast/workers/storage/resources/test-inputs-common.js: Removed.
  • fast/workers/storage/resources/transaction-in-transaction-sync.js: Removed.
  • fast/workers/storage/resources/use-same-database-in-page-and-workers.js: Removed.
  • fast/workers/storage/sql-data-types-sync-expected.txt: Removed.
  • fast/workers/storage/sql-data-types-sync.html: Removed.
  • fast/workers/storage/sql-exception-codes-sync-expected.txt: Removed.
  • fast/workers/storage/sql-exception-codes-sync.html: Removed.
  • fast/workers/storage/test-authorizer-expected.txt: Removed.
  • fast/workers/storage/test-authorizer-sync-expected.txt: Removed.
  • fast/workers/storage/test-authorizer-sync.html: Removed.
  • fast/workers/storage/test-authorizer.html: Removed.
  • fast/workers/storage/transaction-in-transaction-sync-expected.txt: Removed.
  • fast/workers/storage/transaction-in-transaction-sync.html: Removed.
  • fast/workers/storage/use-same-database-in-page-and-workers-expected.txt: Removed.
  • fast/workers/storage/use-same-database-in-page-and-workers.html: Removed.
  • http/tests/security/cross-origin-worker-websql-allowed-expected.txt: Removed.
  • http/tests/security/cross-origin-worker-websql-allowed.html: Removed.
  • http/tests/security/cross-origin-worker-websql-expected.txt: Removed.
  • http/tests/security/cross-origin-worker-websql.html: Removed.
12:19 PM Changeset in webkit [178187] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed test gardening.

  • platform/win/TestExpectations: Unskip fast/canvas/canvas-path-addPath.html now

that it doesn't crash anymore.

12:17 PM Changeset in webkit [178186] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Layout Test fast/canvas/canvas-path-addPath.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=140303
<rdar://problem/19428865>

Reviewed by Simon Fraser.

Although the code clearly states that CG doesn't allow adding a path to itself,
and branches to handle this case, it simply uses the branch to try adding the
path to itself (ignoring the copy it just made)!

Fix this copy/paste bug so that we use the copy and avoid violating the CG
API contract.

  • platform/graphics/cg/PathCG.cpp:

(WebCore::Path::addPath): Fix path used.

12:10 PM Changeset in webkit [178185] by weinig@apple.com
  • 9 edits
    2 adds in trunk/Source/WebKit2

Make WKNavigation bridged to API::Navigation (Take 2)
​https://bugs.webkit.org/show_bug.cgi?id=140272

Reviewed by Dan Bernstein.

  • Shared/API/APIObject.h:

Add Navigation.

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):
Bridge to WKNavigation.

  • UIProcess/API/APINavigation.cpp: Added.

(API::Navigation::Navigation):
(API::Navigation::~Navigation):

  • UIProcess/API/APINavigation.h: Added.

(API::Navigation::create):
(API::Navigation::request):
Add initial implementation.

  • UIProcess/API/Cocoa/WKNavigation.mm:

(-[WKNavigation dealloc]):
(-[WKNavigation _request]):
(-[WKNavigation _apiObject]):

  • UIProcess/API/Cocoa/WKNavigationInternal.h:

(API::wrapper):
Implement bridging to API::Navigation and get the request from the underlying object.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadRequest:]):
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
(-[WKWebView loadData:MIMEType:characterEncodingName:baseURL:]):
(-[WKWebView goToBackForwardListItem:]):
(-[WKWebView goBack]):
(-[WKWebView goForward]):
(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _restoreSessionState:andNavigate:]):

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::createLoadRequestNavigation):
(WebKit::NavigationState::createBackForwardNavigation):
(WebKit::NavigationState::createReloadNavigation):
(WebKit::NavigationState::createLoadDataNavigation):
(WebKit::NavigationState::LoaderClient::didStartProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didCommitLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishDocumentLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFinishLoadForFrame):
(WebKit::NavigationState::LoaderClient::didFailLoadWithErrorForFrame):
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame):
Switch to storing API::Navigations.

  • WebKit2.xcodeproj/project.pbxproj:

Add the new files.

12:08 PM Changeset in webkit [178184] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Navigation sidebar can show blank next to the Console view
​https://bugs.webkit.org/show_bug.cgi?id=140291

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Don't restore collapsed false if selectedSidebarPanel is null.
(WebInspector._sidebarCollapsedStateDidChange): Support a _ignoreNavigationSidebarPanelCollapsedEvent flag
to avoid setting _navigationSidebarCollapsedSetting.
(WebInspector._navigationSidebarPanelSelected): Force collapsed if selectedSidebarPanel is null.
(WebInspector._contentBrowserCurrentContentViewDidChange): Set _ignoreNavigationSidebarPanelCollapsedEvent
when forcing the collapsed state to avoid setting _navigationSidebarCollapsedSetting and calling
_updateContentViewForCurrentNavigationSidebar.

12:07 PM Changeset in webkit [178183] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] Make decoded image data purgeable ASAP.
<​https://webkit.org/b/140298>

Reviewed by Antti Koivisto.

Mark decoded images as "transient" which makes CoreGraphics mark
the backing stores as purgeable shortly after they're used.

The decoded representation will remain in CoreGraphics's caches
indefinitely unless the kernel gets starved and needs the pages.

Most resources will now reach a state where the encoded data is
mmap'ed from disk cache (once the entire resource is downloaded)
and the decoded data is purgeable.

This also has the side effect of making the MemoryCache more
palatial since the decoded data cost can be deducted for images,
allowing us to cache more resources.

Note that the worst case for this new behavior would be something
like hovering below 100% memory utilization and constantly having
to drop and re-decode images. While churny, it still beats
crashing the process, plus there's tiling to remove many of the
reasons we'd need the decoded data.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameAtIndex):

11:55 AM Changeset in webkit [178182] by yoon@igalia.com
  • 16 edits
    2 moves in trunk/Source

Rename GraphicsLayerAnimation to TextureMapperAnimation
​https://bugs.webkit.org/show_bug.cgi?id=140296

Reviewed by Martin Robinson.

Source/WebCore:

GraphicsLayerAnimation is only used by TextureMapper and CoordinatedGraphics.
This should be placed in the platform/graphics/texmap.
And this patch also changes its name to TextureMapperAnimation to remove ambiguity.

No new tests because this is a simply refactoring.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::addAnimation):
(WebCore::GraphicsLayerTextureMapper::setAnimations):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperAnimation.cpp: Renamed from Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp.
  • platform/graphics/texmap/TextureMapperAnimation.h: Renamed from Source/WebCore/platform/graphics/GraphicsLayerAnimation.h.
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::setAnimations):

  • platform/graphics/texmap/TextureMapperLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addAnimation):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

Source/WebKit2:

GraphicsLayerAnimation is changed to TextureMapperAnimation

  • Scripts/webkit/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<TextureMapperAnimation>::encode):
(IPC::ArgumentCoder<TextureMapperAnimation>::decode):
(IPC::ArgumentCoder<TextureMapperAnimations>::encode):
(IPC::ArgumentCoder<TextureMapperAnimations>::decode):
(IPC::ArgumentCoder<GraphicsLayerAnimation>::encode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimation>::decode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimations>::encode): Deleted.
(IPC::ArgumentCoder<GraphicsLayerAnimations>::decode): Deleted.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
11:41 AM Changeset in webkit [178181] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Temporarily disable all media tests.

  • platform/win/TestExpectations:
11:33 AM Changeset in webkit [178180] by Antti Koivisto
  • 11 edits in trunk/Source/WebCore

FontCache should only deal with SimpleFontData
​https://bugs.webkit.org/show_bug.cgi?id=140293

Reviewed by Andreas Kling.

FontCache::fontForFamilyAtIndex hands out FontData objects and calls to FontSelector. That sort
of code does not belong to the cache layer. Move the functionality up to FontGlyphs.

  • platform/graphics/Font.cpp:

(WebCore::Font::operator==):
(WebCore::Font::drawText):
(WebCore::Font::drawEmphasisMarks):
(WebCore::Font::isLoadingCustomFonts):

  • platform/graphics/Font.h:

(WebCore::Font::loadingCustomFonts): Deleted.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::similarFontPlatformData):

Generic null implementation to reduce #ifs.

(WebCore::FontCache::fontForFamilyAtIndex): Deleted.

  • platform/graphics/FontCache.h:

Unfriend FontGlyphs.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::isLoadingCustomFonts):

We can figure thus out cheaply without caching a bit.

(WebCore::realizeNextFamily):
(WebCore::FontGlyphs::realizeFontDataAt):

Reorganize a bit to make the logic clearer.
Get rid of the strange cAllFamiliesScanned constant.

(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalVariant):

Loop until null, that always works.

  • platform/graphics/FontGlyphs.h:

(WebCore::FontGlyphs::loadingCustomFonts): Deleted.

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::similarFontPlatformData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::FontCache::similarFontPlatformData):

  • platform/graphics/mac/FontMac.mm:

(WebCore::Font::dashesForIntersectionsWithRect):

11:29 AM Changeset in webkit [178179] by ap@apple.com
  • 3 edits in trunk/Tools

platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
​https://bugs.webkit.org/show_bug.cgi?id=140300

Reviewed by Simon Fraser.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::updateWindowScaleForTest):
(WTR::TestController::configureViewForTest):

  • WebKitTestRunner/TestController.h:
11:29 AM Changeset in webkit [178178] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update expectations for fast/text/atsui-rtl-override-selection.html, which also
fails on Mountain Lion after enabling kerning and ligatures.

  • platform/mac/TestExpectations:
11:27 AM Changeset in webkit [178177] by Csaba Osztrogonác
  • 6 edits in trunk/Source

REGRESSION(r177925): It broke the !ENABLE(INSPECTOR) build
​https://bugs.webkit.org/show_bug.cgi?id=140098

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/InspectorBackendDispatcher.h: Missing ENABLE(INSPECTOR) guard added.

Source/WebCore:

  • inspector/InspectorInstrumentationCookie.cpp: Removed ENABLE(INSPECTOR) guard,

becaue InspectorInstrumentationCookie is used everywhere unconditionally.

  • inspector/InspectorInstrumentationCookie.h: Removed ENABLE(INSPECTOR) guard.
  • loader/appcache/ApplicationCacheGroup.h: Removed ENABLE(INSPECTOR) guard around

m_currentResourceIdentifier, because it is used unconditionally in the cpp.

10:58 AM Changeset in webkit [178176] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix crash introduced in r178029
​https://bugs.webkit.org/show_bug.cgi?id=140289

Patch by Byungseon Shin <​sun.shin@lge.com> on 2015-01-09
Reviewed by Martin Robinson.

Clearing childClippingMaskLayer of CoordinatedGraphics should be called
before clearing childClippingLayer.

No new tests, covered by existing tests.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::~RenderLayerBacking):

10:31 AM Changeset in webkit [178175] by enrica@apple.com
  • 6 edits in trunk/Source

[iOS] Cannot paste an image URL in a plain text field in a page.
​https://bugs.webkit.org/show_bug.cgi?id=140274
rdar://problem/18590809

Reviewed by Alexey Proskuryakov.

Source/WebCore:

When we want to get plain text from the pasteboard, we
should also try kUTTypeURL if there is no kUTTypeText available.

  • WebCore.exp.in:
  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::read):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::readString):

Source/WebKit2:

supportedPasteboardTypesForCurrentSelection should include kUTTypeURL for plain
text controls and WebArchivePboardType for rich text controls.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView supportedPasteboardTypesForCurrentSelection]): Remove obsolete and
incorrect FIXME.

9:50 AM Changeset in webkit [178174] by commit-queue@webkit.org
  • 9 edits
    2 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r178141.
​https://bugs.webkit.org/show_bug.cgi?id=140294

Broke multiple API tests (Requested by ap on #webkit).

Reverted changeset:

"Make WKNavigation bridged to API::Navigation"
​https://bugs.webkit.org/show_bug.cgi?id=140272
​http://trac.webkit.org/changeset/178141

9:44 AM Changeset in webkit [178173] by commit-queue@webkit.org
  • 30 edits in trunk/Source

Unreviewed, rolling out r178154, r178163, and r178164.
​https://bugs.webkit.org/show_bug.cgi?id=140292

Still multiple assertion failures on tests (Requested by ap on
#webkit).

Reverted changesets:

"Modernize and streamline HTMLTokenizer"
​https://bugs.webkit.org/show_bug.cgi?id=140166
​http://trac.webkit.org/changeset/178154

"Unreviewed speculative buildfix after r178154."
​http://trac.webkit.org/changeset/178163

"One more unreviewed speculative buildfix after r178154."
​http://trac.webkit.org/changeset/178164

9:16 AM Changeset in webkit [178172] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[MSE] Implement Append Window support.
​https://bugs.webkit.org/show_bug.cgi?id=139861

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2015-01-09
Reviewed by Jer Noble.

Source/WebCore:

Implement Append Windows support for SourceBuffer as per spec.
Also change order in idl to match spec order.

Test: media/media-source/media-source-append-buffer-with-append-window.html

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer):
(WebCore::SourceBuffer::appendWindowStart):
(WebCore::SourceBuffer::setAppendWindowStart):
(WebCore::SourceBuffer::appendWindowEnd):
(WebCore::SourceBuffer::setAppendWindowEnd):
(WebCore::SourceBuffer::abort):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/SourceBuffer.idl:

LayoutTests:

Added test which checks whether correct samples from contiguous range of samples are added
when manipulating appendWindow.

  • media/media-source/media-source-append-buffer-with-append-window-expected.txt: Added.
  • media/media-source/media-source-append-buffer-with-append-window.html: Added.
7:29 AM Changeset in webkit [178171] by Chris Fleizach
  • 5 edits in trunk/Source/WebCore

AX: Crash at -[WebAccessibilityObjectWrapperBase accessibilityTitle] + 31
​https://bugs.webkit.org/show_bug.cgi?id=140286

Reviewed by Mario Sanchez Prada.

This is crashing because AppKit is checking if certain method names like "accessibilityTitle" exist,
and then it bypasses accessibilityAttributeValue: to call directly into those methods.

That bypasses are safety checks. I think a safe way to avoid this is rename our methods.

No new tests, problem only occurs when triggered through AppKit.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityLabel]):
(-[WebAccessibilityObjectWrapper accessibilityHint]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase baseAccessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase baseAccessibilityHelpText]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]): Deleted.
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]): Deleted.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

5:50 AM Changeset in webkit [178170] by mtibor@inf.u-szeged.hu
  • 2 edits in trunk/Tools

Unreviewed. Moving myself to the committer section.

  • Scripts/webkitpy/common/config/contributors.json:
5:33 AM Changeset in webkit [178169] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer][MSE] ASSERT in MediaSourceClientGStreamer::addSourceBuffer
​https://bugs.webkit.org/show_bug.cgi?id=140119

Reviewed by Carlos Garcia Campos.

  • platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:

(WebCore::MediaSourceClientGStreamer::addSourceBuffer): Use a raw
pointer for the ghost pad, its reference is then taken once attached
to the parent element.

5:26 AM Changeset in webkit [178168] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

After r178166, ANGLE's EGL/GLES/GLES2 headers are included before the
system-default headers because the Source/ThirdParty/ANGLE/include
directory is searched through. This shouldn't be the case for ports
which want to use system-default headers and are searching for them
explicitly. To avoid that, OPENGL_INCLUDE_DIR or OPENGLES2_INCLUDE_DIR
should be added to WebCore_INCLUDE_DIRECTORIES before ANGLE directories.

Rubber-stamped by Carlos Garcia Campos.

  • CMakeLists.txt:
3:48 AM Changeset in webkit [178167] by Carlos Garcia Campos
  • 1 edit
    1 add in trunk/Tools

Add a script to check for platform layering violations
​https://bugs.webkit.org/show_bug.cgi?id=140248

Reviewed by Darin Adler.

It prints all the cases where files inside platform include
headers that are not in platform directory.

  • Scripts/check-for-platform-layering-violations: Added.

(get_platform_headers):
(check_source_file):

3:46 AM Changeset in webkit [178166] by Carlos Garcia Campos
  • 16 edits in trunk/Source/WebCore

Use angle-bracket form to include external headers in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=140288

Reviewed by Žan Doberšek.

  • CMakeLists.txt:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:
  • platform/graphics/harfbuzz/HarfBuzzFace.cpp:
  • platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp:
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:
  • platform/graphics/win/GraphicsContext3DWin.cpp:
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
  • platform/image-decoders/png/PNGImageDecoder.cpp:
  • platform/image-decoders/webp/WEBPImageDecoder.cpp:
  • platform/image-encoders/JPEGImageEncoder.cpp:
  • platform/image-encoders/PNGImageEncoder.cpp:
  • platform/text/TextEncodingDetectorICU.cpp:
12:07 AM Changeset in webkit [178165] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

12:06 AM Changeset in webkit [178164] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

One more unreviewed speculative buildfix after r178154.

  • xml/parser/CharacterReferenceParserInlines.h:

(WebCore::consumeCharacterReference): Remove highestValidCharacter too, it became unused after r178163.

12:01 AM Changeset in webkit [178163] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed speculative buildfix after r178154.

  • xml/parser/CharacterReferenceParserInlines.h:

(WebCore::consumeCharacterReference): Remove unused overflow variable.

Note: See TracTimeline for information about the timeline view.