Timeline



Jan 18, 2015:

11:15 PM Changeset in webkit [178641] by ddkilzer@apple.com
  • 5 edits in trunk/Tools

iOS EWS queue name should be consistent
<​http://webkit.org/b/140585>

Reviewed by Daniel Bates.

  • Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'

to 'ios'.

  • Scripts/webkitpy/common/config/ports.py: Ditto.

(DeprecatedPort.port):
(IOSPort):

  • Scripts/webkitpy/port/ios.py: Ditto.

(IOSPort):

  • Scripts/webkitpy/port/factory.py:

(PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
appears before ios.IOSPort. If this is not done,
run-webkit-tests --ios-simulator will get the wrong Port class
(IOSPort instead of IOSSimulatorPort) due to the way that
PortFactory.get() uses prefix matching of <Port>.port_name to
find the correct class to use.

11:07 PM Changeset in webkit [178640] by ap@apple.com
  • 2 edits in trunk/LayoutTests

http/tests/navigation/navigation-interrupted-by-fragment.html frequently times out
​https://bugs.webkit.org/show_bug.cgi?id=140607

  • platform/mac-wk2/TestExpectations: Added an expectation.
10:57 PM Changeset in webkit [178639] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

Update bindings generation test results after <​https://trac.webkit.org/changeset/178633>.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):

9:32 PM Changeset in webkit [178638] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Generate matchingShorthandsForLonghand() implementation from CSSPropertyNames.in
​https://bugs.webkit.org/show_bug.cgi?id=140599

Reviewed by Antti Koivisto.

Generate matchingShorthandsForLonghand() implementation from
CSSPropertyNames.in. We already have all the information we need in
CSSPropertyNames.in to generate the big switch() in
matchingShorthandsForLonghand().

A few shorthands still aren't generated. I will look into getting rid
of the custom code in a follow-up patch.

  • css/StylePropertyShorthand.cpp:

(WebCore::makeVector): Deleted.
(WebCore::matchingShorthandsForLonghand): Deleted.

  • css/StylePropertyShorthand.h:

(WebCore::matchingCustomShorthandsForLonghand):

  • css/makeprop.pl:

(constructShorthandsVector):

9:14 PM Changeset in webkit [178637] by dino@apple.com
  • 3 edits
    2 adds in trunk

Out of bounds write in canvas.toDataURL
​https://bugs.webkit.org/show_bug.cgi?id=140594
<rdar://problem/19449135>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

In the case where we have a canvas object that does
not have premultiplied alpha (an option you can select
when using WebGL) we have to multiply out the alpha when
converting to JPEG via toDataURL.

For this we created a buffer, but were not accurately
resizing it before flattening the alpha.

Test: fast/canvas/webgl/toDataURL-unpremultipliedAlpha.html

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageDataToDataURL): Call resize once we've
determined we have enough space.

LayoutTests:

Creates a WebGL context that does not have
premultiplied alpha, fills it with 50% transparent white,
and attempts to convert the canvas to a JPEG data URL. This
exercises the code path that was not accurately
allocating data (to flatten the alpha).

  • fast/canvas/webgl/toDataURL-unpremultipliedAlpha-expected.txt: Added.
  • fast/canvas/webgl/toDataURL-unpremultipliedAlpha.html: Added.
4:03 PM Changeset in webkit [178636] by dbates@webkit.org
  • 5 edits in trunk/Source

Attempt to fix the iOS build after <​http://trac.webkit.org/changeset/178631>
(​https://bugs.webkit.org/show_bug.cgi?id=129441)

Source/WebKit/mac:

Pass lvalue reference to WebCore::Highlight instead of pointer in call to InspectorController::getHighlight().
Also substitute HighlightType::Node and HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.

  • WebInspector/WebNodeHighlightView.mm:

(-[WebNodeHighlightView layoutSublayers:]):

Source/WebKit2:

  • UIProcess/WKInspectorHighlightView.mm:

(-[WKInspectorHighlightView update:]): Substitute HighlightType::Node and
HighlightType::Rects for HighlightTypeNode and HighlightTypeRects, respectively.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight): Pass lvalue reference to WebCore::Highlight
instead of pointer in call to InspectorController::getHighlight().

2:16 PM Changeset in webkit [178635] by weinig@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix style issues and add availability macros missed in r178634
​https://bugs.webkit.org/show_bug.cgi?id=140597

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h:

Add missing availability macros.

  • UIProcess/API/Cocoa/_WKUserContentFilter.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.mm:

(-[_WKUserContentFilter initWithName:serializedRules:]):
(-[_WKUserContentFilter _initWithName:serializedRules:]): Deleted.
Removed unnecessary leading underscore from init method.

1:54 PM Changeset in webkit [178634] by weinig@apple.com
  • 33 edits
    8 adds
    2 deletes in trunk/Source

Add initial experimental user content filtering API
​https://bugs.webkit.org/show_bug.cgi?id=140584

Reviewed by Benjamin Poulain.

Source/WebCore:

Change content extensions to be managed through the UserContentController.

  • WebCore.exp.in:

Update exports.

  • WebCore.xcodeproj/project.pbxproj:

Update for removed files.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::removeAllRuleLists):
(WebCore::ContentExtensions::ContentExtensionsBackend::sharedInstance): Deleted.

  • contentextensions/ContentExtensionsBackend.h:

Remove concept of a shared instance and add a removeAllRuleLists() function.

  • contentextensions/ContentExtensionsInterface.cpp: Removed.
  • contentextensions/ContentExtensionsInterface.h: Removed.

Since there is no shared instance anymore, checking if a URL should be blocked
now has to go directly to the backend.

  • contentextensions/ContentExtensionsManager.cpp:

(WebCore::ContentExtensions::ExtensionsManager::createRuleList):
(WebCore::ContentExtensions::ExtensionsManager::loadExtension): Deleted.

  • contentextensions/ContentExtensionsManager.h:

Update interface to accommodate the lack of a shared instance. Now, all this
file does is take a serialized rule list and outputs the Vector of ContentExtensionRules

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
Check with the UserContentController to see if the URL should be blocked.

  • page/UserContentController.cpp:

(WebCore::UserContentController::addUserContentFilter):
(WebCore::UserContentController::removeAllUserContentFilters):
(WebCore::UserContentController::contentFilterBlocksURL):

  • page/UserContentController.h:

Add single point of interaction for both the WebKit level to add and remove
content filters and WebCore to check to see if URLs should be blocked.

Source/WebKit2:

Moves content filtering from being per-ProcessPool to per-UserContentController.

  • Shared/API/APIObject.h:
  • Shared/API/c/WKBase.h:
  • UIProcess/API/APIUserContentFilter.cpp: Added.

(API::UserContentFilter::UserContentFilter):
(API::UserContentFilter::~UserContentFilter):

  • UIProcess/API/APIUserContentFilter.h: Added.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKUserContentFilterRef.cpp: Added.

(WKUserContentFilterGetTypeID):
(WKUserContentFilterCreate):

  • UIProcess/API/C/WKUserContentFilterRef.h: Added.
  • UIProcess/API/C/WebKit2_C.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.h: Added.
  • UIProcess/API/Cocoa/_WKUserContentFilter.mm: Added.

(WKUserContentControllerAddUserContentFilter):
(WKUserContentControllerRemoveAllUserContentFilters):
(-[_WKUserContentFilter _initWithName:ruleList:]):

  • UIProcess/API/Cocoa/_WKUserContentFilterInternal.h: Added.

Add a basic UserContentFilter type and expose it via both the Objective-C API (as _WKUserContentFilter)
and via the C SPI (as WKUserContentFilterRef).

  • UIProcess/API/C/WKUserContentControllerRef.h:
  • UIProcess/API/C/WKUserContentControllerRef.cpp:

Add C-SPI to set and remove WKUserContentFilterRefs.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _loadContentExtensionWithIdentifier:serializedRules:successCompletionHandler:errorCompletionHandler:]): Deleted.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processDidFinishLaunching):
(WebKit::WebProcessPool::loadContentExtension): Deleted.

  • UIProcess/WebProcessPool.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::loadContentExtension): Deleted.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Remove the old SPI for loading content filters that was per-ProcessPool. Content filters now follow
the same pattern as UserScripts and UserStyleSheets as being per-UserContentController.

  • UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController _addUserContentFilter:]):
(-[WKUserContentController _removeAllUserContentFilters]):

  • UIProcess/API/Cocoa/WKUserContentControllerInternal.h:
  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h: Added.
  • UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::WebUserContentControllerProxy):
(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserContentFilter):
(WebKit::WebUserContentControllerProxy::removeAllUserContentFilters):

  • UIProcess/UserContent/WebUserContentControllerProxy.h:
  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addUserContentFilters):
(WebKit::WebUserContentController::removeAllUserContentFilters):

  • WebProcess/UserContent/WebUserContentController.h:
  • WebProcess/UserContent/WebUserContentController.messages.in:

Pipe user content filters over to all the WebProcesses that the UserContentController is
connected to.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

12:57 PM Changeset in webkit [178633] by Darin Adler
  • 5 edits in trunk/Source/WebCore

REGRESSION (r125251): wrapper lifetimes of SVGElementInstance are incorrect
​https://bugs.webkit.org/show_bug.cgi?id=132148

Reviewed by Anders Carlsson.

Test: svg/custom/use-instanceRoot-event-listeners.xhtml

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::addEventListener): Updated for the new return type
of JSListener::create. For the event type, use JSString::toAtomicString instead of
calling JSString::value and then converting to an AtomicString.
(WebCore::JSDOMWindow::removeEventListener): Same changes as for addEventListener.

  • bindings/js/JSEventListener.cpp:

(WebCore::forwardsEventListeners): Added. Helper to detect the special case needed
for SVGElementInstance. In the future, for better encapsulation, we could use virtual
functions, but for now hard coding this single class seems fine.
(WebCore::correspondingElementWrapper): Added. For use if forwardsEventListeners
returns true, to find out where event listeners will be forwarded.
(WebCore::createJSEventListenerForAttribute): Added. Replaces the old function
createJSAttributeEventListener, for SVGElementInstance attributes only.
(WebCore::createJSEventListenerForAdd): Added. Helper function to avoid repeated
generated code in the addElementListener bindings other than the DOMWindow one.

  • bindings/js/JSEventListener.h:

(WebCore::JSEventListener::create): Changed to return a Ref instead of a PassRefPtr.
(WebCore::createJSEventListenerForAttribute): Renamed from createJSAttributeEventListener,
changed to return a RefPtr instead of a PassRefPtr and to take references rather than
pointers for non-null things.
(WebCore::createJSEventListenerForRemove): Added. Small wrapper that calls
createJSEventListenerForAdd since they are currently identical.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeEventListenerCall): Removed the special case for JSSVGElementInstance
and updated to call the new createJSEventListenerForAttribute. The special case for
SVGElementInstance is now in JSEventListener.h/cpp, which is nicer since we prefer to
keep the generated code simpler if possible.
(GenerateEventListenerCall): Removed the special case for JSSVGElementInstance. This
has been dead code since the explicit definition of add/removeEventListener was removed
from SVGElementInstance.idl, and was also a problem if someone were to use the
addEventListener function from EventTarget on an SVGElementInstance object. The function
needs to be generic at runtime. Use toAtomicString as in JSDOMWindow::addEventListener above.
Call the two new functions, createJSEventListenerForAdd and createJSEventListenerForRemove.
Those new functions properly handle SVGElementInstance.
(GenerateImplementation): Don't pass the class name to GenerateAttributeEventListenerCall
or GenerateEventListenerCall any more.
(GenerateConstructorDefinition): Use JSString::toAtomicString instead of calling
JSString::value and then converting to AtomicString.

12:03 PM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
12:00 PM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
11:52 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
11:50 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
10:39 AM Changeset in webkit [178632] by ap@apple.com
  • 2 edits in trunk/Tools

build.webkit.org/dashboard: OS X EWS is now on Mavericks
​https://bugs.webkit.org/show_bug.cgi?id=140595

Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

9:07 AM Changeset in webkit [178631] by Brian Burg
  • 13 edits
    1 add in trunk/Source

Web Inspector: highlight data for overlay should use protocol type builders
​https://bugs.webkit.org/show_bug.cgi?id=129441

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Add a new domain for overlay types.

  • CMakeLists.txt:
  • DerivedSources.make:
  • inspector/protocol/OverlayTypes.json: Added.

Source/WebCore:

As a first step towards cleaning up the inspector overlay, convert highlight
data construction to use protocol type builders. It's now really obvious what
data is being sent to the inspector overlay page.

This change paves the way towards using inspector protocol commands and events
if we want to support more interactive functionality in the inspector overlay.

This patch makes a few style cleanups, such as standardizing variable names,
using default member initializers, passing by reference, and fixing casts.

No new tests, no behavior changed.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::getHighlight):
(WebCore::InspectorController::buildObjectForHighlightedNode):
(WebCore::InspectorController::inspect): Deleted.

  • inspector/InspectorController.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildNodeHighlight):
(WebCore::buildQuadHighlight):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::buildObjectForPoint):
(WebCore::buildObjectForRect):
(WebCore::buildArrayForQuad):
(WebCore::buildObjectForHighlight):
(WebCore::buildObjectForRegion):
(WebCore::buildObjectForFlowRegions):
(WebCore::buildObjectForSize):
(WebCore::buildQuadObjectForCSSRegionContentClip):
Simplify how the clipping area is encoded. It's now 'regionClippingArea'
stored on a FragmentHighlightData instance.

(WebCore::InspectorOverlay::updatePaintRectsTimerFired):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::buildArrayForRendererFragments):
(WebCore::appendPathCommandAndPoints):
(WebCore::appendPathSegment):
(WebCore::buildObjectForShapeOutside):
(WebCore::buildObjectForElementData):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawNodeHighlight):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reset):
(WebCore::buildObjectForRegionHighlight): Deleted.
(WebCore::buildObjectForCSSRegionsHighlight): Deleted.
(WebCore::buildObjectForCSSRegionContentClip): Deleted.
(WebCore::buildObjectForRendererFragments): Deleted.
(WebCore::buildObjectForElementInfo): Deleted.

  • inspector/InspectorOverlay.h:

(WebCore::Highlight::Highlight):

  • inspector/InspectorOverlayPage.js:

(_createElementTitle):
(_drawElementTitle):
(_drawFragmentHighlight):
(drawNodeHighlight):

  • testing/Internals.cpp:

(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Update symbol.

Jan 17, 2015:

5:41 PM Changeset in webkit [178630] by Chris Dumez
  • 9 edits
    3 copies
    1 add in trunk/Source/WebKit2

[WK2][iOS] Add Cocoa delegate for logging diagnostic messages
​https://bugs.webkit.org/show_bug.cgi?id=140410

Reviewed by Sam Weinig.

Add Cocoa delegate for logging diagnostic messages.

  • UIProcess/API/APIDiagnosticLoggingClient.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.

(API::DiagnosticLoggingClient::~DiagnosticLoggingClient):
(API::DiagnosticLoggingClient::logDiagnosticMessage):
(API::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
(API::DiagnosticLoggingClient::logDiagnosticMessageWithValue):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageDiagnosticLoggingClient):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _diagnosticLoggingDelegate]):
(-[WKWebView _setDiagnosticLoggingDelegate:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.
  • UIProcess/Cocoa/DiagnosticLoggingClient.h: Copied from Source/WebKit2/UIProcess/WebPageDiagnosticLoggingClient.h.
  • UIProcess/Cocoa/DiagnosticLoggingClient.mm: Added.

(WebKit::DiagnosticLoggingClient::DiagnosticLoggingClient):
(WebKit::DiagnosticLoggingClient::delegate):
(WebKit::DiagnosticLoggingClient::setDelegate):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::DiagnosticLoggingClient::logDiagnosticMessageWithValue):

  • UIProcess/WebPageDiagnosticLoggingClient.cpp:

(WebKit::WebPageDiagnosticLoggingClient::WebPageDiagnosticLoggingClient):

  • UIProcess/WebPageDiagnosticLoggingClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setDiagnosticLoggingClient):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::logDiagnosticMessage):
(WebKit::WebPageProxy::logDiagnosticMessageWithResult):
(WebKit::WebPageProxy::logDiagnosticMessageWithValue):
(WebKit::WebPageProxy::initializeDiagnosticLoggingClient): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::diagnosticLoggingClient):

  • WebKit2.xcodeproj/project.pbxproj:
4:20 PM Changeset in webkit [178629] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

Crash in JSScope::resolve() on tools.ups.com
​https://bugs.webkit.org/show_bug.cgi?id=140579

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

For op_resolve_scope of a global property or variable that needs to check for the var
injection check watchpoint, we need to keep the scope around with a Phantom. The
baseline JIT slowpath for op_resolve_scope needs the scope value if the watchpoint
fired.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

New regression test.

  • js/regress-140579-expected.txt: Added.
  • js/regress-140579.html: Added.
  • js/script-tests/regress-140579.js: Added.

(Test.this.isString):
(Test.this.test):
(Test):

2:51 PM Changeset in webkit [178628] by mmaxfield@apple.com
  • 5 edits in trunk/Source/WebCore

[SVG -> OTF Converter] Crashes when SVG font is invalid
​https://bugs.webkit.org/show_bug.cgi?id=140378

Reviewed by Antti Koivisto.

Because CachedSVGFonts are cached, they have to be able to be used
in subsequent documents regardless how the first document left it.

Tests: fast/css/font-face-svg-decoding-error.html

svg/custom/svg-fonts-in-html.html
svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures.html

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::getFontData):
(WebCore::CachedSVGFont::ensureCustomFontData):
(WebCore::CachedSVGFont::maybeInitializeExternalSVGFontElement):

  • loader/cache/CachedSVGFont.h:
9:18 AM Changeset in webkit [178627] by Chris Dumez
  • 6 edits in trunk

Converting time, angle and frequency units in CSS calc() function
​https://bugs.webkit.org/show_bug.cgi?id=138356

Reviewed by Darin Adler.

Source/WebCore:

Update CSSPrimitiveValue::primitiveType() to actually query the
primitiveType of the CSSCalcValue instead of assuming a given
type based on its category (e.g. If category is CalcTime, then
assume type is CSS_MS, even though it would be CSS_S as well).

This would like to calculation errors such as:
calc(4s + 1s) -> 5ms

Because we would assume the unit is CSS_MS without actually
checking.

This patch is inspired by the following Blink revision
by <​rhodovan.u-szeged@partner.samsung.com> and initial WebKit
patch from <​tmeszaros.u-szeged@partner.samsung.com>:
​https://src.chromium.org/viewvc/blink?view=rev&revision=179101

Test: fast/css/calc-with-angle-time-frequency.html

  • css/CSSCalculationValue.h:

(WebCore::CSSCalcValue::primitiveType):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::primitiveType):

LayoutTests:

Update fast/css/calc-with-angle-time-frequency.html to include more
test cases and actually validate the result of the calculation,
instead of merely setting the CSS property and being happy if we don't
crash.

  • fast/css/calc-with-angle-time-frequency-expected.txt:
  • fast/css/calc-with-angle-time-frequency.html:
8:54 AM Changeset in webkit [178626] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Generate shorthandForProperty() implementation from CSSPropertyNames.in
​https://bugs.webkit.org/show_bug.cgi?id=140556

Reviewed by Darin Adler.

Generate shorthandForProperty() implementation from CSSPropertyNames.in.
This is just a big switch() statement calling the right
StylePropertyShorthand factory function for a given CSSPropertyID.

  • css/StylePropertyShorthand.cpp:

(WebCore::shorthandForProperty): Deleted.

  • css/StylePropertyShorthand.h:
  • css/makeprop.pl:
8:49 AM Changeset in webkit [178625] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r178618): Change to WKWebViewConfiguration broke iOS build
<​https://bugs.webkit.org/show_bug.cgi?id=140559>

Blind fix to address the following build failure:

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:79:7: error: interface type cannot be statically allocated

T m_value;


*

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:94:55: note: in instantiation of template class 'LazyInitialized<WKWebViewContentProviderRegistry>' requested here

LazyInitialized<WKWebViewContentProviderRegistry> _contentProviderRegistry;


Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:53:21: error: assigning to 'WKWebViewContentProviderRegistry *' from incompatible type 'RetainPtr<WKWebViewContentProviderRegistry *>'

m_value = f();

~

Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:222:37: note: in instantiation of function template specialization 'LazyInitialized<WKWebViewContentProviderRegistry>::get<(lambda at Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:222:41)>' requested here

return _contentProviderRegistry.get([] { return adoptNS([[WKWebViewContentProviderRegistry alloc] init]); });


Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:57:24: error: property 'get' not found on object of type 'WKWebViewContentProviderRegistry *'

return m_value.get();


3 errors generated.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm: Change

_contentProviderRegistry to be a LazyInitialized<RetainPtr<>> to
match other instance variables.

8:08 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
7:55 AM WebKitGTK/2.4.x edited by berto@igalia.com
(diff)
2:48 AM Changeset in webkit [178624] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots

  • Scripts/webkitpy/port/ios.py:

(IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
the Mountain Lion and Mavericks bots.

2:08 AM Changeset in webkit [178623] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix webkitpy tests on GTK Linux ports

  • Scripts/webkitpy/port/ios.py:

(IOSPort.determine_full_port_name): Set a sensible default if
not running on a Mac platform or if no iOS SDK is installed.

12:42 AM Changeset in webkit [178622] by ddkilzer@apple.com
  • 14 edits in trunk/Tools

Create iOS-EWS client queue
​https://bugs.webkit.org/show_bug.cgi?id=140476

Patch by Jake Nielsen <​jacob_nielsen@apple.com> on 2015-01-17
Reviewed by Alexey Proskuryakov.

  • EWSTools/start-queue-mac.sh:

Adds call to configure-xcode-for-ios-development for iOS EWS.

  • Scripts/webkitpy/common/config/ews.json:

Adds the iOS EWS config entry.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
Adds IOSPort to the port map.
(IOSPort):
(IOSPort.build_webkit_command):
Adds --sdk=iphoneos to the webkit build command.

  • Scripts/webkitpy/port/base.py:

(Port.architecture):
Adds an accessor for the architecture member variable.

  • Scripts/webkitpy/port/factory.py:

(PortFactory):
Adds IOSPort to the port class list.

  • Scripts/webkitpy/port/ios.py:

Adds the IOSPort to encapsulate iOS-specific things.
(IOSPort):
(IOSPort.determine_full_port_name):
(IOSPort.init):
(IOSPort._build_driver_flags):
(IOSPort.operating_system):

  • Scripts/webkitpy/tool/commands/download_unittest.py:

Adds the archetecture option to the mock options.
(DownloadCommandsTest._default_options):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

Appends the archetecture option into calls to webkit-patch.
(AbstractEarlyWarningSystem.review_patch):
(AbstractEarlyWarningSystem.run_command):
(AbstractEarlyWarningSystem.load_ews_classes):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Adds logic to soothe the unittest now that --architecture is being
thrown around everywhere.
(EarlyWarningSystemTest._default_expected_logs):

  • Scripts/webkitpy/tool/commands/queues.py:

Adds glue code to ferry the --architecture option around.
(AbstractQueue.init):
(PatchProcessingQueue.begin_work_queue):

  • Scripts/webkitpy/tool/steps/abstractstep.py:

Adds the archetecture option to all AbstractSteps so that
EarlyWarningSystem doesn't start shoving --architecture into
unsuspecting commands.
(AbstractStep.options):

  • Scripts/webkitpy/tool/steps/build.py:

Translates the --architecture option into an ARCHS= format to pass to
build-webkit.
(Build.build):

  • Scripts/webkitpy/tool/steps/options.py:

Adds a definition for the --architecture option.
(Options):

Note: See TracTimeline for information about the timeline view.