Context Navigation

ScriptSyntaxTree now uses Symbols for identifying AST node types
instead of strings. This will prevent any direct usage of strings
for node types instead of a direct property access off the
ScriptSyntaxTree constructor.

This patch also does some gardening work:

TypeTokenAnnotator only walks over the incoming type information data once to be more efficient.
TypeTokenView is now smarter about updating its associated DOM node only if its display name has changed.

UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode):

UserInterface/External/Esprima/esprima.js:

(.):

UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.gatherIdentifiersInVariableDeclaration):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):

UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype.update):

LayoutTests:

inspector/model/parse-script-syntax-tree-expected.txt:
inspector/model/parse-script-syntax-tree.html:

10:31 PM Changeset in webkit [180387] by dburkart@apple.com

4 edits in branches/safari-600.5-branch/Source/WebCore

Merged r180063. <rdar://19812938>

10:14 PM Changeset in webkit [180386] by shiva.jm@samsung.com

3 edits in trunk/Source/WebKit2

Fix build warning in WebKit2/WebProcess and UIProcess module.
https://bugs.webkit.org/show_bug.cgi?id=141794.

Reviewed by Anders Carlsson.

Fix build warning by using UNUSED_PARAM macro.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::computeWebProcessAccessType):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::deleteWebsiteData):

10:06 PM Changeset in webkit [180385] by dburkart@apple.com

7 edits in branches/safari-600.5-branch/Source

Merged r180062. <rdar://19812938>

9:53 PM Changeset in webkit [180384] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Use of Array.from for NodeList/Arguments to Array conversion
https://bugs.webkit.org/show_bug.cgi?id=141819

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-19
Reviewed by Timothy Hatcher.

Array.from is clearer than Array.prototype.slice.call(arrayLike).

UserInterface/Base/Test.js:

(.console.logType):

UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Command.prototype.promise):
(InspectorBackend.Command.prototype._invokeWithArguments):

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._allMessages):

9:40 PM Changeset in webkit [180383] by dburkart@apple.com

2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179956. <rdar://19812935>

9:37 PM Changeset in webkit [180382] by dburkart@apple.com

2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179937. <rdar://19812932>

9:30 PM Changeset in webkit [180381] by dburkart@apple.com

1 edit
3 copies in branches/safari-600.5-branch/LayoutTests

Merged r179936. <rdar://19812932>

9:25 PM Changeset in webkit [180380] by dburkart@apple.com

7 edits
4 copies
2 deletes in branches/safari-600.5-branch

Merged r179933. <rdar://19812926>

6:37 PM Changeset in webkit [180379] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Make EnvironmentVariables::appendValue() handle the case where the existing value is an empty string.
https://bugs.webkit.org/show_bug.cgi?id=141818.

Patch by Remy Demarest <rdemarest@apple.com> on 2015-02-19
Reviewed by Dan Bernstein.

UIProcess/Launcher/mac/EnvironmentVariables.cpp:

(WebKit::EnvironmentVariables::appendValue): If the existing value is an empty string, replace it rather than
append to it.

6:36 PM Changeset in webkit [180378] by dbates@webkit.org

2 edits in trunk/Tools

REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
https://bugs.webkit.org/show_bug.cgi?id=141815
<rdar://problem/19893933>

Reviewed by Simon Fraser.

Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
was booted by iOS Simulator in a previous run of run-webkit-test.

Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
(IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().

5:41 PM Changeset in webkit [180377] by dburkart@apple.com

3 edits
2 copies in branches/safari-600.5-branch

Merged r179877. <rdar://19850766>

5:36 PM Changeset in webkit [180376] by mmaxfield@apple.com

7 edits
4 adds in trunk/LayoutTests

Updating more tests after r177774
https://bugs.webkit.org/show_bug.cgi?id=141817

Reviewed by NOBODY (As per ap's request).

These tests aren't actually flakey, and simply need updated results.

Some of the SVG tests were actually flakey, but for a different reason.

platform/mac-mavericks/css3/selectors3/html/css3-modsel-161-expected.txt: Added.
platform/mac-mavericks/css3/selectors3/xhtml/css3-modsel-161-expected.txt: Added.
platform/mac-mavericks/css3/selectors3/xml/css3-modsel-161-expected.txt: Added.
platform/mac-mavericks/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added
platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/mac/TestExpectations:
platform/mac/fast/block/margin-collapse/103-expected.txt:
platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:

5:31 PM Changeset in webkit [180375] by dburkart@apple.com

3 edits
2 copies in branches/safari-600.5-branch

Merged r179776. <rdar://19850771>

5:25 PM Changeset in webkit [180374] by dburkart@apple.com

3 edits
3 copies in branches/safari-600.5-branch

Merged r178224. <rdar://19861714>

5:10 PM Changeset in webkit [180373] by Joseph Pecoraro

2 edits in trunk/Source/WebInspectorUI

Follow-up fix to r180371. formatParameterAsValue expects full object, not just a description.

Reviewed by Timothy Hatcher.

UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatParameter):

4:42 PM Changeset in webkit [180372] by commit-queue@webkit.org

3 edits in trunk/Source/bmalloc

Unreviewed, rolling out r180363.
https://bugs.webkit.org/show_bug.cgi?id=141814

Caused >50 crashes when running LayoutTests in GuardMalloc or
ASAN modes. (Requested by jernoble on #webkit).

Reverted changeset:

"bmalloc should implement malloc introspection (to stop false-
positive leaks when MallocStackLogging is off)"
https://bugs.webkit.org/show_bug.cgi?id=141802
http://trac.webkit.org/changeset/180363

4:37 PM Changeset in webkit [180371] by commit-queue@webkit.org

8 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Introduce FormattedValue helpers and use them in Console/ObjectTree
https://bugs.webkit.org/show_bug.cgi?id=141812

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-19
Reviewed by Timothy Hatcher.

There were a few different ways to get styled values. Try to consolidate them
all in FormattedValue. That is also a convenient place to have the styles.

UserInterface/Main.html:
UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._formatMessage):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsString):

(WebInspector.ConsoleMessageImpl.prototype._userProvidedColumnNames):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):
(WebInspector.ConsoleMessageImpl.prototype._populateStackTraceTreeElement):
(WebInspector.ConsoleMessageImpl.prototype._propertyPreviewElement): Deleted.
Fix console.table after renaming ObjectPreview.properties to ObjectPreview.propertyPreviews.
Also, use FormattedValue to create the value elements. Also, remove class
"source-code" as I do not see it actually being used in a meaningful way.

UserInterface/Views/FormattedValue.css: Added.

(.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap):
(.formatted-number):
(.formatted-string, .formatted-regexp):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):
(.formatted-null, .formatted-undefined):

UserInterface/Views/FormattedValue.js: Added.

(WebInspector.FormattedValue.classNameForTypes):
(WebInspector.FormattedValue.classNameForObject):
(WebInspector.FormattedValue.createLinkifiedElementString):
(WebInspector.FormattedValue.createElementForTypesAndValue):
(WebInspector.FormattedValue.createElementForRemoteObject):
(WebInspector.FormattedValue.createElementForObjectPreview):
(WebInspector.FormattedValue.createElementForPropertyPreview):
Styles and formatted value element creation.

UserInterface/Views/LogContentView.css:

(.expandable.source-code): Deleted.
Remove ".source-code". I do not see it actually being used in a meaningful way.

UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
(WebInspector.ObjectPreviewView.prototype._appendValuePreview):
(WebInspector.ObjectPreviewView.prototype._formattedObjectElementForPreview): Deleted.

UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateTitlePropertyStyle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._descriptionString): Deleted.

UserInterface/Views/ObjectTreeView.css:

(.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap): Deleted.
(.formatted-number): Deleted.
(.formatted-string, .formatted-regexp): Deleted.
(.formatted-string): Deleted.
(.formatted-regexp): Deleted.
(.formatted-symbol): Deleted.
(.formatted-null, .formatted-undefined): Deleted.

UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.classNameForObject): Deleted.
Extract styles and value formatting to FormattedValue helpers.

4:20 PM Changeset in webkit [180370] by dino@apple.com

9 edits
4 adds in trunk

ES6: Implement Array.from()
https://bugs.webkit.org/show_bug.cgi?id=141054
<rdar://problem/19654521>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Implement the Array.from() ES6 method
as defined in Section 22.1.2.1 of the specification.

Given that we can't rely on the built-in
global functions or objects to be untainted,
I had to expose a few of them directly to
the function via private names. In particular:

Math.floor -> @floor
Math.abs -> @abs
Number -> @Number
Array -> @Array
isFinite -> @isFinite

builtins/ArrayConstructor.js: Added.

(from): Implementation of Array.from in JavaScript.

runtime/ArrayConstructor.cpp: Add "from" to the lookup

table for the constructor object.

runtime/CommonIdentifiers.h: Add the private versions

of the identifiers listed above.

runtime/JSGlobalObject.cpp: Add the implementations of

those identifiers to the global object (using their
private names).
(JSC::JSGlobalObject::init):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalPrivateFuncAbs): Implementation of the abs function.
(JSC::globalPrivateFuncFloor): Implementation of the floor function.

runtime/JSGlobalObjectFunctions.h:

LayoutTests:

Test for Array.from(). The test has
one expected failure: using from() on a
Set object, which will be addressed in
a followup:
https://bugs.webkit.org/show_bug.cgi?id=141055

js/array-from-expected.txt: Added.
js/array-from.html: Added.
js/script-tests/array-from.js: Added.
js/Object-getOwnPropertyNames.html: Update results for the new value on the constructor.

4:13 PM Changeset in webkit [180369] by jer.noble@apple.com

8 edits
2 adds in branches/safari-600.1.4.15-branch/LayoutTests

Unreviewed gardening; rebaseline tests on safari-600.1.4.15-branch

css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:
platform/mac/css2.1/t1202-counter-04-b-expected.png:
platform/mac/css2.1/t1202-counter-04-b-expected.txt:
platform/mac/css2.1/t1202-counters-04-b-expected.png:
platform/mac/css2.1/t1202-counters-04-b-expected.txt:
platform/mac/fast/text/vertical-no-sideways-expected.png: Added.
platform/mac/fast/text/vertical-no-sideways-expected.txt: Added.

3:05 PM Changeset in webkit [180368] by mmaxfield@apple.com

3 edits in trunk/LayoutTests

Update fast/text/glyph-reordering.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141775

Reviewed by Dan Bernstein.

fast/text/glyph-reordering.html:
platform/mac/TestExpectations:

2:56 PM Changeset in webkit [180367] by ddkilzer@apple.com

5 edits in trunk/Source/WebCore

Rename SOFT_LINK_FUNCTION_{DECL,IMPL}() to SOFT_LINK_FUNCTION_{HEADER,SOURCE}()

Rubber-stamped by Brent Fulgham.

"HEADER" and "SOURCE" seem clearer than "DECL" and "IMPL", and
Brent agreed when I talked to him in person.

platform/cf/CoreMediaSoftLink.cpp:
platform/cf/CoreMediaSoftLink.h:
platform/mac/SoftLinking.h:
platform/win/SoftLinking.h:
Do the rename.

2:42 PM Changeset in webkit [180366] by ddkilzer@apple.com

19 edits
1 add in trunk/Source/WebCore

Move more CoreMedia soft-linked functions to CoreMediaSoftLink.{cpp,h}
<http://webkit.org/b/141791>

Reviewed by Alexey Proskuryakov.

Configurations/WebCore.unexp:
Remove five more symbols.

Modules/plugins/QuickTimePluginReplacement.mm:
Remove all local soft-links and include CoreMediaSoftLink.h. Note that SOFT_LINK_FRAMEWORK_OPTIONAL() should not have been used here since we didn't use the optional function soft-link method.

WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.vcxproj/WebCoreCFNetwork.props:
WebCore.xcodeproj/project.pbxproj:
Add CoreMediaSPI.h to the project.

platform/cf/CoreMediaSoftLink.cpp:
platform/cf/CoreMediaSoftLink.h:
Add three cross-platform symbols, five Cocoa-only symbols, and two Windows-only symbols (based on current usage, not availability on each platform).
Include CoreMediaSPI.h header.
Include <CoreMedia/CoreMedia.h> instead of just CMTime.h.

platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
Remove all CoreMedia soft-linked functions. Constants remain.

platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
Remove one CoreMedia soft-linked method.

platform/graphics/avfoundation/MediaTimeAVFoundation.cpp:
Remove all CoreMedia soft-linked funtions. With this change, we are already realizing space savings for duplicate SOFT_LINK_FRAMEWORK() calls. (On Windows, there was code generated for many unused functions included by CoreMediaSoftLinking.h.)

platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h:
Remove all CoreMedia soft-linked funtions. Constants remain.

platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
Remove duplicate header included by CoreMediaSoftLink.h.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
Remove all CoreMedia soft-linked funtions. Constants remain.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
Remove three CoreMedia soft-linked methods.

platform/mac/PlatformClockCM.mm:
Remove two CoreMedia soft-linked methods.

platform/mac/SerializedPlatformRepresentationMac.mm:
Remove only CoreMedia soft-linked funtion. It wasn't even used.

platform/mediastream/mac/AVVideoCaptureSource.mm:
Remove two CoreMedia soft-linked method.

platform/spi/cf/CoreMediaSPI.h:
Add for SPI from CMNotificationCenter.h.

2:18 PM Changeset in webkit [180365] by rniwa@webkit.org

7 edits in trunk/Websites/perf.webkit.org

Relationship between A/B testing results are unclear
https://bugs.webkit.org/show_bug.cgi?id=141810

Reviewed by Andreas Kling.

Show a "reference chart" indicating which two points have been tested in each test group pane.

Now the chart shown at the top of an analysis task page is called the "overview pane", and we use the pane
and the domain used in this chart to show charts in each test group.

Also renamed an array of revisions used in the A/B test results tables from 'revisions' to 'revisionList'.

public/v2/analysis.js:

(App.TestGroup._fetchTestResults): Renamed from _fetchChartData. Set 'testResults' instead of 'chartData'
since this is the results of A/B testing results, not the data for charts shown next to them.

public/v2/app.css: Added CSS rules for reference charts.

public/v2/app.js:

(App.AnalysisTaskController.paneDomain): Set 'overviewPane' and 'overviewDomain' on each test group pane.
(App.TestGroupPane._populate): Updated per 'chartData' to 'testResults' rename.
(App.TestGroupPane._updateReferenceChart): Get the chart data via the overview pane and find points that
identically matches root sets. If one of configuration used a set of revisions for which no measurement
was made in the original chart, don't show the reference chart as that would be misleading / confusing.
(App.TestGroupPane._computeRepositoryList): Updated per 'chartData' to 'testResults' rename.
(App.TestGroupPane._createConfigurationSummary): Ditto. Also renamed 'revisions' to 'revisionList'.
In addition, renamed 'buildNumber' to 'buildLabel' and prefixed it with "Build ".

public/v2/data.js:

(Measurement.prototype.revisionForRepository): Added.
(Measurement.prototype.commitTimeForRepository): Cleanup.
(TimeSeries.prototype.findPointByRevisions): Added. Finds a point based on a set of revisions.

public/v2/index.html: Added the reference chart. Streamlined the status label for each build request

by including the build number in the title attribute instead of in the markup.

public/v2/interactive-chart.js:

(App.InteractiveChartComponent._updateDomain): Fixed a typo introduced as a consequence of r179913.
(App.InteractiveChartComponent._computeYAxisDomain): Expand the y-axis to show the highlighted points.
(App.InteractiveChartComponent._highlightedItemsChanged): Adjust the y-axis as needed.

1:42 PM Changeset in webkit [180364] by hyatt@apple.com

8 edits
2 adds in trunk

Fix for unsplittable content being paginated by columns.

1:38 PM Changeset in webkit [180363] by ggaren@apple.com

3 edits in trunk/Source/bmalloc

bmalloc should implement malloc introspection (to stop false-positive leaks when MallocStackLogging is off)
https://bugs.webkit.org/show_bug.cgi?id=141802

Reviewed by Andreas Kling.

Fixed a last-minute type.

The macro is OS, not PLATFORM.

bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::grow):

bmalloc/VMHeap.h:
bmalloc/Zone.h:

1:25 PM Changeset in webkit [180362] by andersca@apple.com

13 edits in trunk/Source/WebKit2

Make C SPI objects and modern API objects toll-free bridged
https://bugs.webkit.org/show_bug.cgi?id=141808

Reviewed by Tim Horton.

Shared/API/APIObject.h:

(API::Object::wrap):
(API::Object::unwrap):
Add default implementations of wrap and unwrap. These just cast.

Shared/API/c/WKArray.cpp:

(WKArrayCreate):
(WKArrayCreateAdoptingValues):
(WKArrayGetItemAtIndex):

Shared/API/c/WKDictionary.cpp:

(WKDictionaryGetItemForKey):
Add toImpl and toAPI where necessary.

Shared/API/c/WKSharedAPICast.h:

Add API::Object::wrap in toAPI and unwrap in toImpl.

Shared/API/c/WKType.cpp:

(WKGetTypeID):
(WKRetain):
(WKRelease):
Add missing toImpl calls.

Shared/Cocoa/APIObject.mm:

(API::Object::wrap):
Return the APIObject Objective-C wrapper.

(API::Object::unwrap):
Return the API::Object from the Objective-C object.

Shared/Cocoa/WKObject.h:

Add wrap and unwrap declarations.

UIProcess/API/C/WKPage.cpp:
UIProcess/API/C/WKPageConfigurationRef.cpp:
UIProcess/API/C/WKPageGroup.cpp:
UIProcess/API/C/WKUserContentControllerRef.cpp:

Add missing includes; toImpl now requires a complete type.

1:09 PM Changeset in webkit [180361] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Remove unused forward declaration from WKWebViewInternal.h
https://bugs.webkit.org/show_bug.cgi?id=141806

Reviewed by Anders Carlsson.

UIProcess/API/Cocoa/WKWebViewInternal.h:

The use of WebCore::Highlight moved to WKContentView.

1:08 PM Changeset in webkit [180360] by benjamin@webkit.org

4 edits
2 adds in trunk/Source/JavaScriptCore

Refine the FTL part of ArithPow
https://bugs.webkit.org/show_bug.cgi?id=141792

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-19
Reviewed by Filip Pizlo.

This patch refines the FTL lowering of ArithPow. This was left out
of the original patch to keep it simpler.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileArithPow):
Two improvements here:
1) Do not generate the NaN check unless we know the exponent might be a NaN.
2) Use one BasicBlock per check with the appropriate weight. Now that we have

one branch per test, move the Infinity check before the check for 1 since
it is the less common case.

tests/stress/math-pow-becomes-custom-function.js: Added.

Test for changing the Math.pow() function after it has been optimized.

tests/stress/math-pow-nan-behaviors.js:

The previous tests were only going as far as the DFGAbstractInterpreter
were the operations were replaced by the equivalent constant.

I duplicated the test functions to also test the dynamic behavior of DFG
and FTL.

tests/stress/math-pow-with-constants.js:

Add cases covering exponent constants. LLVM removes many value
checks for those.

tests/stress/math-pow-with-never-NaN-exponent.js: Added.

Test for the new optimization removing the NaN check.

12:42 PM Changeset in webkit [180359] by ggaren@apple.com

5 edits
2 adds in trunk/Source/bmalloc

bmalloc should implement malloc introspection (to stop false-positive leaks when MallocStackLogging is off)
https://bugs.webkit.org/show_bug.cgi?id=141802

Reviewed by Andreas Kling.

This patch does the bare minimum to stop false positive leaks from
being reported by the Darwin leaks tool. We register each super chunk
as a single object, and then request that the leaks tool scan it.

bmalloc.xcodeproj/project.pbxproj: Added an abstraction for the malloc

zone introspection API.

bmalloc/Algorithm.h: Missing #include.

bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::grow):

bmalloc/VMHeap.h: Adopt the new abstraction.

bmalloc/Zone.cpp: Added.

(bmalloc::remoteRead): Helper for reading an object out of another process.
(bmalloc::Zone::enumerator):
(bmalloc::Zone::Zone): Register a malloc zone so that we will participate
in introspection.

bmalloc/Zone.h: Added.

(bmalloc::Zone::superChunks):
(bmalloc::Zone::addSuperChunk): Use a non-dynamically-allocated vector
since our dynamic allocations will not be scanned by leaks since they
will have the malloc VM tag.

12:36 PM Changeset in webkit [180358] by Joseph Pecoraro

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable DOM Tree Editing / Styles Editing of Shadow DOM Nodes
https://bugs.webkit.org/show_bug.cgi?id=141793

Unreviewed follow-up. Fix prototypes.

UserInterface/Views/ObjectPreviewView.js:
UserInterface/Views/ObjectTreeView.js:

12:28 PM Changeset in webkit [180357] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Use the real implementation type in our API cast traits
https://bugs.webkit.org/show_bug.cgi?id=141805

Reviewed by Sam Weinig.

Shared/API/c/WKSharedAPICast.h:

(WebKit::toURLRef):
(WebKit::toAPI): Deleted.
(WebKit::toImpl): Deleted.

UIProcess/GenericCallback.h:

12:25 PM Changeset in webkit [180356] by Joseph Pecoraro

13 edits
11 adds in trunk

Web Inspector: Create Separate Model and View Objects for RemoteObjects / ObjectPreview / PropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=141696

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

UserInterface/Main.html:

Add new files.

UserInterface/Models/CollectionEntry.js: Added.

(WebInspector.CollectionEntry):
(WebInspector.CollectionEntry.fromPayload):
(WebInspector.CollectionEntry.prototype.get key):
(WebInspector.CollectionEntry.prototype.get value):

UserInterface/Models/CollectionEntryPreview.js: Added.

(WebInspector.CollectionEntryPreview):
(WebInspector.CollectionEntryPreview.fromPayload):
(WebInspector.CollectionEntryPreview.prototype.get keyPreview):
(WebInspector.CollectionEntryPreview.prototype.get valuePreview):

UserInterface/Models/ObjectPreview.js: Added.

(WebInspector.ObjectPreview):
(WebInspector.ObjectPreview.fromPayload):
(WebInspector.ObjectPreview.prototype.get type):
(WebInspector.ObjectPreview.prototype.get subtype):
(WebInspector.ObjectPreview.prototype.get description):
(WebInspector.ObjectPreview.prototype.get lossless):
(WebInspector.ObjectPreview.prototype.get overflow):
(WebInspector.ObjectPreview.prototype.get properties):
(WebInspector.ObjectPreview.prototype.get entries):

UserInterface/Models/PropertyPreview.js: Added.

(WebInspector.PropertyPreview):
(WebInspector.PropertyPreview.fromPayload):
(WebInspector.PropertyPreview.prototype.get name):
(WebInspector.PropertyPreview.prototype.get type):
(WebInspector.PropertyPreview.prototype.get subtype):
(WebInspector.PropertyPreview.prototype.get value):
(WebInspector.PropertyPreview.prototype.get valuePreview):

UserInterface/Models/PropertyDescriptor.js: Added.

(WebInspector.PropertyDescriptor.fromPayload):
(WebInspector.PropertyDescriptor.prototype.get name):
(WebInspector.PropertyDescriptor.prototype.get value):
(WebInspector.PropertyDescriptor.prototype.get writable):
(WebInspector.PropertyDescriptor.prototype.get configurable):
(WebInspector.PropertyDescriptor.prototype.get enumerable):
(WebInspector.PropertyDescriptor.prototype.get isOwnProperty):
(WebInspector.PropertyDescriptor.prototype.get wasThrown):
(WebInspector.PropertyDescriptor.prototype.get isInternalProperty):
(WebInspector.PropertyDescriptor.prototype.hasValue):
(WebInspector.PropertyDescriptor.prototype.hasGetter):
(WebInspector.PropertyDescriptor.prototype.hasSetter):
New Model objects for different Protocol types.
The only customizations right now are compatibility modifications
and PropertyDescriptor's "hasValue", "hasGetter", and "hasSetter"
functions to return reliable checks based on the descriptors contents.

UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromPayload):
(WebInspector.RemoteObject.resolveNode):
(WebInspector.RemoteObject.prototype.get value):
(WebInspector.RemoteObject.prototype._isSymbol):
(WebInspector.RemoteObject.prototype.isCollectionType):
(WebInspector.RemoteObject.prototype.isWeakCollection):
(WebInspector.RemoteObject.prototype.getCollectionEntries):
(WebInspector.RemoteObject.prototype.arrayLength):
Clean up the existing code to enforce more checks and use our
style of member variables and public accessors.

(WebInspector.RemoteObject.prototype.getOwnPropertyDescriptors):
(WebInspector.RemoteObject.prototype.getOwnAndGetterPropertyDescriptors):
(WebInspector.RemoteObject.prototype.getAllPropertyDescriptors):
(WebInspector.RemoteObject.prototype.callback):
Provide a new way of getting properties that returns Model objects
instead of raw protocol types.

UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._format):
(WebInspector.ConsoleMessageImpl.prototype._formatParameter):
(WebInspector.ConsoleMessageImpl.prototype._propertyPreviewElement):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsTable):
(WebInspector.ConsoleMessageImpl.prototype._formatAsArrayEntry):
Always include a preview when possible. Now, when forced to be an object,
force expansion even if the preview is lossless.

(WebInspector.ConsoleMessageImpl.prototype._formatParameterAsObject):
Use an ObjectTreeView instead of ObjectPropertiesSection.

(WebInspector.ConsoleMessageImpl.prototype._appendPreview): Deleted.
(WebInspector.ConsoleMessageImpl.prototype._appendEntryPreviews): Deleted.
(WebInspector.ConsoleMessageImpl.prototype._appendPropertyPreviews): Deleted.
(WebInspector.ConsoleMessageImpl.prototype._appendValuePreview): Deleted.
This code is moved into ObjectPreviewView.

UserInterface/Views/ObjectPropertiesSection.js:

(WebInspector.CollectionEntriesMainTreeElement.prototype.onexpand.callback):
(WebInspector.CollectionEntriesMainTreeElement.prototype.onexpand):
These types are now converted to Model types in Model objects, so do not do it here.

UserInterface/Views/ObjectPreviewView.css: Added.

(.object-preview):
(.object-preview.lossless):
(.object-preview .name):

UserInterface/Views/ObjectPreviewView.js: Added.

(WebInspector.ObjectPreviewView):
(WebInspector.ObjectPreviewView.prototype.get preview):
(WebInspector.ObjectPreviewView.prototype.get element):
(WebInspector.ObjectPreviewView.prototype.get mode):
(WebInspector.ObjectPreviewView.prototype.get lossless):
(WebInspector.ObjectPreviewView.prototype._numberOfPropertiesToShowInMode):
(WebInspector.ObjectPreviewView.prototype._appendPreview):
(WebInspector.ObjectPreviewView.prototype._appendEntryPreviews):
(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
(WebInspector.ObjectPreviewView.prototype._appendValuePreview):
(WebInspector.ObjectPreviewView.prototype._formattedObjectElementForPreview):
An ObjectPreviewView can create a full/brief view given a ObjectPreview.
The view will contain formatted values everywhere possible.

UserInterface/Views/ObjectTreePropertyTreeElement.js: Added.

(WebInspector.ObjectTreePropertyTreeElement):
(WebInspector.ObjectTreePropertyTreeElement.prototype.get property):
(WebInspector.ObjectTreePropertyTreeElement.prototype.onpopulate):
(WebInspector.ObjectTreePropertyTreeElement.prototype.onattach):
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateTitle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateTitlePropertyStyle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._updateTitleAPIStyle):
(WebInspector.ObjectTreePropertyTreeElement.prototype._descriptionString):
(WebInspector.ObjectTreePropertyTreeElement.prototype._functionParameterString):
(WebInspector.ObjectTreePropertyTreeElement.prototype.mode):
(WebInspector.ObjectTreePropertyTreeElement.prototype):

UserInterface/Views/ObjectTreeView.js: Added.

(WebInspector.ObjectTreeView):
(WebInspector.ObjectTreeView.classNameForObject):
(WebInspector.ObjectTreeView.ComparePropertyDescriptors):
(WebInspector.ObjectTreeView.prototype.get object):
(WebInspector.ObjectTreeView.prototype.get element):
(WebInspector.ObjectTreeView.prototype.get expanded):
(WebInspector.ObjectTreeView.prototype.expand):
(WebInspector.ObjectTreeView.prototype.collapse):
(WebInspector.ObjectTreeView.prototype.update):
(WebInspector.ObjectTreeView.prototype._updateProperties):
(WebInspector.ObjectTreeView.prototype._handlePreviewOrTitleElementClick):
Re-implementation of ObjectPropertiesSection for our Model objects
without "Section" semantics / dependencies. An ObjectTree will creates
an expandable tree for a RemoteObject. The top level clickable item
will be an ObjectPreview if possible, otherwise just a title element.

UserInterface/Views/ObjectTreeView.css: Added.

(.object-tree):
(.object-tree > .title):
(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree.expanded > :matches(.title, .object-preview)::before):
(.object-tree.lossless-preview > :matches(.title, .object-preview)::before):
(.object-tree-outline):
(.object-tree.expanded > .object-tree-outline):
(.object-tree-outline li):
(.object-tree-outline li.parent):
(.object-tree-outline li.parent::before):
(.object-tree-outline li.parent.expanded::before):
(.object-tree-outline ol):
(.object-tree-outline ol.expanded):
(.object-tree-outline li .empty-message):
(.object-tree-property .name):
(.object-tree-property .name.not-enumerable):
(.object-tree-property .value.error):
(.formatted-object, .formatted-node, .formatted-error, .formatted-map, .formatted-set, .formatted-weakmap):
(.formatted-number):
(.formatted-string, .formatted-regexp):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):
(.formatted-null, .formatted-undefined):
(.console-group-messages .object-tree:not(.lossless-preview)):
(.console-group-messages .object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):
(.console-group-messages .object-tree:not(.lossless-preview) > :matches(.title, .object-preview)::before):
(.console-group-messages :matches(.console-formatted-object, .console-formatted-node, .console-formatted-error, .console-formatted-map, .console-formatted-set, .console-formatted-weakmap) .object-tree):
(.console-group-messages :matches(.console-formatted-object, .console-formatted-node, .console-formatted-error, .console-formatted-map, .console-formatted-set, .console-formatted-weakmap) .object-tree-outline):
All styles for ObjectTree / ObjectPreview. Independent from
other styles in the inspector. Most of this is a copy of
the styles applied to ObjectPropertiesSection, renamed.

UserInterface/Views/ObjectTreeCollectionTreeElement.js: Added.

(WebInspector.ObjectTreeCollectionTreeElement):
(WebInspector.ObjectTreeCollectionTreeElement.propertyDescriptorForEntry):
(WebInspector.ObjectTreeCollectionTreeElement.prototype.get remoteObject):
(WebInspector.ObjectTreeCollectionTreeElement.prototype.onexpand.callback):
(WebInspector.ObjectTreeCollectionTreeElement.prototype.onexpand):
(WebInspector.ObjectTreeCollectionTreeElement.prototype.oncollapse):
(WebInspector.ObjectTreeCollectionTreeElement.prototype.ondetach):
(WebInspector.ObjectTreeCollectionTreeElement.prototype._trackWeakEntries):
(WebInspector.ObjectTreeCollectionTreeElement.prototype._untrackWeakEntries):
(WebInspector.ObjectTreeCollectionEntryTreeElement):
(WebInspector.ObjectTreeCollectionEntryTreeElement.prototype.onpopulate):
(WebInspector.ObjectTreeCollectionEntryTreeElement.prototype.onattach):
(WebInspector.ObjectTreeEmptyCollectionTreeElement):
Essentially a copy of ObjectPropertiesSection Collection handling using
the ObjectTree class names.

UserInterface/Views/TreeOutlineDataGridSynchronizer.js:

Fix prototype typo.

LayoutTests:

inspector/model/remote-object-expected.txt:
inspector/model/remote-object-get-properties-expected.txt:
inspector/model/remote-object-get-properties.html:
inspector/model/remote-object-weak-collection-expected.txt:
inspector/model/remote-object-weak-collection.html:

Update tests and results to use our Model objects and not
raw protocol types.

12:06 PM Changeset in webkit [180355] by ddkilzer@apple.com

3 edits in trunk/Tools

check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
<http://webkit.org/b/141799>

Reviewed by Alex Christensen.

Scripts/webkitpy/style/checkers/cpp.py:

(_IncludeState.check_next_include_order): Don't emit a warning
if the primary header exists and the source file name ends with
"SoftLink.cpp". Add 'filename' argument to method.
(check_include_line): Pass in 'filename'.

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_next_include_orderno_config):
(OrderOfIncludesTest.test_check_next_include_orderno_self):
(OrderOfIncludesTest.test_check_next_include_orderlikely_then_config):
(OrderOfIncludesTest.test_check_next_include_orderother_then_config):
(OrderOfIncludesTest.test_check_next_include_orderconfig_then_other_then_likely):

Add test filename arguments for calls to check_next_include_order().

(OrderOfIncludesTest.test_primary_header): Add test for a file
name ending in "SoftLink.cpp".

11:48 AM Changeset in webkit [180354] by andersca@apple.com

7 edits in trunk/Source/WebKit2

Remove the stray storage manager from WebProcessPool
https://bugs.webkit.org/show_bug.cgi?id=141800

Reviewed by Sam Weinig.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView initWithFrame:processPool:configuration:webView:]):
(-[WKView _applicationWillTerminate:]): Deleted.
Remove code that calls applicationWillTerminate on the WebPageProxy.

UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManager::getStorageDetailsByOrigin):
(WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManager::deleteAllEntries):
Get the storage manager from the website data store.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
Remove storage manager calls.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::applicationWillTerminate): Deleted.

UIProcess/WebProcessPool.h:

Remove storage manager code.

UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::storageManager):
Add getter.

11:43 AM Changeset in webkit [180353] by Chris Dumez

2 edits in trunk/Source/WebCore

[iOS] Fix inefficiencies in ResourceResponse::platformLazyInit()
https://bugs.webkit.org/show_bug.cgi?id=141744

Reviewed by Alexey Proskuryakov.

Fix inefficiencies in iOS's ResourceResponse::platformLazyInit()
implementation, similarly to what was already done for Mac in:
<http://trac.webkit.org/changeset/174717>

The following changes were made:

Add missing "initLevel == AllFields" check before initializing uncommon fields. This bug was causing us to initialize uncommon fields even if called with 'CommonFieldsOnly' initLevel.
Bypass the first pass populating common HTTP headers in m_httpHeaderFields if the initLevel is AllFields. If called with AllFields initLevel, we will end up populating all HTTP headers later on so this first pass is redundant.
Use C++11 range loop to iterator over commonHeaderFields array for readability.
Use CFDictionaryApplyFunction() to populate m_httpHeaderFields for the CFDictionaryRef containing the headers instead of creating copies of keys and values using CFDictionaryGetKeysAndValues() and then iterating over those. This avoids allocating Vectors for keys / values and avoids unnecessary copying.

11:34 AM Changeset in webkit [180352] by bshafiei@apple.com

3 edits
3 copies in branches/safari-600.4.10-branch

Merged r178224. rdar://problem/19890075

11:32 AM Changeset in webkit [180351] by bshafiei@apple.com

3 edits in branches/safari-600.4.10-branch

Merged r175641. rdar://problem/19889872

11:07 AM Changeset in webkit [180350] by Csaba Osztrogonác

2 edits
2 adds in trunk/Source/WebKit2

[WK2] Unreviewed buildfix for non-Cocoa platforms.

CMakeLists.txt:
UIProcess/WebsiteData/unix/WebsiteDataStoreUnix.cpp: Added.

(WebKit::WebsiteDataStore::platformInitialize): Added.
(WebKit::WebsiteDataStore::platformDestroy): Added.

10:45 AM Changeset in webkit [180349] by andersca@apple.com

4 edits
2 adds in trunk/Source/WebKit2

WebsiteDataStore should ensure that local storage is written before exiting
https://bugs.webkit.org/show_bug.cgi?id=141798

Reviewed by Sam Weinig.

UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: Added.

(WebKit::dataStoresWithStorageManagers):
(WebKit::WebsiteDataStore::platformInitialize):
(WebKit::WebsiteDataStore::platformDestroy):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):

UIProcess/WebsiteData/WebsiteDataStore.h:
WebKit2.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [180348] by enrica@apple.com

1 edit
15 adds in trunk/Tools

Add new tool to test editable Webviews.
https://bugs.webkit.org/show_bug.cgi?id=141772

Reviewed by Tim Horton.

Adding WebEditingTester, a Cocoa application to
test WK1 and Wk2 views in editable mode.

WebEditingTester: Added.
WebEditingTester/AppDelegate.h: Added.
WebEditingTester/AppDelegate.m: Added.

(-[WebEditingAppDelegate init]):
(defaultConfiguration):
(-[WebEditingAppDelegate applicationDidFinishLaunching:]):
(-[WebEditingAppDelegate applicationWillTerminate:]):
(-[WebEditingAppDelegate newEditor:]):
(-[WebEditingAppDelegate showOperations:]):
(-[WebEditingAppDelegate useWebKit2ByDefault]):
(-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
(-[WebEditingAppDelegate validateMenuItem:]):

WebEditingTester/Info.plist: Added.
WebEditingTester/MainMenu.xib: Added.
WebEditingTester/WK1WebDocumentController.h: Added.
WebEditingTester/WK1WebDocumentController.m: Added.

(-[WK1WebDocumentController awakeFromNib]):
(-[WK1WebDocumentController loadContent]):
(-[WK1WebDocumentController dealloc]):
(-[WK1WebDocumentController pasteAsMarkup:]):

WebEditingTester/WK2WebDocumentController.h: Added.
WebEditingTester/WK2WebDocumentController.m: Added.

(-[WK2WebDocumentController initWithConfiguration:]):
(-[WK2WebDocumentController pasteAsMarkup:]):
(-[WK2WebDocumentController awakeFromNib]):
(-[WK2WebDocumentController dealloc]):
(-[WK2WebDocumentController loadContent]):

WebEditingTester/WebDocument.xib: Added.
WebEditingTester/WebDocumentController.h: Added.
WebEditingTester/WebDocumentController.m: Added.

(-[WebDocumentController initWithWindow:]):
(-[WebDocumentController windowDidLoad]):
(-[WebDocumentController defaultEditingSource]):
(-[WebDocumentController applicationTerminating]):
(-[WebDocumentController loadContent]):

WebEditingTester/WebEditingTester.xcodeproj: Added.
WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
WebEditingTester/main.m: Added.

(main):

10:36 AM Changeset in webkit [180347] by dino@apple.com

3 edits in trunk/Source/WebCore

Sufficiently small media controls should remove toolbar elements
https://bugs.webkit.org/show_bug.cgi?id=141780
<rdar://problem/16548548>
<rdar://problem/17598778>
<rdar://problem/18351963>

Reviewed by Eric Carlson.

Implement some logic where elements on the media controls are
hidden when there isn't enough room. We start by dropping
the scrubber, then the various buttons on the right hand
side.

This solution isn't perfect. If we had perfection, it would
be because we get resize events and respond accordingly. Instead
we check the size when the user has pinch-zoomed, or when
we start/stop playing.

This is going to cause some extra layout, because we need
to know the size of things before we can work out which
bits to hide.

Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls): Remove the minimum width. This can
cause the controls to get clipped.
(audio::-webkit-media-controls-spacer): Add this empty element to
replace the scrubber when it is hidden.
(audio::-webkit-media-controls-timeline-container):

Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS): Remember our size so we don't churn.
(ControllerIOS.prototype.createControls): Create a new spacer element.
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.showControls): Check if we need to hide stuff.
(ControllerIOS.prototype.updateControls):
(ControllerIOS.prototype.setPlaying): Ditto.
(ControllerIOS.prototype.set pageScaleFactor): Ditto.
(ControllerIOS.prototype.scheduleUpdateLayoutForDisplayedWidth): Trigger an update
asap. In this case it's probably ok to be in a bad state for a frame, or
we are inside setup and we know that we'll layout soon.
(ControllerIOS.prototype.updateLayoutForDisplayedWidth): The actual code
that hides elements.

8:47 AM Changeset in webkit [180346] by Brent Fulgham

2 edits in trunk/LayoutTests

[Win] Disable media tests due to bot failures.

platform/win/TestExpectations:

7:46 AM Changeset in webkit [180345] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r180279): It broke 20 tests on ARM Linux
https://bugs.webkit.org/show_bug.cgi?id=141771

Reviewed by Filip Pizlo.

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation): Align 64-bit values to respect ARM EABI.

7:39 AM Changeset in webkit [180344] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: DOMTree / Node Details Sidebar do not update as <input> content changes
https://bugs.webkit.org/show_bug.cgi?id=141790

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-19
Reviewed by Timothy Hatcher.

UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._characterDataModified):
Update Node "Value" details if character data changes.

UserInterface/Views/DOMTreeUpdater.js:

(WebInspector.DOMTreeUpdater.prototype._updateModifiedNodes):
Update the title of the parent. If the parent had a single text node child
and now doesn't, it will need to update its display.

7:36 AM Changeset in webkit [180343] by commit-queue@webkit.org

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Disable DOM Tree Editing / Styles Editing of Shadow DOM Nodes
https://bugs.webkit.org/show_bug.cgi?id=141793

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-19
Reviewed by Timothy Hatcher.

Currently the backend disallows editing of Shadow DOM nodes,
so the frontend should not provide options that do not work.
Long term we should allow editing Shadow DOM nodes.

UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration.prototype.get editable):
Inline styles on a Shadow DOM node are not editable.

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.ondelete):
(WebInspector.DOMTreeElement.prototype._startEditingTarget):
(WebInspector.DOMTreeElement.prototype._populateTagContextMenu):
(WebInspector.DOMTreeElement.prototype._populateTextContextMenu):
(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
(WebInspector.DOMTreeElement.prototype._startEditing):
Disable context menus and keyboard shortcuts on Shadow DOM nodes.
Only Context Menu item we keep is "Copy as HTML".

UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._contextMenuEventFired):
(WebInspector.DOMTreeOutline.prototype.populateContextMenu):
Eliminate double look-up.

UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.addNewRuleButton):
Do not add the New Rule Button to the Styles Sidebar of Shadow DOM Nodes.
Instead this will just be an empty divider.

12:40 AM Changeset in webkit [180342] by timothy_horton@apple.com

7 edits in trunk/Source/WebCore

Move the software-only ImageBuffer::m_context to ImageBufferData
https://bugs.webkit.org/show_bug.cgi?id=141784

Reviewed by Simon Fraser.

platform/graphics/ImageBuffer.h:
platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):

platform/graphics/cairo/ImageBufferDataCairo.h:
platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):

platform/graphics/cg/ImageBufferDataCG.h:

Move m_context to ImageBufferData in the software-only section;
for accelerated contexts, the GraphicsContext is owned by the IOSurface wrapper.
This will make it harder for ImageBuffer to make the mistake of using
m_context blindly without thinking when it will often be null.

12:36 AM Changeset in webkit [180341] by bshafiei@apple.com

5 edits in branches/safari-600.4.10-branch/Source

Versioning.

12:34 AM Changeset in webkit [180340] by bshafiei@apple.com

1 copy in tags/Safari-600.4.10.2

New tag.

Feb 18, 2015:

11:37 PM Changeset in webkit [180339] by Chris Dumez

3 edits in trunk/LayoutTests

Clean up / modernize test introduced in r180337.
https://bugs.webkit.org/show_bug.cgi?id=141788

Reviewed by Andreas Kling.

fast/history/page-cache-clearing-expected.txt:
fast/history/page-cache-clearing.html:

10:17 PM Changeset in webkit [180338] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed Windows build fix after r180337.

Export a couple of symbols.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

10:07 PM Changeset in webkit [180337] by akling@apple.com

6 edits
2 adds in trunk

REGRESSION(r179347): Clearing the PageCache no longer clears the PageCache.
<https://webkit.org/b/141788>

Reviewed by Anders Carlsson.

Source/WebCore:

Once again we've fallen into the TemporaryChange trap:

TemporaryChange<unsigned>(m_member, temporaryValue);

The code above doesn't actually do anything. Since the TemporaryChange local is not named,
it immediately goes out of scope and restores the original value of m_member.

Unless someone knows a C++ trick to prevent these, we'll need to add a style checker pass
to catch bugs like this. Whatever we do will be done separately from this bug.

Test: fast/history/page-cache-clearing.html

history/PageCache.cpp:

(WebCore::PageCache::pruneToSizeNow): Name the local so it lives longer.

testing/Internals.cpp:

(WebCore::Internals::clearPageCache):
(WebCore::Internals::pageCacheSize):

testing/Internals.h:
testing/Internals.idl: Add a way to clear the page cache and query its size from

window.internals to facilitate writing a simple test for this bug.

LayoutTests:

Add a simple test that navigates to a temporary page which immediately does a history.back
navigation. Upon returning to the first page, check that the page cache now has 1 entry,
and that clearing the page cache makes that entry go away.

fast/history/page-cache-clearing-expected.txt: Added.
fast/history/page-cache-clearing.html: Added.

9:23 PM Changeset in webkit [180336] by ap@apple.com

2 edits in trunk/Source/WebCore

Roll out r180280.

Crashes under IDBDatabase::closeConnection.
https://bugs.webkit.org/show_bug.cgi?id=141745
rdar://problem/19816412

Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::closeConnection):

8:24 PM Changeset in webkit [180335] by ap@apple.com

2 edits in trunk/LayoutTests

Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141685

Updating Yosemite results to match bots.

platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:

7:58 PM Changeset in webkit [180334] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Missing Divider line between console.log and console evaluation
https://bugs.webkit.org/show_bug.cgi?id=141770

Patch by Nikita Vasilyev <Nikita Vasilyev> on 2015-02-18
Reviewed by Timothy Hatcher.

UserInterface/Views/LogContentView.css:

(.console-item):
(.console-message): Deleted.

6:41 PM Changeset in webkit [180333] by rniwa@webkit.org

13 edits in trunk/Websites/perf.webkit.org

Analysis task pages are unusable
https://bugs.webkit.org/show_bug.cgi?id=141786

Reviewed by Andreas Kling.

This patch makes following improvements to analysis task pages:

Making the main chart interactive. This change required the use of App.Pane as well as moving the code to

compute the data for the details pane from PaneController.

Moving the form to add a new test group to the top of test groups instead of the bottom of them.
Grouping the build requests in each test group by root sets instead of the order by which they were ran.

This change required the creation of App.TestGroupPane as well as its methods.

Show a box plot for each root set configuration as well as each build request. This change required

App.BoxPlotComponent.

Show revisions of each repository (e.g. WebKit) for each root set and build request.

public/api/build-requests.php:

(main): Update per the rename of BuildRequestsFetcher::root_sets to BuildRequestsFetcher::root_sets_by_id.

public/api/test-groups.php:

(main): Include root sets and roots in the response.
(format_test_group):

public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::root_sets_by_id): Renamed from root_sets.
(BuildRequestsFetcher::root_sets): Added.
(BuildRequestsFetcher::roots): Added.
(BuildRequestsFetcher::fetch_roots_for_set): Takes a boolean argument $resolve_ids. This flag is only set to
true in /api/build-requests/ (as done prior to this patch) to use repository names as identifiers since
tools/sync-with-buildbot.py can't convert repository names to their ids.

public/v2/analysis.js:

(App.Root): Added.
(App.RootSet): Added.
(App.RootSet.revisionForRepository): Added.
(App.TestGroup.rootSets): Deleted the code to compute root set ids from build requests now that the JSON
response at /api/test-groups will include them.
(App.BuildRequest): Ditto. Also deleted 'configLetter' property, which has been moved to a proxy created by
_createConfigurationSummary.
(App.BuildRequest.statusLabel): Use 'Completed' as the human readable label for 'completed' status.
(App.BuildRequest.aggregateStatuses): Added. Generates a human readable status for a set of build requests.

public/v2/app.css: Updated style rules for analysis task pages.

public/v2/app.js:

(App.Pane): This class is now used in analysis task pages to make the main chart interactive.
(App.Pane._updateDetails): Moved from App.PaneController.

(App.PaneController._updateCanAnalyze): Updated the code per the move of selectedPoints.

(App.AnalysisTaskController): Added 'details'.
(App.AnalysisTaskController._taskUpdated):
(App.AnalysisTaskController.paneDomain):Renamed from _fetchedRuns.
(App.AnalysisTaskController.updateTestGroupPanes): Added. Creates App.TestGroupPane for each test group.
(App.AnalysisTaskController.actions.toggleShowRequestList): Added.

(App.TestGroupPane): Added.
(App.TestGroupPane._populate): Added. Group build requests by root sets and create a summary for each group.
(App.TestGroupPane._computeRepositoryList): Added. Returns a sorted list of repositories which is the union
of all repositories appearing in root sets and builds associated with A/B testing results.
(App.TestGroupPane._groupRequestsByConfigurations): Added. Groups build requests by root sets.
(App.TestGroupPane._createConfigurationSummary): Added. Creates a summary for a group of build requests that
use the same root set. We start by wrapping "raw" build requests in a proxy with formatted values,
build numbers, etc... obtained from the fetched chart data. The list of revisions shown in the group summary
is a union of revisions in the root set and the first build request in the group. We null-out revision info
for a build request if it is identical to the one in the summary. The range of values is expanded as needed
by the values in the group as well as 95% percentile confidence interval.

(App.BoxPlotComponent): Added. Controls a box plot shown for each test group summary and build request.
(App.BoxPlotComponent.didInsertElement): Added. Inserts a SVG element as well as two indicator rects to show
the mean and the confidence interval.
(App.BoxPlotComponent._updateBars): Added. Updates the dimensions of the indicator rects.
(App.BoxPlotComponent.valueChanged): Added. Computes the relative dimensions of the indicator rects and
calls _updateBars to update the rects.

public/v2/chart-pane.css: Added some style rules to be used in the details pane in analysis task pages.

public/v2/data.js:

(Measurement.prototype.formattedRevisions):
(Measurement.formatRevisionRange): Renamed from Measurement.prototype._formatRevisionRange so that it can be
called in _createConfigurationSummary.

public/v2/index.html: Updated the templates for analysis task pages. Moved the form to create a new test

group above all test groups, and replaced the list of data points by "details" pane used in the charts page.
Also made the fetching of chartData no longer block showing of test groups.

public/v2/interactive-chart.js:

(App.InteractiveChartComponent._updateDomain): Added an early exit to fix a newly revealed race condition.
(App.InteractiveChartComponent._domainChanged): Ditto.
(App.InteractiveChartComponent._updateSelectionToolbar): Made it respect 'zoomable' boolean property.

public/v2/js/statistics.js:

(Statistics.min): Added.
(Statistics.max): Added.

public/v2/manifest.js:

(App.Manifest.fetchRunsWithPlatformAndMetric): Added formatWithDeltaAndUnit to be used in _createConfigurationSummary.

5:12 PM Changeset in webkit [180332] by benjamin@webkit.org

3 edits in trunk/Source/JavaScriptCore

Remove BytecodeGenerator's numberMap, it is dead code
https://bugs.webkit.org/show_bug.cgi?id=141779

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-02-18
Reviewed by Filip Pizlo.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitLoad): Deleted.

bytecompiler/BytecodeGenerator.h:

The JSValueMap seems better in every way.

The emitLoad() taking a double was the only way to use numberMap
and that code has no caller.

4:39 PM Changeset in webkit [180331] by Chris Dumez

2 edits in trunk/Source/WebKit2

[WK2][iOS] Fix NetworkCache build
https://bugs.webkit.org/show_bug.cgi?id=141778

Reviewed by Antti Koivisto.

Add missing header include to use round_page() on iOS.

NetworkProcess/cache/NetworkCacheStorageCocoa.mm:

4:37 PM Changeset in webkit [180330] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Fix the iOS Simulator build after r180308.

platform/graphics/cg/ImageBufferDataCG.h:

4:37 PM Changeset in webkit [180329] by Lucas Forschler

3 edits in branches/safari-600.4.10-branch/Source/WebCore

Merge patch for rdar://problem/19585765.

4:30 PM Changeset in webkit [180328] by Alan Bujtas

4 edits
2 adds in trunk

REGRESSION(r174761) Dangling spanner pointer in RenderMultiColumnSpannerPlaceholder.
https://bugs.webkit.org/show_bug.cgi?id=138224

Reviewed by Dave Hyatt.

It's wrong to call flowThreadRelativeWillBeRemoved(child).
RenderMultiColumnFlowThread::removeFlowChildInfo() does not mean that the child is actually about to be removed.
Should this introduce any regressions, we need to deal with those separately.

Source/WebCore:

Test: fast/multicol/crash-when-spanner-gets-moved-around.html

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::removeFlowChildInfo): Deleted.

rendering/RenderMultiColumnFlowThread.h:

LayoutTests:

fast/multicol/crash-when-spanner-gets-moved-around-expected.txt: Added.
fast/multicol/crash-when-spanner-gets-moved-around.html: Added.

4:27 PM Changeset in webkit [180327] by mmaxfield@apple.com

2 edits in trunk/LayoutTests

Many flakey tests for webkit.org/b/139968 do not appear to be flakey
https://bugs.webkit.org/show_bug.cgi?id=141762

Reviewed by Jer Noble.

Removing them from TestExpectations.

platform/mac/TestExpectations:

4:27 PM Changeset in webkit [180326] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/WebCore

Merged r180147. rdar://problem/19850650

4:23 PM Changeset in webkit [180325] by Lucas Forschler

4 edits in branches/safari-600.4.10-branch/Source/JavaScriptCore

Merge patch from rdar://problem/19828518

4:20 PM Changeset in webkit [180324] by Brent Fulgham

2 edits in trunk/Source/WebCore

[Win] CFData leak in CDMSessionAVFoundationCF
https://bugs.webkit.org/show_bug.cgi?id=141765
<rdar://problem/141765>

Reviewed by Joseph Pecoraro.

platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::generateKeyRequest): use 'adoptCF'
so we don't double-increment the retain count.

4:06 PM Changeset in webkit [180323] by Lucas Forschler

5 edits
2 copies in branches/safari-600.4.10-branch

Merged r179963. rdar://problem/19771718

4:02 PM Changeset in webkit [180322] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/WebCore

Merged r179969. rdar://problem/19738568

3:59 PM Changeset in webkit [180321] by mmaxfield@apple.com

3 edits
1 copy in trunk/LayoutTests

Update expected result of fast/forms/text-control-intrinsic-widths.html after r177774
https://bugs.webkit.org/show_bug.cgi?id=141685

Reviewed by Alexey Proskuryakov.

Text metrics have changed.

platform/mac/TestExpectations:
platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
platform/mac-mavericks/fast/forms/text-control-intrinsic-widths-expected.txt:

3:59 PM Changeset in webkit [180320] by Lucas Forschler

3 edits
2 copies in branches/safari-600.4.10-branch

Merged r179968. rdar://problem/19738568

3:55 PM Changeset in webkit [180319] by jonowells@apple.com

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Inspecting a page where resources are in folders forces folder organization on every subsequent page
https://bugs.webkit.org/show_bug.cgi?id=141397

Reviewed by Timothy Hatcher.

When removeChildren is called on an instance of a FolderizedTreeElement, the element's _groupedIntoFolders flag
will now be set to false. This will prevent unnecessary folderization upon a frame navigation. Also during an
onpopulate event, addChildForRepresentedObject is called repeatedly and much of the work done during each call
was unnecessary. That work has now been partially removed and partially relocated to a function that is only
called at the beginning of an onpopulate event.

UserInterface/Views/FolderizedTreeElement.js:

(WebInspector.FolderizedTreeElement.prototype.set removeChildren): Set _groupedIntoFolders to false.
(WebInspector.FolderizedTreeElement.prototype.addChildForRepresentedObject): Remove unnecessary treeOutline
emptiness check, and move _shouldGroupIntoFolders() check to new function prepareToPopulate().
(WebInspector.FolderizedTreeElement.prototype.prepareToPopulate): Create.
(WebInspector.FolderizedTreeElement.prototype._populateFromNewChildQueue): Call prepareToPopulate().

UserInterface/Views/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype.onpopulate): Call prepareToPopulate().

UserInterface/Views/GeneralTreeElement.js: Drive-by inheritance style fix.
UserInterface/Views/ResourceTreeElement.js: Drive-by inheritance style fix.

3:54 PM Changeset in webkit [180318] by Lucas Forschler

6 edits
2 copies in branches/safari-600.4.10-branch

Merged r179959. rdar://problem/19738563

3:52 PM Changeset in webkit [180317] by msaboff@apple.com

4 edits in trunk/Source/JavaScriptCore

Rollout r180247 & r180249 from trunk
https://bugs.webkit.org/show_bug.cgi?id=141773

Reviewed by Filip Pizlo.

Theses changes makes sense to fix the crash reported in https://bugs.webkit.org/show_bug.cgi?id=141730
only for branches. The change to fail the FTL compile but continue running is not comprehensive
enough for general use on trunk.

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileDoubleRep):
(JSC::FTL::LowerDFGToLLVM::compileValueRep):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
(JSC::FTL::LowerDFGToLLVM::compilePutLocal):
(JSC::FTL::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileToString):
(JSC::FTL::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::compare):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isArrayType):
(JSC::FTL::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::lowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::loweringFailed): Deleted.

ftl/FTLLowerDFGToLLVM.h:

3:50 PM Changeset in webkit [180316] by Lucas Forschler

4 edits
2 copies in branches/safari-600.4.10-branch

Merged r179953. rdar://problem/19738528

3:42 PM Changeset in webkit [180315] by Lucas Forschler

4 edits in branches/safari-600.4.10-branch/Source/WebKit2

Merged r179952. rdar://problem/19771726

3:38 PM Changeset in webkit [180314] by Lucas Forschler

6 edits in branches/safari-600.4.10-branch/Source/WebCore

Merged r179531. rdar://problem/19738579

3:35 PM Changeset in webkit [180313] by ap@apple.com

2 edits in trunk/Source/WebKit2

Remove input and output files from "Make Frameworks Symbolic Link" step
https://bugs.webkit.org/show_bug.cgi?id=141769

Reviewed by Dan Bernstein.

WebKit2.xcodeproj/project.pbxproj:

3:31 PM Changeset in webkit [180312] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/WebKit

Merged r179992. rdar://problem/19585768

3:22 PM Changeset in webkit [180311] by Brent Fulgham

3 edits
1 move
1 add in trunk/LayoutTests

[Win] More unreviewed Windows gardening.

platform/win/TestExpectations:
platform/win/accessibility/press-targets-center-point-expected.txt: Added.
platform/win/fast/frames/frame-scrolling-attribute-exepected.txt: Removed.
platform/win/fast/frames/frame-scrolling-attribute-expected.txt: Copied from platform/win/fast/frames/frame-scrolling-attribute-exepected.txt.
platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:

3:19 PM Changeset in webkit [180310] by Lucas Forschler

3 edits
2 copies in branches/safari-600.4.10-branch

Merged r178426. rdar://problem/19585771

3:14 PM Changeset in webkit [180309] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/JavaScriptCore

Merged r179329. rdar://problem/19738498

3:05 PM Changeset in webkit [180308] by timothy_horton@apple.com

13 edits in trunk/Source

Adopt WebCore::IOSurface in ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=141751

Reviewed by Simon Fraser.

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createIOSurface): Deleted.
(WebCore::ImageBuffer::ImageBuffer):
Make use of cachedCGColorSpace.
Make use of WebCore::IOSurface.
Remove the unused size argument from ImageBufferDataCG.
Clear the IOSurface once we've allocated it; WebCore::IOSurface doesn't
do this for us, unlike wkIOSurfaceContextCreate.
Apply the flipping and scale factor to whichever context we made.
We don't need to setIsAcceleratedContext anymore because it's always
false for software contexts, and WebCore::IOSurface will set it for
any accelerated contexts.

(WebCore::ImageBuffer::context):
If we are IOSurface-backed, return WebCore::IOSurface's GraphicsContext.

(WebCore::ImageBuffer::flushContext):
Make use of context(); m_context is now null for accelerated ImageBuffers.

(WebCore::ImageBuffer::copyNativeImage):
Adopt in-line with the Create functions for clarity. Make use of
IOSurface::createImage instead of wkIOSurfaceContextCreateImage.

(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):
Make use of context(); m_context is now null for accelerated ImageBuffers.

platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::ImageBufferData):
Indentation fix, and use nullptr.

(WebCore::convertScanline):
Grammar fix (is -> are).

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
Grab the IOSurfaceRef from the IOSurface wrapper. Eventually these things
should be made more convenient by the wrapper.

platform/graphics/cg/ImageBufferDataCG.h:

Drop the unused size argument from the constructor.
Reorganize and label the various members which are only used
for a particular type of ImageBufferDataCG.

platform/graphics/cocoa/IOSurface.mm:

(IOSurface::ensureGraphicsContext):
IOSurface-backed GraphicsContexts are always considered accelerated.

(IOSurface::create):
(IOSurface::IOSurface):
Add a constructor that take an extra size to use when making the CGContext;
it can only be less than the actual backing IOSurface size.
This is needed for r160121.

platform/ios/WebCoreSystemInterfaceIOS.mm:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Remove old WKSI IOSurface-related functions.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Remove old WKSI IOSurface-related functions.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Remove old WKSI IOSurface-related functions.

3:02 PM Changeset in webkit [180307] by Lucas Forschler

3 edits
2 copies in branches/safari-600.4.10-branch

Merged r178363. rdar://problem/19738547

2:56 PM Changeset in webkit [180306] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/JavaScriptCore

Merged r178311. rdar://problem/19738492

2:52 PM Changeset in webkit [180305] by Lucas Forschler

5 edits
5 copies in branches/safari-600.4.10-branch

Merged r178038. rdar://problem/19738519

2:49 PM Changeset in webkit [180304] by Lucas Forschler

27 edits in branches/safari-600.4.10-branch

Merged r177849. rdar://problem/19585778

2:45 PM Changeset in webkit [180303] by Lucas Forschler

4 edits
4 copies in branches/safari-600.4.10-branch

Merged r177165. rdar://problem/19738587

2:42 PM Changeset in webkit [180302] by Lucas Forschler

3 edits
2 copies in branches/safari-600.4.10-branch

Merged r177089. rdar://problem/19738540

2:39 PM Changeset in webkit [180301] by commit-queue@webkit.org

62 edits in trunk/Source/WebCore

Prepare to use WEBCORE_EXPORT on Windows.
https://bugs.webkit.org/show_bug.cgi?id=141735

Patch by Alex Christensen <achristensen@webkit.org> on 2015-02-18
Reviewed by Brent Fulgham.

bindings/js/GCController.h:
bindings/js/JSDOMGlobalObject.h:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
bindings/scripts/test/JS/JSTestActiveDOMObject.h:
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:
bindings/scripts/test/JS/JSTestEventConstructor.h:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestEventTarget.h:
bindings/scripts/test/JS/JSTestException.cpp:
bindings/scripts/test/JS/JSTestException.h:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
bindings/scripts/test/JS/JSTestNamedConstructor.h:
bindings/scripts/test/JS/JSTestNode.cpp:
bindings/scripts/test/JS/JSTestNode.h:
bindings/scripts/test/JS/JSTestNondeterministic.cpp:
bindings/scripts/test/JS/JSTestNondeterministic.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bindings/scripts/test/JS/JSTestTypedefs.cpp:
bindings/scripts/test/JS/JSTestTypedefs.h:
bindings/scripts/test/JS/JSattribute.cpp:
bindings/scripts/test/JS/JSattribute.h:
bindings/scripts/test/JS/JSreadonly.cpp:
bindings/scripts/test/JS/JSreadonly.h:
bridge/runtime_method.h:
bridge/runtime_object.h:
dom/make_names.pl:

(printNamesHeaderFile):

history/HistoryItem.h:
loader/FrameLoader.h:
loader/LoaderStrategy.h:
loader/ResourceLoadScheduler.h:
loader/icon/IconDatabase.h:
loader/icon/IconDatabaseBase.h:
page/DatabaseProvider.h:
page/Page.h:
page/PageConsoleClient.h:
page/PageOverlay.h:
platform/FileSystem.h:
platform/MemoryPressureHandler.h:
platform/ThreadGlobalData.h:
platform/URL.h:
platform/graphics/ca/PlatformCALayer.h:
platform/network/BlobDataFileReference.h:
platform/network/BlobRegistry.h:
platform/network/BlobRegistryImpl.h:
platform/sql/SQLiteDatabase.h:
rendering/ScrollBehavior.h:
rendering/break_lines.h:

Add and move some WEBCORE_EXPORT macros.

2:38 PM Changeset in webkit [180300] by Lucas Forschler

4 edits
1 copy in branches/safari-600.4.10-branch

Merged r176899. rdar://problem/19585775

2:35 PM Changeset in webkit [180299] by Lucas Forschler

3 edits
2 copies in branches/safari-600.4.10-branch

Merged r176750. rdar://problem/19738583

2:28 PM Changeset in webkit [180298] by Lucas Forschler

2 edits in branches/safari-600.4.10-branch/Source/WebCore

Merged r175771. rdar://problem/19738509

2:25 PM Changeset in webkit [180297] by andersca@apple.com

2 edits
1 move in trunk/Source/WebCore

Rename LocalizedStringsMac.cpp to LocalizedStringsCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=141767

Reviewed by Tim Horton.

Also, move it to platform/cocoa instead of platform/mac.

WebCore.xcodeproj/project.pbxproj:
platform/cocoa/LocalizedStringsCocoa.mm: Renamed from Source/WebCore/platform/mac/LocalizedStringsMac.cpp.

2:25 PM Changeset in webkit [180296] by jer.noble@apple.com

2 edits in trunk/LayoutTests

Unreviewed gardening; add expectation for WK2-only failing test.

platform/mac-wk2/TestExpectations:

2:24 PM Changeset in webkit [180295] by Lucas Forschler

10 edits in branches/safari-600.4.10-branch

Merged r174712. rdar://problem/19738635

2:23 PM Changeset in webkit [180294] by Antti Koivisto

9 edits
2 moves in trunk/Source/WebCore

Rename FontGlyphs to FontCascadeFonts
https://bugs.webkit.org/show_bug.cgi?id=141754

Reviewed by Andreas Kling.

"It is better than Impl."

The purpose of the class to own to create and own the realized Font instances and the associated caches
for FontCascade instances.

2:15 PM Changeset in webkit [180293] by Beth Dakin

3 edits in trunk/Source/WebKit2

iBooks immediate action blacklist should not even create the gesture recognizer
https://bugs.webkit.org/show_bug.cgi?id=141768
-and corresponding-
rdar://problem/19806770

Reviewed by Tim Horton.

Move the runtime-application check to the point where the gesture recognizer is
created so that we can avoid doing so.

UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processPool:configuration:webView:]):

UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _updateImmediateActionItem]):

1:53 PM Changeset in webkit [180292] by Brent Fulgham

4 edits
2 adds in trunk/LayoutTests

[Win] More gardening (Unreviewed).

platform/win/TestExpectations:
platform/win/fast/frames/frame-scrolling-attribute-exepected.txt:
platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
platform/win/svg/W3C-SVG-1.1/masking-path-04-b-expected.png: Added.
platform/win/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.

1:47 PM Changeset in webkit [180291] by commit-queue@webkit.org

11 edits in trunk/Source

Unreviewed, rolling out r180286.
https://bugs.webkit.org/show_bug.cgi?id=141766

Caused >50 crashed LayoutTests (Requested by jernoble on
#webkit).

Reverted changeset:

"Page::userContentController() should return a reference, not
a pointer"
https://bugs.webkit.org/show_bug.cgi?id=141764
http://trac.webkit.org/changeset/180286

1:41 PM Changeset in webkit [180290] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

1:37 PM Changeset in webkit [180289] by bshafiei@apple.com

1 copy in tags/Safari-601.1.19

New tag.

1:19 PM Changeset in webkit [180288] by Csaba Osztrogonác

3 edits in trunk/Tools

Run JSC tests on ARM EFL bots
https://bugs.webkit.org/show_bug.cgi?id=141165

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunJavaScriptCoreTests.countFailures):
(RunRemoteJavaScriptCoreTests):
(RunRemoteJavaScriptCoreTests.start):
(BuildAndRemoteJSCTestsFactory):
(BuildAndRemoteJSCTestsFactory.init):

1:15 PM March 2015 Meeting edited by dino@apple.com

(diff)

1:13 PM Changeset in webkit [180287] by ddkilzer@apple.com

13 edits
2 adds in trunk/Source/WebCore

Consolidate soft-linked CMTimeMakeWithSeconds() function
<http://webkit.org/b/141655>

Reviewed by Brent Fulgham.

Configurations/WebCore.unexp: Remove workaround for

CMTimeMakeWithSeconds() weak external.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
Add CoreMediaSoftLink.{cpp,h} to the project.

platform/cf/CoreMediaSoftLink.cpp: Add.
platform/cf/CoreMediaSoftLink.h: Add.
Implement new strategy where code for soft-linking is only in one place, and the header can simply be included wherever a soft-linked method is needed.

platform/graphics/avfoundation/MediaTimeAVFoundation.cpp:
platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h:
platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
platform/mac/PlatformClockCM.mm:
Remove old soft-linking strategy and include CoreMediaSoftLink.h.

platform/mac/SoftLinking.h:

(SOFT_LINK_FUNCTION_DECL): Add. New macro function used for
header declaration. Split out from SOFT_LINK() macro. Also
stop violating C++ standards by redeclaring an inline function
with the exact same signature as an extern "C" function. This
now matches what we do on Windows (where Visual C++ already
prevented these shenanigans).
(SOFT_LINK_FUNCTION_IMPL): Add. New macro function used for
source implementation. Split out the from SOFT_LINK() macro.

platform/win/SoftLinking.h:

(SOFT_LINK_FRAMEWORK): Map mac/SoftLinking.h macro name to
Windows macros so we can simplify CoreMediaSoftLink.{cpp,h}.
(SOFT_LINK_FUNCTION_DECL): Add.
(SOFT_LINK_FUNCTION_IMPL): Add.

New macro functions split out from SOFT_LINK_DLL_IMPORT() macro for header declaration and source implementation.
We assume the cdecl calling convention because that's what all Apple libraries use, and so we are able to use the exact same macro function on both Mac and Windows to simplify CoreMediaSoftLink.{cpp,h}.

12:51 PM Changeset in webkit [180286] by beidson@apple.com

11 edits in trunk/Source

Page::userContentController() should return a reference, not a pointer
https://bugs.webkit.org/show_bug.cgi?id=141764

Reviewed by Jer Noble.

Source/WebCore:

No new tests (No behavior change)

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):

page/DOMWindow.cpp:

(WebCore::DOMWindow::shouldHaveWebKitNamespaceForWorld):

page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::setUserContentController):

page/Page.h:

(WebCore::Page::userContentController):

page/UserMessageHandlersNamespace.cpp:

(WebCore::UserMessageHandlersNamespace::handler):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView setGroupName:]):

12:42 PM Changeset in webkit [180285] by roger_fong@apple.com

9 edits in trunk/Source/WebCore

WebGL2: Promote various WebGL1 extensions to core for WebGL2.
https://bugs.webkit.org/show_bug.cgi?id=141446
<rdar://problem/19633715>

Reviewed by Brent Fulham.

Tests covered by WebGL2 conformance tests.

This patch promotes the following WebGL1 extensions to core in WebGL2:
OES_element_index_uint
EXT_sRGB
EXT_blend_minmax
EXT_frag_depth
EXT_shader_texture_lod
OES_standard_derivatives

The latter 3 are enabled by default now for GLSL1, though we will get these extensions
for free when GLSL3 becomes available.

WebGL2 binding code should actually fall back to base implementation for getFramebufferAttachmentParameter.

bindings/js/JSWebGL2RenderingContextCustom.cpp:

(WebCore::JSWebGL2RenderingContext::getFramebufferAttachmentParameter): Deleted.

html/canvas/WebGL2RenderingContext.idl: Ditto.

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension): Enable WEBGL_lose_context as an extension again.
It was not promoted to core as I originally thought it had been.
(WebCore::WebGL2RenderingContext::getSupportedExtensions): Ditto.
(WebCore::WebGL2RenderingContext::WebGL2RenderingContext): Promote the 3 shader extensions for GLSL1 to core.
(WebCore::WebGL2RenderingContext::initializeShaderExtensions): Ditto.
(WebCore::WebGL2RenderingContext::getFramebufferAttachmentParameter): Promote SRGB extension to core.
(WebCore::WebGL2RenderingContext::renderbufferStorage): Ditto.
(WebCore::WebGL2RenderingContext::hint): Ditto.
(WebCore::WebGL2RenderingContext::validateTexFuncFormatAndType): Ditto.
(WebCore::WebGL2RenderingContext::validateIndexArrayConservative): Promote OES_element_index_uint extension to core.
(WebCore::WebGL2RenderingContext::validateDrawElements): Ditto.
(WebCore::WebGL2RenderingContext::validateBlendEquation): Promote EXT_blend_minmax extension to core.

html/canvas/WebGL2RenderingContext.h:

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Copied form WebGLRenderingContextBase.
(WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
(WebCore::WebGLRenderingContext::hint): Ditto.
(WebCore::WebGLRenderingContext::validateIndexArrayConservative): Ditto.
(WebCore::WebGLRenderingContext::validateDrawElements): Ditto.
(WebCore::WebGLRenderingContext::validateBlendEquation): Ditto.

html/canvas/WebGLRenderingContext.h:

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateIndexArrayConservative): Deleted.
(WebCore::WebGLRenderingContextBase::validateDrawElements): Deleted.
(WebCore::WebGLRenderingContextBase::getExtension): Deleted.
(WebCore::WebGLRenderingContextBase::getFramebufferAttachmentParameter): Deleted.
(WebCore::WebGLRenderingContextBase::hint): Deleted.
(WebCore::WebGLRenderingContextBase::renderbufferStorage): Deleted.
(WebCore::WebGLRenderingContextBase::validateBlendEquation): Deleted.

html/canvas/WebGLRenderingContextBase.h:

12:15 PM Changeset in webkit [180284] by Lucas Forschler

4 edits
2 copies in branches/safari-600.4.10-branch

Merged r174085. rdar://problem/19738573

12:10 PM Changeset in webkit [180283] by Lucas Forschler

7 edits
2 copies in branches/safari-600.4.10-branch

Merged r173806. rdar://problem/19850795

12:08 PM Changeset in webkit [180282] by achristensen@apple.com

6 edits in trunk

Streamline unexported function build fixes
https://bugs.webkit.org/show_bug.cgi?id=141761

Patch by Alexey Proskuryakov <ap@apple.com> on 2015-02-18
Reviewed by Alex Christensen.

Source/WebCore:

Configurations/WebCore.unexp: Added some functions for symbols only used on newer

OS versions. Removed a special case for NodeList, to handle it uniformly with Node.

Configurations/WebCore.xcconfig: Made the unexported list unconditional, because

it's not only Xcode 5 that is affected.

bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): We already had a hack for

Node, NodeList needs an exactly the same one. Also updated the comments.

Tools:

Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.

We don't need to ignore symbols that are not exported due to the .unexp file.

12:05 PM Changeset in webkit [180281] by Chris Dumez

23 edits in trunk/Source

Access FontCache global instance via singleton() static member function
https://bugs.webkit.org/show_bug.cgi?id=141726

Reviewed by Daniel Bates.

Access FontCache global instance via singleton() static member function,
as per coding style.

11:57 AM Changeset in webkit [180280] by ap@apple.com

2 edits in trunk/Source/WebCore

Crashes under IDBDatabase::closeConnection.
https://bugs.webkit.org/show_bug.cgi?id=141745
rdar://problem/19816412

Reviewed by David Kilzer.

Modules/indexeddb/IDBDatabase.cpp: (WebCore::IDBDatabase::closeConnection):

Add a missing protector.

11:55 AM Changeset in webkit [180279] by fpizlo@apple.com

78 edits
14 adds in trunk

DFG should really support varargs
https://bugs.webkit.org/show_bug.cgi?id=141332

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This adds comprehensive vararg call support to the DFG and FTL compilers. Previously, if a
function had a varargs call, then it could only be compiled if that varargs call was just
forwarding arguments and we were inlining the function rather than compiling it directly. Also,
only varargs calls were dealt with; varargs constructs were not.

This lifts all of those restrictions. Every varargs call or construct can now be compiled by both
the DFG and the FTL. Those calls can also be inlined, too - provided that profiling gives us a
sensible bound on arguments list length. When we inline a varargs call, the act of loading the
varargs is now made explicit in IR. I believe that we have enough IR machinery in place that we
would be able to do the arguments forwarding optimization as an IR transformation. This patch
doesn't implement that yet, and keeps the old bytecode-based varargs argument forwarding
optimization for now.

There are three major IR features introduced in this patch:

CallVarargs/ConstructVarargs: these are like Call/Construct except that they take an arguments
array rather than a list of arguments. Currently, they splat this arguments array onto the stack
using the same basic technique as the baseline JIT has always done. Except, these nodes indicate
that we are not interested in doing the non-escaping "arguments" optimization.

CallForwardVarargs: this is a form of CallVarargs that just does the non-escaping "arguments"
optimization, aka forwarding arguments. It's somewhat lazy that this doesn't include
ConstructForwardVarargs, but the reason is that once we eliminate the lazy tear-off for
arguments, this whole thing will have to be tweaked - and for now forwarding on construct is just
not important in benchmarks. ConstructVarargs will still do forwarding, just not inlined.

LoadVarargs: loads all elements out of an array onto the stack in a manner suitable for a varargs
call. This is used only when a varargs call (or construct) was inlined. The bytecode parser will
make room on the stack for the arguments, and will use LoadVarars to put those arguments into
place.

In the future, we can consider adding strength reductions like:

If CallVarargs/ConstructVarargs see an array of known size with known elements, turn them into Call/Construct.

If CallVarargs/ConstructVarargs are passed an unmodified, unescaped Arguments object, then turn them into CallForwardVarargs/ConstructForwardVarargs.

If LoadVarargs sees an array of known size, then turn it into a sequence of GetByVals and PutLocals.

If LoadVarargs sees an unmodified, unescaped Arguments object, then turn it into something like LoadForwardVarargs.

If CallVarargs/ConstructVarargs/LoadVarargs see the result of a splice (or other Array prototype function), then do the splice and varargs loading in one go (maybe via a new node type).

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
assembler/MacroAssembler.h:

(JSC::MacroAssembler::rshiftPtr):
(JSC::MacroAssembler::urshiftPtr):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::urshift64):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::urshift64):

assembler/X86Assembler.h:

(JSC::X86Assembler::shrq_i8r):

bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::CallLinkInfo):

bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFor):
(JSC::CallLinkStatus::setProvenConstantCallee):
(JSC::CallLinkStatus::dump):

bytecode/CallLinkStatus.h:

(JSC::CallLinkStatus::maxNumArguments):
(JSC::CallLinkStatus::setIsProved): Deleted.

bytecode/CodeOrigin.cpp:

(WTF::printInternal):

bytecode/CodeOrigin.h:

(JSC::InlineCallFrame::varargsKindFor):
(JSC::InlineCallFrame::specializationKindFor):
(JSC::InlineCallFrame::isVarargs):
(JSC::InlineCallFrame::isNormalCall): Deleted.

bytecode/ExitKind.cpp:

(JSC::exitKindToString):

bytecode/ExitKind.h:
bytecode/ValueRecovery.cpp:

(JSC::ValueRecovery::dumpInContext):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::run):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::emitFunctionChecks):
(JSC::DFG::ByteCodeParser::inliningCost):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleTypedArrayConstructor):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::removeLastNodeFromGraph): Deleted.
(JSC::DFG::ByteCodeParser::undoFunctionChecks): Deleted.

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGCapabilities.h:

(JSC::DFG::functionCapabilityLevel):
(JSC::DFG::mightCompileFunctionFor):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGCommon.cpp:

(WTF::printInternal):

dfg/DFGCommon.h:

(JSC::DFG::canInline):
(JSC::DFG::leastUpperBound):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::isLiveInBytecode):
(JSC::DFG::Graph::valueProfileFor):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor): Deleted.
(JSC::DFG::Graph::methodOfGettingAValueProfileFor): Deleted.

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):

dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

dfg/DFGNode.h:

(JSC::DFG::Node::hasCallVarargsData):
(JSC::DFG::Node::callVarargsData):
(JSC::DFG::Node::hasLoadVarargsData):
(JSC::DFG::Node::loadVarargsData):
(JSC::DFG::Node::hasHeapPrediction):

dfg/DFGNodeType.h:
dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPlan.cpp:

(JSC::DFG::dumpAndVerifyGraph):
(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
(JSC::DFG::PreciseLocalClobberizeAdaptor::writeTop):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSSAConversionPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isFlushed):
(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):
(JSC::DFG::StackLayoutPhase::assign):

dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validateCPS):

ftl/FTLAbbreviations.h:

(JSC::FTL::functionType):
(JSC::FTL::buildCall):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfCall):
(JSC::FTL::sizeOfCallVarargs):
(JSC::FTL::sizeOfCallForwardVarargs):
(JSC::FTL::sizeOfConstructVarargs):
(JSC::FTL::sizeOfIn):
(JSC::FTL::sizeOfICFor):
(JSC::FTL::sizeOfCheckIn): Deleted.

ftl/FTLInlineCacheSize.h:
ftl/FTLIntrinsicRepository.h:
ftl/FTLJSCall.cpp:

(JSC::FTL::JSCall::JSCall):

ftl/FTLJSCallBase.cpp:
ftl/FTLJSCallBase.h:
ftl/FTLJSCallVarargs.cpp: Added.

(JSC::FTL::JSCallVarargs::JSCallVarargs):
(JSC::FTL::JSCallVarargs::numSpillSlotsNeeded):
(JSC::FTL::JSCallVarargs::emit):
(JSC::FTL::JSCallVarargs::link):

ftl/FTLJSCallVarargs.h: Added.

(JSC::FTL::JSCallVarargs::node):
(JSC::FTL::JSCallVarargs::stackmapID):
(JSC::FTL::JSCallVarargs::operator<):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::LowerDFGToLLVM::compileLoadVarargs):
(JSC::FTL::LowerDFGToLLVM::compileIn):
(JSC::FTL::LowerDFGToLLVM::emitStoreBarrier):
(JSC::FTL::LowerDFGToLLVM::vmCall):
(JSC::FTL::LowerDFGToLLVM::vmCallNoExceptions):
(JSC::FTL::LowerDFGToLLVM::callCheck):

ftl/FTLOutput.h:

(JSC::FTL::Output::call):

ftl/FTLState.cpp:

(JSC::FTL::State::State):

ftl/FTLState.h:
interpreter/Interpreter.cpp:

(JSC::sizeOfVarargs):
(JSC::sizeFrameForVarargs):

interpreter/Interpreter.h:
interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readInlinedFrame):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitExceptionCheck):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::calleeFrameSlot):
(JSC::AssemblyHelpers::calleeArgumentSlot):
(JSC::AssemblyHelpers::calleeFrameTagSlot):
(JSC::AssemblyHelpers::calleeFramePayloadSlot):
(JSC::AssemblyHelpers::calleeArgumentTagSlot):
(JSC::AssemblyHelpers::calleeArgumentPayloadSlot):
(JSC::AssemblyHelpers::calleeFrameCallerFrame):
(JSC::AssemblyHelpers::selectScratchGPR):

jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):

jit/GPRInfo.h:
jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):

jit/JITCall32_64.cpp:

(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):

jit/JITOperations.h:
jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

jit/SetupVarargsFrame.h:
runtime/Arguments.h:

(JSC::Arguments::create):
(JSC::Arguments::registerArraySizeInBytes):
(JSC::Arguments::finishCreation):

runtime/Options.h:
tests/stress/construct-varargs-inline-smaller-Foo.js: Added.

(Foo):
(bar):
(checkEqual):
(test):

tests/stress/construct-varargs-inline.js: Added.

(Foo):
(bar):
(checkEqual):
(test):

tests/stress/construct-varargs-no-inline.js: Added.

(Foo):
(bar):
(checkEqual):
(test):

tests/stress/get-argument-by-val-in-inlined-varargs-call-out-of-bounds.js: Added.

(foo):
(bar):

tests/stress/get-argument-by-val-safe-in-inlined-varargs-call-out-of-bounds.js: Added.

(foo):
(bar):

tests/stress/get-my-argument-by-val-creates-arguments.js: Added.

(blah):
(foo):
(bar):
(checkEqual):
(test):

tests/stress/load-varargs-then-inlined-call-exit-in-foo.js: Added.

(foo):
(bar):
(checkEqual):

tests/stress/load-varargs-then-inlined-call-inlined.js: Added.

(foo):
(bar):
(baz):
(checkEqual):
(test):

tests/stress/load-varargs-then-inlined-call.js: Added.

(foo):
(bar):
(checkEqual):
(test):

LayoutTests:

Adds a version of deltablue that uses rest arguments profusely. This speeds up by 20% with this
patch. I believe that the machinery that this patch puts in place will allow us to ultimately
run deltablue-varargs at the same steady-state performance as normal deltablue.

js/regress/deltablue-varargs-expected.txt: Added.
js/regress/deltablue-varargs.html: Added.
js/regress/script-tests/deltablue-varargs.js: Added.

(args):
(Object.prototype.inheritsFrom):
(OrderedCollection):
(OrderedCollection.prototype.add):
(OrderedCollection.prototype.at):
(OrderedCollection.prototype.size):
(OrderedCollection.prototype.removeFirst):
(OrderedCollection.prototype.remove):
(Strength):
(Strength.stronger):
(Strength.weaker):
(Strength.weakestOf):
(Strength.strongest):
(Strength.prototype.nextWeaker):
(Constraint):
(Constraint.prototype.addConstraint):
(Constraint.prototype.satisfy):
(Constraint.prototype.destroyConstraint):
(Constraint.prototype.isInput):
(UnaryConstraint):
(UnaryConstraint.prototype.addToGraph):
(UnaryConstraint.prototype.chooseMethod):
(UnaryConstraint.prototype.isSatisfied):
(UnaryConstraint.prototype.markInputs):
(UnaryConstraint.prototype.output):
(UnaryConstraint.prototype.recalculate):
(UnaryConstraint.prototype.markUnsatisfied):
(UnaryConstraint.prototype.inputsKnown):
(UnaryConstraint.prototype.removeFromGraph):
(StayConstraint):
(StayConstraint.prototype.execute):
(EditConstraint.prototype.isInput):
(EditConstraint.prototype.execute):
(BinaryConstraint):
(BinaryConstraint.prototype.chooseMethod):
(BinaryConstraint.prototype.addToGraph):
(BinaryConstraint.prototype.isSatisfied):
(BinaryConstraint.prototype.markInputs):
(BinaryConstraint.prototype.input):
(BinaryConstraint.prototype.output):
(BinaryConstraint.prototype.recalculate):
(BinaryConstraint.prototype.markUnsatisfied):
(BinaryConstraint.prototype.inputsKnown):
(BinaryConstraint.prototype.removeFromGraph):
(ScaleConstraint):
(ScaleConstraint.prototype.addToGraph):
(ScaleConstraint.prototype.removeFromGraph):
(ScaleConstraint.prototype.markInputs):
(ScaleConstraint.prototype.execute):
(ScaleConstraint.prototype.recalculate):
(EqualityConstraint):
(EqualityConstraint.prototype.execute):
(Variable):
(Variable.prototype.addConstraint):
(Variable.prototype.removeConstraint):
(Planner):
(Planner.prototype.incrementalAdd):
(Planner.prototype.incrementalRemove):
(Planner.prototype.newMark):
(Planner.prototype.makePlan):
(Planner.prototype.extractPlanFromConstraints):
(Planner.prototype.addPropagate):
(Planner.prototype.removePropagateFrom):
(Planner.prototype.addConstraintsConsumingTo):
(Plan):
(Plan.prototype.addConstraint):
(Plan.prototype.size):
(Plan.prototype.constraintAt):
(Plan.prototype.execute):
(chainTest):
(projectionTest):
(change):
(deltaBlue):

11:39 AM Changeset in webkit [180278] by mmaxfield@apple.com

4 edits
2 adds in trunk

Justified ruby can cause lines to grow beyond their container
https://bugs.webkit.org/show_bug.cgi?id=141732

Reviewed by David Hyatt.

Source/WebCore:

After we re-layout RenderRubyRuns, this can change the environment upon which
ruby's overhang calculation is sensitive to. Before this patch, we would recalculate
the overhang after the RenderRubyRun gets relaid out. However, doing such causes the
effective width of the RenderRubyRun to change, which causes out subsequent
justification calculations to be off.

Therefore, we have a cycle; the amount of ruby overhang can change the justification
in a line, and the layout of the line affects the ruby overhang calculation. Instead
of performing a layout in a loop until it converges, this patch simply observes that
having a flush right edge is more valuable than having a perfectly correct overhang.
It therefore simply removes the secondary overhang calculation.

Test: fast/text/ruby-justification-flush.html

rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateRubyForJustifiedText):
(WebCore::RenderBlockFlow::computeExpansionForJustifiedText):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

LayoutTests:

Make sure that the right edge of a justified ruby line matches up with
the same line without ruby.

fast/text/ruby-justification-flush-expected.html: Added.
fast/text/ruby-justification-flush.html: Added.

11:34 AM Changeset in webkit [180277] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Add WKContext SPI to clear all visited links
https://bugs.webkit.org/show_bug.cgi?id=141752
<rdar://problem/9997966>

Reviewed by Dan Bernstein.

UIProcess/API/C/WKContext.cpp:

(WKContextClearVisitedLinks):

UIProcess/API/C/WKContext.h:

11:32 AM Changeset in webkit [180276] by Chris Dumez

4 edits in trunk/Source

Evict dead resources in MemoryCache in MemoryPressureHandler::releaseNoncriticalMemory()
https://bugs.webkit.org/show_bug.cgi?id=141723

Reviewed by Andreas Kling.

Evict dead resources from the MemoryCache on non-critical memory
pressure. On critical memory pressure, we already evict ALL resources
from the MemoryCache. It is a good idea to start by evicting resources
we care less about on non-critical warning to decrease the chances of
getting a critical warning and thus having to clear the whole
MemoryCache.

loader/cache/MemoryCache.h:
platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::releaseNoncriticalMemory):
(WebCore::MemoryPressureHandler::releaseCriticalMemory):
(WebCore::MemoryPressureHandler::releaseMemory):
Call releaseCriticalMemory() before releaseNoncriticalMemory()
as releaseCriticalMemory() is more aggressive. Doing it the
other way around would mean that on critical warning, we would
first evict dead resources, then evict all resources. It is
more efficient to evict all resources first, as it makes the
non-critical operation (evict dead resources) a no-op.

11:29 AM Changeset in webkit [180275] by dino@apple.com

10 edits in branches/safari-600.5-branch/LayoutTests

Rebaseline tests for safari-600.5-branch.
<rdar://problem/19861390>

media/video-colorspace-yuv420-expected.txt:
media/video-colorspace-yuv422-expected.txt:
platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
platform/mac/fast/layers/video-layer-expected.txt:
platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/controls-without-preload-expected.txt:
platform/mac/media/media-controls-clone-expected.txt:
platform/mac/media/video-no-audio-expected.txt:

11:19 AM Changeset in webkit [180274] by eric.carlson@apple.com

9 edits
1 copy
1 add in trunk

[iOS] pause video when a tab moves to the background on some devices
https://bugs.webkit.org/show_bug.cgi?id=141753
<rdar://problem/19814562>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-background-tab-playback.html

platform/audio/MediaSession.cpp:

(WebCore::MediaSession::clientDataBufferingTimerFired): Pause video when the element becomes

hidden if the BackgroundTabPlaybackRestricted is set.

platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::applicationWillEnterBackground): Rename BackgroundPlaybackNotPermitted

to BackgroundProcessPlaybackRestricted.

(WebCore::MediaSessionManager::applicationWillEnterForeground): Ditto.

platform/audio/MediaSessionManager.h:

platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::resetRestrictions): Set BackgroundTabPlaybackRestricted on

devices with restricted memory. BackgroundPlaybackNotPermitted -> BackgroundProcessPlaybackRestricted.

testing/Internals.cpp:

(WebCore::Internals::setMediaSessionRestrictions): Add support for BackgroundTabPlaybackRestricted.

BackgroundPlaybackNotPermitted -> BackgroundProcessPlaybackRestricted.

LayoutTests:

media/video-background-playback-expected.txt: BackgroundPlaybackNotPermitted -> BackgroundProcessPlaybackRestricted.
media/video-background-playback.html: Ditto.
media/video-background-tab-playback-expected.txt: Added.
media/video-background-tab-playback.html: Added.

11:00 AM Changeset in webkit [180273] by hyatt@apple.com

8 edits
2 adds in trunk

Wrong text-decoration-style used for underlines.

11:00 AM Changeset in webkit [180272] by ggaren@apple.com

4 edits
1 add in trunk/Source/bmalloc

bmalloc: VMHeap should keep a record of all of its VM ranges (for malloc introspection)
https://bugs.webkit.org/show_bug.cgi?id=141759

Reviewed by Andreas Kling.

bmalloc.xcodeproj/project.pbxproj:
bmalloc/SuperChunk.h: Added.

(bmalloc::SuperChunk::create):
(bmalloc::SuperChunk::SuperChunk):
(bmalloc::SuperChunk::smallChunk):
(bmalloc::SuperChunk::mediumChunk):
(bmalloc::SuperChunk::largeChunk): Factored out super chunk creation
into a separate class, for clarity and type safety.

bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::grow):
(bmalloc::VMHeap::allocateSuperChunk): Renamed "allocateSuperChunk" to
"grow" because Andreas found "allocateSuperChunk" to be unclear.

bmalloc/VMHeap.h: Track all our VM ranges. We will use this information

for malloc introspection.

(bmalloc::VMHeap::allocateSmallPage):
(bmalloc::VMHeap::allocateMediumPage):
(bmalloc::VMHeap::allocateLargeRange): Updated for renames.

10:29 AM Changeset in webkit [180271] by mmaxfield@apple.com

10 edits
3 copies in trunk/LayoutTests

Update more test expected results after r177774
https://bugs.webkit.org/show_bug.cgi?id=141743

Reviewed by Brent Fulgham.

platform/mac/TestExpectations:
platform/mac/fast/dom/character-index-for-point-expected.txt:
platform/mac/fast/forms/select-initial-position-expected.txt:
platform/mac/fast/replaced/width100percent-textarea-expected.txt:
platform/mac/fast/text/atsui-rtl-override-selection-expected.txt:
platform/mac/fast/text/international/text-combine-image-test-expected.txt:
platform/mac-mavericks/fast/forms/select-initial-position-expected.txt:
platform/mac-mavericks/fast/replaced/width100percent-textarea-expected.txt:
platform/mac-mavericks/fast/text/international/text-combine-image-test-expected.txt:
svg/text/lengthAdjust-text-metrics-expected.txt:
svg/text/script-tests/lengthAdjust-text-metrics.js:
svg/text/text-rect-precision.html:

10:23 AM Changeset in webkit [180270] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, Restoring the C LOOP insta-crash fix in r180184.

Fixed a typo that only affected the C Loop in the prologue() macro in LowLevelInterpreter.asm.
After the stackHeightOKGetCodeBlock label, codeBlockSetter(t1) should be codeBlockGetter(t1).

llint/LowLevelInterpreter.asm: Fixed a typo.

10:22 AM Changeset in webkit [180269] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r180260): Try to fix incremental builds by changing UserContentController.cpp

Attempt to fix this linker error by making a non-coding change:

Undefined symbols for architecture i386:

"ZN7WebCore17ContentExtensions24ContentExtensionsBackendC1Ev", referenced from:

ZN7WebCore21UserContentController20addUserContentFilterERKN3WTF6StringES4_ in UserContentController.o

ld: symbol(s) not found for architecture i386

This should have been fixed by r180266, but perhaps Xcode didn't
recognize that it needed to rebuild this source file.

page/UserContentController.cpp: Update copyright.

9:52 AM Changeset in webkit [180268] by akling@apple.com

4 edits in trunk/Source/WebCore

Purge PassRefPtr from CanvasRenderingContext2D.
<https://webkit.org/b/141749>

Reviewed by Gyuyoung Kim.

Switch from using PassRefPtr to RefPtr/Ref in CanvasRenderingContext2D.

html/TextMetrics.h:

(WebCore::TextMetrics::create): Changed create() helper to return Ref.

html/canvas/CanvasRenderingContext2D.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard): Changed to take a reference.

(WebCore::CanvasRenderingContext2D::createLinearGradient):
(WebCore::CanvasRenderingContext2D::createRadialGradient):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::createEmptyImageData):
(WebCore::CanvasRenderingContext2D::createImageData):
(WebCore::CanvasRenderingContext2D::getImageData):
(WebCore::CanvasRenderingContext2D::webkitGetImageDataHD): Made these return RefPtr. Also did
a bunch of 0 -> nullptr conversion, removed a bunch of unnecessary RefPtr::release() calls,
and changed a PassRefPtr argument to RefPtr&&.

(WebCore::CanvasRenderingContext2D::measureText): Made this return Ref.

9:34 AM Changeset in webkit [180267] by Brent Fulgham

3 edits
21 adds in trunk/LayoutTests

[Win] Gardening: Update baselines on Windows bots after removing mac-mountainlion

platform/win/TestExpectations:
platform/win/editing/selection/5057506-2-expected.png: Added.
platform/win/editing/selection/5057506-2-expected.txt: Added.
platform/win/fast/attachment: Added.
platform/win/fast/attachment/attachment-disabled-rendering-expected.txt: Added.
platform/win/fast/attachment/attachment-rendering-expected.txt: Added.
platform/win/fast/frames/frame-scrolling-attribute-exepected.txt: Added.
platform/win/fast/repaint/selection-ruby-rl-expected.txt: Added.
platform/win/http/tests/security/XFrameOptions: Added.
platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
platform/win/http/tests/security/cross-frame-access-callback-explicit-domain-ALLOW-expected.txt: Added.
platform/win/svg/batik/text/textEffect2-expected.txt: Added.
platform/win/svg/batik/text/textEffect3-expected.txt: Added.
platform/win/svg/batik/text/textProperties-expected.txt: Added.
platform/win/svg/custom/text-filter-expected.txt: Added.
platform/win/svg/filters/feColorMatrix-values-expected.png:
platform/win/svg/filters/feColorMatrix-values-expected.txt: Added.
platform/win/svg/filters/filter-on-filter-for-text-expected.txt: Added.
platform/win/svg/filters/filter-on-tspan-expected.txt: Added.
platform/win/svg/filters/sourceAlpha-expected.txt: Added.
platform/win/svg/repaint/text-mask-update-expected.txt: Added.
platform/win/tables/mozilla/bugs/bug131020-expected.png: Added.
platform/win/tables/mozilla/bugs/bug131020-expected.txt: Added.

9:08 AM Changeset in webkit [180266] by commit-queue@webkit.org

6 edits
2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r180260.
https://bugs.webkit.org/show_bug.cgi?id=141757

Broke the 32-bit builders (Requested by jessieberlin on
#webkit).

Reverted changeset:

"Add a trivial code generator for the DFA"
https://bugs.webkit.org/show_bug.cgi?id=141017
http://trac.webkit.org/changeset/180260

8:31 AM Changeset in webkit [180265] by andersca@apple.com

14 edits in trunk/Source

Add API for clearing in-memory caches to WKWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=141724

Reviewed by Tim Horton.

Source/WebCore:

Add a version of evictResources that takes a session id.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::evictResources):

Source/WebKit2:

Shared/WebsiteData/WebsiteDataTypes.h:

Add WebsiteDataTypeMemoryCache.

UIProcess/API/Cocoa/_WKWebsiteDataStore.h:

Add WKWebsiteDataTypeMemoryCache.

UIProcess/API/Cocoa/_WKWebsiteDataStore.mm:

(toWebsiteDataTypes):
Handle WKWebsiteDataTypeMemoryCache and convert it to WebsiteDataTypeMemoryCache.

UIProcess/WebProcessProxy.cpp:

(WebKit::generateCallbackID):
Generate a new callback.

(WebKit::WebProcessProxy::~WebProcessProxy):
Assert that we don't have any pending callbacks.

(WebKit::WebProcessProxy::connectionDidClose):
Invoke pending callbacks.

(WebKit::WebProcessProxy::canTerminateChildProcess):
Don't try to terminate if we have pending callbacks.

(WebKit::WebProcessProxy::didDeleteWebsiteData):
Take the callback and invoke it.

(WebKit::WebProcessProxy::deleteWebsiteData):
Send a delete message.

UIProcess/WebProcessProxy.h:

Add new members.

UIProcess/WebProcessProxy.messages.in:

Add DidDeleteWebsiteData message.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::computeNetworkProcessAccessType):
Spell persistent correctly.

(WebKit::computeWebProcessAccessType):
Return a web process access type given the a data type mask.

(WebKit::WebsiteDataStore::removeData):
Ask any associated web processes to remove website data.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::deleteWebsiteData):
Delete the memory cache if requested.

WebProcess/WebProcess.h:

Add new member.

WebProcess/WebProcess.messages.in:

Add DeleteWebsiteData message.

5:47 AM WebKitGTK/Gardening/Howto edited by clopez@igalia.com

(diff)

5:36 AM WebKitGTK/2.8.x edited by zandobersek@gmail.com

Add r180264 as proposed for merging into 2.7.91. (diff)

5:31 AM Changeset in webkit [180264] by zandobersek@gmail.com

2 edits in trunk/Source/bmalloc

Build bmalloc through CMake as a static library. It's then linked either
into the WTF library (if built as a shared library) or into the JSC and
WebKit2 libraries. There's no need to build it as a standalone shared library.

Rubber-stamped by Carlos Garcia Campos.

CMakeLists.txt:

2:28 AM Changeset in webkit [180263] by Manuel Rego Casasnovas

3 edits in trunk/LayoutTests

[CSS Grid Layout] Remove some leftovers related to "stack" removal
https://bugs.webkit.org/show_bug.cgi?id=141722

Reviewed by Sergio Villar Senin.

In r177858 "stack" packing mode was removed from grid-auto-flow syntax.

This patch removes some missing cases, where "stack" was still used in
the layout tests.

fast/css-grid-layout/grid-auto-flow-resolution.html: Remove

gridAutoFlowStack usage.

fast/css-grid-layout/resources/grid.css:

(.gridAutoFlowStack): Deleted.

1:35 AM Changeset in webkit [180262] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

URTBF after r180258 to fix Windows build.

runtime/MathCommon.cpp:

(JSC::mathPowInternal):

1:00 AM Changeset in webkit [180261] by timothy_horton@apple.com

4 edits in trunk

Remove more references to WebCore.exp.in
https://bugs.webkit.org/show_bug.cgi?id=141747

Reviewed by Alexey Proskuryakov.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj:

Tools:

BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

12:57 AM Changeset in webkit [180260] by benjamin@webkit.org

6 edits
2 adds in trunk/Source/WebCore

Add a trivial code generator for the DFA
https://bugs.webkit.org/show_bug.cgi?id=141017

Reviewed by Andreas Kling.

Nothing fancy yet, this is just doing a literal translation from the DFA
to machine code. It is extremely inefficient at the moment.

WebCore.xcodeproj/project.pbxproj:
contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::ContentExtensionsBackend):
(WebCore::ContentExtensions::ContentExtensionsBackend::setRuleList):
(WebCore::ContentExtensions::addActionToHashSet):
(WebCore::ContentExtensions::ContentExtensionsBackend::shouldBlockURL):

contentextensions/ContentExtensionsBackend.h:
contentextensions/DFA.cpp:

(WebCore::ContentExtensions::DFA::nextState): Deleted.
(WebCore::ContentExtensions::DFA::actions): Deleted.

contentextensions/DFA.h:

(WebCore::ContentExtensions::DFA::size):
(WebCore::ContentExtensions::DFA::nodeAt):

contentextensions/DFACompiler.cpp: Added.

(WebCore::ContentExtensions::compileDFA):
(WebCore::ContentExtensions::DFACodeGenerator::DFACodeGenerator):
(WebCore::ContentExtensions::DFACodeGenerator::compile):
(WebCore::ContentExtensions::DFACodeGenerator::lowerStateMachine):
(WebCore::ContentExtensions::DFACodeGenerator::lowerNode):
(WebCore::ContentExtensions::DFACodeGenerator::getNextCharacter):
(WebCore::ContentExtensions::DFACodeGenerator::callAddActionFunction):

contentextensions/DFACompiler.h: Copied from Source/WebCore/contentextensions/DFA.h.

12:57 AM Changeset in webkit [180259] by Joseph Pecoraro

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r180235): It broke the !ENABLE(PROMISES) build
https://bugs.webkit.org/show_bug.cgi?id=141746

Unreviewed build fix.

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):
Wrap JSPromise related code in ENABLE(PROMISES) guard.

12:17 AM WebKitGTK/2.8.x edited by Carlos Garcia Campos

(diff)

12:01 AM Changeset in webkit [180258] by benjamin@webkit.org

9 edits
2 adds in trunk/Source/JavaScriptCore

Fix the C-Loop LLInt build
https://bugs.webkit.org/show_bug.cgi?id=141618

Reviewed by Filip Pizlo.

I broke C-Loop when moving the common code of pow()
to JITOperations because that file is #ifdefed out
when the JITs are disabled.

It would be weird to move it back to MathObject since
the function needs to know about the calling conventions.

To avoid making a mess, I just gave the function its own file
that is used by both the runtime and the JIT.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGAbstractInterpreterInlines.h:
jit/JITOperations.cpp:
jit/JITOperations.h:
runtime/MathCommon.cpp: Added.

(JSC::fdlibmScalbn):
(JSC::fdlibmPow):
(JSC::isDenormal):
(JSC::isEdgeCase):
(JSC::mathPowInternal):
(JSC::operationMathPow):

runtime/MathCommon.h: Added.
runtime/MathObject.cpp:

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed