⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 10, 2015:

11:11 PM Changeset in webkit [181367] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

Web Inspector: CSS parser errors in the console should include column numbers
​https://bugs.webkit.org/show_bug.cgi?id=114313

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-10
Reviewed by Benjamin Poulain.

Source/WebCore:

Test: inspector-protocol/console/warnings-errors.html

  • css/CSSParser.h:

(WebCore::CSSParser::currentCharacterOffset):
Get the current character offset depending on the source type.
Add instance variables to track column position and start
line / column for inline stylesheets.

  • css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
Initialize new instance variables.

(WebCore::CSSParser::currentLocation):
Update to include column information. Also, if we are on the first line
we may need to take into account a start column offset as well.

(WebCore::CSSParser::realLex):
When bumping the line number, reset the column offset for the next
line with the next character.

(WebCore::CSSParser::syntaxError):
(WebCore::CSSParser::logError):
Include column information.

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLineAndColumn):
Include column information.

  • css/StyleSheetContents.h:
  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::InlineStyleSheetOwner):
(WebCore::InlineStyleSheetOwner::createSheet):
Save and use column information later on.

  • dom/InlineStyleSheetOwner.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ensureSourceData):
Updated parser signature needs starting column and no longer has optional parameters.

Source/WebInspectorUI:

  • UserInterface/Views/ConsoleMessageImpl.js:

(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
Column numbers in console messages are also 1 based and should be adjusted.

LayoutTests:

Test errors in both external and inline CSS and Scripts to ensure they have
expected line:column information.

  • inspector-protocol/console/warnings-errors-expected.txt: Added.
  • inspector-protocol/console/warnings-errors.html: Added.
  • inspector-protocol/resources/errors.css: Added.
  • inspector-protocol/resources/errors.js: Added.
10:56 PM Changeset in webkit [181366] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix the GTK build.

  • html/HTMLVideoElement.idl: Work around gobject bindings generator limitation

by putting in a LANGUAGE_GOBJECT conditional.

10:30 PM Changeset in webkit [181365] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening on 10th Mar.

Mark smil-leak-foo tests, 3 tests of fast/css to failure.

  • platform/efl/TestExpectations:
9:08 PM Changeset in webkit [181364] by Antti Koivisto
  • 5 edits in trunk/Source/WebKit2

Add interface to delete disk cache entries
​https://bugs.webkit.org/show_bug.cgi?id=142546

Reviewed by Anders Carlsson.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::remove):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::remove):

Move deletion to a serial queue so we can't create large number of threads.

(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::Storage::dispatchHeaderWriteOperation):
(WebKit::NetworkCache::Storage::removeEntry): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::deleteQueue):

8:29 PM Changeset in webkit [181363] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

5 tests fail on Apple Mac WK2 performance bots
​https://bugs.webkit.org/show_bug.cgi?id=142485

Reviewed by Andreas Kling.

Only log errors in debug builds if SandboxExtension::createHandle() fails
so that performance tests don't fail because of it. Such error is not
fatal and is expected under certain circumstances. In particular,
SandboxExtension::createHandle() is sometimes called for non-existing
files (e.g. from NetworkResourceLoadParameters::encode()).

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::createHandle):

7:52 PM Changeset in webkit [181362] by Brent Fulgham
  • 2 edits in trunk/Tools

Regression(r181257): WTF_WorkQueue.Simple is flaky
​https://bugs.webkit.org/show_bug.cgi?id=142560

Unreviewed attempt to improve test stability.

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for

the WorkQueue a little later to redue flakiness.

7:36 PM Changeset in webkit [181361] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: console.error output broken, does not produce ObjectTree
​https://bugs.webkit.org/show_bug.cgi?id=142554

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-10
Reviewed by Timothy Hatcher.

  • UserInterface/Models/IssueMessage.js:

(WebInspector.IssueMessage):

  • UserInterface/Protocol/ConsoleObserver.js:

(WebInspector.ConsoleObserver.prototype.messageAdded):

7:34 PM Changeset in webkit [181360] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] 17 different JSC tests started to fail in DST
​https://bugs.webkit.org/show_bug.cgi?id=142531

Reviewed by Chris Dumez.

The stock 'GetTimeZoneInformation' call does not always match the actual Daylight
Savings calendar. This results in a period of time when these tests fail.

If available, we should take advantage of the new 'GetTimeZoneInformationForYear',
which accesses a dynamic calendar of DST dates, which is presumbably updated by
Microsoft from year-to-year.

  • wtf/DateMath.cpp:

(WTF::timeZoneInformationForYearFunction): New function to conditionally access
some Vista (and newer) functionality.
(WTF::calculateUTCOffset): Call new function (if available) to calculate proper UTC
time offset.

7:26 PM Changeset in webkit [181359] by mmaxfield@apple.com
  • 3 edits in trunk/Tools

Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
​https://bugs.webkit.org/show_bug.cgi?id=142555

Reviewed by Simon Fraser.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setDefaultsToConsistentValuesForTesting):

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

7:21 PM Changeset in webkit [181358] by Darin Adler
  • 28 edits in trunk

Some event handler fixes
​https://bugs.webkit.org/show_bug.cgi?id=142474

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::createInjectedScript): Call clearException.
I spotted the fact it was missing by auditing all the calls to JSC::call.

Source/WebCore:

  • bindings/scripts/CodeGenerator.pm:

(GenerateConditionalStringFromAttributeValue): Improved the algorithm here to
handle combinations of & and | in conditional expressions; that's coming up when
combining conditionals for includes in NavigatorContentUtils.idl.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddToImplIncludes): Removed the rudimentary attempt to split and merge
conditionals involving | here; instead we rely on the rules in the
GenerateConditionalStringFromAttributeValue to handle this.
(GenerateImplementation): Passed new "conditional" argument to JSValueToNative.
(GenerateParametersCheck): Pass "conditional" argument to AddToImplIncludes and
JSValueToNative.
(JSValueToNative): Changed to take "conditional" as an argument, since getting
it from the signature won't work for a method parameter.
(WriteData): Merge duplicates based on the result of the
GenerateConditionalStringFromAttributeValue function rather than on the values
passed into that function, since that function converts conditionals into a
canonical form and can make two strings equal that don't start out that way.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute): Added code to guarantee we won't make Objective-C bindings
for event handlers. We will rename EventListener to EventHandler in a
subsequent patch.

  • bindings/scripts/test/JS/JSTestInterface.cpp: Updated for a progression caused

by the better logic for conditional includes.

  • bindings/scripts/test/JS/JSTestObj.cpp: Updated for change to the test below.
  • bindings/scripts/test/TestObj.idl: Added test of an event handler attribute.
  • dom/Document.idl: Removed unneeded language #if around event handler

attributes. Removed all the commented out event handler attributes.
Sorted event handler attributes into a single section rather than separating
"standard" from "extensions". Sorted the conditional event handler attributes
into paragraphs at the bottom. We will probably make them all unconditional
in a subsequent patch.

  • dom/Element.idl: Removed unneeded language #if around event handler

attributes. Removed all the commented out event handler attributes.
Moved event handler attributes here from all derived element classes to
match the approach from the HTML standard. Also resorted the attributes
as in Document above.

  • html/HTMLBodyElement.idl: Removed unneeded language #if around event handler

attributes. Removed all the commented out event handler attributes.
Sorted event handler attributes into a single section rather than separating
"standard" from "overrides".

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::populateEventNameForAttributeLocalNameMap):
Added a few missing attribute names, and re-sorted a bit. Moved any from
element subclasses here.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseAttribute): Moved code to handle
oncomplete and oncompleteerror to Element and HTMLElement.

  • html/HTMLFormElement.idl: Ditto.
  • html/HTMLFrameSetElement.idl: Removed #if and resorted as above.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute): Moved code to handle
onsearch to HTMLElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Moved code to handle
all the event handler attributes to HTMLElement.
(WebCore::HTMLMediaElement::updateCaptionContainer): Removed a redundant
if statement I noticed while auditing all calls to JSC::call.
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot): Added clearException.
I noticed this was missing because a flawed earlier version of my patch was
causing the script to fail, leaving an exception behind that caused an
assertion later. So I audited all calls to JSC::call looking for this mistake.

  • html/HTMLMediaElement.idl: Moved all the event handlers from here to

Element. Also changed everything possible to use Conditional instead of #if.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Added
clearException. Noticed it was missing while auditing all calls to JSC::call.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute): Moved event handler code to
HTMLElement.

  • html/HTMLVideoElement.idl: Moved event handler to Element.idl and use

Conditional instead of #if.

  • page/DOMWindow.idl: Use Conditional instead of #if and tidy up the event

handlers section.

  • svg/svgattrs.in: Remove six unused attribute names. Presumably used in

some older scheme to implement event handlers but no longer used at all.

LayoutTests:

  • fast/dom/event-handler-attributes-expected.txt: Updated for new tests and to

expect more tests to pass.

  • fast/dom/event-handler-attributes.html: Added testing of event handlers on

non-HTML, non-SVG elements, and on SVG elements. Also removed
webkitpresentationmodechanged from the test, for now at least.

  • fast/events/event-attribute-expected.txt: Updated to expect more tests to pass.
6:01 PM Changeset in webkit [181357] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

5:59 PM Changeset in webkit [181356] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

5:54 PM Changeset in webkit [181355] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.15.13

New tag.

5:42 PM Changeset in webkit [181354] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.11

New tag.

5:33 PM Changeset in webkit [181353] by mmirman@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Functions should have initialization precedence over arguments.
​https://bugs.webkit.org/show_bug.cgi?id=142550
rdar://problem/19702564

Reviewed by Geoffrey Garen.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeCapturedVariable):

  • tests/stress/initialize_functions_after_arguments.js: Added.
4:55 PM WebKitGTK/2.8.x edited by clopez@igalia.com
(diff)
4:19 PM Changeset in webkit [181352] by Brent Fulgham
  • 9 edits
    2 adds in trunk

CSS scroll-snap-destination and scroll-snap-coordinate are not honoring position values
​https://bugs.webkit.org/show_bug.cgi?id=142411

Reviewed by Simon Fraser.

Source/WebCore:

Tested by css3/scroll-snap/scroll-snap-position-values.html.

Revise the CSSParser to recognize that scroll-snap-coordinates and scroll-snap-destination
may be specified as positions, therefore allowing 'top', 'bottom', and 'center' for the Y axis,
and 'left', 'right', and 'center' for the X axis.

Correct implementation to support calculated values for Scroll Snap Point markup. This required the
Scroll Snap Point-specific LengthRepeat class to change its internal representation from a CSSPrimitiveValue
to a regular CSSValue.

Add tests that these position labels, as well as combinations with percentages and pixel offsets
are parsed properly.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::scrollSnapDestination): Switch from 'percentageOrZoomAdjustedValue' to 'zoomAdjustedPixelValueForLength'
when working with Length values. This is necessary to allow calculated results to be based on the proper default
page dimensions.
(WebCore::scrollSnapPoints): Ditto.
(WebCore::scrollSnapCoordinates): Ditto.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseScrollSnapPositions): Consolidated code for dealing with snap point
positions.
(WebCore::CSSParser::parseScrollSnapDestination): Revise to call new helper function.
(WebCore::CSSParser::parseScrollSnapCoordinate): Ditto.
(WebCore::CSSParser::parseFillPositionX): Rename as parsePositionX.
(WebCore::CSSParser::parseFillPositionY): Rename as parsePositionY.
(WebCore::CSSParser::parseFillProperty): Update to call renamed parsePosition{X|Y} methods.
(WebCore::CSSParser::parseTransformOrigin): Ditto.
(WebCore::CSSParser::parsePerspectiveOrigin): Ditto.

  • css/CSSParser.h:
  • css/LengthRepeat.h: Revise class to use a CSSValue, rather than a CSSPrimitiveValue, so that we can represent

repeat values as calculations.

LayoutTests:

Add a test for <position> types in scroll snap operations. Also update the test expectations
for computed styles now that double-precision math is being used for calculated values.

  • css3/scroll-snap/scroll-snap-position-values-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-position-values.html: Added.
  • css3/scroll-snap/scroll-snap-property-computed-style-expected.txt: Updated
  • css3/scroll-snap/scroll-snap-property-computed-style.js: Updated
4:12 PM Changeset in webkit [181351] by enrica@apple.com
  • 4 edits
    2 adds in trunk

Add support for more emoji with variation.
​https://bugs.webkit.org/show_bug.cgi?id=142548
rdar://problem/20105008

Reviewed by Tim Horton.

Source/WebCore:

Update ICU rules to support new emoji with variation.

Test: editing/selection/extend-by-character-007.html

  • platform/text/TextBreakIterator.cpp:

(WebCore::cursorMovementIterator):

LayoutTests:

  • editing/selection/extend-by-character-007-expected.txt: Added.
  • editing/selection/extend-by-character-007.html: Added.
3:59 PM Changeset in webkit [181350] by akling@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Eden collections should trigger sweep of MarkedBlocks containing new objects.
<​https://webkit.org/b/142538>

Reviewed by Geoffrey Garen.

Take a snapshot of all MarkedBlocks with new objects as part of Eden collections,
and append that to the IncrementalSweeper's working set.

This ensures that we run destructors for objects that were discovered to be garbage during
Eden collections, instead of delaying their teardown until the next full collection,
or the next allocation cycle for their block.

  • heap/Heap.cpp:

(JSC::Heap::snapshotMarkedSpace): For Eden collections, snapshot the list of MarkedBlocks
that contain new objects, since those are the only ones we're interested in.
Also use Vector::resizeToFit() to allocate the snapshot for full collections, since we know
the final size we need up front.

(JSC::Heap::notifyIncrementalSweeper): For Eden collections, tell the IncrementalSweeper
to add the block snapshot (taken earlier) to its existing set of blocks instead of replacing
it entirely. This allows Eden collections and incremental sweeping to occur interleaved with
each other without missing destruction opportunities.

  • heap/IncrementalSweeper.h:
  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::sweepNextBlock): Change the way we iterate over the sweeper's
work list: instead of keeping an index for the next block, just pop from the end of the list.
This allows us to add new blocks and deduplicate the list without disturbing iteration.

(JSC::IncrementalSweeper::startSweeping): Make this take a Vector<MarkedBlock>&& so we can
pass ownership of this Vector efficiently from Heap to IncrementalSweeper.

(JSC::IncrementalSweeper::addBlocksAndContinueSweeping): Added. This is used by Eden
collections to add a set of MarkedBlocks with new objects to the sweeper's existing
working set and kick the timer.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::blocksWithNewObjects): Expose the list of MarkedBlocks with new objects.

3:53 PM March 2015 Meeting edited by bfulgham@webkit.org
(diff)
3:39 PM Changeset in webkit [181349] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Fix warning about loading insecure content from secure webkit.org/blog
​https://bugs.webkit.org/show_bug.cgi?id=142545

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-10
Reviewed by Mark Rowe.

  • blog/wp-content/themes/webkit/footer.php:

Use an "https" URL for the subresource, instead of "http".

2:54 PM Changeset in webkit [181348] by commit-queue@webkit.org
  • 30 edits in trunk

Use unsigned for HashSet size.
​https://bugs.webkit.org/show_bug.cgi?id=142518

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-03-10
Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • dfg/DFGAvailabilityMap.cpp:

(JSC::DFG::AvailabilityMap::prune):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • heap/MarkedBlockSet.h:

(JSC::MarkedBlockSet::remove):

  • runtime/WeakMapData.h:

Source/WebCore:

  • Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::checkForDuplicate):
(WebCore::CloneSerializer::writeConstantPoolIndex):

  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::~ScriptRunner):

  • loader/ResourceLoadScheduler.h:
  • platform/graphics/Font.cpp:

(WebCore::Font::systemFallbackFontForCharacter):

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontDataIfNeeded):
(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCache.h:
  • platform/graphics/freetype/FontCacheFreeType.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::FontCache::getSystemFontFallbackForCharacters):
(WebCore::FontCache::systemFallbackForCharacters):
(WebCore::FontCache::similarFont):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::shouldAutoActivateFontIfNeeded):
(WebCore::FontCache::systemFallbackForCharacters):
(WebCore::FontCache::similarFont):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::computeOverflowFromCells):

Source/WTF:

  • wtf/HashCountedSet.h:

(WTF::Traits>::size):
(WTF::Traits>::capacity):

  • wtf/HashMap.h:

(WTF::X>::size):
(WTF::X>::capacity):

  • wtf/HashSet.h:

(WTF::V>::size):
(WTF::V>::capacity):

  • wtf/HashTable.h:

(WTF::HashTable::Stats::recordCollisionAtCount):
(WTF::HashTable::Stats::dumpStats):
(WTF::HashTable::size):
(WTF::HashTable::capacity):
(WTF::KeyTraits>::deallocateTable):
(WTF::KeyTraits>::checkTableConsistencyExceptSize):

  • wtf/HashTraits.h:
  • wtf/ListHashSet.h:

(WTF::U>::size):
(WTF::U>::capacity):

Tools:

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::testInitialCapacity):

  • TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

(TestWebKitAPI::TEST):

2:26 PM Changeset in webkit [181347] by eric.carlson@apple.com
  • 6 edits in trunk

[Mac] Refactor media controls code
​https://bugs.webkit.org/show_bug.cgi?id=142455

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, updated tests/media/hls/video-controls-live-stream-expected.txt.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller):
(Controller.prototype.addVideoListeners):
(Controller.prototype.removeVideoListeners):
(Controller.prototype.createControls):
(Controller.prototype.setControlsType):
(Controller.prototype.configureInlineControls):
(Controller.prototype.updateStatusDisplay):
(Controller.prototype.handlePanelMouseDown):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.handleOptimizedFullscreenButtonClicked):
(Controller.prototype.currentPlaybackTargetIsWireless):
(Controller.prototype.updateShouldListenForPlaybackTargetAvailabilityEvent):
(Controller.prototype.updateWirelessPlaybackStatus):
(Controller.prototype.updateWirelessTargetAvailable):
(Controller.prototype.handleWirelessPickerButtonClicked):
(Controller.prototype.handleWirelessPlaybackChange):
(Controller.prototype.handleWirelessTargetAvailableChange):
(Controller.prototype.setShouldListenForPlaybackTargetAvailabilityEvent):

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS):
(ControllerIOS.prototype.addVideoListeners):
(ControllerIOS.prototype.removeVideoListeners):
(ControllerIOS.prototype.createControls):
(ControllerIOS.prototype.setControlsType):
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.handleWirelessPickerButtonTouchEnd):
(ControllerIOS.prototype.updateShouldListenForPlaybackTargetAvailabilityEvent):
(ControllerIOS.prototype.updateStatusDisplay):
(ControllerIOS.prototype.setShouldListenForPlaybackTargetAvailabilityEvent):
(ControllerIOS.prototype.currentPlaybackTargetIsWireless): Deleted.
(ControllerIOS.prototype.updateWirelessPlaybackStatus): Deleted.
(ControllerIOS.prototype.updateWirelessTargetAvailable): Deleted.
(ControllerIOS.prototype.hideControls): Deleted.
(ControllerIOS.prototype.handleWirelessPlaybackChange): Deleted.
(ControllerIOS.prototype.handleWirelessTargetAvailableChange): Deleted.

LayoutTests:

  • platform/mac/http/tests/media/hls/video-controls-live-stream-expected.txt:
2:17 PM Changeset in webkit [181346] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Add WebKitSystemInterface for iOS 8.2
​https://bugs.webkit.org/show_bug.cgi?id=142505

Rubber-stamped by Anders Carlsson.

Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
copy-webkitlibraries-to-product-directory in r181286.

  • Scripts/copy-webkitlibraries-to-product-directory:
1:39 PM Changeset in webkit [181345] by commit-queue@webkit.org
  • 29 edits in trunk/Source

Remove PassRefPtr from svg/properties classes.
​https://bugs.webkit.org/show_bug.cgi?id=142063.

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-03-10
Reviewed by Darin Adler.
Source/WebCore:

Remove PassRefPtr from svg/properties classes. All the return types and
the local variables should be RefPtr. If we are sure the pointer can't
be null, we use Ref instead.

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):
(WebCore::SVGMarkerElement::orientTypeAnimated):

  • svg/SVGMarkerElement.h:
  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::animatedPathSegList):

  • svg/SVGPathElement.h:
  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::SVGPolyElement::points):
(WebCore::SVGPolyElement::animatedPoints):

  • svg/SVGPolyElement.h:
  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::textLengthAnimated):

  • svg/SVGTextContentElement.h:
  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::transform):
(WebCore::SVGViewSpec::viewBoxAnimated):
(WebCore::SVGViewSpec::preserveAspectRatioAnimated):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):

  • svg/SVGViewSpec.h:
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:

(WebCore::SVGAnimatedEnumerationPropertyTearOff::create):

  • svg/properties/SVGAnimatedListPropertyTearOff.h:

(WebCore::SVGAnimatedListPropertyTearOff::create):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):

  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):

  • svg/properties/SVGAnimatedPropertyMacros.h:
  • svg/properties/SVGAnimatedPropertyTearOff.h:

(WebCore::SVGAnimatedPropertyTearOff::create):

  • svg/properties/SVGAnimatedStaticPropertyTearOff.h:

(WebCore::SVGAnimatedStaticPropertyTearOff::create):

  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:

(WebCore::SVGAnimatedTransformListPropertyTearOff::create):

  • svg/properties/SVGListProperty.h:

(WebCore::SVGListProperty::initializeValuesAndWrappers):
(WebCore::SVGListProperty::getItemValuesAndWrappers):
(WebCore::SVGListProperty::insertItemBeforeValuesAndWrappers):
(WebCore::SVGListProperty::replaceItemValuesAndWrappers):
(WebCore::SVGListProperty::removeItemValuesAndWrappers):
(WebCore::SVGListProperty::appendItemValuesAndWrappers):

  • svg/properties/SVGListPropertyTearOff.h:

(WebCore::SVGListPropertyTearOff::create):
(WebCore::SVGListPropertyTearOff::initialize):
(WebCore::SVGListPropertyTearOff::getItem):
(WebCore::SVGListPropertyTearOff::insertItemBefore):
(WebCore::SVGListPropertyTearOff::replaceItem):
(WebCore::SVGListPropertyTearOff::removeItem):
(WebCore::SVGListPropertyTearOff::appendItem):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::getItem):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::removeItem):

  • svg/properties/SVGPathSegListPropertyTearOff.h:

(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):

  • svg/properties/SVGPropertyInfo.h:
  • svg/properties/SVGStaticListPropertyTearOff.h:

(WebCore::SVGStaticListPropertyTearOff::create):

  • svg/properties/SVGStaticPropertyTearOff.h:

(WebCore::SVGStaticPropertyTearOff::create):

  • svg/properties/SVGTransformListPropertyTearOff.h:

(WebCore::SVGTransformListPropertyTearOff::create):
(WebCore::SVGTransformListPropertyTearOff::createSVGTransformFromMatrix):
(WebCore::SVGTransformListPropertyTearOff::consolidate):

Source/WTF:

  • wtf/Ref.h:

(WTF::static_reference_cast): Add a stat_cast function to Ref<>.

1:36 PM Changeset in webkit [181344] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.15-branch/Source/WebCore

Merged r181123. rdar://problem/20109108

1:18 PM Changeset in webkit [181343] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Use std::numeric_limits<unsigned>::max() instead of (unsigned)-1.
<​https://webkit.org/b/142539>

Reviewed by Benjamin Poulain.

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITInlines.h:

(JSC::JIT::emitNakedCall):
(JSC::JIT::addSlowCase):
(JSC::JIT::addJump):
(JSC::JIT::emitJumpSlowToHot):
(JSC::JIT::emitGetVirtualRegister):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

  • yarr/Yarr.h:
1:11 PM Changeset in webkit [181342] by timothy_horton@apple.com
  • 8 edits in trunk/Source

Fix the build

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

  • History/WebHistory.mm:

(-[WebHistoryPrivate loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

  • Shared/Downloads/ios/DownloadIOS.mm:

(WebKit::Download::startWithHandle):

  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:

(-[WKCustomProtocolLoader initWithCustomProtocolManagerProxy:customProtocolID:request:connection:]):

1:09 PM Changeset in webkit [181341] by benjamin@webkit.org
  • 4 edits in trunk

Extend URL filter's Term definition to support groups/subpatterns
​https://bugs.webkit.org/show_bug.cgi?id=142519

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-03-10
Reviewed by Alex Christensen.

Source/WebCore:

Pretty simple extension: Term is extended to support holding
a Vector of Term. The quantifier of the Term applies to its
Vector of term as a whole.

To avoid exposing too much internal in the API of Term, I moved
graph generation from GraphBuilder to Term.

Sinking a CharacterSet works as usual. Sinking a Group is done
by sinking each of its Terms one by one and then apply the quantifier
on the whole subgraph. This is done by recursively calling into
Term::generateGraph().

Since groups could be nested, the groups make a stack with the latest
open group on top.
When sinking a floating Term, it is sunk to the latest open group. If there is no open
group, we use the prefix tree and sink the whole subpattern to the graph.

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::extendGroupSubpattern):
(WebCore::ContentExtensions::Term::generateGraph):
(WebCore::ContentExtensions::Term::operator==):
(WebCore::ContentExtensions::Term::hash):
(WebCore::ContentExtensions::Term::isUniversalTransition):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
(WebCore::ContentExtensions::Term::destroy):
(WebCore::ContentExtensions::Term::Group::operator==):
(WebCore::ContentExtensions::Term::Group::hash):
(WebCore::ContentExtensions::GraphBuilder::finalize):
(WebCore::ContentExtensions::GraphBuilder::atomParenthesesSubpatternBegin):
(WebCore::ContentExtensions::GraphBuilder::atomParenthesesEnd):
(WebCore::ContentExtensions::GraphBuilder::sinkFloatingTermIfNecessary):
(WebCore::ContentExtensions::Term::quantifier): Deleted.
(WebCore::ContentExtensions::Term::visitSimpleTransitions): Deleted.
(WebCore::ContentExtensions::GraphBuilder::addTransitions): Deleted.
(WebCore::ContentExtensions::GraphBuilder::sinkFloatingTerm): Deleted.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testURL):

12:58 PM Changeset in webkit [181340] by bshafiei@apple.com
  • 2 edits in tags/Safari-600.5.9.1/Source/WebCore

Merged r179958. rdar://problem/20096968

12:57 PM Changeset in webkit [181339] by bshafiei@apple.com
  • 2 edits in tags/Safari-600.5.9.1/Source/WebCore

Merged r179895. rdar://problem/20096968

12:56 PM Changeset in webkit [181338] by bshafiei@apple.com
  • 2 edits in tags/Safari-600.5.9.1/Source/WebCore

Merged r179880. rdar://problem/20096968

12:51 PM Changeset in webkit [181337] by bshafiei@apple.com
  • 5 edits in tags/Safari-600.5.9.1/Source

Versioning.

12:48 PM Changeset in webkit [181336] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.9.1

New tag.

12:36 PM Changeset in webkit [181335] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Fix the Mac build with a newer compiler

  • Plugins/WebPluginController.mm:

(WebKit_TSUpdateCheck_alertDidEnd_returnCode_contextInfo_):
(WebKit_NSAlert_beginSheetModalForWindow_modalDelegate_didEndSelector_contextInfo_):

12:29 PM Changeset in webkit [181334] by mark.lam@apple.com
  • 7 edits in trunk/Source

[Win] JSC Build Warnings Need to be Resolved.
<​https://webkit.org/b/142366>

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

Applied some benign changes to make the MSVC compiler happy.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillJSValue):

  • runtime/BasicBlockLocation.cpp:

(JSC::BasicBlockLocation::getExecutedRanges):

  • runtime/ControlFlowProfiler.cpp:

(JSC::ControlFlowProfiler::hasBasicBlockAtTextOffsetBeenExecuted):

Source/WTF:

  • wtf/Compiler.h:
  • MSVC also does not have the CONSIDERS_UNREACHABLE_CODE quirk.
12:13 PM Changeset in webkit [181333] by Yusuke Suzuki
  • 10 edits
    6 adds in trunk

Upgrade Map, Set and WeakMap constructor interface
​https://bugs.webkit.org/show_bug.cgi?id=142348

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

In the latest ES6 spec, Map and Set constructors take initialization data sets
as iterable value. And iterate it and add the values into the constructed one.

This is breaking change because the old constructor interface is
already shipped in Safari 8.

  • runtime/MapConstructor.cpp:

(JSC::callMap):
(JSC::constructMap):
(JSC::MapConstructor::getCallData):

  • runtime/SetConstructor.cpp:

(JSC::callSet):
(JSC::constructSet):

  • runtime/WeakMapConstructor.cpp:

(JSC::callWeakMap):
(JSC::constructWeakMap):
(JSC::WeakMapConstructor::getCallData):

  • tests/stress/map-constructor-adder.js: Added.
  • tests/stress/map-constructor.js: Added.

(testCallTypeError):
(testTypeError):
(for):

  • tests/stress/set-constructor-adder.js: Added.

(Set.prototype.add):

  • tests/stress/set-constructor.js: Added.

(for):

  • tests/stress/weak-map-constructor-adder.js: Added.
  • tests/stress/weak-map-constructor.js: Added.

(testCallTypeError):
(testTypeError):
(for):

LayoutTests:

Constructor semantics is changed.

  • js/basic-map-expected.txt:
  • js/basic-set-expected.txt:
  • js/dom/basic-weakmap-expected.txt:
  • js/script-tests/basic-map.js:
  • js/script-tests/basic-set.js:

(set new):

12:04 PM Changeset in webkit [181332] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Adjustments to media control fonts.
​https://bugs.webkit.org/show_bug.cgi?id=142509.
<rdar://problem/20085228>
Reviewed by Darin Adler.
Use system font for controls. Adjust surrounding divs accordingly.
Apply subpixel antialiasing to all media control text.

  • Modules/mediacontrols/mediaControlsApple.css:

(::-webkit-media-controls):
(audio::-webkit-media-controls-closed-captions-container .list):
(audio::-webkit-media-controls-status-display):
(audio::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display.five-digit-time):
(audio::-webkit-media-controls-current-time-display.five-digit-time):
(audio::-webkit-media-controls-time-remaining-display.six-digit-time):
(audio::-webkit-media-controls-current-time-display.six-digit-time):

11:47 AM Changeset in webkit [181331] by saambarati1@gmail.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Destructuring function parameters should show type information
​https://bugs.webkit.org/show_bug.cgi?id=142233

Reviewed by Joseph Pecoraro.

JSC supports a function's formal parameter being a destructuring pattern,
and so should the type profiler in the Inspector. This was just an oversight
not to have this in bug 141215.

This patch also does a bit of refactoring to not have duplicate code
that traverses AST nodes in TypeTokenAnnotator and ScriptSyntaxTree.
Before, both of these classes were responsible for traversing the AST
in an identical way, this is bad. Now, ScriptSyntaxTree contains the
canonical implementation of how the AST should be traversed and which
AST nodes should be collected for type profiling. ScriptSyntaxTree will
pass this information back to TypeTokenAnnotator.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype._insertTypeToken):
(WebInspector.TypeTokenAnnotator.prototype._insertTypeTokensForEachNode): Deleted.

  • UserInterface/Models/ScriptSyntaxTree.js:

(WebInspector.ScriptSyntaxTree.prototype.):
(WebInspector.ScriptSyntaxTree.prototype.updateTypes):
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
(WebInspector.ScriptSyntaxTree.prototype.gatherIdentifiersInVariableDeclaration): Deleted.

11:17 AM Changeset in webkit [181330] by rgabor@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Too large plugins are crashing.
​https://bugs.webkit.org/show_bug.cgi?id=139856

Reviewed by Darin Adler.

Add layout test to cover this crash.

  • plugins/large-plugin-crash-expected.txt: Added.
  • plugins/large-plugin-crash.html: Added.
11:00 AM Changeset in webkit [181329] by ggaren@apple.com
  • 12 edits in trunk/Source

bmalloc: tryFastMalloc shouldn't crash
​https://bugs.webkit.org/show_bug.cgi?id=142443

Reviewed by Sam Weinig.

Rolling back in r181307 with a check for whether bmalloc is enabled, to
avoid crashes when running with ASan and GuardMalloc.

Source/bmalloc:

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::tryAllocate):

  • bmalloc/Allocator.h:
  • bmalloc/Cache.cpp:

(bmalloc::Cache::tryAllocateSlowCaseNullCache):

  • bmalloc/Cache.h:

(bmalloc::Cache::tryAllocate):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::tryAllocateXLarge):

  • bmalloc/Heap.h:
  • bmalloc/VMAllocate.h:

(bmalloc::tryVMAllocate):
(bmalloc::vmAllocate):

  • bmalloc/bmalloc.h:

(bmalloc::api::tryMalloc):
(bmalloc::api::realloc):
(bmalloc::api::free):

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastRealloc):
(WTF::fastAlignedMalloc):
(WTF::tryFastMalloc):
(WTF::tryFastRealloc): Deleted.

  • wtf/FastMalloc.h:
10:55 AM Changeset in webkit [181328] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed a crash in CertificateInfo::containsNonRootSHA1SignedCertificate when loading a non-HTTPS webapge.

Reviewed by Anders Carlsson.

  • platform/network/mac/CertificateInfoMac.mm:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate): Null-check the certificate chain.

9:31 AM Changeset in webkit [181327] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the build.

  • platform/spi/cocoa/SecuritySPI.h:
9:01 AM Changeset in webkit [181326] by commit-queue@webkit.org
  • 5 edits in trunk/Source

GCC: CRASH() should be annotated with NORETURN
​https://bugs.webkit.org/show_bug.cgi?id=142524

Patch by Michael Catanzaro <Michael Catanzaro> on 2015-03-10
Reviewed by Anders Carlsson.

Source/JavaScriptCore:

Don't return from a NORETURN function. This used to avoid a warning from GCC, but now it
causes one.

  • jsc.cpp:

Source/WTF:

Add COMPILER(GCC) to #ifdefs that already exist for Clang.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
8:16 AM Changeset in webkit [181325] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Merge TextFragmentIterator::findNextBreakablePosition() and TextFragmentIterator::findNextNonWhitespacePosition().
​https://bugs.webkit.org/show_bug.cgi?id=142344

Reviewed by Antti Koivisto.

This patch merges findNextBreakablePosition() and findNextNonWhitespacePosition() so that
the segment looping and position handling logic are no longer duplicated. It also unifies
the static next*() functions' signature.

No change in functionality.

  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::nextTextFragment):
(WebCore::SimpleLineLayout::nextBreakablePosition):
(WebCore::SimpleLineLayout::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::findNextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::findNextNonWhitespace): Deleted.
(WebCore::SimpleLineLayout::TextFragmentIterator::findNextNonWhitespacePosition): Deleted.

  • rendering/SimpleLineLayoutTextFragmentIterator.h:
8:13 AM March 2015 Meeting edited by jfernandez@igalia.com
(diff)
6:38 AM Changeset in webkit [181324] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Contents not shown when entering AC mode unless the window is resized
​https://bugs.webkit.org/show_bug.cgi?id=142347

Reviewed by Žan Doberšek.

The problem is once again that we are now creating the redirected
X window in realize method. When entering AC mode we resize the
redirected window to the drawing area size. Since the size hasn't
changed from the drawing area point of view, the web process is
not notified. The WebProcess always uses the window size, instead
of the root layer size, to make sure it's in sync, see the comment
in LayerTreeHostGtk::compositeLayersToContext(). So, we need to
enforce a resize when we change the size of the redirected window
when entering AC mode.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseEnterAcceleratedCompositingMode):

  • UIProcess/DrawingAreaProxyImpl.h:

(WebKit::DrawingAreaProxyImpl::forceResize):

6:26 AM Changeset in webkit [181323] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] GL_MAX_VARYING_FLOATS is not defined in OpenGL ES 2
​https://bugs.webkit.org/show_bug.cgi?id=142529

Reviewed by Žan Doberšek.

Do not use GL_MAX_VARYING_FLOATS when platform is GTK+ and using
OpenGL ES 2.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::checkVaryingsPacking):

6:23 AM Changeset in webkit [181322] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build with OpenGL ES 2 enabled.

Remove USE(OPENGL) ifdef from GLContext.cpp, since there's nothing
specific to OpenGL in that file, and everything depending on
configure options is already protected by USE(GLX) and USE(EGL)
ifdefs. This is causing linking issues when building with OpenGL
ES 2, because the header doesn't have the ifdef, and the cpp file
is not compiled leaving all the interface undefined.

Patch by José Dapena Paz <​jdapena@igalia.com> on 2015-03-10
Rubber-stamped by Carlos Garcia Campos.

  • platform/graphics/GLContext.cpp:
6:19 AM Changeset in webkit [181321] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Add a configure option to build with OpenGL ES 2
​https://bugs.webkit.org/show_bug.cgi?id=142498

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> and José Dapena Paz <​jdapena@igalia.com> on 2015-03-10
Reviewed by Martin Robinson.

.:

Add ENABLE_GLES2 option. It's disabled by default, but if passed
GLES2 is required and OpenGL is not even searched. Otherwise we
search for OpenGL as usual, using it only if present.

  • Source/cmake/OptionsGTK.cmake:

Source/WebCore:

Build GLES or GL specific files depending on the build options.

  • PlatformGTK.cmake:
3:11 AM March 2015 Meeting edited by rniwa@webkit.org
(diff)
3:10 AM March 2015 Meeting edited by rniwa@webkit.org
Added New HTML/DOM Features section as well as "ES6" as a topic; also … (diff)
2:21 AM Changeset in webkit [181320] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Shrink the CSSPropertyID enum type
​https://bugs.webkit.org/show_bug.cgi?id=142456

Reviewed by Sam Weinig.

Specify uint16_t as the base type for the CSSPropertyID enum.
This is enough to cover all of the CSS properties (429 at this moment,
with static_assert covering future changes). It halves the enum type size,
from 4 bytes to 2, reducing the size of various CSSPropertyID containers.

No new tests -- no change in behavior.

  • css/CSSPrimitiveValue.cpp:

(WebCore::propertyName): Remove the unnecessary propertyID < 0 check.

  • css/makeprop.pl:
1:47 AM Changeset in webkit [181319] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix bleeding debug test bots.
​https://webkit.org/b/142513>

Not reviewed.

The test needs to initialize WTF threading explicitly before using it.

  • API/tests/CompareAndSwapTest.cpp:

(testCompareAndSwap):

1:33 AM Changeset in webkit [181318] by Csaba Osztrogonác
  • 4 edits in trunk

[cmake] Handle unused parameter warnings as build errors except in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=142338

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/WebKitHelpers.cmake:

Source/WebKit2:

  • CMakeLists.txt:
12:34 AM Changeset in webkit [181317] by mitz@apple.com
  • 14 edits
    1 add in trunk/Source

Source/WebCore:
WebCore part of <rdar://problem/20086546> [Cocoa] Add an option to treat certificate chains with SHA1-signed certificates as insecure
​https://bugs.webkit.org/show_bug.cgi?id=142461

Reviewed by Sam Weinig.

  • WebCore.xcodeproj/project.pbxproj: Added reference to SecuritySPI.h and sorted the

spi/cocoa group.

  • platform/network/cf/CertificateInfo.h: Declared new member function

containsNonRootSHA1SignedCertificate.

  • platform/network/mac/CertificateInfoMac.mm:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate): Added. Checks if any but
the last certificate in the chain uses SHA-1 as its signature hash algorithm.

  • platform/network/curl/CertificateInfo.h:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate): Added notImplemented
implementation.

  • platform/network/soup/CertificateInfo.h:

(WebCore::CertificateInfo::containsNonRootSHA1SignedCertificate): Ditto.

  • platform/spi/cocoa/SecuritySPI.h: Added.

Source/WebKit2:
WebKit2 part of <rdar://problem/20086546> [Cocoa] Add an option to treat certificate chains with SHA1-signed certificates as insecure
​https://bugs.webkit.org/show_bug.cgi?id=142461

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): Initialize
webPageConfiguration.treatsSHA1SignedCertificatesAsInsecure from the WKWebViewConfiguration.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

Added _treatsSHA1SignedCertificatesAsInsecure ivar.
(-[WKWebViewConfiguration copyWithZone:]): Copy _treatsSHA1SignedCertificatesAsInsecure.
(-[WKWebViewConfiguration _treatsSHA1SignedCertificatesAsInsecure]): Added this getter.
(-[WKWebViewConfiguration _setTreatsSHA1SignedCertificatesAsInsecure:]): Added this setter.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Declared new

_treatsSHA1SignedCertificatesAsInsecure property.

  • UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didCommitLoad): Use new hasInsecureContent parameter to initialize
hasInsecureContent parameter in the uncommitted state.

  • UIProcess/PageLoadState.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize new m_treatsSHA1CertificatesAsInsecure
member variable from the WebPageConfiguration.
(WebKit::WebPageProxy::didCommitLoadForFrame): Pass true for the new hasInsecureContent to
PageLoadState::didCommitLoad if we are treating SHA1-signed certificates as insecure and
the certificate info contains a non-root SHA1-signed certificate.

  • UIProcess/WebPageProxy.h: Added m_treatsSHA1CertificatesAsInsecure member variable.
12:15 AM Changeset in webkit [181316] by achristensen@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[WinCairo] Unreviewed build fix.

Added directory containing config.h, like r181304.

Mar 9, 2015:

11:56 PM Changeset in webkit [181315] by mark.lam@apple.com
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

Yet another build fix for Windows.
​https://webkit.org/b/142513>

Reviewed by Alex Christensen.

Looks like MSVC requires the function be explicitly declared in a header file
in order for it to be linkable from another file in the same project. This is
strange, but it seems to make MSVC happy.

Also fixed a typo in testapi.vcxproj.filters.

  • API/tests/CompareAndSwapTest.cpp:
  • API/tests/CompareAndSwapTest.h: Added.
  • API/tests/testapi.c:
  • JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
  • JavaScriptCore.vcxproj/testapi/testapi.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
11:54 PM Changeset in webkit [181314] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Skip contentfiltering/block-after-add-data.html for now.
​https://bugs.webkit.org/show_bug.cgi?id=142526

11:50 PM Changeset in webkit [181313] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Unreviewed, rolling out r181307.
​https://bugs.webkit.org/show_bug.cgi?id=142525

Broke ASan tests (Requested by ap on #webkit).

Reverted changeset:

"bmalloc: tryFastMalloc shouldn't crash"
​https://bugs.webkit.org/show_bug.cgi?id=142443
​http://trac.webkit.org/changeset/181307

11:35 PM Changeset in webkit [181312] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.15-branch/Source

Versioning.

11:34 PM Changeset in webkit [181311] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

10:56 PM March 2015 Meeting edited by benjamin@webkit.org
(diff)
10:32 PM Changeset in webkit [181310] by Chris Dumez
  • 5 edits in trunk/Source

[iOS] Sweep all collected objects on critical memory pressure
​https://bugs.webkit.org/show_bug.cgi?id=142457
<rdar://problem/20044440>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

All fullSweep() API to IncrementalSweeper so that we can call it in the
memory pressure handler.

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::fullSweep):

  • heap/IncrementalSweeper.h:

(JSC::IncrementalSweeper::hasWork):

Source/WebCore:

Do a full sweep of objects marked for destruction on critical memory
pressure to free up memory.

  • platform/cocoa/MemoryPressureHandlerCocoa.mm:

(WebCore::MemoryPressureHandler::platformReleaseMemory):

10:24 PM March 2015 Meeting edited by benjamin@webkit.org
(diff)
9:56 PM March 2015 Meeting edited by benjamin@webkit.org
(diff)
9:41 PM Changeset in webkit [181309] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Another build fix for Windows.
​https://webkit.org/b/142513>

Not reviewed.

  • API/tests/CompareAndSwapTest.cpp:
  • Added JS_EXPORT_PRIVATE attribute.
9:21 PM Changeset in webkit [181308] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix for Windows after r181305.
​https://webkit.org/b/142513>

Reviewed by Alex Christensen.

Windows doesn't like pthreads anymore. Changed test to use WTF threading.

  • API/tests/CompareAndSwapTest.cpp:

(setBitThreadFunc):
(testCompareAndSwap):

9:10 PM Changeset in webkit [181307] by ggaren@apple.com
  • 8 edits in trunk/Source

bmalloc: tryFastMalloc shouldn't crash
​https://bugs.webkit.org/show_bug.cgi?id=142443

Reviewed by Darin Adler.

Source/bmalloc:

Added support for tryMalloc.

We assume that non-x-large allocations always succeed, and we crash
otherwise, since normal allocation failure will just cause the next
non-try allocation or internal metadata allocation to fail, and it's
hard and not really useful to keep limping along after that. But
extra-large allocations can meaningfully fail, and we can recover.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateXLarge):
(bmalloc::Heap::tryAllocateXLarge):

  • bmalloc/Heap.h: Added support for non-crashy x-large allocation.
  • bmalloc/VMAllocate.h:

(bmalloc::tryVMAllocate):
(bmalloc::vmAllocate): Added support for non-crashy VM allocation.

  • bmalloc/bmalloc.h:

(bmalloc::api::tryMalloc):
(bmalloc::api::realloc):
(bmalloc::api::free): Tried to clarify our behavior with some comments.
Unfortunately, calling what we do "malloc" is still not quite right, since
malloc returns null on failure and we don't.

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::fastMalloc):
(WTF::fastRealloc):
(WTF::fastAlignedMalloc): Don't check for null. bmalloc automatically
crashes on allocation failure, and we'd rather not pay for an extra check.

(WTF::tryFastMalloc): Added an opt-out API to return null rather than
crashing, since some clients need this.

(WTF::tryFastRealloc): Deleted. Unused.

  • wtf/FastMalloc.h:
8:25 PM March 2015 Meeting edited by yoav@yoav.ws
(diff)
8:01 PM Changeset in webkit [181306] by Joseph Pecoraro
  • 9 edits
    1 copy in trunk/Source/WebInspectorUI

Web Inspector: Inline Error / Warning message for Issues
​https://bugs.webkit.org/show_bug.cgi?id=142520

Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:

New strings and new files.

  • UserInterface/Controllers/IssueManager.js:

(WebInspector.IssueManager.prototype.issueWasAdded):

  • UserInterface/Models/IssueMessage.js:

(WebInspector.IssueMessage):
(WebInspector.IssueMessage.prototype.get columnNumber):

  • UserInterface/Protocol/ConsoleObserver.js:

(WebInspector.ConsoleObserver.prototype.messageAdded):
Correctly pass the column number into IssueMessage.

  • UserInterface/Models/LineWidget.js:

(WebInspector.LineWidget):
(WebInspector.LineWidget.prototype.get codeMirrorLineWidget):
(WebInspector.LineWidget.prototype.get widgetElement):
Create a new Model class for a LineWidget. The root element
should never change, but its children can be updated.

  • UserInterface/Views/SourceCodeTextEditor.css:

(.source-code.text-editor .CodeMirror-linewidget):
Override styles so that widgets can overlap line content.

(.source-code.text-editor > .CodeMirror .issue-widget):
(.source-code.text-editor > .CodeMirror .issue-widget.inline):
Float issue widgets to the right side of the editor.

(.source-code.text-editor > .CodeMirror .issue-widget > .arrow):
(.source-code.text-editor > .CodeMirror .issue-widget.inline > .arrow):
Pure CSS arrow for widgets on the same line as their issue.

(.source-code.text-editor > .CodeMirror .issue-widget > .icon):
(.source-code.text-editor > .CodeMirror .issue-widget > .icon.icon-warning):
(.source-code.text-editor > .CodeMirror .issue-widget > .icon.icon-error):
Issue icon styles for the different issue types.

(.source-code.text-editor > .CodeMirror .issue-widget.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning > .arrow):
(.source-code.text-editor > .CodeMirror .issue-widget.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error > .arrow):
Different colors for the different issue types.

(.source-code.text-editor > .CodeMirror .issue-widget > .text):
(.source-code.text-editor > .CodeMirror .issue-widget.inline > .text):
Text positioning when on the same line or when expanded.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._addIssue):
(WebInspector.SourceCodeTextEditor.prototype._iconClassNameForIssueLevel):
(WebInspector.SourceCodeTextEditor.prototype._updateIssueWidgetForIssues):
(WebInspector.SourceCodeTextEditor.prototype._isWidgetToggleable):
(WebInspector.SourceCodeTextEditor.prototype._handleWidgetClick):
Create widgets for issues.

(WebInspector.SourceCodeTextEditor.prototype._contentDidPopulate):
(WebInspector.SourceCodeTextEditor.prototype.textEditorUpdatedFormatting):
(WebInspector.SourceCodeTextEditor.prototype._clearWidgets):
(WebInspector.SourceCodeTextEditor.prototype._reinsertAllIssues):
Update all widgets in certain cases.

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype.addStyleClassToLine):
This assertion is known to happen for issues added to an editor
before the content has loaded.

(WebInspector.TextEditor.prototype.createWidgetForLine):
Create a widget for a line.

7:18 PM Changeset in webkit [181305] by mark.lam@apple.com
  • 7 edits
    1 add in trunk/Source

8-bit version of weakCompareAndSwap() can cause an infinite loop.
​https://webkit.org/b/142513>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a test that exercises the 8-bit CAS from multiple threads. The threads
will contend to set bits in a large array of bytes using the CAS function.

  • API/tests/CompareAndSwapTest.cpp: Added.

(Bitmap::Bitmap):
(Bitmap::numBits):
(Bitmap::clearAll):
(Bitmap::concurrentTestAndSet):
(setBitThreadFunc):
(testCompareAndSwap):

  • API/tests/testapi.c:

(main):

Source/WTF:

Presently, Bitmap::concurrentTestAndSet() uses the 8-bit version of
weakCompareAndSwap() (which compares and swaps an uint8_t value).
Bitmap::concurrentTestAndSet() has a loop that checks if a bit in the
byte of interest has been set. If not, it will call the 8-bit CAS
function to set the bit.

Under the covers, for ARM, the 8-bit CAS function actually works with a
32-bit CAS. The 8-bit CAS will first fetch the 32-bit value in memory
that should contain the 8-bit value, and check if it contains the
expected byte. If the value in memory doesn't have the expected byte,
it will return early to its caller. The expectation is that the caller
will reload the byte from memory and call the 8-bit CAS again.

Unfortunately, this code path that returns early does not have a
compiler fence. Without a compiler fence, the C++ compiler can
optimize away the reloading of the expected byte value, leaving it
unchanged. As a result, we'll have a infinite loop here that checks a
value that will never change, and the loop will not terminate until the
value changes.

The fix is to eliminate the early return check in the 8-bit CAS, and
have it always call down to the 32-bit CAS. The 32-bit CAS has a
compiler fence which will prevent this issue.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

7:00 PM Changeset in webkit [181304] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Win] testapi project is unable to find the 'config.h' file.

Rubberstamped by Mark Lam.

to the include path.

6:51 PM Changeset in webkit [181303] by Brent Fulgham
  • 4 edits in trunk/LayoutTests

[Win] Rebaseline tests afer r181292.

  • platform/win/TestExpectations:
  • platform/win/fast/forms/search-vertical-alignment-expected.txt:
  • platform/win/fast/forms/textfield-overflow-by-value-update-expected.txt:
6:38 PM Changeset in webkit [181302] by aestes@apple.com
  • 4 edits in trunk/Source/WebCore

[Content Filtering] Give ContentFilter subclasses private constructors, and make them fast-allocated and non-copyable
​https://bugs.webkit.org/show_bug.cgi?id=142515

Reviewed by Andreas Kling.

  • platform/cocoa/NetworkExtensionContentFilter.h:
  • platform/cocoa/ParentalControlsContentFilter.h:
  • testing/MockContentFilter.h:
6:24 PM Changeset in webkit [181301] by Chris Dumez
  • 9 edits in trunk

[CG] Have Canvas use the IOSurfacePool
​https://bugs.webkit.org/show_bug.cgi?id=142417
<rdar://problem/20044440>

Reviewed by Darin Adler.

PerformanceTests:

Lower the number of different canvas sizes from 1000 to 100 so that
the test does not require such a huge cache size. With 100, we now
get over 90% cache hit rate with the default IOSurfacePool size.

  • Canvas/reuse.html:

Source/WebCore:

Have ImageBufferDataCG use the IOSurfacePool so that Canvas can
benefit from it. I see a ~75% progression on Canvas/reuse.html
performance test on my Macbook Pro with 1000 different canvas
sizes and ~110% progression with 100 different canvas sizes.

I also see a ~65% cache hit rate on the mobile version of
cnn.com.

Note that ImageData calls CGContextClearRect() after calling
IOSurface::create() so recycling IOSurfaces in this case should
be safe.

Performance test: Canvas/reuse.html

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::baseTransform):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::copyNativeImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBuffer::toDataURL):

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::~ImageBufferData):
(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):
(WebCore::ImageBufferData::ImageBufferData): Deleted.

  • platform/graphics/cg/ImageBufferDataCG.h:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::surfaceFromPool):
(IOSurface::create):
(IOSurface::createFromSendRight):
(IOSurface::createFromImage):
(IOSurface::setContextSize):

6:00 PM Changeset in webkit [181300] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Assertion in ScrollController::processWheelEventForScrollSnapOnAxis when scrolling with mechanical wheel mouse
​https://bugs.webkit.org/show_bug.cgi?id=142517

Reviewed by Simon Fraser.

  • platform/cocoa/ScrollController.mm:

(WebCore::toWheelEventStatus): Recognize stateless mechanical wheel events.
(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): If a mechanical wheel event is processed while
considering scroll snap logic, end any snap animations and clean up.
(WebCore::ScrollController::updateScrollSnapPoints): Don't begin tracking scroll snap state if there is not
scroll snap point defined in the markup.

5:34 PM Changeset in webkit [181299] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.15.12

New tag.

5:32 PM Changeset in webkit [181298] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.10

New tag.

5:09 PM Changeset in webkit [181297] by akling@apple.com
  • 17 edits
    1 copy
    1 add in trunk/Source

Stale entries in WeakGCMaps are keeping tons of WeakBlocks alive unnecessarily.
<​https://webkit.org/b/142115>
<rdar://problem/19992268>

Reviewed by Geoffrey Garen.

Prune stale entries from WeakGCMaps as part of every full garbage collection.
This frees up tons of previously-stuck WeakBlocks that were only sitting around
with finalized handles waiting to die.

Note that WeakGCMaps register/unregister themselves with the GC heap in their
ctor/dtor, so creating one now requires passing the VM.

Average time spent in the PruningStaleEntriesFromWeakGCMaps GC phase appears
to be between 0.01ms and 0.3ms, though I've seen a few longer ones at ~1.2ms.
It seems somewhat excessive to do this on every Eden collection, so it's only
doing work in full collections for now.

Because the GC may now mutate WeakGCMap below object allocation, I've made it
so that the classic HashMap::add() optimization can't be used with WeakGCMap.
This caused intermittent test failures when originally landed due to having
an invalid iterator on the stack after add() inserted a new entry and we
proceeded to allocate the new object, triggering GC.

  • API/JSWeakObjectMapRefInternal.h:

(OpaqueJSWeakObjectMap::create):
(OpaqueJSWeakObjectMap::OpaqueJSWeakObjectMap):

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWrapperMap.mm:

(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap jsWrapperForObject:]): Pass VM to WeakGCMap constructor.

  • JavaScriptCore.xcodeproj/project.pbxproj: Add WeakGCMapInlines.h and make

it project-private so WebCore clients can access it.

  • heap/Heap.cpp:

(JSC::Heap::collect):
(JSC::Heap::pruneStaleEntriesFromWeakGCMaps): Added a new GC phase for pruning
stale entries from WeakGCMaps. This is only executed during full collections.

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::registerWeakGCMap):
(JSC::Heap::unregisterWeakGCMap): Added a mechanism for WeakGCMaps to register
themselves with the Heap and provide a pruning callback.

  • runtime/PrototypeMap.h:

(JSC::PrototypeMap::PrototypeMap):

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::add): Pass VM to WeakGCMap constructor.

  • runtime/JSCInlines.h: Add "WeakGCMapInlines.h"
  • runtime/JSGlobalObject.cpp: Include "WeakGCMapInlines.h" so this builds.
  • runtime/JSString.cpp:

(JSC::jsStringWithCacheSlowCase):

  • runtime/PrototypeMap.cpp:

(JSC::PrototypeMap::addPrototype):
(JSC::PrototypeMap::emptyObjectStructureForPrototype): Remove HashMap add()
optimization since it's not safe in the GC-managed WeakGCMap world.

  • runtime/VM.cpp:

(JSC::VM::VM): Pass VM to WeakGCMap constructor.

  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::set):
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::WeakGCMap): Deleted.
(JSC::WeakGCMap::gcMap): Deleted.
(JSC::WeakGCMap::gcMapIfNeeded): Deleted.

  • runtime/WeakGCMapInlines.h: Added.

(JSC::WeakGCMap::WeakGCMap):
(JSC::WeakGCMap::~WeakGCMap):
(JSC::WeakGCMap::pruneStaleEntries): Moved ctor, dtor and pruning callback
to WeakGCMapInlines.h to fix interdependent header issues. Removed code that
prunes WeakGCMap at certain growth milestones and instead rely on the GC
callback for housekeeping.

4:57 PM Changeset in webkit [181296] by bshafiei@apple.com
  • 6 edits in tags/Safari-601.1.21.1/Source

Merged patch for <rdar://problem/20080527>.

4:52 PM Changeset in webkit [181295] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.21.1/Source

Versioning.

4:49 PM Changeset in webkit [181294] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.21.1

New tag.

4:47 PM Changeset in webkit [181293] by rniwa@webkit.org
  • 18 edits
    6 adds in trunk

Support extends and super keywords
​https://bugs.webkit.org/show_bug.cgi?id=142200

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added the support for ES6 class syntax inheritance.

Added ConstructorKind as well as boolean flags indicating the constructor kind to
various classes in UnlinkedCodeBlock as well as AST nodes.

Each method stores the associated class as its homeObjectPrivateName. This value is used to
make super calls.

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::ExecutableInfo::ExecutableInfo):
(JSC::UnlinkedFunctionExecutable::constructorKindIsDerived): Added.
(JSC::UnlinkedCodeBlock::constructorKindIsDerived): Added.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator): Don't emit op_create_this in a derived class
as the object is allocated by the highest base class's constructor. Also set "this" to null
and store the original value in m_newTargetRegister. "this" is supposed to be in TDZ but
that will be implemented in a separate patch.
(JSC::BytecodeGenerator::emitReturn): Allow "undefined" to be returned from a derived class.
In a derived class's constructor, not returning "undefined" or an object results in a type
error instead of "this" being returned.
(JSC::BytecodeGenerator::emitThrowTypeError): Added.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::constructorKindIsDerived): Added.
(JSC::BytecodeGenerator::newTarget): Added.

  • bytecompiler/NodesCodegen.cpp:

(JSC::SuperNode::emitBytecode): Added. Emits the code to obtain the callee's parent class.
(JSC::emitSuperBaseForCallee): Added. Emits the code to obtain the parent class's prototype.
(JSC::emitPutHomeObject): Added.
(JSC::PropertyListNode::emitBytecode): Stores the home object when adding methods.
(JSC::PropertyListNode::emitPutConstantProperty): Ditto.
(JSC::BracketAccessorNode::emitBytecode): Added the support for superfoo.
(JSC::DotAccessorNode::emitBytecode): Added the support for super.foo.
(JSC::FunctionCallValueNode::emitBytecode): Added the support for super().
(JSC::FunctionCallBracketNode::emitBytecode): Added the support for superfoo().
(JSC::FunctionCallDotNode::emitBytecode): Added the support for super.foo().
(JSC::DeleteBracketNode::emitBytecode): Forbid "delete super.foo".
(JSC::DeleteDotNode::emitBytecode): Forbid "delete superfoo".
(JSC::ClassExprNode::emitBytecode): Added the support for "classHeritage". This is the main
logic for inheritance. When a class B inherits from a class A, set B.proto to A and set
B.prototype.proto to A.prototype. Throw exceptions when either A or A.proto is not
an object.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::superExpr): Added.

  • parser/NodeConstructors.h:

(JSC::SuperNode::SuperNode): Added.

  • parser/Nodes.cpp:

(JSC::FunctionBodyNode::FunctionBodyNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isSuperNode):
(JSC::PropertyNode::type):
(JSC::PropertyNode::needsSuperBinding):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo): Throw a parser error if super() is used outside
of class constructors.
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass): ConstructorKind is "derived" if and only if the parent
class is specified in the declaration / expression.
(JSC::Parser<LexerType>::parseGetterSetter):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression): Added the support for "super()", "super.foo",
and "superfoo". Throw a semantic error if "super" appears by itself.

  • parser/Parser.h:

(JSC::Scope::Scope): Added m_hasDirectSuper. This variable keeps track of the use of "super()"
so that parseFunctionInfo can spit an error if it's used outside of class constructors.
(JSC::Scope::hasDirectSuper): Added.
(JSC::Scope::setHasDirectSuper): Added.

  • parser/ParserModes.h:

(JSC::ConstructorKind): Added.

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::superExpr): Added.

  • runtime/CommonIdentifiers.h: Added homeObjectPrivateName.
  • runtime/Executable.h:

(JSC::EvalExecutable::executableInfo):
(JSC::ProgramExecutable::executableInfo):

LayoutTests:

Added tests for "extends" and "super" keywords.

  • TestExpectations:
  • js/class-syntax-extends-expected.txt: Added.
  • js/class-syntax-extends.html: Added.
  • js/class-syntax-super-expected.txt: Added.
  • js/class-syntax-super.html: Added.
  • js/script-tests/class-syntax-extends.js: Added.
  • js/script-tests/class-syntax-super.js: Added.
4:43 PM Changeset in webkit [181292] by mmaxfield@apple.com
  • 8 edits
    4 adds in trunk

REGRESSION(r176978): Inline-blocks with overflowing contents have ascents that are too large
​https://bugs.webkit.org/show_bug.cgi?id=141783

Reviewed by David Hyatt.

Source/WebCore:

When we have an inline-block element, and we want to find its baseline (to lay out other
elements on the same line) we loop through the element's children and ask them what their
baselines are. The children use the location of the top of their last line to compute this
value. However, if the child has overflow-y, this might not be the correct calculation.

This behavior is in the spec: "The baseline of an 'inline-block' is the baseline of its last
line box in the normal flow, unless it has either no in-flow line boxes or if its 'overflow'
property has a computed value other than 'visible', in which case the baseline is the bottom
margin edge."

-- ​http://www.w3.org/TR/CSS21/visudet.html#leading

However, we believe that a better policy is, when overflow is not "visible," to place the
baseline at the bottom of the block if the contents overflowed in the Y direction, and to place
it at the bottom of the last line if the contents did not overflow in the Y direction. This is
partially consistent with previous behavior, and isn't too far from the spec to cause too many
breakages.

Test: fast/css/inline-block-tricky-baselines.html

fast/text/baseline-inline-block.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::inlineBlockBaseline):

LayoutTests:

Update expected results.

  • css3/flexbox/child-overflow-expected.html:
  • css3/flexbox/child-overflow.html:
  • fast/css/inline-block-tricky-baselines-expected.html: Added.
  • fast/css/inline-block-tricky-baselines.html: Added.
  • fast/forms/textfield-overflow-by-value-update-expected.txt:
  • fast/text/baseline-inline-block-expected.html: Added.
  • fast/text/baseline-inline-block.html: Added.
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
4:39 PM Changeset in webkit [181291] by aestes@apple.com
  • 13 edits
    3 copies
    16 adds in trunk

[Content Filtering] Add tests
​https://bugs.webkit.org/show_bug.cgi?id=142475

Reviewed by Andreas Kling.

Source/WebCore:

Added a mock content filter that can be configured by window.internals. A test can control whether the filter
is enabled, what to display when a page is blocked, at what point the allow/block decision is made, and what
decision to make.

Added tests to cover allowing and blocking content at each decision point.

Tests: contentfiltering/allow-after-add-data.html

contentfiltering/allow-after-finished-adding-data.html
contentfiltering/allow-after-response.html
contentfiltering/block-after-add-data.html
contentfiltering/block-after-finished-adding-data.html
contentfiltering/block-after-response.html

  • DerivedSources.make: Added MockContentFilterSettings.idl.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSMockContentFilterSettingsCustom.cpp: Added.

(WebCore::JSMockContentFilterSettings::decisionPoint): Returned the decision point's JSValue.
(WebCore::JSMockContentFilterSettings::setDecisionPoint): Set the decision point; threw an exception for invalid values.
(WebCore::JSMockContentFilterSettings::decision): Returned the decision's JSValue.
(WebCore::JSMockContentFilterSettings::setDecision): Set the decision; threw an exception for invalid values.

  • platform/ContentFilter.cpp:

(WebCore::ContentFilter::types): Renamed from contentFilterTypes.
(WebCore::ContentFilter::createIfNeeded):
(WebCore::contentFilterType): Deleted.
(WebCore::contentFilterTypes): Deleted.

  • platform/ContentFilter.h:

(WebCore::ContentFilter::addType): Used to register a new content filter type.
(WebCore::ContentFilter::type): Renamed from contentFilterType.

  • platform/cocoa/NetworkExtensionContentFilter.h: Moved definition of HAVE_NE_FILTER_SOURCE to here.
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Called MockContentFilterSettings::reset().
(WebCore::Internals::Internals): Called MockContentFilter::ensureInstalled().
(WebCore::Internals::mockContentFilterSettings): Returned a reference to MockContentFilterSettings::singleton().

  • testing/Internals.h:
  • testing/Internals.idl: Added attribute mockContentFilterSettings.
  • testing/MockContentFilter.cpp: Added.

(WebCore::MockContentFilter::ensureInstalled): Called MockContentFilter::addType().
(WebCore::MockContentFilter::canHandleResponse): Returned whether MockContentFilterSettings is enabled.
(WebCore::MockContentFilter::create): Returned a new MockContentFilter.
(WebCore::MockContentFilter::MockContentFilter): Called maybeDetermineStatus().
(WebCore::MockContentFilter::addData): Copied data into m_replacementData and called maybeDetermineStatus().
(WebCore::MockContentFilter::finishedAddingData): Called maybeDetermineStatus().
(WebCore::MockContentFilter::needsMoreData): Returned whether m_status equals NeedsMoreData.
(WebCore::MockContentFilter::didBlockData): Returned whether m_status equals Blocked.
(WebCore::MockContentFilter::getReplacementData): Returned a pointer to the start of m_replacementData.
(WebCore::MockContentFilter::unblockHandler): Returned an empty ContentFilterUnblockHandler.
(WebCore::MockContentFilter::maybeDetermineStatus): If m_status is NeedsMoreData and the current decision point
equals MockContentFilterSettings's decision point, set m_status according to MockContentFilterSettings's
decision. If m_status becomes Blocked, clear the original page data from m_replacementData and copy
MockContentFilterSettings's blocked string instead.

  • testing/MockContentFilter.h: Copied from Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.h.
  • testing/MockContentFilterSettings.cpp: Copied from Source/WebCore/platform/ContentFilter.h.

(WebCore::MockContentFilterSettings::singleton):
(WebCore::MockContentFilterSettings::reset): Reset settings to their initial values.
(WebCore::MockContentFilterSettings::MockContentFilterSettings):

  • testing/MockContentFilterSettings.h: Copied from Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.h.

(WebCore::MockContentFilterSettings::ref): Added an empty implementation to make the bindings think this is RefCounted.
(WebCore::MockContentFilterSettings::deref): Ditto.
(WebCore::MockContentFilterSettings::enabled):
(WebCore::MockContentFilterSettings::setEnabled):
(WebCore::MockContentFilterSettings::blockedString):
(WebCore::MockContentFilterSettings::setBlockedString):
(WebCore::MockContentFilterSettings::decisionPoint):
(WebCore::MockContentFilterSettings::setDecisionPoint):
(WebCore::MockContentFilterSettings::decision):
(WebCore::MockContentFilterSettings::setDecision):

  • testing/MockContentFilterSettings.idl: Copied from Source/WebCore/platform/ContentFilter.h.

LayoutTests:

  • contentfiltering/allow-after-add-data-expected.html: Added.
  • contentfiltering/allow-after-add-data.html: Added.
  • contentfiltering/allow-after-finished-adding-data-expected.html: Added.
  • contentfiltering/allow-after-finished-adding-data.html: Added.
  • contentfiltering/allow-after-response-expected.html: Added.
  • contentfiltering/allow-after-response.html: Added.
  • contentfiltering/block-after-add-data-expected.html: Added.
  • contentfiltering/block-after-add-data.html: Added.
  • contentfiltering/block-after-finished-adding-data-expected.html: Added.
  • contentfiltering/block-after-finished-adding-data.html: Added.
  • contentfiltering/block-after-response-expected.html: Added.
  • contentfiltering/block-after-response.html: Added.
4:30 PM Changeset in webkit [181290] by Alan Bujtas
  • 9 edits in trunk/Source/WebCore

Simple line layout should not be limited to RenderText.
​https://bugs.webkit.org/show_bug.cgi?id=142504

Reviewed by Antti Koivisto.

This is in transition to support br element.

No change in functionality.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRects):
(WebCore::RenderText::absoluteQuadsClippedToEllipsis):
(WebCore::RenderText::absoluteQuads):
(WebCore::RenderText::firstRunLocation):
(WebCore::RenderText::linesBoundingBox):
(WebCore::RenderText::caretMinOffset):
(WebCore::RenderText::caretMaxOffset):
(WebCore::RenderText::containsCaretOffset):

  • rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::segmentForRenderer):

  • rendering/SimpleLineLayoutFlowContents.h:
  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::computeBoundingBox):
(WebCore::SimpleLineLayout::computeFirstRunLocation):
(WebCore::SimpleLineLayout::collectAbsoluteRects):
(WebCore::SimpleLineLayout::collectAbsoluteQuads):
(WebCore::SimpleLineLayout::computeTextBoundingBox): Deleted.
(WebCore::SimpleLineLayout::computeTextFirstRunLocation): Deleted.
(WebCore::SimpleLineLayout::collectTextAbsoluteRects): Deleted.
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads): Deleted.

  • rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::findCaretMinimumOffset):
(WebCore::SimpleLineLayout::findCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsCaretOffset):
(WebCore::SimpleLineLayout::findTextCaretMinimumOffset): Deleted.
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset): Deleted.
(WebCore::SimpleLineLayout::containsTextCaretOffset): Deleted.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):

  • rendering/SimpleLineLayoutResolver.h:
  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):

3:51 PM Changeset in webkit [181289] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179958. rdar://problem/20096968

3:49 PM Changeset in webkit [181288] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179895. rdar://problem/20096968

3:48 PM Changeset in webkit [181287] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r179880. rdar://problem/20096968

3:34 PM Changeset in webkit [181286] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/WebKitLibraries

[iOS] Add WebKitSystemInterface for iOS 8.2
​https://bugs.webkit.org/show_bug.cgi?id=142505

Patch by Daniel Bates <​dabates@apple.com> on 2015-03-09
Reviewed by Andy Estes.

  • libWebKitSystemInterfaceIOSDevice8.2.a: Added.
  • libWebKitSystemInterfaceIOSSimulator8.2.a: Added.
3:09 PM Changeset in webkit [181285] by mmaxfield@apple.com
  • 5 edits in trunk

svg/custom/svg-fonts-without-missing-glyph.xhtml fails after fonts/font-fallback-prefers-pictographs.html
​https://bugs.webkit.org/show_bug.cgi?id=142470

Reviewed by Anders Carlsson.

Source/WebCore:

After each test, reset all internal settings.

Covered by svg/custom/svg-fonts-without-missing-glyph.xhtml

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

LayoutTests:

  • platform/mac/TestExpectations:
3:08 PM Changeset in webkit [181284] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r181268.
​https://bugs.webkit.org/show_bug.cgi?id=142508

Broke tests (Requested by ap on #webkit).

Reverted changeset:

"Simple line layout: Merge
TextFragmentIterator::findNextBreakablePosition() and
TextFragmentIterator::findNextNonWhitespacePosition()."
​https://bugs.webkit.org/show_bug.cgi?id=142344
​http://trac.webkit.org/changeset/181268

2:10 PM Changeset in webkit [181283] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

CSS JIT: add aliases between :nth-child()/:nth-last-child() and :first-child/:last-child
​https://bugs.webkit.org/show_bug.cgi?id=142472

Reviewed by Andreas Kling.

Source/WebCore:

The pseudo class :first-child has weaker tree marking than :nth-child(1).
This patch aliases :nth-child(1) to :first-child in the CSS JIT to take
advantage of that.

The strength of :last-child and :nth-last-child(1) are pretty much identical
but :last-child is a bit simpler so I changed it too. It is also easier
to handle both the same.

Tests: fast/selectors/nth-child-matching-first-on-root.html

fast/selectors/nth-child-matching-first.html
fast/selectors/nth-last-child-matching-first-on-root.html
fast/selectors/nth-last-child-matching-first.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addNthChildType):
(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

  • fast/selectors/nth-child-matching-first-expected.txt: Added.
  • fast/selectors/nth-child-matching-first-on-root-expected.txt: Added.
  • fast/selectors/nth-child-matching-first-on-root.html: Added.
  • fast/selectors/nth-child-matching-first.html: Added.
  • fast/selectors/nth-last-child-matching-first-expected.txt: Added.
  • fast/selectors/nth-last-child-matching-first-on-root-expected.txt: Added.
  • fast/selectors/nth-last-child-matching-first-on-root.html: Added.
  • fast/selectors/nth-last-child-matching-first.html: Added.
2:07 PM Changeset in webkit [181282] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Merge TrivialAtom and CharacterSet into a Term abstraction, prepare Term for composition
​https://bugs.webkit.org/show_bug.cgi?id=142429

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-03-09
Reviewed by Darin Adler.

This patch merges CharacterSet and Trivial atom into a new class: Term. A Term is
a combination of an Atom and one Quantifier.

With term being the basic block, we can use the PrefixTree for any construct,
greatly reducing the size of the NFA graph.

Term is built on top of an union holding the Atom storage. This is done in preparation
for more complicated Atoms like a disjunction.

Everything else is pretty much the same. BuildMode is gone since we use the prefix
tree for everything. FloatingAtomType is gone, a TrivialAtom is now represented
by a single character CharacterSet (or two for case insensitive).

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::parseRuleList):

  • contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::addRuleId):

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::~Term):
(WebCore::ContentExtensions::Term::isValid):
(WebCore::ContentExtensions::Term::addCharacter):
(WebCore::ContentExtensions::Term::quantify):
(WebCore::ContentExtensions::Term::quantifier):
(WebCore::ContentExtensions::Term::isUniversalTransition):
(WebCore::ContentExtensions::Term::visitSimpleTransitions):
(WebCore::ContentExtensions::Term::operator=):
(WebCore::ContentExtensions::Term::operator==):
(WebCore::ContentExtensions::Term::hash):
(WebCore::ContentExtensions::Term::isEmptyValue):
(WebCore::ContentExtensions::Term::isDeletedValue):
(WebCore::ContentExtensions::Term::destroy):
(WebCore::ContentExtensions::Term::CharacterSet::operator==):
(WebCore::ContentExtensions::Term::CharacterSet::hash):
(WebCore::ContentExtensions::TermHash::hash):
(WebCore::ContentExtensions::TermHash::equal):
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder):
(WebCore::ContentExtensions::GraphBuilder::finalize):
(WebCore::ContentExtensions::GraphBuilder::atomPatternCharacter):
(WebCore::ContentExtensions::GraphBuilder::atomBuiltInCharacterClass):
(WebCore::ContentExtensions::GraphBuilder::quantifyAtom):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassBegin):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassAtom):
(WebCore::ContentExtensions::GraphBuilder::atomCharacterClassRange):
(WebCore::ContentExtensions::GraphBuilder::addTransitions):
(WebCore::ContentExtensions::GraphBuilder::sinkFloatingTerm):
(WebCore::ContentExtensions::GraphBuilder::sinkFloatingTermIfNecessary):
(WebCore::ContentExtensions::URLFilterParser::URLFilterParser):
(WebCore::ContentExtensions::URLFilterParser::~URLFilterParser):
(WebCore::ContentExtensions::URLFilterParser::addPattern):
(WebCore::ContentExtensions::trivialAtomFromASCIICharacter): Deleted.
(WebCore::ContentExtensions::quantifyTrivialAtom): Deleted.
(WebCore::ContentExtensions::trivialAtomQuantifier): Deleted.
(WebCore::ContentExtensions::trivialAtomForNewlineClassIDBuiltin): Deleted.
(WebCore::ContentExtensions::GraphBuilder::sinkAtom): Deleted.
(WebCore::ContentExtensions::GraphBuilder::generateTransition): Deleted.
(WebCore::ContentExtensions::GraphBuilder::sinkTrivialAtom): Deleted.
(WebCore::ContentExtensions::GraphBuilder::sinkCharacterSet): Deleted.
(WebCore::ContentExtensions::GraphBuilder::sinkPendingAtomIfNecessary): Deleted.

  • contentextensions/URLFilterParser.h:
1:51 PM Changeset in webkit [181281] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(WEBGL) build after r180609
​https://bugs.webkit.org/show_bug.cgi?id=142057

Reviewed by Darin Adler.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::forceContextLost):

1:51 PM Changeset in webkit [181280] by jer.noble@apple.com
  • 3 edits in trunk/Tools

Add an option to run-webkit-tests to override the LayoutTests/ directory
​https://bugs.webkit.org/show_bug.cgi?id=142418

Reviewed by David Kilzer.

Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
directory. The base port will parse the options during initialization and store the override
location if present. layout_tests_dir() will return this overridden location if set.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.layout_tests_dir):

1:22 PM Changeset in webkit [181279] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Only call showControls if controls are hidden.
​https://bugs.webkit.org/show_bug.cgi?id=142496.
<rdar://problem/20083732>
Reviewed by Dean Jackson.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.controlsAreHidden):
Controls are hidden if the ‘show’ class name is not present,
not if the ‘hidden’ class name is.

12:58 PM Changeset in webkit [181278] by mmaxfield@apple.com
  • 3 edits
    3 adds
    3 deletes in trunk

Work around a Cocoa font parsing bug
​https://bugs.webkit.org/show_bug.cgi?id=142446
Source/WebCore:

<rdar://problem/20086223>

Reviewed by Simon Fraser.

Work around a bug in Cocoa regarding font parsing.

  • svg/SVGToOTFFontConversion.cpp:

LayoutTests:

Reviewed by Simon Fraser.

Adding a few extra tests for bits of SVG fonts that could use some more tests.

  • svg/fonts/resources/svg-font-general.svg: Updated and moved from svg-font-horiz-origin-font.svg
  • svg/fonts/svg-font-general.html: Updated and moved from svg-font-horiz-origin.html
  • svg/fonts/svg-font-general-expected.html: Updated and moved from svg-font-horiz-origin-expected.html
12:39 PM Changeset in webkit [181277] by mmaxfield@apple.com
  • 2 edits
    2 deletes in trunk/LayoutTests

[SVG -> OTF Converter] x-height cannot be specified
​https://bugs.webkit.org/show_bug.cgi?id=142465

Reviewed by Simon Fraser.

For all non-system fonts, OS X disregards the font's reported x-height. Therefore,
it is impossible to satisfy this test.

  • fast/css/ex-unit-with-no-x-height-expected.txt: Removed.
  • fast/css/ex-unit-with-no-x-height.html: Removed.
  • platform/mac/TestExpectations:
12:19 PM Changeset in webkit [181276] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ Gardening

​https://bugs.webkit.org/show_bug.cgi?id=142499

Patch by Marcos Chavarría Teijeiro <​chavarria1991@gmail.com> on 2015-03-09

  • platform/gtk/TestExpectations:
12:02 PM Changeset in webkit [181275] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[CMake] Enable WorkQueue tests for CMake ports
​https://bugs.webkit.org/show_bug.cgi?id=142473

Patch by Martin Robinson <​mrobinson@igalia.com> on 2015-03-09
Reviewed by Darin Adler.

  • TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to

the list of source files.

  • Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory

to the list of include directories for EFL.

12:01 PM Changeset in webkit [181274] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the build after r181153
​https://bugs.webkit.org/show_bug.cgi?id=142497

Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

11:58 AM Changeset in webkit [181273] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebKit

[iOS] Fix build when compiling with dead code stripping disabled
<​http://webkit.org/b/142467>

Reviewed by Simon Fraser.

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::save): Add missing method.

Source/WebKit/mac:

  • Configurations/WebKitLegacy.xcconfig:

(EXCLUDED_SOURCE_FILE_NAMES[sdk=iphone*]): Disable mig code
generation and compilation for out-of-process plugin support.
This was never used on iOS.

11:55 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
11:43 AM Changeset in webkit [181272] by ggaren@apple.com
  • 4 edits in trunk/Source/WebKit2

bmalloc: tryFastMalloc shouldn't crash
​https://bugs.webkit.org/show_bug.cgi?id=142443

Reviewed by Anders Carlsson.

Part 1: Stop using tryFastRealloc.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::resize): Deleted.

  • Shared/ShareableBitmap.h: Removed the resize function because it has

no clients.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::updateBackingStore): Changed to allocate a new
backing store instead of resizing the old one. This has three advantages:

(1) Might be more memory-efficient, since you don't have to keep the old
one around while allocating the new one.

(2) Avoids the overhead of realloc() copying the contents of the old
backing store even though we only want uninitialized memory.

(3) Makes resize failure consistent with initial allocation failure.
Previously, while initial allocation failure would set the backing store
to null, resize failure would keep the old wrong backing store and then
tell it not to paint. Now, resize failure also sets the backing store to
null.

10:49 AM Changeset in webkit [181271] by commit-queue@webkit.org
  • 4 edits
    3 moves in trunk/Source

[EFL] Move DispatchQueue to WTF
​https://bugs.webkit.org/show_bug.cgi?id=142493

Patch by Martin Robinson <​mrobinson@igalia.com> on 2015-03-09
Reviewed by Csaba Osztrogonác.

Source/WebKit2:

  • PlatformEfl.cmake: Remove DispatchQueue from the source list.

Source/WTF:

  • wtf/PlatformEfl.cmake: Add DispatchQueue to the source list.
  • wtf/efl/DispatchQueueEfl.cpp: Renamed from Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp.
  • wtf/efl/DispatchQueueEfl.h: Renamed from Source/WebKit2/Platform/efl/DispatchQueueEfl.h.
  • wtf/efl/DispatchQueueWorkItemEfl.h: Renamed from Source/WebKit2/Platform/efl/DispatchQueueWorkItemEfl.h.
10:35 AM Changeset in webkit [181270] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Re-add CSS property that was unintentionally removed in r180893
<rdar://problem/20083715>

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel):

10:19 AM Changeset in webkit [181269] by bshafiei@apple.com
  • 5 edits in branches/safari-600.5-branch/Source

Versioning.

10:09 AM Changeset in webkit [181268] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Merge TextFragmentIterator::findNextBreakablePosition() and TextFragmentIterator::findNextNonWhitespacePosition().
​https://bugs.webkit.org/show_bug.cgi?id=142344

Reviewed by Antti Koivisto.

This patch merges findNextBreakablePosition() and findNextNonWhitespacePosition() so that
the segment looping and position handling logic are no longer duplicated. It also unifies
the static next*() functions' signature.

No change in functionality.

  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::nextTextFragment):
(WebCore::SimpleLineLayout::nextBreakablePosition):
(WebCore::SimpleLineLayout::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::findNextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::findNextNonWhitespace): Deleted.
(WebCore::SimpleLineLayout::TextFragmentIterator::findNextNonWhitespacePosition): Deleted.

  • rendering/SimpleLineLayoutTextFragmentIterator.h:
7:27 AM Changeset in webkit [181267] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix timeouts on iOS Simulator layout tests

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
Simulator end after the first 50 tests time out. Some analysis
this past weekend shows that the 'Booted' status in the output
of xcrun simctl list is not sufficient (and watching the test
run shows that SpringBoard hasn't fully started to the point
where it's displaying icons on the home screen). The workaround
until we have a better fix is to add an arbitrary timeout to let
SpringBoard finish launching. In practice, 15 seconds is
probably enough, but 30 seconds should nearly always work.

6:57 AM Changeset in webkit [181266] by peavo@outlook.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself as a committer.

  • Scripts/webkitpy/common/config/contributors.json:
5:57 AM Changeset in webkit [181265] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure

  • TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

(TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
an expectation that will fail if we hit the race condition.
This test is inherently racy and will deadlock if the first job
for queue2 takes the mutex lock before the second job for
queue1.

4:36 AM Changeset in webkit [181264] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/Source/WebCore

ReadableStreamJSSource should use JSC::Strong UnspecifiedBoolType operator
​https://bugs.webkit.org/show_bug.cgi?id=142397

Reviewed by Benjamin Poulain.

No behavior change. Current tests cover the changes.

  • bindings/js/ReadableStreamJSSource.cpp:
  • bindings/js/ReadableStreamJSSource.h:
4:31 AM Changeset in webkit [181263] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening on 9th Mar.

Mark svg/text/select-textLength-spacingAndGlyphs-foo.html to failure.
Update new failling tests to existing bugs.

  • platform/efl/TestExpectations:
4:31 AM Changeset in webkit [181262] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/Source/WebCore

ReadableStream does not not need to pass itself as callback parameter
​https://bugs.webkit.org/show_bug.cgi?id=142399

Reviewed by Darin Adler.

No change in behavior.

  • Modules/streams/ReadableStream.h: Remove ReadableStream parameter from SuccessCallback definition.
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::ready): Capture JSReadableStream instance instead.
(WebCore::JSReadableStream::closed): Capture JSReadableStream instance instead.

3:16 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
12:28 AM Changeset in webkit [181261] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r181256 - Crash in WebCore::NotificationCenter::stop()
​https://bugs.webkit.org/show_bug.cgi?id=142444
<rdar://problem/20082520>

Reviewed by Darin Adler.

Rework the patch in r181219 so that we do not need a Ref<NotificationCenter> protector
in NotificationCenter::stop(). Instead, we put the client in a local variable and null
out m_client *before* calling NotificationClient::clearNotifications().

No new tests, already covered by:
http/tests/notifications/event-listener-crash.html

  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::stop):

Note: See TracTimeline for information about the timeline view.