Timeline
Jun 22, 2015:
- 11:47 PM Changeset in webkit [185865] by
-
- 1 copy in releases/WebKitGTK/webkit-2.9.3
WebKitGTK+ 2.9.3
- 11:45 PM Changeset in webkit [185864] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.3 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.9.3.
- 11:33 PM Changeset in webkit [185863] by
-
- 2 edits in trunk/Source/WTF
[WTF] Platform.h: use _ABI64 instead of _MIPS_SIM_ABI64 to determine MIPS N64
https://bugs.webkit.org/show_bug.cgi?id=145113
Patch by YunQiang Su <wzssyqa@gmail.com> on 2015-06-22
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h:
- 10:23 PM Changeset in webkit [185862] by
-
- 21 edits1 move3 adds in trunk
[EFL] Hyphenation is not supported
https://bugs.webkit.org/show_bug.cgi?id=89830
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsEfl.cmake: Added an option for LibHyphen.
Source/WebCore:
Share libHyphen backend of GTK port.
Rebased fast/text/hyphenate-*.html
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory): Deleted because of lack of functionality.
eina_file_ls returns full directory path so fnmatch fails to check dict file.
This patch reuse Posix implementation instead of EFL port specific function.
- platform/posix/FileSystemPOSIX.cpp: Ditto.
- platform/text/gtk/HyphenationLibHyphen.cpp: Moved to platform/text/hyphen
- platform/text/hyphen/HyphenationLibHyphen.cpp:
Renamed from Source/WebCore/platform/text/gtk/HyphenationLibHyphen.cpp.
(WebCore::scanTestDictionariesDirectoryIfNecessary):
Added PLATFORM guard and EFL implementation for the test directory
Tools:
- efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
LayoutTests:
Rebaseline expected results which is related to hyphenation.
- platform/efl/TestExpectations: Unskip hyphenate-locale.html
- platform/efl/fast/text/hyphenate-character-expected.png:
- platform/efl/fast/text/hyphenate-character-expected.txt:
- platform/efl/fast/text/hyphenate-first-word-expected.png:
- platform/efl/fast/text/hyphenate-first-word-expected.txt:
- platform/efl/fast/text/hyphenate-limit-before-after-expected.png:
- platform/efl/fast/text/hyphenate-limit-before-after-expected.txt:
- platform/efl/fast/text/hyphenate-limit-lines-expected.png:
- platform/efl/fast/text/hyphenate-limit-lines-expected.txt:
- platform/efl/fast/text/hyphenate-locale-expected.png: Added.
- platform/efl/fast/text/hyphenate-locale-expected.txt: Added.
- platform/efl/fast/text/hyphens-expected.png:
- platform/efl/fast/text/hyphens-expected.txt:
- 9:10 PM Changeset in webkit [185861] by
-
- 2 edits in trunk/Source/WebKit2
Part 2 of [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target
https://bugs.webkit.org/show_bug.cgi?id=146197
Rubber-stamped by Anders Carlsson.
- WebKit2.xcodeproj/project.pbxproj: Deleted the WebKit2SandboxProfiles-IOSOverride target.
- 8:54 PM Changeset in webkit [185860] by
-
- 4 edits in trunk/Source
[WK1] WebAllowDenyPolicyListener.denyOnlyThisRequest() should not start a new permission request
https://bugs.webkit.org/show_bug.cgi?id=146228
<rdar://problem/15179262>
Reviewed by Daniel Bates.
Source/WebCore:
Add Geolocation::resetIsAllowed() API that merely resets
m_allowGeolocation to Unknown, so that we will request the permission
again the next time a position is requested.
- Modules/geolocation/Geolocation.h:
(WebCore::Geolocation::resetIsAllowed):
Source/WebKit/mac:
Call the new Geolocation::resetIsAllowed() API after denying the
current request, instead of calling
Geolocation::resetAllGeolocationPermission(). In addition to resetting
m_allowGeolocation to Unknown, the latter would also start a new
permission request. However, for
WebAllowDenyPolicyListener.denyOnlyThisRequest(), we really only want
to deny the current request and then reset m_allowGeolocation to
Unknown so that permission is requested again later if the app requests
a position again.
The previous implementation meant that if the client application keeps
calling WebAllowDenyPolicyListener.denyOnlyThisRequest(), we would end
up in an infinite loop (requesting for permission), even though the
application did not make any new geolocation requests.
- WebCoreSupport/WebGeolocationClient.mm:
(-[WebGeolocationPolicyListener denyOnlyThisRequest]):
- 8:47 PM Changeset in webkit [185859] by
-
- 18 edits3 deletes in trunk/Tools
Get rid of factory json files in benchmark_runner
https://bugs.webkit.org/show_bug.cgi?id=146175
Patch by Dewei Zhu <Dewei Zhu> on 2015-06-22
Reviewed by Ryosuke Niwa.
Get rid of factory json files in benchmark_runner and refactoring the code.
- Scripts/webkitpy/benchmark_runner/benchmark_builder/init.py:
(benchmark_builder_loader):
- Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
(BenchmarkBuilderFactory):
- Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
- Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
(GenericBenchmarkBuilder):
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.init):
(BenchmarkRunner.execute):
- Scripts/webkitpy/benchmark_runner/browser_driver/init.py:
(browser_driver_loader):
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver):
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
(BrowserDriverFactory):
(BrowserDriverFactory.available_platforms):
(BrowserDriverFactory.available_browsers):
(BrowserDriverFactory.add_browser_driver):
(BrowserDriverFactory.create):
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver):
(OSXBrowserDriver.prepareEnv):
(OSXBrowserDriver.terminateProcesses):
(OSXBrowserDriver.screenSize):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver):
(OSXChromeCanaryDriver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver):
(OSXFirefoxNightlyDriver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver):
- Scripts/webkitpy/benchmark_runner/generic_factory.py:
(GenericFactory.create):
(GenericFactory.add):
(GenericFactory.iterateGetItem): Deleted.
- Scripts/webkitpy/benchmark_runner/http_server_driver/init.py:
(http_server_driver_loader):
- Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
(HTTPServerDriver):
- Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
(HTTPServerDriverFactory):
- Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
- Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver):
- Scripts/webkitpy/benchmark_runner/utils.py:
(is_subclass):
(load_subclasses):
(ModuleNotFoundError): Deleted.
(loadModule): Deleted.
(loadJSONFromFile): Deleted.
- 6:59 PM Changeset in webkit [185858] by
-
- 2 edits in trunk/Source/WebCore
ASSERT(!m_zOrderListsDirty) when mousing over web view with incremental rendering suppressed
https://bugs.webkit.org/show_bug.cgi?id=146225
Reviewed by Zalan Bujtas.
Update RenderLayer's z-order lists when hit testing. There's no guarantee that they've
been updated; this happens to work most of the time because painting updates them,
but if incremental rendering is suppressed, we may not have painted yet.
Easy to hit on webkit.org in MiniBrowser, but I wasn't able to make a reduced testcase.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
(WebCore::RenderLayer::updateLayerListsIfNeeded): Flip the order of the tests, since checking
dirty bits is cheaper than calling isStackingContext().
- 6:59 PM Changeset in webkit [185857] by
-
- 6 edits in trunk/Tools
Make it possible to enable incremental rendering suppression in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=146223
Reviewed by Tim Horton.
Add a menu item to enable incremental rendering suppression to MiniBrowser.
For WK1, this just toggles a pref, and takes effect immediately.
For WK2, this is a WKConfiguration property, so only affects new web views.
Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
logging on launch.
- MiniBrowser/mac/AppDelegate.m:
(defaultConfiguration):
- MiniBrowser/mac/BrowserWindow.xib:
- MiniBrowser/mac/SettingsController.h:
- MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleIncrementalRenderingSuppressed:]):
(-[SettingsController incrementalRenderingSuppressed]):
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]):
- 6:51 PM Changeset in webkit [185856] by
-
- 12 edits8 moves1 add in trunk/Source
Rename PlatformCA*Mac to PlatformCA*Cocoa
https://bugs.webkit.org/show_bug.cgi?id=146224
<rdar://problem/21497182>
Reviewed by Simon Fraser.
Rename PlatformCALayerMac and related files in platform/graphics/ca/mac
to the more accurate Cocoa suffix.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- page/mac/ServicesOverlayController.mm:
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/graphics/ca/PlatformCAAnimation.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Renamed from Source/WebCore/platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp.
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h: Renamed from Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.h.
- platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm.
- platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/PlatformCAFiltersMac.mm.
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.h: Renamed from Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.h.
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm.
- platform/graphics/ca/cocoa/WebTiledBackingLayer.h: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTiledBackingLayer.h.
- platform/graphics/ca/cocoa/WebTiledBackingLayer.mm: Renamed from Source/WebCore/platform/graphics/ca/mac/WebTiledBackingLayer.mm.
- platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:
- platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm:
- platform/graphics/ca/mac/PlatformCALayerMac.mm:
- platform/graphics/ca/mac/WebTiledBackingLayer.mm:
Source/WebKit2:
- WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::filtersCanBeComposited):
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::create):
- WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.cpp:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
- 6:24 PM Changeset in webkit [185855] by
-
- 2 edits in trunk/Source/WebKit/mac
Delegates should be formal protocols
https://bugs.webkit.org/show_bug.cgi?id=146222
rdar://problem/17380856
Reviewed by Dan Bernstein.
Flip the switch on OS X and make delegates formal protocols.
- postprocess-headers.sh:
- 6:09 PM Changeset in webkit [185854] by
-
- 2 edits in trunk/Source/WebCore
[cssjit] Disable compiling scrollbar pseudoclass selectors
https://bugs.webkit.org/show_bug.cgi?id=146220
Reviewed by Benjamin Poulain.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addScrollbarPseudoClassType):
Don't compile selectors with scrollbar pseudoclasses.
- 5:51 PM Changeset in webkit [185853] by
-
- 5 edits1 add in trunk
[ES6] Allow trailing comma in ArrayBindingPattern and ObjectBindingPattern
https://bugs.webkit.org/show_bug.cgi?id=146192
Reviewed by Darin Adler.
Source/JavaScriptCore:
According to the ES6 spec, trailing comma in ArrayBindingPattern and ObjectBindingPattern is allowed.
And empty ArrayBindingPattern and ObjectBindingPattern is also allowed.
This patch allows trailing comma and empty binding patterns.
- bytecompiler/NodesCodegen.cpp:
(JSC::ArrayPatternNode::bindValue):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseDeconstructionPattern):
- tests/stress/trailing-comma-in-patterns.js: Added.
(shouldBe):
(iterator):
LayoutTests:
- js/object-literal-syntax-expected.txt:
- 5:47 PM Changeset in webkit [185852] by
-
- 3 edits in trunk/Websites/perf.webkit.org
A/B testing results should be shown even if they were submitted to different platforms
https://bugs.webkit.org/show_bug.cgi?id=146219
Reviewed by Andreas Kling.
Fetch A/B testing results regardless of the platform to which results are submitted
by providing the platform ID to which the results were submitted for each test group.
- public/api/test-groups.php:
(main): Include the platform id in the test groups.
- public/v2/analysis.js:
(App.TestGroup._fetchTestResults): Fetch results from the platform associated with the group.
- 4:32 PM Changeset in webkit [185851] by
-
- 3 edits2 adds in trunk
-webkit-clip-path clips incorrectly if the element bounds go beyond the top edge of the page
https://bugs.webkit.org/show_bug.cgi?id=146218
rdar://problem/21127840
Reviewed by Zalan Bujtas.
Source/WebCore:
The clip path is computed using the RenderLayer's bounding box, so needs to be offset
by the offsetFromRenderer when set on the mask layer.
Test: compositing/masks/compositing-clip-path-origin.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateMaskingLayerGeometry):
LayoutTests:
Test clip path on layers with non-zero bounds offsetFromRenderer because of box shadow,
or vertical writing mode.
- compositing/masks/compositing-clip-path-origin-expected.html: Added.
- compositing/masks/compositing-clip-path-origin.html: Added.
- 4:02 PM Changeset in webkit [185850] by
-
- 2 edits in trunk/LayoutTests
fast/text/justify-ideograph-{complex,simple,vertical}.html tests are flaky on El Capitan Debug builds
Tracked by <rdar://problem/21486062>.
- platform/mac/TestExpectations: Mark tests as flaky:
- fast/text/justify-ideograph-complex.html
- fast/text/justify-ideograph-simple.html
- fast/text/justify-ideograph-vertical.html
- 3:36 PM Changeset in webkit [185849] by
-
- 2 edits in trunk/Source/WTF
Fix build.
- wtf/threads/BinarySemaphore.cpp:
- 3:22 PM Changeset in webkit [185848] by
-
- 4 edits6 adds in trunk
Web sockets should be treated as active mixed content
https://bugs.webkit.org/show_bug.cgi?id=140624
Reviewed by Sam Weinig.
Source/WebCore:
Tests: http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe.html
http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Block ws:// WebSocket connections from https:// pages, and
emit the onerror event after doing so.
- platform/SchemeRegistry.cpp:
(WebCore::secureSchemes): Add wss:// to the list of secure schemes.
LayoutTests:
- http/tests/security/mixedContent/resources/frame-with-insecure-websocket.html: Added.
- http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/websocket/insecure-websocket-in-iframe.html: Added.
- http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame-expected.txt: Added.
- http/tests/security/mixedContent/websocket/insecure-websocket-in-main-frame.html: Added.
- 3:07 PM Changeset in webkit [185847] by
-
- 4 edits1 delete in trunk/Source/WTF
Get rid of the Windows specific BinarySemaphore implementation
https://bugs.webkit.org/show_bug.cgi?id=146216
Reviewed by Andreas Kling.
The fact that the Windows implementation uses a HEVENT internally was only useful
to the Windows port of WebKit2; we can get rid of it now.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- wtf/threads/BinarySemaphore.h:
(WTF::BinarySemaphore::event): Deleted.
- wtf/threads/win/BinarySemaphoreWin.cpp: Removed.
(WTF::BinarySemaphore::BinarySemaphore): Deleted.
(WTF::BinarySemaphore::~BinarySemaphore): Deleted.
(WTF::BinarySemaphore::signal): Deleted.
(WTF::BinarySemaphore::wait): Deleted.
- 3:06 PM Changeset in webkit [185846] by
-
- 8 edits4 adds in trunk
Element with blur backdrop-filter shows edge duplication and dark edges
https://bugs.webkit.org/show_bug.cgi?id=146215
<rdar://problem/20367695>
Reviewed by Tim Horton.
Source/WebCore:
The input images to backdrop filters should duplicate their edge pixels
outwards, rather than using transparent pixels. This is a flag we
set on the Gaussian blur, but means we have to remember if the
FilterOperations list came from a regular filter or a backdrop filter.
Test: css3/filters/backdrop/blur-input-bounds.html
- css/CSSPropertyNames.in: New custom convertor for backdrop-filter.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertBackdropFilterOperations): New convertor
that sets the backdrop flag, but is otherwise the same as a normal filter
convertor.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFilterOperations): Inherit the backdrop flag if either of our
inputs has it.
- platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Set the inputNormalizeEdges
key on the CAFilter if necessary.
- platform/graphics/filters/FilterOperations.cpp: Add a new flag indicating if
these operations are intended for backdrops.
(WebCore::FilterOperations::operator=):
(WebCore::FilterOperations::operator==):
- platform/graphics/filters/FilterOperations.h:
(WebCore::FilterOperations::isUsedForBackdropFilters):
(WebCore::FilterOperations::setUsedForBackdropFilters):
LayoutTests:
Add a pixel test to show that the input images to backdrop filters should duplicate their
edge pixels. Unfortunately this is not reproducible with normal filters, so it
can't be a reference test.
- css3/filters/backdrop/blur-input-bounds.html: Added.
- platform/mac/css3/filters/backdrop/blur-input-bounds-expected.png: Added.
- platform/mac/css3/filters/backdrop/blur-input-bounds-expected.txt: Added.
- 3:02 PM Changeset in webkit [185845] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: gaps between sections of the styles sidebar rules tab confusing, should say "Media: all"
https://bugs.webkit.org/show_bug.cgi?id=142918
Patch by Devin Rousso <Devin Rousso> on 2015-06-22
Reviewed by Timothy Hatcher.
- UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label:not(.filter-section-non-matching) ~ .label):
Now properly adds padding to filtered labels.
(.sidebar > .panel.details.css-style > .content.filter-in-progress .label ~ .label): Deleted.
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel.prototype.refresh): If a section of CSS rules has no media or inheritance, add
a label that says "Media: all" above the section.
- 2:33 PM Changeset in webkit [185844] by
-
- 2 edits in trunk/Source/WebCore
[TextIndicator] Text shifts one pixel to the left when I force click to bring up Lookup in Mail messages
https://bugs.webkit.org/show_bug.cgi?id=146214
<rdar://problem/20782970>
Reviewed by Dean Jackson.
- page/mac/TextIndicatorWindow.mm:
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
(WebCore::TextIndicatorWindow::setTextIndicator):
(-[WebTextIndicatorView initWithFrame:textIndicator:margin:]): Deleted.
When the WebView is at a nonintegral position, we can end up needing a TextIndicator
with a nonintegral position. We need to round the window position, so we need to apply
the fractional part to the indicator layers inside, not to the window.
- 2:11 PM Changeset in webkit [185843] by
-
- 3 edits in trunk/Source/WebKit2
Simplify Connection::SyncMessageState
https://bugs.webkit.org/show_bug.cgi?id=146213
Reviewed by Andreas Kling.
Since we no longer support Connections dispatching to multiple threads, we can make SyncMessageState
into a singleton and get rid of the RunLoop -> SyncMessageState hash map.
- Platform/IPC/Connection.cpp:
(IPC::Connection::SyncMessageState::singleton):
(IPC::Connection::SyncMessageState::SyncMessageState):
(IPC::Connection::SyncMessageState::processIncomingMessage):
(IPC::Connection::SyncMessageState::dispatchMessages):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingSyncReply):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::SyncMessageState::syncMessageStateMap): Deleted.
(IPC::Connection::SyncMessageState::syncMessageStateMapMutex): Deleted.
(IPC::Connection::SyncMessageState::getOrCreate): Deleted.
(IPC::Connection::SyncMessageState::~SyncMessageState): Deleted.
(IPC::Connection::Connection): Deleted.
- Platform/IPC/Connection.h:
- 1:53 PM Changeset in webkit [185842] by
-
- 5 edits6 adds in trunk
[iOS] Arabic text styled with Georgia is rendered as boxes
https://bugs.webkit.org/show_bug.cgi?id=145681
<rdar://problem/21169844>
Reviewed by Darin Adler.
Source/WebCore:
Georgia doesn't support Arabic, so we ask CoreText what font does support Arabic. It returns
TimesNewRomanPSMT. However, WebKit explicitly disallows this font on iOS. Therefore, instead
of using TimesNewRomanPSMT, we will simply just use GeezaPro.
Test: fast/text/arabic-times-new-roman.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/Font.h: Let FontCacheIOS call fontFamilyShouldNotBeUsedForArabic()
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::fontFamilyShouldNotBeUsedForArabic):
LayoutTests:
- fast/text/arabic-times-new-roman.html: Added.
- platform/ios-simulator/fast/text/arabic-times-new-roman-expected.txt: Added.
- platform/ios-simulator/fast/text/arabic-times-new-roman-expected.png: Added.
- platform/mac-mavericks/fast/text/arabic-times-new-roman-expected.txt: Added.
- platform/mac/fast/text/arabic-times-new-roman-expected.txt: Added.
- platform/mac/fast/text/arabic-times-new-roman-expected.png: Added.
- 1:49 PM Changeset in webkit [185841] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed non-mac debug build fix after r185840.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
Added enable flag around assertion.
- 1:10 PM Changeset in webkit [185840] by
-
- 20 edits in trunk/Source
[Content Extensions] Add SPI to reload without content blocking.
https://bugs.webkit.org/show_bug.cgi?id=146128
rdar://problem/20351903
Reviewed by Sam Weinig.
Source/WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::open):
- page/Page.h:
(WebCore::Page::userContentController):
(WebCore::Page::userContentExtensionsEnabled):
(WebCore::Page::setUserContentExtensionsEnabled):
(WebCore::Page::group):
- page/UserContentController.cpp:
(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):
- page/UserContentController.h:
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/C/WKPage.cpp:
(WKPageSetCustomUserAgent):
(WKPageSetUserContentExtensionsEnabled):
(WKPageSupportsTextEncoding):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _customUserAgent]):
(-[WKWebView _setUserContentExtensionsEnabled:]):
(-[WKWebView _userContentExtensionsEnabled]):
(-[WKWebView _setCustomUserAgent:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setShouldScaleViewToFitDocument):
(WebKit::WebPageProxy::setUserContentExtensionsEnabled):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::userContentExtensionsEnabled):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setShouldScaleViewToFitDocument):
(WebKit::WebPage::setUserContentExtensionsEnabled):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Pass a boolean from the API to WebCore.
- 12:52 PM Changeset in webkit [185839] by
-
- 15 edits in trunk/Source/WebKit2
Remove m_clientRunLoop from IPC::Connection
https://bugs.webkit.org/show_bug.cgi?id=146212
Reviewed by Sam Weinig.
We only ever create connections whose messages are dispatched to the main run loop, so we can
vastly simplify the code by only allowing messages to be dispatched there.
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::DatabaseToWebProcessConnection):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
- Platform/IPC/Connection.cpp:
(IPC::Connection::createServerConnection):
(IPC::Connection::createClientConnection):
(IPC::Connection::Connection):
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::wakeUpRunLoop):
- Platform/IPC/Connection.h:
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::receiveSourceEventHandler):
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::WebProcessConnection):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::initialize):
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::didFinishLaunching):
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching):
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
- WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::establishConnection):
- 12:35 PM Changeset in webkit [185838] by
-
- 3 edits2 adds in trunk
REGRESSION(r169105) Dangling renderer pointer in SelectionSubtreeRoot::SelectionSubtreeData.
https://bugs.webkit.org/show_bug.cgi?id=146116
rdar://problem/20959369
Reviewed by Brent Fulgham.
This patch ensures that we don't adjust the selection unless the visual selection still matches this subtree root.
When multiple selection roots are present we need to ensure that a RenderObject
only shows up in one of them.
RenderView::splitSelectionBetweenSubtrees(), as the name implies, splits the
selection and sets the selection range (start/end) on each selection root.
However, SelectionSubtreeRoot::adjustForVisibleSelection() later recomputes the range
based on visible selection and that could end up collecting renderers as selection start/end
from another selection subtree.
RenderObject's holds the last selection state (RenderObject::setSelectionState).
If we set a renderer first as "on selection border" and later "inside" using multiple selection roots,
we can't clean up selections properly when this object gets destroyed.
One of the roots ends up with a dangling RenderObject pointer.
Source/WebCore:
Test: fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees.html
- rendering/SelectionSubtreeRoot.cpp:
(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
LayoutTests:
- fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees-expected.txt: Added.
- fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees.html: Added.
- 12:30 PM Changeset in webkit [185837] by
-
- 2 edits in trunk/Source/WebKit2
Crashes in hit testing under WebPage::acceptsFirstMouse() while handling sync message in plug-in teardown
https://bugs.webkit.org/show_bug.cgi?id=146211
rdar://problem/17180615
Reviewed by Sam Weinig.
If we're inside a sendSync message when we're being called, just bail.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::acceptsFirstMouse):
- 10:53 AM Changeset in webkit [185836] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Consider making read-only style rules have a darker background
https://bugs.webkit.org/show_bug.cgi?id=145983
Reviewed by Timothy Hatcher.
- UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section:not(.locked)):
(.style-declaration-section): Deleted.
- UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor.read-only > .CodeMirror):
- 10:47 AM Changeset in webkit [185835] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Unable to select text of user input messages in the console
https://bugs.webkit.org/show_bug.cgi?id=145888
Reviewed by Timothy Hatcher.
- UserInterface/Views/ConsoleMessageView.css:
(.console-user-command > .console-message-text):
- 10:41 AM Changeset in webkit [185834] by
-
- 4 edits in trunk/Source/WebCore
Do not exit fullscreen when starting PiP since this is done automatically.
https://bugs.webkit.org/show_bug.cgi?id=144871
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-06-22
Reviewed by Darin Adler.
Since we don't explicitly exit fullscreen, update state in shouldExitFullscreenWithReason()
- platform/ios/WebVideoFullscreenInterfaceAVKit.h: Declare shouldExitFullscreenWithReason().
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController playerViewController:shouldExitFullScreenWithReason:]): Forward to WebVideoFullscreenInterfaceAVKit.
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Added.
(WebVideoFullscreenInterfaceAVKit::willStartPictureInPicture): Remove enter fullscreen code.
- platform/spi/cocoa/AVKitSPI.h: Add missing enums.
- 10:11 AM Changeset in webkit [185833] by
-
- 6 edits1 add in trunk
Run CDjs as part of JSC stress testing
https://bugs.webkit.org/show_bug.cgi?id=146174
Reviewed by Geoffrey Garen.
PerformanceTests:
- JetStream/cdjs/cdjs-tests.yaml: Added. This tells JSC stress tests what tests to run. It uses new syntax ("tests" being a list) that I add in this change.
- JetStream/cdjs/main.js: Mark this as a slow test.
- JetStream/create.rb: Don't copy the JSC stress tests artifacts into the JetStream bundle.
Tools:
- Scripts/run-javascriptcore-tests:
(runJSCStressTests): Make this aware of the cdjs-tests.yaml.
- Scripts/run-jsc-stress-tests:
- Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
- Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
- Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
- 10:04 AM Changeset in webkit [185832] by
-
- 2 edits1 add in trunk/Source/WebKit2
Part 1 of [Xcode] Fold the WebKit2SandboxProfiles-IOSOverride target into the Sandbox Profiles target
https://bugs.webkit.org/show_bug.cgi?id=146197
Reviewed by Anders Carlsson.
- Configurations/SandboxProfiles.xcconfig: Added. Defines INSTALL_PATH based on the value
of WK_INSTALL_OVERRIDE_SANDBOX_PROFILES.
- WebKit2.xcodeproj/project.pbxproj: Use SandboxProfiles.xcconfig for the Sandbox Profiles
target, and change the destination path in its Copy Files build phase to INSTALL_PATH.
- 9:35 AM Changeset in webkit [185831] by
-
- 3 edits in tags/Safari-601.1.35.2.3/Source/WebKit2
Merged r185814. rdar://problem/21444762
- 9:34 AM Changeset in webkit [185830] by
-
- 5 edits in tags/Safari-601.1.35.2.3/Source
Versioning.
- 9:29 AM Changeset in webkit [185829] by
-
- 1 copy in tags/Safari-601.1.35.2.3
New tag.
- 9:17 AM Changeset in webkit [185828] by
-
- 5 edits7 adds in trunk
AX: UI Automation cannot find AutoFill or search cancel buttons
https://bugs.webkit.org/show_bug.cgi?id=145241
<rdar://problem/21051411>
Reviewed by Chris Fleizach.
Source/WebCore:
Add support for hit testing the search cancel button and AutoFill button so that
they can be accessed by UI Automation.
Currently the accessibility hit test machinery ignores nodes in a shadow tree.
So, it neither finds the <input type="search"> cancel button nor the AutoFill button
when it performs a hit test. Therefore these buttons cannot be accessed using
UI Automation.
Tests: accessibility/hit-test-input-auto-fill-button.html
accessibility/hit-test-input-search-cancel-button.html
accessibility/input-search-cancel-button.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityTextFieldDecorationHitTest): Added; returns
the AccessibilityObject for the search cancel button or AutoFill text field decoration as applicable.
(WebCore::AccessibilityRenderObject::accessibilityHitTest): Check whether the hit node
is a text field decoration.
LayoutTests:
Add tests to ensure that there exists an accessibility element for the
search cancel button and that it can be hit using a cursor position. Also
add a test to ensue that the AutoFill button can be hit using a cursor position.
- accessibility/hit-test-input-auto-fill-button-expected.txt: Added.
- accessibility/hit-test-input-auto-fill-button.html: Copied from LayoutTests/accessibility/input-auto-fill-button.html.
- accessibility/hit-test-input-search-cancel-button-expected.txt: Added.
- accessibility/hit-test-input-search-cancel-button.html: Added.
- accessibility/input-search-cancel-button-expected.txt: Added.
- accessibility/input-search-cancel-button.html: Copied from LayoutTests/accessibility/input-auto-fill-button.html.
- accessibility/resources/shouldBeAccessibleByCursor.js: Added.
(shouldBeAccessibleByCursor): Tests whether an AccessibilityUIElement can be hit
using its screen position.
- platform/wk2/TestExpectations: Mark tests hit-test-input-{auto-fill, search-cancel}-button.html
as failing due to <https://bugs.webkit.org/show_bug.cgi?id=71298>.
- 7:32 AM Changeset in webkit [185827] by
-
- 2 edits in trunk/Source/WebKit2
Crash replacing TabDocument in MobileSafari at WebKit: -[WKWebView(WKPrivate) _beginAnimatedResizeWithUpdates:]
https://bugs.webkit.org/show_bug.cgi?id=146201
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
No repro but if for some reason [_contentView bounds] width is zero we'll compute +Inf targetScale
and then NaN contentOffset.x. Verified in lldb that this gives the exact crash signature seen.
Fix by checking that [_contentView bounds] is not empty like is done with other inputs.
- 6:59 AM Changeset in webkit [185826] by
-
- 18 edits in trunk
[Streams API] Implement ReadableStream cancel (abstract part)
https://bugs.webkit.org/show_bug.cgi?id=146111
Reviewed by Darin Adler.
Source/WebCore:
This patch implements ReadableStream and ReadableStreamReader cancel.
The reader delegates cancellation to its stream.
This patch also ensures that controller.close() will not throw in case cancellation is on-going.
A follow-up patch will implement the calling of 'cancel' JS callback for JS sources.
Covered by rebased tests.
- Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::cancel): Checks whether locked or not before cancelling.
(WebCore::ReadableStream::cancelNoCheck): Cancel without lock check.
(WebCore::ReadableStream::notifyCancelSucceeded): Async cancel callback.
(WebCore::ReadableStream::notifyCancelFailed): Ditto.
- Modules/streams/ReadableStream.h:
- Modules/streams/ReadableStream.idl: Cleaned up IDL.
- Modules/streams/ReadableStreamReader.cpp:
(WebCore::ReadableStreamReader::cancel):
- Modules/streams/ReadableStreamReader.h:
- Modules/streams/ReadableStreamReader.idl: Cleaned up IDL
- bindings/js/JSReadableStreamControllerCustom.cpp:
(WebCore::JSReadableStreamController::close):
- bindings/js/JSReadableStreamCustom.cpp:
(WebCore::JSReadableStream::cancel):
- bindings/js/JSReadableStreamReaderCustom.cpp:
(WebCore::JSReadableStreamReader::cancel):
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::doCancel):
- bindings/js/ReadableJSStream.h:
LayoutTests:
Rebasing expectations.
- streams/reference-implementation/bad-underlying-sources-expected.txt:
- streams/reference-implementation/readable-stream-cancel-expected.txt:
- streams/reference-implementation/readable-stream-expected.txt:
- streams/reference-implementation/readable-stream-reader-expected.txt:
- streams/reference-implementation/readable-stream-templated-expected.txt:
- 5:42 AM Changeset in webkit [185825] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r182303): [GTK] Context menu API is broken since r182303
https://bugs.webkit.org/show_bug.cgi?id=146202
Reviewed by Žan Doberšek.
The problem is that ContextMenuclient API changed in r182303, but
we didn't notice it either, and the default handler for
getContextMenuFromProposedMenu was executed. An override keyword
would have caught this.
- UIProcess/API/gtk/WebKitContextMenuClient.cpp: Build a Vector of
WebContextMenuItemData as expected by our API, and add add
override keyword to ensure this doesn't happen again.
- 5:06 AM Changeset in webkit [185824] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] ConnectionUnix should use FastMalloc to allocate on-heap resources
https://bugs.webkit.org/show_bug.cgi?id=146143
Reviewed by Carlos Garcia Campos.
IPC handling in Unix-specific IPC::Connection implementation should use
FastMalloc to allocate on-heap resources, instead of allocating via the
system allocator.
The AttachmentInfo class is marked as allocatable through FastMalloc.
That way it can be allocated through FastMalloc while still handled
through std::unique_ptr<>.
The char[] arrays in readBytesFromSocket() and Connection::sendOutgoingMessage()
are now handled through a MallocPtr<> object.
In Connection::sendOutgoingMessage(), both the AttachmentInfo[] and char[]
arrays are now only allocated if there are actual attachments contained
in the message. The code that's conditioned with a non-empty attachments
Vector is now also grouped together, in a single branch.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket):
(IPC::Connection::sendOutgoingMessage):
- 4:55 AM Changeset in webkit [185823] by
-
- 3 edits in trunk
[CMake] Add support for building with various sanitizer tools
https://bugs.webkit.org/show_bug.cgi?id=131941
Reviewed by Martin Robinson.
- Source/PlatformGTK.cmake: Don't generate any documentation
when compiling with sanitizers enabled.
- Source/cmake/OptionsCommon.cmake: Allow linking with
undefined symbols when compiling with sanitizers enabled.
- 3:03 AM Changeset in webkit [185822] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] test_ewk2_application_cache_manager has been failed since r185527
https://bugs.webkit.org/show_bug.cgi?id=146016
Reviewed by Csaba Osztrogonác.
- UIProcess/API/efl/tests/test_ewk2_application_cache_manager.cpp:
(TEST_F): Disable this test for now. This test will be enabled again.
- 1:57 AM Changeset in webkit [185821] by
-
- 3 edits in trunk/LayoutTests
[Streams API] Correct releaseLock test in readable-stream-templated.html
https://bugs.webkit.org/show_bug.cgi?id=146101
Reviewed by Darin Adler.
- streams/reference-implementation/readable-stream-templated-expected.txt: Rebased changed test.
- streams/reference-implementation/readable-stream-templated.html: Removed testharness wrapper around function.
- 1:36 AM Changeset in webkit [185820] by
-
- 8 edits in trunk
WebRTC: Navigator.webkitGetUserMedia() requires three arguments
https://bugs.webkit.org/show_bug.cgi?id=146022
Reviewed by Eric Carlson.
Source/WebCore:
Updated custom binding to make the third error callback argument
mandatory. Updated and unskipped three tests (for the GTK+ port).
- bindings/js/JSNavigatorCustom.cpp:
(WebCore::JSNavigator::webkitGetUserMedia):
LayoutTests:
Updated and unskipped three existing tests.
- fast/mediastream/argument-types-expected.txt:
- fast/mediastream/getusermedia-expected.txt:
- fast/mediastream/getusermedia.html:
- fast/mediastream/script-tests/argument-types.js:
- platform/gtk/TestExpectations:
- 12:57 AM Changeset in webkit [185819] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build after r185818.
Actually rollout r185320.
- platform/network/soup/DNSSoup.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::gotProxySettingsCallback): Deleted.
(WebCore::DNSResolveQueue::platformMaybeResolveHost): Deleted.
Jun 21, 2015:
- 11:32 PM Changeset in webkit [185818] by
-
- 9 edits in trunk/Source
Page load performance regression due to bugs.webkit.org/show_bug.cgi?id=145542
https://bugs.webkit.org/show_bug.cgi?id=146198
Unreviewed rollout.
Source/WebCore:
- platform/network/DNSResolveQueue.cpp:
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::isUsingProxy):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):
- platform/network/DNSResolveQueue.h:
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::clientCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::proxyIsEnabledInSystemPreferences): Deleted.
(WebCore::isUsingProxy): Deleted.
(WebCore::DNSResolveQueue::platformMaybeResolveHost): Deleted.
- platform/network/soup/DNSSoup.cpp:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_prefetch_dns):
Source/WTF:
- wtf/glib/GUniquePtr.h:
- 9:48 PM Changeset in webkit [185817] by
-
- 2 edits in trunk/Source/WebKit2
WKApplicationCacheManagerDeleteEntriesForOrigin() has wrong WebsiteDataTypes.
https://bugs.webkit.org/show_bug.cgi?id=146180
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-21
Reviewed by Sam Weinig.
Modify to use correct WebsiteDataTypes in WKApplicationCacheManagerDeleteEntriesForOrigin()
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerDeleteEntriesForOrigin):
- 9:25 PM Changeset in webkit [185816] by
-
- 5 edits1 add in trunk
REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
https://bugs.webkit.org/show_bug.cgi?id=146121
rdar://problem/21395180
Reviewed by Darin Adler.
Source/WebCore:
Revert to previous behavior, which is wrong in many ways, but not as wrong as the new one.
- platform/mac/Language.mm:
(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):
- platform/spi/cf/CFBundleSPI.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
(-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::overrideAppleLanguages):
(TestWebKitAPI::languageForSystemLanguage):
(TestWebKitAPI::TEST):
- 8:25 PM Changeset in webkit [185815] by
-
- 2 edits in trunk/LayoutTests
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html is slow on Mavericks WK1 Debug builds
The Flakiness Dashboard says that this test times out, but only
on Mavericks WK1 Debug builds (and the leaks bot):
- platform/mac-wk1/TestExpectations: Mark test as slow on
Mavericks Debug builds:
- fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html
- 4:44 PM Changeset in webkit [185814] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/21444762> REGRESSION (r184215): Plug-in services crash on launch on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=146195
Reviewed by Sam Weinig.
- Configurations/PluginService.32.xcconfig: Changed the Yosemite definition of
INFOPLIST_FILE such that it would also apply to the macosx10.10.internal SDK.
- Configurations/PluginService.64.xcconfig: Ditto.
- 2:14 PM Changeset in webkit [185813] by
-
- 23 edits in trunk/Source/WebCore
Give Node::didNotifySubtreeInsertions() a better name
https://bugs.webkit.org/show_bug.cgi?id=146170
Reviewed by Darin Adler.
didNotifySubtreeInsertions() is not a good name. It sounds like we are notifying the subtree insertions, which doesn't make sense.
This function is really about notifying the Node that the subtree it's a part of has finished being inserted into the DOM
(i.e. all nodes have received their call to insertedInto()). Change the name to finishedInsertingSubtree() to better reflect this.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::notifyChildInserted):
- dom/ContainerNodeAlgorithms.h:
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
- dom/Element.cpp:
(WebCore::Element::addShadowRoot):
- dom/Node.h:
(WebCore::Node::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::Node::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::ScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- dom/ScriptElement.h:
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedInto):
(WebCore::HTMLFrameElementBase::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- html/HTMLFrameElementBase.h:
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::insertedInto):
(WebCore::HTMLScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::HTMLScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- html/HTMLScriptElement.h:
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::insertedInto):
(WebCore::SVGFEImageElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGFEImageElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGFEImageElement.h:
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::insertedInto):
(WebCore::SVGMPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGMPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGMPathElement.h:
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::insertedInto):
(WebCore::SVGScriptElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGScriptElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGScriptElement.h:
- svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::insertedInto):
(WebCore::SVGTRefElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTRefElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGTRefElement.h:
- svg/SVGTextPathElement.cpp:
(WebCore::SVGTextPathElement::insertedInto):
(WebCore::SVGTextPathElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGTextPathElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/SVGTextPathElement.h:
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::finishedInsertingSubtree): Renamed from didNotifySubtreeInsertions.
(WebCore::SVGSMILElement::didNotifySubtreeInsertions): Renamed to finishedInsertingSubtree.
- svg/animation/SVGSMILElement.h:
- 9:44 AM Changeset in webkit [185812] by
-
- 3 edits in trunk/LayoutTests
fast/fixed-layout/fixed-layout.html times out on Apple WK2 bots
The Flakiness Dashboard says this test times out on Apple
WebKit2 platforms by not calling testRunner.notifyDone():
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Use the same mechanism here that was just added in r185811.
- fast/fixed-layout/fixed-layout.html: Switch to using a
zero-delay timer instead of document.body.offsetTop.
- 9:16 AM Changeset in webkit [185811] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r185809): fast/css-grid-layout/flex-content-sized-columns-resize.html hangs on WK1
Since window.resize() occurs in the same runloop as the load on
WK1, testRunner.notifyDone() would never get called.
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Call document.body.offsetTop to ensure layout occurs at the
initial window size before calling window.resize().
- 9:01 AM Changeset in webkit [185810] by
-
- 2 edits in trunk/Source/WebKit2
Build fix.
- Shared/API/Cocoa/WKFoundation.h: Don’t use generics if the SDK doesn’t support them.
- 8:57 AM Changeset in webkit [185809] by
-
- 2 edits in trunk/LayoutTests
fast/css-grid-layout/flex-content-sized-columns-resize.html is flaky
The Flakiness Dashboard says this test is flaky on Apple and EFL
WebKit2 platforms:
It currently doesn't wait for window.resize() to complete, which
is likely the source of flakiness.
- fast/css-grid-layout/flex-content-sized-columns-resize.html:
Switch to using notifyDone() inside a window.onresize function,
and make the test work in a web browser without TestRunner.
- 6:19 AM Changeset in webkit [185808] by
-
- 2 edits in trunk/Source/WebKit2
[SOUP] Use GTask in WebKitSoupRequestInputStream
https://bugs.webkit.org/show_bug.cgi?id=146184
Reviewed by Carlos Garcia Campos.
Replace deprecated use of GSimpleAsyncResult with GTask.
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
(AsyncReadData::AsyncReadData):
(webkitSoupRequestInputStreamReadAsyncResultComplete):
(webkitSoupRequestInputStreamPendingReadAsyncComplete):
(webkitSoupRequestInputStreamReadAsync):
(webkitSoupRequestInputStreamReadFinish):
- 6:15 AM Changeset in webkit [185807] by
-
- 4 edits in trunk/Source/WebKit2
Fix format strings in NetworkCache.cpp and NetworkCacheStatistics.cpp and WebIDBServerConnection.cpp
https://bugs.webkit.org/show_bug.cgi?id=146172
Reviewed by Darin Adler.
Use the correct %"PRIu64" and %"PRIi64" for uint64_t and int64_t, instead of %llu and %lli.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
(WebKit::NetworkCache::Statistics::recordRevalidationSuccess):
- WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:
(WebKit::WebIDBServerConnection::deleteDatabase):
(WebKit::WebIDBServerConnection::didDeleteDatabase):
(WebKit::WebIDBServerConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::didGetOrEstablishIDBDatabaseMetadata):
(WebKit::WebIDBServerConnection::openTransaction):
(WebKit::WebIDBServerConnection::didOpenTransaction):
(WebKit::WebIDBServerConnection::beginTransaction):
(WebKit::WebIDBServerConnection::didBeginTransaction):
(WebKit::WebIDBServerConnection::commitTransaction):
(WebKit::WebIDBServerConnection::didCommitTransaction):
(WebKit::WebIDBServerConnection::resetTransaction):
(WebKit::WebIDBServerConnection::didResetTransaction):
(WebKit::WebIDBServerConnection::rollbackTransaction):
(WebKit::WebIDBServerConnection::didRollbackTransaction):
(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::didCreateObjectStore):
(WebKit::WebIDBServerConnection::createIndex):
(WebKit::WebIDBServerConnection::didCreateIndex):
(WebKit::WebIDBServerConnection::deleteIndex):
(WebKit::WebIDBServerConnection::didDeleteIndex):
(WebKit::WebIDBServerConnection::get):
(WebKit::WebIDBServerConnection::put):
(WebKit::WebIDBServerConnection::didPutRecord):
(WebKit::WebIDBServerConnection::didGetRecord):
(WebKit::WebIDBServerConnection::didOpenCursor):
(WebKit::WebIDBServerConnection::didAdvanceCursor):
(WebKit::WebIDBServerConnection::didIterateCursor):
(WebKit::WebIDBServerConnection::count):
(WebKit::WebIDBServerConnection::didCount):
(WebKit::WebIDBServerConnection::deleteRange):
(WebKit::WebIDBServerConnection::didDeleteRange):
(WebKit::WebIDBServerConnection::clearObjectStore):
(WebKit::WebIDBServerConnection::didClearObjectStore):
(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::didDeleteObjectStore):
(WebKit::WebIDBServerConnection::changeDatabaseVersion):
(WebKit::WebIDBServerConnection::didChangeDatabaseVersion):
(WebKit::WebIDBServerConnection::openCursor):
(WebKit::WebIDBServerConnection::cursorAdvance):
(WebKit::WebIDBServerConnection::cursorIterate):
- 6:15 AM Changeset in webkit [185806] by
-
- 13 edits in trunk/Tools
[CMake] Ignore warnings from system headers when compiling Tools
https://bugs.webkit.org/show_bug.cgi?id=146185
Reviewed by Martin Robinson.
Use the SYSTEM argument to the include_directories() command to silence compiler warnings
from system headers that we don't control.
- DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
- ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
- ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
- ImageDiff/PlatformGTK.cmake:
- MiniBrowser/efl/CMakeLists.txt:
- MiniBrowser/gtk/CMakeLists.txt:
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/PlatformEfl.cmake:
- WebKitTestRunner/PlatformGTK.cmake:
- 3:06 AM Changeset in webkit [185805] by
-
- 5 edits in trunk
libwebkit2gtk fails to link without opengl
https://bugs.webkit.org/show_bug.cgi?id=138332
Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-06-21
Reviewed by Carlos Garcia Campos.
.:
- Source/cmake/OptionsGTK.cmake: USE(TEXTURE_MAPPER) must be
enabled regardless of whether OpenGL is, because certain symbols
such as WebCore::GraphicsLayer::create() need to be built.
Source/WebCore:
- CMakeLists.txt: The third-party ANGLE directories need to be
included even if ENABLE(GRAPHICS_CONTEXT_3D) is false. They must
be included after the OpenGL headers as the comment says.
- platform/graphics/texmap/BitmapTexturePool.cpp: Remove
reference to no longer existent header file.
