Timeline
Jul 31, 2015:
- 11:48 PM Changeset in webkit [187714] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: inherited CSS rules disappear from Styles sidebar while editing
https://bugs.webkit.org/show_bug.cgi?id=147441
Reviewed by Timothy Hatcher.
If the user edits a style declaration such that it would dissapear mid-edit, prevent
the rules panel from refreshing until that editor is blurred.
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection):
(WebInspector.CSSStyleDeclarationSection.prototype.get editorActive):
(WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector):
(WebInspector.CSSStyleDeclarationSection.prototype._editorContentChanged):
(WebInspector.CSSStyleDeclarationSection.prototype._editorBlurred):
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._editorBlured):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):
- UserInterface/Views/RulesStyleDetailsPanel.js:
(WebInspector.RulesStyleDetailsPanel):
(WebInspector.RulesStyleDetailsPanel.prototype._removeSectionWithActiveEditor):
- UserInterface/Views/StyleDetailsPanel.js:
(WebInspector.StyleDetailsPanel.prototype._refreshPreservingScrollPosition):
- 11:47 PM Changeset in webkit [187713] by
-
- 9 edits in trunk/Source
Media Session: inform the UI process when the focused Content media element changes
https://bugs.webkit.org/show_bug.cgi?id=147323
Reviewed by Tim Horton.
WebCore:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playInternal): Eventually tell the UI process that the focused Content media element changed.
- page/ChromeClient.h:
WebKit2:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::isPlayingMediaDidChange):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedContentMediaElementDidChange):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 11:39 PM Changeset in webkit [187712] by
-
- 3 edits in trunk/Source/WebCore
Media Session: give media elements unique IDs https://bugs.webkit.org/show_bug.cgi?id=147322
Reviewed by Eric Carlson.
- html/HTMLMediaElement.cpp:
(WebCore::elementIDsToElements): Create a global map of element IDs to elements.
(WebCore::HTMLMediaElement::elementWithID): Retrieve the element with the given ID.
(WebCore::HTMLMediaElement::HTMLMediaElement): Give the element a unique ID.
(WebCore::HTMLMediaElement::playInternal): Removed whitespace.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.
- html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::elementID):
- 11:27 PM Changeset in webkit [187711] by
-
- 1 edit1 add in trunk/LayoutTests
Adding -expected.png for fast/text/international/arabic-justify.html
- platform/mac-yosemite/fast/text/international/arabic-justify-expected.png: Added
- 10:33 PM Changeset in webkit [187710] by
-
- 1 edit2 adds in trunk/LayoutTests
Media Session: add test to ensure that switching media sessions pauses elements
https://bugs.webkit.org/show_bug.cgi?id=147493
Reviewed by Eric Carlson.
- media/session/switching-sessions-expected.txt: Added.
- media/session/switching-sessions.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 9:27 PM Changeset in webkit [187709] by
-
- 2 edits in trunk/Source/WebCore
Fix the build
Unreviewed.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::lookupCTFont):
- 9:15 PM Changeset in webkit [187708] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Autocomplete: Undo (Cmd+Z) doesn't work as expected
https://bugs.webkit.org/show_bug.cgi?id=147316
Reviewed by Timothy Hatcher.
Instead of replacing the text for a completion, which messes up the undo history, add
a unique marker that contains the remaining text for the current completion.
- UserInterface/Controllers/CodeMirrorCompletionController.js:
(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):
- 9:06 PM Changeset in webkit [187707] by
-
- 6 edits in trunk/Source/WebCore
[OS X] Migrate to CTFontCreateForCharactersWithLanguage from [NSFont findFontLike:forString:withRange:inLanguage]
https://bugs.webkit.org/show_bug.cgi?id=147483
Reviewed by Dean Jackson.
[NSFont findFontLike:forString:withRange:inLanguage] doesn't properly handle its last argument. In
addition, we want to be moving away from NSFont in the first place and on to Core Text. This new
CoreText function correctly handles its language argument, which is required for language-specific
font fallback.
No new tests because there is no behavior change.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData):
- platform/graphics/FontCache.h:
(WebCore::FontCache::platformPurgeInactiveFontData):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::fallbackDedupSet):
(WebCore::FontCache::platformPurgeInactiveFontData):
(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):
- platform/spi/cocoa/CoreTextSPI.h:
- platform/spi/mac/NSFontSPI.h:
- 8:41 PM Changeset in webkit [187706] by
-
- 31 edits in trunk/Source
Drop dummy Timer callbacks
https://bugs.webkit.org/show_bug.cgi?id=147516
Reviewed by Alexey Proskuryakov.
Drop dummy Timer callbacks in the code base. A lot of Timer callbacks
do nothing else beside calling a particular method. In such case, we
can use the called method as Timer callback instead.
Source/WebCore:
- css/FontLoader.cpp:
(WebCore::FontLoader::FontLoader):
- css/FontLoader.h:
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::styleRecalcTimerFired): Deleted.
(WebCore::Document::domCookieCacheExpiryTimerFired): Deleted.
- dom/Document.h:
- html/MediaController.cpp:
(MediaController::MediaController):
(MediaController::timeupdateTimerFired): Deleted.
- html/MediaController.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired): Deleted.
- loader/cache/CachedResourceLoader.h:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::pruneTimerFired): Deleted.
- loader/cache/MemoryCache.h:
- page/EventSource.cpp:
(WebCore::EventSource::EventSource):
(WebCore::EventSource::connectTimerFired): Deleted.
- page/EventSource.h:
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
(WebCore::FrameView::delayedScrollEventTimerFired): Deleted.
(WebCore::FrameView::postLayoutTimerFired): Deleted.
- page/FrameView.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.h:
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired): Deleted.
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired): Deleted.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::FontCache):
(WebCore::FontCache::purgeTimerFired): Deleted.
- platform/graphics/FontCache.h:
- platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::timerFired): Deleted.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired): Deleted.
Source/WebKit/mac:
- Plugins/WebNetscapePluginStream.h:
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverDataTimerFired): Deleted.
Source/WebKit2:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired): Deleted.
- 8:03 PM Changeset in webkit [187705] by
-
- 1 copy in tags/Safari-601.1.45
New tag.
- 7:39 PM Changeset in webkit [187704] by
-
- 2 edits in trunk/Source/WebCore
Removed pointSize from _addMarkersToList
https://bugs.webkit.org/show_bug.cgi?id=147515
Reviewed by Eric Carlson.
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addMarkersToList): Deleted.
- 7:39 PM Changeset in webkit [187703] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Roll out r187466. rdar://problem/21960398
- 6:56 PM Changeset in webkit [187702] by
-
- 8 edits in trunk
Prepare for VS2015
https://bugs.webkit.org/show_bug.cgi?id=146579
Reviewed by Jon Honeycutt.
Source/JavaScriptCore:
- heap/Heap.h:
Fix compiler error by explicitly casting zombifiedBits to the size of a pointer.
Source/WebCore:
- WebCore.vcxproj/build-generated-files.pl:
Find a correct preprocessor when using VS2015.
Source/WTF:
- wtf/StdLibExtras.h:
(std::exchange):
Added preprocessor macros around functions implemented in VS2015's standard library.
Tools:
- WinLauncher/stdafx.h:
Define STDC_LIMIT_MACROS to have access to INTMAX_MAX.
- 6:36 PM Changeset in webkit [187701] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening. Skip Media Sessions tests, the feature is not yet enabled.
- TestExpectations:
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 6:32 PM Changeset in webkit [187700] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Scrolling "jumps" in console
https://bugs.webkit.org/show_bug.cgi?id=147482
Reviewed by Joseph Pecoraro.
Removed focus call on messageElement.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._mousedown): Deleted.
(WebInspector.LogContentView.prototype._didFocus): Deleted.
(WebInspector.LogContentView.prototype._didBlur): Deleted.
- 6:22 PM Changeset in webkit [187699] by
-
- 4 edits in trunk/LayoutTests
Unreviewed gardening. Update inspector test skips based on bots.
- TestExpectations:
- platform/gtk/TestExpectations:
- platform/win/TestExpectations:
- 5:43 PM Changeset in webkit [187698] by
-
- 4 edits in trunk/Source/WebKit2
[WK2][NetworkCache] Drop HTTP method from NetworkCache::Key
https://bugs.webkit.org/show_bug.cgi?id=143348
Reviewed by Antti Koivisto.
Drop HTTP method from NetworkCache::Key as we only cache GET responses
for now. Even when we start caching HEAD responses, we likely will not
want the method to be part of the key because:
- A HEAD response can be used to update the headers of a previously cached response to GET
- A cached GET response may be used to satisfy subsequent HEAD requests
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::makeCacheKey):
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::decode):
(WebKit::NetworkCache::Key::operator=): Deleted.
(WebKit::NetworkCache::Key::computeHash): Deleted.
(WebKit::NetworkCache::Key::encode): Deleted.
- NetworkProcess/cache/NetworkCacheKey.h:
(WebKit::NetworkCache::Key::method): Deleted.
- 5:29 PM Changeset in webkit [187697] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187694. rdar://problem/22015509
- 5:27 PM Changeset in webkit [187696] by
-
- 6 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187688. rdar://problem/22015509
- 5:19 PM Changeset in webkit [187695] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187684. rdar://problem/22000865
- 5:09 PM Changeset in webkit [187694] by
-
- 3 edits in trunk/Source/WebCore
[iOS] use a media-specific user gesture check
https://bugs.webkit.org/show_bug.cgi?id=147509
Reviewed by Tim Horton.
Change an enum name added in r187688.
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite): DefinitelyProcessingMediaUserGesture -> DefinitelyProcessingPotentialUserGesture
(WebCore::UserGestureIndicator::processingUserGestureForMedia): Ditto.
- dom/UserGestureIndicator.h: Ditto.
- 5:00 PM Changeset in webkit [187693] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Latin quotes are used with the system font on Chinese devices
https://bugs.webkit.org/show_bug.cgi?id=147504
Reviewed by Dean Jackson.
The system font has some fancy logic regarding character selection which requires
using Core Text for glyph selection.
No new tests because tests can't change the system language of the device.
- platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::shouldUseCoreText):
- 4:57 PM Changeset in webkit [187692] by
-
- 10 edits1 move1 add in trunk
Web Inspector: Unskip / Unflake inspector tests after r187627
https://bugs.webkit.org/show_bug.cgi?id=147503
Reviewed by Brian Burg.
Source/WebInspectorUI:
- UserInterface/Base/Test.js:
(InspectorTest.completeTest):
(InspectorTest.completeTest.signalCompletionToTestPage): Deleted.
(InspectorTest.testPageDidLoad):
Instead of immediately resending results if completeTest was called
during a reload before the load has completed, we just set a flag
to complete the test when the load completes. This consistently
resends the output to the new page for test output.
(InspectorTest._resendResults):
Delete clear results. If the page had logged anything directly on
the page side (using InspectorTestProxy) this clearMessages would
have deleted those messages and not been able to recreate them.
Clearing messages wasn't really serving a purpose.
LayoutTests:
- TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
Unskip and unflake inspector tests.
- http/tests/inspector/inspector-test.js:
(InspectorTestProxy.addResult):
Simplify with the new append API.
(InspectorTestProxy.clearResults): Deleted.
Delete, as it is no longer used.
- inspector/debugger/probe-manager-add-remove-actions-expected.txt:
Include output that was getting erronously cleared by clearResults
which we removed.
- inspector/dom/highlightSelector-expected.txt:
- inspector/dom/highlightSelector.html:
Make this test more reliable when run with other tests.
Never assume the frame id for the main frame or sub frame,
instead compute them and mask them in the output.
- inspector/dom/resources/highlightSelector-iframe.html: Renamed from LayoutTests/inspector/dom/highlightSelector-iframe.html.
Move the non-test iframe html resource into a sub-folder
so it won't be treated like an actual test.
- 4:56 PM Changeset in webkit [187691] by
-
- 5 edits in trunk/Source
Source/WebCore:
Coalesce authentication credential requests
https://bugs.webkit.org/show_bug.cgi?id=128006
<rdar://problem/16839069>
Reviewed by Alexey Proskuryakov.
Export symbol for ProtectionSpace::compare() so it can be called from
WebKit2.
- platform/network/ProtectionSpaceBase.h:
Source/WebKit2:
Coalesce concurrent authentication challenges for the same ProtectionSpace
https://bugs.webkit.org/show_bug.cgi?id=147496
<rdar://problem/16839069>
Reviewed by Alexey Proskuryakov.
Coalesce concurrent authentication challenges for the same ProtectionSpace.
Ideally, this would be done in the network layer but short term, this will
make sure the user no longer gets repeating authentication dialogs for the
same protection space.
This gets rid of a long-standing bug in WebKit / Safari where visiting a
site using HTTP authentication would pop up one authentication dialog for
each subresource being loaded from the network (especially when the main
resource is loaded from the cache).
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::canCoalesceChallenge):
(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
(WebKit::AuthenticationManager::AuthenticationManager): Deleted.
- Shared/Authentication/AuthenticationManager.h:
- 4:50 PM Changeset in webkit [187690] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Skip more inspector tests on Windows.
It may be that no inspector tests are working on Windows,
if that is the case we may move to skipping all of them
and investigate unskipping in chunks.
- platform/win/TestExpectations:
- 4:27 PM Changeset in webkit [187689] by
-
- 20 edits in trunk/Source/WebInspectorUI
Web Inspector: Convert timeline view classes to ES6 classes
https://bugs.webkit.org/show_bug.cgi?id=147381
Reviewed by Joseph Pecoraro.
Along the way, inline a few style class names.
Elided mechanical changes from the Changelog.
- UserInterface/Views/LayoutTimelineOverviewGraph.js:
- UserInterface/Views/LayoutTimelineView.js:
- UserInterface/Views/LinearTimelineOverview.js:
- UserInterface/Views/NetworkTimelineOverviewGraph.js:
- UserInterface/Views/NetworkTimelineView.js:
- UserInterface/Views/OverviewTimelineView.js:
- UserInterface/Views/RenderingFrameTimelineOverview.js:
- UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
- UserInterface/Views/RenderingFrameTimelineView.js:
- UserInterface/Views/ScriptTimelineOverviewGraph.js:
- UserInterface/Views/ScriptTimelineView.js:
- UserInterface/Views/TimelineOverview.js:
- UserInterface/Views/TimelineOverviewGraph.js:
- UserInterface/Views/TimelineRecordBar.js:
- UserInterface/Views/TimelineRecordFrame.js:
- UserInterface/Views/TimelineRecordingContentView.js:
- UserInterface/Views/TimelineRuler.js:
- UserInterface/Views/TimelineTabContentView.js:
- UserInterface/Views/TimelineView.js:
- 3:59 PM Changeset in webkit [187688] by
-
- 6 edits in trunk/Source/WebCore
[iOS] use a media-specific user gesture check
https://bugs.webkit.org/show_bug.cgi?id=147509
Reviewed by Jer Noble.
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::processingUserGestureForMedia): New.
- bindings/js/ScriptController.h:
- dom/UserGestureIndicator.cpp:
(WebCore::isDefinite): Allow DefinitelyProcessingMediaUserGesture.
(WebCore::UserGestureIndicator::processingUserGestureForMedia): New.
- dom/UserGestureIndicator.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::load): Use ScriptController::processingUserGestureForMedia instead of
ScriptController::processingUserGesture
(WebCore::HTMLMediaElement::play): Ditto.
- 3:43 PM Changeset in webkit [187687] by
-
- 2 edits in trunk/Source/WebCore
Crashes under HTMLMediaElement::updateActiveTextTrackCues() when destroying CachedPage.
<https://webkit.org/b/147506>
<rdar://problem/21939014>
Reviewed by Chris Dumez.
Don't mess with the media element's text tracks below its ActiveDOMObject::stop()
implementation, since that may cause DOM mutations.
I don't have a repro or a test for this, but plenty of crash logs to indicate that
we're getting ourselves into trouble by modifying the DOM during CachedPage teardown.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
- 3:34 PM Changeset in webkit [187686] by
-
- 2 edits in trunk/Source/WebCore
[iOS] DOMNode preview snapshot rects are wrong for user-select: none links
https://bugs.webkit.org/show_bug.cgi?id=147513
<rdar://problem/22083354>
Reviewed by Simon Fraser.
- bindings/objc/DOM.mm:
(-[DOMNode getPreviewSnapshotImage:andRects:]):
Use the same code as WebKit2 to compute the fallback rect (if TextIndicator fails),
asking the RenderObject (or RenderImage) for its bounding box instead of using the
(often wrong) Range bounding rect.
Make sure to use the fallback rect *any* time TextIndicator fails (before
we would return no rects at all if TextIndicator::createWithRange returned null,
and the fallback rect if it returned with an empty image).
Inverse-page-scale the margin, to match the appearance in WebKit2.
- 3:24 PM Changeset in webkit [187685] by
-
- 3 edits3 adds in trunk
[SVG -> OTF Converter] Crash when converting Arabic fonts
https://bugs.webkit.org/show_bug.cgi?id=147510
Reviewed by Anders Carlsson.
Source/WebCore:
SVGToOTFFontConverter::compareCodepointsLexicographically() wasn't transitive.
Test: fast/text/arabic-duplicate-glyph-font.html
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
LayoutTests:
- fast/text/arabic-duplicate-glyph-font-expected.txt: Added.
- fast/text/arabic-duplicate-glyph-font.html: Added.
- fast/text/resources/arabic-duplicate-glyph-font.svg: Added.
- 3:20 PM Changeset in webkit [187684] by
-
- 3 edits in trunk/Source/WebCore
Rename AVPlayerLayerView to _AVPlayerLayerView.
https://bugs.webkit.org/show_bug.cgi?id=147399
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-31
Reviewed by Eric Carlson.
Change class name AVPlayerLayerView to match change in AVKit SPI.
This prevents conflicts with 3rd party apps.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebAVPlayerLayerView_dealloc):
(getWebAVPlayerLayerViewClass):
- platform/spi/cocoa/AVKitSPI.h:
- 2:40 PM Changeset in webkit [187683] by
-
- 2 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: REGRESSION(r187676): Broke stress/tail-call-no-stack-overflow.js
https://bugs.webkit.org/show_bug.cgi?id=147507
Reviewed by Basile Clement.
Changed strictLoopArityFixup1 and strictLoopArityFixup2 to recursively call
themselves instead of nonexistent strictLoopArityFixup.
- tests/stress/tail-call-no-stack-overflow.js:
(strictLoopArityFixup1):
(strictLoopArityFixup2):
- 2:26 PM Changeset in webkit [187682] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed parameter name typo fix.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
- 2:16 PM Changeset in webkit [187681] by
-
- 3 edits in trunk/Source/WebCore
ImageBufferDataCG should not add IOSurfaces to the pool
https://bugs.webkit.org/show_bug.cgi?id=147494
Reviewed by Tim Horton.
ImageBufferDataCG should not add IOSurfaces to the pool as it is not
safe. IOSurfaceIsInUse() does not return accurate result for those
surfaces.
This is a partial revert of r181301.
- platform/graphics/cg/ImageBufferDataCG.cpp:
(WebCore::ImageBufferData::~ImageBufferData): Deleted.
- platform/graphics/cg/ImageBufferDataCG.h:
- 2:05 PM Changeset in webkit [187680] by
-
- 25 edits2 adds in trunk
ES6 class syntax should use block scoping
https://bugs.webkit.org/show_bug.cgi?id=142567
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We treat class declarations like we do "let" declarations.
The class name is under TDZ until the class declaration
statement is evaluated. Class declarations also follow
the same rules as "let": No duplicate definitions inside
a lexical environment.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createClassDeclStatement):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClassDeclaration):
- tests/stress/class-syntax-block-scoping.js: Added.
(assert):
(truth):
(.):
- tests/stress/class-syntax-definition-semantics.js: Added.
(shouldBeSyntaxError):
(shouldNotBeSyntaxError):
(truth):
- tests/stress/class-syntax-tdz.js:
(assert):
(shouldThrowTDZ):
(truth):
(.):
LayoutTests:
- js/class-constructor-return-expected.txt:
- js/class-syntax-call-expected.txt:
- js/class-syntax-declaration-expected.txt:
- js/class-syntax-default-constructor-expected.txt:
- js/class-syntax-extends-expected.txt:
- js/class-syntax-name-expected.txt:
- js/class-syntax-super-expected.txt:
- js/script-tests/class-constructor-return.js:
(shouldThrow):
(shouldNotThrow):
(shouldBeTrue):
(shouldBeFalse):
- js/script-tests/class-syntax-call.js:
(A):
(B):
(shouldThrow):
(shouldNotThrow):
- js/script-tests/class-syntax-declaration.js:
(shouldThrow):
(shouldNotThrow):
(shouldBe):
- js/script-tests/class-syntax-default-constructor.js:
(shouldThrow):
(shouldBe):
(shouldBeTrue):
(assert):
(A):
(B):
- js/script-tests/class-syntax-extends.js:
(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(Base):
(Base.prototype.baseMethod):
- js/script-tests/class-syntax-name.js:
(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(runTestShouldBe):
- js/script-tests/class-syntax-super.js:
(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):
- 1:38 PM Changeset in webkit [187679] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187675. rdar://problem/21632211
- 1:36 PM Changeset in webkit [187678] by
-
- 3 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Emit a single callee-save restoration for fast and slow tail call paths
https://bugs.webkit.org/show_bug.cgi?id=147501
Reviewed by Michael Saboff.
We are currently emitting this twice for no reason.
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- 1:34 PM Changeset in webkit [187677] by
-
- 9 edits5 adds in trunk/Source/JavaScriptCore
Implement WebAssembly module parser
https://bugs.webkit.org/show_bug.cgi?id=147293
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-31
Reviewed by Mark Lam.
Re-landing after fix for the "..\..\jsc.cpp(46): fatal error C1083: Cannot open
include file: 'JSWASMModule.h'" issue on Windows.
Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs
<https://github.com/WebAssembly/polyfill-prototype-1>. This patch only checks
the magic number at the beginning of the files. Parsing of the rest will be
implemented in a subsequent patch.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jsc.cpp:
(GlobalObject::finishCreation):
(functionLoadWebAssembly):
- parser/SourceProvider.h:
(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::data):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::wasmModuleStructure):
- wasm/WASMMagicNumber.h: Added.
- wasm/WASMModuleParser.cpp: Added.
(JSC::WASMModuleParser::WASMModuleParser):
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::parseWebAssembly):
- wasm/WASMModuleParser.h: Added.
- wasm/WASMReader.cpp: Added.
(JSC::WASMReader::readUnsignedInt32):
(JSC::WASMReader::readFloat):
(JSC::WASMReader::readDouble):
- wasm/WASMReader.h: Added.
(JSC::WASMReader::WASMReader):
- 1:31 PM Changeset in webkit [187676] by
-
- 6 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Don't waste stack space when arity fixup was performed
https://bugs.webkit.org/show_bug.cgi?id=147447
Reviewed by Michael Saboff.
r187618 tried to handle this, but did not include the LLInt and did it
wrong anyway. When making a call, the caller first aligns the callee's
frame, then makes the call. If the callee later performs arity fixup,
it does not try to reuse the potential slot left empty by the caller's
frame alignment: instead, it aligns the parameters - arguments delta.
So when trying to find out where our frame starts, we should replicate
this behavior, which we were previously not doing and was the cause of
https://bugs.webkit.org/show_bug.cgi?id=147491.
While here, I also removed the extra slot that used to save the
returnPC for the arity fixup return thunk (that we got rid of in
https://bugs.webkit.org/show_bug.cgi?id=146847) and was now just
wasting stack space.
- jit/CCallHelpers.h:
- jit/ThunkGenerators.cpp:
(JSC::arityFixupGenerator):
- llint/LowLevelInterpreter.asm:
- runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::arityCheckFor):
- tests/stress/tail-call-no-stack-overflow.js:
(strictLoopArityFixup1):
(strictLoopArityFixup2):
- 1:21 PM Changeset in webkit [187675] by
-
- 2 edits in trunk/Source/WebCore
CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
https://bugs.webkit.org/show_bug.cgi?id=147485
Rubber-stamped by Joseph Pecoraro.
Follow-up test crash fix: call superclass's contextDestroyed() which allows the
m_scriptExecutionContext variable to be cleared.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::contextDestroyed):
- 1:17 PM Changeset in webkit [187674] by
-
- 2 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: REGRESSION(r187639): Need to restore callee saves in LLInt before tail call
https://bugs.webkit.org/show_bug.cgi?id=147500
Reviewed by Basile Clement.
Restore callee saves at the head of the prepareForTailCall() macro.
- llint/LowLevelInterpreter.asm:
- 1:15 PM Changeset in webkit [187673] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187655. rdar://problem/21632211
- 1:15 PM Changeset in webkit [187672] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187630. rdar://problem/18835799
- 1:15 PM Changeset in webkit [187671] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187614. rdar://problem/22064327
- 1:01 PM Changeset in webkit [187670] by
-
- 2 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows
https://bugs.webkit.org/show_bug.cgi?id=147499
Reviewed by Basile Clement.
For X86-64, Windows, regT0 is free so use that register instead of regT5.
- jit/ThunkGenerators.cpp:
(JSC::arityFixupGenerator):
- 12:43 PM Changeset in webkit [187669] by
-
- 2 edits in trunk/Source/WebKit/mac
REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
<rdar://problem/22060183> and https://bugs.webkit.org/show_bug.cgi?id=147497
Reviewed by Tim Horton.
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.
Instead do a [[retain] autorelease] on it while still valid.
- 12:25 PM Changeset in webkit [187668] by
-
- 2 edits in trunk/Source/WebCore
Only generate "themeWin*" UserAgentStyleSheet constants for Windows builds
https://bugs.webkit.org/show_bug.cgi?id=147378
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-31
Reviewed by Alex Christensen.
- DerivedSources.make:
Only include windows user agent style sheets for Windows OSes.
- 11:41 AM Changeset in webkit [187667] by
-
- 2 edits1 copy in branches/safari-601.1-branch/Source/JavaScriptCore
Merged r187579. rdar://problem/21668986
- 11:38 AM Changeset in webkit [187666] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187557. rdar://problem/21412186
- 11:33 AM Changeset in webkit [187665] by
-
- 8 edits in branches/safari-601.1-branch
Merged r187556. rdar://problem/21771620
- 11:30 AM Changeset in webkit [187664] by
-
- 5 edits2 copies in branches/safari-601.1-branch
Merged r187535. rdar://problem/21852603
- 11:22 AM Changeset in webkit [187663] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187530. rdar://problem/21833987
- 11:19 AM Changeset in webkit [187662] by
-
- 3 edits2 copies in branches/safari-601.1-branch
Merged r187525. rdar://problem/22022011
- 11:10 AM Changeset in webkit [187661] by
-
- 26 edits in branches/safari-601.1-branch/LayoutTests
Merged r187523. rdar://problem/22010303
- 11:08 AM Changeset in webkit [187660] by
-
- 13 edits in branches/safari-601.1-branch/Source
Merged r187522. rdar://problem/19892014
- 11:07 AM Changeset in webkit [187659] by
-
- 18 edits in trunk
Prepare for debug CMake builds on Windows.
https://bugs.webkit.org/show_bug.cgi?id=147484
Reviewed by Tim Horton.
.:
- Source/cmake/OptionsWindows.cmake:
Don't use debug runtimes in debug builds because the dependencies are only built with multithreaded runtimes.
Source/WebCore:
In order to get debug builds to link on Windows with CMake, we will need to use AllInOnes.
This patch includes more files in the AllInOnes and removes some duplicate code.
- WebCore.vcxproj/WebCore.vcxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- css/CSSAllInOne.cpp:
Many files were added to the AllInOne files. They should not be included in the Visual Studio solutions.
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::create):
Use CSSParserString::equalIgnoringCase to avoid ambiguous calls to overloaded functions.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::convertToFloatLength): Deleted.
- css/TransformFunctions.cpp:
(WebCore::transformOperationType):
(WebCore::convertToFloatLength):
- css/TransformFunctions.h:
Removed duplicate convertToFloatLength function.
- html/HTMLElementsAllInOne.cpp:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::compareZIndexFlowThreadController): Renamed from compareZIndex to prevent naming conflicts.
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::compareZIndex): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldRepaintAfterLayout):
(WebCore::compositedWithOwnBackingStore):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::compositedWithOwnBackingStore): Deleted.
Removed duplicate compositedWithOwnBackingStore.
(WebCore::paintScrollbar): Deleted duplicate function.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresScrollLayer):
(WebCore::paintScrollbar):
- rendering/RenderLayerCompositor.h:
- rendering/RenderingAllInOne.cpp:
- 11:01 AM Changeset in webkit [187658] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187521. rdar://problem/22038421
- 10:56 AM Changeset in webkit [187657] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187516. rdar://problem/20847009
- 10:49 AM Changeset in webkit [187656] by
-
- 2 edits in branches/safari-601.1-branch/LayoutTests
Merged r187512. rdar://problem/22010303
- 10:49 AM Changeset in webkit [187655] by
-
- 4 edits in trunk/Source/WebCore
CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
https://bugs.webkit.org/show_bug.cgi?id=147485
Reviewed by Eric Carlson.
CrashLogs indicate a use-after-free of the ScriptExecutionContext (i.e., Document) used by
the GenericTaskQueue objects owned by HTMLMediaElement. When the ScriptExecutionContext
notifies its ActiveDOMObjects that it is about to be destroyed, close() the
GenericTaskQueues so that they can no longer accept new tasks.
Previously, enqueueing a task on a closed GenericTaskQueue ASSERTed in debug builds, but
silently succeeded in release builds. Calling enqueueTask() on a closed GenericTaskQueue is
now a no-op.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::contextDestroyed):
- html/HTMLMediaElement.h:
- platform/GenericTaskQueue.h:
(WebCore::GenericTaskQueue::enqueueTask):
- 10:08 AM Changeset in webkit [187654] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: add test for MediaSession.releaseSession()
https://bugs.webkit.org/show_bug.cgi?id=147478
Reviewed by Eric Carlson.
- media/session/releasing-sessions-expected.txt: Added.
- media/session/releasing-sessions.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 9:59 AM Changeset in webkit [187653] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: add test to ensure next/previous-track event handlers are not fired when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=147477
Reviewed by Eric Carlson.
- media/session/track-media-events-disabled-expected.txt: Added.
- media/session/track-media-events-disabled.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 9:51 AM Changeset in webkit [187652] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: add test to ensure media sessions are in an Idle state after creation
https://bugs.webkit.org/show_bug.cgi?id=147471
Reviewed by Eric Carlson.
- media/session/session-creation-expected.txt: Added.
- media/session/session-creation.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 9:44 AM Changeset in webkit [187651] by
-
- 12 edits in branches/safari-601.1-branch/Source
Merged r187491. rdar://problem/21718407
- 9:42 AM Changeset in webkit [187650] by
-
- 18 edits34 copies2 deletes in branches/safari-601.1-branch
Merged r187489. rdar://problem/22010303
- 9:35 AM Changeset in webkit [187649] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187471. rdar://problem/22021772
- 9:33 AM Changeset in webkit [187648] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187466. rdar://problem/21960398
- 9:25 AM Changeset in webkit [187647] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187462. rdar://problem/22020770
- 9:05 AM Changeset in webkit [187646] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merged r187459. rdar://problem/21701858
- 9:01 AM Changeset in webkit [187645] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187448. rdar://problem/21948230
- 9:00 AM Changeset in webkit [187644] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merged r187379. rdar://problem/21948230
- 8:58 AM Changeset in webkit [187643] by
-
- 9 edits in branches/safari-601.1-branch/Source
Merged r187375. rdar://problem/21948230
- 7:28 AM Changeset in webkit [187642] by
-
- 2 edits in trunk/Tools
[EFL] Fix pixman build on ARM with GCC 4.9.3
https://bugs.webkit.org/show_bug.cgi?id=147224
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
- 5:24 AM Changeset in webkit [187641] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] NPAPI code crashes on Wayland
https://bugs.webkit.org/show_bug.cgi?id=147297
Reviewed by Žan Doberšek.
Do not crete NPAPI plugins when runing on Wayland, since they are
not supported. ENABLE_NETSCAPE_PLUGIN_API option used to be
incompatible with building with the Wayland target, but now that
we allow to build X11 and Wayland targets at the same time, we
need runtime checks to avoid creating NPAPI plugins in Wayland.
- UIProcess/API/gtk/WebKitSettings.cpp:
(webkit_settings_set_enable_plugins): Do not allow to change the
setting when running in Wayland.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): Initialize
EnablePlugins preference to false when running in Wayland.
- 1:06 AM Changeset in webkit [187640] by
-
- 5 edits in trunk/Source/WebCore
[GTK] Have DataObjectGtk::unknownTypes() return a reference to the HashMap object
https://bugs.webkit.org/show_bug.cgi?id=147401
Reviewed by Carlos Garcia Campos.
Don't copy the DataObjectGtk::m_unknownTypes HashMap on every retrieval through
DataObjectGtk::unknownTypes(). The range-based for-loops that iterate over the
map in PasteboardGtk.cpp and PasteboardHelper.cpp are also cleaned up.
- platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::unknownTypes):
- platform/gtk/DataObjectGtk.h:
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writePasteboard):
(WebCore::Pasteboard::types):
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):
Jul 30, 2015:
- 11:02 PM Changeset in webkit [187639] by
-
- 33 edits2 adds in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: LLint, Baseline and DFG JIT should save & restore platform's callee-save registers
https://bugs.webkit.org/show_bug.cgi?id=146946
Reviewed by Basile Clement.
We save platform callee save registers right below the call frame header, in the location(s)
starting with VirtualRegister 0. Allocated local space in the bytecode compiler.
This space is the maximum space needed for the callee registers that the LLInt or baseline JIT
will used, rounded up to number of VirtualRegisters. The LLInt explicitly saves and restores
the registers in the functions preserveCalleeSavesUsedByLLInt and restoreCalleeSavesUsedByLLInt.
The baseline and DFG JITs saves and restores callee saves registers by what registers are included
in m_calleeSaveRegisters in the code block.
Added code to transition callee saves from one VM's format to the another as part of OSR entry and
OSR exit. Added a helper class RegisterSaveMap that has the cannonical locations for a set of
saved registers. This is used not only to save and restore registers on function entry and exit,
but also to handle OSR entry and exit cases.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
Added RegisterSaveMap to build configurations.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setCalleeSaveRegisters):
(JSC::roundCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::calleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::countReoptimization):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfLLIntBaselineCalleeSaveRegisters):
(JSC::CodeBlock::calleeSaveRegisters):
(JSC::CodeBlock::llintBaselineCalleeSaveSpaceAsVirtualRegisters):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::numberOfDFGCompiles):
Methods to manage a set of callee save registers. Also to allocate the appropriate
number of VritualRegisters for callee saves.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::allocateCalleeSaveSpace):
- bytecompiler/BytecodeGenerator.h:
Allocate the appropriate number of VritualRegisters for callee saves needed by LLInt or baseline JIT.
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileEntry):
(JSC::DFG::JITCompiler::compileSetupRegistersForEntry):
(JSC::DFG::JITCompiler::compileBody):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
Properly handle VirtualRegisters set aside for LLInt or baseline JIT callee saves.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::storeTrustedValue):
(JSC::AssemblyHelpers::emitSaveCalleeSavesFor):
(JSC::AssemblyHelpers::emitRestoreCalleeSavesFor):
(JSC::AssemblyHelpers::emitSaveCalleeSaves):
(JSC::AssemblyHelpers::emitRestoreCalleeSaves):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer):
(JSC::AssemblyHelpers::emitMaterializeTagCheckRegisters):
(JSC::AssemblyHelpers::prologueStackPointerDelta):
Functions to save and restore callee save registers in a stack frame or other buffer.
(JSC::AssemblyHelpers::emitMaterializeTagCheckRegisters):
Helper to populate tagTypeNumberRegister and tagMaskRegister with the appropriate
constants.
- jit/GPRInfo.h:
(JSC::GPRInfo::numberOfLLIntBaselineCalleeSaveRegisters):
Added this constant to hold the maximum number of callee save registers that we use in
the LLInt or baseline JIT.
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emitSlow_op_loop_hint):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_end):
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
Emit code to save and restore callee save registers and materialize tagTypeNumberRegister
and tagMaskRegister. Also handle callee saves when tiering up to the DFG.
- jit/RegisterSaveMap.cpp: Added.
(JSC::RegisterSaveMap::RegisterSaveMap):
(JSC::RegisterSaveMap::getIndexFor):
- jit/RegisterSaveMap.h: Added.
(JSC::RegisterSaveMap::size):
(JSC::RegisterSaveMap::has):
(JSC::RegisterSaveMap::maxOffset):
(JSC::RegisterSaveMap::getOffsetFor):
New class to track register offsets in the stack or other memory.
- jit/RegisterSet.cpp:
(JSC::RegisterSet::allVMCalleeSaveRegisters):
(JSC::RegisterSet::baselineCalleeSaveRegisters):
(JSC::RegisterSet::dfgCalleeSaveRegisters):
- jit/RegisterSet.h:
Fixed set of callee save registers for callee save regsiters in any VM, for the baseline JIT and for the
DFG.
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter64.asm:
Save and restor callee saves used by the LLInt. Added code to handle OSR entry.
Changed the LLInt arity fixup to always use the LLInt supplied loop as the LLInt needs to include
callee saves as they need to be saved before calling the slow path that does arity checking since the
PC register is derived from the value in a callee save register. Therefore that callee save needs to
be used before arity fixup, meaning that we need to save the prior contents.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(JSC::VM::calleeSaveRegistersBufferOffset):
(JSC::VM::getAllCalleeSaveRegistersMap):
Provide a RegisterSaveMap that has all registers that might be saved. Added a callee save buffer to be
used for OSR exit and for exception processing in a future patch.
- 8:48 PM Changeset in webkit [187638] by
-
- 3 edits in trunk/Source/WebCore
RenderTheme::paintBorderOnly and paintDecorations should take RenderBox instead of RenderObject.
https://bugs.webkit.org/show_bug.cgi?id=147470
Reviewed by Simon Fraser.
Tighten the code so that RenderTheme paint functions take RenderBox instead of RenderObject.
No change in functionality.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
- rendering/RenderTheme.h:
- 8:40 PM Changeset in webkit [187637] by
-
- 6 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Eliminate rdi from temp register list for X86-64 Windows
https://bugs.webkit.org/show_bug.cgi?id=147461
Reviewed by Basile Clement.
Eliminated rdi from the list of temporary registers for X86-64 Windows as it
is a callee saves register. This reduced the number of temporary registers
for X86-64 Windows. Since the LLInt needs 6 available registers in a couple
of places, added a register alias called extraTempReg which is t0 on X86-64
Windows and t5 on all other platforms.
As a result of this change, I changed the "PC" register in the LLInt from t5
to t4.
- jit/GPRInfo.h:
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- offlineasm/x86.rb:
- 7:07 PM Changeset in webkit [187636] by
-
- 1 copy in tags/Safari-600.8.9
New tag.
- 7:06 PM Changeset in webkit [187635] by
-
- 1 copy in tags/Safari-600.1.4.17.8
New tag.
- 6:55 PM Changeset in webkit [187634] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Better share objects generated from timeline events (Records)
https://bugs.webkit.org/show_bug.cgi?id=147029
Reviewed by Brian Burg.
This patch changes the way TimelineManager processes events, preserving the event hierarchy after
converting payloads to TimelineRecord objects by retaining parent-child relationships between records.
This eliminates the need for RenderingFrameTimelineRecord objects to create a separate copy of their child
records, and provides richer data for the Timelines UI.
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype.eventRecorded):
Track the parent TimelineRecord as child record payloads are unpacked, and create
a hierarchy of TimelineRecords that mirrors the original event payload hierarchy.
(WebInspector.TimelineManager.prototype._processRecord):
RenderingFrameTimelineRecord is now processed like any other event.
(WebInspector.TimelineManager.prototype._processNestedRecords): Deleted.
Reverted back to a single pass over the incoming timeline event payload.
- UserInterface/Models/LayoutTimelineRecord.js:
(WebInspector.LayoutTimelineRecord):
(WebInspector.LayoutTimelineRecord.prototype.get duringComposite): Deleted.
Removed duringComposite property and constructor parameter. No longer needed.
- UserInterface/Models/RenderingFrameTimelineRecord.js:
(WebInspector.RenderingFrameTimelineRecord.prototype.get children): Deleted.
Removed children property. It now exists on the base class TimelineRecord.
Also removed code that was needed to prevent paint time from being added twice.
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
(WebInspector.ScriptTimelineRecord):
Removed workaround added in:
<https://webkit.org/b/147025> Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property
- UserInterface/Models/TimelineRecord.js:
(WebInspector.TimelineRecord):
(WebInspector.TimelineRecord.prototype.get children):
Added children property.
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.prototype._processPendingRecords):
Now that we preserve the frame's child record hierarchy, we process the entire tree,
yielding richer data grid output:
Frame X
Styles Recalculated
Layout Invalidated
Composite
Paint
Paint
Compared to the previous output:
Frame X
Styles Recalculated
Layout Invalidated
Composite
Paint
Paint
- 6:49 PM Changeset in webkit [187633] by
-
- 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore
Roll out r186895. rdar://problem/21714851
- 6:43 PM Changeset in webkit [187632] by
-
- 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore
Roll out r187048. rdar://problem/21714851
- 6:40 PM Changeset in webkit [187631] by
-
- 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore
Roll out r187490. rdar://problem/22035036
- 5:52 PM Changeset in webkit [187630] by
-
- 2 edits in trunk/Source/WebCore
[CF] Web process continually eating memory on simple, shared Google Docs spreadsheet.
<https://webkit.org/b/147403>
<rdar://problem/18835799>
Reviewed by Geoffrey Garen.
Make sure we service the CFRunLoop on worker threads, since ports using CoreFoundation
will be scheduling garbage collections and heap sweeps using CFRunLoop timers.
This fix is a stopgap. Long term we need a better design for integrating GC tasks with
with the web worker run loop.
- workers/WorkerRunLoop.cpp:
(WebCore::WorkerRunLoop::runInMode): Instead of sleeping forever, calculate a better
wakeup deadline by asking the CFRunLoop when its next timer will fire. Then, when a
timeout occurs, call CFRunLoopRunInMode (with seconds=0) to service pending timers.
- 5:43 PM Changeset in webkit [187629] by
-
- 12 edits2 adds in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Add enums for type-safety
https://bugs.webkit.org/show_bug.cgi?id=147475
Reviewed by Michael Saboff.
This adds:
- A CallMode enum to distinguish tail calls from regular calls from construct
- A FrameAction enum to indicate whether to keep or reuse the call frame. It also changes JITOperations.h to correctly use this to tell slowPathFor to *not* trash the frame on a regular call (before r187505, this was statically known in slowPathFor).
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::repatchNearCall):
- assembler/CodeLocation.h:
(JSC::CodeLocationNearCall::CodeLocationNearCall):
(JSC::CodeLocationNearCall::callMode):
(JSC::CodeLocationCommon::nearCallAtOffset):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::locationOfNearCall):
- bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::callModeFor):
(JSC::CallLinkInfo::callMode):
(JSC::CallLinkInfo::isTailCall):
(JSC::CallLinkInfo::isVarargs):
- bytecode/CallMode.cpp: Added.
(WTF::printInternal):
- bytecode/CallMode.h: Added.
- jit/JITOperations.cpp:
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
(JSC::virtualThunkFor):
- 5:37 PM Changeset in webkit [187628] by
-
- 2 edits in branches/safari-600.8-branch/Source/WebCore
Roll out r186863. rdar://problem/21714843
- 5:17 PM Changeset in webkit [187627] by
-
- 6 edits in trunk/Source/WebKit2
LayoutTests/inspector frequently run slow and timeout when run in WebKit2 but not WebKit1
https://bugs.webkit.org/show_bug.cgi?id=147456
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-30
Reviewed by Timothy Hatcher.
By default, WebKit2 WebPage's on PLATFORM(COCOA) enabling DOM Timer
throttling. Under testing, this ends up impacting Web Inspector
tests that create their own WKWebView which never gets displayed
and so gets throttled. Disable throttling on the Inspector's view
during testing.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _hiddenPageDOMTimerThrottlingEnabled]):
(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):
SPI to toggle DOM timer throttling.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isUnderTest):
Provide a way to get if we are under test, and set it before
calling into the platform method.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
When testing, disable timer throttling.
- 5:12 PM Changeset in webkit [187626] by
-
- 13 edits in trunk/Source/WebCore
Move locale information into FontDescription
https://bugs.webkit.org/show_bug.cgi?id=147457
Reviewed by Andreas Kling.
Currently, the "lang" attribute on a node sets locale information in RenderStyle.
Font selection is sensitive to this locale information, and occurs deep within
platform/ code, far away from RenderStyle. Because every RenderStyle owns a
FontDescription, and font selection can consult with FontDescriptions, it makes
sense to move the variable from RenderStyle to FontDescription, and provide
convenience methods on RenderStyle which inspect its FontDescription for locale
information.
This patch is in preparation for correctly obeying locale information when
performing font fallback.
No new tests because there is no behavior change.
- css/CSSPropertyNames.in:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitLocale):
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
(WebCore::FontDescriptionKey::operator==):
- platform/graphics/FontCascade.cpp:
- platform/graphics/FontDescription.cpp:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::setLocale):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::locale):
(WebCore::FontDescription::initialLocale):
(WebCore::FontDescription::operator==):
(WebCore::FontDescription::FontDescription): Deleted.
(WebCore::FontDescription::setScript): Deleted.
- platform/text/LocaleToScriptMappingDefault.cpp:
(WebCore::localeToScriptCodeForFontSelection):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout): Deleted.
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Deleted.
(WebCore::StyleRareInheritedData::operator==): Deleted.
- rendering/style/StyleRareInheritedData.h:
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- 4:56 PM Changeset in webkit [187625] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Support smart-pasting in the Rules sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=147362
Reviewed by Timothy Hatcher.
When pasting over the selector, if the pasted text matches CSS rule
formatting, replace the selected rule with the selector and text in
the pasted data.
- UserInterface/Models/DOMNodeStyles.js:
(WebInspector.DOMNodeStyles.prototype.changeRule.changeCompleted):
(WebInspector.DOMNodeStyles.prototype.changeRule.styleChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule.changeText):
(WebInspector.DOMNodeStyles.prototype.changeRule.ruleSelectorChanged):
(WebInspector.DOMNodeStyles.prototype.changeRule):
- UserInterface/Views/CSSStyleDeclarationSection.js:
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste.parseTextForRule):
(WebInspector.CSSStyleDeclarationSection.prototype._handleSelectorPaste):
(WebInspector.CSSStyleDeclarationSection):
- 4:51 PM Changeset in webkit [187624] by
-
- 2 edits in trunk/Tools
Add support for window.open to WK1BrowserWindowController
https://bugs.webkit.org/show_bug.cgi?id=147474
Reviewed by Dan Bernstein.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
Set javaScriptCanOpenWindowsAutomatically to YES.
If this becomes a nuisance, we can always add a menu item to toggle this.
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
Implement this UI delegate method.
- 4:47 PM Changeset in webkit [187623] by
-
- 2 edits in trunk/Tools
Undo stray commit.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
- 4:46 PM Changeset in webkit [187622] by
-
- 3 edits in trunk
Remove stray printf.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
- 4:41 PM Changeset in webkit [187621] by
-
- 4 edits in trunk/Source/WebCore
Make Path::apply() take a function reference
https://bugs.webkit.org/show_bug.cgi?id=147472
Reviewed by Anders Carlsson.
Path::apply() should take a const reference to a std::function.
- platform/graphics/Path.h:
- platform/graphics/cairo/PathCairo.cpp:
- platform/graphics/cg/PathCG.cpp:
(WebCore::CGPathApplierToPathApplier):
(WebCore::Path::apply):
- 4:38 PM Changeset in webkit [187620] by
-
- 9 edits3 adds in trunk
Assertion failure when a plug-in loads a resource that redirects somewhere
https://bugs.webkit.org/show_bug.cgi?id=147469
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/plugins/get-url-redirect.html
r186597 moved the call to addPlugInStreamLoader to willSendRequest. This is wrong since
willSendRequest can be invoked more than once.
Fix this by making the initialization phase of NetscapePlugInStreamLoader be more like
SubresourceLoader where we only call addPlugInStreamLoader once we've successfully initialized
the loader, and only call removePlugInStreamLoader if we've called addPlugInStreamLoader.
Also change addPlugInStreamLoader and removePlugInStreamLoader to take references.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::addPlugInStreamLoader):
(WebCore::DocumentLoader::removePlugInStreamLoader):
- loader/DocumentLoader.h:
- loader/NetscapePlugInStreamLoader.cpp:
(WebCore::NetscapePlugInStreamLoader::create):
(WebCore::NetscapePlugInStreamLoader::init):
(WebCore::NetscapePlugInStreamLoader::didFinishLoading):
(WebCore::NetscapePlugInStreamLoader::didFail):
(WebCore::NetscapePlugInStreamLoader::didCancel):
(WebCore::NetscapePlugInStreamLoader::notifyDone):
- loader/NetscapePlugInStreamLoader.h:
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest): Deleted.
- loader/ResourceLoader.h:
(WebCore::ResourceLoader::isPlugInStreamLoader): Deleted.
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
LayoutTests:
Add a test.
- http/tests/plugins/get-url-redirect-expected.txt: Added.
- http/tests/plugins/get-url-redirect.html: Added.
- http/tests/plugins/resources/redirection-response.php: Added.
- 4:25 PM Changeset in webkit [187619] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix typo in frame duration filtering console.assert message
https://bugs.webkit.org/show_bug.cgi?id=147458
Rubber-stamped by Joseph Pecoraro.
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView.displayNameForDurationFilter):
- 4:19 PM Changeset in webkit [187618] by
-
- 8 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: Don't waste stack space when arity fixup was performed
https://bugs.webkit.org/show_bug.cgi?id=147447
Reviewed by Michael Saboff.
When doing a tail call, we overwrite an amount of stack space based on
the number of arguments in the call frame. If we entered the tail
caller by performing an arity fixup, this is incorrect and leads to
wasted stack space - we must use the CodeBlock's number of parameters
instead in that case.
This patch is also moving the prepareForTailCall() function from
jit/ThunkGenerators.h to the place where it should have always been,
namely jit/CCallHelpers.h
- jit/CCallHelpers.h:
(JSC::CCallHelpers::prepareForTailCallSlow):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/Repatch.cpp:
(JSC::linkPolymorphicCall):
- jit/ThunkGenerators.cpp:
(JSC::slowPathFor):
(JSC::virtualThunkFor):
- jit/ThunkGenerators.h:
- tests/stress/tail-call-no-stack-overflow.js:
(strictLoopArityFixup):
- 4:17 PM Changeset in webkit [187617] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Pressing 'done' in fullscreen video sometimes does nothing; stuck in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=147367
Reviewed by Eric Carlson.
During the request to exit fullscreen, the video element's m_videoFullscreenMode variable
is set, but no exitFullscreen() request is sent up to the UIProcess. Previous threading
issues have been discovered and fixed, but may have been re-introduced (or never fully
fixed in the first place). To solve the bad behavior this threading issue creates, add
a watchdog timer, similar to the one used in the desktop fullscreen controller, to ensure
that if an exit fullscreen request is not acted upon, the UIProcess forcibly exits fullscreen
anyway.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit): Initialize the timer.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Cancel the timer.
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Set the timer.
(WebVideoFullscreenInterfaceAVKit::watchdogTimerFired): Forcibly exit fullscreen mode.
- 4:08 PM Changeset in webkit [187616] by
-
- 2 edits in branches/jsc-tailcall/Source/JavaScriptCore
jsc-tailcall: We should consider a tail call as an exit in the LLInt for the purpose of switching to the JIT
https://bugs.webkit.org/show_bug.cgi?id=147449
Reviewed by Michael Saboff.
- llint/LowLevelInterpreter.asm:
- 4:07 PM Changeset in webkit [187615] by
-
- 3 edits in trunk/Source/WebCore
Clean up makeFontCascadeCacheKey()
https://bugs.webkit.org/show_bug.cgi?id=147430
Reviewed by Benjamin Poulain.
FontDescriptionKey is designed to encapsulate all the cacheable properties of a FontDescription.
However, a higher-level cache, FontCascadeCacheKey, was taking some values from FontDescriptions.
The fact that there wasn't a bug before is just a happy coincidence. This patch moves those bits
from the higher-level cache and puts them into FontDescriptionKey where they belong.
No new tests because there is no behavior change.
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::makeFlagKey):
- platform/graphics/FontCascade.cpp:
(WebCore::operator==):
(WebCore::makeFontSelectorFlags): Deleted.
(WebCore::makeFontCascadeCacheKey): Deleted.
(WebCore::computeFontCascadeCacheHash): Deleted.
- 3:56 PM Changeset in webkit [187614] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Set AirPlay discovery mode to disabled when page is hidden
https://bugs.webkit.org/show_bug.cgi?id=147455
Reviewed by Enrica Casucci.
- UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Set discovery mode to disabled after
the picker has been closed.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Ditto.
- 3:26 PM Changeset in webkit [187613] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Media Session: add support for more telephony interruptions
https://bugs.webkit.org/show_bug.cgi?id=147079
Reviewed by Eric Carlson.
- platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm:
(WebCore::callDidEndRinging): End 'Transient' interruptions.
(WebCore::callDidConnect): Forward this event to media sessions as a 'Content' interruption.
(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions): Register observers for new
notification types.
(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions): Unregister all observers.
- 3:13 PM Changeset in webkit [187612] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: test Play/Pause media control events delivered to non-Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147414
Reviewed by Eric Carlson.
- media/session/play-pause-media-events-in-non-content-sessions-expected.txt: Added.
- media/session/play-pause-media-events-in-non-content-sessions.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 2:58 PM Changeset in webkit [187611] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: test Play/Pause media control events delivered to Content media sessions
https://bugs.webkit.org/show_bug.cgi?id=147413
Reviewed by Eric Carlson.
- media/session/play-pause-media-events-in-content-sessions-expected.txt: Added.
- media/session/play-pause-media-events-in-content-sessions.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 2:50 PM Changeset in webkit [187610] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187490. rdar://problem/21995928
- 2:22 PM Changeset in webkit [187609] by
-
- 45 edits3 copies in trunk
Don't use (Details) when exposing SPI
https://bugs.webkit.org/show_bug.cgi?id=147426
<rdar://problem/22062407>
Reviewed by Dan Bernstein.
If we are declaring the interface without any implementation,
we should use class extensions.
Source/WebCore:
Added three new SPI.h files for NSButtonCell, NSURLConnection and
NSURLRequest.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/ScrollViewMac.mm:
- platform/mac/ThemeMac.mm:
- platform/network/mac/ResourceHandleMac.mm:
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
- platform/spi/cf/CFNetworkSPI.h:
- platform/spi/cocoa/AVKitSPI.h:
- platform/spi/cocoa/CFNSURLConnectionSPI.h:
- platform/spi/cocoa/NSButtonCellSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
- platform/spi/cocoa/NSCalendarDateSPI.h:
- platform/spi/cocoa/NSColorSPI.h:
- platform/spi/cocoa/NSFileManagerSPI.h:
- platform/spi/cocoa/NSStringSPI.h:
- platform/spi/cocoa/NSURLConnectionSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
- platform/spi/cocoa/NSURLDownloadSPI.h:
- platform/spi/cocoa/NSURLRequestSPI.h: Copied from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
- platform/spi/cocoa/QuartzCoreSPI.h:
- platform/spi/cocoa/WebFilterEvaluatorSPI.h:
- platform/spi/ios/CoreUISPI.h:
- platform/spi/ios/LaunchServicesSPI.h:
- platform/spi/ios/MediaPlayerSPI.h:
- platform/spi/ios/QuickLookSPI.h:
- platform/spi/ios/UIColorSPI.h:
- platform/spi/mac/QuickLookMacSPI.h:
- rendering/RenderThemeMac.mm:
Source/WebKit/mac:
- WebView/WebFrameView.mm:
- WebView/WebPDFView.mm:
Source/WebKit2:
- Platform/spi/ios/AssertionServicesSPI.h:
- Platform/spi/ios/CorePDFSPI.h:
- Platform/spi/ios/DataDetectorsUISPI.h:
- Platform/spi/ios/ManagedConfigurationSPI.h:
- Platform/spi/ios/UIKitSPI.h:
- Shared/API/Cocoa/WKRemoteObjectCoder.mm:
- Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
- UIProcess/_WKWebViewPrintFormatter.mm:
- UIProcess/mac/WebPageProxyMac.mm:
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
- DumpRenderTree/mac/EventSendingController.mm:
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
- WebKitTestRunner/ios/PlatformWebViewIOS.mm:
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
- WebKitTestRunner/mac/TestControllerMac.mm:
- 2:20 PM Changeset in webkit [187608] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187565. rdar://problem/22061043
- 2:20 PM Changeset in webkit [187607] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187517. rdar://problem/21645007
- 2:20 PM Changeset in webkit [187606] by
-
- 9 edits2 adds in branches/safari-601.1-branch
Merge r187278. rdar://problem/19908029
- 1:57 PM Changeset in webkit [187605] by
-
- 23 edits in trunk
Replace Google App Engine with AppScale
https://bugs.webkit.org/show_bug.cgi?id=147178
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-07-30
Reviewed by Daniel Bates.
Tools:
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
(BubbleQueueServer):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
(TestHistory):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
- TestResultServer/app.yaml: Ditto
- Scripts/webkitpy/common/config/urls.py:
- TestResultServer/main.py:
- TestResultServer/static-dashboards/dashboard_base.js:
- TestResultServer/static-dashboards/loader.js:
Websites/bugs.webkit.org:
- code-review.js:
- template/en/default/attachment/edit.html.tmpl:
- template/en/default/attachment/list.html.tmpl:
- template/en/default/attachment/reviewform.html.tmpl:
LayoutTests:
- fast/harness/results.html:
- 1:23 PM Changeset in webkit [187604] by
-
- 4 edits2 adds in branches/safari-601.1-branch
Merge r187504. rdar://problem/21915355
- 1:23 PM Changeset in webkit [187603] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187478. rdar://problem/21838764
- 1:20 PM Changeset in webkit [187602] by
-
- 4 edits2 deletes in trunk/Source/WebCore
Remove LegacyCACFLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=147388
Reviewed by Geoffrey Garen.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::create):
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.cpp: Removed.
- platform/graphics/ca/win/LegacyCACFLayerTreeHost.h: Removed.
- 1:15 PM Changeset in webkit [187601] by
-
- 5 edits in trunk/Source/WebCore
Fix Windows build after r187587.
- loader/SubresourceLoader.h:
- loader/cache/CachedResource.h:
- platform/graphics/Font.h:
(WebCore::Font::DerivedFontData::DerivedFontData):
- rendering/RenderLayerFilterInfo.h:
Visual Studio doesn't like making std::unique_ptrs of private nested classes.
It tries to make a std::default_delete with the private class as a template parameter.
- 12:40 PM Changeset in webkit [187600] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][NetworkCache] Stop closing files on the main thread
https://bugs.webkit.org/show_bug.cgi?id=147410
Reviewed by Andreas Kling.
After r186510, we no longer open cache files on the main thread.
However, we still close them on the main thread. This patch makes
sure we close the files on another thread instead.
- NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::IOChannel):
- 12:26 PM Changeset in webkit [187599] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Regression: %c is broken for console.group
https://bugs.webkit.org/show_bug.cgi?id=147436
Reviewed by Timothy Hatcher.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
- 12:24 PM Changeset in webkit [187598] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Add special case for deleting the next character when editing rules in the CSS Sidebar
https://bugs.webkit.org/show_bug.cgi?id=147442
Reviewed by Timothy Hatcher.
If the cursor is on the first position of the first line in a CSS Rule and that line
has no content, delete the line instead of doing nothing.
- UserInterface/Views/CSSStyleDeclarationTextEditor.js:
(WebInspector.CSSStyleDeclarationTextEditor.prototype._handleBeforeChange):
- 12:13 PM Changeset in webkit [187597] by
-
- 15 edits in trunk/Source
Convert Path applier to use std::function
https://bugs.webkit.org/show_bug.cgi?id=147368
Reviewed by Sam Weinig.
Use std::function for Path::apply().
Source/WebCore:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(ConvertPathToScreenSpaceFunction): Deleted.
- inspector/InspectorOverlay.cpp:
(WebCore::appendPathSegment):
(WebCore::buildObjectForShapeOutside):
- platform/graphics/Path.cpp:
(WebCore::Path::length):
(WebCore::Path::traversalStateAtLength):
(WebCore::pathLengthApplierFunction): Deleted.
- platform/graphics/Path.h:
- platform/graphics/cairo/FontCairo.cpp:
(WebCore::findPathIntersections):
(WebCore::FontCascade::dashesForIntersectionsWithRect):
- platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::apply):
- platform/graphics/cg/PathCG.cpp:
(WebCore::CGPathApplierToPathApplier):
(WebCore::Path::apply):
- rendering/svg/RenderSVGPath.cpp:
(WebCore::RenderSVGPath::updateZeroLengthSubpaths):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::processMarkerPositions):
- rendering/svg/SVGMarkerData.h:
(WebCore::SVGMarkerData::updateFromPathElement):
- rendering/svg/SVGSubpathData.h:
(WebCore::SVGSubpathData::updateFromPathElement):
(WebCore::SVGSubpathData::SVGSubpathData): Deleted.
- svg/SVGPathUtilities.cpp:
(WebCore::pathIteratorForBuildingString):
(WebCore::buildStringFromPath):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::pathEncodeApplierFunction):
(IPC::ArgumentCoder<Path>::encode):
(IPC::pathPointCountApplierFunction): Deleted.
- 11:47 AM Changeset in webkit [187596] by
-
- 12 edits in trunk
[EFL] Enable IndexedDB based on DatabaseProcess
https://bugs.webkit.org/show_bug.cgi?id=147221
Patch by Joonghun Park <jh718.park@samsung.com> on 2015-07-30
Reviewed by Csaba Osztrogonác.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebKit2:
- DatabaseProcess/efl/DatabaseProcessMainEfl.cpp: Add ecore_init().
Without this call, it leads to crash when launching DatabaseProcess.
- PlatformEfl.cmake: Add missing include_directory.
- Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::executablePathOfDatabaseProcess):
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/efl/WebProcessPoolEfl.cpp:
(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
Add default path for indexedDB sqlite3 db file.
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/efl/TestExpectations: Update IndexedDB test expectations.
- 11:39 AM Changeset in webkit [187595] by
-
- 6 edits in trunk/LayoutTests
aria-liveregions-notifications tests are very flaky
https://bugs.webkit.org/show_bug.cgi?id=147299
<rdar://problem/21998675>
Patch by Nan Wang <n_wang@apple.com> on 2015-07-30
Reviewed by Chris Fleizach.
These tests were flaky because they relied on timer notification callbacks.
Fixed these tests by using different objects to capture the notifications instead.
- platform/mac/TestExpectations:
- platform/mac/accessibility/aria-liveregions-notifications-always-sent-expected.txt:
- platform/mac/accessibility/aria-liveregions-notifications-always-sent.html:
- platform/mac/accessibility/aria-liveregions-notifications-expected.txt:
- platform/mac/accessibility/aria-liveregions-notifications.html:
- 11:36 AM Changeset in webkit [187594] by
-
- 2 edits in trunk/Source/WebKit2
Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
https://bugs.webkit.org/show_bug.cgi?id=147446
Reviewed by Simon Fraser.
Minimize children vector capacity changes in PlatformCALayerRemote::recursiveBuildTransaction()
by leveraging the fact that we know in advance how many layer IDs are going to be added. We
now set the Vector size from the start, instead of clearing it and then growing the vector
capacity when appending the layer IDs one by one.
- WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:
(WebKit::PlatformCALayerRemote::recursiveBuildTransaction):
- 11:32 AM Changeset in webkit [187593] by
-
- 4 edits2 adds in trunk
Selecting in an iframe can cause main page scrolling
https://bugs.webkit.org/show_bug.cgi?id=147431
rdar://problem/19244589
Reviewed by Zalan Bujtas.
Source/WebCore:
The RenderLayer auatoscroll code walks up the RenderLayer hierarchy, crossing
frame boundaries. However, as it crosses into an ancestor frame it failed to
map the target rect into the coordinate space of the new frame, which caused
us to scroll to an incorrect location in that parent frame.
Test: fast/events/autoscroll-in-iframe.html
- rendering/RenderLayer.cpp:
(WebCore::parentLayerCrossFrame): Make the layer a reference, and pass in
an optional rect. When crossing frame boundaries, map the rect from the
contents of the child frame to the contents of the parent frame.
(WebCore::RenderLayer::enclosingScrollableLayer): Pass optional rect.
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::hasScrollableOrRubberbandableAncestor):
- rendering/RenderLayer.h:
LayoutTests:
Test that uses eventSender to select in an iframe after scrolling the
main page.
- fast/events/autoscroll-in-iframe-expected.txt: Added.
- fast/events/autoscroll-in-iframe.html: Added.
- 11:31 AM Changeset in webkit [187592] by
-
- 3 edits in trunk/Source/WebCore
Improve the history logging output
https://bugs.webkit.org/show_bug.cgi?id=147429
Reviewed by Alexey Proskuryakov.
Improve the History log channel output to show which frame is navigating,
print the addresses of the HistoryController and Frame, and print URLs
for everything.
Remove the BackForward log channel which had just one calling location,
and log for pushState/replaceState.
- loader/HistoryController.cpp:
(WebCore::HistoryController::updateForBackForwardNavigation):
(WebCore::HistoryController::updateForReload):
(WebCore::HistoryController::updateForStandardLoad):
(WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
(WebCore::HistoryController::updateForClientRedirect):
(WebCore::HistoryController::updateForCommit):
(WebCore::HistoryController::updateBackForwardListClippedAtTarget):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):
- platform/Logging.h:
- 11:29 AM Changeset in webkit [187591] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add the "wasm" directory to the Additional Include Directories for jsc.exe
https://bugs.webkit.org/show_bug.cgi?id=147443
Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-30
Reviewed by Mark Lam.
This patch should fix the "..\..\jsc.cpp(46): fatal error C1083:
Cannot open include file: 'JSWASMModule.h'" error in the Windows build.
- JavaScriptCore.vcxproj/jsc/jscCommon.props:
- 11:21 AM Changeset in webkit [187590] by
-
- 14 edits in branches/jsc-tailcall/Source/JavaScriptCore
Merged r187505 from trunk.
Simplify call linking
https://bugs.webkit.org/show_bug.cgi?id=147363
Reviewed by Filip Pizlo.
Previously, we were passing both the CallLinkInfo and a
(CodeSpecializationKind, RegisterPreservationMode) pair to the
different call linking slow paths. However, the CallLinkInfo already
has all of that information, and we don't gain anything by having them
in additional static parameters - except possibly a very small
performance gain in presence of inlining. However since those are
already slow paths, this performance loss (if it exists) will not be
visible in practice.
This patch removes the various specialized thunks and JIT operations
for regular and polymorphic call linking with a single thunk and
operation for each case. Moreover, it removes the four specialized
virtual call thunks and operations with one virtual call thunk for each
call link info, allowing for better branch prediction by the CPU and
fixing a pre-existing FIXME.
- bytecode/CallLinkInfo.cpp: (JSC::CallLinkInfo::unlink): (JSC::CallLinkInfo::dummy): Deleted.
- bytecode/CallLinkInfo.h: (JSC::CallLinkInfo::CallLinkInfo): (JSC::CallLinkInfo::registerPreservationMode): (JSC::CallLinkInfo::setUpCallFromFTL): (JSC::CallLinkInfo::setSlowStub): (JSC::CallLinkInfo::clearSlowStub): (JSC::CallLinkInfo::slowStub):
- dfg/DFGDriver.cpp: (JSC::DFG::compileImpl):
- dfg/DFGJITCompiler.cpp: (JSC::DFG::JITCompiler::link):
- ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::link):
- jit/JITCall.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITCall32_64.cpp: (JSC::JIT::compileCallEvalSlowCase): (JSC::JIT::compileOpCall): (JSC::JIT::compileOpCallSlowCase):
- jit/JITOperations.cpp:
- jit/JITOperations.h: (JSC::operationLinkFor): Deleted. (JSC::operationVirtualFor): Deleted. (JSC::operationLinkPolymorphicCallFor): Deleted.
- jit/Repatch.cpp: (JSC::generateByIdStub): (JSC::linkSlowFor): (JSC::linkFor): (JSC::revertCall): (JSC::unlinkFor): (JSC::linkVirtualFor): (JSC::linkPolymorphicCall):
- jit/Repatch.h:
- jit/ThunkGenerators.cpp: (JSC::linkCallThunkGenerator): (JSC::linkPolymorphicCallThunkGenerator): (JSC::virtualThunkFor): (JSC::linkForThunkGenerator): Deleted. (JSC::linkConstructThunkGenerator): Deleted. (JSC::linkCallThatPreservesRegsThunkGenerator): Deleted. (JSC::linkConstructThatPreservesRegsThunkGenerator): Deleted. (JSC::linkPolymorphicCallForThunkGenerator): Deleted. (JSC::linkPolymorphicCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualForThunkGenerator): Deleted. (JSC::virtualCallThunkGenerator): Deleted. (JSC::virtualConstructThunkGenerator): Deleted. (JSC::virtualCallThatPreservesRegsThunkGenerator): Deleted. (JSC::virtualConstructThatPreservesRegsThunkGenerator): Deleted.
- jit/ThunkGenerators.h: (JSC::linkThunkGeneratorFor): Deleted. (JSC::linkPolymorphicCallThunkGeneratorFor): Deleted. (JSC::virtualThunkGeneratorFor): Deleted.
- 10:19 AM Changeset in webkit [187589] by
-
- 2 edits2 adds in trunk/LayoutTests
Media Session: test Next/Previous Track media control events delivered to Content media sessions https://bugs.webkit.org/show_bug.cgi?id=147416
Reviewed by Eric Carlson.
- media/session/track-media-events-in-content-sessions-expected.txt: Added.
- media/session/track-media-events-in-content-sessions.html: Added.
- platform/mac/TestExpectations: Media Session support is disabled by default.
- 10:02 AM Changeset in webkit [187588] by
-
- 5 edits in trunk/Source/WebCore
Media Session: add infrastructure for testing media control events
https://bugs.webkit.org/show_bug.cgi?id=147412
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSessionManager.h:
- testing/Internals.cpp:
(WebCore::Internals::sendMediaControlEvent): Let tests simulate media control events.
- testing/Internals.h:
- testing/Internals.idl:
- 9:25 AM Changeset in webkit [187587] by
-
- 48 edits in trunk/Source
Mark more classes as fast allocated
https://bugs.webkit.org/show_bug.cgi?id=147440
Reviewed by Sam Weinig.
Mark more classes as fast allocated for performance. We heap-allocate
objects of those types throughout the code base.
Source/JavaScriptCore:
- API/JSCallbackObject.h:
- API/ObjCCallbackFunction.mm:
- bytecode/BytecodeKills.h:
- bytecode/BytecodeLivenessAnalysis.h:
- bytecode/CallLinkStatus.h:
- bytecode/FullBytecodeLiveness.h:
- bytecode/SamplingTool.h:
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGBasicBlock.h:
- dfg/DFGBlockMap.h:
- dfg/DFGInPlaceAbstractState.h:
- dfg/DFGThreadData.h:
- heap/HeapVerifier.h:
- heap/SlotVisitor.h:
- parser/Lexer.h:
- runtime/ControlFlowProfiler.h:
- runtime/TypeProfiler.h:
- runtime/TypeProfilerLog.h:
- runtime/Watchdog.h:
Source/WebCore:
- editing/Editor.h:
- history/CachedFrame.h:
- history/CachedPage.h:
- html/parser/HTMLResourcePreloader.h:
- loader/PolicyChecker.h:
- loader/SubresourceLoader.h:
- loader/cache/CachedResource.h:
- page/animation/AnimationController.h:
- page/scrolling/ScrollingConstraints.h:
- page/scrolling/ScrollingStateTree.h:
- platform/graphics/Font.h:
- platform/graphics/GraphicsLayerUpdater.h:
- rendering/FilterEffectRenderer.h:
- rendering/ImageQualityController.h:
- rendering/RenderLayerFilterInfo.h:
- rendering/SimpleLineLayoutResolver.h:
- rendering/shapes/RasterShape.h:
- rendering/shapes/Shape.h:
Source/WebKit2:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
- NetworkProcess/cache/NetworkCacheStorage.h:
- Platform/IPC/MessageRecorder.h:
- Platform/mac/LayerHostingContext.h:
Source/WTF:
- wtf/Bag.h:
- wtf/SegmentedVector.h:
- wtf/SentinelLinkedList.h:
- 9:21 AM Changeset in webkit [187586] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Crashes when SoupSession is destroyed in exit handler
https://bugs.webkit.org/show_bug.cgi?id=145347
Reviewed by Carlos Garcia Campos.
Leak the default SoupSession with NeverDestroyed to avoid races at program exit.
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::defaultSession):
- platform/network/soup/SoupNetworkSession.h:
- 9:16 AM Changeset in webkit [187585] by
-
- 11 edits in trunk
Build AppleWin port with CMake
https://bugs.webkit.org/show_bug.cgi?id=147385
Reviewed by Martin Robinson.
.:
- Source/cmake/OptionsWindows.cmake:
Use the static multithreaded runtime. Based on
http://www.cmake.org/Wiki/CMake_FAQ#How_can_I_build_my_MSVC_application_with_a_static_runtime.3F
Source/WebCore:
- CMakeLists.txt:
Add makesafeseh.asm to 32-bit build. It needs to be after the ADD_PRECOMPILED_HEADER macro
because CMake can only set COMPILE_FLAGS once with set_source_files_properties, and we want
to use that to add /safeseh instead of a precompiled header (which wouldn't be used anyway in assembly).
- PlatformAppleWin.cmake:
- PlatformWin.cmake:
- PlatformWinCairo.cmake:
Added missing source files and libraries.
Source/WebKit:
- PlatformWin.cmake:
Added missing source files and libraries.
Tools:
- WinLauncher/CMakeLists.txt:
Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
- 8:56 AM Changeset in webkit [187584] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r187582.
- accessibility/AccessibilityAllInOne.cpp:
Include new files.
- 7:51 AM Changeset in webkit [187583] by
-
- 6 edits2 adds in trunk
Web Inspector: [Freetype] Allow inspector to retrieve a list of system fonts
https://bugs.webkit.org/show_bug.cgi?id=147018
Reviewed by Carlos Garcia Campos.
Source/WebCore:
No new tests; unskipped inspector/css/get-system-fonts.html
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::patternToFamilies): Added.
(WebCore::FontCache::systemFontFamilies): Implemented.
(WebCore::strongAliasesForFamily): Split some code off to patternToFamilies.
LayoutTests:
- inspector/css/get-system-fonts-expected.txt: Expect some free fonts to be missing....
- inspector/css/get-system-fonts.html: Check for some free fonts.
- platform/gtk/TestExpectations: Unskip the test.
- platform/gtk/inspector/css/get-system-fonts-expected.txt: Added.
- 4:10 AM Changeset in webkit [187582] by
-
- 12 edits6 adds in trunk
AX: VoiceOver unable to access content in malformed trees
https://bugs.webkit.org/show_bug.cgi?id=147295
<rdar://problem/14862892>
Patch by Nan Wang <n_wang@apple.com> on 2015-07-30
Reviewed by Chris Fleizach.
Source/WebCore:
VoiceOver is skipping the content of malformed trees. This fixes the problem
by having the tree check if it has valid children (treeitems) and makes treeitems
check if they are inside trees.
Test: platform/mac/accessibility/malformed-tree.html
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::addChildren):
(WebCore::AccessibilityObject::addChild):
(WebCore::AccessibilityObject::insertChild):
(WebCore::AccessibilityObject::shouldIgnoreAttributeRole):
(WebCore::AccessibilityObject::canHaveChildren):
(WebCore::AccessibilityObject::hasChildren):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/AccessibilityTree.cpp: Added.
(WebCore::AccessibilityTree::AccessibilityTree):
(WebCore::AccessibilityTree::~AccessibilityTree):
(WebCore::AccessibilityTree::create):
(WebCore::AccessibilityTree::computeAccessibilityIsIgnored):
(WebCore::AccessibilityTree::determineAccessibilityRole):
(WebCore::AccessibilityTree::isTreeValid):
- accessibility/AccessibilityTree.h: Added.
- accessibility/AccessibilityTreeItem.cpp: Added.
(WebCore::AccessibilityTreeItem::AccessibilityTreeItem):
(WebCore::AccessibilityTreeItem::~AccessibilityTreeItem):
(WebCore::AccessibilityTreeItem::create):
(WebCore::AccessibilityTreeItem::determineAccessibilityRole):
- accessibility/AccessibilityTreeItem.h: Added.
LayoutTests:
- accessibility/aria-mappings.html:
- accessibility/treeitem-child-exposed-expected.txt:
- accessibility/treeitem-child-exposed.html:
- platform/mac/accessibility/malformed-tree-expected.txt: Added.
- platform/mac/accessibility/malformed-tree.html: Added.
- 2:52 AM Changeset in webkit [187581] by
-
- 2 edits in trunk/LayoutTests
Update JSC's standalone-pre.js for r187575
https://bugs.webkit.org/show_bug.cgi?id=147444
Unreviewed.
- resources/standalone-pre.js:
(shouldBeType):
Copy shouldBeType() from the non-standalone version.
