⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 1, 2015:

5:48 PM Changeset in webkit [187729] by mmaxfield@apple.com
  • 35 edits
    2 adds in trunk

[OS X] Font fallback is not language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

Source/WebCore:

We need to make our font fallback code sensitive to locale.

Test: fast/text/fallback-language-han.html

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:

Updating tests.

  • css3/line-break/line-break-auto-centered-expected.html:
  • css3/line-break/line-break-auto-centered.html:
  • css3/line-break/line-break-auto-postfixes-expected.html:
  • css3/line-break/line-break-auto-postfixes.html:
  • css3/line-break/line-break-loose-centered-expected.html:
  • css3/line-break/line-break-loose-centered.html:
  • css3/line-break/line-break-loose-hyphens-expected.html:
  • css3/line-break/line-break-loose-hyphens.html:
  • css3/line-break/line-break-loose-postfixes-expected.html:
  • css3/line-break/line-break-loose-postfixes.html:
  • css3/line-break/line-break-loose-sound-marks-expected.html:
  • css3/line-break/line-break-loose-sound-marks.html:
  • css3/line-break/line-break-normal-centered-expected.html:
  • css3/line-break/line-break-normal-centered.html:
  • css3/line-break/line-break-normal-hyphens-expected.html:
  • css3/line-break/line-break-normal-hyphens.html:
  • css3/line-break/line-break-normal-postfixes-expected.html:
  • css3/line-break/line-break-normal-postfixes.html:
  • css3/line-break/line-break-normal-sound-marks-expected.html:
  • css3/line-break/line-break-normal-sound-marks.html:
  • css3/line-break/line-break-strict-centered-expected.html:
  • css3/line-break/line-break-strict-centered.html:
  • css3/line-break/line-break-strict-hyphens-expected.html:
  • css3/line-break/line-break-strict-hyphens.html:
  • css3/line-break/line-break-strict-postfixes-expected.html:
  • css3/line-break/line-break-strict-postfixes.html:
  • css3/line-break/line-break-strict-sound-marks-expected.html:
  • css3/line-break/line-break-strict-sound-marks.html:
  • fast/text/fallback-language-han-expected.html: Added.
  • fast/text/fallback-language-han.html: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
4:49 PM Changeset in webkit [187728] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

CharacterFallbackMapKey should be locale-specific
​https://bugs.webkit.org/show_bug.cgi?id=147532

Reviewed by Dean Jackson.

This is in preparation for locale-specific font fallback.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):

4:39 PM Changeset in webkit [187727] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

2:53 PM Changeset in webkit [187726] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit

Fix 64-bit CMake build on Windows.

  • PlatformWin.cmake:

Win64 needs PaintHooks.asm.

1:43 PM Changeset in webkit [187725] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

[Win] Test gardening

Unreviewed

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2015-08-01

  • platform/win/TestExpectations:
1:15 PM Changeset in webkit [187724] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Expand CharacterFallbackMapKey to a struct
​https://bugs.webkit.org/show_bug.cgi?id=147530

Reviewed by Dean Jackson.

This is in prepraration for making this struct locale-specific.

No new tests because there is no behavior change.

  • platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::isHashTableDeletedValue):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::CharacterFallbackMapKeyHash::equal):
(WebCore::Font::systemFallbackFontForCharacter):

1:14 PM Changeset in webkit [187723] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WTF

HashTraits<AtomicString> can use SimpleClassHashTraits
​https://bugs.webkit.org/show_bug.cgi?id=147528

Reviewed by Andreas Kling.

No point in duplicating the code inside SimpleClassHashTraits.

  • wtf/text/AtomicStringHash.h:

(WTF::HashTraits<WTF::AtomicString>::constructDeletedValue): Deleted.
(WTF::HashTraits<WTF::AtomicString>::isDeletedValue): Deleted.

1:08 PM Changeset in webkit [187722] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build after r187721

Unreviewed.

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2015-08-01

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):

12:55 PM Changeset in webkit [187721] by achristensen@apple.com
  • 6 edits in trunk/Source

Fix compile errors with VS2015
​https://bugs.webkit.org/show_bug.cgi?id=147526

Reviewed by Myles Maxfield.

Source/WebCore:

  • bindings/js/JSDOMBinding.h:

(WebCore::createWrapper):
Explicitly call the Ref constructor to avoid unresolved symbols with VS2015.
Otherwise, VS2015 tries to use CSSPrimitiveValue::operator<Ref<CSSPrimitiveValue> > which doesn't exist.

Source/WebKit/win:

  • WebKitDLL.cpp:

(shutDownWebKit):
(loadResourceIntoBuffer): Needs to be exported from WebKit.dll to link with CMake using VS2015.

Source/WTF:

  • wtf/StringExtras.h:

(snprintf):
(wtf_vsnprintf):
VS2015 has an implementation of snprintf.

11:16 AM Changeset in webkit [187720] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46

New tag.

10:11 AM WebKitGTK/2.8.x edited by Michael Catanzaro
Propose some merges (diff)
10:06 AM Changeset in webkit [187719] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187686. rdar://problem/22083354

8:34 AM Changeset in webkit [187718] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187687. rdar://problem/21939014

8:27 AM Changeset in webkit [187717] by saambarati1@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove unintentional "print" statement in test case.
​https://bugs.webkit.org/show_bug.cgi?id=142567

  • tests/stress/class-syntax-definition-semantics.js:

(shouldBeSyntaxError):

8:23 AM Changeset in webkit [187716] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1-branch/Source

Versioning.

3:55 AM Changeset in webkit [187715] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Replace "unknown-mac" CSS class with "el-capitan"
​https://bugs.webkit.org/show_bug.cgi?id=147524

Reviewed by Timothy Hatcher.

  • UserInterface/Base/Platform.js:

No need to repeat WebInspector.Platform.version.release for every possible case.

  • UserInterface/Views/Toolbar.css:

(body:not(.el-capitan) .toolbar .dashboard-container):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]):
(body:not(.el-capitan) .toolbar .search-bar > input[type="search"]:focus):
(body:not(.el-capitan) .toolbar .item.button:active):
(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container):
(body.el-capitan .toolbar .dashboard-container):
(body.el-capitan .toolbar .search-bar > input[type="search"]):
(body.el-capitan .toolbar .search-bar > input[type="search"]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.el-capitan .toolbar .item.button:active):
(body.el-capitan.window-inactive .toolbar .dashboard-container):
(body:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]): Deleted.
(body:not(.unknown-mac) .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body:not(.unknown-mac) .toolbar .item.button:active): Deleted.
(body.window-inactive:not(.unknown-mac) .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .dashboard-container): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]): Deleted.
(body.unknown-mac .toolbar .search-bar > input[type="search"]:focus): Deleted.
(body.unknown-mac .toolbar .item.button:active): Deleted.
(body.unknown-mac.window-inactive .toolbar .dashboard-container): Deleted.

Jul 31, 2015:

11:48 PM Changeset in webkit [187714] by Devin Rousso
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: inherited CSS rules disappear from Styles sidebar while editing
​https://bugs.webkit.org/show_bug.cgi?id=147441

Reviewed by Timothy Hatcher.

If the user edits a style declaration such that it would dissapear mid-edit, prevent
the rules panel from refreshing until that editor is blurred.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):
(WebInspector.CSSStyleDeclarationSection.prototype.get editorActive):
(WebInspector.CSSStyleDeclarationSection.prototype.get _hasInvalidSelector):
(WebInspector.CSSStyleDeclarationSection.prototype._editorContentChanged):
(WebInspector.CSSStyleDeclarationSection.prototype._editorBlurred):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._editorBlured):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._contentChanged):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel):
(WebInspector.RulesStyleDetailsPanel.prototype._removeSectionWithActiveEditor):

  • UserInterface/Views/StyleDetailsPanel.js:

(WebInspector.StyleDetailsPanel.prototype._refreshPreservingScrollPosition):

11:47 PM Changeset in webkit [187713] by mrajca@apple.com
  • 9 edits in trunk/Source

Media Session: inform the UI process when the focused Content media element changes
​https://bugs.webkit.org/show_bug.cgi?id=147323

Reviewed by Tim Horton.

WebCore:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal): Eventually tell the UI process that the focused Content media element changed.

  • page/ChromeClient.h:

WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedContentMediaElementDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
11:39 PM Changeset in webkit [187712] by mrajca@apple.com
  • 3 edits in trunk/Source/WebCore

Media Session: give media elements unique IDs ​https://bugs.webkit.org/show_bug.cgi?id=147322

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::elementIDsToElements): Create a global map of element IDs to elements.
(WebCore::HTMLMediaElement::elementWithID): Retrieve the element with the given ID.
(WebCore::HTMLMediaElement::HTMLMediaElement): Give the element a unique ID.
(WebCore::HTMLMediaElement::playInternal): Removed whitespace.
(WebCore::HTMLMediaElement::pauseInternal): Ditto.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::elementID):

11:27 PM Changeset in webkit [187711] by mmaxfield@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Adding -expected.png for fast/text/international/arabic-justify.html

  • platform/mac-yosemite/fast/text/international/arabic-justify-expected.png: Added
10:33 PM Changeset in webkit [187710] by mrajca@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Media Session: add test to ensure that switching media sessions pauses elements
​https://bugs.webkit.org/show_bug.cgi?id=147493

Reviewed by Eric Carlson.

  • media/session/switching-sessions-expected.txt: Added.
  • media/session/switching-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:27 PM Changeset in webkit [187709] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build

Unreviewed.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::lookupCTFont):

9:15 PM Changeset in webkit [187708] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Autocomplete: Undo (Cmd+Z) doesn't work as expected
​https://bugs.webkit.org/show_bug.cgi?id=147316

Reviewed by Timothy Hatcher.

Instead of replacing the text for a completion, which messes up the undo history, add
a unique marker that contains the remaining text for the current completion.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._createCompletionHintMarker):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._applyCompletionHint):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint.update):
(WebInspector.CodeMirrorCompletionController.prototype._removeCompletionHint):

9:06 PM Changeset in webkit [187707] by mmaxfield@apple.com
  • 6 edits in trunk/Source/WebCore

[OS X] Migrate to CTFontCreateForCharactersWithLanguage from [NSFont findFontLike:forString:withRange:inLanguage]
​https://bugs.webkit.org/show_bug.cgi?id=147483

Reviewed by Dean Jackson.

[NSFont findFontLike:forString:withRange:inLanguage] doesn't properly handle its last argument. In
addition, we want to be moving away from NSFont in the first place and on to Core Text. This new
CoreText function correctly handles its language argument, which is required for language-specific
font fallback.

No new tests because there is no behavior change.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::purgeInactiveFontData):

  • platform/graphics/FontCache.h:

(WebCore::FontCache::platformPurgeInactiveFontData):

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fallbackDedupSet):
(WebCore::FontCache::platformPurgeInactiveFontData):
(WebCore::lookupCTFont):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/spi/cocoa/CoreTextSPI.h:
  • platform/spi/mac/NSFontSPI.h:
8:41 PM Changeset in webkit [187706] by Chris Dumez
  • 31 edits in trunk/Source

Drop dummy Timer callbacks
​https://bugs.webkit.org/show_bug.cgi?id=147516

Reviewed by Alexey Proskuryakov.

Drop dummy Timer callbacks in the code base. A lot of Timer callbacks
do nothing else beside calling a particular method. In such case, we
can use the called method as Timer callback instead.

Source/WebCore:

  • css/FontLoader.cpp:

(WebCore::FontLoader::FontLoader):

  • css/FontLoader.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::styleRecalcTimerFired): Deleted.
(WebCore::Document::domCookieCacheExpiryTimerFired): Deleted.

  • dom/Document.h:
  • html/MediaController.cpp:

(MediaController::MediaController):
(MediaController::timeupdateTimerFired): Deleted.

  • html/MediaController.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::CachedResourceLoader):
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired): Deleted.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::pruneTimerFired): Deleted.

  • loader/cache/MemoryCache.h:
  • page/EventSource.cpp:

(WebCore::EventSource::EventSource):
(WebCore::EventSource::connectTimerFired): Deleted.

  • page/EventSource.h:
  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::delayedScrollEventTimerFired): Deleted.
(WebCore::FrameView::postLayoutTimerFired): Deleted.

  • page/FrameView.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS):
(WebCore::ScrollingCoordinatorIOS::scrollingStateTreeCommitterTimerFired): Deleted.

  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac):
(WebCore::ScrollingCoordinatorMac::scrollingStateTreeCommitterTimerFired): Deleted.

  • platform/graphics/FontCache.cpp:

(WebCore::FontCache::FontCache):
(WebCore::FontCache::purgeTimerFired): Deleted.

  • platform/graphics/FontCache.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::timerFired): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired): Deleted.

Source/WebKit/mac:

  • Plugins/WebNetscapePluginStream.h:
  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverDataTimerFired): Deleted.

Source/WebKit2:

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::layerFlushTimerFired): Deleted.

8:03 PM Changeset in webkit [187705] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.45

New tag.

7:39 PM Changeset in webkit [187704] by mdaiter@apple.com
  • 2 edits in trunk/Source/WebCore

Removed pointSize from _addMarkersToList
​https://bugs.webkit.org/show_bug.cgi?id=147515

Reviewed by Eric Carlson.

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_addMarkersToList): Deleted.

7:39 PM Changeset in webkit [187703] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Roll out r187466. rdar://problem/21960398

6:56 PM Changeset in webkit [187702] by achristensen@apple.com
  • 8 edits in trunk

Prepare for VS2015
​https://bugs.webkit.org/show_bug.cgi?id=146579

Reviewed by Jon Honeycutt.

Source/JavaScriptCore:

  • heap/Heap.h:

Fix compiler error by explicitly casting zombifiedBits to the size of a pointer.

Source/WebCore:

  • WebCore.vcxproj/build-generated-files.pl:

Find a correct preprocessor when using VS2015.

Source/WTF:

  • wtf/StdLibExtras.h:

(std::exchange):
Added preprocessor macros around functions implemented in VS2015's standard library.

Tools:

  • WinLauncher/stdafx.h:

Define STDC_LIMIT_MACROS to have access to INTMAX_MAX.

6:36 PM Changeset in webkit [187701] by Joseph Pecoraro
  • 4 edits in trunk/LayoutTests

Unreviewed gardening. Skip Media Sessions tests, the feature is not yet enabled.

  • TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
6:32 PM Changeset in webkit [187700] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Scrolling "jumps" in console
​https://bugs.webkit.org/show_bug.cgi?id=147482

Reviewed by Joseph Pecoraro.

Removed focus call on messageElement.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype._mousedown): Deleted.
(WebInspector.LogContentView.prototype._didFocus): Deleted.
(WebInspector.LogContentView.prototype._didBlur): Deleted.

6:22 PM Changeset in webkit [187699] by Joseph Pecoraro
  • 4 edits in trunk/LayoutTests

Unreviewed gardening. Update inspector test skips based on bots.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
5:43 PM Changeset in webkit [187698] by Chris Dumez
  • 4 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Drop HTTP method from NetworkCache::Key
​https://bugs.webkit.org/show_bug.cgi?id=143348

Reviewed by Antti Koivisto.

Drop HTTP method from NetworkCache::Key as we only cache GET responses
for now. Even when we start caching HEAD responses, we likely will not
want the method to be part of the key because:

  • A HEAD response can be used to update the headers of a previously cached response to GET
  • A cached GET response may be used to satisfy subsequent HEAD requests
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeCacheKey):

  • NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::operator==):
(WebKit::NetworkCache::Key::decode):
(WebKit::NetworkCache::Key::operator=): Deleted.
(WebKit::NetworkCache::Key::computeHash): Deleted.
(WebKit::NetworkCache::Key::encode): Deleted.

  • NetworkProcess/cache/NetworkCacheKey.h:

(WebKit::NetworkCache::Key::method): Deleted.

5:29 PM Changeset in webkit [187697] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187694. rdar://problem/22015509

5:27 PM Changeset in webkit [187696] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187688. rdar://problem/22015509

5:19 PM Changeset in webkit [187695] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187684. rdar://problem/22000865

5:09 PM Changeset in webkit [187694] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] use a media-specific user gesture check
​https://bugs.webkit.org/show_bug.cgi?id=147509

Reviewed by Tim Horton.

Change an enum name added in r187688.

  • dom/UserGestureIndicator.cpp:

(WebCore::isDefinite): DefinitelyProcessingMediaUserGesture -> DefinitelyProcessingPotentialUserGesture
(WebCore::UserGestureIndicator::processingUserGestureForMedia): Ditto.

  • dom/UserGestureIndicator.h: Ditto.
5:00 PM Changeset in webkit [187693] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] Latin quotes are used with the system font on Chinese devices
​https://bugs.webkit.org/show_bug.cgi?id=147504

Reviewed by Dean Jackson.

The system font has some fancy logic regarding character selection which requires
using Core Text for glyph selection.

No new tests because tests can't change the system language of the device.

  • platform/graphics/mac/GlyphPageMac.cpp:

(WebCore::shouldUseCoreText):

4:57 PM Changeset in webkit [187692] by Joseph Pecoraro
  • 10 edits
    1 move
    1 add in trunk

Web Inspector: Unskip / Unflake inspector tests after r187627
​https://bugs.webkit.org/show_bug.cgi?id=147503

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Base/Test.js:

(InspectorTest.completeTest):
(InspectorTest.completeTest.signalCompletionToTestPage): Deleted.
(InspectorTest.testPageDidLoad):
Instead of immediately resending results if completeTest was called
during a reload before the load has completed, we just set a flag
to complete the test when the load completes. This consistently
resends the output to the new page for test output.

(InspectorTest._resendResults):
Delete clear results. If the page had logged anything directly on
the page side (using InspectorTestProxy) this clearMessages would
have deleted those messages and not been able to recreate them.
Clearing messages wasn't really serving a purpose.

LayoutTests:

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:

Unskip and unflake inspector tests.

  • http/tests/inspector/inspector-test.js:

(InspectorTestProxy.addResult):
Simplify with the new append API.

(InspectorTestProxy.clearResults): Deleted.
Delete, as it is no longer used.

  • inspector/debugger/probe-manager-add-remove-actions-expected.txt:

Include output that was getting erronously cleared by clearResults
which we removed.

  • inspector/dom/highlightSelector-expected.txt:
  • inspector/dom/highlightSelector.html:

Make this test more reliable when run with other tests.
Never assume the frame id for the main frame or sub frame,
instead compute them and mask them in the output.

  • inspector/dom/resources/highlightSelector-iframe.html: Renamed from LayoutTests/inspector/dom/highlightSelector-iframe.html.

Move the non-test iframe html resource into a sub-folder
so it won't be treated like an actual test.

4:56 PM Changeset in webkit [187691] by Chris Dumez
  • 5 edits in trunk/Source

Source/WebCore:
Coalesce authentication credential requests
​https://bugs.webkit.org/show_bug.cgi?id=128006
<rdar://problem/16839069>

Reviewed by Alexey Proskuryakov.

Export symbol for ProtectionSpace::compare() so it can be called from
WebKit2.

  • platform/network/ProtectionSpaceBase.h:

Source/WebKit2:
Coalesce concurrent authentication challenges for the same ProtectionSpace
​https://bugs.webkit.org/show_bug.cgi?id=147496
<rdar://problem/16839069>

Reviewed by Alexey Proskuryakov.

Coalesce concurrent authentication challenges for the same ProtectionSpace.
Ideally, this would be done in the network layer but short term, this will
make sure the user no longer gets repeating authentication dialogs for the
same protection space.

This gets rid of a long-standing bug in WebKit / Safari where visiting a
site using HTTP authentication would pop up one authentication dialog for
each subresource being loaded from the network (especially when the main
resource is loaded from the cache).

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::canCoalesceChallenge):
(WebKit::AuthenticationManager::addChallengeToChallengeMap):
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
(WebKit::AuthenticationManager::AuthenticationManager): Deleted.

  • Shared/Authentication/AuthenticationManager.h:
4:50 PM Changeset in webkit [187690] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip more inspector tests on Windows.

It may be that no inspector tests are working on Windows,
if that is the case we may move to skipping all of them
and investigate unskipping in chunks.

  • platform/win/TestExpectations:
4:27 PM Changeset in webkit [187689] by Brian Burg
  • 20 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert timeline view classes to ES6 classes
​https://bugs.webkit.org/show_bug.cgi?id=147381

Reviewed by Joseph Pecoraro.

Along the way, inline a few style class names.

Elided mechanical changes from the Changelog.

  • UserInterface/Views/LayoutTimelineOverviewGraph.js:
  • UserInterface/Views/LayoutTimelineView.js:
  • UserInterface/Views/LinearTimelineOverview.js:
  • UserInterface/Views/NetworkTimelineOverviewGraph.js:
  • UserInterface/Views/NetworkTimelineView.js:
  • UserInterface/Views/OverviewTimelineView.js:
  • UserInterface/Views/RenderingFrameTimelineOverview.js:
  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:
  • UserInterface/Views/RenderingFrameTimelineView.js:
  • UserInterface/Views/ScriptTimelineOverviewGraph.js:
  • UserInterface/Views/ScriptTimelineView.js:
  • UserInterface/Views/TimelineOverview.js:
  • UserInterface/Views/TimelineOverviewGraph.js:
  • UserInterface/Views/TimelineRecordBar.js:
  • UserInterface/Views/TimelineRecordFrame.js:
  • UserInterface/Views/TimelineRecordingContentView.js:
  • UserInterface/Views/TimelineRuler.js:
  • UserInterface/Views/TimelineTabContentView.js:
  • UserInterface/Views/TimelineView.js:
3:59 PM Changeset in webkit [187688] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] use a media-specific user gesture check
​https://bugs.webkit.org/show_bug.cgi?id=147509

Reviewed by Jer Noble.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::processingUserGestureForMedia): New.

  • bindings/js/ScriptController.h:
  • dom/UserGestureIndicator.cpp:

(WebCore::isDefinite): Allow DefinitelyProcessingMediaUserGesture.
(WebCore::UserGestureIndicator::processingUserGestureForMedia): New.

  • dom/UserGestureIndicator.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::load): Use ScriptController::processingUserGestureForMedia instead of

ScriptController::processingUserGesture

(WebCore::HTMLMediaElement::play): Ditto.

3:43 PM Changeset in webkit [187687] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Crashes under HTMLMediaElement::updateActiveTextTrackCues() when destroying CachedPage.
<​https://webkit.org/b/147506>
<rdar://problem/21939014>

Reviewed by Chris Dumez.

Don't mess with the media element's text tracks below its ActiveDOMObject::stop()
implementation, since that may cause DOM mutations.

I don't have a repro or a test for this, but plenty of crash logs to indicate that
we're getting ourselves into trouble by modifying the DOM during CachedPage teardown.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackDisplay):

3:34 PM Changeset in webkit [187686] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] DOMNode preview snapshot rects are wrong for user-select: none links
​https://bugs.webkit.org/show_bug.cgi?id=147513
<rdar://problem/22083354>

Reviewed by Simon Fraser.

  • bindings/objc/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):
Use the same code as WebKit2 to compute the fallback rect (if TextIndicator fails),
asking the RenderObject (or RenderImage) for its bounding box instead of using the
(often wrong) Range bounding rect.

Make sure to use the fallback rect *any* time TextIndicator fails (before
we would return no rects at all if TextIndicator::createWithRange returned null,
and the fallback rect if it returned with an empty image).

Inverse-page-scale the margin, to match the appearance in WebKit2.

3:24 PM Changeset in webkit [187685] by mmaxfield@apple.com
  • 3 edits
    3 adds in trunk

[SVG -> OTF Converter] Crash when converting Arabic fonts
​https://bugs.webkit.org/show_bug.cgi?id=147510

Reviewed by Anders Carlsson.

Source/WebCore:

SVGToOTFFontConverter::compareCodepointsLexicographically() wasn't transitive.

Test: fast/text/arabic-duplicate-glyph-font.html

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):

LayoutTests:

  • fast/text/arabic-duplicate-glyph-font-expected.txt: Added.
  • fast/text/arabic-duplicate-glyph-font.html: Added.
  • fast/text/resources/arabic-duplicate-glyph-font.svg: Added.
3:20 PM Changeset in webkit [187684] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Rename AVPlayerLayerView to _AVPlayerLayerView.
​https://bugs.webkit.org/show_bug.cgi?id=147399

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-07-31
Reviewed by Eric Carlson.

Change class name AVPlayerLayerView to match change in AVKit SPI.
This prevents conflicts with 3rd party apps.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPlayerLayerView_dealloc):
(getWebAVPlayerLayerViewClass):

  • platform/spi/cocoa/AVKitSPI.h:
2:40 PM Changeset in webkit [187683] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: REGRESSION(r187676): Broke stress/tail-call-no-stack-overflow.js
​https://bugs.webkit.org/show_bug.cgi?id=147507

Reviewed by Basile Clement.

Changed strictLoopArityFixup1 and strictLoopArityFixup2 to recursively call
themselves instead of nonexistent strictLoopArityFixup.

  • tests/stress/tail-call-no-stack-overflow.js:

(strictLoopArityFixup1):
(strictLoopArityFixup2):

2:26 PM Changeset in webkit [187682] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Unreviewed parameter name typo fix.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _setHiddenPageDOMTimerThrottlingEnabled:]):

2:16 PM Changeset in webkit [187681] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

ImageBufferDataCG should not add IOSurfaces to the pool
​https://bugs.webkit.org/show_bug.cgi?id=147494

Reviewed by Tim Horton.

ImageBufferDataCG should not add IOSurfaces to the pool as it is not
safe. IOSurfaceIsInUse() does not return accurate result for those
surfaces.

This is a partial revert of r181301.

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::~ImageBufferData): Deleted.

  • platform/graphics/cg/ImageBufferDataCG.h:
2:05 PM Changeset in webkit [187680] by saambarati1@gmail.com
  • 25 edits
    2 adds in trunk

ES6 class syntax should use block scoping
​https://bugs.webkit.org/show_bug.cgi?id=142567

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We treat class declarations like we do "let" declarations.
The class name is under TDZ until the class declaration
statement is evaluated. Class declarations also follow
the same rules as "let": No duplicate definitions inside
a lexical environment.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassDeclStatement):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClassDeclaration):

  • tests/stress/class-syntax-block-scoping.js: Added.

(assert):
(truth):
(.):

  • tests/stress/class-syntax-definition-semantics.js: Added.

(shouldBeSyntaxError):
(shouldNotBeSyntaxError):
(truth):

  • tests/stress/class-syntax-tdz.js:

(assert):
(shouldThrowTDZ):
(truth):
(.):

LayoutTests:

  • js/class-constructor-return-expected.txt:
  • js/class-syntax-call-expected.txt:
  • js/class-syntax-declaration-expected.txt:
  • js/class-syntax-default-constructor-expected.txt:
  • js/class-syntax-extends-expected.txt:
  • js/class-syntax-name-expected.txt:
  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-constructor-return.js:

(shouldThrow):
(shouldNotThrow):
(shouldBeTrue):
(shouldBeFalse):

  • js/script-tests/class-syntax-call.js:

(A):
(B):
(shouldThrow):
(shouldNotThrow):

  • js/script-tests/class-syntax-declaration.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):

  • js/script-tests/class-syntax-default-constructor.js:

(shouldThrow):
(shouldBe):
(shouldBeTrue):
(assert):
(A):
(B):

  • js/script-tests/class-syntax-extends.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(Base):
(Base.prototype.baseMethod):

  • js/script-tests/class-syntax-name.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(runTestShouldBe):

  • js/script-tests/class-syntax-super.js:

(shouldThrow):
(shouldNotThrow):
(shouldBe):
(shouldBeTrue):
(shouldBeFalse):

1:38 PM Changeset in webkit [187679] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187675. rdar://problem/21632211

1:36 PM Changeset in webkit [187678] by basile_clement@apple.com
  • 3 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Emit a single callee-save restoration for fast and slow tail call paths
​https://bugs.webkit.org/show_bug.cgi?id=147501

Reviewed by Michael Saboff.

We are currently emitting this twice for no reason.

  • jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

1:34 PM Changeset in webkit [187677] by commit-queue@webkit.org
  • 9 edits
    5 adds in trunk/Source/JavaScriptCore

Implement WebAssembly module parser
​https://bugs.webkit.org/show_bug.cgi?id=147293

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2015-07-31
Reviewed by Mark Lam.

Re-landing after fix for the "..\..\jsc.cpp(46): fatal error C1083: Cannot open
include file: 'JSWASMModule.h'" issue on Windows.

Implement WebAssembly module parser for WebAssembly files produced by pack-asmjs
<​https://github.com/WebAssembly/polyfill-prototype-1>. This patch only checks
the magic number at the beginning of the files. Parsing of the rest will be
implemented in a subsequent patch.

(GlobalObject::finishCreation):
(functionLoadWebAssembly):

  • parser/SourceProvider.h:

(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::data):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::wasmModuleStructure):

  • wasm/WASMMagicNumber.h: Added.
  • wasm/WASMModuleParser.cpp: Added.

(JSC::WASMModuleParser::WASMModuleParser):
(JSC::WASMModuleParser::parse):
(JSC::WASMModuleParser::parseModule):
(JSC::parseWebAssembly):

  • wasm/WASMModuleParser.h: Added.
  • wasm/WASMReader.cpp: Added.

(JSC::WASMReader::readUnsignedInt32):
(JSC::WASMReader::readFloat):
(JSC::WASMReader::readDouble):

  • wasm/WASMReader.h: Added.

(JSC::WASMReader::WASMReader):

1:31 PM Changeset in webkit [187676] by basile_clement@apple.com
  • 6 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: Don't waste stack space when arity fixup was performed
​https://bugs.webkit.org/show_bug.cgi?id=147447

Reviewed by Michael Saboff.

r187618 tried to handle this, but did not include the LLInt and did it
wrong anyway. When making a call, the caller first aligns the callee's
frame, then makes the call. If the callee later performs arity fixup,
it does not try to reuse the potential slot left empty by the caller's
frame alignment: instead, it aligns the parameters - arguments delta.
So when trying to find out where our frame starts, we should replicate
this behavior, which we were previously not doing and was the cause of
​https://bugs.webkit.org/show_bug.cgi?id=147491.

While here, I also removed the extra slot that used to save the
returnPC for the arity fixup return thunk (that we got rid of in
​https://bugs.webkit.org/show_bug.cgi?id=146847) and was now just
wasting stack space.

  • jit/CCallHelpers.h:
  • jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):

  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

  • tests/stress/tail-call-no-stack-overflow.js:

(strictLoopArityFixup1):
(strictLoopArityFixup2):

1:21 PM Changeset in webkit [187675] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
​https://bugs.webkit.org/show_bug.cgi?id=147485

Rubber-stamped by Joseph Pecoraro.

Follow-up test crash fix: call superclass's contextDestroyed() which allows the
m_scriptExecutionContext variable to be cleared.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::contextDestroyed):
1:17 PM Changeset in webkit [187674] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall: REGRESSION(r187639): Need to restore callee saves in LLInt before tail call
​https://bugs.webkit.org/show_bug.cgi?id=147500

Reviewed by Basile Clement.

Restore callee saves at the head of the prepareForTailCall() macro.

  • llint/LowLevelInterpreter.asm:
1:15 PM Changeset in webkit [187673] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187655. rdar://problem/21632211

1:15 PM Changeset in webkit [187672] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merge r187630. rdar://problem/18835799

1:15 PM Changeset in webkit [187671] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merge r187614. rdar://problem/22064327

1:01 PM Changeset in webkit [187670] by msaboff@apple.com
  • 2 edits in branches/jsc-tailcall/Source/JavaScriptCore

jsc-tailcall:Eliminate the unsafe use of regT5 in arityFixupGenerator() for X86-64 Windows
​https://bugs.webkit.org/show_bug.cgi?id=147499

Reviewed by Basile Clement.

For X86-64, Windows, regT0 is free so use that register instead of regT5.

  • jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):

12:43 PM Changeset in webkit [187669] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit/mac

REGRESSION (r174791): Returning a zombie NSImage from sharingService:transitionImageForShareItem:contentRect:
<rdar://problem/22060183> and ​https://bugs.webkit.org/show_bug.cgi?id=147497

Reviewed by Tim Horton.

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem): Don't return what is basically a temporary NSImage.

Instead do a [[retain] autorelease] on it while still valid.

12:25 PM Changeset in webkit [187668] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Only generate "themeWin*" UserAgentStyleSheet constants for Windows builds
​https://bugs.webkit.org/show_bug.cgi?id=147378

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-31
Reviewed by Alex Christensen.

  • DerivedSources.make:

Only include windows user agent style sheets for Windows OSes.

11:41 AM Changeset in webkit [187667] by Lucas Forschler
  • 2 edits
    1 copy in branches/safari-601.1-branch/Source/JavaScriptCore

Merged r187579. rdar://problem/21668986

11:38 AM Changeset in webkit [187666] by Lucas Forschler
  • 3 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187557. rdar://problem/21412186

11:33 AM Changeset in webkit [187665] by Lucas Forschler
  • 8 edits in branches/safari-601.1-branch

Merged r187556. rdar://problem/21771620

11:30 AM Changeset in webkit [187664] by Lucas Forschler
  • 5 edits
    2 copies in branches/safari-601.1-branch

Merged r187535. rdar://problem/21852603

11:22 AM Changeset in webkit [187663] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187530. rdar://problem/21833987

11:19 AM Changeset in webkit [187662] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-601.1-branch

Merged r187525. rdar://problem/22022011

11:10 AM Changeset in webkit [187661] by Lucas Forschler
  • 26 edits in branches/safari-601.1-branch/LayoutTests

Merged r187523. rdar://problem/22010303

11:08 AM Changeset in webkit [187660] by Lucas Forschler
  • 13 edits in branches/safari-601.1-branch/Source

Merged r187522. rdar://problem/19892014

11:07 AM Changeset in webkit [187659] by achristensen@apple.com
  • 18 edits in trunk

Prepare for debug CMake builds on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=147484

Reviewed by Tim Horton.

.:

  • Source/cmake/OptionsWindows.cmake:

Don't use debug runtimes in debug builds because the dependencies are only built with multithreaded runtimes.

Source/WebCore:

In order to get debug builds to link on Windows with CMake, we will need to use AllInOnes.
This patch includes more files in the AllInOnes and removes some duplicate code.

  • WebCore.vcxproj/WebCore.vcxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • css/CSSAllInOne.cpp:

Many files were added to the AllInOne files. They should not be included in the Visual Studio solutions.

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcValue::create):
Use CSSParserString::equalIgnoringCase to avoid ambiguous calls to overloaded functions.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::shouldApplyPropertyInParseOrder):
(WebCore::convertToFloatLength): Deleted.

  • css/TransformFunctions.cpp:

(WebCore::transformOperationType):
(WebCore::convertToFloatLength):

  • css/TransformFunctions.h:

Removed duplicate convertToFloatLength function.

  • html/HTMLElementsAllInOne.cpp:
  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::compareZIndexFlowThreadController): Renamed from compareZIndex to prevent naming conflicts.
(WebCore::FlowThreadController::collectFixedPositionedLayers):
(WebCore::compareZIndex): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldRepaintAfterLayout):
(WebCore::compositedWithOwnBackingStore):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::compositedWithOwnBackingStore): Deleted.
Removed duplicate compositedWithOwnBackingStore.
(WebCore::paintScrollbar): Deleted duplicate function.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresScrollLayer):
(WebCore::paintScrollbar):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderingAllInOne.cpp:
11:01 AM Changeset in webkit [187658] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187521. rdar://problem/22038421

10:56 AM Changeset in webkit [187657] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187516. rdar://problem/20847009

10:49 AM Changeset in webkit [187656] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/LayoutTests

Merged r187512. rdar://problem/22010303

10:49 AM Changeset in webkit [187655] by jer.noble@apple.com
  • 4 edits in trunk/Source/WebCore

CRASH at WebCore::TaskDispatcher<WebCore::ScriptExecutionContext>::postTask + 38
​https://bugs.webkit.org/show_bug.cgi?id=147485

Reviewed by Eric Carlson.

CrashLogs indicate a use-after-free of the ScriptExecutionContext (i.e., Document) used by
the GenericTaskQueue objects owned by HTMLMediaElement. When the ScriptExecutionContext
notifies its ActiveDOMObjects that it is about to be destroyed, close() the
GenericTaskQueues so that they can no longer accept new tasks.

Previously, enqueueing a task on a closed GenericTaskQueue ASSERTed in debug builds, but
silently succeeded in release builds. Calling enqueueTask() on a closed GenericTaskQueue is
now a no-op.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::contextDestroyed):

  • html/HTMLMediaElement.h:
  • platform/GenericTaskQueue.h:

(WebCore::GenericTaskQueue::enqueueTask):

10:08 AM Changeset in webkit [187654] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test for MediaSession.releaseSession()
​https://bugs.webkit.org/show_bug.cgi?id=147478

Reviewed by Eric Carlson.

  • media/session/releasing-sessions-expected.txt: Added.
  • media/session/releasing-sessions.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:59 AM Changeset in webkit [187653] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test to ensure next/previous-track event handlers are not fired when they are disabled
​https://bugs.webkit.org/show_bug.cgi?id=147477

Reviewed by Eric Carlson.

  • media/session/track-media-events-disabled-expected.txt: Added.
  • media/session/track-media-events-disabled.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:51 AM Changeset in webkit [187652] by mrajca@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Media Session: add test to ensure media sessions are in an Idle state after creation
​https://bugs.webkit.org/show_bug.cgi?id=147471

Reviewed by Eric Carlson.

  • media/session/session-creation-expected.txt: Added.
  • media/session/session-creation.html: Added.
  • platform/mac/TestExpectations: Media Session support is disabled by default.
9:44 AM Changeset in webkit [187651] by Lucas Forschler
  • 12 edits in branches/safari-601.1-branch/Source

Merged r187491. rdar://problem/21718407

9:42 AM Changeset in webkit [187650] by Lucas Forschler
  • 18 edits
    34 copies
    2 deletes in branches/safari-601.1-branch

Merged r187489. rdar://problem/22010303

9:35 AM Changeset in webkit [187649] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187471. rdar://problem/22021772

9:33 AM Changeset in webkit [187648] by Lucas Forschler
  • 4 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187466. rdar://problem/21960398

9:25 AM Changeset in webkit [187647] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187462. rdar://problem/22020770

9:05 AM Changeset in webkit [187646] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebKit2

Merged r187459. rdar://problem/21701858

9:01 AM Changeset in webkit [187645] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187448. rdar://problem/21948230

9:00 AM Changeset in webkit [187644] by Lucas Forschler
  • 2 edits in branches/safari-601.1-branch/Source/WebCore

Merged r187379. rdar://problem/21948230

8:58 AM Changeset in webkit [187643] by Lucas Forschler
  • 9 edits in branches/safari-601.1-branch/Source

Merged r187375. rdar://problem/21948230

7:28 AM Changeset in webkit [187642] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Fix pixman build on ARM with GCC 4.9.3
​https://bugs.webkit.org/show_bug.cgi?id=147224

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
5:24 AM Changeset in webkit [187641] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] NPAPI code crashes on Wayland
​https://bugs.webkit.org/show_bug.cgi?id=147297

Reviewed by Žan Doberšek.

Do not crete NPAPI plugins when runing on Wayland, since they are
not supported. ENABLE_NETSCAPE_PLUGIN_API option used to be
incompatible with building with the Wayland target, but now that
we allow to build X11 and Wayland targets at the same time, we
need runtime checks to avoid creating NPAPI plugins in Wayland.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_set_enable_plugins): Do not allow to change the
setting when running in Wayland.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore): Initialize
EnablePlugins preference to false when running in Wayland.

1:06 AM Changeset in webkit [187640] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[GTK] Have DataObjectGtk::unknownTypes() return a reference to the HashMap object
​https://bugs.webkit.org/show_bug.cgi?id=147401

Reviewed by Carlos Garcia Campos.

Don't copy the DataObjectGtk::m_unknownTypes HashMap on every retrieval through
DataObjectGtk::unknownTypes(). The range-based for-loops that iterate over the
map in PasteboardGtk.cpp and PasteboardHelper.cpp are also cleaned up.

  • platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::unknownTypes):

  • platform/gtk/DataObjectGtk.h:
  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writePasteboard):
(WebCore::Pasteboard::types):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

Note: See TracTimeline for information about the timeline view.