Timeline

Mar 24, 2016:

11:46 PM Changeset in webkit [198661] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Mark crash tests in proper category.

• platform/efl/TestExpectations:

10:14 PM Changeset in webkit [198660] by commit-queue@webkit.org

• 2 edits in trunk

Determine architecture for running jsc stress tests on windows
​https://bugs.webkit.org/show_bug.cgi?id=155840

Patch by Bill Ming <​mbbill@gmail.com> on 2016-03-24
Reviewed by Alex Christensen.

• Tools/Scripts/run-jsc-stress-tests:

8:59 PM Changeset in webkit [198659] by achristensen@apple.com

• 7 edits in trunk/Source

Fix Mac CMake build.

Source/JavaScriptCore:

• PlatformMac.cmake:

Link to Security framework.

Source/WebCore:

• PlatformMac.cmake:

Add new file and directory.

Source/WebKit2:

• CMakeLists.txt:

Temporarily add DERIVED_SOURCES_JAVASCRIPTCORE_DIR after DERIVED_SOURCES_WEBCORE_DIR,
because both contain a unique header named InspectorBackendDispatchers.h and this include
order includes the correct one for WebKit2 first.

• PlatformMac.cmake:

Add new files. Optionally link to AVFAudio.

7:24 PM Changeset in webkit [198658] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r198500.

Roll back in r197552 as it did not seem to cause a PLT
regression after all

Reverted changeset:

"Unreviewed, rolling out r197552."
​https://bugs.webkit.org/show_bug.cgi?id=154986
​http://trac.webkit.org/changeset/198500

7:14 PM Changeset in webkit [198657] by dbates@webkit.org

• 17 edits
  3 adds in trunk

CSP: Move logic for reporting a violation from ContentSecurityPolicyDirectiveList to ContentSecurityPolicy
​https://bugs.webkit.org/show_bug.cgi?id=155842
<rdar://problem/25340377>
And
​https://bugs.webkit.org/show_bug.cgi?id=155133

Reviewed by Brent Fulgham.

Source/WebCore:

Towards associating source file, line-, and column- numbers (​https://bugs.webkit.org/show_bug.cgi?id=114317)
with a CSP console message we should move the logic for logging the console message/reporting the violation
from class ContentSecurityPolicyDirectiveList to class ContentSecurityPolicy so that it is closer to the
script execution context that can access such information.

The responsibilities of the class ContentSecurityPolicyDirectiveList have been reduced. It is responsible
for parsing a string representation of the Content Security Policy and providing functions to determine
the violated directive (if any) for a given source (e.g. URL). ContentSecurityPolicyDirectiveList no longer
takes responsibility logging a console message or sending a violation report (if applicable). Falling out
from this decrease in responsibility is the removal of enum ContentSecurityPolicyDirectiveList::ReportingStatus
and the need to pass a enumerator of this enum to each ContentSecurityPolicyDirectiveList to suppress
the sending of a violation report. The caller of ContentSecurityPolicyDirectiveList is responsible for
making this determination.

With the exception of a change to the error message for an inline event handler violation, there are no
other functional changes. When an inline event handler violation occurs we will emit either:

Refused to execute a script for an inline event handler because 'unsafe-inline' does not appear in the
script-src directive of the Content Security Policy.

Or:

Refused to execute a script for an inline event handler because 'unsafe-inline' appears in neither the
script-src directive nor the default-src directive of the Content Security Policy.

depending on whether the Content Security Policy contains a script-src directive or not.

• CMakeLists.txt: Add files ContentSecurityPolicyDirective.cpp and ContentSecurityPolicyDirectiveNames.cpp.
• WebCore.xcodeproj/project.pbxproj: Add files ContentSecurityPolicyDirective.cpp and ContentSecurityPolicyDirectiveNames.{cpp, h}.
• page/csp/ContentSecurityPolicy.cpp:

(WebCore::consoleMessageForViolation): Moved from file ContentSecurityPolicyDirectiveList.cpp and
incorporates the functionality of ContentSecurityPolicyDirectiveList::reportViolation(). Modified
to take a reference to the violated directive (ContentSecurityPolicyDirective object) and removed
the boolean parameter violatesDefaultSrc as we can deduce this from the violated directive.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Modified to call ContentSecurityPolicyDirectiveList::violatedDirectiveForUnsafeEval().
(WebCore::ContentSecurityPolicy::foundHashOfContentInAllPolicies): Renamed; Formerly named allPoliciesAllowHashFromContent.
Modified to early return if either no algorithms are given or the specified content to hash is
the empty string.
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs): Moved logic for reporting a violation from
ContentSecurityPolicyDirectiveList member function of the same name to here.
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers): Moved logic for reporting a violation from
ContentSecurityPolicyDirectiveList member function of the same name to here. Additionally, changed the
error message text to better describe the reason for the violation.
(WebCore::ContentSecurityPolicy::allowScriptWithNonce): Ditto.
(WebCore::ContentSecurityPolicy::allowStyleWithNonce): Ditto.
(WebCore::ContentSecurityPolicy::allowInlineScript): Ditto.
(WebCore::ContentSecurityPolicy::allowInlineStyle): Ditto.
(WebCore::ContentSecurityPolicy::allowEval): Ditto.
(WebCore::ContentSecurityPolicy::allowFrameAncestors): Ditto.
(WebCore::ContentSecurityPolicy::allowPluginType): Ditto.
(WebCore::ContentSecurityPolicy::allowScriptFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowObjectFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowChildContextFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowImageFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowStyleFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowFontFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowMediaFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowConnectToSource): Ditto.
(WebCore::ContentSecurityPolicy::allowFormAction): Ditto.
(WebCore::ContentSecurityPolicy::allowBaseURI): Ditto.
(WebCore::ContentSecurityPolicy::reportViolation): Simplified signature by having it take a reference to
a ContentSecurityPolicyDirective object. Also split functionality into two variants: one variant takes a
pointer to a JSC::ExecState, one variant takes a source file, and line and column positions.
(WebCore::ContentSecurityPolicy::allPoliciesAllowHashFromContent): Deleted.
(WebCore::ContentSecurityPolicy::gatherReportURIs): Deleted.

• page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::violatedDirectiveInAnyPolicy): Formerly named allPoliciesAllow. Modified
to return the violated directive.
(WebCore::ContentSecurityPolicy::allPoliciesAllow): Deleted.

• page/csp/ContentSecurityPolicyDirective.cpp: Added.
• page/csp/ContentSecurityPolicyDirective.h: Added.

(WebCore::ContentSecurityPolicyDirective::ContentSecurityPolicyDirective): Modified to take a reference to the
directive list that contains this directive instead of pointer to a ContentSecurityPolicy object.
(WebCore::ContentSecurityPolicyDirective::name): Added.
(WebCore::ContentSecurityPolicyDirective::directiveList): Added.
(WebCore::ContentSecurityPolicyDirective::isDefaultSrc): Added.
(WebCore::ContentSecurityPolicyDirective::policy): Deleted.

• page/csp/ContentSecurityPolicyDirectiveList.cpp: Remove unused header <wtf/Optional.h>. Also remove header wtf/text/StringBuilder.h

as the function that made use of it, consoleMessageForViolation, was moved to file ContentSecurityPolicy.cpp.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForUnsafeEval): Formerly named allowEval.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForUnsafeInlineScript): Formerly named allowInlineScript.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForUnsafeInlineStyle): Formerly named allowInlineStyle.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScriptHash): Formerly named allowInlineScriptWithHash.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForStyleHash): Formerly named allowInlineStyleWithHash.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScriptNonce): Formerly named allowScriptWithNonce.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForStyleNonce): Formerly named allowStyleWithNonce.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForBaseURI): Formerly named allowBaseURI.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForChildContext): Formerly named allowChildContextFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForConnectSource): Formerly named allowConnectToSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFont): Formerly named allowFontFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFormAction): Formerly named allowFormAction.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFrame): Formerly named allowChildFrameFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForFrameAncestor): Formerly named allowFrameAncestors.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForImage): Formerly named allowImageFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForMedia): Formerly named allowMediaFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForObjectSource): Formerly named allowObjectFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForPluginType): Formerly named allowPluginType.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForScript): Formerly named allowScriptFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::violatedDirectiveForStyle): Formerly named allowStyleFromSource.
(WebCore::ContentSecurityPolicyDirectiveList::parse): Update code to make use of ContentSecurityPolicyDirectiveNames constants.
(WebCore::ContentSecurityPolicyDirectiveList::setCSPDirective): Pass |this| instead of the ContentSecurityPolicy object.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Update code to make use of ContentSecurityPolicyDirectiveNames constants.
(WebCore::isExperimentalDirectiveName): Deleted.
(WebCore::isCSPDirectiveName): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::reportViolation): Deleted.
(WebCore::consoleMessageForViolation): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowJavaScriptURLs): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineEventHandlers): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineScript): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineScriptWithHash): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowScriptWithNonce): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineStyle): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineStyleWithHash): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowStyleWithNonce): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowEval): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowPluginType): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowScriptFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowObjectFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildContextFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildFrameFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowImageFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowStyleFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowFontFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowMediaFromSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowConnectToSource): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowFormAction): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowBaseURI): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::allowFrameAncestors): Deleted.

• page/csp/ContentSecurityPolicyDirectiveList.h:

(WebCore::ContentSecurityPolicyDirectiveList::defaultSrc): Added.
(WebCore::ContentSecurityPolicyDirectiveList::policy): Added. Also added FIXME comment to remove this function. This
function is only used by ContentSecurityPolicyMediaListDirective so that it can log a console message on a parsing error.
(WebCore::ContentSecurityPolicyDirectiveList::denyIfEnforcingPolicy): Deleted.

• page/csp/ContentSecurityPolicyDirectiveNames.cpp: Added.
• page/csp/ContentSecurityPolicyDirectiveNames.h: Added.
• page/csp/ContentSecurityPolicyMediaListDirective.cpp:

(WebCore::ContentSecurityPolicyMediaListDirective::ContentSecurityPolicyMediaListDirective): Modified to take a reference to the
directive list that contains this directive instead of pointer to a ContentSecurityPolicy object.
(WebCore::ContentSecurityPolicyMediaListDirective::parse): Updated code to use ContentSecurityPolicyDirectiveList::policy() instead
of ContentSecurityPolicyDirective::policy() as the latter was removed. Ideally this class should not need to use the ContentSecurityPolicy
object to log a console message.

• page/csp/ContentSecurityPolicyMediaListDirective.h:
• page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::isExperimentalDirectiveName): Moved from file ContentSecurityPolicyDirectiveList.cpp because this function is only used
in this file.
(WebCore::isCSPDirectiveName): Ditto.
(WebCore::ContentSecurityPolicySourceList::isProtocolAllowedByStar): Update code to make use of ContentSecurityPolicyDirectiveNames constants.

• page/csp/ContentSecurityPolicySourceListDirective.cpp:

(WebCore::ContentSecurityPolicySourceListDirective::ContentSecurityPolicySourceListDirective): Modified to take a reference to
the directive list that contains this directive instead of pointer to a ContentSecurityPolicy object.

• page/csp/ContentSecurityPolicySourceListDirective.h:

LayoutTests:

Update expected results to reflect new error message text for an inline event handler violation.

• http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta-expected.txt:
• http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
• http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:

7:03 PM Changeset in webkit [198656] by mmaxfield@apple.com

• 7 edits in trunk/Source/WebCore

[OS X] Overflow:scroll scrollbars do not obey overlay/always-on system preference changes
​https://bugs.webkit.org/show_bug.cgi?id=155830

Reviewed by Simon Fraser.

When the scrollbar style changes, the available width of all ScrollableAreas change,
and therefore a relayout must occur.

Each ScrollableArea owns its own ScrollAnimator (if necessary). Upon creation, the
ScrollAnimator will start listening for changes to the system preference for
overlay / always-on scrollbars. When notified, the ScrollAnimator tells its owning
ScrollableArea that scrollbarStyleChanged().

For main-frame scrolling, FrameView overrides scrollbarStyleChanged and causes a
relayout. However, for overflow:scroll elements, no relayout is triggered. This
patch overrides availableContentSizeChanged() for RenderLayer (which is used for
overflow:scroll elements). This override triggers a relayout.

It also updates the mechanism in RenderBlock::recomputeLogicalWidth() to ensure that
a change in scrollbar size causes RenderBlockFlow::layoutBlock() to relayout its
children. This is appropriate because block child positioning is affected by
scrollbar size.

No new tests (for now). Presumably we could mock the message we receive when the
system preference is changed. However, I haven't implemented that yet.

• rendering/RenderBlock.cpp: Rename setHasBorderOrPaddingLogicalWidthChanged().

(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::recomputeLogicalWidth):

• rendering/RenderBlock.h: Ditto.

(WebCore::RenderBlock::setShouldForceRelayoutChildren):
(WebCore::RenderBlock::shouldForceRelayoutChildren):

• rendering/RenderElement.cpp: Ditto.

(WebCore::RenderElement::RenderElement):

• rendering/RenderElement.h: Ditto.

(WebCore::RenderElement::setRenderBlockShouldForceRelayoutChildren):
(WebCore::RenderElement::renderBlockShouldForceRelayoutChildren):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::availableContentSizeChanged): Cause a relayout to occur.

• rendering/RenderLayer.h:

6:13 PM Changeset in webkit [198655] by commit-queue@webkit.org

• 75 edits in trunk/Source

Change NativeImagePtr for CG to be RetainPtr<CGImageRef>
​https://bugs.webkit.org/show_bug.cgi?id=155412

Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-03-24
Reviewed by Darin Adler.

Source/WebCore:

Having NativeImagePtr as a raw pointer makes managing the life cycle of
the returned CGImageRef hard. A lot of work was done to ensure the CG
pointer is refcounted correctly. It was also not possible to move a
FrameData since calling the destructor was releasing the CGImageRef.

With this change, PassNativeImagePtr is not needed anymore. So all the
instance of PassNativeImagePtr can be replaced by NativeImagePtr.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::nativeImageForCurrentTime):

• html/HTMLVideoElement.h: Replace PassNativeImagePtr with NativeImagePtr.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage): Replace PassNativeImagePtr
with NativeImagePtr.

• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):

• loader/cache/MemoryCache.h: Remove USE(CG) and CFRetain(image) since

this code can compile on all platforms. The image refcount will be
incremented when the image is assigned to FrameData.m_image in the
BitmapImage constructor.

• loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousNativeIconForPageURL):

• loader/icon/IconDatabase.h:
• loader/icon/IconDatabaseBase.h: Replace PassNativeImagePtr with NativeImagePtr.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::haveFrameImageAtIndex):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::ensureFrameIsCached):
(WebCore::BitmapImage::frameImageAtIndex):
(WebCore::BitmapImage::nativeImageForCurrentFrame):
(WebCore::BitmapImage::haveFrameAtIndex): Deleted.
(WebCore::BitmapImage::frameAtIndex): Deleted.
Replace PassNativeImagePtr with NativeImagePtr, m_frame with m_image and
*Frame* with *FrameImage*.

• platform/graphics/BitmapImage.h:

(WebCore::FrameData::FrameData):
A BitmapImage can have one or more FrameData. A FrameData member can be
named for shortness as "frame", "m_frames", etc. A FrameData can have
zero or one NativeImagePtr. A NativeImagePtr can be named as "image",
"m_image", etc.

• platform/graphics/GraphicsContext.h: Replace PassNativeImagePtr with

NativeImagePtr.

• platform/graphics/GraphicsContext3D.h:
• platform/graphics/Icon.h:

Change the members of type CGImageRef to be RetainPtr<CGImageRef>.

• platform/graphics/Image.h:

(WebCore::Image::nativeImageForCurrentFrame):
(WebCore::Image::getNSImage):
(WebCore::Image::getTIFFRepresentation):
(WebCore::Image::getCGImageRef):
(WebCore::Image::getFirstCGImageRefOfSize):
(WebCore::Image::getCGImageArray):
(WebCore::Image::getGdkPixbuf):
(WebCore::Image::getEvasObject):

• platform/graphics/ImageBuffer.h:
• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::createFrameImageAtIndex):
(WebCore::ImageSource::createFrameAtIndex): Deleted.

• platform/graphics/ImageSource.h:

Change 0 to nullptr, PassRefPtr to RefPtr and PassNativeImagePtr to
NativeImagePtr.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::nativeImageForCurrentTime):

• platform/graphics/MediaPlayer.h:
• platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::nativeImageForCurrentTime):
Replace PassNativeImagePtr with NativeImagePtr.

• platform/graphics/NativeImagePtr.h:

Make NativeImagePtr a smart pointer for CG. Get rid of PassNativeImagePtr
since NativeImagePtr is now a smart pointer on all platforms.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::nativeImageForCurrentTime):
Replace PassNativeImagePtr with NativeImagePtr.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToImage):
Since Image::nativeImageForCurrentFrame() returns a RetainPtr, move it
to m_pendingContentsImage to remove the refcount churn.

• platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):
Replace m_frame with m_image and frame* with frameImage*.

• platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):

• platform/graphics/cairo/CairoUtilities.h:

Replace PassRefPtr with RefPtr.

• platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
Replace *Frame* with *FrameImage*.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawNativeImage):
Replace PassNativeImagePtr with NativeImagePtr.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::copyImage): Create a new NativeImagePtr so it can
be moved to the BitmapImage::create().
(WebCore::copySurfaceToImageAndAdjustRect):
(WebCore::getImageData):
(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
Replace PassRefPtr with RefPtr.

• platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::FrameData::clear): No need to call CGImageRelease(). Just assign
m_image to nullptr and CGImageRelease() will be called from the RetainPtr
destructor.

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::getCGImageRef):
(WebCore::BitmapImage::getFirstCGImageRefOfSize):
(WebCore::BitmapImage::getCGImageArray):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::copyUnscaledFrameImageAtIndex):
(WebCore::BitmapImage::copyUnscaledFrameAtIndex): Deleted.
Replace CGImageRef with RetainPtr<CGImageRef>. Replace *Frame* with
*FrameImage*.

• platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
(WebCore::GraphicsContext3D::paintToCanvas):
Use m_cgImage.get() instead of m_cgImage when calling CG functions.

• platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::drawPattern):
Replace PassNativeImagePtr with NativeImagePtr. Get the raw CGImageRef
from the NativeImagePtr when calling the CG functions.

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded): Move the image argument
when calling BitmapImage::create().

(WebCore::ImageBuffer::getUnmultipliedImageData):
(WebCore::ImageBuffer::getPremultipliedImageData):
Replace PassRefPtr with RefPtr.

• platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::createFrameImageAtIndex):
(WebCore::ImageSource::createFrameAtIndex): Deleted.
Rename the function and simplify the code since the local variable
and the return value are both smart pointers.

• platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawNativeImage::DrawNativeImage):
(WebCore::DisplayList::DrawNativeImage::apply):

• platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawNativeImage::create):

• platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawNativeImage):

• platform/graphics/displaylists/DisplayListRecorder.h:

Replace PassNativeImagePtr with NativeImagePtr and use constant reference.

• platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
Call a function with its new name.

• platform/graphics/efl/IconEfl.cpp:

(WebCore::Icon::createIconForFiles):

• platform/graphics/gstreamer/ImageGStreamerCairo.cpp:

(ImageGStreamer::ImageGStreamer):

• platform/graphics/gtk/IconGtk.cpp:

(WebCore::Icon::createIconForFiles):

• platform/graphics/ios/IconIOS.mm:

(WebCore::Icon::Icon):
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::createIconForImage):

• platform/graphics/mac/IconMac.mm:

(WebCore::Icon::createIconForFiles):
Use smart pointers RetainPtr<CGImageRef> instead of raw pointers CGImageRef.
And change PassRefPtr to RefPtr and 0 to nullptr.

• platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::getTIFFRepresentation): Get the raw pointer from the
returned smart pointer.

• platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:

(WebCore::CoordinatedSurface::create):

• platform/graphics/texmap/coordinated/CoordinatedSurface.h:

Replace PassRefPtr with RefPtr.

• platform/graphics/win/IconWin.cpp:

(WebCore::Icon::createIconForFiles): Change PassRefPtr to RefPtr.

• platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create): Replace PassRefPtr with RefPtr.
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Call the function
with its new name and get the raw pointer from the returned smart pointer.

• platform/graphics/win/ImageCairoWin.cpp:

(WebCore::BitmapImage::create): Replace PassRefPtr with ReftPtr and use
the move semantics for passing the argument to BitmapImage::create().
(WebCore::BitmapImage::drawFrameMatchingSourceSize): Call the function
with its new name.

• platform/image-decoders/ImageDecoder.h:
• platform/image-decoders/cairo/ImageDecoderCairo.cpp:

(WebCore::ImageFrame::asNewNativeImage):

• platform/win/DragImageCGWin.cpp:

(WebCore::createDragImageFromImage):

• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

• svg/graphics/SVGImage.h:
• svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):

• svg/graphics/SVGImageForContainer.h:

Replace PassNativeImagePtr with NativeImagePtr.

Source/WebKit/mac:

• Misc/WebCache.mm:

(+[WebCache addImageToCache:forURL:forFrame:]):
WebCore::MemoryCache() is taking an rvalue NativeImagePtr. We need to create
NativeImagePtr from the image raw pointer when calling this function.

Source/WebKit/win:

• Plugins/PluginView.h:
• Plugins/PluginViewWin.cpp:

(WebCore::PluginView::snapshot):
Replace PassRefPtr with RefPtr.

Source/WebKit2:

• Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::createWithSurface):
(WebKit::WebCoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
(WebKit::WebCoordinatedSurface::copyToTexture):

• Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
• Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::ShareableBitmap):

• Shared/ShareableBitmap.h:

Replace PassRefPtr with RefPtr and use WTFMove() instead of RefPtr::release()
when passing the RefPtr.

• Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::createSurfaceFromData):
(WebKit::ShareableBitmap::createCairoSurface):
Replace PassRefPtr with RefPtr.

(WebKit::ShareableBitmap::createImage):

• Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createImage):
Replace PassRefPtr with RefPtr and use the move semantics when calling
BitmapImage::create().

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::createCoordinatedSurface):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::createCoordinatedSurface):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

Replace PassRefPtr with RefPtr

5:52 PM Changeset in webkit [198654] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

Safari Crashes if audio.src is changed while connected to AudioAnalyserNode
​https://bugs.webkit.org/show_bug.cgi?id=153593
<rdar://problem/23648082>

Reviewed by Eric Carlson.

m_ringBuffer is accessed on the high-priority WebAudio thread after it has been cleared (a
null-deref). Protect against unsafe access on multiple threads of a non-refcounted object by
a simple try_lock.

Additionally, limit the use of variables in use by both the separate WebAudio thread method
(provideInput()) and AVAudioMix thread method (process()) where possible, and convert to
std::atomic<> where ivars must be acessed by both threads. m_writeCount is entirely superfluous,
as it is a synonym for the endTime returned by m_ringBuffer->getCurrentFrameBounds().

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.h:
• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::provideInput):
(WebCore::AudioSourceProviderAVFObjC::prepare):
(WebCore::AudioSourceProviderAVFObjC::unprepare):
(WebCore::AudioSourceProviderAVFObjC::process):

5:36 PM WebInspectorDebugging edited by Joseph Pecoraro

Added WebKitDebug prefix to log to system console. (diff)

5:31 PM WebInspectorDebugging edited by Joseph Pecoraro

Added new WebKitDebug prefix for local inspector debugging. (diff)

4:56 PM Changeset in webkit [198653] by enrica@apple.com

• 8 edits in trunk/Source

Adopt new SPI from DataDetectorsCore to decide link behavior.
​https://bugs.webkit.org/show_bug.cgi?id=155780
rdar://problem/25303631

Reviewed by Sam Weinig.

Source/WebCore:

isDataDetectorLink and shouldCancelDefaultAction now
use the SPI provided by DataDetectorsCore to decide
what is the link behavior when the user taps on it.

• editing/cocoa/DataDetection.h:
• editing/cocoa/DataDetection.mm:

(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::isDataDetectorLink):
(WebCore::DataDetection::requiresExtendedContext):
(WebCore::DataDetection::dataDetectorIdentifier):
(WebCore::DataDetection::shouldCancelDefaultAction):

• platform/cocoa/DataDetectorsCoreSoftLink.h:
• platform/cocoa/DataDetectorsCoreSoftLink.mm:
• platform/spi/cocoa/DataDetectorsCoreSPI.h:

Source/WebKit2:

Changed use of data detection functions to take
a reference to Element instead of a pointer.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleTap):
(WebKit::WebPage::commitPotentialTap):
(WebKit::WebPage::getPositionInformation):

4:18 PM Changeset in webkit [198652] by sbarati@apple.com

• 6 edits
  4 adds in trunk

ES6: Implement IsRegExp function and use where needed in String.prototype.* methods
​https://bugs.webkit.org/show_bug.cgi?id=155854

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch is a straight forward implementation of IsRegExp
in the ES6 spec:
​https://tc39.github.io/ecma262/#sec-isregexp
We now use this IsRegExp function inside String.prototype.(startsWith | endsWith | includes)
as is dictated by the spec.

• runtime/RegExpConstructor.h:

(JSC::RegExpConstructor::recordMatch):
(JSC::isRegExp):

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
(JSC::stringProtoFuncIncludes):

• tests/es6.yaml:
• tests/es6/well-known_symbols_Symbol.match_String.prototype.endsWith.js: Added.

(test):

• tests/es6/well-known_symbols_Symbol.match_String.prototype.includes.js: Added.

(test):

• tests/es6/well-known_symbols_Symbol.match_String.prototype.startsWith.js: Added.

(test):

• tests/stress/string-prototype-methods-endsWith-startsWith-includes-correctness.js: Added.

(assert):
(test):
(test.get let):
(get let):

LayoutTests:

• js/string-includes-expected.txt:

4:16 PM Changeset in webkit [198651] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

[WK2] Disable network cache speculative validation by default
​https://bugs.webkit.org/show_bug.cgi?id=155857
<rdar://problem/25233210>

Reviewed by Alex Christensen.

Disable network cache speculative validation by default. Clients such
as Safari now use the API added in r198544 to enable if they want.

• UIProcess/API/APIProcessPoolConfiguration.h:

4:09 PM Changeset in webkit [198650] by enrica@apple.com

• 2 edits in trunk/Source/WebCore

DataDetection creates links that are longer than the actual result.
​https://bugs.webkit.org/show_bug.cgi?id=155850
rdar://problem/25280740

Reviewed by Anders Carlsson.

When a data detection result is composed of multiple fragments,
the range for the last fragment should take into account the end
offset of the query range structure, since there could be additional
content in that range that is not part of the result.

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

4:01 PM Changeset in webkit [198649] by commit-queue@webkit.org

• 32 edits
  3 deletes in trunk

Unreviewed, rolling out r198627.
​https://bugs.webkit.org/show_bug.cgi?id=155856

Caused use-after-free (Requested by ap on #webkit).

Reverted changeset:

"[Fetch API] Add basic loading of resources"
​https://bugs.webkit.org/show_bug.cgi?id=155637
​http://trac.webkit.org/changeset/198627

3:43 PM Changeset in webkit [198648] by sbarati@apple.com

• 15 edits in trunk

Web Inspector: Separate Debugger enable state from the debugger breakpoints enabled state
​https://bugs.webkit.org/show_bug.cgi?id=152193
<rdar://problem/23867520>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

When all breakpoints are disabled, we can recompile all JS
code and remove the necessary debugging code that is emitted.
This allows for the code that is executing to be almost as fast
as it is with the debugger completely disabled. This is in preparation for:
​https://bugs.webkit.org/show_bug.cgi?id=155809
which will introduce a high fidelity profiler. That profiler
could be built off the principle that breakpoints are disabled
when we're performing a high fidelity profile. Doing so, for example,
allows the sampling profiler to better measure the real performance
of the JS of a particular application.

• debugger/Debugger.cpp:

(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):

• debugger/Debugger.h:
• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

• inspector/JSGlobalObjectScriptDebugServer.cpp:

(Inspector::JSGlobalObjectScriptDebugServer::attachDebugger):
(Inspector::JSGlobalObjectScriptDebugServer::detachDebugger):

• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::enable):

• runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::queueMicrotask):
(JSC::JSGlobalObject::hasDebugger):
(JSC::JSGlobalObject::hasInteractiveDebugger):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::runtimeFlags):
(JSC::JSGlobalObject::hasDebugger): Deleted.

Source/WebCore:

No new tests because this is already tested by inspector tests.

• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::attachDebugger):
(WebCore::PageScriptDebugServer::detachDebugger):

LayoutTests:

• inspector/script-profiler/event-type-API.html:
• inspector/script-profiler/event-type-Microtask.html:
• inspector/script-profiler/event-type-Other.html:

3:35 PM Changeset in webkit [198647] by msaboff@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Create private builtin helper advanceStringIndexUnicode() for use by RegExp builtins
​https://bugs.webkit.org/show_bug.cgi?id=155855

Reviewed by Mark Lam.

Moved advanceStringIndexUnicode() as a separate helper. Added it as a private builtin
to the GlobalObject like other private builtins.

• builtins/RegExpPrototype.js:

(advanceStringIndexUnicode):
(match):
(match.advanceStringIndexUnicode): Deleted.

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

3:27 PM Changeset in webkit [198646] by jer.noble@apple.com

• 7 edits in trunk/Source/WebCore

[MSE] Make calling HTMLMediaElement.buffered less expensive
​https://bugs.webkit.org/show_bug.cgi?id=155846

Reviewed by Eric Carlson.

The MSE specification requires a new TimeRanges object be returned when calling
HTMLMediaElement.buffered. Additionally, the requirements for generating the buffered time
ranges for MediaSource and its constituent SourceBuffers are specific and expensive. Rather
than perform all these steps each time HTMLMediaElement.buffered is queried, cache the final
result and only regenerate the cached value if the buffered ranges of the consituent
SourceBuffers has changed.

Also, make copying a PlatformTimeRanges more efficient by doing a straight vector-to-vector
copy of the PlatformTimeRange's data.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::buffered):
(WebCore::MediaSource::regenerateActiveSourceBuffers):

• Modules/mediasource/MediaSource.h:
• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::removeCodedFrames):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

• Modules/mediasource/SourceBuffer.h:
• platform/graphics/PlatformTimeRanges.cpp:

(WebCore::PlatformTimeRanges::PlatformTimeRanges): Deleted.
(WebCore::PlatformTimeRanges::operator=): Deleted.
(WebCore::PlatformTimeRanges::copy): Deleted.

• platform/graphics/PlatformTimeRanges.h:

3:20 PM Changeset in webkit [198645] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce forced layouts
​https://bugs.webkit.org/show_bug.cgi?id=155852
<rdar://problem/25345197>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-24
Reviewed by Timothy Hatcher.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.layout):
(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype._positionHeaderViews):
In loops, force layout once, calculate values, then set styles.

• UserInterface/Views/RadioButtonNavigationItem.js:

(WebInspector.RadioButtonNavigationItem):
(WebInspector.RadioButtonNavigationItem.prototype.updateLayout):
Force layout once to calculate the min-width, then never again.

3:18 PM Changeset in webkit [198644] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Open Resource Dialog should not system beep when using Enter to select an item
​https://bugs.webkit.org/show_bug.cgi?id=155853

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-24
Reviewed by Timothy Hatcher.

• UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._handleKeydownEvent):
Prevent default when handling Enter with a selected result.

3:14 PM Changeset in webkit [198643] by dbates@webkit.org

• 3 edits in trunk/LayoutTests

Update expected results following <​http://trac.webkit.org/changeset/198591>
(​https://bugs.webkit.org/show_bug.cgi?id=155777)

• http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt:

1:17 PM Changeset in webkit [198642] by rniwa@webkit.org

• 10 edits
  6 adds in trunk/Websites/perf.webkit.org

Add mocha server tests for /api/build-requests
​https://bugs.webkit.org/show_bug.cgi?id=155831

Reviewed by Chris Dumez.

Added the new mocha.js based server-tests for /api/build-requests. The new harness automatically:

• starts a new Apache instance
• switches the database during testing via setting an environmental variable
• backups and restores public/data directory during testing

As a result, developer no longer has to manually setup Apache, edit config.json manually to use
a testing database, or run /api/manifest.php to re-generate the manifest file after testing.

This patch also makes ID resolution optional on /api/build-requests so that v3 model based syncing
scripts can re-use the same code as the v3 UI to process the JSON. tools/sync-with-buildbot.py has
been modified to use this option (useLegacyIdResolution).

• config.json: Added configurations for the test httpd server.
• init-database.sql: Don't error when tables and types don't exist (when database is empty).
• public/api/build-requests.php:

(main): Made the ID resolution optional with useLegacyIdResolution. Also removed "updates" from the
results JSON since it's never used.

• public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct):
(BuildRequestsFetcher::fetch_roots_for_set_if_needed): Fixed the bug that we would include the same
commit multiple times for each root set.

• public/include/db.php:

(config): If present, use ORG_WEBKIT_PERF_CONFIG_PATH instead of Websites/perf.webkit.org/config.json.

• server-tests: Added.
• server-tests/api-build-requests-tests.js: Added. Tests for /api/build-requests.

(.addMockData):

• server-tests/resources: Added.
• server-tests/resources/test-server.conf: Added. Apache configuration file for testing.
• server-tests/resources/test-server.js: Added.

(TestSever): Added.
(TestSever.prototype.start): Added.
(TestSever.prototype.stop): Added.
(TestSever.prototype.remoteAPI): Added. Configures RemoteAPI to be used with the test sever.
(TestSever.prototype.database): Added. Returns Database configured to use the test database.
(TestSever.prototype._constructTestConfig): Creates config.json for testing. The file is generated by
_start and db.php's config() reads it from the environmental variable: ORG_WEBKIT_PERF_CONFIG_PATH.
(TestSever.prototype._ensureDataDirectory): Renames public/data to public/original-data if exists,
and creates a new empty public/data.
(TestSever.prototype._restoreDataDirectory): Deletes public/data and renames public/original-data
back to public/data.
(TestSever.prototype._ensureTestDatabase): Drops the test database if exists and creates a new one.
(TestSever.prototype.initDatabase): Run init-database.sql to start each test with a consistent state.
(TestSever.prototype._executePgsqlCommand): Executes a postgres command line tool such as psql.
(TestSever.prototype._determinePgsqlDirectory): Finds the directory that contains psql.
(TestSever.prototype._startApache): Starts an Apache instance for testing.
(TestSever.prototype._stopApache): Stops the Apache instance for testing.
(TestSever.prototype._waitForPid): Waits for the Apache pid file to appear or disappear.
(before): Start the test server at the beginning.
(beforeEach): Re-initialize all tables before each test.
(after): Stop the test server at the end.

• tools/js/config.js:

(Config.prototype.path):
(Config.prototype.serverRoot): Added. The path to Websites/perf.webkit.org/public/.
(Config.prototype.pathFromRoot): Added. Resolves a path from Websites/perf.webkit.org.

• tools/js/database.js:

(Database): Now optionally takes the database name to use a different database during testing.
(Database.prototype.connect):
(Database.prototype.query): Added.
(Database.prototype.insert): Added.
(tableToPrefixMap): Maps table name to its prefix. Used by Database.insert.

• tools/js/remote.js: Added.

(RemoteAPI): Added. This is node.js equivalent of RemoteAPI in public/v3/remote.js.
(RemoteAPI.prototype.configure): Added.
(RemoteAPI.prototype.fetchJSON): Added.
(RemoteAPI.prototype.fetchJSONWithStatus): Added.
(RemoteAPI.prototype.sendHttpRequest): Added.

• tools/sync-with-buildbot.py:

(main): Use useLegacyIdResolution as this script relies on the legacy behavior.

• unit-tests/checkconfig.js: pg was never directly used in this test.

12:56 PM Changeset in webkit [198641] by Chris Dumez

• 2 edits in trunk/Source/WTF

Fix iOS9 performance regression after r197572
​https://bugs.webkit.org/show_bug.cgi?id=155845
<rdar://problem/25144924>

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-03-24
Reviewed by Chris Dumez.

• wtf/Platform.h:

Use CFURLConnection instead of NSURLConnection on internal iOS9 builds.

12:05 PM Changeset in webkit [198640] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit/mac

Fix some new PDFKit-related warnings
​https://bugs.webkit.org/show_bug.cgi?id=155847
<rdar://problem/25340312>

Reviewed by Anders Carlsson.

• WebView/WebPDFView.mm:

(-[WebPDFView setViewState:]):

• WebView/WebPreferences.mm:

(-[WebPreferences PDFDisplayMode]):
PDFDisplayMode is now a real enum.

11:56 AM Changeset in webkit [198639] by matthew_hanson@apple.com

• 4 edits
  3 adds in branches/safari-601-branch

Merge r198592. rdar://problem/25332806

11:42 AM Changeset in webkit [198638] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Improve update-webkit-dependency script.
​https://bugs.webkit.org/show_bug.cgi?id=155576

Patch by Jeremy Zerfas <WebKit@JeremyZerfas.com> on 2016-03-24
Reviewed by Brent Fulgham.

• Scripts/update-webkit-dependency:

-Updated script to also use ETags for helping to determine whether dependency is up to date.
-Updated script so it usually won't need to download the entire dependency each time it is

ran.

-Updated script to ensure zip file contains expected directories before trying to install.
-Added some more error checking and improved error messages.
(lastModifiedToUnixTime): Deleted.

• Scripts/update-webkit-wincairo-libs:

-Corrected comment about what script does.

11:42 AM Changeset in webkit [198637] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r189129): <audio> elements do not have playback controls on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=155808
<rdar://problem/23822457>

Reviewed by Eric Carlson.

Audio elements should never require fullscreen for playback.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

11:14 AM Changeset in webkit [198636] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge custom patch. rdar://problem/25152415.

11:14 AM Changeset in webkit [198635] by matthew_hanson@apple.com

• 4 edits
  3 adds in branches/safari-601.1.46-branch

Merge r198592. rdar://problem/25271136

11:14 AM Changeset in webkit [198634] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r198157. rdar://problem/25271134

11:14 AM Changeset in webkit [198633] by matthew_hanson@apple.com

• 8 edits
  8 adds in branches/safari-601.1.46-branch

Merge r195614. rdar://problem/24850429

11:04 AM Changeset in webkit [198632] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Clean up cookie jar after r198195
​https://bugs.webkit.org/show_bug.cgi?id=155484

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-03-24
Reviewed by Tim Horton.

Get rid of a now unneeded macro.

• loader/CookieJar.cpp:

(WebCore::storageSession):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):

10:54 AM Changeset in webkit [198631] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.25.0.1/Source

Versioning.

10:51 AM Changeset in webkit [198630] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.25.0.1

New tag.

10:07 AM Changeset in webkit [198629] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit2

Fix null dereferencing in NetworkLoad::continueCanAuthenticateAgainstProtectionSpace
​https://bugs.webkit.org/show_bug.cgi?id=155799
rdar://25289012

Reviewed by Tim Horton.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
Null-check all the things!

10:01 AM Changeset in webkit [198628] by achristensen@apple.com

• 2 edits in trunk/Tools

Fix webkitpy tests after r198617
​https://bugs.webkit.org/show_bug.cgi?id=155827

Patch by Bill Ming <​mbbill@gmail.com> on 2016-03-24
Reviewed by Alex Christensen.

• Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff._show_pretty_diff):

9:53 AM Changeset in webkit [198627] by youenn.fablet@crf.canon.fr

• 32 edits
  12 adds in trunk

[Fetch API] Add basic loading of resources
​https://bugs.webkit.org/show_bug.cgi?id=155637

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebasing test expectations.
Updating scheme-blob.js to ensure generated test names are stable run after run.

• web-platform-tests/fetch/api/basic/accept-header-expected.txt:
• web-platform-tests/fetch/api/basic/integrity-expected.txt:
• web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt:
• web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
• web-platform-tests/fetch/api/basic/request-forbidden-headers-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-blob-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-blob.js:

(checkFetchResponse): Deleted.
(checkKoUrl): Deleted.

• web-platform-tests/fetch/api/basic/scheme-data-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-others-expected.txt:
• web-platform-tests/fetch/api/basic/stream-response-expected.txt:

Source/WebCore:

Adding support for basic fetch for Window (no support for Worker yet).
A FetchResponse object is created for every fetch task.
But it will only be exposed to JS at promise fulfillment time, i.e. once initial response headers are retrieved.

Updating Blob resource handle to add Content-Type and Content-Length header and notifying of error in case of erroneous HTTP method.

Fetch is limited to same origin requests currently due to some WPT tests that would timeout otherwise.

Tests: http/tests/fetch/closing-while-fetching.html

http/tests/fetch/get-response-body-while-loading.html

Also covered by rebased tests.

• Modules/fetch/DOMWindowFetch.cpp: Creating a FetchResponse to start fetching.

(WebCore::DOMWindowFetch::fetch):

• Modules/fetch/DOMWindowFetch.h:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeArrayBuffer): Handling of body promises in case of data stored as a buffer.
(WebCore::FetchBody::consumeText): Passing the promise as a reference.
(WebCore::blobFromArrayBuffer): Helper routine.
(WebCore::FetchBody::fulfillTextPromise): Helper routine.
(WebCore::FetchBody::loadedAsArrayBuffer): Updated to handle storing of data as a buffer.
(WebCore::FetchBody::loadedAsText):
(WebCore::FetchBody::bodyForInternalRequest): Helper routine to generate the request body data to be sent as part of the fetch request.
(WebCore::FetchBody::extractFromText):

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::FetchBody):

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::loadBlob): Updated to cope with the change that FetchLoader::start does not return a boolean anymore
but will directly call failure callbacks.
(WebCore::FetchBodyOwner::loadedBlobAsText): Moving it closer to other blob loading routines.
(WebCore::FetchBodyOwner::finishBlobLoading):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::body):
(WebCore::FetchBodyOwner::loadedBlobAsArrayBuffer):

• Modules/fetch/FetchHeaders.cpp:

(WebCore::FetchHeaders::fill):
(WebCore::FetchHeaders::filterAndFill): Helper routine to fill headers from a HTTPHeaderMap after being filtered.

• Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::internalHeaders):

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFailRedirectCheck):

• Modules/fetch/FetchLoader.h:
• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::internalRequest): Routine used to create the ResourceRequest transmitted to ThreadableLoader.

• Modules/fetch/FetchRequest.h:

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch): Start fetching by creating a FetchLoader based on passed request.
(WebCore::FetchResponse::BodyLoader::didSucceed): FetchLoader callback.
(WebCore::FetchResponse::BodyLoader::didFail): Ditto.
(WebCore::FetchResponse::BodyLoader::BodyLoader): Ditto.
(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Ditto.
(WebCore::FetchResponse::BodyLoader::didFinishLoadingAsArrayBuffer): Ditto.
(WebCore::FetchResponse::BodyLoader::start): Starting fetch loader.
(WebCore::FetchResponse::BodyLoader::stop): Stopping fetch loader.
(WebCore::FetchResponse::stop): Stop loader if any.

• Modules/fetch/FetchResponse.h:
• platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::doStart: Notifying the loader with an error if verb is not GET.
(WebCore::BlobResourceHandle::notifyResponseOnSuccess): Adding support for Content-Type and Content-Lenth headers.
(WebCore::BlobResourceHandle::createAsync): Removing GET verb check.

LayoutTests:

• TestExpectations: Removed flaky test expectations.
• http/tests/fetch/closing-while-fetching-expected.txt: Added.
• http/tests/fetch/closing-while-fetching.html: Added.
• http/tests/fetch/get-response-body-while-loading-expected.txt: Added.
• http/tests/fetch/get-response-body-while-loading.html: Added.
• http/tests/resources/download-json-with-delay.php: Added.
• platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added.

9:20 AM Changeset in webkit [198626] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Remove virtual inheritance from SVGTransformable.
<​https://webkit.org/b/155837>

Reviewed by Anders Carlsson.

Nothing else inherits SVGLocatable, so make the inheritance non-virtual.

• svg/SVGTransformable.h:

9:13 AM Changeset in webkit [198625] by msaboff@apple.com

• 3 edits
  1 add in trunk/Source/JavaScriptCore

[ES6] Add Proxy based tests for RegExp.prototype[@@match]
​https://bugs.webkit.org/show_bug.cgi?id=155807

Reviewed by Saam Barati.

Added new test that uses Proxy to verify RegExp.prototype[@@match] processing
conforms to the ES6 standard

Modified builtin RegExp.prototype[@@match] to be ES6 spec conformant.

Updated es6.yaml as Proxy_internal_get_calls_RegExp.prototype[Symbol.match].js now passes.

• builtins/RegExpPrototype.js:

(match):

• tests/es6.yaml: Updated.
• tests/stress/regexp-match-proxy.js: Added.

(assert):
(let.getProxyNullExec.new.Proxy):
(let.getSetProxyNullExec.new.Proxy):
(get resetTracking):
(let.getSetProxyMatches_s.new.Proxy):
(set get getSetProxyNullExec):
(let.getSetProxyMatches_tx_Greedy.new.Proxy):
(set get getSetProxyMatches_s):
(let.getSetProxyMatchesUnicode_digit_nonGreedy.new.Proxy):
(set get getSetProxyMatches_tx_Greedy):

7:19 AM Changeset in webkit [198624] by msaboff@apple.com

• 7 edits in trunk

[ES6] Greedy unicode RegExp's don't properly backtrack past non BMP characters
​https://bugs.webkit.org/show_bug.cgi?id=155829

Reviewed by Saam Barati.

Source/JavaScriptCore:

When we backup when matching part of a unicode pattern, we can't just backup one character.
Instead we need to save our start position before trying to match a character and
restore the position if the match fails. This was done in other places, but wasn't
done for all greedy types.

Fixed matchGlobal() to properly handle advancing past non BMP characters.

• runtime/RegExpObject.cpp:

(JSC::RegExpObject::matchGlobal):

• runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::advanceStringUnicode):

• yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::matchCharacterClass):
(JSC::Yarr::Interpreter::matchDisjunction):

LayoutTests:

Added new test cases.

• js/regexp-unicode-expected.txt:
• js/script-tests/regexp-unicode.js:

6:27 AM Changeset in webkit [198623] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip passing tests, which have been passed a long time ago.
Failed to track correct revision on EFL buildbot.

• platform/efl/TestExpectations:

3:36 AM Changeset in webkit [198622] by youenn.fablet@crf.canon.fr

• 5 edits in trunk/Source/WebCore

Remove DeferredWrapper::resolve<Vector<unsigned char>>
​https://bugs.webkit.org/show_bug.cgi?id=154849

Reviewed by Darin Adler.

Adding fulfillPromiseWithArrayBuffer to resolve a promise with an ArrayBuffer.
If the ArrayBuffer is null, the promise is rejected with an OutOfMemory exception.

Not covered by tests since we would need to make tryCreate return null on failing allocation.

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::loadedAsArrayBuffer):

• bindings/js/JSDOMPromise.cpp:

(WebCore::fulfillPromiseWithArrayBuffer):

• bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve<JSC::JSValue>): Deleted.
(WebCore::DeferredWrapper::resolve): Deleted.

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::digest):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):

2:02 AM Changeset in webkit [198621] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/Source/JavaScriptCore

[JSC] In some cases, the integer range optimization phase never converges
​https://bugs.webkit.org/show_bug.cgi?id=155828
rdar://problem/25155460

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-03-24
Reviewed by Filip Pizlo.

In certain conditions, the integer range optimization phase continuously
changes the representation of the same truth, preventing it from
converging to a stable state.

The bug starts by having the same ground truth incomming into a block
in different valid forms. For example, you can have x < 42 coming as:

1) x < 42
2) x < 41 + 1
3) x < 43 - 1

Having those 3 alone coming from predecessors would be okay, we would
just accumulate them. The problem is when you have a combination
of rule that filter out the previously obtained truth, then add a new
form of the same truth.

Let's use the test case as an example. We have two incoming blocks:

Block #1:

-i < 42
-i != 41

Block #2:

-i < 41
-i == 42 - 42 (i == 0 refining the rule above).

Let say that our conditions at head are now [i < 41, i < 42 - 1].

If we merge block #2:

-i < 42 and i < 41 -> i < 42
-i < 42 and i < 42 - 1 -> i < 42
-i != 41 and i < 41 -> i < 41
-i != 41 and i < 42 - 1 -> nothing

The new head is: [i < 41, i < 42]

If we merge block #1:

-i < 41 and i < 41 -> i < 41
-i < 41 and i < 42 -> i < 42
-i == 42 - 42 and i < 41 -> (i < 41 and i < 42 - 1)
-i == 42 - 42 and i < 42 -> i < 42

After filter, we are back to [i < 41, i < 42 - 1].

There are several variations of this idea where the same truth
rotate different forms with each merge().

One possible solution is to make filter() more aggressive
to avoid the better form occuring at merge(). I'll probably
do that at some point but that seems fragile since the same
problem could reappear if merge() is later improved.

For this patch, I went with a more generic solution after
merge(): if the generated form is equivalent to one that
previously existed at head, pick the existing form.

In the previous example, what happens is we only have
either [i < 41] or [i < 42 - 1] but never both simultaneously.

• dfg/DFGIntegerRangeOptimizationPhase.cpp:
• tests/stress/integer-range-optimization-constant-representation-1.js: Added.
• tests/stress/integer-range-optimization-constant-representation-2.js: Added.

Two variation. One timeout in release because of the additional flags.
The other is gets more type of run but only assert in debug.

1:10 AM Changeset in webkit [198620] by commit-queue@webkit.org

• 13 edits in trunk/Source/WebInspectorUI

Web Inspector: Miscellaneous performance fixes in Timeline recording
​https://bugs.webkit.org/show_bug.cgi?id=155832

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-24
Reviewed by Timothy Hatcher.

• UserInterface/Models/CallingContextTree.js:

(WebInspector.CCTNode.prototype.hasChildren):
No need to allocate an array with all of the properties, we can just
check if there is at least one property using a short circuit for..in.
Performance was always faster for empty, small, and large objects
in micro benchmarks.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.layout):
Avoid causing DOM layout when positioning resizers. They only need
a layout if we are resizing the DataGrid, or the initial layout.

• UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar):
(WebInspector.NavigationBar.prototype.needsLayout):
(WebInspector.NavigationBar.prototype.layout):
Avoid causing DOM layout every View layout. In fact, only do a
DOM layout when someone has triggered a needsLayout on this
navigation bar. A basic dirty layout (triggered by a parent)
should not have caused us to resize.

• UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
• UserInterface/Views/LayoutTimelineOverviewGraph.js:

(WebInspector.LayoutTimelineOverviewGraph.prototype.layout):

• UserInterface/Views/MemoryTimelineOverviewGraph.js:

(WebInspector.MemoryTimelineOverviewGraph.prototype.reset):
(WebInspector.MemoryTimelineOverviewGraph.prototype._updateLegend):

• UserInterface/Views/NetworkTimelineOverviewGraph.js:
• UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.layout):

• UserInterface/Views/ScriptTimelineOverviewGraph.js:

Avoid doing any work in non-visible graphs. This was very common
because the RenderingFrameTimelineOverviewGraph is never visible
when the other timeline graphs are, but was performing lots of work.

• UserInterface/Views/MemoryCategoryView.js:

(WebInspector.MemoryCategoryView.prototype.clear):
(WebInspector.MemoryCategoryView.prototype._updateDetails):
(WebInspector.MemoryCategoryView):

• UserInterface/Views/MemoryTimelineView.js:

(WebInspector.MemoryTimelineView.prototype.reset):
(WebInspector.MemoryTimelineView.prototype._updateUsageLegend):
(WebInspector.MemoryTimelineView.prototype._updateMaxComparisonLegend):
Cache values to avoid textContent calls even if the content did not change.
This reduces unnecessary work when the values wouldn't change.

• UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):
(WebInspector.TimelineRecordBar.prototype.set records):
Revert to fast loop and as this code path is very hot and for..of iteration
was showing up in profiles. Remove assert which seems rather pointless but
showed up in profiles.

12:13 AM Changeset in webkit [198619] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Large repaints while typing in the console tab
​https://bugs.webkit.org/show_bug.cgi?id=155627
<rdar://problem/25234875>

Reviewed by Timothy Hatcher.

Use a position: absolute workaround to reduce large repaint areas caused by flexbox.

• UserInterface/Views/LogContentView.css:

(body.selected-tab-console #content):
This selector must only affect the console tab as it breaks sidebars in other tabs.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._tabBarItemSelected):

• UserInterface/Views/TabBar.js:

(WebInspector.TabBar.prototype.set selectedTabBarItem):
Add "selected-tab-console" class to <body> when the console tab is selected.

Mar 23, 2016:

11:32 PM Changeset in webkit [198618] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline range selection changes with ProfileView should not cause navigation bar items to flicker
​https://bugs.webkit.org/show_bug.cgi?id=155834

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-23
Reviewed by Timothy Hatcher.

• UserInterface/Views/ProfileView.js:

(WebInspector.ProfileView.prototype._recreate):
The only reason our selection path components would change is if we
had focus nodes before and do not anymore.

10:16 PM Changeset in webkit [198617] by commit-queue@webkit.org

• 2 edits in trunk/Tools

webkit-patch failed to open pretty diff on Windows
​https://bugs.webkit.org/show_bug.cgi?id=155827

Patch by Bill Ming <​mbbill@gmail.com> on 2016-03-23
Reviewed by Alex Christensen.

• Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff._show_pretty_diff):

10:13 PM Changeset in webkit [198616] by commit-queue@webkit.org

• 2 edits in trunk

Fixed ninja build path.
​https://bugs.webkit.org/show_bug.cgi?id=155796

Patch by Bill Ming <​mbbill@gmail.com> on 2016-03-23
Reviewed by Alex Christensen.

• Tools/Scripts/build-webkit:

8:31 PM Changeset in webkit [198615] by rniwa@webkit.org

• 1 edit
  1 delete in trunk/Websites/perf.webkit.org

Delete a file that was supposed to be removed in r198614 for real.

• unit-tests/resources/v3-models.js: Removed.

8:25 PM Changeset in webkit [198614] by rniwa@webkit.org

• 6 edits
  2 copies
  2 adds in trunk/Websites/perf.webkit.org

Add a model for parsing buildbot JSON with unit tests
​https://bugs.webkit.org/show_bug.cgi?id=155814

Reviewed by Joseph Pecoraro.

Added BuildbotSyncer and BuildbotBuildEntry classes to parse buildbot JSON files with unit tests.
They will be used in the new syncing scripts to improve A/B testing.

• public/v3/models/build-request.js:

(BuildRequest):

• tools/js/buildbot-syncer.js: Added.

(BuildbotBuildEntry): Added.
(BuildbotBuildEntry.prototype.slaveName): Added.
(BuildbotBuildEntry.prototype.buildRequestId): Added.
(BuildbotBuildEntry.prototype.isInProgress): Added.
(BuildbotSyncer): Added.
(BuildbotSyncer.prototype.testPath): Added.
(BuildbotSyncer.prototype.builderName): Added.
(BuildbotSyncer.prototype.platformName): Added.
(BuildbotSyncer.prototype.fetchPendingRequests): Added.
(BuildbotSyncer.prototype._propertiesForBuildRequest): Added.
(BuildbotSyncer.prototype._revisionSetFromRootSetWithExclusionList): Added.
(BuildbotSyncer._loadConfig): Added.
(BuildbotSyncer._validateAndMergeConfig): Added.
(BuildbotSyncer._validateAndMergeProperties): Added.

• tools/js/v3-models.js: Copied from unit-tests/resources/v3-models.js.

(beforeEach): Deleted since this only defined inside mocha.

• unit-tests/analysis-task-tests.js:
• unit-tests/buildbot-syncer-tests.js: Added.

(sampleiOSConfig):
(createSampleBuildRequest):
(.smallConfiguration):

• unit-tests/measurement-adaptor-tests.js:
• unit-tests/measurement-set-tests.js:
• unit-tests/resources/mock-v3-models.js: Renamed from unit-tests/resources/v3-models.js.

(beforeEach):

• unit-tests/test-groups-tests.js:

(sampleTestGroup):

7:41 PM Changeset in webkit [198613] by dbates@webkit.org

• 3 edits in trunk/Source/WebCore

CSP: Simplify logic for checking policies
​https://bugs.webkit.org/show_bug.cgi?id=155817
<rdar://problem/25326546>

Reviewed by Zalan Bujtas.

Consolidate the various static template functions into a single function called ContentSecurityPolicy::allPoliciesAllow()
that tests whether a resource request when evaluated with respect to a directive (given as a ContentSecurityPolicyDirectiveList
pointer-to-member function) violates any of the CSPs that were delivered with the document.

No functionality changed. So, no new tests.

• page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allPoliciesAllowHashFromContent): Formerly name isAllowedByAllWithHash. Made it
a member function so that we query for the document encoding instead of taking it as an argument. Modified
it to take a predicate function to pass it to allPoliciesAllow().
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs): Modified to use ContentSecurityPolicy::allPoliciesAllow().
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers): Ditto.
(WebCore::ContentSecurityPolicy::allowScriptWithNonce): Ditto.
(WebCore::ContentSecurityPolicy::allowStyleWithNonce): Ditto.
(WebCore::ContentSecurityPolicy::allowInlineScript): Modified to use ContentSecurityPolicy::allPoliciesAllow() and
ContentSecurityPolicy::allPoliciesAllowHashFromContent().
(WebCore::ContentSecurityPolicy::allowInlineStyle): Ditto.
(WebCore::ContentSecurityPolicy::allowEval): Modified to use ContentSecurityPolicy::allPoliciesAllow().
(WebCore::ContentSecurityPolicy::allowFrameAncestors): Ditto.
(WebCore::ContentSecurityPolicy::allowPluginType): Ditto.
(WebCore::ContentSecurityPolicy::allowScriptFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowObjectFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowChildContextFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowImageFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowStyleFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowFontFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowMediaFromSource): Ditto.
(WebCore::ContentSecurityPolicy::allowConnectToSource): Ditto.
(WebCore::ContentSecurityPolicy::allowFormAction): Ditto.
(WebCore::ContentSecurityPolicy::allowBaseURI): Ditto.
(WebCore::isAllowedByAllWithFrame): Deleted.
(WebCore::isAllowedByAll): Deleted.
(WebCore::isAllowedByAllWithState): Deleted.
(WebCore::isAllowedByAllWithContext): Deleted.
(WebCore::isAllowedByAllWithNonce): Deleted.
(WebCore::isAllowedByAllWithHash): Deleted.
(WebCore::isAllowedByAllWithHashFromContent): Deleted.
(WebCore::isAllowedByAllWithURL): Deleted.
(WebCore::ContentSecurityPolicy::documentEncoding): Deleted. Incorporated its functionality into ContentSecurityPolicy::allPoliciesAllowHashFromContent().
(WebCore::ContentSecurityPolicy::isActive): Deleted. This function has been unused since the removal of the CSP script
interface in <​http://trac.webkit.org/changeset/197142>.

• page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::allPoliciesAllow): Added. Returns whether the predicate function evaluates to true
for all CSP policies.

7:40 PM Changeset in webkit [198612] by jonlee@apple.com

• 5 edits in trunk/PerformanceTests

Update focus and leaves tests
​https://bugs.webkit.org/show_bug.cgi?id=155825

Reviewed by Simon Fraser.

Particles would improperly disappear, before they were fully off stage. Update the calculation.

• Animometer/tests/dom/resources/leaves.js:
• Animometer/tests/master/resources/leaves.js:

• Animometer/tests/master/focus.html: Update the center element styling.
• Animometer/tests/master/resources/focus.js:

(FocusElement.Utilities.createClass): Give enough space in the container for each particle for the blur
to spread. It should be about 3x more space than the blur radius on each side.
(Stage.call.initialize): Ditto for the center element.

7:40 PM Changeset in webkit [198611] by jonlee@apple.com

• 11 edits
  1 delete in trunk/PerformanceTests

Update support for other platforms
​https://bugs.webkit.org/show_bug.cgi?id=155824

Reviewed by Simon Fraser.

• Animometer/resources/debug-runner/animometer.css: Remove extraneous media query. All of it should

be handled in the release stylesheet.

• Animometer/resources/debug-runner/animometer.js: Add support for browsers that return an HTMLCollection

when retrieving radio elements with a name, instead of the selected value.

• Animometer/resources/runner/animometer.css: Adjust the queries for devices of varying widths.

(.frame-container): Move overflow:hidden to #stage.

• Animometer/tests/master/resources/stage.css: Consolidate into tests/resources/stage.css.
• Animometer/tests/resources/stage.css:

(body): Remove overflow:hidden.
(#stage): Set overflow:hidden here.
(#center-text): Moved from master/resources/stage.css.

Update stylesheet hrefs.

• Animometer/tests/master/canvas-stage.html:
• Animometer/tests/master/focus.html:
• Animometer/tests/master/leaves.html:
• Animometer/tests/master/multiply.html:
• Animometer/tests/master/particles.html:
• Animometer/tests/master/text.html: Adjust text size to fit in the device screen.

7:08 PM Changeset in webkit [198610] by jonlee@apple.com

• 7 edits in trunk/PerformanceTests

Make the benchmark require device to be in landscape orientation
​https://bugs.webkit.org/show_bug.cgi?id=155822
rdar://problem/25258650

Reviewed by Ryosuke Niwa.

Check that the device is in landscape orientation. If not, disable the button to start it,
and show a warning message.

• Animometer/developer.html: Add a message about how the browser should be set up. Include a

warning message that appears if the orientation is incorrect on mobile devices.

• Animometer/index.html: Ditto.

• Animometer/resources/debug-runner/animometer.css: Migrate the .hidden rule into the release

stylesheet. Update the style to accommodate the new UI.

• Animometer/resources/runner/animometer.css:

• Animometer/resources/runner/animometer.js:

(window.benchmarkController.initialize): Add the orientation listener is needed.
(window.benchmarkController.addOrientationListenerIfNecessary): Only mobile devices need this. Check
to see for support of window.orientation.
(window.benchmarkController._orientationChanged): Toggle the warning based on whether we match the
landscape query. Set a state variable, which is needed for the debug harness. Call updateStartButtonState.
(window.benchmarkController.updateStartButtonState):

• Animometer/resources/debug-runner/animometer.js: Change _updateStartButtonState to return

a boolean about whether at least one test is selected. That will be used in
benchmarkController.updateStartButtonState(). Move the load event listener to the release version.
(window.benchmarkController.updateStartButtonState): Override the release version, and also check
that at least one test is selected.

5:43 PM Changeset in webkit [198609] by jer.noble@apple.com

• 2 edits
  2 adds in trunk

Media elements allowed to play without a user gesture, but requiring fullscreen playback, should not be allowed to autoplay.
​https://bugs.webkit.org/show_bug.cgi?id=155599

Reviewed by Darin Adler.

Test: media/video-autoplay-allowed-but-fullscreen-required.html

Entering fullscreen should always require a user gesture.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

5:42 PM Changeset in webkit [198608] by jer.noble@apple.com

• 2 edits in trunk/Tools

[ios-sim] RequiresUserActionForPlaybackTest.DoesNotRequireUserActionForMediaPlayback and RequiresUserActionForVideoButNotAudioPlayback failing
​https://bugs.webkit.org/show_bug.cgi?id=155764

Reviewed by Eric Carlson.

Remove the requirement for media elements to have webkit-playsinline attributes on iOS.

• TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:

(RequiresUserActionForPlaybackTest::SetUp):

5:13 PM Changeset in webkit [198607] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r198538.
​https://bugs.webkit.org/show_bug.cgi?id=155819

Broke two API tests on iOS simulator (Requested by ap on
#webkit).

Reverted changeset:

"Media elements allowed to play without a user gesture, but
requiring fullscreen playback, should not be allowed to
autoplay."
​https://bugs.webkit.org/show_bug.cgi?id=155599
​http://trac.webkit.org/changeset/198538

5:12 PM Changeset in webkit [198606] by ggaren@apple.com

• 9 edits
  1 add in trunk/Source/bmalloc

bmalloc: Added an Object helper class
​https://bugs.webkit.org/show_bug.cgi?id=155818

Reviewed by Gavin Barraclough.

Object is an abstraction that breaks out a void* into its component
metadata pointers.

This is slightly faster than recomputing them, and it enables a future
patch in which Object will tell us whether it is small or large.

• bmalloc.xcodeproj/project.pbxproj: Added to the project.

• bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Use Object to compute size.

• bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):

• bmalloc/Heap.cpp:

(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::deallocateSmallLine):

• bmalloc/Heap.h:

(bmalloc::Heap::derefSmallLine): Use Object to deallocate.

• bmalloc/Object.h: Added.

(bmalloc::Object::Object):
(bmalloc::Object::chunk):
(bmalloc::Object::line):
(bmalloc::Object::page): Helper class to break out a void* into its
component metadata pointers.

• bmalloc/SmallChunk.h:

(bmalloc::SmallChunk::SmallChunk): SmallPage::get doesn't exist anymore
so we use our new helper functions instead.

(bmalloc::SmallChunk::offset):
(bmalloc::SmallChunk::object):
(bmalloc::SmallChunk::page):
(bmalloc::SmallChunk::line):
(bmalloc::SmallLine::begin):
(bmalloc::SmallLine::end):
(bmalloc::SmallPage::begin): New helpers that operate on the data
stored in Object.

(bmalloc::SmallLine::get): Deleted.
(bmalloc::SmallPage::get): Deleted.

• bmalloc/SmallLine.h:

(bmalloc::SmallLine::refCount): Added a default ref value for convenience.

• bmalloc/SmallPage.h:

(bmalloc::SmallPage::SmallPage):

4:47 PM Changeset in webkit [198605] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Allow clicking the Timeline in Editing Mode to toggle the checkbox
​https://bugs.webkit.org/show_bug.cgi?id=155815

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-23
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype._startEditingInstruments):
Remove unused variable.

• UserInterface/Views/TimelineTreeElement.js:

(WebInspector.TimelineTreeElement.prototype.onattach):
(WebInspector.TimelineTreeElement.prototype._clickHandler):
Make clicking on the tree element toggle the checkbox.

4:47 PM Changeset in webkit [198604] by andersca@apple.com

• 5 edits
  1 add in trunk

Crash when using KVO from within -[WebView initWithCoder:]
​https://bugs.webkit.org/show_bug.cgi?id=155816
rdar://problem/17073265

Reviewed by Dan Bernstein.

Source/WebKit/mac:

Get rid of the observationInfo getter and setter. It's not clear why they were added (in 2003),
and the methods on NSObject are good enough for us.

• WebView/WebView.mm:

(-[WebView setObservationInfo:]): Deleted.
(-[WebView observationInfo]): Deleted.

• WebView/WebViewData.h:

Tools:

Add test.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Added.

(-[EarlyKVOCrashResponder initWithWebView:]):
(-[EarlyKVOCrashResponder initWithCoder:]):
(-[EarlyKVOCrashResponder dealloc]):
(-[EarlyKVOCrashResponder encodeWithCoder:]):
(TestWebKitAPI::TEST):

4:42 PM Changeset in webkit [198603] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline Tab sometimes restores as blank
​https://bugs.webkit.org/show_bug.cgi?id=155811

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-23
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.restoreFromCookie):
When early bailing in restore, if there is no content view to restore,
then at least fallback to showing the Overview.

3:45 PM Changeset in webkit [198602] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Timeline Reset does not clear datagrids
​https://bugs.webkit.org/show_bug.cgi?id=155804

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-23
Reviewed by Timothy Hatcher.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView.prototype.shown):
(WebInspector.HeapAllocationsTimelineView.prototype.hidden):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype.reset):
Although we don't use the popover features of TimelineDataGrid,
be a good citizen and call methods on the datagrid.

• UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.reset):
Clear the datagrid on reset.

• UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.reset):
Clear the datagrid on reset.

3:45 PM Changeset in webkit [198601] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exceptions closing Timeline tab
​https://bugs.webkit.org/show_bug.cgi?id=155805

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-23
Reviewed by Timothy Hatcher.

• UserInterface/Views/ScriptClusterTimelineView.js:

(WebInspector.ScriptClusterTimelineView.prototype._scriptClusterViewCurrentContentViewDidChange):
Gracefully handle if there is no content view.

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.closed): Deleted.
Fix typo.

3:33 PM Changeset in webkit [198600] by commit-queue@webkit.org

• 8 edits
  2 deletes in trunk

Unreviewed, rolling out r198582.
​https://bugs.webkit.org/show_bug.cgi?id=155812

"It broke debugging in the web inspector" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"We should not disable inlining when the debugger is enabled"
​https://bugs.webkit.org/show_bug.cgi?id=155741
​http://trac.webkit.org/changeset/198582

3:27 PM Changeset in webkit [198599] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Change the paint count indicator to indicate whether a layer is opaque
​https://bugs.webkit.org/show_bug.cgi?id=155810

Reviewed by Tim Horton.

In non-opaque layers, give the paint count indicator a diagonal top left corner. Being
able to see layer opaqueness helps diagnose bugs.

Also use CGContextStateSaver, and move the indicator in by a pixel to overlap less
with the layer border.

• platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawRepaintIndicator):

2:55 PM Changeset in webkit [198598] by rniwa@webkit.org

• 6 edits
  1 add in trunk/Websites/perf.webkit.org

Add unit tests for test-group.js
​https://bugs.webkit.org/show_bug.cgi?id=155781

Reviewed by Joseph Pecoraro.

Added unit tests for test-group.js that would have caught regressions fixed in r198503.

• public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype._renderAnnotations): Added a forgotten break statement.

• public/v3/models/build-request.js:

(BuildRequest.prototype.setResult):
(BuildRequest):

• public/v3/models/test-group.js:
• unit-tests/measurement-set-tests.js: Use ./resources/v3-models.js to reduce the code duplication.
• unit-tests/resources/v3-models.js: Import more stuff from v3 models.

(beforeEach):

• unit-tests/test-groups-tests.js: Added. Added some unit tests for TestGroup.

(sampleTestGroup):
(.testGroupWithStatusList):

2:40 PM Changeset in webkit [198597] by Alan Bujtas

• 3 edits
  2 adds in trunk

ASSERTION FAILED: y2 >= y1 in WebCore::RenderElement::drawLineForBoxSide
​https://bugs.webkit.org/show_bug.cgi?id=155791

Reviewed by Simon Fraser.

With certain combination of border rect and adjacent width, we could end up with an empty final rect.
This patch ensures that we don't try to paint this empty rect.

Source/WebCore:

Test: fast/borders/empty-outline-border-assert.html

• rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide):

LayoutTests:

• fast/borders/empty-outline-border-assert-expected.txt: Added.
• fast/borders/empty-outline-border-assert.html: Added.

2:29 PM Changeset in webkit [198596] by Lucas Forschler

• 2 edits in trunk/Tools

Teach kill-old-processes about perl 5.18.

Reviewed by Alexey Proskuryakov

• BuildSlaveSupport/kill-old-processes:

(main):

2:20 PM Changeset in webkit [198595] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Screen queries should query the exact screen, not a default
​https://bugs.webkit.org/show_bug.cgi?id=155806
<rdar://problem/25322916>

Reviewed by Simon Fraser.

Some of our media queries were using helper functions that
would query the capabilities of the deepest screen, rather
than the currently used screen. I changed them to use
the existing helper function (that works with WebKit 2)
and comment in some other helpers why a generic check is
ok.

Covered by the existing tests.

• platform/mac/PlatformScreenMac.mm:

(WebCore::screenDepth): Use the helper function.
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome): Move these and make a comment.
(WebCore::screenHasInvertedColors):

2:07 PM Changeset in webkit [198594] by ggaren@apple.com

• 6 edits in trunk/Source/bmalloc

bmalloc: process the object log before asking for new memory
​https://bugs.webkit.org/show_bug.cgi?id=155801

Reviewed by Gavin Barraclough.

This is a step toward merging large and small objects: In future, if we
have large objects in the log, we need to process them right away to
avoid pushing up peak memory use.

But it also appears to be a speedup and memory use improvement now.

• bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate):
(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::allocateLarge): Process the log before asking for
more memory.

• bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):
(bmalloc::Deallocator::deallocateSlowCase):

• bmalloc/Deallocator.h: Provide a public API for processing the object log.

• bmalloc/Heap.cpp:

(bmalloc::Heap::allocateSmallPage): Pop fragmented pages from the front
instead of from the back. This resolves a regression on tree_churn
--parallel. Popping from the front gives us the oldest pages. The oldest
pages have had the most time to accumulate free lines. They are therefore
the least fragmented on average.

• bmalloc/List.h:

(bmalloc::List::popFront):
(bmalloc::List::insertAfter): New API to pop from front.

2:06 PM Changeset in webkit [198593] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

MiniBrowser doesn't use accelerated drawing in WebKit2 windows if a WebKit1 window was opened first
​https://bugs.webkit.org/show_bug.cgi?id=141576
<rdar://problem/25304548>

Reviewed by Simon Fraser.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences init]):
Make the NSUserDefaults key prefix for debug preferences (the only ones read
from NSUserDefaults) "WebKitDebug" instead of just "WebKit" so that they
don't conflict with the names that WebKit1 registers default values for.

2:03 PM Changeset in webkit [198592] by msaboff@apple.com

• 4 edits
  3 adds in trunk

JavaScriptCore ArrayPrototype::join shouldn't cache butterfly when it makes effectful calls
​https://bugs.webkit.org/show_bug.cgi?id=155776

Reviewed by Saam Barati.

Source/JavaScriptCore:

Array.join ends up calling toString, possibly on some object. Since these calls
could be effectful and could change the array itself, we can't hold the butterfly
pointer while making effectful calls. Changed the code to fall back to the general
case when an effectful toString() call might be made.

• runtime/ArrayPrototype.cpp:

(JSC::join):

• runtime/JSStringJoiner.h:

(JSC::JSStringJoiner::appendWithoutSideEffects): New helper that doesn't make effectful
toString() calls.
(JSC::JSStringJoiner::append): Built upon appendWithoutSideEffects.

LayoutTests:

New test.

• js/regress-155776-expected.txt: Added.
• js/regress-155776.html: Added.
• js/script-tests/regress-155776.js: Added.

(fillBigArrayViaToString):
(Function.prototype.toString):

1:58 PM Changeset in webkit [198591] by dbates@webkit.org

• 168 edits in trunk

CSP: Make violation console messages concise and consistent
​https://bugs.webkit.org/show_bug.cgi?id=155777
<rdar://problem/25304031>

Reviewed by Darin Adler.

Source/WebCore:

As a first step towards making the log messages that are emitted by the ContentSecurityPolicy object
concise and consistent with the language and formatting used in other WebKit console messages, including
other Content Security Policy messages, make the violation error messages concise and consistent.
Being concise and consistent will help make it straightforward for a person to understand the reason
for the violation by taking advantage of their familiarity with the language and formatting seen in
other WebKit console messages.

• page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::consoleMessageForViolation): Added. Builds up a console message for violation.
(WebCore::ContentSecurityPolicyDirectiveList::allowJavaScriptURLs): Extract logic for logging a console message/reporting
a violation from ContentSecurityPolicyDirectiveList::checkInlineAndReportViolation() to here and make use of WebCore::consoleMessageForViolation()
to build the actual console message.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineEventHandlers): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineScript): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowInlineStyle): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowEval): Extract logic for logging a console message/reporting
a violation from ContentSecurityPolicyDirectiveList::checkEvalAndReportViolation() to here and make use of WebCore::consoleMessageForViolation()
to build the actual console message.
(WebCore::ContentSecurityPolicyDirectiveList::allowPluginType): Extract logic for logging a console message/reporting
a violation from ContentSecurityPolicyDirectiveList::checkMediaTypeAndReportViolation() to here and make use of WebCore::consoleMessageForViolation()
to build the actual console message.
(WebCore::ContentSecurityPolicyDirectiveList::allowScriptFromSource): Extract logic for logging a console message/reporting
a violation from ContentSecurityPolicyDirectiveList::checkSourceAndReportViolation() to here and make use of WebCore::consoleMessageForViolation()
to build the actual console message.
(WebCore::ContentSecurityPolicyDirectiveList::allowObjectFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildContextFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowChildFrameFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowImageFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowStyleFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowFontFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowMediaFromSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowConnectToSource): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowFormAction): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowBaseURI): Ditto.
(WebCore::ContentSecurityPolicyDirectiveList::allowFrameAncestors): Extract logic for logging a console message/reporting
a violation from ContentSecurityPolicyDirectiveList::checkFrameAncestorsAndReportViolation() to here and make use of WebCore::consoleMessageForViolation()
to build the actual console message.
(WebCore::ContentSecurityPolicyDirectiveList::addDirective): Add FIXME comment to log that the frame-src directive is
deprecated. See <​https://bugs.webkit.org/show_bug.cgi?id=155773> for more details.
(WebCore::ContentSecurityPolicyDirectiveList::checkEvalAndReportViolation): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::checkMediaTypeAndReportViolation): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::checkInlineAndReportViolation): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::checkSourceAndReportViolation): Deleted.
(WebCore::ContentSecurityPolicyDirectiveList::checkFrameAncestorsAndReportViolation): Deleted.

• page/csp/ContentSecurityPolicyDirectiveList.h:

LayoutTests:

Update expected results to reflect new violation message text.

• fast/workers/worker-inherits-csp-blocks-xhr-expected.txt:
• http/tests/contentextensions/block-cookies-in-csp-report-expected.txt:
• http/tests/contentextensions/block-csp-report-expected.txt:
• http/tests/contentextensions/hide-on-csp-report-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt:
• http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt:

...

• http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/xsl-redirect-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt:
• http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
• http/tests/security/isolatedWorld/image-load-should-not-bypass-main-world-csp-expected.txt:
• media/csp-blocks-video-expected.txt:

1:08 PM Changeset in webkit [198590] by Matt Baker

• 2 edits
  18 adds in trunk/Source/WebInspectorUI

Web Inspector: Quick Open dialog has fuzzy icons at 1x
​https://bugs.webkit.org/show_bug.cgi?id=155557
<rdar://problem/25200217>

Reviewed by Timothy Hatcher.

New resource icons (documents and clippings) for large tree items,
for use in the Quick Open dialog's tree outline.

• UserInterface/Images/ClippingCSSLarge.png: Added.
• UserInterface/Images/​ClippingCSSLarge@2x.png: Added.
• UserInterface/Images/ClippingGenericLarge.png: Added.
• UserInterface/Images/ClippingGenericLarge@2x.png: Added.
• UserInterface/Images/ClippingJSLarge.png: Added.
• UserInterface/Images/​ClippingJSLarge@2x.png: Added.
• UserInterface/Images/DocumentCSSLarge.png: Added.
• UserInterface/Images/​DocumentCSSLarge@2x.png: Added.
• UserInterface/Images/DocumentFontLarge.png: Added.
• UserInterface/Images/DocumentFontLarge@2x.png: Added.
• UserInterface/Images/DocumentGenericLarge.png: Added.
• UserInterface/Images/DocumentGenericLarge@2x.png: Added.
• UserInterface/Images/DocumentImageLarge.png: Added.
• UserInterface/Images/DocumentImageLarge@2x.png: Added.
• UserInterface/Images/DocumentJSLarge.png: Added.
• UserInterface/Images/​DocumentJSLarge@2x.png: Added.
• UserInterface/Images/DocumentMarkupLarge.png: Added.
• UserInterface/Images/DocumentMarkupLarge@2x.png: Added.

32px icons at 1x and 2x.

• UserInterface/Views/ResourceIcons.css:

(.large .resource-icon .icon):
(.large .resource-icon.resource-type-document .icon):
(.large .resource-icon.resource-type-image .icon):
(.large .resource-icon.resource-type-font .icon):
(.large .resource-icon.resource-type-stylesheet .icon):
(.large .resource-icon.resource-type-script .icon):
(.large .anonymous-script-icon .icon):
(.large .source-map-resource.resource-icon .icon):
(.large .source-map-resource.resource-icon.resource-type-stylesheet .icon):
(.large .source-map-resource.resource-icon.resource-type-script .icon):
Large icon styles.

12:42 PM Changeset in webkit [198589] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Array.prototype native functions' species constructors should work with proxies
​https://bugs.webkit.org/show_bug.cgi?id=155798

Reviewed by Mark Lam.

Before native the species constructors were checking if the this value was a JSArray.
Instead they should look check that the this value returns true on Array.isArray.

• runtime/ArrayPrototype.cpp:

(JSC::speciesConstructArray):

• tests/es6.yaml:
• tests/stress/proxy-array-prototype-methods.js:

12:21 PM Changeset in webkit [198588] by Brent Fulgham

• 4 edits
  2 adds in trunk

[WebGL] Non-power-of-two texture optimization
​https://bugs.webkit.org/show_bug.cgi?id=118409

Reviewed by Dean Jackson.

Source/WebCore:

Based on a patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com>

This patch optimizes usage of handleNPOTTextures. We do not need to
iterate over each texture unit if no black textures were set. This
optimization provides a few more frames per seconds for certain
draw calls.

Tested by:
(1) Existing tests: webgl/resources/webgl_test_files/conformance/textures/texture-npot.html
(2) New test case: fast/canvas/webgl/texture-alternating-npot.html

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::compressedTexImage2D): Use new helper method.
(WebCore::WebGLRenderingContextBase::validateNPOTTextureLevel): Added.
(WebCore::WebGLRenderingContextBase::drawArrays): Only check texture completeness
if a black texture was used.
(WebCore::WebGLRenderingContextBase::drawElements): Ditto.
(WebCore::WebGLRenderingContextBase::texImage2DBase): Use new helper method.
(WebCore::WebGLRenderingContextBase::validateTexFunc): Ditto.
(WebCore::WebGLRenderingContextBase::checkTextureCompleteness): Return flag to indicate
if a black fallbacktexture was used.

• html/canvas/WebGLRenderingContextBase.h:

LayoutTests:

• fast/canvas/webgl/texture-alternating-npot-expected.txt: Added.
• fast/canvas/webgl/texture-alternating-npot.html: Added.

11:00 AM Changeset in webkit [198587] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Build fix for a new warning.

• editing/VisibleSelection.cpp: (WebCore::makeSearchRange): Don't move when returning,

as that prevents copy elision.

9:48 AM Changeset in webkit [198586] by Keith Rollin

• 2 edits in trunk/Tools

Unreviewed: add Keith Rollin to the committers list.

• Scripts/webkitpy/common/config/contributors.json:

8:53 AM Changeset in webkit [198585] by timothy@apple.com

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: String double quoting in the console and elsewhere needs to escape backslash too

​https://bugs.webkit.org/show_bug.cgi?id=155752
rdar://problem/25293141

Reviewed by Joseph Pecoraro.

• UserInterface/Base/Utilities.js:

(doubleQuotedString): Escape backslashes too.

• UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createLinkifiedElementString): Ditto.

8:39 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com

(diff)

8:36 AM WebKitNightlyElCapWorkaround edited by timothy@apple.com

Update to the latest workaround. (diff)

7:16 AM Changeset in webkit [198584] by Antti Koivisto

• 5 edits in trunk/Source/WebCore

Share style by sharing RenderStyle substructures not the object itself
​https://bugs.webkit.org/show_bug.cgi?id=155787

Reviewed by Anreas Kling.

The current approach where we share RenderStyle objects between elements leads to lot of awkward and bug-prone code.
Most of the RenderStyle consists of shareable substructures. It is better to just share those.

With this patch we create shared styles with RenderStyle::clone(). Sharing is traced as state in Style::SharingResolver
instead of relying on RenderStyle equality to locate potential sharing cousins.

• rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):

m_altText was missing from operator==
This was exposed by TreeResolver::resolveElement change, tested by fast/css/alt-inherit-initial.html

• style/StyleSharingResolver.cpp:

(WebCore::Style::elementHasDirectionAuto):
(WebCore::Style::SharingResolver::resolve):

Save share results to a map.

(WebCore::Style::SharingResolver::findSibling):
(WebCore::Style::SharingResolver::locateCousinList):

Instead of traversing we can now just do a hash lookup to locate a candidate cousin list.
There is no need for recursion anymore, the map covers sharing beyond immediate siblings too.
Remove most tests here as they have been already covered when sharing occured.

(WebCore::Style::canShareStyleWithControl):

• style/StyleSharingResolver.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::TreeResolver::resolveElement):

No need to do forced setting anymore just to support style sharing.

7:05 AM Changeset in webkit [198583] by Gyuyoung Kim

• 23 edits in trunk/Source/WebCore

Reduce PassRefPtr uses in editing
​https://bugs.webkit.org/show_bug.cgi?id=155743

Reviewed by Darin Adler.

Use RefPtr<>&&, raw pointer, or reference in arugments instead of PassRefPtr.
Besides RefPtr is used if function may be able to return nullptr.

• dom/Element.cpp:

(WebCore::Element::setOuterHTML):
(WebCore::Element::setInnerHTML):

• dom/Range.cpp:

(WebCore::Range::createContextualFragment):

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::wrapContentsInDummySpan):

• editing/CompositeEditCommand.h:
• editing/DictationCommand.cpp:

(WebCore::DictationCommand::insertText):

• editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

• editing/TextInsertionBaseCommand.cpp:

(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):

• editing/TextInsertionBaseCommand.h:
• editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::closeTyping):
(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):

• editing/TypingCommand.h:
• editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::firstRange):
(WebCore::makeSearchRange):

• editing/VisibleSelection.h:
• editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand):

• editing/WrapContentsInDummySpanCommand.h:

(WebCore::WrapContentsInDummySpanCommand::create):

• editing/atk/FrameSelectionAtk.cpp:

(WebCore::maybeEmitTextFocusChange):
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

• editing/htmlediting.cpp:

(WebCore::createOrderedListElement):
(WebCore::createUnorderedListElement):
(WebCore::createListItemElement):
(WebCore::createTabSpanElement):

• editing/htmlediting.h:
• editing/markup.cpp:

(WebCore::AttributeChange::AttributeChange):
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::styleFromMatchedRulesAndInlineDecl):
(WebCore::createFragmentForInnerOuterHTML):
(WebCore::createFragmentForTransformToFragment):
(WebCore::createContextualFragment):

• editing/markup.h:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentHTML):

• xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::transformToFragment):

2:15 AM Changeset in webkit [198582] by sbarati@apple.com

• 8 edits
  2 adds in trunk

We should not disable inlining when the debugger is enabled
​https://bugs.webkit.org/show_bug.cgi?id=155741

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

We can enable inlining when the debugger is enabled as long
as we make sure we still jettison the proper CodeBlocks when
a breakpoint is set. This means that for any optimized CodeBlock,
we must ask if any of its inlinees contain the breakpoint that
is being set. If any inlinees do contain the breakpoint, we must
jettison the machine code block that they are a part of.

• debugger/Debugger.cpp:

(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::applyBreakpoints):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushForTerminal):
(JSC::DFG::ByteCodeParser::inliningCost):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::hasDebuggerEnabled): Deleted.

• dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

• ftl/FTLCompile.cpp:

(JSC::FTL::compile):

LayoutTests:

• inspector/debugger/breakpoint-with-inlining-expected.txt: Added.
• inspector/debugger/breakpoint-with-inlining.html: Added.

2:11 AM Changeset in webkit [198581] by Yusuke Suzuki

• 2 edits
  1 add in trunk/Source/JavaScriptCore

[ES6] Allow undefined/null for Symbol.search and Symbol.match
​https://bugs.webkit.org/show_bug.cgi?id=155785

Reviewed by Saam Barati.

Undefined and null for Symbol.search and Symbol.match properties of the given RegExp (like) object are allowed.
When they are specified, we go to the fallback path; creating the RegExp with the given object and matching.

• builtins/StringPrototype.js:

(match):
(search):

• tests/stress/string-symbol-customization.js: Added.

(shouldBe):
(shouldThrow):

1:51 AM Changeset in webkit [198580] by Carlos Garcia Campos

• 16 edits in trunk/Source

Use Region instead of IntRect in PageClient and WebPageProxy setViewNeedsDisplay method
​https://bugs.webkit.org/show_bug.cgi?id=155747

Reviewed by Darin Adler.

Source/WebCore:

Add helper function to make cairo region out of a WebCore::Region.

• platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::toCairoRegion):

• platform/graphics/cairo/CairoUtilities.h:

Source/WebKit2:

This way instead of calling setViewNeedsDisplay() for every
rectangle in the damage area, we can build a region and call
setViewNeedsDisplay() once. GTK+ has API to queue a redraw for a
given region, so we also avoid scheduling multiple redraws in GTK+
port.

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setViewNeedsDisplay): Convert the Region
into a cairo_region_t and use gtk_widget_queue_draw_region()
instyead of gtk_widget_queue_draw_area().

• UIProcess/API/gtk/PageClientImpl.h:
• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Build a Region
with the damage rectangles and call
WebPageProxy::setViewNeedsDisplay() once.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setViewNeedsDisplay):

• UIProcess/WebPageProxy.h:
• UIProcess/efl/WebView.cpp:

(WebKit::WebView::setViewNeedsDisplay):

• UIProcess/efl/WebView.h:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setViewNeedsDisplay):

• UIProcess/mac/PageClientImpl.h:
• UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewNeedsDisplay):

1:21 AM Changeset in webkit [198579] by sbarati@apple.com

• 2 edits in trunk/Source/WTF

SmallPtrSet leaks memory in its move assignment operator when !this->isSmall()
​https://bugs.webkit.org/show_bug.cgi?id=155701

Reviewed by Darin Adler.

• wtf/SmallPtrSet.h:

(WTF::SmallPtrSet::SmallPtrSet):
(WTF::SmallPtrSet::operator=):