Context Navigation

← Previous Period
Next Period →

Timeline

May 14, 2016:

4:52 PM Changeset in webkit [200925] by Chris Dumez

4 edits in trunk/Source/WebCore

Use new Web IDL dictionary support for MediaSession.setMetadata()
https://bugs.webkit.org/show_bug.cgi?id=157711

Reviewed by Eric Carlson.

Use new Web IDL dictionary support for MediaSession.setMetadata().

No new tests, no intended Web-exposed behavior change.

Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::setMetadata):
(WebCore::MediaSession::deactivate): Deleted.

Modules/mediasession/MediaSession.h:
Modules/mediasession/MediaSession.idl:

3:17 PM Changeset in webkit [200924] by commit-queue@webkit.org

95 edits
21 deletes in trunk

Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-14
Reviewed by Mark Lam.

ManualTests/inspector/profiler-test-call.html: Removed.
ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.

Source/JavaScriptCore:

JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.

API/JSProfilerPrivate.cpp: Removed.
API/JSProfilerPrivate.h: Removed.
CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.json:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode): Deleted.

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):

bytecode/UnlinkedFunctionExecutable.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):

bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::profileHookRegister): Deleted.
(JSC::BytecodeGenerator::shouldEmitProfileHooks): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::CallArguments::CallArguments): Deleted.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Deleted.

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel): Deleted.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Deleted.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): Deleted.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Deleted.

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute): Deleted.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):

inspector/protocol/Timeline.json:
interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()): Deleted.
(JSC::Interpreter::execute): Deleted.
(JSC::Interpreter::executeCall): Deleted.
(JSC::Interpreter::executeConstruct): Deleted.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass): Deleted.

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

jit/JITOperations.cpp:
jit/JITOperations.h:
jsc.cpp:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
parser/ParserModes.h:
profiler/CallIdentifier.h: Removed.
profiler/LegacyProfiler.cpp: Removed.
profiler/LegacyProfiler.h: Removed.
profiler/Profile.cpp: Removed.
profiler/Profile.h: Removed.
profiler/ProfileGenerator.cpp: Removed.
profiler/ProfileGenerator.h: Removed.
profiler/ProfileNode.cpp: Removed.
profiler/ProfileNode.h: Removed.
profiler/ProfilerJettisonReason.cpp:

(WTF::printInternal): Deleted.

profiler/ProfilerJettisonReason.h:
runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):

runtime/CodeCache.h:
runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::~JSGlobalObject): Deleted.
(JSC::JSGlobalObject::hasLegacyProfiler): Deleted.

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.

runtime/Options.h:
runtime/VM.cpp:

(JSC::VM::VM): Deleted.
(JSC::SetEnabledProfilerFunctor::operator()): Deleted.
(JSC::VM::setEnabledProfiler): Deleted.

runtime/VM.h:

(JSC::VM::enabledProfiler): Deleted.
(JSC::VM::enabledProfilerAddress): Deleted.

Source/WebCore:

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
ForwardingHeaders/profiler/Profile.h: Removed.
ForwardingHeaders/profiler/ProfileNode.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.

bindings/js/JSDOMWindowBase.h:
bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.

bindings/js/JSWorkerGlobalScopeBase.h:
bindings/js/ScriptCachedFrameData.cpp:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell): Deleted.

bindings/js/ScriptProfile.h: Removed.
bindings/js/ScriptProfileNode.h: Removed.
bindings/scripts/CodeGeneratorJS.pm:

(AddClassForwardIfNeeded): Deleted.

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/TestObj.idl:
css/CSSParser.cpp:
dom/Document.cpp:
inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::stopProfiling):

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.

inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::stopProfilingImpl):

inspector/InspectorInstrumentation.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

inspector/InspectorTimelineAgent.h:
inspector/PageDebuggerAgent.cpp:
inspector/PageRuntimeAgent.cpp:
inspector/ScriptProfile.idl: Removed.
inspector/ScriptProfileNode.idl: Removed.
inspector/TimelineRecordFactory.cpp:

(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.

page/DOMWindow.cpp:
page/Page.cpp:
page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.

page/PageConsoleClient.h:
testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.

testing/Internals.h:
testing/Internals.idl:
testing/js/WebCoreTestSupport.cpp:
xml/XSLStyleSheetLibxslt.cpp:
xml/XSLTProcessorLibxslt.cpp:

Source/WebKit/win:

Interfaces/IWebInspector.idl:
WebView.cpp:
WebInspector.cpp:

(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.

WebInspector.h:

LayoutTests:

fast/profiler/anonymous-event-handler-expected.txt: Removed.
fast/profiler/anonymous-event-handler.html: Removed.
fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
fast/profiler/anonymous-function-calls-eval.html: Removed.
fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
fast/profiler/anonymous-functions-with-display-names.html: Removed.
fast/profiler/apply-expected.txt: Removed.
fast/profiler/apply.html: Removed.
fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
fast/profiler/built-in-function-calls-anonymous.html: Removed.
fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
fast/profiler/call-expected.txt: Removed.
fast/profiler/call-register-leak-expected.txt: Removed.
fast/profiler/call-register-leak.html: Removed.
fast/profiler/call.html: Removed.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
fast/profiler/compare-multiple-profiles-expected.txt: Removed.
fast/profiler/compare-multiple-profiles.html: Removed.
fast/profiler/constructor-expected.txt: Removed.
fast/profiler/constructor.html: Removed.
fast/profiler/dead-time-expected.txt: Removed.
fast/profiler/dead-time.html: Removed.
fast/profiler/document-dot-write-expected.txt: Removed.
fast/profiler/document-dot-write.html: Removed.
fast/profiler/event-handler-expected.txt: Removed.
fast/profiler/event-handler.html: Removed.
fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
fast/profiler/inline-event-handler-expected.txt: Removed.
fast/profiler/inline-event-handler.html: Removed.
fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
fast/profiler/many-calls-in-the-same-scope.html: Removed.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
fast/profiler/multiple-frames-expected.txt: Removed.
fast/profiler/multiple-frames.html: Removed.
fast/profiler/named-functions-with-display-names-expected.txt: Removed.
fast/profiler/named-functions-with-display-names.html: Removed.
fast/profiler/nested-anonymous-functon-expected.txt: Removed.
fast/profiler/nested-anonymous-functon.html: Removed.
fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
fast/profiler/nested-start-and-stop-profiler.html: Removed.
fast/profiler/no-execution-context-expected.txt: Removed.
fast/profiler/no-execution-context.html: Removed.
fast/profiler/one-execution-context-expected.txt: Removed.
fast/profiler/one-execution-context.html: Removed.
fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
fast/profiler/profile-calls-in-included-file.html: Removed.
fast/profiler/profile-with-no-title-expected.txt: Removed.
fast/profiler/profile-with-no-title.html: Removed.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
fast/profiler/profiling-from-a-nested-location.html: Removed.
fast/profiler/resources/other-frame.html: Removed.
fast/profiler/resources/other-window.html: Removed.
fast/profiler/resources/profiler-test-JS-resources.js: Removed.
fast/profiler/simple-event-call-expected.txt: Removed.
fast/profiler/simple-event-call.html: Removed.
fast/profiler/simple-no-level-change-expected.txt: Removed.
fast/profiler/simple-no-level-change.html: Removed.
fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
fast/profiler/start-but-dont-stop-profiling.html: Removed.
fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
fast/profiler/stop-profiling-after-setTimeout.html: Removed.
fast/profiler/stop-then-function-call-expected.txt: Removed.
fast/profiler/stop-then-function-call.html: Removed.
fast/profiler/throw-exception-from-eval-expected.txt: Removed.
fast/profiler/throw-exception-from-eval.html-disabled: Removed.
fast/profiler/two-execution-contexts-expected.txt: Removed.
fast/profiler/two-execution-contexts.html: Removed.
fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
fast/profiler/window-dot-eval-expected.txt: Removed.
fast/profiler/window-dot-eval.html: Removed.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:

2:07 PM Changeset in webkit [200923] by rniwa@webkit.org

5 edits
2 adds in trunk

ToT WebKit doesn't show tooltip on perf dashboard's summary page
https://bugs.webkit.org/show_bug.cgi?id=157705

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by WebKit doesn't look for the title attribute across shadow boundaries.
Fixed it by using a newly added Node::parentNodeInComposedTree in HitTestResult::title.

Test: fast/shadow-dom/tooltip-on-composed-tree.html

dom/Node.cpp:

(WebCore::Node::parentInComposedTree): Added.

dom/Node.h:
rendering/HitTestResult.cpp:

(WebCore::HitTestResult::title): Fixed the bug.
(WebCore::HitTestResult::innerTextIfTruncated): Fixed a related bug when ShowsToolTipOverTruncatedText
is enabled. Unfortunately, there is no machinery to test this feature yet.

LayoutTests:

Added a regression test for finding a tooltip across shadow boundaries.

fast/shadow-dom/tooltip-on-composed-tree-expected.txt: Added.
fast/shadow-dom/tooltip-on-composed-tree.html: Added.

1:09 PM Changeset in webkit [200922] by Darin Adler

34 edits in trunk/Source

CTTE for the HTML editing header
https://bugs.webkit.org/show_bug.cgi?id=157676

Reviewed by Chris Dumez.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::AccessibilityReplacedText::postTextStateChangeNotification): Use auto so we have a
change to compile more efficient code using the more specific types returned, rather than
explicitly using a less specific type like Node.
(WebCore::AXObjectCache::startCharacterOffsetOfParagraph): Ditto.

accessibility/atk/WebKitAccessibleInterfaceText.cpp: Update for deprecatedIsEditingWhitespace name.
dom/Position.cpp:

(WebCore::Position::offsetForPositionAfterAnchor): Update to use a reference instead of a pointer.
(WebCore::Position::next): Ditto.
(WebCore::Position::atFirstEditingPositionForNode): Ditto.
(WebCore::Position::atLastEditingPositionForNode): Ditto.
(WebCore::Position::atStartOfTree): Ditto.
(WebCore::Position::atEndOfTree): Ditto.
(WebCore::Position::upstream): Ditto.
(WebCore::Position::downstream): Ditto.
(WebCore::Position::rendersInDifferentPosition): Ditto.

dom/PositionIterator.cpp:

(WebCore::PositionIterator::increment): Ditto.
(WebCore::PositionIterator::decrement): Ditto.
(WebCore::PositionIterator::atEnd): Ditto.
(WebCore::PositionIterator::atEndOfNode): Ditto.

editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
Use new name, deprecatedIsEditingWhitespace.

editing/ApplyBlockElementCommand.cpp:

(WebCore::ApplyBlockElementCommand::formatSelection): Use auto (see rationale above).

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): More of the same.
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Ditto.
(WebCore::ApplyStyleCommand::fixRangeAndApplyInlineStyle): Ditto.
(WebCore::ApplyStyleCommand::isValidCaretPositionInTextNode): Ditto.
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): Ditto.

editing/BreakBlockquoteCommand.cpp:

(WebCore::BreakBlockquoteCommand::doApply): Ditto.

editing/CompositeEditCommand.cpp:

(WebCore::postTextStateChangeNotification): Ditto.
(WebCore::CompositeEditCommand::insertNodeAt): Ditto.
(WebCore::CompositeEditCommand::positionOutsideTabSpan): Ditto.
(WebCore::containsOnlyDeprecatedEditingWhitespace): Ditto.
(WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor): Ditto.
(WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto.
(WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Ditto.
(WebCore::CompositeEditCommand::insertNewDefaultParagraphElementAt): Ditto.
(WebCore::CompositeEditCommand::moveParagraphWithClones): Ditto.
(WebCore::CompositeEditCommand::moveParagraphs): Ditto.

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto.
(WebCore::DeleteSelectionCommand::handleGeneralDelete): Ditto.
(WebCore::DeleteSelectionCommand::mergeParagraphs): Ditto.
(WebCore::DeleteSelectionCommand::doApply): Ditto.

editing/EditCommand.cpp:

(WebCore::EditCommand::postTextStateChangeNotification): Ditto.

editing/EditingStyle.cpp: Ditto.
editing/Editor.cpp:

(WebCore::Editor::advanceToNextMisspelling): Ditto.

editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::formatRange): Ditto.

editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph): Ditto.

editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply): Ditto.

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::fixOrphanedListChild): Ditto.
(WebCore::InsertListCommand::doApplyForSingleParagraph): Ditto.
(WebCore::InsertListCommand::unlistifyParagraph): Ditto.
(WebCore::InsertListCommand::listifyParagraph): Ditto.

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab): Ditto.

editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply): Ditto.

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::removeUnrenderedNodes): Ditto.
(WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline): Ditto.
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Ditto.
(WebCore::enclosingInline): Ditto.
(WebCore::ReplaceSelectionCommand::doApply): Ditto.

editing/TextIterator.cpp:

(WebCore::maxOffsetIncludingCollapsedSpaces): Ditto.

editing/TypingCommand.cpp:

(WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.

editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore): Ditto.
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter): Ditto.

editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity): Ditto.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Ditto.

editing/VisibleUnits.cpp:

(WebCore::previousRootInlineBoxCandidatePosition): Ditto.
(WebCore::nextRootInlineBoxCandidatePosition): Ditto.
(WebCore::startOfParagraph): Ditto.
(WebCore::endOfParagraph): Ditto.
(WebCore::startOfEditableContent): Ditto.
(WebCore::endOfEditableContent): Ditto.

editing/htmlediting.cpp:

(WebCore::highestEditableRoot): Changed return type to ContainerNode. Maybe later could
change it to Element.
(WebCore::lowestEditableAncestor): Changed return type to Element.
(WebCore::isEditableToAccessibility): Use auto.
(WebCore::isRichlyEditablePosition): Ditto.
(WebCore::editableRootForPosition): Ditto.
(WebCore::unsplittableElementForPosition):Ditto.
(WebCore::nextCandidate): Streamline.
(WebCore::nextVisuallyDistinctCandidate): Ditto.
(WebCore::previousCandidate): Ditto.
(WebCore::previousVisuallyDistinctCandidate): Ditto.
(WebCore::firstEditablePositionAfterPositionInRoot): Changed arugment type to
ContainerNode.
(WebCore::lastEditablePositionBeforePositionInRoot): Ditto.
(WebCore::lastOffsetForEditing): Changed argument type to reference.
(WebCore::stringWithRebalancedWhitespace): Optimized the case where the function does
not need to change the string, so it just returns the passed string rather than a copy.
(WebCore::isTableStructureNode): Use auto.
(WebCore::isSpecialElement): Made this function private to the file. Use auto.
(WebCore::firstInSpecialElement): Return an HTMLElement.
(WebCore::lastInSpecialElement): Ditto.
(WebCore::isFirstVisiblePositionInSpecialElement): Made this function private to the file.
(WebCore::positionBeforeContainingSpecialElement): Changed out argument to HTMLElement.
(WebCore::isLastVisiblePositionInSpecialElement): Ditto.
(WebCore::positionAfterContainingSpecialElement): Ditto.
(WebCore::positionOutsideContainingSpecialElement): Ditto.
(WebCore::isFirstPositionAfterTable): Changed return type to Element.
(WebCore::isLastPositionBeforeTable): Ditto.
(WebCore::visiblePositionBeforeNode): Changed argument type to reference.
(WebCore::visiblePositionAfterNode): Ditto.
(WebCore::enclosingElementWithTag): Use auto. Removed special case for null since the
algorithm already handles null correctly.
(WebCore::enclosingNodeOfType): Use auto.
(WebCore::highestEnclosingNodeOfType): Ditto.
(WebCore::highestNodeToRemoveInPruning): Ditto.
(WebCore::enclosingTableCell): Changed return type to Element.
(WebCore::enclosingAnchorElement): Removed special case for null since the algorithm
already handles null correctly.
(WebCore::enclosingList): Use auto.
(WebCore::enclosingListChild): Use auto.
(WebCore::enclosingEmptyListItem): Use auto.
(WebCore::outermostEnclosingList): Use auto.
(WebCore::canMergeLists): Use references and more specific type. Since both elements are
known to be HTMLElement, compare local names instead of using hasTagName.
(WebCore::isRenderedTable): Use auto.
(WebCore::isTableCell): Ditto.
(WebCore::isEmptyTableCell): Ditto.
(WebCore::createBreakElement): Deleted. Callers can use HTMLBRElement directly.
(WebCore::createOrderedListElement): Deleted. Callers can use HTMLOListElement directly.
(WebCore::createUnorderedListElement): Deleted. Callers can use HTMLUListElement directly.
(WebCore::createListItemElement): Deleted. Callers can use HTMLLIElement directly.
(WebCore::isTabSpanNode): Remove redundant checks and did more specific typecast.
(WebCore::isTabSpanTextNode): Removed redundant null checks.
(WebCore::tabSpanNode): Changed return type to HTMLSpanElement.
(WebCore::positionOutsideTabSpan): Deleted. Unused function.
(WebCore::createTabSpanElement): Made one of the overloads private to this file. Use auto.
Changed argument type since we don't need to support null. Moved createEditingTextNode code,
specific to the version without a string into that function rather than the helper function.
(WebCore::isNodeRendered): Changed argument type to a reference.
(WebCore::numEnclosingMailBlockquotes): Streamlined.
(WebCore::isMailBlockquote): Use downcast instead of static_cast.
(WebCore::caretMinOffset): Take a reference instead of a pointer.
(WebCore::caretMaxOffset): Ditto.
(WebCore::selectionForParagraphIteration): Use auto.
(WebCore::indexForVisiblePosition): Ditto.
(WebCore::visiblePositionForIndex): Ditto.
(WebCore::visiblePositionForIndexUsingCharacterIterator): Ditto.
(WebCore::isVisiblyAdjacent): Made this private to this file.
(WebCore::isNodeVisiblyContainedWithin): Changed argument type to a reference.
(WebCore::areIdenticalElements): Changed argument types to references.
(WebCore::adjustedSelectionStartForStyleComputation): Use auto.
(WebCore::isBlockFlowElement): Changed argument type to a reference. Use auto.
(WebCore::deprecatedEnclosingBlockFlowElement): Updated for reference changes.
(WebCore::rendererForCaretPainting): Use auto.

editing/htmlediting.h: Use pragma once. Removed unneeded includes and forward declarations.

Removed various non-helpful comments (the sections still don't make sense; not really good to
group functions by their return types). Moved inline functoin bodies to the bottom of the file.
Renamed isWhitespace to deprecatedIsEditingWhitespace.

editing/markup.cpp:

(WebCore::createFragmentFromText): Use HTMLBRElement.

page/DOMSelection.cpp:

(WebCore::DOMSelection::extend): Updated since caretMaxOffset takes a reference.

Source/WebKit/ios:

WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame previousUnperturbedDictationResultBoundaryFromPosition:]): Update since
lastOffsetForEditing takes a reference now. Seems like this code should be in WebCore.
(-[WebFrame nextUnperturbedDictationResultBoundaryFromPosition:]): Ditto.

12:18 PM Changeset in webkit [200921] by mmaxfield@apple.com

9 edits
2 adds in trunk

Support ArrayBufferViews in the CSS Font Loading API
https://bugs.webkit.org/show_bug.cgi?id=157694
<rdar://problem/25554267>

Source/WebCore:

This patch adds a new mode to CSSFontFaceSource for immediate (ArrayBuffer) data.
Then, FontFace can simply be hooked up to this new mode.

Reviewed by Darin Adler.

Test: fast/text/css-font-loading-arraybuffer.html

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):
(WebCore::CSSFontFaceSource::font):

css/CSSFontFaceSource.h:
css/FontFace.cpp:

(WebCore::FontFace::create):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createCustomFontData):
(WebCore::CachedFont::createFont):
(WebCore::CachedFont::platformDataFromCustomData):

loader/cache/CachedFont.h:

LayoutTests:

Reviewed by Darin Adler.

fast/text/css-font-loading-arraybuffer-expected.txt: Added.
fast/text/css-font-loading-arraybuffer.html: Added.

10:56 AM Changeset in webkit [200920] by Chris Dumez

6 edits in trunk/Source/WebCore

[WebIDL] Add support for dictionary members of integer types
https://bugs.webkit.org/show_bug.cgi?id=157703

Reviewed by Darin Adler.

Add support for dictionary members of integer types, including support
for the [Clamp] and [EnforceRange] IDL extended attributes on such
members.

bindings/js/JSDOMConvert.h:

(WebCore::convert):
(WebCore::convertOptional):

Add the needed template specializations so we can use convertOptional() with integral types.
Use std::enable_if so the template specializations meants to be used for floating point types or integral types can only be instantiated for such types.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConversionRuleWithLeadingComma):
(GetIntegerConversionConfiguration):
(JSValueToNative):
Generate the right IntegerConversionConfiguration parameter for convert()
and convertOptional() when converting dictionary members of integral
types

bindings/scripts/IDLParser.pm:

(parseDictionaryMember):
Fix bug in the IDL parser where we weren't initializing the extended
attributes for dictionary members.

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/TestObj.idl:

Add bindings tests coverage.

9:54 AM Changeset in webkit [200919] by Chris Dumez

3 edits in trunk/Source/WebCore

Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the stack
https://bugs.webkit.org/show_bug.cgi?id=157690

Reviewed by Myles C. Maxfield.

Allocate MacGlyphToPathTranslator / CairoGlyphToPathTranslator on the
stack. We also now use the subclass type for the local variable so it
will bypass the vtable for various virtual function calls (if the compiler
was not already smart enough to figure this out).

platform/graphics/cairo/FontCairo.cpp:

(WebCore::FontCascade::dashesForIntersectionsWithRect):

platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::dashesForIntersectionsWithRect):

7:59 AM Changeset in webkit [200918] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Empty line shows arrow when hovering over Animation Frame Requested in timeline recording
https://bugs.webkit.org/show_bug.cgi?id=157707

Reviewed by Timothy Hatcher.

UserInterface/Views/DataGrid.css:

(.data-grid:not(.variable-height-rows) > .data-container > table.data > tbody > tr > td > div):

May 13, 2016:

11:31 PM Changeset in webkit [200917] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the iOS build after the protector variables renaming.

platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willSendRequest):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveChallenge):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):

10:51 PM Changeset in webkit [200916] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

jsc: samplingProfilerStackTraces() without starting sampling should not cause jsc to crash
https://bugs.webkit.org/show_bug.cgi?id=157704

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-13
Reviewed by Saam Barati.

jsc.cpp:

(functionStartSamplingProfiler):
(functionSamplingProfilerStackTraces):
Throw an exception instead of crashing if we haven't started sampling.

inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::startTracking):

runtime/VM.h:
runtime/VM.cpp:

(JSC::VM::ensureSamplingProfiler):
Switch ensure to returning a reference, like most other ensures.

10:14 PM Changeset in webkit [200915] by Alan Bujtas

17 edits in trunk

All scrolling height/width values should be integral rounded.
https://bugs.webkit.org/show_bug.cgi?id=157687

Reviewed by Simon Fraser.

Both clientHeight(Width) and scrollHeight(width) need to be explicitly integral
rounded in order to ensure that scrollable content is computed properly.
This will evolve into subpixel snapping once we apply subpixel arithmetics on scrolling.

Source/WebCore:

Not testable.

rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::horizontalScrollbarStart):
(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
(WebCore::RenderLayer::computeScrollDimensions):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):

rendering/RenderLayer.h:

LayoutTests:

platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:

9:58 PM Changeset in webkit [200914] by Dewei Zhu

3 edits in trunk/Tools

Fix JSBench which causes math domain error in run-benchmark script.
https://bugs.webkit.org/show_bug.cgi?id=157697
<rdar://problem/26279292>

Reviewed by Ryosuke Niwa.

Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
Also fix a round-off error while calculating stdev.

Scripts/webkitpy/benchmark_runner/benchmark_results.py:

(BenchmarkResults._format_values):

Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:

9:45 PM Changeset in webkit [200913] by beidson@apple.com

5 edits in trunk

Extend protector naming code style guideline to cover operator= assignment.
https://bugs.webkit.org/show_bug.cgi?id=157693

Reviewed by Darin Adler.

Tools:

Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

Websites/webkit.org:

code-style.md:

7:40 PM Changeset in webkit [200912] by dino@apple.com

2 edits in trunk/Source/WebKit2

Fix iOS Build.

Shared/AssistedNodeInformation.h:

(WebKit::OptionItem::OptionItem):

7:29 PM Changeset in webkit [200911] by weinig@apple.com

2 edits in trunk/Source/WebKit2

REGRESSION (r200463): Autofill Credit Card expected but got Autofill Contact
<rdar://problem/26251538>
https://bugs.webkit.org/show_bug.cgi?id=157701

Reviewed by Dan Bernstein.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(-[WKWebProcessPlugInFrame _certificateChain]):
We need to do a retain-autorelease here now because the CertificateInfo's that contain the
cached certificate chain, are being destroyed, and therefore destroying the chain, before this
function returns. This used to work when the chain wasn't just a cache, because there was still
a strong reference to it being held by the ResourceResponse's CertificateInfo copy, but now
there is none.

7:27 PM Changeset in webkit [200910] by dino@apple.com

3 edits in trunk/Source/WebKit2

[iOS] <select> elements popover should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157699
<rdar://problem/26282319>

Reviewed by Simon Fraser.

Some follow-up changes as suggested by Darin in review.

Shared/AssistedNodeInformation.h: Use initializers so we can

remove the constructors.
(WebKit::OptionItem::OptionItem): Deleted.
(WebKit::AssistedNodeInformation::AssistedNodeInformation): Deleted.

UIProcess/ios/forms/WKFormSelectPopover.mm: Add a comment to explain

why we are explicitly setting the language.
(-[WKSelectTableViewController initWithView:hasGroups:]):

7:26 PM Changeset in webkit [200909] by Chris Dumez

8 edits in trunk/Source

[NetworkCache] Avoid having to re-parse URLs after deserializing them
https://bugs.webkit.org/show_bug.cgi?id=157660

Reviewed by Darin Adler.

Source/WebCore:

Avoid having to re-parse URLs after deserializing them in the WebKit2
network cache storage implementation.

We previously serialized URLs as Strings, which meant that we had the
re-parse them upon deserialization. We now serialize all of the URL
data members to avoid having to parse the String again.

platform/URL.h:

(WebCore::URL::encode):
(WebCore::URL::decode):

platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::encodeWithoutPlatformData):
(WebCore::ResourceRequestBase::decodeWithoutPlatformData):

platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):

Source/WebKit2:

NetworkProcess/cache/NetworkCacheCoders.cpp:

(WebKit::NetworkCache::Coder<WebCore::CertificateInfo>::encode): Deleted.
(WebKit::NetworkCache::Coder<WebCore::CertificateInfo>::decode): Deleted.

NetworkProcess/cache/NetworkCacheCoders.h:

Drop template specializations used by our network cache for encoding
/ decoding URLs as Strings. This causes us to now rely on
URL::encode() / URL::decode() instead.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<BlobPart>::decode):
Fix bug in BlobPart encoding / decoding. It was encoding the url member
as a URL but decoding it as a String.

7:17 PM Changeset in webkit [200908] by weinig@apple.com

8 edits
2 adds in trunk

ScriptController::processingUserGesture should propagate across postMessage boundaries
<rdar://problem/26273173>
https://bugs.webkit.org/show_bug.cgi?id=157686

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dom/Window/post-message-user-action.html

dom/UserGestureIndicator.h:

Export processingUserGesture() for testing.

page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::event):
Maintain the processingUserGesture bit through postMessage.

testing/Internals.cpp:

(WebCore::Internals::setResourceTimingSupport):
(WebCore::Internals::isProcessingUserGesture):

testing/Internals.h:
testing/Internals.idl:

Add new internals function to get the current state of the UseGestureIndicator for testing.

LayoutTests:

fast/dom/Window/post-message-user-action-expected.txt: Added.
fast/dom/Window/post-message-user-action.html: Added.

7:10 PM Changeset in webkit [200907] by Chris Dumez

13 edits in trunk

Align window.scroll() / scrollTo() / scrollBy() with the CSSOM specification
https://bugs.webkit.org/show_bug.cgi?id=157666

Reviewed by Darin Adler.

Source/WebCore:

Align window.scroll() / scrollTo() / scrollBy() with Firefox and the CSSOM
specification:
https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface

In particular, the following changes were made:

Make parameters to scroll() / scrollTo() / scrollBy() mandatory.
Add overloads for scroll() / scrollTo() / scrollBy() that take an optional ScrollToOptions dictionary.
Update API to use "unrestricted double" typing for x/y instead of "long". This matches the specification but it does not really change our behavior at this point because the values are still casted to int in our implementation.

Web-Exposed behavior changes:

JS can now pass a dictionary to scroll() / scrollTo() / scrollBy(). This a new feature that Firefox already supports (Chrome does not).
Passing only 1 parameter to scroll() / scrollTo() / scrollBy() that is not a dictionary will now throw a TypeError. The compatibility risky should be low because Firefox and Chrome already throw in this case (Chrome has been throwing for 2 years and a half).
Calling scrollTo() / scroll() without any parameter no longer scrolls to 0. Instead we use the current viewport's x/y which means we don't scroll at all. The new behavior matches Firefox, Chrome and IE 11. This fixes scrolling on the following Website: https://members.chosun.com/cms_subscribe/application/index.jsp

No new tests, extended existing testing.

bindings/js/JSDOMConvert.h:

(WebCore::convert):
(WebCore::convertOptional):

bindings/scripts/CodeGeneratorJS.pm:

(ShouldAllowNonFiniteForFloatingPointType):
(GenerateConversionRuleWithLeadingComma):
(GenerateDictionaryImplementationContent):
(JSValueToNative):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convert<TestObj::Dictionary>):

bindings/scripts/test/TestObj.idl:
page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollBy):
(WebCore::DOMWindow::scrollTo):

page/DOMWindow.h:
page/DOMWindow.idl:

LayoutTests:

Update / improve testing coverage for the API.

fast/dom/Window/window-scroll-arguments-expected.txt:
fast/dom/Window/window-scroll-arguments.html:
fast/dom/non-numeric-values-numeric-parameters-expected.txt:
fast/dom/script-tests/non-numeric-values-numeric-parameters.js:

7:03 PM Changeset in webkit [200906] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG/FTL have a few bugs in their reasoning about the scope
https://bugs.webkit.org/show_bug.cgi?id=157696

Reviewed by Benjamin Poulain.

When the debugger is enabled, it is easier for the DFG to reason

about the scope register by simply claiming all nodes read the scope
register. This prevents us from ever entering the runtime where we
may take a stack trace but there isn't a scope on the stack.

This patch fixes a bug where the FTL compilation wasn't properly

setting the CodeBlock register. It was only doing this when there
was inline data, but when the debugger is enabled, we never inline.
So this code just needed to be removed from that loop. It was never
right for it to be inside the loop.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

5:20 PM Changeset in webkit [200905] by matthew_hanson@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

5:19 PM Changeset in webkit [200904] by matthew_hanson@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:17 PM Changeset in webkit [200903] by matthew_hanson@apple.com

5 edits in branches/safari-602.1.32-branch/Source

Versioning.

5:12 PM Changeset in webkit [200902] by matthew_hanson@apple.com

5 edits in tags/Safari-602.1.32.2.1/Source

Versioning.

5:03 PM Changeset in webkit [200901] by Ryan Haddad

5 edits in trunk/Source

Unreviewed, rolling out r200894.
https://bugs.webkit.org/show_bug.cgi?id=157695

This change broke the iOS build (Requested by ryanhaddad on
#webkit).

Reverted changeset:

"Remove unused initializer for WebEvent on iOS."
https://bugs.webkit.org/show_bug.cgi?id=157689
http://trac.webkit.org/changeset/200894

Patch by Commit Queue <commit-queue@webkit.org> on 2016-05-13

5:01 PM Changeset in webkit [200900] by rniwa@webkit.org

3 edits
1 add in trunk/Websites/perf.webkit.org

v3 UI shows full git hash instead of the first 8 characters for a blame range
https://bugs.webkit.org/show_bug.cgi?id=157691

Reviewed by Stephanie Lewis.

Fixed the bug that v3 UI shows the full 40 character git hash instead of the first 8 character as done in v2 UI.

public/v3/models/commit-log.js:

(CommitLog.prototype.diff): Fixed the bug.

tools/run-tests.py:

(main): Add the support for running a subset of tests as mocha does.

unit-tests/commit-log-tests.js: Added.

4:53 PM Changeset in webkit [200899] by matthew_hanson@apple.com

2 edits in tags/Safari-602.1.32.2.1/Source/JavaScriptCore

Merge r200666.

4:45 PM Changeset in webkit [200898] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] SetLocal without exit do not need phantoms
https://bugs.webkit.org/show_bug.cgi?id=157653

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Filip Pizlo.

I made a mistake in r200498.

If a SetLocal cannot possibly exit, we were not clearing
the source of the operand. As a result, we sometime kept
a value alive up to the end of the block.

That's uncommon because SetLocal typically appear
toward the end of blocks. That's probably why there was
no perf impact with that fix.

dfg/DFGPhantomInsertionPhase.cpp:

4:45 PM Changeset in webkit [200897] by benjamin@webkit.org

4 edits in trunk/Source/JavaScriptCore

[JSC] Move the CheckTierUp function calls out of the main path
https://bugs.webkit.org/show_bug.cgi?id=157668

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Mark Lam.

If you have a tiny tiny loop (for example, Sunspider's bits-in-byte),
the size of CheckTierUp is a problem.

On multi-issue CPUs, the node is so big that we do not
get to run anything from the loop in the instruction fetch.

On x86, having a bigger loop also pushes us out of the LSD.

This is a 6% improvement on bits-in-byte. Other Sunspider tests
only improves marginally.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSpill):
(JSC::DFG::SpeculativeJIT::silentFill):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

4:44 PM Changeset in webkit [200896] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
https://bugs.webkit.org/show_bug.cgi?id=157671

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-13
Reviewed by Mark Lam.

This improves the chances of having a value
when issuing the TEST.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitLoadWithStructureCheck):

4:42 PM Changeset in webkit [200895] by beidson@apple.com

92 edits in trunk/Source/WebCore

Rename all protector variables that should be called protectedThis
https://bugs.webkit.org/show_bug.cgi?id=157610

Reviewed by Alex Christensen.

No new tests (Renaming, no behavior change).

WebCore has so many instances of these protectors as well as so much variance in naming them,
that I think it deserved a new style pass.

Modules/fetch/FetchResponse.cpp:
Modules/geolocation/GeoNotifier.cpp:
Modules/geolocation/Geolocation.cpp:
Modules/indexeddb/IDBTransaction.cpp:
Modules/indexeddb/client/TransactionOperation.h:
Modules/indexeddb/server/UniqueIDBDatabase.cpp:
Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
Modules/indexeddb/shared/InProcessIDBServer.cpp:
Modules/mediastream/UserMediaRequest.cpp:
Modules/notifications/NotificationCenter.cpp:
Modules/webaudio/AudioContext.cpp:
Modules/webdatabase/Database.cpp:
Modules/websockets/WebSocket.cpp:
Modules/websockets/WebSocketChannel.cpp:
Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
accessibility/AccessibilityObject.cpp:
accessibility/AccessibilityRenderObject.cpp:
bindings/gobject/GObjectEventListener.cpp:
bindings/js/JSCustomElementInterface.cpp:
bindings/js/JSCustomSQLStatementErrorCallback.cpp:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDOMGlobalObjectTask.cpp:
bindings/js/JSDOMWindowBase.cpp:
bindings/js/JSErrorHandler.cpp:
bindings/js/JSEventListener.cpp:
bindings/js/JSMutationCallback.cpp:
bindings/js/JSNodeFilterCustom.cpp:
bindings/js/SerializedScriptValue.cpp:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/test/JS/JSTestCallback.cpp:
bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
bridge/runtime_root.cpp:
css/CSSFontSelector.cpp:
css/StyleSheetContents.cpp:
dom/CharacterData.cpp:
dom/ContainerNode.cpp:
dom/Document.cpp:
dom/EventTarget.cpp:
dom/Node.cpp:
dom/ScriptExecutionContext.cpp:
dom/ScriptedAnimationController.cpp:
dom/StringCallback.cpp:
html/HTMLEmbedElement.cpp:
html/HTMLFormControlElement.cpp:
html/HTMLFormElement.cpp:
html/HTMLInputElement.cpp:
html/HTMLLinkElement.cpp:
html/HTMLMediaElement.cpp:
html/HTMLObjectElement.cpp:
html/HTMLOptionElement.cpp:
html/HTMLScriptElement.cpp:
html/HTMLTableElement.cpp:
html/HTMLTextAreaElement.cpp:
html/HTMLTitleElement.cpp:
html/parser/HTMLDocumentParser.cpp:
html/shadow/SliderThumbElement.cpp:
html/shadow/SpinButtonElement.cpp:
inspector/InspectorFrontendClientLocal.cpp:
loader/DocumentLoader.cpp:
loader/DocumentThreadableLoader.cpp:
loader/MediaResourceLoader.cpp:
loader/NetscapePlugInStreamLoader.cpp:
loader/ResourceLoader.cpp:
loader/SubresourceLoader.cpp:
loader/cache/CachedRawResource.cpp:
loader/cf/SubresourceLoaderCF.cpp:
loader/mac/ResourceLoaderMac.mm:
page/DOMWindow.cpp:
page/DOMWindowExtension.cpp:
page/FrameView.cpp:
page/animation/AnimationBase.cpp:
page/scrolling/ThreadedScrollingTree.cpp:
platform/ScrollView.cpp:
platform/graphics/DisplayRefreshMonitor.cpp:
platform/graphics/ca/win/CACFLayerTreeHost.cpp:
platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
platform/ios/WebVideoFullscreenControllerAVKit.mm:
platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
platform/mac/WidgetMac.mm:
platform/network/BlobResourceHandle.cpp:
platform/network/cf/ResourceHandleCFNet.cpp:
platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
platform/network/curl/CurlDownload.cpp:
platform/network/mac/ResourceHandleMac.mm:
platform/network/soup/SocketStreamHandleSoup.cpp:
platform/win/PopupMenuWin.cpp:
workers/WorkerScriptLoader.cpp:
xml/XMLHttpRequest.cpp:
xml/parser/XMLDocumentParser.cpp:
xml/parser/XMLDocumentParserLibxml2.cpp:

4:39 PM Changeset in webkit [200894] by enrica@apple.com

5 edits in trunk/Source

Remove unused initializer for WebEvent on iOS.
https://bugs.webkit.org/show_bug.cgi?id=157689

Reviewed by Anders Carlsson.

Source/WebCore:

This is no longer used and can be removed.
The logic tied to isPopupVariant has been incorporated
in keyboard flags. The characterSet property is no longer needed too.

platform/ios/WebEvent.h:
platform/ios/WebEvent.mm:

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:isPopupVariant:keyCode:isTabKey:characterSet:]): Deleted.
(-[WebEvent _characterSetDescription]): Deleted.
(-[WebEvent isPopupVariant]): Deleted.
(-[WebEvent characterSet]): Deleted.

Source/WebKit/mac:

Removing use of characterSet property.

WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

4:29 PM Changeset in webkit [200893] by Joseph Pecoraro

3 edits in trunk/Source/JavaScriptCore

Web Inspector: Inform augmenting client when inspector controller is destroyed
https://bugs.webkit.org/show_bug.cgi?id=157688
<rdar://problem/25832724>

Reviewed by Timothy Hatcher.

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):

inspector/augmentable/AugmentableInspectorControllerClient.h:

There is a weak relationship between the InspectorController and the
AugmentingClient. Let the augmenting client know when the controller
is destroyed so it doesn't try to use us anymore.

4:28 PM Changeset in webkit [200892] by matthew_hanson@apple.com

1 copy in tags/Safari-602.1.32.2.1

New Tag.

4:26 PM Changeset in webkit [200891] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Try to fix some non-iOS builds.

mac/postprocess-framework-headers.sh:

4:15 PM Changeset in webkit [200890] by rniwa@webkit.org

4 edits in trunk/Websites/perf.webkit.org

Unreviewed. Added the missing executable bits.

tools/bundle-v3-scripts.py: Added property svn:executable.
tools/detect-changes.js: Added property svn:executable.
tools/process-maintenance-backlog.py: Added property svn:executable.

3:40 PM Changeset in webkit [200889] by Simon Fraser

4 edits
2 adds
3 deletes in trunk

cross-fade() rendering doesn't match expectation
https://bugs.webkit.org/show_bug.cgi?id=157665
rdar://problem/17917708

Reviewed by Dean Jackson.

Source/WebCore:

Cross-fading two opaque images would result in a non-opaque result in between the endpoints,
probably because r157045 caused both images to be drawn with srcOver, since drawImage()
clobbers the composite operation in the context.

Fix by passing the composite operation to the drawImage() calls for the non-transparency layer
code path.

Converted css3/images/cross-fade-blending.html into a ref test to test this.

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::drawCrossfadeSubimage):

LayoutTests:

Make css3/images/cross-fade-blending.html a ref test.

css3/images/cross-fade-blending-expected.html: Added.
css3/images/cross-fade-blending-expected.png: Removed.
css3/images/cross-fade-blending-expected.txt: Removed.
css3/images/cross-fade-blending.html:
platform/mac/css3/images/cross-fade-blending-expected.png: Removed.

3:40 PM Changeset in webkit [200888] by Simon Fraser

18 edits in trunk

Unprefix -webkit-cross-fade()
https://bugs.webkit.org/show_bug.cgi?id=157632

Reviewed by Darin Adler.
Source/WebCore:

Support unprefixed cross-fade() in addition to the prefixed value when parsing,
and have computed style round-trip the correct one.

If computed style is queried during an image transition, return an unprefixed
cross-fade(). If blending cross-fade values, only return the prefixed function if
both inputs are prefixed.

Tested by modified and existing tests.

css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::customCSSText):
(WebCore::CSSCrossfadeValue::blend):

css/CSSCrossfadeValue.h:

(WebCore::CSSCrossfadeValue::create):
(WebCore::CSSCrossfadeValue::isPrefixed):
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):

css/CSSParser.cpp:

(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
(WebCore::CSSParser::parseCrossfade):

css/CSSParser.h:

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

animations/cross-fade-background-image-expected.html:
animations/cross-fade-background-image.html:
animations/cross-fade-border-image-source.html:
animations/cross-fade-list-style-image.html:
animations/cross-fade-webkit-mask-box-image.html:
animations/cross-fade-webkit-mask-image.html:
animations/resources/animation-test-helpers.js:

(parseCSSImage):
(parseCrossFade):
(compareCSSImages):

fast/css/getComputedStyle/computed-style-cross-fade-expected.txt:
fast/css/getComputedStyle/computed-style-cross-fade.html:
transitions/resources/transition-test-helpers.js:

(parseCrossFade):

3:34 PM Changeset in webkit [200887] by yoav@yoav.ws

8 edits
4 adds in trunk

ResourceTiming entries for cached resources and XHR
https://bugs.webkit.org/show_bug.cgi?id=157669

Reviewed by Alex Christensen.

Source/WebCore:

Moves the ResourceTiming storage and addition logic into its own class, so that it can be accessed by both CachedResourceLoader and DocumentThreadableLoader.
Using the above, adds ResourceTiming collection into DocumentThreadableLoader, in order to support ResourceTiming entries for XHR based requests.
Adds ResourceTiming entries for resources that are reused from the memory cache.

Test: http/tests/performance/performance-resource-timing-cached-entries.html

CMakeLists.txt: Add ResourceTimingInformation.
WebCore.xcodeproj/project.pbxproj: Add ResourceTimingInformation.
loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didFinishLoading): Add a call to addResourceTiming.
(WebCore::DocumentThreadableLoader::loadRequest): Store the initiator information.

loader/DocumentThreadableLoader.h:
loader/ResourceTimingInformation.cpp: Added.

(WebCore::ResourceTimingInformation::addResourceTiming): Moved addResourceTiming logic from CachedResourceLoader.
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation): Moved addResourceTiming logic from
CachedResourceLoader. Removed reliance on the committingFirstRealLoad bool when storing initiator info, as I don't
see why it is required, and it made no sense in the context of DocumentThreadableLoader.

loader/ResourceTimingInformation.h: Added.
loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource): Add a ResourceTiming entry when a resource is reused from MemoryCache.
(WebCore::CachedResourceLoader::revalidateResource): Use ResourceTimingInformation::storeResourceTimingInitiatorInformation.
(WebCore::CachedResourceLoader::loadResource): Use ResourceTimingInformation::storeResourceTimingInitiatorInformation.
(WebCore::CachedResourceLoader::loadDone): Use ResourceTimingInformation::addResourceTiming.
(WebCore::CachedResourceLoader::storeResourceTimingInitiatorInformation): Deleted.

loader/cache/CachedResourceLoader.h:

LayoutTests:

These tests make sure that cacheable resources as well as XHR based resources
have ResourceTiming entries.

http/tests/performance/performance-resource-timing-cached-entries-expected.txt: Added.
http/tests/performance/performance-resource-timing-cached-entries.html: Added.

3:22 PM Changeset in webkit [200886] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Typing "layout" in filter for Layout and Rendering Timeline matches everything
https://bugs.webkit.org/show_bug.cgi?id=157684
<rdar://problem/26276588>

Reviewed by Joseph Pecoraro.

Hidden columns should not participate in built-in grid filtering
using DataGrid.filterText. Hidden columns can still be custom filtered,
which is how TimelineDataGrid filters scopebar columns.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGridNode.prototype.get filterableData):
Skip hidden columns.

2:40 PM Changeset in webkit [200885] by Ryan Haddad

2 edits in branches/safari-601-branch/LayoutTests

Merge r194403. rdar://problem/26274768

2:24 PM Changeset in webkit [200884] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Runaway malloc memory usage in this simple JSC program
https://bugs.webkit.org/show_bug.cgi?id=157682

Reviewed by Mark Lam.

heap/WeakSet.cpp:

(JSC::WeakSet::sweep): Whenever we might add a block to
m_logicallyEmptyWeakBlocks, be sure also to sweep a block in
m_logicallyEmptyWeakBlocks. Otherwise, additions might outpace removals
even when all memory is freed.

We do this whenever we *might* add a block and not just whenever we *do*
add a block because we'd like to sweep the entries in
m_logicallyEmptyWeakBlocks promptly even when it's not growing, and this
is a reasonably rate-limited opportunity to do so.

2:22 PM Changeset in webkit [200883] by matthew_hanson@apple.com

1 copy in tags/Safari-601.7.2

New Tag.

2:21 PM Changeset in webkit [200882] by matthew_hanson@apple.com

1 copy in tags/Safari-601.1.46.141

New Tag.

1:47 PM Changeset in webkit [200881] by matthew_hanson@apple.com

1 copy in tags/Safari-602.1.32.2

New Tag.

1:35 PM Changeset in webkit [200880] by aakash_jain@apple.com

9 edits in trunk/Tools

Dashboard code restructuring
https://bugs.webkit.org/show_bug.cgi?id=157680
<rdar://problem/14736888>

Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:

(BubbleQueueView.prototype.addLinkToRow): Moved to base class.
(BubbleQueueView.prototype.addTextToRow): Moved to base class.
(BubbleQueueView.prototype._addDividerToPopover): Moved to base class.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:

(BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:

(BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
additional argument.
(BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
(BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
(BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:

(documentReady): Display any customView if available.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:

(QueueView.prototype.addLinkToRow): Moved from child class, no changes.
(QueueView.prototype.addTextToRow): Moved from child class, no changes.
(QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
(QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
by taking latestIterationGetter method as an argument.
(QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
(QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
(QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(a:hover:link): Underline only when there is a link.

1:16 PM Changeset in webkit [200879] by mark.lam@apple.com

29 edits in trunk

We should have one calleeSaveRegistersBuffer per VMEntryFrame, not one per VM.
https://bugs.webkit.org/show_bug.cgi?id=157537
<rdar://problem/24794845>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The pre-existing code behaves this way:

When JS code throws an exception, it saves callee save registers in the VM calleeSaveRegistersBuffer. These values are meant to be restored to the callee save registers later either at the catch handler or at the uncaught exception handler.

If the Inspector is enable, the VM will invoke inspector C++ code to inspect the exception. That C++ code can change the values of the callee save registers.

The inspector code in turn re-enters the VM to execute JS inspector code.

The JS inspector code can run hot enough that we do an enterOptimizationCheck
on it. The enterOptimizationCheck first saves all callee save registers
into the VM calleeSaveRegistersBuffer.

This effectively overwrites the values in the VM calleeSaveRegistersBuffer
from (1).

Eventually, execution returns to the catch handler or the uncaught exception handler which restores the overwritten values in the VM calleeSaveRegistersBuffer to the callee save registers.

When execution returns to the C++ code that entered the VM before (1), the
values in the callee registers are not what that code expects, and badness
and/or crashes ensues.

This patch applies the following fix:

Allocate space in the VMEntryFrame for the calleeSaveRegistersBuffer. This ensures that each VM entry session has its own buffer to use, and will not corrupt the one from the previous VM entry session.

Delete the VM calleeSaveRegistersBuffer.

Change all locations that uses the VM calleeSaveRegistersBuffer to use the calleeSaveRegistersBuffer in the current VMEntryFrame.

Renamed all uses of the term "VMCalleeSavesBuffer" to "VMEntryFrameCalleeSavesBuffer".

This fix has been tested on the following configurations:

JSC and layout tests on a debug ASan build for 64-bit x86_64.
JSC tests on a release ASan build for 32-bit x86.
JSC tests on a release normal (non-ASan) build for ARM64.
JSC tests on a release normal (non-ASan) build for ARMv7 and ARMv7s.
JSC tests on a release ASan CLOOP build for x86_64.

These test runs did not produce any new crashes. The ASan CLOOP has some
pre-existing crashes which are not due to this patch.

This bug can be tested by running the inspector/debugger/regress-133182.html test
on an ASan build.

bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::emitExplicitExceptionHandler):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSRExitCompiler.cpp:
dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()):
(JSC::UnwindFunctor::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::UnwindFunctor::copyCalleeSavesToVMCalleeSavesBuffer): Deleted.

interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

interpreter/VMEntryRecord.h:

(JSC::VMEntryRecord::calleeSaveRegistersBufferOffset):
(JSC::VMEntryRecord::prevTopCallFrame):
(JSC::VMEntryRecord::unsafePrevTopCallFrame):
(JSC::VMEntryFrame::vmEntryRecordOffset):
(JSC::VMEntryFrame::calleeSaveRegistersBufferOffset):

jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitRandomThunk):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::restoreCalleeSavesFromVMCalleeSavesBuffer): Deleted.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitRestoreSavedTagRegisters):
(JSC::AssemblyHelpers::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMEntryFrameCalleeSavesBuffer):
(JSC::AssemblyHelpers::copyCalleeSavesToVMCalleeSavesBuffer): Deleted.
(JSC::AssemblyHelpers::copyCalleeSavesFromFrameOrRegisterToVMCalleeSavesBuffer): Deleted.

jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileExceptionHandlers):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emitSlow_op_loop_hint):

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_catch):

jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::nativeForGenerator):

llint/LLIntThunks.cpp:

(JSC::vmEntryRecord):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

(JSC::VM::getCTIStub):
(JSC::VM::calleeSaveRegistersBufferOffset): Deleted.

wasm/WASMFunctionCompiler.h:

(JSC::WASMFunctionCompiler::endFunction):

LayoutTests:

inspector/debugger/regress-133182-expected.txt:
Rebased test results to update line numbers.
platform/mac/TestExpectations:
Unskip the test.

12:42 PM Changeset in webkit [200878] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Summary page doesn't report some missing platforms
https://bugs.webkit.org/show_bug.cgi?id=157670

Reviewed by Darin Adler.

This patch improves the warning text for missing platforms and fixes the bug that platforms that don't have
any data reported for a given test would not be reported as missing.

public/v3/pages/summary-page.js:

(SummaryPage.prototype.render): Added instrumentations.
(SummaryPage.prototype._constructRatioGraph): Always create both the ratio bar graph and the spinner icon.
(SummaryPage.prototype._renderCell): Extracted from _constructRatioGraph. Toggle the displayed-ness of the
spinner and the ratio bar graph in the cell by CSS for better performance.
(SummaryPage.prototype._warningTextForGroup): Extracted from _constructRatioGraph. Rephrased warning text
for clarity and adopted new API of SummaryPageConfigurationGroup.
(SummaryPage.prototype._warningTextForGroup.mapAndSortByName): Added.
(SummaryPage.prototype._warningTextForGroup.pluralizeIfNeeded): Added.
(SummaryPage.cssTemplate): Added rules to toggle the visibility of spinner icons and bar graphs.
(SummaryPageConfigurationGroup): Replaced this._warnings by more explicitly named this._missingPlatforms
and this._platformsWithoutBaseline. Also add a platform to this._missingPlatforms if it didn't appear in
any metrics. Note that adding a platform whenever it doesn't in any one metric would be incorrect since
some tests uses a different test name on different platforms: e.g. PLT-Mac and PLT-iPhone.
(SummaryPageConfigurationGroup.prototype.missingPlatforms): Added.
(SummaryPageConfigurationGroup.prototype.platformsWithoutBaseline): Added.
(SummaryPageConfigurationGroup.prototype._fetchAndComputeRatio):

12:42 PM Changeset in webkit [200877] by Ryan Haddad

2 edits in trunk/Source/WebKit2

Attempt to fix the iOS build after r200874

Unreviewed build fix.

UIProcess/API/Cocoa/WKWebViewConfiguration.h:

12:34 PM Changeset in webkit [200876] by d_russell@apple.com

13 edits in trunk

AX: Regressions in undo/redo accessibility from Bug 153361
https://bugs.webkit.org/show_bug.cgi?id=157652

Reviewed by Darin Adler.

Use indexForVisiblePosition & visiblePositionForIndex to store selection data
so that AccessibilityUndoReplacedText can build valid selection ranges and
retrieve strings for AT notifications.

Source/WebCore:

Tests: accessibility/mac/value-change/value-change-user-info-contenteditable-expected.txt:

accessibility/mac/value-change/value-change-user-info-contenteditable.html:
accessibility/mac/value-change/value-change-user-info-textarea-expected.txt:
accessibility/mac/value-change/value-change-user-info-textarea.html:
accessibility/mac/value-change/value-change-user-info-textfield-expected.txt:
accessibility/mac/value-change/value-change-user-info-textfield.html:

accessibility/AXObjectCache.cpp:

(WebCore::AccessibilityReplacedText::AccessibilityReplacedText):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):

editing/CompositeEditCommand.cpp:

(WebCore::AccessibilityUndoReplacedText::configureRangeDeletedByReapplyWithEndingSelection):
(WebCore::AccessibilityUndoReplacedText::configureRangeDeletedByReapplyWithStartingSelection):
(WebCore::AccessibilityUndoReplacedText::setRangeDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::captureTextForUnapply):
(WebCore::AccessibilityUndoReplacedText::captureTextForReapply):
(WebCore::AccessibilityUndoReplacedText::textDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::textDeletedByReapply):
(WebCore::AccessibilityUndoReplacedText::postTextStateChangeNotificationForUnapply):
(WebCore::AccessibilityUndoReplacedText::postTextStateChangeNotificationForReapply):
(WebCore::EditCommandComposition::EditCommandComposition):
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::EditCommandComposition::setStartingSelection):
(WebCore::EditCommandComposition::setEndingSelection):
(WebCore::EditCommandComposition::setRangeDeletedByUnapply):
(WebCore::AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyIndexesWithEditCommandEndingSelection): Deleted.
(WebCore::AccessibilityUndoReplacedText::confgureTextToBeDeletedByUnapplyStartIndexWithEditCommandStartingSelection): Deleted.
(WebCore::AccessibilityUndoReplacedText::setTextInsertedByUnapplyRange): Deleted.
(WebCore::AccessibilityUndoReplacedText::captureTextToBeDeletedByUnapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::captureTextToBeDeletedByReapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::textInsertedByUnapply): Deleted.
(WebCore::AccessibilityUndoReplacedText::textInsertedByReapply): Deleted.
(WebCore::EditCommandComposition::setTextInsertedByUnapplyRange): Deleted.

editing/CompositeEditCommand.h:
editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

editing/TypingCommand.cpp:

(WebCore::TypingCommand::postTextStateChangeNotificationForDeletion):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):

LayoutTests:

accessibility/mac/value-change/value-change-user-info-contenteditable-expected.txt:
accessibility/mac/value-change/value-change-user-info-contenteditable.html:
accessibility/mac/value-change/value-change-user-info-textarea-expected.txt:
accessibility/mac/value-change/value-change-user-info-textarea.html:
accessibility/mac/value-change/value-change-user-info-textfield-expected.txt:
accessibility/mac/value-change/value-change-user-info-textfield.html:

12:19 PM Changeset in webkit [200875] by Chris Dumez

22 edits in trunk/Source

Unreviewed, rolling out r200837.

Seems to have regressed Speedometer and JetStream on iOS

Reverted changeset:

"DOMPromise should only restrict the resolution type"
https://bugs.webkit.org/show_bug.cgi?id=157307
http://trac.webkit.org/changeset/200837

12:14 PM Changeset in webkit [200874] by weinig@apple.com

9 edits in trunk/Source

Rename WKDataDetectorTypeSpotlightSuggestion to WKDataDetectorTypeLookupSuggestion
<rdar://problem/26269611>

Reviewed by Dan Bernstein and Enrica Casucci.

Source/WebCore:

editing/cocoa/DataDetection.h:
editing/cocoa/DataDetection.mm:

(WebCore::constructURLStringForResult):
(WebCore::DataDetection::detectContentInRange):

Source/WebKit2:

Shared/API/Cocoa/WKFoundation.h:
Shared/API/c/WKDeclarationSpecifiers.h:
UIProcess/API/Cocoa/WKWebView.mm:

(fromWKDataDetectorTypes):

UIProcess/API/Cocoa/WKWebViewConfiguration.h:
mac/postprocess-framework-headers.sh:

12:01 PM Changeset in webkit [200873] by Matt Baker

8 edits in trunk/Source/WebInspectorUI

Web Inspector: Script ProfileViews should be searchable
https://bugs.webkit.org/show_bug.cgi?id=157581
<rdar://problem/26228530>

Reviewed by Joseph Pecoraro.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.get filterText):
Make filterText readable.

UserInterface/Views/ProfileDataGridNode.js:

(WebInspector.ProfileDataGridNode.prototype.get callingContextTreeNode):
(WebInspector.ProfileDataGridNode.prototype.filterableDataForColumn):
Add filterable data for the "function" column.
(WebInspector.ProfileDataGridNode.prototype._updateChildrenForModifiers):
(WebInspector.ProfileDataGridNode.prototype.get node): Deleted.
Renamed callingContextTreeNode to be less ambiguous.

UserInterface/Views/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridTree.prototype._updateCurrentFocusDetails):

UserInterface/Views/ProfileView.js:

(WebInspector.ProfileView.prototype.get dataGrid):
Expose data grid for use in parent view.

UserInterface/Views/ScriptClusterTimelineView.js:

(WebInspector.ScriptClusterTimelineView.prototype.selectRecord):
Drive-by fix: forward property to current child TimelineView.

UserInterface/Views/ScriptProfileTimelineView.js:

(WebInspector.ScriptProfileTimelineView):
(WebInspector.ScriptProfileTimelineView.prototype._scopeBarSelectionDidChange):
(WebInspector.ScriptProfileTimelineView.prototype._showProfileViewForOrientation):
Helper function to switch profile views. Persist filter text when
switching to the new profile view.

(WebInspector.ScriptProfileTimelineView.prototype.get showsFilterBar): Deleted.
Remove FIXME and show filter bar.

UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView.prototype.setupDataGrid):
Support switching to a new data grid.
(WebInspector.TimelineView.prototype.dataGridMatchNodeAgainstCustomFilters):
Hooking up filtering causes data grid nodes to be filtered based on the
ruler selection. Although ScriptProfileTimelineView performs its own
time-based filtering, this is necessary to prevent an assert.

(WebInspector.TimelineView.prototype._timelineDataGridSelectedNodeChanged):
(WebInspector.TimelineView.prototype._timelineDataGridNodeWasFiltered):
Converted arrow functions to member functions to allow unregistering
event listeners on outgoing data grid when swapping grids.

11:57 AM Changeset in webkit [200872] by n_wang@apple.com

3 edits
2 adds in trunk

AX: Wrong CharacterOffset from an upstream VisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=157644

Reviewed by Chris Fleizach.

Source/WebCore:

We should adjust the text marker's CharacterOffset if its corresponding
VisiblePosition has upstream affinity.

Test: accessibility/mac/character-offset-from-upstream-position.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::characterOffsetForTextMarkerData):
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::localCaretRectForCharacterOffset):

LayoutTests:

accessibility/mac/character-offset-from-upstream-position-expected.txt: Added.
accessibility/mac/character-offset-from-upstream-position.html: Added.

11:56 AM Changeset in webkit [200871] by matthew_hanson@apple.com

3 edits
1 add in branches/safari-601.1.46-branch/Source/JavaScriptCore

Merge r196490. rdar://problem/26270871

11:56 AM Changeset in webkit [200870] by matthew_hanson@apple.com

4 edits in branches/safari-601.1.46-branch/Source/JavaScriptCore

Merge r196240. rdar://problem/26271188

11:45 AM Changeset in webkit [200869] by matthew_hanson@apple.com

3 edits
1 add in branches/safari-601-branch/Source/JavaScriptCore

Merge r196490. rdar://problem/26270811

11:45 AM Changeset in webkit [200868] by matthew_hanson@apple.com

4 edits in branches/safari-601-branch/Source/JavaScriptCore

Merge r196240. rdar://problem/26271108

11:45 AM Changeset in webkit [200867] by Beth Dakin

2 edits in trunk/Source/WebKit/mac

Build fix.

WebView/WebView.mm:

11:29 AM Changeset in webkit [200866] by Beth Dakin

15 edits
1 add
1 delete in trunk/Source

Source/JavaScriptCore:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396

Reviewed by Darin Adler.

Import #import <wtf/spi/darwin/dyldSPI.h> which now declares all of the
needed dyld code.

API/JSWrapperMap.mm:

Source/WebCore:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396

Reviewed by Darin Adler.

This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h

WebCore.xcodeproj/project.pbxproj:
html/HTMLObjectElement.cpp:
platform/graphics/ios/FontServicesIOS.mm:
platform/spi/cocoa/DynamicLinkerSPI.h: Removed.

Source/WebKit/ios:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396

Reviewed by Darin Adler.

This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h

Misc/WebUIKitSupport.mm:

Source/WebKit/mac:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396

Reviewed by Darin Adler.

This patch removes DynamicLinkerSPI.h and replaces it with
wtf/spi/darwin/dyldSPI.h

WebView/WebView.mm:

Source/WebKit2:
Add dyldSPI.h for linked on or after checks, and add one for link preview
https://bugs.webkit.org/show_bug.cgi?id=157401

Reviewed by Darin Adler.

Set _allowsLinkPreview to YES for programs linked on or after
firstSDKVersionWithLinkPreviewEnabledByDefault.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

Source/WTF:
Add dyldSPI.h
https://bugs.webkit.org/show_bug.cgi?id=157401
-and corresponding-
rdar://problem/26253396

Reviewed by Darin Adler.

New header for dyld spi.

WTF.xcodeproj/project.pbxproj:
wtf/spi/darwin/dyldSPI.h: Added.

11:11 AM Changeset in webkit [200865] by bshafiei@apple.com

5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:11 AM Changeset in webkit [200864] by bshafiei@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

11:06 AM Changeset in webkit [200863] by yoav@yoav.ws

6 edits in trunk

Turn on WEB_TIMING for all ports
https://bugs.webkit.org/show_bug.cgi?id=157673

Reviewed by Alex Christensen.

Turn on WEB_TIMING by default on the cmake Mac port, to match it with all other ports,
and make sure that the flag will be on by default for all ports.

Source/cmake/OptionsGTK.cmake: Remove the specific private flag for WEB_TIMING.
Source/cmake/OptionsMac.cmake: Remove the specific private flag for WEB_TIMING.
Source/cmake/WebKitFeatures.cmake: Turn on WEB_TIMING for all ports by default.

Tools:

Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.

10:42 AM Changeset in webkit [200862] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

Fullscreen view attempts to resize when in 2-up mode
https://bugs.webkit.org/show_bug.cgi?id=157558

Reviewed by Darin Adler.

No need to react to NSApplicationDidChangeScreenParametersNotification to resize the
fullscreen window when the screen parameters change; the NSWindow fullscreen machinery
will do that on our behalf.

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController windowDidLoad]): Deleted.
(-[WKFullScreenWindowController applicationDidChangeScreenParameters:]): Deleted.

10:37 AM Changeset in webkit [200861] by beidson@apple.com

3 edits in trunk/Source/WebCore

Give CrossThreadCopier a default specialization for Vectors of objects.
https://bugs.webkit.org/show_bug.cgi?id=157675

Reviewed by Darin Adler.

No new tests (Refactor, no change in behavior).

platform/CrossThreadCopier.cpp:

(WebCore::Vector<String>>::copy): Deleted.

platform/CrossThreadCopier.h: Add a default specialization for Vector<T> where T is a type that is CrossThreadCopyable itself.

10:29 AM Changeset in webkit [200860] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking fast/text-autosizing/ios/text-autosizing-after-back.html as a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=157589

Unreviewed test gardening.

TestExpectations:

9:16 AM Changeset in webkit [200859] by beidson@apple.com

5 edits in trunk

Protector Ref/RefPtrs should have a specified naming style.
https://bugs.webkit.org/show_bug.cgi?id=157591

Reviewed by Darin Adler.

Tools:

Scripts/webkitpy/style/checkers/cpp.py:

(check_identifier_name_in_declaration):
(CppChecker):

Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_names):

Websites/webkit.org:

code-style.md:

9:06 AM Changeset in webkit [200858] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit2

[iOS] <select> elements popover should render right-aligned when in RTL mode
https://bugs.webkit.org/show_bug.cgi?id=157672
<rdar://problem/26193442>

Patch by Antoine Quint <Antoine Quint> on 2016-05-13
Reviewed by Darin Adler.

Add a new isRTL field to the AssistedNodeInformation as specified by the assisted
node's render style and account for it when displaying the table view shown in the
popover attached to the assisted node using the UIView semanticContentAttribute
property.

Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

Shared/AssistedNodeInformation.h:

(WebKit::AssistedNodeInformation::AssistedNodeInformation):

UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

7:58 AM Changeset in webkit [200857] by Chris Dumez

3 edits in trunk/Source/WebCore

Have the WorkerGlobalScope API return more references
https://bugs.webkit.org/show_bug.cgi?id=157663

Reviewed by Alexey Proskuryakov.

Have the WorkerGlobalScope API return more references instead of
pointers.

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::location):
(WebCore::WorkerGlobalScope::navigator):

workers/WorkerGlobalScope.h:

(WebCore::WorkerGlobalScope::self):

7:28 AM Changeset in webkit [200856] by Yusuke Suzuki

3 edits
1 add in trunk/Source/JavaScriptCore

Assertion failure for direct eval in non-class method
https://bugs.webkit.org/show_bug.cgi?id=157138

Reviewed by Saam Barati.

This assertion was incorrect. In method definitions in object literals,
it can be sloppy mode, but its DerivedContextType may not be DerivedContextType::None.

bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::CacheKey::CacheKey):
(JSC::EvalCodeCache::CacheKey::operator==):
(JSC::EvalCodeCache::CacheKey::Hash::equal):
(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):

interpreter/Interpreter.cpp:

(JSC::eval):

tests/stress/direct-eval-in-object-literal-methods.js: Added.

(shouldBe):
(throw.new.Error):
(shouldBe.Parent.prototype.l):
(shouldBe.Parent):
(shouldBe.Derived.prototype.m):
(shouldBe.Derived):

6:41 AM WebKitGTK/2.12.x edited by Carlos Garcia Campos

(diff)

6:41 AM Changeset in webkit [200855] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.12

Merge r200542 - REGRESSION(r196222): [AX][GTK] accessibility/gtk/caret-offsets.html failing
https://bugs.webkit.org/show_bug.cgi?id=153956

Reviewed by Chris Fleizach.

Source/WebCore:

The reason the test began failing is that it was checking the new caret offset
synchronously. For most of the test cases, this was not a problem. But when the
caret was moved out of a focused link, the focus change (and associated repainting)
delayed the caret-moved event long enough to cause the associated test case to fail.
The test now uses shouldBecomeEqualToString() instead of shouldBeEqualToString().

The test also had a supposedly-correct expectation which was wrong: When moving the
caret to a valid accessible offset, the caret-moved event should be for that offset.
This was not the case for the list item test case because emitTextSelectionChange()
was not adjusting the offset for the RenderListMarker, the text of which is exposed
as part of the ATK_ROLE_LIST_ITEM object. This bug was also fixed and the test case
updated accordingly.

No new tests are needed. The previously-failing test is now passing.

editing/atk/FrameSelectionAtk.cpp:

(WebCore::emitTextSelectionChange):

LayoutTests:

Change the test to run asynchronously and update the expectations.

accessibility/gtk/caret-offsets-expected.txt: Updated.
accessibility/gtk/caret-offsets.html: Updated.
platform/gtk/TestExpectations: Unskipped the previously-failing test.

6:35 AM Changeset in webkit [200854] by Carlos Garcia Campos

6 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200486 - Do not attempt to compute min/max width.
https://bugs.webkit.org/show_bug.cgi?id=157320

Reviewed by David Hyatt.

Replaced elements with no intrinsic size (only with ratio) should not call the containing
block to compute the min/max width when the containing block's min/max width
depends on the children's intrinsic size. It could lead to infinite recursion.

Source/WebCore:

Test: fast/replaced/before-content-intrinsic-crash.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth): Unrelated code change.

rendering/RenderImage.cpp: Unrelated code change.

(WebCore::RenderImage::RenderImage): Deleted.

rendering/RenderImage.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):

LayoutTests:

fast/replaced/before-content-intrinsic-crash-expected.txt: Added.
fast/replaced/before-content-intrinsic-crash.html: Added.

6:31 AM Changeset in webkit [200853] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r200455 - [GStreamer] Adaptive streaming issues
https://bugs.webkit.org/show_bug.cgi?id=144040

Reviewed by Philippe Normand.

In the case of adaptive streaming, the GST URI downloader object is creating the source object, in our case
WebKitWebSrc, without taking its ownership. This is breaking the lifetime of the WebKitWebSrc element. We are
using GRefPtr in WebKitWebSrc to ref/unref the object when sending notifications to the main thread, ensuring
that the object is not destroyed before the main thread dispatches the message. But our smart pointers are so
smart that in case of receiving a floating reference, it's converted to a full reference, so that the first time
we try to take a ref of a WebKitWebSrc having a floating reference we are actually taking the ownership
instead. When we try to release the reference, we are actuallty destroying the object, something that the actual
owner is not expecting and causing runtime critical warnings and very often web process crashes.

(WebKitWebProcess:6863): GStreamer-CRITICAL :
Trying to dispose element appsrc1, but it is in READY instead of the NULL state.
You need to explicitly set elements to the NULL state before
dropping the final reference, to allow them to clean up.
This problem may also be caused by a refcounting bug in the
application or some element.

(WebKitWebProcess:6863): GStreamer-CRITICAL : gst_uri_handler_get_uri: assertion 'GST_IS_URI_HANDLER(handler)' failed

(WebKitWebProcess:6863): GStreamer-CRITICAL : gst_uri_get_protocol: assertion 'uri != NULL' failed

This should be fixed in GST, but we can workaround it in WebKit while it's fixed in GST or to prevent this from
happening if other users make the same mistake. The idea is to add a ensureGRef() only available for GRefPtr
when using WebKitWebSrc objects that consumes the floating reference if needed before taking the actual reference.

platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::ensureGRef): Consume the floating ref if needed.

platform/graphics/gstreamer/GRefPtrGStreamer.h:
platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcChangeState): Use ensureGRef().

6:29 AM Changeset in webkit [200852] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.12

Merge r200445 - CSP: Perform case sensitive match against path portion of source expression URL that ends in '/'
https://bugs.webkit.org/show_bug.cgi?id=157275

Reviewed by Darin Adler.

Source/WebCore:

Merged from Blink:
<https://chromium.googlesource.com/chromium/src/+/7bd0a75e3f71a10e71ded31ea5905d5ee3d992eb>

Perform a case-sensitive prefix match of the path portion a source expression that ends in '/'
against the path portion of a request URL as per step 8.5.4 of section Does url match expression
in origin with redirect count of the Content Security Policy Level 3 spec., <https://w3c.github.io/webappsec-csp>
(Editor's Draft, 27 April 2016).

page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::pathMatches):

LayoutTests:

Add test to ensure that the path portion of a request URL is case-sensitively
matched against the path portion of a source expression that ends in '/'.

http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01-expected.txt:
http/tests/security/contentSecurityPolicy/source-list-parsing-paths-01.html:

6:26 AM Changeset in webkit [200851] by Carlos Garcia Campos

6 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200414 - Clicks inside button elements are sometimes discarded when the mouse moves
https://bugs.webkit.org/show_bug.cgi?id=39620

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/events/click-over-descendant-elements.html

dom/Node.cpp:

(WebCore::ancestor):
(WebCore::commonAncestor): Method inspired from
http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
(WebCore::commonAncestorCrossingShadowBoundary): Helper routine
that handles the case of nodes into a shadow node.

dom/Node.h:
page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent): Selecting click event
target node according commonAncestorOverShadowBoundary method.
(WebCore::EventHandler::targetNodeForClickEvent): Deleted.

LayoutTests:

Test coming from http://src.chromium.org/viewvc/blink?view=revision&revision=162081.
Modified to ensure click events do not end up being considered as double click events.

fast/events/click-over-descendant-elements-expected.txt: Added.
fast/events/click-over-descendant-elements.html: Added.
platform/ios-simulator/TestExpectations: Marked new test as failing.

6:07 AM Changeset in webkit [200850] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r200410 - CrashTracer: [USER] com.apple.WebKit.WebContent at …ple.WebCore: WebCore::EditCommandComposition::unapply + 105
https://bugs.webkit.org/show_bug.cgi?id=157282
<rdar://problem/25391441>

Reviewed by Darin Adler.

A frame could be destroyed in the middle of executing undo/redo command.
Therefore, add an early return.

editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):

5:59 AM Changeset in webkit [200849] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200326 - Do not reuse cache entries with conditional headers
https://bugs.webkit.org/show_bug.cgi?id=157205
rdar://problem/25856933

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/xmlhttprequest/if-modified-since-0.html

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):
CachedResourceLoader::determineRevalidationPolicy asserts that the request is not conditional,
which means that it does not have any headers like If-Modified-Since. They are usually different,
because we put the timestamp in the If-Modified-Since header, so it fails the canReuse test because
time has passed since the last If-Modified-Since header was sent. When a user sets the If-Modified-Since
manually to something that is constant, we reuse cache entries when we should not.

platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
Set the source so we can use it in Internals.

LayoutTests:

http/tests/xmlhttprequest/if-modified-since-0-expected.txt: Added.
http/tests/xmlhttprequest/if-modified-since-0.html: Added.

5:33 AM Changeset in webkit [200848] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200301 - Some content causes deep recursion.
https://bugs.webkit.org/show_bug.cgi?id=157230
<rdar://problem/7694756>

Reviewed by Antti Koivisto.

This patch sets a limit(512) on content nesting for the render tree. Elements injected over the limit
are still accessible through DOM APIs but

we stop generating renderers for them -they behave like display: none.
their layout related computed style values are set to default (e.g. window.computedStyle(document.elementById("over512").width -> auto)

Source/WebCore:

Test: fast/block/nested-renderers.html

page/Settings.h:
style/StyleTreeResolver.cpp: Skip renderer constructing and continue with the sibling node.

(WebCore::Style::TreeResolver::resolveComposedTree):

LayoutTests:

fast/block/nested-renderers-expected.html: Added.
fast/block/nested-renderers.html: Added.

5:26 AM Changeset in webkit [200847] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200282 - REGRESSION(194502): overflow: scroll; direction: rtl; divs jump horizontally when scrolled vertically
https://bugs.webkit.org/show_bug.cgi?id=157201

Reviewed by Simon Fraser.

Source/WebCore:

ScrollableArea::scrollToOffsetWithoutAnimation() was mistakenly conflating scroll offsets with
scroll positions.

Test: fast/scrolling/rtl-drag-vertical-scroller.html

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):

LayoutTests:

fast/scrolling/rtl-drag-vertical-scroller-expected.txt: Added.
fast/scrolling/rtl-drag-vertical-scroller.html: Added.

5:18 AM Changeset in webkit [200846] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200247 - Wheel Event Not Fired For body,html { height:100% }
https://bugs.webkit.org/show_bug.cgi?id=148450

Reviewed by Brent Fulgham.

Source/WebCore:

EventHandler::handleWheelEvent() didn't pass the Active flag in the HitTestRequest,
which causes code in RenderLayer::hitTest() to fail to fall back to returning the
root layer if no other element is hit. "Active" is in the default flags,
so just create the HitTestRequest with the default flags.

Test: fast/events/wheel-event-outside-body.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleWheelEvent):

LayoutTests:

Testcase, skipped on iOS which doesn't support wheel events.

fast/events/wheel-event-outside-body-expected.txt: Added.
fast/events/wheel-event-outside-body.html: Added.
platform/ios-simulator/TestExpectations:

5:14 AM Changeset in webkit [200845] by Carlos Garcia Campos

7 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200220 - Content disappears on mouse over.
https://bugs.webkit.org/show_bug.cgi?id=157073
<rdar://problem/24389168>

Reviewed by Simon Fraser.

When a redundant inlinebox is found after constructing the line, we remove it from the tree.
The remove operation marks the ancestor tree dirty (and this newly constructed line is supposed to be clean).
This patch resets this dirty flag on the boxes all the way up to the rootlinebox.
Previously we only cleared the rootinlinebox and we ended up with dirty inlineflowboxes.

Source/WebCore:

Test: fast/text/text-node-remains-dirty-after-calling-surroundContents.html

rendering/BidiRun.h:

(WebCore::BidiRun::setBox):

rendering/RenderBlockFlow.h:
rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::constructLine):
(WebCore::RenderBlockFlow::removeLineBoxIfNeeded):
(WebCore::RenderBlockFlow::computeBlockDirectionPositionsForLine):

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox): Deleted.

rendering/RenderText.cpp:

(WebCore::RenderText::setText):
(WebCore::RenderText::positionLineBox): Deleted.

LayoutTests:

fast/text/text-node-remains-dirty-after-calling-surroundContents-expected.html: Added.
fast/text/text-node-remains-dirty-after-calling-surroundContents.html: Added.

4:52 AM WebKitGTK/2.12.x edited by Carlos Garcia Campos

(diff)

4:51 AM Changeset in webkit [200844] by Carlos Garcia Campos

8 edits
4 adds in releases/WebKitGTK/webkit-2.12

Merge r200188 - AX: [ATK] We need to be smarter about flattening and the accessible text implementation
https://bugs.webkit.org/show_bug.cgi?id=144639

Reviewed by Chris Fleizach.

Source/WebCore:

Defer to WebCore Accessibility more regarding when to include anonymous blocks in the
accessibility tree. Explicitly flatten menu items, headings, list items, and paragraphs
in order to preserve the expected platform behavior for backwards compatibility. Also
map anonymous table parts to DivRole rather than GroupRole for GTK and EFL because ATK
has separate roles for generic text block elements and other generic containers.

Tests: accessibility/gtk/nested-block-element-children.html

accessibility/gtk/spans-paragraphs-and-divs-tree.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

LayoutTests:

Added two new tests and updated three existing tests to reflect the new behavior
regarding inclusion of elements in the accessibility tree and the text value of
included elements.

accessibility/gtk/nested-block-element-children-expected.txt: Added.
accessibility/gtk/nested-block-element-children.html: Added.
accessibility/gtk/spans-paragraphs-and-divs-expected.txt: Updated for new behavior.
accessibility/gtk/spans-paragraphs-and-divs-tree-expected.txt: Added.
accessibility/gtk/spans-paragraphs-and-divs-tree.html: Added.
accessibility/gtk/spans-paragraphs-and-divs.html: Updated for new behavior.
platform/gtk/accessibility/generated-content-with-display-table-crash-expected.txt: Updated for new behavior.
platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Updated for new behavior.

4:49 AM Changeset in webkit [200843] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r200184 - REGRESSION(r199659): Web Process crash when RenderTheme::adjustMenuListStyle is called with a null element
https://bugs.webkit.org/show_bug.cgi?id=157127

Reviewed by Sergio Villar Senin.

This happens for example with tests fast/css/appearance-with-pseudo-elements-in-quirks-mode.html and
fast/css/appearance-with-pseudo-elements.html.

rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::adjustMenuListStyle): Do not change the style color if the given element is nullptr.

4:45 AM Changeset in webkit [200842] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2

Merge r200152 - Remove download message receiver when NetworkProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=157102
<rdar://problem/25550106>

Reviewed by Anders Carlsson.

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::processDidClose):
When the NetworkProcess crashes during a download, we want to remove the message receiver from the map
so we don't get an assertion in ~MessageReceiver in the UIProcess so we do not have a freed
message receiver in the map.

4:43 AM Changeset in webkit [200841] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.12

Merge r200126 - [EFL][GTK] Volume slider only changes volume when thumb is released, not while dragging
https://bugs.webkit.org/show_bug.cgi?id=156970

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Volume slider have to change the volume while dragging the thumb.

Test: media/video-volume-slider-drag.html

Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.createControls): Use the 'input' event instead of the 'change' to
check the changed value correctly.
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderInput): Renamed from handleVolumeSliderChange.
(Controller.prototype.handleVolumeSliderChange): Deleted.

LayoutTests:

Removed the passed test.

platform/efl/TestExpectations:
platform/gtk/TestExpectations:

4:38 AM Changeset in webkit [200840] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r200091 - GuardMalloc crash in WebCore::HTMLFrameElementBase::marginHeight()
https://bugs.webkit.org/show_bug.cgi?id=157020
<rdar://problem/25148315>

Reviewed by Darin Adler.

Calls to setIntegralAttribute triggers event handling code, which can cause
the underlying m_frameOwnerElement member to be deleted. We could clone this
object, but since we only want the width and height we should just read them
while we know the object is in a good state, then execute the potentially
mutating methods.

Tested by imported/blink/fast/dom/HTMLBodyElement/body-inserting-iframe-crash.html.

html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::insertedInto): Read margin width and height before
calling setIntegralAttribute.

4:36 AM Changeset in webkit [200839] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.12/Source

Merge r200068 - Heap corruption is detected when destructing JSGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=156831

Patch by Fujii Hironori <Fujii Hironori> on 2016-04-25
Reviewed by Mark Lam.

WebKit uses CRT static library on Windows. Each copy of the CRT
library has its own heap manager, allocating memory in one CRT
library and passing the pointer across a DLL boundary to be freed
by a different copy of the CRT library is a potential cause for
heap corruption.

Potential Errors Passing CRT Objects Across DLL Boundaries
<https://msdn.microsoft.com/en-us/library/ms235460(v=vs.140).aspx>

JSGlobalObject::createRareDataIfNeeded is inlined but
JSGlobalObject::~JSGlobalObject is not. Then, the heap of
allocating JSGlobalObjectRareData is WebKit.dll, but deallocating
JavaScriptCore.dll. Adding WTF_MAKE_FAST_ALLOCATED to
JSGlobalObjectRareData ensures heap consistency of it. WTF::Lock
also needs WTF_MAKE_FAST_ALLOCATED because it is allocated from
the inlined constructor of JSGlobalObjectRareData.

Source/JavaScriptCore:

Test: fast/dom/insertedIntoDocument-iframe.html

runtime/JSGlobalObject.h:

Add WTF_MAKE_FAST_ALLOCATED to JSGlobalObjectRareData.

Source/WTF:

wtf/Lock.h: Add WTF_MAKE_FAST_ALLOCATED.

4:03 AM Changeset in webkit [200838] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.12

Merge r200056 - Add port 4190 (managesieve) to port blacklist
https://bugs.webkit.org/show_bug.cgi?id=156986
<rdar://problem/9119470>

Reviewed by Daniel Bates.

Source/WebCore:

Tested by security/block-test.html.

platform/URL.cpp:

(WebCore::portAllowed): Add 4190 to the port blacklist.

LayoutTests:

platform/mac/security/block-test-expected.txt
security/block-test-expected.txt:
security/block-test.html:

4:03 AM Changeset in webkit [200837] by youenn.fablet@crf.canon.fr

22 edits in trunk/Source

DOMPromise should only restrict the resolution type
https://bugs.webkit.org/show_bug.cgi?id=157307

Reviewed by Darin Adler.

Source/WebCore:

Removing from DOMPromise the rejection template parameter.
Supported rejection types are integers (Exception codes) and DOM objects (DOMError typically).

Updated toJS and DeferredWrapper to accept Ref<>&& and RefPtr<>&&.
Previously Ref<>&& were not accepted and only "const RefPtr<>&" was accepted.
This in turn created an unecessary churn count when calling toJS.

Changes also allow in most cases to remove the need for explictly declaring the
rejection/resolution type.

Minor refactoring of FontFaceSet promise handling to use DOMPromise in lieu of DeferredWrapper.

Covered by existing tests.
Changes should not be visible from user scripts.

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeText):
(WebCore::blobFromArrayBuffer):
(WebCore::FetchBody::loadingFailed):

Modules/fetch/FetchBody.h:

(WebCore::FetchBody::formData):

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didReceiveResponse):

Modules/fetch/FetchResponse.h:
Modules/mediastream/MediaDevices.h:
Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::didCreateStream):

Modules/streams/ReadableStreamSource.h:
Modules/webaudio/AudioContext.h:
bindings/js/JSDOMBinding.h:

(WebCore::toJS):
(WebCore::jsPair):

bindings/js/JSDOMPromise.cpp:

(WebCore::fulfillPromiseWithJSON):

bindings/js/JSDOMPromise.h:

(WebCore::TypeInspector::decltype):
(WebCore::TypeInspector::testIsVector):
(WebCore::TypeInspector::testIsRefOrRefPtr):
(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DOMPromise::resolve):
(WebCore::DOMPromise::reject):
(WebCore::DeferredWrapper::resolveWithValue):
(WebCore::DeferredWrapper::rejectWithValue):
(WebCore::callPromiseFunction):

bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::importKey):
(WebCore::JSSubtleCrypto::unwrapKey):

css/FontFace.h:
css/FontFaceSet.cpp:

(WebCore::FontFaceSet::PendingPromise::PendingPromise):
(WebCore::FontFaceSet::load):
(WebCore::FontFaceSet::registerReady):

css/FontFaceSet.h:
html/HTMLMediaElement.h:

Source/WTF:

wtf/Ref.h: Adding static constexpr to ease detection of Ref for templates.
wtf/RefPtr.h: Ditto.

4:02 AM Changeset in webkit [200836] by Carlos Garcia Campos

9 edits
4 adds in releases/WebKitGTK/webkit-2.12

Merge r200047 - Toggling animation-play-state can re-start a finished animation
https://bugs.webkit.org/show_bug.cgi?id=156731

Reviewed by Dean Jackson.

Source/WebCore:

After an animation completed, CompositeAnimation::updateKeyframeAnimations() cleared
all state that the animation had run on the element, so changing the value of some
animation property triggered the animation to run again. This is wrong, since animation-name
still applied to the element.

Fix by keeping state for keyframe animations in the Done state in the m_keyframeAnimations
map. This allows for the removal of the index property on KeyframeAnimation.

Tests: animations/change-completed-animation-transform.html

animations/change-completed-animation.html

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::timeToNextService):

page/animation/AnimationBase.h:

(WebCore::AnimationBase::isAnimatingProperty):

page/animation/CompositeAnimation.cpp: Add animations that should stick around to AnimationNameMap,

and swap with m_keyframeAnimations at the end.
(WebCore::CompositeAnimation::updateKeyframeAnimations):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::getAnimatedStyle):

page/animation/KeyframeAnimation.h:

LayoutTests:

animations/animation-direction-reverse-expected.txt:
animations/animation-direction-reverse.html: This is a progression. The test was detecting a

restarted animation.

animations/change-completed-animation-expected.txt: Added.
animations/change-completed-animation-transform-expected.html: Added.
animations/change-completed-animation-transform.html: Added. Ref test that ensures that the final

state for normal and accelerated animations is correct.

animations/change-completed-animation.html: Added. Tests that changing a property doesn't trigger

another animation, by detecting a second animationstart event.

4:01 AM Changeset in webkit [200835] by Carlos Garcia Campos

8 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200043 - play-state not parsed as part of animation shorthand
https://bugs.webkit.org/show_bug.cgi?id=156959

Reviewed by Darin Adler.

Source/WebCore:

We failed to parse animation-play-state as part of the animation shorthand, contrary
to the spec and other browsers.

Fix for both the prefixed and unprefixed properties. There is some compat risk here,
but only changing unprefixed behavior will probably lead to more author confusion.

Test: animations/play-state-in-shorthand.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseAnimationShorthand):

css/CSSPropertyNames.in:
css/StylePropertyShorthand.cpp:

(WebCore::animationShorthandForParsing): Remove the long comment which is no longer relevant
now that the behavior has been written into the spec.

LayoutTests:

animations/animation-shorthand-expected.txt:
animations/animation-shorthand.html:
animations/play-state-in-shorthand-expected.txt: Added.
animations/play-state-in-shorthand.html: Added.
animations/resources/animation-test-helpers.js:

(getPropertyValue):
(comparePropertyValue):

3:41 AM Changeset in webkit [200834] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r200042 - Negative animation-delay is treated as 0s
https://bugs.webkit.org/show_bug.cgi?id=141008

Reviewed by Daniel Bates.

Source/WebCore:

Fix keyframe animations which start in the paused state.

Explicitly move such animations from the new to the paused state, and
set m_pauseTime to 0, rather than leaving it at -1. Fix getElapsedTime()
to compute a correct time elapsed time for such animations, which takes
negative delay into account correctly.

Fix assertions which need to account for the new transition of New -> PlayStatePaused.

Test: animations/play-state-start-paused.html

page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::getElapsedTime):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::animate):

LayoutTests:

Ref test that has an initially-paused animation on 'left' and with a
3d transform.

animations/play-state-start-paused-expected.html: Added.
animations/play-state-start-paused.html: Added.

3:39 AM Changeset in webkit [200833] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r200039 - Stop listening for "media can start" notifications when media player is cleared
https://bugs.webkit.org/show_bug.cgi?id=156985
<rdar://problem/23158505>

Reviewed by Jer Noble.

No new tests, I have not been able to create a test that reliably reproduces this.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal): Add logging.
(WebCore::HTMLMediaElement::selectMediaResource): Assert and return early if there is

no media player.

(WebCore::HTMLMediaElement::clearMediaPlayer): Stop listening for can start notifications.
(WebCore::HTMLMediaElement::visibilityStateChanged): Add logging.
(WebCore::HTMLMediaElement::mediaCanStart): Ditto.

3:37 AM Changeset in webkit [200832] by Carlos Garcia Campos

4 edits
4 adds in releases/WebKitGTK/webkit-2.12

Merge r200030 - REGRESSION (r196012): Subresource may be blocked by Content Security Policy if it only matches 'self'
https://bugs.webkit.org/show_bug.cgi?id=156935
<rdar://problem/25351286>

Reviewed by Darin Adler.

Source/WebCore:

Fixes an issue where subresource load may be blocked by the Content Security Policy (CSP) if its URL only
matched 'self'. In particular, the load would be blocked if initiated from a document that inherited the
origin of its owner document (e.g. the document contained in <iframe src="about:blank"></iframe>).

Following r196012 we compute and cache 'self' and its protocol on instantiation of a ContentSecurityPolicy
object for use when matching a URL against it. These cached values become out-of-date if the document
subsequently inherits the origin of its owner document. Therefore matches against 'self' will fail and
CSP will block a load if its not otherwise allowed by the policy. Previously we would compute 'self' when
parsing the definition of a source list and compute the protocol for 'self' each time we tried to match a
URL against 'self'. So, 'self' would always be up-to-date with respect to the origin of the document.

Tests: http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script.html

http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script.html

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Extract out logic for computing and caching
'self' and its protocol into ContentSecurityPolicy::updateSourceSelf() and make use of this function.
(WebCore::ContentSecurityPolicy::updateSourceSelf): Computes and caches 'self' and its protocol with
respect to the specified SecurityOrigin.
(WebCore::ContentSecurityPolicy::applyPolicyToScriptExecutionContext): Call ContentSecurityPolicy::updateSourceSelf()
to ensure that we have an up-to-date representation for 'self' and the protocol of 'self' which can
become out-of-date if the document inherited the origin of its owner document.

page/csp/ContentSecurityPolicy.h:

LayoutTests:

Add tests to ensure that we match 'self' correctly in an iframe with an about:blank document.

http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script-expected.txt: Added.
http/tests/security/contentSecurityPolicy/iframe-blank-url-programmatically-add-external-script.html: Added.
http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script-expected.txt: Added.
http/tests/security/contentSecurityPolicy/iframe-srcdoc-external-script.html: Added.

3:32 AM Changeset in webkit [200831] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore/platform/gtk/po

Merge r199948 - Updated Hungarian translation
https://bugs.webkit.org/show_bug.cgi?id=156952

Patch by Gabor Kelemen <kelemeng@ubuntu.com> on 2016-04-23
Rubber-stamped by Michael Catanzaro.

hu.po:

3:25 AM Changeset in webkit [200830] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.12

Merge r199895 - REGRESSION (r189567): The top of Facebook's messenger.com looks visually broken
https://bugs.webkit.org/show_bug.cgi?id=156869
<rdar://problem/23204668>

Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/block/min-content-with-box-sizing.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::computeIntrinsicLogicalContentHeightUsing):

LayoutTests:

fast/block/min-content-box-sizing-expected.html: Added.
fast/block/min-content-box-sizing.html: Added.

3:22 AM Changeset in webkit [200829] by Carlos Garcia Campos

10 edits
3 adds in releases/WebKitGTK/webkit-2.12

Merge r199881 - REGRESSION (r194898): Multi download of external SVG defs file by <use> xlinks:href (caching)
https://bugs.webkit.org/show_bug.cgi?id=156368
<rdar://problem/25611746>

Reviewed by Simon Fraser.

Source/WebCore:

We would load svg resources with fragment identifier again because the encoding never matched.

Test: http/tests/svg/svg-use-external.html

loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::setEncoding):
(WebCore::TextResourceDecoder::hasEqualEncodingForCharset):

Encoding can depend on mime type. Add a comparison function that takes this into account.

(WebCore::findXMLEncoding):

loader/TextResourceDecoder.h:

(WebCore::TextResourceDecoder::encoding):

loader/cache/CachedCSSStyleSheet.h:
loader/cache/CachedResource.h:

(WebCore::CachedResource::textResourceDecoder):

Add a way to get the TextResourceDecoder from a cached resource.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

Use the new comparison function.

loader/cache/CachedSVGDocument.h:
loader/cache/CachedScript.h:
loader/cache/CachedXSLStyleSheet.h:

LayoutTests:

http/tests/svg/resources/symbol-defs.svg: Added.
http/tests/svg/svg-use-external-expected.txt: Added.
http/tests/svg/svg-use-external.html: Added.

3:02 AM Changeset in webkit [200828] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebKit2

Merge r199875 - NetworkCacheIOChannelSoup: detach the newly-created IOChannel::readSync thread
https://bugs.webkit.org/show_bug.cgi?id=156907

Reviewed by Carlos Garcia Campos.

NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::IOChannel::readSyncInThread): Detach the new thread,
ensuring the resources are released after the thread exits. Next step is
to set up a thread pool and use that, avoiding thread re-creation.

3:01 AM Changeset in webkit [200827] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r199856 - RenderVideo should always update the intrinsic size before layout.
https://bugs.webkit.org/show_bug.cgi?id=156878

Reviewed by Simon Fraser.

In order to layout video element properly we need to know the correct intrinsic size.
This patch also asserts if we end up updating the intrinsic size right after finishing video renderer layout.

This issues was discovered as part of webkit.org/b/156245. (hence covered by existing tests)

rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updateIntrinsicSize):
(WebCore::RenderVideo::layout):
(WebCore::RenderVideo::updatePlayer):

rendering/RenderVideo.h:

2:57 AM Changeset in webkit [200826] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.12/Source/WebCore

Merge r199851 - Fix crashes when loading SVG images.

loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):
Give the SVG page its own application cache storage.

2:54 AM Changeset in webkit [200825] by Carlos Garcia Campos

8 edits
3 deletes in releases/WebKitGTK/webkit-2.12

Revert "Merge r197520 - DFG should be able to compile StringReplace"

This reverts commit 0c91f9b2c73ecc89dac9ece8b7fa6fd06330e451.

1:22 AM Changeset in webkit [200824] by gskachkov@gmail.com

12 edits in trunk

Assertion failure for super() call in arrow function default parameters
https://bugs.webkit.org/show_bug.cgi?id=157079

Reviewed by Saam Barati.

Source/JavaScriptCore:

Root of the issue that in arrow function we load bounded variables this/super/new.target just after
input parameters were initialized, and did not covered case of default values for function parameters.
Current patch tried to fix issue and allow to load bounded variables earlier, before the input
parameters are assigned by default values.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

tests/stress/arrowfunction-lexical-bind-this-2.js:

LayoutTests:

js/arrowfunction-lexical-bind-arguments-non-strict-expected.txt:
js/arrowfunction-lexical-bind-this-expected.txt:
js/arrowfunction-supercall-expected.txt:
js/arrowfunction-superproperty-expected.txt:
js/script-tests/arrowfunction-lexical-bind-arguments-non-strict.js:
js/script-tests/arrowfunction-lexical-bind-this.js:
js/script-tests/arrowfunction-supercall.js:
js/script-tests/arrowfunction-superproperty.js:

1:11 AM Changeset in webkit [200823] by bshafiei@apple.com

5 edits in tags/Safari-602.1.32.1.1/Source

Versioning.

12:50 AM Changeset in webkit [200822] by bshafiei@apple.com

1 copy in tags/Safari-602.1.32.1.1

New tag.

12:41 AM Changeset in webkit [200821] by svillar@igalia.com

4 edits in trunk

[css-grid] Show auto-repeat line names in ComputedStyle
https://bugs.webkit.org/show_bug.cgi?id=157622

Reviewed by Darin Adler.

Source/WebCore:

Add the necessary machinery to show the named lines from auto-repeat tracks in
getComputedStyle(). A new class OrderedNamedLinesCollector was added to abstract the
retrieval of line names no matter where they come from (explicit or auto-repeat tracks).

css/CSSComputedStyleDeclaration.cpp:

(WebCore::OrderedNamedLinesCollector::OrderedNamedLinesCollector):
(WebCore::OrderedNamedLinesCollector::isEmpty): TRUE if we don't have named lines neither on
explicit nor auto-repeat tracks.
(WebCore::OrderedNamedLinesCollector::appendLines): Add the named lines found for a given
index to the CSSGridLineNamesValue.
(WebCore::OrderedNamedLinesCollector::collectLineNamesForIndex): Collects named lines found
for a given index.
(WebCore::addValuesForNamedGridLinesAtIndex): Use the collector to gather named lines.
(WebCore::valueForGridTrackList): Ditto.

LayoutTests:

fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:

12:33 AM Changeset in webkit [200820] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Always use v3 UI for dashboards and analysis task pages
https://bugs.webkit.org/show_bug.cgi?id=157647

Reviewed by Darin Adler.

Redirect dashboard pages from v1 and v2 to v3's summary page. Also redirect v1 UI's charts page and v2 UI's
analysis task pages to the corresponding v3 pages.

Keep v2's charts page accessible since some features such as segmentation is still only available on v2 UI.

public/index.html:

(init.showCharts): Redirect to v3 UI once the chart list has been parsed.
(init.redirectChartsToV3): Added.

public/v2/index.html:

12:31 AM Changeset in webkit [200819] by commit-queue@webkit.org

17 edits in trunk/Source

Revert r199691.
https://bugs.webkit.org/show_bug.cgi?id=157645
<rdar://problem/26235373>

Patch by Tina Liu <iting_liu@apple.com> on 2016-05-13
Reviewed by Darin Adler.

Source/WebCore:

plugins/PluginStrategy.h:

Source/WebKit/mac:

WebCoreSupport/WebPlatformStrategies.h:
WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.

Source/WebKit2:

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.

Shared/WebProcessCreationParameters.h:
UIProcess/API/C/mac/WKContextPrivateMac.h:
UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextSetPrivateBrowsingPluginLoadClientPolicy): Deleted.

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setPluginLoadClientPolicy):
(WebKit::WebProcessPool::createNewWebProcess): Deleted.
(WebKit::WebProcessPool::setPluginLoadClientPolicyForPrivateBrowsing): Deleted.
(WebKit::WebProcessPool::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
(WebKit::WebProcessPool::clearPluginClientPolicies): Deleted.

UIProcess/WebProcessPool.h:
WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::setPluginLoadClientPolicy):
(WebKit::WebPlatformStrategies::longestMatchedWildcardHostForHost):
(WebKit::WebPlatformStrategies::replaceHostWithMatchedWildcardHost):
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHost):
(WebKit::WebPlatformStrategies::populatePluginCache):
(WebKit::WebPlatformStrategies::setPluginLoadClientPolicyForPrivateBrowsing): Deleted.
(WebKit::WebPlatformStrategies::setPrivateBrowsingPluginLoadClientPolicy): Deleted.
(WebKit::WebPlatformStrategies::clearPluginClientPolicies): Deleted.
(WebKit::WebPlatformStrategies::pluginLoadClientPolicyForHostForPrivateBrowsing): Deleted.

WebProcess/WebCoreSupport/WebPlatformStrategies.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setPluginLoadClientPolicies): Deleted.
(WebKit::WebProcess::setPrivateBrowsingPluginLoadClientPolicy): Deleted.

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

12:31 AM Changeset in webkit [200818] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Show a spinner while fetching data on summary page
https://bugs.webkit.org/show_bug.cgi?id=157658

Reviewed by Darin Adler.

Show a spinner while fetching JSON files on the summary page.

public/v3/components/base.js:

(ComponentBase.prototype.renderReplace): Added a new implementation that simply calls the static version.
(ComponentBase.renderReplace): Made this static.

public/v3/pages/summary-page.js:

(SummaryPage.prototype._constructRatioGraph): Show a spinner icon when SummaryPageConfigurationGroup's
isFetching returns true.
(SummaryPage.cssTemplate): Force the height of each cell to be 2.5rem so that the height of cell doesn't
change when a spinner is replaced by a ratio bar graph.

(SummaryPageConfigurationGroup): Added this._isFetching as an instance variable.
(SummaryPageConfigurationGroup.prototype.isFetching): Added.
(SummaryPageConfigurationGroup.prototype.fetchAndComputeSummary): Set this._isFetching while waiting for
the promises to resolve after 50ms. We don't immediately set this._isFetching to avoid FOC when all JSON
files have been cached.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed