Timeline

Mar 8, 2017:

11:45 PM Changeset in webkit [213632] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

[Modern Media Controls] iOS: Live Broadcast video shows scrubber with 00:00 duration until paused
​https://bugs.webkit.org/show_bug.cgi?id=169374
<rdar://problem/30063273>

Patch by Antoine Quint <Antoine Quint> on 2017-03-08
Reviewed by Dean Jackson.

Source/WebCore:

We need to make sure we update the controls layout when they come back from being hidden, so promote
that functionality from MacOSInlineMediaControls to MediaControls so that iOS can pick that behavior
up.

Test: media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-status-label-enabled-hidden-controls-bar.html

• Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.controlsBarVisibilityDidChange): Deleted.

• Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.controlsBarVisibilityDidChange):

LayoutTests:

Add a test that checks that we correctly show the status label after enabling it with the controls bar
invisible.

• media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-status-label-enabled-hidden-controls-bar-expected.txt: Added.
• media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-status-label-enabled-hidden-controls-bar.html: Added.

10:31 PM Changeset in webkit [213631] by Yusuke Suzuki

• 8 edits in trunk

[GTK] JSC test stress/arity-check-ftl-throw.js.ftl-no-cjit-validate-sampling-profiler crashing on GTK bot
​https://bugs.webkit.org/show_bug.cgi?id=160124

Reviewed by Mark Lam.

JSTests:

• stress/spread-forward-call-varargs-stack-overflow.js:

Source/JavaScriptCore:

When performing CallVarargs, we will copy values to the stack.
Before actually copying values, we need to adjust the stackPointerRegister
to ensure copied values are in the allocated stack area.
If we do not that, OS can break the values that is stored beyond the stack
pointer. For example, signal stack can be constructed on these area, and
breaks values.

This patch fixes the crash in stress/spread-forward-call-varargs-stack-overflow.js
in Linux port. Since Linux ports use signal to suspend and resume threads,
signal handler is frequently called when enabling sampling profiler. Thus this
crash occurs.

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):

• jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

• jit/SetupVarargsFrame.h:

10:02 PM Changeset in webkit [213630] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Fix error/warning duplication in JSON bindings results
​https://bugs.webkit.org/show_bug.cgi?id=169305

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2017-03-08
Reviewed by Alexey Proskuryakov.

The distinction between failures and errors is not meaningful, since all errors will also be failures.
As a result, we only need to keep track of failures.

• Scripts/webkitpy/bindings/main.py:

(BindingsTests.init): Remove errors.
(BindingsTests.detect_changes): Remove errors.
(BindingsTests.main): Remove errors.

9:54 PM Changeset in webkit [213629] by Yusuke Suzuki

• 3 edits
  3 adds in trunk

[JSC] Add helpers to run Six Speed to run-jsc-benchmarks
​https://bugs.webkit.org/show_bug.cgi?id=169351

Reviewed by Saam Barati.

PerformanceTests:

• SixSpeed/wrappers/wrapper.js: Added.

(assertEqual):
(test):
(jscRun):

Tools:

This patch adds an ability to run six-speed microbenchmarks
from run-jsc-benchmarks by specifying six-speed directory in
arewefastyet repository.

While it is a collection of microbenchmarks, it is useful
to ensure that our ES6 optimization covers major use cases.
For the macrobenchmark, we already have ARES-6.

• Scripts/run-jsc-benchmarks:

9:50 PM Changeset in webkit [213628] by jiewen_tan@apple.com

• 29 edits
  6 moves
  9 adds
  2 deletes in trunk

[WebCrypto] Implement SubtleCrypto::DeriveKey method
​https://bugs.webkit.org/show_bug.cgi?id=169386
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch does following few things:

1. It implements SubtleCrypto::DeriveKey method according to the spec:

​https://www.w3.org/TR/WebCryptoAPI/#SubtleCrypto-method-deriveKey.

2. It implements getKeyLength operations for AES-CBC, AES-KW, AES-CFB,

AES-GCM, and HMAC, which is needed by the SubtleCrypto::DeriveKey method.

3. It enables ECDH DeriveKey operation.
4. It replaces unigned long with size_t in all the crypto codes.

Tests: crypto/subtle/derive-key-malformed-parameters.html

crypto/subtle/ecdh-import-key-derive-aes-key.html
crypto/subtle/ecdh-import-key-derive-hmac-key-custom-length.html
crypto/subtle/unwrap-key-malformed-parameters.html
crypto/subtle/wrap-key-malformed-parameters.html
crypto/workers/subtle/ecdh-import-key-derive-key.html

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionEncryptPromise):
(WebCore::jsSubtleCryptoFunctionDecryptPromise):
(WebCore::jsSubtleCryptoFunctionSignPromise):
(WebCore::jsSubtleCryptoFunctionVerifyPromise):
(WebCore::jsSubtleCryptoFunctionDigestPromise):
(WebCore::jsSubtleCryptoFunctionDeriveKeyPromise):
(WebCore::jsSubtleCryptoFunctionDeriveBitsPromise):
Remove unnecessary return statement from callbacks.

• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::deriveBits):
(WebCore::CryptoAlgorithm::getKeyLength):

• crypto/CryptoAlgorithm.h:
• crypto/CryptoAlgorithmParameters.h:
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::generateKey):
(WebCore::CryptoAlgorithmAES_CBC::getKeyLength):

• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:

(WebCore::CryptoAlgorithmAES_CFB::generateKey):
(WebCore::CryptoAlgorithmAES_CFB::getKeyLength):

• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:

(WebCore::CryptoAlgorithmAES_GCM::generateKey):
(WebCore::CryptoAlgorithmAES_GCM::getKeyLength):

• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::generateKey):
(WebCore::CryptoAlgorithmAES_KW::getKeyLength):

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):

• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::getKeyLength):

• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::getKeyLength):

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::getKeyLengthFromHash):
(WebCore::CryptoKeyHMAC::generate):
(WebCore::CryptoKeyHMAC::getKeyLength):

• crypto/keys/CryptoKeyHMAC.h:
• crypto/mac/CryptoAlgorithmECDHMac.cpp:

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

• crypto/parameters/AesKeyParams.idl: Renamed from Source/WebCore/crypto/parameters/AesKeyGenParams.idl.
• crypto/parameters/CryptoAlgorithmAesKeyParams.h: Renamed from Source/WebCore/crypto/parameters/CryptoAlgorithmAesKeyGenParams.h.

Rename AesKeyGenParams to AesKeyParams to represent a unified dictionary for AesKeyGenParams and AesDerivedKeyParams.

• crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
• crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:

LayoutTests:

• crypto/subtle/aes-generate-key-malformed-parameters-expected.txt:
• crypto/subtle/derive-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/derive-key-malformed-parameters.html: Added.
• crypto/subtle/deriveKey-malformed-parameters-expected.txt: Removed.
• crypto/subtle/deriveKey-malformed-parameters.html: Removed.
• crypto/subtle/ecdh-import-key-derive-aes-key-expected.txt: Added.
• crypto/subtle/ecdh-import-key-derive-aes-key.html: Added.
• crypto/subtle/ecdh-import-key-derive-hmac-key-custom-length-expected.txt: Added.
• crypto/subtle/ecdh-import-key-derive-hmac-key-custom-length.html: Added.
• crypto/subtle/unwrap-key-malformed-parameters-expected.txt: Renamed from LayoutTests/crypto/subtle/unwrapKey-malformed-parameters-expected.txt.
• crypto/subtle/unwrap-key-malformed-parameters.html: Renamed from LayoutTests/crypto/subtle/unwrapKey-malformed-parameters.html.
• crypto/subtle/wrap-key-malformed-parameters-expected.txt: Renamed from LayoutTests/crypto/subtle/wrapKey-malformed-parameters-expected.txt.
• crypto/subtle/wrap-key-malformed-parameters.html: Renamed from LayoutTests/crypto/subtle/wrapKey-malformed-parameters.html.

A bit renaming.

• crypto/workers/subtle/ecdh-import-key-derive-key-expected.txt: Added.
• crypto/workers/subtle/ecdh-import-key-derive-key.html: Added.
• crypto/workers/subtle/resources/ecdh-import-key-derive-key.js: Added.

9:16 PM Changeset in webkit [213627] by Wenson Hsieh

• 19 edits in trunk/Source

Add plumbing for WebCore to notify WebKit2 when an edit drag has concluded
​https://bugs.webkit.org/show_bug.cgi?id=169392
<rdar://problem/30882974>

Reviewed by Tim Horton.

Source/WebCore:

Add DragClient::didConcludeEditDrag and invoke it after performing an edit drag in
DragController::performDragOperation.

• page/DragClient.h:

(WebCore::DragClient::didConcludeEditDrag):

• page/DragController.cpp:

(WebCore::DragController::performDragOperation):

Source/WebKit/mac:

Add a stub implementation of WebDragClient::didConcludeEditDrag.

• WebCoreSupport/WebDragClient.h:

Source/WebKit2:

Add boilerplate plumbing for didConcludeEditDataInteraction from the web process to the UI process. Also makes
some minor tweaks to WKContentView along the way.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didConcludeEditDataInteraction):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

Bail out of zooming to the focus rect when performing a data interaction operation. This needs to eventually
work, but is not high priority at the moment.

(-[WKContentView becomeFirstResponderForWebView]):
(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView useSelectionAssistantWithMode:]):
(-[WKContentView _updateChangedSelection:]):
(-[WKContentView suppressAssistantSelectionView]):
(-[WKContentView setSuppressAssistantSelectionView:]):

Add a mechanism for suppressing the text interaction assistant's selection view. If the text interaction
assistant exists while beginning or ending suppression, the selection will be deactivated or activated. If there
is not text interaction assistant, then we instead remember whether or not we should be suppressing the
selection, and bail out of activating the selection if so.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didConcludeEditDataInteraction):

• WebProcess/WebCoreSupport/WebDragClient.h:
• WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::didConcludeEditDrag):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDataInteraction):

8:55 PM Changeset in webkit [213626] by Matt Baker

• 33 edits
  2 copies
  7 adds in trunk

Web Inspector: Add DOM breakpoints UI for node/subtree modification events
​https://bugs.webkit.org/show_bug.cgi?id=168101

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/dom-debugger/dom-breakpoints.html

• inspector/InspectorDOMAgent.h:

Removed declarations for undefined member functions.

• inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::disable):
(WebCore::InspectorDOMDebuggerAgent::mainFrameDOMContentLoaded):
(WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr):
Check that DebuggerAgent breakpoints are active before breaking.
(WebCore::InspectorDOMDebuggerAgent::clear): Deleted.
Replaced by call to discardBindings.

• inspector/InspectorDOMDebuggerAgent.h:

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
DOMDebugger agent needs to discard bindings when the main frame navigates.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

New UI strings.

• UserInterface/Base/Main.js:

(WebInspector.loaded):
Add new manager.

• UserInterface/Controllers/DOMBreakpointTreeController.js: Added.

Handles messages from DOMDebuggerManager, and updates an associated
tree outline as DOM breakpoints are added and removed.
(WebInspector.DOMBreakpointTreeController):
(WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
(WebInspector.DOMBreakpointTreeController.prototype.disconnect):
(WebInspector.DOMBreakpointTreeController.prototype._addBreakpointTreeElement):
(WebInspector.DOMBreakpointTreeController.prototype._removeBreakpointTreeElement):
(WebInspector.DOMBreakpointTreeController.prototype._domBreakpointAdded):
(WebInspector.DOMBreakpointTreeController.prototype._domBreakpointRemoved):
(WebInspector.DOMBreakpointTreeController.prototype._domBreakpointResolvedStateDidChange):
(WebInspector.DOMBreakpointTreeController.prototype._mainResourceDidChange):

• UserInterface/Controllers/DOMDebuggerManager.js: Added.

New frontend manager for the DOMDebugger domain. A DOM breakpoint is
described by a location (URL and node path) and type. The manager keeps
all known DOM breakpoints in memory, and considers a breakpoint to be
"resolved" once its location is pushed to the frontend.

Breakpoints located within a child frame are still associated with the
main frame. Whenever a the main resource of a child frame changes, all
unresolved breakpoints associated with the main frame are speculatively
resolved.

(WebInspector.DOMDebuggerManager):
(WebInspector.DOMDebuggerManager.prototype.get supported):
(WebInspector.DOMDebuggerManager.prototype.get domBreakpoints):
(WebInspector.DOMDebuggerManager.prototype.domBreakpointsForNode):
(WebInspector.DOMDebuggerManager.prototype.addDOMBreakpoint):
(WebInspector.DOMDebuggerManager.prototype.removeDOMBreakpoint):
(WebInspector.DOMDebuggerManager.prototype._detachDOMBreakpoint):
(WebInspector.DOMDebuggerManager.prototype._detachBreakpointsForFrame):
(WebInspector.DOMDebuggerManager.prototype._speculativelyResolveBreakpoints):
(WebInspector.DOMDebuggerManager.prototype._resolveDOMBreakpoint):
(WebInspector.DOMDebuggerManager.prototype._updateDOMBreakpoint):
(WebInspector.DOMDebuggerManager.prototype._saveBreakpoints):
(WebInspector.DOMDebuggerManager.prototype._domBreakpointDisabledStateDidChange):
(WebInspector.DOMDebuggerManager.prototype._childFrameWasRemoved):
(WebInspector.DOMDebuggerManager.prototype._mainFrameDidChange):
(WebInspector.DOMDebuggerManager.prototype._mainResourceDidChange):
(WebInspector.DOMDebuggerManager.prototype._nodeInserted):
(WebInspector.DOMDebuggerManager.prototype._nodeRemoved):

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._pauseReasonFromPayload):
Plumbing for DOM breakpoint pause reason.

• UserInterface/Images/DOMBreakpoint.svg: Added.

New art. Visually very similar to a script breakpoint, with some
tweaks to make it suitable for display in the DOM tree gutter.

• UserInterface/Main.html:

New files.

• UserInterface/Models/DOMBreakpoint.js: Added.

New model class. DOM breakpoints are either associated with a DOM node
when created, or constructed from a cookie and resolved in the future.

(WebInspector.DOMBreakpoint):
(WebInspector.DOMBreakpoint.prototype.get type):
(WebInspector.DOMBreakpoint.prototype.get url):
(WebInspector.DOMBreakpoint.prototype.get path):
(WebInspector.DOMBreakpoint.prototype.get disabled):
(WebInspector.DOMBreakpoint.prototype.set disabled):
(WebInspector.DOMBreakpoint.prototype.get domNodeIdentifier):
(WebInspector.DOMBreakpoint.prototype.set domNodeIdentifier):
(WebInspector.DOMBreakpoint.prototype.get serializableInfo):
(WebInspector.DOMBreakpoint.prototype.saveIdentityToCookie):

• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

The DOMDebugger should not be enabled for legacy backends, since legacy
backend support was never tested and may have issues.

• UserInterface/Test.html:

New files.

• UserInterface/Test/Test.js:

(WebInspector.loaded):
Add new manager.

• UserInterface/Views/ContentView.js:

(WebInspector.ContentView.createFromRepresentedObject):
(WebInspector.ContentView.resolvedRepresentedObjectForRepresentedObject):
Plumbing for additional represented object types. DOMNode is included
because the Debugger sidebar panel shows DOM breakpoint tree elements
as children of a DOM node tree element.

• UserInterface/Views/DOMBreakpointTreeElement.css: Added.

(.item.dom-breakpoint .icon):
(.item.dom-breakpoint.breakpoint-paused-icon .icon):
(.item.dom-breakpoint .status img):
(.item.dom-breakpoint .status > img.disabled):
Styles for "Pause Reason" and "DOM Breakpoints" sections.

• UserInterface/Views/DOMBreakpointTreeElement.js: Added.

Tree element class for DOM breakpoints. Includes a breakpoint status
element and context menu for delete/disable actions, similar to script
breakpoint tree elements.

(WebInspector.DOMBreakpointTreeElement):
(WebInspector.DOMBreakpointTreeElement.displayNameForType):
(WebInspector.DOMBreakpointTreeElement.prototype.onattach):
(WebInspector.DOMBreakpointTreeElement.prototype.ondetach):
(WebInspector.DOMBreakpointTreeElement.prototype.ondelete):
(WebInspector.DOMBreakpointTreeElement.prototype.onenter):
(WebInspector.DOMBreakpointTreeElement.prototype.onspace):
(WebInspector.DOMBreakpointTreeElement.prototype.populateContextMenu):
(WebInspector.DOMBreakpointTreeElement.prototype._statusImageElementClicked):
(WebInspector.DOMBreakpointTreeElement.prototype._statusImageElementFocused):
(WebInspector.DOMBreakpointTreeElement.prototype._statusImageElementMouseDown):
(WebInspector.DOMBreakpointTreeElement.prototype._toggleBreakpoint):
(WebInspector.DOMBreakpointTreeElement.prototype._updateStatus):

• UserInterface/Views/DOMNodeTreeElement.js: Added.

Tree element class for DOM nodes, which serves as a parent for DOM
breakpoint tree elements. Includes context menu for bulk delete/disable
of all child breakpoints.

(WebInspector.DOMNodeTreeElement):
(WebInspector.DOMNodeTreeElement.prototype.ondelete):
(WebInspector.DOMNodeTreeElement.prototype.populateContextMenu):

• UserInterface/Views/DOMTreeContentView.css:

Styles for DOM breakpoint gutter and breakpoint indicators, including
"left pointing" breakpoints for RTL mode.

(.content-view.dom-tree.show-gutter .tree-outline.dom):
(body[dir=ltr] .content-view.dom-tree.show-gutter .tree-outline.dom):
(body[dir=rtl] .content-view.dom-tree.show-gutter .tree-outline.dom):
(.content-view.dom-tree .tree-outline.dom li .status-image):
(body[dir=ltr] .content-view.dom-tree .tree-outline.dom li .status-image):
(body[dir=rtl] .content-view.dom-tree .tree-outline.dom li .status-image):
(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint):
(body:not(.window-inactive) .content-view.dom-tree .tree-outline.dom:focus li.selected .status-image.breakpoint):
(.content-view.dom-tree .tree-outline.dom li .status-image.breakpoint.disabled):
(.content-view.dom-tree .tree-outline.dom.breakpoints-disabled li .status-image.breakpoint):
(.content-view.dom-tree .tree-outline.dom.breakpoints-disabled li .status-image.breakpoint.disabled):

• UserInterface/Views/DOMTreeContentView.js:

Add support for DOM breakpoint gutter and breakpoint indicators.
Breakpoint indicator elements are part of the DOM tree element, and are
updated whenever there a breakpoint's disabled or resolved state changes.

(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.get breakpointGutterEnabled):
(WebInspector.DOMTreeContentView.prototype.set breakpointGutterEnabled):
(WebInspector.DOMTreeContentView.prototype.shown):
(WebInspector.DOMTreeContentView.prototype.closed):
(WebInspector.DOMTreeContentView.prototype._domTreeElementAdded):
(WebInspector.DOMTreeContentView.prototype._domBreakpointAddedOrRemoved):
(WebInspector.DOMTreeContentView.prototype._domBreakpointDisabledStateDidChange):
(WebInspector.DOMTreeContentView.prototype._domBreakpointResolvedStateDidChange):
(WebInspector.DOMTreeContentView.prototype._updateBreakpointStatus):
(WebInspector.DOMTreeContentView.prototype._restoreBreakpointsAfterUpdate):
(WebInspector.DOMTreeContentView.prototype._breakpointsEnabledDidChange):

• UserInterface/Views/DOMTreeElement.js:

Add support for breakpoint status element and content menu.
(WebInspector.DOMTreeElement):
(WebInspector.DOMTreeElement.prototype.get breakpointStatus):
(WebInspector.DOMTreeElement.prototype.set breakpointStatus):
(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
(WebInspector.DOMTreeElement.prototype.updateTitle):
(WebInspector.DOMTreeElement.prototype._updateBreakpointStatus):
(WebInspector.DOMTreeElement.prototype._statusImageContextmenu):

• UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .details-section.dom-breakpoints .item.dom-node .titles):
(.sidebar > .panel.navigation.debugger .details-section.dom-breakpoints .item.dom-node .icon):
Styles for DOM node tree elements.

• UserInterface/Views/DebuggerSidebarPanel.js:

Add new DOM Breakpoints section, and support for the "DOM" pause reason.

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype.closed):
(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
(WebInspector.DebuggerSidebarPanel.prototype._domBreakpointAddedOrRemoved):

• UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
Restore DOM breakpoints once the root node is available.

• UserInterface/Views/Variables.css:

(:root):
Fill and stroke colors for resolved, unresolved, and disabled breakpoints.

• Versions/Inspector-iOS-10.0.json:
• Versions/Inspector-iOS-10.3.json:
• Versions/Inspector-iOS-7.0.json:
• Versions/Inspector-iOS-8.0.json:
• Versions/Inspector-iOS-9.0.json:
• Versions/Inspector-iOS-9.3.json:

LayoutTests:

Tests for pausing on supported DOM breakpoint types, and DOMDebuggerManager
events triggered by added/removed DOM nodes that have breakpoints.

• inspector/dom-debugger/dom-breakpoints-expected.txt: Added.
• inspector/dom-debugger/dom-breakpoints.html: Added.

8:23 PM Changeset in webkit [213625] by commit-queue@webkit.org

• 3 edits in trunk/Tools

import-w3c-tests doesn't work with svn repositories.
​https://bugs.webkit.org/show_bug.cgi?id=169190

Patch by Sam Weinig <​sam@webkit.org> on 2017-03-08
Reviewed by Tim Horton.

The script assumed you had WebKit checked-out as a git repository, but
there was no reason for that.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git.clone):
Add a class method to clone a repository which does not require
an existing checkout.

(Git.fetch):
(Git.checkout):
Add methods needed for test_downloader.py, so it doesn't have to use
the internal _run_git

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.checkout_test_repository):
Switch to using Git.clone(), which doesn't require an existing git
directory, and then also adopt non private methods to fetch/checkout.

8:04 PM Changeset in webkit [213624] by jiewen_tan@apple.com

• 16 edits
  4 copies
  1 move
  12 adds
  1 delete in trunk

[WebCrypto] Implement ECDH DeriveBits operation
​https://bugs.webkit.org/show_bug.cgi?id=169319
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch implements DeriveBits operation of ECDH according to the spec:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations.

Tests: crypto/subtle/derive-bits-malformed-parameters.html

crypto/subtle/ecdh-derive-bits-malformed-parametrs.html
crypto/subtle/ecdh-generate-key-derive-bits.html
crypto/subtle/ecdh-import-key-derive-bits-custom-length.html
crypto/subtle/ecdh-import-key-derive-bits-null-length.html
crypto/workers/subtle/ecdh-import-key-derive-bits.html

• CMakeLists.txt:
• DerivedSources.make:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionDeriveKeyPromise):
(WebCore::jsSubtleCryptoFunctionDeriveBitsPromise):
(WebCore::JSSubtleCrypto::generateKey):
Reorder a bit of the functions.

• crypto/CommonCryptoUtilities.h:
• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::deriveBits):

• crypto/CryptoAlgorithm.h:
• crypto/CryptoAlgorithmParameters.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::deriveBits):

• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/gnutls/CryptoAlgorithmECDHGnuTLS.cpp: Added.

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

• crypto/keys/CryptoKeyEC.h:
• crypto/mac/CryptoAlgorithmECDHMac.cpp: Added.

(WebCore::CryptoAlgorithmECDH::platformDeriveBits):

• crypto/parameters/CryptoAlgorithmEcdhKeyDeriveParams.h: Added.
• crypto/parameters/EcdhKeyDeriveParams.idl: Added.

LayoutTests:

• TestExpectations:

Refine some comments.

• crypto/subtle/derive-bits-malformed-parameters-expected.txt: Renamed from LayoutTests/crypto/subtle/deriveBits-malformed-parameters-expected.txt.
• crypto/subtle/derive-bits-malformed-parameters.html: Added.
• crypto/subtle/deriveBits-malformed-parameters.html: Removed.
• crypto/subtle/ecdh-derive-bits-malformed-parametrs-expected.txt: Added.
• crypto/subtle/ecdh-derive-bits-malformed-parametrs.html: Added.
• crypto/subtle/ecdh-generate-key-derive-bits-expected.txt: Added.
• crypto/subtle/ecdh-generate-key-derive-bits.html: Added.
• crypto/subtle/ecdh-import-key-derive-bits-custom-length-expected.txt: Added.
• crypto/subtle/ecdh-import-key-derive-bits-custom-length.html: Added.
• crypto/subtle/ecdh-import-key-derive-bits-null-length-expected.txt: Added.
• crypto/subtle/ecdh-import-key-derive-bits-null-length.html: Added.
• crypto/workers/subtle/ecdh-import-key-derive-bits-expected.txt: Added.
• crypto/workers/subtle/ecdh-import-key-derive-bits.html: Added.
• crypto/workers/subtle/resources/ecdh-import-key-derive-bits.js: Added.

8:02 PM Changeset in webkit [213623] by wilander@apple.com

• 35 edits
  5 adds in trunk

Resource Load Statistics: Communicate to the network process which domains to partition
​https://bugs.webkit.org/show_bug.cgi?id=169322
<rdar://problem/30768921>

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Now calls ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler()
to tell the network process the domain has got user interaction.

(WebCore::ResourceLoadObserver::logUserInteraction):

Now calls ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler()
to tell the network process the domain has got user interaction.

(WebCore::ResourceLoadObserver::fireShouldPartitionCookiesHandler):

To allow TestRunner to set a domain for which
partitioning should be applied.

(WebCore::ResourceLoadObserver::primaryDomain):

New overloaded convenience function.

• loader/ResourceLoadObserver.h:
• loader/ResourceLoadStatisticsStore.cpp:

(WebCore::ResourceLoadStatisticsStore::readDataFromDecoder):

Now bootstraps the network process' set of known domains to
partition cookies for.

(WebCore::ResourceLoadStatisticsStore::setShouldPartitionCookiesCallback):
(WebCore::ResourceLoadStatisticsStore::fireShouldPartitionCookiesHandler):
(WebCore::ResourceLoadStatisticsStore::hasHadRecentUserInteraction):

Now tells the network process to start partitioning again
when user interaction ages out.

• loader/ResourceLoadStatisticsStore.h:
• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::shouldPartitionCookiesForHost):
(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts):

Source/WebKit2:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):

Now consults WebCore::NetworkStorageSession::shouldPartitionCookiesForHost()
to decide whether partitioning should be applied or not.

• UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerSetCookieStoragePartitioningEnabled):

To allow TestRunner to configure cookie partitioning.

• UIProcess/API/C/WKCookieManager.h:
• UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:

(WKResourceLoadStatisticsManagerFireShouldPartitionCookiesHandler):

To allow TestRunner to set a domain for which
partitioning should be applied.

• UIProcess/API/C/WKResourceLoadStatisticsManager.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::shouldPartitionCookiesForTopPrivatelyOwnedDomains):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Network/NetworkProcessProxy.messages.in:
• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setCookieStoragePartitioningEnabled):

To allow TestRunner to configure cookie partitioning.

• UIProcess/WebCookieManagerProxy.h:
• UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::fireShouldPartitionCookiesHandler):

To allow TestRunner to set a domain for which
partitioning should be applied.

• UIProcess/WebResourceLoadStatisticsManager.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::classifyResource):

Now tells the network process as soon as a domain
has been classified as prevalent.

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):

Overloaded function to allow injection of handlers for communication with the
network process.

• UIProcess/WebResourceLoadStatisticsStore.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::shouldPartitionCookiesForTopPrivatelyOwnedDomains):
(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver):

Now sets two callback handlers for communication with the network process.

• UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

These changes add support for two new TestRunner functions:

• setCookieStoragePartitioningEnabled()
• statisticsFireShouldPartitionCookiesHandler()

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setCookieStoragePartitioningEnabled):
(WTR::TestRunner::statisticsFireShouldPartitionCookiesHandler):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::statisticsFireShouldPartitionCookiesHandler):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/partitioned-cookies-with-and-without-user-interaction.html: Added.
• http/tests/loading/resourceLoadStatistics/resources: Added.
• http/tests/loading/resourceLoadStatistics/resources/get-cookies.php: Added.
• http/tests/loading/resourceLoadStatistics/resources/set-cookie.php: Added.

7:44 PM Changeset in webkit [213622] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: table header columns and cells don't line up, dragging seems backwards
​https://bugs.webkit.org/show_bug.cgi?id=168289

Patch by Devin Rousso <Devin Rousso> on 2017-03-08
Reviewed by Brian Burg.

Changed the algorithm used to position columns when in RTL to use right offsets instead of
left offsets. This also applies to the resizer elements between columns.

• UserInterface/Views/DataGrid.css:

(.data-grid):
(.data-grid th):
(body[dir=ltr] .data-grid :matches(th, td):not(:last-child)):
(body[dir=rtl] .data-grid :matches(th, td):not(:last-child)):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(body[dir=ltr] .data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)):
(body[dir=rtl] .data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)):
(.data-grid .right div):
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child):
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after):
(body[dir=ltr] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after):
(body[dir=rtl] .data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child::after):
(.data-grid th.sort-ascending > div:first-child::after):
(.data-grid th.sort-descending > div:first-child::after):
(.data-grid tr.parent td.disclosure::before):
(body[dir=ltr] .data-grid tr.parent td.disclosure::before):
(body[dir=rtl] .data-grid tr.parent td.disclosure::before):
(.data-grid td .icon):
(body[dir=ltr] .data-grid td .icon):
(body[dir=rtl] .data-grid td .icon):
(.data-grid td .go-to-arrow):
(body[dir=ltr] .data-grid td .go-to-arrow):
(body[dir=rtl] .data-grid td .go-to-arrow):
(.data-grid .resizer):
(body[dir=ltr] .data-grid .resizer):
(body[dir=rtl] .data-grid .resizer):
(.data-grid table:matches(.header, .data)):
(body[dir=ltr] .data-grid table:matches(.header, .data)):
(body[dir=rtl] .data-grid table:matches(.header, .data)):
(body[dir=ltr] .data-grid :matches(th, td):first-child):
(body[dir=rtl] .data-grid :matches(th, td):first-child):
(@media (-webkit-min-device-pixel-ratio: 2)):
(.data-grid :matches(th, td):not(:last-child)): Deleted.
(.data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)): Deleted.
(.data-grid th:matches(.sort-ascending, .sort-descending) > div:first-child): Deleted.
(.data-grid table.header, .data-grid table.data): Deleted.

• UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._positionResizerElements):
(WebInspector.DataGrid.prototype._positionHeaderViews):
(WebInspector.DataGrid.prototype.resizerDragging):

7:35 PM Changeset in webkit [213621] by Joseph Pecoraro

• 30 edits
  9 adds in trunk

Web Inspector: Should be able to see where Resources came from (Memory Cache, Disk Cache)
​https://bugs.webkit.org/show_bug.cgi?id=164892
<rdar://problem/29320562>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/Network.json:

Replace "fromDiskCache" property with "source" property which includes
more complete information about the source of this response (network,
memory cache, disk cache, or unknown).

• inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(_generate_class_for_object_declaration):

• inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator._generate_open_field_names):

• inspector/scripts/codegen/generator.py:

(Generator):
(Generator.open_fields):
To avoid conflicts between the Inspector::Protocol::Network::Response::Source
enum and open accessor string symbol that would have the same name, only generate
a specific list of open accessor strings. This reduces the list of exported
symbols from all properties to just the ones that are needed. This can be
cleaned up later if needed.

• inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result: Added.
• inspector/scripts/tests/generic/type-with-open-parameters.json: Added.

Test for open accessors generation.

Source/WebCore:

Test: http/tests/inspector/network/resource-response-source-disk-cache.html

http/tests/inspector/network/resource-response-source-memory-cache.html
http/tests/inspector/network/resource-response-source-network.html

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setSource): Deleted.

• platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setSource):
Make Source mutable to allow it to be set in const methods.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):
Set the Response source after a successful memory cache validation
as early as possible so that future copies have up to date info.

• inspector/InspectorNetworkAgent.cpp:

(WebCore::responseSource):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorNetworkAgent::markResourceAsCached): Deleted.
Eliminate this "markResourceAsCached" path.
Update Response to include required source parameter instead of
optional fromDiskCache parameter.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::markResourceAsCachedImpl): Deleted.

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::markResourceAsCached): Deleted.

• inspector/InspectorNetworkAgent.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):
Eliminate this "markResourceAsCached" call because the later delegate
messages will include this information.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

New localized strings for memory/disk cache information.

• UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.markResourceRequestAsServedFromMemoryCache):
Make this legacy path more explicit.

(WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
Make this memory cache path more explicit.

(WebInspector.FrameResourceManager.prototype.resourceRequestDidReceiveResponse):
Pass the resource's response source onward.

• UserInterface/Models/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.responseSourceFromPayload):
(WebInspector.Resource.prototype.get responseSource):
(WebInspector.Resource.prototype.hasResponse):
(WebInspector.Resource.prototype.updateForResponse):
(WebInspector.Resource.prototype.markAsCached):
(WebInspector.Resource.prototype.legacyMarkServedFromMemoryCache):
(WebInspector.Resource.prototype.legacyMarkServedFromDiskCache):
Include a WebInspector.ResponseSource enum.
Update a Resource's responseSource state where appropriate.

• UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.requestServedFromCache):
Mark legacy path.

• UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView):

• UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView):
Tweak default column sizes to make Cached and graph columns a little larger.

• UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ResourceTimelineDataGridNode.prototype._cachedCellContent):
Update "Cached" column data with more information if available.

• UserInterface/Views/NetworkGridContentView.css:

(.content-view.network-grid > .data-grid .cache-type):
(.content-view.network-grid > .data-grid:matches(:focus, .force-focus) tr.selected .cache-type):
Style the cache type a secondary color.

LayoutTests:

• http/tests/inspector/network/resource-response-source-disk-cache-expected.txt: Added.
• http/tests/inspector/network/resource-response-source-disk-cache.html: Added.
• http/tests/inspector/network/resource-response-source-memory-cache-expected.txt: Added.
• http/tests/inspector/network/resource-response-source-memory-cache.html: Added.
• http/tests/inspector/network/resource-response-source-network-expected.txt: Added.
• http/tests/inspector/network/resource-response-source-network.html: Added.
• http/tests/inspector/network/resources/cached-script.js: Added.

Test for Network, MemoryCache, and DiskCache loads.

• http/tests/inspector/network/resource-timing-expected.txt:
• http/tests/inspector/network/resource-timing.html:

Fix a typo.

• http/tests/cache/disk-cache/resources/cache-test.js:

(loadResourcesWithOptions):
(loadResources):
Fix typos and style.

• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

Skip disk cache tests where the disk cache is not enabled.

6:40 PM Changeset in webkit [213620] by Michael Catanzaro

• 3 edits in trunk/Source/WebKit2

Fix -Wattributes warning spam
​https://bugs.webkit.org/show_bug.cgi?id=169243

Reviewed by Alexey Proskuryakov.

• Shared/API/c/WKDeclarationSpecifiers.h: Add WK_UNAVAILABLE macro.
• UIProcess/API/C/WKPageGroup.h: Use it.

6:37 PM Changeset in webkit [213619] by Chris Dumez

• 9 edits
  2 deletes in trunk

Drop support for non-standard document.all.tags()
​https://bugs.webkit.org/show_bug.cgi?id=169337

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline web platform test now that one more check is passing.

• web-platform-tests/html/infrastructure/common-dom-interfaces/collections/htmlallcollection-expected.txt:

Source/WebCore:

Drop support for non-standard document.all.tags(). It is not part of the specification:

• ​https://html.spec.whatwg.org/multipage/infrastructure.html#the-htmlallcollection-interface

It is not supported by Firefox and its support was dropped from Chrome back in early 2014:

• ​https://src.chromium.org/viewvc/blink?view=revision&revision=166870

No new tests, updated existing test.

• html/HTMLAllCollection.cpp:
• html/HTMLAllCollection.h:
• html/HTMLAllCollection.idl:

LayoutTests:

Update existing test to check that document.all.tags does not exist.

• fast/dom/document-all-tags-expected.txt:
• fast/dom/document-all-tags.html:

6:16 PM Changeset in webkit [213618] by commit-queue@webkit.org

• 25 edits in trunk

Enable async image decoding for large images
​https://bugs.webkit.org/show_bug.cgi?id=165039

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-03-08
Reviewed by Simon Fraser.

Source/WebCore:

Once FrameView finishes flushing compositing, it will request all its
images, which intersect with the tileCoverageRect (aka the futureRect)
of the TileController, to start asynchronously decoding their image frames.
This should improve the image first time paint and the scrolling scenarios.
It also makes the scrolling more responsive by removing the decoding step
from the main thread.

For now we are going to disable the asynchronous image decoding for the
webkit test runner because drawing the image does not block the page rendering
anymore. An image can be repainted later when its frame is ready for painting.
This can cause a test to fail because the webkit test runner may capture
an image for the page before painting all the images. The asynchronous image
decoding can to be explicitly enabled from the test page. Once the specs
of the image 'async' attribute and 'ready' event is approved, this should
be revisited. It is important to test what we ship and eventually async
image decoding should be enabled in the webkit test runner.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::didAttachRenderers):
(WebCore::HTMLImageElement::willDetachRenderers):
Register/unregister the renderer of the HTMLImageElement for async image decoding
from the RenderView. I followed what HTMLMediaElement to registerForVisibleInViewportCallback().

• html/HTMLImageElement.h:

• page/FrameView.cpp:

(WebCore::FrameView::flushCompositingStateForThisFrame): For all the images inside
the tileCoverageRect of the TileController, request async image decoding.
(WebCore::FrameView::applyRecursivelyWithAbsoluteRect): Request the async image decoding for the
the images inside this FrameView and then recursively do the same thing for all sub FrameViews.
(WebCore::FrameView::requestAsyncDecodingForImagesInAbsoluteRect): Calls the RenderView to
make the request.
(WebCore::FrameView::requestAsyncDecodingForImagesInAbsoluteRectIncludingSubframes): Calls
applyRecursivelyWithAbsoluteRect giving an apply lambda which calls requestAsyncDecodingForImagesInAbsoluteRect.

• page/FrameView.h:

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData): ImageSource::hasDecodingQueue() is renamed to ImageSource::hasAsyncDecodingQueue().
(WebCore::BitmapImage::dataChanged): Use String::utf8().data() instead of String::characters8().
(WebCore::BitmapImage::draw): If drawing the current frame is called while it is being
decoded, draw the the image if the current frame was decoded but for a different size
and and will not invoke decoding while painting. If the frame is being decoded and there
isn't a decoded frame, return without drawing but set a flag that that this image needs
a repaint.
(WebCore::BitmapImage::internalStartAnimation): Use String::utf8().data() instead of String::characters8().
(WebCore::BitmapImage::advanceAnimation): Ditto.
(WebCore::BitmapImage::internalAdvanceAnimation): Ditto.
(WebCore::BitmapImage::newFrameNativeImageAvailableAtIndex): Now this callback can be
called form the ImageFrameCache when finishing a frame of an animated image or the
frame of a large image. For large images, we need to call CachedImage::changedInRect()
if this image needs a repaint. If the decoding queue is idle, we should close it.
(WebCore::BitmapImage::requestAsyncDecoding): This is called form
RenderView::requestAsyncDecodingForImagesInRect().

• platform/graphics/BitmapImage.h:

• platform/graphics/Image.h:

(WebCore::Image::requestAsyncDecoding): Add the default implementation of a virtual function.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::~ImageFrameCache): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageFrameCache::decodingQueue): Change the QNS of the decoding thread to be WorkQueue::QOS::Default.
WorkQueue::QOS::UserInteractive causes the scrolling thread to preempted which can make the scrolling choppy.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Ditto.
(WebCore::ImageFrameCache::isAsyncDecodingQueueIdle): A helper function to tell whether the decoding thread is idle.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().

• platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::hasAsyncDecodingQueue): Rename this function to be consistent with the rest of the functions.
(WebCore::ImageFrameCache::hasDecodingQueue): Deleted.

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::hasAsyncDecodingQueue): hasDecodingQueue() was renamed to hasAsyncDecodingQueue().
(WebCore::ImageSource::isAsyncDecodingQueueIdle): A wrapper for ImageFrameCache::isAsyncDecodingQueueIdle().
(WebCore::ImageSource::hasDecodingQueue): Deleted.

• platform/graphics/TiledBacking.h: Fix a comment. tileGridExtent() is the only one that is used for testing.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement):
(WebCore::RenderElement::intersectsAbsoluteRect): Make this function does what shouldRepaintForImageAnimation()
was doing expect the check for document.activeDOMObjectsAreSuspended().
(WebCore::RenderElement::newImageAnimationFrameAvailable): Replace the call to
shouldRepaintForImageAnimation() by checking document().activeDOMObjectsAreSuspended() then a call to
RenderElement::intersectsAbsoluteRect().
(WebCore::RenderElement::repaintForPausedImageAnimationsIfNeeded): Ditto.
(WebCore::RenderElement::registerForAsyncImageDecodingCallback): Call the RenderView to register the renderer..
(WebCore::RenderElement::unregisterForAsyncImageDecodingCallback): Call the RenderView to unregister the renderer..
(WebCore::shouldRepaintForImageAnimation): Deleted.

• rendering/RenderElement.h:

• rendering/RenderObject.cpp:

(WebCore::RenderObject::setIsRegisteredForAsyncImageDecodingCallback):

• rendering/RenderObject.h:

(WebCore::RenderObject::isRegisteredForAsyncImageDecodingCallback):
(WebCore::RenderObject::RenderObjectRareData::RenderObjectRareData):
Mark/unmark the renderer for being RegisteredForAsyncImageDecodingCallback.

• rendering/RenderReplaced.h: Make intrinsicSize() be a public function.

• rendering/RenderView.cpp:

(WebCore::RenderView::registerForAsyncImageDecodingCallback): Register a renderer for async image decoding.
(WebCore::RenderView::unregisterForAsyncImageDecodingCallback): Remove a renderer from the list of async image decoding.
(WebCore::RenderView::requestAsyncDecodingForImagesInAbsoluteRect):This loops through all the registered RenderImages
inside this RenderView and if any of them intersects with the rectangle, requestAsyncDecoding for it.

• rendering/RenderView.h:

Source/WebKit2:

Add WK2 preferences for setting/getting LargeImageAsyncDecoding and
AnimatedImageAsyncDecoding.

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLargeImageAsyncDecodingEnabled):
(WKPreferencesGetLargeImageAsyncDecodingEnabled):
(WKPreferencesSetAnimatedImageAsyncDecodingEnabled):
(WKPreferencesGetAnimatedImageAsyncDecodingEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

Disable LargeImageAsyncDecoding for DRT/WTR.

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

6:13 PM Changeset in webkit [213617] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: add a "create breakpoint" context menu item for linkified source locations
​https://bugs.webkit.org/show_bug.cgi?id=47442

Patch by Devin Rousso <Devin Rousso> on 2017-03-08
Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

(WebInspector.isShowingResourcesTab): Added.
(WebInspector.linkifyElement):
Now calls WebInspector.appendContextMenuItemsForSourceCode on "contextmenu" events for the
created element.

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.breakpointForSourceCodeLocation):
Returns the first breakpoint (since there should only be one) that matches the given location.

• UserInterface/Views/ContextMenuUtilities.js:

(WebInspector.appendContextMenuItemsForSourceCode):
Rework parameters to also accept a WebInspector.SourceCodeLocation, thereby allowing the
setting of breakpoints so long as the associated WebInspector.SourceCode is a script.

• UserInterface/Views/Main.css:

(.resource-link, .go-to-link):
Prevent link from being selected.

6:06 PM Changeset in webkit [213616] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

Fix missing return value after r213499
​https://bugs.webkit.org/show_bug.cgi?id=168198

Reviewed by Myles C. Maxfield.

• platform/text/CharacterProperties.h:

(WebCore::isEmojiGroupCandidate):

5:47 PM Changeset in webkit [213615] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: Switching back to System Direction doesn't change the dock side
​https://bugs.webkit.org/show_bug.cgi?id=169323

Patch by Devin Rousso <Devin Rousso> on 2017-03-08
Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

(WebInspector.setLayoutDirection):
Change the dock side based on the resolved layout direction, not the current setting value.

5:44 PM Changeset in webkit [213614] by Wenson Hsieh

• 19 edits in trunk/Source

Add TextIndicator support for providing a snapshot excluding selected content
​https://bugs.webkit.org/show_bug.cgi?id=169309
<rdar://problem/30883525>

Reviewed by Tim Horton.

Source/WebCore:

Work towards <rdar://problem/30882974>. Adds support in TextIndicator to include a snapshot of all visible
content, excluding nodes captured in the current selection. This comes in the form of the new
TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection flag -- see per-method changes for more details.

No new tests, since there is no change in behavior yet.

• page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRectWithClip):

• page/FrameSnapshotting.h:

Introduce a new snapshot option flag, SnapshotOptionsPaintEverythingExcludingSelection.

(WebCore::snapshotFrameRectWithClip):

• page/TextIndicator.cpp:

If TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection is turned on, capture and include a
snapshot of the visible bounds of the frame.

(WebCore::takeSnapshot):
(WebCore::takeSnapshots):
(WebCore::initializeIndicator):

• page/TextIndicator.h:

Introduce TextIndicatorOptionIncludeSnapshotOfAllVisibleContentWithoutSelection.

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthOfTextRange):

• platform/graphics/FontCascade.h:

Teach FontCascade to retrieve the width of a range in a TextRun, and also compute the widths of the TextRun
before and after the range. This is used by InlineTextBox to compute the painting rect to clip out when skipping
text decorations for the selected region of the TextRun.

• rendering/InlineTextBox.cpp:

Teach InlineTextBox to respect PaintBehaviorExcludeSelection. When painting text, if this paint behavior is
used, we will not paint the portion of the text run that lies inside the range determined by selectionStartEnd().
Similarly, when painting text decorations, we exclude the rect surrounding the selected content.

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

• rendering/InlineTextBox.h:
• rendering/PaintPhase.h:

Introduce PaintBehaviorExcludeSelection, used to inform members of the render tree not to paint portions that
lie within the current selection range.

• rendering/RenderLayer.cpp:

Propagate the PaintBehaviorExcludeSelection flag to children when painting.

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):

• rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

Teach RenderReplaced to respect PaintBehaviorExcludeSelection by bailing from painting if it is selected and the
paint behavior is enabled.

• rendering/TextDecorationPainter.h:
• rendering/TextPaintStyle.cpp:

(WebCore::computeTextSelectionPaintStyle):

• rendering/TextPaintStyle.h:
• rendering/TextPainter.cpp:

(WebCore::TextPainter::paintText):

• rendering/TextPainter.h:

Source/WebKit2:

Serialize the snapshot excluding the selection and the snapshot's bounds when sending TextIndicatorData over
IPC to the UI process.

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TextIndicatorData>::encode):
(IPC::ArgumentCoder<TextIndicatorData>::decode):

5:35 PM Changeset in webkit [213613] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Support PeerConnectionStates::BundlePolicy::MaxBundle when setting rtc configuration
​https://bugs.webkit.org/show_bug.cgi?id=169389

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-08
Reviewed by Eric Carlson.

Temporary fix to support appr.tc web site.
A future patch should allow to set MaxBundle.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::configurationFromMediaEndpointConfiguration):

5:31 PM Changeset in webkit [213612] by jmarcell@apple.com

• 2 edits in tags/Safari-604.1.9/Source/WebKit2

Merge r213611. rdar://problem/30930190

5:28 PM Changeset in webkit [213611] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

REGRESSION(r213564): Netflix does not play content
​https://bugs.webkit.org/show_bug.cgi?id=169391
<rdar://problem/30930190>

Reviewed by Alex Christensen.

Add the missing IOKit properties identified during testing on Netflix.

• WebProcess/com.apple.WebProcess.sb.in:

5:24 PM Changeset in webkit [213610] by Matt Baker

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r212998): Web Inspector: DetailsSections with options have broken layout
​https://bugs.webkit.org/show_bug.cgi?id=169350

Reviewed by Brian Burg.

• UserInterface/Views/DetailsSection.css:

(.details-section):
Fix negative margin.
(body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow),):
(body[dir=ltr] .details-section > .header::before,):
(body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar),): Deleted.
It looks like :matches doesn't accept compound selectors in its selector list.

4:43 PM Changeset in webkit [213609] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Clean up WebPaymentCoordinatorProxy
​https://bugs.webkit.org/show_bug.cgi?id=169393
Part of rdar://problem/28880714.

Reviewed by Beth Dakin.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(-[WKPaymentAuthorizationViewControllerDelegate paymentAuthorizationViewControllerDidFinish:]):
Move this to where it belongs.

(WebKit::toPKPaymentSummaryItems):
Add a new helper function.

(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingMethodSelection):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):
Use the new helper function.

4:34 PM Changeset in webkit [213608] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

4:30 PM Changeset in webkit [213607] by Chris Dumez

• 8 edits
  2 adds in trunk

Drop select.remove() / options.remove() overloads taking an option element in parameter
​https://bugs.webkit.org/show_bug.cgi?id=169339

Reviewed by Sam Weinig.

Source/WebCore:

Drop select.remove() / options.remove() overloads taking an option element in parameter.
It is non-standard:

• ​https://html.spec.whatwg.org/multipage/forms.html#the-select-element
• ​https://html.spec.whatwg.org/multipage/infrastructure.html#htmloptionscollection

It is not supported by Firefox and was removed from Chrome:

• ​https://bugs.chromium.org/p/chromium/issues/detail?id=345697
• ​https://bugs.chromium.org/p/chromium/issues/detail?id=398627

Chrome UseCounter data shows consistent 0% usage:

• ​https://www.chromestatus.com/metrics/feature/timeline/popularity/398

Test: fast/dom/HTMLSelectElement/remove-option-element.html

• html/HTMLOptionsCollection.cpp:
• html/HTMLOptionsCollection.h:
• html/HTMLOptionsCollection.idl:
• html/HTMLSelectElement.cpp:
• html/HTMLSelectElement.h:
• html/HTMLSelectElement.idl:

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLSelectElement/remove-option-element-expected.txt: Added.
• fast/dom/HTMLSelectElement/remove-option-element.html: Added.

4:30 PM Changeset in webkit [213606] by Chris Dumez

• 12 edits
  2 adds in trunk

Parameter to input.setCustomValidity() should not be nullable
​https://bugs.webkit.org/show_bug.cgi?id=169332

Reviewed by Sam Weinig.

Source/WebCore:

Parameter to input.setCustomValidity() should not be nullable:

• ​https://html.spec.whatwg.org/#htmlinputelement

Firefox and Chrome agree with the specification so the change
should be safe.

Test: fast/forms/setCustomValidity-null-parameter.html

• html/HTMLButtonElement.idl:
• html/HTMLFieldSetElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLKeygenElement.idl:
• html/HTMLObjectElement.idl:
• html/HTMLOutputElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTextAreaElement.idl:

LayoutTests:

• fast/forms/ValidityState-customError-expected.txt:
• fast/forms/ValidityState-customError.html:

Rebaseline now that behavior has changed when passing null or undefined
to setCustomValidity().

• fast/forms/setCustomValidity-null-parameter-expected.txt: Added.
• fast/forms/setCustomValidity-null-parameter.html: Added.

Add layout test coverage.

4:21 PM Changeset in webkit [213605] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Use H264 hardware encoder for Mac libwebrtc
​https://bugs.webkit.org/show_bug.cgi?id=169383

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-08
Reviewed by Alex Christensen.

Switching to H264 hardware encoder if available for Mac.
Adding logs in case hardware encoder cannot be used.

• Configurations/libwebrtc.xcconfig:
• Source/webrtc/sdk/objc/Framework/Classes/h264_video_toolbox_encoder.mm:

(webrtc::H264VideoToolboxEncoder::ResetCompressionSession):
(webrtc::H264VideoToolboxEncoder::ConfigureCompressionSession):

4:12 PM Changeset in webkit [213604] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/airplay-button/airplay-button.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=168409

Unreviewed test gardening.

• TestExpectations:

3:50 PM Changeset in webkit [213603] by Simon Fraser

• 12 edits
  2 adds in trunk

Support transitions/animations of background-position with right/bottom-relative values
​https://bugs.webkit.org/show_bug.cgi?id=162048

Reviewed by Dean Jackson.
Source/WebCore:

Make transitions between "background-position: 10px 20px" and "background-position: right 10px bottom 20px"
work. We do this by by converting "right 10px" to "calc(100% - 10px)" when blending.

Also improve logging of calculated lengths, and better animation logging for FillLayer properties.

Test: transitions/background-position-transitions.html

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::FillLayerAnimationPropertyWrapperBase::FillLayerAnimationPropertyWrapperBase): Keep the propertyID
around so logging can use it.
(WebCore::FillLayerAnimationPropertyWrapperBase::property):
(WebCore::FillLayerPropertyWrapperGetter::FillLayerPropertyWrapperGetter):
(WebCore::FillLayerPropertyWrapperGetter::value):
(WebCore::FillLayerPropertyWrapper::FillLayerPropertyWrapper):
(WebCore::createCalculatedLength):
(WebCore::FillLayerPositionPropertyWrapper::FillLayerPositionPropertyWrapper):
(WebCore::FillLayerRefCountedPropertyWrapper::FillLayerRefCountedPropertyWrapper):
(WebCore::FillLayerStyleImagePropertyWrapper::FillLayerStyleImagePropertyWrapper):
(WebCore::FillLayersPropertyWrapper::FillLayersPropertyWrapper):
(WebCore::CSSPropertyAnimation::blendProperties): Blend then log, so that the logging
can show the result.

• platform/CalculationValue.cpp:

(WebCore::CalcExpressionNumber::dump):
(WebCore::CalcExpressionBinaryOperation::dump):
(WebCore::CalcExpressionLength::dump):
(WebCore::CalcExpressionBlendLength::dump):
(WebCore::operator<<):

• platform/CalculationValue.h:
• platform/Length.cpp:

(WebCore::operator<<):

LayoutTests:

• transitions/background-position-transitions-expected.txt: Added.
• transitions/background-position-transitions.html: Added.
• transitions/resources/transition-test-helpers.js:
• transitions/svg-transitions-expected.txt:

3:31 PM Changeset in webkit [213602] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[Mac][WK2] Whitelist a local cache needed by CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=169388
<rdar://problem/30224000>

Reviewed by Alex Christensen.

Whitelist access to a local cache needed by CFNetwork.

• WebProcess/com.apple.WebProcess.sb.in:

2:56 PM Changeset in webkit [213601] by andersca@apple.com

• 23 edits in trunk/Source

Simplify the PaymentCoordinator interface
​https://bugs.webkit.org/show_bug.cgi?id=169382
Part of rdar://problem/28880714.

Reviewed by Tim Horton.

Source/WebCore:

Add four new structs: PaymentAuthorizationResult, PaymentMethodUpdate, ShippingContactUpdate and ShippingMethodUpdate.
Change the various PaymentCoordinator and PaymentCoordinatorClient functions to take these new objects instead of multiple parameters.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::ApplePaySession::completeShippingMethodSelection):
(WebCore::ApplePaySession::completeShippingContactSelection):
(WebCore::ApplePaySession::completePaymentMethodSelection):
(WebCore::ApplePaySession::completePayment):
(WebCore::ApplePaySession::didSelectShippingMethod):
(WebCore::ApplePaySession::didSelectShippingContact):

• Modules/applepay/PaymentAuthorizationStatus.h:
• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::completeShippingMethodSelection):
(WebCore::PaymentCoordinator::completeShippingContactSelection):
(WebCore::PaymentCoordinator::completePaymentMethodSelection):
(WebCore::PaymentCoordinator::completePaymentSession):

• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.h:
• Modules/applepay/PaymentRequest.h:
• loader/EmptyClients.cpp:

Source/WebKit/mac:

Update for PaymentCoordinatorClient changes.

• WebCoreSupport/WebPaymentCoordinatorClient.h:
• WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::completeShippingMethodSelection):
(WebPaymentCoordinatorClient::completeShippingContactSelection):
(WebPaymentCoordinatorClient::completePaymentMethodSelection):
(WebPaymentCoordinatorClient::completePaymentSession):

Source/WebKit2:

Send the new structs over the wire to the UI process and update the various proxy object to take them instead of
multiple parameters.

• Scripts/webkit/messages.py:

(headers_for_type):

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::PaymentAuthorizationResult>::encode):
(IPC::ArgumentCoder<WebCore::PaymentAuthorizationResult>::decode):
(IPC::ArgumentCoder<WebCore::PaymentError>::encode):
(IPC::ArgumentCoder<WebCore::PaymentError>::decode):
(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::encode):
(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::decode):
(IPC::ArgumentCoder<WebCore::ShippingContactUpdate>::encode):
(IPC::ArgumentCoder<WebCore::ShippingContactUpdate>::decode):
(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::encode):
(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::decode):

• Shared/WebCoreArgumentCoders.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::completeShippingMethodSelection):
(WebKit::WebPaymentCoordinatorProxy::completeShippingContactSelection):
(WebKit::WebPaymentCoordinatorProxy::completePaymentMethodSelection):
(WebKit::WebPaymentCoordinatorProxy::completePaymentSession):
(WebKit::isValidEnum): Deleted.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentSession):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingMethodSelection):
(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):
(WebKit::WebPaymentCoordinatorProxy::platformCompletePaymentMethodSelection):

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::completeShippingMethodSelection):
(WebKit::WebPaymentCoordinator::completeShippingContactSelection):
(WebKit::WebPaymentCoordinator::completePaymentMethodSelection):
(WebKit::WebPaymentCoordinator::completePaymentSession):

• WebProcess/ApplePay/WebPaymentCoordinator.h:

Source/WTF:

• wtf/EnumTraits.h:

Fix a build warning.

2:53 PM Changeset in webkit [213600] by Simon Fraser

• 4 edits
  3 adds in trunk

Change determineNonLayerDescendantsPaintedContent to max out based on renderers traversed
​https://bugs.webkit.org/show_bug.cgi?id=169384

Reviewed by Zalan Bujtas.

Source/WebCore:

determineNonLayerDescendantsPaintedContent() would bail after depth 3, sibling count 20. However,
empirical testing shows that it would run to completion more often if the limit was based on the
number of nodes traversed (in particular, it's common to see fairly deep subtrees with few siblings).
Running to completion has huge memory advantages, because we can then be sure to have checked all the
renderers for smoothed text, allowing us, on some pages, to avoid the extra memory cost of using
layers that support subpixel-antialiased text.

Performance measurement shows that mean runtime of this function goes up from 0.30us to 0.34us
with a 200 renderer limit, which seems worthwhile.

Test: compositing/contents-format/subpixel-antialiased-text-traversal.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

Rebaseline an existing test which changes behavior, and add a new test that generates divs
on both sides of the threshold, in depth and breadth.

• compositing/contents-format/subpixel-antialiased-text-traversal-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-text-traversal.html: Added.
• platform/mac/compositing/contents-format/subpixel-antialiased-text-configs-antialiasing-style-expected.txt:
• platform/mac/compositing/contents-format/subpixel-antialiased-text-traversal-expected.txt: Added.

2:50 PM Changeset in webkit [213599] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

WebAssembly: Make OOB for fast memory do an extra safety check by ensuring the faulting address is in the range we allocated for fast memory
​https://bugs.webkit.org/show_bug.cgi?id=169290

Reviewed by Saam Barati.

This patch adds an extra sanity check by ensuring that the the memory address we faulting trying to load is in range
of some wasm fast memory.

• wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

• wasm/WasmMemory.cpp:

(JSC::Wasm::activeFastMemories):
(JSC::Wasm::viewActiveFastMemories):
(JSC::Wasm::tryGetFastMemory):
(JSC::Wasm::releaseFastMemory):

• wasm/WasmMemory.h:

2:44 PM Changeset in webkit [213598] by commit-queue@webkit.org

• 22 edits
  1 copy
  30 adds in trunk

Support canvas captureStream
​https://bugs.webkit.org/show_bug.cgi?id=169192

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-08
Reviewed by Dean Jackson.

Source/WebCore:

Tests: fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html

fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-exceptions.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html

Adding canvas captureStream as defined in ​https://w3c.github.io/mediacapture-fromelement/#html-canvas-element-media-capture-extensions
This allows creating a video MediaStreamTrack fed by canvas taken frames.
Frames are produced when canvas get changed.

Tests taken from Chromium.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp: Added.

(WebCore::CanvasCaptureMediaStreamTrack::create):
(WebCore::CanvasCaptureMediaStreamTrack::CanvasCaptureMediaStreamTrack):
(WebCore::CanvasCaptureMediaStreamTrack::Source::create):
(WebCore::CanvasCaptureMediaStreamTrack::Source::Source):
(WebCore::CanvasCaptureMediaStreamTrack::Source::startProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::stopProducingData):
(WebCore::CanvasCaptureMediaStreamTrack::Source::requestFrameTimerFired):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasDestroyed):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasResized):
(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):
(WebCore::CanvasCaptureMediaStreamTrack::Source::captureCanvas):
(WebCore::CanvasCaptureMediaStreamTrack::Source::paintCurrentFrameInContext):
(WebCore::CanvasCaptureMediaStreamTrack::Source::currentFrameImage):

• Modules/mediastream/CanvasCaptureMediaStreamTrack.h: Added.

(isType):

• Modules/mediastream/CanvasCaptureMediaStreamTrack.idl: Added.
• Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::isCanvas):

• Modules/mediastream/MediaStreamTrack.idl:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSMediaStreamTrackCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toMediaSample):
(WebCore::HTMLCanvasElement::captureStream):

• html/HTMLCanvasElement.h:
• html/HTMLCanvasElement.idl:
• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::clear):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::markContextChangedAndNotifyCanvasObserver):
(WebCore::WebGLRenderingContextBase::drawArrays):
(WebCore::WebGLRenderingContextBase::drawElements):
(WebCore::WebGLRenderingContextBase::drawArraysInstanced):
(WebCore::WebGLRenderingContextBase::drawElementsInstanced):

• html/canvas/WebGLRenderingContextBase.h:
• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::toBGRAData):

• platform/graphics/ImageBuffer.h:
• platform/graphics/avfoundation/MediaSampleAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::releaseUint8Vector):
(WebCore::MediaSampleAVFObjC::createImageSample):

• platform/graphics/cg/ImageBufferCG.cpp:
• platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::transferData):
(WebCore::ImageBufferData::toBGRAData):

• platform/graphics/cg/ImageBufferDataCG.h:

LayoutTests:

• fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-2d-events.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-capture-out-of-DOM-element.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-clone-track.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-creation-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-creation.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-exceptions-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-exceptions.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-imagebitmaprenderingcontext.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-offscreencanvas.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt: Added.
• fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html: Added.
• fast/mediacapturefromelement/resources/svg-with-image-with-foreignobject.svg: Added.
• fast/mediacapturefromelement/resources/webgl-test.js: Added.

2:14 PM Changeset in webkit [213597] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Use the new code path when dragging web contents
​https://bugs.webkit.org/show_bug.cgi?id=169298

Reviewed by Beth Dakin.

• editing/Editor.h:
• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::writeSelection):
Add a new function that writes the selection to a writer object.

• page/DragController.cpp:

(WebCore::DragController::startDrag):
Use the new writeSelection if mustUseLegacyDragClient is false.

• platform/PasteboardWriterData.cpp:

(WebCore::PasteboardWriterData::WebContent::WebContent):
(WebCore::PasteboardWriterData::WebContent::~WebContent):
(WebCore::PasteboardWriterData::setWebContent):

• platform/PasteboardWriterData.h:

Add getters and setters.

• platform/mac/PasteboardWriter.mm:

(WebCore::toUTIUnlessAlreadyUTI):
Add a helper.

(WebCore::createPasteboardWriter):
Convert web content to pasteboard types.

2:10 PM Changeset in webkit [213596] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/Safari Technology Preview 25

Added a tag for Safari Technology Preview release 25.

1:56 PM Changeset in webkit [213595] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168409

Patch by Antoine Quint <Antoine Quint> on 2017-03-08
Reviewed by Dean Jackson.

Adding more detailed assertions to try to understand where the timeouts might be coming from.

• media/modern-media-controls/airplay-button/airplay-button-expected.txt:
• media/modern-media-controls/airplay-button/airplay-button.html:

1:42 PM Changeset in webkit [213594] by Megan Gardner

• 2 edits in trunk/Source/WebKit/mac

Fix for dependency fix
​https://bugs.webkit.org/show_bug.cgi?id=169369

Reviewed by Beth Dakin.

• WebView/WebViewPrivate.h:

1:11 PM Changeset in webkit [213593] by hyatt@apple.com

• 9 edits
  12 deletes in trunk

CSS Multicolumn should not clip columns horizontally
​https://bugs.webkit.org/show_bug.cgi?id=169363

Reviewed by Sam Weinig.

Source/WebCore:

Revised multiple tests in fast/multicol.

• rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
Stop clipping horizontally. Section 8.1 of the spec changed from "clip" to "don't clip",
so we're changing to match the latest draft. Keep iBooks-based pagination clipping though.

LayoutTests:

• fast/multicol/newmulticol/adjacent-spanners-expected.html:
• fast/multicol/newmulticol/adjacent-spanners.html:
• fast/multicol/newmulticol/clipping-expected.html:
• fast/multicol/newmulticol/clipping.html:
• fast/multicol/newmulticol/spanner-inline-block-expected.html:
• fast/multicol/newmulticol/spanner-inline-block.html:

12:39 PM Changeset in webkit [213592] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

Remove the trace command from the sandbox profile.

• WebProcess/com.apple.WebProcess.sb.in: Unreviewed.

12:36 PM Changeset in webkit [213591] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

REGRESSION(r212904): [WK2][Mac] Revise sandbox to support AES3
​https://bugs.webkit.org/show_bug.cgi?id=169361
<rdar://problem/30927476>

Unreviewed sandbox revert. Avoid web compatibility issue by
restoring access to AES3 Plugin path.

Tests: Existing media tests, on older Mac hardware.

• WebProcess/com.apple.WebProcess.sb.in:

12:01 PM Changeset in webkit [213590] by Simon Fraser

• 42 edits
  7 adds in trunk

Add support for history.scrollRestoration
​https://bugs.webkit.org/show_bug.cgi?id=147782
rdar://problem/22614568

Reviewed by Sam Weinig.
LayoutTests/imported/w3c:

New passing baselines.

• web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-basic-expected.txt:
• web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt:
• web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-cross-origin-expected.txt:
• web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc-expected.txt:

Source/WebCore:

Add support for history.scrollRestoration, per spec:
<​https://html.spec.whatwg.org/multipage/browsers.html#dom-history-scroll-restoration>

This is a new attribute on the History interface. On setting, sets the "shouldRestoreScrollPosition"
state on the current history item, and the getter returns that state. pushState() inherits the
state from the current item.

HistoryController::restoreScrollPositionAndViewState() consults this state, and if set to "manual"
("don't restore) it just uses the current scroll position (we need something to pass to
setPageScaleFactor() so can't just avoid the restoration).

FrameLoader::scrollToFragmentWithParentBoundary() also needs to consult the historyItem
to know if it's OK to scroll to a fragment, on back/forward same-document loads.

Tests: fast/history/history-scroll-restoration-attribute.html

fast/history/history-scroll-restoration.html

• history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::shouldRestoreScrollPosition):
(WebCore::HistoryItem::setShouldRestoreScrollPosition):

• history/HistoryItem.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadInSameDocument):
(WebCore::itemAllowsScrollRestoration):
(WebCore::isSameDocumentReload):
(WebCore::FrameLoader::scrollToFragmentWithParentBoundary):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

• loader/FrameLoader.h:
• loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::goToItem):
(WebCore::HistoryController::pushState):
(WebCore::HistoryController::replaceState):

• page/History.cpp:

(WebCore::History::scrollRestoration):
(WebCore::History::setScrollRestoration):

• page/History.h:
• page/History.idl:

Source/WebKit2:

Need to send shouldRestoreScrollPosition to the UI process in SessionState,
WKWebView now stores _unobscuredCenterToRestore and _scrollOffsetToRestore as
std::optionals, and they will be nullopt if scroll restoration should not happen.

ViewGestureControllerIOS also needs knowledge of whether scroll restoration will
happen, and compares UI-process scroll position vs. the position at snapshot time
to know if the snapshot should be shown (this prevents showing a misleading snapshot
when swiping back on a navigation where scroll restoration is disabled).

• Shared/SessionState.cpp:

(WebKit::FrameState::encode):
(WebKit::FrameState::decode):

• Shared/SessionState.h:
• Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::pageState):

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _processDidExit]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _restorePageScrollPosition:scrollOrigin:previousObscuredInset:scale:]):
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewScrollPosition):

• UIProcess/API/gtk/PageClientImpl.h:
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::viewScrollPosition):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::viewScrollPosition):
(WebKit::PageClientImpl::restorePageState):
(WebKit::PageClientImpl::restorePageCenterAndScale):

• UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::restorePageState):
(WebKit::WebPageProxy::restorePageCenterAndScale):

• UIProcess/mac/PageClientImpl.h:
• UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::viewScrollPosition):

• UIProcess/mac/ViewSnapshotStore.h:

(WebKit::ViewSnapshot::setViewScrollPosition):
(WebKit::ViewSnapshot::viewScrollPosition):

• UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot):

• WebProcess/WebCoreSupport/SessionStateConversion.cpp:

(WebKit::toFrameState):
(WebKit::applyFrameState):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::restorePageState):

LayoutTests:

Sadly history-scroll-restoration.html needs to be cloned for iOS and to use uiController.doAfterPresentationUpdate()
there, since restoration involves a trip to the UI process, and this same test did not work for Mac WK1 (dispatch_async()
doesn't seem to give the right timing in DRT).

• TestExpectations:
• fast/dom/Window/window-appendages-cleared-expected.txt:
• fast/history/history-scroll-restoration-attribute-expected.txt: Added.
• fast/history/history-scroll-restoration-attribute.html: Added.
• fast/history/history-scroll-restoration-expected.txt: Added.
• fast/history/history-scroll-restoration.html: Added.
• platform/ios-simulator-wk2/TestExpectations:
• platform/ios-simulator/TestExpectations:

11:52 AM Changeset in webkit [213589] by Chris Dumez

• 4 edits
  2 adds in trunk

[iOS] Throttle DOM timers to 30fps in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=169213
<rdar://problem/30876965>

Reviewed by Simon Fraser.

Source/WebCore:

Throttle and align DOM timers to ~30fps in low power mode on iOS
to save battery.

Test: fast/dom/timer-throttling-lowPowerMode.html

• page/DOMTimer.h:
• page/Page.cpp:

(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::updateDOMTimerAlignmentInterval):

LayoutTests:

Add layout test coverage.

• fast/dom/timer-throttling-lowPowerMode-expected.txt: Added.
• fast/dom/timer-throttling-lowPowerMode.html: Added.

11:03 AM Changeset in webkit [213588] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Update outdated comment about HTMLElement.dropzone
​https://bugs.webkit.org/show_bug.cgi?id=169338

Reviewed by Sam Weinig.

Update outdated comment about HTMLElement.dropzone since it was dropped
from the HTML specification:

• ​https://github.com/whatwg/html/commit/3044a7e8517a4488cea811789d19974a8d5a56ae

Also add comment about HTMLElement.webkitdropzone since Blink dropped
it in:

• ​https://bugs.chromium.org/p/chromium/issues/detail?id=688943

• html/HTMLElement.idl:

10:55 AM Changeset in webkit [213587] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark editing/selection/move-by-word-visually-multi-space.html as flaky on Sierra Debug WK2.
​https://bugs.webkit.org/show_bug.cgi?id=168346

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

10:48 AM Changeset in webkit [213586] by mrajca@apple.com

• 5 edits in trunk

Add support for updating autoplay policies after a page has been loaded.
​https://bugs.webkit.org/show_bug.cgi?id=169360

Reviewed by Alex Christensen.

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updateWebsitePolicies):

Tools:

• TestWebKitAPI/Tests/WebKit2/autoplay-check.html:
• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

10:48 AM Changeset in webkit [213585] by mrajca@apple.com

• 3 edits in trunk/Source/WebCore

Add support for an autoplay play-pause events quirk.
​https://bugs.webkit.org/show_bug.cgi?id=169235

Reviewed by Jer Noble.

For sites that assume media starts off playing, send a playing and pause event to trigger
custom media controls to update.

• html/HTMLMediaElement.cpp:

(WebCore::needsAutoplayPlayPauseEventsQuirk):
(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):

• html/HTMLMediaElement.h:

10:33 AM Changeset in webkit [213584] by timothy_horton@apple.com

• 13 edits
  2 adds in trunk/Source/WebKit2

Switching focus from a UITextField to an editable WKWebView causes the keyboard to dance
​https://bugs.webkit.org/show_bug.cgi?id=168932
<rdar://problem/30193996>

Reviewed by Beth Dakin.

When WKWebView first becomes first responder from a tap, we don't have
enough information to immediately respond accurately to various questions
from UIKit, because we haven't had time to ask the Web Content process
what is under the touch. Defer updating input views until we get a
response or lose first responder status, so that the keyboard doesn't
start transitioning to its new state until we know what that is.

There is currently no test because TestWebKitAPI has no UIApplication,
and thus cannot generate mock events.

• Platform/spi/ios/UIKitSPI.h:
• WebKit2.xcodeproj/project.pbxproj:
• UIProcess/ios/InputViewUpdateDeferrer.h: Added.
• UIProcess/ios/InputViewUpdateDeferrer.mm: Added.

Add an RAII object that defers input view updates while alive.

• UIProcess/ios/WKContentView.mm:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):
(-[WKContentView _commitPotentialTapFailed]):
(-[WKContentView _didNotHandleTapAsClick:]):
(-[WKContentView _didCompleteSyntheticClick]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _attemptClickAtLocation:]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
Create a InputViewUpdateDeferrer just before we become first responder
from a tap, and destroy it when we get a response (of any kind) or lose
first-responder status (or interaction is torn down).

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didCompleteSyntheticClick):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didCompleteSyntheticClick):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):
Plumb an indication that the synthetic click completed, regardless of
how it was handled.

10:22 AM Changeset in webkit [213583] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.9

Tag Safari-604.1.9.

10:19 AM Changeset in webkit [213582] by Megan Gardner

• 2 edits in trunk/Source/WebKit/mac

Fix Project Dependency
​https://bugs.webkit.org/show_bug.cgi?id=169340

Unreviewed Dependency Fix.

• WebView/WebViewPrivate.h:

10:15 AM Changeset in webkit [213581] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/cache/disk-cache/disk-cache-remove-several-pending-writes.html as flaky on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=169359

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

10:09 AM Changeset in webkit [213580] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/track/media-element-enqueue-event-crash.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169324

Unreviewed test gardening.

• platform/mac/TestExpectations:

10:09 AM Changeset in webkit [213579] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=167589

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

10:09 AM Changeset in webkit [213578] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/play-pause-button/play-pause-button.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=167447

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:50 AM Changeset in webkit [213577] by Jonathan Bedard

• 9 edits in trunk/Tools

Unreviewed, rolling out r213545.

iOS EWS broken by this change

Reverted changeset:

"Standardize device/simulator naming conventions"
​https://bugs.webkit.org/show_bug.cgi?id=169083
​http://trac.webkit.org/changeset/213545

9:44 AM Changeset in webkit [213576] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebKit2

[WK2] Guard GLib-specific code in Module, Connection files with USE(GLIB)
​https://bugs.webkit.org/show_bug.cgi?id=169349

Reviewed by Carlos Garcia Campos.

Use the USE(GLIB) build guards for GLib-specific code in Connection and
Module header files and the ConnectionUnix implementation file, instead
of the PLATFORM(GTK) guard.

• Platform/IPC/Connection.h:
• Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::platformInitialize):
(IPC::Connection::platformInvalidate):
(IPC::Connection::open):
(IPC::Connection::sendOutputMessage):

• Platform/Module.h:

9:43 AM Changeset in webkit [213575] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

MediaPlayerPrivateGStreamerBase::volume() should override the MediaPlayerPrivate method
​https://bugs.webkit.org/show_bug.cgi?id=169347

Reviewed by Carlos Garcia Campos.

Enable the MediaPlayerPrivate::volume() method for the USE(GSTREAMER) configuration
and override it in the MediaPlayerPrivateGStreamerBase class.

• platform/graphics/MediaPlayerPrivate.h:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

9:10 AM Changeset in webkit [213574] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[mac-wk2 Debug] LayoutTest webrtc/libwebrtc/descriptionGetters.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=169317

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-08

• platform/mac-wk2/TestExpectations: Removing failure expectation.
• webrtc/libwebrtc/descriptionGetters.html: Fixing paths.

8:37 AM Changeset in webkit [213573] by Jon Davis

• 2 edits in trunk/PerformanceTests

Fixed ARES-6 animations for other browsers

4:49 AM Changeset in webkit [213572] by eocanha@igalia.com

• 6 edits in trunk/Source/WebCore

[GStreamer][MSE] Actually implement flush() on playback pipeline
​https://bugs.webkit.org/show_bug.cgi?id=169202

Reviewed by Žan Doberšek.

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp: Added GRefPtr support for GstQuery.

(WTF::adoptGRef):
(WTF::refGPtr<GstQuery>):
(WTF::derefGPtr<GstQuery>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h: Ditto.
• platform/graphics/gstreamer/GUniquePtrGStreamer.h: Added GUniquePtr support for GstSegment.
• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::flush): Only actually flush in the non-seek case. For the seek case,
GStreamer seek will already do the flush.

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::addSourceBuffer): Configure appsrc to be time-based instead of bytes-based to ensure
that the segments it produces are time-based.
(WebCore::segmentFixerProbe): This captures the next segment in the stream and "fixes" its base time by setting
it to the start time. This prevent audio/video desynchronizations.
(WebCore::PlaybackPipeline::flush): Really implement flushing by sending flush start/stop events, reconfiguring
appsrc with a new (seamless) segment (so it reconfigures the rest of the elements in that stream), and attached
a segmentFixerProbe to fix the segment emitted by basesrc (appsrc). The current pipeline position is used as
start time used for the new segment. This prevents displaying samples already displayed before flushing, while
allowing the decoder to decode them as a base for future (dependent) p-frame and b-frame samples.

2:34 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

ShareableSurface was renamed to WebCoordinatedSurface (diff)

1:35 AM Changeset in webkit [213571] by timothy_horton@apple.com

• 9 edits in trunk/Source/WebKit2

Remove unused WebPageIOS::zoomToRect and plumbing
​https://bugs.webkit.org/show_bug.cgi?id=169344

Reviewed by Alex Christensen.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::zoomToRect): Deleted.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::zoomToRect): Deleted.

1:15 AM Changeset in webkit [213570] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

UIViewController with WKWebView presented modally causes the presented UIViewController to be dismissed.
​https://bugs.webkit.org/show_bug.cgi?id=165225

Patch by Brad Wright <​bwright2@apple.com> on 2017-03-08
Reviewed by Wenson Hsieh.

The problem happens on an iPhone with a WKWebView inside a view controller presented modally. If the user selects an HTML file input
tag button, a UIDocumentMenuViewController will appear. Anything the user does next causes the entire modal view controller to get dismissed.

To fix this problem, I prevent the UIDocumentMenuViewController from being dismissed by not saving a pointer to it. The UIDocumentMenuViewController
always goes away by itself on any user interaction. Trying to dismiss the UIDocumentMenuViewController when it is already dismissed causes the modal view controller
to be dismissed.

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _cancel]):
(-[WKFileUploadPanel dismiss]):
(-[WKFileUploadPanel _showDocumentPickerMenu]):
(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):
(-[WKFileUploadPanel _presentForCurrentInterfaceIdiom:]): Deleted.

Mar 7, 2017:

11:52 PM Changeset in webkit [213569] by ap@apple.com

• 2 edits in trunk/Source/WebKit2

WebKit should not export dyld install name hints on watchOS and tvOS
​https://bugs.webkit.org/show_bug.cgi?id=169342

Reviewed by Dan Bernstein.

• Shared/API/Cocoa/WebKit.m:

11:32 PM Changeset in webkit [213568] by ap@apple.com

• 2 edits in trunk/Source/WebKit/mac

WebKitLegacy should re-export symbols from WebCore on watchos and tvos
​https://bugs.webkit.org/show_bug.cgi?id=169341
<rdar://problem/30913788>

Reviewed by Dan Bernstein.

• MigrateHeaders.make:

10:06 PM Changeset in webkit [213567] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Remove never-implemented CSS3 text decoration-related properties
​https://bugs.webkit.org/show_bug.cgi?id=169009

Reviewed by Zalan Bujtas.

The following CSS properties were added many years ago based on an old CSS3 Text
draft (​https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
Remove them.

text-line-through
text-line-through-color
text-line-through-mode
text-line-through-style
text-line-through-width
text-overline
text-overline-color
text-overline-mode
text-overline-style
text-overline-width
text-underline
text-underline-color
text-underline-mode
text-underline-style
text-underline-width

• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSProperties.json:
• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isKeywordPropertyID):

9:46 PM Changeset in webkit [213566] by Simon Fraser

• 30 edits in trunk

Have fixedPositionCreatesStackingContext be on by default everywhere
​https://bugs.webkit.org/show_bug.cgi?id=169334

Reviewed by Zalan Bujtas.

It makes no sense to have web-exposed CSS functionality be different based on setting,
and other browser are now aligned with having position:fixed create stacking context.

So remove the fixedPositionCreatesStackingContext setting and have StyleResolver::adjustRenderStyle()
always force stacking context for position:fixed.

Source/WebCore:

• css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

• page/Settings.cpp:
• page/Settings.in:

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

• WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):

LayoutTests:

• compositing/absolute-inside-out-of-view-fixed.html:
• compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html:
• compositing/layer-creation/fixed-overlap-extent-rtl.html:
• compositing/layer-creation/fixed-overlap-extent.html:
• compositing/layer-creation/fixed-position-change-out-of-view-in-view.html:
• compositing/layer-creation/fixed-position-in-view-dynamic.html:
• compositing/layer-creation/fixed-position-out-of-view-dynamic.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-iframe-scroll.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-iframe.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html:
• compositing/layer-creation/fixed-position-out-of-view-scaled.html:
• compositing/layer-creation/fixed-position-transformed-into-view.html:
• compositing/layer-creation/fixed-position-transformed-outside-view.html:
• compositing/layer-creation/no-compositing-for-fixed-position-under-transform.html:
• compositing/repaint/scroll-fixed-layer-no-content.html:
• compositing/repaint/scroll-fixed-layer-out-of-view.html:
• fast/block/positioning/fixed-position-stacking-context2.html:
• fullscreen/full-screen-fixed-pos-parent.html:

9:18 PM Changeset in webkit [213565] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: DOM Tree broken if an element has a "debounce" attribute
​https://bugs.webkit.org/show_bug.cgi?id=169336
<rdar://problem/30899430>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-07
Reviewed by Brian Burg.

• UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getAttribute):
(WebInspector.DOMNode.prototype.removeAttribute.mycallback):
(WebInspector.DOMNode.prototype.removeAttribute):
Convert the attributes map to an actual Map to avoid name collisions
with Object.prototype properties.

8:49 PM Changeset in webkit [213564] by Brent Fulgham

• 5 edits in trunk/Source/WebKit2

[Mac][WK2] Whitelist iokit-get-properties
​https://bugs.webkit.org/show_bug.cgi?id=169331
<rdar://problem/16363632>

Reviewed by Alex Christensen.

Block access to all IOKit properties by default. Turn on only those properties
that are actually needed by our engine.

• DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

7:54 PM Changeset in webkit [213563] by commit-queue@webkit.org

• 17 edits in trunk/Source/WebCore

Asynchronous image decoding should consider the drawing size if it is smaller than the size of the image
​https://bugs.webkit.org/show_bug.cgi?id=168814

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-03-07
Reviewed by Simon Fraser.

If the image destinationRect.size() is smaller than the imageSourceSize
(e.g. 3000x3000 pixels), CGImageSourceCreateThumbnailAtIndex() is slower
than CGImageSourceCreateImageAtIndex() in decoding this image. To overcome
this problem, the entry (kCGImageSourceThumbnailMaxPixelSize,
max(destinationRect.width, destinationRect.height)) is added to the options
dictionary when calling CGImageSourceCreateThumbnailAtIndex(). This will
avoid copying a large block of memory for the unscaled bitmap image.

An argument named 'sizeForDrawing' of type std::optional<IntSize> will be passed
all the way from BitmapImage to ImageDecoder. If bool(sizeForDrawing) equals
true that means we want async image decoding. Otherwise the image will be decoded
synchronously.

The subsamplingLevel argument will be passed as std::optional<SubsamplingLevel>.
to ImageFrame query functions. When combined with sizeForDrawing, the meaning of
these two arguments will be the following:
-- !bool(subsamplingLevel): No caching is required. return what is stored in ImageFrameCache.
-- bool(subsamplingLevel) && !bool(sizeForDrawing): Match subsamplingLevel only. Recache if it's different.
-- bool(subsamplingLevel) && bool(sizeForDrawing): Match both both. . Recache if one of them is different.

We are going to allow decoding the same ImageFrame for different sizeForDrawings.
The rule is a new decoding is allowed only if the maxPixelSize(sizeForDrawing) of
the last requested image decoding is less than the new request sizeForDrawing.

• loader/cache/CachedImage.h: Add a helper function which returns the URL of a CachedImage.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::frameImageAtIndex): Add a new argument for sizeForDrawing.
(WebCore::BitmapImage::nativeImage): Pass an empty sizeForDrawing to frameImageAtIndex(). We an image with the native size.
(WebCore::BitmapImage::nativeImageForCurrentFrame): Ditto.
(WebCore::BitmapImage::nativeImageOfSize): Ditto.
(WebCore::BitmapImage::draw): Pass the destRect.size() to internalStartAnimation().
(WebCore::BitmapImage::isAsyncDecodingRequired): A helper function to answer the question
whether the async image decoding is required. It takes into account the animated images, the
large image, and the image size.
(WebCore::BitmapImage::internalStartAnimation): If async image decoding is requested for this frame m_sizeForDraw
will be set. If internalStartAnimation() is called from startAnimation(), sizeForDraw will be empty. In this
case no async image decoding will be requested. This happens only when startAnimation() is called from outside
BitmapImage::draw().
(WebCore::BitmapImage::advanceAnimation): Change the log message.
(WebCore::BitmapImage::newFrameNativeImageAvailableAtIndex): Ditto.

• platform/graphics/BitmapImage.h:

• platform/graphics/ImageFrame.cpp:

(WebCore::ImageFrame::operator=): Include m_sizeForDraw in the properties of ImageFrame.
(WebCore::maxPixelSize): Returns the maximum of the width() and the height of an IntSize.
(WebCore::ImageFrame::isBeingDecoded): Returns true if the ImageFrame is currently being decoded for a specific sizeForDrawing.
(WebCore::ImageFrame::hasValidNativeImage): Ditto.

• platform/graphics/ImageFrame.h:

(WebCore::ImageFrame::enqueueSizeForDecoding): Adds a new sizeForDrawing; this sets the ImageFrame is being decoded for this sizeForDrawing.
(WebCore::ImageFrame::dequeueSizeForDecoding): Removes the first sizeForDrawing was enqueued; this marks this ImageFrame has finished decoding for this sizeForDrawing.
(WebCore::ImageFrame::clearSizeForDecoding): Clears the sizeForDecoding queue. Marks the ImageFrame for not being decoded.
(WebCore::ImageFrame::isEmpty): Replace Decoding::Empty by Decoding::None.
(WebCore::ImageFrame::sizeForDrawing): Returns the ImageFrame sizeForDraw.
(WebCore::ImageFrame::hasDecodedNativeImage): Returns true if the ImageFrame doesn't need decoding before drawing.
(WebCore::ImageFrame::hasValidNativeImage): Deleted. Moved to the source file.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::setFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::setFrameMetadataAtIndex): When sizeForDraw is set, use the decoder to get the image
frame size. Otherwise, get the size of the nativeImage.
(WebCore::ImageFrameCache::replaceFrameNativeImageAtIndex): Take a new argument for sizeForDraw.
(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Ditto.
(WebCore::ImageFrameCache::startAsyncDecodingQueue): Pass the sizeForDraw as a new property of the ImageFrame.
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Store sizeForDraw in ImageFrameRequest. Delete unneeded check.
This function always receives a valid subsamplingLevel.
(WebCore::ImageFrameCache::stopAsyncDecodingQueue): Marks all the queued ImageFrames for not being decoded.
(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded): Take a new argument for sizeForDraw. If this function fixes the
properties of ImageFrame properties, keep the old sizeForDraw and/or subsamplingLevel. If a new frame is
decoded, no async image decoding will be done in this code path. So pass an empty std::optional<IntSize> to
ImageDecoder::createFrameImageAtIndex() and store std::optional<IntSize> in ImageFrame.
(WebCore::ImageFrameCache::frameMetadataAtIndex): A new helper function which takes a variable number of arguments which
will be passed to the (ImageFrame::*functor).
(WebCore::ImageFrameCache::frameMetadataAtIndexCacheIfNeeded): Make this function takes a variable number of arguments which
will be passed to the frameAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::size): Pass an Metadata, valid SubsamplingLevel and empty sizeForDraw to frameMetadataAtIndexCacheIfNeeded().
(WebCore::ImageFrameCache::sizeRespectingOrientation): Ditto.
(WebCore::ImageFrameCache::singlePixelSolidColor): Pass MetadataAndImage, empty SubsamplingLevel and empty sizeForDraw to
frameMetadataAtIndexCacheIfNeeded(); we can use the current frame image regardless of its size.
(WebCore::ImageFrameCache::frameIsBeingDecodedAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameIsCompleteAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasAlphaAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameHasValidNativeImageAtIndex): Pass subsamplingLevel and sizeForDrawing to frameMetadataAtIndex().
(WebCore::ImageFrameCache::frameHasDecodedNativeImage): New helper function to answer the question whether an ImageFrame will need
decoding when drawing or not.
(WebCore::ImageFrameCache::frameSubsamplingLevelAtIndex): Pass the ImageFrame method as a function argument instead of
passing it as a template argument.
(WebCore::ImageFrameCache::frameSizeAtIndex): Ditto.
(WebCore::ImageFrameCache::frameBytesAtIndex): Ditto.
(WebCore::ImageFrameCache::frameDurationAtIndex): Ditto.
(WebCore::ImageFrameCache::frameOrientationAtIndex):
(WebCore::ImageFrameCache::frameImageAtIndex): Ditto.
(WebCore::ImageFrameCache::frameAtIndex): Deleted. Renamed to frameAtIndexCacheIfNeeded().

• platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::frameAtIndexCacheIfNeeded):

• platform/graphics/ImageObserver.h: Define a virtual function for image sourceUrl().

• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::frameImageAtIndex): Take a new argument for sizeForDrawing.

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::requestFrameAsyncDecodingAtIndex): Take a new argument for sizeForDrawing.
(WebCore::ImageSource::frameHasValidNativeImageAtIndex): Ditto.
(WebCore::ImageSource::frameHasDecodedNativeImage): New helper function.
(WebCore::ImageSource::frameImageAtIndex): Ditto.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions): Create a dictionary with the basic image decoding options.
(WebCore::createImageSourceAsyncOptions): Create a dictionary with the basic asynchronous image decoding options.
(WebCore::appendImageSourceOption): Append the SubsamplingLevel or the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::appendImageSourceOptions): Append the SubsamplingLevel and the MaxPixelSize option to an CGImageSource options dictionary.
(WebCore::imageSourceOptions): Creates a dictionary for the synchronous image decoding options.
(WebCore::imageSourceAsyncOptions): Creates a dictionary for the asynchronous image decoding options.
(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/graphics/cg/ImageDecoderCG.h: Change a prototype.

• platform/graphics/win/ImageDecoderDirect2D.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/graphics/win/ImageDecoderDirect2D.h: Change a prototype.

• platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageDecoder::createFrameImageAtIndex): Replace the DecodingMode argument by an std::optional<IntSize>.

• platform/image-decoders/ImageDecoder.h: Change a prototype.

7:46 PM Changeset in webkit [213562] by commit-queue@webkit.org

• 8 edits in trunk/Tools

Perf and layout test results should report using correct scm revision.
​https://bugs.webkit.org/show_bug.cgi?id=169171

Patch by Kocsen Chung <Kocsen Chung> on 2017-03-07
Reviewed by Ryosuke Niwa.

For accurate record keeping, perf test and layout test results should
report using the native scm revision as an identifier.
To do so we introduce a new scm functions:

native_revision() and timestamp_of_native_revision().

The former is responsible for returning a git hash if scm.git or an
svn revision if scm.svn. The latter is responsible for retrieving the correct timestamp.
We also add the corresponding tests and a helper function _most_recent_log_for_revision.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.run):
Drive-by indentation fix to adhere to WebKit style conventions.
(SCM.svn_revision):
Remove superfluous comment.
(SCM.native_revision):
Add new abstract function native_revision and make it a _subclass_must_implement()
as we want to closely mimic svn_revision() function due to their similar behavior.
(SCM.timestamp_of_native_revision):
Add new abstract function timestamp_of_native_revision to closely mimic timestamp_of_revision.

• Scripts/webkitpy/common/checkout/scm/git.py:

(Git._most_recent_log_for_revision):
New helper function similar to _most_recent_log_matching that is git hash friendly.
(Git.native_revision):
Implement new function native_revision(). Get the native_revision by running:

git log -1 --pretty=format:%H

and thus returning the latest git hash (in long format).
(Git.timestamp_of_native_revision):
Since perftestrunner and layout_test.controllers.manager use the new native_revision
function, we create a new native_revision timestamp retriever.
You will notice this uses a far more simplified way to retrieve UTC strict-ISO timestamp
than its non-native counterpart: timestamp_of_revision().

• Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.native_revision):
Implement native_revision for SVN: simply return self.svn_revision()
(SVN.timestamp_of_native_revision):
Implement timestamp_of_native_revision for SVN: simply return self.timestamp_of_revision()

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_native_revision):
[SVN] Confirm that svn_revision == native_revision. And that native_revision returns 5.
Use '.' as the path parameter instead of svn_checkout_path to avoid violating pylint/E1101
and since we are guaranteed by test setUp to be in the correct SVN dir.
(GitTest.test_native_revision):
[Git] Confirm that git rev-parse HEAD is equal to newly implemented native_revision().
(GitSVNTest.test_native_revision):
[Git] Confirm that git rev-parse HEAD is equal to newly implemented native_revision().
(test_timestamp_of_native_revision):
Test new function timestamp_of_native_revision. Very similar fashion to
test_timestamp_of_revision.

• Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.native_revision):
Add MockSCM.native_revision to behave like svn.py (default).
(MockSCM.test_native_revision):
Add MockSCM.test_native_revision to behave like its non-native counterpart.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.upload_results):
When iterating through a list of projects, make sure we use the project's new native revision.

• Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict):
As per the FIXME in manager.py, we have duplicate code in perftestsrunner.py.
So make the same exact change here.

7:15 PM Changeset in webkit [213561] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
​https://bugs.webkit.org/show_bug.cgi?id=168638

Reviewed by Zalan Bujtas.

Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
which is really just "consume the 'auto' ident or a string", so rename that function.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAutoOrString):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeLocale): Deleted.

6:09 PM Changeset in webkit [213560] by jiewen_tan@apple.com

• 20 edits
  51 adds in trunk

[WebCrypto] Implement ECDH ImportKey/ExportKey operations
​https://bugs.webkit.org/show_bug.cgi?id=169257
<rdar://problem/23789585>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• web-platform-tests/WebCryptoAPI/import_export/ec_importKey.worker-expected.txt:
• web-platform-tests/WebCryptoAPI/import_export/test_ec_importKey-expected.txt:

Source/WebCore:

This patch implements ECDH ImportKey/ExportKey operations according to:
​https://www.w3.org/TR/WebCryptoAPI/#ecdh-operations. Sad that we can't
support SPKI/PKCS8 formats at this moment due to lack of necessary
support in the underlying crypto library. Bug 169318 is tracking the
issue. Also, this patch fixes minor bugs while importing JWK keys for
HMAC/RSA.

Tests: crypto/subtle/ec-export-key-malformed-parameters.html

crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html
crypto/subtle/ec-import-jwk-key-export-jwk-key-public.html
crypto/subtle/ec-import-jwk-key-export-raw-key.html
crypto/subtle/ec-import-key-malformed-parameters.html
crypto/subtle/ec-import-raw-key-export-jwk-key.html
crypto/subtle/ec-import-raw-key-export-raw-key.html
crypto/subtle/ecdh-generate-export-jwk-key-p256.html
crypto/subtle/ecdh-generate-export-jwk-key-p384.html
crypto/subtle/ecdh-generate-export-key-raw-p256.html
crypto/subtle/ecdh-generate-export-key-raw-p384.html
crypto/subtle/ecdh-import-jwk-key-minimum.html
crypto/subtle/ecdh-import-jwk-private-key-p256.html
crypto/subtle/ecdh-import-jwk-private-key-p384.html
crypto/subtle/ecdh-import-jwk-public-key-p256.html
crypto/subtle/ecdh-import-jwk-public-key-p384.html
crypto/subtle/ecdh-import-raw-key-p256.html
crypto/subtle/ecdh-import-raw-key-p384.html
crypto/workers/subtle/ec-generate-export-jwk-key.html
crypto/workers/subtle/ec-generate-export-raw-key.html
crypto/workers/subtle/ec-import-jwk-key-private.html
crypto/workers/subtle/ec-import-jwk-key-public.html
crypto/workers/subtle/ec-import-raw-key.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::supportExportKeyThrow):
Added EC family support.

• crypto/CommonCryptoUtilities.h:

Added needed CommonCrypto SPIs.

• crypto/CryptoAlgorithm.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::importKey):
(WebCore::CryptoAlgorithmECDH::exportKey):

• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/gnutls/CryptoKeyECGnuTLS.cpp:

(WebCore::CryptoKeyEC::keySizeInBits):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformAddFieldElements):
Faked implementations for GTK+.

• crypto/keys/CryptoKeyEC.cpp:

(WebCore::toNamedCurve):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::importRaw):
(WebCore::CryptoKeyEC::importJwk):
(WebCore::CryptoKeyEC::exportJwk):

• crypto/keys/CryptoKeyEC.h:
• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::importJwk):
Fixed a bug.

• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):
Fixed a bug.

• crypto/mac/CryptoKeyECMac.cpp:

(WebCore::doesUncompressedPointMatchNamedCurve):
(WebCore::doesFieldElementMatchNamedCurve):
(WebCore::getKeySizeFromNamedCurve):
(WebCore::CryptoKeyEC::~CryptoKeyEC):
(WebCore::CryptoKeyEC::keySizeInBits):
(WebCore::CryptoKeyEC::exportRaw):
(WebCore::CryptoKeyEC::platformGeneratePair):
(WebCore::CryptoKeyEC::platformImportRaw):
(WebCore::CryptoKeyEC::platformImportJWKPublic):
(WebCore::CryptoKeyEC::platformImportJWKPrivate):
(WebCore::CryptoKeyEC::platformAddFieldElements):

LayoutTests:

• crypto/subtle/ec-export-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/ec-export-key-malformed-parameters.html: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-private-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-private.html: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-public-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-jwk-key-public.html: Added.
• crypto/subtle/ec-import-jwk-key-export-raw-key-expected.txt: Added.
• crypto/subtle/ec-import-jwk-key-export-raw-key.html: Added.
• crypto/subtle/ec-import-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/ec-import-key-malformed-parameters.html: Added.
• crypto/subtle/ec-import-raw-key-export-jwk-key-expected.txt: Added.
• crypto/subtle/ec-import-raw-key-export-jwk-key.html: Added.
• crypto/subtle/ec-import-raw-key-export-raw-key-expected.txt: Added.
• crypto/subtle/ec-import-raw-key-export-raw-key.html: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p256.html: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-jwk-key-p384.html: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p256-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p256.html: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p384-expected.txt: Added.
• crypto/subtle/ecdh-generate-export-key-raw-p384.html: Added.
• crypto/subtle/ecdh-import-jwk-key-minimum-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-key-minimum.html: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p256.html: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-private-key-p384.html: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p256.html: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-jwk-public-key-p384.html: Added.
• crypto/subtle/ecdh-import-raw-key-p256-expected.txt: Added.
• crypto/subtle/ecdh-import-raw-key-p256.html: Added.
• crypto/subtle/ecdh-import-raw-key-p384-expected.txt: Added.
• crypto/subtle/ecdh-import-raw-key-p384.html: Added.
• crypto/subtle/hmac-import-key-malformed-parameters-expected.txt:
• crypto/subtle/hmac-import-key-malformed-parameters.html:
• crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
• crypto/subtle/rsa-import-key-malformed-parameters.html:

Fixed some minor bugs.

• crypto/workers/subtle/ec-generate-export-jwk-key-expected.txt: Added.
• crypto/workers/subtle/ec-generate-export-jwk-key.html: Added.
• crypto/workers/subtle/ec-generate-export-raw-key-expected.txt: Added.
• crypto/workers/subtle/ec-generate-export-raw-key.html: Added.
• crypto/workers/subtle/ec-import-jwk-key-private-expected.txt: Added.
• crypto/workers/subtle/ec-import-jwk-key-private.html: Added.
• crypto/workers/subtle/ec-import-jwk-key-public-expected.txt: Added.
• crypto/workers/subtle/ec-import-jwk-key-public.html: Added.
• crypto/workers/subtle/ec-import-raw-key-expected.txt: Added.
• crypto/workers/subtle/ec-import-raw-key.html: Added.
• crypto/workers/subtle/resources/ec-generate-export-jwk-key.js: Added.
• crypto/workers/subtle/resources/ec-generate-export-raw-key.js: Added.
• crypto/workers/subtle/resources/ec-import-jwk-key-private.js: Added.
• crypto/workers/subtle/resources/ec-import-jwk-key-public.js: Added.
• crypto/workers/subtle/resources/ec-import-raw-key.js: Added.

5:50 PM Changeset in webkit [213559] by Simon Fraser

• 2 edits in trunk/Source/WebKit/mac

Initialize the subpixelAntialiasedLayerTextEnabled Setting in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=169230

Reviewed by Tim Horton.

• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

5:48 PM Changeset in webkit [213558] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WebRTC can be used even if getUserMedia is off
​https://bugs.webkit.org/show_bug.cgi?id=169303

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Alex Christensen.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled): No longer tieing peerConnectionEnabled to
mediaStreamEnabled.

5:43 PM Changeset in webkit [213557] by Simon Fraser

• 4 edits in trunk/Source

Enable SubpixelAntialiasedLayerTextEnabled by default on some versions of macOS
​https://bugs.webkit.org/show_bug.cgi?id=169329

Reviewed by Tim Horton.

If the macOS version is > 101300, enable subpixelAntialiasedLayerTextEnabled.

Source/WebKit/mac:

• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:

5:36 PM Changeset in webkit [213556] by dino@apple.com

• 3 edits in trunk/Source/WebCore

Make platformDevice() not inline, to avoid a
weak external symbol issue on newer compilers/linkers

• platform/graphics/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::platformDevice):

• platform/graphics/gpu/GPUDevice.h:

(WebCore::GPUDevice::platformDevice): Deleted.

5:03 PM Changeset in webkit [213555] by timothy_horton@apple.com

• 2 edits in trunk/Tools

Fix the TestWebKitAPI build

Rubber-stamped by Anders Carlsson.

• TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:

(TestWebKitAPI::TEST_F):
Fix a new warning about default argument promotion and va_start by
making this a enum class.

4:59 PM Changeset in webkit [213554] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Add Debug flag to TestExpectation for webrtc/libwebrtc/descriptionGetters.html.

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:54 PM Changeset in webkit [213553] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark webrtc/libwebrtc/descriptionGetters.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=169317

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:54 PM Changeset in webkit [213552] by commit-queue@webkit.org

• 2 edits in trunk/Source/ThirdParty/libwebrtc

TurnPort::OnSocketConnect is crashing
​https://bugs.webkit.org/show_bug.cgi?id=169284

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Eric Carlson.

• Source/webrtc/p2p/base/turnport.cc: Fixing the assertion.

4:41 PM Changeset in webkit [213551] by Megan Gardner

• 3 edits in trunk/Source/WebKit/mac

Additional DataInteraction Support
​https://bugs.webkit.org/show_bug.cgi?id=169316
<rdar://problem/30884234>

Reviewed by Wenson Hsieh.

Add stub implementations to WebView for methods that handle data interaction

• WebView/WebView.mm:

(-[WebView _enteredDataInteraction:client:global:operation:]):
(-[WebView _updatedDataInteraction:client:global:operation:]):
(-[WebView _exitedDataInteraction:client:global:operation:]):
(-[WebView _performDataInteraction:client:global:operation:]):
(-[WebView _endedDataInteraction:global:]):

• WebView/WebViewPrivate.h:

4:31 PM Changeset in webkit [213550] by Chris Dumez

• 1 edit
  2 adds in trunk/LayoutTests

Add test case to check that MessageEvent.data returns the value it was initialized to
​https://bugs.webkit.org/show_bug.cgi?id=169311

Reviewed by Sam Weinig.

• fast/events/constructors/message-event-constructor-data-identity-expected.txt: Added.
• fast/events/constructors/message-event-constructor-data-identity.html: Added.

4:09 PM Changeset in webkit [213549] by dino@apple.com

• 15 edits in trunk

Some platforms won't be able to create a GPUDevice
​https://bugs.webkit.org/show_bug.cgi?id=169314
<rdar://problems/30907521>

Reviewed by Jon Lee.

Source/JavaScriptCore:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Protect for the case where the hardware doesn't support Metal. And
we might as well disable WebGPU completely in the iOS simulator
for now.

• Configurations/FeatureDefines.xcconfig:
• platform/graphics/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::GPUDevice):

• platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::create):

Source/WebCore/PAL:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Disable WEB_GPU on the iOS Simulator.

• Configurations/FeatureDefines.xcconfig:

Tools:

Protect for the case where the hardware doesn't support Metal.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
• TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:

(TestWebKitAPI::TEST):

3:21 PM Changeset in webkit [213548] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Update ReadMe.md to use directory format for backing up & restoring the database
​https://bugs.webkit.org/show_bug.cgi?id=169263

Reviewed by Joseph Pecoraro.

Update ReadMe.md's instruction to backup and restore the database to use directory format instead of
piping it to gzip. The new command will backup and restore the database with multiple concurrent processes
with a custom compression level.

• ReadMe.md:

3:12 PM Changeset in webkit [213547] by Ryan Haddad

• 6 edits
  1 add in trunk

Correctly check for an empty database file.
<rdar://problem/30542242> Removing Website Data not working (WebSQL directories being left behind)
​https://bugs.webkit.org/show_bug.cgi?id=169256

Patch by Maureen Daum <​mdaum@apple.com> on 2017-03-07
Reviewed by Brady Eidson.

Source/WebCore:

Tests: DatabaseTrackerTest.DeleteDatabaseFileIfEmpty verifies that we actually delete an empty file.

Instead of checking that a database file's size is zero bytes, we should check if it contains
any tables. Once we open an empty database file and set its journal mode to WAL, it will have a
valid SQLite header and therefore will no longer be empty. We can know that the database was empty
if it does not contain any tables.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
Use BEGIN EXCLUSIVE TRANSACTION in order to obtain the exclusive lock. If the database doesn't contain
any tables, it is empty and can be deleted.

Source/WebKit/mac:

Check if the folder for an origin's WebSQL databases is empty after trying to delete
all of its files. Currently we check if the deletedDatabaseFileCount matches the number
of files that were in the folder. However, when we delete the actual database file in
DatabaseTracker::deleteDatabaseFileIfEmpty(), the shm and wal files get deleted along with
the database file, but deletedDatabaseFileCount only gets incremented once.

• Storage/WebDatabaseManager.mm:

(+[WebDatabaseManager removeEmptyDatabaseFiles]):
Delete the folder if it is empty.

Tools:

Add a test for DatabaseTracker::deleteDatabaseFileIfEmpty that verifies
that if we pass in an empty file it actually gets deleted.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp.

• TestWebKitAPI/Tests/WebCore/DatabaseTrackerTest.cpp: Added.

(TestWebKitAPI::TEST):

3:07 PM Changeset in webkit [213546] by commit-queue@webkit.org

• 8 edits in trunk

[URLParser] Fix file URLs that are just ​file:// and a Windows drive letter
​https://bugs.webkit.org/show_bug.cgi?id=169242

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-03-07
Reviewed by Tim Horton.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

This is specified in ​https://url.spec.whatwg.org/#file-host-state and tested by a newly-passing
web platform test. I added the check for the windows drive quirk in the FileHost state of the
parser but I forgot it when FileHost is the terminal state.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

3:05 PM Changeset in webkit [213545] by Jonathan Bedard

• 9 edits in trunk/Tools

Standardize device/simulator naming conventions
​https://bugs.webkit.org/show_bug.cgi?id=169083
<rdar://problem/30810466>

Reviewed by Alexey Proskuryakov.

• Scripts/build-webkit: Document --ios-device and --simulator options.
• Scripts/package-root:

(usage): Ditto.

• Scripts/run-api-tests: Document --simulator option.
• Scripts/webkitdirs.pm:

(argumentsForConfiguration): Use --ios-device by default rather than --device.
(determineXcodeSDK): Parse --ios-device and --simulator options.

• Scripts/webkitpy/common/config/ews.json: Change port name from ios to ios-device.
• Scripts/webkitpy/common/config/ports.py: Ditto.

(DeprecatedPort.port):
(IOSPort): Change port name from ios to ios-device.

• Scripts/webkitpy/port/factory.py:

(platform_options): Add --simulator option.
(PortFactory): Update comment.

• Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort): Change port name from ios to ios-device.
(IOSDevicePort.operating_system): Ditto.

2:53 PM Changeset in webkit [213544] by Brent Fulgham

• 8 edits in trunk/Source/WebKit2

[Mac][iOS][WK2] Whitelist sysctl-read
​https://bugs.webkit.org/show_bug.cgi?id=169306
<rdar://problem/16371458>

Reviewed by Alex Christensen.

Limit access to the 'sysctl' call to read-only cases of the very small
set of operations we actually use.

• DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

2:44 PM Changeset in webkit [213543] by Chris Dumez

• 5 edits in trunk/Source

Drop non-standard MessageEvent.webkitInitMessageEvent()
​https://bugs.webkit.org/show_bug.cgi?id=169295

Reviewed by Joseph Pecoraro.

Source/WebCore:

Drop non-standard MessageEvent.webkitInitMessageEvent().

Chrome dropped it almost 3 years ago. They had UseCounter data showing
consistent 0% usage:

• ​https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y
• ​https://www.chromestatus.com/metrics/feature/timeline/popularity/223
• ​https://src.chromium.org/viewvc/blink?revision=174967&view=revision

• bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent): Deleted.
(WebCore::JSMessageEvent::webkitInitMessageEvent): Deleted.

• dom/MessageEvent.idl:

Source/WebInspectorUI:

Drop MessageEvent.webkitInitMessageEvent and update parameters for various
init*Event() operations to match the current implementation.

• UserInterface/Models/NativeFunctionParameters.js:

2:24 PM Changeset in webkit [213542] by Chris Dumez

• 4 edits
  6 adds in trunk

Label of an <option> element should not be displayed in quirks mode
​https://bugs.webkit.org/show_bug.cgi?id=169296
<rdar://problem/30900751>

Reviewed by Simon Fraser.

Source/WebCore:

Label of an <option> element should not be displayed in quirks mode, to
match Chrome and Firefox. However, we should still display the label in
strict mode, as per the HTML specification:

• ​https://html.spec.whatwg.org/multipage/rendering.html#the-select-element-2

Chrome renders the label in strict mode, same as us. Firefox does not:

• ​https://bugzilla.mozilla.org/show_bug.cgi?id=1345242

Tests: fast/dom/HTMLOptionElement/option-label-quirksmode.html

fast/dom/HTMLOptionElement/option-label-quirksmode2.html
fast/dom/HTMLOptionElement/option-label-strictmode.html

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::displayLabel):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):

• html/HTMLOptionElement.h:

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLOptionElement/option-label-quirksmode-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode2-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-quirksmode2.html: Added.
• fast/dom/HTMLOptionElement/option-label-strictmode-expected.html: Added.
• fast/dom/HTMLOptionElement/option-label-strictmode.html: Added.

2:23 PM Changeset in webkit [213541] by dino@apple.com

• 7 edits
  7 adds in trunk

Add GPUDevice implementation and WebGPULayer
​https://bugs.webkit.org/show_bug.cgi?id=169219
<rdar://problem/30879048>

Reviewed by Sam Weinig.

Source/WebCore:

Add a basic implementation of a GPUDevice object,
which references a MTLDevice. Also add a WebGPULayer
that will ultimately be used to host WebGPU content.

WebKit API Test: WebCore/mac/GPUDevice.mm

• Configurations/WebCore.xcconfig: Link to Metal.

• PlatformMac.cmake: New files.
• WebCore.xcodeproj/project.pbxproj:

• platform/Logging.h: Add a WebGPU logging channel.

• platform/graphics/cocoa/GPUDeviceMetal.mm: Added.

(WebCore::GPUDevice::GPUDevice): Cocoa implementation.
(WebCore::GPUDevice::reshape):

• platform/graphics/cocoa/WebGPULayer.h: Added.
• platform/graphics/cocoa/WebGPULayer.mm: Added.

(-[WebGPULayer initWithGPUDevice:]):
(-[WebGPULayer copyImageSnapshotWithColorSpace:]):
(-[WebGPULayer display]):

• platform/graphics/gpu/GPUDevice.cpp: Added.

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::~GPUDevice):
(WebCore::GPUDevice::GPUDevice): Implementation for platforms
other than Mac and iOS hardware.
(WebCore::GPUDevice::reshape):

• platform/graphics/gpu/GPUDevice.h: Added.

(WebCore::GPUDevice::platformLayer):
(WebCore::GPUDevice::platformDevice):
(WebCore::GPUDevice::layer):

Tools:

Test for WebCore's GPUDevice class.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Added.

(TestWebKitAPI::TEST):

2:22 PM Changeset in webkit [213540] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Log an error to the console when an image fails to load
​https://bugs.webkit.org/show_bug.cgi?id=169292

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Dean Jackson.

In order to help debug flaky tests we now log the image source when an image fails to load.

• Modules/modern-media-controls/controls/icon-button.js:

(IconButton.prototype.handleEvent):
(IconButton.prototype._loadImage):

1:51 PM Changeset in webkit [213539] by jmarcell@apple.com

• 6 edits in tags/Safari-604.1.8.2.1/Source

Versioning.

1:46 PM Changeset in webkit [213538] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.8.2.1

Tag Safari-604.1.8.2.1.

1:26 PM Changeset in webkit [213537] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/seek-backward-support/seek-backward-support.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=165386

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:26 PM Changeset in webkit [213536] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-audio-background.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=169117

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

1:26 PM Changeset in webkit [213535] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Remove Debug flag from flaky test http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html.
​https://bugs.webkit.org/show_bug.cgi?id=162975

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:02 PM Changeset in webkit [213534] by Alan Bujtas

• 3 edits
  2 adds in trunk

Simple line layout: Do not use invalid m_lastNonWhitespaceFragment while removing trailing whitespace.
​https://bugs.webkit.org/show_bug.cgi?id=169288
rdar://problem/30576976

Reviewed by Antti Koivisto.

Source/WebCore:

When the current line has nothing but whitespace, m_lastNonWhitespaceFragment is invalid so
we should not use the start/end values to decide how many characters we need to revert.
This patch makes m_lastNonWhitespaceFragment optional. When it's invalid we just remove
all the runs from the current line since they are all considered whitespace runs.

Test: fast/text/simple-line-layout-line-is-all-whitespace.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::revertAllRunsOnCurrentLine):
(WebCore::SimpleLineLayout::LineState::removeTrailingWhitespace):

LayoutTests:

• fast/text/simple-line-layout-line-is-all-whitespace-expected.txt: Added.
• fast/text/simple-line-layout-line-is-all-whitespace.html: Added.

12:54 PM Changeset in webkit [213533] by achristensen@apple.com

• 25 edits in trunk

[Content Extensions] Rename "Domain" to "Condition" where appropriate
​https://bugs.webkit.org/show_bug.cgi?id=169297

Reviewed by Brady Eidson.

Source/WebCore:

In r184116 I added the ability for a content blocker author to add conditions to the triggers,
if-domain and unless-domain which look at the domain of the main document URL.
I plan to add more conditions soon to run regexes on the entire URL, but to make that patch more
manageable, I took the non-behavior-changing parts and put them in this patch.

No change in behavior except some error messages were made more generic.

• contentextensions/CompiledContentExtension.h:
• contentextensions/ContentExtension.cpp:

(WebCore::ContentExtensions::ContentExtension::ContentExtension):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::populateConditionCacheIfNeeded):
Pass the main document URL instead of just the domain. No change in behavior yet.
(WebCore::ContentExtensions::ContentExtension::cachedConditionedActions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithConditions):
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded): Deleted.
(WebCore::ContentExtensions::ContentExtension::cachedDomainActions): Deleted.
(WebCore::ContentExtensions::ContentExtension::universalActionsWithDomains): Deleted.

• contentextensions/ContentExtension.h:

(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutConditions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutDomains): Deleted.

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::compileRuleList):

• contentextensions/ContentExtensionCompiler.h:
• contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

• contentextensions/ContentExtensionError.h:
• contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getStringList):
Don't pass the error type as a parameter. It's always JSONInvalidConditionList.
(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):

• contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::~Trigger):
(WebCore::ContentExtensions::Trigger::isEmpty):
(WebCore::ContentExtensions::Trigger::operator==):
(WebCore::ContentExtensions::TriggerHash::hash):
Use bitwise xor instead of bitwise or to have fewer hash collisions.
Also, before we were accidentally doing the same hash operation here for IfDomain and UnlessDomain.
This caused unnecessary hash collisions. This is fixed, but should not change any behavior.

• contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):

• contentextensions/DFABytecode.h:

(WebCore::ContentExtensions::instructionSizeWithArguments):

• contentextensions/DFABytecodeCompiler.cpp:

(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):

• contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::matchesCondition):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsMatchingEverything):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithConditions):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::matchesDomain): Deleted.
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithDomains): Deleted.

• contentextensions/DFABytecodeInterpreter.h:
• loader/ResourceLoadInfo.h:

Source/WebKit2:

• Shared/WebCompiledContentExtension.cpp:

(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecode):
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecodeLength):
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecode):
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecodeLength):
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecode):
(WebKit::WebCompiledContentExtension::conditionedFiltersBytecodeLength):
(WebKit::WebCompiledContentExtension::filtersWithoutDomainsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutDomainsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithDomainsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithDomainsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::domainFiltersBytecode): Deleted.
(WebKit::WebCompiledContentExtension::domainFiltersBytecodeLength): Deleted.

• Shared/WebCompiledContentExtension.h:
• Shared/WebCompiledContentExtensionData.cpp:

(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):

• Shared/WebCompiledContentExtensionData.h:

(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):

• UIProcess/API/APIUserContentExtensionStore.cpp:

(API::ContentExtensionMetaData::fileSize):
(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
(API::compiledToFile):
(API::createExtension):
(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):

• UIProcess/API/APIUserContentExtensionStore.h:

Tools:

• TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::InMemoryCompiledContentExtension::create):
(TestWebKitAPI::TEST_F):

12:36 PM Changeset in webkit [213532] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[FreeType] FontPlatformData::fallbacks() returns unprepared FcPatterns
​https://bugs.webkit.org/show_bug.cgi?id=164689

Reviewed by Carlos Garcia Campos.

From the documentation of FcFontSort():

"""The returned FcFontSet references FcPattern structures which may be shared by the
return value from multiple FcFontSort calls, applications must not modify these patterns.
Instead, they should be passed, along with p to FcFontRenderPrepare which combines them into
a complete pattern."""

That means each call to FcFontSort() must be followed up by a call to FcFontRenderPrepare(),
else the patterns will lack information about how to draw the font properly.

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::fallbacks):

12:16 PM Changeset in webkit [213531] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

Flaky Test: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html
​https://bugs.webkit.org/show_bug.cgi?id=169159

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Dean Jackson.

Make this test more defensive to ensure it doesn't fail.

• media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
• media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
• platform/mac/TestExpectations:

12:05 PM Changeset in webkit [213530] by Jonathan Bedard

• 3 edits in trunk/Tools

webkitpy: Refactor setup_test_run for IOSPort and IOSSimulator
​https://bugs.webkit.org/show_bug.cgi?id=169220
<rdar://problem/30879645>

Reviewed by Daniel Bates.

Provide more specific port setup functions for iOS ports to allow more sharing of common code.

• Scripts/webkitpy/port/ios.py:

(IOSPort):
(IOSPort._create_devices): Added.
(IOSPort.setup_test_run): Shared iOS device setup code.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Renamed from setup_test_run.
(IOSSimulatorPort.setup_test_run): Renamed as _create_devices.

11:27 AM Changeset in webkit [213529] by andersca@apple.com

• 2 edits in trunk/Tools

Rewrite the DRT Pasteboard implementation to use UTIs and WTF types
​https://bugs.webkit.org/show_bug.cgi?id=169289

Reviewed by Tim Horton.

• DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[LocalPasteboard initWithName:]):
(-[LocalPasteboard name]):
(-[LocalPasteboard declareTypes:owner:]):
(isUTI):
(toUTI):
(-[LocalPasteboard addTypes:owner:]):
(-[LocalPasteboard changeCount]):
(-[LocalPasteboard types]):
(-[LocalPasteboard availableTypeFromArray:]):
(-[LocalPasteboard setData:forType:]):
(-[LocalPasteboard dataForType:]):
(-[LocalPasteboard writeObjects:]):
(-[LocalPasteboard dealloc]): Deleted.

11:26 AM Changeset in webkit [213528] by mmaxfield@apple.com

• 7 edits
  1 add in trunk

Parsing font descriptors inside @font-face needs to accept ranges
​https://bugs.webkit.org/show_bug.cgi?id=168893

Reviewed by Dean Jackson.

Source/WebCore:

Parse font-weight, font-stretch, and font-style ranges according to
​https://drafts.csswg.org/css-fonts-4/#font-prop-desc. There is one difference, though:
as documented in ​https://github.com/w3c/csswg-drafts/issues/783, slashes are a better
delimiters than hyphens, so this patch implements that instead. I'll update the spec to
include slashes as soon as possible.

Because this patch is all about creating FontSelectionValues from fonts, it doesn't
actually modify the font selection algorithm, and therefore only tests the creation of
these new values. The font selection algorithm itself is already tested elsewhere.

This new work is behind the ENABLE(VARIATION_FONTS) flag.

Test: fast/text/font-selection-font-face-parse.html

• css/CSSFontFace.cpp:

(WebCore::calculateWeightRange):
(WebCore::calculateStretchRange):
(WebCore::calculateItalicRange):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontWeightRange):
(WebCore::consumeFontStretchRange):
(WebCore::consumeFontStyleRange):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::extractVariationBounds):
(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::capabilitiesForFontDescriptor):

LayoutTests:

• fast/text/font-selection-font-face-parse-expected.txt:
• fast/text/font-selection-font-face-parse.html:
• platform/mac-elcapitan/fast/text/font-selection-font-face-parse-expected.txt:

Variations are off on El Capitan, so this platform needs explicit results.

11:21 AM Changeset in webkit [213527] by fpizlo@apple.com

• 2 edits in trunk/PerformanceTests

Revise the ARES-6 explainer text
​https://bugs.webkit.org/show_bug.cgi?id=169287

Reviewed by Saam Barati.

Just did some copy-editing.

• ARES-6/about.html:

11:16 AM Changeset in webkit [213526] by clopez@igalia.com

• 1 edit
  2 moves in trunk/LayoutTests

Move webrtc/descriptionGetters.html to webrtc/libwebrtc/descriptionGetters.html
​https://bugs.webkit.org/show_bug.cgi?id=169216

Unreviewed test gardening.

Move the test webrtc/descriptionGetters.html under the directory webrtc/libwebrtc
because its still not testing the spec, but the current libwebrtc based implementation.

This way the test is skipped on the GTK+ port (The whole directory webrtc/libwebrtc is skipped).

• webrtc/libwebrtc/descriptionGetters-expected.txt: Renamed from LayoutTests/webrtc/descriptionGetters-expected.txt.
• webrtc/libwebrtc/descriptionGetters.html: Renamed from LayoutTests/webrtc/descriptionGetters.html.

10:54 AM Changeset in webkit [213525] by mmaxfield@apple.com

• 2 edits in trunk/Tools

Add David Jonathan Ross to contributors.json
​https://bugs.webkit.org/show_bug.cgi?id=169265

Unreviewed.

David Jonathan Ross very kindly offered to create and contribute his Boxis font in r211060,
which is used for testing font variations.

• Scripts/webkitpy/common/config/contributors.json:

10:37 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Mention that TextureMapperBackingStore is the interface (diff)

10:06 AM Changeset in webkit [213524] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[Mac][WK2] Expand sandbox to support access to audio component registrar
​https://bugs.webkit.org/show_bug.cgi?id=169283
<rdar://problem/30793512>

Reviewed by Alexey Proskuryakov.

• WebProcess/com.apple.WebProcess.sb.in:

9:59 AM Changeset in webkit [213523] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

Animated GIFs fail to play in multi-column layout
​https://bugs.webkit.org/show_bug.cgi?id=167901
<rdar://problem/30382262>

Reviewed by Zalan Bujtas.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):
Make sure to handle the case where we pass in a null repaintContainer and need
to cross a multicolumn flow thread -> region boundary as a result.

9:43 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

GraphicsLayerAnimation was renamed to TextureMapperAnimation (diff)

9:36 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

LayerTreeRenderer was renamed to CoordinatedGraphicsScene (diff)

9:33 AM Changeset in webkit [213522] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

ShadowBlur::calculateLayerBoundingRect doesn't need to return the enclosingIntRect of layerRect
​https://bugs.webkit.org/show_bug.cgi?id=168650

Patch by Fujii Hironori <Fujii Hironori> on 2017-03-07
Reviewed by Simon Fraser.

No new tests, no behavior change.

• platform/graphics/ShadowBlur.h: Change the type of return value

from IntRect to IntSize.

• platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect): Ditto.
(WebCore::ShadowBlur::drawRectShadow): Rename a variable layerRect layerSize.
(WebCore::ShadowBlur::drawInsetShadow): Ditto.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling): Ditto.
(WebCore::ShadowBlur::beginShadowLayer): Ditto.

9:29 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Updated paths of some source files (diff)

9:22 AM Changeset in webkit [213521] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Replace debug assertion with release one in Frame::setView()
​https://bugs.webkit.org/show_bug.cgi?id=169189

Reviewed by Ryosuke Niwa.

Replace debug assertion with release one in Frame::setView() to make make sure the
document does not have a living render tree. This will help identify possible
remaining cases where this can happen.

• dom/Document.cpp:

(WebCore::Document::didBecomeCurrentDocumentInView): Deleted.

• dom/Document.h:
• page/Frame.cpp:

(WebCore::Frame::setView):

9:15 AM Changeset in webkit [213520] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Expose WebRTC current/pending description getters
​https://bugs.webkit.org/show_bug.cgi?id=169216

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Alex Christensen.

Source/WebCore:

Test: webrtc/descriptionGetters.html

Implement pending and current description getters through libwebrtc.
These getters do not yet match the spec as can be seen from the test, which is written to match the implemented behavior.

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::currentLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::currentRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingRemoteDescription):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:

LayoutTests:

• webrtc/descriptionGetters-expected.txt: Added.
• webrtc/descriptionGetters.html: Added.

9:11 AM Changeset in webkit [213519] by Chris Dumez

• 32 edits in trunk/Source

Port DOMTimer from std::chrono::milliseconds to WTF::Seconds type
​https://bugs.webkit.org/show_bug.cgi?id=169236

Reviewed by Simon Fraser.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::minimumDOMTimerInterval):
(WebCore::Document::timerAlignmentInterval):

• dom/Document.h:
• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::adjustMinimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::minimumDOMTimerInterval):
(WebCore::ScriptExecutionContext::timerAlignmentInterval):

• dom/ScriptExecutionContext.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didInstallTimerImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didInstallTimer):

• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didInstallTimer):

• inspector/InspectorTimelineAgent.h:
• inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createTimerInstallData):

• inspector/TimelineRecordFactory.h:
• page/DOMTimer.cpp:

(WebCore::shouldForwardUserGesture):
(WebCore::userGestureTokenToForward):
(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::intervalClampedToMinimum):
(WebCore::DOMTimer::alignedFireTime):

• page/DOMTimer.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):

• page/Page.cpp:

(WebCore::Page::setTimerThrottlingState):
(WebCore::Page::setDOMTimerAlignmentIntervalIncreaseLimit):
(WebCore::Page::updateDOMTimerAlignmentInterval):

• page/Page.h:

(WebCore::Page::domTimerAlignmentInterval):

• page/Settings.cpp:

(WebCore::Settings::setMinimumDOMTimerInterval):

• page/Settings.h:

(WebCore::Settings::minimumDOMTimerInterval):

• page/SuspendableTimer.h:

(WebCore::SuspendableTimer::startRepeating):
(WebCore::SuspendableTimer::startOneShot):
(WebCore::SuspendableTimer::augmentFireInterval):
(WebCore::SuspendableTimer::augmentRepeatInterval):

• platform/Timer.cpp:

(WebCore::TimerBase::setNextFireTime):

• platform/Timer.h:

(WebCore::TimerBase::alignedFireTime):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setMinimumTimerInterval):

• testing/InternalSettings.h:
• testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):

Source/WebKit2:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::updateHiddenPageThrottlingAutoIncreaseLimit):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::setHiddenPageDOMTimerThrottlingIncreaseLimit):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setHiddenPageDOMTimerThrottlingIncreaseLimit):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

9:10 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

USE(UI_SIDE_COMPOSITING) is USE(COORDINATED_GRAPHICS) now (diff)

9:08 AM Changeset in webkit [213518] by commit-queue@webkit.org

• 6 edits in trunk

W3C importer should be able to update the import expectations file
​https://bugs.webkit.org/show_bug.cgi?id=168037

LayoutTests/imported/w3c:

Patch by Youenn Fablet <​youenn@apple.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

• resources/import-expectations.json:

Tools:

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-03-07
Reviewed by Ryosuke Niwa.

Changing import expectations from an array to a map.
Marking all test paths as import and updating import expectations file accordingly.

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.init):
(TestDownloader._init_paths_from_expectations):
(TestDownloader):
(TestDownloader.update_import_expectations):

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.do_import):

• Scripts/webkitpy/w3c/test_importer_unittest.py:

9:03 AM Changeset in webkit [213517] by Chris Dumez

• 20 edits
  1 copy
  2 adds
  2 deletes in trunk

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
​https://bugs.webkit.org/show_bug.cgi?id=169176

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Re-sync web-platform tests from upstream after:

• ​https://github.com/w3c/web-platform-tests/pull/5043
• ​https://github.com/w3c/web-platform-tests/pull/5044

• web-platform-tests/dom/events/CustomEvent-expected.txt:
• web-platform-tests/dom/events/CustomEvent.html:
• web-platform-tests/dom/events/Event-initEvent-expected.txt:
• web-platform-tests/dom/events/Event-initEvent.html:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/html/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces.html:
• web-platform-tests/html/dom/resources/interfaces.idl: Copied from LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces.html.
• web-platform-tests/html/dom/resources/untested-interfaces.idl: Added.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor-expected.txt: Removed.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.html: Removed.
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
• web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html:

Source/WebCore:

Align initEvent / initCustomEvent / initMessageEvent with the latest specification
after:

• ​https://github.com/whatwg/dom/pull/417
• ​https://github.com/whatwg/html/pull/2410

In particular, the following changes were made:

• initEvent: The length property now properly returns 1 instead of 3 as only the first parameter is mandatory. We were already behaving correcting the the length property value was wrong because we forgot to drop a hack from the bindings generator.
• initCustomEvent: Make all parameters except the first optional. Previously, all parameters were mandatory so this is safe.
• initMessageEvent: Drop the custom code and mark the first parameter as mandatory. A side effect of dropping the custom code is that null is no longer considered as valid input for the last parameter. The parameter is of type sequence<> and the new behavior is consistent with the specification and Firefox. If it turns out to break existing content, I'll make the parameter nullable in a follow-up.

No new tests, updated existing tests.

• bindings/js/JSMessageEventCustom.cpp:
• bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):

• dom/CustomEvent.idl:
• dom/MessageEvent.idl:

LayoutTests:

Updated existing tests to reflect behavior change.

• fast/events/init-events-expected.txt:
• fast/events/script-tests/init-events.js:
• fast/eventsource/eventsource-attribute-listeners.html:

9:02 AM Changeset in webkit [213516] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

[GTK][Wayland] Update list of test failing on the Wayland release test bot.

Unreviewed test gardening.

• platform/gtk-wayland/TestExpectations: Update list of test failing on the Wayland release test bot.
• platform/gtk/TestExpectations: media/video-played-collapse.html crashes sometimes.

8:54 AM Changeset in webkit [213515] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Differentiate between pending head and body stylesheets in Style::Scope
​https://bugs.webkit.org/show_bug.cgi?id=169277

Reviewed by Andreas Kling.

Split pending stylesheet node set into separate sets for head and body elements and processing instructions.

This tightens typing and will also be useful later.

• style/StyleScope.cpp:

(WebCore::Style::Scope::~Scope):
(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::removePendingSheet):
(WebCore::Style::Scope::didRemovePendingStylesheet):
(WebCore::Style::Scope::hasPendingSheet):
(WebCore::Style::Scope::hasPendingSheetInBody):
(WebCore::Style::Scope::hasProcessingInstructionWithPendingSheet): Deleted.

• style/StyleScope.h:

(WebCore::Style::Scope::hasPendingSheet): Deleted.
(WebCore::Style::Scope::hasPendingSheets): Deleted.

• style/StyleTreeResolver.cpp:

(WebCore::Style::hasLoadingStylesheet):

Just test for body stylesheets.

(WebCore::Style::TreeResolver::resolve):

Treat all before-body stylesheets uniformly.

8:35 AM CoordinatedGraphicsSystem edited by Konstantin Tokarev

Updated TiledBackingStore and CoordinatedTile description to reflect … (diff)

8:23 AM Changeset in webkit [213514] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[Modern Media Controls] Setting a valid source after an invalid one retains the invalid placard
​https://bugs.webkit.org/show_bug.cgi?id=169280
<rdar://problem/30876078>

Patch by Antoine Quint <Antoine Quint> on 2017-03-07
Reviewed by Jon Lee.

Source/WebCore:

We need to track when a new load start to see if we might have recovered from an error
and hide the "invalid" placard.

Test: media/modern-media-controls/placard-support/placard-support-error-recover.html

• Modules/modern-media-controls/media/placard-support.js:

(PlacardSupport.prototype.get mediaEvents):

LayoutTests:

Add a new test that checks that we know to remove the "invalid" placard if a new source is
set and media starts loading again.

• media/modern-media-controls/placard-support/placard-support-error-recover-expected.txt: Added.
• media/modern-media-controls/placard-support/placard-support-error-recover.html: Added.

6:45 AM Changeset in webkit [213513] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Mark media/video-buffered.html as flaky.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

5:16 AM Changeset in webkit [213512] by Manuel Rego Casasnovas

• 3 edits in trunk/Tools

Add pdr to the rendering watchlist
​https://bugs.webkit.org/show_bug.cgi?id=167298

Patch by Philip Rogers <​pdr@google.com> on 2017-03-07
Reviewed by Andreas Kling.

• Scripts/webkitpy/common/config/contributors.json: Switch to ​pdr+autocc@chromium.org
• Scripts/webkitpy/common/config/watchlist: Add pdr to the rendering watchlist.

5:05 AM Changeset in webkit [213511] by Manuel Rego Casasnovas

• 2 edits in trunk/LayoutTests

[css-grid] Mark a few tests from the W3C suite as pass after r213480
​https://bugs.webkit.org/show_bug.cgi?id=169270

Unreviewed test gardening.

r213480 was porting some Blink patches that makes these tests to pass now.
Check the following bugs for more information:

• ​http://webkit.org/b/169197
• ​http://webkit.org/b/169198

• TestExpectations: Mark grid-minimum-size-grid-items-007.xht and

grid-minimum-size-grid-items-009.xht as passing.
Keep grid-items-sizing-alignment-001.html as failure but now for a different issue
(see ​http://webkit.org/b/169271).

4:46 AM Changeset in webkit [213510] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] ECDH tests from imported/w3c/web-platform-tests/WebCryptoAPI/generateKey fail.

Unreviewed test gardening.

• platform/gtk/TestExpectations:

2:15 AM Changeset in webkit [213509] by mario@webkit.org

• 2 edits in trunk/Tools

Unreviewed. Removed myself from the Accessibility watch list

Patch by Mario Sanchez Prada <​mario@webkit.org> on 2017-03-07

• Scripts/webkitpy/common/config/watchlist: Removed myself.

1:51 AM Changeset in webkit [213508] by aestes@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION (r213412): JPEG premultiplication tests fail under GuardMalloc
​https://bugs.webkit.org/show_bug.cgi?id=169266

Reviewed by Tim Horton.

r213412 added functions to create a CGImageRef from a canvas image buffer, which were used
to create data: URLs and blobs. If JPEG premultiplication is applied, though,
WebCore::cgImage() would return an image with a data provider pointing to stack memory.

I fixed a similar issue in ImageBuffer::toCGImage() by leaking the reference to a
Uint8ClampedArray then creating a CGDataProviderRef with a releaseData function that adopts
the leaked reference.

We could take that approach in cgImage() too by allocating the premultiplied data buffer on
the heap then freeing it with a releaseData function, but it's simpler to refactor
toCGImage()/cgImage() to return an encoded image as a CFDataRef instead of a CFImageRef.
This ensures that a CGDataProviderRef never outlives the data it points to.

Covered by existing tests.

• platform/graphics/ImageBuffer.h: Renamed toCGImage() to toCFData().
• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::dataURL): Changed to take a CFDataRef.
(WebCore::dataVector): Renamed from data(). Changed to take a CFDataRef.
(WebCore::ImageBuffer::toDataURL): Changed to call toCFData().
(WebCore::ImageBuffer::toData): Ditto.
(WebCore::ImageBuffer::toCFData): Changed to return a CFDataRef after encoding the
CGImageRef that was previously returned.
(WebCore::cfData): Ditto.
(WebCore::dataURL): Changed to call cfData().
(WebCore::data): Ditto.
(WebCore::ImageBuffer::toCGImage): Renamed to ImageBuffer::toCFData().
(WebCore::cgImage): Renamed to WebCore::cfData().

12:47 AM Changeset in webkit [213507] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Test fix after r213505
​https://bugs.webkit.org/show_bug.cgi?id=169267

Unreviewed.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):