Timeline

Apr 11, 2017:

11:50 PM Changeset in webkit [215259] by zandobersek@gmail.com

• 21 edits
  2 adds in trunk/Source

[GTK] Use the DisplayRefreshMonitor facilities
​https://bugs.webkit.org/show_bug.cgi?id=170599

Reviewed by Carlos Garcia Campos.

Source/WebCore:

• CMakeLists.txt: Add missing files to the build.
• platform/graphics/DisplayRefreshMonitor.cpp: Build fixes.

(WebCore::DisplayRefreshMonitor::createDefaultDisplayRefreshMonitor):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer): Mark the
platform layer as updated in the layer's CoordinatedGraphicsState.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

Source/WebKit2:

ThreadedCompositor gains a DisplayRefreshMonitor member that it can use
to better coordinate display refresh callbacks on the main thread. Still,
because currently the GTK+ port doesn't have a reliable way of notifying
the ThreadedCompositor of a vsync event, a timer targeting 60FPS is used
in order to keep the updates at a reasonable rate. When the timer is fired,
the ThreadedCompositor decides how to proceed based on state changes that
might have occurred during composition or whether there's any display
refresh callbacks that require handling on the main thread.

CompositingRunLoop now stores its state in an atomic variable that's then
inspected whenever a new update is scheduled or completed. When scheduled,
if there's no update in progress, a new update is requested through the
timer. If there's already an update in progress, a new update is marked
as pending after the current one completes. In that case, when the update
is completed, a new update is requested through the timer.

ThreadedDisplayRefreshMonitor is used to coordinate updates between the
main and the composition thread whenever the CoordinatedGraphics state
demands it, or whenever there are clients registered to that monitor that
require an update (e.g. a requestAnimationFrame() callback). After the
update on the composition thread is finished, and the DisplayRefreshMonitor
object requires an update, a callback at the same priority as the layer
flush timer is scheduled on the main thread. In that callback we handle
any clients registered for this DisplayRefreshMonitor before proceeding
to handle any changes to the CoordinatedGraphics scene. In case the
DisplayRefreshMonitor clients or the layer flushes already queued up
any changes to the state, we immediately ask the ThreadedCompositor for
an update.

• PlatformGTK.cmake:
• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::updateViewport):
(WebKit::CoordinatedGraphicsScene::commitSceneState):

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::isActive):
(WebKit::CompositingRunLoop::scheduleUpdate):
(WebKit::CompositingRunLoop::stopUpdates):
(WebKit::CompositingRunLoop::updateCompleted):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::CompositingRunLoop::isCurrent):
(WebKit::CompositingRunLoop::startUpdateTimer): Deleted.
(WebKit::CompositingRunLoop::stopUpdateTimer): Deleted.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

(): Deleted.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::invalidate):
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing):
(WebKit::ThreadedCompositor::updateViewport):
(WebKit::ThreadedCompositor::scheduleDisplayImmediately):
(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::displayRefreshMonitor):
(WebKit::ThreadedCompositor::renderNextFrameIfNeeded):
(WebKit::ThreadedCompositor::completeCoordinatedUpdateIfNeeded):
(WebKit::ThreadedCompositor::coordinateUpdateCompletionWithClient):
(WebKit::ThreadedCompositor::performFrameCompletion):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp: Added.

(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::requiresDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::dispatchDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::invalidate):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::createDisplayRefreshMonitor):

• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::createDisplayRefreshMonitor):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
• WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::createDisplayRefreshMonitor):

Source/WTF:

• wtf/Platform.h: Enable USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for the GTK+ port.
• wtf/glib/RunLoopSourcePriority.h: Add the DisplayRefreshMonitorTimer entry that

matches the value of LayerFlushTimer.

11:12 PM Changeset in webkit [215258] by jmarcell@apple.com

• 5 edits in branches/safari-603-branch

Cherry-pick 214358. rdar://problem/31502340

9:37 PM Changeset in webkit [215257] by rniwa@webkit.org

• 3 edits
  1 add in trunk/Websites/perf.webkit.org

Retrying an A/B testing does not set the repetition count in some cases
​https://bugs.webkit.org/show_bug.cgi?id=170695

Reviewed by Joseph Pecoraro.

When selecting an existing A/B test group, the analysis task page automatically sets the repetition count
of its retry to be that of the original test group. However, this information wasn't being passed correctly
to the code that actually created a test group. As a result, the retried test group's repetition count does
not match that of the original group or the number shown to the user on UI.

Fixed the bug by updating this._repetitionCount in setRepetitionCount.

• browser-tests/index.html:
• browser-tests/test-group-form-tests.js: Added. Added tests.

(.createTestGroupFormWithContext): Added.

• public/v3/components/test-group-form.js:

(TestGroupForm.prototype.setRepetitionCount):
(TestGroupForm.formContent):
(TestGroupForm):

8:05 PM Changeset in webkit [215256] by Matt Baker

• 5 edits
  4 adds in trunk/Source/WebInspectorUI

Web Inspector: checkboxes in Settings screen use inappropriate layout
​https://bugs.webkit.org/show_bug.cgi?id=166993
<rdar://problem/30002272>

Reviewed by Devin Rousso.

• Localizations/en.lproj/localizedStrings.js:

New checkbox setting strings.

• UserInterface/Main.html:

New settings view classes.

• UserInterface/Views/GeneralSettingsView.js: Added.

(WebInspector.GeneralSettingsView):
(WebInspector.GeneralSettingsView.prototype.initialLayout):
Move settings UI creation from SettingsTabContentView.

• UserInterface/Views/SettingEditor.js: Added.

Basic setting editor UI for the following input types: checkbox,
number, and select. In the future it may be useful to include
additional types, such as radio buttons.

(WebInspector.SettingEditor):
(WebInspector.SettingEditor.createForSetting):
(WebInspector.SettingEditor.prototype.get element):
(WebInspector.SettingEditor.prototype.get type):
(WebInspector.SettingEditor.prototype.get label):
(WebInspector.SettingEditor.prototype.get value):
(WebInspector.SettingEditor.prototype.set value):
(WebInspector.SettingEditor.prototype._createEditorElement):

• UserInterface/Views/SettingsGroup.js: Added.

A container holding editors for one or more WebInspector.Settings.
Every editor belongs to a group. SettingsView provides convenience
methods for adding settings and groups, so create instances directly
shouldn't normally be necessary.

(WebInspector.SettingsGroup):
(WebInspector.SettingsGroup.prototype.get element):
(WebInspector.SettingsGroup.prototype.addSetting):
(WebInspector.SettingsGroup.prototype.addCustomSetting):

• UserInterface/Views/SettingsTabContentView.css:

Refactored styles to more closely match Xcode settings UI.
Eliminated redundant use of "setting" from CSS class names.

(.content-view.settings):
(.content-view.settings .navigation-bar .item.radio.button.text-only):
(.content-view.settings .navigation-bar .item.radio.button.text-only.selected):
(.content-view.settings > .settings-view > .separator):
(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .title):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .title):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .title):
(.content-view.settings > .settings-view > .container > .editor-group):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(.content-view.settings > .settings-view > .container > .editor-group > .editor select):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="number"]):
(.content-view.settings > .header): Deleted.
(.content-view.settings > .separator): Deleted.
(.content-view.settings > .setting-container): Deleted.
(.content-view.settings > .setting-container.combined): Deleted.
(.content-view.settings > .setting-container > .setting-name): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-name): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-name): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="checkbox"]): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller select): Deleted.
(.content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.
(body[dir=ltr] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.
(body[dir=rtl] .content-view.settings > .setting-container > .setting-value-controller input[type="number"]): Deleted.

• UserInterface/Views/SettingsTabContentView.js:

To better organize the growing number of settings, multiple settings views
are now supported, with a navigation bar for switching between them. For
now there is a single "General" setting view, and and the navigation bar
is hidden. Adding a second view will cause the bar to be shown.

(WebInspector.SettingsTabContentView):
(WebInspector.SettingsTabContentView.prototype.get type):
(WebInspector.SettingsTabContentView.prototype.get selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.addSettingsView):
(WebInspector.SettingsTabContentView.prototype._navigationItemSelected):
(WebInspector.SettingsTabContentView.prototype.layout): Deleted.
No longer needed.

• UserInterface/Views/SettingsView.js: Added.

Base class for displaying editing UI for a collection of related
WebInspector.Setting objects.

(WebInspector.SettingsView):
(WebInspector.SettingsView.prototype.get identifier):
(WebInspector.SettingsView.prototype.get displayName):
A string suitable for display in a NavigationBar showing a list of
SettingsViews (e.g. "General", "Text Editing", "Fonts & Colors", etc).

(WebInspector.SettingsView.prototype.addSetting):
Add UI for a setting, consisting of a title, an editor appropriate for
the setting's value type, and optional label and formatting options.
For example:

addSetting("Setting 1:", new WebInspector.Setting(…, true), "Item one")
addSetting("Setting 2:", new WebInspector.Setting(…, 1), "units")

will create a checkbox and number input field:

Setting 1: [x] Item one
Setting 2: [ 1] units

(WebInspector.SettingsView.prototype.addCustomSetting):
Add UI for a specific editor type, with optional formatting options.
A setting can be updated in response to changes in the editor's value.

(WebInspector.SettingsView.prototype.addGroup):
Add a group, for listing multiple settings under one title. For example:

group = addGroup("Title:")
group.addSetting(new WebInspector.Setting(…, true), "Item one")
group.addSetting(new WebInspector.Setting(…, false), "Item two")

will create two checkboxes under the same title:

Title: [x] Item one

[ ] Item two

(WebInspector.SettingsView.prototype.addSeparator):
Add vertical space between two settings or groups.

4:24 PM Changeset in webkit [215255] by achristensen@apple.com

• 14 edits in trunk/Source/WebKit2

Modernize and clean up code
​https://bugs.webkit.org/show_bug.cgi?id=170752

Reviewed by Sam Weinig.

• NetworkProcess/NetworkResourceLoader.h:
• Shared/WebPreferencesStore.h:
• UIProcess/API/APIHitTestResult.cpp:

(API::HitTestResult::create):

• UIProcess/API/APIHitTestResult.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesCreate):
(WKPreferencesCreateWithIdentifier):
(WKPreferencesCreateCopy):

• UIProcess/Authentication/AuthenticationChallengeProxy.h:
• UIProcess/WebPreferences.cpp:

(WebKit::WebPreferences::createWithLegacyDefaults):
(WebKit::WebPreferences::copy):

• UIProcess/WebPreferences.h:
• WebProcess/Network/WebLoaderStrategy.h:
• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::requestCheckingOfString):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addTextCheckingRequest):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::computeExpandAndShrinkThresholdsForHandle):
(WebKit::WebPage::changeBlockSelection):
(WebKit::WebPage::rangeForGranularityAtPoint):
(WebKit::WebPage::computePagesForPrintingAndDrawToPDF):

4:03 PM Changeset in webkit [215254] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Allow modern-media-controls to be provided through WebKitAdditions
​https://bugs.webkit.org/show_bug.cgi?id=170722
<rdar://problem/31553089>

Patch by Antoine Quint <Antoine Quint> on 2017-04-11
Reviewed by Dean Jackson.

If modern media controls source files are provided through WebKitAdditions, use these instead
of the sources found in the WebCore module.

• WebCore.xcodeproj/project.pbxproj:

3:48 PM Changeset in webkit [215253] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

LayoutTest webrtc/video-mute.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=170704

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

• webrtc/video-mute.html: Trying to make it less flaky.

3:47 PM Changeset in webkit [215252] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/LayoutTests

[WK1] Add captureStream test with webrtc
​https://bugs.webkit.org/show_bug.cgi?id=170746

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

• platform/mac-wk1/TestExpectations: Activating this new test in WK1.
• webrtc/captureCanvas-webrtc-expected.txt: Added.
• webrtc/captureCanvas-webrtc.html: Added.

3:47 PM Changeset in webkit [215251] by commit-queue@webkit.org

• 14 edits in trunk/LayoutTests

Migrating webrtc tests to latest API
​https://bugs.webkit.org/show_bug.cgi?id=170709

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

• webrtc/audio-peer-connection-webaudio.html:
• webrtc/libwebrtc/descriptionGetters.html:
• webrtc/negotiatedneeded-event-addStream.html:
• webrtc/peer-connection-audio-mute.html:
• webrtc/peer-connection-audio-mute2.html:
• webrtc/peer-connection-remote-audio-mute.html:
• webrtc/peer-connection-remote-audio-mute2.html:
• webrtc/release-after-getting-track.html:
• webrtc/video-disabled-black.html:
• webrtc/video-mute.html:
• webrtc/video-remote-mute.html:
• webrtc/video-with-receiver.html:
• webrtc/video.html:

2:30 PM Changeset in webkit [215250] by dino@apple.com

• 12 edits in trunk

Disable outdated WritableStream API
​https://bugs.webkit.org/show_bug.cgi?id=170749
<rdar://problem/31446233>

Reviewed by Tim Horton.

The API we implement is no longer accurate. Disable it until we
are compatible with the new specification

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

1:39 PM Changeset in webkit [215249] by mrajca@apple.com

• 4 edits in trunk

Consider the current document when allowing autoplay quirks.
​https://bugs.webkit.org/show_bug.cgi?id=170744

Reviewed by Eric Carlson.

Added API test.

In addition to checking if the top-level document supports autoplay quirks, we should check
if the current document supports quirks. This allows all embedded YouTube videos (which use
iframes) to play correctly if the client allows autoplay quirks on youtube.com.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::dispatchPlayPauseEventsIfNeedsQuirks):

12:51 PM Changeset in webkit [215248] by Ryan Haddad

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r215245.

This change broke internal builds.

Reverted changeset:

"[Modern Media Controls] Allow modern-media-controls to be
provided through WebKitAdditions"
​https://bugs.webkit.org/show_bug.cgi?id=170722
​http://trac.webkit.org/changeset/215245

12:13 PM Changeset in webkit [215247] by mitz@apple.com

• 8 edits
  3 adds
  1 delete in trunk

[Cocoa] WebKit unnecessarily soft-links CorePrediction
​https://bugs.webkit.org/show_bug.cgi?id=170644

Reviewed by Sam Weinig.

Source/WebKit2:

• Configurations/BaseTarget.xcconfig: Defined HAVE_CORE_PREDICTION and added HAVE_CORE_PREDICTION to the preprocessor defintions when the former is YES.

• Configurations/WebKit.xcconfig: Have the linker link against CorePrediction where available. On macOS, use weak linking, because CorePrediction is not available in the Base System.

• Platform/classifier/cocoa/CorePredictionSoftLink.h: Removed.

• Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp: Guarded with #if HAVE(CORE_PREDICTION).

(WebKit::isNullFunctionPointer): Added this helper.
(WebKit::ResourceLoadStatisticsClassifierCocoa::canUseCorePrediction): Replaced

dlopen()-based runtime check with a null check.

• Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.h: Guarded with #if HAVE(CORE_PREDICTION).

• Platform/spi/Cocoa/CorePredictionSPI.h: Added.

• UIProcess/WebResourceLoadStatisticsStore.h: Updated guards to include HAVE(CORE_PREDICTION).

• WebKit2.xcodeproj/project.pbxproj: pdated file references for removal and addition.

WebKitLibraries:

• WebKitPrivateFrameworkStubs/iOS/10/CorePrediction.framework: Added this framework stub.
• WebKitPrivateFrameworkStubs/iOS/10/CorePrediction.framework/CorePrediction.tbd: Added.

11:43 AM Changeset in webkit [215246] by commit-queue@webkit.org

• 11 edits
  3 copies
  3 adds in trunk

Add SPI for handling geolocation authorization requests
​https://bugs.webkit.org/show_bug.cgi?id=170362
rdar://problem/17508627

Patch by David Quesada <​david_quesada@apple.com> on 2017-04-11
Reviewed by Alex Christensen.

Source/WebKit2:

Add a new WKUIDelegate method for the WKGeolocationProviderIOS to call when a web page
requests geolocation access. To support testing this change, make it possible to override
the CoreLocation abstraction WKGeolocationProviderIOS uses. There is now a configurable
object on the process pool that implements a protocol for providing location updates for
web views in the process pool. If the client doesn't provide this object,
WKGeolocationProviderIOS falls back to an object that wraps the existing WebKit1
WebGeolocationCoreLocationProvider and conforms to the new protocol.

• Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

• Shared/WebGeolocationPosition.h:

(WebKit::WebGeolocationPosition::create):

• UIProcess/API/C/WKGeolocationPosition.cpp:

(WKGeolocationPositionCreate_b):

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _coreLocationProvider]):
(-[WKProcessPool _setCoreLocationProvider:]):

• UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/API/Cocoa/_WKGeolocationCoreLocationProvider.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.
• UIProcess/API/Cocoa/_WKGeolocationPosition.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.
• UIProcess/API/Cocoa/_WKGeolocationPosition.mm: Added.

(WebKit::if):
(-[_WKGeolocationPosition dealloc]):
(-[_WKGeolocationPosition _apiObject]):

• UIProcess/API/Cocoa/_WKGeolocationPositionInternal.h: Copied from Source/WebKit2/UIProcess/API/C/WKGeolocationPosition.cpp.

(WebKit::wrapper):

• UIProcess/ios/WKGeolocationProviderIOS.mm:

(kit):
(-[WKGeolocationProviderIOS initWithProcessPool:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS positionChanged:]):
(-[WKLegacyCoreLocationProvider setListener:]):
(-[WKLegacyCoreLocationProvider requestGeolocationAuthorization]):
(-[WKLegacyCoreLocationProvider start]):
(-[WKLegacyCoreLocationProvider stop]):
(-[WKLegacyCoreLocationProvider setEnableHighAccuracy:]):
(-[WKLegacyCoreLocationProvider geolocationAuthorizationGranted]):
(-[WKLegacyCoreLocationProvider geolocationAuthorizationDenied]):
(-[WKLegacyCoreLocationProvider positionChanged:]):
(-[WKLegacyCoreLocationProvider errorOccurred:]):
(-[WKLegacyCoreLocationProvider resetGeolocation]):
Implement a new class that bridges the currently used WebGeolocationCoreLocationProvider
to conform to the _WKGeolocationCoreLocationProvider protocol that WKGeolocationProviderIOS
expects.

• WebKit2.xcodeproj/project.pbxproj:

Tools:

Add API tests for the new WKUIDelegate SPI for allowing or denying websites permission
to use geolocation. Adopt the new WKProcessPool._coreLocationProvider property to
provide a stub object to simulate the various configurations of geolocation permissions:

1. The app doesn't have permission to use geolocation.
2. The app is allowed to use geolocation, but the UI delegate denies the web view permission.
3. The app is allowed to use geolocation, and the UI delegate allows the web view permission.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/Geolocation.mm: Added.

(-[TestCoreLocationProvider setListener:]):
(-[TestCoreLocationProvider requestGeolocationAuthorization]):
(-[TestCoreLocationProvider start]):
(-[TestCoreLocationProvider stop]):
(-[TestCoreLocationProvider setEnableHighAccuracy:]):
(expectException):
(-[GeolocationTestUIDelegate _webView:requestGeolocationAuthorizationForURL:frame:decisionHandler:]):
(-[GeolocationTestUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2Cocoa/GeolocationGetCurrentPositionResult.html: Added.

11:41 AM Changeset in webkit [215245] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Allow modern-media-controls to be provided through WebKitAdditions
​https://bugs.webkit.org/show_bug.cgi?id=170722
<rdar://problem/31553089>

Patch by Antoine Quint <Antoine Quint> on 2017-04-11
Reviewed by Dean Jackson.

If modern media controls source files are provided through WebKitAdditions, use these instead
of the sources found in the WebCore module.

• WebCore.xcodeproj/project.pbxproj:

11:39 AM Changeset in webkit [215244] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for CF ports after r215241
​https://bugs.webkit.org/show_bug.cgi?id=170725

• heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::nextFireTime):

11:29 AM Changeset in webkit [215243] by mrajca@apple.com

• 5 edits
  1 add in trunk

Change autoplay state to "prevented" when media is paused due to restrictions.
​https://bugs.webkit.org/show_bug.cgi?id=170686

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

Currently, the autoplay state is set to "prevented" when playback is about to begin without
user interaction and there are restrictions in place. We should also be setting this flag when
autoplay is allowed but due to a change in audio tracks, for example, it gets paused.

This patch also moves some common logic into setPlaybackWithoutUserGesture without changing behavior.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::setPlaybackWithoutUserGesture):
(WebCore::HTMLMediaElement::updateShouldPlay):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2/autoplay-muted-with-controls.html: Added test.
• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

11:27 AM Changeset in webkit [215242] by eric.carlson@apple.com

• 9 edits in trunk/Source

[MediaStream] Set correct audio session category when capturing audio
​https://bugs.webkit.org/show_bug.cgi?id=170736
<rdar://problem/31559405>

Reviewed by Jer Noble.

Source/WebCore:

No new tests yet, filed bug 170737.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Initialize m_mediaSession.
(WebCore::MediaStream::statusDidChange): Call canProduceAudioChanged.
(WebCore::MediaStream::mediaType): New. Return MediaStreamCapturingAudio when actively
capturing audio.
(WebCore::MediaStream::presentationType):
(WebCore::MediaStream::characteristics):
(WebCore::MediaStream::mayResumePlayback):
(WebCore::MediaStream::suspendPlayback):
(WebCore::MediaStream::sourceApplicationIdentifier):
(WebCore::MediaStream::canProduceAudio):

• Modules/mediastream/MediaStream.h:

• platform/audio/PlatformMediaSession.h: Add MediaStreamCapturingAudio.
• platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::has): Adjust assert for MediaStreamCapturingAudio.
(WebCore::PlatformMediaSessionManager::count): Ditto.

• platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState): Set small preferred buffer size when
capturing audio. Set audio session category to PlayAndRecord whenever there is a media
stream that is capturing audio.

Source/WebKit2:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::isPlayingMediaDidChange):

11:25 AM Changeset in webkit [215241] by Yusuke Suzuki

• 11 edits in trunk

[WebCore][JSC] ResourceUsageData.{timeOfNextEdenCollection,timeOfNextFullCollection} should be MonotonicTime
​https://bugs.webkit.org/show_bug.cgi?id=170725

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This patch makes GCActivityCallback return MonotonicTime instead of raw double value.

• heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::nextFireTime):

• heap/GCActivityCallback.h:

Source/WebCore:

Use MonotonicTime instead of raw doubles.
Currently, large part of data structures and helper functions are the same in
ResourceUsageOverlayCocoa.mm and ResourceUsageOverlayLinux.cpp. This should be
unified in a separate patch.

• page/ResourceUsageData.h:
• page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::gcTimerString):
(WebCore::ResourceUsageOverlay::platformDraw):

• page/linux/ResourceUsageOverlayLinux.cpp:

(WebCore::gcTimerString):

Source/WTF:

Make MonotonicTime more constexpr friendly mainly to annotate MonotonicTime::nan() as constexpr.

• wtf/MonotonicTime.h:

(WTF::MonotonicTime::MonotonicTime):
(WTF::MonotonicTime::fromRawSeconds):
(WTF::MonotonicTime::infinity):
(WTF::MonotonicTime::nan):
(WTF::MonotonicTime::secondsSinceEpoch):
(WTF::MonotonicTime::operator bool):
(WTF::MonotonicTime::operator+):
(WTF::MonotonicTime::operator-):
(WTF::MonotonicTime::operator==):
(WTF::MonotonicTime::operator!=):
(WTF::MonotonicTime::operator<):
(WTF::MonotonicTime::operator>):
(WTF::MonotonicTime::operator<=):
(WTF::MonotonicTime::operator>=):

Tools:

• TestWebKitAPI/Tests/WTF/Time.cpp:

(TestWebKitAPI::TEST):

10:34 AM Changeset in webkit [215240] by mitz@apple.com

• 2 edits in trunk/Source/WebKit/mac

[iOS] Simple HTML documents should allow non-markup JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=170734

Reviewed by Sam Weinig.

• WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Enabled scripting

but disabled scripting markup.

10:27 AM Changeset in webkit [215239] by commit-queue@webkit.org

• 9 edits in trunk

Activate WebRTC data channel tests for WK1
​https://bugs.webkit.org/show_bug.cgi?id=170710

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing and activated tests.

Making LibWebRTCProvider::factory not static.
For that purpose LibWebRTCMediaEndpoint now stores its peer connection factory reference.
Making LibWebRTCProvider use libebrtc networking by default.

Removing some no longer needed checks related to libwebrtc availability.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::factory):

• platform/mediastream/libwebrtc/LibWebRTCProvider.h:

Source/WebKit2:

• WebProcess/Network/webrtc/LibWebRTCProvider.h: Making sure networking is not done in the Web process.

LayoutTests:

• platform/mac-wk1/TestExpectations:

10:06 AM Changeset in webkit [215238] by commit-queue@webkit.org

• 53 edits in trunk

MediaStream id should be equal to msid
​https://bugs.webkit.org/show_bug.cgi?id=170712

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-11
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/datachannel-emptystring-expected.txt:
• web-platform-tests/webrtc/no-media-call-expected.txt:
• web-platform-tests/webrtc/promises-call-expected.txt:
• web-platform-tests/webrtc/rtcpeerconnection/setRemoteDescription-expected.txt:

Source/WebCore:

Covered by rebased tests.

Setting MediaStream id to libwebrtc mediastream label.
Refactoring to use more Ref<> in MediaStream code.

Making PeerConnection use the libwebrtc backend by default for layout tests instead of the mock.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::createTrackPrivateVector):
(WebCore::MediaStream::MediaStream):

• Modules/mediastream/MediaStream.h:
• Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookUp):

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::mediaStreamFromRTCStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteStream):
(WebCore::LibWebRTCMediaEndpoint::addRemoteTrack):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load):

• platform/graphics/MediaPlayer.h:
• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):

• platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::create):

• testing/Internals.cpp:

(WebCore::Internals::Internals):

LayoutTests:

Removing no longer needed/Adding needed calls to useMockRTCPeerConnectionFactory.

• fast/mediastream/RTCPeerConnection-inspect-answer.html:
• fast/mediastream/RTCPeerConnection-inspect-offer.html:
• fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html:
• fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html:
• fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
• fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html:
• fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html:
• webrtc/audio-peer-connection-webaudio.html:
• webrtc/audio-replace-track.html:
• webrtc/connection-state.html:
• webrtc/datachannel/basic.html:
• webrtc/datachannel/bufferedAmountLowThreshold.html:
• webrtc/datachannel/datachannel-gc.html:
• webrtc/datachannel/datachannel-stats.html:
• webrtc/datachannel/filter-ice-candidate.html:
• webrtc/ephemeral-certificates-and-cnames.html:
• webrtc/libwebrtc/descriptionGetters.html:
• webrtc/negotiatedneeded-event-addStream.html:
• webrtc/no-port-zero-in-upd-candidates.html:
• webrtc/peer-connection-audio-mute.html:
• webrtc/peer-connection-audio-mute2.html:
• webrtc/peer-connection-remote-audio-mute.html:
• webrtc/peer-connection-remote-audio-mute2.html:
• webrtc/release-after-getting-track.html:
• webrtc/video-disabled-black.html:
• webrtc/video-getParameters.html:
• webrtc/video-mediastreamtrack-stats.html:
• webrtc/video-mute.html:
• webrtc/video-remote-mute.html:
• webrtc/video-replace-track-to-null.html:
• webrtc/video-replace-track.html:
• webrtc/video-stats.html:
• webrtc/video-with-receiver.html:
• webrtc/video.html:

10:03 AM Changeset in webkit [215237] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[jsc] Add missing MacroAssemblerMIPS::or32() implementation
​https://bugs.webkit.org/show_bug.cgi?id=169714

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-04-11
Reviewed by Michael Catanzaro.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::or32):
Added or32(TrustedImm32, Address).

10:00 AM Changeset in webkit [215236] by Chris Fleizach

• 6 edits in trunk

AX: Web article navigation does not work (article rotor for Facebook, Twitter, Messages etc.)
​https://bugs.webkit.org/show_bug.cgi?id=170330
<rdar://problem/31366105>

Reviewed by Joanmarie Diggs.

Source/WebCore:

Add a search ability for the "article" role.

Test: accessibility/mac/search-predicate-article.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):

• accessibility/AccessibilityObject.h:
• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityArticleAncestor]):

• accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(createAccessibilitySearchKeyMap):

LayoutTests:

• accessibility/mac/search-predicate-article-expected.txt:
• accessibility/mac/search-predicate-article.html:

9:54 AM Changeset in webkit [215235] by commit-queue@webkit.org

• 7 edits in trunk

test262: test262/test/annexB/language/comments/multi-line-html-close.js
​https://bugs.webkit.org/show_bug.cgi?id=170648

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-11
Reviewed by Keith Miller.

JSTests:

• test262.yaml:

Source/JavaScriptCore:

• parser/Lexer.cpp:

(JSC::Lexer<T>::lex):
A multi-line comment that contains a line terminator is itself treated
like a line terminator. An HTML Close Comment that comes after it can
therefore treat it like it is at the start of a line, because it was
immediately preceeded by the equivalent of a line terminator.

LayoutTests:

• js/parser-xml-close-comment-expected.txt:
• js/script-tests/parser-xml-close-comment.js:

Update test coverage for JavaScript HTML comments.

9:38 AM Changeset in webkit [215234] by commit-queue@webkit.org

• 24 edits
  1 add in trunk

test262: test262/test/built-ins/Array/S15.4.3_A2.2.js
​https://bugs.webkit.org/show_bug.cgi?id=170652

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-04-11
Reviewed by Michael Saboff.

JSTests:

• stress/native-constructors-length.js: Added.

(assertLengthDescriptorAttributes):
Add a quick test for the length properties of all native constructors.

• ChakraCore/test/es5/enumerable.baseline-jsc:

Rebaseline expectations for this test.

• test262.yaml:

Source/JavaScriptCore:

• runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::finishCreation):

• runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::finishCreation):

• runtime/DateConstructor.cpp:

(JSC::DateConstructor::finishCreation):

• runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::finishCreation):

• runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):

• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

• runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

• runtime/StringConstructor.cpp:

(JSC::StringConstructor::finishCreation):

• runtime/SymbolConstructor.cpp:

(JSC::SymbolConstructor::finishCreation):
Ensure the "length" property on these native constructors is configurable (deletable).

LayoutTests:

• ietestcenter/Javascript/15.2.3.3-4-186-expected.txt:
• ietestcenter/Javascript/15.2.3.3-4-191-expected.txt:
• ietestcenter/Javascript/15.2.3.3-4-194-expected.txt:
• ietestcenter/Javascript/15.2.3.3-4-201-expected.txt:
• ietestcenter/Javascript/15.3.3.2-1-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.3/S15.4.3_A2.2-expected.txt:
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.1_Date.prototype.constructor/S15.9.5.1_A3_T2-expected.txt:

These tests expected the opposite, they are now out of date.

9:26 AM Changeset in webkit [215233] by Chris Fleizach

• 17 edits in trunk/Source

AX: PDF plugin needs to support PDF-DOM Mode
​https://bugs.webkit.org/show_bug.cgi?id=170589

Reviewed by Tim Horton.

Source/WebCore:

Provide WebCore support for accessibility connect to PDF document.
This includes the ability to connect a PDF annotation created node within WebKit to

its PDFAnnotation parent (through use of shadowPluginParent).

• accessibility/AXObjectCache.h:
• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXPostNotificationWithUserInfo):

• accessibility/mac/WebAccessibilityObjectWrapperMac.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper shadowPluginParent]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

• html/HTMLAttributeNames.in:
• plugins/PluginViewBase.h:

(WebCore::PluginViewBase::accessibilityShadowPluginParentForElement):

Source/WebKit2:

Provide access to DOM objects with PDF document. This mean:

1) Support a different set of attributes for WKPDFPluginAccessibilityObject.

WKPDFPluginAccessibilityObject is now a group instead of forwarding attribute calls to the pdf layer.

2) Connect the focused UI element to the active annotation if possible.
3) Mark the PDF associated nodes with an attribute so they can be identified later so their correct parent can be found.

• WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
• WebProcess/Plugins/PDF/PDFPlugin.h:
• WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFPluginAccessibilityObject pdfLayerController]):
(-[WKPDFPluginAccessibilityObject setPdfLayerController:]):
(-[WKPDFPluginAccessibilityObject convertRectToScreenSpace:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityActionNames]):
(-[WKPDFPluginAccessibilityObject accessibilityParameterizedAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityFocusedUIElement]):
(-[WKPDFPluginAccessibilityObject accessibilityAssociatedControlForAnnotation:]):
(-[WKPDFPluginAccessibilityObject accessibilityHitTest:]):
(WebKit::PDFPlugin::convertFromRootViewToPDFView):
(WebKit::PDFPlugin::convertFromPDFViewToScreen):
(WebKit::PDFPlugin::pluginHandlesContentOffsetForAccessibilityHitTest):
(WebKit::PDFPlugin::axObjectCache):
(WebKit::PDFPlugin::accessibilityShadowPluginParentForElement):

• WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach):

• WebProcess/Plugins/Plugin.h:

(WebKit::Plugin::accessibilityShadowPluginParentForElement):
(WebKit::Plugin::pluginHandlesContentOffsetForAccessibilityHitTest):

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::accessibilityShadowPluginParentForElement):

• WebProcess/Plugins/PluginView.h:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm:

(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

8:59 AM Changeset in webkit [215232] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for Windows after r215228 part 2
​https://bugs.webkit.org/show_bug.cgi?id=170723

Since GCActivityCallback class is annotated exported, we do not need to annotate each member.

• heap/GCActivityCallback.h:

8:51 AM Changeset in webkit [215231] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

REGRESSION(r215153): Request Animation Frame broken when building without REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR
​https://bugs.webkit.org/show_bug.cgi?id=170719

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-04-11
Reviewed by Žan Doberšek.

This is because when not using the display refresh monitor, the timer is always used, not only when throttling,
but since r215153 the rAF timer is always aligned to 30ms.

Fixes: fast/animation/request-animation-frame-too-rapid.html

• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::scheduleAnimation): Only do the timer alignment when throttling.

8:47 AM Changeset in webkit [215230] by Yusuke Suzuki

• 2 edits in trunk/Source/WTF

Unreviewed, build fix for Windows port after r215228
​https://bugs.webkit.org/show_bug.cgi?id=170723

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):

8:10 AM Changeset in webkit [215229] by yoav@yoav.ws

• 14 edits in trunk

[link preload] Double downloads of preloaded content when it's in MemoryCache
​https://bugs.webkit.org/show_bug.cgi?id=170122

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, but unflaked http/tests/preload/single_download_preload_headers_charset.html.

The test was flaky because it appears as if MemoryCache is not being evicted between runs,
and running multiple iterations of the test resulted in preloaded being taken out of MemoryCache
and not having the unknown encoding flag. In those cases, the result was a double download and
a failed test.

• loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::setEncoding): Set the m_encodingSet flag.

• loader/TextResourceDecoder.h: Added an m_encodingSet flag initialized to false.
• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::setEncoding): Assert that stylesheets don't maintain decoded text.

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource): Remove initialization of hasUnknownEncoding flag.

• loader/cache/CachedResource.h:

(WebCore::CachedResource::hasUnknownEncoding): Remove.
(WebCore::CachedResource::setHasUnknownEncoding): Remove.
(WebCore::CachedResource::CachedResource): Remove initialization of hasUnknownEncoding flag.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy): Set the encoding in case it changed.

LayoutTests:

• TestExpectations: Removed flakiness label from the header preload charset test.
• fast/loader/cache-encoding-expected.txt: Changed expectation.
• fast/loader/cache-encoding.html: Modified behavior to stick with the first decoded string.
• http/tests/preload/preload-encoding-expected.txt: Changed expectation.
• http/tests/preload/preload-encoding.html: Modified behavior to stick with the first decoded string.
• imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-01-expected.txt: This test refers to the same file

twice and expects different decoding for it each time. This is the behavior that we modified, and therefore the test expectation is changed as well.

8:09 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

8:08 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

7:56 AM Changeset in webkit [215228] by Yusuke Suzuki

• 19 edits in trunk/Source

[JSC][GTK] Use RunLoop::Timer in GTK port
​https://bugs.webkit.org/show_bug.cgi?id=170723

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

This patch makes GTK port use RunLoop::Timer for JSRunLoopTimer.
Only Cocoa-based ports use platform-specific Timer because it
has additional feature that changes RunLoop to the WebThread one.

And we enable Heap timers in all the ports including JSCOnly port.

• heap/EdenGCActivityCallback.cpp:

(JSC::EdenGCActivityCallback::lastGCLength):

• heap/EdenGCActivityCallback.h:
• heap/FullGCActivityCallback.cpp:

(JSC::FullGCActivityCallback::lastGCLength):

• heap/FullGCActivityCallback.h:
• heap/GCActivityCallback.cpp:

(JSC::GCActivityCallback::GCActivityCallback):
(JSC::GCActivityCallback::doWork):
(JSC::GCActivityCallback::scheduleTimer):
(JSC::GCActivityCallback::cancelTimer):
(JSC::GCActivityCallback::nextFireTime):
(JSC::GCActivityCallback::didAllocate):

• heap/GCActivityCallback.h:
• heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doWork):
(JSC::IncrementalSweeper::doSweep):

• heap/IncrementalSweeper.h:
• heap/StopIfNecessaryTimer.cpp:

(JSC::StopIfNecessaryTimer::scheduleSoon):

• runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::setRunLoop):
(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::cancelTimer):
(JSC::JSRunLoopTimer::JSRunLoopTimer):
(JSC::JSRunLoopTimer::~JSRunLoopTimer):
(JSC::JSRunLoopTimer::timerDidFireCallback):

• runtime/JSRunLoopTimer.h:
• runtime/PromiseDeferredTimer.cpp:

(JSC::PromiseDeferredTimer::scheduleWorkSoon):

Source/WTF:

Add secondsUntilFire method. And add setName and setPriority
for GTK RunLoop::Timer.

• wtf/RunLoop.h:
• wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::TimerBase::secondsUntilFire):

• wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::secondsUntilFire):

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::setName):
(WTF::RunLoop::TimerBase::secondsUntilFire):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::isActive):
(WTF::RunLoop::TimerBase::secondsUntilFire):

6:19 AM Changeset in webkit [215227] by magomez@igalia.com

• 6 edits in trunk/Source/WebCore

REGRESSION(r215211): [GTK] Lots of image related tests are timing out, causing the test bot to exit early
​https://bugs.webkit.org/show_bug.cgi?id=170727

Reviewed by Carlos Garcia Campos.

Since r215211 ImageDecoder::isSizeAvailable() calls encodedDataStatus() in the different decoder implementations,
and those implementations force a partial decoding of the image if the size is not available yet. But
ImageDecoder::isSizeAvailable() was already being used inside the decoders assuming that it wasn't going to
force this partial decoding. Due to this, there are some situations where the partial decoding is not
desired but it's happening anyway. For example, the check in setSize(), which causes the partial decoding
to happen again and again because no value is actually set to the animation size (which causes the timouts
in the test bot).

To avoid this, replace all the calls to ImageDecoder::isSizeAvailable() inside the decoders with calls to
ImageDecoder::encodedDataStatus(), which doesn't force the partial decoding.

Covered by existent tests.

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::setSize):

• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):

• platform/image-decoders/jpeg/JPEGImageDecoder.h:
• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageReader::decode):
(WebCore::PNGImageDecoder::frameBufferAtIndex):

• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::decode):

5:44 AM Changeset in webkit [215226] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[jsc][mips] Add missing MacroAssembler functions after r214187
​https://bugs.webkit.org/show_bug.cgi?id=170089

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-04-11
Reviewed by Yusuke Suzuki.

• assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::loadFloat): Added.
(JSC::MacroAssemblerMIPS::storeFloat): Added.

4:19 AM Changeset in webkit [215225] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Attach popup menu to web view widget
​https://bugs.webkit.org/show_bug.cgi?id=145866

Use gtk_menu_attach_to_widget() to let GTK+ know that popup menus belong to a certain web view.
This improves the positioning choices that the toolkit can do, and solves a long-standing issue
that caused long popup menus to hang outside of the available display area under Wayland.

Based on a patch by Jonas Ådahl <​jadahl@gmail.com>.

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-11
Reviewed by Carlos Garcia Campos.

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu):

3:22 AM Changeset in webkit [215224] by magomez@igalia.com

• 7 edits in trunk/Source/WebCore

REGRESSION(r215211): [GTK] Lots of image related tests are crashing, causing the test bot to exit early
​https://bugs.webkit.org/show_bug.cgi?id=170721

Reviewed by Carlos Garcia Campos.

r215211 caused an infinite loop because of calls between ImageDecoder::isSizeAvailable() and the specializations of
ImageDecoder::encodedDataStatus(). Change the different decoders so ImageDecoder::encodedDataStatus doesn't call
ImageDecoder::isSizeAvailable().

Covered by existent tests.

• platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::encodedDataStatus):

• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::encodedDataStatus):

• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::encodedDataStatus):

• platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::encodedDataStatus):

• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::encodedDataStatus):

• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::encodedDataStatus):

2:34 AM Changeset in webkit [215223] by Yusuke Suzuki

• 9 edits in trunk/Source

[JSC] Enable JSRunLoopTimer for JSCOnly and Windows
​https://bugs.webkit.org/show_bug.cgi?id=170655

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

• runtime/JSRunLoopTimer.cpp:

(JSC::JSRunLoopTimer::JSRunLoopTimer):
(JSC::JSRunLoopTimer::scheduleTimer):
(JSC::JSRunLoopTimer::cancelTimer):

• runtime/JSRunLoopTimer.h:

Source/WTF:

This patch makes RunLoop::Timer in Generic and Windows thread-safe to use it
in JSC's JSRunLoopTimer. Eventually, we would like to replace JSRunLoopTimer's
platform-dependent implementation to WTF::RunLoop::Timer.

• wtf/RunLoop.h:
• wtf/cf/RunLoopCF.cpp:

(WTF::RunLoop::TimerBase::start):

• wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::EarliestSchedule::operator()):
(WTF::RunLoop::populateTasks):
(WTF::RunLoop::runImpl):
(WTF::RunLoop::schedule):
(WTF::RunLoop::scheduleAndWakeUp):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

• wtf/glib/RunLoopGLib.cpp:

(WTF::RunLoop::TimerBase::TimerBase):

• wtf/win/RunLoopWin.cpp:

(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

2:20 AM Changeset in webkit [215222] by Manuel Rego Casasnovas

• 4 edits in trunk/LayoutTests

[css-grid] Fix fast/css-grid-layout/grid-simplified-layout-positioned.html
​https://bugs.webkit.org/show_bug.cgi?id=167538

Reviewed by Darin Adler.

fast/css-grid-layout/grid-simplified-layout-positioned.html was flacky
as the caret was not always painted in the test runner.
The test was checking for a crash in simplified layout (see bug #163450)
and has nothing to do with the caret or "autofocus" behavior.
"autofocus" was needed to get the crash, so this change modifies
the test to blur the element, so the caret is not painted anymore.

• fast/css-grid-layout/grid-simplified-layout-positioned-expected.html:

Don't focus the input element.

• fast/css-grid-layout/grid-simplified-layout-positioned.html: Blur

the input element to avoid showing the caret.

• platform/mac-wk2/TestExpectations: Remove file from expectations.

1:29 AM Changeset in webkit [215221] by zandobersek@gmail.com

• 2 edits in trunk

[CMake] OpenWebRTC libraries path isn't properly deduced
​https://bugs.webkit.org/show_bug.cgi?id=170670

Reviewed by Carlos Garcia Campos.

When using OpenWebRTC installation that's outside of the usual Jhbuild
installation directories, the library paths are ignored because the
dependency libraries are simply gathered from the pkg-config file.

Instead, the pkg-config data should be used to search for the correct
paths to the header and library locations. Both libopenwebrtc and
libopenwebrtc_gst libraries are needed, so the two library paths are
concatenated into the OPENWEBRTC_LIBRARIES variable.

• Source/cmake/FindOpenWebRTC.cmake:

1:27 AM Changeset in webkit [215220] by zandobersek@gmail.com

• 3 edits in trunk/Source/WTF

REGRESSION(r213645): It made JSC tests super slow and timeout on AArch64 Linux
​https://bugs.webkit.org/show_bug.cgi?id=169510

Reviewed by Saam Barati.

Add the volatile qualifiers for ASM statements that set up ldxr and stxr
instruction calls when HAVE(LL_SC) is enabled for aarch64 platforms.

This avoids indefinite execution when running GCC-compiled JSC on Linux.
Specific bug or expected behavior that differs from Clang wasn't determined.

HAVE(LL_SC) is re-enabled on non-Darwin aarch64 platforms.

• wtf/Atomics.h:
• wtf/Platform.h:

Apr 10, 2017:

11:18 PM Changeset in webkit [215219] by achristensen@apple.com

• 12 edits in trunk

Revert r215217
​https://bugs.webkit.org/show_bug.cgi?id=170703

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

10:46 PM Changeset in webkit [215218] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Fix bad change in r215167.
​https://bugs.webkit.org/show_bug.cgi?id=170656

Reviewed by Yusuke Suzuki.

Revert mistake made in r215167.

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::caretBlinkInterval):

10:05 PM Changeset in webkit [215217] by achristensen@apple.com

• 12 edits in trunk

Continue enabling WebRTC
​https://bugs.webkit.org/show_bug.cgi?id=170703

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:57 PM Changeset in webkit [215216] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

PlayerLayerView +layerClass methods should use return type Class.
​https://bugs.webkit.org/show_bug.cgi?id=165406

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-04-10
Reviewed by Sam Weinig.

No new tests because not behavior change.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPictureInPicturePlayerLayerView_layerClass):
(WebAVPlayerLayerView_layerClass):

8:33 PM Changeset in webkit [215215] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Have parseRevisionProperty use default repo name as the Buildbot key.
​https://bugs.webkit.org/show_bug.cgi?id=170696

Patch by Kocsen Chung <Kocsen Chung> on 2017-04-10
Reviewed by Daniel Bates.

Previously, we needed to set a key and a fallbackKey when addressing
Buildbot data for Internal. That is no longer necessary as we can make a safe assumption
that the repo name maps exactly to that key for every repository other
than WebKit.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

Set key = repositoryName and only use fallback keys when dealing with WebKit.

7:49 PM Changeset in webkit [215214] by aakash_jain@apple.com

• 2 edits in trunk/Tools

Add test262 JavaScriptCore tests to dashboard
​https://bugs.webkit.org/show_bug.cgi?id=170711

Rubber-stamped by Joseph Pecoraro.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): Added test262 JSC tests to dashboard.

6:14 PM Changeset in webkit [215213] by jiewen_tan@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed, test expectations update

• platform/wk2/TestExpectations:

5:40 PM Changeset in webkit [215212] by commit-queue@webkit.org

• 16 edits in trunk

REGRESSION(r195479) First main resource load in new WebProcess bypasses content extensions
​https://bugs.webkit.org/show_bug.cgi?id=170707
<rdar://problem/27788755>

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-04-10
Reviewed by Tim Horton.

Source/WebKit2:

We fix this by sending the UserContentController with the WebPageCreationParameters
instead of in a IPC message immediately following creation. By the time the WebPage
receives its second message, it has already started loading the first main resource.

I also changed all instances of calling ChildProcessProxy::connection() to send a message
in favor of calling ChildProcessProxy::send, which does the same thing except if a child
process has not started, it will put the message in a queue and send it when the process
is finished launching. This was necessary because the UserContentController is now connected
to the process sooner, so there were some API tests that would try to send messages between
initiating a process launch and finishing a process launch, and this change preserves the
existing behavior in those cases.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):
(WebKit::DatabaseProcessProxy::didFinishLaunching):

• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::cancel):
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilenameAsync):

• UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addUserContentWorldUse):
(WebKit::WebUserContentControllerProxy::removeUserContentWorldUses):
(WebKit::WebUserContentControllerProxy::addUserScript):
(WebKit::WebUserContentControllerProxy::removeUserScript):
(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::addUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeUserStyleSheet):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):
(WebKit::WebUserContentControllerProxy::addUserScriptMessageHandler):
(WebKit::WebUserContentControllerProxy::removeUserMessageHandlerForName):
(WebKit::WebUserContentControllerProxy::removeAllUserMessageHandlers):
(WebKit::WebUserContentControllerProxy::addContentExtension):
(WebKit::WebUserContentControllerProxy::removeContentExtension):
(WebKit::WebUserContentControllerProxy::removeAllContentExtensions):

• UIProcess/UserContent/WebUserContentControllerProxy.h:
• UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::removeAll):
(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::sendTable):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::finishInitializingWebPageAfterProcessLaunch):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::addWebUserContentControllerProxy):

• UIProcess/WebProcessProxy.h:
• WebProcess/UserContent/WebUserContentController.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST_F):

• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[ContentBlockingWebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):

5:24 PM Changeset in webkit [215211] by commit-queue@webkit.org

• 33 edits
  1 add in trunk/Source/WebCore

CachedImage should stop decoding images when unknown type is detected
​https://bugs.webkit.org/show_bug.cgi?id=170530

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-04-10
Reviewed by Tim Horton.

If the status of the encoded data is "unknown type", WebKit should stop
decoding the rest of the data. Ideally WebKit should also cancel loading
the rest of the encoded data.

To do that we need to add a function to the ImageDecoder to return the
encodedDataStatus(). We also need to change the return type of Image::setData()
and Image::dataChanged() form bool to EncodedDataStatus.

• WebCore.xcodeproj/project.pbxproj: Add ImageTypes.h to the WebCore project.
• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::addIncrementalDataBuffer): Replace checking !sizeAvailable
by checking if encodedDataStatus isn't an error but it has not reached
sizeAvailable state

• loader/cache/CachedResourceClientWalker.h:

(WebCore::CachedResourceClientWalker::CachedResourceClientWalker): Unrelated clean-up.
(WebCore::CachedResourceClientWalker::next): Ditto.

• loader/icon/IconRecord.cpp:

(WebCore::IconRecord::setImageData): Image::setData() used to return a bool. Now it returns
an EncodedDataStatus. !setData() now means setData() < EncodedDataStatus::SizeAvailable.

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::dataChanged): Replace the return of dataChanged() from bool
by EncodedDataStatus.

• platform/graphics/BitmapImage.h: Replace isSizeAvailable() by a new function

named encodedDataStatus().

• platform/graphics/Image.cpp:

(WebCore::Image::setData): Code clean-up and adding a clarification comment.

• platform/graphics/Image.h: Change the return of setData() and dataChanged() to be

EncodedDataStatus.
(WebCore::Image::dataChanged): Return EncodedDataStatus::Unknown as an indication
the size is not available but we do not have an error.

• platform/graphics/ImageTypes.h: Added.

Image definitions which are shared among Image, ImageDecoder, ImageSource,
ImageFrameCache and ImageFrame used to be added to ImageFrame.h. This has
been annoying since these definitions aren't related to ImageFrame only.
A new header file named ImageTypes.h is to the to include such definitions.
(WebCore::operator++):

• platform/graphics/ImageFrame.h:

(WebCore::operator++): Deleted.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::ImageFrameCache): This is the case of a BitmapImage without
a decoder but with a NativeImage. The status has to be EncodedDataStatus::Complete.
(WebCore::ImageFrameCache::growFrames): Replace if (isSizeAvailable()) by
if (encodedDataStatus() >= EncodedDataStatus::SizeAvailable).
(WebCore::ImageFrameCache::metadata): Ditto.
(WebCore::ImageFrameCache::encodedDataStatus): This is a replacement for isSizeAvailable().
Don't cache the EncodedDataStatus until it is Complete. Don't call didDecodeProperties()
until the status >= EncodedDataStatus::SizeAvailable.
(WebCore::ImageFrameCache::isSizeAvailable): Deleted.

• platform/graphics/ImageFrameCache.h: Replace isSizeAvailable() by encodedDataStatus().
• platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::dataChanged): Make return an EncodedDataStatus instead of returning
a bool for isSizeAvailable.

• platform/graphics/ImageSource.h:

(WebCore::ImageSource::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
(WebCore::ImageSource::isSizeAvailable): Deleted.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
The logic of this function is the following:

-- CGImageSourceGetStatus() can return kCGImageStatusUnexpectedEOF, kCGImageStatusInvalidData
or kCGImageStatusReadingHeader even if CG will end up recovering form the error and drawing
the image. Actually CG initializes the status of CGImageSource before receiving any data
with kCGImageStatusInvalidData. So the status will be considered an error only if all the
data is received but CG does not move the status of this CGImageSource to Complete.
-- If CGImageSourceGetStatus() returns Incomplete, this means CG already created the image
reader and therefore the image type is known.
-- If CGImageSourceGetStatus() returns UnknownType, this means CG could not create the
image reader and this should be considered an error.

(WebCore::ImageDecoder::isSizeAvailable): Deleted.

• platform/graphics/cg/ImageDecoderCG.h: Replace isSizeAvailable() by encodedDataStatus().
• platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dataChanged): The PDFDocument is created only when allDataReceived.

• platform/graphics/cg/PDFDocumentImage.h: Change the return type from bool to EncodedDataStatus.
• platform/image-decoders/ImageDecoder.h:

(WebCore::ImageDecoder::encodedDataStatus): Add a new function encodedDataStatus(). Deduce the
status of the encoded data from the flags m_failed, m_isAllDataReceived and m_sizeAvailable in
this order.
(WebCore::ImageDecoder::isSizeAvailable): Make this function uses encodedDataStatus().

• platform/image-decoders/bmp/BMPImageDecoder.cpp:

(WebCore::BMPImageDecoder::encodedDataStatus): Replace isSizeAvailable() by encodedDataStatus().
(WebCore::BMPImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/bmp/BMPImageDecoder.h:
• platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::encodedDataStatus): Ditto.
(WebCore::GIFImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/gif/GIFImageDecoder.h:
• platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::encodedDataStatus): Ditto.
(WebCore::ICOImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/ico/ICOImageDecoder.h:
• platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageDecoder::encodedDataStatus): Ditto.
(WebCore::JPEGImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/jpeg/JPEGImageDecoder.h:
• platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::encodedDataStatus): Ditto.
(WebCore::PNGImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/png/PNGImageDecoder.h:
• platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::encodedDataStatus): Ditto.
(WebCore::WEBPImageDecoder::isSizeAvailable): Deleted.

• platform/image-decoders/webp/WEBPImageDecoder.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged): m_page is created only when allDataReceived is true.

• svg/graphics/SVGImage.h:

5:23 PM Changeset in webkit [215210] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark two newly imported web-platform-tests as failing.

Unreviewed test gardening.

• TestExpectations:

5:11 PM Changeset in webkit [215209] by achristensen@apple.com

• 7 edits in trunk

Add API to get available content extension identifiers in a WKContentExtensionStore
​https://bugs.webkit.org/show_bug.cgi?id=170093

Reviewed by Geoffrey Garen.

Source/WebKit2:

• UIProcess/API/APIContentExtensionStore.cpp:

(API::constructedPathPrefix):
(API::constructedPathFilter):
(API::constructedPath):
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers):

• UIProcess/API/APIContentExtensionStore.h:
• UIProcess/API/Cocoa/WKContentExtensionStore.h:
• UIProcess/API/Cocoa/WKContentExtensionStore.mm:

(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]):
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]):
(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]):
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WKUserContentExtensionStore.mm:

(TEST_F):

4:59 PM Changeset in webkit [215208] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Mark SVG-Within-OpenType as "Under Consideration"
​https://bugs.webkit.org/show_bug.cgi?id=170706

Reviewed by Brady Eidson.

• features.json:

3:22 PM Changeset in webkit [215207] by Wenson Hsieh

• 4 edits in trunk/Tools

Refactor DataInteractionTests.UnresponsivePageDoesNotHangUI to not check against a fixed time interval
​https://bugs.webkit.org/show_bug.cgi?id=170658

Reviewed by Tim Horton.

Uses ignoreSynchronousMessagingTimeoutsForTesting to ensure that this test times out if data interaction
preparation is synchronous, or passes if it is asynchronous.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView initWithFrame:]):
(-[TestWKWebView initWithFrame:configuration:processPoolConfiguration:]):
(-[TestWKWebView _setUpTestWindow:]):

2:46 PM Changeset in webkit [215206] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: WebSockets: Don't clip data in the data grid
​https://bugs.webkit.org/show_bug.cgi?id=170559

Reviewed by Timothy Hatcher.

Long lines without spaces should be broken down into several lines instead of being ellipsized.

• UserInterface/Views/WebSocketContentView.css:

(.web-socket.content-view > .data-grid td.data-column,):

2:45 PM Changeset in webkit [215205] by rniwa@webkit.org

• 33 edits
  2 adds in trunk/Websites/perf.webkit.org

Add the UI for scheduling a A/B testing with a custom root
​https://bugs.webkit.org/show_bug.cgi?id=170622

Reviewed by Anders Carlsson.

This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch
would update the syncing script to schedule such an A/B testing job to a buildbot instance.

• ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace

the file path for the backup.

• init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column

to store the root file in commit_set_relationships.

• public/api/build-requests.php:

(main): Include the uploaded files.

• public/api/commits.php:

(main): Added the support for querying the latest commits for a given platform. This is used in a new page
to create a custom analysis task to autofill the latest revisions for a given platform.

• public/api/test-groups.php:

(main): Include the uploaded files.

• public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct): Added a list of uploaded_files and a map from its id.
(BuildRequestsFetcher::uploaded_files): Added.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added the support for including custom roots' id in
each commit set, and inserting its meta data in the list of uplaoded files.

• public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_latest_for_platform): Added. Finds the latest commit for a given platform. Ideally,
we should be finding the latest commit for a given platform, but this is very slow so instead find the commit
of the latest build for a given platform.

• public/privileged-api/create-test-group.php:

(main): Added the support for creating an analysis task along with a group.
(commit_sets_from_revision_sets): Added the support for custom roots. Verify the specified uploaded file exists
and include it in commit_set_relationships. Because commits and upload files are stored in a different column
in commit_set_relationships, this function now stores the information for each row of commit_set_relationships
except the commit set ID, which is unknown until the set is created, instead of a commit ID.
(ensure_commit_sets): Made the each entry in a commit set a row instead of a commit ID as done. As this format
is only by v2 UI and detect-changes.js, we don't add the support for specifying custom roots here.

• public/privileged-api/upload-file.php:

(main): Fixed a typo. Also added one more error check.

• public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,

and a set of revisions, as well as custom roots for a custom A/B testing job. The first set of revision with
custom roots is referred as "baseline", and the second configuration is referred as "comparison" in this class.
(CustomAnalysisTaskConfigurator):
(CustomAnalysisTaskConfigurator.prototype.tests): Added.
(CustomAnalysisTaskConfigurator.prototype.platform): Added.
(CustomAnalysisTaskConfigurator.prototype.commitSets): Added. Returns a pair of baseline and comparsion if both
have been configured by the user.
(CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): Added.
(CustomAnalysisTaskConfigurator.prototype._configureComparison): Added. Called when the user is to configu the
"comparison" configuration.
(CustomAnalysisTaskConfigurator.prototype.render): Added.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests): Added. Renders the list of top-level tests
that can be scheduled by a triggerable.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerablePlatforms): Added. Renders the list of platforms
that can be schedule with the currently selected list of tests by a triggerable. Note that the current UI only
lets the user select a single test but the intent is to allow multiple tests to be selected in the near future.
(CustomAnalysisTaskConfigurator.prototype._buildCheckboxList): Added. Creates a list of radio boxes to select
an item with a callback for each. It automatically sets "selected" class on the selected item. It's used to
render both the list of tests and platforms.
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable): Added. Finds the triggerable for a given list of
tests and platforms. Returns an error when some tests belong to another triggearalbe.
(CustomAnalysisTaskConfigurator.prototype._updateRepositoryGroups): Added. Finds a repository group to use when
the current triggerable has changed. We try to use the repository group of the same name if there is any, and
defaults to the first repository group if there is none. This allows the set of repositories to be specified to
more or less persist across different triggerables. For example, if iOS platforms and Mac platforms use two
distinct triggerables , and both triggerables have two repository groups: one that only specify the OS and the
other that specifies both teh OS and WebKit revision, then this code allows the choice the user had made to
specify either just the OS or the OS and WebKit will be preserved when the user switches from an iOS platform
to a Mac platform.
(CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Added. Create a commit set map, the format that
TestGroup.createWithTask accepts given "baseline" and "comparison" commit sets. Pretend "comparison" is not set
if two sets are identical since it makes no sense to schedule an A/B testing job when A and B are identical.
(CustomAnalysisTaskConfigurator.prototype._computeCommitSet): Added. Creates a commit set using the revisions
and the csutom roots the user had specified.
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Added. Renders the pane to specify revisions
and custom roots for "baseline" and "comparison".
(CustomAnalysisTaskConfigurator.prototype._renderBaselineRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._renderComparisonRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._optionalRepositoryList): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionTable): Added. Creates a table for specifying revisions
and custom roots along with a list of repository groups to pick. The set of repositories and custom roots are
shown at the all if all repository groups require them. Otherwise, they are grouped at the bottom as optional.
(CustomAnalysisTaskConfigurator.prototype._buildRepositoryGroupList): Added.
(CustomAnalysisTaskConfigurator.prototype._selectRepositoryGroup): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionInput): Added. Creates an input element to specify
a revision for a given repository. Autofills it with the latest commit for the currently selected platform if
the user had not modified the field by the time the revisions are fetched.
(CustomAnalysisTaskConfigurator.htmlTemplate): Added.
(CustomAnalysisTaskConfigurator.cssTemplate): Added.

• public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"

or "comparison" configurations of CustomAnalysisTaskConfigurator. It's "instant" because it auto-detects when a
file to be uploaded had already been uploaded elsewhere by checking its SHA-256 hash.
(InstantFileUploader):
(InstantFileUploader.prototype.hasFileToUpload): Added.
(InstantFileUploader.prototype.uploadedFiles): Added.
(InstantFileUploader.prototype.addUploadedFile): Added. It's called on the uploader for "comparison"
configuration when the uploader for "baseline" configuration dipsatches "uploadedFile" action to automatically
mirror the newly uploaded custom root to "comparision" configuration.
(InstantFileUploader.prototype.didConstructShadowTree): Added.
(InstantFileUploader.prototype.render): Added.
(InstantFileUploader.prototype._renderUploadedFiles): Added. Renders the list of the uploaded files.
(InstantFileUploader.prototype._renderPreuploadFiles): Added. Renders the list of the files to be uploaded with
a progress bar.
(InstantFileUploader.prototype._updateUploadStatus): Added. Updates the progress bar for uploading the file.
(InstantFileUploader.prototype._formatUploadError): Added.
(InstantFileUploader.prototype._didFileInputChange): Added. Called when the user picks a file to uploaded on
the input element. Fetch the meta data for the uploaded file with the same SHA-256 hash if there is any, and
start uploading the file if there isn't one.
(InstantFileUploader.prototype._removeUploadedFile): Added.
(InstantFileUploader.prototype._didUploadFile): Added. Move a file from the list of files to be uploaded to
the list of uploaded files.
(InstantFileUploader.htmlTemplate): Added.
(InstantFileUploader.cssTemplate): Added.

• public/v3/index.html:

• public/v3/models/analysis-task.js:

(AnalysisTask): Made platform and metric optional as it is now.
(AnalysisTask.findByPlatformAndMetric): Skip analysis tasks without a platform or a metric.
(AnalysisTask.prototype.isCustom): Added. Returns true for a custom analysis task.
(AnalysisTask.fetchRelatedTasks): Skip custom analysis tasks.
(AnalysisTask._constructAnalysisTasksFromRawData): Construct analysis tasks even if they were missing a metric
or a platform instead of silently skipping them.

• public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.

• public/v3/models/commit-log.js:

(CommitLog.fetchLatestCommitForPlatform): Added.

• public/v3/models/commit-set.js:

(CommitSet): Added this._customRoots.
(CommitSet.prototype.customRoots): Returns this._customRoots.
(CommitSet.prototype.equals): Returns false when the set of custom roots are not equal.
(CommitSet.areCustomRootsEqual): Added.
(CustomCommitSet):
(CustomCommitSet.prototype.equals): Added.
(CustomCommitSet.prototype.customRoots): Added.
(CustomCommitSet.prototype.addCustomRoot): Added.

• public/v3/models/manifest.js:

(Manifest._didFetchManifest): Store fileUploadSizeLimit in the manifest as UploadedFile.fileUploadSizeLimit.
This allows a file size check in the client size instead of uploading it to the server and receiving an error.

• public/v3/models/metric.js:

(Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.

• public/v3/models/test-group.js:

(TestGroup.prototype.createWithTask): Added.
(TestGroup.prototype.createAndRefetchTestGroups):
(TestGroup.prototype._revisionSetsFromCommitSets): Added. Extracted from createAndRefetchTestGroups.
(TestGroup.prototype._fetchTestGroupsForTask): Added. Extracted from createAndRefetchTestGroups.

• public/v3/models/triggerable.js:

(Triggerable.triggerablePlatformsForTests): Added.
(Triggerable.sortByNamePreferringSmallerRepositories): Added.

• public/v3/models/uploaded-file.js:

(UploadedFile.prototype.createdAt): Added.
(UploadedFile.prototype.filename): Added.
(UploadedFile.prototype.author): Added.
(UploadedFile.prototype.size): Added.
(UploadedFile.uploadFile): Added a client-side check for the file size using UploadedFile.fileUploadSizeLimit.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Ditto. Also fixed a bug that 404 was resulting in a rejected
promise instead of a resolved promise with null.

• public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
metric being null for some analysis tasks.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._didFetchTask): Don't fetch the measurement set or create a chart for custom tasks.
(AnalysisTaskPage.prototype.render): Don't display the charts or the stacking table for custom tasks.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus): Don't try to show the full test name for custom tasks
since it's not associated with exactly one pair.

• public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype._renderBuildRevisionTable):
(ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.

• public/v3/pages/chart-pane.js:

(ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.

• public/v3/pages/create-analysis-task-page.js:

(CreateAnalysisTaskPage): This page now shows CustomAnalysisTaskConfigurator by default, and lets a user create
a custom analysis task by picking a test, a platform, and a set of revisions and custom darwinup roots.
(CreateAnalysisTaskPage.prototype.updateFromSerializedState): Show a message when inProgress is set. This is
the old behavior of this page.
(CreateAnalysisTaskPage.prototype.didConstructShadowTree): Added.
(CreateAnalysisTaskPage.prototype._createAnalysisTaskWithGroup): Added.
(CreateAnalysisTaskPage.prototype.render):
(CreateAnalysisTaskPage.prototype._renderMessage): Added. Hides CustomAnalysisTaskConfigurator and the select
element to specify the numebr of iterations when a message is set.
(CreateAnalysisTaskPage.htmlTemplate):
(CreateAnalysisTaskPage.cssTemplate):

• public/v3/pages/page-router.js:

(PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.

• server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of

uploaded files associated with build requests.

• server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task

and a test group with custom roots.

• server-tests/resources/mock-data.js:

(MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table.

• tools/js/remote.js: Include global.FormData from form-data.js.

• unit-tests/build-request-tests.js:

(sampleBuildRequestData): Updated the mock response.

• unit-tests/buildbot-syncer-tests.js:

(createSampleBuildRequest): Ditto.

• unit-tests/test-groups-tests.js:

(sampleTestGroup): Ditto.

2:44 PM Changeset in webkit [215204] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Remove call to WKShowKeyAndMain
​https://bugs.webkit.org/show_bug.cgi?id=170691
rdar://problem/31050032

Reviewed by Beth Dakin.

• Carbon/CarbonWindowAdapter.mm:

(-[CarbonWindowAdapter makeKeyWindow]):

2:43 PM Changeset in webkit [215203] by rniwa@webkit.org

• 36 edits
  1 delete in trunk

.:
Elftoolchain ar doesn't support response files
​https://bugs.webkit.org/show_bug.cgi?id=170105

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-04-08
Reviewed by Michael Catanzaro.

WebKit enables the use of response files when cmake and ninja is used.
However, the default implementation of ar command used in FreeBSD, which
is part of elftoolchain project, doesn't support reading arguments from
response files. To avoid causing undefined reference error on FreeBSD,
we disable the use of response files when elftoolchain ar is detected.

• Source/cmake/OptionsCommon.cmake:

Websites/perf.webkit.org:
Unreviewed, rolling out r215202.
​https://bugs.webkit.org/show_bug.cgi?id=170694

Committed incorrectly (Requested by rniwa on #webkit).

Reverted changeset:

"Add the UI for scheduling a A/B testing with a custom root"
​https://bugs.webkit.org/show_bug.cgi?id=170622
​http://trac.webkit.org/changeset/215202

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-04-10

2:38 PM Changeset in webkit [215202] by rniwa@webkit.org

• 36 edits
  5 adds in trunk

Add the UI for scheduling a A/B testing with a custom root
​https://bugs.webkit.org/show_bug.cgi?id=170622

Reviewed by Anders Carlsson.

This patch adds the support for creating a new analysis task with a custom darwinup roots. A follow up patch
would update the syncing script to schedule such an A/B testing job to a buildbot instance.

• ReadMe.md: Updated instructions for backing up and restoring the database so that it's easier to replace

the file path for the backup.

• init-database.sql: Make task_platform and task_metric optional in each analysis task. Also added a column

to store the root file in commit_set_relationships.

• public/api/build-requests.php:

(main): Include the uploaded files.

• public/api/commits.php:

(main): Added the support for querying the latest commits for a given platform. This is used in a new page
to create a custom analysis task to autofill the latest revisions for a given platform.

• public/api/test-groups.php:

(main): Include the uploaded files.

• public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::construct): Added a list of uploaded_files and a map from its id.
(BuildRequestsFetcher::uploaded_files): Added.
(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Added the support for including custom roots' id in
each commit set, and inserting its meta data in the list of uplaoded files.

• public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_latest_for_platform): Added. Finds the latest commit for a given platform. Ideally,
we should be finding the latest commit for a given platform, but this is very slow so instead find the commit
of the latest build for a given platform.

• public/privileged-api/create-test-group.php:

(main): Added the support for creating an analysis task along with a group.
(commit_sets_from_revision_sets): Added the support for custom roots. Verify the specified uploaded file exists
and include it in commit_set_relationships. Because commits and upload files are stored in a different column
in commit_set_relationships, this function now stores the information for each row of commit_set_relationships
except the commit set ID, which is unknown until the set is created, instead of a commit ID.
(ensure_commit_sets): Made the each entry in a commit set a row instead of a commit ID as done. As this format
is only by v2 UI and detect-changes.js, we don't add the support for specifying custom roots here.

• public/privileged-api/upload-file.php:

(main): Fixed a typo. Also added one more error check.

• public/v3/components/custom-analysis-task-configurator.js: Added. The UI for selecting a test, a platform,

and a set of revisions, as well as custom roots for a custom A/B testing job. The first set of revision with
custom roots is referred as "baseline", and the second configuration is referred as "comparison" in this class.
(CustomAnalysisTaskConfigurator):
(CustomAnalysisTaskConfigurator.prototype.tests): Added.
(CustomAnalysisTaskConfigurator.prototype.platform): Added.
(CustomAnalysisTaskConfigurator.prototype.commitSets): Added. Returns a pair of baseline and comparsion if both
have been configured by the user.
(CustomAnalysisTaskConfigurator.prototype.didConstructShadowTree): Added.
(CustomAnalysisTaskConfigurator.prototype._configureComparison): Added. Called when the user is to configu the
"comparison" configuration.
(CustomAnalysisTaskConfigurator.prototype.render): Added.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerableTests): Added. Renders the list of top-level tests
that can be scheduled by a triggerable.
(CustomAnalysisTaskConfigurator.prototype._renderTriggerablePlatforms): Added. Renders the list of platforms
that can be schedule with the currently selected list of tests by a triggerable. Note that the current UI only
lets the user select a single test but the intent is to allow multiple tests to be selected in the near future.
(CustomAnalysisTaskConfigurator.prototype._buildCheckboxList): Added. Creates a list of radio boxes to select
an item with a callback for each. It automatically sets "selected" class on the selected item. It's used to
render both the list of tests and platforms.
(CustomAnalysisTaskConfigurator.prototype._updateTriggerable): Added. Finds the triggerable for a given list of
tests and platforms. Returns an error when some tests belong to another triggearalbe.
(CustomAnalysisTaskConfigurator.prototype._updateRepositoryGroups): Added. Finds a repository group to use when
the current triggerable has changed. We try to use the repository group of the same name if there is any, and
defaults to the first repository group if there is none. This allows the set of repositories to be specified to
more or less persist across different triggerables. For example, if iOS platforms and Mac platforms use two
distinct triggerables , and both triggerables have two repository groups: one that only specify the OS and the
other that specifies both teh OS and WebKit revision, then this code allows the choice the user had made to
specify either just the OS or the OS and WebKit will be preserved when the user switches from an iOS platform
to a Mac platform.
(CustomAnalysisTaskConfigurator.prototype._updateCommitSetMap): Added. Create a commit set map, the format that
TestGroup.createWithTask accepts given "baseline" and "comparison" commit sets. Pretend "comparison" is not set
if two sets are identical since it makes no sense to schedule an A/B testing job when A and B are identical.
(CustomAnalysisTaskConfigurator.prototype._computeCommitSet): Added. Creates a commit set using the revisions
and the csutom roots the user had specified.
(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Added. Renders the pane to specify revisions
and custom roots for "baseline" and "comparison".
(CustomAnalysisTaskConfigurator.prototype._renderBaselineRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._renderComparisonRevisionTable): Added.
(CustomAnalysisTaskConfigurator.prototype._optionalRepositoryList): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionTable): Added. Creates a table for specifying revisions
and custom roots along with a list of repository groups to pick. The set of repositories and custom roots are
shown at the all if all repository groups require them. Otherwise, they are grouped at the bottom as optional.
(CustomAnalysisTaskConfigurator.prototype._buildRepositoryGroupList): Added.
(CustomAnalysisTaskConfigurator.prototype._selectRepositoryGroup): Added.
(CustomAnalysisTaskConfigurator.prototype._buildRevisionInput): Added. Creates an input element to specify
a revision for a given repository. Autofills it with the latest commit for the currently selected platform if
the user had not modified the field by the time the revisions are fetched.
(CustomAnalysisTaskConfigurator.htmlTemplate): Added.
(CustomAnalysisTaskConfigurator.cssTemplate): Added.

• public/v3/components/instant-file-uploader.js: Added. A form to upload a custom darwinup root in "baseline"

or "comparison" configurations of CustomAnalysisTaskConfigurator. It's "instant" because it auto-detects when a
file to be uploaded had already been uploaded elsewhere by checking its SHA-256 hash.
(InstantFileUploader):
(InstantFileUploader.prototype.hasFileToUpload): Added.
(InstantFileUploader.prototype.uploadedFiles): Added.
(InstantFileUploader.prototype.addUploadedFile): Added. It's called on the uploader for "comparison"
configuration when the uploader for "baseline" configuration dipsatches "uploadedFile" action to automatically
mirror the newly uploaded custom root to "comparision" configuration.
(InstantFileUploader.prototype.didConstructShadowTree): Added.
(InstantFileUploader.prototype.render): Added.
(InstantFileUploader.prototype._renderUploadedFiles): Added. Renders the list of the uploaded files.
(InstantFileUploader.prototype._renderPreuploadFiles): Added. Renders the list of the files to be uploaded with
a progress bar.
(InstantFileUploader.prototype._updateUploadStatus): Added. Updates the progress bar for uploading the file.
(InstantFileUploader.prototype._formatUploadError): Added.
(InstantFileUploader.prototype._didFileInputChange): Added. Called when the user picks a file to uploaded on
the input element. Fetch the meta data for the uploaded file with the same SHA-256 hash if there is any, and
start uploading the file if there isn't one.
(InstantFileUploader.prototype._removeUploadedFile): Added.
(InstantFileUploader.prototype._didUploadFile): Added. Move a file from the list of files to be uploaded to
the list of uploaded files.
(InstantFileUploader.htmlTemplate): Added.
(InstantFileUploader.cssTemplate): Added.

• public/v3/index.html:

• public/v3/models/analysis-task.js:

(AnalysisTask): Made platform and metric optional as it is now.
(AnalysisTask.findByPlatformAndMetric): Skip analysis tasks without a platform or a metric.
(AnalysisTask.prototype.isCustom): Added. Returns true for a custom analysis task.
(AnalysisTask.fetchRelatedTasks): Skip custom analysis tasks.
(AnalysisTask._constructAnalysisTasksFromRawData): Construct analysis tasks even if they were missing a metric
or a platform instead of silently skipping them.

• public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Construct uploaded file objects returned by /api/build-requests.

• public/v3/models/commit-log.js:

(CommitLog.fetchLatestCommitForPlatform): Added.

• public/v3/models/commit-set.js:

(CommitSet): Added this._customRoots.
(CommitSet.prototype.customRoots): Returns this._customRoots.
(CommitSet.prototype.equals): Returns false when the set of custom roots are not equal.
(CommitSet.areCustomRootsEqual): Added.
(CustomCommitSet):
(CustomCommitSet.prototype.equals): Added.
(CustomCommitSet.prototype.customRoots): Added.
(CustomCommitSet.prototype.addCustomRoot): Added.

• public/v3/models/manifest.js:

(Manifest._didFetchManifest): Store fileUploadSizeLimit in the manifest as UploadedFile.fileUploadSizeLimit.
This allows a file size check in the client size instead of uploading it to the server and receiving an error.

• public/v3/models/metric.js:

(Metric.formatTime): Moved from ChartPaneStatusView to be also used by InstantFileUploader._renderUploadedFiles.

• public/v3/models/test-group.js:

(TestGroup.prototype.createWithTask): Added.
(TestGroup.prototype.createAndRefetchTestGroups):
(TestGroup.prototype._revisionSetsFromCommitSets): Added. Extracted from createAndRefetchTestGroups.
(TestGroup.prototype._fetchTestGroupsForTask): Added. Extracted from createAndRefetchTestGroups.

• public/v3/models/triggerable.js:

(Triggerable.triggerablePlatformsForTests): Added.
(Triggerable.sortByNamePreferringSmallerRepositories): Added.

• public/v3/models/uploaded-file.js:

(UploadedFile.prototype.createdAt): Added.
(UploadedFile.prototype.filename): Added.
(UploadedFile.prototype.author): Added.
(UploadedFile.prototype.size): Added.
(UploadedFile.uploadFile): Added a client-side check for the file size using UploadedFile.fileUploadSizeLimit.
(UploadedFile.fetchUnloadedFileWithIdenticalHash): Ditto. Also fixed a bug that 404 was resulting in a rejected
promise instead of a resolved promise with null.

• public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype._reconstructTaskList): Modernized the code. Added the support for platform and
metric being null for some analysis tasks.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._didFetchTask): Don't fetch the measurement set or create a chart for custom tasks.
(AnalysisTaskPage.prototype.render): Don't display the charts or the stacking table for custom tasks.
(AnalysisTaskPage.prototype._renderTaskNameAndStatus): Don't try to show the full test name for custom tasks
since it's not associated with exactly one pair.

• public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype._renderBuildRevisionTable):
(ChartPaneStatusView.prototype._formatTime): Moved to Metric.formatTime.

• public/v3/pages/chart-pane.js:

(ChartPane.prototype._analyzeRange): Set inProgress to true to hide CustomAnalysisTaskConfigurator in
CreateAnalysisTaskPage when creating a non-custom analysis task for a specific range.

• public/v3/pages/create-analysis-task-page.js:

(CreateAnalysisTaskPage): This page now shows CustomAnalysisTaskConfigurator by default, and lets a user create
a custom analysis task by picking a test, a platform, and a set of revisions and custom darwinup roots.
(CreateAnalysisTaskPage.prototype.updateFromSerializedState): Show a message when inProgress is set. This is
the old behavior of this page.
(CreateAnalysisTaskPage.prototype.didConstructShadowTree): Added.
(CreateAnalysisTaskPage.prototype._createAnalysisTaskWithGroup): Added.
(CreateAnalysisTaskPage.prototype.render):
(CreateAnalysisTaskPage.prototype._renderMessage): Added. Hides CustomAnalysisTaskConfigurator and the select
element to specify the numebr of iterations when a message is set.
(CreateAnalysisTaskPage.htmlTemplate):
(CreateAnalysisTaskPage.cssTemplate):

• public/v3/pages/page-router.js:

(PageRouter.prototype.route): Always enqueue the page to re-render when the route has changed.

• server-tests/api-build-requests-tests.js: Updated test cases now that the response contains a list of

uploaded files associated with build requests.
*server-tests/api-commits-tests.js: Added a test case for /api/commits/<repository-name>/latest?platform=X.

• server-tests/privileged-api-create-test-group-tests.js: Added test cases for creating a custom analysis task

and a test group with custom roots.

• server-tests/resources/mock-data.js:

(MockData.addMockData): Updated the mock data to satisfy new constraint on analysis-tasks table. Also inserted
more commits, builds, and build_commits rows for testing /api/commits/<repository-name>/latest?platform=X.

• tools/js/remote.js: Include global.FormData from form-data.js.

• unit-tests/analysis-task-tests.js: Added a test for calling findByPlatformAndMetric when there is a custom

analysis task.
(sampleAnalysisTask): Removed the category since /api/analysis-tasks/ no longer generate this property.
(sampleCustomAnalysisTask): Added.

• unit-tests/build-request-tests.js:

(sampleBuildRequestData): Updated the mock response. Added a test case for fetcing custom roots.

• unit-tests/buildbot-syncer-tests.js:

(createSampleBuildRequest): Ditto.

• unit-tests/test-groups-tests.js:

(sampleTestGroup): Ditto.

2:24 PM Changeset in webkit [215201] by commit-queue@webkit.org

• 19 edits
  2 adds in trunk/Source

Add CoreAudioCaptureSource.
​https://bugs.webkit.org/show_bug.cgi?id=170112
rdar://problem/30293338

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-04-10
Source/WebCore:

Reviewed by Eric Carlson.

No new tests because this provides the same funcitonality as AVAudioCaptureSource.
Funcionality is covered by existing test cases.

Add CoreAudioCaptureSource for audio capture. And use it by default in AVCaptureDeviceManager.
Add UseAVFoundationAudioCapture setting to switch back to AVFoundation for audio capture.

• WebCore.xcodeproj/project.pbxproj:
• page/Settings.cpp:

(WebCore::Settings::useAVFoundationAudioCapture):
(WebCore::Settings::setUseAVFoundationAudioCapture):

• page/Settings.h:
• platform/mediastream/mac/AVCaptureDeviceManager.h:
• platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::setUseAVFoundationAudioCapture):

• platform/mediastream/mac/CoreAudioCaptureSource.cpp: Added.

(WebCore::CoreAudioCaptureSource::create):
(WebCore::CoreAudioCaptureSource::factory):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::preferredSampleRate):
(WebCore::CoreAudioCaptureSource::preferredIOBufferDuration):
(WebCore::CoreAudioCaptureSource::configureMicrophoneProc):
(WebCore::CoreAudioCaptureSource::configureSpeakerProc):
(WebCore::CoreAudioCaptureSource::addMicrophoneDataConsumer):
(WebCore::CoreAudioCaptureSource::removeMicrophoneDataConsumer):
(WebCore::CoreAudioCaptureSource::addEchoCancellationSource):
(WebCore::CoreAudioCaptureSource::removeEchoCancellationSource):
(WebCore::CoreAudioCaptureSource::checkTimestamps):
(WebCore::CoreAudioCaptureSource::provideSpeakerData):
(WebCore::CoreAudioCaptureSource::speakerCallback):
(WebCore::CoreAudioCaptureSource::processMicrophoneSamples):
(WebCore::CoreAudioCaptureSource::microphoneCallback):
(WebCore::CoreAudioCaptureSource::defaultOutputDevice):
(WebCore::CoreAudioCaptureSource::defaultInputDevice):
(WebCore::CoreAudioCaptureSource::setupAudioUnits):
(WebCore::CoreAudioCaptureSource::startProducingData):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSource::suspend):
(WebCore::CoreAudioCaptureSource::resume):
(WebCore::CoreAudioCaptureSource::capabilities):
(WebCore::CoreAudioCaptureSource::settings):

• platform/mediastream/mac/CoreAudioCaptureSource.h: Added.
• platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::RealtimeMediaSourceCenterMac):
(WebCore::RealtimeMediaSourceCenterMac::defaultAudioFactory):

Source/WebKit/mac:

Reviewed by Eric Carlson.

Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences useAVFoundationAudioCapture]):
(-[WebPreferences setUseAVFoundationAudioCapture:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Reviewed by Tim Horton.

Add UseAVFoundationAudioCapture preference to switch back from the new default of CoreAudio.

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUseAVFoundationAudioCapture):
(WKPreferencesGetUseAVFoundationAudioCapture):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::syncWithWebCorePrefs):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:02 PM Changeset in webkit [215200] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Wrap legacy MediaStream API in runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=169877

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-10
Reviewed by Alex Christensen.

Covered by binding tests.

Marking navigator.getUserMedia and MediaStreamEvent as runtime enabled if mediastream and webrtclegacy api flags
are on.
Updated binding generator to support multiple runtime flags.

• Modules/mediastream/MediaStreamEvent.idl:
• Modules/mediastream/NavigatorUserMedia.idl:
• bindings/scripts/CodeGeneratorJS.pm:

(GetRuntimeEnableFunctionName):
(GenerateImplementation):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

• bindings/scripts/test/TestObj.idl:

1:00 PM Changeset in webkit [215199] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-slider/volume-slider-value.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167475

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

12:59 PM Changeset in webkit [215198] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Remove deprecated parts of media stream spec
​https://bugs.webkit.org/show_bug.cgi?id=169879

Patch by Youenn Fablet <​youenn@apple.com> on 2017-04-10
Reviewed by Jon Lee.

Removing MediaStreamTrackState 'new' value which was unused.
Removing MediaStreamTrack _readonly attribute which was unused.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readonly): Deleted.

• Modules/mediastream/MediaStreamTrack.h:
• Modules/mediastream/MediaStreamTrack.idl:
• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::readonly): Deleted.

• platform/mediastream/MediaStreamTrackPrivate.h:
• platform/mediastream/RealtimeMediaSource.h:

12:53 PM Changeset in webkit [215197] by Brent Fulgham

• 4 edits
  2 adds in trunk

[WK2][macOS] Block access to Apple Events before launch.
​https://bugs.webkit.org/show_bug.cgi?id=170626
<rdar://problem/16079334>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Clear the environment of the AppleEvent server name before initializing
AppKit so we never bother connecting.

• Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:

(main):

Tools:

Add a new TestWebKitAPI test that fails if Apple Events are sent.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
• TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent.cpp: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit2/mac/InjectedBundleAppleEvent_Bundle.cpp: Added.

(TestWebKitAPI::InjectedBundleAppleEventTest::InjectedBundleAppleEventTest):
(TestWebKitAPI::InjectedBundleAppleEventTest::didCreatePage):

12:38 PM Changeset in webkit [215196] by mark.lam@apple.com

• 11 edits in trunk/Source/JavaScriptCore

Move ProbeContext and ProbeFunction out of AbstractMacroAssembler.
​https://bugs.webkit.org/show_bug.cgi?id=170681

Reviewed by Michael Saboff.

This is a refactoring step towards enabling custom probe printers the way printInternal() works for dataLog.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::ProbeContext::gpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fpr): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::gprName): Deleted.
(JSC::AbstractMacroAssembler::ProbeContext::fprName): Deleted.

• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

• assembler/MacroAssembler.h:

(JSC::ProbeContext::gpr):
(JSC::ProbeContext::fpr):
(JSC::ProbeContext::gprName):
(JSC::ProbeContext::fprName):

• assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::probe):

• assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeTrampoline):
(JSC::MacroAssemblerARM64::probe):

• assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::probe):

• assembler/MacroAssemblerPrinter.cpp:
• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::probe):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::abstractStructure):
(JSC::FTL::DFG::LowerDFGToB3::probe): Deleted.

• Deleted because this became a useless place-holder after the transition to B3.

12:01 PM Changeset in webkit [215195] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[JSC] Do not run FTL stress tests on MIPS
​https://bugs.webkit.org/show_bug.cgi?id=170684

Patch by Guillaume Emont <​guijemont@igalia.com> on 2017-04-10
Reviewed by Carlos Alberto Lopez Perez.

run-jsc-stress-tests does not correctly detect MIPS platforms, and its
logic to detect if the platform supports FTL ignores that MIPS does
not support FTL. This adds detection of MIPS (with the magic number
determined empirically) and fixes the determination of whether we
support FTL.

• Scripts/run-jsc-stress-tests:

11:34 AM Changeset in webkit [215194] by keith_miller@apple.com

• 9 edits
  2 adds
  1 delete in trunk/JSTests

WebAssembly: Update spec tests
​https://bugs.webkit.org/show_bug.cgi?id=170683

Rubber-stamped by JF Bastien.

• wasm.yaml:
• wasm/spec-tests/br_table.wast.js:
• wasm/spec-tests/conversions.wast.js: Removed.
• wasm/spec-tests/f32_bitwise.wast.js: Added.
• wasm/spec-tests/f32_cmp.wast.js:
• wasm/spec-tests/f64_bitwise.wast.js: Added.
• wasm/spec-tests/f64_cmp.wast.js:
• wasm/spec-tests/i32.wast.js:
• wasm/spec-tests/i64.wast.js:
• wasm/spec-tests/int_exprs.wast.js:
• wasm/spec-tests/memory.wast.js:

11:31 AM Changeset in webkit [215193] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

WebAssembly: Fix B3IRGenerator for BrTable
​https://bugs.webkit.org/show_bug.cgi?id=170685

Reviewed by JF Bastien.

For some reason this didn't get included in r215141.

This fixes an issue with BrTable and loops where we would use the loop's return type
as the branch target type.

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::ControlData::resultForBranch):
(JSC::Wasm::B3IRGenerator::unifyValuesWithBlock):

11:11 AM Changeset in webkit [215192] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Placeholder text is clipped in the 'Enter Class Name' field at the bottom of Rules style sidebar in some localizations
​https://bugs.webkit.org/show_bug.cgi?id=167641
<rdar://problem/26541953>

Reviewed by Joseph Pecoraro.

Make the "Enter Class Name" text field span the entire width of the Styles sidebar.

• UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon): Deleted.
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class.active > .add-class-icon,): Deleted.

• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
Remove the checkbox, which didn't do anything, and the plus icon. Make the "Enter Class Name" text field visible by default.

11:11 AM Changeset in webkit [215191] by Jonathan Bedard

• 2 edits in trunk/Tools

webkitpy: Increase estimate for processes run by iOS Simulators
​https://bugs.webkit.org/show_bug.cgi?id=170678
<rdar://problem/31534061>

Reviewed by Aakash Jain.

Previously, it was estimated that each simulated iOS device would run about 100
processes. With newer versions of iOS, this is closer to 125.

• Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort): Increase process estimate from 100 to 125.

11:06 AM Changeset in webkit [215190] by commit-queue@webkit.org

• 5 edits in trunk

[GTK] Misplaced right click menu on web page due to deprecated gtk_menu_popup()
​https://bugs.webkit.org/show_bug.cgi?id=170553

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-10
Reviewed by Michael Catanzaro.

Source/WebKit2:

Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when building with GTK+ 3.22 or
newer. This allows the Wayland GTK+ backend to properly position popup menus, and also avoids
using functions which were deprecated starting at that GTK+ release.

• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::show): Use gtk_menu_popup_at_pointer() as there is always a
pointer event that can be passed to it.

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_popup_at_rect(), using the coordinates
of the control passed as reference rectangle. Some conditional code is needed because with newer
GTK+ versions a relative offset instead of an absolute position is needed.

Tools:

Use gtk_menu_popup_at_pointer() and gtk_menu_popup_at_rect() when
building with GTK+ 3.22 or newer. This allows the Wayland GTK+ backend
to properly position popup menus, and also avoids using functions
which were deprecated starting at that GTK+ release.

• MiniBrowser/gtk/BrowserSearchBar.c:

(searchEntryMenuIconPressedCallback):
Update MiniBrowser to use gtk_menu_popup_at_pointer().

10:58 AM Changeset in webkit [215189] by Wenson Hsieh

• 9 edits in trunk

REGRESSION (r214403): fast/events/drag-to-navigate.html and fast/events/only-valid-drop-targets-receive-file-drop.html failing
​https://bugs.webkit.org/show_bug.cgi?id=170677
<rdar://problem/31512633>

Reviewed by Tim Horton.

Tools:

Fixes two drag and drop LayoutTests by introducing and enabling a TestOptions switch (enableDragDestinationActionLoad)
to allow dropping URLs to trigger page navigation.

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

• DumpRenderTree/mac/UIDelegate.h:
• DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate resetToConsistentStateBeforeTesting:]):
(-[UIDelegate webView:dragDestinationActionMaskForDraggingInfo:]):

LayoutTests:

Turn enableDragDestinationActionLoad on in these two LayoutTests via WKTR options.

• fast/events/drag-to-navigate.html:
• fast/events/only-valid-drop-targets-receive-file-drop.html:

10:55 AM Changeset in webkit [215188] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

[GTK] Opening a popup menu does not pre-select the active item
​https://bugs.webkit.org/show_bug.cgi?id=170680

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-04-10
Reviewed by Michael Catanzaro.

• UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use gtk_menu_shell_select_item() to
ensure that the active item appears selected right after popping up the menu.

10:54 AM Changeset in webkit [215187] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/volume-up-support/volume-up-support.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=170682

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

10:35 AM Changeset in webkit [215186] by commit-queue@webkit.org

• 2 edits in trunk/Tools

update-webkit-dependency should report $response->message for diagnose
​https://bugs.webkit.org/show_bug.cgi?id=170666

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-10
Reviewed by Alex Christensen.

• Scripts/update-webkit-dependency: Print $response->message to STDERR if an error happens.

10:28 AM Changeset in webkit [215185] by Ryan Haddad

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r215175.

This change caused a flaky crash in existing media tests.

Reverted changeset:

"Add fallback fonts to video captions stylesheet."
​https://bugs.webkit.org/show_bug.cgi?id=170495
​http://trac.webkit.org/changeset/215175

10:07 AM Changeset in webkit [215184] by Wenson Hsieh

• 5 edits
  1 add in trunk

Data interaction on an image enclosed by an anchor should vend the anchor's URL
​https://bugs.webkit.org/show_bug.cgi?id=170660
<rdar://problem/31043220>

Reviewed by Tim Horton.

Source/WebCore:

When writing an image embedded inside an anchor to the pasteboard, actually use the enclosing anchor's href if
it exists. Previously, we were simply dropping this argument on the floor.

Covered by 2 new DataInteractionTests: ImageInLinkToInput and ImageInLinkWithoutHREFToInput.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

Tools:

Adds two new unit tests covering cases where data interaction is triggered from an image nested underneath an
anchor. In one of the tests, the link has an href, and in the other, its href is missing, in which case we
should fall back to the image URL instead. Also fixes a related unit test that was trying to check selection
rects, but should not be.

See WebCore ChangeLog for more details.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/image-in-link-and-input.html: Added.
• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

9:44 AM Changeset in webkit [215183] by Ryan Haddad

• 4 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r215131.

Unreviewed test gardening.

• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:

9:05 AM Changeset in webkit [215182] by jonlee@apple.com

• 7 edits in trunk/Source

Update localizable strings to "full screen" from "fullscreen"
​https://bugs.webkit.org/show_bug.cgi?id=170675
rdar://problem/28207034

Reviewed by Antoine Quint.

Source/WebCore:

For localizable strings, it should consistently be "full screen" instead of "fullscreen".

• English.lproj/Localizable.strings:
• English.lproj/modern-media-controls-localized-strings.js:
• platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagExitVideoFullscreen):
(WebCore::localizedMediaControlElementString):

• platform/cocoa/LocalizedStringsCocoa.mm:

(WebCore::exitFullScreenButtonAccessibilityTitle):

Source/WebInspectorUI:

• UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName): For localizable strings, it should consistently be
"full screen" instead of "fullscreen".

6:49 AM Changeset in webkit [215181] by akling@apple.com

• 11 edits
  2 adds in trunk

Don't generate extra scrolling tiles for non-visible pages.
​https://bugs.webkit.org/show_bug.cgi?id=167213
<rdar://problem/30105774>

Reviewed by Antti Koivisto.

Source/WebCore:

Reduce the tiling coverage to a minimum when the page is non-visible.
On macOS, this means that fully occluded web views can maintain a smaller set of tiles
in non-volatile surfaces, reducing net footprint.

Test: compositing/tiling/non-visible-window-tile-coverage.html

• rendering/RenderLayerBacking.cpp:

(WebCore::computePageTiledBackingCoverage): If the page's activity state is non-visible, use minimal tile coverage.

• platform/ScrollView.h:
• page/FrameView.h:
• page/FrameView.cpp:

(WebCore::FrameView::hide): Call adjustTiledBackingCoverage() in hide() since it now takes page visibility into account.

(WebCore::FrameView::enableSpeculativeTilingIfNeeded):

• testing/Internals.cpp:

(WebCore::Internals::setSpeculativeTilingDelayDisabledForTesting):

• testing/Internals.h:
• testing/Internals.idl: Add an internals API for disabling the 500ms delay before speculative tiling begins after

the main frame load finishes. This is needed for reliably testing this change.

LayoutTests:

• TestExpectations:
• compositing/tiling/non-visible-window-tile-coverage-expected.txt: Added.
• compositing/tiling/non-visible-window-tile-coverage.html: Added.
• platform/mac-wk2/TestExpectations:

5:55 AM Changeset in webkit [215180] by berto@igalia.com

• 2 edits in trunk/Source/WTF

[GTK] Fix x32 build
​https://bugs.webkit.org/show_bug.cgi?id=170673

Patch by Thorsten Glaser <​tg@mirbsd.de> on 2017-04-10
Reviewed by Carlos Alberto Lopez Perez.

• wtf/Platform.h:

4:48 AM Changeset in webkit [215179] by Carlos Garcia Campos

• 3 edits
  6 adds
  1 delete in trunk/Tools

[GTK] Remove the GDK dependency from ImageDiff
​https://bugs.webkit.org/show_bug.cgi?id=85299

Reviewed by Žan Doberšek.

Add a cairo only implementation of ImageDiff. We currently have 3 different implementations of ImageDiff: the
Gdk based one used by GTK+ port, the cairo based one used by WinCairo and the CG based one. Most of the code is
actually common in all of them, but it's duplicated. So, I've taken advantage of this patch to refactor the
ImageDiff code to share the common implementation. This patch adds the cross-platform code, and the cairo
implementation and enables it in the GTK+ port. In follow up patches we can move WinCairo to this implementation
and also add CG implementation.

• ImageDiff/CMakeLists.txt:
• ImageDiff/Cairo.cmake: Added.
• ImageDiff/ImageDiff.cpp: Added.

(main):

• ImageDiff/PlatformGTK.cmake:
• ImageDiff/PlatformImage.cpp: Added.

(ImageDiff::PlatformImage::isCompatible):
(ImageDiff::PlatformImage::difference):

• ImageDiff/PlatformImage.h: Added.
• ImageDiff/cairo/PlatformImageCairo.cpp: Added.

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

• ImageDiff/gtk/ImageDiff.cpp: Removed.

4:44 AM Changeset in webkit [215178] by Carlos Garcia Campos

• 4 edits in trunk

REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426
​https://bugs.webkit.org/show_bug.cgi?id=170667

Reviewed by Žan Doberšek.

Tools:

In r214666 we disabled modern media controls runtime feature for the GTK+ port, but layout tests still override
that value.

• WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest): Disable modern media controls.

LayoutTests:

Unskip then test that is passing now.

• platform/gtk/TestExpectations:

4:04 AM Changeset in webkit [215177] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] Enable DOM timer throttling and CSS animations suspension
​https://bugs.webkit.org/show_bug.cgi?id=170669

Reviewed by Žan Doberšek.

• Shared/WebPreferencesDefinitions.h:

3:16 AM Changeset in webkit [215176] by commit-queue@webkit.org

• 9 edits in trunk/Tools

WTR: Avoid conversion from platform image to WKImage and then to platform image again when dumping pixel results
​https://bugs.webkit.org/show_bug.cgi?id=170653

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-04-10
Reviewed by Tim Horton.

When dumping pixels from a web view snapshot, we create a platform image that is then converted to a WKImage,
which is a ShareableBitmap, so the image is rendered into a graphics context. Then we immediately extract the
platform image back from the WKImage to dump the pixels. We could avoid that conversion by taking the web
snapshot from TestInvocation::dumpPixelsAndCompareWithExpected().

• WebKitTestRunner/PlatformWebView.h: Add PlatformImage typedef and use it as return value of windowSnapshotImage().
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::dumpResults): Pass the WKImage to dumpPixelsAndCompareWithExpected() only when pixel
results were created in the web process.

• WebKitTestRunner/TestInvocation.h: Make WKImage a default paramater of dumpPixelsAndCompareWithExpected().
• WebKitTestRunner/cairo/TestInvocationCairo.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the cairo surface from the given WKimage in case
of web contents snapshot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.

• WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromCGImage): Changed to receive a CGImageRef and renamed.
(WTR::createCGContextFromImage): Get the CGImageRef from the WKImage and call createCGContextFromCGImage().
(WTR::paintRepaintRectOverlay): It receives now the image size instead of the WKImage.
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create the CGContextRef from the WKImage in case of web
contents snpashot, and use PlatformWebView::windowSnapshotImage() in case of web view snapshot.

• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::windowSnapshotImage): Return the cairo surface instead of creating a WKImage. Also use
RGB24 format to match what mac does (kCGWindowImageShouldBeOpaque).

• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage): Return the CGImageRef instead of creating a WKImage.

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage): Ditto.

3:01 AM Changeset in webkit [215175] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

Add fallback fonts to video captions stylesheet.
​https://bugs.webkit.org/show_bug.cgi?id=170495

Reviewed by Myles C. Maxfield.

The kCTFontCascadeListAttribute key is used to obtain the cascade list for a font reference.

I have not added a test, since CaptionUserPreferences::testingMode() returns true when running tests,
preventing this code path from being executed.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsDefaultFontCSS):

1:28 AM Changeset in webkit [215174] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Mark several tests as failing/timing out.

• platform/gtk/TestExpectations:

1:02 AM Changeset in webkit [215173] by Chris Dumez

• 130 edits in trunk

Drop Timer::startOneShot() overload taking a double
​https://bugs.webkit.org/show_bug.cgi?id=170659

Reviewed by Yusuke Suzuki.

Drop Timer::startOneShot() overload taking a double as people should use Seconds type now.

Source/WebCore:

• Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::startTimerIfNeeded):

• Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::configureWatchdogTimer):

• Modules/mediasession/WebMediaSessionManager.h:
• Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

• Modules/vibration/Vibration.cpp:

(WebCore::Vibration::timerFired):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::close):

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::enqueuePasswordValueChangeNotification):
(WebCore::AXObjectCache::postLiveRegionChangeNotification):
(WebCore::AXObjectCache::focusAriaModalNode):

• css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setStatus):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

• dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::finishedParsing):

• dom/ScriptedAnimationController.cpp:
• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::startAlternativeTextUITimer):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):
(WebCore::HTMLMediaElement::handleSeekToPlaybackPosition):

• html/SearchInputType.cpp:

(WebCore::SearchInputType::startSearchEventTimer):

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer):

• html/canvas/WebGLRenderingContextBase.cpp:
• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::startTimer):
(WebCore::MediaControlPanelElement::makeTransparent):

• html/track/VTTRegion.cpp:

(WebCore::VTTRegion::startTimer):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameScheduledNavigation):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameScheduledNavigation):

• inspector/InspectorPageAgent.h:
• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::startTimer):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::documentDidFinishLoadEvent):

• loader/icon/IconDatabase.cpp:
• page/EventHandler.cpp:
• page/EventSource.cpp:

(WebCore::EventSource::scheduleReconnect):

• page/FocusController.cpp:

(WebCore::FocusController::setFocusedElementNeedsRepaint):

• page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::enableSpeculativeTilingIfNeeded):

• page/Settings.cpp:

(WebCore::Settings::Settings):

• page/Settings.h:

(WebCore::Settings::setTimeWithoutMouseMovementBeforeHidingControls):
(WebCore::Settings::timeWithoutMouseMovementBeforeHidingControls):

• page/SuspendableTimer.h:
• page/animation/CSSAnimationController.cpp:
• page/mac/EventHandlerMac.mm:
• page/mac/TextIndicatorWindow.mm:

(WebCore::TextIndicatorWindow::setTextIndicator):

• platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::stop):

• platform/ScrollAnimationSmooth.cpp:

(WebCore::getAnimationParametersForGranularity):
(WebCore::ScrollAnimationSmooth::updatePerAxisData):
(WebCore::ScrollAnimationSmooth::animateScroll):
(WebCore::ScrollAnimationSmooth::animationTimerFired):
(WebCore::ScrollAnimationSmooth::startNextTimer):

• platform/ScrollAnimationSmooth.h:
• platform/Timer.h:

(WebCore::TimerBase::startRepeating):

• platform/audio/PlatformMediaSession.cpp:

(WebCore::PlatformMediaSession::scheduleClientDataBufferingCheck):

• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::scheduleStatelessScrollSnap):

• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::gamepadHadInput):

• platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::openAndScheduleManager):
(WebCore::HIDGamepadProvider::valuesChanged):

• platform/glib/MainThreadSharedTimerGLib.cpp:

(WebCore::MainThreadSharedTimer::setFireInterval):

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::startTimer):
(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::advanceAnimation):
(WebCore::BitmapImage::resetAnimation):

• platform/graphics/BitmapImage.h:
• platform/graphics/MediaPlaybackTargetPicker.cpp:
• platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::scheduleScratchBufferPurge):

• platform/graphics/ca/LayerPool.cpp:

(WebCore::LayerPool::schedulePrune):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):

• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3DManager::updateHighPerformanceState):

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::scheduleReleaseUnusedTextures):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::scheduleReleaseUnusedBuffers):
(WebCore::TextureMapperPlatformLayerProxy::releaseUnusedBuffersTimerFired):

• platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
• platform/gtk/ScrollAnimatorGtk.cpp:

(WebCore::ScrollAnimatorGtk::overlayScrollbarAnimationTimerFired):
(WebCore::ScrollAnimatorGtk::showOverlayScrollbars):
(WebCore::ScrollAnimatorGtk::hideOverlayScrollbars):

• platform/gtk/ScrollAnimatorGtk.h:
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):

• platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::startScrollbarPaintTimer):

• platform/mock/MediaPlaybackTargetPickerMock.cpp:
• platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::speak):

• platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::TimerEvent):

• platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):

• platform/network/PingHandle.h:
• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):

• platform/network/mac/NetworkStateNotifierMac.cpp:
• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::sendPendingRequest):

• rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::restartTimer):

• rendering/RenderLayerCompositor.cpp:
• rendering/RenderProgress.cpp:

(WebCore::RenderProgress::RenderProgress):

• rendering/RenderProgress.h:
• rendering/RenderText.cpp:

(WebCore::SecureTextTimer::restart):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::animationRepeatIntervalForProgressBar):

• rendering/RenderTheme.h:

(WebCore::RenderTheme::mediaControlsFadeOutDuration):

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::animationRepeatIntervalForProgressBar):

• rendering/RenderThemeGtk.h:
• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::animationRepeatIntervalForProgressBar):

• rendering/RenderThemeMac.h:
• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):

• replay/EventLoopInputDispatcher.cpp:

(WebCore::EventLoopInputDispatcher::dispatchInputSoon):

• svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::startTimer):

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::setTimeWithoutMouseMovementBeforeHidingControls):

• testing/InternalSettings.h:
• testing/Internals.cpp:

(WebCore::Internals::setImageFrameDecodingDuration):

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit:

• Storage/StorageAreaSync.cpp:
• Storage/StorageTracker.cpp:

(WebKit::StorageTracker::StorageTracker):

• Storage/StorageTracker.h:

(WebKit::StorageTracker::storageDatabaseIdleInterval):
(WebKit::StorageTracker::setStorageDatabaseIdleInterval):

Source/WebKit/mac:

• Plugins/WebNetscapePluginView.mm:

(PluginTimer::start):

• Storage/WebStorageManager.mm:

(+[WebStorageManager setStorageDatabaseIdleInterval:]):

Source/WebKit/win:

• Plugins/PluginMessageThrottlerWin.cpp:

(WebCore::PluginMessageThrottlerWin::appendMessage):
(WebCore::PluginMessageThrottlerWin::messageThrottleTimerFired):

• Plugins/PluginViewWin.cpp:

(WebCore::PluginView::invalidateRect):

• WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::scheduleLayerFlush):

Source/WebKit2:

• NetworkProcess/PingLoad.h:
• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::startTimeout):

• Platform/IPC/Connection.h:
• Platform/IPC/mac/ConnectionMac.mm:

(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
(IPC::Connection::terminateSoon):

• PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::setMinimumLifetime):

• PluginProcess/PluginProcess.h:
• Shared/ChildProcess.cpp:

(WebKit::ChildProcess::ChildProcess):

• Shared/ChildProcess.h:

(WebKit::ChildProcess::setTerminationTimeout):

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::startUpdateTimer):

• Shared/Plugins/PluginProcessCreationParameters.h:
• Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::initializeTimers):

• Shared/WebProcessCreationParameters.h:
• UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm:

(API::SharedJSContext::ensureContext):

• UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::shutDownProcess):

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

• UIProcess/Cocoa/ViewGestureController.cpp:

(WebKit::ViewGestureController::SnapshotRemovalTracker::startWatchdog):

• UIProcess/Cocoa/ViewGestureController.h:
• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::start):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::didDraw):

• UIProcess/Gamepad/UIGamepadProvider.cpp:
• UIProcess/Plugins/PluginProcessProxy.cpp:
• UIProcess/ProcessThrottler.cpp:
• UIProcess/ResponsivenessTimer.cpp:
• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::createNewWebProcess):

• UIProcess/gtk/GestureController.cpp:

(WebKit::GestureController::DragGesture::begin):

• UIProcess/mac/WebInspectorProxyMac.mm:
• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scheduleAnimation):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

• WebProcess/WebProcess.cpp:

Tools:

• TestWebKitAPI/Tests/WTF/RunLoop.cpp:

(TestWebKitAPI::TEST):

• WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):

12:39 AM Changeset in webkit [215172] by magomez@igalia.com

• 6 edits in trunk

REGRESSION(r205841): [GTK] Test fast/images/animated-png.html is failing since r205841
​https://bugs.webkit.org/show_bug.cgi?id=168425

Reviewed by Said Abou-Hallawa.

Source/WebCore:

There is a problem with animations that are blending their frames into the previous frame. Due to a change
in how pixel components are premultiplied (the result is now rounded up), the parameters to the blending
operation may vary in one unit, causing the result of the blending to be different from the expected result.
In order to fix this, a new parameter is added to indicate whether we want to use rounding up when
premultiplying or not, and ImageBackingStore uses that parameter to disable rounding up.

Adjusted the expectation for fast/images/animated-png.html, as it must pass now.

• platform/graphics/Color.cpp:

(WebCore::premultipliedChannel):
(WebCore::makePremultipliedRGBA):

• platform/graphics/Color.h:
• platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue):

LayoutTests:

Adjusted expectation for fast/images/animated-png.html. It must pass now.

• platform/gtk/TestExpectations: