⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 24, 2017:

9:18 PM Changeset in webkit [217407] by Chris Dumez
  • 3 edits
    2 adds in trunk

ResourceResponses for data URLs have their Source marked as Unknown
​https://bugs.webkit.org/show_bug.cgi?id=172573
<rdar://problem/31786198>

Reviewed by Geoffrey Garen.

Source/WebCore:

ResourceResponses for data URLs have their Source marked as Unknown.

Now set their source to Network to maintain previous behavior when
we used to decode those data URLs on Network process side.

Test: fast/url/data-url-source.html

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):

LayoutTests:

Add layout test coverage.

  • fast/url/data-url-source-expected.txt: Added.
  • fast/url/data-url-source.html: Added.
8:54 PM Changeset in webkit [217406] by commit-queue@webkit.org
  • 4 edits in trunk

[Win] An assertion fails if the custom cursor image isn't loaded yet
​https://bugs.webkit.org/show_bug.cgi?id=172209

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-24
Reviewed by Said Abou-Hallawa.

Source/WebCore:

Test: fast/css/crash-on-custom-cursor-when-loading.html

A custom cursor image can be zero dimension if it is loading or
decoding. Cursor::ensurePlatformCursor of Windows port should
handle such case properly.

  • platform/win/CursorWin.cpp:

(WebCore::Cursor::ensurePlatformCursor): Load a stock cursor if
the custom cursor image has zero dimension. Do not do null-check
of the return value of createSharedCursor() because it never
returns null.

LayoutTests:

Windows port have the same issue Qt port had had several years ago
(Bug 68223). I'd like to reuse the test case. But, current CSS
parser rejects invalid 'cursor' property value which consists of
a single URL but no keywords.

  • fast/css/crash-on-custom-cursor-when-loading.html: Fix invalid

'cursor' property by appending a fallback keyword.

8:39 PM Changeset in webkit [217405] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Increase the headerpad for WebKit XPC Services
​https://bugs.webkit.org/show_bug.cgi?id=172571

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-24
Reviewed by Dan Bernstein.

  • Configurations/BaseXPCService.xcconfig:

Increase the headerpad to make room for additional dyld commands.

7:16 PM Changeset in webkit [217404] by commit-queue@webkit.org
  • 14 edits
    1 add in trunk

[CMake] Consolidate CMake code related to Cairo
​https://bugs.webkit.org/show_bug.cgi?id=172568

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-05-24
Reviewed by Alex Christensen.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

No new tests. No change in behavior.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • PlatformWinCairo.cmake:
  • config.h:
  • platform/Cairo.cmake: Added.
  • platform/GStreamer.cmake:
  • platform/ImageDecoders.cmake:

Tools:

  • DumpRenderTree/config.h:
  • TestWebKitAPI/config.h:
5:58 PM Changeset in webkit [217403] by Ryan Haddad
  • 2 edits in branches/safari-604.1.21-branch/Tools

Merge r217165.

5:58 PM Changeset in webkit [217402] by Ryan Haddad
  • 4 edits in branches/safari-604.1.21-branch/Tools

Merge r217147.

5:48 PM Changeset in webkit [217401] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

5:47 PM Changeset in webkit [217400] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.21.9

Tag Safari-604.1.21.9.

5:25 PM Changeset in webkit [217399] by jmarcell@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

5:23 PM Changeset in webkit [217398] by jmarcell@apple.com
  • 1 copy in tags/Safari-603.3.2

Tag Safari-603.3.2.

4:54 PM Changeset in webkit [217397] by rniwa@webkit.org
  • 6 edits in trunk/Websites/perf.webkit.org

Opening an analysis task from the queue page is broken
​https://bugs.webkit.org/show_bug.cgi?id=172559
<rdar://problem/32389708>

Rubber-stamped by Chris Dumez.

Fix the bug that opening the analysis task page from the queue page results in multiple assertion failures
as well as the list of test groups in the analysis task page not getting updated.

  • public/v3/models/build-request.js:

(BuildRequest.prototype.updateSingleton): Because /api/build-requests/ do not include test groups, it's
possible for testGroup to be dynamically updated upon loading an analysis task page. Update _testGroup in
such instances instead of asserting that it doesn't happen.

  • public/v3/models/data-model.js:

(DataModelObject.cachedFetch): Because various code to create model objects from the result of a JSON API
modify the fetched content in irreversible manner, e.g. object.platform = Platform.findById(object.platform)
we must return a fresh new content each time even if the result had been cached.

  • public/v3/models/test-group.js:

(TestGroup.prototype.platform): Return this._platform as that's not available.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage):
(AnalysisTaskPage.prototype._resetVariables): Extracted from the constructor.
(AnalysisTaskPage.prototype.updateFromSerializedState): Reset all instance variables when opening a new
analysis task page. This would avoid showing the stale result even when fetching new test groups had failed.

  • unit-tests/test-groups-tests.js: Added a test case for fetching the same test group twice. This used to hit

a problem in BuildRequest.constructBuildRequestsFromData which overrode platform property of each raw content
with a Platform model object because in the case of a cached fetch, we end up trying to look up the platform
again using the result of stringifying the Platform object instead of the platform ID included in the original
fetched content.
(sampleTestGroup): Added "platform" as included in the JSON API's response now.

4:52 PM Changeset in webkit [217396] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

The commit log viewer can overlap the analysis results viewer
​https://bugs.webkit.org/show_bug.cgi?id=172534

Rubber-stamped by Chris Dumez.

Allocate the padding on the right for the commit log viewer, and add a horizontal scrollbar
to the analysis results viewer instead of letting it expand beneath the commit log viewer.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskResultsPane.htmlTemplate):
(AnalysisTaskResultsPane.cssTemplate):

4:24 PM Changeset in webkit [217395] by jmarcell@apple.com
  • 6 edits in branches/safari-604.1.21-branch

Cherry-pick r217382. rdar://problem/32380083

4:21 PM Changeset in webkit [217394] by bshafiei@apple.com
  • 8 edits in branches/safari-604.1.21-branch/Source

Roll out r217382. rdar://problem/32380083

4:14 PM Changeset in webkit [217393] by bshafiei@apple.com
  • 8 edits in branches/safari-604.1.21-branch/Source

Merged r217382. rdar://problem/32380083

4:13 PM Changeset in webkit [217392] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION (r206481): Don't assume frameCount() is larger than or equal to the size of the image frame cache
​https://bugs.webkit.org/show_bug.cgi?id=172552

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-05-24
Reviewed by Geoffrey Garen.

If an image with many cached ImageFrames is cached but its encoded data is
freed, then the same image is reused, the encoded data will be fetched.
But the initial frameCount() might be less than the current size of the
ImageFrames cache.

This was causing an assertion in the debug build and crash in the release
build. Vector::grow() does not handle the case where the new size is smaller
than the current size safely.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::growFrames):

4:05 PM Changeset in webkit [217391] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

navigator.webdriver should return false if the page is not controlled by automation
​https://bugs.webkit.org/show_bug.cgi?id=171997

Patch by Sergey Shekyan <​shekyan@gmail.com> on 2017-05-24
Reviewed by Chris Dumez.

Per WebDriver Specification at ​https://www.w3.org/TR/webdriver/#interface

Test: js/dom/navigator-webdriver.html
Rebaseled fast/dom/navigator-detached-no-crash.html

  • Modules/webdriver/NavigatorWebDriver.cpp:

(WebCore::NavigatorWebDriver::NavigatorWebDriver):
(WebCore::NavigatorWebDriver::isControlledByAutomation):
(WebCore::NavigatorWebDriver::from):
(WebCore::NavigatorWebDriver::webdriver):
(WebCore::JSNavigator::webdriver): Deleted.

  • Modules/webdriver/NavigatorWebDriver.h:
  • Modules/webdriver/NavigatorWebDriver.idl:
3:53 PM Changeset in webkit [217390] by ap@apple.com
  • 1155 edits
    710 deletes in trunk/LayoutTests

Merge split script tests
​https://bugs.webkit.org/show_bug.cgi?id=172423

Reviewed by Sam Weinig.

In the past, many tests were being split into HTML and JS parts for no good reason.
This makes it hard to see what those tests are doing.

This is first part of the change, only including files where JS and HTML counterparts
have matching names. Custom cases will be completed in a follow-up.

Long change list omitted.

2:59 PM Changeset in webkit [217389] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Provide details on javascript exception
​https://bugs.webkit.org/show_bug.cgi?id=161187

Patch by David Keijser <​keijser@gmail.com> on 2017-05-24
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptCallback):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):

2:35 PM Changeset in webkit [217388] by Ryan Haddad
  • 4 edits in trunk/Source

Unreviewed, suppress deprecation warnings to fix the build.

Source/WebCore:

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::linearRGBColorSpaceRef):

Source/WebKit2:

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::decode):

2:35 PM Changeset in webkit [217387] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch.html as failing on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=172547

Unreviewed test gardening.

  • platform/ios/TestExpectations:
1:28 PM Changeset in webkit [217386] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for garbage collect and clean buttons in Console
​https://bugs.webkit.org/show_bug.cgi?id=167356

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-24
Reviewed by Michael Catanzaro.

  • UserInterface/Images/gtk/NavigationItemClear.svg: Aligned for 16x16 dimension.
  • UserInterface/Images/gtk/NavigationItemGarbageCollect.svg: Added.
  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView): Removed the Clear image dimension's conditional expression.

  • UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView): Ditto.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView): Ditto.

12:43 PM Changeset in webkit [217385] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Sycning script build fix after r217378.

  • tools/sync-buildbot.js:

(syncLoop):

12:32 PM Changeset in webkit [217384] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Disable memory kill mechanisms when running with FastMalloc disabled.
​https://bugs.webkit.org/show_bug.cgi?id=172550
<rdar://problem/32181908>

Reviewed by Antti Koivisto.

If someone is using WebKit with a non-standard allocator, they are likely trying to debug
or test something, and suddenly getting killed is not gonna help with that.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::setShouldUsePeriodicMemoryMonitor):

12:25 PM Changeset in webkit [217383] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r217172. rdar://problem/32380123

12:01 PM Changeset in webkit [217382] by Wenson Hsieh
  • 10 edits in trunk

Plumb additional image metadata to item providers when beginning data interaction on an image
​https://bugs.webkit.org/show_bug.cgi?id=172536
<rdar://problem/32371300>

Reviewed by Beth Dakin.

Source/WebCore:

Plumb suggestedName (the last path component of the image's source URL) and size (the actual size of the image)
to item providers when beginning data interaction on an image.

Augments existing unit tests to cover these changes -- see DataInteractionTests.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

  • platform/Pasteboard.h:
  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::writeObjectRepresentations):

  • platform/ios/WebItemProviderPasteboard.h:
  • platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderRegistrationInfoList init]):
(-[WebItemProviderPasteboard setItemsUsingRegistrationInfoLists:]):
(temporaryFileURLForDataInteractionContent):

Source/WebKit2:

Boilerplate plumbing to send suggestedName over IPC.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PasteboardImage>::encode):
(IPC::ArgumentCoder<PasteboardImage>::decode):

Tools:

Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
source item providers.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(checkSuggestedNameAndEstimatedSize):
(TestWebKitAPI::TEST):

11:56 AM Changeset in webkit [217381] by eric.carlson@apple.com
  • 4 edits
    1 add in trunk/Source/WebCore

CoreAudioCaptureSource is ducking system sound
​https://bugs.webkit.org/show_bug.cgi?id=172512

Reviewed by Youenn Fablet.

Manual testing.

  • Configurations/WebCore.xcconfig: Adding CoreAudio as framework for iOS.
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::setupAudioUnit):
(WebCore::CoreAudioSharedUnit::defaultOutputDevice):

  • platform/spi/cf/CoreAudioSPI.h: Added.
11:54 AM Changeset in webkit [217380] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[WPE] Rebaseline test

Unreviewed gardening after a series of changes to dom static properties.

  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
11:53 AM Changeset in webkit [217379] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't load the active recording until a Timeline view needs to be shown
​https://bugs.webkit.org/show_bug.cgi?id=172467

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView):
(WebInspector.TimelineTabContentView.prototype.restoreFromCookie):
(WebInspector.TimelineTabContentView.prototype._showTimelineViewForType):
Move the call to _recordingLoaded to when a timeline view needs to be shown and only if
_displayedRecording isn't already set. This delays the creation of the content view for
the recording to right before it needs to be displayed.

11:47 AM Changeset in webkit [217378] by rniwa@webkit.org
  • 14 edits
    1 add in trunk/Websites/perf.webkit.org

Add the support for perf try bots to sync-buildbot.js
​https://bugs.webkit.org/show_bug.cgi?id=172529

Rubber-stamped by Chris Dumez.

Make sync-buildbot.js schedule an A/B testing job with a patch or roots to buildbot.

Change the buildbot property format in the syncing script's configuration again to use a dictionary
with a single key of "revision", "patch", or "roots" to specify a revision, a patch, or a set of roots,
and simplified the structure of the configuration by always having "types" and "builders", and
make each entry in "configurations" refer to a list of types, platforms, and builders.

Since now there are build requests to build patches and run tests, "configurations" has been renamed to
"testConfigurations" and "buildConfigurations" have been added. Each entry in "buildConfigurations"
specifies a list of platforms and builders. Similarly in repository group configurations, the buildbot
properties for testing is now specified as "testProperties" and ones for building a patch is specified
in newly introduced "buildProperties".

  • public/api/build-requests.php:

(update_builds): When a build request to build a patch fails, mark all subsequent requests as failed
since there is no way to run tests without a successful build.

  • public/api/update-triggerable.php:

(main): Re-generate manifest.json after updating the triggerable. The lack of this re-generation was
the reason we had to manually GET /api/manifest in api-update-triggerable-tests.js.

  • public/v3/models/build-request.js:

(BuildRequest.prototype.hasCompleted): Added.

  • public/v3/models/manifest.js:

(Manifest.reset): Added. Extracted from MockData.resetV3Models in unit-tests/mock-data.js and
syncLoop in tools/sync-buildbot.js
(Manifest.fetch): Reset V3 models before fetching the manifest. This eliminates the need to manually
reset V3 models in syncLoop.

  • public/v3/models/uploaded-file.js:

(UploadedFile.prototype.url): Use RemoteAPI.url to get the full URL instead of just a path.

  • public/v3/remote.js:

(BrowserRemoteAPI.prototype.url): Added. Constructs the full URL.

  • server-tests/api-update-triggerable-tests.js:

(.refetchManifest): Deleted. Now that /api/manifest re-generates manifest.json, we can simply call
Manifest.fetch instead.

  • server-tests/resources/mock-data.js:

(MockData.resetV3Models): Calls Manifest.reset().
(MockData.addMockConfiguration): Extracted from addMockData.
(MockData.addMockData): Updated per the format change.
(MockData.mockTestSyncConfigWithSingleBuilder): Ditto.
(MockData.mockTestSyncConfigWithTwoBuilders): Ditto.
(MockData.runningBuild): Make buildNumber specifiable.
(MockData.finishedBuild): Ditto.

  • server-tests/tools-buildbot-triggerable-tests.js: Updated configurations per the format change.

Now that now acceptsCustomRoots() for "system-and-webkit" must be true since we can't have a
repository group that which accepts a patch and not take roots.

  • server-tests/tools-sync-buildbot-integration-tests.js: Added.

(createTriggerable): Added.
(createTestGroupWihPatch): Added.
(uploadRoot): Added.
(.assertAndResolveRequest): Added.
(.assertTestBuildHasFailed): Added.

  • tools/js/buildbot-syncer.js:

(BuildbotSyncer): Added. _type as an instance variable to identify whether this buildbot builder
is a "builder" which builds a patch, builder, or a "tester" which runs a test. Also renamed
_testConfigurations to _configurations.
(BuildbotSyncer.prototype.addTestConfiguration): Assert that either the type of this syncer hasn't
been set or it's a tester.
(BuildbotSyncer.prototype.testConfigurations): Return [] when it's a builder.
(BuildbotSyncer.prototype.addBuildConfiguration): Added. Adds a platform to a builder.
(BuildbotSyncer.prototype.buildConfigurations): Added. Returns the list of configurations if this
syncer is a builder. Otherwise returns [].
(BuildbotSyncer.prototype.isTester): Added.
(BuildbotSyncer.prototype.matchesConfiguration):
(BuildbotSyncer.prototype._propertiesForBuildRequest): Updated to support the new format.
(BuildbotSyncer._loadConfig): Ditto. Optionally parse buildConfigurations.
(BuildbotSyncer._resolveBuildersWithPlatforms): Added. For each test or build configuration entry,
creates the list of configurations per builder and platform.
(BuildbotSyncer._parseRepositoryGroup): Added the support for parsing the new format with revision,
roots, and patch option types with a lot of validations as we're seeing a bit of combinatorial
explosion in the number of things that can go wrong. Also parse buildProperties optionally.
(BuildbotSyncer._parseRepositoryGroupPropertyTemplate): Added. A helper function to parse a set of
buildbot properties, validates its content, and invokes a callback if it's an dynamically resolved
type such as "revision" and "patch".
(BuildbotSyncer._validateAndMergeConfig): Updated per the format change. No longer allows "types",
"type", "platforms", and "platform" as they're explicity resolved in _resolveBuildersWithPlatforms.

  • tools/js/buildbot-triggerable.js:

(BuildbotTriggerable.prototype.syncOnce):
(BuildbotTriggerable.prototype._validateRequests): Handle the case when a build request is not
associated with any test.
(BuildbotTriggerable.prototype._nextRequestInGroup): Return null when there is a build request to
build a patch which has not been completed (pending, scheduled, running, or failed). Since all
requests to build a patch has a negative order, those requests should all show up at the beginning.
(BuildbotTriggerable.prototype._scheduleRequestIfSlaveIsAvailable): Pick a new buildbot syncer when
scheduling the first request to build a patch or the first request to run a test. The first request
to run a test will always have order of 0, so it's a sufficient condition to find such a request.
On the other hand, the first request to build a patch can have a negative order number so we must
explicitly check if it's the first item in the ordered list of requests in the test group.

  • tools/remote-server-relay.log: Added.
  • tools/sync-buildbot.js:

(syncLoop): Fixed a bug we were not re-fetching the triggerable after updating the triggerable so
that Triggerable and related objects we have in the memory may not reflect what we just synced to
the perf dashboard. Also, we don't reset V3 models manually any more since Manifest.fetch does that.

  • unit-tests/buildbot-syncer-tests.js: Added more test cases and updated existing test cases to test

exception messages explicitly since allowing any exception was resulting in some tests passing a
result of unrelated parsing error being thrown, etc...
(sampleiOSConfig): Updated per the format change.
(sampleiOSConfigWithExpansions): Ditto.
(smallConfiguration): Ditto.

11:40 AM Changeset in webkit [217377] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[WPE] Rebaseline test

Unreviewed gardening after a series of changes to dom static properties.

  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
11:39 AM Changeset in webkit [217376] by Claudio Saavedra
  • 1 edit
    1 delete in trunk/LayoutTests

[WPE] Rebaseline test

Unreviewed gardening after a series of changes to dom static properties.

  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
11:38 AM Changeset in webkit [217375] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit2

[WK2] Remove workaround to disable zooming to the focus rect while performing a data interaction
​https://bugs.webkit.org/show_bug.cgi?id=172546

Reviewed by Beth Dakin.

Removes a now-unnecessary workaround to prevent scrolling when performing a data interaction operation in
editable content.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):

11:37 AM Changeset in webkit [217374] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/JSTests

Cherry-pick r217018. rdar://problem/32380054

11:34 AM Changeset in webkit [217373] by jmarcell@apple.com
  • 3 edits
    1 add in branches/safari-603-branch

Cherry-pick r217016. rdar://problem/32380054

10:36 AM Changeset in webkit [217372] by wilander@apple.com
  • 5 edits in trunk/Source

Resource Load Statistics: Change grandfathering default to one hour
​https://bugs.webkit.org/show_bug.cgi?id=172524
<rdar://problem/32360462>

Reviewed by Brent Fulgham.

Source/WebCore:

Covered by existing test.

  • loader/ResourceLoadStatisticsStore.cpp:

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::resetToConsistentState):

9:39 AM Changeset in webkit [217371] by jer.noble@apple.com
  • 14 edits
    4 moves in trunk/Source

Rename DisplaySleepDisabler -> SleepDisabler
​https://bugs.webkit.org/show_bug.cgi?id=172478

Reviewed by Sam Weinig.

Source/WebCore:

Rename DisplaySleepDisabler to SleepDisabler so that different (i.e., non-Display) sleep types can be
added in a future change.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateSleepDisabling):

  • html/HTMLMediaElement.h:
  • platform/SleepDisabler.cpp: Renamed from Source/WebCore/platform/DisplaySleepDisabler.cpp.

(WebCore::SleepDisabler::create):
(WebCore::SleepDisabler::SleepDisabler):
(WebCore::SleepDisabler::~SleepDisabler):

  • platform/SleepDisabler.h: Renamed from Source/WebCore/platform/DisplaySleepDisabler.h.
  • platform/cocoa/SleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.cpp.

(WebCore::SleepDisabler::create):
(WebCore::SleepDisablerCocoa::SleepDisablerCocoa):
(WebCore::SleepDisablerCocoa::~SleepDisablerCocoa):

  • platform/cocoa/SleepDisablerCocoa.h: Renamed from Source/WebCore/platform/cocoa/DisplaySleepDisablerCocoa.h.
  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController updatePowerAssertions]):

  • CMakeLists.txt:
  • PlatformMac.cmake:
  • WebCore.order:

Source/WebKit/mac:

  • WebView/WebFullScreenController.h:

Source/WebKit2:

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:
9:22 AM Changeset in webkit [217370] by pvollan@apple.com
  • 8 edits in trunk

[Win] Create unique network storage session for each DRT.
​https://bugs.webkit.org/show_bug.cgi?id=172540

Reviewed by Brent Fulgham.

During layout testing, each DRT instance should have its own network storage session.

Source/WebCore:

  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::switchToNewTestingSession):

Source/WebKit/win:

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferences.cpp:

(WebPreferences::switchNetworkLoaderToNewTestingSession):

  • WebPreferences.h:

Tools:

  • DumpRenderTree/win/DumpRenderTree.cpp:

(prepareConsistentTestingEnvironment):

9:08 AM Changeset in webkit [217369] by weinig@apple.com
  • 8 edits in trunk/Source/WebCore

[WebIDL] Overloaded functions unnecessarily duplicate argument checks
​https://bugs.webkit.org/show_bug.cgi?id=172481

Reviewed by Chris Dumez.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePropertiesHashTable):
Update for rename of GetConditionalForFunctionConsideringOverloads.

(AreTypesDistinguishableForOverloadResolution):
Remove unnecessary subroutine isDictionary that can be replaced by
a direct call to $codeGenerator->IsDictionaryType().

(GetConditionalForFunctionConsideringOverloads):
Renamed from getConditionalForFunctionConsideringOverloads.

(GenerateOverloadDispatcher):
Renamed from GenerateOverloadedFunctionOrConstructor. Moved Constructor/Operation/LegacyCaller
specific code out, and into parameters.

(GenerateImplementation):
Moved operation generation out into its own subroutine.

(GenerateOperationDefinition): Added.
Moved from GenerateImplementation.

(GenerateLegacyCallerDefinitions):
Pass function name and signature to GenerateOverloadDispatcher.

(GenerateArgumentsCountCheck):
Don't generate an argument check if this is an overloaded function. The argument
checks happen in the overload dispatcher.

(NeedsExplicitPropagateExceptionCall):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
Replace IsReturningPromise with more direct check.

(GenerateConstructorDefinitions):
Pass function name and signature to GenerateOverloadDispatcher.

(getConditionalForFunctionConsideringOverloads): Renamed to GetConditionalForFunctionConsideringOverloads.
(GenerateOverloadedFunctionOrConstructor): Renamed to GenerateOverloadDispatcher.
(IsReturningPromise): Deleted.

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/TestInterface.idl:

Update test results.

8:40 AM Changeset in webkit [217368] by jdiggs@igalia.com
  • 7 edits
    1 copy in trunk/LayoutTests

[ATK] Gardening needed after r217171
​https://bugs.webkit.org/show_bug.cgi?id=172539

Unreviewed test gardening after r217171.

Add "PASS successfullyParsed is true" and "TEST COMPLETE" lines for
tests with platform-specific expectations.

  • accessibility/multiselect-list-reports-active-option-expected.txt:
  • accessibility/table-cells-roles-expected.txt:
  • platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt:
  • platform/gtk/accessibility/aria-switch-sends-notification-expected.txt:
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt:
  • platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt:
  • platform/gtk/accessibility/table-roles-hierarchy-expected.txt:
5:11 AM Changeset in webkit [217367] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.16.3

WebKitGTK+ 2.16.3

5:09 AM Changeset in webkit [217366] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.3 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.16.3.
4:17 AM Changeset in webkit [217365] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r215166 - generate-bindings-all.pl shouldn't use Perl threads
​https://bugs.webkit.org/show_bug.cgi?id=170106

Patch by Fujii Hironori <Fujii Hironori> on 2017-04-09
Reviewed by Yusuke Suzuki.

The use of interpreter-based threads in Perl is officially
discouraged and not all Linux distributions and BSD compile Perl
with threads support. Use fork instead of threads to run
generate-bindings.pl in parallel.

  • bindings/scripts/generate-bindings-all.pl:

(spawnGenerateBindingsIfNeeded): Added.
(executeCommand): Removed the workaround for Cygwin Perl threads.
(spawnCommand): Added.
(worker): Deleted.

4:00 AM Changeset in webkit [217364] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r214291 - ASSERT_WITH_SECURITY_IMPLICATION hit when removing an <input type="range"> while dragging on iOS
​https://bugs.webkit.org/show_bug.cgi?id=165535
<rdar://problem/29559749>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Utimately we should prevent SliderThumbElement::unregisterForTouchEvents() being called while
updating render tree. A quick fix for this is to move dispatchFormControlChangeEvent for input
from stopDragging up to the callers which really needs to dispatch this event, i.e., finishing
dragging the slider. It is clear that not every caller of stopDragging wants to
dispatchFormControlChangeEvent.

Test: fast/forms/range/range-remove-on-drag.html

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::stopDragging):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::handleTouchEndAndCancel):

LayoutTests:

This test case is only enabled in iOS simulator WK2.

  • TestExpectations:
  • fast/forms/range/range-remove-on-drag-expected.txt: Added.
  • fast/forms/range/range-remove-on-drag.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
3:47 AM Changeset in webkit [217363] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r217319.
​https://bugs.webkit.org/show_bug.cgi?id=172538

This patch broke iOS Simulator Debug build (Requested by fredw
on #webkit).

Reverted changeset:

"CoreAudioCaptureSource is ducking system sound"
​https://bugs.webkit.org/show_bug.cgi?id=172512
​http://trac.webkit.org/changeset/217319

3:26 AM Changeset in webkit [217362] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r214086 - WebGL: Improve index validation when using uint index values
​https://bugs.webkit.org/show_bug.cgi?id=169798

Reviewed by Simon Fraser.

Source/WebCore:

Make sure that we test index validation with the correct type.
Also stop using -1 in WebGLBuffer to indicate non-existant values.

Test: fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.

  • html/canvas/WebGLBuffer.cpp: Use unsigned for maxIndex (they can't be negative)

and optional<> to indicate unknown value.
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):

  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateIndexArrayConservative): Use optional<> and
unsigned values.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::validateVertexAttributes): No need to check if
an unsigned value is less than zero.

LayoutTests:

  • fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt: Added.
  • fast/canvas/webgl/draw-elements-out-of-bounds-uint-index.html: Added.
3:21 AM Changeset in webkit [217361] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r214014 - Iteratively dispatch DOM events after restoring a cached page
​https://bugs.webkit.org/show_bug.cgi?id=169703
<rdar://problem/31075903>

Reviewed by Brady Eidson.

Make dispatching of DOM events when restoring a page from the page cache symmetric with
dispatching of events when saving a page to the page cache.

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Move code to dispatch events from here to FrameLoader::didRestoreFromCachedPage().

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad): Ensure that no DOM events are dispatched during
restoration of a cached page. Call didRestoreFromCachedPage() after restoring the page to
dispatch DOM events on the restored frames.
(WebCore::FrameLoader::willRestoreFromCachedPage): Renamed; formerly named prepareForCachedPageRestore().
(WebCore::FrameLoader::didRestoreFromCachedPage): Added.
(WebCore::FrameLoader::prepareForCachedPageRestore): Renamed to willRestoreFromCachedPage().

  • loader/FrameLoader.h:
  • page/FrameTree.cpp:

(WebCore::FrameTree::traverseNextInPostOrderWithWrap): Returns the next Frame* in a post-order
traversal of the frame tree optionally wrapping around to the deepest first child in the tree.
(WebCore::FrameTree::deepFirstChild): Added.

  • page/FrameTree.h:
2:50 AM Changeset in webkit [217360] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/win

[WinCairo] AcceleratedCompositingContext.h: error C3668: 'AcceleratedCompositingContext::paintContents': method with override specifier 'override' did not override any base class methods
​https://bugs.webkit.org/show_bug.cgi?id=172535

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-24
Reviewed by Konstantin Tokarev.

  • WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::paintContents): Append the fifth argument.

  • WebCoreSupport/AcceleratedCompositingContext.h: Ditto.
2:40 AM Changeset in webkit [217359] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.16

Merge r217227 - Crash in WebCore::StyleRuleKeyframes::findKeyframeIndex
​https://bugs.webkit.org/show_bug.cgi?id=170756
<rdar://problem/31573157>

Reviewed by Andreas Kling.

Source/WebCore:

Using a malformed key with CSSKeyframesRule.findRule crashes because
CSSParser::parseKeyframeKeyList returns null which is then dereferenced.

  • css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::findKeyframeIndex): Null test.

LayoutTests:

Expand the tests to cover the malformed key case.

  • animations/keyframes-rule.html:
  • animations/unprefixed-keyframes-rule.html:
2:37 AM Changeset in webkit [217358] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Tools

Merge r217190 - [GTK] gtkdoc-fixxref needs --module argument to work
​https://bugs.webkit.org/show_bug.cgi?id=172415

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-05-20
Reviewed by Michael Catanzaro.

  • gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_fixxref):

2:36 AM Changeset in webkit [217357] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r217172 - Do not fire load event for SVGElements that are detached or in frameless documents
​https://bugs.webkit.org/show_bug.cgi?id=172289
<rdar://problem/32275689>

Reviewed by Ryosuke Niwa.

Source/WebCore:

We should not fire load event for SVGElements that are detached or in frameless
documents.

Test: svg/load-event-detached.html

  • svg/SVGElement.cpp:

(WebCore::SVGElement::sendSVGLoadEventIfPossible):

LayoutTests:

Add layout test coverage.

  • svg/load-event-detached-expected.txt: Added.
  • svg/load-event-detached.html: Added.
2:32 AM Changeset in webkit [217356] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r217219 - Add even more input validation in Connection::processMessage()
​https://bugs.webkit.org/show_bug.cgi?id=171682

Reviewed by Carlos Garcia Campos.

Verify that the size of the out-of-line message body matches the size of the AttachmentInfo
that is containing it.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::processMessage):

2:32 AM Changeset in webkit [217355] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r217206 - Add more input validation in Connection::readBytesFromSocket()
​https://bugs.webkit.org/show_bug.cgi?id=171871

Reviewed by Michael Catanzaro.

Check the control message length is in the limits. Credit to Nathan Crandall for reporting this issue and
submitting an equivalent fix.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::readBytesFromSocket):

2:31 AM Changeset in webkit [217354] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r217126 - Add more input validation in Connection::processMessage()
​https://bugs.webkit.org/show_bug.cgi?id=171682

Reviewed by Michael Catanzaro.

Check limits of attachments and message size. Credit to Nathan Crandall for reporting this issue and submitting
an equivalent fix.

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::processMessage):

2:27 AM Changeset in webkit [217353] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16

Merge r217164 - Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
​https://bugs.webkit.org/show_bug.cgi?id=172309
<rdar://problem/32262357>

Reviewed by Simon Fraser.

Source/WebCore:

This patch stops the redundant ellipsis box trigger ASSERT_WITH_SECURITY_IMPLICATION.

In RootInlineBox::placeEllipsis we construct an ellipsis box and append it to a static HashMap which
keeps track of the ellipsis boxes on each line. However when the line already has an ellipsis, we
re-use the existing one and this newly constructed (but redundant) box gets destroyed as we return from this function.
In InlineBox's d'tor, we let the parent know that now it has a dangling child and we assert on it
later, while accessing the children list. However this redundant ellipsis box was never added to the line,
so the assertion hits incorrectly.

Test: fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.cpp: This needs 32bits padding.

(WebCore::InlineBox::invalidateParentChildList):

  • rendering/InlineBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis):

LayoutTests:

  • fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt: Added.
  • fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html: Added.
2:14 AM Changeset in webkit [217352] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r217079 - Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().
​https://bugs.webkit.org/show_bug.cgi?id=172309
<rdar://problem/32262357>

Reviewed by Simon Fraser.

Source/WebCore:

This patch stops the redundant ellipsis box trigger ASSERT_WITH_SECURITY_IMPLICATION.

In RootInlineBox::placeEllipsis we construct an ellipsis box and append it to a static HashMap which
keeps track of the ellipsis boxes on each line. However when the line already has an ellipsis, we
re-use the existing one and this newly constructed (but redundant) box gets destroyed as we return from this function.
In InlineBox's d'tor, we let the parent know that now it has a dangling child and we assert on it
later, while accessing the children list. However this redundant ellipsis box was never added to the line,
so the assertion hits incorrectly.

Test: fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::EllipsisBox):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::invalidateParentChildList):

  • rendering/InlineBox.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::placeEllipsis): Use the newly created ellipsis box instead.

LayoutTests:

  • fast/inline/redundant-ellipsis-triggers-assert-incorrectly-expected.txt: Added.
  • fast/inline/redundant-ellipsis-triggers-assert-incorrectly.html: Added.
2:08 AM Changeset in webkit [217351] by Carlos Garcia Campos
  • 8 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r217075 - Transform misplaces element 50% of the time
​https://bugs.webkit.org/show_bug.cgi?id=172300
Source/WebCore:

Reviewed by Simon Fraser.

A hardware-accelerated animation of the transform property
requires layout to happen if it contains a translate operation
using percentages, otherwise it may create an incorrect
animation. The "50% of the time" comes in to play because
the layout timer may sometimes fire before the animation
timer. The test case contains a example that is much more
likely to fail without this fix.

Test: animations/needs-layout.html

  • page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::animationTimerFired): If
we've been told that we need a layout, and we have one pending, then
force it before doing the rest of the animation logic.
(WebCore::CSSAnimationController::updateAnimations): Check if the
CompositeAnimation depends on layout, and tell the private controller
that it should check for the necessity of a layout as the animation
timer fires.

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::animate): Ask the keyframes if this
animation depends on layout.

  • page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::hasAnimationThatDependsOnLayout):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::computeLayoutDependency): Look at all
the keyframe properties for something that is a translation using
percentages.

  • page/animation/KeyframeAnimation.h:

LayoutTests:

<rdar://problem/29835668>

Reviewed by Simon Fraser.

A test case which has an animation that relies on
translation percentages. If all goes well, the
animating element will be completely obscured.

  • animations/needs-layout-expected.html: Added.
  • animations/needs-layout.html: Added.
2:05 AM Changeset in webkit [217350] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.16

Merge r217069 - Improve error message for Access-Control-Allow-Origin violation due to misconfigured server
​https://bugs.webkit.org/show_bug.cgi?id=162819
<rdar://problem/28575938>

Reviewed by Joseph Pecoraro.

LayoutTests/imported/w3c:

Update expected result.

  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:

Source/WebCore:

Inspired by Blink change:
<​https://src.chromium.org/viewvc/blink?view=revision&revision=163406>

At most one Access-Control-Allow-Origin header may be in an HTTP response. Improve the
error message emitted on a CORS failure when Access-Control-Allow-Origin contains more
than one origin, indicated by the presence of a ',', as a way to help web developers/server
administrators differentiate between a misconfigured Access-Control-Allow-Origin header
and a misconfigured server.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck): Defined a local variable to hold the value of securityOrigin.toString()
and referenced this variable throughout the code to avoid computing the stringified security
origin more than once. Switched to using makeString() to concatenate error message when the
origin of the page does not match the value of the Access-Control-Allow-Origin header.

LayoutTests:

Add more tests when Access-Control-Allow-Origin has more than one value and group
with existing tests. Update expected results.

  • http/tests/xmlhttprequest/origin-exact-matching-expected.txt:
  • http/tests/xmlhttprequest/resources/origin-exact-matching-iframe.html: Also extracted

the origin string for the page into a local variable called pageOrigin, making use of document.origin,
and referenced this variable instead of duplicating its value. Fixed various style nits.

2:03 AM Changeset in webkit [217349] by Carlos Garcia Campos
  • 6 edits
    7 adds in releases/WebKitGTK/webkit-2.16

Merge r217054 - REGRESSION (r209608): Cross-origin plugin document opened in child window blocked by parent
window CSP when object-src 'none' is set
​https://bugs.webkit.org/show_bug.cgi?id=172038
<rdar://problem/32258262>

Reviewed by Andy Estes.

Source/WebCore:

Fixes an issue where a cross-origin plugin document opened in a child window would inherit
the Content Security Policy (CSP) of its opener. In particular, a cross-origin plugin
document opened in a child window would be blocked when the CSP of its opener disallows
plugins (e.g. object-source 'none').

Prior to r209608 a document opened in a child window never inherited the CSP from its opener
and a plugin document loaded in a subframe would unconditionally inherit the CSP from its
parent frame. So, a plugin document opened in a child window would be allowed to load
regardless of whether its opener had a CSP that prevented plugins. Following r209608 a
document opened in a child window would inherit its CSP from its opener if and only if it
would inherit the security origin from its opener (e.g. about:blank) or was a plugin
document. The latter condition makes plugin documents opened in a child window unconditionally
inherit the CSP from their opener and is the cause of this bug. It seems reasonable to exempt
cross-origin plugin documents opened in a child window from the CSP inheritance rule because
such documents cannot compromise the origin of their opener. Same-origin plugin documents
opened in a child window will continue to inherit the CSP from their opener because such
documents can compromise the origin of their opener.

Tests: http/tests/security/contentSecurityPolicy/cross-origin-plugin-document-allowed-in-child-window.html

http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window.html
http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html

  • dom/Document.cpp:

(WebCore::Document::shouldInheritContentSecurityPolicyFromOwner): Added.
(WebCore::Document::initContentSecurityPolicy):

  • dom/Document.h:

Tools:

Teach the test Netscape plugin to look for a URL that contains plugin-document-alert-and-notify-done.pl.
When it sees this URL it will show a JavaScript alert and call testRunner.notifyDone().

  • DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):

LayoutTests:

Adds tests to ensure that a same-origin- and cross-origin- plugin document opened in a child
window inherit and do not inherit the CSP of its opener, respectively. Also adds a test to
ensure that an about:blank window inherits the CSP plugin policy of its opener.

  • http/tests/plugins/resources/plugin-document-alert-and-notify-done.pl: Added.
  • http/tests/security/contentSecurityPolicy/cross-origin-plugin-document-allowed-in-child-window-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/cross-origin-plugin-document-allowed-in-child-window.html: Added.
  • http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window.html: Added.
  • http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html: Added.
  • platform/ios/TestExpectations: Skip added tests as iOS does not support plugins.
2:00 AM Changeset in webkit [217348] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168409

Unreviewed.

Remove temporary logging which prevents performance bots from reporting useful data.

Patch by Antoine Quint <Antoine Quint> on 2017-05-24

  • page/Page.cpp:

(WebCore::Page::suspendScriptedAnimations):

1:40 AM Changeset in webkit [217347] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216978 - getElementById can return a wrong elemnt when a matching element is removed during beforeload event
​https://bugs.webkit.org/show_bug.cgi?id=171374

Patch by Ryosuke Niwa <​rniwa@webkit.org> on 2017-05-17
Reviewed by Brent Fulgham.

Source/WebCore:

The bug was caused by HTMLLinkElement firing beforeload event inside insertedInto before the tree state is updated.
Delay the event dispatch to the post insertion callback.

Test: fast/html/link-element-removal-during-beforeload.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::finishedInsertingSubtree):

  • html/HTMLLinkElement.h:

LayoutTests:

Added a regression test for calling getElementById after removing a matching element
during beforeload event of a link element.

  • fast/html/link-element-removal-during-beforeload-expected.txt: Added.
  • fast/html/link-element-removal-during-beforeload.html: Added.
1:37 AM Changeset in webkit [217346] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216968 - Remove C-style casts by using xmlDocPtr instead of void*
<​https://webkit.org/b/172189>

Reviewed by Alex Christensen.

  • dom/TransformSource.h: Fix whitespace indentation.

(typedef PlatformTransformSource): Use xmlDocPtr not void*.

  • dom/TransformSourceLibxslt.cpp:

(WebCore::TransformSource::~TransformSource): Remove cast.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::document): Remove cast.

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xmlDocPtrFromNode): Remove casts.

  • xml/parser/XMLDocumentParser.h:

(WebCore::xmlDocPtrForString): Update declaration to return
xmlDocPtr not void*.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doEnd): Change type of local
variable from void* to xmlDocPtr.
(WebCore::xmlDocPtrForString): Update to return xmlDocPtr
not void*.

1:35 AM Changeset in webkit [217345] by jfernandez@igalia.com
  • 4 edits in trunk

[css-grid] Ignore collapsed tracks on content-distribution alignment
​https://bugs.webkit.org/show_bug.cgi?id=172493

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

The CSS Box Alignment spec states that we should ignore the collapsed
tracks when computing the Distribution Alignment space to assign to the
different grid tracks.

No new tests, just unskipping the web-platform-tests imported to verify this use case.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::populateGridPositionsForDirection):

LayoutTests:

Unskip the web-platform-tests related to content-alignment and collapsed tracks.

1:21 AM Changeset in webkit [217344] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r216915 - [SOUP] Remove LATEST_RECORD_VERSION from GnuTLS priority string
​https://bugs.webkit.org/show_bug.cgi?id=172153

Based on discussion with Nikos in ​https://bugzilla.gnome.org/show_bug.cgi?id=782218, we
should remove LATEST_RECORD_VERSION from our GnuTLS priority string. This causes GnuTLS to
use the latest TLS record version (the record format is separate from the TLS protocol
version), which we needed a couple years ago (after dropping SSLv3) for maximum
compatibility with broken web servers. But it's not needed anymore, and is causing new
compatibility problems with other broken web servers, so let's get rid of it.

Reviewed by Carlos Garcia Campos.

  • NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

  • WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

1:18 AM Changeset in webkit [217343] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216889 - Crash in libxml2.2.dylib: xmlDictReference
<​https://webkit.org/b/172086>
<rdar://problem/23643436>

Reviewed by Daniel Bates.

Speculative fix and code clean-up based on source code
inspection. The fix for the crash is in two parts that change
XSLStyleSheet::parseString():

  1. Always set m_stylesheetDoc to nullptr after freeing it via XSLStyleSheet::clearXSLStylesheetDocument().
  2. Add nullptr check before using m_stylesheetDoc from parent.

Broadly speaking, the changes are:

  • Extract code to reset m_stylesheetDoc into new private XSLStyleSheet::clearXSLStylesheetDocument() method. There is a special contract between m_stylesheetDoc and m_stylesheetDocTaken that wasn't being followed every time. See comment in XSLStyleSheet::compileStyleSheet().
  • XSLStyleSheet::clearDocuments() now calls new clearXSLStylesheetDocument() method. Previously, it was not checking or resetting m_stylesheetDocTaken, and it might have leaked an xmlDocPtr if m_stylesheetDoc was set and m_stylesheetDocTaken was false.
  • XSLStyleSheet::parseString() now calls new clearXSLStylesheetDocument() method. Previously, it did not clear m_stylesheetDoc after freeing it, and it could return early due to a failure in xmlCreateMemoryParserCtxt().
  • In XSLStyleSheet::parseString() use checked arithmetic when calculating 'size' for xmlCreateMemoryParserCtxt() and xmlCtxtReadMemory(). This code used to do an implicit unsigned -> signed integer conversion that could overflow.
  • Always iterate m_children using an 'auto& import' variable.
  • xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add declaration.
(WebCore::XSLStyleSheet::m_disabled): Add default initializer.
(WebCore::XSLStyleSheet::m_stylesheetDoc): Ditto.
(WebCore::XSLStyleSheet::m_stylesheetDocTaken): Ditto.
(WebCore::XSLStyleSheet::m_parentStyleSheet): Ditto.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::XSLStyleSheet): Get rid of redundant
initializers. Set m_parentStyleSheet if needed.
(WebCore::XSLStyleSheet::~XSLStyleSheet): Call
clearXSLStylesheetDocument() instead of custom code. Switch
m_children fast iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::isLoading): Switch m_children fast
iteration to use 'auto& import' variable.
(WebCore::XSLStyleSheet::clearDocuments): Call
clearXSLStylesheetDocument() instead of setting m_stylesheetDoc
to nullptr. This might fix an occasional xmlDocPtr leak.
(WebCore::XSLStyleSheet::clearXSLStylesheetDocument): Add. This
method always sets m_stylesheetDoc to nullptr (after freeing it
if necessary) and sets m_stylesheetDocTaken to false.
(WebCore::XSLStyleSheet::parseString): Call
clearXSLStylesheetDocument(). Prior to this, m_stylesheetDoc
might be left pointing to a freed value, and this method could
return early if xmlCreateMemoryParserCtxt() failed. Switch to
using Checked<> to compute required buffer size to parse XSL
stylesheet, and return early on overflow. Clean up existing
return statements to use boolean expressions. Add nullptr check
for m_parentStyleSheet->m_stylesheetDoc before using it.
(WebCore::XSLStyleSheet::loadChildSheet): Get rid of local
variable by calling loadSheet() from last array element.
(WebCore::XSLStyleSheet::compileStyleSheet): Add debug assert
that m_stylesheetDoc is not nullptr.

1:01 AM Changeset in webkit [217342] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216859 - [CAIRO] Painting an image mask with a matrix above Pixman's limit breaks internal states of Cairo
​https://bugs.webkit.org/show_bug.cgi?id=169094

Reviewed by Žan Doberšek.

Source/WebCore:

It is the same problem which addressed in r212431.
In HiDPI situation, it happens easily due to the size of coordinates.
Also, if this bug happens, it will break the rendering continuously
since we are reusing graphics contexts to render webpages in same
webview.

Test: fast/hidpi/hidpi-long-page-with-inset-element.html

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::pushImageMask):
We can avoid the limit of the Pixman by reducing the source surface's
size, and it will create a minimal pattern matrix.

LayoutTests:

  • fast/hidpi/hidpi-long-page-with-inset-element-expected.html: Added.
  • fast/hidpi/hidpi-long-page-with-inset-element.html: Added.
12:59 AM Changeset in webkit [217341] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r216847 - Always reset the assisted node when the main frame commits a new load.
​https://bugs.webkit.org/show_bug.cgi?id=172088

Reviewed by Antti Koivisto.

WebPage::m_assistedNode could extend the lifetime of the document it pointed into
if the main frame was navigated while the assisted node was in one of its subframes.
The life-supported document wouldn't be reachable from JavaScript but nevertheless
would consume memory and other resources.

This patch fixes the issue by always clearing WebPage::m_assistedNode when the main
frame commits a new load.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resetAssistedNodeForFrame):

12:52 AM Changeset in webkit [217340] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216789 - Check existence of a page before accessing its plugins
​https://bugs.webkit.org/show_bug.cgi?id=171712
<rdar://problem/32007806>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: plugins/navigator-plugin-crash.html

  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):

LayoutTests:

  • plugins/navigator-plugin-crash-expected.txt: Added.
  • plugins/navigator-plugin-crash.html: Added.
12:48 AM Changeset in webkit [217339] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.16

Merge r216759 - [GTK] ASSERTION FAILED: !m_flushingLayers
​https://bugs.webkit.org/show_bug.cgi?id=172025

Reviewed by Žan Doberšek.

Source/WebCore:

The problem is that syncImageBacking() is calling didChangeLayerState(). All sync methods are called by
flushCompositingStateForThisLayerOnly() while flushing layers, so none of them should call didChange method that
will schedule a new flush while flushing.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):

LayoutTests:

  • platform/gtk/TestExpectations:
12:46 AM Changeset in webkit [217338] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216758 - [GTK] GIF images are not properly loaded the first time
​https://bugs.webkit.org/show_bug.cgi?id=170432

Reviewed by Carlos Alberto Lopez Perez.

Source/WebCore:

When the GIF image is loaded for the first time, it's always read from the network, and the decoder is usually
fetched with chunks of data. Then the data is cached in disk by the network process, so that when loaded from
the cache, the whole encoded data is available to fetch the encoder. The problem is that we are failing to
decode the image when giving chunks of data, that's why it only happens the first time loaded. If the first
chunk of data provided is enough to get some metadata, including the size, but not frame contents, the load fails
in CachedImage::addIncrementalDataBuffer() because the EncodedDataStatus reported is SizeAvailable but
Image::isNull() returns true. An Image is considered to be Null when its size is empty, and the size is
calculated always using the first frame in ImageFrameCache. Since we still don't have frames, the image is
always Null in this case. It is not expected that EncodedDataStatus returns SizeAvailable and the image is Null,
that's why it's considered an error and the load finishes with a decode error. However, the non CG ImageDecoder
has a m_size member to handle this particular case, and it's when m_size is set when EncodedDataStatus changes
to SizeAvailable. We should return the ImageEncoder size as the ImageSize when we have a decoder but
not frames yet.

Test: http/tests/images/gif-progressive-load.html

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::size): Return ImageDecoder::size() without caching it, if frame list is empty.

LayoutTests:

  • http/tests/images/gif-progressive-load-expected.html: Added.
  • http/tests/images/gif-progressive-load.html: Added.
12:39 AM Changeset in webkit [217337] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r216670 - [GTK] JavaScript prompt uses title of page to be loaded rather than title of current page
​https://bugs.webkit.org/show_bug.cgi?id=152690

Reviewed by Michael Catanzaro.

webkit_web_view_get_uri() returns the page to be loaded, use
internal api for this.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateJavaScriptDialog):

12:38 AM Changeset in webkit [217336] by Carlos Garcia Campos
  • 7 edits in releases/WebKitGTK/webkit-2.16

Merge r216643 - REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
​https://bugs.webkit.org/show_bug.cgi?id=132297

Reviewed by Simon Fraser.

Source/WebCore:

We don't know why m_renderView needs layout in this case, but we know that we don't need to
assert if the client hasn't set the ScrollableInnerFrameTrigger compositing trigger.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

LayoutTests:

  • http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
  • http/tests/navigation/resources/keyboard-events-test.js:

(runTest):

  • platform/ios-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
12:34 AM Changeset in webkit [217335] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216631 - REGRESSION (r207372) Visibility property is not inherited when used in an animation
​https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>

Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

  • rendering/RenderElement.h:

(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

  • animations/animation-initial-inheritance-expected.html: Added.
  • animations/animation-initial-inheritance.html: Added.
12:23 AM Changeset in webkit [217334] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r216608 - Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
​https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>

Reviewed by Filip Pizlo and Geoffrey Garen.

This is a workaround for <rdar://problem/27607384>. During thread initialization,
for some target platforms, thread state is momentarily set to 0 before being
filled in with the target thread's real register values. As a result, there's
a race condition that may result in us getting a null stackPointer during a GC scan.
This issue may manifest with workqueue threads where the OS may choose to recycle
a thread for an expired task.

The workaround is simply to indicate that there's nothing to copy and return.
This is correct because we will only ever observe a null pointer during thread
initialization. Hence, by definition, there's nothing there that we need to scan
yet, and therefore, nothing that needs to be copied.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStack):

12:23 AM Changeset in webkit [217333] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216607 - REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
​https://bugs.webkit.org/show_bug.cgi?id=171925
<rdar://problem/29931223>

Reviewed by Wenson Hsieh.

We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.

I believe this can happen if the VisibleSelection is orphaned but not none, because
rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
if isNoneOrOrphaned().

No new tests, I do not know how to reproduce.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt):

12:21 AM Changeset in webkit [217332] by Wenson Hsieh
  • 5 edits
    2 adds in trunk

Respect image UTIs when writing to item providers when beginning data interaction on an image
​https://bugs.webkit.org/show_bug.cgi?id=172436
<rdar://problem/31786569>

Reviewed by Beth Dakin.

Source/WebCore:

Previously, when beginning writing images to the WebItemProviderPasteboard, we would create a new UIImage and
use standard UIImage UIItemProviderWriting utilities to register the image to the pasteboard. This is lossy for
gifs, since UIImage doesn't inherently know how to represent gifs. Instead, register the raw image data directly
to the UTI type corresponding to the MIME type of the image, and use UIImage's item provider writing capability
as a fallback when the raw resourceData is unavailable.

Augments existing unit tests, and also adds a new unit test:
DataInteractionTests.ImageDoesNotUseElementSizeAsEstimatedSize

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::writeObjectRepresentations):

Tools:

Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
details.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.

Create a new test page containing a GIF and a file input.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(checkTypeIdentifierIsRegisteredAtIndex):
(TestWebKitAPI::TEST):

12:19 AM Changeset in webkit [217331] by Carlos Garcia Campos
  • 8 edits
    2 copies in releases/WebKitGTK/webkit-2.16

Merge r216599 - Keyboard input suppression should extend to subframes
​https://bugs.webkit.org/show_bug.cgi?id=171880
<rdar://problem/31201793>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html

  • dom/EventDispatcher.cpp:

(WebCore::shouldSuppressEventDispatchInDOM): Changed to call shouldSuppressKeyboardInput()
on the main frame's loader.

  • editing/Editor.cpp:

(WebCore::Editor::shouldInsertText): Ditto.

LayoutTests:

  • http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
  • http/tests/navigation/keyboard-events-during-provisional-navigation.html:
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
  • http/tests/navigation/resources/keyboard-events-after-navigation.html:
  • http/tests/navigation/resources/keyboard-events-test.js:

(runTest):
(waitForProvisionalNavigation.xhr.onreadystatechange):
(waitForProvisionalNavigation):

12:16 AM Changeset in webkit [217330] by Carlos Garcia Campos
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-2.16

Merge r216593 - Null pointer dereference in WTF::RefPtr<WTF::StringImpl>::operator!() under slow_path_get_direct_pname
​https://bugs.webkit.org/show_bug.cgi?id=171801

Reviewed by Michael Saboff.

JSTests:

These tests used to crash. The prefix and postfix tests cover different paths, except
postfix-ignored goes down the same path as prefix due to an optimization.

  • stress/for-in-postfix-ignored-index.js: Added.

(foo):

  • stress/for-in-postfix-index.js: Added.

(foo):

  • stress/for-in-prefix-index.js: Added.

(foo):

Source/JavaScriptCore:

This was a goofy oversight. The for-in optimization relies on the bytecode generator
to detect when the loop's index variable gets mutated. We forgot to have the hooks for
detecting this in prefix and postfix operations (++i and i++).

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):

12:12 AM Changeset in webkit [217329] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebKit2

Merge r216584 - [GTK] HTTP authentication dialog should focus on first input field
​https://bugs.webkit.org/show_bug.cgi?id=151349

Reviewed by Michael Catanzaro.

Setting focus on a widget before it's mapped does nothing. Move
the call to the right place.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogMap):

12:11 AM Changeset in webkit [217328] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebInspectorUI

Merge r216562 - [GTK][Win] Web Inspector: Cann't open "Quick Open" dialog by pressing Ctrl+Shift+O
​https://bugs.webkit.org/show_bug.cgi?id=171798

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Michael Catanzaro.

PC can't input the shortcut keys Command+Shift+O and Command+P.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Use CommandOrControl instead of Command.

12:08 AM Changeset in webkit [217327] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore

Merge r216547 - Heap::heap() should behave gracefully for null pointers
​https://bugs.webkit.org/show_bug.cgi?id=171888
<rdar://problem/32005315>

Reviewed by Mark Lam.

Some callers of Heap::heap() can pass a null cell and they will behave gracefully if we
return a null Heap. So, let's do that.

This fixes a crash and it does not hurt performance. I'm seeing a possible 0.5% regression
with 74% probability. That's a neutral result by our usual 95% standard.

  • heap/HeapInlines.h:

(JSC::Heap::heap):

May 23, 2017:

11:43 PM Changeset in webkit [217326] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.16

Merge r217203 - [GTK] Remove Firefox user agent quirk for Google domains
​https://bugs.webkit.org/show_bug.cgi?id=171941

Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::quirksForURL):
(WebCore::UserAgentQuirks::stringForQuirk):
(WebCore::urlRequiresFirefoxBrowser): Deleted.
(WebCore::UserAgentQuirks::firefoxRevisionString): Deleted.

  • platform/UserAgentQuirks.h:
  • platform/gtk/UserAgentGtk.cpp:

(WebCore::buildUserAgentString):

Tools:

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.

11:43 PM Changeset in webkit [217325] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Merge r216585 - Remove user agent quirk for Slack
​https://bugs.webkit.org/show_bug.cgi?id=171869

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack
without difficulty using our default user agent.

  • platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the corresponding test.

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

11:42 PM Changeset in webkit [217324] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216531 - Update Chrome and Firefox versions in user agent quirks
​https://bugs.webkit.org/show_bug.cgi?id=171823

Reviewed by Carlos Alberto Lopez Perez.

  • platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):
(WebCore::UserAgentQuirks::firefoxRevisionString):

11:35 PM Changeset in webkit [217323] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.16

Merge r216440 - Text overlaps on ​http://www.duden.de/rechtschreibung/Acre
​https://bugs.webkit.org/show_bug.cgi?id=171796
<rdar://problem/31036028>

Reviewed by Simon Fraser.

Source/WebCore:

Simple line layout pre-measures space using the primary font,
even if the space glyph requires a fallback font (and even if the string does not have a space in it at all).
When this width gets cached (see WidthCache) we might end up using it later during normal line layout and
it could produce incorrect layout.
This patch removes the space width caching from Simple line layout, since Font already caches it.

Test: fast/text/simple-line-layout-fallback-space-glyph.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createLineRuns):

  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):

  • rendering/SimpleLineLayoutTextFragmentIterator.h:

LayoutTests:

  • fast/text/simple-line-layout-fallback-space-glyph-expected.html: Added.
  • fast/text/simple-line-layout-fallback-space-glyph.html: Added.
11:27 PM Changeset in webkit [217322] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore

Merge r216438 - Bail out of simple line layout when hyphen needs a fallback font.
​https://bugs.webkit.org/show_bug.cgi?id=171811

Reviewed by Antti Koivisto.

With hyphen: auto is set, we don't know if the hypen string is going to be used, until
after we started laying out the content and figured that the text overflows the line.
However it's too late to bail out of simple line layout at this point, so let's just
pre-check if the hyphen string needs a fallback font.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForStyle):

11:25 PM Changeset in webkit [217321] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Increase test timeout for slow tests.
​https://bugs.webkit.org/show_bug.cgi?id=172449

Reviewed by Alexey Proskuryakov.

Instead of using a fixed timeout of 30 seconds for all tests, we should use the
timeout member in the TestRunner class.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setWaitToDump):

10:58 PM Changeset in webkit [217320] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch

Cherry-pick r217197. rdar://problem/32355285

10:39 PM Changeset in webkit [217319] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

CoreAudioCaptureSource is ducking system sound
​https://bugs.webkit.org/show_bug.cgi?id=172512

Reviewed by Youenn Fablet.

Manual testing.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::setupAudioUnit):
(WebCore::CoreAudioSharedUnit::defaultOutputDevice):

8:42 PM Changeset in webkit [217318] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit2

Resource Load Statistics: Don't include HSTS cache data in website data removal
​https://bugs.webkit.org/show_bug.cgi?id=172525
<rdar://problem/32332704>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::initializeDataTypesToRemove):

6:09 PM Changeset in webkit [217317] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: content views are not restored on reload if its tree element is filtered out
​https://bugs.webkit.org/show_bug.cgi?id=165744
<rdar://problem/27461323>

Reviewed by Devin Rousso.

By default, NavigationSidebar should get the selected represented object
from its content browser, instead of relying on the tree selection. This
allows a filtered tree selection to persist across page loads.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.get currentRepresentedObject):
(WebInspector.NavigationSidebarPanel.prototype.saveStateToCookie):
Get the represented object from the content browser instead of relying
on the tree selection (which can be filtered out).

(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
(WebInspector.NavigationSidebarPanel.prototype._treeElementWasFiltered):
Reselect the represented object's tree element when it is shown due
to a change in the filter state.

(WebInspector.NavigationSidebarPanel.prototype.get hasSelectedElement): Deleted.
Not used.
(WebInspector.NavigationSidebarPanel.prototype.representedObjectWasFiltered): Deleted.
Not used. Replaced by _treeElementWasFiltered.

6:06 PM Changeset in webkit [217316] by Said Abou-Hallawa
  • 2 edits in trunk/Source/WebCore

[iOS] Speculative fix for a PLT regression
<rdar://problem/32361890>

Unreviewed.

Make sure CGImageSourceGetTypeWithData() is called with a buffer which is
32 bytes or more.

  • platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoder::ImageDecoder):

5:33 PM Changeset in webkit [217315] by jiewen_tan@apple.com
  • 18 edits
    3 copies
    51 adds in trunk

[WebCrypto] Support RSA-PSS
​https://bugs.webkit.org/show_bug.cgi?id=170869
<rdar://problem/31640672>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch implements RSA-PSS according to the spec: ​https://www.w3.org/TR/WebCryptoAPI/#rsa-pss.
Supported operations include sign, verify, generateKey, importKey and exportKey.

Tests: crypto/subtle/rsa-pss-generate-export-key-jwk-sha1.html

crypto/subtle/rsa-pss-generate-export-key-jwk-sha224.html
crypto/subtle/rsa-pss-generate-export-key-jwk-sha256.html
crypto/subtle/rsa-pss-generate-export-key-jwk-sha384.html
crypto/subtle/rsa-pss-generate-export-key-jwk-sha512.html
crypto/subtle/rsa-pss-generate-export-key-pkcs8.html
crypto/subtle/rsa-pss-generate-export-key-spki.html
crypto/subtle/rsa-pss-generate-key.html
crypto/subtle/rsa-pss-import-jwk-private-key.html
crypto/subtle/rsa-pss-import-jwk-public-key-empty-usages.html
crypto/subtle/rsa-pss-import-jwk-public-key-sha1.html
crypto/subtle/rsa-pss-import-jwk-public-key-sha224.html
crypto/subtle/rsa-pss-import-jwk-public-key-sha256.html
crypto/subtle/rsa-pss-import-jwk-public-key-sha384.html
crypto/subtle/rsa-pss-import-jwk-public-key-sha512.html
crypto/subtle/rsa-pss-import-key-sign-large-salt.html
crypto/subtle/rsa-pss-import-key-sign.html
crypto/subtle/rsa-pss-import-key-verify.html
crypto/subtle/rsa-pss-import-pkcs8-key.html
crypto/subtle/rsa-pss-import-spki-key-empty-usages.html
crypto/subtle/rsa-pss-import-spki-key.html
crypto/workers/subtle/rsa-pss-import-key-sign.html
crypto/workers/subtle/rsa-pss-import-key-verify.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformGTK.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):

  • crypto/CryptoAlgorithmParameters.h:
  • crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp: Added.

(WebCore::CryptoAlgorithmRSA_PSS::create):
(WebCore::CryptoAlgorithmRSA_PSS::identifier):
(WebCore::CryptoAlgorithmRSA_PSS::sign):
(WebCore::CryptoAlgorithmRSA_PSS::verify):
(WebCore::CryptoAlgorithmRSA_PSS::generateKey):
(WebCore::CryptoAlgorithmRSA_PSS::importKey):
(WebCore::CryptoAlgorithmRSA_PSS::exportKey):

  • crypto/algorithms/CryptoAlgorithmRSA_PSS.h: Added.
  • crypto/mac/CryptoAlgorithmECDSAMac.cpp:

(WebCore::cryptoDigestAlgorithm): Deleted.
Extract function cryptoDigestAlgorithm to a separate file.

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::cryptoDigestAlgorithm): Deleted.
Extract function cryptoDigestAlgorithm to a separate file.

  • crypto/mac/CryptoAlgorithmRSA_PSSMac.cpp: Added.

(WebCore::signRSA_PSS):
(WebCore::verifyRSA_PSS):
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformVerify):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/mac/CryptoDigestAlgorithm.h: Added.

(WebCore::cryptoDigestAlgorithm):
Have cryptoDigestAlgorithm in a separate file.

  • crypto/parameters/CryptoAlgorithmRsaPssParams.h: Added.
  • crypto/parameters/RsaPssParams.idl: Added.

Source/WTF:

  • wtf/Platform.h:

Add a flag to enable RSA-PSS in the future.

LayoutTests:

Skip tests related to RSA-PSS for now.

  • crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
  • crypto/subtle/rsa-generate-key-malformed-parameters.html:
  • crypto/subtle/rsa-import-key-malformed-parameters-expected.txt:
  • crypto/subtle/rsa-import-key-malformed-parameters.html:
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha1-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha1.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha224-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha224.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha256-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha256.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha384-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha384.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha512-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-jwk-sha512.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-pkcs8-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-pkcs8.html: Added.
  • crypto/subtle/rsa-pss-generate-export-key-spki-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-export-key-spki.html: Added.
  • crypto/subtle/rsa-pss-generate-key-expected.txt: Added.
  • crypto/subtle/rsa-pss-generate-key.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-private-key-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-private-key.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-empty-usages-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-empty-usages.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha1-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha1.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha224-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha224.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha256-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha256.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha384-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha384.html: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha512-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-jwk-public-key-sha512.html: Added.
  • crypto/subtle/rsa-pss-import-key-sign-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-key-sign-large-salt-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-key-sign-large-salt.html: Added.
  • crypto/subtle/rsa-pss-import-key-sign.html: Added.
  • crypto/subtle/rsa-pss-import-key-verify-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-key-verify.html: Added.
  • crypto/subtle/rsa-pss-import-pkcs8-key-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-pkcs8-key.html: Added.
  • crypto/subtle/rsa-pss-import-spki-key-empty-usages-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-spki-key-empty-usages.html: Added.
  • crypto/subtle/rsa-pss-import-spki-key-expected.txt: Added.
  • crypto/subtle/rsa-pss-import-spki-key.html: Added.
  • crypto/workers/subtle/resources/rsa-pss-import-key-sign.js: Added.
  • crypto/workers/subtle/resources/rsa-pss-import-key-verify.js: Added.
  • crypto/workers/subtle/rsa-pss-import-key-sign-expected.txt: Added.
  • crypto/workers/subtle/rsa-pss-import-key-sign.html: Added.
  • crypto/workers/subtle/rsa-pss-import-key-verify-expected.txt: Added.
  • crypto/workers/subtle/rsa-pss-import-key-verify.html: Added.
5:32 PM Changeset in webkit [217314] by sbarati@apple.com
  • 3 edits
    1 add in trunk

We should not mmap zero bytes for a memory in Wasm
​https://bugs.webkit.org/show_bug.cgi?id=172528
<rdar://problem/32257076>

Reviewed by Mark Lam.

JSTests:

  • wasm/js-api/dont-mmap-zero-byte-memory.js: Added.

(testMems):

Source/JavaScriptCore:

This patch fixes a bug where we would call into mmap with zero bytes
when creating a slow WasmMemory with zero initial page size. This fix
is simple: if we don't have any initial bytes, we just call the constructor
in WasmMemory that's meant to handle this case.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::create):

5:31 PM Changeset in webkit [217313] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

5:27 PM Changeset in webkit [217312] by Chris Dumez
  • 7 edits in trunk/LayoutTests

Some async tests ignore jsTestIsAsync when ported from js-test-pre.js / js-test-post.js to js-test.js
​https://bugs.webkit.org/show_bug.cgi?id=172523

Reviewed by Ryosuke Niwa.

This test used to be flaky because jsTestIsAsync was ignored. It now consistently times out.

  • fast/dom/script-charset-update.html:

Port test to js-test.js instead of js-test-pre.js / js-test-post.js now that it works.

  • fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt:

Rebaseline test now that it actually runs to the end.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:

Remove expectation for a test that is now skipped in root TestExpectations file.

  • resources/js-test.js:

Call testRunner.waitUntilDone() in the DOMContentLoader event listener if jsTestIsAsync is already
set then, instead of waiting for the load event listener to do so. This is needed because some
tests may decide to complete *before* the load event has fired, such as the test updated in this
patch. We still need to call testRunner.waitUntilDone() in the load event listener as well because
some tests only set jsTestIsAsync in a load event handler.

5:07 PM Changeset in webkit [217311] by eric.carlson@apple.com
  • 5 edits in trunk/Source/WebCore

[MediaStream] Allow transition from autoplay to play when a capture stream begins.
​https://bugs.webkit.org/show_bug.cgi?id=172391
<rdar://problem/32304934>

Reviewed by Youenn Fablet.

Manual testing. Regression testing to be added as a follow-up.

  • dom/Document.cpp:

(WebCore::Document::updateIsPlayingMedia): Call mediaStreamCaptureStateChanged when capture
state changes.
(WebCore::Document::registerForMediaStreamStateChangeCallbacks):
(WebCore::Document::unregisterForMediaStreamStateChangeCallbacks):
(WebCore::Document::mediaStreamCaptureStateChanged): Call all registered elements.

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::registerWithDocument): Register for capture state changes.
(WebCore::HTMLMediaElement::unregisterWithDocument): Unregister for capture state changes.
(WebCore::HTMLMediaElement::mediaStreamCaptureStateChanged): Attempt autoplay as necessary.

  • html/HTMLMediaElement.h:
5:01 PM Changeset in webkit [217310] by mrajca@apple.com
  • 10 edits
    2 adds in trunk

Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
​https://bugs.webkit.org/show_bug.cgi?id=172138

Reviewed by Alex Christensen.

Source/WebCore:

The current autoplay signals that are fired at navigation may not get delivered to the UIProcess if the WebPage is close()'ed around
this time. This patch simplifies this and just notifies clients if a media element has played past a threshold.

Updated API tests.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::userDidInterfereWithAutoplay):

  • page/AutoplayEvent.h:

Source/WebKit2:

Updated auto-play event types.

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:

Tools:

Added API tests.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
5:01 PM Changeset in webkit [217309] by BJ Burg
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r217051): Automation sessions fail to complete bootstrap
​https://bugs.webkit.org/show_bug.cgi?id=172513
<rdar://problem/32338354>

Reviewed by Joseph Pecoraro.

The changes to be more strict about typechecking messages were too strict.

  • inspector/remote/cocoa/RemoteInspectorCocoa.mm:

(Inspector::RemoteInspector::receivedSetupMessage):
WIRAutomatically is an optional key in the setup message. In the relay, this key gets copied
into an NSDictionary as NSNull if the key isn't present in a forwarded command.
We need to revert NSNull values to nil, since it's valid to call [nil boolValue] but not
[[NSNull null] boolValue]. We also need to allow for nil in the typecheck for this key.

5:00 PM Changeset in webkit [217308] by Ryan Haddad
  • 7 edits in trunk/LayoutTests

Rebaseline tests for iOS simulator.

Unreviewed test gardening.

  • fast/events/ios/rotation/basic-rotation-expected.txt:
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-block-scrolling-state-expected.txt:
  • fast/events/touch/ios/block-without-overflow-scroll-and-passive-observer-on-document-scrolling-state-expected.txt:
  • fast/events/touch/ios/block-without-overflow-scroll-scrolling-state-expected.txt:
  • fast/events/touch/ios/tap-with-active-touch-end-listener-expected.txt:
  • fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
4:45 PM Changeset in webkit [217307] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

ASSERT(!m_timeoutTimer.isActive()) hit in BackgroundProcessResponsivenessTimer::responsivenessCheckTimerFired()
​https://bugs.webkit.org/show_bug.cgi?id=172509
<rdar://problem/32251578>

Reviewed by Geoffrey Garen.

In the BackgroundProcessResponsivenessTimer class, we have 2 timers:

  • m_responsivenessCheckTimer that causes us to do an IPC handshake with the WebProcess.
  • m_timeoutTimer that is started when we send the IPC message to the WebProcess and which is stopped when we get the response from the WebProcess. If we do not get the response by the time m_timeoutTimer fires, then we mark the process as unresponsive.

As a result, of the behavior above, whenever the BackgroundProcessResponsivenessTimer
is considered "active", there should be one of the 2 timers above that
is active, and only one.

The assertion hit showed that we decided to start the m_responsivenessCheckTimer
timer even though the m_timeoutTimer timer is still active (we are still waiting
for an IPC message from the WebProcess and the process is not considered
unresponsive yet), which is wrong. The reason was that in
BackgroundProcessResponsivenessTimer::updateState(), if we should be active,
we would start the m_responsivenessCheckTimer if m_responsivenessCheckTimer is
not already active, without checking if m_timeoutTimer is active. So if
updateState() was called while the IPC handshake was in process, we would have
both timers running at the same time.

  • UIProcess/BackgroundProcessResponsivenessTimer.cpp:

(WebKit::BackgroundProcessResponsivenessTimer::updateState):
(WebKit::BackgroundProcessResponsivenessTimer::isActive):

  • UIProcess/BackgroundProcessResponsivenessTimer.h:
3:58 PM Changeset in webkit [217306] by Matt Baker
  • 5 edits in trunk

Web Inspector: Cannot delete a disabled XHR breakpoint
​https://bugs.webkit.org/show_bug.cgi?id=171971
<rdar://problem/32129527>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WebInspector.DOMDebuggerManager.prototype.removeXHRBreakpoint):
Dispatch XHRBreakpointRemoved event before removing the breakpoint from
the backend. A disabled breakpoint will have already been removed, and
an enabled breakpoint that fails to get removed from the backend should
be removed from the frontend, to prevent it being resolved in the future.
Drive-by fix: remove spurious dispatch of DOMBreakpointRemoved event.

(WebInspector.DOMDebuggerManager.prototype._detachXHRBreakpoint): Deleted.
Merged with removeXHRBreakpoint to simplify implementation.

LayoutTests:

  • inspector/dom-debugger/xhr-breakpoints-expected.txt:
  • inspector/dom-debugger/xhr-breakpoints.html:
3:55 PM Changeset in webkit [217305] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip crashing css-display-3/display-contents tests.
​https://bugs.webkit.org/show_bug.cgi?id=172503

Unreviewed test gardening.

3:54 PM Changeset in webkit [217304] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.21.8

Tag Safari-604.1.21.8.

2:44 PM Changeset in webkit [217303] by Simon Fraser
  • 4 edits in trunk

Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=172522
rdar://problem/31071812

Source/WebKit/mac:

Reviewed by Tim Horton.

There's no need to consult -[NSWindow viewsNeedDisplay] on newer OSes. It was
added in r58623, and modified in r61204 for Carbon apps, but with more recent AppKit
versions this synchronization is no longer required.

  • WebView/WebView.mm:

(LayerFlushController::flushLayers):

Tools:

Reviewed by Sam Weinig.

Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
We set this in the .xib file now.

  • MiniBrowser/mac/MiniBrowser_Prefix.pch:
2:33 PM Changeset in webkit [217302] by Manuel Rego Casasnovas
  • 2 edits
    35 copies
    2 adds
    1 delete in trunk/LayoutTests/imported/w3c

Move css-scoping-1 test suite to WPT
​https://bugs.webkit.org/show_bug.cgi?id=172500

Reviewed by Youenn Fablet.

csswg-test repo was merged into web-platform-tests a while ago,
this patch moves the css-scoping-1 test suite to the new path.

  • csswg-test/css-scoping-1/w3c-import.log: Removed.
  • resources/import-expectations.json:
  • web-platform-tests/css/css-scoping-1/OWNERS: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/OWNERS.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-assigned-node-with-before-after-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-assigned-node-with-before-after-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-assigned-node-with-before-after.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-assigned-node-with-before-after.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-assigned-node-with-rules-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-assigned-node-with-rules-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-assigned-node-with-rules.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-assigned-node-with-rules.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-functional-rule-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-functional-rule-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-functional-rule.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-functional-rule.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-rule-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-rule-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-rule.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-rule.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-with-before-after-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-with-before-after-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-with-before-after.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-host-with-before-after.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-invisible-slot-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-invisible-slot-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-invisible-slot.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-invisible-slot.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-root-hides-children-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-root-hides-children-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-root-hides-children.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-root-hides-children.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-display-override-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-display-override-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-display-override.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-display-override.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-fallback-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-fallback-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-fallback.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-fallback.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-style-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-style-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot-style.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot-style.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slot.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slot.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slotted-nested-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slotted-nested-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slotted-nested.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slotted-nested.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slotted-rule-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slotted-rule-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-slotted-rule.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-slotted-rule.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-outside-rules-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-outside-rules-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-outside-rules.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-outside-rules.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-rules-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-rules-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-rules-no-style-leak-expected.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-rules-no-style-leak-expected.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-rules-no-style-leak.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-rules-no-style-leak.html.
  • web-platform-tests/css/css-scoping-1/css-scoping-shadow-with-rules.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/css-scoping-shadow-with-rules.html.
  • web-platform-tests/css/css-scoping-1/shadow-cascade-order-001-expected.txt: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001-expected.txt.
  • web-platform-tests/css/css-scoping-1/shadow-cascade-order-001.html: Renamed from LayoutTests/imported/w3c/csswg-test/css-scoping-1/shadow-cascade-order-001.html.
  • web-platform-tests/css/css-scoping-1/w3c-import.log: Added.
2:30 PM Changeset in webkit [217301] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html as failing.
​https://bugs.webkit.org/show_bug.cgi?id=172515

Unreviewed test gardening.

2:06 PM Changeset in webkit [217300] by Chris Dumez
  • 5 edits
    3 adds in trunk/LayoutTests
Regression(r215229): ASSERTION FAILED: !m_scriptHash
m_scriptHash == m_script.impl()->hash()

​https://bugs.webkit.org/show_bug.cgi?id=171091
<rdar://problem/31752046>

Reviewed by Geoffrey Garen.

  • fast/dom/resources/script-with-unicode.js: Added.
  • fast/dom/script-charset-update-expected.txt: Added.
  • fast/dom/script-charset-update.html: Added.

Add test that was consistently hitting the assertion in debug builds before
r215229 was rolled out.

  • fast/loader/cache-encoding-expected.txt:
  • fast/loader/cache-encoding.html:

Improve test to check that it is actually getting a SyntaxError the first time,
when it loads the script with the wrong encoding. Apparently this test was not
clear enough because it was updated / disabled in r215229, but was showing a
real bug.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:

Unskip test was should no longer be flaky now that r215229 has been rolled out.

1:59 PM Changeset in webkit [217299] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/webrtc/getstats.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=172521

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:49 PM Changeset in webkit [217298] by dino@apple.com
  • 12 edits
    2 adds in trunk

checkGPUStatus needs to exercise instancing calls
​https://bugs.webkit.org/show_bug.cgi?id=172520
<rdar://problem/23118395>

Reviewed by Brent Fulgham.

Source/WebCore:

The checkGPUStatus method (formerly checkGPUStatusIfNecessary) was
not being called after the drawArrays/Elements instancing calls.

I also added a test case to exercise the recovery logic.

Test: fast/canvas/webgl/lose-context-on-status-failure.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::setFailNextGPUStatusCheck): Force
the next checkGPUStatus on the GC3D to fail.

  • html/canvas/WebGLRenderingContextBase.h:
  • platform/graphics/GraphicsContext3D.h: Rename a function, and make

the number of calls we wait before checking per instance, rather than
static (which might have meant we're only ever checking after one canvas on
a page with multiple contexts).
(WebCore::GraphicsContext3D::setFailNextGPUStatusCheck):

  • platform/graphics/cairo/GraphicsContext3DCairo.cpp:

(WebCore::GraphicsContext3D::checkGPUStatus): Renamed.
(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Deleted.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::checkGPUStatus): Improve the logic.
(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Deleted.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::clear):
(WebCore::GraphicsContext3D::drawArrays):
(WebCore::GraphicsContext3D::drawElements):
(WebCore::GraphicsContext3D::drawArraysInstanced): Add a call to checkGPUStatus.
(WebCore::GraphicsContext3D::drawElementsInstanced): Ditto.

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::checkGPUStatus):
(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Deleted.

  • testing/Internals.cpp: Implement the internal call to cause the next

check to fail.
(WebCore::Internals::failNextGPUStatusCheck):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/canvas/webgl/lose-context-on-status-failure-expected.txt: Added.
  • fast/canvas/webgl/lose-context-on-status-failure.html: Added.
1:49 PM Changeset in webkit [217297] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WebIDL] Further cleanup enumeration handling
​https://bugs.webkit.org/show_bug.cgi?id=172516

Patch by Sam Weinig <​sam@webkit.org> on 2017-05-23
Reviewed by Chris Dumez.

  • bindings/scripts/CodeGeneratorJS.pm:

(GeneratePut):
(GeneratePutByIndex):
(GenerateDictionaryImplementationContent):
(GenerateParametersCheck):
(GenerateCallbackImplementationContent):
Update now that JSValueToNative doesn't have a second return value.

(GenerateImplementation):
Add enumeration special casing to attribute setting code, where it is special
cased in the standard

(PassArgumentExpression):
Stop special casing enumerations.

(IsValidContextForJSValueToNative):
Assert that enums are never passed to JSValueToNative in an attribute context.

(JSValueToNative):
Remove enumeration special case and second return value (which was always 1).

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjEnumAttrFunction):
(WebCore::setJSTestObjImplementationEnumAttrFunction):
(WebCore::setJSTestObjAttributeWithReservedEnumTypeFunction):
Update results.

1:44 PM Changeset in webkit [217296] by Simon Fraser
  • 61 edits
    1 add in trunk

Snapshotting via -renderInContext: should do synchronous image decodes
​https://bugs.webkit.org/show_bug.cgi?id=172485
rdar://problem/32276146

Reviewed by Tim Horton.

Source/WebCore:

When UIWebView clients snapshot the view via -renderInContext: on the UIView's layer,
WebKit should do synchronous image decodes so that the images show in the snapshot.

Fix by plumbing through a "snapshotting" paint behavior flag from two source locations:
WebSimpleLayer, used by compositing layers, and LegacyTileLayer, used for the WK1 tile cache.
On WebSimpleLayer the flag propagates through PlatformCALayer to GraphicsLayer, and on LegacyTileLayer
it sets some state on the WAKWindow, which is detected by -[WebFrame _paintBehaviorForDestinationContext:].
In both cases, the flag becomes PaintBehaviorSnapshotting which is passed down through painting
in PaintInfo.paintBehavior.

Fix code that was checking paintBehavior on the FrameView to just looking at PaintInfo.paintBehavior,
which required passing PaintInfo along in RenderImage::paintIntoRect().

We can't just use the PaintBehaviorFlattenCompositingLayers flag, because that triggers
a flattening paint of compositing layers, and we don't want that behavior for -renderInContext:,
since CoreAnimation calls -renderInContext: on each of our layers and we need to avoid double-painting.
So PaintBehaviorSnapshotting is now added to the call sites that also set PaintBehaviorFlattenCompositingLayers
in most cases.

Tested by SnapshotViaRenderInContext API test.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • page/FrameView.cpp:

(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::paintContentsForSnapshot):

  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::paintContents):

  • page/PageOverlayController.h:
  • page/mac/ServicesOverlayController.h:
  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::paintContents):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::paintGraphicsLayerContents):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::paintContents):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/PlatformCALayerClient.h:
  • platform/graphics/ca/TileCoverageMap.cpp:

(WebCore::TileCoverageMap::platformCALayerPaintContents):

  • platform/graphics/ca/TileCoverageMap.h:
  • platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::platformCALayerPaintContents):

  • platform/graphics/ca/TileGrid.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayer::drawLayerContents):

  • platform/graphics/mac/WebLayer.mm:

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer renderInContext:]):
(-[WebSimpleLayer drawInContext:]):

  • platform/ios/LegacyTileCache.h: Use initializers.
  • platform/ios/LegacyTileCache.mm:

(WebCore::LegacyTileCache::LegacyTileCache):
(WebCore::LegacyTileCache::drawWindowContent):
(WebCore::LegacyTileCache::drawLayer):

  • platform/ios/LegacyTileLayer.h:
  • platform/ios/LegacyTileLayer.mm:

(-[LegacyTileHostLayer renderInContext:]):
(-[LegacyTileLayer renderInContext:]):
(-[LegacyTileLayer drawInContext:]):
(+[LegacyTileLayer layerBeingPainted]): Deleted. There were no callers.

  • platform/ios/wak/WAKView.mm:

(-[WAKView _drawRect:context:lockFocus:]): bool -> BOOL

  • platform/ios/wak/WAKWindow.h:
  • platform/ios/wak/WAKWindow.mm:

(-[WAKWindow setIsInSnapshottingPaint:]):
(-[WAKWindow isInSnapshottingPaint]):

  • rendering/PaintPhase.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintMaskImages):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::paintContents):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::paintReplaced):

Source/WebKit/mac:

Remove the _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap: SPI that no longer
has any callers.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView inFlatteningPaint]): Deleted.

  • WebView/WebFrame.mm:

(-[WebFrame _paintBehaviorForDestinationContext:]):
(-[WebFrame _drawRect:contentsOnly:]):
(-[WebFrame _shouldFlattenCompositingLayers:]): Deleted.

  • WebView/WebHTMLView.mm:

(imageFromRect):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]): Deleted.
(-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]): Deleted.

  • WebView/WebViewData.h:
  • WebView/WebViewPrivate.h:

Source/WebKit2:

Pass the PaintBehaviorSnapshotting flag in functions that do snapshotting.

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

Tools:

New API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.

(-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
(-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
(TestWebKitAPI::getPixelIndex):
(TestWebKitAPI::TEST):

1:34 PM Changeset in webkit [217295] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: use initialLayout for NetworkSidebarPanel
​https://bugs.webkit.org/show_bug.cgi?id=172470

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel):
(WebInspector.NetworkSidebarPanel.prototype.showDefaultContentView):
(WebInspector.NetworkSidebarPanel.prototype.initialLayout):
Don't create NetworkGridContentView until right before it is shown.

1:31 PM Changeset in webkit [217294] by Manuel Rego Casasnovas
  • 6 edits
    109 adds in trunk/LayoutTests

[css-grid] Import css/css-grid-1/alignment/ from WPT (8df7c9c215)
​https://bugs.webkit.org/show_bug.cgi?id=172494

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

This patch imports the new alignment tests for the CSS Grid Layout test suite
from WPT repository. It also needs to start importing "css/reference" folder
as some of the new tests were pointing to reference files there
and the importer wasn't able to get them.

  • resources/import-expectations.json:
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-001.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-002.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-003.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-004.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-005.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-006-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-006.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-007-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-007.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-008-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-008.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-009-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-009.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-010-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-010.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-011-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-011.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-012-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-012.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-013-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-013.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-014-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-014.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-015-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-015.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-016-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-016.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-017-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-017.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-018-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-018.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-019-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-019.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-020-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-020.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-021-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-021.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-022-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-022.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-023-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-023.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-024-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-024.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-025-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-025.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-001-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-001.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-002-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-002.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-003-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-003.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-004.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-005-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-005.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-006-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-006.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-007-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-007.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-008-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-008.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-009-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-009.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-010-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-010.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-011-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-011.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-012-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-012.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-013-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-013.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-014-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-014.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-015-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-015.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-016-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-016.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-017-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-017.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-018-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-018.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-019-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-019.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-020-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-020.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-021-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-021.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-022.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-023-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-023.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-024-expected.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/grid-content-distribution-with-collapsed-tracks-024.html: Added.
  • web-platform-tests/css/css-grid-1/alignment/w3c-import.log: Added.
  • web-platform-tests/css/css-grid-1/grid-items/w3c-import.log:
  • web-platform-tests/css/css-grid-1/grid-model/w3c-import.log:
  • web-platform-tests/css/reference/OWNERS: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_match_bold-expected.xht: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_match_bold.xht: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_match_smallcaps-expected.xht: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_match_smallcaps.xht: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_underlined-expected.html: Added.
  • web-platform-tests/css/reference/pass_if_filler_text_underlined.html: Added.
  • web-platform-tests/css/reference/w3c-import.log: Added.

LayoutTests:

1:24 PM Changeset in webkit [217293] by mmaxfield@apple.com
  • 25 edits
    3 deletes in trunk

Remove dead ENABLE(FONT_LOAD_EVENTS) code
​https://bugs.webkit.org/show_bug.cgi?id=172517

Rubber-stamped by Simon Fraser.

.:

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSFontFaceLoadEvent.cpp: Removed.
  • css/CSSFontFaceLoadEvent.h: Removed.
  • css/CSSFontFaceLoadEvent.idl: Removed.
  • dom/EventNames.in:
  • page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled): Deleted.

Source/WebCore/PAL:

No new tests because there is no behavior change.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1:23 PM Changeset in webkit [217292] by ap@apple.com
  • 22 edits in trunk/LayoutTests

Many editing js-tests use waitUntilDone
​https://bugs.webkit.org/show_bug.cgi?id=172401

Reviewed by Ryosuke Niwa.

Corrected the use of js-test harness, updated the tests to use js-test.js instead
of js-test-pre.js where possible.

  • editing/caret/ios/absolute-caret-position-after-scroll.html:
  • editing/caret/ios/fixed-caret-position-after-scroll.html:
  • editing/input/style-change-during-input.html:
  • editing/inserting/insert-html-crash.html:
  • editing/mac/input/undo-grouping-on-text-insertion.html:
  • editing/mac/selection/context-menu-select-editability-expected.txt:
  • editing/mac/selection/context-menu-select-editability.html:
  • editing/mac/spelling/accept-candidate-undo-does-not-select.html:
  • editing/mac/spelling/autocorrection-respets-undo-expected.txt:
  • editing/mac/spelling/autocorrection-respets-undo.html:
  • editing/pasteboard/drag-and-drop-attachment-contenteditable.html:
  • editing/pasteboard/drag-and-drop-image-contenteditable.html:
  • editing/pasteboard/drag-and-drop-inputimage-contenteditable.html:
  • editing/pasteboard/drag-and-drop-objectimage-contenteditable.html:
  • editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt:
  • editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html:
  • editing/selection/ios/absolute-selection-after-scroll.html:
  • editing/selection/ios/fixed-selection-after-scroll.html:
  • editing/spelling/copy-paste-crash-expected.txt:
  • editing/spelling/copy-paste-crash.html:
  • editing/style/apply-style-join-child-text-nodes-crash.html:
12:51 PM Changeset in webkit [217291] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

[WTF] Export additional symbols in threading
​https://bugs.webkit.org/show_bug.cgi?id=171952

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-05-23
Reviewed by Konstantin Tokarev.

  • wtf/ThreadMessage.h:
  • wtf/threads/Signals.h:
12:46 PM Changeset in webkit [217290] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, test gardening after r217225

Gardening about imported/w3c/web-platform-tests/WebCryptoAPI/

12:39 PM Changeset in webkit [217289] by Chris Dumez
  • 15 edits in trunk

Unreviewed, roll out r215229

It caused CachedScripts in MemoryCache to be reused with different encodings
even though CachedScript potentially has already decoded data or cached hash
with a previous encoding.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-01-expected.txt:

Source/WebCore:

  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::setEncoding):

  • loader/TextResourceDecoder.h:

(WebCore::TextResourceDecoder::sawError):
(WebCore::TextResourceDecoder::encodingSet): Deleted.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::setEncoding):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::hasUnknownEncoding):
(WebCore::CachedResource::setHasUnknownEncoding):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::determineRevalidationPolicy):

LayoutTests:

  • TestExpectations:
  • fast/loader/cache-encoding-expected.txt:
  • fast/loader/cache-encoding.html:
  • http/tests/preload/preload-encoding-expected.txt:
  • http/tests/preload/preload-encoding.php:
11:58 AM Changeset in webkit [217288] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Zoom in/out is slow in Safari with large PDFs
​https://bugs.webkit.org/show_bug.cgi?id=172495
<rdar://problem/32338631>

Reviewed by Simon Fraser.

No tests; just a performance improvement.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::computePageBoxes):
Use PDFKit instead of CGPDF to compute the first page box, so we can take
advantage of PDFKit optimizations. PDFKit also handles box fallback,
so we don't need to do that ourselves. Stop fetching all the boxes, as
we only seem to use the first one.

11:49 AM Changeset in webkit [217287] by sbarati@apple.com
  • 3 edits
    1 add in trunk

CFGSimplificationPhase should not merge a block with itself
​https://bugs.webkit.org/show_bug.cgi?id=172508
<rdar://problem/28424006>

Reviewed by Keith Miller.

JSTests:

  • stress/dont-crash-in-cfg-simplification.js: Added.

(bar):
(baz):
(foo):

Source/JavaScriptCore:

CFGSimplificationPhase can run into or create IR that ends up with a
block that has a Jump to itself, and no other predecessors. It should
gracefully handle such IR. Before this patch, it would not. The only criteria
for merging 'block' with 'targetBlock' used to be that 'targetBlock.predecessors.size() == 1'.
The code is written in such a way that if we merge a block with itself, we
will infinite loop until we run out of memory.

Merging a block with itself does not make sense for a few reasons. First,
we're joining the contents of two blocks. What is the definition of joining
a block with itself? I suppose we could simply unroll this self loop
one level, but that would not be wise because this self loop is by definition
unreachable unless it's the root block in the graph (which I think is
invalid IR since we'd never generate bytecode that would do this).

This patch employs an easy fix: we can't merge a block with itself.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::canMergeBlocks):
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

11:37 AM Changeset in webkit [217286] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: !renderer().view().needsLayout() while running media/video-main-content-autoplay.html
​https://bugs.webkit.org/show_bug.cgi?id=172476

Reviewed by Simon Fraser.

This patch decouples the layout call logic from the post layout task timer setup.
Just because we are switching over to asynchronous performPostLayoutTasks() it should not stop us from
running layout on a dirty tree (we could encounter a forced layout (which sets m_postLayoutTasksTimer active)
and a subsequent tree mutation during performPostLayoutTasks()).

There are a few different ways to end up here:
root layout is done -> call performPostLayoutTasks() synchronously ->

  1. tree stays clean -> no action needed.
  2. tree gets dirty -> setup performPostLayoutTasks timer -> run nested layout -> since m_postLayoutTasksTimer is active()

we don't try to run performPostLayoutTasks() while in the nested layout and we return with a clean tree.

  • page/FrameView.cpp:

(WebCore::FrameView::layout):

11:36 AM Changeset in webkit [217285] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip LayoutTest imported/w3c/web-platform-tests/innerText/getter.html.
​https://bugs.webkit.org/show_bug.cgi?id=172514

Unreviewed test gardening.

11:27 AM Changeset in webkit [217284] by Wenson Hsieh
  • 4 edits in trunk

Multiple links should be inserted separately when performing data interaction
​https://bugs.webkit.org/show_bug.cgi?id=172489
<rdar://problem/31510832>

Reviewed by Dan Bernstein.

Source/WebCore:

In WebContentReader, URLs are currently always inserted inline. When inserting multiple items, this causes
adjacent links to be inserted on a single line with no break, which is undesirable. To address this, when
appending links from additional items to the existing document fragment in WebContentReader, insert a new space
prior to inserting the anchor element.

New unit test: DataInteractionTests.ExternalSourceMultipleURLsToContentEditable

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::addFragment):

Tweak to add all children of the new fragment, rather than just the first child.

(WebCore::Editor::WebContentReader::readURL):

Tools:

Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

11:20 AM Changeset in webkit [217283] by timothy_horton@apple.com
  • 4 edits in trunk

REGRESSION: API test WebKit2.WKObject is failing
​https://bugs.webkit.org/show_bug.cgi?id=172497
<rdar://problem/31694641>

Reviewed by Geoff Garen.

  • Shared/Cocoa/WKNSString.mm:

(-[WKNSString superclass]):
(-[WKNSString class]):
Pretend to be NSString instead of the more specific subclass (NSCFString)
that we actually are. There is code underneath us that assumes that if
-class returns NSCFString, that the object is a CFStringRef, which is
not true in our case.

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:

(TestWebKitAPI::TEST):
Add a test that ensures that we pretend to at least be *some* kind of
NSString, which my first fix would not have passed.

9:35 AM Changeset in webkit [217282] by Ryan Haddad
  • 3 edits in branches/safari-604.1.21-branch/Tools

Merge r216899. rdar://problem/32352868

9:30 AM Changeset in webkit [217281] by commit-queue@webkit.org
  • 16 edits in trunk

[WebIDL] Remove some unnecessary specialization for enum types
​https://bugs.webkit.org/show_bug.cgi?id=172482

Patch by Sam Weinig <​sam@webkit.org> on 2017-05-23
Reviewed by Chris Dumez.

Source/WebCore:

  • Removes convertEnumeration template function and generated specialization. convert<IDLEnumeration<T>> now does the entire check, and can have specialized exceptions.
  • Treats enums more like all other types, removing enum specific code in the generator.

Also fixes some order of exception bugs as the convertEnumeration<T> implementations
were not correctly catching exceptions thrown in parseEnumeration<T>.

  • bindings/js/JSDOMConvertEnumeration.h:

(WebCore::Converter<IDLEnumeration<T>>::convert):
Remove convertEnumeration and move implementation to convert. Add ExceptionThrower
parameter to retain argument conversion exception specialization and allow future
specialization for other contexts.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::jsSubtleCryptoFunctionImportKeyPromise):
(WebCore::jsSubtleCryptoFunctionExportKeyPromise):
(WebCore::jsSubtleCryptoFunctionWrapKeyPromise):
(WebCore::jsSubtleCryptoFunctionUnwrapKeyPromise):
Switch from convertEnumeration<T> to convert<IDLEnumeration<T>>.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetArgumentExceptionFunction):
Add (really move from GenerateParametersCheck) enum specific argument conversion exception.

(PassArgumentExpression):
Allow the enum specific code for attributes to remain by explicitly checking the context.
Attribute setters use parseEnumeration<T> explicitly, as WebIDL mandates slightly different
behavior, specially that they don't throw.

(GenerateEnumerationImplementationContent):
(GenerateEnumerationHeaderContent):
Remove convertEnumeration<T>.

(GenerateParametersCheck):
Remove entire branch devoted to enums. The main parameter check is now mature enough
to handle them.

(JSValueToNative):
Like in PassArgumentExpression, we need to retain the specialize behavior for attributes.
Before, JSValueToNative was only called for enums with a context of IDLAttribute or IDLDictionaryMember,
but now that we use if IDLArguments as well, it makes more sense to make this check in terms
of the odd man out, IDLAttribute.

  • bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
  • bindings/scripts/test/JS/JSTestCallbackInterface.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:
  • bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
  • bindings/scripts/test/JS/JSTestStandaloneEnumeration.cpp:
  • bindings/scripts/test/JS/JSTestStandaloneEnumeration.h:

Update test results.

LayoutTests:

  • crypto/subtle/import-key-malformed-parameters-expected.txt:
  • fast/files/blob-constructor-expected.txt:
  • fast/files/script-tests/blob-constructor.js:

Update test and results for improved order of exceptions. In this case, the conversion
to String throws before the failure to parse the enumeration (which is what the
plain TypeError was).

9:27 AM Changeset in webkit [217280] by commit-queue@webkit.org
  • 4 edits
    98 adds in trunk/LayoutTests

Import the css-display-3 css tests.
​https://bugs.webkit.org/show_bug.cgi?id=172212

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-23
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/css/css-display-3/OWNERS: Added.
  • web-platform-tests/css/css-display-3/display-contents-alignment-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-alignment-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-alignment-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-alignment-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-before-after-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-before-after-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-before-after-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-before-after-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-block-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-block-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-block-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-block-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-computed-style-expected.txt: Added.
  • web-platform-tests/css/css-display-3/display-contents-computed-style.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-first-letter-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-before-after-first-letter-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-001-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-flex-003-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-inline-flex-001-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-list-001-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-multicol-001-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-001-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-inline.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-dynamic-table-002-none.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-first-letter-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-first-letter-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-first-line-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-first-line-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-003-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-flex-003.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-float-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-float-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-inline-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-inline-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-inline-flex-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-list-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-list-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-multicol-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-multicol-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-oof-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-oof-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-oof-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-oof-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-replaced-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-replaced-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-state-change-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-state-change-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-table-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-table-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-table-002-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-table-002.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-td-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-td-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-text-only-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-text-only-001.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-tr-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-contents-tr-001.html: Added.
  • web-platform-tests/css/css-display-3/display-flow-root-001-expected.html: Added.
  • web-platform-tests/css/css-display-3/display-flow-root-001.html: Added.
  • web-platform-tests/css/css-display-3/support/acid.css: Added.

(html, body):
(body):
(.table):
(.itable):
(.caption):
(.cell):
(.row):
(.rowg):
(.head):
(.foot):
(.col):
(.colg):
(.flex):
(.iflex):
(.li):
(.ib):
(.inline):
(.columns):
(.contents):
(.c1):
(.c2):
(.c3):
(.c4):
(.c5):
(.c6):
(.c7):
(.c8):
(.c9):
(.c10):
(.b):
(.ref .c2):
(.ref .b):
(.ref div.contents):
(.ref span.contents):

  • web-platform-tests/css/css-display-3/support/swatch-orange.png: Added.
  • web-platform-tests/css/css-display-3/support/util.js: Added.

(eachDisplayContentsElementIn):

  • web-platform-tests/css/css-display-3/support/w3c-import.log: Added.
  • web-platform-tests/css/css-display-3/w3c-import.log: Added.
9:24 AM Changeset in webkit [217279] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Readable Streams API] Align respondInClosedState with spec
​https://bugs.webkit.org/show_bug.cgi?id=172288

Patch by Romain Bellessort <​romain.bellessort@crf.canon.fr> on 2017-05-23
Reviewed by Chris Dumez.

Two changes are implemented in this patch:

  • Change #1: An issue was reported to GH [1] while working on respondInClosedState

implementation. This issue has now been fixed, and this patch aligns implementation
with spec [2].

  • Change #2: In addition, this patch also fixes a bug that went unnoticed as code

is not yet reachable (usage of controller.@reader is not valid and is therefore
replaced by controller.@controlledReadableStream.@reader).

[1] ​https://github.com/whatwg/streams/issues/686
[2] ​https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-in-closed-state

No added test as:

  • Change #1 does not change behavior;
  • Change #2 is not testable as the code is not yet reachable.
  • Modules/streams/ReadableByteStreamInternals.js:

(readableByteStreamControllerRespondInClosedState): Aligned with spec.

9:06 AM Changeset in webkit [217278] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit2

[WK2][iOS] Add a mach-lookup exception for 'com.apple.analyticsd'
​https://bugs.webkit.org/show_bug.cgi?id=172462
<rdar://problem/32331638>

Reviewed by Alexey Proskuryakov.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
8:57 AM Changeset in webkit [217277] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit2

[WK2][iOS] Adopt a whitelist for XPC services
​https://bugs.webkit.org/show_bug.cgi?id=172182
<rdar://problem/30669445>

Reviewed by Sam Weinig.

Tell the Sandbox to block all XPC connections that are not explicitly allowed by
the sandbox profile. The default behavior is to allow everything by default.

If the restriction is set before including the standard iOS sandbox profiles, there
does not seem to be a need to white list any other services.

General web browsing on multiple devices indicate that these sandbox profiles work
properly with media, accessibility, webgl, and general web content.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
8:56 AM Changeset in webkit [217276] by commit-queue@webkit.org
  • 11 edits
    1 copy
    1 add in trunk

There should be an easy way to run HTTP/WPT served tests on a browser
​https://bugs.webkit.org/show_bug.cgi?id=172068

Patch by youenn fablet <​youenn@apple.com> on 2017-05-23
Reviewed by Sam Weinig.

Tools:

Adding a new script open-layout-test to open a layout-test in a
browser and making sure it is served as done through run-webkit-tests.
In case tests should be run using a server, detecting whether the
server are running. If not, calling run-webkit-httpd to run the
servers and open the URL in a browser.
Otherwise, open directly the URL.

Adding an option in run-webkit-httpd to open an URL after having
started the servers.

Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
This allows running run-webkit-httpd once and not having to restart
servers everytime a test should be served.

Moving most of run-webkit-httpd logic in its own python file to reuse
it in open-layout-test script.

Adding routines to check whether HTTP and WPT servers are running.

  • Scripts/open-layout-test: Added.

(parse_args):
(main):

  • Scripts/run-webkit-httpd:

(main):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder.find_tests):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase._is_server_running_on_all_ports):
(HttpServerBase):
(HttpServerBase._is_running_on_port):
(HttpServerBase._check_that_all_ports_are_available):
(is_http_server_running):

  • Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.

(parse_args):
(main):
(run_server):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(is_wpt_server_running):

  • Scripts/webkitpy/port/base.py:

(Port.to.is_http_server_running):
(Port.to):
(Port.to.is_wpt_server_running):
(Port.to.start_web_platform_test_server):

  • Scripts/webkitpy/port/driver.py:

(DriverProxy.is_web_platform_test):
(DriverProxy):
(DriverProxy.is_webkit_specific_web_platform_test):

LayoutTests:

  • fast/harness/results.html: In case results.html is opened locallly,

open HTTP/WPT urls as served by their related servers.
Adding a check that the servers are running before opening the related test.

7:18 AM Changeset in webkit [217275] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

[Modern Media Controls] Turn off all tests
​https://bugs.webkit.org/show_bug.cgi?id=172447

Patch by Antoine Quint <Antoine Quint> on 2017-05-23
Reviewed by Jon Lee.

Due to the high number of timeouts and random failures with the current tests, we turn off
all modern-media-controls tests while we wait on a more permanent solution.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
7:04 AM Changeset in webkit [217274] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests/imported/w3c

[GTK] Test gardening after r217225
​https://bugs.webkit.org/show_bug.cgi?id=172498

Patch by Romain Bellessort <​romain.bellessort@crf.canon.fr> on 2017-05-23
Reviewed by Michael Catanzaro.

Update test expectations after r217225 resync of WPT tests.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated.
6:34 AM Changeset in webkit [217273] by commit-queue@webkit.org
  • 19 edits in trunk

Add a RuntimeEnabledFeature for display: contents, defaulted to false.
​https://bugs.webkit.org/show_bug.cgi?id=171984

LayoutTests/imported/w3c:

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-22
Reviewed by Antti Koivisto.

  • web-platform-tests/innerText/getter-expected.txt:

Source/WebCore:

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-22
Reviewed by Antti Koivisto.

The "defaulted to false" is not only because there are spec issues,
but because I ran the WPT suite, and there was a fair amount of
crashes and messed render trees.

Tests: imported/w3c/web-platform-tests/innerText/getter.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDisplayContentsEnabled):
(WebCore::RuntimeEnabledFeatures::displayContentsEnabled):

Source/WebKit/mac:

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-23
Reviewed by Antti Koivisto.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences displayContentsEnabled]):
(-[WebPreferences setDisplayContentsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-23
Reviewed by Antti Koivisto.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDisplayContentsEnabled):
(WKPreferencesGetDisplayContentsEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Patch by Emilio Cobos Álvarez <​ecobos@igalia.com> on 2017-05-23
Reviewed by Antti Koivisto.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

12:37 AM Changeset in webkit [217272] by mmaxfield@apple.com
  • 19 edits in trunk

Update font-style's implementation in the font selection algorithm
​https://bugs.webkit.org/show_bug.cgi?id=169453

Reviewed by Simon Fraser.

Source/WebCore:

Previously, we were treating "font-style: oblique" exactly the same as "font-style: italic".
These values were parsed to the same internal data type. However, variation fonts may have two
distinct axes: 'slnt' and 'ital'. Therefore, we need to keep a bool of state which represents
which of these two axes we should be setting when we apply font variations. We can do this by
making the "font-style" parser a "custom" parser. The implementation of these custom functions
will set both the italic value on the FontDescription as well as this extra bool.

We don't, however, want to treat these values as distinct for the purposese of font selection.
The fact that we treat oblique fonts the same as italic fonts is a feature, not a bug. Therefore,
the font selection algorithm is not made aware of this distinction. This is why we don't want to
package up the bool and FontSelectionValue into a class: font selection only cares about the
FontSelectionValue, so conceptually they shouldn't be joined. (The FontSelectionValue already
exists within a collection of all the things font selection needs to know about.)

Now that there is this extra bit of state on the FontDescription, we can do a little better when
computing the result of getComputedStyle(). Previously, we were always returning "italic" even
when "oblique" was specified. Now, we can return the correct one. However, this extra bit of
state is not kept on the CSSFontFace (because it doesn't need to be), which means we can only
improve the computed style of an element, rather than the cssText of an @font-face rule.

Test: fast/text/font-style-parse.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::fontStyleFromStyleValue):
(WebCore::fontStyleFromStyle):
(WebCore::fontShorthandValueForSelectionProperties):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceSet.h:
  • css/CSSProperties.json:
  • css/FontFace.cpp:

(WebCore::FontFace::style):

  • css/FontSelectionValueInlines.h:

(WebCore::fontStyleKeyword):

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontStyle): Deleted.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialFontStyle):
(WebCore::StyleBuilderCustom::applyInheritFontStyle):
(WebCore::StyleBuilderCustom::applyValueFontStyle):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription):

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::shouldUseItalicVariationAxis):
(WebCore::FontDescription::setShouldUseItalicVariationAxis):
(WebCore::FontDescription::operator==):
(WebCore::FontCascadeDescription::initialShouldUseItalicVariationAxis):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontWithFamily):
(WebCore::FontCache::createFontPlatformData):
(WebCore::FontCache::systemFallbackForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

LayoutTests:

  • fast/text/font-style-parse-expected.txt:
  • fast/text/font-style-parse.html:
  • platform/mac-elcapitan/fast/text/font-style-parse-expected.txt:
12:21 AM Changeset in webkit [217271] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add a new icon DockLeft.svg
​https://bugs.webkit.org/show_bug.cgi?id=172492

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-23
Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/DockLeft.svg: Added.
12:17 AM Changeset in webkit [217270] by tpopela@redhat.com
  • 2 edits in trunk/Source/WTF

[WTF] Compilation fails with system malloc
​https://bugs.webkit.org/show_bug.cgi?id=172445

Reviewed by Michael Catanzaro.

We are using the bmalloc even if the system malloc should be used.
Don't use bmalloc if the system malloc is requested and add the
missing implementation for computeRAMSize() on UNIX that's utilizing
the sysinfo() call.

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

12:02 AM Changeset in webkit [217269] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add a new icon CSSVariable.svg
​https://bugs.webkit.org/show_bug.cgi?id=172491

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-23
Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/CSSVariable.svg: Added.
Note: See TracTimeline for information about the timeline view.