Timeline

Dec 4, 2017:

11:51 PM Changeset in webkit [225519] by jfbastien@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Math: don't redundantly check for exceptions, just release scope
​https://bugs.webkit.org/show_bug.cgi?id=180395

Rubber stamped by Mark Lam.

Two of the exceptions checks could just have been exception scope
releases before the return, which is ever-so-slightly more
efficient. The same technically applies where we have loops over
parameters, but doing the scope release there isn't really more
efficient and is way harder to read.

• runtime/MathObject.cpp:

(JSC::mathProtoFuncATan2):
(JSC::mathProtoFuncPow):

10:25 PM Changeset in webkit [225518] by jmarcell@apple.com

• 10 edits
  7 adds in branches/safari-604-branch

Cherry-pick r225273. rdar://problem/35838163

10:25 PM Changeset in webkit [225517] by jmarcell@apple.com

• 3 edits
  1 add in branches/safari-604-branch

Cherry-pick r225239. rdar://problem/35838157

9:23 PM Changeset in webkit [225516] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/iOS 11.2

Added a tag for iOS 11.2.

9:20 PM Changeset in webkit [225515] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari 11.0.1

Added a tag for Safari 11.0.1.

9:18 PM Changeset in webkit [225514] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/iOS 11.1

Added a tag for iOS 11.1

6:06 PM Changeset in webkit [225513] by Chris Dumez

• 17 edits
  3 adds in trunk

Support container.getRegistration() / getRegistrations() inside service workers
​https://bugs.webkit.org/show_bug.cgi?id=180360

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/activation.https-expected.txt:

Rebaseline test with slightly different output.

• web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https.html:

With my change, this test started running and passing a check before timing out. When investigating the time
out, I found out that this is caused by the test unregistering the worker while the test is still running
in the service worker, which causes the worker to terminate early. To address the issue, we no longer add
a cleanup step to unregister. The test now passes all checks.

Source/WebCore:

Support container.getRegistration() / getRegistrations() inside service workers
by making sure we hop to the right thread when needed.

Test: http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration.html

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::postTaskTo):

• dom/ScriptExecutionContext.h:
• workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::jobRejectedInServer):
(WebCore::SWClientConnection::registrationJobResolvedInServer):
(WebCore::SWClientConnection::unregistrationJobResolvedInServer):
(WebCore::SWClientConnection::startScriptFetchForServer):
(WebCore::SWClientConnection::clearPendingJobs):

• workers/service/SWClientConnection.h:
• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::didFinishGetRegistrationRequest):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::didFinishGetRegistrationsRequest):
(WebCore::ServiceWorkerContainer::stop):

• workers/service/ServiceWorkerContainer.h:

Source/WebKit:

• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::didMatchRegistration):
(WebKit::WebSWClientConnection::didGetRegistrations):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::getRegistrations):

LayoutTests:

Add layout test coverage.

• http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration-expected.txt: Added.
• http/tests/workers/service/ServiceWorkerGlobalScope_getRegistration.html: Added.
• http/tests/workers/service/resources/ServiceWorkerGlobalScope_getRegistration-worker.js: Added.

5:37 PM Changeset in webkit [225512] by Simon Fraser

• 5 edits in trunk/Source/WebCore

Cleanup code that computes iframe content offsets in FrameView
​https://bugs.webkit.org/show_bug.cgi?id=180385

Reviewed by Zalan Bujtas.

The coordinate conversion functions in FrameView explicitly added borderLeft/paddingLeft
and borderTop/paddingTop to compute the offset from the contents of a frame to its parent renderer.

This is equivalent to the call to contextBoxRect() that RenderWidget::updateWidgetGeometry() does,
which also takes left-side scrollbars into account.

Coordinate offsets don't need height and width, so add RenderBox::contentBoxLocation() that just
computes the top left, and use it in FrameView.

• page/FrameView.cpp:

(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):

• platform/graphics/FloatPoint.h:

(WebCore::FloatPoint::scaled const):
(WebCore::FloatPoint::scaled): Deleted.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::contentBoxLocation const):

• rendering/RenderBox.h:

5:24 PM Changeset in webkit [225511] by n_wang@apple.com

• 13 edits
  2 adds in trunk

AX: AOM: Implement relation type properties
​https://bugs.webkit.org/show_bug.cgi?id=179500

Reviewed by Ryosuke Niwa.

Source/WebCore:

Accessibility Object Model
Explainer: ​https://wicg.github.io/aom/explainer.html
Spec: ​https://wicg.github.io/aom/spec/

Implemented the AOM support for activeDescendant, details and errorMessage.
The corresponding ARIA attributes all take IDREFs, and the AOM properties
take references to AccessibleNodes instead.

Test: accessibility/mac/AOM-relation-property.html

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::getAttribute const):
(WebCore::AccessibilityObject::hasProperty const):
(WebCore::AccessibilityObject::stringValueForProperty const):
(WebCore::AccessibilityObject::boolValueForProperty const):
(WebCore::AccessibilityObject::intValueForProperty const):
(WebCore::AccessibilityObject::unsignedValueForProperty const):
(WebCore::AccessibilityObject::doubleValueForProperty const):
(WebCore::AccessibilityObject::elementValueForProperty const):
(WebCore::AccessibilityObject::supportsARIAAttributes const):
(WebCore::AccessibilityObject::elementsFromProperty const):
(WebCore::AccessibilityObject::elementsReferencedByProperty const):
(WebCore::AccessibilityObject::ariaActiveDescendantReferencingElements const):
(WebCore::AccessibilityObject::ariaDetailsElements const):
(WebCore::AccessibilityObject::ariaDetailsReferencingElements const):
(WebCore::AccessibilityObject::ariaErrorMessageElements const):
(WebCore::AccessibilityObject::ariaErrorMessageReferencingElements const):

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::activeDescendant const):

• accessibility/AccessibleNode.cpp:

(WebCore::ariaAttributeMap):
(WebCore::isPropertyValueRelation):
(WebCore::AccessibleNode::attributeFromAXPropertyName):
(WebCore::AccessibleNode::setRelationProperty):
(WebCore::AccessibleNode::singleRelationValueForProperty):
(WebCore::AccessibleNode::activeDescendant const):
(WebCore::AccessibleNode::setActiveDescendant):
(WebCore::AccessibleNode::details const):
(WebCore::AccessibleNode::setDetails):
(WebCore::AccessibleNode::errorMessage const):
(WebCore::AccessibleNode::setErrorMessage):

• accessibility/AccessibleNode.h:
• accessibility/AccessibleNode.idl:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):

• WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
(WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):

LayoutTests:

Only enable this test on WK2.

• accessibility/mac/AOM-relation-property-expected.txt: Added.
• accessibility/mac/AOM-relation-property.html: Added.
• platform/mac-wk1/TestExpectations:

5:19 PM Changeset in webkit [225510] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Followup to:
Get a directory path to SWServers for storing ServiceWorker registrations
​https://bugs.webkit.org/show_bug.cgi?id=180362

Unreviewed.

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.

5:13 PM Changeset in webkit [225509] by Simon Fraser

• 12 edits in trunk

Minor DisplayRefreshMonitor-related cleanup
​https://bugs.webkit.org/show_bug.cgi?id=179802

Reviewed by Sam Weinig.

Source/WebCore:

New trace point for when the CVDisplayLink fires on its own thread.

Some #pragma once, and put all the WellKnownRunLoopOrders in one place.

• inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

• platform/cf/RunLoopObserver.h:
• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/ca/LayerFlushScheduler.h:
• platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):

Source/WebKit:

Use RunLoopObserver::WellKnownRunLoopOrders. We want to fire before layer flushing.

• UIProcess/WebPageProxy.cpp:

(WebKit::m_configurationPreferenceValues):

Source/WTF:

New trace point for when the CVDisplayLink fires on its own thread.

• wtf/SystemTracing.h:

Tools:

New trace point for when the CVDisplayLink fires on its own thread.

• Tracing/SystemTracePoints.plist:

5:11 PM Changeset in webkit [225508] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Don't force creation of process pool when enabling resource load statistics
​https://bugs.webkit.org/show_bug.cgi?id=180374
<rdar://problem/35545639>

Reviewed by Alex Christensen.

Pass appropriate arguments to the 'processPool' accessor so that we only get the
set of existing process pools. We don't want to pay the cost of launching new
process pools just to set this flag. The flag will be properly set when the pools
are created as soon as a WebView is instantiated.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):

4:57 PM Changeset in webkit [225507] by commit-queue@webkit.org

• 16 edits
  5 adds in trunk

Add a class for parsing application manifests
​https://bugs.webkit.org/show_bug.cgi?id=177973
rdar://problem/34747949

Patch by David Quesada <​david_quesada@apple.com> on 2017-12-04
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebCore:

Add a new struct ApplicationManifest, along with ApplicationManifestParser to initialize
ApplicationManifests from JSON data, according to the App Manifest spec. Just a basic subset
of the manifests's properties are implemented to start with.

ApplicationManifestParser is tested by new unit tests in TestWebKitAPI.

• Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
• Modules/applicationmanifest/ApplicationManifest.h: Added.
• Modules/applicationmanifest/ApplicationManifestParser.cpp: Added.

(WebCore::ApplicationManifestParser::parse):
The main entry point for eventual clients (and currently the unit tests) to invoke
ApplicationManifestParser. There is a variant that accepts a ScriptExecutionContext that
uses the context exclusively for logging console warnings while parsing the manifest, and
not for actually executing any scripts.
(WebCore::ApplicationManifestParser::ApplicationManifestParser):
(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
(WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
(WebCore::ApplicationManifestParser::logDeveloperWarning):
(WebCore::ApplicationManifestParser::parseStartURL):
(WebCore::ApplicationManifestParser::parseName):
(WebCore::ApplicationManifestParser::parseDescription):
(WebCore::ApplicationManifestParser::parseShortName):
(WebCore::isInScope):
(WebCore::ApplicationManifestParser::parseScope):
(WebCore::ApplicationManifestParser::parseGenericString):

• Modules/applicationmanifest/ApplicationManifestParser.h: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• features.json: Change the Web App Manifest feature status to "In Development"

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebKit:

• Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.

Tools:

Add basic unit tests for ApplicationManifestParser. For each of the implemented top-level properties,
attempt to parse manifests with varying types of valid and invalid data to ensure the resulting
ApplicationManifest is configured with the appropriate values per the spec.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Add ENABLE_APPLICATION_MANIFEST feature flag.
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp: Added.

(ApplicationManifestParserTest::SetUp):
(ApplicationManifestParserTest::parseString):
(ApplicationManifestParserTest::parseTopLevelProperty):
(ApplicationManifestParserTest::testStartURL):
(ApplicationManifestParserTest::testName):
(ApplicationManifestParserTest::testDescription):
(ApplicationManifestParserTest::testShortName):
(ApplicationManifestParserTest::testScope):
(assertManifestHasDefaultValues):
(TEST_F):

4:51 PM Changeset in webkit [225506] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

RenderMultiColumnFlow::fragmentedFlowDescendantInserted should not destroy incoming newDescendant
​https://bugs.webkit.org/show_bug.cgi?id=180181

Reviewed by Antti Koivisto.

This is in preparation for having all multicolumn related tree mutation in RenderTreeUpdaterMultiColumn.

Covered by fast/multicol/column-span-range-crash.html

• rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):

• rendering/RenderMultiColumnFlow.h:
• style/RenderTreeUpdaterMultiColumn.cpp:

(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):

4:13 PM Changeset in webkit [225505] by Wenson Hsieh

• 3 edits in trunk/Source/WebKit

Rename a static helper in TouchBarMenuItemData.cpp to match style guidelines.
​https://bugs.webkit.org/show_bug.cgi?id=180305

Reviewed by Andy Estes.

Style guidelines state that we should use bare words for getters, so getItemType should just be
itemType. Since this collides with the itemType member variable, this patch also renames that
member variable to the more concise "type".

No change in behavior.

• Shared/TouchBarMenuItemData.cpp:

(WebKit::itemType):
(WebKit::TouchBarMenuItemData::TouchBarMenuItemData):
(WebKit::TouchBarMenuItemData::encode const):
(WebKit::TouchBarMenuItemData::decode):
(WebKit::getItemType): Deleted.

• Shared/TouchBarMenuItemData.h:

(WebKit::operator==):

4:11 PM Changeset in webkit [225504] by jmarcell@apple.com

• 4 edits
  1 add in tags/Safari-605.1.15.2

Cherry-pick r225383. rdar://problem/35709469

4:09 PM Changeset in webkit [225503] by jmarcell@apple.com

• 7 edits in tags/Safari-605.1.15.2/Source

Versioning.

4:07 PM Changeset in webkit [225502] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.15.2

New tag.

4:06 PM Changeset in webkit [225501] by BJ Burg

• 9 edits in trunk/Source

Web Automation: add flag to preserve legacy page screenshot behavior
​https://bugs.webkit.org/show_bug.cgi?id=180313
<rdar://problem/34379930>

Reviewed by Joseph Pecoraro.

Source/WebDriver:

Set the clipToViewport flag to true when sending Automation.takeScreenshot.
This preserves the current behavior for this driver implementation.

• Session.cpp:

(WebDriver::Session::takeScreenshot):

Source/WebKit:

For compatibility with JSON Wire Protocol implemented by Safari,
we need to retain the ability to perform whole page contents
snapshots using Automation.takeScreenshot. Add an extra flag,
clipToViewport, which can be used by W3C-conforming drivers.

• UIProcess/Automation/Automation.json: Add new flag.
• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::takeScreenshot):

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::snapshotRectForScreenshot):
(WebKit::WebAutomationSessionProxy::takeScreenshot):
If the flag is false, take a screenshot of the whole page contents.

4:03 PM Changeset in webkit [225500] by aakash_jain@apple.com

• 3 edits in trunk/Tools

Add docstring in EarlyWarningSystemTask to explain return values
​https://bugs.webkit.org/show_bug.cgi?id=180303

Reviewed by Daniel Bates.

• Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

(EarlyWarningSystemTask.run): Added docstring to explain return values.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch): Added comment to explain the result of unlocking a patch.

3:34 PM Changeset in webkit [225499] by jfbastien@apple.com

• 57 edits
  1 add in trunk

Update std::expected to match libc++ coding style
​https://bugs.webkit.org/show_bug.cgi?id=180264

Reviewed by Alex Christensen.

Source/JavaScriptCore:

Update various uses of Expected.

• wasm/WasmModule.h:
• wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseImport):
(JSC::Wasm::ModuleParser::parseTableHelper):
(JSC::Wasm::ModuleParser::parseTable):
(JSC::Wasm::ModuleParser::parseMemoryHelper):

• wasm/WasmParser.h:
• wasm/generateWasmValidateInlinesHeader.py:

(loadMacro):
(storeMacro):

• wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::createStub):

• wasm/js/JSWebAssemblyModule.h:

Source/WebCore:

Update various uses of Expected, mostly renaming valueOr and
hasValue to the STL naming convention.

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::retrieveRecords):
(WebCore::DOMCache::batchDeleteOperation):
(WebCore::DOMCache::batchPutOperation):

• Modules/cache/DOMCacheStorage.cpp:

(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::DOMCacheStorage::open):
(WebCore::DOMCacheStorage::remove):

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::recordsOrErrorFromRecordsData):

• bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

• contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

• contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList):
(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadRule):
(WebCore::ContentExtensions::loadEncodedRules):
(WebCore::ContentExtensions::parseRuleList):

• css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::loadBestFitImage):

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

• css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

• dom/CallbackResult.h:

(WebCore::CallbackResult<ReturnType>::type const):
(WebCore::CallbackResult<ReturnType>::releaseReturnValue):

• dom/Element.cpp:

(WebCore::Element::getIntegralAttribute const):
(WebCore::Element::getUnsignedIntegralAttribute const):

• dom/ExceptionOr.h:

(WebCore::ExceptionOr<ReturnType>::hasException const):
(WebCore::ExceptionOr<void>::hasException const):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::maxLengthAttributeChanged):
(WebCore::HTMLInputElement::minLengthAttributeChanged):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLengthAttributeChanged):
(WebCore::HTMLTextAreaElement::minLengthAttributeChanged):

• html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLNonNegativeInteger):

• html/parser/HTMLParserIdioms.h:

(WebCore::limitToOnlyHTMLNonNegative):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadMainResource):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):
(WebCore::LinkLoader::loadLink):

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

• loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

• platform/URLParser.cpp:

(WebCore::URLParser::parseIPv4Host):

• platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading):

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

• svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateExternalDocument):

• xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

Source/WebKit:

Update various uses of Expected, mostly renaming valueOr and
hasValue to the STL naming convention.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::fetchEntries):
(WebKit::CacheStorage::Engine::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::ReadRecordTaskCounter::appendRecord):
(WebKit::CacheStorage::Cache::updateRecordToDisk):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initialize):
(WebKit::CacheStorage::Caches::readCachesFromDisk):

• NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createResolver):

• Platform/IPC/ArgumentCoders.h:

Source/WTF:

As of ​https://wg21.link/p0323r4 std::expected is on its way to the
Library Fundamentals v3 TS (LEWG and EWG voted for this, but LWG
hasn't done wording review yet, hence "on its way"). The API is
therefore pretty close to what will be in the TS, and I've gotten
requests for an easily usable implementation of std::expected. I
talked to our clang team and they'll help me migrate our
implementation to libc++, but our implementation has to look more
like libc++ than it does now. Once in libc++ I'll maintain changes
on both sides to make sure neither is out-of-date for too long.

• Fork std::unexpected into its own header.
• Add mild support for an exception-based implementation, but don't do noexcept yet.
• Rename everything to follow STL style, and keep a global using or variable alias where possible to reduce WebKit code churn.
• Minor API updates to remove things that aren't in the proposal anymore.

• wtf/Expected.h:

(std::experimental::fundamentals_v3::bad_expected_access<void>::bad_expected_access):
(std::experimental::fundamentals_v3::bad_expected_access::bad_expected_access):
(std::experimental::fundamentals_v3::bad_expected_access::error):
(std::experimental::fundamentals_v3::bad_expected_access::error const):
(std::experimental::fundamentals_v3::expected_detail::constexpr_base::constexpr_base):
(std::experimental::fundamentals_v3::expected_detail::base::base):
(std::experimental::fundamentals_v3::expected_detail::base::~base):
(std::experimental::fundamentals_v3::expected::expected):
(std::experimental::fundamentals_v3::expected::operator=):
(std::experimental::fundamentals_v3::expected::swap):
(std::experimental::fundamentals_v3::expected::operator-> const):
(std::experimental::fundamentals_v3::expected::operator->):
(std::experimental::fundamentals_v3::expected::operator* const):
(std::experimental::fundamentals_v3::expected::operator*):
(std::experimental::fundamentals_v3::expected::has_value const):
(std::experimental::fundamentals_v3::expected::value const):
(std::experimental::fundamentals_v3::expected::value):
(std::experimental::fundamentals_v3::expected::error const):
(std::experimental::fundamentals_v3::expected::error):
(std::experimental::fundamentals_v3::expected::value_or const):
(std::experimental::fundamentals_v3::expected::value_or):
(std::experimental::fundamentals_v3::operator==):
(std::experimental::fundamentals_v3::operator!=):
(std::experimental::fundamentals_v3::swap):
(WTF::Unexpected::Unexpected): Deleted.
(WTF::Unexpected::value const): Deleted.
(WTF::Unexpected::value): Deleted.
(WTF::operator==): Deleted.
(WTF::operator!=): Deleted.
(WTF::makeUnexpected): Deleted.
(WTF::ExpectedDetail::Throw): Deleted.
(WTF::ExpectedDetail::destroy): Deleted.
(WTF::ExpectedDetail::std::is_trivially_destructible<T>::value): Deleted.
(WTF::ExpectedDetail::ConstexprBase::ConstexprBase): Deleted.
(WTF::ExpectedDetail::Base::Base): Deleted.
(WTF::ExpectedDetail::Base::~Base): Deleted.
(WTF::Expected::Expected): Deleted.
(WTF::Expected::operator=): Deleted.
(WTF::Expected::swap): Deleted.
(WTF::Expected::operator-> const): Deleted.
(WTF::Expected::operator->): Deleted.
(WTF::Expected::operator* const): Deleted.
(WTF::Expected::operator*): Deleted.
(WTF::Expected::operator bool const): Deleted.
(WTF::Expected::hasValue const): Deleted.
(WTF::Expected::value const): Deleted.
(WTF::Expected::value): Deleted.
(WTF::Expected::error const): Deleted.
(WTF::Expected::error): Deleted.
(WTF::Expected::getUnexpected const): Deleted.
(WTF::Expected::valueOr const): Deleted.
(WTF::Expected::valueOr): Deleted.
(WTF::swap): Deleted.
(WTF::makeExpected): Deleted.
(WTF::makeExpectedFromError): Deleted.

• wtf/Forward.h:
• wtf/Optional.h:
• wtf/StdLibExtras.h:
• wtf/Unexpected.h: Added.

(std::experimental::fundamentals_v3::unexpected::unexpected):
(std::experimental::fundamentals_v3::unexpected::value const):
(std::experimental::fundamentals_v3::unexpected::value):
(std::experimental::fundamentals_v3::operator==):
(std::experimental::fundamentals_v3::operator!=):
(makeUnexpected):

Tools:

Update tests according to name changes as well as removal of
now-gone APIs.

• TestWebKitAPI/Tests/WTF/Expected.cpp:

(std::experimental::fundamentals_v3::operator<<):
(TestWebKitAPI::TEST):
(WTF::operator<<): Deleted.

• TestWebKitAPI/Tests/WebCore/HTMLParserIdioms.cpp:

(TestWebKitAPI::testParseHTMLInteger):
(TestWebKitAPI::testParseHTMLNonNegativeInteger):

3:05 PM Changeset in webkit [225498] by Ross Kirsling

• 2 edits in trunk/Tools

download-latest-github-release.py should use existing release ANY time latest is not found
​https://bugs.webkit.org/show_bug.cgi?id=180293

Reviewed by Per Arne Vollan.

• Scripts/download-latest-github-release.py:

(find_latest_release):
Handle all URLErrors, not just HTTPErrors. Stop special-casing 404s.

(main):
Rearrange logic so any failure to detect a latest release falls back to an existing release. Improve logging.

(Status):
(download_release):
(load_version_info): Renamed from existing_version info.
(has_latest_release): Deleted.
Cleanup.

2:52 PM Changeset in webkit [225497] by Alan Bujtas

• 3 edits
  2 adds in trunk

REGRESSION (r211531): Text flow changes and overlaps other text after double-click selecting paragraph
​https://bugs.webkit.org/show_bug.cgi?id=180377
<rdar://problem/34337967>

Reviewed by Antti Koivisto.

Source/WebCore:

Take floats into account when computing the available width for a certain vertical position.

Test: fast/block/float/simple-line-layout-float-shrink-line.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::updateLineConstrains):

LayoutTests:

• fast/block/float/simple-line-layout-float-shrink-line-expected.html: Added.
• fast/block/float/simple-line-layout-float-shrink-line.html: Added.

2:51 PM Changeset in webkit [225496] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Exclude some more leak callstacks
​https://bugs.webkit.org/show_bug.cgi?id=180379

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-04
Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/port/leakdetector.py:

(LeakDetector._types_to_exclude_from_leaks):
(LeakDetector._callstacks_to_exclude_from_leaks):
(LeakDetector._leaks_args):
(LeakDetector._types_to_exlude_from_leaks): Deleted.

• Scripts/webkitpy/port/leakdetector_unittest.py:

(LeakDetectorTest.test_leaks_args):

2:49 PM Changeset in webkit [225495] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

<video> and scale() transforms yield shrunk small or clipped controls
​https://bugs.webkit.org/show_bug.cgi?id=180358
<rdar://problem/34436124>

Patch by Antoine Quint <Antoine Quint> on 2017-12-04
Reviewed by Dean Jackson.

Source/WebCore:

To compute the bounds of the media controls, we would call getBoundingClientRect()
on the root-most element in the shadow root, which is styled to have width and height
set to 100%, which allows to match the metrics of the host media element, without
the borders.

However, if the host media element has CSS transforms applied, these would be factored
into calls to getBoundingClientRect() and the controls would be too large and clipped,
in case the scale was more than 1, or shrunk, in case the scale was less than 1.

To obtain correct metrics, we computed the complete transformation matrix applied to
the host media element, and apply its inverted matrix to each corner point of the
bounds returned for the root-most container element in the shadow root.

Then we compute the width and height of this transformed rectangle and set those to
be our media controls' metrics.

Test: media/modern-media-controls/css/transformed-media.html

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsSize):
(MediaController.prototype._controlsWidth): Deleted.

LayoutTests:

Write a new test that ensures that we reflect the width and height, not accounting
for borders, of the host media element when sizing media controls.

• media/modern-media-controls/css/transformed-media-expected.txt: Added.
• media/modern-media-controls/css/transformed-media.html: Added.

2:47 PM Changeset in webkit [225494] by commit-queue@webkit.org

• 4 edits
  2 deletes in trunk

Cursor is not visible after exiting full screen video
​https://bugs.webkit.org/show_bug.cgi?id=180247
<rdar://problem/33885922>

Patch by Antoine Quint <Antoine Quint> on 2017-12-04
Reviewed by Dean Jackson.

Source/WebCore:

There is a dedicated NSCursor method to temporarily hide the mouse cursor while the mouse is idle,
so we use this platform functionality, already exposed through the page chrome, instead which
implements the expected behavior. Now, the mouse cursor is hidden while the mouse is stationary
when a <video> is fullscreen, as before, but as soon as the user exits fullscreen, the mouse cursor
reappears.

No test provided as I don't believe this platform behavior can be tested, there is no API to query
whether the cursor is visible.

• page/EventHandler.cpp:

(WebCore::EventHandler::cancelAutoHideCursorTimer):
(WebCore::EventHandler::autoHideCursorTimerFired):

LayoutTests:

Remove the existing test which would query a cursor state that is no longer relevant.

• fullscreen/video-cursor-auto-hide-expected.txt: Removed.
• fullscreen/video-cursor-auto-hide.html: Removed.
• platform/gtk/TestExpectations:

2:44 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

2:06 PM Changeset in webkit [225493] by jfbastien@apple.com

• 2 edits in trunk/JSTests

Proxy all functions, except the $ objects
​https://bugs.webkit.org/show_bug.cgi?id=180375

Reviewed by Saam Barati.

It looks like this test may have broken some executions because I
call some internal objects. Explicitly ignore objects whose name
starts with "$" because it's a bad idea anyways.

• stress/proxy-all-the-parameters.js:

(generateObjects):
(get throw):

2:00 PM Changeset in webkit [225492] by sbarati@apple.com

• 3 edits
  1 add in trunk

We need to leave room on the top of the stack for the FTL TailCall slow path so it doesn't overwrite things we want to retrieve when doing a stack walk when throwing an exception
​https://bugs.webkit.org/show_bug.cgi?id=180366
<rdar://problem/35685877>

Reviewed by Michael Saboff.

JSTests:

• stress/ftl-tail-call-throw-exception-from-slow-path-recover-stack-values.js: Added.

(theParent):
(test1.base.getParentStaticValue):
(test1.base):
(test1.v_24888.prototype.set prop):
(test1.v_24888):
(test2.base.getParentStaticValue):
(test2.base):
(test2.v_24888.prototype.set prop):
(test2.v_24888):
(test2):

Source/JavaScriptCore:

On the TailCall slow path, the CallFrameShuffler will build the frame with
respect to SP instead of FP. However, this may overwrite slots on the stack
that are needed if the slow path C call does a stack walk. The slow path
C call does a stack walk when it throws an exception. This patch fixes
this bug by ensuring that the top of the stack in the FTL always has enough
space to allow CallFrameShuffler to build a frame without overwriting any
items on the stack that are needed when doing a stack walk.

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):

1:56 PM Changeset in webkit [225491] by Chris Dumez

• 3 edits in trunk/Source/WebCore

ServiceWorkerGlobalScope::skipWaiting(Ref<DeferredPromise>&&) is unsafe
​https://bugs.webkit.org/show_bug.cgi?id=180372

Reviewed by Youenn Fablet.

Ref the WorkerThread and capture it in the lambda. Keep the pending promises in
a HashMap on the ServiceWorkerGlobalScope so that they stay on the worker thread.

• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

• workers/service/ServiceWorkerGlobalScope.h:

1:50 PM Changeset in webkit [225490] by beidson@apple.com

• 20 edits in trunk/Source

Get a directory path to SWServers for storing ServiceWorker registrations.
​https://bugs.webkit.org/show_bug.cgi?id=180362

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (No observable behavior change yet).

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::SWServer):

• workers/service/server/SWServer.h:

Source/WebKit:

This gets all of the plumbing in place for specifying a ServiceWorker registration storage path
in a particular WebsiteDataStore.

• Shared/Storage/StorageProcessCreationParameters.cpp:

(WebKit::StorageProcessCreationParameters::encode const):
(WebKit::StorageProcessCreationParameters::decode):

• Shared/Storage/StorageProcessCreationParameters.h:

• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::initializeWebsiteDataStore):
(WebKit::StorageProcess::swServerForSession):

• StorageProcess/StorageProcess.h:

• UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithLegacyOptions):
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):

• UIProcess/API/APIProcessPoolConfiguration.h:

• UIProcess/API/APIWebsiteDataStore.h:
• UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm:

(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):

• UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp:

(API::WebsiteDataStore::defaultServiceWorkerRegistrationDirectory):

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::legacyPlatformDefaultIndexedDBDatabaseDirectory):
(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore):

• UIProcess/WebProcessPool.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary):
(WebKit::WebsiteDataStore::storageProcessParameters):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::resolvedServiceWorkerRegistrationDirectory const):

• UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

• UIProcess/wpe/WebProcessPoolWPE.cpp:

(WebKit::WebProcessPool::legacyPlatformDefaultServiceWorkerRegistrationDirectory):

1:43 PM Changeset in webkit [225489] by Michael Catanzaro

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed layout test gardening

• platform/gtk/TestExpectations:

1:40 PM Changeset in webkit [225488] by webkit@devinrousso.com

• 30 edits in trunk

Web Inspector: provide method for recording CanvasRenderingContext2D from JavaScript
​https://bugs.webkit.org/show_bug.cgi?id=175166
<rdar://problem/34040740>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

• inspector/protocol/Recording.json:

Add optional name that will be used by the frontend for uniquely identifying the Recording.

• inspector/JSGlobalObjectConsoleClient.h:
• inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::record):
(Inspector::JSGlobalObjectConsoleClient::recordEnd):

• runtime/ConsoleClient.h:
• runtime/ConsoleObject.cpp:

(JSC::ConsoleObject::finishCreation):
(JSC::consoleProtoFuncRecord):
(JSC::consoleProtoFuncRecordEnd):

Source/WebCore:

No new tests, updated existing tests.

• inspector/InspectorCanvas.h:
• inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):

• inspector/InspectorCanvasAgent.h:
• inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):

• inspector/InspectorInstrumentation.h:
• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::consoleStartRecordingCanvas):
(WebCore::InspectorInstrumentation::consoleStartRecordingCanvasImpl):

• page/PageConsoleClient.h:
• page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::record):
(WebCore::PageConsoleClient::recordEnd):

• workers/WorkerConsoleClient.h:
• workers/WorkerConsoleClient.cpp:

(WebCore::WorkerConsoleClient::record):
(WebCore::WorkerConsoleClient::recordEnd):

Source/WebInspectorUI:

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.recordingFinished):
If a name is sent with the payload, use it as the suggested name.

• UserInterface/Models/NativeFunctionParameters.js:

Add console.record and console.recordEnd.

• UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype.showRepresentedObject):
Drive-by: remove logic that toggled the collapsed state of the navigation sidebar, as this
was not very controllable by the user and often was aggravating.

(WI.CanvasTabContentView.prototype._recordingStopped):
Only show the recording if it was not started from the console. This can determined by
CanvasManager when it recieves a recording if the recording's source is not the same as the
current canvas being recorded.

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-2d.html:

(performConsoleRecording):

• inspector/canvas/recording-webgl-expected.txt:
• inspector/canvas/recording-webgl.html:

(performConsoleRecording):

• inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer):

• js/console-expected.txt:
• js/console.html:

12:40 PM Changeset in webkit [225487] by Matt Baker

• 24 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas Tab initial user interface needs some polish
​https://bugs.webkit.org/show_bug.cgi?id=179330
<rdar://problem/35367581>

Reviewed by Joseph Pecoraro.

Update the Canvas overview placeholder text and prevent appearance of
the vertical scrollbar when no canvases exist. This patch also includes
a bunch of cleanup of code that creates content placeholder text throughout
the UI, and makes sure all text is styled consistently.

• Localizations/en.lproj/localizedStrings.js:

Updated Canvas overview message text.

• UserInterface/Base/Main.js:

Make the "message text view" a container with child message element, instead
of a simple element with text content. This makes it simpler to customize
the message (by adding buttons, more text, etc).

• UserInterface/Views/CanvasDetailsSidebarPanel.css:

(.sidebar > .panel.details.canvas .details-section.canvas-extensions .content > ul):
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder): Deleted.
(.sidebar > .panel.details.canvas > .content > .empty-content-placeholder > .message): Deleted.

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WI.CanvasDetailsSidebarPanel.prototype.initialLayout):

• UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
Customize the content placeholder to include a description beneath
the "No Canvas Contexts" message.

• UserInterface/Views/CollectionContentView.css:

(.content-view.collection):
Change overflow-y to auto, to prevent scrollbar from appearing when
"Show scroll bars" system preference is enabled on macOS.

• UserInterface/Views/CollectionContentView.js:

Add support for custom content placeholders.
(WI.CollectionContentView):
(WI.CollectionContentView.prototype._showContentPlaceholder):
(WI.CollectionContentView.prototype._hideContentPlaceholder):

• UserInterface/Views/ContentView.css:

(.content-view > .message-text-view):
(.content-view > .message-text-view > .message):

• UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger > .content):
(.sidebar > .panel.navigation.debugger > :matches(.content, .empty-content-placeholder)): Deleted.

• UserInterface/Views/DetailsSection.css:

(.details-section > .content > .group > .row > .message-text-view):

• UserInterface/Views/Main.css:

(.message-text-view):
(.message-text-view > .message):
(.message-text-view.error):

• UserInterface/Views/NavigationSidebarPanel.css:

(.sidebar > .panel.navigation > .overflow-shadow):
(.sidebar > .panel.navigation > .content .empty-content-placeholder): Deleted.
(.sidebar > .panel.navigation > .content > .empty-content-placeholder): Deleted.
(.sidebar > .panel.navigation > .content .empty-content-placeholder > .message): Deleted.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WI.NavigationSidebarPanel.prototype._createEmptyContentPlaceholderIfNeeded):

• UserInterface/Views/NetworkTableContentView.css:

(.content-view.network .message-text-view):
(.content-view.network .message-text-view > .message):
Workaround to prevent "No Filter Results" message from being styled like
"full width" messages displayed in ContentViews (large, bold font).
This is needed because the placeholder message element is a immediate child
of the network content view, rather than the network table.

(.content-view.network .empty-content-placeholder): Deleted.
(body[dir=ltr] .content-view.network .empty-content-placeholder): Deleted.
(body[dir=rtl] .content-view.network .empty-content-placeholder): Deleted.
(.content-view.network .empty-content-placeholder > .message): Deleted.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._showEmptyFilterResultsMessage):

• UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content):
(.sidebar > .panel.navigation.recording > :matches(.content, .empty-content-placeholder)): Deleted.

• UserInterface/Views/ResourceSidebarPanel.css:

(.sidebar > .panel.navigation.resource > .content):
(.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)): Deleted.

• UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style > .content > .rules > .message-text-view):
(.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .message-text-view):
(.sidebar > .panel.details.css-style > .content > .rules:not(.filter-non-matching) > .no-filter-results): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results): Deleted.
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message): Deleted.

• UserInterface/Views/RulesStyleDetailsPanel.js:

(WI.RulesStyleDetailsPanel):

• UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search > :matches(.content, .message-text-view)):
(.sidebar > .panel.navigation.search.changed > :matches(.content, .message-text-view)):
(.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)): Deleted.
(.sidebar > .panel.navigation.search.changed > :matches(.content, .empty-content-placeholder)): Deleted.

• UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:

(WI.SpreadsheetRulesStyleDetailsPanel):

• UserInterface/Views/StorageSidebarPanel.css:

(.sidebar > .panel.navigation.storage > .content):
(.sidebar > .panel.navigation.storage > :matches(.content, .empty-content-placeholder)): Deleted.

• UserInterface/Views/Variables.css:

(:root):

12:35 PM Changeset in webkit [225486] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Call "Terminate Service Worker" on all workers when all their clients are gone
​https://bugs.webkit.org/show_bug.cgi?id=179552

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

Tested manually.

When SWServer detects that there is no longer any client for a given client origin,
it iterates through the running workers to terminate them if they have the given client origin.
A timer of 60 seconds is used in case a user closes a tab or a window, and reopens one with the same origin shortly after.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::findClientByIdentifier):
(WebCore::SWServer::matchAll):
(WebCore::SWServer::registerServiceWorkerClient):
(WebCore::SWServer::unregisterServiceWorkerClient):

• workers/service/server/SWServer.h:

12:31 PM Changeset in webkit [225485] by Antti Koivisto

• 4 edits in trunk/Source/WebCore

Enable selector filtering for ::before and ::after pseudo element resolution
​https://bugs.webkit.org/show_bug.cgi?id=180364

Reviewed by Ryosuke Niwa.

Since these pseudo elements are now resolved by TreeResolver we can use selector filter for them.

This is 10%+ progression in StyleBench pseudo element subtest.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::pseudoStyleForElement):

• css/StyleResolver.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolvePseudoStyle):

11:37 AM Changeset in webkit [225484] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore/PAL

Unreviewed WPE build fix.

• pal/PlatformWPE.cmake: Use GLIB_INCLUDE_DIRS for building the PAL library.

10:55 AM Changeset in webkit [225483] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Add support ​https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
​https://bugs.webkit.org/show_bug.cgi?id=180359

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

This algorithm is needed for implementation of claim.
As per specification, it is run for every client unload, hence why this is put in removeClientUsingRegistration.

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::removeClientUsingRegistration):
(WebCore::SWServerRegistration::handleClientUnload):

• workers/service/server/SWServerRegistration.h:

10:37 AM Changeset in webkit [225482] by Antti Koivisto

• 6 edits in trunk/Source/WebCore

Remove duplicates from selector filter hashes
​https://bugs.webkit.org/show_bug.cgi?id=180354

Reviewed by Simon Fraser.

We have only four slots for hashes in RuleSet and adding more regresses performance. To use the limited slots
better we should eliminate duplicates.

This patch also switches to using std::array instead of a C array for the hashes.

The patch reduces the number of selectors passing through the selector filter in StyleBench by ~0.4%.

• css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):

• css/RuleSet.cpp:

(WebCore::RuleData::RuleData):

• css/RuleSet.h:

(WebCore::RuleData::descendantSelectorIdentifierHashes const):

• css/SelectorFilter.cpp:

(WebCore::collectDescendantSelectorIdentifierHashes):
(WebCore::SelectorFilter::collectIdentifierHashes):

• css/SelectorFilter.h:

(WebCore::SelectorFilter::fastRejectSelector const):

10:13 AM Changeset in webkit [225481] by Chris Dumez

• 5 edits in trunk/Source/WebCore

WorkerCacheStorageConnection should handle the case of terminated workers
​https://bugs.webkit.org/show_bug.cgi?id=180304

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

No web page observable change of behavior.

Reworked WorkerCacheStorageConnection hopping.
Instead of refing/unrefing itself, it refs the worker thread and the main thread connection.
This worker thread is then used on the way back from the main thread.

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

• Modules/cache/WorkerCacheStorageConnection.h:
• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::cacheStorageConnection):

• workers/WorkerGlobalScope.h:

8:45 AM Changeset in webkit [225480] by fred.wang@free.fr

• 5 edits in trunk/Source

Make ScrollingTreeNode::enclosingFrameNode return the node itself for frame nodes
​https://bugs.webkit.org/show_bug.cgi?id=180353

Patch by Frederic Wang <​fwang@igalia.com> on 2017-12-04
Reviewed by Antonio Gomes.

This function was introduced in bug 175135 to solve a rendering bug with fixed positioned
nodes in overflow nodes. For a frame node, the reference frame to use for fixed nodes is
actually the frame node itself or otherwise we will get the same rendering bug. This patch
makes enclosingFrameNode return the node itself when it is a frame node and renames it to
clarify this behavior. Currently, enclosingFrameNode is not used for frame nodes so the
behavior is unchanged.

Source/WebCore:

No new tests, behavior is unchanged.

• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::enclosingFrameNodeIncludingSelf): Start the search from a frame
scrolling node from the node itself. Renamed to make explicit that this function may include
the node itself.

• page/scrolling/ScrollingTreeNode.h: Renamed.

Source/WebKit:

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Use auto* and
the new function name.

8:41 AM Changeset in webkit [225479] by Ms2ger@igalia.com

• 2 edits
  3 adds in trunk/LayoutTests

[GTK] Rebaseline imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
​https://bugs.webkit.org/show_bug.cgi?id=180357

Unreviewed test gardening.

The difference with the platform-neutral expectation is whitespace-only.

• platform/gtk/TestExpectations:
• platform/gtk/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: Added.

7:32 AM Changeset in webkit [225478] by Antti Koivisto

• 2 edits in trunk/PerformanceTests

Fix StyleBench/InteractiveRunner.html
​https://bugs.webkit.org/show_bug.cgi?id=180355

• StyleBench/InteractiveRunner.html:

7:15 AM Changeset in webkit [225477] by Michael Catanzaro

• 8 edits
  3 adds in trunk/Source

Source/WebCore:
[WPE][GTK] Implement PAL::SleepDisabler
​https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

Add a comment to warn about some odd use of SleepDisabler in HTMLMediaElement.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldDisableSleep const):

Source/WebCore/PAL:
[WPE][GTK] Implement PAL::SleepDisabler
​https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

• pal/PlatformGTK.cmake:
• pal/PlatformWPE.cmake:
• pal/system/SleepDisabler.cpp:
• pal/system/glib/SleepDisablerGLib.cpp: Added.

(PAL::SleepDisabler::create):
(PAL::SleepDisablerGLib::SleepDisablerGLib):
(PAL::SleepDisablerGLib::~SleepDisablerGLib):
(PAL::SleepDisablerGLib::acquireInhibitor):
(PAL::SleepDisablerGLib::releaseInhibitor):

• pal/system/glib/SleepDisablerGLib.h: Added.

Source/WebKit:
[GTK] Implement PAL::SleepDisabler
​https://bugs.webkit.org/show_bug.cgi?id=178485

Reviewed by Carlos Garcia Campos.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseDispose):
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
(screenSaverInhibitedCallback): Deleted.
(webkitWebViewBaseSendInhibitMessageToScreenSaver): Deleted.
(screenSaverProxyCreatedCallback): Deleted.
(webkitWebViewBaseInhibitScreenSaver): Deleted.
(webkitWebViewBaseUninhibitScreenSaver): Deleted.

5:27 AM WebDriverStatus edited by Carlos Garcia Campos

(diff)

5:20 AM WebDriverStatus edited by Carlos Garcia Campos

(diff)

3:34 AM Changeset in webkit [225476] by Carlos Garcia Campos

• 8 edits in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

• imported/w3c/importer.json:
• imported/w3c/tools/webdriver/webdriver/client.py:
• imported/w3c/tools/webdriver/webdriver/error.py:
• imported/w3c/webdriver/tests/element_retrieval/get_active_element.py:
• imported/w3c/webdriver/tests/interaction/element_clear.py:
• imported/w3c/webdriver/tests/sessions/status.py:
• imported/w3c/webdriver/tests/support/wait.py:

3:30 AM Changeset in webkit [225475] by fred.wang@free.fr

• 13 edits
  2 copies in trunk/Source/WebCore

Bug 161300 - Move RenderMathMLRoot:RootType and RenderMathMLScripts:ScriptsType to element classes
​https://bugs.webkit.org/show_bug.cgi?id=161300

Patch by Frederic Wang <​fwang@igalia.com> on 2017-12-04
Reviewed by Darin Adler.

RenderMathMLRoot::m_kind and RenderMathMLScripts::m_scriptType are initialized in the
constructors of the renderer classes from the tag name of the corresponding elements.
This patch moves them into the corresponding element classes and makes them const members
parsed in the constructors. It also introduces a MathMLRootElement class deriving from
MathMLRowElement to store the new member. Finally, the types are redefined as enum classes.

No new tests, behavior unchanged and already covered by existing tests.

• Sources.txt: Add MathMLRootElement files.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• mathml/MathMLAllInOne.cpp: Ditto.
• mathml/MathMLRootElement.cpp:

(WebCore::element): Override this function to downcast to MathMLRootElement.
(WebCore::rootTypeOf): Helper function to parse the root type, moved from RenderMathMLRoot.
(WebCore::MathMLRootElement::MathMLRootElement): Initialize the root type.
(WebCore::MathMLRootElement::create):
(WebCore::MathMLRootElement::createElementRenderer): Moved from MathMLRowElement.

• mathml/MathMLRootElement.h: New class deriving from MathMLRowElement, with a RootType

member exposed to the renderer class.

• mathml/MathMLRowElement.cpp: Remove header for RenderMathMLRoot.h.

(WebCore::MathMLRowElement::createElementRenderer): Moved to MathMLRootElement.

• mathml/MathMLScriptsElement.cpp: Introduce a script type.

(WebCore::scriptTypeOf): Helper function to parse the script type, moved from
RenerMathMLScripts.
(WebCore::MathMLScriptsElement::MathMLScriptsElement): Initialize the script type.

• mathml/MathMLScriptsElement.h: Add new script type member.

(WebCore::MathMLScriptsElement::scriptType const): Expose the script type to the renderer
class.

• mathml/mathtags.in: Map <msqrt> and <mroot> to MathMLRootElement.
• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::RenderMathMLRoot): Use MathMLRootElement and remove parsing of
the root type.
(WebCore::RenderMathMLRoot::rootType const): Helper function to access the root type from
the element class.
(WebCore::RenderMathMLRoot::isValid const): Use rootType() and add prefix for enum class
values.
(WebCore::RenderMathMLRoot::getBase const): Ditto.
(WebCore::RenderMathMLRoot::getIndex const): Ditto.
(WebCore::RenderMathMLRoot::horizontalParameters): Ditto.
(WebCore::RenderMathMLRoot::verticalParameters): Ditto.
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLRoot::layoutBlock): Ditto.
(WebCore::RenderMathMLRoot::paint): Ditto.

• rendering/mathml/RenderMathMLRoot.h: Define root type as an enum class, replace

MathMLRowElement with MathMLRootElement, declare and use new rootType() function and remove
the m_kind member.

• rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::RenderMathMLScripts): Remove parsing of script type.
(WebCore::RenderMathMLScripts::scriptType const): Helper function to access the script type
from the element class.
(WebCore::RenderMathMLScripts::validateAndGetReferenceChildren): Use scriptType() and add
prefix for enum class values.
(WebCore::RenderMathMLScripts::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLScripts::verticalMetrics): Ditto.
(WebCore::RenderMathMLScripts::layoutBlock): Ditto.

• rendering/mathml/RenderMathMLScripts.h: Define root type as an enum class, declare the

scriptType() function and remove the m_scriptType member.

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::isValid const): Use scriptType() and add prefix for enum
class values.
(WebCore::RenderMathMLUnderOver::under const): Ditto.
(WebCore::RenderMathMLUnderOver::over const): Ditto.
(WebCore::RenderMathMLUnderOver::computePreferredLogicalWidths): Ditto.
(WebCore::RenderMathMLUnderOver::hasAccent const): Ditto.
(WebCore::RenderMathMLUnderOver::layoutBlock): Ditto.

3:29 AM Changeset in webkit [225474] by Carlos Garcia Campos

• 5 edits in trunk/Source/WebDriver

WebDriver: implement element property command
​https://bugs.webkit.org/show_bug.cgi?id=180244

Reviewed by Brian Burg.

13.3 Get Element Property
​https://w3c.github.io/webdriver/webdriver-spec.html#get-element-property

Fixes: imported/w3c/webdriver/tests/state/get_element_property.py::test_no_browsing_context

imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_dismiss
imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_accept
imported/w3c/webdriver/tests/state/get_element_property.py::test_handle_prompt_missing_value
imported/w3c/webdriver/tests/state/get_element_property.py::test_element_stale

• Session.cpp:

(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):

• Session.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::getElementProperty):

• WebDriverService.h:

12:52 AM Changeset in webkit [225473] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GStreamer] More leaks in TextCombinerGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=180331

Reviewed by Michael Catanzaro.

I've noticed more leaks reading the code, but I couldn't check them with valgrind, because I don't know how to
trigger that code path. This patch cleans up the file using smart pointer everywhere.

• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_pad_init):
(webkitTextCombinerPadEvent):
(webkitTextCombinerReleasePad):

12:49 AM Changeset in webkit [225472] by jer.noble@apple.com

• 17 edits
  7 adds in trunk

Include 'video/*' in image request Accept header if browser supports video media in image contexts.
​https://bugs.webkit.org/show_bug.cgi?id=179178

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/images/image-supports-video.html

Ensure that 'video/*' is included in the Accept header by asking the ImageDecoder whether "Video"
media is supported. The ImageDecoder will ask all it's constituent decoders, which aside from
ImageDecoderAVFObjC will say only support the "Image" media type.

Drive-by fix: Make sure the MIMETypeRegistry includes all the types supported by AVFoundation when
ImageDecoderAVFObjC is enabled. Also, now that Image reports it can support video mime types, check
whether MediaDocument can support a given mime type before asking ImageDocument.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::isSupportedType):

• loader/cache/CachedResourceRequest.cpp:

(WebCore::acceptHeaderValueFromType):

• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::isSupportedImageVideoOrSVGMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageOrSVGMIMEType): Deleted.

• platform/MIMETypeRegistry.h:
• platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::supportsMediaType):

• platform/graphics/ImageDecoder.h:
• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h:

(WebCore::ImageDecoderAVFObjC::supportsMediaType):

• platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::supportsContentType):

• platform/graphics/cg/ImageDecoderCG.h:
• platform/graphics/win/ImageDecoderDirect2D.h:
• platform/image-decoders/ScalableImageDecoder.h:

(WebCore::ScalableImageDecoder::supportsMediaType):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

LayoutTests:

• http/tests/images/image-supports-video-expected.txt: Added.
• http/tests/images/image-supports-video.html: Added.
• http/tests/misc/resources/image-checks-for-accept.php:
• http/tests/resources/redirect-to-video-if-accepted.php: Added.
• platform/ios/TestExpectations:
• platform/mac/imported/w3c/web-platform-tests/html/semantics/the-img-element/update-the-source-set-expected.txt: Added.

Dec 3, 2017:

10:26 PM Changeset in webkit [225471] by tpopela@redhat.com

• 3 edits in trunk/Source/WTF

Build fails on x86_64 and arm64 with BMalloc disabled
​https://bugs.webkit.org/show_bug.cgi?id=180188

Reviewed by Carlos Garcia Campos.

Add missing methods in WTF's Gigacage.h and fix g_gigacageBasePtr
definition.

• wtf/Gigacage.cpp:
• wtf/Gigacage.h:

(Gigacage::basePtr):
(Gigacage::isEnabled):

10:13 PM Changeset in webkit [225470] by Yusuke Suzuki

• 71 edits
  1 add in trunk

WTF shouldn't have both Thread and ThreadIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=180308

Reviewed by Darin Adler.

Source/JavaScriptCore:

• heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStacks):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_trace_operand):
(JSC::LLInt::llint_trace_value):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::traceFunctionPrologue):

• runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

• runtime/JSLock.h:

(JSC::JSLock::currentThreadIsHoldingLock):

• runtime/VM.cpp:

(JSC::VM::throwException):

• runtime/VM.h:

(JSC::VM::throwingThread const):
(JSC::VM::clearException):

• tools/HeapVerifier.cpp:

(JSC::HeapVerifier::printVerificationHeader):

Source/WebCore:

No behavior change.

• Modules/indexeddb/IDBActiveDOMObject.h:

(WebCore::IDBActiveDOMObject::originThread const):
(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):
(WebCore::IDBActiveDOMObject::callFunctionOnOriginThread):
(WebCore::IDBActiveDOMObject::originThreadID const): Deleted.

• Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::IDBCursor):
(WebCore::IDBCursor::~IDBCursor):
(WebCore::IDBCursor::sourcesDeleted const):
(WebCore::IDBCursor::transaction const):
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBCursor::deleteFunction):
(WebCore::IDBCursor::setGetResult):

• Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::~IDBDatabase):
(WebCore::IDBDatabase::hasPendingActivity const):
(WebCore::IDBDatabase::name const):
(WebCore::IDBDatabase::version const):
(WebCore::IDBDatabase::objectStoreNames const):
(WebCore::IDBDatabase::renameObjectStore):
(WebCore::IDBDatabase::renameIndex):
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::connectionToServerLost):
(WebCore::IDBDatabase::maybeCloseInServer):
(WebCore::IDBDatabase::activeDOMObjectName const):
(WebCore::IDBDatabase::canSuspendForDocumentSuspension const):
(WebCore::IDBDatabase::stop):
(WebCore::IDBDatabase::startVersionChangeTransaction):
(WebCore::IDBDatabase::didStartTransaction):
(WebCore::IDBDatabase::willCommitTransaction):
(WebCore::IDBDatabase::didCommitTransaction):
(WebCore::IDBDatabase::willAbortTransaction):
(WebCore::IDBDatabase::didAbortTransaction):
(WebCore::IDBDatabase::didCommitOrAbortTransaction):
(WebCore::IDBDatabase::fireVersionChangeEvent):
(WebCore::IDBDatabase::dispatchEvent):
(WebCore::IDBDatabase::didCreateIndexInfo):
(WebCore::IDBDatabase::didDeleteIndexInfo):

• Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::IDBIndex):
(WebCore::IDBIndex::~IDBIndex):
(WebCore::IDBIndex::name const):
(WebCore::IDBIndex::setName):
(WebCore::IDBIndex::objectStore):
(WebCore::IDBIndex::keyPath const):
(WebCore::IDBIndex::unique const):
(WebCore::IDBIndex::multiEntry const):
(WebCore::IDBIndex::rollbackInfoForVersionChangeAbort):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::doCount):
(WebCore::IDBIndex::doGet):
(WebCore::IDBIndex::doGetKey):
(WebCore::IDBIndex::getAll):
(WebCore::IDBIndex::getAllKeys):
(WebCore::IDBIndex::markAsDeleted):

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::IDBObjectStore):
(WebCore::IDBObjectStore::~IDBObjectStore):
(WebCore::IDBObjectStore::name const):
(WebCore::IDBObjectStore::setName):
(WebCore::IDBObjectStore::keyPath const):
(WebCore::IDBObjectStore::indexNames const):
(WebCore::IDBObjectStore::transaction):
(WebCore::IDBObjectStore::autoIncrement const):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::openKeyCursor):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::getKey):
(WebCore::IDBObjectStore::putOrAdd):
(WebCore::IDBObjectStore::doDelete):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::doCount):
(WebCore::IDBObjectStore::getAll):
(WebCore::IDBObjectStore::getAllKeys):
(WebCore::IDBObjectStore::markAsDeleted):
(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):

• Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::~IDBOpenDBRequest):
(WebCore::IDBOpenDBRequest::onError):
(WebCore::IDBOpenDBRequest::versionChangeTransactionDidFinish):
(WebCore::IDBOpenDBRequest::fireSuccessAfterVersionChangeCommit):
(WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
(WebCore::IDBOpenDBRequest::dispatchEvent):
(WebCore::IDBOpenDBRequest::onSuccess):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore::IDBOpenDBRequest::onDeleteDatabaseSuccess):
(WebCore::IDBOpenDBRequest::requestCompleted):
(WebCore::IDBOpenDBRequest::requestBlocked):

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):
(WebCore:: const):
(WebCore::IDBRequest::setSource):
(WebCore::IDBRequest::setVersionChangeTransaction):
(WebCore::IDBRequest::transaction const):
(WebCore::IDBRequest::sourceObjectStoreIdentifier const):
(WebCore::IDBRequest::sourceIndexIdentifier const):
(WebCore::IDBRequest::requestedObjectStoreRecordType const):
(WebCore::IDBRequest::requestedIndexRecordType const):
(WebCore::IDBRequest::eventTargetInterface const):
(WebCore::IDBRequest::activeDOMObjectName const):
(WebCore::IDBRequest::canSuspendForDocumentSuspension const):
(WebCore::IDBRequest::hasPendingActivity const):
(WebCore::IDBRequest::stop):
(WebCore::IDBRequest::enqueueEvent):
(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):
(WebCore::IDBRequest::setResultToUndefined):
(WebCore::IDBRequest::resultCursor):
(WebCore::IDBRequest::willIterateCursor):
(WebCore::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBRequest::completeRequestAndDispatchEvent):
(WebCore::IDBRequest::onError):
(WebCore::IDBRequest::onSuccess):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::~IDBTransaction):
(WebCore::IDBTransaction::objectStoreNames const):
(WebCore::IDBTransaction::db):
(WebCore::IDBTransaction::error const):
(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abortDueToFailedRequest):
(WebCore::IDBTransaction::transitionedToFinishing):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::internalAbort):
(WebCore::IDBTransaction::abortOnServerAndCancelRequests):
(WebCore::IDBTransaction::activeDOMObjectName const):
(WebCore::IDBTransaction::canSuspendForDocumentSuspension const):
(WebCore::IDBTransaction::hasPendingActivity const):
(WebCore::IDBTransaction::stop):
(WebCore::IDBTransaction::isActive const):
(WebCore::IDBTransaction::isFinishedOrFinishing const):
(WebCore::IDBTransaction::addRequest):
(WebCore::IDBTransaction::removeRequest):
(WebCore::IDBTransaction::scheduleOperation):
(WebCore::IDBTransaction::schedulePendingOperationTimer):
(WebCore::IDBTransaction::pendingOperationTimerFired):
(WebCore::IDBTransaction::operationCompletedOnServer):
(WebCore::IDBTransaction::scheduleCompletedOperationTimer):
(WebCore::IDBTransaction::completedOperationTimerFired):
(WebCore::IDBTransaction::commit):
(WebCore::IDBTransaction::commitOnServer):
(WebCore::IDBTransaction::finishAbortOrCommit):
(WebCore::IDBTransaction::didStart):
(WebCore::IDBTransaction::notifyDidAbort):
(WebCore::IDBTransaction::didAbort):
(WebCore::IDBTransaction::didCommit):
(WebCore::IDBTransaction::fireOnComplete):
(WebCore::IDBTransaction::fireOnAbort):
(WebCore::IDBTransaction::enqueueEvent):
(WebCore::IDBTransaction::dispatchEvent):
(WebCore::IDBTransaction::createObjectStore):
(WebCore::IDBTransaction::createObjectStoreOnServer):
(WebCore::IDBTransaction::didCreateObjectStoreOnServer):
(WebCore::IDBTransaction::renameObjectStore):
(WebCore::IDBTransaction::renameObjectStoreOnServer):
(WebCore::IDBTransaction::didRenameObjectStoreOnServer):
(WebCore::IDBTransaction::createIndex):
(WebCore::IDBTransaction::createIndexOnServer):
(WebCore::IDBTransaction::didCreateIndexOnServer):
(WebCore::IDBTransaction::renameIndex):
(WebCore::IDBTransaction::renameIndexOnServer):
(WebCore::IDBTransaction::didRenameIndexOnServer):
(WebCore::IDBTransaction::requestOpenCursor):
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::openCursorOnServer):
(WebCore::IDBTransaction::didOpenCursorOnServer):
(WebCore::IDBTransaction::iterateCursor):
(WebCore::IDBTransaction::iterateCursorOnServer):
(WebCore::IDBTransaction::didIterateCursorOnServer):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
(WebCore::IDBTransaction::getAllRecordsOnServer):
(WebCore::IDBTransaction::didGetAllRecordsOnServer):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestGetValue):
(WebCore::IDBTransaction::requestGetKey):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::getRecordOnServer):
(WebCore::IDBTransaction::didGetRecordOnServer):
(WebCore::IDBTransaction::requestCount):
(WebCore::IDBTransaction::getCountOnServer):
(WebCore::IDBTransaction::didGetCountOnServer):
(WebCore::IDBTransaction::requestDeleteRecord):
(WebCore::IDBTransaction::deleteRecordOnServer):
(WebCore::IDBTransaction::didDeleteRecordOnServer):
(WebCore::IDBTransaction::requestClearObjectStore):
(WebCore::IDBTransaction::clearObjectStoreOnServer):
(WebCore::IDBTransaction::didClearObjectStoreOnServer):
(WebCore::IDBTransaction::requestPutOrAdd):
(WebCore::IDBTransaction::putOrAddOnServer):
(WebCore::IDBTransaction::didPutOrAddOnServer):
(WebCore::IDBTransaction::deleteObjectStore):
(WebCore::IDBTransaction::deleteObjectStoreOnServer):
(WebCore::IDBTransaction::didDeleteObjectStoreOnServer):
(WebCore::IDBTransaction::deleteIndex):
(WebCore::IDBTransaction::deleteIndexOnServer):
(WebCore::IDBTransaction::didDeleteIndexOnServer):
(WebCore::IDBTransaction::operationCompletedOnClient):
(WebCore::IDBTransaction::establishOnServer):
(WebCore::IDBTransaction::activate):
(WebCore::IDBTransaction::deactivate):

• Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::removeItemsMatchingCurrentThread):

• Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::TransactionOperation::~TransactionOperation):
(WebCore::IDBClient::TransactionOperation::perform):
(WebCore::IDBClient::TransactionOperation::transitionToCompleteOnThisThread):
(WebCore::IDBClient::TransactionOperation::transitionToComplete):
(WebCore::IDBClient::TransactionOperation::doComplete):
(WebCore::IDBClient::TransactionOperation::originThread const):
(WebCore::IDBClient::TransactionOperation::originThreadID const): Deleted.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::lock):
(WebCore::AudioContext::tryLock):
(WebCore::AudioContext::unlock):
(WebCore::AudioContext::isAudioThread const):
(WebCore::AudioContext::isGraphOwner const):

• Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::setAudioThread):
(WebCore::AudioContext::audioThread const):

• Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

• Modules/webdatabase/Database.cpp:

(WebCore::Database::performClose):
(WebCore::Database::securityOrigin):

• Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::operator=):
(WebCore::DatabaseDetails::thread const):
(WebCore::DatabaseDetails::threadID const): Deleted.

• Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::detailsForNameAndOrigin):

• Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):

• Modules/webdatabase/DatabaseThread.h:

(WebCore::DatabaseThread::getThread):
(WebCore::DatabaseThread::getThreadID): Deleted.

• Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::checkAndHandleClosedDatabase):

• Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::doCleanup):
(WebCore::SQLTransactionBackend::notifyDatabaseThreadIsShuttingDown):

• bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackData::~JSCallbackData):

• bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute):

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::createdMessagePort):
(WebCore::ScriptExecutionContext::destroyedMessagePort):

• page/ResourceUsageOverlay.h:
• page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::isCurrentThread):

• platform/Supplementable.h:

(WebCore::Supplementable::provideSupplement):
(WebCore::Supplementable::removeSupplement):
(WebCore::Supplementable::requireSupplement):
(WebCore::Supplementable::Supplementable): Deleted.

• platform/Timer.cpp:

(WebCore::TimerBase::TimerBase):
(WebCore::TimerBase::start):
(WebCore::TimerBase::stop):
(WebCore::TimerBase::setNextFireTime):

• platform/Timer.h:

(WebCore::TimerBase::isActive const):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::shouldAutoActivateFontIfNeeded):

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::activateOnCompositingThread):
(WebCore::TextureMapperPlatformLayerProxy::invalidate):
(WebCore::TextureMapperPlatformLayerProxy::getAvailableBuffer):
(WebCore::TextureMapperPlatformLayerProxy::appendToUnusedBuffers):
(WebCore::TextureMapperPlatformLayerProxy::swapBuffer):

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:

(): Deleted.

• platform/ios/wak/WebCoreThread.mm:

(RunWebThread):
(StartWebThread):

• platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::close):

• platform/sql/SQLiteDatabase.h:

(WebCore::SQLiteDatabase::sqlite3Handle const):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::isContextThread const):

• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::WorkerMessagingProxy):
(WebCore::WorkerMessagingProxy::~WorkerMessagingProxy):

• workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):

• workers/WorkerThread.h:

(WebCore::WorkerThread::thread const):
(WebCore::WorkerThread::threadID const): Deleted.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobFailedWithException):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireUpdateFoundEvent):
(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::jobResolvedWithUnregistrationResult):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::jobFailedLoadingScript):
(WebCore::ServiceWorkerContainer::jobDidFinish):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::removeRegistration):
(WebCore::ServiceWorkerContainer::scheduleTaskToFireControllerChangeEvent):
(WebCore::ServiceWorkerContainer::contextIdentifier):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::resolvedWithRegistration):
(WebCore::ServiceWorkerJob::resolvedWithUnregistrationResult):
(WebCore::ServiceWorkerJob::startScriptFetch):
(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):
(WebCore::ServiceWorkerJob::notifyFinished):

• workers/service/ServiceWorkerJob.h:
• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::matchFunc):
(WebCore::openFunc):
(WebCore::initializeXMLParser):
(WebCore::XMLParserContext::createStringParser):
(WebCore::XMLParserContext::createMemoryParser):

Source/WebKit:

• UIProcess/API/glib/IconDatabase.cpp:
• UIProcess/GenericCallback.h:

(WebKit::GenericCallback::~GenericCallback):
(WebKit::GenericCallback::performCallbackWithReturnValue):

Source/WTF:

We should use a pointer of WTF::Thread instead of ThreadIdentifier.

One problem is that Windows support library uses WTF::createThread,
which returns ThreadIdentifier. So we cannot drop ThreadIdentifier
in Windows environment. This patch keeps ThreadIdentifier in Windows.

• wtf/MainThread.cpp:

(WTF::initializeMainThread):
(WTF::isMainThread):
(WTF::canAccessThreadLocalDataForThread):

• wtf/MainThread.h:
• wtf/ParkingLot.cpp:

(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::unparkOneImpl):
(WTF::ParkingLot::unparkCount):

• wtf/RecursiveLockAdapter.h:

(WTF::RecursiveLockAdapter::lock):
(WTF::RecursiveLockAdapter::unlock):
(WTF::RecursiveLockAdapter::tryLock):

• wtf/Threading.cpp:

(WTF::Thread::dump const):

• wtf/Threading.h:

(WTF::Thread::id const):
(WTF::Thread::operator==): Deleted.
(WTF::Thread::operator!=): Deleted.
(WTF::currentThread): Deleted.

• wtf/ThreadingPrimitives.h:
• wtf/ThreadingPthreads.cpp:

(WTF::Thread::waitForCompletion):
(WTF::Thread::detach):
(WTF::Thread::initializeCurrentTLS):
(WTF::Thread::suspend):
(WTF::Thread::establishPlatformSpecificHandle):
(WTF::Thread::currentID): Deleted.

• wtf/ThreadingWin.cpp:

(WTF::Thread::waitForCompletion):
(WTF::Thread::suspend):
(WTF::Thread::currentDying):

• wtf/mac/MainThreadMac.mm:

(WTF::initializeApplicationUIThread):
(WTF::initializeWebThreadPlatform):
(WTF::canAccessThreadLocalDataForThread):
(WTF::initializeApplicationUIThreadIdentifier): Deleted.
(WTF::initializeWebThreadIdentifier): Deleted.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(runThread): Deleted.
(runPthread): Deleted.
(testThreadIdentifierMap): Deleted.

• TestWebKitAPI/CMakeLists.txt:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
• TestWebKitAPI/Tests/WTF/Threading.cpp: Added.

(TestWebKitAPI::TEST):

9:40 PM Changeset in webkit [225469] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

WebSocketChannel should ensure its client is live when calling it in error case
​https://bugs.webkit.org/show_bug.cgi?id=180285

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-03
Reviewed by Darin Adler.

No observable change of behavior.
This makes it consistent with other calls of didReceiveMessageError.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::fail):

7:34 PM Changeset in webkit [225468] by ap@apple.com

• 2 edits in trunk/Source/WebCore

WebArchiveResourceWebResourceHandler leaks when pasting
​https://bugs.webkit.org/show_bug.cgi?id=180339

Reviewed by Joseph Pecoraro.

• editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attributesForAttributedStringConversion):

6:15 PM Changeset in webkit [225467] by Chris Dumez

• 17 edits
  1 move
  17 adds
  37 deletes in trunk/LayoutTests

Re-sync Service Workers web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=180336

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Re-sync Service Workers web-platform-tests from upstream 6df98083a2be.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/resources/unregister-controlling-worker.html: Added.
• web-platform-tests/service-workers/service-worker/about-blank-replacement.https-expected.txt: Added.
• web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html: Added.
• web-platform-tests/service-workers/service-worker/activation.https.html:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https-expected.txt: Added.
• web-platform-tests/service-workers/service-worker/fetch-event-respond-with-partial-stream.https.html: Added.
• web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
• web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-basics.https.html: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-cors.https.html: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-event.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-event.https.html: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/foreign-fetch-workers.https.html: Removed.
• web-platform-tests/service-workers/service-worker/iframe-sandbox-register-link-element.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/iframe-sandbox-register-link-element.https.html: Removed.
• web-platform-tests/service-workers/service-worker/interfaces-window.https-expected.txt:
• web-platform-tests/service-workers/service-worker/link-element-register-basic.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-basic.https.html: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-mime-types.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-mime-types.https.html: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-scope.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-scope.https.html: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-script-url.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-script-url.https.html: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-script.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-script.https.html: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-security-error.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/link-element-register-security-error.https.html: Removed.
• web-platform-tests/service-workers/service-worker/navigation-preload/empty-preload-response-body.https-expected.txt:
• web-platform-tests/service-workers/service-worker/navigation-preload/resources/empty-preload-response-body-scope.html: Added.
• web-platform-tests/service-workers/service-worker/register-foreign-fetch-errors.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/register-foreign-fetch-errors.https.html: Removed.
• web-platform-tests/service-workers/service-worker/register-link-header.https-expected.txt: Removed.
• web-platform-tests/service-workers/service-worker/register-link-header.https.html: Removed.
• web-platform-tests/service-workers/service-worker/registration-iframe.https.html:
• web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/registration-updateviacache.https.html:
• web-platform-tests/service-workers/service-worker/resource-timing.https-expected.txt:
• web-platform-tests/service-workers/service-worker/resource-timing.https.html:
• web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-frame.py: Added.

(main):

• web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-ping-frame.py: Added.

(main):

• web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-popup-frame.py: Added.

(main):

• web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-uncontrolled-nested-frame.html: Added.
• web-platform-tests/service-workers/service-worker/resources/about-blank-replacement-worker.js: Added.

(async.getClientByURL):
(async.pingPong.waitForPong.return.new.Promise):
(async.pingPong.waitForPong):
(async.pingPong):
(async.evt.url.searchParams):
(async.evt.evt.respondWith.async):
(evt.evt.waitUntil.async):

• web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js:

(self.onfetch):

• web-platform-tests/service-workers/service-worker/resources/empty.js: Added.
• web-platform-tests/service-workers/service-worker/resources/fetch-event-respond-with-partial-stream-worker.js: Added.

(evt.evt.request.url.includes):

• web-platform-tests/service-workers/service-worker/resources/fetch-event-test-worker.js:

(handleClientId):

• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-cors-worker.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-event-worker.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-iframe.html: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-script.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helper-worker.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-helpers.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/foreign-fetch-worker.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/iframe-register-link-element.html: Removed.
• web-platform-tests/service-workers/service-worker/resources/install-worker-helper.html: Removed.
• web-platform-tests/service-workers/service-worker/resources/interfaces-idls.js:
• web-platform-tests/service-workers/service-worker/resources/link-header.py: Removed.
• web-platform-tests/service-workers/service-worker/resources/register-foreign-fetch-errors-worker.js: Removed.
• web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.sub.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/resources/resource-timing-iframe.html.
• web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-fetch-event-iframe.html: Added.
• web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-fetch-event-worker.js: Added.

(event.waitUntil.self.clients.matchAll.then):

• web-platform-tests/service-workers/service-worker/resources/sandboxed-iframe-navigator-serviceworker-iframe.html: Added.
• web-platform-tests/service-workers/service-worker/resources/test-helpers.sub.js:
• web-platform-tests/service-workers/service-worker/resources/w3c-import.log:
• web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https-expected.txt: Added.
• web-platform-tests/service-workers/service-worker/sandboxed-iframe-fetch-event.https.html: Added.
• web-platform-tests/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https-expected.txt: Added.
• web-platform-tests/service-workers/service-worker/sandboxed-iframe-navigator-serviceworker.https.html: Added.
• web-platform-tests/service-workers/service-worker/service-worker-csp-connect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
• web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:
• web-platform-tests/service-workers/service-worker/w3c-import.log:

LayoutTests:

Skip new tests that are timing out and remove entries for tests
that were removed.

• TestExpectations:
• tests-options.json:

4:28 PM Changeset in webkit [225466] by aakash_jain@apple.com

• 2 edits in trunk/Tools

webkitpy EWS keeps retrying a failing patch
​https://bugs.webkit.org/show_bug.cgi?id=180302

Reviewed by Alexey Proskuryakov.

• Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test_patch): Instead of returning false, call report_failure()
which raises an exception, this exception is catched by earlywarningsystem.py and
it posts a comment on bugzilla. Returning false simply unlocks the patch and returns
it to the queue.

3:08 PM Changeset in webkit [225465] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/service-workers/service-worker/registration-service-worker-attributes.https.html as flaky

• TestExpectations:

3:00 PM Changeset in webkit [225464] by Caio Lima

• 6 edits in trunk/Source/JavaScriptCore

Rename DestroyFunc to avoid redefinition on unified build
​https://bugs.webkit.org/show_bug.cgi?id=180335

Reviewed by Filip Pizlo.

Changing DestroyFunc structures to more specific names to avoid
conflits on unified builds.

• heap/HeapCellType.cpp:

(JSC::HeapCellType::finishSweep):
(JSC::HeapCellType::destroy):

• runtime/JSDestructibleObjectHeapCellType.cpp:

(JSC::JSDestructibleObjectHeapCellType::finishSweep):
(JSC::JSDestructibleObjectHeapCellType::destroy):

• runtime/JSSegmentedVariableObjectHeapCellType.cpp:

(JSC::JSSegmentedVariableObjectHeapCellType::finishSweep):
(JSC::JSSegmentedVariableObjectHeapCellType::destroy):

• runtime/JSStringHeapCellType.cpp:

(JSC::JSStringHeapCellType::finishSweep):
(JSC::JSStringHeapCellType::destroy):

• wasm/js/JSWebAssemblyCodeBlockHeapCellType.cpp:

(JSC::JSWebAssemblyCodeBlockHeapCellType::finishSweep):
(JSC::JSWebAssemblyCodeBlockHeapCellType::destroy):

2:48 PM Changeset in webkit [225463] by Darin Adler

• 14 edits
  1 copy
  1 add in trunk

Add WTF::Hasher, an easier to use replacement for WTF::IntegerHasher
​https://bugs.webkit.org/show_bug.cgi?id=180318

Reviewed by JF Bastien.

Source/WTF:

• WTF.xcodeproj/project.pbxproj: Added Hasher.h.
• wtf/CMakeLists.txt: Ditto.

• wtf/Forward.h: Added Hasher and TextStream.

• wtf/Hasher.h: Moved StringHasher into a separate header. Added Hasher.

Marked IntegerHasher deprecated.

• wtf/text/CString.cpp: Include StringHasher.h instead of Hasher.h.
• wtf/text/StringHash.h: Ditto.

• wtf/text/StringHasher.h: Added. Moved StringHasher here from Hasher.h.

• wtf/text/StringImpl.h: Include StringHasher.h instead of Hasher.h.

• wtf/text/WTFString.h: Added a hash function. This was useful in some

adoption I was doing in WebCore, not included in this patch.

• wtf/unicode/UTF8.cpp: Include StringHasher.h instead of Hasher.h.

Tools:

• TestWebKitAPI/CMakeLists.txt: Added Hasher.cpp.
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.

• TestWebKitAPI/Tests/WTF/Hasher.cpp: Added. Contains tests of the new

WTF::Hasher class.

• TestWebKitAPI/Tests/WTF/StringHasher.cpp: Include StringHasher.h instead of

Hasher.h.

2:24 PM Changeset in webkit [225462] by Chris Dumez

• 20 edits in trunk

Support serviceWorker.postMessage() inside service workers
​https://bugs.webkit.org/show_bug.cgi?id=180328

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/extendable-message-event.https-expected.txt:

Source/WebCore:

Support serviceWorker.postMessage() inside service workers.

No new tests, unskipped and rebaselined existing test that is
now passing.

• workers/service/SWClientConnection.h:
• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorker):

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::fireMessageEvent):
(WebCore::ServiceWorkerThread::postMessageToServiceWorker):

• workers/service/context/ServiceWorkerThread.h:

Source/WebKit:

Support serviceWorker.postMessage() inside service workers.

• StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):

• StorageProcess/ServiceWorker/WebSWServerConnection.h:
• StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
• WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorker):

• WebProcess/Storage/WebSWClientConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerFromServiceWorker):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Unskip WPT test that no longer times out.

• TestExpectations:

1:34 PM Changeset in webkit [225461] by Chris Dumez

• 13 edits in trunk/LayoutTests

Unreviewed, unskip / rebaseline a few web platform tests.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/service-worker/clients-matchall-on-evaluation.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
• web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/postmessage-to-client.https-expected.txt:
• web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
• web-platform-tests/service-workers/service-worker/serviceworker-message-event-historical.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting-using-registration.https-expected.txt:
• web-platform-tests/service-workers/service-worker/unregister-then-register-new-script.https-expected.txt:

LayoutTests:

• TestExpectations:

12:32 PM Changeset in webkit [225460] by Chris Dumez

• 22 edits in trunk

Implement self.skipWaiting() inside service workers
​https://bugs.webkit.org/show_bug.cgi?id=180329

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/update.https-expected.txt:
• web-platform-tests/service-workers/service-worker/claim-with-redirect.https-expected.txt:
• web-platform-tests/service-workers/service-worker/postmessage-from-waiting-serviceworker.https-expected.txt:
• web-platform-tests/service-workers/service-worker/skip-waiting-without-client.https-expected.txt:

Source/WebCore:

Implement self.skipWaiting() inside service workers:

• ​https://w3c.github.io/ServiceWorker/#service-worker-global-scope-skipwaiting

Also fixes a bug where tryActivate() was calling activate() even though the
registration's active worker was "in use":

• ​https://w3c.github.io/ServiceWorker/#try-activate-algorithm

No new tests, rebaselined existing tests.

• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

• workers/service/context/SWContextManager.h:
• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::tryActivate):

• workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::skipWaiting):

• workers/service/server/SWServerToContextConnection.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::skipWaiting):

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::isSkipWaitingFlagSet const):

Source/WebKit:

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::didFinishSkipWaiting):

• StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
• StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::skipWaiting):
(WebKit::WebSWContextManagerConnection::didFinishSkipWaiting):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

• http/tests/workers/service/resources/service-worker-fetch-worker.js:

add self.skipWaiting() now that we properly wait when the registation's
active worker is in use. This is needed because this worker script is
used by http/tests/workers/service/controller-change.html. The
'controllerchange' event is only fired if an active worker is being
replaced while in use due to the waiting worker calling skipWaiting().

1:08 AM Changeset in webkit [225459] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GStreamer] GstPad leaked in WebKitTextCombiner
​https://bugs.webkit.org/show_bug.cgi?id=180314

Reviewed by Michael Catanzaro.

gst_element_get_static_pad() returns a full reference that si never freed, because gst_ghost_pad_new doesn't
take the ownership of the given pad.

• platform/graphics/gstreamer/TextCombinerGStreamer.cpp:

(webkit_text_combiner_init):

1:07 AM Changeset in webkit [225458] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GStreamer] GstCaps leaked in MediaPlayerPrivateGStreamer::createGSTPlayBin
​https://bugs.webkit.org/show_bug.cgi?id=180311

Reviewed by Michael Catanzaro.

gst_caps_new_empty_simple() is passed directly to g_object_set(). The returned caps should be freed with
gst_caps_unref().

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):