Timeline

Apr 16, 2018:

11:54 PM Changeset in webkit [230702] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Inconsistent EGL defines in ImageBufferCairo
​https://bugs.webkit.org/show_bug.cgi?id=184661

Patch by Pablo Saavedra <Pablo Saavedra> on 2018-04-16
Reviewed by Žan Doberšek.

On revision r219391 libepoxy is added. The headers in
ImageBufferCairo.cpp become inconsistent when 2D canvas is enabled
(-DENABLE_ACCELERATED_2D_CANVAS=ON) due to a redefinition error during
the Webkit build:

...
/usr/include/GLES2/gl2.h:503:82: error: 'voi
epoxy_glAttachShader(GLuint, GLuint)' redeclared as different kind
of symbol
GL_APICALL void GL_APIENTRY glAttachShader (GLuint
program, GLuint shader);

No new tests.

• platform/graphics/cairo/ImageBufferCairo.cpp:

10:48 PM Changeset in webkit [230701] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Can't select and copy text from Network tab popover
​https://bugs.webkit.org/show_bug.cgi?id=184606

Reviewed by Matt Baker.

• UserInterface/Views/ResourceTimingBreakdownView.css:

(.waterfall-popover .resource-timing-breakdown):

10:17 PM Changeset in webkit [230700] by Alan Bujtas

• 6 edits
  1 add in trunk/Tools

[LayoutReloaded] Add support for replaced box.
​https://bugs.webkit.org/show_bug.cgi?id=184680

Reviewed by Antti Koivisto.

Basic support for inline replaced.

• LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:

(InlineFormattingContext.prototype._handleInlineBox):
(InlineFormattingContext.prototype._handleInlineBlock):
(InlineFormattingContext.prototype._handleReplaced):

• LayoutReloaded/FormattingContext/InlineFormatting/Line.js:

(Line.prototype.lastLineBox):
(Line.prototype.addInlineBox):
(Line.prototype.addInlineContainerBox): Deleted.

• LayoutReloaded/TreeBuilder.js:

(TreeBuilder.prototype._createAndAttachBox):

• LayoutReloaded/Utils.js:

(Utils._dumpBox):

• LayoutReloaded/test/index.html:
• LayoutReloaded/test/inline-simple-replaced.html: Added.

8:15 PM Changeset in webkit [230699] by Alan Bujtas

• 2 edits in trunk/Tools

[LayoutReloaded] Minor InlineFormattingContext::layout() cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=184679

Reviewed by Antti Koivisto.

• LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:

(InlineFormattingContext):
(InlineFormattingContext.prototype.layout):
(InlineFormattingContext.prototype._handleInlineContainer):
(InlineFormattingContext.prototype._handleInlineContent):
(InlineFormattingContext.prototype._handleInlineBlock):
(InlineFormattingContext.prototype._handleReplacedBox):
(InlineFormattingContext.prototype._clearNeedsLayoutAndMoveToNextSibling):
(InlineFormattingContext.prototype._handleInlineBlockContainer): Deleted.
(InlineFormattingContext.prototype._clearAndMoveToNext): Deleted.

8:01 PM Changeset in webkit [230698] by timothy@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed 32-bit build fix for r230673.

​https://bugs.webkit.org/show_bug.cgi?id=184657
rdar://problem/39463307

• Configurations/PluginProcessShim.xcconfig: Use the correct names.

7:38 PM Changeset in webkit [230697] by Yusuke Suzuki

• 20 edits
  20 adds in trunk

[WebAssembly][Modules] Prototype wasm import
​https://bugs.webkit.org/show_bug.cgi?id=184600

Reviewed by JF Bastien.

JSTests:

Add wasm and wat files since module loader want to load wasm files from FS.
Currently, importing the other modules from wasm is not supported.

• wasm.yaml:
• wasm/modules/constant.wasm: Added.
• wasm/modules/constant.wat: Added.
• wasm/modules/js-wasm-function-namespace.js: Added.

(assert.throws):

• wasm/modules/js-wasm-function.js: Added.

(assert.throws):

• wasm/modules/js-wasm-global-namespace.js: Added.

(assert.throws):

• wasm/modules/js-wasm-global.js: Added.

(assert.throws):

• wasm/modules/js-wasm-memory-namespace.js: Added.

(assert.throws):

• wasm/modules/js-wasm-memory.js: Added.

(assert.throws):

• wasm/modules/js-wasm-start.js: Added.

(then):

• wasm/modules/js-wasm-table-namespace.js: Added.

(assert.throws):

• wasm/modules/js-wasm-table.js: Added.

(assert.throws):

• wasm/modules/memory.wasm: Added.
• wasm/modules/memory.wat: Added.
• wasm/modules/start.wasm: Added.
• wasm/modules/start.wat: Added.
• wasm/modules/sum.wasm: Added.
• wasm/modules/sum.wat: Added.
• wasm/modules/table.wasm: Added.
• wasm/modules/table.wat: Added.

Source/JavaScriptCore:

This patch is an initial attempt to implement Wasm loading in module pipeline.
Currently,

1. We only support Wasm loading in the JSC shell. Once loading mechanism is specified in whatwg HTML, we should integrate this into WebCore.

2. We only support exporting values from Wasm. Wasm module cannot import anything from the other modules now.

When loading a file, JSC shell checks wasm magic. If the wasm magic is found, JSC shell
loads the file with WebAssemblySourceProvider. It is wrapped into JSSourceCode and
module loader pipeline just handles it as the same to JS. When parsing a module, we
checks the type of JSSourceCode. If the source code is Wasm source code, we create a
WebAssemblyModuleRecord instead of JSModuleRecord. Our module pipeline handles
AbstractModuleRecord and Wasm module is instantiated, linked, and evaluated.

• builtins/ModuleLoaderPrototype.js:

(globalPrivate.newRegistryEntry):
(requestInstantiate):
(link):

• jsc.cpp:

(convertShebangToJSComment):
(fillBufferWithContentsOfFile):
(fetchModuleFromLocalFileSystem):
(GlobalObject::moduleLoaderFetch):

• parser/SourceProvider.h:

(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::hostResolveImportedModule):
(JSC::AbstractModuleRecord::link):
(JSC::AbstractModuleRecord::evaluate):
(JSC::identifierToJSValue): Deleted.

• runtime/AbstractModuleRecord.h:
• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::evaluate):

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):
(JSC::JSModuleRecord::instantiateDeclarations):

• runtime/JSModuleRecord.h:
• runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeParseModule):
(JSC::moduleLoaderPrototypeRequestedModules):
(JSC::moduleLoaderPrototypeModuleDeclarationInstantiation):

• wasm/js/JSWebAssemblyHelpers.h:

(JSC::getWasmBufferFromValue):
(JSC::createSourceBufferFromValue):

• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finalizeCreation):
(JSC::JSWebAssemblyInstance::createPrivateModuleKey):
(JSC::JSWebAssemblyInstance::create):

• wasm/js/JSWebAssemblyInstance.h:
• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::prepareLink):
(JSC::WebAssemblyModuleRecord::link):

• wasm/js/WebAssemblyModuleRecord.h:
• wasm/js/WebAssemblyPrototype.cpp:

(JSC::resolve):
(JSC::instantiate):
(JSC::compileAndInstantiate):
(JSC::WebAssemblyPrototype::instantiate):
(JSC::webAssemblyInstantiateFunc):
(JSC::webAssemblyValidateFunc):

• wasm/js/WebAssemblyPrototype.h:

7:02 PM Changeset in webkit [230696] by Alan Bujtas

• 1 edit
  2 adds in trunk/Tools

[LayoutReloaded] Introduce fragmentation state/context.
​https://bugs.webkit.org/show_bug.cgi?id=184677

Reviewed by Antti Koivisto.

State/context for fragmented content (multicol, regions, pagination etc).

• LayoutReloaded/FormattingContext/FragmentationContext.js: Added.

(FragmentationContext):

• LayoutReloaded/FormattingState/FragmentationState.js: Added.

(FragmentationState):
(FragmentationState.prototype.formattingState):

6:56 PM Changeset in webkit [230695] by fpizlo@apple.com

• 3 edits in trunk/Source/WebCore

MutationObserver should be in an IsoHeap
​https://bugs.webkit.org/show_bug.cgi?id=184671
<rdar://problem/36081981>

Reviewed by Sam Weinig.

No new tests because no new behavior.

• dom/MutationObserver.cpp:
• dom/MutationObserver.h:

6:20 PM Changeset in webkit [230694] by aestes@apple.com

• 6 edits in trunk

[iOS] Enable WKPDFView by default
​https://bugs.webkit.org/show_bug.cgi?id=184675
<rdar://problem/27885452>

Reviewed by Darin Adler.

Source/WebKit:

• UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:

(-[WKWebViewContentProviderRegistry init]):

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

5:19 PM Changeset in webkit [230693] by Kocsen Chung

• 7 edits in tags/Safari-606.1.13.2/Source

Versioning.

5:17 PM Changeset in webkit [230692] by Kocsen Chung

• 1 copy in tags/Safari-606.1.13.2

New tag.

4:57 PM Changeset in webkit [230691] by Keith Rollin

• 4 edits in trunk/LayoutTests

REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=184673
<rdar://problem/39474698>

Unreviewed test gardening. The test was flaky because the HTTP parser
would try to preload the Javascript resource. Sometimes this operation
would complete in time to print its own console message, duplicating a
subsequent one when the non-preloading resource-load occurs. Updated
the test to load the Javascript in such a way that it skips the reload
step.

• TestExpectations:
• http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt:
• http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html:

4:46 PM Changeset in webkit [230690] by Kocsen Chung

• 7 edits in branches/safari-605-branch/Source

Versioning.

4:43 PM Changeset in webkit [230689] by Brent Fulgham

• 5 edits in trunk/Source

[macOS] Don't establish unneeded Dock connections
​https://bugs.webkit.org/show_bug.cgi?id=184664
<rdar://problem/16863698>

Reviewed by Simon Fraser.

There is no reason for the WebContent or Plugin processes to interact with
the Dock. We should tell AppKit that we don't want this connection, and to
avoid creating such connections.

Source/WebCore/PAL:

• pal/spi/mac/NSApplicationSPI.h: Add Dock connection declaration.

Source/WebKit:

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess): Tell NSApplication to
not create a Dock connection.

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Ditto.

4:18 PM Changeset in webkit [230688] by Ross Kirsling

• 2 edits
  208 adds in trunk/LayoutTests

Unreviewed. Update WinCairo TestExpectations in preparation for LayoutTests automation.

• platform/wincairo/TestExpectations:

Updated current failures for directories A-E. Added temporary skips for everything after.

• platform/wincairo/accessibility:
• platform/wincairo/animations/3d:
• platform/wincairo/css2.1:
• platform/wincairo/css3:
• platform/wincairo/editing:
• platform/wincairo/fast/css-generated-content:
• platform/wincairo/fast/dom:
• platform/wincairo/legacy-animation-engine/animations/3d:
• platform/wincairo/legacy-animation-engine/compositing:

Added expectation files.

3:59 PM Changeset in webkit [230687] by youenn@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Set H264 VT encoder usage to 1
​https://bugs.webkit.org/show_bug.cgi?id=184668

Reviewed by Eric Carlson.

• Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:

(-[RTCVideoEncoderH264 configureCompressionSession]):

3:46 PM Changeset in webkit [230686] by Megan Gardner

• 4 edits in trunk

Switch to UIWKTextInteractionAssistant for non-editable text
​https://bugs.webkit.org/show_bug.cgi?id=182834

Reviewed by Beth Dakin.

Source/WebKit:

Switch to only using one assistant for text selection.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView useSelectionAssistantWithGranularity:]):

LayoutTests:

Marking tests as flaky and to be fixed later.

• platform/ios-wk2/TestExpectations:

3:29 PM Changeset in webkit [230685] by Kocsen Chung

• 4 edits in tags/Safari-606.1.13.1

Revert r230683. rdar://problem/39397649

3:29 PM Changeset in webkit [230684] by Kocsen Chung

• 4 edits in tags/Safari-606.1.13.1/Source

Revert r230682. rdar://problem/39344671

2:52 PM Changeset in webkit [230683] by Kocsen Chung

• 4 edits in tags/Safari-606.1.13.1

Cherry-pick r230665. rdar://problem/39397649

[Web Animations] Animations do not naturally get a finish event
​https://bugs.webkit.org/show_bug.cgi?id=184639
<rdar://problem/39397649>

Reviewed by Jon Lee.

LayoutTests/imported/w3c:

Record two progressions in the Web Animations WPT tests.

• web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

We must call updateFinishedState() when an animation gets sampled as it means its timeline's time has progressed
and it may have crossed to a finished state. Calling updateFinishedState() when sampling means that we'll correctly
set the animation's hold time to its end value, which means that currentTime() will now always be clamped to return
the end time once its has reached it, so we must not schedule animations to resolve immediately anymore since otherwise
they will keep being scheduled in a loop.

• animation/WebAnimation.cpp: (WebCore::WebAnimation::timeToNextRequiredTick const): (WebCore::WebAnimation::resolve):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@230665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:52 PM Changeset in webkit [230682] by Kocsen Chung

• 4 edits in tags/Safari-606.1.13.1/Source

Cherry-pick r230521. rdar://problem/39344671

[Web Animations] Turn Web Animations on by default
​https://bugs.webkit.org/show_bug.cgi?id=184491

Patch by Antoine Quint <Antoine Quint> on 2018-04-11
Reviewed by Simon Fraser.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

Source/WebKit:

• Shared/WebPreferences.yaml:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@230521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:50 PM Changeset in webkit [230681] by youenn@apple.com

• 29 edits
  12 copies
  6 adds in trunk

Use NetworkLoadChecker to handle synchronous HTTP loads
​https://bugs.webkit.org/show_bug.cgi?id=184240

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/cors/request-headers-expected.txt:
• web-platform-tests/XMLHttpRequest/access-control-and-redirects-expected.txt:
• web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt:
• web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt:

Source/WebCore:

Update LoaderStrategy::loadResourceSynchronously to pass FetchOptions directly.
Update various call sites accordingly. This allows NetworkProcess to do all necessary checks.
Add an option to disable security checks if NetworkProcess does it for WebProcess.
This option will be also used for regular asynchronous loads in future patches.

Update DocumentThreadableLoader to bypass preflighting and response validation checks in case they are done in NetworkProcess.

Covered by existing and rebased tests.

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::doPreflight):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::loadRequest):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

• loader/FrameLoader.h:
• loader/LoaderStrategy.h:
• xml/XSLTProcessorLibxslt.cpp:

(WebCore::docLoaderFunc):

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):

Source/WebKit:

For every NetworkResourceLoader synchronous load, we create a NetworkLoadChecker.
NetworkLoadChecker handles all security checks in that case.
This allows supporting cross-origin loads for synchronous XHR.

Updated NetworkCORSPreflightChecker to return the result as a ResourceError.
This is used to convey any error message from NetworkProcess to the JS console.
Ensure NetworkCORSPreflightChecker computes correctly Access-Control-Request-Headers value
by providing the headers set by the application plus Referrer/Origin.

• NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
(WebKit::NetworkResourceLoader::continueWillSendRequest):
(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
(WebKit::NetworkResourceLoader::validateCacheEntry):

• NetworkProcess/NetworkResourceLoader.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResourceSynchronously):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::loadResourceSynchronously):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

• http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt:
• http/wpt/beacon/cors/cors-preflight-blob-failure.html: Fix buggy assertion.

Test should check for actual request header and not header name in Access-Control-Request-Headers.

• http/wpt/beacon/cors/cors-preflight-blob-success.html: Ditto.
• platform/mac-wk1/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
• platform/mac-wk1/http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt: Added.
• platform/mac-wk1/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/access-control-and-redirects-expected.txt: Added.
• platform/win/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt: Added.
• platform/win/http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt: Added.
• platform/win/http/tests/xmlhttprequest/cross-origin-no-authorization-expected.txt: Added.
• platform/mac-highsierra-wk2/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt.
• platform/mac-highsierra-wk2/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt.
• platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt.
• platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt.
• platform/mac-wk1/imported/w3c/web-platform-tests/cors/request-headers-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/cors/request-headers-expected.txt.
• platform/win/http/tests/xmlhttprequest/access-control-and-redirects-expected.txt:
• platform/win/http/tests/xmlhttprequest/access-control-preflight-not-successful-expected.txt:
• platform/win/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-basic-setrequestheader-expected.txt.
• platform/win/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt.
• platform/win/imported/w3c/web-platform-tests/cors/request-headers-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/cors/request-headers-expected.txt.

2:03 PM Changeset in webkit [230680] by msaboff@apple.com

• 1 edit
  121 adds in trunk/Tools

Perl-based Test262 runner
​https://bugs.webkit.org/show_bug.cgi?id=183343

Patch by Leo Balter <Leo Balter> on 2018-04-16
Reviewed by Michael Saboff.

• Scripts/test262-helpers/README.md: Added.
• Scripts/test262-helpers/agent.js: Added.

(262.getGlobal):
(262.setGlobal):
(262.destroy):
(262.IsHTMLDDA):

• Scripts/test262-helpers/cpanfile: Added.
• Scripts/test262-helpers/cpanfile.snapshot: Added.
• Scripts/test262-helpers/test262-runner.pl: Added.

(main):
(processFile):
(getScenarios):
(addScenario):
(compileTest):
(runTest):
(processResult):
(getTempFile):
(getContents):
(parseData):
(getHarness):

• Scripts/test262-helpers/tests.log: Added.

1:56 PM WPE edited by clopez@igalia.com

update isntructions for wpebackend-fdo (diff)

12:45 PM Changeset in webkit [230679] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WinCairo] Media elements should be enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=184597

Patch by Christopher Reid <​chris.reid@sony.com> on 2018-04-16
Reviewed by Per Arne Vollan.

Enabling media elements by default with media foundation.

• page/SettingsDefaultValues.h:

12:22 PM Changeset in webkit [230678] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Curl] Add the Accept-Language field to curl request headers
​https://bugs.webkit.org/show_bug.cgi?id=184605

Patch by Christopher Reid <​chris.reid@sony.com> on 2018-04-16
Reviewed by Alex Christensen.

Add Accept-Language field to curl request headers

• platform/network/curl/CurlRequest.cpp:
• platform/network/curl/CurlRequest.h:

12:20 PM Changeset in webkit [230677] by pvollan@apple.com

• 2 edits in trunk/Source/WTF

Deactivate the WindowServer connection for the WebContent process.
​https://bugs.webkit.org/show_bug.cgi?id=184451
<rdar://problem/38313938>

Reviewed by Brent Fulgham.

Defining ENABLE_WEBPROCESS_WINDOWSERVER_BLOCKING as 1 will deactivate the WindowServer connection
for the WebContent process by enabling the call to 'CGSSetDenyWindowServerConnections(true)' on
process startup. After calling this function, every attempt to establish a connection to the
WindowServer from the WebContent process will fail, except for CA render server connections.

• wtf/FeatureDefines.h:

12:02 PM Changeset in webkit [230676] by Chris Dumez

• 10 edits in trunk/Source/WebCore

Move more WindowProxy-related logic from ScriptController to WindowProxyController
​https://bugs.webkit.org/show_bug.cgi?id=184640

Reviewed by Ryosuke Niwa.

Move more WindowProxy-related logic from ScriptController to WindowProxyController,
for clarity.

• bindings/js/JSDOMWindowProxy.cpp:

(WebCore::JSDOMWindowProxy::attachDebugger):

• bindings/js/JSDOMWindowProxy.h:
• bindings/js/ScriptCachedFrameData.cpp:

(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::initScriptForWindowProxy):

• bindings/js/ScriptController.h:

(WebCore::ScriptController::existingCacheableBindingRootObject const):

• bindings/js/WindowProxyController.cpp:

(WebCore::collectGarbageAfterWindowProxyDestruction):
(WebCore::WindowProxyController::~WindowProxyController):
(WebCore::WindowProxyController::clearWindowProxiesNotMatchingDOMWindow):
(WebCore::WindowProxyController::setDOMWindowForWindowProxy):
(WebCore::WindowProxyController::attachDebugger):

• bindings/js/WindowProxyController.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::clear):

• page/Page.cpp:

(WebCore::Page::setDebugger):

11:53 AM Changeset in webkit [230675] by BJ Burg

• 3 edits in trunk/Source/WebKit

[Cocoa] Web Automation: add SPI to terminate automation session and disconnect the remote end
​https://bugs.webkit.org/show_bug.cgi?id=184523
<rdar://problem/39368599>

Reviewed by Simon Fraser.

When a user breaks the automation glass pane and chooses "Stop Session", there is no way
for Safari to actually disconnect the remote connection using automation-related ObjC SPI.
This can lead to sessions getting stuck and safaridriver is unable to request a new session.

Expose the -terminate method as SPI. This disconnects the remote connection and then notifies
the session delegate that the remote disconnected. At that point, Safari can uninstall
the session from the process pool and tear down other session state.

• UIProcess/API/Cocoa/_WKAutomationSession.h:
• UIProcess/API/Cocoa/_WKAutomationSession.mm:

(-[_WKAutomationSession terminate]):

11:33 AM Changeset in webkit [230674] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
​https://bugs.webkit.org/show_bug.cgi?id=184652

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-04-16
Reviewed by Philippe Normand.

In the constructor we should mark selected streams based on the default values from GstStream,
if the user changes them, they will be updated as required later on.

No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.

• platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer):

• platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp:

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):

11:29 AM Changeset in webkit [230673] by timothy@apple.com

• 5 edits in trunk/Source/WebKit

Clean up OTHER_LDFLAGS for WebKit processes
​https://bugs.webkit.org/show_bug.cgi?id=184657

Reviewed by Jer Noble.

• Configurations/PluginProcessShim.xcconfig:
• Configurations/PluginService.32.xcconfig:
• Configurations/PluginService.64.xcconfig:
• Configurations/WebContentService.xcconfig:

11:05 AM Changeset in webkit [230672] by Kocsen Chung

• 7 edits in tags/Safari-606.1.13.1/Source

Versioning.

10:55 AM Changeset in webkit [230671] by bshafiei@apple.com

• 7 edits in trunk/Source

Versioning.

10:48 AM Changeset in webkit [230670] by Kocsen Chung

• 1 copy in tags/Safari-606.1.13.1

New tag.

9:01 AM Changeset in webkit [230669] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
​https://bugs.webkit.org/show_bug.cgi?id=184651

Patch by Thibault Saunier <​tsaunier@igalia.com> on 2018-04-16
Reviewed by Philippe Normand.

We can't notify the client if none is connected, but still we need to fill our metadatas from
the provided GstTagList, especially in the case of playbin3 where the client is not set yet
at construct time but the metadata might already be preset (and won't be updated later on).

No new tests are added as we already have a few ones that are currently disabled in
the mediastream testsuite. This patch is part of the work to enable them.

• platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged):

7:36 AM Changeset in webkit [230668] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark css3/filters/blur-various-radii.html as a crash on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=184649

Unreviewed test gardening.

• platform/win/TestExpectations:

1:47 AM Changeset in webkit [230667] by graouts@webkit.org

• 4 edits in trunk

[Web Animations] Ensure we never return -0 through the API
​https://bugs.webkit.org/show_bug.cgi?id=184644

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Record one progression in the Web Animations WPT tests.

• web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

We could sometimes return -0 instead of 0, which is surprising and leads to an error in WPT tests.
This would happen when playbackRate < 0.

• animation/WebAnimationUtilities.h:

(WebCore::secondsToWebAnimationsAPITime):

Apr 15, 2018:

11:58 PM Changeset in webkit [230666] by rniwa@webkit.org

• 7 edits in trunk/Websites/perf.webkit.org

Make it possible to hide some repository groups
​https://bugs.webkit.org/show_bug.cgi?id=184632

Reviewed by Saam Barati.

Added the ability to hide repository groups in the custom analysis task configurator from the admin page.
Hidden repositroy groups will continue to function for existing test groups. This is purely an UI change.

• init-database.sql: Added repositorygroup_hidden as a new column to triggerable_repository_groups.
• public/admin/triggerables.php: Added a form field to hide a repository group.
• public/include/manifest-generator.php: Include hidden state in the manifest file.
• public/v3/components/custom-analysis-task-configurator.js:

(CustomAnalysisTaskConfigurator.prototype._renderRepositoryPanes): Filter out hidden repository groups.

• public/v3/models/triggerable.js:

(prototype.isHidden): Added.

• server-tests/api-manifest-tests.js: Updated an existing test case to test a hidden repository group.

10:38 PM Changeset in webkit [230665] by graouts@webkit.org

• 4 edits in trunk

[Web Animations] Animations do not naturally get a finish event
​https://bugs.webkit.org/show_bug.cgi?id=184639
<rdar://problem/39397649>

Reviewed by Jon Lee.

LayoutTests/imported/w3c:

Record two progressions in the Web Animations WPT tests.

• web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

We must call updateFinishedState() when an animation gets sampled as it means its timeline's time has progressed
and it may have crossed to a finished state. Calling updateFinishedState() when sampling means that we'll correctly
set the animation's hold time to its end value, which means that currentTime() will now always be clamped to return
the end time once its has reached it, so we must not schedule animations to resolve immediately anymore since otherwise
they will keep being scheduled in a loop.

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::timeToNextRequiredTick const):
(WebCore::WebAnimation::resolve):

6:01 PM Changeset in webkit [230664] by Chris Dumez

• 21 edits
  2 adds in trunk

Change Event's returnValue so it doesn't expose a new primitive
​https://bugs.webkit.org/show_bug.cgi?id=184415

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import test coverage from ​https://github.com/w3c/web-platform-tests/pull/10258.

• web-platform-tests/dom/events/AddEventListenerOptions-passive-expected.txt:
• web-platform-tests/dom/events/AddEventListenerOptions-passive.html:
• web-platform-tests/dom/events/Event-constructors.html:
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt:
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html:
• web-platform-tests/dom/events/Event-defaultPrevented-expected.txt:
• web-platform-tests/dom/events/Event-defaultPrevented.html:
• web-platform-tests/dom/events/Event-dispatch-click.html:
• web-platform-tests/dom/events/Event-dispatch-detached-click.html:
• web-platform-tests/dom/events/Event-dispatch-other-document.html:
• web-platform-tests/dom/events/Event-initEvent.html:
• web-platform-tests/dom/events/Event-returnValue-expected.txt: Added.
• web-platform-tests/dom/events/Event-returnValue.html: Added.
• web-platform-tests/dom/events/EventListener-handleEvent.html:
• web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue-expected.txt:
• web-platform-tests/dom/events/EventTarget-dispatchEvent-returnvalue.html:
• web-platform-tests/dom/events/w3c-import.log:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/interfaces/dom.idl:

Source/WebCore:

Update Event.returnValue setter to match the latest DOM specification after:

• ​https://github.com/whatwg/dom/pull/626

In particular, the returnValue setter is now a no-op if the new flag value
is true. If the input flag value is false, it only sets the 'canceled' flag
if the event is cancelable and the event’s in passive listener flag is unset.

Test: imported/w3c/web-platform-tests/dom/events/Event-returnValue.html

• dom/Event.cpp:

(WebCore::Event::setLegacyReturnValue):
(WebCore::Event::setCanceledFlagIfPossible):
(WebCore::Event::preventDefault):

• dom/Event.h:

2:21 PM Changeset in webkit [230663] by aestes@apple.com

• 3 edits
  1 add in trunk/Tools

[iOS] Add API tests for PDF find-in-page
​https://bugs.webkit.org/show_bug.cgi?id=184634

Reviewed by Dan Bernstein.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/find.pdf: Added.
• TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:

(-[TestFindDelegate findString]):
(-[TestFindDelegate _webView:didCountMatches:forString:]):
(-[TestFindDelegate _webView:didFindMatches:forString:withMatchIndex:]):
(-[TestFindDelegate _webView:didFailToFindString:]):
(loadWebView):
(TEST):

10:38 AM Changeset in webkit [230662] by fpizlo@apple.com

• 7 edits
  5 adds in trunk

Function.prototype.caller shouldn't return generator bodies
​https://bugs.webkit.org/show_bug.cgi?id=184630

Reviewed by Yusuke Suzuki.
JSTests:

• stress/function-caller-async-arrow-function-body.js: Added.
• stress/function-caller-async-function-body.js: Added.
• stress/function-caller-async-generator-body.js: Added.
• stress/function-caller-generator-body.js: Added.
• stress/function-caller-generator-method-body.js: Added.

Source/JavaScriptCore:

Function.prototype.caller no longer returns generator bodies. Those are meant to be
private.

Also added some builtin debugging tools so that it's easier to do the investigation that I
did.

• builtins/BuiltinNames.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::callerGetter):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncBuiltinDescribe):

• runtime/JSGlobalObjectFunctions.h:

9:32 AM Changeset in webkit [230661] by Michael Catanzaro

• 4 edits
  1 add in trunk

[WPE] Install files needed for WebKitWebExtensions
​https://bugs.webkit.org/show_bug.cgi?id=179915

Reviewed by Žan Doberšek.

.:

• Source/cmake/OptionsWPE.cmake:

Source/WebKit:

• PlatformWPE.cmake: Install pkg-config file, injected bundle, and API headers.
• UIProcess/API/glib/WebKitWebContext.cpp: Load the injected bundle when installed.
• wpe/wpe-web-extension.pc.in: Added.