Timeline

Mar 4, 2019:

11:58 PM Changeset in webkit [242412] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=195272

Unreviewed test gardening.

• platform/gtk/TestExpectations:

11:55 PM Changeset in webkit [242411] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r242376.

Broke some tests

Reverted changeset:

"Correctly handle sandbox extensions when the same WKWebView
loads multiple ​file:// URLs."
​https://bugs.webkit.org/show_bug.cgi?id=195291
​https://trac.webkit.org/changeset/242376

8:27 PM Changeset in webkit [242410] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Reload actions from second level inspector should properly reload the inspected inspector
​https://bugs.webkit.org/show_bug.cgi?id=195306

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-04
Reviewed by Matt Baker.

• UserInterface/Base/Main.js:

Provide a better reload for a Nth level inspector.

• UserInterface/Debug/Bootstrap.js:

(WI.runBootstrapOperations):
Simplify, should not need to check for InspectorFrontendHost.

8:24 PM Changeset in webkit [242409] by Fujii Hironori

• 2 edits in trunk/Source/WebKit

Use a SQLite database to hold the ResourceLoadStatistics data
​https://bugs.webkit.org/show_bug.cgi?id=194867
<rdar://problem/24240854>

Unreviewed build fix for WinCairo.

ResourceLoadStatisticsDebug and RELEASE_LOG_INFO_IF are not
defined because WinCairo port defines RELEASE_LOG_DISABLED.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess): Enclosed RELEASE_LOG_INFO_IF with #if !RELEASE_LOG_DISABLED.
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener): Ditto.
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking): Ditto.

8:22 PM Changeset in webkit [242408] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: MediaSource logging not initialized properly
​https://bugs.webkit.org/show_bug.cgi?id=195307

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-04
Reviewed by Matt Baker.

• UserInterface/Controllers/ConsoleManager.js:

(WI.ConsoleManager.prototype.initializeLogChannels):
Typo caused undefined to be included and trigger assertions.

8:00 PM Changeset in webkit [242407] by Justin Fan

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for High Sierra.

• platform/graphics/gpu/cocoa/GPUBufferMetal.mm: Should fix "global constructor" error.

7:00 PM Changeset in webkit [242406] by Brent Fulgham

• 22 edits
  1 move
  4 adds in trunk/Source

Use a SQLite database to hold the ResourceLoadStatistics data
​https://bugs.webkit.org/show_bug.cgi?id=194867
<rdar://problem/24240854>

Reviewed by Chris Dumez.

Source/WebCore:

Add a new runtime feature flag to support use of an experimental database
back-end. Also expose some SQLite function calls for use outside of WebCore.

No change in functionality, so no new tests.

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setItpDatabaseModeEnabled):
(WebCore::RuntimeEnabledFeatures::itpDatabaseModeEnabled const):

• platform/sql/SQLiteDatabase.h:
• platform/sql/SQLiteStatement.h:

Source/WebKit:

The ResourceLoadStatistics database plist is inefficient. It requires more memory use
than it needs, and forces lots of looping and string comparisons to find information.

This problem has already been solved in the form of relational databases. We use them
elsewhere in WebKit, and should do so for this storage as well.

This patch creates an optional SQLite database to handle ITP operations.

1. It adds a new internal experimental feature flag to activate it. It requires the user exit and restart the process to take effect.
2. It populates itself from the existing plist file (if it exists).
3. It stops using the plist in favor of the database.
4. It does queries and other operations using the database instead of the old hash table implementation.

This patch refactors the exisiting ResourceLoadStatisticsMemoryStore class into a base
ResourceLoadStatisticsStore class, which ResourceLoadStatisticsMemoryStore is based on.
It adds a new ResourceLoadStatisticsDatabaseStore that is implemented in terms of SQL
operations.

These code changes should not have any impact on existing operations, and when enabled
should produce the same test results.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp: Added.

(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::createSchema):
(WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertObservedDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::relationshipExists const):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationship):
(WebKit::ResourceLoadStatisticsDatabaseStore::confirmDomainDoesNotExist const):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainIDFromString const):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationships):
(WebKit::ResourceLoadStatisticsDatabaseStore::databaseIsEmpty const):
(WebKit::ResourceLoadStatisticsDatabaseStore::populateFromMemoryStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::calculateAndSubmitTelemetry const):
(WebKit::ResourceLoadStatisticsDatabaseStore::incrementRecordsDeletedCountForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::recursivelyFindNonPrevalentDomainsThatRedirectedToThisDomain):
(WebKit::buildList):
(WebKit::ResourceLoadStatisticsDatabaseStore::markAsPrevalentIfHasRedirectedToPrevalent):
(WebKit::listToString):
(WebKit::ResourceLoadStatisticsDatabaseStore::findNotVeryPrevalentResources):
(WebKit::ResourceLoadStatisticsDatabaseStore::reclassifyResources):
(WebKit::ResourceLoadStatisticsDatabaseStore::classifyPrevalentResources):
(WebKit::ResourceLoadStatisticsDatabaseStore::syncStorageIfNeeded):
(WebKit::ResourceLoadStatisticsDatabaseStore::syncStorageImmediately):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::requestStorageAccessUnderOpener):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccess):
(WebKit::ResourceLoadStatisticsDatabaseStore::grantStorageAccessInternal):
(WebKit::ResourceLoadStatisticsDatabaseStore::grandfatherDataForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensurePrevalentResourcesForDebugMode):
(WebKit::ResourceLoadStatisticsDatabaseStore::logFrameNavigation):
(WebKit::ResourceLoadStatisticsDatabaseStore::logSubresourceLoading):
(WebKit::ResourceLoadStatisticsDatabaseStore::logSubresourceRedirect):
(WebKit::ResourceLoadStatisticsDatabaseStore::setUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::logUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasHadUserInteraction):
(WebKit::ResourceLoadStatisticsDatabaseStore::setPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setDomainsAsPrevalent):
(WebKit::ResourceLoadStatisticsDatabaseStore::dumpResourceLoadStatistics const):
(WebKit::ResourceLoadStatisticsDatabaseStore::predicateValueForDomain const):
(WebKit::ResourceLoadStatisticsDatabaseStore::isPrevalentResource const):
(WebKit::ResourceLoadStatisticsDatabaseStore::isVeryPrevalentResource const):
(WebKit::ResourceLoadStatisticsDatabaseStore::isRegisteredAsSubresourceUnder const):
(WebKit::ResourceLoadStatisticsDatabaseStore::isRegisteredAsSubFrameUnder const):
(WebKit::ResourceLoadStatisticsDatabaseStore::isRegisteredAsRedirectingTo const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::setGrandfathered):
(WebKit::ResourceLoadStatisticsDatabaseStore::isGrandfathered const):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubframeUnderTopFrameOrigin):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUnderTopFrameOrigin):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setSubresourceUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectTo):
(WebKit::ResourceLoadStatisticsDatabaseStore::setTopFrameUniqueRedirectFrom):
(WebKit::ResourceLoadStatisticsDatabaseStore::ensureResourceStatisticsForPrimaryDomain):
(WebKit::ResourceLoadStatisticsDatabaseStore::clear):
(WebKit::ResourceLoadStatisticsDatabaseStore::cookieTreatmentForOrigin const):
(WebKit::ResourceLoadStatisticsDatabaseStore::hasUserGrantedStorageAccessThroughPrompt):
(WebKit::ResourceLoadStatisticsDatabaseStore::domainsToBlock const):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlocking):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateCookieBlockingForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearBlockingStateForDomains):
(WebKit::ResourceLoadStatisticsDatabaseStore::processStatistics const):
(WebKit::ResourceLoadStatisticsDatabaseStore::prevalentDomains const):
(WebKit::ResourceLoadStatisticsDatabaseStore::findExpiredUserInteractions const):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearExpiredUserInteractions):
(WebKit::ResourceLoadStatisticsDatabaseStore::clearGrandfathering):
(WebKit::ResourceLoadStatisticsDatabaseStore::topPrivatelyControlledDomainsToRemoveWebsiteDataFor):
(WebKit::ResourceLoadStatisticsDatabaseStore::pruneStatisticsIfNeeded):
(WebKit::ResourceLoadStatisticsDatabaseStore::updateLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setLastSeen):
(WebKit::ResourceLoadStatisticsDatabaseStore::setVeryPrevalentResource):
(WebKit::ResourceLoadStatisticsDatabaseStore::removeAllStorageAccess):

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h: Added.

(WebKit::ResourceLoadStatisticsDatabaseStore::isEmpty const):

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:

(WebKit::ResourceLoadStatisticsMemoryStore::ResourceLoadStatisticsMemoryStore):
(WebKit::ResourceLoadStatisticsMemoryStore::incrementRecordsDeletedCountForDomains):
(WebKit::ResourceLoadStatisticsMemoryStore::classifyPrevalentResources):
(WebKit::ResourceLoadStatisticsMemoryStore::syncStorageIfNeeded):
(WebKit::ResourceLoadStatisticsMemoryStore::syncStorageImmediately):
(WebKit::ResourceLoadStatisticsMemoryStore::grandfatherDataForDomains):
(WebKit::domainsToString): Deleted.
(WebKit::OperatingDate::fromWallTime): Deleted.
(WebKit::OperatingDate::today): Deleted.
(WebKit::OperatingDate::secondsSinceEpoch const): Deleted.
(WebKit::OperatingDate::operator== const): Deleted.
(WebKit::OperatingDate::operator< const): Deleted.
(WebKit::OperatingDate::operator<= const): Deleted.
(WebKit::OperatingDate::OperatingDate): Deleted.
(WebKit::mergeOperatingDates): Deleted.
(WebKit::computeImportance): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::~ResourceLoadStatisticsMemoryStore): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setNotifyPagesWhenDataRecordsWereScanned): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setShouldClassifyResourcesBeforeDataRecordsRemoval): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setShouldSubmitTelemetry): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::removeDataRecords): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::processStatisticsAndDataRecords): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::grandfatherExistingWebsiteData): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setResourceLoadStatisticsDebugMode): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setPrevalentResourceForDebugMode): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::scheduleStatisticsProcessingRequestIfNecessary): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::cancelPendingStatisticsProcessingRequest): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setTimeToLiveUserInteraction): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setMinimumTimeBetweenDataRecordsRemoval): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setGrandfatheringTime): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setCacheMaxAgeCap): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::updateCacheMaxAgeCap): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setAgeCapForClientSideCookies): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::updateClientSideCookiesAgeCap): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::shouldRemoveDataRecords const): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setDataRecordsBeingRemoved): Deleted.
(WebKit::debugLogDomainsInBatches): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::includeTodayAsOperatingDateIfNecessary): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::hasStatisticsExpired const): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setMaxStatisticsEntries): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setPruneEntriesDownTo): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::resetParametersToDefaultValues): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::logTestingEvent): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::didCreateNetworkProcess): Deleted.

• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:

(WebKit::ResourceLoadStatisticsMemoryStore::data const):
(WebKit::ResourceLoadStatisticsMemoryStore::isDebugModeEnabled const): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::store const): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setStorageAccessPromptsEnabled): Deleted.
(WebKit::ResourceLoadStatisticsMemoryStore::setDebugLogggingEnabled): Deleted.
(): Deleted.

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: Added.

(WebKit::domainsToString):
(WebKit::OperatingDate::fromWallTime):
(WebKit::OperatingDate::today):
(WebKit::OperatingDate::secondsSinceEpoch const):
(WebKit::OperatingDate::operator== const):
(WebKit::OperatingDate::operator< const):
(WebKit::OperatingDate::operator<= const):
(WebKit::ResourceLoadStatisticsStore::ResourceLoadStatisticsStore):
(WebKit::ResourceLoadStatisticsStore::~ResourceLoadStatisticsStore):
(WebKit::ResourceLoadStatisticsStore::calculateAndSubmitTelemetry const):
(WebKit::ResourceLoadStatisticsStore::computeImportance):
(WebKit::ResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::ResourceLoadStatisticsStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::ResourceLoadStatisticsStore::setShouldSubmitTelemetry):
(WebKit::ResourceLoadStatisticsStore::removeDataRecords):
(WebKit::ResourceLoadStatisticsStore::processStatisticsAndDataRecords):
(WebKit::ResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
(WebKit::ResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):
(WebKit::ResourceLoadStatisticsStore::setPrevalentResourceForDebugMode):
(WebKit::ResourceLoadStatisticsStore::scheduleStatisticsProcessingRequestIfNecessary):
(WebKit::ResourceLoadStatisticsStore::cancelPendingStatisticsProcessingRequest):
(WebKit::ResourceLoadStatisticsStore::setTimeToLiveUserInteraction):
(WebKit::ResourceLoadStatisticsStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::ResourceLoadStatisticsStore::setGrandfatheringTime):
(WebKit::ResourceLoadStatisticsStore::setCacheMaxAgeCap):
(WebKit::ResourceLoadStatisticsStore::updateCacheMaxAgeCap):
(WebKit::ResourceLoadStatisticsStore::setAgeCapForClientSideCookies):
(WebKit::ResourceLoadStatisticsStore::updateClientSideCookiesAgeCap):
(WebKit::ResourceLoadStatisticsStore::shouldRemoveDataRecords const):
(WebKit::ResourceLoadStatisticsStore::setDataRecordsBeingRemoved):
(WebKit::ResourceLoadStatisticsStore::updateCookieBlockingForDomains):
(WebKit::ResourceLoadStatisticsStore::clearBlockingStateForDomains):
(WebKit::ResourceLoadStatisticsStore::processStatistics const):
(WebKit::ResourceLoadStatisticsStore::statisticsEpirationTime const):
(WebKit::ResourceLoadStatisticsStore::mergeOperatingDates):
(WebKit::ResourceLoadStatisticsStore::includeTodayAsOperatingDateIfNecessary):
(WebKit::ResourceLoadStatisticsStore::hasStatisticsExpired const):
(WebKit::ResourceLoadStatisticsStore::setMaxStatisticsEntries):
(WebKit::ResourceLoadStatisticsStore::setPruneEntriesDownTo):
(WebKit::ResourceLoadStatisticsStore::resetParametersToDefaultValues):
(WebKit::ResourceLoadStatisticsStore::logTestingEvent):
(WebKit::ResourceLoadStatisticsStore::removeAllStorageAccess):
(WebKit::ResourceLoadStatisticsStore::didCreateNetworkProcess):
(WebKit::ResourceLoadStatisticsStore::debugLogDomainsInBatches):

• NetworkProcess/Classifier/ResourceLoadStatisticsStore.h: Copied from Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h.

(WebKit::OperatingDate::OperatingDate):
(WebKit::ResourceLoadStatisticsStore::isEmpty const):
(WebKit::ResourceLoadStatisticsStore::data const):
(WebKit::ResourceLoadStatisticsStore::isDebugModeEnabled const):
(WebKit::ResourceLoadStatisticsStore::store const):
(WebKit::ResourceLoadStatisticsStore::setStorageAccessPromptsEnabled):
(WebKit::ResourceLoadStatisticsStore::setDebugLogggingEnabled):

• NetworkProcess/Classifier/ResourceLoadStatisticsStoreCocoa.mm: Renamed from Source/WebKit/UIProcess/Cocoa/ResourceLoadStatisticsMemoryStoreCocoa.mm.

(WebKit::ResourceLoadStatisticsStore::registerUserDefaultsIfNeeded):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::setNotifyPagesWhenDataRecordsWereScanned):
(WebKit::WebResourceLoadStatisticsStore::setShouldClassifyResourcesBeforeDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsStore::setShouldSubmitTelemetry):
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
(WebKit::WebResourceLoadStatisticsStore::setResourceLoadStatisticsDebugMode):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResourceForDebugMode):
(WebKit::WebResourceLoadStatisticsStore::scheduleStatisticsAndDataRecordsProcessing):
(WebKit::WebResourceLoadStatisticsStore::hasStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadStatisticsStore::grantStorageAccess):
(WebKit::WebResourceLoadStatisticsStore::performDailyTasks):
(WebKit::WebResourceLoadStatisticsStore::logFrameNavigation):
(WebKit::WebResourceLoadStatisticsStore::logWebSocketLoading):
(WebKit::WebResourceLoadStatisticsStore::logSubresourceLoading):
(WebKit::WebResourceLoadStatisticsStore::logSubresourceRedirect):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::clearUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::hasHadUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setLastSeen):
(WebKit::WebResourceLoadStatisticsStore::setPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isVeryPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubresourceUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsSubFrameUnder):
(WebKit::WebResourceLoadStatisticsStore::isRegisteredAsRedirectingTo):
(WebKit::WebResourceLoadStatisticsStore::clearPrevalentResource):
(WebKit::WebResourceLoadStatisticsStore::setGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::isGrandfathered):
(WebKit::WebResourceLoadStatisticsStore::setSubframeUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setSubresourceUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectTo):
(WebKit::WebResourceLoadStatisticsStore::setTopFrameUniqueRedirectFrom):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookieBlockingUpdate):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookieBlockingUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearBlockingStateForDomains):
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent):
(WebKit::WebResourceLoadStatisticsStore::setTimeToLiveUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::setMinimumTimeBetweenDataRecordsRemoval):
(WebKit::WebResourceLoadStatisticsStore::setGrandfatheringTime):
(WebKit::WebResourceLoadStatisticsStore::setMaxStatisticsEntries):
(WebKit::WebResourceLoadStatisticsStore::setPruneEntriesDownTo):
(WebKit::WebResourceLoadStatisticsStore::resetParametersToDefaultValues):

• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• Platform/classifier/ResourceLoadStatisticsClassifier.cpp:

(WebKit::ResourceLoadStatisticsClassifier::calculateResourcePrevalence):

• Platform/classifier/ResourceLoadStatisticsClassifier.h:
• Shared/WebPreferences.yaml:
• Sources.txt:
• SourcesCocoa.txt:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

• UIProcess/WebProcessPool.cpp:
• WebKit.xcodeproj/project.pbxproj:

5:34 PM Changeset in webkit [242405] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CSS: class input isn't fully centered
​https://bugs.webkit.org/show_bug.cgi?id=195297

Reviewed by Matt Baker.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(body[dir=ltr] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.
(body[dir=rtl] .sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input): Deleted.

4:55 PM Changeset in webkit [242404] by Justin Fan

• 25 edits
  2 copies
  4 adds in trunk

[Web GPU] Blitting function prototypes
​https://bugs.webkit.org/show_bug.cgi?id=195224
<rdar://problem/48538902>

Reviewed by Dean Jackson.

Source/WebCore:

Implement barebones GPUCommandBuffer::copy* prototypes while rounding out GPUTexture implementation details.

Test: webgpu/blit-commands.html

• Modules/webgpu/GPUOrigin3D.h: Added.
• Modules/webgpu/GPUOrigin3D.idl: Added.
• Modules/webgpu/WebGPUCommandBuffer.cpp: Add copy view struct implementations.

(WebCore::WebGPUBufferCopyView::asGPUBufferCopyView const): Added.
(WebCore::WebGPUTextureCopyView::asGPUTextureCopyView const): Added.
(WebCore::WebGPUCommandBuffer::copyBufferToBuffer): Added.
(WebCore::WebGPUCommandBuffer::copyBufferToTexture): Added.
(WebCore::WebGPUCommandBuffer::copyTextureToBuffer): Added.
(WebCore::WebGPUCommandBuffer::copyTextureToTexture): Added.

• Modules/webgpu/WebGPUCommandBuffer.h: Add new functions and supporting structs.
• Modules/webgpu/WebGPUCommandBuffer.idl: Ditto.
• Modules/webgpu/WebGPURenderPassDescriptor.cpp: Refactor constructors to copy the entire base class.

(WebCore::GPURenderPassColorAttachmentDescriptor::GPURenderPassColorAttachmentDescriptor):
(WebCore::GPURenderPassDepthStencilAttachmentDescriptor::GPURenderPassDepthStencilAttachmentDescriptor):
(WebCore::WebGPURenderPassDescriptor::asGPURenderPassDescriptor const):
(WebCore::attachment): Deleted.

• Modules/webgpu/WebGPUTexture.h:

(WebCore::WebGPUTexture::texture const): Added.

• platform/graphics/gpu/GPUBuffer.h:

(WebCore::GPUBuffer::byteLength const): Added.
(WebCore::GPUBuffer::isTransferSource const): Added.
(WebCore::GPUBuffer::isTransferDestination const): Renamed from isTransferDst. Refactored for OptionSet API.
(WebCore::GPUBuffer::isVertex const): Ditto.
(WebCore::GPUBuffer::isUniform const): Ditto.
(WebCore::GPUBuffer::isStorage const): Ditto.
(WebCore::GPUBuffer::isMappable const): Ditto.
(WebCore::GPUBuffer::isMapWrite const): Ditto.
(WebCore::GPUBuffer::isMapRead const): Ditto.

• platform/graphics/gpu/GPUBufferUsage.h: Refactored for better bit flag style.
• platform/graphics/gpu/GPUCommandBuffer.h:

(WebCore::GPUCommandBuffer::blitEncoder const): Added.

• platform/graphics/gpu/GPURenderPassDescriptor.h:
• platform/graphics/gpu/GPUTexture.h: Cache usage flags for reference.

(WebCore::GPUTexture::isTransferSrc const): Added.
(WebCore::GPUTexture::isTransferDst const): Added.
(WebCore::GPUTexture::isOutputAttachment const): Added.

• platform/graphics/gpu/GPUTextureUsage.h: Refactor to match GPUBufferUsage.h.
• platform/graphics/gpu/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::validateBufferUsage): Renamed from validateBufferCreate, refactored for OptionSet.
(WebCore::GPUBuffer::tryCreate):
(WebCore::GPUBuffer::GPUBuffer):
(WebCore::GPUBuffer::isReadOnly const):
(WebCore::GPUBuffer::setSubData): Add alignment check according to Metal docs.

• platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:

(WebCore::GPUCommandBuffer::create): No need to use this alias here.
(WebCore::GPUCommandBuffer::GPUCommandBuffer): Ditto.
(WebCore::GPUCommandBuffer::copyBufferToBuffer): Added.
(WebCore::GPUCommandBuffer::copyBufferToTexture): Added.
(WebCore::GPUCommandBuffer::copyTextureToBuffer): Added.
(WebCore::GPUCommandBuffer::copyTextureToTexture): Added.

• platform/graphics/gpu/cocoa/GPUQueueMetal.mm:

(WebCore::GPUQueue::submit): End encoding on the MTLCommandBuffer's blitCommandEncoder if it was used.

• platform/graphics/gpu/cocoa/GPUSwapChainMetal.mm:

(WebCore::GPUSwapChain::getNextTexture): Now provide usage flags to texture creation.

• platform/graphics/gpu/cocoa/GPUTextureMetal.mm:

(WebCore::mtlTextureUsageForGPUTextureUsageFlags): Refactor validation.
(WebCore::tryCreateMtlTextureDescriptor): Ditto.
(WebCore::GPUTexture::tryCreate): Now provide usage flags to texture creation.
(WebCore::GPUTexture::create): Ditto.
(WebCore::GPUTexture::GPUTexture): Ditto.
(WebCore::GPUTexture::createDefaultTextureView): Ditto.

LayoutTests:

Add basic test to copy data with all new blitting functions and verify the result.

• webgpu/blit-commands-expected.html: Added.
• webgpu/blit-commands.html: Added.
• webgpu/buffer-command-buffer-races.html: Fixed typo.
• webgpu/resources/green-400.png: Added.

4:43 PM Changeset in webkit [242403] by Alan Bujtas

• 6 edits
  2 adds in trunk

[ContentChangeObserver] Introduce fixed duration content observation
​https://bugs.webkit.org/show_bug.cgi?id=195295
<rdar://problem/48579913>

Reviewed by Simon Fraser.

Source/WebCore:

Some pages have a runloop-like scheduling setup where the content triggering change happens at a nested timer firing.
This patch helps finding cases like that using a 32ms long fixed window. Currently nested timers get dropped on the floor and
we stop observing for content changes before they even get fired.

Test: fast/events/touch/ios/visibility-change-happens-on-timer-hops.html

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::ContentChangeObserver):
(WebCore::ContentChangeObserver::startContentObservationForDuration):
(WebCore::ContentChangeObserver::stopDurationBasedContentObservation):
(WebCore::ContentChangeObserver::hasDeterminateState const):
(WebCore::ContentChangeObserver::adjustObservedState):

• page/ios/ContentChangeObserver.h:

(WebCore::ContentChangeObserver::isObservingContentChanges const):
(WebCore::ContentChangeObserver::hasPendingActivity const):

Source/WebKit:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

LayoutTests:

• fast/events/touch/ios/visibility-change-happens-on-timer-hops-expected.txt: Added.
• fast/events/touch/ios/visibility-change-happens-on-timer-hops.html: Added.

4:42 PM Changeset in webkit [242402] by Kocsen Chung

• 1 copy in tags/Safari-607.1.40.0.4

Tag Safari-607.1.40.0.4.

4:31 PM Changeset in webkit [242401] by Wenson Hsieh

• 5 edits
  2 adds in trunk

Native text selection UI is incorrectly suppressed in Microsoft Visio
​https://bugs.webkit.org/show_bug.cgi?id=195178
<rdar://problem/48519394>

Reviewed by Darin Adler.

Source/WebCore:

Currently, our heuristics for detecting hidden editable areas attempt to search for empty parent renderers with
"overflow: hidden". It does this by ascending the layer tree in search of renderers that have an empty content
size, and whose renderers' styles indicate that they have overflow: hidden in the X or Y directions. This fails
in the case where a child renderer is positioned out of flow, relative to one of its parent layers, since the
child will be visible, but we'll incorrectly believe that it is hidden. This leads to selection UI unexpectedly
disappearing in the online version of Microsoft Visio.

To fix this, we check whether the enclosing layer around the editable element has an empty clip rect; if the
element is inside of a subframe, we additionally walk up to each enclosing frame's layer and check if that
frame's layer has an empty clip rect.

Test: editing/selection/ios/do-not-hide-selection-in-visible-container.html

• rendering/RenderObject.cpp:

(WebCore::RenderObject::isTransparentOrFullyClippedRespectingParentFrames const):

LayoutTests:

Add a new layout test that focuses several different text fields and checks whether or not editing UI is shown:

1. A text field inside an overflow: hidden container, all within an absolutely positioned iframe, such that the

text field is not visible. The caret should be hidden.

2. A text field inside an absolutely positioned iframe, inside an overflow: hidden container, such that the

text field is visible. The caret should be visible.

3. A text field inside a relatively positioned iframe in an overflow: hidden container, such that the text field

is not visible. The caret should be hidden.

4. A text field that is position: fixed inside an overflow: hidden container, such that the text field is

visible. The caret should be visible.

• editing/selection/ios/do-not-hide-selection-in-visible-container-expected.txt: Added.
• editing/selection/ios/do-not-hide-selection-in-visible-container.html: Added.
• editing/selection/ios/hide-selection-in-empty-overflow-hidden-container.html:
• resources/ui-helper.js:

(window.UIHelper.activateElementAndWaitForInputSession):

Add a convenience function in UIHelper that taps a given element and waits for the keyboard to show.

4:09 PM Changeset in webkit [242400] by Truitt Savell

• 9 edits in trunk/Source/WebKit

Unreviewed, rolling out r242396.

Found issue to be unrelated. reverting my rollout.

Reverted changeset:

"Unreviewed, rolling out r242222."
​https://bugs.webkit.org/show_bug.cgi?id=193683
​https://trac.webkit.org/changeset/242396

3:51 PM Changeset in webkit [242399] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for debug builds after r242397

• runtime/JSString.h:

3:49 PM Changeset in webkit [242398] by jiewen_tan@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed, a followup after r242336

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webViewDidMoveToWindow):
Copy the list of observers before iterating it to avoid observers modifying the list.

3:27 PM Changeset in webkit [242397] by ysuzuki@apple.com

• 11 edits
  1 add in trunk

[JSC] Store bits for JSRopeString in 3 stores
​https://bugs.webkit.org/show_bug.cgi?id=195234

Reviewed by Saam Barati.

JSTests:

• stress/null-rope-and-collectors.js: Added.

Source/JavaScriptCore:

This patch cleans up the initialization of JSRopeString fields in DFG and FTL.
Previously, we store some part of data separately. Instead, this patch calculates
the data first by bit operations and store calculated data with fewer stores.

This patch also cleans up is8Bit and isSubstring flags. We put them in lower bits
of the first fiber instead of the upper 16 bits. Since we only have 3 bit flags, (isRope, is8Bit, isSubstring),
we can put them into the lower 3 bits, they are always empty due to alignment.

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl): A bit clean up of StringLength IC to give a chance of unnecessary mov removal.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::canBeRope):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):
(JSC::DFG::SpeculativeJIT::compileMakeRope):

• dfg/DFGSpeculativeJIT.h:
• ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::isRopeString):
(JSC::FTL::DFG::LowerDFGToB3::isNotRopeString):

• runtime/JSString.cpp:

(JSC::JSString::visitChildren):

• runtime/JSString.h:

(JSC::JSString::is8Bit const):
(JSC::JSString::isSubstring const):

• tools/JSDollarVM.cpp:

(JSC::functionCreateNullRopeString):
(JSC::JSDollarVM::finishCreation):

3:11 PM Changeset in webkit [242396] by Truitt Savell

• 9 edits in trunk/Source/WebKit

Unreviewed, rolling out r242222.

Broke internal debug testing

Reverted changeset:

"[iOS] Move calls to [UIKeyboard isInHardwareKeyboardMode] to
the UI process."
​https://bugs.webkit.org/show_bug.cgi?id=193683
​https://trac.webkit.org/changeset/242222

2:57 PM Changeset in webkit [242395] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: show the version number in the UI
​https://bugs.webkit.org/show_bug.cgi?id=195292

Reviewed by Matt Baker.

• UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype._updateNoAuditsPlaceholder):
Fix the logic for showing a placeholder when editing or with only disabled tests.

• UserInterface/Views/AuditNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.audit > .content > .message-text-view): Added.
(.audit-version): Added.
Don't obstruct the "Edit" button when showing a placeholder.

• Localizations/en.lproj/localizedStrings.js:

2:36 PM Changeset in webkit [242394] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Unreviewed build fix after r242378

• UIProcess/ios/EditableImageController.mm:

(WebKit::EditableImageController::associateWithAttachment):

2:09 PM Changeset in webkit [242393] by Alan Coon

• 2 edits in branches/safari-608.1.5.1-branch/Source/WebKit

Cherry-pick r242376. rdar://problem/47820581

Correctly handle sandbox extensions when the same WKWebView loads multiple ​file:// URLs.
<rdar://problem/47820581> and ​https://bugs.webkit.org/show_bug.cgi?id=195291

Reviewed by Andy Estes.

• WebProcess/WebPage/WebPage.cpp: (WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL we're currently loading is functionally equivalent to the previous one.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:08 PM Changeset in webkit [242392] by Alan Coon

• 7 edits in branches/safari-608.1.5.1-branch/Source

Versioning.

2:00 PM Changeset in webkit [242391] by rniwa@webkit.org

• 3 edits in trunk/Source/WebCore

gPictureOwnerMap is unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=195228

Reviewed by Zalan Bujtas.

Just store in HTMLImageElement. An extra pointer isn't going to affect the memory use here.
If anything, we should worry about m_editableImage and m_pendingClonedAttachmentID instead.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::pictureElement const):
(WebCore::HTMLImageElement::setPictureElement):

• html/HTMLImageElement.h:

1:59 PM Changeset in webkit [242390] by Alan Coon

• 2 edits in tags/Safari-608.1.7.1.1/Source/WebKit

Cherry-pick r242376. rdar://problem/47820581

Correctly handle sandbox extensions when the same WKWebView loads multiple ​file:// URLs.
<rdar://problem/47820581> and ​https://bugs.webkit.org/show_bug.cgi?id=195291

Reviewed by Andy Estes.

• WebProcess/WebPage/WebPage.cpp: (WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL we're currently loading is functionally equivalent to the previous one.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:57 PM Changeset in webkit [242389] by dbates@webkit.org

• 2 edits in trunk/Source/WebCore

[iOS] Caret x-position in empty text area does not match text field
​https://bugs.webkit.org/show_bug.cgi?id=195125
<rdar://problem/47161070>

Remove the word "use" in the added comment to make it read well.

• css/html.css:

(textarea):

1:53 PM Changeset in webkit [242388] by Kocsen Chung

• 10 edits in branches/safari-607-branch

Cherry-pick r242302. rdar://problem/48572673

Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=195229
<rdar://problem/48520362>

Reviewed by Chris Dumez.

Source/WebKit:

Just like _setBoundInterfaceIdentifier, we need a way to set these properties after instantiation of a WKWebsiteDataStore,
but we need to make sure we don't set it after the parameters have been copied to the NetworkProcess.

Functionality verified by manual testing. See radar.
Added an API test that verifies the setter restrictions work as expected.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]): (-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]): (-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]): (-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::toPKPaymentRequest):
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters):
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): (WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier):
• UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::sourceApplicationBundleIdentifier): (WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:52 PM Changeset in webkit [242387] by rniwa@webkit.org

• 10 edits
  1 add in trunk

Add WeakHashSet
​https://bugs.webkit.org/show_bug.cgi?id=195152

Reviewed by Antti Koivisto.

Source/WTF:

Added WeakHashSet which is a HashSet of WeakPtr. When the object pointed by WeakPtr is deleted,
WeakHashSet treats the key to be no longer in the set. That is, WeakHashSet::contains returns false
and const_iterator skips such a WeakPtr in the set.

We decided not to make HashSet<WeahPtr<T>> work because it involves weird semantics such as making
find(X) delete the table entry as remove(find(X)) would be a no-op otherwise as find(X) would return
necessarily need to return HashSet<WeakPtr<T>>::end().

Furthermore, we cannot determine the true size of this set in O(1) because the objected pointed by
some of WeakPtr in the set may have already been deleted. This has implications that we can't have
size(), isEmpty(), random(), etc... as O(1) operation.

WeakHashSet is implemented as HashSet<WeakReference<T>>. HashTable::rehash has been updated to delete
WeakReference<T>'s whose m_ptr has become null, and HashTable::expand first deletes any such entry
before deciding an actual expansion is needed. This is accomplished via newly added hash trait,
hasIsReleasedWeakValueFunction, and HashTraits<Ref<WeakReference<T>>>::isReleasedWeakValue which
returns true for when WeakReference<T> pointed by Ref<WeakReference<T>> has null m_ptr, not to be
confused with Ref<WeakReference<T>> itself pointing to a null WeakReference<T>.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Forward.h:
• wtf/HashSet.h:

(WTF::HashSet<T, U, V>::checkConsistency const): Added.

• wtf/HashTable.h:

(WTF::HashTable::isReleasedWeakBucket): Added.
(WTF::HashTable::expand): Delete WeakReference<T> with null m_ptr first. This updates m_keyCount
and may make mustRehashInPlace() return true.
(WTF::HashTable::deleteReleasedWeakBuckets): Added.
(WTF::HashTable::rehash): Delete WeakReference<T> with null m_ptr. Also refactored the code a bit
to avoid keep repeating oldTable[i].

• wtf/HashTraits.h:

(WTF::HashTraits<T>::isHashTraitsReleasedWeakValue): Added.
(WTF::RefHashTraits<T>): Extracted from HashTraits<Ref<P>> to share code with
HashTraits<Ref<WeakReference<T>>>.
(WTF::HashTraitsReleasedWeakValueChecker<Traits, hasIsReleasedWeakValueFunction>): Added.
(WTF::isHashTraitsReleasedWeakValue<Traits, hasIsReleasedWeakValueFunction>): Added.

• wtf/WeakHashSet.h: Added.

(WTF::WeakHashSet): Added.
(WTF::WeakHashSet::WeakHashSetConstIterator::WeakHashSetConstIterator):
(WTF::WeakHashSet::WeakHashSetConstIterator::get const):
(WTF::WeakHashSet::WeakHashSetConstIterator::operator* const):
(WTF::WeakHashSet::WeakHashSetConstIterator::operator-> const):
(WTF::WeakHashSet::WeakHashSetConstIterator::operator++):
(WTF::WeakHashSet::WeakHashSetConstIterator::skipEmptyBuckets):
(WTF::WeakHashSet::WeakHashSetConstIterator::operator== const):
(WTF::WeakHashSet::WeakHashSetConstIterator::operator!= const):
(WTF::WeakHashSet::WeakHashSet):
(WTF::WeakHashSet::begin const):
(WTF::WeakHashSet::end const):
(WTF::WeakHashSet::add):
(WTF::WeakHashSet::remove):
(WTF::WeakHashSet::contains const):
(WTF::WeakHashSet::capacity const):
(WTF::WeakHashSet::computeSize const): Deletes any WeakReference<T> with null m_ptr first.
(WTF::WeakHashSet::checkConsistency const):
(WTF::HashTraits<Ref<WeakReference<T>>>): Added. This hash traits triggers the new code in HashTable's
expand and rehash methods to delete WeakReference<T> with null m_ptr.
(WTF::HashTraits<Ref<WeakReference<T>>>::isReleasedWeakValue):

• wtf/WeakPtr.h:

(WTF::WeakReference::~WeakReference): Added so that we can keep track the number of live WeakReference
in API tests by template specializations.

Tools:

Added tests for WeakHashSet.

• TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::Base::Base): Moved.
(TestWebKitAPI::Derived::foo): Moved.
(WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
(WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
(WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
(TestWebKitAPI::computeSizeOfWeakHashSet): Added.

1:48 PM Changeset in webkit [242386] by commit-queue@webkit.org

• 10 edits in trunk/Source

ITMLKit Inspector: Data Bindings / Associated Data for nodes
​https://bugs.webkit.org/show_bug.cgi?id=195290
<rdar://problem/48304019>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2019-03-04
Reviewed by Devin Rousso.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Source/WebCore:

• inspector/agents/InspectorDOMAgent.h:
• inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getDataBindingsForNode):
(WebCore::InspectorDOMAgent::getAssociatedDataForNode):
Stub these for web pages, they will only be used for ITMLKit right now.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

New title and empty message strings.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.css:

(.sidebar > .panel.dom-node-details .details-section.dom-node-associated-data > .content .row):

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WI.DOMNodeDetailsSidebarPanel.prototype.initialLayout):
(WI.DOMNodeDetailsSidebarPanel.prototype.layout):
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshDataBindings):
(WI.DOMNodeDetailsSidebarPanel.prototype._refreshAssociatedData):
(WI.DOMNodeDetailsSidebarPanel.prototype._attributesChanged):
New Node sections only enabled for ITMLKit WI.sharedApp.hasExtraDomains.

• UserInterface/Views/ObjectTreeView.js:

(WI.ObjectTreeView):
Provide a way, like TreeElement/View to access the ObjectTreeView from an element.

1:37 PM Changeset in webkit [242385] by Alan Coon

• 7 edits in tags/Safari-608.1.7.1.1/Source

Versioning.

1:33 PM Changeset in webkit [242384] by Alan Coon

• 1 copy in tags/Safari-608.1.7.1.1

New tag.

1:26 PM Changeset in webkit [242383] by Kocsen Chung

• 10 edits in branches/safari-607.1.40.0-branch

Cherry-pick r242302. rdar://problem/48572657

Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=195229
<rdar://problem/48520362>

Reviewed by Chris Dumez.

Source/WebKit:

Just like _setBoundInterfaceIdentifier, we need a way to set these properties after instantiation of a WKWebsiteDataStore,
but we need to make sure we don't set it after the parameters have been copied to the NetworkProcess.

Functionality verified by manual testing. See radar.
Added an API test that verifies the setter restrictions work as expected.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore _sourceApplicationBundleIdentifier]): (-[WKWebsiteDataStore _setSourceApplicationBundleIdentifier:]): (-[WKWebsiteDataStore _sourceApplicationSecondaryIdentifier]): (-[WKWebsiteDataStore _setSourceApplicationSecondaryIdentifier:]):
• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::toPKPaymentRequest):
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::WebsiteDataStore::parameters):
• UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::WebsiteDataStore): (WebKit::WebsiteDataStore::setSourceApplicationSecondaryIdentifier): (WebKit::WebsiteDataStore::setSourceApplicationBundleIdentifier):
• UIProcess/WebsiteData/WebsiteDataStore.h: (WebKit::WebsiteDataStore::sourceApplicationBundleIdentifier): (WebKit::WebsiteDataStore::sourceApplicationSecondaryIdentifier):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:20 PM Changeset in webkit [242382] by ysuzuki@apple.com

• 8 edits in trunk/Source/JavaScriptCore

[JSC] Make Reflect lazily-allocated by dropping @Reflect references from builtin JS
​https://bugs.webkit.org/show_bug.cgi?id=195250

Reviewed by Saam Barati.

By removing @Reflect from builtin JS, we can make Reflect object allocation lazy.
We move @ownKeys function from @Reflect to @Object to remove @Reflect reference.

We also remove m_intlObject field from JSGlobalObject since we no longer use it.

• builtins/BuiltinNames.h:
• builtins/GlobalOperations.js:

(globalPrivate.copyDataProperties):
(globalPrivate.copyDataPropertiesNoExclusions):

• runtime/JSGlobalObject.cpp:

(JSC::createReflectProperty):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:
• runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
(JSC::objectConstructorOwnKeys):

• runtime/ReflectObject.cpp:

(JSC::ReflectObject::finishCreation):

1:17 PM Changeset in webkit [242381] by Alan Coon

• 7 edits in tags/Safari-608.1.7.3/Source

Versioning.

1:13 PM Changeset in webkit [242380] by Alan Coon

• 1 copy in tags/Safari-608.1.7.3

New tag.

1:07 PM Changeset in webkit [242379] by dbates@webkit.org

• 40 edits
  3 adds in trunk

[iOS] Caret x-position in empty text area does not match text field
​https://bugs.webkit.org/show_bug.cgi?id=195125
<rdar://problem/47161070>

Reviewed by Darin Adler.

Source/WebCore:

Fix up User Agent styles for <textarea> on iOS such that they have the same left padding
width and same text-indent as <input type="text">. This makes the x-position of the caret
in an empty textarea match the position of the caret in an empty text field.

Test: fast/forms/textarea/ios/caret-x-position-in-textarea-matches-textfield.html

• css/html.css:

(textarea): For iOS Family, do not use the padding shorthand property. Instead explicitly specify
padding-top and padding-bottom to be 2px to keep our current behavior (because it looks reasonable)
and do not specify left and right padding so that we inherit the padding set earlier in this file.
(textarea::placeholder): Deleted. This was added to "try" to make fix up the position of the placeholder
text so as to match the position of the textarea's inner text and the position of a text field's inner
text. This fix up may have worked out visually when it was added, but based on the discovery of the
hardcoded 3px left and right padding (see below remark) it looks like it was always one pixel too short.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createInnerTextStyle): Remove hardcoded 3px left and right padding.

LayoutTests:

Update expected results due to changes in padding.

• TestExpectations: Remove some tests that are now passing.
• editing/selection/ios/show-selection-in-empty-overflow-hidden-document-expected.txt:
• editing/selection/ios/show-selection-in-empty-overflow-hidden-document.html:
• fast/forms/textarea/ios/caret-x-position-in-textarea-matches-textfield-expected.txt: Added.
• fast/forms/textarea/ios/caret-x-position-in-textarea-matches-textfield.html: Added.
• platform/ios-wk2/editing/input/reveal-caret-of-multiline-input-expected.txt:
• platform/ios-wk2/editing/inserting/4960120-1-expected.txt:
• platform/ios-wk2/editing/pasteboard/pasting-tabs-expected.txt:
• platform/ios-wk2/fast/block/float/overhanging-tall-block-expected.txt:
• platform/ios-wk2/fast/block/margin-collapse/103-expected.txt:
• platform/ios-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
• platform/ios-wk2/fast/dynamic/008-expected.txt:
• platform/ios-wk2/fast/forms/basic-textareas-expected.txt:
• platform/ios-wk2/fast/forms/textAreaLineHeight-expected.txt:
• platform/ios-wk2/fast/forms/textarea-align-expected.txt:
• platform/ios-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
• platform/ios-wk2/fast/forms/textarea-placeholder-visibility-1-expected.txt:
• platform/ios-wk2/fast/forms/textarea-placeholder-visibility-2-expected.txt:
• platform/ios-wk2/fast/forms/textarea-scroll-height-expected.txt:
• platform/ios-wk2/fast/forms/textarea-scrollbar-expected.txt:
• platform/ios-wk2/fast/forms/textarea-scrolled-type-expected.txt:
• platform/ios-wk2/fast/forms/textarea-setinnerhtml-expected.txt:
• platform/ios-wk2/fast/hidpi/resize-corner-hidpi-expected.txt:
• platform/ios-wk2/fast/overflow/overflow-x-y-expected.txt:
• platform/ios-wk2/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
• platform/ios-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
• platform/ios/TestExpectations:
• platform/ios/compositing/overflow/textarea-scroll-touch-expected.txt:
• platform/ios/fast/forms/form-element-geometry-expected.txt:
• platform/ios/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
• platform/ios/fast/forms/negativeLineHeight-expected.txt:
• platform/ios/fast/forms/text-control-intrinsic-widths-expected.txt:
• platform/ios/fast/forms/textarea-width-expected.txt:
• platform/ios/fast/replaced/width100percent-textarea-expected.txt:
• platform/ios/fast/scrolling/ios/textarea-scroll-touch-expected.txt:
• platform/ios/tables/mozilla/bugs/bug194024-expected.txt:
• platform/ios/tables/mozilla/bugs/bug30559-expected.txt:
• platform/ios/tables/mozilla/bugs/bug30692-expected.txt:

1:01 PM Changeset in webkit [242378] by Brent Fulgham

• 5 edits in trunk/Source/WebKit

Check contextIDs when handling WebContent messages
​https://bugs.webkit.org/show_bug.cgi?id=195289
<rdar://problem/48475870>

Reviewed by Alex Christensen.

The WebContent process is untrusted because it handles arbitrary markup and javascript from untrusted sources.
We should handle its messages with suspicion, and make sure the arguments are valid and usable before honoring them.

This patch hardens the message passing layer by performing MESSAGE_CHECK in places that had been overlooked.

• UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::setUpPlaybackControlsManagerWithID):
(WebKit::PlaybackSessionManagerProxy::currentTimeChanged):
(WebKit::PlaybackSessionManagerProxy::bufferedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::seekableRangesVectorChanged):
(WebKit::PlaybackSessionManagerProxy::canPlayFastReverseChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionOptionsChanged):
(WebKit::PlaybackSessionManagerProxy::audioMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::legibleMediaSelectionIndexChanged):
(WebKit::PlaybackSessionManagerProxy::externalPlaybackPropertiesChanged):
(WebKit::PlaybackSessionManagerProxy::wirelessVideoPlaybackDisabledChanged):
(WebKit::PlaybackSessionManagerProxy::mutedChanged):
(WebKit::PlaybackSessionManagerProxy::volumeChanged):
(WebKit::PlaybackSessionManagerProxy::durationChanged):
(WebKit::PlaybackSessionManagerProxy::playbackStartedTimeChanged):
(WebKit::PlaybackSessionManagerProxy::rateChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureSupportedChanged):
(WebKit::PlaybackSessionManagerProxy::pictureInPictureActiveChanged):
(WebKit::PlaybackSessionManagerProxy::handleControlledElementIDResponse const):

• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints):
(WebKit::UserMediaCaptureManagerProxy::startProducingData):
(WebKit::UserMediaCaptureManagerProxy::stopProducingData):
(WebKit::UserMediaCaptureManagerProxy::end):
(WebKit::UserMediaCaptureManagerProxy::capabilities):
(WebKit::UserMediaCaptureManagerProxy::setMuted):
(WebKit::UserMediaCaptureManagerProxy::applyConstraints):

• UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::VideoFullscreenManagerProxy::setHasVideo):
(WebKit::VideoFullscreenManagerProxy::setVideoDimensions):
(WebKit::VideoFullscreenManagerProxy::enterFullscreen):
(WebKit::VideoFullscreenManagerProxy::exitFullscreen):
(WebKit::VideoFullscreenManagerProxy::exitFullscreenWithoutAnimationToMode):
(WebKit::VideoFullscreenManagerProxy::setInlineRect):
(WebKit::VideoFullscreenManagerProxy::setHasVideoContentLayer):
(WebKit::VideoFullscreenManagerProxy::cleanupFullscreen):
(WebKit::VideoFullscreenManagerProxy::preparedToReturnToInline):
(WebKit::VideoFullscreenManagerProxy::preparedToExitFullscreen):

• UIProcess/ios/EditableImageController.mm:

(WebKit::EditableImageController::didCreateEditableImage):
(WebKit::EditableImageController::didDestroyEditableImage):
(WebKit::EditableImageController::associateWithAttachment):

12:54 PM Changeset in webkit [242377] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Fix crashes when NetworkResourceLoader/NetworkLoadChecker are destroyed during HTTPS upgrade check
​https://bugs.webkit.org/show_bug.cgi?id=195238
<rdar://problem/47598656>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-03-04
Reviewed by Chris Dumez.

• NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRequest):

12:39 PM Changeset in webkit [242376] by beidson@apple.com

• 2 edits in trunk/Source/WebKit

Correctly handle sandbox extensions when the same WKWebView loads multiple ​file:// URLs.
<rdar://problem/47820581> and ​https://bugs.webkit.org/show_bug.cgi?id=195291

Reviewed by Andy Estes.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::shouldReuseCommittedSandboxExtension): Only retain the previous sandbox extension if the file URL

we're currently loading is functionally equivalent to the previous one.

12:36 PM Changeset in webkit [242375] by Chris Dumez

• 10 edits in trunk/Source/WebKit

Drop legacy userAgentForURL injected bundle SPI
​https://bugs.webkit.org/show_bug.cgi?id=195222
<rdar://problem/46734147>

Reviewed by Darin Adler.

Drop legacy userAgentForURL injected bundle SPI. There are no longer any clients, and using
WebsitePolicies.customUserAgent is the way to go nowadays.

• WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:

(API::InjectedBundle::PageLoaderClient::willDestroyFrame):
(API::InjectedBundle::PageLoaderClient::userAgentForURL const): Deleted.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageLoaderClient.h:
• WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(setUpPageLoaderClient):
(userAgentForURL): Deleted.

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::userAgentForURL const): Deleted.

• WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userAgent const):

12:35 PM Changeset in webkit [242374] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: protocol error on first open
​https://bugs.webkit.org/show_bug.cgi?id=195059
<rdar://problem/48407871>

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.prototype.initializeTarget):
(WI.CanvasManager.prototype.static supportsRecordingAutoCapture):
(WI.CanvasManager.prototype.setRecordingAutoCaptureFrameCount):
If targets aren't available, wait until they are and then set the auto-capture frame count.

12:33 PM Changeset in webkit [242373] by sbarati@apple.com

• 2 edits
  1 add in trunk/PerformanceTests

Add a detailed summary page for JetStream 2
​https://bugs.webkit.org/show_bug.cgi?id=195014

Rubber-stamped by Darin Adler.

• JetStream2/JetStream.css:

(a:link, a:visited):

• JetStream2/in-depth.html: Added.

12:30 PM Changeset in webkit [242372] by youenn@apple.com

• 5 edits in trunk/Source/WebCore

Make sure to correctly notify of end of a ServiceWorkerJob when the context is stopped
​https://bugs.webkit.org/show_bug.cgi?id=195195

Reviewed by Chris Dumez.

Before the patch, we were notifying that some jobs were finished too aggressively at context stop time.
This was confusing the Network Process.
Only notify such jobs that have pending loads.
Improve the tracking of jobs doing registration resolution to ensure the Network Process gets notified
in case of a registration promise being resolved but the settling callback being not yet called while the context is stopped.

Covered by existing tests not crashing anymore, in particular imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting.https.html.

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::jobResolvedWithRegistration):
(WebCore::ServiceWorkerContainer::notifyRegistrationIsSettled):
(WebCore::ServiceWorkerContainer::stop):

• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::cancelPendingLoad):

• workers/service/ServiceWorkerJob.h:

(WebCore::ServiceWorkerJob::isLoading const):

12:26 PM Changeset in webkit [242371] by Chris Dumez

• 14 edits in trunk

Do not share WebProcesses between private and regular sessions
​https://bugs.webkit.org/show_bug.cgi?id=195189
<rdar://problem/48421064>

Reviewed by Alex Christensen.

Source/WebKit:

Do not share WebProcesses between private and regular sessions. There are some privacy concerns.
Also, some of the WebsiteDataStore informations are passed via WebProcessCreationParameters (e.g.
ApplicationCache path) and cannot be updated later.

There were 2 cases where this could happen and that are fixed in the patch:

• A process may be prewarmed with a given website data store and then later on used for a page associated with a different data store. We now prevent this. While this is not necessary for privacy reasons, it is still useful because our code currently does not support well uses different sessions inside a single WebProcess, as mentioned above.
• The client can force a WebsiteDataStore swap when responding to the decidePolicyForNavigationAction, via the WebsitePolicies. To address the issue, we now force a process swap whenever the client makes such a change.

As a result, WebProcessProxy::websiteDataStore() now makes sense and is always correct. It can
also only contains pages whose WebPageProxy::websiteDataStore() returns the same store.

• UIProcess/API/C/WKContext.cpp:

(WKContextWarmInitialProcess):

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _warmInitialProcess]):

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::ProvisionalPageProxy):
(WebKit::ProvisionalPageProxy::~ProvisionalPageProxy):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::notifyProcessPoolToPrewarm):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::swapToWebProcess):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::commitProvisionalPage):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::websiteDataStore):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::tryTakePrewarmedProcess):
(WebKit::WebProcessPool::prewarmProcess):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::pageBeginUsingWebsiteDataStore):
(WebKit::WebProcessPool::pageEndUsingWebsiteDataStore):
(WebKit::WebProcessPool::didReachGoodTimeToPrewarm):
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):
(WebKit::WebProcessPool::findReusableSuspendedPageProcess):

• UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToOneProcess):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):
(WebKit::WebProcessProxy::addExistingWebPage):
(WebKit::WebProcessProxy::removeWebPage):

• UIProcess/WebProcessProxy.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

12:23 PM Changeset in webkit [242370] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Toggling Timeline "Stop when page loads" to on should stop (immediately or soon) any active recording if already past the load event
​https://bugs.webkit.org/show_bug.cgi?id=195239

Reviewed by Joseph Pecoraro.

• UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._handleTimelinesAutoStopSettingChanged):

12:20 PM Changeset in webkit [242369] by Chris Dumez

• 5 edits in trunk/Source

[iOS] Improve our file picker
​https://bugs.webkit.org/show_bug.cgi?id=195284
<rdar://problem/45655856>

Reviewed by Tim Horton and Wenson Hsieh.

Source/WebCore:

Export UTIUtilities.h so that it can be used from WebKit2.

• WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Improve our file picker on iOS so that:

• Accepted file extensions specified in the HTML (e.g. <input type="file"> accept=".pdf">) are now properly reflected in the file picker. Previously, we only we only supported MIME types in the accept attribute that only Image / Video ones.
• If accepted types are specified in the HTML and not of them are Video or Image types, then bypass the UIDocumentMenuViewController and show the file picker directly (as if the user had tapped on "Browse..." on that menu). Other menu items such as "Take Photo or Video" and "Photo Library" do not make sense if the page only accepts PDF files for example.

Things that we should do but are not fixed in this patch:

• Stop using UIDocumentMenuViewController entirely since it was deprecated in favor of using UIDocumentPickerViewController directly.
• Add multiple selection support, which is supported both on the HTML side and in the UIDocumentPickerViewController API.

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(arrayContainsUTIThatConformsTo):
(-[WKFileUploadPanel dealloc]):
(-[WKFileUploadPanel presentWithParameters:resultListener:]):
(UTIsForMIMETypes):
(-[WKFileUploadPanel _mediaTypesForPickerSourceType:]):
(-[WKFileUploadPanel _cameraButtonLabelAllowingPhoto:allowingVideo:]):
(-[WKFileUploadPanel _showDocumentPickerMenu]):

11:58 AM Changeset in webkit [242368] by Conrad Shultz

• 3 edits in trunk/Source/WebCore/PAL

Improper use of PLATFORM(TVOS) in PAL
​https://bugs.webkit.org/show_bug.cgi?id=195215

Reviewed by Darin Adler.

There are a couple stray uses of PLATFORM(TVOS) in PAL. The correct usage is
PLATFORM(APPLETV).

• pal/spi/cocoa/NSKeyedArchiverSPI.h:
• pal/spi/cocoa/NSProgressSPI.h:

11:54 AM Changeset in webkit [242367] by achristensen@apple.com

• 4 edits in trunk/Source/WebKit

REGRESSION: ( r240978-r240985 ) [ iOS Release ] Layout Test imported/w3c/web-platform-tests/xhr/send-redirect-post-upload.htm is crashing
​https://bugs.webkit.org/show_bug.cgi?id=194523

Reviewed by Ryosuke Niwa.

Attempt to work around a CFNetwork bug in the timing of tearing down tasks with upload streams.
See rdar://problem/28233746.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::~NetworkDataTaskCocoa):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):

11:33 AM Changeset in webkit [242366] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

[ContentChangeObserver] Decouple mouseMoved event and the "is observing content change" status.
​https://bugs.webkit.org/show_bug.cgi?id=195286

Reviewed by Simon Fraser.

Now isObservingContentChanges returns true only when we are actively observing content change during timer firing and/or style recalculating.
This patch also renames a couple of functions to follow the didStart/didFinish pattern.

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::domTimerExecuteDidStart):
(WebCore::ContentChangeObserver::domTimerExecuteDidFinish):
(WebCore::ContentChangeObserver::styleRecalcDidStart):
(WebCore::ContentChangeObserver::styleRecalcDidFinish):
(WebCore::ContentChangeObserver::mouseMovedDidStart):
(WebCore::ContentChangeObserver::mouseMovedDidFinish):
(WebCore::ContentChangeObserver::setShouldObserveNextStyleRecalc):
(WebCore::ContentChangeObserver::StyleChangeScope::StyleChangeScope):
(WebCore::ContentChangeObserver::MouseMovedScope::MouseMovedScope):
(WebCore::ContentChangeObserver::MouseMovedScope::~MouseMovedScope):
(WebCore::ContentChangeObserver::StyleRecalcScope::StyleRecalcScope):
(WebCore::ContentChangeObserver::StyleRecalcScope::~StyleRecalcScope):
(WebCore::ContentChangeObserver::DOMTimerScope::DOMTimerScope):
(WebCore::ContentChangeObserver::DOMTimerScope::~DOMTimerScope):
(WebCore::ContentChangeObserver::startObservingDOMTimerExecute): Deleted.
(WebCore::ContentChangeObserver::stopObservingDOMTimerExecute): Deleted.
(WebCore::ContentChangeObserver::startObservingStyleRecalc): Deleted.
(WebCore::ContentChangeObserver::stopObservingStyleRecalc): Deleted.
(WebCore::ContentChangeObserver::startObservingMouseMoved): Deleted.
(WebCore::ContentChangeObserver::stopObservingMouseMoved): Deleted.
(WebCore::ContentChangeObserver::setShouldObserveStyleRecalc): Deleted.

• page/ios/ContentChangeObserver.h:

(WebCore::ContentChangeObserver::setShouldObserveDOMTimerScheduling):
(WebCore::ContentChangeObserver::isObservingDOMTimerScheduling const):
(WebCore::ContentChangeObserver::isObservingStyleRecalc const):
(WebCore::ContentChangeObserver::isObservingContentChanges const):
(WebCore::ContentChangeObserver::startObservingDOMTimerScheduling): Deleted.
(WebCore::ContentChangeObserver::stopObservingDOMTimerScheduling): Deleted.
(WebCore::ContentChangeObserver::shouldObserveStyleRecalc const): Deleted.

10:56 AM Changeset in webkit [242365] by ysuzuki@apple.com

• 18 edits in trunk/Source

[JSC] Offer @makeTypeError instead of exposing @TypeError
​https://bugs.webkit.org/show_bug.cgi?id=193858

Reviewed by Mark Lam.

Source/JavaScriptCore:

Instead of exposing @TypeError, we expose @makeTypeError function.
And we make TypeError and Error lazily-allocated objects in non JIT environment.
In JIT environment, only TypeError becomes lazily-allocated since WebAssembly errors
touch Error prototype anyway. But we can make them lazy in a subsequent patch.

• builtins/AsyncFromSyncIteratorPrototype.js:
• builtins/AsyncGeneratorPrototype.js:

(globalPrivate.asyncGeneratorEnqueue):

• builtins/BuiltinNames.h:
• builtins/PromiseOperations.js:

(globalPrivate.createResolvingFunctions.resolve):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::initializeErrorConstructor):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::errorPrototype const):
(JSC::JSGlobalObject::errorStructure const):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncMakeTypeError):

• runtime/JSGlobalObjectFunctions.h:

Source/WebCore:

Use @makeTypeError instead.

• Modules/mediastream/RTCPeerConnection.js:
• Modules/mediastream/RTCPeerConnectionInternals.js:
• Modules/streams/ReadableByteStreamInternals.js:

(readableByteStreamControllerClose):
(readableByteStreamControllerPullInto):

• Modules/streams/ReadableStream.js:

(cancel):
(pipeTo):

• Modules/streams/ReadableStreamBYOBReader.js:

(cancel):
(read):

• Modules/streams/ReadableStreamDefaultReader.js:

(cancel):
(read):

• Modules/streams/ReadableStreamInternals.js:

(readableStreamReaderGenericRelease):

• Modules/streams/WritableStream.js:

(abort):
(close):
(write):
(getter.closed):
(getter.ready):

10:06 AM Changeset in webkit [242364] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit

[CoordinatedGraphics] The compositing loop is still running even after exiting AC mode
​https://bugs.webkit.org/show_bug.cgi?id=195270

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-03-04
Reviewed by Don Olmstead.

Suspend the threaded compositor when the painting is paused or layer flush disabled, and resume it again when
painting is resumed and layer flush enabled.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::suspend): Increment the suspend counter and mark the scene as inactive if it was suspended.
(WebKit::ThreadedCompositor::resume): Decrement the suspend counter and mark the scene as active if it's now resumed.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::forceRepaint): Return early if layer tree state is frozen.
(WebKit::DrawingAreaCoordinatedGraphics::forceRepaintAsync): Ditto.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::setLayerFlushSchedulingEnabled): Call ThreadedCompositor::suspend()/resume().
(WebKit::LayerTreeHost::pauseRendering): Call ThreadedCompositor::suspend.
(WebKit::LayerTreeHost::resumeRendering): Call ThreadedCompositor::resume().

9:28 AM Changeset in webkit [242363] by bshafiei@apple.com

• 4 edits in branches/safari-607-branch/Source

Cherry-pick r242355. rdar://problem/48563894

[iOS] Fullscreen "stay in page" option breaks video playback
​https://bugs.webkit.org/show_bug.cgi?id=195277
<rdar://problem/48537317>

Reviewed by Eric Carlson.

Source/WebCore:

Add a LOG entry when playback is rejected due to media playback suspension.

• html/MediaElementSession.cpp: (WebCore::MediaElementSession::playbackPermitted const):

Source/WebKit:

Make sure we resume media playback when the user chooses "stay in page" from the deceptive
website warning dialog.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController _showPhishingAlert]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:25 AM Changeset in webkit [242362] by bshafiei@apple.com

• 4 edits in branches/safari-607.1.40.0-branch/Source

Cherry-pick r242355. rdar://problem/48563891

[iOS] Fullscreen "stay in page" option breaks video playback
​https://bugs.webkit.org/show_bug.cgi?id=195277
<rdar://problem/48537317>

Reviewed by Eric Carlson.

Source/WebCore:

Add a LOG entry when playback is rejected due to media playback suspension.

• html/MediaElementSession.cpp: (WebCore::MediaElementSession::playbackPermitted const):

Source/WebKit:

Make sure we resume media playback when the user chooses "stay in page" from the deceptive
website warning dialog.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController _showPhishingAlert]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:21 AM Changeset in webkit [242361] by bshafiei@apple.com

• 7 edits in branches/safari-607.1.40.0-branch/Source

Versioning.

8:58 AM Changeset in webkit [242360] by Darin Adler

• 15 edits in trunk

Prepare to improve handling of conversion of float to strings
​https://bugs.webkit.org/show_bug.cgi?id=195262

Reviewed by Daniel Bates.

Source/WTF:

• wtf/dtoa.cpp:

(WTF::truncateTrailingZeros): Renamed from
formatStringTruncatingTrailingZerosIfNeeded and removed the calls
to double_conversion::StringBuilder::Finalizer, since the caller
already does that.
(WTF::numberToFixedPrecisionString): Added an overload for float
and updated to use the new truncateTrailingZeros.
(WTF::numberToFixedWidthString): Added an overload for float.

• wtf/text/AtomicString.cpp:

(WTF::AtomicString::number): Added float overload. This is a
behavior change, but in all cases for the better. The old behavior
was to convert to double first and then do "shortest form"
conversion, and it's always better to just do that as float.

• wtf/text/AtomicString.h: Added float overload of AtomicString::number.

• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendFixedPrecisionNumber): Added float
overload.
(WTF::StringBuilder::appendShortestFormNumber): Renamed from
appendECMAScriptNumber and did the above.
(WTF::StringBuilder::appendFixedWidthNumber): Ditto.

• wtf/text/StringBuilder.h: Added overloads for float and

appendShortestFormNumber. The appendNumber and appendECMAScriptNumber
functions are now inlines in the header, since they are expressed
entirely in terms of the other functions.

• wtf/text/WTFString.cpp:

(WTF::String::numberToStringFixedPrecision): Added float overload.
Removed unnecessary explicit conversion to String.
(WTF::String::numberToStringShortest): Renamed from
numberToStringECMAScript and did the above.
(WTF::String::numberToStringFixedWidth): Ditto.

• wtf/text/WTFString.h: Added overloads for float and

numberToStringShortest. The number and numberToStringECMAScript
functions are now inlines in the header, since they are expressed
entirely in terms of the other functions.

LayoutTests:

• svg/dom/SVGAngle-expected.txt:
• svg/dom/SVGAngle.html:
• svg/dom/SVGLength-px-expected.txt:
• svg/dom/SVGLength-px-with-context-expected.txt:
• svg/dom/SVGLength-px-with-context.html:
• svg/dom/SVGLength-px.html:

Remove checks that depend on the precision and number of serialization.
The current tests depend on behavior that we'd like to change in the future and
some of them had already been updated since the behavior is different in different
web browsers. Tricky issue because of the mix of single and double precision in
the SVG engine and the JavaScript language, and straightforward to keep the tests
useful without this unnecessary dependency. Generally we check the units of the
result of valueAsString, and not the numeric result. Another idea would be to
check the numeric part of the result by converting it back to a number and
comparing it as a number rather than as a string.

8:57 AM Changeset in webkit [242359] by Simon Fraser

• 26 edits
  2 copies
  1 move in trunk/Source

Share more code between overflow and frame scrolling nodes, fixing overflow scrollbar display
​https://bugs.webkit.org/show_bug.cgi?id=195258

Reviewed by Antti Koivisto.

This patch moves management of scrollbar layers and scrollbar painters ("NSScrollerImp") down to
ScrollingStateScrollingNode to be shared between frame and overflow nodes, allowing for
scrolling thread updates of overflow scrollbars. It also moves some scrolling tree-side code
to ScrollingTreeScrollingNodeDelegateMac to be shared between the "tree" nodes for overflow and frames.

Layers for scrollbars are given to scrolling state nodes via setNodeLayers() now, and
RenderLayerCompositor::updateScrollingNodeLayers() is added to provide a bottleneck to call that.
At some point AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange() should be relieved
of the responsibility of pushing scrollbar layers (but the scrolling state tree needs to hold
references to GraphicsLayers before that becomes safe).

The actual fix that allows overflow scrollbars to show is the change in
AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange() that calls scrollableArea.*ScrollbarLayerDidChange()
for all ScrollableAreas. This ensures that the CALayer is pushed onto the NSScrollerImp.

Source/WebCore:

• SourcesCocoa.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::setNodeLayers):
(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):
(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setAllPropertiesChanged):
(WebCore::ScrollingStateFrameScrollingNode::setVerticalScrollbarLayer): Deleted.
(WebCore::ScrollingStateFrameScrollingNode::setHorizontalScrollbarLayer): Deleted.
(WebCore::ScrollingStateFrameScrollingNode::setScrollerImpsFromScrollbars): Deleted.

• page/scrolling/ScrollingStateFrameScrollingNode.h:
• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setAllPropertiesChanged):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarLayer):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarLayer):
(WebCore::ScrollingStateScrollingNode::setScrollerImpsFromScrollbars):

• page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::horizontalScrollbarLayer const):
(WebCore::ScrollingStateScrollingNode::verticalScrollbarLayer const):
(WebCore::ScrollingStateScrollingNode::verticalScrollerImp const):
(WebCore::ScrollingStateScrollingNode::horizontalScrollerImp const):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::setOrClearLatchedNode):
(WebCore::ScrollingTree::handleWheelEvent):

• page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: Renamed from Source/WebCore/page/scrolling/mac/ScrollingStateFrameScrollingNodeMac.mm.

(WebCore::ScrollingStateScrollingNode::setScrollerImpsFromScrollbars):

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeFrameScrollingNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeFrameScrollingNodeMac::repositionRelatedLayers):
(WebCore::ScrollingTreeFrameScrollingNodeMac::~ScrollingTreeFrameScrollingNodeMac): Deleted.
(WebCore::ScrollingTreeFrameScrollingNodeMac::releaseReferencesToScrollerImpsOnTheMainThread): Deleted.

• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.h:
• page/scrolling/mac/ScrollingTreeOverflowScrollingNodeMac.mm:

(WebCore::ScrollingTreeOverflowScrollingNodeMac::commitStateBeforeChildren):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::handleWheelEvent):
(WebCore::ScrollingTreeOverflowScrollingNodeMac::repositionRelatedLayers):

• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.h:
• page/scrolling/mac/ScrollingTreeScrollingNodeDelegateMac.mm:

(WebCore::ScrollingTreeScrollingNodeDelegateMac::~ScrollingTreeScrollingNodeDelegateMac):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateFromStateNode):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::handleWheelEvent):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::updateScrollbarPainters):
(WebCore::ScrollingTreeScrollingNodeDelegateMac::releaseReferencesToScrollerImpsOnTheMainThread):

• platform/ScrollbarThemeComposite.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didChangePlatformLayerForLayer):
(WebCore::RenderLayerCompositor::updateScrollingNodeLayers):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingRole):

• rendering/RenderLayerCompositor.h:

Source/WebKit:

• Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):

• SourcesCocoa.txt:
• UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

• UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode):

• UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp:

(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::commitStateBeforeChildren):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::repositionRelatedLayers):
(WebKit::ScrollingTreeFrameScrollingNodeRemoteMac::handleMouseEvent):

• UIProcess/RemoteLayerTree/mac/ScrollingTreeOverflowScrollingNodeRemoteMac.cpp: Copied from Source/WebKit/UIProcess/RemoteLayerTree/mac/ScrollingTreeFrameScrollingNodeRemoteMac.cpp.

(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::create):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::ScrollingTreeOverflowScrollingNodeRemoteMac):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::~ScrollingTreeOverflowScrollingNodeRemoteMac):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::commitStateBeforeChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::repositionRelatedLayers):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::handleWheelEvent):
(WebKit::ScrollingTreeOverflowScrollingNodeRemoteMac::handleMouseEvent):

• WebKit.xcodeproj/project.pbxproj:

8:57 AM Changeset in webkit [242358] by Truitt Savell

• 2 edits in trunk/LayoutTests

webkit.org/b/195210 resolve by r242308, unskipping tests.
​https://bugs.webkit.org/show_bug.cgi?id=195210

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

8:51 AM Changeset in webkit [242357] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Remove HEVC as a codec requiring hardware support.
​https://bugs.webkit.org/show_bug.cgi?id=194960
<rdar://problem/47741432>

Reviewed by Eric Carlson.

• page/cocoa/SettingsBaseCocoa.mm:

(WebCore::SettingsBase::defaultMediaContentTypesRequiringHardwareSupport):

8:47 AM Changeset in webkit [242356] by aestes@apple.com

• 13 edits
  7 copies
  4 adds
  1 delete in trunk/Source

[Apple Pay] Move WebPaymentCoordinatorProxy from Source/WebKit/UIProcess to Source/WebKit/Shared
​https://bugs.webkit.org/show_bug.cgi?id=195080
<rdar://problem/48421558>

Reviewed by Antti Koivisto.

Source/WebKit:

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources.make:
• Shared/ApplePay/WebPaymentCoordinatorProxy.cpp: Renamed from Source/WebKit/UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp.
• Shared/ApplePay/WebPaymentCoordinatorProxy.h: Renamed from Source/WebKit/UIProcess/ApplePay/WebPaymentCoordinatorProxy.h.
• Shared/ApplePay/WebPaymentCoordinatorProxy.messages.in: Renamed from Source/WebKit/UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in.
• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h: Renamed from Source/WebKit/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h.
• Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: Renamed from Source/WebKit/UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm.
• Shared/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Renamed from Source/WebKit/UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm.
• Shared/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm: Renamed from Source/WebKit/UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm.
• Shared/mac/WebHitTestResultData.mm:
• SourcesCocoa.txt:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeFrameScrollingNodeRemoteIOS.mm:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:
• WebKit.xcodeproj/project.pbxproj:

Source/WTF:

• wtf/FeatureDefines.h:

8:44 AM Changeset in webkit [242355] by jer.noble@apple.com

• 4 edits in trunk/Source

[iOS] Fullscreen "stay in page" option breaks video playback
​https://bugs.webkit.org/show_bug.cgi?id=195277
<rdar://problem/48537317>

Reviewed by Eric Carlson.

Source/WebCore:

Add a LOG entry when playback is rejected due to media playback suspension.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted const):

Source/WebKit:

Make sure we resume media playback when the user chooses "stay in page" from the deceptive
website warning dialog.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _showPhishingAlert]):

7:25 AM Changeset in webkit [242354] by Michael Catanzaro

• 10 edits
  1 add in trunk

[WPE] Enable web process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=195169

Reviewed by Daniel Bates.

.:

• Source/cmake/BubblewrapSandboxChecks.cmake: Added.
• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsWPE.cmake:

Source/WebKit:

• PlatformWPE.cmake:
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitialize):

Tools:

• wpe/install-dependencies:
• wpe/jhbuild.modules:

7:18 AM Changeset in webkit [242353] by Michael Catanzaro

• 2 edits in trunk/Source/WTF

URLHelpers should use unorm2_quickCheck before converting to NFC
​https://bugs.webkit.org/show_bug.cgi?id=194272

Reviewed by Darin Adler.

If the string is already in normalization form C, don't try to normalize it.

• wtf/URLHelpers.cpp:

(WTF::URLHelpers::toNormalizationFormC):

6:30 AM Changeset in webkit [242352] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebDriver

WebDriver: fix String not terminated with null caracter
​https://bugs.webkit.org/show_bug.cgi?id=195274

Patch by Karl Leplat <​karl.leplat_ext@softathome.com> on 2019-03-04
Reviewed by Carlos Garcia Campos.

This has been detected by an exception returned by the function
evaluateJavaScriptFunction with the message :
[native code]: JS ERROR SyntaxError: Unexpected keyword 'function'. Expected ')' to end a compound expression.
keyword 'function' has been initialized with a string that come from char array, not a null-terminated string.

• Session.cpp:

(WebDriver::Session::fullscreenWindow):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::elementClear):

6:23 AM Changeset in webkit [242351] by Adrian Perez de Castro

• 5 edits in trunk/Source/WebKit

[GTK][WPE] Wrong license header in WebKit{,WebExtension}Autocleanups.h
​https://bugs.webkit.org/show_bug.cgi?id=195245

Reviewed by Carlos Garcia Campos.

Changed license headers to contain the LGPL, which is the correct one for the GTK
and WPE ports. The change was agreed by the contributors to the files involved.

• UIProcess/API/gtk/WebKitAutocleanups.h:
• UIProcess/API/wpe/WebKitAutocleanups.h:
• WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionAutocleanups.h:
• WebProcess/InjectedBundle/API/wpe/WebKitWebExtensionAutocleanups.h:

5:24 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

4:03 AM Changeset in webkit [242350] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r242045.
​https://bugs.webkit.org/show_bug.cgi?id=195273

WE not ready to enable PSON yet (Requested by KaL on #webkit).

Reverted changeset:

"[GTK] Enable PSON"
​https://bugs.webkit.org/show_bug.cgi?id=194979
​https://trac.webkit.org/changeset/242045

2:34 AM Changeset in webkit [242349] by Carlos Garcia Campos

• 4 edits in trunk

[GLib] Returning G_TYPE_OBJECT from a constructor does not work
​https://bugs.webkit.org/show_bug.cgi?id=195206

Reviewed by Žan Doberšek.

Source/JavaScriptCore:

We are freeing the newly created object before returning from the constructor.

• API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::construct):

Tools:

Add a new test case.

• TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCClass):

2:32 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

2:30 AM Changeset in webkit [242348] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore/platform/gtk/po

Unreviewed. Update POTFILES.in after r239627.

• POTFILES.in:

2:28 AM Changeset in webkit [242347] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.24/Source/WebKit

Unreviewed build fix after r242163

This fixes WPE aftyer the backport for r242055 wrongly added a piece of code which is
needed only in trunk and depends on changes introduced by a patch that is not being
merged for 2.24.

• UIProcess/glib/WebProcessPoolGLib.cpp:

(WebKit::WebProcessPool::platformInitializeWebProcess): Remove unneeded code.

1:58 AM Changeset in webkit [242346] by Carlos Garcia Campos

• 15 edits
  2 moves
  3 adds
  6 deletes in trunk/Source/WebKit

[CoordinatedGraphics] Unify DrawingArea classes
​https://bugs.webkit.org/show_bug.cgi?id=195167

Reviewed by Žan Doberšek.

Add DrawingAreaProxyCoordinatedGraphics and DrawingAreaCoordinatedGraphics.

• PlatformGTK.cmake:
• PlatformWPE.cmake:
• PlatformWin.cmake:
• Shared/DrawingAreaInfo.h:
• SourcesGTK.txt:
• SourcesWPE.txt:
• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):
(WebKit::PageClientImpl::viewSize):

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):
(webkitWebViewBaseUnrealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseSizeAllocate):
(webkitWebViewBaseDidRelaunchWebProcess):
(webkitWebViewBasePageClosed):

• UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

• UIProcess/AcceleratedDrawingAreaProxy.cpp: Removed.
• UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp: Added.

(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingAreaProxyCoordinatedGraphics):
(WebKit::DrawingAreaProxyCoordinatedGraphics::~DrawingAreaProxyCoordinatedGraphics):
(WebKit::DrawingAreaProxyCoordinatedGraphics::paint):
(WebKit::DrawingAreaProxyCoordinatedGraphics::sizeDidChange):
(WebKit::DrawingAreaProxyCoordinatedGraphics::deviceScaleFactorDidChange):
(WebKit::DrawingAreaProxyCoordinatedGraphics::waitForBackingStoreUpdateOnNextPaint):
(WebKit::DrawingAreaProxyCoordinatedGraphics::setBackingStoreIsDiscardable):
(WebKit::DrawingAreaProxyCoordinatedGraphics::update):
(WebKit::DrawingAreaProxyCoordinatedGraphics::didUpdateBackingStoreState):
(WebKit::DrawingAreaProxyCoordinatedGraphics::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyCoordinatedGraphics::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyCoordinatedGraphics::updateAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyCoordinatedGraphics::incorporateUpdate):
(WebKit::DrawingAreaProxyCoordinatedGraphics::alwaysUseCompositing const):
(WebKit::DrawingAreaProxyCoordinatedGraphics::backingStoreStateDidChange):
(WebKit::DrawingAreaProxyCoordinatedGraphics::sendUpdateBackingStoreState):
(WebKit::DrawingAreaProxyCoordinatedGraphics::waitForAndDispatchDidUpdateBackingStoreState):
(WebKit::DrawingAreaProxyCoordinatedGraphics::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyCoordinatedGraphics::discardBackingStore):
(WebKit::DrawingAreaProxyCoordinatedGraphics::setNativeSurfaceHandleForCompositing):
(WebKit::DrawingAreaProxyCoordinatedGraphics::destroyNativeSurfaceHandleForCompositing):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::DrawingMonitor):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::~DrawingMonitor):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::webViewDrawCallback):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::start):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::stop):
(WebKit::DrawingAreaProxyCoordinatedGraphics::DrawingMonitor::didDraw):
(WebKit::DrawingAreaProxyCoordinatedGraphics::dispatchAfterEnsuringDrawing):

• UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.h: Renamed from Source/WebKit/UIProcess/AcceleratedDrawingAreaProxy.h.
• UIProcess/DrawingAreaProxyImpl.cpp: Removed.
• UIProcess/DrawingAreaProxyImpl.h: Removed.
• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::update):

• UIProcess/win/PageClientImpl.cpp:

(WebKit::PageClientImpl::createDrawingAreaProxy):

• UIProcess/win/WebView.cpp:

(WebKit::WebView::paint):

• WebProcess/WebPage/AcceleratedDrawingArea.cpp: Removed.
• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp: Added.

(WebKit::DrawingAreaCoordinatedGraphics::DrawingAreaCoordinatedGraphics):
(WebKit::DrawingAreaCoordinatedGraphics::~DrawingAreaCoordinatedGraphics):
(WebKit::DrawingAreaCoordinatedGraphics::setNeedsDisplay):
(WebKit::DrawingAreaCoordinatedGraphics::setNeedsDisplayInRect):
(WebKit::DrawingAreaCoordinatedGraphics::scroll):
(WebKit::DrawingAreaCoordinatedGraphics::forceRepaint):
(WebKit::DrawingAreaCoordinatedGraphics::forceRepaintAsync):
(WebKit::DrawingAreaCoordinatedGraphics::setLayerTreeStateIsFrozen):
(WebKit::DrawingAreaCoordinatedGraphics::updatePreferences):
(WebKit::DrawingAreaCoordinatedGraphics::mainFrameContentSizeChanged):
(WebKit::DrawingAreaCoordinatedGraphics::deviceOrPageScaleFactorChanged):
(WebKit::DrawingAreaCoordinatedGraphics::didChangeViewportAttributes):
(WebKit::DrawingAreaCoordinatedGraphics::graphicsLayerFactory):
(WebKit::DrawingAreaCoordinatedGraphics::setRootCompositingLayer):
(WebKit::DrawingAreaCoordinatedGraphics::scheduleCompositingLayerFlush):
(WebKit::DrawingAreaCoordinatedGraphics::layerHostDidFlushLayers):
(WebKit::DrawingAreaCoordinatedGraphics::createDisplayRefreshMonitor):
(WebKit::DrawingAreaCoordinatedGraphics::setNativeSurfaceHandleForCompositing):
(WebKit::DrawingAreaCoordinatedGraphics::destroyNativeSurfaceHandleForCompositing):
(WebKit::DrawingAreaCoordinatedGraphics::activityStateDidChange):
(WebKit::DrawingAreaCoordinatedGraphics::attachViewOverlayGraphicsLayer):
(WebKit::DrawingAreaCoordinatedGraphics::updateBackingStoreState):
(WebKit::DrawingAreaCoordinatedGraphics::didUpdate):
(WebKit::DrawingAreaCoordinatedGraphics::sendDidUpdateBackingStoreState):
(WebKit::DrawingAreaCoordinatedGraphics::exitAcceleratedCompositingModeSoon):
(WebKit::DrawingAreaCoordinatedGraphics::exitAcceleratedCompositingModeNow):
(WebKit::DrawingAreaCoordinatedGraphics::discardPreviousLayerTreeHost):
(WebKit::DrawingAreaCoordinatedGraphics::suspendPainting):
(WebKit::DrawingAreaCoordinatedGraphics::resumePainting):
(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaCoordinatedGraphics::exitAcceleratedCompositingMode):
(WebKit::DrawingAreaCoordinatedGraphics::scheduleDisplay):
(WebKit::DrawingAreaCoordinatedGraphics::displayTimerFired):
(WebKit::DrawingAreaCoordinatedGraphics::display):
(WebKit::shouldPaintBoundsRect):

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.h: Renamed from Source/WebKit/WebProcess/WebPage/AcceleratedDrawingArea.h.
• WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

• WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::layerFlushThrottlingIsActive const):

• WebProcess/WebPage/DrawingAreaImpl.cpp: Removed.
• WebProcess/WebPage/DrawingAreaImpl.h: Removed.

1:21 AM Changeset in webkit [242345] by Adrian Perez de Castro

• 2 edits in releases/WebKitGTK/webkit-2.24/Tools

Merged r242344 - [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
​https://bugs.webkit.org/show_bug.cgi?id=194898

Reviewed by Žan Doberšek.

• wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on

a GCC extension that permits arithmetic on void* pointer. Inline
the macro until this issue is fixed upstream.

12:32 AM Changeset in webkit [242344] by cturner@igalia.com

• 2 edits in trunk/Tools

[WPE] Inline wl_array_for_each to workaround C++ compatibility issue
​https://bugs.webkit.org/show_bug.cgi?id=194898

Reviewed by Žan Doberšek.

• wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on

a GCC extension that permits arithmetic on void* pointer. Inline
the macro until this issue is fixed upstream.

12:20 AM Changeset in webkit [242343] by Claudio Saavedra

• 2 edits in trunk/LayoutTests

Fix typo in previous gardening commit

Unreviewed.

• platform/wpe/TestExpectations:

12:18 AM Changeset in webkit [242342] by Claudio Saavedra

• 2 edits in trunk/LayoutTests

[WPE][EME] Mark two flaky EME tests

Unreviewed gardening.

• platform/wpe/TestExpectations:

12:07 AM Changeset in webkit [242341] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Fix the build.

• dom/Document.h:

Mar 3, 2019:

10:05 PM Changeset in webkit [242340] by Alan Bujtas

• 16 edits in trunk/Source

[ContentChangeObserver] Content observation should be limited to the current document.
​https://bugs.webkit.org/show_bug.cgi?id=195256
<rdar://problem/48544402>

Source/WebCore:

Move ContentChangeObserver from Page to Document.
It limits content observation to the target node's owner document.

Reviewed by Simon Fraser.

• dom/Document.cpp:

(WebCore::m_contentChangeObserver):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::willDetachPage):
(WebCore::Document::platformSuspendOrStopActiveDOMObjects):
(WebCore::m_undoManager): Deleted.

• dom/Document.h:

(WebCore::Document::contentChangeObserver):

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install):
(WebCore::DOMTimer::removeById):
(WebCore::DOMTimer::fired):

• page/Frame.cpp:

(WebCore::Frame::willDetachPage):

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::pointerLockController const):
(WebCore::Page::contentChangeObserver): Deleted.

• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::ContentChangeObserver):
(WebCore::ContentChangeObserver::didInstallDOMTimer):
(WebCore::ContentChangeObserver::stopObservingDOMTimerExecute):
(WebCore::ContentChangeObserver::stopObservingStyleRecalc):
(WebCore::ContentChangeObserver::clearTimersAndReportContentChange):
(WebCore::ContentChangeObserver::startObservingMouseMoved):
(WebCore::ContentChangeObserver::hasDeterminateState const):
(WebCore::ContentChangeObserver::adjustObservedState):
(WebCore::ContentChangeObserver::notifyContentChangeIfNeeded):
(WebCore::ContentChangeObserver::StyleChangeScope::StyleChangeScope):
(WebCore::ContentChangeObserver::StyleChangeScope::~StyleChangeScope):
(WebCore::ContentChangeObserver::MouseMovedScope::MouseMovedScope):
(WebCore::ContentChangeObserver::MouseMovedScope::~MouseMovedScope):
(WebCore::ContentChangeObserver::StyleRecalcScope::StyleRecalcScope):
(WebCore::ContentChangeObserver::StyleRecalcScope::~StyleRecalcScope):
(WebCore::ContentChangeObserver::DOMTimerScope::DOMTimerScope):
(WebCore::ContentChangeObserver::DOMTimerScope::~DOMTimerScope):
(WebCore::hasPendingStyleRecalc): Deleted.

• page/ios/ContentChangeObserver.h:
• page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::mouseMoved):

• rendering/updating/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):

Source/WebKit:

Reviewed by Simon Fraser.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completePendingSyntheticClickForContentChangeObserver):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::handleTap):
(WebKit::WebPage::handleTwoFingerTapAtPoint):
(WebKit::WebPage::commitPotentialTap):

Source/WebKitLegacy/ios:

Reviewed by Simon Fraser.

• WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::observedContentChange):

9:12 PM Changeset in webkit [242339] by timothy_horton@apple.com

• 675 edits in trunk

Rid the world of WK_API_ENABLED
​https://bugs.webkit.org/show_bug.cgi?id=195263

Reviewed by Dan Bernstein.

List of changed files elided because it's useless.

9:09 PM Changeset in webkit [242338] by Ross Kirsling

• 2 edits in trunk/Tools

Unreviewed follow-up to r242292.

By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.

• TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:

(TestWebKitAPI::testStrip): Renamed from strip.
(TestWebKitAPI::TEST):

8:47 PM Changeset in webkit [242337] by bshafiei@apple.com

• 2 edits in tags/Safari-608.1.7.2/Source/WebKit

Cherry-pick r242233. rdar://problem/48139481

Disable Web Animations in Safari Technology Preview
​https://bugs.webkit.org/show_bug.cgi?id=194748
<rdar://problem/48139481>

Patch by Antoine Quint <Antoine Quint> on 2019-02-28
Reviewed by Dean Jackson.

The test runners already opt into that feature explicitly, so all that is needed is to turn
the default setting value to false.

• Shared/WebPreferences.yaml:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@242233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:38 PM Changeset in webkit [242336] by jiewen_tan@apple.com

• 6 edits
  1 add in trunk/Source/WebKit

Add a WebViewDidMoveToWindowObserver for WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=195223
<rdar://problem/48520161>

Reviewed by Darin Adler.

The load optimizer would only allow itself to optimize loads whenever the web view
who owns the page is (visible && focused), otherwises it will wait until the web view
becomes (visible && focused). Therefore, we need a way to notify the load optimizer
changes of statuses.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView didMoveToWindow]):

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::viewDidMoveToWindow):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::addWebViewDidMoveToWindowObserver):
(WebKit::WebPageProxy::removeWebViewDidMoveToWindowObserver):
(WebKit::WebPageProxy::webViewDidMoveToWindow):

• UIProcess/WebPageProxy.h:
• UIProcess/WebViewDidMoveToWindowObserver.h: Added.
• WebKit.xcodeproj/project.pbxproj:

8:37 PM Changeset in webkit [242335] by bshafiei@apple.com

• 7 edits in tags/Safari-608.1.7.2/Source

Versioning.

8:32 PM Changeset in webkit [242334] by bshafiei@apple.com

• 1 copy in tags/Safari-608.1.7.2

New tag.

4:36 PM Changeset in webkit [242333] by Simon Fraser

• 45 edits in trunk

Share more code for updating the state of frame scrolling nodes
​https://bugs.webkit.org/show_bug.cgi?id=195254

Reviewed by Antti Koivisto.
Source/WebCore:

Responsibility for updating state on ScrollingStateFrameScrolling nodes was split between
AsyncScrollingCoordinator::frameViewLayoutUpdated(), which is called post-layout, and
RenderLayerCompositor. This patch gives that responsibility entirely to RenderLayerCompositor,
ensuring that we update frame scrolling nodes at the same time as the rest of the scrolling
state tree.

We also share code between updating ScrollingStateFrameScrollingNodes and
ScrollingStateOverflowScrollingNodews, since both can be updated from a ScrollableArea.
Some minor cleanup of ScrollableArea is doing to help. For the first time, we're pushing
ScrollableAreaParameters for overflow scrolling nodes, allowing rubber-banding to work
on macOS.

• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::setRectRelativeToParentNode):
(WebCore::AsyncScrollingCoordinator::setFrameScrollingNodeState):
(WebCore::AsyncScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):
(WebCore::AsyncScrollingCoordinator::setViewportConstraintedNodeConstraints):
(WebCore::AsyncScrollingCoordinator::setScrollingNodeGeometry): Deleted.
(WebCore::AsyncScrollingCoordinator::setViewportConstraintedNodeGeometry): Deleted.

• page/scrolling/AsyncScrollingCoordinator.h:
• page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::setRectRelativeToParentNode):
(WebCore::ScrollingCoordinator::setScrollingNodeScrollableAreaGeometry):
(WebCore::ScrollingCoordinator::setFrameScrollingNodeState):
(WebCore::ScrollingCoordinator::setViewportConstraintedNodeConstraints):
(WebCore::ScrollingCoordinator::setScrollingNodeGeometry): Deleted.
(WebCore::ScrollingCoordinator::setViewportConstraintedNodeGeometry): Deleted.

• platform/ScrollView.h:

(WebCore::ScrollView::horizontalScrollbarMode const): Deleted.
(WebCore::ScrollView::verticalScrollbarMode const): Deleted.

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::reachableTotalContentsSize const):

• platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalScrollbarMode const):
(WebCore::ScrollableArea::verticalScrollbarMode const):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::overhangAmount const):
(WebCore::RenderLayer::reachableTotalContentsSize const):
(WebCore::RenderLayer::scrollableContentsSize const): Deleted.

• rendering/RenderLayer.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::updateScrollingNodeForViewportConstrainedRole):
(WebCore::RenderLayerCompositor::rootParentRelativeScrollableRect const):
(WebCore::RenderLayerCompositor::parentRelativeScrollableRect const):
(WebCore::RenderLayerCompositor::updateScrollingNodeForScrollingRole):
(WebCore::RenderLayerCompositor::updateScrollingNodeForFrameHostingRole):
(WebCore::RenderLayerCompositor::computeFrameScrollingGeometry const): Deleted.
(WebCore::RenderLayerCompositor::computeFrameHostingGeometry const): Deleted.
(WebCore::RenderLayerCompositor::computeOverflowScrollingGeometry const): Deleted.

• rendering/RenderLayerCompositor.h:

LayoutTests:

New baselines. Overflow nodes get some state from ScrollableAreaParameters now, and
frame nodes get the current scroll position (which is good, since they already have
the new layout viewport).

• fast/scrolling/ios/change-scrollability-on-content-resize-expected.txt:
• fast/scrolling/ios/change-scrollability-on-content-resize-nested-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
• platform/ios-wk2/scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
• scrollingcoordinator/scrolling-tree/gain-scrolling-node-parent-expected.txt:
• scrollingcoordinator/scrolling-tree/lose-scrolling-node-parent-expected.txt:
• scrollingcoordinator/scrolling-tree/overflow-in-fixed-expected.txt:
• scrollingcoordinator/scrolling-tree/remove-scrolling-role-expected.txt:
• scrollingcoordinator/scrolling-tree/reparent-across-compositing-layers-expected.txt:
• scrollingcoordinator/scrolling-tree/reparent-with-layer-removal-expected.txt:
• tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
• tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
• tiled-drawing/scrolling/fixed/four-bars.html:
• tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
• tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
• tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
• tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:

2:16 PM Changeset in webkit [242332] by aestes@apple.com

• 13 edits in trunk/Source/WebKit

[Apple Pay] Untangle WebPageProxy and WebPaymentCoordinatorProxy
​https://bugs.webkit.org/show_bug.cgi?id=195219
<rdar://problem/48518082>

Reviewed by Darin Adler.

Rather than having WebPaymentCoordinatorProxy know about WebPageProxy, give
WebPaymentCoordinatorProxy a client interface that WebPageProxy conforms to.

In a follow-on patch, WebPaymentCoordinatorProxy will have a non-WebPageProxy client.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy): Replaced use of
m_webPageProxy with m_client.
(WebKit::WebPaymentCoordinatorProxy::~WebPaymentCoordinatorProxy): Ditto.
(WebKit::WebPaymentCoordinatorProxy::messageSenderConnection const): Implemented
IPC::MessageSender via m_client.
(WebKit::WebPaymentCoordinatorProxy::messageSenderDestinationID const): Ditto.
(WebKit::WebPaymentCoordinatorProxy::canMakePaymentsWithActiveCard): Replaced use of
m_webPageProxy with m_client.
(WebKit::WebPaymentCoordinatorProxy::openPaymentSetup): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didCancelPaymentSession): Called our own
MessageSender::send rather than going through m_webPageProxy.
(WebKit::WebPaymentCoordinatorProxy::validateMerchant): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didAuthorizePayment): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingMethod): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingContact): Ditto.
(WebKit::WebPaymentCoordinatorProxy::didSelectPaymentMethod): Ditto.

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h: Defined the Client abstract class and

changed m_webPageProxy to m_client.

• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCanMakePaymentsWithActiveCard): Replaced use of
m_webPageProxy with m_client.
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Renamed from toPKPaymentRequest.
(WebKit::toPKPaymentRequest): Renamed to WebPaymentCoordinatorProxy::platformPaymentRequest.

• UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Replaced use of m_webPageProxy
with m_client.

• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI): Ditto.

• UIProcess/AuxiliaryProcessProxy.h:

(WebKit::AuxiliaryProcessProxy::messageReceiverMap): Added.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::paymentCoordinatorConnection): Implemented WebPaymentCoordinatorProxy::Client.
(WebKit::WebPageProxy::paymentCoordinatorMessageReceiver): Ditto.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationBundleIdentifier): Ditto.
(WebKit::WebPageProxy::paymentCoordinatorSourceApplicationSecondaryIdentifier): Ditto.
(WebKit::WebPageProxy::paymentCoordinatorDestinationID): Ditto.

• UIProcess/WebPageProxy.h: Made WebPageProxy derive from WebPaymentCoordinatorProxy::Client.
• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::paymentCoordinatorPresentingViewController): Implemented WebPaymentCoordinatorProxy::Client.
(WebKit::WebPageProxy::paymentCoordinatorCTDataConnectionServiceType): Ditto.

• UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::paymentCoordinatorPresentingWindow): Ditto.

• WebKit.xcodeproj/project.pbxproj:

2:08 PM Changeset in webkit [242331] by Diego Pino Garcia

• 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=195261

Unreviewed test gardening.

• platform/gtk/TestExpectations:

12:43 PM Changeset in webkit [242330] by Darin Adler

• 23 edits
  2 deletes in trunk

Retire legacy dtoa function and DecimalNumber class
​https://bugs.webkit.org/show_bug.cgi?id=195253

Reviewed by Daniel Bates.

LayoutTests/imported/w3c:

• web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-iteration-composite-operation-expected.txt:

Rebaseline still-failing part of this test that dumps super-small numbers that are formatted
differently by the new code (exponential style).

Source/JavaScriptCore:

• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential): Removed dependency on NumberToStringBufferLength,
using NumberToStringBuffer instead. Also tweaked style of implementation a bit.

Source/WebCore:

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::formatNumberValue const): Use makeString instead
of DecimalNumber. Also changed return type to String and use StringView and
removed special handling of literals.
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText const): Removed an
unnecessary use of StringBuilder.

• css/CSSPrimitiveValue.h: Updated for changes to formatNumberValue.

Source/WTF:

• WTF.xcodeproj/project.pbxproj: Removed DecimalNumber.cpp/h.
• wtf/CMakeLists.txt: Ditto.

• wtf/DecimalNumber.cpp: Removed.
• wtf/DecimalNumber.h: Removed.

• wtf/JSONValues.cpp:

(WTF::JSONImpl::Value::writeJSON const): Use
StringBuilder::appendECMAScriptNumber instead of custom logic
using the DecimalNumber class.

• wtf/dtoa.cpp:

(WTF::storeInc): Deleted.
(WTF::BigInt): Deleted.
(WTF::multadd): Deleted.
(WTF::hi0bits): Deleted.
(WTF::lo0bits): Deleted.
(WTF::i2b): Deleted.
(WTF::mult): Deleted.
(WTF::P5Node::P5Node): Deleted.
(WTF::pow5mult): Deleted.
(WTF::lshift): Deleted.
(WTF::cmp): Deleted.
(WTF::diff): Deleted.
(WTF::d2b): Deleted.
(WTF::quorem): Deleted.
(WTF::dtoa): Deleted.

• wtf/dtoa.h: Removed DtoaBuffer, dtoa, and NumberToStringBufferLength.

LayoutTests:

• fast/css/large-value-csstext-expected.txt:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles-expected.txt:
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles.html:

Updated expected value to expect exponential syntax for super-small numbers that are formatted
differently by the new code.

• platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
• platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:

Rebaseline still-failing parts of these tests that dump super-small numbers that are formatted
differently by the new code. Still probably needs to be done for 4 other platforms.

11:11 AM Changeset in webkit [242329] by Michael Catanzaro

• 1 edit
  1 delete in trunk/Tools

Unreviewed, remove accidentally-committed URLHelpers.cpp test

This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
and bug #194272 for details.

• TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.

9:51 AM Changeset in webkit [242328] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[SOUP] Cleanups in SoupNetworkSession
​https://bugs.webkit.org/show_bug.cgi?id=195247

Reviewed by Daniel Bates.

This renames clientCertificates to allowedCertificates, since they are not client
certificates at all, but server certificates. It also adds a using statement to avoid
repeating the long type of the map, and avoids an unnecessary copy.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::allowedCertificates):
(WebCore::SoupNetworkSession::checkTLSErrors):
(WebCore::SoupNetworkSession::allowSpecificHTTPSCertificateForHost):
(WebCore::clientCertificates): Deleted.

8:45 AM Changeset in webkit [242327] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

-Wformat error in SharedBuffer::tryCreateArrayBuffer
​https://bugs.webkit.org/show_bug.cgi?id=195004

Reviewed by Darin Adler.

Seems C++ has no format specifier appropriate for printing the result of sizeof. We should
just not try to print it. Anyway, that's easy in this case, because sizeof(char) is
guaranteed to be 1. This code was an attempt to be pedantic to account for mythical systems
with char larger than one byte, but perhaps it didn't realize sizeof always returns
multiples of char and so sizeof(char) is always one even on such mythical systems.

Note the sizeof(char) use two lines up is left since it's not clear that switching it to 1
would actually be more readable.

• platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::tryCreateArrayBuffer const):

4:30 AM Changeset in webkit [242326] by Adrian Perez de Castro

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.24/Source/WebKit

[WPE] Public API headers are missing autocleanup definitions
​https://bugs.webkit.org/show_bug.cgi?id=195211

Reviewed by Philippe Normand.

• PlatformWPE.cmake: List new API headers as installable.
• UIProcess/API/wpe/WebKitAutocleanups.h: Added. This is a copy of the header from the GTK

port, adapted to fit the WPE port.

• UIProcess/API/wpe/webkit.h: Add inclusion of WebKitAutocleanups.h
• WebProcess/InjectedBundle/API/wpe/WebKitWebExtensionAutocleanups.h: Added. Also adapted

from the equivalent header of the GTK port.

• WebProcess/InjectedBundle/API/wpe/webkit-web-extension.h: Add inclusion of

WebKitWebExtensionAutocleanups.h

2:35 AM Changeset in webkit [242325] by timothy_horton@apple.com

• 46 edits
  4 deletes in trunk

Remove some more unused 32-bit code
​https://bugs.webkit.org/show_bug.cgi?id=195255

Reviewed by Darin Adler.

Source/WebCore:

• platform/gamepad/cocoa/GameControllerGamepad.h:
• platform/gamepad/cocoa/GameControllerGamepad.mm:
• platform/gamepad/cocoa/GameControllerGamepadProvider.h:
• platform/gamepad/cocoa/GameControllerGamepadProvider.mm:
• platform/graphics/cocoa/FontCascadeCocoa.mm:
• platform/mac/PlatformEventFactoryMac.mm:

(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::servicesRolloverButtonCell const):
(WebCore::RenderThemeMac::paintImageControlsButton):
(WebCore::RenderThemeMac::imageControlsButtonSize const):
(WebCore::RenderThemeMac::imageControlsButtonPositionOffset const):

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/PlatformMac.cmake:
• pal/spi/cocoa/IOKitSPI.h:
• pal/spi/mac/QuickDrawSPI.h: Removed.

Source/WebKit:

• Platform/Module.cpp:

(WebKit::Module::Module):

• Platform/Module.h:
• Platform/cf/ModuleCF.cpp:

(WebKit::Module::unload):
(WebKit::Module::bundleResourceMap): Deleted.

• PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeShim):
(WebKit::PluginProcess::platformInitializeProcess):
(WebKit::shouldCallRealDebugger): Deleted.
(WebKit::isWindowActive): Deleted.
(WebKit::getCurrentEventButtonState): Deleted.
(WebKit::carbonWindowShown): Deleted.
(WebKit::carbonWindowHidden): Deleted.
(WebKit::openCFURLRef): Deleted.
(WebKit::isMallocTinyMemoryTag): Deleted.
(WebKit::shouldMapMemoryExecutable): Deleted.

• PluginProcess/mac/PluginProcessShim.h:
• PluginProcess/mac/PluginProcessShim.mm:

(WebKit::shimDebugger): Deleted.
(WebKit::shimGetCurrentEventButtonState): Deleted.
(WebKit::shimIsWindowActive): Deleted.
(WebKit::shimModalDialog): Deleted.
(WebKit::shimAlert): Deleted.
(WebKit::shimShowWindow): Deleted.
(WebKit::shimHideWindow): Deleted.
(WebKit::shimLSOpenCFURLRef): Deleted.
(WebKit::shimMachVMMap): Deleted.

• Shared/API/Cocoa/WKFoundation.h:
• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:

(WebKit::XPCServiceMain):

• Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::tryLoad):

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginArchitecture):
(WebKit::NetscapePluginModule::determineQuirks):

• Shared/Plugins/PluginQuirks.h:
• Shared/cf/ArgumentCodersCF.cpp:

(IPC::sizeForNumberType):

• Shared/mac/WebEventFactory.mm:

(WebKit::mouseButtonForEvent):
(WebKit::globalPointForEvent):
(WebKit::pointForEvent):
(WebKit::WebEventFactory::createWebMouseEvent):

• UIProcess/API/C/mac/WKPagePrivateMac.h:
• UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageLoadFileReturningNavigation):

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pressureChangeWithEvent):

• UIProcess/Gamepad/cocoa/UIGamepadProviderCocoa.mm:

(WebKit::UIGamepadProvider::platformSetDefaultGamepadProvider):

• UIProcess/mac/ServicesController.mm:

(WebKit::ServicesController::ServicesController):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):

• WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin):

• WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::isWindowActive const): Deleted.

• WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::setDrawingModel):
(WebKit::NetscapePlugin::setEventModel):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::windowFocusChanged):
(WebKit::NetscapePlugin::windowAndViewFramesChanged):
(WebKit::NetscapePlugin::sendComplexTextInput):
(): Deleted.
(WebKit::windowMap): Deleted.
(WebKit::NetscapePlugin::netscapePluginFromWindow): Deleted.
(WebKit::NetscapePlugin::windowRef const): Deleted.
(WebKit::NetscapePlugin::updateFakeWindowBounds): Deleted.
(WebKit::NetscapePlugin::buttonState): Deleted.
(WebKit::initializeEventRecord): Deleted.
(WebKit::anyMouseButtonIsDown): Deleted.
(WebKit::rightMouseButtonIsDown): Deleted.
(WebKit::modifiersForEvent): Deleted.
(WebKit::convertStringToKeyCodes): Deleted.
(WebKit::scriptCodeFromCurrentKeyboardInputSource): Deleted.
(WebKit::NetscapePlugin::nullEventTimerFired): Deleted.

Source/WebKitLegacy/mac:

• Plugins/WebNetscapePluginEventHandler.mm:

(WebNetscapePluginEventHandler::create):

• Plugins/WebNetscapePluginView.h:
• Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebNetscapePluginView restorePortState:]):
(-[WebNetscapePluginView sendEvent:isDrawRect:]):
(-[WebNetscapePluginView isNewWindowEqualToOldWindow]):
(-[WebNetscapePluginView updateAndSetWindow]):
(-[WebNetscapePluginView setWindowIfNecessary]):
(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView fini]):
(-[WebNetscapePluginView drawRect:]):
(-[WebNetscapePluginView invalidateRegion:]):
(-[WebNetscapePluginView getVariable:value:]):
(-[WebNetscapePluginView setVariable:value:]):
(isDrawingModelQuickDraw): Deleted.
(-[WebNetscapePluginView fixWindowPort]): Deleted.
(getQDPixelFormatForBitmapContext): Deleted.
(-[WebNetscapePluginView tellQuickTimeToChill]): Deleted.
(-[WebNetscapePluginView _printedPluginBitmap]): Deleted.

• WebView/WebDelegateImplementationCaching.mm:

Tools:

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
• DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
• DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_New):
(NPP_HandleEvent):
(handleEventCarbon): Deleted.

LayoutTests:

• platform/mac/plugins/supports-carbon-event-model-expected.txt: Removed.
• platform/mac/plugins/supports-carbon-event-model.html: Removed.