Timeline

Apr 17, 2019:

11:41 PM Changeset in webkit [244421] by graouts@webkit.org

• 9 edits
  1 add in trunk

[Pointer Events WPT] Unskip imported/w3c/web-platform-tests/pointerevents/pointerevent_on_event_handlers.html
​https://bugs.webkit.org/show_bug.cgi?id=197006

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

• web-platform-tests/pointerevents/pointerevent_on_event_handlers-expected.txt: Added.

Source/WebCore:

Add support for on* HTML attributes and JS properties for pointer events.

• dom/GlobalEventHandlers.idl:
• html/HTMLAttributeNames.in:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap):

LayoutTests:

• js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/mac/TestExpectations:

11:39 PM Changeset in webkit [244420] by Fujii Hironori

• 2 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port

Following tests expected to fail but passed constantly.

• css3/masking/clip-path-inset-corners.html
• fast/box-shadow/box-shadow-with-zero-radius.html
• storage/indexeddb/database-odd-names.html
• storage/indexeddb/lazy-index-population.html

• platform/wincairo/TestExpectations: Unmarked them.

10:01 PM Changeset in webkit [244419] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 80

Added a tag for Safari Technology Preview release 80.

8:43 PM Changeset in webkit [244418] by Devin Rousso

• 5 edits in trunk/Source/WebKit

Web Inspector: InspectorFrontendHost::inspectionLevel returns wrong value for inspector3
​https://bugs.webkit.org/show_bug.cgi?id=197044

Reviewed by Joseph Pecoraro.

• UIProcess/WebInspectorUtilities.h:
• UIProcess/WebInspectorUtilities.cpp:

(WebKit::trackInspectorPage):
(WebKit::untrackInspectorPage):
Determine the level of the inspector page by looking to see if the page being inspected is
in the inspector page map. If so, we must be inspecting an inspector page and should use
that inspector page's inspection level as the value to increment.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createFrontendPage):

• UIProcess/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::createFrontendPageAndWindow):

6:16 PM Changeset in webkit [244417] by Kocsen Chung

• 28 edits in tags/Safari-608.1.17

Revert r244228. rdar://problem/49999041

6:06 PM Changeset in webkit [244416] by Kocsen Chung

• 1 copy in tags/Safari-608.1.17

Tag Safari-608.1.17.

6:02 PM Changeset in webkit [244415] by timothy_horton@apple.com

• 2 edits in trunk/Tools

[iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
​https://bugs.webkit.org/show_bug.cgi?id=197028
<rdar://problem/49985290>

Reviewed by Wenson Hsieh.

• TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:

(TEST):
Liberal application of waitForNextPresentationUpdate works around a race
where if the page rapidly changes its viewport arguments (or an API client
rapidly changes its viewport arguments), we'd get stuck thinking that the
user had intentionally zoomed the page, and stop resetting the initial scale.
This deserves a separate bug, but no need to keep the test failing while
we think about it.

5:42 PM Changeset in webkit [244414] by timothy_horton@apple.com

• 5 edits in trunk/Source

Adopt different scroll view flashing SPI
​https://bugs.webkit.org/show_bug.cgi?id=197043
<rdar://problem/49996476>

Reviewed by Wenson Hsieh.

Source/WebKit:

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollViewAnimator scrollToContentOffset:animated:]):

Source/WTF:

• wtf/Platform.h:

4:55 PM Changeset in webkit [244413] by timothy@apple.com

• 7 edits in trunk

Standardize the <meta name="color-scheme"> separator.
​https://bugs.webkit.org/show_bug.cgi?id=193931

Reviewed by Simon Fraser.

Source/WebCore:

Drop support for comma as a valid seperator in <meta name="color-scheme"> to
match the proposal being tracked by: ​https://github.com/whatwg/html/issues/4504

Tests: css-dark-mode/color-scheme-meta.html

css-dark-mode/older-syntax/supported-color-schemes-meta.html

• dom/Document.cpp:

(WebCore::isColorSchemeSeparator): Drop support for comma.

LayoutTests:

• css-dark-mode/color-scheme-meta-expected.txt:
• css-dark-mode/color-scheme-meta.html:
• css-dark-mode/older-syntax/supported-color-scheme-meta-expected.txt:
• css-dark-mode/older-syntax/supported-color-schemes-meta.html:

4:47 PM Changeset in webkit [244412] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Navigating to resource sometimes shows different resource
​https://bugs.webkit.org/show_bug.cgi?id=195978
<rdar://problem/49043191>

Reviewed by Timothy Hatcher.

• UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.cancelRestoringState):
Reset _pendingViewStateCookie so _checkElementsForPendingViewStateCookie could exit early.

• UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype.initialLayout):
(WI.ResourceSidebarPanel.prototype._mainFrameMainResourceDidChange):
(WI.ResourceSidebarPanel.prototype._createMainFrameTreeElement):
Don't try to change content view on initialLayout.

4:37 PM Changeset in webkit [244411] by Joseph Pecoraro

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: CPU Usage Timeline - Include # of Network Requests in the Statistics section
​https://bugs.webkit.org/show_bug.cgi?id=197039
<rdar://problem/49996299>

Reviewed by Timothy Hatcher.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/CPUTimelineView.js:

(WI.CPUTimelineView.prototype.initialLayout):
(WI.CPUTimelineView.prototype._computeStatisticsData):
(WI.CPUTimelineView.prototype._clearStatistics):
Add the number of network requests started in the selected range.

4:33 PM Changeset in webkit [244410] by timothy_horton@apple.com

• 6 edits
  1 add in trunk

REGRESSION (r241988): Switching tabs is slow
​https://bugs.webkit.org/show_bug.cgi?id=197037
<rdar://problem/49951473>

Reviewed by Simon Fraser.

Source/WebKit:

• UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateActivityState):
r241988 changed to wait for a WebPageProxy message to a given DrawingArea ID,
but WebPageProxy messages are identified by their WebPageProxy ID.
Revert that one change. The rest of the patch looks OK.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.

(TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView addToTestWindow]):
Add a test that hangs without this fix.

4:29 PM Changeset in webkit [244409] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Link prefetch not useful for top-level navigation
​https://bugs.webkit.org/show_bug.cgi?id=195623

Patch by Rob Buis <​rbuis@igalia.com> on 2019-04-17
Reviewed by Alex Christensen.

Fix macOS and iOS Debug WK2 bots ASSERTS after r367404, by simply
not sending the DidReceiveResponse message.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

4:15 PM Changeset in webkit [244408] by timothy@apple.com

• 24 edits
  4 copies
  12 moves
  4 adds
  3 deletes in trunk

Rename supported-color-schemes to color-scheme.
​https://bugs.webkit.org/show_bug.cgi?id=197016
rdar://problem/49980259

Reviewed by Simon Fraser.

Source/WebCore:

Changed supported-color-schemes to color-scheme to follow the spec changes
being tracked by: ​https://github.com/w3c/csswg-drafts/issues/3807

The old supported-color-schemes is now an alias of color-scheme for compatibility.

Tests: css-dark-mode/color-scheme-css-parse.html

css-dark-mode/color-scheme-css.html
css-dark-mode/color-scheme-meta.html
css-dark-mode/color-scheme-priority.html
css-dark-mode/color-scheme-scrollbar.html
css-dark-mode/older-syntax/supported-color-schemes-css.html
css-dark-mode/older-syntax/supported-color-schemes-meta.html
css-dark-mode/older-systems/color-scheme-css.html
css-dark-mode/older-systems/color-scheme-meta.html

• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):

• css/CSSProperties.json:
• css/CSSValueKeywords.in:
• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::updateColorScheme):
(WebCore::StyleBuilderConverter::convertColorScheme):
(WebCore::StyleBuilderConverter::updateSupportedColorSchemes): Deleted.
(WebCore::StyleBuilderConverter::convertSupportedColorSchemes): Deleted.

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueColorScheme):
(WebCore::StyleBuilderCustom::applyValueSupportedColorSchemes): Deleted.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::applyMatchedProperties):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeColorScheme):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeSupportedColorSchemes): Deleted.

• dom/Document.cpp:

(WebCore::processColorSchemeString):
(WebCore::Document::processColorScheme):
(WebCore::Document::useDarkAppearance const):
(WebCore::processColorSchemes): Deleted.
(WebCore::Document::processSupportedColorSchemes): Deleted.

• dom/Document.h:
• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

• page/FrameView.cpp:

(WebCore::FrameView::rendererForColorScheme const):
(WebCore::FrameView::useDarkAppearance const):
(WebCore::FrameView::styleColorOptions const):
(WebCore::FrameView::rendererForSupportedColorSchemes const): Deleted.

• page/FrameView.h:
• rendering/style/RenderStyle.cpp:

(WebCore::rareInheritedDataChangeRequiresRepaint):

• rendering/style/RenderStyle.h:

(WebCore::RenderStyle::colorScheme const):
(WebCore::RenderStyle::setHasExplicitlySetColorScheme):
(WebCore::RenderStyle::hasExplicitlySetColorScheme const):
(WebCore::RenderStyle::setColorScheme):
(WebCore::RenderStyle::initialColorScheme):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::supportedColorSchemes const): Deleted.
(WebCore::RenderStyle::setHasExplicitlySetSupportedColorSchemes): Deleted.
(WebCore::RenderStyle::hasExplicitlySetSupportedColorSchemes const): Deleted.
(WebCore::RenderStyle::setSupportedColorSchemes): Deleted.
(WebCore::RenderStyle::initialSupportedColorSchemes): Deleted.

• rendering/style/RenderStyleConstants.h:
• rendering/style/StyleColorScheme.h: Renamed from Source/WebCore/rendering/style/StyleSupportedColorSchemes.h.

(WebCore::StyleColorScheme::StyleColorScheme):
(WebCore::StyleColorScheme::operator== const):
(WebCore::StyleColorScheme::operator!= const):
(WebCore::StyleColorScheme::isAuto const):
(WebCore::StyleColorScheme::isOnly const):
(WebCore::StyleColorScheme::colorScheme const):
(WebCore::StyleColorScheme::add):
(WebCore::StyleColorScheme::contains const):
(WebCore::StyleColorScheme::setAllowsTransformations):
(WebCore::StyleColorScheme::allowsTransformations const):

• rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator== const):

• rendering/style/StyleRareInheritedData.h:

Source/WebInspectorUI:

• UserInterface/Views/Main.css:

(:root):

LayoutTests:

• css-dark-mode/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt.
• css-dark-mode/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-css.html.
• css-dark-mode/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt.
• css-dark-mode/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes.html.
• css-dark-mode/color-scheme-parse-expected.txt: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes-expected.txt.
• css-dark-mode/color-scheme-parse.html: Renamed from LayoutTests/css-dark-mode/parse-supported-color-schemes.html.
• css-dark-mode/color-scheme-priority-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority-expected.txt.
• css-dark-mode/color-scheme-priority.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-priority.html.
• css-dark-mode/color-scheme-scrollbar-expected.txt: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar-expected.txt.
• css-dark-mode/color-scheme-scrollbar.html: Renamed from LayoutTests/css-dark-mode/supported-color-schemes-scrollbar.html.
• css-dark-mode/older-syntax/supported-color-schemes-css-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css-expected.txt.
• css-dark-mode/older-syntax/supported-color-schemes-css.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes-css.html.
• css-dark-mode/older-syntax/supported-color-schemes-meta-expected.txt: Copied from LayoutTests/css-dark-mode/supported-color-schemes-expected.txt.
• css-dark-mode/older-syntax/supported-color-schemes-meta.html: Copied from LayoutTests/css-dark-mode/supported-color-schemes.html.
• css-dark-mode/older-systems/color-scheme-css-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css-expected.txt
• css-dark-mode/older-systems/color-scheme-css.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-css.html.
• css-dark-mode/older-systems/color-scheme-meta-expected.txt: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes-expected.txt.
• css-dark-mode/older-systems/color-scheme-meta.html: Renamed from LayoutTests/css-dark-mode/older-systems/supported-color-schemes.html.
• fast/css/style-enumerate-properties.html: Updated property count.

4:06 PM Changeset in webkit [244407] by Truitt Savell

• 7 edits
  1 delete in trunk

Unreviewed, rolling out r244400.

Caused testing to exit early with assertionon Debug WK2

Reverted changeset:

"UI↔Web deadlock when printing with a JavaScript alert
visible"
​https://bugs.webkit.org/show_bug.cgi?id=196839
​https://trac.webkit.org/changeset/244400

3:51 PM Changeset in webkit [244406] by Justin Fan

• 4 edits in trunk

[Web GPU] GPUComputePassEncoder::dispatch number of thread groups, not grid size
​https://bugs.webkit.org/show_bug.cgi?id=196984

Reviewed by Myles C. Maxfield.

Source/WebCore:

Test: Updated compute-squares.html.

• platform/graphics/gpu/cocoa/GPUComputePassEncoderMetal.mm:

(WebCore::GPUComputePassEncoder::dispatch):

LayoutTests:

• webgpu/compute-squares.html: One thread group is enough to process the data in a single pass.

3:47 PM Changeset in webkit [244405] by beidson@apple.com

• 9 edits
  1 add in trunk

Link clicks in PDFs shouldn't send referrer headers.
<rdar://problem/21142581> and ​https://bugs.webkit.org/show_bug.cgi?id=196980

Reviewed by Tim Horton.

Source/WebKit:

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::clickedLink):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

Source/WebKitLegacy/ios:

• WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

• WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.

(putPDFBytesCallback):
(emptyReleaseInfoCallback):
(createPDFWithLinkToURL):
(TEST):

3:41 PM Changeset in webkit [244404] by aestes@apple.com

• 4 edits in trunk/Source

[iOS] Support multiple file selection in UIDocumentPickerViewController
​https://bugs.webkit.org/show_bug.cgi?id=197014
<rdar://problem/49963514>

Reviewed by Tim Horton.

Source/WebCore:

• platform/LocalizedStrings.h:

Exported multipleFileUploadText().

Source/WebKit:

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Allowed multiple file selection in our UIDocumentPickerViewController when
_allowMultipleFiles is YES.

(displayStringForDocumentsAtURLs):
(-[WKFileUploadPanel documentPicker:didPickDocumentsAtURLs:]):
Changed to support multiple file selection. When more than one file is selected, use
WebCore::multipleFileUploadText() as the display string.

3:10 PM Changeset in webkit [244403] by achristensen@apple.com

• 6 edits in trunk/Source/WebKit

Make WebCompiledContentRuleListData non-default-constructible, move its nonserialized member to API::ContentRuleList
​https://bugs.webkit.org/show_bug.cgi?id=197033

Reviewed by Tim Horton.

This is just cleanup that makes the code nicer without changing behavior.

• Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::encode const):
(WebKit::WebCompiledContentRuleListData::decode):

• Shared/WebCompiledContentRuleListData.h:

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):

• UIProcess/API/APIContentRuleList.h:
• UIProcess/API/APIContentRuleListStore.cpp:

(API::createExtension):

2:47 PM Changeset in webkit [244402] by wilander@apple.com

• 16 edits
  4 copies
  4 adds in trunk

Add prioritization of ad click conversions and cleaning of sent ad click conversions
​https://bugs.webkit.org/show_bug.cgi?id=196934
<rdar://problem/49917773>

Reviewed by Chris Dumez.

Source/WebCore:

Tests: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html

http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html
http/tests/adClickAttribution/second-conversion-with-higher-priority.html
http/tests/adClickAttribution/second-conversion-with-lower-priority.html

• loader/AdClickAttribution.cpp:

(WebCore::AdClickAttribution::hasHigherPriorityThan const):

Added to facilitate priority comparison between two attributions.

• loader/AdClickAttribution.h:

(WebCore::AdClickAttribution::Destination::Destination):

Added a WTF::HashTableDeletedValueType constructor and changed the copy constructor to
a move constructor.

(WebCore::AdClickAttribution::isEmpty const):

Source/WebKit:

In this description, by "pair" I mean { AdClickAttribution::Source, AdClickAttribution::Destination }.

This patch adds handling of prioritization of conversions according to these rules:

• If we have a matching unconverted attribution, convert it. This consumes the conversion.
• If we have no previously converted attribution for this pair, just store.
• If we have a previously converted attribution for this pair, replace it if the new one has higher priority.
• If we had no matching unconverted attribution but do have a previously converted attribution for this

pair, re-convert the previously converted attribution to make sure the highest priority gets set.

This handling is in part done by dividing the previous m_adClickAttributionMap into
m_unconvertedAdClickAttributionMap and m_convertedAdClickAttributionMap, which now use a std::pair
as key instead of a nested HashMap.

This patch also changes AdClickAttributionManager::firePendingConversionRequests() so that it now
removes attributions which have been sent out.

Finally, AdClickAttributionManager::clear() no longer clears m_conversionBaseURLForTesting and
m_isRunningTest since doing so caused test flakiness. It is now up to the test case that sets these
members to also clear them when done.

• NetworkProcess/AdClickAttributionManager.cpp:

(WebKit::AdClickAttributionManager::storeUnconverted):
(WebKit::AdClickAttributionManager::convert):
(WebKit::AdClickAttributionManager::firePendingConversionRequests):
(WebKit::AdClickAttributionManager::clear):
(WebKit::AdClickAttributionManager::toString const):
(WebKit::AdClickAttributionManager::setConversionURLForTesting):
(WebKit::AdClickAttributionManager::ensureDestinationMapForSource): Deleted.
(WebKit::AdClickAttributionManager::store): Deleted.

• NetworkProcess/AdClickAttributionManager.h:

(WebKit::AdClickAttributionManager::AdClickAttributionManager):
(WebKit::AdClickAttributionManager::setConversionURLForTesting): Deleted.

• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::storeAdClickAttribution):

LayoutTests:

• http/tests/adClickAttribution/attribution-conversion-through-cross-site-image-redirect-expected.txt:
• http/tests/adClickAttribution/attribution-conversion-through-image-redirect-with-priority-expected.txt:
• http/tests/adClickAttribution/attribution-conversion-through-image-redirect-without-priority-expected.txt:
• http/tests/adClickAttribution/resources/getConversionData.php:
• http/tests/adClickAttribution/resources/redirectToConversion.php:
• http/tests/adClickAttribution/second-attribution-converted-with-higher-priority-expected.txt: Added.
• http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html: Added.
• http/tests/adClickAttribution/second-attribution-converted-with-lower-priority-expected.txt: Added.
• http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html: Added.
• http/tests/adClickAttribution/second-conversion-with-higher-priority-expected.txt: Added.
• http/tests/adClickAttribution/second-conversion-with-higher-priority.html: Added.
• http/tests/adClickAttribution/second-conversion-with-lower-priority-expected.txt: Added.
• http/tests/adClickAttribution/second-conversion-with-lower-priority.html: Added.
• http/tests/adClickAttribution/send-attribution-conversion-request-expected.txt:
• http/tests/adClickAttribution/send-attribution-conversion-request.html:
• http/tests/adClickAttribution/store-ad-click-attribution-expected.txt:

2:35 PM Changeset in webkit [244401] by sbarati@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Remove deprecated JSScript SPI
​https://bugs.webkit.org/show_bug.cgi?id=194909
<rdar://problem/48283499>

Reviewed by Keith Miller.

• API/JSAPIGlobalObject.mm:

(JSC::JSAPIGlobalObject::moduleLoaderFetch):

• API/JSScript.h:
• API/JSScript.mm:

(+[JSScript scriptWithSource:inVirtualMachine:]): Deleted.
(fillBufferWithContentsOfFile): Deleted.
(+[JSScript scriptFromASCIIFile:inVirtualMachine:withCodeSigning:andBytecodeCache:]): Deleted.
(+[JSScript scriptFromUTF8File:inVirtualMachine:withCodeSigning:andBytecodeCache:]): Deleted.
(-[JSScript setSourceURL:]): Deleted.

• API/JSScriptInternal.h:
• API/tests/testapi.mm:

(testFetch):
(testFetchWithTwoCycle):
(testFetchWithThreeCycle):
(testLoaderResolvesAbsoluteScriptURL):
(testImportModuleTwice):
(-[JSContextFileLoaderDelegate context:fetchModuleForIdentifier:withResolveHandler:andRejectHandler:]):

1:20 PM Changeset in webkit [244400] by timothy_horton@apple.com

• 7 edits
  1 add in trunk

UI↔Web deadlock when printing with a JavaScript alert visible
​https://bugs.webkit.org/show_bug.cgi?id=196839
<rdar://problem/49157642>

Reviewed by Andy Estes.

Source/WebKit:

• Platform/IPC/Connection.cpp:

(IPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::dispatchSyncMessage):

• Platform/IPC/Connection.h:

(IPC::Connection::hasOutstandingOutgoingSynchronousReplies const):
Keep track of whether we owe the other side of the connection any
delayed sync replies.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webViewPrintFormatter]):
Most actions one can take with a _WKWebViewPrintFormatter involve
synchronously messaging the Web Content process with an infinite timeout.
Doing so while the Web Content process is awaiting a reply to a deferred-reply
synchronous message (like, say, an alert()) results in an app-destroying deadlock.
Instead of that, return a nil _WKWebViewPrintFormatter, indicating to the client
that we can't print right now.

• UIProcess/ios/WKContentView.mm:

(-[WKContentView _wk_pageCountForPrintFormatter:]):
(-[WKContentView _wk_printedDocument]):
The above isn't sufficient, though, because a sync message could arrive and
be handled between creation and use of the _WKWebViewPrintFormatter.
So, we also bail with a zero page count and null CGPDFDocument immediately
before we would send a sync message to the Web Content process. Clients
handle this less gracefully (e.g. showing a zero page PDF), but it is
very rare compared to the above case.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.

(-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

1:01 PM Changeset in webkit [244399] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: imported recordings aren't processed when the navigation sidebar is collapsed
​https://bugs.webkit.org/show_bug.cgi?id=196921
<rdar://problem/49910815>

Reviewed by Timothy Hatcher.

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype.initialLayout):

12:59 PM Changeset in webkit [244398] by Joseph Pecoraro

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Extension scripts with parse errors do not show up in Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=196996
<rdar://problem/47054804>

Reviewed by Devin Rousso.

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.scriptDidFail):
Create a LocalScript that can be linked to but ignore it
if we already have a Resource for the URL.

• UserInterface/Protocol/DebuggerObserver.js:

(WI.DebuggerObserver.prototype.scriptFailedToParse):
Let DebuggerManager potentially create a script for this.

• UserInterface/Models/Script.js:

(WI.Script):
Local scripts provide a null id and id is not required below.

12:54 PM Changeset in webkit [244397] by Wenson Hsieh

• 3 edits in trunk/LayoutTests

REGRESSION (r244220): fast/forms/ios/inputmode-change-update-keyboard.html times out
​https://bugs.webkit.org/show_bug.cgi?id=197027
<rdar://problem/49959227>

Reviewed by Megan Gardner.

Recently, r244220 added a mechanism to disconnect or connect the hardware keyboard from layout tests; adopt this
to fix several tests that require the software keyboard to be present.

• fast/events/autoscroll-when-input-is-offscreen.html:
• fast/forms/ios/inputmode-change-update-keyboard.html:

12:50 PM Changeset in webkit [244396] by jer.noble@apple.com

• 2 edits in trunk

Automatically use ccache when available for Makefile builds
​https://bugs.webkit.org/show_bug.cgi?id=197020

Reviewed by Alex Christensen.

• Makefile.shared:

12:46 PM Changeset in webkit [244395] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKitLegacy

Unreviewed, rolling out r244386.
​https://bugs.webkit.org/show_bug.cgi?id=197031

Causing build failures on several internal builders (Requested
by ShawnRoberts on #webkit).

Reverted changeset:

"Move MiG .def files into their own "Copy files" build step"
​https://bugs.webkit.org/show_bug.cgi?id=196982
​https://trac.webkit.org/changeset/244386

12:28 PM Changeset in webkit [244394] by Devin Rousso

• 2 edits in trunk/Source/WebCore

AX: AccessibilityObject::parentObject() doesn't need to be pure virtual
​https://bugs.webkit.org/show_bug.cgi?id=197026
<rdar://problem/49448209>

Reviewed by Timothy Hatcher.

• accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::parentObject const):

12:13 PM Changeset in webkit [244393] by graouts@webkit.org

• 8 edits
  127 adds
  9 deletes in trunk/LayoutTests

[Pointer Events WPT] Update WPT tests and provide macOS testdriver
​https://bugs.webkit.org/show_bug.cgi?id=197011
<rdar://problem/49976553>

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

We update the WPT tests from the latest state of the WPT GitHub repository and provide a testdriver to dispatch mouse events on macOS.

• web-platform-tests/payment-request/payment-request-canmakepayment-method.https-expected.txt: Update expectations now that an (incomplete)

test driver is available.

• web-platform-tests/pointerevents/META.yml:
• web-platform-tests/pointerevents/compat/pointerevent_touch-action_two-finger_interaction-manual.html: Added.
• web-platform-tests/pointerevents/extension/idlharness.window-expected.txt: Removed.
• web-platform-tests/pointerevents/extension/idlharness.window.html: Removed.
• web-platform-tests/pointerevents/extension/pointerevent_coalesced_events_attributes-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_constructor.html:
• web-platform-tests/pointerevents/extension/pointerevent_getCoalescedEvents_when_pointerlocked-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_getPredictedEvents_when_pointerlocked-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_pointerrawmove-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_pointerrawmove_in_pointerlock-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_predicted_events_attributes-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-down-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-left-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-right-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/extension/pointerevent_touch-action-pan-up-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/extension/w3c-import.log: Removed.
• web-platform-tests/pointerevents/html/pointerevent_drag_interaction-manual.html: Added.
• web-platform-tests/pointerevents/idlharness.window-expected.txt: Removed.
• web-platform-tests/pointerevents/idlharness.window.html: Removed.
• web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers-manual-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_attributes_hoverable_pointers-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_attributes_nohover_pointers-manual-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_attributes_nohover_pointers-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers.html: Added.
• web-platform-tests/pointerevents/pointerevent_boundary_events_in_capturing-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_capture_mouse-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_capture_mouse.html: Added.
• web-platform-tests/pointerevents/pointerevent_capture_suppressing_mouse-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_change-touch-action-onpointerdown_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_click_during_capture-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_click_during_capture.html: Added.
• web-platform-tests/pointerevents/pointerevent_disabled_form_control-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_element_haspointercapture-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_element_haspointercapture_release_pending_capture-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_fractional_coordinates-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html: Added.
• web-platform-tests/pointerevents/pointerevent_lostpointercapture_is_first.html: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover.html: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame.html: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_inactivate_pointer-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_inactivate_pointer.html: Added.
• web-platform-tests/pointerevents/pointerevent_multiple_primary_pointers_boundary_events-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_on_event_handlers-expected.txt: Removed.
• web-platform-tests/pointerevents/pointerevent_pointerId_scope-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointercancel_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerenter_does_not_bubble-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointerenter_does_not_bubble.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_after_pointercancel_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_descendant_over-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_descendant_over.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_descendants-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_descendants.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_does_not_bubble-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_does_not_bubble.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerleave_pen-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove_isprimary_same_as_pointerdown.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove_on_chorded_mouse_button-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointermove_on_chorded_mouse_button.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerout_after_pointercancel_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerout_pen.html: Added.
• web-platform-tests/pointerevents/pointerevent_pointerout_received_once-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_pointerout_received_once.html: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_events_to_original_target-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_invalid_pointerid-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_invalid_pointerid.html: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointercancel_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_onpointerup_mouse.html: Added.
• web-platform-tests/pointerevents/pointerevent_releasepointercapture_release_right_after_capture-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_root_computed_style-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_root_computed_style.html: Added.
• web-platform-tests/pointerevents/pointerevent_root_hit_test-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_root_hit_test.html: Added.
• web-platform-tests/pointerevents/pointerevent_sequence_at_implicit_release_on_click-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_sequence_at_implicit_release_on_drag-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_disconnected-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_disconnected.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_inactive_button_mouse-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_inactive_button_mouse.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_invalid_pointerid.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_override_pending_capture_element-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget.html: Added.
• web-platform-tests/pointerevents/pointerevent_setpointercapture_to_same_element_twice-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_support.js:
• web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_click-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_click.html: Added.
• web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse-expected.txt: Added.
• web-platform-tests/pointerevents/pointerevent_suppress_compat_events_on_drag_mouse.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-auto-css_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-button-test_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-auto-child-none_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-none_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-x_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_child-pan-x-child-pan-y_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_highest-parent-none_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-inherit_parent-none_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-keyboard-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-mouse-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-none-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y-pan-y_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-pan-x-pan-y_touch.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-pan-y-css_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-rotated-divs_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-span-test_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-svg-test_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerevent_touch-action-table-test_touch-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_coordinates_when_locked.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_movementxy_when_locked-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_after_pointercapture-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_in_pointerlock-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-manual.html: Added.
• web-platform-tests/pointerevents/pointerlock/resources/pointerevent_pointermove_in_pointerlock-iframe.html: Added.
• web-platform-tests/pointerevents/pointerlock/resources/w3c-import.log: Removed.
• web-platform-tests/pointerevents/resources/pointerevent_mouse_pointercapture-iframe.html: Added.
• web-platform-tests/pointerevents/resources/pointerevent_mouse_pointercapture_inactivate_pointer-iframe.html: Added.
• web-platform-tests/pointerevents/resources/pointerevent_pointerrawmove_in_pointerlock-iframe.html: Added.
• web-platform-tests/pointerevents/resources/w3c-import.log: Removed.
• web-platform-tests/pointerevents/w3c-import.log: Removed.
• web-platform-tests/resources/testdriver-actions.js: Added.
• web-platform-tests/resources/testdriver-vendor.js: Added.

(logDebug):
(dispatchMouseActions):
(window.test_driver_internal.action_sequence):

• web-platform-tests/resources/testdriver.js: Added.

LayoutTests:

• platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_boundary_events_at_implicit_release_hoverable_pointers-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_capture_change_hover-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_mouse_pointercapture_in_frame-expected.txt: Added.
• platform/mac-wk1/imported/w3c/web-platform-tests/pointerevents/pointerevent_setpointercapture_relatedtarget-expected.txt: Added.
• platform/mac/TestExpectations:

11:57 AM Changeset in webkit [244392] by Alan Bujtas

• 6 edits
  2 adds in trunk

[ContentChangeObserver] Use aria role as a hint whether a tap should result in a synthetic click
​https://bugs.webkit.org/show_bug.cgi?id=196988
<rdar://problem/49955328>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role.html

• accessibility/AccessibilityObject.h:

Source/WebKit:

Tapping on elements with cretain aria role attributes should trigger synthetic click the same way it does on form control elements.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::isAriaRoleForImmediateClick):
(WebKit::nodeAlwaysRequiresClick):
(WebKit::WebPage::handleSyntheticClick):

LayoutTests:

• fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role-expected.txt: Added.
• fast/events/touch/ios/content-observation/tap-on-input-looking-div-with-role.html: Added.

11:49 AM Changeset in webkit [244391] by achristensen@apple.com

• 6 edits in trunk/Source/WebCore

WebSocketHandshake should not know about a Document
​https://bugs.webkit.org/show_bug.cgi?id=196468

Reviewed by Tim Horton.

I'll need to move WebSocketHandshake to the NetworkProcess for rdar://problem/46287028
It currently uses the Document pointer for 3 things:

1. To get the user agent, which we can pass in as a creation parameter.
2. To get the origin, which we can also pass in as a creation parameter.
3. To get cookies for the web inspector. We can pass in a functor instead and have the inspector provide cookies itself.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):
(WebCore::WebSocketChannel::disconnect):
(WebCore::WebSocketChannel::didOpenSocketStream):
(WebCore::WebSocketChannel::clientHandshakeRequest):

• Modules/websockets/WebSocketChannel.h:

(WebCore::WebSocketChannel::document):

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::WebSocketHandshake):
(WebCore::WebSocketHandshake::clientHandshakeMessage const):
(WebCore::WebSocketHandshake::clientHandshakeRequest const):
(WebCore::WebSocketHandshake::clientOrigin const): Deleted.
(WebCore::WebSocketHandshake::clientHandshakeCookieRequestHeaderFieldProxy const): Deleted.
(WebCore::WebSocketHandshake::clearDocument): Deleted.

• Modules/websockets/WebSocketHandshake.h:
• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::enable):

11:28 AM Changeset in webkit [244390] by achristensen@apple.com

• 107 edits in trunk

WKRetainPtr's adoption constructor should be private
​https://bugs.webkit.org/show_bug.cgi?id=197019

Reviewed by Tim Horton.

Source/WebKit:

RefPtr and RetainPtr have already done this. It makes us use nicer syntax.

• UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

• UIProcess/API/cpp/WKRetainPtr.h:

(WebKit::WKRetainPtr::WKRetainPtr):
(WebKit::adoptWK):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(dumpFramesAsText):

• TestWebKitAPI/InjectedBundleController.cpp:

(TestWebKitAPI::InjectedBundleController::initialize):

• TestWebKitAPI/PlatformUtilities.cpp:

(TestWebKitAPI::Util::createContextWithInjectedBundle):
(TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
(TestWebKitAPI::Util::createContextForInjectedBundleTest):
(TestWebKitAPI::Util::toWK):

• TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionBasic::initialize):

• TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:

(TestWebKitAPI::DOMWindowExtensionNoCache::initialize):

• TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:

(TestWebKitAPI::didRemoveFrameFromHierarchyCallback):

• TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:

(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):

• TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/Find.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FindMatches.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/Geolocation.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:

(TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):

• TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:

(TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
(TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):

• TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:

(TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):

• TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:

(TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):

• TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:

(TestWebKitAPI::loadAlternateHTMLString):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:

(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):

• TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:

(TestWebKitAPI::buildAndPerformTest):

• TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/UserMedia.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):

• TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
• TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
• TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(TEST):

• TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:

(TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):

• WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::getMenuItemTitleCallback):
(WTR::createMouseMessageBody):
(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::mouseForceClick):
(WTR::EventSendingController::startAndCancelMouseForceClick):
(WTR::EventSendingController::mouseForceDown):
(WTR::EventSendingController::mouseForceUp):
(WTR::EventSendingController::mouseForceChanged):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::scheduleAsynchronousClick):
(WTR::createKeyDownMessageBody):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSendingController::continuousMouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::setTouchPointRadius):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::touchCancel):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didCreatePage):
(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::booleanForKey):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::dumpToStdErr):
(WTR::InjectedBundle::outputText):
(WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR::InjectedBundle::postSetWindowIsKey):
(WTR::InjectedBundle::postSetViewSize):
(WTR::InjectedBundle::postSimulateWebNotificationClick):
(WTR::InjectedBundle::postSetAddsVisitedLinks):
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
(WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
(WTR::InjectedBundle::isGeolocationProviderActive const):
(WTR::InjectedBundle::imageCountInGeneralPasteboard const):
(WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
(WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
(WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR::InjectedBundle::setHidden):
(WTR::InjectedBundle::setCacheModel):
(WTR::InjectedBundle::shouldProcessWorkQueue const):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueForwardNavigation):
(WTR::InjectedBundle::queueLoad):
(WTR::InjectedBundle::queueLoadHTMLString):
(WTR::InjectedBundle::queueReload):
(WTR::InjectedBundle::queueLoadingScript):
(WTR::InjectedBundle::queueNonLoadingScript):

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::frameToStr):
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::dumpFrameDescriptionSuitableForTestResult):
(WTR::dumpFrameScrollPosition):
(WTR::dumpDescendantFrameScrollPositions):
(WTR::dumpFrameText):
(WTR::dumpDescendantFramesText):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::shouldDumpPixels const):
(WTR::TestRunner::setDumpPixels):
(WTR::TestRunner::whatToDump const):
(WTR::TestRunner::setWhatToDump):
(WTR::TestRunner::setWaitUntilDone):
(WTR::TestRunner::shouldWaitUntilDone const):
(WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
(WTR::TestRunner::shouldDumpFrameLoadCallbacks):
(WTR::TestRunner::clearAllDatabases):
(WTR::TestRunner::setIDBPerOriginQuota):
(WTR::TestRunner::originsWithApplicationCache):
(WTR::TestRunner::setCanOpenWindows):
(WTR::TestRunner::setXSSAuditorEnabled):
(WTR::TestRunner::setMediaDevicesEnabled):
(WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
(WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
(WTR::TestRunner::setCustomUserAgent):
(WTR::TestRunner::setWebAPIStatisticsEnabled):
(WTR::TestRunner::setModernMediaControlsEnabled):
(WTR::TestRunner::setWebGL2Enabled):
(WTR::TestRunner::setWritableStreamAPIEnabled):
(WTR::TestRunner::setReadableByteStreamAPIEnabled):
(WTR::TestRunner::setEncryptedMediaAPIEnabled):
(WTR::TestRunner::setAllowsAnySSLCertificate):
(WTR::TestRunner::setPluginsEnabled):
(WTR::TestRunner::setValueForUser):
(WTR::TestRunner::setAudioResult):
(WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
(WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
(WTR::TestRunner::setAlwaysAcceptCookies):
(WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
(WTR::TestRunner::isDoingMediaCapture const):
(WTR::TestRunner::queueLoad):
(WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
(WTR::TestRunner::setShouldLogDownloadCallbacks):
(WTR::TestRunner::setAuthenticationUsername):
(WTR::TestRunner::setAuthenticationPassword):
(WTR::TestRunner::secureEventInputIsEnabled const):
(WTR::TestRunner::setBlockAllPlugins):
(WTR::TestRunner::setPluginSupportedMode):
(WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
(WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
(WTR::TestRunner::setNavigationGesturesEnabled):
(WTR::TestRunner::setIgnoresViewportScaleLimits):
(WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
(WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
(WTR::TestRunner::terminateNetworkProcess):
(WTR::TestRunner::terminateServiceWorkerProcess):
(WTR::TestRunner::runUIScript):
(WTR::TestRunner::setStatisticsDebugMode):
(WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
(WTR::TestRunner::setStatisticsLastSeen):
(WTR::TestRunner::setStatisticsPrevalentResource):
(WTR::TestRunner::setStatisticsVeryPrevalentResource):
(WTR::TestRunner::dumpResourceLoadStatistics):
(WTR::TestRunner::isStatisticsPrevalentResource):
(WTR::TestRunner::isStatisticsVeryPrevalentResource):
(WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
(WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
(WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
(WTR::TestRunner::setStatisticsHasHadUserInteraction):
(WTR::TestRunner::isStatisticsHasHadUserInteraction):
(WTR::TestRunner::setStatisticsGrandfathered):
(WTR::TestRunner::isStatisticsGrandfathered):
(WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
(WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
(WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
(WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
(WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
(WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
(WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
(WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
(WTR::TestRunner::statisticsUpdateCookieBlocking):
(WTR::TestRunner::statisticsSubmitTelemetry):
(WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
(WTR::TestRunner::setStatisticsIsRunningTest):
(WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
(WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
(WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
(WTR::TestRunner::setStatisticsGrandfatheringTime):
(WTR::TestRunner::setStatisticsMaxStatisticsEntries):
(WTR::TestRunner::setStatisticsPruneEntriesDownTo):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
(WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsDeleteCookiesForHost):
(WTR::TestRunner::setStatisticsCacheMaxAgeCap):
(WTR::TestRunner::statisticsResetToConsistentState):
(WTR::TestRunner::setStorageAccessAPIEnabled):
(WTR::TestRunner::getAllStorageAccessEntries):
(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::clearMockMediaDevices):
(WTR::TestRunner::removeMockMediaDevice):
(WTR::TestRunner::resetMockMediaDevices):
(WTR::TestRunner::connectMockGamepad):
(WTR::TestRunner::disconnectMockGamepad):
(WTR::TestRunner::setMockGamepadDetails):
(WTR::TestRunner::setMockGamepadAxisValue):
(WTR::TestRunner::setMockGamepadButtonValue):
(WTR::TestRunner::removeAllSessionCredentials):
(WTR::TestRunner::clearDOMCache):
(WTR::TestRunner::clearDOMCaches):
(WTR::TestRunner::hasDOMCache):
(WTR::TestRunner::domCacheSize):
(WTR::TestRunner::setAllowStorageQuotaIncrease):
(WTR::TestRunner::getApplicationManifestThen):
(WTR::TestRunner::injectUserScript):
(WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
(WTR::TestRunner::setWebAuthenticationMockConfiguration):
(WTR::TestRunner::addTestKeyToKeychain):
(WTR::TestRunner::cleanUpKeychain):
(WTR::TestRunner::keyExistsInKeychain):
(WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
(WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
(WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
(WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
(WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
(WTR::TestRunner::setAdClickAttributionConversionURLForTesting):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):
(WTR::parseStringTestHeaderValueAsRelativePath):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::runTest):
(WTR::TestController::didReceiveLiveDocumentsList):
(WTR::TestController::didReceiveMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestController::didFinishNavigation):
(WTR::TestController::didReceiveAuthenticationChallenge):

• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::uiScriptDidComplete):
(WTR::TestInvocation::didReceiveAllStorageAccessEntries):

• WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::closeWebNotification):

• WebKitTestRunner/WorkQueueManager.cpp:

(WTR::ScriptItem::ScriptItem):
(WTR::WorkQueueManager::queueLoad):
(WTR::WorkQueueManager::queueLoadHTMLString):

11:09 AM Changeset in webkit [244389] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit

Fix crash during teardown of PingLoad
​https://bugs.webkit.org/show_bug.cgi?id=197024
<rdar://problem/49973077>

Reviewed by Jer Noble.

• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::initialize):
Early return if weakThis is null.

11:04 AM Changeset in webkit [244388] by Wenson Hsieh

• 5 edits
  2 adds in trunk

REGRESSION (r243926): [iOS] Release assertion when computing editor state during an overflow scroll triggered by layout
​https://bugs.webkit.org/show_bug.cgi?id=197012
<rdar://problem/49908848>

Reviewed by Simon Fraser.

Source/WebKit:

We hit the release assertion due to the following sequence of events:

• Dispatch a queued event (in this case, a scroll event)
• Invoke the scroll event listener, which modifies layout in some way
• This scrolls an overflow scrollable container under the scope of layout
• Overflow scrolling then calls didChangeSelection and triggers an editor state update, which updates layout

In the case where the selection is in the main frame, we bail early due to the check for recursive layout (i.e.
frameView->layoutContext().isInRenderTreeLayout()). However, in the case where the selection is inside a
subframe, we end up skipping past this check, since the subframe's FrameView isn't currently laying out, and so
we end up hitting the release assertion underneath the early return.

To fix this, simply defer editor state updates due to overflow scrolling until the next remote layer tree commit
instead of computing and sending the information immediately. While this only defers editor state updates during
overflow scrolling, <rdar://problem/47258878> tracks making editor state updates deferred in the general case.

Test: editing/selection/overflow-scroll-while-selecting-text.html

• WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:

(WebKit::WebEditorClient::overflowScrollPositionChanged):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didChangeOverflowScrollPosition):
(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::didChangeSelectionOrOverflowScrollPosition):

• WebProcess/WebPage/WebPage.h:

LayoutTests:

Adds a new layout test to exercise the crash.

• editing/selection/overflow-scroll-while-selecting-text-expected.txt: Added.
• editing/selection/overflow-scroll-while-selecting-text.html: Added.

10:59 AM Changeset in webkit [244387] by timothy@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed build fix for iOSMac after r244223.

• platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::routeSharingPolicy const): Add ALLOW_DEPRECATED_DECLARATIONS_BEGIN/END
around AVAudioSessionRouteSharingPolicyLongForm use.

10:58 AM Changeset in webkit [244386] by Keith Rollin

• 2 edits in trunk/Source/WebKitLegacy

Move MiG .def files into their own "Copy files" build step
​https://bugs.webkit.org/show_bug.cgi?id=196982

Reviewed by Alex Christensen.

WebKitLegacy's MiG files need to be processed differently from the
other files in the "Copy Headers" build phase, so move them into their
own "Copy Files" build phase. This arrangement removes them from any
post-processing performed on the main group of headers.

• WebKitLegacy.xcodeproj/project.pbxproj:

10:57 AM Changeset in webkit [244385] by Keith Rollin

• 2 edits in trunk/Source/JavaScriptCore

Remove JSCBuiltins.cpp from Copy Headers phase
​https://bugs.webkit.org/show_bug.cgi?id=196981
<rdar://problem/49952133>

Reviewed by Alex Christensen.

JSCBuiltins.cpp is not a header and so doesn't need to be in the Copy
Headers phase. Checking its history, it seems to have been added
accidentally at the same time that JSCBuiltins.h was added.

• JavaScriptCore.xcodeproj/project.pbxproj:

10:41 AM Changeset in webkit [244384] by achristensen@apple.com

• 2 edits in trunk/Tools

Add a comment to make my test from r244139 less mysterious.
​https://bugs.webkit.org/show_bug.cgi?id=196744

As suggested by Darin Adler.

• TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:

(-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):

10:28 AM Changeset in webkit [244383] by achristensen@apple.com

• 2 edits in trunk/LayoutTests

[Mac iOS WK2] Layout Test http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=196974

Reviewed by Brady Eidson.

• http/tests/resourceLoadStatistics/ping-to-prevalent-resource.html:

Make test do one thing at a time to avoid race conditions.
Clean up state on the server after test is finished to prevent corrupting future test state.

10:03 AM Changeset in webkit [244382] by Chris Dumez

• 32 edits
  1 copy
  1 add in trunk

Remember device orientation permission for the duration of the browsing session
​https://bugs.webkit.org/show_bug.cgi?id=196992
<rdar://problem/49946067>

Reviewed by Alex Christensen.

Source/WebCore:

Use DeviceOrientationOrMotionPermissionState type more consistently in the code base
instead of bool or Optional<bool>. Added "Prompt" value to this enumeration which is the
default state and which indicates we should ask the client.

• WebCore.xcodeproj/project.pbxproj:
• dom/DeviceOrientationAndMotionAccessController.cpp:

(WebCore::DeviceOrientationAndMotionAccessController::DeviceOrientationAndMotionAccessController):
(WebCore::DeviceOrientationAndMotionAccessController::shouldAllowAccess):

• dom/DeviceOrientationAndMotionAccessController.h:

(WebCore::DeviceOrientationAndMotionAccessController::accessState const):

• dom/DeviceOrientationOrMotionEvent.cpp:

(WebCore::DeviceOrientationOrMotionEvent::requestPermission):

• dom/DeviceOrientationOrMotionPermissionState.h:
• loader/DocumentLoader.h:

(WebCore::DocumentLoader::deviceOrientationAndMotionAccessState const):
(WebCore::DocumentLoader::setDeviceOrientationAndMotionAccessState):

• page/ChromeClient.h:
• page/DOMWindow.cpp:

(WebCore::DOMWindow::isAllowedToAddDeviceMotionOrientationListener const):

Source/WebKit:

Implement caching of device orientation permission decisions on the WebDeviceOrientationAndMotionAccessController,
which is owned by the WebsiteDataStore. This way, if we already prompted the user of a given origin, we will
remember the previous decision for the duration of the session and not prompt again.

• Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):

• Shared/WebsitePoliciesData.h:
• UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/Cocoa/WKWebpagePreferences.mm:

(toDeviceOrientationOrMotionPermissionState):
(-[WKWebpagePreferences _setDeviceOrientationAndMotionAccessPolicy:]):
(toWKWebsiteDeviceOrientationAndMotionAccessPolicy):
(-[WKWebpagePreferences _deviceOrientationAndMotionAccessPolicy]):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::shouldAllowDeviceOrientationAndMotionAccess):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.cpp: Added.

(WebKit::WebDeviceOrientationAndMotionAccessController::shouldAllowDeviceOrientationAndMotionAccess):
(WebKit::WebDeviceOrientationAndMotionAccessController::deviceOrientationPermission const):

• UIProcess/WebsiteData/WebDeviceOrientationAndMotionAccessController.h: Copied from Source/WebCore/dom/DeviceOrientationAndMotionAccessController.h.
• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::deviceOrientationAndMotionAccessController):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::shouldAllowDeviceOrientationAndMotionAccess):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::shouldAllowDeviceOrientationAndMotionAccess):

• WebProcess/WebPage/WebPage.h:

Tools:

Add API test coverage.

• TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:

(-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
(TEST):

9:47 AM Changeset in webkit [244381] by jer.noble@apple.com

• 2 edits in trunk/Source/WTF

Enable HAVE_AVFOUNDATION_VIDEO_OUTPUT on PLATFORM(IOSMAC)
​https://bugs.webkit.org/show_bug.cgi?id=196994
<rdar://problem/44158331>

Reviewed by Alex Christensen.

• wtf/Platform.h:

9:22 AM Changeset in webkit [244380] by Ryan Haddad

• 2 edits in branches/safari-607-branch/Tools

Cherry-pick r242819. rdar://problem/49979209

Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
​https://bugs.webkit.org/show_bug.cgi?id=195137
<rdar://problem/48810307>

Reviewed by Eric Carlson.

• TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm: (TestWebKitAPI::TEST):

git-svn-id: ​http://svn.webkit.org/repository/webkit/trunk@242819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:20 AM Changeset in webkit [244379] by aakash_jain@apple.com

• 2 edits in trunk/Tools

[ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
​https://bugs.webkit.org/show_bug.cgi?id=196675

Reviewed by Lucas Forschler.

• BuildSlaveSupport/ews-app/ews/views/submittoews.py:

(SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py

9:10 AM Changeset in webkit [244378] by Alan Bujtas

• 41 edits in trunk/LayoutTests

[iOS] Unreviewed gardening.

2 single taps in fast loading subsequent tests are recognized as double tap. Turn off double taps for content observation tests.

• fast/events/touch/ios/content-observation/0ms-delay-0ms-transition-on-mousemove.html:
• fast/events/touch/ios/content-observation/0ms-transition-on-touch-start.html:
• fast/events/touch/ios/content-observation/100ms-delay-10ms-transition-on-mousemove.html:
• fast/events/touch/ios/content-observation/100ms-transition-on-touch-start.html:
• fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-mousemove.html:
• fast/events/touch/ios/content-observation/10ms-delay-0ms-transition-on-touch-start.html:
• fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start-with-non-0px-end.html:
• fast/events/touch/ios/content-observation/10ms-delay-transition-on-touch-start.html:
• fast/events/touch/ios/content-observation/350ms-hover-intent.html:
• fast/events/touch/ios/content-observation/400ms-hover-intent.html:
• fast/events/touch/ios/content-observation/click-instead-of-hover-simple.html:
• fast/events/touch/ios/content-observation/clickable-content-is-inside-a-container.html:
• fast/events/touch/ios/content-observation/crash-on-anonymous-renderer.html:
• fast/events/touch/ios/content-observation/hover-when-style-change-is-async.html:
• fast/events/touch/ios/content-observation/hover-while-loading-subframe.html:
• fast/events/touch/ios/content-observation/iframe-is-shown-on-hover.html:
• fast/events/touch/ios/content-observation/mouse-out-event-should-fire-on-click.html:
• fast/events/touch/ios/content-observation/move-content-from-offscreen.html:
• fast/events/touch/ios/content-observation/new-content-covers-tap-target.html:
• fast/events/touch/ios/content-observation/non-visible-becomes-visible-and-gains-new-renderer.html:
• fast/events/touch/ios/content-observation/non-visible-content-gains-new-renderer.html:
• fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-opacity-and-left.html:
• fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove-with-transition.html:
• fast/events/touch/ios/content-observation/opacity-change-happens-on-mousemove.html:
• fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition.html:
• fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart.html:
• fast/events/touch/ios/content-observation/remove-subframe-while-observing.html:
• fast/events/touch/ios/content-observation/stuck-with-hover-state.html:
• fast/events/touch/ios/content-observation/style-recalc-schedule-and-force-relalc.html:
• fast/events/touch/ios/content-observation/tap-on-input-type-button-element.html:
• fast/events/touch/ios/content-observation/tap-on-input-type-text-element.html:
• fast/events/touch/ios/content-observation/transition-on-touch-start-and-remove.html:
• fast/events/touch/ios/content-observation/visibility-change-after-touch-end.html:
• fast/events/touch/ios/content-observation/visibility-change-happens-at-the-second-timer.html:
• fast/events/touch/ios/content-observation/visibility-change-happens-on-timer-hops.html:
• fast/events/touch/ios/content-observation/visibility-change-happens-while-in-mousemoved.html:
• fast/events/touch/ios/content-observation/visibility-change-is-max-height-change.html:
• fast/events/touch/ios/content-observation/visibility-change-on-touch-start-simple.html:
• fast/events/touch/ios/content-observation/visibility-change-with-image-content.html:
• fast/events/touch/ios/content-observation/visible-content-gains-new-renderer.html:

5:59 AM WebKitGTK/2.24.x edited by Adrian Perez de Castro

(diff)

3:11 AM Changeset in webkit [244377] by commit-queue@webkit.org

• 6 edits
  1 copy
  2 moves
  7 adds
  2 deletes in trunk

XMLHttpRequest has the wrong fallback encoding
​https://bugs.webkit.org/show_bug.cgi?id=191741

Patch by Rob Buis <​rbuis@igalia.com> on 2019-04-17
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Update improved test expectations and sync unsupported-encodings.any.js and
replacement-encodings.any.js tests.

• web-platform-tests/encoding/replacement-encodings.any-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings-expected.txt.
• web-platform-tests/encoding/replacement-encodings.any.html: Added.
• web-platform-tests/encoding/replacement-encodings.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings.html.
• web-platform-tests/encoding/replacement-encodings.any.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/encoding/replacement-encodings-expected.txt.
• web-platform-tests/encoding/replacement-encodings.any.worker.html: Added.
• web-platform-tests/encoding/unsupported-encodings-expected.txt: Removed.
• web-platform-tests/encoding/unsupported-encodings.any-expected.txt: Added.
• web-platform-tests/encoding/unsupported-encodings.any.html: Added.
• web-platform-tests/encoding/unsupported-encodings.any.js: Added.
• web-platform-tests/encoding/unsupported-encodings.any.worker-expected.txt: Added.
• web-platform-tests/encoding/unsupported-encodings.any.worker.html: Added.
• web-platform-tests/encoding/unsupported-encodings.html: Removed.
• web-platform-tests/xhr/overridemimetype-edge-cases.window-expected.txt:
• web-platform-tests/xhr/responsetext-decoding-expected.txt:

Source/WebCore:

Allow overriding the response charset as specified here:
​https://xhr.spec.whatwg.org/#final-charset

Behavior matches Firefox and Chrome.

Tests: imported/w3c/web-platform-tests/encoding/replacement-encodings.any.html

imported/w3c/web-platform-tests/encoding/replacement-encodings.any.worker.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.html
imported/w3c/web-platform-tests/encoding/unsupported-encodings.any.worker.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::finalResponseCharset const):
(WebCore::XMLHttpRequest::createDecoder const):

• xml/XMLHttpRequest.h:

2:21 AM Changeset in webkit [244376] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

Update the test result of resize-observer/eventloop.html.
​https://bugs.webkit.org/show_bug.cgi?id=197001

Patch by Cathie Chen <cathiechen> on 2019-04-17
Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

• web-platform-tests/resize-observer/eventloop-expected.txt:

LayoutTests:

Since 177484 has landed, the order of requestAnimationFrame and resizeobserver callback is right.
No need to mark eventloop.html as flaky.

• TestExpectations:

12:36 AM Changeset in webkit [244375] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

Opt Google Maps into simulated mouse events dispatch quirk
​https://bugs.webkit.org/show_bug.cgi?id=196965
<rdar://problem/49934766>

Reviewed by Dean Jackson.

Use the correct Google Maps path.

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

12:33 AM Changeset in webkit [244374] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

Opt flipkart.com into simulated mouse events dispatch quirk
​https://bugs.webkit.org/show_bug.cgi?id=196961
<rdar://problem/49648520>

Reviewed by Dean Jackson.

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

12:30 AM Changeset in webkit [244373] by graouts@webkit.org

• 2 edits in trunk/Source/WebCore

Opt MSN.com into simulated mouse events dispatch quirk
​https://bugs.webkit.org/show_bug.cgi?id=196960
<rdar://problem/49403260>

Reviewed by Dean Jackson.

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Apr 16, 2019:

11:16 PM Changeset in webkit [244372] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

ScalableImageDecoder: don't forcefully decode image data when querying frame completeness, duration
​https://bugs.webkit.org/show_bug.cgi?id=191354
<rdar://problem/46123406>

Reviewed by Michael Catanzaro.

ScalableImageDecoder::frameIsCompleteAtIndex() should only check the
index validity and, if the index is valid, check for completeness of the
corresponding frame. ScalableImageDecoder::frameDurationAtIndex() should
also only retrieve duration for already-complete frames, or expand the
default 0-second value according to the flashing-protection rule when
the target frame is not yet complete.

Both methods avoid calling ScalableImageDecoder::frameBufferAtIndex()
as that method goes on and decodes image data to determine specific
information. The ImageSource class that's querying this information
doesn't anticipate this, and doesn't handle the increased memory
consumption of the decoded data, leaving MemoryCache in the blind about
the image resource's actual amount of consumed memory. ImageSource can
instead gracefully handle any incomplete frame by marking the decoding
status for this frame as only partial.

• platform/image-decoders/ScalableImageDecoder.cpp:

(WebCore::ScalableImageDecoder::frameIsCompleteAtIndex const):
(WebCore::ScalableImageDecoder::frameHasAlphaAtIndex const):
(WebCore::ScalableImageDecoder::frameDurationAtIndex const):

9:45 PM Changeset in webkit [244371] by aestes@apple.com

• 2 edits in trunk/Source/WebKit

[iOSMac] Use UIDocumentPickerViewController for picking files
​https://bugs.webkit.org/show_bug.cgi?id=196999
<rdar://problem/49961414>

Reviewed by Tim Horton.

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showDocumentPickerMenu]):
Changed to present a UIDocumentPickerViewController on iOSMac.

(-[WKFileUploadPanel documentPicker:didPickDocumentsAtURLs:]):
(-[WKFileUploadPanel documentPicker:didPickDocumentAtURL:]):
Replaced a deprecated delegate method implementation.

8:34 PM Changeset in webkit [244370] by Wenson Hsieh

• 25 edits
  2 adds in trunk

[iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
​https://bugs.webkit.org/show_bug.cgi?id=196919
<rdar://problem/41630459>

Reviewed by Tim Horton.

Source/WebKit:

Adds modern WebKit support for -dontDismiss by implementing a couple of new platform hooks. Covered by a new
layout test: editing/selection/ios/selection-after-changing-text-with-callout-menu.html.

• Platform/spi/ios/UIKitSPI.h:

Declare the private -dontDismiss property of UIMenuItem.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView willFinishIgnoringCalloutBarFadeAfterPerformingAction]):

Additionally teach the web view (not just the content view) to respond to the hook. This matters in the case
where the WebKit client (most notably, Mail) overrides WKWebView methods to define custom actions in the menu
controller. This scenario is exercised by the new layout test.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView willFinishIgnoringCalloutBarFadeAfterPerformingAction]):

If an action was performed where callout bar fading was ignored, then in WebKit, don't allow selection changes
to fade the callout bar until after the next remote layer tree commit.

(-[WKContentView _updateChangedSelection:]):

Stop suppressing selection updates when showing B/I/U controls, now that we can properly honor the -dontDismiss
property. This was originally introduced in <rdar://problem/15199925>, presumably to ensure that B/I/U buttons
(which have -dontDismiss set to YES) don't trigger selection change and end up dismissing themselves; however,
if triggering B/I/U actually changes the selection rects, this also means that the selection rects on-screen
would be stale after triggering these actions. This effect is most noticeable when bolding text.

(-[WKContentView shouldAllowHidingSelectionCommands]):

Tools:

Add iOS support for several new testing hooks. See below for more detail.

• DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isDismissingMenu const):

Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
dismissing. We consider the menu to be dismissing in between the -WillHide and -DidHide notifications sent
by UIKit when dismissing the callout bar (i.e. UIMenuController).

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::isDismissingMenu const):

• TestRunnerShared/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAllowedMenuActions):

Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
"Copy", or "Paste"). In the case of the custom actions installed via installCustomMenuAction, we instead match
against the name of the custom action.

(WTR::TestRunner::installCustomMenuAction):

Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
takes the name of the action (which appears in a button in the callout bar), whether the action should cause
the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
triggered.

(WTR::TestRunner::performCustomMenuAction):

Invoked when the custom menu action is triggered.

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::installCustomMenuAction):
(WTR::TestController::setAllowedMenuActions):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
(WTR::TestInvocation::performCustomMenuAction):

Add plumbing to call back into the injected bundle when performing the custom action.

• WebKitTestRunner/TestInvocation.h:
• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::installCustomMenuAction):
(WTR::TestController::setAllowedMenuActions):

• WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]):
(-[TestRunnerWKWebView becomeFirstResponder]):
(-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):

Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
in the Mail app on iOS.

(-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
(-[TestRunnerWKWebView setAllowedMenuActions:]):
(-[TestRunnerWKWebView resetCustomMenuAction]):
(-[TestRunnerWKWebView performCustomAction:]):
(-[TestRunnerWKWebView canPerformAction:withSender:]):
(-[TestRunnerWKWebView _willHideMenu]):
(-[TestRunnerWKWebView _didHideMenu]):

• WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
if specified.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::isDismissingMenu const):

LayoutTests:

Add a new iOS layout test that installs a custom, non-dismissing action in the callout menu that enlarges text.
The test then activates this custom menu item and checks that the selection rects after triggering this custom
action are updated, and the callout bar is still showing.

• editing/selection/ios/selection-after-changing-text-with-callout-menu-expected.txt: Added.
• editing/selection/ios/selection-after-changing-text-with-callout-menu.html: Added.

This test additionally suppresses all callout bar menu items except for the custom "Embiggen" action, to ensure
that the "Embiggen" option can be tapped from the layout test without having to navigate callout bar items by
tapping on the "Next" and "Show styles" buttons. This latter approach is very challenging to make reliable in
automation; when navigating submenus in the callout bar, the next button can't be tapped until the current
callout bar transition animation is complete, but there's no delegate method invoked or notification posted when
this happens.

• resources/ui-helper.js:

(window.UIHelper.isShowingMenu):
(window.UIHelper.isDismissingMenu):
(window.UIHelper.rectForMenuAction):
(window.UIHelper.async.chooseMenuAction):

Additionally add a few more UIHelper methods.

(window.UIHelper):

7:56 PM Changeset in webkit [244369] by Ross Kirsling

• 4 edits in trunk/Source

Unreviewed non-unified build fix after r244307.

Source/WebCore:

• page/DiagnosticLoggingClient.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.h:

6:41 PM Changeset in webkit [244368] by Megan Gardner

• 9 edits in trunk

Allow sharing from imageSheet on an image document
​https://bugs.webkit.org/show_bug.cgi?id=196891
<rdar://problem/25377386>

Reviewed by Tim Horton.

Source/WebKit:

Allow sharing from an image sheet generated from an image document
by storing the image URL and using it as a fallback for the URL.
Store it as an image on WKElementAction to not accidentally trigger
any actions that should actually be associated with pure URLs.

• UIProcess/API/Cocoa/_WKActivatedElementInfo.h:
• UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithInteractionInformationAtPosition:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:]):
(-[_WKActivatedElementInfo _initWithType:URL:imageURL:location:title:ID:rect:image:userInfo:]):
(-[_WKActivatedElementInfo imageURL]):
(-[_WKActivatedElementInfo _initWithType:URL:location:title:ID:rect:image:]): Deleted.
(-[_WKActivatedElementInfo _initWithType:URL:location:title:ID:rect:image:userInfo:]): Deleted.

• UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h:
• UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction _elementActionWithType:customTitle:assistant:]):

• UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant defaultActionsForImageSheet:]):
(-[WKActionSheetAssistant showLinkSheet]):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showAttachmentSheet]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):

Tools:

Test to make sure that the correct imageURL is extracted from an image element.

• TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:

(TestWebKitAPI::TEST):

6:32 PM Changeset in webkit [244367] by Wenson Hsieh

• 4 edits in trunk/Source/WebKit

[Cocoa] Add a way for Apple-internal clients to opt into recommended compatibility mode
​https://bugs.webkit.org/show_bug.cgi?id=196977
<rdar://problem/49871194>

Reviewed by Tim Horton.

Add a helper method to query whether the navigation client should bypass policy safeguards when determining the
recommended compatibility mode. We bypass policy safeguards in Cocoa platforms if the navigation delegate
implements the new navigation delegate API.

• UIProcess/API/APINavigationClient.h:

(API::NavigationClient::shouldBypassCompatibilityModeSafeguards const):

• UIProcess/Cocoa/NavigationState.h:
• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::shouldBypassCompatibilityModeSafeguards const):

6:27 PM Changeset in webkit [244366] by stephan.szabo@sony.com

• 4 edits in trunk/Source

[PlayStation] Update port for system library changes
​https://bugs.webkit.org/show_bug.cgi?id=196978

Reviewed by Ross Kirsling.

Source/JavaScriptCore:

• shell/playstation/Initializer.cpp:

Add reference to new posix compatibility library.

Source/WTF:

• wtf/PlatformPlayStation.cmake:

Remove reference to deleted system library

5:33 PM Changeset in webkit [244365] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit

-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
​https://bugs.webkit.org/show_bug.cgi?id=196991
<rdar://problem/45507423>

Reviewed by Brent Fulgham.

The credentials are stored in the Network process. To enable fetching credentials from the Network process,
a proper process access type needs to be set for the credential Website data type.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::computeNetworkProcessAccessTypeForDataFetch):

5:18 PM Changeset in webkit [244364] by commit-queue@webkit.org

• 4 edits in trunk

REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
​https://bugs.webkit.org/show_bug.cgi?id=196995

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-04-16
Reviewed by Brady Eidson.

Source/WebKit:

Always call CompletionHandlers. Otherwise things hang or assert.
I added an API test that asserts without this change so we don't regress this again.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TEST):

4:44 PM Changeset in webkit [244363] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Worker imported scripts not showing up in Open Quickly dialog if inspector open after workers exist
​https://bugs.webkit.org/show_bug.cgi?id=196986

Reviewed by Devin Rousso.

• UserInterface/Views/OpenResourceDialog.js:

(WI.OpenResourceDialog.prototype._addScriptsForTarget):
We were unnecessary skipping Scripts that do not have a sourceURL but do
have a URL, which ends up being Worker populated scripts.

4:29 PM Changeset in webkit [244362] by jer.noble@apple.com

• 2 edits in trunk/Source/WTF

Enable HAVE_AVKIT on PLATFORM(IOSMAC)
​https://bugs.webkit.org/show_bug.cgi?id=196987

Reviewed by Tim Horton.

• wtf/Platform.h:

4:07 PM Changeset in webkit [244361] by Chris Dumez

• 14 edits
  1 add in trunk

URL set by document.open() is not communicated to the UIProcess
​https://bugs.webkit.org/show_bug.cgi?id=196941
<rdar://problem/49237544>

Reviewed by Geoff Garen.

Source/WebCore:

Notify the FrameLoaderClient whenever an explicit open was done and provide it with
the latest document URL.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::didExplicitOpen):

• loader/FrameLoaderClient.h:

Source/WebKit:

Whenever the UIProcess is notified of an explicit document.open() call, update the
PageLoadState to make sure the URL is up-to-date. Also make sure the page / process
knows it committed a load (i.e. It is no longer showing the initially empty document).

• UIProcess/PageLoadState.cpp:

(WebKit::PageLoadState::didExplicitOpen):

• UIProcess/PageLoadState.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didExplicitOpenForFrame):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidExplicitOpen):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add API test coverage.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
• TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:

(-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):

3:43 PM Changeset in webkit [244360] by Chris Dumez

• 4 edits
  2 adds in trunk/Source

Show prompt for device orientation access if the client does not implement the corresponding API delegate
​https://bugs.webkit.org/show_bug.cgi?id=196971
<rdar://problem/49945840>

Reviewed by Alex Christensen.

Show prompt for device orientation access if the client does not implement the corresponding
API delegate, instead of rejecting access by default.

• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::shouldAllowDeviceOrientationAndMotionAccess):

• UIProcess/Cocoa/WKOrientationAccessAlert.h: Added.
• UIProcess/Cocoa/WKOrientationAccessAlert.mm: Added.

(WebKit::presentOrientationAccessAlert):

• WebKit.xcodeproj/project.pbxproj:

2:35 PM Changeset in webkit [244359] by wilander@apple.com

• 3 edits in trunk/LayoutTests

Set test conditions closer to conversion redirect in LayoutTests/http/tests/adClickAttribution/send-attribution-conversion-request.html
​https://bugs.webkit.org/show_bug.cgi?id=196983
<rdar://problem/49952679>

Unreviewed test gardening.

• http/tests/adClickAttribution/resources/redirectToConversion.php:
• http/tests/adClickAttribution/send-attribution-conversion-request.html:

2:28 PM Changeset in webkit [244358] by Joseph Pecoraro

• 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r238168) Web Inspector: <iframe src=...> request does not show up in Network Tab
​https://bugs.webkit.org/show_bug.cgi?id=193505
<rdar://problem/47325957>

Reviewed by Devin Rousso.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype._handleFrameWasAdded):
Handle new frames by adding the frame's main resource.

1:52 PM Changeset in webkit [244357] by jonlee@apple.com

• 5 edits in trunk

[MotionMark] The text "kkkj" is causing Firefox console warning: unreachable code after return statement
​https://bugs.webkit.org/show_bug.cgi?id=196814

Reviewed by Wenson Hsieh.

• MotionMark/resources/extensions.js:

(subtract.subtract.sampleY):
Websites/browserbench.org:

• MotionMark1.1/resources/extensions.js:

(subtract.subtract.sampleY):

1:39 PM Changeset in webkit [244356] by Alan Bujtas

• 2 edits in trunk/Source/WebKit

REGRESSION(r243557)[ContentChangeObserver] Need to double tap text formatting elements in MS Word web app
​https://bugs.webkit.org/show_bug.cgi?id=196975
<rdar://problem/49489849>

Reviewed by Simon Fraser.

This patch ensures that we always proceed with synthetic click on form elements.

Covered by existing tests.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):

1:32 PM Changeset in webkit [244355] by timothy@apple.com

• 4 edits in trunk/Source

FrameView base background color always starts white.
​https://bugs.webkit.org/show_bug.cgi?id=196976

Reviewed by Beth Dakin.

Source/WebCore:

• page/FrameView.cpp:

(WebCore::FrameView::setBaseBackgroundColor): Bail early if the base background
color did not change.

Source/WebKit:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Set m_backgroundColor before calling
WebFrame::createWithCoreMainFrame so the call to create the FrameView
for the empty page in transitionToCommittedForNewPage() gets
the correct color from WebPage.

12:53 PM Changeset in webkit [244354] by Devin Rousso

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.selectionPathComponents')
​https://bugs.webkit.org/show_bug.cgi?id=196936
<rdar://problem/49917789>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WI.HeapAllocationsTimelineView.prototype.showHeapSnapshotTimelineRecord):
(WI.HeapAllocationsTimelineView.prototype.get navigationItems):
(WI.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
Drive-by: when selecting a record, force it to be visible before selecting it, as otherwise
the selection events won't be fired.

• UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WI.HeapAllocationsTimelineOverviewGraph.prototype.layout):
Drive-by: ensure that clicking on a [S] heap snapshot record icon actually selects the record.

12:48 PM Changeset in webkit [244353] by Devin Rousso

• 67 edits in trunk

Unprefix -webkit-sticky
​https://bugs.webkit.org/show_bug.cgi?id=196962
<rdar://problem/40903458>

Reviewed by Simon Fraser.

Source/WebCore:

Updated existing tests.

This change doesn't modify functionality, only exposing a new unprefixed CSS value.

• css/CSSProperties.json:
• css/CSSValueKeywords.in:

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator PositionType const):

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::convertPositionStyle):

Source/WebInspectorUI:

Replace all -webkit-sticky with sticky.

• UserInterface/Models/CSSKeywordCompletions.js:
• UserInterface/Views/AuditTestCaseContentView.css:

(.content-view-container > .content-view.audit-test-case > header):

• UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group.contains-test-case > header):

• UserInterface/Views/ChangesDetailsSidebarPanel.css:

(.changes-panel .resource-section > .header):

• UserInterface/Views/DetailsSection.css:

(.details-section > .header):

• UserInterface/Views/NetworkDetailView.css:

(.network-detail .navigation-bar):

• UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings .navigation-bar):

• UserInterface/Views/Table.css:

(.table > .header):

LayoutTests:

• compositing/layer-creation/no-compositing-for-sticky.html:
• editing/pasteboard/copy-paste-converts-sticky.html:
• editing/pasteboard/copy-paste-converts-sticky-expected.txt:
• fast/block/positioning/fixed-container-with-sticky-parent.html:
• fast/block/sticky-position-containing-block-crash.html:
• fast/css/sticky/inflow-sticky.html:
• fast/css/sticky/inline-sticky-abspos-child.html:
• fast/css/sticky/inline-sticky.html:
• fast/css/sticky/multiple-layers-sticky-crash.html:
• fast/css/sticky/parsing-position-sticky-expected.txt:
• fast/css/sticky/remove-inline-sticky-crash.html:
• fast/css/sticky/remove-sticky-crash.html:
• fast/css/sticky/replaced-sticky.html:
• fast/css/sticky/resources/parsing-position-sticky.js:
• fast/css/sticky/sticky-as-positioning-container.html:
• fast/css/sticky/sticky-both-sides.html:
• fast/css/sticky/sticky-bottom-overflow-padding.html:
• fast/css/sticky/sticky-left-percentage.html:
• fast/css/sticky/sticky-left.html:
• fast/css/sticky/sticky-margins.html:
• fast/css/sticky/sticky-overflowing.html:
• fast/css/sticky/sticky-side-margins.html:
• fast/css/sticky/sticky-stacking-context.html:
• fast/css/sticky/sticky-stacking-context-expected.html:
• fast/css/sticky/sticky-table-row-top.html:
• fast/css/sticky/sticky-table-thead-top.html:
• fast/css/sticky/sticky-top-margins.html:
• fast/css/sticky/sticky-top-overflow-container-overflow.html:
• fast/css/sticky/sticky-top-overflow.html:
• fast/css/sticky/sticky-top-zoomed.html:
• fast/css/sticky/sticky-top-zoomed-expected.html:
• fast/css/sticky/sticky-top.html:
• fast/css/sticky/sticky-writing-mode-horizontal-bt.html:
• fast/css/sticky/sticky-writing-mode-vertical-lr.html:
• fast/css/sticky/sticky-writing-mode-vertical-rl.html:
• fast/multicol/newmulticol/table-section-crash.html:
• fast/scrolling/ios/reconcile-layer-position-recursive.html:
• fast/scrolling/rtl-scrollbars-sticky-document-2.html:
• fast/scrolling/rtl-scrollbars-sticky-document.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe-2.html:
• fast/scrolling/rtl-scrollbars-sticky-iframe.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html:
• fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html:
• fast/scrolling/sticky-to-fixed.html:
• legacy-animation-engine/fast/multicol/newmulticol/table-section-crash.html:
• scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html:
• svg/text/select-text-inside-non-static-position.html:
• tiled-drawing/scrolling/sticky/negative-scroll-offset.html:
• tiled-drawing/scrolling/sticky/sticky-horizontal.html:
• tiled-drawing/scrolling/sticky/sticky-layers.html:
• tiled-drawing/scrolling/sticky/sticky-vertical.html:

12:46 PM Changeset in webkit [244352] by rmorisset@apple.com

• 4 edits in trunk/Source

[WTF] holdLock should be marked WARN_UNUSED_RETURN
​https://bugs.webkit.org/show_bug.cgi?id=196922

Reviewed by Keith Miller.

Source/JavaScriptCore:

There was one case where holdLock was used and the result ignored.
From a comment that was deleted in ​https://bugs.webkit.org/attachment.cgi?id=328438&action=prettypatch, I believe that it is on purpose.
So I brought back a variant of the comment, and made the ignoring of the return explicit.

• heap/BlockDirectory.cpp:

(JSC::BlockDirectory::isPagedOut):

Source/WTF:

• wtf/Locker.h:

12:37 PM Changeset in webkit [244351] by Devin Rousso

• 2 edits
  3 deletes in trunk/Source/WebInspectorUI

Web Inspector: remove unused WI.DOMTreeDataGrid
​https://bugs.webkit.org/show_bug.cgi?id=196958
<rdar://problem/49931383>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DOMTreeDataGrid.css: Removed.
• UserInterface/Views/DOMTreeDataGrid.js: Removed.
• UserInterface/Views/DOMTreeDataGridNode.js: Removed.
• UserInterface/Main.html:

12:02 PM Changeset in webkit [244350] by Devin Rousso

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Storage: values truncated in Local/Session table
​https://bugs.webkit.org/show_bug.cgi?id=178318
<rdar://problem/34998581>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/DataGrid.js:

(WI.DataGrid):
(WI.DataGrid.prototype._copyTextForDataGridNode):

• UserInterface/Views/TimelineDataGrid.js:

(WI.TimelineDataGrid):
Refactor WI.DataGrid constructor to allow for more optional arguments.
Introduce a new optional argument copyCallback that can be used to override the text that
would be copied for any WI.DataGridNode in any column.

• UserInterface/Views/DOMStorageContentView.js:

(WI.DOMStorageContentView):
(WI.DOMStorageContentView.prototype.itemAdded):
(WI.DOMStorageContentView.prototype.itemUpdated):
(WI.DOMStorageContentView.prototype._populate):
(WI.DOMStorageContentView.prototype._dataGridCopy): Added.
Save the full non-truncated value as part of the WI.DataGridNode's data. When copying,
use the full non-truncated value instead of what was shown in the DOM.

11:51 AM Changeset in webkit [244349] by don.olmstead@sony.com

• 7 edits in trunk

[CMake] Set WTF_SCRIPTS_DIR
​https://bugs.webkit.org/show_bug.cgi?id=196917

Reviewed by Konstantin Tokarev.

.:

Define WTF_SCRIPTS_DIR in WebKitFS.cmake and use that within the WEBKIT_COMPUTE_SOURCES
macro. This allows it to be overridden by a port such as the AppleWin internal build.

• Source/cmake/OptionsAppleWin.cmake:
• Source/cmake/OptionsWinCairo.cmake:
• Source/cmake/WebKitFS.cmake:
• Source/cmake/WebKitMacros.cmake:

Source/WTF:

Use WTF_SCRIPTS_DIR for copying the unified sources script.

• wtf/CMakeLists.txt:

11:32 AM Changeset in webkit [244348] by Kocsen Chung

• 8 edits
  1 add in tags/Safari-607.2.4.1/Source

Apply patch. rdar://problem/49836497

11:27 AM Changeset in webkit [244347] by Kocsen Chung

• 7 edits in tags/Safari-607.2.4.1/Source

Versioning.

11:25 AM Changeset in webkit [244346] by wilander@apple.com

• 2 edits in trunk/LayoutTests

Increase timeout threshold in http/tests/adClickAttribution/send-attribution-conversion-request.html to address flakiness
​https://bugs.webkit.org/show_bug.cgi?id=196970
<rdar://problem/49945327>

Unreviewed test gardening.

• http/tests/adClickAttribution/send-attribution-conversion-request.html:

Increased test timeout from 2 seconds to 4.

11:19 AM Changeset in webkit [244345] by Joseph Pecoraro

• 3 edits in trunk/LayoutTests

Unreviewed test gardening, rebaseline HAR test after r244294.

• http/tests/inspector/network/har/har-page-expected.txt:
• http/tests/inspector/network/har/har-page.html:

Update for stricter SameSite parsing.

11:11 AM Changeset in webkit [244344] by Shawn Roberts

• 3 edits in trunk/LayoutTests

media/W3C/video/events/event_progress_manual.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=177663

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations: Updating test expectations

11:07 AM Changeset in webkit [244343] by Kocsen Chung

• 1 copy in tags/Safari-607.2.4.1

New tag.

11:01 AM Changeset in webkit [244342] by Alan Coon

• 7 edits in tags/Safari-608.1.16.100/Source

Versioning.

10:55 AM Changeset in webkit [244341] by Alan Coon

• 1 copy in tags/Safari-608.1.16.100

New tag.

10:47 AM Changeset in webkit [244340] by Alan Coon

• 7 edits in tags/Safari-608.1.16.200/Source

Versioning.

10:45 AM Changeset in webkit [244339] by Alan Coon

• 1 delete in tags/Safari-608.1.16.1.200

Delete tag.

10:44 AM Changeset in webkit [244338] by Alan Coon

• 1 copy in tags/Safari-608.1.16.200

New tag.

10:41 AM Changeset in webkit [244337] by Alan Coon

• 1 copy in tags/Safari-608.1.16.1.200

New tag.

10:40 AM Changeset in webkit [244336] by Alan Coon

• 1 delete in tags/Safari-608.1.16.200

Delete tag.

10:36 AM Changeset in webkit [244335] by Alan Coon

• 1 copy in tags/Safari-608.1.16.200

New tag.

10:18 AM Changeset in webkit [244334] by Kocsen Chung

• 7 edits in branches/safari-607-branch/Source

Versioning.

9:46 AM Changeset in webkit [244333] by Ryan Haddad

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the build with recent SDKs.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(WebKit::WKWebViewState::store):

9:46 AM Changeset in webkit [244332] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations: Correct a typo in bug URL.

9:28 AM Changeset in webkit [244331] by commit-queue@webkit.org

• 14 edits
  1 delete in trunk

Unreviewed, rolling out r244321.
​https://bugs.webkit.org/show_bug.cgi?id=196968

Causing all WK2 Debug builds to exit early after Assertion
failures. (Requested by ShawnRoberts on #webkit).

Reverted changeset:

"URL set by document.open() is not communicated to the
UIProcess"
​https://bugs.webkit.org/show_bug.cgi?id=196941
​https://trac.webkit.org/changeset/244321

8:58 AM Changeset in webkit [244330] by caitp@igalia.com

• 8 edits in trunk

[JSC] Filter DontEnum properties in ProxyObject::getOwnPropertyNames()
​https://bugs.webkit.org/show_bug.cgi?id=176810

Reviewed by Saam Barati.

JSTests:

Add tests for the DontEnum filtering, and variations of other tests
take the DontEnum-filtering path.

• stress/proxy-own-keys.js:

(i.catch):
(set assert):
(set add):
(let.set new):
(get let):

Source/JavaScriptCore:

This adds conditional logic following the invariant checks, to perform
filtering in common uses of getOwnPropertyNames.

While this would ideally only be done in JSPropertyNameEnumerator, adding
the filtering to ProxyObject::performGetOwnPropertyNames maintains the
invariant that the EnumerationMode is properly followed.

This was originally rolled out in r244020, as DontEnum filtering code
in ObjectConstructor.cpp's ownPropertyKeys() had not been removed. It's
now redundant due to being handled in ProxyObject::getOwnPropertyNames().

• runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::reset):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::performGetOwnPropertyNames):

Source/WebCore:

Previously, there was a comment here indicating uncertainty of whether it
was necessary to filter DontEnum properties explicitly or not. It turns
out that it was necessary in the case of JSC ProxyObjects.

This patch adds DontEnum filtering for ProxyObjects, however we continue
to explicitly filter them in JSDOMConvertRecord, which needs to use the
property descriptor after filtering. This change prevents observably
fetching the property descriptor twice per property.

• bindings/js/JSDOMConvertRecord.h:

8:16 AM EnvironmentVariables edited by Philippe Normand

(diff)

2:41 AM Changeset in webkit [244329] by Philippe Normand

• 2 edits in trunk/LayoutTests

Unreviewed, GTK gardening

• platform/gtk/TestExpectations:

media/media-controls-accessibility.html times out since r244182.

1:03 AM Changeset in webkit [244328] by graouts@webkit.org

• 4 edits
  2 adds in trunk

[iOS] Redundant pointer events causes material design buttons to flush twice
​https://bugs.webkit.org/show_bug.cgi?id=196914
<rdar://problem/49571860>

Reviewed by Dean Jackson.

Source/WebCore:

Test: pointerevents/ios/pointer-event-order.html

Do not dispatch pointer events for mouse events on iOS since we're already dispatching them when processing touch events.

• dom/Element.cpp:

(WebCore::Element::dispatchMouseEvent):

LayoutTests:

Add a new test that listens to all pointer event types as well as click, which forces the dispatch of compatibility mouse events
along with the click which would trigger duplicated pointer events prior to the source changes.

To ensure the new test added runs smoothly with a preceeding test that also uses ui.tap(), we add a delay to guarantee that no
double-taps are seen rather two successive single taps.

• pointerevents/ios/pointer-event-order-expected.txt: Added.
• pointerevents/ios/pointer-event-order.html: Added.
• pointerevents/utils.js:

(const.ui.new.UIController.prototype.tap):