Context Navigation

← Previous Period
Next Period →

Timeline

Sep 5, 2019:

10:57 PM Changeset in webkit [249564] by Chris Dumez

5 edits in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
https://bugs.webkit.org/show_bug.cgi?id=201519

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Drop Webkit-specific changes to WPT tests.

IndexedDB-private-browsing/support.js:

Tools:

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
TestOption::useEphemeralSession flag based on the test folder.

DumpRenderTree/mac/DumpRenderTree.mm:

(shouldUseEphemeralSession):
(runTest):

WebKitTestRunner/TestOptions.cpp:

(WTR::shouldUseEphemeralSession):
(WTR::TestOptions::TestOptions):

10:06 PM Changeset in webkit [249563] by Chris Dumez

308 edits in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js
https://bugs.webkit.org/show_bug.cgi?id=201522

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js.
Instead, use the new useEphemeralSession WKTR flag added in r249542.

resources/js-test.js:
storage/indexeddb/aborted-versionchange-closes-private.html:
storage/indexeddb/basics-private.html:
storage/indexeddb/clone-exception-private.html:
storage/indexeddb/closed-cursor-private.html:
storage/indexeddb/connection-leak-private.html:
storage/indexeddb/create-and-remove-object-store-private.html:
storage/indexeddb/create-object-store-options-private.html:
storage/indexeddb/createIndex-after-failure-private.html:
storage/indexeddb/createObjectStore-name-argument-required-private.html:
storage/indexeddb/createObjectStore-null-name-private.html:
storage/indexeddb/cursor-added-bug-private.html:
storage/indexeddb/cursor-advance-private.html:
storage/indexeddb/cursor-basics-private.html:
storage/indexeddb/cursor-cast-private.html:
storage/indexeddb/cursor-continue-dir-private.html:
storage/indexeddb/cursor-continue-private.html:
storage/indexeddb/cursor-continue-validity-private.html:
storage/indexeddb/cursor-delete-private.html:
storage/indexeddb/cursor-finished-private.html:
storage/indexeddb/cursor-inconsistency-private.html:
storage/indexeddb/cursor-index-delete-private.html:
storage/indexeddb/cursor-key-order-private.html:
storage/indexeddb/cursor-leak-private.html:
storage/indexeddb/cursor-overloads-private.html:
storage/indexeddb/cursor-prev-no-duplicate-private.html:
storage/indexeddb/cursor-primary-key-order-private.html:
storage/indexeddb/cursor-properties-private.html:
storage/indexeddb/cursor-request-cycle-private.html:
storage/indexeddb/cursor-reverse-bug-private.html:
storage/indexeddb/cursor-skip-deleted-private.html:
storage/indexeddb/cursor-update-private.html:
storage/indexeddb/cursor-update-value-argument-required-private.html:
storage/indexeddb/cursor-value-private.html:
storage/indexeddb/database-basics-private.html:
storage/indexeddb/database-close-private.html:
storage/indexeddb/database-closepending-flag-private.html:
storage/indexeddb/database-deletepending-flag-private.html:
storage/indexeddb/database-name-undefined-private.html:
storage/indexeddb/database-odd-names-private.html:
storage/indexeddb/database-quota-private.html:
storage/indexeddb/database-wrapper-private.html:
storage/indexeddb/delete-closed-database-object-private.html:
storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private.html:
storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private.html:
storage/indexeddb/delete-range-private.html:
storage/indexeddb/deleteIndex-bug110792-private.html:
storage/indexeddb/deleteIndex-private.html:
storage/indexeddb/deleteObjectStore-name-argument-required-private.html:
storage/indexeddb/deleteObjectStore-null-name-private.html:
storage/indexeddb/deleted-objects-private.html:
storage/indexeddb/deletedatabase-blocked-private.html:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private.html:
storage/indexeddb/deletedatabase-not-blocked-private.html:
storage/indexeddb/deletedatabase-transaction-private.html:
storage/indexeddb/dont-commit-on-blocked-private.html:
storage/indexeddb/dont-wedge-private.html:
storage/indexeddb/duplicates-private.html:
storage/indexeddb/error-causes-abort-by-default-private.html:
storage/indexeddb/events-private.html:
storage/indexeddb/exception-in-event-aborts-private.html:
storage/indexeddb/exceptions-private.html:
storage/indexeddb/factory-cmp-private.html:
storage/indexeddb/factory-deletedatabase-private.html:
storage/indexeddb/get-keyrange-private.html:
storage/indexeddb/index-basics-private.html:
storage/indexeddb/index-count-private.html:
storage/indexeddb/index-cursor-private.html:
storage/indexeddb/index-duplicate-keypaths-private.html:
storage/indexeddb/index-get-key-argument-required-private.html:
storage/indexeddb/index-multientry-private.html:
storage/indexeddb/index-population-private.html:
storage/indexeddb/index-unique-private.html:
storage/indexeddb/interfaces-private.html:
storage/indexeddb/intversion-abort-in-initial-upgradeneeded-private.html:
storage/indexeddb/intversion-bad-parameters-private.html:
storage/indexeddb/intversion-blocked-private.html:
storage/indexeddb/intversion-close-between-events-private.html:
storage/indexeddb/intversion-close-in-oncomplete-private.html:
storage/indexeddb/intversion-close-in-upgradeneeded-private.html:
storage/indexeddb/intversion-encoding-private.html:
storage/indexeddb/intversion-gated-on-delete-private.html:
storage/indexeddb/intversion-long-queue-private.html:
storage/indexeddb/intversion-omit-parameter-private.html:
storage/indexeddb/intversion-open-in-upgradeneeded-private.html:
storage/indexeddb/intversion-open-with-version-private.html:
storage/indexeddb/intversion-pending-version-changes-ascending-private.html:
storage/indexeddb/intversion-pending-version-changes-descending-private.html:
storage/indexeddb/intversion-pending-version-changes-same-private.html:
storage/indexeddb/intversion-persistence-private.html:
storage/indexeddb/intversion-revert-on-abort-private.html:
storage/indexeddb/intversion-two-opens-no-versions-private.html:
storage/indexeddb/intversion-upgrades-private.html:
storage/indexeddb/invalid-keys-private.html:
storage/indexeddb/key-generator-private.html:
storage/indexeddb/key-sort-order-across-types-private.html:
storage/indexeddb/key-sort-order-date-private.html:
storage/indexeddb/key-type-array-private.html:
storage/indexeddb/key-type-binary-private.html:
storage/indexeddb/key-type-infinity-private.html:
storage/indexeddb/keypath-arrays-private.html:
storage/indexeddb/keypath-basics-private.html:
storage/indexeddb/keypath-edges-private.html:
storage/indexeddb/keypath-fetch-key-private.html:
storage/indexeddb/keypath-intrinsic-properties-private.html:
storage/indexeddb/keyrange-private.html:
storage/indexeddb/keyrange-required-arguments-private.html:
storage/indexeddb/lazy-index-population-private.html:
storage/indexeddb/lazy-index-types-private.html:
storage/indexeddb/legacy-constants-private.html:
storage/indexeddb/list-ordering-private.html:
storage/indexeddb/metadata-private.html:
storage/indexeddb/metadata-race-private.html:
storage/indexeddb/modern/abort-objectstore-info-private.html:
storage/indexeddb/modern/abort-requests-cancelled-private.html:
storage/indexeddb/modern/aborted-put-private.html:
storage/indexeddb/modern/autoincrement-abort-private.html:
storage/indexeddb/modern/basic-add-private.html:
storage/indexeddb/modern/basic-put-private.html:
storage/indexeddb/modern/binary-keys-1-private.html:
storage/indexeddb/modern/blocked-open-db-requests-private.html:
storage/indexeddb/modern/create-index-failures-private.html:
storage/indexeddb/modern/createobjectstore-basic-private.html:
storage/indexeddb/modern/createobjectstore-failures-private.html:
storage/indexeddb/modern/cursor-1-private.html:
storage/indexeddb/modern/cursor-2-private.html:
storage/indexeddb/modern/cursor-3-private.html:
storage/indexeddb/modern/cursor-4-private.html:
storage/indexeddb/modern/cursor-5-private.html:
storage/indexeddb/modern/cursor-6-private.html:
storage/indexeddb/modern/cursor-7-private.html:
storage/indexeddb/modern/cursor-8-private.html:
storage/indexeddb/modern/date-basic-private.html:
storage/indexeddb/modern/deletedatabase-1-private.html:
storage/indexeddb/modern/deletedatabase-2-private.html:
storage/indexeddb/modern/deletedatabase-null-name-exception-private.html:
storage/indexeddb/modern/deletedatabase-request-event-private.html:
storage/indexeddb/modern/deletedatabase-request-private.html:
storage/indexeddb/modern/deleteindex-1-private.html:
storage/indexeddb/modern/deleteindex-2-private.html:
storage/indexeddb/modern/deleteindex-3-private.html:
storage/indexeddb/modern/deleteindex-4-private.html:
storage/indexeddb/modern/deleteobjectstore-1-private.html:
storage/indexeddb/modern/double-abort-private.html:
storage/indexeddb/modern/double-open-private.html:
storage/indexeddb/modern/gc-closes-database-private.html:
storage/indexeddb/modern/get-index-failures-private.html:
storage/indexeddb/modern/get-keyrange-private.html:
storage/indexeddb/modern/idbcursor-continue-primary-key-1-private.html:
storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private.html:
storage/indexeddb/modern/idbdatabase-transaction-failures-private.html:
storage/indexeddb/modern/idbindex-getall-1-private.html:
storage/indexeddb/modern/idbindex-getallkeys-1-private.html:
storage/indexeddb/modern/idbindex-properties-basic-private.html:
storage/indexeddb/modern/idbkey-array-equality-private.html:
storage/indexeddb/modern/idbobjectstore-clear-1-private.html:
storage/indexeddb/modern/idbobjectstore-clear-2-private.html:
storage/indexeddb/modern/idbobjectstore-count-1-private.html:
storage/indexeddb/modern/idbobjectstore-count-failures-private.html:
storage/indexeddb/modern/idbobjectstore-delete-1-private.html:
storage/indexeddb/modern/idbobjectstore-delete-2-private.html:
storage/indexeddb/modern/idbobjectstore-delete-failures-private.html:
storage/indexeddb/modern/idbobjectstore-get-failures-private.html:
storage/indexeddb/modern/idbobjectstore-getall-1-private.html:
storage/indexeddb/modern/idbobjectstore-getallkeys-1-private.html:
storage/indexeddb/modern/idbobjectstore-getkey-1-private.html:
storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private.html:
storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html:
storage/indexeddb/modern/idbtransaction-objectstores-1-private.html:
storage/indexeddb/modern/index-1-private.html:
storage/indexeddb/modern/index-2-private.html:
storage/indexeddb/modern/index-3-private.html:
storage/indexeddb/modern/index-4-private.html:
storage/indexeddb/modern/index-5-private.html:
storage/indexeddb/modern/index-cursor-1-private.html:
storage/indexeddb/modern/index-cursor-2-private.html:
storage/indexeddb/modern/index-cursor-3-private.html:
storage/indexeddb/modern/index-get-count-basic-private.html:
storage/indexeddb/modern/index-get-count-failures-private.html:
storage/indexeddb/modern/index-rename-1-private.html:
storage/indexeddb/modern/keypath-basic-private.html:
storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private.html:
storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html:
storage/indexeddb/modern/objectstore-attributes-private.html:
storage/indexeddb/modern/objectstore-cursor-advance-failures-private.html:
storage/indexeddb/modern/objectstore-cursor-continue-failures-private.html:
storage/indexeddb/modern/objectstore-rename-1-private.html:
storage/indexeddb/modern/opencursor-failures-private.html:
storage/indexeddb/modern/opendatabase-request-event-private.html:
storage/indexeddb/modern/opendatabase-request-private.html:
storage/indexeddb/modern/opendatabase-success-after-versionchange-private.html:
storage/indexeddb/modern/opendatabase-versions-private.html:
storage/indexeddb/modern/request-readystate-private.html:
storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html:
storage/indexeddb/modern/transaction-scheduler-1-private.html:
storage/indexeddb/modern/transaction-scheduler-2-private.html:
storage/indexeddb/modern/transaction-scheduler-3-private.html:
storage/indexeddb/modern/transaction-scheduler-4-private.html:
storage/indexeddb/modern/transaction-scheduler-5-private.html:
storage/indexeddb/modern/transaction-scheduler-6-private.html:
storage/indexeddb/modern/transactions-stop-on-navigation-private.html:
storage/indexeddb/modern/versionchange-abort-then-reopen-private.html:
storage/indexeddb/modern/versionchange-event-private.html:
storage/indexeddb/mozilla/add-twice-failure-private.html:
storage/indexeddb/mozilla/autoincrement-indexes-private.html:
storage/indexeddb/mozilla/bad-keypath-private.html:
storage/indexeddb/mozilla/clear-private.html:
storage/indexeddb/mozilla/create-index-unique-private.html:
storage/indexeddb/mozilla/create-index-with-integer-keys-private.html:
storage/indexeddb/mozilla/create-objectstore-basics-private.html:
storage/indexeddb/mozilla/create-objectstore-null-name-private.html:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private.html:
storage/indexeddb/mozilla/cursor-mutation-private.html:
storage/indexeddb/mozilla/cursor-update-updates-indexes-private.html:
storage/indexeddb/mozilla/cursors-private.html:
storage/indexeddb/mozilla/delete-result-private.html:
storage/indexeddb/mozilla/event-source-private.html:
storage/indexeddb/mozilla/global-data-private.html:
storage/indexeddb/mozilla/index-prev-no-duplicate-private.html:
storage/indexeddb/mozilla/indexes-private.html:
storage/indexeddb/mozilla/key-requirements-delete-null-key-private.html:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-private.html:
storage/indexeddb/mozilla/key-requirements-private.html:
storage/indexeddb/mozilla/key-requirements-put-no-key-private.html:
storage/indexeddb/mozilla/key-requirements-put-null-key-private.html:
storage/indexeddb/mozilla/object-cursors-private.html:
storage/indexeddb/mozilla/object-identity-private.html:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private.html:
storage/indexeddb/mozilla/object-store-remove-values-private.html:
storage/indexeddb/mozilla/objectstorenames-private.html:
storage/indexeddb/mozilla/odd-result-order-private.html:
storage/indexeddb/mozilla/open-database-null-name-private.html:
storage/indexeddb/mozilla/put-get-values-private.html:
storage/indexeddb/mozilla/readonly-transactions-private.html:
storage/indexeddb/mozilla/readwrite-transactions-private.html:
storage/indexeddb/mozilla/readyState-private.html:
storage/indexeddb/mozilla/remove-index-private.html:
storage/indexeddb/mozilla/remove-objectstore-private.html:
storage/indexeddb/mozilla/versionchange-abort-private.html:
storage/indexeddb/mutating-cursor-private.html:
storage/indexeddb/object-lookups-in-versionchange-private.html:
storage/indexeddb/objectStore-required-arguments-private.html:
storage/indexeddb/objectstore-autoincrement-private.html:
storage/indexeddb/objectstore-basics-private.html:
storage/indexeddb/objectstore-clear-private.html:
storage/indexeddb/objectstore-count-private.html:
storage/indexeddb/objectstore-cursor-private.html:
storage/indexeddb/objectstore-removeobjectstore-private.html:
storage/indexeddb/odd-strings-private.html:
storage/indexeddb/open-bad-versions-private.html:
storage/indexeddb/open-cursor-private.html:
storage/indexeddb/open-during-transaction-private.html:
storage/indexeddb/open-ordering-private.html:
storage/indexeddb/opencursor-key-private.html:
storage/indexeddb/optional-arguments-private.html:
storage/indexeddb/pending-activity-private.html:
storage/indexeddb/pending-version-change-on-exit-private.html:
storage/indexeddb/pending-version-change-stuck-private.html:
storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html:
storage/indexeddb/persistence-private.html:
storage/indexeddb/prefetch-bugfix-108071-private.html:
storage/indexeddb/prefetch-invalidation-private.html:
storage/indexeddb/prefetch-race-private.html:
storage/indexeddb/primary-key-unique-to-objectstore-private.html:
storage/indexeddb/queued-commands-private.html:
storage/indexeddb/readonly-private.html:
storage/indexeddb/readonly-properties-private.html:
storage/indexeddb/removed-private.html:
storage/indexeddb/request-continue-abort-private.html:
storage/indexeddb/request-event-propagation-private.html:
storage/indexeddb/request-leak-private.html:
storage/indexeddb/request-result-cache-private.html:
storage/indexeddb/set_version_blocked-private.html:
storage/indexeddb/setversion-blocked-by-versionchange-close-private.html:
storage/indexeddb/setversion-not-blocked-private.html:
storage/indexeddb/structured-clone-private.html:
storage/indexeddb/transaction-abort-private.html:
storage/indexeddb/transaction-active-flag-private.html:
storage/indexeddb/transaction-after-close-private.html:
storage/indexeddb/transaction-and-objectstore-calls-private.html:
storage/indexeddb/transaction-basics-private.html:
storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private.html:
storage/indexeddb/transaction-complete-with-js-recursion-private.html:
storage/indexeddb/transaction-complete-workers-private.html:
storage/indexeddb/transaction-coordination-across-databases-private.html:
storage/indexeddb/transaction-coordination-within-database-private.html:
storage/indexeddb/transaction-crash-in-tasks-private.html:
storage/indexeddb/transaction-crash-on-abort-private.html:
storage/indexeddb/transaction-error-private.html:
storage/indexeddb/transaction-event-propagation-private.html:
storage/indexeddb/transaction-ordering-private.html:
storage/indexeddb/transaction-overlapping-private.html:
storage/indexeddb/transaction-read-only-private.html:
storage/indexeddb/transaction-readwrite-exclusive-private.html:
storage/indexeddb/transaction-rollback-private.html:
storage/indexeddb/transaction-scope-sequencing-private.html:
storage/indexeddb/transaction-storeNames-required-private.html:
storage/indexeddb/unblocked-version-changes-private.html:
storage/indexeddb/unprefix-private.html:
storage/indexeddb/value-undefined-private.html:
storage/indexeddb/values-odd-types-private.html:
storage/indexeddb/version-change-abort-private.html:
storage/indexeddb/version-change-event-basic-private.html:
storage/indexeddb/version-change-event-private.html:
storage/indexeddb/version-change-exclusive-private.html:
storage/indexeddb/versionchangerequest-activedomobject-private.html:

9:51 PM Changeset in webkit [249562] by Chris Dumez

3 edits
1 copy
1 add in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cache/disk-cache/disk-cache-vary-cookie.html
https://bugs.webkit.org/show_bug.cgi?id=201524

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() as it does not do the right thing for WebKit2.
Instead, use the new useEphemeralSession WKTR flag added in r249542.

http/tests/cache/disk-cache/disk-cache-vary-cookie-expected.txt:
http/tests/cache/disk-cache/disk-cache-vary-cookie-private-expected.txt: Added.
http/tests/cache/disk-cache/disk-cache-vary-cookie-private.html: Copied from LayoutTests/http/tests/cache/disk-cache/disk-cache-vary-cookie.html.
http/tests/cache/disk-cache/disk-cache-vary-cookie.html:

9:37 PM Changeset in webkit [249561] by Chris Dumez

5 edits
2 adds in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html
https://bugs.webkit.org/show_bug.cgi?id=201523

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html
since it does not do the right thing for WebKit2. Instead, use the new useEphemeralSession
WKTR flag.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:
plugins/non-private-browsing-mode-expected.txt: Added.
plugins/non-private-browsing-mode.html: Added.
plugins/private-browsing-mode-expected.txt:
plugins/private-browsing-mode.html:

7:38 PM Changeset in webkit [249560] by Fujii Hironori

5 edits in trunk/Source

[Win] Add support for MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=201445

Reviewed by Brent Fulgham.

Source/WebCore:

Spec: <https://www.w3.org/TR/uievents/#dom-mouseevent-buttons>

platform/win/GDIUtilities.h:

(buttonsForEvent): Added.

platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Set m_buttons.

Source/WebKit:

Shared/win/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
Set m_buttons.

6:48 PM Changeset in webkit [249559] by Fujii Hironori

5 edits in trunk

[Win] Support Per-Monitor (V2) DPI Awareness
https://bugs.webkit.org/show_bug.cgi?id=201450

Reviewed by Don Olmstead.

Source/WebCore:

platform/win/GDIUtilities.cpp:

(WebCore::deviceScaleFactorForWindow): Use GetDpiForWindow if available by using soft linking.

Tools:

MiniBrowser/win/MainWindow.cpp:

(MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.

MiniBrowser/win/WinMain.cpp:

(wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.

6:45 PM Changeset in webkit [249558] by Fujii Hironori

2 edits in trunk/Source/WebKitLegacy/win

[WinCairo][WK1] ASSERTION FAILED: !isAcceleratedCompositing() in WebView::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=201493

Reviewed by Don Olmstead.

WebView::paint switches painting code path by checking accelerated
compositing enabled. However, accelerated compositing could be
enabled after the checking.

WebView::paint called WebView::paintCompositedContentToHDC and
WebCore::Page::updateRendering.
WebView::paintCompositedContentToHDC checks accelerated
compositing enabled. Then, WebCore::Page::updateRendering executes
JavaScript and accelerated compositing could be enabled.

WebView.cpp:

(WebView::paint): Call WebCore::Page::updateRendering the
beginning of the function.

6:07 PM Changeset in webkit [249557] by Chris Dumez

5 edits in trunk

REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=201440
<rdar://problem/54998427>

Reviewed by Alex Christensen.

Source/WebKit:

Add private WKBundlePage API to query if the WebPage is currently suspended or not.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageIsSuspended):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
created in the WebContent process is the one that is currently running the test and that we want to talk to.
Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::page const):

5:03 PM Changeset in webkit [249556] by mark.lam@apple.com

12 edits in trunk/Source

Refactor the Gigacage code to require less pointer casting.
https://bugs.webkit.org/show_bug.cgi?id=201521

Reviewed by Saam Barati.

Source/bmalloc:

Define a Gigacage::Config struct instead of hacking around a g_gigacageBasePtrs array of bytes.
Change Gigacage::basePtr() to return a pointer instead of a reference to the requested basePtr. Instead, make it explicit when the client is trying to take the address of the basePtr, or setting it.
Renamed wasEnabled() to isEnabled() because it returns the present state of the flag, not some past state.

bmalloc/Gigacage.cpp:

(Gigacage::bmalloc::protectGigacageBasePtrs):
(Gigacage::bmalloc::unprotectGigacageBasePtrs):
(Gigacage::bmalloc::runwaySize):
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::primitiveGigacageDisabled):

bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::Config::basePtr const):
(Gigacage::Config::setBasePtr):
(Gigacage::isEnabled):
(Gigacage::basePtr):
(Gigacage::addressOfBasePtr):
(Gigacage::size):
(Gigacage::caged):
(Gigacage::wasEnabled): Deleted.
(Gigacage::setWasEnabled): Deleted.
(Gigacage::basePtrs): Deleted.

bmalloc/HeapKind.h:

(bmalloc::heapKind):
(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):

Source/JavaScriptCore:

Change LLInt's loadCagedJSValue() to skip the caging if Gigacage is not enabled
in the build. This allows us to remove the unneeded stubs in WTF Gigacage.h.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cageConditionally):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

Source/WTF:

Remove some unneeded stubs in WTF Gigacage.h.

wtf/Gigacage.cpp:
wtf/Gigacage.h:

(Gigacage::name):
(Gigacage::isEnabled):
(Gigacage::basePtr): Deleted.
(Gigacage::basePtrs): Deleted.

4:42 PM Changeset in webkit [249555] by Justin Fan

7 edits
1 add in trunk/LayoutTests

[WebGPU] Fix new test results after adding console warnings
https://bugs.webkit.org/show_bug.cgi?id=201526

Unreviewed test expectation updates.

webgpu/buffer-errors-expected.txt:
webgpu/map-read-buffers-expected.txt:
webgpu/map-write-buffers-expected.txt:
webgpu/render-pipelines.html: Fix WHLSL compile error.
webgpu/uncaptured-errors-expected.txt: Added.
webgpu/whlsl/use-undefined-variable-2-expected.txt:
webgpu/whlsl/use-undefined-variable-expected.txt:

4:37 PM Changeset in webkit [249554] by Jonathan Bedard

5 edits in trunk/Tools

results.webkit.org: Assign notifyRerender before calling
https://bugs.webkit.org/show_bug.cgi?id=201510

Reviewed by Aakash Jain.

Timelines should define notifyRerender to an empty function,
rename notifiyRerender to notifyRerender.

resultsdbpy/resultsdbpy/view/static/js/timeline.js:
resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
resultsdbpy/resultsdbpy/view/templates/search.html:
resultsdbpy/resultsdbpy/view/templates/suite_results.html:

4:21 PM Changeset in webkit [249553] by Ryan Haddad

3 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181837

Unreviewed test gardening.

platform/ios/TestExpectations: Mark test as flaky.
platform/mac/TestExpectations: Ditto.

4:21 PM Changeset in webkit [249552] by ysuzuki@apple.com

4 edits in trunk/Source/JavaScriptCore

Unreviewed, follow-up after r249530 and r249509
https://bugs.webkit.org/show_bug.cgi?id=201495

Rename FTLOutput::weakPointer to alreadyRegisteredWeakPointer and alreadyRegisteredFrozenPointer.

builtins/PromiseConstructor.js:

(nakedConstructor.Promise.resolve):
(nakedConstructor.Promise.reject):
(nakedConstructor.Promise):
(nakedConstructor.InternalPromise.resolve):
(nakedConstructor.InternalPromise.reject):
(nakedConstructor.InternalPromise):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::weakPointer):
(JSC::FTL::DFG::LowerDFGToB3::frozenPointer):
(JSC::FTL::DFG::LowerDFGToB3::weakStructure):

ftl/FTLOutput.h:

(JSC::FTL::Output::alreadyRegisteredWeakPointer):
(JSC::FTL::Output::alreadyRegisteredFrozenPointer):
(JSC::FTL::Output::weakPointer): Deleted.

4:16 PM Changeset in webkit [249551] by Kocsen Chung

3 edits
2 adds in branches/safari-608.2.11.1-branch

Cherry-pick r249534. rdar://problem/55084674

AX: children cache are not re-computed if tab index is removed
https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

accessibility/tabindex-removed-expected.txt: Added.
accessibility/tabindex-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:08 PM Changeset in webkit [249550] by Kocsen Chung

8 edits
2 adds in branches/safari-608-branch

Apply patch. rdar://problem/55001140

Treat a two-finger single tap as if the user tapped with the Cmd key pressed https://bugs.webkit.org/show_bug.cgi?id=201420 <rdar://problem/53207786>

Reviewed by Simon Fraser.

Source/WebKit:

Set the metaKey modifier to true when generating a click event based on a two-finger single tap. This is important so that sites like Google and DuckDuckGo
correctly open links in their search results page in a new tab in Safari on iOS. This currently doesn't work because those sites will call preventDefault()
if the metaKey flag isn't set on a "click" event, and if it is set, they let the browser handle the navigation themselves.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _twoFingerSingleTapGestureRecognized:]):

Tools:

Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
-[HIDEventGenerator twoFingerTap:completionBlock:].

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::twoFingerSingleTapAtPoint):
WebKitTestRunner/ios/UIScriptControllerIOS.h:
WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):

LayoutTests:

Add a new event that checks that a two-finger single tap on a clickable element yields a "click" event with the metaKey flag set to true.

fast/events/ios/click-event-two-finger-single-tap-meta-key-expected.txt: Added.
fast/events/ios/click-event-two-finger-single-tap-meta-key.html: Added.

4:03 PM Changeset in webkit [249549] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Fix prepending search result on empty list
https://bugs.webkit.org/show_bug.cgi?id=201512

Reviewed by Aakash Jain.

resultsdbpy/resultsdbpy/view/templates/search.html:

2:58 PM Changeset in webkit [249548] by cturner@igalia.com

11 edits in trunk/Source/WebCore

[EME] Introduce a Proxy CDM for thread-safe access to CDM instances from background decryption threads
https://bugs.webkit.org/show_bug.cgi?id=201339

Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

platform/encryptedmedia/CDMInstance.h:
platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::isolatedKey):
(WebCore::ProxyCDMClearKey::isolatedKeys const):
(WebCore::CDMInstanceClearKey::CDMInstanceClearKey):

platform/encryptedmedia/clearkey/CDMClearKey.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):

platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(handleKeyResponse):
(findAndSetKey):
(decrypt):

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(isCDMInstanceAvailable):
(sinkEventHandler):
(setContext):

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstance::proxyCDM const):

testing/MockCDMFactory.h:

2:48 PM Changeset in webkit [249547] by ysuzuki@apple.com

39 edits
1 copy
1 add in trunk/Source/JavaScriptCore

[JSC] Generalize Get/PutPromiseInternalField for InternalFieldObjectImpl
https://bugs.webkit.org/show_bug.cgi?id=201513

Reviewed by Ross Kirsling.

This patch extracts JSPromise's internal fields mechanism as JSInternalFieldsObjectImpl, and make it reusable for the other objects.
It is preparation for using this internal fields mechanism for generators, async functions, async generators, array iterators and so on.

The profiler is telling many recompilation of Generator's resume function (including async generator's one). We are using properties
with private-symbols as a storage for internal state of generators. However, the spec defines that each generator from different generator-functions
has different Prototype. While we need to share one Generator.prototype.next function, generators tend to have different Structures due to
different Prototype and accessing internal fields with get_by_id_direct sadly becomes super megamorphic while it is not necessary.
And every time new Structure for new generator pops up, DFG/FTL code for generator resume function gets OSR exit or eventually this function gets
emits super generic code unfortunately. By using internal fields for storing these state, we can avoid this performance problem.

Bytecodes and corresponding DFG nodes are just renamed. JSPromise is now inheriting JSInternalFieldsObjectImpl, which can holds specified
number of internal fields. And op_get_internal_field / op_put_internal_field can access these internal fields.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.rb:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetInternalField):
(JSC::BytecodeGenerator::emitPutInternalField):
(JSC::BytecodeGenerator::emitGetPromiseInternalField): Deleted.
(JSC::BytecodeGenerator::emitPutPromiseInternalField): Deleted.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_getPromiseInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putPromiseInternalField):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGMayExit.cpp:
dfg/DFGNode.h:

(JSC::DFG::Node::hasInternalFieldIndex):
(JSC::DFG::Node::hasHeapPrediction):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetInternalField):
(JSC::DFG::SpeculativeJIT::compilePutInternalField):
(JSC::DFG::SpeculativeJIT::compileCreatePromise):
(JSC::DFG::SpeculativeJIT::compileNewPromise):
(JSC::DFG::SpeculativeJIT::compileGetPromiseInternalField): Deleted.
(JSC::DFG::SpeculativeJIT::compilePutPromiseInternalField): Deleted.

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStoreBarrierInsertionPhase.cpp:
ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewPromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileGetInternalField):
(JSC::FTL::DFG::LowerDFGToB3::compilePutInternalField):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPromiseInternalField): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::compilePutPromiseInternalField): Deleted.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emit_op_get_promise_internal_field): Deleted.
(JSC::JIT::emit_op_put_promise_internal_field): Deleted.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emit_op_get_promise_internal_field): Deleted.
(JSC::JIT::emit_op_put_promise_internal_field): Deleted.

llint/LLIntOffsetsExtractor.cpp:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSInternalFieldObjectImpl.h: Copied from Source/JavaScriptCore/runtime/JSPromise.h.

(JSC::JSInternalFieldObjectImpl::allocationSize):
(JSC::JSInternalFieldObjectImpl::internalField const):
(JSC::JSInternalFieldObjectImpl::internalField):
(JSC::JSInternalFieldObjectImpl::offsetOfInternalFields):
(JSC::JSInternalFieldObjectImpl::offsetOfInternalField):
(JSC::JSInternalFieldObjectImpl::JSInternalFieldObjectImpl):

runtime/JSInternalFieldObjectImplInlines.h: Added.

(JSC::JSInternalFieldObjectImpl<passedNumberOfInternalFields>::visitChildren):

runtime/JSPromise.cpp:

(JSC::JSPromise::finishCreation):
(JSC::JSPromise::visitChildren):
(JSC::JSPromise::status const):
(JSC::JSPromise::result const):
(JSC::JSPromise::isHandled const):

runtime/JSPromise.h:

(JSC::JSPromise::allocationSize): Deleted.
(JSC::JSPromise::offsetOfInternalFields): Deleted.
(JSC::JSPromise::offsetOfInternalField): Deleted.
(): Deleted.

2:44 PM Changeset in webkit [249546] by Jonathan Bedard

4 edits in trunk/Tools

results.webkit.org: Retain certain parameters when following menu links
https://bugs.webkit.org/show_bug.cgi?id=201463

Rubber-stamped by Aakash Jain.

resultsdbpy/resultsdbpy/view/site_menu.py:

(SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.

resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,

retain the specified parameters

resultsdbpy/resultsdbpy/view/view_routes.py:

(ViewRoutes.init):

2:29 PM Changeset in webkit [249545] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC] LayoutState should not need the initial containing block
https://bugs.webkit.org/show_bug.cgi?id=201511
<rdar://problem/55079241>

Reviewed by Antti Koivisto.

Throw-away layouts should just be able to initialize a dedicated LayoutState without passing in the ICB.

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::markNeedsUpdate):
(WebCore::Layout::LayoutState::run):
(WebCore::Layout::LayoutState::LayoutState): Deleted.

layout/LayoutState.h:

(WebCore::Layout::LayoutState::initialContainingBlock const): Deleted.

layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

layout/floats/FloatingContext.cpp: Fix a (very sad)typo.

(WebCore::Layout::FloatingContext::constraints const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::printLayoutTreeForLiveDocuments):

2:19 PM Changeset in webkit [249544] by russell_e@apple.com

3 edits in trunk/LayoutTests

Layout Test media/audio-concurrent-supported.html is a flaky failure.
rdar://55081191

Unreviewed Test Gardening.

platform/ios/TestExpectations:
platform/mac/TestExpectations:

2:13 PM Changeset in webkit [249543] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r247463.
https://bugs.webkit.org/show_bug.cgi?id=201515

JetStream2 code-load related regression (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"Keyword lookup can use memcmp to get around unaligned load
undefined behavior"
https://bugs.webkit.org/show_bug.cgi?id=199650
https://trac.webkit.org/changeset/247463

2:12 PM Changeset in webkit [249542] by Chris Dumez

62 edits in trunk

[WK2] Add proper layout test support for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=201475

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

IndexedDB-private-browsing/support.js:

Tools:

Add proper layout test support for ephemeral sessions via:

This actually creates a new WebView using an ephemeral data store to load the test which
is *true* private browsing.

testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
process, which is a hack and does not truly enable private browsing because the UIProcess and
the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
get rid of it.

Note that WK2 does not support using a WebContent process for different sessions / data stores.
Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
simply to support testRunner.setPrivateBrowsingEnabled().

DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

DumpRenderTree/TestOptions.h:
DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

LayoutTests:

Update existing layout tests to either switch to the new mechanism when trivial or to rename
setPrivateBrowsingEnabled() to setPrivateBrowsingEnabled_DEPRECATED() when it is not.

crypto/subtle/rsa-indexeddb-non-exportable-private.html:
crypto/subtle/rsa-indexeddb-private.html:
http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
http/tests/adClickAttribution/resources/util.js:

(tearDownAndFinish):

http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
http/tests/cache-storage/cache-persistency.https.html:
http/tests/cache-storage/cache-representation.https.html:
http/tests/cache/disk-cache/disk-cache-vary-cookie.html:
http/tests/cookies/private-cookie-storage.html:
http/tests/media/now-playing-info-private-browsing.html:
http/tests/security/appcache-in-private-browsing.html:
http/tests/security/appcache-switching-private-browsing.html:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.php:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.php:
http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.php:
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt:
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.php:
http/tests/security/cookies/resources/first-party-cookie-allow.xsl:
http/tests/security/cookies/resources/third-party-cookie-blocking.xsl:
http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
http/tests/security/cookies/third-party-cookie-blocking-redirect.html:
http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
http/tests/security/cookies/third-party-cookie-blocking.html:
http/tests/security/cross-frame-access-private-browsing.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
http/tests/security/private-browsing-http-auth.html:
http/tests/security/storage-blocking-loosened-private-browsing-plugin.html:
http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html:
http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html:
http/tests/security/strip-referrer-to-origin-for-third-party-requests-in-private-mode.html:
http/tests/storageAccess/has-storage-access-true-if-feature-off.html:
http/tests/workers/service/resources/basic-register.js:

(async.test):

http/tests/workers/service/serviceworker-private-browsing.https.html:
http/wpt/fetch/dnt-header-after-redirection.html:
platform/wk2/TestExpectations:
plugins/private-browsing-mode-2.html:
plugins/private-browsing-mode.html:
resources/js-test.js:
storage/domstorage/localstorage/private-browsing-affects-storage.html:
storage/domstorage/localstorage/resources/private-browsing-1.html:
storage/domstorage/localstorage/resources/private-browsing-2.html:
storage/indexeddb/open-db-private-browsing.html:
storage/indexeddb/resources/open-db-private-browsing.js:
storage/websql/private-browsing-noread-nowrite.html:
storage/websql/private-browsing-open-disabled.html:

2:01 PM Changeset in webkit [249541] by Kocsen Chung

1 copy in tags/Safari-609.1.3.2

Tag Safari-609.1.3.2.

1:55 PM Changeset in webkit [249540] by Kocsen Chung

7 edits in tags/Safari-609.1.3.1/Source

Versioning.

12:21 PM Changeset in webkit [249539] by Justin Fan

22 edits
4 copies
1 add in trunk

[WebGPU] Implement GPUUncapturedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=199676

Reviewed by Dean Jackson.

Source/WebCore:

Implement GPUUncapturedErrorEvent and "uncapturederror" event name.
Add the onuncapturederror EventHandler attribute to GPUDevice.

Test: webgpu/uncaptured-errors.html

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webgpu/GPUUncapturedErrorEvent.cpp:

(WebCore::GPUUncapturedErrorEvent::create):
(WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent):
(WebCore::GPUUncapturedErrorEvent::eventInterface const):

Modules/webgpu/GPUUncapturedErrorEvent.h:
Modules/webgpu/GPUUncapturedErrorEvent.idl:
Modules/webgpu/WebGPUAdapter.cpp: Must now provide ScriptExecutionContext to any created GPUDevice.

(WebCore::WebGPUAdapter::requestDevice const):

Modules/webgpu/WebGPUAdapter.h:
Modules/webgpu/WebGPUAdapter.idl:
Modules/webgpu/WebGPUDevice.cpp: Is now an EventTarget.

(WebCore::WebGPUDevice::tryCreate):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::printValidationErrorToConsole):
(WebCore::WebGPUDevice::dispatchUncapturedError): Events should only be fired from the main thread.

Modules/webgpu/WebGPUDevice.h:
Modules/webgpu/WebGPUDevice.idl:
Modules/webgpu/WebGPUDeviceEventHandler.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventNames.h:
dom/EventNames.in:
dom/EventTargetFactory.in:
platform/graphics/gpu/GPUError.cpp: GPUErrors can only be created internally; creation should never fail.

(WebCore::createError):

platform/graphics/gpu/GPUError.h:
platform/graphics/gpu/GPUErrorScopes.cpp:

(WebCore::GPUErrorScopes::create):
(WebCore::GPUErrorScopes::GPUErrorScopes):
(WebCore::GPUErrorScopes::generateError): Use a callback for now, since GPUErrorScopes is still under platform.

platform/graphics/gpu/GPUErrorScopes.h:

(WebCore::GPUErrorScopes::create): Deleted.

LayoutTests:

Add a test to ensure GPUUncapturedErrorEvents work.

webgpu/uncaptured-errors.html: Added.

11:47 AM Changeset in webkit [249538] by Tadeu Zagallo

5 edits
1 add in trunk

LazyClassStructure::setConstructor should not store the constructor to the global object
https://bugs.webkit.org/show_bug.cgi?id=201484
<rdar://problem/50400451>

Reviewed by Yusuke Suzuki.

JSTests:

stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.

Source/JavaScriptCore:

LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.

globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;

runtime/LazyClassStructure.cpp:

(JSC::LazyClassStructure::Initializer::setConstructor):

runtime/LazyClassStructure.h:
runtime/Lookup.h:

(JSC::reifyStaticProperty):

11:29 AM Changeset in webkit [249537] by Ryan Haddad

2 edits in trunk/LayoutTests

[iOS] Layout Test imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html is failing
https://bugs.webkit.org/show_bug.cgi?id=201509

Unreviewed test gardening.

platform/ios-simulator/TestExpectations: Mark test as failing.

11:03 AM Changeset in webkit [249536] by Antti Koivisto

6 edits in trunk

Generate event region for both the main graphics layer and the scrolled contents layer
https://bugs.webkit.org/show_bug.cgi?id=201487

Reviewed by Simon Fraser.

Source/WebCore:

We currently generate region for one of them only. With borders both need it.

Also share more code with painting paths.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

Generate region for both layers.

(WebCore::RenderLayerBacking::paintIntoLayer):

Add event region context parameter so we can use this function for event region update too.

rendering/RenderLayerBacking.h:

LayoutTests:

pointerevents/ios/touch-action-region-backing-sharing-expected.txt:
pointerevents/ios/touch-action-region-overflow-expected.txt:

10:44 AM Changeset in webkit [249535] by rniwa@webkit.org

8 edits
3 adds in trunk

REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
https://bugs.webkit.org/show_bug.cgi?id=201490

Reviewed by Daniel Bates.

Source/WebCore:

The bug was caused by an element in the pasted content not having any explicit font name resolving
to use the font-family value of -webkit-standard. When such an inline style is inserted into
Mail's WKWebView which sets a different font family, ReplaceSelectionCommand would fail to strip away,
making the pasted content using the default font family of Times New Roman.

Fixed the bug by stripping away font-family set to -webkit-standard in the sanitization document
since that's indicative of the pasted content not having any font family being specified.

In the future, we should consider making regular copy (as opposed to the copy for sanitization)
resolve generic font family names to concrete font names since different WKWebView might be using
different concrete font names. Unfortuantely, such a change is quite involved and risky since various
paste side code in EditingStyle that removes redundant inline styles (i.e. redundant font-family)
need to be aware of this special font family resolution.

Tests: editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family.html

PasteHTML.DoesNotAddStandardFontFamily

editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::familyNameFromCSSPrimitiveValue): Added.
(WebCore::loneFontFamilyName): Extracted from usesForbiddenSystemFontAsOnlyFontFamilyName. Fixed
a bug that it was not handling the case when font-family property's value is a CSSPrimitiveValue
instead of a CSSValueList.
(WebCore::usesForbiddenSystemFontAsOnlyFontFamilyName): Deleted.
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Remove font-family property when
StandardFontFamilySerializationMode::Strip is specified and its value is -webkit-standard.

editing/EditingStyle.h:
editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Added
StandardFontFamilySerializationMode as an argument.
(WebCore::StyledMarkupAccumulator::appendStartTag):
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::serializePreservingVisualAppearanceInternal): Ditto.
(WebCore::serializePreservingVisualAppearance): Use StandardFontFamilySerializationMode::Keep
to preserve the pre-existing behavior.
(WebCore::sanitizedMarkupForFragmentInDocument): Use StandardFontFamilySerializationMode::Strip
as this is the code used by sanitization code.

Tools:

Added a test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.

LayoutTests:

Added a test to make sure -webkit-standard font family name isn't stripped away when sanitization is not in effect.

editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family-expected.txt: Added.
editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family.html: Added.

10:27 AM Changeset in webkit [249534] by Chris Fleizach

3 edits
2 adds in trunk

AX: children cache are not re-computed if tab index is removed
https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

accessibility/tabindex-removed-expected.txt: Added.
accessibility/tabindex-removed.html: Added.

10:11 AM Changeset in webkit [249533] by sihui_liu@apple.com

10 edits in trunk/Source/WebKit

Remove StorageArea pointers in StorageManagerSet when removing StorageManagers that own them
https://bugs.webkit.org/show_bug.cgi?id=201324

Reviewed by Alex Christensen.

NetworkProcess/WebStorage/LocalStorageNamespace.cpp:

(WebKit::LocalStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/LocalStorageNamespace.h:
NetworkProcess/WebStorage/SessionStorageNamespace.cpp:

(WebKit::SessionStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/SessionStorageNamespace.h:
NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::allStorageAreaIdentifiers const):

NetworkProcess/WebStorage/StorageManager.h:
NetworkProcess/WebStorage/StorageManagerSet.cpp:

(WebKit::StorageManagerSet::remove):

NetworkProcess/WebStorage/TransientLocalStorageNamespace.cpp:

(WebKit::TransientLocalStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/TransientLocalStorageNamespace.h:

10:01 AM Changeset in webkit [249532] by Michael Catanzaro

1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, update contributors.json

People are having trouble CCing me on Bugzilla.

I'm still at Igalia, but no longer working on WebKit.

Scripts/webkitpy/common/config/contributors.json:

9:56 AM Changeset in webkit [249531] by Konstantin Tokarev

3 edits in trunk/Source/WebCore

Don't call PlatformMediaSessionManager methods when neither VIDEO nor WEB_AUDIO is enabled
https://bugs.webkit.org/show_bug.cgi?id=201508

Reviewed by Jer Noble.

Definitions of these methods are guarded with #if ENABLE(VIDEO)

ENABLE(WEB_AUDIO),

so calling them causes linking errors.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldDeactivateAudioSession):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::processWillSuspend):
(WebCore::Internals::processDidResume):
(WebCore::Internals::setIsPlayingToAutomotiveHeadUnit):

8:51 AM Changeset in webkit [249530] by ysuzuki@apple.com

3 edits
1 add in trunk

[JSC] Do not use FTLOutput::weakPointer directly
https://bugs.webkit.org/show_bug.cgi?id=201495

Reviewed by Filip Pizlo.

JSTests:

stress/create-promise-weak-pointer.js: Added.

(foo):

Source/JavaScriptCore:

FTLOutput::weakPointer does not register the cell as a weak pointer.
CreatePromise's implementation is accidentally using m_out.weakPointer and hits the debug assertion.
While the current implementation is not posing correctness issue since these cells are live so long as JSGlobalObject is live,
and we register JSGlobalObject as a weakPointer, we should always use FTLLowerDFGToB3's helper function.
For FrozenValue, we should use frozenPointer helper function.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):

7:48 AM Changeset in webkit [249529] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

REGRESSION(r249275): [GTK][WPE] wrong page ID returned by webkit_web_view_get_page_id()
https://bugs.webkit.org/show_bug.cgi?id=201504

Reviewed by Michael Catanzaro.

We want to return the page identifier not the web page proxy id.

UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_get_page_id):

7:21 AM Changeset in webkit [249528] by Pablo Saavedra

2 edits in trunk/Source/WebKit

Build failure after r249501 for ports with SERVICE_WORKER set OFF
https://bugs.webkit.org/show_bug.cgi?id=201503

Reviewed by Youenn Fablet.

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

3:53 AM Changeset in webkit [249527] by Keith Rollin

2 edits in trunk/Source/WebCore

Fix implicit conversion that loses precision
https://bugs.webkit.org/show_bug.cgi?id=201476
<rdar://problem/55043129>

Reviewed by Youenn Fablet, Alex Christensen.

Building for watchOS results in the following error:

.../Source/WebCore/fileapi/NetworkSendQueue.cpp:66:42: error: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Werror,-Wshorten-64-to-32]

enqueue(JSC::ArrayBuffer::create(byteLength, 1), 0, 0);

Fix this by replacing byteLength (which is known to be zero at this
point) with 0U.

No new tests -- no new or changed functionality.

fileapi/NetworkSendQueue.cpp:

(WebCore::NetworkSendQueue::enqueue):

2:01 AM Changeset in webkit [249526] by youenn@apple.com

17 edits
2 adds in trunk

Introduce WorkerSWClientConnection to make SWClientConnection mono-thread
https://bugs.webkit.org/show_bug.cgi?id=201430

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Remove inserted iframes to make test outputs more stable.

web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
web-platform-tests/service-workers/service-worker/activation.https.html:
web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:
web-platform-tests/service-workers/service-worker/detached-context.https.html:

Source/WebCore:

Make SWClientConnection RefCounted.
Add a WorkerSWClientConnection dedicated to be used by worker/service worker contexts.
Simplify ServiceWorkerContainer logic based on this refactoring.

Covered by existing tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::swClientConnection):

workers/WorkerGlobalScope.h:
workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::postTaskForJob):

workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::mainThreadConnection):
(WebCore::ServiceWorkerContainer::ready):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::updateRegistrationState):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::notifyRegistrationIsSettled):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::notifyFailedFetchingScript):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):
(WebCore::ServiceWorkerContainer::stop):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::isolatedCopy const):

workers/service/WorkerSWClientConnection.cpp: Added.

(WebCore::WorkerSWClientConnection::WorkerSWClientConnection):
(WebCore::WorkerSWClientConnection::~WorkerSWClientConnection):
(WebCore::WorkerSWClientConnection::matchRegistration):
(WebCore::WorkerSWClientConnection::getRegistrations):
(WebCore::WorkerSWClientConnection::whenRegistrationReady):
(WebCore::WorkerSWClientConnection::addServiceWorkerRegistrationInServer):
(WebCore::WorkerSWClientConnection::removeServiceWorkerRegistrationInServer):
(WebCore::WorkerSWClientConnection::didResolveRegistrationPromise):
(WebCore::WorkerSWClientConnection::postMessageToServiceWorker):
(WebCore::WorkerSWClientConnection::serverConnectionIdentifier const):
(WebCore::WorkerSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
(WebCore::WorkerSWClientConnection::syncTerminateWorker):
(WebCore::WorkerSWClientConnection::registerServiceWorkerClient):
(WebCore::WorkerSWClientConnection::unregisterServiceWorkerClient):
(WebCore::WorkerSWClientConnection::finishFetchingScriptInServer):
(WebCore::WorkerSWClientConnection::isThrottleable const):
(WebCore::WorkerSWClientConnection::updateThrottleState):
(WebCore::WorkerSWClientConnection::scheduleJob):
(WebCore::WorkerSWClientConnection::scheduleJobInServer):

workers/service/WorkerSWClientConnection.h: Added.

12:47 AM Changeset in webkit [249525] by rniwa@webkit.org

2 edits
1 delete in trunk/Tools

Remove unused SPI that accesses MemoryCache directly
https://bugs.webkit.org/show_bug.cgi?id=201468

Reviewed by Youenn Fablet.

Removed the API test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.

Sep 4, 2019:

11:02 PM Changeset in webkit [249524] by Fujii Hironori

2 edits in trunk/Source/WebCore

[Win][Clang] InspectorNetworkAgent.cpp(1122,20): error: cannot decompose this type; 'std::tuple_size<const WTF::KeyValuePair<WTF::String, WTF::RefPtr<WTF::JSONImpl::Value, WTF::DumbPtrTraits<WTF::JSONImpl::Value> > >>::value' is not a valid integral const
https://bugs.webkit.org/show_bug.cgi?id=201489

Unreviewed build fix for clang-cl.

clang-cl 8 can't use a structured binding for a const struct.

No behavior change.

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptWithResponse): Not to use a structured binding for a const struct.

10:51 PM Changeset in webkit [249523] by ysuzuki@apple.com

16 edits in trunk/Source/JavaScriptCore

Unreviewed, partial roll out r249372 due to JetStream2/Basic ~10% regression
https://bugs.webkit.org/show_bug.cgi?id=201373

bytecode/BytecodeList.rb:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitLoopHint):
(JSC::BytecodeGenerator::emitCheckTraps):

bytecompiler/BytecodeGenerator.h:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_check_traps):
(JSC::JIT::emitSlow_op_check_traps):
(JSC::JIT::emitSlow_op_enter): Deleted.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_enter):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:

10:24 PM Changeset in webkit [249522] by Fujii Hironori

2 edits in trunk/LayoutTests

[AppleWin] fast/block/float/float-with-anonymous-previous-sibling.html is failing as flaky ImageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=201491

Unreviewed test gardening.

platform/win/TestExpectations: Marked it.

9:12 PM Changeset in webkit [249521] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari Technology Preview/Safari Technology Preview 91

Added a tag for Safari Technology Preview release 91.

9:01 PM Changeset in webkit [249520] by ysuzuki@apple.com

14 edits in trunk/Source/JavaScriptCore

Unreviewed, rebaseline builtin generator test results
https://bugs.webkit.org/show_bug.cgi?id=200898

Rebaseline the result files.

Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:

8:00 PM Changeset in webkit [249519] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, another build fix after r249501.

loader/EmptyFrameLoaderClient.h:

7:52 PM Changeset in webkit [249518] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] FunctionOverrides should have a lock to ensure concurrent access to hash table does not happen
https://bugs.webkit.org/show_bug.cgi?id=201485

Reviewed by Tadeu Zagallo.

FunctionOverrides is a per-process singleton for registering overrides information. But we are accessing
it without taking a lock. If multiple threads with multiple VMs are accessing this concurrently, we have
a race issue like,

While one thread is adding overrides information,
Another thread is accessing this hash table.

This patch adds a lock to make sure that only one thread can access this registry.

tools/FunctionOverrides.cpp:

(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::FunctionOverrides::initializeOverrideFor):
(JSC::FunctionOverrides::parseOverridesInFile):

tools/FunctionOverrides.h:

(JSC::FunctionOverrides::clear):

7:52 PM Changeset in webkit [249517] by timothy@apple.com

15 edits
3 adds in trunk

Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
https://bugs.webkit.org/show_bug.cgi?id=201368
rdar://problem/40529867

Reviewed by Ryosuke Niwa.

Source/WebCore:

Dark mode content that is pasted should have the inline styles inverse color
transformed by the color filter to match the color filtered document contents.

Layout Test: editing/pasteboard/paste-dark-mode-color-filtered.html
API Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,

PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent

editing/EditingStyle.cpp:

(WebCore::EditingStyle::inverseTransformColorIfNeeded): Added caret-color to the transformed properties.

editing/ReplaceSelectionCommand.cpp:

(WebCore::fragmentNeedsColorTransformed): Added.
(WebCore::ReplaceSelectionCommand::inverseTransformColor): Added.
(WebCore::ReplaceSelectionCommand::doApply): Call fragmentNeedsColorTransformed() and inverseTransformColor().

editing/ReplaceSelectionCommand.h:

Tools:

Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,

PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:

(createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.

TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:

(createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.

TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
TestWebKitAPI/cocoa/TestWKWebView.h:
TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView forceDarkMode]):

LayoutTests:

TestExpectations:
editing/pasteboard/paste-dark-mode-color-filtered-expected.txt: Added.
editing/pasteboard/paste-dark-mode-color-filtered.html: Added.
platform/ios-12/TestExpectations:
platform/ios/TestExpectations:
platform/mac/TestExpectations:

7:38 PM Changeset in webkit [249516] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, drop extra whitespace added in r249515.

loader/EmptyFrameLoaderClient.h:

7:36 PM Changeset in webkit [249515] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed build fix after r249501.

r249501 seems to have exposed the fact that EmptyFrameLoaderClient.h is missing a #pragma once.

loader/EmptyFrameLoaderClient.h:

7:36 PM Changeset in webkit [249514] by Wenson Hsieh

5 edits in trunk

MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
https://bugs.webkit.org/show_bug.cgi?id=201479
<rdar://problem/51511834>

Reviewed by Tim Horton.

Source/WebKit:

Fix the crash by making -_shareForWebView: robust in the case where there are no selection rects
known in the UI process when -[WKContentView _share:] is invoked.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _shareForWebView:]):

Tools:

Add a test to verify that the UI process doesn't crash when invoking _share: while there's no selection.

TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
TestWebKitAPI/ios/UIKitSPI.h:

7:20 PM WebKitGTK/2.26.x edited by Patrick Griffis

(diff)

7:15 PM Changeset in webkit [249513] by Devin Rousso

6 edits in trunk/Source/WebInspectorUI

Web Inspector: unify the interaction of show/hide status icons in Sources and Canvas
https://bugs.webkit.org/show_bug.cgi?id=201470

Reviewed by Joseph Pecoraro.

Rather than "fading" the tree element's text when the underlying represented object is
disabled/blackboxed, we should just "fade" the icon. The "fade" shouldn't change when the
tree element is selected. The image of the status eye also shouldn't change depending on
whether the underlying represented object is disabled/blackboxed, as it being visible (even
if it's "faded") is already enough of an indicator.

It should also be possible to toggle the disabled/blackboxed state via the context menu.

UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):

UserInterface/Views/SourceCodeTreeElement.css:

(.tree-outline:not(.navigation-sidebar-panel-content-tree-outline) .item .status > .toggle-script-blackboxed, .tree-outline .item:not(:hover) .status > .toggle-script-blackboxed:not(.blackboxed)): Added.
(.tree-outline:not(.navigation-sidebar-panel-content-tree-outline) .item .status > .toggle-script-blackboxed, .tree-outline .item:not(:hover, .selected) .status > .toggle-script-blackboxed:not(.blackboxed)): Deleted.

UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram):
(WI.ShaderProgram.prototype.get disabled): Added.
(WI.ShaderProgram.prototype.set disabled): Added.
(WI.ShaderProgram.prototype.toggleDisabled): Deleted.

UserInterface/Views/ShaderProgramTreeElement.js:

(WI.ShaderProgramTreeElement.prototype.onattach):
(WI.ShaderProgramTreeElement.prototype.ondetach): Added.
(WI.ShaderProgramTreeElement.prototype.canSelectOnMouseDown):
(WI.ShaderProgramTreeElement.prototype.populateContextMenu): Added.
(WI.ShaderProgramTreeElement.prototype._disabledImageElementClicked):
(WI.ShaderProgramTreeElement.prototype._handleShaderProgramDisabledChanged): Added.

UserInterface/Views/ShaderProgramTreeElement.css:

(.tree-outline .item.shader-program .status > img): Added.
(.tree-outline .item.shader-program:not(:hover, .selected, .disabled) .status > img): Added.
(.tree-outline .item.shader-program.disabled .status > img): Added.
(@media (prefers-color-scheme: dark) .tree-outline .item.shader-program .status > img): Added.
(.item.shader-program .status > img): Deleted.
(.item.shader-program.disabled:hover .status > img): Deleted.
(.item.shader-program:not(:hover, .selected, .disabled) .status > img): Deleted.
(.item.shader-program.disabled > :not(.status)): Deleted.
(@media (prefers-color-scheme: dark) .item.shader-program .status > img): Deleted.

7:11 PM Changeset in webkit [249512] by rniwa@webkit.org

4 edits in trunk/Source/WebKit

Replace defaultCustomPasteboardDataEnabled by an equivalent macro
https://bugs.webkit.org/show_bug.cgi?id=201477

Reviewed by Wenson Hsieh.

r227282 introduced defaultCustomPasteboardDataEnabled() to disable the custom pasteboard data on
apps linked against old SDKs. However, this had a bug that the check inside WebContent process
would always return true because WebContent process is always linked against the latest SDKs.
Because WebPreferences values aren't propagated from UI process to WebContent process unless
there is a value change, it meant that custom pasteboard data is always enabled.

This patch replaces this function with a simple macro which always enables the custom pasteboard
data on iOS family and macOS as it has always been the case before and after r227282.

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultCustomPasteboardDataEnabled): Deleted.

Shared/WebPreferencesDefaultValues.h:

6:39 PM Changeset in webkit [249511] by Simon Fraser

7 edits
2 adds in trunk

Cancelled transitions on Google image search leave content with opacity 0 sometimes
https://bugs.webkit.org/show_bug.cgi?id=201482
rdar://problem/54921036

Reviewed by Tim Horton.
Source/WebCore:

If, in a single rendering update, we started an accelerated opacity transition, and then removed
it, we'd still push the transition onto the CALayer with fillForwards and never remove it, so its
effects would last forever.

Fix by making GraphicsLayerCA::removeAnimation() remove animations from the uncomittedAnimations
list as well.

Also fix layer names in debug; if a layer's primaryLayerID changed, we'd fail to rename the
CALayer, causing confusion when logging at layer dumps. Fix by adding the layer ID just
before pushing the name to the platform layer.

Some drive-by logging cleanup.

Test: legacy-animation-engine/compositing/transitions/add-remove-transition.html

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::debugName const):

platform/graphics/GraphicsLayer.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setName):
(WebCore::GraphicsLayerCA::debugName const):
(WebCore::GraphicsLayerCA::addAnimation):
(WebCore::GraphicsLayerCA::pauseAnimation):
(WebCore::GraphicsLayerCA::seekAnimation):
(WebCore::GraphicsLayerCA::removeAnimation):
(WebCore::GraphicsLayerCA::platformCALayerAnimationStarted):
(WebCore::GraphicsLayerCA::platformCALayerAnimationEnded):
(WebCore::GraphicsLayerCA::updateNames):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

platform/graphics/ca/GraphicsLayerCA.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

LayoutTests:

legacy-animation-engine/compositing/transitions/add-remove-transition-expected.html: Added.
legacy-animation-engine/compositing/transitions/add-remove-transition.html: Added.

6:33 PM Changeset in webkit [249510] by Kocsen Chung

1 copy in tags/Safari-608.3.1

Tag Safari-608.3.1.

6:23 PM Changeset in webkit [249509] by ysuzuki@apple.com

117 edits
1 copy
21 adds in trunk

[JSC] Make Promise implementation faster
https://bugs.webkit.org/show_bug.cgi?id=200898

Reviewed by Saam Barati.

JSTests:

ChakraCore/test/UnitTestFramework/UnitTestFramework.js:

(assert.assert.return.throws):

modules/breaking-builtin-promise-then-does-not-break-internal-promise.js: Added.
modules/breaking-builtin-promise-then-does-not-break-internal-promise/test.js: Added.
stress/constructor-kind-naked-should-not-be-applied-to-inner-functions.js: Added.

(shouldThrow):
(new.Promise):
(shouldThrow.Promise):

stress/create-promise-should-respect-promise-realm.js: Added.

(shouldBe):
(other.new.OtherPromise):
(DerivedOtherPromise):
(i.promise.new.DerivedOtherPromise):
(createPromise):

stress/derived-promise-constructor-class-syntax-prototype-replace-attempt.js: Added.

(shouldBe):
(DerivedPromise):
(i.array.push.new.DerivedPromise):
(promise.new.DerivedPromise):

stress/derived-promise-constructor-inlined.js: Added.

(shouldBe):
(DerivedPromise):
(i.array.push.new.DerivedPromise):
(DerivedPromise.all.array.then):

stress/derived-promise-prototype-replaced.js: Added.

(shouldBe):
(DerivedPromise):
(i.array.push.new.DerivedPromise):
(promise.new.DerivedPromise):

stress/internal-promise-constructor-not-confusing.js: Added.

(shouldBe):
(InternalPromise.vm.createBuiltin):
(DerivedPromise):

stress/internal-promise-is-not-exposed.js: Added.

(shouldBe):

stress/new-promise-should-respect-promise-realm.js: Added.

(shouldBe):
(other.new.OtherPromise):
(createPromise):

stress/promise-cannot-be-called.js:

(shouldThrow):

stress/promise-capability-fast-path.js: Added.

(shouldBe):
(i.array.push.new.Promise):
(i.array.i.then):

stress/promise-capability-slow-path.js: Added.

(shouldBe):
(Promise.prototype.then):
(i.array.push.new.Promise):
(i.array.i.then):

stress/promise-capability-then-slow-path.js: Added.

(shouldBe):
(DerivedPromise):
(DerivedPromise.prototype.then):
(i.array.push.new.DerivedPromise):
(i.array.i.then):

stress/promise-constructor-inlined.js: Added.

(shouldBe):
(i.array.push.new.Promise):
(Promise.all.array.then):

stress/promise-constructor-transition-from-new-promise-to-create-promise.js: Added.

(shouldBe):
(DerivedPromise):
(DerivedPromise2):
(i.array.push.new.DerivedPromise):
(i.array2.push.new.DerivedPromise2):

stress/without-promise-functions.js: Added.

(shouldBe):
(async):

LayoutTests/imported/w3c:

web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/JavaScriptCore:

This is the major change of the Promise implementation and it improves JetStream2/async-fs by 62%.

Make JSPromise C++ friendly

Instead of using objects with private properties (properties with private symbols), we put internal fields in JSPromise.
This avoids allocating unnecessary butterflies for these private fields, and makes allocating JSPromise and accessing these
fields from C++ easy. Moreover, this patch reduces # of fields of JSPromise from 4 to 2 to make JSPromise compact. To access these internal
fields efficiently from JS, we add op_get_promise_internal_field and op_put_promise_internal_field bytecodes, and corresponding DFG/FTL
supports. They are similar to GetClosureVar / PutClosureVar implementation. These two bytecodes are intentionally generic to later expand
this support to generator and async-generator by renaming them to op_get_internal_field and op_put_internal_field. It is filed in [1].

We also add JSPromiseType as JSType. And structures for JSPromise should have that. So that now @isPromise is efficiently implemented.
This also requires adding SpecPromiseObject and PromiseObjectUse to DFG.

Further, by introducing another bit flag representing alreadyResolved to JSPromise's flags, we can remove JSPromiseDeferred. This extension
is filed in [2].

Make JSPromise constructor JS friendly

The old JSPromise constructor was very inefficient: JSPromise constructor is InternalFunction in C++, and in it, it
calls initializePromise JS function. And this initializePromise function invokes executor function passed by user program.
If we can implement JSPromise constructor fully in JS, we can recognize executor and we have a chance to fully inline them.
Unfortunately, we cannot inline JSPromise constructor for now since it takes 120 bytecode cost while our inlining threshold for
construct is 100. We might want to investigate getting it inlined in the future[3].

We can avoid C++ <-> JS dance in such an important operation, allocating JSPromise. This patch introduces @nakedConstructor
annotation to builtin JS. And this is propagated as ConstructorKind::Naked. If this kind is attached, the bytecode generator
do not emit op_create_this implicitly and the constructor does not return this object implicitly. The naked constructor allows
us to emit bare-metal bytecode, specifically necessary to allocate non-final JSObject from JS constructor. We introduce op_create_promise,
which is similar to op_create_this, but it allocates JSPromise. And by using @createPromise bytecode intrinsic, we implement
JSPromise constructor fully in JS.
With this, we can start introducing object-allocation-sinking for JSPromise too. It is filed in [4].

DFG supports for JSPromise operations

This patch adds four DFG nodes, CreatePromise, NewPromise, GetPromiseInternalField, and PutPromiseInternalField. CreatePromise mimics CreateThis,
and NewPromise mimics NewObject. CreatePromise can be converted to NewPromise with some condition checks and NewPromise can efficiently allocate
promises. CreatePromise and NewPromise have isInternalPromise flag so that InternalPromise is also correctly handled in DFG.
When converting CreatePromise to NewPromise, we need to get the correct structure with a specified callee.prototype. We mimic the mechanism
used in CreateThis, but we use InternalFunctionAllocationProfile instead of ObjectAllocationProfile because (1) InternalFunctionAllocationProfile
can handle non-final JSObjects and (2) we do not need to handle inline-capacity for promises. To make InternalFunctionAllocationProfile usable
in DFG, we connect watchpoint to InternalFunctionAllocationProfile's invalidation so that DFG code can notice when InternalFunctionAllocationProfile's
structure is invalidated: callee.prototype is replaced.

Avoid creating unnecessary promises

Some promises are never shown to users, and they are never rejected. One example is await's promise. And some of promise creation can be avoided.
For example, when resolving a value with Promise.resolve, if a value is promise and if it's then method is the builtin then, we can avoid creating
intermediate promise. To handle these things well, we introduce @resolveWithoutPromise, @rejectWithoutPromise, and @fulfillWithoutPromise. They
take onFulfilled and onRejected handlers and they do not need an intermediate promise for resolving. This removes internal promise allocations
in major cases and makes promise / async-functions efficient. And we also expose builtin then function as @then, and insert @isPromise(xxx) && then === @then
check to take a fast path. We introduced four types of promise reactions to avoid some of object allocations. And microtask reaction is handling these four types.

Avoid creating resolving-functions and promise capabilities

Resolving functions have alreadyResolved flag to prevent calling resolve and reject multiple times. For the first resolving function creation, this
patch embeds one bit flag to JSPromise itself which indicates alreadyResolved in the first created resolving functions (resolving functions can be later
created again for the same promise. In that case, we just create a usual resolving functions). By doing so, we avoid unnecessary resolving functions
and promise capability allocations. We introduce a wrapper function @resolvePromiseWithFirstResolvingFunctionCallCheck and @rejectPromiseWithFirstResolvingFunctionCallCheck.
The resolving functions which are first created with @newPromiseCapability can be mechanically replaced with the calls to these functions, e.g. replacing
promiseCapability.@resolve.@call(@undefined, value) with @resolvePromiseWithFirstResolvingFunctionCallCheck(promise, value).
This mechanism will be used to drop JSPromiseDeferred in a separate patch.

JetStream2/async-fs results.

ToT:

Running async-fs:

Startup: 116.279
Worst Case: 151.515
Average: 176.630
Score: 145.996
Wall time: 0:01.149

Patched:

Running async-fs:

Startup: 166.667
Worst Case: 267.857
Average: 299.080
Score: 237.235
Wall time: 0:00.683

[1]: https://bugs.webkit.org/show_bug.cgi?id=201159
[2]: https://bugs.webkit.org/show_bug.cgi?id=201160
[3]: https://bugs.webkit.org/show_bug.cgi?id=201452
[4]: https://bugs.webkit.org/show_bug.cgi?id=201158

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
Scripts/wkbuiltins/builtins_generate_combined_header.py:

(ConstructAbility):
(ConstructorKind):

Scripts/wkbuiltins/builtins_generate_separate_header.py:
Scripts/wkbuiltins/builtins_generator.py:

(BuiltinsGenerator.generate_embedded_code_data_for_function):
(BuiltinsGenerator.generate_embedded_code_string_section_for_data):

Scripts/wkbuiltins/builtins_model.py:

(BuiltinFunction.init):
(BuiltinFunction.fromString):

Scripts/wkbuiltins/builtins_templates.py:
builtins/AsyncFromSyncIteratorPrototype.js:

(next.try):
(next):
(return.try):
(return):
(throw.try):
(throw):

builtins/AsyncFunctionPrototype.js:

(globalPrivate.asyncFunctionResume):

builtins/AsyncGeneratorPrototype.js:

(globalPrivate.asyncGeneratorQueueIsEmpty):
(globalPrivate.asyncGeneratorQueueEnqueue):
(globalPrivate.asyncGeneratorQueueDequeue):
(globalPrivate.asyncGeneratorReject):
(globalPrivate.asyncGeneratorResolve):
(globalPrivate.asyncGeneratorYield):
(onRejected):
(globalPrivate.awaitValue):
(onFulfilled):
(globalPrivate.doAsyncGeneratorBodyCall):
(globalPrivate.asyncGeneratorResumeNext):
(globalPrivate.asyncGeneratorEnqueue):
(globalPrivate.asyncGeneratorDequeue): Deleted.
(const.onRejected): Deleted.
(const.onFulfilled): Deleted.
(globalPrivate.asyncGeneratorResumeNext.): Deleted.

builtins/BuiltinExecutableCreator.h:
builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::defaultConstructorSourceCode):
(JSC::BuiltinExecutables::createDefaultConstructor):
(JSC::BuiltinExecutables::createBuiltinExecutable):
(JSC::BuiltinExecutables::createExecutable):
(JSC::createBuiltinExecutable): Deleted.

builtins/BuiltinExecutables.h:
builtins/BuiltinNames.h:
builtins/BuiltinUtils.h:
builtins/ModuleLoader.js:

(forceFulfillPromise):

builtins/PromiseConstructor.js:

builtins/PromiseOperations.js:

(globalPrivate.newPromiseReaction):
(globalPrivate.newPromiseCapability):
(globalPrivate.newHandledRejectedPromise):
(globalPrivate.triggerPromiseReactions):
(globalPrivate.resolvePromise):
(globalPrivate.rejectPromise):
(globalPrivate.fulfillPromise):
(globalPrivate.resolvePromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.rejectPromiseWithFirstResolvingFunctionCallCheck):
(globalPrivate.createResolvingFunctions.resolve):
(globalPrivate.createResolvingFunctions.reject):
(globalPrivate.createResolvingFunctions):
(globalPrivate.promiseReactionJobWithoutPromise):
(globalPrivate.resolveWithoutPromise):
(globalPrivate.rejectWithoutPromise):
(globalPrivate.fulfillWithoutPromise):
(resolve):
(reject):
(globalPrivate.createResolvingFunctionsWithoutPromise):
(globalPrivate.promiseReactionJob):
(globalPrivate.promiseResolveThenableJobFast):
(globalPrivate.promiseResolveThenableJobWithoutPromiseFast):
(globalPrivate.promiseResolveThenableJob):
(globalPrivate.isPromise): Deleted.
(globalPrivate.newPromiseCapability.executor): Deleted.
(globalPrivate.initializePromise): Deleted.

builtins/PromisePrototype.js:

(then):

bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

bytecode/BytecodeIntrinsicRegistry.h:
bytecode/BytecodeList.rb:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::finalizeLLIntInlineCaches):

bytecode/Opcode.h:
bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationFromClassInfo):
(JSC::speculationFromJSType):
(JSC::speculationFromString):

bytecode/SpeculatedType.h:
bytecode/UnlinkedFunctionExecutable.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitGetPromiseInternalField):
(JSC::BytecodeGenerator::emitPutPromiseInternalField):
(JSC::BytecodeGenerator::emitCreatePromise):
(JSC::BytecodeGenerator::emitNewPromise):
(JSC::BytecodeGenerator::emitReturn):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::promiseRegister):
(JSC::BytecodeGenerator::emitIsPromise):
(JSC::BytecodeGenerator::promiseCapabilityRegister): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::promiseInternalFieldIndex):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_getPromiseInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putPromiseInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isPromise):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_createPromise):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_newPromise):
(JSC::FunctionNode::emitBytecode):

dfg/DFGAbstractHeap.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGHeapLocation.h:
dfg/DFGMayExit.cpp:
dfg/DFGNode.h:

(JSC::DFG::Node::convertToNewPromise):
(JSC::DFG::Node::hasIsInternalPromise):
(JSC::DFG::Node::isInternalPromise):
(JSC::DFG::Node::hasInternalFieldIndex):
(JSC::DFG::Node::internalFieldIndex):
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasStructure):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGPromotedHeapLocation.cpp:

(WTF::printInternal):

dfg/DFGPromotedHeapLocation.h:
dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):
(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionCommon):
(JSC::DFG::SpeculativeJIT::speculatePromiseObject):
(JSC::DFG::SpeculativeJIT::speculate):
(JSC::DFG::SpeculativeJIT::compileGetPromiseInternalField):
(JSC::DFG::SpeculativeJIT::compilePutPromiseInternalField):
(JSC::DFG::SpeculativeJIT::compileCreatePromise):
(JSC::DFG::SpeculativeJIT::compileNewPromise):

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStoreBarrierInsertionPhase.cpp:
dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):
(JSC::DFG::isCell):

ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):
(JSC::FTL::DFG::LowerDFGToB3::compileNewPromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPromiseInternalField):
(JSC::FTL::DFG::LowerDFGToB3::compilePutPromiseInternalField):
(JSC::FTL::DFG::LowerDFGToB3::speculate):
(JSC::FTL::DFG::LowerDFGToB3::speculatePromiseObject):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITOperations.cpp:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_promise_internal_field):
(JSC::JIT::emit_op_put_promise_internal_field):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_promise_internal_field):
(JSC::JIT::emit_op_put_promise_internal_field):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseFunctionInfo):

parser/Parser.h:

(JSC::parse):

parser/ParserModes.h:
runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

runtime/CommonSlowPaths.h:
runtime/ConstructAbility.h:
runtime/ConstructorKind.h: Copied from Source/JavaScriptCore/runtime/ConstructAbility.h.
runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::FunctionRareData):
(JSC::FunctionRareData::initializeObjectAllocationProfile):
(JSC::FunctionRareData::clear):

runtime/FunctionRareData.h:
runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructureSlow):

runtime/InternalFunction.h:

(JSC::InternalFunction::createSubclassStructure):

runtime/JSCast.h:
runtime/JSGlobalObject.cpp:

(JSC::enqueueJob):
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::arrayProtoValuesFunction const):
(JSC::JSGlobalObject::promiseProtoThenFunction const):
(JSC::JSGlobalObject::initializePromiseFunction const): Deleted.

runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::createStructure):

runtime/JSInternalPromiseConstructor.cpp:

(JSC::JSInternalPromiseConstructor::create):
(JSC::JSInternalPromiseConstructor::createStructure):
(JSC::JSInternalPromiseConstructor::JSInternalPromiseConstructor):
(JSC::constructPromise): Deleted.

runtime/JSInternalPromiseConstructor.h:
runtime/JSInternalPromisePrototype.cpp:

(JSC::JSInternalPromisePrototype::create):

runtime/JSMicrotask.cpp:

(JSC::createJSMicrotask):
(JSC::JSMicrotask::run):

runtime/JSMicrotask.h:
runtime/JSPromise.cpp:

(JSC::JSPromise::createStructure):
(JSC::JSPromise::finishCreation):
(JSC::JSPromise::visitChildren):
(JSC::JSPromise::status const):
(JSC::JSPromise::result const):
(JSC::JSPromise::isHandled const):
(JSC::JSPromise::initialize): Deleted.

runtime/JSPromise.h:

(JSC::JSPromise::allocationSize):
(JSC::JSPromise::offsetOfInternalFields):
(JSC::JSPromise::offsetOfInternalField):

runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::create):
(JSC::JSPromiseConstructor::createStructure):
(JSC::JSPromiseConstructor::JSPromiseConstructor):
(JSC::JSPromiseConstructor::finishCreation):
(JSC::constructPromise): Deleted.
(JSC::callPromise): Deleted.

runtime/JSPromiseConstructor.h:
runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::create):
(JSC::JSPromisePrototype::finishCreation):
(JSC::JSPromisePrototype::addOwnInternalSlots):

runtime/JSPromisePrototype.h:
runtime/JSType.cpp:

(WTF::printInternal):

runtime/JSType.h:

Source/WebCore:

Modules/streams/ReadableStream.js:

(pipeThrough):

Modules/streams/ReadableStreamInternals.js:

(readableStreamError):
(readableStreamReaderGenericRelease):

LayoutTests:

inspector/canvas/recording-bitmaprenderer-frameCount-expected.txt:
inspector/canvas/recording-bitmaprenderer-full-expected.txt:
inspector/canvas/recording-bitmaprenderer-memoryLimit-expected.txt:
inspector/console/message-stack-trace-expected.txt:
inspector/console/queryHolders-expected.txt:
js/Promise-types-expected.txt:
js/dom/Promise-resolve-with-itself-expected.txt:
js/dom/Promise-resolve-with-itself.html:
js/script-tests/Promise-types.js:

6:17 PM Changeset in webkit [249508] by Wenson Hsieh

5 edits in trunk

-[WKContentView selectedText] returns an empty string when selecting more than 200 characters
https://bugs.webkit.org/show_bug.cgi?id=201471
<rdar://problem/55039227>

Reviewed by Tim Horton.

Source/WebKit:

The fix for <rdar://problem/54308019> is contingent on -[WKContentView selectedText] returning a non-empty
result in the case where text is selected. However, in WebKit, if more than 200 characters are selected,
-selectedText ends up returning nothing.

This is due to logic added in trac.webkit.org/r167624 that was intended to return the selected text in
PostLayoutData's wordAtSelection, up to a maximum of 200 characters, likely for performance and/or security
reasons. However, instead of truncating at 200 characters, the change simply drops wordAtSelection altogether.
This patch fixes this issue by taking the first 200 characters of the selected text.

Test: EditorStateTests.SelectedText

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

Tools:

Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
selected.

TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:

(TestWebKitAPI::TEST):

TestWebKitAPI/ios/UIKitSPI.h:

6:02 PM Changeset in webkit [249507] by timothy_horton@apple.com

3 edits
2 adds in trunk

Line artifacts in note body after viewing note with <attachment>s
https://bugs.webkit.org/show_bug.cgi?id=201474
<rdar://problem/51306108>

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/attachment/attachment-border-should-stay-inside-attachment.html

rendering/RenderThemeIOS.mm:

(WebCore::attachmentBorderPath):
(WebCore::paintAttachmentBorder):
Inset the border rect by half the width, so that <attachment> doesn't
paint out-of-bounds.

LayoutTests:

fast/attachment/attachment-border-should-stay-inside-attachment-expected.html: Added.
fast/attachment/attachment-border-should-stay-inside-attachment.html: Added.

Add a test that ensures that <attachment> stays inside its bounds.

5:47 PM Changeset in webkit [249506] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Fix mobile vs desktop mode
https://bugs.webkit.org/show_bug.cgi?id=201441

Rubber-stamped by Aakash Jain.

We should unconditionally use desktop mode if the device screen-width
is large enough.

resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:

5:45 PM Changeset in webkit [249505] by Kocsen Chung

7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

4:35 PM Changeset in webkit [249504] by Joseph Pecoraro

77 edits
11 copies
23 adds in trunk

Web Inspector: Local Overrides - Provide substitution content for resource loads (URL based)
https://bugs.webkit.org/show_bug.cgi?id=201262
<rdar://problem/13108764>

Reviewed by Devin Rousso.

Source/JavaScriptCore:

When interception is enabled, Network requests that match any of the configured
interception patterns will be paused on the backend and allowed to be modified
by the frontend.

Currently the only time a network request can be intercepted is during the
HTTP response. However, this intercepting interface is mean to extend to
HTTP requests as well.

When a response is to be intercepted a new event is sent to the frontend:

Network.responseIntercepted event

With a requestId to identify that network request. The frontend
must respond with one of the following commands to continue:

Network.interceptContinue - proceed with the response unmodified
Network.interceptWithResponse - provide a response

The response is paused in the meantime.

inspector/protocol/Network.json:

New interfaces for intercepting network responses and suppling override content.

Scripts/generate-combined-inspector-json.py:
inspector/scripts/generate-inspector-protocol-bindings.py:

(generate_from_specification.load_specification):
Complete allowing comments in JSON protocol files.

inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCBackendDispatcherImplementationGenerator._generate_invocation_for_command):

inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:

Allow optional enums in ObjC interfaces.

Source/WebCore:

Tests: http/tests/inspector/network/local-resource-override-basic.html

http/tests/inspector/network/local-resource-override-main-resource.html
http/tests/inspector/network/local-resource-override-script-tag.html
http/tests/inspector/network/resource-response-inspector-override.html

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
Headers.cmake:

New files.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willInterceptRequestImpl):
(WebCore::InspectorInstrumentation::shouldInterceptResponseImpl):
(WebCore::InspectorInstrumentation::interceptResponseImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::hasFrontends):
(WebCore::InspectorInstrumentation::willInterceptRequest):
(WebCore::InspectorInstrumentation::shouldInterceptResponse):
(WebCore::InspectorInstrumentation::interceptResponse):
(WebCore::InspectorInstrumentation::frontendCreated):
(WebCore::InspectorInstrumentation::frontendDeleted):

inspector/InspectorInstrumentationPublic.cpp:
inspector/InspectorInstrumentationPublic.h:
inspector/InspectorInstrumentationWebKit.cpp:

(WebCore::InspectorInstrumentationWebKit::shouldInterceptResponseInternal):
(WebCore::InspectorInstrumentationWebKit::interceptResponseInternal):

inspector/InspectorInstrumentationWebKit.h: Added.

(WebCore::InspectorInstrumentationWebKit::shouldInterceptResponse):
(WebCore::InspectorInstrumentationWebKit::interceptResponse):
Provide a slim InspectorInstrumentation API that can be used in the WebKit
layer without a ton of includes.

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::responseSource):
(WebCore::InspectorNetworkAgent::disable):
(WebCore::InspectorNetworkAgent::continuePendingResponses):
(WebCore::InspectorNetworkAgent::setInterceptionEnabled):
(WebCore::InspectorNetworkAgent::addInterception):
(WebCore::InspectorNetworkAgent::removeInterception):
(WebCore::InspectorNetworkAgent::willInterceptRequest):
(WebCore::InspectorNetworkAgent::shouldInterceptResponse):
(WebCore::InspectorNetworkAgent::interceptResponse):
(WebCore::InspectorNetworkAgent::interceptContinue):
(WebCore::InspectorNetworkAgent::interceptWithResponse):
Manage a list of URLs that will be intercepted and send
intercepts to an active frontend for response content.

inspector/agents/InspectorNetworkAgent.h:

(WebCore::InspectorNetworkAgent::PendingInterceptResponse::PendingInterceptResponse):
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::~PendingInterceptResponse):
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::originalResponse):
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::respondWithOriginalResponse):
(WebCore::InspectorNetworkAgent::PendingInterceptResponse::respond):
Callback for an eventual intercept response.

platform/network/ResourceResponseBase.h:

New ResponseSource - Inspector Override.

loader/DocumentLoader.cpp:

(WebCore::logResourceResponseSource):

testing/Internals.cpp:

(WebCore::responseSourceToString):
Handle new response sources.

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):
Avoid preloading or using the cache for URLs that would be intercepted
by an active Inspector frontend.

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::remove):
Assertion to help detect if we ever get override content into the MemoryCache.

loader/ResourceLoader.h:

(WebCore::DocumentLoader::responseReceived):

loader/ResourceLoader.cpp:

Fix typos.

Source/WebInspectorUI:

This adds a new "Local Overrides" section to the Sources tab sidebar
which will allow users to provide their own resource content for text
resources. Users can clone a resource, and provide their own content
(by editing in Web Inspector) and new requests for those particular
URLs will get the substitute content.

Overrides are based on a particular URL (ignoring fragment). They
can override: status code, status text, response headers, content,
and MIME Type (Content-Type).

Tools/CodeMirrorModes/index.html: Added.
Tools/CodeMirrorModes/styles.css: Added.

Debug tool for CodeMirror editors and our custom CodeMirror modes.

UserInterface/Main.html:
UserInterface/Test.html:
Localizations/en.lproj/localizedStrings.js:

New files and strings.

UserInterface/Base/HTTPUtilities.js: Added.

(WI.httpStatusTextForStatusCode):
Translate between typical status codes and status text.

UserInterface/Base/ObjectStore.js:

(WI.ObjectStore._open):
New persistent store for local resource overrides.

UserInterface/Base/Main.js:

(WI.showLocalResourceOverride):
Convenience for showing an override file.

UserInterface/Base/URLUtilities.js:

(parseURL):
Avoid uncaught exceptions with the URL constructor for common WebKit internal sourceURL strings.

(WI.urlWithoutFragment):
Strip a fragment from a URL.

UserInterface/Controllers/HARBuilder.js:

(WI.HARBuilder.fetchType):
(WI.HARBuilder.responseSourceFromHARFetchType):
Handle new custom response types.

UserInterface/Protocol/NetworkObserver.js:

(WI.NetworkObserver.prototype.responseIntercepted):
(WI.NetworkObserver):
New events.

UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager):
(WI.NetworkManager.supportsLocalResourceOverrides):
(WI.NetworkManager.prototype.initializeTarget):
(WI.NetworkManager.prototype.get localResourceOverrides):
(WI.NetworkManager.prototype.get interceptionEnabled):
(WI.NetworkManager.prototype.set interceptionEnabled):
(WI.NetworkManager.prototype.addLocalResourceOverride):
(WI.NetworkManager.prototype.removeLocalResourceOverride):
(WI.NetworkManager.prototype.localResourceOverrideForURL):
(WI.NetworkManager.prototype.canBeOverridden):
(WI.NetworkManager.prototype.responseIntercepted):
(WI.NetworkManager.prototype._handleResourceContentDidChange):
(WI.NetworkManager.prototype._persistLocalResourceOverrideSoonAfterContentChange):
(WI.NetworkManager.prototype._saveLocalResourceOverrides):
(WI.NetworkManager.prototype._extraDomainsActivated):
(WI.NetworkManager.prototype.localResourceForURL): Deleted.
Handle saving and restoring local resource overrides.
Handle responding to a responseIntercepted Network protocol event.

UserInterface/Models/LocalResource.js:

(WI.LocalResource.fromJSON):
(WI.LocalResource.prototype.toJSON):
(WI.LocalResource.prototype.get localContent):
(WI.LocalResource.prototype.get localContentIsBase64Encoded):
(WI.LocalResource.prototype.isLocalResourceOverride):
(WI.LocalResource.prototype.updateOverrideContent):
Allow a LocalResource to identify itself as an "override".

UserInterface/Models/LocalResourceOverride.js: Added.

(WI.LocalResourceOverride.prototype.create):
(WI.LocalResourceOverride.fromJSON):
(WI.LocalResourceOverride.prototype.toJSON):
(WI.LocalResourceOverride.prototype.get url):
(WI.LocalResourceOverride.prototype.get localResource):
(WI.LocalResourceOverride.prototype.get disabled):
(WI.LocalResourceOverride.prototype.set disabled):
(WI.LocalResourceOverride.prototype.saveIdentityToCookie):
(WI.LocalResourceOverride):
Model object for a LocalResourceOverride. This has LocalResource content
and an enabled/disabled state.

UserInterface/Models/Resource.js:

(WI.Resource.classNamesForResource):
(WI.Resource.responseSourceFromPayload):
(WI.Resource.prototype.isLocalResourceOverride):
(WI.Resource.prototype.async.createLocalResourceOverride):
(WI.Resource.classNameForResource): Deleted.
Convenience functions and icon updates.

UserInterface/Views/SourcesTabContentView.js:

(WI.SourcesTabContentView.prototype.canShowRepresentedObject):

UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.resolvedRepresentedObjectForRepresentedObject):
(WI.ContentView.isViewable):
Handle new represented object type.

UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel):
(WI.SourcesNavigationSidebarPanel.prototype.createContentTreeOutline):
(WI.SourcesNavigationSidebarPanel.prototype.willDismissPopover):
(WI.SourcesNavigationSidebarPanel.prototype._willDismissLocalOverridePopover):
(WI.SourcesNavigationSidebarPanel.prototype._willDismissEventBreakpointPopover):
(WI.SourcesNavigationSidebarPanel.prototype._willDismissURLBreakpointPopover):
(WI.SourcesNavigationSidebarPanel.prototype._addLocalResourceOverride):
(WI.SourcesNavigationSidebarPanel.prototype._removeLocalResourceOverride):
(WI.SourcesNavigationSidebarPanel.prototype._handleTreeSelectionDidChange):
(WI.SourcesNavigationSidebarPanel.prototype._populateCreateBreakpointContextMenu):
(WI.SourcesNavigationSidebarPanel.prototype._handleLocalResourceOverrideAdded):
(WI.SourcesNavigationSidebarPanel.prototype._handleLocalResourceOverrideRemoved):

UserInterface/Views/SourcesNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.sources > .content > .warning-banner):
(.sidebar > .panel.navigation.sources > .content > :matches(.pause-reason-container, .call-stack-container, .breakpoints-container, .local-overrides)):
(.sidebar > .panel.navigation.sources > .content > .local-overrides):
(.sidebar > .panel.navigation.sources > .content > :matches(.pause-reason-container, .call-stack-container, .breakpoints-container)): Deleted.
Hide and show Local Overrides section.

UserInterface/Views/LocalResourceOverrideTreeElement.css:

(.item.resource.override .status > div):

UserInterface/Views/LocalResourceOverrideTreeElement.js: Added.

(WI.LocalResourceOverrideTreeElement):
(WI.LocalResourceOverrideTreeElement.prototype.canSelectOnMouseDown):
(WI.LocalResourceOverrideTreeElement.prototype.populateContextMenu):
(WI.LocalResourceOverrideTreeElement.prototype.willDismissPopover):
TreeElement for a Local Resource Override.

UserInterface/Views/CodeMirrorLocalOverrideURLMode.css:

(.cm-s-default .cm-local-override-url-bad-scheme):
(.cm-s-default .cm-local-override-url-fragment):

UserInterface/Views/CodeMirrorLocalOverrideURLMode.js: Added.

(tokenBase):
(return.startState):
(return.token):

UserInterface/Views/ContentBrowserTabContentView.js:

(WI.ContentBrowserTabContentView.prototype._revealAndSelectRepresentedObject):

UserInterface/Views/ContextMenu.js:

(WI.ContextMenu.prototype._itemSelected):
(WI.ContextMenu):
Better debugging for exceptions in context menu handlers.

UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForSourceCode):
(WI.appendContextMenuItemsForURL):
Context menu items for Local Resource Overrides.

UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.startEditingNode):
(WI.DataGrid.prototype._startEditingNodeAtColumnIndex):
(WI.DataGrid.prototype._startEditing):
(WI.DataGrid.prototype._contextMenuInDataTable):

UserInterface/Views/DataGridNode.js:

(WI.DataGridNode):
(WI.DataGridNode.prototype.get editable):
(WI.DataGridNode.prototype.set editable):
Improve DataGrid editing functionality.
Allow a node to not be editable.
Allow adding a new node and starting to edit in one action.

UserInterface/Views/DebuggerSidebarPanel.js:

(WI.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject):
Do not provide overrides in the Debugger tab.

UserInterface/Views/LocalResourceOverrideLabelView.css:

(.local-resource-override-label-view):
(.local-resource-override-label-view > div):
(.local-resource-override-label-view > div > .label):
(.local-resource-override-label-view > div > .url):
(@media (prefers-color-scheme: dark)):

UserInterface/Views/LocalResourceOverrideLabelView.js:

(WI.LocalResourceOverrideLabelView):
(WI.LocalResourceOverrideLabelView.prototype.initialLayout):

UserInterface/Views/LocalResourceOverridePopover.css: Added.

(.popover .local-resource-override-popover-content):
(.popover .local-resource-override-popover-content > label.toggle):
(.popover .local-resource-override-popover-content > table):
(.popover .local-resource-override-popover-content > table > tr > th):
(.popover .local-resource-override-popover-content > table > tr > td):
(.popover .local-resource-override-popover-content .editor):
(.popover .local-resource-override-popover-content .editor > .CodeMirror):
(.popover .local-resource-override-popover-content .editor.url):
(.popover .local-resource-override-popover-content .editor.mime):
(.popover .local-resource-override-popover-content .editor.status):
(.popover .local-resource-override-popover-content .editor.status-text):
(.popover .local-resource-override-popover-content .add-header):
(@media (prefers-color-scheme: dark)):
New banner view for a local resource override itself.
Shows the URL being overriden.

UserInterface/Views/LocalResourceOverrideWarningView.css:

(.local-resource-override-warning-view):
(.local-resource-override-warning-view[hidden]):
(.local-resource-override-warning-view > div):
(.local-resource-override-warning-view > div > button):
(@media (prefers-color-scheme: dark)):

UserInterface/Views/LocalResourceOverrideWarningView.js: Added.

(WI.LocalResourceOverrideWarningView):
(WI.LocalResourceOverrideWarningView.prototype.attached):
(WI.LocalResourceOverrideWarningView.prototype.detached):
(WI.LocalResourceOverrideWarningView.prototype._updateContent):
(WI.LocalResourceOverrideWarningView.prototype._handleLocalResourceOverrideChanged):

UserInterface/Views/NavigationSidebarPanel.js:

(WI.NavigationSidebarPanel.prototype.pruneStaleResourceTreeElements):
New banner view for a resource that has been overridden.
Allows jumping to the override itself.

UserInterface/Views/LocalResourceOverridePopover.js: Added.

(WI.LocalResourceOverridePopover):
(WI.LocalResourceOverridePopover.prototype.get serializedData):
(WI.LocalResourceOverridePopover.prototype.show.addDataGridNodeForHeader):
(WI.LocalResourceOverridePopover.prototype.show):
(WI.LocalResourceOverridePopover.prototype._createEditor):
(WI.LocalResourceOverridePopover.prototype._defaultURL):
(WI.LocalResourceOverridePopover.prototype._presentOverTargetElement):
New popover for creating or editing a Local Resource Override.

UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.performSearch):
Consider searching overrides.

UserInterface/Views/Variables.css:

(:root):

UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search.changed > .banner):

UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .warning-banner):

UserInterface/Views/ConsoleMessageView.css:

(.console-warning-level):
Use a new variable for a common warning color.

UserInterface/Images/NavigationItemNetworkOverride.svg: Added.
UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.canBeFormatted):
(WI.SourceCodeTextEditor.prototype.get _supportsDebugging):

UserInterface/Views/SourcesNavigationSidebarPanel.css:

UserInterface/Views/TextEditor.css:

(.text-editor):

UserInterface/Views/TextResourceContentView.css:

(.content-view.resource.text):
(.content-view.resource.text > .text-editor):

UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView):
(WI.TextResourceContentView.prototype.get navigationItems):
(WI.TextResourceContentView.prototype.closed):
(WI.TextResourceContentView.prototype._contentWillPopulate):
(WI.TextResourceContentView.prototype._contentDidPopulate):
(WI.TextResourceContentView.prototype.async._handleCreateLocalResourceOverride):
(WI.TextResourceContentView.prototype._handleRemoveLocalResourceOverride):
(WI.TextResourceContentView.prototype._handleLocalResourceOverrideChanged):
(WI.TextResourceContentView.prototype._textEditorContentDidChange):
(WI.TextResourceContentView.prototype._shouldBeEditable):
Allow Text resources to create a local resource override.
Support for Image resources will come separately.

UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._responseSourceDisplayString):
Handle new response type.

UserInterface/Controllers/CSSManager.js:

Avoid extra handling for Local Resource Overrides.

UserInterface/Views/ResourceIcons.css:

(.resource-icon.override .icon):

UserInterface/Views/ResourceSizesContentView.js:

(WI.ResourceSizesContentView.prototype.initialLayout):

UserInterface/Views/ResourceTimelineDataGridNode.js:

(WI.ResourceTimelineDataGridNode.prototype.iconClassNames):

UserInterface/Views/ResourceTreeElement.js:

(WI.ResourceTreeElement.prototype._updateResource):
(WI.ResourceTreeElement.prototype._updateIcon):
(WI.ResourceTreeElement.prototype._responseReceived):
(WI.ResourceTreeElement):

UserInterface/Views/TimelineDataGridNode.js:

(WI.TimelineDataGridNode.prototype.createCellContent):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateTransferSizeCell):
(WI.NetworkTableContentView.prototype._generateSortComparator):
Better Resource icons all over for overrides.

UserInterface/Views/URLBreakpointPopover.js:

(WI.URLBreakpointPopover.prototype._createEditor):
Code cleanup.

Source/WebKit:

Sources.txt:
WebKit.xcodeproj/project.pbxproj:

New sources.

WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
On receiving a response, check with the inspector if an active
frontend will override the response content.

WebProcess/Network/WebResourceInterceptController.h:
WebProcess/Network/WebResourceInterceptController.cpp:

(WebKit::WebResourceInterceptController::isIntercepting const):
(WebKit::WebResourceInterceptController::beginInterceptingResponse):
(WebKit::WebResourceInterceptController::continueResponse):
(WebKit::WebResourceInterceptController::interceptedResponse):
(WebKit::WebResourceInterceptController::defer):
Buffer networking callbacks for an ongoing intercept.

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::havePerformedSecurityChecks const):
Handle new response source.

LayoutTests:

http/tests/inspector/network/local-resource-override-basic-expected.txt: Added.
http/tests/inspector/network/local-resource-override-basic.html: Added.
http/tests/inspector/network/local-resource-override-main-resource-expected.txt: Added.
http/tests/inspector/network/local-resource-override-main-resource.html: Added.
http/tests/inspector/network/local-resource-override-script-tag-expected.txt: Added.
http/tests/inspector/network/local-resource-override-script-tag.html: Added.
http/tests/inspector/network/resource-response-inspector-override-expected.txt: Added.
http/tests/inspector/network/resource-response-inspector-override.html: Added.
http/tests/inspector/network/resources/override.js: Added.
http/tests/inspector/network/resources/override.txt: Added.
inspector/network/local-resource-override-continue-response-expected.txt: Added.
inspector/network/local-resource-override-continue-response.html: Added.

Tests for overrides.

inspector/unit-tests/url-utilities-expected.txt:
inspector/unit-tests/url-utilities.html:

Test WI.urlWithoutFragment.

platform/mac-wk1/TestExpectations:

WebKitLegacy does not support overrides.

4:20 PM Changeset in webkit [249503] by Kocsen Chung

1 copy in tags/Safari-608.2.11.1.2

Tag Safari-608.2.11.1.2.

4:13 PM Changeset in webkit [249502] by Chris Dumez

2 edits in trunk/Source/WebKit

Unreviewed minor follow-up fix after r249501 to address crashes in debug.

NetworkProcess/cache/NetworkCache.h:

(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::constructDeletedValue):
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::isDeletedValue):

3:57 PM Changeset in webkit [249501] by Chris Dumez

52 edits in trunk/Source

Expose WebPageProxy identifier to the Network Process
https://bugs.webkit.org/show_bug.cgi?id=201467

Reviewed by Geoffrey Garen.

Source/WebCore:

loader/EmptyFrameLoaderClient.h:

(isType):

loader/FrameLoaderClient.h:

Source/WebKit:

Expose WebPageProxy identifier to the Network Process (similarly to WebPage / WebFrame identifiers)
so that it can use it whenever it IPCs the UIProcess. The IPCs from the network process were the
last one requiring the UIProcess to lookup a WebPageProxy object from a WebPageIdentifier (rather
than a WebPageProxyIdentifier).

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):

NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):

NetworkProcess/NetworkCORSPreflightChecker.h:
NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):
(WebKit::NetworkConnectionToWebProcess::requestStorageAccess):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didReceiveChallenge):

NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::checkCORSRequestWithPreflight):

NetworkProcess/NetworkLoadChecker.h:
NetworkProcess/NetworkLoadParameters.h:
NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::NetworkProcess::logDiagnosticMessage):
(WebKit::NetworkProcess::logDiagnosticMessageWithResult):
(WebKit::NetworkProcess::logDiagnosticMessageWithValue):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::m_shouldCaptureExtraNetworkLoadMetrics):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):
(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didReceiveResponse):

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::didReceiveChallenge):

NetworkProcess/cache/NetworkCache.h:

(WebKit::NetworkCache::GlobalFrameID::hash const):
(WebKit::NetworkCache::operator==):
(WTF::GlobalFrameIDHash::hash):
(WTF::GlobalFrameIDHash::equal):
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::emptyValue):
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::constructDeletedValue):
(WTF::HashTraits<WebKit::NetworkCache::GlobalFrameID>::isDeletedValue):

NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):

NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::logSpeculativeLoadingDiagnosticMessage):

Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::shouldCoalesceChallenge const):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

Shared/Authentication/AuthenticationManager.h:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didReceiveAuthenticationChallenge):
(WebKit::NetworkProcessProxy::logDiagnosticMessage):
(WebKit::NetworkProcessProxy::logDiagnosticMessageWithResult):
(WebKit::NetworkProcessProxy::logDiagnosticMessageWithValue):
(WebKit::NetworkProcessProxy::requestStorageAccessConfirm):
(WebKit::NetworkProcessProxy::didCommitCrossSiteLoadWithDataTransfer):
(WebKit::NetworkProcessProxy::didCommitCrossSiteLoadWithDataTransferFromPrevalentResource):
(WebKit::NetworkProcessProxy::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:
UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::start):

UIProcess/ServiceWorkerProcessProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::isServiceWorkerPageID const):
(WebKit::WebProcessPool::didCommitCrossSiteLoadWithDataTransfer):

UIProcess/WebProcessPool.h:
UIProcess/WebProcessProxy.cpp:
UIProcess/WebProcessProxy.h:
WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::preconnectTo):

WebProcess/Network/WebResourceLoader.h:
WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::ServiceWorkerFrameLoaderClient::ServiceWorkerFrameLoaderClient):
(WebKit::ServiceWorkerFrameLoaderClient::createDocumentLoader):
(WebKit::WebSWContextManagerConnection::WebSWContextManagerConnection):
(WebKit::WebSWContextManagerConnection::installServiceWorker):

WebProcess/Storage/WebSWContextManagerConnection.h:

(isType):

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::testProcessIncomingSyncMessagesWhenWaitingForSyncReply):

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::webPageProxyID const):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestStorageAccess):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

2:25 PM Changeset in webkit [249500] by Jonathan Bedard

3 edits in trunk/Tools

run-api-tests: Add support for specifying additional environment variables
https://bugs.webkit.org/show_bug.cgi?id=201311
<rdar://problem/54852698>

Reviewed by Daniel Bates.

Scripts/webkitpy/api_tests/run_api_tests.py:

(parse_args): Add --additional-env-var flag.

Scripts/webkitpy/port/base.py:

(Port._append_value_colon_separated): Use os.pathsep instead of ':'.
(Port.environment_for_api_tests): Add the values from --additional-env-var to the
environment.

2:12 PM Changeset in webkit [249499] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Structure::storedPrototype() and storedPrototypeObject() should assert with isCompilationThread(), not !isMainThread().
https://bugs.webkit.org/show_bug.cgi?id=201449

Reviewed by Yusuke Suzuki.

Using !isMainThread() in the assertion also disables the assertion for the mutator
of worker threads. This is not what we intended.

runtime/StructureInlines.h:

(JSC::Structure::storedPrototype const):
(JSC::Structure::storedPrototypeObject const):

2:11 PM Changeset in webkit [249498] by achristensen@apple.com

6 edits in trunk/Source

Remove unused SPI that accesses MemoryCache directly
https://bugs.webkit.org/show_bug.cgi?id=201468

Reviewed by Tim Horton.

Source/WebCore:

loader/cache/MemoryCache.cpp:

(WebCore::dummyCachedImageClient): Deleted.
(WebCore::MemoryCache::addImageToCache): Deleted.
(WebCore::MemoryCache::removeImageFromCache): Deleted.

loader/cache/MemoryCache.h:

Source/WebKitLegacy/mac:

Misc/WebCache.h:
Misc/WebCache.mm:

(+[WebCache addImageToCache:forURL:]): Deleted.
(+[WebCache addImageToCache:forURL:forFrame:]): Deleted.
(+[WebCache removeImageFromCacheForURL:]): Deleted.
(+[WebCache removeImageFromCacheForURL:forFrame:]): Deleted.

1:42 PM Changeset in webkit [249497] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC] Assert on FormattingContext escaping
https://bugs.webkit.org/show_bug.cgi?id=201464
<rdar://problem/55029574>

Reviewed by Antti Koivisto.

This patch asserts on accidental formatting context escaping. This is only a correctness issue at the moment,
since we don't support multithreaded subtree layout yet.
Normally we should not need to access display boxes in different formatting contexts during layout, but there are a few, justified cases when it is required.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::displayBoxForLayoutBox const):

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::displayBoxForLayoutBox const): Deleted.

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
(WebCore::Layout::FormattingContext::Geometry::staticVerticalPositionForOutOfFlowPositioned const):
(WebCore::Layout::FormattingContext::Geometry::staticHorizontalPositionForOutOfFlowPositioned const):

layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

1:09 PM Changeset in webkit [249496] by Kocsen Chung

2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r249430. rdar://problem/55027550

[macOS] Correct sandbox violation in Flash plugin
https://bugs.webkit.org/show_bug.cgi?id=201228
<rdar://problem/54347503>

Reviewed by Alex Christensen.

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:08 PM Changeset in webkit [249495] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Disambiguate a symbol used in JSDollarVM.
https://bugs.webkit.org/show_bug.cgi?id=201466
<rdar://problem/51826672>

Reviewed by Tadeu Zagallo.

This was causing a build issue on some internal build.

tools/JSDollarVM.cpp:

12:53 PM Changeset in webkit [249494] by Alan Bujtas

6 edits in trunk/Source/WebCore

[LFC] FormattingContext::map* functions are too generic.
https://bugs.webkit.org/show_bug.cgi?id=201447
<rdar://problem/55005733>

Reviewed by Antti Koivisto.

We don't need such generic mapping functions yet. This patch is also in preparation for
asserting on formatting context escaping.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::mapTopToFormattingContextRoot const):
(WebCore::Layout::FormattingContext::mapLeftToFormattingContextRoot const):
(WebCore::Layout::FormattingContext::mapRightToFormattingContextRoot const):
(WebCore::Layout::FormattingContext::mapLeftToAncestor const): Deleted.
(WebCore::Layout::FormattingContext::mapRightToAncestor const): Deleted.
(WebCore::Layout::FormattingContext::mapBoxToAncestor const): Deleted.
(WebCore::Layout::FormattingContext::mapTopToAncestor const): Deleted.
(WebCore::Layout::FormattingContext::mapPointToAncestor const): Deleted.
(WebCore::Layout::FormattingContext::mapPointToDescendent const): Deleted.

layout/FormattingContext.h:
layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider const):

layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFormattingContextRoot const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::constraints const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapPointFromFormattingContextRootToFloatingStateRoot const):
(WebCore::Layout::mapToFormattingContextRoot): Deleted.

layout/floats/FloatingContext.h:
page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

12:38 PM Changeset in webkit [249493] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[iPadOS] Unable to change sheets on Airtable.com
https://bugs.webkit.org/show_bug.cgi?id=201456
<rdar://problem/51557377>

Patch by Antoine Quint <Antoine Quint> on 2019-09-04
Reviewed by Dean Jackson.

Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.

page/Quirks.cpp:

(WebCore::Quirks::simulatedMouseEventTypeForTarget const):

12:37 PM Changeset in webkit [249492] by timothy_horton@apple.com

6 edits in trunk/Source/WebKit

macCatalyst: Re-enable iOS WKWebView printing API
https://bugs.webkit.org/show_bug.cgi?id=201392
<rdar://problem/54690252>

Reviewed by Wenson Hsieh.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _webViewPrintFormatter]):

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/_WKWebViewPrintFormatter.mm:
UIProcess/_WKWebViewPrintFormatterInternal.h:
UIProcess/ios/WKContentView.mm:

_WKWwebViewPrintFormatter was disabled during bringup because requisite
UIKit bits were missing, but they are not anymore (and have not been for
quite some time), so remove these unnecessary platform ifdefs.

12:23 PM Changeset in webkit [249491] by Kocsen Chung

1 edit in branches/safari-608-branch/Tools/WebKitTestRunner/TestOptions.h

Unreviewed build fix.

12:19 PM Changeset in webkit [249490] by Kocsen Chung

2 edits in branches/safari-608.2.11.1-branch/Source/WebKit

Cherry-pick r249430. rdar://problem/55031098

[macOS] Correct sandbox violation in Flash plugin
https://bugs.webkit.org/show_bug.cgi?id=201228
<rdar://problem/54347503>

Reviewed by Alex Christensen.

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:28 AM Changeset in webkit [249489] by commit-queue@webkit.org

17 edits in trunk/LayoutTests

Address review comments after r249364
https://bugs.webkit.org/show_bug.cgi?id=201432

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-09-04
Reviewed by Simon Fraser.

Fix the <img> CSS width properties by adding the "px" units.

fast/images/exif-orientation-background-expected.html:
fast/images/exif-orientation-canvas-expected.html:
fast/images/exif-orientation-canvas.html:
fast/images/exif-orientation-composited-expected.html:
fast/images/exif-orientation-composited.html:

Remove the CSS border to enable the composited image code path.

fast/images/exif-orientation-content-expected.html:
fast/images/exif-orientation-element-expected.html:
fast/images/exif-orientation-element.html:
fast/images/exif-orientation-image-document-expected.html:
fast/images/exif-orientation-image-document.html:
fast/images/exif-orientation-image-object-expected.html:
fast/images/exif-orientation-image-object.html:
fast/images/exif-orientation-svg-feimage-expected.html:
fast/images/exif-orientation-svg-feimage.html:
fast/images/exif-orientation-svg-image-expected.html:
fast/images/exif-orientation-svg-image.html:

11:15 AM Changeset in webkit [249488] by mark.lam@apple.com

2 edits in branches/safari-608-branch/Source/JavaScriptCore

Cherry-pick 249345. rdar://problem/55000994

2019-08-30 Mark Lam <mark.lam@apple.com>

Fix a bug in SlotVisitor::reportZappedCellAndCrash() and also capture more information.
https://bugs.webkit.org/show_bug.cgi?id=201345

Reviewed by Yusuke Suzuki.

This patch fixes a bug where SlotVisitor::reportZappedCellAndCrash() was using
the wrong pointer for capture the cell headerWord and zapReason. As a result,
we get junk for those 2 values.

Previously, we were only capturing the upper 32-bits of the cell header slot,
and the lower 32-bit of the next slot in the zapped cell. We now capture the
full 64-bits of both slots. If the second slot did not contain a zapReason as we
expect, the upper 32-bits might give us a clue as to what type of value the slot
contains.

This patch also adds capturing of the found MarkedBlock address for the zapped
cell, as well as some state bit values.

heap/SlotVisitor.cpp: (JSC::SlotVisitor::reportZappedCellAndCrash):

11:13 AM Changeset in webkit [249487] by Patrick Griffis

2 edits in trunk/Source/WebKit

[WPE][GTK] Fix sandbox parsing DISPLAY on X11
https://bugs.webkit.org/show_bug.cgi?id=201462

Reviewed by Michael Catanzaro.

On some setups the DISPLAY env var was incorrectly parsed.

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindX11):

11:08 AM Changeset in webkit [249486] by BJ Burg

2 edits in trunk/Source/WebKit

Selenium test 'interactions_tests.py::testContextClick' is hanging
https://bugs.webkit.org/show_bug.cgi?id=201161
<rdar://problem/54728541>

Reviewed by Chris Dumez.

A web page should not show native context menus if user interactions are being simulated for WebDriver.
Showing a native context menu spawns a nested run loop. Since there's no way to interact
with native UI via WebDriver, the test will hang until the context menu is manually dismissed.

To fix this, pretend to show the context menu in UIProcess and dismiss it immediately.
This is necessary to trigger oncontextmenu events appropriately and resume handling mouse events.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu): Hook into isControlledByAutomation here.
We could short circuit this on the WebProcess side, but the check would be more crude
and suppress context menus even if user interaction isn't being simulated. This would be
problematic for a user who wants to interrupt their test session and interact with it.
The main use case for this is right clicking on the test page and choose "Inspect".

11:06 AM Changeset in webkit [249485] by Kocsen Chung

7 edits in branches/safari-608.2.11.1-branch/Source

Versioning.

11:01 AM Changeset in webkit [249484] by mark.lam@apple.com

22 edits in branches/safari-608-branch

Source/JavaScriptCore:
Cherry-pick 248143, 248162. rdar://problem/55000992

Also deleted an unused function. This is needed to resolve a merge conflict for
this patch.

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::zap): Deleted.

heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::zap): Deleted.

2019-08-02 Mark Lam <mark.lam@apple.com>

Gardening: build fix.
https://bugs.webkit.org/show_bug.cgi?id=200149
<rdar://problem/53570112>

Not reviewed.

assembler/CPU.cpp: (JSC::hwPhysicalCPUMax):

2019-08-01 Mark Lam <mark.lam@apple.com>

Add crash diagnostics for debugging unexpected zapped cells.
https://bugs.webkit.org/show_bug.cgi?id=200149
<rdar://problem/53570112>

Reviewed by Yusuke Suzuki.

Add a check for zapped cells in SlotVisitor::appendToMarkStack() and
SlotVisitor::visitChildren(). If a zapped cell is detected, we will crash with
some diagnostic info.

To facilitate this, we've made the following changes:

Changed FreeCell to preserve the 1st 8 bytes. This is fine to do because all cells are at least 16 bytes long.
Changed HeapCell::zap() to only zap the structureID. Leave the rest of the cell header info intact (including the cell JSType).
Changed HeapCell::zap() to record the reason for zapping the cell. We stash the reason immediately after the first 8 bytes. This is the same location as FreeCell::scrambledNext. However, since a cell is not expected to be zapped and on the free list at the same time, it is also fine to do this.
Added a few utility functions to MarkedBlock for checking if a cell points into the block.
Added VMInspector and JSDollarVM utilities to dump in-use subspace hashes.
Added some comments to document the hashes of known subspaces.
Added Options::dumpZappedCellCrashData() to make this check conditional. We use this option to disable this check for slower machines so that their PLT5 performance is not impacted.

assembler/CPU.cpp: (JSC::hwL3CacheSize): (JSC::hwPhysicalCPUMax):
assembler/CPU.h: (JSC::hwL3CacheSize): (JSC::hwPhysicalCPUMax):
heap/FreeList.h: (JSC::FreeCell::offsetOfScrambledNext):
heap/HeapCell.h: (JSC::HeapCell::zap): (JSC::HeapCell::isZapped const):
heap/MarkedBlock.cpp: (JSC::MarkedBlock::Handle::stopAllocating):
heap/MarkedBlock.h: (JSC::MarkedBlock::Handle::start const): (JSC::MarkedBlock::Handle::end const): (JSC::MarkedBlock::Handle::contains const):
heap/MarkedBlockInlines.h: (JSC::MarkedBlock::Handle::specializedSweep):
heap/MarkedSpace.h: (JSC::MarkedSpace::forEachSubspace):
heap/SlotVisitor.cpp: (JSC::SlotVisitor::appendToMarkStack): (JSC::SlotVisitor::visitChildren): (JSC::SlotVisitor::reportZappedCellAndCrash):
heap/SlotVisitor.h:
jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
runtime/Options.cpp: (JSC::Options::initialize):
runtime/Options.h:
runtime/VM.cpp: (JSC::VM::VM):
tools/JSDollarVM.cpp: (JSC::functionDumpSubspaceHashes): (JSC::JSDollarVM::finishCreation):
tools/VMInspector.cpp: (JSC::VMInspector::dumpSubspaceHashes):
tools/VMInspector.h:

Source/WebCore:
Cherry-pick 248143. rdar://problem/55000992

2019-08-01 Mark Lam <mark.lam@apple.com>

Add crash diagnostics for debugging unexpected zapped cells.
https://bugs.webkit.org/show_bug.cgi?id=200149
<rdar://problem/53570112>

Reviewed by Yusuke Suzuki.

No new tests because this is a feature for debugging crashes. It has been tested
manually by modifying the code to force a crash at the point of interest.

Added some comments to document the hashes of known subspaces.

bindings/js/WebCoreJSClientData.cpp: (WebCore::JSVMClientData::JSVMClientData):

10:27 AM Changeset in webkit [249483] by aakash_jain@apple.com

11 edits in trunk

EWS bubbles should indicate builder vs tester
https://bugs.webkit.org/show_bug.cgi?id=201253

Reviewed by Jonathan Bedard.

Tools:

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble._build_bubble): Add icons to the bubbles appropriately.
(StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
(StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
(StatusBubble.get):

BuildSlaveSupport/ews-app/ews/common/buildbot.py:

(Buildbot.fetch_config): Method to fetch the config from Buildbot server.
(Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.

BuildSlaveSupport/ews-app/ews/fetcher.py:

(FetchLoop.run): Update the icons for queues mapping.

BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
BuildSlaveSupport/ews-build/loadConfig_unittest.py: .

(test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.

Websites/bugs.webkit.org:

code-review.js: Do not display the icons in status-bubbles on this page.
template/en/default/attachment/edit.html.tmpl: Ditto.
template/en/default/attachment/reviewform.html.tmpl: Ditto.

10:05 AM Changeset in webkit [249482] by Kocsen Chung

1 edit in branches/safari-608-branch/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

Unreviewed build fix.

9:46 AM Changeset in webkit [249481] by youenn@apple.com

7 edits
3 adds in trunk/Source

Abstract out WebSocketChannel message queue
https://bugs.webkit.org/show_bug.cgi?id=201359

Reviewed by Alex Christensen.

Source/WebCore:

Move BlobLoader in its own file.
Introduce NetworkSendQueue class to handle the sending of messages, some of them being blobs.
This class ensures that messages will be sent in order, even though blob data is resolved asynchronously.

Covered by existing tests.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
fileapi/BlobLoader.h: Added.

(WebCore::BlobLoader::BlobLoader):
(WebCore::BlobLoader::~BlobLoader):
(WebCore::BlobLoader::didFinishLoading):
(WebCore::BlobLoader::didFail):
(WebCore::BlobLoader::complete):

fileapi/NetworkSendQueue.cpp: Added.

(WebCore::NetworkSendQueue::NetworkSendQueue):
(WebCore::NetworkSendQueue::enqueue):
(WebCore::NetworkSendQueue::clear):
(WebCore::NetworkSendQueue::processMessages):

fileapi/NetworkSendQueue.h: Added.

Source/WebKit:

Make use of newly added NetworkSendQueue.

WebProcess/Network/WebSocketChannel.cpp:

(WebKit::WebSocketChannel::createMessageQueue):
(WebKit::WebSocketChannel::WebSocketChannel):
(WebKit::WebSocketChannel::send):
(WebKit::WebSocketChannel::disconnect):

WebProcess/Network/WebSocketChannel.h:

8:19 AM Changeset in webkit [249480] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Allow checking whether image was created from JavaScript
https://bugs.webkit.org/show_bug.cgi?id=200662

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-04
Reviewed by Darin Adler.

No behavior change.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::create):

html/HTMLImageElement.h:

(WebCore::HTMLImageElement::createdByParser const):

html/HTMLTagNames.in:

5:46 AM Changeset in webkit [249479] by youenn@apple.com

29 edits
2 moves in trunk/Source

Move MessageRegistry to NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=201299

Reviewed by Alex Christensen.

Move message registry to NetworkProcess.
Take benefit of this move to use async reply IPC as much as possible.
This also allows to remove the IPC message to UIProcess when doing postMessage with service workers.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::createNewMessagePortChannel):
(WebKit::NetworkConnectionToWebProcess::entangleLocalPortInThisProcessToRemote):
(WebKit::NetworkConnectionToWebProcess::messagePortDisentangled):
(WebKit::NetworkConnectionToWebProcess::messagePortClosed):
(WebKit::NetworkConnectionToWebProcess::nextMessageBatchIdentifier):
(WebKit::NetworkConnectionToWebProcess::takeAllMessagesForPort):
(WebKit::NetworkConnectionToWebProcess::didDeliverMessagePortMessages):
(WebKit::NetworkConnectionToWebProcess::postMessageToRemote):
(WebKit::NetworkConnectionToWebProcess::checkRemotePortForActivity):
(WebKit::NetworkConnectionToWebProcess::checkProcessLocalPortForActivity):

NetworkProcess/NetworkConnectionToWebProcess.h:
NetworkProcess/NetworkConnectionToWebProcess.messages.in:
NetworkProcess/NetworkMessagePortChannelProvider.cpp: Added.

(WebKit::NetworkMessagePortChannelProvider::NetworkMessagePortChannelProvider):
(WebKit::NetworkMessagePortChannelProvider::createNewMessagePortChannel):
(WebKit::NetworkMessagePortChannelProvider::entangleLocalPortInThisProcessToRemote):
(WebKit::NetworkMessagePortChannelProvider::messagePortDisentangled):
(WebKit::NetworkMessagePortChannelProvider::messagePortClosed):
(WebKit::NetworkMessagePortChannelProvider::takeAllMessagesForPort):
(WebKit::NetworkMessagePortChannelProvider::postMessageToRemote):
(WebKit::NetworkMessagePortChannelProvider::checkRemotePortForActivity):
(WebKit::NetworkMessagePortChannelProvider::checkProcessLocalPortForActivity):

NetworkProcess/NetworkMessagePortChannelProvider.h: Added.
NetworkProcess/NetworkProcess.cpp:

(WebKit::m_messagePortChannelProvider):
(WebKit::NetworkProcess::webProcessConnection const):

NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::messagePortChannelRegistry):

Sources.txt:
UIProcess/Downloads/DownloadProxyMap.cpp:
UIProcess/WebPageProxy.cpp:
UIProcess/WebProcessPool.cpp:
UIProcess/WebProcessPool.h:
UIProcess/WebProcessPool.messages.in:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::~WebProcessProxy):
(WebKit::WebProcessProxy::shutDown):

UIProcess/WebProcessProxy.h:
UIProcess/WebProcessProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::initializeSWClientConnection):
(WebKit::NetworkProcessConnection::messagesAvailableForPort):
(WebKit::NetworkProcessConnection::checkProcessLocalPortForActivity):

WebProcess/Network/NetworkProcessConnection.h:
WebProcess/Network/NetworkProcessConnection.messages.in:
WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorker):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::postMessageToServiceWorkerClient):

WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp:

(WebKit::networkProcessConnection):
(WebKit::WebMessagePortChannelProvider::createNewMessagePortChannel):
(WebKit::WebMessagePortChannelProvider::entangleLocalPortInThisProcessToRemote):
(WebKit::WebMessagePortChannelProvider::messagePortDisentangled):
(WebKit::WebMessagePortChannelProvider::messagePortClosed):
(WebKit::WebMessagePortChannelProvider::takeAllMessagesForPort):
(WebKit::WebMessagePortChannelProvider::postMessageToRemote):
(WebKit::WebMessagePortChannelProvider::checkRemotePortForActivity):

WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:
WebProcess/WebProcess.cpp:
WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

5:27 AM Changeset in webkit [249478] by zandobersek@gmail.com

1 edit
2 deletes in trunk/Source/WebCore

Remove unused ScrollingTreeOverflowScrollProxyNode implementation
https://bugs.webkit.org/show_bug.cgi?id=201376

Reviewed by Simon Fraser.

Remove the unused ScrollingTreeOverflowScrollProxyNode implementation
and header files that were added in r246723 but are not included in any
build. Cocoa-specific implementation remains untouched, and other
scrolling systems should be providing their own (as is the case with
other types of nodes).

page/scrolling/ScrollingTreeOverflowScrollProxyNode.cpp: Removed.
page/scrolling/ScrollingTreeOverflowScrollProxyNode.h: Removed.

2:10 AM WebKitGTK/2.24.x edited by berto@igalia.com

(diff)

2:09 AM WebKitGTK/2.24.x edited by berto@igalia.com

(diff)

2:04 AM Changeset in webkit [249477] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] Sound is down-pitched when playing video from YLE Areena
https://bugs.webkit.org/show_bug.cgi?id=201399

Reviewed by Xabier Rodriguez-Calvar.

If the FDK-AAC decoder is available, promote it and downrank the
libav AAC decoders, due to their broken LC support, as reported in:
https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247063.html

platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

1:37 AM Changeset in webkit [249476] by Kocsen Chung

7 edits in branches/safari-608-branch/Source

Versioning.

1:35 AM Changeset in webkit [249475] by Kocsen Chung

11 edits
6 adds in branches/safari-608-branch

Cherry-pick r249368. rdar://problem/55001166

Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
https://bugs.webkit.org/show_bug.cgi?id=201346
<rdar://problem/54885784>

Reviewed by Dean Jackson.

Source/WebKit:

For apps that are linked on or after iOS 13, we add a context menu interaction to the content view, which
requires us to disable (or avoid adding) the highlight long press gesture recognizer. However, for apps that are
linked on the iOS 12 SDK or prior, this gesture is still present, and fires when long pressing for (roughly) up
to 0.75 seconds if a tap gesture was not recognized instead. Firing this gesture sends a click event to the
page; this brings back some form of <rdar://problem/53889373>, but only when holding for slightly longer than a
normal tap, and also only in apps linked on iOS 12 or earlier. To fix this, we apply a similar solution as in
r248433 and detect whether a long press gesture interrupted scroll view deceleration in
-gestureRecognizerShouldBegin:. If so, we return NO to avoid clicking. See per-method comments below for more
details.

Testing this bug as-is was tricky, since there's no way in layout tests to simulate being linked on or before a
given SDK version. Luckily, recall that:

This bug occurs when the highlight gesture recognizer is enabled and added to the content view.
The highlight gesture recognizer only needs to be disabled or removed when context menu interaction is added. As such, we should be able to restore the highlight gesture recognizer by suppressing the context menu interaction in an app linked-on-or-after iOS 13, by setting allowsLinkPreview to NO. Unfortunately, this doesn't quite work, since we currently always avoid adding the highlight gesture recognizer if the app is linked on iOS 13 or later.

However, this means that the highlight gesture recognizer is absent from the content view in apps linked against
iOS 13 that disable link previews, even though its absence is not required. This means that long pressing a
clickable element in a web view that disables link previews does not show a tap highlight on iOS 13, whereas it
would on iOS 12; this is a regression, albeit a very subtle one. To fix this subtle issue and make it possible
to write a test for this bug, we refactor some logic for creating and configuring the highlight long press
gesture, such that we now unconditionally add the highlight gesture, but only enable it in apps linked on or
after iOS 13 if link previews (i.e. context menu interaction) are not allowed.

Test: fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html

SourcesCocoa.txt:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView setAllowsLinkPreview:]):
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setupInteraction]):

Refactor our gesture setup logic to always create and add the long press and highlight long press gestures, but
conditionally disable them based on whether or not (1) the context menu is available, and (2) WKWebView's
allowsLinkPreview property.

(-[WKContentView _didChangeLinkPreviewAvailability]):
(-[WKContentView _updateLongPressAndHighlightLongPressGestures]):

Add a new helper to update the enabled state of the long press and highlight long press gestures, by consulting
-_shouldUseContextMenu and -allowsLinkPreview. This is called when setting up the gestures, as well as whenever
-allowsLinkPreview changes.

(-[WKContentView gestureRecognizerShouldBegin:]):

Factor out logic to ascend the view hierarchy in search of a UIScrollView that was interrupted while
decelerating into a local lambda function; use this for both the highlight gesture and the single tap gesture,
to determine whether they should begin.

UIProcess/ios/WKHighlightLongPressGestureRecognizer.h: Added.
UIProcess/ios/WKHighlightLongPressGestureRecognizer.mm: Added.

In order to remember the UIScrollView (if any) tracked by the highlight long press gesture, we subclass
_UIWebHighlightLongPressGestureRecognizer. While UILongPressGestureRecognizer does have SPI to ask for a list of
UITouches, by the time the gesture has been recognized and the gesture delegates are invoked, these UITouches
no longer correspond to UIViews. As such, the only time we have access to the list of UITouches with their
UIViews is during the touches* subclass hooks.

(-[WKHighlightLongPressGestureRecognizer reset]):

Clear out the tracked UIScrollView here, when the gesture is reset (i.e. after ending, or being canceled).

(-[WKHighlightLongPressGestureRecognizer touchesBegan:withEvent:]):

Remember the last touched UIScrollView here.

(-[WKHighlightLongPressGestureRecognizer lastTouchedScrollView]):

WebKit.xcodeproj/project.pbxproj:

Tools:

Add a new test option to allow tests to disable link previews.

WebKitTestRunner/TestController.cpp: (WTR::updateTestOptionsFromTestHeader):
WebKitTestRunner/TestOptions.h:

Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.

(WTR::TestOptions::hasSameInitializationOptions const):

WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateWebView):

LayoutTests:

Add a couple of new layout tests to verify that using a long press gesture to interrupt momentum scrolling in a
web view that uses API to disable link previews does not result in a click.

fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-main-frame-expected.txt: Added.
fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-main-frame.html: Added.
fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow-expected.txt: Added.
fast/scrolling/ios/click-events-after-long-press-during-momentum-scroll-in-overflow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:29 AM Changeset in webkit [249474] by Pablo Saavedra

4 edits in trunk/Source/WebCore

[GTK] Build failure in Debian Stable and Ubuntu LTS bots after r249427
https://bugs.webkit.org/show_bug.cgi?id=201434

Reviewed by Xabier Rodriguez-Calvar.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::waitForCPUSync):

1:20 AM Changeset in webkit [249473] by Kocsen Chung

8 edits
2 adds in branches/safari-608-branch

Cherry-pick r249147. rdar://problem/55001178

Removing fullscreen element in rAF() callback after requestFullscreen() can leave fullscreen in inconsistent state.
https://bugs.webkit.org/show_bug.cgi?id=201101
<rdar://problem/54164587>

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/full-screen-request-removed-with-raf.html

Add a new state variable, m_pendingFullscreenElement, to track which element is about to
become the fullscreen element, so that when elements are removed or cancelFullscreen() is
called, the state machine inside the fullscreen algorithm can cancel effectively.

dom/FullscreenManager.cpp: (WebCore::FullscreenManager::requestFullscreenForElement): (WebCore::FullscreenManager::cancelFullscreen): (WebCore::FullscreenManager::exitFullscreen): (WebCore::FullscreenManager::willEnterFullscreen): (WebCore::FullscreenManager::willExitFullscreen): (WebCore::FullscreenManager::didExitFullscreen): (WebCore::FullscreenManager::adjustFullscreenElementOnNodeRemoval): (WebCore::FullscreenManager::clear): (WebCore::FullscreenManager::fullscreenElementRemoved): Deleted.
dom/FullscreenManager.h:

Source/WebKit:

Add more state to track in which direction the animation is flowing to allow in-process
animations to be cancelled more gracefully.

UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController enterFullScreen]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController requestExitFullScreen]): (-[WKFullScreenWindowController exitFullScreen]):
WebProcess/cocoa/VideoFullscreenManager.h: (WebKit::VideoFullscreenInterfaceContext::animationState const): (WebKit::VideoFullscreenInterfaceContext::setAnimationState): (WebKit::VideoFullscreenInterfaceContext::isAnimating const): Deleted. (WebKit::VideoFullscreenInterfaceContext::setIsAnimating): Deleted.
WebProcess/cocoa/VideoFullscreenManager.mm: (WebKit::VideoFullscreenManager::enterVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::exitVideoFullscreenForVideoElement): (WebKit::VideoFullscreenManager::didEnterFullscreen): (WebKit::VideoFullscreenManager::didCleanupFullscreen):

LayoutTests:

fullscreen/full-screen-request-removed-with-raf-expected.txt: Added.
fullscreen/full-screen-request-removed-with-raf.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:20 AM Changeset in webkit [249472] by Kocsen Chung

4 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r249140. rdar://problem/55001152

Image pasted from screenshot into Mail compose window via share sheet has the wrong aspect ratio
https://bugs.webkit.org/show_bug.cgi?id=201171
<rdar://problem/54671275>

Reviewed by Tim Horton.

Augments an existing app-specific hack to include the Mail composition service, in addition to Mail.

platform/RuntimeApplicationChecks.h:
platform/cocoa/RuntimeApplicationChecksCocoa.mm: (WebCore::IOSApplication::isMailCompositionService):

Add a new bundle checking method for the Mail composition service (com.apple.MailCompositionService).

platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex):

Only plumb the preferred presentation height through to the web process if the application is neither Mail nor
the Mail composition service. In the future, we should consider putting this hack behind SPI, or maybe only
expose the preferred presentation width in all apps (it isn't difficult to imagine a use case where a "Mail-
compose-like" web app has img { max-width: 100%; } in their stylesheet).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:20 AM Changeset in webkit [249471] by Kocsen Chung

8 edits
2 adds in branches/safari-608-branch

Cherry-pick r249339. rdar://problem/55001170

Caret does not appear in text field inside a transformed, overflow: hidden container
https://bugs.webkit.org/show_bug.cgi?id=201317
<rdar://problem/54859264>

Reviewed by Simon Fraser.

Source/WebCore:

This patch refactors the heuristic for determining whether to suppress selection gestures and UI in a way that
fixes the corner case encountered in this bug. To understand why this test case fails with our existing
heuristic, consider the below test case.

Let's say we have an input field inside an "overflow: hidden;" container, which is positioned in such a way that
it is completely clipped by its enclosing container which is also "overflow: hidden". Our existing logic would
appropriately identify this as a hidden editable element.

However, let's now apply a transform to the input field's closest "overflow: hidden" ancestor, such that the
field is now visible. Since RenderLayer::offsetFromAncestor doesn't take transforms into account when we try to
find the offset of the "overflow: hidden" layer relative to the root view, we end up passing an offsetFromRoot
of (0, 100vw) to RenderLayer::calculateClipRects, which computes a background clip rect of (0, 0, 100vw, 100vh).

This means that at the end of RenderLayer::calculateClipRects, we end up intersecting the background clip rect
(0, 0, 100vw, 100vh) against (100vw, 0, 100vw, 100vh), which results in the empty rect, and subsequently makes
us believe we're editing a hidden editable element.

Instead of tacking on more logic to isTransparentOrFullyClippedRespectingParentFrames, we can fix this by using
RenderObject::computeVisibleRectInContainer instead, performing a similar walk up the render tree to compute the
visible rect of each focused element or subframe relative to its root. This is capable of taking transforms into
account. See comments below for more details.

Test: editing/selection/ios/show-selection-in-transformed-container-2.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::isTransparentRespectingParentFrames const):

Split out isTransparentOrFullyClippedRespectingParentFrames into two methods: RenderLayer's
isTransparentRespectingParentFrames, and RenderObject's hasNonEmptyVisibleRectRespectingParentFrames. The
transparency check starts at the enclosing layer and walks up the layer tree, while the non-empty visible rect
check looks for renderers that are completely empty relative to their root views.

rendering/RenderLayer.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::hasNonEmptyVisibleRectRespectingParentFrames const):

Rewrite logic for detecting completely clipped editable areas (that formerly lived in
isTransparentOrFullyClippedRespectingParentFrames) to use computeVisibleRectInContainer instead.

rendering/RenderObject.h:

Source/WebKit:

Adjust isTransparentOrFullyClipped to use the new methods in RenderLayer and RenderObject. See WebCore ChangeLog
for more details.

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::isTransparentOrFullyClipped const):

LayoutTests:

Add a new layout test that covers this scenario. See WebCore ChangeLog for additional detail.

editing/selection/ios/show-selection-in-transformed-container-2-expected.txt: Added.
editing/selection/ios/show-selection-in-transformed-container-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249470] by Kocsen Chung

3 edits
2 adds in branches/safari-608-branch

Cherry-pick r249296. rdar://problem/55001174

[iOS 13] Caret does not appear in text field if the body element is translated completely out of the viewport
https://bugs.webkit.org/show_bug.cgi?id=201287
<rdar://problem/54780864>

Reviewed by Tim Horton.

Source/WebKit:

During EditorState computation, we use the hidden editable element heuristic to determine whether we should
begin suppressing selection gestures and UI. Currently, we use the editable root of the selection range to
determine where in the layer tree we should start our ascent, in search of a completely transparent or
completely clipped container.

However, in the case where the selection is inside a focused text field, this causes us to walk up the layer
tree starting at the RenderLayer corresponding to the text field's inner contenteditable div, which is different
than the text field's enclosing RenderLayer in the case where the containing block is transformed, such that no
part of it is within the visible viewport. This scenario is exercised by the below test case, in which the caret
after transforming the body horizontally by -100vw is hidden due to a false positive in the hidden editable area
heuristic.

Fix this by starting the layer tree ascent from the enclosing layer of the text form control if applicable,
instead of the inner editable area under the shadow root of the form control.

Test: editing/selection/ios/show-selection-in-transformed-container.html

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::platformEditorState const):

LayoutTests:

Add a new layout test that covers this scenario. See WebKit ChangeLog for additional detail.

editing/selection/ios/show-selection-in-transformed-container-expected.txt: Added.
editing/selection/ios/show-selection-in-transformed-container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249469] by Kocsen Chung

4 edits
2 adds in branches/safari-608-branch

Cherry-pick r249230. rdar://problem/55001168

Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
https://bugs.webkit.org/show_bug.cgi?id=201256
<rdar://problem/54809509>

Reviewed by Simon Fraser.

Source/WebKit:

WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::restorePageState): When restoring page state from a history item, if the saved scale was equal to the initial scale at the time it was saved, ignore the saved scale and use the current initial scale instead.

Normally this doesn't matter because a given page's initial scale doesn't usually change
between loads, but it totally can! See the test for one example of a way an API client
might cause this; you could also imagine something similar happening if the actual
page content changed.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added. (TestWebKitAPI::TEST): Add a test. I left many comments because I had a great deal of trouble writing this test and wanted to document my findings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249468] by Kocsen Chung

4 edits
1 add in branches/safari-608-branch

Cherry-pick r249115. rdar://problem/55001212

Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
<https://webkit.org/b/201144>
<rdar://problem/54689399>

Reviewed by Brent Fulgham.

Source/WebCore:

editing/cocoa/DataDetection.mm: (WebCore::buildQuery): Extract common variables to prevent double conversion for 8-bit strings.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add DataDetectorsTestIOS.mm to the project.
TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new test for Data Detectors for phone numbers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249467] by Kocsen Chung

3 edits
2 adds in branches/safari-608-branch

Cherry-pick r249026. rdar://problem/55001375

Crash may happen when an SVG <feImage> element references the root <svg> element
https://bugs.webkit.org/show_bug.cgi?id=201014

Reviewed by Ryosuke Niwa.

Source/WebCore:

When an <feImage> references an <svg> element as its target image but
this <svg> element is also one of the ancestors of the <feImage>, the
parent <filter> should not be applied.

Test: svg/filters/filter-image-ref-root.html

svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build const):

LayoutTests:

Ensure the cyclic reference between the <feImage> renderer and its
ancestor <svg> root renderer is broken.

svg/filters/filter-image-ref-root-expected.txt: Added.
svg/filters/filter-image-ref-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249466] by Kocsen Chung

8 edits in branches/safari-608-branch/Source/JavaScriptCore

Cherry-pick r248824. rdar://problem/55001142

[JSC] WebAssembly BBQ should switch compile mode for size of modules
https://bugs.webkit.org/show_bug.cgi?id=200807

Reviewed by Mark Lam.

Some webpages use very large Wasm module, and it exhausts all executable memory in ARM64 devices since the size of executable memory region is 128MB.
The long term solution should be introducing Wasm interpreter. But as a short term solution, we introduce heuristics switching back to BBQ B3 at
the sacrifice of start-up time, since BBQ Air bloats such lengthy code, and thereby consumes a large amount of executable memory.

Currently, I picked 10MB since the reported website is using 11MB wasm module.

runtime/Options.h:
wasm/WasmAirIRGenerator.cpp: (JSC::Wasm::parseAndCompileAir):
wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::parseAndCompile):
wasm/WasmBBQPlan.cpp: (JSC::Wasm::BBQPlan::compileFunctions):
wasm/WasmModuleInformation.h:
wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseCode):
wasm/WasmStreamingParser.cpp: (JSC::Wasm::StreamingParser::parseCodeSectionSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249465] by Kocsen Chung

3 edits
1 add in branches/safari-608-branch

Cherry-pick r248793. rdar://problem/55001191

[JSC] Promise.prototype.finally should accept non-promise objects
https://bugs.webkit.org/show_bug.cgi?id=200829

Reviewed by Mark Lam.

JSTests:

stress/promise-finally-should-accept-non-promise-objects.js: Added. (shouldBe): (Thenable): (Thenable.prototype.then):

Source/JavaScriptCore:

According to the Promise.prototype.finally spec step 2[1], we should check @isObject instead of @isPromise,
since Promise.prototype.finally should accept thenable objects that are defined by user libraries (like, bluebird for example).
This patch changes this check to the specified one.

[1]: https://tc39.es/proposal-promise-finally/

builtins/PromisePrototype.js: (finally):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249464] by Kocsen Chung

2 edits in branches/safari-608-branch/Source/WebKit

Cherry-pick r248698. rdar://problem/55001378

Fix the build when ENABLE(APPLE_PAY) is false.

Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249463] by Kocsen Chung

13 edits in branches/safari-608-branch/Source

Cherry-pick r248692. rdar://problem/55001378

[Cocoa] Add some WKA extension points
https://bugs.webkit.org/show_bug.cgi?id=200506
<rdar://problem/51682474>

Reviewed by Tim Horton.

Source/WebCore:

Modules/applepay/ApplePayPayment.h:
Modules/applepay/ApplePayPaymentMethod.h:
Modules/applepay/ApplePayRequestBase.cpp: (WebCore::finishConverting): (WebCore::convertAndValidate):
Modules/applepay/ApplePayRequestBase.h:
Modules/applepay/ApplePaySessionPaymentRequest.h:
Modules/applepay/PaymentCoordinatorClient.cpp: (WebCore::PaymentCoordinatorClient::supportsVersion):
Modules/applepay/cocoa/PaymentCocoa.mm: (WebCore::convert):
Modules/applepay/cocoa/PaymentMethodCocoa.mm: (WebCore::finishConverting): (WebCore::convert):

Source/WebKit:

Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm: (WebKit::finishCreating): (WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest):
Shared/Cocoa/WebCoreArgumentCodersCocoa.mm: (IPC::finishDecoding): (IPC::finishEncoding): (IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode): (IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:19 AM Changeset in webkit [249462] by Kocsen Chung

10 edits in branches/safari-608-branch/Source/WebCore

Cherry-pick r248275. rdar://problem/55001373

[WebIDL] Support partial dictionaries and conditional dictionary members
https://bugs.webkit.org/show_bug.cgi?id=200441

Reviewed by Alex Christensen.

Added new bindings tests.

bindings/scripts/CodeGeneratorJS.pm: (GenerateDictionaryImplementationContent):
bindings/scripts/IDLParser.pm: (parsePartialDefinition): (parsePartialInterface): Deleted. (parsePartialDictionary): Deleted.
bindings/scripts/generate-bindings.pl: (generateBindings):
bindings/scripts/preprocess-idls.pl: (getPartialNamesFromIDL): (getPartialInterfaceNameFromIDL): Deleted.
bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::convertDictionary<TestEventConstructor::Init>):
bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp: (WebCore::convertDictionary<DictionaryImplName>): (WebCore::convertDictionaryToJS):
bindings/scripts/test/JS/JSTestStandaloneDictionary.h:
bindings/scripts/test/TestStandaloneDictionary.idl:
bindings/scripts/test/TestSupplemental.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:16 AM Changeset in webkit [249461] by ysuzuki@apple.com

13 edits in trunk

[bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
https://bugs.webkit.org/show_bug.cgi?id=201448

Reviewed by Mark Lam.

Source/bmalloc:

In the base class of IsoTLSEntry and IsoHeapImplBase, we register each instance with the per-process linked-list singleton to
offer a way to iterate all these instances. But since derived classes of IsoTLSEntry and IsoHeapImplBase have virtual functions,
the instance is not fully instantiated yet when executing the base constructor! In particular, the register instance needs vtable pointer
initialization in the derived constructor.

So, there is a race condition,

IsoTLSEntry adds itself to the global linked-list.
IsoTLSEntry's derived class is initializing the instance including vtable pointer, this happens because base and derived classes have virtual functions.
While doing (2), other thread iterates instances through (1)'s linked-list and call virtual functions

Then, crash happens because the instance vtable pointer hasn't been set to the derived class' vtable yet. IsoHeapImpl has the same problem.
This issue causes some crashes in bmalloc::Scavenger::scavenge / bmalloc::IsoTLS::ensureEntries.

In this patch,

We introduce IsoTLSEntryHolder, which initialize the TLS entry. And after fully initializing it, the holder registers the entry with the IsoTLSLayout singleton.
We call IsoHeapImplBase::addToAllIsoHeaps after IsoHeapImpl is fully initialized.
We put memory barrier in IsoTLSLayout since IsoTLSLayout::head does not take a lock.
We add unit-test that reliably reproduces IsoHeapImpl crash if we run this test ~10 times!

bmalloc/AllIsoHeaps.h:
bmalloc/IsoHeapImpl.h:
bmalloc/IsoHeapImplInlines.h:

(bmalloc::IsoHeapImpl<Config>::IsoHeapImpl):
(bmalloc::IsoHeapImpl<Config>::allocatorOffset):
(bmalloc::IsoHeapImpl<Config>::deallocatorOffset):

bmalloc/IsoHeapInlines.h:

(bmalloc::api::IsoHeap<Type>::initialize):

bmalloc/IsoTLSAllocatorEntry.h:
bmalloc/IsoTLSDeallocatorEntry.h:
bmalloc/IsoTLSEntry.cpp:

(bmalloc::IsoTLSEntry::IsoTLSEntry):

bmalloc/IsoTLSEntry.h:

(bmalloc::IsoTLSEntryHolder::IsoTLSEntryHolder):
(bmalloc::IsoTLSEntryHolder::operator* const):
(bmalloc::IsoTLSEntryHolder::operator*):
(bmalloc::IsoTLSEntryHolder::operator-> const):
(bmalloc::IsoTLSEntryHolder::operator->):

bmalloc/IsoTLSLayout.cpp:

(bmalloc::IsoTLSLayout::add):

bmalloc/IsoTLSLayout.h:

Tools:

TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:

(TEST):

1:14 AM Changeset in webkit [249460] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

REGRESSION (r249364): Layout Test webgpu/texture-triangle-strip.html is Failing
https://bugs.webkit.org/show_bug.cgi?id=201425

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-09-04
Reviewed by Myles C. Maxfield.

The orientation of webgpu/resources/blue-checkered.png is OriginRightTop.
Because r249364 made the image orientation respected everywhere including
the canvas drawImage(), the expected result does not match the output of
the test anymore.

The fix is to change the the expected result to match the image drawing
when the image orientation is respected.

Context Navigation

Timeline

Sep 5, 2019:

Sep 4, 2019:

Download in other formats: