Context Navigation

← Previous Period
Next Period →

Timeline

Sep 6, 2019:

10:59 PM Changeset in webkit [249609] by Brent Fulgham

3 edits in trunk/Source/WebCore

[FTW] Minor cleanups to avoid crashes during web browsing
https://bugs.webkit.org/show_bug.cgi?id=201572

Reviewed by Alexey Proskuryakov.

This patch addresses a few crashes seen when doing general web browsing using
the FTW build of WebKit:

ImageBuffer::sinkIntoImage was attempting to use a render target after WTFMoving it elsewhere.
ImageBuffer::copyNativeImage was not properly checking the type of the render target to make sure it was suitable for Bitmap operations.
BackingStoreBackendDirect2DImpl::scroll would crash if the scroll offset was outside the bounds of the current view. In that case, it would attempt to allocate a zero-size texture, which triggered a crash.

platform/graphics/win/BackingStoreBackendDirect2DImpl.cpp:

(WebCore::BackingStoreBackendDirect2DImpl::scroll):

platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::sinkIntoImage):
(WebCore::ImageBuffer::copyNativeImage const):

10:42 PM Changeset in webkit [249608] by mark.lam@apple.com

11 edits in trunk/Source

Harden protection of the Gigacage Config parameters.
https://bugs.webkit.org/show_bug.cgi?id=201570
<rdar://problem/55134229>

Reviewed by Saam Barati.

Source/bmalloc:

Rename protectGigacageBasePtrs() and unprotectGigacageBasePtrs() to freezeGigacageConfig() and unfreezeGigacageConfig() respectively.

Also move the alignment check in protectGigacageBasePtrs() into ensureGigacage().
There's no need to check it more than once.

Introduce permanentlyFreezeGigacageConfig() which permanently makes the Config ReadOnly. Once invoked, the Config cannot be made writable again.

This is made possible by using vm_protect with a true set_maximum argument.
We also add a g_gigacageConfig.isPermanentlyFrozen flag that we assert.
Note: this permanence is only true for OS(DARWIN) since vm_protect is Mach API.

Rename disableDisablingPrimitiveGigacageIfShouldBeEnabled() to forbidDisablingPrimitiveGigacage() because "disablingDisabling" is a tongue twister.

Also, we don't want to make it conditional on "IfShouldBeEnabled". We want
forbidDisablingPrimitiveGigacage() to be irreversible. It is up to the client
to ensure that the Gigacage is already initialized (if possible) before
invoking forbidDisablingPrimitiveGigacage(). Conceptually, the forbidding
isn't about guaranteeing that the Gigacage is enabled. It only takes away the
option to disable it.

That said, forbidDisablingPrimitiveGigacage() is only invoked by clients that
care about keeping the Gigacage enabled. So, it does a sanity check (with an
assertion) that if !GIGACAGE_ALLOCATION_CAN_FAIL, then the Gigacage should be
have been initialized and enabled before invoking it.

We also make sure that forbidDisablingPrimitiveGigacage() calls
permanentlyFreezeGigacageConfig() unconditionally. It is safe to call it more
than once. This guarantees that the Config is permanently frozen after this,
even if a bug should inadvertantly set the
g_gigacageConfig.disablingPrimitiveGigacageIsForbidden flag before
forbidDisablingPrimitiveGigacage() is invoked.

Assert that ensureGigacage() is only called once.

Assert that shouldBeEnabled() is only called once. Also moved its cached result into the Config so that it can be frozen.

bmalloc/Gigacage.cpp:

(Gigacage::bmalloc::freezeGigacageConfig):
(Gigacage::bmalloc::unfreezeGigacageConfig):
(Gigacage::bmalloc::permanentlyFreezeGigacageConfig):
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::UnfreezeGigacageConfigScope):
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::~UnfreezeGigacageConfigScope):
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::verifyGigacageIsEnabled):
(Gigacage::forbidDisablingPrimitiveGigacage):
(Gigacage::isDisablingPrimitiveGigacageForbidden):
(Gigacage::shouldBeEnabled):
(Gigacage::bmalloc::protectGigacageBasePtrs): Deleted.
(Gigacage::bmalloc::unprotectGigacageBasePtrs): Deleted.
(Gigacage::bmalloc::UnprotectGigacageBasePtrsScope::UnprotectGigacageBasePtrsScope): Deleted.
(Gigacage::bmalloc::UnprotectGigacageBasePtrsScope::~UnprotectGigacageBasePtrsScope): Deleted.
(Gigacage::primitiveGigacageDisabled): Deleted.
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled): Deleted.
(Gigacage::isDisablingPrimitiveGigacageDisabled): Deleted.

bmalloc/Gigacage.h:

(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):
(Gigacage::forbidDisablingPrimitiveGigacage):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled): Deleted.

Source/JavaScriptCore:

Just renaming some function names here.

assembler/testmasm.cpp:

(JSC::testCagePreservesPACFailureBit):

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cageConditionally):

jsc.cpp:

(jscmain):

Source/WebKit:

Just renaming a function name here.

WebProcess/WebProcess.cpp:

Source/WTF:

Just renaming some function names here.

wtf/Gigacage.h:

(Gigacage::forbidDisablingPrimitiveGigacage):
(Gigacage::isDisablingPrimitiveGigacageForbidden):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled): Deleted.
(Gigacage::isDisablingPrimitiveGigacageDisabled): Deleted.

9:19 PM Changeset in webkit [249607] by Devin Rousso

5 edits in trunk

Web Inspector: CSS Formatter: the closing } of nested @media aren't indented
https://bugs.webkit.org/show_bug.cgi?id=201560

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

UserInterface/Workers/Formatter/FormatterContentBuilder.js:

(FormatterContentBuilder.prototype.removeLastNewline):
It's possible that there were multiple newlines in a row, so we should update _startOfLine
to be true if the previous line was empty.

LayoutTests:

inspector/formatting/resources/css-tests/media-query.css:
inspector/formatting/resources/css-tests/media-query-expected.css:

8:19 PM Changeset in webkit [249606] by bshafiei@apple.com

1 copy in tags/Safari-608.2.11.1.3

Tag Safari-608.2.11.1.3.

7:58 PM Changeset in webkit [249605] by Wenson Hsieh

16 edits
5 adds in trunk

Incorrect selection rect revealed after pasting images in a contenteditable element
https://bugs.webkit.org/show_bug.cgi?id=201549
<rdar://problem/50956429>

Reviewed by Simon Fraser.

Source/WebCore:

Editor::replaceSelectionWithFragment currently scrolls to reveal the selection after inserting the given
DocumentFragment. However, this scrolling occurs before any inserted images have loaded yet, which causes the
wrong caret rect to be revealed, since all image elements inserted during paste will be empty.

To fix this, we defer revealing the selection after inserting the fragment until after all images that have
been inserted are done loading. While waiting for images to load, if any layers which may be scrolled as a
result of revealing the selection are scrolled, we additionally cancel the deferred selection reveal. See
comments below for more detail.

Tests: editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll.html

editing/pasteboard/reveal-selection-after-pasting-images.html
PasteImage.RevealSelectionAfterPastingImage

editing/Editing.cpp:

(WebCore::visibleImageElementsInRangeWithNonLoadedImages):

Add a new helper to iterate through a range and collect all image elements in that range, that contain cached
images that have not finished loading yet.

editing/Editing.h:
editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment):

Instead of always immediately revealing the selection after applying the ReplaceSelectionCommand, collect the
image elements that were just inserted, and avoid immediately revealing the selection if any of these images
have non-null cached images, but are not loaded yet. Instead, hold on to these images in a set, remove them once
they finish loading using the new method below, and once all images are removed, reveal the selection.

(WebCore::Editor::revealSelectionIfNeededAfterLoadingImageForElement):
(WebCore::Editor::renderLayerDidScroll):

Called whenever a scrollable RenderLayer is scrolled (or in the case of FrameView, the root layer). In the case
where Editor is waiting to reveal the selection, we check to see if the scrolled layer is an ancestor of the
layer enclosing the start of the selection.

(WebCore::Editor::respondToChangedSelection):

If the selection changes between pasting and waiting for pasted images to load, just cancel waiting to reveal
the selection after pasting.

editing/Editor.h:
editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertedContentRange const):

Add a helper method to grab the Range of content inserted after applying the command.

editing/ReplaceSelectionCommand.h:
page/FrameView.cpp:

(WebCore::FrameView::scrollPositionChanged):

page/FrameView.h:
page/Page.cpp:

(WebCore::Page::didFinishLoadingImageForElement):

Notify Editor after an image finishes loading.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

Source/WebKit:

Tweak some existing logic to use the new visibleImageElementsInRangeWithNonLoadedImages helper function. See
WebCore for more details.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::didConcludeEditDrag):

Tools:

Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
directly written to the pasteboard.

TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:

LayoutTests:

Add a couple of new layout tests.

editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll-expected.txt: Added.
editing/pasteboard/do-not-reveal-selection-after-programmatic-scroll.html: Added.

This test verifies that we don't try to scroll to reveal the caret after pasting, if the scroll position was
changed before the images finished loading.

editing/pasteboard/reveal-selection-after-pasting-images-expected.txt: Added.
editing/pasteboard/reveal-selection-after-pasting-images.html: Added.
platform/ios/editing/pasteboard/reveal-selection-after-pasting-images-expected.txt: Added.

This test verifies that we reveal the caret after loading multiple pasted images in a selection, and dispatch a
scroll event in the process.

7:39 PM Changeset in webkit [249604] by Brent Fulgham

5 edits in trunk/Source/WebCore

PathDirect2D Cleanups
https://bugs.webkit.org/show_bug.cgi?id=201534

Reviewed by Fujii Hironori.

Add a COMPtr<> move operator.
Reduce copying ID2D1Geometry objects.
Protect against using the ID2D1PathGeometry after the ID2D1GeometrySink's Close operation is used.
Add a debug-only 'refCount' function to COMPtr to help track down memory errors.

platform/graphics/Path.h:

(WebCore::Path::activePath const): Deleted.

platform/graphics/win/Direct2DOperations.cpp:

(WebCore::Direct2D::fillPath):
(WebCore::Direct2D::drawPath):

platform/graphics/win/PathDirect2D.cpp:
platform/win/COMPtr.h:

(COMPtr::COMPtr):
(=):
(refCount):

6:53 PM Changeset in webkit [249603] by Chris Dumez

11 edits
1 copy
1 add in trunk/Source

Move the ResourceLoadObserver logic to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=201517

Reviewed by Brent Fulgham.

Move the ResourceLoadObserver logic to WebKit2 since it is not used by WebKit1. This allows us to simplify
code.

In a follow-up patch, I will simplify the code even further by leveraging the fact that a WebContent process
is always associated with a single WebsiteDataStore / sessionID:

No need for a HashMap of sessionIDs
No need to even allocate the ResourceLoadObserver if the WebProcess is associated with an ephemeral session.

Source/WebCore:

dom/Document.h:
loader/ResourceLoadObserver.cpp:

(WebCore::sharedObserver):
(WebCore::ResourceLoadObserver::setShared):
(WebCore::ResourceLoadObserver::shared):

loader/ResourceLoadObserver.h:

(WebCore::ResourceLoadObserver::~ResourceLoadObserver):
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logWebSocketLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):
(WebCore::ResourceLoadObserver::logFontLoad):
(WebCore::ResourceLoadObserver::logCanvasRead):
(WebCore::ResourceLoadObserver::logCanvasWriteOrMeasure):
(WebCore::ResourceLoadObserver::logNavigatorAPIAccessed):
(WebCore::ResourceLoadObserver::logScreenAPIAccessed):
(WebCore::ResourceLoadObserver::statisticsForURL):
(WebCore::ResourceLoadObserver::updateCentralStatisticsStore):
(WebCore::ResourceLoadObserver::clearState):
(WebCore::ResourceLoadObserver::setShouldLogUserInteraction):

page/DeprecatedGlobalSettings.h:

Source/WebKit:

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::resourceLoadStatisticsUpdated):

NetworkProcess/NetworkConnectionToWebProcess.h:
Sources.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp: Copied from Source/WebCore/loader/ResourceLoadObserver.cpp.

(WebKit::is3xxRedirect):
(WebKit::WebResourceLoadObserver::WebResourceLoadObserver):
(WebKit::WebResourceLoadObserver::shouldLog const):
(WebKit::WebResourceLoadObserver::requestStorageAccessUnderOpener):
(WebKit::WebResourceLoadObserver::ensureResourceStatisticsForRegistrableDomain):
(WebKit::WebResourceLoadObserver::scheduleNotificationIfNeeded):
(WebKit::WebResourceLoadObserver::updateCentralStatisticsStore):
(WebKit::WebResourceLoadObserver::statisticsForURL):
(WebKit::WebResourceLoadObserver::takeStatistics):
(WebKit::WebResourceLoadObserver::clearState):
(WebKit::WebResourceLoadObserver::nonNullOwnerURL const):
(WebKit::WebResourceLoadObserver::logFontLoad):
(WebKit::WebResourceLoadObserver::logCanvasRead):
(WebKit::WebResourceLoadObserver::logCanvasWriteOrMeasure):
(WebKit::WebResourceLoadObserver::logNavigatorAPIAccessed):
(WebKit::WebResourceLoadObserver::logScreenAPIAccessed):
(WebKit::WebResourceLoadObserver::logSubresourceLoading):
(WebKit::WebResourceLoadObserver::logWebSocketLoading):
(WebKit::WebResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

WebProcess/WebCoreSupport/WebResourceLoadObserver.h: Added.
WebProcess/WebProcess.cpp:

5:42 PM Changeset in webkit [249602] by Matt Lewis

4 edits
2 deletes in trunk/Tools

Unreviewed, rolling out r249582.

This caused results.html fail to be created on internal
testers.

Reverted changeset:

"run-webkit-test: Allow results to be uploaded without scm
checkout"
https://bugs.webkit.org/show_bug.cgi?id=200787
https://trac.webkit.org/changeset/249582

5:24 PM Changeset in webkit [249601] by Justin Fan

117 edits
8 moves in trunk

[WebGPU] Update several interface and enum names to match spec
https://bugs.webkit.org/show_bug.cgi?id=201564

Reviewed by Dean Jackson.

Rename GPUShaderStageBit -> GPUShaderStage.
Rename GPUColorWriteBits -> GPUColorWrite.
Rename TRANSFER_SRC/DST -> COPY_SRC/DST.
Source/WebCore:

Rename GPUPipelineStageDescriptor -> GPUProgrammableStageDescriptor.

Existing tests trivially updated to match.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webgpu/GPUBindGroupLayoutBinding.h:
Modules/webgpu/GPUBufferUsage.idl:
Modules/webgpu/GPUColorStateDescriptor.idl:
Modules/webgpu/GPUColorWrite.idl: Renamed from Source/WebCore/Modules/webgpu/GPUColorWriteBits.idl.
Modules/webgpu/GPUShaderStage.h: Renamed from Source/WebCore/Modules/webgpu/GPUShaderStageBit.h.
Modules/webgpu/GPUShaderStage.idl: Renamed from Source/WebCore/Modules/webgpu/GPUShaderStageBit.idl.
Modules/webgpu/GPUTextureUsage.idl:
Modules/webgpu/WebGPUComputePipelineDescriptor.cpp:

(WebCore::WebGPUComputePipelineDescriptor::tryCreateGPUComputePipelineDescriptor const):

Modules/webgpu/WebGPUComputePipelineDescriptor.h:
Modules/webgpu/WebGPUComputePipelineDescriptor.idl:
Modules/webgpu/WebGPUDevice.cpp:
Modules/webgpu/WebGPUProgrammableStageDescriptor.cpp: Renamed from Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.cpp.

(WebCore::WebGPUProgrammableStageDescriptor::tryCreateGPUProgrammableStageDescriptor const):

Modules/webgpu/WebGPUProgrammableStageDescriptor.h: Renamed from Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.h.
Modules/webgpu/WebGPUProgrammableStageDescriptor.idl: Renamed from Source/WebCore/Modules/webgpu/WebGPUPipelineStageDescriptor.idl.
Modules/webgpu/WebGPURenderPipelineDescriptor.cpp:

(WebCore::WebGPURenderPipelineDescriptor::tryCreateGPURenderPipelineDescriptor const):

Modules/webgpu/WebGPURenderPipelineDescriptor.h:
Modules/webgpu/WebGPURenderPipelineDescriptor.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
platform/graphics/gpu/GPUBuffer.h:

(WebCore::GPUBuffer::isCopySource const):
(WebCore::GPUBuffer::isCopyDestination const):
(WebCore::GPUBuffer::isTransferSource const): Deleted.
(WebCore::GPUBuffer::isTransferDestination const): Deleted.

platform/graphics/gpu/GPUBufferUsage.h:
platform/graphics/gpu/GPUColorStateDescriptor.h:
platform/graphics/gpu/GPUColorWrite.h: Renamed from Source/WebCore/platform/graphics/gpu/GPUColorWriteBits.h.
platform/graphics/gpu/GPUComputePipelineDescriptor.h:

(WebCore::GPUComputePipelineDescriptor::GPUComputePipelineDescriptor):

platform/graphics/gpu/GPUPipelineDescriptorBase.h:
platform/graphics/gpu/GPUProgrammableStageDescriptor.h: Renamed from Source/WebCore/platform/graphics/gpu/GPUPipelineStageDescriptor.h.

(WebCore::GPUProgrammableStageDescriptor::GPUProgrammableStageDescriptor):

platform/graphics/gpu/GPURenderPipelineDescriptor.h:

(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor):

platform/graphics/gpu/GPUTexture.h:

(WebCore::GPUTexture::isCopySource const):
(WebCore::GPUTexture::isCopyDestination const):
(WebCore::GPUTexture::isReadOnly const):
(WebCore::GPUTexture::isTransferSource const): Deleted.
(WebCore::GPUTexture::isTransferDestination const): Deleted.

platform/graphics/gpu/GPUTextureUsage.h:
platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:

(WebCore::GPUBindGroupLayout::tryCreate):

platform/graphics/gpu/cocoa/GPUBindGroupMetal.mm:

(WebCore::GPUBindGroup::tryCreate):

platform/graphics/gpu/cocoa/GPUBufferMetal.mm:
platform/graphics/gpu/cocoa/GPUCommandBufferMetal.mm:

(WebCore::GPUCommandBuffer::copyBufferToBuffer):
(WebCore::GPUCommandBuffer::copyBufferToTexture):
(WebCore::GPUCommandBuffer::copyTextureToBuffer):
(WebCore::GPUCommandBuffer::copyTextureToTexture):

platform/graphics/gpu/cocoa/GPUComputePipelineMetal.mm:

(WebCore::trySetFunctions):

platform/graphics/gpu/cocoa/GPUPipelineMetalConvertLayout.cpp:

(WebCore::convertShaderStageFlags):

platform/graphics/gpu/cocoa/GPURenderPipelineMetal.mm:

(WebCore::mtlColorWriteMaskForGPUColorWriteFlags):
(WebCore::trySetFunctions):

platform/graphics/gpu/cocoa/GPUTextureMetal.mm:

(WebCore::mtlTextureUsageForGPUTextureUsageFlags):

LayoutTests:

webgpu/bind-groups.html:
webgpu/blend-color-triangle-strip.html:
webgpu/blit-commands.html:
webgpu/buffer-errors.html:
webgpu/color-write-mask-triangle-strip.html:
webgpu/pipeline-layouts.html:
webgpu/render-pipelines.html:
webgpu/texture-triangle-strip.html:
webgpu/textures-textureviews.html:
webgpu/whlsl/arbitrary-vertex-attribute-locations.html:
webgpu/whlsl/buffer-fragment.html:
webgpu/whlsl/buffer-length.html:
webgpu/whlsl/buffer-vertex.html:
webgpu/whlsl/checker-should-set-type-of-read-modify-write-variables.html:
webgpu/whlsl/compute.html:
webgpu/whlsl/dereference-pointer-should-type-check.html:
webgpu/whlsl/device-proper-type-checker.html:
webgpu/whlsl/do-while-loop-break.html:
webgpu/whlsl/do-while-loop-continue.html:
webgpu/whlsl/do-while-loop.html:
webgpu/whlsl/dont-crash-parsing-enum.html:
webgpu/whlsl/dot-expressions.html:
webgpu/whlsl/duplicate-types-should-not-produce-duplicate-ctors.html:
webgpu/whlsl/ensure-proper-variable-lifetime-2.html:
webgpu/whlsl/ensure-proper-variable-lifetime-3.html:
webgpu/whlsl/ensure-proper-variable-lifetime.html:
webgpu/whlsl/huge-array.html:
webgpu/whlsl/js/test-harness.js:

(Harness.prototype.async.callTypedFunction):
(Harness.prototype._clearResults):
(Harness.prototype._setUpArguments):

webgpu/whlsl/loops-break.html:
webgpu/whlsl/loops-continue.html:
webgpu/whlsl/loops.html:
webgpu/whlsl/make-array-reference.html:
webgpu/whlsl/matrix-2.html:
webgpu/whlsl/matrix-alignment.html:
webgpu/whlsl/matrix-memory-layout.html:
webgpu/whlsl/matrix.html:
webgpu/whlsl/nested-dot-expression-rvalue.html:
webgpu/whlsl/nested-loop.html:
webgpu/whlsl/oob-access.html:
webgpu/whlsl/read-modify-write-high-zombies.html:
webgpu/whlsl/return-local-variable.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-10.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-11.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-12.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-13.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-14.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-15.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-16.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-17.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-18.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-19.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-2.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-20.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-21.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-22.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-23.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-24.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-25.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-26.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-27.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-3.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-4.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-5.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-6.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-7.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-8.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules-9.html:
webgpu/whlsl/separate-shader-modules/separate-shader-modules.html:
webgpu/whlsl/simple-arrays.html:
webgpu/whlsl/store-to-property-updates-properly.html:
webgpu/whlsl/textures-load.html:
webgpu/whlsl/textures-sample-bias.html:
webgpu/whlsl/textures-sample-grad.html:
webgpu/whlsl/textures-sample-level.html:
webgpu/whlsl/textures-sample.html:
webgpu/whlsl/two-dimensional-array.html:
webgpu/whlsl/while-loop-break.html:
webgpu/whlsl/while-loop-continue.html:
webgpu/whlsl/whlsl.html:
webgpu/whlsl/zero-initialize-values-2.html:
webgpu/whlsl/zero-initialize-values.html:

5:08 PM Changeset in webkit [249600] by jiewen_tan@apple.com

4 edits in trunk/Source/WebKit

[WebAuthn] Make WebAuthn default off and let clients turn it on at will
https://bugs.webkit.org/show_bug.cgi?id=201439
<rdar://problem/54998154>

Reviewed by Youenn Fablet.

This patch makes WebAuthn default off such that clients that have the right entitlements
could turn it on and we don't risk at turning on a Web API that does nothing by default.

This patch doesn't add any SPI to turn the feature on as it is currently doable via

[WKPreferencesPrivate _setEnabled:forExperimentalFeature:].

Shared/WebPreferences.yaml:
Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultWebAuthenticationEnabled): Deleted.

Shared/WebPreferencesDefaultValues.h:

4:09 PM Changeset in webkit [249599] by mark.lam@apple.com

2 edits in trunk/JSTests

Gardening: speculative test fix to green bots.
https://bugs.webkit.org/show_bug.cgi?id=201529
<rdar://problem/53935772>

Not reviewed.

stress/test-out-of-memory.js:

3:59 PM Changeset in webkit [249598] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews-app] Status bubble should only display important messages in pop-over - part 2
https://bugs.webkit.org/show_bug.cgi?id=201557

Reviewed by Jonathan Bedard.

BuildSlaveSupport/ews-app/ews/views/statusbubble.py:

(StatusBubble): Add few more strings to STEPS_TO_HIDE.

3:49 PM Changeset in webkit [249597] by Ross Kirsling

8 edits in trunk

Math.round() produces wrong result for value prior to 0.5
https://bugs.webkit.org/show_bug.cgi?id=185115

Reviewed by Saam Barati.

JSTests:

stress/math-round-basics.js:

Add positive/negative test cases.

test262/expectations.yaml:

Mark test passing.

Source/JavaScriptCore:

Our Math.round implementation goes in the wrong direction for double values like 0.49999999999999994.
This requires just a subtle adjustment for three of our four versions; only baseline JIT needed a full rewrite.

Specifically:

While 0.49999999999999994 is representable, 1 - 0.49999999999999994 is not (it turns into 0.5), so taking the difference between ceil(value) and value` is problematic.
The baseline implementation was doing floor(x + 0.5) for positive doubles and slowpathing negative ones (by falling back to jsRound). This patch gives baseline a legitimate implementation too.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithRounding):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileArithRound):

jit/ThunkGenerators.cpp:

(JSC::roundThunkGenerator):

runtime/MathCommon.cpp:

3:34 PM Changeset in webkit [249596] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: CSS Formatter: links to CSS resources don't map to the right line after pretty printing if the line is after a multiline comment
https://bugs.webkit.org/show_bug.cgi?id=201559

Reviewed by Joseph Pecoraro.

Newlines in multiline comments weren't added as line endings, so they weren't considered
when a source code location updated after pretty printing.

UserInterface/Workers/Formatter/CSSFormatter.js:

(CSSFormatter.prototype._format):

3:23 PM Changeset in webkit [249595] by Ryan Haddad

2 edits in trunk/LayoutTests

REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
https://bugs.webkit.org/show_bug.cgi?id=201550

Unreviewed test gardening.

platform/ios-wk2/TestExpectations: Mark the test as flaky to speed up EWS while we investigate the root cause.

3:15 PM Changeset in webkit [249594] by commit-queue@webkit.org

8 edits
2 adds in trunk

REGRESSION (r249367): m_decodingPromises grows indefinitely until ImageLoader destruction
https://bugs.webkit.org/show_bug.cgi?id=201402

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-09-06
Reviewed by Youenn Fablet and Daniel Bates.

Source/WebCore:

Add the static functions resolvePromises() and rejectPromises(). These
functions take an lvalue reference to a Vector of promises. Inside them,
the lvalue reference argument are exchanged with an empty Vector of
promises then the promises are processed. This clears m_decodingPromises
and fixes the leak.

Add an internal API which returns the count of the pending promises of
an HTMLImageElement. This internal API will be used in the attached test.

Test: fast/images/decode-resolve-reject-no-leak.html

html/HTMLImageElement.h:

(WebCore::HTMLImageElement::pendingDecodePromisesCountForTesting const):

loader/ImageLoader.cpp:

(WebCore::resolvePromises):
ImageLoader::decode() calls BitmapImage::decode() and moves m_decodingPromises
in capture. When decoding finishes, this function is called to resolve the
promises. But ImageLoader might get deleted before the image decoding
finishes. So this function has to be static.

(WebCore::rejectPromises):
(WebCore::ImageLoader::resolveDecodePromises):
(WebCore::ImageLoader::rejectDecodePromises):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::decode):
(WebCore::resolveDecodePromises): Deleted.
(WebCore::rejectDecodePromises): Deleted.

loader/ImageLoader.h:

(WebCore::ImageLoader::pendingDecodePromisesCountForTesting const):

testing/Internals.cpp:

(WebCore::Internals::imagePendingDecodePromisesCountForTesting):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

fast/images/decode-resolve-reject-no-leak-expected.txt: Added.
fast/images/decode-resolve-reject-no-leak.html: Added.

2:57 PM Changeset in webkit [249593] by commit-queue@webkit.org

3 edits
4 adds in trunk

Prefer null namespace 'href' over 'xlink:href' on SVG elements
https://bugs.webkit.org/show_bug.cgi?id=195802

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2019-09-06
Reviewed by Youenn Fablet.

Source/WebCore:

-- When the attribute "href" is set, its value is always reflected in

SVGURIReference::m_href.

-- When the attribute "href" is removed, the value of the attribute

"xlink:href" is always reflected in SVGURIReference::m_href.

-- When the "xlink:href" is set, its value is reflected in

SVGURIReference::m_href only if the attribute "href" is not set.

Tests: svg/custom/href-xlink-href-gradient-element-expected.svg

svg/custom/href-xlink-href-gradient-element.svg
svg/custom/href-xlink-href-use-element-expected.svg
svg/custom/href-xlink-href-use-element.svg

svg/SVGURIReference.cpp:

(WebCore::SVGURIReference::parseAttribute):

LayoutTests:

svg/custom/href-xlink-href-gradient-element-expected.svg: Added.
svg/custom/href-xlink-href-gradient-element.svg: Added.
svg/custom/href-xlink-href-use-element-expected.svg: Added.
svg/custom/href-xlink-href-use-element.svg: Added.

2:19 PM Changeset in webkit [249592] by Joseph Pecoraro

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Better position for Sources tab when enabling the experimental setting
https://bugs.webkit.org/show_bug.cgi?id=201539

Reviewed by Devin Rousso.

UserInterface/Views/SettingsTabContentView.js:

Place the Sources tab where the Debugger tab was.

2:08 PM Changeset in webkit [249591] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][TFC] Set computed row width.
https://bugs.webkit.org/show_bug.cgi?id=201533
<rdar://problem/55098828>

Reviewed by Antti Koivisto.

Decouple cell box layout/display box setup and set the computed row width.

layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layout):

1:51 PM Changeset in webkit [249590] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC] A formatting context root is always a containing block for relative: static boxes.
https://bugs.webkit.org/show_bug.cgi?id=201554
<rdar://problem/55123295>

Reviewed by Antti Koivisto.

"For other elements, if the element's position is 'relative' or 'static', the containing block is formed by the content
edge of the nearest ancestor box that is a block container or which establishes a formatting context."

layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::containingBlock const):

page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

1:42 PM Changeset in webkit [249589] by achristensen@apple.com

26 edits
2 adds
1 delete in trunk

Deprecate all WKCookieManagerRef functions
https://bugs.webkit.org/show_bug.cgi?id=201473

Reviewed by Chris Dumez.

Source/WebKit:

Their use was removed in rdar://problem/55039275
Created replacement C API that more closely resembles the public ObjC API for WebKitTestRunner.

Shared/API/c/WKBase.h:
Sources.txt:
UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::deleteAllCookies):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::deleteCookiesInDefaultUIProcessCookieStore):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicyInDefaultUIProcessCookieStore):

UIProcess/API/APIHTTPCookieStore.h:
UIProcess/API/C/WKAPICast.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetStorageAccessAPIEnabled):

UIProcess/API/C/WKContext.h:
UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetTypeID):
(WKCookieManagerSetClient):
(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerDeleteCookiesForHostname):
(WKCookieManagerDeleteAllCookies):
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerSetHTTPCookieAcceptPolicy):
(WKCookieManagerGetHTTPCookieAcceptPolicy):
(WKCookieManagerSetStorageAccessAPIEnabled):
(WKCookieManagerStartObservingCookieChanges):
(WKCookieManagerStopObservingCookieChanges):

UIProcess/API/C/WKCookieManager.h:
UIProcess/API/C/WKHTTPCookieStoreRef.cpp: Added.

(WKHTTPCookieStoreGetTypeID):
(WKHTTPCookieStoreDeleteAllCookies):
(WKHTTPCookieStoreSetHTTPCookieAcceptPolicy):

UIProcess/API/C/WKHTTPCookieStoreRef.h: Added.
UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreGetHTTPCookieStore):

UIProcess/API/C/WKWebsiteDataStoreRef.h:
UIProcess/API/Cocoa/APIHTTPCookieStoreCocoa.mm:

(API::HTTPCookieStore::deleteCookiesInDefaultUIProcessCookieStore):
(API::toNSHTTPCookieAcceptPolicy):
(API::HTTPCookieStore::setHTTPCookieAcceptPolicyInDefaultUIProcessCookieStore):

UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::setStorageAccessAPIEnabled): Deleted.

UIProcess/WebCookieManagerProxy.h:
WebKit.xcodeproj/project.pbxproj:

Tools:

Adopt replacement C API in WebKitTestRunner.

TestWebKitAPI/CMakeLists.txt:
TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

1:23 PM Changeset in webkit [249588] by mark.lam@apple.com

4 edits in trunk/Source/bmalloc

Use FailureAction everywhere in bmalloc instead of a crashOnFailure boolean.
https://bugs.webkit.org/show_bug.cgi?id=201553

Reviewed by Yusuke Suzuki.

bmalloc/Cache.cpp:

(bmalloc::Cache::tryAllocateSlowCaseNullCache):
(bmalloc::Cache::allocateSlowCaseNullCache):
(bmalloc::Cache::tryReallocateSlowCaseNullCache):
(bmalloc::Cache::reallocateSlowCaseNullCache):

bmalloc/DebugHeap.cpp:

(bmalloc::DebugHeap::malloc):
(bmalloc::DebugHeap::memalign):
(bmalloc::DebugHeap::realloc):

bmalloc/DebugHeap.h:

1:08 PM Changeset in webkit [249587] by mark.lam@apple.com

1 edit
1 move in trunk/JSTests

Move web-assembly-constructors-should-not-override-global-object-property.js below JSTests/wasm/stress.
https://bugs.webkit.org/show_bug.cgi?id=201551

Reviewed by Tadeu Zagallo.

Ports that don't support WASM will always fail this test if it stays in JSTests/stress.

stress/web-assembly-constructors-should-not-override-global-object-property.js: Removed.
wasm/stress/web-assembly-constructors-should-not-override-global-object-property.js: Copied from JSTests/stress/web-assembly-constructors-should-not-override-global-object-property.js.

12:11 PM Changeset in webkit [249586] by Joseph Pecoraro

5 edits
2 copies
2 moves
17 adds
4 deletes in trunk

Tail Deleted Frames shown in Web Inspector are sometimes incorrect (Shadow Chicken)
https://bugs.webkit.org/show_bug.cgi?id=201366

Reviewed by Saam Barati.

Source/JavaScriptCore:

It is possible for the log buffer to be full right as someone is trying to
log a function prologue. In such a case the machine stack has already been
updated to include the new JavaScript call frame, but the prologue packet
cannot be included in the update because the log is full. This would mean
that the update fails to rationalize the machine stack with the shadow
log / stack. Namely, the current JavaScript call frame is unable to
find a matching prologue (the one we are holding to include after the update)
and inserts a questionable value into the stack; and in the process
missing and removing real potential tail calls.

For example:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function start() { return first(); }

If the the log fills up just as we are entering b then we may have a list
full log of packets looking like:

Shadow Log:

...
{ prologue-packet: entering start ... }
{ prologue-packet: entering first ... }
{ tail-packet: leaving first with a tail call }

Incoming Packet:

{ prologue-packet: entering second ... }

Current JS Stack:

second
start

Since the Current JavaScript stack already has second, if we process the
log without the prologue for second then we push a confused entry on the
shadow stack and clear the log such that we eventually lose the tail-call
information for first to second.

This patch solves this issue by providing enough extra space in the log
to always process the incoming packet when that forces an update. This way
clients can continue to behave exactly as they are.

We also document a corner case in some circumstances where the shadow
log may currently be insufficient to know how to reconcile:

For example:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function doNothingTail() { return Math.random() }
function start() {

for (i=0;i<1000;++i) doNothingTail();
return first();

}

In this case the ShadowChicken log may be processed multiple times due
to the many calls to doNothingTail / Math.random(). When calling the
Native function no prologue packet is emitted, so it is unclear that we
temporarly go deeper and come back out on the stack, so the log appears
to have lots of doNothingTail calls reusing the same frame:

Shadow Log:

...
, [123] {callee = 0x72a21aee0, frame = 0x7ffeef897270, callerFrame = 0x7ffeef8972e0, name = start}
, [124] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [125] tail-packet:{frame = 0x7ffeef8971f0}
, [126] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [127] tail-packet:{frame = 0x7ffeef8971f0}
...
, [140] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [141] tail-packet:{frame = 0x7ffeef8971f0}
, [142] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [143] tail-packet:{frame = 0x7ffeef8971f0}
, [144] {callee = 0x72a21aeb0, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = first}
, [145] tail-packet:{frame = 0x7ffeef8971f0}
, [146] {callee = 0x72a21ae80, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = second}
...

This log would seem to be indistinguishable from real tail recursion, such as:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function doNothingTail(n) {

return n ? doNothingTail(n-1) : first();

}
function start() {

return doNothingTail(1000);

}

Likewise there are more cases where the shadow log appears to be ambiguous with determining
the appropriate parent call frame with intermediate function calls. In practice this may
not be too problematic, as this is a best effort reconstruction of tail deleted frames.
It seems likely we would only show additional frames that did in fact happen serially
between JavaScript call frames, but may not actually be the proper parent frames
heirachy in the stack.

interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::Packet::dump const):
(JSC::ShadowChicken::Frame::dump const):
(JSC::ShadowChicken::dump const):
Improved debugging output. Especially for functions.

(JSC::ShadowChicken::ShadowChicken):
Make space in the log for 1 additional packet to process when we slow log.

(JSC::ShadowChicken::log):
Include this packet in our update.

(JSC::ShadowChicken::update):
Address an edge case where we can eliminate tail-deleted frames that don't make sense.

LayoutTests:

inspector/debugger/tail-deleted-frames-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-from-vm-entry-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-from-vm-entry.html: Removed.
inspector/debugger/tail-deleted-frames-this-value-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-this-value.html: Removed.
inspector/debugger/tail-deleted-frames.html: Removed.

Remove legacy tests that are difficult to read.

inspector/debugger/tail-deleted-frames/resources/stack-trace-utilities.js: Added.

(TestPage.registerInitializer.window.getAsyncStackTrace):
(TestPage.registerInitializer.async.logThisObject):
(TestPage.registerInitializer.async.logScope):
(TestPage.registerInitializer.async.logCallFrame):
(TestPage.registerInitializer):

inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-frames.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-native-tail-deleted-calls.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-tail-deleted-frames.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-scopes.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-this-value.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-vm-entry.js: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-frames-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-frames.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-tail-deleted-frames-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-tail-deleted-frames.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-scopes-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-scopes.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-vm-entry-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-vm-entry.html: Added.

Include modern tests that are easier to read.

inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-native-tail-deleted-calls-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-native-tail-deleted-calls.html: Added.

Include a test that is known to produce bad output, since we have reproductive steps.

platform/mac/TestExpectations:

Updated pathes.

12:03 PM Changeset in webkit [249585] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION(iOS 12): Keyboard dismissal leaves WKWebView viewport-fit=cover content offscreen
https://bugs.webkit.org/show_bug.cgi?id=192564

Patch by Darryl Pogue <darryl@dpogue.ca> on 2019-09-06
Reviewed by Tim Horton.

Source/WebKit:

The new keyboard height was being read into a variable after the scrollview had already been
adjusted. This worked when the keyboard was opening, because the scrollview is adjusted with
the correct value a second time when the keyboard animation has finished. However, when the
keyboard is closed, the adjustment was being made before the correct height was stored,
leading to the scrollview being positioned as if the keyboard were still open.

UIProcess/ios/WKScrollView.mm:

(-[WKScrollView _adjustForAutomaticKeyboardInfo:animated:lastAdjustment:]):

LayoutTests:

Added tests to verify scrolling properly adapts to the keyboard insets on iOS.

fast/scrolling/ios/scrollview-adjusts-to-keyboard-insets-expected.txt: Added.
fast/scrolling/ios/scrollview-adjusts-to-keyboard-insets.html: Added.

11:46 AM Changeset in webkit [249584] by timothy_horton@apple.com

6 edits
1 add in trunk

Marking up a note on iOS results in a PDF with no contents
https://bugs.webkit.org/show_bug.cgi?id=201530
<rdar://problem/53686019>

Reviewed by Andy Estes.

Source/WebKit:

Platform/IPC/Connection.cpp:

(IPC::Connection::Connection):
(IPC::Connection::waitForMessage):
(IPC::Connection::connectionDidClose):

Platform/IPC/Connection.h:

If the main thread is blocked when the Web Content process dies, and
something eventually calls waitForAndDispatchImmediately without
returning control to the main run loop, we will wait for the full timeout,
because a) the code to mark the connection invalid is dispatched
to the main thread, and b) the secondary thread that is informed of
the Web Content process dying did not yet have a "waiting for" message
to mark as interrupted (because it wasn't waiting yet).

Fix this race by adding a bit that is set under the waitForMessage lock
on the secondary thread when the connection is invalidated, identically
to m_shouldWaitForSyncReplies, which solves the same problem for sync
messages.

Read the new bit when we are about to start waiting, and bail if it is set.
It's OK to not read it inside the loop because we are guaranteed to have
waitForMessage set at that point, so the normal interruption bit will work.

UIProcess/ios/WKContentView.mm:

(-[WKContentView _processDidExit]):
Reset _isPrintingToPDF; the Web Content process is never going to get
back to us if it crashes.

(-[WKContentView _wk_pageCountForPrintFormatter:]):
Do not bail from starting a printing operation if one is already occurring.
This fixes the original bug, because Markup ends up invalidating the page
count at least one extra time before asking for the printed document.
Instead of maintaining the fragile requirement that you cannot recompute
the page count while printing, just let it happen. In order to make this
work safely, synchronously wait for the previous printed result before
continuing with the next print.

We could do more coalescing here if need be, but calls to -_recalcPageCount
are not high in volume.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:

Add some tests for WKWebViewPrintFormatter; specifically that it is
possible to _recalcPageCount twice in quick succession, and that
we don't hang if we start painting the printed content immediately
after a Web Content process crash.

11:28 AM Changeset in webkit [249583] by sihui_liu@apple.com

3 edits in trunk/Source/WebCore

IndexedDB: use SQL COUNT statement for count operation
https://bugs.webkit.org/show_bug.cgi?id=201465

Reviewed by Geoffrey Garen.

We did count operation by moving objectStore/index iterator from begin to end and counting the steps. We can
utilize the SQL COUNT statement, and improve the performance further by caching the statement.

Tested on release build minibrowser. Without the change, the mean time to complete one iteration in
PerformanceTests/IndexedDB/basic/index-count.html and PerformanceTests/IndexedDB/basic/objectStore-count.html is
about 50ms. With the change it is about 2ms.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::cachedStatement):
(WebCore::IDBServer::SQLiteIDBBackingStore::closeSQLiteDB):

Modules/indexeddb/server/SQLiteIDBBackingStore.h:

11:10 AM Changeset in webkit [249582] by Matt Lewis

4 edits
2 adds in trunk/Tools

run-webkit-test: Allow results to be uploaded without scm checkout
https://bugs.webkit.org/show_bug.cgi?id=200787

Reviewed by Jonathan Bedard.

Scripts/webkitpy/common/checkout/scm/detection.py:

(SCMDetector.detect_scm_system): Added in detection of stub repository.

Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.

(StubRepository):
(StubRepository.init):
(StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
find the directory containing the checkout_information.json of the stub repository.
(StubRepository.in_working_directory): Required functions to be implemented.
(StubRepository.svn_revision): Required functions to be implemented.
(StubRepository.native_revision): Required functions to be implemented.
(StubRepository.native_branch): Required functions to be implemented.
(StubRepository._decode_json): Decodes checkout_information.json.
(StubRepository.find_checkout_root): Required functions to be implemented.

Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.

(StubRepositoryTest): Unit test for stub_repository SCM.
(StubRepositoryTest.mock_host_for_stub_repository):
(StubRepositoryTest.test_in_working_directory):
(StubRepositoryTest.test_native_revision):
(StubRepositoryTest.test_native_branch):
(StubRepositoryTest.test_svn_revision):
(StubRepositoryTest.test_find_checkout_root):

Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.

Scripts/webkitpy/port/base.py:

(Port.commits_for_upload): Removed unnecessary scm initialization.

11:05 AM Changeset in webkit [249581] by Simon Fraser

4 edits
2 adds in trunk

REGRESSION (iOS 13): If an overflow:hidden with a non-zero scroll position is toggled to overflow:scroll, some other scroll causes its scroll position to get reset
https://bugs.webkit.org/show_bug.cgi?id=201528
rdar://problem/55044885

Reviewed by Frédéric Wang.
Source/WebCore:

If, when an overflow scrolling node is created, the scroller has non-zero scroll
position (for example, via toggling to overflow:hidden, setting scrollTop, then toggling
to overflow:scroll), then on the next update its scroll position will reset back to zero.

The bug was that newly created ScrollingTreeScrollingNodes didn't set m_currentScrollPosition
to the scroll position coming from the state node, so a subsequent update could cause
the 0,0 currentScrollPosition to get applied. If we're making a new node, and there's no
requestedScrollPosition, then initialize m_currentScrollPosition.

Test: scrollingcoordinator/ios/scroller-initial-scroll-position.html

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeScrollingNode::commitStateAfterChildren):

page/scrolling/ScrollingTreeScrollingNode.h:

LayoutTests:

scrollingcoordinator/ios/scroller-initial-scroll-position-expected.html: Added.
scrollingcoordinator/ios/scroller-initial-scroll-position.html: Added.

11:02 AM Changeset in webkit [249580] by achristensen@apple.com

2 edits in trunk/Source/WebKit

Fix unused argument warning from GCC.

Platform/IPC/ArgumentCoders.h:

(IPC::TupleDecoder<0>::decode):
There was indeed an unused argument.

10:16 AM Changeset in webkit [249579] by Said Abou-Hallawa

3 edits in trunk/LayoutTests

Unreviewed, fix typo in r249216

Also change the <desc> element to be <text> element so the purpose of
the test is visible once it is opened.

svg/custom/href-svg-namespace-animate-target-expected.svg:
svg/custom/href-svg-namespace-animate-target.svg:

10:04 AM Changeset in webkit [249578] by mark.lam@apple.com

10 edits
2 adds in trunk

Fix bmalloc::Allocator:tryAllocate() to return null on failure to allocate.
https://bugs.webkit.org/show_bug.cgi?id=201529
<rdar://problem/53935772>

Reviewed by Yusuke Suzuki.

JSTests:

stress/test-out-of-memory.js: Added.

Source/bmalloc:

In this implementation, we pass FailureAction in as a runtime option. If this
proves to be a perf issue, we can easily fix this by passing it as a template
argument. That will also automatically elide unneeded code paths. We'll defer
that exercise until we have evidence that it is warranted.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocateImpl):
(bmalloc::Allocator::reallocateImpl):
(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateLogSizeClass):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::tryAllocate): Deleted.
(bmalloc::Allocator::allocate): Deleted.
(bmalloc::Allocator::reallocate): Deleted.
(bmalloc::Allocator::tryReallocate): Deleted.

bmalloc/Allocator.h:

(bmalloc::Allocator::tryAllocate):
(bmalloc::Allocator::allocate):
(bmalloc::Allocator::tryReallocate):
(bmalloc::Allocator::reallocate):
(bmalloc::Allocator::allocateImpl):

bmalloc/BumpAllocator.h:
bmalloc/FailureAction.h: Added.
bmalloc/Heap.cpp:

(bmalloc::Heap::allocateSmallChunk):
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateSmallBumpRangesByMetadata):
(bmalloc::Heap::allocateSmallBumpRangesByObject):
(bmalloc::Heap::allocateLarge):
(bmalloc::Heap::tryAllocateLarge): Deleted.

bmalloc/Heap.h:

(bmalloc::Heap::allocateSmallBumpRanges):

bmalloc/bmalloc.cpp:

(bmalloc::api::tryLargeZeroedMemalignVirtual):

10:03 AM Changeset in webkit [249577] by Ryan Haddad

5 edits
2 copies
4 adds
1 delete in trunk

Unreviewed, rolling out r249566.

Causes inspector layout test crashes under GuardMalloc

Reverted changeset:

"Tail Deleted Frames shown in Web Inspector are sometimes
incorrect (Shadow Chicken)"
https://bugs.webkit.org/show_bug.cgi?id=201366
https://trac.webkit.org/changeset/249566

9:56 AM Changeset in webkit [249576] by guijemont@igalia.com

2 edits in trunk/Source/JavaScriptCore

testmasm: save r6 in JIT'ed code on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=201138

Reviewed by Mark Lam.

MacroAssemblerArmv7 uses r6 as a temporary register, and it is a
callee-saved register. The JITs use
AssemblyHelpers::emitSaveCalleeSaves() and friends to save
callee-saved registers, but there is no such mechanism in testmasm,
which seems to make the assumption that the macroassembler does not
use callee-saved registers (which I guess is true for all other
architectures, but not for Armv7).

This issue means that testmasm crashes on Armv7 since code generated
by gcc uses r6, and it gets modified by JIT'ed code.

This change makes sure that we save and restore r6 for all code
compiled by testmasm on Armv7.

assembler/testmasm.cpp:

(JSC::emitFunctionPrologue):
(JSC::emitFunctionEpilogue):
(JSC::testSimple):
(JSC::testGetEffectiveAddress):
(JSC::testBranchTruncateDoubleToInt32):
(JSC::testBranchTestBit32RegReg):
(JSC::testBranchTestBit32RegImm):
(JSC::testBranchTestBit32AddrImm):
(JSC::testBranchTestBit64RegReg):
(JSC::testBranchTestBit64RegImm):
(JSC::testBranchTestBit64AddrImm):
(JSC::testCompareDouble):
(JSC::testMul32WithImmediates):
(JSC::testMul32SignExtend):
(JSC::testCompareFloat):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::testProbeModifiesStackValues):
(JSC::testByteSwap):
(JSC::testMoveDoubleConditionally32):
(JSC::testMoveDoubleConditionally64):
(JSC::testCagePreservesPACFailureBit):

9:19 AM Changeset in webkit [249575] by achristensen@apple.com

20 edits in trunk

When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
https://bugs.webkit.org/show_bug.cgi?id=201480

Reviewed by Youenn Fablet.

Source/WebCore:

No change in behavior, but this blocks bug 200050 which will make WebKitTestRunner use a persistent, non-default session.
Without this change, that change causes lots of test failures because we are switching from the legacy private browsing session
to the default session instead of the session we were using.

page/Page.cpp:

(WebCore::Page::enableLegacyPrivateBrowsing): Deleted.

page/Page.h:
page/PageGroup.cpp:

(WebCore::PageGroup::addPage):
(WebCore::PageGroup::setSessionIDForTesting):
(WebCore::PageGroup::enableLegacyPrivateBrowsingForTesting): Deleted.

page/PageGroup.h:
storage/StorageNamespaceProvider.cpp:

(WebCore::StorageNamespaceProvider::setSessionIDForTesting):
(WebCore::StorageNamespaceProvider::enableLegacyPrivateBrowsingForTesting): Deleted.

storage/StorageNamespaceProvider.h:

Source/WebKit:

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

WebProcess/InjectedBundle/InjectedBundle.h:

Source/WebKitLegacy/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPrivateBrowsingEnabled):

8:49 AM Changeset in webkit [249574] by youenn@apple.com

9 edits in trunk

Remove MediaStreamPrivate::scheduleDeferredTask
https://bugs.webkit.org/show_bug.cgi?id=200975

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-streams/MediaStream-finished-add.https-expected.txt:

Source/WebCore:

All calls to scheduleDeferredTask are done on the main thread.
This was initially done to trigger less reconfiguration.
But this makes the implementation significantly more complex.

For instance, we have to wait for the document to update its media state
and send it to UIProcess before calling the allow completion handler.

Covered by existing tests.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream):
Make sure to update the document media state once the tracks have been added, similarly to the other constructor.
This ensures the document media state is computed with the new MediaStreamTrack.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::isMediaStreamCorrectlyStarted):
(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::stop):
(WebCore::UserMediaRequest::mediaStreamDidFail):

Modules/mediastream/UserMediaRequest.h:
page/MediaProducer.h:

(WebCore::MediaProducer::isCapturing):
Make sure to include getDisplayMedia as part of capture check.

platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::trackMutedChanged):
(WebCore::MediaStreamPrivate::trackEnabledChanged):
(WebCore::MediaStreamPrivate::trackStarted):
(WebCore::MediaStreamPrivate::trackEnded):

platform/mediastream/MediaStreamPrivate.h:

6:05 AM Changeset in webkit [249573] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.26/Source/WebKit

Unreviewed. Disable PSON in GTK port

There are some issues causing problems in applications.

Shared/WebPreferencesDefaultValues.h:

5:38 AM WebKitGTK/2.26.x edited by Michael Catanzaro

(diff)

5:27 AM Changeset in webkit [249572] by commit-queue@webkit.org

34 edits
23 adds
2 deletes in trunk

LayoutTests/imported/w3c:
Implement MathMLIDL / HTMLOrForeignElement
https://bugs.webkit.org/show_bug.cgi?id=200470

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-06
Reviewed by Ryosuke Niwa.

Add tests for functionality exposed by HTMLOrForeignElement.
Import WPT tests as of 6e83b23bb962c97687b6573c378963208219ad1b (origin/master).

resources/import-expectations.json:
web-platform-tests/mathml/relations/html5-tree/class-1.html:
web-platform-tests/mathml/relations/html5-tree/class-2.html:
web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative-expected.txt: Added.
web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html: Added.
web-platform-tests/mathml/relations/html5-tree/color-attributes-1.html:
web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative-expected.html: Added.
web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html: Added.
web-platform-tests/mathml/relations/html5-tree/css-inline-style-interface.tentative-expected.txt: Added.
web-platform-tests/mathml/relations/html5-tree/css-inline-style-interface.tentative.html: Added.
web-platform-tests/mathml/relations/html5-tree/display-1-expected.txt:
web-platform-tests/mathml/relations/html5-tree/display-1.html:
web-platform-tests/mathml/relations/html5-tree/dynamic-1.html:
web-platform-tests/mathml/relations/html5-tree/href-click-1.html:
web-platform-tests/mathml/relations/html5-tree/href-click-2.html:
web-platform-tests/mathml/relations/html5-tree/href-click-3.html:
web-platform-tests/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative-expected.txt: Added.
web-platform-tests/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html: Added.
web-platform-tests/mathml/relations/html5-tree/integration-point-1.html:
web-platform-tests/mathml/relations/html5-tree/integration-point-2.html:
web-platform-tests/mathml/relations/html5-tree/integration-point-3.html:
web-platform-tests/mathml/relations/html5-tree/integration-point-4-expected.txt: Added.
web-platform-tests/mathml/relations/html5-tree/integration-point-4.html: Added.
web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative-expected.txt: Added.
web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html: Added.
web-platform-tests/mathml/relations/html5-tree/required-extensions-1-expected.txt: Removed.
web-platform-tests/mathml/relations/html5-tree/required-extensions-1.html: Removed.
web-platform-tests/mathml/relations/html5-tree/required-extensions-2.html:
web-platform-tests/mathml/relations/html5-tree/unique-identifier-1.html:
web-platform-tests/mathml/relations/html5-tree/unique-identifier-2.html:
web-platform-tests/mathml/relations/html5-tree/unique-identifier-3.html:
web-platform-tests/mathml/relations/html5-tree/w3c-import.log:
web-platform-tests/mathml/support/attribute-values.js: Added.

(AttributeValueTransforms.lowercase):
(AttributeValueTransforms.uppercase):
(AttributeValueTransforms.alternate_case):
(TransformAttributeValues):

web-platform-tests/mathml/support/box-comparison.js: Added.

(spaceBetween):
(measureSpaceAround):
(compareSpaceWithAndWithoutStyle):
(compareSizeWithAndWithoutStyle):

web-platform-tests/mathml/support/layout-comparison.js: Added.

(getWritingMode):
(compareSize):
(participateToParentLayout):
(childrenParticipatingToLayout):
(compareLayout):

web-platform-tests/mathml/support/mathml-fragments.js: Added.

(FragmentHelper.createElement):
(FragmentHelper.isValidChildOfMrow):
(FragmentHelper.isEmpty):
(FragmentHelper.element):
(FragmentHelper.appendChild):
(FragmentHelper.forceNonEmptyElement):

web-platform-tests/mathml/support/w3c-import.log: Added.

Source/WebCore:
Implement MathML DOM
https://bugs.webkit.org/show_bug.cgi?id=200470

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-06
Reviewed by Ryosuke Niwa.

Expose MathML DOM as specified here [1].

[1] https://mathml-refresh.github.io/mathml-core/#dom-mathmlelement

Tests: imported/w3c/web-platform-tests/mathml/relations/html5-tree/clipboard-event-handlers.tentative.html

imported/w3c/web-platform-tests/mathml/relations/html5-tree/css-inline-style-dynamic.tentative.html
imported/w3c/web-platform-tests/mathml/relations/html5-tree/css-inline-style-interface.tentative.html
imported/w3c/web-platform-tests/mathml/relations/html5-tree/html-or-foreign-element-interfaces.tentative.html
imported/w3c/web-platform-tests/mathml/relations/html5-tree/integration-point-4.html
imported/w3c/web-platform-tests/mathml/relations/html5-tree/math-global-event-handlers.tentative.html
mathml/focus-event-handling.html
mathml/tabindex-order.html

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSElementCustom.cpp:

(WebCore::createNewElementWrapper):

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

mathml/MathMLElement.cpp:

(WebCore::MathMLElement::parseAttribute):

mathml/MathMLElement.idl: Copied from Source/WebCore/html/HTMLOrForeignElement.idl.
mathml/MathMLMathElement.idl: Copied from Source/WebCore/html/HTMLOrForeignElement.idl.
mathml/mathtags.in:

LayoutTests:
Implement MathML DOM
https://bugs.webkit.org/show_bug.cgi?id=200470

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-06
Reviewed by Ryosuke Niwa.

Extend existing tests to also test focus for MathML. Add a standalone test for MathML
based on svg/custom/tabindex-order.html. Add a test for mouse clicks and focus handling
based on svg/custom/focus-event-handling.xhtml.

fast/dom/tabindex-defaults-expected.txt:
fast/dom/tabindex-defaults.html:
mathml/focus-event-handling-expected.txt: Added.
mathml/focus-event-handling.html: Added.
mathml/tabindex-order-expected.txt: Added.
mathml/tabindex-order.html: Added.
platform/ios-wk2/TestExpectations:

3:01 AM Changeset in webkit [249571] by commit-queue@webkit.org

16 edits in trunk

Add runtime flag for lazy image loading
https://bugs.webkit.org/show_bug.cgi?id=199794

Patch by Rob Buis <rbuis@igalia.com> on 2019-09-06
Reviewed by Frédéric Wang.

Remove parts of r248409 that were meant for WK1 since
lazy image loading is WK2 only.

Source/WebKitLegacy/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences lazyImageLoadingEnabled]): Deleted.
(-[WebPreferences setLazyImageLoadingEnabled:]): Deleted.

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKitLegacy/win:

Interfaces/IWebPreferencesPrivate.idl:
WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setResizeObserverEnabled):
(WebPreferences::lazyImageLoadingEnabled): Deleted.
(WebPreferences::setLazyImageLoadingEnabled): Deleted.

WebPreferences.h:
WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

DumpRenderTree/TestOptions.h:
DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

2:14 AM Changeset in webkit [249570] by Joseph Pecoraro

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: Error response headers summary has wrong color border
https://bugs.webkit.org/show_bug.cgi?id=201538
<rdar://problem/55104469>

Reviewed by Devin Rousso.

UserInterface/Views/ResourceHeadersContentView.css:

(body[dir] .resource-headers > section.error > .details):
Re-apply an error style for resource-header sections.

2:00 AM Changeset in webkit [249569] by Patrick Griffis

2 edits in trunk/Source/WebKit

[GTK][WPE] Do not enable the sandbox in Snap
https://bugs.webkit.org/show_bug.cgi?id=201486

Reviewed by Carlos Garcia Campos.

Running inside of Snap adds its own complications and is simply
not supported for now.

Also update isInsideFlatpak() for consistency.

UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::isInsideFlatpak):
(WebKit::isInsideSnap):
(WebKit::ProcessLauncher::launchProcess):

1:51 AM Changeset in webkit [249568] by zandobersek@gmail.com

5 edits in trunk/Source/WebCore

[GStreamer] YUV buffers on iMX platforms have to be treated as RGBA
https://bugs.webkit.org/show_bug.cgi?id=201537

Reviewed by Philippe Normand.

The imxvpudecoder element on iMX platforms decodes YUV data in a
platform-specific way, gathering the YUV data in a single texture and
then relying on the sampler in the Vivante graphics drivers to
automagically decode that YUV data into RGBA values.

To correctly display such decoded data, we have to represent that
single texture as an RGBA texture, even when the GStreamer buffer is
crafted as containing planar YUV data.

platform/graphics/gstreamer/GStreamerCommon.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
(WebCore::GstVideoFrameHolder::platformLayerBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

1:22 AM Changeset in webkit [249567] by Joseph Pecoraro

5 edits in trunk

Web Inspector: Crashes when intercept response is a 404
https://bugs.webkit.org/show_bug.cgi?id=201514

Reviewed by Alex Christensen.

Source/WebKit:

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponse):
Ensure the WebResourceLoader stays around during intercepts.

(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
Only perform the work if the m_coreLoader is still alive.

LayoutTests:

http/tests/inspector/network/local-resource-override-basic-expected.txt:
http/tests/inspector/network/local-resource-override-basic.html:

Add a test for a 404 response override.

1:14 AM Changeset in webkit [249566] by Joseph Pecoraro

5 edits
2 copies
2 moves
17 adds
4 deletes in trunk

Tail Deleted Frames shown in Web Inspector are sometimes incorrect (Shadow Chicken)
https://bugs.webkit.org/show_bug.cgi?id=201366

Reviewed by Saam Barati.

Source/JavaScriptCore:

For example:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function start() { return first(); }

If the the log fills up just as we are entering b then we may have a list
full log of packets looking like:

Shadow Log:

...
{ prologue-packet: entering start ... }
{ prologue-packet: entering first ... }
{ tail-packet: leaving first with a tail call }

Incoming Packet:

{ prologue-packet: entering second ... }

Current JS Stack:

second
start

This patch solves this issue by providing enough extra space in the log
to always process the incoming packet when that forces an update. This way
clients can continue to behave exactly as they are.

We also document a corner case in some circumstances where the shadow
log may currently be insufficient to know how to reconcile:

For example:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function doNothingTail() { return Math.random() }
function start() {

for (i=0;i<1000;++i) doNothingTail();
return first();

}

Shadow Log:

...
, [123] {callee = 0x72a21aee0, frame = 0x7ffeef897270, callerFrame = 0x7ffeef8972e0, name = start}
, [124] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [125] tail-packet:{frame = 0x7ffeef8971f0}
, [126] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [127] tail-packet:{frame = 0x7ffeef8971f0}
...
, [140] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [141] tail-packet:{frame = 0x7ffeef8971f0}
, [142] {callee = 0x72a21af10, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = doNothingTail}
, [143] tail-packet:{frame = 0x7ffeef8971f0}
, [144] {callee = 0x72a21aeb0, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = first}
, [145] tail-packet:{frame = 0x7ffeef8971f0}
, [146] {callee = 0x72a21ae80, frame = 0x7ffeef8971f0, callerFrame = 0x7ffeef897270, name = second}
...

This log would seem to be indistinguishable from real tail recursion, such as:

"use strict";
function third() { return 1; }
function second() { return third(); }
function first() { return second(); }
function doNothingTail(n) {

return n ? doNothingTail(n-1) : first();

}
function start() {

return doNothingTail(1000);

}

interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::Packet::dump const):
(JSC::ShadowChicken::Frame::dump const):
(JSC::ShadowChicken::dump const):
Improved debugging output. Especially for functions.

(JSC::ShadowChicken::ShadowChicken):
Make space in the log for 1 additional packet to process when we slow log.

(JSC::ShadowChicken::log):
Include this packet in our update.

(JSC::ShadowChicken::update):
Address an edge case where we can eliminate tail-deleted frames that don't make sense.

LayoutTests:

inspector/debugger/tail-deleted-frames-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-from-vm-entry-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-from-vm-entry.html: Removed.
inspector/debugger/tail-deleted-frames-this-value-expected.txt: Removed.
inspector/debugger/tail-deleted-frames-this-value.html: Removed.
inspector/debugger/tail-deleted-frames.html: Removed.

Remove legacy tests that are difficult to read.

inspector/debugger/tail-deleted-frames/resources/stack-trace-utilities.js: Added.

inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-frames.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-native-tail-deleted-calls.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-intermediate-tail-deleted-frames.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-scopes.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-this-value.js: Added.
inspector/debugger/tail-deleted-frames/resources/tail-deleted-frames-vm-entry.js: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-frames-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-frames.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-tail-deleted-frames-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-tail-deleted-frames.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-scopes-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-scopes.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-this-value.html: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-vm-entry-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-vm-entry.html: Added.

Include modern tests that are easier to read.

inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-native-tail-deleted-calls-expected.txt: Added.
inspector/debugger/tail-deleted-frames/tail-deleted-frames-intermediate-native-tail-deleted-calls.html: Added.

Include a test that is known to produce bad output, since we have reproductive steps.

platform/mac/TestExpectations:

Updated pathes.

12:06 AM Changeset in webkit [249565] by commit-queue@webkit.org

5 edits in trunk

AccessibilityRenderObject::setSelectedTextRange fails to set the selection passed an empty line.
https://bugs.webkit.org/show_bug.cgi?id=201518
<rdar://problem/54835122>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-09-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: accessibility/set-selected-text-range-after-newline.html

In the case of an empty line, the CharacterIterator range start and end
were not equal, thus we were not advancing the iterator and returning
the iterator range end, which is not correct. With this change we are
always advancing the iterator if its text is just '\n'. This covers all
the cases we fixed before plus empty lines.

editing/Editing.cpp:

(WebCore::visiblePositionForIndexUsingCharacterIterator):

LayoutTests:

Extended this test to set the selection range passed an empty line.

accessibility/set-selected-text-range-after-newline-expected.txt:
accessibility/set-selected-text-range-after-newline.html:

Sep 5, 2019:

10:57 PM Changeset in webkit [249564] by Chris Dumez

5 edits in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
https://bugs.webkit.org/show_bug.cgi?id=201519

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Drop Webkit-specific changes to WPT tests.

IndexedDB-private-browsing/support.js:

Tools:

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
TestOption::useEphemeralSession flag based on the test folder.

DumpRenderTree/mac/DumpRenderTree.mm:

(shouldUseEphemeralSession):
(runTest):

WebKitTestRunner/TestOptions.cpp:

(WTR::shouldUseEphemeralSession):
(WTR::TestOptions::TestOptions):

10:06 PM Changeset in webkit [249563] by Chris Dumez

308 edits in trunk

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js
https://bugs.webkit.org/show_bug.cgi?id=201522

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in js-test.js.
Instead, use the new useEphemeralSession WKTR flag added in r249542.

resources/js-test.js:
storage/indexeddb/aborted-versionchange-closes-private.html:
storage/indexeddb/basics-private.html:
storage/indexeddb/clone-exception-private.html:
storage/indexeddb/closed-cursor-private.html:
storage/indexeddb/connection-leak-private.html:
storage/indexeddb/create-and-remove-object-store-private.html:
storage/indexeddb/create-object-store-options-private.html:
storage/indexeddb/createIndex-after-failure-private.html:
storage/indexeddb/createObjectStore-name-argument-required-private.html:
storage/indexeddb/createObjectStore-null-name-private.html:
storage/indexeddb/cursor-added-bug-private.html:
storage/indexeddb/cursor-advance-private.html:
storage/indexeddb/cursor-basics-private.html:
storage/indexeddb/cursor-cast-private.html:
storage/indexeddb/cursor-continue-dir-private.html:
storage/indexeddb/cursor-continue-private.html:
storage/indexeddb/cursor-continue-validity-private.html:
storage/indexeddb/cursor-delete-private.html:
storage/indexeddb/cursor-finished-private.html:
storage/indexeddb/cursor-inconsistency-private.html:
storage/indexeddb/cursor-index-delete-private.html:
storage/indexeddb/cursor-key-order-private.html:
storage/indexeddb/cursor-leak-private.html:
storage/indexeddb/cursor-overloads-private.html:
storage/indexeddb/cursor-prev-no-duplicate-private.html:
storage/indexeddb/cursor-primary-key-order-private.html:
storage/indexeddb/cursor-properties-private.html:
storage/indexeddb/cursor-request-cycle-private.html:
storage/indexeddb/cursor-reverse-bug-private.html:
storage/indexeddb/cursor-skip-deleted-private.html:
storage/indexeddb/cursor-update-private.html:
storage/indexeddb/cursor-update-value-argument-required-private.html:
storage/indexeddb/cursor-value-private.html:
storage/indexeddb/database-basics-private.html:
storage/indexeddb/database-close-private.html:
storage/indexeddb/database-closepending-flag-private.html:
storage/indexeddb/database-deletepending-flag-private.html:
storage/indexeddb/database-name-undefined-private.html:
storage/indexeddb/database-odd-names-private.html:
storage/indexeddb/database-quota-private.html:
storage/indexeddb/database-wrapper-private.html:
storage/indexeddb/delete-closed-database-object-private.html:
storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-private.html:
storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-private.html:
storage/indexeddb/delete-range-private.html:
storage/indexeddb/deleteIndex-bug110792-private.html:
storage/indexeddb/deleteIndex-private.html:
storage/indexeddb/deleteObjectStore-name-argument-required-private.html:
storage/indexeddb/deleteObjectStore-null-name-private.html:
storage/indexeddb/deleted-objects-private.html:
storage/indexeddb/deletedatabase-blocked-private.html:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-private.html:
storage/indexeddb/deletedatabase-not-blocked-private.html:
storage/indexeddb/deletedatabase-transaction-private.html:
storage/indexeddb/dont-commit-on-blocked-private.html:
storage/indexeddb/dont-wedge-private.html:
storage/indexeddb/duplicates-private.html:
storage/indexeddb/error-causes-abort-by-default-private.html:
storage/indexeddb/events-private.html:
storage/indexeddb/exception-in-event-aborts-private.html:
storage/indexeddb/exceptions-private.html:
storage/indexeddb/factory-cmp-private.html:
storage/indexeddb/factory-deletedatabase-private.html:
storage/indexeddb/get-keyrange-private.html:
storage/indexeddb/index-basics-private.html:
storage/indexeddb/index-count-private.html:
storage/indexeddb/index-cursor-private.html:
storage/indexeddb/index-duplicate-keypaths-private.html:
storage/indexeddb/index-get-key-argument-required-private.html:
storage/indexeddb/index-multientry-private.html:
storage/indexeddb/index-population-private.html:
storage/indexeddb/index-unique-private.html:
storage/indexeddb/interfaces-private.html:
storage/indexeddb/intversion-abort-in-initial-upgradeneeded-private.html:
storage/indexeddb/intversion-bad-parameters-private.html:
storage/indexeddb/intversion-blocked-private.html:
storage/indexeddb/intversion-close-between-events-private.html:
storage/indexeddb/intversion-close-in-oncomplete-private.html:
storage/indexeddb/intversion-close-in-upgradeneeded-private.html:
storage/indexeddb/intversion-encoding-private.html:
storage/indexeddb/intversion-gated-on-delete-private.html:
storage/indexeddb/intversion-long-queue-private.html:
storage/indexeddb/intversion-omit-parameter-private.html:
storage/indexeddb/intversion-open-in-upgradeneeded-private.html:
storage/indexeddb/intversion-open-with-version-private.html:
storage/indexeddb/intversion-pending-version-changes-ascending-private.html:
storage/indexeddb/intversion-pending-version-changes-descending-private.html:
storage/indexeddb/intversion-pending-version-changes-same-private.html:
storage/indexeddb/intversion-persistence-private.html:
storage/indexeddb/intversion-revert-on-abort-private.html:
storage/indexeddb/intversion-two-opens-no-versions-private.html:
storage/indexeddb/intversion-upgrades-private.html:
storage/indexeddb/invalid-keys-private.html:
storage/indexeddb/key-generator-private.html:
storage/indexeddb/key-sort-order-across-types-private.html:
storage/indexeddb/key-sort-order-date-private.html:
storage/indexeddb/key-type-array-private.html:
storage/indexeddb/key-type-binary-private.html:
storage/indexeddb/key-type-infinity-private.html:
storage/indexeddb/keypath-arrays-private.html:
storage/indexeddb/keypath-basics-private.html:
storage/indexeddb/keypath-edges-private.html:
storage/indexeddb/keypath-fetch-key-private.html:
storage/indexeddb/keypath-intrinsic-properties-private.html:
storage/indexeddb/keyrange-private.html:
storage/indexeddb/keyrange-required-arguments-private.html:
storage/indexeddb/lazy-index-population-private.html:
storage/indexeddb/lazy-index-types-private.html:
storage/indexeddb/legacy-constants-private.html:
storage/indexeddb/list-ordering-private.html:
storage/indexeddb/metadata-private.html:
storage/indexeddb/metadata-race-private.html:
storage/indexeddb/modern/abort-objectstore-info-private.html:
storage/indexeddb/modern/abort-requests-cancelled-private.html:
storage/indexeddb/modern/aborted-put-private.html:
storage/indexeddb/modern/autoincrement-abort-private.html:
storage/indexeddb/modern/basic-add-private.html:
storage/indexeddb/modern/basic-put-private.html:
storage/indexeddb/modern/binary-keys-1-private.html:
storage/indexeddb/modern/blocked-open-db-requests-private.html:
storage/indexeddb/modern/create-index-failures-private.html:
storage/indexeddb/modern/createobjectstore-basic-private.html:
storage/indexeddb/modern/createobjectstore-failures-private.html:
storage/indexeddb/modern/cursor-1-private.html:
storage/indexeddb/modern/cursor-2-private.html:
storage/indexeddb/modern/cursor-3-private.html:
storage/indexeddb/modern/cursor-4-private.html:
storage/indexeddb/modern/cursor-5-private.html:
storage/indexeddb/modern/cursor-6-private.html:
storage/indexeddb/modern/cursor-7-private.html:
storage/indexeddb/modern/cursor-8-private.html:
storage/indexeddb/modern/date-basic-private.html:
storage/indexeddb/modern/deletedatabase-1-private.html:
storage/indexeddb/modern/deletedatabase-2-private.html:
storage/indexeddb/modern/deletedatabase-null-name-exception-private.html:
storage/indexeddb/modern/deletedatabase-request-event-private.html:
storage/indexeddb/modern/deletedatabase-request-private.html:
storage/indexeddb/modern/deleteindex-1-private.html:
storage/indexeddb/modern/deleteindex-2-private.html:
storage/indexeddb/modern/deleteindex-3-private.html:
storage/indexeddb/modern/deleteindex-4-private.html:
storage/indexeddb/modern/deleteobjectstore-1-private.html:
storage/indexeddb/modern/double-abort-private.html:
storage/indexeddb/modern/double-open-private.html:
storage/indexeddb/modern/gc-closes-database-private.html:
storage/indexeddb/modern/get-index-failures-private.html:
storage/indexeddb/modern/get-keyrange-private.html:
storage/indexeddb/modern/idbcursor-continue-primary-key-1-private.html:
storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private.html:
storage/indexeddb/modern/idbdatabase-transaction-failures-private.html:
storage/indexeddb/modern/idbindex-getall-1-private.html:
storage/indexeddb/modern/idbindex-getallkeys-1-private.html:
storage/indexeddb/modern/idbindex-properties-basic-private.html:
storage/indexeddb/modern/idbkey-array-equality-private.html:
storage/indexeddb/modern/idbobjectstore-clear-1-private.html:
storage/indexeddb/modern/idbobjectstore-clear-2-private.html:
storage/indexeddb/modern/idbobjectstore-count-1-private.html:
storage/indexeddb/modern/idbobjectstore-count-failures-private.html:
storage/indexeddb/modern/idbobjectstore-delete-1-private.html:
storage/indexeddb/modern/idbobjectstore-delete-2-private.html:
storage/indexeddb/modern/idbobjectstore-delete-failures-private.html:
storage/indexeddb/modern/idbobjectstore-get-failures-private.html:
storage/indexeddb/modern/idbobjectstore-getall-1-private.html:
storage/indexeddb/modern/idbobjectstore-getallkeys-1-private.html:
storage/indexeddb/modern/idbobjectstore-getkey-1-private.html:
storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private.html:
storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html:
storage/indexeddb/modern/idbtransaction-objectstores-1-private.html:
storage/indexeddb/modern/index-1-private.html:
storage/indexeddb/modern/index-2-private.html:
storage/indexeddb/modern/index-3-private.html:
storage/indexeddb/modern/index-4-private.html:
storage/indexeddb/modern/index-5-private.html:
storage/indexeddb/modern/index-cursor-1-private.html:
storage/indexeddb/modern/index-cursor-2-private.html:
storage/indexeddb/modern/index-cursor-3-private.html:
storage/indexeddb/modern/index-get-count-basic-private.html:
storage/indexeddb/modern/index-get-count-failures-private.html:
storage/indexeddb/modern/index-rename-1-private.html:
storage/indexeddb/modern/keypath-basic-private.html:
storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private.html:
storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html:
storage/indexeddb/modern/objectstore-attributes-private.html:
storage/indexeddb/modern/objectstore-cursor-advance-failures-private.html:
storage/indexeddb/modern/objectstore-cursor-continue-failures-private.html:
storage/indexeddb/modern/objectstore-rename-1-private.html:
storage/indexeddb/modern/opencursor-failures-private.html:
storage/indexeddb/modern/opendatabase-request-event-private.html:
storage/indexeddb/modern/opendatabase-request-private.html:
storage/indexeddb/modern/opendatabase-success-after-versionchange-private.html:
storage/indexeddb/modern/opendatabase-versions-private.html:
storage/indexeddb/modern/request-readystate-private.html:
storage/indexeddb/modern/single-entry-index-invalid-key-crash-private.html:
storage/indexeddb/modern/transaction-scheduler-1-private.html:
storage/indexeddb/modern/transaction-scheduler-2-private.html:
storage/indexeddb/modern/transaction-scheduler-3-private.html:
storage/indexeddb/modern/transaction-scheduler-4-private.html:
storage/indexeddb/modern/transaction-scheduler-5-private.html:
storage/indexeddb/modern/transaction-scheduler-6-private.html:
storage/indexeddb/modern/transactions-stop-on-navigation-private.html:
storage/indexeddb/modern/versionchange-abort-then-reopen-private.html:
storage/indexeddb/modern/versionchange-event-private.html:
storage/indexeddb/mozilla/add-twice-failure-private.html:
storage/indexeddb/mozilla/autoincrement-indexes-private.html:
storage/indexeddb/mozilla/bad-keypath-private.html:
storage/indexeddb/mozilla/clear-private.html:
storage/indexeddb/mozilla/create-index-unique-private.html:
storage/indexeddb/mozilla/create-index-with-integer-keys-private.html:
storage/indexeddb/mozilla/create-objectstore-basics-private.html:
storage/indexeddb/mozilla/create-objectstore-null-name-private.html:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private.html:
storage/indexeddb/mozilla/cursor-mutation-private.html:
storage/indexeddb/mozilla/cursor-update-updates-indexes-private.html:
storage/indexeddb/mozilla/cursors-private.html:
storage/indexeddb/mozilla/delete-result-private.html:
storage/indexeddb/mozilla/event-source-private.html:
storage/indexeddb/mozilla/global-data-private.html:
storage/indexeddb/mozilla/index-prev-no-duplicate-private.html:
storage/indexeddb/mozilla/indexes-private.html:
storage/indexeddb/mozilla/key-requirements-delete-null-key-private.html:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-private.html:
storage/indexeddb/mozilla/key-requirements-private.html:
storage/indexeddb/mozilla/key-requirements-put-no-key-private.html:
storage/indexeddb/mozilla/key-requirements-put-null-key-private.html:
storage/indexeddb/mozilla/object-cursors-private.html:
storage/indexeddb/mozilla/object-identity-private.html:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private.html:
storage/indexeddb/mozilla/object-store-remove-values-private.html:
storage/indexeddb/mozilla/objectstorenames-private.html:
storage/indexeddb/mozilla/odd-result-order-private.html:
storage/indexeddb/mozilla/open-database-null-name-private.html:
storage/indexeddb/mozilla/put-get-values-private.html:
storage/indexeddb/mozilla/readonly-transactions-private.html:
storage/indexeddb/mozilla/readwrite-transactions-private.html:
storage/indexeddb/mozilla/readyState-private.html:
storage/indexeddb/mozilla/remove-index-private.html:
storage/indexeddb/mozilla/remove-objectstore-private.html:
storage/indexeddb/mozilla/versionchange-abort-private.html:
storage/indexeddb/mutating-cursor-private.html:
storage/indexeddb/object-lookups-in-versionchange-private.html:
storage/indexeddb/objectStore-required-arguments-private.html:
storage/indexeddb/objectstore-autoincrement-private.html:
storage/indexeddb/objectstore-basics-private.html:
storage/indexeddb/objectstore-clear-private.html:
storage/indexeddb/objectstore-count-private.html:
storage/indexeddb/objectstore-cursor-private.html:
storage/indexeddb/objectstore-removeobjectstore-private.html:
storage/indexeddb/odd-strings-private.html:
storage/indexeddb/open-bad-versions-private.html:
storage/indexeddb/open-cursor-private.html:
storage/indexeddb/open-during-transaction-private.html:
storage/indexeddb/open-ordering-private.html:
storage/indexeddb/opencursor-key-private.html:
storage/indexeddb/optional-arguments-private.html:
storage/indexeddb/pending-activity-private.html:
storage/indexeddb/pending-version-change-on-exit-private.html:
storage/indexeddb/pending-version-change-stuck-private.html:
storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html:
storage/indexeddb/persistence-private.html:
storage/indexeddb/prefetch-bugfix-108071-private.html:
storage/indexeddb/prefetch-invalidation-private.html:
storage/indexeddb/prefetch-race-private.html:
storage/indexeddb/primary-key-unique-to-objectstore-private.html:
storage/indexeddb/queued-commands-private.html:
storage/indexeddb/readonly-private.html:
storage/indexeddb/readonly-properties-private.html:
storage/indexeddb/removed-private.html:
storage/indexeddb/request-continue-abort-private.html:
storage/indexeddb/request-event-propagation-private.html:
storage/indexeddb/request-leak-private.html:
storage/indexeddb/request-result-cache-private.html:
storage/indexeddb/set_version_blocked-private.html:
storage/indexeddb/setversion-blocked-by-versionchange-close-private.html:
storage/indexeddb/setversion-not-blocked-private.html:
storage/indexeddb/structured-clone-private.html:
storage/indexeddb/transaction-abort-private.html:
storage/indexeddb/transaction-active-flag-private.html:
storage/indexeddb/transaction-after-close-private.html:
storage/indexeddb/transaction-and-objectstore-calls-private.html:
storage/indexeddb/transaction-basics-private.html:
storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private.html:
storage/indexeddb/transaction-complete-with-js-recursion-private.html:
storage/indexeddb/transaction-complete-workers-private.html:
storage/indexeddb/transaction-coordination-across-databases-private.html:
storage/indexeddb/transaction-coordination-within-database-private.html:
storage/indexeddb/transaction-crash-in-tasks-private.html:
storage/indexeddb/transaction-crash-on-abort-private.html:
storage/indexeddb/transaction-error-private.html:
storage/indexeddb/transaction-event-propagation-private.html:
storage/indexeddb/transaction-ordering-private.html:
storage/indexeddb/transaction-overlapping-private.html:
storage/indexeddb/transaction-read-only-private.html:
storage/indexeddb/transaction-readwrite-exclusive-private.html:
storage/indexeddb/transaction-rollback-private.html:
storage/indexeddb/transaction-scope-sequencing-private.html:
storage/indexeddb/transaction-storeNames-required-private.html:
storage/indexeddb/unblocked-version-changes-private.html:
storage/indexeddb/unprefix-private.html:
storage/indexeddb/value-undefined-private.html:
storage/indexeddb/values-odd-types-private.html:
storage/indexeddb/version-change-abort-private.html:
storage/indexeddb/version-change-event-basic-private.html:
storage/indexeddb/version-change-event-private.html:
storage/indexeddb/version-change-exclusive-private.html:
storage/indexeddb/versionchangerequest-activedomobject-private.html:

9:51 PM Changeset in webkit [249562] by Chris Dumez

3 edits
1 copy
1 add in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/cache/disk-cache/disk-cache-vary-cookie.html
https://bugs.webkit.org/show_bug.cgi?id=201524

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() as it does not do the right thing for WebKit2.
Instead, use the new useEphemeralSession WKTR flag added in r249542.

http/tests/cache/disk-cache/disk-cache-vary-cookie-expected.txt:
http/tests/cache/disk-cache/disk-cache-vary-cookie-private-expected.txt: Added.
http/tests/cache/disk-cache/disk-cache-vary-cookie-private.html: Copied from LayoutTests/http/tests/cache/disk-cache/disk-cache-vary-cookie.html.
http/tests/cache/disk-cache/disk-cache-vary-cookie.html:

9:37 PM Changeset in webkit [249561] by Chris Dumez

5 edits
2 adds in trunk/LayoutTests

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html
https://bugs.webkit.org/show_bug.cgi?id=201523

Reviewed by Alex Christensen.

Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in plugins/private-browsing-mode.html
since it does not do the right thing for WebKit2. Instead, use the new useEphemeralSession
WKTR flag.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:
plugins/non-private-browsing-mode-expected.txt: Added.
plugins/non-private-browsing-mode.html: Added.
plugins/private-browsing-mode-expected.txt:
plugins/private-browsing-mode.html:

7:38 PM Changeset in webkit [249560] by Fujii Hironori

5 edits in trunk/Source

[Win] Add support for MouseEvent.buttons
https://bugs.webkit.org/show_bug.cgi?id=201445

Reviewed by Brent Fulgham.

Source/WebCore:

Spec: <https://www.w3.org/TR/uievents/#dom-mouseevent-buttons>

platform/win/GDIUtilities.h:

(buttonsForEvent): Added.

platform/win/PlatformMouseEventWin.cpp:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):
Set m_buttons.

Source/WebKit:

Shared/win/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
Set m_buttons.

6:48 PM Changeset in webkit [249559] by Fujii Hironori

5 edits in trunk

[Win] Support Per-Monitor (V2) DPI Awareness
https://bugs.webkit.org/show_bug.cgi?id=201450

Reviewed by Don Olmstead.

Source/WebCore:

platform/win/GDIUtilities.cpp:

(WebCore::deviceScaleFactorForWindow): Use GetDpiForWindow if available by using soft linking.

Tools:

MiniBrowser/win/MainWindow.cpp:

(MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.

MiniBrowser/win/WinMain.cpp:

(wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.

6:45 PM Changeset in webkit [249558] by Fujii Hironori

2 edits in trunk/Source/WebKitLegacy/win

[WinCairo][WK1] ASSERTION FAILED: !isAcceleratedCompositing() in WebView::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=201493

Reviewed by Don Olmstead.

WebView::paint switches painting code path by checking accelerated
compositing enabled. However, accelerated compositing could be
enabled after the checking.

WebView::paint called WebView::paintCompositedContentToHDC and
WebCore::Page::updateRendering.
WebView::paintCompositedContentToHDC checks accelerated
compositing enabled. Then, WebCore::Page::updateRendering executes
JavaScript and accelerated compositing could be enabled.

WebView.cpp:

(WebView::paint): Call WebCore::Page::updateRendering the
beginning of the function.

6:07 PM Changeset in webkit [249557] by Chris Dumez

5 edits in trunk

REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
https://bugs.webkit.org/show_bug.cgi?id=201440
<rdar://problem/54998427>

Reviewed by Alex Christensen.

Source/WebKit:

Add private WKBundlePage API to query if the WebPage is currently suspended or not.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageIsSuspended):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:

Tools:

Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
created in the WebContent process is the one that is currently running the test and that we want to talk to.
Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::page const):

5:03 PM Changeset in webkit [249556] by mark.lam@apple.com

12 edits in trunk/Source

Refactor the Gigacage code to require less pointer casting.
https://bugs.webkit.org/show_bug.cgi?id=201521

Reviewed by Saam Barati.

Source/bmalloc:

Define a Gigacage::Config struct instead of hacking around a g_gigacageBasePtrs array of bytes.
Change Gigacage::basePtr() to return a pointer instead of a reference to the requested basePtr. Instead, make it explicit when the client is trying to take the address of the basePtr, or setting it.
Renamed wasEnabled() to isEnabled() because it returns the present state of the flag, not some past state.

bmalloc/Gigacage.cpp:

(Gigacage::bmalloc::protectGigacageBasePtrs):
(Gigacage::bmalloc::unprotectGigacageBasePtrs):
(Gigacage::bmalloc::runwaySize):
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::primitiveGigacageDisabled):

bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::Config::basePtr const):
(Gigacage::Config::setBasePtr):
(Gigacage::isEnabled):
(Gigacage::basePtr):
(Gigacage::addressOfBasePtr):
(Gigacage::size):
(Gigacage::caged):
(Gigacage::wasEnabled): Deleted.
(Gigacage::setWasEnabled): Deleted.
(Gigacage::basePtrs): Deleted.

bmalloc/HeapKind.h:

(bmalloc::heapKind):
(bmalloc::isActiveHeapKindAfterEnsuringGigacage):
(bmalloc::mapToActiveHeapKindAfterEnsuringGigacage):

Source/JavaScriptCore:

Change LLInt's loadCagedJSValue() to skip the caging if Gigacage is not enabled
in the build. This allows us to remove the unneeded stubs in WTF Gigacage.h.

jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cageConditionally):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter64.asm:
runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):

Source/WTF:

Remove some unneeded stubs in WTF Gigacage.h.

wtf/Gigacage.cpp:
wtf/Gigacage.h:

(Gigacage::name):
(Gigacage::isEnabled):
(Gigacage::basePtr): Deleted.
(Gigacage::basePtrs): Deleted.

4:42 PM Changeset in webkit [249555] by Justin Fan

7 edits
1 add in trunk/LayoutTests

[WebGPU] Fix new test results after adding console warnings
https://bugs.webkit.org/show_bug.cgi?id=201526

Unreviewed test expectation updates.

webgpu/buffer-errors-expected.txt:
webgpu/map-read-buffers-expected.txt:
webgpu/map-write-buffers-expected.txt:
webgpu/render-pipelines.html: Fix WHLSL compile error.
webgpu/uncaptured-errors-expected.txt: Added.
webgpu/whlsl/use-undefined-variable-2-expected.txt:
webgpu/whlsl/use-undefined-variable-expected.txt:

4:37 PM Changeset in webkit [249554] by Jonathan Bedard

5 edits in trunk/Tools

results.webkit.org: Assign notifyRerender before calling
https://bugs.webkit.org/show_bug.cgi?id=201510

Reviewed by Aakash Jain.

Timelines should define notifyRerender to an empty function,
rename notifiyRerender to notifyRerender.

resultsdbpy/resultsdbpy/view/static/js/timeline.js:
resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
resultsdbpy/resultsdbpy/view/templates/search.html:
resultsdbpy/resultsdbpy/view/templates/suite_results.html:

4:21 PM Changeset in webkit [249553] by Ryan Haddad

3 edits in trunk/LayoutTests

Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/ready.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181837

Unreviewed test gardening.

platform/ios/TestExpectations: Mark test as flaky.
platform/mac/TestExpectations: Ditto.

4:21 PM Changeset in webkit [249552] by ysuzuki@apple.com

4 edits in trunk/Source/JavaScriptCore

Unreviewed, follow-up after r249530 and r249509
https://bugs.webkit.org/show_bug.cgi?id=201495

Rename FTLOutput::weakPointer to alreadyRegisteredWeakPointer and alreadyRegisteredFrozenPointer.

builtins/PromiseConstructor.js:

(nakedConstructor.Promise.resolve):
(nakedConstructor.Promise.reject):
(nakedConstructor.Promise):
(nakedConstructor.InternalPromise.resolve):
(nakedConstructor.InternalPromise.reject):
(nakedConstructor.InternalPromise):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::weakPointer):
(JSC::FTL::DFG::LowerDFGToB3::frozenPointer):
(JSC::FTL::DFG::LowerDFGToB3::weakStructure):

ftl/FTLOutput.h:

(JSC::FTL::Output::alreadyRegisteredWeakPointer):
(JSC::FTL::Output::alreadyRegisteredFrozenPointer):
(JSC::FTL::Output::weakPointer): Deleted.

4:16 PM Changeset in webkit [249551] by Kocsen Chung

3 edits
2 adds in branches/safari-608.2.11.1-branch

Cherry-pick r249534. rdar://problem/55084674

AX: children cache are not re-computed if tab index is removed
https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

accessibility/tabindex-removed-expected.txt: Added.
accessibility/tabindex-removed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@249534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:08 PM Changeset in webkit [249550] by Kocsen Chung

8 edits
2 adds in branches/safari-608-branch

Apply patch. rdar://problem/55001140

Treat a two-finger single tap as if the user tapped with the Cmd key pressed https://bugs.webkit.org/show_bug.cgi?id=201420 <rdar://problem/53207786>

Reviewed by Simon Fraser.

Source/WebKit:

Set the metaKey modifier to true when generating a click event based on a two-finger single tap. This is important so that sites like Google and DuckDuckGo
correctly open links in their search results page in a new tab in Safari on iOS. This currently doesn't work because those sites will call preventDefault()
if the metaKey flag isn't set on a "click" event, and if it is set, they let the browser handle the navigation themselves.

UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView _twoFingerSingleTapGestureRecognized:]):

Tools:

Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
-[HIDEventGenerator twoFingerTap:completionBlock:].

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.h: (WTR::UIScriptController::twoFingerSingleTapAtPoint):
WebKitTestRunner/ios/UIScriptControllerIOS.h:
WebKitTestRunner/ios/UIScriptControllerIOS.mm: (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):

LayoutTests:

Add a new event that checks that a two-finger single tap on a clickable element yields a "click" event with the metaKey flag set to true.

fast/events/ios/click-event-two-finger-single-tap-meta-key-expected.txt: Added.
fast/events/ios/click-event-two-finger-single-tap-meta-key.html: Added.

4:03 PM Changeset in webkit [249549] by Jonathan Bedard

2 edits in trunk/Tools

results.webkit.org: Fix prepending search result on empty list
https://bugs.webkit.org/show_bug.cgi?id=201512

Reviewed by Aakash Jain.

resultsdbpy/resultsdbpy/view/templates/search.html:

2:58 PM Changeset in webkit [249548] by cturner@igalia.com

11 edits in trunk/Source/WebCore

[EME] Introduce a Proxy CDM for thread-safe access to CDM instances from background decryption threads
https://bugs.webkit.org/show_bug.cgi?id=201339

Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

platform/encryptedmedia/CDMInstance.h:
platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::isolatedKey):
(WebCore::ProxyCDMClearKey::isolatedKeys const):
(WebCore::CDMInstanceClearKey::CDMInstanceClearKey):

platform/encryptedmedia/clearkey/CDMClearKey.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::cdmInstanceAttached):

platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(handleKeyResponse):
(findAndSetKey):
(decrypt):

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(isCDMInstanceAvailable):
(sinkEventHandler):
(setContext):

platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstance::proxyCDM const):

testing/MockCDMFactory.h:

2:48 PM Changeset in webkit [249547] by ysuzuki@apple.com

39 edits
1 copy
1 add in trunk/Source/JavaScriptCore

[JSC] Generalize Get/PutPromiseInternalField for InternalFieldObjectImpl
https://bugs.webkit.org/show_bug.cgi?id=201513

Reviewed by Ross Kirsling.

This patch extracts JSPromise's internal fields mechanism as JSInternalFieldsObjectImpl, and make it reusable for the other objects.
It is preparation for using this internal fields mechanism for generators, async functions, async generators, array iterators and so on.

The profiler is telling many recompilation of Generator's resume function (including async generator's one). We are using properties
with private-symbols as a storage for internal state of generators. However, the spec defines that each generator from different generator-functions
has different Prototype. While we need to share one Generator.prototype.next function, generators tend to have different Structures due to
different Prototype and accessing internal fields with get_by_id_direct sadly becomes super megamorphic while it is not necessary.
And every time new Structure for new generator pops up, DFG/FTL code for generator resume function gets OSR exit or eventually this function gets
emits super generic code unfortunately. By using internal fields for storing these state, we can avoid this performance problem.

Bytecodes and corresponding DFG nodes are just renamed. JSPromise is now inheriting JSInternalFieldsObjectImpl, which can holds specified
number of internal fields. And op_get_internal_field / op_put_internal_field can access these internal fields.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.rb:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

bytecode/Opcode.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGetInternalField):
(JSC::BytecodeGenerator::emitPutInternalField):
(JSC::BytecodeGenerator::emitGetPromiseInternalField): Deleted.
(JSC::BytecodeGenerator::emitPutPromiseInternalField): Deleted.

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_getPromiseInternalField):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_putPromiseInternalField):

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGMayExit.cpp:
dfg/DFGNode.h:

(JSC::DFG::Node::hasInternalFieldIndex):
(JSC::DFG::Node::hasHeapPrediction):

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetInternalField):
(JSC::DFG::SpeculativeJIT::compilePutInternalField):
(JSC::DFG::SpeculativeJIT::compileCreatePromise):
(JSC::DFG::SpeculativeJIT::compileNewPromise):
(JSC::DFG::SpeculativeJIT::compileGetPromiseInternalField): Deleted.
(JSC::DFG::SpeculativeJIT::compilePutPromiseInternalField): Deleted.

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGStoreBarrierInsertionPhase.cpp:
ftl/FTLAbstractHeapRepository.h:
ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewPromise):
(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileGetInternalField):
(JSC::FTL::DFG::LowerDFGToB3::compilePutInternalField):
(JSC::FTL::DFG::LowerDFGToB3::compileGetPromiseInternalField): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::compilePutPromiseInternalField): Deleted.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emit_op_get_promise_internal_field): Deleted.
(JSC::JIT::emit_op_put_promise_internal_field): Deleted.

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emit_op_get_promise_internal_field): Deleted.
(JSC::JIT::emit_op_put_promise_internal_field): Deleted.

llint/LLIntOffsetsExtractor.cpp:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSInternalFieldObjectImpl.h: Copied from Source/JavaScriptCore/runtime/JSPromise.h.

(JSC::JSInternalFieldObjectImpl::allocationSize):
(JSC::JSInternalFieldObjectImpl::internalField const):
(JSC::JSInternalFieldObjectImpl::internalField):
(JSC::JSInternalFieldObjectImpl::offsetOfInternalFields):
(JSC::JSInternalFieldObjectImpl::offsetOfInternalField):
(JSC::JSInternalFieldObjectImpl::JSInternalFieldObjectImpl):

runtime/JSInternalFieldObjectImplInlines.h: Added.

(JSC::JSInternalFieldObjectImpl<passedNumberOfInternalFields>::visitChildren):

runtime/JSPromise.cpp:

(JSC::JSPromise::finishCreation):
(JSC::JSPromise::visitChildren):
(JSC::JSPromise::status const):
(JSC::JSPromise::result const):
(JSC::JSPromise::isHandled const):

runtime/JSPromise.h:

(JSC::JSPromise::allocationSize): Deleted.
(JSC::JSPromise::offsetOfInternalFields): Deleted.
(JSC::JSPromise::offsetOfInternalField): Deleted.
(): Deleted.

2:44 PM Changeset in webkit [249546] by Jonathan Bedard

4 edits in trunk/Tools

results.webkit.org: Retain certain parameters when following menu links
https://bugs.webkit.org/show_bug.cgi?id=201463

Rubber-stamped by Aakash Jain.

resultsdbpy/resultsdbpy/view/site_menu.py:

(SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.

resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,

retain the specified parameters

resultsdbpy/resultsdbpy/view/view_routes.py:

(ViewRoutes.init):

2:29 PM Changeset in webkit [249545] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC] LayoutState should not need the initial containing block
https://bugs.webkit.org/show_bug.cgi?id=201511
<rdar://problem/55079241>

Reviewed by Antti Koivisto.

Throw-away layouts should just be able to initialize a dedicated LayoutState without passing in the ICB.

layout/LayoutState.cpp:

(WebCore::Layout::LayoutState::markNeedsUpdate):
(WebCore::Layout::LayoutState::run):
(WebCore::Layout::LayoutState::LayoutState): Deleted.

layout/LayoutState.h:

(WebCore::Layout::LayoutState::initialContainingBlock const): Deleted.

layout/Verification.cpp:

(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

layout/floats/FloatingContext.cpp: Fix a (very sad)typo.

(WebCore::Layout::FloatingContext::constraints const):

layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::printLayoutTreeForLiveDocuments):

2:19 PM Changeset in webkit [249544] by russell_e@apple.com

3 edits in trunk/LayoutTests

Layout Test media/audio-concurrent-supported.html is a flaky failure.
rdar://55081191

Unreviewed Test Gardening.

platform/ios/TestExpectations:
platform/mac/TestExpectations:

2:13 PM Changeset in webkit [249543] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r247463.
https://bugs.webkit.org/show_bug.cgi?id=201515

JetStream2 code-load related regression (Requested by
yusukesuzuki on #webkit).

Reverted changeset:

"Keyword lookup can use memcmp to get around unaligned load
undefined behavior"
https://bugs.webkit.org/show_bug.cgi?id=199650
https://trac.webkit.org/changeset/247463

2:12 PM Changeset in webkit [249542] by Chris Dumez

62 edits in trunk

[WK2] Add proper layout test support for ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=201475

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

IndexedDB-private-browsing/support.js:

Tools:

Add proper layout test support for ephemeral sessions via:

This actually creates a new WebView using an ephemeral data store to load the test which
is *true* private browsing.

testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
process, which is a hack and does not truly enable private browsing because the UIProcess and
the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
get rid of it.

Note that WK2 does not support using a WebContent process for different sessions / data stores.
Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
simply to support testRunner.setPrivateBrowsingEnabled().

DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

DumpRenderTree/TestOptions.h:
DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::generatePageConfiguration):
(WTR::updateTestOptionsFromTestHeader):

WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

LayoutTests:

Update existing layout tests to either switch to the new mechanism when trivial or to rename
setPrivateBrowsingEnabled() to setPrivateBrowsingEnabled_DEPRECATED() when it is not.

crypto/subtle/rsa-indexeddb-non-exportable-private.html:
crypto/subtle/rsa-indexeddb-private.html:
http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html:
http/tests/adClickAttribution/resources/util.js:

(tearDownAndFinish):

http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html:
http/tests/cache-storage/cache-persistency.https.html:
http/tests/cache-storage/cache-representation.https.html:
http/tests/cache/disk-cache/disk-cache-vary-cookie.html:
http/tests/cookies/private-cookie-storage.html:
http/tests/media/now-playing-info-private-browsing.html:
http/tests/security/appcache-in-private-browsing.html:
http/tests/security/appcache-switching-private-browsing.html:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled.php:
http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled.php:
http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled.php:
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt:
http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled.php:
http/tests/security/cookies/resources/first-party-cookie-allow.xsl:
http/tests/security/cookies/resources/third-party-cookie-blocking.xsl:
http/tests/security/cookies/third-party-cookie-blocking-main-frame.html:
http/tests/security/cookies/third-party-cookie-blocking-redirect.html:
http/tests/security/cookies/third-party-cookie-blocking-user-action.html:
http/tests/security/cookies/third-party-cookie-blocking.html:
http/tests/security/cross-frame-access-private-browsing.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled-allowed.html:
http/tests/security/cross-origin-plugin-private-browsing-toggled.html:
http/tests/security/private-browsing-http-auth.html:
http/tests/security/storage-blocking-loosened-private-browsing-plugin.html:
http/tests/security/storage-blocking-strengthened-private-browsing-plugin.html:
http/tests/security/strip-referrer-to-origin-for-third-party-redirects-in-private-mode.html:
http/tests/security/strip-referrer-to-origin-for-third-party-requests-in-private-mode.html:
http/tests/storageAccess/has-storage-access-true-if-feature-off.html:
http/tests/workers/service/resources/basic-register.js:

(async.test):

http/tests/workers/service/serviceworker-private-browsing.https.html:
http/wpt/fetch/dnt-header-after-redirection.html:
platform/wk2/TestExpectations:
plugins/private-browsing-mode-2.html:
plugins/private-browsing-mode.html:
resources/js-test.js:
storage/domstorage/localstorage/private-browsing-affects-storage.html:
storage/domstorage/localstorage/resources/private-browsing-1.html:
storage/domstorage/localstorage/resources/private-browsing-2.html:
storage/indexeddb/open-db-private-browsing.html:
storage/indexeddb/resources/open-db-private-browsing.js:
storage/websql/private-browsing-noread-nowrite.html:
storage/websql/private-browsing-open-disabled.html:

2:01 PM Changeset in webkit [249541] by Kocsen Chung

1 copy in tags/Safari-609.1.3.2

Tag Safari-609.1.3.2.

1:55 PM Changeset in webkit [249540] by Kocsen Chung

7 edits in tags/Safari-609.1.3.1/Source

Versioning.

12:21 PM Changeset in webkit [249539] by Justin Fan

22 edits
4 copies
1 add in trunk

[WebGPU] Implement GPUUncapturedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=199676

Reviewed by Dean Jackson.

Source/WebCore:

Implement GPUUncapturedErrorEvent and "uncapturederror" event name.
Add the onuncapturederror EventHandler attribute to GPUDevice.

Test: webgpu/uncaptured-errors.html

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Modules/webgpu/GPUUncapturedErrorEvent.cpp:

(WebCore::GPUUncapturedErrorEvent::create):
(WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent):
(WebCore::GPUUncapturedErrorEvent::eventInterface const):

Modules/webgpu/GPUUncapturedErrorEvent.h:
Modules/webgpu/GPUUncapturedErrorEvent.idl:
Modules/webgpu/WebGPUAdapter.cpp: Must now provide ScriptExecutionContext to any created GPUDevice.

(WebCore::WebGPUAdapter::requestDevice const):

Modules/webgpu/WebGPUAdapter.h:
Modules/webgpu/WebGPUAdapter.idl:
Modules/webgpu/WebGPUDevice.cpp: Is now an EventTarget.

(WebCore::WebGPUDevice::tryCreate):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::printValidationErrorToConsole):
(WebCore::WebGPUDevice::dispatchUncapturedError): Events should only be fired from the main thread.

Modules/webgpu/WebGPUDevice.h:
Modules/webgpu/WebGPUDevice.idl:
Modules/webgpu/WebGPUDeviceEventHandler.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
dom/EventNames.h:
dom/EventNames.in:
dom/EventTargetFactory.in:
platform/graphics/gpu/GPUError.cpp: GPUErrors can only be created internally; creation should never fail.

(WebCore::createError):

platform/graphics/gpu/GPUError.h:
platform/graphics/gpu/GPUErrorScopes.cpp:

(WebCore::GPUErrorScopes::create):
(WebCore::GPUErrorScopes::GPUErrorScopes):
(WebCore::GPUErrorScopes::generateError): Use a callback for now, since GPUErrorScopes is still under platform.

platform/graphics/gpu/GPUErrorScopes.h:

(WebCore::GPUErrorScopes::create): Deleted.

LayoutTests:

Add a test to ensure GPUUncapturedErrorEvents work.

webgpu/uncaptured-errors.html: Added.

11:47 AM Changeset in webkit [249538] by Tadeu Zagallo

5 edits
1 add in trunk

LazyClassStructure::setConstructor should not store the constructor to the global object
https://bugs.webkit.org/show_bug.cgi?id=201484
<rdar://problem/50400451>

Reviewed by Yusuke Suzuki.

JSTests:

stress/web-assembly-constructors-should-not-override-global-object-property.js: Added.

Source/JavaScriptCore:

LazyClassStructure::setConstructor sets the constructor as a property of the global object.
This became a problem when it started being used for WebAssembly constructors, such as Module
and Instance, since they are properties of the WebAssembly object, not the global object. That
resulted in properties of the global object replaced whenever a lazy WebAssembly constructor
was first accessed. e.g.

globalThis.Module = x;
WebAssembly.Module;
globalThis.Module === WebAssembly.Module;

runtime/LazyClassStructure.cpp:

(JSC::LazyClassStructure::Initializer::setConstructor):

runtime/LazyClassStructure.h:
runtime/Lookup.h:

(JSC::reifyStaticProperty):

11:29 AM Changeset in webkit [249537] by Ryan Haddad

2 edits in trunk/LayoutTests

[iOS] Layout Test imported/w3c/web-platform-tests/html/semantics/embedded-content/the-video-element/video_timeupdate_on_seek.html is failing
https://bugs.webkit.org/show_bug.cgi?id=201509

Unreviewed test gardening.

platform/ios-simulator/TestExpectations: Mark test as failing.

11:03 AM Changeset in webkit [249536] by Antti Koivisto

6 edits in trunk

Generate event region for both the main graphics layer and the scrolled contents layer
https://bugs.webkit.org/show_bug.cgi?id=201487

Reviewed by Simon Fraser.

Source/WebCore:

We currently generate region for one of them only. With borders both need it.

Also share more code with painting paths.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateEventRegion):

Generate region for both layers.

(WebCore::RenderLayerBacking::paintIntoLayer):

Add event region context parameter so we can use this function for event region update too.

rendering/RenderLayerBacking.h:

LayoutTests:

pointerevents/ios/touch-action-region-backing-sharing-expected.txt:
pointerevents/ios/touch-action-region-overflow-expected.txt:

10:44 AM Changeset in webkit [249535] by rniwa@webkit.org

8 edits
3 adds in trunk

REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
https://bugs.webkit.org/show_bug.cgi?id=201490

Reviewed by Daniel Bates.

Source/WebCore:

The bug was caused by an element in the pasted content not having any explicit font name resolving
to use the font-family value of -webkit-standard. When such an inline style is inserted into
Mail's WKWebView which sets a different font family, ReplaceSelectionCommand would fail to strip away,
making the pasted content using the default font family of Times New Roman.

Fixed the bug by stripping away font-family set to -webkit-standard in the sanitization document
since that's indicative of the pasted content not having any font family being specified.

In the future, we should consider making regular copy (as opposed to the copy for sanitization)
resolve generic font family names to concrete font names since different WKWebView might be using
different concrete font names. Unfortuantely, such a change is quite involved and risky since various
paste side code in EditingStyle that removes redundant inline styles (i.e. redundant font-family)
need to be aware of this special font family resolution.

Tests: editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family.html

PasteHTML.DoesNotAddStandardFontFamily

editing/EditingStyle.cpp:

(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::familyNameFromCSSPrimitiveValue): Added.
(WebCore::loneFontFamilyName): Extracted from usesForbiddenSystemFontAsOnlyFontFamilyName. Fixed
a bug that it was not handling the case when font-family property's value is a CSSPrimitiveValue
instead of a CSSValueList.
(WebCore::usesForbiddenSystemFontAsOnlyFontFamilyName): Deleted.
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization): Remove font-family property when
StandardFontFamilySerializationMode::Strip is specified and its value is -webkit-standard.

editing/EditingStyle.h:
editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::StyledMarkupAccumulator): Added
StandardFontFamilySerializationMode as an argument.
(WebCore::StyledMarkupAccumulator::appendStartTag):
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::serializePreservingVisualAppearanceInternal): Ditto.
(WebCore::serializePreservingVisualAppearance): Use StandardFontFamilySerializationMode::Keep
to preserve the pre-existing behavior.
(WebCore::sanitizedMarkupForFragmentInDocument): Use StandardFontFamilySerializationMode::Strip
as this is the code used by sanitization code.

Tools:

Added a test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.

LayoutTests:

Added a test to make sure -webkit-standard font family name isn't stripped away when sanitization is not in effect.

editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family-expected.txt: Added.
editing/pasteboard/paste-cocoa-writer-markup-with-webkit-standard-font-family.html: Added.

10:27 AM Changeset in webkit [249534] by Chris Fleizach

3 edits
2 adds in trunk

AX: children cache are not re-computed if tab index is removed
https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

accessibility/tabindex-removed-expected.txt: Added.
accessibility/tabindex-removed.html: Added.

10:11 AM Changeset in webkit [249533] by sihui_liu@apple.com

10 edits in trunk/Source/WebKit

Remove StorageArea pointers in StorageManagerSet when removing StorageManagers that own them
https://bugs.webkit.org/show_bug.cgi?id=201324

Reviewed by Alex Christensen.

NetworkProcess/WebStorage/LocalStorageNamespace.cpp:

(WebKit::LocalStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/LocalStorageNamespace.h:
NetworkProcess/WebStorage/SessionStorageNamespace.cpp:

(WebKit::SessionStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/SessionStorageNamespace.h:
NetworkProcess/WebStorage/StorageManager.cpp:

(WebKit::StorageManager::allStorageAreaIdentifiers const):

NetworkProcess/WebStorage/StorageManager.h:
NetworkProcess/WebStorage/StorageManagerSet.cpp:

(WebKit::StorageManagerSet::remove):

NetworkProcess/WebStorage/TransientLocalStorageNamespace.cpp:

(WebKit::TransientLocalStorageNamespace::storageAreaIdentifiers const):

NetworkProcess/WebStorage/TransientLocalStorageNamespace.h:

10:01 AM Changeset in webkit [249532] by Michael Catanzaro

1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed, update contributors.json

People are having trouble CCing me on Bugzilla.

I'm still at Igalia, but no longer working on WebKit.

Scripts/webkitpy/common/config/contributors.json:

9:56 AM Changeset in webkit [249531] by Konstantin Tokarev

3 edits in trunk/Source/WebCore

Don't call PlatformMediaSessionManager methods when neither VIDEO nor WEB_AUDIO is enabled
https://bugs.webkit.org/show_bug.cgi?id=201508

Reviewed by Jer Noble.

Definitions of these methods are guarded with #if ENABLE(VIDEO)

ENABLE(WEB_AUDIO),

so calling them causes linking errors.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldDeactivateAudioSession):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::processWillSuspend):
(WebCore::Internals::processDidResume):
(WebCore::Internals::setIsPlayingToAutomotiveHeadUnit):

8:51 AM Changeset in webkit [249530] by ysuzuki@apple.com

3 edits
1 add in trunk

[JSC] Do not use FTLOutput::weakPointer directly
https://bugs.webkit.org/show_bug.cgi?id=201495

Reviewed by Filip Pizlo.

JSTests:

stress/create-promise-weak-pointer.js: Added.

(foo):

Source/JavaScriptCore:

FTLOutput::weakPointer does not register the cell as a weak pointer.
CreatePromise's implementation is accidentally using m_out.weakPointer and hits the debug assertion.
While the current implementation is not posing correctness issue since these cells are live so long as JSGlobalObject is live,
and we register JSGlobalObject as a weakPointer, we should always use FTLLowerDFGToB3's helper function.
For FrozenValue, we should use frozenPointer helper function.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreatePromise):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):

7:48 AM Changeset in webkit [249529] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit

REGRESSION(r249275): [GTK][WPE] wrong page ID returned by webkit_web_view_get_page_id()
https://bugs.webkit.org/show_bug.cgi?id=201504

Reviewed by Michael Catanzaro.

We want to return the page identifier not the web page proxy id.

UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_get_page_id):

7:21 AM Changeset in webkit [249528] by Pablo Saavedra

2 edits in trunk/Source/WebKit

Build failure after r249501 for ports with SERVICE_WORKER set OFF
https://bugs.webkit.org/show_bug.cgi?id=201503

Reviewed by Youenn Fablet.

WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

3:53 AM Changeset in webkit [249527] by Keith Rollin

2 edits in trunk/Source/WebCore

Fix implicit conversion that loses precision
https://bugs.webkit.org/show_bug.cgi?id=201476
<rdar://problem/55043129>

Reviewed by Youenn Fablet, Alex Christensen.

Building for watchOS results in the following error:

.../Source/WebCore/fileapi/NetworkSendQueue.cpp:66:42: error: implicit conversion loses integer precision: 'unsigned long long' to 'unsigned int' [-Werror,-Wshorten-64-to-32]

enqueue(JSC::ArrayBuffer::create(byteLength, 1), 0, 0);

Fix this by replacing byteLength (which is known to be zero at this
point) with 0U.

No new tests -- no new or changed functionality.

fileapi/NetworkSendQueue.cpp:

(WebCore::NetworkSendQueue::enqueue):

2:01 AM Changeset in webkit [249526] by youenn@apple.com

17 edits
2 adds in trunk

Introduce WorkerSWClientConnection to make SWClientConnection mono-thread
https://bugs.webkit.org/show_bug.cgi?id=201430

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Remove inserted iframes to make test outputs more stable.

web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
web-platform-tests/service-workers/service-worker/activation.https.html:
web-platform-tests/service-workers/service-worker/detached-context.https-expected.txt:
web-platform-tests/service-workers/service-worker/detached-context.https.html:

Source/WebCore:

Make SWClientConnection RefCounted.
Add a WorkerSWClientConnection dedicated to be used by worker/service worker contexts.
Simplify ServiceWorkerContainer logic based on this refactoring.

Covered by existing tests.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::swClientConnection):

workers/WorkerGlobalScope.h:
workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::failedFetchingScript):
(WebCore::SWClientConnection::postTaskForJob):

workers/service/SWClientConnection.h:
workers/service/ServiceWorkerContainer.cpp:

(WebCore::mainThreadConnection):
(WebCore::ServiceWorkerContainer::ready):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::updateRegistrationState):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::notifyRegistrationIsSettled):
(WebCore::ServiceWorkerContainer::jobFinishedLoadingScript):
(WebCore::ServiceWorkerContainer::notifyFailedFetchingScript):
(WebCore::ServiceWorkerContainer::ensureSWClientConnection):
(WebCore::ServiceWorkerContainer::stop):

workers/service/ServiceWorkerContainer.h:
workers/service/ServiceWorkerFetchResult.h:

(WebCore::ServiceWorkerFetchResult::isolatedCopy const):

workers/service/WorkerSWClientConnection.cpp: Added.

(WebCore::WorkerSWClientConnection::WorkerSWClientConnection):
(WebCore::WorkerSWClientConnection::~WorkerSWClientConnection):
(WebCore::WorkerSWClientConnection::matchRegistration):
(WebCore::WorkerSWClientConnection::getRegistrations):
(WebCore::WorkerSWClientConnection::whenRegistrationReady):
(WebCore::WorkerSWClientConnection::addServiceWorkerRegistrationInServer):
(WebCore::WorkerSWClientConnection::removeServiceWorkerRegistrationInServer):
(WebCore::WorkerSWClientConnection::didResolveRegistrationPromise):
(WebCore::WorkerSWClientConnection::postMessageToServiceWorker):
(WebCore::WorkerSWClientConnection::serverConnectionIdentifier const):
(WebCore::WorkerSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
(WebCore::WorkerSWClientConnection::syncTerminateWorker):
(WebCore::WorkerSWClientConnection::registerServiceWorkerClient):
(WebCore::WorkerSWClientConnection::unregisterServiceWorkerClient):
(WebCore::WorkerSWClientConnection::finishFetchingScriptInServer):
(WebCore::WorkerSWClientConnection::isThrottleable const):
(WebCore::WorkerSWClientConnection::updateThrottleState):
(WebCore::WorkerSWClientConnection::scheduleJob):
(WebCore::WorkerSWClientConnection::scheduleJobInServer):

workers/service/WorkerSWClientConnection.h: Added.

12:47 AM Changeset in webkit [249525] by rniwa@webkit.org

2 edits
1 delete in trunk/Tools

Remove unused SPI that accesses MemoryCache directly
https://bugs.webkit.org/show_bug.cgi?id=201468

Reviewed by Youenn Fablet.

Removed the API test.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed