⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 26, 2020:

11:05 PM Changeset in webkit [262180] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

SMILTimeContainer must protect its m_scheduledAnimations while it does updateAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=212192
<rdar://problem/56717734>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-05-26
Reviewed by Youenn Fablet.

Source/WebCore:

updateAnimations() needs to protect m_scheduledAnimations while processing
the scheduled animations. m_scheduledAnimations may be changed from JavaScript
callbacks. This will invalidate the HashMap iterators while the one used
by the for-loop in updateAnimations() is still in use.

To allow copying m_scheduledAnimations, the value of the entry has to be
of type AnimationVector instead of std::unique_ptr<AnimationVector>.

Test: svg/animations/css-animation-reinsert-target.html

  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::schedule):
(WebCore::SMILTimeContainer::unschedule):
(WebCore::SMILTimeContainer::processScheduledAnimations):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SMILTimeContainer.h:

LayoutTests:

  • svg/animations/css-animation-reinsert-target-expected.txt: Added.
  • svg/animations/css-animation-reinsert-target.html: Added.
10:19 PM Changeset in webkit [262179] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

MacApplication::isSafari should allow safari bundle id variants
​https://bugs.webkit.org/show_bug.cgi?id=212401

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-26
Reviewed by Timothy Hatcher.

There is a test environment with bundle ID com.apple.Safari.something.
This change is blocking rdar://problem/63574451

  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::MacApplication::isSafari):

10:19 PM Changeset in webkit [262178] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

Unreviewed WPE build fix after r262155.

  • UIProcess/API/wpe/WebKitColor.cpp:

(webkit_color_parse): Use CSSParser::parseColor() to do the color parsing.

10:10 PM Changeset in webkit [262177] by Simon Fraser
  • 3 edits
    4 adds in trunk

Rendering artifacts when scrolling overlays
​https://bugs.webkit.org/show_bug.cgi?id=204120
<rdar://problem/57121358>

Reviewed by Zalan Bujtas.

Source/WebCore:

RenderLayerBacking::setContentsNeedDisplayInRect() needs to adjust repaint rects in the
scrolled contents layer by the RenderLayer's scrollOffset, because that's what's used
during repaint rect computation. We haven't yet pushed the new scroll offset onto the
GraphicsLayer, so m_scrolledContentsLayer->scrollOffset() would be stale here.

I tested RTL to make sure that scrollOffset(), and not scrollPosition() is the correct
function to tall.

Test: compositing/repaint/compositing-toggle-in-overflow-scroll-repaint.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

LayoutTests:

  • compositing/repaint/compositing-toggle-in-overflow-scroll-repaint-expected.txt: Added.
  • compositing/repaint/compositing-toggle-in-overflow-scroll-repaint.html: Added.
  • platform/ios-wk2/compositing/repaint/compositing-toggle-in-overflow-scroll-repaint-expected.txt: Added.
  • platform/mac-wk1/compositing/repaint/compositing-toggle-in-overflow-scroll-repaint-expected.txt: Added.
9:44 PM Changeset in webkit [262176] by mark.lam@apple.com
  • 11 edits in trunk/JSTests

JSC stress tests that require --useLLInt=0 should be skipped on --no-jit test runs.
​https://bugs.webkit.org/show_bug.cgi?id=212400

Reviewed by Saam Barati.

That's because using --useLLInt=0 and --useJIT=0 together is not a "coherent"
(read "valid") configuration. We should be able to do a --no-jit test run with
the JSC_useJIT=0 environmental variable set. Before this patch, the following
tests will all fail. This patch skips them.

  • stress/delete-property-poly-proto.js:
  • stress/dfg-compare-eq-via-nonSpeculativeNonPeepholeCompareNullOrUndefined.js:
  • stress/getter-setter-inlining-should-emit-movhint.js:
  • stress/merging-ic-variants-should-bail-if-structures-overlap.js:
  • stress/poly-proto-setter-adds-setter-in-middle.js:
  • stress/poly-proto-setter-changes-setter-2.js:
  • stress/poly-proto-setter-changes-setter.js:
  • stress/racy-gc-cleanup-of-identifier-after-mutator-stops-running.js:
  • stress/regress-192717.js:
  • stress/retry-cache-later.js:
9:01 PM Changeset in webkit [262175] by commit-queue@webkit.org
  • 9 edits
    4 adds in trunk

An SVG animated property animator can stop animation while other animators are still running
​https://bugs.webkit.org/show_bug.cgi?id=207417
<rdar://problem/59278306>

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2020-05-26
Reviewed by Simon Fraser.

Source/WebCore:

An SVG animated property can be animated by multiple animators. When one
animator stops the animation, the animVal should not be deleted since it
will be used by other animators.

SVGAnimatedProperty will maintain a WeakHashSet<SVGAttributeAnimator> in
which the animator will be added when the animation starts and will be
removed when the the animation stops. When all the animators stops their
animations, the animated property may delete the animVal or keep it if it
can be referenced by JavaScript.

Tests: svg/animations/animated-enum-mutiple-animators.svg

svg/animations/animated-length-mutiple-animators.svg

  • svg/properties/SVGAnimatedDecoratedProperty.h:
  • svg/properties/SVGAnimatedPrimitiveProperty.h:
  • svg/properties/SVGAnimatedProperty.h:

(WebCore::SVGAnimatedProperty::isAnimating const):
(WebCore::SVGAnimatedProperty::startAnimation):
(WebCore::SVGAnimatedProperty::stopAnimation):
(WebCore::SVGAnimatedProperty::instanceStartAnimation):
(WebCore::SVGAnimatedProperty::instanceStopAnimation):

  • svg/properties/SVGAnimatedPropertyAnimator.h:
  • svg/properties/SVGAnimatedPropertyList.h:
  • svg/properties/SVGAnimatedValueProperty.h:
  • svg/properties/SVGAttributeAnimator.h:

LayoutTests:

  • svg/animations/animated-enum-mutiple-animators-expected.txt: Added.
  • svg/animations/animated-enum-mutiple-animators.svg: Added.
  • svg/animations/animated-length-mutiple-animators-expected.txt: Added.
  • svg/animations/animated-length-mutiple-animators.svg: Added.
8:36 PM Changeset in webkit [262174] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (async oveflow): scrubber missing from inline video inside overflow scroll
​https://bugs.webkit.org/show_bug.cgi?id=212391
<rdar://problem/63089859>

Reviewed by Zalan Bujtas.

Source/WebCore:

backgroundClipRect() is in the coordinate space of the ClipRectContext's rootLayer, not the receiver,
so when converting to absolute coordinates we must use the ClipRectContext's rootLayer.

Test: compositing/layer-creation/overlap-in-scroller.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMap const):

LayoutTests:

  • compositing/layer-creation/overlap-in-scroller-expected.html: Added.
  • compositing/layer-creation/overlap-in-scroller.html: Added.
7:42 PM Changeset in webkit [262173] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌘G should not override the current query of the find banner if it's visible
​https://bugs.webkit.org/show_bug.cgi?id=212395

Reviewed by Simon Fraser.

  • UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.async handleFindNextShortcut):
(WI.ContentBrowser.prototype.async handleFindPreviousShortcut):

  • UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.highlightPreviousSearchMatch):
(WI.LogContentView.prototype.highlightNextSearchMatch):

7:09 PM Changeset in webkit [262172] by Fujii Hironori
  • 3 edits in trunk/Source/WebKit

[WinCairo] Unreviewed clang-cl build fix after r262158
​https://bugs.webkit.org/show_bug.cgi?id=211883

std::unique_ptr<WebCore::TextureMapper> can't delete an incomplete type TextureMapper.

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h:
6:48 PM Changeset in webkit [262171] by commit-queue@webkit.org
  • 7 edits in trunk

UTF-8 encode strings of invalid URLs when converting WTF::URL to NSURL instead of truncating the UTF-16 encoding
​https://bugs.webkit.org/show_bug.cgi?id=212393
<rdar://problem/63095503>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-26
Reviewed by Tim Horton.

Source/WTF:

This only changes behavior in code that is marked as UNLIKELY because it can only be reached by invalid unicode URLs,
but it can be reached and should behave in a reasonable manner in those cases. This makes Safari behave more similarly
to Firefox in this case instead of doing something similar to no other browser.

  • wtf/URL.cpp:

(WTF::copyASCII): Deleted.
(WTF::URL::copyToBuffer const): Deleted.

  • wtf/URL.h:
  • wtf/cf/URLCF.cpp:

(WTF::URL::createCFURL const):

  • wtf/cocoa/URLCocoa.mm:

(WTF::URL::createCFURL const):

Tools:

  • TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:

(TestWebKitAPI::TEST):

5:36 PM Changeset in webkit [262170] by yoshiaki.jitsukawa@sony.com
  • 3 edits
    1 add in trunk/Source/WTF

[PlayStation] Disable LLINT_EMBEDDED_OPCODE_ID
​https://bugs.webkit.org/show_bug.cgi?id=212387

Reviewed by Don Olmstead.

  • wtf/CMakeLists.txt:
  • wtf/PlatformEnable.h:
  • wtf/PlatformEnablePlayStation.h: Added.
5:21 PM Changeset in webkit [262169] by jer.noble@apple.com
  • 5 edits
    2 adds in trunk

Can't scrub video on ​https://www.judiciary.senate.gov
​https://bugs.webkit.org/show_bug.cgi?id=212270
<rdar://problem/57922919>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/embedded-content/media-elements/seeking/seek-to-negative-time-expected.txt:

Source/WebCore:

Test: media/video-duration-seekable.html

www.judiciary.senate.gov uses the Akamai Media Player, which doesn't query HTMLMediaElement.duration
directly. Rather, when it receives a "durationchange" event, it calculates the duration by using the
HTMLMediaElement.seekable ranges to determine the effective media duration. But no event is fired when
the seekable ranges change, and when they first query HTMLMediaElement.seekable, AVFoundation hasn't
yet updated seekable ranges, so we report an empty set of seekable ranges.

The HTML specification suggests that UAs "should adopt a very liberal and optimistic view of what is
seekable." With that advice in mind, when we are asked by the page for our seekable ranges, and we do
not yet have the official ranges from AVPlayerItem, lets just respond with [0, duration).

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable const):

LayoutTests:

  • media/video-duration-seekable-expected.txt: Added.
  • media/video-duration-seekable.html: Added.
4:37 PM Changeset in webkit [262168] by mark.lam@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Add some new emitters to the X86_64 and ARM64 MacroAssemblers.
​https://bugs.webkit.org/show_bug.cgi?id=212385

Reviewed by Robin Morisset.

This patch adds these MacroAssembler emitters:

clearBit64
clearBits64WithMask
countTrailingZeros64WithoutNullCheck

clearBit64 clears a bit.

clearBits64WithMask does the equivalent of and64 with the 1's complement of the
provided mask.

countTrailingZeros64WithoutNullCheck does the same thing as countTrailingZeros64,
except that it assumes that the word in the register it is processing will never
be null, and therefore skips the null check. This is useful in code generation
that already does a null check ahead of time. So, there's no need to do a
redundant null check.

Also added testmasm tests for these emitters.

  • assembler/AbortReason.h:
  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::clearBit64):
(JSC::MacroAssemblerARM64::clearBits64WithMask):
(JSC::MacroAssemblerARM64::countTrailingZeros64WithoutNullCheck):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::countTrailingZeros64WithoutNullCheck):
(JSC::MacroAssemblerX86_64::clearBit64):
(JSC::MacroAssemblerX86_64::clearBits64WithMask):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::btrq_rr):

  • assembler/testmasm.cpp:

(JSC::testClearBit64):
(JSC::testClearBits64WithMask):
(JSC::testClearBits64WithMaskTernary):
(JSC::testCountTrailingZeros64Impl):
(JSC::testCountTrailingZeros64):
(JSC::testCountTrailingZeros64WithoutNullCheck):
(JSC::run):

4:33 PM Changeset in webkit [262167] by mark.lam@apple.com
  • 4 edits in trunk

Enhance Bitmap::setEachNthBit() to also take an end index.
​https://bugs.webkit.org/show_bug.cgi?id=212386
<rdar://problem/63643324>

Reviewed by Robin Morisset.

Source/WTF:

Previously, it was only taking the n interval, and the start index.
Also fixed isEmpty() and isFull() to return a bool instead of size_t.

  • wtf/Bitmap.h:

(WTF::WordType>::isEmpty const):
(WTF::WordType>::isFull const):
(WTF::WordType>::setEachNthBit):

Tools:

  • TestWebKitAPI/Tests/WTF/Bitmap.cpp:

(TestWebKitAPI::testBitmapSetEachNthBitImpl):

3:43 PM Changeset in webkit [262166] by yoshiaki.jitsukawa@sony.com
  • 4 edits in trunk/Source/JavaScriptCore

[PlayStation] Enable RemoteWebInspector
​https://bugs.webkit.org/show_bug.cgi?id=212312

Reviewed by Don Olmstead.

  • API/JSRemoteInspectorServer.cpp:

Fix compile error.

  • PlatformPlayStation.cmake:

Add JSRemoteInspectorServer.h to the public header list.

  • inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

Set PlayStation specific socket option.

3:16 PM Changeset in webkit [262165] by Alexey Shvayka
  • 6 edits
    1 add in trunk

IteratorClose should suppress GetMethod errors
​https://bugs.webkit.org/show_bug.cgi?id=212378

Reviewed by Keith Miller.

JSTests:

  • stress/custom-iterators.js:
  • stress/iterator-return-abrupt-lookup-builtins.js: Added.
  • test262/expectations.yaml: Mark 4 test cases as passing.

Source/JavaScriptCore:

This patch implements recent spec change [1] that prevents "return" method lookup error
from overriding outer exception, aligning JSC with V8 and SpiderMonkey.

It is accomplished by moving pushTry() before emitGetById() in BytecodeGenerator.cpp
(covered by test262 suite) and removal of RETURN_IF_EXCEPTION in IteratorOperations.cpp
(added a stress test).

Before this patch, JSC partly implemented the spec change [1] by suppressing TypeError
if "return" method of iterator was not callable.

BytecodeGenerator::emitDelegateYield() is intentionally left unchanged.
Also, this patch utilizes emitIteratorGenericClose() to avoid code duplication.
for/of microbenchmarks are neutral.

[1]: ​https://github.com/tc39/ecma262/pull/1408

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitGenericEnumeration):
(JSC::BytecodeGenerator::emitEnumeration):

  • runtime/IteratorOperations.cpp:

(JSC::iteratorClose):

3:02 PM Changeset in webkit [262164] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

Regression(?): [ iOS wk2 ] http/tests/resourceLoadStatistics/cookie-deletion.html is flaky failing and crashing.
​https://bugs.webkit.org/show_bug.cgi?id=207197

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
2:56 PM Changeset in webkit [262163] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

[ iOS wk2 ] http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=207583

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
2:34 PM Changeset in webkit [262162] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network: Timing: gaps around the "An error occurred trying to load this resource" message
​https://bugs.webkit.org/show_bug.cgi?id=212384

Reviewed by Timothy Hatcher.

  • UserInterface/Views/NetworkTableContentView.css:

(.content-view.network-table > .message-text-view): Added.
(.content-view.network-table > .message-text-view > .message): Added.
(.content-view.network .message-text-view): Deleted.
(.content-view.network .message-text-view > .message): Deleted.
Be more specific with the selector so it doesn't apply as broadly.

2:32 PM Changeset in webkit [262161] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

SamplingProfiler::takeSample() should not assume that ENABLE(WEBASSEMBLY) means Wasm is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=212382

Reviewed by Saam Barati.

Wasm can still be disabled at runtime with JSC options. Fixing this will allow
sampling profiler tests to run with JSC_useJIT=0 without crashing.

  • runtime/SamplingProfiler.cpp:

(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::recordJITFrame):
(JSC::CFrameWalker::CFrameWalker):
(JSC::SamplingProfiler::takeSample):

1:38 PM Changeset in webkit [262160] by Kate Cheney
  • 2 edits in trunk/LayoutTests

REGRESSION: [ iOS wk2 Debug ] multiple fast/text/international/system-language tests are flaky crashing - WTFCrashWithInfo - WebKit::ResourceLoadStatisticsDatabaseStore::openAndUpdateSchemaIfNecessary()
​https://bugs.webkit.org/show_bug.cgi?id=211958
<rdar://problem/63275549>

Reviewed by Darin Adler.

Tests no longer crashing.

  • platform/ios-wk2/TestExpectations:
1:32 PM Changeset in webkit [262159] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit

Fix the engineering build on internal SDKs

  • Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Silenced a deprecation warning.

1:30 PM Changeset in webkit [262158] by Fujii Hironori
  • 15 edits
    2 adds in trunk

[WinCairo][WK2] Use GraphicsLayerTextureMapper for Accelerated Compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=211883

Reviewed by Don Olmstead.

.:

  • Source/cmake/OptionsWinCairo.cmake: Added a new build option

USE_GRAPHICS_LAYER_TEXTURE_MAPPER, and set ON as the default.

Source/WebKit:

GraphicsLayerTextureMapper is a simple GraphicsLayer
implementation using TextureMapper which is used for WinCairo WebKit1.

Add a new LayerTreeHost implementation for
GraphicsLayerTextureMapper by copying WinCairo WebKit1's
AcceleratedCompositingContext.

Windows WebKitTestRunner can't capture the window content for
pixel dump tests yet.

  • PlatformWin.cmake:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::WebView):

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::setNeedsDisplayInRect):
(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.cpp: Added.

(WebKit::LayerTreeHost::prepareForRendering):
(WebKit::LayerTreeHost::compositeLayersToContext):
(WebKit::LayerTreeHost::flushPendingLayerChanges):
(WebKit::LayerTreeHost::layerFlushTimerFired):
(WebKit::LayerTreeHost::LayerTreeHost):
(WebKit::LayerTreeHost::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHost::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHost::scheduleLayerFlush):
(WebKit::LayerTreeHost::cancelPendingLayerFlush):
(WebKit::LayerTreeHost::setRootCompositingLayer):
(WebKit::LayerTreeHost::setViewOverlayRootLayer):
(WebKit::LayerTreeHost::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHost::scrollNonCompositedContents):
(WebKit::LayerTreeHost::flushAndRenderLayers):
(WebKit::LayerTreeHost::forceRepaint):
(WebKit::LayerTreeHost::forceRepaintAsync):
(WebKit::LayerTreeHost::sizeDidChange):
(WebKit::LayerTreeHost::pauseRendering):
(WebKit::LayerTreeHost::resumeRendering):
(WebKit::LayerTreeHost::graphicsLayerFactory):
(WebKit::LayerTreeHost::contentsSizeChanged):
(WebKit::LayerTreeHost::didChangeViewportAttributes):
(WebKit::LayerTreeHost::setIsDiscardable):
(WebKit::LayerTreeHost::deviceOrPageScaleFactorChanged):
(WebKit::LayerTreeHost::createDisplayRefreshMonitor):
(WebKit::LayerTreeHost::window):
(WebKit::LayerTreeHost::enabled):
(WebKit::LayerTreeHost::paintContents):
(WebKit::LayerTreeHost::deviceScaleFactor const):
(WebKit::LayerTreeHost::applyDeviceScaleFactor):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeHostTextureMapper.h: Added.

(WebKit::LayerTreeHost::layerTreeContext const):
(WebKit::LayerTreeHost::displayID const):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::nativeWindowHandle):

  • WebProcess/win/WebProcessMainWin.cpp:

Tools:

  • MiniBrowser/win/WebKitBrowserWindow.cpp:

(WebKitBrowserWindow::setPreference): Call WKPreferencesSet* for
menu items IDM_ACC_COMPOSITING, IDM_COMPOSITING_BORDERS and
IDM_DEBUG_INFO_LAYER.

12:42 PM Changeset in webkit [262157] by Russell Epstein
  • 2 edits in branches/safari-609-branch/Source/WebCore

Revert "Cherry-pick r261961. rdar://problem/63626656"

This reverts commit r262150.

12:29 PM Changeset in webkit [262156] by don.olmstead@sony.com
  • 6 edits
    1 add in trunk

[CMake] Add static analyzers
​https://bugs.webkit.org/show_bug.cgi?id=212280

Reviewed by David Kilzer.

.:

Add support for static analyzers within CMake builds. Supported analyzers are
clang-tidy, iwyu (include-what-you-use) and lwyu (link-what-you-use). They can
be enabled by passing a semicolon separated list to CMake through the ANALYZERS
option.

  • Source/cmake/WebKitCommon.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/WebKitMacros.cmake:
  • Source/cmake/WebKitStaticAnalysis.cmake: Added.

Source/WTF:

Export headers from Plaform.h so include-what-you-use does not suggest they be
included directly. The headers being exported will #error when included outside of
Platform.h

  • wtf/Platform.h:
12:16 PM Changeset in webkit [262155] by Darin Adler
  • 14 edits in trunk/Source

Eliminate Color constructors that take strings, moving color parsing entirely into the CSS parser
​https://bugs.webkit.org/show_bug.cgi?id=212296

Reviewed by Sam Weinig.

Source/WebCore:

  • css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseColor): Moved more of the logic into
CSSParserFastPaths::parseSimpleColor. Also added a FIXME about what
seems to be a mistake about strict mode.
(WebCore::CSSParser::parseColorWorkerSafe): Ditto.
(WebCore::CSSParser::parseSystemColor): Removed unused context argument.
(WebCore::CSSParser::parseNamedColor): Added.
(WebCore::CSSParser::parseHexColor): Added.
(WebCore::CSSParser::parseSingleValue): Use auto.
(WebCore::CSSParser::parseValue): Ditto.

  • css/parser/CSSParser.h: Exported parseColor. Removed unused value pool

and strict arguments from parseColorWorkerSafe. Removed unused context
argument from parseSystemColor. Added parseNamedColor and parseHexColor.

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::parseSimpleLengthValue): Take a StringView.
(WebCore::finishParsingHexColor): Added, logic moved from Color constructor.
(WebCore::parseHexColorInternal): Ditto.
(WebCore::parseNumericColor): Added, logic moved from fastParseColorInternal.
(WebCore::parseColor): Turned into a non-member function since it's private
to this file. Use auto a bit more, and removed unneeded value pool argument.
(WebCore::finishParsingNamedColor): Added, logic moved from Color constructor.
(WebCore::parseNamedColorInternal): Ditto.
(WebCore::parseSimpleColorInternal): Ditto.
(WebCore::CSSParserFastPaths::parseSimpleColor): Ditto.
(WebCore::CSSParserFastPaths::parseHexColor): Ditto.
(WebCore::CSSParserFastPaths::parseNamedColor): Ditto.
(WebCore::isUniversalKeyword): Take a StringView.
(WebCore::parseKeywordValue): Ditto.
(WebCore::parseSimpleTransform): Ditto.
(WebCore::parseCaretColor): Ditto. Also take a parser context rather than
a parser mode.
(WebCore::CSSParserFastPaths::maybeParseValue): Take a StringView.

  • css/parser/CSSParserFastPaths.h: Cut down includes. Use StringView.

Added parseSimpleColor, parseHexColor, and parseNamedColor.

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseHexColor): Return an
Optional<SimpleColor> instead of a Color.
(WebCore::CSSPropertyParserHelpers::consumeColor): Refactor a bit for clarity.

  • html/HTMLElement.cpp:

(WebCore::parseLegacyColorValue): Renamed from parseColorStringWithCrazyLegacyRules
and refactored a bit. Made this match the HTML specification more closely.
(WebCore::HTMLElement::addHTMLColorToStyle): Simplify now that more of the logic
was moved into parseLegacyColorValue.

  • html/canvas/CanvasStyle.cpp:

(WebCore::parseColor): Removed unneeded arguments for parseColorWorkerSafe
and for parseSystemColor.

  • platform/graphics/Color.cpp:

(WebCore::findNamedColor): Deleted.
(WebCore::Color::Color): Deleted overloadds that take strings.

  • platform/graphics/Color.h: Updated for the above.
  • platform/graphics/SimpleColor.cpp:

(WebCore::parseHexColorInternal): Deleted.
(WebCore::SimpleColor::parseHexColor): Deleted.

  • platform/graphics/SimpleColor.h: Removed parseHexColor functions.

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetComposition): Use WebCore::CSSParser::parseColor.

12:12 PM Changeset in webkit [262154] by graouts@webkit.org
  • 12 edits
    2 adds in trunk

Hardware fill-forwards animation and transitions don't interact correctly
​https://bugs.webkit.org/show_bug.cgi?id=187839
<rdar://problem/42410412>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Mark a progression for a WPT test.

  • web-platform-tests/web-animations/interfaces/Animation/style-change-events-expected.txt:

Source/WebCore:

Test: webanimations/updating-property-targeted-by-css-transition-during-css-animation.html

We didn't follow the CSS Transitions spec closely enough when it came to defining the correct before and after
change styles during a style change event.

We now correctly set the before-change style as one of three possible values:

  1. if there are running CSS-originated animations, we ensure those are updated to the current time and resolve them to get the style,
  2. otherwise we use the RenderStyle recorded in Style::TreeResolver::createAnimatedElementUpdate() prior to applying animations during the last style change event,
  3. otherwise we use the previous computed style, which should not have any animated values.

As for the after-change style, we also need to ensure any running CSS Animations are update to the current time
and resolve them to get the style. Otherwise, we just use the current computed style prior to applying animations.

Finally, we can exit from AnimationTimeline::updateCSSTransitionsForElementAndProperty() early if we find that
we have a JS-originated animation running for the given property on the given element since we know that that
animation will yield an overriding value for both the before and after change styles since JS-originated animations
have the hightest composite order.

This means we no longer need to track the unanimated style on KeyframeEffect.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSAnimationsForElement):
(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
(WebCore::AnimationTimeline::updateCSSTransitionsForElement):

  • animation/AnimationTimeline.h:
  • animation/ElementAnimationRareData.h:

(WebCore::ElementAnimationRareData::lastStyleChangeEventStyle const):
(WebCore::ElementAnimationRareData::setLastStyleChangeEventStyle):

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::clearBlendingKeyframes):
(WebCore::KeyframeEffect::apply):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

  • animation/KeyframeEffect.h:

(WebCore::KeyframeEffect::unanimatedStyle const): Deleted.

  • dom/Element.cpp:

(WebCore::Element::lastStyleChangeEventStyle const):
(WebCore::Element::setLastStyleChangeEventStyle):

  • dom/Element.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

LayoutTests:

Add a new test that reproduces the issue shown by the original test case for this bug. While an animation is running
for a CSS property, we change the underlying value for that animated property which is also set as the transition-property
value. The correct behavior is to not start a CSS Transition either when changing the underlying value during the
CSS Animation nor at the end of the CSS Animation.

  • webanimations/updating-property-targeted-by-css-transition-during-css-animation-expected.txt: Added.
  • webanimations/updating-property-targeted-by-css-transition-during-css-animation.html: Added.
11:50 AM Changeset in webkit [262153] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, skip revoke-blob-url-after-navigation.html on Windows.

Windows port is lacking blob support.

  • platform/win/TestExpectations:
11:42 AM Changeset in webkit [262152] by Alan Coon
  • 1 copy in branches/safari-610.1.15-branch

New branch.

10:56 AM Changeset in webkit [262151] by weinig@apple.com
  • 7 edits in trunk

Extended Color Cleanup: Remove red()/green()/blue() accessors from ExtendedColor in preperation for supporting non-RGB based ColorSpaces
​https://bugs.webkit.org/show_bug.cgi?id=212366

Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/Color.cpp:

(WebCore::differenceSquared):
Switch to using toSRGBASimpleColorLossy() rather than poking at the ExtendedColor
components directly. The old code was already incorrect if the two colors had
differing color spaces so this at least now gives reasonable results.

(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
Delegate to ExtendedColor completely for colorWithAlpha() to allow for more
control over how the components might be stored in the future.

  • platform/graphics/Color.h:

(WebCore::Color::isBlackColor):
(WebCore::Color::isWhiteColor):
Delegate to ExtendedColor for isBlack()/isWhite() to allow per-color space
interpretations of the predicate.

(WebCore::Color::encode const):
(WebCore::Color::decode):
Use c1, c2, c3 rather than red/green/blue. This should be acceptable for the
forseeable future, as all expected colorspaces only have 3 channels, but at
some point, it may make sense to delegate coding to ExtendedColor completely.

  • platform/graphics/ExtendedColor.cpp:
  • platform/graphics/ExtendedColor.h:

(WebCore::ExtendedColor::channels const):
(WebCore::ExtendedColor::red const): Deleted.
(WebCore::ExtendedColor::green const): Deleted.
(WebCore::ExtendedColor::blue const): Deleted.
(WebCore::ExtendedColor::colorWithAlpha const): Added.
(WebCore::ExtendedColor::isWhite const): Added.
(WebCore::ExtendedColor::isBlack const): Added.
Use channels() with structured bindings rather than the red()/green()/blue() accessors
everywhere.

Tools:

  • TestWebKitAPI/Tests/WebCore/ExtendedColorTests.cpp:

(TestWebKitAPI::TEST):
Update tests to pull values from the channels rather than from the red()/green()/blue() accessors.

10:35 AM Changeset in webkit [262150] by Russell Epstein
  • 2 edits in branches/safari-609-branch/Source/WebCore

Cherry-pick r261961. rdar://problem/63626656

Potential crash in PointerCaptureController::cancelPointer()
​https://bugs.webkit.org/show_bug.cgi?id=208347
<rdar://problem/59866247>

Reviewed by David Kilzer and Daniel Bates.

  • page/PointerCaptureController.cpp: (WebCore::PointerCaptureController::cancelPointer):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@261961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:56 AM Changeset in webkit [262149] by Peng Liu
  • 7 edits in trunk

ASSERTION FAILED: m_clientCounts.contains(contextId) - WebKit::VideoFullscreenManagerProxy::removeClientForContext()
​https://bugs.webkit.org/show_bug.cgi?id=212308

Source/WebCore:

Reviewed by Jer Noble.

Call m_videoFullscreenModel->didExitPictureInPicture() after the video player
completes the process to exit Picture-in-Picture.

Covered by existing tests.

  • platform/ios/VideoFullscreenInterfaceAVKit.mm:

(VideoFullscreenInterfaceAVKit::cleanupFullscreen):
(VideoFullscreenInterfaceAVKit::didStopPictureInPicture):

Source/WebKit:

Refactor the implementation of the callback hasVideoInPictureInPictureDidChange().

Reviewed by Jer Noble.

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenModelContext::didEnterPictureInPicture):
(WebKit::VideoFullscreenModelContext::didExitPictureInPicture):

(WebKit::VideoFullscreenManagerProxy::hasVideoInPictureInPictureDidChange):
Add this function to wrap m_page->uiClient().hasVideoInPictureInPictureDidChange().

(WebKit::VideoFullscreenManagerProxy::setupFullscreenWithID):
Remove the call to hasVideoInPictureInPictureDidChange() because it is too early to do so.

(WebKit::VideoFullscreenManagerProxy::exitFullscreenWithoutAnimationToMode):
Add a call to hasVideoInPictureInPictureDidChange() on Mac as well. This fixes the timeout of
TestWebKitAPI.PictureInPicture.ExitPiPOnSuspendVideoElement on Mac.

(WebKit::VideoFullscreenManagerProxy::fullscreenModeChanged):
Remove the call to hasVideoInPictureInPictureDidChange() because it is not necessary.

Tools:

Disable TestWebKitAPI.PictureInPicture.ExitPiPOnSuspendVideoElement for old iOS versions
due to an issue of AVKit.

In addition, don't run the test if Picture-in-Picture is not supported.

Reviewed by Jer Noble.

  • TestWebKitAPI/Tests/WebKitCocoa/ExitPiPOnSuspendVideoElement.mm:

(TestWebKitAPI::TEST):

9:53 AM Changeset in webkit [262148] by Alan Bujtas
  • 3 edits
    2 adds in trunk

[LFC][TFC] Use padding to space out sections
​https://bugs.webkit.org/show_bug.cgi?id=212377

Reviewed by Antti Koivisto.

Source/WebCore:

Use fake padding before/after to space out sections.

Test: fast/layoutformattingcontext/table-simple-multiple-sections-with-border-spacing-and-collapse.html

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

LayoutTests:

  • fast/layoutformattingcontext/table-simple-multiple-sections-with-border-spacing-and-collapse-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-multiple-sections-with-border-spacing-and-collapse.html: Added.
9:17 AM Changeset in webkit [262147] by Keith Rollin
  • 25 edits in trunk

Enable the use of XCBuild by default in Apple builds
​https://bugs.webkit.org/show_bug.cgi?id=209890
<rdar://problem/44182078>

Reviewed by Darin Adler.

Switch from the "legacy" Xcode build system to the "new" build system
(also known as "XCBuild"). Switching to the new system speeds up
builds by a small percentage, better validates projects for
build-related issues (such as dependency cycles), lets WebKit benefit
from future improvements in XCBuild such as those coming from the
underlying llbuild open source project, and prepares us for any other
tools built for this new ecosystem.

Specific changes:

  • Remove Xcode project and workspace settings that selected the Build system, allowing the default to take hold (which is currently the New build system).
  • Updated webkitdirs.pm with a terser check for Xcode version.
  • Update build-webkit and Makefile.shared to be explicit when using the old build system (no longer treat it as a default or fall-back configuration).
  • Update various xcconfig files similarly to treat the default as using the new build system.
  • Update various post-processing build steps to check for Xcode 11.4 and to no longer treat the default as using the old build system.

.:

  • Makefile.shared:
  • WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings:

Source/JavaScriptCore:

  • Configurations/JavaScriptCore.xcconfig:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty/ANGLE:

  • ANGLE.xcodeproj/project.pbxproj:
  • Configurations/ANGLE.xcconfig:

Source/ThirdParty/libwebrtc:

  • libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

No new tests -- no changed functionality.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

  • Configurations/WebKit.xcconfig:
  • WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

  • Configurations/WebKitLegacy.xcconfig:

Tools:

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(canUseXCBuild):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9:17 AM Changeset in webkit [262146] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unskip fast/events/form-onchange.html after r262145.

  • platform/mac-wk1/TestExpectations:
9:15 AM Changeset in webkit [262145] by Chris Dumez
  • 1 edit
    6 deletes in trunk/LayoutTests

Unreviewed, drop a few beforeload event tests that no longer make sense after r261971.

We dropped support for the BeforeLoadEvent in r261971 so these tests do not make
sense anymore. Those tests also cause flakiness such as <rdar://63623324> now that
they no longer run as expected.

  • fast/events/form-iframe-target-before-load-crash-expected.txt: Removed.
  • fast/events/form-iframe-target-before-load-crash.html: Removed.
  • fast/events/form-iframe-target-before-load-crash2-expected.txt: Removed.
  • fast/events/form-iframe-target-before-load-crash2.html: Removed.
  • fast/events/form-iframe-target-before-load-crash3-expected.txt: Removed.
  • fast/events/form-iframe-target-before-load-crash3.html: Removed.
8:54 AM Changeset in webkit [262144] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[LFC][TFC] Add support for multiple sections
​https://bugs.webkit.org/show_bug.cgi?id=212354

Reviewed by Antti Koivisto.

Source/WebCore:

Let's keep the grid about rows and columns and about distributing available space.
Use the layout tree to find sections.

Test: fast/layoutformattingcontext/table-simple-multiple-sections.html

  • layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:

(WebCore::Layout::TableWrapperBlockFormattingContext::computeBorderAndPaddingForTableBox):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
(WebCore::Layout::TableFormattingContext::setUsedGeometryForSections):

  • layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::appendCell):
(WebCore::Layout::TableGrid::Section::Section): Deleted.

  • layout/tableformatting/TableGrid.h:

(WebCore::Layout::TableGrid::Section::box const): Deleted.
(WebCore::Layout::TableGrid::sections const): Deleted.
(WebCore::Layout::TableGrid::sections): Deleted.

LayoutTests:

  • fast/layoutformattingcontext/table-simple-multiple-sections-expected.html: Added.
  • fast/layoutformattingcontext/table-simple-multiple-sections.html: Added.
8:42 AM Changeset in webkit [262143] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: simctl list may have stderr logging
​https://bugs.webkit.org/show_bug.cgi?id=212376
<rdar://problem/63517635>

Unreviewed infrastructure fix.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager.populate_available_devices): Only parse stdout, log error when
json decoding fails.
(SimulatedDevice.is_usable): Only parse stdout.
(SimulatedDevice.launch_app): Ditto.

7:46 AM Changeset in webkit [262142] by Jason_Lawrence
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac wk1 ] fast/events/form-onchange.html is flaky failing.
​https://bugs.webkit.org/show_bug.cgi?id=212375

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
3:43 AM Changeset in webkit [262141] by Diego Pino Garcia
  • 4 edits
    2 adds in trunk/LayoutTests

[WPE] Gardening, update pending baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212370

Unrevewed gardening.

  • platform/wpe/fast/borders/fieldsetBorderRadius-expected.txt: Added.
  • platform/wpe/fast/html/details-marker-style-mixed-expected.txt: Added.
  • platform/wpe/mathml/presentation/roots-expected.txt:
  • platform/wpe/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/wpe/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
3:23 AM Changeset in webkit [262140] by Diego Pino Garcia
  • 2 edits
    1 move
    1 add in trunk/LayoutTests

[GTK] Gardening, update pending baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212369

Unreviewed gardening.

  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.png:
  • platform/gtk/fast/borders/fieldsetBorderRadius-expected.txt: Added.
  • platform/gtk/fast/html/details-marker-style-mixed-expected.txt: Renamed from LayoutTests/platform/glib/fast/html/details-marker-style-mixed-expected.txt.
2:46 AM WPTExportProcess edited by clopez@igalia.com
(diff)
1:46 AM Changeset in webkit [262139] by clopez@igalia.com
  • 6 edits in trunk/LayoutTests

[css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails
​https://bugs.webkit.org/show_bug.cgi?id=212054

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Update the test to use the Ahem font, and rely on different font colors (instead of different glyps)
to check that each box of the test is placed correctly.

  • web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html:
  • web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html:

LayoutTests:

Remove expectations for passing test.

1:29 AM WPTExportProcess edited by clopez@igalia.com
(diff)
1:01 AM Changeset in webkit [262138] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK4] Use screen font options as default
​https://bugs.webkit.org/show_bug.cgi?id=212332

Reviewed by Adrian Perez de Castro.

There's no gdk_screen_get_font_options() in GTK4, so we need to get the individual properties from the settings
and build a cairo_font_options_t. We can just do the same in GTK3 to avoid ifdefs. Add a helper
SystemFontOptions singleton class to monitor and parse the font settings.

  • platform/graphics/gtk/GdkCairoUtilities.cpp:

(WebCore::SystemFontOptions::singleton):
(WebCore::SystemFontOptions::SystemFontOptions):
(WebCore::SystemFontOptions::fontOptions const):
(WebCore::SystemFontOptions::updateFontOptions):
(WebCore::getDefaultCairoFontOptions):

12:59 AM Changeset in webkit [262137] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit

[GTK4] Fix context menu
​https://bugs.webkit.org/show_bug.cgi?id=212344

Reviewed by Adrian Perez de Castro.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSizeAllocate): Call gtk_native_check_resize() on the popover to make it appear.

  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::destroyMenuWidget): There's no gtk_widget_destroy() in GTK4 so we can just unparent it.
(WebKit::bindModelToMenuWidget): Do not set the action namespace because that's not possible in GTK4.
(WebKit::WebContextMenuProxyGtk::append): Use group.name again for the action name passed to
g_menu_item_set_action_and_target_value().
(WebKit::WebContextMenuProxyGtk::~WebContextMenuProxyGtk): Use destroyMenuWidget().

May 25, 2020:

9:48 PM Changeset in webkit [262136] by Wenson Hsieh
  • 2 edits in trunk/Tools

[iOS] ActionSheetTests.DataDetectorsLinkIsNotPresentedAsALink is failing consistently
​https://bugs.webkit.org/show_bug.cgi?id=212363
<rdar://problem/63508866>

Reviewed by Tim Horton.

This test began to consistently throw an exception after <​https://trac.webkit.org/r261157>, due to how
UserInterfaceSwizzler always instantiates the shared UIApplication. This apparently causes -[WKContentView
resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets:] to return nil instead of a replica view. As a
result, we crash under createFallbackTargetedPreview as we're attempting to assemble a targeted preview for
the context menu interaction.

Since this seems to only affect this particular API test, work around it by swizzling out
-resizableSnapshotViewFromRect:afterScreenUpdates:withCapInsets: in this API test to return a non-null UIView.

  • TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(TestWebKitAPI::swizzledResizableSnapshotViewFromRect):
(TestWebKitAPI::TEST):

8:44 PM Changeset in webkit [262135] by Diego Pino Garcia
  • 11 edits in trunk/LayoutTests

[WPE] Gardening, update baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212365

Unreviewed gardening.

  • platform/wpe/fast/html/details-no-summary4-expected.txt:
  • platform/wpe/fast/html/details-open-javascript-expected.txt:
  • platform/wpe/fast/html/details-open2-expected.txt:
  • platform/wpe/fast/html/details-open4-expected.txt:
  • platform/wpe/fast/html/details-replace-summary-child-expected.txt:
  • platform/wpe/fast/html/details-replace-text-expected.txt:
  • platform/wpe/fast/html/details-writing-mode-expected.txt:
  • platform/wpe/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/wpe/fast/writing-mode/fieldsets-expected.txt:
  • platform/wpe/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
8:30 PM Changeset in webkit [262134] by Diego Pino Garcia
  • 70 edits in trunk/LayoutTests

[GTK] Gardening, update baselines after r262127
​https://bugs.webkit.org/show_bug.cgi?id=212364

Unreviewed gardening.

  • platform/glib/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/glib/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/glib/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/glib/fast/css-generated-content/details-summary-before-after-expected.txt:
  • platform/glib/fast/html/details-add-child-1-expected.txt:
  • platform/glib/fast/html/details-add-child-2-expected.txt:
  • platform/glib/fast/html/details-add-details-child-1-expected.txt:
  • platform/glib/fast/html/details-add-details-child-2-expected.txt:
  • platform/glib/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-1-expected.txt:
  • platform/glib/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-10-expected.txt:
  • platform/glib/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-2-expected.txt:
  • platform/glib/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-3-expected.txt:
  • platform/glib/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-4-expected.txt:
  • platform/glib/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-5-expected.txt:
  • platform/glib/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-6-expected.txt:
  • platform/glib/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-7-expected.txt:
  • platform/glib/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-8-expected.txt:
  • platform/glib/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/glib/fast/html/details-add-summary-9-expected.txt:
  • platform/glib/fast/html/details-add-summary-child-1-expected.txt:
  • platform/glib/fast/html/details-add-summary-child-2-expected.txt:
  • platform/glib/fast/html/details-marker-style-expected.txt:
  • platform/glib/fast/html/details-nested-1-expected.txt:
  • platform/glib/fast/html/details-nested-2-expected.txt:
  • platform/glib/fast/html/details-no-summary1-expected.txt:
  • platform/glib/fast/html/details-no-summary2-expected.txt:
  • platform/glib/fast/html/details-no-summary3-expected.txt:
  • platform/glib/fast/html/details-open1-expected.txt:
  • platform/glib/fast/html/details-open3-expected.txt:
  • platform/glib/fast/html/details-open5-expected.txt:
  • platform/glib/fast/html/details-open6-expected.txt:
  • platform/glib/fast/html/details-position-expected.txt:
  • platform/glib/fast/html/details-remove-child-1-expected.txt:
  • platform/glib/fast/html/details-remove-child-2-expected.txt:
  • platform/glib/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-1-expected.txt:
  • platform/glib/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-2-expected.txt:
  • platform/glib/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-3-expected.txt:
  • platform/glib/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-4-expected.txt:
  • platform/glib/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-5-expected.txt:
  • platform/glib/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/glib/fast/html/details-remove-summary-6-expected.txt:
  • platform/glib/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/glib/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/glib/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/glib/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/gtk/fast/html/details-no-summary4-expected.txt:
  • platform/gtk/fast/html/details-open-javascript-expected.txt:
  • platform/gtk/fast/html/details-open2-expected.txt:
  • platform/gtk/fast/html/details-open4-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-expected.txt:
  • platform/gtk/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/gtk/fast/writing-mode/fieldsets-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
5:27 PM Changeset in webkit [262133] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Use an Optional<> for LayerFragment::boundingBox
​https://bugs.webkit.org/show_bug.cgi?id=212358

Reviewed by Zalan Bujtas.

Replace a bool + LayoutRect with Optional<LayoutRect>.

  • rendering/LayerFragment.h:

(WebCore::LayerFragment::setRects):
(WebCore::LayerFragment::moveBy):
(WebCore::LayerFragment::intersect):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::updatePaintingInfoForFragments):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
5:26 PM Changeset in webkit [262132] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Make isTableRow() an inline function
​https://bugs.webkit.org/show_bug.cgi?id=212360

Reviewed by Darin Adler.

isTableCell() is a virtual function that's called in some hot code paths, like RenderLayer::localBoundingBox(),
so make it inline by using a spare bit on RenderObject.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isTableCaption const):
(WebCore::RenderObject::isTableRow const):
(WebCore::RenderObject::setIsTableRow):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::RenderTableRow):

  • rendering/RenderTableRow.h:
5:03 PM Changeset in webkit [262131] by commit-queue@webkit.org
  • 7 edits in trunk/Source

Expose more network metrics to WebCoreNSURLSession
​https://bugs.webkit.org/show_bug.cgi?id=212359
<rdar://problem/62909440>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-25
Reviewed by Darin Adler.

Source/WebCore:

  • platform/network/NetworkLoadMetrics.h:

(WebCore::NetworkLoadMetrics::isolatedCopy const):
(WebCore::NetworkLoadMetrics::operator== const):
(WebCore::NetworkLoadMetrics::encode const):
(WebCore::NetworkLoadMetrics::decode):

  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionTaskTransactionMetrics networkProtocolName]):
(-[WebCoreNSURLSessionTaskTransactionMetrics isReusedConnection]):
(-[WebCoreNSURLSessionTaskTransactionMetrics cellular]):
(-[WebCoreNSURLSessionTaskTransactionMetrics expensive]):
(-[WebCoreNSURLSessionTaskTransactionMetrics constrained]):
(-[WebCoreNSURLSessionTaskTransactionMetrics multipath]):

Source/WebKit:

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

Source/WTF:

  • wtf/PlatformHave.h:
1:51 PM WPTExportProcess edited by clopez@igalia.com
(diff)
1:39 PM Changeset in webkit [262130] by Oriol Brufau
  • 10 edits in trunk

[css-grid] Prevent grid-template-rows from serializing adjacent <line-names>
​https://bugs.webkit.org/show_bug.cgi?id=212345

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Update test expectations.

  • web-platform-tests/css/css-grid/parsing/grid-shorthand-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-shorthand-valid-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-expected.txt:
  • web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid-expected.txt:

Source/WebCore:

The parser for the grid-template shorthand has this code:

Persists between loop iterations so we can use the same value for
 consecutive <line-names> values
RefPtr<CSSGridLineNamesValue> lineNames;

However, this wasn't working because of a lineNames.releaseNonNull() at
the end of the loop. So each iteration started with a null lineNames, and
consecutive <line-names> values were not merged together.

Tests: fast/css-grid-layout/grid-template-shorthand-get-set.html

imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-shorthand-valid.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand.html
imported/w3c/web-platform-tests/css/css-grid/parsing/grid-template-shorthand-valid.html

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridTemplateRowsAndAreasAndColumns):

LayoutTests:

Update test expectations.

  • fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-template-shorthand-get-set.html:
1:35 PM WPTExportProcess created by clopez@igalia.com
12:25 PM Changeset in webkit [262129] by weinig@apple.com
  • 3 edits in trunk/Source/WebCore

Extended Color Cleanup: Assert !isExtended() in Color::asSimpleColor()...finally
​https://bugs.webkit.org/show_bug.cgi?id=212357

Reviewed by Simon Fraser.

Reap the reward of the cleanup, and add the ASSERT(!isExtended()) to Color::asSimpleColor()
as was the original goal of this effort. Only tree non-checked places remained and were
trivial to add isExtended() checks for.

  • platform/graphics/Color.cpp:

(WebCore::Color::nameForRenderTreeAsText const):
Use ExtenedColor::cssText() for the RenderTree representation. It is stable
and as good as any, no need to re-invent the wheel here.

(WebCore::Color::light const):
(WebCore::Color::dark const):
Add isExtended() checks before doing white/black checks,

  • platform/graphics/Color.h:

(WebCore::Color::asSimpleColor const):
Add ASSERT.

11:30 AM Changeset in webkit [262128] by weinig@apple.com
  • 34 edits in trunk

Extended Color Cleanup: Use the name SimpleColor consistently
​https://bugs.webkit.org/show_bug.cgi?id=212337

Reviewed by Anders Carlsson.
Source/WebCore:


  • Removes RGBA32 type alias, updating all remaining users of it.
  • Renames functions that take/return SimpleColor to use the name SimpleColor rather than RGB (e.g. makeRGBA -> makeSimpleColor)
  • Moves hex color parsing from Color to SimpleColor, as that is the type it returns. Also took the opportunity to make it return an Optional<SimpleColor> instead of using a bool/out parameter.
  • Move Color::compositionFill to editing/CompositionHighlight.h It makes no real sense to keep it in Color.h
  • Replaces rgb() function in Color with asSimpleColor() for symmetry with asExtended().
  • Replaced std::max(a, std::min(value, b)) with std::clamp(value, a, b) for clarity.
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::fastParseColorInternal):
(WebCore::CSSParserFastPaths::parseColor):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseHexColor):

  • editing/CompositionHighlight.h:
  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

  • html/ColorInputType.cpp:

(WebCore::parseSimpleColorValue):

  • html/HTMLElement.cpp:

(WebCore::parseColorStringWithCrazyLegacyRules):

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:
  • platform/adwaita/ThemeAdwaita.cpp:

(WebCore::ThemeAdwaita::activeSelectionForegroundColor const):
(WebCore::ThemeAdwaita::activeSelectionBackgroundColor const):
(WebCore::ThemeAdwaita::inactiveSelectionForegroundColor const):

  • platform/graphics/Color.cpp:

(WebCore::differenceSquared):
(WebCore::Color::Color):
(WebCore::Color::operator=):
(WebCore::Color::serialized const):
(WebCore::Color::cssText const):
(WebCore::Color::nameForRenderTreeAsText const):
(WebCore::Color::light const):
(WebCore::Color::dark const):
(WebCore::Color::blend const):
(WebCore::Color::blendWithWhite const):
(WebCore::Color::colorWithAlpha const):
(WebCore::Color::colorWithAlphaUsingAlternativeRounding const):
(WebCore::Color::invertedColorWithAlpha const):
(WebCore::Color::colorSpaceAndComponents const):
(WebCore::Color::toSRGBASimpleColorLossy const):
(WebCore::blend):
(WebCore::Color::tagAsValid):
(WebCore::parseHexColorInternal): Deleted.
(WebCore::Color::parseHexColor): Deleted.
(WebCore::Color::asExtended const): Deleted.

  • platform/graphics/Color.h:

(WebCore::Color::Color):
(WebCore::Color::isHashTableDeletedValue const):
(WebCore::Color::isValid const):
(WebCore::Color::isOpaque const):
(WebCore::Color::isVisible const):
(WebCore::Color::alpha const):
(WebCore::Color::alphaAsFloat const):
(WebCore::Color::isSemantic const):
(WebCore::Color::isExtended const):
(WebCore::Color::setIsSemantic):
(WebCore::operator==):
(WebCore::equalIgnoringSemanticColor):
(WebCore::Color::hash const):
(WebCore::Color::asExtended const):
(WebCore::Color::asSimpleColor const):
(WebCore::Color::setSimpleColor):
(WebCore::Color::isBlackColor):
(WebCore::Color::isWhiteColor):
(WebCore::Color::encode const):
(WebCore::Color::decode):
(WebCore::Color::setRGB): Deleted.
(WebCore::Color::rgb const): Deleted.

  • platform/graphics/ColorUtilities.h:

(WebCore::clampedColorComponent):

  • platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::blendPixel):
(WebCore::ImageBackingStore::pixelValue const):

  • platform/graphics/SimpleColor.cpp:

(WebCore::makePremultipliedSimpleColor):
(WebCore::makeUnpremultipliedSimpleColor):
(WebCore::makeSimpleColorFromFloats):
(WebCore::makeSimpleColorFromHSLA):
(WebCore::makeSimpleColorFromCMYKA):
(WebCore::parseHexColorInternal):
(WebCore::SimpleColor::parseHexColor):
(WebCore::makePremultipliedRGBA): Deleted.
(WebCore::makeUnPremultipliedRGBA): Deleted.
(WebCore::makeRGBA32FromFloats): Deleted.
(WebCore::makeRGBAFromHSLA): Deleted.
(WebCore::makeRGBAFromCMYKA): Deleted.

  • platform/graphics/SimpleColor.h:

(WebCore::roundAndClampColorChannel):
(WebCore::colorFloatToSimpleColorByte):
(WebCore::makeSimpleColor):
(WebCore::colorFloatToRGBAByte): Deleted.
(WebCore::makeRGB): Deleted.
(WebCore::makeRGBA): Deleted.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::makeSimpleColorFromARGBCFArray):
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes):
(WebCore::makeRGBA32FromARGBCFArray): Deleted.

  • platform/graphics/cairo/ImageBufferCairoImageSurfaceBackend.cpp:

(WebCore::ImageBufferCairoImageSurfaceBackend::platformTransformColorSpace):

  • platform/graphics/cairo/NativeImageCairo.cpp:

(WebCore::nativeImageSinglePixelSolidColor):

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::makeSimpleColorFromCGColor):
(WebCore::Color::Color):
(WebCore::cachedCGColor):
(WebCore::makeRGBAFromCGColor): Deleted.

  • platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::Color):

  • platform/graphics/mac/ColorMac.mm:

(WebCore::makeSimpleColorFromNSColor):
(WebCore::colorFromNSColor):
(WebCore::semanticColorFromNSColor):
(WebCore::makeRGBAFromNSColor): Deleted.

  • platform/graphics/win/ColorDirect2D.cpp:

(WebCore::Color::Color):

  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):

  • platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::brushWithColor):

  • platform/ios/ColorIOS.mm:

(WebCore::colorFromUIColor):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionBackground):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintResizer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::patternForTouchAction):
(WebCore::patternForEventListenerRegionType):

  • rendering/RenderThemeAdwaita.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::menuBackgroundColor):

Source/WebKit:

  • UIProcess/ios/WKContentViewInteraction.mm:

(compositionHighlights):
Update for new name of CompositionHighlight::defaultCompositionFillColor.

Tools:

  • TestWebKitAPI/Tests/WebCore/ColorTests.cpp:

(TestWebKitAPI::TEST):
Update test for rename of makeRGBAFromHSLA to makeSimpleColorFromHSLA.

9:41 AM Changeset in webkit [262127] by Alan Bujtas
  • 230 edits
    1 copy
    3 adds in trunk

[Subpixel layout] Bad scrolling on mercurynews.com article
​https://bugs.webkit.org/show_bug.cgi?id=201038
<rdar://problem/28489812>

Reviewed by Dean Jackson.

Source/WebCore:

The scrolling is caused by the mismatching subpixel handling between block and inline content.
Inline content (and in this particular case ascent/descent handling) is still integral based while block content supports fractional pixel values.
When the (inline)line height relies on the (block)inline-block height, we need to make sure that the computed line height encloses the inline-block.
This patch changes the rounding behavior of computed the line height from floor to round.

Test: fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::baselinePosition const):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox const):

LayoutTests:

  • fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not-expected.html: Added.
  • fast/inline/hidpi-inline-block-is-subpixel-while-line-is-not.html: Added.
  • platform/ios/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/ios/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/ios/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/ios/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/ios/fast/borders/fieldsetBorderRadius-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/fieldsetBorderRadius-expected.txt.
  • platform/ios/fast/forms/select-item-background-clip-expected.txt:
  • platform/ios/fast/gradients/list-item-gradient-expected.txt:
  • platform/ios/fast/html/details-add-child-1-expected.txt:
  • platform/ios/fast/html/details-add-child-2-expected.txt:
  • platform/ios/fast/html/details-add-details-child-1-expected.txt:
  • platform/ios/fast/html/details-add-details-child-2-expected.txt:
  • platform/ios/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-1-expected.txt:
  • platform/ios/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-10-expected.txt:
  • platform/ios/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-2-expected.txt:
  • platform/ios/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-3-expected.txt:
  • platform/ios/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-4-expected.txt:
  • platform/ios/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-5-expected.txt:
  • platform/ios/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-6-expected.txt:
  • platform/ios/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-7-expected.txt:
  • platform/ios/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-8-expected.txt:
  • platform/ios/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/ios/fast/html/details-add-summary-9-expected.txt:
  • platform/ios/fast/html/details-add-summary-child-1-expected.txt:
  • platform/ios/fast/html/details-add-summary-child-2-expected.txt:
  • platform/ios/fast/html/details-marker-style-expected.txt:
  • platform/ios/fast/html/details-marker-style-mixed-expected.txt:
  • platform/ios/fast/html/details-nested-1-expected.txt:
  • platform/ios/fast/html/details-nested-2-expected.txt:
  • platform/ios/fast/html/details-no-summary1-expected.txt:
  • platform/ios/fast/html/details-no-summary2-expected.txt:
  • platform/ios/fast/html/details-no-summary3-expected.txt:
  • platform/ios/fast/html/details-no-summary4-expected.txt:
  • platform/ios/fast/html/details-open-javascript-expected.txt:
  • platform/ios/fast/html/details-open1-expected.txt:
  • platform/ios/fast/html/details-open2-expected.txt:
  • platform/ios/fast/html/details-open3-expected.txt:
  • platform/ios/fast/html/details-open4-expected.txt:
  • platform/ios/fast/html/details-open5-expected.txt:
  • platform/ios/fast/html/details-open6-expected.txt:
  • platform/ios/fast/html/details-position-expected.txt:
  • platform/ios/fast/html/details-remove-child-1-expected.txt:
  • platform/ios/fast/html/details-remove-child-2-expected.txt:
  • platform/ios/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-1-expected.txt:
  • platform/ios/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-2-expected.txt:
  • platform/ios/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-3-expected.txt:
  • platform/ios/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-4-expected.txt:
  • platform/ios/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-5-expected.txt:
  • platform/ios/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/ios/fast/html/details-remove-summary-6-expected.txt:
  • platform/ios/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/ios/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/ios/fast/html/details-replace-summary-child-expected.txt:
  • platform/ios/fast/html/details-replace-text-expected.txt:
  • platform/ios/fast/html/details-writing-mode-expected.txt:
  • platform/ios/fast/html/details-writing-mode-mixed-expected.txt:
  • platform/ios/fast/writing-mode/fieldsets-expected.txt:
  • platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/ios/mathml/presentation/mo-stretch-expected.txt:
  • platform/ios/mathml/presentation/roots-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/html/details-add-child-1-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-marker-style-expected.txt:
  • platform/mac/fast/html/details-nested-1-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.txt:
  • platform/mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
9:03 AM Changeset in webkit [262126] by Diego Pino Garcia
  • 5 edits
    1 move
    1 delete in trunk/LayoutTests

[WPE] Gardening, update test expectations after r262120
​https://bugs.webkit.org/show_bug.cgi?id=212353

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/glib/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt: Renamed from LayoutTests/platform/gtk/fast/canvas/webgl/webgl-compressed-texture-astc-expected.txt.
  • platform/gtk/TestExpectations:
  • platform/gtk/fast/canvas/webgl/readPixels-float-expected.txt: Removed.
  • platform/wpe/TestExpectations:
  • platform/wpe/fast/dom/navigator-detached-no-crash-expected.txt: Emit baseline after r260075.
7:47 AM Changeset in webkit [262125] by commit-queue@webkit.org
  • 4 edits in trunk

Use child text content when determining whether to bail early in running a script
​https://bugs.webkit.org/show_bug.cgi?id=182695

Patch by Rob Buis <​rbuis@igalia.com> on 2020-05-25
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

  • web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements-expected.txt:

Source/WebCore:

Check that the text content is not empty instead of just checking
for the first child [1].

Behavior matches Chrome and Firefox.

[1] ​https://html.spec.whatwg.org/#prepare-a-script step 5 and 6

Test: web-platform-tests/html/semantics/scripting-1/the-script-element/emptyish-script-elements.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::prepareScript):

7:18 AM Changeset in webkit [262124] by svillar@igalia.com
  • 7 edits in trunk

[css-flex] Allow indefinite size flex items to be definite wrt resolving percentages inside them
​https://bugs.webkit.org/show_bug.cgi?id=212264

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-flexbox/percentage-heights-003-expected.txt: There were 3 subtests

marked as failures. All of them work fine now.

Source/WebCore:

Implement ​https://github.com/w3c/csswg-drafts/commit/5b5db39d21f3658ae2f4d7992daaf822aca178d8 which modified
the way percentages were resolved in flexible items with indefinite sizes. From now on we can pretend that
they're really definite.

This allows us to mark 3 tests which were testing percentages in flex items as correct.

Based on Blink's crrev.com/1247184 by <​cbiesinger@chromium.org>

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution): Do only check flex container main size
definiteness when computing the main size for percentage resolution, no need to check flex basis at all.

LayoutTests:

  • css3/flexbox/definite-main-size-expected.txt: Updated expectation.
  • css3/flexbox/definite-main-size.html: Updated comment.
6:58 AM Changeset in webkit [262123] by Diego Pino Garcia
  • 3 edits in trunk/LayoutTests

[GTK] Gardening, update test expectations after r262060
​https://bugs.webkit.org/show_bug.cgi?id=212346

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/TestExpectations:
6:34 AM Changeset in webkit [262122] by youenn@apple.com
  • 3 edits in trunk/Source/WebCore

AVVideoCaptureSource should notify of video samples in a background thread
​https://bugs.webkit.org/show_bug.cgi?id=212072

Reviewed by Eric Carlson.

Do not hop to the main thread to send samples.
Instead, directly call the observer callback.
Manually tested.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::captureOutputDidOutputSampleBufferFromConnection):

4:58 AM Changeset in webkit [262121] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak][GStreamer] compilation fails when GST_BUILD_PATH is defined
​https://bugs.webkit.org/show_bug.cgi?id=212343

Patch by Víctor Manuel Jáquez Leal <​vjaquez@igalia.com> on 2020-05-25
Reviewed by Philippe Normand.

Flatpak's command has to be expressed before gst-env declaration.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

4:31 AM Changeset in webkit [262120] by Adrian Perez de Castro
  • 3 edits in trunk/Source/WebCore

Non-unified build fixes, late May 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=212342

Unreviewed build fix.

No new tests needed.

  • loader/ImageLoader.h: Add missing inclusion of Element.h and remove forward declaration.
  • page/PageConfiguration.h: Add missing inclusion of ShouldRelaxThirdPartyCookieBlocking.h
3:10 AM Changeset in webkit [262119] by Adrian Perez de Castro
  • 4 edits in trunk

[WPE][WKTR] Fix typo in EventSenderProxyWPE
​https://bugs.webkit.org/show_bug.cgi?id=212340

Reviewed by Carlos Garcia Campos.

Tools:

  • WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:

(WTR::wpeKeySymForKeyRef): Fix typo rightArror -> rightArrow.

LayoutTests:

  • platform/wpe/TestExpectations: fast/events/keydown-numpad-keys.html is now passing.
1:37 AM Changeset in webkit [262118] by Diego Pino Garcia
  • 2 edits
    4 adds in trunk/LayoutTests

[GTK][WPE] Gardening, emit baselines for update-the-source-set.html after r261929.
​https://bugs.webkit.org/show_bug.cgi?id=212216

Unreviewed gardening.

  • platform/glib/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt: Added.
1:33 AM Changeset in webkit [262117] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

REGRESSION(r262057): [Flatpak SDK] sccache-dist server no longer starting
​https://bugs.webkit.org/show_bug.cgi?id=212326

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

A few mount points were missing in the sandbox created by
flatpak run preventing the sccache-dist server to start and keep running.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox):

  • flatpak/webkit-bwrap:
1:31 AM Changeset in webkit [262116] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Flatpak SDK] Fixup icecc support
​https://bugs.webkit.org/show_bug.cgi?id=212301

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Žan Doberšek.

  • flatpak/flatpakutils.py:

(WebkitFlatpak.run_in_sandbox): Allow homedir access from the
sandbox, this is needed because the icecc toolchains paths refer
to the host environment, not the sandbox.
(WebkitFlatpak.pack_toolchain): Fix byte-string formatting issue, happening in Python3.

1:16 AM Changeset in webkit [262115] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK4] SDK contains too old GTK4
​https://bugs.webkit.org/show_bug.cgi?id=212334

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-25
Reviewed by Adrian Perez de Castro.

  • buildstream/elements/sdk/gtk.bst: Update GTK4 to 3.98.4.
12:52 AM Changeset in webkit [262114] by youenn@apple.com
  • 5 edits in trunk/Source/WebCore

MediaPlayerPrivateMediaStreamAVFObjC::m_activeVideoTrack should be a VideoTrackPrivateMediaStream
​https://bugs.webkit.org/show_bug.cgi?id=212129

Reviewed by Eric Carlson.

Instead of looking in the map when wanting to get the VideoTrackPrivateMediaStream corresponding to the active video track,
store directly the VideoTrackPrivateMediaStream as the active video track and use streamTrack() to get the corresponding MediaStreamTrack.
Small refactoring to use more Ref<>.
Covered by existing tests.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoSampleAvailable):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange):
(WebCore::updateTracksOfType):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):

  • platform/mediastream/AudioTrackPrivateMediaStream.h:
  • platform/mediastream/VideoTrackPrivateMediaStream.h:
Note: See TracTimeline for information about the timeline view.