⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 12, 2021:

9:39 PM Changeset in webkit [279864] by Fujii Hironori
  • 3 edits in trunk/Source/WebCore

[curl] Can't finish loading some websites after r271946 started throttling low priority resources
​https://bugs.webkit.org/show_bug.cgi?id=227863

Reviewed by Don Olmstead.

NetworkLoadScheduler started throttling low priority resource
loading since r271946. It uses curl_easy_pause to pause the
resource loads. CURLMOPT_MAX_HOST_CONNECTIONS is set to 6 to limit
the number of connections per host. In the certain condition,
curl_multi_fdset can constantly return -1 if 6 handles of the same
host are paused.

This patch changes CurlRequest::start not to actually start the
job if it is suspended.

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::start):
(WebCore::CurlRequest::suspend):
(WebCore::CurlRequest::resume):
(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::setRequestPaused):

  • platform/network/curl/CurlRequest.h:
7:05 PM Changeset in webkit [279863] by timothy_horton@apple.com
  • 19 edits in trunk/Source/WebKit

Make WebKit's UserInterfaceIdiom operate in terms of the exceptions, not the rule
​https://bugs.webkit.org/show_bug.cgi?id=227885
<rdar://problem/79987158>

Reviewed by Wenson Hsieh.

No new tests, no change in behavior.

In general, we consider the macOS/iPad behavior the "normal" WebKit behavior,
and exceptions to that for iPhone or Watch are just that: exceptions.

To bring the code in line with this understanding, make places that
we make decisions based on UIUserInterfaceIdiom take macOS/iPad behavior
as the default, and make iPhone/Watch the special cases.

  • Shared/UserInterfaceIdiom.h:
  • Shared/UserInterfaceIdiom.mm:

(WebKit::currentUserInterfaceIdiomIsPhoneOrWatch):
(WebKit::setCurrentUserInterfaceIdiomIsPhoneOrWatch):
Also, lump iPod Touch in with iPhone when checking based on device class.

(WebKit::updateCurrentUserInterfaceIdiom):
(WebKit::currentUserInterfaceIdiomIsPadOrMac): Deleted.
(WebKit::setCurrentUserInterfaceIdiomIsPadOrMac): Deleted.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • Shared/ios/WebPreferencesDefaultValuesIOS.mm:

(WebKit::defaultTextAutosizingUsesIdempotentMode):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::registerNotificationObservers):

  • UIProcess/ios/SmartMagnificationController.mm:

(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFormInputSession setAccessoryViewCustomButtonTitle:]):
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
(-[WKContentView _shouldShowAutomaticKeyboardUIIgnoringInputMode]):
(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView _elementTypeRequiresAccessoryView:]):
(-[WKContentView _updateAccessory]):
(-[WKContentView _shouldUseLegacySelectPopoverDismissalBehavior]):

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(WebKit::WebDataListSuggestionsDropdownIOS::show):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingSupported):

  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker show:fromRect:]):

  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _showPhotoPickerWithSourceType:]):
(-[WKFileUploadPanel _presentMenuOptionForCurrentInterfaceIdiom:]):

  • UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl initWithView:]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectMultiplePicker configurePresentation]):

  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::userInterfaceIdiomDidChange):

6:57 PM Changeset in webkit [279862] by Patrick Angle
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION(r279510): Elements: Computed: an (i) button is shown for computed property traces
​https://bugs.webkit.org/show_bug.cgi?id=227892

Reviewed by Devin Rousso.

Property traces need to opt out of displaying the (i) button as they do for things like the colon and semicolon.

  • UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .property-trace-item .property .name,):

6:47 PM Changeset in webkit [279861] by mark.lam@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Revert r277027: breaks GC.
​https://bugs.webkit.org/show_bug.cgi?id=227888

Reviewed by Saam Barati.

The patch in r277027 to make deletion of GCAwareJITStubRoutines incremental has a
bug: the routine may not be deleted yet by the incremental sweeper before the next
GC cycle, and the GC will not be happy visiting dead cell pointers in that routine.
There is also another bug with the triggering of sweeping.

For now, we're reverting the patch, and will revisit this at a later time.

  • CMakeLists.txt:
  • heap/Heap.cpp:

(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::sweepSynchronously):

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::mayHaveJITStubRoutinesToDelete): Deleted.
(JSC::Heap::deleteDeadJITStubRoutines): Deleted.

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::doSweep):

  • heap/JITStubRoutineSet.cpp:

(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):

  • heap/JITStubRoutineSet.h:

(JSC::JITStubRoutineSet::deleteUnmarkedJettisonedStubRoutines):
(JSC::JITStubRoutineSet::traceMarkedStubRoutines):
(JSC::JITStubRoutineSet::mayHaveRoutinesToDelete): Deleted.
(JSC::JITStubRoutineSet::notifyHaveRoutinesToDelete): Deleted.

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::observeZeroRefCount):

  • jit/JITStubRoutine.h:

(JSC::JITStubRoutine::createSelfManagedRoutine):

6:22 PM Changeset in webkit [279860] by Wenson Hsieh
  • 5 edits
    1 add in trunk/Source

[Cocoa] Turn on USE(OS_STATE) when building with a non-Apple-internal SDK
​https://bugs.webkit.org/show_bug.cgi?id=227884

Reviewed by Tim Horton.

Source/WebKit:

Instead of directly importing <os/state_private.h>, introduce a new SPI header (OSStateSPI.h) that simply
includes <os/state_private.h> on internal builds, and falls back to function declarations when using the non-
internal SDK.

  • Platform/spi/Cocoa/OSStateSPI.h: Added.
  • WebKit.xcodeproj/project.pbxproj:

Drive-by fix: additionally restore the minimum objectVersion to 52 rather than 54. This was unintentionally
bumped in r279133.

  • WebProcess/cocoa/WebProcessCocoa.mm:

Source/WTF:

Enable the compile-time flag for all Cocoa builds.

  • wtf/PlatformUse.h:
5:33 PM Changeset in webkit [279859] by Robert Jenner
  • 3 edits in trunk/LayoutTests

REGRESSION (r279806):[iOS Mac wk2 ] fast/canvas/canvas-path-addPath.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=227890

Unreviewed test gardening.

Patch by Eric Hutchison <Eric Hutchison> on 2021-07-12

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
4:58 PM Changeset in webkit [279858] by Russell Epstein
  • 1 copy in tags/Safari-612.1.22.11.3

Tag Safari-612.1.22.11.3.

4:44 PM Changeset in webkit [279857] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ MacOS & iOS ] animations/leak-document-with-css-animation.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=226598

Unreviewed test gardening.

Patch by Ayumi Kojima <Ayumi Kojima> on 2021-07-12

  • platform/ios-wk2/TestExpectations:
4:43 PM Changeset in webkit [279856] by commit-queue@webkit.org
  • 4 edits in trunk

_WKWebAuthenticationPanel escapes slashes in origin
​https://bugs.webkit.org/show_bug.cgi?id=227724
rdar://80232742

Patch by Garrett Davidson <​garrett_davidson@apple.com> on 2021-07-12
Reviewed by Kate Cheney.

Source/WebKit:

Tell NSJSONSerialization not to try to escapes slashes, like those in the scheme of an origin.

  • UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:

(produceClientDataJson):

Tools:

Update both the makeCredential and getAssertion tests to use an origin.

WebAuthenticationPanel.GetAssertionLA:
This test wasn't using an origin or RPID. Update it to use both. This means both
clientDataJSON and authenticatorData changed. Update both to the new expected
values, using as much plaintext as possible.

WebAuthenticationPanel.MakeCredentialLA:
This test should have caught this issue, but the origin being passed here isn't
valid, because it didn't have a scheme. Per the WebAuthn spec, origins used by
WebAuthn MUST start with "​https://". Also update this test to use plaintext
instead of base64 for clientDataJSON.

  • TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:

(TestWebKitAPI::TEST):

4:07 PM Changeset in webkit [279855] by Chris Fleizach
  • 5 edits in trunk/Source

AX: Make WebKit observe spatial audio accessibility settings
​https://bugs.webkit.org/show_bug.cgi?id=227848

Reviewed by Sam Weinig.

Source/WebKit:

Allow mac and iOS to read from accessibility domains.
Allow mac sandbox to read from com.apple.Accessibility.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
  • UIProcess/Cocoa/PreferenceObserver.mm:

(-[WKPreferenceObserver init]):

Source/WTF:

This flag was using the wrong format for a HAVE setting, so the code wasn't being compiled in.

  • wtf/PlatformHave.h:
3:33 PM Changeset in webkit [279854] by timothy_horton@apple.com
  • 5 edits in trunk

BifurcatedGraphicsContext can't draw text
​https://bugs.webkit.org/show_bug.cgi?id=227883

Reviewed by Wenson Hsieh.

Source/WebCore:

API test: BifurcatedGraphicsContextTests.TextInBifurcatedContext

  • platform/graphics/BifurcatedGraphicsContext.cpp:

(WebCore::BifurcatedGraphicsContext::save):
(WebCore::BifurcatedGraphicsContext::restore):
(WebCore::BifurcatedGraphicsContext::paintFrameForMedia):
(WebCore::BifurcatedGraphicsContext::drawText):
(WebCore::BifurcatedGraphicsContext::drawGlyphs):
(WebCore::BifurcatedGraphicsContext::drawEmphasisMarks):
(WebCore::BifurcatedGraphicsContext::drawBidiText):

  • platform/graphics/BifurcatedGraphicsContext.h:

Bifurcate a few methods I somehow missed in the original patch.

Also, call GraphicsContext's implementation of save and restore
from the overridden version, because we confusingly currently use
the top-level context's state stack.

Tools:

  • TestWebKitAPI/Tests/WebCore/cg/BifurcatedGraphicsContextTestsCG.cpp:

(TestWebKitAPI::TEST):
Add a test ensuring that we get DrawGlyphs commands on both contexts.

2:34 PM Changeset in webkit [279853] by Robert Jenner
  • 2 edits in trunk/LayoutTests

[ iOS ] fast/canvas/canvas-overloads-strokeText.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=227881.

Unreviewed test gardening.

Patch by Eric Hutchison <Eric Hutchison> on 2021-07-12

  • platform/ios-wk2/TestExpectations:
2:18 PM Changeset in webkit [279852] by Russell Epstein
  • 1 copy in tags/Safari-612.1.23.1.1

Tag Safari-612.1.23.1.1.

1:55 PM Changeset in webkit [279851] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[Mac wk1 Debug] webaudio/audioworket-out-of-memory.html is a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=227845

Unreviewed test gardening.

Patch by Ayumi Kojima <Ayumi Kojima> on 2021-07-12

  • platform/mac-wk1/TestExpectations:
1:51 PM Changeset in webkit [279850] by Yijia Huang
  • 8 edits in trunk/Source/JavaScriptCore

Add SMNEGL, UMNEGL, UMADDL, and UMSUBL for ARM64 and select this instruction in Air
​https://bugs.webkit.org/show_bug.cgi?id=227857

Reviewed by Robin Morisset.

The previous patches have already added MNEG, MADD, MSUB, SMADDL, and SMSUBL.
This patch completes the corresponding signed or unsigned variants (SMNEGL,
UMNEGL, UMADDL, and UMSUBL) of them. In addition, this patch refactors
the implementation and the associative test cases of MADD, MSUB, and MNEG
to be more readable and maintainable w.r.t their variants.

### SMNEGL/UMNEGL Xd Wn Wm ###

Signed/Unsigned Multiply-Negate Long multiplies two 32-bit register values,
negates the product, and writes the result to the 64-bit destination register.
The equivalent patterns are

d = -(SExt32(n) * SExt32(m)) and d = -(ZExt32(n) * ZExt32(m)) respectively.

Given B3 IR:
Int @0 = S/ZExt32(Trunc(ArgumentReg(%x0)))
Int @1 = S/ZExt32(Trunc(ArgumentReg(%x1)))
Int @2 = Mul(@0, @1)
Int @3 = Neg(@2)
Void@4 = Return(@3, Terminal)

Old optimized AIR
Move32 %x0, %x0, @0
Move32 %x1, %x1, @1
MultiplyNeg %x0, %x1, %x0, @3
Ret %x0, @4

New optimized AIR
MultiplyNegSign/ZeroExtend %x0, %x1, %x0, @3
Ret %x0, @4

### UMADDL Xd Wn Wm Xa ###

Unsigned Multiply-Add Long multiplies two 32-bit register values, adds a 64-bit
register value, and writes the result to the 64-bit destination register. The
equivalent patterns are

d = ZExt32(n) * ZExt32(m) + a or d = a + ZExt32(n) * ZExt32(m)

Given B3 IR:
Int @0 = ZExt32(Trunc(ArgumentReg(%x0)))
Int @1 = ZExt32(Trunc(ArgumentReg(%x1)))
Int @2 = ArgumentReg(%x2)
Int @3 = Mul(@0, @1)
Int @4 = Add(@3, @2)
Void@5 = Return(@4, Terminal)

Old optimized AIR
Move32 %x0, %x0, @1
Move32 %x1, %x1, @2
MultiplyAdd %x0, %x1, %x2, %x0, @4
Ret64 %x0, @5

New optimized AIR
MultiplyAddZeroExtend %x0, %x1, %x2, %x0, @8
Ret %x0, @9

### UMSUBL Xd Wn Wm Xa ###

Unsigned Multiply-Subtract Long multiplies two 32-bit register values, subtracts
the product from a 64-bit register value, and writes the result to the 64-bit
destination register. The equivalent patterns are

d = a - ZExt32(n) * ZExt32(m)

Given B3 IR:
Int @0 = ZExt32(Trunc(ArgumentReg(%x0)))
Int @1 = ZExt32(Trunc(ArgumentReg(%x1)))
Int @2 = ArgumentReg(%x2)
Int @3 = Mul(@0, @1)
Int @4 = Sub(@2, @3)
Void@5 = Return(@4, Terminal)

Old optimized AIR
Move32 %x0, %x0, @1
Move32 %x1, %x1, @2
MultiplySub %x0, %x1, %x2, %x0, @4
Ret64 %x0, @5

New optimized AIR
MultiplySubZeroExtend %x0, %x1, %x2, %x0, @8
Ret %x0, @9

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::multiplyNeg32):
(JSC::MacroAssemblerARM64::multiplyAddZeroExtend32):
(JSC::MacroAssemblerARM64::multiplySubZeroExtend32):
(JSC::MacroAssemblerARM64::multiplyNeg64):
(JSC::MacroAssemblerARM64::multiplyNegSignExtend32):
(JSC::MacroAssemblerARM64::multiplyNegZeroExtend32):

  • assembler/testmasm.cpp:

(JSC::testMultiplyAddSignExtend32):
(JSC::testMultiplyAddZeroExtend32):
(JSC::testMultiplySubSignExtend32):
(JSC::testMultiplySubZeroExtend32):
(JSC::testMultiplyNegSignExtend32):
(JSC::testMultiplyNegZeroExtend32):
(JSC::testMultiplyAddSignExtend32Left): Deleted.
(JSC::testMultiplyAddSignExtend32Right): Deleted.

  • b3/B3LowerToAir.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/testb3.h:
  • b3/testb3_2.cpp:

(testMulAddArgsLeft):
(testMulAddArgsRight):
(testMulAddSignExtend32ArgsLeft):
(testMulAddZeroExtend32ArgsLeft):
(testMulAddZeroExtend32ArgsRight):
(testMulSubArgsLeft):
(testMulSubArgsRight):
(testMulSubArgsRight32):
(testMulSubSignExtend32):
(testMulSubZeroExtend32):
(testMulNegArgArg):
(testMulNegArgs):
(testMulNegArgs32):
(testMulNegSignExtend32):
(testMulNegZeroExtend32):
(testMulSubSignExtend32Args): Deleted.

  • b3/testb3_3.cpp:

(addArgTests):

1:46 PM Changeset in webkit [279849] by Jonathan Bedard
  • 4 edits in trunk/Tools

[run-api-tests] Use Python 3 (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=225427
<rdar://problem/77584713>

Reviewed by Aakash Jain.

  • CISupport/build-webkit-org/steps.py:

(RunAPITests): Use Python3 to invoke run-api-tests.

  • CISupport/ews-build/steps.py:

(RunAPITests): Use Python3 to invoke run-api-tests.

  • CISupport/ews-build/steps_unittest.py:
1:45 PM Changeset in webkit [279848] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Updating test expectations for imported/w3c/web-platform-tests/navigation-timing/test_timing_attributes_order.html.
​https://bugs.webkit.org/show_bug.cgi?id=227877.

Unreviewed test gardening.

Patch by Eric Hutchison <Eric Hutchison> on 2021-07-12

  • platform/mac/TestExpectations:
1:45 PM Changeset in webkit [279847] by Simon Fraser
  • 17 edits in trunk/Source

Add a StyleSheets log channel and some logging
​https://bugs.webkit.org/show_bug.cgi?id=227880

Reviewed by Alan Bujtas.

Source/WebCore:

Add some logging to help debug issues when pages dynamically build style sheets.

Also make Document loggable.

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::insertRule):
(WebCore::CSSStyleSheet::deleteRule):
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::debugDescription const):

  • css/CSSStyleSheet.h:
  • css/StyleSheet.cpp:

(WebCore::operator<<):

  • css/StyleSheet.h:
  • dom/Document.cpp:

(WebCore::Document::debugDescription const):
(WebCore::operator<<):

  • dom/Document.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::debugDescription const):

  • html/HTMLLinkElement.h:
  • platform/Logging.h:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties const):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::imageBufferResult):

  • style/StyleScope.cpp:

(WebCore::Style::Scope::addPendingSheet):
(WebCore::Style::Scope::addStyleSheetCandidateNode):
(WebCore::Style::Scope::collectActiveStyleSheets):
(WebCore::Style::Scope::updateActiveStyleSheets):

  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::debugDescription const):

Source/WTF:

Make it possible to feed Ref<> and RefPtr<> into TextStream.

  • wtf/text/TextStream.h:

(WTF::operator<<):

1:18 PM Changeset in webkit [279846] by Russell Epstein
  • 8 edits in branches/safari-612.1.22.11-branch/Source

Versioning.

WebKit-7612.1.22.11.3

12:05 PM Changeset in webkit [279845] by sbarati@apple.com
  • 4 edits in trunk/JSTests

Run some tests for fewer iterations to prevent test timeouts
​https://bugs.webkit.org/show_bug.cgi?id=227879

Reviewed by Mark Lam.

  • microbenchmarks/get-by-val-negative-array-index.js:
  • microbenchmarks/memcpy-typed-loop-small.js:
  • microbenchmarks/put-by-val-negative-array-index.js:
11:56 AM Changeset in webkit [279844] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Add a new GTK layout tester bot to build.webkit.org that runs with --skip-failing-tests switch
​https://bugs.webkit.org/show_bug.cgi?id=227744

Reviewed by Jonathan Bedard.

On the EWS the layout tests run with this switch --skip-failing-tests
which changes the order in which tests are run (those expected to fail
are not scheduled). I think this may be causing different results on
other tests (like unexpected failures or unexpected flakies).
Having a bot in build.webkit.org running with this switch will help
to detect and garden those cases.

  • CISupport/build-webkit-org/config.json:
11:52 AM Changeset in webkit [279843] by Adrian Perez de Castro
  • 1 copy in releases/WPE WebKit/webkit-2.32.2

WPE WebKit 2.32.2

11:51 AM Changeset in webkit [279842] by Adrian Perez de Castro
  • 4 edits in releases/WebKitGTK/webkit-2.32

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.32.2 release

.:

  • Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

  • wpe/NEWS: Add release notes for 2.32.2
11:08 AM Changeset in webkit [279841] by Russell Epstein
  • 8 edits in branches/safari-612.1.23.1-branch/Source

Versioning.

WebKit-7612.1.23.1.1

11:06 AM Changeset in webkit [279840] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Unreviewed, reverting r279835.

Newly added assertions are wrong

Reverted changeset:

"Regression(r279601) ProcessAssertion may get destroyed on a
background thread"
​https://bugs.webkit.org/show_bug.cgi?id=227875
​https://commits.webkit.org/r279835

11:02 AM Changeset in webkit [279839] by sbarati@apple.com
  • 2 edits in trunk/JSTests

stress/wasm-loop-consistency.js should require the --useExecutableAllocationFuzz=false JSC option
​https://bugs.webkit.org/show_bug.cgi?id=227876

Reviewed by Mark Lam.

  • stress/wasm-loop-consistency.js:
10:59 AM Changeset in webkit [279838] by Chris Dumez
  • 269 edits
    1 copy
    8 moves
    816 adds
    27 deletes in trunk/LayoutTests

Resync content-security-policy web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=227651

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync content-security-policy web-platform-tests from upstream 2c19d6ee62676ac90146.

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/content-security-policy/*: Updated.
  • web-platform-tests/reporting/*: Imported.

LayoutTests:

10:54 AM Changeset in webkit [279837] by Russell Epstein
  • 1 copy in branches/safari-612.1.23.1-branch

New branch.

10:48 AM Changeset in webkit [279836] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Unreviewed, reverting r279493.
​https://bugs.webkit.org/show_bug.cgi?id=227878

Web Inspector: Can't reveal local overrides in the sidebar if
lots of scripts are visible

Reverted changeset:

"Web Inspector: [Regression: r279271] Sources: Breakpoints
section in navigation sidebar disappears when Web Inspector
becomes taller than 650px"
​https://bugs.webkit.org/show_bug.cgi?id=227597
​https://commits.webkit.org/r279493

10:26 AM Changeset in webkit [279835] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Regression(r279601) ProcessAssertion may get destroyed on a background thread
​https://bugs.webkit.org/show_bug.cgi?id=227875
<rdar://76972252>

Reviewed by Geoffrey Garen.

r279601 added an internal WorkQueue to ProcessAssertion, so that we could acquire the RunningBoard assertion
asynchronously on the background queue. When dispatching to the background queue, we capture |protectedThis|,
which means that ProcessAssertion may now get destroyed on the background queue. ProcessAssertion is a main
thread object and destroying it on a non-main thread can lead to crashes.

  • UIProcess/ProcessAssertion.h:
  • UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAssertion::~ProcessAssertion):

10:23 AM Changeset in webkit [279834] by Russell Epstein
  • 8 edits in branches/safari-612.1.23-branch/Source

Versioning.

WebKit-7612.1.23.1

10:10 AM Changeset in webkit [279833] by jer.noble@apple.com
  • 5 edits in trunk

[Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:]
​https://bugs.webkit.org/show_bug.cgi?id=227860
<rdar://80376777>

Reviewed by Sam Weinig.

Source/WebKit:

In r277645, we added a deprecation declaration for -closeAllMediaPresentations:completion, but
that API was never shipped in a release. The actual shipped API, -closeAllMediaPresentations,
was removed entirely, leading to bincompat crashes when binaries built against older SDKs are
run against newer OSs.

Correct the deprecated API declaration, and re-add support for -closeAllMediaPresentations.

  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView closeAllMediaPresentations]):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:

(TEST):

10:08 AM Changeset in webkit [279832] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed, partial revert of r279661 to address crashes on iOS Debug.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::removeAllEventListeners):

9:25 AM Changeset in webkit [279831] by Truitt Savell
  • 2 edits in trunk/LayoutTests

[BigSur Release wk2 ]fullscreen/full-screen-remove-children.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=227874.

Unreviewed test gardening.

Patch by Eric Hutchison <Eric Hutchison> on 2021-07-12

  • platform/mac-wk2/TestExpectations:
9:15 AM Changeset in webkit [279830] by Wenson Hsieh
  • 11 edits
    2 adds in trunk

[watchOS] Make a few additional adjustments to support system minimum layout margins
​https://bugs.webkit.org/show_bug.cgi?id=227859
rdar://80113612

Reviewed by Tim Horton.

Source/WebCore:

Reduce the default minimum viewport scale on watchOS to avoid horizontal scrolling when loading wide fixed-
viewport-width web content. See WebKit ChangeLog for more details.

  • page/ViewportConfiguration.cpp:

(WebCore::platformDeviceWidthOverride):
(WebCore::platformMinimumScaleForWebpage):
(WebCore::shouldOverrideShrinkToFitArgument):
(WebCore::ViewportConfiguration::nativeWebpageParametersWithShrinkToFit):
(WebCore::ViewportConfiguration::webpageParameters):

Source/WebKit:

Make a couple of minor adjustments to deal with the fact that -contentInset includes system content insets
(specifically, -_contentScrollInset) on watchOS, due to method swizzling that happens in PepperUICore. See
changes below for more detail.

Test: fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html

  • UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _computedContentInset]):

Only apply -safeAreaInsets on top of -contentInset when computing the total scroll view content inset on
watchOS (as opposed to applying both -safeAreaInsets and -_contentScrollInset); this is because
-contentInset on watchOS is actually equivalent to -_effectiveContentInset on other iOS-family platforms, so
additionally adding -_contentScrollInset here would result in the scroll content inset being double-counted.

  • UIProcess/ios/WKScrollView.mm:

(-[WKScrollView setContentInset:]):
(-[WKScrollView _setContentScrollInsetInternal:]):
(-[WKScrollView _updateContentScrollInset]):

In the case where the WebKit client explicitly sets the scroll view's content insets using `-[WKScrollView
setContentInset:], set a flag (_contentInsetWasExternallyOverridden`) and immediately revert any internally
specified -_contentScrollInset on WKScrollView. Due to the swizzled implementation of `-[UIScrollView
contentInset] described above, it's practically impossible for any client to use -setContentInset:` correctly
when there is a nonzero -_contentScrollInset on watchOS, so preferable to simply get out of the way of the
client in this scenario.

In the context of _SFNanoBrowserViewController, this ensures that scroll view content inset adjustment logic in
Safari doesn't inadvertently cause horizontal content insets to increase by -_contentScrollInset every time
-[WKScrollView setContentInset:] is invoked by the client.

Tools:

Add support for simulating arbitrary horizontal (trailing and leading) values for -systemMinimumLayoutMargin
in WebKitTestRunner, via a new "horizontalSystemMinimumLayoutMargin" test option. By default, this is 0.

  • WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::horizontalSystemMinimumLayoutMargin const):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(-[PlatformWebViewController systemMinimumLayoutMargins]):

Override this UIViewController method and replace the leading and trailing layout margin values with the values
from test options.

(WTR::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetStateToConsistentValues):

Additionally make a slight adjustment here to avoid calling -setContentInset on the scroll view in between
tests if the content insets aren't changing. This is needed in order for the new layout test to work on watchOS.

LayoutTests:

Add a new layout test that uses the new test option to verify that nonzero horizontal system minimum layout
margins shrink the width of the viewport on watchOS (this test also disables watchOS device adaptations and uses
a device-width viewport with initial-scale=1 such that we can simply check the value of innerWidth).

  • fast/viewport/watchos/viewport-with-system-minimum-layout-margins-expected.txt: Added.
  • fast/viewport/watchos/viewport-with-system-minimum-layout-margins.html: Added.
9:14 AM Changeset in webkit [279829] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

AX: Add ARIA role "image" as a new role, and leave "img" as a synonym
​https://bugs.webkit.org/show_bug.cgi?id=224615

Patch by Tyler Wilcock <Tyler Wilcock> on 2021-07-12
Reviewed by Chris Fleizach.

Source/WebCore:

Test: accessibility/image-role-is-synonomous-with-img-role.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::initializeRoleMap):
Add "image" ARIA role as a synonym for the "img" ARIA role, both of
which map to the AccessibilityRole::Image WebCore representation.

Also hardcode the ARIA reverse role map to return "image" for
the AccessibilityRole::Image key.

LayoutTests:

The "image" role is replacing the "img" role (though "img" is not
going away), so "image" should be returned from computedRoleString.

  • accessibility/image-role-is-synonomous-with-img-role-expected.txt: Added.
  • accessibility/image-role-is-synonomous-with-img-role.html: Added.
  • accessibility/roles-computedRoleString-expected.txt:
  • accessibility/roles-computedRoleString.html:
  • inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
  • platform/glib/accessibility/roles-computedRoleString-expected.txt:
  • platform/gtk/accessibility/gtk/xml-roles-exposed-expected.txt:
  • platform/gtk/accessibility/image-link-expected.txt:
  • platform/gtk/inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
  • platform/mac/accessibility/roles-computedRoleString-expected.txt:
  • platform/wpe/accessibility/image-link-expected.txt:

All the tests in this group have been updated to expect "image"
instead of "img".

8:41 AM Changeset in webkit [279828] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] media/playlist-inherits-user-gesture.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=198118

Unreviewed test gardening, this test passes after r227404.

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2021-07-12

  • platform/glib/TestExpectations:
8:23 AM Changeset in webkit [279827] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[GTK] Touch navigation gesture triggers kinetic scrolling when cancelling
​https://bugs.webkit.org/show_bug.cgi?id=227701

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-07-12
Reviewed by Michael Catanzaro.

Make sure an event that has finished a navigation swipe gesture isn't propagated
to the page triggering kinetic scrolling.

Move the navigation swipe ending from drag-end to swipe signal handler, since
that's where kinetic scrolling is handled and we can stop it.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseTouchDragEnd):
(webkitWebViewBaseTouchSwipe):

  • UIProcess/gtk/ViewGestureControllerGtk.cpp:

(WebKit::ViewGestureController::SwipeProgressTracker::handleEvent):

7:26 AM Changeset in webkit [279826] by commit-queue@webkit.org
  • 12 edits in trunk/Source

[GTK][WPE] Support drawing scrollbar corner
​https://bugs.webkit.org/show_bug.cgi?id=227868

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-07-12
Reviewed by Michael Catanzaro.

Source/WebCore:

With dark scrollbars supported, the lack of scroll corner for non-overlay
scrollbars becomes very noticeable. Implement it.

To properly draw them, we need to know whether scrollbars are dark, and whether
the vertical scrollbar is on the left. Hence, pass ScrollableArea to
paintScrollCorner() so we can query it.

Only cover non-system scrollbars, it would take considerable amount of work to
make it work for system as well.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintScrollCorner):

  • platform/ScrollbarTheme.h:

(WebCore::ScrollbarTheme::paintScrollCorner):
(WebCore::ScrollbarTheme::defaultPaintScrollCorner):

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:

(WebCore::ScrollbarThemeAdwaita::paintScrollCorner):

  • platform/adwaita/ScrollbarThemeAdwaita.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paintScrollCorner):

  • rendering/RenderLayerScrollableArea.cpp:

(WebCore::RenderLayerScrollableArea::paintScrollCorner):

  • rendering/RenderScrollbarTheme.cpp:

(WebCore::RenderScrollbarTheme::paintScrollCorner):

  • rendering/RenderScrollbarTheme.h:

Source/WebKit:

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::paintControlForLayerInContext):
Update the paintScrollCorner() call.

6:05 AM Changeset in webkit [279825] by clopez@igalia.com
  • 4 edits
    1 delete in trunk

Unreviewed, reverting r279778.

It caused unexpected text diffs on http/tests/storageAccess
tests

Reverted changeset:

"[GTK][WPE][libsoup] Test imported/w3c/web-platform-
tests/cookies/samesite/about-blank-toplevel.https.html crashes
since it was imported"
​https://bugs.webkit.org/show_bug.cgi?id=227819
​https://commits.webkit.org/r279778

6:02 AM Changeset in webkit [279824] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Match Adwaita scrollbars more closely
​https://bugs.webkit.org/show_bug.cgi?id=227870

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-07-12
Reviewed by Michael Catanzaro.

Adjust the dimensions to match GTK as closely as possible.

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:

(WebCore::ScrollbarThemeAdwaita::paint):

4:47 AM Changeset in webkit [279823] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK] Adwaita entries should follow the system cursor blink settings
​https://bugs.webkit.org/show_bug.cgi?id=227856

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-07-12
Reviewed by Adrian Perez de Castro.

Get the caret blink interval from GtkSettings if available, same as it was done
for the GTK theme before.

  • rendering/RenderThemeAdwaita.cpp:

(WebCore::RenderThemeAdwaita::caretBlinkInterval const):

  • rendering/RenderThemeAdwaita.h:
2:30 AM Changeset in webkit [279822] by imanol
  • 16 edits
    1 copy
    12 moves
    3 adds in trunk/Source/WebKit

Cross platform compilation of PlatformXRSystem and PlatformXRSystemProxy
​https://bugs.webkit.org/show_bug.cgi?id=226919

Reviewed by Dean Jackson.

PlatformXRSystem and PlatformXRSystemProxy are only compiled in Cocoa platform while WPE uses OpenXR,
which only has code in WebCore. In order to run WebKit based WebXR on non-cocoa VR Standalone devices
we also need to split the code and IPC messages between UIProcess/WebProcess.

The existing PlatformXRSystem/PlatformXRSystemProxy pattern fits very well to the VR standalone scenario.
This patch ensures that the existing code can be used in more platforms other than Cocoa.

Tested by WebXR WPT.

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformMac.cmake:
  • Shared/XR/XRDeviceIdentifier.h: Renamed from Source/WebKit/Shared/Cocoa/XRDeviceIdentifier.h.
  • Shared/XR/XRDeviceInfo.cpp: Renamed from Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm.
  • Shared/XR/XRDeviceInfo.h: Renamed from Source/WebKit/Shared/Cocoa/XRDeviceInfo.h.
  • Shared/XR/XRDeviceProxy.cpp: Renamed from Source/WebKit/Shared/Cocoa/XRDeviceProxy.mm.
  • Shared/XR/XRDeviceProxy.h: Renamed from Source/WebKit/Shared/Cocoa/XRDeviceProxy.h.
  • Shared/mac/MediaFormatReader/MediaSampleCursor.cpp: Add include to fix compilation error
  • Sources.txt:
  • SourcesCocoa.txt:
  • UIProcess/Cocoa/PlatformXRCoordinator.mm: Copied from Source/WebKit/WebProcess/cocoa/PlatformXRSystemProxy.messages.in.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didAttachToRunningProcess):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • UIProcess/XR/PlatformXRCoordinator.h: Renamed from Source/WebKit/UIProcess/Cocoa/PlatformXRCoordinator.h.
  • UIProcess/XR/PlatformXRSystem.cpp: Renamed from Source/WebKit/UIProcess/Cocoa/PlatformXRSystem.mm.
  • UIProcess/XR/PlatformXRSystem.h: Renamed from Source/WebKit/UIProcess/Cocoa/PlatformXRSystem.h.
  • UIProcess/XR/PlatformXRSystem.messages.in: Renamed from Source/WebKit/UIProcess/Cocoa/PlatformXRSystem.messages.in.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::xrSystemProxy):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/XR/PlatformXRSystemProxy.cpp: Renamed from Source/WebKit/WebProcess/cocoa/PlatformXRSystemProxy.mm.
  • WebProcess/XR/PlatformXRSystemProxy.h: Renamed from Source/WebKit/WebProcess/cocoa/PlatformXRSystemProxy.h.
  • WebProcess/XR/PlatformXRSystemProxy.messages.in: Renamed from Source/WebKit/WebProcess/cocoa/PlatformXRSystemProxy.messages.in.
1:22 AM Changeset in webkit [279821] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK4] Scrollbar click doesn't work as expected when native scrollbars are off
​https://bugs.webkit.org/show_bug.cgi?id=226331

Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2021-07-12
Reviewed by Carlos Garcia Campos.

Make Adwaita scrollbar theme follow the GTK setting if possible.

  • platform/adwaita/ScrollbarThemeAdwaita.cpp:

(WebCore::ScrollbarThemeAdwaita::handleMousePressEvent):

12:53 AM Changeset in webkit [279820] by ysuzuki@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] JITCage already includes guard pages
​https://bugs.webkit.org/show_bug.cgi?id=227867

Reviewed by Mark Lam.

Since JITCage already includes guard pages, we do not need to allocate that additionally.

  • jit/ExecutableAllocator.cpp:

(JSC::initializeJITPageReservation):

12:40 AM Changeset in webkit [279819] by commit-queue@webkit.org
  • 12 edits
    108 adds in trunk/LayoutTests

Resync web-platform-tests/css/css-overflow from upstream
​https://bugs.webkit.org/show_bug.cgi?id=227849

Patch by Rob Buis <​rbuis@igalia.com> on 2021-07-12
Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Import based on 1d6a9a37bc.

  • resources/resource-files.json:
  • web-platform-tests/css/css-overflow/clip-001.html:
  • web-platform-tests/css/css-overflow/clip-002-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-002.html: Added.
  • web-platform-tests/css/css-overflow/clip-003-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-003.html: Added.
  • web-platform-tests/css/css-overflow/clip-004-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-004.html: Added.
  • web-platform-tests/css/css-overflow/clip-005-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-005.html: Added.
  • web-platform-tests/css/css-overflow/clip-006-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-006.html: Added.
  • web-platform-tests/css/css-overflow/clip-007-expected.html: Added.
  • web-platform-tests/css/css-overflow/clip-007.html: Added.
  • web-platform-tests/css/css-overflow/dynamic-visible-to-clip-001.html:
  • web-platform-tests/css/css-overflow/incremental-scroll-expected.html: Added.
  • web-platform-tests/css/css-overflow/incremental-scroll.html: Added.
  • web-platform-tests/css/css-overflow/no-scrollable-overflow-vertical-rl-2-expected.html: Added.
  • web-platform-tests/css/css-overflow/no-scrollable-overflow-vertical-rl-2.html: Added.
  • web-platform-tests/css/css-overflow/no-scrollable-overflow-vertical-rl-expected.html: Added.
  • web-platform-tests/css/css-overflow/no-scrollable-overflow-vertical-rl.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-007-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-007.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-008-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-008.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-009-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-009.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-010-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-010.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-011-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-body-propagation-011.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-001-crash.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-002-crash.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-cant-scroll-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-cant-scroll.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-content-visual-overflow-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-content-visual-overflow.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-hit-testing.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-001-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-001.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-002-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-002.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-003-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-003.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-004-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-004.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-005-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-005.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-006-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-006.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-007-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-007.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-intersection-observer.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-invalidation-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-margin-invalidation.html: Added.
  • web-platform-tests/css/css-overflow/overflow-clip-scroll-size.html: Added.
  • web-platform-tests/css/css-overflow/overflow-empty-child-box-expected.txt: Added.
  • web-platform-tests/css/css-overflow/overflow-empty-child-box.html: Added.
  • web-platform-tests/css/css-overflow/overflow-hidden-resize-with-stacking-context-child-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-hidden-resize-with-stacking-context-child.html: Added.
  • web-platform-tests/css/css-overflow/overflow-negative-margin-dynamic-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-negative-margin-dynamic.html: Added.
  • web-platform-tests/css/css-overflow/overflow-negative-margin-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-negative-margin.html: Added.
  • web-platform-tests/css/css-overflow/overflow-no-frameset-propagation-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-no-frameset-propagation.html: Added.
  • web-platform-tests/css/css-overflow/overflow-padding.html:
  • web-platform-tests/css/css-overflow/overflow-replaced-element-001-expected.txt: Added.
  • web-platform-tests/css/css-overflow/overflow-replaced-element-001.html: Added.
  • web-platform-tests/css/css-overflow/overflow-scroll-resize-visibility-hidden-expected.html: Added.
  • web-platform-tests/css/css-overflow/overflow-scroll-resize-visibility-hidden.html: Added.
  • web-platform-tests/css/css-overflow/parsing/overflow-computed-expected.txt:
  • web-platform-tests/css/css-overflow/parsing/overflow-computed.html:
  • web-platform-tests/css/css-overflow/parsing/scrollbar-gutter-invalid.html:
  • web-platform-tests/css/css-overflow/parsing/scrollbar-gutter-valid.html:
  • web-platform-tests/css/css-overflow/scrollable-overflow-float-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-float.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-self-collapsing-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-self-collapsing.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-textarea-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-textarea.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-001-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-002-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-002.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-003-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-003.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-001-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-002-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-002.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-003-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-003.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-004-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-004.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-005-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-005.html: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-006-expected.txt: Added.
  • web-platform-tests/css/css-overflow/scrollable-overflow-transform-dynamic-006.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-002.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-003.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-004.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-005.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-006.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-propagation-007.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-rtl-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-lr-001.html: Added.
  • web-platform-tests/css/css-overflow/scrollbar-gutter-vertical-rl-001.html: Added.
  • web-platform-tests/css/css-overflow/w3c-import.log:
  • web-platform-tests/css/css-overflow/webkit-line-clamp-036-expected.html: Added.
  • web-platform-tests/css/css-overflow/webkit-line-clamp-036.html: Added.
  • web-platform-tests/css/css-overflow/webkit-line-clamp-037-expected.html: Added.
  • web-platform-tests/css/css-overflow/webkit-line-clamp-037.html: Added.
  • web-platform-tests/css/css-overflow/webkit-line-clamp-dynamic-001-expected.html: Added.
  • web-platform-tests/css/css-overflow/webkit-line-clamp-dynamic-001.html: Added.

LayoutTests:

Skip some tests, for example some rely on
unimplemented overflow: clip property.

Jul 11, 2021:

9:08 PM Changeset in webkit [279818] by Chris Dumez
  • 14 edits in trunk

:link and :visited pseudo-class selectors should not match <link> elements
​https://bugs.webkit.org/show_bug.cgi?id=227847

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
  • web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/link-expected.txt:

Source/WebCore:

:link, :visited and :any-link should only match <a> and <area> elements as per:

Blink and Gecko match the specification. However, WebKit was incorrectly matching
<link> elements too.

No new tests, rebaselined existing tests.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute):

LayoutTests:

Update / Rebaseline existing tests due to behavior change.

  • fast/css/link-basics-expected.html:
  • fast/css/link-basics.html:
  • fast/selectors/any-link-basics-expected.txt:
  • fast/selectors/link-basics-expected.txt:
  • fast/selectors/link-basics-xhtml-expected.txt:
  • fast/selectors/resources/html-link-type-tests.js:

(testHTMLTagsForLink):

  • fast/selectors/webkit-any-link-basics-expected.txt:
4:41 PM Changeset in webkit [279817] by Wenson Hsieh
  • 4 edits in trunk/Source/WebKit

Remove an unused deprecated private UI delegate method
​https://bugs.webkit.org/show_bug.cgi?id=227861

Reviewed by Tim Horton.

-_webView:didNotHandleTapAsMeaningfulClickAtPoint: is replaced with -_webView:didTapAtPoint:withResult:;
the old SPI is no longer required for either binary or source compatibility after rdar://79700201.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::didTapAtPoint):

1:36 PM Changeset in webkit [279816] by Fujii Hironori
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

  • platform/wincairo/TestExpectations:
11:20 AM Changeset in webkit [279815] by Chris Dumez
  • 5 edits in trunk

XMLSerializer.serializeToString() doesn't properly escape \n, \n and \t
​https://bugs.webkit.org/show_bug.cgi?id=227844

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that one more subtest is passing.

  • web-platform-tests/domparsing/XMLSerializer-serializeToString-expected.txt:

Source/WebCore:

XMLSerializer.serializeToString() doesn't properly escape \n, \n and \t.

This is causing the "check XMLSerializer.serializeToString escapes attribute values for roundtripping" subtest to fail in WebKit on:
​http://wpt.live/domparsing/XMLSerializer-serializeToString.html

Chrome and Firefox both escape these and pass this WPT subtest.

The specification does not indicate we should escape those:

But there is an open bug about this:

No new tests, rebaselined existing test.

  • editing/MarkupAccumulator.cpp:

(WebCore::elementCannotHaveEndTag):

  • editing/MarkupAccumulator.h:
Note: See TracTimeline for information about the timeline view.