Context Navigation

← Previous Period
Next Period →

Timeline

Mar 29, 2022:

11:37 PM Changeset in webkit [292096] by Fujii Hironori

3 edits
1 delete in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

platform/wincairo-wk1/TestExpectations:
platform/wincairo/TestExpectations:
platform/wincairo/fast/text/softHyphen-expected.txt: Removed.

11:12 PM Changeset in webkit [292095] by Brandon

2 edits in trunk/Source/WebCore

Ensure m_layerRulesBeforeImportRules is properly copied during StyleSheetContents instantiation
https://bugs.webkit.org/show_bug.cgi?id=238537

Reviewed by Antti Koivisto.

During the instantiation of the StyleSheetContents the m_layerRulesBeforeImportRules was not being
properly copied.

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):

6:57 PM Changeset in webkit [292094] by Diego Pino Garcia

2 edits in trunk/Source/WebCore

[GCC] Ubuntu LTS build broken after r291956
https://bugs.webkit.org/show_bug.cgi?id=238481

Reviewed by Darin Adler.

Default comparisons by value (P1946R0) is only supported since GCC10.
https://en.cppreference.com/w/cpp/compiler_support/20

rendering/style/StyleGridData.h:

(WebCore::GridTrackEntrySubgrid::operator== const):
(WebCore::GridTrackEntryRepeat::operator== const):
(WebCore::GridTrackEntryAutoRepeat::operator== const):

6:36 PM Changeset in webkit [292093] by Alan Coon

87 edits
3 deletes in branches/safari-613-branch

Apply patch. rdar://problem/89997669

6:36 PM Changeset in webkit [292092] by Alan Coon

3 edits in branches/safari-613-branch

Apply patch. rdar://problem/89997669

6:35 PM Changeset in webkit [292091] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r291494. rdar://problem/90957324

Keep a strong reference to session in [WebCoreNSURLSessionDataTask _restart]
https://bugs.webkit.org/show_bug.cgi?id=238061
<rdar://88242622>

Patch by Alex Christensen <achristensen@webkit.org> on 2022-03-18
Reviewed by Eric Carlson.

_session is a WeakObjCPtr<WebCoreNSURLSession> and since we're not using ARC self.session
returns a raw pointer to an object that may be deallocated and null out its loader on a different thread.
To prevent null crashes, keep a strong reference to the session when using it.

platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSession dealloc]): (-[WebCoreNSURLSessionDataTask _restart]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:35 PM Changeset in webkit [292090] by Alan Coon

2 edits in branches/safari-613-branch/Source/WebKit

Cherry-pick r290840. rdar://problem/90957274

[WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
https://bugs.webkit.org/show_bug.cgi?id=225646
rdar://78147681

Reviewed by Brent Fulgham.

decidePolicyForLocalAuthenticator is not implemented for the _WKWebAuthenticationPanelDelegate
used for modern because the prompt to allow Touch/FaceID comes earlier in the process.

UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::makeCredential):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:35 PM Changeset in webkit [292089] by Alan Coon

3 edits in branches/safari-613-branch

Cherry-pick r290392. rdar://problem/90957261

[WebAuthn] Improve error message for missing pubKeyCredParams
https://bugs.webkit.org/show_bug.cgi?id=235421
rdar://87884875

Reviewed by Brent Fulgham.

Source/WebCore:

We have seen confusion from library authors around the language
used in this error not indicating enough information about what
the problem is. This patch adds additional information, useful
to developers seeing this error.

Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::create const):

LayoutTests:

Update test to reflect new error message.

http/wpt/webauthn/public-key-credential-create-failure.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:27 PM Changeset in webkit [292088] by Alan Coon

9 edits in branches/safari-613.2.4.1-branch/Source

Versioning.

WebKit-7613.2.4.1.2

6:23 PM Changeset in webkit [292087] by Alan Coon

9 edits in branches/safari-613.2.4.0-branch/Source

Versioning.

WebKit-7613.2.4.0.2

5:34 PM Changeset in webkit [292086] by Tyler Wilcock

10 edits
3 adds in trunk

AX: Don't detach children in AXIsolatedTree::applyPendingChanges for nodes being updated (removed and added)
https://bugs.webkit.org/show_bug.cgi?id=238460

Reviewed by Chris Fleizach and Andres Gonzalez.

Source/WebCore:

In AXIsolatedTree::updateNode, we perform the update by queuing the node to be
removed, and then queueing it to be added. When performing the removal in
AXIsolatedTree::applyPendingChanges, we call AXCoreObject::detach, which unconditionally
calls AXCoreObject::detachRemoteParts. Specifically, AXIsolatedObject::detachRemoteParts
detaches all the object's children from the itself (by setting their m_parentID to zero).
Then, when we start applying m_pendingAppends, we re-add the object, but never re-attach
the children, resulting in a broken tree.

This patch fixes this by storing the reason (AccessibilityDetachmentType) the node is
being removed in m_pendingNodeRemovals, and not detaching children if the type is
AccessibilityDetachmentType::ElementChanged, as in the case of a node update.

This patch also removes AXIsolatedObject::setParent. It's never called, and
its existence is therefore confusing.

Test: accessibility/search-traversal-after-role-change.html.
This test exercises the behavior in this patch because changing an
object's role triggers AXIsolatedTree::updateNode.

accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::detach):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setParent): Deleted.

accessibility/isolatedtree/AXIsolatedObject.h:
accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::applyPendingChanges):

accessibility/isolatedtree/AXIsolatedTree.h:

LayoutTests:

accessibility/search-traversal-after-role-change-expected.txt: Added.
accessibility/search-traversal-after-role-change.html: Added.
platform/glib/TestExpectations: Skip new test.
platform/ios/TestExpectations: Enable new test.
platform/ios/accessibility/search-traversal-after-role-change-expected.txt: Added.
platform/win/TestExpectations: Skip new test.

5:32 PM Changeset in webkit [292085] by Tyler Wilcock

3 edits in trunk/Source/WebCore

AXIsolatedObject::isAccessibilityObject should not be ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=238511

Reviewed by Chris Fleizach.

We try to downcast AXCoreObjects to AccessibilityObjects here in AXLogger's TextStream& operator<<(TextStream&, const AXCoreObject&):

if (auto* axObject = dynamicDowncast<AccessibilityObject>(&object); axObject && axObject->hasDisplayContents())

stream.dumpProperty("hasDisplayContents", true);

So this should not ASSERT_NOT_REACHED in AXIsolatedObject.

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::isAccessibilityObject const): Deleted.

accessibility/isolatedtree/AXIsolatedObject.h:

5:12 PM Changeset in webkit [292084] by Devin Rousso

44 edits
1 copy
3 adds in trunk

Web Inspector: Sources: allow Response Local Overrides to map to a file on disk
https://bugs.webkit.org/show_bug.cgi?id=238236
<rdar://problem/59009154>

Reviewed by Patrick Angle.

Source/WebCore:

This makes Response Local Overrides even more powerful by allowing developers to map the
contents of the (Local Override) resource to a file on disk (e.g. a local copy of the file),
meaning that they can use their preferred editor of choice (and all the tools that may come
with it) to make changes instead of having to stay within Web Inspector.

Test: http/tests/inspector/network/local-resource-override-mapped-to-file.html

inspector/InspectorFrontendHost.idl:
inspector/InspectorFrontendHost.h:
inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canLoad): Added.
(WebCore::InspectorFrontendHost::load): Added.
(WebCore::InspectorFrontendHost::getPath): Added.
Add helpers for loading the contents of a file on disk and getting the full path of a File.

inspector/InspectorFrontendClient.h:
inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canLoad): Added.
(WebCore::InspectorFrontendClientLocal::load): Added.
Do not allow file mapping in tests (and WK1).

testing/Internals.idl:
testing/Internals.h:
testing/Internals.cpp:

(WebCore::Internals::createTemporaryFile): Added.
Add a way for tests to create a temporary file with given contents.

Source/WebInspectorUI:

UserInterface/Models/LocalResource.js:

(WI.LocalResource):
(WI.LocalResource.canMapToFile): Added.
(WI.LocalResource.prototype.toJSON):
(WI.LocalResource.prototype.get mappedFilePath): Added.
(WI.LocalResource.prototype.set mappedFilePath): Added.
(WI.LocalResource.prototype.async requestContent):
(WI.LocalResource.prototype.async _loadFromFileSystem): Added.

UserInterface/Models/LocalResourceOverride.js:

(WI.LocalResourceOverride.prototype.get canMapToFile): Added.
Save the given local file path as a member variable and use InspectorFrontendHost.load to
grab its contents (saving it inside the WI.LocalResource so that it can still be used in
case the file is moved/deleted) whenever anyone requestContent.

UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView):
(WI.ResourceContentView.prototype.get navigationItems):
(WI.ResourceContentView.prototype.showMessage):
(WI.ResourceContentView.prototype.addIssue):
(WI.ResourceContentView.prototype._contentAvailable):
(WI.ResourceContentView.prototype.async _handleMapLocalResourceOverrideToFile): Added.
(WI.ResourceContentView.prototype._handleMappedFilePathChanged): Added.
Add a new "[Disk.svg] Map to File" navigation item when viewing Response Local Overrides. If
the Response Local Override has already been mapped to a file, show the path of the file
instead of the contents of the resource. This allows us to not have to monitor the file for
changes, instead only grabbing the current contents when necessary (i.e. when replacing the
response of an intercepted network request).

UserInterface/Views/ResourceContentView.css: Added.

(.content-view.resource > .local-resource-override-label-view + .message-text-view):
Still show the Local Override banner if the Local Override has been mapped to a file.

UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype._contentWillPopulate):
Don't show the WI.SourceCodeTextEditor if there's already something else being shown.

UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype.async responseIntercepted):
Make sure to requestContent before using the currentRevision so that any file-mapped
WI.LocalResource have a chance to load from disk before handling the interception.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:
UserInterface/Images/Disk.svg: Added.

Source/WebKit:

WebProcess/Inspector/WebInspectorUI.h:
WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::load): Added.
(WebKit::WebInspectorUI::canLoad): Added.

WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::canLoad): Added.

WebProcess/Inspector/mac/WebInspectorUIMac.mm:

(WebKit::WebInspectorUI::canLoad): Added.

WebProcess/Inspector/win/WebInspectorUIWin.cpp:

(WebKit::WebInspectorUI::canLoad): Added.

WebProcess/Inspector/RemoteWebInspectorUI.h:
WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::load): Added.

UIProcess/Inspector/WebInspectorUIProxy.messages.in:
UIProcess/Inspector/WebInspectorUIProxy.h:
UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::load): Added.
(WebKit::WebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::initialize): Renamed from load.
(WebKit::RemoteWebInspectorUIProxy::reopen):
(WebKit::RemoteWebInspectorUIProxy::load): Added.
(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.
Add helpers for loading the contents of a file on disk.

UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController loadForDebuggable:backendCommandsURL:]):

UIProcess/Inspector/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorProxy::initialize): Renamed from load.
(WebKit::RemoteInspectorClient::inspect):

UIProcess/Inspector/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorProxy::initialize): Renamed from load.
(WebKit::RemoteInspectorClient::inspect):
Use renamed WebKit::RemoteWebInspectorUIProxy::initialize.

LayoutTests:

http/tests/inspector/network/local-resource-override-mapped-to-file.html: Added.
http/tests/inspector/network/local-resource-override-mapped-to-file-expected.txt: Added.

TestExpectations:
platform/mac-wk1/TestExpectations:
platform/mac-wk2/TestExpectations:

Skip this test everywhere except mac-wk2.

5:08 PM Changeset in webkit [292083] by ysuzuki@apple.com

9 edits
1 delete in trunk/Source/JavaScriptCore

[JSC] Use constants buffer to load JSGlobalObject in BaselineJIT thunks
https://bugs.webkit.org/show_bug.cgi?id=238414

Reviewed by Saam Barati.

Since these thunks are only called from BaselineJIT, we can assume constants
buffer register. And since we are always using 0 index for JSGlobalObject,
we can encode this into these shared thunks directly instead of loading
CodeBlock pointer from the stack.

We also fix using OBJECT_OFFSETOF for JSGlobalObject directly. We should use
it as JSGlobalObject::offsetOfXXX to make it clean and make it annotated that
these fields are accessed by JIT.

This patch also removes UnusedPointer.h since it is no longer used.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::emitVarReadOnlyCheck):

jit/JIT.h:
jit/JITInlines.h:

(JSC::JIT::loadConstant):
(JSC::JIT::loadGlobalObject):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::valueIsFalseyGenerator):
(JSC::JIT::valueIsTruthyGenerator):
(JSC::JIT::op_throw_handlerGenerator):
(JSC::JIT::op_check_traps_handlerGenerator):

jit/JITPropertyAccess.cpp:

(JSC::JIT::slow_op_get_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_with_this_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::generateOpResolveScopeThunk):
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::emitVarInjectionCheck):

jit/UnusedPointer.h: Removed.
runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::offsetOfVarInjectionWatchpoint):
(JSC::JSGlobalObject::offsetOfVarReadOnlyWatchpoint):
(JSC::JSGlobalObject::offsetOfFunctionProtoHasInstanceSymbolFunction):

5:00 PM Changeset in webkit [292082] by rniwa@webkit.org

2 edits in trunk

Add descriptions on how to start WPT and http test servers to Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=238523

Reviewed by Chris Dumez.

Introduction.md:

4:58 PM Changeset in webkit [292081] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[Playstation] Fix build break after r292041 when ENABLE_SERVICE_WORKER is off
https://bugs.webkit.org/show_bug.cgi?id=238520

Patch by Jigen Zhou <jigen.zhou@sony.com> on 2022-03-29
Reviewed by Darin Adler.

Unreviewed build fix after r292041 / r291979 for Playsation platform builds.

UIProcess/WebsiteData/WebsiteDataStore.cpp:

4:21 PM Changeset in webkit [292080] by commit-queue@webkit.org

8 edits in trunk/Source/JavaScriptCore

[JSC][ARMv7] Cleanup GPR numbering
https://bugs.webkit.org/show_bug.cgi?id=235027

Patch by Geza Lore <Geza Lore> on 2022-03-29
Reviewed by Yusuke Suzuki.

Make the the lower order callee save register be regCS0/llint csr0.

Some of the CSR store/restore code relies on this and using a
numbering scheme consistent with other targets (that is: regCS<N> maps
to a lower number machine register than regCS<N+1>) eliminates some
ifdefs in LLInt, and hopefully will prevent hard to find issues due to
the mismatch from other targets that all follow this rule.

In the Thumb-2 instruction set, use of r0-r7 can often be encoded

using a shorter, 16-bit instruction. Swap regT4/regT5 with
regT7/regT6, so lower order temporaries (which are usually used first)
map to the lower order registers that can yield denser code. This
then simplifies BaselineJITRegisters.h, and also saves about ~1% DFG
code size.

In offlineasm, prefer low order registers for temporaries.

Also clean up baseline instanceof op implementation.

bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo):

jit/BaselineJITRegisters.h:
jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::PreferredArgumentImpl::preferredArgumentJSR):

jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::slow_op_put_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_callSlowOperationThenCheckExceptionGenerator):

llint/LowLevelInterpreter.asm:
offlineasm/arm.rb:

4:04 PM Changeset in webkit [292079] by Matt Woodrow

8 edits
2 adds in trunk

Don't mutate children during RenderGrid::computeIntrinsicLogicalWidths unless we're about to re-layout.
https://bugs.webkit.org/show_bug.cgi?id=237732

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children.html

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::advanceNextState):
(WebCore::GridTrackSizingAlgorithm::isValidTransition const):

rendering/GridTrackSizingAlgorithm.h:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):

rendering/RenderGrid.h:

computeIntrinsicLogicalWidths can re-layout children (via performGridItemsPreLayout, as well as during
the track sizing algorithm), and does so using the estimated track sizes. This can be incorrect, and if
we're not about to do a full layout on this RenderGrid, it can leave the children in an invalid state.

This caches the intrinsic sizes when we do a full layout, so that we can use these values instead when
we just want to query the RenderGrid without mutating anything.

LayoutTests:

Don't mutate children during computeIntrinsicWidth

TestExpectations:
fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children-expected.html: Added.
fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children.html: Added.
platform/ios/TestExpectations:

Marked existing WPT as passing on MacOS (since we run layout multiple times there).
Added new test for this implementation-specific bug.

3:54 PM Changeset in webkit [292078] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Use spoolers in FTL OSR exit thunk
https://bugs.webkit.org/show_bug.cgi?id=238444

Reviewed by Mark Lam.

We deploy spoolers in FTL OSR exit thunk to reduce generated code size.
This change reduces FTLOSRExit code size in JetStream2 by 35%.

Before:

FTLOSRExit: 803564 (784.730469 KB) count 363 avg size 2213

After:

FTLOSRExit: 516432 (504.328125 KB) count 362 avg size 1426

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

3:22 PM Changeset in webkit [292077] by Alan Coon

1 copy in tags/Safari-613.2.4.0.1

Tag Safari-613.2.4.0.1.

3:22 PM Changeset in webkit [292076] by Alan Coon

1 delete in tags/Safari-613.2.4.0.1

Delete tag.

3:10 PM Changeset in webkit [292075] by Patrick Angle

2 edits in trunk/Source/JavaScriptCore

Web Inspector: Add check for null entryScope in JSC::Debugger::detach
https://bugs.webkit.org/show_bug.cgi?id=238518

Reviewed by Devin Rousso.

A virtual machine may not always have an entryScope, which can occur if a JSGlobalObject is being destructed
(which will call into JSC::Debugger::Detach) before a VMEntryScope is created or after a VMEntryScope has
fallen out of scope, causing the VM's entryScope to be null again. In the original internal issue that led to
finding this, this most commonly occurred in conjunction with page refresh while the debugger was paused.

Because it is possible that we were previously paused in the VM that now has no entryScope, we should go ahead
and unpause.

debugger/Debugger.cpp:

(JSC::Debugger::detach):

2:57 PM Changeset in webkit [292074] by Alan Coon

1 copy in tags/Safari-613.2.4.1.1

Tag Safari-613.2.4.1.1.

2:57 PM Changeset in webkit [292073] by Alan Coon

1 delete in tags/Safari-613.2.4.1.1

Delete tag.

2:49 PM Changeset in webkit [292072] by mmaxfield@apple.com

8 edits
2 adds in trunk

[Cocoa] Automatically relayout the page when new fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

page/Page.cpp:

(WebCore::m_attachmentElementClient):

platform/graphics/FontCache.cpp:

(WebCore::Function<void):
(WebCore::FontCache::registerFontCacheInvalidationCallback):
(WebCore::FontCache::invalidateAllFontCaches):

platform/graphics/FontCache.h:

LayoutTests:

fast/text/install-font-style-recalc-expected.txt: Added.
fast/text/install-font-style-recalc.html: Added.

2:37 PM Changeset in webkit [292071] by Alan Coon

1 copy in tags/Safari-613.2.4.1.1

Tag Safari-613.2.4.1.1.

2:36 PM Changeset in webkit [292070] by Alan Coon

1 copy in tags/Safari-613.2.4.0.1

Tag Safari-613.2.4.0.1.

2:01 PM Changeset in webkit [292069] by commit-queue@webkit.org

14 edits in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=238506

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-03-29

platform/glib/TestExpectations:
platform/glib/css2.1/t0505-c16-descendant-01-e-expected.txt:
platform/glib/fast/lists/002-expected.txt:
platform/gtk/css1/box_properties/margin_right-expected.txt:
platform/gtk/css1/box_properties/padding_right-expected.txt:
platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
platform/gtk/fast/inline/emptyInlinesWithinLists-expected.txt:
platform/gtk/fast/lists/003-expected.txt:
platform/wpe/css1/box_properties/margin_right-expected.txt:
platform/wpe/css1/box_properties/padding_right-expected.txt:
platform/wpe/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
platform/wpe/fast/inline/emptyInlinesWithinLists-expected.txt:
platform/wpe/fast/lists/003-expected.txt:

1:57 PM Changeset in webkit [292068] by achristensen@apple.com

19 edits in trunk

Don't create directories on iOS if we are only using ephemeral storages
https://bugs.webkit.org/show_bug.cgi?id=238402
Source/WebKit:

<rdar://79639418>

Reviewed by Chris Dumez.

Since we have been giving access to those directories as long as WebKit2 has been on iOS,
this is a conservative change to only give access to the directories when using persistent storage.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::addWebsiteDataStore):

NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

NetworkProcess/NetworkProcessCreationParameters.h:
NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):

Shared/WebsiteDataStoreParameters.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::platformInitializeWebProcess):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

Tools:

Reviewed by Chris Dumez.

TestWebKitAPI/Tests/WebKitCocoa/NSAttributedStringWebKitAdditions.mm:

(TEST):

1:55 PM Changeset in webkit [292067] by achristensen@apple.com

4 edits in trunk/Source

Navigation Timing data is corrupt in WebView (UIWebView/WKWebView)
https://bugs.webkit.org/show_bug.cgi?id=186919
<rdar://41393423>

Reviewed by Simon Fraser.

Source/WebCore:

Sometimes the observed requestStart time is after the observed responseStart time.
This may be due to the device's clock changing. It may be due to something else,
but currently CFNetwork does not use a monotonic timer to gather the data.
When this happens, use the later of the two times for responseStart.

platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:53 PM Changeset in webkit [292066] by achristensen@apple.com

4 edits in branches/safari-613-branch/Source

Revert r292055

https://bugs.webkit.org/show_bug.cgi?id=186919

Source/WebCore:

I accidentally put it on a branch.

platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:39 PM Changeset in webkit [292065] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit

Add Captive Portal alert to WKWebView
https://bugs.webkit.org/show_bug.cgi?id=238326

Patch by C Lopez <clopez1@apple.com> on 2022-03-29
Reviewed by Geoffrey Garen and Brent Fulgham

When WkWebView on iOS is initialized, we call _presentCaptivePortalModeAlertIfNeeded which checks whether an alert needs to be presented or not.

UIProcess/API/ios/WKWebViewIOS.h:
UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _presentCaptivePortalModeAlertIfNeeded]):
(-[WKWebView didMoveToWindow]):

1:24 PM Changeset in webkit [292064] by don.olmstead@sony.com

6 edits in trunk

[LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
https://bugs.webkit.org/show_bug.cgi?id=238510

Reviewed by Adrian Perez de Castro.

Post v1.12.0 introduces the WPE_ENABLE_XKB definition to libwpe. For v1.12.0 and earlier
the define is added to the WPE::libwpe target's compile options. For later versions the
pkg-config for the library will determine the presence of this definition.

Source/cmake/FindWPE.cmake:

Source/WebKit:

Guard libwpe xkb code with WPE_ENABLE_XKB.

UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

Guard libwpe xkb code with WPE_ENABLE_XKB.

WebKitTestRunner/libwpe/EventSenderProxyLibWPE.cpp:

(WTR::EventSenderProxy::keyDown):

1:22 PM Changeset in webkit [292063] by Brandon

1 edit
1 move in trunk/Source/bmalloc

Rename Libpas README to README.md
https://bugs.webkit.org/show_bug.cgi?id=238517

Reviewed by Yusuke Suzuki.

Libpas README does not correctly display markdown output on github.com
without .md file extension.

libpas/ReadMe.md: Renamed from Source/bmalloc/libpas/README.

1:18 PM Changeset in webkit [292062] by Russell Epstein

9 edits in branches/safari-614.1.7-branch/Source

Versioning.

WebKit-7614.1.7.4

1:15 PM Changeset in webkit [292061] by Matteo Flores

2 edits in trunk/LayoutTests

REGRESSION(r290898?): [ iOS ] animations/shadow-host-child-change.html is a flaky image failure
https://bugs.webkit.org/show_bug.cgi?id=238519

Unreviewed test gardening.

platform/ios/TestExpectations:

1:06 PM Changeset in webkit [292060] by Jonathan Bedard

5 edits in trunk/Tools

[Merge-Queue] Canonicalize commit
https://bugs.webkit.org/show_bug.cgi?id=238453
<rdar://problem/90921217>

Reviewed by Dewei Zhu.

Before pushing to Subversion, we want to include the canonical
link in the commit message.

Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add Canonicalize step.

Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

Tools/CISupport/ews-build/steps.py:

(Canonicalize):
(Canonicalize.init):
(Canonicalize.doStepIf): Only canonicalize pull requests.
(Canonicalize.hideStepIf): Hide step if we aren't doing it.
(Canonicalize.run): Update the base branch, rebase the source branch
then move the base branch to the tip of the source branch. Finally,
canonicalize the new commit.
(Canonicalize.getResultSummary):

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/248995@main

12:49 PM Changeset in webkit [292059] by Fujii Hironori

5 edits
4 adds in trunk

drop-shadow filter doesn't work correctly in tiled backing layer
https://bugs.webkit.org/show_bug.cgi?id=236800
<rdar://problem/89382612>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/filter-effects/filters-drop-shadow-003-expected.html: Added.
web-platform-tests/css/filter-effects/filters-drop-shadow-003.html: Added.

Source/WebCore:

If an element with drop-shadow filter wasn't placed in the
painting rect, the drop-shadow wasn't rendered correctly. This
issue tended to be observed in tiled backing layers becuase each
tile is painted separately. But, not necessary. If an element with
drop-shadow filter was placed in the outside of view, this issue
could arise.

Tests: css3/filters/drop-shadow-in-tiled-backing.html

imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-003.html

rendering/RenderLayerFilters.cpp:

(WebCore::RenderLayerFilters::beginFilterEffect): If the
drop-shadow is cast to the right direction, dirtyRect needs to be
extended to left direction to calculate targetBoundingBox.

LayoutTests:

css3/filters/drop-shadow-in-tiled-backing-expected.html: Added.
css3/filters/drop-shadow-in-tiled-backing.html: Added.
platform/ios-wk2/TestExpectations:

12:46 PM Changeset in webkit [292058] by Russell Epstein

5 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292042. rdar://problem/90999175

Unreviewed, fix UAF after r291980

Source/WebCore:

page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:23 PM Changeset in webkit [292057] by Chris Dumez

2 edits in trunk/Source/WebCore

Use "UTF-8"_s instead of PAL::UTF8Encoding().domName()
https://bugs.webkit.org/show_bug.cgi?id=238508

Reviewed by Geoffrey Garen.

Use "UTF-8"_s instead of PAL::UTF8Encoding().domName() as it is equivalent and more efficient.

dom/Document.cpp:

(WebCore::Document::characterSetWithUTF8Fallback const):
(WebCore::Document::defaultCharsetForLegacyBindings const):

12:17 PM Changeset in webkit [292056] by Jonathan Bedard

5 edits in trunk/Tools

[Merge-Queue] Add Reviewers to ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=238396
<rdar://problem/90860335>

Reviewed by Dewei Zhu.

Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add AddReviewerToChangeLog.

Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

Tools/CISupport/ews-build/steps.py:

(AddReviewerToChangeLog.init):
(AddReviewerToChangeLog._files): List files in the pull-request.
(AddReviewerToChangeLog.run): Replace "NOBODY" with reviewers.
(AddReviewerToChangeLog.getResultSummary):
(AddReviewerToChangeLog.doStepIf): Skip step if patch or if reviewers are undefined.
(AddReviewerToChangeLog.hideStepIf): Hide step if skipped.

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/248992@main

12:15 PM Changeset in webkit [292055] by achristensen@apple.com

4 edits in branches/safari-613-branch/Source

Navigation Timing data is corrupt in WebView (UIWebView/WKWebView)
https://bugs.webkit.org/show_bug.cgi?id=186919
<rdar://41393423>

Reviewed by Simon Fraser.

Source/WebCore:

platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

12:10 PM Changeset in webkit [292054] by Alan Bujtas

2 edits in trunk/Source/WebCore

WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
https://bugs.webkit.org/show_bug.cgi?id=238465
<rdar://80630664>

Reviewed by Antti Koivisto.

The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
gridLineHeight.

rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):

12:08 PM Changeset in webkit [292053] by commit-queue@webkit.org

3 edits in trunk/Source/ThirdParty/ANGLE

Handle pkg_config and declare_args statements in gni-to-cmake.py
https://bugs.webkit.org/show_bug.cgi?id=238490

Remove these statements, since they currently must be deleted from
the resulting CMake files by hand.

Regenerate the CMake files from current ANGLE sources, to minimize
changes during the next roll.

Patch by Kenneth Russell <kbr@chromium.org> on 2022-03-29
Reviewed by Dean Jackson.

GL.cmake:
gni-to-cmake.py:

12:07 PM Changeset in webkit [292052] by Matteo Flores

3 edits in trunk/LayoutTests

[ iOS Mac ] imported/w3c/web-platform-tests/fetch/metadata/download.https.sub.html is a flaky text failure
https://bugs.webkit.org/show_bug.cgi?id=238469

Unreviewed test gardening.

platform/ios/TestExpectations:
platform/mac/TestExpectations:

11:33 AM Changeset in webkit [292051] by sihui_liu@apple.com

2 edits in trunk/Source/WebKit

Unreviewed test fix after r292024.
https://bugs.webkit.org/show_bug.cgi?id=238082
<rdar://problem/90844775>

Correcting an if condition.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processDidResume):

11:31 AM Changeset in webkit [292050] by Jonathan Bedard

5 edits in trunk/Tools

[Merge-Queue] Add Reviewers to commit message
https://bugs.webkit.org/show_bug.cgi?id=238354
<rdar://problem/90800671>

Reviewed by Dewei Zhu.

When a PR has been reviewed, Merge-Queue should insert those
reviewers into the commit message.

Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add AddReviewerToCommitMessage and ValidateCommitMessage steps.

Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

Tools/CISupport/ews-build/steps.py:

(AddReviewerMixin):
(AddReviewerMixin.environment): Set committer to action owner.
(AddReviewerMixin.reviewers): Return a combined string of all reviewers.
(AddReviewerToCommitMessage.init):
(AddReviewerToCommitMessage.start): Insert reviewer string into commit message.
(AddReviewerToCommitMessage.getResultSummary):
(AddReviewerToCommitMessage.doStepIf): Skip step if patch or if reviewers are undefined.
(AddReviewerToCommitMessage.hideStepIf): Hide step if skipped.
(ValidateCommitMessage.init):
(ValidateCommitMessage.start): List commit message for commit.
(ValidateCommitMessage.getResultSummary):
(ValidateCommitMessage.evaluateCommand):
(ValidateCommitMessage.doStepIf): Skip step if patch.
(ValidateCommitMessage.hideStepIf): Hide step if skipped.

Tools/CISupport/ews-build/steps_unittest.py:

(mock_load_contributors): Share with multiple functions.

Canonical link: https://commits.webkit.org/248986@main

11:30 AM Changeset in webkit [292049] by eric.carlson@apple.com

11 edits
2 adds in trunk

[macOS] Muted video is sometimes paused when entering fullscreen
https://bugs.webkit.org/show_bug.cgi?id=238462
rdar://89104216

Reviewed by Jer Noble.

Source/WebCore:

Test: media/fullscreen-when-muted.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didMoveToNewDocument): Add logging.
(WebCore::HTMLMediaElement::elementIsHidden const): Consider both element fullscreen
and video fullscreen.
(WebCore::HTMLMediaElement::visibilityStateChanged): Use elementIsHidden.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const): Add
logging for the one case that didn't have it.
(WebCore::HTMLMediaElement::updateMediaPlayer): New, wrap MediaPlayer functions
that are called frequently by RenderVideo so we can only call them when necessary.

html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::elementIsHidden const): Deleted.

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::visibilityChanged): Just use elementIsHidden, it
already accounts for fullscreen.

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVisibleInViewport): Do nothing when visibility is not changing.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setPageIsVisible): Add logging.

rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer): Call HTMLMediaElement::updateMediaPlayer instead
of calling MediaPlayer directly.

Source/WebKit:

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::setPageIsVisible): Track visibility and do
nothing when it doesn't change.
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio): Ditto for aspect
ratio.

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

LayoutTests:

media/fullscreen-when-muted-expected.txt: Added.
media/fullscreen-when-muted.html: Added.

11:21 AM Changeset in webkit [292048] by Alan Coon

5 edits in branches/safari-613-branch/Source

Cherry-pick r292042. rdar://problem/89434696

Unreviewed, fix UAF after r291980

Source/WebCore:

page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [292047] by Alan Coon

5 edits in branches/safari-613.2.4.0-branch/Source

Cherry-pick r292042. rdar://problem/89434696

Unreviewed, fix UAF after r291980

Source/WebCore:

page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [292046] by Alan Coon

20 edits in branches/safari-613-branch

Cherry-pick r291980. rdar://problem/89434696

[iOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=237979
<rdar://problem/89434696>

Reviewed by Tim Horton.

Source/WebCore:

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added. (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from sizeForCSSDefaultViewportUnits. (WebCore::FrameView::copyCSSViewportUnits const): Added. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.

Source/WebKit:

Recently the W3C CSS working group added [some new unit types to CSS](https://drafts.csswg.org/css-values-4/#viewport-variants)
with the goal of helping web developers better deal with browsers that have dynamic UI
elements that change apperance/size/etc. based on user actions (e.g. the URL bar
collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most
recently scrolled/swiped down the page).

These new units come in three categories:

the "large viewport" units (lvw, lvh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished")
the "small viewport" units (svw, svh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished")
the "dynamic viewport" units (dvw, dvh, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements

This way, developer could use 100svh to ensure that no matter what state the browser UI
elements are in the entire element will always be visible on the screen, or use 100dvh to
respond to browser UI element changes by automatically resizing various elements to always
fully take advantage of the available space.

Nothing needs to be added to support "dynamic viewport" dv* units as there already exists
other methods to adjust the visual area of the WKWebView without adjusting its frame
(e.g. -[WKWebView setBounds:], -[UIScrollView setContentInset:], etc.).

But for "small viewport" sv* units and "large viewport" lv* units, however, there is
unfortunately no way to tell a WKWebView anything like "this is the smallest/largest that
this WKWebView will ever be", so there's no way to know ahead of time what the size of the
visual area would be when all browser UI elements are in their smallest/largest state. As
such, this patch adds a new API to allow for WKWebView clients to tell WebKit this
information ahead of time.

Note that there already exists the concept of "default viewport" units (vw, vh, etc.)
that each represent 1% of one dimension of the size of the visual area of the page when all
browser UI elements are in their default state. The behavior of these units remain the same,
and the value can be changed via the existing -[WKWebView setFrame:].

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]): Added. (-[WKWebView setMinimumViewportInset:maximumViewportInset:]): Added.
UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _processWillSwapOrDidExit]): (-[WKWebView _frameOrBoundsChanged]): (-[WKWebView _didCompleteAnimatedResize]): (-[WKWebView _setMinimumUnobscuredSizeOverride:]): (-[WKWebView _setMaximumUnobscuredSizeOverride:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _dispatchSetMinimumUnobscuredSize:]): Deleted. (-[WKWebView _dispatchSetMaximumUnobscuredSize:]): Deleted. Recalculate the size for CSS "small viewport" sv* units whenever the frame changes. Also move the deduplication logic that prevents the same value from being sent to the WebProcess more than once to the setter methods on WebPageProxy so that it can be used by more than just iOS-only codepaths.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDefaultUnobscuredSize): Added. (WebKit::WebPageProxy::setMinimumUnobscuredSize): Added. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Added. (WebKit::WebPageProxy::creationParameters):
UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setMinimumUnobscuredSize): Deleted. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Deleted.
Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewportSizeForCSSViewportUnits): (WebKit::WebPage::setDefaultUnobscuredSize): Added. (WebKit::WebPage::setMinimumUnobscuredSize): Added. (WebKit::WebPage::setMaximumUnobscuredSize): Added. (WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Added.
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::viewportConfigurationChanged): (WebKit::WebPage::setMinimumUnobscuredSize): Deleted. (WebKit::WebPage::setMaximumUnobscuredSize): Deleted. (WebKit::WebPage::updateViewportSizeForCSSViewportUnits): Deleted. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units. Move iOS-only code to be for all platforms.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Propagate all viewport size overrides when a new FrameView is created.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: (TEST.CSSViewportUnits.NegativeMinimumViewportInset): Added. (TEST.CSSViewportUnits.NegativeMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInset): Added. (TEST.CSSViewportUnits.MaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:19 AM Changeset in webkit [292045] by Antti Koivisto

16 edits
4 adds in trunk

[CSS Container Queries] Support CSSOM
https://bugs.webkit.org/show_bug.cgi?id=238500

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt:
web-platform-tests/css/css-contain/container-queries/idlharness-expected.txt:

Source/WebCore:

Add CSSContainerRule interface.

https://drafts.csswg.org/css-contain-3/#the-csscontainerrule-interface

DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJSNewlyCreated):

css/CSSContainerRule.cpp: Added.

(WebCore::CSSContainerRule::CSSContainerRule):
(WebCore::CSSContainerRule::create):
(WebCore::CSSContainerRule::styleRuleContainer const):
(WebCore::CSSContainerRule::cssText const):
(WebCore::CSSContainerRule::conditionText const):

Implementation, the only real functionality is serialization.

css/CSSContainerRule.h: Added.
css/CSSContainerRule.idl: Added.

Interface.

css/ContainerQuery.cpp:

(WebCore::CQ::serialize):
(WebCore::serialize):

Query syntax serialization support.

css/ContainerQuery.h:
css/ContainerQueryParser.cpp:

(WebCore::ContainerQueryParser::consumeContainerQuery):

Remember the text of unknown queries.

css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper const):

LayoutTests:

TestExpectations:

11:15 AM Changeset in webkit [292044] by eric.carlson@apple.com

3 edits in trunk/Source/WebKit

Don't send sync RemoteMediaPlayerProxy messages that we know will fail
https://bugs.webkit.org/show_bug.cgi?id=238467
rdar://86662565

Reviewed by Jer Noble.

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::videoFrameForCurrentTime): Return early if
readyState is less than HaveCurrentData, or if the first frame is not available.

WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime): Ditto.
(WebKit::MediaPlayerPrivateRemote::colorSpace): Ditto.

10:55 AM Changeset in webkit [292043] by Alan Bujtas

2 edits in trunk/Source/WebCore

RenderText::width should call FontCascade directly on single space characters
https://bugs.webkit.org/show_bug.cgi?id=238484

Reviewed by Antti Koivisto.

Some "text and inline box" heavy pages (e.g. wikipedia) have the pattern of leaving one space
gap between adjacent inline boxes (<span>some content</span> <span>and some more</span>).
This patch ensures that we don't construct redundant TextRun objects (and measure their widths)
for such simple cases when applicable.

rendering/RenderText.cpp:

(WebCore::RenderText::width const):

10:37 AM Changeset in webkit [292042] by Devin Rousso

5 edits in trunk/Source

Unreviewed, fix UAF after r291980

Source/WebCore:

page/FrameView.h:

(WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added.
(WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.

page/FrameView.cpp:

(WebCore::FrameView::setSizeForCSSDefaultViewportUnits):
(WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits.
(WebCore::FrameView::setSizeForCSSSmallViewportUnits):
(WebCore::FrameView::overrideWidthForCSSSmallViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits.
(WebCore::FrameView::setSizeForCSSLargeViewportUnits):
(WebCore::FrameView::overrideWidthForCSSLargeViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits.
(WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted.
Expose OverrideViewportSize so that we can copy those members specifically instead of
having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Expose OverrideViewportSize so that we can copy those members specifically instead of
having to keep alive the old FrameView when transitioning to a new page.

10:30 AM Changeset in webkit [292041] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

[Playstation] Fix build break after r291979 if ENABLE_SERVICE_WORKER is off
https://bugs.webkit.org/show_bug.cgi?id=238471

Patch by Jigen Zhou <jigen.zhou@sony.com> on 2022-03-29
Reviewed by Don Olmstead.

Build fix for playstation platform after r291979 to support ServiceWorkerClients.openWindow.
This patch resolves compiling errors occurs in WebPageProxy::callLoadCompletionHandlersIfNecessary
if ENABLE_SERVICE_WORKER is off.

UIProcess/WebPageProxy.cpp:

10:29 AM Changeset in webkit [292040] by Russell Epstein

7 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292035. rdar://problem/88717577

[iOS GPUProcess] Image decoding should not trigger IOSurface usage in the web process
https://bugs.webkit.org/show_bug.cgi?id=238489
<rdar://88717577>

Reviewed by Per Arne Vollan.

Source/WebCore:

When hardwareAcceleratedDecodingDisabled() has been called, turn off hardware acceleration
for image decoding.

platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::createImageSourceOptions): (WebCore::ImageDecoderCG::disableHardwareAcceleratedDecoding): (WebCore::ImageDecoderCG::hardwareAcceleratedDecodingDisabled):
platform/graphics/cg/ImageDecoderCG.h:

Source/WebCore/PAL:

Expose kCGImageSourceUseHardwareAcceleration.

pal/spi/cg/ImageIOSPI.h:

Source/WebKit:

When useGPUProcessForDOMRendering is true, disable hardware image decoding since
we need to avoid IOSurface access in the web process.

WebProcess/WebProcess.cpp: (WebKit::WebProcess::setUseGPUProcessForDOMRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 AM Changeset in webkit [292039] by Russell Epstein

4 edits in branches/safari-614.1.8-branch/Source/WebCore

Cherry-pick r292026. rdar://problem/90941790

REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color
https://bugs.webkit.org/show_bug.cgi?id=238466
rdar://90941790

Reviewed by Simon Fraser.

r291771 uncovers this bug: TextBoxPainter::paintForeground() records the
glyphs to a DisplayList before settings the destination GraphicsContext.

The fix is to apply all the changes to the GraphicsContext before calling
TextPainter::setGlyphDisplayListIfNeeded().

Delete TextPainter::paint() because it is not used.

Initialize TextPainter with a reference to FontCascade.

rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::paintForeground):
rendering/TextPainter.cpp: (WebCore::TextPainter::TextPainter): (WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded): (WebCore::TextPainter::paintRange): (WebCore::TextPainter::paint): Deleted.
rendering/TextPainter.h: (WebCore::TextPainter::setShadowColorFilter): (WebCore::TextPainter::setGlyphDisplayListIfNeeded): (WebCore::TextPainter::setFont): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 AM Changeset in webkit [292038] by Russell Epstein

8 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292010. rdar://problem/89559929

Disable custom storage paths for IndexedDB and LocalStorage by default
https://bugs.webkit.org/show_bug.cgi?id=236977
<rdar://problem/89559929>

Reviewed by Geoffrey Garen.

Source/WebKit:

Developers can enable them by disabling "general directory for storage" via internal debug feature or system
feature flag.

FeatureFlags/WebKit-appletvos.plist:
FeatureFlags/WebKit-ios.plist:
FeatureFlags/WebKit-macos.plist:
FeatureFlags/WebKit-watchos.plist:
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::internalFeatureEnabled): (WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths):

Source/WTF:

Add an internal debug feature for using genreal directory for storage.

Scripts/Preferences/WebPreferencesInternal.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:26 AM Changeset in webkit [292037] by Patrick Angle

16 edits in trunk/Source

Web Inspector: [Cocoa] Indicate a request was sent through proxy/private relay in Network tab
https://bugs.webkit.org/show_bug.cgi?id=233202

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Add new isProxyConnection property to network metrics protocol object.

inspector/protocol/Network.json:

Source/WebCore:

Add plumbing for the new isProxyConnection network metric.

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForMetrics):

platform/network/NetworkLoadMetrics.cpp:

(WebCore::AdditionalNetworkLoadMetricsForWebInspector::isolatedCopy):

platform/network/NetworkLoadMetrics.h:

(WebCore::AdditionalNetworkLoadMetricsForWebInspector::encode const):
(WebCore::AdditionalNetworkLoadMetricsForWebInspector::decode):

Source/WebInspectorUI:

For resources that are sent through a proxy or relay (like iCloud Private Relay), the remoteAddress will be that
of the proxy or relay server, not the server that provided the page to the proxy or relay. To indicate this, we
now append (Proxy) to these remote IP addresses in Web Inspector so that it is clearer what server the remote
address actually represents in these cases.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Models/LocalResource.js:
UserInterface/Models/Resource.js:

(WI.Resource.prototype.get displayRemoteAddress):

Similar to displayName and displayURL which provide user-facing strings, add a displayRemoteAddress that

will denote the address is a proxy if applicable.

(WI.Resource.prototype.updateWithMetrics):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._entryForResource):

UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):

UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):

UserInterface/Views/ResourceTimelineDataGridNode.js:

(WI.ResourceTimelineDataGridNode.prototype.get data):

Source/WebKit:

Add plumbing for the new isProxyConnection network metric.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

10:21 AM Changeset in webkit [292036] by Brandon

3 edits in trunk/Source/WebCore

Need to add ISO annotations to GPUUncapturedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=238512

Reviewed by Yusuke Suzuki.

ISO annotations are required in GPUUncapturedErrorEvent for proper initialization.

Modules/WebGPU/GPUUncapturedErrorEvent.cpp:
Modules/WebGPU/GPUUncapturedErrorEvent.h:

(WebCore::GPUUncapturedErrorEvent::create): Deleted.
(WebCore::GPUUncapturedErrorEvent::backing): Deleted.
(WebCore::GPUUncapturedErrorEvent::backing const): Deleted.
(WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent): Deleted.

10:05 AM Changeset in webkit [292035] by Simon Fraser

7 edits in trunk/Source

[iOS GPUProcess] Image decoding should not trigger IOSurface usage in the web process
https://bugs.webkit.org/show_bug.cgi?id=238489
<rdar://88717577>

Reviewed by Per Arne Vollan.

Source/WebCore:

When hardwareAcceleratedDecodingDisabled() has been called, turn off hardware acceleration
for image decoding.

platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions):
(WebCore::ImageDecoderCG::disableHardwareAcceleratedDecoding):
(WebCore::ImageDecoderCG::hardwareAcceleratedDecodingDisabled):

platform/graphics/cg/ImageDecoderCG.h:

Source/WebCore/PAL:

Expose kCGImageSourceUseHardwareAcceleration.

pal/spi/cg/ImageIOSPI.h:

Source/WebKit:

When useGPUProcessForDOMRendering is true, disable hardware image decoding since
we need to avoid IOSurface access in the web process.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setUseGPUProcessForDOMRendering):

8:54 AM Changeset in webkit [292034] by Brandon

2 edits in trunk/Source/WebCore

Check page exists before trying to access authenticatorCoordinator
https://bugs.webkit.org/show_bug.cgi?id=238507

Reviewed by Brent Fulgham.

Check we have a valid page before trying to access the authenticatorCoordinator.

Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

8:54 AM Changeset in webkit [292033] by Sam Sneddon

6 edits
116 copies
131 adds
1 delete in trunk/LayoutTests

Re-import web-platform-tests/css/css-conditional
https://bugs.webkit.org/show_bug.cgi?id=237896

Reviewed by Tim Nguyen.

This used to be web-platform-tests/css/conditional, so this also
combines the rename, but is ultimately this is just an update.

LayoutTests/imported/w3c:

resources/import-expectations.json:
resources/resource-files.json:
web-platform-tests/css/conditional/LICENSE: Removed.
web-platform-tests/css/conditional/at-supports-001-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-002-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-003-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-004-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-005-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-006-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-007-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-008-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-009-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-010-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-011-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-012-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-013-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-014-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-015-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-016-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-017-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-018-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-019-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-020-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-021-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-022-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-023-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-024-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-025-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-026-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-027-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-028-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-029-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-030-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-031-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-032-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-033-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-034-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-035-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-036-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-037-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-038-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-039-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-040-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-041-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-042-expected.html: Removed.
web-platform-tests/css/conditional/at-supports-043-expected.html: Removed.
web-platform-tests/css/conditional/reference/background-lime.html: Removed.
web-platform-tests/css/conditional/test_group_insertRule-expected.txt: Removed.
web-platform-tests/css/conditional/test_group_insertRule.html: Removed.
web-platform-tests/css/css-conditional/META.yml: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/META.yml.
web-platform-tests/css/css-conditional/at-media-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-001.html: Added.
web-platform-tests/css/css-conditional/at-media-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-002.html: Added.
web-platform-tests/css/css-conditional/at-media-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-003.html: Added.
web-platform-tests/css/css-conditional/at-media-content-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-content-001.html: Added.
web-platform-tests/css/css-conditional/at-media-content-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-content-002.html: Added.
web-platform-tests/css/css-conditional/at-media-content-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-content-003.html: Added.
web-platform-tests/css/css-conditional/at-media-content-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-content-004.html: Added.
web-platform-tests/css/css-conditional/at-media-dynamic-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-media-dynamic-001.html: Added.
web-platform-tests/css/css-conditional/at-media-whitespace-optional-001-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-001-expected.html.
web-platform-tests/css/css-conditional/at-media-whitespace-optional-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-001.html.
web-platform-tests/css/css-conditional/at-media-whitespace-optional-002-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-002-expected.html.
web-platform-tests/css/css-conditional/at-media-whitespace-optional-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-002.html.
web-platform-tests/css/css-conditional/at-supports-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-001.html.
web-platform-tests/css/css-conditional/at-supports-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-006.html.
web-platform-tests/css/css-conditional/at-supports-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-002.html.
web-platform-tests/css/css-conditional/at-supports-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-004.html.
web-platform-tests/css/css-conditional/at-supports-005-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-005.html.
web-platform-tests/css/css-conditional/at-supports-006-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-006.html.
web-platform-tests/css/css-conditional/at-supports-007-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-007.html.
web-platform-tests/css/css-conditional/at-supports-008-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-008.html.
web-platform-tests/css/css-conditional/at-supports-009-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-009.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-009.html.
web-platform-tests/css/css-conditional/at-supports-010-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-010.html.
web-platform-tests/css/css-conditional/at-supports-011-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-011.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-011.html.
web-platform-tests/css/css-conditional/at-supports-012-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-012.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-012.html.
web-platform-tests/css/css-conditional/at-supports-013-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-013.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-013.html.
web-platform-tests/css/css-conditional/at-supports-014-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-014.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-014.html.
web-platform-tests/css/css-conditional/at-supports-015-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-015.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-015.html.
web-platform-tests/css/css-conditional/at-supports-016-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-016.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-016.html.
web-platform-tests/css/css-conditional/at-supports-017-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-017.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-017.html.
web-platform-tests/css/css-conditional/at-supports-018-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-018.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-018.html.
web-platform-tests/css/css-conditional/at-supports-019-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-019.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-019.html.
web-platform-tests/css/css-conditional/at-supports-020-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-020.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-020.html.
web-platform-tests/css/css-conditional/at-supports-021-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-021.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-021.html.
web-platform-tests/css/css-conditional/at-supports-022-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-022.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-022.html.
web-platform-tests/css/css-conditional/at-supports-023-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-023.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-023.html.
web-platform-tests/css/css-conditional/at-supports-024-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-024.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-024.html.
web-platform-tests/css/css-conditional/at-supports-025-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-025.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-025.html.
web-platform-tests/css/css-conditional/at-supports-026-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-026.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-026.html.
web-platform-tests/css/css-conditional/at-supports-027-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
web-platform-tests/css/css-conditional/at-supports-027-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
web-platform-tests/css/css-conditional/at-supports-027.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
web-platform-tests/css/css-conditional/at-supports-028-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-028.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-028.html.
web-platform-tests/css/css-conditional/at-supports-029-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
web-platform-tests/css/css-conditional/at-supports-029.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-029.html.
web-platform-tests/css/css-conditional/at-supports-030-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-030.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-030.html.
web-platform-tests/css/css-conditional/at-supports-031-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-031.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-031.html.
web-platform-tests/css/css-conditional/at-supports-032-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-032.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-032.html.
web-platform-tests/css/css-conditional/at-supports-033-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-033.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-033.html.
web-platform-tests/css/css-conditional/at-supports-034-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-034.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-034.html.
web-platform-tests/css/css-conditional/at-supports-035-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-035.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-035.html.
web-platform-tests/css/css-conditional/at-supports-036-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-036.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-036.html.
web-platform-tests/css/css-conditional/at-supports-037-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-037.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-037.html.
web-platform-tests/css/css-conditional/at-supports-038-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-038.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-038.html.
web-platform-tests/css/css-conditional/at-supports-039-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-039.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-039.html.
web-platform-tests/css/css-conditional/at-supports-043-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-043.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-043.html.
web-platform-tests/css/css-conditional/at-supports-044-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-044.html: Added.
web-platform-tests/css/css-conditional/at-supports-045-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-045.html: Added.
web-platform-tests/css/css-conditional/at-supports-046-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-046.html: Added.
web-platform-tests/css/css-conditional/at-supports-content-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-content-001.html: Added.
web-platform-tests/css/css-conditional/at-supports-content-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-content-002.html: Added.
web-platform-tests/css/css-conditional/at-supports-content-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-content-003.html: Added.
web-platform-tests/css/css-conditional/at-supports-content-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-content-004.html: Added.
web-platform-tests/css/css-conditional/at-supports-namespace-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-namespace-001.html: Added.
web-platform-tests/css/css-conditional/at-supports-namespace-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-namespace-002.html: Added.
web-platform-tests/css/css-conditional/at-supports-selector-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-selector-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-040.html.
web-platform-tests/css/css-conditional/at-supports-selector-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-selector-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-040.html.
web-platform-tests/css/css-conditional/at-supports-selector-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-selector-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-041.html.
web-platform-tests/css/css-conditional/at-supports-selector-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
web-platform-tests/css/css-conditional/at-supports-selector-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-042.html.
web-platform-tests/css/css-conditional/css-supports-001-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-001.xht: Added.
web-platform-tests/css/css-conditional/css-supports-002-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-002.xht: Added.
web-platform-tests/css/css-conditional/css-supports-003-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-003.xht: Added.
web-platform-tests/css/css-conditional/css-supports-004-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-004.xht: Added.
web-platform-tests/css/css-conditional/css-supports-005-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-005.xht: Added.
web-platform-tests/css/css-conditional/css-supports-006-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-006.xht: Added.
web-platform-tests/css/css-conditional/css-supports-007-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-007.xht: Added.
web-platform-tests/css/css-conditional/css-supports-008-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-008.xht: Added.
web-platform-tests/css/css-conditional/css-supports-009-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-009.xht: Added.
web-platform-tests/css/css-conditional/css-supports-010-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-010.xht: Added.
web-platform-tests/css/css-conditional/css-supports-011-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-011.xht: Added.
web-platform-tests/css/css-conditional/css-supports-012-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-012.xht: Added.
web-platform-tests/css/css-conditional/css-supports-013-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-013.xht: Added.
web-platform-tests/css/css-conditional/css-supports-014-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-014.xht: Added.
web-platform-tests/css/css-conditional/css-supports-015-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-015.xht: Added.
web-platform-tests/css/css-conditional/css-supports-016-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-016.xht: Added.
web-platform-tests/css/css-conditional/css-supports-017-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-017.xht: Added.
web-platform-tests/css/css-conditional/css-supports-018-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-018.xht: Added.
web-platform-tests/css/css-conditional/css-supports-019-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-019.xht: Added.
web-platform-tests/css/css-conditional/css-supports-020-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-020.xht: Added.
web-platform-tests/css/css-conditional/css-supports-021-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-021.xht: Added.
web-platform-tests/css/css-conditional/css-supports-022-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-022.xht: Added.
web-platform-tests/css/css-conditional/css-supports-023-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-023.xht: Added.
web-platform-tests/css/css-conditional/css-supports-024-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-024.xht: Added.
web-platform-tests/css/css-conditional/css-supports-025-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-025.xht: Added.
web-platform-tests/css/css-conditional/css-supports-026-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-026.xht: Added.
web-platform-tests/css/css-conditional/css-supports-029-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-029.xht: Added.
web-platform-tests/css/css-conditional/css-supports-030-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-030.xht: Added.
web-platform-tests/css/css-conditional/css-supports-031-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-031.xht: Added.
web-platform-tests/css/css-conditional/css-supports-032-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-032.xht: Added.
web-platform-tests/css/css-conditional/css-supports-033-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-033.xht: Added.
web-platform-tests/css/css-conditional/css-supports-034-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-034.xht: Added.
web-platform-tests/css/css-conditional/css-supports-035-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-035.xht: Added.
web-platform-tests/css/css-conditional/css-supports-036-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-036.xht: Added.
web-platform-tests/css/css-conditional/css-supports-037-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-037.xht: Added.
web-platform-tests/css/css-conditional/css-supports-038-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-038.xht: Added.
web-platform-tests/css/css-conditional/css-supports-039-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-039.xht: Added.
web-platform-tests/css/css-conditional/css-supports-040-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-040.xht: Added.
web-platform-tests/css/css-conditional/css-supports-041-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-041.xht: Added.
web-platform-tests/css/css-conditional/css-supports-042-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-042.xht: Added.
web-platform-tests/css/css-conditional/css-supports-043-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-043.xht: Added.
web-platform-tests/css/css-conditional/css-supports-044-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-044.xht: Added.
web-platform-tests/css/css-conditional/css-supports-045-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-045.xht: Added.
web-platform-tests/css/css-conditional/css-supports-046-expected.xht: Added.
web-platform-tests/css/css-conditional/css-supports-046.xht: Added.
web-platform-tests/css/css-conditional/idlharness-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/idlharness-expected.txt.
web-platform-tests/css/css-conditional/idlharness.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/idlharness.html.
web-platform-tests/css/css-conditional/js/001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/js/001-expected.txt.
web-platform-tests/css/css-conditional/js/001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/js/001.html.
web-platform-tests/css/css-conditional/js/CSS-supports-CSSStyleDeclaration-expected.txt: Added.
web-platform-tests/css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html: Added.
web-platform-tests/css/css-conditional/js/CSS-supports-L3-expected.txt: Added.
web-platform-tests/css/css-conditional/js/CSS-supports-L3.html: Added.
web-platform-tests/css/css-conditional/js/CSS-supports-L4-expected.txt: Added.
web-platform-tests/css/css-conditional/js/CSS-supports-L4.html: Added.
web-platform-tests/css/css-conditional/js/conditional-CSSGroupingRule-expected.txt: Added.
web-platform-tests/css/css-conditional/js/conditional-CSSGroupingRule.html: Added.
web-platform-tests/css/css-conditional/js/w3c-import.log: Added.
web-platform-tests/css/css-conditional/support/at-media-dynamic-001-inner.html: Added.
web-platform-tests/css/css-conditional/support/fail.css: Added.

(*):

web-platform-tests/css/css-conditional/support/pass.xht: Added.
web-platform-tests/css/css-conditional/support/w3c-import.log: Added.
web-platform-tests/css/css-conditional/w3c-import.log: Added.

LayoutTests:

TestExpectations:

8:48 AM Changeset in webkit [292032] by Wenson Hsieh

8 edits in trunk

HTMLAttachmentElement.getAttachmentIdentifier() should propagate attachment data to the client
https://bugs.webkit.org/show_bug.cgi?id=238473
rdar://90938796

Reviewed by Devin Rousso.

Source/WebCore:

In the case where a WebKit client that has enabled the attachment element uses
HTMLAttachmentElement.getAttachmentIdentifier on an image element to create a new attachment-backed image, we
currently propagate an empty _WKAttachment to the UI delegate in the UI process, even in the case where the
image element has a visible image that has been loaded.

To support plain-text editing mode, Mail needs to be able to call getAttachmentIdentifier to create attachment
elements for images that already contain images with blob sources, but are inserted into the document via
JavaScript (as opposed to native editing code).

To make this work, we plumb the image element itself through the registerAttachmentIdentifier method that
currently only takes a single attachment identifier, and use it to send the image data, image name, and MIME
type to the attachment client if the image has a loaded image; otherwise, we fall back to creating and surfacing
an empty _WKAttachment to the client.

Test: WKAttachmentTests.CreateAttachmentsFromExistingImage

dom/Document.cpp:

(WebCore::Document::registerAttachmentIdentifier):

dom/Document.h:
editing/Editor.cpp:

(WebCore::Editor::registerAttachmentIdentifier):

editing/Editor.h:
html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::getAttachmentIdentifier):

Tools:

Add a new API test to exercise the fix.

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

8:17 AM WebKitGTK/2.36.x edited by magomez@igalia.com

(diff)

7:31 AM Changeset in webkit [292031] by don.olmstead@sony.com

3 edits
1 copy
1 add
1 delete in trunk/Source/WebKit

Share WebAutomationSession among USE(LIBWPE) ports
https://bugs.webkit.org/show_bug.cgi?id=238470

Reviewed by Adrian Perez de Castro.

Rename WebAutomationSessionWPE.cpp to WebAutomationSessionLibWPE since its just using the
libWPE API. Remove glib specific code in WebAutomationSession::platformSimulateKeySequence
to use a StringView::codePoints. The same code was in GTK so replace that as well.

SourcesWPE.txt:
UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeySequence):

UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp: Renamed from Source/WebKit/UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp.

(WebKit::WebAutomationSession::platformSimulateKeySequence):

7:23 AM Changeset in webkit [292030] by Alan Bujtas

3 edits in trunk/LayoutTests

Make fast/repaint/list-item-equal-style-change-no-repaint.html less prone to flakiness
https://bugs.webkit.org/show_bug.cgi?id=238480

Reviewed by Simon Fraser.

Use Internals::layoutCount to check whether animation triggers layout.

fast/repaint/list-item-equal-style-change-no-repaint-expected.txt:
fast/repaint/list-item-equal-style-change-no-repaint.html:

5:24 AM Changeset in webkit [292029] by ntim@apple.com

4 edits in trunk

Use Canvas/CanvasText system colors for <dialog> default styling
https://bugs.webkit.org/show_bug.cgi?id=238425

Reviewed by Antti Koivisto.

Per HTML spec change: https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
Main change is that the colors now adapt to dark mode by default.

LayoutTests/imported/w3c:

Updated test result to pass.

web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:

Source/WebCore:

Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html

css/dialog.css:

(dialog):

5:21 AM Changeset in webkit [292028] by ntim@apple.com

4 edits
40 moves
4 adds in trunk/LayoutTests

Re-import inert and <dialog> WPT
https://bugs.webkit.org/show_bug.cgi?id=238502

Reviewed by Antti Koivisto.

Upstream commit: https://github.com/web-platform-tests/wpt/commit/46e50fc357127c76c898675cd30ae34090a2268d

Main changes:

Removes .tentative.html suffix from inert tests
Adds default-color.html test for <dialog>

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt: Added.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html: Added.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.tentative-expected.txt.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.tentative.html.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt: Added.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection.html: Added.
web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
web-platform-tests/inert/dynamic-inert-on-focused-element-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/dynamic-inert-on-focused-element.tentative-expected.txt.
web-platform-tests/inert/dynamic-inert-on-focused-element.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/dynamic-inert-on-focused-element.tentative.html.
web-platform-tests/inert/inert-and-contenteditable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt.
web-platform-tests/inert/inert-and-contenteditable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative.html.
web-platform-tests/inert/inert-canvas-fallback-content-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-canvas-fallback-content.tentative-expected.txt.
web-platform-tests/inert/inert-canvas-fallback-content.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-canvas-fallback-content.tentative.html.
web-platform-tests/inert/inert-does-not-match-disabled-selector-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative-expected.txt.
web-platform-tests/inert/inert-does-not-match-disabled-selector.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative.html.
web-platform-tests/inert/inert-iframe-hittest-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt.
web-platform-tests/inert/inert-iframe-hittest.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative.html.
web-platform-tests/inert/inert-iframe-tabbing-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt.
web-platform-tests/inert/inert-iframe-tabbing.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative.html.
web-platform-tests/inert/inert-in-shadow-dom-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-in-shadow-dom.tentative-expected.txt.
web-platform-tests/inert/inert-in-shadow-dom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-in-shadow-dom.tentative.html.
web-platform-tests/inert/inert-inlines-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines.tentative-expected.txt.
web-platform-tests/inert/inert-inlines.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines.tentative.html.
web-platform-tests/inert/inert-label-focus-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-label-focus.tentative-expected.txt.
web-platform-tests/inert/inert-label-focus.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-label-focus.tentative.html.
web-platform-tests/inert/inert-node-is-uneditable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt.
web-platform-tests/inert/inert-node-is-uneditable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative.html.
web-platform-tests/inert/inert-node-is-unfocusable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.tentative-expected.txt.
web-platform-tests/inert/inert-node-is-unfocusable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.tentative.html.
web-platform-tests/inert/inert-node-is-unselectable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unselectable.tentative-expected.txt.
web-platform-tests/inert/inert-node-is-unselectable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unselectable.tentative.html.
web-platform-tests/inert/inert-on-non-html-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html.tentative-expected.txt.
web-platform-tests/inert/inert-on-non-html.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html.tentative.html.
web-platform-tests/inert/inert-on-slots-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-slots.tentative-expected.txt.
web-platform-tests/inert/inert-on-slots.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-slots.tentative.html.
web-platform-tests/inert/inert-svg-hittest-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt.
web-platform-tests/inert/inert-svg-hittest.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative.html.
web-platform-tests/inert/inert-with-modal-dialog-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-001.tentative-expected.txt.
web-platform-tests/inert/inert-with-modal-dialog-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-001.tentative.html.
web-platform-tests/inert/inert-with-modal-dialog-002-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-002.tentative-expected.txt.
web-platform-tests/inert/inert-with-modal-dialog-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-002.tentative.html.
web-platform-tests/inert/w3c-import.log:

LayoutTests:

platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt.
platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt.
platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt.
platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt.

4:40 AM Changeset in webkit [292027] by youenn@apple.com

23 edits in trunk/Source

RealtimeMediaSource::Type::Video is misleading as it is actually referring to camera sources
https://bugs.webkit.org/show_bug.cgi?id=238449

Reviewed by Eric Carlson.

Source/WebCore:

Make RealtimeMediaSource::Type a boolean (audio or video) and use deviceType wherever more fine grained information is needed.
No change of behavior.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::getAudioTracks const):
(WebCore::MediaStream::getVideoTracks const):

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind const):
(WebCore::MediaStreamTrack::setContentHint):
(WebCore::updateVideoCaptureAccordingMicrophoneInterruption):
(WebCore::trackTypeForMediaProducerCaptureKind):
(WebCore::MediaStreamTrack::endCapture):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::isCapturingAudio const):

Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::isVideo const):
(WebCore::MediaStreamTrack::isAudio const):
(WebCore::MediaStreamTrack::hasVideo const): Deleted.
(WebCore::MediaStreamTrack::hasAudio const): Deleted.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::mediaStreamDidFail): Deleted.

Modules/mediastream/UserMediaRequest.h:
Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::createSourceAndRTCTrack):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::updateTracksOfKind):

platform/mediarecorder/MediaRecorderPrivate.cpp:

(WebCore::MediaRecorderPrivate::selectTracks):

platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasVideo const):
(WebCore::MediaStreamPrivate::hasAudio const):
(WebCore::MediaStreamPrivate::updateActiveVideoTrack):
(WebCore::MediaStreamPrivate::monitorOrientation):

platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::type const): Deleted.

platform/mediastream/MediaStreamTrackPrivate.h:
platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::convertEnumerationToString):

platform/mediastream/RealtimeMediaSource.h:
platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::DisplayCaptureSourceCocoa):
(WebCore::sourceTypeForDevice): Deleted.

platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
testing/Internals.cpp:

(WebCore::Internals::stopObservingRealtimeMediaSource):
(WebCore::Internals::observeMediaStreamTrack):

Source/WebKit:

Shared/WebCoreArgumentCoders.h:
UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):

WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::toSourceType):

2:43 AM Changeset in webkit [292026] by Said Abou-Hallawa

4 edits in trunk/Source/WebCore

REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color
https://bugs.webkit.org/show_bug.cgi?id=238466
rdar://90941790

Reviewed by Simon Fraser.

r291771 uncovers this bug: TextBoxPainter::paintForeground() records the
glyphs to a DisplayList before settings the destination GraphicsContext.

The fix is to apply all the changes to the GraphicsContext before calling
TextPainter::setGlyphDisplayListIfNeeded().

Delete TextPainter::paint() because it is not used.

Initialize TextPainter with a reference to FontCascade.

rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::paintForeground):

rendering/TextPainter.cpp:

(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintRange):
(WebCore::TextPainter::paint): Deleted.

rendering/TextPainter.h:

(WebCore::TextPainter::setShadowColorFilter):
(WebCore::TextPainter::setGlyphDisplayListIfNeeded):
(WebCore::TextPainter::setFont): Deleted.

12:59 AM Changeset in webkit [292025] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[GTK][WPE] Use GBMBufferSwapchain in GraphicsContextGLTextureMapperANGLE
https://bugs.webkit.org/show_bug.cgi?id=237883

Patch by Zan Dobersek <zdobersek@igalia.com> on 2022-03-29
Reviewed by Alejandro G. Castro.

Use the generic GBMBufferSwapchain for managing dmabuf-based buffer
objects in GraphicsContextGLTextureMapperANGLE. This usage is guarded
behind the USE(TEXTURE_MAPPER_DMABUF) build guards.

When that build guard is enabled, we can avoid using additional textures
but instead have to manage a GBMBufferSwapchain instance from which we
can retrieve buffers that should be acting as backing for the different
draw operations.

This buffer setup is handled in the
GraphicsContextGLTextureMapperANGLE::makeContextCurrent() method. Once
called, if there's a swapchain available (after initial or each
subsequent backing reshaping) a buffer will be retrieved from that
swapchain, a corresponding EGLImage created and associated to the GL
texture that acts as the color attachment for the default buffer. All
subsequent drawing will be done onto this buffer object, all the way
to the prepareForDisplay() method where that buffer is moved into the
display-buffer position, waiting for the display to occur.

The display of this buffer is still handled in Nicosia::GCGLANGLELayer.
In the swapBuffersIfNeeded() method, if the pending buffer is detected,
the dmabuf information is pushed into the
TextureMapperPlatformLayerProxyDMABuf instance and prepared for
presentation.

No new tests -- covered by existing tests, where the ANGLE-backed
GraphicsContextGL continues to improve the overall state of WebGL tests.
Only problem is the software-backed rasterization in the WPE/GTK testing
tooling which disables a few features and to a degree breaks WebGL
content display, but this specific issue will be resolved later.

platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:

(Nicosia::GCGLANGLELayer::swapBuffersIfNeeded):
(Nicosia::GCGLANGLELayer::GCGLANGLELayer):

platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h:
platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
(WebCore::GraphicsContextGLTextureMapperANGLE::~GraphicsContextGLTextureMapperANGLE):
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitializeContext):
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitialize):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareTexture):
(WebCore::GraphicsContextGLTextureMapperANGLE::reshapeDisplayBufferBacking):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay):
(WebCore::GraphicsContextGLTextureMapperANGLE::Swapchain::Swapchain):
(WebCore::GraphicsContextGLTextureMapperANGLE::Swapchain::~Swapchain):
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::EGLImageBacking): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::~EGLImageBacking): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::format const): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::stride const): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::releaseResources): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::isReleased): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::reset): Deleted.

platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:

Mar 28, 2022:

10:54 PM Changeset in webkit [292024] by sihui_liu@apple.com

20 edits in trunk/Source/WebKit

Add logging about process entering background to NetworkProcess::processDidResume
https://bugs.webkit.org/show_bug.cgi?id=238082
<rdar://problem/90844775>

Reviewed by Chris Dumez.

In rdar://82412733, we found network process can be suspended right after it receives processDidResume message.
For network process, processDidResume means process is not suspended and it is safe to perform database
operations. Let's add logging to check when and why processDidResume message is sent. If the logging confirms
that processDidResume message can be received when process is close to assertion timeout, we probably want to
ignore such message and resume database operations when application actually enters foreground.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::applicationDidEnterBackground):
(WebKit::NetworkProcess::applicationWillEnterForeground):
(WebKit::NetworkProcess::processDidResume):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
NetworkProcess/ios/NetworkProcessIOS.mm:
UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _processDidResumeForTesting]):

UIProcess/Cocoa/DownloadProxyMapCocoa.mm:

(WebKit::DownloadProxyMap::platformCreate):
(WebKit::DownloadProxyMap::platformDestroy):

UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::applicationDidEnterBackground): Deleted.
(WebKit::DownloadProxyMap::applicationWillEnterForeground): Deleted.

UIProcess/Downloads/DownloadProxyMap.h:

(WebKit::DownloadProxyMap::isEmpty const):

UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::sendProcessDidResume):

UIProcess/GPU/GPUProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::~NetworkProcessProxy):
(WebKit::NetworkProcessProxy::synthesizeAppIsBackground):
(WebKit::NetworkProcessProxy::sendProcessDidResume):
(WebKit::NetworkProcessProxy::applicationDidEnterBackground):
(WebKit::NetworkProcessProxy::applicationWillEnterForeground):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxyCocoa.mm:

(WebKit::NetworkProcessProxy::addBackgroundStateObservers):
(WebKit::NetworkProcessProxy::removeBackgroundStateObservers):

UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionIfNeeded):

UIProcess/ProcessThrottlerClient.h:
UIProcess/WebAuthentication/WebAuthnProcessProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::sendProcessDidResume):

UIProcess/WebProcessProxy.h:
UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::sendNetworkProcessDidResume):

9:33 PM Changeset in webkit [292023] by Russell Epstein

3 edits in branches/safari-614.1.8-branch/Source/WebKit

Cherry-pick r291982. rdar://problem/90927474

[iOS] Fix sandbox violation related to Network content filtering
https://bugs.webkit.org/show_bug.cgi?id=238458
<rdar://90927474>

Reviewed by Brent Fulgham.

After enabling Network content filtering in the Network process, a related sandbox rule should
be moved to the Network process' sandbox.

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:35 PM Changeset in webkit [292022] by Alan Bujtas

4 edits in trunk

[ macOS & Win ] fast/repaint/list-item-equal-style-change-no-repaint.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215723
<rdar://problem/67520729>

Reviewed by Simon Fraser.

Source/WebCore:

animation/KeyframeEffect.h:

LayoutTests:

platform/mac/TestExpectations:

8:06 PM Changeset in webkit [292021] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
https://bugs.webkit.org/show_bug.cgi?id=238477

Patch by Ada Chan <adachan@apple.com> on 2022-03-28
Reviewed by Dean Jackson.

Without this extension, EGLImageTargetTexture2DOES() will fail
in GraphicsContextGLCocoa::attachIOSurfaceToSharedTexture().

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::makeXRCompatible):

7:04 PM Changeset in webkit [292020] by Lauro Moura

2 edits in trunk/Source/WebCore

Unreviewed, non-unified buildfix after 248938@main
https://bugs.webkit.org/show_bug.cgi?id=238478

workers/service/server/SWServerToContextConnection.h:

6:20 PM Changeset in webkit [292019] by Lauro Moura

5 edits
1 add in trunk

[AT-SPI] accessibility/native-text-control-attributed-string.html is failing
https://bugs.webkit.org/show_bug.cgi?id=237821

Reviewed by Carlos Garcia Campos.

Tools:

WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::AccessibilityUIElement::attributedStringForRange): Check the
validity of the passed range.

LayoutTests:

platform/gtk/TestExpectations:
platform/gtk/accessibility/native-text-control-attributed-string-expected.txt: Added.
platform/wpe/TestExpectations:

6:16 PM Changeset in webkit [292018] by Nikos Mouchtaris

4 edits in trunk

Clamp degenerate calc() values for <angle>
https://bugs.webkit.org/show_bug.cgi?id=238401

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-values/calc-infinity-nan-computed-expected.txt:

Source/WebCore:

Clamp nan, infinity and -infinity to zero for <angle>. Issue discussing this:
https://github.com/w3c/csswg-drafts/issues/6105.

css/calc/CSSCalcValue.cpp:

(WebCore::CSSCalcValue::clampToPermittedRange const):

6:14 PM Changeset in webkit [292017] by Russell Epstein

7 edits in branches/safari-614.1.8-branch

Cherry-pick r292007. rdar://problem/90602918

[macOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=238173
<rdar://problem/90602918>

Reviewed by Wenson Hsieh.

Source/WebKit:

See <https://webkit.org/b/237979> for information about this API. This change just also
enables it on macOS (the other change was iOS-only).

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.mm:
UIProcess/API/mac/WKWebViewMac.mm: (-[WKWebView setFrameSize:]): Remove the #if PLATFORM(IOS_FAMILY) around all things related to -[WKWebview setMinimumViewportInset:maximumViewportInset:].

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: Enable tests for -[WKWebView setMinimumViewportInset:maximumViewportInset:] on macOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@292007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:40 PM Changeset in webkit [292016] by Alan Coon

1 copy in tags/Safari-613.1.17.0.9

Tag Safari-613.1.17.0.9.

5:26 PM Changeset in webkit [292015] by Alan Coon

5 edits
2 adds in branches/safari-613-branch

Cherry-pick r291622. rdar://problem/90935942

Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170

Reviewed by Eric Carlson.

Source/WebCore:

Test: fetch/fetch-blob-unbounded-range.html

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess):

Source/WebKit:

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

LayoutTests:

fetch/fetch-blob-unbounded-range-expected.txt: Added.
fetch/fetch-blob-unbounded-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:23 PM Changeset in webkit [292014] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Clean up some 32bit load/store with 64bit load/store
https://bugs.webkit.org/show_bug.cgi?id=238440

Reviewed by Mark Lam.

On OSR entry, we should copy values from scratch to stack via loadValue / storeValue instead of 32bit load/store.
We should initialize tail-call's argumentCountIncludingThis slot via store64.

dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::prepareAny):

5:22 PM Changeset in webkit [292013] by Matteo Flores

2 edits in trunk/LayoutTests

[ iPadOS ] 3 svg/filters/* tests are constant image failures
https://bugs.webkit.org/show_bug.cgi?id=237689

Unreviewed test gardening.

platform/ipad/TestExpectations:

5:14 PM Changeset in webkit [292012] by Alan Coon

5 edits
2 adds in branches/safari-613.2.4.0-branch

Cherry-pick r291622. rdar://problem/90935942

Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170

Reviewed by Eric Carlson.

Source/WebCore:

Test: fetch/fetch-blob-unbounded-range.html

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess):

Source/WebKit:

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

LayoutTests:

fetch/fetch-blob-unbounded-range-expected.txt: Added.
fetch/fetch-blob-unbounded-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:13 PM Changeset in webkit [292011] by Alan Coon

5 edits
2 adds in branches/safari-613.2.4.1-branch

Cherry-pick r291622. rdar://problem/90935942

Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170

Reviewed by Eric Carlson.

Source/WebCore:

Test: fetch/fetch-blob-unbounded-range.html

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess):

Source/WebKit:

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

LayoutTests:

fetch/fetch-blob-unbounded-range-expected.txt: Added.
fetch/fetch-blob-unbounded-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:00 PM Changeset in webkit [292010] by sihui_liu@apple.com

8 edits in trunk/Source

Disable custom storage paths for IndexedDB and LocalStorage by default
https://bugs.webkit.org/show_bug.cgi?id=236977
<rdar://problem/89559929>

Reviewed by Geoffrey Garen.

Source/WebKit:

Developers can enable them by disabling "general directory for storage" via internal debug feature or system
feature flag.

FeatureFlags/WebKit-appletvos.plist:
FeatureFlags/WebKit-ios.plist:
FeatureFlags/WebKit-macos.plist:
FeatureFlags/WebKit-watchos.plist:
UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::internalFeatureEnabled):
(WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths):

Source/WTF:

Add an internal debug feature for using genreal directory for storage.

Scripts/Preferences/WebPreferencesInternal.yaml:

4:48 PM Changeset in webkit [292009] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

The lazy symbolObjectStructure should be realized before we allocate a SymbolObject.
https://bugs.webkit.org/show_bug.cgi?id=238474
<rdar://problem/90918765>

Reviewed by Yusuke Suzuki and Saam Barati.

We should not be allocating the symbolObjectStructure while in the middle of
initializing a SymbolObject.

runtime/Symbol.cpp:

(JSC::Symbol::toObject const):
(JSC::SymbolObject::create): Deleted.

runtime/SymbolObject.h:

4:31 PM Changeset in webkit [292008] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Unreviewed, reverting r291728.
https://bugs.webkit.org/show_bug.cgi?id=238476

causing crashes in tests

Reverted changeset:

"Expand autocorrect context for more accurate results."
https://bugs.webkit.org/show_bug.cgi?id=237990
https://commits.webkit.org/r291728

4:28 PM Changeset in webkit [292007] by Devin Rousso

7 edits in trunk

[macOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=238173
<rdar://problem/90602918>

Reviewed by Wenson Hsieh.

Source/WebKit:

See <https://webkit.org/b/237979> for information about this API. This change just also
enables it on macOS (the other change was iOS-only).

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.mm:
UIProcess/API/mac/WKWebViewMac.mm:

(-[WKWebView setFrameSize:]):
Remove the #if PLATFORM(IOS_FAMILY) around all things related to -[WKWebview setMinimumViewportInset:maximumViewportInset:].

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:

Enable tests for -[WKWebView setMinimumViewportInset:maximumViewportInset:] on macOS.

4:27 PM Changeset in webkit [292006] by Alan Coon

20 edits in branches/safari-613.2.4.0-branch

Cherry-pick r291980. rdar://problem/89434696

[iOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=237979
<rdar://problem/89434696>

Reviewed by Tim Horton.

Source/WebCore:

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added. (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from sizeForCSSDefaultViewportUnits. (WebCore::FrameView::copyCSSViewportUnits const): Added. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.

Source/WebKit:

Recently the W3C CSS working group added [some new unit types to CSS](https://drafts.csswg.org/css-values-4/#viewport-variants)
with the goal of helping web developers better deal with browsers that have dynamic UI
elements that change apperance/size/etc. based on user actions (e.g. the URL bar
collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most
recently scrolled/swiped down the page).

These new units come in three categories:

the "large viewport" units (lvw, lvh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished")
the "small viewport" units (svw, svh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished")
the "dynamic viewport" units (dvw, dvh, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements

This way, developer could use 100svh to ensure that no matter what state the browser UI
elements are in the entire element will always be visible on the screen, or use 100dvh to
respond to browser UI element changes by automatically resizing various elements to always
fully take advantage of the available space.

Nothing needs to be added to support "dynamic viewport" dv* units as there already exists
other methods to adjust the visual area of the WKWebView without adjusting its frame
(e.g. -[WKWebView setBounds:], -[UIScrollView setContentInset:], etc.).

But for "small viewport" sv* units and "large viewport" lv* units, however, there is
unfortunately no way to tell a WKWebView anything like "this is the smallest/largest that
this WKWebView will ever be", so there's no way to know ahead of time what the size of the
visual area would be when all browser UI elements are in their smallest/largest state. As
such, this patch adds a new API to allow for WKWebView clients to tell WebKit this
information ahead of time.

Note that there already exists the concept of "default viewport" units (vw, vh, etc.)
that each represent 1% of one dimension of the size of the visual area of the page when all
browser UI elements are in their default state. The behavior of these units remain the same,
and the value can be changed via the existing -[WKWebView setFrame:].

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]): Added. (-[WKWebView setMinimumViewportInset:maximumViewportInset:]): Added.
UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _processWillSwapOrDidExit]): (-[WKWebView _frameOrBoundsChanged]): (-[WKWebView _didCompleteAnimatedResize]): (-[WKWebView _setMinimumUnobscuredSizeOverride:]): (-[WKWebView _setMaximumUnobscuredSizeOverride:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _dispatchSetMinimumUnobscuredSize:]): Deleted. (-[WKWebView _dispatchSetMaximumUnobscuredSize:]): Deleted. Recalculate the size for CSS "small viewport" sv* units whenever the frame changes. Also move the deduplication logic that prevents the same value from being sent to the WebProcess more than once to the setter methods on WebPageProxy so that it can be used by more than just iOS-only codepaths.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDefaultUnobscuredSize): Added. (WebKit::WebPageProxy::setMinimumUnobscuredSize): Added. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Added. (WebKit::WebPageProxy::creationParameters):
UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setMinimumUnobscuredSize): Deleted. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Deleted.
Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewportSizeForCSSViewportUnits): (WebKit::WebPage::setDefaultUnobscuredSize): Added. (WebKit::WebPage::setMinimumUnobscuredSize): Added. (WebKit::WebPage::setMaximumUnobscuredSize): Added. (WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Added.
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::viewportConfigurationChanged): (WebKit::WebPage::setMinimumUnobscuredSize): Deleted. (WebKit::WebPage::setMaximumUnobscuredSize): Deleted. (WebKit::WebPage::updateViewportSizeForCSSViewportUnits): Deleted. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units. Move iOS-only code to be for all platforms.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Propagate all viewport size overrides when a new FrameView is created.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: (TEST.CSSViewportUnits.NegativeMinimumViewportInset): Added. (TEST.CSSViewportUnits.NegativeMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInset): Added. (TEST.CSSViewportUnits.MaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:23 PM Changeset in webkit [292005] by Wenson Hsieh

4 edits in trunk

REGRESSION (r290794): [ iOS Debug ] 4 editing/selection/* tests are constant timeouts
https://bugs.webkit.org/show_bug.cgi?id=238155
rdar://90593957

Reviewed by Aditya Keerthi.

Source/WebKit:

After the changes in r290794, we now preemptively compute and send an excessive amount of autocorrection
contexts to the UI process when an element gains focus, such that the UI process is capable of immediately
responding to calls to -requestAutocorrectionContextWithCompletionHandler: without relying on synchronous IPC
to the web process. This made several (already-fairly-slow) tests in editing/selection time out, due to WebKit
computing and sending an excessive amount of this contextual information.

To mitigate this, only perform this preemptive autocorrection context computation if the focused element is
actually changing (i.e., we're not refocusing the same element). Covered by removing several [ Slow ] test
expectations that should no longer be needed.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::elementDidFocus):

LayoutTests:

Unmark several tests that no longer need to be marked as [ Slow ].

platform/ios/TestExpectations:

4:04 PM Changeset in webkit [292004] by Alan Coon

2 edits in branches/safari-613.2.4.1-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90935489

AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:03 PM Changeset in webkit [292003] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS] Block access to IOKit class
https://bugs.webkit.org/show_bug.cgi?id=238457

Reviewed by Geoffrey Garen.

Block access to IOKit class AGPMClient on macOS. We already block all messages for this class.

WebProcess/com.apple.WebProcess.sb.in:

3:52 PM Changeset in webkit [292002] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Check for re-entrancy in stopForBackForwardCache
https://bugs.webkit.org/show_bug.cgi?id=223536

Patch by Rob Buis <rbuis@igalia.com> on 2022-03-28
Reviewed by Darin Adler.

Check for re-entrancy in stopForBackForwardCache.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::stopForBackForwardCache):

3:51 PM Changeset in webkit [292001] by Alan Coon

9 edits in branches/safari-613.2.4.1-branch/Source

Versioning.

WebKit-7613.2.4.1.1

3:44 PM Changeset in webkit [292000] by Alan Coon

2 edits in branches/safari-613.2.4.3-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90935489

AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:39 PM Changeset in webkit [291999] by Alan Coon

9 edits in branches/safari-613.2.4.3-branch/Source

Versioning.

WebKit-7613.2.4.3.1

3:35 PM Changeset in webkit [291998] by Cameron McCormack

15 edits
5 adds in trunk

Remove the 1ms minimum for setTimeout
https://bugs.webkit.org/show_bug.cgi?id=221124
<rdar://problem/73852354>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

web-platform-tests/html/webappapis/timers/zero-settimeout.any-expected.txt:
web-platform-tests/html/webappapis/timers/zero-settimeout.any.html:
web-platform-tests/html/webappapis/timers/zero-settimeout.any.js:

(async_test):

web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker-expected.txt:
web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker.html:

New test checking that 0ms and 1ms timeouts are called in the right
order.

web-platform-tests/FileAPI/file/File-constructor.any.worker-expected.txt:
web-platform-tests/html/webappapis/microtask-queuing/queue-microtask-exceptions.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-cross-origin.sub.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-redirect-to-cross-origin.sub.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-same-origin.sub.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker-expected.txt:
web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-same-origin.sub.any.worker-expected.txt:

Disable console output in some worker tests where the reduced timeout
would cause intemittent failures due to the console message sometimes
not making it to the test output in time.

Source/WebCore:

This patch removes the 1ms minimum for setTimeout. The HTML spec makes
no mention of such a minimum, and Firefox and Chrome do not enforce
this minimum. Removing this for setTimeout results in a 0.7-2.1%
improvement on Speedometer, depending on platform and hardware.

The WPT added here demonstrates how this change can affect pages: if a
page schedules a 1ms and then a 0ms timeout in the same turn of the
event loop, then with this patch they will now be fired in the reverse
order. Since Firefox and Chrome do not impose a 1ms minimum, this
reduces the risk of this being a compatbility problem.

Scheduling a 0ms timeout will cause its callback to be called the next
time around the event loop. Other, non-timer queued tasks, will be
pre-empted. This behavior is permitted by the HTML spec, since the
event loop processing model[1] states that the implementation can
choose which task source to service, and timer callbacks are
dispatched using their own task source. Due to the way the SharedTimer
is called, we don't need to literally dispatch a task with a new
TaskSource::Timer source. (If we decided later to make a different
about whether to service timer callbacks before tasks from all other
task sources, we might need to.)

Not addressing the setTimeout 1ms minimum here, which should likely also
be removed.

While we're here, settle on "one shot" rather rather than "single
shot" as the term for timers that fire once.

[1] https://html.spec.whatwg.org/#event-loop-processing-model

Tests: imported/w3c/web-platform-tests/html/webappapis/timers/zero-settimeout.any.html

imported/w3c/web-platform-tests/html/webappapis/timers/zero-settimeout.any.worker.html

page/DOMTimer.h:
page/DOMTimer.cpp:

(WebCore::DOMTimer::DOMTimer):
(WebCore::DOMTimer::install):
(WebCore::DOMTimer::fired):
(WebCore::DOMTimer::updateTimerIntervalIfNecessary):
(WebCore::DOMTimer::intervalClampedToMinimum const):

LayoutTests:

TestExpectations: Disable console output in some worker tests where

the reduced timeout would cause intemittent failures due to the
console message sometimes not making it to the test output in time.

js/script-tests/weakref-finalizationregistry.js:

(turnEventLoop): Use a timeout of 1ms instead of 0ms so that
the deferred work task that calls the JS FinalizationRegistry
callback gets a chance to run before we continue on to the
assertion that it was run.

3:23 PM Changeset in webkit [291997] by Chris Dumez

2 edits in trunk/Source/JavaScriptCore

Unreviewed, address post-landing review comment from Darin after r291972.

yarr/YarrJIT.cpp:

3:20 PM Changeset in webkit [291996] by Alan Coon

2 edits in branches/safari-613.2.4.0-branch/Source/JavaScriptCore

Cherry-pick r291891. rdar://problem/90935489

AI should not set the structure for ObjectCreate
https://bugs.webkit.org/show_bug.cgi?id=238349

Patch by Justin Michaud <Justin Michaud> on 2022-03-24
Reviewed by Saam Barati and Yusuke Suzuki.

The AbstractInterpreter should not set the structure for ObjectCreate because it might change by
the time the constant folding phase runs if the structure cache is cleared.

dfg/DFGAbstractInterpreterInlines.h: (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:18 PM Changeset in webkit [291995] by Alan Coon

9 edits in branches/safari-613.2.4.0-branch/Source

Versioning.

WebKit-7613.2.4.0.1

3:02 PM Changeset in webkit [291994] by Fujii Hironori

2 edits in trunk/Source/WebKit

Unreviewed build fix after 291979 for WinCairo and PlayStation Debug builds
https://bugs.webkit.org/show_bug.cgi?id=238400

WebNotificationManager.cpp(153): error C2027: use of undefined type 'WebCore::Notification'

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show): Guarded the LOG with ENABLE(NOTIFICATIONS).

2:53 PM Changeset in webkit [291993] by Antti Koivisto

11 edits
20 moves
15 adds in trunk/LayoutTests

[CSS Container Queries] Another WPT import
https://bugs.webkit.org/show_bug.cgi?id=238459

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

resources/resource-files.json:
web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:
web-platform-tests/css/css-contain/container-queries/at-container-parsing.html:
web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt: Added.
web-platform-tests/css/css-contain/container-queries/at-container-serialization.html: Added.
web-platform-tests/css/css-contain/container-queries/container-name-computed-expected.txt:
web-platform-tests/css/css-contain/container-queries/container-name-computed.html:
web-platform-tests/css/css-contain/container-queries/container-name-parsing-expected.txt:
web-platform-tests/css/css-contain/container-queries/container-name-parsing.html:
web-platform-tests/css/css-contain/container-queries/crashtests/canvas-as-container-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-000-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/chrome-bug-1289718-001-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/columns-in-table-001-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/container-type-change-chrome-legacy-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-type-change-chrome-legacy-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/flex-in-columns-000-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/flex-in-columns-000-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/flex-in-columns-001-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/flex-in-columns-001-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/flex-in-columns-002-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/flex-in-columns-002-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/flex-in-columns-003-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/flex-in-columns-003-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/focus-inside-content-visibility-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/focus-inside-content-visibility-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/grid-in-columns-000-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/grid-in-columns-000-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/grid-in-columns-001-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/grid-in-columns-001-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/grid-in-columns-002-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/grid-in-columns-002-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/grid-in-columns-003-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/grid-in-columns-003-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/inline-multicol-inside-container-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-multicol-inside-container-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/inline-with-columns-000-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-with-columns-000-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/inline-with-columns-001-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/inline-with-columns-001-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/input-column-group-container-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/input-column-group-container-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/input-placeholder-inline-size-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/math-block-container-child-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/pseudo-container-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/pseudo-container-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/svg-layout-root-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/svg-layout-root-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/svg-text-crash.html: Added.
web-platform-tests/css/css-contain/container-queries/crashtests/table-in-columns-000-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/table-in-columns-000-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/table-in-columns-001-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/table-in-columns-001-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/table-in-columns-002-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/table-in-columns-002-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/table-in-columns-003-crash.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/table-in-columns-003-crash.html.
web-platform-tests/css/css-contain/container-queries/crashtests/w3c-import.log: Added.
web-platform-tests/css/css-contain/container-queries/idlharness-expected.txt: Added.
web-platform-tests/css/css-contain/container-queries/idlharness.html: Added.
web-platform-tests/css/css-contain/container-queries/layout-dependent-focus-expected.txt: Added.
web-platform-tests/css/css-contain/container-queries/layout-dependent-focus.html: Added.
web-platform-tests/css/css-contain/container-queries/w3c-import.log:

LayoutTests:

TestExpectations:

2:20 PM Changeset in webkit [291992] by Chris Dumez

307 edits in trunk/Source

Prepare WebCore for making the String(const char*) constructor explicit
https://bugs.webkit.org/show_bug.cgi?id=238408

Reviewed by Geoff Garen.

Prepare WebCore for making the String(const char*) constructor explicit.
Making this constructor explicit helps findings cases where a String is constructed
from a literal without the ""_s suffix.

Source/WebCore:

Scripts/SettingsTemplates/Settings.cpp.erb:
contentextensions/ContentExtensionError.cpp:
contentextensions/ContentExtensionError.h:
css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::mediaAttributeMatches):

dom/BroadcastChannel.cpp:

(WebCore::BroadcastChannel::postMessage):

dom/DataTransfer.cpp:

(WebCore::normalizeType):
(WebCore::IEOpFromDragOp):

dom/Document.cpp:

(WebCore::Document::compatMode const):
(WebCore::Document::characterSetWithUTF8Fallback const):
(WebCore::Document::processMetaHttpEquiv):
(WebCore::Document::setDomain):
(WebCore::Document::execCommand):
(WebCore::Document::queryCommandEnabled):
(WebCore::Document::queryCommandIndeterm):
(WebCore::Document::queryCommandState):
(WebCore::Document::queryCommandSupported):
(WebCore::Document::queryCommandValue):
(WebCore::Document::updateResizeObservations):

dom/Element.cpp:

(WebCore::Element::setOuterHTML):
(WebCore::Element::animate):

dom/ImageOverlay.cpp:

(WebCore::ImageOverlay::updateWithTextRecognitionResult):

dom/Node.cpp:

(WebCore::Node::showTreeForThisAcrossFrame const):

dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

dom/ViewportArguments.cpp:

(WebCore::viewportErrorMessageTemplate):
(WebCore::viewportErrorMessage):

editing/Editor.cpp:

(WebCore::Editor::toggleBold):
(WebCore::Editor::toggleUnderline):
(WebCore::Editor::setBaseWritingDirection):

editing/EditorCommand.cpp:

(WebCore::isStylePresent):
(WebCore::executeToggleStyle):
(WebCore::stateStyle):
(WebCore::textDecorationChangeForToggling):

editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::addSpacesForSmartReplace):

editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::observeParagraphs):

editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):

editing/markup.cpp:

(WebCore::createPageForSanitizingWebContent):

fileapi/BlobURL.cpp:

(WebCore::BlobURL::createInternalURL):

fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start):
(WebCore::FileReaderLoader::convertToText):
(WebCore::FileReaderLoader::convertToDataURL):

history/BackForwardCache.cpp:

(WebCore::BackForwardCache::BackForwardCache):

html/EmailInputType.cpp:
html/EnterKeyHint.cpp:

(WebCore::attributeValueForEnterKeyHint):

html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::evaluateDynamicMediaQueryDependencies):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::showPicker):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::updateSleepDisabling):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin):

html/ImageBitmap.cpp:

(WebCore::ImageBitmap::createPromise):
(WebCore::croppedSourceRectangleWithFormatting):
(WebCore::ImageBitmap::createFromBuffer):

html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseFragments):

html/PDFDocument.cpp:

(WebCore::PDFDocument::sendPDFArrayBuffer):

html/canvas/ANGLEInstancedArrays.cpp:

(WebCore::ANGLEInstancedArrays::ANGLEInstancedArrays):
(WebCore::ANGLEInstancedArrays::supported):

html/canvas/EXTTextureCompressionRGTC.cpp:

(WebCore::EXTTextureCompressionRGTC::EXTTextureCompressionRGTC):

html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::initializeShaderExtensions):

html/canvas/WebGLCompressedTextureATC.cpp:

(WebCore::WebGLCompressedTextureATC::WebGLCompressedTextureATC):
(WebCore::WebGLCompressedTextureATC::supported):

html/canvas/WebGLCompressedTextureETC.cpp:

(WebCore::WebGLCompressedTextureETC::WebGLCompressedTextureETC):
(WebCore::WebGLCompressedTextureETC::supported):

html/canvas/WebGLCompressedTextureETC1.cpp:

(WebCore::WebGLCompressedTextureETC1::WebGLCompressedTextureETC1):
(WebCore::WebGLCompressedTextureETC1::supported):

html/canvas/WebGLCompressedTexturePVRTC.cpp:

(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::supported):

html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::WebGLCompressedTextureS3TC):
(WebCore::WebGLCompressedTextureS3TC::supported):

html/canvas/WebGLCompressedTextureS3TCsRGB.cpp:

(WebCore::WebGLCompressedTextureS3TCsRGB::WebGLCompressedTextureS3TCsRGB):
(WebCore::WebGLCompressedTextureS3TCsRGB::supported):

html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::WebGLDebugShaders):

html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::WebGLDepthTexture):
(WebCore::WebGLDepthTexture::supported):

html/canvas/WebGLDrawBuffers.cpp:

(WebCore::WebGLDrawBuffers::WebGLDrawBuffers):
(WebCore::WebGLDrawBuffers::supported):
(WebCore::WebGLDrawBuffers::satisfiesWebGLRequirements):

html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::setupFlags):
(WebCore::WebGLRenderingContextBase::getActiveUniform):
(WebCore::WebGLRenderingContextBase::addExtensionSupportedFormatsAndTypes):
(WebCore::WebGLRenderingContextBase::loseContextImpl):
(WebCore::WebGLRenderingContextBase::printToConsole):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
(WebCore::WebGLRenderingContextBase::recycleContext):

html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

html/parser/HTMLParserIdioms.cpp:

(WebCore::serializeForNumberType):

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

html/parser/HTMLPreloadScanner.h:
html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::create):

html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):

html/track/VTTCue.cpp:

(WebCore::VTTCueBox::applyCSSProperties):

html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::WebVTTParser):
(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

inspector/InspectorAuditAccessibilityObject.cpp:

(WebCore::InspectorAuditAccessibilityObject::getComputedProperties):

inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):

inspector/InspectorFrontendClientLocal.cpp:
inspector/InspectorFrontendHost.cpp:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::setGridOverlayForNode):
(WebCore::InspectorOverlay::clearGridOverlayForNode):
(WebCore::InspectorOverlay::setFlexOverlayForNode):
(WebCore::InspectorOverlay::clearFlexOverlayForNode):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::buildObjectForStyle const):
(WebCore::InspectorStyle::styleWithProperties const):
(WebCore::selectorsFromSource):

inspector/agents/InspectorAnimationAgent.cpp:

(WebCore::InspectorAnimationAgent::resolveAnimation):

inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getFontDataForNode):
(WebCore::InspectorCSSAgent::getStyleSheet):
(WebCore::InspectorCSSAgent::setRuleSelector):
(WebCore::InspectorCSSAgent::addRule):

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::resolveContext):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getSupportedEventNames):
(WebCore::InspectorDOMAgent::showGridOverlay):
(WebCore::InspectorDOMAgent::showFlexOverlay):

inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::setEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeEventBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::breakOnURLIfNeeded):

inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::findStorageArea):

inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::executeSQL):

inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::ExecutableWithDatabase::start):

inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):

inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::resolveWebSocket):

inspector/agents/InspectorPageAgent.cpp:

(WebCore::parseCookieObject):

inspector/agents/page/PageDOMDebuggerAgent.cpp:

(WebCore::PageDOMDebuggerAgent::setDOMBreakpoint):
(WebCore::PageDOMDebuggerAgent::removeDOMBreakpoint):
(WebCore::PageDOMDebuggerAgent::willInsertDOMNode):
(WebCore::PageDOMDebuggerAgent::willRemoveDOMNode):
(WebCore::PageDOMDebuggerAgent::buildPauseDataForDOMBreakpoint):

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForLineLayoutWithReason):

loader/ContentFilter.h:

(WebCore::ContentFilter::urlScheme):

loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):

loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod const):
(WebCore::CrossOriginPreflightResultCacheItem::validateCrossOriginHeaders const):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeLoadEmpty):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::checkURLSchemeAsCORSEnabled):
(WebCore::DocumentThreadableLoader::cancel):
(WebCore::DocumentThreadableLoader::loadRequest):

loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):
(WebCore::FormSubmission::populateFrameLoadRequest):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::updateRequestAndAddExtraFields):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::loadDifferentDocumentItem):

loader/ImageLoader.cpp:

(WebCore::rejectPromises):
(WebCore::ImageLoader::rejectDecodePromises):
(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::decode):

loader/ImageLoader.h:
loader/MixedContentChecker.cpp:

(WebCore::logWarning):
(WebCore::MixedContentChecker::canDisplayInsecureContent):
(WebCore::MixedContentChecker::canRunInsecureContent):

loader/PingLoader.cpp:

(WebCore::PingLoader::sendPing):

loader/ResourceLoadStatistics.cpp:

(WebCore::encodeFontHashSet):
(WebCore::encodeCanvasActivityRecord):
(WebCore::ResourceLoadStatistics::encode const):
(WebCore::decodeHashCountedSet):
(WebCore::decodeFontHashSet):
(WebCore::decodeCanvasActivityRecord):
(WebCore::ResourceLoadStatistics::decode):
(WebCore::ResourceLoadStatistics::toString const):

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::loadDataURL):

loader/ServerTimingParser.cpp:

(WebCore::ServerTimingParser::parseServerTiming):

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::textFromUTF8):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::createFromSelection):

loader/cache/CachedApplicationManifest.cpp:

(WebCore::CachedApplicationManifest::CachedApplicationManifest):
(WebCore::CachedApplicationManifest::encoding const):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
(WebCore::CachedCSSStyleSheet::didAddClient):
(WebCore::CachedCSSStyleSheet::encoding const):
(WebCore::CachedCSSStyleSheet::checkNotify):

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):
(WebCore::CachedSVGDocument::encoding const):

loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::ensureCustomFontData):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::encoding const):

loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
(WebCore::CachedXSLStyleSheet::encoding const):

loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::MemoryCache):
(WebCore::MemoryCache::originsWithCache const):

mathml/MathMLElement.cpp:

(WebCore::convertMathSizeIfNeeded):

page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS const):

page/Chrome.cpp:

(WebCore::Chrome::print):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::checkOrEnableIfNeeded const):

page/DOMSelection.cpp:

(WebCore::DOMSelection::extend):

page/DOMWindow.cpp:

(WebCore::DOMWindow::print):
(WebCore::DOMWindow::alert):
(WebCore::DOMWindow::confirmForBindings):
(WebCore::DOMWindow::prompt):
(WebCore::DOMWindow::showModalDialog):

page/EventHandler.cpp:

(WebCore::handleKeyboardSelectionMovement):

page/EventSource.cpp:

(WebCore::EventSource::connect):

page/Frame.cpp:

(WebCore::createRegExpForLabels):
(WebCore::matchLabelsAgainstString):

page/FrameView.cpp:

(WebCore::FrameView::adjustMediaTypeForPrinting):

page/IntersectionObserver.cpp:

(WebCore::parseRootMargin):
(WebCore::IntersectionObserver::create):

page/LoggedInStatus.cpp:

(WebCore::LoggedInStatus::create):

page/NavigatorBase.cpp:
page/Page.cpp:

(WebCore::Page::userStyleSheet const):

page/Quirks.cpp:

(WebCore::Quirks::triggerOptionalStorageAccessQuirk const):

page/WindowFeatures.cpp:

(WebCore::parseDialogFeatures):
(WebCore::boolFeature):
(WebCore::floatFeature):

page/csp/ContentSecurityPolicy.cpp:

(WebCore::consoleMessageForViolation):
(WebCore::ContentSecurityPolicy::allowEval const):
(WebCore::ContentSecurityPolicy::reportInvalidPluginTypes const):

page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::shouldReportSample const):

page/csp/ContentSecurityPolicyDirectiveNames.cpp:
page/csp/ContentSecurityPolicyDirectiveNames.h:
platform/LegacySchemeRegistry.cpp:

(WebCore::allBuiltinSchemes):

platform/LocalizedStrings.cpp:

(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):
(WebCore::AXListItemActionVerb):

platform/SleepDisabler.cpp:

(WebCore::SleepDisabler::SleepDisabler):

platform/SleepDisabler.h:
platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::HRTFDatabase):

platform/encryptedmedia/CDMPrivate.cpp:

(WebCore::CDMPrivate::getSupportedCapabilitiesForAudioVideoType):

platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseLicenseFormat):
(WebCore::parseLicenseReleaseAcknowledgementFormat):
(WebCore::extractKeyidsFromCencInitData):
(WebCore::extractKeyIdFromWebMInitData):
(WebCore::CDMInstanceSessionClearKey::removeSessionData):

platform/graphics/Font.cpp:

(WebCore::Font::description const):

platform/graphics/GraphicsTypes.cpp:
platform/graphics/InbandGenericCue.cpp:

(WebCore::InbandGenericCue::toJSONString const):

platform/graphics/MediaPlayer.cpp:
platform/graphics/avfoundation/FormatDescriptionUtilities.cpp:

(WebCore::codecFromFormatDescription):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateAnimations):

platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::filenameExtension const):

platform/graphics/cocoa/VP9UtilitiesCocoa.mm:

(WebCore::createVideoInfoFromVP9HeaderParser):
(WebCore::createVideoInfoFromVP8Header):

platform/graphics/cocoa/VideoTrackPrivateWebM.cpp:

(WebCore::VideoTrackPrivateWebM::codec const):

platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::externalRepresentation const):

platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::validateDepthStencil):

platform/ios/QuickLook.h:
platform/ios/QuickLook.mm:
platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::hashStringWithSalt):

platform/mock/RTCNotifiersMock.cpp:

(WebCore::RemoteDataChannelNotifier::fire):

platform/mock/ScrollbarsControllerMock.cpp:

(WebCore::ScrollbarsControllerMock::mouseEnteredContentArea):
(WebCore::ScrollbarsControllerMock::mouseMovedInContentArea):
(WebCore::ScrollbarsControllerMock::mouseExitedContentArea):

platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::mimeTypeCache):

platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::loadResourceSynchronously):
(WebCore::BlobResourceHandle::notifyResponseOnError):

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::DecodeTask::process):

platform/network/HTTPParsers.cpp:

(WebCore::parseStructuredFieldValue):
(WebCore::parseHTTPHeader):

platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::storageAccessQuirks):

platform/network/ParsedContentType.cpp:

(WebCore::ParsedContentType::charset const):

platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::filter):

platform/network/cf/DNSResolveQueueCFNet.cpp:

(WebCore::DNSResolveQueueCFNet::updateIsUsingProxy):

platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::addCONNECTCredentials):
(WebCore::SocketStreamHandleImpl::readStreamCallback):

platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::authorizerFunction):

rendering/RenderAttachment.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::renderName const):

rendering/RenderBlock.h:
rendering/RenderButton.h:
rendering/RenderCombineText.h:
rendering/RenderCounter.cpp:

(WebCore::RenderCounter::renderName const):

rendering/RenderCounter.h:
rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::renderName const):

rendering/RenderDeprecatedFlexibleBox.h:
rendering/RenderDetailsMarker.h:
rendering/RenderEmbeddedObject.h:
rendering/RenderFileUploadControl.h:
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::renderName const):

rendering/RenderFlexibleBox.h:
rendering/RenderFragmentContainer.h:
rendering/RenderFragmentContainerSet.h:
rendering/RenderFragmentedFlow.h:
rendering/RenderFrame.h:
rendering/RenderFrameSet.h:
rendering/RenderFullScreen.h:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::renderName const):

rendering/RenderGrid.h:
rendering/RenderHTMLCanvas.h:
rendering/RenderIFrame.h:
rendering/RenderImage.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::renderName const):

rendering/RenderInline.h:
rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::ensureClippingStackLayers):
(WebCore::RenderLayerBacking::updateDescendantClippingLayer):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateMaskingLayer):
(WebCore::RenderLayerBacking::updateChildClippingStrategy):
(WebCore::RenderLayerBacking::updateScrollingLayers):

rendering/RenderLineBreak.h:
rendering/RenderListBox.h:
rendering/RenderListItem.h:
rendering/RenderListMarker.h:
rendering/RenderMedia.h:
rendering/RenderMenuList.h:
rendering/RenderMeter.h:
rendering/RenderModel.h:
rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::renderName const):

rendering/RenderMultiColumnFlow.h:
rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::renderName const):

rendering/RenderMultiColumnSet.h:
rendering/RenderMultiColumnSpannerPlaceholder.cpp:

(WebCore::RenderMultiColumnSpannerPlaceholder::renderName const):

rendering/RenderMultiColumnSpannerPlaceholder.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::outputRenderObject const):

rendering/RenderObject.h:
rendering/RenderProgress.h:
rendering/RenderQuote.h:
rendering/RenderReplaced.h:
rendering/RenderReplica.h:
rendering/RenderRuby.h:
rendering/RenderRubyBase.h:
rendering/RenderRubyRun.h:
rendering/RenderRubyText.h:
rendering/RenderScrollbarPart.h:
rendering/RenderSlider.h:
rendering/RenderTable.h:
rendering/RenderTableCell.h:
rendering/RenderTableCol.h:
rendering/RenderTableRow.h:
rendering/RenderTableSection.h:
rendering/RenderText.cpp:

(WebCore::RenderText::renderName const):

rendering/RenderText.h:
rendering/RenderTextControl.h:
rendering/RenderTreeAsText.cpp:

(WebCore::getTagName):
(WebCore::RenderTreeAsText::writeRenderObject):

rendering/RenderVideo.h:
rendering/RenderView.h:
rendering/mathml/RenderMathMLBlock.h:
rendering/mathml/RenderMathMLFenced.h:
rendering/mathml/RenderMathMLFraction.h:
rendering/mathml/RenderMathMLMath.h:
rendering/mathml/RenderMathMLMenclose.h:
rendering/mathml/RenderMathMLOperator.h:
rendering/mathml/RenderMathMLPadded.h:
rendering/mathml/RenderMathMLRoot.h:
rendering/mathml/RenderMathMLRow.h:
rendering/mathml/RenderMathMLScripts.h:
rendering/mathml/RenderMathMLSpace.h:
rendering/mathml/RenderMathMLToken.h:
rendering/mathml/RenderMathMLUnderOver.h:
rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::checkShapeImageOrigin):

rendering/style/GridPositionsResolver.cpp:

(WebCore::adjustGridPositionsFromStyle):

rendering/svg/LegacyRenderSVGContainer.h:
rendering/svg/LegacyRenderSVGRect.h:
rendering/svg/LegacyRenderSVGRoot.h:
rendering/svg/LegacyRenderSVGShape.h:
rendering/svg/RenderSVGContainer.h:
rendering/svg/RenderSVGEllipse.h:
rendering/svg/RenderSVGForeignObject.h:
rendering/svg/RenderSVGGradientStop.h:
rendering/svg/RenderSVGHiddenContainer.h:
rendering/svg/RenderSVGImage.h:
rendering/svg/RenderSVGInline.h:
rendering/svg/RenderSVGInlineText.h:
rendering/svg/RenderSVGPath.h:
rendering/svg/RenderSVGRect.h:
rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceFilter.h:
rendering/svg/RenderSVGResourceFilterPrimitive.h:
rendering/svg/RenderSVGResourceLinearGradient.h:
rendering/svg/RenderSVGResourceMarker.h:
rendering/svg/RenderSVGResourceMasker.h:
rendering/svg/RenderSVGResourcePattern.h:
rendering/svg/RenderSVGResourceRadialGradient.h:
rendering/svg/RenderSVGRoot.h:
rendering/svg/RenderSVGShape.h:
rendering/svg/RenderSVGTSpan.h:
rendering/svg/RenderSVGText.h:
rendering/svg/RenderSVGTextPath.h:
rendering/svg/RenderSVGViewportContainer.h:
rendering/svg/SVGContainerLayout.cpp:

(WebCore::SVGContainerLayout::verifyLayoutLocationConsistency):

rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::TextStreamSeparator::TextStreamSeparator):
(WebCore::writeSVGFillPaintingResource):
(WebCore::writeSVGStrokePaintingResource):
(WebCore::writeStandardPrefix):

svg/LinearGradientAttributes.h:

(WebCore::LinearGradientAttributes::LinearGradientAttributes):

svg/RadialGradientAttributes.h:

(WebCore::RadialGradientAttributes::RadialGradientAttributes):

svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBoxGeneric):

svg/SVGGeometryElement.cpp:

(WebCore::SVGGeometryElement::parseAttribute):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

testing/Internals.cpp:

(WebCore::styleValidityToToString):
(WebCore::responseSourceToString):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::elementBufferingPolicy):
(WebCore::Internals::createSleepDisabler):
(WebCore::Internals::loadArtworkImage):

testing/InternalsMapLike.cpp:

(WebCore::InternalsMapLike::InternalsMapLike):

testing/MockMediaSessionCoordinator.cpp:

(WebCore::MockMediaSessionCoordinator::positionStateChanged):
(WebCore::MockMediaSessionCoordinator::readyStateChanged):
(WebCore::MockMediaSessionCoordinator::playbackStateChanged):
(WebCore::MockMediaSessionCoordinator::trackIdentifierChanged):

testing/MockMediaSessionCoordinator.h:
testing/MockPageOverlayClient.cpp:

(WebCore::MockPageOverlayClient::layerTreeAsText):

testing/MockPaymentCoordinator.cpp:
workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::notifyError):

workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):

workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::ensureValidRecordsTable):
(WebCore::updateViaCacheToString):
(WebCore::workerTypeToString):
(WebCore::RegistrationDatabase::doPushChanges):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::scheduleJob):

workers/shared/SharedWorker.cpp:

(WebCore::SharedWorker::create):

worklets/PaintWorkletGlobalScope.cpp:

(WebCore::PaintWorkletGlobalScope::registerPaint):

worklets/WorkletGlobalScope.cpp:

(WebCore::WorkletGlobalScope::userAgent const):

xml/XMLErrors.cpp:

(WebCore::XMLErrors::handleError):
(WebCore::XMLErrors::appendErrorMessage):

xml/XMLErrors.h:
xml/XMLHttpRequest.cpp:

(WebCore::replaceCharsetInMediaTypeIfNeeded):
(WebCore::XMLHttpRequest::setTimeout):
(WebCore::XMLHttpRequest::setResponseType):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::createDecoder const):

xml/XPathParser.cpp:

(WebCore::XPath::Parser::nextTokenInternal):

xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::transformToFragment):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):
(WebCore::docLoaderFunc):
(WebCore::resultMIMEType):
(WebCore::XSLTProcessor::transformToString):

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::createLeafTextNode):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):

Source/WebCore/PAL:

pal/Logging.cpp:

(PAL::registerNotifyCallback):

pal/Logging.h:
pal/system/SleepDisabler.cpp:

(PAL::SleepDisabler::create):
(PAL::SleepDisabler::SleepDisabler):

pal/system/SleepDisabler.h:
pal/system/cocoa/SleepDisablerCocoa.cpp:

(PAL::SleepDisabler::create):
(PAL::SleepDisablerCocoa::SleepDisablerCocoa):

pal/system/cocoa/SleepDisablerCocoa.h:
pal/system/glib/SleepDisablerGLib.cpp:

(PAL::SleepDisabler::create):
(PAL::SleepDisablerGLib::SleepDisablerGLib):
(PAL::SleepDisablerGLib::acquireInhibitor):

pal/system/glib/SleepDisablerGLib.h:

Source/WebKit:

NetworkProcess/NetworkDataTaskBlob.cpp:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didCreateSleepDisabler):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Source/WTF:

wtf/text/WTFString.h:

(WTF::equalIgnoringASCIICase):

2:20 PM Changeset in webkit [291991] by Alan Coon

9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.14

2:11 PM Changeset in webkit [291990] by Ziran Sun

7 edits in trunk

[selection] Fire Select event when selection extent or direction changes
https://bugs.webkit.org/show_bug.cgi?id=238142

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Update test expectations as more sub-tests are now passing.

web-platform-tests/html/semantics/forms/textfieldselection/selection-start-end-expected.txt:
web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setRangeText-expected.txt:
web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:

Source/WebCore:

As per step 6 at [1], if either extent or direction of the text control to be modified,
we need to queue an element task on the user interaction task source given the element
to fire an select event with the bubbles attribute initialized to true.

[1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#set-the-selection-range

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::cacheSelection):
(WebCore::HTMLTextFormControlElement::restoreCachedSelection):
(WebCore::HTMLTextFormControlElement::scheduleSelectEvent):

html/HTMLTextFormControlElement.h:

(WebCore::HTMLTextFormControlElement::cacheSelection): Deleted.

2:02 PM Changeset in webkit [291989] by Jonathan Bedard

6 edits in trunk/Tools

[webkitbugspy] Support component and version in GitHub
https://bugs.webkit.org/show_bug.cgi?id=238086
<rdar://problem/90495776>

Reviewed by Dewei Zhu.

GitHub issues do not have the concept of "component" and "version." However,
we can use label colors to divide labels into types.

Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:

(Tracker):
(Tracker.init): Add concept of color groups for version and components.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:

(GitHub):
(GitHub.init):
(GitHub._labels): Sort labels and output project details as labels.

Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:

(TestGitHub.test_create):
(TestGitHub.test_create_projects):

Canonical link: https://commits.webkit.org/248946@main

1:58 PM Changeset in webkit [291988] by J Pascoe

3 edits in trunk/Source/WebKit

Adopt ASCPublicKeyCredentialCreationOptions's residentKeyPreference
https://bugs.webkit.org/show_bug.cgi?id=238387
rdar://problem/90845393

Reviewed by Brent Fulgham.

This patch passes along the residentKeyPreference to ASA, so it can be passed
back via _WKAuthenticatorSelectionCriteria.residentKey.

Platform/spi/Cocoa/AuthenticationServicesCoreSPI.h:
UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm:

(WebKit::toASCResidentKeyPreference):
(WebKit::configureRegistrationRequestContext):

1:43 PM Changeset in webkit [291987] by Jonathan Bedard

5 edits in trunk/Tools

[git-webkit] Support —oneline in log command
https://bugs.webkit.org/show_bug.cgi?id=238209
<rdar://problem/90660142>

Reviewed by Dewei Zhu.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/command.py:

(FilteredCommand): Header lines don't always start with 'commit'
(FilteredCommand.main): Handle --online output

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/log.py:

(Log):
(Log.parser): Add various git log options.
(Log.main): Forward git log options.

Canonical link: https://commits.webkit.org/248944@main

1:29 PM Changeset in webkit [291986] by Russell Epstein

20 edits in branches/safari-614.1.8-branch

Cherry-pick r291980. rdar://problem/89434696

[iOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=237979
<rdar://problem/89434696>

Reviewed by Tim Horton.

Source/WebCore:

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

page/FrameView.h:
page/FrameView.cpp: (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added. (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from sizeForCSSDefaultViewportUnits. (WebCore::FrameView::copyCSSViewportUnits const): Added. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.

Source/WebKit:

Recently the W3C CSS working group added [some new unit types to CSS](https://drafts.csswg.org/css-values-4/#viewport-variants)
with the goal of helping web developers better deal with browsers that have dynamic UI
elements that change apperance/size/etc. based on user actions (e.g. the URL bar
collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most
recently scrolled/swiped down the page).

These new units come in three categories:

the "large viewport" units (lvw, lvh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished")
the "small viewport" units (svw, svh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished")
the "dynamic viewport" units (dvw, dvh, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements

This way, developer could use 100svh to ensure that no matter what state the browser UI
elements are in the entire element will always be visible on the screen, or use 100dvh to
respond to browser UI element changes by automatically resizing various elements to always
fully take advantage of the available space.

Nothing needs to be added to support "dynamic viewport" dv* units as there already exists
other methods to adjust the visual area of the WKWebView without adjusting its frame
(e.g. -[WKWebView setBounds:], -[UIScrollView setContentInset:], etc.).

But for "small viewport" sv* units and "large viewport" lv* units, however, there is
unfortunately no way to tell a WKWebView anything like "this is the smallest/largest that
this WKWebView will ever be", so there's no way to know ahead of time what the size of the
visual area would be when all browser UI elements are in their smallest/largest state. As
such, this patch adds a new API to allow for WKWebView clients to tell WebKit this
information ahead of time.

Note that there already exists the concept of "default viewport" units (vw, vh, etc.)
that each represent 1% of one dimension of the size of the visual area of the page when all
browser UI elements are in their default state. The behavior of these units remain the same,
and the value can be changed via the existing -[WKWebView setFrame:].

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]): Added. (-[WKWebView setMinimumViewportInset:maximumViewportInset:]): Added.
UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _processWillSwapOrDidExit]): (-[WKWebView _frameOrBoundsChanged]): (-[WKWebView _didCompleteAnimatedResize]): (-[WKWebView _setMinimumUnobscuredSizeOverride:]): (-[WKWebView _setMaximumUnobscuredSizeOverride:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _dispatchSetMinimumUnobscuredSize:]): Deleted. (-[WKWebView _dispatchSetMaximumUnobscuredSize:]): Deleted. Recalculate the size for CSS "small viewport" sv* units whenever the frame changes. Also move the deduplication logic that prevents the same value from being sent to the WebProcess more than once to the setter methods on WebPageProxy so that it can be used by more than just iOS-only codepaths.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDefaultUnobscuredSize): Added. (WebKit::WebPageProxy::setMinimumUnobscuredSize): Added. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Added. (WebKit::WebPageProxy::creationParameters):
UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setMinimumUnobscuredSize): Deleted. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Deleted.
Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewportSizeForCSSViewportUnits): (WebKit::WebPage::setDefaultUnobscuredSize): Added. (WebKit::WebPage::setMinimumUnobscuredSize): Added. (WebKit::WebPage::setMaximumUnobscuredSize): Added. (WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Added.
WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::viewportConfigurationChanged): (WebKit::WebPage::setMinimumUnobscuredSize): Deleted. (WebKit::WebPage::setMaximumUnobscuredSize): Deleted. (WebKit::WebPage::updateViewportSizeForCSSViewportUnits): Deleted. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units. Move iOS-only code to be for all platforms.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Propagate all viewport size overrides when a new FrameView is created.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: (TEST.CSSViewportUnits.NegativeMinimumViewportInset): Added. (TEST.CSSViewportUnits.NegativeMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInset): Added. (TEST.CSSViewportUnits.MaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:29 PM Changeset in webkit [291985] by Russell Epstein

36 edits
4 adds in branches/safari-614.1.8-branch

Cherry-pick r291979. rdar://problem/90616651

Support ServiceWorkerClients.openWindow.
<rdar://90616651> and https://bugs.webkit.org/show_bug.cgi?id=238400

Reviewed by Youenn Fablet.
Source/WebCore:

Test: http/tests/workers/service/openwindow-from-notification-click.html

dom/Document.cpp: (WebCore::Document::pageID const):

page/ClientOrigin.h: (WebCore::ClientOrigin::loggingString const):

workers/service/ServiceWorkerClientData.cpp: (WebCore::ServiceWorkerClientData::isolatedCopy const): (WebCore::ServiceWorkerClientData::isolatedCopy): (WebCore::ServiceWorkerClientData::from):

workers/service/ServiceWorkerClientData.h: (WebCore::ServiceWorkerClientData::encode const): (WebCore::ServiceWorkerClientData::decode):

workers/service/ServiceWorkerClients.cpp: (WebCore::matchWindowWithPageIdentifier): (WebCore::ServiceWorkerClients::openWindow):

workers/service/context/SWContextManager.h:
workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.h:

Source/WebKit:

This API asks the browser to asynchronously open a new tab to a URL then resolve
a promise with the new WindowClient representing that tab.

From a WebCore/WebKit standpoint, implementing this was mostly straightforward.
1 - A plumbing exercise (thread hopping and IPC'ing the message and its reply around)
2 - Implmenting a new delegate method for the hosting app to create the requested WKWebView

The delegate method was interesting. Normally this is the type of thing that'd go to the
WKUIDelegate but that requires there to be a WKWebView, and service workers can be running
without any web views.

Fortunately we already had a WKWebsiteDataStore delegate SPI, and service workers *do* always
have an associated website data store they're running under.

Once the app gives the new web view back to WebKit, we record its PageIdentifier in the reply.

Once the reply makes its way all the way back to the ServiceWorker process and on the
ServiceWorker thread, we do a client match and cross check with that PageIdentifier to make
sure we're resolving the promise with the correct WindowClient.

If there's no matched clients, then the view is either already gone or it has navigated away
to a non-applicable URL.

Same if there are matched clients, but they don't match the specified PageIdentifier.

A straight forward layouttest completes the task.

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp: (WebKit::WebSWServerConnection::controlClient):

NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp: (WebKit::WebSWServerToContextConnection::openWindow):
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:

UIProcess/API/Cocoa/WKWebsiteDataStore.mm: (-[WKWebsiteDataStore set_delegate:]):
UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:

UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::openWindowFromServiceWorker):
UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:

UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary): (WebKit::WebPageProxy::didFinishLoadForFrame): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::resetState): (WebKit::WebPageProxy::callServiceWorkerLaunchCompletionHandlerIfNecessary): Deleted.
UIProcess/WebPageProxy.h:

UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::openWindowFromServiceWorker):
UIProcess/WebsiteData/WebsiteDataStore.h:

UIProcess/WebsiteData/WebsiteDataStoreClient.h: (WebKit::WebsiteDataStoreClient::openWindowFromServiceWorker):

WebProcess/Notifications/WebNotificationManager.cpp: (WebKit::WebNotificationManager::show): (WebKit::WebNotificationManager::didShowNotification): (WebKit::WebNotificationManager::didClickNotification):

WebProcess/Storage/WebSWContextManagerConnection.cpp: (WebKit::WebSWContextManagerConnection::openWindow):
WebProcess/Storage/WebSWContextManagerConnection.h:

Source/WTF:

wtf/HashTable.h: (WTF::KeyTraits>::inlineLookup): Relax this value size requirement for now. The required refactoring is best left as a seperate task with a seperate patch.

Tools:

Implement the new delegate to create the new view.

WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createOtherPlatformWebView):
WebKitTestRunner/TestController.h:

WebKitTestRunner/cocoa/TestControllerCocoa.mm: (WTR::TestController::platformCreateOtherPage):
WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm: (-[TestWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]):

LayoutTests:

WKTR knows how to openWindow() now.

So test:

The success case
Failure due to a disallowed URL
Failure due to a lack of a related user gesture.

http/tests/workers/service/openwindow-from-notification-click-expected.txt: Added.
http/tests/workers/service/openwindow-from-notification-click.html: Added.
http/tests/workers/service/resources/openwindow-client.html: Added.
http/tests/workers/service/resources/shownotification-openwindow-worker.js: Added. (async const): (let.messageClients): (clients.openWindow.string_appeared_here.then.async client): (catch.async error): (async event): (async tryShow): (async getNotes):
platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:17 PM Changeset in webkit [291984] by Kate Cheney

3 edits in trunk/LayoutTests

REGRESSION (r291587): [ iOS ] editing/deleting/insert-in-orphaned-selection-crash.html is a constant text failure (238282)
https://bugs.webkit.org/show_bug.cgi?id=238282
<rdar://problem/90720306>

Reviewed by Aditya Keerthi.

In r291587 we started dropping native appearance for non-form control elements with
specified author style. This is the correct behavior, but requires adjusting this
test which relies on the appearance of a table element in order to reproduce a
non-appearance related crash. This patch updates the test to add table data tags which
ensure the table element gets included in the selectAll() command to keep the test passing.

editing/deleting/insert-in-orphaned-selection-crash.html:
platform/ios-wk2/TestExpectations:

12:40 PM Changeset in webkit [291983] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Accessing WebGL content crashes in macOS Recovery OS, workaround 2
https://bugs.webkit.org/show_bug.cgi?id=238448

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-03-28
Reviewed by Dean Jackson.

Add a two new quick workarounds to try fix a recovery OS crash when
WebKit tries to use ANGLE that is not present in the OS image.
Compare explicitly against NULL as instructed in weak linking documentation.
Check for the EGL_GetPlatformDisplayEXT, this is nullptr in the
recovery OS.

Remove the previous workaround. The environment variable is
not available in WP or GPUP. The Metal symbol is not the problem.

platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::platformSupportsMetal):
(WebCore::initializeEGLDisplay):

12:33 PM Changeset in webkit [291982] by pvollan@apple.com

3 edits in trunk/Source/WebKit

[iOS] Fix sandbox violation related to Network content filtering
https://bugs.webkit.org/show_bug.cgi?id=238458
<rdar://90927474>

Reviewed by Brent Fulgham.

After enabling Network content filtering in the Network process, a related sandbox rule should
be moved to the Network process' sandbox.

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:

11:45 AM Changeset in webkit [291981] by Chris Dumez

7 edits in trunk/Source/WebCore

Speed up Element::removedFromAncestor()
https://bugs.webkit.org/show_bug.cgi?id=238404

Reviewed by Geoffrey Garen.

Speed up Element::removedFromAncestor() by inlining some of the functions it is calling.
This is a confirmed 1.5-2% progression on Speedometer on iMac 20,1.

dom/Element.cpp:

(WebCore::Element::removedFromAncestor):
(WebCore::Element::clearBeforePseudoElementSlow):
(WebCore::Element::clearAfterPseudoElementSlow):
(WebCore::Element::setSavedLayerScrollPositionSlow):
(WebCore::Element::clearBeforePseudoElement): Deleted.
(WebCore::Element::clearAfterPseudoElement): Deleted.
(WebCore::Element::setSavedLayerScrollPosition): Deleted.

dom/Element.h:

(WebCore::Element::setSavedLayerScrollPosition):
(WebCore::Element::clearBeforePseudoElement):
(WebCore::Element::clearAfterPseudoElement):

page/PointerCaptureController.cpp:

(WebCore::PointerCaptureController::elementWasRemovedSlow):
(WebCore::PointerCaptureController::elementWasRemoved): Deleted.

page/PointerCaptureController.h:

(WebCore::PointerCaptureController::elementWasRemoved):

page/PointerLockController.cpp:

(WebCore::PointerLockController::elementWasRemovedInternal):
(WebCore::PointerLockController::elementWasRemoved): Deleted.

page/PointerLockController.h:

(WebCore::PointerLockController::elementWasRemoved):

11:18 AM Changeset in webkit [291980] by Devin Rousso

20 edits in trunk

[iOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
https://bugs.webkit.org/show_bug.cgi?id=237979
<rdar://problem/89434696>

Reviewed by Tim Horton.

Source/WebCore:

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

page/FrameView.h:
page/FrameView.cpp:

(WebCore::FrameView::performSizeToContentAutoSize):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from sizeForCSSDefaultViewportUnits.
(WebCore::FrameView::copyCSSViewportUnits const): Added.
Add all the various methods for getting/setting/overriding/clearing an override value for
CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing
behavior (where CSS "default viewport" v* units match the size of the WKWebView) while
adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.

Source/WebKit:

Recently the W3C CSS working group added [some new unit types to CSS](https://drafts.csswg.org/css-values-4/#viewport-variants)
with the goal of helping web developers better deal with browsers that have dynamic UI
elements that change apperance/size/etc. based on user actions (e.g. the URL bar
collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most
recently scrolled/swiped down the page).

These new units come in three categories:

the "large viewport" units (lvw, lvh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished")
the "small viewport" units (svw, svh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished")
the "dynamic viewport" units (dvw, dvh, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements

This way, developer could use 100svh to ensure that no matter what state the browser UI
elements are in the entire element will always be visible on the screen, or use 100dvh to
respond to browser UI element changes by automatically resizing various elements to always
fully take advantage of the available space.

Nothing needs to be added to support "dynamic viewport" dv* units as there already exists
other methods to adjust the visual area of the WKWebView without adjusting its frame
(e.g. -[WKWebView setBounds:], -[UIScrollView setContentInset:], etc.).

But for "small viewport" sv* units and "large viewport" lv* units, however, there is
unfortunately no way to tell a WKWebView anything like "this is the smallest/largest that
this WKWebView will ever be", so there's no way to know ahead of time what the size of the
visual area would be when all browser UI elements are in their smallest/largest state. As
such, this patch adds a new API to allow for WKWebView clients to tell WebKit this
information ahead of time.

Note that there already exists the concept of "default viewport" units (vw, vh, etc.)
that each represent 1% of one dimension of the size of the visual area of the page when all
browser UI elements are in their default state. The behavior of these units remain the same,
and the value can be changed via the existing -[WKWebView setFrame:].

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]): Added.
(-[WKWebView setMinimumViewportInset:maximumViewportInset:]): Added.

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _processWillSwapOrDidExit]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _didCompleteAnimatedResize]):
(-[WKWebView _setMinimumUnobscuredSizeOverride:]):
(-[WKWebView _setMaximumUnobscuredSizeOverride:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _dispatchSetMinimumUnobscuredSize:]): Deleted.
(-[WKWebView _dispatchSetMaximumUnobscuredSize:]): Deleted.
Recalculate the size for CSS "small viewport" sv* units whenever the frame changes. Also
move the deduplication logic that prevents the same value from being sent to the WebProcess
more than once to the setter methods on WebPageProxy so that it can be used by more than
just iOS-only codepaths.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDefaultUnobscuredSize): Added.
(WebKit::WebPageProxy::setMinimumUnobscuredSize): Added.
(WebKit::WebPageProxy::setMaximumUnobscuredSize): Added.
(WebKit::WebPageProxy::creationParameters):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setMinimumUnobscuredSize): Deleted.
(WebKit::WebPageProxy::setMaximumUnobscuredSize): Deleted.

Shared/WebPageCreationParameters.h:
Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setViewportSizeForCSSViewportUnits):
(WebKit::WebPage::setDefaultUnobscuredSize): Added.
(WebKit::WebPage::setMinimumUnobscuredSize): Added.
(WebKit::WebPage::setMaximumUnobscuredSize): Added.
(WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Added.
(WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Added.
(WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Added.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::setMinimumUnobscuredSize): Deleted.
(WebKit::WebPage::setMaximumUnobscuredSize): Deleted.
(WebKit::WebPage::updateViewportSizeForCSSViewportUnits): Deleted.
Add all the various methods for getting/setting/overriding/clearing an override value for
CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing
behavior (where CSS "default viewport" v* units match the size of the WKWebView) while
adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.
Move iOS-only code to be for all platforms.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Propagate all viewport size overrides when a new FrameView is created.

Tools:

TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm:

(TEST.CSSViewportUnits.NegativeMinimumViewportInset): Added.
(TEST.CSSViewportUnits.NegativeMaximumViewportInset): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetLargerThanFrame): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetLargerThanFrame): Added.
(TEST.CSSViewportUnits.MinimumViewportInset): Added.
(TEST.CSSViewportUnits.MaximumViewportInset): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithZoom): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithZoom): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithFrame): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithFrame): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithBounds): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithBounds): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithContentInset): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithContentInset): Added.
(TEST.CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets): Added.
(TEST.CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets): Added.
(TEST.CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI): Added.

11:14 AM Changeset in webkit [291979] by beidson@apple.com

36 edits
4 adds in trunk

Support ServiceWorkerClients.openWindow.
<rdar://90616651> and https://bugs.webkit.org/show_bug.cgi?id=238400

Reviewed by Youenn Fablet.
Source/WebCore:

Test: http/tests/workers/service/openwindow-from-notification-click.html

dom/Document.cpp:

(WebCore::Document::pageID const):

page/ClientOrigin.h:

(WebCore::ClientOrigin::loggingString const):

workers/service/ServiceWorkerClientData.cpp:

(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::isolatedCopy):
(WebCore::ServiceWorkerClientData::from):

workers/service/ServiceWorkerClientData.h:

(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):

workers/service/ServiceWorkerClients.cpp:

(WebCore::matchWindowWithPageIdentifier):
(WebCore::ServiceWorkerClients::openWindow):

workers/service/context/SWContextManager.h:
workers/service/server/SWServerToContextConnection.h:
workers/service/server/SWServerWorker.h:

Source/WebKit:

This API asks the browser to asynchronously open a new tab to a URL then resolve
a promise with the new WindowClient representing that tab.

From a WebCore/WebKit standpoint, implementing this was mostly straightforward.
1 - A plumbing exercise (thread hopping and IPC'ing the message and its reply around)
2 - Implmenting a new delegate method for the hosting app to create the requested WKWebView

The delegate method was interesting. Normally this is the type of thing that'd go to the
WKUIDelegate but that requires there to be a WKWebView, and service workers can be running
without any web views.

Fortunately we already had a WKWebsiteDataStore delegate SPI, and service workers *do* always
have an associated website data store they're running under.

Once the app gives the new web view back to WebKit, we record its PageIdentifier in the reply.

Once the reply makes its way all the way back to the ServiceWorker process and on the
ServiceWorker thread, we do a client match and cross check with that PageIdentifier to make
sure we're resolving the promise with the correct WindowClient.

If there's no matched clients, then the view is either already gone or it has navigated away
to a non-applicable URL.

Same if there are matched clients, but they don't match the specified PageIdentifier.

A straight forward layouttest completes the task.

NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::controlClient):

NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::openWindow):

NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:

UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore set_delegate:]):

UIProcess/API/Cocoa/_WKWebsiteDataStoreDelegate.h:

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::openWindowFromServiceWorker):

UIProcess/Network/NetworkProcessProxy.h:
UIProcess/Network/NetworkProcessProxy.messages.in:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared):
(WebKit::WebPageProxy::callLoadCompletionHandlersIfNecessary):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::resetState):
(WebKit::WebPageProxy::callServiceWorkerLaunchCompletionHandlerIfNecessary): Deleted.

UIProcess/WebPageProxy.h:

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::openWindowFromServiceWorker):

UIProcess/WebsiteData/WebsiteDataStore.h:

UIProcess/WebsiteData/WebsiteDataStoreClient.h:

(WebKit::WebsiteDataStoreClient::openWindowFromServiceWorker):

WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::didShowNotification):
(WebKit::WebNotificationManager::didClickNotification):

WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::openWindow):

WebProcess/Storage/WebSWContextManagerConnection.h:

Source/WTF:

wtf/HashTable.h:

(WTF::KeyTraits>::inlineLookup): Relax this value size requirement for now.
The required refactoring is best left as a seperate task with a seperate patch.

Tools:

Implement the new delegate to create the new view.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createOtherPlatformWebView):

WebKitTestRunner/TestController.h:

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateOtherPage):

WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:

(-[TestWebsiteDataStoreDelegate websiteDataStore:openWindow:fromServiceWorkerOrigin:completionHandler:]):

LayoutTests:

WKTR knows how to openWindow() now.

So test:

The success case
Failure due to a disallowed URL
Failure due to a lack of a related user gesture.

http/tests/workers/service/openwindow-from-notification-click-expected.txt: Added.
http/tests/workers/service/openwindow-from-notification-click.html: Added.
http/tests/workers/service/resources/openwindow-client.html: Added.
http/tests/workers/service/resources/shownotification-openwindow-worker.js: Added.

(async const):
(let.messageClients):
(clients.openWindow.string_appeared_here.then.async client):
(catch.async error):
(async event):
(async tryShow):
(async getNotes):

platform/gtk/TestExpectations:

10:58 AM Changeset in webkit [291978] by commit-queue@webkit.org

24 edits in trunk/Source

Some Apple internal clients fail to build due to redeclared AppKit types in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=238368

Patch by Ian Anderson <iana@apple.com> on 2022-03-28
Reviewed by Jonathan Bedard.

Source/WebCore:

Some Apple internal Mac Catalyst clients need to use both AppKit and
WebKitLegacy. WebKitLegacy's redeclaration of AppKit types causes errors
for those clients. Copy AppKit's Apple internal logic for identifying
the special Mac Catalyst clients that are allowed to use the AppKit
types, and when such clients use WebKitLegacy, don't redeclare the
AppKit types.

platform/ios/KeyEventCodesIOS.h:
platform/ios/wak/WAKAppKitStubs.h:
platform/ios/wak/WAKView.h:
platform/ios/wak/WAKWindow.h:

Source/WebKitLegacy/ios:

WebKitLegacy can't always define NSView to WAKView in Mac Catalyst, but
views are always WAKView in Mac Catalyst. Switch on TARGET_OS_IPHONE to
declare WAKView explicitly.

WebView/WebUIKitDelegate.h:

Source/WebKitLegacy/mac:

WebKitLegacy can't always define NSClipView/NSView/NSScrollView/
NSWindow/NSResponder to their WAK counterparts in Mac Catalyst, but
those types are always the WAK ones in Mac Catalyst. Switch on
TARGET_OS_IPHONE to declare the WAK types explicitly.

Misc/WebDownload.h:
Misc/WebNSViewExtras.h:
Plugins/WebPluginDatabase.h:
WebView/WebDocument.h:
WebView/WebDocumentPrivate.h:
WebView/WebFramePrivate.h:
WebView/WebFrameView.h:

(WEBKIT_CLASS_DEPRECATED_MAC):

WebView/WebFrameViewPrivate.h:
WebView/WebHTMLRepresentation.h:
WebView/WebHTMLRepresentationPrivate.h:
WebView/WebHTMLView.h:
WebView/WebHTMLViewPrivate.h:
WebView/WebUIDelegate.h:
WebView/WebUIDelegatePrivate.h:
WebView/WebView.h:

(WEBKIT_CLASS_DEPRECATED_MAC):

WebView/WebViewPrivate.h:

10:42 AM Changeset in webkit [291977] by Alan Coon

1 copy in branches/safari-613.2.4.3-branch

New branch.

10:42 AM Changeset in webkit [291976] by Alan Coon

1 copy in branches/safari-613.2.4.2-branch

New branch.

10:42 AM Changeset in webkit [291975] by Alan Coon

1 copy in branches/safari-613.2.4.1-branch

New branch.

10:42 AM Changeset in webkit [291974] by Alan Coon

1 copy in branches/safari-613.2.4.0-branch

New branch.

10:29 AM Changeset in webkit [291973] by Alan Coon

5 edits
2 adds in branches/safari-613.1.17.0-branch

Cherry-pick r291622. rdar://problem/90501108

Fetching a Blob URL with an unbounded Range header do not generate a Content-Range response header
https://bugs.webkit.org/show_bug.cgi?id=238170

Reviewed by Eric Carlson.

Source/WebCore:

Test: fetch/fetch-blob-unbounded-range.html

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::notifyResponseOnSuccess):

Source/WebKit:

Handle the case where the request contains an unbounded range, and property calculate the rangeEnd
to pass into ParsedContentRange.

NetworkProcess/NetworkDataTaskBlob.cpp: (WebKit::NetworkDataTaskBlob::dispatchDidReceiveResponse):

LayoutTests:

fetch/fetch-blob-unbounded-range-expected.txt: Added.
fetch/fetch-blob-unbounded-range.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:25 AM Changeset in webkit [291972] by Chris Dumez

16 edits in trunk/Source

Use StringView for Yarr / RegularExpression parsing
https://bugs.webkit.org/show_bug.cgi?id=238420

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Use StringView for Yarr / RegularExpression parsing, to avoid unnecessary String construction
in some cases. It is not uncommon for the pattern to be a string literal.

yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::create):
(JSC::Yarr::RegularExpression::Private::Private):
(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::RegularExpression):
(JSC::Yarr::RegularExpression::match const):
(JSC::Yarr::RegularExpression::searchRev const):
(JSC::Yarr::replace):

yarr/RegularExpression.h:
yarr/YarrInterpreter.cpp:

(JSC::Yarr::interpret):

yarr/YarrInterpreter.h:
yarr/YarrJIT.cpp:

(JSC::Yarr::jitCompile):
(JSC::Yarr::jitCompileInlinedTest):

yarr/YarrJIT.h:
yarr/YarrParser.h:

(JSC::Yarr::Parser::Parser):
(JSC::Yarr::parse):

yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPattern::compile):
(JSC::Yarr::YarrPattern::YarrPattern):
(JSC::Yarr::YarrPattern::dumpPatternString):
(JSC::Yarr::YarrPattern::dumpPattern):

yarr/YarrPattern.h:
yarr/YarrSyntaxChecker.cpp:

(JSC::Yarr::checkSyntax):

yarr/YarrSyntaxChecker.h:

Source/WebCore:

platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:

(WebCore::CDMPrivateMediaSourceAVFObjC::parseKeySystem):

Source/WTF:

Add convenience characters() templated function to StringView, to match String and StringImpl.

wtf/text/StringView.h:

(WTF::StringView::characters<LChar> const):
(WTF::StringView::characters<UChar> const):

10:25 AM Changeset in webkit [291971] by Alan Coon

9 edits in branches/safari-613.1.17.0-branch/Source

Versioning.

WebKit-7613.1.17.0.9

10:04 AM Changeset in webkit [291970] by Diego Pino Garcia

3 edits in trunk/Source/WebCore

[GLIB] Fix build error 'not match operator !=' in Ubuntu LTS after r291696
https://bugs.webkit.org/show_bug.cgi?id=238443

Reviewed by Adrian Perez de Castro.

The error was also happening in build bots using GCC 8.3 like Debian
Stable.

platform/graphics/GraphicsTypes.h:

(WebCore::operator==):
(WebCore::operator!=):
(WebCore::CompositeMode::operator==): Deleted.

platform/graphics/SourceBrush.h:

(WebCore::operator!=):

9:43 AM Changeset in webkit [291969] by youenn@apple.com

2 edits in trunk/Source/WebCore

ImageTransferSessionVT::setSize should properly create its buffer pool
https://bugs.webkit.org/show_bug.cgi?id=238455

Reviewed by Eric Carlson.

Covered by existing tests.

platform/graphics/cv/ImageTransferSessionVT.mm:

(WebCore::ImageTransferSessionVT::setSize):
We check the Expected, then move the RetainPtr if available.

9:28 AM Changeset in webkit [291968] by Tyler Wilcock

2 edits in trunk/Source/WebCore

AccessibilityObject::listMarkerTextForNodeAndPosition should check for presence of list item before anything else
https://bugs.webkit.org/show_bug.cgi?id=238341

Reviewed by Andres Gonzalez.

The first thing AccessibilityObject::listMarkerTextForNodeAndPosition
does is check to see that the given range isStartOfLine. We
should instead check if there's an actual list item to work with
before doing this, since isStartOfLine can cause crashes.

Covered by test
accessibility/mac/attributed-string-with-listitem-multiple-lines.html.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition):

9:24 AM Changeset in webkit [291967] by youenn@apple.com

13 edits
2 copies in trunk/Source

Share more code between RemoteRealtimeAudioSource and RemoteRealtimeVideoSource
https://bugs.webkit.org/show_bug.cgi?id=237704
<rdar://problem/90424679>

Reviewed by Eric Carlson.

Source/WebCore:

The remote video source is now correctly exposing whether it is camera, screen...
This was not well handled before in some places, we replace type == Video by hasVideo to handle all video types appropriately.

Covered by existing tests.

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
platform/mediastream/MediaStreamPrivate.cpp:

Source/WebKit:

Introduce RemoteRealtimeMediaSource as a common class for RemoteRealtimeAudioSource and RemoteRealtimeVideoSource.

SourcesCocoa.txt:
WebKit.xcodeproj/project.pbxproj:
WebProcess/cocoa/RemoteRealtimeAudioSource.cpp:
WebProcess/cocoa/RemoteRealtimeAudioSource.h:
WebProcess/cocoa/RemoteRealtimeMediaSource.cpp: Added.
WebProcess/cocoa/RemoteRealtimeMediaSource.h: Added.
WebProcess/cocoa/RemoteRealtimeMediaSourceProxy.h:
WebProcess/cocoa/RemoteRealtimeVideoSource.cpp:
WebProcess/cocoa/RemoteRealtimeVideoSource.h:

8:13 AM Changeset in webkit [291966] by Noam Rosenthal

3 edits in trunk/Tools

Issues with WPT exporter
https://bugs.webkit.org/show_bug.cgi?id=238446

Also addresses https://bugs.webkit.org/show_bug.cgi?id=216330
and https://bugs.webkit.org/show_bug.cgi?id=216603

Reviewed by Youenn Fablet.

Fix issues with WPT exporter:

Ignore *-expected.html files
Perform a 3-way merge when applying patch
Add a newline at the end of the patch

Scripts/webkitpy/w3c/test_exporter.py:

(WebPlatformTestExporter._strip_ignored_files_from_diff):
(WebPlatformTestExporter.create_branch_with_patch):

7:51 AM Changeset in webkit [291965] by aakash_jain@apple.com

2 edits in trunk/Tools

[ews] Update contributors in ews unit tests
https://bugs.webkit.org/show_bug.cgi?id=238416

Reviewed by Jonathan Bedard.

CISupport/ews-build/steps_unittest.py: Use mocked info in unit-tests.

7:22 AM Changeset in webkit [291964] by Chris Dumez

3 edits in trunk/Source/WebCore

Optimize toJS() for HTMLElements
https://bugs.webkit.org/show_bug.cgi?id=238426

Reviewed by Yusuke Suzuki.

Optimize toJS() for HTMLElements. Previously, the more generic Element's toJS() would be called,
which would have to do more checks.

This is a 0.6% progression on Speedometer 2.0 on MacBook Air 10,1 (AS).

bindings/js/JSHTMLElementCustom.cpp:

(WebCore::toJS):
(WebCore::toJSNewlyCreated):

html/HTMLElement.idl:

7:14 AM Changeset in webkit [291963] by Chris Dumez

2 edits in trunk/Source/WebCore

Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
https://bugs.webkit.org/show_bug.cgi?id=238422

Reviewed by Peng Liu.

Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.

bindings/js/JSNodeCustom.cpp:

(WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
(WebCore::isReachableFromDOM): Deleted.

5:08 AM Changeset in webkit [291962] by Ziran Sun

5 edits in trunk

[Forms] Alias appearance <compat-auto> keywords to 'auto' for button
https://bugs.webkit.org/show_bug.cgi?id=238252

Reviewed by Darin Adler.

Source/WebCore:

We need to alias appearance <compat-auto> keywords to 'auto'. This is to
handle some button related cases including button, push-button and square-button.
Also the slider-horizontal case has been addressed. We still have menulist and
textfield cases left to look into.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustAppearanceForElement const):

LayoutTests:

Unskip the tests that are now passing.
-webkit-appearance: square-button doesnt work for ::-webkit-file-upload-button any more.
Replace it with -webkit-appearance: none in fast/forms/file/file-style-inheritance.html.
This is also in line with the change in Chromium.

TestExpectations:
fast/forms/file/file-style-inheritance.html:

1:27 AM Changeset in webkit [291961] by Cameron McCormack

3 edits
2 adds in trunk

Remove pending UA shadow tree state when an input element is removed from the document
https://bugs.webkit.org/show_bug.cgi?id=238429
<rdar://90682918>

Reviewed by Antti Koivisto.

Source/WebCore:

If an <input> element has a pending UA shadow tree, and the element is
removed from the document, we don't currently remove the element from
Document::m_elementsWithPendingUserAgentShadowTreeUpdates. Not only
does that means we may wastefully create the shadow tree if the
element is not inserted into the document again, but if the element is
then inserted into a different document, flushing style in the new
document won't correctly create the shadow tree.

Test: fast/forms/lazy-shadow-tree-creation-move-document-crash.html

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::removedFromAncestor):

LayoutTests:

fast/forms/lazy-shadow-tree-creation-move-document-crash-expected.txt: Added.
fast/forms/lazy-shadow-tree-creation-move-document-crash.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed