Timeline

Mar 30, 2022:

11:04 PM Changeset in webkit [292143] by Simon Fraser

• 2 edits in trunk/Source/WebKit

Crash the WebContent process if the RemoteRenderingBackend::PrepareBuffersForDisplay IPC fails
​https://bugs.webkit.org/show_bug.cgi?id=238569

Reviewed by Kimmo Kinnunen.

We can't sensibly recover from RemoteRenderingBackend::PrepareBuffersForDisplay IPC failing,
which can happen when the GPU process crashes, so just crash the WebContent process.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::prepareBuffersForDisplay):

11:02 PM Changeset in webkit [292142] by Andres Gonzalez

• 4 edits in trunk/Source/WebCore

Split streaming of AX trees from the class AXLogger.
​https://bugs.webkit.org/show_bug.cgi?id=238550
<rdar://problem/91041921>

Reviewed by Chris Fleizach.

AXLogger functionality is debug only. We need to stream the content of
the AX trees both in debug and release builds. This patch splits
streaming of the AX trees from the AXLogger class, which remains a debug
only utility.
In addition, added a mechanism to control what is streamed via the
AXStreamOptions enumeration.

• accessibility/AXLogger.cpp:

(WebCore::shouldLog):
(WebCore::operator<<):
(WebCore::streamIsolatedSubtreeOnMainThread):
Streams a snapshot of the hierarchy of AXIsolatedObjects on the main
thread, limiting the properties of the AXIsolatedObject that can be
accessed using AXStreamOptions.

(WebCore::streamAXCoreObject):
(WebCore::streamSubtree):
(WebCore::AXLogger::add): Replaced with streamSubtree.

• accessibility/AXLogger.h:
• accessibility/isolatedtree/AXIsolatedTree.h:

10:08 PM Changeset in webkit [292141] by sihui_liu@apple.com

• 4 edits in trunk

Regression: WebsiteDataStore fails to read experimental feature values from NSUserDefaults
​https://bugs.webkit.org/show_bug.cgi?id=238486

Reviewed by Alex Christensen.

Source/WebKit:

From rdar://46352542, Safari no longer uses "Experimental" as prefix for experimental features.

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::internalFeatureEnabled):
(WebKit::experimentalFeatureEnabled):
(WebKit::WebsiteDataStore::thirdPartyCookieBlockingMode const):
(WebKit::WebsiteDataStore::platformSetNetworkParameters):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

9:22 PM Changeset in webkit [292140] by Alan Bujtas

• 2 edits in trunk/LayoutTests

Add explanation as to why contain-size-button-001.html/002.html WPT tests fail.

Unreviewed.

• TestExpectations:

8:45 PM Changeset in webkit [292139] by Brent Fulgham

• 4 edits in trunk/Source/WebCore

[Cocoa] Ensure correct isAppInitiated state when creating URLRequests from URL
​https://bugs.webkit.org/show_bug.cgi?id=238159
<rdar://problem/88490742>

Reviewed by Kate Cheney.

Update various load operations to ensure AppInitiated state is properly handled.

• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleLocationChange): The ScheduledPageBlock
load did not propagating the value of the driving document's AppInitiated state.

• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create): Reflect the AppInitiated state in the load.

• page/DragController.cpp:

(WebCore::DragController::performDragOperation): A page load triggered by the user
dragging content into the view is never AppInitiated.

8:24 PM Changeset in webkit [292138] by mmaxfield@apple.com

• 8 edits in trunk

[Cocoa] Link WebCore with WebGPU.framework 🎉
​https://bugs.webkit.org/show_bug.cgi?id=236751

Reviewed by Dean Jackson.

Source/WebCore:

Apple's build system has been configured, so it's now safe to
link WebCore.framework and WebGPU.framework.

We correctly handle the situation where the framework isn't present
at runtime.

• Configurations/WebCore.xcconfig:

Source/WTF:

Apple's build system has been configured, so it's now safe to
link WebCore.framework and WebGPU.framework.

We correctly handle the situation where the framework isn't present
at runtime.

• wtf/PlatformHave.h:

LayoutTests:

Once we enable WebGPU, the WebGPU tests will start crashing all over the place.
Let's temporarily mark them as skip until the crashing stops.

• platform/ios-device-wk1/TestExpectations:
• platform/ios-simulator-wk1/TestExpectations:
• platform/mac-wk1/TestExpectations:

7:36 PM Changeset in webkit [292137] by don.olmstead@sony.com

• 5 edits in trunk

Turn DEVELOPER_MODE ON for all non-Apple ports in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=238556

Reviewed by Alex Christensen.

.:

Use DEVELOPER_MODE to determine what the defaults of ENABLE_API_TESTS and
ENABLE_MINIBROWSER should be. Make ENABLE_WEBKIT the default of ENABLE_MINIBROWSER.

• Source/cmake/OptionsPlayStation.cmake:

Tools:

Add DEVELOPER_MODE=ON to the CMake argument list for all non-Apple ports in build-webkit.
Use ENABLE_MINIBROWSER to determine whether to build the executable on PlayStation.

• PlatformPlayStation.cmake:
• Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

7:10 PM Changeset in webkit [292136] by ysuzuki@apple.com

• 3 edits in trunk/JSTests

Remove useProbeOSRExit=1 flag from tests
​https://bugs.webkit.org/show_bug.cgi?id=238571

Reviewed by Saam Barati.

This flag no longer exists.

• stress/out-of-frame-stack-accesses-due-to-probe-based-osr-exits.js:
• stress/sampling-profiler-should-not-sample-beyond-stack-bounds.js:

6:52 PM Changeset in webkit [292135] by Matteo Flores

• 2 edits in trunk/LayoutTests

REGRESSION(r291797): [ wk1 ] 5 imported/w3c/web-platform-tests/css/css-sizing/contain-intrinsic-size* tests are constant text failures
​https://bugs.webkit.org/show_bug.cgi?id=238584

Unreviewed test gardening.

• LayoutTests/platform/mac-wk1/TestExpectations:

6:48 PM Changeset in webkit [292134] by Kate Cheney

• 27 edits
  111 adds in trunk

Migrate manifest version content security policy filtering for extensions into WebKit
​https://bugs.webkit.org/show_bug.cgi?id=238230
<rdar://problem/60081492>

Reviewed by Timothy Hatcher.

Source/WebCore:

Currently Safari handles parsing CSP for extensions depending on the manifest version. This patch moves
parsing to WebKit to align with existing CSP implementation.

There are two current versions of the manifest, v2 and v3. The rules for V2 affect the script-src and default-src
directives and the rules are:

1. Standalone wildcards are prohibited.
2. Wildcards with only a tld (e.g. *.com) are prohibited.
3. Only full ​https:// urls are allowed as sources, with the exception of the blob: scheme.
4. The 'unsafe-inline' source expression is prohibited.

The rules for V3 affect the script-src, worker-src, object-src and default-src directives and the rules are:

1. Wildcards are prohibited.
2. External sources are prohibited.
3. The 'self' and 'none' keywords are allowed. All others are prohibited.

Tests: http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-blob-scheme-allowed.html

http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-insecure-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-missing-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-scheme-only.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-eval-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-inline-blocked.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-prohibited.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-host-only-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-scheme-only-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-blob-scheme-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-hash-source-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-insecure-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-missing-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-scheme-only.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-eval-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-inline-blocked.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-blocked.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-non-https-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-insecure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-secure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-self.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-host-only-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-scheme-only-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-wildcard-allowed.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-non-https-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-partial-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-insecure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-secure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-self.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-non-https-scheme.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-partial-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blockes-nonces.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blocks-hashes.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-insecure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-secure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-self.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/style-src/manifest-v3-style-src-allows-keywords.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-partial-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-wildcard.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-can-load-insecure-loopback-ip.html
http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-self.html

• WebCore.xcodeproj/project.pbxproj:
• page/Page.cpp:

(WebCore::m_contentSecurityPolicyModeForExtension):
(WebCore::m_attachmentElementClient): Deleted.

• page/Page.h:

(WebCore::Page::contentSecurityPolicyModeForExtension const):

• page/PageConfiguration.h:
• page/csp/ContentSecurityPolicy.cpp:

Planning on fixing the non-document case in a followup, this patch was big enough.

• page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::contentSecurityPolicyModeForExtension const):

• page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::ContentSecurityPolicySourceList::ContentSecurityPolicySourceList):
(WebCore::schemeIsInHttpFamily):
(WebCore::isRestrictedDirectiveForMode):
This function returns the specific directives that have rules applied to them
in each manifest version. It can be used for blocking wildcards and unsafe-inline
for both versions, and all other keywords for manifest v3.

(WebCore::ContentSecurityPolicySourceList::isValidSourceForExtensionMode):
This function checks a given source against the rules for a specific version.

(WebCore::extensionModeAllowsKeywordsForDirective):
Most keywords (aside from unsafe-inline) are allowed in manifest v2, but only
'self' and 'none' are allowed in v3.

(WebCore::ContentSecurityPolicySourceList::parse):
(WebCore::ContentSecurityPolicySourceList::parseSource):
(WebCore::ContentSecurityPolicySourceList::parseNonceSource):
(WebCore::ContentSecurityPolicySourceList::parseHashSource):
Nonces and hashes are not allowed for specified v3 directives.

• page/csp/ContentSecurityPolicySourceList.h:

Source/WebKit:

Add an SPI for Safari to specify when we are loading a WebView for an extension,
and which manifest version the extension has.

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):

• UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::setContentSecurityPolicyModeForExtension):
(API::PageConfiguration::contentSecurityPolicyModeForExtension const):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _setContentSecurityPolicyModeForExtension:]):
(-[WKWebViewConfiguration _contentSecurityPolicyModeForExtension]):

• UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
• UIProcess/Cocoa/CSPExtensionUtilities.h: Added.
• UIProcess/Cocoa/CSPExtensionUtilities.mm: Added.

(WebKit::toWKContentSecurityPolicyModeForExtension):
(WebKit::toContentSecurityPolicyModeForExtension):

• UIProcess/Cocoa/WebProcessProxyCocoa.mm:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

Tools:

• WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults):
(WTR::TestOptions::keyTypeMapping):

• WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::contentSecurityPolicyExtensionMode const):

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::platformCreateWebView):

LayoutTests:

Layout test coverage. We don’t allow loading of hosts
other than localhost and 127.0.0.1 in our test infrastructure,
so that made it difficult to write a test for remote sources
being blocked in manifest V3, and for blocked TLDs with wildcards
for manifest v2. We have existing unit test coverage for our isPublicSuffix
function.

• TestExpectations:
• platform/wk2/TestExpectations:
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-blob-scheme-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-blob-scheme-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-insecure-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-insecure-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-missing-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-missing-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-scheme-only-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-scheme-only.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-eval-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-eval-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-inline-blocked-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-unsafe-inline-blocked.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-prohibited-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/default-src/manifest-v2-default-src-wildcard-prohibited.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-host-only-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-host-only-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-scheme-only-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-scheme-only-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-wildcard-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/img-src/manifest-v2-img-src-wildcard-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-blob-scheme-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-blob-scheme-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-hash-source-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-hash-source-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-insecure-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-insecure-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-missing-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-missing-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-scheme-only-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-scheme-only.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-eval-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-eval-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-inline-blocked-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-unsafe-inline-blocked.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-blocked-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v2/script-src/manifest-v2-script-src-wildcard-blocked.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-non-https-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-non-https-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-block-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-insecure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-insecure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-secure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-can-load-secure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-self-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/default-src/manifest-v3-default-src-self.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-host-only-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-host-only-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-scheme-only-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-scheme-only-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-wildcard-allowed-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/img-src/manifest-v3-img-src-wildcard-allowed.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-non-https-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-non-https-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-partial-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-partial-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-block-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-insecure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-insecure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-secure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-can-load-secure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-self-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/object-src/manifest-v3-object-src-self.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/resources/check-style.js: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/resources/load-blob.js: Added.

(script.onload):
(script.onerror):

• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-non-https-scheme-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-non-https-scheme.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-partial-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-partial-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-block-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blockes-nonces-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blockes-nonces.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blocks-hashes-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-blocks-hashes.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-insecure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-insecure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-secure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-can-load-secure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-self-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/script-src/manifest-v3-script-src-self.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/style-src/manifest-v3-style-src-allows-keywords-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/style-src/manifest-v3-style-src-allows-keywords.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-partial-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-partial-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-wildcard-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-block-wildcard.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-can-load-insecure-loopback-ip-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-can-load-insecure-loopback-ip.html: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-self-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/extensions/manifest-v3/worker-src/manifest-v3-worker-src-self.html: Added.

5:48 PM Changeset in webkit [292133] by Matteo Flores

• 3 edits in trunk/LayoutTests

[ Mac , iOS Debug ] imported/w3c/web-platform-tests/html/cross-origin-opener-policy/resource-popup.https.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=228127

Unreviewed test gardening.

• LayoutTests/platform/ios-wk2/TestExpectations:
• LayoutTests/platform/mac-wk2/TestExpectations:

5:06 PM Changeset in webkit [292132] by commit-queue@webkit.org

• 14 edits in trunk/Tools

[webkitbugspy] Get and set issue component data
​https://bugs.webkit.org/show_bug.cgi?id=238514
<rdar://problem/90994542>

Reviewed by Dewei Zhu.

• Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/init.py: Ditto.
• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/bugzilla.py:

(Tracker.populate): Populate project, component and version.
(Tracker.set): Set project, component and version.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:

(Tracker.request): github.Tracker has no Exception member. Use RuntimeError instead.
(Tracker.populate): Populate labels and then extract component and version.
(Tracker.set): Set labels associated with components and versions.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/issue.py:

(Issue.init): Set _labels, _project, _component and _version values.
(Issue.labels): Populate and return labels.
(Issue.set_labels): Set labels associated with issue.
(Issue.project): Populate and return project.
(Issue.component): Populate and return component.
(Issue.version): Populate and return version.
(Issue.set_component): Set the project, component and version of an issue.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/bugzilla.py:

(Bugzilla._issue): Mock setting and returning project, component and version.
(Bugzilla._create): Populate project, component and version on creation.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/data.py: Set values for

project, component and version.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/github.py:

(GitHub._labels_for_issue): Given an issue, return a list of labels. Take into
consideration component and version.
(GitHub._issue): Mock label editing and returning.
(GitHub._create): Ditto.
(GitHub.request): Support request to update labels.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/mocks/radar.py:

(RadarModel.init): Set component.
(RadarModel.commit_changes): Commit component changes.
(RadarClient.find_components): Implement version filter.
(RadarClient.create_radar): Create radar with component details.
(Radar.Component.get): Implement dict-like API.
(Radar.Component.getitem): Ditto.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/radar.py:

(Tracker.populate): Get project, component and version.
(Tracker.set): Set component information.

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/bugzilla_unittest.py:

(TestBugzilla.test_create):
(TestBugzilla.test_create_prompt):

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/github_unittest.py:

(TestGitHub.test_projects):
(TestGitHub.test_create_projects):

• Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/radar_unittest.py:

(TestRadar.test_create):
(TestRadar.test_create_prompt):

Canonical link: ​https://commits.webkit.org/249039@main

4:54 PM Changeset in webkit [292131] by Alan Coon

• 1 copy in tags/Safari-613.2.4.0.2

Tag Safari-613.2.4.0.2.

4:50 PM Changeset in webkit [292130] by Alan Coon

• 1 copy in tags/Safari-613.2.4.1.2

Tag Safari-613.2.4.1.2.

4:44 PM Changeset in webkit [292129] by Alan Coon

• 4 edits in branches/safari-613-branch

Cherry-pick r290371. rdar://problem/88652375

Call WKNavigationDelegate.didFailProvisionalNavigation even after a cross-origin navigation with COOP
​https://bugs.webkit.org/show_bug.cgi?id=237071
<rdar://88652375>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-02-23
Reviewed by Chris Dumez.

Source/WebKit:

There was an assumption that this callback wasn't needed in this case, but it is.
Covered by an API test that verifies the callback is received.

• UIProcess/ProvisionalPageProxy.cpp: (WebKit::ProvisionalPageProxy::didFailProvisionalLoadForFrame):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm: (TEST):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:33 PM Changeset in webkit [292128] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction()
​https://bugs.webkit.org/show_bug.cgi?id=238559

Reviewed by Darin Adler.

Use dispatch_source_create(DISPATCH_SOURCE_TYPE_SIGNAL, SIGTERM) in setOSTransaction() instead of a
low-level signal(SIGTERM) handler, as recommended by the XPC team.

This is better becomes it has less limitations about what you can do in the handler. It is also
possible to set several handlers this way, in different parts of the code (i.e. also not worry about
some other code overriding our handler).

• Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::setOSTransaction):

4:23 PM Changeset in webkit [292127] by Alan Bujtas

• 5 edits in trunk

[CSS contain] Containment disables the special handling of the HTML body element for overflow viewport propagation.
​https://bugs.webkit.org/show_bug.cgi?id=238526

Reviewed by Simon Fraser.

Source/WebCore:

​https://www.w3.org/TR/css-overflow-3/#overflow-propagation

"...UAs must apply the overflow-* values set on the root element to the viewport when the root element’s display value is not none.
However, when the root element is an html element whose overflow value is visible, and that element has as a
child a body element whose display value is also not none, user agents must instead apply the
overflow-* values of the first such child element to the viewport.
The element from which the value is propagated must then have a used overflow value of visible.

Note: Using containment disables this special handling of the HTML body element..."

• rendering/RenderBox.cpp:

(WebCore::RenderBox::updateFromStyle):

LayoutTests:

• TestExpectations:
• fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping-expected.html:
• fast/layers/parent-clipping-overflow-is-overwritten-by-child-clipping.html:

4:19 PM Changeset in webkit [292126] by sihui_liu@apple.com

• 6 edits in trunk

Remove -[WKWebsiteDataStore _indexedDBDatabaseDirectory]
​https://bugs.webkit.org/show_bug.cgi?id=238487

Reviewed by Alex Christensen.

Source/WebKit:

This is not used by SPI clients, and we have -[_WKWebsiteDataStoreConfiguration _indexedDBDatabaseDirectory].

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _indexedDBDatabaseDirectory]): Deleted.

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm:

(createDirectories):
(TEST):

• TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:

(TEST):

3:59 PM Changeset in webkit [292125] by Alan Coon

• 1 copy in tags/Safari-613.2.4.3.1

Tag Safari-613.2.4.3.1.

3:59 PM Changeset in webkit [292124] by Alan Coon

• 1 delete in tags/Safari-613.2.4.3.1

Delete tag.

3:56 PM Changeset in webkit [292123] by Alan Coon

• 1 copy in tags/Safari-613.2.4.3.1

Tag Safari-613.2.4.3.1.

2:56 PM Changeset in webkit [292122] by Jonathan Bedard

• 3 edits in trunk/Tools

[Merge-Queue] Add http credential helper
​https://bugs.webkit.org/show_bug.cgi?id=238553
<rdar://problem/91044821>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(CheckOutPullRequest.run): Add credential helper that pulls http credentials
from environment variables.

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/249035@main

2:07 PM Changeset in webkit [292121] by Jonathan Bedard

• 2 edits in trunk/Tools

[Merge-Queue] Add Reviewers to commit message (Follow-up fix)
​https://bugs.webkit.org/show_bug.cgi?id=238354
<rdar://problem/90800671>

Reviewed by Aakash Jain.

• Tools/CISupport/ews-build/steps.py:

(AddReviewerMixin.gitCommitEnvironment) Renamed from environment:
(AddReviewerToCommitMessage.start):
(AddReviewerToChangeLog.run):
(AddReviewerMixin.environment): Renamed to gitCommitEnvironment.

Canonical link: ​https://commits.webkit.org/249034@main

1:55 PM Changeset in webkit [292120] by Devin Rousso

• 26 edits in trunk/Source

Web Inspector: Sources: the mapped file URL of a Response Local Override should be clickable
​https://bugs.webkit.org/show_bug.cgi?id=238533

Reviewed by Patrick Angle.

Source/WebCore:

• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:
• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::revealFileExternally): Added.
Add a helper for selecting a file in the system file explorer.

• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::revealFileExternally): Added.
Do nothing in tests (and WK1) as there is no way to check for another app being opened.

Source/WebInspectorUI:

• UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView.prototype._handleMappedFilePathChanged):
Instead of showing the mapped file path as basic text, linkify it such that it is shown in
the system file explorer when clicked.

• UserInterface/Base/Main.js:

(WI.createMessageTextView):
Allow the message to be a Node (in addition to a String).

Source/WebKit:

• WebProcess/Inspector/RemoteWebInspectorUI.h:
• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::revealFileExternally): Added.

• WebProcess/Inspector/WebInspectorUI.h:
• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::revealFileExternally): Added.

• UIProcess/Inspector/WebInspectorUIProxy.messages.in:
• UIProcess/Inspector/WebInspectorUIProxy.h:
• UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::revealFileExternally): Added.
(WebKit::WebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.mm:

(WebKit::WebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/win/WebInspectorUIProxyWin.mm:

(WebKit::WebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
• UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
• UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::revealFileExternally): Added.
(WebKit::RemoteWebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformRevealFileExternally): Added.

• UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformRevealFileExternally): Added.
Add a helper for selecting a file in the system file explorer.

1:51 PM Changeset in webkit [292119] by sihui_liu@apple.com

• 5 edits in trunk

Avoid initializing default WKWebsiteDataStore in -[WKWebViewConfiguration copyWithZone]
​https://bugs.webkit.org/show_bug.cgi?id=238531
rdar://90628101

Reviewed by Tim Horton.

Source/WebKit:

API test: WKWebsiteDataStore.DoNotCreateDefaultDataStore

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:

(TestWebKitAPI::TEST):

1:41 PM Changeset in webkit [292118] by Chris Dumez

• 74 edits in trunk/Source

Optimize the construction of a JSC::Identifier from an ASCIILiteral
​https://bugs.webkit.org/show_bug.cgi?id=238552

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

There are two ways to construct a JSC::Identifier from a string literal and both
were sub-optimal:

• template<unsigned charactersCount> static Identifier fromString(VM&, const char (&characters)[charactersCount]): Even though it knows the charactersCount at compile time, it doesn't leverage this information at all. Also, it ends up calling AtomStringImpl::add() instead of AtomStringImpl::addLiteral() which means we lose the knowledge that it was a string literal and the optimization that come with it (e.g. not copying the characters over). In this patch, I am deprecating this function in favor of fromString(ASCIILiteral) which is now more efficient. I'll remove it in a follow up.
• static Identifier fromString(VM&, ASCIILiteral): It ended up calling the Identifier(VM&, String) constructor which meant that we were potentially constructing a String/StringImpl unnecessarily before atomizing it since the string may already be in the AtomString table. We also failed to use the smallStrings cache for literals whose length is 1, which would happen when calling fromString(VM&, const char (&characters)[charactersCount]).

In this patch, I optimized fromString(VM&, ASCIILiteral) to leverage the smallStrings cache
when necessary and call AtomStringImpl::addLiteral() instead of AtomStringImpl::add(). I also
made sure to mark fromString(VM&, ASCIILiteral) and Identifier(VM&, ASCIILiteral) as
ALWAYS_INLINE to make sure the compiler can optimize out the strlen() calls.

According to A/B bots, this is a 1-1.5% progression on Speedometer and and a 1.3% progression on
JetStream on iMac 20,1 (Intel). Sadly, this is perf-neutral on those two benchmarks on Apple
Silicon.

• API/JSAPIGlobalObject.mm:

(JSC::JSAPIGlobalObject::moduleLoaderCreateImportMetaProperties):

• API/JSBase.cpp:

(JSGetMemoryUsageStatistics):

• API/JSObjectRef.cpp:

(JSObjectMakeFunction):

• builtins/BuiltinNames.cpp:

(JSC::BuiltinNames::BuiltinNames):

• builtins/BuiltinUtils.h:
• dynbench.cpp:
• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::functionDetails):
(Inspector::constructInternalProperty):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetEntries):
(Inspector::JSInjectedScriptHost::iteratorEntries):

• inspector/JSJavaScriptCallFrame.cpp:

(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):

• inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

• inspector/agents/InspectorAuditAgent.cpp:

(Inspector::InspectorAuditAgent::populateAuditObject):

• jsc.cpp:

(GlobalObject::moduleLoaderCreateImportMetaProperties):
(JSC_DEFINE_HOST_FUNCTION):
(dumpException):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::hostResolveImportedModule):

• runtime/AtomicsObject.cpp:

(JSC::AtomicsObject::finishCreation):

• runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

• runtime/FinalizationRegistryPrototype.cpp:

(JSC::FinalizationRegistryPrototype::finishCreation):

• runtime/Identifier.cpp:

(JSC::Identifier::addLiteral):

• runtime/Identifier.h:

(JSC::Identifier::Identifier):

• runtime/IdentifierInlines.h:

(JSC::Identifier::fromString):

• runtime/IntlLocale.cpp:

(JSC::IntlLocale::textInfo):
(JSC::IntlLocale::weekInfo):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::resolvedOptions const):
(JSC::IntlNumberFormat::formatToPartsInternal):

• runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::resolvedOptions const):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::exposeDollarVM):

• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::finishCreation):

• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):

• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):

• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

• runtime/SymbolConstructor.cpp:
• tools/JSDollarVM.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):
(JSC::JSDollarVM::finishCreation):

• wasm/js/JSWebAssemblyGlobal.cpp:

(JSC::JSWebAssemblyGlobal::type):

• wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::type):

• wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::type):

• wasm/js/WebAssemblyGlobalConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

• wasm/js/WebAssemblyTagPrototype.cpp:

(JSC::JSC_DEFINE_HOST_FUNCTION):

Source/WebCore:

Adopt the JSC::Identifier constructor from an ASCIILiteral more widely.

• Modules/applepay-ams-ui/ApplePayAMSUIPaymentHandler.cpp:

(WebCore::ApplePayAMSUIPaymentHandler::finishSession):

• Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::update):

• Modules/webaudio/AudioWorkletGlobalScope.cpp:

(WebCore::AudioWorkletGlobalScope::registerProcessor):

• Modules/webaudio/AudioWorkletProcessor.cpp:

(WebCore::AudioWorkletProcessor::process):

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue const):
(WebCore::JSDOMWindow::setOpener):
(WebCore::JSDOMWindow::setOpenDatabase):

• bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

• bindings/js/JSImageDataCustom.cpp:

(WebCore::toJSNewlyCreated):

• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::createImportMetaProperties):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent):
(addUnscopableProperties):
(GenerateImplementation):
(GenerateAttributeSetterBodyDefinition):
(GenerateDefaultToJSONOperationDefinition):
(GenerateCallbackImplementationContent):
(GenerateConstructorHelperMethods):

• bindings/scripts/test/JS/JSExposedStar.cpp:

(WebCore::JSExposedStarPrototype::finishCreation):

• bindings/scripts/test/JS/JSExposedToWorkerAndWindow.cpp:

(WebCore::convertDictionary<ExposedToWorkerAndWindow::Dict>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::setJSTestCEReactions_stringifierAttributeSetter):
(WebCore::setJSTestCEReactions_stringifierAttributeNotNeededSetter):

• bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::convertDictionary<TestCallbackInterface::Dictionary>):
(WebCore::JSTestCallbackInterface::callbackWithNoParam):
(WebCore::JSTestCallbackInterface::callbackWithArrayParam):
(WebCore::JSTestCallbackInterface::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallbackInterface::callbackWithStringList):
(WebCore::JSTestCallbackInterface::callbackWithBoolean):
(WebCore::JSTestCallbackInterface::callbackRequiresThisToPass):
(WebCore::JSTestCallbackInterface::callbackWithAReturnValue):
(WebCore::JSTestCallbackInterface::callbackThatRethrowsExceptions):
(WebCore::JSTestCallbackInterface::callbackWithThisObject):

• bindings/scripts/test/JS/JSTestConditionalIncludes.cpp:

(WebCore::JSTestConditionalIncludesDOMConstructor::initializeProperties):
(WebCore::JSTestConditionalIncludesPrototype::finishCreation):

• bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp:

(WebCore::JSTestConditionallyReadWritePrototype::finishCreation):

• bindings/scripts/test/JS/JSTestDefaultToJSON.cpp:

(WebCore::JSTestDefaultToJSONPrototype::finishCreation):
(WebCore::jsTestDefaultToJSONPrototypeFunction_toJSONBody):

• bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp:

(WebCore::JSTestDefaultToJSONFilteredByExposedPrototype::finishCreation):
(WebCore::jsTestDefaultToJSONFilteredByExposedPrototypeFunction_toJSONBody):

• bindings/scripts/test/JS/JSTestDefaultToJSONInherit.cpp:

(WebCore::jsTestDefaultToJSONInheritPrototypeFunction_toJSONBody):

• bindings/scripts/test/JS/JSTestDefaultToJSONInheritFinal.cpp:

(WebCore::jsTestDefaultToJSONInheritFinalPrototypeFunction_toJSONBody):

• bindings/scripts/test/JS/JSTestDerivedDictionary.cpp:

(WebCore::convertDictionary<TestDerivedDictionary>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestDerivedDictionary2.cpp:

(WebCore::convertDictionary<TestDerivedDictionary2>):
(WebCore::convertDictionaryToJS):
(WebCore::convertDictionary<TestDerivedDictionary2::Dictionary>):

• bindings/scripts/test/JS/JSTestDictionary.cpp:

(WebCore::convertDictionary<TestDictionary>):

• bindings/scripts/test/JS/JSTestDictionaryWithOnlyConditionalMembers.cpp:

(WebCore::convertDictionary<TestDictionaryWithOnlyConditionalMembers>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingDOMConstructor::initializeProperties):
(WebCore::JSTestEnabledBySettingPrototype::finishCreation):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::convertDictionary<TestEventConstructor::Init>):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):

• bindings/scripts/test/JS/JSTestInheritedDictionary.cpp:

(WebCore::convertDictionary<TestInheritedDictionary>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestInheritedDictionary2.cpp:

(WebCore::convertDictionary<TestInheritedDictionary2>):
(WebCore::convertDictionaryToJS):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfacePrototype::finishCreation):

• bindings/scripts/test/JS/JSTestNamespaceObject.cpp:

(WebCore::JSTestNamespaceObjectDOMConstructor::initializeProperties):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::jsTestNodePrototypeFunction_toJSONBody):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionaryToJS):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldTolerateNull>):
(WebCore::convertDictionary<AlternateDictionaryName>):
(WebCore::convertDictionary<TestObj::ParentDictionary>):
(WebCore::convertDictionary<TestObj::ChildDictionary>):
(WebCore::convertDictionary<TestObj::ConditionalDictionaryA>):
(WebCore::convertDictionary<TestObj::ConditionalDictionaryB>):
(WebCore::convertDictionary<TestObj::ConditionalDictionaryC>):
(WebCore::JSTestObjDOMConstructor::initializeProperties):
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::setJSTestObj_putForwardsAttributeSetter):
(WebCore::setJSTestObj_putForwardsNullableAttributeSetter):

• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::convertDictionary<TestPromiseRejectionEvent::Init>):

• bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:

(WebCore::convertDictionary<DictionaryImplName>):
(WebCore::convertDictionaryToJS):

• html/HTMLMediaElement.cpp:

(WebCore::controllerJSValue):
(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):

1:20 PM Changeset in webkit [292117] by Antti Koivisto

• 7 edits in trunk

[CSS Container Queries] Keep colon syntax when serializing container condition
​https://bugs.webkit.org/show_bug.cgi?id=238542

Reviewed by Tim Nguyen.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt:
• web-platform-tests/css/css-contain/container-queries/at-container-serialization.html:

Source/WebCore:

Don't switch to the range syntax when serializing (min-width: 100px) and similar.

• css/ContainerQuery.cpp:

(WebCore::CQ::serialize):

Add an enum that remembers the syntax used and use it when deciding how to serialize.

• css/ContainerQuery.h:
• css/ContainerQueryParser.cpp:

(WebCore::consumeFeatureName):
(WebCore::ContainerQueryParser::consumePlainSizeFeature):

Also fix a bug where plain size feature names were not lowercased.

(WebCore::ContainerQueryParser::consumeRangeSizeFeature):

12:14 PM Changeset in webkit [292116] by Alan Coon

• 9 edits in branches/safari-613.1.17.1-branch/Source

Revert "Versioning."

This reverts r292115.

12:07 PM Changeset in webkit [292115] by Alan Coon

• 9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.15

11:46 AM Changeset in webkit [292114] by Alan Coon

• 12 edits in branches/safari-613.2.4.1-branch/Source/WebKit

Revert r289292. rdar://90113314

This reverts r289292.

11:46 AM Changeset in webkit [292113] by Alan Coon

• 14 edits
  2 adds in branches/safari-613.2.4.1-branch

Revert r290708. rdar://90113314

This reverts r290708.

11:44 AM Changeset in webkit [292112] by Alan Coon

• 12 edits in branches/safari-613.2.4.0-branch/Source/WebKit

Revert r289292. rdar://90113314

This reverts r289292.

11:44 AM Changeset in webkit [292111] by Alan Coon

• 14 edits
  2 adds in branches/safari-613.2.4.0-branch

Revert r290708. rdar://90113314

This reverts r290708.

11:40 AM Changeset in webkit [292110] by youenn@apple.com

• 38 edits
  1 copy in trunk

Implement persistent notification handling
​https://bugs.webkit.org/show_bug.cgi?id=238498

Reviewed by Brady Eidson.

Source/WebCore:

Before the patch, we were directly going from UIProcess to service worker process.
This works if the service worker is running but does not otherwise.
To make sure we now go to NetworkProcess.
To implement ​https://notifications.spec.whatwg.org/#persistent-notification,
we add a service worker registration URL to NotficationData.
We remove the notfication handling going through NotificationEvent and make it Document specific.
Instead, we go through ServiceWorkerThreadProxy.
Make sure SWServer treats notification events as functional events.
Covered by updated test.

• Headers.cmake:
• Modules/notifications/Notification.cpp:

(WebCore::Notification::create):
(WebCore::Notification::dispatchClickEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::data const):

• Modules/notifications/Notification.h:
• Modules/notifications/NotificationData.cpp:

(WebCore::NotificationData::isolatedCopy const):
(WebCore::NotificationData::isolatedCopy):

• Modules/notifications/NotificationData.h:

(WebCore::NotificationData::encode const):
(WebCore::NotificationData::decode):

• Modules/notifications/NotificationEvent.h:
• Modules/notifications/NotificationEventType.h: Added.
• WebCore.xcodeproj/project.pbxproj:
• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::postTaskToFireNotificationEvent): Deleted.

• workers/service/ServiceWorkerGlobalScope.h:
• workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::fireNotificationEvent):

• workers/service/context/SWContextManager.h:
• workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::queueTaskToFirePushSubscriptionChangeEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireNotificationEvent):
(WebCore::ServiceWorkerThread::startFunctionalEventMonitoring):
(WebCore::ServiceWorkerThread::heartBeatTimerFired):
(WebCore::ServiceWorkerThread::startPushEventMonitoring): Deleted.

• workers/service/context/ServiceWorkerThread.h:

(WebCore::ServiceWorkerThread::stopFunctionalEventMonitoring):
(WebCore::ServiceWorkerThread::stopPushEventMonitoring): Deleted.

• workers/service/context/ServiceWorkerThreadProxy.cpp:

(WebCore::ServiceWorkerThreadProxy::~ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::firePushEvent):
(WebCore::ServiceWorkerThreadProxy::fireNotificationEvent):

• workers/service/context/ServiceWorkerThreadProxy.h:
• workers/service/server/SWServer.cpp:

(WebCore::SWServer::unregisterServiceWorkerClient):
(WebCore::SWServer::processPushMessage):
(WebCore::SWServer::processNotificationEvent):

• workers/service/server/SWServer.h:
• workers/service/server/SWServerToContextConnection.h:
• workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::decrementFunctionalEventCounter):
(WebCore::SWServerWorker::terminateIfPossible):
(WebCore::SWServerWorker::decrementPushEventCounter): Deleted.

• workers/service/server/SWServerWorker.h:

(WebCore::SWServerWorker::incrementFunctionalEventCounter):
(WebCore::SWServerWorker::shouldContinue const):
(WebCore::SWServerWorker::incrementPushEventCounter): Deleted.

Source/WebKit:

When receiving an update for a notification, check if the notification is tied to a service worker registration.
If so, go to network process to fire a functional event, as per ​https://notifications.spec.whatwg.org/#activating-a-notification
and ​https://notifications.spec.whatwg.org/#ref-for-fire-a-service-worker-notification-event①
UIProcess sends the corresponding NotficationData to NetworkProcess.
NetworkProcess gets the service worker registration, runs the service worker as needed and fires the functional event.
Add IPC plumbing code to support this flow.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processNotificationEvent):
(WebKit::NetworkProcess::processPushMessage):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::firePushEvent):
(WebKit::WebSWServerToContextConnection::fireNotificationEvent):

• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::processNotificationEvent):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Notifications/WebNotification.cpp:

(WebKit::WebNotification::WebNotification):

• UIProcess/Notifications/WebNotification.h:

(WebKit::WebNotification::title const):
(WebKit::WebNotification::body const):
(WebKit::WebNotification::iconURL const):
(WebKit::WebNotification::tag const):
(WebKit::WebNotification::lang const):
(WebKit::WebNotification::dir const):
(WebKit::WebNotification::coreNotificationID const):
(WebKit::WebNotification::sessionID const):
(WebKit::WebNotification::data const):
(WebKit::WebNotification::isPersistentNotification const):
(WebKit::WebNotification::notificationID const):

• UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::dispatchDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):

• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::fireNotificationEvent):

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

• http/tests/workers/service/shownotification-allowed.html:

11:39 AM Changeset in webkit [292109] by clopez@igalia.com

• 8 edits
  4 adds in trunk

[GTK][WPE] generate-bundle: self-contained bundle for the MiniBrowser that can work on any distro
​https://bugs.webkit.org/show_bug.cgi?id=237107

Rubber-stamped by Philippe Normand.

Source/WebCore:

No new tests, no change in behaviour.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession): Allow to load the TLS database specified on the
environment variable WEBKIT_TLS_CAFILE_PEM when DEVELOPER_MODE is enabled

• platform/network/soup/SoupVersioning.h:

(soup_session_set_tls_database):

Tools:

This implements in the generate-bundle script the support to generate a bundle self-contained that can work on any distro.
To achieve that the bundle contains all the required system libraries inside the bundle (even the graphics drivers).
It also contains the required system resources: icons (for gtk), fontconfig files and fonts, etc.
A custom dlopenwrap library is also added and preloaded. The purpose of this library is to wrap all dlopen() calls
and rewrite the paths to ensure that only libraries inside the bundle are loaded.

The bundle has been tested to be generated with the flatpak build and executed on a range of very different distributions
with sucess: Fedora, Ubuntu, Debian, Alpine, CentOS (different versions of each)

• Scripts/bundle-binary:
• Scripts/generate-bundle:
• Scripts/webkitpy/binary_bundling/bundle.py:

(BinaryBundler):
(BinaryBundler.init):
(BinaryBundler._is_system_dep):
(BinaryBundler.set_use_sys_lib_directory):
(BinaryBundler.copy_and_maybe_strip_patchelf):
(BinaryBundler.destination_dir):
(BinaryBundler.generate_wrapper_script):
(BinaryBundler.copy_and_remove_rpath): Deleted.

• Scripts/webkitpy/binary_bundling/dlopenwrap/Makefile: Added.
• Scripts/webkitpy/binary_bundling/dlopenwrap/README.txt: Added.
• Scripts/webkitpy/binary_bundling/dlopenwrap/dlopenwrap.c: Added.

(dlopen_wrapper_path_join):
(is_dir):
(dlopen_wrapper_recursive_find):
(dlopen_wrapper_get_path_for_file_under_dir):
(dlopen_wrapper_find_library_on_libpath):
(dlopen):
(dlmopen):
(dlerror):

• Scripts/webkitpy/style/checker.py:

10:38 AM Changeset in webkit [292108] by Russell Epstein

• 1 copy in tags/Safari-614.1.7.4

Tag Safari-614.1.7.4.

10:01 AM Changeset in webkit [292107] by Devin Rousso

• 2 edits in trunk/LayoutTests

Unreviewed, fix test after r285521 and r271735

• http/tests/paymentrequest/updateWith-shippingOptions.https.html:

Remove a duplicate assert_equals added in r271735 (which should've been removed in r285521).
Drive-by: Also check that the selected of each provided shipping method/option matches.

8:08 AM WebKitGTK/2.36.x edited by Michael Catanzaro

(diff)

7:56 AM Changeset in webkit [292106] by Chris Dumez

• 20 edits in trunk/Source

Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets
​https://bugs.webkit.org/show_bug.cgi?id=238521

Reviewed by Geoffrey Garen.

Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets using an ASCIILiteral,
without the need for allocating a String.

Source/WebCore:

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::packageFormData):

• Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::installReplacement):

• Modules/websockets/WebSocketDeflateFramer.cpp:

(WebCore::WebSocketExtensionDeflateFrame::processResponse):

• loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::allowsCrossOriginMethod const):
(WebCore::CrossOriginPreflightResultCacheItem::validateCrossOriginHeaders const):

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::filter):
(WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting):

Source/WebKit:

• Shared/mac/AuxiliaryProcessMac.mm:

(WebKit::getUserDirectorySuffix):

• UIProcess/AuxiliaryProcessProxy.cpp:

(WebKit::AuxiliaryProcessProxy::getLaunchOptions):

• UIProcess/Launcher/cocoa/ProcessLauncherCocoa.mm:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:

(WebKit::ProcessLauncher::launchProcess):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

• UIProcess/glib/WebProcessProxyGLib.cpp:

(WebKit::WebProcessProxy::platformGetLaunchOptions):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):

Source/WTF:

• wtf/text/StringImpl.h:
• wtf/text/WTFString.h:

(WTF::HashTranslatorASCIILiteral::hash):
(WTF::HashTranslatorASCIILiteral::equal):
(WTF::HashTranslatorASCIILiteral::translate):

6:28 AM Changeset in webkit [292105] by youenn@apple.com

• 18 edits in trunk

Implement ServiceWorker WindowClient.ancestorOrigins
​https://bugs.webkit.org/show_bug.cgi?id=238441

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/idlharness.https.any.serviceworker-expected.txt:

Source/WebCore:

Add ancestorOrigins to ServiceWorkerClientData.
Migrate client map to UniqueRef since ServiceWorkerClientData size goes above 128.

Covered by updated tests.

• workers/service/ServiceWorkerClientData.cpp:
• workers/service/ServiceWorkerClientData.h:
• workers/service/ServiceWorkerWindowClient.h:
• workers/service/ServiceWorkerWindowClient.idl:
• workers/service/server/SWServer.cpp:
• workers/service/server/SWServer.h:

Source/WebKit:

• NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::controlClient):

Source/WTF:

Update UniqueRef and HashTraits to not use a private constructor when creating empty values.

• wtf/HashTraits.h:
• wtf/UniqueRef.h:

LayoutTests:

• http/wpt/service-workers/resources/third-party-worker.js:
• http/wpt/service-workers/third-party-registration.html:

5:58 AM Changeset in webkit [292104] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Slim down ANGLEHeaders.h
​https://bugs.webkit.org/show_bug.cgi?id=238539

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-03-30
Reviewed by Adrian Perez de Castro.

Define the EGL_NO_PLATFORM_SPECIFIC_TYPES macro in ANGLEHeaders.h before
including the ANGLE entrypoint headers. These will subsequently include
EGL's platform headers, but the macro prevents including additional
platform-specific headers (e.g. X11 development headers) that often
bring in additional generically-named identifiers and macros that end up
colliding with WebCore and WebKit types. The libepoxy header inclusion
is also removed, it should be done where necessary and not everywhere
ANGLEHeaders.h ends up included.

• platform/graphics/angle/ANGLEHeaders.h:
• platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:
• platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h:

5:04 AM Changeset in webkit [292103] by commit-queue@webkit.org

• 2 edits
  2 adds
  1 delete in trunk/Tools/buildstream

[Flatpak SDK] Bump to Meson 0.62.
​https://bugs.webkit.org/show_bug.cgi?id=238454

Patch by Philippe Normand <​pnormand@igalia.com> on 2022-03-30
Reviewed by Adrian Perez de Castro.

Needed for meson devenv --dump support in local dependencies builds.

• elements/freedesktop-sdk.bst:
• patches/fdo-0001-gobject-introspection-Bump-to-1.72.patch: Added.
• patches/fdo-0001-meson-Bump-to-0.60.3.patch: Removed.
• patches/fdo-0002-meson-Bump-to-1.62.patch: Added.

2:48 AM Changeset in webkit [292102] by commit-queue@webkit.org

• 12 edits in trunk/Source/WebKit

Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
​https://bugs.webkit.org/show_bug.cgi?id=238504

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2022-03-30
Reviewed by Chris Dumez.

Move connection port/socket/pipe pair creation function from AuxiliaryProcess
to IPC::Connection. This way other components than AuxiliaryProcess subclasses
can create and send new connections.

No new tests, refactor.

• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::createGPUConnectionToWebProcess):

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::createNetworkConnectionToWebProcess):

• Platform/IPC/Connection.cpp:

(IPC::Connection::createConnectionIdentifierPair):

• Platform/IPC/Connection.h:
• Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::Connection::createConnectionIdentifierPair):

• Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::createConnectionIdentifierPair):

• Platform/IPC/win/ConnectionWin.cpp:

(IPC::Connection::createConnectionIdentifierPair):

• Shared/AuxiliaryProcess.cpp:
• Shared/AuxiliaryProcess.h:
• WebAuthnProcess/WebAuthnProcess.cpp:

(WebKit::WebAuthnProcess::createWebAuthnConnectionToWebProcess):

• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::updateConnection):

1:32 AM Changeset in webkit [292101] by mark.lam@apple.com

• 4 edits in trunk/Source/JavaScriptCore

Remove obsolete --useProbeOSRExit option.
​https://bugs.webkit.org/show_bug.cgi?id=238534

Reviewed by Saam Barati.

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

• runtime/Options.cpp:

(JSC::Options::recomputeDependentOptions):

• runtime/OptionsList.h:

1:19 AM Changeset in webkit [292100] by Lauro Moura

• 8 edits in trunk/Source/WebCore

Unreviewed, non-unified build fixes
​https://bugs.webkit.org/show_bug.cgi?id=238536

• contentextensions/ContentExtensionError.cpp:
• contentextensions/ContentExtensionError.h:
• css/ContainerQuery.cpp:
• html/HTMLTextFormControlElement.cpp:
• inspector/InspectorFrontendHost.cpp:
• page/Page.cpp:
• page/csp/ContentSecurityPolicyDirectiveNames.cpp:

12:41 AM Changeset in webkit [292099] by Pablo Saavedra

• 2 edits in trunk/Source/WebKit

[GTK][WPE] Exit cleanly if Connection to UIProcess severed. Regression (r214307)
​https://bugs.webkit.org/show_bug.cgi?id=235224

This patch reverts the WPE and GTK specific code removed in '[WK2] Make
establishing a connection between the WebProcess and the Network process more
robust' (r12345):

GTK+ and WPE ports don't exit on send sync message failure. In those particular
cases, the network process can be terminated by the UI process while the
Web process is still initializing, so we always want to exit instead of crashing. This can
happen when the WebView is created and then destroyed quickly.
See ​https://bugs.webkit.org/show_bug.cgi?id=183348.

Reviewed by Carlos Garcia Campos.

• WebProcess/WebProcess.cpp:

(WebKit::getNetworkProcessConnection):
(WebKit::WebProcess::getGPUProcessConnection):
(WebKit::getWebAuthnProcessConnection):

12:22 AM Changeset in webkit [292098] by mmaxfield@apple.com

• 3 edits in trunk/Source/WebGPU

[WebGPU] Refactor isDepthOrStencilFormat() for upcoming data transfer patches
​https://bugs.webkit.org/show_bug.cgi?id=238427

Reviewed by Kimmo Kinnunen.

This exposes isDepthOrStencilFormat() outside of Texture.mm, and changes its implementation
to use depthSpecificFormat() and stencilSpecificFormat(), which will become useful in the
implementation of subsequent data transfer patches.

• WebGPU/Texture.h:
• WebGPU/Texture.mm:

(WebGPU::depthSpecificFormat):
(WebGPU::stencilSpecificFormat):
(WebGPU::Texture::containsDepthAspect):
(WebGPU::Texture::containsStencilAspect):
(WebGPU::Texture::isDepthOrStencilFormat):
(WebGPU::Device::validateCreateTexture):
(WebGPU::isDepthOrStencilFormat): Deleted.

12:03 AM Changeset in webkit [292097] by Jean-Yves Avenard

• 2 edits in trunk/Source/WebKit

Window is too small after entering and exiting video/element fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=238488
rdar://89363964

Reviewed by Tim Horton.

Don't change the size of the window to the size of the element.

• UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):

Mar 29, 2022:

11:37 PM Changeset in webkit [292096] by Fujii Hironori

• 3 edits
  1 delete in trunk/LayoutTests

[WinCairo] Unreviewed test gardening

• platform/wincairo-wk1/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wincairo/fast/text/softHyphen-expected.txt: Removed.

11:12 PM Changeset in webkit [292095] by Brandon

• 2 edits in trunk/Source/WebCore

Ensure m_layerRulesBeforeImportRules is properly copied during StyleSheetContents instantiation
​https://bugs.webkit.org/show_bug.cgi?id=238537

Reviewed by Antti Koivisto.

During the instantiation of the StyleSheetContents the m_layerRulesBeforeImportRules was not being
properly copied.

• css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::StyleSheetContents):

6:57 PM Changeset in webkit [292094] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

[GCC] Ubuntu LTS build broken after r291956
​https://bugs.webkit.org/show_bug.cgi?id=238481

Reviewed by Darin Adler.

Default comparisons by value (P1946R0) is only supported since GCC10.
​https://en.cppreference.com/w/cpp/compiler_support/20

• rendering/style/StyleGridData.h:

(WebCore::GridTrackEntrySubgrid::operator== const):
(WebCore::GridTrackEntryRepeat::operator== const):
(WebCore::GridTrackEntryAutoRepeat::operator== const):

6:36 PM Changeset in webkit [292093] by Alan Coon

• 87 edits
  3 deletes in branches/safari-613-branch

Apply patch. rdar://problem/89997669

6:36 PM Changeset in webkit [292092] by Alan Coon

• 3 edits in branches/safari-613-branch

Apply patch. rdar://problem/89997669

6:35 PM Changeset in webkit [292091] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebCore

Cherry-pick r291494. rdar://problem/90957324

Keep a strong reference to session in [WebCoreNSURLSessionDataTask _restart]
​https://bugs.webkit.org/show_bug.cgi?id=238061
<rdar://88242622>

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-03-18
Reviewed by Eric Carlson.

_session is a WeakObjCPtr<WebCoreNSURLSession> and since we're not using ARC self.session
returns a raw pointer to an object that may be deallocated and null out its loader on a different thread.
To prevent null crashes, keep a strong reference to the session when using it.

• platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSession dealloc]): (-[WebCoreNSURLSessionDataTask _restart]):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:35 PM Changeset in webkit [292090] by Alan Coon

• 2 edits in branches/safari-613-branch/Source/WebKit

Cherry-pick r290840. rdar://problem/90957274

[WebAuthn] Don't use decidePolicyForLocalAuthenticator for Web Authentication Modern
​https://bugs.webkit.org/show_bug.cgi?id=225646
rdar://78147681

Reviewed by Brent Fulgham.

decidePolicyForLocalAuthenticator is not implemented for the _WKWebAuthenticationPanelDelegate
used for modern because the prompt to allow Touch/FaceID comes earlier in the process.

• UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticator::makeCredential):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:35 PM Changeset in webkit [292089] by Alan Coon

• 3 edits in branches/safari-613-branch

Cherry-pick r290392. rdar://problem/90957261

[WebAuthn] Improve error message for missing pubKeyCredParams
​https://bugs.webkit.org/show_bug.cgi?id=235421
rdar://87884875

Reviewed by Brent Fulgham.

Source/WebCore:

We have seen confusion from library authors around the language
used in this error not indicating enough information about what
the problem is. This patch adds additional information, useful
to developers seeing this error.

• Modules/webauthn/AuthenticatorCoordinator.cpp: (WebCore::AuthenticatorCoordinator::create const):

LayoutTests:

Update test to reflect new error message.

• http/wpt/webauthn/public-key-credential-create-failure.https.html:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@290392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6:27 PM Changeset in webkit [292088] by Alan Coon

• 9 edits in branches/safari-613.2.4.1-branch/Source

Versioning.

WebKit-7613.2.4.1.2

6:23 PM Changeset in webkit [292087] by Alan Coon

• 9 edits in branches/safari-613.2.4.0-branch/Source

Versioning.

WebKit-7613.2.4.0.2

5:34 PM Changeset in webkit [292086] by Tyler Wilcock

• 10 edits
  3 adds in trunk

AX: Don't detach children in AXIsolatedTree::applyPendingChanges for nodes being updated (removed and added)
​https://bugs.webkit.org/show_bug.cgi?id=238460

Reviewed by Chris Fleizach and Andres Gonzalez.

Source/WebCore:

In AXIsolatedTree::updateNode, we perform the update by queuing the node to be
removed, and then queueing it to be added. When performing the removal in
AXIsolatedTree::applyPendingChanges, we call AXCoreObject::detach, which unconditionally
calls AXCoreObject::detachRemoteParts. Specifically, AXIsolatedObject::detachRemoteParts
detaches all the object's children from the itself (by setting their m_parentID to zero).
Then, when we start applying m_pendingAppends, we re-add the object, but never re-attach
the children, resulting in a broken tree.

This patch fixes this by storing the reason (AccessibilityDetachmentType) the node is
being removed in m_pendingNodeRemovals, and not detaching children if the type is
AccessibilityDetachmentType::ElementChanged, as in the case of a node update.

This patch also removes AXIsolatedObject::setParent. It's never called, and
its existence is therefore confusing.

Test: accessibility/search-traversal-after-role-change.html.
This test exercises the behavior in this patch because changing an
object's role triggers AXIsolatedTree::updateNode.

• accessibility/AccessibilityObjectInterface.h:

(WebCore::AXCoreObject::detach):

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setParent): Deleted.

• accessibility/isolatedtree/AXIsolatedObject.h:
• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::updateNode):
(WebCore::AXIsolatedTree::applyPendingChanges):

• accessibility/isolatedtree/AXIsolatedTree.h:

LayoutTests:

• accessibility/search-traversal-after-role-change-expected.txt: Added.
• accessibility/search-traversal-after-role-change.html: Added.
• platform/glib/TestExpectations: Skip new test.
• platform/ios/TestExpectations: Enable new test.
• platform/ios/accessibility/search-traversal-after-role-change-expected.txt: Added.
• platform/win/TestExpectations: Skip new test.

5:32 PM Changeset in webkit [292085] by Tyler Wilcock

• 3 edits in trunk/Source/WebCore

AXIsolatedObject::isAccessibilityObject should not be ASSERT_NOT_REACHED
​https://bugs.webkit.org/show_bug.cgi?id=238511

Reviewed by Chris Fleizach.

We try to downcast AXCoreObjects to AccessibilityObjects here in AXLogger's TextStream& operator<<(TextStream&, const AXCoreObject&):

if (auto* axObject = dynamicDowncast<AccessibilityObject>(&object); axObject && axObject->hasDisplayContents())

stream.dumpProperty("hasDisplayContents", true);

So this should not ASSERT_NOT_REACHED in AXIsolatedObject.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::isAccessibilityObject const): Deleted.

• accessibility/isolatedtree/AXIsolatedObject.h:

5:12 PM Changeset in webkit [292084] by Devin Rousso

• 44 edits
  1 copy
  3 adds in trunk

Web Inspector: Sources: allow Response Local Overrides to map to a file on disk
​https://bugs.webkit.org/show_bug.cgi?id=238236
<rdar://problem/59009154>

Reviewed by Patrick Angle.

Source/WebCore:

This makes Response Local Overrides even more powerful by allowing developers to map the
contents of the (Local Override) resource to a file on disk (e.g. a local copy of the file),
meaning that they can use their preferred editor of choice (and all the tools that may come
with it) to make changes instead of having to stay within Web Inspector.

Test: http/tests/inspector/network/local-resource-override-mapped-to-file.html

• inspector/InspectorFrontendHost.idl:
• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canLoad): Added.
(WebCore::InspectorFrontendHost::load): Added.
(WebCore::InspectorFrontendHost::getPath): Added.
Add helpers for loading the contents of a file on disk and getting the full path of a File.

• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendClientLocal.h:

(WebCore::InspectorFrontendClientLocal::canLoad): Added.
(WebCore::InspectorFrontendClientLocal::load): Added.
Do not allow file mapping in tests (and WK1).

• testing/Internals.idl:
• testing/Internals.h:
• testing/Internals.cpp:

(WebCore::Internals::createTemporaryFile): Added.
Add a way for tests to create a temporary file with given contents.

Source/WebInspectorUI:

This makes Response Local Overrides even more powerful by allowing developers to map the
contents of the (Local Override) resource to a file on disk (e.g. a local copy of the file),
meaning that they can use their preferred editor of choice (and all the tools that may come
with it) to make changes instead of having to stay within Web Inspector.

• UserInterface/Models/LocalResource.js:

(WI.LocalResource):
(WI.LocalResource.canMapToFile): Added.
(WI.LocalResource.prototype.toJSON):
(WI.LocalResource.prototype.get mappedFilePath): Added.
(WI.LocalResource.prototype.set mappedFilePath): Added.
(WI.LocalResource.prototype.async requestContent):
(WI.LocalResource.prototype.async _loadFromFileSystem): Added.

• UserInterface/Models/LocalResourceOverride.js:

(WI.LocalResourceOverride.prototype.get canMapToFile): Added.
Save the given local file path as a member variable and use InspectorFrontendHost.load to
grab its contents (saving it inside the WI.LocalResource so that it can still be used in
case the file is moved/deleted) whenever anyone requestContent.

• UserInterface/Views/ResourceContentView.js:

(WI.ResourceContentView):
(WI.ResourceContentView.prototype.get navigationItems):
(WI.ResourceContentView.prototype.showMessage):
(WI.ResourceContentView.prototype.addIssue):
(WI.ResourceContentView.prototype._contentAvailable):
(WI.ResourceContentView.prototype.async _handleMapLocalResourceOverrideToFile): Added.
(WI.ResourceContentView.prototype._handleMappedFilePathChanged): Added.
Add a new "[Disk.svg] Map to File" navigation item when viewing Response Local Overrides. If
the Response Local Override has already been mapped to a file, show the path of the file
instead of the contents of the resource. This allows us to not have to monitor the file for
changes, instead only grabbing the current contents when necessary (i.e. when replacing the
response of an intercepted network request).

• UserInterface/Views/ResourceContentView.css: Added.

(.content-view.resource > .local-resource-override-label-view + .message-text-view):
Still show the Local Override banner if the Local Override has been mapped to a file.

• UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView.prototype._contentWillPopulate):
Don't show the WI.SourceCodeTextEditor if there's already something else being shown.

• UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.async requestIntercepted):
(WI.NetworkManager.prototype.async responseIntercepted):
Make sure to requestContent before using the currentRevision so that any file-mapped
WI.LocalResource have a chance to load from disk before handling the interception.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Main.html:
• UserInterface/Images/Disk.svg: Added.

Source/WebKit:

This makes Response Local Overrides even more powerful by allowing developers to map the
contents of the (Local Override) resource to a file on disk (e.g. a local copy of the file),
meaning that they can use their preferred editor of choice (and all the tools that may come
with it) to make changes instead of having to stay within Web Inspector.

• WebProcess/Inspector/WebInspectorUI.h:
• WebProcess/Inspector/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::load): Added.
(WebKit::WebInspectorUI::canLoad): Added.

• WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::canLoad): Added.

• WebProcess/Inspector/mac/WebInspectorUIMac.mm:

(WebKit::WebInspectorUI::canLoad): Added.

• WebProcess/Inspector/win/WebInspectorUIWin.cpp:

(WebKit::WebInspectorUI::canLoad): Added.

• WebProcess/Inspector/RemoteWebInspectorUI.h:
• WebProcess/Inspector/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::load): Added.

• UIProcess/Inspector/WebInspectorUIProxy.messages.in:
• UIProcess/Inspector/WebInspectorUIProxy.h:
• UIProcess/Inspector/WebInspectorUIProxy.cpp:

(WebKit::WebInspectorUIProxy::load): Added.
(WebKit::WebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/gtk/WebInspectorUIProxyGtk.cpp:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/mac/WebInspectorUIProxyMac.mm:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/win/WebInspectorUIProxyWin.cpp:

(WebKit::WebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/RemoteWebInspectorUIProxy.messages.in:
• UIProcess/Inspector/RemoteWebInspectorUIProxy.h:
• UIProcess/Inspector/RemoteWebInspectorUIProxy.cpp:

(WebKit::RemoteWebInspectorUIProxy::initialize): Renamed from load.
(WebKit::RemoteWebInspectorUIProxy::reopen):
(WebKit::RemoteWebInspectorUIProxy::load): Added.
(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/gtk/RemoteWebInspectorUIProxyGtk.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/mac/RemoteWebInspectorUIProxyMac.mm:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.

• UIProcess/Inspector/win/RemoteWebInspectorUIProxyWin.cpp:

(WebKit::RemoteWebInspectorUIProxy::platformLoad): Added.
Add helpers for loading the contents of a file on disk.

• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(-[_WKRemoteWebInspectorViewController loadForDebuggable:backendCommandsURL:]):

• UIProcess/Inspector/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorProxy::initialize): Renamed from load.
(WebKit::RemoteInspectorClient::inspect):

• UIProcess/Inspector/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorProxy::initialize): Renamed from load.
(WebKit::RemoteInspectorClient::inspect):
Use renamed WebKit::RemoteWebInspectorUIProxy::initialize.

LayoutTests:

• http/tests/inspector/network/local-resource-override-mapped-to-file.html: Added.
• http/tests/inspector/network/local-resource-override-mapped-to-file-expected.txt: Added.

• TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/mac-wk2/TestExpectations:

Skip this test everywhere except mac-wk2.

5:08 PM Changeset in webkit [292083] by ysuzuki@apple.com

• 9 edits
  1 delete in trunk/Source/JavaScriptCore

[JSC] Use constants buffer to load JSGlobalObject in BaselineJIT thunks
​https://bugs.webkit.org/show_bug.cgi?id=238414

Reviewed by Saam Barati.

Since these thunks are only called from BaselineJIT, we can assume constants
buffer register. And since we are always using 0 index for JSGlobalObject,
we can encode this into these shared thunks directly instead of loading
CodeBlock pointer from the stack.

We also fix using OBJECT_OFFSETOF for JSGlobalObject directly. We should use
it as JSGlobalObject::offsetOfXXX to make it clean and make it annotated that
these fields are accessed by JIT.

This patch also removes UnusedPointer.h since it is no longer used.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::emitVarReadOnlyCheck):

• jit/JIT.h:
• jit/JITInlines.h:

(JSC::JIT::loadConstant):
(JSC::JIT::loadGlobalObject):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::valueIsFalseyGenerator):
(JSC::JIT::valueIsTruthyGenerator):
(JSC::JIT::op_throw_handlerGenerator):
(JSC::JIT::op_check_traps_handlerGenerator):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::slow_op_get_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_private_name_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_del_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_get_by_id_with_this_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::slow_op_put_by_id_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::generateOpResolveScopeThunk):
(JSC::JIT::generateOpGetFromScopeThunk):
(JSC::JIT::emitVarInjectionCheck):

• jit/UnusedPointer.h: Removed.
• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::offsetOfVarInjectionWatchpoint):
(JSC::JSGlobalObject::offsetOfVarReadOnlyWatchpoint):
(JSC::JSGlobalObject::offsetOfFunctionProtoHasInstanceSymbolFunction):

5:00 PM Changeset in webkit [292082] by rniwa@webkit.org

• 2 edits in trunk

Add descriptions on how to start WPT and http test servers to Introduction.md
​https://bugs.webkit.org/show_bug.cgi?id=238523

Reviewed by Chris Dumez.

• Introduction.md:

4:58 PM Changeset in webkit [292081] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[Playstation] Fix build break after r292041 when ENABLE_SERVICE_WORKER is off
​https://bugs.webkit.org/show_bug.cgi?id=238520

Patch by Jigen Zhou <​jigen.zhou@sony.com> on 2022-03-29
Reviewed by Darin Adler.

Unreviewed build fix after r292041 / r291979 for Playsation platform builds.

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

4:21 PM Changeset in webkit [292080] by commit-queue@webkit.org

• 8 edits in trunk/Source/JavaScriptCore

[JSC][ARMv7] Cleanup GPR numbering
​https://bugs.webkit.org/show_bug.cgi?id=235027

Patch by Geza Lore <Geza Lore> on 2022-03-29
Reviewed by Yusuke Suzuki.

• Make the the lower order callee save register be regCS0/llint csr0.

Some of the CSR store/restore code relies on this and using a
numbering scheme consistent with other targets (that is: regCS<N> maps
to a lower number machine register than regCS<N+1>) eliminates some
ifdefs in LLInt, and hopefully will prevent hard to find issues due to
the mismatch from other targets that all follow this rule.

• In the Thumb-2 instruction set, use of r0-r7 can often be encoded

using a shorter, 16-bit instruction. Swap regT4/regT5 with
regT7/regT6, so lower order temporaries (which are usually used first)
map to the lower order registers that can yield denser code. This
then simplifies BaselineJITRegisters.h, and also saves about ~1% DFG
code size.

• In offlineasm, prefer low order registers for temporaries.

• Also clean up baseline instanceof op implementation.

• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::initializeFromUnlinkedStructureStubInfo):

• jit/BaselineJITRegisters.h:
• jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::PreferredArgumentImpl::preferredArgumentJSR):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::slow_op_put_by_val_callSlowOperationThenCheckExceptionGenerator):
(JSC::JIT::emit_op_put_private_name):
(JSC::JIT::emitSlow_op_put_private_name):
(JSC::JIT::slow_op_put_private_name_callSlowOperationThenCheckExceptionGenerator):

• llint/LowLevelInterpreter.asm:
• offlineasm/arm.rb:

4:04 PM Changeset in webkit [292079] by Matt Woodrow

• 8 edits
  2 adds in trunk

Don't mutate children during RenderGrid::computeIntrinsicLogicalWidths unless we're about to re-layout.
​https://bugs.webkit.org/show_bug.cgi?id=237732

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children.html

• rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::advanceNextState):
(WebCore::GridTrackSizingAlgorithm::isValidTransition const):

• rendering/GridTrackSizingAlgorithm.h:
• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):

• rendering/RenderGrid.h:

computeIntrinsicLogicalWidths can re-layout children (via performGridItemsPreLayout, as well as during
the track sizing algorithm), and does so using the estimated track sizes. This can be incorrect, and if
we're not about to do a full layout on this RenderGrid, it can leave the children in an invalid state.

This caches the intrinsic sizes when we do a full layout, so that we can use these values instead when
we just want to query the RenderGrid without mutating anything.

LayoutTests:

Don't mutate children during computeIntrinsicWidth

• TestExpectations:
• fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children-expected.html: Added.
• fast/css-grid-layout/compute-intrinsic-logical-widths-should-not-mutate-children.html: Added.
• platform/ios/TestExpectations:

Marked existing WPT as passing on MacOS (since we run layout multiple times there).
Added new test for this implementation-specific bug.

3:54 PM Changeset in webkit [292078] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Use spoolers in FTL OSR exit thunk
​https://bugs.webkit.org/show_bug.cgi?id=238444

Reviewed by Mark Lam.

We deploy spoolers in FTL OSR exit thunk to reduce generated code size.
This change reduces FTLOSRExit code size in JetStream2 by 35%.

Before:

FTLOSRExit: 803564 (784.730469 KB) count 363 avg size 2213

After:

FTLOSRExit: 516432 (504.328125 KB) count 362 avg size 1426

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileExit):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

3:22 PM Changeset in webkit [292077] by Alan Coon

• 1 copy in tags/Safari-613.2.4.0.1

Tag Safari-613.2.4.0.1.

3:22 PM Changeset in webkit [292076] by Alan Coon

• 1 delete in tags/Safari-613.2.4.0.1

Delete tag.

3:10 PM Changeset in webkit [292075] by Patrick Angle

• 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Add check for null entryScope in JSC::Debugger::detach
​https://bugs.webkit.org/show_bug.cgi?id=238518

Reviewed by Devin Rousso.

A virtual machine may not always have an entryScope, which can occur if a JSGlobalObject is being destructed
(which will call into JSC::Debugger::Detach) before a VMEntryScope is created or after a VMEntryScope has
fallen out of scope, causing the VM's entryScope to be null again. In the original internal issue that led to
finding this, this most commonly occurred in conjunction with page refresh while the debugger was paused.

Because it is possible that we were previously paused in the VM that now has no entryScope, we should go ahead
and unpause.

• debugger/Debugger.cpp:

(JSC::Debugger::detach):

2:57 PM Changeset in webkit [292074] by Alan Coon

• 1 copy in tags/Safari-613.2.4.1.1

Tag Safari-613.2.4.1.1.

2:57 PM Changeset in webkit [292073] by Alan Coon

• 1 delete in tags/Safari-613.2.4.1.1

Delete tag.

2:49 PM Changeset in webkit [292072] by mmaxfield@apple.com

• 8 edits
  2 adds in trunk

[Cocoa] Automatically relayout the page when new fonts are installed
​https://bugs.webkit.org/show_bug.cgi?id=238483
<rdar://problem/80544133>

Reviewed by Chris Dumez.

Source/WebCore:

This patch simply calls setNeedsRecalcStyleInAllFrames on every Page when we receive a
kCTFontManagerRegisteredFontsChangedNotification.

FontCache::invalidateAllFontCaches() can't do this directly because it's in platform/ and
therefore isn't allowed to know what Pages are. Instead, this patch takes a process-global
callback and calls that instead. This callback is set at initialization time.

Test: fast/text/install-font-style-recalc.html

• page/Page.cpp:

(WebCore::m_attachmentElementClient):

• platform/graphics/FontCache.cpp:

(WebCore::Function<void):
(WebCore::FontCache::registerFontCacheInvalidationCallback):
(WebCore::FontCache::invalidateAllFontCaches):

• platform/graphics/FontCache.h:

LayoutTests:

• fast/text/install-font-style-recalc-expected.txt: Added.
• fast/text/install-font-style-recalc.html: Added.

2:37 PM Changeset in webkit [292071] by Alan Coon

• 1 copy in tags/Safari-613.2.4.1.1

Tag Safari-613.2.4.1.1.

2:36 PM Changeset in webkit [292070] by Alan Coon

• 1 copy in tags/Safari-613.2.4.0.1

Tag Safari-613.2.4.0.1.

2:01 PM Changeset in webkit [292069] by commit-queue@webkit.org

• 14 edits in trunk/LayoutTests

[GLIB] Update test expectations and baselines. Unreviewed test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=238506

Patch by Arcady Goldmints-Orlov <Arcady Goldmints-Orlov> on 2022-03-29

• platform/glib/TestExpectations:
• platform/glib/css2.1/t0505-c16-descendant-01-e-expected.txt:
• platform/glib/fast/lists/002-expected.txt:
• platform/gtk/css1/box_properties/margin_right-expected.txt:
• platform/gtk/css1/box_properties/padding_right-expected.txt:
• platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
• platform/gtk/fast/inline/emptyInlinesWithinLists-expected.txt:
• platform/gtk/fast/lists/003-expected.txt:
• platform/wpe/css1/box_properties/margin_right-expected.txt:
• platform/wpe/css1/box_properties/padding_right-expected.txt:
• platform/wpe/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
• platform/wpe/fast/inline/emptyInlinesWithinLists-expected.txt:
• platform/wpe/fast/lists/003-expected.txt:

1:57 PM Changeset in webkit [292068] by achristensen@apple.com

• 19 edits in trunk

Don't create directories on iOS if we are only using ephemeral storages
​https://bugs.webkit.org/show_bug.cgi?id=238402
Source/WebKit:

<rdar://79639418>

Reviewed by Chris Dumez.

Since we have been giving access to those directories as long as WebKit2 has been on iOS,
this is a conservative change to only give access to the directories when using persistent storage.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::addWebsiteDataStore):

• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

• Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::encode const):
(WebKit::WebsiteDataStoreParameters::decode):

• Shared/WebsiteDataStoreParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::parameters):

Tools:

Reviewed by Chris Dumez.

• TestWebKitAPI/Tests/WebKitCocoa/NSAttributedStringWebKitAdditions.mm:

(TEST):

1:55 PM Changeset in webkit [292067] by achristensen@apple.com

• 4 edits in trunk/Source

Navigation Timing data is corrupt in WebView (UIWebView/WKWebView)
​https://bugs.webkit.org/show_bug.cgi?id=186919
<rdar://41393423>

Reviewed by Simon Fraser.

Source/WebCore:

Sometimes the observed requestStart time is after the observed responseStart time.
This may be due to the device's clock changing. It may be due to something else,
but currently CFNetwork does not use a monotonic timer to gather the data.
When this happens, use the later of the two times for responseStart.

• platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:53 PM Changeset in webkit [292066] by achristensen@apple.com

• 4 edits in branches/safari-613-branch/Source

Revert r292055

​​https://bugs.webkit.org/show_bug.cgi?id=186919

Source/WebCore:

I accidentally put it on a branch.

• platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

1:39 PM Changeset in webkit [292065] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit

Add Captive Portal alert to WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=238326

Patch by C Lopez <​clopez1@apple.com> on 2022-03-29
Reviewed by Geoffrey Garen and Brent Fulgham

When WkWebView on iOS is initialized, we call _presentCaptivePortalModeAlertIfNeeded which checks whether an alert needs to be presented or not.

• UIProcess/API/ios/WKWebViewIOS.h:
• UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _presentCaptivePortalModeAlertIfNeeded]):
(-[WKWebView didMoveToWindow]):

1:24 PM Changeset in webkit [292064] by don.olmstead@sony.com

• 6 edits in trunk

[LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
​https://bugs.webkit.org/show_bug.cgi?id=238510

Reviewed by Adrian Perez de Castro.

.:

Post v1.12.0 introduces the WPE_ENABLE_XKB definition to libwpe. For v1.12.0 and earlier
the define is added to the WPE::libwpe target's compile options. For later versions the
pkg-config for the library will determine the presence of this definition.

• Source/cmake/FindWPE.cmake:

Source/WebKit:

Guard libwpe xkb code with WPE_ENABLE_XKB.

• UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:

(WebKit::doKeyStrokeEvent):

Tools:

Guard libwpe xkb code with WPE_ENABLE_XKB.

• WebKitTestRunner/libwpe/EventSenderProxyLibWPE.cpp:

(WTR::EventSenderProxy::keyDown):

1:22 PM Changeset in webkit [292063] by Brandon

• 1 edit
  1 move in trunk/Source/bmalloc

Rename Libpas README to README.md
​https://bugs.webkit.org/show_bug.cgi?id=238517

Reviewed by Yusuke Suzuki.

Libpas README does not correctly display markdown output on github.com
without .md file extension.

• libpas/ReadMe.md: Renamed from Source/bmalloc/libpas/README.

1:18 PM Changeset in webkit [292062] by Russell Epstein

• 9 edits in branches/safari-614.1.7-branch/Source

Versioning.

WebKit-7614.1.7.4

1:15 PM Changeset in webkit [292061] by Matteo Flores

• 2 edits in trunk/LayoutTests

REGRESSION(r290898?): [ iOS ] animations/shadow-host-child-change.html is a flaky image failure
​https://bugs.webkit.org/show_bug.cgi?id=238519

Unreviewed test gardening.

• platform/ios/TestExpectations:

1:06 PM Changeset in webkit [292060] by Jonathan Bedard

• 5 edits in trunk/Tools

[Merge-Queue] Canonicalize commit
​https://bugs.webkit.org/show_bug.cgi?id=238453
<rdar://problem/90921217>

Reviewed by Dewei Zhu.

Before pushing to Subversion, we want to include the canonical
link in the commit message.

• Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add Canonicalize step.

• Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

• Tools/CISupport/ews-build/steps.py:

(Canonicalize):
(Canonicalize.init):
(Canonicalize.doStepIf): Only canonicalize pull requests.
(Canonicalize.hideStepIf): Hide step if we aren't doing it.
(Canonicalize.run): Update the base branch, rebase the source branch
then move the base branch to the tip of the source branch. Finally,
canonicalize the new commit.
(Canonicalize.getResultSummary):

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/248995@main

12:49 PM Changeset in webkit [292059] by Fujii Hironori

• 5 edits
  4 adds in trunk

drop-shadow filter doesn't work correctly in tiled backing layer
​https://bugs.webkit.org/show_bug.cgi?id=236800
<rdar://problem/89382612>

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/filter-effects/filters-drop-shadow-003-expected.html: Added.
• web-platform-tests/css/filter-effects/filters-drop-shadow-003.html: Added.

Source/WebCore:

If an element with drop-shadow filter wasn't placed in the
painting rect, the drop-shadow wasn't rendered correctly. This
issue tended to be observed in tiled backing layers becuase each
tile is painted separately. But, not necessary. If an element with
drop-shadow filter was placed in the outside of view, this issue
could arise.

Tests: css3/filters/drop-shadow-in-tiled-backing.html

imported/w3c/web-platform-tests/css/filter-effects/filters-drop-shadow-003.html

• rendering/RenderLayerFilters.cpp:

(WebCore::RenderLayerFilters::beginFilterEffect): If the
drop-shadow is cast to the right direction, dirtyRect needs to be
extended to left direction to calculate targetBoundingBox.

LayoutTests:

• css3/filters/drop-shadow-in-tiled-backing-expected.html: Added.
• css3/filters/drop-shadow-in-tiled-backing.html: Added.
• platform/ios-wk2/TestExpectations:

12:46 PM Changeset in webkit [292058] by Russell Epstein

• 5 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292042. rdar://problem/90999175

Unreviewed, fix UAF after r291980

Source/WebCore:

• page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
• page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:23 PM Changeset in webkit [292057] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Use "UTF-8"_s instead of PAL::UTF8Encoding().domName()
​https://bugs.webkit.org/show_bug.cgi?id=238508

Reviewed by Geoffrey Garen.

Use "UTF-8"_s instead of PAL::UTF8Encoding().domName() as it is equivalent and more efficient.

• dom/Document.cpp:

(WebCore::Document::characterSetWithUTF8Fallback const):
(WebCore::Document::defaultCharsetForLegacyBindings const):

12:17 PM Changeset in webkit [292056] by Jonathan Bedard

• 5 edits in trunk/Tools

[Merge-Queue] Add Reviewers to ChangeLog files
​https://bugs.webkit.org/show_bug.cgi?id=238396
<rdar://problem/90860335>

Reviewed by Dewei Zhu.

• Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add AddReviewerToChangeLog.

• Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

• Tools/CISupport/ews-build/steps.py:

(AddReviewerToChangeLog.init):
(AddReviewerToChangeLog._files): List files in the pull-request.
(AddReviewerToChangeLog.run): Replace "NOBODY" with reviewers.
(AddReviewerToChangeLog.getResultSummary):
(AddReviewerToChangeLog.doStepIf): Skip step if patch or if reviewers are undefined.
(AddReviewerToChangeLog.hideStepIf): Hide step if skipped.

• Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: ​https://commits.webkit.org/248992@main

12:15 PM Changeset in webkit [292055] by achristensen@apple.com

• 4 edits in branches/safari-613-branch/Source

Navigation Timing data is corrupt in WebView (UIWebView/WKWebView)
​https://bugs.webkit.org/show_bug.cgi?id=186919
<rdar://41393423>

Reviewed by Simon Fraser.

Source/WebCore:

Sometimes the observed requestStart time is after the observed responseStart time.
This may be due to the device's clock changing. It may be due to something else,
but currently CFNetwork does not use a monotonic timer to gather the data.
When this happens, use the later of the two times for responseStart.

• platform/network/cocoa/NetworkLoadMetrics.mm:

(WebCore::packageTimingData):

Source/WebKit:

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

12:10 PM Changeset in webkit [292054] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

WebCore::LegacyRootInlineBox::lineSnapAdjustment should bail out on grid line height < 1
​https://bugs.webkit.org/show_bug.cgi?id=238465
<rdar://80630664>

Reviewed by Antti Koivisto.

The !gridLineHeight check was added to avoid division by zero but the integral roundToInt() may also produce a 0 value for
gridLineHeight.

• rendering/LegacyRootInlineBox.cpp:

(WebCore::LegacyRootInlineBox::lineSnapAdjustment const):

12:08 PM Changeset in webkit [292053] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/ANGLE

Handle pkg_config and declare_args statements in gni-to-cmake.py
​https://bugs.webkit.org/show_bug.cgi?id=238490

Remove these statements, since they currently must be deleted from
the resulting CMake files by hand.

Regenerate the CMake files from current ANGLE sources, to minimize
changes during the next roll.

Patch by Kenneth Russell <​kbr@chromium.org> on 2022-03-29
Reviewed by Dean Jackson.

• GL.cmake:
• gni-to-cmake.py:

12:07 PM Changeset in webkit [292052] by Matteo Flores

• 3 edits in trunk/LayoutTests

[ iOS Mac ] imported/w3c/web-platform-tests/fetch/metadata/download.https.sub.html is a flaky text failure
​https://bugs.webkit.org/show_bug.cgi?id=238469

Unreviewed test gardening.

• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

11:33 AM Changeset in webkit [292051] by sihui_liu@apple.com

• 2 edits in trunk/Source/WebKit

Unreviewed test fix after r292024.
​https://bugs.webkit.org/show_bug.cgi?id=238082
<rdar://problem/90844775>

Correcting an if condition.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processDidResume):

11:31 AM Changeset in webkit [292050] by Jonathan Bedard

• 5 edits in trunk/Tools

[Merge-Queue] Add Reviewers to commit message
​https://bugs.webkit.org/show_bug.cgi?id=238354
<rdar://problem/90800671>

Reviewed by Dewei Zhu.

When a PR has been reviewed, Merge-Queue should insert those
reviewers into the commit message.

• Tools/CISupport/ews-build/factories.py:

(MergeQueueFactory.init): Add AddReviewerToCommitMessage and ValidateCommitMessage steps.

• Tools/CISupport/ews-build/factories_unittest.py:

(TestExpectedBuildSteps): Ditto.

• Tools/CISupport/ews-build/steps.py:

(AddReviewerMixin):
(AddReviewerMixin.environment): Set committer to action owner.
(AddReviewerMixin.reviewers): Return a combined string of all reviewers.
(AddReviewerToCommitMessage.init):
(AddReviewerToCommitMessage.start): Insert reviewer string into commit message.
(AddReviewerToCommitMessage.getResultSummary):
(AddReviewerToCommitMessage.doStepIf): Skip step if patch or if reviewers are undefined.
(AddReviewerToCommitMessage.hideStepIf): Hide step if skipped.
(ValidateCommitMessage.init):
(ValidateCommitMessage.start): List commit message for commit.
(ValidateCommitMessage.getResultSummary):
(ValidateCommitMessage.evaluateCommand):
(ValidateCommitMessage.doStepIf): Skip step if patch.
(ValidateCommitMessage.hideStepIf): Hide step if skipped.

• Tools/CISupport/ews-build/steps_unittest.py:

(mock_load_contributors): Share with multiple functions.

Canonical link: ​https://commits.webkit.org/248986@main

11:30 AM Changeset in webkit [292049] by eric.carlson@apple.com

• 11 edits
  2 adds in trunk

[macOS] Muted video is sometimes paused when entering fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=238462
rdar://89104216

Reviewed by Jer Noble.

Source/WebCore:

Test: media/fullscreen-when-muted.html

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::didMoveToNewDocument): Add logging.
(WebCore::HTMLMediaElement::elementIsHidden const): Consider both element fullscreen
and video fullscreen.
(WebCore::HTMLMediaElement::visibilityStateChanged): Use elementIsHidden.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction const): Add
logging for the one case that didn't have it.
(WebCore::HTMLMediaElement::updateMediaPlayer): New, wrap MediaPlayer functions
that are called frequently by RenderVideo so we can only call them when necessary.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::elementIsHidden const): Deleted.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::visibilityChanged): Just use elementIsHidden, it
already accounts for fullscreen.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setVisibleInViewport): Do nothing when visibility is not changing.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setPageIsVisible): Add logging.

• rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer): Call HTMLMediaElement::updateMediaPlayer instead
of calling MediaPlayer directly.

Source/WebKit:

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::setPageIsVisible): Track visibility and do
nothing when it doesn't change.
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio): Ditto for aspect
ratio.

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:

LayoutTests:

• media/fullscreen-when-muted-expected.txt: Added.
• media/fullscreen-when-muted.html: Added.

11:21 AM Changeset in webkit [292048] by Alan Coon

• 5 edits in branches/safari-613-branch/Source

Cherry-pick r292042. rdar://problem/89434696

Unreviewed, fix UAF after r291980

Source/WebCore:

• page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
• page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [292047] by Alan Coon

• 5 edits in branches/safari-613.2.4.0-branch/Source

Cherry-pick r292042. rdar://problem/89434696

Unreviewed, fix UAF after r291980

Source/WebCore:

• page/FrameView.h: (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.
• page/FrameView.cpp: (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits. (WebCore::FrameView::setSizeForCSSSmallViewportUnits): (WebCore::FrameView::overrideWidthForCSSSmallViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits. (WebCore::FrameView::setSizeForCSSLargeViewportUnits): (WebCore::FrameView::overrideWidthForCSSLargeViewportUnits): (WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits): (WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits. (WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted. Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Expose OverrideViewportSize so that we can copy those members specifically instead of having to keep alive the old FrameView when transitioning to a new page.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:21 AM Changeset in webkit [292046] by Alan Coon

• 20 edits in branches/safari-613-branch

Cherry-pick r291980. rdar://problem/89434696

[iOS] Add WKWebView API to control CSS "small viewport" sv* and "large viewport" lv* units
​https://bugs.webkit.org/show_bug.cgi?id=237979
<rdar://problem/89434696>

Reviewed by Tim Horton.

Source/WebCore:

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

• page/FrameView.h:
• page/FrameView.cpp: (WebCore::FrameView::performSizeToContentAutoSize): (WebCore::FrameView::enableAutoSizeMode): (WebCore::FrameView::clearSizeOverrideForCSSDefaultViewportUnits): Added. (WebCore::FrameView::setSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits): Added. (WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added. (WebCore::FrameView::sizeForCSSDefaultViewportUnits const): Renamed from sizeForCSSDefaultViewportUnits. (WebCore::FrameView::copyCSSViewportUnits const): Added. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units.

Source/WebKit:

Recently the W3C CSS working group added [some new unit types to CSS](​https://drafts.csswg.org/css-values-4/#viewport-variants)
with the goal of helping web developers better deal with browsers that have dynamic UI
elements that change apperance/size/etc. based on user actions (e.g. the URL bar
collapsing/"squishing" and expanding/"unsquishing" depending on whether the user has most
recently scrolled/swiped down the page).

These new units come in three categories:

• the "large viewport" units (lvw, lvh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their smallest state (e.g. when the URL bar is collapsed/"squished")
• the "small viewport" units (svw, svh, etc.) each represent 1% of one dimension of the size of the visual area of the page when all browser UI elements are in their largest state (e.g. when the URL bar is expanded/"unsquished")
• the "dynamic viewport" units (dvw, dvh, etc.) each represent 1% of one dimension of the size of the current visual area of the page, which depends on the current state of all browser UI elements

This way, developer could use 100svh to ensure that no matter what state the browser UI
elements are in the entire element will always be visible on the screen, or use 100dvh to
respond to browser UI element changes by automatically resizing various elements to always
fully take advantage of the available space.

Nothing needs to be added to support "dynamic viewport" dv* units as there already exists
other methods to adjust the visual area of the WKWebView without adjusting its frame
(e.g. -[WKWebView setBounds:], -[UIScrollView setContentInset:], etc.).

But for "small viewport" sv* units and "large viewport" lv* units, however, there is
unfortunately no way to tell a WKWebView anything like "this is the smallest/largest that
this WKWebView will ever be", so there's no way to know ahead of time what the size of the
visual area would be when all browser UI elements are in their smallest/largest state. As
such, this patch adds a new API to allow for WKWebView clients to tell WebKit this
information ahead of time.

Note that there already exists the concept of "default viewport" units (vw, vh, etc.)
that each represent 1% of one dimension of the size of the visual area of the page when all
browser UI elements are in their default state. The behavior of these units remain the same,
and the value can be changed via the existing -[WKWebView setFrame:].

Tests: CSSViewportUnits.NegativeMinimumViewportInset

CSSViewportUnits.NegativeMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset
CSSViewportUnits.MinimumViewportInsetLargerThanFrame
CSSViewportUnits.MaximumViewportInsetLargerThanFrame
CSSViewportUnits.MinimumViewportInset
CSSViewportUnits.MaximumViewportInset
CSSViewportUnits.MinimumViewportInsetWithZoom
CSSViewportUnits.MaximumViewportInsetWithZoom
CSSViewportUnits.MinimumViewportInsetWithWritingMode
CSSViewportUnits.MaximumViewportInsetWithWritingMode
CSSViewportUnits.MinimumViewportInsetWithFrame
CSSViewportUnits.MaximumViewportInsetWithFrame
CSSViewportUnits.MinimumViewportInsetWithBounds
CSSViewportUnits.MaximumViewportInsetWithBounds
CSSViewportUnits.MinimumViewportInsetWithContentInset
CSSViewportUnits.MaximumViewportInsetWithContentInset
CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets
CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets
CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI

• UIProcess/API/Cocoa/WKWebViewInternal.h:
• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _recalculateViewportSizesWithMinimumViewportInset:maximumViewportInset:throwOnInvalidInput:]): Added. (-[WKWebView setMinimumViewportInset:maximumViewportInset:]): Added.
• UIProcess/API/ios/WKWebViewIOS.mm: (-[WKWebView _processWillSwapOrDidExit]): (-[WKWebView _frameOrBoundsChanged]): (-[WKWebView _didCompleteAnimatedResize]): (-[WKWebView _setMinimumUnobscuredSizeOverride:]): (-[WKWebView _setMaximumUnobscuredSizeOverride:]): (-[WKWebView _beginAnimatedResizeWithUpdates:]): (-[WKWebView _dispatchSetMinimumUnobscuredSize:]): Deleted. (-[WKWebView _dispatchSetMaximumUnobscuredSize:]): Deleted. Recalculate the size for CSS "small viewport" sv* units whenever the frame changes. Also move the deduplication logic that prevents the same value from being sent to the WebProcess more than once to the setter methods on WebPageProxy so that it can be used by more than just iOS-only codepaths.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::setDefaultUnobscuredSize): Added. (WebKit::WebPageProxy::setMinimumUnobscuredSize): Added. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Added. (WebKit::WebPageProxy::creationParameters):
• UIProcess/ios/WebPageProxyIOS.mm: (WebKit::WebPageProxy::dynamicViewportSizeUpdate): (WebKit::WebPageProxy::setMinimumUnobscuredSize): Deleted. (WebKit::WebPageProxy::setMaximumUnobscuredSize): Deleted.
• Shared/WebPageCreationParameters.h:
• Shared/WebPageCreationParameters.cpp: (WebKit::WebPageCreationParameters::encode const): (WebKit::WebPageCreationParameters::decode):
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit::WebPage::setViewportSizeForCSSViewportUnits): (WebKit::WebPage::setDefaultUnobscuredSize): Added. (WebKit::WebPage::setMinimumUnobscuredSize): Added. (WebKit::WebPage::setMaximumUnobscuredSize): Added. (WebKit::WebPage::updateSizeForCSSDefaultViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSSmallViewportUnits): Added. (WebKit::WebPage::updateSizeForCSSLargeViewportUnits): Added.
• WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::viewportConfigurationChanged): (WebKit::WebPage::setMinimumUnobscuredSize): Deleted. (WebKit::WebPage::setMaximumUnobscuredSize): Deleted. (WebKit::WebPage::updateViewportSizeForCSSViewportUnits): Deleted. Add all the various methods for getting/setting/overriding/clearing an override value for CSS "default viewport" v* units. This allows for WKWebView clients to preserve existing behavior (where CSS "default viewport" v* units match the size of the WKWebView) while adding supporting CSS "small viewport" sv* units and CSS "large viewport" lv* units. Move iOS-only code to be for all platforms.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Propagate all viewport size overrides when a new FrameView is created.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/CSSViewportUnits.mm: (TEST.CSSViewportUnits.NegativeMinimumViewportInset): Added. (TEST.CSSViewportUnits.NegativeMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanMaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetLargerThanFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInset): Added. (TEST.CSSViewportUnits.MaximumViewportInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithZoom): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithWritingMode): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithFrame): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithBounds): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithContentInset): Added. (TEST.CSSViewportUnits.MinimumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.MaximumViewportInsetWithSafeAreaInsets): Added. (TEST.CSSViewportUnits.UnobscuredSizeOverridesIgnoreMaximumViewportInsetAPI): Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@291980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:19 AM Changeset in webkit [292045] by Antti Koivisto

• 16 edits
  4 adds in trunk

[CSS Container Queries] Support CSSOM
​https://bugs.webkit.org/show_bug.cgi?id=238500

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-contain/container-queries/at-container-serialization-expected.txt:
• web-platform-tests/css/css-contain/container-queries/idlharness-expected.txt:

Source/WebCore:

Add CSSContainerRule interface.

​https://drafts.csswg.org/css-contain-3/#the-csscontainerrule-interface

• DerivedSources-input.xcfilelist:
• DerivedSources-output.xcfilelist:
• DerivedSources.make:
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJSNewlyCreated):

• css/CSSContainerRule.cpp: Added.

(WebCore::CSSContainerRule::CSSContainerRule):
(WebCore::CSSContainerRule::create):
(WebCore::CSSContainerRule::styleRuleContainer const):
(WebCore::CSSContainerRule::cssText const):
(WebCore::CSSContainerRule::conditionText const):

Implementation, the only real functionality is serialization.

• css/CSSContainerRule.h: Added.
• css/CSSContainerRule.idl: Added.

Interface.

• css/ContainerQuery.cpp:

(WebCore::CQ::serialize):
(WebCore::serialize):

Query syntax serialization support.

• css/ContainerQuery.h:
• css/ContainerQueryParser.cpp:

(WebCore::ContainerQueryParser::consumeContainerQuery):

Remember the text of unknown queries.

• css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper const):

LayoutTests:

• TestExpectations:

11:15 AM Changeset in webkit [292044] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebKit

Don't send sync RemoteMediaPlayerProxy messages that we know will fail
​https://bugs.webkit.org/show_bug.cgi?id=238467
rdar://86662565

Reviewed by Jer Noble.

• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::videoFrameForCurrentTime): Return early if
readyState is less than HaveCurrentData, or if the first frame is not available.

• WebProcess/GPU/media/cocoa/MediaPlayerPrivateRemoteCocoa.mm:

(WebKit::MediaPlayerPrivateRemote::nativeImageForCurrentTime): Ditto.
(WebKit::MediaPlayerPrivateRemote::colorSpace): Ditto.

10:55 AM Changeset in webkit [292043] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

RenderText::width should call FontCascade directly on single space characters
​https://bugs.webkit.org/show_bug.cgi?id=238484

Reviewed by Antti Koivisto.

Some "text and inline box" heavy pages (e.g. wikipedia) have the pattern of leaving one space
gap between adjacent inline boxes (<span>some content</span> <span>and some more</span>).
This patch ensures that we don't construct redundant TextRun objects (and measure their widths)
for such simple cases when applicable.

• rendering/RenderText.cpp:

(WebCore::RenderText::width const):

10:37 AM Changeset in webkit [292042] by Devin Rousso

• 5 edits in trunk/Source

Unreviewed, fix UAF after r291980

Source/WebCore:

• page/FrameView.h:

(WebCore::FrameView::overrideSizeForCSSDefaultViewportUnits): Added.
(WebCore::FrameView::overrideSizeForCSSSmallViewportUnits): Added.
(WebCore::FrameView::overrideSizeForCSSLargeViewportUnits): Added.

• page/FrameView.cpp:

(WebCore::FrameView::setSizeForCSSDefaultViewportUnits):
(WebCore::FrameView::overrideWidthForCSSDefaultViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSDefaultViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSDefaultViewportUnits): Renamed from overrideSizeForCSSDefaultViewportUnits.
(WebCore::FrameView::setSizeForCSSSmallViewportUnits):
(WebCore::FrameView::overrideWidthForCSSSmallViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSSmallViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSSmallViewportUnits): Renamed from overrideSizeForCSSSmallViewportUnits.
(WebCore::FrameView::setSizeForCSSLargeViewportUnits):
(WebCore::FrameView::overrideWidthForCSSLargeViewportUnits):
(WebCore::FrameView::resetOverriddenWidthForCSSLargeViewportUnits):
(WebCore::FrameView::setOverrideSizeForCSSLargeViewportUnits): Renamed from overrideSizeForCSSLargeViewportUnits.
(WebCore::FrameView::copyCSSViewportSizeOverrides): Deleted.
Expose OverrideViewportSize so that we can copy those members specifically instead of
having to keep alive the old FrameView when transitioning to a new page.

Source/WebKit:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Expose OverrideViewportSize so that we can copy those members specifically instead of
having to keep alive the old FrameView when transitioning to a new page.

10:30 AM Changeset in webkit [292041] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

[Playstation] Fix build break after r291979 if ENABLE_SERVICE_WORKER is off
​https://bugs.webkit.org/show_bug.cgi?id=238471

Patch by Jigen Zhou <​jigen.zhou@sony.com> on 2022-03-29
Reviewed by Don Olmstead.

Build fix for playstation platform after r291979 to support ServiceWorkerClients.openWindow.
This patch resolves compiling errors occurs in WebPageProxy::callLoadCompletionHandlersIfNecessary
if ENABLE_SERVICE_WORKER is off.

• UIProcess/WebPageProxy.cpp:

10:29 AM Changeset in webkit [292040] by Russell Epstein

• 7 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292035. rdar://problem/88717577

[iOS GPUProcess] Image decoding should not trigger IOSurface usage in the web process
​https://bugs.webkit.org/show_bug.cgi?id=238489
<rdar://88717577>

Reviewed by Per Arne Vollan.

Source/WebCore:

When hardwareAcceleratedDecodingDisabled() has been called, turn off hardware acceleration
for image decoding.

• platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::createImageSourceOptions): (WebCore::ImageDecoderCG::disableHardwareAcceleratedDecoding): (WebCore::ImageDecoderCG::hardwareAcceleratedDecodingDisabled):
• platform/graphics/cg/ImageDecoderCG.h:

Source/WebCore/PAL:

Expose kCGImageSourceUseHardwareAcceleration.

• pal/spi/cg/ImageIOSPI.h:

Source/WebKit:

When useGPUProcessForDOMRendering is true, disable hardware image decoding since
we need to avoid IOSurface access in the web process.

• WebProcess/WebProcess.cpp: (WebKit::WebProcess::setUseGPUProcessForDOMRendering):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 AM Changeset in webkit [292039] by Russell Epstein

• 4 edits in branches/safari-614.1.8-branch/Source/WebCore

Cherry-pick r292026. rdar://problem/90941790

REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color
​https://bugs.webkit.org/show_bug.cgi?id=238466
rdar://90941790

Reviewed by Simon Fraser.

r291771 uncovers this bug: TextBoxPainter::paintForeground() records the
glyphs to a DisplayList before settings the destination GraphicsContext.

The fix is to apply all the changes to the GraphicsContext before calling
TextPainter::setGlyphDisplayListIfNeeded().

Delete TextPainter::paint() because it is not used.

Initialize TextPainter with a reference to FontCascade.

• rendering/TextBoxPainter.cpp: (WebCore::TextBoxPainter::paintForeground):
• rendering/TextPainter.cpp: (WebCore::TextPainter::TextPainter): (WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded): (WebCore::TextPainter::paintRange): (WebCore::TextPainter::paint): Deleted.
• rendering/TextPainter.h: (WebCore::TextPainter::setShadowColorFilter): (WebCore::TextPainter::setGlyphDisplayListIfNeeded): (WebCore::TextPainter::setFont): Deleted.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:29 AM Changeset in webkit [292038] by Russell Epstein

• 8 edits in branches/safari-614.1.8-branch/Source

Cherry-pick r292010. rdar://problem/89559929

Disable custom storage paths for IndexedDB and LocalStorage by default
​https://bugs.webkit.org/show_bug.cgi?id=236977
<rdar://problem/89559929>

Reviewed by Geoffrey Garen.

Source/WebKit:

Developers can enable them by disabling "general directory for storage" via internal debug feature or system
feature flag.

• FeatureFlags/WebKit-appletvos.plist:
• FeatureFlags/WebKit-ios.plist:
• FeatureFlags/WebKit-macos.plist:
• FeatureFlags/WebKit-watchos.plist:
• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: (WebKit::internalFeatureEnabled): (WebKit::WebsiteDataStore::defaultShouldUseCustomStoragePaths):

Source/WTF:

Add an internal debug feature for using genreal directory for storage.

• Scripts/Preferences/WebPreferencesInternal.yaml:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@292010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:26 AM Changeset in webkit [292037] by Patrick Angle

• 16 edits in trunk/Source

Web Inspector: [Cocoa] Indicate a request was sent through proxy/private relay in Network tab
​https://bugs.webkit.org/show_bug.cgi?id=233202

Reviewed by Devin Rousso.

Source/JavaScriptCore:

Add new isProxyConnection property to network metrics protocol object.

• inspector/protocol/Network.json:

Source/WebCore:

Add plumbing for the new isProxyConnection network metric.

• inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForMetrics):

• platform/network/NetworkLoadMetrics.cpp:

(WebCore::AdditionalNetworkLoadMetricsForWebInspector::isolatedCopy):

• platform/network/NetworkLoadMetrics.h:

(WebCore::AdditionalNetworkLoadMetricsForWebInspector::encode const):
(WebCore::AdditionalNetworkLoadMetricsForWebInspector::decode):

Source/WebInspectorUI:

For resources that are sent through a proxy or relay (like iCloud Private Relay), the remoteAddress will be that
of the proxy or relay server, not the server that provided the page to the proxy or relay. To indicate this, we
now append (Proxy) to these remote IP addresses in Web Inspector so that it is clearer what server the remote
address actually represents in these cases.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Models/LocalResource.js:
• UserInterface/Models/Resource.js:

(WI.Resource.prototype.get displayRemoteAddress):

• Similar to displayName and displayURL which provide user-facing strings, add a displayRemoteAddress that

will denote the address is a proxy if applicable.

(WI.Resource.prototype.updateWithMetrics):

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._entryForResource):

• UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WI.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):

• UserInterface/Views/ResourceHeadersContentView.js:

(WI.ResourceHeadersContentView.prototype._refreshSummarySection):

• UserInterface/Views/ResourceTimelineDataGridNode.js:

(WI.ResourceTimelineDataGridNode.prototype.get data):

Source/WebKit:

Add plumbing for the new isProxyConnection network metric.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):

10:21 AM Changeset in webkit [292036] by Brandon

• 3 edits in trunk/Source/WebCore

Need to add ISO annotations to GPUUncapturedErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=238512

Reviewed by Yusuke Suzuki.

ISO annotations are required in GPUUncapturedErrorEvent for proper initialization.

• Modules/WebGPU/GPUUncapturedErrorEvent.cpp:
• Modules/WebGPU/GPUUncapturedErrorEvent.h:

(WebCore::GPUUncapturedErrorEvent::create): Deleted.
(WebCore::GPUUncapturedErrorEvent::backing): Deleted.
(WebCore::GPUUncapturedErrorEvent::backing const): Deleted.
(WebCore::GPUUncapturedErrorEvent::GPUUncapturedErrorEvent): Deleted.

10:05 AM Changeset in webkit [292035] by Simon Fraser

• 7 edits in trunk/Source

[iOS GPUProcess] Image decoding should not trigger IOSurface usage in the web process
​https://bugs.webkit.org/show_bug.cgi?id=238489
<rdar://88717577>

Reviewed by Per Arne Vollan.

Source/WebCore:

When hardwareAcceleratedDecodingDisabled() has been called, turn off hardware acceleration
for image decoding.

• platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::createImageSourceOptions):
(WebCore::ImageDecoderCG::disableHardwareAcceleratedDecoding):
(WebCore::ImageDecoderCG::hardwareAcceleratedDecodingDisabled):

• platform/graphics/cg/ImageDecoderCG.h:

Source/WebCore/PAL:

Expose kCGImageSourceUseHardwareAcceleration.

• pal/spi/cg/ImageIOSPI.h:

Source/WebKit:

When useGPUProcessForDOMRendering is true, disable hardware image decoding since
we need to avoid IOSurface access in the web process.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::setUseGPUProcessForDOMRendering):

8:54 AM Changeset in webkit [292034] by Brandon

• 2 edits in trunk/Source/WebCore

Check page exists before trying to access authenticatorCoordinator
​https://bugs.webkit.org/show_bug.cgi?id=238507

Reviewed by Brent Fulgham.

Check we have a valid page before trying to access the authenticatorCoordinator.

• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::isUserVerifyingPlatformAuthenticatorAvailable):

8:54 AM Changeset in webkit [292033] by Sam Sneddon

• 6 edits
  116 copies
  131 adds
  1 delete in trunk/LayoutTests

Re-import web-platform-tests/css/css-conditional
​https://bugs.webkit.org/show_bug.cgi?id=237896

Reviewed by Tim Nguyen.

This used to be web-platform-tests/css/conditional, so this also
combines the rename, but is ultimately this is just an update.

LayoutTests/imported/w3c:

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/css/conditional/LICENSE: Removed.
• web-platform-tests/css/conditional/at-supports-001-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-002-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-003-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-004-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-005-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-006-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-007-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-008-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-009-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-010-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-011-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-012-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-013-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-014-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-015-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-016-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-017-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-018-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-019-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-020-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-021-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-022-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-023-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-024-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-025-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-026-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-027-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-028-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-029-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-030-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-031-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-032-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-033-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-034-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-035-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-036-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-037-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-038-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-039-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-040-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-041-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-042-expected.html: Removed.
• web-platform-tests/css/conditional/at-supports-043-expected.html: Removed.
• web-platform-tests/css/conditional/reference/background-lime.html: Removed.
• web-platform-tests/css/conditional/test_group_insertRule-expected.txt: Removed.
• web-platform-tests/css/conditional/test_group_insertRule.html: Removed.
• web-platform-tests/css/css-conditional/META.yml: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/META.yml.
• web-platform-tests/css/css-conditional/at-media-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-001.html: Added.
• web-platform-tests/css/css-conditional/at-media-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-002.html: Added.
• web-platform-tests/css/css-conditional/at-media-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-003.html: Added.
• web-platform-tests/css/css-conditional/at-media-content-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-content-001.html: Added.
• web-platform-tests/css/css-conditional/at-media-content-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-content-002.html: Added.
• web-platform-tests/css/css-conditional/at-media-content-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-content-003.html: Added.
• web-platform-tests/css/css-conditional/at-media-content-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-content-004.html: Added.
• web-platform-tests/css/css-conditional/at-media-dynamic-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-media-dynamic-001.html: Added.
• web-platform-tests/css/css-conditional/at-media-whitespace-optional-001-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-001-expected.html.
• web-platform-tests/css/css-conditional/at-media-whitespace-optional-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-001.html.
• web-platform-tests/css/css-conditional/at-media-whitespace-optional-002-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-002-expected.html.
• web-platform-tests/css/css-conditional/at-media-whitespace-optional-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-media-whitespace-optional-002.html.
• web-platform-tests/css/css-conditional/at-supports-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-001-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-001.html.
• web-platform-tests/css/css-conditional/at-supports-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-006.html.
• web-platform-tests/css/css-conditional/at-supports-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-002.html.
• web-platform-tests/css/css-conditional/at-supports-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-003.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-004.html.
• web-platform-tests/css/css-conditional/at-supports-005-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-005.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-005.html.
• web-platform-tests/css/css-conditional/at-supports-006-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-006.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-006.html.
• web-platform-tests/css/css-conditional/at-supports-007-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-007.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-007.html.
• web-platform-tests/css/css-conditional/at-supports-008-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-008.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-008.html.
• web-platform-tests/css/css-conditional/at-supports-009-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-009.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-009.html.
• web-platform-tests/css/css-conditional/at-supports-010-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-010.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-010.html.
• web-platform-tests/css/css-conditional/at-supports-011-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-011.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-011.html.
• web-platform-tests/css/css-conditional/at-supports-012-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-012.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-012.html.
• web-platform-tests/css/css-conditional/at-supports-013-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-013.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-013.html.
• web-platform-tests/css/css-conditional/at-supports-014-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-014.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-014.html.
• web-platform-tests/css/css-conditional/at-supports-015-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-015.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-015.html.
• web-platform-tests/css/css-conditional/at-supports-016-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-016.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-016.html.
• web-platform-tests/css/css-conditional/at-supports-017-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-017.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-017.html.
• web-platform-tests/css/css-conditional/at-supports-018-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-018.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-018.html.
• web-platform-tests/css/css-conditional/at-supports-019-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-019.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-019.html.
• web-platform-tests/css/css-conditional/at-supports-020-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-020.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-020.html.
• web-platform-tests/css/css-conditional/at-supports-021-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-021.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-021.html.
• web-platform-tests/css/css-conditional/at-supports-022-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-022.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-022.html.
• web-platform-tests/css/css-conditional/at-supports-023-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-023.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-023.html.
• web-platform-tests/css/css-conditional/at-supports-024-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-024.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-024.html.
• web-platform-tests/css/css-conditional/at-supports-025-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-025.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-025.html.
• web-platform-tests/css/css-conditional/at-supports-026-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-026.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-026.html.
• web-platform-tests/css/css-conditional/at-supports-027-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
• web-platform-tests/css/css-conditional/at-supports-027-ref.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
• web-platform-tests/css/css-conditional/at-supports-027.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
• web-platform-tests/css/css-conditional/at-supports-028-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-028.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-028.html.
• web-platform-tests/css/css-conditional/at-supports-029-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-027.html.
• web-platform-tests/css/css-conditional/at-supports-029.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-029.html.
• web-platform-tests/css/css-conditional/at-supports-030-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-030.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-030.html.
• web-platform-tests/css/css-conditional/at-supports-031-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-031.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-031.html.
• web-platform-tests/css/css-conditional/at-supports-032-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-032.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-032.html.
• web-platform-tests/css/css-conditional/at-supports-033-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-033.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-033.html.
• web-platform-tests/css/css-conditional/at-supports-034-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-034.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-034.html.
• web-platform-tests/css/css-conditional/at-supports-035-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-035.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-035.html.
• web-platform-tests/css/css-conditional/at-supports-036-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-036.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-036.html.
• web-platform-tests/css/css-conditional/at-supports-037-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-037.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-037.html.
• web-platform-tests/css/css-conditional/at-supports-038-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-038.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-038.html.
• web-platform-tests/css/css-conditional/at-supports-039-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-039.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-039.html.
• web-platform-tests/css/css-conditional/at-supports-043-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-043.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-043.html.
• web-platform-tests/css/css-conditional/at-supports-044-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-044.html: Added.
• web-platform-tests/css/css-conditional/at-supports-045-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-045.html: Added.
• web-platform-tests/css/css-conditional/at-supports-046-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-046.html: Added.
• web-platform-tests/css/css-conditional/at-supports-content-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-content-001.html: Added.
• web-platform-tests/css/css-conditional/at-supports-content-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-content-002.html: Added.
• web-platform-tests/css/css-conditional/at-supports-content-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-content-003.html: Added.
• web-platform-tests/css/css-conditional/at-supports-content-004-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-content-004.html: Added.
• web-platform-tests/css/css-conditional/at-supports-namespace-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-namespace-001.html: Added.
• web-platform-tests/css/css-conditional/at-supports-namespace-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-namespace-002.html: Added.
• web-platform-tests/css/css-conditional/at-supports-selector-001-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-selector-001.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-040.html.
• web-platform-tests/css/css-conditional/at-supports-selector-002-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-selector-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-040.html.
• web-platform-tests/css/css-conditional/at-supports-selector-003-expected.html: Copied from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-selector-003.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-041.html.
• web-platform-tests/css/css-conditional/at-supports-selector-004-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-003.html.
• web-platform-tests/css/css-conditional/at-supports-selector-004.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/at-supports-042.html.
• web-platform-tests/css/css-conditional/css-supports-001-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-001.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-002-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-002.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-003-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-003.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-004-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-004.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-005-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-005.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-006-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-006.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-007-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-007.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-008-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-008.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-009-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-009.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-010-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-010.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-011-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-011.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-012-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-012.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-013-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-013.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-014-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-014.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-015-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-015.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-016-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-016.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-017-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-017.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-018-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-018.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-019-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-019.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-020-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-020.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-021-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-021.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-022-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-022.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-023-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-023.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-024-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-024.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-025-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-025.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-026-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-026.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-029-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-029.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-030-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-030.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-031-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-031.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-032-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-032.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-033-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-033.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-034-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-034.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-035-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-035.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-036-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-036.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-037-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-037.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-038-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-038.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-039-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-039.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-040-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-040.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-041-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-041.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-042-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-042.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-043-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-043.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-044-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-044.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-045-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-045.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-046-expected.xht: Added.
• web-platform-tests/css/css-conditional/css-supports-046.xht: Added.
• web-platform-tests/css/css-conditional/idlharness-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/idlharness-expected.txt.
• web-platform-tests/css/css-conditional/idlharness.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/idlharness.html.
• web-platform-tests/css/css-conditional/js/001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/js/001-expected.txt.
• web-platform-tests/css/css-conditional/js/001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/css/conditional/js/001.html.
• web-platform-tests/css/css-conditional/js/CSS-supports-CSSStyleDeclaration-expected.txt: Added.
• web-platform-tests/css/css-conditional/js/CSS-supports-CSSStyleDeclaration.html: Added.
• web-platform-tests/css/css-conditional/js/CSS-supports-L3-expected.txt: Added.
• web-platform-tests/css/css-conditional/js/CSS-supports-L3.html: Added.
• web-platform-tests/css/css-conditional/js/CSS-supports-L4-expected.txt: Added.
• web-platform-tests/css/css-conditional/js/CSS-supports-L4.html: Added.
• web-platform-tests/css/css-conditional/js/conditional-CSSGroupingRule-expected.txt: Added.
• web-platform-tests/css/css-conditional/js/conditional-CSSGroupingRule.html: Added.
• web-platform-tests/css/css-conditional/js/w3c-import.log: Added.
• web-platform-tests/css/css-conditional/support/at-media-dynamic-001-inner.html: Added.
• web-platform-tests/css/css-conditional/support/fail.css: Added.

(*):

• web-platform-tests/css/css-conditional/support/pass.xht: Added.
• web-platform-tests/css/css-conditional/support/w3c-import.log: Added.
• web-platform-tests/css/css-conditional/w3c-import.log: Added.

LayoutTests:

• TestExpectations:

8:48 AM Changeset in webkit [292032] by Wenson Hsieh

• 8 edits in trunk

HTMLAttachmentElement.getAttachmentIdentifier() should propagate attachment data to the client
​https://bugs.webkit.org/show_bug.cgi?id=238473
rdar://90938796

Reviewed by Devin Rousso.

Source/WebCore:

In the case where a WebKit client that has enabled the attachment element uses
HTMLAttachmentElement.getAttachmentIdentifier on an image element to create a new attachment-backed image, we
currently propagate an empty _WKAttachment to the UI delegate in the UI process, even in the case where the
image element has a visible image that has been loaded.

To support plain-text editing mode, Mail needs to be able to call getAttachmentIdentifier to create attachment
elements for images that already contain images with blob sources, but are inserted into the document via
JavaScript (as opposed to native editing code).

To make this work, we plumb the image element itself through the registerAttachmentIdentifier method that
currently only takes a single attachment identifier, and use it to send the image data, image name, and MIME
type to the attachment client if the image has a loaded image; otherwise, we fall back to creating and surfacing
an empty _WKAttachment to the client.

Test: WKAttachmentTests.CreateAttachmentsFromExistingImage

• dom/Document.cpp:

(WebCore::Document::registerAttachmentIdentifier):

• dom/Document.h:
• editing/Editor.cpp:

(WebCore::Editor::registerAttachmentIdentifier):

• editing/Editor.h:
• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::getAttachmentIdentifier):

Tools:

Add a new API test to exercise the fix.

• TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

8:17 AM WebKitGTK/2.36.x edited by magomez@igalia.com

(diff)

7:31 AM Changeset in webkit [292031] by don.olmstead@sony.com

• 3 edits
  1 copy
  1 add
  1 delete in trunk/Source/WebKit

Share WebAutomationSession among USE(LIBWPE) ports
​https://bugs.webkit.org/show_bug.cgi?id=238470

Reviewed by Adrian Perez de Castro.

Rename WebAutomationSessionWPE.cpp to WebAutomationSessionLibWPE since its just using the
libWPE API. Remove glib specific code in WebAutomationSession::platformSimulateKeySequence
to use a StringView::codePoints. The same code was in GTK so replace that as well.

• SourcesWPE.txt:
• UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeySequence):

• UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp: Renamed from Source/WebKit/UIProcess/Automation/wpe/WebAutomationSessionWPE.cpp.

(WebKit::WebAutomationSession::platformSimulateKeySequence):

7:23 AM Changeset in webkit [292030] by Alan Bujtas

• 3 edits in trunk/LayoutTests

Make fast/repaint/list-item-equal-style-change-no-repaint.html less prone to flakiness
​https://bugs.webkit.org/show_bug.cgi?id=238480

Reviewed by Simon Fraser.

Use Internals::layoutCount to check whether animation triggers layout.

• fast/repaint/list-item-equal-style-change-no-repaint-expected.txt:
• fast/repaint/list-item-equal-style-change-no-repaint.html:

5:24 AM Changeset in webkit [292029] by ntim@apple.com

• 4 edits in trunk

Use Canvas/CanvasText system colors for <dialog> default styling
​https://bugs.webkit.org/show_bug.cgi?id=238425

Reviewed by Antti Koivisto.

Per HTML spec change: ​https://github.com/whatwg/html/commit/22154a4c1d426dddf187fb12c05fbcb8816c94a5
Main change is that the colors now adapt to dark mode by default.

LayoutTests/imported/w3c:

Updated test result to pass.

• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt:

Source/WebCore:

Test: LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html

• css/dialog.css:

(dialog):

5:21 AM Changeset in webkit [292028] by ntim@apple.com

• 4 edits
  40 moves
  4 adds in trunk/LayoutTests

Re-import inert and <dialog> WPT
​https://bugs.webkit.org/show_bug.cgi?id=238502

Reviewed by Antti Koivisto.

Upstream commit: ​https://github.com/web-platform-tests/wpt/commit/46e50fc357127c76c898675cd30ae34090a2268d

Main changes:

• Removes .tentative.html suffix from inert tests
• Adds default-color.html test for <dialog>

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color-expected.txt: Added.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/default-color.html: Added.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.tentative-expected.txt.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-inert.tentative.html.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection-expected.txt: Added.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/modal-dialog-selection.html: Added.
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
• web-platform-tests/inert/dynamic-inert-on-focused-element-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/dynamic-inert-on-focused-element.tentative-expected.txt.
• web-platform-tests/inert/dynamic-inert-on-focused-element.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/dynamic-inert-on-focused-element.tentative.html.
• web-platform-tests/inert/inert-and-contenteditable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative-expected.txt.
• web-platform-tests/inert/inert-and-contenteditable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-and-contenteditable.tentative.html.
• web-platform-tests/inert/inert-canvas-fallback-content-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-canvas-fallback-content.tentative-expected.txt.
• web-platform-tests/inert/inert-canvas-fallback-content.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-canvas-fallback-content.tentative.html.
• web-platform-tests/inert/inert-does-not-match-disabled-selector-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative-expected.txt.
• web-platform-tests/inert/inert-does-not-match-disabled-selector.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-does-not-match-disabled-selector.tentative.html.
• web-platform-tests/inert/inert-iframe-hittest-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt.
• web-platform-tests/inert/inert-iframe-hittest.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative.html.
• web-platform-tests/inert/inert-iframe-tabbing-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt.
• web-platform-tests/inert/inert-iframe-tabbing.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative.html.
• web-platform-tests/inert/inert-in-shadow-dom-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-in-shadow-dom.tentative-expected.txt.
• web-platform-tests/inert/inert-in-shadow-dom.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-in-shadow-dom.tentative.html.
• web-platform-tests/inert/inert-inlines-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines.tentative-expected.txt.
• web-platform-tests/inert/inert-inlines.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-inlines.tentative.html.
• web-platform-tests/inert/inert-label-focus-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-label-focus.tentative-expected.txt.
• web-platform-tests/inert/inert-label-focus.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-label-focus.tentative.html.
• web-platform-tests/inert/inert-node-is-uneditable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt.
• web-platform-tests/inert/inert-node-is-uneditable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative.html.
• web-platform-tests/inert/inert-node-is-unfocusable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.tentative-expected.txt.
• web-platform-tests/inert/inert-node-is-unfocusable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unfocusable.tentative.html.
• web-platform-tests/inert/inert-node-is-unselectable-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unselectable.tentative-expected.txt.
• web-platform-tests/inert/inert-node-is-unselectable.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-node-is-unselectable.tentative.html.
• web-platform-tests/inert/inert-on-non-html-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html.tentative-expected.txt.
• web-platform-tests/inert/inert-on-non-html.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-non-html.tentative.html.
• web-platform-tests/inert/inert-on-slots-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-slots.tentative-expected.txt.
• web-platform-tests/inert/inert-on-slots.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-on-slots.tentative.html.
• web-platform-tests/inert/inert-svg-hittest-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt.
• web-platform-tests/inert/inert-svg-hittest.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative.html.
• web-platform-tests/inert/inert-with-modal-dialog-001-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-001.tentative-expected.txt.
• web-platform-tests/inert/inert-with-modal-dialog-001.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-001.tentative.html.
• web-platform-tests/inert/inert-with-modal-dialog-002-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-002.tentative-expected.txt.
• web-platform-tests/inert/inert-with-modal-dialog-002.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/inert/inert-with-modal-dialog-002.tentative.html.
• web-platform-tests/inert/w3c-import.log:

LayoutTests:

• platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-hittest.tentative-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-iframe-tabbing.tentative-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-node-is-uneditable.tentative-expected.txt.
• platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest-expected.txt: Renamed from LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/inert/inert-svg-hittest.tentative-expected.txt.

4:40 AM Changeset in webkit [292027] by youenn@apple.com

• 23 edits in trunk/Source

RealtimeMediaSource::Type::Video is misleading as it is actually referring to camera sources
​https://bugs.webkit.org/show_bug.cgi?id=238449

Reviewed by Eric Carlson.

Source/WebCore:

Make RealtimeMediaSource::Type a boolean (audio or video) and use deviceType wherever more fine grained information is needed.
No change of behavior.

• Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::getAudioTracks const):
(WebCore::MediaStream::getVideoTracks const):

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::~MediaStreamTrack):
(WebCore::MediaStreamTrack::kind const):
(WebCore::MediaStreamTrack::setContentHint):
(WebCore::updateVideoCaptureAccordingMicrophoneInterruption):
(WebCore::trackTypeForMediaProducerCaptureKind):
(WebCore::MediaStreamTrack::endCapture):
(WebCore::MediaStreamTrack::trackEnded):
(WebCore::MediaStreamTrack::isCapturingAudio const):

• Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::isVideo const):
(WebCore::MediaStreamTrack::isAudio const):
(WebCore::MediaStreamTrack::hasVideo const): Deleted.
(WebCore::MediaStreamTrack::hasAudio const): Deleted.

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::mediaStreamDidFail): Deleted.

• Modules/mediastream/UserMediaRequest.h:
• Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addTrack):
(WebCore::LibWebRTCMediaEndpoint::createSourceAndRTCTrack):

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::updateTracksOfKind):

• platform/mediarecorder/MediaRecorderPrivate.cpp:

(WebCore::MediaRecorderPrivate::selectTracks):

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::hasVideo const):
(WebCore::MediaStreamPrivate::hasAudio const):
(WebCore::MediaStreamPrivate::updateActiveVideoTrack):
(WebCore::MediaStreamPrivate::monitorOrientation):

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::type const): Deleted.

• platform/mediastream/MediaStreamTrackPrivate.h:
• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::convertEnumerationToString):

• platform/mediastream/RealtimeMediaSource.h:
• platform/mediastream/cocoa/DisplayCaptureSourceCocoa.cpp:

(WebCore::DisplayCaptureSourceCocoa::DisplayCaptureSourceCocoa):
(WebCore::sourceTypeForDevice): Deleted.

• platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:
• testing/Internals.cpp:

(WebCore::Internals::stopObservingRealtimeMediaSource):
(WebCore::Internals::observeMediaStreamTrack):

Source/WebKit:

• Shared/WebCoreArgumentCoders.h:
• UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:

(WebKit::UserMediaCaptureManagerProxy::SourceProxy::SourceProxy):
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::~SourceProxy):

• WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:

(WebKit::toSourceType):

2:43 AM Changeset in webkit [292026] by Said Abou-Hallawa

• 4 edits in trunk/Source/WebCore

REGRESSION(r291771): [ iOS ] Text sometimes draw with incorrect color
​https://bugs.webkit.org/show_bug.cgi?id=238466
rdar://90941790

Reviewed by Simon Fraser.

r291771 uncovers this bug: TextBoxPainter::paintForeground() records the
glyphs to a DisplayList before settings the destination GraphicsContext.

The fix is to apply all the changes to the GraphicsContext before calling
TextPainter::setGlyphDisplayListIfNeeded().

Delete TextPainter::paint() because it is not used.

Initialize TextPainter with a reference to FontCascade.

• rendering/TextBoxPainter.cpp:

(WebCore::TextBoxPainter::paintForeground):

• rendering/TextPainter.cpp:

(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintRange):
(WebCore::TextPainter::paint): Deleted.

• rendering/TextPainter.h:

(WebCore::TextPainter::setShadowColorFilter):
(WebCore::TextPainter::setGlyphDisplayListIfNeeded):
(WebCore::TextPainter::setFont): Deleted.

12:59 AM Changeset in webkit [292025] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[GTK][WPE] Use GBMBufferSwapchain in GraphicsContextGLTextureMapperANGLE
​https://bugs.webkit.org/show_bug.cgi?id=237883

Patch by Zan Dobersek <​zdobersek@igalia.com> on 2022-03-29
Reviewed by Alejandro G. Castro.

Use the generic GBMBufferSwapchain for managing dmabuf-based buffer
objects in GraphicsContextGLTextureMapperANGLE. This usage is guarded
behind the USE(TEXTURE_MAPPER_DMABUF) build guards.

When that build guard is enabled, we can avoid using additional textures
but instead have to manage a GBMBufferSwapchain instance from which we
can retrieve buffers that should be acting as backing for the different
draw operations.

This buffer setup is handled in the
GraphicsContextGLTextureMapperANGLE::makeContextCurrent() method. Once
called, if there's a swapchain available (after initial or each
subsequent backing reshaping) a buffer will be retrieved from that
swapchain, a corresponding EGLImage created and associated to the GL
texture that acts as the color attachment for the default buffer. All
subsequent drawing will be done onto this buffer object, all the way
to the prepareForDisplay() method where that buffer is moved into the
display-buffer position, waiting for the display to occur.

The display of this buffer is still handled in Nicosia::GCGLANGLELayer.
In the swapBuffersIfNeeded() method, if the pending buffer is detected,
the dmabuf information is pushed into the
TextureMapperPlatformLayerProxyDMABuf instance and prepared for
presentation.

No new tests -- covered by existing tests, where the ANGLE-backed
GraphicsContextGL continues to improve the overall state of WebGL tests.
Only problem is the software-backed rasterization in the WPE/GTK testing
tooling which disables a few features and to a degree breaks WebGL
content display, but this specific issue will be resolved later.

• platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:

(Nicosia::GCGLANGLELayer::swapBuffersIfNeeded):
(Nicosia::GCGLANGLELayer::GCGLANGLELayer):

• platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h:
• platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::makeContextCurrent):
(WebCore::GraphicsContextGLTextureMapperANGLE::~GraphicsContextGLTextureMapperANGLE):
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitializeContext):
(WebCore::GraphicsContextGLTextureMapperANGLE::platformInitialize):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareTexture):
(WebCore::GraphicsContextGLTextureMapperANGLE::reshapeDisplayBufferBacking):
(WebCore::GraphicsContextGLTextureMapperANGLE::prepareForDisplay):
(WebCore::GraphicsContextGLTextureMapperANGLE::Swapchain::Swapchain):
(WebCore::GraphicsContextGLTextureMapperANGLE::Swapchain::~Swapchain):
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::EGLImageBacking): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::~EGLImageBacking): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::format const): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::stride const): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::releaseResources): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::isReleased): Deleted.
(WebCore::GraphicsContextGLTextureMapperANGLE::EGLImageBacking::reset): Deleted.

• platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.h: