Context Navigation

← Previous Period
Next Period →

Timeline

Apr 1, 2013:

11:49 PM Changeset in webkit [147395] by esprehn@chromium.org

5 edits in trunk/Source/WebCore

RenderObject::offsetParent should return Element*
https://bugs.webkit.org/show_bug.cgi?id=113739

Reviewed by Abhishek Arya.

The offsetParent of a node should always be an Element, ensure this
by fixing RenderObject::offsetParent to return an Element* and clean up
the method to match the algorithm in the spec which lets us remove the
comments that were trying to explain what was going on.

This also hardens against badness where RenderObject::offsetParent
could have returned a renderer with a non-Element node which would result
in a bad cast in Element::offsetParent. We fixed all cases of this, but
this patch makes sure such things never happen again.

No new tests, no change in behavior.

dom/Element.cpp:

(WebCore::Element::offsetParent):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):

rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent): Now returns Element*.

rendering/RenderObject.h:

(RenderObject):

11:34 PM Changeset in webkit [147394] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Removing duplicated expectations to get rid of linting errors.

11:29 PM Changeset in webkit [147393] by zandobersek@gmail.com

4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectation for the svg/repaint/buffered-rendering-static-image.html

layout test added in r147348, most likely due to disabled subpixel layout on the GTK port.

platform/gtk/fast/table/overflowHidden-expected.png: Updating after r147245.
platform/gtk/fast/table/overflowHidden-expected.txt: Ditto.

11:28 PM Changeset in webkit [147392] by hclam@chromium.org

4 edits in trunk/Source/WebCore

Simply GIFImageReader error handling
https://bugs.webkit.org/show_bug.cgi?id=113718

Reviewed by Adam Barth.

When GIFImageReader encounters a parsing error it should just return
without doing any more work. Current code saves a boolean before return,
this is not necessary.

Tested with existing unit tests.
Tested locally with ASAN build with 60k GIF images.

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::repetitionCount):

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

platform/image-decoders/gif/GIFImageReader.h:

(GIFImageReader::GIFImageReader):
(GIFImageReader):

11:23 PM Changeset in webkit [147391] by esprehn@chromium.org

15 edits in trunk/Source/WebCore

Make all v8 weak callbacks type safe
https://bugs.webkit.org/show_bug.cgi?id=111802

Reviewed by Adam Barth.

Make all v8 handle weak callbacks typesafe by adding a new class WeakHandleListner
that uses templates to generate the callback proxies that have the correct type
arguments. Now getting the arguments wrong will fail compilation.

No new tests, no change in behavior.

bindings/v8/DOMDataStore.h:

(WebCore::::callback):

bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::reportMemoryUsage):
(DOMWrapperMap):

bindings/v8/DOMWrapperWorld.cpp:

(WebCore::::callback):
(WebCore::DOMWrapperWorld::makeContextWeak):

bindings/v8/ScriptState.cpp:

(WebCore::::callback):
(WebCore::ScriptState::ScriptState):

bindings/v8/ScriptState.h:

(ScriptState):

bindings/v8/ScriptWrappable.h:

(ScriptWrappable):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::::callback):

bindings/v8/V8AbstractEventListener.cpp:

(WebCore::::callback):
(WebCore::V8AbstractEventListener::setListenerObject):

bindings/v8/V8AbstractEventListener.h:

(V8AbstractEventListener):

bindings/v8/V8MutationCallback.cpp:

(WebCore::::callback):
(WebCore::V8MutationCallback::V8MutationCallback):

bindings/v8/V8MutationCallback.h:

(V8MutationCallback):

bindings/v8/V8NPObject.cpp:

(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::set):
(WebCore::::callback):
(WebCore::staticNPObjectMap):

bindings/v8/V8Utilities.h:

(WeakHandleListener):
(WebCore::WeakHandleListener::makeWeak):
(WebCore::WeakHandleListener::WeakHandleListener):
(WebCore::WeakHandleListener::invokeWeakCallback):

bindings/v8/V8ValueCache.cpp:

(WebCore::::callback):
(WebCore::StringCache::v8ExternalStringSlow):

bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::::callback):
(WebCore::createInjectedScriptHostV8Wrapper):

11:16 PM Changeset in webkit [147390] by shinyak@chromium.org

2 edits in trunk/Source/WebKit/chromium

2013-04-01 <webkit.review.bot@gmail.com>

[chromium] Roll chromium deps to 191760.
https://bugs.webkit.org/show_bug.cgi?id=113745

Unreviewed, rolling deps.

DEPS:

11:16 PM Changeset in webkit [147389] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Hide non-coordinated scrollbars for Android M26
https://bugs.webkit.org/show_bug.cgi?id=113738

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-04-01
Reviewed by Simon Fraser.

This patch will hide any non-coordinated scrollbars on Android.
Coordinated scrollbars won't be affected.

Currently all scrollbars are coordinated on Android. The sole purpose
of this patch is to be cherry-picked to the M26 branch.

No new tests. Please revert immediately after landed.

platform/ScrollView.cpp:

(WebCore::positionScrollbarLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

11:15 PM Changeset in webkit [147388] by cevans@google.com

7 edits
2 adds in trunk

Crash in Node::enclosingBlockFlowElement()
https://bugs.webkit.org/show_bug.cgi?id=113712

Reviewed by Abhishek Arya.

Source/WebCore:

Fix a bad Node assumption if we walk up to the document root.

Test: editing/execCommand/format-block-at-root.html

dom/Node.cpp:

(WebCore::Node::isBlockFlowElement): Check we found an Element Node and rename from isBlockFlow().
(WebCore::Node::enclosingBlockFlowElement): Use the new toElement().

editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::formatRange): Check for NULL.

editing/InsertListCommand.cpp:

(WebCore::InsertListCommand::doApplyForSingleParagraph):

editing/ReplaceSelectionCommand.cpp:

(WebCore::enclosingInline): Impact from method rename.

LayoutTests:

editing/execCommand/format-block-at-root-expected.txt: Added.
editing/execCommand/format-block-at-root.html: Added.

10:51 PM Changeset in webkit [147387] by simonjam@chromium.org

7 edits
2 adds in trunk

[Resource Timing] Expose timing information for iframes
https://bugs.webkit.org/show_bug.cgi?id=103927

Reviewed by Nate Chapin.

Source/WebCore:

The only catch with main documents is that we only want to record the load that was initiated by
adding the <iframe> to a document. We don't want any subsequent navigations within the iframe to
be reported.

Test: http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::loadDone): Make sure iframes are reported in the parent.

LayoutTests:

http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Fix timeout.
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation-expected.txt: Added.
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html: Added.
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Remove bad line.
platform/chromium/TestExpectations: Unskip tests that relied on iframes.

10:48 PM Changeset in webkit [147386] by commit-queue@webkit.org

4 edits in trunk/Source

[BlackBerry] Move Path into it's own header
https://bugs.webkit.org/show_bug.cgi?id=113724

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.

Source/WebCore:

No behavioural change.

platform/graphics/blackberry/PathBlackBerry.cpp:

Source/WebKit/blackberry:

WebKitSupport/DefaultTapHighlight.cpp:

10:43 PM Changeset in webkit [147385] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] canvas is not rendering correctly for www.html5-benchmark.com
https://bugs.webkit.org/show_bug.cgi?id=113716

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-01
Reviewed by Rob Buis.

PR 317205
Internally reivewed by: Mike Lattanzio, Jacky Jiang

This is a site issue where they detect physical pixels by multiplying
availWidth * devicePixelRatio. This gives us an invalid result since
we don't round the CSS pixels that are reported to availWidth and availHeight.

platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::toUserSpace):

10:39 PM Changeset in webkit [147384] by hmuller@adobe.com

12 edits
2 adds in trunk

[CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent
https://bugs.webkit.org/show_bug.cgi?id=113600

Reviewed by Dirk Schulze.

Source/WebCore:

ExclusionShapeInsideInfo classes need to depend on the ExclusionShape's padded boundary and
ExclusionShapeOutsideInfo classes should depend on the ExclusionShape's margin boundary. Added
a virtual method to the ExclusionShapeInfo that returns the ExclusionShape's logical bounding box -
computedShapeLogicalBoundingBox() - and overrode that method in the subclasses to return the
value of the appropriate ExclusionShape method. Added shapeMarginLogicalBoundingBox() and
shapePaddingLogicalBoundingBox() methods to ExclusionShape and removed the shapeLogicalBoundingBox()
method, which did not take shape-margin or shape-padding into account.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html

rendering/ExclusionPolygon.h: Defined the padding and margin bounding box virtual methods.
rendering/ExclusionRectangle.h: Defined the padding and margin bounding box virtual methods.
rendering/ExclusionShape.h: Added the padding and margin bounding box virtual abstract methods. Removed shapeLogicalBoundingBox().

(ExclusionShape):

rendering/ExclusionShapeInfo.h:

(WebCore::ExclusionShapeInfo::shapeLogicalTop): Now calls computedShapeLogicalBoundingBox().
(WebCore::ExclusionShapeInfo::shapeLogicalBottom): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalLeft): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalRight): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalWidth): Ditto.
(WebCore::ExclusionShapeInfo::shapeLogicalHeight): Ditto.
(ExclusionShapeInfo): Added computedShapeLogicalBoundingBox().

rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::computedShapeLogicalBoundingBox): Gets the padded shape's bounding box.

rendering/ExclusionShapeOutsideInfo.h:

(ExclusionShapeOutsideInfo):
(WebCore::ExclusionShapeOutsideInfo::computedShapeLogicalBoundingBox): Gets the margin shape's bounding box.

LayoutTests:

Corrected the expected values in the ellipse-margin-left and ellipse-margin-right tests because the
shape-outside float layout code now (correctly) takes into account the shape's margin boundary.

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom-expected.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-bottom.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt:
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt:
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:

10:34 PM Changeset in webkit [147383] by abarth@webkit.org

6 edits in trunk

Assertion failure !m_lastChunkBeforeScript in HTMLDocumentParser during inspector/debugger/pause-in-inline-script.html
https://bugs.webkit.org/show_bug.cgi?id=112369

Reviewed by Eric Seidel.

Source/WebCore:

The threaded HTML parser wasn't correctly handling the nested event
loops that can arise from the JavaScript debugger and from
showModalDialog. When the parser received a chunk from the background
parser, it was always processing it immediately, which lead to
re-entrancy. Now, we'll queue the chunk in the speculation buffer and
process it once the stack unwinds.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::~HTMLDocumentParser):
(WebCore::HTMLDocumentParser::didReceiveParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::insert):

html/parser/HTMLParserScheduler.cpp:

(WebCore::PumpSession::PumpSession):

html/parser/HTMLParserScheduler.h:

LayoutTests:

Unskip test that is now passing.

platform/chromium/TestExpectations:

10:31 PM Changeset in webkit [147382] by commit-queue@webkit.org

4 edits in trunk

[JSC] IndexedDB: Exceptions not thrown for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113689

Patch by Michael Pruett <michael@68k.org> on 2013-04-01
Reviewed by Kentaro Hara.

Source/WebCore:

ScriptValue::serialize() should not clear exceptions thrown during
serialization. This change is needed to match behavior in V8.

Tests: storage/indexeddb/clone-exception.html

storage/indexeddb/exceptions.html
storage/indexeddb/structured-clone.html

bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):

LayoutTests:

platform/gtk/TestExpectations:

10:29 PM Changeset in webkit [147381] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] IndexedDB: Turn "should only be true in unit tests" comments into ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=113597

Reviewed by Adam Barth.

In the vein of wkbug.com/111233 and wkbug.com/110820 don't just comment that
some condition is true only in unit tests - ASSERT that Chromium's unitTestSupport()
is non-null to catch errors during development.

Exercised by Chromium's webkit_unit_tests.

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):

10:06 PM Changeset in webkit [147380] by shinyak@chromium.org

198 edits
5 adds
3 deletes in trunk/LayoutTests

Unreviewed, rolling out r147347.
http://trac.webkit.org/changeset/147347

broke Chromium Linux test
The same reason as the previous rollout.

platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-win/fast/borders/border-image-scaled-expected.png:
platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-win/fast/borders/scaled-border-image-expected.png:
platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium/TestExpectations:

9:54 PM Changeset in webkit [147379] by fpizlo@apple.com

5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support some more integer arithmetic ops (negate, xor, urshift)
https://bugs.webkit.org/show_bug.cgi?id=113740

Reviewed by Geoffrey Garen.

ftl/FTLAbbreviations.h:

(JSC::FTL::buildNeg):
(JSC::FTL::buildLShr):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileBitXor):
(JSC::FTL::LowerDFGToLLVM::compileBitURShift):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):

ftl/FTLOutput.h:

(JSC::FTL::Output::neg):
(JSC::FTL::Output::lShr):

9:46 PM Changeset in webkit [147378] by shinyak@chromium.org

381 edits in trunk/LayoutTests

Unreviewed, rolling out r147351.
http://trac.webkit.org/changeset/147351

broke Chromium Linux test
The same reason as the previous rollout.

platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

9:28 PM Changeset in webkit [147377] by shinyak@chromium.org

9 edits
1 move
1 delete in trunk/LayoutTests

Unreviewed, rolling out r147358.
http://trac.webkit.org/changeset/147358

broke Chromium Linux test
In the flakiness dashboard, this rebaseline looks good, however actually it broke Chromium Linux Test bots.
Maybe something bad is happening, but let me revert them again.

platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.

8:02 PM Changeset in webkit [147376] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

7:22 PM Changeset in webkit [147375] by roger_fong@apple.com

3 edits
1 add in trunk

VS2010 WebCoreGenerated build scripts should use new feature-defines script.
Update FEATURE_DEFINES string generation for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=113737.

Reviewed by Timothy Horton.

WebCore.vcxproj/build-generated-files.sh:
win/tools/scripts/feature-defines2010.sh: Added.

6:23 PM Changeset in webkit [147374] by ojan@chromium.org

7 edits
1 copy
1 move
1 add
1 delete in trunk/LayoutTests

Test rebaselines after r147245.

fast/table/overflowHidden-expected.txt:
platform/chromium-mac/fast/table/overflowHidden-expected.txt: Removed.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/fast/table/overflowHidden-expected.txt: Copied from LayoutTests/fast/table/overflowHidden-expected.txt.
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win-7sp0/fast/table/overflowHidden-expected.txt: Renamed from LayoutTests/platform/win/fast/table/overflowHidden-expected.txt.

5:26 PM Changeset in webkit [147373] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770

Reviewed by David Levin.

Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.

Also, unconditionally start laying out from the minimum height, so that the
documentRect can shrink below its previous height if needed.

No new tests; autosizing is not currently exposed in a testable way on Mac.

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

5:10 PM Changeset in webkit [147372] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Bot greening failed test from http://trac.webkit.org/changeset/147317.
The test should use testRunner, not layoutTestController.

Unreviewed.

fast/text/emphasis-height-crash.html:

5:03 PM Changeset in webkit [147371] by hayato@chromium.org

15 edits in trunk

[Shadow DOM] Change the order of event dispatching at AT_TARGET phase.
https://bugs.webkit.org/show_bug.cgi?id=113676

Reviewed by Dimitri Glazkov.

Source/WebCore:

Change the order of event dispatching at AT_TARGET phase so that it mimics bubbling events.

The spec side bug is:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21404

Example:

Given the event path, from Node A (top-most) to Node G (target,
inner-most), where C and D are shadow hosts and G is the target,
the event dispatching order in the current WebKit implementation is:
(T: AT_TARGET, C: CAPTURING, B: BUBBLING)

For bubbling events:

A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 3 (T)
D 4 (C) 9 (B)
E (SH) 5 (T)
F 6 (C) 8 (B)
G (Target) 7 (T)

For non-bubbling events:

A 1 (C)
B 2 (C)
C (SH) 3 (T)
D 4 (C)
E (SH) 5 (T)
F 6 (C)
G (Target) 7 (T)

This patch has changed the order of event dispatching as follows:

For bubbling events:

A 1 (C) 11 (B)
B 2 (C) 10 (B)
C (SH) 9 (T)
D 3 (C) 8 (B)
E (SH) 7 (T)
F 4 (C) 6 (B)
G (Target) 5 (T)

For non-bubbling events:

A 1 (C)
B 2 (C)
C (SH) 7 (T)
D 3 (C)
E (SH) 6 (T)
F 4 (C)
G (Target) 5 (T)

No new tests, updating existing layouts.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

dom/EventDispatcher.h:

(EventDispatcher):

LayoutTests:

fast/dom/shadow/cppevent-in-shadow-expected.txt:
fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
fast/dom/shadow/gesture-tap-expected.txt:
fast/dom/shadow/shadow-boundary-events-expected.txt:
fast/dom/shadow/shadow-boundary-events.html:
fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:
fast/dom/shadow/shadow-root-blur-expected.txt:

5:00 PM Changeset in webkit [147370] by Nate Chapin

2 edits in trunk/Source/WebCore

Crash in WebCore::HTMLMediaElement::~HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=113531

Reviewed by Adam Barth.

No new tests, though this is intermittently reproducible with
http/tests/misc/delete-frame-during-readystatechange.html under ASAN.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Clear the media player manually

before the destructor exits. Clearing the media player may cancel a resource load,
which can trigger a readystatechange event. It's possible for the HTMLMediaElement
to attempt to fire an abort event within the readystatechange event, even though it is
now in an inconsistent state. Clearling the media player before finishing the destructor
ensures that the HTMLMediaElement will at least still be alive if this case is triggered.
Set m_completelyLoaded to true to ensure that if userCancelledLoad() is called, it doesn't
attempt to fire events while destructing.

4:35 PM Changeset in webkit [147369] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r146373.
http://trac.webkit.org/changeset/146373
https://bugs.webkit.org/show_bug.cgi?id=113731

broke autosizing shrinking past previous size (Requested by
thorton on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

4:19 PM Changeset in webkit [147368] by fpizlo@apple.com

6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support GetGlobalVar/PutGlobalVar
https://bugs.webkit.org/show_bug.cgi?id=113728

Reviewed by Gavin Barraclough.

Removed the macro magic for the globals absolute abstract heap, since for anything
with absolute addresses we can just share a common absolute abstract heap. It
would only be a problem if we for example were emitting an access to a global but
not using an absolute address, and then wanted to say that this access was
constrained to global variables. I don't believe we do that, and I don't believe we
ever will.

Then added Output::absolute(), a convenient way of building a typed pointer for an
absolute address.

Then added GetGlobalVar/PutGlobalVar.

ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

ftl/FTLAbstractHeapRepository.h:

(FTL):
(AbstractHeapRepository):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetGlobalVar):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compilePutGlobalVar):

ftl/FTLOutput.h:

(JSC::FTL::Output::absolute):
(Output):

3:41 PM Changeset in webkit [147367] by Nate Chapin

2 edits in trunk/LayoutTests

Unreviewed, chromium expectations update after r147357.

platform/chromium/TestExpectations:

3:02 PM Changeset in webkit [147366] by aelias@chromium.org

2 edits in branches/chromium/1453/Source/WebKit/chromium

Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."

[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190018

2:46 PM Changeset in webkit [147365] by roger_fong@apple.com

2 edits
2 adds in trunk/LayoutTests

Unreviewed. AppleWin port gardening.

platform/win/TestExpectations:
platform/win/fast/table: Added.
platform/win/fast/table/overflowHidden-expected.txt: Added.

2:36 PM Changeset in webkit [147364] by jchaffraix@webkit.org

1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderTableCell.cpp

Merge 145822 "REGRESSION(r145305) Performance: 1.3% mac-release-..."

REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
https://bugs.webkit.org/show_bug.cgi?id=112125

Reviewed by Julien Chaffraix.

When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.

rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout):

TBR=jchaffraix@webkit.org
Review URL: https://codereview.chromium.org/13393017

2:33 PM Changeset in webkit [147363] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

WebCache should do the normal initialization dance
https://bugs.webkit.org/show_bug.cgi?id=113722
<rdar://problem/13424530>

Reviewed by Anders Carlsson.

In case a WebKit1 client uses WebCache before creating a WebView (or any of the other
initialization-ready classes), we should do the initialization work in WebCache as well.

Misc/WebCache.mm:

(+[WebCache initialize]):

2:32 PM Changeset in webkit [147362] by timothy@apple.com

5 edits in trunk/Source

Allow changing Web Inspector dock sides without undocking first.

https://webkit.org/b/113661
rdar://problem/13543127

Reviewed by Joseph Pecoraro.

Source/WebCore:

inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal): Initialize m_dockSide.

(WebCore::InspectorFrontendClientLocal::canAttachWindow): If we are already attached, allow
attaching again to allow switching sides.

(WebCore::InspectorFrontendClientLocal::setAttachedWindow): Set m_dockSide.

inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal): Added m_dockSide.

Source/WebKit2:

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::createInspectorPage): Send AttachedBottom and
AttachedRight messages so InspectorFrontendClientLocal knows which side we
are attached.

(WebKit::WebInspectorProxy::canAttach): If we are already attached, allow
attaching again to allow switching sides.

2:27 PM Changeset in webkit [147361] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Nor this! (Who reviewed this anyway!)

WebProcess/Storage/StorageNamespaceProxy.cpp:

(WebKit::StorageNamespaceProxy::storageArea):

2:19 PM Changeset in webkit [147360] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Didn't mean to commit this!

WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

2:12 PM Changeset in webkit [147359] by ap@apple.com

5 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=113721
<rdar://problem/13549181> REGRESSION (r146929): HTTP auth credentials not reused during session

Reviewed by Brady Eidson.

NetworkProcess/NetworkResourceLoader.h:
NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Added an override that we still need. It's not great, but causes no trouble for NetworkProcess. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Implement in terms of sync version to avoid duplicating logic.

1:56 PM Changeset in webkit [147358] by Nate Chapin

9 edits
2 adds
1 delete in trunk/LayoutTests

Unreviewed, chromium gardening.

platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Added.
platform/chromium/css3/images/cross-fade-background-size-expected.png: Removed.

1:48 PM Changeset in webkit [147357] by aelias@chromium.org

17 edits in trunk

[chromium] Delete code behind if (!applyXYZScaleInCompositor)
https://bugs.webkit.org/show_bug.cgi?id=111809

Reviewed by James Robinson.

Chromium is setting the flags applyPageScaleFactorInCompositor and
applyDeviceScaleFactorInCompositor permanently to true, so any code
in platform/chromium with the false setting is dead. Delete all of
it.

I also switched FrameTestHelpers and DumpRenderTree to always turn the
setting to true so that they test the code we're actually running.
This exposed a number of failing tests which I added in the
expectations file.

Note also that I made calls to setPageScaleFactor turn on
force-compositing-mode to make the layout tests work, as
pageScaleFactor is now ignored in non-composited mode.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):

src/PageWidgetDelegate.cpp:

(WebKit::PageWidgetDelegate::paint):

src/PageWidgetDelegate.h:
src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectRange):
(WebKit::WebFrameImpl::moveCaretSelectionTowardsWindowPoint):

src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
(WebKit::WebViewImpl::scaledSize):
(WebKit::WebViewImpl::resize):
(WebKit::WebViewImpl::paint):
(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):
(WebKit::WebViewImpl::clampOffsetAtScale):
(WebKit::WebViewImpl::setPageScaleFactorPreservingScrollOffset):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::contentsSize):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:
tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebView):

tests/WebFrameTest.cpp:
tests/WebInputEventConversionTest.cpp:

(WebCore::TEST):

1:33 PM Changeset in webkit [147356] by timothy@apple.com

4 edits in trunk

Make 'this' evaluate to the correct object when paused in the Debugger.

https://webkit.org/b/113607
rdar://problem/13538351

Reviewed by Joseph Pecoraro.

Source/WebCore:

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Bind 'this' to the expression function.

LayoutTests:

platform/mac/http/tests/inspector/console-resource-errors-expected.txt:

1:10 PM Changeset in webkit [147355] by vcarbune@chromium.org

6 edits
2 adds in trunk

TextTrackCue Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109821

Reviewed by Eric Carlson.

Source/WebCore:

The TextTrackCue gets a new attribute and setting, regionId, which specifies
to which region the cue belongs to. The attribute is guarded by WEBVTT_REGIONS
and is by default disabled in ports.

Test: media/track/regions-webvtt/text-track-cue-region-attribute.html

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::TextTrackCue): Added member variable for the regionId attribute.
(WebCore):
(WebCore::TextTrackCue::setRegionId): Setter for the regionId attribute.
(WebCore::TextTrackCue::settingName): Added RegionId setting name.
(WebCore::TextTrackCue::setCueSettings): Parsed the "region:" cue setting.

html/track/TextTrackCue.h:

(TextTrackCue):
(WebCore::TextTrackCue::regionId): Getter for the regionId attribute.

html/track/TextTrackCue.idl: Updated to match the WebVTT Regions Extension.

LayoutTests:

media/track/captions-webvtt/header-regions.vtt: Updated to include cues with

settings for which the "region:" setting should be ignored (for backwards compatibility
regarding WebVTT rendering rules).

media/track/regions-webvtt/text-track-cue-region-attribute-expected.txt: Added.
media/track/regions-webvtt/text-track-cue-region-attribute.html: Added.

1:05 PM Changeset in webkit [147354] by andersca@apple.com

10 edits in trunk/Source

Apply changes from storage events locally
https://bugs.webkit.org/show_bug.cgi?id=111502

Reviewed by Sam Weinig.

Source/WebCore:

Add and export a helper function for setting an item without taking
into account the quota for the map. Also, reindent StorageMap.h

WebCore.exp.in:
storage/StorageMap.cpp:

(WebCore::StorageMap::setItemIgnoringQuota):
(WebCore):

storage/StorageMap.h:

(StorageMap):
(WebCore::StorageMap::quota):

Source/WebKit2:

WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::StorageAreaProxy):
Store the security origin as a member variable.

(WebKit::StorageAreaProxy::dispatchStorageEvent):
Set the item and call the appropriate event dispatch function.

(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):
Add stubs.

WebProcess/Storage/StorageAreaProxy.h:

1:01 PM Changeset in webkit [147353] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Remove a couple of malloc from ExceptionBase construction
https://bugs.webkit.org/show_bug.cgi?id=113681

Reviewed by Darin Adler.

dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):
When the condition is true, we were creating a new String for
description.name. The constructor had already allocated a string for
that: m_name. Use that string instead of creating a new one.

When the condition is false, we were creating a String for typeName
just to use the string operators. This is a waste of time, we can use
makeString() to invoke the string concatenation functions directly.

12:59 PM Changeset in webkit [147352] by Lucas Forschler

2 edits in tags/Safari-537.35.5/Source/WebCore

Merged r147287. <rdar://problem/13541868>

12:52 PM Changeset in webkit [147351] by Nate Chapin

381 edits
2 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

platform/chromium-linux-x86/svg/dynamic-updates: Removed.
platform/chromium-linux-x86/tables/mozilla/marvin: Removed.
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

12:49 PM Changeset in webkit [147350] by eae@chromium.org

4 edits in trunk/Source/WebCore

Move remaining marquee applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=113298

Reviewed by Allan Sandfeld Jensen.

Move applying logic for CSSPropertyWebkitMarqueeIncrement,
CSSPropertyWebkitMarqueeRepetition and CSSPropertyWebkitMarqueeSpeed
from StyleResolver::applyProperty.

No new tests, no change in functionality.

css/StyleBuilder.cpp:

(ApplyPropertyMarqueeIncrement):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::createHandler):
(WebCore):
(ApplyPropertyMarqueeRepetition):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::createHandler):
(ApplyPropertyMarqueeSpeed):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Move marquee applying logic from StyleResolver to StyleBuilder.

rendering/style/RenderStyle.h:

Change setMarqueeIncrement to pass Length by value instead of const
reference. This is consistent with other length setters and works with
the ApplyPropertyLength template.

12:39 PM Changeset in webkit [147349] by benjamin@webkit.org

5 edits in trunk/Source/JavaScriptCore

Use Vector::reserveInitialCapacity and Vector::uncheckedAppend for JSC's APIs
https://bugs.webkit.org/show_bug.cgi?id=113651

Reviewed by Andreas Kling.

This removes a bunch of branches on initialization and when
filling the vector.

API/JSCallbackConstructor.cpp:

(JSC::constructJSCallback):

API/JSCallbackFunction.cpp:

(JSC::JSCallbackFunction::call):

API/JSCallbackObjectFunctions.h:

(JSC::::construct):
(JSC::::call):

API/JSObjectRef.cpp:

(JSObjectCopyPropertyNames):

11:55 AM Changeset in webkit [147348] by pdr@google.com

19 edits
6 adds in trunk

[SVG2] Add support for the buffered-rendering hint
https://bugs.webkit.org/show_bug.cgi?id=104207

Reviewed by Stephen Chenney.

Source/WebCore:

This patch adds the SVG2 buffered-rendering property and implements it for the image
element. For reference, the spec can be found at:

https://svgwg.org/svg2-draft/single-page.html#painting-BufferedRendering

The buffered-rendering hint causes our implementation to create a temporary image buffer
for caching an element's foreground rendering. This behavior has been designed to support
other graphical and container elements in followup patches (such as the use and g elements).
This patch should not affect rendering, and a test has been added showing the image
results are unchanged.

The performance aspects of this patch can be tested using the following test:

http://philbit.com/bouncingTigers.html

Without the patch, rendering is below 1fps. With the patch, rendering is fluid.

Tests: svg/css/buffered-rendering.html

svg/repaint/buffered-rendering-dynamic-image.html
svg/repaint/buffered-rendering-static-image.html

Other than the changes to RenderSVGImage and SVGRenderingContext, the changes below are to
support the new buffered-rendering property:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore):
(WebCore::CSSPrimitiveValue::operator EBufferedRendering):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):

css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

css/SVGCSSPropertyNames.in:
css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

css/SVGCSSValueKeywords.in:
rendering/style/SVGRenderStyle.cpp:

(WebCore::SVGRenderStyle::diff):

rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialBufferedRendering):
(WebCore::SVGRenderStyle::setBufferedRendering):
(WebCore::SVGRenderStyle::bufferedRendering):
(WebCore::SVGRenderStyle::setBitDefaults):

rendering/style/SVGRenderStyleDefs.h:
rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

The foreground painting has been extracted out into a separate function. This has also
been changed so that if the buffered-rendering hint is present, bufferForeground
is used.

(WebCore::RenderSVGImage::paintForeground):
(WebCore):
(WebCore::RenderSVGImage::invalidateBufferedForeground):

This function could be replaced with "m_bufferedForeground.clear()" but other renderers
(such as container elements) will require more complex invalidation logic. To
maintain consistency with this future code, invalidateBufferedForeground has been used.

(WebCore::RenderSVGImage::imageChanged):

rendering/svg/RenderSVGImage.h:

(RenderSVGImage):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::bufferForeground):
(WebCore):

rendering/svg/SVGRenderingContext.h:

(SVGRenderingContext):

svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):
(WebCore::cssPropertyToTypeMap):

svg/svgattrs.in:

LayoutTests:

svg/css/buffered-rendering-expected.txt: Added.
svg/css/buffered-rendering.html: Added.
svg/repaint/buffered-rendering-dynamic-image-expected.html: Added.
svg/repaint/buffered-rendering-dynamic-image.html: Added.
svg/repaint/buffered-rendering-static-image-expected.html: Added.
svg/repaint/buffered-rendering-static-image.html: Added.

11:39 AM Changeset in webkit [147347] by Nate Chapin

198 edits
3 adds
4 deletes in trunk/LayoutTests

Unreviewed, chromium gardening.

platform/chromium-linux-x86/fast/backgrounds/repeat: Removed.
platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-win/fast/borders/border-image-scaled-expected.png:
platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-win/fast/borders/scaled-border-image-expected.png:
platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium/TestExpectations:

11:24 AM Changeset in webkit [147346] by mkwst@chromium.org

14 edits in trunk

CSP 1.1: Remove 'type' parameter from CSPDirectiveList::checkSourceAndReportViolation.
https://bugs.webkit.org/show_bug.cgi?id=113502

Reviewed by Adam Barth.

Source/WebCore:

Now that we're passing in 'effectiveDirective', we don't need the 'type'
parameter to generate the proper error message prefix when reporting
violations.

While I'm here, I'll slightly tweak the grammar for the error messages.
Changes are covered via rebaselines of existing tests.

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Drop the 'type' parameter. We don't need to pass in a type since
we're now passing in the 'effectiveDirective'; we can use the latter
to generate the correct error message prefix.

(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):
(WebCore::CSPDirectiveList::allowBaseURI):

Drop the 'type' parameter from the callsites, which has the lovely
property of allowing us to throw away a bunch of statically allocated
strings that we don't need anymore.

LayoutTests:

http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/media-src-track-block-expected.txt:
http/tests/security/contentSecurityPolicy/object-src-no-url-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/object-src-url-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
media/csp-blocks-video-expected.txt:
platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
platform/chromium/media/csp-blocks-video-expected.txt:

11:24 AM Changeset in webkit [147345] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Move definition of nested classes that inherit enclosing class outside class definition.
https://bugs.webkit.org/show_bug.cgi?id=113454

Patch by Han Shen <shenhan@google.com> on 2013-04-01
Reviewed by Benjamin Poulain.

HashMap.h does not build on GCC 4.8. Inside this file,
HashMapKeysProxy and HashMapValuesProxy are defined as nested
class inside HashMap - which is legal - the illegal part is that
these 2 classes inherit HashMap, that is the enclosing class, that
causes "reference to in-complete definition" error.

The fix is to move outside the definition of these 2 classes, and
leave only declaration part inside HashMap as is illustrated below -

template class <typename T>
class HashMap {

... ...
... ...

private:

class HashMapKeysProxy;

ERROR - nested class inherits enclosing class.
class HashMapKeysProxy : private HashMap {

... ...

};
... ...
... ...
class HashMapKeysProxy : private HashMap {

... ...

};
... ...
... ...

};

Fixed as below:

template class <typename T>
class HashMap {

... ...
... ...

private:

class HashMapKeysProxy;
class HashMapValuesProxy;

... ...
... ...

};

template <typename T>
class HashMap<T>::HashMapKeysProxy : private HashMap<T> {

... ...

};

template <typename T>
class HashMap<T>::HashMapValuesProxy : private HashMap<T> {

... ...

};

wtf/HashMap.h:

(HashMap):
(WTF): Factor out nested class definition from enclosing class.

11:06 AM Changeset in webkit [147344] by ap@apple.com

2 edits in trunk/Source/WebKit2

<rdar://problem/13490123> Sandbox extension tracking is incorrect when restoring a session
https://bugs.webkit.org/show_bug.cgi?id=113709

Reviewed by Anders Carlsson.

WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad): Added an assertion to catch extension tracking logic errors that could result in giving an extension to non-local pages. (WebKit::WebPage::SandboxExtensionTracker::didCommitProvisionalLoad): Just like below, clearing m_pendingProvisionalSandboxExtension appears incorrect, even though I am not aware of any scenarios where this happens in practice. (WebKit::WebPage::SandboxExtensionTracker::didFailProvisionalLoad): The load may be failing exactly because a new one cancels it, so we shouldn't be preventing the new one from using its extension.

11:05 AM Changeset in webkit [147343] by commit-queue@webkit.org

12 edits in trunk

AX: "video element controller" is an overly verbose default description for the playback controls; how about just "playback"
https://bugs.webkit.org/show_bug.cgi?id=113549

Patch by James Craig <james@cookiecrook.com> on 2013-04-01
Reviewed by Chris Fleizach.

Source/WebCore:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.
Also cleaned up some erroneous comments related to the sub-level controls on these elements.

English.lproj/Localizable.strings:
platform/LocalizedStrings.cpp:

(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):

platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaControlElementString):

Source/WebCore/platform/gtk/po:

Existing test coverage.

Updating the video/audio element's default accessibility labels to be less verbose.

en_CA.po:
en_GB.po:

LayoutTests:

Updating the video/audio element's default accessibility labels to be less verbose.

platform/gtk/accessibility/media-controls-panel-title-expected.txt:
platform/gtk/accessibility/media-controls-panel-title.html:
platform/gtk/accessibility/media-element-expected.txt:
platform/mac/accessibility/media-element-expected.txt:

11:05 AM Changeset in webkit [147342] by beidson@apple.com

2 edits in trunk/Source/WebKit2

SharedMemory release build hardening.
<rdar://problem/13546860> and https://bugs.webkit.org/show_bug.cgi?id=113710

Reviewed by Anders Carlsson.

Successful creation of a memory entry with a size less than the size we requested should be treated
as a failure to create the SharedMemory object.

Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::createFromVMBuffer): Early return if the port we get is bogus for our needs.
(WebKit::SharedMemory::createHandle): Ditto.
(WebKit::SharedMemory::create): Guarantee we pass valid input in to mach_vm_map.

11:00 AM Changeset in webkit [147341] by pfeldman@chromium.org

1 edit
2 deletes in branches/chromium/1410

Revert 140817 "Web Inspector: [Styles] Editing a property value ..."
BUG=225346

Web Inspector: [Styles] Editing a property value containing a trimmed data: URL breaks the style
https://bugs.webkit.org/show_bug.cgi?id=107936

Reviewed by Yury Semikhatsky.

Source/WebCore:

Restore the original CSS property value before editing.

Test: inspector/styles/edit-value-with-trimmed-url.html

inspector/front-end/StylesSidebarPane.js:
LayoutTests:

inspector/styles/edit-value-with-trimmed-url-expected.txt: Added.
inspector/styles/edit-value-with-trimmed-url.html: Added.

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/13084008

10:57 AM Changeset in webkit [147340] by Lucas Forschler

4 edits in tags/Safari-537.35.5/Source

Versioning.

10:50 AM Changeset in webkit [147339] by Lucas Forschler

1 copy in tags/Safari-537.35.5

New Tag.

10:03 AM Changeset in webkit [147338] by commit-queue@webkit.org

2 edits in trunk/Tools

Unreviewed, rolling out r147319.
http://trac.webkit.org/changeset/147319
https://bugs.webkit.org/show_bug.cgi?id=113707

The unit test is still failing on the buildbot (Requested by
zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

Scripts/run-gtk-tests:

(TestRunner):

10:00 AM Changeset in webkit [147337] by fpizlo@apple.com

7 edits
5 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL should support ArithSub
https://bugs.webkit.org/show_bug.cgi?id=113675

Reviewed by Oliver Hunt.

This does the obvious bit of implementing ArithSub, but it also takes this
as an opportunity to clean up how intrinsics and common values (common types
and constants) are handled. Previously they were all lumped together in
FTL::Output. Now, in an effort to split up the files and make FTL::Output
less big, I created a thing called FTL::CommonValues which just tracks the
common values, and a thing called FTL::IntrinsicRepository which just tracks
intrinsics. These and FTL::Output are all related to each other in a linear
hierarchy. Moreover, IntrinsicRepository uses macro-fu to make it easy to
declare new intrinsics in the future.

I also out-of-lined some things and made .cpp files for each of these classes.
Initialize I wasn't going to do this but then I realized that FTL::Output is
already included in multiple places. Probably it's better if some of its guts
are not inline, and it's also good to now have .cpp "landing pads" if we ever
want to add more things to that class.

Note that a lot of how these things are designed has to do with the fact
that pretty soon here I'll have to switch us from using the LLVM global
context to using a context that we create. When that happens, anyone who
creates anything will have to know the context; that's why FTL::CommonValues
already knows the module but doesn't use it - in the future it will have to
do things with it.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLAbbreviations.h:

(JSC::FTL::buildSub):

ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCommonValues.cpp: Added.

(FTL):
(JSC::FTL::CommonValues::CommonValues):

ftl/FTLCommonValues.h: Added.

(FTL):
(CommonValues):
(JSC::FTL::CommonValues::initialize):

ftl/FTLIntrinsicRepository.cpp: Added.

(FTL):
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):

ftl/FTLIntrinsicRepository.h: Added.

(FTL):
(IntrinsicRepository):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(LowerDFGToLLVM):

ftl/FTLOutput.cpp: Added.

(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):

ftl/FTLOutput.h:

(Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::sub):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::subWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):

9:54 AM Changeset in webkit [147336] by Nate Chapin

3 edits in trunk/Source/WebCore

Make a bunch of DocumentLoader functions private
https://bugs.webkit.org/show_bug.cgi?id=113601

Reviewed by Alexey Proskuryakov.

No new tests, cleanup only.

loader/DocumentLoader.cpp:
loader/DocumentLoader.h:

9:44 AM Changeset in webkit [147335] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Fixing borked VS 2010 project file

Unreviewed bot greening.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:

9:32 AM Changeset in webkit [147334] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

One more Windows build fix

Unreviewed.

JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

9:26 AM Changeset in webkit [147333] by kangil.han@samsung.com

3 edits in trunk/Source/WebCore

Minor code cleanup by removing duplicated null checks
https://bugs.webkit.org/show_bug.cgi?id=113701

Reviewed by Darin Adler.

Duplicated null check is code redundancy, so delete those.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::setFocusedNodeIfNeeded):

platform/Arena.cpp:

(WebCore::FreeArenaList):

9:18 AM Changeset in webkit [147332] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

More build fallout fixes.

Unreviewed build fix.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Add new export symbols.
heap/SuperRegion.cpp: Windows didn't like "LLU".

9:14 AM Changeset in webkit [147331] by pfeldman@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: follow up to r147323, popover is empty on network panel.
Not reviewed.

inspector/front-end/DOMExtension.js:

(Element.prototype.measurePreferredSize):

inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

9:01 AM Changeset in webkit [147330] by mhahnenberg@apple.com

6 edits in trunk/Source/JavaScriptCore

r147324 broke the world
https://bugs.webkit.org/show_bug.cgi?id=113704

Unreviewed build fix.

Remove a bunch of unused variables and use the correctly sized types for 32-bit platforms.

heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):

heap/BlockAllocator.h:

(BlockAllocator):

heap/Heap.cpp:

(JSC::Heap::Heap):

heap/SuperRegion.cpp:

(JSC::SuperRegion::SuperRegion):

heap/SuperRegion.h:

(SuperRegion):

8:35 AM Changeset in webkit [147329] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

32-bit Windows build fix

Unreviewed build fix.

heap/SuperRegion.cpp:
heap/SuperRegion.h: Use uint64_t instead of size_t.

(SuperRegion):

8:28 AM Changeset in webkit [147328] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

EFL build fix

Unreviewed build fix.

CMakeLists.txt:

8:26 AM Changeset in webkit [147327] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Exception in console on attempt to filter javascript messages.
https://bugs.webkit.org/show_bug.cgi?id=113327

Fixed non-css filtration if console message groups are present. Message groups elements are always shown and are
never filtered out.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.updateRepeatCount):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._printResult):

8:25 AM Changeset in webkit [147326] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL doesn't need virtual register allocation
https://bugs.webkit.org/show_bug.cgi?id=113679

Reviewed by Mark Hahnenberg.

dfg/DFGDriver.cpp:

(JSC::DFG::dumpAndVerifyGraph):
(DFG):
(JSC::DFG::compile):

8:24 AM Changeset in webkit [147325] by vcarbune@chromium.org

12 edits
3 adds in trunk

Parsing WebVTT Region Header Metadata
https://bugs.webkit.org/show_bug.cgi?id=109818

Reviewed by Eric Carlson.

Source/WebCore:

This patch enables reading regions from the metadata section of
a WebVTT file. The work for defining generic metadata within the
WebVTT file header is still work in progress in the TextTrack CG.

As previous patches, everything is guarded by WEBVTT_REGIONS and
is by default disabled in all ports.

Test: media/track/regions-webvtt/text-track-region-parser.html

html/track/LoadableTextTrack.cpp:

(WebCore):
(WebCore::LoadableTextTrack::newRegionsAvailable): Added method
to be called as soon as regions have finished parsing.

html/track/LoadableTextTrack.h:

(LoadableTextTrack):

html/track/TextTrack.h: Changed the access modifiers.

(TextTrack):

html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::setRegionSettings): Entry point for
parsing the region settings from a string.
(WebCore):
(WebCore::TextTrackRegion::getSettingFromString): Maps a string
to a RegionSetting value.
(WebCore::TextTrackRegion::parseSettingValue): Parses the value
of a specific setting.
(WebCore::TextTrackRegion::parseSetting): Parses a setting string.

html/track/TextTrackRegion.h:
html/track/WebVTTParser.cpp:

(WebCore):
(WebCore::WebVTTParser::parseFloatPercentageValue): Helper method
to parse a float percentage value (e.g. "50.1%")
(WebCore::WebVTTParser::parseFloatPercentageValuePair): Helper method
to parse a float percentage value pair (e.g. "50.1%, 30.5%")
(WebCore::WebVTTParser::getNewRegions): Retrieves the new regions
available for processing.
(WebCore::WebVTTParser::parseBytes):
(WebCore::WebVTTParser::collectHeader): Generic function to collect
header in the metadata region.
(WebCore::WebVTTParser::createNewRegion): Creates new region using
the existing metadata header name and value.

html/track/WebVTTParser.h:

(WebVTTParserClient):
(WebVTTParser):

loader/TextTrackLoader.cpp:

(WebCore):
(WebCore::TextTrackLoader::newRegionsParsed): Called when the
regions have been succesfully parsed.
(WebCore::TextTrackLoader::getNewRegions): Gets the new regions.

loader/TextTrackLoader.h:

(TextTrackLoaderClient): Added methods that need to be implemented.
(TextTrackLoader):

LayoutTests:

media/track/captions-webvtt/header-regions.vtt: Added.
media/track/regions-webvtt/text-track-region-parser-expected.txt: Added.
media/track/regions-webvtt/text-track-region-parser.html: Added.

8:23 AM Changeset in webkit [147324] by mhahnenberg@apple.com

18 edits
2 adds in trunk/Source

Regions should be allocated from the same contiguous segment of virtual memory
https://bugs.webkit.org/show_bug.cgi?id=113662

Reviewed by Filip Pizlo.

Instead of letting the OS spread our Regions all over the place, we should allocate them all within
some range of each other. This change will open the door to some other optimizations, e.g. doing simple
range checks for our write barriers and compressing JSCell pointers to 32-bits.

Source/JavaScriptCore:

Added new SuperRegion class that encapsulates allocating Regions from a contiguous reserved chunk of
virtual address space. It functions very similarly to the FixedVMPoolExecutableAllocator class used by the JIT.

Also added two new subclasses of Region, NormalRegion and ExcessRegion.

NormalRegion is the type of Region that is normally allocated when there is available space remaining
in the SuperRegion. If we ever run out of space in the SuperRegion, we fall back to allocating
ExcessRegions, which are identical to how Regions have behaved up until now, i.e. they contain a
PageAllocationAligned.

We only use the SuperRegion (and NormalRegions) on 64-bit systems, since it doesn't make sense to reserve the
entire 4 GB address space on 32-bit systems just for the JS heap.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
Target.pri:
heap/BlockAllocator.cpp:

(JSC::BlockAllocator::BlockAllocator):

heap/BlockAllocator.h:

(JSC):
(BlockAllocator):
(JSC::BlockAllocator::allocate):
(JSC::BlockAllocator::allocateCustomSize):
(JSC::BlockAllocator::deallocateCustomSize):

heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC):
(JSC::Heap::didExceedFixedHeapSizeLimit):

heap/Heap.h:

(Heap):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):

heap/Region.h:

(Region):
(JSC):
(NormalRegion):
(JSC::NormalRegion::base):
(JSC::NormalRegion::size):
(ExcessRegion):
(JSC::ExcessRegion::base):
(JSC::ExcessRegion::size):
(JSC::NormalRegion::NormalRegion):
(JSC::NormalRegion::tryCreate):
(JSC::NormalRegion::tryCreateCustomSize):
(JSC::NormalRegion::reset):
(JSC::ExcessRegion::ExcessRegion):
(JSC::ExcessRegion::~ExcessRegion):
(JSC::ExcessRegion::create):
(JSC::ExcessRegion::createCustomSize):
(JSC::ExcessRegion::reset):
(JSC::Region::Region):
(JSC::Region::initializeBlockList):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::~Region):
(JSC::Region::destroy):
(JSC::Region::reset):
(JSC::Region::deallocate):
(JSC::Region::base):
(JSC::Region::size):

heap/SuperRegion.cpp: Added.

(JSC):
(JSC::SuperRegion::SuperRegion):
(JSC::SuperRegion::getAlignedBase):
(JSC::SuperRegion::allocateNewSpace):
(JSC::SuperRegion::notifyNeedPage):
(JSC::SuperRegion::notifyPageIsFree):

heap/SuperRegion.h: Added.

(JSC):
(SuperRegion):

Source/WTF:

wtf/MetaAllocator.cpp: Changed the MetaAllocator to allow custom page sizes if the derived class wants to

use something other than the system page size.
(WTF::MetaAllocator::MetaAllocator):

wtf/MetaAllocator.h:

(MetaAllocator):

7:03 AM Changeset in webkit [147323] by pfeldman@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Go to line dialog has 0 height, viewport dialogs have empty gaps.
https://bugs.webkit.org/show_bug.cgi?id=113702

Reviewed by Yury Semikhatsky.

inspector/front-end/DOMExtension.js:

(Element.prototype.measurePreferredSize):

inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._innerShow):

inspector/front-end/ViewportControl.js:

(WebInspector.ViewportControl.prototype.refresh):

inspector/front-end/dialog.css:

(.dialog-contents):

5:52 AM Changeset in webkit [147322] by commit-queue@webkit.org

4 edits
2 adds in trunk

Web Inspector: [DTE] Convertion between text and coordinates
https://bugs.webkit.org/show_bug.cgi?id=113389

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/editor/text-editor-char-to-coordinates.html

Implement cursorPositionToCoordinates and coordinatesToCursorPosition
methods pair in DefaultTextEditor.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.DefaultTextEditor.prototype.coordinatesToCursorPosition):
(WebInspector.TextEditorMainPanel.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditorMainPanel.prototype.coordinatesToCursorPosition):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.cursorPositionToCoordinates):
(WebInspector.TextEditor.prototype.coordinatesToCursorPosition):

LayoutTests:

Test to verify added functionality.

inspector/editor/text-editor-char-to-coordinates-expected.txt: Added.
inspector/editor/text-editor-char-to-coordinates.html: Added.

5:47 AM Changeset in webkit [147321] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Rename "Copy to Curl" menu item command to "Copy to cURL"
https://bugs.webkit.org/show_bug.cgi?id=113575

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

Fix the name to the offical way of capitalization.

English.lproj/localizedStrings.js:
inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._contextMenu):

5:13 AM Changeset in webkit [147320] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

3:46 AM Changeset in webkit [147319] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
https://bugs.webkit.org/show_bug.cgi?id=104779

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-01
Reviewed by Carlos Garcia Campos.

Scripts/run-gtk-tests:

(TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
passing in current trunk.

3:39 AM Changeset in webkit [147318] by zandobersek@gmail.com

2 edits
1 add in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for tests added in r147249 and r147250 that fail

due to disabled subpixel layout. Adding failure expectations for tests that regressed with r147241.

platform/gtk/fast/events/event-attribute-expected.txt: Added the required baseline after r147205.

3:35 AM Changeset in webkit [147317] by commit-queue@webkit.org

3 edits
2 adds in trunk

ASSERTION FAILED: m_purgePreventCount when clicking text with emphasis marks
https://bugs.webkit.org/show_bug.cgi?id=85266

Patch by Koji Ishii <Koji Ishii> on 2013-04-01
Reviewed by Darin Adler.

Font::glyphDataAndPageForCharacter may call FontCache::getFontDataForCharacters
if system fallback occurs, which may return SimpleFontData with DoNotRetain,
so callers must prevent possible font cache purging.

Source/WebCore:

Test: fast/text/emphasis-height-crash.html

platform/graphics/FontFastPath.cpp:

(WebCore::Font::emphasisMarkAscent): Add FontCachePurgePreventer.
(WebCore::Font::emphasisMarkDescent): ditto.
(WebCore::Font::emphasisMarkHeight): ditto.
(WebCore::Font::drawEmphasisMarks): ditto.

LayoutTests:

fast/text/emphasis-height-crash-expected.txt: Added.
fast/text/emphasis-height-crash.html: Added.

3:32 AM Changeset in webkit [147316] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

Remove an unused variable from the ARMv7 Assembler
https://bugs.webkit.org/show_bug.cgi?id=113653

Reviewed by Andreas Kling.

assembler/ARMv7Assembler.h:

(ARMv7Assembler):

3:29 AM Changeset in webkit [147315] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[GTK] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113677

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-01

platform/gtk/TestExpectations: Rebaseline after r147219.

3:25 AM Changeset in webkit [147314] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Fixed DOM Breakpoint pane styles.
https://bugs.webkit.org/show_bug.cgi?id=113688

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-04-01
Reviewed by Pavel Feldman.

The required stylesheet (breakpointsList.css) was not loaded because of
the peculiar way DOMBreakpointsSidebarPane is included in two panels
(Sources and Elements) via a proxy pane. Since DOMBreakpointsSidebarPane
was never shown directly the registerRequiredCSS call in its base class
NativeBreakpointsSidebarPane constructor had no effect.
Addin a registerRequiredCSS call to the proxy pane constructor fixes the
problem.

inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.Proxy):

2:41 AM Changeset in webkit [147313] by yurys@chromium.org

2 edits in trunk/Source/WTF

Web Inspector: add memory instrumentation for StringBuffer
https://bugs.webkit.org/show_bug.cgi?id=113507

Reviewed by Pavel Feldman.

Added memory instrumentation for StringBuffer.

wtf/MemoryInstrumentationString.h:

(WTF):
(WTF::reportMemoryUsage):

2:39 AM Changeset in webkit [147312] by shinyak@chromium.org

198 edits
1 move
4 adds
19 deletes in trunk/LayoutTests

Unreviewed, rolling out r147298.
http://trac.webkit.org/changeset/147298

broke lots of layout tests

platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Added.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Added.
platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Added.
platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Added.
platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Removed.
platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-win/fast/borders/border-image-scaled-expected.png:
platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-win/fast/borders/scaled-border-image-expected.png:
platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium/TestExpectations:
platform/chromium/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium-win/css3/images/cross-fade-background-size-expected.png.

2:27 AM Changeset in webkit [147311] by shinyak@chromium.org

237 edits
6 deletes in trunk/LayoutTests

Unreviewed, rolling out r147301.
http://trac.webkit.org/changeset/147301

broke lots of layout tests

platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Removed.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Removed.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Removed.
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:

2:18 AM Changeset in webkit [147310] by shinyak@chromium.org

153 edits
3 deletes in trunk/LayoutTests

Unreviewed, rolling out r147302.
http://trac.webkit.org/changeset/147302

broke lots of layout tests

platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Removed.
platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Removed.
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

2:02 AM Changeset in webkit [147309] by commit-queue@webkit.org

1 edit
10 adds in trunk/LayoutTests

Unreviewed, rolling out r147307.
http://trac.webkit.org/changeset/147307
https://bugs.webkit.org/show_bug.cgi?id=113692

maybe broken lots of layout tests (Requested by
shinyak|gardener on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-01

platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.

1:13 AM Changeset in webkit [147308] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Extract item to coordinates conversion into a separate function.
https://bugs.webkit.org/show_bug.cgi?id=113682

Reviewed by Yury Semikhatsky.

The calculation was extracted into entryToAnchorBox.

Drive by fixes: unnecessary members were removed.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Entry):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._entryToAnchorBox):
(WebInspector.FlameChart.prototype.draw):

12:19 AM Changeset in webkit [147307] by shinyak@chromium.org

1 edit
10 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Removed.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Removed.
platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Removed.

12:04 AM Changeset in webkit [147306] by commit-queue@webkit.org

6 edits in trunk

[EFL] Enable user-select:all for EFL port
https://bugs.webkit.org/show_bug.cgi?id=113494

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.

Add a feature flag for user-select:all and enable it for EFL port.

Source/cmake/OptionsEfl.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

LayoutTests:

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-01
Reviewed by Gyuyoung Kim.

Enable user-select:all for EFL port and update the TestExpectations.

platform/efl/TestExpectations:

Mar 31, 2013:

11:55 PM Changeset in webkit [147305] by commit-queue@webkit.org

3 edits
1 move in trunk/Tools

Unreviewed, rolling out r147289.
http://trac.webkit.org/changeset/147289
https://bugs.webkit.org/show_bug.cgi?id=113678

broke Win7 (dbg) build (Requested by shinyak|gardener on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-31

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.

(WebTestRunner):
(WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
(WebTestRunner::WebUserMediaClientMock::taskList):

Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

11:29 PM Changeset in webkit [147304] by abarth@webkit.org

2 edits in trunk/Tools

configure-svn-config.sh fails
https://codereview.chromium.org/13392007/

Reviewed by Eric Seidel.

This script was trying to use "svn checkout" to dowload a file from
svn.webkit.org, but "svn checkout" only works with directories.
Instead, we should use "svn export".

EWSTools/configure-svn-config.sh:

11:14 PM FeatureFlags edited by tkent@chromium.org

VIEWSOURCE_ATTRIBUTE (diff)

10:54 PM Changeset in webkit [147303] by commit-queue@webkit.org

5 edits
2 adds in trunk

Gradient background does not get repainted when child box is expanded.
https://bugs.webkit.org/show_bug.cgi?id=113644

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.

The initial value for background-size is SizeNone and remains, unless it is
set explicitly. However, when the background shorthand is used,
the size property defaults to SizeLength. The repaint
logic in mustRepaintFillLayers expects to have this value set correctly.

Test: fast/repaint/background-shorthand-with-gradient-and-height-changes.html

rendering/RenderObject.cpp:

(WebCore::mustRepaintFillLayers): code cleanup. no functionality change.

rendering/style/FillLayer.cpp:

(WebCore::FillLayer::FillLayer):

rendering/style/FillLayer.h: use SizeNone as initial value.

(WebCore::FillLayer::initialFillSizeType):
(WebCore::FillLayer::initialFillSize):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-31
Reviewed by Antti Koivisto.

fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt: Added.
fast/repaint/background-shorthand-with-gradient-and-height-changes.html: Added.

10:23 PM Changeset in webkit [147302] by shinyak@chromium.org

153 edits
4 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

platform/chromium-linux-x86/tables/mozilla/marvin/tfoot_valign_bottom-expected.png: Added.
platform/chromium-linux-x86/tables/mozilla/marvin/th_valign_top-expected.png: Added.
platform/chromium-linux-x86/tables/mozilla/marvin/tr_valign_middle-expected.png: Added.
platform/chromium-linux/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-linux/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-linux/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-lion/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-lion/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-mac/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1430-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug15544-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug97383-expected.png:
platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
platform/chromium-win/tables/mozilla/core/col_widths_auto_autoFix-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tbody_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/td_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tfoot_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/thead_valign_top-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_baseline-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_bottom-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_middle-expected.png:
platform/chromium-win/tables/mozilla/marvin/tr_valign_top-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug6933-expected.png:

9:48 PM Changeset in webkit [147301] by shinyak@chromium.org

237 edits
7 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Added.
platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Added.
platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Added.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-linux-x86/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-linux/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-linux/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-linux/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-linux/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac-lion/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac-lion/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-lion/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-lion/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-lion/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac-snowleopard/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac-snowleopard/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-mac/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-mac/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1296-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-win/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/custom/clip-mask-negative-scale-expected.png:
platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png:
platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png:
platform/chromium-win/svg/filters/feImage-preserveAspectratio-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug1296-expected.png:

9:35 PM Changeset in webkit [147300] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/WTF

https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.

Unreviewed.

Forgot to land these as part of http://trac.webkit.org/changeset/147299.

wtf/MathExtras.h:

(isGreaterThanNonZeroPowerOfTwo):

9:33 PM Changeset in webkit [147299] by fpizlo@apple.com

4 edits in branches/dfgFourthTier/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=113656
Fix Sam's nits.

Unreviewed.

ftl/FTLAbstractHeap.cpp:

(JSC::FTL::IndexedAbstractHeap::initialize):

ftl/FTLAbstractHeap.h:

(IndexedAbstractHeap):
(AbsoluteAbstractHeap):

ftl/FTLAbstractHeapRepository.h:

(AbstractHeapRepository):

9:29 PM Changeset in webkit [147298] by shinyak@chromium.org

198 edits
1 copy
1 move
18 adds
4 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaselining.

platform/chromium-linux-x86/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
platform/chromium-linux-x86/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png: Removed.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-linux-x86/fast/backgrounds/size/backgroundSize06-expected.png: Added.
platform/chromium-linux-x86/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-linux-x86/fast/borders/border-image-scale-transform-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/border-image-scaled-expected.png: Removed.
platform/chromium-linux-x86/fast/borders/scaled-border-image-expected.png: Removed.
platform/chromium-linux-x86/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
platform/chromium-linux-x86/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-linux-x86/svg/W3C-I18N/text-dirRTL-ubNone-expected.png: Copied from LayoutTests/platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png.
platform/chromium-linux/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-linux/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-linux/css3/images/cross-fade-background-size-expected.png: Added.
platform/chromium-linux/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-linux/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-linux/fast/backgrounds/size/backgroundSize06-expected.png: Added.
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-linux/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-linux/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-linux/fast/borders/border-image-scaled-expected.png:
platform/chromium-linux/fast/borders/scaled-border-image-expected.png:
platform/chromium-linux/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-linux/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-linux/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-lion/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-lion/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-mac-lion/fast/backgrounds/size/backgroundSize06-expected.png: Added.
platform/chromium-mac-lion/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-mac-lion/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-lion/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-lion/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-lion/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-lion/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-lion/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac-snowleopard/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize02-expected.png: Added.
platform/chromium-mac-snowleopard/fast/backgrounds/size/backgroundSize06-expected.png: Added.
platform/chromium-mac-snowleopard/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac-snowleopard/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac-snowleopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac-snowleopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac-snowleopard/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-mac/fast/borders/scaled-border-image-expected.png:
platform/chromium-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-win/css2.1/20110323/replaced-min-max-001-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
platform/chromium-win/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
platform/chromium-win/css3/images/cross-fade-background-size-expected.png: Renamed from LayoutTests/platform/chromium/css3/images/cross-fade-background-size-expected.png.
platform/chromium-win/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize02-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize04-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize06-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize13-expected.png:
platform/chromium-win/fast/backgrounds/size/backgroundSize14-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/chromium-win/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.png:
platform/chromium-win/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-win/fast/borders/border-image-scaled-expected.png:
platform/chromium-win/fast/borders/border-image-side-reduction-expected.png:
platform/chromium-win/fast/borders/scaled-border-image-expected.png:
platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png:
platform/chromium-win/fast/replaced/absolute-image-sizing-expected.png:
platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
platform/chromium-win/platform/chromium/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-win/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-win/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium/TestExpectations:

9:20 PM Changeset in webkit [147297] by fpizlo@apple.com

5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should support GetByVal on Int32 arrays
https://bugs.webkit.org/show_bug.cgi?id=113668

Reviewed by Sam Weinig.

It actually already supported this, but needed to be told that it did.

Also adds an option to enable LICM (loop-invariant code motion, i.e.
http://llvm.org/docs/Passes.html#licm-loop-invariant-code-motion). LICM
isn't doing me any good right now, but I guess I'll have to play with
it more. And this adds the ability to tweak the LLVM optimization level
from the command-line.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

runtime/Options.h:

(JSC):

8:52 PM Changeset in webkit [147296] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

platform/chromium/TestExpectations:

8:44 PM Changeset in webkit [147295] by hayato@chromium.org

4 edits
2 adds in trunk

Text representation of pseudo elements, '::-webkit-distributed', is wrong in CSSSelector::selectorText().
https://bugs.webkit.org/show_bug.cgi?id=113560

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the text representation of distributed functional pseudo elements in CSSSelector::selectorText().

Test: fast/dom/shadow/distributed-pseudo-element-css-text.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:

(CSSSelector):

LayoutTests:

fast/dom/shadow/distributed-pseudo-element-css-text-expected.txt: Added.
fast/dom/shadow/distributed-pseudo-element-css-text.html: Added.

8:06 PM Changeset in webkit [147294] by abarth@webkit.org

5 edits
1 move in trunk/Source

[Chromium] Yarr should build using a separate GYP file from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=113652

Reviewed by Nico Weber.

Source/JavaScriptCore:

This patch moves JavaScriptCore.gyp to yarr.gyp because Chromium only
uses this GYP file to build yarr.

JavaScriptCore.gyp/JavaScriptCoreGTK.gyp:
JavaScriptCore.gypi:
yarr/yarr.gyp: Renamed from Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp.

Source/WebCore:

WebCore.gyp/WebCore.gyp:
- Update references to yarr.gyp.

7:52 PM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

6:16 PM Changeset in webkit [147293] by kangil.han@samsung.com

9 edits in trunk/Source

[EFL] Remove unused stdio.h includes
https://bugs.webkit.org/show_bug.cgi?id=113655

Reviewed by Andreas Kling.

We do not have to include unused header file.

Source/WebCore:

platform/efl/CursorEfl.cpp:
platform/efl/FileSystemEfl.cpp:
platform/efl/PlatformKeyboardEventEfl.cpp:
platform/efl/ScrollbarThemeEfl.cpp:

Source/WebKit/efl:

ewk/ewk_tiled_backing_store.cpp:
ewk/ewk_tiled_matrix.cpp:
ewk/ewk_tiled_model.cpp:

(tile_account):

4:28 PM Changeset in webkit [147292] by fpizlo@apple.com

6 edits
5 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should supply TBAA meta-data to LLVM
https://bugs.webkit.org/show_bug.cgi?id=113656

Reviewed by Oliver Hunt.

This adds support for performing strong typing on the LLVM IR that the FTL
generates, by using TBAA meta-data. This will permit LLVM to do aggressive
GVN, load elimination, and LICM optimization even if it sees pointer store
side-effects. The goal is to precisely model all loads and stores we emit,
except for the super crazy ones (GetById that can go all-out polymorphic,
or for example a Call where we know nothing).

This is accomplished by introducing the notion of an AbstractHeap
typesystem. An AbstractHeap is a subset of all possible memory locations
that we might store to. For example, JSCell::m_structure and
JSObject::m_butterfly are two disjoint AbstractHeaps because we know that
a store to one cannot clobber the other. AbstractHeaps follow a
single-inheritance hierarchy. There is the root heap, which corresponds to
any possible memory location accessible to the JS engine, and then there
are heaps for all internal object fields, a heap for each global object,
and so on.

There are three other tidbits here that make this somewhat more interesting.
We have a notion of an AbstractHeap-with-offset, called AbstractField.
JSCell::m_structure is actually an AbstractField. This allows us to say
things like m_out.loadPtr(base, m_heaps.JSCell_structure); this both
gives you the offset of JSCell::m_structure and ascribes TBAA meta-data for
the JSCell::m_structure heap to the generated load instrction.

Another fun tidbit is the notion of Indexed, Numbered, and Absolute abstract
heaps. An indexed abstract heap corresponds to a set of locations that you
might access by index from some base. Virtual registers are a great example.
Though I call them just "variables" in the FTL. When we access a virtual
register, we know that we aren't interfering with accesses to
Structure-managed named properties, or with JSCell::m_structure, or with
other such disjoint heaps. But we also know that if we access a variable at
offset X and then another variable at offset Y and we know that X and Y are
unequal, then these two accesses are on disjoint subheaps of the variables
heap. This works out naturally for interference between, say, scoped variable
access and local variable access: if you access scoped variable r5 and then
access a local variable r5, these might interfere - and they will get the
same abstract subheap of the variables heap. IndexedAbstractHeaps
conveniently remember the size of the elements and will give you an
AbstractField (i.e. heap-with-offset) if you give it an index. This is great
for conveniently writing code that accesses contiguous arrays of well-typed
things. This allows you to literally do things like
m_out.load64(callFrameRegister, m_heaps.variables[operand]) and the right
thing will happen. You can also get the heap variables.atAnyIndex(), if
you're doing an access with an unknown index.

Numbered and Absolute abstract heaps are related except that they don't
assume that the value used to get the abstract subheap corresponds to any
meaningful offset from any base. Numbered heaps, like the properties heap
(for named properties tracked by Structure), are "numbered" (not indexed)
by the propertyNumber. So you can emit a GetByOffset by separately
computing the offset and the propertyNumber (both values are stored in the
StorageAccessData), and passing the offset directly to Output::address()
and passing m_heaps.properties[propertyNumber] as the field. Absolute heaps
are similar, but are keyed on absolute address. This is appropriate for
global variables, and possibly other things.

Finally, FTL::Output understands the notion of a pointer-with-TBAA-data,
and calls it a TypedPointer. TypedPointer is a tuple of a LLVMValueRef
referencing an intptr value and a pointer to an AbstractHeap. All load()
and store() operations now take a TypedPointer, and will perform the access
by casting the intptr to a pointer of the right type and then ascribing the
TBAA meta-data from the AbstractHeap.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLAbbreviations.h:

(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(FTL):
(JSC::FTL::setMetadata):

ftl/FTLAbstractHeap.cpp: Added.

(FTL):
(JSC::FTL::AbstractHeap::tbaaMetadataSlow):
(JSC::FTL::AbstractHeap::decorateInstruction):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::~IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::baseIndex):
(JSC::FTL::IndexedAbstractHeap::atSlow):
(JSC::FTL::IndexedAbstractHeap::initialize):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::~NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::~AbsoluteAbstractHeap):

ftl/FTLAbstractHeap.h: Added.

(FTL):
(AbstractHeap):
(JSC::FTL::AbstractHeap::AbstractHeap):
(JSC::FTL::AbstractHeap::isInitialized):
(JSC::FTL::AbstractHeap::initialize):
(JSC::FTL::AbstractHeap::parent):
(JSC::FTL::AbstractHeap::heapName):
(JSC::FTL::AbstractHeap::tbaaMetadata):
(AbstractField):
(JSC::FTL::AbstractField::AbstractField):
(JSC::FTL::AbstractField::initialize):
(JSC::FTL::AbstractField::offset):
(IndexedAbstractHeap):
(JSC::FTL::IndexedAbstractHeap::atAnyIndex):
(JSC::FTL::IndexedAbstractHeap::at):
(JSC::FTL::IndexedAbstractHeap::operator[]):
(JSC::FTL::IndexedAbstractHeap::returnInitialized):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::constructDeletedValue):
(JSC::FTL::IndexedAbstractHeap::MyHashTraits::isDeletedValue):
(NumberedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::atAnyNumber):
(JSC::FTL::NumberedAbstractHeap::at):
(JSC::FTL::NumberedAbstractHeap::operator[]):
(AbsoluteAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::atAnyAddress):
(JSC::FTL::AbsoluteAbstractHeap::at):
(JSC::FTL::AbsoluteAbstractHeap::operator[]):

ftl/FTLAbstractHeapRepository.cpp: Added.

(FTL):
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
(JSC::FTL::AbstractHeapRepository::~AbstractHeapRepository):

ftl/FTLAbstractHeapRepository.h: Added.

(FTL):
(AbstractHeapRepository):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(LowerDFGToLLVM):

ftl/FTLOutput.h:

(FTL):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::addPtr):
(JSC::FTL::Output::address):
(JSC::FTL::Output::baseIndex):

ftl/FTLTypedPointer.h: Added.

(FTL):
(TypedPointer):
(JSC::FTL::TypedPointer::TypedPointer):
(JSC::FTL::TypedPointer::operator!):
(JSC::FTL::TypedPointer::heap):
(JSC::FTL::TypedPointer::value):

runtime/Options.h:

(JSC):

4:27 PM Changeset in webkit [147291] by rafaelw@chromium.org

4 edits
3 adds in trunk

HTMLLinkElement should resolve resource URLs when resources will be fetched
https://bugs.webkit.org/show_bug.cgi?id=113630

Source/WebCore:

HTMLLinkElement was resolving its URL when the href attribute was processed and caching it without ever
invalidating the cached URL. This patch removes the cached URL and adds getURL() which resolve the
URL dynamically.

Reviewed by Eric Seidel.

Test: fast/dom/HTMLLinkElement/resolve-url-on-insertion.html

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::getURL):
(WebCore):
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::shouldLoadLink):
(WebCore::HTMLLinkElement::process):

html/HTMLLinkElement.h:

(HTMLLinkElement):

LayoutTests:

Reviewed by Eric Seidel.

fast/dom/HTMLLinkElement/resolve-url-on-insertion-expected.txt: Added.
fast/dom/HTMLLinkElement/resolve-url-on-insertion.html: Added.
fast/dom/HTMLLinkElement/resources/stylesheet2.css: Added.

(#test2):

4:25 PM Changeset in webkit [147290] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix a comment. While thinking about TBAA for array accesses,
I realized that we have to be super careful about aliasing of typed arrays.

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getByValLoadElimination):

4:17 PM Changeset in webkit [147289] by commit-queue@webkit.org

3 edits
1 move in trunk/Tools

Allow WebUserMediaClientMock to be used by client
https://bugs.webkit.org/show_bug.cgi?id=113633

Patch by Wei Jia <wjia@chromium.org> on 2013-03-31
Reviewed by Adam Barth.

Export WebUserMediaClientMock.
Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.

DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.

(WebUserMediaClientMock):

DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):

1:34 PM Changeset in webkit [147288] by aelias@chromium.org

2 edits in branches/chromium/1410/Source/WebKit/chromium

Merge 147181 "[chromium] Use widget.parent() for plugin WebMouse..."

[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

TBR=aelias@chromium.org
Review URL: https://codereview.chromium.org/13190003

1:13 PM Changeset in webkit [147287] by beidson@apple.com

2 edits in trunk/Source/WebCore

NetworkProcess crashes in WebCoreResourceHandleAsOperationQueueDelegate callbacks.
<rdar://problem/13541868> and https://bugs.webkit.org/show_bug.cgi?id=113664

Reviewed by Dan Bernstein.

In the "two-part" callbacks that involve waiting on a semaphore for the async block to finish,
the delegate might have been destroyed by the time the wait completes.

A RetainPtr<> protector will fix that up nicely.

platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionShouldUseCredentialStorage:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:canAuthenticateAgainstProtectionSpace:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willCacheResponse:]):

12:33 PM Changeset in webkit [147286] by fpizlo@apple.com

4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should be able to compile the Array.prototype.findGraphNode function in Kraken/ai-astar
https://bugs.webkit.org/show_bug.cgi?id=113646

Reviewed by Oliver Hunt.

This adds enough FTL support to compile Array.prototype.findGraphNode. This isn't
a speed-up, yet, because findGraphNode tends to be aggressively inlined by the DFG,
and the FTL can't yet compile the things into which it was inlined. In future
patches we will get to a point where we can compile the callers, and then we'll be
able to see what the performance effects are.

But the interesting thing is that it isn't a slow-down, either. This implies that
even if we FTL compile a CodeBlock that we shouldn't have (the fact that we
compiling things that end up being inlined is dumb, and the fact that the current
FTL tiering strategy launches LLVM for those things is even dumber), we still run
at OK performance.

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileGetButterfly):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowObject):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::lowStorage):
(JSC::FTL::LowerDFGToLLVM::isNotInt32):
(JSC::FTL::LowerDFGToLLVM::isNotCell):
(JSC::FTL::LowerDFGToLLVM::isNotBoolean):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateCell):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::accountedPointer):
(JSC::FTL::LowerDFGToLLVM::weakPointer):

ftl/FTLOutput.h:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::baseIndex):

Mar 30, 2013:

9:30 PM Changeset in webkit [147285] by abarth@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused includes of stdio.h
https://bugs.webkit.org/show_bug.cgi?id=113650

Reviewed by Dimitri Glazkov.

We shouldn't include stdio.h. These includes aren't used anyway.

src/WebInputEvent.cpp:
src/x11/WebScreenInfoFactory.cpp:

9:11 PM Changeset in webkit [147284] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove unused include of RegularExpression.h
https://bugs.webkit.org/show_bug.cgi?id=113649

Reviewed by Dimitri Glazkov.

Modules/filesystem/DOMFilePath.cpp:
- This include isn't used.

5:04 PM Changeset in webkit [147283] by fpizlo@apple.com

9 edits
4 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able to compile the Marsaglia random number generator
https://bugs.webkit.org/show_bug.cgi?id=113635

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Just adding missing functionality.

Also "fixed" OSR exit to use a call to abort() in addition to using Unreachable
since the latter doesn't actually mean trap - quite the opposite, it tells LLVM
that the code can never be reached.

The Marsaglia function runs ~60% faster with FTL, than DFG. Not a terrible start.

JavaScriptCore.xcodeproj/project.pbxproj:
ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::voidType):
(JSC::FTL::structType):
(JSC::FTL::functionType):
(JSC::FTL::addFunction):
(JSC::FTL::setLinkage):
(JSC::FTL::setFunctionCallingConv):
(JSC::FTL::addExternFunction):
(JSC::FTL::constIntToPtr):
(JSC::FTL::constBitCast):
(JSC::FTL::buildMul):
(JSC::FTL::buildOr):
(JSC::FTL::buildShl):
(JSC::FTL::buildAShr):
(JSC::FTL::buildCall):
(JSC::FTL::buildExtractValue):
(JSC::FTL::dumpModule):
(JSC::FTL::verifyModule):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileBitAnd):
(JSC::FTL::LowerDFGToLLVM::compileBitOr):
(JSC::FTL::LowerDFGToLLVM::compileBitRShift):
(JSC::FTL::LowerDFGToLLVM::compileBitLShift):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):

ftl/FTLOutput.h:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(Output):
(JSC::FTL::Output::mul):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::addWithOverflow32):
(JSC::FTL::Output::mulWithOverflow32):
(JSC::FTL::Output::extractValue):
(JSC::FTL::Output::call):
(JSC::FTL::Output::addWithOverflow32Function):
(JSC::FTL::Output::mulWithOverflow32Function):

ftl/FTLState.cpp: Added.

(FTL):
(JSC::FTL::State::dumpState):

ftl/FTLState.h:

(State):

LayoutTests:

Reviewed by Oliver Hunt.

fast/js/regress/marsaglia-expected.txt: Added.
fast/js/regress/marsaglia.html: Added.
fast/js/regress/script-tests/marsaglia.js: Added.

(marsaglia):

12:01 PM Changeset in webkit [147282] by mhahnenberg@apple.com

8 edits
1 add in trunk/Source/JavaScriptCore

Move Region into its own header
https://bugs.webkit.org/show_bug.cgi?id=113617

Reviewed by Geoffrey Garen.

BlockAllocator.h is getting a little crowded. We should move the Region class into its own
header, since it's pretty independent from the BlockAllocator.

GNUmakefile.list.am:
JavaScriptCore.gypi:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/BlockAllocator.h:

(JSC):

heap/Region.h: Added.

(JSC):
(DeadBlock):
(JSC::DeadBlock::DeadBlock):
(Region):
(JSC::Region::blockSize):
(JSC::Region::isFull):
(JSC::Region::isEmpty):
(JSC::Region::isCustomSize):
(JSC::Region::create):
(JSC::Region::createCustomSize):
(JSC::Region::Region):
(JSC::Region::~Region):
(JSC::Region::reset):
(JSC::Region::allocate):
(JSC::Region::deallocate):

11:31 AM Changeset in webkit [147281] by tsepez@chromium.org

11 edits in trunk

Cross-Origin copy&paste / drag&drop allowing XSS via srcdoc attribute.
https://bugs.webkit.org/show_bug.cgi?id=113443

Reviewed by Adam Barth.

Source/WebCore:

Tested by LayoutTests/editing/pasteboard/paste-noscript.html

dom/Element.h:

(Element):
(WebCore::Element::isHTMLContentAttribute):
Adds an isHTMLContentAttribute() method to determine whether an attribute can contain
(potentially unsafe) HTML content. Currently, the iframe's srcdoc attribute is the only
such attribute, but clever folks might add more in the future.
Rename stripJavaScriptAttributes() method to stripScriptingAttributes(), to better reflect
the reality that scripting content may appear as above.
Adds missing consts and consolidate isJavaScriptAttribute() method.

dom/Element.cpp:

(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::stripScriptingAttributes):
Consolidated methods.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isHTMLContentAttribute):
(WebCore):

html/HTMLFrameElementBase.h:

(HTMLFrameElementBase):
Indicate that for frames, the srcdoc attribute contains HTML content.

html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::setAttributes):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::setAttributes):
Rename stripJavaScriptAttribute calls to match Element.h

LayoutTests:

editing/pasteboard/paste-noscript-expected.txt:
editing/pasteboard/paste-noscript.html:

Adds a test that an iframe's srcdoc attribute is not pasted.

11:22 AM Changeset in webkit [147280] by tsepez@chromium.org

8 edits in trunk

View-source iframes are dangerous (and not very useful).
https://bugs.webkit.org/show_bug.cgi?id=113345

Reviewed by Adam Barth.

Source/WebCore:

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):
Conditionalize viewsource attribute on ENABLE(VIEWSOURCE_ATTRIBUTE).

Source/WebKit/chromium:

features.gypi:

Disable VIEWSOURCE_ATTRIBUTE for chromium.

Source/WTF:

wtf/FeatureDefines.h:

Default definition of ENABLE_VIEWSOURCE_ATTRIBUTE is enabled.

LayoutTests:

platform/chromium/TestExpectations:

Update expectations now that chromium excludes iframe's viewsource attribute.

6:08 AM Changeset in webkit [147279] by Philippe Normand

3 edits in trunk/Source/WebCore

[GTK] Should use GStreamer codec installation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=34085

Reviewed by Martin Robinson.

Initial support for the GStreamer codec installer. The player will
handle missing-plugins messages and use the pbutils codec
installer facilities to install the missing GStreamer
plugins. Once the plugins are installed reset the pipeline state.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mediaPlayerPrivatePluginInstallerResultFunction): This
method is used to notify the player that the missing plugins were installed.
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Ignore
errors while installing plugins and handle the missing-plugin message.
(WebCore::MediaPlayerPrivateGStreamer::handlePluginInstallerResult):
This method is invoked after the installer finished its task.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

3:41 AM Changeset in webkit [147278] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

g_slist_reverse() may not be required in webKitWebAudioSrcLoop
https://bugs.webkit.org/show_bug.cgi?id=113568

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-30
Reviewed by Philippe Normand.

Decremental 'for' loop logic implemented to avoid using g_slist_reverse().

Original code - 2.025230 micro seconds per loop
Original code + patch - 1.964759 micro seconds per loop

This patch is covered by existing webaudio tests.

platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

1:59 AM Changeset in webkit [147277] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Unreviewed buildfix after r147260.

WebProcess/qt/QtBuiltinBundlePage.cpp:

(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

1:34 AM Changeset in webkit [147276] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.
Desable the test (duplicate a rule from TestExpectations to override "webkit.org/b/90488 [ Debug ] inspector [ Slow ]").

inspector/console/console-css-warnings-expected.txt:
platform/chromium/TestExpectations:

1:24 AM Changeset in webkit [147275] by commit-queue@webkit.org

14 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-30
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

inspector/front-end/breakpointsList.css:
inspector/front-end/dataGrid.css:

(.data-grid):
(.data-grid table):
(.data-grid td):
(.data-grid th.sort-ascending > div::after):
(.data-grid th.sort-descending > div::after):
(.data-grid button):

inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):

inspector/front-end/inspector.css:

(.toolbar-item):
(.toolbar-label):
(.console-message .bubble):
(.outline-disclosure > ol):
(.source-code):
(.scope-bar li):
(.sidebar-tree, .sidebar-tree .children):
(.sidebar-tree-section):
(li .status .bubble):
(.sidebar-tree-item.selected):
(.sidebar-tree-item .titles):
(.sidebar-tree-item .subtitle):
(.sidebar-tree-item.selected .subtitle):
(.source-frame-breakpoint-message):
(.soft-context-menu):

inspector/front-end/inspectorCommon.css:

(body):
(.resources-divider-label):

inspector/front-end/navigatorView.css:

(.navigator li):
(.navigator li.selected .selection):
(.navigator .base-navigator-tree-element-title):

inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):
(.network-log-grid.data-grid th):
(.network-log-grid.data-grid select):
(.network-graph-label):
(.network-timeline-grid .resources-divider-label):
(.network-log-grid.data-grid .network-summary-bar td):

inspector/front-end/resourcesPanel.css:

(.resources.panel .sidebar li):
(.resources.panel .sidebar li.selected):
(.resources.panel .sidebar li.selected .selection):

inspector/front-end/sidebarPane.css:

(.sidebar-pane > .body .info):
(.sidebar-pane-title):
(.sidebar-pane-toolbar):
(.sidebar-pane-subtitle):

inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):
(select.tabbed-pane-header-tabs-drop-down-select):

inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

1:14 AM Changeset in webkit [147274] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Remove resource-har-conversion.html from TestExpectation
https://bugs.webkit.org/show_bug.cgi?id=113586

Unreviewed, EFL gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-30

platform/efl/TestExpectations: Rebaseline after r147219.

Mar 29, 2013:

10:20 PM Changeset in webkit [147273] by pfeldman@chromium.org

1 edit in branches/chromium/1453/Source/WebCore/inspector/front-end/timelinePanel.css

Merge 146849 "Web Inspector: [Timeline] Records sidebar is clipped."
BUG=222683

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

inspector/front-end/timelinePanel.css:
(.timeline .sidebar): Make "bottom" value "important".

TBR=eustas@chromium.org
Review URL: https://codereview.chromium.org/13383002

10:12 PM Changeset in webkit [147272] by pfeldman@chromium.org

4 edits in branches/chromium/1453

Merge 147028 "REGRESSION (r146588): Cannot correctly display Chi..."
BUG=223503

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

css/CSSGrammar.y.in:
css/CSSParser.cpp:
(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

TestExpectations:
fast/css/parsing-error-recovery.html:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13382002

9:51 PM Changeset in webkit [147271] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, release mode build fix.

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):

9:41 PM Changeset in webkit [147270] by fpizlo@apple.com

2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Change DO_NOT_INCLUDE_LLVM_CPP_HEADERS to LLVM_DO_NOT_INCLUDE_CPP_HEADERS
https://bugs.webkit.org/show_bug.cgi?id=113634

Reviewed by Dan Bernstein.

ftl/FTLLLVMHeaders.h:

9:15 PM Changeset in webkit [147269] by fpizlo@apple.com

3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Reviewed by Geoffrey Garen.

I forgot to make a couple of the requested review changes, so I'm making
them now!

ftl/FTLCompile.cpp:

(JSC::FTL::compile):

ftl/FTLJITCode.h:

7:54 PM Changeset in webkit [147268] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[EFL] Unreviewed build fix after r147251
https://bugs.webkit.org/show_bug.cgi?id=113631

Unreviewed build fix.

Add NETWORK_PROCESS guard.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29

UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

7:08 PM Changeset in webkit [147267] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r147263.
http://trac.webkit.org/changeset/147263
https://bugs.webkit.org/show_bug.cgi?id=113632

Breaks test fast/loader/display-image-unset-allows-cached-
image-load.html (Requested by mlam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime):

6:49 PM Changeset in webkit [147266] by roger_fong@apple.com

3 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

5:51 PM Changeset in webkit [147265] by commit-queue@webkit.org

5 edits
2 adds in trunk/Source/WebCore

When releasing a CGImage, we should also remove it from the subimage cache.
https://bugs.webkit.org/show_bug.cgi?id=102453

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-29
Reviewed by Simon Fraser.

When we release an image(CGImageRef) from BitmapImage's cachedFrames, if the image was already
cached in subimage cache, it's ref count won't drop to 0 and the image won't be deleted. Usually,
the subimage cache will clear the whole cache in a timer with 1 sec delay. However, if WebCore has
to paint another subimage (not necessarily from the same CGImageRef) before this timer fires, we
will restart the timer and images inside the cache will stay longer than they should.

This patch does two things:

move SubimageCacheWithTimer and related helper struct into a separate file.
remove the image from subimage cache when we releasing the CGImageRef, this prevent subimage

cache holding the image after we released it.

No new tests, manually verified the CGImageRef is also removed from subimage cache
when we releasing the image from FrameData::clear.

WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::FrameData::clear): remove the image from subimage cache before we releasing it.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore):
(WebCore::GraphicsContext::drawNativeImage):

platform/graphics/cg/SubimageCacheWithTimer.cpp: Added.

(WebCore):
(SubimageRequest):
(WebCore::SubimageRequest::SubimageRequest):
(WebCore::SubimageCacheAdder::hash):
(SubimageCacheAdder):
(WebCore::SubimageCacheAdder::equal):
(WebCore::SubimageCacheAdder::translate):
(WebCore::SubimageCacheWithTimer::SubimageCacheWithTimer):
(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):
(WebCore::SubimageCacheWithTimer::getSubimage):
(WebCore::SubimageCacheWithTimer::clearImage):
(WebCore::subimageCache):

platform/graphics/cg/SubimageCacheWithTimer.h: Added.

(WebCore):
(SubimageCacheWithTimer): Added a data member m_images to record which image and its subimages are cached.
(SubimageCacheEntry):
(SubimageCacheEntryTraits):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isEmptyValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::constructDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheEntryTraits::isDeletedValue):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::hash):
(WebCore::SubimageCacheWithTimer::SubimageCacheHash::equal):
(SubimageCacheHash):

5:19 PM Changeset in webkit [147264] by fpizlo@apple.com

4 edits
2 adds in branches/dfgFourthTier

fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
https://bugs.webkit.org/show_bug.cgi?id=113452

Rubber stamped by Mark Hahnenberg.

Tools:

Scripts/copy-webkitlibraries-to-product-directory:
Scripts/export-llvm-build:

WebKitLibraries:

LLVMIncludesMountainLion.tar.bz2: Added.
LLVMLibrariesMountainLion.tar.bz2: Added.

5:04 PM Changeset in webkit [147263] by aestes@apple.com

2 edits in trunk/Source/WebCore

Let cached resources from file: schemes expire immediately
https://bugs.webkit.org/show_bug.cgi?id=113626

Reviewed by Brady Eidson

When a CachedResource was loaded from a file: URL, we would give it an
indefinite freshness lifetime. This means that we would continue to
serve a stale resource from the memory cache even if the file was
changed on disk. With the introduction of main resource caching, this
behavior broke at least one third-party WebKit app (see <rdar://problem/13313769>).

We should instead let file resources expire immediately. Modern
filesystems implement their own caching, so we should get good
performance for multiple reads of unmodified files without doing our
own caching.

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::freshnessLifetime): file: URLs should have a
0 freshness lifetime.

4:41 PM Changeset in webkit [147262] by Lucas Forschler

4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147257. <rdar://problem/13531679>

4:32 PM Changeset in webkit [147261] by ojan@chromium.org

20 edits
2 deletes in trunk

Source/WebCore: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Disallow auto as a valid min-size value.

css/html.css:

(input::-webkit-datetime-edit):
(input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-slider-runnable-track):
Remove now unnecessary min-width: 0's.

css/mediaControlsChromium.css:

(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
Set a flex-shrink: 0 to avoid shrinking these items below the designated height.

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
Remove all the unneeded SizeType arguments now that we don't need to
specially handle MinSize in all these functions.

rendering/RenderBox.h:
rendering/RenderButton.cpp:

(WebCore::RenderButton::styleWillChange):
(WebCore::RenderButton::setupInnerStyle):
No longer need to explicitly set min-width:0.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Remove the code for specially handling auto.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::maxPageLogicalHeight):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
Remove all the now unneeded SizeType arguments.

rendering/style/RenderStyle.h:

Change the default min-size back to 0.

Source/WebKit2: Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Patch by Brady Eidson <beidson@apple.com> on 2013-03-29
Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::detachFromCoreLoader): Clear out the ResourceLoader pointer.
(WebKit::WebResourceLoader::willSendRequest): Protect this, and don't message back to the NetworkProcess if its not needed.
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace): Ditto
(WebKit::WebResourceLoader::didReceiveResource): Paranoid hardening - Protect this before delivering the data to the WebCore

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

WebProcess/Network/WebResourceLoader.h:

LayoutTests: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790

Reviewed by Tony Chang.

css3/flexbox/content-height-with-scrollbars.html:
css3/flexbox/cross-axis-scrollbar.html:

Set flex:none to avoid flex-shrinking.

css3/flexbox/flex-item-min-size-expected.txt: Removed.
css3/flexbox/flex-item-min-size.html: Removed.

These tests are now redundant with tests in fast/css-intrinsic-dimensions.

css3/flexbox/flexbox-baseline.html:

Set flex:none to avoid flex-shrinking.

css3/flexbox/line-wrapping.html:

Auto-size the flex items so that the column flexboxes have an auto-height.

css3/flexbox/preferred-widths.html:

Set flex:none to avoid flex-shrinking.

fast/css/auto-min-size-expected.txt:
fast/css/auto-min-size.html:

Update to no longer allow parsing auto as a valid value for min-width/min-height.

4:30 PM Changeset in webkit [147260] by ap@apple.com

15 edits in trunk

Expose FeatureObserver data to WebKit clients
https://bugs.webkit.org/show_bug.cgi?id=113613

Reviewed by Sam Weinig.

FeatureObserver used to depend on chromium-only HistogramSupport, which is not
really usable on Mac at least.

Instead of adding parallel feature reporting machinery, I'm adding a way to
generically relay the data from FeatureObserver to port code.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::reportMemoryUsage):
loader/FrameLoader.h: (WebCore::FrameLoader::previousURL): Exposed m_previousURL, renaming it to follow WebKit style.

page/FeatureObserver.cpp: (WebCore::FeatureObserver::~FeatureObserver): (WebCore::FeatureObserver::updateMeasurements):
page/FeatureObserver.h: (WebCore::FeatureObserver::accumulatedFeatureBits): Exposed the data to clients, and made reporting through HistogramSupport chromium only for clarity.

4:28 PM Changeset in webkit [147259] by fpizlo@apple.com

16 edits
14 adds in branches/dfgFourthTier

fourthTier: FTL JIT should be able run some simple function
https://bugs.webkit.org/show_bug.cgi?id=113481

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This is the initial version of the FTL JIT (Fourth Tier LLVM JIT).
It includes a lowering from the DFG IR to LLVM IR (FTL::lowerDFGToLLVM)
and a "backend" step that invokes the LLVM and wraps the resulting
function in a thunk (FTL::compile).

All LLVM IR building functions are wrapped up into a nicer FTL API.
First they're wrapped in an abbreviated API (FTLAbbreviations.h) and
then again into an object-oriented IR builder (FTLOutput.h).

This runs things. I don't know how fast it runs things. And I don't
make any claims of stability. The FTL is runtime-disabled by default;
you will enable it by doing --useExperimentalFTL=true. Probably if you
do this, you will run slower, because of the heavy thunking we do, the
fact that we don't have anything resembling a sensible tiering story,
and because we only compile ridiculously tiny functions.

Finally, this still requires a custom set of LLVM headers to build.
I am working on getting that up-streamed to LLVM, and separately I'll
make sure that we have a build checked into this branch.

Configurations/JavaScriptCore.xcconfig:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Operands.h:

(Operands):
(JSC::Operands::Operands):

dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::needsTypeCheck):
(AbstractState):
(JSC::DFG::AbstractState::filterEdgeByUse):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::needsTypeCheck):
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):

dfg/DFGUseKind.h:

(JSC::DFG::shouldNotHaveTypeCheck):
(DFG):
(JSC::DFG::mayHaveTypeCheck):
(JSC::DFG::isDouble):
(JSC::DFG::isCell):

ftl: Added.
ftl/FTLAbbreviations.h: Added.

(FTL):
(JSC::FTL::int1Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::pointerType):
(JSC::FTL::getParam):
(JSC::FTL::constInt):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildAlloca):
(JSC::FTL::buildAdd):
(JSC::FTL::buildAnd):
(JSC::FTL::buildXor):
(JSC::FTL::buildLoad):
(JSC::FTL::buildStore):
(JSC::FTL::buildZExt):
(JSC::FTL::buildIntCast):
(JSC::FTL::buildIntToPtr):
(JSC::FTL::buildPtrToInt):
(JSC::FTL::buildICmp):
(JSC::FTL::buildSelect):
(JSC::FTL::buildBr):
(JSC::FTL::buildCondBr):
(JSC::FTL::buildRet):
(JSC::FTL::buildUnreachable):

ftl/FTLCapabilities.cpp: Added.

(FTL):
(JSC::FTL::canCompile):

ftl/FTLCapabilities.h: Added.

(FTL):

ftl/FTLCompile.cpp: Added.

(FTL):
(JSC::FTL::compileEntry):
(JSC::FTL::compile):

ftl/FTLCompile.h: Added.

(FTL):

ftl/FTLJITCode.cpp: Added.

(FTL):
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addressForCall):
(JSC::FTL::JITCode::executableAddressAtOffset):
(JSC::FTL::JITCode::dataAddressAtOffset):
(JSC::FTL::JITCode::offsetOf):
(JSC::FTL::JITCode::size):
(JSC::FTL::JITCode::contains):

ftl/FTLJITCode.h: Added.

(FTL):
(JITCode):

ftl/FTLLLVMHeaders.h: Added.
ftl/FTLLowerDFGToLLVM.cpp: Added.

(FTL):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOpRoots):
(JSC::FTL::LowerDFGToLLVM::closeOverFlushedLocalOps):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalOp):
(JSC::FTL::LowerDFGToLLVM::addFlushedLocalEdge):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compilePhantom):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::checkNotInt32):
(JSC::FTL::LowerDFGToLLVM::unboxInt32):
(JSC::FTL::LowerDFGToLLVM::boxInt32):
(JSC::FTL::LowerDFGToLLVM::checkNotCell):
(JSC::FTL::LowerDFGToLLVM::checkNotBoolean):
(JSC::FTL::LowerDFGToLLVM::unboxBoolean):
(JSC::FTL::LowerDFGToLLVM::boxBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateInt32):
(JSC::FTL::LowerDFGToLLVM::addressFor):
(JSC::FTL::LowerDFGToLLVM::payloadFor):
(JSC::FTL::LowerDFGToLLVM::tagFor):
(JSC::FTL::LowerDFGToLLVM::globalData):
(JSC::FTL::LowerDFGToLLVM::codeBlock):
(JSC::FTL::lowerDFGToLLVM):

ftl/FTLLowerDFGToLLVM.h: Added.

(FTL):

ftl/FTLOutput.h: Added.

(FTL):
(Output):
(JSC::FTL::Output::Output):
(JSC::FTL::Output::~Output):
(JSC::FTL::Output::initialize):
(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::param):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::add):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intCast):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::get):
(JSC::FTL::Output::set):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::testNonZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):

ftl/FTLState.h: Added.

(FTL):
(State):
(JSC::FTL::State::State):

runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

runtime/Options.h:

(JSC):

Source/WTF:

Reviewed by Geoffrey Garen.

wtf/Platform.h:

Tools:

Reviewed by Geoffrey Garen.

Give the scripts the ability to find an LLVM build and use it.

Also added a script, export-llvm-build, that allows you to take your
own build of LLVM and package it for use by WebKit's build system.

The build system treats a "build" of LLVM as a pair of .tar.bz2's,
one for the library archives and one for the headers. It then unpacks
them into your built products directory in a mannner that is mostly
analogous to how WebKitSystemInterface works.

Scripts/build-jsc:
Scripts/copy-webkitlibraries-to-product-directory:

(unpackIfNecessary):
(dittoHeaders):

Scripts/export-llvm-build: Added.

4:24 PM Changeset in webkit [147258] by dgrogan@chromium.org

1 edit in branches/chromium/1453/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 146950 "IndexedDB: Histogram cause of LevelDB write errors"

IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

platform/leveldb/LevelDBDatabase.cpp:
(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/13171005

4:02 PM Changeset in webkit [147257] by beidson@apple.com

4 edits in trunk/Source/WebKit2

Crash when "willSendRequest" causes the ResourceLoader to be cancelled.
<rdar://problem/13531679> and https://bugs.webkit.org/show_bug.cgi?id=113616

Reviewed by Alexey Proskuryakov.

These callbacks to the WebCore ResourceLoader can cause the WebResourceLoader to be destroyed.
A RefPtr<> protector fixes that.

Additionally we can invalidate the WebResourceLoader to avoid unnecessary callbacks to the NetworkProcess.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Call detachFromCoreLoader() on a removed WebResourceLoader.

WebProcess/Network/WebResourceLoader.cpp:

ResourceLoader, and null check it before delivering the "didFinishLoader" call.

WebProcess/Network/WebResourceLoader.h:

3:32 PM Changeset in webkit [147256] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r191432. Requested by
"Philip Rogers" <pdr@google.com> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

DEPS:

3:18 PM Changeset in webkit [147255] by acolwell@chromium.org

1 edit
4 adds in trunk/LayoutTests

Add LayoutTests that verify MediaSource.duration behavior.
https://bugs.webkit.org/show_bug.cgi?id=113438

Reviewed by Eric Carlson.

http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Added.
http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Added.
http/tests/media/media-source/video-media-source-duration-expected.txt: Added.
http/tests/media/media-source/video-media-source-duration.html: Added.

3:10 PM Changeset in webkit [147254] by jsbell@chromium.org

4 edits in trunk/LayoutTests

[Chromium] IndexedDB: Update terminated worker connection test
https://bugs.webkit.org/show_bug.cgi?id=113608

Reviewed by Tony Chang.

Update layout test only run under Chromium's content_shell that ensures that
worker termination does not result in stuck connections. The test was using
the obsolete setVersion() API.

storage/indexeddb/pending-version-change-stuck-works-with-terminate-expected.txt:
storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:
storage/indexeddb/resources/pending-version-change-stuck.js:

(test.request.onblocked):
(test):

2:56 PM Changeset in webkit [147253] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Should never send events to plugins waiting on asynchronous initialization.
<rdar://problem/13538945> and https://bugs.webkit.org/show_bug.cgi?id=113612

Reviewed by Anders Carlsson.

Sending mouse and keyboard events to a plugin in the middle of asynchronous initialization is silly.

A quick audit of the sendSync() messages in PluginProxy suggests the following 8 can just have an early return:

WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::handleMouseEvent):
(WebKit::PluginProxy::handleWheelEvent):
(WebKit::PluginProxy::handleMouseEnterEvent):
(WebKit::PluginProxy::handleMouseLeaveEvent):
(WebKit::PluginProxy::handleKeyboardEvent):
(WebKit::PluginProxy::handleEditingCommand):
(WebKit::PluginProxy::isEditingCommandEnabled):
(WebKit::PluginProxy::handlesPageScaleFactor):

2:37 PM Changeset in webkit [147252] by mhahnenberg@apple.com

5 edits in trunk/Source/JavaScriptCore

Objective-C API: Remove -[JSManagedValue managedValueWithValue:owner:]
https://bugs.webkit.org/show_bug.cgi?id=113602

Reviewed by Geoffrey Garen.

Since we put the primary way of keeping track of external object graphs (i.e. "managed" references)
in JSVirtualMachine, there is some overlap in the functionality of that interface and JSManagedValue.
Specifically, we no longer need the methods that include an owner, since ownership is now tracked
by JSVirtualMachine. These JSManagedValues will become weak pointers unless they are used
with [JSVirtualMachine addManagedReference:withOwner:], in which case their lifetime is tied to that
of their owner.

API/JSManagedValue.h:
API/JSManagedValue.mm:

(-[JSManagedValue init]):
(-[JSManagedValue initWithValue:]):
(JSManagedValueHandleOwner::isReachableFromOpaqueRoots):

API/JSVirtualMachine.mm:

(getInternalObjcObject):

API/tests/testapi.mm:

(-[TextXYZ setOnclick:]):
(-[TextXYZ dealloc]):

2:32 PM Changeset in webkit [147251] by beidson@apple.com

7 edits in trunk/Source/WebKit2

"Empty cache..." clears the disk cache from each WebProcess.
<rdar://problem/12456652> and https://bugs.webkit.org/show_bug.cgi?id=113603

Reviewed by Sam Weinig.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::terminate): Override ChildProcess::terminate to allow us to finish clearing the cache.

NetworkProcess/NetworkProcess.h:

NetworkProcess/NetworkProcess.messages.in: Add the ClearCacheForAllOrigins message.

NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::clearCacheForAllOrigins): Clear the disk cache.
(WebKit::NetworkProcess::platformTerminate): Wait for the clear to complete.

UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins): Message the network process, also.

WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformClearResourceCaches): Don't clear the disk cache if we use the network process.

2:13 PM Changeset in webkit [147250] by commit-queue@webkit.org

5 edits
2 adds in trunk

[CSS Exclusions] shape outside segments not properly calculated for ellipses
https://bugs.webkit.org/show_bug.cgi?id=112587

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-29
Reviewed by Julien Chaffraix.

Source/WebCore:

When converting the line top coordinates from the parent's coordinate
space to the coordinate space of the float, the offset given by the
shape was not being accounted for. This patch accounts for that
offset.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftOffsetForLine): Fix the coordinate conversion.
(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.

rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Ditto.

LayoutTests:

Check that shapes with a non-zero y value are properly wrapped.

fast/exclusions/shape-outside-floats/shape-outside-floats-non-zero-y.html: Added.
fast/exclusions/resources/rounded-rectangle.js:

(generateSimulatedShapeOutsideOnFloat): For simulating, we ignore the
x and y values, since we're not attempting to draw the float's content
in the right place, we just want to simulate the shape's effect.

1:34 PM Changeset in webkit [147249] by hmuller@adobe.com

4 edits
4 adds in trunk

[CSS Exclusions] Incorrect margin corner radii formula
https://bugs.webkit.org/show_bug.cgi?id=111186

Reviewed by Dirk Schulze.

Source/WebCore:

Corrected an error in the forumla for the margin ellipse's radii.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html

rendering/ExclusionRectangle.cpp:

(WebCore::FloatRoundedRect::marginBounds):

LayoutTests:

fast/exclusions/resources/subpixel-utils.js:

(SubPixelLayout): Added an initSubPixelLayout() function so that inline test code doesn't have to wait until the DOMContentLoaded event.

fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left-expected.txt: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right-expected.txt: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html: Added.

1:26 PM Changeset in webkit [147248] by Lucas Forschler

4 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147179. <rdar://problem/13479890>

1:24 PM Changeset in webkit [147247] by Lucas Forschler

2 edits in tags/Safari-537.35.4/Source/WebKit2

Merged r147010. <rdar://problem/13479890>

1:22 PM Changeset in webkit [147246] by Lucas Forschler

5 edits
2 copies in tags/Safari-537.35.4/Source/WebKit2

Merged r147006. <rdar://problem/13479890>

1:12 PM Changeset in webkit [147245] by ojan@chromium.org

13 edits
2 adds in trunk

min-width/max-width of min-content/max-content don't work correctly if width is specified
https://bugs.webkit.org/show_bug.cgi?id=106143

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
Expose this so that we don't use the preferred widths when calculating intrinsic width
values since the preferred width will be the regular width value if it is set.
Also, simplified the logic around table cells and scrollbar widths. The old code was
wrong and unnecessarily complicated.

(WebCore::RenderBlock::computePreferredLogicalWidths):
Use the new computeIntrinsicLogicalWidths method.

(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Pass in the min/max values as out params so they can be called from computeIntrinsicLogicalWidths.
Also, make computeBlockPreferredLogicalWidths const.

rendering/RenderBlock.h:

LayoutTests:

css3/flexbox/box-sizing.html:

The old result was incorrectly using the preferred width as the min-content width of the flex items.
The new result is correctly resolving the min-content width to 0 and allowing the flex items to shrink.

fast/css-intrinsic-dimensions/intrinsic-sized-blocks-expected.txt: Added.
fast/css-intrinsic-dimensions/intrinsic-sized-blocks.html: Added.
platform/chromium-win/fast/table/overflowHidden-expected.txt:

The new result correctly adds the scrollbar width to the table cell intrinsic width.
The pixel result doesn't need ot be updated because the elements that changed are below
the fold, so they don't show up in the png.

platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

Add tests that will need rebaselines.

scrollbars/custom-scrollbar-table-cell-expected.png:

The new result correctly adds the scrollbar width to the table cell intrinsic width.

12:56 PM Changeset in webkit [147244] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Use WTF::TemporaryChange rather than manually resetting a flag
https://bugs.webkit.org/show_bug.cgi?id=113594

Reviewed by Tony Chang.

Split out from another patch: rather than m_foo = true; ... m_foo = false; use
the handy WTF::TemporaryChange scoped variable change doohickey.

Test: http/tests/inspector/indexeddb/database-structure.html

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::close):

12:51 PM Changeset in webkit [147243] by timothy@apple.com

2 edits in trunk/LayoutTests

Marking animation-delay-changed.html and reinserting-svg-into-document.html as flaky.

https://webkit.org/b/113598
https://webkit.org/b/113599

Unreviewed.

platform/mac/TestExpectations:

12:49 PM Changeset in webkit [147242] by Lucas Forschler

21 edits in tags/Safari-537.35.4/Source

Merged r146544. <rdar://problem/13479890>

12:36 PM Changeset in webkit [147241] by jsbell@chromium.org

3 edits
2 adds in trunk

[V8] IndexedDB: Exceptions thrown inconsistently for non-cloneable values
https://bugs.webkit.org/show_bug.cgi?id=113091

Reviewed by Kentaro Hara.

Source/WebCore:

The exception thrown by SerializedScriptValue into the JS engine is not
observable by ScriptState. (We should fix that, but it appears non-trivial.)
Ask the SerializedScriptValue directly if it failed to clone. If so, don't
set an exception - one was already set so let that be processed normally.

Test: storage/indexeddb/clone-exception.html

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::put):

LayoutTests:

storage/indexeddb/clone-exception-expected.txt: Added.
storage/indexeddb/clone-exception.html: Added.

12:31 PM Changeset in webkit [147240] by dino@apple.com

3 edits in trunk/Source/WebCore

Snapshotted plugins must be able to restart on appropriate mouseup events
https://bugs.webkit.org/show_bug.cgi?id=113577

Reviewed by Tim Horton.

If the page content prevents the default behaviour of a mousedown event, then a snapshotted
plugin would never receive a click event, and thus be unable to restart. We have to also
look for a mouseup that happens with an associated mousedown, and trigger restart. This
won't call any page code - it's just behind the scenes.

rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Initialize new member variable.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Track the state of mousedown and up pairs, and restart

if you see an appropriate mouseup.

rendering/RenderSnapshottedPlugIn.h: New member variable to track mouse state.

12:27 PM Changeset in webkit [147239] by Martin Robinson

110 edits
853 adds in trunk/Source/ThirdParty

Update the version of gyp in the repository
https://bugs.webkit.org/show_bug.cgi?id=113540

Reviewed by Nico Weber.

gyp: Update gyp to r1605.

12:26 PM Changeset in webkit [147238] by Simon Fraser

2 edits in trunk/Source/WebCore

removeViewportConstrainedLayer() should remove the layer from m_viewportConstrainedLayersNeedingUpdate too
https://bugs.webkit.org/show_bug.cgi?id=113596

Reviewed by Tim Horton.

It's possible, with some combination of position:fixed and opacity transitions
in iframes, to end up with a RenderLayer in m_viewportConstrainedLayersNeedingUpdate
that has been removed from m_viewportConstrainedLayers, which leads to later assertions
and/or crashes.

Fix by removing a layer from m_viewportConstrainedLayersNeedingUpdate when we
remove it from m_viewportConstrainedLayers.

I was not able to come up with a testcase that reliably reproduces this.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::removeViewportConstrainedLayer):

12:22 PM Changeset in webkit [147237] by Lucas Forschler

19 edits in tags/Safari-537.35.4

Merged r146704. <rdar://problem/13337564>

12:14 PM Changeset in webkit [147236] by commit-queue@webkit.org

20 edits in trunk

Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
https://bugs.webkit.org/show_bug.cgi?id=112276

Patch by Greg Hughes <ghughes@apple.com> on 2013-03-29
Reviewed by Chris Fleizach.

Source/WebCore:

Added support for accessibility search predicates to accept multiple search keys. The search will return the first item that matches any one of the provided search keys.

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex):
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch):
(WebCore):

accessibility/AccessibilityObject.h:

(AccessibilitySearchCriteria):
(WebCore::AccessibilitySearchCriteria::AccessibilitySearchCriteria):
(AccessibilityObject):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

Tools:

Added support to test accessibility search predicates with multiple keys.

DumpRenderTree/AccessibilityUIElement.cpp:

(uiElementForSearchPredicateCallback):

DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::uiElementForSearchPredicate):

DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::uiElementForSearchPredicate):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::uiElementForSearchPredicate):

LayoutTests:

Updated the search predicate test to test passing multiple search keys (link OR heading).

platform/mac/accessibility/search-predicate-expected.txt:
platform/mac/accessibility/search-predicate.html:

12:13 PM Changeset in webkit [147235] by Lucas Forschler

4 edits in tags/Safari-537.35.4/Source

Versioning.

12:12 PM Changeset in webkit [147234] by ggaren@apple.com

5 edits in trunk/Source/JavaScriptCore

Simplified bytecode generation by unforking "condition context" codegen
https://bugs.webkit.org/show_bug.cgi?id=113554

Reviewed by Mark Hahnenberg.

Now, a node that establishes a condition context can always ask its child
nodes to generate into that context.

This has a few advantages:

(*) Removes a bunch of code;

(*) Optimizes a few missed cases like "if (!(x < 2))", "if (!!x)", and

"if (!x

!y)";

(*) Paves the way to removing more opcodes.

bytecode/Opcode.h:

(JSC): Separated out the branching opcodes for clarity.

bytecompiler/NodesCodegen.cpp:

(JSC::ExpressionNode::emitBytecodeInConditionContext): All expressions
can be emitted in a condition context now -- the default behavior is
to branch based on the expression's value.

(JSC::LogicalNotNode::emitBytecodeInConditionContext):
(JSC::LogicalOpNode::emitBytecodeInConditionContext):
(JSC::ConditionalNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):

parser/Nodes.h:

(JSC::ExpressionNode::isSubtract):
(ExpressionNode):
(LogicalNotNode):
(LogicalOpNode): Removed lots of code for handling expressions
that couldn't generate into a condition context because all expressions
can now.

12:12 PM Changeset in webkit [147233] by jsbell@chromium.org

7 edits in trunk/Source

IndexedDB: Bind lifetime of in-memory backing stores to IDBFactory backend
https://bugs.webkit.org/show_bug.cgi?id=110820

Reviewed by Tony Chang.

Source/WebCore:

Backing stores are dropped as soon as all connections are closed. That makes sense for
disk-backed stores to free up memory (although there's a performance trade-off...). But
for memory-backed stores, the expected lifetime should match the lifetime of the factory
so that an open/write/close/re-open/read yields the written data.

Test: Chromium's webkit_unit_tests, IDBFactoryBackendTest.MemoryBackingStoreLifetime

Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::IDBBackingStore): Pass comparator into constructor since it was always
assigned immediately afterwards anyway.
(WebCore::IDBBackingStore::open): Split into three parts - open() which is disk-backed...
(WebCore::IDBBackingStore::openInMemory): ...explit in-memory creation (previously: specified by empty path)
(WebCore::IDBBackingStore::create): ... and the common logic which calls the constructor.

Modules/indexeddb/IDBBackingStore.h: Headers for the above.
Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::openBackingStore): Add in-memory backing stores to dependent set.

Modules/indexeddb/IDBFactoryBackendImpl.h: Add member to track dependent backing stores.

Source/WebKit/chromium:

tests/IDBBackingStoreTest.cpp:

(WebCore::IDBBackingStoreTest::SetUp): Use openInMemory rather than empty path.
(WebCore::TEST): Added IDBFactoryBackendTest.MemoryBackingStoreLifetime to verify refs.

11:54 AM Changeset in webkit [147232] by timothy@apple.com

2 edits in trunk/LayoutTests

Mark fast/workers/worker-close-more.html, worker-document-leak.html and
worker-lifecycle.html as flaky on Windows.

http://webkit.org/b/106415

Unreviewed.

platform/win/TestExpectations:

11:52 AM Changeset in webkit [147231] by roger_fong@apple.com

2 edits in trunk/WebKitLibraries

Unreviewed. Rollout r146818.

win/tools/vsprops/FeatureDefines.props:

11:49 AM Changeset in webkit [147230] by timothy@apple.com

2 edits in trunk/LayoutTests

Mark inspector/debugger/debugger-scripts-reload.html as flaky.

http://webkit.org/b/113589

Unreviewed.

platform/mac/TestExpectations:

11:40 AM Changeset in webkit [147229] by Lucas Forschler

1 copy in tags/Safari-537.35.4

New Tag.

11:10 AM Changeset in webkit [147228] by Nate Chapin

3 edits
2 adds in trunk

ASSERT d->m_defersLoading != defers on detik.com and drive.google.com
https://bugs.webkit.org/show_bug.cgi?id=111902

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/navigation/same-url-iframes-defer-crash.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setDefersLoading): If multiple DocumentLoaders are

using loading the same main resource, ensure only one of them can call
ResourceLoader::setDefersLoading.

LayoutTests:

http/tests/navigation/same-url-iframes-defer-crash-expected.txt: Added.
http/tests/navigation/same-url-iframes-defer-crash.html: Added.

10:24 AM Changeset in webkit [147227] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Content should not be lost when uiSourceCode's file was removed externally on file system.
https://bugs.webkit.org/show_bug.cgi?id=113581

Reviewed by Pavel Feldman.

inspector/front-end/IsolatedFileSystem.js:

(WebInspector.IsolatedFileSystem.prototype.errorHandler):
(WebInspector.IsolatedFileSystem.prototype.requestFileContent):
(WebInspector.IsolatedFileSystem.prototype.fileSystemLoaded):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.checkContentUpdated.contentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
(WebInspector.UISourceCode.prototype._commitContent):

10:06 AM Changeset in webkit [147226] by vsevik@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Prompt before closing dirty tab.
https://bugs.webkit.org/show_bug.cgi?id=113576

Reviewed by Pavel Feldman.

inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._maybeCloseTab):
(WebInspector.TabbedEditorContainer.prototype._closeTabs):
(WebInspector.EditorContainerTabDelegate):
(WebInspector.EditorContainerTabDelegate.prototype.closeTabs):

inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPane.prototype.setTabDelegate):
(WebInspector.TabbedPane.prototype.appendTab):
(WebInspector.TabbedPane.prototype.allTabs):
(WebInspector.TabbedPane.prototype.otherTabs):
(WebInspector.TabbedPaneTab.prototype.setDelegate):
(WebInspector.TabbedPaneTab.prototype._tabClicked):
(WebInspector.TabbedPaneTab.prototype._closeTabs):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeOthers):
(WebInspector.TabbedPaneTab.prototype._tabContextMenu.closeAll):
(WebInspector.TabbedPaneTabDelegate):
(WebInspector.TabbedPaneTabDelegate.prototype.closeTabs):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.resetWorkingCopy):

9:59 AM Changeset in webkit [147225] by rniwa@webkit.org

2 edits in trunk/Tools

Fix a typo in r147147 to fix Mac EWS.

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):

9:47 AM Changeset in webkit [147224] by loislo@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Remove hopping ancorElement and use anchorBox instead.
https://bugs.webkit.org/show_bug.cgi?id=113579

Reviewed by Pavel Feldman.

Initially I made a fake anchor element and moved it according to the highlighted element position.
It was a hack and after http://trac.webkit.org/changeset/147209 I'm able to remove it.

Drive by fix: the code was moved from onMouseMove to getPopoverAnchor.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
-(WebInspector.FlameChart.prototype._onMouseMove)

inspector/front-end/flameChart.css:

9:37 AM Changeset in webkit [147223] by zarvai@inf.u-szeged.hu

41 edits
16 copies
5 moves
128 adds
21 deletes in trunk/LayoutTests

[Qt] Unreviewed gardneing. Updated png expected results after r146206.

platform/qt-5.0-wk2/compositing/color-matching/image-color-matching-expected.png:
platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-expected.png:
platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
platform/qt-5.0-wk2/compositing/culling/scrolled-within-boxshadow-expected.png:
platform/qt-5.0-wk2/compositing/culling/translated-boxshadow-expected.png:
platform/qt-5.0-wk2/compositing/culling/unscrolled-within-boxshadow-expected.png:
platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
platform/qt-5.0-wk2/compositing/flat-with-transformed-child-expected.png: Removed.
platform/qt-5.0-wk2/compositing/generated-content-expected.png: Added.
platform/qt-5.0-wk2/compositing/geometry/abs-position-inside-opacity-expected.png: Added.
platform/qt-5.0-wk2/compositing/geometry/clipping-foreground-expected.png: Added.
platform/qt-5.0-wk2/compositing/geometry/foreground-layer-expected.png:
platform/qt-5.0-wk2/compositing/geometry/root-layer-update-expected.png: Added.
platform/qt-5.0-wk2/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png: Added.
platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
platform/qt-5.0-wk2/compositing/iframes/composited-iframe-alignment-expected.png: Added.
platform/qt-5.0-wk2/compositing/iframes/nested-iframe-scrolling-expected.png:
platform/qt-5.0-wk2/compositing/masks/direct-image-mask-expected.png: Added.
platform/qt-5.0-wk2/compositing/masks/mask-of-clipped-layer-expected.png:
platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
platform/qt-5.0-wk2/compositing/overflow/overflow-compositing-descendant-expected.png: Added.
platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Removed.
platform/qt-5.0-wk2/compositing/overflow/scroll-ancestor-update-expected.png: Removed.
platform/qt-5.0-wk2/compositing/overflow/zero-size-overflow-expected.png:
platform/qt-5.0-wk2/compositing/reflections/compositing-change-inside-reflection-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/nested-reflection-transformed2-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/reflection-opacity-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/reflection-ordering-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/reflection-positioning-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/reflection-positioning2-expected.png: Added.
platform/qt-5.0-wk2/compositing/reflections/simple-composited-reflections-expected.png: Added.
platform/qt-5.0-wk2/compositing/repaint/become-overlay-composited-layer-expected.png: Added.
platform/qt-5.0-wk2/compositing/repaint/layer-repaint-rects-expected.png: Added.
platform/qt-5.0-wk2/compositing/repaint/newly-composited-repaint-rect-expected.png:
platform/qt-5.0-wk2/compositing/repaint/requires-backing-repaint-expected.png:
platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
platform/qt-5.0-wk2/compositing/self-painting-layers-expected.png: Removed.
platform/qt-5.0-wk2/compositing/sibling-positioning-expected.png: Added.
platform/qt-5.0-wk2/compositing/text-on-large-layer-expected.png: Added.
platform/qt-5.0-wk2/compositing/visibility/visibility-image-layers-expected.png: Added.
platform/qt-5.0-wk2/compositing/visibility/visibility-simple-video-layer-expected.png:
platform/qt-5.0-wk2/compositing/z-order/negative-z-index-expected.png:
platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-expected.png: Removed.
platform/qt-5.0-wk2/css3/compositing/effect-background-blend-mode-stacking-expected.png: Added.
platform/qt-5.0-wk2/css3/filters/composited-reflected-expected.png:
platform/qt-5.0-wk2/css3/filters/custom/custom-filter-clamp-css-color-matrix-expected.png:
platform/qt-5.0-wk2/css3/filters/custom/custom-filter-nonseparable-blend-mode-luminosity-expected.png:
platform/qt-5.0-wk2/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png:
platform/qt-5.0-wk2/editing/selection/5099303-expected.png:
platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png:
platform/qt-5.0-wk2/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
platform/qt-5.0-wk2/fast/backgrounds/size/zero-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
platform/qt-5.0-wk2/fast/canvas/canvas-as-image-incremental-repaint-expected.png: Added.
platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Removed.
platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Removed.
platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png: Added.
platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png: Added.
platform/qt-5.0-wk2/fast/multicol/float-paginate-empty-lines-expected.png: Added.
platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-multicol-expected.png: Removed.
platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png: Removed.
platform/qt-5.0-wk2/fast/reflections/inline-crash-expected.png: Removed.
platform/qt-5.0-wk2/fast/reflections/reflection-masks-expected.png: Added.
platform/qt-5.0-wk2/fast/reflections/reflection-masks-opacity-expected.png: Added.
platform/qt-5.0-wk2/fast/reflections/reflection-masks-outset-expected.png: Added.
platform/qt-5.0-wk2/fast/repaint/background-misaligned-expected.png: Added.
platform/qt-5.0-wk2/fast/repaint/block-layout-inline-children-replaced-expected.png: Added.
platform/qt-5.0-wk2/fast/repaint/line-flow-with-floats-in-regions-expected.png: Removed.
platform/qt-5.0-wk2/fast/repaint/scale-page-shrink-expected.png: Removed.
platform/qt-5.0-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png:
platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-row-border-width-expected.png:
platform/qt-5.0-wk2/fast/table/border-collapsing/cached-change-tbody-border-width-expected.png:
platform/qt-5.0-wk2/fast/text/font-initial-expected.png: Removed.
platform/qt-5.0-wk2/fast/text/whitespace/003-expected.png: Added.
platform/qt-5.0-wk2/fast/text/whitespace/006-expected.png: Added.
platform/qt-5.0-wk2/fast/text/whitespace/008-expected.png: Added.
platform/qt-5.0-wk2/fast/text/whitespace/009-expected.png: Added.
platform/qt-5.0-wk2/fast/text/whitespace/012-expected.png: Added.
platform/qt-5.0-wk2/fast/text/whitespace/013-expected.png:
platform/qt-5.0-wk2/fast/text/whitespace/014-expected.png:
platform/qt-5.0-wk2/fast/writing-mode/block-level-images-expected.png: Added.
platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png: Added.
platform/qt-5.0-wk2/scrollbars/listbox-scrollbar-combinations-expected.png: Added.
platform/qt-5.0-wk2/scrollbars/overflow-scrollbar-combinations-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png: Added.
platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-image-08-t-expected.png: Added.
platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2c-expected.png: Added.
platform/qt-5.0-wk2/svg/animations/animateMotion-additive-2d-expected.png: Added.
platform/qt-5.0-wk2/svg/as-background-image/svg-as-background-2-expected.png: Added.
platform/qt-5.0-wk2/svg/as-border-image/svg-as-border-image-expected.png: Added.
platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png: Removed.
platform/qt-5.0-wk2/svg/as-image/animated-svg-as-image-same-image-expected.png: Removed.
platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
platform/qt-5.0-wk2/svg/batik/filters/feTile-expected.png: Added.
platform/qt-5.0-wk2/svg/batik/text/textDecoration-expected.png: Added.
platform/qt-5.0-wk2/svg/batik/text/textFeatures-expected.png: Added.
platform/qt-5.0-wk2/svg/css/group-with-shadow-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/clip-mask-negative-scale-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/createImageElement-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/createImageElement2-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/image-parent-translation-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/image-rescale-clip-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/image-rescale-scroll-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/inline-svg-in-xhtml-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/js-update-image-and-display2-expected.png:
platform/qt-5.0-wk2/svg/custom/js-update-image-and-display3-expected.png:
platform/qt-5.0-wk2/svg/custom/js-update-image-expected.png:
platform/qt-5.0-wk2/svg/custom/massive-coordinates-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/pattern-in-defs-expected.png:
platform/qt-5.0-wk2/svg/custom/pattern-rotate-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/pointer-events-image-css-transform-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/pointer-events-image-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/text-image-opacity-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png: Added.
platform/qt-5.0-wk2/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr-expected.png: Removed.
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr-expected.png: Removed.
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-dom-in-attr-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETileElement-svgdom-in-prop-expected.png:
platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-svgdom-href1-prop-expected.png: Removed.
platform/qt-5.0-wk2/svg/filters/big-sized-filter-expected.png: Added.
platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
platform/qt-5.0-wk2/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png: Added.
platform/qt-5.0-wk2/svg/transforms/text-with-mask-with-svg-transform-expected.png: Removed.
platform/qt-5.0-wk2/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Removed.
platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png: Added.
platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image2-expected.png: Added.
platform/qt-5.0-wk2/svg/zoom/page/zoom-background-images-expected.png: Added.
platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png: Added.
platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug11026-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug1188-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug12910-2-expected.png:
platform/qt-5.0-wk2/tables/mozilla/bugs/bug1296-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug15544-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug2981-2-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug4093-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug4284-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug4427-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/bugs/bug97383-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla/core/misc-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/97619-expected.png: Added.
platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug6933-expected.png: Added.
platform/qt-5.0-wk2/transitions/cross-fade-border-image-expected.png: Added.

9:07 AM Changeset in webkit [147222] by commit-queue@webkit.org

9 edits
3 copies
1 add in trunk/Source

[EFL][EGL] Add support for creating offscreen surface.
https://bugs.webkit.org/show_bug.cgi?id=113359

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-29
Reviewed by Noam Rosenthal.

This is in preparation for enabling EGL and GLES2
support for EFL port. This patch adds support for using
EGLPixmapSurface as an offscreensurface.

PlatformEfl.cmake:
platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createOffScreenSurface):

platform/graphics/surfaces/efl/GLTransportSurface.cpp:

(WebCore::GLTransportSurface::createTransportSurface):

platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::pixmapContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):

platform/graphics/surfaces/egl/EGLConfigSelector.h:

(EGLConfigSelector):

Added logic to select EGLConfig supporting alpha and
opaque as needed. Moved Code related to display to
EGLHelper class.

platform/graphics/surfaces/egl/EGLHelper.cpp: Added.

(WebCore):
(EGLDisplayConnection):
(WebCore::EGLDisplayConnection::EGLDisplayConnection):
(WebCore::EGLDisplayConnection::~EGLDisplayConnection):
(WebCore::EGLDisplayConnection::display):
(WebCore::EGLDisplayConnection::terminate):
(WebCore::EGLHelper::eglDisplay):

platform/graphics/surfaces/egl/EGLHelper.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.

(WebCore):
(EGLHelper):

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLTransportSurface::createTransportSurface):
(WebCore::EGLTransportSurface::EGLTransportSurface):
(WebCore::EGLTransportSurface::attributes):
(WebCore::EGLTransportSurface::~EGLTransportSurface):
(WebCore::EGLTransportSurface::destroy):
(WebCore::EGLTransportSurface::configuration):
(WebCore::EGLOffScreenSurface::createOffScreenSurface):
(WebCore::EGLOffScreenSurface::EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::~EGLOffScreenSurface):
(WebCore::EGLOffScreenSurface::attributes):
(WebCore::EGLOffScreenSurface::configuration):
(WebCore::EGLOffScreenSurface::destroy):

platform/graphics/surfaces/egl/EGLSurface.h:

(WebCore):
(EGLTransportSurface):
(EGLOffScreenSurface):

platform/graphics/surfaces/egl/EGLXSurface.cpp: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.cpp.

(WebCore):
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::~EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::swapBuffers):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLPixmapSurface::EGLPixmapSurface):
(WebCore::EGLPixmapSurface::~EGLPixmapSurface):
(WebCore::EGLPixmapSurface::destroy):

platform/graphics/surfaces/egl/EGLXSurface.h: Copied from Source/WebCore/platform/graphics/surfaces/egl/EGLSurface.h.

(WebCore):
(EGLWindowTransportSurface):
(EGLPixmapSurface):

EGLPixmapSurface implementation.

8:50 AM Changeset in webkit [147221] by commit-queue@webkit.org

12 edits in trunk

Unreviewed, rolling out r147218.
http://trac.webkit.org/changeset/147218
https://bugs.webkit.org/show_bug.cgi?id=113585

We should rethink UI of this feature. (Requested by vsevik on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-29

Source/WebCore:

inspector/InjectedScriptSource.js:

(.):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.populateWithProperties):

inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.prototype.set else):
(WebInspector.RemoteObjectProperty):

inspector/front-end/inspector.css:

LayoutTests:

inspector/console/command-line-api-expected.txt:
inspector/debugger/properties-special-expected.txt:
inspector/debugger/properties-special.html:
inspector/runtime/runtime-getProperties-expected.txt:
inspector/runtime/runtime-getProperties.html:
platform/chromium/inspector/debugger/properties-special-expected.txt:

8:20 AM Changeset in webkit [147220] by caseq@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: extract common base for 3 timeline overview controls (Events/Frames/Memory)
https://bugs.webkit.org/show_bug.cgi?id=113572

Reviewed by Yury Semikhatsky.

Refactoring, covered by existing tests.

introduce TimelineOverviewBase as a common base for 3 overview controls;
make every overview control a view.

This does not yet take advantage of common base (subject of the next patch).

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.gridElement):
(WebInspector.OverviewGrid.prototype.itemsGraphsElement):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewBase):
(WebInspector.TimelineOverviewBase.prototype.update):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):
(WebInspector.TimelineFrameOverview):
(WebInspector.TimelineFrameOverview.prototype.update):
(WebInspector.TimelineFrameOverview.prototype._renderBars):
(WebInspector.TimelineFrameOverview.prototype._drawFPSMarks):
(WebInspector.TimelineFrameOverview.prototype._renderBar):

8:09 AM Changeset in webkit [147219] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

Web Inspector: Update test expectation for resource-har-conversion.html
https://bugs.webkit.org/show_bug.cgi?id=113460

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-29
Reviewed by Vsevolod Vlasov.

The value of pageref and title had been changed after r105596.
(Use page ids, not document URLs in HAR entries to refer to pages.

Use page URL as a title field of a HAR page.)

http/tests/inspector/resource-har-conversion-expected.txt:
platform/mac-snowleopard/http/tests/inspector/resource-har-conversion-expected.txt:
platform/mac/http/tests/inspector/resource-har-conversion-expected.txt:
platform/win/http/tests/inspector/resource-har-conversion-expected.txt:

8:02 AM Changeset in webkit [147218] by commit-queue@webkit.org

12 edits in trunk

Web Inspector: gather accessor property getter and setter under a single tree node
https://bugs.webkit.org/show_bug.cgi?id=113357

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-29
Reviewed by Yury Semikhatsky.

Source/WebCore:

A new tree element class AccessorPropertyTreeElemenet is added.
RemoteObjectProperty can now represent accessor property (if value is null).
New tree element is supported in CSS stylesheet.

Testing code is slightly modified for exploring new tree elements.

inspector/InjectedScriptSource.js:

(.):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertyTreeElement.populateWithProperties):
(WebInspector.AccessorPropertyTreeElement):
(WebInspector.AccessorPropertyTreeElement.prototype.onattach):
(WebInspector.AccessorPropertyTreeElement.prototype.update):
(WebInspector.AccessorPropertyTreeElement.prototype.onpopulate):

inspector/front-end/RemoteObject.js:
inspector/front-end/inspector.css:

(.accessor-property-name):

LayoutTests:

Expectations are fixed with changed functionality and changed tests.

inspector/debugger/properties-special-expected.txt:
inspector/debugger/properties-special.html:
inspector/runtime/runtime-getProperties-expected.txt:
inspector/runtime/runtime-getProperties.html:
platform/chromium/inspector/debugger/properties-special-expected.txt:

7:21 AM Changeset in webkit [147217] by timothy@apple.com

1 edit
1 add in trunk/LayoutTests

Unreviewed Windows gardening.

platform/win/fast/events/event-attribute-expected.txt: Added.

New baseline after r147205.

7:17 AM Changeset in webkit [147216] by timothy@apple.com

1 edit
1 add in trunk/LayoutTests

Unreviewed Mac gardening.

platform/mac/fast/events/event-attribute-expected.txt: Added.

New baseline after r147205.

7:15 AM Changeset in webkit [147215] by kadam@inf.u-szeged.hu

1 edit
1 delete in trunk/LayoutTests

[Qt] Removal of misplaced stuff after r146692.

platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Removed.
platform/qt-unknown/svg/carto.net/tabgroup-expected.png: Removed.

7:14 AM Changeset in webkit [147214] by abucur@adobe.com

2 edits
6 adds in trunk/PerformanceTests

[CSS Regions] Add performance tests
https://bugs.webkit.org/show_bug.cgi?id=113303

Reviewed by Antti Koivisto.

Add simple performance tests for regions, without nested named flows: a region chain and a flow article.
The regions.js script is used to generate the tests and can set the following parameters: the number of regions,
the number of paragraphs, the regions width, height, max-height and the propability of a forced break after a paragraph.

The tests are skipped for now. They should be enabled once the regions performance is stable enough to create a baseline.

Layout/RegionsAuto.html: Added. A few regions with a short article. The regions have auto-height and some

paragraphs (80%) have forced breaks after. Stress test for the auto-height algorithm.

Layout/RegionsAutoMaxHeight.html: Added. A lot of regions with auto-height and max-height. Tests the impact of

max-height on the auto-height algorithm.

Layout/RegionsFixed.html: Added. A lot of regions with a long article. Some paragraphs (50%) have forced breaks after.

Stress test for the regions layout algorithm.

Layout/RegionsFixedShort.html: Added. A lot of short regions with a long content. Tests the impact of unforced breaks

on the layout speed.

Layout/resources/regions.css: Added.

(.articleInFlow):
(.articleNone):
(.region):
(.contentParagraph):
(.breakAfter):
(.regionContainer):

Layout/resources/regions.js: Added.

(.):

Skipped:

6:56 AM Changeset in webkit [147213] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Developers will have more clue
if two different profiles will have same colors for same functions.
https://bugs.webkit.org/show_bug.cgi?id=113410

Reviewed by Pavel Feldman.

The code related to color generator was extracted into a separate class.
The instance of the class was stored as static private member of the FlameChart class,
so all the profiles will share the same instance and will use same colors.
The colors itself were slightly adjusted.

Drive by fix: coordinatesToNodeIndex was fixed. The error was introduced in the patch about left padding.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.ColorGenerator):
(WebInspector.FlameChart.ColorGenerator.prototype._colorPairForID):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._calculateTimelineDataForSamples):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):

6:18 AM Changeset in webkit [147212] by charles.wei@torchmobile.com.cn

11 edits in trunk

[BlackBerry] Cleanup the CONTEXT_MENUS in BlackBerry porting
https://bugs.webkit.org/show_bug.cgi?id=113562

Reviewed by George Staikos.
Internally reviewed by Mike Fenton and Gen Mak.

Source/cmake/OptionsBlackBerry.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/WebCore:

No new tests, just disable CONTEXT_MENUS for blackberry porting.

platform/blackberry/ContextMenuBlackBerry.cpp:
platform/blackberry/ContextMenuItemBlackBerry.cpp:

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

WebCoreSupport/ContextMenuClientBlackBerry.cpp:
WebCoreSupport/ContextMenuClientBlackBerry.h:

6:08 AM Changeset in webkit [147211] by charles.wei@torchmobile.com.cn

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Context menu doesn't showup anymore after rebase.
https://bugs.webkit.org/show_bug.cgi?id=113570

Reviewed by George Staikos.

The upstreaming patch for bug: 103058, reverses the return value of
Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
so we should reverse our logic in webkit part that calls it also.

This only applys to master_41 which is a new rebase, don't apply it to master_40.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

5:55 AM Changeset in webkit [147210] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix build warning after r147022
https://bugs.webkit.org/show_bug.cgi?id=113567

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-03-29
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
No new tests, no change on behavior.

page/EventHandler.cpp:

(WebCore::expandSelectionToRespectUserSelectAll):

5:40 AM Changeset in webkit [147209] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: ability to use AnchorBox as an anchor for Popover
https://bugs.webkit.org/show_bug.cgi?id=113563

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
Reviewed by Pavel Feldman.

No new test: no change in behaviour.

Ability to pass AnchorBox instead of Element for popover anchor.

inspector/front-end/Popover.js:

(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper.prototype._eventInHoverElement):

5:31 AM Changeset in webkit [147208] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: assign Scroll events to rendering category (was painting)
https://bugs.webkit.org/show_bug.cgi?id=113564

Reviewed by Pavel Feldman.

inspector/front-end/TimelinePresentationModel.js: /ScrollLayer.*category/s/painting/rendering/

(WebInspector.TimelinePresentationModel._initRecordStyles):

5:27 AM Changeset in webkit [147207] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test after r147205.

platform/qt-5.0-wk1/TestExpectations:

4:28 AM Changeset in webkit [147206] by Philippe Normand

2 edits in trunk/Source/WebCore

[GStreamer] playback gets bumpy sometimes when on-disk buffering is slow
https://bugs.webkit.org/show_bug.cgi?id=113512

Reviewed by Martin Robinson.

When the HTTP source element is slow downloading data for on-disk
buffering the playback position might reach an unbuffered region
and have bad consequences, pausing the pipeline beforehand
prevents this case to happen.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):

2:59 AM Changeset in webkit [147205] by keishi@webkit.org

14 edits
4 adds in trunk

Add the event handler content attributes that are defined in the spec to HTMLElement
https://bugs.webkit.org/show_bug.cgi?id=86363

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/events/event-attribute.html

We are missing some event handler content attributes from HTMLElement that are defined in the spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects

html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName): Returns event name for a given attribute name by looking it up on a HashMap.
(WebCore::HTMLElement::parseAttribute): Sets up event listeners for content attributes.

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::parseAttribute): Removed event listener content attributes that was added to HTMLElement.

html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute): Ditto.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute): Ditto.

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute): Ditto.

html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::parseAttribute): Ditto.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::parseAttribute): Ditto.

html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::parseAttribute): Ditto.

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Ditto.

LayoutTests:

fast/events/event-attribute-expected.txt: Added.
fast/events/event-attribute.html: Added. Tests that setting attribute creates event listeners.
fast/events/form-onchange-expected.txt: Added.
fast/events/form-onchange.html: Added. Test for Bug 24516.

2:44 AM Changeset in webkit [147204] by caseq@chromium.org

16 edits in trunk

Web Inspector: timeline paint rectangles are off for transformed layers
https://bugs.webkit.org/show_bug.cgi?id=112919

Reviewed by Pavel Feldman.

Source/WebCore:

pass RenderObject instead of Frame to InspectorInstrumentation::didPaint;
take transforms into account and convert paint clip rect into quad;
emit quads, not rects as Paint and Layout record data;
adjust client to using quads, compute width/height from quad coords.

inspector/InspectorInstrumentation.cpp: Pass RenderObject, not frame to {will,did}Paint.

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Added.

inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::localToPageQuad): Convert local clip rect to transformed quad.
(WebCore):

inspector/InspectorTimelineAgent.h:

(WebCore):
(InspectorTimelineAgent):

inspector/TimelineRecordFactory.cpp: Emit quads as Paint and Layout records data.

(WebCore::createQuad):
(WebCore):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::createLayoutData):

inspector/TimelineRecordFactory.h:

(WebCore):
(TimelineRecordFactory):

inspector/front-end/TimelinePanel.js: Highlight a quad iff formatted record has highlightQuad field.

(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightQuad):
(WebInspector.TimelinePanel.prototype._hideQuadHighlight):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.Record): Set highlightQuad for Paint and Layout
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.quadWidth):
(WebInspector.TimelinePresentationModel.quadHeight):

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

adjust to changed record format;
simplify test using InspectorTest.evaluateWithTimeline().

http/tests/inspector/timeline-test.js:
inspector/timeline/timeline-layout-expected.txt:
inspector/timeline/timeline-paint-expected.txt:
inspector/timeline/timeline-paint.html:

2:33 AM Changeset in webkit [147203] by zarvai@inf.u-szeged.hu

6 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
platform/qt/TestExpectations:
platform/qt/compositing/contents-opaque/control-layer-expected.txt: Rebaseline after r147127.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.

2:25 AM Changeset in webkit [147202] by caseq@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad()
https://bugs.webkit.org/show_bug.cgi?id=112911

Reviewed by Pavel Feldman.

added Quad type and DOMAgent.highlightQuad() to protocol;
retained DOMAgent.highlightRect(), but implement it via highlightQuad.

inspector/Inspector.json:
inspector/InspectorDOMAgent.cpp:

(WebCore::parseQuad):
(WebCore):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):

inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

inspector/InspectorOverlay.cpp: Mostly just renames of rect to quad.

(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reportMemoryUsage):

inspector/InspectorOverlay.h:

(InspectorOverlay):

inspector/InspectorOverlayPage.html: Ditto.

1:51 AM Changeset in webkit [147201] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding a crashing expectation for the

ttp/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html layout test. Skipping the perf/ tests when
using the debug build.

platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt: Rebaselining after r147156.

12:59 AM Changeset in webkit [147200] by commit-queue@webkit.org

3 edits
19 adds in trunk/LayoutTests

[EFL] New baselines for accessibility tests.
https://bugs.webkit.org/show_bug.cgi?id=113510

Unreviewed, EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-29

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:
platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
platform/efl/accessibility/aria-checkbox-text-expected.txt: Added.
platform/efl/accessibility/aria-combobox-expected.txt: Added.
platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Added.
platform/efl/accessibility/aria-roles-expected.txt: Added.
platform/efl/accessibility/aria-tables-expected.txt: Added.
platform/efl/accessibility/aria-toggle-button-with-title-expected.txt: Added.
platform/efl/accessibility/canvas-description-and-role-expected.txt: Added.
platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
platform/efl/accessibility/image-link-expected.txt: Added.
platform/efl/accessibility/image-map1-expected.txt: Added.
platform/efl/accessibility/image-map2-expected.txt: Added.
platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
platform/efl/accessibility/legend-expected.txt: Added.
platform/efl/accessibility/menu-list-sends-change-notification-expected.txt: Added.
platform/efl/accessibility/notification-listeners-expected.txt: Added.
platform/efl/accessibility/svg-image-expected.txt: Added.

12:36 AM Changeset in webkit [147199] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
https://bugs.webkit.org/show_bug.cgi?id=113526

Source/WebCore:

It matches shipping Safari and Firefox behaviour.

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.

Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-29
Reviewed by Antti Koivisto.

fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added.
fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added.

Mar 28, 2013:

11:31 PM Changeset in webkit [147198] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu.
https://bugs.webkit.org/show_bug.cgi?id=113496

Reviewed by Pavel Feldman.

Integrate CookiesTable with DataGrid context menu
instead of overriding it.

inspector/front-end/CookiesTable.js:

Pass context menu callback to DataGrid constructor.

inspector/front-end/DataGrid.js:

Added context menu callback constructor parameter. Fixed JSDoc.

10:53 PM Changeset in webkit [147197] by ryuan.choi@samsung.com

3 edits in trunk/Tools

[EFL] Build break with latest EFL libraries after r146265
https://bugs.webkit.org/show_bug.cgi?id=113558

Unreviewed build fix.

TestWebKitAPI/PlatformWebView.h:
WebKitTestRunner/PlatformWebView.h:

10:40 PM Changeset in webkit [147196] by gyuyoung.kim@samsung.com

2 edits in trunk/Tools

Unreviewed. Fix build break when running --update-efl in WebKit EFL.

efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail

in libgcrypt build.

9:33 PM Changeset in webkit [147195] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r147123.
http://trac.webkit.org/changeset/147123
https://bugs.webkit.org/show_bug.cgi?id=113557

wrong TextExpectation removal (Requested by shinyak|gardener
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

platform/chromium/TestExpectations:

9:12 PM Changeset in webkit [147194] by shinyak@chromium.org

8 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Test expectations update and rebaselining.

platform/chromium-mac-lion/fast/lists/003-vertical-expected.png:
platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.txt:
platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.txt:
platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.txt:
platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.txt:
platform/chromium-mac/fast/lists/003-vertical-expected.png:
platform/chromium-mac/fast/text/international/text-spliced-font-expected.txt:

8:47 PM Changeset in webkit [147193] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

platform/chromium/TestExpectations:

6:48 PM Changeset in webkit [147192] by commit-queue@webkit.org

3 edits
3 deletes in trunk/Source/WebKit/chromium

[chromium] Remove unused WebRegularExpression API
https://bugs.webkit.org/show_bug.cgi?id=113520

Patch by James Robinson <jamesr@chromium.org> on 2013-03-28
Reviewed by Kent Tamura.

Last reference to these files removed in r190880.

WebKit.gyp:
public/WebRegularExpression.h: Removed.
public/WebTextCaseSensitivity.h: Removed.
src/AssertMatchingEnums.cpp:
src/WebRegularExpression.cpp: Removed.

6:16 PM Changeset in webkit [147191] by beidson@apple.com

2 edits in trunk/Source/WebKit2

We leak NetworkConnectionToWebProcess objects.
<rdar://problem/13393118> and https://bugs.webkit.org/show_bug.cgi?id=113551

Reviewed by Anders Carlsson.

NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didClose): Remove this from the global set

of NetworkConnectionToWebProcess objects.

6:09 PM Changeset in webkit [147190] by ggaren@apple.com

13 edits in trunk/Source/JavaScriptCore

Simplified the bytecode by removing op_loop and op_loop_if_*
https://bugs.webkit.org/show_bug.cgi?id=113548

Reviewed by Filip Pizlo.

Regular jumps will suffice.

These opcodes are identical to branches, except they also do timeout
checking. That style of timeout checking has been broken for a long
time, and when we add back timeout checking, it won't use these opcodes.

JavaScriptCore.order:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:

(JIT):
(JSC):

llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:

6:01 PM Changeset in webkit [147189] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't cross editing boundary when touch hold selection expands
https://bugs.webkit.org/show_bug.cgi?id=113537

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Set editing boundary crossing rule to make sure it won't cross
editing boundary when selection expands.

Reviewed Internally By Genevieve Mak and Mike Fenton.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):

5:51 PM Changeset in webkit [147188] by mkwst@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening.

http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
crashes sometimes. Applying the patch from wkbug.com/111902 fixes it
locally for me: skipping it until that patch lands.

platform/mac/TestExpectations:

Marking http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
as crashy in Debug.

5:50 PM Changeset in webkit [147187] by pdr@google.com

2 edits in trunk/Source/WebCore

Fix compiler warning in IDBTransaction::modeToString
https://bugs.webkit.org/show_bug.cgi?id=113547

Reviewed by Darin Adler.

Not all compilers are smart enough to handle this switch. This patch refactors
modeToString to not return from the default case.

No new tests as this is just a compiler fix.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::modeToString):

5:18 PM Changeset in webkit [147186] by Simon Fraser

6 edits in trunk/Source/WebCore

GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
https://bugs.webkit.org/show_bug.cgi?id=113544

Reviewed by Tim Horton.

The functions added in r147058 to update the visible rects of GraphicsLayerCAs
should not have actually set the m_visibleRect on the layer, because this
caused a later call to adjustTiledLayerVisibleRect() to think that the visible
rect had not changed, so it did no expansion.

Clarify the logic to ask the GraphicsLayer whether, given a new visible
rect, it would need to make new tiles (which happens later during a flush).

Add a function to RenderLayerCompositor to call this code (but which has
no callers yet).

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::visibleRectChangeRequiresFlush): Make private.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush):

platform/graphics/ca/GraphicsLayerCA.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::noteVisibleRectChanged):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

5:13 PM Changeset in webkit [147185] by rafaelw@chromium.org

4 edits in trunk

[HTMLTemplateElement] <template> should be able to be a foster parent
https://bugs.webkit.org/show_bug.cgi?id=113541

Source/WebCore:

Reviewed by Eric Seidel

This adds to the check in findFosterSite to include whether the parent is a DocumentFragment which is a template contents.

Tests added to html5lib suite.

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::findFosterSite):

LayoutTests:

Reviewed by Eric Seidel.

html5lib/resources/template.dat:

5:09 PM Changeset in webkit [147184] by ggaren@apple.com

17 edits in trunk/Source/JavaScriptCore

Simplified the bytecode by removing op_jmp_scopes
https://bugs.webkit.org/show_bug.cgi?id=113545

Reviewed by Filip Pizlo.

We already have op_pop_scope and op_jmp, so we don't need op_jmp_scopes.
Using op_jmp_scopes was also adding a "jump to self" to codegen for
return statements, which was pretty silly.

JavaScriptCore.order:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

bytecode/Opcode.h:

(JSC::padOpcodeName):

bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitPopScopes):

bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

bytecompiler/NodesCodegen.cpp:

(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

jit/JIT.h:
jit/JITOpcodes.cpp:
jit/JITOpcodes32_64.cpp:
jit/JITStubs.cpp:
jit/JITStubs.h:
llint/LLIntSlowPaths.cpp:
llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:

4:46 PM Changeset in webkit [147183] by tony@chromium.org

9 edits in trunk/LayoutTests

Convert some flexbox layout tests to using flexbox.css
https://bugs.webkit.org/show_bug.cgi?id=113534

Reviewed by Ojan Vafai.

This allows tests to be run without the -webkit prefix for flexbox tests allowing
some of them to run in Firefox.

css3/flexbox/flex-align-baseline.html:
css3/flexbox/flex-align-column.html:
css3/flexbox/flex-align-end.html:
css3/flexbox/flex-align-max.html:
css3/flexbox/flex-align-percent-height.html:
css3/flexbox/flex-align-stretch.html:
css3/flexbox/flex-align-vertical-writing-mode.html:
css3/flexbox/flex-align.html:

4:43 PM Changeset in webkit [147182] by tony@chromium.org

2 edits in trunk/LayoutTests

[chromium] Unreviewed, fix up some lint errors in TestExpectations.

platform/chromium/TestExpectations:

4:40 PM Changeset in webkit [147181] by aelias@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

src/WebInputEventConversion.cpp:

(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

4:12 PM Changeset in webkit [147180] by Lucas Forschler

10 edits in tags/Safari-537.35.3

Merged r146955. <rdar://problem/12324224>

4:09 PM Changeset in webkit [147179] by beidson@apple.com

4 edits in trunk/Source/WebKit2

Resources are never revalidated/reloaded if a cached response exists on disk.
<rdar://problem/13479890> and https://bugs.webkit.org/show_bug.cgi?id=113542

Reviewed by Alexey Proskuryakov.

Trying to get a cached resource in didReceiveResponse and then aborting the load
meant we never performed any new loads.

We can check and see if the data is cached data inside didReceiveBuffer, instead.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse): Don't try for cached resources here.
(WebKit::NetworkResourceLoader::didReceiveData): This callback should never be used.
(WebKit::NetworkResourceLoader::didReceiveBuffer): Try to see if this data objected represents

a file based mmaped buffer.

NetworkProcess/NetworkResourceLoader.h:

Refactor these utility functions to start from either a CFURLCachedResponse or a SharedBuffer:

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(CFCachedURLResponseGetMemMappedData):
(CFURLCacheIsMemMappedData):
(WebKit::tryGetShareableHandleFromCFData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

4:08 PM Changeset in webkit [147178] by wangxianzhu@chromium.org

4 edits in trunk/Source

[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524

Reviewed by James Robinson.

Source/WebCore:

Test: GraphicsLayerChromiumTest.setContentsToSolidColor

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):

Source/WebKit/chromium:

tests/GraphicsLayerChromiumTest.cpp:

(GraphicsLayerChromiumTest::setContentsToSolidColor):

4:07 PM Changeset in webkit [147177] by Lucas Forschler

2 edits in tags/Safari-537.35.3/Source/WebCore

Merged r147050. <rdar://problem/13205610>

4:03 PM Changeset in webkit [147176] by Lucas Forschler

5 edits
2 copies in tags/Safari-537.35.3

Merged r147018. <rdar://problem/13205610>

4:00 PM Changeset in webkit [147175] by Lucas Forschler

2 edits in tags/Safari-537.35.3/Source/WebKit2

Merged r146722. <rdar://problem/13205610>

3:55 PM Changeset in webkit [147174] by Lucas Forschler

10 edits in tags/Safari-537.35.3/Source

Merged r146664. <rdar://problem/13205610>

3:48 PM Changeset in webkit [147173] by Lucas Forschler

12 edits
4 copies in tags/Safari-537.35.3

Merged r146946. <rdar://problem/13486852>

3:39 PM Changeset in webkit [147172] by commit-queue@webkit.org

4 edits
2 moves in trunk

use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
https://bugs.webkit.org/show_bug.cgi?id=113518

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum XMLHttpRequestResponseType type instead of DOMString for
XMLHttpRequest responseType.

Argument validation now happens in the bindings.
XMLHttpRequest::setResponseType should then never receive invalid
arguments. So, replace console message with ASSERT_NOT_REACHED();

Test: fast/xmlhttprequest/xmlhttprequest-set-responsetype.html

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setResponseType):

xml/XMLHttpRequest.idl:

LayoutTests:

Update xmlhttprequest-responsetype-set-invalidtype expected result:
Test all valide responseType. Remove expected console message in case
of invalid responseType. Rename to xmlhttprequest-set-responsetype

fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt.
fast/xmlhttprequest/xmlhttprequest-set-responsetype.html: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html.
fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:

3:29 PM Changeset in webkit [147171] by Lucas Forschler

326 edits
17 copies
2 deletes in tags/Safari-537.35.3

Merged r146531. <rdar://problem/12324224>

3:25 PM Changeset in webkit [147170] by commit-queue@webkit.org

3 edits
1 add in trunk

[css3-text] Add platform support for "wavy" text decoration style
https://bugs.webkit.org/show_bug.cgi?id=92868

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-28
Reviewed by Benjamin Poulain.

Source/WebCore:

This patch uses GraphicsContext::strokePath() to implement
wavy decoration for the CSS3 property "text-decoration-style".

No new tests as this is covered with existing tests.

rendering/InlineTextBox.cpp:

(WebCore::textDecorationStyleToStrokeStyle): Remove obsolete comment.
(WebCore::adjustStepToDecorationLength): Add function to adjust
variables used to calculate the lenght of Bezier curves.
(WebCore::strokeWavyTextDecoration): Add function to stroke wavy
decoration based on cubic Bezier curve.
(WebCore::InlineTextBox::paintDecoration): Call
strokeWavyTextDecoration when necessary.

LayoutTests:

Rebaseline chromium-linux expectation for
fast/css3-text/css3-text-decoration/text-decoration-style.html.

platform/chromium-linux/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.

3:17 PM Changeset in webkit [147169] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

REGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=113538

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Simon Fraser.

Run run-bindings-tests --reset-results to fix broken tests after
r147149.

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::shortAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::createAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetter):
(WebCore::TestObjV8Internal::anyAttributeAttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::strictFloatAttrSetter):
(WebCore::TestObjV8Internal::idAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetter):

3:07 PM Changeset in webkit [147168] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

http://trac.webkit.org/changeset/147152 was wrong, and should have been
(as the ChangeLog stated) testing the argument to redirectDataToPlugin,
not the value of m_pluginView.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

3:07 PM Changeset in webkit [147167] by commit-queue@webkit.org

6 edits
1 delete in trunk/Source/WebCore

Unreviewed, rolling out r147130.
http://trac.webkit.org/changeset/147130
https://bugs.webkit.org/show_bug.cgi?id=113539

Not needed now that we do not sleep in preprocessor.pm
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

WebCore.gyp/WebCore.gyp:
bindings/scripts/CodeGenerator.pm:

(ParseInterface):

bindings/scripts/IDLParser.pm:

(Parse):

bindings/scripts/generate-bindings.pl:
bindings/scripts/generate-preprocessed-idls.pl: Removed.
bindings/scripts/preprocessor.pm:

(applyPreprocessor):

3:01 PM Changeset in webkit [147166] by Lucas Forschler

2 edits in trunk/Tools

Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.

Unreviewed.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(MacEWS):

2:58 PM Changeset in webkit [147165] by Nate Chapin

6 edits in trunk

Source/WebCore: Don't grant local content permissions for appcache loads.
https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

No new tests, fixing http/tests/appcache/local-content.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::commitData): Don't grant local load permissions

to all SubstituteData loads, only give them to loads that were SubstituteData
loads at the time of DocumentLoader construction. This constitutes all
SubstituteData loads except those triggered by appcache.

loader/DocumentLoader.h:
loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Move granting local load

permissions for SubstituteData loads to DocumentLoader::commitData().

LayoutTests: Remove expected failure for https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

platform/qt-5.0-wk1/TestExpectations:

2:56 PM Changeset in webkit [147164] by mkwst@chromium.org

15 edits in trunk

X-Frame-Options: Blocked resources should fire load events.
https://bugs.webkit.org/show_bug.cgi?id=113192

Reviewed by Nate Chapin.

Source/WebCore:

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

Fire a load event on the frame's owner element when denying access
due to X-Frame-Options header content. This brings us in-line with
Gecko and IE, which both trigger load events currently.

LayoutTests:

http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html:
http/tests/security/XFrameOptions/x-frame-options-deny.html:
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:

Add some expectations around the 'load' event to ensure it's fired.

2:50 PM Changeset in webkit [147163] by commit-queue@webkit.org

11 edits
1 add in trunk/Source

Support bottom-right anchored fixed-position elements during a pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=111670

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-28
Reviewed by James Robinson.

Source/Platform:

Added WebLayerPositionConstraint for layers that need position
adjustment during threaded scrolling.
Currently it is only used for fixed-position layers.

Platform.gypi:
chromium/public/WebLayer.h:

(WebKit):
(WebLayer):
(WebKit::WebLayer::setPositionConstraint):
(WebKit::WebLayer::positionConstraint):
(WebKit::WebLayer::setFixedToContainerLayer):
(WebKit::WebLayer::fixedToContainerLayer):

chromium/public/WebLayerPositionConstraint.h: Added.

(WebKit):
(WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::fixedPosition):

Source/WebCore:

This patch adds support to bottom-right fixed-position elements by
introducing WebLayerPositionConstraint to WebLayer.

No new tests. Can't test until chromium patch landed.

page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateLayerPositionConstraint):

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::clearPositionConstraintExceptForLayer):
(WebCore):
(WebCore::computePositionConstraint):
(WebCore::ScrollingCoordinatorChromium::updateLayerPositionConstraint):

page/scrolling/chromium/ScrollingCoordinatorChromium.h:

(ScrollingCoordinatorChromium):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::registerScrollingLayers):

rendering/RenderLayerBacking.h:

(WebCore::RenderLayerBacking::contentsContainmentLayer):
(RenderLayerBacking):

rendering/RenderLayerCompositor.cpp:
rendering/RenderLayerCompositor.h:

2:50 PM Changeset in webkit [147162] by Lucas Forschler

20 edits in tags/Safari-537.35.3/Source

Merged r146823. <rdar://problem/13475462>

2:46 PM Changeset in webkit [147161] by tkent@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
https://bugs.webkit.org/show_bug.cgi?id=113377

Reviewed by Dimitri Glazkov.

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.

2:46 PM Changeset in webkit [147160] by Lucas Forschler

1 edit in tags/Safari-537.35.3/Source/WTF/ChangeLog

Fix revision number in ChangeLog.

2:45 PM Changeset in webkit [147159] by Lucas Forschler

2 edits in tags/Safari-537.35.3/Source/WTF

Merge portion of r146823 needed for <rdar://problem/13475462>

wtf/HashSet.h:

(WTF):
(WTF::copyToVector):

2:44 PM Changeset in webkit [147158] by jshin@chromium.org

1 edit in trunk/LayoutTests/platform/chromium/TestExpectations

[Chromium] Unreviewed. Test Expectations update.

platform/chromium/TestExpectations:

2:31 PM Changeset in webkit [147157] by jamesr@google.com

2 edits in trunk/Source/WebCore

Remove unnecessary 1 second sleep on windows from preprocessor.pm
https://bugs.webkit.org/show_bug.cgi?id=113536

Unreviewed, partial rollout of r146661.

This rolls out one line of 146661 that slows down the windows build significantly.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

2:03 PM Changeset in webkit [147156] by leviw@chromium.org

5 edits in trunk

Source/WebCore: Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

Bugs in Chromium-mac's -webkit-font-feature-settings support prevented us from enabling the
optimization when it was enabled for all other platforms. This was believed to be related to
kerning, but the bug shows up when there are any font-feature-settings specified. For now,
optimizing the common case and only turning off the optimization when there are font-feature-
settings in play.

Updated test fast/text/shaping/shaping-selection-rect.html to avoid breaking due to
https://bugs.webkit.org/show_bug.cgi?id=113418

rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests: Disable font measurement optimization for Chromium-mac when there are font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing

due to https://bugs.webkit.org/show_bug.cgi?id=113418.

2:01 PM Changeset in webkit [147155] by zoltan@webkit.org

3 edits
2 moves
3 adds in trunk

[CSS Exclusions][CSS Regions] Block children do not layout inline content correctly in a region with shape-inside set
https://bugs.webkit.org/show_bug.cgi?id=112177

Reviewed by David Hyatt.

Source/WebCore:

When we had two multiple regions and a shape-inside was applied on the second region, but not on the first region and the content contained
paragraphs, the content was pushed down almost to the bottom in the second region. In a flow thread this behavior caused by the lack of the
proper updating of absoluteLogicalTop in RenderBlock::layoutRunsAndFloatsInRange function.

Tests: fast/regions/shape-inside/shape-inside-on-additional-regions.html

fast/regions/shape-inside/shape-inside-on-regions.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the value of absoluteLogicalTop in every run when we are in a flow thread.

LayoutTests:

Add a new subdirectory for regions shape-inside tests. Move old and add new test files to the directory.

fast/regions/shape-inside: Added.
fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Added.
fast/regions/shape-inside/shape-inside-on-additional-regions.html: Added.
fast/regions/shape-inside/shape-inside-on-regions-expected.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions-expected.html.
fast/regions/shape-inside/shape-inside-on-regions.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions.html.

1:52 PM Changeset in webkit [147154] by alokp@chromium.org

1 edit
1 copy
1 move
2 adds in trunk/LayoutTests

Unreviewed rebaseline.
Adding missing baseline for new test compositing/contents-opaque/control-layer.html

platform/chromium-mac/platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer-expected.txt: Copied from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
platform/chromium-win/compositing/contents-opaque/control-layer-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.

1:38 PM Changeset in webkit [147153] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r191172. Requested by
pdr2 via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

DEPS:

1:24 PM Changeset in webkit [147152] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

Ignore redirectDataToPlugin(0), which is only called from PluginDocument::detach(),
and only after r125500. Otherwise, PluginDocuments that are put into the page cache
but leave later can clear a totally different and legitimate PluginView from the
WebFrameLoaderClient, causing data to be lost and PluginDocument loads to stall.

This restores our behavior to the pre-r125500 state, which should be fine, as we
clear WebFrameLoaderClient's m_pluginView when the load fails or finishes. This
matches the changes made in r125500 for every platform other than Chromium and WebKit2.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

1:21 PM Changeset in webkit [147151] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

PDFPlugin: shouldUsePDFPlugin can't use pdfLayerControllerClass() because it asserts if it's not available
https://bugs.webkit.org/show_bug.cgi?id=113533
<rdar://problem/13528720>

Reviewed by Simon Fraser.

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldUsePDFPlugin):
Move shouldUsePDFPlugin to WebPageMac, where it belongs, and explicitly look up PDFLayerController
instead of using pdfLayerControllerClass(), which ASSERT()s if it isn't available.

1:21 PM Changeset in webkit [147150] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Safari hangs during test262 run in CodeCache::pruneSlowCase
https://bugs.webkit.org/show_bug.cgi?id=113469

Reviewed by Geoffrey Garen.

We can end up hanging for quite some time if we add a lot of small keys to the CodeCache.
By the time we get around to pruning the cache, we have a potentially tens or hundreds of
thousands of small entries, which can cause a noticeable hang when pruning them.

To fix this issue we added a hard cap to the number of entries in the cache because we
could potentially have to remove every element in the map.

runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): We need to prune until we're both under the hard cap and the
capacity in bytes.

runtime/CodeCache.h:

(CodeCacheMap):
(JSC::CodeCacheMap::numberOfEntries): Convenience accessor function to the number of entries in
the map that does the cast to size_t of m_map.size() for us.
(JSC::CodeCacheMap::canPruneQuickly): Checks that the total number is under the hard cap. We put this
check inside a function to more accurately describe why we're doing the check and to abstract out
the actual calculation in case we want to coalesce calls to pruneSlowCase in the future.
(JSC::CodeCacheMap::prune): Check the number of entries against our hard cap. If it's greater than
the cap then we need to drop down to pruneSlowCase.

1:08 PM Changeset in webkit [147149] by commit-queue@webkit.org

5 edits in trunk

exceptions are not checked after toInt32 calls in bindings.
https://bugs.webkit.org/show_bug.cgi?id=113218

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

In attribute setter, wrap JSValue to native value conversion in a try
catch block.

Define a new macro binding: V8TRYCATCH_VOID

No new tests: covered by fast/dom/exception-in-binding.html

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):

bindings/v8/V8BindingMacros.h:

(WebCore):

LayoutTests:

platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html

1:05 PM Changeset in webkit [147148] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed gardening on AppleWin port.
More tests that use mouseScrollBy event which hasn't been implemented yet on Windows.

platform/win/TestExpectations:

1:01 PM Changeset in webkit [147147] by rniwa@webkit.org

2 edits in trunk/Tools

Use the right OS name on Mac EWS instead of mac-future.

Rubber-stamped by Dirk Pranke.

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):
(PatchProcessingQueue.begin_work_queue):
(PatchProcessingQueue._upload_results_archive_for_patch):

12:59 PM Changeset in webkit [147146] by Claudio Saavedra

2 edits
2 moves in trunk/LayoutTests

Prepare extend-selection-enclosing-block test to support different editing behavior
https://bugs.webkit.org/show_bug.cgi?id=113424

Reviewed by Ryosuke Niwa.

We make this test Mac specific and change
extendAndLogSelectionWithinBlock() to take the platform as a
parameter. When bug 110487 is fixed this should be extended to
test the Windows editing behavior.

editing/selection/extend-selection-enclosing-block-mac-expected.txt:

Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt.

editing/selection/extend-selection-enclosing-block-mac.html:

Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block.html.

editing/selection/resources/extend-selection.js:

(extendAndLogSelectionWithinBlock): Extend to receive platform as
a parameter. Only "mac" is supported for now.

12:59 PM Changeset in webkit [147145] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

[GTK][AC] Use transform property of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113317

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

ClutterActor has a transform property to set transformation matrix directly
since version 1.12. So we don't need to keep and use the matrix property of GraphicsLayerActor.

No new tests because of no functionality change.

platform/graphics/clutter/GraphicsLayerActor.cpp:

(_GraphicsLayerActorPrivate):
(graphicsLayerActorDispose):
(graphicsLayerActorApplyTransform):

platform/graphics/clutter/GraphicsLayerActor.h:
platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::updateTransform):

platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::addTransformTransition):

12:57 PM Changeset in webkit [147144] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Unreviewed, rolling out r143834.
http://trac.webkit.org/changeset/143834
https://bugs.webkit.org/show_bug.cgi?id=113530

Multiple use-after-free regressions on ClusterFuzz (Requested
by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

dom/Attr.cpp:

(WebCore::Attr::Attr):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

dom/Attr.h:

(Attr):

dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

dom/Element.h:

(Element):

12:52 PM Changeset in webkit [147143] by Claudio Saavedra

2 edits in trunk/LayoutTests

Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test
https://bugs.webkit.org/show_bug.cgi?id=113490

Reviewed by Ryosuke Niwa.

editing/selection/move-vertically-with-paddings-borders.html:

(selectWord): Use String.trim() to drop trailing whitespaces that
might be added depending on the editing behavior. See related bug
110487.

12:46 PM Changeset in webkit [147142] by Lucas Forschler

4 edits in tags/Safari-537.35.3/Source

Versioning

12:42 PM Changeset in webkit [147141] by Lucas Forschler

1 copy in tags/Safari-537.35.3

New Tag.

12:24 PM Changeset in webkit [147140] by jchaffraix@webkit.org

5 edits
6 adds in trunk

[CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
https://bugs.webkit.org/show_bug.cgi?id=113351

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-element-border-grid-item.html

fast/css-grid-layout/grid-element-border-padding-grid-item.html
fast/css-grid-layout/grid-element-padding-grid-item.html

rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
Added this helper function (we do have borderAndPaddingStart but didn't have this
one for some reason).

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::findChildLogicalPosition):
Shifted |offset| by the paddings and borders before / start.

LayoutTests:

fast/css-grid-layout/resources/grid.css:

(.verticalLR):
(.horizontalBT):
(.directionRTL):
Added more helper classes.

fast/css-grid-layout/grid-element-border-grid-item-expected.txt: Added.
fast/css-grid-layout/grid-element-border-grid-item.html: Added.
fast/css-grid-layout/grid-element-border-padding-grid-item-expected.txt: Added.
fast/css-grid-layout/grid-element-border-padding-grid-item.html: Added.
fast/css-grid-layout/grid-element-padding-grid-item-expected.txt: Added.
fast/css-grid-layout/grid-element-padding-grid-item.html: Added.

12:08 PM Changeset in webkit [147139] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Unskip some layout test folder on Windows port.

platform/win/TestExpectations:

12:00 PM Changeset in webkit [147138] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Reduce PluginProcess lifetime.
<rdar://problem/12465479> and https://bugs.webkit.org/show_bug.cgi?id=113523

Reviewed by Sam Weinig.

Lower the minimum process lifetime from 30 minutes to 2 minutes.
Lower the "shutdown after last plugin goes away" period from 10 minutes to 1 minute.

UIProcess/Plugins/PluginProcessProxy.cpp:

11:58 AM Changeset in webkit [147137] by zandobersek@gmail.com

18 edits
2 adds
2 deletes in trunk

[GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
https://bugs.webkit.org/show_bug.cgi?id=112546

Reviewed by Martin Robinson.

GNUmakefile.am: Define the new platform_webcore_cppflags.

Source/Platform:

GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform

directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
CPPFLAGS.

GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the

GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
GNUmakefile.list.am placed in the same framework directory in which the source file is located.

Source/WebCore:

No new tests - no new functionality.

GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now

built into libPlatformGtk.la.

GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the

libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.

platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.

Source/WebKit/gtk:

GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.

Source/WebKit2:

GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the

libPlatformGtk2's CPPFLAGS.

Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched

for forwarding headers, it's at the moment not necessary to be included.

Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the

WebCore framework.

Shared/gtk/WebEventFactory.cpp: Ditto.
UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.

Tools:

GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has

moved back to Source/WebCore/platform. Fix an indentation issue as well.

11:44 AM Changeset in webkit [147136] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
https://bugs.webkit.org/show_bug.cgi?id=113447
Internal PR 313452

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Potential threading problems are avoided by moving from
WebPage members and mapToTransformed() to the web page
client's userInterfaceViewportAccessor().

As part of this cleaning effort, the WebPageCompositor's
render() method is changed to now take document instead of
pixel coordinates.

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::compositeContents):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):

Api/WebPageCompositor.h:
Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

11:38 AM Changeset in webkit [147135] by falken@chromium.org

55 edits in trunk/Source

Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
https://bugs.webkit.org/show_bug.cgi?id=113273

Reviewed by Kent Tamura.

Element::disabled is about form controls and Element::isEnabledFormControl
is redundant with it, so replace them with a single function
Element::isDisabledFormControl.

Source/WebCore:

No new tests, there should be no behavior change.

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):

accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):

accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::canSetFocusAttribute):

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isEnabled):

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):

dom/Element.cpp:

(WebCore::Element::isDisabledFormControl):

dom/Element.h:

(Element):
(WebCore::isDisabledFormControl): Add helper function for convenience.
(WebCore):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):

html/DOMFormData.cpp:

(WebCore::DOMFormData::DOMFormData):

html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::disabledAttributeChanged):

html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
(WebCore::HTMLButtonElement::isSuccessfulSubmitButton):

html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
(WebCore::HTMLFormControlElement::isDisabledFormControl):
(WebCore::HTMLFormControlElement::supportsFocus):

html/HTMLFormControlElement.h:

(HTMLFormControlElement):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isSuccessfulSubmitButton):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::isDisabledFormControl):

html/HTMLOptGroupElement.h:

(HTMLOptGroupElement):

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::isDisabledFormControl):

html/HTMLOptionElement.h:

(HTMLOptionElement):

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::optionAtIndex):

html/ImageInputType.cpp:

(WebCore::ImageInputType::handleDOMActivateEvent):

html/ResetInputType.cpp:

(WebCore::ResetInputType::handleDOMActivateEvent):

html/SubmitInputType.cpp:

(WebCore::SubmitInputType::handleDOMActivateEvent):

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::isDisabledFormControl):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/SpinButtonElement.h:
html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::updateImage):

loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

page/DragController.cpp:

(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::itemIsEnabled):

rendering/RenderTextControl.cpp:

(WebCore::updateUserModifyProperty):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isEnabled):

rendering/RenderThemeMac.mm:

(WebCore::getMediaUIPartStateFlags):

rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::adjustMenuListStyle):

Source/WebKit/blackberry:

WebCoreSupport/CredentialTransformData.cpp:

(WebCore::CredentialTransformData::findPasswordFormFields):

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::openSelectPopup):

Source/WebKit/chromium:

src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::isEnabled):

src/WebOptionElement.cpp:

(WebKit::WebOptionElement::isEnabled):

src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

src/WebSearchableFormData.cpp:

(HTMLNames::findSuitableSearchInputElement):
(HTMLNames::buildSearchString):

Source/WebKit/win:

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::disabled):

11:24 AM Changeset in webkit [147134] by beidson@apple.com

2 edits in trunk/Source/WebCore

Remove workaround for <rdar://problem/5321972>.
<rdar://problem/12022862> and https://bugs.webkit.org/show_bug.cgi?id=113516

Reviewed by Sam Weinig.

No new tests (No point in testing the removal of bizarre behavior).

platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary): This workaround isn't needed on Lion+

11:13 AM Changeset in webkit [147133] by commit-queue@webkit.org

3 edits
2 adds in trunk

use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=113456

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum CanvasWindingRule type instead of DOMString for winding
arguments when needed. Changed methods are: fill, stroke and isPointInPath.

Test: fast/canvas/winding-enumeration.html

html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When calling methods accepting a CanvasWindingRule with an invalid
string, check that a TypeError is thrown.

fast/canvas/winding-enumeration-expected.txt: Added.
fast/canvas/winding-enumeration.html: Added.

10:47 AM Changeset in webkit [147132] by allan.jensen@digia.com

1 edit
1 move
2 adds
1 delete in trunk/LayoutTests

Rebaseline font-face-woff after r147020

Unreviewed gardening.

Updated using garden-o-matic.

fast/css/font-face-woff-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/font-face-woff-expected.txt.
platform/mac/fast/css/font-face-woff-expected.txt: Removed.
platform/qt/fast/css/font-face-woff-expected.png: Added.
platform/qt/fast/css/font-face-woff-expected.txt: Added.

10:40 AM Changeset in webkit [147131] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Gardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove-iframe-crash.html.

Not Reviewed.

platform/mac-wk2/TestExpectations:

10:27 AM Changeset in webkit [147130] by commit-queue@webkit.org

6 edits
1 add in trunk/Source/WebCore

Move preprocessing of idl to pre-pass for gyp
https://bugs.webkit.org/show_bug.cgi?id=113448

Patch by Scott Graham <scottmg@chromium.org> on 2013-03-28
Reviewed by Tony Chang.

Moves the preprocessor invocations when parsing IDL files to a
pre-pass to avoid reinvocations when IDLs are referenced from others.
This reduces the number of invocations of the preprocessor from 20071
to 633, which reduces the runtime from 12m30 to 1m (on a Windows box).

No new tests, this is a build time improvement, and shouldn't have any
visible effect.

WebCore.gyp/WebCore.gyp:
bindings/scripts/CodeGenerator.pm:

(ParseInterface):

bindings/scripts/IDLParser.pm:

(Parse):

bindings/scripts/generate-bindings.pl:
bindings/scripts/generate-preprocessed-idls.pl: Added.
bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:25 AM Changeset in webkit [147129] by kadam@inf.u-szeged.hu

1 edit
74 adds in trunk/LayoutTests

[Qt] Unreviewed gardneing. Updated png expected results after r146206.

platform/qt-5.0-wk2/editing/deleting/5126166-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/5206311-1-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/5369009-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/5433862-2-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-3608445-fix-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-block-contents-003-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-br-002-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-br-003-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-br-004-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-br-006-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-hr-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/delete-listitem-001-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/merge-different-styles-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/pruning-after-merge-2-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/smart-delete-003-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png: Added.
platform/qt-5.0-wk2/editing/deleting/type-delete-after-quote-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/4580583-1-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/4924441-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/indent-empty-root-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/insertHorizontalRule-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/insertImage-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/nsresponder-indent-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/nsresponder-outdent-expected.png: Added.
platform/qt-5.0-wk2/editing/execCommand/remove-list-item-1-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/4875189-1-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/4875189-2-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/4959067-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/5418891-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/insert-3778059-fix-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/insert-3800346-fix-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/insert-div-025-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/insert-paragraph-02-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/paragraph-separator-03-expected.png: Added.
platform/qt-5.0-wk2/editing/inserting/redo-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/4076267-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/4242293-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/4641033-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/5032095-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/5134759-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/merge-end-borders-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/merge-start-list-expected.png: Added.
platform/qt-5.0-wk2/editing/pasteboard/styled-element-markup-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/13804-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/4866671-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/5099303-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/expanding-selections-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/expanding-selections2-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/extend-by-character-003-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/extend-by-character-005-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/extend-by-sentence-001-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/inline-table-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/mixed-editability-4-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/mixed-editability-5-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/mixed-editability-9-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/move-by-character-003-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/move-by-character-005-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/replace-selection-1-expected.png: Added.
platform/qt-5.0-wk2/editing/selection/table-caret-3-expected.png: Added.
platform/qt-5.0-wk2/editing/style/4916887-expected.png: Added.
platform/qt-5.0-wk2/editing/style/5084241-expected.png: Added.

10:14 AM Changeset in webkit [147128] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Fix layout test for blending in the background
https://bugs.webkit.org/show_bug.cgi?id=113402

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-03-28
Reviewed by Dirk Schulze.

Fixed the layout test effect-background-blend-mode.html typo
Also rebaselined the test

css3/compositing/effect-background-blend-mode.html:
platform/mac/css3/compositing/effect-background-blend-mode-expected.png:

10:03 AM Changeset in webkit [147127] by alokp@chromium.org

3 edits
3 adds in trunk

RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

compositing/contents-opaque/control-layer-expected.txt: Added.
compositing/contents-opaque/control-layer.html: Added.
platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.

9:46 AM Changeset in webkit [147126] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding failure expectation for a reftest added in r147111
that's failing due to subpixel layout being disabled on the GTK port.

platform/gtk/TestExpectations:

9:38 AM Changeset in webkit [147125] by Martin Robinson

4 edits
1 add in trunk/Source/WebKit/gtk

[GTK] [gyp] Improve support for rerunning gyp automatically
https://bugs.webkit.org/show_bug.cgi?id=113360

Reviewed by Gustavo Noronha Silva.

Add support for automatically rerunning gyp when input file changes are detected
while running make.

gyp/GNUmakefile: Added. A wrapper that invokes the generated makefile.
gyp/autogen.sh: Add a symlink to the wrapper script.
gyp/configure.ac: "Freeze" the TOPLEVEL_DIRECTORY command-line argument so that

run-gyp reads it properly when configure is run independently of autogen.sh.

gyp/run-gyp: Prevent generation of auto-regeneration rules in gyp. They are buggy.

9:32 AM Changeset in webkit [147124] by commit-queue@webkit.org

2 edits in trunk/Tools

[BlackBerry] Committer Email Updates
https://bugs.webkit.org/show_bug.cgi?id=113435

Patch by Ming Xie <mxie@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Add the @blackberry.com email address for all our BlackBerry
WebKit committers. This is the first step for our email address
migration.

Scripts/webkitpy/common/config/committers.py:

9:31 AM Changeset in webkit [147123] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

This test is temporatily disabled in TestExpectations. platform/chromium/TestExpectations override this expectation for chromium/debug.
It removed for now.

platform/chromium/TestExpectations:

9:05 AM Changeset in webkit [147122] by Philippe Normand

3 edits in trunk/Tools

[jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=113508

Reviewed by Martin Robinson.

Prevent the GStreamer plugin scanner to load system-wide
plugins. Only the ones built in JHBuild should be loaded and used
at runtime.

efl/jhbuildrc:
gtk/jhbuildrc:

9:00 AM Changeset in webkit [147121] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK][AC] Animating layer disappears while running with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110470

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

The reason of this issue is that clutter_actor_remove_child leads to stopping animations
of child actor. ClutterActor's animation could be defined only when it has a parent actor.
So we should avoid the case calling the api as much as we can. At least we don't
need to reset a actor's parent at all if the current parent is same with new one.
If we can't avoid invoking clutter_actor_remove_child for an animating actor, we may apply
a more complicated way to keep the animation. But I haven't faced such a case yet.

Covered by existing animation tests.

platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorSetSublayers):

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::updateSublayerList):

8:48 AM Changeset in webkit [147120] by wangxianzhu@chromium.org

4 edits
4 adds in trunk

Non-painting fixed elements should not cause repaints on scroll
https://bugs.webkit.org/show_bug.cgi?id=110430

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/scroll-fixed-layer-no-content.html
Test: compositing/repaint/scroll-fixed-layer-out-of-view.html

page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.

LayoutTests:

compositing/repaint/scroll-fixed-layer-no-content.html: Added.
compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.

8:46 AM Changeset in webkit [147119] by Christophe Dumez

3 edits in trunk/LayoutTests

Unreviewed gardening.

Fix bad rebaseline in r147115.

fast/forms/validationMessage-expected.txt:
platform/efl/fast/forms/validationMessage-expected.txt:

8:35 AM Changeset in webkit [147118] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed, revert accidentally added line committed in r147117.

inspector/front-end/ElementsTreeOutline.js:

8:15 AM Changeset in webkit [147117] by apavlov@chromium.org

8 edits in trunk

Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor
https://bugs.webkit.org/show_bug.cgi?id=113306

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use CodeMirror as the raw HTML editor for the "Edit as HTML" menu item
(and all multiline editors for WebInspector.startEditing()).
Drive-by fix for handling the editing when the editor has been invoked on the closing tag.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype.commit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):

inspector/front-end/UIUtils.js:

(WebInspector.EditingConfig.prototype.setMultiline):
(WebInspector.startEditing):
(WebInspector.CodeMirrorCSSLoadView): A bogus view to load-unload CodeMirror-related CSS on demand.

inspector/front-end/elementsPanel.css:

(#elements-content .CodeMirror):
(#elements-content .CodeMirror pre):
(#elements-content .CodeMirror-lines):

inspector/front-end/elementsPanel.css: CodeMirror styles for the "Edit as HTML" editor.
inspector/front-end/externs.js: Declare CodeMirror type with some members, as it is third-party code.
inspector/front-end/inspector.html: Fix script order (UIUtils.js requires View.js).

LayoutTests:

inspector/elements/edit-dom-actions.html:

7:53 AM Changeset in webkit [147116] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark several tests as failing due to missing WKTR / DRT functionality.

platform/efl/TestExpectations:

7:44 AM Changeset in webkit [147115] by Christophe Dumez

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/forms/validationMessage.html after r145024.

fast/forms/validationMessage-expected.txt:

7:41 AM Changeset in webkit [147114] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed gardening of test failures after r147086 and r147090.

platform/gtk-wk1/TestExpectations:
platform/gtk/TestExpectations:

7:34 AM Changeset in webkit [147113] by morrita@google.com

7 edits
2 adds in trunk

Custom Elements: should support non-HTML namespaces.
https://bugs.webkit.org/show_bug.cgi?id=111693

Reviewed by Dimitri Glazkov.

Source/WebCore:

Some existing code assumes that the element extends HTMLElements.
This change allow it to extend from Element. Note that the
namespace URI of a custom element is determined by given element
prototype: An element will have XHTML namespace if its prototype
chain includes HTMLElements, SVGElement leads SVG namespace and
null otherwise, respectively.

Test: fast/dom/custom/document-register-namespace.html

bindings/v8/CustomElementHelpers.cpp:

(WebCore::hasValidPrototypeChainFor): Factored out from isValidPrototypeParameter()
(WebCore::CustomElementHelpers::isValidPrototypeParameter): Extend to support non HTMLElement prototype
(WebCore::CustomElementHelpers::findLocalName): Support non-HTML element names.

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElementInternal):

dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::registerElement): No longer hard-codes namespace and picks one based on the prototype value.

dom/CustomElementRegistry.h:

(CustomElementRegistry):

LayoutTests:

fast/dom/custom/document-register-namespace-expected.txt: Added.
fast/dom/custom/document-register-namespace.html: Added.

7:28 AM Changeset in webkit [147112] by Christophe Dumez

1 edit
2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Add platform specific expectation for http/tests/inspector/console-resource-errors.html.
We get the same result as mac port.

platform/efl/http/tests/inspector/console-resource-errors-expected.txt: Added.

7:20 AM Changeset in webkit [147111] by hmuller@adobe.com

4 edits
6 adds in trunk

[CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside
https://bugs.webkit.org/show_bug.cgi?id=112592

Reviewed by Dirk Schulze.

Source/WebCore:

First pass at computing the padded or inset boundary of a polygon. This version does not handle
self-intersecting polygons, or values of shape-padding large enough to change the shape of the
original polygon. The implementation computes an offset edge for each polgon edge, where the offset
edge is parallel to the original edge and separated by shape-padding. The padded polygon's vertices
are the intersections of each pair of adjacent offset edges. When adjacent offset edges do not intersect,
because they share a reflex vertex in the original polygon, an approximation to a circular arc
connects the offset edges.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html

fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

rendering/ExclusionPolygon.cpp:

(WebCore::isReflexVertex): Just moved this function earlier in the file.
(WebCore::inwardEdgeNormal): Unit vector that's perpindicular to the edge and that points inwards.
(WebCore::outwardEdgeNormal): Unit vector that's perpindicular to the edge and that points outwards.
(WebCore::appendArc): Append a linear approximation to a circular arc to a vector of vertices.
(WebCore::computeShapePaddingBounds): Return a polygon whose edges are all inset by shape-padding from m_polygon.
(WebCore::computeShapeMarginBounds): Just a stub, see bug 112917.
(WebCore::ExclusionPolygon::shapePaddingBounds): Lazily use computeShapePaddingBounds() to initialize m_paddingBounds.
(WebCore::ExclusionPolygon::shapeMarginBounds): Lazily use computeShapeMarginBounds() to initialize m_marginBounds.
(WebCore::ExclusionPolygon::getIncludedIntervals): Now based on the value of shapePaddingBounds().
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Now based on the value of shapePaddingBounds().

rendering/ExclusionPolygon.h:

(WebCore::ExclusionPolygon::ExclusionPolygon):

LayoutTests:

Verify that the CSS shape-padding property works correctly for some simple polygonal shapes:
a rectangle, a rectangle rotated 45 degress, and rectangular shape with a single reflex vertex.

fast/exclusions/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html: Added.
fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html: Added.
fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html: Added.

7:04 AM Changeset in webkit [147110] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[BlackBerry] Handle EXIF orientation for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=113423

Internal Bug: PR 293648
Informally Reviewed by Jeff Rogers
Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Support image orientation in our image draw calls, and advertise
the capability to the calling code. This allows us to respect EXIF
orientation data.

platform/graphics/BitmapImage.h:
platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::BitmapImage::draw):
(WebCore):

rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

6:46 AM Changeset in webkit [147109] by caseq@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: name timeline overview controls consistently
https://bugs.webkit.org/show_bug.cgi?id=113503

Reviewed by Yury Semikhatsky.

Refactoring, covered by existing tests.

rename HeapGraph to TimelineMemoryOverview;
rename TimelineCategoryStrips to TimelineEventOvrview.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setMinimumRecordDuration):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):

6:43 AM Changeset in webkit [147108] by Philippe Normand

2 edits in trunk/Tools

[GTK] run-launcher --gtk -2 fails on a WK2-only build
https://bugs.webkit.org/show_bug.cgi?id=113386

Reviewed by Carlos Garcia Campos.

Scripts/webkitdirs.pm:

(builtDylibPathForName): The WebKit2GTK .so name change from 1.0
version to 3.0. Reflect this change so the builtDylibPathForName
function doesn't fail to report the library as found.

6:39 AM Changeset in webkit [147107] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Correct glyph contour winding direction when fake-bolding
https://bugs.webkit.org/show_bug.cgi?id=113411

Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:

(WebCore::FontPlatformData::applyState):

6:35 AM Changeset in webkit [147106] by vsevik@chromium.org

6 edits in trunk

Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSourceCode does not have a scriptFile.
https://bugs.webkit.org/show_bug.cgi?id=113500

Reviewed by Pavel Feldman.

JavaScriptSourceFrame now listens for uiSourceCode working copy related events and supports muting breakpoints without script file.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyChanged):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.dispose):

6:25 AM Changeset in webkit [147105] by caseq@chromium.org

11 edits
1 add in trunk/Source/WebCore

Web Inspector: factor out node search controller from inspector.js
https://bugs.webkit.org/show_bug.cgi?id=112689

Reviewed by Pavel Feldman.

This just extracts the existing logic of toggling node search
from inspector.js into a class of its own, InspectElementModeController.
Drive-by: add CtrlOrMeta+Shift+C to help screen.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
inspector/compile-front-end.py:
inspector/front-end/InspectElementModeController.js: Added.

(WebInspector.InspectElementModeController):
(WebInspector.InspectElementModeController.createShortcut):
(WebInspector.InspectElementModeController.prototype.enabled):
(WebInspector.InspectElementModeController.prototype.disable):
(WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
(WebInspector.InspectElementModeController.prototype.toggleSearch):
(WebInspector.InspectElementModeController.prototype.handleShortcut):

inspector/front-end/InspectorFrontendAPI.js:

(InspectorFrontendAPI.enterInspectElementMode):

inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector._createGlobalStatusBarItems):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._updateFocusedNode):

6:09 AM Changeset in webkit [147104] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375

Reviewed by Pavel Feldman.

Serialized "previouslyViewedFiles" may make local storage overflow.
Two fixed applied:

limit number of history log items
limit length of URIs that get serialized; this would affect only data-url URIs.

inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
Added length check.
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
Added output array length limit.

6:07 AM Changeset in webkit [147103] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
https://bugs.webkit.org/show_bug.cgi?id=113497

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):

inspector/front-end/heapProfiler.css:

(.heap-snapshot-view .data-grid div.heap-snapshot-multiple-values):

6:06 AM Changeset in webkit [147102] by vsevik@chromium.org

9 edits in trunk

Web Inspector: ResourceScriptFile should check if resource content really matches VM script when determining hasDiverged state.
https://bugs.webkit.org/show_bug.cgi?id=113488

Reviewed by Pavel Feldman.

Source/WebCore:

Enabled support for checking that file content matches VM script in ResourceScriptFile (For script resources only).
This check is never done before content is loaded in corresponding editor to avoid regressing performance.
File - script content matching is done bearing in mind sourceURLs.
Live edit keeps sourceURL in script content now even if it is not present in file's content.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):

inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditScriptFile.prototype.checkMapping):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ScriptFile.prototype.checkMapping):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._sourceMatchesScriptSource):
(WebInspector.ResourceScriptFile.prototype._sourceEndsWithSourceURL):
(WebInspector.ResourceScriptFile.prototype.checkMapping.callback):
(WebInspector.ResourceScriptFile.prototype.checkMapping):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptFile.prototype.checkMapping):

LayoutTests:

http/tests/inspector/debugger-test.js:
inspector/debugger/file-system-project-mapping-expected.txt:
inspector/debugger/file-system-project-mapping.html:

6:04 AM Changeset in webkit [147101] by kadam@inf.u-szeged.hu

196 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png expected results after r146206.

platform/qt/editing/deleting/5126166-expected.png:
platform/qt/editing/deleting/5206311-1-expected.png:
platform/qt/editing/deleting/5272440-expected.png:
platform/qt/editing/deleting/5369009-expected.png:
platform/qt/editing/deleting/5433862-2-expected.png:
platform/qt/editing/deleting/delete-3608445-fix-expected.png:
platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
platform/qt/editing/deleting/delete-block-contents-003-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
platform/qt/editing/deleting/delete-br-002-expected.png:
platform/qt/editing/deleting/delete-br-003-expected.png:
platform/qt/editing/deleting/delete-br-004-expected.png:
platform/qt/editing/deleting/delete-br-005-expected.png:
platform/qt/editing/deleting/delete-br-006-expected.png:
platform/qt/editing/deleting/delete-hr-expected.png:
platform/qt/editing/deleting/delete-image-002-expected.png:
platform/qt/editing/deleting/delete-line-003-expected.png:
platform/qt/editing/deleting/delete-line-004-expected.png:
platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
platform/qt/editing/deleting/delete-listitem-001-expected.png:
platform/qt/editing/deleting/forward-delete-expected.png:
platform/qt/editing/deleting/merge-different-styles-expected.png:
platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
platform/qt/editing/deleting/smart-delete-003-expected.png:
platform/qt/editing/deleting/smart-delete-004-expected.png:
platform/qt/editing/deleting/type-delete-after-quote-expected.png:
platform/qt/editing/execCommand/4580583-1-expected.png:
platform/qt/editing/execCommand/4924441-expected.png:
platform/qt/editing/execCommand/5482023-expected.png:
platform/qt/editing/execCommand/findString-2-expected.png:
platform/qt/editing/execCommand/indent-empty-root-expected.png:
platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
platform/qt/editing/execCommand/insertImage-expected.png:
platform/qt/editing/execCommand/nsresponder-indent-expected.png:
platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
platform/qt/editing/execCommand/paste-1-expected.png:
platform/qt/editing/execCommand/paste-2-expected.png:
platform/qt/editing/execCommand/remove-list-item-1-expected.png:
platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
platform/qt/editing/inserting/4875189-1-expected.png:
platform/qt/editing/inserting/4875189-2-expected.png:
platform/qt/editing/inserting/4959067-expected.png:
platform/qt/editing/inserting/5418891-expected.png:
platform/qt/editing/inserting/before-after-input-element-expected.png:
platform/qt/editing/inserting/editable-html-element-expected.png:
platform/qt/editing/inserting/edited-whitespace-1-expected.png:
platform/qt/editing/inserting/insert-3654864-fix-expected.png:
platform/qt/editing/inserting/insert-3778059-fix-expected.png:
platform/qt/editing/inserting/insert-3800346-fix-expected.png:
platform/qt/editing/inserting/insert-3851164-fix-expected.png:
platform/qt/editing/inserting/insert-div-011-expected.png:
platform/qt/editing/inserting/insert-div-012-expected.png:
platform/qt/editing/inserting/insert-div-013-expected.png:
platform/qt/editing/inserting/insert-div-014-expected.png:
platform/qt/editing/inserting/insert-div-015-expected.png:
platform/qt/editing/inserting/insert-div-016-expected.png:
platform/qt/editing/inserting/insert-div-017-expected.png:
platform/qt/editing/inserting/insert-div-018-expected.png:
platform/qt/editing/inserting/insert-div-019-expected.png:
platform/qt/editing/inserting/insert-div-020-expected.png:
platform/qt/editing/inserting/insert-div-025-expected.png:
platform/qt/editing/inserting/insert-div-027-expected.png:
platform/qt/editing/inserting/insert-paragraph-02-expected.png:
platform/qt/editing/inserting/paragraph-separator-03-expected.png:
platform/qt/editing/inserting/redo-expected.png:
platform/qt/editing/pasteboard/4076267-expected.png:
platform/qt/editing/pasteboard/4242293-expected.png:
platform/qt/editing/pasteboard/4641033-expected.png:
platform/qt/editing/pasteboard/4944770-1-expected.png:
platform/qt/editing/pasteboard/4944770-2-expected.png:
platform/qt/editing/pasteboard/4989774-expected.png:
platform/qt/editing/pasteboard/5028447-expected.png:
platform/qt/editing/pasteboard/5032095-expected.png:
platform/qt/editing/pasteboard/5134759-expected.png:
platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
platform/qt/editing/pasteboard/input-field-1-expected.png:
platform/qt/editing/pasteboard/merge-after-delete-expected.png:
platform/qt/editing/pasteboard/merge-end-borders-expected.png:
platform/qt/editing/pasteboard/merge-start-list-expected.png:
platform/qt/editing/pasteboard/paste-text-004-expected.png:
platform/qt/editing/pasteboard/paste-text-008-expected.png:
platform/qt/editing/pasteboard/paste-text-009-expected.png:
platform/qt/editing/pasteboard/paste-text-013-expected.png:
platform/qt/editing/pasteboard/paste-text-014-expected.png:
platform/qt/editing/pasteboard/paste-text-016-expected.png:
platform/qt/editing/pasteboard/styled-element-markup-expected.png:
platform/qt/editing/selection/13804-expected.png:
platform/qt/editing/selection/4402375-expected.png:
platform/qt/editing/selection/4776665-expected.png:
platform/qt/editing/selection/4866671-expected.png:
platform/qt/editing/selection/4889598-expected.png:
platform/qt/editing/selection/4895428-2-expected.png:
platform/qt/editing/selection/4895428-3-expected.png:
platform/qt/editing/selection/4947387-expected.png:
platform/qt/editing/selection/4960116-expected.png:
platform/qt/editing/selection/4960137-expected.png:
platform/qt/editing/selection/4975120-expected.png:
platform/qt/editing/selection/4983858-expected.png:
platform/qt/editing/selection/5076323-1-expected.png:
platform/qt/editing/selection/5081257-1-expected.png:
platform/qt/editing/selection/5081257-2-expected.png:
platform/qt/editing/selection/5099303-expected.png:
platform/qt/editing/selection/5195166-2-expected.png:
platform/qt/editing/selection/5240265-expected.png:
platform/qt/editing/selection/7152-1-expected.png:
platform/qt/editing/selection/7152-2-expected.png:
platform/qt/editing/selection/addRange-expected.png:
platform/qt/editing/selection/caret-ltr-2-expected.png:
platform/qt/editing/selection/caret-ltr-2-left-expected.png:
platform/qt/editing/selection/caret-ltr-expected.png:
platform/qt/editing/selection/caret-ltr-right-expected.png:
platform/qt/editing/selection/caret-rtl-2-left-expected.png:
platform/qt/editing/selection/caret-rtl-right-expected.png:
platform/qt/editing/selection/clear-selection-expected.png:
platform/qt/editing/selection/contenteditable-click-inside-expected.png:
platform/qt/editing/selection/drag-select-1-expected.png:
platform/qt/editing/selection/editable-html-element-expected.png:
platform/qt/editing/selection/expanding-selections-expected.png:
platform/qt/editing/selection/expanding-selections2-expected.png:
platform/qt/editing/selection/extend-by-character-003-expected.png:
platform/qt/editing/selection/extend-by-character-005-expected.png:
platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
platform/qt/editing/selection/focus_editable_html-expected.png:
platform/qt/editing/selection/inline-table-expected.png:
platform/qt/editing/selection/mixed-editability-1-expected.png:
platform/qt/editing/selection/mixed-editability-3-expected.png:
platform/qt/editing/selection/mixed-editability-4-expected.png:
platform/qt/editing/selection/mixed-editability-5-expected.png:
platform/qt/editing/selection/mixed-editability-8-expected.png:
platform/qt/editing/selection/mixed-editability-9-expected.png:
platform/qt/editing/selection/move-3875618-fix-expected.png:
platform/qt/editing/selection/move-3875641-fix-expected.png:
platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
platform/qt/editing/selection/move-by-character-003-expected.png:
platform/qt/editing/selection/move-by-character-005-expected.png:
platform/qt/editing/selection/node-removal-1-expected.png:
platform/qt/editing/selection/node-removal-2-expected.png:
platform/qt/editing/selection/paragraph-granularity-expected.png:
platform/qt/editing/selection/range-between-block-and-inline-expected.png:
platform/qt/editing/selection/replace-selection-1-expected.png:
platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
platform/qt/editing/selection/select-all-003-expected.png:
platform/qt/editing/selection/select-all-005-expected.png:
platform/qt/editing/selection/select-all-006-expected.png:
platform/qt/editing/selection/select-all-iframe-expected.png:
platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/qt/editing/selection/selectNode-expected.png:
platform/qt/editing/selection/selectNodeContents-expected.png:
platform/qt/editing/selection/selection-actions-expected.png:
platform/qt/editing/selection/selection-button-text-expected.png:
platform/qt/editing/selection/table-caret-3-expected.png:
platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
platform/qt/editing/selection/word-granularity-expected.png:
platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
platform/qt/editing/style/4916887-expected.png:
platform/qt/editing/style/5084241-expected.png:
platform/qt/editing/style/apple-style-editable-mix-expected.png:
platform/qt/editing/style/block-style-001-expected.png:
platform/qt/editing/style/block-style-002-expected.png:
platform/qt/editing/style/block-style-003-expected.png:
platform/qt/editing/style/create-block-for-style-001-expected.png:
platform/qt/editing/style/create-block-for-style-002-expected.png:
platform/qt/editing/style/create-block-for-style-003-expected.png:
platform/qt/editing/style/create-block-for-style-004-expected.png:
platform/qt/editing/style/create-block-for-style-005-expected.png:
platform/qt/editing/style/create-block-for-style-006-expected.png:
platform/qt/editing/style/create-block-for-style-007-expected.png:
platform/qt/editing/style/create-block-for-style-008-expected.png:
platform/qt/editing/style/create-block-for-style-009-expected.png:
platform/qt/editing/style/create-block-for-style-010-expected.png:
platform/qt/editing/style/create-block-for-style-011-expected.png:
platform/qt/editing/style/create-block-for-style-012-expected.png:
platform/qt/editing/style/create-block-for-style-013-expected.png:
platform/qt/editing/style/designmode-expected.png:
platform/qt/editing/style/relative-font-size-change-001-expected.png:
platform/qt/editing/style/relative-font-size-change-002-expected.png:
platform/qt/editing/style/relative-font-size-change-003-expected.png:
platform/qt/editing/style/relative-font-size-change-004-expected.png:

5:45 AM Changeset in webkit [147100] by zarvai@inf.u-szeged.hu

1 edit
2 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Rebaselining after r147086.

platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

5:34 AM Changeset in webkit [147099] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it.
https://bugs.webkit.org/show_bug.cgi?id=113489

Reviewed by Pavel Feldman.

ResourceScriptFile._hasDiverged is the one flag that shows whether we have diverged from VM.
It's values is based both on dirty flag on uiSourceCode and information about live edit failures stored in _lastLiveEditFailed field.
Removed willMerge/Diverge events from ScriptFile.
JavaScriptSourceFrame now uses isMergingToVM/DivergingFromVM methods on ScriptFile.
to determine whether breakpointAdded/Removed events should be ignored.
Introduced muted state on JavaScriptSourceFrame to determine whether it should ignore user attempts to set/remove breakpoints.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._didMergeToVM):
(WebInspector.JavaScriptSourceFrame.prototype._didDivergeFromVM):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._shouldIgnoreExternalBreakpointEvents):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):

inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditScriptFile.prototype.isMergingToVM):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptFile.prototype.isMergingToVM):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._update):
(WebInspector.ResourceScriptFile.prototype._divergeFromVM):
(WebInspector.ResourceScriptFile.prototype._mergeToVM):
(WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ResourceScriptFile.prototype.isMergingToVM):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptFile.prototype.isMergingToVM):

5:31 AM Changeset in webkit [147098] by kadam@inf.u-szeged.hu

4 edits
19 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png expected results after r146206..

platform/qt-5.0-wk2/fast/backgrounds/mask-box-image-expected.png: Added.
platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize08-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-image-scaled-gradient-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-image-slice-constrained-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/border-image-slices-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/box-shadow-radius-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadows-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/inset-expected.png: Added.
platform/qt-5.0-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/qt-5.0-wk2/fast/canvas/canvas-as-image-expected.png: Added.
platform/qt-5.0-wk2/fast/canvas/canvas-bg-zoom-expected.png: Added.
platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png:
platform/qt-5.0-wk2/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png:

5:16 AM Changeset in webkit [147097] by caseq@chromium.org

7 edits in trunk

Web Inspector: DOMContentLoaded event divider is not shown on Timeline's main view
https://bugs.webkit.org/show_bug.cgi?id=113196

Reviewed by Pavel Feldman.

Source/WebCore:

keep event divider records in TimelinePresentationModel, not in TimelinePanel;
process event divider records on every level, not just on top.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.checkVisible):
(WebInspector.TimelinePanel.prototype._resetPanel):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype.eventDividerRecords):

LayoutTests:

use TimelinePresentationModel to fetch list of event divider records;

http/tests/inspector/timeline-test.js:

(initialize_Timeline.InspectorTest.printTimestampRecords):

inspector/timeline/timeline-load-event-expected.txt:
inspector/timeline/timeline-load-event.html:

5:14 AM Changeset in webkit [147096] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed inspector front-end closure compilation fix.

inspector/front-end/CookiesTable.js:

5:11 AM Changeset in webkit [147095] by commit-queue@webkit.org

11 edits in trunk

Web Inspector: [DTE] Paint overlay highlight over line background color
https://bugs.webkit.org/show_bug.cgi?id=113346

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

Source/WebCore:

No new tests: no change in behaviour.

Append spans instead of text nodes to lineRows.
Set positioning of all spans inside of webkit-line-content as

relative

Set z-index property so that overlay highlight is above line

background but under text.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._measureSpans):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):

inspector/front-end/textEditor.css:

(.webkit-line-content > .text-editor-overlay-highlight):
(.webkit-line-content > *):

LayoutTests:

Updated test expectations to correspond to new DefaultTextEditor's DOM
layout.

inspector/editor/text-editor-brace-highlighter-expected.txt:
inspector/editor/text-editor-highlight-api-expected.txt:
inspector/editor/text-editor-highlight-token-expected.txt:
inspector/editor/text-editor-long-line-expected.txt:
inspector/editor/text-editor-remove-chunks-from-dom-expected.txt:
inspector/editor/text-editor-show-whitespace-expected.txt:
inspector/editor/text-editor-type-over-decoration-expected.txt:

5:02 AM Changeset in webkit [147094] by apavlov@chromium.org

3 edits
2 adds in trunk

Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
https://bugs.webkit.org/show_bug.cgi?id=113491

Reviewed by Pavel Feldman.

Source/WebCore:

Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.

Test: inspector/styles/paste-property.html

inspector/front-end/StylesSidebarPane.js:

(.selectElement):
(.moveDirection.alreadyNew):

LayoutTests:

inspector/styles/paste-property-expected.txt: Added.
inspector/styles/paste-property.html: Added.

3:54 AM Changeset in webkit [147093] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adjusting the expectation for media/track/track-in-band-legacy-api.html.

3:40 AM Changeset in webkit [147092] by kadam@inf.u-szeged.hu

410 edits
3 copies
3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results after r146206.

platform/qt/fast/backgrounds/001-expected.png:
platform/qt/fast/backgrounds/background-clip-text-expected.png:
platform/qt/fast/backgrounds/background-origin-root-element-expected.png:
platform/qt/fast/backgrounds/gradient-background-leakage-expected.png:
platform/qt/fast/backgrounds/opacity-on-document-element-expected.png:
platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
platform/qt/fast/block/basic/001-expected.png:
platform/qt/fast/block/basic/004-expected.png:
platform/qt/fast/block/basic/005-expected.png:
platform/qt/fast/block/basic/007-expected.png:
platform/qt/fast/block/basic/008-expected.png:
platform/qt/fast/block/basic/010-expected.png:
platform/qt/fast/block/basic/011-expected.png:
platform/qt/fast/block/basic/015-expected.png:
platform/qt/fast/block/basic/016-expected.png:
platform/qt/fast/block/basic/018-expected.png:
platform/qt/fast/block/basic/019-expected.png:
platform/qt/fast/block/basic/min-pref-width-nowrap-floats-expected.png:
platform/qt/fast/block/basic/minheight-expected.png:
platform/qt/fast/block/basic/quirk-height-expected.png:
platform/qt/fast/block/basic/quirk-percent-height-grandchild-expected.png:
platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
platform/qt/fast/block/float/001-expected.png:
platform/qt/fast/block/float/003-expected.png:
platform/qt/fast/block/float/004-expected.png:
platform/qt/fast/block/float/005-expected.png:
platform/qt/fast/block/float/006-expected.png:
platform/qt/fast/block/float/010-expected.png:
platform/qt/fast/block/float/015-expected.png:
platform/qt/fast/block/float/016-expected.png:
platform/qt/fast/block/float/017-expected.png:
platform/qt/fast/block/float/021-expected.png:
platform/qt/fast/block/float/023-expected.png:
platform/qt/fast/block/float/024-expected.png:
platform/qt/fast/block/float/025-expected.png:
platform/qt/fast/block/float/027-expected.png:
platform/qt/fast/block/float/029-expected.png:
platform/qt/fast/block/float/030-expected.png:
platform/qt/fast/block/float/031-expected.png:
platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
platform/qt/fast/block/float/avoiding-float-centered-expected.png:
platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
platform/qt/fast/block/float/fit_line_below_floats-expected.png:
platform/qt/fast/block/float/float-avoidance-expected.png:
platform/qt/fast/block/float/float-on-zero-height-line-expected.png:
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png:
platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png:
platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
platform/qt/fast/block/float/multiple-float-positioning-expected.png:
platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
platform/qt/fast/block/float/overhanging-after-height-decrease-offsets-expected.png:
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png:
platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png:
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png:
platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png:
platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
platform/qt/fast/block/float/width-update-after-clear-expected.png:
platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
platform/qt/fast/block/lineboxcontain/replaced-expected.png:
platform/qt/fast/block/margin-collapse/001-expected.png:
platform/qt/fast/block/margin-collapse/005-expected.png:
platform/qt/fast/block/margin-collapse/006-expected.png:
platform/qt/fast/block/margin-collapse/010-expected.png:
platform/qt/fast/block/margin-collapse/011-expected.png:
platform/qt/fast/block/margin-collapse/012-expected.png:
platform/qt/fast/block/margin-collapse/015-expected.png:
platform/qt/fast/block/margin-collapse/016-expected.png:
platform/qt/fast/block/margin-collapse/017-expected.png:
platform/qt/fast/block/margin-collapse/018-expected.png:
platform/qt/fast/block/margin-collapse/019-expected.png:
platform/qt/fast/block/margin-collapse/020-expected.png:
platform/qt/fast/block/margin-collapse/025-expected.png:
platform/qt/fast/block/margin-collapse/030-expected.png:
platform/qt/fast/block/margin-collapse/031-expected.png:
platform/qt/fast/block/margin-collapse/037-expected.png:
platform/qt/fast/block/margin-collapse/038-expected.png:
platform/qt/fast/block/margin-collapse/043-expected.png:
platform/qt/fast/block/margin-collapse/056-expected.png:
platform/qt/fast/block/margin-collapse/059-expected.png:
platform/qt/fast/block/margin-collapse/100-expected.png:
platform/qt/fast/block/margin-collapse/103-expected.png:
platform/qt/fast/block/margin-collapse/104-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png:
platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
platform/qt/fast/block/positioning/047-expected.png:
platform/qt/fast/block/positioning/049-expected.png:
platform/qt/fast/block/positioning/051-expected.png:
platform/qt/fast/block/positioning/052-expected.png:
platform/qt/fast/block/positioning/054-expected.png:
platform/qt/fast/block/positioning/055-expected.png:
platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
platform/qt/fast/block/positioning/height-change-expected.png:
platform/qt/fast/block/positioning/pref-width-change-expected.png:
platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
platform/qt/fast/block/positioning/window-height-change-expected.png:
platform/qt/fast/body-propagation/background-image/009-expected.png:
platform/qt/fast/body-propagation/background-image/009-xhtml-expected.png:
platform/qt/fast/body-propagation/overflow/001-expected.png:
platform/qt/fast/body-propagation/overflow/001-xhtml-expected.png:
platform/qt/fast/body-propagation/overflow/005-declarative-expected.png:
platform/qt/fast/body-propagation/overflow/005-expected.png:
platform/qt/fast/body-propagation/overflow/005-xhtml-expected.png:
platform/qt/fast/borders/bidi-002-expected.png:
platform/qt/fast/borders/bidi-009a-expected.png:
platform/qt/fast/borders/bidi-012-expected.png:
platform/qt/fast/borders/border-color-inherit-expected.png:
platform/qt/fast/borders/border-radius-huge-assert-expected.png:
platform/qt/fast/borders/border-radius-inline-flow-expected.png:
platform/qt/fast/borders/border-radius-split-inline-expected.png:
platform/qt/fast/borders/borderRadiusArcs01-expected.png:
platform/qt/fast/borders/borderRadiusDotted05-expected.png:
platform/qt/fast/borders/borderRadiusDouble01-expected.png:
platform/qt/fast/borders/borderRadiusDouble02-expected.png:
platform/qt/fast/borders/borderRadiusDouble03-expected.png:
platform/qt/fast/borders/borderRadiusGroove01-expected.png:
platform/qt/fast/borders/borderRadiusGroove02-expected.png:
platform/qt/fast/borders/borderRadiusInset01-expected.png:
platform/qt/fast/borders/borderRadiusInvalidColor-expected.png:
platform/qt/fast/borders/borderRadiusOutset01-expected.png:
platform/qt/fast/borders/borderRadiusRidge01-expected.png:
platform/qt/fast/borders/borderRadiusSolid01-expected.png:
platform/qt/fast/borders/borderRadiusSolid02-expected.png:
platform/qt/fast/borders/borderRadiusSolid03-expected.png:
platform/qt/fast/borders/borderRadiusSolid04-expected.png:
platform/qt/fast/borders/different-color-borders-expected.png:
platform/qt/fast/borders/fieldsetBorderRadius-expected.png:
platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png:
platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
platform/qt/fast/borders/rtl-border-05-expected.png:
platform/qt/fast/borders/table-borders-expected.png:
platform/qt/fast/borders/webkit-border-radius-expected.png:
platform/qt/fast/box-shadow/basic-shadows-expected.png:
platform/qt/fast/box-shadow/box-shadow-radius-expected.png:
platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
platform/qt/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
platform/qt/fast/box-shadow/spread-multiple-inset-expected.png: Added.
platform/qt/fast/box-shadow/spread-multiple-normal-expected.png: Added.
platform/qt/fast/box-sizing/box-sizing-expected.png:
platform/qt/fast/box-sizing/panels-one-expected.png:
platform/qt/fast/box-sizing/panels-two-expected.png:
platform/qt/fast/canvas/canvas-zoom-expected.png:
platform/qt/fast/clip/001-expected.png:
platform/qt/fast/clip/002-expected.png:
platform/qt/fast/clip/003-expected.png:
platform/qt/fast/clip/004-expected.png:
platform/qt/fast/clip/005-expected.png:
platform/qt/fast/clip/006-expected.png:
platform/qt/fast/clip/007-expected.png:
platform/qt/fast/clip/008-expected.png:
platform/qt/fast/clip/009-expected.png:
platform/qt/fast/clip/010-expected.png:
platform/qt/fast/clip/011-expected.png:
platform/qt/fast/clip/012-expected.png:
platform/qt/fast/clip/013-expected.png:
platform/qt/fast/clip/014-expected.png:
platform/qt/fast/clip/015-expected.png:
platform/qt/fast/clip/nestedTransparencyClip-expected.png:
platform/qt/fast/clip/outline-overflowClip-expected.png:
platform/qt/fast/clip/overflow-border-radius-clip-expected.png:
platform/qt/fast/clip/overflow-border-radius-combinations-expected.png:
platform/qt/fast/clip/overflow-border-radius-composited-expected.png:
platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png:
platform/qt/fast/clip/overflow-border-radius-transformed-expected.png:
platform/qt/fast/css-generated-content/001-expected.png:
platform/qt/fast/css-generated-content/002-expected.png:
platform/qt/fast/css-generated-content/008-expected.png:
platform/qt/fast/css-generated-content/009-expected.png:
platform/qt/fast/css-generated-content/013-expected.png:
platform/qt/fast/css-generated-content/016-expected.png:
platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.png:
platform/qt/fast/css-generated-content/after-order-expected.png:
platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.png:
platform/qt/fast/css-generated-content/inline-display-types-expected.png:
platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png:
platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png:
platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
platform/qt/fast/css-generated-content/table-row-before-after-expected.png:
platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.png:
platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
platform/qt/fast/css/002-expected.png:
platform/qt/fast/css/003-expected.png:
platform/qt/fast/css/004-expected.png:
platform/qt/fast/css/005-expected.png:
platform/qt/fast/css/008-expected.png:
platform/qt/fast/css/ZeroOpacityLayers-expected.png:
platform/qt/fast/css/ZeroOpacityLayers2-expected.png:
platform/qt/fast/css/absolute-poition-in-rtl-parent-expected.png:
platform/qt/fast/css/attribute-selector-dynamic-expected.png:
platform/qt/fast/css/attribute-selector-empty-value-expected.png:
platform/qt/fast/css/background-shorthand-invalid-url-expected.png:
platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png:
platform/qt/fast/css/begin-end-contain-selector-empty-value-expected.png:
platform/qt/fast/css/border-height-expected.png:
platform/qt/fast/css/border-radius-outline-offset-expected.png:
platform/qt/fast/css/border-solid-single-edge-antialias-expected.png: Added.
platform/qt/fast/css/child-style-can-override-visited-style-expected.png:
platform/qt/fast/css/clip-text-in-scaled-div-expected.png:
platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png:
platform/qt/fast/css/continuationCrash-expected.png:
platform/qt/fast/css/create_element_align-expected.png:
platform/qt/fast/css/css-imports-expected.png:
platform/qt/fast/css/css3-modsel-22-expected.png:
platform/qt/fast/css/css3-nth-child-expected.png:
platform/qt/fast/css/error-in-last-decl-expected.png:
platform/qt/fast/css/first-letter-first-line-hover-expected.png:
platform/qt/fast/css/first-letter-float-after-float-expected.png:
platform/qt/fast/css/first-letter-float-expected.png:
platform/qt/fast/css/first-letter-punctuation-expected.png:
platform/qt/fast/css/first-letter-recalculation-expected.png:
platform/qt/fast/css/first-letter-visibility-expected.png:
platform/qt/fast/css/focus-ring-detached-expected.png:
platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
platform/qt/fast/css/focus-ring-outline-color-expected.png:
platform/qt/fast/css/focus-ring-outline-offset-expected.png:
platform/qt/fast/css/focus-ring-outline-width-expected.png:
platform/qt/fast/css/font-face-implicit-local-font-expected.png:
platform/qt/fast/css/font-face-multiple-faces-expected.png:
platform/qt/fast/css/font-face-multiple-remote-sources-expected.png:
platform/qt/fast/css/font-smoothing-expected.png:
platform/qt/fast/css/font_property_normal-expected.png:
platform/qt/fast/css/hsla-color-expected.png:
platform/qt/fast/css/import-rule-regression-11590-expected.png:
platform/qt/fast/css/inline-properties-important-expected.png:
platform/qt/fast/css/invalid-percentage-property-expected.png:
platform/qt/fast/css/invalidation-errors-2-expected.png:
platform/qt/fast/css/invalidation-errors-3-expected.png:
platform/qt/fast/css/invalidation-errors-expected.png:
platform/qt/fast/css/last-child-style-sharing-expected.png:
platform/qt/fast/css/layerZOrderCrash-expected.png:
platform/qt/fast/css/line-height-overflow-expected.png:
platform/qt/fast/css/link-outside-head-expected.png:
platform/qt/fast/css/list-outline-expected.png:
platform/qt/fast/css/margin-bottom-form-element-quirk-expected.png:
platform/qt/fast/css/margin-bottom-form-element-strict-expected.png:
platform/qt/fast/css/namespaces/004-expected.png:
platform/qt/fast/css/namespaces/005-expected.png:
platform/qt/fast/css/namespaces/006-expected.png:
platform/qt/fast/css/namespaces/namespaces-comments-expected.png:
platform/qt/fast/css/namespaces/namespaces-empty-expected.png:
platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.png:
platform/qt/fast/css/negative-leading-expected.png:
platform/qt/fast/css/non-empty-span-expected.png:
platform/qt/fast/css/pendingStylesheetFontSize-expected.png:
platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png:
platform/qt/fast/css/position-negative-top-margin-expected.png:
platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
platform/qt/fast/css/rem-dynamic-scaling-expected.png:
platform/qt/fast/css/rem-units-on-root-expected.png:
platform/qt/fast/css/rgb-float-expected.png:
platform/qt/fast/css/selector-set-attribute-expected.png:
platform/qt/fast/css/shadow-multiple-expected.png:
platform/qt/fast/css/style-outside-head-expected.png:
platform/qt/fast/css/style-parsed-outside-head-expected.png:
platform/qt/fast/css/table-rules-attribute-groups-with-frame-expected.png:
platform/qt/fast/css/table-text-align-quirk-expected.png:
platform/qt/fast/css/table-text-align-strict-expected.png:
platform/qt/fast/css/target-fragment-match-expected.png:
platform/qt/fast/css/text-align-expected.png:
platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.png:
platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
platform/qt/fast/css/text-transform-select-expected.png:
platform/qt/fast/css/textCapitalizeEdgeCases-expected.png:
platform/qt/fast/css/transform-default-parameter-expected.png:
platform/qt/fast/css/transformed-mask-expected.png:
platform/qt/fast/css/transition-color-unspecified-expected.png:
platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png:
platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
platform/qt/fast/css/visibility-hit-test-expected.png:
platform/qt/fast/css/zoom-font-size-expected.png:
platform/qt/fast/doctypes/001-expected.png:
platform/qt/fast/doctypes/002-expected.png:
platform/qt/fast/doctypes/003-expected.png:
platform/qt/fast/doctypes/004-expected.png:
platform/qt/fast/dom/34176-expected.png:
platform/qt/fast/dom/Element/null-offset-parent-expected.png:
platform/qt/fast/dom/HTMLElement/bdo-expected.png:
platform/qt/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
platform/qt/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
platform/qt/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png:
platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
platform/qt/fast/dom/Range/create-contextual-fragment-expected.png:
platform/qt/fast/dom/Range/surroundContents-1-expected.png:
platform/qt/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
platform/qt/fast/dom/anchor-text-expected.png:
platform/qt/fast/dom/blur-contenteditable-expected.png:
platform/qt/fast/dom/createDocumentType-expected.png:
platform/qt/fast/dom/css-rule-functions-expected.png:
platform/qt/fast/dom/delete-contents-expected.png:
platform/qt/fast/dom/gc-10-expected.png:
platform/qt/fast/dom/importNodeHTML-expected.png:
platform/qt/fast/dom/importNodeXML-expected.png:
platform/qt/fast/dynamic/002-expected.png:
platform/qt/fast/dynamic/011-expected.png:
platform/qt/fast/dynamic/014-expected.png:
platform/qt/fast/dynamic/015-expected.png:
platform/qt/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png:
platform/qt/fast/dynamic/first-letter-display-change-expected.png:
platform/qt/fast/dynamic/float-at-line-break-expected.png:
platform/qt/fast/dynamic/float-no-longer-overhanging-expected.png:
platform/qt/fast/dynamic/float-withdrawal-2-expected.png:
platform/qt/fast/dynamic/float-withdrawal-expected.png:
platform/qt/fast/dynamic/noninlinebadness-expected.png:
platform/qt/fast/dynamic/outerHTML-doc-expected.png:
platform/qt/fast/dynamic/outerHTML-img-expected.png:
platform/qt/fast/dynamic/subtree-parent-static-y-expected.png:
platform/qt/fast/dynamic/unicode-bidi-expected.png:
platform/qt/fast/dynamic/view-overflow-expected.png:
platform/qt/fast/encoding/utf-16-big-endian-expected.png:
platform/qt/fast/encoding/utf-16-little-endian-expected.png:
platform/qt/fast/events/event-listener-on-link-expected.png:
platform/qt/fast/events/resize-events-expected.png:
platform/qt/fast/fast-mobile-scrolling/fixed-position-element-expected.png:
platform/qt/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png:
platform/qt/fast/flexbox/001-expected.png:
platform/qt/fast/flexbox/002-expected.png:
platform/qt/fast/flexbox/003-expected.png:
platform/qt/fast/flexbox/004-expected.png:
platform/qt/fast/flexbox/005-expected.png:
platform/qt/fast/flexbox/006-expected.png:
platform/qt/fast/flexbox/007-expected.png:
platform/qt/fast/flexbox/008-expected.png:
platform/qt/fast/flexbox/009-expected.png:
platform/qt/fast/flexbox/010-expected.png:
platform/qt/fast/flexbox/011-expected.png:
platform/qt/fast/flexbox/012-expected.png:
platform/qt/fast/flexbox/013-expected.png:
platform/qt/fast/flexbox/014-expected.png:
platform/qt/fast/flexbox/015-expected.png:
platform/qt/fast/flexbox/016-expected.png:
platform/qt/fast/flexbox/017-expected.png:
platform/qt/fast/flexbox/018-expected.png:
platform/qt/fast/flexbox/019-expected.png:
platform/qt/fast/flexbox/020-expected.png:
platform/qt/fast/flexbox/021-expected.png:
platform/qt/fast/flexbox/022-expected.png:
platform/qt/fast/flexbox/023-expected.png:
platform/qt/fast/flexbox/024-expected.png:
platform/qt/fast/flexbox/overhanging-floats-removed-expected.png:
platform/qt/fast/forms/HTMLOptionElement_label05-expected.png:
platform/qt/fast/forms/basic-buttons-expected.png:
platform/qt/fast/forms/basic-textareas-quirks-expected.png:
platform/qt/fast/forms/button-default-title-expected.png:
platform/qt/fast/forms/button-inner-block-reuse-expected.png:
platform/qt/fast/forms/button-table-styles-expected.png:
platform/qt/fast/forms/button-text-transform-expected.png:
platform/qt/fast/forms/control-clip-overflow-expected.png:
platform/qt/fast/forms/disabled-select-change-index-expected.png:
platform/qt/fast/forms/fieldset-align-expected.png:
platform/qt/fast/forms/file/file-input-direction-expected.png:
platform/qt/fast/forms/floating-textfield-relayout-expected.png:
platform/qt/fast/forms/form-hides-table-expected.png:
platform/qt/fast/forms/input-appearance-selection-expected.png:
platform/qt/fast/forms/input-placeholder-paint-order-expected.png:
platform/qt/fast/forms/listbox-clip-expected.png:
platform/qt/fast/forms/menulist-clip-expected.png:
platform/qt/fast/forms/menulist-option-wrap-expected.png:
platform/qt/fast/forms/negativeLineHeight-expected.png:
platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
platform/qt/fast/forms/option-strip-whitespace-expected.png:
platform/qt/fast/forms/placeholder-position-expected.png:
platform/qt/fast/forms/search-rtl-expected.png:
platform/qt/fast/forms/select-change-popup-to-listbox-expected.png:
platform/qt/fast/forms/select-initial-position-expected.png:
platform/qt/fast/forms/select-item-background-clip-expected.png:
platform/qt/fast/forms/select-list-box-with-height-expected.png:
platform/qt/fast/forms/select/optgroup-rendering-expected.png:
platform/qt/fast/forms/textarea-align-expected.png:
platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
platform/qt/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:

3:07 AM Changeset in webkit [147091] by zarvai@inf.u-szeged.hu

1 edit
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r147086.

platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

2:50 AM Changeset in webkit [147090] by commit-queue@webkit.org

7 edits in trunk

Web Inspector: Auto expand retaining path until there are more than one retainer.
https://bugs.webkit.org/show_bug.cgi?id=112596

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Yury Semikhatsky.

Source/WebCore:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.

Test: inspector/profiler/heap-snapshot-summary-retainers.html

inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.populateComplete):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.setDataSource):

inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):

LayoutTests:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.

Added a test for the new behavior.
Replaced hardcoded "populate complete" string with the event object.

inspector/profiler/heap-snapshot-summary-retainers-expected.txt:
inspector/profiler/heap-snapshot-summary-retainers.html:
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

2:47 AM Changeset in webkit [147089] by zarvai@inf.u-szeged.hu

412 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating PNG expected results after r146206.

platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
platform/qt/tables/mozilla/bugs/bug46924-expected.png:
platform/qt/tables/mozilla/bugs/bug47432-expected.png:
platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
platform/qt/tables/mozilla/bugs/bug48827-expected.png:
platform/qt/tables/mozilla/bugs/bug51037-expected.png:
platform/qt/tables/mozilla/bugs/bug5188-expected.png:
platform/qt/tables/mozilla/bugs/bug52505-expected.png:
platform/qt/tables/mozilla/bugs/bug52506-expected.png:
platform/qt/tables/mozilla/bugs/bug53690-1-expected.png:
platform/qt/tables/mozilla/bugs/bug53690-2-expected.png:
platform/qt/tables/mozilla/bugs/bug5538-expected.png:
platform/qt/tables/mozilla/bugs/bug55527-expected.png:
platform/qt/tables/mozilla/bugs/bug55694-expected.png:
platform/qt/tables/mozilla/bugs/bug55789-expected.png:
platform/qt/tables/mozilla/bugs/bug57300-expected.png:
platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
platform/qt/tables/mozilla/bugs/bug57828-expected.png:
platform/qt/tables/mozilla/bugs/bug5799-expected.png:
platform/qt/tables/mozilla/bugs/bug5835-expected.png:
platform/qt/tables/mozilla/bugs/bug5838-expected.png:
platform/qt/tables/mozilla/bugs/bug59354-expected.png:
platform/qt/tables/mozilla/bugs/bug60804-expected.png:
platform/qt/tables/mozilla/bugs/bug60807-expected.png:
platform/qt/tables/mozilla/bugs/bug6184-expected.png:
platform/qt/tables/mozilla/bugs/bug6304-expected.png:
platform/qt/tables/mozilla/bugs/bug641-1-expected.png:
platform/qt/tables/mozilla/bugs/bug641-2-expected.png:
platform/qt/tables/mozilla/bugs/bug647-expected.png:
platform/qt/tables/mozilla/bugs/bug650-expected.png:
platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
platform/qt/tables/mozilla/bugs/bug68912-expected.png:
platform/qt/tables/mozilla/bugs/bug68998-expected.png:
platform/qt/tables/mozilla/bugs/bug69187-expected.png:
platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
platform/qt/tables/mozilla/bugs/bug709-expected.png:
platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
platform/qt/tables/mozilla/bugs/bug7342-expected.png:
platform/qt/tables/mozilla/bugs/bug7471-expected.png:
platform/qt/tables/mozilla/bugs/bug7714-expected.png:
platform/qt/tables/mozilla/bugs/bug78162-expected.png:
platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
platform/qt/tables/mozilla/bugs/bug8381-expected.png:
platform/qt/tables/mozilla/bugs/bug8411-expected.png:
platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
platform/qt/tables/mozilla/bugs/bug88524-expected.png:
platform/qt/tables/mozilla/bugs/bug8858-expected.png:
platform/qt/tables/mozilla/bugs/bug9072-expected.png:
platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
platform/qt/tables/mozilla/bugs/bug92143-expected.png:
platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
platform/qt/tables/mozilla/bugs/bug92868-expected.png:
platform/qt/tables/mozilla/bugs/bug93363-expected.png:
platform/qt/tables/mozilla/bugs/bug963-expected.png:
platform/qt/tables/mozilla/bugs/bug96334-expected.png:
platform/qt/tables/mozilla/bugs/bug96343-expected.png:
platform/qt/tables/mozilla/bugs/bug965-expected.png:
platform/qt/tables/mozilla/bugs/bug97138-expected.png:
platform/qt/tables/mozilla/bugs/bug97383-expected.png:
platform/qt/tables/mozilla/bugs/bug98196-expected.png:
platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
platform/qt/tables/mozilla/bugs/bug99948-expected.png:
platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
platform/qt/tables/mozilla/core/borders-expected.png:
platform/qt/tables/mozilla/core/captions-expected.png:
platform/qt/tables/mozilla/core/col_span-expected.png:
platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
platform/qt/tables/mozilla/core/margins-expected.png:
platform/qt/tables/mozilla/core/nested1-expected.png:
platform/qt/tables/mozilla/core/row_span-expected.png:
platform/qt/tables/mozilla/core/table_frame-expected.png:
platform/qt/tables/mozilla/core/table_rules-expected.png:
platform/qt/tables/mozilla/core/table_widths-expected.png:
platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
platform/qt/tables/mozilla/dom/insertCols1-expected.png:
platform/qt/tables/mozilla/dom/insertCols2-expected.png:
platform/qt/tables/mozilla/dom/insertCols3-expected.png:
platform/qt/tables/mozilla/dom/insertCols4-expected.png:
platform/qt/tables/mozilla/dom/insertCols5-expected.png:
platform/qt/tables/mozilla/dom/tableDom-expected.png:
platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
platform/qt/tables/mozilla/marvin/body_tbody-expected.png:
platform/qt/tables/mozilla/marvin/body_tfoot-expected.png:
platform/qt/tables/mozilla/marvin/body_thead-expected.png:
platform/qt/tables/mozilla/marvin/col_span-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_align_center-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_align_left-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_align_right-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_span-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png:
platform/qt/tables/mozilla/marvin/colgroup_width_px-expected.png:
platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
platform/qt/tables/mozilla/marvin/table_row_align_center-expected.png:
platform/qt/tables/mozilla/marvin/table_row_align_left-expected.png:
platform/qt/tables/mozilla/marvin/table_row_align_right-expected.png:
platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
platform/qt/tables/mozilla/marvin/table_rules_groups-expected.png:
platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
platform/qt/tables/mozilla/marvin/tables_align_center-expected.png:
platform/qt/tables/mozilla/marvin/tables_align_left-expected.png:
platform/qt/tables/mozilla/marvin/tables_align_right-expected.png:
platform/qt/tables/mozilla/marvin/tables_border_0-expected.png:
platform/qt/tables/mozilla/marvin/tables_border_1-expected.png:
platform/qt/tables/mozilla/marvin/tables_border_2-expected.png:
platform/qt/tables/mozilla/marvin/tables_border_3-expected.png:
platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
platform/qt/tables/mozilla/marvin/tables_cellpadding-expected.png:
platform/qt/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
platform/qt/tables/mozilla/marvin/tables_cellspacing-expected.png:
platform/qt/tables/mozilla/marvin/tables_class-expected.png:
platform/qt/tables/mozilla/marvin/tables_default-expected.png:
platform/qt/tables/mozilla/marvin/tables_id-expected.png:
platform/qt/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
platform/qt/tables/mozilla/marvin/tables_style-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_align_center-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_align_left-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_align_right-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_colspan-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_height-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_nowrap-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_rowspan-expected.png:
platform/qt/tables/mozilla/marvin/tables_td_width-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_align_center-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_align_left-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_align_right-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_colspan-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_height-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_rowspan-expected.png:
platform/qt/tables/mozilla/marvin/tables_th_width-expected.png:
platform/qt/tables/mozilla/marvin/tables_width_percent-expected.png:
platform/qt/tables/mozilla/marvin/tables_width_px-expected.png:
platform/qt/tables/mozilla/marvin/tbody_align_center-expected.png:
platform/qt/tables/mozilla/marvin/tbody_align_char-expected.png:
platform/qt/tables/mozilla/marvin/tbody_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/tbody_align_left-expected.png:
platform/qt/tables/mozilla/marvin/tbody_align_right-expected.png:
platform/qt/tables/mozilla/marvin/tbody_char-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_align_center-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_align_char-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_align_left-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_align_right-expected.png:
platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
platform/qt/tables/mozilla/marvin/thead_align_center-expected.png:
platform/qt/tables/mozilla/marvin/thead_align_char-expected.png:
platform/qt/tables/mozilla/marvin/thead_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/thead_align_left-expected.png:
platform/qt/tables/mozilla/marvin/thead_align_right-expected.png:
platform/qt/tables/mozilla/marvin/thead_char-expected.png:
platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
platform/qt/tables/mozilla/marvin/x_col_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_col_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_col_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_col_span-expected.png:
platform/qt/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_col_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_col_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_col_width_pct-expected.png:
platform/qt/tables/mozilla/marvin/x_col_width_px-expected.png:
platform/qt/tables/mozilla/marvin/x_col_width_rel-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_span-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
platform/qt/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
platform/qt/tables/mozilla/marvin/x_table-expected.png:
platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
platform/qt/tables/mozilla/marvin/x_table_border-expected.png:
platform/qt/tables/mozilla/marvin/x_table_border_none-expected.png:
platform/qt/tables/mozilla/marvin/x_table_border_px-expected.png:
platform/qt/tables/mozilla/marvin/x_table_cellpadding-expected.png:
platform/qt/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
platform/qt/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
platform/qt/tables/mozilla/marvin/x_table_class-expected.png:
platform/qt/tables/mozilla/marvin/x_table_frame_void-expected.png:
platform/qt/tables/mozilla/marvin/x_table_id-expected.png:
platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.png:
platform/qt/tables/mozilla/marvin/x_table_rules_none-expected.png:
platform/qt/tables/mozilla/marvin/x_table_style-expected.png:
platform/qt/tables/mozilla/marvin/x_table_width_pct-expected.png:
platform/qt/tables/mozilla/marvin/x_table_width_px-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_align_left-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_align_right-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_class-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_id-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_style-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_td_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_td_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_td_align_left-expected.png:
platform/qt/tables/mozilla/marvin/x_td_align_right-expected.png:
platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
platform/qt/tables/mozilla/marvin/x_td_height-expected.png:
platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.png:
platform/qt/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_td_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_td_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_td_width-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_class-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_id-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_style-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_th_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_th_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_th_align_left-expected.png:
platform/qt/tables/mozilla/marvin/x_th_align_right-expected.png:
platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
platform/qt/tables/mozilla/marvin/x_th_class-expected.png:
platform/qt/tables/mozilla/marvin/x_th_height-expected.png:
platform/qt/tables/mozilla/marvin/x_th_id-expected.png:
platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.png:
platform/qt/tables/mozilla/marvin/x_th_style-expected.png:
platform/qt/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_th_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_th_width-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_align_left-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_align_right-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_class-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_id-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_style-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_thead_valign_top-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_align_center-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_align_char-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
platform/qt/tables/mozilla/marvin/x_tr_valign_top-expected.png:
platform/qt/tables/mozilla/other/cellspacing-expected.png:
platform/qt/tables/mozilla/other/nested2-expected.png:
platform/qt/tables/mozilla/other/nestedTables-expected.png:
platform/qt/tables/mozilla/other/padding-expected.png:
platform/qt/tables/mozilla/other/test3-expected.png:
platform/qt/tables/mozilla/other/test6-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug17826-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug47163-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
platform/qt/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png:
platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.png:
platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.png:
platform/qt/tables/mozilla_expected_failures/core/cols1-expected.png:
platform/qt/tables/mozilla_expected_failures/core/columns-expected.png:
platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
platform/qt/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
platform/qt/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
platform/qt/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png:
platform/qt/transforms/2d/transform-borderbox-expected.png:
platform/qt/transforms/2d/transform-fixed-container-expected.png:
platform/qt/transforms/2d/transform-origin-borderbox-expected.png:
platform/qt/transforms/2d/zoom-menulist-expected.png:
platform/qt/transitions/cross-fade-background-image-expected.png:
platform/qt/transitions/cross-fade-border-image-expected.png:
platform/qt/transitions/svg-text-shadow-transition-expected.png:

2:33 AM Changeset in webkit [147088] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Fixed property text indentation in Styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=113409

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.

inspector/front-end/StylesSidebarPane.js:

2:13 AM Changeset in webkit [147087] by commit-queue@webkit.org

3 edits
2 adds in trunk

Regression: Crash when selecting Hebrew and numbers in a list
https://bugs.webkit.org/show_bug.cgi?id=111894

Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

There is a crash when trying to click/select an anonymous
renderer.

This is a regression due to r143313 which tries to add border/padding
to the computed caret rect in RenderBox::localCaretRect().
The patch calls on the node() method for the corresponding
renderer. For an anonymous renderer though, node() returns
null. Since no check had been added for this, a crash occurs when
caret rect for an anonymous renderer is being computed.

Test: editing/selection/click-on-anonymous-content-crash.html

rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):
Added a check for validating the return from the node() call.

LayoutTests:

editing/selection/click-on-anonymous-content-crash-expected.txt: Added.
editing/selection/click-on-anonymous-content-crash.html: Added.

Added a testcase for verifying that no crash occurs when trying to
select/click an anonymous renderer, in this case the list marker's
renderer.

1:59 AM Changeset in webkit [147086] by mkwst@chromium.org

5 edits
11 adds in trunk

X-Frame-Options: Multiple headers are ignored completely.
https://bugs.webkit.org/show_bug.cgi?id=113387

Reviewed by Nate Chapin.

Source/WebCore:

If a server sends multiple 'X-Frame-Options' headers, we end up with a
value like 'SAMEORIGIN, SAMEORIGIN'. Currently, we're treating that as
invalid, and ignoring the header. It would be safer to follow Gecko's
lead[1] by:

Folding duplicated entries into their common value (that is: 'sameorigin, sameorigin' -> 'sameorigin').

Failing closed in the case of conflicts (that is: 'sameorigin, allowall' -> 'deny').

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=761655

Tests: http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html

http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html

loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

Call out to parseXFrameOptionsHeader to get the header's disposition
and deal with each case in a switch statement for clarity. Add a new
console warning for the conflict case described above.

platform/network/HTTPParsers.cpp:

(WebCore::parseXFrameOptionsHeader):

platform/network/HTTPParsers.h:

Move X-Frame-Options parsing out into HTTPParsers, as it's getting
more and more complicated. To do this, the patch defines a new enum
to pass around the header's disposition.

LayoutTests:

http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-conflict.cgi: Added.
http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-sameorigin.cgi: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html: Added.
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

1:48 AM Changeset in webkit [147085] by zandobersek@gmail.com

2 edits in trunk

Unreviewed GTK build fix after r147039.

Source/autotools/symbols.filter: Export the missing symbols.

1:37 AM Changeset in webkit [147084] by commit-queue@webkit.org

3 edits
2 adds
30 deletes in trunk/LayoutTests

[CSS Regions] Convert layout tests region-style-block-background-color[2] to ref-tests
https://bugs.webkit.org/show_bug.cgi?id=86339

Patch by Mihai Tica <mitica@adobe.com> on 2013-03-28
Reviewed by Tony Chang.

This patch converts the pixel test baseline into ref-tests for the following tests:
fast/regions/region-style-block-background-color.html
fast/regions/region-style-block-background-color2.html

fast/regions/region-style-block-background-color-expected.html: Added.
fast/regions/region-style-block-background-color.html:
fast/regions/region-style-block-background-color2-expected.html: Added.
fast/regions/region-style-block-background-color2.html:
platform/chromium-linux/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/chromium-linux/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/chromium-mac-lion/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/chromium-mac-lion/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/chromium-mac/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/chromium-mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/chromium-win/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt: Removed.
platform/chromium/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/chromium/fast/regions/region-style-block-background-color2-expected.txt: Removed.
platform/efl/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/efl/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/efl/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Removed.
platform/gtk/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Removed.
platform/mac/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/mac/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Removed.
platform/qt/fast/regions/region-style-block-background-color-expected.png: Removed.
platform/qt/fast/regions/region-style-block-background-color-expected.txt: Removed.
platform/qt/fast/regions/region-style-block-background-color2-expected.png: Removed.
platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Removed.

1:30 AM Changeset in webkit [147083] by kadam@inf.u-szeged.hu

4 edits
2 copies
6 deletes in trunk/LayoutTests

Gardening. Organize expected results, because the generic expected file should be the one that uses JSC.
https://bugs.webkit.org/show_bug.cgi?id=113291.

Reviewed by Csaba Osztrogonác.

inspector/console/console-eval-syntax-error-expected.txt:
inspector/debugger/debugger-pause-in-eval-script-expected.txt:
inspector/extensions/extensions-eval-expected.txt:
platform/chromium/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-pause-in-eval-script-expected.txt.
platform/chromium/inspector/extensions/extensions-eval-expected.txt: Copied from LayoutTests/inspector/extensions/extensions-eval-expected.txt.
platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Removed.
platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
platform/mac/inspector/extensions/extensions-eval-expected.txt: Removed.
platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Removed.
platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
platform/qt/inspector/extensions/extensions-eval-expected.txt: Removed.

1:26 AM Changeset in webkit [147082] by mihnea@adobe.com

4 edits in trunk/Source/WebCore

[CSSRegions] Consolidate use of RenderRegion::isValid
https://bugs.webkit.org/show_bug.cgi?id=113154

Reviewed by David Hyatt.

After https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately than the list of valid regions.
A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code
instead of testing for both isValid() and m_flowThread.

No new tests since there is no change is functionality, just code refactoring.

rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread): Added a new function to keep the code
used in addRegionToThread and checkInvalidRegions.
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):

rendering/RenderNamedFlowThread.h:
rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect):
(WebCore::RenderRegion::computePreferredLogicalWidths):

1:25 AM Changeset in webkit [147081] by commit-queue@webkit.org

3 edits in trunk/Tools

[CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
https://bugs.webkit.org/show_bug.cgi?id=113484

Unreviewed build fix.

Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-28

TestWebKitAPI/CMakeLists.txt:
WebKitTestRunner/CMakeLists.txt:

1:09 AM Changeset in webkit [147080] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

platform/chromium/TestExpectations:

12:51 AM Changeset in webkit [147079] by zandobersek@gmail.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for the EFL and GTK ports.

runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): Pass a 0 casted to the int64_t type instead of 0LL
to the std::max call so the arguments' types match.

12:44 AM Changeset in webkit [147078] by Lucas Forschler

2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r147049. <rdar://problem/13522909>

12:42 AM Changeset in webkit [147077] by Lucas Forschler

27 edits
7 copies in tags/Safari-537.35.2

Merged r147039. <rdar://problem/13383835>

12:40 AM Changeset in webkit [147076] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Timeline. Refresh is slow when user drags the overview window.
https://bugs.webkit.org/show_bug.cgi?id=113371

Reviewed by Pavel Feldman.

The root of problem is the 300ms delay in scheduleRefresh method.
It was introduced for the case when we add a huge number of records per second.
The scheduleRefresh was written such a way that refresh happened immediately
only for the scrolling operations. Actually we would like to see fast
refresh every time when it is forced by an user action.

In this patch additional flag newRecordWasAdded was added to the
_invalidateAndScheduleRefresh. I made it mandatory because the function
is also used as a callback for an event and it is easy to make a mistake and
interpret the event as the flag.

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._onCategoryCheckboxClicked):
(WebInspector.TimelinePanel.prototype._durationFilterChanged):
(WebInspector.TimelinePanel.prototype._repopulateRecords):
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):
(WebInspector.TimelinePanel.prototype._onRecordsCleared):
(WebInspector.TimelinePanel.prototype._invalidateAndScheduleRefresh):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype.performFilter):

12:29 AM Changeset in webkit [147075] by Lucas Forschler

14 edits in tags/Safari-537.35.2

Merged r146956. <rdar://problem/13032692>

12:08 AM Changeset in webkit [147074] by Lucas Forschler

24 edits
3 copies in tags/Safari-537.35.2/Source

Merged r146929. <rdar://problem/13194263>

12:05 AM Changeset in webkit [147073] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

platform/chromium/TestExpectations:

Mar 27, 2013:

11:48 PM Changeset in webkit [147072] by Lucas Forschler

2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146928. <rdar://problem/13492038>

11:44 PM Changeset in webkit [147071] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

platform/chromium/TestExpectations:

compositing/rtl tests are failing also on Linux Debug.

11:39 PM Changeset in webkit [147070] by keishi@webkit.org

3 edits
2 adds in trunk

Dragging to edge should always snap to min/max.
https://bugs.webkit.org/show_bug.cgi?id=113477

Reviewed by Kent Tamura.

Source/WebCore:

Dragging to the edge of a slider should always snap to the min/max.

Test: fast/forms/range/range-slow-drag-to-edge.html

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

LayoutTests:

fast/forms/range/range-slow-drag-to-edge-expected.txt: Added.
fast/forms/range/range-slow-drag-to-edge.html: Added.

11:33 PM Changeset in webkit [147069] by Lucas Forschler

3 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146913. <rdar://problem/13492038>

11:32 PM Changeset in webkit [147068] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed Qt build fix after http://trac.webkit.org/changeset/147067.

WebProcess/WebPage/WebPage.cpp:

11:24 PM Changeset in webkit [147067] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

PDFPlugin: Enable PDFPlugin only if its dependencies exist on the system
https://bugs.webkit.org/show_bug.cgi?id=113372
<rdar://problem/12685301>

Reviewed by Alexey Proskuryakov.

Shared/mac/PDFKitImports.h: Wrap in #if PLATFORM(MAC).
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): Use shouldUsePDFPlugin.
(WebKit::WebPage::shouldUsePDFPlugin): If the PDFPlugin setting is enabled but PDFLayerController is not available, don't use PDFPlugin.

WebProcess/WebPage/WebPage.h:

(WebPage): Add shouldUsePDFPlugin

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformPreferencesDidChange): Use shouldUsePDFPlugin.

11:13 PM Changeset in webkit [147066] by Lucas Forschler

7 edits
5 copies in tags/Safari-537.35.2/Source/WebCore

Merged r146667. <rdar://problem/13194263>

11:10 PM Changeset in webkit [147065] by Lucas Forschler

5 edits
3 copies in tags/Safari-537.35.2

Merged r146626. <rdar://problem/13462658>

11:06 PM Changeset in webkit [147064] by Lucas Forschler

8 edits in tags/Safari-537.35.2/Source

Merged r146536. <rdar://problem/13194263>

10:57 PM Changeset in webkit [147063] by Lucas Forschler

2 edits in tags/Safari-537.35.2/Source/WebKit2

Merged r146513. <rdar://problem/13194263>

10:54 PM Changeset in webkit [147062] by Lucas Forschler

11 edits
1 copy in tags/Safari-537.35.2/Source/WebCore

Merged r146508. <rdar://problem/13194263>

10:51 PM Changeset in webkit [147061] by Lucas Forschler

2 edits in tags/Safari-537.35.2/Source/WebCore

Merged r146488. <rdar://problem/13194263>

10:24 PM Changeset in webkit [147060] by Lucas Forschler

4 edits in tags/Safari-537.35.2/Source

Versioning.

10:21 PM Changeset in webkit [147059] by Lucas Forschler

1 copy in tags/Safari-537.35.2

New Tag.

10:18 PM Changeset in webkit [147058] by Simon Fraser

7 edits in trunk/Source/WebCore

Add a way to update GraphicsLayerCA visibleRects without having to do a flush
https://bugs.webkit.org/show_bug.cgi?id=113459

Reviewed by Tim Horton.

Some platforms need to update TiledBacking visible rects from
outside of WebKit, for example if they use delegated scrolling.
They want to avoid forcing layout to be up-to-date when doing this.

Currently, updating the visibleRect happens when the GraphicsLayerCA
layer are being flushed, but that makes some assumptions about
layout being up-to-date.

To fix this, add a light-weight pass over the layer tree that
uses TransformState to compute the visibleRect for each
layer, and only if the visibleRect would cause a change in the
tiles in a TiledBacking trigger a layer flush.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::recomputeVisibleRects):

platform/graphics/TiledBacking.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveComputeVisibleRect):
(WebCore::GraphicsLayerCA::recomputeVisibleRects):
(WebCore::GraphicsLayerCA::computeVisibleRect):

platform/graphics/ca/GraphicsLayerCA.h:
platform/graphics/ca/mac/TileController.h:
platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):

10:04 PM Changeset in webkit [147057] by pdr@google.com

10 edits in trunk/Source/WebCore

Rename toScriptElement -> toScriptElementIfPossible
https://bugs.webkit.org/show_bug.cgi?id=113473

Reviewed by Ryosuke Niwa.

Rename ScriptElement::toScriptElement to ScriptElement::toScriptElementIfPossible to
differentiate this function from other to*Element functions, and to better describe the
function's behavior. Other to*Element functions do not return null if the cast fails,
whereas toScriptElementIfPossible does.

No new tests as this is just a refactoring.

dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

dom/ScriptElement.h:

(WebCore):

dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

This is the only unchecked return value but there isn't a security issue here.

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::collectOptionInnerText):

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::insertForeignElement):

html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::requestPendingScript):
(WebCore::HTMLScriptRunner::runScript):

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::notifyFinished):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement):

9:06 PM Changeset in webkit [147056] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

http/tests/cache/subresource-failover-to-network.html is failing.

platform/chromium/TestExpectations:

8:58 PM Changeset in webkit [147055] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2013-03-27 Geoffrey Garen <ggaren@apple.com>

Unreviewed build fix: Removed a dead field.

Pointed out by Mark Lam.

dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (ByteCodeParser):

8:54 PM Changeset in webkit [147054] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

2013-03-27 Geoffrey Garen <ggaren@apple.com>

Unreviewed build fix: Removed a dead field.

dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::ByteCodeParser): (ByteCodeParser):

8:41 PM Changeset in webkit [147053] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Removed some dead code in the DFG bytecode parser
https://bugs.webkit.org/show_bug.cgi?id=113472

Reviewed by Sam Weinig.

Now that Phi creation and liveness analysis are separate passes, we can
remove the vestiges of code that used to do that in the bytecode
parser.

dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::parse):

8:38 PM Changeset in webkit [147052] by weinig@apple.com

8 edits in trunk/Source/WebKit2

[WebKit2] Need SPI to determine whether a plug-in is blocked
https://bugs.webkit.org/show_bug.cgi?id=113463

Reviewed by Anders Carlsson.

Add new SPI, WKContextCopyPlugInInfoForBundleIdetifier, to get data about a plug-in,
including whether it is blocked by x-protect.

UIProcess/WebLoaderClient.cpp:
UIProcess/API/C/WKAPICast.h:

(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
Move to a shared location.

UIProcess/API/C/mac/WKContextPrivateMac.h:
UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable):
(WKPlugInInfoPathKey):
(WKPlugInInfoBundleIdentifierKey):
(WKPlugInInfoVersionKey):
(WKPlugInInfoLoadPolicyKey):
(WKPlugInInfoUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WKContextCopyPlugInInfoForBundleIdetifier):
Add new SPI and dictionary keys.

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifer):

UIProcess/Plugins/PluginInfoStore.h:
UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::findPluginWithBundleIdentifer):
Add function to lookup plug-ins by bundle identifier.

8:32 PM Changeset in webkit [147051] by shinyak@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening. Test Expectations update.

platform/chromium/TestExpectations:

8:24 PM Changeset in webkit [147050] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Debug test fix after r147018.

toElement() asserts. What we want here is isElementNode().

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::attachLater):

8:24 PM Changeset in webkit [147049] by Beth Dakin

2 edits in trunk/Source/WebKit2

WKBundlePagePrivateMac.h is not being exported
https://bugs.webkit.org/show_bug.cgi?id=113470
-and corresponding-
<rdar://problem/13522909>

Reviewed by Sam Weinig.

Mark it as private instead of project.

WebKit2.xcodeproj/project.pbxproj:

8:04 PM Changeset in webkit [147048] by noel.gordon@gmail.com

10 edits
15 adds in trunk

Add webp image color profile support
https://bugs.webkit.org/show_bug.cgi?id=113184

Reviewed by Eric Seidel.

Source/WebCore:

Requires libwebp version 0.3.0 (decoder ABI version 0x201). For images
with an ICC color profile chunk, poll the incremental decoder for the
current decoded height with the WebPIDecGetRGB() API and color correct
any newly decoded rows in-situ in the frame buffer.

Note: the ICC chunk appears before the encoded image frame in the webp
encoding (RIFF container) format. When the incremental decoder outputs
decoded pixels, enough encoded data has arrived to read the entire ICC
color profile data chunk.

Tests: fast/images/webp-color-profile-lossless.html

fast/images/webp-color-profile-lossy-alpha.html
fast/images/webp-color-profile-lossy.html

platform/image-decoders/webp/WEBPImageDecoder.cpp:

(WebCore::WEBPImageDecoder::WEBPImageDecoder):
(WebCore::WEBPImageDecoder::~WEBPImageDecoder): Call clear().
(WebCore):
(WebCore::WEBPImageDecoder::clear):
Added. Helper to clean up the webp decoder and color transform members.
(WebCore::WEBPImageDecoder::createColorTransform):
Create m_transform using the supplied profile memory data. Note that
the |deviceProfile| is not owned, but the |inputProfile| temporary is
so release it here with qcms_release_profile().
(WebCore::WEBPImageDecoder::readColorProfile):
Called once only when the decoder begins to output decoded rows of an
image containing an ICC chunk, to read the ICC color profile data from
the encoded data stream, verify it, and use it to create m_transform.
(WebCore::WEBPImageDecoder::applyColorProfile):
Since there is no row callback in libwebp, poll for the decoded height
of the image so far. If new rows are decoded, color correct the pixels
of those new rows and re-write them back into the frame buffer using
buffer.setRGBA() to 1) alpha pre-multiply the pixels if needed, and 2)
shuffle the pixel bytes into the platform's RGBA pixel endian-ness.
(WebCore::WEBPImageDecoder::decode):
If the container format indicates the image has an ICC color profile,
decode the image to RGBA format for subsequent input to the QCMS color
correction library in applyColorProfile().

platform/image-decoders/webp/WEBPImageDecoder.h:

(WEBPImageDecoder):
(WebCore::WEBPImageDecoder::colorTransform): m_transform getter.

LayoutTests:

fast/images/resources/webp-color-profile-lossless.webp: Added.
fast/images/resources/webp-color-profile-lossy-alpha.webp: Added.
fast/images/resources/webp-color-profile-lossy.webp: Added.
fast/images/webp-color-profile-lossless-expected.txt: Added.
fast/images/webp-color-profile-lossless.html: Added.
fast/images/webp-color-profile-lossy-alpha-expected.txt: Added.
fast/images/webp-color-profile-lossy-alpha.html: Added.
fast/images/webp-color-profile-lossy-expected.txt: Added.
fast/images/webp-color-profile-lossy.html: Added.
platform/chromium-mac/fast/images/webp-color-profile-lossless-expected.png: Added.
platform/chromium-mac/fast/images/webp-color-profile-lossy-alpha-expected.png: Added.
platform/chromium-mac/fast/images/webp-color-profile-lossy-expected.png: Added.
platform/chromium-win/fast/images/webp-color-profile-lossless-expected.png: Added.
platform/chromium-win/fast/images/webp-color-profile-lossy-alpha-expected.png: Added.
platform/chromium-win/fast/images/webp-color-profile-lossy-expected.png: Added.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

7:47 PM Changeset in webkit [147047] by fpizlo@apple.com

5 edits
6 adds in trunk

JIT and DFG should NaN-check loads from Float32 arrays
https://bugs.webkit.org/show_bug.cgi?id=113462
<rdar://problem/13490804>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitFloatTypedArrayGetByVal):

LayoutTests:

fast/js/dfg-float32-array-nan-expected.txt: Added.
fast/js/dfg-float32-array-nan.html: Added.
fast/js/jit-float32-array-nan-expected.txt: Added.
fast/js/jit-float32-array-nan.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-float32-array-nan.js: Added.

(foo):

fast/js/script-tests/jit-float32-array-nan.js: Added.

7:19 PM Changeset in webkit [147046] by mark.lam@apple.com

4 edits in trunk/Source/WebKit

Rolling out r147044.
https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

7:17 PM Changeset in webkit [147045] by keishi@webkit.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] Enable touch events in PagePopup
https://bugs.webkit.org/show_bug.cgi?id=113380

We want to use touch events inside the calendar picker. This patch adds
PagePopupChromeClient::needTouchEvents() and moved hasTouchEventHandlers()
from WebViewClient to WebWidgetClient.

Reviewed by Kent Tamura.

public/WebViewClient.h:
public/WebWidgetClient.h:

(WebWidgetClient):
(WebKit::WebWidgetClient::hasTouchEventHandlers): Moved from WebViewClient.

src/WebPagePopupImpl.cpp:

(WebKit):

6:55 PM Changeset in webkit [147044] by mark.lam@apple.com

4 edits in trunk/Source/WebKit

Greening the Apple Win bot (debug build).
https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

6:40 PM Changeset in webkit [147043] by mark.lam@apple.com

4 edits in trunk/Source/WebKit

Greening the Apple Win bot.
https://bugs.webkit.org/show_bug.cgi?id=113352.

Not Reviewed.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

6:35 PM Changeset in webkit [147042] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Refactor validation checks for texture uploads
https://bugs.webkit.org/show_bug.cgi?id=111012

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-03-27
Reviewed by Kenneth Russell.

Move the validation checks to the entry level of tex{Sub}Image2D, return early for invalid parameters and avoid duplicated checks.
Moreover, turn all the validation checks at the bottom level - tex{Sub}Image2DBase into assertions.

Already covered by current tests.

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::validateTexFunc): A helper function for tex{Sub}Image2D to check input parameters.
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::validateHTMLImageElement):
(WebCore::WebGLRenderingContext::validateHTMLCanvasElement):
(WebCore::WebGLRenderingContext::validateHTMLVideoElement):

html/canvas/WebGLRenderingContext.h:

6:11 PM Changeset in webkit [147041] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

remove parentsOnly variable in codeGenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=113457

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

Remove unused variable parentsOnly.

No new tests: no change in behaviour.

bindings/scripts/CodeGenerator.pm:

(ForAllParents):
(AddMethodsConstantsAndAttributesFromParentInterfaces):
(ParseInterface):
(InheritsInterface):
(InheritsExtendedAttribute):

bindings/scripts/CodeGeneratorV8.pm:

(BaseInterfaceName):

5:47 PM Changeset in webkit [147040] by Patrick Gansterer

4 edits in trunk

Set WTF_ARM_ARCH_VERSION to correct value when used with MSVC
https://bugs.webkit.org/show_bug.cgi?id=113436

Reviewed by Benjamin Poulain.

Source/cmake/OptionsWinCE.cmake: CPU(ARM_TRADITIONAL) is now set correctly by Platform.h.

Source/WTF:

The Microsoft compiler defines _M_ARM with used ARM version.

wtf/Platform.h:

5:42 PM Changeset in webkit [147039] by Beth Dakin

27 edits
7 adds in trunk

Need WK2 API to give a WebView a header and footer
https://bugs.webkit.org/show_bug.cgi?id=113352
-and corresponding-
<rdar://problem/13383835>

Reviewed by Simon Fraser.

Source/WebCore:

This API will require RenderLayerCompositor to keep layers for the header and
footer when the exist. It also requires the scrolling machinery to know that the
size of the scrollable area will differ from the contentsSize when there is a
header or footer.

setWantsLayerForHeader() and setWantsLayerForFooter() return GraphicsLayers to
WK2. setHeaderHeight() and setFooterHeight() set the header and footer heights
respectively.

WebCore.exp.in:
page/FrameView.h:

(FrameView):

page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::setWantsLayerForHeader):
(WebCore::FrameView::setWantsLayerForFooter):
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):

Should use totalContentsSize() instead of contentsSize().
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::isScrollable):

page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

This should also use totalContentsSize() instead of contentsSize(), and while
we're at it, re-name the variable and function names in the scrolling tree code
from contentsSize to totalContentsSize.

page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setTotalContentsSize):
(WebCore::ScrollingStateScrollingNode::dumpProperties):

page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::totalContentsSize):
(ScrollingStateScrollingNode):

page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):

page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::totalContentsSize):
(ScrollingTreeScrollingNode):

page/scrolling/mac/ScrollingCoordinatorMac.h:

(ScrollParameters):

page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinatorMac::setScrollParametersForNode):

page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::updateAfterChildren):
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):

Use totalContentsSize() instead of contentsSize().

platform/ScrollView.cpp:

(WebCore::ScrollView::maximumScrollPosition):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::overhangAmount):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::calculateOverhangAreasForPainting):

scrollOffset() represents the offset within the totalContentsSize, but that is
not what we need here. So subtract out the headerHeight() for the appropriate
value.
(WebCore::ScrollView::windowToContents):
(WebCore::ScrollView::contentsToWindow):

Use totalContentsSize() instead of contentsSize().

platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::maximumScrollPosition):
(WebCore):
(WebCore::ScrollableArea::totalContentsSize):

platform/ScrollableArea.h:

(WebCore::ScrollableArea::headerHeight):
(WebCore::ScrollableArea::footerHeight):
(ScrollableArea):

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):
(WebCore::ScrollAnimatorMac::pinnedInDirection):

platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::ensuredView):

The rootContentLayer needs to be offset by the headerHeight().

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateRootLayerPosition):

New member variables m_layerForHeader and m_layerForFooter. This code properly
creates and manages them.
(WebCore::RenderLayerCompositor::updateLayerForBottomOverhangArea):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::computeFixedViewportConstraints):
(WebCore::RenderLayerCompositor::reportMemoryUsage):

rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

Test infrastructure.

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore):
(WebCore::Internals::setFooterHeight):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit2:

New API allows setting and getting layers for a header and footer.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/c/mac: Added.
WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h: Added.
WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm: Added.

(WKBundlePageGetHeaderLayer):
(WKBundlePageSetHeaderLayer):
(WKBundlePageGetFooterLayer):
(WKBundlePageSetFooterLayer):

WebProcess/WebPage/WebPage.h:

(WebPage):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::setTopOverhangImage):
(WebKit::WebPage::setBottomOverhangImage):
(WebKit):
(WebKit::WebPage::getHeaderLayer):
(WebKit::WebPage::setHeaderLayerWithHeight):
(WebKit::WebPage::getFooterLayer):
(WebKit::WebPage::setFooterLayerWithHeight):

LayoutTests:

platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-expected.txt: Added.
platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale-expected.txt: Added.
platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing-with-page-scale.html: Added.
platform/mac-wk2/tiled-drawing/header-and-footer-hit-testing.html: Added.

5:41 PM Changeset in webkit [147038] by commit-queue@webkit.org

8 edits
2 adds in trunk

javascriptcore bindings do not check exception after calling valueToStringWithNullCheck
https://bugs.webkit.org/show_bug.cgi?id=113219

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

Source/WebCore:

When converting JSValue to native value in attribute setter, store the
native value in a temporary variable. After this variable assignment,
always check if an exception has been raised.

Update binding tests.

Test: fast/dom/exception-in-binding.html

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GetNativeType):
(JSValueToNative):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalNode):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjConstructorStaticStringAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjTypedArrayAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjAnyAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsImmutableSerializedScriptValue):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):
(WebCore::setJSTestTypedefsStringAttrWithGetterException):
(WebCore::setJSTestTypedefsStringAttrWithSetterException):

LayoutTests:

fast/dom/exception-in-binding-expected.txt: Added.
fast/dom/exception-in-binding.html: Added.
platform/chromium/TestExpectations: new test fails for now

5:39 PM Changeset in webkit [147037] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

cache parsed interfaces in CodeGenerator.pm
https://bugs.webkit.org/show_bug.cgi?id=113446

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-27
Reviewed by Kentaro Hara.

When generating binding for an interface, informations about parent
interfaces are sometimes needed several times. This patch caches
those the parsed interface. When generating all WebCore bindings, this
results in a speedup of about 40% for JavaScriptCore and about 80% for
V8.

No new tests: no change in behaviour.

bindings/scripts/CodeGenerator.pm:

(ParseInterface):

5:33 PM Changeset in webkit [147036] by Claudio Saavedra

54 edits in trunk/LayoutTests

Explicitly set editingBehavior in some tests.
https://bugs.webkit.org/show_bug.cgi?id=113383

Reviewed by Ryosuke Niwa.

These tests make assumptions on how word selection works.
Actually, word selection will work differently depending on the
editingBehavior in place, see bug 110487, so the only way to
ensure the following tests will do word selection as expected is
to use Mac editing behavior.

editing/deleting/delete-by-word-001.html: Call setEditingBehavior("mac").
editing/deleting/list-item-1.html: ditto.
editing/deleting/non-smart-delete.html: ditto.
editing/deleting/smart-delete-002.html: ditto.
editing/deleting/smart-delete-across-editable-boundaries.html: ditto.
editing/execCommand/hilitecolor.html: ditto.
editing/execCommand/remove-formatting-2.html: ditto.
editing/inserting/4960120-2.html: ditto.
editing/inserting/insert-paragraph-02.html: ditto. ditto.
editing/inserting/insert-paragraph-03.html: ditto.
editing/inserting/insert-paragraph-04.html: ditto.
editing/inserting/paragraph-outside-nested-divs.html: ditto.
editing/inserting/paragraph-separator-01.html: ditto.
editing/inserting/paragraph-separator-02.html: ditto.
editing/inserting/paragraph-separator-03.html: ditto.
editing/pasteboard/4242293-1.html: ditto.
editing/pasteboard/4806874.html: ditto.
editing/pasteboard/5006779.html: ditto.
editing/pasteboard/8145-2.html: ditto.
editing/pasteboard/bad-placeholder.html: ditto.
editing/pasteboard/copy-text-with-backgroundcolor.html: ditto.
editing/pasteboard/drag-drop-modifies-page.html: ditto.
editing/pasteboard/get-data-text-plain-drop.html: ditto.
editing/pasteboard/insert-div-text-into-text.html: ditto.
editing/pasteboard/merge-end-3.html: ditto.
editing/pasteboard/merge-end-5.html: ditto.
editing/pasteboard/merge-end-borders.html: ditto.
editing/pasteboard/paste-blockquote-3.html: ditto.
editing/pasteboard/paste-list-004.html: ditto.
editing/pasteboard/pasting-object.html: ditto.
editing/selection/4932260-2.html: ditto.
editing/selection/extend-by-word-002.html: ditto.
editing/selection/extend-forward-by-word-over-non-editable.html: ditto.
editing/selection/transformed-selection-rects.html: ditto.
editing/style/5046875-1.html: ditto.
editing/style/5046875-2.html: ditto.
editing/style/fore-color-by-name.html: ditto.
editing/style/relative-font-size-change-002.html: ditto.
editing/style/relative-font-size-change-003.html: ditto.
editing/style/relative-font-size-change-004.html: ditto.
editing/style/style-boundary-005.html: ditto.
editing/text-iterator/first-letter-word-boundary.html: ditto.
editing/undo/undo-combined-delete-boundary.html: ditto.
editing/undo/undo-combined-delete.html: ditto.
editing/undo/undo-delete-boundary.html: ditto.
editing/undo/undo-delete.html: ditto.
editing/undo/undo-forward-delete-boundary.html: ditto.
editing/undo/undo-forward-delete.html: ditto.
fast/dom/34176.html: ditto.
platform/chromium-win/editing/deleting/non-smart-delete-expected.txt: Updated.
platform/efl/editing/deleting/non-smart-delete-expected.txt: Updated.
platform/gtk/editing/deleting/non-smart-delete-expected.txt: Updated.
platform/qt/editing/deleting/non-smart-delete-expected.txt: Updated.

5:29 PM Changeset in webkit [147035] by Claudio Saavedra

1 edit
20 moves in trunk/LayoutTests

Rename Editing tests whose expectations are Mac specific
https://bugs.webkit.org/show_bug.cgi?id=113414

Reviewed by Ryosuke Niwa.

These tests have expectations that assume that word selection
works always as in Mac and therefore will break when ran with
editingBehavior set, for instance, to Windows (see bug
110487). Rename them to have the suffix -mac and explicitly set
editingBehavior to Mac.

When the fix for 110487 lands, counterparts to these tests with
suffix -win, editingBehavior set to win, and updated expectations
will be added.

editing/deleting/smart-editing-disabled-mac-expected.txt:

Renamed from
LayoutTests/editing/deleting/smart-editing-disabled-expected.txt.

editing/deleting/smart-editing-disabled-mac.html: Renamed from

LayoutTests/editing/deleting/smart-editing-disabled.html.

editing/execCommand/remove-format-multiple-elements-mac-expected.txt:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements-expected.txt.

editing/execCommand/remove-format-multiple-elements-mac.html:

Renamed from
LayoutTests/editing/execCommand/remove-format-multiple-elements.html.

editing/execCommand/script-tests/remove-format-multiple-elements-mac.js:

Renamed from
LayoutTests/editing/execCommand/script-tests/remove-format-multiple-elements.js.

editing/execCommand/script-tests/toggle-link-mac.js: Renamed

from LayoutTests/editing/execCommand/script-tests/toggle-link.js.

editing/execCommand/toggle-link-mac-expected.txt: Renamed from

LayoutTests/editing/execCommand/toggle-link-expected.txt.

editing/execCommand/toggle-link-mac.html: Renamed from

LayoutTests/editing/execCommand/toggle-link.html.

editing/style/make-text-writing-direction-inline-mac-expected.txt:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline-expected.txt.

editing/style/make-text-writing-direction-inline-mac.html:

Renamed from
LayoutTests/editing/style/make-text-writing-direction-inline.html.

editing/style/push-down-font-styles-mac-expected.txt: Renamed

from LayoutTests/editing/style/push-down-font-styles-expected.txt.

editing/style/push-down-font-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-implicit-styles.html.

editing/style/push-down-implicit-styles-around-list-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list-expected.txt.

editing/style/push-down-implicit-styles-around-list-mac.html:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-around-list.html.

editing/style/push-down-implicit-styles-mac-expected.txt:

Renamed from
LayoutTests/editing/style/push-down-implicit-styles-expected.txt.

editing/style/push-down-implicit-styles-mac.html: Renamed from

LayoutTests/editing/style/push-down-font-styles.html.

editing/style/script-tests/make-text-writing-direction-inline-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/make-text-writing-direction-inline.js.

editing/style/script-tests/push-down-font-styles-mac.js: Renamed

from
LayoutTests/editing/style/script-tests/push-down-font-styles.js.

editing/style/script-tests/push-down-implicit-styles-around-list-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles-around-list.js.

editing/style/script-tests/push-down-implicit-styles-mac.js:

Renamed from
LayoutTests/editing/style/script-tests/push-down-implicit-styles.js.

5:25 PM Changeset in webkit [147034] by commit-queue@webkit.org

9 edits
2 adds in trunk

Add a settings to disallow initializing background-size if background shorthand doesn't include it.
https://bugs.webkit.org/show_bug.cgi?id=113363

Source/WebCore:

Patch by KyungTae Kim <ktf.kim@samsung.com> and Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-27
Reviewed by David Kilzer.

This is based on KyungTae Kim's patch in https://bugs.webkit.org/show_bug.cgi?id=97761. Many legacy sites set
background-size first and then set background for setting background-image. For backward-compatibility
in some WebKit based clients, if 'background' shorthand have no 'background-size' attribute, we could add
a settings to let the css parser not initialize 'background-size'.

Test: fast/backgrounds/background-shorthand-after-set-backgroundSize.html

css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext): initialize useLegacyBackgroundSizeShorthandBehavior.
(WebCore::operator==):
(WebCore::CSSParser::useLegacyBackgroundSizeShorthandBehavior): add a method to return if we want background-size

to be initialized by background shorthand.

(WebCore):
(WebCore::CSSParser::parseFillShorthand): don't initialize background-size in background shorthand if we have

useLegacyBackgroundSizeShorthandBehavior set to true.

css/CSSParser.h:

(CSSParser):

css/CSSParserMode.h: add member useLegacyBackgroundSizeShorthandBehavior to CSSParserContext.

(CSSParserContext):

page/Settings.in: initialize useLegacyBackgroundSizeShorthandBehavior to false.
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): add the new settings useLegacyBackgroundSizeShorthandBehavior to Backup.
(WebCore::InternalSettings::Backup::restoreTo): restore useLegacyBackgroundSizeShorthandBehavior from Backup.
(WebCore::InternalSettings::setUseLegacyBackgroundSizeShorthandBehavior):
(WebCore):

testing/InternalSettings.h:

(Backup):
(InternalSettings):

testing/InternalSettings.idl: add a JS testing API setUseLegacyBackgroundSizeShorthandBehavior to turn on/off

the new settings.

LayoutTests:

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-03-27
Reviewed by David Kilzer.

Add test for the new settings useLegacyBackgroundSizeShorthandBehavior.

fast/backgrounds/background-shorthand-after-set-backgroundSize-expected.txt: Added.
fast/backgrounds/background-shorthand-after-set-backgroundSize.html: Added.

5:18 PM Changeset in webkit [147033] by fmalita@chromium.org

2 edits in trunk/Source/WebCore

Remove unused RenderLayer::renderBox{X,Y} methods
https://bugs.webkit.org/show_bug.cgi?id=113408

Reviewed by Simon Fraser.

Minor cleanup - renderBoxX() and renderBox() are no longer used.

No new tests: no functional changes.

rendering/RenderLayer.h:

5:18 PM Changeset in webkit [147032] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Show compositing on the Inspector timeline properly
https://bugs.webkit.org/show_bug.cgi?id=113416

Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-27
Reviewed by Rob Buis.

The call to willComposite was too early and encompased the paint calls
as well. Moving it lower will no longer encompass the paints.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):

5:16 PM Changeset in webkit [147031] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Web Inspector: Plumb and expose cookie clearing options throughout the Resources Cookies tree and views
https://bugs.webkit.org/show_bug.cgi?id=87140

Patch by PhistucK <phistuck@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

Added cookie clearing buttons and context menu options
throughout the tree and views.
Drive by -

Made sure the delete button is only visible

when a cookie is selected.

Fixed a wrong JSDoc comment.

inspector/front-end/CookieItemsView.js:

(WebInspector.CookieItemsView):
(WebInspector.CookieItemsView.prototype.statusBarItems):
(WebInspector.CookieItemsView.prototype._updateWithCookies):
(WebInspector.CookieItemsView.prototype.clear):
Added. Clears the entire cookie view.
(WebInspector.CookieItemsView.prototype._clearButtonClicked):
Added. Ditto (when clicking on the button).
(WebInspector.CookieItemsView.prototype._showDeleteButton):
Added. Shows the delete button when selecting a cookie row.

inspector/CookiesTable.js:

(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._clearAndRefresh):
Added. Clears the cookies of the current table and updates it.
(WebInspector.CookiesTable.prototype._handleContextMenuEvent):
Added. Manages the context menu within the table.
(WebInspector.CookiesTable.prototype.clear):
Added. Clears the cookies of the current table.
(WebInspector.CookiesTable.prototype.setCookies):

Fixed a wrong JSDoc comment structure.

inspector/front-end/ResourcesPanel.js:

(WebInspector.ResourcesPanel.prototype.clearCookies):
Added. Clears the cookies of the given domain view.
(WebInspector.CookieTreeElement.prototype.onattach):
Added. Adds a contextmenu handler.
(WebInspector.CookieTreeElement.prototype._handleContextMenuEvent):
Added. Manages the context menu within cookie tree.
(WebInspector.CookieTreeElement.prototype._clearCookies):
Added. Clears the cookies of the view of the tree item.

inspector/front-end/treeoutline.js:

(TreeOutline): Fixed a wrong JSDoc comment.

English.lproj/localizedStrings.js:

Added strings for the context menu options.

5:14 PM Changeset in webkit [147030] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: [DTE] implement "tokenAtTextPosition" method
https://bugs.webkit.org/show_bug.cgi?id=113390

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/editor/text-editor-token-at-position.html

Add TextEditor.tokenAtTextPosition method
Implement tokenAtTextPosition method in DefaultTextEditor

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.tokenAtTextPosition):
(WebInspector.TextEditorMainPanel.prototype.compare):
(WebInspector.TextEditorMainPanel.prototype.tokenAtTextPosition):
(WebInspector.TextEditorMainPanel.prototype._tokenAtUnhighlightedLine):
(WebInspector.TextEditorMainPanel.prototype.set mimeType):
(WebInspector.TextEditorMainPanel.prototype.get mimeType):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.tokenAtTextPosition):

inspector/front-end/TextEditorHighlighter.js:

(WebInspector.TextEditorHighlighter):
(WebInspector.TextEditorHighlighter.prototype.get mimeType):
(WebInspector.TextEditorHighlighter.prototype.set mimeType):

LayoutTests:

Add a test to verify TextEditor.tokenAtTextPosition method.

inspector/editor/text-editor-token-at-position-expected.txt: Added.
inspector/editor/text-editor-token-at-position.html: Added.

5:13 PM Changeset in webkit [147029] by charles.wei@torchmobile.com.cn

13 edits in trunk/Source/WebCore

Remove build warning for unused function parameters in indexeddb.
https://bugs.webkit.org/show_bug.cgi?id=113043

Reviewed by Tony Chang.

No new tests, just remove build warning.

Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onBlocked):
(WebCore::IDBCallbacks::onUpgradeNeeded):

Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::stringToDirection):

Modules/indexeddb/IDBCursor.h:

(IDBCursor):

Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::prefetchReset):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::setIndexesReady):

Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):

Modules/indexeddb/IDBLevelDBCoding.cpp:

(IDBLevelDBCoding):

Modules/indexeddb/IDBObjectStore.cpp:

(WebCore):
(WebCore::IDBObjectStore::openCursor):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::stringToMode):

Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

inspector/InspectorIndexedDBAgent.cpp:

(WebCore):

5:11 PM Changeset in webkit [147028] by commit-queue@webkit.org

6 edits in trunk

REGRESSION (r146588): Cannot correctly display Chinese SNS Renren
https://bugs.webkit.org/show_bug.cgi?id=113142

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

Source/WebCore:

Changed CSS grammar to be equivalent to pre-r146588.
CSS error reporting disabled to prevent message overflow.

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::isLoggingErrors):

LayoutTests:

TestExpectations:
fast/css/parsing-error-recovery.html:

5:10 PM Changeset in webkit [147027] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: enhance Popover.js to rely on hover element coordinates
https://bugs.webkit.org/show_bug.cgi?id=113340

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

Introduce a coordinates-based method that checks if mouse is inside hover
element and use it in PopoverHelper instead of DOM hierarchy.

inspector/front-end/Popover.js:

(WebInspector.PopoverHelper.prototype._eventInHoverElement): Added.
(WebInspector.PopoverHelper.prototype._mouseDown):
(WebInspector.PopoverHelper.prototype._mouseMove):
(WebInspector.PopoverHelper.prototype._mouseOut):

5:08 PM Changeset in webkit [147026] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] fix webinspector-css theme for CodeMirror
https://bugs.webkit.org/show_bug.cgi?id=113399

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Alexander Pavlov.

Add style rule to highlight css properties for CodeMirror
webinspector-css theme.

No new tests: no change in behaviour.

inspector/front-end/cm/cmdevtools.css:

(.cm-s-web-inspector-css span.cm-property):

5:05 PM Changeset in webkit [147025] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [DTE] paint overlay highlight for unhighlighted lines
https://bugs.webkit.org/show_bug.cgi?id=113344

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Pavel Feldman.

No new tests.

Remove fast-return condition from paintLine method that checked for
highlight existence.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._paintLine):

5:02 PM Changeset in webkit [147024] by anilsson@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Populate the mime type of the WebContext for images
https://bugs.webkit.org/show_bug.cgi?id=113272

Reviewed by George Staikos.

PR 278967

Populate the mime type using the file extension reported by the image
decoder. This way we benefit from file type sniffing, instead of
relying on the mime type reported by the resource response.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):

5:01 PM Changeset in webkit [147023] by commit-queue@webkit.org

2 edits in trunk/Tools

Revision for the internal jhbuild is too old
https://bugs.webkit.org/show_bug.cgi?id=113324

Patch by Mario Sanchez Prada <mario.prada@samsung.com> on 2013-03-27
Reviewed by Martin Robinson.

Update the minimum required version to a point where jhbuild won't
fail installing packages when trying to remove a symlink to a directory.

jhbuild/jhbuild-wrapper: Updated revision.

5:01 PM Changeset in webkit [147022] by rniwa@webkit.org

9 edits
2 adds in trunk

Shift clicking on an element with -webkit-user-select: all doesn't extend selection
https://bugs.webkit.org/show_bug.cgi?id=113270

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by updateSelectionForMouseDownDispatchingSelectStart always replacing selection whenever
the target node was inside an element with -webkit-suer-select even when we were attemping to extend selection
in handleMousePressEventSingleClick.

Fixed the bug by extracting this logic as a separate function (expandSelectionToRespectUserSelectAll) and deploying
it in handleMousePressEventSingleClick to extend selection as needed.

Test: editing/selection/user-select-all-with-shift.html

page/EventHandler.cpp:

(WebCore::expandSelectionToRespectUserSelectAll): Extracted from updateSelectionForMouseDownDispatchingSelectStart.
(WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart):
(WebCore::EventHandler::selectClosestWordFromHitTestResult):
(WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventTripleClick):
(WebCore::EventHandler::handleMousePressEventSingleClick): Adjust "pos" as needed when extending selection.
Also use shouldConsiderSelectionAsDirectional() instead of manually peeking editingBehaviorType while we're at it.

LayoutTests:

Added a regression test for shift clicking on an element with -webkit-user-select: all.
Skip it on non-Mac platforms as -webkit-user-select: all hasn't been enabled on them.

editing/selection/user-select-all-with-shift-expected.txt: Added.
editing/selection/user-select-all-with-shift.html: Added.
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

4:59 PM Changeset in webkit [147021] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION(r143102): iframe with percentage height within table with anonymous cell fails.
https://bugs.webkit.org/show_bug.cgi?id=113077

Source/WebCore:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-27
Reviewed by Antti Koivisto.

http://www.w3.org/TR/CSS21/visuren.html#anonymous-block-level
"Anonymous block boxes are ignored when resolving percentage values that would refer to it:
the closest non-anonymous ancestor box is used instead."
When figuring out whether auto height needs to be applied on the current box, ignore anonymous
ancestors until the first non-anonymous containing block is found. This matches both
Firefox and Opera behaviour.

Test: fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight): Switch from
isAnonymousBlock() to isAnonymous() to make sure all anonymous boxes are ignored.
Remove isTableCell() check which is a noop as table cell isn't an anonymous block.

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-03-27
Reviewed by Antti Koivisto.

fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell-expected.txt: Added.
fast/replaced/iframe-with-percentage-height-within-table-with-anonymous-table-cell.html: Added.

4:57 PM Changeset in webkit [147020] by pierre.rossi@gmail.com

6 edits in trunk

[Qt] Add WOFF support when using zlib
https://bugs.webkit.org/show_bug.cgi?id=112805

Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Covered by existing test:
fast/css/font-face-woff.html

Target.pri: Conditional inclusion of WOFFFileFormat
platform/graphics/qt/FontCustomPlatformDataQt.cpp:

(WebCore::createFontCustomPlatformData): Try to unpack WOFF data, otherwise spit out a warning and bail.
(WebCore::FontCustomPlatformData::supportsFormat): accept WOFF webfonts if USE(ZLIB).

LayoutTests:

platform/qt-5.0-wk2/TestExpectations: keep skipped for WK2 due to a WTR bug.
platform/qt/TestExpectations: unskip font-face-woff.html

4:49 PM Changeset in webkit [147019] by robert@webkit.org

7 edits
2 adds in trunk

Growing a position:absolute element in a position:relative one in a table does not update scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=111977

Reviewed by David Hyatt.

Source/WebCore:

During simplified layout tables still need to know about overflow from positioned objects in any of
their cells.

Test: fast/table/cell-overflow-simplified-layout.html

rendering/RenderBlock.h:

(RenderBlock):

rendering/RenderTable.cpp:

(WebCore::RenderTable::simplifiedNormalFlowLayout):
(WebCore):

rendering/RenderTable.h:
rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::layoutRows):
(WebCore):
(WebCore::RenderTableSection::computeOverflowFromCells):

rendering/RenderTableSection.h:

(RenderTableSection):

LayoutTests:

fast/table/cell-overflow-simplified-layout-expected.html: Added.
fast/table/cell-overflow-simplified-layout.html: Added.

4:45 PM Changeset in webkit [147018] by ggaren@apple.com

5 edits
2 adds in trunk

Honor the setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=113122

Reviewed by Ryosuke Niwa.

Source/WebCore:

dom/ScriptableDocumentParser.cpp:

(WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Applied the
setting here, so all document parsing would be covered. This is similar
to what we do for plug-in stripping.

html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertForeignElement): Fixed a bug where
we would insert an SVG script element into the document even in script
markup disabled mode.

(This bug has existed for copy/paste for a long time, but other bugs and
quirks in SVG copy/paste papered over it. It's a serious issue now
that non-paste clients will rely on this mode.)

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Fixed the same
bug -- this time in the part of the parser that executes scripts as they
parse.

I adopted the toScriptElement() convention for testing for a script
element to match the XML parser.

LayoutTests:

editing/unsupported-content/script-markup-enabled-setting-expected.txt: Added.
editing/unsupported-content/script-markup-enabled-setting.html: Added.

4:37 PM Changeset in webkit [147017] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

CodeCache::m_capacity can becoming negative, producing undefined results in pruneSlowCase
https://bugs.webkit.org/show_bug.cgi?id=113453

Reviewed by Geoffrey Garen.

runtime/CodeCache.cpp:

(JSC::CodeCacheMap::pruneSlowCase): We make sure that m_minCapacity doesn't drop below zero now.
This prevents m_capacity from doing the same.

4:12 PM Changeset in webkit [147016] by kov@webkit.org

2 edits in trunk/Tools

[GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
https://bugs.webkit.org/show_bug.cgi?id=113203

Reviewed by Philippe Normand.

We build our libsoup without GNOME support. gst-plugins-good does separate
pkg-config checks for libsoup-gnome and libsoup, causing the build to use
libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
build failures as the headers of those diverge. We do not use souphttpsrc, so
disable it when building gst-plugins-good.

gtk/jhbuild.modules: disable soup support in gst-plugins-good.

4:12 PM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

4:09 PM Changeset in webkit [147015] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

Tamil translation for Gnome 3.6
https://bugs.webkit.org/show_bug.cgi?id=96995

Patch by Shantha kumar <shkumar@redhat.com> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

ta.po: Added.

3:58 PM Changeset in webkit [147014] by fpizlo@apple.com

27 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: JITCode should abstract exactly how the JIT code is structured and where it was allocated
https://bugs.webkit.org/show_bug.cgi?id=113437

Reviewed by Mark Hahnenberg.

JITCode is now a virtual base class, which will allow different JITs to have radically
different memory allocation and management conventions in the future. It will also
make it easier to store JIT-specific meta-data in CodeBlock just by putting it into
an appropriate JITCode subclass.

For now there is one subclass, DirectJITCode, which just behaves like JITCode used to
behave.

assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::getJITType):
(CodeBlock):

dfg/DFGDriver.cpp:

(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

dfg/DFGDriver.h:

(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

dfg/DFGJITCompiler.h:

(JITCompiler):

dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::codeLocationForRepatch):

dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

dfg/DFGOperations.cpp:
interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

jit/JIT.cpp:

(JSC::JIT::privateCompile):

jit/JIT.h:

(JSC::JIT::compile):
(JIT):

jit/JITCode.cpp:

(JSC):
(JSC::JITCode::JITCode):
(JSC::JITCode::~JITCode):
(JSC::JITCode::execute):
(JSC::JITCode::hostFunction):
(JSC::DirectJITCode::DirectJITCode):
(JSC::DirectJITCode::~DirectJITCode):
(JSC::DirectJITCode::addressForCall):
(JSC::DirectJITCode::executableAddressAtOffset):
(JSC::DirectJITCode::dataAddressAtOffset):
(JSC::DirectJITCode::offsetOf):
(JSC::DirectJITCode::size):
(JSC::DirectJITCode::contains):

jit/JITCode.h:

(JSC):
(JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
(JSC::JITCode::isOptimizingJIT):
(JSC::JITCode::isBaselineCode):
(JSC::JITCode::jitType):
(JSC::JITCode::jitTypeFor):
(JSC::JITCode::executableAddress):
(JSC::JITCode::start):
(JSC::JITCode::end):
(DirectJITCode):

jit/JITDriver.h:

(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):

jit/JITStubs.cpp:

(JSC::lazyLinkFor):
(JSC::DEFINE_STUB_FUNCTION):

jit/ThunkGenerators.cpp:

(JSC::virtualForGenerator):

llint/LLIntEntrypoints.cpp:

(JSC::LLInt::getFunctionEntrypoint):
(JSC::LLInt::getEvalEntrypoint):
(JSC::LLInt::getProgramEntrypoint):

llint/LLIntEntrypoints.h:

(JSC):
(LLInt):
(JSC::LLInt::getEntrypoint):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::ExecutableBase::generatedJITCodeFor):
(ExecutableBase):
(JSC::ExecutableBase::hostCodeEntryFor):
(JSC::ExecutableBase::jsCodeEntryFor):
(JSC::ExecutableBase::jsCodeWithArityCheckEntryFor):
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
(JSC::EvalExecutable::generatedJITCode):
(JSC::ProgramExecutable::generatedJITCode):

runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

3:43 PM Changeset in webkit [147013] by jer.noble@apple.com

3 edits in trunk/Source/WebKit2

Going full screen and cancelling gets system into a weird state
https://bugs.webkit.org/show_bug.cgi?id=113445

Reviewed by Eric Carlson.

Replace an array of BOOL member variables to track full screen state with a single enum, and
add state tracking for the "waiting to enter" and "waiting to exit" states. Use this new,
more specific enum to be more stringent about the state when responding to WebProcess
messages. Also only set the placeholder view's target once in full screen mode.

UIProcess/mac/WKFullScreenWindowController.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController isFullScreen]): Yes when in full screen, entering full screen,

or waiting to enter full screen.

(-[WKFullScreenWindowController cancelOperation:]): Only requestExitFullScreen() if a watchdog

has not already been made active.

(-[WKFullScreenWindowController enterFullScreen:]): Use the new state variable.
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Ditto. Set the placeholder target.
(-[WKFullScreenWindowController exitFullScreen]): Ditto. Clear the placeholder target.
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:WebCore::finalFrame:WebCore::]): Ditto.
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]): Ditto.
(-[WKFullScreenWindowController performClose:]): Ditto.
(-[WKFullScreenWindowController close]): Ditto.
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]): Ditto.

3:07 PM Changeset in webkit [147012] by dino@apple.com

2 edits in trunk/Source/WebCore

Chromium Mac fails to build after r146995 because the new NSFont category
may conflict with the system. Add the WebCoreTheme category to the whitelist.

Unreviewed.

WebCore.gyp/WebCore.gyp:

2:56 PM Changeset in webkit [147011] by rniwa@webkit.org

2 edits in trunk/Tools

Build fix after r146852. Please another reference to the Lion leaks builder.

BuildSlaveSupport/build.webkit.org-config/config.json:

2:31 PM Changeset in webkit [147010] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Blind attempt at fixing the release build.

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::willCacheResponseAsync):

2:04 PM Changeset in webkit [147009] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/win

Another Windows build fix attempt after r147004.

WebKit.vcproj/WebKitExports.def.in:

1:51 PM Changeset in webkit [147008] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Selection code spends a lot of time in InlineTextBox::localSelectionRect
https://bugs.webkit.org/show_bug.cgi?id=113364

Reviewed by Enrica Casucci.

Avoid computing the font width when we're selecting the entire line box.

This appears to be 25-26% improvement on Interactive/SelectAll:Time.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::localSelectionRect):

1:47 PM Changeset in webkit [147007] by timothy@apple.com

1 edit in trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in

Windows build fix attempt.

1:38 PM Changeset in webkit [147006] by beidson@apple.com

5 edits
2 adds in trunk/Source/WebKit2

Mem mapped resource data improvements.
<rdar://problem/13196481> and https://bugs.webkit.org/show_bug.cgi?id=113422

Reviewed by Alexey Proskuryakov (and looked over by Geoff Garen).

Remove timer-based approach support code:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::abortInProgressLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):

NetworkProcess/NetworkResourceLoader.h:

Add an object to encapsulate monitoring a resource going in to the disk cache.
It listens for a callback on the cached response indicating it is disk backed
and also sets a timeout so we don't keep the monitor alive and waiting forever.

NetworkProcess/mac/DiskCacheMonitor.h: Added.

(WebKit::DiskCacheMonitor::destinationID):
(WebKit::DiskCacheMonitor::connectionToWebProcess):
(WebKit::DiskCacheMonitor::resourceRequest):

NetworkProcess/mac/DiskCacheMonitor.mm: Added.

(CFCachedURLResponseSetBecameFileBackedCallBackBlock):
(WebKit::monitorFileBackingStoreCreation):
(WebKit::DiskCacheMonitor::DiskCachingMonitor):
(WebKit::DiskCacheMonitor::connection):

Refactoring and monitor certain cached responses:

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(CFCachedURLResponseGetMemMappedData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse): Use CFCachedURLResponseGetMemMappedData

to explicitly get an mem-mapped data object.

(WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):
(WebKit::NetworkResourceLoader::willCacheResponseAsync): If the resource is over the minimum

size then set up a disk caching monitor.

WebKit2.xcodeproj/project.pbxproj:

1:35 PM Changeset in webkit [147005] by timothy@apple.com

2 adds in trunk/Source/WebKit2/Resources

Add missing images from my previous commit.

1:34 PM Changeset in webkit [147004] by timothy@apple.com

48 edits
1 delete in trunk

Add support for dock-to-right of the Web Inspector in the Mac port.

Unfortunately this requires Safari changes, so it is disabled in the nightly builds.

https://webkit.org/b/113341
rdar://problem/10368152

Reviewed by Joseph Pecoraro.

Source/autotools/symbols.filter:

Source/WebCore:

WebCore.exp.in:
inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

inspector/InspectorFrontendClientLocal.cpp:

(WebCore):
(WebCore::InspectorFrontendClientLocal::frontendLoaded):
(WebCore::InspectorFrontendClientLocal::requestSetDockSide):
(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::setAttachedWindow):
(WebCore::InspectorFrontendClientLocal::constrainedAttachedWindowWidth):

inspector/InspectorFrontendClientLocal.h:

(InspectorFrontendClientLocal):

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::setAttachedWindowWidth):
(WebCore):

inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/front-end/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.setAttachedWindowWidth):

inspector/front-end/externs.js:

(InspectorFrontendHostAPI.prototype.setAttachedWindowWidth):

testing/Internals.cpp:

Source/WebKit/chromium:

src/InspectorFrontendClientImpl.cpp:

(WebKit::InspectorFrontendClientImpl::changeAttachedWindowWidth):

src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit/efl:

WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorFrontendClientEfl::attachWindow):
(WebCore::InspectorFrontendClientEfl::setAttachedWindowWidth):

WebCoreSupport/InspectorClientEfl.h:

(InspectorFrontendClientEfl):

Source/WebKit/gtk:

WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorFrontendClient::attachWindow):
(WebKit::InspectorFrontendClient::setAttachedWindowWidth):

WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient):

Source/WebKit/mac:

Resources/Dock.pdf: Updated.
WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::setAttachedWindowWidth):
(-[WebInspectorWindowController attachWindow:]):
(-[WebInspectorWindowController attach]):
(-[WebInspectorWindowController detach]):

WebInspector/WebInspectorFrontend.mm:

(-[WebInspectorFrontend attach]):

Source/WebKit/qt:

WebCoreSupport/InspectorClientQt.cpp:

(WebCore::InspectorFrontendClientQt::frontendLoaded):
(WebCore::InspectorFrontendClientQt::attachWindow):
(WebCore::InspectorFrontendClientQt::setAttachedWindowWidth):

WebCoreSupport/InspectorClientQt.h:

(InspectorFrontendClientQt):

Source/WebKit/win:

WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::setAttachedWindowWidth):

WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

Source/WebKit2:

Resources/Dock.pdf: Removed.
Resources/DockBottom.pdf: Added.
Resources/DockRight.pdf: Added.
Shared/WebPreferencesStore.h:
UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::attachBottom):
(WebKit::WebInspectorProxy::attachRight):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::setAttachedWindowWidth):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

UIProcess/WebInspectorProxy.h:

(WebInspectorProxy):

UIProcess/WebInspectorProxy.messages.in:
UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter attachRight:]):
(-[WKWebInspectorProxyObjCAdapter attachBottom:]):
(-[WKWebInspectorWindow _cursorForResizeDirection:]):
(-[WKWebInspectorWindow _customTitleFrame]):
(WebKit::createDockButton):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
(WebKit::WebInspectorProxy::platformInspectedWindowWidth):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):

WebKit2.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::attachWindow):
(WebKit::WebInspectorFrontendClient::setAttachedWindowWidth):

WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::attachBottom):
(WebKit::WebInspector::attachRight):
(WebKit::WebInspector::setAttachedWindowWidth):
(WebKit::WebInspector::attachedBottom):
(WebKit::WebInspector::attachedRight):
(WebKit::WebInspector::detached):

WebProcess/WebPage/WebInspector.h:

(WebInspector):

WebProcess/WebPage/WebInspector.messages.in:

12:55 PM Changeset in webkit [147003] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Slovenian translation
https://bugs.webkit.org/show_bug.cgi?id=113151

Patch by Matej Urbančič <mateju@svn.gnome.org> on 2013-03-27
Reviewed by Gustavo Noronha Silva (kov).

sl.po: translation update.

11:54 AM Changeset in webkit [147002] by zandobersek@gmail.com

16 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r146992.

platform/gtk/fast/hidpi/video-controls-in-hidpi-expected.txt:
platform/gtk/fast/layers/video-layer-expected.txt:
platform/gtk/media/audio-controls-rendering-expected.txt:
platform/gtk/media/audio-repaint-expected.txt:
platform/gtk/media/controls-after-reload-expected.txt:
platform/gtk/media/controls-strict-expected.txt:
platform/gtk/media/controls-styling-strict-expected.txt:
platform/gtk/media/controls-without-preload-expected.txt:
platform/gtk/media/video-controls-rendering-expected.txt:
platform/gtk/media/video-display-toggle-expected.txt:
platform/gtk/media/video-empty-source-expected.txt:
platform/gtk/media/video-no-audio-expected.txt:
platform/gtk/media/video-playing-and-pause-expected.txt:
platform/gtk/media/video-volume-slider-expected.txt:
platform/gtk/media/video-zoom-controls-expected.txt:

11:45 AM Changeset in webkit [147001] by eric.carlson@apple.com

14 edits
2 adds in trunk

[Mac] webkitClosedCaptionsVisible doesn't work
https://bugs.webkit.org/show_bug.cgi?id=113417

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-in-band-legacy-api.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Delete m_disableCaptions, it is no longer used.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Pass this to textTrackSelectionScore.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Delete m_disableCaptions, it is no longer used.

html/HTMLMediaElement.h: Ditto.

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::textTrackSelectionScore): Add an HTMLMediaElement parameter.

page/CaptionUserPreferences.h:

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Return a score if the media element

is showing captions, even if the preference says captions are disabled.

LayoutTests:

media/track/track-in-band-legacy-api-expected.txt: Added.
media/track/track-in-band-legacy-api.html: Added.

platform/chromium/TestExpectations: Skip new test.
platform/efl/TestExpectations: Ditto.
platform/gtk/TestExpectations: Ditto.
platform/mac/TestExpectations: Ditto.
platform/qt/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.

11:33 AM Changeset in webkit [147000] by eric.carlson@apple.com

5 edits in trunk

[Mac] Text track menu items sometimes labeled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113406

Reviewed by Jer Noble.

Source/WebCore:

media/video-controls-captions-trackmenu-localized.html was updated to test this.

page/CaptionUserPreferencesMac.mm:

(WebCore::trackDisplayName): Use the 'label' attribute for the menu text when necessary.

LayoutTests:

media/video-controls-captions-trackmenu-localized.html:
platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:

11:26 AM Changeset in webkit [146999] by sergio@webkit.org

6 edits in trunk

Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode
https://bugs.webkit.org/show_bug.cgi?id=113413

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a "normal" insert instead of a replace when there is
nothing to replace (like at the end of a line) as this case is not
supported by the replacing code path. This will allow us to
properly rebalance whitespaces in those cases.

Updated the editing/execCommand/overtype.html test to check also
this use case.

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): use the recently added
setEndingSelectionWithoutValidation() to avoid code duplication.

editing/InsertTextCommand.h:

(InsertTextCommand):

LayoutTests:

Updated the test to include the case of inserting a whitespace
both in the middle or at the end of a line.

editing/execCommand/overtype-expected.txt:
editing/execCommand/overtype.html:

11:17 AM Changeset in webkit [146998] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
https://bugs.webkit.org/show_bug.cgi?id=113421

Reviewed by Dirk Pranke.

When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
in the GTK-specific TestExpectations files.

To avoid this only enable the warnings only when not using WKTR.

Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.warn_if_bug_missing_in_test_expectations):

10:54 AM Changeset in webkit [146997] by rniwa@webkit.org

2 edits
1 add in trunk/PerformanceTests

Add a performance tests for selecting all content in a document
https://bugs.webkit.org/show_bug.cgi?id=113358

Reviewed by Levi Weintraub.

Add a performance test for selecting all. We wait for paint to happen by setTimeout(~, 0).

Example outputs:

RESULT Interactive: SelectAll: Time= 652.6 ms
median= 644.5 ms, stdev= 54.6177144967 ms, min= 599.0 ms, max= 773.0 ms

RESULT Interactive: SelectAll: Time= 654.4 ms
median= 633.5 ms, stdev= 55.9223145368 ms, min= 600.0 ms, max= 769.0 ms

RESULT Interactive: SelectAll: Time= 657.9 ms
median= 640.0 ms, stdev= 54.1420159833 ms, min= 604.0 ms, max= 774.0 ms

Interactive/SelectAll.html: Added.
Skipped:

10:54 AM Changeset in webkit [146996] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG should use CheckStructure for typed array checks whenever possible
https://bugs.webkit.org/show_bug.cgi?id=113374

Reviewed by Geoffrey Garen.

We used to do the right thing, but it appears that this regressed at some point. Since the
FixupPhase now has the ability to outright remove spurious CheckStructures on array
operations, it is profitable for the ByteCodeParser to insert CheckStructures whenver there
is a chance that it might be profitable, and when the profiling tells us what structure to
check.

Also added some code for doing ArrayProfile debugging.

This is a slightly speed-up. Maybe 3% on Mandreel.

bytecode/ArrayProfile.cpp:

(JSC::ArrayProfile::computeUpdatedPrediction):

dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::benefitsFromStructureCheck):

10:53 AM Changeset in webkit [146995] by dino@apple.com

4 edits in trunk/Source/WebCore

[Mac] Use fontName rather than familyName for internal fonts
https://bugs.webkit.org/show_bug.cgi?id=113392
<rdar://problem/13474743>

Reviewed by Enrica Casucci.

Some internal fonts on OS X have a family name that
isn't listed in availableFontFamilies. In this case
we should use the font name rather than the family
name when looking for a match.

platform/mac/ThemeMac.h: NSFont category to provide a web-friendly family name.
platform/mac/ThemeMac.mm:

(-[NSFont webCoreFamilyName]): Returns the font name for internal fonts, otherwise the family name.
(WebCore::ThemeMac::controlFont):

rendering/RenderThemeMacShared.mm: Use the webCoreFamilyName.

(WebCore::RenderThemeMacShared::systemFont): Ditto.
(WebCore::RenderThemeMacShared::setFontFromControlSize): Ditto.

10:45 AM Changeset in webkit [146994] by zandobersek@gmail.com

7 edits
2 moves
8 adds
1 delete in trunk/LayoutTests

Unreviewed GTK gardening.

Addressing layout test failures that are specific to GTK-WK1 by moving the related expectations into the specific
TestExpectations file or adjusting and moving the baselines into the GTK-WK1 baseline search path.

platform/gtk-wk1/TestExpectations:
platform/gtk-wk1/fast: Added.
platform/gtk-wk1/fast/media: Added.
platform/gtk-wk1/fast/media/mq-transform-02-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-02-expected.html.
platform/gtk-wk1/fast/media/mq-transform-03-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-03-expected.html.
platform/gtk-wk2/TestExpectations:
platform/gtk/TestExpectations:
platform/gtk/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
platform/gtk/fast/dom/HTMLLinkElement/subresource-expected.txt: Added.
platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt:
platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt:
platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt:
platform/gtk/fast/media/mq-transform-02-expected.html: Removed.
platform/gtk/fast/media/mq-transform-03-expected.html: Removed.
platform/gtk/fast/preloader: Added.
platform/gtk/fast/preloader/document-write-2-expected.txt: Added.
platform/gtk/fast/preloader/document-write-expected.txt: Added.
platform/gtk/fast/preloader/script-expected.txt: Added.
platform/gtk/http/tests/security/XFrameOptions: Removed.
platform/gtk/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed.
platform/gtk/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed.

10:32 AM Changeset in webkit [146993] by allan.jensen@digia.com

3 edits in trunk/Source/WTF

Support C++11 static_assert
https://bugs.webkit.org/show_bug.cgi?id=113308

Reviewed by Alexey Proskuryakov.

Use the C++11 static_assert for COMPILE_ASSERT when it is available. Note that
even when compiling with C++11 support, static_assert will not always be available
since Assertions.h may also be used outside of C++.

C11 _Static_assert is enabled for GCC when it has C11 support (gcc>=4.7 -std=c11).

wtf/Assertions.h:
wtf/Compiler.h:

9:43 AM Changeset in webkit [146992] by jer.noble@apple.com

27 edits
1 add in trunk

Source/WebCore: Source/WebCore: Mac: Media Controls always hide time display elements
https://bugs.webkit.org/show_bug.cgi?id=113355

Reviewed by Eric Carlson.

No new tests; rebaselined existing tests against correct behavior.

A prior commit set the "min-width:0" property on the time display elements, which, combined
with the "-webkit-flex-box:0 0" setting, caused the flex-box container to collapse the width
of the elements to zero. To achieve the desired effect of hiding the time display elements,
first set the elements' min-width to the desired width, as the new flex-box spec treats the
default value of "min-width:auto" as the intrinsic width, and will collapse the text display
elements to the intrinsic width of its contained text node.

The above allows the timeline container to collapse beyond the sum of its childrens'
intrinsic width. Create a custom renderer that detects when this happens, and hide the time
display controls.

css/mediaControls.css:
css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):

Set the "min-width:" property to equal the "width:" property.

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):

Ditto.

css/mediaControlsChromium.css:

(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):

Chromium assumes the time display controls are flex-boxes, so make that explicit.

html/shadow/MediaControlElementTypes.cpp: Removed MediaControlTimeDisplayElement::createRenderer().
html/shadow/MediaControlElementTypes.h:

(MediaControlTimeDisplayElement): Ditto.

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden): Added, walks through the

container's children and shows or hides time display elements.

(WebCore::MediaControlTimelineContainerElement::createRenderer): Added, creates a RenderMediaControlTimelineContainer.
(WebCore::getMediaControlTimeRemainingDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to

query against children's shadowPseudoId().

(WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Moved contents to getMediaControlTimeRemainingDisplayElementShadowPseudoId.
(WebCore::getMediaControlCurrentTimeDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to

query against children's shadowPseudoId().

(WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Moved contents to getMediaControlCurrentTimeDisplayElementShadowPseudoId.

html/shadow/MediaControlElements.h:

(MediaControlTimelineContainerElement):

rendering/RenderMediaControlElements.cpp:

(WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer): Added, simple constructor.
(WebCore::RenderMediaControlTimelineContainer::layout): Detect when the controller's width is greater than

a certain value, and show or hide the time display elements in response.

rendering/RenderMediaControlElements.h:

(RenderMediaControlTimelineContainer):

LayoutTests: Mac: Media Controls always hide time display elements
https://bugs.webkit.org/show_bug.cgi?id=113355

Reviewed by Eric Carlson.

Rebaseline mac results.

platform/mac/media/audio-controls-rendering-expected.png:
platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-after-reload-expected.png:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-strict-expected.png:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/controls-styling-strict-expected.png: Added.
platform/mac/media/controls-styling-strict-expected.txt:
platform/mac/media/controls-without-preload-expected.png:
platform/mac/media/controls-without-preload-expected.txt:
platform/mac/media/video-controls-rendering-expected.png:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.png:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-no-audio-expected.png:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-playing-and-pause-expected.png:
platform/mac/media/video-playing-and-pause-expected.txt:

9:09 AM Changeset in webkit [146991] by Antti Koivisto

2 edits in trunk/Tools

Fix Zalan's email.

Scripts/webkitpy/common/config/committers.py:

8:50 AM Changeset in webkit [146990] by Csaba Osztrogonác

3 edits in trunk/Tools

master.cfg cleanup
https://bugs.webkit.org/show_bug.cgi?id=113195

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

8:44 AM Changeset in webkit [146989] by Csaba Osztrogonác

3 edits in trunk/Tools

master.cfg fine-tuning for Qt Mountain Lion Release bot
https://bugs.webkit.org/show_bug.cgi?id=113191

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/build.webkit.org-config/config.json:
- Rename the slave due to its location change.
- Update the platform of the slave.
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunQtAPITests): Enable running WK2 API tests on Qt.
(RunQtAPITests.start):
(RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
(BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)

8:36 AM Changeset in webkit [146988] by rakuco@webkit.org

2 edits in trunk/Tools

[EFL][jhbuild] Evas fails to build when Wayland is present on the system
https://bugs.webkit.org/show_bug.cgi?id=113403

Reviewed by Kenneth Rohde Christiansen.

As of Evas 1.7.5, when Wayland is detected on the system, support for
both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
The code, however, seems to depend on a few other flags which must be
explicitly enabled.

If those additional GL-related options are passed, we end up
having issues on the WebKit side, so disable Wayland support for
now.

efl/jhbuild.modules:

8:35 AM Changeset in webkit [146987] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: CPU profiler. Swap FlameChart with Data Grid.
https://bugs.webkit.org/show_bug.cgi?id=113395

Reviewed by Pavel Feldman.

Looks like FlameChart is more powerful and flexible instrument
than plain old ProfileTree in DataGrid. The same action like
'look for the most expensive function in a frame' could be easily
done with FlameChart and need number of clicks in DataGrid.
So in an offline discussion we decided to place FlameChart on top of DataGrid.

inspector/front-end/CPUProfileView.js:

7:53 AM Changeset in webkit [146986] by Chris Fleizach

4 edits in trunk

Regression in tests due to https://bugs.webkit.org/show_bug.cgi?id=113339
https://bugs.webkit.org/show_bug.cgi?id=113361

Source/WebCore:

Fix the red bots. No review.

Ensure only pop-up buttons get the AXRequired attribute instead of all buttons.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

Remove skipped tests.

platform/mac/TestExpectations:

7:48 AM Changeset in webkit [146985] by zarvai@inf.u-szeged.hu

1 edit
14 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Cleanup after r146756 and r146786.

platform/qt/fast/frames/frame-set-scaling-rotate-expected.txt: Removed.
platform/qt/fast/frames/frame-set-scaling-skew-expected.txt: Removed.
platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed.
platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Removed.
platform/qt/fast/reflections/reflection-masks-expected.txt: Removed.
platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed.
platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Removed.
platform/qt/fast/repaint/background-misaligned-expected.txt: Removed.
platform/qt/fast/repaint/overhanging-float-detach-repaint-expected.txt: Removed.
platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed.
platform/qt/fast/replaced/border-radius-clip-content-edge-expected.txt: Removed.
platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Removed.
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed.
platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed.

7:46 AM Changeset in webkit [146984] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-2.0.0

Tagging the WebKitGTK+ 2.0.0 release

7:37 AM Changeset in webkit [146983] by vsevik@chromium.org

13 edits in trunk

Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added.
https://bugs.webkit.org/show_bug.cgi?id=113381

Reviewed by Pavel Feldman.

Source/WebCore:

Breakpoint manager now restores breakpoints on UISourceCodeAdded event.
Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._uiSourceCodeAdded):
(WebInspector.BreakpointManager.prototype._resetBreakpoints):
(WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged):

inspector/front-end/CompilerScriptMapping.js:

(WebInspector.CompilerScriptMapping.prototype.get isIdentity):

inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping.prototype.isIdentity):

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.isIdentity):

inspector/front-end/SASSSourceMapping.js:

(WebInspector.SASSSourceMapping.prototype.isIdentity):

inspector/front-end/ScriptSnippetModel.js:

(WebInspector.SnippetScriptMapping.prototype.isIdentity):

inspector/front-end/SourceMapping.js:

(WebInspector.SourceMapping.prototype.isIdentity):

inspector/front-end/StylesSourceMapping.js:

(WebInspector.StylesSourceMapping.prototype.isIdentity):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.setSourceMapping):

LayoutTests:

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:

7:27 AM Changeset in webkit [146982] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Fixed assertion failure in debug mode after r146975.

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):

7:22 AM Changeset in webkit [146981] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: FlameChart. Provide 15px padding left for the chart so developers will see the first divider with '0' title.
https://bugs.webkit.org/show_bug.cgi?id=113404

Reviewed by Pavel Feldman.

15px paddingLeft was added to the code for the chart.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype.draw):

7:18 AM Changeset in webkit [146980] by dominik.rottsches@intel.com

6 edits in trunk

Unreviewed, rolling out r146864.
http://trac.webkit.org/changeset/146864
https://bugs.webkit.org/show_bug.cgi?id=113391

causes crashes on Wk2 EFL release bot (Requested by drott on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-27

Source/cmake/OptionsEfl.cmake:

Tools:

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

platform/efl/TestExpectations:

7:14 AM Changeset in webkit [146979] by rakuco@webkit.org

3 edits in trunk/Tools

[jhbuild] Correctly specify an alternate number of make jobs.
https://bugs.webkit.org/show_bug.cgi?id=113396

Reviewed by Philippe Normand.

So far, we were using the `MAKEFLAGS' environment variable to pass the
number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
other hand, prefers to use the `jobs' variable from jhbuildrc for that.

We now behave more closely to the rest of the WebKit tools by first
checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
not set, just letting jhbuild itself figure out how many jobs to use.

efl/jhbuildrc:
gtk/jhbuildrc:

4:10 AM Changeset in webkit [146978] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Remove a duplicated test from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=113385

Unreviewed, EFL gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-03-27

platform/efl/TestExpectations:

4:06 AM Changeset in webkit [146977] by tkent@chromium.org

16 edits in trunk/Source

Rename HTMLFormControlElement::readOnly to isReadOnly
https://bugs.webkit.org/show_bug.cgi?id=113297

Reviewed by Alexey Proskuryakov.

Source/WebCore:

HTMLFormControlElement::readOnly is not an implementation of
'readOnly' IDL attribute. It's confusing and we don't need to
violate our naming convention.

No new tests. Just a refactoring.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseAttribute):

html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isReadOnly):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass):
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):

html/shadow/TextControlInnerElements.cpp:

(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult):

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::updateImage):

rendering/RenderTextControl.cpp:

(WebCore::updateUserModifyProperty):

rendering/RenderThemeMacShared.mm:

(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):

Source/WebKit/chromium:

src/WebFormControlElement.cpp:

(WebKit::WebFormControlElement::isReadOnly):

Source/WebKit/win:

DOMHTMLClasses.cpp:

(DOMHTMLInputElement::readOnly):

4:04 AM Changeset in webkit [146976] by zeno.albisser@digia.com

8 edits in trunk

[Qt] Remove Qt specific WorkQueueItem definitions.
https://bugs.webkit.org/show_bug.cgi?id=112891

This patch is preparation work for removing
WorkQueue related code from TestRunnerQt and
replacing it with generic TestRunner code.

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

API/JSStringRefQt.cpp:

(JSStringCreateWithQString):

Adding a convenience function to create a
JSStringRef from a QString.

API/JSStringRefQt.h:

Tools:

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunner::queueLoad):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

DumpRenderTree/qt/WorkQueueItemQt.cpp:

(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(LoadAlternateHTMLStringItem::invoke):
(ReloadItem::invoke):
(ScriptItem::invoke):
(BackForwardItem::invoke):

DumpRenderTree/qt/WorkQueueItemQt.h:

(LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
(LoadAlternateHTMLStringItem):

3:27 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:29 AM Changeset in webkit [146975] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats
https://bugs.webkit.org/show_bug.cgi?id=113376

Reviewed by Vsevolod Vlasov.

Added missing fields to Timeline.TimelineEvent type definition in Inspector.json

inspector/Inspector.json:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setDOMCounters):
Switched InspectorTimelineAgent to the new typed event builders.
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

2:03 AM Changeset in webkit [146974] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 2.0.0 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 2.0.0.

1:33 AM Changeset in webkit [146973] by vsevik@chromium.org

4 edits in trunk

Web Inspector: Follow-up to r146898: test that uiSourceCodes are not leaking in breakpoint manager.
https://bugs.webkit.org/show_bug.cgi?id=113368

Reviewed by Pavel Feldman.

Source/WebCore:

Added a missed line and a test.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._projectWillReset):

LayoutTests:

inspector/debugger/breakpoint-manager.html:

1:12 AM Changeset in webkit [146972] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] CodeMirrorTextEditor.highlightRange has bugs
https://bugs.webkit.org/show_bug.cgi?id=113348

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests.

Append additional "<class>-start" class to the first highlighted span

and "<class>-end" class to the last highlighted span to provide a way
to set up a css classes with borders.

Increment end column of the markup range to simulate inclusive range.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):

1:04 AM Changeset in webkit [146971] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: Add isClean/markClean method pair to textEditor.js
https://bugs.webkit.org/show_bug.cgi?id=112815

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27
Reviewed by Vsevolod Vlasov.

No new tests: no change in behaviour.

Add TextEditor.isClean and TextEditor.markClean methods
Implement these methods in DefaultTextEditor
Implement these methods in CodeMirrorTextEditor

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.isClean):
(WebInspector.CodeMirrorTextEditor.prototype.markClean):

inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.isClean):
(WebInspector.DefaultTextEditor.prototype.markClean):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.isClean):
(WebInspector.TextEditor.prototype.markClean):

inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

1:01 AM Changeset in webkit [146970] by loislo@chromium.org

6 edits in trunk/Source/WebCore

Unreviewed. Web Inspector. rename method Timeline.Calculator.grandMinimumBoundary to Timeline.Calculator.zeroTime

No changes in behaviour.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.Calculator.prototype.zeroTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.zeroTime):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkBaseCalculator.prototype.zeroTime):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.Calculator.prototype.zeroTime):

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewCalculator.prototype.zeroTime):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelineCalculator.prototype.zeroTime):

12:31 AM Changeset in webkit [146969] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Timeline. Scroll dividers with the underlying events.
https://bugs.webkit.org/show_bug.cgi?id=113315

Reviewed by Pavel Feldman.

Now when TimelineGrid is able to draw dividers with any offset
we could cut away paddingLeft member of Timeline.Calculator
and clear the code of TimelineGrid.

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelineCalculator.prototype.computePosition):
(WebInspector.TimelineCalculator.prototype.setDisplayWindow):
(WebInspector.TimelineCalculator.prototype.grandMinimumBoundary):

inspector/front-end/inspectorCommon.css:

(.resources-dividers-label-bar):

12:08 AM Changeset in webkit [146968] by commit-queue@webkit.org

10 edits in trunk/Source

[CoordGfx] Support to share GraphicsSurface flags with client.
https://bugs.webkit.org/show_bug.cgi?id=112982

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-27
Reviewed by Noam Rosenthal.

Covered by existing WebGL tests.

Source/WebCore:

This patch adds support to pass GraphicsSurface flags during it's client creation.
This would be helpful to determine cases when blending can be disabled on client
side i.e When AlphaSupport is disabled during Graphics Surface creation.
With GLX, we rely on Window to provide us with necessary information on client side.
This might not be the case on other platforms or when not using Window on X.
This patch doesn't change original behaviour of creating GraphicsSurface client
with default flags GraphicsSurface::SupportsTextureTarget and GraphicsSurface::SupportsSharing.

platform/graphics/texmap/TextureMapperPlatformLayer.h:

(WebCore::TextureMapperPlatformLayer::graphicsSurfaceFlags):

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded):

platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(CoordinatedGraphicsLayerState):

platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore):
(WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags):

platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initializeClient):

Source/WebKit2:

This patch adds support to pass GraphicsSurface flags
during it's client creation.

Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

Mar 26, 2013:

11:39 PM Changeset in webkit [146967] by tasak@google.com

3 edits
2 adds in trunk

[shadow] styleForText should consider the case where parent node has no style
https://bugs.webkit.org/show_bug.cgi?id=113275

Source/WebCore:

If a text node is distributed, its parent node for rendering and
styling might have no style. In the case, styleForText should return
default style.

Reviewed by Hajime Morrita.

Test: fast/dom/shadow/text-node-distributed-crash.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForText):
Check whether a parent node has any style or not. If not, return
default style. This is the same behavior as styleForElement.

LayoutTests:

Reviewed by Hajime Morrita.

fast/dom/shadow/text-node-distributed-crash-expected.txt: Added.
fast/dom/shadow/text-node-distributed-crash.html: Added.

11:02 PM Changeset in webkit [146966] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/replaced/border-radius-clip-content-edge.html

platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:

10:03 PM Changeset in webkit [146965] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Make SocketStreamHandle (Chromium port) fully use IPC window in send()
https://bugs.webkit.org/show_bug.cgi?id=113304

Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-03-26
Reviewed by Kent Tamura.

socket_stream of Chromium buffers send data up to 32KiB (exact) bytes.

However, SocketStreamHandleInternal::send() method now keeps in-flight
send data not greater than m_maxPendingSendAllowed - 1 that is
32KiB - 1. This means that SocketStreamHandleInternal consumes the
buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory
copy operations unaligned unnecessarily. It should just use the
allowed size fully.

platform/network/chromium/SocketStreamHandle.cpp:

(WebCore::SocketStreamHandleInternal::send):
(WebCore):

8:49 PM Changeset in webkit [146964] by oliver@apple.com

2 edits in trunk/Source/WTF

RefCountedArray needs a size based constructor
https://bugs.webkit.org/show_bug.cgi?id=113277

Reviewed by Benjamin Poulain.

Simple patch to add a size based constructor for RefCountedArray
so that we can create an sharable array without a copy.

wtf/RefCountedArray.h:

(RefCountedArray):
(WTF::RefCountedArray::RefCountedArray):

8:02 PM Changeset in webkit [146963] by pdr@google.com

3 edits in trunk/LayoutTests

Rebaseline expectations for fast/replaced/border-radius-clip-content-edge.html

Unreviewed rebaseline of test expectations after r146955

platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:

7:49 PM Changeset in webkit [146962] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit/mac

Unreviewed attempted cr-mac build fix.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

7:40 PM Changeset in webkit [146961] by hayato@chromium.org

41 edits in trunk/Source

Allow ShadowContents in HitTests by default.
https://bugs.webkit.org/show_bug.cgi?id=113171

Reviewed by Dimitri Glazkov.

Source/WebCore:

HitTestRequest is widely used in WebCore, but AllowShadowContents
flag is not turned on by default. In most places, we can set the
flag on.

This change makes HitTests allow shadow contents by default.

To track all existing HitTests which do not allow shadow contents,
and discourage such a HitTest in the future, I've introduced
disallowShadowContenet flag so that callers must turn on this flag
explicitly if they want to disallow shadow contents in their HitTests.

This change should be refactoring and should not include any
behavior changes. After this change, we'll investigate each place
where disallowShadowContents is used step by step and get rid of
the flag if it is okay to remove.

No new tests, no behavior change.

dom/Document.h:

(Document):

dom/TreeScope.cpp:

(WebCore::nodeFromPoint):

editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):

page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureLongPress):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::handleTouchEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

page/EventHandler.h:

(EventHandler):

page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

page/Frame.cpp:

(WebCore::Frame::visiblePositionForPoint):

page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

rendering/HitTestRequest.h:

(WebCore::HitTestRequest::disallowsShadowContent):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::addNodeToRectBasedTestResult):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::hitTestClipContent):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::hitTestResult):

WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):

Source/WebKit/chromium:

src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspelledWord):

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::visiblePositionForWindowPoint):

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::isRectTopmost):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTapNode):

Source/WebKit/efl:

ewk/ewk_frame.cpp:

(ewk_frame_hit_test_new):

Source/WebKit/gtk:

webkit/webkitwebinspector.cpp:

(webkit_web_inspector_inspect_coordinates):

webkit/webkitwebview.cpp:

(prepareMouseEventForFrame):
(webkit_web_view_get_hit_test_result):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame elementAtPoint:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/qt:

WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::hitTestContent):

Source/WebKit/win:

WebView.cpp:

(WebView::gestureNotify):

Source/WebKit2:

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):

7:20 PM Changeset in webkit [146960] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Memory leak in WebPagePrivate.cpp - NavigatorContentUtilsClientBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=112996

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.

PR 312552
Internally Reviewed by Anthony Scian.

NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(),
but not deleted anywhere. Fixed by creating an OwnPtr for it.
Also fixed some webkit-style errors.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

Api/WebPage_p.h:

(WebCore):
(WebPagePrivate):

7:20 PM Changeset in webkit [146959] by wangxianzhu@chromium.org

5 edits
2 copies
2 deletes in branches/chromium/1410

Merge 146940 "Non-paintsContent fixed position layer should not ..."

Non-paintsContent fixed position layer should not cause slow scrolling
https://bugs.webkit.org/show_bug.cgi?id=113238

Reviewed by James Robinson.

Source/WebCore:

Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

LayoutTests:

compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.

TBR=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/12499009

6:22 PM Changeset in webkit [146958] by mark.lam@apple.com

2 edits in trunk/LayoutTests

Greening the mac bots.
https://bugs.webkit.org/show_bug.cgi?id=113361.

Not Reviewed.

platform/mac/TestExpectations:

6:21 PM Changeset in webkit [146957] by danakj@chromium.org

6 edits
5 deletes in trunk/Source

[chromium] Remove the WebVideoFrame, WebVideoFrameProvider, WebStreamTextureClient, and WebVideoLayer classes.
https://bugs.webkit.org/show_bug.cgi?id=112483

Reviewed by James Robinson.

Source/Platform:

These classes are no longer used, so remove them. And remove APIs
to provide them.

Platform.gypi:
chromium/public/WebCompositorSupport.h:

(WebKit):

chromium/public/WebVideoFrame.h: Removed.
chromium/public/WebVideoFrameProvider.h: Removed.
chromium/public/WebVideoLayer.h: Removed.

Source/WebKit/chromium:

These classes are no longer used, so remove them.

WebKit.gyp:
public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer):

public/WebStreamTextureClient.h: Removed.
public/WebVideoFrame.h: Removed.

6:20 PM Changeset in webkit [146956] by timothy_horton@apple.com

14 edits in trunk

[ca] Tell CA to clean up unused resources if a given WebProcess won't be drawing
https://bugs.webkit.org/show_bug.cgi?id=107539
<rdar://problem/13032692>

Reviewed by Simon Fraser.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Update WebCoreSystemInterface.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage): Initially move the Page out of the window if necessary;
Page defaults to in-window, which is wrong in many cases - we depend on
Page::isInWindow being accurate to decide whether WebPage::setIsInWindow is actually
a state change or not.
(WebKit::WebPage::setIsInWindow):

WebProcess/WebProcess.cpp: Inform WebProcess when we go on/off screen.

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pageDidMoveOnscreen): Keep track of the number of on-screen pages in this process.
(WebKit::WebProcess::pageWillMoveOffscreen): If the number of on-screen pages drops to zero, clean up unused rendering resources.

WebProcess/WebProcess.h:

Update WebSystemInterface.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

6:00 PM Changeset in webkit [146955] by Antti Koivisto

10 edits in trunk

Test if non-immediate descendants obscure background
https://bugs.webkit.org/show_bug.cgi?id=113137

Reviewed by Simon Fraser.

Source/WebCore:

The current obscuration test only covers immediate children. We can find more cases by looking deeper into descendants.

The patch makes the test sufficiently smart to stop a heavy fully obscured gif animation on micrsoft.com.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::animationAdvanced):

rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

Invalidate parents to max test depth.

(WebCore::RenderBox::backgroundPaintedExtent):

Background painting is pixel snapped.

(WebCore::isCandidateForOpaquenessTest):
(WebCore::RenderBox::foregroundIsKnownToBeOpaqueInRect):

Separate foreground testing and make it recursive.
Add fast bailout for common static positioned case.
Remove maximum child count, the fast bailouts should prevent long tests.
Add maximum depth so we know how deep we need to invalidate in styleDidChange.

(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore):

rendering/RenderBox.h:

(RenderBox):

rendering/RenderImage.cpp:

(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):

rendering/RenderImage.h:

(RenderImage):

LayoutTests:

fast/backgrounds/obscured-background-child-style-change-expected.html:
fast/backgrounds/obscured-background-child-style-change.html:
fast/repaint/obscured-background-no-repaint-expected.txt:
fast/repaint/obscured-background-no-repaint.html:

5:59 PM Changeset in webkit [146954] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Regression (r145601): out-of-bounds read in line breaking / new width cache
https://bugs.webkit.org/show_bug.cgi?id=113347

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-26
Reviewed by Geoffrey Garen.

The values zero and 0xffff have special values with the default HashTraits. Those values
are also valid values for UChar.

To avoid any table inconsitency, switch from UChar to uint32_t as the key type for
the WidthCache's single char map. The traits is also changed to allow zero as a normal
value.

This makes no space or time change over the previous code because:
-The struct KeyValuePair was already 64bits due to the ABI alignment restrictions on floats.
-The two hashes take the same number of instructions.

platform/graphics/WidthCache.h:

(WidthCache):

5:43 PM Changeset in webkit [146953] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Make HTMLProgressElement::isDeterminate private
https://bugs.webkit.org/show_bug.cgi?id=113299

Reviewed by Kentaro Hara.

The only callsite of isDeterminate outside of HTMLProgressElement
is in StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes,
and we can replace it with Element::shouldAppearIndeterminate.

No new tests. Just a refactoring.

css/StyleResolver.cpp:

(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
Use Element::shouldAppearIndeterminate.

html/HTMLProgressElement.h:

(HTMLProgressElement): Make isDeterminate private.

5:17 PM Changeset in webkit [146952] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190706. Requested by
danakj_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

DEPS:

5:15 PM Changeset in webkit [146951] by jamesr@google.com

2 edits in trunk/Source/WTF

Compile fix - OS(WINDOWS), not OS(WIN).

wtf/ProcessID.h:

(WTF::getCurrentProcessID):

5:12 PM Changeset in webkit [146950] by dgrogan@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Histogram cause of LevelDB write errors
https://bugs.webkit.org/show_bug.cgi?id=113350

Reviewed by Tony Chang.

Add histogram for source of LevelDB errors on Write in addition to
Open.

No new tests - no good way to test histogram code.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::histogramLevelDBError):
(WebCore):
(WebCore::LevelDBDatabase::open):
(WebCore::LevelDBDatabase::write):

5:11 PM Changeset in webkit [146949] by Chris Fleizach

3 edits
2 adds in trunk

WebKit does not expose @required or @aria-required as AXRequired on select elements
https://bugs.webkit.org/show_bug.cgi?id=113339

Reviewed by Tim Horton.

Source/WebCore:

Make sure button types can return the AXRequired attribute.

Tests: platform/mac/accessibility/aria-required-popup-button.html

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

LayoutTests:

platform/mac/accessibility/aria-required-popup-button-expected.txt: Added.
platform/mac/accessibility/aria-required-popup-button.html: Added.

5:09 PM Changeset in webkit [146948] by jamesr@google.com

2 edits in trunk/Source/WTF

Fix compile for OS(WIN) != PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=113356

Reviewed by Tim Horton.

wtf/ProcessID.h:

(WTF::getCurrentProcessID):

5:03 PM Changeset in webkit [146947] by fpizlo@apple.com

5 edits
6 adds in trunk

REGRESSION: Sometimes, operations on proven strings ignore changes to the string prototype
https://bugs.webkit.org/show_bug.cgi?id=113353
<rdar://problem/13510778>

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg and Geoffrey Garen.

ToString should call speculateStringObject() even if you know that it's a string object, since
it calls it to also get the watchpoint. Note that even with this change, if you do
Phantom(Check:StringObject:@a), it might get eliminated just because we proved that @a is a
string object (thereby eliminating the prototype watchpoint); that's fine since ToString is
MustGenerate and never decays to Phantom.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):

dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

LayoutTests:

Reviewed by Mark Hahnenberg and Geoffrey Garen.

fast/js/jsc-test-list:
fast/js/dfg-phantom-base-expected.txt: Added.
fast/js/dfg-phantom-base.html: Added.
fast/js/dfg-to-string-toString-becomes-bad-with-check-structure-expected.txt: Added.
fast/js/dfg-to-string-toString-becomes-bad-with-check-structure.html: Added.

4:52 PM Changeset in webkit [146946] by dino@apple.com

12 edits
4 adds in trunk

When a primary plugin is restarted, also start similar plugins
https://bugs.webkit.org/show_bug.cgi?id=113265

Reviewed by Tim Horton.

Source/WebCore:

If we detect a primary plugin that is snapshotted, we immediately restart it.
When this happens, we should also restart any other plugins that
match the same origin and type. This allows sites with a lot of
(geometrically) nearby plugins to behave as if they are a single big plugin.

Tests: plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html

plugins/snapshotting/autoplay-similar-to-dominant.html

WebCore.exp.in: Export mimeTypeFromURL.
html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Use loadedMimeType helper.
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): New method, which copied the

existing code from userDidClickSnapshot.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Move the similar plugin detection

out into another function and call it.

(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Call restartSimilarPlugIns.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Use loadedMimeType helper.

html/HTMLPlugInImageElement.h: Declaration of restartSimilarPlugIns.

(WebCore::HTMLPlugInImageElement::loadedMimeType): New helper method since this

code was being often duplicated.

Source/WebKit2:

Remember the origin of the primary plugin, so that we can
autostart anything that is similar.

WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::WebPlugInClient): Keep a pointer to the WebPage.
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Pass the page onto the process.

WebProcess/WebCoreSupport/WebPlugInClient.h:

(WebPlugInClient): New member variable for the WebPage we were created with.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Remember the origin information

for the primary plugin.

(WebKit::WebPage::matchesPrimaryPlugIn): Returns true if we're seeing something that

looks like the primary plugin.

WebProcess/WebPage/WebPage.h: New method matchesPrimaryPlugIn.
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check if the page thinks this is

the primary plugin.

WebProcess/WebProcess.h: Accept a reference to the page in shouldPlugInAutoStartFromOrigin.

LayoutTests:

Two new tests. The first has one big plugin (that should be detected as the primary)
and then a few smaller versions (which should autostart along with the primary).
The second has one big plugin, and then adds a similar one after a short delay.

platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-after-delay-expected.txt: Added.
platform/mac-wk2/plugins/snapshotting/autoplay-similar-to-dominant-expected.txt: Added.
plugins/snapshotting/autoplay-similar-to-dominant-after-delay.html: Added.
plugins/snapshotting/autoplay-similar-to-dominant.html: Added.

4:45 PM Changeset in webkit [146945] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r144131): It made fast/js/regress/string-repeat-arith.html assert on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=112106

Rubber stamped by Filip Pizlo.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkGeneratedTypeForToInt32): Get rid of the case for constants because
we would have done constant folding anyways on a ValueToInt32.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean): Fixed a random compile error with this flag enabled.

4:01 PM Changeset in webkit [146944] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebCore

Rollout r146806. <rdar://problem/13202277>

3:50 PM Changeset in webkit [146943] by zoltan@webkit.org

2 edits in trunk/LayoutTests

Unreviewed. Fix test after r146938. Since CSS Exclusions is still an experimental feature, shape-inside-on-nested-container-with-unresolved-height.html
test should enable CSS Exclusions for the testrunners first.

fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Set CSSExclisions enabled for DRT/WTR.

3:21 PM Changeset in webkit [146942] by alokp@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening.
Marked compositing/rtl/rtl-iframe-* tests as ImageOnlyFailure instead of Failure.

platform/chromium/TestExpectations:

3:20 PM Changeset in webkit [146941] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[Windows, WinCairo] Scroll offset being applied to plugins during print operations.
https://bugs.webkit.org/show_bug.cgi?id=39889

Reviewed by Anders Carlsson.

This must be tested manually. See the issue for details.

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::paintWindowedPluginIntoContext):
Revise the Windows implementation of the PluginView class
paintWindowedPluginIntoContext to use the containing window
position when computing the plugin's position for printing.

3:12 PM Changeset in webkit [146940] by wangxianzhu@chromium.org

7 edits
1 copy
1 add
2 deletes in trunk

Non-paintsContent fixed position layer should not cause slow scrolling
https://bugs.webkit.org/show_bug.cgi?id=113238

Reviewed by James Robinson.

Source/WebCore:

Added NotCompositedForNoVisibleContent in ViewportConstrainedNotCompositedReason and set it in RLC.

Test: compositing/layer-creation/fixed-position-no-content-scroll-reason.html

rendering/RenderLayer.h: Add NotCompositedForNoVisibleContent.
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Set NotCompositedForNoVisibleContent reason when the fixed position layer has no visible content.

LayoutTests:

compositing/layer-creation/fixed-position-no-content-scroll-reason-expected.txt: Added.
compositing/layer-creation/fixed-position-no-content-scroll-reason.html: Copied from LayoutTests/compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html. Test case for the bug.
compositing/layer-creation/fixed-position-in-view-dynamic.html: Set background of fixed layer to distinguish out-of-view case from no-content case.
compositing/layer-creation/fixed-position-out-of-view-dynamic.html: Ditto.
compositing/layer-creation/fixed-position-out-of-view-scroll-reason.html: Ditto.
platform/chromium/compositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-in-view-dynamic-expected.txt: Removed. This was a wrong rebaseline related to this bug.

3:09 PM Changeset in webkit [146939] by alokp@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening.
Marked compositing/iframes/scrolling-iframe.html flaky on all platforms.

platform/chromium/TestExpectations:

3:08 PM Changeset in webkit [146938] by zoltan@webkit.org

3 edits
2 adds in trunk

[CSS Exclusions] The radius of a circle should be computed based on the shorter available dimension
https://bugs.webkit.org/show_bug.cgi?id=113255

Reviewed by Julien Chaffraix.

When we decide what should be the radius of a circle, we should choose the smallest available space. For instance when the
width or height is not resolvable for the circle we should not have a radius for it. This change modifies the behavior to
use the smaller available space, so we won't render unnecessary circle shapes.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html

rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

LayoutTests:

fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-on-nested-container-with-unresolved-height.html: Added.

3:04 PM Changeset in webkit [146937] by timothy@apple.com

2 edits in trunk/Source/WebCore

Make the Web Inspector console work in strict mode with JavaScriptCore.

https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Joseph Pecoraro.

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Don't use 'eval' parameter (it isn't
allowed in strict mode). Swap window.eval with our known eval instead.

3:03 PM Changeset in webkit [146936] by jamesr@google.com

23 edits in trunk/LayoutTests

Clean up last failing expectations from solid color layer patch.

platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-win/platform/chromium/virtual/softwarecompositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-win/platform/chromium/virtual/softwarecompositing/transitions/scale-transition-no-start-expected.png:
platform/chromium/TestExpectations:
platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

3:03 PM Changeset in webkit [146935] by rniwa@webkit.org

8 edits in trunk/Source

Heap-use-after-free regression
https://bugs.webkit.org/show_bug.cgi?id=113337

Reviewed by Abhishek Arya and Alexey Proskuryakov.

Source/WebCore:

Use RefPtr instead of raw pointer in m_associatedFormControls.

dom/Document.cpp:

(WebCore::Document::didAssociateFormControlsTimerFired):

dom/Document.h:

(Document):

loader/EmptyClients.h:

(WebCore::EmptyChromeClient::didAssociateFormControls):

page/ChromeClient.h:

(WebCore::ChromeClient::didAssociateFormControls):

Source/WebKit/chromium:

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):

src/ChromeClientImpl.h:

(ChromeClientImpl):

2:46 PM Changeset in webkit [146934] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Include accelerated compositing layers in screen captures.
https://bugs.webkit.org/show_bug.cgi?id=113335

Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

PR# 280374
Include accelerated compositing layers in screen captures.
Reviewed Internally By: Jakob Petsovits

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):

Api/BackingStore_p.h:

2:46 PM Changeset in webkit [146933] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
https://bugs.webkit.org/show_bug.cgi?id=113144

Reviewed by Geoffrey Garen.

Forgot to include Geoff's requested change in the original commit.

profiler/ProfilerDatabase.cpp:

(Profiler):

2:43 PM Changeset in webkit [146932] by fpizlo@apple.com

14 edits
1 add in trunk/Source

JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
https://bugs.webkit.org/show_bug.cgi?id=113144

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
to the current directory, or JSC_PROFILER_PATH if the latter was specified.

This works by saving the Profiler::Database either when it is destroyed or atexit(),
whichever happens first.

This allows use of the profiler from any WebKit client.

jsc.cpp:

(jscmain):

profiler/ProfilerDatabase.cpp:

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):

profiler/ProfilerDatabase.h:

(JSC::Profiler::Database::databaseID):
(Database):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Source/WTF:

Reviewed by Geoffrey Garen.

I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
_getpid() I believe), so I wrote a header that abstracts it. I also changed existing
code that uses getpid() to use WTF::getCurrentProcessID().

GNUmakefile.list.am:
WTF.gypi:
WTF.pro:
WTF.vcproj/WTF.vcproj:
WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

wtf/ProcessID.h: Added.

(WTF):
(WTF::getCurrentProcessID):

wtf/text/StringImpl.cpp:

(WTF::StringStats::printStats):

2:42 PM Changeset in webkit [146931] by ap@apple.com

2 edits in trunk/Source/WebKit2

Follow-up to:
<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
https://bugs.webkit.org/show_bug.cgi?id=113256

Reviewed by Mark Rowe.

NetworkProcess/NetworkResourceLoader.h: Added some forgotten OVERRIDEs.

2:29 PM Changeset in webkit [146930] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Set mouse document position for mouse event in updateCursor
https://bugs.webkit.org/show_bug.cgi?id=109094

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-26
Reviewed by Rob Buis.

Internally Reviewed by Jakob Petsovits.

Mouse content position should be in document coordinate.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateCursor):

2:27 PM Changeset in webkit [146929] by ap@apple.com

24 edits
2 copies
1 add in trunk/Source

<rdar://problem/13194263> Crashes in NetworkProcess due to threading issues
https://bugs.webkit.org/show_bug.cgi?id=113256

Reviewed by Brady Eidson.

Added a new code path in ResourceHandle/ResourceHandleClient that doesn't need
blocking calls. Implemented it for NSURLConnection by changing NSOperationQueue
version to forward calls to main thread.

2:26 PM Changeset in webkit [146928] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

[wk2] Don't send intrinsic content size updates more than once per runloop
https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Simon Fraser.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Only start the zero-delay timer if it's not already active.

2:13 PM Changeset in webkit [146927] by Claudio Saavedra

2 edits in trunk/LayoutTests

Convert test from UTF-16 to UTF-8

Rubber stamped by James Robinson.

fast/dom/34176.html: Convert from little endian UTF-16 to UTF-8

to make git diff happy.

1:40 PM Changeset in webkit [146926] by jparent@chromium.org

3 edits in trunk/Tools

Flakiness dashboard: simplify logic around which tests to show.
https://bugs.webkit.org/show_bug.cgi?id=113250

Reviewed by Ojan Vafai.

The different filters for showing results are only used for layout
tests, otherwise, we show everything.

Change the defaults to false (what layout tests used), and only
look at the values when viewing layout tests.

TestResultServer/static-dashboards/flakiness_dashboard.js:

(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):

1:33 PM Changeset in webkit [146925] by alokp@chromium.org

21 edits
10 copies
1 add
1 delete in trunk/LayoutTests

Rebaseline text output for opaque GraphicsLayers
https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed rebaseline.

platform/chromium-linux-x86/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Removed.
platform/chromium-linux/compositing/overflow/composited-scrolling-paint-phases-expected.txt:
platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-win/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt.
platform/chromium/TestExpectations:
platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
platform/chromium/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-paint-phases-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-paint-phases-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
platform/chromium/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.

1:29 PM Changeset in webkit [146924] by tony@chromium.org

15 edits in trunk/Source

Autogenerate the scrollAnimatorEnabled setting in Settings.in
https://bugs.webkit.org/show_bug.cgi?id=113253

Reviewed by James Robinson.

Source/WebCore:

Convert scrollAnimatorEnabled into an autogenerated setting. This involves renaming
the setter from setEnableScrollAnimator(bool) to setScrollAnimatorEnabled(bool) and
updating the callers. I didn't change any WebKit API methods.

Also remove the code in InternalSettings since it's never used and will now be
autogenerated with proper resetting code.

No new tests, this is a refactor and should compile.

page/Settings.cpp:

(WebCore::Settings::Settings): Remove code that is now autogenerated.

page/Settings.h:

(Settings): Remove code that is now autogenerated.

page/Settings.in: Add entry for scrollAnimatorEnabled.
testing/InternalSettings.cpp: Remove unused code.
testing/InternalSettings.h: Remove unused code.
testing/InternalSettings.idl: Remove unused code.

Source/WebKit/chromium:

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setEnableScrollAnimator): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/gtk:

webkit/webkitwebview.cpp:

(webkit_web_view_update_settings): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(webkit_web_view_settings_notify): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit/qt:

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply): Update call to WebCore to use setScrollAnimatorEnabled(bool).

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout): Update call to WebCore to use setScrollAnimatorEnabled(bool).
(WebKit::WebPage::updatePreferences): Update call to WebCore to use setScrollAnimatorEnabled(bool).

1:05 PM Changeset in webkit [146923] by rafaelw@chromium.org

2 edits in trunk/LayoutTests

Remove stray newline. This newline is messing up mozilla's test harness
and we share this file with them via html5lib.

html5lib/resources/template.dat:

1:04 PM Changeset in webkit [146922] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] In RSSFilterStream, don't swallow headers when there's no body
https://bugs.webkit.org/show_bug.cgi?id=113334

Patch by Joe Mason <jmason@blackberry.com> on 2013-03-26
Reviewed by Rob Buis.

RIM PR 316345

When receiving an HTTP response that has a Content-Type header such as text/xml, but no
body, RSSFilterStream::notifyHeadersReceived reads the Content-Type as "potential RSS", and
calls saveHeaders. It expects to sniff the body in notifyDataReceived to see if it's RSS,
and then call sendSavedHeaders to pass on the headers. But since there is no body,
notifyDataReceived is never called. So call sendSavedHeaders in notifyClose too (it will not
send them again if they were already sent.)

platform/network/blackberry/rss/RSSFilterStream.cpp:

(WebCore::RSSFilterStream::notifyClose):

12:48 PM Changeset in webkit [146921] by commit-queue@webkit.org

2 edits in trunk/Tools

Update bots on test-results.appspot
https://bugs.webkit.org/show_bug.cgi?id=113333

Patch by Isaac Levy <ilevy@google.com> on 2013-03-26
Reviewed by Ojan Vafai.

TestResultServer/static-dashboards/builders.jsonp:

12:46 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:44 PM Changeset in webkit [146920] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0

[GTK] Bump required versions of some dependencies
https://bugs.webkit.org/show_bug.cgi?id=113282

Reviewed by Martin Robinson.

This patch updates the following dependencies:

libsoup 2.42.0: is the current stable release.

glib 2.36.0: libsoup 2.42 requires 2.35.0, but we don't want to depend on unstable versions and 2.36 is the next stable version after 2.35.

gtk+ 3.6.0: this is the previous stable release. We don't currently have any code using newer API, so we will be able to remove all the #ifdefed code.

at-spi2 2.5.3: is the version required by gtk+ 3.6.

GObject introspection 1.32.0: is the version required by gtk+ 3.6.

Pango 1.32.0: it's the current stable version and the first one depending on Harfbuzz.

Fontconfig 2.5: required by pango 1.32.0 when using Harfbuzz.

gtk+ 2.24.10: it allows us to remove a lot of deprecated code and #ifdefs.

Source/autotools/Versions.m4:

12:41 PM Changeset in webkit [146919] by kareng@chromium.org

9 edits in branches/chromium/1453/Source

Revert 146672 "Add client callbacks to notify of changes of asso..."

Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375

dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):

dom/Document.h:
(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.

html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):

html/FormAssociatedElement.h:
(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes

html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::insertedInto):
(WebCore):

html/HTMLFormElement.h:
add call to Document::didAssociateFormControl

loader/EmptyClients.h:
(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):

page/ChromeClient.h:
(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

public/WebAutofillClient.h:
(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):

src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):

src/ChromeClientImpl.h:
(ChromeClientImpl):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12670015

12:30 PM Changeset in webkit [146918] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Faster drawer animation.
https://bugs.webkit.org/show_bug.cgi?id=113330

250ms -> 100ms

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.

inspector/front-end/inspector.css:

(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):

12:12 PM Changeset in webkit [146917] by tony@chromium.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Expose setSelectionIncludesAltImageText in WebSettings
https://bugs.webkit.org/show_bug.cgi?id=113316

Reviewed by Dimitri Glazkov.

Enabling this setting allows plain text clipboard content to include alt
text like on Firefox and IE10.

public/WebSettings.h:

(WebSettings):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setSelectionIncludesAltImageText):

src/WebSettingsImpl.h:

(WebSettingsImpl):

12:04 PM Changeset in webkit [146916] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Remove some entries since those tests have been passing.
Also update the test expectations for the bug 113227 flaky since they're passing most of the time.

platform/mac/TestExpectations:

12:01 PM Changeset in webkit [146915] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] Fails to start QtWebProcess.exe if installed in a path containing spaces
https://bugs.webkit.org/show_bug.cgi?id=113328

Reviewed by Jocelyn Turcotte.

Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30249

We use QProcess::start() with a commandline string to start the web process
and the string is treated by QProcess as a whitespace delimeted list of the
command and the arguments, thus we have to escape the path to the process
binaries so that if the path contains spaces we still run the appropriate
command.

UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncher::launchProcess):

11:57 AM Changeset in webkit [146914] by abecsi@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] QML WebView asserts when double clicking a link
https://bugs.webkit.org/show_bug.cgi?id=113329

Reviewed by Jocelyn Turcotte.

Downstream bugreport: https://bugreports.qt-project.org/browse/QTBUG-30288

Remove an erroneous assert which is no longer valid if
mouse gestures are enabled.

UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleInputEvent):

11:43 AM Changeset in webkit [146913] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

[wk2] Don't send intrinsic content size updates more than once per runloop
https://bugs.webkit.org/show_bug.cgi?id=113258
<rdar://problem/13492038>

Reviewed by Anders Carlsson.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
Add a zero-delay timer for intrinsic content size updates.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameContentSizeChanged):
Start our new one-shot zero-delay timer.
(WebKit::TiledCoreAnimationDrawingArea::updateIntrinsicContentSizeTimerFired):
Inform the WebPage that the intrinsic content size has changed.

11:30 AM Changeset in webkit [146912] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed Build fix.

platform/graphics/win/FontCustomPlatformDataCairo.h:

(FontCustomPlatformData): Correct signature in header to match
required implementation.

11:21 AM Changeset in webkit [146911] by anilsson@rim.com

8 edits in trunk/Source

[BlackBerry] Scrolling up and down can cause the screen to flash black
https://bugs.webkit.org/show_bug.cgi?id=113269

Reviewed by Rob Buis.

PR 296106

Source/WebCore:

The LayerRenderer should never clear before drawing the layers, from
now on that's the responsibility of the caller.

Only manually testable.

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::setViewport):

platform/graphics/blackberry/LayerRendererClient.h:

(LayerRendererClient):

Source/WebKit/blackberry:

Various flaws in the code could conspire to make the screen cleared to
black before rendering the web page. This only happened when the
BackingStore was inactive, and the LayerTiler takes on the job of
drawing the root layer. When tiles are missing, this made the
"checkerboard" effect especially noticeable since black color was seen
where the tile should have been. It would be better to clear to the web
page background color.

This was actually the intent of the code, but when the document
background color was invalid, we would still use it instead of the
background color from settings. Also, the LayerRenderer would clear to
black when WebPageCompositorPrivate::drawsRootLayer() was true.

Fixed by falling back to the settings background color when the
document background color is invalid, and removing the clearing code
from the LayerRenderer entirely. The appropriate clear already happens
near the beginning of BackingStorePrivate::blitVisibleContents().

Also slightly cleaned up the code for managing the background color.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
(BlackBerry::WebKit::WebPagePrivate::updateBackgroundColor):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::documentBackgroundColor):

Api/WebPageCompositor.cpp:
Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

Api/WebPage_p.h:

(WebPagePrivate):

11:10 AM Changeset in webkit [146910] by allan.jensen@digia.com

5 edits in trunk

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Make it possible to read from a writable Clipboard.

Test: editing/pasteboard/can-read-in-copy-and-cut-events.html

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::readClipboardData):
(WebCore::ClipboardQt::hasData):
(WebCore::ClipboardQt::items):

platform/qt/ClipboardQt.h:

(ClipboardQt):

LayoutTests:

Unskip now working editing/pasteboard/can-read-in-copy-and-cut-events.html.
The other test still needs better drag-and-drop support in DRT.

platform/qt/TestExpectations:

11:01 AM Changeset in webkit [146909] by bfulgham@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

platform/graphics/win/FontCustomPlatformDataCairo.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Update
method signature to match CG variant.

10:59 AM Changeset in webkit [146908] by Christophe Dumez

14 edits
2 deletes in trunk/Source

Code duplication between HTTPParsers and HTTPValidation
https://bugs.webkit.org/show_bug.cgi?id=113283

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merged isValidHTTPToken() from HTTPValidation.h and isRFC2616Token() from
HTTPParsers.h. They were doing exactly the same thing and their
implementation was almost the same.

Removed HTTPValidation.* and moved remaining code to HTTPParsers.* as this
seems like the proper place and it seems odd to keep HTTPValidation for
just one function.

No new tests, no behavior change for layout tests.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/HTTPParsers.cpp:

(WebCore::isValidHTTPHeaderValue):
(WebCore):
(WebCore::isValidHTTPToken): Implementation is slightly simplified based on

isValidHTTPToken() from HTTPValidation.cpp. (c >= 0x80 replaced by (c >= 0x7F). (c <= 0x1F

c == 0x7F) is
c == ' '	c == '\t') is replaced

by (c <= 0x20). Those expressions are shorter but equivalent.
(WebCore::contentDispositionType):

platform/network/HTTPParsers.h:
platform/network/HTTPValidation.cpp: Removed.
platform/network/HTTPValidation.h: Removed.
xml/XMLHttpRequest.cpp: Stop including HTTPValidation.h.

Source/WebKit/chromium:

src/AssociatedURLLoader.cpp: Include HTTPParsers.h instead

of HTTPValidation.h to use isValidHTTPToken().

10:58 AM Changeset in webkit [146907] by sergio@webkit.org

17 edits
4 adds in trunk

Implement overtype mode for editable content
https://bugs.webkit.org/show_bug.cgi?id=112126

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/execCommand/overtype-support.html

editing/execCommand/overtype.html

Add a new Overwrite command to the editor. This command will
perform overtype operations when enabled instead of "normal" text
insertions. As IE does, we maintain a single toggle state in the
editor (enabled/disabled) for all the editable content in the
page.

This new command will be only available for richly editable
content via keybindings or the context menu. For testing purposes
it is also accessible via internals.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
local variables.

editing/Editor.cpp:

(WebCore::Editor::Editor):

editing/Editor.h:

(WebCore::Editor::isOverwriteModeEnabled):
(WebCore::Editor::toggleOverwriteModeEnabled):
(Editor): Added two new functions and a new attribute.

editing/EditorCommand.cpp:

(WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
(WebCore):
(WebCore::createCommandMap): New OverWrite command.

editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
Refactored from performTrivialReplace(), shared by
performOverwrite().
(WebCore):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.

editing/InsertTextCommand.h:

(InsertTextCommand):

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset OverWrite mode
to false.
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore):
(WebCore::Internals::toggleOverwriteModeEnabled): Provide access
to overwrite functionality in Editor for testing purposes.

testing/Internals.h:

(Internals):

testing/Internals.idl:

Source/WebKit/mac:

Added the OverWrite editing command to the WebCore editing
commands lists.

WebView/WebHTMLView.mm:
WebView/WebView.h:
WebView/WebView.mm:

LayoutTests:

Two new layout tests for the new overtype mode. We use
overtype-support.html to check that the Overwrite command is not
exported to JavaScript but accessible through Internals. The
overtype.html one is used to test the actual behaviour of the
command.

The new command was also added to enabling-and-selection-2.js to
check that it is only available for richly editable content.

editing/execCommand/enabling-and-selection-2-expected.txt:

Updated expectations for OverWrite command.

editing/execCommand/overtype-expected.txt: Added.
editing/execCommand/overtype-support-expected.txt: Added.
editing/execCommand/overtype-support.html: Added.
editing/execCommand/overtype.html: Added.
editing/execCommand/script-tests/enabling-and-selection-2.js:

Added a check for OverWrite command.

10:44 AM Changeset in webkit [146906] by anilsson@rim.com

6 edits in trunk/Source

[BlackBerry] WebOverlay::pixelViewportRect() should return pixel viewport coordinates
https://bugs.webkit.org/show_bug.cgi?id=113263

Reviewed by Rob Buis.

PR 312404

Source/WebCore:

Fix WebOverlay::pixelViewportRect() to return the pixel viewport rect
instead of the window rect. These are different if the web page is
rendered starting at a window coordinate other than 0,0. The clip rect
encodes the position we're rendered at, and can be used to translate
the rect expressed in window coordinates to the pixel viewport
coordinate system.

Also perform some cleanup of related code.

Only manually testable.

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::getTransformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::toPixelCoordinates):
(WebCore):
(WebCore::LayerRenderer::toWindowCoordinates):
(WebCore::LayerRenderer::toPixelViewportCoordinates):
(WebCore::LayerRenderer::toDocumentViewportCoordinates):
(WebCore::LayerRenderer::updateLayersRecursive):

platform/graphics/blackberry/LayerRenderer.h:

(LayerRenderer):

Source/WebKit/blackberry:

Fixed by returning pixel viewport coordinates instead of window
coordinates.

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

10:31 AM Changeset in webkit [146905] by commit-queue@webkit.org

5 edits in trunk

Unreviewed, rolling out r146901.
http://trac.webkit.org/changeset/146901
https://bugs.webkit.org/show_bug.cgi?id=113321

Was landed to soon (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
(WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.monitoringXHRItemAction):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get preserveLogItemAction):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):

inspector/front-end/inspector.css:

(.console-warning-level, .console-error-level, .console-log-level, .console-debug-level):
(.filter-all .console-debug-level, .filter-debug .console-debug-level):
(.filter-all .console-debug-level.repeated-message, .filter-debug .console-debug-level.repeated-message):

LayoutTests:

inspector/console/console-preserve-log.html:

10:24 AM Changeset in webkit [146904] by rafaelw@chromium.org

4 edits in trunk

HTMLStackItem should include <template> as a special tag
https://bugs.webkit.org/show_bug.cgi?id=113016

Reviewed by Eric Seidel.

Source/WebCore:

New test added to html5lib suite.

html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::isSpecialNode):

LayoutTests:

html5lib/resources/template.dat:

10:22 AM Changeset in webkit [146903] by vsevik@chromium.org

6 edits in trunk

Web Inspector: Distinguish breakpoints and breakpoint locations in BreakpointManager API
https://bugs.webkit.org/show_bug.cgi?id=113311

Reviewed by Pavel Feldman.

Source/WebCore:

Made independent handling of breakpoints and breakpoint location in breakpoint manager consistent.
JavaScriptSourceFrame now removes breakpoints originally set in it based on primary UI location.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype.breakpointsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpoints):
(WebInspector.BreakpointManager.prototype.breakpointLocationsForUISourceCode):
(WebInspector.BreakpointManager.prototype.allBreakpointLocations):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.onUISourceCodeContentChanged):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._removeAllBreakpoints):

LayoutTests:

inspector/debugger/live-edit-breakpoints-expected.txt:
inspector/debugger/live-edit-breakpoints.html:

10:21 AM Changeset in webkit [146902] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

bundle-ids need to be sanitized before using them in filesystem paths
https://bugs.webkit.org/show_bug.cgi?id=113030
<rdar://problem/13300254>

Patch by Simon Cooper <scooper@apple.com> on 2013-03-26
Reviewed by Alexey Proskuryakov.

When choosing / looking for a specialized Sandbox for a Plugin the
bundle-id needs to be sanitized before using it to construct a
filesystem name to look up. The “/“ character should not be allowed
and transformed into something else, in this case a “:”

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::loadSandboxProfile):

10:12 AM Changeset in webkit [146901] by commit-queue@webkit.org

5 edits in trunk

Web Inspector: Remove remainings of CSS-based console message filtering.
https://bugs.webkit.org/show_bug.cgi?id=112710

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-26
Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.get this):
(WebInspector.ConsoleView.prototype.):
(WebInspector.ConsoleView.prototype.filter):
(WebInspector.ConsoleView.prototype._consoleMessageAdded):
(WebInspector.ConsoleView.prototype._appendConsoleMessage):
(WebInspector.ConsoleView.prototype._consoleCleared):
(WebInspector.ConsoleView.prototype._shouldBeVisible):
(WebInspector.ConsoleView.prototype._updateMessageList):
(WebInspector.ConsoleView.prototype._promptKeyDown):
(WebInspector.ConsoleView.prototype._printResult):
(WebInspector.ConsoleCommand.prototype.highlightSearchResults):

inspector/front-end/inspector.css:

(.console-debug-level.repeated-message):

LayoutTests:

inspector/console/console-preserve-log.html:

10:09 AM Changeset in webkit [146900] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
https://bugs.webkit.org/show_bug.cgi?id=113211

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-26
Reviewed by Yury Semikhatsky.

A new method WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements is added and used
from 2 sites.

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.ObjectPropertiesSection.prototype.update.callback):
(WebInspector.ObjectPropertiesSection.prototype.update):
(WebInspector.ObjectPropertiesSection.prototype.updateProperties):
(.callback):
(WebInspector.ObjectPropertyTreeElement.populate):
(WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements):

inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype.update.appendResult):
(WebInspector.WatchExpressionsSection.prototype.update):

10:04 AM Changeset in webkit [146899] by Christophe Dumez

2 edits in trunk/Source/WebCore

HTTPHeaderMap::copyData() could call uncheckedAppend()
https://bugs.webkit.org/show_bug.cgi?id=113279

Reviewed by Alexey Proskuryakov.

HTTPHeaderMap::copyData() calls reserveInitialCapacity() on the Vector
but then appends items using append() function. Since we already know
the capacity is sufficient, it is more efficient to call uncheckedAppend()
instead to bypass capacity checks.

No new tests, no behavior change for layout tests.

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

10:01 AM Changeset in webkit [146898] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: UISourceCodes are leaking on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=113310

Reviewed by Pavel Feldman.

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):

inspector/front-end/ConsoleModel.js:

(WebInspector.ConsoleModel.prototype.clearMessages):

9:45 AM Changeset in webkit [146897] by apavlov@chromium.org

4 edits
2 adds in trunk

Web Inspector: [Elements] Unable to "Edit as HTML" XHTML/SVG documents.
https://bugs.webkit.org/show_bug.cgi?id=113290

Reviewed by Pavel Feldman.

Source/WebCore:

DOMPatchSupport has been slightly augmented to handle XML (XHTML and SVG) documents.

Test: inspector/elements/set-outer-html-for-xhtml.xhtml

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):
(WebCore::DOMPatchSupport::patchNode):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML): Let HTML, XHTML, and SVG documents through.

LayoutTests:

inspector/elements/set-outer-html-for-xhtml-expected.txt: Added.
inspector/elements/set-outer-html-for-xhtml.xhtml: Added.

9:14 AM Changeset in webkit [146896] by morrita@google.com

5 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=113164
Custom Elements: readyCallback should be called for outerHTML and insertAdjecentHTML

Source/WebCore:

These APIs also create new elements thus should have V8DeliverCustomElementCallbacks attribute.

Reviewed by Dimitri Glazkov.

Test: Updated lifecycle-ready-creation-api.html.

html/HTMLElement.idl:

LayoutTests:

Reviewed by Dimitri Glazkov.

fast/dom/custom/lifecycle-ready-creation-api-expected.txt:
fast/dom/custom/lifecycle-ready-creation-api.html:

9:10 AM Changeset in webkit [146895] by jochen@chromium.org

2 edits in trunk/LayoutTests

Fix incorrect test name in content shell expectations

Unreviewed. Typing is hard.

platform/chromium/ContentShellTestExpectations:

9:05 AM Changeset in webkit [146894] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Convert WebInputEvent::GestureDoubleTap to PlatformEvent::NoType
https://bugs.webkit.org/show_bug.cgi?id=113215

In bug 93045 we removed PlatformEvent::GestureDoubleTap since now DoubleTap gesture
is implemented as a Tap gesture with tap_count = 2.

In WebViewImpl::handleGestureEvent(), a PlatformEvent is built from the WebGestureEvent
regardless, even though the PlatfromEvent will never reach the WebCore. DoubleTap, in
our case, is only handled in WebViewImpl for doube-tap-to-zoom, will also go through
conversion in WebInpuEventConversion.cpp::PlatformGestureEventBuilder() and reach
ASSERT_NOT_REACHED()

This patch converts WebGestureEvent::DoubleTap to PlatformEvent::NoType, this makes the
conversion list from WebInputEvent to PlatformEvent complete and we don't need a special
handling for the DoubleTap event in WebViewImpl::handleGestureEvent()

Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-26
Reviewed by Antonio Gomes.

src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

9:02 AM Changeset in webkit [146893] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. WebInspector: remove unnecessary method.

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.Window):

9:00 AM Changeset in webkit [146892] by kareng@chromium.org

8 edits in branches/chromium/1453/Source/WebCore

Revert 146744 "Refactoring: Pull Node::disabled() and Node::isIn..."

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

dom/Element.cpp:
(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

dom/Element.h:
(Element):

dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:
(Node):

TBR=falken@chromium.org
Review URL: https://codereview.chromium.org/12703032

8:57 AM Changeset in webkit [146891] by kareng@chromium.org

33 edits in branches/chromium/1453/Source/WebCore

Revert 146726 "AXObjectCache gets recreated during document tear..."

AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

dom/ContainerNode.cpp:
(WebCore::ContainerNode::~ContainerNode):

dom/Document.cpp:
(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

dom/Document.h:
(Document):

dom/Element.cpp:
(WebCore::Element::attributeChanged):

dom/Node.cpp:
(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

editing/AppendNodeCommand.cpp:
(WebCore::sendAXTextChangedIgnoringLineBreaks):

editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertNodeBeforeCommand.cpp:
(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/atk/FrameSelectionAtk.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/chromium/FrameSelectionChromium.cpp:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):

html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/InputType.cpp:
(WebCore::InputType::applyStep):

html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):

loader/FrameLoader.cpp:
(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):

page/Frame.cpp:
(WebCore::Frame::disconnectOwnerElement):

page/FrameView.cpp:
(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

platform/ScrollView.cpp:
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

platform/Scrollbar.cpp:
(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

platform/Scrollbar.h:
(Scrollbar):

rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

rendering/RenderListBox.cpp:
(WebCore::RenderListBox::selectionChanged):

rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

rendering/RenderObject.cpp:
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderText.cpp:
(WebCore::RenderText::setText):

rendering/RenderWidget.cpp:
(WebCore::RenderWidget::willBeDestroyed):

TBR=Chris Fleizach
Review URL: https://codereview.chromium.org/12703031

8:54 AM Changeset in webkit [146890] by loislo@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Scroll dividers together with underlying chart.
http://bugs.webkit.org/show_bug.cgi?id=113080

Reviewed by Pavel Feldman.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.Calculator.prototype.grandMinimumBoundary):
(WebInspector.FlameChart.prototype._canvasDragging):

inspector/front-end/TimelineGrid.js:

(WebInspector.TimelineGrid.prototype.updateDividers):

8:53 AM Changeset in webkit [146889] by kareng@chromium.org

1 add in branches/chromium/1453/codereview.settings

for drovering

8:52 AM Changeset in webkit [146888] by kareng@chromium.org

1 copy in branches/chromium/1453

hopefully m27 branch

8:36 AM Changeset in webkit [146887] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

ArrayMode should not consider SpecOther when refining the base
https://bugs.webkit.org/show_bug.cgi?id=113271

Reviewed by Geoffrey Garen.

9% speed-up on Octane/pdfjs.

dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

8:22 AM Changeset in webkit [146886] by mkwst@chromium.org

5 edits
4 adds in trunk

CSP 1.1: Experiment with 'base-uri' directive.
https://bugs.webkit.org/show_bug.cgi?id=113307

Reviewed by Jochen Eisinger.

Source/WebCore:

The 'base-uri' directive was introduced[1] as an experimental directive
in CSP 1.1 after a bit of discussion[2][3]. The exact semantics will
likely change, but it would be good for us to get some implementation
experience with the API as currently specified, and to allow folks to
play with the implementation to determine whether it meets the
requirements the way we think it might.

This patch is a first pass at that implementation: it will have no
effect on ports that haven't enabled the CSP_NEXT flag.

[1]: https://dvcs.w3.org/hg/content-security-policy/rev/4b89c246ea16
[2]: http://lists.w3.org/Archives/Public/public-webappsec/2012Oct/0022.html
[3]: http://lists.w3.org/Archives/Public/public-webappsec/2013Feb/0074.html

Tests: http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html

http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html

dom/Document.cpp:

(WebCore::Document::processBaseElement):

Check that the new base URI is allowed by CSP before using it as
the document's base URI.

page/ContentSecurityPolicy.cpp:

Add a constant for the new directive name (and, as a drive-by, split
the list into CSP 1.0 and CSP 1.1 for clarity).

(CSPDirectiveList):

Add a property to hold the base URI policy directive value.

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):

Customize the error message iff we're dealing with 'base-uri'.

(WebCore::CSPDirectiveList::allowBaseURI):

Check the given URI against the 'base-uri' directive's value,
exactly as we do for every other source-list type of directive.

(WebCore::CSPDirectiveList::addDirective):

Accept 'base-uri' as a valid directive iff CSP_NEXT is set, and
the embedder has opted-in via the runtime flag.

(WebCore::ContentSecurityPolicy::allowBaseURI):

Expose an API method on ContentSecurityPolicy to check URIs against
the 'base-uri' directive's value.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/base-uri-allow-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/base-uri-allow.html: Added.
http/tests/security/contentSecurityPolicy/1.1/base-uri-deny-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/base-uri-deny.html: Added.

8:21 AM Changeset in webkit [146885] by anilsson@rim.com

2 edits in trunk/Source/WebCore

[BlackBerry] Main frame fixed divs not positioned correctly
https://bugs.webkit.org/show_bug.cgi?id=112889

Reviewed by Carlos Garcia Campos.

PR 283363

This was a regression from bug #112806. It caused main frame fixed
handling to enter the iframe/scrollable div code path in LayerRenderer.

Fixed by not setting the container for fixed flag on the main frame,
the LayerRenderer expects this flag to be set only on non-mainframe
containers.

Only manually testable.

page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp:

(WebCore::scrollLayerForFrame):
(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):

8:17 AM Changeset in webkit [146884] by Christophe Dumez

2 edits in trunk/Source/WebCore

FormData::deepCopy() could use Vector::uncheckedAppend()
https://bugs.webkit.org/show_bug.cgi?id=113309

Reviewed by Kenneth Rohde Christiansen.

FormData::deepCopy() calls reserveInitialCapacity() on the Vector but then uses the
regular append() method. This patch switches to using uncheckedAppend() method
instead to bypass capacity checks as we already know it is sufficient.

No new tests, no behavior change.

platform/network/FormData.cpp:

(WebCore::FormData::deepCopy):

8:15 AM Changeset in webkit [146883] by commit-queue@webkit.org

13 edits in trunk

Unreviewed, rolling out r146879.
http://trac.webkit.org/changeset/146879
https://bugs.webkit.org/show_bug.cgi?id=113312

Multiple layout test crashes in
WebCore::RenderListItem::updateListMarkerNumbers (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

dom/Node.cpp:
dom/Node.h:

(Node):

dom/NodeTraversal.cpp:
dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):

html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

rendering/RenderListItem.cpp:

(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

fast/dom/shadow/shadow-and-list-elements-expected.html:
fast/lists/positioned-count-crash-expected.txt:

8:06 AM Changeset in webkit [146882] by morrita@google.com

6 edits
3 adds in trunk

remoeveAllEventListeners() should be called to shadow trees
https://bugs.webkit.org/show_bug.cgi?id=113037

Reviewed by Dimitri Glazkov.

Source/WebCore:

Document::removeAllEventListeners() doesn't traverse shadow tree, but we should.
This change override Element::removeAllEventListeners() so that it cleans its shadow trees up.

Test: fast/dom/shadow/shadow-tree-listener-clearance.html

dom/Element.cpp:

(WebCore::Element::removeAllEventListeners):
(WebCore):

dom/Element.h:

(Element):

dom/ElementShadow.cpp:

(WebCore::ElementShadow::removeAllEventListeners): Added.
(WebCore):

dom/ElementShadow.h:

(ElementShadow):

LayoutTests:

fast/dom/shadow/resources/shadow-tree-listener-clearance-frame.html: Added.
fast/dom/shadow/shadow-tree-listener-clearance-expected.txt: Added.
fast/dom/shadow/shadow-tree-listener-clearance.html: Added.

8:04 AM Changeset in webkit [146881] by yurys@chromium.org

1 edit
1 add
1 delete in trunk/LayoutTests

Unreviewed. Updated test expectations for compositing/geometry/fixed-in-composited.html

platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Removed.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.

7:52 AM Changeset in webkit [146880] by zeno.albisser@digia.com

2 edits in trunk/Source/WebKit2

[Qt] UIProcess should initialize WebCoreSystemInterface.
https://bugs.webkit.org/show_bug.cgi?id=113300

The WebCoreSystemInterface is necessary to detect supported
mime types on Mac OS. In particular it is needed for download
support.
This patch fixes in particular the previously failing
Qt API qmltest WebViewDownload::test_downloadRequest.
The test was crashing when using QTKit, because functions
in WebCoreSystemInterface could not be resolved on the UIProcess side.

Reviewed by Jocelyn Turcotte.

UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

6:53 AM Changeset in webkit [146879] by abucur@adobe.com

13 edits in trunk

Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352

Reviewed by Elliott Sprehn.

Source/WebCore:

Currently the list items ordering is made by traversing the render tree. This gives bad results for:

list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
list items matched to insertion points inside a shadow tree. The insertion point may be a child of a

list so the numbering gets broken.

To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.

In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975

Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html

dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):

dom/Node.h:

(Node):

dom/NodeTraversal.cpp:

(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

rendering/RenderListItem.cpp:

(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.

fast/dom/shadow/shadow-and-list-elements-expected.html:
fast/lists/positioned-count-crash-expected.txt:

6:51 AM Changeset in webkit [146878] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] Poor rounding in GraphicsContext::drawLineForText
https://bugs.webkit.org/show_bug.cgi?id=113301

Reviewed by Jocelyn Turcotte.

Round the position of the line decoration, so lines on subpixel
coordinates are not always rounded up.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::drawLineForText):

6:45 AM Changeset in webkit [146877] by zarvai@inf.u-szeged.hu

256 edits
6 copies
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening. Updating PNG expected results. Making pixel test bot happier after r146206.

platform/qt/svg/custom/mask-excessive-malloc-expected.png:
platform/qt/svg/custom/mask-inside-defs-expected.png:
platform/qt/svg/custom/massive-coordinates-expected.png:
platform/qt/svg/custom/missing-xlink-expected.png:
platform/qt/svg/custom/non-circular-marker-reference-expected.png:
platform/qt/svg/custom/object-sizing-expected.png:
platform/qt/svg/custom/path-bad-data-expected.png:
platform/qt/svg/custom/path-update-expected.png:
platform/qt/svg/custom/pattern-no-pixelation-expected.png:
platform/qt/svg/custom/pattern-scaled-pattern-space-expected.png: Added.
platform/qt/svg/custom/pattern-size-bigger-than-target-size-expected.png:
platform/qt/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.png:
platform/qt/svg/custom/pattern-y-offset-expected.png:
platform/qt/svg/custom/percentage-of-html-parent-expected.png:
platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
platform/qt/svg/custom/pointer-events-image-expected.png:
platform/qt/svg/custom/pointer-events-path-expected.png:
platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
platform/qt/svg/custom/pointer-events-text-expected.png:
platform/qt/svg/custom/poly-identify-expected.png:
platform/qt/svg/custom/polyline-hittest-expected.png:
platform/qt/svg/custom/polyline-invalid-points-expected.png:
platform/qt/svg/custom/relative-sized-content-with-resources-expected.png:
platform/qt/svg/custom/rootelement-expected.png:
platform/qt/svg/custom/rootmost-svg-xy-attrs-expected.png:
platform/qt/svg/custom/second-inline-text-expected.png:
platform/qt/svg/custom/shape-rendering-expected.png:
platform/qt/svg/custom/sheet-title-expected.png:
platform/qt/svg/custom/stroke-fallback-expected.png:
platform/qt/svg/custom/svg-float-border-padding-expected.png:
platform/qt/svg/custom/svg-fonts-in-html-expected.png:
platform/qt/svg/custom/svg-fonts-segmented-expected.png:
platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
platform/qt/svg/custom/svgpolyparser-extra-space-expected.png:
platform/qt/svg/custom/text-dom-01-f-expected.png:
platform/qt/svg/custom/text-filter-expected.png:
platform/qt/svg/custom/text-hit-test-expected.png:
platform/qt/svg/custom/text-letter-spacing-expected.png:
platform/qt/svg/custom/text-linking-expected.png:
platform/qt/svg/custom/text-whitespace-handling-expected.png:
platform/qt/svg/custom/text-x-dx-lists-expected.png:
platform/qt/svg/custom/text-x-dy-lists-expected.png:
platform/qt/svg/custom/text-x-override-in-tspan-child-expected.png:
platform/qt/svg/custom/transform-removeAttributeNS-expected.png:
platform/qt/svg/custom/transform-scale-parse-expected.png:
platform/qt/svg/custom/use-clipped-transform-expected.png:
platform/qt/svg/custom/use-dynamic-append-expected.png:
platform/qt/svg/custom/use-font-face-crash-expected.png:
platform/qt/svg/custom/use-nested-transform-expected.png:
platform/qt/svg/custom/use-on-clip-path-with-transformation-expected.png:
platform/qt/svg/custom/use-on-g-containing-foreignObject-and-image-expected.png:
platform/qt/svg/custom/use-on-g-containing-symbol-expected.png:
platform/qt/svg/custom/use-on-g-containing-use-expected.png:
platform/qt/svg/custom/use-on-g-expected.png:
platform/qt/svg/custom/use-on-rect-expected.png:
platform/qt/svg/custom/use-on-symbol-expected.png:
platform/qt/svg/custom/use-on-text-expected.png:
platform/qt/svg/custom/use-on-use-expected.png:
platform/qt/svg/custom/use-transform-expected.png:
platform/qt/svg/custom/viewport-no-width-height-expected.png:
platform/qt/svg/custom/viewport-update-expected.png:
platform/qt/svg/custom/visibility-override-clip-expected.png:
platform/qt/svg/custom/visibility-override-expected.png:
platform/qt/svg/custom/visibility-override-mask-expected.png:
platform/qt/svg/custom/width-full-percentage-expected.png:
platform/qt/svg/custom/xml-stylesheet-expected.png:
platform/qt/svg/dom/SVGLengthList-insertItemBefore-expected.png:
platform/qt/svg/dom/SVGPathSegList-cloning-expected.png:
platform/qt/svg/filters/animate-fill-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
platform/qt/svg/filters/big-sized-filter-expected.png:
platform/qt/svg/filters/feColorMatrix-offset-expected.png:
platform/qt/svg/filters/feColorMatrix-saturate-expected.png:
platform/qt/svg/filters/feDropShadow-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
platform/qt/svg/filters/feGaussianBlur-subregion-expected.png: Copied from LayoutTests/platform/qt/tables/mozilla/bugs/bug219693-1-expected.png.
platform/qt/svg/filters/filter-empty-g-expected.png:
platform/qt/svg/filters/filter-on-filter-for-text-expected.png:
platform/qt/svg/filters/filter-on-tspan-expected.png:
platform/qt/svg/filters/filter-placement-issue-expected.png:
platform/qt/svg/filters/filter-source-position-expected.png:
platform/qt/svg/filters/filterRes2-expected.png:
platform/qt/svg/foreignObject/clip-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
platform/qt/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png:
platform/qt/svg/foreignObject/filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
platform/qt/svg/foreignObject/mask-expected.png: Copied from LayoutTests/platform/qt/svg/custom/transform-scale-parse-expected.png.
platform/qt/svg/foreignObject/svg-document-as-direct-child-expected.png:
platform/qt/svg/foreignObject/svg-document-in-html-document-expected.png:
platform/qt/svg/hixie/cascade/001-broken-expected.png:
platform/qt/svg/hixie/error/012-expected.png:
platform/qt/svg/hixie/error/013-expected.png:
platform/qt/svg/hixie/links/001-expected.png:
platform/qt/svg/hixie/mixed/003-expected.png:
platform/qt/svg/hixie/shapes/path/001-expected.png:
platform/qt/svg/hixie/text/001-expected.png:
platform/qt/svg/hixie/text/003-expected.png:
platform/qt/svg/hixie/transform/001-expected.png:
platform/qt/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
platform/qt/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
platform/qt/svg/text/bidi-embedded-direction-expected.png:
platform/qt/svg/text/kerning-expected.png:
platform/qt/svg/text/scaled-font-expected.png:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
platform/qt/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
platform/qt/svg/text/small-fonts-in-html5-expected.png:
platform/qt/svg/text/text-align-04-b-expected.png:
platform/qt/svg/text/text-align-05-b-expected.png:
platform/qt/svg/text/text-deco-01-b-expected.png:
platform/qt/svg/text/text-path-middle-align-expected.png:
platform/qt/svg/text/text-text-04-t-expected.png:
platform/qt/svg/text/text-text-06-t-expected.png:
platform/qt/svg/text/text-text-07-t-expected.png:
platform/qt/svg/text/textPathBoundsBug-expected.png:
platform/qt/svg/wicd/rightsizing-grid-expected.png:
platform/qt/svg/wicd/test-rightsizing-a-expected.png:
platform/qt/svg/wicd/test-rightsizing-b-expected.png:
platform/qt/svg/wicd/test-scalable-background-image1-expected.png:
platform/qt/svg/wicd/test-scalable-background-image2-expected.png:
platform/qt/svg/zoom/page/zoom-background-image-tiled-expected.png:
platform/qt/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png:
platform/qt/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
platform/qt/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/qt/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
platform/qt/svg/zoom/page/zoom-svg-as-object-expected.png:
platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.png:
platform/qt/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.png:
platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.png:
platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
platform/qt/tables/layering/paint-test-layering-1-expected.png:
platform/qt/tables/layering/paint-test-layering-2-expected.png:
platform/qt/tables/mozilla/bugs/bug101201-expected.png:
platform/qt/tables/mozilla/bugs/bug102145-1-expected.png:
platform/qt/tables/mozilla/bugs/bug102145-2-expected.png:
platform/qt/tables/mozilla/bugs/bug102145-3-expected.png:
platform/qt/tables/mozilla/bugs/bug102145-4-expected.png:
platform/qt/tables/mozilla/bugs/bug10269-1-expected.png:
platform/qt/tables/mozilla/bugs/bug10296-1-expected.png:
platform/qt/tables/mozilla/bugs/bug10296-2-expected.png:
platform/qt/tables/mozilla/bugs/bug103533-expected.png:
platform/qt/tables/mozilla/bugs/bug1055-1-expected.png:
platform/qt/tables/mozilla/bugs/bug106158-1-expected.png:
platform/qt/tables/mozilla/bugs/bug106795-expected.png:
platform/qt/tables/mozilla/bugs/bug106816-expected.png:
platform/qt/tables/mozilla/bugs/bug109043-expected.png:
platform/qt/tables/mozilla/bugs/bug11321-expected.png:
platform/qt/tables/mozilla/bugs/bug113235-2-expected.png:
platform/qt/tables/mozilla/bugs/bug113235-3-expected.png:
platform/qt/tables/mozilla/bugs/bug11384q-expected.png:
platform/qt/tables/mozilla/bugs/bug11384s-expected.png:
platform/qt/tables/mozilla/bugs/bug1163-1-expected.png:
platform/qt/tables/mozilla/bugs/bug1188-expected.png:
platform/qt/tables/mozilla/bugs/bug11944-expected.png:
platform/qt/tables/mozilla/bugs/bug119786-expected.png:
platform/qt/tables/mozilla/bugs/bug1224-expected.png:
platform/qt/tables/mozilla/bugs/bug12709-expected.png:
platform/qt/tables/mozilla/bugs/bug127267-expected.png:
platform/qt/tables/mozilla/bugs/bug128229-expected.png:
platform/qt/tables/mozilla/bugs/bug131020-expected.png:
platform/qt/tables/mozilla/bugs/bug131020_iframe-expected.png:
platform/qt/tables/mozilla/bugs/bug13118-expected.png:
platform/qt/tables/mozilla/bugs/bug1318-expected.png:
platform/qt/tables/mozilla/bugs/bug13196-expected.png:
platform/qt/tables/mozilla/bugs/bug133756-2-expected.png:
platform/qt/tables/mozilla/bugs/bug133948-expected.png:
platform/qt/tables/mozilla/bugs/bug137388-1-expected.png:
platform/qt/tables/mozilla/bugs/bug139524-2-expected.png:
platform/qt/tables/mozilla/bugs/bug14159-1-expected.png:
platform/qt/tables/mozilla/bugs/bug14929-expected.png:
platform/qt/tables/mozilla/bugs/bug15247-expected.png:
platform/qt/tables/mozilla/bugs/bug154780-expected.png:
platform/qt/tables/mozilla/bugs/bug157890-expected.png:
platform/qt/tables/mozilla/bugs/bug15933-expected.png:
platform/qt/tables/mozilla/bugs/bug16012-expected.png:
platform/qt/tables/mozilla/bugs/bug16252-expected.png:
platform/qt/tables/mozilla/bugs/bug17138-expected.png:
platform/qt/tables/mozilla/bugs/bug17587-expected.png:
platform/qt/tables/mozilla/bugs/bug1800-expected.png:
platform/qt/tables/mozilla/bugs/bug1802-expected.png:
platform/qt/tables/mozilla/bugs/bug1802s-expected.png:
platform/qt/tables/mozilla/bugs/bug1818-1-expected.png:
platform/qt/tables/mozilla/bugs/bug1818-2-expected.png:
platform/qt/tables/mozilla/bugs/bug1818-4-expected.png:
platform/qt/tables/mozilla/bugs/bug18359-expected.png:
platform/qt/tables/mozilla/bugs/bug18664-expected.png:
platform/qt/tables/mozilla/bugs/bug18955-expected.png:
platform/qt/tables/mozilla/bugs/bug19061-1-expected.png:
platform/qt/tables/mozilla/bugs/bug19061-2-expected.png:
platform/qt/tables/mozilla/bugs/bug194024-expected.png:
platform/qt/tables/mozilla/bugs/bug19599-expected.png:
platform/qt/tables/mozilla/bugs/bug2050-expected.png:
platform/qt/tables/mozilla/bugs/bug20579-expected.png:
platform/qt/tables/mozilla/bugs/bug20804-expected.png:
platform/qt/tables/mozilla/bugs/bug21299-expected.png:
platform/qt/tables/mozilla/bugs/bug215629-expected.png:
platform/qt/tables/mozilla/bugs/bug219693-1-expected.png:
platform/qt/tables/mozilla/bugs/bug219693-2-expected.png:
platform/qt/tables/mozilla/bugs/bug221784-1-expected.png:
platform/qt/tables/mozilla/bugs/bug221784-2-expected.png:
platform/qt/tables/mozilla/bugs/bug222846-expected.png:
platform/qt/tables/mozilla/bugs/bug2267-expected.png:
platform/qt/tables/mozilla/bugs/bug23072-expected.png:
platform/qt/tables/mozilla/bugs/bug23299-expected.png:
platform/qt/tables/mozilla/bugs/bug24627-expected.png:
platform/qt/tables/mozilla/bugs/bug2469-expected.png:
platform/qt/tables/mozilla/bugs/bug2479-2-expected.png:
platform/qt/tables/mozilla/bugs/bug24880-expected.png:
platform/qt/tables/mozilla/bugs/bug25074-expected.png:
platform/qt/tables/mozilla/bugs/bug25086-expected.png:
platform/qt/tables/mozilla/bugs/bug2509-expected.png:
platform/qt/tables/mozilla/bugs/bug25367-expected.png:
platform/qt/tables/mozilla/bugs/bug25663-expected.png:
platform/qt/tables/mozilla/bugs/bug2684-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-2-expected.png:
platform/qt/tables/mozilla/bugs/bug27038-3-expected.png:
platform/qt/tables/mozilla/bugs/bug2773-expected.png:
platform/qt/tables/mozilla/bugs/bug2886-2-expected.png:
platform/qt/tables/mozilla/bugs/bug28928-expected.png:
platform/qt/tables/mozilla/bugs/bug29058-3-expected.png:
platform/qt/tables/mozilla/bugs/bug29429-expected.png:
platform/qt/tables/mozilla/bugs/bug2981-1-expected.png:
platform/qt/tables/mozilla/bugs/bug2981-2-expected.png:
platform/qt/tables/mozilla/bugs/bug2997-expected.png:
platform/qt/tables/mozilla/bugs/bug3037-1-expected.png:
platform/qt/tables/mozilla/bugs/bug3037-2-expected.png:
platform/qt/tables/mozilla/bugs/bug30418-expected.png:
platform/qt/tables/mozilla/bugs/bug30559-expected.png:
platform/qt/tables/mozilla/bugs/bug30692-expected.png:
platform/qt/tables/mozilla/bugs/bug3103-expected.png:
platform/qt/tables/mozilla/bugs/bug32205-2-expected.png:
platform/qt/tables/mozilla/bugs/bug32205-3-expected.png:
platform/qt/tables/mozilla/bugs/bug32447-expected.png:
platform/qt/tables/mozilla/bugs/bug3260-expected.png:
platform/qt/tables/mozilla/bugs/bug32841-expected.png:
platform/qt/tables/mozilla/bugs/bug3309-1-expected.png:
platform/qt/tables/mozilla/bugs/bug3309-2-expected.png:
platform/qt/tables/mozilla/bugs/bug34538-expected.png:
platform/qt/tables/mozilla/bugs/bug3454-expected.png:
platform/qt/tables/mozilla/bugs/bug3681-1-expected.png:
platform/qt/tables/mozilla/bugs/bug3681-2-expected.png:
platform/qt/tables/mozilla/bugs/bug38916-expected.png:
platform/qt/tables/mozilla/bugs/bug3977-expected.png:
platform/qt/tables/mozilla/bugs/bug41890-expected.png:
platform/qt/tables/mozilla/bugs/bug42187-expected.png:
platform/qt/tables/mozilla/bugs/bug4284-expected.png:
platform/qt/tables/mozilla/bugs/bug43039-expected.png:
platform/qt/tables/mozilla/bugs/bug4382-expected.png:
platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
platform/qt/tables/mozilla/bugs/bug43854-2-expected.png:
platform/qt/tables/mozilla/bugs/bug4427-expected.png:
platform/qt/tables/mozilla/bugs/bug45055-2-expected.png:
platform/qt/tables/mozilla/bugs/bug4523-expected.png:
platform/qt/tables/mozilla/bugs/bug45350-expected.png:
platform/qt/tables/mozilla/bugs/bug45486-expected.png:
platform/qt/tables/mozilla/bugs/bug46268-1-expected.png:
platform/qt/tables/mozilla/bugs/bug46268-2-expected.png:
platform/qt/tables/mozilla/bugs/bug46268-5-expected.png:
platform/qt/tables/mozilla/bugs/bug46268-expected.png:
platform/qt/tables/mozilla/bugs/bug46368-1-expected.png:
platform/qt/tables/mozilla/bugs/bug46368-2-expected.png:

6:29 AM Changeset in webkit [146876] by kadam@inf.u-szeged.hu

2 edits
5 adds in trunk/LayoutTests

[Qt] Unreviewed gardneing. Unskipped and Updated inspector tests after r146863.

platform/qt/TestExpectations:
platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Added.
platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
platform/qt/inspector/extensions/extensions-eval-expected.txt: Added.

6:22 AM Changeset in webkit [146875] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Decorations in several consecutive lines are not moved correctly in DTE.
https://bugs.webkit.org/show_bug.cgi?id=113296

Reviewed by Pavel Feldman.

Separated removing and adding decorations so that moved decorations are not removed when next line is processed.

inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorGutterPanel.prototype.textChanged):

6:17 AM Changeset in webkit [146874] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Remove references to non-chromium entries from WebCore.gypi (part 2)
https://bugs.webkit.org/show_bug.cgi?id=103124

Reviewed by Pavel Feldman.

WebCore.gypi: removed unused references to gtk, cf, win and mac

5:31 AM Changeset in webkit [146873] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed GTK gardening.

Scripts/run-gtk-tests:

(TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.

5:08 AM Changeset in webkit [146872] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit/qt

[Qt] Fix tst_QWebElement::render() API test
https://bugs.webkit.org/show_bug.cgi?id=65243

Reviewed by Jocelyn Turcotte.

Unmark the passing part of this testcase.

tests/qwebelement/tst_qwebelement.cpp:

(tst_QWebElement::render):

5:01 AM Changeset in webkit [146871] by commit-queue@webkit.org

9 edits in trunk/Source

Unreviewed, rolling out r146767.
http://trac.webkit.org/changeset/146767
https://bugs.webkit.org/show_bug.cgi?id=113295

Rolling out until nicer fonts / sizes are chosen (Requested by
pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-26

Source/WebCore:

inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):
(.drawer-header-close-button):

inspector/front-end/inspectorCommon.css:

(body):

inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(.tabbed-pane-header-tab-close-button):

inspector/front-end/timelinePanel.css:

(.timeline-tree-item .count):
(.timeline-records-stats, .storage-application-cache-status, .storage-application-cache-connectivity):
(.memory-counter-sidebar-info):
(.memory-counter-value):

Source/WebKit/chromium:

src/js/devTools.css:

4:57 AM Changeset in webkit [146870] by zarvai@inf.u-szeged.hu

287 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

platform/qt/svg/W3C-SVG-1.1/animate-elem-28-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-32-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-44-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/color-prof-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/color-prop-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/color-prop-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/color-prop-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-coord-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-coord-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-trans-06-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-light-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/interact-dom-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-a-07-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-uri-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/masking-path-05-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-fill-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-fill-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-marker-03-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-render-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-09-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-12-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-13-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-14-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/paths-data-15-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-06-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-07-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/render-elems-08-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/script-handle-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/script-handle-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/script-handle-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-line-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-dom-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-dom-06-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-frag-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-frag-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-group-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-group-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-08-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-image-09-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-use-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/struct-use-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-css-06-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-text-08-b-expected.png:
platform/qt/svg/W3C-SVG-1.1/text-tref-01-b-expected.png:
platform/qt/svg/as-background-image/animated-svg-as-background-expected.png:
platform/qt/svg/as-background-image/background-image-preserveaspectRatio-support-expected.png:
platform/qt/svg/as-background-image/same-image-two-instances-background-image-expected.png:
platform/qt/svg/as-background-image/svg-as-background-with-relative-size-expected.png:
platform/qt/svg/as-border-image/svg-as-border-image-2-expected.png:
platform/qt/svg/as-border-image/svg-as-border-image-expected.png:
platform/qt/svg/as-image/image-respects-pageScaleFactor-expected.png:
platform/qt/svg/as-image/same-image-two-instances-expected.png:
platform/qt/svg/batik/filters/feTile-expected.png:
platform/qt/svg/batik/paints/patternRegions-expected.png:
platform/qt/svg/batik/paints/patternRegions-positioned-objects-expected.png:
platform/qt/svg/batik/text/textEffect-expected.png:
platform/qt/svg/batik/text/textEffect3-expected.png:
platform/qt/svg/batik/text/textLayout-expected.png:
platform/qt/svg/batik/text/textOnPath3-expected.png:
platform/qt/svg/batik/text/textStyles-expected.png:
platform/qt/svg/batik/text/xmlSpace-expected.png:
platform/qt/svg/clip-path/clip-in-mask-expected.png:
platform/qt/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png:
platform/qt/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png:
platform/qt/svg/clip-path/clip-path-childs-clipped-expected.png:
platform/qt/svg/clip-path/clip-path-clipped-evenodd-twice-expected.png:
platform/qt/svg/clip-path/clip-path-clipped-expected.png:
platform/qt/svg/clip-path/clip-path-clipped-nonzero-expected.png:
platform/qt/svg/clip-path/clip-path-css-transform-1-expected.png:
platform/qt/svg/clip-path/clip-path-css-transform-2-expected.png:
platform/qt/svg/clip-path/clip-path-objectBoundingBox-expected.png:
platform/qt/svg/clip-path/clip-path-on-clipped-use-expected.png:
platform/qt/svg/clip-path/clip-path-on-g-and-child-expected.png:
platform/qt/svg/clip-path/clip-path-on-g-expected.png:
platform/qt/svg/clip-path/clip-path-on-svg-and-child-expected.png:
platform/qt/svg/clip-path/clip-path-on-svg-expected.png:
platform/qt/svg/clip-path/clip-path-recursive-call-by-child-expected.png:
platform/qt/svg/clip-path/clip-path-recursive-call-expected.png:
platform/qt/svg/clip-path/clip-path-transform-1-expected.png:
platform/qt/svg/clip-path/clip-path-transform-2-expected.png:
platform/qt/svg/clip-path/clip-path-use-as-child-expected.png:
platform/qt/svg/clip-path/clip-path-userSpaceOnUse-expected.png:
platform/qt/svg/clip-path/clip-path-with-different-unittypes-expected.png:
platform/qt/svg/clip-path/clip-path-with-different-unittypes2-expected.png:
platform/qt/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png:
platform/qt/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png:
platform/qt/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png:
platform/qt/svg/css/css-box-min-width-expected.png:
platform/qt/svg/css/group-with-shadow-expected.png:
platform/qt/svg/css/mask-with-shadow-expected.png:
platform/qt/svg/css/path-gradient-stroke-shadow-expected.png:
platform/qt/svg/css/rect-gradient-stroke-shadow-expected.png:
platform/qt/svg/custom/SVGMatrix-interface-expected.png:
platform/qt/svg/custom/SVGNumber-interface-expected.png:
platform/qt/svg/custom/SVGPoint-interface-expected.png:
platform/qt/svg/custom/SVGRect-interface-expected.png:
platform/qt/svg/custom/alignment-baseline-modes-expected.png:
platform/qt/svg/custom/bug45331-expected.png:
platform/qt/svg/custom/circular-marker-reference-2-expected.png:
platform/qt/svg/custom/class-baseValue-expected.png:
platform/qt/svg/custom/clip-mask-negative-scale-expected.png:
platform/qt/svg/custom/clip-path-referencing-use-expected.png:
platform/qt/svg/custom/clip-path-with-transform-expected.png:
platform/qt/svg/custom/conditional-processing-outside-switch-expected.png:
platform/qt/svg/custom/container-opacity-clip-viewBox-expected.png:
platform/qt/svg/custom/control-points-for-S-and-T-expected.png:
platform/qt/svg/custom/convolution-crash-expected.png:
platform/qt/svg/custom/create-metadata-element-expected.png:
platform/qt/svg/custom/createelement-expected.png:
platform/qt/svg/custom/display-none-expected.png:
platform/qt/svg/custom/dominant-baseline-hanging-expected.png:
platform/qt/svg/custom/dominant-baseline-modes-expected.png:
platform/qt/svg/custom/dynamic-svg-document-creation-expected.png:
platform/qt/svg/custom/embedding-external-svgs-expected.png:
platform/qt/svg/custom/empty-clip-path-expected.png:
platform/qt/svg/custom/evt-onload-expected.png:
platform/qt/svg/custom/fill-SVGPaint-interface-expected.png:
platform/qt/svg/custom/fill-fallback-expected.png:
platform/qt/svg/custom/fill-update-expected.png:
platform/qt/svg/custom/fractional-rects-expected.png:
platform/qt/svg/custom/getPresentationAttribute-expected.png:
platform/qt/svg/custom/getscreenctm-in-mixed-content-expected.png:
platform/qt/svg/custom/getsvgdocument-expected.png:
platform/qt/svg/custom/gradient-attr-update-expected.png:
platform/qt/svg/custom/gradient-cycle-detection-expected.png:
platform/qt/svg/custom/gradient-rotated-bbox-expected.png:
platform/qt/svg/custom/gradient-stop-corner-cases-expected.png:
platform/qt/svg/custom/group-opacity-expected.png:
platform/qt/svg/custom/hit-test-with-br-expected.png:
platform/qt/svg/custom/image-parent-translation-expected.png:
platform/qt/svg/custom/image-rescale-scroll-expected.png:
platform/qt/svg/custom/image-with-aspect-ratio-stretch-expected.png:
platform/qt/svg/custom/image-with-transform-clip-filter-expected.png:
platform/qt/svg/custom/inner-svg-hit-test-expected.png:
platform/qt/svg/custom/invalid-fill-expected.png:
platform/qt/svg/custom/invalid-fill-hex-expected.png:
platform/qt/svg/custom/invalid-lengthlist-expected.png:
platform/qt/svg/custom/invalid-stroke-hex-expected.png:
platform/qt/svg/custom/invalid-uri-stroke-expected.png:
platform/qt/svg/custom/invisible-text-after-scrolling-expected.png:
platform/qt/svg/custom/junk-data-expected.png:
platform/qt/svg/custom/large-bounding-box-percents-expected.png:
platform/qt/svg/custom/linking-a-03-b-transform-expected.png:
platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
platform/qt/svg/custom/linking-uri-01-b-expected.png:
platform/qt/svg/custom/marker-changes-expected.png:
platform/qt/svg/custom/marker-empty-path-expected.png:
platform/qt/svg/custom/mask-changes-expected.png:

4:52 AM Changeset in webkit [146869] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

Fix unused parameter warnings in JITInlines.h
https://bugs.webkit.org/show_bug.cgi?id=112560

Reviewed by Zoltan Herczeg.

jit/JITInlines.h:

(JSC::JIT::beginUninterruptedSequence):
(JSC::JIT::endUninterruptedSequence):
(JSC):

4:49 AM Changeset in webkit [146868] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
https://bugs.webkit.org/show_bug.cgi?id=113287

Reviewed by Jocelyn Turcotte.

Scripts/run-qtwebkit-tests:

(Options.init):

4:37 AM Changeset in webkit [146867] by commit-queue@webkit.org

3 edits
2 adds in trunk

Unable to insert a paragraph in between some text whose previous sibling is a non-editable block.
https://bugs.webkit.org/show_bug.cgi?id=113007

Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Unable to insert a line break in between a text that follows a
non-editable block but is itself contained within an editable
block.

While comparing the positions from the start block till the
insertion position, we should ignore the nodes that do not
generate a visiblePosition for the position before the node.
This ultimately results in an assert within comparePositions().

For this case, the firstChild of the start block is a text
node with no renderer which would thus not generate a candidate
position for itself.
There is also no candidate previous to it, and since
the position after it lies within a different editable element (root),
no candidate after it as well.
Such a point will thus return a null visiblePosition.

Test: editing/inserting/insert-paragraph-between-text.html

editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):
Added a check to verify the generated visiblePosition (for the
position before the node) prior to carrying out a comparison with
the insertion point.

LayoutTests:

editing/inserting/insert-paragraph-between-text-expected.txt: Added.
editing/inserting/insert-paragraph-between-text.html: Added.

Added a layout test case for verifying the behavior when trying
to insert a line break between an editable text with a non-editable
block as it's previous sibling.

4:23 AM Changeset in webkit [146866] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error.
https://bugs.webkit.org/show_bug.cgi?id=113138

Reviewed by Pavel Feldman.

The old version had problem with rounding because it recalculates the window size on each event.
The new version just calculates the dragging delta and moves the window
to the new position based on the initial values and the delta.

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):

3:44 AM Changeset in webkit [146865] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Memory leak in UserMediaClientImpl
https://bugs.webkit.org/show_bug.cgi?id=112998

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26
Reviewed by Rob Buis.

PR 312559
Internally Reviewed by Anthony Scian.

Should destroy itself in UserMediaClientImpl::pageDestroyed(), as other
XXClientBlackBerry did, like GeolocationClientBlackBerry::geolocationDestroyed().

WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::UserMediaClientImpl::pageDestroyed):

3:41 AM Changeset in webkit [146864] by commit-queue@webkit.org

6 edits in trunk

[EFL] Enable IndexedDB by default
https://bugs.webkit.org/show_bug.cgi?id=107248

Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-03-26
Reviewed by Laszlo Gombos.

Source/cmake/OptionsEfl.cmake:

Enable IndexedDB by default on EFL.

Tools:

Scripts/webkitperl/FeatureList.pm:

Enable IndexedDB by default on EFL.

LayoutTests:

platform/efl/TestExpectations:

Unskip the tests now that IndexDB is enabled (except the ones
that actually fail).

3:39 AM Changeset in webkit [146863] by kadam@inf.u-szeged.hu

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/TestExpectations: Skipped some failing tests.
platform/qt/css3/filters/effect-reference-expected.png: Updated after r146779.
platform/qt/css3/filters/effect-reference-expected.txt: Update after r146779.

1:43 AM Changeset in webkit [146862] by zarvai@inf.u-szeged.hu

10 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r146814.

platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt:

1:40 AM Changeset in webkit [146861] by commit-queue@webkit.org

3 edits in trunk/Tools

Sheriffbot should explain rollout failures in a human readable form.
https://bugs.webkit.org/show_bug.cgi?id=107092

Patch by Alan Cutter <alancutter@chromium.org> on 2013-03-26
Reviewed by Ryosuke Niwa.

Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).

Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout._check_diff_failure):
(Rollout.execute):

Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_rollout):

1:26 AM Changeset in webkit [146860] by tkent@chromium.org

11 edits in trunk/Source/WebCore

Rename HTMLInputElement::isIndeterminate to Element::shouldAppearIndeterminate
https://bugs.webkit.org/show_bug.cgi?id=113264

Reviewed by Kentaro Hara.

HTMLInputElement had indeterminate() and isIndeterminate(). It's very
confusing.

Because indeterminate is a public DOM function and isIndeterminate is
for CSS and rendering, we rename isIndetermiante to
shouldAppearIndeterminate. Also, HTMLProgressElement, which support
:indeterminate pseudo class, should follow it. We add
shouldAppearIndeterminate to Element.

No new tests. Just a refactoring.

dom/Element.cpp:

(WebCore::Element::shouldAppearIndeterminate): Added. Returns false.

dom/Element.h:

(Element): Declare shouldAppearIndeterminate.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::shouldAppearIndeterminate):
Renamed from isIndeterminate.

html/HTMLInputElement.h:

(HTMLInputElement): Rename isIndeterminate to shouldAppearIndeterminate,
and overrides Element::shouldAppearIndeterminate.

html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::shouldAppearIndeterminate): Added.

html/HTMLProgressElement.h: Add shouldAppearIndeterminate.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isIndeterminate):
Use shouldAppearIndeterminate.

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne): Ditto.

css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl): Ditto.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isIndeterminate): Ditto.

1:21 AM Changeset in webkit [146859] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed GTK gardening.

Scripts/run-gtk-tests:

(TestRunner): Skipping a failing unit test after r146518.

1:20 AM Changeset in webkit [146858] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [FlameChart] Make function bar highlighted consistent with cursor.
https://bugs.webkit.org/show_bug.cgi?id=113266.

Patch by Pan Deng <pan.deng@intel.com> on 2013-03-26
Reviewed by Vsevolod Vlasov.

In Flamechart, the highlighted function bar is not consistent with cursor sometimes,
reason is that time range that converted from cursor position is truncated by floor.
Actually float value is expected to compare with function startTime and duration.

No new tests.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._coordinatesToNodeIndex): Remove floor

1:09 AM Changeset in webkit [146857] by zandobersek@gmail.com

4 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adjusting expectation for inspector/debugger/live-edit-breakpoints.html after r146840.
platform/gtk/fast/text/international/khmer-selection-expected.txt: Rebaselining after r146778.
platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Rebaselining

after r146763.

12:54 AM Changeset in webkit [146856] by mihnea@adobe.com

3 edits
2 adds in trunk

[CSSRegions]: Crash accessing offsetParent for contentNodes inside a flow thread
https://bugs.webkit.org/show_bug.cgi?id=112730

Reviewed by Levi Weintraub.

Source/WebCore:

When computing the offsetParent for an element inside a flow thread, do not
let the algorithm process past the flow thread boundaries, until we figure out
the proper behavior. When reaching the flow thread, offsetParent will return 0,
thus preventing the assert while calling toElement inside Element::offsetParent.

The attached test sets the ground work and will be changed to match the right behavior.
For now, it makes sure we do not crash or return HTMLDocument as offsetParent for
elements inside the flow thread.

Test: fast/regions/offsetParent-in-flow-thread.html

rendering/RenderObject.cpp:

(WebCore::RenderObject::offsetParent):

LayoutTests:

fast/regions/offsetParent-in-flow-thread-expected.txt: Added.
fast/regions/offsetParent-in-flow-thread.html: Added.

12:51 AM Changeset in webkit [146855] by dominik.rottsches@intel.com

6 edits
2 deletes in trunk/Source/WebCore

Remove HarfBuzzShaperBase
https://bugs.webkit.org/show_bug.cgi?id=112087

Reviewed by Martin Robinson.

Folding HarfBuzzShaperBase into HarfBuzzShaper since
there is no harfbuzz-old vs. harfbuzz-ng distinction anymore.

No new tests, no change in behavior.

GNUmakefile.list.am: Removing HarfBuzzShaperBase.*
PlatformEfl.cmake: Removing HarfBuzzShaperBase.*
WebCore.gypi: Removing HarfBuzzShaperBase.*
platform/graphics/harfbuzz/HarfBuzzShaper.cpp: Folding base class members and methods into HarfBuzzShaper.

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::normalizeSpacesAndMirrorChars):
(WebCore):
(WebCore::HarfBuzzShaper::setNormalizedBuffer):
(WebCore::HarfBuzzShaper::isWordEnd):
(WebCore::HarfBuzzShaper::determineWordBreakSpacing):
(WebCore::HarfBuzzShaper::setPadding):

platform/graphics/harfbuzz/HarfBuzzShaper.h: Folding base class members and methods into HarfBuzzShaper.

(HarfBuzzShaper):
(WebCore::HarfBuzzShaper::isCodepointSpace):

platform/graphics/harfbuzz/HarfBuzzShaperBase.cpp: Removed.
platform/graphics/harfbuzz/HarfBuzzShaperBase.h: Removed.

12:33 AM Changeset in webkit [146854] by yurys@chromium.org

3 edits in trunk/LayoutTests

Unreviewed. Rebaseline fast/canvas/canvas-toDataURL-webp.html

platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-toDataURL-webp-expected.png:

Mar 25, 2013:

11:39 PM Changeset in webkit [146853] by morrita@google.com

6 edits
2 adds in trunk

Listening touch events on ShadowRoot can crash.
https://bugs.webkit.org/show_bug.cgi?id=113035

Reviewed by Kentaro Hara.

Source/WebCore:

TreeScope destructor clears a document reference on ShadowRoot but
destructors of ContainerNode and Node assumed it being available
and tried to access it for some cleanup purposes.

This change extracts such cleanup to Node::willBeDeletedFrom() and
calls it from ShadowRoot dtor before the document reference gets cleared.

Test: fast/dom/shadow/shadow-root-touch-listener-crash.html

dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode): Adopted willBeDeletedFrom()

dom/Node.cpp:

(WebCore::Node::~Node): Adopted willBeDeletedFrom()
(WebCore::Node::willBeDeletedFrom): Extracted from Node and ContainerNode
(WebCore):

dom/Node.h:
dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::~ShadowRoot): Adopted willBeDeletedFrom()

LayoutTests:

fast/dom/shadow/shadow-root-touch-listener-crash-expected.txt: Added.
fast/dom/shadow/shadow-root-touch-listener-crash.html: Added.

11:35 PM Changeset in webkit [146852] by rniwa@webkit.org

2 edits in trunk/Tools

Remove Lion leaks builder
https://bugs.webkit.org/show_bug.cgi?id=113252

Reviewed by Andreas Kling.

Removed.

BuildSlaveSupport/build.webkit.org-config/config.json:

11:35 PM Changeset in webkit [146851] by morrita@google.com

6 edits
2 deletes in trunk/Source/WebCore

Custom Elements Refactoring: The name V8CustomElement is confusing.
https://bugs.webkit.org/show_bug.cgi?id=113165

Reviewed by Kent Tamura.

This change moves functions from V8CustomElement to CustomElementHelpers and
removes V8CustomElement. V8CustomElement is just a heritage of old design
and no longer makes sense.

No new tests. No behavior change.

WebCore.gypi:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::createWrapper):
(WebCore):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):
(WebCore::CustomElementHelpers::wrap):
(WebCore):
(WebCore::CustomElementHelpers::constructorOf):

bindings/v8/V8CustomElement.cpp: Removed.
bindings/v8/V8CustomElement.h: Removed.
bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

dom/make_names.pl:

(printWrapperFactoryCppFile):

11:07 PM Changeset in webkit [146850] by jamesr@google.com

5 edits
1 add
1 delete in trunk/LayoutTests

Update a few more chromium compositor baselines.

platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.

9:51 PM Changeset in webkit [146849] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Records sidebar is clipped.
https://bugs.webkit.org/show_bug.cgi?id=113177

Reviewed by Pavel Feldman.

Analysis: depending on CSS injection order sidebar rule that overwrites
"bottom" property may win.

Fix: make timeline-specific rule "important".

inspector/front-end/timelinePanel.css:

(.timeline .sidebar): Make "bottom" value "important".

9:04 PM Changeset in webkit [146848] by noel.gordon@gmail.com

4 edits in trunk/LayoutTests

[chromium] Rebaseline canvas-toDataURL-webp test expectations
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

platform/chromium-mac/fast/canvas/canvas-toDataURL-webp-expected.png:
platform/chromium-win/fast/canvas/canvas-toDataURL-webp-expected.png:
platform/chromium/TestExpectations:

8:28 PM Changeset in webkit [146847] by tkent@chromium.org

35 edits in trunk

Rename ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=113254

Reviewed by Kentaro Hara.

Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
Actually I'd like to remove the code, but we shouldn't remove it yet
because we shipped products with it on some platforms.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):

css/html.css:
html/DateTimeInputType.cpp:
html/DateTimeInputType.h:
html/InputType.cpp:

(WebCore::createInputTypeFactoryMap):

Source/WebKit/blackberry:

WebCoreSupport/AboutDataEnableFeatures.in:

Source/WebKit/chromium:

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableInputTypeDateTime):
(WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled):

tests/WebViewTest.cpp:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
qmake/mkspecs/features/features.pri:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.props:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

platform/chromium/TestExpectations:

8:19 PM Changeset in webkit [146846] by rniwa@webkit.org

4 edits in trunk/LayoutTests

REGRESSION(r146657): NRWT shouldn't report image only failures when pixel tests are disabled
https://bugs.webkit.org/show_bug.cgi?id=113261

Reviewed by Dirk Pranke.

Fixed the bug by treating ['TEXT', 'IMAGE'] as a flaky pass when the pixel tests is disabled
since the second token implies that we've forced pixel tests in retry and didn't have text failures.

fast/harness/resources/results-test.js:
fast/harness/results.html:
fast/harness/results-expected.txt:

8:13 PM Changeset in webkit [146845] by mary.wu@torchmobile.com.cn

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] add needReferer in WebPage load() api
https://bugs.webkit.org/show_bug.cgi?id=113167

Reviewed by Rob Buis.

PR310175, internally reviewed by Joe Mason.
Sometimes when client load request, it need to add referer with current frame like
save link/image in option menu, so we add needRef in load() interface in webpage.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::load):
(BlackBerry::WebKit::WebPage::loadExtended):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::download):

Api/WebPage.h:
Api/WebPage_p.h:

(WebPagePrivate):

8:11 PM Changeset in webkit [146844] by tony@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, update Efl test expectations to mark new test as failing.
Efl doesn't implement the Pasteboard class.

platform/efl/TestExpectations: Mark editing/pasteboard/copy-image-with-alt-text.html as failing

8:02 PM Changeset in webkit [146843] by danakj@chromium.org

7 edits
1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

chromium/public/WebVideoFrame.h:
chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

This moves ownership of the compositor's video layer over to the
implementation of WebMediaPlayer, as well as all interaction
between the media player system and the compositor layer or its
interfaces such as cc::VideoFrameProvider.

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

WebKit.gypi:
public/WebMediaPlayer.h:

(WebKit):

public/WebMediaPlayerClient.h:
public/WebStreamTextureClient.h:
src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::setWebLayer):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::needsWebLayer):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Removed.

7:51 PM Changeset in webkit [146842] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190515. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

DEPS:

7:43 PM Changeset in webkit [146841] by jamesr@google.com

20 edits
3 copies
1 add
10 deletes in trunk/LayoutTests

Update more expectations and baselines for r146826

platform/chromium-linux-x86/compositing/iframes/scrolling-iframe-expected.txt: Copied from LayoutTests/platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt.
platform/chromium-linux/compositing/iframes/scrolling-iframe-expected.txt:
platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt: Removed.
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Removed.
platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
platform/chromium-win/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.
platform/chromium-win/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium/TestExpectations:
platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/iframe-resize-expected.txt:
platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/resizer-expected.txt:
platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:

7:35 PM Changeset in webkit [146840] by timothy@apple.com

9 edits
5 adds in trunk

Make the Web Inspector console work in strict mode with JavaScriptCore.

https://webkit.org/b/65829
rdar://problem/11271238

Reviewed by Oliver Hunt.

Source/WebCore:

bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::evaluate):
Return the evalFunction directly.

inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
Added. Return true on JSC and false on V8.

inspector/InjectedScriptHost.idl:

Added evaluateReturnsEvalFunction and change evaluate to an attribute on JSC.

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn): Change from using 'with' statements to creating
a closure that evaluates the expression. The command line APIs are passed as parameters
to the closure so they are in scope but not injected. This allows the code evaluated in
the console to stay in strict mode (if is was already set), or to get strict mode by
prefixing expressions with 'use strict';.

LayoutTests:

inspector/debugger/mutation-observer-suspend-while-paused.html: Tweaked.
inspector/console/command-line-api-expected.txt: Updated.

platform/mac/http/tests/inspector/console-resource-errors-expected.txt: Added.
platform/mac/http/tests/inspector/console-websocket-error-expected.txt: Updated.
platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Added.
platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Added.
platform/mac/inspector/extensions/extensions-eval-expected.txt: Added.

Added new expectations to match the new console evaluate approach.

7:14 PM Changeset in webkit [146839] by jamesr@google.com

3 edits
4 copies
2 moves
5 adds
10 deletes in trunk/LayoutTests

Update chromium baselines for windows related to r146826

platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-mac/compositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Removed.
platform/chromium-win-xp/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium-win/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Copied from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Renamed from LayoutTests/platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium/TestExpectations:
platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
platform/chromium/compositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-fixed-expected.txt: Added.
platform/chromium/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt.

7:02 PM Changeset in webkit [146838] by rniwa@webkit.org

2 edits in trunk/Tools

Remove one more line that was intended to be removed in r146657.

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

6:44 PM Changeset in webkit [146837] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r146816, r146821, and r146830.
http://trac.webkit.org/changeset/146816
http://trac.webkit.org/changeset/146821
http://trac.webkit.org/changeset/146830
https://bugs.webkit.org/show_bug.cgi?id=113262

Broke all the Windows tests (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

platform/win/TestExpectations:

6:36 PM Changeset in webkit [146836] by jamesr@google.com

2 edits in trunk/LayoutTests

Revert bad change to expectation from r146826

compositing/geometry/object-clip-rects-assertion-expected.txt:

6:33 PM Changeset in webkit [146835] by tony@chromium.org

25 edits
2 adds in trunk

Image alt text not included in plain-text version when copying
https://bugs.webkit.org/show_bug.cgi?id=11200

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a setting to enable copying image alt text to the clipboard and drag and drop pasteboard.
This setting is disabled by default, so each port can enable if they want to match IE10 and
Firefox's behavior.

Test: editing/pasteboard/copy-image-with-alt-text.html

editing/Editor.cpp:

(WebCore::Editor::cut): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::copy): Explicitly ask that the selection on the pasteboard as being for the clipboard.
(WebCore::Editor::selectedText): Add a private version of selectedText() that can choose between having image alt text or not.
(WebCore::Editor::selectedTextForClipboard): Ask for image alt text if the setting is enabled.

editing/Editor.h:
editing/TextIterator.cpp:

(WebCore::TextIterator::TextIterator): Add a bool to keep track of whether or not to emit image alt text.
(WebCore::TextIterator::handleReplacedElement): If there's alt text, point the iterator to it.

editing/TextIterator.h:

(TextIterator):

editing/mac/EditorMac.mm:

(WebCore::Editor::takeFindStringFromSelection): Use the same text as on the clipboard.
(WebCore::Editor::writeSelectionToPasteboard): Don't include image alt text since this is
used by Services.
(WebCore::Editor::stringSelectionForPasteboard): Don't include image alt text since this is
used by Services.

page/DragController.cpp:

(WebCore::DragController::startDrag): Use image alt text (matches Firefox).

page/Settings.in: Add a setting that disables image alt text by default.
platform/Pasteboard.h:
platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/chromium/ClipboardChromium.cpp:

(WebCore::ClipboardChromium::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/efl/PasteboardEfl.cpp:

(WebCore::Pasteboard::writeSelection): Update function param.

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getStringSelection): Use ShouldSerializeSelectedTextForClipboard to determine whether the selected
text is for the clipboard or not.
(WebCore::Pasteboard::writeSelectionForTypes): Pass ShouldSerializeSelectedTextForClipboard through.
(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange): Use clipboard text when writing ranges (used by d&d).

platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::writeSelection): Add ShouldSerializeSelectedTextForClipboard parameter.

rendering/RenderImage.h:

(WebCore::RenderImage::altText): Add a getter for the alt text.

LayoutTests:

editing/pasteboard/copy-image-with-alt-text-expected.txt: Added.
editing/pasteboard/copy-image-with-alt-text.html: Added.

6:23 PM Changeset in webkit [146834] by jamesr@google.com

3 edits
9 moves
13 adds
2 deletes in trunk/LayoutTests

Update chromium mac 10.6 and 10.8 baselines for r146826.

platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt.
platform/chromium-win/compositing/geometry/composited-in-columns-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/geometry/composited-in-columns-expected.txt.
platform/chromium-win/css3/filters/filtered-compositing-descendant-expected.txt: Renamed from LayoutTests/platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt.

6:02 PM Changeset in webkit [146833] by dino@apple.com

10 edits
2 deletes in trunk/Source/WebCore

Remove autostart hashing code from WebCore
https://bugs.webkit.org/show_bug.cgi?id=113242

Reviewed by Tim Horton.

Remove PlugInOriginHash and all the related build entries.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
html/HTMLPlugInImageElement.cpp:
plugins/PlugInOriginHash.cpp: Removed.
plugins/PlugInOriginHash.h: Removed.

5:40 PM Changeset in webkit [146832] by pkasting@chromium.org

7 edits
7 adds in trunk/LayoutTests

[chromium] Rebaselining, etc.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112927

Unreviewed, test expectations update.

platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Added.
platform/chromium-mac-lion/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Added.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-hw-expected.txt: Added.
platform/chromium-mac/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-expected.png:
platform/chromium-mac/css3/filters/effect-reference-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
platform/chromium-win-xp/fast/text/international/bold-bengali-expected.png: Added.
platform/chromium-win-xp/fast/text/international/bold-bengali-expected.txt: Added.
platform/chromium/TestExpectations:

5:36 PM Changeset in webkit [146831] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Offlineasm cloop backend compiles op+branch incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=113146.

Reviewed by Geoffrey Garen.

dfg/DFGRepatch.h:

(JSC::DFG::dfgResetGetByID):
(JSC::DFG::dfgResetPutByID):

These functions never return when the DFG is dsiabled, not just when asserts are enabled. Changing the attribute from NO_RETURN_DUE_TO_ASSERT to NO_RETURN.
llint/LLIntOfflineAsmConfig.h:
Added some #defines needed to get the cloop building again.
offlineasm/cloop.rb:
Fix cloopEmitOpAndBranchIfOverflow() and cloopEmitOpAndBranch() to emit code that unconditionally executes the specified operation before doing the conditional branch.

5:27 PM Changeset in webkit [146830] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Wrong place to enable RuntimeEnabledFeature for Windows.

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

5:14 PM Changeset in webkit [146829] by mhahnenberg@apple.com

3 edits
3 adds in trunk

JSObject::enterDictionaryIndexingMode doesn't have a case for ALL_BLANK_INDEXING_TYPES
https://bugs.webkit.org/show_bug.cgi?id=113236

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

runtime/JSObject.cpp:

(JSC::JSObject::enterDictionaryIndexingMode): We forgot blank indexing types.

LayoutTests:

New test case that tests calling Object.freeze on Array.prototype.

fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type-expected.txt: Added.
fast/js/enter-dictionary-indexing-mode-with-blank-indexing-type.html: Added.
fast/js/script-tests/enter-dictionary-indexing-mode-with-blank-indexing-type.js: Added.

5:11 PM Changeset in webkit [146828] by jamesr@google.com

7 edits
1 move
29 adds
5 deletes in trunk/LayoutTests

Update chromium baselines for r146826

platform/chromium-linux-x86/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux-x86/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-linux/compositing/geometry/fixed-in-composited-expected.png:
platform/chromium-linux/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
platform/chromium-linux/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-linux/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/compositing/geometry/composited-in-columns-expected.txt: Added.
platform/chromium-mac-lion/compositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
platform/chromium-mac-lion/css3/filters/filtered-compositing-descendant-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-clip-overlap-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/backing/no-backing-for-perspective-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/composited-in-columns-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-in-composited-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/object-clip-rects-assertion-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/preserve-3d-switching-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/layer-creation/scroll-partial-update-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/crash-reparent-tiled-layer-expected.txt: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-resize-expected.txt: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Removed.
platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt: Renamed from LayoutTests/platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt.

4:46 PM Changeset in webkit [146827] by roger_fong@apple.com

3 edits in trunk/Tools

No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
Re-enable WinEWS tests.

Scripts/webkitpy/common/config/ports.py:

(WinPort.run_bindings_tests_command):

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:34 PM Changeset in webkit [146826] by jamesr@google.com

128 edits
11 deletes in trunk

[chromium] Support GraphicsLayer::setContentsToSolidColor
https://bugs.webkit.org/show_bug.cgi?id=104396

Reviewed by Adrienne Walker.

Source/WebCore:

This enables and implements the GraphicsLayer::setContentsToSolidColor
path for Chromium.

Tested by reftests in compositing/background-color/ and several other
compositing/ tests.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setContentsToSolidColor):
(WebCore):

platform/graphics/chromium/GraphicsLayerChromium.h:

(WebKit):
(GraphicsLayerChromium):

Source/WebKit/chromium:

Updates some unit tests for better include discipline.

tests/GraphicsLayerChromiumTest.cpp:
tests/ImageLayerChromiumTest.cpp:

4:30 PM Changeset in webkit [146825] by vcarbune@chromium.org

8 edits
3 copies
2 adds in trunk

TextTrack Extension for WebVTT Regions
https://bugs.webkit.org/show_bug.cgi?id=109820

Reviewed by Eric Carlson.

Source/WebCore:

Implemented the TextTrackRegionList and extended TextTrack with
methods required for proper interaction with TextTrackRegion objects.

Test: media/track/regions-webvtt/text-track-region-list.html

WebCore.gypi: Added files for proper building of TextTrackRegionList.
html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore):
(WebCore::TextTrack::ensureTextTrackRegionList): Method for creating a
TextTrackRegionList associated with the current track, if it does exist
already.
(WebCore::TextTrack::regions): Getter for the regions object.
(WebCore::TextTrack::addRegion): Method for adding a region.
(WebCore::TextTrack::removeRegion): Method for removing a region.

html/track/TextTrack.h:

(WebCore):
(TextTrack):

html/track/TextTrack.idl: Added methods specific for region handling.
html/track/TextTrackRegion.cpp:

(WebCore::TextTrackRegion::TextTrackRegion): Initialized the track member variable.
(WebCore::TextTrackRegion::setTrack): Added internal setter for the track attribute.
(WebCore):
(WebCore::TextTrackRegion::updateParametersFromRegion): Method to copy the parameters
from a different region object.

html/track/TextTrackRegion.h: Added track member variable and copy method.

(WebCore::TextTrackRegion::track): Getter retrieves now the member variable.
(TextTrackRegion):

html/track/TextTrackRegionList.cpp: Implemented methods required by the IDL.

(WebCore):
(WebCore::TextTrackRegionList::TextTrackRegionList):
(WebCore::TextTrackRegionList::length):
(WebCore::TextTrackRegionList::item):
(WebCore::TextTrackRegionList::getRegionById):
(WebCore::TextTrackRegionList::add):
(WebCore::TextTrackRegionList::remove):
(WebCore::TextTrackRegionList::clear):

html/track/TextTrackRegionList.h:

(WebCore):
(TextTrackRegionList):
(WebCore::TextTrackRegionList::create):
(WebCore::TextTrackRegionList::~TextTrackRegionList):

html/track/TextTrackRegionList.idl: IDL defined by the specification.

LayoutTests:

media/track/regions-webvtt/text-track-region-list-expected.txt: Added.
media/track/regions-webvtt/text-track-region-list.html: Added.

4:29 PM Changeset in webkit [146824] by commit-queue@webkit.org

7 edits
1 add in trunk/Source

Unreviewed, rolling out r146819.
http://trac.webkit.org/changeset/146819
https://bugs.webkit.org/show_bug.cgi?id=113249

broke component build (Requested by danakj on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/Platform:

chromium/public/WebVideoFrame.h:

Source/WebKit/chromium:

WebKit.gypi:
public/WebMediaPlayerClient.h:

(WebKit):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::readyStateChanged):
(WebKit::WebMediaPlayerClientImpl::repaint):
(WebKit::WebMediaPlayerClientImpl::setOpaque):
(WebKit::WebMediaPlayerClientImpl::disableAcceleratedCompositing):
(WebKit::WebMediaPlayerClientImpl::loadRequested):
(WebKit::WebMediaPlayerClientImpl::loadInternal):
(WebKit):
(WebKit::WebMediaPlayerClientImpl::platformLayer):
(WebKit::WebMediaPlayerClientImpl::paint):
(WebKit::WebMediaPlayerClientImpl::supportsAcceleratedRendering):
(WebKit::WebMediaPlayerClientImpl::acceleratedRenderingInUse):
(WebKit::WebMediaPlayerClientImpl::setVideoFrameProviderClient):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::create):
(WebKit::WebMediaPlayerClientImpl::supportsType):

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Added.

(WebKit):
(FakeWebMediaPlayerClientImpl):
(WebKit::FakeWebMediaPlayerClientImpl::create):
(WebKit::FakeWebMediaPlayerClientImpl::FakeWebMediaPlayerClientImpl):
(FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::create):
(WebKit::FakeVideoFrameProviderClient::~FakeVideoFrameProviderClient):
(WebKit::FakeVideoFrameProviderClient::didReceiveFrame):
(WebKit::FakeVideoFrameProviderClient::didUpdateMatrix):
(WebKit::FakeVideoFrameProviderClient::stopUsingProvider):
(WebKit::FakeVideoFrameProviderClient::provider):
(WebKit::FakeVideoFrameProviderClient::FakeVideoFrameProviderClient):
(WebKit::TEST):

4:27 PM Changeset in webkit [146823] by dino@apple.com

20 edits in trunk/Source

Cleanup plugin snapshotting autostart decision making
https://bugs.webkit.org/show_bug.cgi?id=113231

Reviewed by Tim Horton.

Source/WebCore:

Move the code that creates a hash of plugin origin info
out of WebCore. All WebCore needs to do now is simply ask its
host layer whether or not a tuple of (pluginOrigin, pageOrigin, mimeType)
should autostart or not.

As a drive-by, the code in subframeLoaderWillCreatePlugIn was not quite
restarting properly when the displayState was Restarting or
RestartingWithPendingMouseClick. It still worked most of the time, but usually
because the code ran soon after a mouse click. Now it should be explicit and
also allowed us to be more clear about snapshotting at the end of the method.

html/HTMLPlugInElement.h: No more pluginOriginHash().
html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin): Change signature to accept the tuple

described above, and compare strings rather than hashes.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Tell host layer the origin

info rather than hash info.

(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Remember the url that

the plugin was loaded from. Make some of the logging messages more clear. Test for
plugin and page origin rather than hash.

html/HTMLPlugInImageElement.h:

(WebCore::HTMLPlugInImageElement::loadedUrl): New loadedURL member function.

page/PlugInClient.h:

(PlugInClient): Change signature of virtual class to accept origin and mimeType info

rather than hash.

Source/WebKit2:

Two major changes to the way snapshotting plugins may autostart.

The first is that previously WebCore was keeping a hash that
represented the combination of page origin, plugin origin and
mime type. WebKit was responsible for deciding if that particular
hash should autostart. Now, WebKit keeps the hash, and WebCore
just asks us whether the combination of origins and mimetype
should start immediately. You can see this change the in WebPluginClient
and WebProcess APIs.

The second change is that we now keep two types of structures
around to decide whether a plugin should autostart. One is the
existing page + plugin origin combination. The other is simply
the plugin origin, which allows plugins from major providers
to autostart no matter what page they were embedded on.

Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode): Encode the new parameter.
(WebKit::WebProcessCreationParameters::decode): Decode the new parameter.

Shared/WebProcessCreationParameters.h: Also keep a list of strings around.

UIProcess/API/C/WKContext.cpp:

(WKContextSetPlugInAutoStartOrigins): The C API to send the list of plugin

origins over to the context.

UIProcess/API/C/WKContext.h:

UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash): Renamed from addAutoStartOrigin.

No functional change other than new names for members.

(WebKit::PlugInAutoStartProvider::autoStartOriginHashesCopy): Ditto.
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTable): Ditto.
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsArray): New method that converts the

incoming ImmutableArray into a Vector of Strings.

(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction): Rename for new members.

UIProcess/Plugins/PlugInAutoStartProvider.h: Renaming member variables. Adding

some typedefs to clean up code.

(WebKit::PlugInAutoStartProvider::autoStartOrigins): New accessor.

UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess): Renaming, and copy the new parameter into the process creation.
(WebKit::WebContext::addPlugInAutoStartOriginHash): Renaming.
(WebKit::WebContext::setPlugInAutoStartOriginHashes): Renaming.
(WebKit::WebContext::setPlugInAutoStartOrigins): New method.

UIProcess/WebContext.h: Adds the new setPlugInAutoStartOrigin method.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin): Drive-by fix that was attempting to restart plugins

that were in the process of restarting.

(WebKit::PluginView::pluginDidReceiveUserInteraction): Temporarily suspend update of

expiration time if the user interacts with a plugin.

WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::shouldAutoStartFromOrigin): Renaming.
(WebKit::WebPlugInClient::didStartFromOrigin): Ditto.

WebProcess/WebCoreSupport/WebPlugInClient.h: Renaming.

WebProcess/WebProcess.cpp: Drive-by - noticed that we forgot to count seconds in

a timeout threshold.

(WebKit::WebProcess::initializeWebProcess): Also add the list of origins when we initialize.
(WebKit::addCaseFoldedCharacters): Copied from WebCore - adds a String to a hash input.
(WebKit::hashForPlugInOrigin): Copied from WebCore - hashing function.
(WebKit::WebProcess::isPlugInAutoStartOriginHash): Renaming.
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin): Check the list of pure origins first. If

that fails, fall back to the hash list of pairs.

(WebKit::WebProcess::plugInDidStartFromOrigin): Renaming.
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash): Ditto.
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes): Ditto.
(WebKit::WebProcess::plugInDidReceiveUserInteraction): Ditto.

WebProcess/WebProcess.h: Renaming some methods, but also adding the input of the new

origin-only list.

WebProcess/WebProcess.messages.in: Renaming a message.

4:07 PM Changeset in webkit [146822] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r146793.
http://trac.webkit.org/changeset/146793
https://bugs.webkit.org/show_bug.cgi?id=113248

Fix did not work (Requested by rfong on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-25

Source/WebCore:

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Tools:

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

3:58 PM Changeset in webkit [146821] by roger_fong@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Disable fast/exclusions and fast/regions tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=113244

platform/win/TestExpectations:

3:51 PM Changeset in webkit [146820] by commit-queue@webkit.org

14 edits
3 copies
3 adds in trunk

WEBGL_compressed_texture_pvrtc needs implementation
https://bugs.webkit.org/show_bug.cgi?id=110497

Patch by Brandon Jones <bajones@google.com> on 2013-03-25
Reviewed by Kenneth Russell.

Source/WebCore:

Test: webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html

Exposes the WEBGL_compressed_texture_pvrtc extension, but is unverified since no desktop hardware supports
the format that I am aware of. Should enable mobile ports to expose the format, however.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

html/canvas/WebGLCompressedTexturePVRTC.cpp: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebCore::WebGLCompressedTexturePVRTC::WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::~WebGLCompressedTexturePVRTC):
(WebCore::WebGLCompressedTexturePVRTC::getName):
(WebCore::WebGLCompressedTexturePVRTC::create):
(WebCore::WebGLCompressedTexturePVRTC::supported):

html/canvas/WebGLCompressedTexturePVRTC.h: Copied from Source/WebCore/html/canvas/WebGLExtension.h.

(WebCore):
(WebGLCompressedTexturePVRTC):

html/canvas/WebGLCompressedTexturePVRTC.idl: Copied from Source/WebCore/html/canvas/WebGLExtension.h.
html/canvas/WebGLExtension.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateCompressedTexFuncData):

html/canvas/WebGLRenderingContext.h:

(WebCore):
(WebGLRenderingContext):

LayoutTests:

webgl/conformance/extensions/webgl-compressed-texture-pvrtc-expected.txt: Added.
webgl/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.
webgl/resources/webgl_test_files/conformance/extensions/webgl-compressed-texture-pvrtc.html: Added.

3:48 PM Changeset in webkit [146819] by danakj@chromium.org

7 edits
1 delete in trunk/Source

[chromium] Move ownership of compositor VideoLayer to WebMediaPlayer
https://bugs.webkit.org/show_bug.cgi?id=112971

Reviewed by James Robinson.

Source/Platform:

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

chromium/public/WebVideoFrame.h:
chromium/public/WebVideoFrameProvider.h:

Source/WebKit/chromium:

Now, the WebMediaPlayer implementation calls setWebLayer() to
provide the WebLayer* to the WebMediaPlayerClientImpl so that
it can be inserted into the GraphicsLayer tree appropriately.

Defines REMOVE_WEBVIDEOFRAME in related headers to enable this code
path in chromium.

Once chromium removes its use of WebVideoFrame and its related
classes, we can remove them from WebKit entirely.

WebKit.gypi:
public/WebMediaPlayer.h:

(WebKit):

public/WebMediaPlayerClient.h:
public/WebStreamTextureClient.h:
src/WebMediaPlayerClientImpl.cpp:

src/WebMediaPlayerClientImpl.h:

(WebKit):
(WebMediaPlayerClientImpl):

tests/WebMediaPlayerClientImplTest.cpp: Removed.

3:18 PM Changeset in webkit [146818] by roger_fong@apple.com

2 edits in trunk/WebKitLibraries

Unreviewed. Also enable CSS_REGIONS and EXCLUSIONS for VS2010 solution.

win/tools/vsprops/FeatureDefines.props:

3:08 PM Changeset in webkit [146817] by rniwa@webkit.org

5 edits in trunk/Tools

REGRESSION(r146657): Test failures reported incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113223

Reviewed by Dirk Pranke.

The bug was caused by BuildBotPrinter not taking the new behavior into account.

Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(RunDetails.init):
(summarize_results): Remove the line I intended to remove in r146657.

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(logging_run): Return details instead of the exit code.
(run_and_capture): Ditto.

(RunTest.test_full_results_html):
(RunTest.test_hung_thread):
(RunTest.test_no_tests_found):
(RunTest.test_no_tests_found_2):
(RunTest.test_repeat_each_iterations_num_tests):
(RunTest.test_run_singly_actually_runs_tests):
(RunTest.test_test_list):
(RunTest.test_missing_and_unexpected_results):
(RunTest.test_pixel_test_directories):
(RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
(RunTest.test_crash_with_stderr):
(RunTest.test_no_image_failure_with_image_diff):
(RunTest.test_crash_log):
(RunTest.test_exit_after_n_failures_upload):
(RunTest.test_results_directory_absolute):
(RunTest.test_results_directory_relative):
(RunTest.test_retrying_and_flaky_tests):
(RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
(RunTest.test_retrying_uses_retries_directory):
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(RunTest.test_output_diffs):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

Scripts/webkitpy/layout_tests/views/buildbot_results.py:

(BuildBotPrinter.print_results):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
when we forced pixel tests in retry (i.e. pixel test was initially disabled).

2:01 PM Changeset in webkit [146816] by roger_fong@apple.com

6 edits in trunk

Enable CSS_REGIONS and CSS_EXCLUSIONS and related tests.
https://bugs.webkit.org/show_bug.cgi?id=87519

Reviewed by Timothy Horton.

win/tools/vsprops/FeatureDefines.vsprops:
platform/win/TestExpectations:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

1:53 PM Changeset in webkit [146815] by mikhail.pozdnyakov@intel.com

2 edits in trunk/Source/WebCore

Remove unused code from Frame class destructor
https://bugs.webkit.org/show_bug.cgi?id=113181

Reviewed by Alexey Proskuryakov.

No new tests. No new functionality.

page/Frame.cpp:

(WebCore::Frame::~Frame):

Removed the code which could never have been executed
as m_view had been set to '0'.

1:41 PM Changeset in webkit [146814] by danakj@chromium.org

21 edits in trunk/LayoutTests

Don't use video to trigger compositing for layout tests
https://bugs.webkit.org/show_bug.cgi?id=113228

Reviewed by Adrienne Walker.

These tests used <video> to trigger compositing because a 3d identity
transform would have affected the overlap map differently. This is
no longer the case, so use translateZ(0) to trigger compositing instead,
which makes these tests more reliable and faster.

compositing/geometry/limit-layer-bounds-clipping-ancestor.html:
compositing/geometry/limit-layer-bounds-fixed-positioned.html:
compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
compositing/geometry/limit-layer-bounds-opacity-transition.html:
compositing/geometry/limit-layer-bounds-overflow-repaint.html:
compositing/geometry/limit-layer-bounds-overflow-root.html:
compositing/geometry/limit-layer-bounds-positioned-transition.html:
compositing/geometry/limit-layer-bounds-positioned.html:
compositing/geometry/limit-layer-bounds-transformed-overflow.html:
compositing/geometry/limit-layer-bounds-transformed.html:
compositing/layer-creation/scroll-partial-update-expected.txt:
compositing/layer-creation/scroll-partial-update.html:
platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.txt:
platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:

1:38 PM Changeset in webkit [146813] by Lucas Forschler

1 edit
2 copies in tags/Safari-537.35.1/LayoutTests

Merged r146685. <rdar://problem/13475726>

1:36 PM Changeset in webkit [146812] by Lucas Forschler

8 edits in tags/Safari-537.35.1/Source

Merged r146679. <rdar://problem/13475726>

1:33 PM Changeset in webkit [146811] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146563. <rdar://problem/13435161>

1:30 PM Changeset in webkit [146810] by Lucas Forschler

5 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146551. <rdar://problem/13355759>

1:28 PM Changeset in webkit [146809] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146542. <rdar://problem/13355808>

1:26 PM Changeset in webkit [146808] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Sheriffing.
https://bugs.webkit.org/show_bug.cgi?id=112927
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectation updates.

Removed crash expectations for fixed bug; added fail expectations for
results the bot won't give us; marked a test as slow.

platform/chromium/TestExpectations:

1:26 PM Changeset in webkit [146807] by Lucas Forschler

4 edits in tags/Safari-537.35.1/Source/WebKit2

Merged r146539. <rdar://problem/13355808>

1:23 PM Changeset in webkit [146806] by Lucas Forschler

2 edits in tags/Safari-537.35.1/Source/WebCore

Merged r146373. <rdar://problem/13202277>

1:16 PM Changeset in webkit [146805] by eric@webkit.org

3 edits
2 adds in trunk

Incorrect parsing due to hash collision
https://bugs.webkit.org/show_bug.cgi?id=113235

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/parser/tag-hash-collision.html

html/parser/HTMLIdentifier.cpp:

(WebCore::HTMLIdentifier::findIndex):

LayoutTests:

fast/parser/tag-hash-collision-expected.txt: Added.
fast/parser/tag-hash-collision.html: Added.

1:15 PM Changeset in webkit [146804] by eric.carlson@apple.com

4 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Update three more tests that use "testRunner" instead of "layoutTestController".

fast/block/float/intruding-float-not-removed-writing-mode.xhtml:
mhtml/shared_buffer_bug.mht:
svg/custom/use-invalidate-click-crash.xhtml:

1:14 PM Changeset in webkit [146803] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Compile without SVG will fail
https://bugs.webkit.org/show_bug.cgi?id=113234

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-03-25
Reviewed by Timothy Hatcher.

Only make the cast to SVGStyleElement if we have SVG support built.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

1:11 PM Changeset in webkit [146802] by Patrick Gansterer

2 edits in trunk/Source/WebCore

Enable STORE_FONT_CUSTOM_PLATFORM_DATA for all platforms
https://bugs.webkit.org/show_bug.cgi?id=108438

Reviewed by Andreas Kling.

Remove the conditional code so it is turned on for all platforms.

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::~CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::platformDataFromCustomData):
(WebCore::CachedFont::allClientsRemoved):
(WebCore::CachedFont::reportMemoryUsage):

1:10 PM Changeset in webkit [146801] by eric.carlson@apple.com

4 edits in trunk

REGRESSION(r146380): media/track/track-user-preferences.html
https://bugs.webkit.org/show_bug.cgi?id=113083

Reviewed by Jer Noble.

Source/WebCore:

Ignore track change notifications triggered by automatic track selection so the
configuration is not changed.

No new tests, this fixes an existing test.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Clear m_processingPreferenceChange after all

track configuration is finished.

(WebCore::HTMLMediaElement::configureTextTrackDisplay): Do nothing if m_processingPreferenceChange

is true.

LayoutTests:

platform/mac/TestExpectations: Remove test from expectations.

1:06 PM Changeset in webkit [146800] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Build the final piece of WebCore
https://bugs.webkit.org/show_bug.cgi?id=113216

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add the rest of the WebCore source files to the WebCore build target.

1:00 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:57 PM Changeset in webkit [146799] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WK2][GTK] MiniBrowser won't play video in <embed> tag
https://bugs.webkit.org/show_bug.cgi?id=113107

Reviewed by Martin Robinson.

The wrong clip region is used for windowed plugins, because it's
translated to window frame coords again.

WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformGeometryDidChange): Do not move
the current clip region.

12:45 PM Changeset in webkit [146798] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Adding support for building WebCore rendering
https://bugs.webkit.org/show_bug.cgi?id=113213

Reviewed by Gustavo Noronha Silva.

WebCore.gyp/WebCoreGTK.gyp: Build the rendering directory into a shared library.

12:37 PM Changeset in webkit [146797] by jparent@chromium.org

12 edits in trunk/Tools

Dashboard refactor: Move cross dashboard history related code into history.js.
https://bugs.webkit.org/show_bug.cgi?id=113104

Reviewed by Ojan Vafai.

All functions relating to cross dashboard behavior move from being
globals to methods on the history.History object. Names stay the same,
except many are made private, ones that should have been constants now
are, and the long standing TODO to change "currentState" to
dashboardSpecificState is done.

We now create a global history object in dashboard_base, as an
intermediate measure. Once the dashboard specific code is
added to history, each DB will need to create its own, and this
global will be eliminated.

TestResultServer/static-dashboards/aggregate_results.js:

(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):

TestResultServer/static-dashboards/dashboard_base.js:

(parseDashboardSpecificParameters):
(defaultValue):
(currentBuilderGroupCategory):
(currentBuilderGroupName):
(handleLocationChange):
(expectationsMap):

TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(.switch.return):
(platformAndBuildType):
(individualTests):
(substringList):
(processMissingAndExtraExpectations):
(pathToFailureLog):
(showPopupForBuild):
(htmlForTestsWithExpectationsButNoFailures):
(shouldHideTest):
(isCrossBuilderView):
(tableHeaders):
(htmlForSingleTestRow):
(htmlForTableColumnHeader):
(generatePageForExpectationsUpdate):
(handleUpdate):
(nextUpdate):
(setUpdateIndex):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
(.appendExpectationsItem):
(loadExpectations):
(.dummyNode.onload):
(loadExpectationsLayoutTests):
(appendExpectations):
(htmlForNavBar):
(checkBoxToToggleState):
(linkHTMLToToggleState):
(generatePageForBuilder):
(isInvalidKeyForCrossBuilderView):
(handleQueryParameterChange):
(showLegend):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

TestResultServer/static-dashboards/history.js:

(.):

TestResultServer/static-dashboards/history_unittests.js:
TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/loader_unittests.js:
TestResultServer/static-dashboards/timeline_explorer.js:

(generatePage):
(initCurrentBuilderTestResults):
(selectBuild):
(showResultsDelta):

TestResultServer/static-dashboards/treemap.js:

(generatePage):
(.switch.return):
(handleFocus):

TestResultServer/static-dashboards/ui.js:

12:16 PM Changeset in webkit [146796] by tony@chromium.org

3 edits in trunk/Source/WebCore

Remove TextIterator argumentless constructor
https://bugs.webkit.org/show_bug.cgi?id=113226

Reviewed by Ryosuke Niwa.

The TextIterator argumentless constructors are never used and wouldn't be useful
since you can't specify a range.

No new tests, removing dead code. There should be no behavior change.

editing/TextIterator.cpp: Remove constructors.
editing/TextIterator.h:

(TextIterator):
(SimplifiedBackwardsTextIterator):
(CharacterIterator):
(BackwardsCharacterIterator):
(WordAwareIterator):

12:05 PM Changeset in webkit [146795] by commit-queue@webkit.org

3 edits
3 adds in trunk

Enabled canvas.getContext("webgl") on Desktop Chrome
https://bugs.webkit.org/show_bug.cgi?id=113079

Patch by Brandon Jones <bajones@chromium.org> on 2013-03-25
Reviewed by Dean Jackson.

Test: fast/canvas/webgl/webgl-unprefixed-context-id.html

bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextMethodCustom):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

11:51 AM Changeset in webkit [146794] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Windows rebaseline after r146779.

platform/win/css3/filters/effect-reference-expected.txt:
platform/win/css3/filters/effect-reference-hw-expected.txt:

11:43 AM Changeset in webkit [146793] by roger_fong@apple.com

4 edits in trunk

Unreviewed. Remove some suspicious looking code in an attempt to fix EWS bots.
Enable WinEWS test again.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

11:40 AM Changeset in webkit [146792] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Merge r136586.

2012-12-04 Florin Malita <fmalita@chromium.org>

Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

svg/custom/use-href-update-crash.svg:

11:36 AM Changeset in webkit [146791] by Lucas Forschler

4 edits in tags/Safari-537.35.1/Source

Versioning.

11:31 AM Changeset in webkit [146790] by Lucas Forschler

1 copy in tags/Safari-537.35.1

New Tag.

11:19 AM Changeset in webkit [146789] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] [gyp] Add support for building the platform directory
https://bugs.webkit.org/show_bug.cgi?id=113212

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add support for building the platform directory including

two libraries, one for platform and one for geometry files. This follows the approach
of Chromium.

11:13 AM Changeset in webkit [146788] by rniwa@webkit.org

6 edits in trunk/LayoutTests

Mac rebaselines after r146779. Also add failing expectations for 4 transition tests per bug 113223.

platform/mac/TestExpectations:
platform/mac/css3/filters/effect-reference-expected.png:
platform/mac/css3/filters/effect-reference-expected.txt:
platform/mac/css3/filters/effect-reference-hw-expected.png:
platform/mac/css3/filters/effect-reference-hw-expected.txt:

10:57 AM Changeset in webkit [146787] by jochen@chromium.org

4 edits in trunk

Swap both the error and change event queue before processing fullscreen events
https://bugs.webkit.org/show_bug.cgi?id=113194

Reviewed by Jer Noble.

Source/WebCore:

While processing the change events, not only new change events but
also new error events might get generated. However, for the timer, we
should only process preexisting events.

This is covered by fullscreen/full-screen-restrictions.html which times
out depending on the delay between requesting fullscreen and granting
fullscreen.

dom/Document.cpp:

(WebCore::Document::fullScreenChangeDelayTimerFired):

LayoutTests:

platform/chromium/TestExpectations:

9:51 AM Changeset in webkit [146786] by zarvai@inf.u-szeged.hu

215 edits
3 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining. Making pixel test bot happier after r146206.

platform/qt/fast/replaced/max-width-percent-expected.png:
platform/qt/fast/replaced/maxheight-percent-expected.png:
platform/qt/fast/replaced/maxheight-pxs-expected.png:
platform/qt/fast/replaced/maxwidth-percent-expected.png:
platform/qt/fast/replaced/maxwidth-pxs-expected.png:
platform/qt/fast/replaced/minheight-percent-expected.png:
platform/qt/fast/replaced/minheight-pxs-expected.png:
platform/qt/fast/replaced/minwidth-percent-expected.png:
platform/qt/fast/replaced/minwidth-pxs-expected.png:
platform/qt/fast/replaced/object-align-hspace-vspace-expected.png:
platform/qt/fast/replaced/percent-height-in-anonymous-block-in-table-expected.png:
platform/qt/fast/replaced/percent-height-in-anonymous-block-widget-expected.png:
platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/vertical-lr/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/vertical-rl/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/width100percent-button-expected.png:
platform/qt/fast/ruby/ruby-inline-table-expected.png:
platform/qt/fast/runin/001-expected.png:
platform/qt/fast/runin/generated-expected.png:
platform/qt/fast/runin/runin-generated-before-content-expected.png:
platform/qt/fast/selectors/016-expected.png:
platform/qt/fast/selectors/017-expected.png:
platform/qt/fast/selectors/061-expected.png:
platform/qt/fast/selectors/062-expected.png:
platform/qt/fast/selectors/064-expected.png:
platform/qt/fast/table/003-expected.png:
platform/qt/fast/table/023-expected.png:
platform/qt/fast/table/027-vertical-expected.png:
platform/qt/fast/table/038-vertical-expected.png:
platform/qt/fast/table/040-expected.png:
platform/qt/fast/table/040-vertical-expected.png:
platform/qt/fast/table/100-percent-cell-width-expected.png:
platform/qt/fast/table/add-before-anonymous-child-expected.png:
platform/qt/fast/table/auto-100-percent-width-expected.png:
platform/qt/fast/table/border-collapsing/002-vertical-expected.png:
platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-expected.png:
platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png:
platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.png:
platform/qt/fast/table/cell-absolute-child-expected.png:
platform/qt/fast/table/click-near-anonymous-table-expected.png:
platform/qt/fast/table/empty-cells-expected.png:
platform/qt/fast/table/empty-table-percent-height-expected.png:
platform/qt/fast/table/fixed-granular-cols-expected.png:
platform/qt/fast/table/fixed-with-auto-with-colspan-expected.png:
platform/qt/fast/table/generated-caption-expected.png:
platform/qt/fast/table/insert-before-anonymous-ancestors-expected.png:
platform/qt/fast/table/mozilla-bug10296-vertical-align-1-expected.png:
platform/qt/fast/table/mozilla-bug10296-vertical-align-2-expected.png:
platform/qt/fast/table/row-height-recalc-expected.png:
platform/qt/fast/table/rtl-cell-display-none-assert-expected.png:
platform/qt/fast/table/stale-grid-crash-expected.png:
platform/qt/fast/table/table-and-parts-outline-expected.png:
platform/qt/fast/table/table-display-types-vertical-expected.png:
platform/qt/fast/table/text-field-baseline-expected.png:
platform/qt/fast/table/unused-percent-heights-expected.png:
platform/qt/fast/text/backslash-to-yen-sign-expected.png:
platform/qt/fast/text/basic/001-expected.png:
platform/qt/fast/text/basic/002-expected.png:
platform/qt/fast/text/basic/004-expected.png:
platform/qt/fast/text/basic/008-expected.png:
platform/qt/fast/text/basic/009-expected.png:
platform/qt/fast/text/basic/011-expected.png:
platform/qt/fast/text/basic/012-expected.png:
platform/qt/fast/text/basic/generic-family-changes-expected.png:
platform/qt/fast/text/basic/generic-family-reset-expected.png:
platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.png:
platform/qt/fast/text/capitalize-empty-generated-string-expected.png:
platform/qt/fast/text/complex-text-opacity-expected.png:
platform/qt/fast/text/fake-italic-expected.png:
platform/qt/fast/text/fallback-traits-fixup-expected.png:
platform/qt/fast/text/firstline/001-expected.png:
platform/qt/fast/text/font-initial-expected.png:
platform/qt/fast/text/hyphenate-limit-before-after-expected.png:
platform/qt/fast/text/international/arabic-justify-expected.png:
platform/qt/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/qt/fast/text/international/hindi-whitespace-expected.png:
platform/qt/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
platform/qt/fast/text/justified-selection-at-edge-expected.png:
platform/qt/fast/text/justified-selection-expected.png:
platform/qt/fast/text/line-breaks-after-white-space-expected.png:
platform/qt/fast/text/shadow-no-blur-expected.png:
platform/qt/fast/text/shadow-translucent-fill-expected.png:
platform/qt/fast/text/softHyphen-expected.png:
platform/qt/fast/text/unicode-variation-selector-expected.png:
platform/qt/fast/text/wbr-in-pre-crash-expected.png:
platform/qt/fast/text/wbr-styled-expected.png:
platform/qt/fast/text/whitespace/002-expected.png:
platform/qt/fast/text/whitespace/020-expected.png:
platform/qt/fast/text/whitespace/021-expected.png:
platform/qt/fast/text/whitespace/022-expected.png:
platform/qt/fast/text/whitespace/025-expected.png:
platform/qt/fast/text/whitespace/027-expected.png:
platform/qt/fast/text/whitespace/030-expected.png:
platform/qt/fast/text/whitespace/nbsp-mode-and-linewraps-expected.png:
platform/qt/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
platform/qt/fast/text/whitespace/pre-break-word-expected.png:
platform/qt/fast/text/whitespace/pre-wrap-last-char-expected.png:
platform/qt/fast/text/whitespace/pre-wrap-line-test-expected.png:
platform/qt/fast/text/word-break-expected.png:
platform/qt/fast/text/zero-font-size-expected.png:
platform/qt/fast/transforms/bounding-rect-zoom-expected.png:
platform/qt/fast/transforms/diamond-expected.png:
platform/qt/fast/transforms/matrix-01-expected.png:
platform/qt/fast/transforms/matrix-02-expected.png:
platform/qt/fast/transforms/overflow-with-transform-expected.png:
platform/qt/fast/transforms/skew-with-unitless-zero-expected.png:
platform/qt/fast/transforms/transform-on-inline-expected.png:
platform/qt/fast/transforms/transform-positioned-ancestor-expected.png:
platform/qt/fast/transforms/transformed-document-element-expected.png:
platform/qt/fast/transforms/transforms-with-opacity-expected.png:
platform/qt/fast/writing-mode/block-level-images-expected.png:
platform/qt/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
platform/qt/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
platform/qt/fast/writing-mode/box-shadow-vertical-lr-expected.png:
platform/qt/fast/writing-mode/box-shadow-vertical-rl-expected.png:
platform/qt/fast/writing-mode/english-bt-text-expected.png:
platform/qt/fast/writing-mode/english-rl-text-expected.png:
platform/qt/fast/writing-mode/horizontal-bt-replaced-selection-expected.png:
platform/qt/fast/writing-mode/vertical-lr-replaced-selection-expected.png:
platform/qt/fast/writing-mode/vertical-rl-replaced-selection-expected.png:
platform/qt/fast/xsl/document-function-expected.png:
platform/qt/fonts/cursive-expected.png:
platform/qt/fonts/default-expected.png:
platform/qt/fonts/fantasy-expected.png:
platform/qt/fonts/monospace-expected.png:
platform/qt/fonts/sans-serif-expected.png:
platform/qt/fonts/serif-expected.png:
platform/qt/http/tests/local/file-url-sent-as-referer-expected.png:
platform/qt/http/tests/misc/frame-access-during-load-expected.png:
platform/qt/http/tests/misc/iframe404-expected.png:
platform/qt/http/tests/navigation/postredirect-basic-expected.png:
platform/qt/http/tests/navigation/postredirect-goback1-expected.png:
platform/qt/http/tests/uri/css-href-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background-color-border-box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-003-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-style-005-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.png:
platform/qt/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-003-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-005-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-007-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-008-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-009-expected.png:
platform/qt/ietestcenter/css3/text/textshadow-010-expected.png:
platform/qt/platform/qt/fast/forms/button-line-break-expected.png:
platform/qt/printing/return-from-printing-mode-expected.png:
platform/qt/scrollbars/custom-scrollbar-with-incomplete-style-expected.png:
platform/qt/scrollbars/listbox-scrollbar-combinations-expected.png:
platform/qt/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/qt/scrollbars/scrollbars-on-positioned-content-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png:
platform/qt/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
platform/qt/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-20-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-21-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-25-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png:
platform/qt/svg/W3C-SVG-1.1/animate-elem-27-t-expected.png:

9:49 AM Changeset in webkit [146785] by commit-queue@webkit.org

17 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-25
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters for a
small amount of frequently used functions / functions used by Dromaeo.

Added tests to TestObj.idl and updated bindings tests.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldReadOnlyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethod):
(WebCore::TestObjV8Internal::perWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::perWorldMethodMethodCallbackForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod1MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2Method):
(WebCore::TestObjV8Internal::overloadedPerWorldMethod2MethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethod):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodForMainWorld):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallback):
(WebCore::TestObjV8Internal::overloadedPerWorldMethodMethodCallbackForMainWorld):
(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

dom/Document.idl:
dom/Element.idl:
dom/Node.idl:
page/DOMWindow.idl:

9:47 AM Changeset in webkit [146784] by dcheng@chromium.org

3 edits
1 add in trunk

Don't allow drags to start after a mouse press that creates a context menu
https://bugs.webkit.org/show_bug.cgi?id=112079

Reviewed by Tony Chang.

ManualTests/context-menu-during-drag-selection.html: Added.

Source/WebCore:

This appears to be the intent of the original code anyway (the comments in the corresponding
context menu handlers indicate that they set m_mousePressed to false in order to suppress
drags from starting). Since exact platform behavior differs quite a bit in this area, this
will also make the behavior more consistent across different WebKit implementations.

Manually testable using context-menu-during-drag-selection.html.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):

9:36 AM Changeset in webkit [146783] by pdr@google.com

2 edits
1 add in trunk/LayoutTests

[Chromium] Rebaseline svg/custom/marker-orient-auto

Unreviewed rebaseline of test expectations.

platform/chromium-linux-x86/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium/TestExpectations:

9:29 AM Changeset in webkit [146782] by vsevik@chromium.org

6 edits in trunk

Web Inspector: [Regression] Provisional breakpoints are not shown on reload.
https://bugs.webkit.org/show_bug.cgi?id=113210

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.prototype._restoreBreakpoints):
(WebInspector.BreakpointManager.prototype._projectWillReset.get for):
(WebInspector.BreakpointManager.prototype._projectWillReset):
(WebInspector.BreakpointManager.prototype._breakpointResolved):

inspector/front-end/utilities.js:

LayoutTests:

inspector/debugger/breakpoint-manager-expected.txt:
inspector/debugger/breakpoint-manager.html:

9:28 AM Changeset in webkit [146781] by commit-queue@webkit.org

8 edits in trunk

Web Inspector: Remove console warnings for *_ prefixed CSS styles
https://bugs.webkit.org/show_bug.cgi?id=113175

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Source/WebCore:

Added separate error message for syntax CSS error in declaration list when no property detected.
Added filter for messages starting with '*'.

css/CSSGrammar.y.in:

LayoutTests:

inspector/console/console-css-warnings-expected.txt:
inspector/console/console-css-warnings.html:

9:16 AM Changeset in webkit [146780] by jochen@chromium.org

2 edits in trunk/LayoutTests

Triage more test failures on content_shell

Unreviewed gardening.

platform/chromium/ContentShellTestExpectations:

9:10 AM Changeset in webkit [146779] by commit-queue@webkit.org

9 edits
1 add in trunk

Integration of the Skia displacement mapping into WebKit
https://bugs.webkit.org/show_bug.cgi?id=112927

Patch by Alexis Hetu <sugoi@chromium.org> on 2013-03-25
Reviewed by Stephen White.

Added displacement mapping to effect-reference.html and
effect-reference-hw.html

WebCore.gypi:
platform/graphics/filters/FEDisplacementMap.h:

(FEDisplacementMap):
Adding Skia specific declarations

platform/graphics/filters/skia/FEDisplacementMapSkia.cpp: Added.

(WebCore):
(WebCore::toSkiaMode):
Provides conversion between the WebKit displacement mapping mode and
the Skia displacement mapping mode
(WebCore::FEDisplacementMap::platformApplySkia):
Displacement through the Skia API. (Accelerated only for now)
(WebCore::FEDisplacementMap::createImageFilter):
Displacement image filter creation through the Skia API.

9:05 AM Changeset in webkit [146778] by dominik.rottsches@intel.com

3 edits
2 deletes in trunk/Tools

[HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
https://bugs.webkit.org/show_bug.cgi?id=112166

HarfBuzz 0.9.14 merged my patch for icu detection without
pkg-config files, as needed by for example Ubuntu 12.04.
This obsoletes our local workaround. Removed it for GTK and EFL.

Reviewed by Martin Robinson.

efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.

9:01 AM Changeset in webkit [146777] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Graduate some new Inspector APIs to public
https://bugs.webkit.org/show_bug.cgi?id=113176

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Summary of changes:

DOM.highlightNode.nodeId: required parameter is now optional
Input: domain has been added
Runtime.enable: command has been added
Runtime.executionContextCreated: event has been added
Page.clearGeolocationOverride: command has been added
Page.setGeolocationOverride: command has been added
Page.captureScreenshot: command has been added
Debugger.setBreakpointByUrl.locations: optional response parameter is now required

inspector/Inspector.json:

8:56 AM Changeset in webkit [146776] by kadam@inf.u-szeged.hu

341 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results.

platform/qt/css3/selectors3/xhtml/css3-modsel-146a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-146b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-147a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-147b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-153-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-172a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-172b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-173a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-173b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-3-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-47-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-48-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-49-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-51-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-52-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-53-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-57-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-57b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-93-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-94-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-94b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-95-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-96-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-96b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-97-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-97b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-98-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-98b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-99-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-99b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-d4-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-100-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-100b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-101-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-101b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-102-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-102b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-103-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-103b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-104-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-104b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-105-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-105b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-106-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-106b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-107-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-107b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-108-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-108b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-109-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-109b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-110-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-110b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-111-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-111b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-112-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-112b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-113-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-113b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-114-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-114b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-115-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-115b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-116-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-116b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-117-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-117b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-118-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-119-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-120-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-121-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-122-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-123-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-124-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-124b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-125-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-125b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-126-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-126b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-127-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-127b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-128-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-128b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-129-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-129b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-130-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-130b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-131-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-131b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-132-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-132b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-133-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-133b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-134-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-134b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-135-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-135b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-136-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-136b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-137-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-137b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-138-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-138b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-139-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-139b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-140-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-140b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-141-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-141b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-142-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-142b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-143-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-143b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-145a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-145b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-146a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-146b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-147a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-147b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-153-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-15c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-172a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-172b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-173a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-173b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-3-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-47-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-48-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-49-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-51-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-52-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-53-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-57-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-57b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-93-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-94-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-94b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-95-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-96-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-96b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-97-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-97b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-98-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-98b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-99-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-99b-expected.png:
platform/qt/css3/selectors3/xml/css3-modsel-d4-expected.png:
platform/qt/css3/unicode-bidi-isolate-basic-expected.png:

8:34 AM Changeset in webkit [146775] by kadam@inf.u-szeged.hu

198 edits
5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png resutls after r146206.

platform/qt/css3/compositing/effect-background-blend-mode-expected.png: Added.
platform/qt/css3/css3-modsel-33-expected.png:
platform/qt/css3/css3-modsel-35-expected.png:
platform/qt/css3/css3-modsel-36-expected.png:
platform/qt/css3/css3-modsel-37-expected.png:
platform/qt/css3/filters/custom/custom-filter-color-matrix-expected.png: Added.
platform/qt/css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
platform/qt/css3/filters/effect-invert-hw-expected.png:
platform/qt/css3/filters/filter-repaint-child-layers-expected.png: Added.
platform/qt/css3/filters/nested-filter-expected.png:
platform/qt/css3/filters/regions-expanding-expected.png:
platform/qt/css3/flexbox/flexbox-baseline-expected.png:
platform/qt/css3/images/cross-fade-background-size-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14c-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-14e-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-15-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-150-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-159-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-16-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-161-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-168-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-168a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-169-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-169a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-18-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-181-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-183-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-18b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-19-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-19b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-20-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-21-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-22-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-23-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-24-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-28-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-28b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-29-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-29b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-30-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-31-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-32-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-33-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-34-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-35-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-36-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-37-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-38-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-39c-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-3a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-41-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-41a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-42-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-42a-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-43-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-43b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-44-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-44b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-45-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-45b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-46-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-46b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-54-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-55-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-56-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-59-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-60-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-61-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-62-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-63-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-64-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-65-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-66-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-67-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-68-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-69-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-7-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-72-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-72b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-73-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-73b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-74-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-74b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-75-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-75b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-76-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-76b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-77-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-77b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-78-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-78b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-79-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-8-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-80-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-81-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-81b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-82-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-82b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-87-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-87b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-9-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-90-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-90b-expected.png:
platform/qt/css3/selectors3/html/css3-modsel-d4-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-1-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-10-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-100-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-100b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-101-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-101b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-102-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-102b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-103-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-103b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-104-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-104b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-105-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-105b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-106-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-106b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-107-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-107b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-108-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-108b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-109-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-109b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-11-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-110-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-110b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-111-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-111b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-112-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-112b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-113-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-113b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-114-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-114b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-115-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-115b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-116-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-116b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-117-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-117b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-118-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-119-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-120-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-121-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-122-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-123-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-124-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-124b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-125-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-125b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-126-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-126b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-127-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-127b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-128-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-128b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-129-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-129b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-13-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-130-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-130b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-131-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-131b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-132-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-132b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-133-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-133b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-134-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-134b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-135-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-135b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-136-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-136b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-137-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-137b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-138-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-138b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-139-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-139b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-14-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-140-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-140b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-141-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-141b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-142-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-142b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-143-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-143b-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-145a-expected.png:
platform/qt/css3/selectors3/xhtml/css3-modsel-145b-expected.png:

8:25 AM Changeset in webkit [146774] by ddkilzer@apple.com

2 edits in trunk/Source/WTF

WTF::binarySearchImpl() should compile with -Wshorten-64-to-32
<http://webkit.org/b/113170>

Reviewed by Dan Bernstein.

Fixes the following build failure:

/usr/local/include/wtf/StdLibExtras.h:190:30: error: implicit conversion loses integer precision: 'unsigned long' to 'int' [-Werror,-Wshorten-64-to-32]

int pos = (size - 1) >> 1;

~ ~^~

1 error generated.

wtf/StdLibExtras.h:

(WTF::binarySearchImpl): Switch type from int to size_t.

8:09 AM Changeset in webkit [146773] by kadam@inf.u-szeged.hu

123 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated expected png results r146206.

platform/qt-5.0-wk2/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
platform/qt-5.0-wk2/css2.1/t1004-c5524-width-00-b-g-expected.png: Added.
platform/qt/css2.1/20110323/absolute-non-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-height-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-max-height-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-max-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-002-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-003-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-004-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-005-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-009-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-010-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-012-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-013-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-014-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-016-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-017-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-018-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-019-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-020-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-021-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-022-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-023-expected.png:
platform/qt/css2.1/20110323/absolute-non-replaced-width-024-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-009-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-010-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-016-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-017-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-022-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-023-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-024-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-029-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-030-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-height-031-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-013-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-020-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-022-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-027-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-029-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-034-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-036-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-041-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-043-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-048-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-050-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-055-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-057-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-062-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-064-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-069-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-071-expected.png:
platform/qt/css2.1/20110323/absolute-replaced-width-076-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-002-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-005-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-height-006-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-005-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/block-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/block-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/block-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/block-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/border-conflict-style-079-expected.png:
platform/qt/css2.1/20110323/border-conflict-style-088-expected.png:
platform/qt/css2.1/20110323/border-spacing-applies-to-015-expected.png:
platform/qt/css2.1/20110323/empty-inline-003-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-007-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-008-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-009-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-010-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/float-non-replaced-width-012-expected.png:
platform/qt/css2.1/20110323/float-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/float-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/float-replaced-width-011-expected.png:
platform/qt/css2.1/20110323/floating-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-002-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-003-expected.png:
platform/qt/css2.1/20110323/inline-block-non-replaced-width-004-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/inline-block-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/inline-replaced-height-001-expected.png:
platform/qt/css2.1/20110323/inline-replaced-height-008-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-001-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-006-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-014-expected.png:
platform/qt/css2.1/20110323/inline-replaced-width-015-expected.png:
platform/qt/css2.1/20110323/margin-applies-to-010-expected.png:
platform/qt/css2.1/20110323/replaced-intrinsic-001-expected.png:
platform/qt/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
platform/qt/css2.1/20110323/table-caption-002-expected.png:
platform/qt/css2.1/20110323/table-caption-optional-001-expected.png:
platform/qt/css2.1/20110323/table-caption-optional-002-expected.png:
platform/qt/css2.1/20110323/table-height-algorithm-023-expected.png:
platform/qt/css2.1/20110323/table-height-algorithm-024-expected.png:
platform/qt/css2.1/20110323/width-non-replaced-inline-001-expected.png:
platform/qt/css2.1/t051103-c21-activ-ln-00-e-i-expected.png:
platform/qt/css2.1/t051103-c21-hover-ln-00-e-i-expected.png:
platform/qt/css2.1/t060403-c21-pseu-cls-00-e-i-expected.png:
platform/qt/css2.1/t060403-c21-pseu-id-00-e-i-expected.png:
platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/qt/css2.1/t1202-counters-08-b-expected.png:
platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
platform/qt/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
platform/qt/css2.1/t1508-c527-font-07-b-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.png:
platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.png:

7:50 AM Changeset in webkit [146772] by kadam@inf.u-szeged.hu

68 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Updated png results after r146206.

platform/qt/css1/basic/class_as_selector-expected.png:
platform/qt/css1/basic/comments-expected.png:
platform/qt/css1/basic/contextual_selectors-expected.png:
platform/qt/css1/basic/grouping-expected.png:
platform/qt/css1/basic/id_as_selector-expected.png:
platform/qt/css1/box_properties/acid_test-expected.png:
platform/qt/css1/box_properties/border_bottom_inline-expected.png:
platform/qt/css1/box_properties/border_bottom_width-expected.png:
platform/qt/css1/box_properties/border_bottom_width_inline-expected.png:
platform/qt/css1/box_properties/border_color-expected.png:
platform/qt/css1/box_properties/border_color_inline-expected.png:
platform/qt/css1/box_properties/border_inline-expected.png:
platform/qt/css1/box_properties/border_left_inline-expected.png:
platform/qt/css1/box_properties/border_left_width_inline-expected.png:
platform/qt/css1/box_properties/border_right-expected.png:
platform/qt/css1/box_properties/border_right_width_inline-expected.png:
platform/qt/css1/box_properties/border_style_inline-expected.png:
platform/qt/css1/box_properties/border_top_inline-expected.png:
platform/qt/css1/box_properties/border_top_width-expected.png:
platform/qt/css1/box_properties/border_top_width_inline-expected.png:
platform/qt/css1/box_properties/border_width-expected.png:
platform/qt/css1/box_properties/border_width_inline-expected.png:
platform/qt/css1/box_properties/clear-expected.png:
platform/qt/css1/box_properties/float-expected.png:
platform/qt/css1/box_properties/float_elements_in_series-expected.png:
platform/qt/css1/box_properties/height-expected.png:
platform/qt/css1/box_properties/margin-expected.png:
platform/qt/css1/box_properties/margin_bottom-expected.png:
platform/qt/css1/box_properties/margin_bottom_inline-expected.png:
platform/qt/css1/box_properties/margin_left_inline-expected.png:
platform/qt/css1/box_properties/margin_right_inline-expected.png:
platform/qt/css1/box_properties/margin_top-expected.png:
platform/qt/css1/box_properties/margin_top_inline-expected.png:
platform/qt/css1/box_properties/padding-expected.png:
platform/qt/css1/box_properties/padding_left_inline-expected.png:
platform/qt/css1/box_properties/padding_right_inline-expected.png:
platform/qt/css1/box_properties/padding_top-expected.png:
platform/qt/css1/box_properties/padding_top_inline-expected.png:
platform/qt/css1/box_properties/width-expected.png:
platform/qt/css1/classification/list_style-expected.png:
platform/qt/css1/classification/list_style_image-expected.png:
platform/qt/css1/classification/list_style_position-expected.png:
platform/qt/css1/classification/list_style_type-expected.png:
platform/qt/css1/classification/white_space-expected.png:
platform/qt/css1/color_and_background/background-expected.png:
platform/qt/css1/color_and_background/background_attachment-expected.png:
platform/qt/css1/color_and_background/background_color-expected.png:
platform/qt/css1/color_and_background/background_image-expected.png:
platform/qt/css1/color_and_background/color-expected.png:
platform/qt/css1/font_properties/font_family-expected.png:
platform/qt/css1/font_properties/font_size-expected.png:
platform/qt/css1/font_properties/font_style-expected.png:
platform/qt/css1/font_properties/font_variant-expected.png:
platform/qt/css1/font_properties/font_weight-expected.png:
platform/qt/css1/formatting_model/canvas-expected.png:
platform/qt/css1/formatting_model/floating_elements-expected.png:
platform/qt/css1/formatting_model/height_of_lines-expected.png:
platform/qt/css1/formatting_model/horizontal_formatting-expected.png:
platform/qt/css1/formatting_model/replaced_elements-expected.png:
platform/qt/css1/text_properties/letter_spacing-expected.png:
platform/qt/css1/text_properties/line_height-expected.png:
platform/qt/css1/text_properties/text_align-expected.png:
platform/qt/css1/text_properties/vertical_align-expected.png:
platform/qt/css1/text_properties/word_spacing-expected.png:
platform/qt/css1/units/color_units-expected.png:
platform/qt/css1/units/length_units-expected.png:
platform/qt/css1/units/percentage_units-expected.png:

7:42 AM Changeset in webkit [146771] by caseq@chromium.org

4 edits in trunk

Web Inspector: [Timeline] set glue records mode off by default
https://bugs.webkit.org/show_bug.cgi?id=113189

Reviewed by Pavel Feldman.

Source/WebCore:

inspector/front-end/TimelinePanel.js: /glueRecordsSetting/s/true/false/

LayoutTests:

inspector/timeline/timeline-receive-response-event.html: enable glue records mode for the test.

7:29 AM QtWebKitBuildBots edited by zarvai@inf.u-szeged.hu

Removing Amazon bot after its shutdown. (diff)

7:27 AM Changeset in webkit [146770] by gyuyoung.kim@samsung.com

5 edits in trunk/Source/WebCore

[EFL] Fix build break when media source is enabled
https://bugs.webkit.org/show_bug.cgi?id=113143

Unreviewed. Build error needs to be fixed in order to start to implement
media source functionality.

CMakeLists.txt:
platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

7:26 AM Changeset in webkit [146769] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Toggling breakpoint with shortcut should be freezed as well while editing.
https://bugs.webkit.org/show_bug.cgi?id=113188

Reviewed by Pavel Feldman.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):

7:23 AM Changeset in webkit [146768] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Remove unneeded code from JavaScriptSourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=113182

Reviewed by Pavel Feldman.

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

6:56 AM Changeset in webkit [146767] by commit-queue@webkit.org

9 edits in trunk/Source

Web Inspector: Fonts refactoring
https://bugs.webkit.org/show_bug.cgi?id=113047

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

Unify fonts usage across inspector.
Make inspector default font depend on platform.

Source/WebCore:

inspector/front-end/dataGrid.css:

(.data-grid table):
(.data-grid td):

inspector/front-end/inspector.css:

(.toolbar-label):
(body.show-toolbar-icons .toolbar-label):
(.console-message .bubble):
(li .status .bubble):
(.source-frame-breakpoint-message):
(.soft-context-menu):

inspector/front-end/inspectorCommon.css:

(body):

inspector/front-end/networkLogView.css:

(.network-log-grid.data-grid td):
(.network-log-grid.data-grid.small td):

inspector/front-end/tabbedPane.css:

(.tabbed-pane-header-tab):
(select.tabbed-pane-header-tabs-drop-down-select):

inspector/front-end/timelinePanel.css:

(.memory-counter-value):

Source/WebKit/chromium:

src/js/devTools.css:

(body.platform-linux):
(body.platform-mac):
(body.platform-windows):

6:54 AM Changeset in webkit [146766] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt] Qml WebKit needs preferences to change security knobs
https://bugs.webkit.org/show_bug.cgi?id=111979

Patch by Maxim Ermilov <maxim.ermilov@canonical.com> on 2013-03-25
Reviewed by Jocelyn Turcotte.

UIProcess/API/qt/qwebpreferences.cpp:

(QWebPreferencesPrivate::testAttribute):
(QWebPreferencesPrivate::setAttribute):
(QWebPreferences::universalAccessFromFileURLsAllowed):
(QWebPreferences::setUniversalAccessFromFileURLsAllowed):
(QWebPreferences::fileAccessFromFileURLsAllowed):
(QWebPreferences::setFileAccessFromFileURLsAllowed):

UIProcess/API/qt/qwebpreferences_p.h:
UIProcess/API/qt/qwebpreferences_p_p.h:

6:52 AM Changeset in webkit [146765] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Use generate-inspector-protocol-version to list valid public API changes
https://bugs.webkit.org/show_bug.cgi?id=113148

Added --show-changes command line option.
Used existing compare_schemas method to do a reverse compare.
Fixed a number of small problems (missing domain name in the message,
incorrect error messages for command parameters).

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-25
Reviewed by Pavel Feldman.

inspector/generate-inspector-protocol-version:

(named_list_to_map):
(removed):
(required):
(compare_schemas):
(compare_domains):
(compare_commands):
(compare_events):
(compare_params_list):
(compare_types):
(self_test):
(self_test.create_test_schema_1):
(self_test.create_test_schema_2):
(self_test.is_subset):
(self_test.errors_match):
(main):

6:42 AM Changeset in webkit [146764] by alecflett@chromium.org

17 edits
9 adds in trunk

Support Quota API in Workers
https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by Adam Barth.

Source/WebCore:

Tests: fast/workers/shared-worker-storagequota-query-usage.html

fast/workers/worker-storagequota-query-usage.html

Modules/quota/WorkerNavigatorStorageQuota.cpp: Added.
Modules/quota/WorkerNavigatorStorageQuota.h: Added.
Modules/quota/WorkerNavigatorStorageQuota.idl: Added.
WebCore.gypi: Add entries for WorkerNavigatorStorageQuota.
page/WorkerNavigator.h: Add a Navigator supplement that extends the worker navigator.

LayoutTests:

fast/workers/resources/shared-worker-common.js:

(handleMessage): Allow port to be dynamically discovered from self.

fast/workers/resources/storagequota-query-usage.js: Added.

(worker.onmessage):

fast/workers/resources/worker-storagequota-query-usage.js: Added.

(requestUsage.errorCallback):
(requestUsage.usageCallback):
(requestUsage):

fast/workers/shared-worker-storagequota-query-usage-expected.txt: Added.
fast/workers/shared-worker-storagequota-query-usage.html: Added.
fast/workers/worker-storagequota-query-usage-expected.txt: Added.
fast/workers/worker-storagequota-query-usage.html: Added.

6:39 AM Changeset in webkit [146763] by mkwst@chromium.org

15 edits in trunk

CSP 1.1: Rename SecurityPolicyViolationEvent::sourceURL to ::sourceFile.
https://bugs.webkit.org/show_bug.cgi?id=113033

Reviewed by Jochen Eisinger.

Source/WebCore:

Bringing our experimental implementation into line with the spec, which
has landed on the de facto standard name Gecko has been sending out for
years and years.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/e44f4003e158
Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0087.html

dom/SecurityPolicyViolationEvent.h:

(SecurityPolicyViolationEventInit):
(WebCore::SecurityPolicyViolationEvent::sourceFile):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):
(SecurityPolicyViolationEvent):

dom/SecurityPolicyViolationEvent.idl:
page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

s/sourceURL/sourceFile/

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:

6:10 AM Changeset in webkit [146762] by Michelangelo De Simone

8 edits
20 adds in trunk

[CSS Filters] Using negative drop-shadow radius values has slow performance
https://bugs.webkit.org/show_bug.cgi?id=107848

Source/WebCore:

Setting negative blur radius values in drop-shadow() and box-shadow() led to
significant rendering performance loss. The invalid value overflowed and the
embedder became unresponsive for few seconds.
This impacted SVG too (SVGFEDropShadow and SVGFEGaussianBlur).

Reviewed by Dirk Schulze.

Tests: css3/filters/effect-drop-shadow-negative-radius.html

fast/box-shadow/box-shadow-parsing-invalid.html
svg/filters/feDropShadow-negative-deviation-expected.svg
svg/filters/feDropShadow-negative-deviation.svg
svg/filters/feDropShadow-zero-deviation.svg
svg/filters/feGaussianBlur-negative-deviation-expected.svg
svg/filters/feGaussianBlur-negative-deviation.svg
svg/filters/feGaussianBlur-zero-deviation.svg

css/CSSParser.cpp:

(WebCore::CSSParser::parseShadow): Negative values are skipped during parsing: as per
CSS Background and Borders specs, negative values shall not be allowed.

platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::calculateUnscaledKernelSize): Added "non-negative" assertion for
negative deviations.

svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build): If a negative standard deviation is encountered, don't
build the filter and returns earlier, this avoids unnecessary calls: FEGaussianBlur is not being
created with wrong and potentially overflowing values.

svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build): Ditto.

LayoutTests:

Added a whole set of new tests for both CSS and SVG to assess the correctness of
blur(), drop-shadow() and box-shadow() blur radius values.

Reviewed by Dirk Schulze.

css3/filters/effect-drop-shadow-negative-radius-expected.html: Added.
css3/filters/effect-drop-shadow-negative-radius.html: Added.
css3/filters/filter-property-parsing-invalid-expected.txt:
css3/filters/script-tests/filter-property-parsing-invalid.js:
fast/box-shadow/box-shadow-parsing-invalid-expected.txt: Added.
fast/box-shadow/box-shadow-parsing-invalid.html: Added.
fast/box-shadow/script-tests/box-shadow-parsing-invalid.js: Added.

(testInvalidFilterRule):

platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
platform/chromium/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
platform/chromium/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
platform/mac/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
svg/filters/feDropShadow-negative-deviation-expected.svg: Added.
svg/filters/feDropShadow-negative-deviation.svg: Added.
svg/filters/feDropShadow-zero-deviation.svg: Added.
svg/filters/feGaussianBlur-negative-deviation-expected.svg: Added.
svg/filters/feGaussianBlur-negative-deviation.svg: Added.
svg/filters/feGaussianBlur-zero-deviation.svg: Added.

6:06 AM Changeset in webkit [146761] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] REGRESSION(r146630): 8 text related test asserts on debug builds
https://bugs.webkit.org/show_bug.cgi?id=113179

Reviewed by Jocelyn Turcotte.

Test if range.start is within the valid range before testing the value at that point.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

5:55 AM Changeset in webkit [146760] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Properly handle the rule addition to an XML or SVG document.
https://bugs.webkit.org/show_bug.cgi?id=113185

Reviewed by Pavel Feldman.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

5:38 AM Changeset in webkit [146759] by commit-queue@webkit.org

6 edits
3 adds in trunk

Web Inspector: support changing local variables in frontend
https://bugs.webkit.org/show_bug.cgi?id=112470

Patch by Peter Rybin <prybin@chromium.org> on 2013-03-25
Reviewed by Yury Semikhatsky.

Source/WebCore:

ScopeRef type is added to RemoteObject and setPropertyValue is patched accordingly.

Test: inspector/debugger/debugger-change-variable.html

inspector/front-end/DebuggerModel.js:

(WebInspector.DebuggerModel.CallFrame.prototype.get id):

inspector/front-end/ObjectPropertiesSection.js:

(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate.didGetDetails):
(WebInspector.FunctionScopeMainTreeElement.prototype.onpopulate):

inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject):
(WebInspector.RemoteObject.fromScopePayload):
(WebInspector.RemoteObject.prototype.):
(WebInspector.RemoteObject.prototype.setPropertyValue):
(WebInspector.RemoteObject.prototype.setVariableValueCallback):
(WebInspector.RemoteObject.prototype._setDeclarativeVariableValue):
(WebInspector.ScopeRef):

inspector/front-end/ScopeChainSidebarPane.js:

(WebInspector.ScopeChainSidebarPane.prototype.update):

LayoutTests:

inspector/debugger/debugger-change-variable-expected.txt: Added.
inspector/debugger/debugger-change-variable.html: Added.
platform/chromium/inspector/debugger/debugger-change-variable-expected.txt: Added.

5:20 AM Changeset in webkit [146758] by mkwst@chromium.org

5 edits
3 copies
8 adds in trunk

CSP 1.1: Strip URLs in SecurityPolicyViolationEvents, just as we do for POSTed violation reports.
https://bugs.webkit.org/show_bug.cgi?id=113039

Reviewed by Jochen Eisinger.

Source/WebCore:

I'd originally assumed that we didn't need to be quite so careful when
handing URLs to JavaScript via SecurityPolicyViolationEvents. This was
a mistake. Cross-origin URLs aren't accessible to JavaScript currently
and there's no reason that we should begin exposing them via an event.

This patch extracts the stripping logic from the existing reports into
stripURLForUseInReport(), and uses that new method when populating the
event and report objects.

Relatedly, we were doing the wrong thing with 'file:' URLs, which this
patch made clear. Now they're treated the same as 'data:' et al.

Spec: https://dvcs.w3.org/hg/content-security-policy/rev/45f6ccaba0ef

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html

page/ContentSecurityPolicy.cpp:

(WebCore::stripURLForUseInReport):

Extract the logic from blockedURI out into a reusable method:
cross-origin URLs are stripped down to the ASCII serialization of
their origin, and non-heirarchical (and 'file:') URLs are stripped
down to the ASCII serialization of their protocol.

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

Use ::stripURLForUseInReport for blockedURL and sourceFile
attributes in these two methods.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
http/tests/security/contentSecurityPolicy/resources/securitypolicyviolation-test.js: Added.

Updating tests to cover cross-origin scenarios: load cross-origin
images, and cross-origin scripts that inject images. The former
should strip the image URL down to the origin, the latter the
script URL.

http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
http/tests/security/contentSecurityPolicy/report-blocked-file-uri.html: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.

This patch changes the behavior of 'file:' URLs to behave similarly
to 'data:'/'blob:', etc. We weren't previously testing this, now we
are. We need platform-specific results for Chromium and GTK, since
those ports have enabled CSP_NEXT, which adds a field to the report.

4:35 AM Changeset in webkit [146757] by eustas@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: Fix JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=113025

Reviewed by Pavel Feldman.

Next version of JS compiler finds more inconsistencies
and ambiguous declarations.
Some of them are resolved in this patch.

inspector/InjectedScriptSource.js: Fix JSDocs.
inspector/front-end/ConsoleModel.js: Ditto.
inspector/front-end/CookieParser.js: Ditto.
inspector/front-end/FileContentView.js: Ditto.
inspector/front-end/HeapSnapshotView.js: Ditto.
inspector/front-end/IndexedDBModel.js: Ditto.
inspector/front-end/ProfilesPanelDescriptor.js: Ditto.
inspector/front-end/utilities.js: Ditto.

4:30 AM Changeset in webkit [146756] by zarvai@inf.u-szeged.hu

196 edits
1 copy
14 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Making pixel test bot happier after r146206.

platform/qt/fast/frames/flattening/frameset-flattening-grid-expected.png:
platform/qt/fast/frames/flattening/frameset-flattening-simple-expected.png:
platform/qt/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-height-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-fixed-width-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-offscreen-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-out-of-view-expected.png:
platform/qt/fast/frames/flattening/iframe-flattening-simple-expected.png:
platform/qt/fast/frames/frame-scrolling-attribute-expected.png:
platform/qt/fast/frames/frameset-style-recalc-expected.png:
platform/qt/fast/frames/iframe-scrolling-attribute-expected.png:
platform/qt/fast/frames/iframe-with-frameborder-expected.png:
platform/qt/fast/frames/viewsource-attribute-expected.png:
platform/qt/fast/gradients/background-clipped-expected.png:
platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png:
platform/qt/fast/gradients/crash-on-zero-radius-expected.png:
platform/qt/fast/gradients/radial-centered-expected.png:
platform/qt/fast/html/details-nested-1-expected.png:
platform/qt/fast/html/details-nested-2-expected.png:
platform/qt/fast/html/details-writing-mode-expected.png:
platform/qt/fast/html/font-weight-bold-for-b-and-strong-expected.png:
platform/qt/fast/html/link-rel-stylesheet-expected.png:
platform/qt/fast/html/listing-expected.png:
platform/qt/fast/html/marquee-scroll-expected.png:
platform/qt/fast/html/marquee-scrollamount-expected.png:
platform/qt/fast/images/image-map-anchor-children-expected.png:
platform/qt/fast/images/imagemap-circle-focus-ring-expected.png:
platform/qt/fast/images/imagemap-focus-ring-expected.png:
platform/qt/fast/images/imagemap-focus-ring-outline-color-expected.png:
platform/qt/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.png:
platform/qt/fast/images/imagemap-focus-ring-zoom-expected.png:
platform/qt/fast/images/imagemap-polygon-focus-ring-expected.png:
platform/qt/fast/inline-block/001-expected.png:
platform/qt/fast/inline-block/002-expected.png:
platform/qt/fast/inline-block/003-expected.png:
platform/qt/fast/inline-block/006-expected.png:
platform/qt/fast/inline-block/14498-positionForCoordinates-expected.png:
platform/qt/fast/inline-block/contenteditable-baseline-expected.png:
platform/qt/fast/inline-block/tricky-baseline-expected.png:
platform/qt/fast/inline/25277-2-expected.png:
platform/qt/fast/inline/25277-expected.png:
platform/qt/fast/inline/continuation-outlines-with-layers-2-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlines-expected.png:
platform/qt/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
platform/qt/fast/inline/emptyInlinesWithinLists-expected.png:
platform/qt/fast/inline/inline-continuation-borders-expected.png:
platform/qt/fast/inline/inline-focus-ring-expected.png:
platform/qt/fast/inline/inline-text-quirk-bpm-expected.png:
platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png:
platform/qt/fast/inline/long-wrapped-line-expected.png:
platform/qt/fast/inline/nested-top-alignment-expected.png:
platform/qt/fast/inline/vertical-align-text-bottom-expected.png:
platform/qt/fast/invalid/003-expected.png:
platform/qt/fast/invalid/004-expected.png:
platform/qt/fast/invalid/010-expected.png:
platform/qt/fast/invalid/014-expected.png:
platform/qt/fast/invalid/016-expected.png:
platform/qt/fast/invalid/019-expected.png:
platform/qt/fast/invalid/021-expected.png:
platform/qt/fast/invalid/missing-address-end-tag-expected.png:
platform/qt/fast/invalid/missing-dl-end-tag-expected.png:
platform/qt/fast/invalid/missing-dt-end-tag-expected.png:
platform/qt/fast/invalid/missing-font-end-tag-expected.png:
platform/qt/fast/invalid/nestedh3s-expected.png:
platform/qt/fast/invalid/td-inside-object-expected.png:
platform/qt/fast/layers/inline-dirty-z-order-lists-expected.png:
platform/qt/fast/layers/opacity-transforms-expected.png:
platform/qt/fast/layers/remove-only-this-layer-update-expected.png:
platform/qt/fast/line-grid/line-align-left-edges-expected.png:
platform/qt/fast/line-grid/line-align-right-edges-expected.png:
platform/qt/fast/line-grid/line-grid-floating-expected.png:
platform/qt/fast/line-grid/line-grid-into-floats-expected.png:
platform/qt/fast/line-grid/line-grid-positioned-expected.png:
platform/qt/fast/lists/001-expected.png:
platform/qt/fast/lists/001-vertical-expected.png:
platform/qt/fast/lists/002-expected.png:
platform/qt/fast/lists/002-vertical-expected.png:
platform/qt/fast/lists/007-expected.png:
platform/qt/fast/lists/007-vertical-expected.png:
platform/qt/fast/lists/008-expected.png:
platform/qt/fast/lists/008-vertical-expected.png:
platform/qt/fast/lists/anonymous-items-expected.png:
platform/qt/fast/lists/big-list-marker-expected.png:
platform/qt/fast/lists/li-br-expected.png:
platform/qt/fast/lists/li-style-alpha-huge-value-crash-expected.png:
platform/qt/fast/lists/list-item-line-height-expected.png:
platform/qt/fast/lists/list-style-none-crash-expected.png:
platform/qt/fast/lists/ol-display-types-expected.png:
platform/qt/fast/lists/ol-start-parsing-expected.png:
platform/qt/fast/lists/olstart-expected.png:
platform/qt/fast/multicol/block-axis-horizontal-bt-expected.png:
platform/qt/fast/multicol/block-axis-horizontal-tb-expected.png:
platform/qt/fast/multicol/block-axis-vertical-lr-expected.png:
platform/qt/fast/multicol/block-axis-vertical-rl-expected.png:
platform/qt/fast/multicol/client-rects-expected.png:
platform/qt/fast/multicol/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/column-count-with-rules-expected.png:
platform/qt/fast/multicol/float-avoidance-expected.png:
platform/qt/fast/multicol/float-paginate-complex-expected.png:
platform/qt/fast/multicol/float-paginate-expected.png:
platform/qt/fast/multicol/layers-in-multicol-expected.png:
platform/qt/fast/multicol/margin-collapse-expected.png:
platform/qt/fast/multicol/max-height-columns-block-expected.png:
platform/qt/fast/multicol/overflow-across-columns-expected.png:
platform/qt/fast/multicol/overflow-unsplittable-expected.png:
platform/qt/fast/multicol/paginate-block-replaced-expected.png:
platform/qt/fast/multicol/positioned-split-expected.png:
platform/qt/fast/multicol/positive-leading-expected.png:
platform/qt/fast/multicol/progression-reverse-expected.png:
platform/qt/fast/multicol/shadow-breaking-expected.png:
platform/qt/fast/multicol/span/anonymous-before-child-parent-crash-expected.png:
platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.png:
platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png:
platform/qt/fast/multicol/table-margin-collapse-expected.png:
platform/qt/fast/multicol/table-vertical-align-expected.png:
platform/qt/fast/multicol/unsplittable-inline-block-expected.png:
platform/qt/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/vertical-lr/column-count-with-rules-expected.png:
platform/qt/fast/multicol/vertical-lr/float-multicol-expected.png:
platform/qt/fast/multicol/vertical-lr/float-paginate-expected.png:
platform/qt/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png:
platform/qt/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
platform/qt/fast/multicol/vertical-rl/column-count-with-rules-expected.png:
platform/qt/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/qt/fast/multicol/vertical-rl/float-paginate-expected.png:
platform/qt/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png:
platform/qt/fast/overflow/001-expected.png:
platform/qt/fast/overflow/002-expected.png:
platform/qt/fast/overflow/003-expected.png:
platform/qt/fast/overflow/004-expected.png:
platform/qt/fast/overflow/007-expected.png:
platform/qt/fast/overflow/008-expected.png:
platform/qt/fast/overflow/dynamic-hidden-expected.png:
platform/qt/fast/overflow/float-in-relpositioned-expected.png:
platform/qt/fast/overflow/hidden-scrollbar-resize-expected.png:
platform/qt/fast/overflow/line-clamp-expected.png:
platform/qt/fast/overflow/overflow-auto-table-expected.png:
platform/qt/fast/overflow/overflow-float-stacking-expected.png:
platform/qt/fast/overflow/overflow-focus-ring-expected.png:
platform/qt/fast/overflow/overflow-rtl-vertical-expected.png:
platform/qt/fast/overflow/overflow-stacking-expected.png:
platform/qt/fast/overflow/paged-x-div-with-column-gap-expected.png:
platform/qt/fast/overflow/position-fixed-transform-clipping-expected.png:
platform/qt/fast/overflow/scrollbar-position-update-expected.png:
platform/qt/fast/overflow/table-overflow-float-expected.png:
platform/qt/fast/overflow/trailing-float-linebox-expected.png:
platform/qt/fast/parser/001-expected.png:
platform/qt/fast/parser/broken-comments-vs-parsing-mode-expected.png:
platform/qt/fast/parser/entity-comment-in-style-expected.png:
platform/qt/fast/parser/nofoo-tags-inside-paragraph-expected.png:
platform/qt/fast/parser/open-comment-in-style-expected.png:
platform/qt/fast/reflections/inline-crash-expected.png:
platform/qt/fast/reflections/opacity-reflection-transform-expected.png:
platform/qt/fast/reflections/reflection-masks-expected.png:
platform/qt/fast/reflections/reflection-masks-opacity-expected.png:
platform/qt/fast/reflections/reflection-masks-outset-expected.png:
platform/qt/fast/reflections/reflection-nesting-expected.png:
platform/qt/fast/reflections/reflection-overflow-hidden-expected.png:
platform/qt/fast/regions/flow-content-basic-expected.png:
platform/qt/fast/regions/flow-content-basic-vertical-expected.png:
platform/qt/fast/regions/flow-content-basic-vertical-rl-expected.png:
platform/qt/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png:
platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png:
platform/qt/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png:
platform/qt/fast/regions/region-style-block-background-color-expected.png:
platform/qt/fast/regions/region-style-block-background-color2-expected.png:
platform/qt/fast/regions/text-region-split-small-pagination-expected.png:
platform/qt/fast/regions/top-overflow-out-of-second-region-expected.png:
platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png:
platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png:
platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png:
platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
platform/qt/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
platform/qt/fast/repaint/background-misaligned-expected.png:
platform/qt/fast/repaint/block-layout-inline-children-replaced-expected.png:
platform/qt/fast/repaint/focus-layers-expected.png:
platform/qt/fast/repaint/scale-page-shrink-expected.png:
platform/qt/fast/repaint/transform-absolute-child-expected.png:
platform/qt/fast/repaint/transform-absolute-in-positioned-container-expected.png:
platform/qt/fast/repaint/transform-relative-position-expected.png:
platform/qt/fast/repaint/transform-replaced-shadows-expected.png:
platform/qt/fast/replaced/004-expected.png:
platform/qt/fast/replaced/absolute-position-percentage-height-expected.png:
platform/qt/fast/replaced/absolute-position-with-auto-height-and-top-and-bottom-expected.png:
platform/qt/fast/replaced/absolute-position-with-auto-width-and-left-and-right-expected.png:
platform/qt/fast/replaced/applet-display-none-expected.png:
platform/qt/fast/replaced/image-resize-width-expected.png:

4:05 AM Changeset in webkit [146755] by mkwst@chromium.org

2 edits in trunk/Source/WebCore

Cleanup: Tiny nits in ContentSecurityPolicy::reportViolation.
https://bugs.webkit.org/show_bug.cgi?id=112784

Reviewed by Jochen Eisinger.

Just cleanup of three tiny nits I ran across in
ContentSecurityPolicy::reportViolation while doing other work.

'directiveText' and 'effectiveDirective' can't be empty; we pass in values at every callsite. We can safely remove the 'isEmpty()' checks. Moreover, even if they could possibly somehow be empty, we should still include those empty strings in the report, rather than dropping the values entirely.

We don't need to hold 'document->referrer()' in a temp variable.

page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation):

3:55 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

3:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:26 AM Changeset in webkit [146754] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

E: webkitgtk3 missing-sentinel Source/[...]/TestMain.cpp:47 g_build_filename takes a NULL sentinel.
https://bugs.webkit.org/show_bug.cgi?id=113036

Patch by Dominique Leuenberger <dimstar@opensuse.org> on 2013-03-25
Reviewed by Martin Robinson.

UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):

2:50 AM Changeset in webkit [146753] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032

Reviewed by Pavel Feldman.

To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.

This feature is hard to discover.

Setting "move" cursor will make this feature more discoverable.

inspector/front-end/inspectorCommon.css:

Set "move" cursor to draggable area.

inspector/front-end/OverviewGrid.js: Ditto.

2:33 AM Changeset in webkit [146752] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015

Reviewed by Pavel Feldman.

_profileGroupsForLinks is not used anymore.

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._reset): Removed unused member.

2:33 AM Changeset in webkit [146751] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardneing. Skip two tests, because they are failing with timed out.

platform/qt/TestExpectations:

2:01 AM Changeset in webkit [146750] by yurys@chromium.org

2 edits in trunk/LayoutTests

Mark fast/css/font-family-pictograph.html as flaky on Linux

platform/chromium/TestExpectations:

1:55 AM Changeset in webkit [146749] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Exception when turning on pretty print without any displayed source in the editor
https://bugs.webkit.org/show_bug.cgi?id=113136

Patch by PhistucK <phistuck@chromium.org> on 2013-03-25
Reviewed by Vsevolod Vlasov.

No new tests.
Added a check for the existence of currently edited document.

inspector/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._toggleFormatSource):

1:47 AM Changeset in webkit [146748] by mihnea@adobe.com

2 edits in trunk/Source/WebCore

[CSSRegions] Remove RenderRegion::printRegionObjectsStyles
https://bugs.webkit.org/show_bug.cgi?id=113081

Reviewed by Tony Chang.

No change in functionality, remove unused function..

rendering/RenderRegion.h:

1:45 AM Changeset in webkit [146747] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] Memory leak when closing a tab
https://bugs.webkit.org/show_bug.cgi?id=112127

Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-03-25
Reviewed by Noam Rosenthal.

When closing a tab, if there are any updates pending in CoordinatedGraphicsScene's
render queue, the scene is not freed because reference count of m_scene is not zero.

No new tests.

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::detach): When bind updates in CoordinatedGraphicsScene,
the reference count of m_scene is increasing, if m_renderQueue is not empty
before closing tab, then m_scene is never freed.
Hence, when closing tab, need to clear m_renderQueue explicitly in order to
destroy m_scene.

1:21 AM Changeset in webkit [146746] by keishi@webkit.org

3 edits
10 adds in trunk

Clear button visibility is not updated when restoring form state
https://bugs.webkit.org/show_bug.cgi?id=113172

Source/WebCore:

Clear button wasn't showing up when restoring form state.

Reviewed by Kent Tamura.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html

fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::restoreFormControlState):

LayoutTests:

Reviewed by Kent Tamura.

fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Added.

12:45 AM Changeset in webkit [146745] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Use registry to track settings objects.
https://bugs.webkit.org/show_bug.cgi?id=113008

Reviewed by Pavel Feldman.

Currently .createSetting creates new instance any time it is invoked.
When one instance saves value, the other instance do not know about it.

To resolve this issue we can use registry to make .createSetting return
same object for specific key.

inspector/front-end/Settings.js:

(WebInspector.Settings.prototype.createSetting): Use registry.

Mar 24, 2013:

9:58 PM Changeset in webkit [146744] by falken@chromium.org

9 edits in trunk/Source/WebCore

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods. The plan is to rename
Element::disabled to isDisabledFormControl and to remove
Element::isEnabledFormControl.

No new tests, just refactoring.

dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

dom/Element.h:

(Element):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:

(Node):

9:27 PM Changeset in webkit [146743] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

Start generating test images on the bots now that libwebp 0.3.0
has landed in chromium webkit.

platform/chromium/TestExpectations:

8:55 PM Changeset in webkit [146742] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] fast/text/international/danda-space.html is failing
https://bugs.webkit.org/show_bug.cgi?id=113169

Unreviewed test expectations update.

platform/chromium/TestExpectations:

7:15 PM Changeset in webkit [146741] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146740 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

pl.po: updated translation.

7:14 PM Changeset in webkit [146740] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=113113

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-24
Reviewed by Gustavo Noronha Silva (kov).

pl.po: updated translation.

6:57 PM Changeset in webkit [146739] by danakj@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Roll chromium deps to 190311.
https://bugs.webkit.org/show_bug.cgi?id=113161

Unreviewed, rolling deps.

DEPS:

5:38 PM Changeset in webkit [146738] by hayato@chromium.org

1 edit
2 adds in trunk/LayoutTests

[Shadow] Add a test of insertionParent for <shadow> element.
https://bugs.webkit.org/show_bug.cgi?id=113021

Reviewed by Dimitri Glazkov.

fast/dom/shadow/insertion-parent-shadow-expected.txt: Added.
fast/dom/shadow/insertion-parent-shadow.html: Added.

5:36 PM Changeset in webkit [146737] by hclam@chromium.org

4 edits in trunk/Source

GIFImageReader should reports parsing error to client
https://bugs.webkit.org/show_bug.cgi?id=113141

Reviewed by Stephen White.

Source/WebCore:

GIFImageReader nows reports parsing error to client (GIFImageDecoder) such that errors can be handled.
In the case of corrupted GIF images GIFImageReader will be deleted and decoding will fail.

Unit test is updated to reflect change in behavior.
Tested with a local corpus which showed better handling of corrupted GIF images.

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decode):

Source/WebKit/chromium:

Updated unit test that runs on a broken GIF image file, decoding should fail.

tests/GIFImageDecoderTest.cpp:

(WebKit::TEST):

4:37 PM Changeset in webkit [146736] by jamesr@google.com

5 edits in trunk/Source

[chromium] Wire windows scrollByPage enum up to compositor thread input handling
https://bugs.webkit.org/show_bug.cgi?id=113117

Reviewed by Adrienne Walker.

Source/Platform:

chromium/public/WebInputHandlerClient.h:

Source/WebKit/chromium:

src/WebCompositorInputHandlerImpl.cpp:

(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

tests/WebCompositorInputHandlerImplTest.cpp:

(MockWebInputHandlerClient):

4:15 PM Changeset in webkit [146735] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r190276. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-24

DEPS:

3:45 PM Changeset in webkit [146734] by mhahnenberg@apple.com

12 edits
2 adds in trunk/Source/JavaScriptCore

HandleSet should use HeapBlocks for storing handles
https://bugs.webkit.org/show_bug.cgi?id=113145

Reviewed by Geoffrey Garen.

GNUmakefile.list.am: Build project changes.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
heap/BlockAllocator.cpp: Rename the RegionSet to m_fourKBBlockRegionSet because there are

too many block types to include them all in the name now.
(JSC::BlockAllocator::BlockAllocator):

heap/BlockAllocator.h:

(BlockAllocator): Add the appropriate override for regionSetFor.
(JSC::WeakBlock):
(JSC::MarkStackSegment):
(JSC::HandleBlock):

heap/HandleBlock.h: Added.

(HandleBlock): New class for HandleBlocks.
(JSC::HandleBlock::blockFor): Static method to get the block of the given HandleNode pointer. Allows
us to quickly figure out which HandleSet the HandleNode belongs to without storing the pointer to it
in the HandleNode.
(JSC::HandleBlock::handleSet): Getter.

heap/HandleBlockInlines.h: Added.

(JSC::HandleBlock::create):
(JSC::HandleBlock::HandleBlock):
(JSC::HandleBlock::payloadEnd):
(JSC::HandleBlock::payload):
(JSC::HandleBlock::nodes):
(JSC::HandleBlock::nodeAtIndex):
(JSC::HandleBlock::nodeCapacity):

heap/HandleSet.cpp:

(JSC::HandleSet::~HandleSet):
(JSC::HandleSet::grow):

heap/HandleSet.h:

(HandleNode): Move the internal Node class from HandleSet to be its own public class so it can be
used by HandleBlock.
(HandleSet): Add a typedef so that Node refers to the new HandleNode class.
(JSC::HandleSet::toHandle):
(JSC::HandleSet::toNode):
(JSC::HandleSet::allocate):
(JSC::HandleSet::deallocate):
(JSC::HandleNode::HandleNode):
(JSC::HandleNode::slot):
(JSC::HandleNode::handleSet): Use the new blockFor static function to get the right HandleBlock and lookup
the HandleSet.
(JSC::HandleNode::setPrev):
(JSC::HandleNode::prev):
(JSC::HandleNode::setNext):
(JSC::HandleNode::next):
(JSC::HandleSet::forEachStrongHandle):

heap/Heap.h: Friend HandleSet so that it can access the BlockAllocator when allocating HandleBlocks.

12:16 PM Changeset in webkit [146733] by kareng@chromium.org

9 edits
2 copies in branches/chromium/1451/Source/WebCore

Revert 146458 "[EFL][WebGL] Implement a common GraphicsSurface I..."

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

platform/graphics/efl/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

platform/graphics/opengl/GLPlatformSurface.cpp:
(WebCore::GLPlatformSurface::createTransportSurface):

platform/graphics/opengl/GLPlatformSurface.h:
platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.
(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.
(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.
(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.h:
(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/13046002

12:13 PM Changeset in webkit [146732] by kareng@chromium.org

1 add in branches/chromium/1451/codereview.settings

for drovering

12:12 PM Changeset in webkit [146731] by kareng@chromium.org

1 copy in branches/chromium/1451

branching to revert a change for canary.

8:57 AM Changeset in webkit [146730] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[EFL] Add support to check for current Drawable.
https://bugs.webkit.org/show_bug.cgi?id=113103

Patch by KondapallyKalyan <kalyan.kondapally@intel.com> on 2013-03-24
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

In MakeCurrent we do an early return if it is
the current GL context but ignore Surface. This
patch fixes the issue, we now check for both
context and surface before doing an early return
in MakeCurrent.

platform/graphics/opengl/GLPlatformContext.cpp:

(WebCore::GLPlatformContext::makeCurrent):
(WebCore::GLPlatformContext::releaseCurrent):
(WebCore::GLPlatformContext::destroy):

platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore):
(WebCore::GLPlatformSurface::isCurrentDrawable):
(WebCore::GLPlatformSurface::onMakeCurrent):

platform/graphics/opengl/GLPlatformSurface.h:

8:47 AM Changeset in webkit [146729] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146704): Settings::setHiddenPageDOMTimerThrottlingEnabled() isn't always built
<http://webkit.org/b/112308>

WebCore.exp.in: Export

Settings::setHiddenPageDOMTimerThrottlingEnabled()
conditionally based on ENABLE(HIDDEN_PAGE_DOM_TIMER_THROTTLING).

7:43 AM Changeset in webkit [146728] by Christophe Dumez

2 edits in trunk/Source/WebCore

[EFL] NetworkStateNotifier::updateState() is called too often
https://bugs.webkit.org/show_bug.cgi?id=113152

Reviewed by Kenneth Rohde Christiansen.

Wait until we have read all the data on the Netlink socket before
reporting a possible network interface change. This way, we make
sure we don't call NetworkStateNotifier::updateState() several
times in a row for no reason.

We also call NetworkStateNotifier::updateState() only if we get a
RTM_NEWADDR event and we are currently offline, or if we get a
RTM_DELADDR and we are currently online. This avoids calling
NetworkStateNotifier::updateState() uselessly as there is no way
the online state can change otherwise.

No new tests, no behavior change for layout tests.

platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):

3:36 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:20 AM Changeset in webkit [146727] by Chris Fleizach

5 edits
2 adds in trunk

AX: Crash in WebCore::AccessibilitySpinButton::incrementButton()
https://bugs.webkit.org/show_bug.cgi?id=111582

Reviewed by Tim Horton.

Source/WebCore:

There are two ways to create a spin button: from a textfield counter or from ARIA.
If an ARIA spin button is created, it was returning true for isSpinButton, so we were
casting to the other kind of spin button, leading to a crash.

We need to be more specific about our class types.

Test: platform/mac/accessibility/aria-spinbutton-crash.html

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isNativeSpinButton):

accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::isNativeSpinButton):
(WebCore::toAccessibilitySpinButton):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

LayoutTests:

platform/mac/accessibility/aria-spinbutton-crash-expected.txt: Added.
platform/mac/accessibility/aria-spinbutton-crash.html: Added.

12:37 AM Changeset in webkit [146726] by Chris Fleizach

34 edits in trunk/Source/WebCore

AXObjectCache gets recreated during document tear-down.
https://bugs.webkit.org/show_bug.cgi?id=112525

Reviewed by Simon Fraser.

In many cases, a document's AXObjectCache was being created after the
document had detached, which is wasteful and could potentially lead to
crashes because the AXObjectCache has a timer and relies on its document
to exist.

This patch provides a way to get the existing AX object cache, instead of
always creating a new one.
It moves the accessibilityEnabled() checks into the axObjectCache retrieval
for easier readability.
It adds a number of ASSERTs to vieryf that only the correct (top) document is used
for cache manipulation.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

dom/ContainerNode.cpp:

(WebCore::ContainerNode::~ContainerNode):

dom/Document.cpp:

(WebCore::Document::~Document):
(WebCore::Document::clearAXObjectCache):
(WebCore::Document::existingAXObjectCache):
(WebCore::Document::axObjectCache):
(WebCore::Document::setFocusedNode):

dom/Document.h:

(Document):

dom/Element.cpp:

(WebCore::Element::attributeChanged):

dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::isEditableToAccessibility):
(WebCore::Node::attach):
(WebCore::Node::rootEditableElement):
(WebCore::Node::didMoveToNewDocument):

editing/AppendNodeCommand.cpp:

(WebCore::sendAXTextChangedIgnoringLineBreaks):

editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply):
(WebCore::DeleteFromTextNodeCommand::doUnapply):

editing/Editor.cpp:

(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):

editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doApply):
(WebCore::InsertIntoTextNodeCommand::doUnapply):

editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doApply):
(WebCore::InsertNodeBeforeCommand::doUnapply):

editing/atk/FrameSelectionAtk.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/chromium/FrameSelectionChromium.cpp:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setChecked):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setRecalcListItems):

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

html/InputType.cpp:

(WebCore::InputType::applyStep):

html/RangeInputType.cpp:

(WebCore::RangeInputType::handleKeydownEvent):

loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

page/FocusController.cpp:

(WebCore::FocusController::setInitialFocus):

page/Frame.cpp:

(WebCore::Frame::disconnectOwnerElement):

page/FrameView.cpp:

(WebCore::FrameView::removeFromAXObjectCache):
(WebCore::FrameView::layout):
(WebCore::FrameView::scrollToAnchor):
(WebCore::FrameView::axObjectCache):

platform/ScrollView.cpp:

(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

platform/Scrollbar.cpp:

(WebCore::Scrollbar::~Scrollbar):
(WebCore):
(WebCore::Scrollbar::existingAXObjectCache):

platform/Scrollbar.h:

(Scrollbar):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLineBoxTree):
(WebCore::RenderBlock::createRootInlineBox):
(WebCore::RenderBlock::createAndAppendRootInlineBox):

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectionChanged):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::addChild):
(WebCore::RenderMenuList::didUpdateActiveOption):

rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeDestroyed):

rendering/RenderObjectChildList.cpp:

(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):

rendering/RenderText.cpp:

(WebCore::RenderText::setText):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::willBeDestroyed):

Mar 23, 2013:

10:50 PM Changeset in webkit [146725] by mkwst@chromium.org

13 edits in trunk

Drop full URLs from cross-origin access errors caused by sandboxing.
https://bugs.webkit.org/show_bug.cgi?id=113029

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112042, this patch brings cross-origin
access error messages into line with the newly origin-only default
message, and changes the error message text to explicitly refer to the
missing 'allow-same-origin' sandbox flag that's the root cause of the
error.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

Note that we're using the origin of the frames' URLs rather than
their actual origin in these messages. This seems like a reasonable
thing to do, since we know that at least one of the two origins will
be "null" in this scenario.

LayoutTests:

http/tests/security/contentSecurityPolicy/sandbox-allow-scripts-in-http-header-expected.txt:
http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
http/tests/security/sandboxed-iframe-origin-add-expected.txt:
http/tests/security/sandboxed-iframe-origin-remove-expected.txt:
http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt:
platform/chromium/http/tests/security/sandboxed-iframe-modify-self-expected.txt:
platform/chromium/http/tests/security/srcdoc-in-sandbox-cannot-access-parent-expected.txt:

9:48 PM Changeset in webkit [146724] by dmazzoni@google.com

21 edits
9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

chromium/public/WebSpeechSynthesisUtterance.h: Added.

(WebKit):
(WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::~WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::isNull):

chromium/public/WebSpeechSynthesisVoice.h: Added.

(WebCore):
(WebKit):
(WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::~WebSpeechSynthesisVoice):
(WebKit::WebSpeechSynthesisVoice::operator=):

chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::boundaryEventOccurred):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didPauseSpeaking):
(WebCore::SpeechSynthesis::didResumeSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
(WebCore):

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):

Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::setVoiceURI):
(WebCore::PlatformSpeechSynthesisVoice::setName):
(WebCore::PlatformSpeechSynthesisVoice::setLang):
(WebCore::PlatformSpeechSynthesisVoice::setLocalService):
(WebCore::PlatformSpeechSynthesisVoice::setIsDefault):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):
(WebCore::PlatformSpeechSynthesizer::pause):
(WebCore::PlatformSpeechSynthesizer::resume):
(WebCore::PlatformSpeechSynthesizer::cancel):

platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisUtterance::WebSpeechSynthesisUtterance):
(WebKit::WebSpeechSynthesisUtterance::operator=):
(WebKit::WebSpeechSynthesisUtterance::assign):
(WebKit::WebSpeechSynthesisUtterance::reset):
(WebKit::WebSpeechSynthesisUtterance::operator PassRefPtr<PlatformSpeechSynthesisUtterance>):
(WebKit::WebSpeechSynthesisUtterance::operator PlatformSpeechSynthesisUtterance*):
(WebKit::WebSpeechSynthesisUtterance::text):
(WebKit::WebSpeechSynthesisUtterance::lang):
(WebKit::WebSpeechSynthesisUtterance::voice):
(WebKit::WebSpeechSynthesisUtterance::volume):
(WebKit::WebSpeechSynthesisUtterance::rate):
(WebKit::WebSpeechSynthesisUtterance::pitch):
(WebKit::WebSpeechSynthesisUtterance::startTime):

platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

(WebKit):
(WebKit::WebSpeechSynthesisVoice::assign):
(WebKit::WebSpeechSynthesisVoice::reset):
(WebKit::WebSpeechSynthesisVoice::setVoiceURI):
(WebKit::WebSpeechSynthesisVoice::setName):
(WebKit::WebSpeechSynthesisVoice::setLanguage):
(WebKit::WebSpeechSynthesisVoice::setIsLocalService):
(WebKit::WebSpeechSynthesisVoice::setIsDefault):
(WebKit::WebSpeechSynthesisVoice::operator PassRefPtr<WebCore::PlatformSpeechSynthesisVoice>):

platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

(WebCore):
(WebCore::WebSpeechSynthesizerClientImpl::WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl):
(WebCore::WebSpeechSynthesizerClientImpl::setVoiceList):
(WebCore::WebSpeechSynthesizerClientImpl::didStartSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didFinishSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didPauseSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::didResumeSpeaking):
(WebCore::WebSpeechSynthesizerClientImpl::speakingErrorOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::wordBoundaryEventOccurred):
(WebCore::WebSpeechSynthesizerClientImpl::sentenceBoundaryEventOccurred):

platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::speak):

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

6:24 PM Changeset in webkit [146723] by dcheng@chromium.org

4 edits in trunk

[Qt] editing/pasteboard/can-read-in-dragstart-event.html and /can-read-in-copy-and-cut-events.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=113126

Reviewed by Ryosuke Niwa.

Source/WebCore:

The ClipboardQt implementation only allows reading or writing, not both. Attempting to read
when the clipboard is only writable will lead to a crash since the corresponding member will
be null. To prevent crashes, change the asserts to early returns. In the long term, the
correct fix is to unify the m_readableData and m_writableData members.

No new tests since no functionality in Qt port should change.

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):

LayoutTests:

platform/qt/TestExpectations:

1:18 PM Changeset in webkit [146722] by ggaren@apple.com

2 edits in trunk/Source/WebKit2

Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999

Rolled out a line from r146664 that was left over from before I adopted
the Settings.in way of adding a new setting.

Reviewed by Ryosuke Niwa.

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): No need
to initialize / override -- Settings.in settings do this automatically.

Also, dydx noticed that this line of code had a typo, and was totaly wrong.

10:47 AM Changeset in webkit [146721] by commit-queue@webkit.org

6 edits in trunk/Source

[GTK][Regression] webkit_dom_html_table_element_insert_row returns value that doesn't pass WEBKIT_DOM_IS_HTML_TABLE_ROW_ELEMENT macro
https://bugs.webkit.org/show_bug.cgi?id=111714

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-23
Reviewed by Martin Robinson.

Source/WebCore:

Add custom kit implementation for HTMLElements so that the HTML
wrappers are used in that case instead of wrapHTMLElement.

bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::kit):
(WebKit):

bindings/gobject/WebKitDOMBinding.h:

(WebCore):
(WebKit):

bindings/scripts/CodeGeneratorGObject.pm:

(UsesManualKitImplementation):

Source/WebKit/gtk:

Add test that checks webkit_dom_html_table_element_insert_row() to
also preproduce this issue.

tests/testdomdocument.c:

(test_dom_document_insert_row):
(main):

7:44 AM Changeset in webkit [146720] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

Revert "BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS"

This is platform-agnositic code, so the previous solution won't work.

7:41 AM Changeset in webkit [146719] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146667): ResourceRequest constructor in SynchronousLoaderClient.cpp is ambiguous on iOS

Fixes the following build failure:

Source/WebCore/platform/network/SynchronousLoaderClient.cpp:52:15: error: conversion from 'int' to 'const WebCore::ResourceRequest' is ambiguous

request = 0;

In file included from Source/WebCore/platform/network/SynchronousLoaderClient.cpp:30:
In file included from Source/WebCore/platform/network/ResourceHandle.h:37:
In file included from Source/WebCore/platform/network/ios/QuickLook.h:13:
Source/WebCore/platform/network/cf/ResourceRequest.h:79:9: note: candidate constructor

ResourceRequest(NSURLRequest *);

Source/WebCore/platform/network/cf/ResourceRequest.h:83:9: note: candidate constructor

ResourceRequest(CFURLRequestRef cfRequest)

1 error generated.

platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::willSendRequest): If
USE(CFNETWORK) is defined, use static_cast<CFURLRequestRef>(0),
otherwise use static_cast<NSURLRequest *>(0).

7:16 AM Changeset in webkit [146718] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146687): setDefaultMIMEType() is unused in ResourceHandleCFNet.cpp on iOS

Fixes the following build failure:

Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:98:13: error: unused function 'setDefaultMIMEType' [-Werror,-Wunused-function]
static void setDefaultMIMEType(CFURLResponseRef response)

1 error generated.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::setDefaultMIMEType): Add #if !PLATFORM(MAC)/#endif
guard.

Mar 22, 2013:

11:36 PM Changeset in webkit [146717] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Stupid picky bug syntax...

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

10:58 PM Changeset in webkit [146716] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark flaky test.
https://bugs.webkit.org/show_bug.cgi?id=113129

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

10:47 PM Changeset in webkit [146715] by pkasting@chromium.org

4 edits
2 deletes in trunk/LayoutTests

[chromium] Last bits of post-Skia-change fallout, plus other bits.
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=113067
https://bugs.webkit.org/show_bug.cgi?id=113128
https://code.google.com/p/chromium/issues/detail?id=67442

Unreviewed, test expectations updates.

Deleted a few new baselines added during Skia rebaselining that were
existing expected failures from bug 109507 whose failure lines were
left in TestExpectations.

Added a flaky test and a failing test (which for some reason has no new
baselines so I can't rebaseline), and removed a passing test.

Re-added some "Pass" expectations I'd previously removed, as they're
necessary after all.

platform/chromium-linux/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.

9:59 PM Changeset in webkit [146714] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a timeout expectation to media/track/track-prefer-captions.html after
r146380 on GTK+. The failure is tracked by http://webkit.org/b/113127

platform/gtk/TestExpectations:

9:54 PM Changeset in webkit [146713] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add crash test expectations to tests added in r146644.
The failures are tracked by http://webkit.org/b/113126

platform/qt/TestExpectations:

9:51 PM Changeset in webkit [146712] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r145119): Make JSValue* properties default to (assign)
<rdar://problem/13380794>

Reviewed by Mark Hahnenberg.

Fixes the following build failures:

Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]
@property JSValue *onclick;
^{Source/JavaScriptCore/API/tests/testapi.mm:106:1: error: default property attrib ute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]

Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: no 'assign', 'retain', or 'copy' attribute is specified - 'assign' is assumed [-Werror,-Wobjc-property-no-attribute]

@property JSValue *weakOnclick;}
Source/JavaScriptCore/API/tests/testapi.mm:107:1: error: default property attribute 'assign' not appropriate for non-GC object [-Werror,-Wobjc-property-no-attribute]
4 errors generated.

API/tests/testapi.mm: Default to (assign) for JSValue*

properties.

9:20 PM Changeset in webkit [146711] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

testLeakingPrototypesAcrossContexts added in r146682 doesn't compile on Win and fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=113125

Reviewed by Mark Hahnenberg

Remove the test added in r146682 as it's now failing on Mac.
This is the test that was causing a compilation failure on Windows.

API/tests/testapi.c:

(main):

8:35 PM Changeset in webkit [146710] by rniwa@webkit.org

4 edits in trunk/Source/WebKit

The second part of the build fix for r146702. This should do it.
I had to see the mangled name for the new signature.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

8:34 PM Changeset in webkit [146709] by noel.gordon@gmail.com

2 edits in trunk/LayoutTests

[chromium] Mark canvas-toDataURL-webp.html imageOnlyFailure Pass
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome, changing the encoder
output, after which these test results will need to be updated.

platform/chromium/TestExpectations:

8:24 PM Changeset in webkit [146708] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

Fix the typo: WIN -> WINDOWS.

API/tests/testapi.c:

(main):

8:12 PM Changeset in webkit [146707] by rniwa@webkit.org

2 edits in trunk/Source/JavaScriptCore

I really can't figure out what's wrong with this one.
Temporarily disable the test added by r146682 on Windows since it doesn't compile.

API/tests/testapi.c:

(main):

8:09 PM Changeset in webkit [146706] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark more tests as crashing.
https://bugs.webkit.org/show_bug.cgi?id=113067

Unreviewed, test expectations update.

platform/chromium/TestExpectations:

7:50 PM Changeset in webkit [146705] by rniwa@webkit.org

4 edits in trunk/Source/WebKit

Build fix attempt after r146702.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

7:15 PM Changeset in webkit [146704] by cmuppala@apple.com

19 edits in trunk

Add runtime setting for hidden page DOM timer throttling and CSS animation suspension
https://bugs.webkit.org/show_bug.cgi?id=112308

Reviewed by Gavin Barraclough.

Source/WebCore:

No new tests. Only adding settings to enable/disable existing features
and hence existing tests suffice.

WebCore.exp.in:
page/Page.cpp:

(WebCore::Page::setVisibilityState): Check if DOM timer throttling
and CSS animation suspension are enabled before turning them on.
(WebCore::Page::hiddenPageDOMTimerThrottlingStateChanged): Start or stop
DOM timer throttling based on page visibility and the new setting state.
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged): Ditto
for CSS animation suspension.

page/Page.h:
page/Settings.cpp:

(WebCore::Settings::Settings): Initialize the flags for enabling hidden
page DOM timer throttling and CSS animation suspension to false.
(WebCore::Settings::setHiddenPageDOMTimerThrottlingEnabled): Update flag
and notify page that the state of the setting has changed.
(WebCore::Settings::setHiddenPageCSSAnimationSuspensionEnabled): Ditto.

page/Settings.h:

(WebCore::Settings::hiddenPageDOMTimerThrottlingEnabled):
(WebCore::Settings::hiddenPageCSSAnimationSuspensionEnabled):

Source/WebKit/mac:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
disabled by default to avoid compatibility issues.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences hiddenPageDOMTimerThrottlingEnabled]):
(-[WebPreferences setHiddenPageDOMTimerThrottlingEnabled:]):
(-[WebPreferences hiddenPageCSSAnimationSuspensionEnabled]):
(-[WebPreferences setHiddenPageCSSAnimationSuspensionEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add private preference for enabling/disabling hidden page DOM timer
throttling and CSS animation suspension. The preference should be
enabled by default only on Mac, where WebKit2 is a private API and
hence compatibility is less of a issue.

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesGetHiddenPageDOMTimerThrottlingEnabled):
(WKPreferencesSetHiddenPageCSSAnimationSuspensionEnabled):
(WKPreferencesGetHiddenPageCSSAnimationSuspensionEnabled):

UIProcess/API/C/WKPreferencesPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Allow
WebKitTestRunner to override hiddenPageDOMTimerThrottlingEnabled.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

Hidden page DOM timer throttling is disabled by default in WebKit1 and
in WebKit2 for platforms other than Mac. Override the preference to
enable it during the test.

fast/dom/timer-throttling-hidden-page.html:

7:01 PM Changeset in webkit [146703] by cmuppala@apple.com

2 edits in trunk/Tools

Unreviewed. Move self from contributor to committer list.

Scripts/webkitpy/common/config/committers.py:

6:35 PM Changeset in webkit [146702] by benjamin@webkit.org

7 edits in trunk/Source

Remove 2 bad branches from StringHash::equal() and CaseFoldingHash::equal()
https://bugs.webkit.org/show_bug.cgi?id=113003

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Eric Seidel.

Source/WebCore:

Fix two unfortunate use of StringHash and use the correct StringImpl function.

html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):

html/parser/HTMLTreeBuilderSimulator.cpp:

(WebCore::tokenExitsSVG):

Source/WTF:

StringHash::equal() and CaseFoldingHash::equal() were both testing for
the nullity of the two input pointers. The catch is: neither traits handle
null pointers, and any client code would have crashed on hash(), before equal()
is called.
Consequently, the two branches had a pass rate of zero when called from a HashMap code.

The function is also never inlined because it is too big (the code of equal() for characters
is always inlined, causing the function to be quite big).

This patch introduces two new functions in the StringImpl API: equalNonNull() and
equalIgnoringCaseNonNull(). Those functions are similar to their equal() equivalent
but make the assumtion the input is never null.

The functions are used for StringHash to avoid the useless branches.

wtf/text/StringHash.h:

(WTF::StringHash::equal):
(WTF::CaseFoldingHash::equal):

wtf/text/StringImpl.cpp:

(WTF::stringImplContentEqual):
(WTF::equal):
(WTF::equalNonNull):
(WTF::equalIgnoringCase):
(WTF::equalIgnoringCaseNonNull):
(WTF::equalIgnoringNullity):

wtf/text/StringImpl.h:

(WTF::equalIgnoringCase):

6:19 PM Changeset in webkit [146701] by aestes@apple.com

2 edits in trunk/Source/WebCore

Set the cache partition property on CFURLRequests
https://bugs.webkit.org/show_bug.cgi?id=113116

Patch by Jeffrey Pfau
Reviewed by David Kilzer.

platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):

6:17 PM Changeset in webkit [146700] by schenney@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

Adding bug numbers for two failing tests.

platform/chromium/TestExpectations:

6:10 PM Changeset in webkit [146699] by schenney@chromium.org

81 edits
6 adds
5 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The rest.

platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-linux/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-linux/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-linux/fast/box-shadow/inset-expected.png:
platform/chromium-linux/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac-lion/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac-lion/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
platform/chromium-mac-lion/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
platform/chromium-mac-lion/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/chromium-mac-lion/fast/borders/border-antialiasing-expected.png:
platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac-snowleopard/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
platform/chromium-mac-snowleopard/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-00-a-ag-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-02-d-agi-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png:
platform/chromium-mac/css2.1/t100801-c544-valgn-04-d-agi-expected.png:
platform/chromium-mac/editing/selection/select-text-overflow-ellipsis-expected.png:
platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png:
platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-mac/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-mac/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-mac/fast/box-shadow/inset-expected.png:
platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
platform/chromium-win/fast/borders/border-radius-with-box-shadow-01-expected.png:
platform/chromium-win/fast/borders/border-radius-with-box-shadow-expected.png:
platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
platform/chromium-win/fast/box-shadow/inset-expected.png:
platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
platform/chromium/TestExpectations:
platform/efl-wk2/fast/borders/border-radius-split-inline-expected.png: Added.
platform/efl-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
platform/efl-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
platform/efl-wk2/fast/box-shadow/inset-expected.png: Added.
platform/efl-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
platform/efl/fast/borders/border-radius-split-inline-expected.png: Removed.
platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
platform/efl/fast/box-shadow/inset-expected.png: Removed.
platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.

6:09 PM Changeset in webkit [146698] by rniwa@webkit.org

3 edits in trunk/Source/JavaScriptCore

Another build fix (after r146693) for r146682.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

6:07 PM Changeset in webkit [146697] by jchaffraix@webkit.org

4 edits
4 adds in trunk

[CSS Grid Layout] content-sized row tracks with percentage logical height grid items don't resolve properly
https://bugs.webkit.org/show_bug.cgi?id=113085

Reviewed by Tony Chang.

Source/WebCore:

The core issue is that because overrideContainingBlockLogicalHeight() is unset in
logicalContentHeightForChild, RenderBox::computePercentageLogicalHeight would try to
resolve percentage logical height against the grid element (wrong containing block
as a grid item's containing block is the grid area).

Tests: fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html

fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::logicalContentHeightForChild):
Set our override logical height to -1, so that we don't try to constrain a grid item's logical height
based on resolving (badly) its percentage.

LayoutTests:

fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt:

Updated the result to pass.

fast/css-grid-layout/grid-item-multiple-minmax-content-resolution-expected.txt: Added.
fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html: Added.
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt: Added.
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html: Added.

Added more testing to ensure that we properly do the resolution.

6:03 PM Changeset in webkit [146696] by schenney@chromium.org

65 edits
2 adds
1 delete in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/canvas/...
fast/css/...
fast/forms/...
fast/multicol/...

platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-linux/fast/css/font-family-pictograph-expected.png:
platform/chromium-linux/fast/css/font-family-pictograph-expected.txt:
platform/chromium-linux/fast/css/shadow-multiple-expected.png:
platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac-lion/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
platform/chromium-mac-lion/fast/dynamic/text-combine-expected.png:
platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac-lion/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac-lion/fast/multicol/nested-columns-expected.png:
platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac-snowleopard/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac-snowleopard/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/shadow-multiple-expected.png:
platform/chromium-mac/fast/dynamic/text-combine-expected.png:
platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
platform/chromium-mac/fast/line-grid/line-grid-contains-value-expected.png:
platform/chromium-mac/fast/multicol/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
platform/chromium-win/fast/css/shadow-multiple-expected.png:
platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
platform/chromium/TestExpectations:
platform/efl-wk2/fast/multicol: Added.
platform/efl-wk2/fast/multicol/shadow-breaking-expected.png: Added.
platform/efl/fast/multicol/shadow-breaking-expected.png: Removed.

5:52 PM Changeset in webkit [146695] by schenney@chromium.org

44 edits
9 adds
17 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/repaint/...
fast/ruby/...

fast/repaint/moving-shadow-on-container-expected.png: Added.
fast/repaint/search-field-cancel-expected.txt: Added.
platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac-lion/fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/search-field-cancel-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.png: Removed.
platform/chromium-mac-snowleopard/fast/ruby/base-shorter-than-text-expected.txt: Removed.
platform/chromium-mac-snowleopard/fast/ruby/position-after-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-mac/fast/repaint/scale-page-shrink-expected.png: Added.
platform/chromium-mac/fast/repaint/search-field-cancel-expected.png: Added.
platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
platform/chromium-mac/fast/ruby/position-after-expected.png:
platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Removed.
platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Removed.
platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
platform/chromium-win/fast/repaint/search-field-cancel-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/repaint/search-field-cancel-expected.png: Removed.
platform/chromium/fast/repaint/search-field-cancel-expected.txt: Removed.
platform/efl-wk2/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/efl-wk2/fast/repaint/moving-shadow-on-path-expected.png: Added.
platform/efl-wk2/fast/repaint/transform-replaced-shadows-expected.png: Added.
platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/efl/fast/repaint/moving-shadow-on-path-expected.png: Removed.
platform/efl/fast/repaint/transform-replaced-shadows-expected.png: Removed.
platform/gtk/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/mac/fast/repaint/moving-shadow-on-container-expected.png: Removed.
platform/mac/fast/repaint/search-field-cancel-expected.txt: Removed.

5:45 PM Changeset in webkit [146694] by zmo@google.com

7 edits in trunk/Source/WebCore

Check WEBGL_draw_buffers requirements before exposing the extension
https://bugs.webkit.org/show_bug.cgi?id=112359

Reviewed by Kenneth Russell.

html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported): call satisfies*().
(WebCore::EXTDrawBuffers::drawBuffersEXT):
(WebCore):
(WebCore::EXTDrawBuffers::satisfiesWebGLRequirements): check WebGL requirements.

html/canvas/EXTDrawBuffers.h:

(EXTDrawBuffers):

html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::getDrawBuffer):
(WebCore):

html/canvas/WebGLFramebuffer.h:

(WebGLFramebuffer):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::getMaxDrawBuffers):
(WebCore::WebGLRenderingContext::getMaxColorAttachments):
(WebCore::WebGLRenderingContext::setBackDrawBuffer):
(WebCore::WebGLRenderingContext::restoreCurrentFramebuffer):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
(WebCore::WebGLRenderingContext::supportsDrawBuffers): a cached version of EXTDrawBuffers::supports()

html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

5:44 PM Changeset in webkit [146693] by roger_fong@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed. AppleWin build fix.

JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
JavaScriptCore.vcxproj/copy-files.cmd:

5:37 PM Changeset in webkit [146692] by schenney@chromium.org

41 edits
6 adds
3 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

fast/text/...

platform/chromium-linux/fast/text/emphasis-avoid-ruby-expected.png: Added.
platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-linux/fast/text/stroking-decorations-expected.png:
platform/chromium-linux/fast/text/stroking-expected.png:
platform/chromium-linux/fast/transforms/shadows-expected.png:
platform/chromium-mac-lion/fast/text/decorations-with-text-combine-expected.png:
platform/chromium-mac-lion/fast/text/international/bold-bengali-expected.png:
platform/chromium-mac-lion/fast/text/international/text-spliced-font-expected.png:
platform/chromium-mac-lion/fast/text/international/vertical-text-glyph-test-expected.png:
platform/chromium-mac-lion/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac-lion/fast/text/orientation-sideways-expected.png:
platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
platform/chromium-mac-lion/fast/text/stroking-expected.png:
platform/chromium-mac-lion/fast/text/whitespace/024-expected.png:
platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-001-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-002-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bidi-linebreak-003-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/bold-bengali-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/text-spliced-font-expected.png:
platform/chromium-mac-snowleopard/fast/text/international/vertical-text-glyph-test-expected.png:
platform/chromium-mac-snowleopard/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac-snowleopard/fast/text/whitespace/024-expected.png:
platform/chromium-mac/fast/text/decorations-with-text-combine-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-mac/fast/text/stroking-decorations-expected.png:
platform/chromium-mac/fast/text/stroking-expected.png:
platform/chromium-mac/fast/text/whitespace/024-expected.png:
platform/chromium-mac/fast/transforms/shadows-expected.png:
platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
platform/chromium-win-xp/fast/text/stroking-expected.png:
platform/chromium-win/fast/text/international/bold-bengali-expected.png:
platform/chromium-win/fast/text/international/bold-bengali-expected.txt:
platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
platform/chromium-win/fast/text/stroking-decorations-expected.png:
platform/chromium-win/fast/text/stroking-expected.png:
platform/chromium-win/fast/transforms/shadows-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/text/international/bold-bengali-expected.png: Removed.
platform/efl-wk2/fast/text/shadow-translucent-fill-expected.png: Added.
platform/efl/fast/text/shadow-translucent-fill-expected.png: Removed.
platform/qt-unknown/fast: Added.
platform/qt-unknown/fast/text: Added.
platform/qt-unknown/fast/text/international: Added.
platform/qt-unknown/fast/text/international/text-spliced-font-expected.png: Added.
platform/qt/fast/text/international/text-spliced-font-expected.png: Removed.

5:31 PM Changeset in webkit [146691] by rniwa@webkit.org

6 edits in trunk/Tools

EWS should use a human readable port name when uploading layout test archives
https://bugs.webkit.org/show_bug.cgi?id=113099

Reviewed by Dirk Pranke.

Use new port's object's name() method to report human readable port names.
This will also help us resolving the bug to apply layout test results posted by EWS.

Scripts/webkitpy/tool/bot/botinfo.py:

(BotInfo.init): Take port's name.
(BotInfo.summary_text):

Scripts/webkitpy/tool/bot/botinfo_unittest.py:

(BotInfoTest.test_summary_text):

Scripts/webkitpy/tool/bot/flakytestreporter.py:

(FlakyTestReporter.init): Preserve the old behavior since we don't have a real port object here.

Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue.init): Initialize self._port.
(PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
and use that for the attachment filename and the comment posted.

Scripts/webkitpy/tool/commands/queues_unittest.py:

(PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
"mac-snowleopard" as expected for TestPort.

5:26 PM Changeset in webkit [146690] by schenney@chromium.org

4 edits in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

One I missed.

platform/chromium-mac-lion/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/chromium-mac-snowleopard/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:

5:24 PM Changeset in webkit [146689] by roger_fong@apple.com

2 edits in trunk/Tools

Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:21 PM Changeset in webkit [146688] by mhahnenberg@apple.com

2 edits in trunk/Source/JavaScriptCore

-[TinyDOMNode dealloc] should call [super dealloc] when ARC is not enabled
https://bugs.webkit.org/show_bug.cgi?id=113054

Reviewed by Geoffrey Garen.

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]):

5:14 PM Changeset in webkit [146687] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Fix AppleWin port following https://bugs.webkit.org/show_bug.cgi?id=113100.
Patch by Alexey Proskuryakov.

platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):

5:10 PM Changeset in webkit [146686] by kov@webkit.org

2 edits in trunk/Source/WebKit/gtk

Trivial fixes to the gyp-build autogen.sh script.

Reviewed by Martin Robinson (mrobinson).

gyp/autogen.sh: add /bin/sh -e as hashbang, so stricter shells will be happy to

run the script; deal with automake exiting with an error code because there is no
Makefile.am for it to work on.

5:00 PM Changeset in webkit [146685] by timothy_horton@apple.com

1 edit
2 adds in trunk/LayoutTests

Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

Add a test for http://trac.webkit.org/changeset/146679.

platform/mac-wk2/plugins/snapshotting/autoplay-dominant-expected.txt: Added.
plugins/snapshotting/autoplay-dominant.html: Added.

4:58 PM Changeset in webkit [146684] by tony@chromium.org

3 edits
2 adds in trunk

REGRESSION (r146272): layout issues for flex boxes that have -webkit-flex-wrap: wrap
https://bugs.webkit.org/show_bug.cgi?id=113071

Reviewed by Ojan Vafai.

Source/WebCore:

The refactor in r139535 introduced this bug, where a variable name wasn't updated properly.
In combination with r146272, this bug became more visible when nesting multiline flexboxen.

Test: css3/flexbox/multiline-min-preferred-width.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths): We want the width of the widest
flexitem, the value in m_minPreferredWidth isn't relevant. Also update the comment for max
preferred width.

LayoutTests:

css3/flexbox/multiline-min-preferred-width-expected.txt: Added.
css3/flexbox/multiline-min-preferred-width.html: Added.

4:56 PM Changeset in webkit [146683] by mvujovic@adobe.com

3 edits
4 adds in trunk

[CSS Shaders] Clamp css_MixColor before the blending and compositing steps
https://bugs.webkit.org/show_bug.cgi?id=113088

Reviewed by Dean Jackson.

Source/WebCore:

The blending and compositing operations from the spec [1] expect that they are operating on
valid color inputs, in the range [0.0, 1.0]. Thus, we should clamp the css_MixColor input to
this range to avoid implementation-dependent behavior for invalid color inputs.

[1]: https://dvcs.w3.org/hg/FXTF/rawfile/tip/compositing/index.html#blending

Tests: css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html

css3/filters/custom/custom-filter-clamp-css-mix-color.html

platform/graphics/filters/CustomFilterValidatedProgram.cpp:

(WebCore::CustomFilterValidatedProgram::rewriteMixFragmentShader):

Clamp css_MixColor as clampedMixColor before using it in the blending and compositing
steps.

LayoutTests:

css3/filters/custom/custom-filter-clamp-css-mix-color-expected.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color-negative-expected.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color-negative.html: Added.
css3/filters/custom/custom-filter-clamp-css-mix-color.html: Added.

4:49 PM Changeset in webkit [146682] by mhahnenberg@apple.com

10 edits in trunk/Source/JavaScriptCore

opaqueJSClassData should be cached on JSGlobalObject, not the JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=113086

Reviewed by Geoffrey Garen.

opaqueJSClassData stores cached prototypes for JSClassRefs in the C API. It doesn't make sense to
share these prototypes within a JSGlobalData across JSGlobalObjects, and in fact doing so will cause
a leak of the original JSGlobalObject that these prototypes were created in. Therefore we should move
this cache to JSGlobalObject where it belongs and where it won't cause memory leaks.

API/JSBase.cpp: Needed to add an extern "C" so that testapi.c can use the super secret GC function.
API/JSClassRef.cpp: We now grab the cached context data from the global object rather than the global data.

(OpaqueJSClass::contextData):

API/JSClassRef.h: Remove this header because it's unnecessary and causes circular dependencies.
API/tests/testapi.c: Added a new test that makes sure that using the same JSClassRef in two different contexts

doesn't cause leaks of the original global object.
(leakFinalize):
(nestedAllocateObject): This is a hack to bypass the conservative scan of the GC, which was unnecessarily marking
objects and keeping them alive, ruining the test result.
(testLeakingPrototypesAcrossContexts):
(main):

API/tests/testapi.mm: extern "C" this so we can continue using it here.
runtime/JSGlobalData.cpp: Remove JSClassRef related stuff.

(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSGlobalObject.h: Add the stuff that JSGlobalData had. We add it to JSGlobalObjectRareData so that

clients who don't use the C API don't have to pay the memory cost of this extra HashMap.
(JSGlobalObject):
(JSGlobalObjectRareData):
(JSC::JSGlobalObject::opaqueJSClassData):

4:48 PM Changeset in webkit [146681] by Martin Robinson

2 edits in trunk/Source/WebCore

[GTK] Add WebCoreDOM to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112737

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add WebCoreDOM to the gyp build.

4:47 PM Changeset in webkit [146680] by Martin Robinson

3 edits in trunk/Source

[GTK] Add WebCoreHTML to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112727

Reviewed by Nico Weber.

WebCore.gyp/WebCoreGTK.gyp: Add support for building all files under

the HTML directory. This includes splitting off common WebCore dependencies
into an aggregate target and adding a top-level WebCore target.

4:43 PM Changeset in webkit [146679] by timothy_horton@apple.com

8 edits in trunk/Source

Plugin Snapshotting: Auto-start dominant plugins
https://bugs.webkit.org/show_bug.cgi?id=113111
<rdar://problem/13475726>

Reviewed by Dean Jackson.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
Acknowledge the new "Restarting" DisplayState.

html/HTMLPlugInElement.h:

Rename PlayingWithPendingMouseClick to RestartingWithPendingMouseClick for accuracy.
Add "Restarting" DisplayState, so we can be aware that the plugin is intentionally restarting and not re-snapshot it.

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::classNameForShadowRoot): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Restart the plugin when it becomes primary.
(WebCore::HTMLPlugInImageElement::updateSnapshotInfo): Remove m_isPrimarySnapshottedPlugIn.
(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn):
Move the plugin to Restarting unless it's already marked as PendingMouseClick.
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired): Match the PlayingWithPendingMouseClick rename.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Don't snapshot if we're restarting.

html/HTMLPlugInImageElement.h: Remove m_isPrimarySnapshottedPlugIn.
rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paint): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::getCursor): Acknowledge the new "Restarting" DisplayState.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Match the PlayingWithPendingMouseClick rename.

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin):
(WebKit::PluginView::paint):
(WebKit::PluginView::invalidateRect):
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Acknowledge the new "Restarting" DisplayState.

4:43 PM Changeset in webkit [146678] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Mark test as expected to timeout.
https://bugs.webkit.org/show_bug.cgi?id=113114

Unreviewed, test expectations update.

platform/chromium/TestExpectations:

4:40 PM Changeset in webkit [146677] by Martin Robinson

8 edits
2 copies in trunk/Source

[GTK] Add support for building the WebCore bindings to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=112638

Reviewed by Nico Weber.

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Export all include directories to direct

dependents and fix the indentation of the libjavascriptcore target.

Source/WebCore:

Add targets, actions, and rules for building the WebCore bindings. This is
the first part of the WebCoreGTK build.

WebCore.gyp/ConvertFileToHeaderWithCharacterArray.gypi: Added.
WebCore.gyp/MakeNames.gypi: Added.
WebCore.gyp/WebCoreGTK.gyp: Added WebCore bindings build. This has been adapted

from the Chromium build.

WebCore.gypi: Updated list of derived sources files and added a parameter

for adjusting the location of the built files. We don't want to force the
Mac build to change, but we'd still like to reuse the scripts that the
Chromium build uses.

Source/WebKit/gtk:

gyp/Configuration.gypi.in: Added options for enabling SVG and setting the location of

the WebCore derived sources.

gyp/run-gyp: Include the gyp scripts directory on the Python path and make the WebCoreGTK

gyp file the default for the build.

4:29 PM Changeset in webkit [146676] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Expose a few more compiler defines for the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113109

Reviewed by Gustavo Noronha Silva.

gyp/Configuration.gypi.in: Expose the version number string and data

directory to the gyp build as command-line arguments.

4:28 PM Changeset in webkit [146675] by Martin Robinson

2 edits in trunk/Source/WebKit/gtk

[GTK] [gyp] Feature defines are not space separated
https://bugs.webkit.org/show_bug.cgi?id=113108

Reviewed by Gustavo Noronha Silva.

gyp/configure.ac: Properly export feature defines for gyp during

configure phase.

4:23 PM Changeset in webkit [146674] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Build fix in InputHandler
https://bugs.webkit.org/show_bug.cgi?id=113092

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):

4:12 PM Changeset in webkit [146673] by jer.noble@apple.com

2 edits in trunk/Source/WebKit2

After switching to another space and back, video races to catch up with audio
https://bugs.webkit.org/show_bug.cgi?id=113006

Reviewed by Anders Carlsson.

Add an observer for the NSWorkspaceActiveSpaceDidChangeNotification notification, and trigger
a visibility update when that notification is observed.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]): Unregister the observer.
(-[WKView _activeSpaceDidChange:]): Notify the view that its visibility may have changed.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): Add the observer.

4:11 PM Changeset in webkit [146672] by commit-queue@webkit.org

11 edits in trunk/Source

Add client callbacks to notify of changes of associated from controls
https://bugs.webkit.org/show_bug.cgi?id=110375

Patch by Dane Wallinga <dgwallinga@chromium.org> on 2013-03-22
Reviewed by Ryosuke Niwa.

Source/WebCore:

Hook FormAssociatedElement, HTMLFormElement to notify EditorClient of form changes after a page has loaded.
Will be used to add autofill support for ajax-y webpages. e.g if while filling out a form, new fields
are dynamically created, autofill can know to re-query the autofill server and keep going.
https://bugs.webkit.org/show_bug.cgi?id=110375

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didAssociateFormControl):
(WebCore):
(WebCore::Document::didAssociateFormControlsTimerFired):

dom/Document.h:

(Document):
added method didAssociateFormControl, which batches form changes
and calls out to ChromeClient on a timer.

html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::resetFormOwner):
(WebCore::FormAssociatedElement::formAttributeChanged):
(WebCore):

html/FormAssociatedElement.h:

(FormAssociatedElement):
add calls to Document::didAssociateFormControl when form changes

html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::insertedInto):
(WebCore):

html/HTMLFormElement.h:

add call to Document::didAssociateFormControl

loader/EmptyClients.h:

(EmptyChromeClient):
(WebCore::EmptyChromeClient::didAssociateFormControls):
(WebCore::EmptyChromeClient::shouldNotifyOnFormChanges):

page/ChromeClient.h:

(ChromeClient):
add new method didAssociateFormControls

Source/WebKit/chromium:

Implement form association methods of ChromeClient
to inform autofill of form changes after a page has loaded

public/WebAutofillClient.h:

(WebAutofillClient):
(WebKit::WebAutofillClient::didAssociateInput):
(WebKit::WebAutofillClient::didAddForm):
(WebKit::WebAutofillClient::didAssociateFormControls):

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::didAssociateFormControls):
(WebKit):
(WebKit::ChromeClientImpl::shouldNotifyOnFormChanges):

src/ChromeClientImpl.h:

(ChromeClientImpl):

4:04 PM Changeset in webkit [146671] by zmo@google.com

3 edits in branches/chromium/1410/Source/WebCore

Merge 145856 "Check to ensure MultisampleRenderbuffer creation s..."

Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12843018

4:02 PM Changeset in webkit [146670] by schenney@chromium.org

139 edits
14 adds
11 deletes in trunk/LayoutTests

[Chromium] Test expectations after Skia changes

Unreviewed expectations update.

The next round.

Too many files to list, plus ...

platform/chromium/TestExpectations:

4:00 PM Changeset in webkit [146669] by fpizlo@apple.com

11 edits in trunk/Source/JavaScriptCore

Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.

2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).

3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.

4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.

5) Treat all exits that were counted as being frequent.

81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):

bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExit.h:

(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):
(OSRExit):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Options.h:

(JSC):

3:49 PM Changeset in webkit [146668] by benjamin@webkit.org

2 edits in trunk/Source/WTF

Name correctly the argument of StringImpl::setIsAtomic()
https://bugs.webkit.org/show_bug.cgi?id=113000

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-22
Reviewed by Geoffrey Garen.

wtf/text/StringImpl.h:

(WTF::StringImpl::setIsAtomic):
The argument was probably an unfortunate copy-paste from setIsIdentifier().
Fix the name.

3:44 PM Changeset in webkit [146667] by ap@apple.com

7 edits
5 adds in trunk/Source/WebCore

Split ResourceHandleMac into multiple files
https://bugs.webkit.org/show_bug.cgi?id=113100

Reviewed by Geoff Garen.

It's grown too big to navigate, and I'm going to make WebCoreResourceHandleAsDelegate
substantially more complicated yet.

Mechanically moved WebCoreResourceHandleAsDelegate into separate files.
Refactored WebCoreSynchronousLoaderClient to be cross-platform, and moved it into separate files.

WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/SynchronousLoaderClient.cpp: Added.
platform/network/SynchronousLoaderClient.h: Added.
platform/network/cf/ResourceHandleCFNet.cpp:
platform/network/mac/SynchronousLoaderClient.mm: Added.
platform/network/mac/WebCoreResourceHandleAsDelegate.h: Added.
platform/network/mac/WebCoreResourceHandleAsDelegate.mm: Added.

3:38 PM Changeset in webkit [146666] by schenney@chromium.org

491 edits
17 adds
13 deletes in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

SVG and Compositing tests

Too many files to list, plus ...

platform/chromium/TestExpectations:

3:24 PM Changeset in webkit [146665] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Fix the expected image result as r78910 committed a bad expected result.
See http://trac.webkit.org/changeset/78910/trunk/LayoutTests/platform/mac/editing/deleting/deletionUI-single-instance-expected.png

platform/mac/editing/deleting/deletionUI-single-instance-expected.png:

3:19 PM Changeset in webkit [146664] by ggaren@apple.com

10 edits in trunk/Source

Added a setting for whether JavaScript markup is enabled
https://bugs.webkit.org/show_bug.cgi?id=112999

Reviewed by Maciej Stachowiak.

This setting is useful for clients that want protection from script
injection attacks.

../WebCore:

page/Settings.h:

(Settings): Clarified which clients should call canExecuteScripts().

page/Settings.in: Added the new setting.

../WebKit2:

Shared/WebPreferencesStore.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetJavaScriptMarkupEnabled):
(WKPreferencesSetJavaScriptMarkupEnabled):
(WKPreferencesGetJavaScriptEnabled):

UIProcess/API/C/WKPreferences.h:
UIProcess/API/mac/WKBrowsingContextGroup.mm:

(-[WKBrowsingContextGroup allowsJavaScriptMarkup]):
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Plumbed through to API.

3:19 PM Changeset in webkit [146663] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a failing test expectation to media/track/track-prefer-captions.html on Windows after r146647.
The failure is tracked by the bug 113106.

platform/win/TestExpectations:

3:06 PM Changeset in webkit [146662] by rniwa@webkit.org

2 edits in trunk/LayoutTests

[Win] editing/pasteboard/can-read-in-copy-and-cut-events.html fails
https://bugs.webkit.org/show_bug.cgi?id=113102

Skip a test added by r146644 since writing into clipboard is not supported on Windows port.

platform/win/TestExpectations:

3:04 PM Changeset in webkit [146661] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

3:03 PM Changeset in webkit [146660] by pdr@google.com

2 edits
8 adds in trunk/LayoutTests

Update svg/custom/marker-orient-auto expectations

Unreviewed update of test expectations.

platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac-lion/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac-snowleopard/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-mac/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-mac/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium-win/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-win/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium/TestExpectations:

2:14 PM Changeset in webkit [146659] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add failing test expectations for two more position: sticky tests to make Mac EWS happy.

platform/mac/TestExpectations:

2:12 PM Changeset in webkit [146658] by eric.carlson@apple.com

3 edits in branches/safari-536.30-branch/LayoutTests

Update results where white-space changed because of the change from testRunner" to "layoutTestController.

fast/block/float/float-not-removed-from-pre-block-expected.txt:
fast/css/image-set-value-not-removed-crash-expected.txt:

2:05 PM Changeset in webkit [146657] by rniwa@webkit.org

9 edits in trunk

NRWT: Enable pixel tests when retrying tests
https://bugs.webkit.org/show_bug.cgi?id=112898

Reviewed by Dirk Pranke.

Tools:

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
if we've forced pixel tests in the retry.
(Manager._run_tests):
(Manager._clean_up_run): Fixed the capitalizations.
(Manager._force_pixel_tests_if_needed): Added.

Scripts/webkitpy/layout_tests/models/test_run_results.py:

(_interpret_test_failures): Now that this function maybe called multiple times, only set
'image_diff_percent' if it doesn't already exist.

(summarize_results): When the first attempt resulted in a text failure and the second attempt
resulted in image and text failures and we've forced to run pixel tests in the retry run,
treat this as a regular regression instead of a flakiness.

Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
run had image diffs.

Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:

(summarized_results):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
Also removed some dead code.

(RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
is set and pixel_tests_enabled is set to false.
(EndToEndTest.test_reftest_with_two_notrefs):

LayoutTests:

Link to images and image diff in retries when they're only available in retries.

fast/harness/resources/results-test.js: Added a test case.
fast/harness/results-expected.txt:
fast/harness/results.html:

(imageResultsCell): Extracted from tableRow.
(tableRow): Split the actual result into two tokens (first attempt and retry),
and then check if the image failure was detected in the first attempt. If not,
add hyperlinks to the actual results in the retry run.

2:00 PM Changeset in webkit [146656] by pdr@google.com

2 edits in trunk/LayoutTests

Update svg/custom/marker-orient-auto-expected test expectation.

Unreviewed update of test expectations.

platform/chromium/TestExpectations:

1:59 PM Changeset in webkit [146655] by schenney@chromium.org

4 edits in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

One more not-expected failure, fixed.

platform/chromium-mac-lion/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:

1:57 PM Changeset in webkit [146654] by schenney@chromium.org

3 edits
4 adds in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Some more currently failing (not expected) tests.

platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-expected.png:
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.

1:51 PM Changeset in webkit [146653] by fpizlo@apple.com

4 edits
3 adds in trunk

DFG folding of PutById to SimpleReplace should consider the specialized function case
https://bugs.webkit.org/show_bug.cgi?id=113093

Reviewed by Geoffrey Garen and Mark Hahnenberg.

Source/JavaScriptCore:

bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

LayoutTests:

fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function-expected.txt: Added.
fast/js/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-cfa-prove-put-by-id-simple-when-storing-to-specialized-function.js: Added.

(foo):
(baz):
(fuzz):

1:41 PM Changeset in webkit [146652] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add failing test expectations to the test added by r146644 on Mac.
The failure is tracked by http://webkit.org/b/113094.

platform/mac/TestExpectations:

1:36 PM Changeset in webkit [146651] by roger_fong@apple.com

2 edits in trunk/Source/WebCore

Unreviewed. Force kill gcc-3.exe during bindings generation tests to avoid process hangs.

This problem is occuring on the WinEWS bots where there are somehow multiple gcc-3 processes existing at the same time.
This is a speculative fix. There should only be 1 gcc-3.exe process running at a time ever.

bindings/scripts/preprocessor.pm:

(applyPreprocessor):

1:34 PM Changeset in webkit [146650] by timothy_horton@apple.com

5 edits in trunk/Tools

Make it possible to run layout tests on Retina MBP
https://bugs.webkit.org/show_bug.cgi?id=93673

Reviewed by Ryosuke Niwa.

Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
windows on 2x machines still run at 1x.

DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
Reset the window resolution to 1x on creation.

DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
(WTR::PlatformWebView::PlatformWebView):
Add NSWindow details, reset the window resolution to 1x on creation.

1:30 PM Changeset in webkit [146649] by eric.carlson@apple.com

6 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Change all instances of "testRunner" back to "layoutTestController" in svg files, which
my initial commit missed.

fast/css/font-size-nan.svg:
svg/custom/stale-resource-data-crash.svg:
svg/custom/use-href-update-crash.svg:
svg/custom/use-rebuild-resources-crash.svg:
svg/text/alt-glpyh-on-fallback-font-crash.svg:

1:28 PM Changeset in webkit [146648] by wangxianzhu@chromium.org

1 edit in branches/chromium/1410/Source/WebCore/rendering/RenderLayerCompositor.cpp

Merge 144642 "Don't apply page scale to clipRect if applyPageSca..."

Don't apply page scale to clipRect if applyPageScaleFactorInCompositor is set to true
https://bugs.webkit.org/show_bug.cgi?id=111229

Patch by Min Qin <qinmin@chromium.org> on 2013-03-04
Reviewed by Simon Fraser.

If applyPageScaleFactorInCompositor is set to true, webcore should use css coordinates.
As a result, we shouldn't apply page scale to clipRect in RenderLayerCompositor.
Layout tests set the flag to false, so we don't have anything to test against.

rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::addToOverlapMap):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12797016

1:24 PM Changeset in webkit [146647] by eric.carlson@apple.com

11 edits in trunk/Source/WebCore

Cleanup text track selection logic
https://bugs.webkit.org/show_bug.cgi?id=113062

Reviewed by Jer Noble.

No new tests, covered by existing tests.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Remove.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Don't look at track attributes directly,

use captionPreferences->textTrackSelectionScore to calculate track rank.

(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_processingPreferenceChange here

instead of in captionPreferencesChanged.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't suppress calls to setClosedCaptionsVisible,

existing code already makes sure we don't do unnecessary work.

html/HTMLMediaElement.h:

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Drive by cleanup, don't

process inactive cues.

html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): Call resetTrackListMenu instead

of updateDisplay so we only mark the menu as needing a recalculation and do the work when
it is displayed.

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::shouldShowCaptions): When in testing mode, return true if

the caption or subtitle preference has been set.

(WebCore::CaptionUserPreferences::setShouldShowCaptions): In testing mode, clear the caption

and subtitle preference when passed false.

(WebCore::CaptionUserPreferences::textTrackSelectionScore): Calculate the track score based on

track type preference and preferred language.

(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Score a track according to

the language presence and position in the preferred languages list.

page/CaptionUserPreferences.h:

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Calculate track language score

according to user preferences.

platform/Language.cpp:

(WebCore::indexOfBestMatchingLanguageInList): Repurposed the static bestMatchingLanguage

function to return the location of a language in a Vector.

(WebCore::preferredLanguageFromList): Removed.

platform/Language.h:

1:16 PM Changeset in webkit [146646] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Build fix for TransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=113087

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Martin Robinson.

This is a trivial build fix for clutter ac backend. Clutter AC backend doesn't use
TextureMapper so there is nowhere including TransformationMatrix.h.
For the reason, we include it explicitly.

No new tests because of no functionality change.

platform/graphics/clutter/GraphicsContext3DPrivate.cpp:
platform/graphics/clutter/GraphicsContext3DPrivate.h:

(WebCore):

1:14 PM Changeset in webkit [146645] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Coordinates.idl lacks Conditional=GEOLOCATION
https://bugs.webkit.org/show_bug.cgi?id=112949

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Steve Block.

No new tests, build optimization only.

page/Coordinates.idl: Added GEOLOCATION conditional guard.

1:04 PM Changeset in webkit [146644] by dcheng@chromium.org

12 edits
4 adds in trunk

Data store should be readable in dragstart/copy/cut events
https://bugs.webkit.org/show_bug.cgi?id=23695

Reviewed by Tony Chang.

Source/WebCore:

There were several events where data could be written but not read back due to the fact that
different Clipboard method implementations checked permissions inconsistently. This patch
adds helper methods to check if an operation is permitted on a Clipboard and refactors all
direct comparisons against Clipboard::m_policy to use the new helpers instead. This fixes
several bugs where Clipboard::types and Clipboard::getData are not usable inside the
aforementioned events.

Tests: editing/pasteboard/can-read-in-copy-and-cut-events.html

editing/pasteboard/can-read-in-dragstart-event.html

dom/Clipboard.cpp:

(WebCore::Clipboard::canReadTypes): Formerly restricted to ClipboardReadable and

ClipboardTypesReadable; now allows ClipboardWritable as
well.

(WebCore::Clipboard::canReadData): Formerly restricted to ClipboardReadable; now allows

ClipboardWritable as well.

(WebCore::Clipboard::canWriteData):
(WebCore::Clipboard::canSetDragImage):
(WebCore::Clipboard::hasFileOfType):
(WebCore::Clipboard::hasStringOfType):
(WebCore::Clipboard::setDropEffect):
(WebCore::Clipboard::setEffectAllowed):

dom/Clipboard.h:

(Clipboard):

platform/blackberry/ClipboardBlackBerry.cpp:

(WebCore::ClipboardBlackBerry::clearData):
(WebCore::ClipboardBlackBerry::clearAllData):
(WebCore::ClipboardBlackBerry::getData):
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::types):

platform/chromium/ClipboardChromium.cpp:

(WebCore::DataTransferItemPolicyWrapper::kind):
(WebCore::DataTransferItemPolicyWrapper::type):
(WebCore::DataTransferItemPolicyWrapper::getAsString):
(WebCore::DataTransferItemPolicyWrapper::getAsFile):
(WebCore::ClipboardChromium::clearData):
(WebCore::ClipboardChromium::clearAllData):
(WebCore::ClipboardChromium::getData):
(WebCore::ClipboardChromium::setData):
(WebCore::ClipboardChromium::types):
(WebCore::ClipboardChromium::files):
(WebCore::ClipboardChromium::setDragImage):

platform/gtk/ClipboardGtk.cpp:

(WebCore::ClipboardGtk::clearData):
(WebCore::ClipboardGtk::clearAllData):
(WebCore::ClipboardGtk::getData):
(WebCore::ClipboardGtk::setData):
(WebCore::ClipboardGtk::types):
(WebCore::ClipboardGtk::files):
(WebCore::ClipboardGtk::setDragImage):

platform/mac/ClipboardMac.mm:

(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::files):
(WebCore::ClipboardMac::setDragImage):

platform/qt/ClipboardQt.cpp:

(WebCore::ClipboardQt::clearData):
(WebCore::ClipboardQt::clearAllData):
(WebCore::ClipboardQt::getData):
(WebCore::ClipboardQt::setData):
(WebCore::ClipboardQt::types):
(WebCore::ClipboardQt::files):
(WebCore::ClipboardQt::setDragImage):
(WebCore::ClipboardQt::items):

platform/qt/DataTransferItemListQt.cpp:

(WebCore::DataTransferItemListQt::length):
(WebCore::DataTransferItemListQt::item):
(WebCore::DataTransferItemListQt::deleteItem):
(WebCore::DataTransferItemListQt::clear):
(WebCore::DataTransferItemListQt::add):

platform/qt/DataTransferItemQt.cpp:

(WebCore::DataTransferItemQt::getAsString):

platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::clearData):
(WebCore::ClipboardWin::clearAllData):
(WebCore::ClipboardWin::getData):
(WebCore::ClipboardWin::setData):
(WebCore::ClipboardWin::types):
(WebCore::ClipboardWin::files):
(WebCore::ClipboardWin::setDragImage):

LayoutTests:

editing/pasteboard/can-read-in-copy-and-cut-events-expected.txt: Added.
editing/pasteboard/can-read-in-copy-and-cut-events.html: Added.
editing/pasteboard/can-read-in-dragstart-event-expected.txt: Added.
editing/pasteboard/can-read-in-dragstart-event.html: Added.

1:00 PM Changeset in webkit [146643] by schenney@chromium.org

16 edits
1 add in trunk/LayoutTests

[Chromium] Test expectation after Skia changes

Unreviewed expectations update.

Only the things failing on the bots, not already accounted for.

platform/chromium-linux/fast/text/international/danda-space-expected.png:
platform/chromium-mac-lion/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac-lion/fast/ruby/base-shorter-than-text-expected.png:
platform/chromium-mac-lion/fast/text/emphasis-combined-text-expected.png:
platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium/TestExpectations:

12:44 PM Changeset in webkit [146642] by abucur@adobe.com

2 edits in trunk/Source/WebCore

[CSS Regions] Remove pushLayoutState(RenderFlowThread*) from RenderView
https://bugs.webkit.org/show_bug.cgi?id=113084

Reviewed by Dirk Schulze.

Remove void pushLayoutState(RenderFlowThread*, bool regionsChanged) from RenderView.h because it's not used.

Tests: Code cleanup. No tests needed.

rendering/RenderView.h:

(RenderView):

12:34 PM Changeset in webkit [146641] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

Check focused node reference when traversing through history
https://bugs.webkit.org/show_bug.cgi?id=113082

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-03-22
Reviewed by Rob Buis.

PR312101
Check if we have a valid node and document before attempting to access its frame and
frame selection. This is causing issues when going back to a page after a redirect
where a stale pointer is used.
Further, the focused node should be changed after the frame is fully loaded.

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::setElementUnfocused):
(BlackBerry::WebKit::InputHandler::restoreViewState):

12:23 PM Changeset in webkit [146640] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

[EFL] Fix build issues to enable CSS Filter and Shaders support.
https://bugs.webkit.org/show_bug.cgi?id=111274

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Noam Rosenthal.

This is in preperation to enable CSS Filter and Shaders support.
This patch fixes related build issues to enable the support.

platform/graphics/surfaces/efl/GLTransportSurface.cpp:
platform/graphics/texmap/TextureMapper.cpp:
platform/graphics/texmap/TextureMapper.h:

(WebCore):

platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/texmap/TextureMapperGL.h:

(WebCore):

platform/graphics/texmap/TextureMapperShaderProgram.h:

12:11 PM Changeset in webkit [146639] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Remove Android platform expectations from Chromium TestExpectations.
(Too many bug URLs to list)

Unreivewed, test expectations update.

platform/chromium/TestExpectations:

12:01 PM Changeset in webkit [146638] by falken@chromium.org

4 edits in trunk/Source/WebCore

Implement isEnabledFormControl() for SliderThumbElement and SpinButtonElement in terms of disabled()
https://bugs.webkit.org/show_bug.cgi?id=112993

Reviewed by Kent Tamura.

This is an intermediate step for refactoring Node::disabled and
Element::isEnabledFormControl. All classes that override
isEnabledFormControl just return !disabled(), except for
SliderThumbElement and SpinButtonElement. This patch changes those two
classes to do so, which shows that the two functions are redundant and
easy to refactor into a single function in a subsequent patch.

No new tests, there should be no behavior change.

html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::disabled):
(WebCore):
(WebCore::SliderThumbElement::isEnabledFormControl):

html/shadow/SliderThumbElement.h:

(SliderThumbElement):

html/shadow/SpinButtonElement.h: The check of shadowHost() is

necessary because it can be detached by JavaScript that runs during
event handling (see r76566)

11:47 AM Changeset in webkit [146637] by mario@webkit.org

4 edits in trunk/Source

[GTK] Include the right GL header for GLES2
https://bugs.webkit.org/show_bug.cgi?id=113034

Reviewed by Martin Robinson.

Include GLES2/gl2.h when using GLES2.

Source/WebKit/gtk:

WebCoreSupport/AcceleratedCompositingContextGL.cpp:

Source/WebKit2:

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

11:38 AM Changeset in webkit [146636] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Add the newline at end of the test results, apparently lost when merging r131709.

fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style-expected.txt:

11:30 AM Changeset in webkit [146635] by pdr@google.com

3 edits
2 copies in branches/chromium/1410

Merge 146227 "Separate SVG image size and container size"

Separate SVG image size and container size
https://bugs.webkit.org/show_bug.cgi?id=112651

Reviewed by Stephen Chenney.

Source/WebCore:

Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.

This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.

Test: svg/as-image/svg-container-size-after-reload.html

svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):

svg/graphics/SVGImage.h:

The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: http://www.w3.org/TR/css3-images/#default-sizing

svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):

In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.

LayoutTests:

svg/as-image/svg-container-size-after-reload-expected.txt: Added.
svg/as-image/svg-container-size-after-reload.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/13008026

11:28 AM Changeset in webkit [146634] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Hit Test doesn't need to be active
https://bugs.webkit.org/show_bug.cgi?id=113072

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-22
Reviewed by Rob Buis.

Reviewed Internally By Mike Lattanzio.
PR #306074

WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

11:27 AM Changeset in webkit [146633] by alecflett@chromium.org

6 edits
2 adds in trunk/Source/WebKit/chromium

[chromium] Support Quota API in Worker
https://bugs.webkit.org/show_bug.cgi?id=112713

Hook up WebKit side of queryUsageAndQuota. Tests
and WebCore code will come in https://bugs.webkit.org/show_bug.cgi?id=112972

Reviewed by David Levin.

WebKit.gyp:
public/WebCommonWorkerClient.h:

(WebKit::WebCommonWorkerClient::queryUsageAndQuota):

src/StorageQuotaChromium.cpp:

(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::queryUsageAndQuota):
(WebKit):

src/WebWorkerClientImpl.h:
src/WorkerStorageQuotaCallbacksBridge.cpp: Added.

(WebKit):
(MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::createLeakedPtr):
(WebKit::MainThreadStorageQuotaCallbacks::~MainThreadStorageQuotaCallbacks):
(WebKit::MainThreadStorageQuotaCallbacks::didQueryStorageUsageAndQuota):
(WebKit::MainThreadStorageQuotaCallbacks::didFail):
(WebKit::MainThreadStorageQuotaCallbacks::didGrantStorageQuota):
(WebKit::MainThreadStorageQuotaCallbacks::MainThreadStorageQuotaCallbacks):
(WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaContextObserver::create):
(WebKit::WorkerStorageQuotaContextObserver::notifyStop):
(WebKit::WorkerStorageQuotaContextObserver::WorkerStorageQuotaContextObserver):
(WebKit::WorkerStorageQuotaCallbacksBridge::stop):
(WebKit::WorkerStorageQuotaCallbacksBridge::cleanUpAfterCallback):
(WebKit::WorkerStorageQuotaCallbacksBridge::WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::~WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::postQueryUsageAndQuotaToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::queryUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didFailOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::didQueryStorageUsageAndQuotaOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::runTaskOnWorkerThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::dispatchTaskToMainThread):
(WebKit::WorkerStorageQuotaCallbacksBridge::mayPostTaskToWorker):

src/WorkerStorageQuotaCallbacksBridge.h: Added.

(WebCore):
(WebKit):
(WorkerStorageQuotaCallbacksBridge):
(WebKit::WorkerStorageQuotaCallbacksBridge::create):

11:13 AM Changeset in webkit [146632] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a failure test expectation to media/track/track-user-preferences.html after r146380.
The failure is tracked by the webkit.org/b/113083.

platform/mac/TestExpectations:

11:08 AM Changeset in webkit [146631] by eric.carlson@apple.com

2 edits in branches/safari-536.30-branch/LayoutTests

Merge r135523 to get the updated test results.

2012-11-22 Daniel Bates <dbates@webkit.org>

JavaScript fails to concatenate large strings
<https://bugs.webkit.org/show_bug.cgi?id=102963>

Update test result.

fast/js/concat-large-strings-crash-expected.txt:

10:51 AM Changeset in webkit [146630] by allan.jensen@digia.com

5 edits in trunk

[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt.
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Qt adds word-spacing to leading spaces, but WebCore only expects
us to add for trailing spaces. We only corrected for this in width
calculation but do need to also do it for drawing.

Instead of subtracting the extra word-spacing we now configure the
FormatRange not to apply to leading spaces. This means this behavior
will be applied everywhere reliably.

platform/graphics/Font.h:

(Font):

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::initFormatForTextLayout):

LayoutTests:

platform/qt/TestExpectations:

10:41 AM Changeset in webkit [146629] by jsbell@chromium.org

2 edits in trunk/Source/WebCore

REGRESSION (r146540?): Crashes in storage/indexeddb/factory-basics-workers.html, storage/indexeddb/transaction-error.html
https://bugs.webkit.org/show_bug.cgi?id=113019

Reviewed by Tony Chang.

Also manifesting flakily under Chromium's content_shell. It's an ASSERT being hit in
the IDBTransaction destructor. The cause was r146540 which allows a stopped context
to reclaim script wrappers. This allows the IDBTransaction to be deref'd at times where
it previously would have just leaked. Modulate the destructor assertions to account
for this case.

No new tests; failures already manifest as flaky crashes in some ports.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::~IDBTransaction): If context is stopped, expected state
transitions/cleanup may not have occurred before destructor runs.

10:34 AM Changeset in webkit [146628] by dgrogan@chromium.org

4 edits in trunk/Source

IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Tony Chang.

Source/Platform:

chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

ChromeOS suspects they might be hitting disk corruption when the disks
are nearly full. This patch logs the available space to either the
"success" or the "fail" histogram as appropriate so that the
distributions can be compared.

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

10:11 AM Changeset in webkit [146627] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay clipped incorrectly
https://bugs.webkit.org/show_bug.cgi?id=113069

Patch by Andrew Lo <anlo@rim.com> on 2013-03-22
Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson.

As a follow-up to r146278, the clip rect also needs to be
adjusted by the parent's offset when drawing the
selection overlay.

WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

10:05 AM Changeset in webkit [146626] by Nate Chapin

5 edits
3 adds in trunk

REGRESSION (r146239): Reproducible crash in WebCore::DocumentLoader::responseReceived.
https://bugs.webkit.org/show_bug.cgi?id=112811

Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/cache/x-frame-options-304.html

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::switchClientsToRevalidatedResource):

loader/cache/CachedRawResource.h:

LayoutTests:

http/tests/cache/resources/x-frame-options.php: Added.
http/tests/cache/x-frame-options-304-expected.txt: Added.
http/tests/cache/x-frame-options-304.html: Added.

10:03 AM Changeset in webkit [146625] by rniwa@webkit.org

3 edits in trunk/Tools

Leak bots shouldn't build
https://bugs.webkit.org/show_bug.cgi?id=112774

Reviewed by Simon Fraser.

Since leak bots use regular debug builds, there is no need to build on these bots.
Simply downloading builds will dramatically improve the cycle time of these bots.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
TestFactory instead of BuildAndTestFactory.

9:58 AM Changeset in webkit [146624] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add flaky crash expectations on some media tests per bugs 113075 and 113076.

platform/win/TestExpectations:

9:41 AM Changeset in webkit [146623] by wangxianzhu@chromium.org

10 edits
3 copies in branches/chromium/1410

Merge 146129 "Variant of non-primary fell-back SVGFont causes cr..."

Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367

Reviewed by Stephen Chenney.

Source/WebCore:

Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.

Test: svg/css/font-face-variant-crash.html

platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):

platform/graphics/SimpleFontData.h:
(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.

BTW, Removed unreferenced commonInit.

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/skia/SimpleFontDataSkia.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wince/SimpleFontDataWinCE.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wx/SimpleFontDataWx.cpp:
(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

LayoutTests:

resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
svg/css/font-face-variant-crash-expected.txt: Added.
svg/css/font-face-variant-crash.html: Added.

TBR=wangxianzhu@chromium.org

9:24 AM Changeset in webkit [146622] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Eric Carlson.

Work around the ASSERTs generated when setting an AVPlayerLayer's player property
during a CA flush by setting the player property during the next runloop, outside
of a CA flush.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:22 AM Changeset in webkit [146621] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[Curl] Performance fix, avoid loading cookie file on every request.
https://bugs.webkit.org/show_bug.cgi?id=113023

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-22
Reviewed by Brent Fulgham.

We currently load the cookie file on every request, and when setting cookies from JavaScript, by using the option CURLOPT_COOKIEFILE.
This is very inefficient as the cookie file can get quite large, and file I/O is slow.
It is sufficient to load the cookie file on startup, as we use a shared cookie database between the requests.

platform/network/curl/CookieJarCurl.cpp:

(WebCore::setCookiesFromDOM): Avoid loading cookie file when setting cookies from JavaScript.

platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle): Avoid loading cookie file on every request.
(WebCore::ResourceHandleManager::initCookieSession): Load the cookie file to shared database on startup.

9:08 AM Changeset in webkit [146620] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Update Input field Background Color
https://bugs.webkit.org/show_bug.cgi?id=113063

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-03-22
Reviewed by George Staikos.

RIM PR 307463.
Internally reviewed by Ed Baker.

platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintTextFieldOrTextAreaOrSearchField):

8:56 AM Changeset in webkit [146619] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: FlameChart. Draw function names over flame chart bar if they fit into the bar.
https://bugs.webkit.org/show_bug.cgi?id=113052

Reviewed by Vsevolod Vlasov.

The draw function will draw the bar title if the text is less than bar width.
Unfortunately almost all the projects which need to be profiled
use long function names with dots. So if the function name has dots and
doesn't fit into the space then prepareTitle will try to drop the prefix before dot.
If the title has no dots then the function will strip the tail of the title.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._prepareTitle):

8:55 AM Changeset in webkit [146618] by yurys@chromium.org

2 edits in trunk/LayoutTests

Unreviewed. Update test expectations for a bunch of softwarecompositing tests.

platform/chromium/TestExpectations:

8:44 AM Changeset in webkit [146617] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Add "hidden" attribute to the recently added APIs in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=113061

Added "hidden": true to the APIs introduced since version 1.0.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

inspector/Inspector.json:

8:39 AM Changeset in webkit [146616] by schenney@chromium.org

4 edits in trunk

Source/WebKit/chromium: Skia flag removal to enable bug fixes and performance improvements.

Unreviewed code enabling.

skia_webkit.gyp:

LayoutTests: Enabling Skia features/modifications.

Unreviewed Chromium expectations, all of which will be removed later today.

platform/chromium/TestExpectations:

8:22 AM Changeset in webkit [146615] by vsevik@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: Correctly implement scrollToLine, revealLine and setSelection on CodeMirror editor.
https://bugs.webkit.org/show_bug.cgi?id=113028

Reviewed by Pavel Feldman.

Added focus event handler to CodeMirror editor view elememnt to support inspector's focus model.
Added selection and scroll listeners to correctly save editor scroll and selection in history.
Implemented revealLine, scrollToLine and setSelection.
Note: CodeMirror's coordsChar method does not work correctly in "local" mode, implemented as binary search
as a temporary workaround.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.defaultFocusedElement):
(WebInspector.CodeMirrorTextEditor.prototype._handleElementFocus):
(WebInspector.CodeMirrorTextEditor.prototype.revealLine):
(WebInspector.CodeMirrorTextEditor.prototype._coordsChar):
(WebInspector.CodeMirrorTextEditor.prototype._topScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._bottomScrolledLine):
(WebInspector.CodeMirrorTextEditor.prototype._scroll):
(WebInspector.CodeMirrorTextEditor.prototype._selectionChange):
(WebInspector.CodeMirrorTextEditor.prototype.scrollToLine):
(WebInspector.CodeMirrorTextEditor.prototype.setSelection):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):

inspector/front-end/TextEditor.js:

(WebInspector.TextEditor.prototype.copyRange):

8:16 AM Changeset in webkit [146614] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: [Regression] Editor scroll is not restored after inspector reload.
https://bugs.webkit.org/show_bug.cgi?id=113027

Reviewed by Pavel Feldman.

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype._isEditorShowing):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):

8:15 AM WebKitGTK/2.0.x edited by dimstar@opensuse.org

Add bug 113036 to the list. (diff)

8:04 AM Changeset in webkit [146613] by allan.jensen@digia.com

5 edits in trunk/Source/WebCore

[Qt] Fix build with OPENCL 1.2
https://bugs.webkit.org/show_bug.cgi?id=113056

Reviewed by Kenneth Rohde Christiansen.

Switch qmake checks to the modern style which means we can enable OpenCL with
WEBKIT_CONFIG+=opencl.

Upgrade OpenCL 1.1 clCreateImage2D to OpenCL 1.2 clCreateImage calls.

Target.pri:
WebCore.pri:
platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::createOpenCLImageResult):

platform/graphics/gpu/opencl/FilterContextOpenCL.cpp:

(WebCore::FilterContextOpenCL::createOpenCLImage):

7:59 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

7:57 AM Changeset in webkit [146612] by kov@webkit.org

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146611 - Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

te.po: Added.

7:54 AM Changeset in webkit [146611] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

Telugu [te] language translation submission for WebKitGTK+ HEAD
https://bugs.webkit.org/show_bug.cgi?id=103052

Patch by Krishnababu Krothapalli <kkrothap@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

te.po: Added.

7:45 AM Changeset in webkit [146610] by eae@chromium.org

8 edits
1 add
2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines for r146600.

platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-mac/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.png:

7:42 AM Changeset in webkit [146609] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK][AC] Opacity animation doesn't work with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110347

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

The static casting in ternary operator doesn't change actual inputted argument type.
So I replaced it with if-else statement.

Covered by existing animation tests.

platform/graphics/clutter/PlatformClutterAnimation.cpp:

(WebCore::PlatformClutterAnimation::addClutterTransitionForProperty):
(WebCore::PlatformClutterAnimation::addClutterKeyframeTransitionForProperty):

7:38 AM Changeset in webkit [146608] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK][AC] Add removing animations procedure with clutter ac backend
https://bugs.webkit.org/show_bug.cgi?id=110607

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-03-22
Reviewed by Gustavo Noronha Silva.

This changes is based on mac port implementation. The only different thing is
that updateAnimations is called explicitly in destructor of GraphicsLayerClutter
to remove uncommitted animations. Because even though we call notifyFlushRequired
to remove existing animations in removeAnimation(), removeClutterAnimationFromLayer
has been never reached since the root layer is destroyed before. It means
that we haven't lost a change to remove actual animations from clutterActor.

Covered by existing animation tests.

platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::removeAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::removeClutterAnimationFromLayer):

platform/graphics/clutter/GraphicsLayerClutter.h:

(WebCore::GraphicsLayerClutter::animationIsRunning):
(GraphicsLayerClutter):

7:28 AM Changeset in webkit [146607] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[EFL][WebGL] Optimize AlphaOp for HTMLVideoElement input.
https://bugs.webkit.org/show_bug.cgi?id=113049

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Covered by existing tests.

Changeset 137397 implemented optimisation to avoid any
unnecessary Unmultiply or Premultiply operation in unpack/pack
provided the Image source is from HTMLVideoElement. This patch
enables the same for EFL port.

platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

7:27 AM Changeset in webkit [146606] by eae@chromium.org

8 edits
5 adds in trunk/LayoutTests

Unreviewed chromium and apple mac rebaselines for r146600.

platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac-lion/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
platform/chromium-mac-lion/fast/transforms/bounding-rect-zoom-expected.txt: Added.
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Added.
platform/chromium-mac-snowleopard/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt: Removed.
platform/chromium/fast/text/international/bidi-layout-across-linebreak-expected.txt: Added.
platform/chromium/fast/transforms/bounding-rect-zoom-expected.txt: Added.
platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:

7:24 AM Changeset in webkit [146605] by timothy@apple.com

2 edits in trunk/Source/WebKit2

Fix an assert when opening the Web Inspector window for the first time.

rdar://problem/13471765
https://webkit.org/b/113053

Reviewed by Eric Carlson.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow): Assign m_inspectorWindow
earlier so it is ready for when center is called and windowDidMove: gets called.

7:22 AM Changeset in webkit [146604] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Build testapi.mm with ARC enabled for armv7s
<http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
^{1 error generated.}

Configurations/ToolExecutable.xcconfig: Enable ARC for armv7s

architecture.

6:53 AM Changeset in webkit [146603] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

Revert "BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]"

This fixes a build failure introduced by this change:

Source/JavaScriptCore/API/tests/testapi.mm:206:6: error: ARC forbids explicit message send of 'dealloc'

[super dealloc];

^~

1 error generated.

Not sure why this didn't fail locally on my Mac Pro.

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Remove call to [super dealloc].

6:46 AM Changeset in webkit [146602] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Missed one in r146589.

platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Rebaselining after r146531.

6:43 AM Changeset in webkit [146601] by tommyw@google.com

13 edits in trunk

Source/WebCore: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

This patch cleans away deprecated parts, fixes so that stop() can be called more than once and adds
the missing emma attribute on SpeechRecognitionEvent (which is always null).

Patch covered by existing tests.

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):

Modules/speech/SpeechRecognition.h:

(SpeechRecognition):

Modules/speech/SpeechRecognitionEvent.cpp:

(WebCore::SpeechRecognitionEvent::createResult):
(WebCore::SpeechRecognitionEvent::createNoMatch):
(WebCore::SpeechRecognitionEvent::SpeechRecognitionEvent):

Modules/speech/SpeechRecognitionEvent.h:

(WebCore):
(SpeechRecognitionEventInit):
(SpeechRecognitionEvent):
(WebCore::SpeechRecognitionEvent::emma):

Modules/speech/SpeechRecognitionEvent.idl:

Source/WebKit/chromium: Clean up the speach recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

public/WebSpeechRecognizerClient.h:
src/SpeechRecognitionClientProxy.cpp:
src/SpeechRecognitionClientProxy.h:

(SpeechRecognitionClientProxy):

LayoutTests: Clean up the speech recognintion API
https://bugs.webkit.org/show_bug.cgi?id=112916

Reviewed by Adam Barth.

fast/events/constructors/speech-recognition-event-constructor-expected.txt:
fast/events/constructors/speech-recognition-event-constructor.html:

6:40 AM Changeset in webkit [146600] by eae@chromium.org

8 edits
2 adds in trunk

Floor cell widths in AutoTableLayout::recalcColumn
https://bugs.webkit.org/show_bug.cgi?id=112922

Reviewed by Levi Weintraub.

Source/WebCore:

Table cells widths are floored to ensure even distribution of available
space across columns. The code path that computes the width of the
_table_ failed to take this into account and thus can over report the
total width of the table.

Test: fast/sub-pixel/table-with-subpixel-cell-size.html

rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn): Floor width to match column sizing logic.

LayoutTests:

Add test for table with subpixel cells and update existing baselines as needed.

fast/sub-pixel/table-with-subpixel-cell-size-expected.html: Added.
fast/sub-pixel/table-with-subpixel-cell-size.html: Added.
platform/chromium-linux/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-win/fast/text/international/bidi-layout-across-linebreak-expected.txt:
platform/chromium-win/fast/transforms/bounding-rect-zoom-expected.txt:
platform/chromium-win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:

6:35 AM Changeset in webkit [146599] by ddkilzer@apple.com

2 edits in trunk/Source/JavaScriptCore

BUILD FIX (r146558): Call [super dealloc] from -[TinyDOMNode dealloc]
<http://webkit.org/b/112608>

Fixes the following build failure:

Source/JavaScriptCore/API/tests/testapi.mm:205:1: error: method possibly missing a [super dealloc] call [-Werror,-Wobjc-missing-super-calls]
}
^{1 error generated.}

API/tests/testapi.mm:

(-[TinyDOMNode dealloc]): Call [super dealloc].

6:27 AM Changeset in webkit [146598] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146208): Export shouldPrintExceptions methods for iOS

Fixes the following build failure:

Undefined symbols for architecture i386:

"ZN7WebCore11PageConsole24setShouldPrintExceptionsEb", referenced from:

+[WebCoreStatistics setShouldPrintExceptions:] in WebCoreStatistics.o

"ZN7WebCore11PageConsole21shouldPrintExceptionsEv", referenced from:

+[WebCoreStatistics shouldPrintExceptions] in WebCoreStatistics.o

ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)

WebCore.exp.in: Move symbols so they're exported for iOS as

well.

6:18 AM Changeset in webkit [146597] by commit-queue@webkit.org

6 edits
2 adds in trunk/Source/WebKit

[BlackBerry] Add custom BackForwardList client implementation
https://bugs.webkit.org/show_bug.cgi?id=113024

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-22
Reviewed by Rob Buis.

PR 310030
Internally reviewed by Joe Mason.

Source/WebKit:

PlatformBlackBerry.cmake: Add new files to compilation.

Source/WebKit/blackberry:

Adds a new class BackForwardListBlackBerry that implements
BackForwardList client and wraps the BackForwardListImpl including
the BlackBerry specific changes to notify the API layer when the
BackForwardList changes.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): Create a
BackForwardListBlackBerry.
(BlackBerry::WebKit::WebPage::getBackForwardList): Use
BackForwardListBlackBerry instead of BackForwardListImpl.
(BlackBerry::WebKit::WebPage::clearBackForwardList): Ditto.

WebCoreSupport/BackForwardListBlackBerry.cpp: Added.

(WebCore):
(WebCore::BackForwardListBlackBerry::BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::~BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::current):
(WebCore::BackForwardListBlackBerry::notifyBackForwardListChanged):
(WebCore::BackForwardListBlackBerry::addItem):
(WebCore::BackForwardListBlackBerry::goToItem):
(WebCore::BackForwardListBlackBerry::itemAtIndex):
(WebCore::BackForwardListBlackBerry::backListCount):
(WebCore::BackForwardListBlackBerry::forwardListCount):
(WebCore::BackForwardListBlackBerry::isActive):
(WebCore::BackForwardListBlackBerry::close):
(WebCore::BackForwardListBlackBerry::clear):
(WebCore::BackForwardListBlackBerry::entries):
(WebCore::BackForwardListBlackBerry::currentItem):

WebCoreSupport/BackForwardListBlackBerry.h: Added.

(WebKit):
(WebCore):
(BackForwardListBlackBerry):
(WebCore::BackForwardListBlackBerry::create):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

5:32 AM Changeset in webkit [146596] by kov@webkit.org

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146594 - [kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

kn.po: Added.

5:32 AM Changeset in webkit [146595] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146474 - [l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

mr.po: updated.

5:31 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

5:29 AM Changeset in webkit [146594] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

[kn] Kannada Translation for webkit
https://bugs.webkit.org/show_bug.cgi?id=106301

Patch by Shankar Prasad <svenkate@redhat.com> on 2013-03-22
Reviewed by Gustavo Noronha Silva (kov).

kn.po: Added.

5:24 AM Changeset in webkit [146593] by jocelyn.turcotte@digia.com

2 edits in trunk/Tools

[Qt] Fix the TestWebKitAPI build
https://bugs.webkit.org/show_bug.cgi?id=113044

Reviewed by Tor Arne Vestbø.

The generate-forwarding-headers script would only be run
after the targets in InjectedBundle.pri since the second
addStrictSubdirOrderBetween call in
Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
the derived_sources -> injected_bundle order in SUBDIRS.

Fix it by only moving the dependent target at the end of
SUBDIRS, don't touch its dependency.

qmake/mkspecs/features/functions.prf:

5:14 AM Changeset in webkit [146592] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Fix Chromium Win compilation after r146583.

bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):

5:04 AM Changeset in webkit [146591] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Chart has to be zoomed around the mouse pointer.
https://bugs.webkit.org/show_bug.cgi?id=113031

Reviewed by Yury Semikhatsky.

Overview grid is able to zoom around the mouse pointer.
So the simplest way is to translate x coordinate of the mouse pointer hovered over the chart
to x coordinate in term of overview window and pass it to the zoom function.

Minor unrelated fix: draw small border at bottom of the overview grid.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._onMouseWheel):

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.zoom):

inspector/front-end/flameChart.css:

(#flame-chart-overview-container):

4:58 AM Changeset in webkit [146590] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] TextureMapperImageBuffer should not use rendering code for filters.
https://bugs.webkit.org/show_bug.cgi?id=113040

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-22
Reviewed by Kenneth Rohde Christiansen.

Disable TextureMapperImageBuffer filters, until they can be done the right way.
This should only disrupt accelerated filters in fallback mode, which is a very rare
use case.

No new testable functionality.

platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):

4:54 AM Changeset in webkit [146589] by zarvai@inf.u-szeged.hu

3 edits
8 moves
8 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r146469 and r146531. Cleaning up duplicated expecteds.

platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Removed.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Removed.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Removed.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Removed.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png.
platform/qt/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png.
platform/qt/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt.
platform/qt/css3/filters/effect-reference-expected.txt:

4:29 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

4:26 AM Changeset in webkit [146588] by commit-queue@webkit.org

5 edits in trunk

Web Inspector: Report more CSS errors
https://bugs.webkit.org/show_bug.cgi?id=113022

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-22
Reviewed by Pavel Feldman.

Source/WebCore:

Reporting next few CSS syntax errors in declaration_list.

css/CSSGrammar.y.in:

LayoutTests:

inspector/console/console-css-warnings-expected.txt:
inspector/console/console-css-warnings.html:

4:00 AM Changeset in webkit [146587] by yurys@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: use individual samples to construct CPU profile flame chart
https://bugs.webkit.org/show_bug.cgi?id=112569

Reviewed by Pavel Feldman.

Added an optional array of samples to the CPU profile returned over the
protocol. Each sample is id of the profile node corresponding to the top frame
of the sample's stack trace. The array of samples if present is used to draw
the flame chart on the CPU profile panel, otherwise flame chart is drawn based
on the aggregated profile data.

bindings/js/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForSamples):

bindings/js/ScriptProfile.h:

(ScriptProfile):

bindings/v8/ScriptProfile.cpp:

(WebCore::buildInspectorObjectFor):
(WebCore):
(WebCore::ScriptProfile::buildInspectorObjectForSamples):

bindings/v8/ScriptProfile.h:

(ScriptProfile):

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):

inspector/Inspector.json:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

inspector/front-end/CPUProfileView.js:

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
(WebInspector.CPUProfileView.prototype._buildIdToNodeMap):

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._calculateTimelineData):

3:34 AM Changeset in webkit [146586] by commit-queue@webkit.org

2 edits in trunk

Cannot run All Source (target WebProcess) on Xcode.
https://bugs.webkit.org/show_bug.cgi?id=111042

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-03-22
Reviewed by Alexey Proskuryakov.

WebProcessShim is renamed by r139066.
However, WebProcessShim is not renamed to SecItemShim in WebKit.xcworkspace.
This make WebProcess.app load WebProcessShim.dylib, and it cause dyld loading error.

WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Renamed WebProcessShim to SecItemShim.

3:08 AM Changeset in webkit [146585] by commit-queue@webkit.org

14 edits
1 move
1 delete in trunk/Source/WebCore

Use generated bindings for the Coordinates type used by Geolocation
https://bugs.webkit.org/show_bug.cgi?id=112975

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, refactoring only.

CMakeLists.txt:
GNUmakefile.list.am:
Modules/geolocation/Coordinates.cpp: Renamed from Source/WebCore/bindings/js/JSCoordinatesCustom.cpp.

(WebCore):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):

Modules/geolocation/Coordinates.h:

(Coordinates):

Modules/geolocation/Coordinates.idl:
Target.pri:
UseJSC.cmake:
UseV8.cmake:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:
bindings/v8/custom/V8CoordinatesCustom.cpp: Removed.

3:04 AM Changeset in webkit [146584] by commit-queue@webkit.org

16 edits
12 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Incomplete datetime format should fallback to default
https://bugs.webkit.org/show_bug.cgi?id=113005

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-22
Reviewed by Kent Tamura.

Source/WebCore:

Use fallback format when datetime format from locale is not complete.

Tests: fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html

fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(DateTimeFormatValidator): A helper class that parses datetime format and tests existence of fields.
(WebCore::DateTimeFormatValidator::DateTimeFormatValidator):
(WebCore::DateTimeFormatValidator::visitField):
(WebCore::DateTimeFormatValidator::validateFormat): Parses datetime format and validates by calling BaseMultipleFieldsDateAndTimeInputType::isValidFormat.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updateInnerTextValue): Checks if dateTimeFormat is valid, and uses fallback format if not.

html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare isValidFormat.

html/DateInputType.cpp:

(WebCore::DateInputType::isValidFormat): Added.

html/DateInputType.h:

(DateInputType):

html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::isValidFormat): Added.

html/DateTimeInputType.h:

(DateTimeInputType):

html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::isValidFormat): Added.

html/DateTimeLocalInputType.h:

(DateTimeLocalInputType):

html/MonthInputType.cpp:

(WebCore::MonthInputType::isValidFormat): Added.

html/MonthInputType.h:

(MonthInputType):

html/TimeInputType.cpp:

(WebCore::TimeInputType::isValidFormat): Added.

html/TimeInputType.h:

(TimeInputType):

html/WeekInputType.cpp:

(WebCore::WeekInputType::isValidFormat): Added.

html/WeekInputType.h:

(WeekInputType):

LayoutTests:

fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Added.
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Added.
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Added.
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Added.
fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Added.

2:54 AM Changeset in webkit [146583] by morrita@google.com

24 edits
14 adds in trunk

Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538

Reviewed by Elliott Sprehn.

Source/WebCore:

This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.

The change has two parts:

1. Tracking which Element objects to be created.
2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.

For 1, CustomElementRegistry maintains list of "callback
invocaions". Each list item ("invocation") tracks the element
which has a lifecycle callback to be invoked. Each invocation is
registered when - Any custom element C++ object is instantiated.
See changes on CustomElementConstructor.cpp.

This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.

For 2, CustomElementRegistry basically follows what
MutationObserver is doing, and introduces a method called
deliverLifecycleCallbacks(). This function flushes all pending
callback invocations. You can think it as a dual of
MutationObserver::deliverAllMutations().

The delivery function is called places where MutationObserver's
deliverAllMutations() is called. In addition, it is also called
just before returning from a set of DOM APIs. For example, it is
called just before createElement() returns, so that possibly
created custom element becomes ready through its readyCallback().
Such APIs get "V8DeliverCustomElementCallbacks" IDL attribute. In
principle, APIs which can create new custom element instnaces are
marked. See CustomElementRegistry::CallbackDeliveryScope and
changes on CodeGeneratorV8.pm.

We need this extra work because the readyCallback() needs to give
an illusion so that JavaScript programmers feel like the
readyCallback() callback being called just after it is created,
instead of called on arbitrary late timing like MutationObserver
notifications.

Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html

fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html

bindings/scripts/CodeGeneratorV8.pm:
Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.

(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):

bindings/scripts/IDLAttributes.txt:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):

dom/CustomElementConstructor.h:

(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):

dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.

(WebCore::CustomElementInvocation::CustomElementInvocation):
(WebCore::CustomElementInvocation::~CustomElementInvocation):
(WebCore::activeCustomElementRegistries):
(WebCore::CustomElementRegistry::~CustomElementRegistry):
(WebCore::CustomElementRegistry::didGiveTypeExtension):
(WebCore::CustomElementRegistry::didCreateElement):
(WebCore::CustomElementRegistry::activate):
(WebCore::CustomElementRegistry::deactivate):
(WebCore::CustomElementRegistry::deliverLifecycleCallbacks):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacks):

dom/CustomElementRegistry.h:

(CustomElementInvocation):
(WebCore::CustomElementInvocation::element):
(CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::CallbackDeliveryScope):
(WebCore::CustomElementRegistry::CallbackDeliveryScope::~CallbackDeliveryScope):
(CustomElementRegistry):
(WebCore::CustomElementRegistry::deliverAllLifecycleCallbacksIfNeeded):

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):

dom/Document.h:

(Document):

dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp: Added deliverAllLifecycleCallbacks()

Source/WTF:

wtf/HashSet.h:

(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
fast/dom/custom/lifecycle-ready-creation-api.html: Added.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
fast/dom/custom/lifecycle-ready-parser-only.html: Added.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
fast/dom/custom/lifecycle-ready-parser-script.html: Added.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
fast/dom/custom/lifecycle-ready-paste.html: Added.

2:29 AM Changeset in webkit [146582] by tommyw@google.com

18 edits in trunk

MediaStream API: Finalize the RTCPeerConnection states
https://bugs.webkit.org/show_bug.cgi?id=112792

Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebRTCPeerConnectionHandlerClient.h:

Source/WebCore:

This patch finalized the RTCPeerConnection state and events. These changes
have not yet pushed out to the editors draft; but they are uncontroversial
and agreed upon.

readyState will be deleted; please use the replacement signalingState which is already available.
onstatechange -> onsignalingstatechange
onicechange -> oniceconnectionstatechange
ongatheringchange will be deleted since oniceconnectionstatechange can be used for the same purpose.
RTCIceConnectionState::"starting" -> RTCIceConnectionState::"new"

Patch covered by modified tests.

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::changeSignalingState):
(WebCore::RTCPeerConnection::changeIceGatheringState):
(WebCore::RTCPeerConnection::changeIceConnectionState):

Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

Modules/mediastream/RTCPeerConnection.idl:
dom/EventNames.h:

(WebCore):

platform/mediastream/RTCPeerConnectionHandlerClient.h:

Source/WebKit/chromium:

src/AssertMatchingEnums.cpp:

LayoutTests:

fast/mediastream/RTCPeerConnection-datachannel.html:
fast/mediastream/RTCPeerConnection-dtmf.html:
fast/mediastream/RTCPeerConnection-events-expected.txt:
fast/mediastream/RTCPeerConnection-events.html:
fast/mediastream/RTCPeerConnection-ice.html:
fast/mediastream/RTCPeerConnection-state-expected.txt:
fast/mediastream/RTCPeerConnection-state.html:

2:23 AM Changeset in webkit [146581] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] View is not focused when fullscreen mode toggled
https://bugs.webkit.org/show_bug.cgi?id=113009

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Laszlo Gombos.

Set focus on view when fullscreen mode enabled/disabled
by FullScreen API.

MiniBrowser/efl/main.c:

(on_fullscreen_accept):
(on_fullscreen_deny):

2:20 AM Changeset in webkit [146580] by mkwst@chromium.org

4 edits in trunk/Source/WebCore

Prefer 'KURL(ParsedURLString, String)' when dealing with known-good data.
https://bugs.webkit.org/show_bug.cgi?id=112965

Reviewed by Alexey Proskuryakov.

In https://bugs.webkit.org/show_bug.cgi?id=112783#c6, Adam noted that
it would be possible to use 'KURL(ParsedURLString, [url])' rather than
'KURL(KURL(), [url])', since we knew that the URL in question is a
value and absolute URL. This patch fixes the obvious instances of this
pattern; there are several more 'KURL(KURL(), String)' calls in
WebCore but these were the only places I was reasonably sure that bad
data couldn't creep in.

dom/Document.cpp:

(WebCore::Document::updateBaseURL):

'documentURI' is pulled from 'url()->string()'. It's safe.

page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):
(WebCore::ContentSecurityPolicy::reportViolation):

'CallFrame::sourceURL()' is a known valid/absolute URL.

page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::create):

The strings constructed here are certainly valid.

2:17 AM Changeset in webkit [146579] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip a now passing test after r146393.
https://bugs.webkit.org/show_bug.cgi?id=112904.

platform/qt/TestExpectations:

2:09 AM Changeset in webkit [146578] by commit-queue@webkit.org

3 edits
1 add in trunk/LayoutTests

[EFL] New baseline for accessibility/platform-name.html
https://bugs.webkit.org/show_bug.cgi?id=113018

Unreviewed EFL gardening

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-22

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:
platform/efl/accessibility/platform-name-expected.txt: Added.

2:00 AM Changeset in webkit [146577] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. move overview window when user scrolls the chart.
https://bugs.webkit.org/show_bug.cgi?id=113014

Reviewed by Yury Semikhatsky.

I found that I could use scaling mechanics in OverviewGrid for scaling the chart.
But the dragging part was not so simple due to the different approaches in
OverviewGrid and FlameChart. OverviewGrid used _windowLeft and _windowRight
when FlameChart used _xOffset and _xScaleFactor and width.
It was not practical and I rewrote the FlameChart mechanics
and now it also uses _windowLeft _windowRight.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._updateBoundaries):
(WebInspector.FlameChart.prototype.update):

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.prototype.zoom):
(WebInspector.OverviewGrid.Window.prototype._zoom):

inspector/front-end/inspectorCommon.css:

(.overview-grid-window-rulers):

1:56 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:52 AM Changeset in webkit [146576] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Tools

Merge r146504 - [GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

gtk/generate-feature-defines-files:

(write_feature_defines_header):
(write_flattened_feature_defines_file):

1:38 AM Changeset in webkit [146575] by commit-queue@webkit.org

6 edits
1 move in trunk/Source/WebCore

Move GeolocationClient.h to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112997

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

GNUmakefile.list.am:
Modules/geolocation/GeolocationClient.h: Renamed from Source/WebCore/page/GeolocationClient.h.

(WebCore):
(GeolocationClient):
(WebCore::GeolocationClient::~GeolocationClient):

WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

1:29 AM Changeset in webkit [146574] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a flaky crash test expectations on Mac WebKit2 per bug 113020.

platform/mac-wk2/TestExpectations:

1:24 AM Changeset in webkit [146573] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Skipping fast/dom/custom tests as the custom elements support is not yet enabled

on the GTK port. Adding crashing expectations for two IDB tests that regressed with r146540.

1:12 AM Changeset in webkit [146572] by commit-queue@webkit.org

35 edits
14 deletes in trunk

Unreviewed, rolling out r146534 and r146565.
http://trac.webkit.org/changeset/146534
http://trac.webkit.org/changeset/146565
https://bugs.webkit.org/show_bug.cgi?id=113017

"r146534 caused perf regression on Chromium Linux x64"
(Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-22

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateOverloadedFunction):
(GenerateFunctionCallback):
(GenerateFunction):
(GenerateParametersCheck):
(GenerateSingleConstructorCallback):
(GenerateNonStandardFunction):
(GenerateImplementation):
(GenerateFunctionCallString):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/CustomElementHelpers.cpp:
bindings/v8/CustomElementHelpers.h:

(WebCore):
(CustomElementHelpers):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

bindings/v8/V8RecursionScope.cpp:

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):

dom/CustomElementConstructor.h:

(CustomElementConstructor):

dom/CustomElementRegistry.cpp:

(WebCore::CustomElementRegistry::~CustomElementRegistry):

dom/CustomElementRegistry.h:

(WebCore):
(CustomElementRegistry):

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::registerElement):

dom/Document.h:
dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Element.idl:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp:

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp:

Source/WTF:

wtf/HashSet.h:

(WTF):
(WTF::copyToVector):

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Removed.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Removed.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-creation-api.html: Removed.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-innerHTML.html: Removed.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Removed.
fast/dom/custom/lifecycle-ready-parser-only.html: Removed.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-parser-script.html: Removed.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Removed.
fast/dom/custom/lifecycle-ready-paste.html: Removed.

1:07 AM Changeset in webkit [146571] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] Memory leak in AudioFileReader::createBus()
https://bugs.webkit.org/show_bug.cgi?id=112925

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-22
Reviewed by Martin Robinson.

Adopt the reference returned by g_timeout_source_new()
to fix a memory leak.

No new tests. No change in behavior.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

12:52 AM Changeset in webkit [146570] by commit-queue@webkit.org

11 edits
2 moves in trunk/Source/WebCore

Move page/Coordinates.[h|idl] to Modules/geolocation/
https://bugs.webkit.org/show_bug.cgi?id=112945

Patch by Steve Block <steveblock@chromium.org> on 2013-03-22
Reviewed by Kentaro Hara.

No new tests, no functional change.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/geolocation/Coordinates.h: Renamed from Source/WebCore/page/Coordinates.h.

(WebCore):
(Coordinates):
(WebCore::Coordinates::create):
(WebCore::Coordinates::isolatedCopy):
(WebCore::Coordinates::latitude):
(WebCore::Coordinates::longitude):
(WebCore::Coordinates::altitude):
(WebCore::Coordinates::accuracy):
(WebCore::Coordinates::altitudeAccuracy):
(WebCore::Coordinates::heading):
(WebCore::Coordinates::speed):
(WebCore::Coordinates::canProvideAltitude):
(WebCore::Coordinates::canProvideAltitudeAccuracy):
(WebCore::Coordinates::canProvideHeading):
(WebCore::Coordinates::canProvideSpeed):
(WebCore::Coordinates::Coordinates):

Modules/geolocation/Coordinates.idl: Renamed from Source/WebCore/page/Coordinates.idl.
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:

12:41 AM Changeset in webkit [146569] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a flaky test failure expectation per bug 113012.

platform/win/TestExpectations:

12:36 AM Changeset in webkit [146568] by rniwa@webkit.org

3 edits in trunk/Source/JavaScriptCore

Leak bots erroneously report JSC::WatchpointSet as leaking
https://bugs.webkit.org/show_bug.cgi?id=107781

Reviewed by Filip Pizlo.

Since leaks doesn't support tagged pointers, avoid using it by flipping the bit flag to indicate
the entry is "fat". We set the flag when the entry is NOT fat; i.e. slim.

Replaced FatFlag by SlimFlag and initialized m_bits with this flag to indicate that the entry is
initially "slim".

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::copySlow): Don't set FatFlag since it has been replaced by SlimFlag.
(JSC::SymbolTableEntry::inflateSlow): Ditto.

runtime/SymbolTable.h:

(JSC::SymbolTableEntry::Fast::Fast): Set SlimFlag by default.
(JSC::SymbolTableEntry::Fast::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::Fast::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag
is not set.

(JSC::SymbolTableEntry::SymbolTableEntry): Set SlimFlag by default.
(JSC::SymbolTableEntry::SymbolTableEntry::getFast): Set SlimFlag when creating Fast from a fat entry.
(JSC::SymbolTableEntry::isNull): Ignore SlimFlag.
(JSC::SymbolTableEntry::FatEntry::FatEntry): Strip SlimFlag.
(JSC::SymbolTableEntry::isFat): An entry is fat when m_bits is not entirely zero and SlimFlag is unset.
(JSC::SymbolTableEntry::fatEntry): Don't strip FatFlag as this flag doesn't exist anymore.
(JSC::SymbolTableEntry::pack): Preserve SlimFlag.

(JSC::SymbolTableIndexHashTraits): empty value is no longer zero so don't set emptyValueIsZero true.

12:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

12:19 AM Changeset in webkit [146567] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Final Mac rebaseline attempt for r146531 since r146564 wasn't enough.

I'm sorry I made a huge mess here.

platform/mac/compositing/rtl/rtl-fixed-expected.txt:

12:09 AM Changeset in webkit [146566] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[chromium] Mark virtual/gpu/fast/canvas/canvas-toDataURL-webp.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.

Patch by James Zern <jzern@chromium.org> on 2013-03-22

platform/chromium/TestExpectations:

Mar 21, 2013:

11:16 PM Changeset in webkit [146565] by morrita@google.com

24 edits
14 adds in trunk

Custom Elements: "readyCallback" lifecycle callback should be called.
https://bugs.webkit.org/show_bug.cgi?id=112538

Reviewed by Elliott Sprehn.

Source/WebCore:

This change allows each custom element definition to hook up its instantiation,
namely "readyCallback" lifecycle callback.

The change has two parts:

1. Tracking which Element objects to be created.
2. Invoking appropriate JavaScript functions, which are readyCallback(), before the Element object is visible from page script.

This also happens when @is attribute is set by the parser or node
cloning routine, which can turn a non-custom element into a
type-extended custom element. See changes on Element.cpp.

Tests: fast/dom/custom/lifecycle-ready-createElement-recursion.html

fast/dom/custom/lifecycle-ready-createElement-reentrancy.html
fast/dom/custom/lifecycle-ready-creation-api.html
fast/dom/custom/lifecycle-ready-innerHTML.html
fast/dom/custom/lifecycle-ready-parser-only.html
fast/dom/custom/lifecycle-ready-parser-script.html
fast/dom/custom/lifecycle-ready-paste.html

bindings/scripts/CodeGeneratorV8.pm:
Hooked up CallbackDeliveryScope through V8DeliverCustomElementCallbacks attriute.

(GenerateCustomElementInvocationScopeIfNeeded):
(GenerateNormalAttrSetter):
(GenerateFunction):

bindings/scripts/IDLAttributes.txt:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::CustomElementHelpers::invokeReadyCallbackIfNeeded):
(WebCore::CustomElementHelpers::invokeReadyCallbacksIfNeeded):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

bindings/v8/V8RecursionScope.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::V8RecursionScope::didLeaveScriptContext):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::createElement):
(WebCore::CustomElementConstructor::createElementInternal):

dom/CustomElementConstructor.h:

(WebCore::CustomElementConstructor::isExtended):
(CustomElementConstructor):

dom/CustomElementRegistry.cpp: Adding element tracking and invocation execution.

dom/CustomElementRegistry.h:

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::didCreateCustomElement):

dom/Document.h:

(Document):

dom/Document.idl:
dom/Element.cpp:

(WebCore::Element::attributeChangedFromParserOrByCloning): Added to catch @is attribute
(WebCore::Element::parserSetAttributes):
(WebCore::Element::cloneAttributesFromElement):

dom/Element.h:
dom/Node.idl:
dom/ShadowRoot.idl:
html/HTMLElement.idl:
html/parser/HTMLScriptRunner.cpp: Added deliverAllLifecycleCallbacks()

(WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
(WebCore::HTMLScriptRunner::runScript):

Source/WebKit/chromium:

src/WebKit.cpp: Added deliverAllLifecycleCallbacks()

Source/WTF:

wtf/HashSet.h:

(WTF::copyToVector): Generalized to let it accept variants like ListHahsSet instead of only HashSet.

LayoutTests:

fast/dom/custom/lifecycle-ready-createElement-recursion-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-recursion.html: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy-expected.txt: Added.
fast/dom/custom/lifecycle-ready-createElement-reentrancy.html: Added.
fast/dom/custom/lifecycle-ready-creation-api-expected.txt: Added.
fast/dom/custom/lifecycle-ready-creation-api.html: Added.
fast/dom/custom/lifecycle-ready-innerHTML-expected.txt: Added.
fast/dom/custom/lifecycle-ready-innerHTML.html: Added.
fast/dom/custom/lifecycle-ready-parser-only-expected.html: Added.
fast/dom/custom/lifecycle-ready-parser-only.html: Added.
fast/dom/custom/lifecycle-ready-parser-script-expected.txt: Added.
fast/dom/custom/lifecycle-ready-parser-script.html: Added.
fast/dom/custom/lifecycle-ready-paste-expected.txt: Added.
fast/dom/custom/lifecycle-ready-paste.html: Added.

11:05 PM Changeset in webkit [146564] by rniwa@webkit.org

5 edits in trunk/LayoutTests

Yet another Mac rebaseline attempt for r146531 since r146538 and r146554 didn't work.

platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:

10:50 PM Changeset in webkit [146563] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Crash in WebCore::MediaPlayer::cachedResourceLoader + 4
https://bugs.webkit.org/show_bug.cgi?id=112977

Reviewed by Geoffrey Garen.

Speculative fix for a NULL-dereference crash. MediaPlayerPrivateAVFoundationObjC is the
sole owner of a WebCoreAVFLoaderDelegate instance. It releases this instance in its destructor,
but it is possible that, on another thread, the AVAssetResourceLoader has already begun
using the delegate and in so doing has retained it. By the time the delegate method is fired
on the main thread, the MediaPlayerPrivateAVFoundationObjC owner of the delegate has already
been deleted, and the delegate's m_callback pointer is now pointing at freed memory.

In addition to calling -[AVAssetResourceLoader setDelegate:queue:] to avoid any not-yet-started
delegate callbacks, MediaPlayerPrivateAVFoundationObjC should clear the WebCoreAVFLoaderDelegate
m_callback ivar, to avoid calling into freed memory for already queued delegate callbacks.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC): Clear the m_loaderDelegate's callback pointer.
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]): Check the value of m_callback before continuing.
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]): Ditto.
(-[WebCoreAVFLoaderDelegate setCallback:]): Added simple setter.

10:22 PM Changeset in webkit [146562] by tasak@google.com

3 edits
2 adds in trunk

XMLDocumentParser doesn't parse <template> correctly.
https://bugs.webkit.org/show_bug.cgi?id=112328

Reviewed by Hajime Morrita.

Source/WebCore:

XMLDocumentParser should check whether a parent node is attached or not
when a new element is appended.

Test: fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
m_currentNode is a parent node of newElement, but it is updated by
pushCurrentNode. So firstly stored copied m_curretNode's value into
local currentNode and used the currentNode to check whether
newElement's parent is attached or not.

LayoutTests:

fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash-expected.txt: Added.
fast/dom/HTMLTemplateElement/xhtml-with-titleElement-parsing-crash.xhtml: Added.

9:58 PM Changeset in webkit [146561] by dgrogan@chromium.org

4 edits in trunk/Source

Unreviewed, rolling out r146560.
http://trac.webkit.org/changeset/146560
https://bugs.webkit.org/show_bug.cgi?id=112862

invalid parameter to histogram

Source/Platform:

chromium/public/Platform.h:

Source/WebCore:

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

9:03 PM Changeset in webkit [146560] by dgrogan@chromium.org

4 edits in trunk/Source

IndexedDB: Histogram available disk space on attempt to open database
https://bugs.webkit.org/show_bug.cgi?id=112862

Reviewed by Adam Barth.

Source/Platform:

chromium/public/Platform.h:

(WebKit::Platform::availableDiskSpaceInBytes):
(Platform):

Source/WebCore:

No new tests - I don't know of a good way to test histograms. Local
printf testing didn't turn up any bugs.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::HistogramFreeSpace):
(WebCore):
(WebCore::LevelDBDatabase::open):

8:48 PM Changeset in webkit [146559] by dpranke@chromium.org

6 edits in trunk/Tools

nrwt is no longer saving retry results in the retries/ subdirectory
https://bugs.webkit.org/show_bug.cgi?id=112995

Reviewed by Ojan Vafai.

I think this has been broken a long time, unfortunately. This
patch should fix that.

In order to do so, I had to pass the directory to use from
the Worker object through the SingleTestWriter to the
TestResultWriter. While I was plumbing that through, I rationalized
the order of the parameter arguments a bit ...

Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(Worker._run_single_test):

Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(run_single_test):
(SingleTestRunner.init):
(SingleTestRunner._run_compare_test):
(SingleTestRunner._run_rebaseline):
(SingleTestRunner._run_reftest):

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(write_test_result):

Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:

(TestResultWriterTest.test_reftest_diff_image):

Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_retrying_uses_retries_directory):

8:12 PM Changeset in webkit [146558] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

Objective-C API: Need a good way to preserve custom properties on JS wrappers
https://bugs.webkit.org/show_bug.cgi?id=112608

Reviewed by Geoffrey Garen.

Currently, we just use a weak map, which means that garbage collection can cause a wrapper to
disappear if it isn't directly exported to JavaScript.

The most straightforward and safe way (with respect to garbage collection and concurrency) is to have
clients add and remove their external references along with their owners. Effectively, the client is
recording the structure of the external object graph so that the garbage collector can make sure to
mark any wrappers that are reachable through either the JS object graph of the external Obj-C object
graph. By keeping these wrappers alive, this has the effect that custom properties on these wrappers
will also remain alive.

The rule for if an object needs to be tracked by the runtime (and therefore whether the client should report it) is as follows:
For a particular object, its references to its children should be added if:

The child is referenced from JavaScript.
The child contains references to other objects for which (1) or (2) are true.

API/JSAPIWrapperObject.mm:

(JSAPIWrapperObjectHandleOwner::finalize):
(JSAPIWrapperObjectHandleOwner::isReachableFromOpaqueRoots): A wrapper object is kept alive only if its JSGlobalObject
is marked and its corresponding Objective-C object was added to the set of opaque roots.
(JSC::JSAPIWrapperObject::visitChildren): We now call out to scanExternalObjectGraph, which handles adding all Objective-C
objects to the set of opaque roots.

API/JSAPIWrapperObject.h:

(JSAPIWrapperObject):

API/JSContext.mm: Moved dealloc to its proper place in the main implementation.

(-[JSContext dealloc]):

API/JSVirtualMachine.h:
API/JSVirtualMachine.mm:

(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(getInternalObjcObject): Helper funciton to get the Objective-C object out of JSManagedValues or JSValues if there is one.
(-[JSVirtualMachine addManagedReference:withOwner:]): Adds the Objective-C object to the set of objects
owned by the owner object in that particular virtual machine.
(-[JSVirtualMachine removeManagedReference:withOwner:]): Removes the relationship between the two objects.
(-[JSVirtualMachine externalObjectGraph]):
(scanExternalObjectGraph): Does a depth-first search of the external object graph in a particular virtual machine starting at
the specified root. Each new object it encounters it adds to the set of opaque roots. These opaque roots will keep their
corresponding wrapper objects alive if they have them.

API/JSManagedReferenceInternal.h: Added.
API/JSVirtualMachine.mm: Added the per-JSVirtualMachine map between objects and the objects they own, which is more formally

known as that virtual machine's external object graph.

API/JSWrapperMap.mm:

(-[JSWrapperMap dealloc]): We were leaking this before :-(
(-[JSVirtualMachine initWithContextGroupRef:]):
(-[JSVirtualMachine dealloc]):
(-[JSVirtualMachine externalObjectGraph]):

API/JSVirtualMachineInternal.h:
API/tests/testapi.mm: Added two new tests using the TinyDOMNode class. The first tests that a custom property added to a wrapper

doesn't vanish after GC, even though that wrapper isn't directly accessible to the JS garbage collector but is accessible through
the external Objective-C object graph. The second test makes sure that adding an object to the external object graph with the same
owner doesn't cause any sort of problems.
(+[TinyDOMNode sharedVirtualMachine]):
(-[TinyDOMNode init]):
(-[TinyDOMNode dealloc]):
(-[TinyDOMNode appendChild:]):
(-[TinyDOMNode numberOfChildren]):
(-[TinyDOMNode childAtIndex:]):
(-[TinyDOMNode removeChildAtIndex:]):

JavaScriptCore.xcodeproj/project.pbxproj:
heap/SlotVisitor.h:

(SlotVisitor):

heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::containsOpaqueRootTriState): Added a new method to SlotVisitor to allow scanExternalObjectGraph to have a
thread-safe view of opaque roots during parallel marking. The set of opaque roots available to any one SlotVisitor isn't guaranteed
to be 100% correct, but that just results in a small duplication of work in scanExternalObjectGraph. To indicate this change for
false negatives we return a TriState that's either true or mixed, but never false.

8:11 PM Changeset in webkit [146557] by li.yin@intel.com

8 edits in trunk

FileAPI: Remove deprecation warning when ArrayBuffer is in Blob constructor.
https://bugs.webkit.org/show_bug.cgi?id=88389

Reviewed by Kenneth Russell.

Source/WebCore:

Spec: http://dev.w3.org/2006/webapi/FileAPI/#dfn-Blob
Both ArrayBuffer and ArrayBufferView should be supported for Blob constructor.

Test: fast/files/blob-constructor.html.

bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append): Remove the deprecated warning.

fileapi/WebKitBlobBuilder.h:

(WebCore):
(BlobBuilder):

LayoutTests:

fast/files/blob-constructor-expected.txt:
fast/files/script-tests/blob-constructor.js:

8:02 PM Changeset in webkit [146556] by tasak@google.com

3 edits
2 adds in trunk

[Shadow]: @host styles are not applied dynamically
https://bugs.webkit.org/show_bug.cgi?id=112869

Reviewed by Elliott Sprehn.

Source/WebCore:

Need to add features of @host @-rules to rule feature set.

Test: fast/dom/shadow/athost-apply-dynamically.html

css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::collectFeaturesTo):

LayoutTests:

fast/dom/shadow/athost-apply-dynamically-expected.html: Added.
fast/dom/shadow/athost-apply-dynamically.html: Added.

8:00 PM Changeset in webkit [146555] by hayato@chromium.org

6 edits
2 adds in trunk

[Shadow] Provide an api of insertionParent().
https://bugs.webkit.org/show_bug.cgi?id=112866

Source/WebCore:

Add insertinParent binding to Element and Text.
It's prefixed (webkitInsertionParent) and guarded by SHADOW_DOM flag.

The bug in the Shadow DOM spec is here:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=21067

Reviewed by Dimitri Glazkov.

Test: fast/dom/shadow/insertion-parent.html

dom/Element.idl:
dom/Node.cpp:

(WebCore::Node::insertionParentForBinding):
(WebCore):

dom/Node.h:

(Node):

dom/Text.idl:

LayoutTests:

Reviewed by Dimitri Glazkov.

fast/dom/shadow/insertion-parent-expected.txt: Added.
fast/dom/shadow/insertion-parent.html: Added.

7:23 PM Changeset in webkit [146554] by rniwa@webkit.org

5 edits in trunk/LayoutTests

Another Mac rebaseline attempt for r146531 since r146538 didn't work.

platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-expected.txt:
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt:

7:02 PM Changeset in webkit [146553] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Test expectations updates.
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=107935
https://bugs.webkit.org/show_bug.cgi?id=109507

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

6:56 PM Changeset in webkit [146552] by mark.lam@apple.com

12 edits in trunk/Source

Source/JavaScriptCore: Fix O(n^{2) op_debug bytecode charPosition to column computation.

https://bugs.webkit.org/show_bug.cgi?id=112957.}

Reviewed by Geoffrey Garen.

The previous algorithm does a linear reverse scan of the source string
to find the line start for any given char position. This results in a
O(n^{2) algortithm when the source string has no line breaks.}

The new algorithm computes a line start column table for a
SourceProvider on first use. This line start table is used to fix up
op_debug's charPosition operand into a column operand when an
UnlinkedCodeBlock is linked into a CodeBlock. The initialization of
the line start table is O(n), and the CodeBlock column fix up is
O(log(n)).

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock): - do column fix up.

interpreter/Interpreter.cpp:

(JSC::Interpreter::debug): - no need to do column fixup anymore.

interpreter/Interpreter.h:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

parser/SourceProvider.cpp:

(JSC::SourceProvider::lineStarts):
(JSC::charPositionExtractor):
(JSC::SourceProvider::charPositionToColumnNumber):

initialize line start column table if needed.
look up line start for the given char position.
parser/SourceProvider.h:

Source/WTF: Introducing String::findNextLineStart().
https://bugs.webkit.org/show_bug.cgi?id=112957.

Reviewed by Geoffrey Garen.

This is replaces String::reverseFindLineTerminator() in the JSC
debugger's code for computing column numbers.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::findNextLineStart):

wtf/text/StringImpl.h:

(WTF::findNextLineStart):

wtf/text/WTFString.h:

(WTF::String::findNextLineStart):

6:39 PM Changeset in webkit [146551] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

[wk2] Page Overlays: Don't create backing store until the client asks us to paint
https://bugs.webkit.org/show_bug.cgi?id=112989
<rdar://problem/13355759>

Reviewed by Anders Carlsson.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
Invalidate the entire overlay on installation, to maintain existing behavior
on platforms where the fade-in animation is not performed by invalidating the overlay.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::installPageOverlay):
Don't invalidate the overlay upon installation.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Create backing store for the page overlay layer the first time it is painted into.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Don't update the size of the page overlay layer unless we intend for it to have backing store.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Don't create backing store when we create the page overlay layer.

6:32 PM Changeset in webkit [146550] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/win

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=112892

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-21
Reviewed by Kentaro Hara.

WebKit.vcproj/WebKitExports.def.in: Added ENABLE(VIDEO_TRACK) guard.

6:26 PM Changeset in webkit [146549] by tsepez@chromium.org

3 edits
2 adds in trunk

Bypass XSSAuditor for asp.net servers.
https://bugs.webkit.org/show_bug.cgi?id=112235

Reviewed by Adam Barth.

Source/WebCore:

Similar to https://bugs.webkit.org/show_bug.cgi?id=81283, but the
fix to that bug failed to cover this particular comma-splicing case.

Test: http/tests/security/xssAuditor/img-tag-with-comma.html

html/parser/XSSAuditor.cpp:

(WebCore::isTerminatingCharacter):
Beware of comma-splicing tricks by stopping at commas.

LayoutTests:

http/tests/security/xssAuditor/img-tag-with-comma-expected.txt: Added.
http/tests/security/xssAuditor/img-tag-with-comma.html: Added.

6:17 PM Changeset in webkit [146548] by fpizlo@apple.com

7 edits in trunk

JSC profiler should have an at-a-glance report of the success of DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::toJS):

profiler/ProfilerCompilation.h:

(JSC::Profiler::Compilation::noticeInlinedGetById):
(JSC::Profiler::Compilation::noticeInlinedPutById):
(JSC::Profiler::Compilation::noticeInlinedCall):
(Compilation):

runtime/CommonIdentifiers.h:

Tools:

Scripts/display-profiler-output:

5:58 PM Changeset in webkit [146547] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Test expectations updates: mark flaky tests; fix overlapping expectations; convert [ Pass Slow ] to [ Slow ].
https://bugs.webkit.org/show_bug.cgi?id=88833
https://bugs.webkit.org/show_bug.cgi?id=93569
https://bugs.webkit.org/show_bug.cgi?id=109507
https://bugs.webkit.org/show_bug.cgi?id=112980
https://bugs.webkit.org/show_bug.cgi?id=112981
https://bugs.webkit.org/show_bug.cgi?id=112984
https://bugs.webkit.org/show_bug.cgi?id=112987
http://crbug.com/24182

Unreviewed, test expectations updates.

platform/chromium/TestExpectations:

5:25 PM Changeset in webkit [146546] by dpranke@chromium.org

3 edits in trunk/Tools

[chromium] Linux ASAN WebKit canary is running out of memory
https://bugs.webkit.org/show_bug.cgi?id=112978

Reviewed by Tony Chang.

Running the AddressSanitizer on a crash takes a lot of
memory, so we should serialize access to it to avoid running
out of memory on a machine.

Scripts/webkitpy/layout_tests/port/chromium.py:

(ChromiumPort._get_crash_log):

Scripts/webkitpy/layout_tests/port/http_lock.py:

(HttpLock.init):
(HttpLock.wait_for_httpd_lock):

5:14 PM Changeset in webkit [146545] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Add Mac baseline after r146510.

platform/mac/svg/custom/marker-orient-auto-expected.png: Added.
platform/mac/svg/custom/marker-orient-auto-expected.txt: Added.

5:14 PM Changeset in webkit [146544] by beidson@apple.com

21 edits in trunk/Source

If a previously loaded resource is later stored to the disk cache, replace the buffer with MMAP'ed memory.
<rdar://problem/13414154> and https://bugs.webkit.org/show_bug.cgi?id=112943

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (No change in behavior.)

Give SharedBuffer the ability to replace its contents from another SharedBuffer:

platform/SharedBuffer.h:
platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer:: tryReplaceContentsWithPlatformBuffer):

Forward along SharedBuffer's new ability to ResourceBuffer:

loader/mac/ResourceBuffer.mm:

(WebCore::ResourceBuffer:: tryReplaceSharedBufferContents):

loader/ResourceBuffer.h:

Give CachedResource the ability to replace its encoded data buffer if appropriate:

loader/cache/CachedResource.cpp:

(WebCore::CachedResource:: tryReplaceEncodedData):

loader/cache/CachedResource.h:

WebCore.exp.in:

Source/WebKit2:

Add a timer that will try to look up the disk cached buffer for the resource a few seconds after the load
completes and - if the resource is disk backed - send it to the WebProcess for sharing:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):
(WebKit::NetworkResourceLoader::diskCacheTimerFired):
(WebKit::NetworkResourceLoader::didReceiveResponse):
(WebKit::NetworkResourceLoader::didReceiveData):
(WebKit::NetworkResourceLoader::didFinishLoading):

NetworkProcess/NetworkResourceLoader.h:

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::tryGetShareableHandleForResource):

Refactor SharedMemory to remove the unnecessary vm_copy and only vm_allocate when an appropriate buffer
doesn't already exist:

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createFromVMBuffer):
(WebKit::SharedMemory::~SharedMemory):

Give ShareableResource the ability to create a CFDataRef that wraps "this", and return it in a SharedBuffer:

Shared/ShareableResource.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):

Shared/ShareableResource.h:

Shared/WebCoreArgumentCoders.cpp: Encode/decode the cache partition for ResourceRequest.

WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):
(WebKit::NetworkProcessConnection::didCacheResource): Lookup the CachedResource in the WebCore memory cache

and try to replace its encoded data with the shared mmap'ed buffer.

WebProcess/Network/NetworkProcessConnection.h:
WebProcess/Network/NetworkProcessConnection.messages.in:

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResource):

5:08 PM Changeset in webkit [146543] by rniwa@webkit.org

4 edits
5 adds in trunk/LayoutTests

[Mac] Add baselines for css3/filters/effect-reference*.html
https://bugs.webkit.org/show_bug.cgi?id=112962

Reviewed by Dean Jackson.

Add Mac rebaselines for the following tests and removed the corresponding entries in TestExpectations.

platform/mac/TestExpectations:
platform/mac/css3/filters/effect-reference-expected.png: Added.
platform/mac/css3/filters/effect-reference-expected.txt:
platform/mac/css3/filters/effect-reference-external-expected.png: Added.
platform/mac/css3/filters/effect-reference-hw-expected.png: Added.
platform/mac/css3/filters/effect-reference-hw-expected.txt:
platform/mac/css3/filters/effect-reference-ordering-expected.png: Added.
platform/mac/css3/filters/effect-reference-ordering-hw-expected.png: Added.

5:04 PM Changeset in webkit [146542] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix, forgot to stage one file.

WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::didChangeScrollOffsetForAnyFrame):
(DrawingArea):

4:58 PM Changeset in webkit [146541] by alokp@chromium.org

2 edits in trunk/LayoutTests

Unreviewed gardening.
Suppressed text failures due to r146531.

platform/chromium/TestExpectations:

4:52 PM Changeset in webkit [146540] by jsbell@chromium.org

4 edits in trunk/Source/WebCore

IndexedDB: Ensure script wrappers can be collected after context is stopped
https://bugs.webkit.org/show_bug.cgi?id=112976

Reviewed by Adam Barth.

ActiveDOMObject::hasPendingActivity is called to see if script wrappers
can be disposed of. Once the script execution context has stopped they
should be free to go - include this in the checks.

No new tests - suggestions welcome.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity): Return false if stopped.
(WebCore::IDBDatabase::stop): Don't bother calling empty super impl.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::hasPendingActivity): Return false if stopped.
(WebCore::IDBRequest::stop): Don't bother calling empty super impl.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::hasPendingActivity): Return false if stopped.
(WebCore::IDBTransaction::stop): Don't bother calling empty super impl.

4:47 PM Changeset in webkit [146539] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

[wk2] Page overlays shouldn't dirty the entire layer when flushing if the main frame can't scroll
https://bugs.webkit.org/show_bug.cgi?id=111662
<rdar://problem/13355808>

Reviewed by Dean Jackson.

Instead of setNeedsDisplay()ing the whole page overlay layer every time through
TCADA::flushLayers, do it at scroll time instead. Repainting on scroll is
necessary to keep things painted in the right place when we scroll (the overlay
is fixed to the size of the view), but is quite wasteful in apps that don’t scroll.

This works with threaded scrolling because overlay installation forces us
into main-thread scrolling mode.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didChangeScrollOffset):
Plumb scroll offset changes through to the drawing area, so it can invalidate the page overlay.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add didChangeScrollOffsetForAnyFrame, for WebFrameLoaderClient to call us back when any frame scrolls.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame):
Invalidate the page overlay when any frame scrolls, so that find indicators in subframes are kept in the right place.
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Stop unconditionally invalidating the page overlay when we flush layers.

4:41 PM Changeset in webkit [146538] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

Mac rebaseline r146531.

platform/mac/compositing/rtl/rtl-fixed-expected.txt: Added.
platform/mac/compositing/rtl/rtl-fixed-overflow-expected.txt: Added.

4:28 PM Changeset in webkit [146537] by commit-queue@webkit.org

37 edits in trunk/Source/WebCore

Remove upcastPointer from ActiveDOMObject constructor
https://bugs.webkit.org/show_bug.cgi?id=112858

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-21
Reviewed by Alexey Proskuryakov.

Removed pesky argument to ActiveDOMObject constructor that is no longer
used.

No new tests (no change in behavior).

Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::BatteryManager):

Modules/filesystem/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::DOMFileSystem):

Modules/filesystem/FileWriter.cpp:

(WebCore::FileWriter::FileWriter):

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::IDBDatabase):

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::IDBRequest):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource):

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::RTCDTMFSender):

Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):

Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp:

(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl):

Modules/mediastream/RTCStatsRequestImpl.cpp:

(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl):

Modules/mediastream/RTCVoidRequestImpl.cpp:

(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl):

Modules/networkinfo/NetworkInfoConnection.cpp:

(WebCore::NetworkInfoConnection::NetworkInfoConnection):

Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):

Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationCenter):

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::SpeechRecognition):

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):

Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):

Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):

css/FontLoader.cpp:

(WebCore::FontLoader::FontLoader):

dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::ActiveDOMObject):

dom/ActiveDOMObject.h:

(ActiveDOMObject):

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::didCreateActiveDOMObject):

dom/ScriptExecutionContext.h:

(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::activeDOMObjects):

fileapi/FileReader.cpp:

(WebCore::FileReader::FileReader):

html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::HTMLMarqueeElement):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):

loader/Prerenderer.cpp:

(WebCore::Prerenderer::Prerenderer):

page/EventSource.cpp:

(WebCore::EventSource::EventSource):

page/SuspendableTimer.cpp:

(WebCore::SuspendableTimer::SuspendableTimer):

workers/AbstractWorker.cpp:

(WebCore::AbstractWorker::AbstractWorker):

workers/WorkerContext.cpp:

(WebCore::WorkerContext::hasPendingActivity):

xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):

3:54 PM Changeset in webkit [146536] by ap@apple.com

8 edits in trunk/Source

[Mac] Move NSOperationQueue out of NetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=112970

Reviewed by Brady Eidson.

WebCore clients do not need explicit control over what queue ResourceHandle works on,
they just want to avoid blocking main thread.

platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::usesAsyncCallbacks): Added. The name doesn't quite match what ResourceHandleMac currently does, but it will very soon.

platform/network/NetworkingContext.h: (WebCore::NetworkingContext::scheduledRunLoopPairs):
platform/network/mac/ResourceHandleMac.mm: (WebCore::operationQueueForAsyncClients): (WebCore::ResourceHandle::start):

3:53 PM Changeset in webkit [146535] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Revert bad change to resize-corner-tracking-transformed-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=112974

In bug 9221, I accidentally overwrite
resize-corner-tracking-transformed-expected.txt with a win/linux
version, which broke Mac. Unfortunately, the gardener didn't realize
this and just added the test to TestExpectations. This change restores
the original expectation to fix mac and removes the test from
TestExpectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Tony Chang.

platform/chromium/TestExpectations:
platform/chromium/fast/css/resize-corner-tracking-transformed-expected.txt:

3:52 PM Changeset in webkit [146534] by commit-queue@webkit.org

15 edits in trunk/Source/WebCore

[V8] Generate specialized callbacks for the main world
https://bugs.webkit.org/show_bug.cgi?id=112430

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-21
Reviewed by Jochen Eisinger.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters of Node,
Element and Document.

No new tests (updated existing binding tests).

bindings/scripts/CodeGeneratorV8.pm:

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedMethod):
(V8DOMConfiguration):

dom/Document.idl:
dom/Element.idl:
dom/Node.idl:

3:50 PM Changeset in webkit [146533] by esprehn@chromium.org

2 edits in trunk/Source/WebCore

Remove RenderObject::canHaveRegionStyle since nothing uses it
https://bugs.webkit.org/show_bug.cgi?id=112973

Reviewed by Eric Seidel.

Nothing uses canHaveRegionStyle so we can remove it.

rendering/RenderObject.h:

3:35 PM Changeset in webkit [146532] by pkasting@chromium.org

17 edits
1 delete in trunk/LayoutTests

[chromium] Minor test expectations updates and some Skia rebaselines.
https://bugs.webkit.org/show_bug.cgi?id=94240
https://bugs.webkit.org/show_bug.cgi?id=104595
https://code.google.com/p/chromium/issues/detail?id=181700
https://code.google.com/p/chromium/issues/detail?id=222382

Unreviewed, gardening.

platform/chromium-linux-x86/platform/chromium/virtual/gpu: Removed.
platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast: Removed.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium/TestExpectations:

3:29 PM Changeset in webkit [146531] by alokp@chromium.org

326 edits
11 copies
6 adds
2 deletes in trunk

Mark GraphicsLayers as opaque when possible
https://bugs.webkit.org/show_bug.cgi?id=70634

Reviewed by Simon Fraser.

Source/WebCore:

Mark layers as opaque in a very simple case - any child renderer has an opaque background and covers the entire composited bounds. It is important to note that since we only consider the background, the only layer that can be marked opaque is the primary GraphicsLayer of a RenderLayer.

Tests: compositing/contents-opaque/background-clip.html

compositing/contents-opaque/background-color.html
compositing/contents-opaque/body-background-painted.html
compositing/contents-opaque/body-background-skipped.html
compositing/contents-opaque/layer-opacity.html
compositing/contents-opaque/layer-transform.html

rendering/RenderBox.cpp:

(WebCore::skipBodyBackground):
(WebCore):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

rendering/RenderBox.h:

(RenderBox):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
(WebCore):
(WebCore::RenderLayer::listBackgroundIsKnownToBeOpaqueInRect):

rendering/RenderLayer.h:

(RenderLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

rendering/RenderLayerModelObject.h:

(RenderLayerModelObject):
(WebCore::RenderLayerModelObject::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

compositing/absolute-inside-out-of-view-fixed-expected.txt:
compositing/backing/no-backing-for-clip-expected.txt:
compositing/backing/no-backing-for-clip-overlap-expected.txt:
compositing/backing/no-backing-for-perspective-expected.txt:
compositing/clip-child-by-non-stacking-ancestor-expected.txt:
compositing/columns/composited-in-paginated-expected.txt:
compositing/contents-opaque/background-clip-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
compositing/contents-opaque/background-clip.html: Added.
compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
compositing/contents-opaque/background-color.html: Added.
compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
compositing/contents-opaque/body-background-painted.html: Added.
compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
compositing/contents-opaque/body-background-skipped.html: Added.
compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
compositing/contents-opaque/layer-opacity.html: Added.
compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
compositing/contents-opaque/layer-transform.html: Added.
compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
compositing/geometry/bounds-ignores-hidden-expected.txt:
compositing/geometry/clip-expected.txt:
compositing/geometry/clip-inside-expected.txt:
compositing/geometry/fixed-position-composited-switch-expected.txt:
compositing/geometry/flipped-writing-mode-expected.txt:
compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
compositing/geometry/limit-layer-bounds-fixed-expected.txt:
compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-expected.txt:
compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-expected.txt:
compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
compositing/geometry/preserve-3d-switching-expected.txt:
compositing/iframes/become-composited-nested-iframes-expected.txt:
compositing/iframes/become-overlapped-iframe-expected.txt:
compositing/iframes/composited-parent-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
compositing/iframes/connect-compositing-iframe-expected.txt:
compositing/iframes/connect-compositing-iframe2-expected.txt:
compositing/iframes/connect-compositing-iframe3-expected.txt:
compositing/iframes/enter-compositing-iframe-expected.txt:
compositing/iframes/iframe-resize-expected.txt:
compositing/iframes/invisible-nested-iframe-hide-expected.txt:
compositing/iframes/invisible-nested-iframe-show-expected.txt:
compositing/iframes/overlapped-iframe-expected.txt:
compositing/iframes/overlapped-iframe-iframe-expected.txt:
compositing/iframes/overlapped-nested-iframes-expected.txt:
compositing/iframes/page-cache-layer-tree-expected.txt:
compositing/iframes/scrolling-iframe-expected.txt:
compositing/layer-creation/animation-overlap-with-children-expected.txt:
compositing/layer-creation/fixed-position-and-transform-expected.txt:
compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
compositing/layer-creation/fixed-position-under-transform-expected.txt:
compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
compositing/layer-creation/overflow-scroll-overlap-expected.txt:
compositing/layer-creation/overlap-animation-clipping-expected.txt:
compositing/layer-creation/overlap-animation-expected.txt:
compositing/layer-creation/overlap-child-layer-expected.txt:
compositing/layer-creation/overlap-clipping-expected.txt:
compositing/layer-creation/overlap-transformed-3d-expected.txt:
compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
compositing/layer-creation/overlap-transformed-layer-expected.txt:
compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
compositing/layer-creation/overlap-transforms-expected.txt:
compositing/layer-creation/spanOverlapsCanvas-expected.txt:
compositing/layer-creation/stacking-context-overlap-expected.txt:
compositing/layer-creation/translatez-overlap-expected.txt:
compositing/masks/mask-layer-size-expected.txt:
compositing/overflow-trumps-transform-style-expected.txt:
compositing/overflow/clip-descendents-expected.txt:
compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
compositing/overflow/textarea-scroll-touch-expected.txt:
compositing/plugins/no-backing-store-expected.txt:
compositing/repaint/invalidations-on-composited-layers-expected.txt:
compositing/rtl/rtl-absolute-expected.txt:
compositing/rtl/rtl-absolute-overflow-expected.txt:
compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
compositing/rtl/rtl-fixed-expected.txt:
compositing/rtl/rtl-fixed-overflow-expected.txt:
compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
compositing/rtl/rtl-iframe-absolute-expected.txt:
compositing/rtl/rtl-iframe-fixed-expected.txt:
compositing/rtl/rtl-iframe-relative-expected.txt:
compositing/rtl/rtl-relative-expected.txt:
compositing/tiled-layers-hidpi-expected.txt:
compositing/tiling/backface-preserve-3d-tiled-expected.txt:
compositing/tiling/crash-reparent-tiled-layer-expected.txt:
compositing/tiling/huge-layer-add-remove-child-expected.txt:
compositing/tiling/huge-layer-with-layer-children-expected.txt:
compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
compositing/tiling/rotated-tiled-clamped-expected.txt:
compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
compositing/tiling/tile-cache-zoomed-expected.txt:
compositing/tiling/tiled-layer-resize-expected.txt:
compositing/visible-rect/2d-transformed-expected.txt:
compositing/visible-rect/3d-transform-style-expected.txt:
compositing/visible-rect/3d-transformed-expected.txt:
compositing/visible-rect/animated-expected.txt:
compositing/visible-rect/animated-from-none-expected.txt:
compositing/visible-rect/clipped-by-viewport-expected.txt:
compositing/visible-rect/clipped-visible-rect-expected.txt:
compositing/visible-rect/iframe-and-layers-expected.txt:
compositing/visible-rect/iframe-no-layers-expected.txt:
compositing/visible-rect/nested-transform-expected.txt:
compositing/visible-rect/scrolled-expected.txt:
css3/filters/filtered-compositing-descendant-expected.txt:
platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-linux/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium-linux/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium-linux/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/iframe-resize-expected.txt:
platform/chromium-linux/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium-linux/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-linux/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium-linux/compositing/iframes/resizer-expected.txt:
platform/chromium-linux/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-resize-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/overlapped-iframe-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/resizer-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/scrolling-iframe-expected.txt: Removed.
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/chromium/TestExpectations:
platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
platform/chromium/compositing/contents-opaque/background-color-expected.txt: Copied from LayoutTests/platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
platform/chromium/compositing/contents-opaque/body-background-painted-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
platform/chromium/compositing/contents-opaque/body-background-skipped-expected.txt: Copied from LayoutTests/platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt.
platform/chromium/compositing/contents-opaque/layer-opacity-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
platform/chromium/compositing/contents-opaque/layer-transform-expected.txt: Copied from LayoutTests/compositing/clip-child-by-non-stacking-ancestor-expected.txt.
platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
platform/chromium/compositing/geometry/clip-expected.txt:
platform/chromium/compositing/geometry/clip-inside-expected.txt:
platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/chromium/compositing/iframes/iframe-resize-expected.txt:
platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
platform/chromium/compositing/iframes/resizer-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
platform/chromium/compositing/overflow/clip-descendents-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
platform/chromium/compositing/rtl/rtl-relative-expected.txt:
platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
platform/mac/compositing/iframes/resizer-expected.txt:
platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt:
platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt:
platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt:
platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt: Removed.
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:

3:29 PM Changeset in webkit [146530] by roger_fong@apple.com

134 edits
10 moves in trunk

Move common props files for VS2010 solution to WebKitLibraries folder and update all projects accordingly.

WebKit.vcxproj/FeatureDefines.props: Removed.
WebKit.vcxproj/FeatureDefinesCairo.props: Removed.
WebKit.vcxproj/WebKit/cURL.props: Removed.
WebKit.vcxproj/WinCairo.props: Removed.
WebKit.vcxproj/common.props: Removed.
WebKit.vcxproj/debug.props: Removed.
WebKit.vcxproj/debug_wincairo.props: Removed.
WebKit.vcxproj/debugsuffix.props: Removed.
WebKit.vcxproj/production.props: Removed.
WebKit.vcxproj/release.props: Removed.
win/tools/vsprops/FeatureDefines.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefines.props.
win/tools/vsprops/FeatureDefinesCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/FeatureDefinesCairo.props.
win/tools/vsprops/WinCairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/WinCairo.props.
win/tools/vsprops/cURL.props: Copied from ../Source/WebKit/WebKit.vcxproj/WebKit/cURL.props.
win/tools/vsprops/common.props: Copied from ../Source/WebKit/WebKit.vcxproj/common.props.
win/tools/vsprops/debug.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug.props.
win/tools/vsprops/debug_wincairo.props: Copied from ../Source/WebKit/WebKit.vcxproj/debug_wincairo.props.
win/tools/vsprops/debugsuffix.props: Copied from ../Source/WebKit/WebKit.vcxproj/debugsuffix.props.
win/tools/vsprops/production.props: Copied from ../Source/WebKit/WebKit.vcxproj/production.props.
win/tools/vsprops/release.props: Copied from ../Source/WebKit/WebKit.vcxproj/release.props.

3:17 PM Changeset in webkit [146529] by Alexandru Chiculita

17 edits
2 copies
3 adds in trunk

[CSS Shaders] Implement a StyleCustomFilterProgram cache
https://bugs.webkit.org/show_bug.cgi?id=112602

Reviewed by Dean Jackson.

Source/WebCore:

When the style is recalculated, the new computed RenderStyle is saved as the m_style of the
RenderObject, even if the style was not different.

In the case of Custom Filters, a new StyleCustomFilterProgram was created at all times, but the
actual equality check was done by comparing the pair of cached shaders from inside the StyleCustomFilterProgram.

Because of that the RenderLayer::styleChanged was not called when the new StyleCustomFilterProgram was created, so it
will end up still knowing only about the previous StyleCustomFilterProgram.

The RenderLayer sets itself as a client of the StyleCustomFilterProgram, so that it can repaint itself
when the program is loaded, but because RenderLayer::styleChanged is not called, it will not add itself as a client of the new
StyleCustomFilterProgram.

StyleCustomFilterProgram waits until the first client to load the programs, so in this case it will just remain unloaded.

There was no crash, but just an assert in debug mode. Also, as a visible side-effect some frames were rendered using blank shaders,
resulting in a pass-through filter.

The fix would be to actually make the RenderStyle::diff detect the change of the StyleCustomFilterProgram
using the pointer value and not the values. However, that will always invalidate the "filter" property because
of the StyleCustomFilterProgram that always gets created during the recalculation time.

I've added StyleCustomFilterProgramCache to cache all the instances of the StyleCustomFilterPrograms that a
StyleResolver allocates. This way, next time it will try to reuse previously allocated StyleCustomFilterPrograms.
The key of the cache is the CustomFilterProgramInfo, that combines the URLs to the shaders and a couple of other program settings.

StyleCustomFilterProgramCache is owned by the StyleResovler and StyleCustomFilterPrograms are responsible with
removing themselves from the cache when the last reference goes away.

This change makes the previous "platform level" program cache obsolete and I will remove that in a future patch.
https://bugs.webkit.org/show_bug.cgi?id=112844

Test: css3/filters/custom/custom-filter-reload.html

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/StyleResolver.cpp:

(WebCore::StyleResolver::lookupCustomFilterProgram): Lookup any similar programs in the cache. It will create a new pending
StyleCustomFilterProgram if there is no pre-cached version of the program.
if no program is found. loadPendingShaders is responsible for adding the program in the cache if it is actually going to be used.
(WebCore::StyleResolver::loadPendingShaders): At this point the program is final, so it's safe to add it to the cache.
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

css/StyleResolver.h:

(StyleResolver):

css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::completeURL): Factored out the function to compute the complete URL of the resource.
(WebCore::WebKitCSSShaderValue::cachedShader):

css/WebKitCSSShaderValue.h:

(WebCore::toWebKitCSSShaderValue):
(WebKitCSSShaderValue):

platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::blend):

platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::operator==): Removed. Programs should now compare by pointer. Kept it as
private to catch any potential use of it.

rendering/style/StyleCustomFilterProgram.cpp: Copied from Source/WebCore/css/WebKitCSSShaderValue.h.

(WebCore::StyleCustomFilterProgram::~StyleCustomFilterProgram): Destructor removes the program from the cache.

rendering/style/StyleCustomFilterProgram.h:

(WebCore::StyleCustomFilterProgram::setVertexShader): Added an assert to check that the shader is not in the
cache while the mutation happens. Otherwise the cache might have the wrong key.
(WebCore::StyleCustomFilterProgram::setFragmentShader): Ditto.
(WebCore::StyleCustomFilterProgram::isLoaded): Added more asserts to catch cases when the program is used with no clients.
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::hasPendingShaders):
(WebCore::StyleCustomFilterProgram::inCache):
(WebCore::StyleCustomFilterProgram::setCache): Function called when a program is added to / removed from the cache.
(WebCore::StyleCustomFilterProgram::vertexShaderURL): Added methods to store the KURL that we used as keys in the cache.
The same KURLs will be used to lookup and remove the filter at the end.
(WebCore::StyleCustomFilterProgram::setVertexShaderURL):
(WebCore::StyleCustomFilterProgram::fragmentShaderURL):
(WebCore::StyleCustomFilterProgram::setFragmentShaderURL):
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram):

rendering/style/StyleCustomFilterProgramCache.cpp: Added.

(WebCore::StyleCustomFilterProgramCache::programCacheKey):
(WebCore::StyleCustomFilterProgramCache::StyleCustomFilterProgramCache):
(WebCore::StyleCustomFilterProgramCache::~StyleCustomFilterProgramCache): Destructor removes itself from all the
referenced StyleCustomFilterPrograms. This is to avoid issues with different destruction orders.
(WebCore::StyleCustomFilterProgramCache::lookup):
(WebCore::StyleCustomFilterProgramCache::add):
(WebCore::StyleCustomFilterProgramCache::remove):

rendering/style/StyleCustomFilterProgramCache.h:

(StyleCustomFilterProgramCache):

platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:

(WebCore::CoordinatedCustomFilterProgram::operator==: Removed. Programs should now compare by pointer.

LayoutTests:

Added a new test to check for the case when the style is recalculated but the
filter property is not changed. All the other cases for the new StyleCustomFilterProgramCache
class should be tested by existing tests.

css3/filters/custom/custom-filter-reload-expected.txt: Added.
css3/filters/custom/custom-filter-reload.html: Added.

3:11 PM Changeset in webkit [146528] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Last paragraph can't be selected by touch hold selection if there is no new line after it in subframe.
https://bugs.webkit.org/show_bug.cgi?id=112966

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-21
Reviewed by Rob Buis.

PR 312044
Reviewed Internally By Genevieve Mak.

If selection reaches the bottom of content, ignore scroll margin
so the text on the bottom can be selected.
Stop expanding selection only if the end of document is selected
or touch is released.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

2:53 PM Changeset in webkit [146527] by jsbell@chromium.org

5 edits in trunk/Source/WebCore

IndexedDB: Ensure all API methods have IDB_TRACE macros
https://bugs.webkit.org/show_bug.cgi?id=112963

Reviewed by Tony Chang.

Anntotate methods and callbacks that weren't already annotated
with IDB_TRACE macros to assist in debugging, e.g. when using
the chromium port's chrome://tracing visualization.

No new tests - just harmless diagnostic sprinkles.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore): Added IDB_TRACE macro call here.
(WebCore::IDBDatabase::deleteObjectStore): ...and here.
(WebCore::IDBDatabase::transaction): ...etc.
(WebCore::IDBDatabase::close):
(WebCore::IDBDatabase::onVersionChange):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::deleteDatabase):
(WebCore::IDBFactoryBackendImpl::open):

Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onBlocked):

2:52 PM Changeset in webkit [146526] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] addSearchProvider shouldn't match the full host, only the server
https://bugs.webkit.org/show_bug.cgi?id=112960

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-03-21
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.

Remove full host matching. only check if domains are from the same server.

Also, check user gesture before dispatching the addSearchProvider event to the browser.

WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addSearchProvider):
(WebCore::ChromeClientBlackBerry::isSearchProviderInstalled):

WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

WebCoreSupport/ExternalExtension.cpp:

(IsSearchProviderInstalledMethod):

2:51 PM Changeset in webkit [146525] by jochen@chromium.org

2 edits in trunk/LayoutTests

Skip triaged crashes on content shell

Unreviewed gardening

platform/chromium/ContentShellTestExpectations:

2:49 PM Changeset in webkit [146524] by rniwa@webkit.org

2 edits in trunk/Websites/bugs.webkit.org

EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=112964

Reviewed by Philip Rogers.

Increased the width from 500px to 600px so that all bubbles fit.

template/en/custom/attachment/list.html.tmpl:

2:47 PM Changeset in webkit [146523] by tkent@chromium.org

2 edits in trunk/LayoutTests

fast/frames/detach-frame-during-focus.html fails on some platforms
https://bugs.webkit.org/show_bug.cgi?id=112904

fast/frames/detach-frame-during-focus.html:

Do not run the test sequence twice.

2:37 PM Changeset in webkit [146522] by commit-queue@webkit.org

3 edits
2 adds in trunk

http://trac.webkit.org/changeset/146375 causing CrOS crashes
https://bugs.webkit.org/show_bug.cgi?id=112958

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Test: fast/flexbox/crash-anonymous-box.html

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Anonymous renderers don't have a node in their constructor, so
don't get document() in there.

LayoutTests:

fast/flexbox/crash-anonymous-box-expected.txt: Added.
fast/flexbox/crash-anonymous-box.html: Added.

2:30 PM Changeset in webkit [146521] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

[chromium] Add possibleUserNames to WebPasswordFormData
https://bugs.webkit.org/show_bug.cgi?id=112375

Patch by Garrett Casto <gcasto@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

public/WebPasswordFormData.h:

(WebPasswordFormData):

src/WebPasswordFormData.cpp:

(WebKit::WebPasswordFormData::WebPasswordFormData):

src/WebPasswordFormUtils.cpp:

(WebKit::findPasswordFormFields):

src/WebPasswordFormUtils.h:

(PasswordFormFields):

2:25 PM Changeset in webkit [146520] by mkwst@chromium.org

3 edits
2 adds in trunk

CSP 1.1: Fire a SecurityPolicyViolationEvent when violations occur.
https://bugs.webkit.org/show_bug.cgi?id=112783

Reviewed by Adam Barth.

Source/WebCore:

A new event type for Content Security Policy violations landed in
http://wkrev.com/146305; this patch takes that stub, and wires it up to
ContentSecurityPolicy::reportViolation such that violation events fire
when resources are blocked.

This should bring WebKit up to date with the current description of
CSP's event model in sections 3.3[1] and 3.4.1.3[2] of the editor's
draft.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model
[2]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#firing-events-using-the-securitypolicyviolationevent-interface

Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html

page/ContentSecurityPolicy.cpp:

(WebCore::gatherSecurityPolicyViolationEventData):

Populate a SecurityPolicyViolationEventInit object with the various
bits of data that should be passed into the event constructor.

This static method is strictly an implementation detail; it's not
part of ContentSecurityPolicy's public API.

(WebCore::ContentSecurityPolicy::reportViolation):

Regardless of whether the policy has set a 'report-uri' directive
or not, gather together all the data we'll need to fire an event,
create the event, and queue it up for dispatching on the Document.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html: Added.

2:22 PM Changeset in webkit [146519] by tdanderson@chromium.org

8 edits in trunk/Source

[chromium] Remove SK_SUPPORT_HINTING_SCALE_FACTOR flag and code
https://bugs.webkit.org/show_bug.cgi?id=112928

Reviewed by Stephen White.

This flag was only for ChromeOS builds with HighDPI. It is no longer needed and can be removed.
See http://crbug.com/17550

Source/WebCore:

No new tests needed since this is just removing unused code.

platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp:

(WebCore::OpaqueRectTrackingContentLayerDelegate::paintContents):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::PlatformContextSkia):
(WebCore::PlatformContextSkia::setupPaintCommon):

platform/graphics/skia/PlatformContextSkia.h:

Source/WebKit/chromium:

features.gypi:
tests/OpaqueRectTrackingContentLayerDelegateTest.cpp:
tests/PlatformContextSkiaTest.cpp:

2:16 PM Changeset in webkit [146518] by timothy@apple.com

14 edits in trunk/Source/WebKit2

Support connecting the Web Inspector without showing it.

This allows you to get the debugger attached in the background. When a breakpoint is hit
the Inspector will open. This change also reduces some WebProcess messaging by removing
the DidLoadInspectorPage message and stops sending the SetAttachedWindow message on close.

https://bugs.webkit.org/show_bug.cgi?id=112445

Reviewed by Sam Weinig.

UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsConnected): Added.
(WKInspectorConnect): Added.
(WKInspectorHide): Added.

UIProcess/API/C/WKInspector.h:

Added new APIs.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::WebInspectorProxy):
Initialize new state booleans.

(WebKit::WebInspectorProxy::invalidate):
Don't set state booleans that didClose already resets.

(WebKit::WebInspectorProxy::connect): Added.
(WebKit::WebInspectorProxy::show):
Open if we are already connected. Call connect().

(WebKit::WebInspectorProxy::hide): Added.

(WebKit::WebInspectorProxy::close):
Call didClose we can detach or close the window immediately instead of waiting for a
message from the WebProcess.

(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
Check for !m_page to match other functions.

(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::didLoadInspectorPage):
Removed. Moved logic to open().

(WebKit::WebInspectorProxy::open): Added.

(WebKit::WebInspectorProxy::didClose):
Clear new state booleans. Don't perform work again if already closed. Use platformDetach()
instead of detach() to avoid sending the SetAttachedWindow message.

(WebKit::WebInspectorProxy::bringToFront):
Call open() if we are not visible yet, otherwise platformBringToFront.

UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isConnected): Added.

UIProcess/WebInspectorProxy.messages.in: Removed DidLoadInspectorPage.

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformHide): Added stub.

UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformHide): Added.

UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformHide): Added stub.

WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

Removed frontendLoaded().

WebProcess/WebPage/WebInspector.cpp:
WebProcess/WebPage/WebInspector.h:

Removed didLoadInspectorPage().

2:02 PM Changeset in webkit [146517] by commit-queue@webkit.org

2 edits in trunk/Tools

Cleanup android media layout test code
https://bugs.webkit.org/show_bug.cgi?id=112944

Patch by Min Qin <qinmin@chromium.org> on 2013-03-21
Reviewed by Adam Barth.

Chromium change: https://codereview.chromium.org/12892010/
The current android layout tests are using WebmediaPlayerInProcessAndroid class.
The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
Instead, we should switch to use content shell for layout tests.

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::resetTestController):

2:02 PM Changeset in webkit [146516] by mkwst@chromium.org

54 edits in trunk

Drop full URLs from cross-origin access errors caused by protocol mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112894

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112813, this patch brings protocol
mismatch errors into line with the new origin-only hotness. The message
is also changed to display the URL's protocol rather than the origin's
protocol: it makes a big difference for 'data:' URLs, for instance.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
http/tests/security/cross-frame-access-protocol-expected.txt:
http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
http/tests/security/view-source-no-javascript-url-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
http/tests/security/xssAuditor/full-block-base-href-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-subframe-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-subframe-location-change-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-in-foreign-domain-window-open-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
platform/chromium/http/tests/security/inactive-document-with-empty-security-origin-expected.txt:
platform/chromium/http/tests/security/window-named-proto-expected.txt:

1:57 PM Changeset in webkit [146515] by schenney@chromium.org

3 edits
2 adds in trunk

SVG text path referencing parent text infinite loops
https://bugs.webkit.org/show_bug.cgi?id=112078

Reviewed by Philip Rogers.

Source/WebCore:

We do not check the target type when adding a resource reference for
SVG Text Path's URI. This goes horribly wrong when the target is the
text path's parent text element. In this patch we check that the target
element of the text path is indeed a path element, as the spec
requires. No other element type is allowed.

Note that RenderSVGTextPath enforces this check in the renderer code
also, so if we get past this check via pending resources, it doesn't
matter. You can't get into this situation with a pending reference
because, by definition, the parent must be defined before the text
path child.

Test: svg/text/textpath-referencing-text-crash.svg

svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

LayoutTests:

svg/text/textpath-referencing-text-crash-expected.txt: Added.
svg/text/textpath-referencing-text-crash.svg: Added.

1:56 PM Changeset in webkit [146514] by dpranke@chromium.org

2 edits in trunk/Tools

[chromium] add missing project dependencies to DRT to fix Mac Valgrind
https://bugs.webkit.org/show_bug.cgi?id=112953

Reviewed by Tony Chang.

When I created the DumpRenderTree_resources target in r144863 I
forgot to declare the needed dependencies on the other resource
targets. Due to a quirk of ordering, this appears to have been fine
w/ ninja but not w/ Xcode (which is still being used on the chromium
mac valgrind bots). Declaring the dependencies fixes the build
failures.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

1:53 PM Changeset in webkit [146513] by ap@apple.com

2 edits in trunk/Source/WebKit2

Build fix.

NetworkProcess/mac/NetworkResourceLoaderMac.mm: Include CurrentTime.h, as needed to call currentTime().

1:49 PM Changeset in webkit [146512] by pilgrim@chromium.org

2 edits in trunk/Source/Platform

[Chromium] Removed unused WEBKIT_USE_NEW_WEBFILESYSTEMTYPE flag
https://bugs.webkit.org/show_bug.cgi?id=112931

Reviewed by Adam Barth.

Migration complete; flag no longer needed.

chromium/public/WebFileSystemType.h:

1:43 PM Changeset in webkit [146511] by jsbell@chromium.org

14 edits in trunk/Source

IndexedDB: Remove onVersionChange(string) plumbing
https://bugs.webkit.org/show_bug.cgi?id=112712

Reviewed by Adam Barth.

Source/WebCore:

Delete unused onVersionChange(string) overload.

No new tests - just deleting dead code.

Modules/indexeddb/IDBDatabase.cpp: Delete onVersionChange(string) overload.
Modules/indexeddb/IDBDatabase.h: Ditto.
Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Ditto.
Modules/indexeddb/IDBDatabaseCallbacks.h: Ditto.
Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp: Ditto.
Modules/indexeddb/IDBDatabaseCallbacksImpl.h: Ditto.

Source/WebKit/chromium:

public/WebIDBDatabaseCallbacks.h: Remove onVersionChange(string) overload.
src/IDBDatabaseCallbacksProxy.cpp: Ditto.
src/IDBDatabaseCallbacksProxy.h: Ditto.
src/WebIDBDatabaseCallbacksImpl.cpp: Ditto.
src/WebIDBDatabaseCallbacksImpl.h: Ditto.
tests/IDBAbortOnCorruptTest.cpp: Ditto.
tests/IDBDatabaseBackendTest.cpp: Ditto.

1:35 PM Changeset in webkit [146510] by pdr@google.com

4 edits
3 adds in trunk

Correct bisector angle calculation for markers
https://bugs.webkit.org/show_bug.cgi?id=112054

Reviewed by Stephen Chenney.

Source/WebCore:

The SVG marker spec states that mid markers with orient=auto should be aligned with their
x-axis along the bisector of the incoming (in) and outgoing (out) angles. Previously we
calculated this bisector angle as:

bisector = (in + out) / 2;

Angles cannot be averaged this way! Consider in=90deg and out=-180deg: the bisector should
be 135deg but a naive average gives -45deg. This patch corrects for the discontinuity in
angle values with:

bisector = (in + out + 360) / 2 if |in - out| > 180
bisector = (in + out) / 2 otherwise

This patch includes an exhaustive test of angle values.

Test: svg/custom/marker-orient-auto.html

rendering/svg/SVGMarkerData.h:

(WebCore::SVGMarkerData::currentAngle):

LayoutTests:

platform/chromium-linux/svg/custom/marker-orient-auto-expected.png: Added.
platform/chromium-linux/svg/custom/marker-orient-auto-expected.txt: Added.
platform/chromium/TestExpectations:
svg/custom/marker-orient-auto.html: Added.

1:28 PM Changeset in webkit [146509] by commit-queue@webkit.org

6 edits in trunk

Expose the Type field of an RTCStatsReport
https://bugs.webkit.org/show_bug.cgi?id=112951

Patch by Harald Alvestrand <hta@google.com> on 2013-03-21
Reviewed by Adam Barth.

Source/WebCore:

Covered by an extension of an existing test.

Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::type):

Modules/mediastream/RTCStatsReport.idl:

LayoutTests:

fast/mediastream/RTCPeerConnection-stats-expected.txt:
fast/mediastream/RTCPeerConnection-stats.html:

1:27 PM Changeset in webkit [146508] by ap@apple.com

11 edits
1 add in trunk/Source/WebCore

Move non-trivial virtual functions out of ResourceHandleClient.h
https://bugs.webkit.org/show_bug.cgi?id=112950

Reviewed by Brady Eidson.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/network/ResourceHandleClient.cpp: Added. (WebCore::ResourceHandleClient::ResourceHandleClient): (WebCore::ResourceHandleClient::~ResourceHandleClient): (WebCore::ResourceHandleClient::didReceiveBuffer): (WebCore::ResourceHandleClient::getBuffer):
platform/network/ResourceHandleClient.h:

1:19 PM Changeset in webkit [146507] by bfulgham@webkit.org

2 edits in trunk/Tools

[WinCairo] Correct assert in Empty BitmapImage Test.
https://bugs.webkit.org/show_bug.cgi?id=112934

Reviewed by Tim Horton.

TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:

(TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
to avoid ref counting assertion when leaving test scope.

1:11 PM Changeset in webkit [146506] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Windows rebaseline after r146469.

platform/win/css3/filters/effect-reference-expected.txt:
platform/win/css3/filters/effect-reference-hw-expected.txt:

1:06 PM Changeset in webkit [146505] by mark.lam@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.

Reviewed by Michael Saboff.

Changed the Lexer to no longer keep a m_charPosition. Instead, we compute
currentCharPosition() from m_code and m_codeStartPlusOffset, where
m_codeStartPlusOffset is the SourceProvider m_codeStart + the SourceCode
start offset. This ensures that the charPosition is always in sync with
m_code.

parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

parser/Lexer.h:

(JSC::Lexer::currentCharPosition):
(JSC::::lexExpectIdentifier):

1:05 PM Changeset in webkit [146504] by zandobersek@gmail.com

2 edits in trunk/Tools

[GTK] generate-feature-defines-files is incompatible with Python3
https://bugs.webkit.org/show_bug.cgi?id=112956

Reviewed by Martin Robinson.

Make the generate-feature-defines-files compatible with Python3 by calling the items()
method on the dictionary objects when iterating through said dictionaries.

gtk/generate-feature-defines-files:

(write_feature_defines_header):
(write_flattened_feature_defines_file):

1:03 PM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

1:02 PM Changeset in webkit [146503] by fmalita@chromium.org

13 edits
1 delete in trunk/Source/WebCore

[SVG] Remove explicit LightSource dispatchers
https://bugs.webkit.org/show_bug.cgi?id=112827

Reviewed by Stephen Chenney.

Convert LightSource setters to dynamic dispatch. This allows us to remove LightSource.cpp
altogether.

No new tests: refactoring only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/filters/DistantLightSource.h:

(DistantLightSource):

platform/graphics/filters/LightSource.cpp: Removed.
platform/graphics/filters/LightSource.h:

(WebCore::LightSource::setAzimuth):
(WebCore::LightSource::setElevation):
(WebCore::LightSource::setX):
(WebCore::LightSource::setY):
(WebCore::LightSource::setZ):
(WebCore::LightSource::setPointsAtX):
(WebCore::LightSource::setPointsAtY):
(WebCore::LightSource::setPointsAtZ):
(WebCore::LightSource::setSpecularExponent):
(WebCore::LightSource::setLimitingConeAngle):

platform/graphics/filters/PointLightSource.h:

(PointLightSource):

platform/graphics/filters/SpotLightSource.h:

(SpotLightSource):

12:55 PM Changeset in webkit [146502] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[BlackBerry] GCActivityCallback: replace JSLock with JSLockHolder
https://bugs.webkit.org/show_bug.cgi?id=112448

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

This changed in r121381.

runtime/GCActivityCallbackBlackBerry.cpp:

(JSC::DefaultGCActivityCallback::doWork):

12:51 PM Changeset in webkit [146501] by igor.o@sisa.samsung.com

2 edits in trunk/Source/WebCore

[Texmap] Implement support for OpenGLES EXT_unpack_subimage extension
https://bugs.webkit.org/show_bug.cgi?id=108716

If the extension GL_EXT_unpack_subimage is supported, it adds GL_UNPACK_ROW_LENGTH,
GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS as valid enums to PixelStore.

Reviewed by Noam Rosenthal.

platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):

12:42 PM Changeset in webkit [146500] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Regression: drawer resizes slowly with animation.
https://bugs.webkit.org/show_bug.cgi?id=112920

Drawer status bar opacity wasn't set to zero on inialization, so no transition event
was fired on first time drawer appeared,thus animation styles wasn't removed properly.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-21
Reviewed by Vsevolod Vlasov.

inspector/front-end/Drawer.js:

(WebInspector.Drawer):

12:36 PM Changeset in webkit [146499] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsLayer: fix code that was accidentally reverted
https://bugs.webkit.org/show_bug.cgi?id=112143

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

Several changes were accidentally reverted in r144465 due to the
upstreaming of some new code:

clearBackgroundColor() and m_contentsLayerHasBackgroundColor had been removed in r137798.

showDebugBorders() had been renamed to isShowingDebugBorder() in r133517.

A new GraphicsLayer::create() overload had been introduced in r130185.

This patch fixes them all.

platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:

(WebCore::GraphicsLayer::create):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

platform/graphics/blackberry/GraphicsLayerBlackBerry.h:

(GraphicsLayerBlackBerry):

12:25 PM Changeset in webkit [146498] by zandobersek@gmail.com

6 edits
1 add in trunk

[GTK] Move libLevelDB.la setup into a separate GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=112947

Reviewed by Martin Robinson.

GNUmakefile.am: Include the new GNUmakefile.am, located under Source/ThirdParty/leveldb.

Source/ThirdParty:

leveldb/GNUmakefile.am: Added, sets up the libLevelDB.la library.

Source/WebCore:

No new tests - no new functionality.

GNUmakefile.am: Move the libLevelDD.la setup into the new GNUmakefile.am that's placed in

the third-party leveldb source directory.

GNUmakefile.list.am: Move the LevelDB sources listing there as well.

12:25 PM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos

(diff)

12:23 PM WebKitGTK/AddingNewWebKit2API edited by Carlos Garcia Campos

(diff)

12:22 PM Changeset in webkit [146497] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] DrawingBuffer: add clearPlatformLayer() implementation
https://bugs.webkit.org/show_bug.cgi?id=112696

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Rob Buis.

DrawingBuffer::clearPlatformLayer() was added in r139142.

This is not needed in the BlackBerry port, so this patch only
contains a dummy implementation.

platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:

(WebCore):
(WebCore::DrawingBuffer::clearPlatformLayer):

12:19 PM Changeset in webkit [146496] by rniwa@webkit.org

2 edits in trunk/Tools

kill-old-processes spits out error messages on Mac
https://bugs.webkit.org/show_bug.cgi?id=112878

Reviewed by Jessie Berlin.

Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
included in the list of options grep --help shows.

Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.

BuildSlaveSupport/kill-old-processes:

(main):

12:14 PM Changeset in webkit [146495] by fmalita@chromium.org

15 edits
2 adds in trunk

[SVG] Suppress painting when an empty viewBox is specified
https://bugs.webkit.org/show_bug.cgi?id=112623

Reviewed by Philip Rogers.

Source/WebCore:

Per spec, elements with an empty viewBox should not be rendered:
http://www.w3.org/TR/SVG/coords.html#ViewBoxAttribute.

This patch adds the missing viewBox checks to RenderSVGRoot, RenderSVGViewPortContainer,
RenderSVGResourceMarker and RenderSVGResourceMarker's paint methods.

In order to detect the case of "viewBox present but invalid", the patch also introduces
SVGAnimatedProperty plumbing for tracking property validity: the baseVal setter now takes
an additional optional 'validValue' boolean parameter, which can later be queried via a
macroed getter (LowerProperty##IsValid()).

Test: svg/custom/viewBox-empty.html

rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::draw):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::paint):
(WebCore):

rendering/svg/RenderSVGViewportContainer.h:

(RenderSVGViewportContainer):

svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::hasEmptyViewBox):
(SVGSVGElement):
Suppress painting if a valid empty viewBox is found.

svg/SVGFitToViewBox.h:

(WebCore::SVGFitToViewBox::parseAttribute):
Mark the viewBox property as invalid if not successfully parsed.

svg/SVGExternalResourcesRequired.h:

(SVGExternalResourcesRequired):

svg/SVGURIReference.h:

(SVGURIReference):

svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore::SVGSynchronizableAnimatedProperty::SVGSynchronizableAnimatedProperty):
(SVGSynchronizableAnimatedProperty):
(WebCore):
Plumbing for tracking property value validation.

LayoutTests:

svg/custom/script-tests/svg-viewBox-dynamic.js:
svg/custom/svg-viewBox-dynamic-expected.txt:
svg/custom/viewBox-empty-expected.html: Added.
svg/custom/viewBox-empty.html: Added.

12:09 PM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

12:06 PM Changeset in webkit [146494] by mhahnenberg@apple.com

16 edits
1 move in trunk/Source/JavaScriptCore

Objective-C API: wrapperClass holds a static JSClassRef, which causes JSGlobalObjects to leak
https://bugs.webkit.org/show_bug.cgi?id=112856

Reviewed by Geoffrey Garen.

Through a very convoluted path that involves the caching of prototypes on the JSClassRef, we can leak
JSGlobalObjects when inserting an Objective-C object into multiple independent JSContexts.

API/JSAPIWrapperObject.cpp: Removed.
API/JSAPIWrapperObject.h:

(JSAPIWrapperObject):

API/JSAPIWrapperObject.mm: Copied from Source/JavaScriptCore/API/JSAPIWrapperObject.cpp. Made this an

Objective-C++ file so that we can call release on the wrappedObject. Also added a WeakHandleOwner for
JSAPIWrapperObjects. This will also be used in a future patch for https://bugs.webkit.org/show_bug.cgi?id=112608.
(JSAPIWrapperObjectHandleOwner):
(jsAPIWrapperObjectHandleOwner):
(JSAPIWrapperObjectHandleOwner::finalize): This finalize replaces the old finalize that was done through
the C API.
(JSC::JSAPIWrapperObject::finishCreation): Allocate the WeakImpl. Balanced in finalize.
(JSC::JSAPIWrapperObject::setWrappedObject): We now do the retain of the wrappedObject here rather than in random
places scattered around JSWrapperMap.mm

API/JSObjectRef.cpp: Added some ifdefs for platforms that don't support the Obj-C API.

(JSObjectGetPrivate): Ditto.
(JSObjectSetPrivate): Ditto.
(JSObjectGetPrivateProperty): Ditto.
(JSObjectSetPrivateProperty): Ditto.
(JSObjectDeletePrivateProperty): Ditto.

API/JSValueRef.cpp: Ditto.

(JSValueIsObjectOfClass): Ditto.

API/JSWrapperMap.mm: Remove wrapperClass().

(objectWithCustomBrand): Change to no longer use a parent class, which was only used to give the ability to
finalize wrapper objects.
(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]): Change to no longer use wrapperClass().
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): Ditto.
(tryUnwrapObjcObject): We now check if the object inherits from JSAPIWrapperObject.

API/tests/testapi.mm: Added a test that exports an Objective-C object to two different JSContexts and makes

sure that the first one is collected properly by using a weak JSManagedValue for the wrapper in the first JSContext.

CMakeLists.txt: Build file modifications.
GNUmakefile.list.am: Ditto.
JavaScriptCore.gypi: Ditto.
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Ditto.
JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
runtime/JSGlobalObject.cpp: More ifdefs for unsupported platforms.

(JSC::JSGlobalObject::reset): Ditto.
(JSC::JSGlobalObject::visitChildren): Ditto.

runtime/JSGlobalObject.h: Ditto.

(JSGlobalObject): Ditto.
(JSC::JSGlobalObject::objcCallbackFunctionStructure): Ditto.

11:54 AM Changeset in webkit [146493] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: Hide toolbar customization experimental setting
https://bugs.webkit.org/show_bug.cgi?id=112942

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

inspector/front-end/Settings.js:

(WebInspector.ExperimentsSettings):

inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isToolbarCustomizable):

11:52 AM Changeset in webkit [146492] by senorblanco@chromium.org

10 edits
10 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

New test results for effect-reference and effect-reference-hw.

platform/chromium-linux-x86/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-linux-x86/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-linux/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac-lion/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-mac-lion/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-mac-snowleopard/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-mac/css3/filters/effect-reference-expected.png:
platform/chromium-mac/css3/filters/effect-reference-expected.txt:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.txt:
platform/chromium-win-xp/css3/filters/effect-reference-expected.png: Removed.
platform/chromium-win-xp/css3/filters/effect-reference-expected.txt: Removed.
platform/chromium-win/css3/filters/effect-reference-expected.png:
platform/chromium-win/css3/filters/effect-reference-expected.txt:
platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
platform/chromium-win/css3/filters/effect-reference-hw-expected.txt:
platform/chromium/TestExpectations:

11:52 AM Changeset in webkit [146491] by commit-queue@webkit.org

2 edits in trunk/Tools

[BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
https://bugs.webkit.org/show_bug.cgi?id=112597

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-21
Reviewed by Xan Lopez.

These were introduced for the Chromium port in r105295. We need
dummy implementations in order to compile the BlackBerry port.

DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:

(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

11:45 AM Changeset in webkit [146490] by Claudio Saavedra

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening.

platform/gtk/TestExpectations: Remove redundant entry.

11:26 AM Changeset in webkit [146489] by antonm@chromium.org

22 edits
9 deletes in trunk/Source

Unreviewed, rolling out r146483.
http://trac.webkit.org/changeset/146483
https://bugs.webkit.org/show_bug.cgi?id=111695

Source/JavaScriptCore:

Breaks debug builds.

bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Source/Platform:

Breaks

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):

chromium/public/WebSpeechSynthesisUtterance.h: Removed.
chromium/public/WebSpeechSynthesisVoice.h: Removed.
chromium/public/WebSpeechSynthesizer.h: Removed.
chromium/public/WebSpeechSynthesizerClient.h: Removed.

Source/WebCore:

Breaks

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(WebCore::SpeechSynthesisUtterance::startTime):
(WebCore::SpeechSynthesisUtterance::setStartTime):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
(SpeechSynthesisUtterance):

Modules/speech/SpeechSynthesisVoice.h:

(SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:
platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::client):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore):
(WebCore::PlatformSpeechSynthesizer::speak):

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::create):
(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

11:19 AM Changeset in webkit [146488] by ap@apple.com

2 edits in trunk/Source/WebCore

[Mac] Consolidate bits of willSendRequest implementation
https://bugs.webkit.org/show_bug.cgi?id=112932

Reviewed by Brady Eidson.

Moved some logic from WebCoreResourceHandleAsDelegate to ResourceHandle for clarity.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::willSendRequest): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]):

11:08 AM Changeset in webkit [146487] by danakj@chromium.org

2 edits in trunk/Source/Platform

[chromium] Add isOrphan() to the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=112649

Reviewed by James Robinson.

This method will be used by WebMediaPlayerClientImpl to tell
if the compositing video layer is currently being used to
display the video content or not.

chromium/public/WebLayer.h:

(WebLayer):

11:08 AM Changeset in webkit [146486] by commit-queue@webkit.org

17 edits
2 adds
2 deletes in trunk

Remove AudioGain.idl from compilation.
https://bugs.webkit.org/show_bug.cgi?id=112650

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-03-21
Reviewed by Chris Rogers.

Source/WebCore:

Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#GainNode

https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioBufferSourceNode

AudioParam serves the same purpose as AudioGain. Infact, AudioGain inherits
AudioParam class and doesn't have its own member functions/parameters. Also,
AudioGain is not part of WebAudio W3C specifications.

Test: webaudio/gain-basic.html

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):

Modules/webaudio/AudioBufferSourceNode.h:

(AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::gain):

Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioGain.h: Removed.
Modules/webaudio/AudioGain.idl: Removed.
Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):

Modules/webaudio/GainNode.h:

(WebCore):
(WebCore::GainNode::create):
(GainNode):
(WebCore::GainNode::gain):

Modules/webaudio/GainNode.idl:
Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):

Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::distanceGain):
(WebCore::PannerNode::coneGain):

Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Test to verify GainNode attributes.

webaudio/gain-basic-expected.txt: Added.
webaudio/gain-basic.html: Added.

10:56 AM Changeset in webkit [146485] by roger_fong@apple.com

2 edits in trunk/Tools

Re-enable WinEWS tests following r146376.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

10:31 AM Changeset in webkit [146484] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

10:24 AM Changeset in webkit [146483] by dmazzoni@google.com

21 edits
9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

chromium/public/WebSpeechSynthesisUtterance.h: Added.

chromium/public/WebSpeechSynthesisVoice.h: Added.

chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

platform/mac/PlatformSpeechSynthesizerMac.mm:

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

10:14 AM Changeset in webkit [146482] by jchaffraix@webkit.org

7 edits
4 adds in trunk

[CSS Grid Layout] Properly layout spanning grid items with minmax grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112389

Reviewed by Tony Chang.

Source/WebCore:

This change updates our core minmax resolution function to be spanning grid
items aware. The new implementation of the algorithm doesn't totally match
the specification but it is fairly close that it's a good first pass. The
extra complexity in the specification needs to be carefully examinated
first (not to mention the probable change in the core layout algorithm).

Tests: fast/css-grid-layout/minmax-spanning-resolution-columns.html

fast/css-grid-layout/minmax-spanning-resolution-rows.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated this function to account for spanning grid items by:

iterating over all spanned grid tracks.
removing any used breadth from all spanned grid tracks.

LayoutTests:

fast/css-grid-layout/grid-item-spanning-resolution.html:
fast/css-grid-layout/resources/grid.css:

(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):
Moved the previous classes for maximum reuse.

fast/css-grid-layout/minmax-spanning-resolution-columns-expected.txt: Added.
fast/css-grid-layout/minmax-spanning-resolution-columns.html: Added.
fast/css-grid-layout/minmax-spanning-resolution-rows-expected.txt: Added.
fast/css-grid-layout/minmax-spanning-resolution-rows.html: Added.

New tests.

fast/css-grid-layout/grid-item-change-column-repaint-expected.txt:
fast/css-grid-layout/grid-item-change-row-repaint-expected.txt:

Unintended consistent progression from this change, it's unclear why these baselines
change as the tests involve no spanning.

9:55 AM Changeset in webkit [146481] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

9:51 AM Changeset in webkit [146480] by zoltan@webkit.org

2 edits in trunk/Tools

Unreviewed. Add Bem Jones-Bey to the list of contributors.

Scripts/webkitpy/common/config/committers.py:

9:45 AM Changeset in webkit [146479] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GStreamer] New reference returned by g_main_context_new() must be freed
https://bugs.webkit.org/show_bug.cgi?id=112899

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Fix a memory leak by adopting the new reference returned
by g_main_context_new().

No new tests. No change in behavior.

platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

9:32 AM Changeset in webkit [146478] by commit-queue@webkit.org

4 edits
3 adds in trunk/Source/WebCore

[BlackBerry] Add ScrollingCoordinatorBlackBerry implementation
https://bugs.webkit.org/show_bug.cgi?id=112915

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-03-21
Reviewed by Rob Buis.

PlatformBlackBerry.cmake: Add page/scrolling/blackberry to the

indlude dir list.

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create): Create a
ScrollingCoordinatorBlackBerry for the BlackBerry platform.

page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.cpp: Added.

(WebCore):
(WebCore::ScrollingCoordinatorBlackBerry::ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsContainerForFixedPositionLayers):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerIsFixedToContainerLayer):
(WebCore::ScrollingCoordinatorBlackBerry::setLayerFixedToContainerLayerEdge):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewFrameRectDidChange):
(WebCore::ScrollingCoordinatorBlackBerry::frameViewContentsSizeDidChange):

page/scrolling/blackberry/ScrollingCoordinatorBlackBerry.h: Added.

(WebCore):
(ScrollingCoordinatorBlackBerry):
(WebCore::ScrollingCoordinatorBlackBerry::supportsFixedPositionLayers):

platform/graphics/PlatformLayer.h:

(WebCore): Add PlatformLayer definition for BlackBerry.

9:28 AM Changeset in webkit [146477] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Marking platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup.html as flaky

platform/chromium/TestExpectations:

8:57 AM Changeset in webkit [146476] by caseq@chromium.org

9 edits
1 add in trunk

Web Inspector: Paint rectangles shown on hover over Timeline's paint records occasionally have wrong offsets
https://bugs.webkit.org/show_bug.cgi?id=112371

Reviewed by Pavel Feldman.

Source/WebCore:

pass frame to InspectorTimelineAgent::didPaint();
convert paint coordinates to root view.

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::didPaint):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

LayoutTests:

http/tests/inspector/timeline-test.js:

(initialize_Timeline.InspectorTest.startTimeline.InspectorTest._addTimelineEvent):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addEvent):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):

inspector/timeline/timeline-paint-expected.txt:
inspector/timeline/timeline-paint.html:

8:49 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

8:49 AM Changeset in webkit [146475] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: do not use inspector cookie in InspectorInstrumentation::{will,did}Paint
https://bugs.webkit.org/show_bug.cgi?id=112787

Reviewed by Pavel Feldman.

pass frame, not inspector cookie to InspectorInstrumentation::didPaint;
use frame to determine timeline agent in InspectorInstrumentation::didPaint.

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):

inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):

page/FrameView.cpp:

(WebCore::FrameView::paintContents):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

8:36 AM Changeset in webkit [146474] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [mr] Updated WebKitGTK+ Translation(s) in Marathi [mr] language
https://bugs.webkit.org/show_bug.cgi?id=103035

Patch by Sandeep Shedmake <sshedmak@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

mr.po: updated.

8:30 AM Changeset in webkit [146473] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146463 - [l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

pl.po: Updated.

8:28 AM Changeset in webkit [146472] by Claudio Saavedra

2 edits in trunk/Tools

[GTK] Missing atk in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112272

Reviewed by Gustavo Noronha Silva.

gtk/install-dependencies: Add missing atk dependency.

8:16 AM Changeset in webkit [146471] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Marking http/tests/appcache/abort-cache-ondownloading-resource-404.html as flaky.
Unskipping tests under perf/ to see how they behave.

platform/gtk/TestExpectations:

8:09 AM Changeset in webkit [146470] by jchaffraix@webkit.org

3 edits
2 adds in trunk

[CSS Grid Layout] OOB access in RenderGrid with a grid item with negative position index
https://bugs.webkit.org/show_bug.cgi?id=112853

Reviewed by Tony Chang.

Source/WebCore:

This issue was caused by us casting a negative int to a size_t by mistake. This
would make us not size the grid properly thus yielding to OOB access during the
rest of the layout.

Test: fast/css-grid-layout/grid-item-negative-indexes.html

rendering/RenderGrid.cpp:

(WebCore::estimatedGridSizeForPosition):
Added this helper function to do the proper estimation and checks that our
position can be represented by a size_t.

(WebCore::RenderGrid::maximumIndexInDirection):
Updated to use estimatedGridSizeForPosition.

LayoutTests:

fast/css-grid-layout/grid-item-negative-indexes-expected.txt: Added.
fast/css-grid-layout/grid-item-negative-indexes.html: Added.

7:58 AM Changeset in webkit [146469] by senorblanco@chromium.org

7 edits
1 add in trunk

[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

WebCore.gypi:

Add FEConvolveMatrixSkia.cpp to the build.

platform/graphics/filters/FEConvolveMatrix.h:

Enable the skia accelerated path for feConvolveMatrix.

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:

(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:

Add new test case for feConvolveMatrix as a reference filter.

platform/chromium/TestExpectations:

Suppress failures until the test can be rebaselined.

7:56 AM Changeset in webkit [146468] by commit-queue@webkit.org

5 edits in trunk

Source/ThirdParty/leveldb/db/builder.cc does not build on systems without <endian.h>
https://bugs.webkit.org/show_bug.cgi?id=111817

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva.

Improve processing of the autoconf host variable. Setup up the wiring to detect
whether or not we are compiling for Darwin.

Source/autotools/CheckSystemAndBasicDependencies.m4: Improve host detection.
Source/autotools/SetupAutomake.m4: Tell automake if we are compiling for Darwin or not.

Source/WebCore:

GNUmakefile.am: Add the appropriate flags to the LevelDB build if we are on FreeBSD

or OS X.

7:53 AM Changeset in webkit [146467] by jchaffraix@webkit.org

3 edits
6 adds in trunk

[CSS Grid Layout] Support default grid items sizing
https://bugs.webkit.org/show_bug.cgi?id=103333

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html

fast/css-grid-layout/grid-auto-columns-rows-resolution.html
fast/css-grid-layout/grid-auto-columns-rows-update.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):
Core of the change: return the grid-auto-{rows|columns} instead of a pre-defined value.

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Fixed a latent bug: we need to iterate over the internal grid representation instead of the
style's rows / columns as the latter doesn't account for implicit rows / columns.

LayoutTests:

fast/css-grid-layout/grid-auto-columns-rows-resolution-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-resolution.html: Added.

This test covers the simple implicit column / row case.

fast/css-grid-layout/grid-auto-columns-rows-update-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-update.html: Added.

This test covers that modifying grid-auto-{rows|columns} updates the grid items' sizes.

fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html: Added.

This test covers the implicit rows / columns generated by the auto placement. We are failing
2 sub-tests due to a bug involving percentage grid items in grid rows.

7:46 AM Changeset in webkit [146466] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests.

platform/qt/TestExpectations:

7:43 AM Changeset in webkit [146465] by Claudio Saavedra

2 edits in trunk/Tools

[GTK] Missing backslash in install-dependencies script
https://bugs.webkit.org/show_bug.cgi?id=112907

Reviewed by Philippe Normand.

gtk/install-dependencies: Add missing backslash to dependencies

list.

7:30 AM Changeset in webkit [146464] by abarth@webkit.org

11 edits
1 add in trunk/Source

HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831

Reviewed by Darin Adler.

Source/WebCore:

This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.

WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.

(GenerateStrings):
(GenerateValidateStrings):

dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

createQualifiedName now takes an already-constructed StringImpl object.

dom/QualifiedName.h:
dom/make_names.pl:

(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):

Teach make_names how to use StaticString.pm.

Source/WTF:

wtf/text/StringImpl.h:

(StringImpl):
(StaticASCIILiteral):

This struct lets us construct StringImpl objects at compile time.

(WTF::StringImpl::assertHashIsCorrect):

This function lets us sanity check StringImpl objects created from StaticData.

(WTF::StringImpl::find): Remove a stray ;
(WTF::StringImpl::findIgnoringCase): ditto
(WTF::StringImpl::startsWith): ditto
(WTF::ValueCheck<StringImpl*>):

wtf/text/AtomicStringImpl.h:

(WTF::ValueCheck<AtomicStringImpl*>):

7:09 AM Changeset in webkit [146463] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=100590

Patch by Piotr Drąg <piotrdrag@gmail.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

pl.po: Updated.

6:50 AM Changeset in webkit [146462] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge 146461 - [as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

as.po: Updated.

6:49 AM Changeset in webkit [146461] by kov@webkit.org

2 edits in trunk/Source/WebCore/platform/gtk/po

[as-IN] Translations of WebKitGtk+
https://bugs.webkit.org/show_bug.cgi?id=112791

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-03-21
Reviewed by Gustavo Noronha Silva (kov).

as.po: Updated.

6:43 AM Changeset in webkit [146460] by commit-queue@webkit.org

10 edits
10 adds in trunk/LayoutTests

[EFL] Rebaseline most "needs rebaseline" sections of EFL test expectations, and update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=112901

https://bugs.webkit.org/show_bug.cgi?id=105437
https://bugs.webkit.org/show_bug.cgi?id=65643
https://bugs.webkit.org/show_bug.cgi?id=14664
https://bugs.webkit.org/show_bug.cgi?id=110654

Unreviewed, rebaselining.
Adding failure expectation for the test added in r133834.

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-21

platform/efl/TestExpectations:
platform/efl/css2.1/20110323/replaced-elements-001-expected.txt:
platform/efl/fast/block/float/024-expected.txt:
platform/efl/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
platform/efl/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/efl/svg/css/arrow-with-shadow-expected.txt:
platform/efl/svg/css/clippath-with-shadow-expected.txt:
platform/efl/svg/css/composite-shadow-example-expected.png: Added.
platform/efl/svg/css/composite-shadow-example-expected.txt: Added.
platform/efl/svg/css/composite-shadow-with-opacity-expected.png: Added.
platform/efl/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/efl/svg/custom/feDisplacementMap-01-expected.png: Added.
platform/efl/svg/custom/feDisplacementMap-01-expected.txt: Added.
platform/efl/svg/custom/foreign-object-skew-expected.png: Added.
platform/efl/svg/custom/foreign-object-skew-expected.txt:
platform/efl/svg/custom/simple-text-double-shadow-expected.png: Added.
platform/efl/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:

6:19 AM Changeset in webkit [146459] by rgabor@webkit.org

9 edits in trunk/Source

Implement LLInt for CPU(ARM_TRADITIONAL)
https://bugs.webkit.org/show_bug.cgi?id=97589

Reviewed by Zoltan Herczeg.

Enable LLInt for ARMv5 and ARMv7 traditional as well.

Source/JavaScriptCore:

llint/LLIntOfflineAsmConfig.h:
llint/LowLevelInterpreter.asm:
llint/LowLevelInterpreter32_64.asm:
offlineasm/arm.rb:
offlineasm/backends.rb:
offlineasm/instructions.rb:

Source/WTF:

wtf/Platform.h:

6:14 AM Changeset in webkit [146458] by commit-queue@webkit.org

10 edits
2 moves
2 adds in trunk/Source/WebCore

[EFL][WebGL] Implement a common GraphicsSurface Implementation.
https://bugs.webkit.org/show_bug.cgi?id=111759

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-21
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This is in preparation to add transport surface support for GLES2.
This patch makes it easy to share the core logic of using
Transport Surface and client on GLX and GLES2 backends without
any code duplication.

PlatformEfl.cmake:
platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::initialize):
(WebCore::GraphicsContext3DPrivate::releaseResources):
(WebCore::GraphicsContext3DPrivate::prepareBuffer):
(WebCore::GraphicsContext3DPrivate::createGraphicsSurface):
(WebCore::GraphicsContext3DPrivate::didResizeCanvas):
(WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):

platform/graphics/efl/GraphicsContext3DPrivate.h:

(GraphicsContext3DPrivate):

TransportSurface related code is moved to GraphicsSurfaceCommon.
As GraphicsSurface is deleted on resize, added logic to ensure that
current buffer is not deleted before having the shared buffer
with correct size. This would avoid any flashing during resize.

platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::createTransportSurface):

platform/graphics/opengl/GLPlatformSurface.h:
platform/graphics/surfaces/efl/GLTransportSurface.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.cpp.

(WebCore):
(WebCore::GLTransportSurface::GLTransportSurface):
(WebCore::GLTransportSurface::~GLTransportSurface):
(WebCore::GLTransportSurface::updateContents):
(WebCore::GLTransportSurface::setGeometry):
(WebCore::GLTransportSurface::destroy):
(WebCore::GLTransportSurface::draw):
(WebCore::GLTransportSurface::bindArrayBuffer):
(WebCore::GLTransportSurface::updateTransformationMatrix):
(WebCore::GLTransportSurface::initializeShaderProgram):
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::~GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::destroy):
(WebCore::GLTransportSurfaceClient::prepareTexture):
(WebCore::GLTransportSurfaceClient::createTexture):

platform/graphics/surfaces/efl/GLTransportSurface.h: Renamed from Source/WebCore/platform/graphics/surfaces/GLTransportSurface.h.

(WebCore):
(GLTransportSurface):
(GLTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::texture):
(WebCore::GLTransportSurfaceClient::hasAlpha):

Moved TransportSurface to EFL folder as this is being used by EFL port only.
Added a base class for TransportSurfaceClient.

platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: Added.

(WebCore):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::destroy):
(WebCore::GraphicsSurfacePrivate::initializeTransportSurface):
(WebCore::GraphicsSurfacePrivate::makeContextCurrent):
(WebCore::GraphicsSurfacePrivate::copyFromTexture):
(WebCore::GraphicsSurfacePrivate::handle):
(WebCore::GraphicsSurfacePrivate::updateClientBuffer):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::rect):
(WebCore::GraphicsSurfacePrivate::size):
(WebCore::GraphicsSurfacePrivate::textureId):
(WebCore::GraphicsSurfacePrivate::initializeClient):
(WebCore::GraphicsSurface::platformExport):
(WebCore::GraphicsSurface::platformGetTextureID):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformCopyFromTexture):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
(WebCore::GraphicsSurface::platformFrontBuffer):
(WebCore::GraphicsSurface::platformSwapBuffers):
(WebCore::GraphicsSurface::platformSize):
(WebCore::GraphicsSurface::platformCreate):
(WebCore::GraphicsSurface::platformImport):
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):
(WebCore::GraphicsSurface::platformDestroy):
(WebCore::GraphicsSurface::platformBeginPaint):
(WebCore::GraphicsSurface::createReadOnlyImage):

GraphicsSurface implementation to be shared by both GLX and GLES2.

platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):

platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore):
(WebCore::resolveGLMethods):
(WebCore::isMesaGLX):
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::~GLXTransportSurfaceClient):
(WebCore::GLXTransportSurfaceClient::destroy):
(WebCore::GLXTransportSurfaceClient::prepareTexture):

platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXTransportSurfaceClient):
(WebCore):
GLXTransportSurfaceClient implementation.

5:58 AM Changeset in webkit [146457] by commit-queue@webkit.org

7 edits
1 delete in trunk

Unreviewed, rolling out r146454.
http://trac.webkit.org/changeset/146454
https://bugs.webkit.org/show_bug.cgi?id=112906

compile failures (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-21

Source/WebCore:

WebCore.gypi:
platform/graphics/filters/FEConvolveMatrix.h:

(FEConvolveMatrix):

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp: Removed.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:
platform/chromium/TestExpectations:

5:49 AM Changeset in webkit [146456] by reed@google.com

2 edits in trunk/Source/WebCore

Remove obsolete conditionals around calling SkTypeface::getUnitsPerEm()
https://bugs.webkit.org/show_bug.cgi?id=112846

Reviewed by Stephen White.

Existing complex-text layouttests exercise this code.

platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:

(WebCore::FontPlatformData::emSizeInFontUnits):

5:28 AM Changeset in webkit [146455] by antonm@chromium.org

39 edits
44 adds
14 deletes in trunk/LayoutTests

2013-03-21 Anton Muhin <antonm@chromium.org>

Unreviewed Chromium gardening.

Mass rebaselining.

fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-linux-x86/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-linux-x86/platform/chromium/fast: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Added.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
platform/chromium-linux-x86/svg/css/composite-shadow-example-expected.txt:
platform/chromium-linux-x86/svg/css/composite-shadow-with-opacity-expected.txt:
platform/chromium-linux-x86/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-linux-x86/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-linux-x86/svg/repaint: Added.
platform/chromium-linux-x86/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-linux/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-linux/svg/css/composite-shadow-example-expected.png:
platform/chromium-linux/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-linux/svg/css/composite-shadow-text-expected.png:
platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-linux/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-linux/svg/css/shadow-changes-expected.png:
platform/chromium-linux/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-linux/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-linux/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac-lion/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac-lion/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac-lion/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac-lion/svg/css/shadow-changes-expected.png:
platform/chromium-mac-lion/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-mac-lion/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac-lion/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac-snowleopard/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac-snowleopard/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.txt: Removed.
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac/svg/css/arrow-with-shadow-expected.png:
platform/chromium-mac/svg/css/composite-shadow-example-expected.png:
platform/chromium-mac/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-mac/svg/css/composite-shadow-text-expected.png:
platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-mac/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-mac/svg/css/shadow-changes-expected.png:
platform/chromium-mac/svg/css/shadow-changes-expected.txt:
platform/chromium-mac/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-mac/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-win-xp/fast/repaint/moving-shadow-on-container-expected.png: Added.
platform/chromium-win-xp/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-win-xp/svg/css/composite-shadow-text-expected.png:
platform/chromium-win-xp/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-win-xp/svg/css/shadow-changes-expected.png:
platform/chromium-win-xp/svg/css/shadow-changes-expected.txt: Added.
platform/chromium-win-xp/svg/custom/simple-text-double-shadow-expected.txt: Added.
platform/chromium-win-xp/svg/repaint: Added.
platform/chromium-win-xp/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-win/svg/css/arrow-with-shadow-expected.png:
platform/chromium-win/svg/css/composite-shadow-example-expected.png:
platform/chromium-win/svg/css/composite-shadow-example-expected.txt: Added.
platform/chromium-win/svg/css/composite-shadow-text-expected.png:
platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.txt: Added.
platform/chromium-win/svg/css/shadow-changes-expected.png:
platform/chromium-win/svg/css/shadow-changes-expected.txt:
platform/chromium-win/svg/custom/simple-text-double-shadow-expected.txt:
platform/chromium-win/svg/repaint/repaint-webkit-svg-shadow-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/chromium/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/chromium/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/efl/fast/repaint/moving-shadow-on-container-expected.txt: Added.
platform/gtk/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/gtk/svg/css/composite-shadow-text-expected.png: Removed.
platform/mac/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/mac/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/mac/svg/css/composite-shadow-text-expected.png: Removed.
platform/qt/svg/css/arrow-with-shadow-expected.txt: Removed.
platform/qt/svg/css/clippath-with-shadow-expected.txt: Removed.
platform/qt/svg/repaint/repaint-webkit-svg-shadow-expected.txt: Removed.
svg/css/arrow-with-shadow-expected.txt: Added.
svg/css/clippath-with-shadow-expected.txt: Added.
svg/css/composite-shadow-text-expected.png: Added.

5:16 AM Changeset in webkit [146454] by senorblanco@chromium.org

7 edits
1 add in trunk

[skia] feConvolveMatrix should use accelerated path
https://bugs.webkit.org/show_bug.cgi?id=112828

Reviewed by James Robinson.

Source/WebCore:

Covered by layout tests css3/filters/effect-reference*.html.

WebCore.gypi:

Add FEConvolveMatrixSkia.cpp to the build.

platform/graphics/filters/FEConvolveMatrix.h:

Enable the skia accelerated path for feConvolveMatrix.

platform/graphics/filters/skia/FEConvolveMatrixSkia.cpp:

(WebCore::FEConvolveMatrix::createImageFilter):
Implement building/conversion from FEConvolveMatrix to
SkMatrixConvolutionImageFilter.

LayoutTests:

css3/filters/effect-reference-hw.html:
css3/filters/effect-reference.html:

Add new test case for feConvolveMatrix as a reference filter.

platform/chromium/TestExpectations:

Suppress failures until the test can be rebaselined.

4:54 AM Changeset in webkit [146453] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Refactoring: Reorganize datetime field element parameters
https://bugs.webkit.org/show_bug.cgi?id=112877

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-21
Reviewed by Kent Tamura.

Before this patch, the field element constructors took minimum/maximum
as a pair of integers, and step/stepbase as a DateTimeNumericFieldElement::Parameters.
This patch makes these constructors to take a Range (for minimum/maximum)
and a Step (for step/stepbase).

No new tests. Just refactoring.

html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Replaced min/max data members by Ranges.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldAMPMFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::createStep):

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeDayFieldElement::create):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour11FieldElement::create):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour12FieldElement::create):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour23FieldElement::create):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeHour24FieldElement::create):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeMonthFieldElement::create):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeWeekFieldElement::create):

html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement):
(DateTimeMinuteFieldElement):
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement):
(DateTimeWeekFieldElement):

html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore):
(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::roundDown):
(WebCore::DateTimeNumericFieldElement::roundUp):

html/shadow/DateTimeNumericFieldElement.h:

(WebCore::DateTimeNumericFieldElement::Step::Step): Renamed from Parameters.
(WebCore::DateTimeNumericFieldElement::Range::Range):
(WebCore::DateTimeNumericFieldElement::Range::isSingleton): Returns true if the range is a singleton range (i.e. contains exactly one value).
(Range): Now it's parameter type, hence public.
(DateTimeNumericFieldElement): Replaced two int members (m_step and m_stepBase) by a Range.

4:41 AM Changeset in webkit [146452] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: Track CSS error location information.
https://bugs.webkit.org/show_bug.cgi?id=111314

Source/WebCore:

Added CSS syntax error reporting to some (other rules will be covered later) error recovery grammar rules.
Added code to CSSParser to allow track error location information.
Added empty rule to declaration_list. Needed to not report error about declarations like "body {}".
Added helper grammar rule "errors: error | errors error". Handles the same grammar as "error" but simplifies error location tracking.

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Test: inspector/console/console-css-warnings.html

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::currentLocation):
(WebCore):
(WebCore::CSSParser::realLex):

css/CSSParser.h:

(CSSParser):

LayoutTests:

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

inspector/console/console-css-warnings-expected.txt: Added.
inspector/console/console-css-warnings.html: Added.

4:17 AM Changeset in webkit [146451] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Changing "#define YYDEBUG 0" to 1 causing compilation error
https://bugs.webkit.org/show_bug.cgi?id=111178

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-21
Reviewed by Pavel Feldman.

Code that reference tokens can't be placed into CSSGrammar.yy.include because it's included before tokens defined.
YYDEBUG can't be used in CSSGrammar.yy.in because the #define is only defined in CSSGrammar.yy.include. This
change simplifies CSS debugging letting manipulate only #define YYDEBUG in CSSGrammar.yy.include and/or in CSSParser.cpp.

css/CSSGrammar.y.in:
css/CSSGrammar.y.includes:

3:40 AM Changeset in webkit [146450] by kadam@inf.u-szeged.hu

2 edits
2 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/TestExpectations: Skip failing tests after r146361 and r146399.
platform/qt/fast/repaint/caret-with-transformation-expected.png: Added after r139282.
platform/qt/fast/repaint/caret-with-transformation-expected.txt: Added after r139282.

2:05 AM Changeset in webkit [146449] by rniwa@webkit.org

13 edits
2 deletes in trunk/Source/WebCore

Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Patch by Nate Chapin <Nate Chapin> on 2013-03-21
Reviewed by Adam Barth.

No new tests, refactor only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from

~MainResourceLoader.

(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished): Moved from MainResourceLoader::notifyFinished.
(WebCore):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::dataReceived):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource): Don't keep separate checks

for normal and empty loads, just use a single boolean.

loader/DocumentLoader.h:

(WebCore::DocumentLoader::isLoadingMainResource):

loader/MainResourceLoader.cpp: Removed.
loader/MainResourceLoader.h: Removed.
loader/mac/DocumentLoaderMac.cpp:

(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

1:02 AM Changeset in webkit [146448] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. draw background for the FlameChart overview pane with the CPU aggregated data.
https://bugs.webkit.org/show_bug.cgi?id=112823

Reviewed by Yury Semikhatsky.

The idea of the patch is to collect the data about stack depth for the each X
and draw a line with help of this data.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype._drawOverviewCanvas):
(WebInspector.FlameChart.prototype.update):

12:52 AM Changeset in webkit [146447] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Tiled page overlay layers don't create tiles until the first flush after they switch to being tiled
https://bugs.webkit.org/show_bug.cgi?id=112860
<rdar://problem/13468400>

Reviewed by Simon Fraser.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add storage for m_clipsToExposedRect.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
The page overlay layer will never have children, so we can use flushCompositingState instead of the ForThisLayerOnly variant.
Pass the visible rect of the page overlay layer (computed by intersecting its bounds with the exposed
rect that comes from the WKView) to flushCompositingState; don't bother setting the visible rect manually.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Store m_clipsToExposedRect so we can use it in flushLayers.

12:49 AM Changeset in webkit [146446] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectation for the test added in r146427.
Removing failure expectations for tests fixed by r146430.

platform/gtk/TestExpectations:

12:42 AM Changeset in webkit [146445] by rniwa@webkit.org

2 edits in trunk/Source/WebKit

Windows build fix after r146430.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

12:42 AM Changeset in webkit [146444] by pkasting@chromium.org

7 edits
1 add
1 delete in trunk/LayoutTests

Correct some apparent problems in previous rebaselines.

Unreviewed, rebaselining.

css2.1/20110323/replaced-elements-001-expected.txt: Added.
platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-win-xp/css3/flexbox: Removed.
platform/chromium-win/css3/flexbox/button-expected.png:

12:30 AM Changeset in webkit [146443] by rniwa@webkit.org

7 edits in trunk/Tools

EWS bots have stopped uploading results to bugzilla
https://bugs.webkit.org/show_bug.cgi?id=101091

Reviewed by Adam Barth.

The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
this relative file path resoled to a file inside a non-existent directory for "zip".

Fixed the bug by resolving both test results directory and zip archive paths in
LayoutTestResultsReader.archive.

Also made workspace.create_zip print the source_path so that we may debug these issues more easily
in the future.

Scripts/webkitpy/common/system/filesystem_mock.py:

(MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".

Scripts/webkitpy/common/system/workspace.py:

(Workspace.create_zip): Log the source path when "zip" failed.

Scripts/webkitpy/common/system/workspace_mock.py:

(MockWorkspace.create_zip): Record zip_path and source_path for testing.

Scripts/webkitpy/common/system/workspace_unittest.py:

(WorkspaceTest.test_create_zip_exception): Test that.

Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
This is the actual bug fix.

Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:

(test_archive_last_layout_test_results_with_relative_path): Added a test case.

12:15 AM Changeset in webkit [146442] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Fix JS compiler warnings.
https://bugs.webkit.org/show_bug.cgi?id=112879

Reviewed by Pavel Feldman.

Removed erroneous JSDoc.

inspector/front-end/Settings.js: Removed erroneous JSDoc.

Mar 20, 2013:

11:35 PM Changeset in webkit [146441] by pkasting@chromium.org

165 edits
21 adds
18 deletes in trunk/LayoutTests

Unreviewed, test expectations update.

css2.1/20110323/replaced-elements-001-expected.txt: Removed.
fast/css/empty-generated-content-expected.txt: Added.
fast/css/word-space-extra-expected.txt: Added.
fast/table/025-expected.txt: Added.
platform/chromium-linux-x86/css3/masking: Added.
platform/chromium-linux-x86/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-linux-x86/fast/forms/date: Removed.
platform/chromium-linux-x86/fast/forms/time: Removed.
platform/chromium-linux-x86/platform/chromium/fast: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png: Removed.
platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png:
platform/chromium-linux/fast/css/word-space-extra-expected.txt: Removed.
platform/chromium-linux/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-lion/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac-lion/css3/masking: Added.
platform/chromium-mac-lion/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-mac-lion/fast/css/word-space-extra-expected.png: Added.
platform/chromium-mac-lion/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-mac-lion/fast/table/025-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-snowleopard/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac-snowleopard/css3/masking: Added.
platform/chromium-mac-snowleopard/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/word-space-extra-expected.png:
platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-mac-snowleopard/fast/table/025-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png:
platform/chromium-mac/fast/css/word-space-extra-expected.png:
platform/chromium-mac/fast/css/word-space-extra-expected.txt: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-mac/fast/table/025-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win-xp/css3/masking: Added.
platform/chromium-win-xp/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png: Removed.
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png: Removed.
platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png: Removed.
platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Removed.
platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.png:
platform/chromium-win/css2.1/20110323/replaced-elements-001-expected.txt:
platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png:
platform/chromium-win/fast/css/empty-generated-content-expected.txt:
platform/chromium-win/fast/css/word-space-extra-expected.png:
platform/chromium-win/fast/css/word-space-extra-expected.txt:
platform/chromium-win/fast/events/stopPropagation-submit-expected.txt: Added.
platform/chromium-win/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-month-popup-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.txt:
platform/chromium-win-xp/css2.1/20110323/replaced-elements-001-expected.png: Added.
platform/chromium/TestExpectations:
platform/chromium/css3/filters/filter-property-parsing-expected.txt: Replaced.
platform/chromium/fast/css/empty-generated-content-expected.txt: Removed.
platform/chromium/fast/table/025-expected.txt: Removed.
platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Removed.
platform/mac/fast/css/empty-generated-content-expected.txt: Removed.
platform/mac/fast/css/word-space-extra-expected.txt: Removed.
platform/mac/fast/table/025-expected.txt: Removed.
platform/win-future/css2.1: Added.
platform/win-future/css2.1/20110323: Added.
platform/win-future/css2.1/20110323/replaced-elements-001-expected.txt: Added.
platform/win/fast/css/empty-generated-content-expected.txt: Removed.

11:22 PM Changeset in webkit [146440] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add a flaky crash test expectation per bug 112881.

platform/win/TestExpectations:

11:16 PM Changeset in webkit [146439] by jochen@chromium.org

11 edits
5 moves
1 add
1 delete in trunk/Tools

[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebKit):
(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.

(WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
(WebTestRunner):
(WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
(WebTestRunner::WebTestThemeControlWin::box):
(WebTestRunner::WebTestThemeControlWin::line):
(WebTestRunner::WebTestThemeControlWin::triangle):
(WebTestRunner::WebTestThemeControlWin::roundRect):
(WebTestRunner::WebTestThemeControlWin::oval):
(WebTestRunner::WebTestThemeControlWin::circle):
(WebTestRunner::WebTestThemeControlWin::nestedBoxes):
(WebTestRunner::WebTestThemeControlWin::markState):
(WebTestRunner::WebTestThemeControlWin::draw):
(WebTestRunner::WebTestThemeControlWin::drawTextField):
(WebTestRunner::WebTestThemeControlWin::drawProgressBar):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.

(WebTestRunner):
(WebTestThemeControlWin):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.

(WebTestRunner):
(WebTestThemeEngineMac):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.

(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
(WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.

(WebTestRunner::WebTestThemeEngineWin::paintButton):
(WebTestRunner):
(WebTestRunner::WebTestThemeEngineWin::paintMenuList):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
(WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
(WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
(WebTestRunner::WebTestThemeEngineWin::paintTextField):
(WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
(WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
(WebTestRunner::WebTestThemeEngineWin::getSize):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.

(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(WebKit):

DumpRenderTree/chromium/TestShellMac.mm:

(platformInit):

DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

10:59 PM Changeset in webkit [146438] by Simon Fraser

5 edits in trunk/Source/WebCore

Make GraphicsLayerCA::backingStoreMemoryEstimate() give a better estimate for tiled layers
https://bugs.webkit.org/show_bug.cgi?id=112864

Reviewed by Tim Horton.

If a GraphicsLayerCA has TiledBacking, ask the TiledBacking how
much memory it's using for tiles, rather than just using
height * width * 4.

Implement retainedTileBackingStoreMemory() in the TileController,
summing the memory used by parented tiles.

The original code was incorrectly multiplying by contentsScale
only once rather than twice (2x contents scale uses 4x as much memory).

platform/graphics/TiledBacking.h:
platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreMemoryEstimate):

platform/graphics/ca/mac/TileController.h:
platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::retainedTileBackingStoreMemory):

10:53 PM Changeset in webkit [146437] by tkent@chromium.org

65 edits
1 delete in trunk/LayoutTests

[Chromium] Test expectation update for r145055
https://bugs.webkit.org/show_bug.cgi?id=111319

platform/chromium-linux-x86/fast/forms/time/time-appearance-pseudo-elements-expected.png: Removed.
platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png:
platform/chromium-win/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
platform/chromium/TestExpectations:

10:48 PM WebKit Team edited by esprehn@chromium.org

(diff)

9:57 PM Changeset in webkit [146436] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r189497. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

DEPS:

9:05 PM Changeset in webkit [146435] by pkasting@chromium.org

2 edits
2 adds in trunk/LayoutTests

[chromium] Test expectations updates, and rebaseline to parallel r143389.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=99984
https://bugs.webkit.org/show_bug.cgi?id=111004
https://bugs.webkit.org/show_bug.cgi?id=112288
https://bugs.webkit.org/show_bug.cgi?id=112755

Unreviewed, test expectations updates.

platform/chromium-win/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
platform/chromium-win/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
platform/chromium/TestExpectations:

8:43 PM Changeset in webkit [146434] by commit-queue@webkit.org

6 edits
8 adds in trunk/LayoutTests

Rebaseline some of my recent test changes
https://bugs.webkit.org/show_bug.cgi?id=112843

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Ojan Vafai.

platform/chromium-mac-lion/css3/flexbox/button-expected.png: Added.
platform/chromium-mac-lion/fast/forms/color/input-appearance-color-expected.png:
platform/chromium-mac-snowleopard/css3/flexbox/button-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/color/input-appearance-color-expected.png:
platform/chromium-mac/css3/flexbox/button-expected.png: Added.
platform/chromium-mac/css3/flexbox/button-expected.txt: Added.
platform/chromium-mac/fast/forms/color/input-appearance-color-expected.png:
platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
platform/chromium-win/css3/flexbox/button-expected.png: Added.
platform/chromium-win/css3/flexbox/button-expected.txt: Added.
platform/chromium/TestExpectations:

8:35 PM Changeset in webkit [146433] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r146418.
http://trac.webkit.org/changeset/146418
https://bugs.webkit.org/show_bug.cgi?id=112872

It turns out that these sub pixel tests still do fail on Mac
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

platform/mac/TestExpectations:

7:47 PM Changeset in webkit [146432] by gyuyoung.kim@samsung.com

2 edits in trunk/LayoutTests

Unreviewed. Remove test cases which need to do rebaseline in EFL TestExpectations.

platform/efl/TestExpectations:

7:43 PM Changeset in webkit [146431] by rniwa@webkit.org

10 edits
1 delete in trunk/Source

Unreviewed, rolling out r146419.
http://trac.webkit.org/changeset/146419
https://bugs.webkit.org/show_bug.cgi?id=112870

Broke many tests on debug builds (Requested by rniwa_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

DerivedSources.make:
GNUmakefile.am:
WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_makenames.py:

(main):

bindings/scripts/StaticString.pm: Removed.
dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

dom/QualifiedName.h:

(WebCore):

dom/make_names.pl:

(printNamesCppFile):
(printDefinitions):

Source/WTF:

wtf/text/StringImpl.h:

(StringImpl):

7:42 PM Changeset in webkit [146430] by commit-queue@webkit.org

14 edits
1 delete in trunk

[JSC] Implement EnforceRange IDL attribute for integer conversions
https://bugs.webkit.org/show_bug.cgi?id=112506

Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.

Source/autotools/symbols.filter:

Source/WebCore:

Implement the EnforceRange attribute for JSC bindings.

The EnforceRange attribute requires a type error to be thrown when
converting an ECMAScript number which is beyond the representable
range of the IDL integer type.

Tests: fast/js/webidl-type-mapping.html

storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/cursor-advance.html
storage/indexeddb/intversion-bad-parameters.html

WebCore.exp.in:
bindings/js/JSDOMBinding.cpp:

(WebCore):
(WebCore::enforceRange):
(WebCore::toInt32EnforceRange):
(WebCore::toUInt32EnforceRange):
(WebCore::toInt64):
(WebCore::toUInt64):

bindings/js/JSDOMBinding.h:

(WebCore::toInt32):
(WebCore):
(WebCore::toUInt32):

bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionItem):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjLongAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjId):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjConstructorFunctionClassMethodWithOptional):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod11):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsUnsignedLongLongAttr):
(WebCore::setJSTestTypedefsAttrWithGetterException):
(WebCore::setJSTestTypedefsAttrWithSetterException):

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

fast/js/webidl-type-mapping-expected.txt:
platform/chromium/fast/js/webidl-type-mapping-expected.txt: Removed.

7:33 PM Changeset in webkit [146429] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

[QNX][ARM] REGRESSION(r135330): Various failures in Octane
https://bugs.webkit.org/show_bug.cgi?id=112863

Patch by Cosmin Truta <ctruta@blackberry.com> on 2013-03-20
Reviewed by Yong Li.

This was fixed in http://trac.webkit.org/changeset/146396 on Linux only.
Enable this fix on QNX.

assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

7:26 PM Changeset in webkit [146428] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add flaky test expectations to compositing/geometry/limit-layer-bounds-fixed.html
and fast/dom/MutationObserver/database-callback-delivery.html on Windows per bugs
112867 and 112868.

platform/win/TestExpectations:

6:51 PM Changeset in webkit [146427] by hayato@chromium.org

4 edits
2 adds in trunk

Gesture events should include AllowShadowContent in hit testing
https://bugs.webkit.org/show_bug.cgi?id=112073

Reviewed by Dimitri Glazkov.

Source/WebCore:

Support gesture events for Shadow DOM.
Now 'gesturetap' events can be correctly dispatched in shadow trees.

Test: fast/dom/shadow/gesture-tap.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

fast/dom/shadow/gesture-tap-expected.txt: Added.
fast/dom/shadow/gesture-tap.html: Added.
fast/dom/shadow/resources/event-dispatching.js:

(addEventListeners):

6:46 PM Changeset in webkit [146426] by msaboff@apple.com

2 edits
3 adds in trunk/LayoutTests

Should add test for bug #112694
https://bugs.webkit.org/show_bug.cgi?id=112859

Reviewed by Filip Pizlo.

New regression test to check that eliminating a var arg DFG Node (array in this case) doesn't
cause a ASSERT or crash.

fast/js/dfg-array-dead-expected.txt: Added.
fast/js/dfg-array-dead.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-array-dead.js: Added.

6:44 PM Changeset in webkit [146425] by mrowe@apple.com

4 edits in trunk/Source

Versioning.

6:44 PM Changeset in webkit [146424] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Mac rebaseline after r146415. I somehow missed the 1px difference.

platform/mac/svg/custom/text-ctm-expected.txt:

6:39 PM Changeset in webkit [146423] by mrowe@apple.com

1 copy in tags/Safari-537.35

New tag.

5:49 PM Changeset in webkit [146422] by bfulgham@webkit.org

5 edits in trunk/Source

../ThirdParty: [WinCairo] Build WinCairo port under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861

Reviewed by Tim Horton.

gtest/msvc/gtest-md.vcxproj: Add WinCairo targets.

../WebKit: [WinCairo] Top-level solution change to build under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112861.

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.sln: Add final set of WinCairo build

targets.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Add #if/def guards around some media-specific exports that
are not provided by the WinCairo port.

5:43 PM Changeset in webkit [146421] by pkasting@chromium.org

2 edits in trunk/LayoutTests

[chromium] Update test expectations to more closely match reality.
https://bugs.webkit.org/show_bug.cgi?id=106609
https://code.google.com/p/chromium/issues/detail?id=222140

Unreviewed, test expectations update.

platform/chromium/TestExpectations:

5:36 PM Changeset in webkit [146420] by bfulgham@webkit.org

3 edits
1 add in trunk/Tools

[WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.

New property sheet that does not link against CoreFoundation and
CFNetwork.

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:

Use new TestWebKitAPICommonWinCairo property sheet.

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:

Ditto.

5:31 PM Changeset in webkit [146419] by abarth@webkit.org

10 edits
1 add in trunk/Source

HTMLNames should construct strings at compile time
https://bugs.webkit.org/show_bug.cgi?id=112831

Reviewed by Darin Adler.

Source/WebCore:

This patch teaches make_names how to construct strings at compile time,
eliminating a large number of startup mallocs.

WebCore.gyp/WebCore.gyp:
WebCore.gyp/scripts/action_makenames.py:
- Teach the Chromium build how to deal with Perl modules.
bindings/scripts/StaticString.pm: Added.
- A Perl module for constructing static strings.

(GenerateStrings):
(GenerateValidateStrings):

dom/QualifiedName.cpp:

(WebCore::createQualifiedName):

createQualifiedName now takes an already-constructed StringImpl object.

dom/QualifiedName.h:
dom/make_names.pl:

(valueForName):
(namesToStrings):
(printNamesCppFile):
(printDefinitions):

Teach make_names how to use StaticString.pm.

Source/WTF:

wtf/text/StringImpl.h:

(StringImpl):
(StaticASCIILiteral):

This struct lets us construct StringImpl objects at compile time.

(WTF::StringImpl::assertValidHash):

This function lets us sanity check StringImpl objects created from StaticData.

5:20 PM Changeset in webkit [146418] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Remove entires added by r138484 now that these tests pass on Mac.

platform/mac/TestExpectations:

5:09 PM Changeset in webkit [146417] by falken@chromium.org

6 edits in trunk/Source/WebCore

Remove unnecessary calls to Node::disabled for <meter>, <progress>, and <output>
https://bugs.webkit.org/show_bug.cgi?id=112767

Reviewed by Kent Tamura.

This is part of a refactoring to move Node::disabled to HTMLFormControlElement::disabled.
The concept of disabled is just a form control element one.

HTMLMeterElement, HTMLOutputElement, and HTMLProgressElement never
have disabled() return true, so we can remove the call. In addition,
HTMLMeterElement and HTMLProgressElement no longer inherit from
HTMLFormControlElement, so we don't need to override supportsFocus.

No new tests because no behavior change.

html/HTMLMeterElement.cpp:
html/HTMLMeterElement.h:
html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::supportsFocus):

html/HTMLProgressElement.cpp:
html/HTMLProgressElement.h:

5:08 PM Changeset in webkit [146416] by bfulgham@webkit.org

4 edits
3 adds in trunk/Tools

[WinCairo] Unreviewed build fix for VS2010.

Had to add WinCairo-specific property sheets to deal with some
library and path differences with the main Apple port.

DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.

5:06 PM Changeset in webkit [146415] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Remove an entry added in r141645 as this test is now passing.

platform/mac/TestExpectations:

5:03 PM Changeset in webkit [146414] by rniwa@webkit.org

3 edits in trunk/LayoutTests

fast/css/empty-generated-content.html needs to be rebaselined after 104462
https://bugs.webkit.org/show_bug.cgi?id=104595

platform/mac/TestExpectations:
platform/mac/fast/css/empty-generated-content-expected.txt:

4:53 PM Changeset in webkit [146413] by rniwa@webkit.org

6 edits in trunk/LayoutTests

Rebaseline expected results added in r143389 so that they have alpha values.

platform/mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
platform/mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
svg/as-image/image-preserveAspectRatio-all-expected.png:
svg/filters/feImage-preserveAspectRatio-all-expected.png:

4:49 PM Changeset in webkit [146412] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Remove test expectations added in r133786 as these tests are now passing.

platform/mac/TestExpectations:

4:46 PM Changeset in webkit [146411] by rniwa@webkit.org

2 edits in trunk/LayoutTests

inspector/debugger/debugger-reload-on-pause.html assertion failure on Mac after r141136
https://bugs.webkit.org/show_bug.cgi?id=109232

Unreviewed. Remove the test expectation entry since this test hasn't been crashing lately.

platform/mac/TestExpectations:

4:41 PM Changeset in webkit [146410] by rniwa@webkit.org

3 edits
1 copy in trunk/LayoutTests

Mac rebaseline intended to be done in r146409 for r144096.

platform/mac/TestExpectations:
platform/mac/css2.1/20110323/replaced-elements-001-expected.png:
platform/mac/css2.1/20110323/replaced-elements-001-expected.txt: Copied from LayoutTests/css2.1/20110323/replaced-elements-001-expected.txt.

4:31 PM Changeset in webkit [146409] by rniwa@webkit.org

3 edits
2 copies in trunk/LayoutTests

Mac rebaseline after r144096.

platform/mac/TestExpectations:
platform/mac/css3/flexbox/button-expected.png: Copied from LayoutTests/css3/flexbox/button-expected.png.
platform/mac/css3/flexbox/button-expected.txt: Copied from LayoutTests/css3/flexbox/button-expected.txt.
platform/mac/svg/custom/foreign-object-skew-expected.png:

4:20 PM Changeset in webkit [146408] by commit-queue@webkit.org

18 edits
9 adds in trunk

Source/WebCore: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.

"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line

This patch is the parsing part to support each-line value for text-indent.

"each-line" means "Indentation affects the first line of the block
container as well as each line after a forced line break, but does
not affect lines after a soft wrap break."

It's prefixed and guarded by CSS3_TEXT flag.

Tests: fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html

fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

style.getPropertyCSSValue(text-indent) returns CSSPrimitiveValue when text-indent has only <length>
or <percentage> value, but returns CSSValueList when text-indent also has -webkit-each-line.

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID): Removed CSSPropertyTextIndent case.
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent): Added.

css/CSSParser.h:

Parsed <length> or <percentage> with -webkit-each-line for text-indent.

css/CSSValueKeywords.in: Added new -webkit-each-line keyword.
css/StyleBuilder.cpp:

(ApplyPropertyTextIndent): Added.
(WebCore::ApplyPropertyTextIndent::applyInheritValue):
(WebCore::ApplyPropertyTextIndent::applyInitialValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
(WebCore::ApplyPropertyTextIndent::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

Added codes to handle applying text-indent offset and -webkit-each-line option to our style.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):

rendering/style/RenderStyle.h:
rendering/style/RenderStyleConstants.h: Added enum TextIndentLine.
rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

rendering/style/StyleRareInheritedData.h: Added m_textIndentLine.

(StyleRareInheritedData):

Added the usual getter / setter / initial methods for m_textIndentLine.

LayoutTests: [css3-text] Parsing -webkit-each-line value for text-indent from css3-text
https://bugs.webkit.org/show_bug.cgi?id=109021

"each-line" is added for text-indent in CSS3.
http://dev.w3.org/csswg/css3-text/#each-line

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-20
Reviewed by Julien Chaffraix.

fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-expected.txt: Added.
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited-expected.txt: Added.
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent-inherited.html: Added.
fast/css3-text/css3-text-indent/getComputedStyle/getComputedStyle-text-indent.html: Added.
fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent-inherited.js: Added.

(testComputedStyle):
(ownValueTest):
(inheritanceTest):

fast/css3-text/css3-text-indent/getComputedStyle/script-tests/getComputedStyle-text-indent.js: Added.

(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):

platform/chromium/TestExpectations:
platform/mac/TestExpectations:
platform/qt-mac/TestExpectations:
platform/qt/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

4:16 PM Changeset in webkit [146407] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix indentation of JSString.h

Rubber stamped by Mark Hahnenberg.

runtime/JSString.h:

4:04 PM Changeset in webkit [146406] by tsepez@chromium.org

3 edits in trunk/LayoutTests

dialog-enabled.html and dialog-disabled.html don't really test what they think they do
https://bugs.webkit.org/show_bug.cgi?id=112848

Reviewed by Adam Barth.

fast/dom/HTMLDialogElement/dialog-disabled.html:
fast/dom/HTMLDialogElement/dialog-enabled.html:

Set the dialog element enabled setting before parsing <dialog> element.

4:03 PM Changeset in webkit [146405] by rniwa@webkit.org

4 edits in trunk/LayoutTests

Mac rebaseline after r142152.

platform/mac/TestExpectations:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

3:52 PM Changeset in webkit [146404] by rniwa@webkit.org

24 edits in trunk/LayoutTests

Mac rebaseline after r140693.

editing/selection/extend-by-sentence-001-expected.txt:
platform/mac/TestExpectations:
platform/mac/css2.1/t0505-c16-descendant-01-e-expected.png:
platform/mac/css2.1/t0505-c16-descendant-01-e-expected.txt:
platform/mac/editing/selection/extend-by-sentence-001-expected.png:
platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
platform/mac/fast/text/capitalize-empty-generated-string-expected.png:
platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:
platform/mac/fast/text/whitespace/006-expected.png:
platform/mac/fast/text/whitespace/006-expected.txt:
platform/mac/fast/text/whitespace/007-expected.png:
platform/mac/fast/text/whitespace/007-expected.txt:
platform/mac/svg/batik/text/xmlSpace-expected.png:
platform/mac/svg/batik/text/xmlSpace-expected.txt:
platform/mac/svg/carto.net/combobox-expected.png:
platform/mac/tables/mozilla/bugs/bug113235-3-expected.txt:
platform/mac/tables/mozilla/bugs/bug1188-expected.png:
platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
platform/mac/tables/mozilla/bugs/bug1318-expected.png:
platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
svg/carto.net/combobox-expected.txt:

3:43 PM Changeset in webkit [146403] by rniwa@webkit.org

2 edits
2 adds in trunk/LayoutTests

Mac rebaseline after r139282.

fast/repaint/caret-with-transformation-expected.png: Added.
fast/repaint/caret-with-transformation-expected.txt: Added.

3:40 PM Changeset in webkit [146402] by benjamin@webkit.org

9 edits in trunk

[WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112849

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-20
Reviewed by Sam Weinig.

Source/WebKit2:

The code was added in r137148 for the sole purpose of testing,
and it is not even being properly tested.

Remove the code until someone actually implement the feature in WebKit2.

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCanShowMIMEType):

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:

(WebPage):

Tools:

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:
WebKitTestRunner/InjectedBundle/TestRunner.h:

3:39 PM Changeset in webkit [146401] by fpizlo@apple.com

1 edit
3 adds in trunk/LayoutTests

"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845

Reviewed by Mark Hahnenberg.

fast/js/regress/empty-string-plus-int-expected.txt: Added.
fast/js/regress/empty-string-plus-int.html: Added.
fast/js/regress/script-tests/empty-string-plus-int.js: Added.

(foo):

3:37 PM Changeset in webkit [146400] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

"" + x where x is not a string should be optimized by the DFG to some manner of ToString conversion
https://bugs.webkit.org/show_bug.cgi?id=112845

Reviewed by Mark Hahnenberg.

I like to do "" + x. So I decided to make DFG recognize it, and related idioms.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToPrimitive):
(FixupPhase):
(JSC::DFG::FixupPhase::fixupToString):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::resultOfToPrimitive):
(DFG):
(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGPredictionPropagationPhase.h:

(DFG):

3:36 PM Changeset in webkit [146399] by commit-queue@webkit.org

10 edits
7 adds in trunk

Correct coordinated scrolling for RTL iframe and overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=112088

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-20
Reviewed by James Robinson.

Source/WebCore:

This patch adds appropriate offset in ScrollingCoordinatorChromium to
adjust impl-side scroll position to the range [0, maxPos - minPos].

This also corrects RenderLayer to return correct scroll position for RTL,
explained below:

There are 2 commonly used scroll offset coordinate systems in WebCore.

The scroll offset is the amount that needs to be translated when painting child elements in a RenderBox. The value can be negative when there is negative overflow (for RTL). The range will be within [overflow_top_left_corner, overflow_bottom_right_corner - client_size]. This system is mainly used for painting and layer positioning.

The scroll offset will be always non-negative, and the range will be within [0, content_size - client_size]. This system is mainly used for scrollbars.

scrollOrigin is defined to convert between the two systems. scrollOrigin is always
non-negative, and equivalent to -overflow_top_left_corner.

The first system is used for ScrollableArea::scrollPosition/minimumScrollPosition/
maximumScrollPosition function family. So is it implemented in ScrollView/Frameview.
RenderLayer errorneously implemented scrollPosition in the second system,
and worse, returned minimumScrollPosition/maximumScrollPosition were totally non-sense.
This patch corrects RenderLayer to use the first coordinate system.

Test: compositing/rtl/rtl-overflow-scrolling.html

ScrollingCoordinatorChromiumTest.rtlIframe

page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:

(WebCore::ScrollingCoordinatorChromium::scrollableAreaScrollLayerDidChange):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::minimumScrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Source/WebKit/chromium:

Added test to ensure RTL iframe has appropriate impl-side scroll position.

tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):
(WebKit):

tests/data/rtl-iframe-inner.html: Added.
tests/data/rtl-iframe.html: Added.

LayoutTests:

This patch corrects scrollOrigin compensation for composited overflow:scroll.

compositing/rtl/rtl-overflow-scrolling.html is added to verify RTL divs
can be correctly scrolled to the left under accelerated scrolling mode.

fast/css/sticky/inline-sticky-abspos-child.html is modified to avoid sub-pixel
issue with Ahem font.

compositing/rtl/rtl-overflow-scrolling-expected.png: Added.
compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.
compositing/rtl/rtl-overflow-scrolling.html: Added.
fast/css/sticky/inline-sticky-abspos-child-expected.html:
fast/css/sticky/inline-sticky-abspos-child.html:
platform/chromium/TestExpectations:
platform/mac/compositing/rtl/rtl-overflow-scrolling-expected.txt: Added.

3:33 PM Changeset in webkit [146398] by bfulgham@webkit.org

10 edits
6 adds in trunk/Tools

[WinCairo] Build WebKit Tools under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112821

Reviewed by Tim Horton.

DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:

Add WinCairo-specific build target.

DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:

Add WinCairo-specific build target.

DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:

Add WinCairo-specific build target.

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add

WinCairo-specific build target.

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-

specific build target.

WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add

WinCairo-specific build target.

win/record-memory/record-memory.vcxproj: Add WinCairo target.
win/record-memory/record-memoryDebugWinCairo.props: Added.
win/record-memory/record-memoryReleaseWinCairo.props: Added.

3:19 PM Changeset in webkit [146397] by rniwa@webkit.org

9 edits in trunk/LayoutTests

Mac rebaseline after r140202.

editing/input/caret-at-the-edge-of-contenteditable-expected.png:
editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
editing/input/reveal-caret-of-multiline-input-expected.png:
fast/spatial-navigation/snav-div-overflow-scrol-hidden-expected.txt:
platform/mac/TestExpectations:
platform/mac/editing/input/caret-at-the-edge-of-contenteditable-expected.txt:
platform/mac/editing/input/reveal-caret-of-multiline-contenteditable-expected.txt:
platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt:

3:07 PM Changeset in webkit [146396] by zherczeg@webkit.org

3 edits in trunk/Source/JavaScriptCore

ARMv7 replaceWithJump ASSERT failure after r135330.
https://bugs.webkit.org/show_bug.cgi?id=103146

Reviewed by Filip Pizlo.

On Linux, the 24 bit distance range of jumps sometimes does not
enough to cover all targets addresses. This patch supports jumps
outside of this range using a mov/movt/bx 10 byte long sequence.

assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::revertJumpTo_movT3movtcmpT2):
(JSC::ARMv7Assembler::nopw):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

3:05 PM Changeset in webkit [146395] by rniwa@webkit.org

2 edits in branches/safari-536.30-branch/Tools

Unreviewed. Merge the latest delete-stale-build-files to make bots green.

BuildSlaveSupport/delete-stale-build-files:

3:01 PM Changeset in webkit [146394] by jberlin@webkit.org

4 edits in trunk/Source

REGRESSION(r145592): AutodrainedPool.h. RunLoopTimer.h, SchedulePair.h are being copied into
the wrong location
https://bugs.webkit.org/show_bug.cgi?id=112833

Reviewed by Darin Adler.

Source/WebCore:

Fix an incorrect include path.

loader/DocumentLoader.h:

RunLoopTimer.h lives in wtf as of r145592.

Source/WTF:

WTF.xcodeproj/project.pbxproj:

Make sure those three headers are copied with the rest of the WTF headers.

2:58 PM Changeset in webkit [146393] by tkent@chromium.org

3 edits
2 adds in trunk

Crash in Document::setFocusedNode if the frame of new focused node is detached in 'change' event handler
https://bugs.webkit.org/show_bug.cgi?id=112653

Reviewed by Dimitri Glazkov.

Source/WebCore:

Test: fast/frames/detach-frame-during-focus.html

page/FocusController.cpp:

(WebCore::FocusController::setFocusedNode):
A oldDocument->setFocusedNode call might dispatch a 'change' event for
an old focused node, and an event handler code might detach the
newFocusedFrame. So we should check it. Without the check, the following
newDocument->setFocusedNode call would crash because of null
Frame::page().

LayoutTests:

fast/frames/detach-frame-during-focus-expected.txt: Added.
fast/frames/detach-frame-during-focus.html: Added.

2:41 PM Changeset in webkit [146392] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Objective-C API: Fix over-releasing in allocateConstructorAndPrototypeWithSuperClassInfo:
https://bugs.webkit.org/show_bug.cgi?id=112832

Reviewed by Geoffrey Garen.

If either the m_constructor or m_prototype (but not both) is collected, we will call
allocateConstructorAndPrototypeWithSuperClassInfo, which will create a new object to replace the one
that was collected, but at the end of the method we call release on both of them.
This is incorrect since we autorelease the JSValue in the case that the object doesn't need to be
reallocated. Thus we'll end up overreleasing later during the drain of the autorelease pool.

API/JSWrapperMap.mm:

(objectWithCustomBrand): We no longer alloc here. We instead call the JSValue valueWithValue class method,
which autoreleases for us.
(-[JSObjCClassInfo allocateConstructorAndPrototypeWithSuperClassInfo:]): We no longer call release on the
constructor or prototype JSValues.

API/tests/testapi.mm: Added a new test that crashes on ToT due to over-releasing.

2:36 PM Changeset in webkit [146391] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

Reviewed by Simon Fraser.

Address Simon's review comment. Don't convert String to MIMEType just to convert it back to String.

platform/mac/PasteboardMac.mm:

(WebCore::fragmentFromWebArchive):

2:26 PM Changeset in webkit [146390] by zandobersek@gmail.com

9 edits
1 add in trunk

[GTK] Build ANGLE sources into a separate library from libWebCore.la
https://bugs.webkit.org/show_bug.cgi?id=112778

Reviewed by Martin Robinson.

GNUmakefile.am: Include the GNUmakefile.am covering the libANGLE.la library.

Source/ThirdParty/ANGLE:

GNUmakefile.am: Added, sets up the libANGLE.la library.

Source/WebCore:

No new tests - no change in functionality.

GNUmakefile.list.am: Remove the ANGLE sources listing, it's now placed in the ANGLE-specific GNUmakefile.am.

Source/WebKit/gtk:

GNUmakefile.am: Add libLevelDB.la to the libwebkitgtk library if using the OpenGL accelerated backend.

Source/WebKit2:

GNUmakefile.am: Add libLevelDB.la to the libwebkit2gtk library if using the OpenGL accelerated backend.

2:24 PM Changeset in webkit [146389] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

Reviewed by Enrica Casucci.

It's possible for clipboard to be overriden between the time we retrieve clipboard types and the time
we actually retrieve the Web archive buffer. Add a null check to take this into account.

Also extracted fragmentFromWebArchive for clarity.

platform/mac/PasteboardMac.mm:

(WebCore::fragmentFromWebArchive): Extracted.
(WebCore::Pasteboard::documentFragment):

2:16 PM Changeset in webkit [146388] by eric.carlson@apple.com

30 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/13465764> Many merged tests are failing

Rubber stamped by Mark Rowe.

Change all instances of "testRunner" back to "layoutTestController".

editing/style/apply-style-crash.html:
fast/backgrounds/background-clip-text-on-body.html:
fast/backgrounds/transformed-body-background.html:
fast/backgrounds/transformed-body-html-background.html:
fast/backgrounds/transformed-html-body-background.html:
fast/block/colspan-under-button-crash.html:
fast/block/float/float-not-removed-from-pre-block.html:
fast/block/line-layout/double-line-break-obj-removal-crash.html:
fast/canvas/canvas-measureText.html:
fast/css-generated-content/bug-106384.html:
fast/css/image-set-value-not-removed-crash.html:
fast/dom/Geolocation/watchPosition-unique.html:
fast/dom/ready-state-change-crash.html:
fast/dom/window-load-crash.html:
fast/forms/textarea/textarea-autofocus-removal-while-focusing-with-style.html:
fast/frames/frame-unload-crash2.html:
fast/images/crossfade-client-not-removed-crash.html:
fast/js/concat-large-strings-crash.html:
fast/js/concat-large-strings-crash2.html:
fast/multicol/continuation-crash.html:
fast/multicol/float-not-removed-crash.html:
fast/multicol/span/list-multi-column-crash.html:
fast/parser/foster-parent-adopted.html:
fast/parser/foster-parent-adopted2.html:
http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
plugins/plugin-remove-readystatechange.html:
svg/animations/animate-keytimes-crash.html:
svg/custom/elementTimeControl-nan-crash.html:

2:13 PM Changeset in webkit [146387] by Chris Fleizach

3 edits
2 adds in trunk

WebSpeech: Crash in WebCore::PlatformSpeechSynthesisUtterance::client / WebCore::SpeechSynthesis::didResumeSpeaking
https://bugs.webkit.org/show_bug.cgi?id=112728

Reviewed by Tim Horton.

When cancel() is called, there was a delay in the platform returning and saying speech was finished, which caused
the m_currentSpeechUtterance variable to get deallocated but not cleared.

This patch fixes up the management of the utterances in SpeechSynthesis and the Mac platform given that
we can't rely on the platform to return immediately on a stop speaking job.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-cancel-crash.html

Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::resume):

platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper cancel]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:willSpeakWord:ofString:]):

1:55 PM Changeset in webkit [146386] by roger_fong@apple.com

3 edits in trunk/Tools

API test gardening AppleWin port.

The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.

TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
TestWebKitAPI/win/TestWebKitAPI.vcproj:

1:47 PM Changeset in webkit [146385] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

Unreviewed, fix Mac release build.

page/CaptionUserPreferencesMac.mm:

(WebCore::languageIdentifier):

1:45 PM Changeset in webkit [146384] by fpizlo@apple.com

1 copy in branches/dfgFourthTier

Unreviewed, branch for work on https://bugs.webkit.org/show_bug.cgi?id=112836

1:43 PM Changeset in webkit [146383] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

It's called "Hash Consing" not "Hash Consting"
https://bugs.webkit.org/show_bug.cgi?id=112768

Rubber stamped by Mark Hahnenberg.

See http://en.wikipedia.org/wiki/Hash_consing

heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):

heap/GCThreadSharedData.h:

(GCThreadSharedData):

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::reset):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
(JSC::JSString::shouldTryHashCons):
(JSC::SlotVisitor::internalAppend):

heap/SlotVisitor.h:

(SlotVisitor):

runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashCons):
(JSC::JSGlobalData::resetNewStringsSinceLastHashCons):

runtime/JSString.h:

(JSC::JSString::finishCreation):
(JSString):
(JSC::JSString::isHashConsSingleton):
(JSC::JSString::clearHashConsSingleton):
(JSC::JSString::setHashConsSingleton):

1:29 PM Changeset in webkit [146382] by fpizlo@apple.com

18 edits in trunk/Source/JavaScriptCore

DFG implementation of op_strcat should inline rope allocations
https://bugs.webkit.org/show_bug.cgi?id=112780

Reviewed by Oliver Hunt.

This gets rid of the StrCat node and adds a MakeRope node. The MakeRope node can
take either two or three operands, and allocates a rope string with either two or
three fibers. (The magic choice of three children for non-VarArg nodes happens to
match exactly with the magic choice of three fibers for rope strings.)

ValueAdd on KnownString is replaced with MakeRope with two children.

StrCat gets replaced by an appropriate sequence of MakeRope's.

MakeRope does not do the dynamic check to see if its children are empty strings.
This is replaced by a static check, instead. The downside is that we may use more
memory if the strings passed to MakeRope turn out to dynamically be empty. The
upside is that we do fewer checks in the cases where either the strings are not
empty, or where the strings are statically known to be empty. I suspect both of
those cases are more common, than the case where the string is dynamically empty.

This also results in some badness for X86. MakeRope needs six registers if it is
allocating a three-rope. We don't have six registers to spare on X86. Currently,
the code side-steps this problem by just never usign three-ropes in optimized
code on X86. All other architectures, including X86_64, don't have this problem.

This is a shocking speed-up. 9% progressions on both V8/splay and
SunSpider/date-format-xparb. 1% progression on V8v7 overall, and ~0.5% progression
on SunSpider. 2x speed-up on microbenchmarks that test op_strcat.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

dfg/DFGAdjacencyList.h:

(AdjacencyList):
(JSC::DFG::AdjacencyList::removeEdge):

dfg/DFGArgumentsSimplificationPhase.cpp:

(JSC::DFG::ArgumentsSimplificationPhase::removeArgumentsReferencingPhantomChild):

dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):
(JSC::DFG::CSEPhase::eliminateIrrelevantPhantomChildren):
(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::eliminateIrrelevantPhantomChildren):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):
(FixupPhase):
(JSC::DFG::FixupPhase::convertToMakeRope):
(JSC::DFG::FixupPhase::fixupMakeRope):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(DFG):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::~SpeculateCellOperand):
(JSC::DFG::SpeculateCellOperand::gpr):
(JSC::DFG::SpeculateCellOperand::use):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

runtime/JSString.h:

(JSRopeString):

1:25 PM Changeset in webkit [146381] by bfulgham@webkit.org

7 edits
11 adds in trunk/Source/WebKit

[WinCairo] Build the WebKit.dll under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112759

Reviewed by Tim Horton.

WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Update project to

build WinCairo variant using new property sheets.

WebKit.vcxproj/Interfaces/InterfacesDebugWinCairo.props: Added.
WebKit.vcxproj/Interfaces/InterfacesReleaseWinCairo.props: Added.
WebKit.vcxproj/WebKit.sln: Update solution to use WinCairo

build targets for WebKit.dll-related projects.

WebKit.vcxproj/WebKit/WebKit.vcxproj: Update project to build

WinCairo variant using new property sheets.

WebKit.vcxproj/WebKit/cURL.props: Added.
WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Added.
WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Added.
WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:

Update project to build WinCairo variant using new property sheets.

WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebugWinCairo.props: Added.
WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorReleaseWinCairo.props: Added.
WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Update project to

build WinCairo variant using new property sheets.

WebKit.vcxproj/WebKitGUID/WebKitGUIDDebugWinCairo.props: Added.
WebKit.vcxproj/WebKitGUID/WebKitGUIDReleaseWinCairo.props: Added.
WebKit.vcxproj/WinCairo.props: Added.
WebKit.vcxproj/debug_wincairo.props: Added.

1:13 PM Changeset in webkit [146380] by eric.carlson@apple.com

36 edits in trunk

Allow ports specific text track menu
https://bugs.webkit.org/show_bug.cgi?id=112800

Reviewed by Dean Jackson.

Source/WebCore:

No new tests, existing tests updated for changes.

English.lproj/Localizable.strings: Add localizable strings for text track names.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::setSelectedTextTrack): toggleTrackAtIndex -> setSelectedTextTrack.
(WebCore::HTMLMediaElement::userPrefersCaptions): userPrefersCaptions -> shouldShowCaptions.
(WebCore::HTMLMediaElement::userIsInterestedInThisTrackKind): Get preferences from CaptionUserPreferences

instead of from Settings.

(WebCore::HTMLMediaElement::setSelectedTextTrack): Renamed from toggleTrackAtIndex. Now takes

a TextTrack* instead of an int.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Don't force a recalculation unless

captions are enabled/disabled to avoid unnecessary thrash.

html/HTMLMediaElement.h:

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Use the menu to track

map instead of just the track index.

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Build and configure the

menu from the menu to track map.

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Start with a list

of tracks already sorted according to platform specific rules. Build a menu to track map
so tracks are retained while the menu is visible.

html/shadow/MediaControlElements.h:

html/shadow/MediaControls.cpp:

(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged so the

track menu will be rebuilt before it is shown again.

html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::containsOnlyForcedSubtitles): New, passthrough to the private track.
(WebCore::InbandTextTrack::isMainProgramContent): Ditto.
(WebCore::InbandTextTrack::isEasyToRead): Ditto.

html/track/InbandTextTrack.h:
html/track/TextTrack.h:

html/track/TextTrackList.cpp:

(WebCore::TextTrackList::contains): New.

html/track/TextTrackList.h:

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::CaptionUserPreferences): Pull in from .h ditto.
(WebCore::CaptionUserPreferences::~CaptionUserPreferences): Ditto.
(WebCore::CaptionUserPreferences::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferences::setShouldShowCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersCaptions): Ditto.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersSubtitles): Ditto.
(WebCore::CaptionUserPreferences::userPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::setUserPrefersTextDescriptions): Ditto.
(WebCore::CaptionUserPreferences::displayNameForTrack): Ditto.
(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Ditto.

page/CaptionUserPreferences.h:

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Renamed from userPrefersCaptions.
(WebCore::CaptionUserPreferencesMac::userPrefersCaptions): New.
(WebCore::CaptionUserPreferences::userPrefersSubtitles): Ditto.
(WebCore::trackDisplayName): Update logic used to build track title.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): Call trackDisplayName.
(WebCore::textTrackCompare): Text track title sort comparison function.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): New. Sort the list of tracks

according to title, language, and user preferences.

platform/Language.cpp:

(WebCore::displayNameForLanguageLocale): Don't leak the CFLocale.

platform/LocalizedStrings.cpp:

(WebCore::textTrackCountryAndLanguageMenuItemText): New.
(WebCore::textTrackLanguageMenuItemText): Ditto.
(WebCore::closedCaptionTrackMenuItemText): Ditto.
(WebCore::sdhTrackMenuItemText): Ditto.
(WebCore::easyReaderTrackMenuItemText): Ditto.

platform/LocalizedStrings.h:

platform/graphics/InbandTextTrackPrivate.h:
platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::containsOnlyForcedSubtitles): New, return AVFoundation property.
(WebCore::InbandTextTrackPrivateAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateAVFObjC::isEasyToRead): Ditto.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::setShouldDisplayTrackKind): Set setting via CaptionUserPreferences

instead of from Settings.

(WebCore::InternalSettings::shouldDisplayTrackKind): Get setting from CaptionUserPreferences

instead of from Settings.

Source/WebKit:

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new exports.
win/WebKit.vcproj/WebKitExports.def.in: Ditto.

LayoutTests:

media/track/track-user-preferences-expected.txt:
media/track/track-user-preferences.html:
media/video-controls-captions-trackmenu-localized.html:
media/video-controls-captions-trackmenu-sorted.html:
media/video-controls-captions-trackmenu.html:
platform/mac/media/video-controls-captions-trackmenu-expected.txt:
platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:

1:07 PM Changeset in webkit [146379] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

[GTK] Clean up TemporaryLinkStubs.cpp
https://bugs.webkit.org/show_bug.cgi?id=112820

Reviewed by Philippe Normand.

Clean up the TemporaryLinkStubs.cpp file, removing unnecessary includes and prettifying the code.

No new tests - no new functionality.

platform/gtk/TemporaryLinkStubs.cpp:

(WebCore):
(WebCore::getSupportedKeySizes):
(WebCore::signedPublicKeyAndChallengeString):
(WebCore::userIdleTime):

12:27 PM Changeset in webkit [146378] by commit-queue@webkit.org

8 edits in trunk/Source

Remove PlatformEvent::GestureDoubleTap
https://bugs.webkit.org/show_bug.cgi?id=93045

Patch by Yufeng Shen <miletus@chromium.org> on 2013-03-20
Reviewed by Antonio Gomes.

Source/WebCore:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore and replaced by GestureTap with
tap count 2, so remove it.

Test: We are removing something that is not used, so
no new test. All existing tests pass.

dom/GestureEvent.cpp:

(WebCore::GestureEvent::create):

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

platform/PlatformEvent.h:
platform/chromium/PopupContainer.cpp:

(WebCore::PopupContainer::handleGestureEvent):

Source/WebKit/chromium:

PlatformEvent::GestureDoubleTap is not currently
used in WebCore so remove it.

src/WebInputEventConversion.cpp:

(WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):

12:22 PM Changeset in webkit [146377] by ojan@chromium.org

7 edits in trunk/Source/WebCore

Move repaint methods from RenderObject to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=112773

Reviewed by Julien Chaffraix.

repaintOverhangingFloats and repaintDuringLayoutIfMoved are only ever called
on RenderBoxes, so don't need to be on RenderObject. This also lets us
devirtualize repaintDuringLayoutIfMoved.

rendering/RenderBox.h:

(WebCore::RenderBox::repaintOverhangingFloats):

rendering/RenderObject.cpp:
rendering/RenderObject.h:

12:22 PM Changeset in webkit [146376] by roger_fong@apple.com

2 edits in trunk/Tools

Test fix for Win EWS bots, catch various errors and restart script if necessary.

EWSTools/start-queue-win.sh:

12:19 PM Changeset in webkit [146375] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Add a feature observer for RenderDeprecatedFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=112740

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-20
Reviewed by Tony Chang.

No new tests - only adding measurements.

page/FeatureObserver.h:

Add constants for RenderDeprecatedFlexibleBox, and add separate
constants for its use in the UI and in extensions.

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
Call FeatureObserver. Check the document()->url() to see which
constant to use.

12:09 PM Changeset in webkit [146374] by skyostil@chromium.org

2 edits in trunk/Tools

Unreviewed, add myself to committers.py.

11:56 AM Changeset in webkit [146373] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Autosize should use documentRect height instead of scrollHeight
https://bugs.webkit.org/show_bug.cgi?id=112770

Reviewed by David Levin.

Autosizing fails to compute the correct height if the root element is very
small but the document has significant overflow.

No new tests; autosizing is not currently exposed in a testable way on Mac.

page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):

11:56 AM Changeset in webkit [146372] by mrowe@apple.com

2 edits in trunk/Source/WTF

FastMalloc scavenge timer specifies an overly narrow leeway value.

Reviewed by Alexey Proskuryakov.

There's no need to allow only 1ms of leeway on a 2s timer.

wtf/FastMalloc.cpp:

(WTF::TCMalloc_PageHeap::initializeScavenger): Bump the leeway window
to 10% of the scavenge timer.

11:50 AM Changeset in webkit [146371] by jchaffraix@webkit.org

3 edits
8 adds in trunk

[CSS Grid Layout] Improper repainting when grid item change their position
https://bugs.webkit.org/show_bug.cgi?id=112749

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/css-grid-layout/grid-element-change-columns-repaint.html

fast/css-grid-layout/grid-element-change-rows-repaint.html
fast/css-grid-layout/grid-item-change-column-repaint.html
fast/css-grid-layout/grid-item-change-row-repaint.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutGridItems):
Added a call to repaintDuringLayoutIfMoved to repaint moving grid items.

LayoutTests:

fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
fast/css-grid-layout/grid-element-change-columns-repaint.html: Added.
fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
fast/css-grid-layout/grid-element-change-rows-repaint.html: Added.

Those are added testing for the grid element's change. They were already passing due to
the LayoutRepainter in RenderGrid::layoutBlock.

fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
fast/css-grid-layout/grid-item-change-column-repaint.html: Added.
fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
fast/css-grid-layout/grid-item-change-row-repaint.html: Added.

New testing, was failing before this change.

11:35 AM Changeset in webkit [146370] by kareng@chromium.org

1 edit in branches/chromium/1447/Source/WebCore/bindings/v8/V8LazyEventListener.cpp

Merge 146344 "[v8] unsafe persistent access in V8LazyEventListener"

[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807

Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.

No new tests.

bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12512013

11:34 AM Changeset in webkit [146369] by kareng@chromium.org

1 add in branches/chromium/1447/codereview.settings

for drovering

11:33 AM Changeset in webkit [146368] by kareng@chromium.org

1 copy in branches/chromium/1447

branching to merge a v8 fix

11:24 AM Changeset in webkit [146367] by roger_fong@apple.com

2 edits in trunk/Source/WebKit

AppleWin VS2010 build fix.

WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

11:20 AM Changeset in webkit [146366] by anilsson@rim.com

2 edits in trunk/Source/WebCore

[BlackBerry] compositing/iframes/scroll-fixed-transformed-element.html fails in manual testing
https://bugs.webkit.org/show_bug.cgi?id=112806

Reviewed by Antonio Gomes.

PR 283363

When scrolling the iframe, the position: fixed element is correctly
positioned, that is, as if it was fixed with respect to the iframe's
viewport. When scrolling the main frame however, the fixed pos element
was positioned as if it was fixed with respect to the main frame's
viewport.

Fixed by falling back to using the WebKit-thread scroll position for
fixed positioning in LayerRenderer, if the override doesn't have a
position currently set, i.e. if we are not currently scrolling the
iframe.

The effects of the bug are only visual, i.e. not detectable by DRT.

Manually testable using compositing/iframes/scroll-fixed-transformed-element.html

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::updateLayersRecursive):

11:17 AM Changeset in webkit [146365] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[V8] Simplify implementation of EnforceRange conversions
https://bugs.webkit.org/show_bug.cgi?id=112758

Patch by Michael Pruett <michael@68k.org> on 2013-03-20
Reviewed by Kentaro Hara.

Factor out EnforceRange conversion into a helper function.
Simplify calculation for truncation.

Tests: fast/js/webidl-type-mapping.html

storage/indexeddb/cursor-advance.html
storage/indexeddb/cursor-advance-workers.html
storage/indexeddb/intversion-bad-parameters.html

bindings/v8/V8Binding.cpp:

(WebCore::enforceRange):
(WebCore):
(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

11:06 AM Changeset in webkit [146364] by commit-queue@webkit.org

9 edits in trunk/Source

Remove Local/Remote and RTCStatsElement from WebRTCStats API
https://bugs.webkit.org/show_bug.cgi?id=112678

Patch by Harald Alvestrand <hta@google.com> on 2013-03-20
Reviewed by Adam Barth.

Source/Platform:

chromium/public/WebRTCStatsResponse.h:

(WebRTCStatsResponse):

Source/WebCore:

Pure removal, remaining functionality covered by existing test.

Modules/mediastream/RTCStatsReport.cpp:
Modules/mediastream/RTCStatsReport.h:

(RTCStatsReport):

Modules/mediastream/RTCStatsResponse.cpp:
Modules/mediastream/RTCStatsResponse.h:

(RTCStatsResponse):

platform/chromium/support/WebRTCStatsResponse.cpp:
platform/mediastream/RTCStatsResponseBase.h:

(RTCStatsResponseBase):

10:56 AM Changeset in webkit [146363] by jocelyn.turcotte@digia.com

2 edits in trunk

[Qt] Define MODULE_VERSION
https://bugs.webkit.org/show_bug.cgi?id=112808

Reviewed by Allan Sandfeld Jensen.

Upstream http://codereview.qt-project.org/49052
Use 5.2.0 as this is the next release that will be branched from trunk.

.qmake.conf:

10:33 AM Changeset in webkit [146362] by xingnan.wang@intel.com

2 edits in trunk/Source/WebCore

ASSERTION FAILED: !m_renderingAutomaticPullNodes.size()
https://bugs.webkit.org/show_bug.cgi?id=112777

Reviewed by Chris Rogers.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::~AudioContext):

10:28 AM Changeset in webkit [146361] by commit-queue@webkit.org

13 edits
2 adds in trunk

Copy-paste should not spellcheck when continuous spellcheck is turned off
https://bugs.webkit.org/show_bug.cgi?id=112464

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-20
Reviewed by Ryosuke Niwa.

Source/autotools/symbols.filter: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.

Source/WebCore:

Test: editing/spelling/spellcheck-paste-continuous-disabled.html

WebCore.exp.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
WebCore.order: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.
editing/Editor.cpp:

(WebCore::Editor::replaceSelectionWithFragment): Do not spellcheck if continuous spellcheck is turned off.

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Leave continuous spellcheck turned on after a test.
(WebCore::Internals::setContinuousSpellCheckingEnabled): Let tests enable and disable continuous spellcheck.
(WebCore):

testing/Internals.h: Let tests enable and disable continuous spellcheck.

(Internals):

testing/Internals.idl: Let tests enable and disable continuous spellcheck.

Source/WebKit/win:

WebKit.vcproj/WebKitExports.def.in: Export WebCore::Editor::isContinuousSpellCheckingEnabled() and WebCore::Editor::toggleContinuousSpellChecking() for use by internals.

LayoutTests:

editing/spelling/spellcheck-paste-continuous-disabled-expected.txt: Added expected results for pasting when continuous spellcheck is turned off.
editing/spelling/spellcheck-paste-continuous-disabled.html: Added a test for pasting with continuous spellcheck turned off.
platform/mac-wk2/TestExpectations: Skip spellcheck-paste-continuous-disabled.html, because it is a slight modification of spellcheck-paste-disabled.html, which is also skipped in mac-wk2.

10:22 AM Changeset in webkit [146360] by acolwell@chromium.org

9 edits
2 adds in trunk

Add support for MediaSource::isTypeSupported()
https://bugs.webkit.org/show_bug.cgi?id=112301

Reviewed by Darin Fisher.

Source/Platform:

chromium/public/WebMimeRegistry.h:

(WebMimeRegistry): Added supportsMediaSourceMIMEType() method.

Source/WebCore:

Test: http/tests/media/media-source/video-media-source-is-type-supported.html

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer): Added isTypeSupported() call to verify parameters

pass into this method.

(WebCore::MediaSource::isTypeSupported):
(WebCore):

Modules/mediasource/MediaSource.h:

(MediaSource):

Modules/mediasource/MediaSource.idl: Added isTypeSupported().
platform/MIMETypeRegistry.h:

(MIMETypeRegistry): Added isSupportedMediaSourceMIMEType().

platform/chromium/MIMETypeRegistryChromium.cpp:

(WebCore):
(WebCore::MIMETypeRegistry::isSupportedMediaSourceMIMEType): Implemented in terms of WebMimeRegistry::isSupportedMediaSourceMIMEType.

LayoutTests:

http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Added. Reflects Chromium expectations.

Valid MP4 type strings will return true
instead of false in Chrome builds.

http/tests/media/media-source/video-media-source-is-type-supported.html: Added.

10:18 AM Changeset in webkit [146359] by caio.oliveira@openbossa.org

2 edits in trunk/Tools

Unreviewed. Adding another email for me.

Scripts/webkitpy/common/config/committers.py:

9:56 AM Changeset in webkit [146358] by bfulgham@webkit.org

3 edits in trunk/Source/WebCore

[WinCairo] Unreviewed VS2010 build correction.

WebCore.vcxproj/WebCore.vcxproj: Enable build of NetworkStorageSessionStub.cpp

for WinCairo port.

WebCore.vcxproj/WebCore.vcxproj.filters: Correct build type of

CookieJarCurl from 'custom' to 'C++ source file'

9:55 AM Changeset in webkit [146357] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[V8] Rename DOMDataStore::isMainWorldObject
https://bugs.webkit.org/show_bug.cgi?id=112817

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-20
Reviewed by Jochen Eisinger.

No new tests (no changes in functionality).

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperFast):
(WebCore::DOMDataStore::getWrapper):
(WebCore::DOMDataStore::getWrapperForMainWorld):
(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::canExistInWorker):

9:49 AM Changeset in webkit [146356] by abecsi@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] Clean up sanity checks related to gesture recognition
https://bugs.webkit.org/show_bug.cgi?id=112679

Reviewed by Jocelyn Turcotte.

The only callers of the panGestureActive and pinchGestureActive member
functions of the page viewport controller client are event delivery
related sanity check assers, thus they can be replaced by checking
for the corresponding internal states and therefore the superfluous
members can be removed.
Also update other asserts in the page viewport controller client to
be more accurate about the expected states.

UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::panGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):

UIProcess/qt/PageViewportControllerClientQt.h:

(PageViewportControllerClientQt):

UIProcess/qt/QtWebPageEventHandler.cpp:

(WebKit::QtWebPageEventHandler::handleInputEvent):

9:45 AM Changeset in webkit [146355] by abecsi@webkit.org

6 edits in trunk/Source/WebKit2

[Qt][WK2] Refactor handling of content suspension to properly cover corner cases
https://bugs.webkit.org/show_bug.cgi?id=111751

Reviewed by Jocelyn Turcotte.

The current suspend / resume infrastructure turned out to be insufficient to cover
all corner cases during transitions between gestures of complex gesture chains.

The requirements for robust suspend / resume handling are:

Keep the content suspended while the user is continuously interacting,

eg. does not lift the finger between transition from a pan to a pinch gesture
and vice versa.

The content should not be suspended unnecessarily (like for a tap gesture),

only during panning and scroll animation (flick), as well as pinch zoom and scale
animation (also includes double-tap-to-zoom).

The content should never end up stuck in suspended state after long gesture

chains and continuous interaction.

This patch reintroduces reference counting based suspension in form of a new
ViewportInteractionTracker member class to make it possible to reliably control the
suspend / resume cycles during scrolling and scaling.
During continuous gestures, while the user is interacting, the reference count is
increased without actually suspending the content to prevent resuming unnecessarily
during continuous interaction. At the same time this also assures that the page is
not suspended for simple tap gestures, which was a side-effect of the previous
approach based on update deferrers.
The newly added functionality replaces boolean members that tried to achive the
above requirements.
Additionally this patch also removes the redundant m_hasSuspendedContent member
from the PageViewportController since WebPageProxy already keeps this information.

UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::updateMinimumScaleToFit):

UIProcess/PageViewportController.h:

(PageViewportController):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::areActiveDOMObjectsAndAnimationsSuspended):

UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::begin):
(WebKit):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::end):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::pageItemPositionChanged):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureRequestUpdate):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
(WebKit::PageViewportControllerClientQt::didChangeContentsSize):

UIProcess/qt/PageViewportControllerClientQt.h:

(ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::ViewportInteractionTracker):
(WebKit::PageViewportControllerClientQt::ViewportInteractionTracker::inProgress):
(PageViewportControllerClientQt):

9:19 AM Changeset in webkit [146354] by loislo@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Provide Overview pane for better user expirience.
https://bugs.webkit.org/show_bug.cgi?id=112496

Reviewed by Yury Semikhatsky.

This patch implements basic part of Overview Pane in FlameChart.
The idea of the patch is to move everything into chart-container element.
And put OverviewGrid into new overview-container element.

Drive by change: fix the layout of the flame chart elements.
Drive by change: fix the drag window & drag resizer mechanics
for the case when the parent element has zero offsetLeft.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.OverviewCalculator):
(WebInspector.FlameChart.OverviewCalculator.prototype._updateBoundaries):
(WebInspector.FlameChart.OverviewCalculator.prototype.computePosition):
(WebInspector.FlameChart.OverviewCalculator.prototype.formatTime):
(WebInspector.FlameChart.OverviewCalculator.prototype.maximumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.minimumBoundary):
(WebInspector.FlameChart.OverviewCalculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype._onWindowChanged):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.update):

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._resizerElementStartDragging):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.WindowSelector):

inspector/front-end/TimelineOverviewPane.js:
inspector/front-end/flameChart.css:

(.chart-container .item-anchor):
(.overview-container):
(.chart-container):
(#flame-chart-overview-grid .resources-dividers-label-bar):

inspector/front-end/inspectorCommon.css:

(.resources-divider-label):

9:07 AM Changeset in webkit [146353] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Adding a framework for plumbing CSS warnings from CSSParser/grammar to the Inspector console.

css/CSSParser.cpp:

(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::logError):

css/CSSParser.h:

(CSSParser):
(CSSParser::Location):
(WebCore):

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
(WebCore::StyleSheetContents::parseStringAtLine):

css/StyleSheetContents.h:

(StyleSheetContents):

dom/StyleElement.cpp:

(WebCore::StyleElement::createSheet):

page/PageConsole.cpp:

(WebCore::PageConsole::addMessage):

9:05 AM Changeset in webkit [146352] by kadam@inf.u-szeged.hu

1 edit
1 delete in trunk/LayoutTests

[Qt] Qt 4.8 expected results removal from Trunk.

Reviewed by Csaba Osztrogonác.

platform/qt-4.8/TestExpectations: Removed.
platform/qt-4.8/css1/text_properties/text_transform-expected.txt: Removed.
platform/qt-4.8/editing/selection/regional-indicators-expected.txt: Removed.
platform/qt-4.8/fast/css/dumpAsText/xml-stylesheet-pi-not-in-prolog-expected.txt: Removed.
platform/qt-4.8/fast/dom/Range/surround-contents-font-face-crash-expected.txt: Removed.
platform/qt-4.8/fast/dom/xml-parser-error-message-crash-expected.txt: Removed.
platform/qt-4.8/fast/encoding/dumpAsText/utf-16-no-bom-expected.txt: Removed.
platform/qt-4.8/fast/events/xsl-onload-expected.txt: Removed.
platform/qt-4.8/fast/parser/xml-colon-entity-expected.txt: Removed.
platform/qt-4.8/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Removed.
platform/qt-4.8/fast/parser/xslt-with-html-expected.txt: Removed.
platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Removed.
platform/qt-4.8/fast/text/find-kana-expected.txt: Removed.
platform/qt-4.8/fast/text/find-russian-expected.txt: Removed.
platform/qt-4.8/fast/text/find-soft-hyphen-expected.txt: Removed.
platform/qt-4.8/fast/url/path-expected.txt: Removed.
platform/qt-4.8/fast/xsl/subframe-location-expected.txt: Removed.
platform/qt-4.8/fast/xsl/transform-to-html-expected.txt: Removed.
platform/qt-4.8/fast/xsl/utf8-chunks-expected.txt: Removed.
platform/qt-4.8/fast/xsl/xslt-bad-import-uri-expected.txt: Removed.
platform/qt-4.8/fast/xsl/xslt-doc-noenc-expected.txt: Removed.
platform/qt-4.8/fast/xsl/xslt-entity-enc-expected.txt: Removed.
platform/qt-4.8/fast/xsl/xslt-entity-expected.png: Removed.
platform/qt-4.8/fast/xsl/xslt-mismatched-tags-in-xslt-expected.txt: Removed.
platform/qt-4.8/fast/xsl/xslt-recursion-expected.txt: Removed.
platform/qt-4.8/http/tests/misc/location-test-xsl-style-sheet-expected.txt: Removed.
platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-allowed-expected.txt: Removed.
platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-img-blocked-expected.txt: Removed.
platform/qt-4.8/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Removed.
platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.png: Removed.
platform/qt-4.8/http/tests/security/cookies/first-party-cookie-allow-xslt-expected.txt: Removed.
platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.png: Removed.
platform/qt-4.8/http/tests/security/cookies/third-party-cookie-blocking-xslt-expected.txt: Removed.
platform/qt-4.8/http/tests/security/xss-DENIED-xml-external-entity-expected.txt: Removed.
platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Removed.
platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Removed.
platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt: Removed.
platform/qt-4.8/http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Removed.
platform/qt-4.8/http/tests/xmlhttprequest/methods-expected.txt: Removed.
platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-async-expected.txt: Removed.
platform/qt-4.8/http/tests/xmlhttprequest/workers/methods-expected.txt: Removed.
platform/qt-4.8/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt: Removed.
platform/qt-4.8/svg/custom/bug45331-expected.png: Removed.
platform/qt-4.8/svg/custom/bug45331-expected.txt: Removed.
platform/qt-4.8/svg/custom/bug78807-expected.txt: Removed.
platform/qt-4.8/svg/custom/use-invalid-html-expected.txt: Removed.
platform/qt-4.8/svg/custom/use-invalid-style-expected.txt: Removed.
platform/qt-4.8/svg/hixie/error/dumpAsText/004-expected.txt: Removed.
platform/qt-4.8/svg/hixie/error/dumpAsText/005-expected.txt: Removed.

8:59 AM Changeset in webkit [146351] by junov@google.com

27 edits in trunk

[Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
https://bugs.webkit.org/show_bug.cgi?id=112605

Reviewed by James Robinson.

Source/WebCore:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

No new tests: Affected code paths covered by existing tests.

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

html/HTMLCanvasElement.h:
page/Settings.in:
platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
(ImageBuffer):

platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/chromium/Canvas2DLayerBridge.cpp:

(WebCore::Canvas2DLayerBridge::Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::~Canvas2DLayerBridge):
(WebCore::Canvas2DLayerBridge::prepareForDraw):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecordingChanged):
(WebCore::Canvas2DLayerBridge::storageAllocatedForRecording):
(WebCore::Canvas2DLayerBridge::freeMemoryIfPossible):
(WebCore::Canvas2DLayerBridge::flush):
(WebCore::Canvas2DLayerBridge::skCanvas):
(WebCore::Canvas2DLayerBridge::prepareTexture):
(WebCore::Canvas2DLayerBridge::contextAcquired):

platform/graphics/chromium/Canvas2DLayerBridge.h:

(WebCore::Canvas2DLayerBridge::create):
(Canvas2DLayerBridge):

platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::createAcceleratedCanvas):
(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::ImageBuffer::ImageBuffer):

platform/graphics/wx/ImageBufferWx.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Source/WebKit/chromium:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

public/WebSettings.h:

(WebKit::WebSettings::setDeferred2dCanvasEnabled):

src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDeferred2dCanvasEnabled):

tests/Canvas2DLayerBridgeTest.cpp:

(Canvas2DLayerBridgeTest::fullLifecycleTest):

tests/Canvas2DLayerManagerTest.cpp:

(FakeCanvas2DLayerBridge::FakeCanvas2DLayerBridge):

Tools:

Deleting all the code that was used for propagating and supporting
the Chromium setting for disabling deferred 2d canvas rendering.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):
(TestShell::runFileTest):

DumpRenderTree/chromium/TestShell.h:

(TestShell):

LayoutTests:

Marked some 2d canvas tests as failing. These tests are using the
two point radial gradient API. The bug was already present in
chromium. Starts getting detected in DRT with this change.
Related: crbug.com/222140

8:42 AM Changeset in webkit [146350] by mkwst@chromium.org

6 edits in trunk

Drop full URLs from cross-domain access errors caused by 'document.domain' mismatches.
https://bugs.webkit.org/show_bug.cgi?id=112813

Reviewed by Timothy Hatcher.

Source/WebCore:

Following up on http://wkbug.com/112042, this patch brings 'document.domain'
mismatch error messages into line with the newly origin-only default
message. There will probably be two or three more patches in this series
just to keep the rebaselines down to something managably reviewable.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

Move the default message redefinition up out of the final 'return' so
that 'document.domain' mismatch errors grab the new text.

LayoutTests:

http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:

8:40 AM Changeset in webkit [146349] by commit-queue@webkit.org

10 edits in trunk/Source

Web Inspector: Add promptText param to Page.handleJavaScriptDialog
https://bugs.webkit.org/show_bug.cgi?id=112706

Patch by Ken Kania <kkania@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

Source/WebCore:

inspector/Inspector.json:
inspector/InspectorClient.h:

(WebCore::InspectorClient::handleJavaScriptDialog):

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::handleJavaScriptDialog):

inspector/InspectorPageAgent.h:

Source/WebKit/chromium:

src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::handleJavaScriptDialog):

src/InspectorClientImpl.h:

(InspectorClientImpl):

src/WebDevToolsAgentImpl.cpp:

(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):

src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

8:28 AM Changeset in webkit [146348] by Carlos Garcia Campos

1 copy in releases/WebKitGTK/webkit-1.11.92

Tagging the WebKitGTK+ 1.11.92 release

8:10 AM Changeset in webkit [146347] by kadam@inf.u-szeged.hu

3 edits in trunk/Tools

[Qt] Qt 4.8 tool related stuff removal from webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=112699.

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._search_paths):
(QtPort._port_specific_expectations_files):

Scripts/webkitpy/layout_tests/port/qt_unittest.py:

(QtPortTest):
(QtPortTest._assert_search_path):
(QtPortTest._assert_expectations_files):

8:09 AM Changeset in webkit [146346] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Update NEWS and Versions.m4 for 1.11.92 release.

Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

NEWS: Added release notes for 1.11.92.

7:59 AM Changeset in webkit [146345] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: fix SourceFrame.js compilation warning
https://bugs.webkit.org/show_bug.cgi?id=112804

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.

No new tests: no change in behavior.

Explicitly parse lineNumber from object property name.
Add type annotations to ensure addMessageToSource is monomorphic.

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.clearMessages):

7:34 AM Changeset in webkit [146344] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[v8] unsafe persistent access in V8LazyEventListener
https://bugs.webkit.org/show_bug.cgi?id=112807

Patch by Dan Carney <dcarney@google.com> on 2013-03-20
Reviewed by Kentaro Hara.

No new tests.

bindings/v8/V8LazyEventListener.cpp:

(WebCore::toObjectWrapper):

7:32 AM Changeset in webkit [146343] by anilsson@rim.com

3 edits in trunk/Source/WebCore

[BlackBerry] Enable appropriate vertex attribute arrays in LayerRenderer::useProgram()
https://bugs.webkit.org/show_bug.cgi?id=112757

Reviewed by Rob Buis.

PR 306465

Make the LayerRenderer and associated code more bullet-proof when it
comes to enabling vertex attribute arrays, by enabling them already
when LayerRenderer::useProgram() is called. This fixes a bug where the
video hole punch rectangle wasn't punched when preceding rendering
caused the vertex attribute array at index 0 to be disabled, such as
when rendering the text selection overlay immediately before video.

A number of places where the position attribute index was hard-coded
to 0 were also fixed. This causes no change in behavior, the position
attribute was really at 0, but nonetheless that shouldn't be hardcoded.

The effects of this patch are only manually testable.

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::useProgram):

7:30 AM Changeset in webkit [146342] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] implement highlightRange method
https://bugs.webkit.org/show_bug.cgi?id=112802

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

Implement highlightRange/removeHighlight methods in

CodeMirrorTextEditor.

Update TextEditor interface closure annotations.

No new tests.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.prototype.removeHighlight):
(WebInspector.CodeMirrorTextEditor.prototype.highlightRange):

inspector/front-end/DefaultTextEditor.js:
inspector/front-end/TextEditor.js:

7:28 AM Changeset in webkit [146341] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] show source location for codemirror text editor
https://bugs.webkit.org/show_bug.cgi?id=112798

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

No new tests.

Implement CodeMirrorTextEditor.copyRange method
Fire "selectionChange" event for text editor delegate from

CodeMirrorTextEditor.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.copyRange):
(WebInspector.CodeMirrorTextEditor.prototype._cursorActivity):

7:18 AM Changeset in webkit [146340] by allan.jensen@digia.com

7 edits in trunk

[Qt] Enable kerning by default
https://bugs.webkit.org/show_bug.cgi?id=112704

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Enable default kerning when fast kerning is available.

To support layout tests that depend on kerning being off by default,
a method is added to DumpRenderTreeSupportQt to reset the default.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::resetDefaultTypesettingFeatures):

WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/InitWebCoreQt.cpp:

(WebKit::initializeWebKitQt):

Tools:

Disable kerning by default, since some reference test expectations
expect kerning to be default off.

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

(WTR::activateFonts):

7:06 AM Changeset in webkit [146339] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Implement and32 on MIPS platform
https://bugs.webkit.org/show_bug.cgi?id=112665

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-20
Reviewed by Zoltan Herczeg.

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::and32): Added missing method.
(MacroAssemblerMIPS):

6:38 AM Changeset in webkit [146338] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Fix make distcheck.

GNUmakefile.am: Add WebKitFeatures.txt and WebKitFeatures.h to

DISTCLEANFILES.

6:29 AM Changeset in webkit [146337] by zeno.albisser@digia.com

3 edits in trunk/Tools

[Qt] Remove empty function stubs from TestRunnerQt.
https://bugs.webkit.org/show_bug.cgi?id=112799

We are reducing the code in TestRunnerQt step by step,
in order to finally replace all of it with the generic
TestRunner implementation.
This patch removes several simple function stubs that
currently do not implement any actual functionality.

Reviewed by Kenneth Rohde Christiansen.

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

6:24 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

6:21 AM Changeset in webkit [146336] by kov@webkit.org

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merged 146335 - [or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).

or.po: Added.

6:16 AM Changeset in webkit [146335] by kov@webkit.org

1 edit
1 add in trunk/Source/WebCore/platform/gtk/po

[or] Updated WebKitGTK+ Translation for Odia [or] language.
https://bugs.webkit.org/show_bug.cgi?id=103037

Patch by Manoj Kumar Giri <mgiri@redhat.com> on 2013-03-20
Rubber-stamped by Gustavo Noronha Silva (kov).

or.po: Added.

6:08 AM Changeset in webkit [146334] by commit-queue@webkit.org

4 edits in trunk

Unreviewed, rolling out r146331.
http://trac.webkit.org/changeset/146331
https://bugs.webkit.org/show_bug.cgi?id=112795

Does not work as expected (Requested by carewolf on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

Source/WebCore:

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

LayoutTests:

platform/qt/TestExpectations:

5:43 AM Changeset in webkit [146333] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Resources] Local Storage: "Add item" row height doesn't match underlying grid.
https://bugs.webkit.org/show_bug.cgi?id=112433

Reviewed by Pavel Feldman.

Fixed cell height to correspond grid step.

inspector/front-end/dataGrid.css:

(.data-grid td): Fixed cell height to correspond grid step.

5:26 AM Changeset in webkit [146332] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
https://bugs.webkit.org/show_bug.cgi?id=112687

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.

Hide the SearchBar by default on window creation.

MiniBrowser/efl/main.c:

(window_create):

4:53 AM Changeset in webkit [146331] by allan.jensen@digia.com

4 edits in trunk

[Qt] New fast/text/word-space-with-kerning-3.html fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=112668

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Kerning is on by default in Qt. This means we need to disable it
when WebCore does not request it.

platform/graphics/qt/FontQt.cpp:

(WebCore::Font::initFormatForTextLayout):

LayoutTests:

platform/qt/TestExpectations:

4:51 AM Changeset in webkit [146330] by loislo@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: OverviewGrid rename classes according to names of js classes.
https://bugs.webkit.org/show_bug.cgi?id=112786

Reviewed by Yury Semikhatsky.

It is a part of meta bug 'extract OverviewGrid from TimelineOverviewPane'.
As the last step it renames timeline-...... classes to overview-grid-...... classes
and moves them to inspectorCommon.css

inspector/front-end/OverviewGrid.js:

(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):

inspector/front-end/inspectorCommon.css:

(.overview-grid-window-selector):
(.overview-grid-window):
(.overview-grid-dividers-background):
(.overview-grid-window-rulers):
(.overview-grid-window-resizer):

inspector/front-end/timelinePanel.css:

(.timeline-frame-overview .overview-grid-window):
(.timeline-frame-overview .overview-grid-dividers-background):

4:50 AM Changeset in webkit [146329] by commit-queue@webkit.org

11 edits
5 moves
1 add
1 delete in trunk/Tools

Unreviewed, rolling out r146304.
http://trac.webkit.org/changeset/146304
https://bugs.webkit.org/show_bug.cgi?id=112788

to many expectations to update (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(WebKit):

DumpRenderTree/chromium/TestShellMac.mm:

(platformInit):

DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.

(WebThemeControlDRTWin::WebThemeControlDRTWin):
(WebThemeControlDRTWin::~WebThemeControlDRTWin):
(WebThemeControlDRTWin::box):
(WebThemeControlDRTWin::line):
(WebThemeControlDRTWin::triangle):
(WebThemeControlDRTWin::roundRect):
(WebThemeControlDRTWin::oval):
(WebThemeControlDRTWin::circle):
(WebThemeControlDRTWin::nestedBoxes):
(WebThemeControlDRTWin::markState):
(WebThemeControlDRTWin::draw):
(WebThemeControlDRTWin::drawTextField):
(WebThemeControlDRTWin::drawProgressBar):

DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.

(WebThemeControlDRTWin):

DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.

(WebThemeEngineDRTMac):

DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.

(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.

(webRectToSkIRect):
(drawControl):
(drawTextField):
(drawProgressBar):
(WebThemeEngineDRTWin::paintButton):
(WebThemeEngineDRTWin::paintMenuList):
(WebThemeEngineDRTWin::paintScrollbarArrow):
(WebThemeEngineDRTWin::paintScrollbarThumb):
(WebThemeEngineDRTWin::paintScrollbarTrack):
(WebThemeEngineDRTWin::paintSpinButton):
(WebThemeEngineDRTWin::paintTextField):
(WebThemeEngineDRTWin::paintTrackbar):
(WebThemeEngineDRTWin::paintProgressBar):
(WebThemeEngineDRTWin::getSize):

DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.

(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):

4:43 AM Changeset in webkit [146328] by commit-queue@webkit.org

3 edits
1 delete in trunk/LayoutTests

Unreviewed, rolling out r146315.
http://trac.webkit.org/changeset/146315
https://bugs.webkit.org/show_bug.cgi?id=112789

followup to 146304 rollout (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Removed.
platform/chromium-win/css1/box_properties/border_right_inline-expected.png:

4:41 AM Changeset in webkit [146327] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rolling out r146316.
http://trac.webkit.org/changeset/146316
https://bugs.webkit.org/show_bug.cgi?id=112790

followup to 146304 rollout (Requested by antonm on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-20

platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:

4:31 AM Changeset in webkit [146326] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: Switch Drawer animation from JavaScript to CSS transitions.
https://bugs.webkit.org/show_bug.cgi?id=112586

This is prerequisite to make Drawer work in overlay mode.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Vsevolod Vlasov.

inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.this.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.immediatelyFinishAnimation):
(WebInspector.Drawer.prototype._getAnimationStyles):

inspector/front-end/UIUtils.js:
inspector/front-end/inspector.css:

(.animate-slow *):
(.animate #main):
(.animate #floating-status-bar-container):
(.animate #drawer):
(.animate #bottom-status-bar-container > *):

4:30 AM Changeset in webkit [146325] by eustas@chromium.org

18 edits in trunk

Web Inspector: [DataGrid] Refactorings.
https://bugs.webkit.org/show_bug.cgi?id=112690

Reviewed by Pavel Feldman.

Source/WebCore:

Avoid using string literals;
Remove unused notifications; turn "populate" to method invocation;
Replace some getters with regular functions.

inspector/front-end/DataGrid.js: Applied refactorings.
inspector/front-end/ApplicationCacheItemsView.js: Adopted changes.
inspector/front-end/BottomUpProfileDataGridTree.js: Ditto.
inspector/front-end/CPUProfileView.js: Ditto.
inspector/front-end/CSSSelectorProfileView.js: Ditto.
inspector/front-end/CookiesTable.js: Ditto.
inspector/front-end/DirectoryContentView.js: Ditto.
inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
inspector/front-end/HeapSnapshotGridNodes.js: Ditto.
inspector/front-end/NativeMemorySnapshotView.js: Ditto.
inspector/front-end/NetworkPanel.js: Ditto.
inspector/front-end/ProfileDataGridTree.js: Ditto.
inspector/front-end/ResourceWebSocketFrameView.js: Ditto.
inspector/front-end/TopDownProfileDataGridTree.js: Ditto.
inspector/front-end/dataGrid.css: Ditto.

LayoutTests:

Adopted changes.

inspector/profiler/heap-snapshot-test.js: Adopted changes.

4:22 AM Changeset in webkit [146324] by allan.jensen@digia.com

7 edits in trunk

[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Set QFont antialiasing settings based on the font smoothing settings in FontDescription.

platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

Source/WebKit/qt:

Export an interface so DRT can also disable font-smoothing like WTR does.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::setShouldUseFontSmoothing):

WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

Set shouldUseFontSmoothing to false to match WebKitTestRunner.

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

4:05 AM Changeset in webkit [146323] by zeno.albisser@digia.com

1 edit
3 adds in trunk/LayoutTests

[Qt] Unreviewed rebaselining after r146206.

The webgl-composite-modes test started failing due to
the newly introduced more restrictive pixel tolerance.
It turns out that the expectation was created without multisampling
enabled. However, Qt does implement this.

platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
platform/qt/fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.

4:04 AM Changeset in webkit [146322] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

ewk_settings_memory_cache_clear should clear JS garbage and release FastMalloc's free pages to OS
https://bugs.webkit.org/show_bug.cgi?id=112536

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-03-20
Reviewed by Gyuyoung Kim.

Added changes to clear JS garbage and release FastMalloc's free pages to OS
while calling ewk_settings_memory_cache_clear API.

ewk/ewk_settings.cpp:

(ewk_settings_memory_cache_clear):

3:15 AM Changeset in webkit [146321] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

[EFL] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111989

Unreviewed EFL gardening

accessibility/aria-scrollbar-role.html passes after r146312.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:

3:01 AM Changeset in webkit [146320] by commit-queue@webkit.org

6 edits
1 add in trunk

[EFL] Disable REQUEST_ANIMATION_FRAME_TIMER to render a new animation frame.
https://bugs.webkit.org/show_bug.cgi?id=112114

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-03-20
Reviewed by Kenneth Rohde Christiansen.

Add a manual test to check the running of scripted transition animation.

ManualTests/animation/transition-on-and-offscreen-animation.html: Added.

Source/WebKit/efl:

Add dummy functions for WK1.

Example test case: ManualTests/animation/transition-on-and-offscreen-animation.html

WebCoreSupport/ChromeClientEfl.cpp: Add dummy functions for WK1.

(WebCore):
(WebCore::ChromeClientEfl::scheduleAnimation):
(WebCore::ChromeClientEfl::serviceScriptedAnimations):

WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WTF:

The issue is that if the animation starts outside of the area covered by keepRects,
the web process does not create tiles of the animation layer and the layer moves
without having any tiles. In order to fix this issue, CoordinatedLayerHost must call
scheduleLayerFlush to create new tiles when the layer enters the area covered by keepRect.
However EFL port didn't call scheduleLayerFlush periodically for animation.
We can tie scripted animations with synchronization of the layer and that already
has been implemented in r123786 by Qt port. This patch is for activating r123786 patch.

The testing is covered by ManualTests/animation/transition-on-and-offscreen-animation.html

wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER.

3:01 AM Changeset in webkit [146319] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Web Inspector: Allow toolbar customization
https://bugs.webkit.org/show_bug.cgi?id=112440

Adds a tools menu item that allows the user to show/hide
inspector panels on the toolbar.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-20
Reviewed by Yury Semikhatsky.

inspector/front-end/InspectorView.js:
inspector/front-end/Settings.js:

(WebInspector.Settings):
(WebInspector.ExperimentsSettings):

inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.addPanel):
(WebInspector.Toolbar.prototype._isPanelVisibleByDefault):
(WebInspector.Toolbar.prototype.set _hidePanel):
(WebInspector.Toolbar.prototype._showPanel):
(WebInspector.Toolbar.prototype._togglePanelsMenu):

inspector/front-end/inspector.css:

(#toolbar-panels-menu):
(#toolbar-panels-menu:hover):
(#toolbar-panels-menu:active):

inspector/front-end/inspector.html:

2:09 AM Changeset in webkit [146318] by mark.lam@apple.com

26 edits in trunk/Source

Source/JavaScriptCore: Fix incorrect debugger column number value.
https://bugs.webkit.org/show_bug.cgi?id=112741.

Reviewed by Oliver Hunt.

In lexer, parser, and debugger code, renamed column to charPosition.
Convert the charPosition to the equivalent column number before passing it to the debugger.
Changed ScopeNodes to take both a startLocation and an endLocation. This allows FunctionBodyNodes, ProgramNodes, and EvalNodess to emit correct debug hooks with correct starting line and column numbers.
Fixed the Lexer to not reset the charPosition (previously columnNumber) in Lexer::lex().

JavaScriptCore.order:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitExpressionInfo):

bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::toArgumentList):
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):

interpreter/Interpreter.cpp:

(JSC::Interpreter::debug):

convert charPosition to column for the debugger.
interpreter/Interpreter.h:
jit/JITStubs.cpp:

(DEFINE_STUB_FUNCTION(void, op_debug)):

llint/LLIntSlowPaths.cpp:

(LLINT_SLOW_PATH_DECL(slow_op_debug)):

parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createBlockStatement):
(JSC::ASTBuilder::createExprStatement):
(JSC::ASTBuilder::createIfStatement):
(JSC::ASTBuilder::createForLoop):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createVarStatement):
(JSC::ASTBuilder::createReturnStatement):
(JSC::ASTBuilder::createBreakStatement):
(JSC::ASTBuilder::createContinueStatement):
(JSC::ASTBuilder::createTryStatement):
(JSC::ASTBuilder::createSwitchStatement):
(JSC::ASTBuilder::createWhileStatement):
(JSC::ASTBuilder::createDoWhileStatement):
(JSC::ASTBuilder::createWithStatement):
(JSC::ASTBuilder::createThrowStatement):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::createConstStatement):

parser/Lexer.cpp:

(JSC::::setCode):
(JSC::::internalShift):
(JSC::::shift):
(JSC::::lex):

parser/Lexer.h:

(JSC::Lexer::currentCharPosition):
(Lexer):
(JSC::::lexExpectIdentifier):

parser/NodeConstructors.h:

(JSC::Node::Node):

parser/Nodes.cpp:

(JSC::StatementNode::setLoc):
(JSC::ScopeNode::ScopeNode):
(JSC::ProgramNode::ProgramNode):
(JSC::ProgramNode::create):
(JSC::EvalNode::EvalNode):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::create):

parser/Nodes.h:

(JSC::Node::charPosition):
(Node):
(StatementNode):
(JSC::StatementNode::lastLine):
(ScopeNode):
(JSC::ScopeNode::startLine):
(JSC::ScopeNode::startCharPosition):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):

parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseFunctionBody):
(JSC::::parseFunctionInfo):

parser/Parser.h:

(JSC::::parse):

parser/ParserTokens.h:

(JSC::JSTokenLocation::JSTokenLocation):
(JSTokenLocation):

parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createFunctionBody):

Source/WTF: Introducing String::reverseFindLineTerminator().
https://bugs.webkit.org/show_bug.cgi?id=112741.

Reviewed by Oliver Hunt.

This is needed by the JSC debugger code for computing column numbers.

wtf/text/StringImpl.cpp:

(WTF::StringImpl::reverseFindLineTerminator):

wtf/text/StringImpl.h:

(StringImpl):
(WTF::reverseFindLineTerminator):

wtf/text/WTFString.h:

(WTF::String::reverseFindLineTerminator):

2:08 AM Changeset in webkit [146317] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Settings] Add "storage" parameter to WebInspector.Setting
https://bugs.webkit.org/show_bug.cgi?id=112667

Reviewed by Pavel Feldman.

New parameter will allow more options on how long setting will persist.
Possible options are: localStorage, sessionStorage and no-storage.

Additional change: use delete instead of .removeItem to make it possible
use any object as storage.

inspector/front-end/Settings.js:

Added "storage" parameter and used is instead of "window.localStorage".

1:55 AM Changeset in webkit [146316] by antonm@chromium.org

2 edits in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselining after r146304.

platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:

1:43 AM Changeset in webkit [146315] by antonm@chromium.org

3 edits
1 add in trunk/LayoutTests

Unreviewed Chromium gardening.

Rebaselining after r146304.

platform/chromium-mac-snowleopard/css1/box_properties/border_right_inline-expected.png:
platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
platform/chromium-win/css1/box_properties/border_right_inline-expected.png:

1:38 AM Changeset in webkit [146314] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [Network] Fix the bug of WebSocketFrameView crash.
https://bugs.webkit.org/show_bug.cgi?id=112771.

Patch by Pan Deng <pan.deng@intel.com> on 2013-03-20
Reviewed by Pavel Feldman.

WebSocketFrameView crashes when websocket receives an error message, this
patch fixes this problem, and error message will be shown in dataGrid as expected.

No new tests.

inspector/front-end/ResourceWebSocketFrameView.js:

(WebInspector.ResourceWebSocketFrameView): Handle the errorMessage case.

1:34 AM Changeset in webkit [146313] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Remove remainings of obsolete LogLevels and MessageSources from inspector JS part.
https://bugs.webkit.org/show_bug.cgi?id=112709

By the way tuned messagesources in ApplicationCacheGroup.

Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-20
Reviewed by Pavel Feldman.

inspector/front-end/ConsoleMessage.js:

(WebInspector.ConsoleMessageImpl.prototype.toMessageElement):
(WebInspector.ConsoleMessageImpl.prototype.toString):

inspector/front-end/ConsoleModel.js:
inspector/front-end/ExtensionAPI.js:

(defineCommonExtensionSymbols):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
(WebInspector.ExtensionServer.prototype._makeConsoleMessage):

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFinishLoading):
(WebCore::ApplicationCacheGroup::didFail):

1:12 AM Changeset in webkit [146312] by commit-queue@webkit.org

7 edits in trunk

[GTK] accessibility/aria-scrollbar-role.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98358

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-20
Reviewed by Martin Robinson.

Source/WebCore:

Adds support for checking an orientation attribute of accessibility object.
AccessibilityObject that represents ScrollBar element should be ATK_VALUE type.
ScrollBar element can be considered as a Range Widget that is able to expose some
range values.

Test: accessibility/aria-scrollbar-role.html

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):
(getInterfaceMaskFromObject):

Tools:

Adds support for checking accessibility object's orientation.
Orientation is checked by retrieving proper state of accessibility object.

DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(checkElementState):
(AccessibilityUIElement::orientation):

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::orientation):

LayoutTests:

Fixed failing test.

platform/gtk/TestExpectations:

1:07 AM Changeset in webkit [146311] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

Unreviewed. Fixing a typo in libLevelDB_la_CFLAGS assignment - cxflags -> cflags.

GNUmakefile.am:

1:03 AM Changeset in webkit [146310] by zandobersek@gmail.com

3 edits
2 adds in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r146305.

platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt:
platform/gtk/fast/js/global-constructors-expected.txt:
platform/gtk/http/tests/security/contentSecurityPolicy/1.1: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.

12:52 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

12:51 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos

(diff)

12:43 AM Changeset in webkit [146309] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r146089): It broke 20 sputnik tests on ARM traditional and Thumb2
https://bugs.webkit.org/show_bug.cgi?id=112676

Rubber-stamped by Filip Pizlo.

Add one more EABI_32BIT_DUMMY_ARG to make DFG JIT ARM EABI compatible
again after r146089 similar to https://bugs.webkit.org/show_bug.cgi?id=84449

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

12:16 AM Changeset in webkit [146308] by robert@webkit.org

3 edits
2 adds in trunk

Absolute position div without width specified does not reflow its text when it is moved (and computed width changes)
https://bugs.webkit.org/show_bug.cgi?id=112052

Source/WebCore:

Reviewed by Emil A Eklund.

If a positioned block has auto width then any movement means the block needs to be resized.

Test: fast/block/positioned-block-auto-width-movement.html

rendering/style/RenderStyle.cpp:

(WebCore::positionedObjectMoved):
(WebCore::RenderStyle::diff):

LayoutTests:

Reviewed by Emil A Eklund.

fast/block/positioned-block-auto-width-movement-expected.html: Added.
fast/block/positioned-block-auto-width-movement.html: Added.

12:08 AM Changeset in webkit [146307] by Carlos Garcia Campos

30 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Add padding to all public class structs for future expansion without breaking ABI
https://bugs.webkit.org/show_bug.cgi?id=112565

Reviewed by Gustavo Noronha Silva.

Use 4 pointers for most of the classes that are unlikely to grow
and 8 for WebKitWebView and WebKitWebContext.

UIProcess/API/gtk/WebKitBackForwardList.h:

(_WebKitBackForwardListClass):

UIProcess/API/gtk/WebKitBackForwardListItem.h:

(_WebKitBackForwardListItemClass):

UIProcess/API/gtk/WebKitContextMenu.h:

(_WebKitContextMenuClass):

UIProcess/API/gtk/WebKitContextMenuItem.h:

(_WebKitContextMenuItemClass):

UIProcess/API/gtk/WebKitCookieManager.h:

(_WebKitCookieManagerClass):

UIProcess/API/gtk/WebKitDownload.h:

(_WebKitDownloadClass):

UIProcess/API/gtk/WebKitFaviconDatabase.h:

(_WebKitFaviconDatabaseClass):

UIProcess/API/gtk/WebKitFileChooserRequest.h:

(_WebKitFileChooserRequestClass):

UIProcess/API/gtk/WebKitFindController.h:

(_WebKitFindControllerClass):

UIProcess/API/gtk/WebKitFormSubmissionRequest.h:

(_WebKitFormSubmissionRequestClass):

UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h:

(_WebKitGeolocationPermissionRequestClass):

UIProcess/API/gtk/WebKitHitTestResult.h:

(_WebKitHitTestResultClass):

UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:

(_WebKitNavigationPolicyDecisionClass):

UIProcess/API/gtk/WebKitPlugin.h:

(_WebKitPluginClass):

UIProcess/API/gtk/WebKitPolicyDecision.h:

(_WebKitPolicyDecisionClass):

UIProcess/API/gtk/WebKitPrintOperation.h:

(_WebKitPrintOperationClass):

UIProcess/API/gtk/WebKitResponsePolicyDecision.h:

(_WebKitResponsePolicyDecisionClass):

UIProcess/API/gtk/WebKitSecurityManager.h:

(_WebKitSecurityManagerClass):

UIProcess/API/gtk/WebKitSettings.h:

(_WebKitSettingsClass):

UIProcess/API/gtk/WebKitURIRequest.h:

(_WebKitURIRequestClass):

UIProcess/API/gtk/WebKitURIResponse.h:

(_WebKitURIResponseClass):

UIProcess/API/gtk/WebKitURISchemeRequest.h:

(_WebKitURISchemeRequestClass):

UIProcess/API/gtk/WebKitWebContext.h:

(_WebKitWebContextClass):

UIProcess/API/gtk/WebKitWebInspector.h:

(_WebKitWebInspectorClass):

UIProcess/API/gtk/WebKitWebResource.h:

(_WebKitWebResourceClass):

UIProcess/API/gtk/WebKitWebView.h:

(_WebKitWebViewClass):

UIProcess/API/gtk/WebKitWebViewBase.h:

(_WebKitWebViewBaseClass):

UIProcess/API/gtk/WebKitWebViewGroup.h:

(_WebKitWebViewGroupClass):

UIProcess/API/gtk/WebKitWindowProperties.h:

(_WebKitWindowPropertiesClass):

Mar 19, 2013:

11:37 PM Changeset in webkit [146306] by commit-queue@webkit.org

13 edits
2 adds in trunk/Source/WebCore

Unreviewed, rolling out r146301.
http://trac.webkit.org/changeset/146301
https://bugs.webkit.org/show_bug.cgi?id=112776

Caused hundreds of tests to hit assertions on Windows debug
bots (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::reportMemoryUsage):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::setDefersLoading):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore):
(WebCore::DocumentLoader::maybeLoadEmpty):
(WebCore::DocumentLoader::startLoadingMainResource):

loader/DocumentLoader.h:

(WebCore):
(DocumentLoader):

loader/MainResourceLoader.cpp: Added.

(WebCore):
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::~MainResourceLoader):
(WebCore::MainResourceLoader::create):
(WebCore::MainResourceLoader::clearResource):
(WebCore::MainResourceLoader::frameLoader):
(WebCore::MainResourceLoader::request):
(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
(WebCore::MainResourceLoader::defersLoading):
(WebCore::MainResourceLoader::setDataBufferingPolicy):
(WebCore::MainResourceLoader::loader):
(WebCore::MainResourceLoader::identifier):

loader/MainResourceLoader.h: Added.

(WebCore):
(MainResourceLoader):
(WebCore::MainResourceLoader::cachedMainResource):
(WebCore::MainResourceLoader::documentLoader):

loader/mac/DocumentLoaderMac.cpp:

(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

11:23 PM Changeset in webkit [146305] by mkwst@chromium.org

12 edits
4 adds in trunk

CSP 1.1: Stub out SecurityPolicyViolationEvent interface.
https://bugs.webkit.org/show_bug.cgi?id=112681

Reviewed by Adam Barth.

Source/WebCore:

A first pass at a SecurityPolicyViolationEvent interface is defined in
CSP 1.1's editor's draft[1]. This patch puts the big components into
place so that we can start getting some implementation experience with
the new event interface as it's defined, and feed that back into the
working group.

Here, we're only defining the interface, and creating a listener on the
Document. Events aren't yet being fired when Content Security Policy
violations occur. I'll tackle that in a future patch; adding files is
a big enough annoyance to do it separately.

This patch has only two web-visible impacts:

Document objects now have an 'onsecuritypolicyviolation' attribute.
A SecurityPolicyViolationEvent constructor is accessible on the Window object.

Ports that have not enabled the CSP_NEXT flag should experience no change.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicyviolationevent-events

Test: http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

Wow! A new file! This is so exciting! I'm going to tell ALL my build
systems about this!

dom/Document.h:
dom/Document.idl:

Define an 'onsecuritypolicyviolation' event handler on Document objects.

dom/EventNames.h:
dom/EventNames.in:

Define a 'securitypolicyviolation' event type.

dom/SecurityPolicyViolationEvent.h: Added.

(WebCore::SecurityPolicyViolationEventInit::SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEventInit):
(SecurityPolicyViolationEvent):
(WebCore::SecurityPolicyViolationEvent::create):
(WebCore::SecurityPolicyViolationEvent::documentURI):
(WebCore::SecurityPolicyViolationEvent::referrer):
(WebCore::SecurityPolicyViolationEvent::blockedURI):
(WebCore::SecurityPolicyViolationEvent::violatedDirective):
(WebCore::SecurityPolicyViolationEvent::effectiveDirective):
(WebCore::SecurityPolicyViolationEvent::originalPolicy):
(WebCore::SecurityPolicyViolationEvent::sourceURL):
(WebCore::SecurityPolicyViolationEvent::lineNumber):
(WebCore::SecurityPolicyViolationEvent::interfaceName):
(WebCore::SecurityPolicyViolationEvent::SecurityPolicyViolationEvent):

dom/SecurityPolicyViolationEvent.idl: Added.

Define the SecurityPolicyViolationEvent's IDL, and then create all the
boilerplate necessary to properly initialize a SecurityPolicyViolationEvent
object with the relevant properties.

page/DOMWindow.idl:

Add the new SecurityPolicyViolationEvent constructor to the Window object
so it's available on a page.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html: Added.

Simple test which checks only that events are created correctly,
and that the event handler exists on Document. We'll test the
real functionality once we wire the event up to the handler.

10:59 PM Changeset in webkit [146304] by jochen@chromium.org

11 edits
5 moves
1 add
1 delete in trunk/Tools

[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebKit):
(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.

(WebTestRunner):
(WebTestThemeControlWin):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.

(WebTestRunner):
(WebTestThemeEngineMac):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.

(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(WebKit):

DumpRenderTree/chromium/TestShellMac.mm:

(platformInit):

DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

10:13 PM Changeset in webkit [146303] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Timeline] Tune status bar UI for limited-width window.
https://bugs.webkit.org/show_bug.cgi?id=112702

Reviewed by Pavel Feldman.

Reduce filter titles when there is not enough space.

inspector/front-end/TimelinePanel.js: Add classnames to elements.
inspector/front-end/timelinePanel.css: Specify "flex" behaviour.

9:31 PM Changeset in webkit [146302] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Qt and GTK+ rebaselines after r146272.

css3/flexbox/flexbox-baseline-expected.txt:
platform/qt/css3/flexbox/flexbox-baseline-expected.txt:

9:21 PM Changeset in webkit [146301] by Nate Chapin

13 edits
2 deletes in trunk/Source/WebCore

Merge MainResourceLoader into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=104969

Reviewed by Adam Barth.

No new tests, refactor only.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::~DocumentLoader): Move main resource clearing from

~MainResourceLoader.

for normal and empty loads, just use a single boolean.

loader/DocumentLoader.h:

(WebCore::DocumentLoader::isLoadingMainResource):

loader/MainResourceLoader.cpp: Removed.
loader/MainResourceLoader.h: Removed.
loader/mac/DocumentLoaderMac.cpp:

(WebCore::DocumentLoader::schedule):
(WebCore::DocumentLoader::unschedule):

9:16 PM Changeset in webkit [146300] by tony@chromium.org

9 edits in trunk

Move testRunner.setTouchDragDropEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112739

Reviewed by Adam Barth.

Tools:

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner): Remove unnecessary code.

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo): Always set to false.

LayoutTests:

Update tests to use internals.settings. This testRunner method was only exposed on
Chromium, but now that Settings.in generates internals.settings setters, we can
use that instead.

fast/events/touch/gesture/long-press-on-draggable-element-in-iframe-triggers-drag.html:
fast/events/touch/gesture/long-press-on-draggable-element-in-nested-iframes-triggers-drag.html:
fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag.html:
touchadjustment/touch-links-longpress.html:

9:08 PM Changeset in webkit [146299] by pilgrim@chromium.org

14 edits in trunk

[Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112754

Reviewed by Darin Fisher.

Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
now that it's always defined.

Source/WebKit/chromium:

public/WebCommonWorkerClient.h:

(WebCommonWorkerClient):

public/WebFrame.h:

(WebFrame):

public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):

src/LocalFileSystemChromium.cpp:

(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):

src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebFrameImpl):

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::openFileSystem):

src/WebWorkerClientImpl.h:
src/WorkerFileSystemCallbacksBridge.cpp:
src/WorkerFileSystemCallbacksBridge.h:

(WorkerFileSystemCallbacksBridge):

Tools:

DumpRenderTree/chromium/WebViewHost.cpp:
DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

9:00 PM Changeset in webkit [146298] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Fix expected results added in r146224.

fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt:
fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt:

8:32 PM Changeset in webkit [146297] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Mac rebaseline after r146272.

platform/mac/css3/flexbox/flexbox-baseline-expected.txt:

7:51 PM Changeset in webkit [146296] by ojan@chromium.org

11 edits in trunk/LayoutTests

Rebaselines after r146272.

platform/chromium-mac-lion/css3/flexbox/flexbox-baseline-expected.png:
platform/chromium-mac-snowleopard/css3/flexbox/flexbox-baseline-expected.png:
platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.png:
platform/chromium-mac/css3/flexbox/flexbox-baseline-expected.txt:
platform/chromium-win/css3/flexbox/flexbox-baseline-expected.png:
platform/chromium/TestExpectations:
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

7:38 PM Changeset in webkit [146295] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Cache a pointer to V8DOMActivityLogger in PerContextData.
https://bugs.webkit.org/show_bug.cgi?id=112719

Patch by Ankur Taly <ataly@google.com> on 2013-03-19
Reviewed by Kentaro Hara.

Adds a data member (and getter, setter methods) to V8PerContextData
that holds a pointer to a V8DOMActivityLogger. This member is set while
initializing the context for a V8DOMWindowShell. Ownership of the pointer
is still retained by the HashMap in DOMWrapperWorld.
As a result of this patch, subsequent patches that will implement logging
for DOM API access (See bug 107207) will be able to obtain a reference to
the logger directly from PerContextData. This will benefit performance as it
will be faster than looking up the logger in the DOMActivityLoggerMap in
DOMWrapperWorld.

There are no new tests as there is no change in behavior.

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):

bindings/v8/V8PerContextData.h:

(WebCore::V8PerContextData::activityLogger):
(V8PerContextData):
(WebCore::V8PerContextData::setActivityLogger):

7:14 PM Changeset in webkit [146294] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Windows rebaseline after r146284.

platform/win/fast/dom/icon-url-property-expected.txt:

7:12 PM Changeset in webkit [146293] by kbr@google.com

11 edits
5 moves
1 add
1 delete in trunk/Tools

Unreviewed, rolling out r146290.
http://trac.webkit.org/changeset/146290
https://bugs.webkit.org/show_bug.cgi?id=112751

Broke Chromium Mac build.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(WebKit):

DumpRenderTree/chromium/TestShellMac.mm:

(platformInit):

DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.

DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.

(WebThemeControlDRTWin):

DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.

(WebThemeEngineDRTMac):

DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.

(+[FakeActiveWindow alwaysActiveWindow]):
(+[FakeActiveWindow alwaysInactiveWindow]):
(-[FakeActiveWindow initWithActiveControls:]):
(-[FakeActiveWindow _hasActiveControls]):
(WebThemeEngineDRTMac::paintScrollbarThumb):
(stateToHIEnableState):
(WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
(WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.

DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.

(WebThemeEngineDRTWin):
(WebThemeEngineDRTWin::WebThemeEngineDRTWin):

7:11 PM Changeset in webkit [146292] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

do not use string reference for enum support in CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112760

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.

Do use string references in generated JS bindings for enum values.

Test: bindings/scripts/test/TestObj.idl

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

7:08 PM Changeset in webkit [146291] by commit-queue@webkit.org

8 edits
1 add in trunk

[EFL] canvas-fallback-content.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111998

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-19
Reviewed by Chris Fleizach.

Tools:

Adds support for getting platform name.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticValues):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::platformName):

LayoutTests:

Fixed failing test. The reason of failure is different accessibility role for combobox element.

accessibility/canvas-fallback-content.html: Use platform specific role.
platform/efl-wk1/TestExpectations: Unskipped.
platform/efl-wk2/TestExpectations: Unskipped.
platform/efl/accessibility/canvas-fallback-content-expected.txt: Added.

6:58 PM Changeset in webkit [146290] by jochen@chromium.org

11 edits
5 moves
1 add
1 delete in trunk/Tools

[chromium] move WebThemeEngine implementations to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=112751

Reviewed by Adam Barth.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
DumpRenderTree/DumpRenderTree.gypi:
DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebKit):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebKit):
(TestInterfaces):

DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::themeEngine):
(WebTestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.

(WebTestRunner):
(WebTestThemeControlWin):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.

(WebTestRunner):
(WebTestThemeEngineMac):

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.

DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.

(WebTestRunner):
(WebTestThemeEngineWin):
(WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):

DumpRenderTree/chromium/TestShell.h:

(WebKit):

DumpRenderTree/chromium/TestShellMac.mm:

(platformInit):

DumpRenderTree/chromium/TestShellWin.cpp:

(platformInit):

DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.

6:56 PM Changeset in webkit [146289] by kbr@google.com

4 edits in trunk/LayoutTests

Unreviewed rebaselining after r146279.

platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png:
platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png:

6:47 PM Changeset in webkit [146288] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[chromium] Mark fast/canvas/canvas-toDataURL-webp.html as failing
https://bugs.webkit.org/show_bug.cgi?id=93310

Unreviewed test expectations update.

libwebp will be updated to 0.3.0 in chrome changing the encoder
output after which this test will need to be rebaselined.

Patch by James Zern <jzern@chromium.org> on 2013-03-19

platform/chromium/TestExpectations:

6:43 PM Changeset in webkit [146287] by benjamin@webkit.org

1 edit
38 deletes in trunk/LayoutTests

Remove the test results and expectations for win-wk2
https://bugs.webkit.org/show_bug.cgi?id=112510

Reviewed by Tim Horton.

platform/win-wk2/TestExpectations: Removed.
platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Removed.
platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Removed.
platform/win-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Removed.
platform/win-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Removed.
platform/win-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Removed.
platform/win-wk2/editing/selection/after-line-break-expected.txt: Removed.
platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Removed.
platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Removed.
platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Removed.
platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Removed.
platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Removed.
platform/win-wk2/fast/css/pseudo-any-expected.txt: Removed.
platform/win-wk2/fast/forms/textfield-overflow-expected.txt: Removed.
platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Removed.
platform/win-wk2/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Removed.
platform/win-wk2/platform/win/inverted-colors/non-composited-expected.png: Removed.
platform/win-wk2/platform/win/inverted-colors/non-composited-expected.txt: Removed.
platform/win-wk2/platform/win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
platform/win-wk2/plugins/npruntime/embed-property-equality-expected.txt: Removed.
platform/win-wk2/plugins/resize-from-plugin-expected.txt: Removed.
platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
platform/win-wk2/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
platform/win-wk2/svg/text/bidi-text-query-expected.png: Removed.
platform/win-wk2/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt: Removed.

6:23 PM Changeset in webkit [146286] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Add failing test expectations on Windows per bugs 112764 and 112766.

platform/win/TestExpectations:

6:10 PM Changeset in webkit [146285] by Simon Fraser

2 edits in trunk/Source/WebCore

Make RLC::haveNonMainLayersWithTiledBacking() public and fix the name
https://bugs.webkit.org/show_bug.cgi?id=112763

Reviewed by Tim Horton.

Downstream code needs to call hasNonMainLayersWithTiledBacking().

rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::hasNonMainLayersWithTiledBacking):
(RenderLayerCompositor):

6:09 PM Changeset in webkit [146284] by levin@chromium.org

5 edits in trunk

FrameLoader::didChangeIcons isn't called when the favicon is changed.
https://bugs.webkit.org/show_bug.cgi?id=112080

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/dom/icon-url-property.html

dom/Document.cpp:

(WebCore::Document::addIconURL): Made the callback for didChangeIcons
happen whenever there are favicon changes instead of filtering it
and have to be in sync about what hosts care about. As far as I could
tell no hosts rely on this callback except for Chromium, so in general
doing less work here may potentially help a small amount for other
ports.

LayoutTests:

fast/dom/icon-url-property-expected.txt:
fast/dom/icon-url-property.html: Add some more calls

to trigger didChangeIcons callbacks.

5:57 PM Changeset in webkit [146283] by commit-queue@webkit.org

5 edits
2 deletes in trunk

Don't throw on infinity or NaN index in HTMLOptionsCollection.add()
https://bugs.webkit.org/show_bug.cgi?id=112612

Patch by Michael Pruett <michael@68k.org> on 2013-03-19
Reviewed by Kentaro Hara.

Source/WebCore:

HTMLOptionsCollection.add() should not throw a type error when
its optional index argument is infinity or NaN. Such values
should instead be converted to 0 with no error.

Tests: fast/dom/non-numeric-values-numeric-parameters.html

fast/js/select-options-add.html

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):

LayoutTests:

fast/dom/non-numeric-values-numeric-parameters-expected.txt:
fast/js/select-options-add-expected.txt:
platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Removed.
platform/chromium/fast/js/select-options-add-expected.txt: Removed.

5:27 PM Changeset in webkit [146282] by dmazzoni@google.com

3 edits
2 adds in trunk

Security: Heap-use-after-free in WebCore::AXObjectCache::getOrCreate
https://bugs.webkit.org/show_bug.cgi?id=112044

Reviewed by Chris Fleizach.

Source/WebCore:

Always call recalcSectionsIfNeeded before accessing
table sections.

Test: accessibility/table-remove-cell-crash.html

accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):

LayoutTests:

Adds test showing a crash / assertion failure if a cell is
deleted from a table and the table's AX object is accessed.

accessibility/table-remove-cell-crash-expected.txt: Added.
accessibility/table-remove-cell-crash.html: Added.

5:21 PM Changeset in webkit [146281] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[v8] add IDL 'enum' in DOM methods
https://bugs.webkit.org/show_bug.cgi?id=112644

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-19
Reviewed by Kentaro Hara.

This adds V8 support for enumerations in method parameters.

Test: bindings/scripts/test/TestObj.idl

bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::methodWithEnumArgMethod):

5:19 PM Changeset in webkit [146280] by kbr@google.com

23 edits
9 deletes in trunk/Source

Unreviewed, rolling out r146277.
http://trac.webkit.org/changeset/146277
https://bugs.webkit.org/show_bug.cgi?id=111695

Broke Chromium Android build

Source/Platform:

Platform.gypi:
chromium/public/Platform.h:

(WebKit):

chromium/public/WebSpeechSynthesisUtterance.h: Removed.
chromium/public/WebSpeechSynthesisVoice.h: Removed.
chromium/public/WebSpeechSynthesizer.h: Removed.
chromium/public/WebSpeechSynthesizerClient.h: Removed.

Source/WebCore:

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

Modules/speech/SpeechSynthesisVoice.h:
WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:
platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore::PlatformSpeechSynthesisVoice::create):

platform/PlatformSpeechSynthesisVoice.h:

(PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizer::~PlatformSpeechSynthesizer):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Removed.
platform/chromium/support/WebSpeechSynthesisVoice.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Removed.
platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Removed.
platform/mac/PlatformSpeechSynthesizerMac.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:WebCore::]):
(-[WebSpeechSynthesisWrapper speechSynthesizer:didFinishSpeaking:]):
(WebCore::PlatformSpeechSynthesizer::speak):

platform/mock/PlatformSpeechSynthesizerMock.cpp:

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

Source/WebKit/chromium:

features.gypi:

5:17 PM Changeset in webkit [146279] by Antti Koivisto

11 edits
2 adds in trunk

Don't compute background obscuration on every repaint
https://bugs.webkit.org/show_bug.cgi?id=112457

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/backgrounds/obscured-background-child-style-change.html

It is generally enough to compute background obscuration status once per layout rather than doing it on every repaint.
Since there are fewer layouts than repaints this will allow more expensive checks in the future.

With this patch adds caching and invalidation of the obscuration status.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout):

Invalidate the obscuration status on layout.

rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

Invalidate the parent obscuration status if there is repaint-only style change (often background related).
Tested by the new fast/css/obscured-background-child-style-change.html.

(WebCore::RenderBox::layout):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):

rendering/RenderBox.h:
rendering/RenderImage.cpp:

(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):

Use CachedImage::currentFrameKnownToBeOpaque which ensures that the frame is decoded and we get the real status.
Tested by an additional case in fast/css/obscured-background-child-style-change.html.

rendering/RenderImage.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange):

rendering/RenderObject.h:

(WebCore::RenderObject::hasBoxDecorations):
(WebCore::RenderObject::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::boxDecorationState):
(WebCore::RenderObject::RenderObjectBitfields::setBoxDecorationState):

Combine box decoration bit and the obscuration status so we only need one extra bit.

(WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
(WebCore::RenderObject::setHasBoxDecorations):
(WebCore::RenderObject::invalidateBackgroundObscurationStatus):
(WebCore::RenderObject::backgroundIsKnownToBeObscured):

rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::layout):

LayoutTests:

fast/backgrounds/obscured-background-child-style-change-expected.html: Added.
fast/backgrounds/obscured-background-child-style-change.html: Added.
fast/repaint/obscured-background-no-repaint.html:

4:46 PM Changeset in webkit [146278] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay is sometimes in wrong position.
https://bugs.webkit.org/show_bug.cgi?id=112748

Patch by Andrew Lo <anlo@rim.com> on 2013-03-19
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Internal PR 305384.
Translate by parent's offset when drawing selection overlay.

WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

4:26 PM Changeset in webkit [146277] by dmazzoni@google.com

22 edits
9 adds in trunk/Source

Implement Web Speech Synthesis for Chromium
https://bugs.webkit.org/show_bug.cgi?id=111695

Reviewed by Adam Barth.

Source/Platform:

Exposes a platform API that the embedder can implement to
provide speech synthesis for the Chromium port.

Platform.gypi:
chromium/public/Platform.h:

(WebKit):
(Platform):
(WebKit::Platform::speechSynthesizer):

chromium/public/WebSpeechSynthesisUtterance.h: Added.

chromium/public/WebSpeechSynthesisVoice.h: Added.

chromium/public/WebSpeechSynthesizer.h: Added.

(WebKit):
(WebSpeechSynthesizer):
(WebKit::WebSpeechSynthesizer::~WebSpeechSynthesizer):

chromium/public/WebSpeechSynthesizerClient.h: Added.

(WebKit):
(WebSpeechSynthesizerClient):
(WebKit::WebSpeechSynthesizerClient::~WebSpeechSynthesizerClient):

Source/WebCore:

Straightforward implementation of speech synthesis
for Chromium by exposing interfaces for the platform
to implement.

Modules/speech/SpeechSynthesis.cpp:

Modules/speech/SpeechSynthesis.h:

(SpeechSynthesis):

Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
(WebCore):
(WebCore::SpeechSynthesisUtterance::~SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::setVoice):

Modules/speech/SpeechSynthesisUtterance.h:

Modules/speech/SpeechSynthesisVoice.h:

(WebCore::SpeechSynthesisVoice::~SpeechSynthesisVoice):

WebCore.exp.in:
WebCore.gypi:
platform/PlatformSpeechSynthesis.h:

(PlatformSpeechSynthesis):

platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::create):

platform/PlatformSpeechSynthesisUtterance.h:

(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::setClient):

platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):

platform/PlatformSpeechSynthesisVoice.h:

platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create):
(WebCore::PlatformSpeechSynthesizer::setVoiceList):
(WebCore):

platform/PlatformSpeechSynthesizer.h:

(WebKit):
(PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):

platform/chromium/PlatformSpeechSynthesizerChromium.cpp: Added.

platform/chromium/support/WebSpeechSynthesisUtterance.cpp: Added.

platform/chromium/support/WebSpeechSynthesisVoice.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.cpp: Added.

platform/chromium/support/WebSpeechSynthesizerClientImpl.h: Added.

(WebCore):
(WebSpeechSynthesizerClientImpl):

platform/mac/PlatformSpeechSynthesizerMac.mm:

platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::PlatformSpeechSynthesizerMock):
(WebCore::PlatformSpeechSynthesizerMock::speakingFinished):
(WebCore::PlatformSpeechSynthesizerMock::speak):

platform/mock/PlatformSpeechSynthesizerMock.h:

(PlatformSpeechSynthesizerMock):

4:17 PM Changeset in webkit [146276] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Another build fix after r146220.

English.lproj/localizedStrings.js:

4:16 PM Changeset in webkit [146275] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

REGRESSION(r146164): It made all inspector tests timeout on ARM traditional
https://bugs.webkit.org/show_bug.cgi?id=112697

Unreviewed gardening, skip _all_ inspector test to be able catch new regressions.

platform/qt-arm/TestExpectations:

4:12 PM Changeset in webkit [146274] by jchaffraix@webkit.org

11 edits
2 adds in trunk

[CSS Grid Layout] Add parsing for grid-auto-{row|column}
https://bugs.webkit.org/show_bug.cgi?id=112724

Reviewed by Tony Chang.

Source/WebCore:

This change is a first step towards handling grid-auto-{row|column}.
For now, only the parsing, storing and getComputedStyle bits are implemented.
In order to do so without duplicating code, the functions handling <track-size>
(named <track-minmax> in the code based on a previous version of the grammar)
have been tweaked to be called in a standalone fashion. The code was also
updated to match the grammar more closely:

<track-minmax> is now <track-size>.
<track-group> was renmoved, folded into <track-list>.

Test: fast/css-grid-layout/grid-auto-columns-rows-get-set.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackSize):
Renamed from valueForGridTrackMinMax.

(WebCore::valueForGridTrackList):
Folded valueForGridTrackGroup here.

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Added the parsing for grid-auto-{rows|columns}.

(WebCore::CSSParser::parseGridTrackSize):
Renamed from parseGridTrackMinMax. Changed to return the parsed value (or 0 in case of
error). This enables us to reuse it in parseValue. Note that this function now moves
the parser value list instead of the caller.

(WebCore::CSSParser::parseGridTrackList):
Updated after parseGridTrackSize changes and parseGridTrackGroup removal.

css/CSSParser.h: Updated the names.
css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

css/CSSPropertyNames.in:

Added the 2 new non-inherited properties.

css/StyleResolver.cpp:

(WebCore::createGridTrackSize):
Renamed from createGridTrackMinMax. Also simplified to ensure code reuse (applyProperty hands
down a CSSValue) and consistency (the state wasn't consistently the last argument).

(WebCore::createGridTrackList):
Folded createGridTrackGroup into this function.

(WebCore::StyleResolver::applyProperty):
Added the code for the new properties.

rendering/style/RenderStyle.h:
rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Added the storage and boiler-plate code for the new properties.

LayoutTests:

fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt: Added.
fast/css-grid-layout/grid-auto-columns-rows-get-set.html: Added.

4:07 PM Changeset in webkit [146273] by ggaren@apple.com

3 edits in trunk/Source/WebCore

Removed a using declaration to avoid name conflicts
https://bugs.webkit.org/show_bug.cgi?id=112752

Reviewed by Ryosuke Niwa.

html/ClassList.cpp: Put the using declaration here instead.

html/ClassList.h: Don't put a using declaration in this header because

it can cause name conflicts with SVGNames.

3:37 PM Changeset in webkit [146272] by ojan@chromium.org

13 edits
4 adds in trunk

Make intrinsic size keywords on flexboxes work
https://bugs.webkit.org/show_bug.cgi?id=112652

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html

fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html

platform/Length.h:

(WebCore::Length::isSpecifiedOrIntrinsic):

rendering/RenderBox.cpp:

(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Pass in the Length so that RenderFlexibleBox can call this method and avoid
doing a bunch of code duplication.

rendering/RenderBox.h:
rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
Instead of just calling valueForLength, call computeLogicalWidthInRegionUsing so that
we properly resolve intrinsic Length types. Incidentally, this should also make viewport
percentage units work.

(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
Resolve intrinsic min/max Lengths. Also, instead of calling minPreferredLogicalWidth for the
min-width: auto case, call computeMainAxisExtentForChild to correctly compute the min intrinsic size.

LayoutTests:

fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items-expected.txt: Added.
fast/css-intrinsic-dimensions/intrinsic-sized-column-flex-items.html: Added.
fast/css-intrinsic-dimensions/intrinsic-sized-flex-items-expected.txt: Added.
fast/css-intrinsic-dimensions/intrinsic-sized-flex-items.html: Added.
platform/chromium-linux/css3/flexbox/flexbox-baseline-expected.png:
platform/chromium-win/css3/flexbox/flexbox-baseline-expected.txt:

This looks like a rounding difference. The new result matches the non-column result
in this same test, so it looks more correct to me.

3:30 PM Changeset in webkit [146271] by ggaren@apple.com

2 edits in trunk/Source/WebCore

Try to fix the Windows build.

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType): Qualify the
namespace to avoid conflicts.

3:27 PM Changeset in webkit [146270] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Windows build fix after r146264.

svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

3:27 PM Changeset in webkit [146269] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Hook up scroll position to proximity detector
https://bugs.webkit.org/show_bug.cgi?id=112743

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.

PR 243385
Reviewed Internally By Genevieve Mak.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPage::adjustDocumentScrollPosition):
(WebKit):

Api/WebPage.h:
Api/WebPage_p.h:

(WebPagePrivate):

3:22 PM Changeset in webkit [146268] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Crash when loading http://www.jqchart.com/jquery/gauges/RadialGauge/LiveData
https://bugs.webkit.org/show_bug.cgi?id=112694

Reviewed by Filip Pizlo.

We were trying to convert an NewArray to a Phantom, but convertToPhantom doesn't handle
nodes with variable arguments. Added code to insert a Phantom node in front of all the
live children of a var args node. Added ASSERT not var args for convertToPhantom to
catch any other similar cases. Added a new convertToPhantomUnchecked() for converting
var arg nodes.

dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::setOpAndDefaultNonExitFlags): Added ASSERT(!(m_flags & NodeHasVarArgs))
(JSC::DFG::Node::setOpAndDefaultNonExitFlagsUnchecked):
(JSC::DFG::Node::convertToPhantomUnchecked):

3:16 PM Changeset in webkit [146267] by Nate Chapin

2 edits in trunk/Source/WebCore

REGRESSION(r146223): chromium asserts/crashes in DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112745

Reviewed by Kenneth Russell.

Fixes layout tests on chromium debug

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainReceivedError): Frame might be detached, get

defersLoading() from mainResourceLoader().

(WebCore::DocumentLoader::responseReceived): RefPtr got dropped, it's really needed.
(WebCore::DocumentLoader::receivedData): Frame might be detached, get

defersLoading() from mainResourceLoader().

(WebCore::DocumentLoader::cancelMainResourceLoad): The ResourceError parameter

can be null if coming from the WebKit layer, we should have a default just in case.

3:03 PM Changeset in webkit [146266] by dino@apple.com

2 edits in trunk/LayoutTests

Unreviewed. Skipping plugin snapshot tests temporarily to work out compositing issues.

platform/mac-wk2/TestExpectations:

2:55 PM Changeset in webkit [146265] by mikhail.pozdnyakov@intel.com

16 edits
1 add in trunk

[EFL][WK2] Separate WebView further from EwkView
https://bugs.webkit.org/show_bug.cgi?id=111591

Reviewed by Caio Marcelo de Oliveira Filho.

Source/WebKit2:

Main points are:

WKView API has no dependency on EFL types
WebView class does not store the Evas_Object

UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):

WKView creation does not require any EFL objects to be passed.

UIProcess/API/C/efl/WKView.h:
UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::create):

WKViewRef is passed to EwkView constructor from outside rather than
created inside.

(EwkView::webView):

UIProcess/API/efl/EwkView.h:

(EwkView):
(EwkView::wkView):
(EwkView::page):

EwkView keeps WKViewRef rather than pointer to WebView class.

UIProcess/API/efl/ewk_view_private.h: Added.

(EWKViewCreate):
(EWKViewGetWKView):

Added private API to create ewk view evas object and return its WKViewRef.

UIProcess/API/efl/ewk_view.cpp:

(ewkCreateEvasObject):
(ewk_view_smart_add):
(ewk_view_add):
(ewk_view_add_with_context):

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Updated accordingly to the new APIs.

UIProcess/efl/WebView.cpp:

(WebKit::WebView::WebView):
(WebKit::WebView::create):
(WebKit):
(WebKit::WebView::setEwkView):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):

UIProcess/efl/WebView.h:

(WebView):

Implementation of updated WKView API.

Tools:

Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
since we can afford it having EWKViewGetWKView() private API to access WKView.

TestWebKitAPI/PlatformWebView.h:
TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):

WebKitTestRunner/PlatformWebView.h:
WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::dispatchEvent):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):

WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowSnapshotImage):

2:51 PM Changeset in webkit [146264] by ggaren@apple.com

44 edits in trunk

Refactored script content removal in the fragment parser for clarity and speed
https://bugs.webkit.org/show_bug.cgi?id=112734

Reviewed by Enrica Casucci.

Source/WebCore:

WebCore.exp.in: Export!

dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::parseHTML):
(WebCore::DocumentFragment::parseXML):

dom/DocumentFragment.h:

(DocumentFragment): Updated for rename of FragmentScriptingPermission to
ParserContentPolicy.

dom/Element.cpp:

(WebCore::isEventHandlerAttribute):
(WebCore::Element::isJavaScriptURLAttribute):
(WebCore::Element::isJavaScriptAttribute): Fixed a FIXME by factoring
out some helper functions that reuse isURLAttribute(). This makes our
attribute removal slightly more precise, as reflected in test changes.

(WebCore::Element::stripJavaScriptAttributes): Factored this function out
of parserSetAttributes to clarify that the parser is responsible for
fully removing scripts before inserting anything into the DOM.

Now that this is a helper function, we can avoid doing any work in the
common case, where script content is allowed. Also, when we do have to
strip attributes, we use "two finger compaction" to avoid copying the
vector, and to avoid O(N) vector removal operations when there is
something to remove.

(WebCore::Element::parserSetAttributes):

dom/Element.h:

dom/FragmentScriptingPermission.h:

(WebCore::scriptingContentIsAllowed):
(WebCore::disallowScriptingContent):
(WebCore::pluginContentIsAllowed):
(WebCore::allowPluginContent): Renamed for clarity, and added some helper
functions for reading values out of this enum.

dom/ScriptableDocumentParser.cpp:

(WebCore::ScriptableDocumentParser::ScriptableDocumentParser): Moved
a settings check into the parser constructor so we're sure that all
clients get the right behavior.

dom/ScriptableDocumentParser.h:

(WebCore::ScriptableDocumentParser::parserContentPolicy):
(ScriptableDocumentParser):

editing/markup.cpp:

(WebCore::createFragmentFromMarkup):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::createFragmentForInnerOuterHTML):
(WebCore::createContextualFragment):

editing/markup.h: Updated for renames.

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isURLAttribute): Fixed a bug where
isURLAttribute would ignore href attributes in other namespaces, like
xlink:href.

html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::isURLAttribute): Same bug.

html/HTMLElement.cpp:

(WebCore::HTMLElement::isURLAttribute): Fixed a logic error where HTMLElement
wouldn't call through to its base class.

html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::isURLAttribute): Same isURLAttribute namespace
bug as above.

html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes): Helper function for optionally stripping
disallowed attributes before setting them on an element. This helps all
clients get the right behavior without sprinkling checks everywhere.

(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):

(WebCore::HTMLConstructionSite::insertScriptElement): Don't schedule the
element for insertion into the document if the element is forbidden. This
is slightly clearer than leaving an empty forbidden element in the document.

(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElement):

html/parser/HTMLConstructionSite.h:

(HTMLConstructionSite):
(WebCore::HTMLConstructionSite::parserContentPolicy):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
(WebCore::HTMLDocumentParser::parseDocumentFragment):

html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):
(WebCore::HTMLDocumentParser::create):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext):
Updated for renames and interface changes above.

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processEndTag): Removed isParsingFragment()
checks to make it possible to use ParserContentPolicy in more places.

Removed call to removeChildren() because, if an element is forbidden,
we fully remove the element now. This brings behavior for <script>
elements in line with behavior for plug-in elements. It also brings
behavior of the HTML parser in line with behavior of the XML parser.

html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::create):
(FragmentParsingContext):
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement):

platform/blackberry/PasteboardBlackBerry.cpp:

(WebCore::Pasteboard::documentFragment):

platform/chromium/DragDataChromium.cpp:

(WebCore::DragData::asFragment):

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::documentFragment):

platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::documentFragment):

platform/qt/DragDataQt.cpp:

(WebCore::DragData::asFragment):

platform/qt/PasteboardQt.cpp:

(WebCore::Pasteboard::documentFragment):

platform/win/ClipboardUtilitiesWin.cpp:

(WebCore::fragmentFromCFHTML):
(WebCore::fragmentFromHTML):

platform/wx/PasteboardWx.cpp:

(WebCore::Pasteboard::documentFragment): Updated for renames and interface
changes.

svg/SVGAElement.cpp:

(WebCore::SVGAElement::isURLAttribute): Fixed a bug where SVG anchor
elements didn't identify their URL attributes.

svg/SVGAElement.h:

(SVGAElement):

xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock): No need to disallow
scripting attributes here because we're creating the attributes
ourselves and we know they're not scripting attributes.

xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::parseDocumentFragment):

xml/parser/XMLDocumentParser.h:

(WebCore::XMLDocumentParser::create):
(XMLDocumentParser): Updated for renames and interface changes above.

Removed the 8 inline capacity in the attribute vector so we could share
helper functions with the HTML parser, which didn't have it.

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::setAttributes):
(WebCore):
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::handleNamespaceAttributes):
(WebCore::handleElementAttributes):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement): Same changes as for the
HTML parser.

LayoutTests:

Updated tests to improve coverage and reflect behavior tweaks to improve
clarity.

editing/pasteboard/paste-noscript-expected.txt:
- The "href", "source", and "action" attributes are fully removed now, instead of being set to the empty string, because for clarity we fully remove script attributes instead of setting their values to the empty string.

The "formaction" attribute on the form control is not removed because, even though it seems to contain javascript content, the formaction attribute doesn't map to anything on a form element, and won't ever run as script.

I added a button with a "formaction" attribute, to verify that it does get stripped, since this is the case where the "formaction" attribute can run as script.

editing/pasteboard/paste-noscript-svg-expected.txt:
- The "xlink:href" attribute is fully removed now. See above.

editing/pasteboard/paste-noscript-xhtml-expected.txt:
editing/pasteboard/paste-noscript.html:
- The "href", "source", and "action" attributes are fully removed now. See above.

The <script> element is fully removed now. See above.

The "formaction" attribute on the form control is not removed. See above.

I added a button with a "formaction" attribute. See above.

editing/pasteboard/paste-visible-script-expected.txt:
- The <script> elements are fully removed now. See above.

editing/pasteboard/resources/paste-noscript-content.html:
- The "formaction" attribute on the form control is not removed. See above.

I added a button with a "formaction" attribute. See above.

2:49 PM Changeset in webkit [146263] by mhahnenberg@apple.com

3 edits
3 adds in trunk

Crash in SpeculativeJIT::fillSpeculateIntInternal<false> on http://bellard.org/jslinux
https://bugs.webkit.org/show_bug.cgi?id=112738

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixIntEdge): We shouldn't be killing this node because it could be
referenced by other people.

LayoutTests:

fast/js/dfg-rshift-by-zero-eliminate-valuetoint32-expected.txt: Added.
fast/js/dfg-rshift-by-zero-eliminate-valuetoint32.html: Added.
fast/js/script-tests/dfg-rshift-by-zero-eliminate-valuetoint32.js: Added.

(f):

2:45 PM Changeset in webkit [146262] by pdr@google.com

14 edits in trunk/Source/WebCore

Clean up static_casts for SVG renderers
https://bugs.webkit.org/show_bug.cgi?id=111651

Reviewed by Abhishek Arya.

toRenderSVGPath and toRenderSVGFilter are preferred over static_casts because bad casts can
be caught on our testing infrastructure. This patch replaces all static_casts for
RenderSVGPath and RenderSVGFilter with toRenderSVGPath and toRenderSVGFilter, respectively.

This patch also adds FIXME to the remaining toRenderSVG* instances that are missing.

No new tests as this is covered with existing tests.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

This call is currently safe due to the element->hasTagName(SVGNames::clipPathTag) check.

rendering/svg/RenderSVGPath.h:

(WebCore):
(WebCore::toRenderSVGPath):

rendering/svg/RenderSVGResourceFilter.h:

(WebCore):
(WebCore::toRenderSVGFilter):

rendering/svg/RenderSVGResourceFilterPrimitive.cpp:

(WebCore::RenderSVGResourceFilterPrimitive::styleDidChange):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::addResourceForClientInvalidation):

rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::repaintRectForRendererInLocalCoordinatesExcludingSVGShadow):
(WebCore::SVGRenderSupport::rendererHasSVGShadow):
(WebCore::SVGRenderSupport::setRendererHasSVGShadow):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):

This cast was not correct! Thankfully it was not required anyway.

svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::svgAttributeChanged):

This cast was not correct!

svg/SVGEllipseElement.cpp:

(WebCore::SVGEllipseElement::svgAttributeChanged):

This cast was not correct!

svg/SVGLineElement.cpp:

(WebCore::SVGLineElement::svgAttributeChanged):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::pathSegListChanged):
(WebCore::SVGPathElement::getBBox):

svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::svgAttributeChanged):

svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::svgAttributeChanged):

2:40 PM Changeset in webkit [146261] by roger_fong@apple.com

2 edits in trunk/Tools

Changes to VS2010 project files should only trigger builds on Windows bots.
https://bugs.webkit.org/show_bug.cgi?id=112731

Reviewed by Timothy Horton.

BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

2:30 PM Changeset in webkit [146260] by Beth Dakin

2 edits in trunk/Source/WebCore

RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673

Reviewed by Simon Fraser.

FrameLoaderClient::didChangeScrollOffset() should be called whenever something is
actually being scrolled.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

2:17 PM Changeset in webkit [146259] by commit-queue@webkit.org

41 edits in trunk/Source/WebCore

[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-19
Reviewed by Jochen Eisinger.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

Added an IDL attribute (V8PerWorldBindings) to define which
attribute getters / setters to specialize.

This patch generates main world bindings for getters and setters of Node
and Element. (The possibility to generate bindings for callbacks will be
added later.)

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructorConstructor::GetTemplate):
(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore::V8TestObj::installPerContextProperties):

bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::configureTemplate):

bindings/v8/V8DOMConfiguration.h:

(BatchedAttribute):
(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8EventTargetCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

dom/Element.idl:
dom/Node.idl:

2:12 PM Changeset in webkit [146258] by cevans@google.com

2 edits in branches/chromium/1410/Source/WebCore/Modules/webaudio

Merge 143565
BUG=174137
Review URL: https://codereview.chromium.org/12478015

2:12 PM Changeset in webkit [146257] by mkwst@chromium.org

3 edits in trunk/Source/WebCore

FeatureObserver: Measure X-Frame-Options usage.
https://bugs.webkit.org/show_bug.cgi?id=112670

Reviewed by Adam Barth.

This patch adds three FeatureObserver entries to gather information
about 'X-Frame-Options' usage in general, and in particular usage
and potential misunderstanding of the 'SAMEORIGIN' value.

Three entries are added:

XFrameOptions measures the raw number of 'X-Frame-Options' headers.

XFrameOptionsSameOrigin measures the number of those headers that set the value to 'SAMEORIGIN'.

XFrameOptionsSameOriginWithBadAncestorChain measures the number of occasions in which the frame passed the "top-only" origin check we're currently performing, but would have failed a more strict check against poisoned ancestor chains (that is, an ancestor chain that looks like 'example.com' -> 'evil.com' -> 'example.com').

Mozilla is considering changing 'SAMEORIGIN's behavior to block the
latter loophole[1], and the UI Safety spec is considering dropping
'top-only' entirely[2]. This data will inform those decisions.

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=725490
[2]: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0007.html

This doesn't change web-visible behavior; it only adds histograms

loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

When processing an 'X-Frame-Options' header's value, call out to
FeatureObserver when relevant to increment the correct histogram
entries.

page/FeatureObserver.h:

Added three entries to the FeatureObserver enum: XFrameOptions,
XFrameOptionsSameOrigin, and XFrameOptionsSameOriginWithBadAncestorChain.
Each is explained above.

2:00 PM Changeset in webkit [146256] by roger_fong@apple.com

3 edits in trunk/Tools

Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.

Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

1:59 PM Changeset in webkit [146255] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

2013-03-19 Oliver Hunt <oliver@apple.com>

RELEASE_ASSERT fires in exception handler lookup

RS=Geoff Garen.

Temporarily switch this RELEASE_ASSERT into a regular ASSERT
as currently this is producing fairly bad crashiness.

bytecode/CodeBlock.cpp: (JSC::CodeBlock::handlerForBytecodeOffset):

1:51 PM Changeset in webkit [146254] by jparent@chromium.org

14 edits
2 adds in trunk/Tools

Dashboards: Introduce history namespace and unit tests.
https://bugs.webkit.org/show_bug.cgi?id=112645

Reviewed by Ojan Vafai.

Laying the framework for introducing the new history object and
namespace. This moves only static functions into the history
namespace, and moves corresponding unit tests into seperate
unit test file.

TestResultServer/static-dashboards/aggregate_results.html:
TestResultServer/static-dashboards/dashboard_base.js:

(parseCrossDashboardParameters):
(parseDashboardSpecificParameters):
(parseParameters):

TestResultServer/static-dashboards/flakiness_dashboard.html:
TestResultServer/static-dashboards/flakiness_dashboard.js:

(.switch.return):

TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
TestResultServer/static-dashboards/history.js: Added.
TestResultServer/static-dashboards/history_unittests.js: Added.
TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/run-embedded-unittests.html:
TestResultServer/static-dashboards/run-unittests.html:
TestResultServer/static-dashboards/timeline_explorer.html:
TestResultServer/static-dashboards/timeline_explorer.js:
TestResultServer/static-dashboards/treemap.html:
TestResultServer/static-dashboards/treemap.js:

(.switch.return):

TestResultServer/static-dashboards/ui.js:

1:45 PM Changeset in webkit [146253] by abarth@webkit.org

2 edits
1 add in trunk/Source/WebCore

GenerateHashValue should be usable outside CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112736

Reviewed by Benjamin Poulain.

GenerateHashValue is not specific to CodeGeneratorJS.pm. Instead, the
function matches the StringHash used in WTF. This patch moves the
function into a separate Perl module so that it can be used by other
Perl scripts. For example, I plan to use this function to compute the
hash value for HTMLNames at compile time rather than at startup.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHashTable):

bindings/scripts/Hash.pm: Added.

(leftShift):
(GenerateHashValue):

1:35 PM Changeset in webkit [146252] by bfulgham@webkit.org

2 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build fix.

win/tools/vsprops/FeatureDefinesCairo.vsprops: This file was out

of sync with the main Windows build, and the VS2010 version of the
WinCairo port, preventing consistent builds.

1:34 PM Changeset in webkit [146251] by pilgrim@chromium.org

2 edits in trunk/Source/Platform

[Chromium] Flip WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
https://bugs.webkit.org/show_bug.cgi?id=112726

Reviewed by Adam Barth.

Now that all embedders respect this ifdef, we can safely define it
to get everything to use the new top-level WebFileSystemType enum.

chromium/public/WebFileSystemType.h:

1:30 PM Changeset in webkit [146250] by dino@apple.com

12 edits
6 adds in trunk

Source/WebCore: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696

Reviewed by Tim Horton.

Expose a new setting maximumPlugInSnapshotAttempts that can
be set by testing scripts.

Tests: plugins/snapshotting/restart.html

plugins/snapshotting/simple.html

page/Settings.in:

Source/WebKit2: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696

Reviewed by Tim Horton.

Use the new maximumPlugInSnapshotAttempts setting rather than a hardcoded
value. At the same time, if this value is 0, then snapshot immediately
(don't wait to get a snapshot and test it).

WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::didInitializePlugin): Snapshot immediately if maximum attempts are 0.
(WebKit::PluginView::pluginSnapshotTimerFired): Use setting rather than file local variable.

LayoutTests: Allow PlugIn Snapshotting to be tested
https://bugs.webkit.org/show_bug.cgi?id=98696
<rdar://problem/12456731>

Reviewed by Tim Horton.

Two new simple tests for plugin snapshotting. One that makes
sure the plugin was snapshotted (looks for the RenderSnapshottedPlugin)
and one that restarts a snapshotted plugin by clicking.

Since this feature is currently only enabled in WebKit2, the tests
are skipped everywhere else.

platform/chromium/TestExpectations: Skip plugins/snapshotting.
platform/efl/TestExpectations: Ditto.
platform/gtk/TestExpectations: Ditto.
platform/mac-wk2/TestExpectations: Ditto.
platform/mac-wk2/plugins/snapshotting/restart-expected.txt: Added.
platform/mac-wk2/plugins/snapshotting/simple-expected.txt: Added.
platform/mac/TestExpectations: Skip plugins/snapshotting.
platform/qt/TestExpectations: Ditto.
platform/win/TestExpectations: Ditto.
plugins/snapshotting/restart.html: Added.
plugins/snapshotting/simple.html: Added.

1:27 PM Changeset in webkit [146249] by dbates@webkit.org

3 edits in trunk/Tools

svn-apply has trouble applying a patch that adds a Windows newline to EOF
https://bugs.webkit.org/show_bug.cgi?id=112732

Reviewed by Eric Seidel.

Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
of an existing file cannot be applied.

In particular, svn-{apply, unapply} compensate for differences in line endings
by converting the line endings in a diff to match the line endings in the target
file. The diff(1) command precedes the last line of a diff that adds a newline
character to the end of a file with the special character sequence "\n
No newline at end of file\n"
Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
when applying this modified diff. Instead, svn-{apply, unapply} should not modify
the newline characters in this special character sequence to match the line endings
in the target file.

Scripts/VCSUtils.pm:

(parseDiff):

Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:

Added tests:

"SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
"SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
"Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
"Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"

(escapeNewLineCharacters): Added.
(toMacLineEndings): Added.

1:23 PM Changeset in webkit [146248] by dino@apple.com

5 edits in trunk/Source

Restarting a snapshotted plugin should restart all plugins from the same domain on the page
https://bugs.webkit.org/show_bug.cgi?id=112725

Reviewed by Tim Horton.

Source/WebCore:

If the user restarts a snapshotted plugin, then typically they will
want to restart all similar plugins on the page, where similarity
is defined by the domain of the content. Or in other words, since clients
will typically add a restarted plugin to the list of autostarting
domain hashes, we should start the other plugins that would autostart
on reload.

When a snapshotted plugin gets the user click telling it to restart, it iterates
over every frame in the document looking for domain hashes similar to its own.
It then manually restarts each of the paused plugins.

html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingOriginHash): Static helper function

that builds a list of plugins to restart.

(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): After restarting itself,

the plugin looks for all other similar snapshotted plugins in the page.

(WebCore::HTMLPlugInImageElement::restartSnapshottedPlugIn): Splits out the actual

restart functionality, to make it separate from plugins that were manually
restarted and thus probably want to forward a delayed click event.

html/HTMLPlugInImageElement.h:

(HTMLPlugInImageElement): New method restartSnapshottedPlugIn.

Source/WebKit2:

When we add a plugin domain hash to the list of sites that autostart, we
send a message to our owning process. That message might not return before
another plugin queries if it is in the list. So, before we send the message,
add the current hash to the list with a very small timeout. That way the
response will be to either extend the timeout, or not add the hash (in which
case it will expire soon).

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addPlugInAutoStartOrigin):

1:23 PM Changeset in webkit [146247] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG should optimize StringObject.length and StringOrStringObject.length
https://bugs.webkit.org/show_bug.cgi?id=112658

Reviewed by Mark Hahnenberg.

Implemented by injecting a ToString(StringObject:@a) or ToString(StringOrStringObject:@a) prior
to GetArrayLength with ArrayMode(Array::String) if @a is predicted StringObject or
StringOrStringObject.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::createToString):
(FixupPhase):
(JSC::DFG::FixupPhase::attemptToForceStringArrayModeByToStringConversion):
(JSC::DFG::FixupPhase::convertStringAddUse):

1:22 PM Changeset in webkit [146246] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/mac

Another Mac build fix attempt after r146239.

WebCoreSupport/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

1:16 PM Changeset in webkit [146245] by mrowe@apple.com

1 copy in tags/Safari-534.59.7

New tag.

1:16 PM Changeset in webkit [146244] by mrowe@apple.com

1 copy in tags/Safari-536.29.10

New tag.

1:09 PM Changeset in webkit [146243] by mrowe@apple.com

4 edits in branches/safari-536.29-branch/Source

Versioning.

1:04 PM Changeset in webkit [146242] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/mac

Mac build fix attempt after r146239.

WebCoreSupport/WebFrameNetworkingContext.h:

12:55 PM Changeset in webkit [146241] by mrowe@apple.com

5 edits in branches/safari-534.59-branch/Source

Versioning.

12:55 PM Changeset in webkit [146240] by commit-queue@webkit.org

11 edits
4 deletes in trunk

[chromium] Remove compositor settings that don't go through WebKit
https://bugs.webkit.org/show_bug.cgi?id=112718

Patch by James Robinson <jamesr@chromium.org> on 2013-03-19
Reviewed by Adam Barth.

Source/WebKit/chromium:

This removes settings that used to propagate through WebLayerTreeView::Settings by way of WebViewImpl but are
now directly set by the embedder.

public/WebSettings.h:
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):

src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

DumpRenderTree/chromium/TestShell.h:

(TestShell):

LayoutTests:

platform/chromium/compositing/accelerated-drawing/alpha-expected.png: Removed.
platform/chromium/compositing/accelerated-drawing/alpha-expected.txt: Removed.
platform/chromium/compositing/accelerated-drawing/alpha.html: Removed.
platform/chromium/compositing/accelerated-drawing/svg-filters.html: Removed.

12:39 PM Changeset in webkit [146239] by Nate Chapin

5 edits in trunk/Source/WebCore

Merge MainResourceLoader's SubstituteData loading + others into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112722

Part of the ongoing effort to merge MainResourceLoader entirely
into DocumentLoader.

Reviewed by Antti Koivisto.

No new tests, refactor only.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainReceivedError): Moved from MainResourceLoader::receivedError

and the failure case in MainResourceLoader::notifyFinished.

(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::handleSubstituteDataLoadNow): Moved from MainResourceLoader.
(WebCore::DocumentLoader::startDataLoadTimer): Moved from MainResourceLoader.
(WebCore::DocumentLoader::handleSubstituteDataLoadSoon): Moved from MainResourceLoader.
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::startLoadingMainResource): Most of MainResourceLoader::load

moved here.

(WebCore::DocumentLoader::cancelMainResourceLoad): MainResourceLoader::cancel

moved here.

loader/DocumentLoader.h:
loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::notifyFinished):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::identifier):

loader/MainResourceLoader.h:

12:36 PM Changeset in webkit [146238] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed build fix after r146220. Add the missing ]'s.

English.lproj/localizedStrings.js:

12:29 PM Changeset in webkit [146237] by hclam@chromium.org

7 edits
1 add in trunk/Source

GIFImageReader to count frames and decode in one pass
https://bugs.webkit.org/show_bug.cgi?id=111144

Reviewed by Stephen White.

Source/WebCore:

OBJECTIVE

This change has the objective of improving performance reading GIF
files. This implementation can parse the entire GIF file in one pass
and saves information about each frame, such that decoding in a later
pass does not need to parse the file again.

This change fixes the performance problem of decoding GIF files when
they are received very slowly. Existing implementation creates a new
GIFImageReader for counting frames for every time it is notified that
new data has been received, this has O(n^{2) behavior when data is

received very slowly.}

ALGORITHM

This implementation divides the decoding process into two separate
steps: parse and LZW decoding.

In the parse step, the state machine is similar to the existing
implementation. However this algorithm does not perform any decoding
while scanning through the file. Intead it creates a new data structure
for caching all frame information and the corresponding LZW blocks.

If a full decode is requested then LZW decoding is performed. This
implementation looks through all frame information saved and decodes
each frame sequentially until the target frame is reached.

Because of the separation of parse and decode, each frame can be
decoded separately. This paves the way to support seeking in GIF files.

TESTING

Added a new unit test to cover progressively decoding a GIF image.
There are already GIF unit tests for functional testing.
Exhaustive testing was done locally with a corpus of 60k images.
I mixed the corpus with some generated bad data and truncated files.
The results was bit-identical when compared to the previous
implementation.

These was also no crashing when decoding the entire corpus.

platform/image-decoders/gif/GIFImageDecoder.cpp:

(WebCore::GIFImageDecoder::GIFImageDecoder):
(WebCore::GIFImageDecoder::setData):
(WebCore::GIFImageDecoder::frameCount):
(WebCore::GIFImageDecoder::repetitionCount):
(WebCore::GIFImageDecoder::decode):

platform/image-decoders/gif/GIFImageDecoder.h:

(GIFImageDecoder):

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFLZWContext::outputRow):
(GIFLZWContext::doLZW):
(GIFFrameContext::decode):
(GIFImageReader::decode):
(GIFImageReader::parse):
(GIFImageReader::addFrameIfNecessary):
(GIFLZWContext::prepareToDecode):

platform/image-decoders/gif/GIFImageReader.h:

There is a lot of reshuffling in GIFLZWContext and GIFFrameContext.
These changes has the goal of having GIFLZWContext be a pure decoding
state machine. GIFFrameContext is mostly a read-only container for
frame information. With all these changes we can decode each
GIFFrameContext independently.

The ownership pattern is:
GIFImageReader owns GIFFrameContext owns GIFLZWContext.

(GIFLZWContext::GIFLZWContext):
(GIFLZWContext):
(GIFLZWContext::hasRemainingRows):
GIFLZWContext is moved to the top of file.
(GIFLZWBlock):
(GIFLZWBlock::GIFLZWBlock):
New data structure to save block position and size.
(GIFFrameContext):
(GIFFrameContext::GIFFrameContext):
(GIFFrameContext::~GIFFrameContext):
(GIFFrameContext::addLzwBlock):
(GIFFrameContext::isComplete):
(GIFFrameContext::isHeaderDefined):
(GIFFrameContext::isDataSizeDefined):
(GIFFrameContext::setComplete):
(GIFFrameContext::setHeaderDefined):
(GIFFrameContext::setDataSize):
Now owns GIFLZWContext for decoding.
(GIFImageReader::GIFImageReader):
(GIFImageReader::~GIFImageReader):
(GIFImageReader::imagesCount):
(GIFImageReader::frameContext):
(GIFImageReader):
(GIFImageReader::parseFailed):
(GIFImageReader::isFirstFrame):
Owns a list of GIFFrameContxt.

Source/WebKit/chromium:

Added a new GIF unit test for progressive decoding. The test is to verify
that continually re-decoding an image one additional byte at a time produces
the same outputs as repeatedly decoding (with brand new decoders) truncated
versions of the image that are one byte longer each time.

tests/GIFImageDecoderTest.cpp:

(WebKit::TEST):

12:25 PM Changeset in webkit [146236] by roger_fong@apple.com

1 edit
2 adds in trunk/LayoutTests

Unreviewed gardening of AppleWin port.

platform/win/fast/dom/icon-url-property-expected.txt: Added.
platform/win/fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt: Added.

12:19 PM Changeset in webkit [146235] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r189038. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19

DEPS:

12:18 PM Changeset in webkit [146234] by dpranke@chromium.org

2 edits in trunk/Tools

Unreviewed, rolling out r146101.
https://bugs.webkit.org/show_bug.cgi?id=111884

re-enable custom freetype on asan; this needs to be on
now that the bot is running lucid.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

12:14 PM Changeset in webkit [146233] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Don't handle keyboard scrolling shortcuts in webkit
https://bugs.webkit.org/show_bug.cgi?id=112716

Informally Reviewed by Mike Fenton (mifenton@rim.com)
Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.

The comment is right, this isn't the correct place to handle keyboard
scrolling shortcuts. That's what we have clients for.

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::keyEvent):

12:03 PM Changeset in webkit [146232] by jsbell@chromium.org

2 edits in trunk/LayoutTests

[Chromium] IndexedDB: index-duplicate-keypaths test is flaky under content_shell
https://bugs.webkit.org/show_bug.cgi?id=112723

Reviewed by Tony Chang.

Root cause is a race between the "versionchange" transaction's "complete" event
being dispatched to script and the "success" call arriving from the back-end
which updates the metadata. Tracked as https://bugs.webkit.org/show_bug.cgi?id=111642

storage/indexeddb/resources/index-duplicate-keypaths.js:

(testCollideAutoIncrementSetup): Trigger test from open's onsuccess...
(testCollideAutoIncrement): ... rather than transaction's oncomplete.

11:59 AM Changeset in webkit [146231] by bfulgham@webkit.org

3 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction for WebCore library.

WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific frame source

from WinCairo build.

WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Pass correct

parameter to build-generated-files.sh for WinCairo build.

11:50 AM Changeset in webkit [146230] by Martin Robinson

2 edits in trunk/Source/WTF

Fix the WTF gyp build for GTK+.

WTF.gyp/WTFGTK.gyp: Skip files with CF in the name.

11:47 AM Changeset in webkit [146229] by commit-queue@webkit.org

2 edits in trunk/Source/Platform

[chromium] Remove deprecated/unused bits of WebLayerTreeView
https://bugs.webkit.org/show_bug.cgi?id=112714

Patch by James Robinson <jamesr@chromium.org> on 2013-03-19
Reviewed by Adam Barth.

chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

11:45 AM Changeset in webkit [146228] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Implement onRefEncodedData for lazy pixel refs.
This allows printToSkPicture to write the original
encoded data to the stream.
Add a method to ImageFrameGenerator to copy its
data, which is used by onRefEncodedData.
https://bugs.webkit.org/show_bug.cgi?id=110759

Patch by Leon Scroggins <scroggo@chromium.org> on 2013-03-19
Reviewed by Stephen White.

No new tests. New functionality is for testing purposes
(creating SKP files).

platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::data):
(WebCore):

platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::isClipped):
(WebCore):
(WebCore::LazyDecodingPixelRef::onRefEncodedData):

platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

11:39 AM Changeset in webkit [146227] by pdr@google.com

5 edits
2 adds in trunk

Separate SVG image size and container size
https://bugs.webkit.org/show_bug.cgi?id=112651

Reviewed by Stephen Chenney.

Source/WebCore:

Previously, SVG images could retain their cached size between reloads due to a bug where an
old container size would be re-used if the image's new container size was not available yet.

This patch changes SVGImage::size() to return the intrinsic size of the image before a
container size has been set. SVGImageCache::imageSizeForRenderer will now return the
image's intrinsic size instead of a cached value if the container size cannot be looked up.
In javascript, querying [SVGImage].width will now return either the image's intrinsic size
or the size of 'imageForContainer'.

Test: svg/as-image/svg-container-size-after-reload.html

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::dataChanged):

svg/graphics/SVGImage.h:

The member variable 'm_intrinsicSize' has been added to track the image's intrinsic
size. This term can be found in: http://www.w3.org/TR/css3-images/#default-sizing

svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageSizeForRenderer):
(WebCore::SVGImageCache::imageForRenderer):

In both of these functions, image has been renamed to imageForContainer here to clarify
that the cached container size is being returned, not the image's intrinsic size.

LayoutTests:

svg/as-image/svg-container-size-after-reload-expected.txt: Added.
svg/as-image/svg-container-size-after-reload.html: Added.

11:31 AM Changeset in webkit [146226] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] When selecting an object, assign focus to new node instead of clearing previous focused node
https://bugs.webkit.org/show_bug.cgi?id=112707

Patch by Andy Chen <andchen@blackberry.com> on 2013-03-19
Reviewed by Rob Buis.

In SelectionHandler, when selecting a new object, we should set focus
to the anchor node of selection instead of removing it from the old input.
In InputHandler, when focusedNodeChanged is called, if the new node is
not an Element node, we need to set focus to its Element parent node,
instead of removing focus from the old node.
PR 304631
Internally reviewed by Mike Fenton.

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

11:23 AM Changeset in webkit [146225] by jsbell@chromium.org

3 edits in trunk/Source/WebCore

IndexedDB: Use integer plumbing for deleteDatabase onVersionChange calls
https://bugs.webkit.org/show_bug.cgi?id=112715

Reviewed by Tony Chang.

When deleteDatabase on the back-end needs to send the front-end an
onVersionChange notification it does so using the string overload. That's
the only remaining use of that overload and we'd like to delete it. Switch
to using the integer overload, with an already defined special value.
This will unblock http://wkbug.com/112712 to delete the dead code.

No new tests - no functional change.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::onVersionChange): Map NoIntVersion to null.

Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::deleteDatabase): Call integer overload.

11:20 AM Changeset in webkit [146224] by tdanderson@chromium.org

3 edits
6 adds in trunk

Hover effects from a GestureTapDown are dismissed by a GestureTap on the hover element
https://bugs.webkit.org/show_bug.cgi?id=103283

Reviewed by Antonio Gomes.

Source/WebCore:

On a GestureTap event over an element that was made visible as a hover effect, the
GestureTap should be applied to that element and the hover effects should not be dismissed.
A GestureTap or a mouse move to a location outside of the element should still dismiss the
hover effects.

Tests: fast/events/touch/gesture/gesture-tap-hover-clear.html

fast/events/touch/gesture/gesture-tap-on-hover-element.html

page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

LayoutTests:

Two layout tests added. See descriptions inline.

fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
fast/events/touch/gesture/gesture-tap-hover-clear.html: Added.

Tests that a GestureTap or a mouse move outside of the hovered element
clears its hover effects.

fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.
fast/events/touch/gesture/gesture-tap-on-hover-element.html: Added.

Tests that a GestureTap on an element which has been made visible as
a hover effect is dispatched to the element and does not dismiss the
hover effect.

platform/chromium/fast/events/touch/gesture/gesture-tap-hover-clear-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/gesture-tap-on-hover-element-expected.txt: Added.

11:13 AM Changeset in webkit [146223] by Nate Chapin

6 edits
2 copies in branches/chromium/1410

Merge 145735 "REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning"

.: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Source/autotools/symbols.filter:
Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Test: http/tests/navigation/post-redirect-get-reload.php

loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether

we are in a redirect. Check redirectResponse.isNull() instead.

testing/Internals.cpp:
(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.

Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
which makes it unsuitable for this case.

testing/Internals.h:
testing/Internals.idl:
Source/WebKit/win: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

WebKit.vcproj/WebKitExports.def.in:
LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194.

Reviewed by Alexey Proskuryakov.

http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
http/tests/navigation/post-redirect-get-reload.php: Added.

TBR=Nate Chapin
Review URL: https://codereview.chromium.org/12568009

10:52 AM Changeset in webkit [146222] by commit-queue@webkit.org

4 edits in trunk

[BlackBerry] Enable USE_SYSTEM_MALLOC by default
https://bugs.webkit.org/show_bug.cgi?id=112365

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-19
Reviewed by Benjamin Poulain.

Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
harcoding it in wtf/Platform.h

Source/WTF:

wtf/Platform.h:

Tools:

Scripts/webkitperl/FeatureList.pm:

10:47 AM Changeset in webkit [146221] by Simon Fraser

3 edits in trunk/LayoutTests

Assertion in LegacyWebArchive::create() in editing tests
https://bugs.webkit.org/show_bug.cgi?id=112642

editing/pasteboard/5780697-1.html is also a flakey assertion.

Move to mac-wk2 beacuse these only seem to happen in WK2.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

10:43 AM Changeset in webkit [146220] by commit-queue@webkit.org

17 edits in trunk/Source/WebCore

Web Inspector: Fix menu items capitalization.
https://bugs.webkit.org/show_bug.cgi?id=112553

The context menu items should be correctly capitalized.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._emptyElementContextMenu):
(WebInspector.XHRBreakpointsSidebarPane.prototype._contextMenu):

inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.Placard.prototype._placardContextMenu):

inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleView.prototype._handleContextMenuEvent.get var):
(WebInspector.ConsoleView.prototype._handleContextMenuEvent.set get contextMenu):

inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype._contextMenu):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._contextMenuInDataTable):

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._contextMenuEventFired.set get var):
(WebInspector.ElementsPanel.prototype.appendApplicableItems):

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):

inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotSortableDataGrid.prototype.populateContextMenu):

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkPanel.prototype.appendApplicableItems):

inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype._handleContextMenuEvent):
(WebInspector.ProfilesPanel.prototype.appendApplicableItems):
(WebInspector.ProfileSidebarTreeElement.prototype.handleContextMenuEvent):

inspector/front-end/ResourcesPanel.js:

(WebInspector.FileSystemListTreeElement.prototype._handleContextMenuEvent):

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._appendUISourceCodeMappingItems):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._appendFunctionItems):

inspector/front-end/TabbedPane.js:

(WebInspector.TabbedPaneTab.prototype._tabContextMenu):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._contextMenu):

inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSection.prototype._emptyElementContextMenu):
(WebInspector.WatchExpressionTreeElement.prototype.populateContextMenu):

10:31 AM Changeset in webkit [146219] by Simon Fraser

2 edits in trunk/LayoutTests

ASSERTION FAILED: m_scheduledTasksAreSuspended
https://bugs.webkit.org/show_bug.cgi?id=97124

Mark fast/loader/dynamic-iframe-extra-back-forward-item.html as sometimes crashing in debug.

platform/mac-wk2/TestExpectations:

10:29 AM Changeset in webkit [146218] by alecflett@chromium.org

12 edits in trunk

Inspector: IndexedDB clear button and menu item
https://bugs.webkit.org/show_bug.cgi?id=112066

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Adds a button that can clear the contents of an objectStore from
the IDBDataView, and a context menu from the ResourcesPanel that
can do the same.

This also disables the Refresh button from the IDBDataView, so there
is at least some visual feedback that the refresh button is working.

Tests: http/tests/inspector/indexeddb/database-data.html

inspector/Inspector.json: New API clearObjectStore.
inspector/InspectorIndexedDBAgent.cpp: Implementation of clearObjectStore

(WebCore):
(ClearObjectStoreListener): Calls the original closure after the objectStore is cleared.
(ClearObjectStore): Initiates the clear operation after the DB opens.

inspector/front-end/IndexedDBModel.js: Exposes clearObjectStore to the Model API.

(WebInspector.IDBDataView): Add clear button and enable/disable clear and refresh buttons appropriately.

inspector/front-end/ResourcesPanel.js: Add a menu item and refresh the displayed data after the clear.
inspector/front-end/inspector.css: Add a style to show the right button for clear.

LayoutTests:

Add extra methods to test clearing the database after populating it.

10:26 AM Changeset in webkit [146217] by Simon Fraser

2 edits in trunk/LayoutTests

[Mac] Flaky crash in SliderThumbElement::defaultEventHandler on fast/forms/range/slider-delete-while-dragging-thumb.html
https://bugs.webkit.org/show_bug.cgi?id=108223

platform/mac/TestExpectations:

10:08 AM Changeset in webkit [146216] by Nate Chapin

5 edits in trunk/Source/WebCore

Merge MainResourceLoader::responseReceived into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=112593

Part of the ongoing effort to merge MainResourceLoader entirely
into DocumentLoader.

Reviewed by Adam Barth.

No new tests, refactor only.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading): The only thing left in

MainResourceLoader related to this function was a RefPtr which indirectly
protected DocumentLoader. Move the RefPtr here and protect DocumentLoader directly.

(WebCore::DocumentLoader::responseReceived): Moved from MainResourceLoader.
(WebCore::DocumentLoader::callContinueAfterContentPolicy): Moved from MainResourceLoader.
(WebCore::DocumentLoader::continueAfterContentPolicy): Moved from MainResourceLoader.
(WebCore::DocumentLoader::interruptedForPolicyChangeError): Moved from MainResourceLoader.
(WebCore::DocumentLoader::stopLoadingForPolicyChange): Moved from MainResourceLoader.
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::cancelMainResourceLoad):

loader/DocumentLoader.h:

(WebCore::DocumentLoader::isLoadingMultipartContent): Store multipart bit here.

loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::cancel):
(WebCore::MainResourceLoader::responseReceived):
(WebCore::MainResourceLoader::notifyFinished):

loader/MainResourceLoader.h:

10:06 AM Changeset in webkit [146215] by tony@chromium.org

2 edits in trunk/Source/WebCore

Cleanup defaultUnifiedTextCheckerEnabled type
https://bugs.webkit.org/show_bug.cgi?id=112640

Reviewed by Adam Barth.

It's a bool setting. I accidentally declared the default value as a double
in r139202.

No new tests, this is a refactor/code cleanup.

page/Settings.cpp:

(WebCore): Switch from double to a bool.

9:56 AM Changeset in webkit [146214] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: Increase DataGrid default font size.
https://bugs.webkit.org/show_bug.cgi?id=112692

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.

The default font of 10px is too small. Most instances of DataGrid set
font to 11px.

inspector/front-end/dataGrid.css:

(.data-grid table):

9:49 AM Changeset in webkit [146213] by mvujovic@adobe.com

3 edits in trunk/Source/WebCore

Refactor conditions for setCompositingLayersNeedRebuild in RenderLayer::styleChanged
https://bugs.webkit.org/show_bug.cgi?id=112606

Reviewed by Simon Fraser.

To fix bug 109098 [1], we will need to add more conditions for calling
RenderLayerCompositor::setCompositingLayersNeedRebuild in RenderLayer::styleChanged.
Adding more non-trivial conditions will make this block of code even harder to follow.
This patch refactors the current conditions into functions:

needsCompositingLayersRebuiltForClip
needsCompositingLayersRebuiltForOverflow

In bug 109098 [1], I'm planning to add:

needsCompositingLayersRebuiltForFilters

[1]: https://bugs.webkit.org/show_bug.cgi?id=109098

No new tests. Just refactoring.

rendering/RenderLayer.cpp:

(WebCore):
(WebCore::RenderLayer::needsCompositingLayersRebuiltForClip):
(WebCore::RenderLayer::needsCompositingLayersRebuiltForOverflow):

This is a method and not a file static function because it needs to look at the
RenderLayer's stackingContainer(), which is a private method.

(WebCore::RenderLayer::styleChanged):

rendering/RenderLayer.h:

(RenderLayer):

9:20 AM Changeset in webkit [146212] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Web Inspector: Remove flaky part of testRendererProcessNativeMemorySize test.
https://bugs.webkit.org/show_bug.cgi?id=112703

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.

The memory increase size check happened to be flaky. Remove it.

src/js/Tests.js:

(.TestSuite.prototype.testRendererProcessNativeMemorySize.step1):
(.TestSuite.prototype.testRendererProcessNativeMemorySize):

9:17 AM Changeset in webkit [146211] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening,

platform/gtk/TestExpectations: Adding failure expectation for fast/dom/icon-url-property.html after r146173.
platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Rebaselining after r146141.

9:06 AM Changeset in webkit [146210] by commit-queue@webkit.org

2 edits in trunk/PerformanceTests

Web Inspector: Fix heap profiler performance tests.
https://bugs.webkit.org/show_bug.cgi?id=112701

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.

The tests were broken by profile types refactoring.

inspector/heap-snapshot-performance-test.js:

(test.performanceTest.step0):
(test.performanceTest.step1):

9:00 AM Changeset in webkit [146209] by allan.jensen@digia.com

4 edits in trunk/Source/WebCore

[Qt] Support kerning in fast path font rendering
https://bugs.webkit.org/show_bug.cgi?id=106013

Reviewed by Jocelyn Turcotte.

To support kerning in the fast font path we need to implement SimpleFontData::applyTransforms.

This patch changes the types used by the fast path GlyphBuffer to match those used by Qt,
and implements SimpleFontData::applyTransforms using QRawFont::advancesForGlyphIndexes.

platform/graphics/GlyphBuffer.h:

(GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):
(WebCore::GlyphBufferAdvance::setWidth):
(WebCore::GlyphBufferAdvance::width):
(WebCore::GlyphBufferAdvance::height):
(WebCore::GlyphBuffer::add):

platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::applyTransforms):

platform/graphics/WidthIterator.h:

(WebCore::WidthIterator::supportsTypesettingFeatures):

8:54 AM Changeset in webkit [146208] by commit-queue@webkit.org

26 edits
2 adds in trunk/Source

Web Inspector: split Console into two entities, a web-facing bound object and page console.
https://bugs.webkit.org/show_bug.cgi?id=111578

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.

Otherwise, a lot of logging in WebCore needs to go through the DOMWindow which is unnecessary.

Source/WebCore:

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.exp.in:
WebCore.gypi:
WebCore.order:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

dom/Document.cpp:

(WebCore::Document::addConsoleMessage):
(WebCore::Document::addMessage):

inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::muteConsole):
(WebCore::PageDebuggerAgent::unmuteConsole):

inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::muteConsole):
(WebCore::PageRuntimeAgent::unmuteConsole):

page/Console.cpp:

(WebCore::internalAddMessage):

page/Console.h:

(WebCore):
(Console):

page/DOMWindow.cpp:

(WebCore::DOMWindow::pageConsole):
(WebCore):
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
(WebCore::DOMWindow::printErrorMessage):

page/DOMWindow.h:

(WebCore):
(DOMWindow):

page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore):
(WebCore::Page::console):
(Page):

page/PageConsole.cpp: Added.

(WebCore::PageConsole::PageConsole):
(WebCore):
(WebCore::PageConsole::~PageConsole):
(WebCore::PageConsole::printSourceURLAndLine):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):
(WebCore::PageConsole::addMessage):
(WebCore::PageConsole::mute):
(WebCore::PageConsole::unmute):
(WebCore::PageConsole::shouldPrintExceptions):
(WebCore::PageConsole::setShouldPrintExceptions):

page/PageConsole.h: Copied from Source/WebCore/page/Console.h.

(WebCore):
(PageConsole):
(WebCore::PageConsole::create):
(WebCore::PageConsole::page):

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):
(WebCore::docLoaderFunc):

Source/WebKit/mac:

Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics shouldPrintExceptions]):
(+[WebCoreStatistics setShouldPrintExceptions:]):

8:47 AM Changeset in webkit [146207] by zandobersek@gmail.com

3 edits in trunk/Source/WebKit2

[GTK] Fix WebKit2 builds after r146193
https://bugs.webkit.org/show_bug.cgi?id=112700

Reviewed by Martin Robinson.

Apply changes to the LayerTreeHostGtk class that are analogous to changes made in r146193
to the LayerTreeHostMac class, namely introducing a PageOverlayLayersMap and using that as
the source of GraphicsLayer objects that should be operated on, making it possible to
support multiple page overlays.

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::invalidate):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostGtk::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostGtk::sizeDidChange):
(WebKit::LayerTreeHostGtk::didInstallPageOverlay):
(WebKit::LayerTreeHostGtk::didUninstallPageOverlay):
(WebKit::LayerTreeHostGtk::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostGtk::paintContents):
(WebKit::LayerTreeHostGtk::flushPendingLayerChanges):
(WebKit::LayerTreeHostGtk::createPageOverlayLayer):
(WebKit::LayerTreeHostGtk::destroyPageOverlayLayer):

WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk):

8:39 AM Changeset in webkit [146206] by allan.jensen@digia.com

2 edits in trunk/Tools

[Qt] Make ImageDiff similar to Chromium's ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=94782

Based on patch by Csaba Osztrogonác.
Reviewed by Jocelyn Turcotte.

The diff image is generated with bright red indicating errors, but letting the base image
shine through so the context of the error-pixel can be identified.

DumpRenderTree/qt/ImageDiff.cpp:

(main):

8:18 AM Changeset in webkit [146205] by commit-queue@webkit.org

2 edits in trunk

[Qt] QStyle: Set State_Enabled by default when painting style widgets.
https://bugs.webkit.org/show_bug.cgi?id=112688

Patch by David Rosca <nowrep@gmail.com> on 2013-03-19
Reviewed by Jocelyn Turcotte.

All Qt style widgets were painted with a disabled state, even when
they actually were enabled.
This change fixes it by setting State_Enabled as a default state,
which is then correctly removed when element is disabled.

Source/WebCore/platform/qt/RenderThemeQStyle.cpp:

7:47 AM Changeset in webkit [146204] by loislo@chromium.org

9 edits
1 add in trunk/Source/WebCore

Web Inspector: move OverviewGrid and OverviewWindow into separate file.
https://bugs.webkit.org/show_bug.cgi?id=112693

Reviewed by Yury Semikhatsky.

It is the third patch for the meta bug "Web Inspector: meta bug: extract OverviewGrid from TimelineOverviewPane"
It just moves the OverviewGrid and the related classes into its own file.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
inspector/compile-front-end.py:
inspector/front-end/OverviewGrid.js: Added.

(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.itemsGraphsElement):
(WebInspector.OverviewGrid.prototype.insertBeforeItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.windowLeft):
(WebInspector.OverviewGrid.prototype.windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype.reset):
(WebInspector.OverviewGrid.Window.prototype._leftResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._rightResizeElementDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._windowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._moveWindow):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowLeft):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowRight):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowMaximum):
(WebInspector.OverviewGrid.Window.prototype._setWindow):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.Window.prototype._zoom):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):
(WebInspector.OverviewGrid.WindowSelector.prototype._close):
(WebInspector.OverviewGrid.WindowSelector.prototype._updatePosition):

inspector/front-end/TimelineOverviewPane.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/inspector.html:

7:28 AM Changeset in webkit [146203] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[Qt] Monospace font does not render in proper sizes
https://bugs.webkit.org/show_bug.cgi?id=93263

Reviewed by Jocelyn Turcotte.

Do not force fonts to use integer metrics. This was necessary when the fast font path
only worked in integer but is now hindering accurate metrics. This is also required to
make kerning in the fast-path look acceptable

Only enabled for Qt 5.1+ to avoid changing all the baselines for 5.0.

platform/graphics/qt/FontPlatformDataQt.cpp:

(WebCore::FontPlatformData::FontPlatformData):

7:13 AM Changeset in webkit [146202] by commit-queue@webkit.org

5 edits
3 adds in trunk

Web Inspector: Add iframe option to inspectedWindow.eval() extension API
https://bugs.webkit.org/show_bug.cgi?id=106811

Patch by John J. Barton <johnjbarton@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Add a new case to the options processing in inspectedWindow.eval(), look
for option.frameURL <string> and/or option.scriptExecutionContext: <string>, find the
matching JS context in the runtimeModel, and call evaluate() in that
context; or error if the context is not found.

Test: http/tests/inspector/extensions-iframe-eval.html

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):

inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.frames):

Added read access to _frames

inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.contextListByFrame):

Added access to a frame's contextList, removed contextByFrameAndSecurityOrigin()

(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):

Added access to frame's mainWorldContext, rather than implicit first context.
Now we can go from ResourceTreeModel -> frame -> contextList then either
mainWorldContext() or contextBySecurityOrigin() to access contexts.

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype._onEvaluateOnInspectedPage):
(WebInspector.ExtensionServer.prototype.evaluate):

inspector/front-end/ResourceTreeModel.js:
inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onReload):
(WebInspector.ExtensionServer.prototype.resolveURLToFrame.hasMatchingURL):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):

inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.frames):

inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):

inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype.resolveURLToFrame.hasMatchingURL):
(WebInspector.ExtensionServer.prototype.):
(WebInspector.ExtensionServer.prototype.evaluate):

inspector/front-end/ResourceTreeModel.js:

(WebInspector.ResourceTreeModel.prototype.frames):

inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.contextListByFrame):
(WebInspector.FrameExecutionContextList.prototype.mainWorldContext):

LayoutTests:

New tests for evaluate in iframe options in extension API

http/tests/inspector/extensions-iframe-eval-expected.txt: Added.
http/tests/inspector/extensions-iframe-eval.html: Added.
http/tests/inspector/resources/extensions-frame-eval.html: Added.

6:22 AM Changeset in webkit [146201] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip a failing tests after r146174 and r146178.

platform/qt/TestExpectations:

5:54 AM Changeset in webkit [146200] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: rename TimelineOverviewWindow to OverviewGrid.Window and fix names for constants.
https://bugs.webkit.org/show_bug.cgi?id=112685

Reviewed by Yury Semikhatsky.

It is the second patch which extracts OverviewGrid from TimelineOverviewPane.
It renames internal components of OverviewGrid.
WebInspector.TimelineOverviewWindow -> WebInspector.OverviewGrid.Window
WebInspector.TimelineOverviewWindow.WindowSelector -> WebInspector.OverviewGrid.WindowSelector

and moves constants from WebInspector.TimelineOverviewWindow namespace to WebInspector.OverviewGrid namespace

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.Window):
(WebInspector.OverviewGrid.Window.prototype._startWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._endWindowSelectorDragging):
(WebInspector.OverviewGrid.Window.prototype._startWindowDragging):
(WebInspector.OverviewGrid.Window.prototype._windowDragging):
(WebInspector.OverviewGrid.Window.prototype._moveWindow):
(WebInspector.OverviewGrid.Window.prototype._resizeWindowRight):
(WebInspector.OverviewGrid.Window.prototype._setWindowPosition):
(WebInspector.OverviewGrid.Window.prototype._onMouseWheel):
(WebInspector.OverviewGrid.Window.prototype._zoom):
(WebInspector.OverviewGrid.WindowSelector):
(WebInspector.OverviewGrid.WindowSelector.prototype._createSelectorElement):

4:46 AM Changeset in webkit [146199] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584

Reviewed by Pavel Feldman.

It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.OverviewGrid):
(WebInspector.OverviewGrid.prototype.get grid):
(WebInspector.OverviewGrid.prototype.get clientWidth):
(WebInspector.OverviewGrid.prototype.showItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.hideItemsGraphsElement):
(WebInspector.OverviewGrid.prototype.updateDividers):
(WebInspector.OverviewGrid.prototype.addEventDividers):
(WebInspector.OverviewGrid.prototype.removeEventDividers):
(WebInspector.OverviewGrid.prototype.setWindowPosition):
(WebInspector.OverviewGrid.prototype.reset):
(WebInspector.OverviewGrid.prototype.get windowLeft):
(WebInspector.OverviewGrid.prototype.get windowRight):
(WebInspector.OverviewGrid.prototype.setWindow):
(WebInspector.OverviewGrid.prototype.addEventListener):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

4:43 AM Changeset in webkit [146198] by commit-queue@webkit.org

5 edits in trunk/Source/WebCore

Web Inspector: Add Inspector.targetCrashed event to Inspector protocol.
https://bugs.webkit.org/show_bug.cgi?id=112669

Added Inspector.targetCrashed event and handled it on the front end.
Showing a modal dialog similar to the one displayed when the remote
debugging target is disconnected.

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-19
Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
inspector/Inspector.json:
inspector/front-end/HelpScreen.js:

(WebInspector.HelpScreenUntilReload):
(WebInspector.HelpScreenUntilReload.prototype.willHide):

inspector/front-end/inspector.js:

(WebInspector.targetCrashed):

4:05 AM Changeset in webkit [146197] by abecsi@webkit.org

2 edits in trunk/Tools

[Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt

Rubber-stamped by Csaba Osztrogonác.

Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
since the latter might not cover the former.

QtTestBrowser/launcherwindow.cpp:

(LauncherWindow::print):

3:05 AM Changeset in webkit [146196] by mario@webkit.org

3 edits in trunk/Source/WebCore

[GTK] Wrong guard USE(GLX) in RedirectedXCompositeWindow
https://bugs.webkit.org/show_bug.cgi?id=112600

Reviewed by Martin Robinson.

Replace USE(GLX) condition with USE(OPENGL) && PLATFORM(X11).

platform/gtk/RedirectedXCompositeWindow.cpp: Updated guard.
platform/gtk/RedirectedXCompositeWindow.h: Ditto.

2:32 AM Changeset in webkit [146195] by rgabor@webkit.org

3 edits in trunk/Source/JavaScriptCore

Implement and32 on ARMv7 and ARM traditional platforms
https://bugs.webkit.org/show_bug.cgi?id=112663

Reviewed by Zoltan Herczeg.

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::and32): Add missing method.
(MacroAssemblerARM):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::and32): Add missing method.
(MacroAssemblerARMv7):

2:30 AM Changeset in webkit [146194] by kadam@inf.u-szeged.hu

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests.

platform/qt-5.0-wk1/TestExpectations:
platform/qt-5.0-wk2/TestExpectations:
platform/qt/TestExpectations:

2:27 AM Changeset in webkit [146193] by timothy_horton@apple.com

14 edits in trunk/Source/WebKit2

[wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505
<rdar://problem/13424796>

Reviewed by Simon Fraser.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):
Add PageOverlay argument.

WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didInstallPageOverlay):
(WebKit::DrawingAreaImpl::didUninstallPageOverlay):
(WebKit::DrawingAreaImpl::setPageOverlayNeedsDisplay):
(WebKit::DrawingAreaImpl::setPageOverlayOpacity):
Add PageOverlay argument, forward it to LayerTreeHost.
(WebKit::DrawingAreaImpl::display):
Paint all of the PageOverlays that WebPage knows about.

WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
Pass the relevant PageOverlay into the DrawingArea methods that now take it.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPageOverlay):
Take the PageOverlay to draw as an argument.
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
Allow (un)installation of multiple PageOverlays.
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):
Hit-test PageOverlays in reverse order of installation (most recently installed should be topmost).

WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::drawPageOverlay): Take the PageOverlay to draw as an argument.
(WebKit::WebPage::hasPageOverlay): Return true if we have any number of overlays.
(WebKit::WebPage::pageOverlays): Return the whole vector of overlays.

WebProcess/WebPage/mac/LayerTreeHostMac.h:

Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.

WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Operate on all installed PageOverlays, not just the most recently installed one.

(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Forward the passed-in PageOverlay on to createPageOverlayLayer/destroyPageOverlayLayer.

(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::LayerTreeHostMac::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.

(WebKit::LayerTreeHostMac::initialize):
Create layers for all of WebPage's active PageOverlays.

(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlays map.
Also, drive-by add support for accelerated overlays and debug borders/repaint counters in overlays.

(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlays map and tear it down.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
Add storage for a map of GraphicsLayer->CALayers.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Pass PageOverlay argument on to createPageOverlayLayer.

(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
Pass PageOverlay argument on to destroyPageOverlayLayer.
Refrain from re-enabling threaded scrolling if there are still more overlays installed.

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::TiledCoreAnimationDrawingArea::paintContents):
Find the PageOverlay corresponding to the GraphicsLayer that we're painting, and ask WebPage to paint it.
While not ideal (crawling the map), the vast majority of the time there will only be one entry.

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Operate on all installed PageOverlays, not just the most recently installed one.

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlays map.
Also, add its platformLayer to our m_pageOverlayPlatformLayers map.

(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlays and m_pageOverlayPlatformLayers maps and tear it down.

(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):
When we commit changes for the layer, if the GraphicsLayer's backing platform CALayer
has changed out from under us (we have a reference to the previous one in the m_pageOverlayPlatformLayers map),
the GraphicsLayer has probably switched to/from a tiled layer, and we need to swap out the
layer we have inserted into the root layer. We need to keep the layer ordering consistent with
installation order, as well.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
Assert if we try to install more than one page overlay into a CoordinatedLayerTreeHost,
as this patch does not implement multiple overlay support for Coordinated Graphics.
Keep track of the current PageOverlay so that paintContents can hand WebPage the right one.
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay): Remove our reference to the PageOverlay.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity): Add unused PageOverlay argument.
(WebKit::CoordinatedLayerTreeHost::paintContents): Hand WebPage the PageOverlay we're currently displaying.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost): Add PageOverlay* argument to relevant functions, and storage for m_pageOverlay.

2:09 AM Changeset in webkit [146192] by mihnea@adobe.com

4 edits
2 adds in trunk

[CSSRegions] Crash reflowing content in variable width regions
https://bugs.webkit.org/show_bug.cgi?id=112515

Reviewed by David Hyatt.

Source/WebCore:

When removing floats during relayout of a line in a paginated context,
we have to make sure that the floats collection actually has elements before
accessing the last float from the collection.
This situation arises when a block had floats in a previous layout and after
they were removed, m_floatingObjects is not destroyed, only emptied.

Test: fast/regions/crash-reflow-inline-content-in-variable-width-regions.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObjectsBelow):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):

LayoutTests:

fast/regions/crash-reflow-inline-content-in-variable-width-regions-expected.txt: Added.
fast/regions/crash-reflow-inline-content-in-variable-width-regions.html: Added.

2:06 AM Changeset in webkit [146191] by vsevik@chromium.org

14 edits
1 add in trunk

Web Inspector: Debugger scripts should visually differ from network/filesystem files in workspace.
https://bugs.webkit.org/show_bug.cgi?id=112552

Reviewed by Pavel Feldman.

Source/WebCore:

Extracted ContentProviderBasedProjectDelegate from SimpleProjectDelegate.
Implemented DebuggerProjectDelegate for DefaultScriptMapping.
Debugger scripts are now added to workspace with a name starting with [VM] and ending with scriptId.
Added yellow background to debugger scripts editor.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.py:
inspector/front-end/ContentProviderBasedProjectDelegate.js: Added.
inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DefaultScriptMapping.prototype._debuggerReset):
(WebInspector.DebuggerProjectDelegate):
(WebInspector.DebuggerProjectDelegate.prototype.id):
(WebInspector.DebuggerProjectDelegate.prototype.type):
(WebInspector.DebuggerProjectDelegate.prototype.displayName):
(WebInspector.DebuggerProjectDelegate.prototype.addScript):

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame):

inspector/front-end/ParsedURL.js:

(WebInspector.ParsedURL.splitURL):

inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate):
(WebInspector.SimpleProjectDelegate.prototype.addFile):
(WebInspector.SimpleProjectDelegate.prototype._ensureUniquePath):
(WebInspector.SimpleWorkspaceProvider.prototype._innerAddFileForURL):

inspector/front-end/WebKit.qrc:
inspector/front-end/Workspace.js:

(WebInspector.Workspace.prototype.uiSourceCodeForURL):

inspector/front-end/inspector.html:
inspector/front-end/javaScriptSourceFrame.css: Added.

(.source-frame-debugger-script):

LayoutTests:

inspector/debugger/live-edit-breakpoints-expected.txt:

1:58 AM Changeset in webkit [146190] by rniwa@webkit.org

14 edits in trunk/Source/WebKit2

Unreviewed, rolling out r146183.
http://trac.webkit.org/changeset/146183
https://bugs.webkit.org/show_bug.cgi?id=112673

Caused a few dozens of editing tests to fail on Mac WK2
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-19

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didInstallPageOverlay):
(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):
(WebKit::CoordinatedLayerTreeHost::setPageOverlayNeedsDisplay):
(WebKit::CoordinatedLayerTreeHost::setPageOverlayOpacity):
(WebKit::CoordinatedLayerTreeHost::paintContents):

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost):

WebProcess/WebPage/DrawingArea.h:

(WebKit):
(WebKit::DrawingArea::didInstallPageOverlay):
(WebKit::DrawingArea::didUninstallPageOverlay):
(WebKit::DrawingArea::setPageOverlayNeedsDisplay):
(WebKit::DrawingArea::setPageOverlayOpacity):

WebProcess/WebPage/DrawingAreaImpl.cpp:

WebProcess/WebPage/DrawingAreaImpl.h:

(DrawingAreaImpl):

WebProcess/WebPage/LayerTreeHost.h:

(LayerTreeHost):
(WebKit::LayerTreeHost::setPageOverlayOpacity):

WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPageOverlay):
(WebKit::WebPage::installPageOverlay):
(WebKit::WebPage::uninstallPageOverlay):
(WebKit::WebPage::mouseEvent):
(WebKit::WebPage::mouseEventSyncForTesting):

WebProcess/WebPage/WebPage.h:

(WebKit):
(WebPage):
(WebKit::WebPage::hasPageOverlay):

WebProcess/WebPage/mac/LayerTreeHostMac.h:

(WebKit):
(LayerTreeHostMac):

WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::initialize):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):
(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer):

1:41 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

Add new change on track (diff)

1:08 AM Changeset in webkit [146189] by g.czajkowski@samsung.com

2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

spelling-changed-text.html passes after r145849.

platform/efl/TestExpectations:

1:07 AM Changeset in webkit [146188] by commit-queue@webkit.org

7 edits
1 add in trunk/Source/WebCore

Web Inspector: [CodeMirror] add smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=112138

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.

No new tests.

Add closebrackets add-on to codemirror which implements smart braces
functionality and guard this setting with the "Text Editor smart
braces" experiment.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
inspector/front-end/CodeMirrorTextEditor.js:
inspector/front-end/WebKit.qrc:
inspector/front-end/cm/closebrackets.js: Added.

(.):

1:04 AM Changeset in webkit [146187] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Avoid forcing text editor resize
https://bugs.webkit.org/show_bug.cgi?id=112581

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.

No new tests.

Avoid unnecessary text editor resizing by removing line decoration
via removeDecoration method instead of DOM remove operation.

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype._setTextEditorDecorations):

1:03 AM Changeset in webkit [146186] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] fix cursor movements
https://bugs.webkit.org/show_bug.cgi?id=112555

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-19
Reviewed by Vsevolod Vlasov.

No new tests.

Update CodeMirror to ToT to include its improved cursor movement
Add a small keymap to force cursor stop on both line endings and line

starts.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.FixWordMovement):
(WebInspector.CodeMirrorTextEditor.FixWordMovement.moveRight):

inspector/front-end/cm/codemirror.css:

(.CodeMirror div.CodeMirror-cursor):
(.CodeMirror.cm-keymap-fat-cursor div.CodeMirror-cursor):
(.CodeMirror):

inspector/front-end/cm/codemirror.js:

(window.CodeMirror):
(window.CodeMirror.):

1:01 AM GStreamer edited by Philippe Normand

(diff)

12:56 AM Changeset in webkit [146185] by abarth@webkit.org

2 edits in trunk/Source/WebCore

[chromium] Regression(143825): select elements don't open when there is a marquee on the page
https://bugs.webkit.org/show_bug.cgi?id=111278

Unreviewed.

This patch is a rollout of http://trac.webkit.org/changeset/143825. The
original patch caused a regression in the Chromium port.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):

12:54 AM GStreamer/GStreamerOnMac edited by Philippe Normand

(diff)

12:50 AM Changeset in webkit [146184] by apavlov@chromium.org

3 edits
2 adds in trunk

Web Inspector: [Styles] Matching @host rule children are not displayed
https://bugs.webkit.org/show_bug.cgi?id=112664

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Process host rules' contents akin to media rules' when handling the CSS model and source data.

Test: platform/chromium/inspector/styles/host-rules.html

inspector/InspectorStyleSheet.cpp:

(flattenSourceData):
(WebCore::asCSSRuleList):

LayoutTests:

platform/chromium/inspector/styles/host-rules-expected.txt: Added.
platform/chromium/inspector/styles/host-rules.html: Added.

Mar 18, 2013:

11:46 PM Changeset in webkit [146183] by timothy_horton@apple.com

14 edits in trunk/Source/WebKit2

[wk2] Should support multiple page overlays, like the API suggests
https://bugs.webkit.org/show_bug.cgi?id=112505
<rdar://problem/13424796>

Reviewed by Simon Fraser.

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/DrawingArea.h:

WebProcess/WebPage/DrawingAreaImpl.cpp:

WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::setNeedsDisplay):
(WebKit::PageOverlay::fadeAnimationTimerFired):
Pass the relevant PageOverlay into the DrawingArea methods that now take it.

WebProcess/WebPage/WebPage.cpp:

WebProcess/WebPage/WebPage.h:

WebProcess/WebPage/mac/LayerTreeHostMac.h:

Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.

WebProcess/WebPage/mac/LayerTreeHostMac.mm:

(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplayInRect):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
Operate on all installed PageOverlays, not just the most recently installed one.

(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
Forward the passed-in PageOverlay on to createPageOverlayLayer/destroyPageOverlayLayer.

(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::LayerTreeHostMac::initialize):
Create layers for all of WebPage's active PageOverlays.

(WebKit::LayerTreeHostMac::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, drive-by add support for accelerated overlays and debug borders/repaint counters in overlays.

(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers map and tear it down.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):
Add PageOverlay argument to a few methods.
Add storage for a map of PageOverlay->GraphicsLayers.
Add storage for a map of GraphicsLayer->CALayers.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):
Pass PageOverlay argument on to createPageOverlayLayer.

(WebKit::TiledCoreAnimationDrawingArea::setPageOverlayNeedsDisplay):
Look up the GraphicsLayer for the PageOverlay we need to dirty, and dirty it.

(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer):
Stick the newly-created GraphicsLayer into the m_pageOverlayLayers map.
Also, add its platformLayer to our m_pageOverlayPlatformLayers map.

(WebKit::TiledCoreAnimationDrawingArea::destroyPageOverlayLayer):
Remove the relevant overlay from the m_pageOverlayLayers and m_pageOverlayPlatformLayers maps and tear it down.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

(CoordinatedLayerTreeHost): Add PageOverlay* argument to relevant functions, and storage for m_pageOverlay.

11:17 PM Changeset in webkit [146182] by apavlov@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Styles] The "inherit" property value should be suggested for all properties
https://bugs.webkit.org/show_bug.cgi?id=112662

Reviewed by Vsevolod Vlasov.

inspector/front-end/CSSMetadata.js:

(WebInspector.CSSMetadata.keywordsForProperty):

11:17 PM Changeset in webkit [146181] by levin@chromium.org

3 edits
1 add in trunk/LayoutTests

Change icon-url-property test for platforms which don't support dumpIconChanges.
https://bugs.webkit.org/show_bug.cgi?id=112660

Reviewed by Simon Fraser.

Add the baseline for mac and remove the test failure.

fast/dom/icon-url-property.html:
platform/mac/TestExpectations:
platform/mac/fast/dom/icon-url-property-expected.txt: Added.

10:41 PM Changeset in webkit [146180] by Simon Fraser

2 edits in trunk/LayoutTests

Media playhead button is sometimes 1px wider: media/video-playing-and-pause.html flakey
https://bugs.webkit.org/show_bug.cgi?id=112659

platform/mac/TestExpectations:

10:23 PM Changeset in webkit [146179] by fpizlo@apple.com

6 edits
6 adds in trunk

DFG ToString generic cases should work correctly
https://bugs.webkit.org/show_bug.cgi?id=112654
<rdar://problem/13447250>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

fast/js/dfg-to-string-on-cell-expected.txt: Added.
fast/js/dfg-to-string-on-cell.html: Added.
fast/js/dfg-to-string-on-value-expected.txt: Added.
fast/js/dfg-to-string-on-value.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-to-string-on-cell.js: Added.

(foo):

fast/js/script-tests/dfg-to-string-on-value.js: Added.

(foo):

9:42 PM Changeset in webkit [146178] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix for 32 bit builds.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:15 PM Changeset in webkit [146177] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r146088): ResourceRequest::cfURLRequest() is defined twice on iOS
<http://webkit.org/b/112387>

platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::cfURLRequest): Move method into
!USE(CFNETWORK) section since it's also defined in
cf/ResourceRequestCFNet.cpp on iOS.

9:00 PM Changeset in webkit [146176] by Simon Fraser

2 edits in trunk/LayoutTests

fast/dom/icon-url-property.html fails on Mac after r146173

platform/mac/TestExpectations:

8:50 PM Changeset in webkit [146175] by hclam@chromium.org

5 edits in trunk/Source/WebCore

[chromium] More tracing in deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=112648

Reviewed by James Robinson.

Adding more trace events for a couple things in deferred image decoding path:

Time span for each lock pixels of SkPixelRef.
Time spent on decoding, scaling and pruning. Also the stack trace for these events.
Memory usage and number of cached entries.
Number of decode & scale operations done per image.

No test as this just add tracing information and no behavior change.

platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::prune):
(WebCore::ImageDecodingStore::insertCacheInternal):
(WebCore::ImageDecodingStore::removeFromCacheInternal):

platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decodeAndScale):
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decode):

platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):
(WebCore::LazyDecodingPixelRef::onUnlockPixels):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):

8:22 PM Changeset in webkit [146174] by msaboff@apple.com

5 edits in trunk/Source/JavaScriptCore

EFL: Unsafe branch detected in compilePutByValForFloatTypedArray()
https://bugs.webkit.org/show_bug.cgi?id=112609

Reviewed by Geoffrey Garen.

Created local valueFPR and scratchFPR and filled them with valueOp.fpr() and scratch.fpr()
respectively so that if valueOp.fpr() causes a spill during allocation, it occurs before the
branch and also to follow convention. Added register allocation checks to FPRTemporary.
Cleaned up a couple of other places to follow the "AllocatVirtualRegType foo, get machine
reg from foo" pattern.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::fprAllocate):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::convertToDouble):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

8:00 PM Changeset in webkit [146173] by levin@chromium.org

3 edits in trunk/LayoutTests

Dump icon change events in the icon-url-property test.
https://bugs.webkit.org/show_bug.cgi?id=112647

Reviewed by Jochen Eisinger.

This allows us to check that the didChangeIcon callback
is being done when it should be done. This test stopped
testing that in r122806 but it did before that.

fast/dom/icon-url-property-expected.txt:
fast/dom/icon-url-property.html:

7:38 PM Changeset in webkit [146172] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed. Generalized suppression for flaky
fast/js/repeat-cached-vm-reentry.html .

platform/chromium/TestExpectations:

7:26 PM Changeset in webkit [146171] by kbr@google.com

3 edits in trunk/LayoutTests

Unreviewed rebaselining after r146167.

platform/chromium-win/css3/flexbox/flexbox-baseline-margins-expected.png:
platform/chromium-win/fast/layers/scroll-rect-to-visible-expected.png:

7:12 PM Changeset in webkit [146170] by benjamin@webkit.org

2 edits in trunk/Source/WTF

[iOS] Make a UChar string equal() based on the LChar version
https://bugs.webkit.org/show_bug.cgi?id=112495

Reviewed by David Kilzer.

wtf/text/StringImpl.h:

(WTF::equal):
Create a equal() function for UChar based on the work done for LChar.

On A6, this is a speed up of about 40% for any string of 2 or more characters.
It is slower by 8% on a single UChar comparison.

6:45 PM Changeset in webkit [146169] by cevans@google.com

5 edits in branches/chromium/1410/Source/WebCore/bindings/v8

Merge 144458
BUG=150737
Review URL: https://codereview.chromium.org/12926003

6:28 PM Changeset in webkit [146168] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Unreviewed. Rebaselined run-bindings-tests after r146161.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):

6:07 PM Changeset in webkit [146167] by commit-queue@webkit.org

10 edits in trunk

[chromium] Small pixel differences in scroll bars after r145844
https://bugs.webkit.org/show_bug.cgi?id=112384

Patch by Robert Flack <flackr@chromium.org> on 2013-03-18
Reviewed by Kenneth Russell.

Source/WebCore:

Tests: fast/forms/basic-textareas-quirks.html

fast/forms/basic-textareas.html
fast/overflow/overflow-x-y.html
fast/parser/open-comment-in-textarea.html
fast/replaced/width100percent-textarea.html

platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect):

LayoutTests:

platform/chromium-linux/fast/forms/basic-textareas-expected.png:
platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
platform/chromium-win/fast/forms/basic-textareas-quirks-expected.png:

6:04 PM Changeset in webkit [146166] by Simon Fraser

2 edits in trunk/LayoutTests

fast/css/lang-mapped-to-webkit-locale-dynamic.xhtml is flakey

platform/mac/TestExpectations:

5:46 PM Changeset in webkit [146165] by bfulgham@webkit.org

3 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

The "ImageDecoder.h" file was improperly tagged as a source file to
build, causing a build failure on initial build attempts. Subsequent
or incremental builds would work.

WebCore.vcxproj/WebCore.vcxproj: Exclude CG-specific font files.

Switch 'ImageDecoder.h' to proper source file type.

WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

5:44 PM Changeset in webkit [146164] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

DFG should inline binary string concatenations (i.e. ValueAdd with string children)
https://bugs.webkit.org/show_bug.cgi?id=112599

Reviewed by Oliver Hunt.

This does as advertised: if you do x + y where x and y are strings, you'll get
a fast inlined JSRopeString allocation (along with whatever checks are necessary).
It also does good things if either x or y (or both) are StringObjects, or some
other thing like StringOrStringObject. It also lays the groundwork for making this
fast if either x or y are numbers, or some other reasonably-cheap-to-convert
value.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::isStringObjectUse):
(JSC::DFG::FixupPhase::convertStringAddUse):
(JSC::DFG::FixupPhase::attemptToMakeFastStringAdd):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAdd):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):

runtime/JSString.h:

(JSC::JSString::offsetOfFlags):
(JSString):
(JSRopeString):
(JSC::JSRopeString::offsetOfFibers):

5:37 PM Changeset in webkit [146163] by jamesr@google.com

4 edits
2 deletes in trunk/Source

[chromium] Remove unused type WebTransformationMatrix
https://bugs.webkit.org/show_bug.cgi?id=112634

Reviewed by Adam Barth.

Source/Platform:

Platform.gypi:
chromium/public/WebTransformationMatrix.h: Removed.

Source/WebCore:

WebCore.gypi:
platform/chromium/support/WebTransformationMatrix.cpp: Removed.

5:34 PM Changeset in webkit [146162] by Simon Fraser

2 edits in trunk/LayoutTests

fast/events/pageshow-pagehide.html sometimes crashes.
https://bugs.webkit.org/show_bug.cgi?id=81291

platform/mac-wk2/TestExpectations:

5:33 PM Changeset in webkit [146161] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Add IDL 'enum' support to CodeGeneratorJS.pm
https://bugs.webkit.org/show_bug.cgi?id=112475

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-18
Reviewed by Kentaro Hara.

This adds support for enumerations in JS, adding validation checking
to setters.
It also does validation checking to methods, and a new method
methodWithEnumArg in TestObj.idl

Test: bindings/scripts/test/TestObj.idl

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(NativeToJSValue):

bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::methodWithEnumArg):

bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_method_with_enum_arg):

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjEnumAttr):
(WebCore::setJSTestObjEnumAttr):
(WebCore::jsTestObjPrototypeFunctionMethodWithEnumArg):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj methodWithEnumArg:]):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::methodWithEnumArgMethod):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::methodWithEnumArgMethodCallback):
(WebCore::ConfigureV8TestObjTemplate):

5:28 PM Changeset in webkit [146160] by Simon Fraser

2 edits in trunk/LayoutTests

plugins/private-browsing-mode.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112646

platform/mac/TestExpectations:

5:27 PM Changeset in webkit [146159] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed suppression for flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112643

platform/chromium/TestExpectations:

5:24 PM Changeset in webkit [146158] by Simon Fraser

2 edits in trunk/LayoutTests

editing/deleting/paste-with-transparent-background-color.html
sometimes asserts.

platform/mac/TestExpectations:

5:20 PM Changeset in webkit [146157] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

JSC_NATIVE_FUNCTION() takes an identifier for the name and then uses #name, which is unsafe if name was already #define'd to something else
https://bugs.webkit.org/show_bug.cgi?id=112639

Reviewed by Michael Saboff.

Change it to take a string instead.

runtime/JSObject.h:

(JSC):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

5:17 PM Changeset in webkit [146156] by morrita@google.com

1 edit
2 adds in trunk/LayoutTests

Older shadow root rendered in incorrect order when multiple shadow roots containing style tags have been constructed
https://bugs.webkit.org/show_bug.cgi?id=93752

The bug was already fixed in some point. This change just adds a regression test to cover the reported problem.

Reviewed by Dimitri Glazkov.

fast/dom/shadow/multiple-shadowroots-with-empty-styles-expected.html: Added.
fast/dom/shadow/multiple-shadowroots-with-empty-styles.html: Added.

5:13 PM Changeset in webkit [146155] by Simon Fraser

2 edits in trunk/Tools

Style tweeks to default.css.

Rubber-stamped by David Kilzer.

Give visited links a different color to other links, so you can
see which builds you've viewed.

Make the <small> text less tiny.

BuildSlaveSupport/build.webkit.org-config/public_html/default.css:

(small):
(a:link,a:visited,a:active):
(a:visited):

5:12 PM Changeset in webkit [146154] by weinig@apple.com

11 edits in trunk/Source

Need a bundle SPI to generate a snapshot of a specific DOM node (like [DOMNode renderedImage])
<rdar://problem/13148631>
https://bugs.webkit.org/show_bug.cgi?id=110034

Reviewed by Tim Horton.

Source/WebCore:

WebCore.exp.in:

Add some necessary exports.

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(WKBundleNodeHandleCopySnapshotWithOptions):

WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

Add WKBundleNodeHandleCopySnapshotWithOptions function.

WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:

Fix conversion method between WKDOMNode and WKBundleNodeHandleRef to have the same
name in the header and implementation.

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):
(WebKit):
(WebKit::InjectedBundleNodeHandle::renderedImage):

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:

Add implementation of WKBundleNodeHandleCopySnapshotWithOptions.

Shared/ImageOptions.h:

(WebKit::snapshotOptionsToImageOptions):

WebProcess/WebPage/WebPage.cpp:

Move snapshotOptionsToImageOptions conversion function to a location where
it can be shared.

5:10 PM Changeset in webkit [146153] by bfulgham@webkit.org

7 edits
10 adds in trunk/Source/WebCore

[WinCairo] Build WebCore under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112637

Reviewed by Tim Horton.

WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj: Extend project

with WinCairo-specific build targets.

WebCore.vcxproj/QTMovieWin/QTMovieWinCairoDebug.props: Added.
WebCore.vcxproj/QTMovieWin/QTMovieWinCairoRelease.props: Added.
WebCore.vcxproj/WebCore.vcxproj: Update to build WinCairo version

of code.

WebCore.vcxproj/WebCoreCURL.props: Added.
WebCore.vcxproj/WebCoreCairo.props: Added.
WebCore.vcxproj/WebCoreDebugWinCairo.props: Added.
WebCore.vcxproj/WebCoreGenerated.vcxproj:
WebCore.vcxproj/WebCoreGeneratedDebugWinCairo.props: Added.
WebCore.vcxproj/WebCoreGeneratedReleaseWinCairo.props: Added.
WebCore.vcxproj/WebCoreGeneratedWinCairo.make: Added.
WebCore.vcxproj/WebCoreGeneratedWinCairoCommon.props: Added.
WebCore.vcxproj/WebCoreReleaseWinCairo.props: Added.
WebCore.vcxproj/WebCoreTestSupport.vcxproj:
WebCorePrefix.h: Update header to not include Apple-specific

headers during WinCairo build.

4:54 PM Changeset in webkit [146152] by jsbell@chromium.org

3 edits in trunk/Source/WebCore

IDB Cursor continue moves one item at a time
https://bugs.webkit.org/show_bug.cgi?id=109972

Reviewed by Tony Chang.

IndexedDB: Use seek on the underlying levelDB iterator to implement the continue operation
on a cursor, instead of advancing one item at a time. On a simple test in Chrome - open a
key cursor on an index w/ 100 items, then do continue(50), rinse and repeat - this cuts the
time 50% (850c/s to 1700c/s). (Original patch c/o Pankaj Kakkar <pankaj@google.com>)

Covered by existing storage/indexeddb cursor tests; just a performance optimization.

Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::Cursor::continueFunction): Special case first iteration w/ key
to use leveldb seek (forward cursors only, since reverse seek isn't exposed).
(WebCore::ObjectStoreKeyCursorImpl::encodeKey): Helper for encoding key to seek to.
(WebCore::ObjectStoreCursorImpl::encodeKey): Ditto.
(WebCore::IndexKeyCursorImpl::encodeKey): Ditto.
(WebCore::IndexCursorImpl::encodeKey): Ditto.
(WebCore::objectStoreCursorOptions): Store IDs for encodeKey() to use.
(WebCore::indexCursorOptions): Ditto.

Modules/indexeddb/IDBBackingStore.h:

(CursorOptions): Storage for IDs.
(Cursor): Add encodeKey() to interface.

4:52 PM Changeset in webkit [146151] by ap@apple.com

8 edits in trunk/Source/WebCore

MessagePortChannel::EventData should not be exposed
https://bugs.webkit.org/show_bug.cgi?id=112635

Reviewed by Geoff Garen.

MessagePortChannel::EventData is an implementation detail that's only needed to
store events in MessageQueue. Other existing code already gets away without it,
just passing message and ports separately.

dom/MessagePort.cpp: (WebCore::MessagePort::postMessage): (WebCore::MessagePort::dispatchMessages):
dom/MessagePortChannel.cpp:
dom/MessagePortChannel.h:
dom/default/PlatformMessagePortChannel.cpp: (WebCore::PlatformMessagePortChannel::EventData::create): (WebCore::PlatformMessagePortChannel::EventData::EventData): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote):
dom/default/PlatformMessagePortChannel.h: (WebCore::PlatformMessagePortChannel::EventData::message): (WebCore::PlatformMessagePortChannel::EventData::channels): (PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage): (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
dom/default/chromium/PlatformMessagePortChannelChromium.cpp: (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::PlatformMessagePortChannel::postMessageToRemote): (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
dom/default/chromium/PlatformMessagePortChannelChromium.h:

4:51 PM FeatureFlags edited by tkent@chromium.org

VIEW_MODE_CSS_MEDIA (diff)

4:42 PM Changeset in webkit [146150] by rniwa@webkit.org

2 edits in trunk/Tools

Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
https://bugs.webkit.org/show_bug.cgi?id=112494

Reviewed by Dirk Pranke.

Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
Also merged two pairs of methods to cleanup the code.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner.run): Merged _upload_and_show_results.
(PerfTestsRunner._generate_results): Merged _generate_output_files.

4:31 PM Changeset in webkit [146149] by cevans@google.com

6 edits
2 copies in branches/chromium/1410

Merge 145423
BUG=177686
Review URL: https://codereview.chromium.org/12573007

4:22 PM Changeset in webkit [146148] by dpranke@chromium.org

2 edits in trunk/Tools

[chromium] build xdisplaycheck when building DRT
https://bugs.webkit.org/show_bug.cgi?id=112636

Reviewed by Tony Chang.

It appears that we need xdisplaycheck to be built in order for
Xvfb to be started correctly on the bots, and DRT was missing
a dependency on it. This may be the cause of the ASAN bot not
starting up properly (it only builds DRT).

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

4:17 PM Changeset in webkit [146147] by tsepez@chromium.org

2 edits in trunk/Source/WebCore

[v8] Suppress binding integrity check of HTMLContentElement.
https://bugs.webkit.org/show_bug.cgi?id=112613

Reviewed by Adam Barth.

Patch is correct so long as fast/dom/shadow/content-element-user-agent-shadow.html
continues to pass.

html/shadow/HTMLContentElement.idl:

4:16 PM Changeset in webkit [146146] by Simon Fraser

1 edit
1 delete in trunk/LayoutTests

Remove failing Windows-specific result; this test passes now.

platform/win/media/nodesFromRect-shadowContent-expected.txt: Removed.

4:10 PM Changeset in webkit [146145] by dmazzoni@google.com

4 edits in trunk/Source/WebCore

Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

WebCore.gypi:

Add html/HTMLSelectElementWin.cpp.

html/HTMLSelectElement.cpp:

Don't compile generic platformHandleKeydownEvent on
Chromium win.

html/HTMLSelectElementWin.cpp:

Only compile platformHandleKeydownEvent on Windows.
Fix compile error in assertion.

(WebCore):

4:10 PM Changeset in webkit [146144] by bfulgham@webkit.org

2 edits
3 adds in trunk/Source/JavaScriptCore

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Use CFLite-specific

build target (standard version links against CoreFoundation.lib
instead of CFLite.lib).

JavaScriptCore.vcxproj/testapi/testapiCommonCFLite.props: Added.
JavaScriptCore.vcxproj/testapi/testapiDebugCFLite.props: Added.
JavaScriptCore.vcxproj/testapi/testapiReleaseCFLite.props: Added.

4:08 PM Changeset in webkit [146143] by akling@apple.com

3 edits in trunk/Source/WebKit2

[WK2][Mac] Don't consider empty window frames cacheable.
<http://webkit.org/b/112631>
<rdar://problem/13384894>

Reviewed by Anders Carlsson.

If the UI client overrides getWindowFrame() and returns an empty rect, send that over
to the web process and mark it as uncached. This forces the next ChromeClient::windowRect()
call to synchronously retrieve the window frame from the other side.

Fixes an issue with the Mac Web Inspector which uses empty rects to signify that there is
no known window frame yet. In this case, we should not be falling back to the native frame.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

4:05 PM Changeset in webkit [146142] by Simon Fraser

2 edits in trunk/LayoutTests

fast/loader/document-with-fragment-url-4.html sometimes asserts
https://bugs.webkit.org/show_bug.cgi?id=97124

platform/mac-wk2/TestExpectations:

3:54 PM Changeset in webkit [146141] by mkwst@chromium.org

6 edits
1 copy
3 adds in trunk

CSP 1.1: Schemeless source expressions match HTTPS resources on HTTP sites.
https://bugs.webkit.org/show_bug.cgi?id=112573

Reviewed by Adam Barth.

Source/WebCore:

Currently, the directive 'script-src example.com' would match only
scripts served from 'http://example.com' when served on an HTTP site,
and only scripts served from 'https://example.com' when served on an
HTTPS site. This patch changes the matching behavior for ports that
have enabled CSP_NEXT in order to encourage use of HTTPS resources by
allow schemeless source expressions to match HTTPS origins when on
HTTP sites.

Thread: http://lists.w3.org/Archives/Public/public-webappsec/2013Mar/0013.html
Spec change: https://dvcs.w3.org/hg/content-security-policy/rev/a7dc8820946e

Test: http/tests/security/contentSecurityPolicy/source-list-parsing-10.html

page/ContentSecurityPolicy.cpp:

(WebCore::CSPSource::CSPSource):

Pass the current policy into CSPSource so that we can check the
protected resource's scheme inside schemeMatches, rather than
overwriting the source expression's scheme before creating the
CSPSource.

(WebCore::CSPSource::schemeMatches):

If CSP_NEXT is enabled, ensure that HTTPS resources match the
HTTP scheme when loaded on HTTP pages with schemaless source
expressions.

(WebCore::CSPSource::portMatches):

Check the port against the URL's scheme: if m_scheme isn't
empty, this will match it. If m_scheme is empty, we can't
do a strict match against it, nor can we do a strict match
against the protected resource's port. Checking the URL's
port against the default port for its scheme solves this
problem elegantly.

(WebCore::CSPSourceList::parse):
(WebCore::CSPSourceList::addSourceSelf):

Pass in the policy when creating a CSPSource object.

LayoutTests:

http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:

Add support for full URLs in this type of test, which enables loading
scripts from hosts other than the current page's.

http/tests/security/contentSecurityPolicy/source-list-parsing-01-expected.txt:
http/tests/security/contentSecurityPolicy/source-list-parsing-01.html:

Drops a test from the first parsing group, as it's better grouped
with the new test added below.

http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-01.html.

Adds a new test that checks HTTPS scripts loaded against a
schemeless source expression.

platform/chromium/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt: Added.

This patch has different behavior for ports that enable CSP_NEXT,
currently Chromium and GTK.

3:51 PM Changeset in webkit [146140] by jer.noble@apple.com

5 edits in trunk/Source/WebCore

Text track cues do not update sizes when entering or exiting full screen.
https://bugs.webkit.org/show_bug.cgi?id=112472

Reviewed by Eric Carlson.

The style properties of the TextCueBoxes were not being updated after the size of the video bounds changed.
Because getDisplayTree() will not do it when the cue itself has not changed, explicitly call videoSizeDidChange()
from updateSizes().

html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): call videoSizeDidChange() on every active cue.

html/track/TextTrackCue.h:

(WebCore::TextTrackCue::hasDisplayTree): returns whether or not the cue has created a display tree without side effects.
(WebCore::TextTrackCue::videoSizeDidChange): Overridable empty method.

html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::videoSizeDidChange): Update the CSS height attribute of the cue box using the new video size.

html/track/TextTrackCueGeneric.h:

3:49 PM Changeset in webkit [146139] by levin@chromium.org

7 edits in trunk/Tools

Implement icon change notification dump for Chromium's test shell.
https://bugs.webkit.org/show_bug.cgi?id=112614

This was previously implemented for some other platforms in r58111
and r116547.

In r122806, fast/dom/icon-url-property.html stopped using it, but
it is useful for tests, so I plan to re-add it to that test again.

Reviewed by Jochen Eisinger.

DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that

icon change notifications from WebKit may be logged in test output.

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
(WebTestRunner::TestRunner::reset): Clear the new dump variable.
(WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
(WebTestRunner):
(WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::didChangeIcon):
(WebTestRunner):

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::didChangeIcon): Add the output about changing the icon.

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

3:48 PM Changeset in webkit [146138] by cevans@google.com

3 edits
2 copies in branches/chromium/1410

Merge 145481
BUG=183741
Review URL: https://codereview.chromium.org/12886025

3:47 PM Changeset in webkit [146137] by mkwst@chromium.org

4 edits
24 adds in trunk

CSP 1.1: Add 'effective-directive' to violation reports.
https://bugs.webkit.org/show_bug.cgi?id=112568

Reviewed by Adam Barth.

Source/WebCore:

https://dvcs.w3.org/hg/content-security-policy/rev/bc2bb0e5072a
introduced an 'effective-directive' field on CSP violation reports,
which allows developers to distinguish between resource types when
'default-src' is the violated directive.

This patch implements the new field behind the CSP_NEXT flag.

Test: http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html

page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::reportViolation):

These methods now accept an additional parameter to pipe the
effective directive from the initial callsite down into
ContentSecurityPolicy::reportViolation.

(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::checkMediaTypeAndReportViolation):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
(WebCore::CSPDirectiveList::allowFormAction):

These methods now pass the effective directive name down
into checkSourceAndReportViolation or reportViolation.

(WebCore::ContentSecurityPolicy::reportViolation):

page/ContentSecurityPolicy.h:

This method now accepts a new parameter that carries
the effective directive name. If CSP_NEXT is enabled,
the field is added to the violation report before it's
sent out into the world.

LayoutTests:

http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt: Added.
http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive.html: Added.

A new test that ensures that 'default-src' doesn't show up in the
effective directive field, even if it's the directive that was
actually violated.

platform/chromium/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
platform/chromium/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-only-report-uri-missing-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.

This patch changes the output of violation reports for ports that
have enabled CSP_NEXT. At the moment, I think that's Chromium and
GTK only.

3:43 PM Changeset in webkit [146136] by cevans@google.com

16 edits in branches/chromium/1410/Source

Merge 145453
BUG=183741
Review URL: https://codereview.chromium.org/12918021

3:43 PM Changeset in webkit [146135] by wjmaclean@chromium.org

6 edits in trunk/Source

Source/Platform: [chromium] Remove code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

The boundsContainsPageScale() API is going away, remove code that
depends on it.

Reviewed by James Robinson.

chromium/public/WebContentLayer.h:

(WebContentLayer):

Source/WebCore: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

Reviewed by James Robinson.

The boundsContainsPageScale() API is going away, remove code that
depends on it. Uses existing tests as no behaviour change.

platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::setAppliesPageScale):
(WebCore::GraphicsLayerChromium::appliesPageScale):

Source/WebKit/chromium: [chromium] Remove NCCH code that relies on boundsContainsPageScale().
https://bugs.webkit.org/show_bug.cgi?id=112465

Reviewed by James Robinson.

The boundContainsPageScale API is going away, remove code that relies
on it.

src/NonCompositedContentHost.cpp:

(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):

3:36 PM Changeset in webkit [146134] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed gardening. Suppressed flaky test.
https://bugs.webkit.org/show_bug.cgi?id=112629

platform/chromium/TestExpectations:

3:33 PM Changeset in webkit [146133] by Simon Fraser

2 edits in trunk/LayoutTests

Another flakey iframe flattening test.

platform/mac/TestExpectations:

3:31 PM Changeset in webkit [146132] by alecflett@chromium.org

11 edits in trunk/Source

IndexedDB: Protect against key prefix overflows
https://bugs.webkit.org/show_bug.cgi?id=111138

Reviewed by Tony Chang.

Source/WebCore:

This reworks the boundary checking for all databaseId,
objectStoreId, and indexId, including negative and
zero-based ids. All entrypoints into IDBLevelDBCoding
are protected with explicit checks and all internal
uses of KeyPrefix are protected with ASSERTs in the
various constructors.

Tests: WebKit unit tests IDBBackingStoreTest.cpp in WebKit/chromium

Modules/indexeddb/IDBBackingStore.h: Make all public methods boolean-based for errors.
Modules/indexeddb/IDBLevelDBCoding.h: Add methods for checking databaseId, objectStoreId, and indexId.

Source/WebKit/chromium:

Add tests for invalid indexIds in basic get/put operations.

3:24 PM Changeset in webkit [146131] by roger_fong@apple.com

4 edits in trunk/Source

AppleWin VS2010 Debug configuration build fix..

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj:

3:20 PM Changeset in webkit [146130] by ap@apple.com

4 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=112627
MessagePort::disentangle() takes an ExceptionCode argument without any need

Reviewed by Geoffrey Garen.

MessagePort::disentangle() is called in two places. One has ASSERT_NO_EXCEPTION,
and another fails to check the exception, but clearly cannot get one.

This function is also not exposed to bindings.

dom/MessagePort.cpp:

(WebCore::MessagePort::disentangle):
(WebCore::MessagePort::disentanglePorts):

dom/MessagePort.h:
workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):
Also removed some unhelpful comments.

3:07 PM Changeset in webkit [146129] by wangxianzhu@chromium.org

13 edits
3 adds in trunk

Variant of non-primary fell-back SVGFont causes crash.
https://bugs.webkit.org/show_bug.cgi?id=112367

Reviewed by Stephen Chenney.

Source/WebCore:

Don't go to PlatformFontData path for SimpleFontData::createScaledFontData()
for SVG fonts.

Test: svg/css/font-face-variant-crash.html

platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::createScaledFontData): Don't go to PlatformFontData path for SVG fonts.
(WebCore):

platform/graphics/SimpleFontData.h:

(SimpleFontData): Added createScaledFontData and renamed the original createScaledFontData to platformCreateScaledFontData.

BTW, Removed unreferenced commonInit.

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Renamed from createScaledFontData.

platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/qt/SimpleFontDataQt.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/skia/SimpleFontDataSkia.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wince/SimpleFontDataWinCE.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

platform/graphics/wx/SimpleFontDataWx.cpp:

(WebCore::SimpleFontData::platformCreateScaledFontData): Ditto.

LayoutTests:

resources/SpaceOnly.otf: Added. A font containing only the space glyph for testing font fallback.
svg/css/font-face-variant-crash-expected.txt: Added.
svg/css/font-face-variant-crash.html: Added.

3:02 PM Changeset in webkit [146128] by vcarbune@chromium.org

4 edits
3 adds in trunk

Determine text direction for rendering a TextTrackCue
https://bugs.webkit.org/show_bug.cgi?id=79749

Reviewed by Levi Weintraub.

Source/WebCore:

The rendering rules for WebVTT cues are slightly different
depending on the directionality determined from the characters
of the cue text. This patch implements the preliminary step
to be able to take directionality into account.

It iterates through the cue characters and setting the CSS
directionality to the one of the first strong directional character.

Test: media/track/track-cue-rendering-rtl.html

html/track/TextTrackCue.cpp:

(WebCore::TextTrackCueBox::applyCSSProperties): Applies the determined
direction.
(WebCore::TextTrackCue::TextTrackCue): Sets the default value for the
display direction.
(WebCore::isCueParagraphSeparator): Tests for explicit unicode characters
that are paragraph separators.
(WebCore):
(WebCore::TextTrackCue::determineTextDirection): Determined the direction
by the first strong directional character found.
(WebCore::TextTrackCue::calculateDisplayParameters): Updated.
(WebCore::TextTrackCue::getCSSWritingDirection): Return the determined CSS
writing direction.

html/track/TextTrackCue.h:

(TextTrackCue):

LayoutTests:

media/track/captions-webvtt/captions-rtl.vtt: Added.
media/track/track-cue-rendering-rtl-expected.txt: Added.
media/track/track-cue-rendering-rtl.html: Added.

2:43 PM Changeset in webkit [146127] by jparent@chromium.org

3 edits
2 copies in trunk/Tools

Cleanup: Move js for treemap and aggregate_results into own js files.
https://bugs.webkit.org/show_bug.cgi?id=112618

Reviewed by Dirk Pranke.

No functional changes, just moving the code into separate js file
rather than inlined in the html, so we can test it, make it more
modular, etc. Other dashboard types are already done this way.

TestResultServer/static-dashboards/aggregate_results.html:
TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.

(generatePage):
(handleValidHashParameter):
(htmlForBuilder):
(rawValuesHTML):
(chartHTML):
(filteredValues):
(chart):
(htmlForRevisionRows):
(wrapHTMLInTable):
(htmlForSummaryTable):
(valuesPerExpectation):
(htmlForTestType):
(htmlForTableRow):
(extendedEncode):

TestResultServer/static-dashboards/treemap.html:
TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.

(humanReadableTime):
(convertToWebTreemapFormat):
(reverseSortByAverage):
(generatePage):
(focusPath):
(.switch.return):
(handleQueryParameterChange):
(extractName):
(fullName):
(handleFocus.):
(handleFocus):

2:35 PM Changeset in webkit [146126] by kbr@google.com

3 edits
12 deletes in trunk/LayoutTests

Unreviewed gardening. Marked flaky tests, removed obsolete
expectations, and fixed flaky test fast/innerHTML/innerHTML-iframe.html .
https://bugs.webkit.org/show_bug.cgi?id=97816
https://bugs.webkit.org/show_bug.cgi?id=112306
https://bugs.webkit.org/show_bug.cgi?id=112621

fast/innerHTML/innerHTML-iframe.html:
platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
platform/chromium-android/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
platform/chromium-win/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
platform/chromium/TestExpectations:

2:30 PM Changeset in webkit [146125] by zandobersek@gmail.com

2 edits in trunk/Tools

[webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112622

Reviewed by Dirk Pranke.

Scripts/webkitpy/tool/steps/haslanded_unittest.py:

(HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.

2:28 PM Changeset in webkit [146124] by zandobersek@gmail.com

4 edits in trunk/Tools

[NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=112619

Reviewed by Dirk Pranke.

When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
directory and then fall back to the generic LayoutTests/platform/gtk directory.

Scripts/webkitpy/layout_tests/port/gtk.py:

(GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
Port._webkit_baseline_path method.

Scripts/webkitpy/layout_tests/port/gtk_unittest.py:

(GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
(GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.

Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
that are expected based on the builder name.

2:28 PM Changeset in webkit [146123] by bfulgham@webkit.org

10 edits
3 adds in trunk/Source/JavaScriptCore

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add build targets for

Debug_WinCairo and Release_WinCairo using CFLite.

JavaScriptCore.vcxproj/JavaScriptCoreCFLite.props: Added.
JavaScriptCore.vcxproj/JavaScriptCoreDebugCFLite.props: Added.
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj:

Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.

JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj: Ditto.
JavaScriptCore.vcxproj/JavaScriptCoreReleaseCFLite.props: Added.
JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:

Add Debug_WinCairo and Release_WinCairo build targets to
make sure headers are copied to proper build folder.

JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:

Ditto.

JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:

Ditto.

JavaScriptCore.vcxproj/jsc/jsc.vcxproj: Ditto.
JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj: Ditto.
JavaScriptCore.vcxproj/testapi/testapi.vcxproj: Ditto.

2:16 PM Changeset in webkit [146122] by Simon Fraser

2 edits in trunk/LayoutTests

Skip some tests on Windows.

platform/win/TestExpectations:

2:09 PM Changeset in webkit [146121] by bfulgham@webkit.org

3 edits in trunk/Source/WTF

[WinCairo] Get build working under VS2010.
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

WTF.vcxproj/WTF.vcxproj: Add Debug_WinCairo and Release_WinCairo

targets so headers get copied to appropriate build folder.

WTF.vcxproj/WTFGenerated.vcxproj: Ditto.

2:08 PM Changeset in webkit [146120] by bfulgham@webkit.org

2 edits
1 add in trunk/Source/WebKit

[WinCairo] Build WinCairo port under VS2010
https://bugs.webkit.org/show_bug.cgi?id=112604

Reviewed by Tim Horton.

WebKit.vcxproj/WebKit.sln: Add Debug_WinCairo and Release_WinCairo

build targets. No other changes in this patch.

WebKit.vcxproj/FeatureDefinesCairo.props: Add parallel property

sheet for WinCairo version of build.

1:57 PM Changeset in webkit [146119] by Simon Fraser

2 edits in trunk/LayoutTests

ASSERTION FAILED: !NoEventDispatchAssertion::isEventDispatchForbidden()
https://bugs.webkit.org/show_bug.cgi?id=112620

platform/mac/TestExpectations:

1:57 PM Changeset in webkit [146118] by Simon Fraser

2 edits in trunk/LayoutTests

http/tests/navigation/navigation-redirect-schedule-crash.html asserts sometimes
https://bugs.webkit.org/show_bug.cgi?id=112617

platform/mac/TestExpectations:

1:56 PM Changeset in webkit [146117] by hans@chromium.org

3 edits
2 adds in trunk

Fix GridTrackSize::operator==
https://bugs.webkit.org/show_bug.cgi?id=112501

Reviewed by Eric Seidel.

Source/WebCore:

There was a missing "other." in the function.

This was found by experimenting with a potential new Clang warning.

Test: fast/css-grid-layout/grid-dynamic-updates-relayout.html

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::operator==):

LayoutTests:

Add a test to check that style changes cause relayout correctly.

fast/css-grid-layout/grid-dynamic-updates-relayout-expected.txt: Added.
fast/css-grid-layout/grid-dynamic-updates-relayout.html: Added.

1:48 PM Changeset in webkit [146116] by alecflett@chromium.org

3 edits in trunk

Inspector: [Chromium] http/tests/inspector/indexeddb/database-data.html ASSERT on Win7 following r133855
https://bugs.webkit.org/show_bug.cgi?id=101618

Deactivate transactions created by the inspector, before
they are reactivated by IndexedDB. This puts transactions
in an identical state as when they are created by scripts.

Reviewed by Vsevolod Vlasov.

Test: http/tests/inspector/indexeddb/database-data.html

inspector/InspectorIndexedDBAgent.cpp: Make transactions inactive upon leaving the inspector code.

1:45 PM Changeset in webkit [146115] by jpfau@apple.com

5 edits
12 adds in trunk

Allow blocking of application cache in third-party contexts
https://bugs.webkit.org/show_bug.cgi?id=112288

Reviewed by Adam Barth.

Source/WebCore:

Return early if we can't access the application cache due to security
restrictions.

Tests: http/tests/security/cross-origin-appcache-allowed.html

http/tests/security/cross-origin-appcache.html
http/tests/security/same-origin-appcache-blocked.html

loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::selectCache):
(WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::canAccessApplicationCache):

LayoutTests:

http/tests/security/cross-origin-appcache-allowed-expected.txt: Added.
http/tests/security/cross-origin-appcache-allowed.html: Added.
http/tests/security/cross-origin-appcache-expected.txt: Added.
http/tests/security/cross-origin-appcache.html: Added.
http/tests/security/resources/cross-origin-iframe-for-appcache-allowed.html: Added.
http/tests/security/resources/cross-origin-iframe-for-appcache.html: Added.
http/tests/security/resources/manifest-for-appcache-allowed.manifest: Added.
http/tests/security/resources/manifest-for-appcache-blocked.manifest: Added.
http/tests/security/resources/manifest-for-appcache.manifest: Added.
http/tests/security/resources/same-origin-iframe-for-appcache-blocked.html: Added.
http/tests/security/same-origin-appcache-blocked-expected.txt: Added.
http/tests/security/same-origin-appcache-blocked.html: Added.
platform/chromium/TestExpectations:

1:37 PM Changeset in webkit [146114] by Simon Fraser

2 edits in trunk/LayoutTests

plugins/plugin-clip-subframe.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112616

platform/mac/TestExpectations:

1:28 PM Changeset in webkit [146113] by tony@chromium.org

4 edits
2 copies in branches/chromium/1410

Merge 142928 "Crash when selecting a HarfBuzz text run with SVG ..."

Crash when selecting a HarfBuzz text run with SVG fonts included
https://bugs.webkit.org/show_bug.cgi?id=109833

Reviewed by Tony Chang.

Source/WebCore:

There is an assert in SimpleFontData::applyTransforms that should not
be there, as the code is valid for SVG fonts. If we get past this,
then the HarfBuzz text run shaping code assumes that font data has a
SkTypeface member, and SVG fonts do not. So we crash there too.

For now, we fix the crashes. This still leaves incorrect selection
rectangles in this situation, on all platforms, tracked in
https://bugs.webkit.org/show_bug.cgi?id=108133

Test: svg/css/font-face-crash.html

platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::applyTransforms): Remove ASSERT_NOT_REACHED as the code can legally be reached for SVG fonts.

platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns): Check for SVG fonts in the text run, and abort if we find them.

LayoutTests:

Only known to crash on Chromium Linux (without the patch), but other platforms may be affected.

svg/css/font-face-crash-expected.txt: Added.
svg/css/font-face-crash.html: Added.

TBR=schenney@chromium.org
Review URL: https://codereview.chromium.org/12919016

1:27 PM Changeset in webkit [146112] by vsevik@chromium.org

5 edits in trunk

Web Inspector: Script should know nothing about disabled source mappings.
https://bugs.webkit.org/show_bug.cgi?id=112580

Reviewed by Pavel Feldman.

Source/WebCore:

ResourceScriptMapping handles diverged uiSourceCodes internally now.

Tested in inspector/debugger/live-edit-breakpoints.html already.

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._hasMergedToVM):
(WebInspector.ResourceScriptMapping.prototype._hasDivergedFromVM):

inspector/front-end/Script.js:

(WebInspector.Script.prototype.rawLocationToUILocation):

LayoutTests:

inspector/debugger/breakpoint-manager.html:

1:26 PM Changeset in webkit [146111] by pilgrim@chromium.org

17 edits
1 copy in trunk

[Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
https://bugs.webkit.org/show_bug.cgi?id=112571

Reviewed by Adam Barth.

Source/Platform:

New top-level enum (not tied to WebFileSystem class) will allow
easier refactoring of filesystem methods within the Platform/
directory. (All changes are behind an #ifdef so we can sync
required changes in embedders.)

chromium/public/WebFileSystemType.h: new file

(WebKit):

Platform.gypi:
chromium/public/WebFileSystem.h:
chromium/public/WebFileSystemType.h: Copied from Source/WebKit/chromium/public/WebCommonWorkerClient.h.

(WebKit):

Source/WebKit/chromium:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

public/WebCommonWorkerClient.h:

(WebCommonWorkerClient):
(WebKit::WebCommonWorkerClient::openFileSystem):

public/WebFrame.h:

(WebFrame):

public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::openFileSystem):
(WebKit::WebFrameClient::deleteFileSystem):

src/LocalFileSystemChromium.cpp:

(WebCore):
(WebCore::openFileSystemHelper):
(WebCore::LocalFileSystem::deleteFileSystem):

src/WebFrameImpl.cpp:

(WebKit):
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

src/WebFrameImpl.h:

(WebFrameImpl):

src/WebWorkerClientImpl.cpp:

(WebKit):
(WebKit::WebWorkerClientImpl::openFileSystem):

src/WebWorkerClientImpl.h:
src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):

src/WorkerFileSystemCallbacksBridge.h:

(WorkerFileSystemCallbacksBridge):

Tools:

Update function declarations for new WebFileSystemType enum. (All
changes are behind an #ifdef so we can sync required changes in embedders.)

DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::openFileSystem):
(WebViewHost::deleteFileSystem):

DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

1:25 PM Changeset in webkit [146110] by ap@apple.com

3 edits in trunk/Source/WebCore

Update MessagePort terminology to match HTML5
https://bugs.webkit.org/show_bug.cgi?id=112611

Reviewed by Anders Carlsson.

Transferable objects are "neutered" when transfered. Cloning is a different operation.

dom/MessagePort.cpp:

(WebCore::MessagePort::disentanglePorts):

dom/MessagePort.h:

(WebCore::MessagePort::isEntangled):
(WebCore::MessagePort::isNeutered):

1:23 PM Changeset in webkit [146109] by roger_fong@apple.com

5 edits in trunk/Source

AppleWin VS2010 build fix.

WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

1:23 PM Changeset in webkit [146108] by Simon Fraser

2 edits in trunk/LayoutTests

Another asserting test.

platform/mac/TestExpectations:

1:18 PM Changeset in webkit [146107] by Simon Fraser

3 edits in trunk/LayoutTests

Mark a couple of asserty tests as such.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

12:56 PM Changeset in webkit [146106] by jparent@chromium.org

3 edits
1 copy in trunk/Tools

Cleanup: Move timeline_exporer js out of html file into js.
https://bugs.webkit.org/show_bug.cgi?id=112188

Reviewed by Dirk Pranke.

Moves the javascript out of the html file and into a new js file.
This follows the format of flakiness_dashboard.{html|js}.

Also moves code from dashboard_base that is used only by this one
dashboard, and makes it private to the dashboard.

TestResultServer/static-dashboards/dashboard_base.js:
TestResultServer/static-dashboards/timeline_explorer.html:
TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.

(generatePage):
(initCurrentBuilderTestResults):
(shouldShowWebKitRevisionsOnly):
(updateTimelineForBuilder.):
(updateTimelineForBuilder):
(selectBuild):
(updateBuildIndicator):
(.addRow):
(.addNumberRow):
(.inspectorNode.getElementsByTagName.0.onclick):
(.inspectorNode.getElementsByTagName.1.onclick):
(.inspectorNode.getElementsByTagName.2.onclick):
(updateBuildInspector):
(showResultsDelta):
(decompressResults.addFlakyDelta):
(decompressResults):

12:45 PM Changeset in webkit [146105] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed gardening. Added expectation for failing test.
https://bugs.webkit.org/show_bug.cgi?id=112610

platform/chromium/TestExpectations:

12:43 PM Changeset in webkit [146104] by commit-queue@webkit.org

7 edits
20 adds in trunk

[css3-text] Add rendering support for -webkit-text-underline-position
https://bugs.webkit.org/show_bug.cgi?id=102795

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-18
Reviewed by Levi Weintraub.

Source/WebCore:

This patch implements rendering support for values [ auto | alphabetic | under ]
of CSS3 property text-underline-position. We don't fully match the specification
as we don't support [ left | right ] and this is left for another implementation
as the rendering will need to be added.

Tests: fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html

fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeMaxLogicalTop): Added method to compute maximal logical top among all chidren of
this InlineTextBox.

rendering/InlineFlowBox.h:

(InlineFlowBox):

rendering/InlineTextBox.cpp:

(WebCore::computeUnderlineOffset): Added method to compute offset for text-underline-position property.
(WebCore::InlineTextBox::paintDecoration): Paint decoration at position calculated using computeUnderlineOffset().

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Call method to compute maximal logical top among all
children of this RootInlineBox.

rendering/RootInlineBox.h:

(RootInlineBox):
(WebCore::RootInlineBox::maxLogicalTop): Added getter for m_maxLogicalTop class member.

rendering/style/RenderStyle.h: Added the usual getter / setter / initial methods for text-underline-position

property

LayoutTests:

Added text-underline-position tests for 'text-underline-position' CSS3
property, with 'webkit' prefix.

fast/css3-text/css3-text-decoration/text-underline-position/style.css: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.txt: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all.html: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.txt: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic.html: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.txt: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto.html: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.txt: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.txt: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow.html: Added.
fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under.html: Added.
platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-all-expected.png: Added.
platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-alphabetic-expected.png: Added.
platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-auto-expected.png: Added.
platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-expected.png: Added.
platform/chromium-linux/fast/css3-text/css3-text-decoration/text-underline-position/text-underline-position-under-out-of-flow-expected.png: Added.

12:32 PM Changeset in webkit [146103] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-18
Reviewed by Ojan Vafai.

No new tests (No change in behaviour)

css/html.css:

(input::-webkit-clear-button):
Missed this one in the original patch.

12:26 PM Changeset in webkit [146102] by james.wei@intel.com

6 edits in trunk/Source/WebCore

AudioBasicProcessorNode need to check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=112544

There can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of tryLocks() in the
context's updating system but the processor already updated to the new
number of channels, so need to check the channel number before processing.

Reviewed by Chris Rogers.

Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::process):

Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::process):

platform/audio/AudioDSPKernelProcessor.cpp:

(WebCore::AudioDSPKernelProcessor::AudioDSPKernelProcessor):

platform/audio/AudioDSPKernelProcessor.h:

(WebCore::AudioDSPKernelProcessor::numberOfChannels):
(AudioDSPKernelProcessor):

platform/audio/AudioProcessor.h:

(WebCore::AudioProcessor::AudioProcessor):
(AudioProcessor):

12:20 PM Changeset in webkit [146101] by dpranke@chromium.org

2 edits in trunk/Tools

Unreviewed, rolling out r145272.
http://trac.webkit.org/changeset/145272
https://bugs.webkit.org/show_bug.cgi?id=111884

Turns out the ASAN build is still broken; possibly there's
something still setting LD_LIBRARY_PATH, or possibly there's
something else wrong. In the meantime, we need it to work again.

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

12:11 PM Changeset in webkit [146100] by msaboff@apple.com

4 edits
9 adds in trunk

Potentially unsafe register allocations in DFG code generation
https://bugs.webkit.org/show_bug.cgi?id=112477

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Moved allocation of temporary GPRs to be before any generated branches in the functions below.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):

LayoutTests:

New tests added to verify proper operation of
SpeculativeJIT::compileObjectToObjectOrOtherEquality,
SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality
and SpeculativeJIT::compileObjectOrOtherLogicalNot.

fast/js/dfg-compare-final-object-to-final-object-or-other-expected.txt: Added.
fast/js/dfg-compare-final-object-to-final-object-or-other.html: Added.
fast/js/dfg-logical-not-final-object-or-other-expected.txt: Added.
fast/js/dfg-logical-not-final-object-or-other.html: Added.
fast/js/dfg-peephole-compare-final-object-to-final-object-or-other-expected.txt: Added.
fast/js/dfg-peephole-compare-final-object-to-final-object-or-other.html: Added.
fast/js/script-tests/dfg-compare-final-object-to-final-object-or-other.js: Added.
fast/js/script-tests/dfg-logical-not-final-object-or-other.js: Added.
fast/js/script-tests/dfg-peephole-compare-final-object-to-final-object-or-other.js: Added.

12:05 PM Changeset in webkit [146099] by aelias@chromium.org

7 edits
2 copies in branches/chromium/1410

Merge 145954 "TextIterator emits LF for a br element inside an e..."

TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html

editing/text-iterator/basic-iteration-shadowdom.html

editing/TextIterator.cpp:
(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):

editing/TextIterator.h:
(SimplifiedBackwardsTextIterator):

LayoutTests:

editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
editing/text-iterator/basic-iteration-shadowdom.html: Added.
editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
platform/mac/TestExpectations:

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12780019

12:04 PM Changeset in webkit [146098] by jchaffraix@webkit.org

3 edits
2 adds in trunk

[CSS Grid Layout] Fix StyleGridData::operator==
https://bugs.webkit.org/show_bug.cgi?id=112574

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-update.html

rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Fixed a bad comparison that would make us ignore grid-auto-flow changes.

LayoutTests:

fast/css-grid-layout/grid-auto-flow-update-expected.txt: Added.
fast/css-grid-layout/grid-auto-flow-update.html: Added.

11:55 AM Changeset in webkit [146097] by roger_fong@apple.com

2 edits in trunk/Source/WebKit/win

Fix typo on Windows following r145849 that was causing DRT to crash 100% of the time.

WebView.cpp:

(WebView::setSmartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):

11:52 AM Changeset in webkit [146096] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed gardening. Marked flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=112598
https://bugs.webkit.org/show_bug.cgi?id=112601
https://bugs.webkit.org/show_bug.cgi?id=112603

platform/chromium/TestExpectations:

11:41 AM Changeset in webkit [146095] by beidson@apple.com

2 edits in trunk/Source/WebKit2

Mac build fix after http://trac.webkit.org/changeset/146088

NetworkProcess/mac/NetworkResourceLoaderMac.mm:

(WebKit::NetworkResourceLoader::platformDidReceiveResponse):

11:39 AM Changeset in webkit [146094] by rafaelw@chromium.org

2 edits in trunk/Source/WebCore

[HTMLTemplateElement] parseError check in processTemplateEndTag should use hasTagName, not hasLocalName
https://bugs.webkit.org/show_bug.cgi?id=112591

Reviewed by Adam Barth.

No tests needed, change is unobservable.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):

11:34 AM Changeset in webkit [146093] by rniwa@webkit.org

2 edits in trunk/Tools

delete-stale-build-files is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=112595

Reviewed by Tim Horton.

It appears that whitelisting file extensions to keep is not a good idea.
Blacklist files to delete instead, and only delete .o files for now.
We can add more file extensions as needed.

BuildSlaveSupport/delete-stale-build-files:

11:33 AM Changeset in webkit [146092] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix missing brace.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

11:32 AM Changeset in webkit [146091] by jknotten@chromium.org

5 edits
2 adds in trunk/Source/WebKit/chromium

[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:

(WebViewImpl):

tests/WebFrameTest.cpp:
tests/WebViewTest.cpp:
tests/data/long_scroll.html: Added.
tests/data/short_scroll.html: Added.

11:29 AM Changeset in webkit [146090] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Fix variable names so they actually match the function
declarations.

Fix call to rectForPoint(), which was moved from HitTestResult to
HitTestLocation in r117091 and r126859.

WebKitSupport/ProximityDetector.cpp:

(BlackBerry::WebKit::ProximityDetector::findBestPoint):

11:09 AM Changeset in webkit [146089] by fpizlo@apple.com

43 edits
51 adds in trunk

DFG string conversions and allocations should be inlined
https://bugs.webkit.org/show_bug.cgi?id=112376

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This turns new String(), String(), String.prototype.valueOf(), and
String.prototype.toString() into intrinsics. It gives the DFG the ability to handle
conversions from StringObject to JSString and vice-versa, and also gives it the
ability to handle cases where a variable may be either a StringObject or a JSString.
To do this, I added StringObject to value profiling (and removed the stale
distinction between Myarguments and Foreignarguments). I also cleaned up ToPrimitive
handling, using some of the new functionality but also taking advantage of the
existence of Identity(String:@a).

This is a 2% SunSpider speed-up. Also there are some speed-ups on V8v7 and Kraken.
On microbenchmarks that stress new String() this is a 14x speed-up.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::hasExitSite):
(JSC):

bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::hasExitSite):
(DFG):

bytecode/DFGExitProfile.h:

(ExitProfile):
(JSC::DFG::ExitProfile::hasExitSite):

bytecode/ExitKind.cpp:

(JSC::exitKindToString):

bytecode/ExitKind.h:
bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromClassInfo):

bytecode/SpeculatedType.h:

(JSC):
(JSC::isStringObjectSpeculation):
(JSC::isStringOrStringObjectSpeculation):

create_hash_table:
dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::filterEdgeByUse):

dfg/DFGByteCodeParser.cpp:

(ByteCodeParser):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::emitArgumentPhantoms):
(DFG):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::putStructureStoreElimination):

dfg/DFGEdge.h:

(JSC::DFG::Edge::shift):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):
(FixupPhase):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
(JSC::DFG::FixupPhase::observeUseKindOnNode):

dfg/DFGGraph.h:

(JSC::DFG::Graph::hasGlobalExitSite):
(Graph):
(JSC::DFG::Graph::hasExitSite):
(JSC::DFG::Graph::clobbersWorld):

dfg/DFGNode.h:

(JSC::DFG::Node::convertToToString):
(Node):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::shouldSpeculateStringObject):
(JSC::DFG::Node::shouldSpeculateStringOrStringObject):

dfg/DFGNodeType.h:

(DFG):

dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileToStringOnCell):
(DFG):
(JSC::DFG::SpeculativeJIT::compileNewStringObject):
(JSC::DFG::SpeculativeJIT::speculateObject):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringObject):
(JSC::DFG::SpeculativeJIT::speculateStringOrStringObject):
(JSC::DFG::SpeculativeJIT::speculate):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(SpeculativeJIT):
(JSC::DFG::SpeculateCellOperand::SpeculateCellOperand):
(DFG):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGUseKind.cpp:

(WTF::printInternal):

dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

interpreter/CallFrame.h:

(JSC::ExecState::regExpPrototypeTable):

runtime/CommonIdentifiers.h:
runtime/Intrinsic.h:
runtime/JSDestructibleObject.h:

(JSDestructibleObject):
(JSC::JSDestructibleObject::classInfoOffset):

runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSObject.cpp:
runtime/JSObject.h:

(JSC):

runtime/JSWrapperObject.h:

(JSC::JSWrapperObject::allocationSize):
(JSWrapperObject):
(JSC::JSWrapperObject::internalValueOffset):
(JSC::JSWrapperObject::internalValueCellOffset):

runtime/StringPrototype.cpp:

(JSC):
(JSC::StringPrototype::finishCreation):
(JSC::StringPrototype::create):

runtime/StringPrototype.h:

(StringPrototype):

LayoutTests:

Reviewed by Geoffrey Garen.

fast/js/dfg-to-string-bad-toString-expected.txt: Added.
fast/js/dfg-to-string-bad-toString.html: Added.
fast/js/dfg-to-string-bad-valueOf-expected.txt: Added.
fast/js/dfg-to-string-bad-valueOf.html: Added.
fast/js/dfg-to-string-int-expected.txt: Added.
fast/js/dfg-to-string-int-or-string-expected.txt: Added.
fast/js/dfg-to-string-int-or-string.html: Added.
fast/js/dfg-to-string-int.html: Added.
fast/js/dfg-to-string-side-effect-clobbers-toString-expected.txt: Added.
fast/js/dfg-to-string-side-effect-clobbers-toString.html: Added.
fast/js/dfg-to-string-side-effect-expected.txt: Added.
fast/js/dfg-to-string-side-effect.html: Added.
fast/js/dfg-to-string-toString-becomes-bad-expected.txt: Added.
fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype-expected.txt: Added.
fast/js/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.html: Added.
fast/js/dfg-to-string-toString-becomes-bad.html: Added.
fast/js/dfg-to-string-toString-in-string-expected.txt: Added.
fast/js/dfg-to-string-toString-in-string.html: Added.
fast/js/dfg-to-string-valueOf-becomes-bad-expected.txt: Added.
fast/js/dfg-to-string-valueOf-becomes-bad.html: Added.
fast/js/dfg-to-string-valueOf-in-string-expected.txt: Added.
fast/js/dfg-to-string-valueOf-in-string.html: Added.
fast/js/jsc-test-list:
fast/js/regress/script-tests/string-concat-object.js: Added.

(foo):

fast/js/regress/script-tests/string-concat-pair-object.js: Added.

(foo):

fast/js/regress/script-tests/string-concat-pair-simple.js: Added.

(foo):

fast/js/regress/script-tests/string-concat-simple.js: Added.

(foo):

fast/js/regress/script-tests/string-cons-repeat.js: Added.

(foo):

fast/js/regress/script-tests/string-cons-tower.js: Added.

(foo):

fast/js/regress/string-concat-object-expected.txt: Added.
fast/js/regress/string-concat-object.html: Added.
fast/js/regress/string-concat-pair-object-expected.txt: Added.
fast/js/regress/string-concat-pair-object.html: Added.
fast/js/regress/string-concat-pair-simple-expected.txt: Added.
fast/js/regress/string-concat-pair-simple.html: Added.
fast/js/regress/string-concat-simple-expected.txt: Added.
fast/js/regress/string-concat-simple.html: Added.
fast/js/regress/string-cons-repeat-expected.txt: Added.
fast/js/regress/string-cons-repeat.html: Added.
fast/js/regress/string-cons-tower-expected.txt: Added.
fast/js/regress/string-cons-tower.html: Added.
fast/js/script-tests/dfg-to-string-bad-toString.js: Added.

(String.prototype.toString):
(foo):

fast/js/script-tests/dfg-to-string-bad-valueOf.js: Added.

(String.prototype.valueOf):
(foo):

fast/js/script-tests/dfg-to-string-int-or-string.js: Added.

(foo):

fast/js/script-tests/dfg-to-string-int.js: Added.

(foo):

fast/js/script-tests/dfg-to-string-side-effect-clobbers-toString.js: Added.

(foo):

fast/js/script-tests/dfg-to-string-side-effect.js: Added.

(foo):

fast/js/script-tests/dfg-to-string-toString-becomes-bad-with-dictionary-string-prototype.js: Added.

(foo):
(.String.prototype.toString):

fast/js/script-tests/dfg-to-string-toString-becomes-bad.js: Added.

(foo):
(.String.prototype.toString):

fast/js/script-tests/dfg-to-string-toString-in-string.js: Added.

(foo):
(.argument.toString):

fast/js/script-tests/dfg-to-string-valueOf-becomes-bad.js: Added.

(foo):
(.String.prototype.valueOf):

fast/js/script-tests/dfg-to-string-valueOf-in-string.js: Added.

(foo):
(.argument.valueOf):

11:05 AM Changeset in webkit [146088] by beidson@apple.com

13 edits
1 add in trunk/Source

NetworkProcess should send vm_copied, mmap'ed memory to WebProcesses when a
resource is already in the disk cache.
<rdar://problem/13414153> and https://bugs.webkit.org/show_bug.cgi?id=112387

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (No change in behavior).

WebCore.exp.in:

Add a CFURLRequestRef accessor even in the mac NSURL-based loader:

platform/network/cf/ResourceRequest.h:
platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::cfURLRequest):

Source/WebKit2:

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::didReceiveResponse): After notifying about the response,

call platformDidReceiveResponse.

NetworkProcess/NetworkResourceLoader.h:

NetworkProcess/mac/NetworkResourceLoaderMac.mm: Added.

(WebKit::NetworkResourceLoader::platformDidReceiveResponse): Attempt to pull a filesystem

mmap'ed buffer from the CFNetwork cache and - if it exists - abort the traditional load
and send that to the WebProcess instead.

(WebKit::NetworkResourceLoader:: fileBackedResourceMinimumSize): For now, use the VM page size.

NetworkProcess/mac/NetworkProcessMac.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Set the threshold for what

should be backed by a file on disk instead of stored in the database.

Change SharedMemory to do a vm_copy if a previously existing buffer is being passed in:

Platform/SharedMemory.h:
Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::create):
(WebKit::SharedMemory::createWithVMCopy):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::createShareableResourceDeallocator):
(WebKit::WebResourceLoader::didReceiveResource): Create a special CFDataRef whose buffer is

backed by a ShareableResource to send to the ResourceLoader in one chunk.

Shared/ShareableResource.h: Fix some comments.

WebKit2.xcodeproj/project.pbxproj:

11:01 AM Changeset in webkit [146087] by dino@apple.com

3 edits
2 adds in trunk

Only add wordspacing when kerning to actual word ends
https://bugs.webkit.org/show_bug.cgi?id=112507
<rdar://problem/12945869>

Reviewed by Enrica Casucci.

Source/WebCore:

When measuring text, we currently include any word spacing in
the result (it's removed later). When kerning is active, we
were adding the word spacing to every wordMeasurement instance
whether or not it is a separate word. For example, a nested
<span> element would get a wordMeasurement, even though it
should not always get word spacing.

Test: fast/text/word-space-with-kerning-3.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Test if the current character
referenced by the wordMeasurement is a space character, and add word
spacing only then.

LayoutTests:

fast/text/word-space-with-kerning-3-expected.html: Added.
fast/text/word-space-with-kerning-3.html: Added.

10:57 AM Changeset in webkit [146086] by tony@chromium.org

56 edits in trunk

[chromium] Default background color of listboxes should be white
https://bugs.webkit.org/show_bug.cgi?id=112480

Reviewed by Ojan Vafai.

Source/WebCore:

I think it was an accident that list boxes got the grey background color as a
side effect of trying to get the button styling. In the default GTK+ theme on
Ubuntu, list boxes get a white background. Win and OS X also use white as the
default color.

No new tests, covered by existing pixel tests.

css/themeChromiumLinux.css:

Narrow the CSS rule that overrides the background color specified in html.css.
We only want to use the button color when a select is using button styling.

LayoutTests:

Update pixel results with list boxes.

platform/chromium-linux/fast/css/text-transform-select-expected.png:
platform/chromium-linux/fast/css/text-transform-select-expected.txt:
platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.png:
platform/chromium-linux/fast/forms/HTMLOptionElement_label05-expected.txt:
platform/chromium-linux/fast/forms/disabled-select-change-index-expected.png:
platform/chromium-linux/fast/forms/disabled-select-change-index-expected.txt:
platform/chromium-linux/fast/forms/form-element-geometry-expected.png:
platform/chromium-linux/fast/forms/form-element-geometry-expected.txt:
platform/chromium-linux/fast/forms/hidden-listbox-expected.txt:
platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
platform/chromium-linux/fast/forms/listbox-bidi-align-expected.txt:
platform/chromium-linux/fast/forms/listbox-clip-expected.png:
platform/chromium-linux/fast/forms/listbox-clip-expected.txt:
platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.png:
platform/chromium-linux/fast/forms/listbox-hit-test-zoomed-expected.txt:
platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.png:
platform/chromium-linux/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
platform/chromium-linux/fast/forms/listbox-width-change-expected.png:
platform/chromium-linux/fast/forms/listbox-width-change-expected.txt:
platform/chromium-linux/fast/forms/option-strip-whitespace-expected.png:
platform/chromium-linux/fast/forms/option-strip-whitespace-expected.txt:
platform/chromium-linux/fast/forms/select-block-background-expected.png:
platform/chromium-linux/fast/forms/select-block-background-expected.txt:
platform/chromium-linux/fast/forms/select-change-listbox-size-expected.png:
platform/chromium-linux/fast/forms/select-change-listbox-size-expected.txt:
platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.png:
platform/chromium-linux/fast/forms/select-change-popup-to-listbox-expected.txt:
platform/chromium-linux/fast/forms/select-initial-position-expected.png:
platform/chromium-linux/fast/forms/select-initial-position-expected.txt:
platform/chromium-linux/fast/forms/select-item-background-clip-expected.png:
platform/chromium-linux/fast/forms/select-item-background-clip-expected.txt:
platform/chromium-linux/fast/forms/select-list-box-with-height-expected.png:
platform/chromium-linux/fast/forms/select-list-box-with-height-expected.txt:
platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.png:
platform/chromium-linux/fast/forms/select-listbox-multiple-no-focusring-expected.txt:
platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
platform/chromium-linux/fast/forms/select-overflow-scroll-expected.txt:
platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.txt:
platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.png:
platform/chromium-linux/fast/forms/select/optgroup-rendering-expected.txt:
platform/chromium-linux/fast/repaint/select-option-background-color-expected.png:
platform/chromium-linux/fast/repaint/select-option-background-color-expected.txt:
platform/chromium-linux/fast/replaced/replaced-breaking-expected.png:
platform/chromium-linux/fast/replaced/replaced-breaking-expected.txt:
platform/chromium-linux/fast/text/drawBidiText-expected.png:
platform/chromium-linux/fast/text/drawBidiText-expected.txt:
platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.png:
platform/chromium-linux/fast/text/international/bidi-listbox-atsui-expected.txt:
platform/chromium-linux/fast/text/international/bidi-listbox-expected.png:
platform/chromium-linux/fast/text/international/bidi-listbox-expected.txt:
platform/chromium-linux/fast/text/updateNewFont-expected.png:
platform/chromium-linux/fast/text/updateNewFont-expected.txt:

10:53 AM Changeset in webkit [146085] by kbr@google.com

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r146079.
http://trac.webkit.org/changeset/146079
https://bugs.webkit.org/show_bug.cgi?id=112594

many timeline tests failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

inspector/front-end/TimelineOverviewPane.js:

(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.sidebarResized):
(WebInspector.TimelineOverviewPane.prototype.zoomToFrame):
(WebInspector.TimelineOverviewPane.prototype._reset):
(WebInspector.TimelineOverviewPane.prototype.windowLeft):
(WebInspector.TimelineOverviewPane.prototype.windowRight):
(WebInspector.TimelineOverviewPane.prototype._updateWindow):

10:49 AM Changeset in webkit [146084] by peter@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] The <select> element on Android should also switch to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112559

Reviewed by Ojan Vafai.

Following r145959, also update themeChromiumAndroid.css to use the new
flexible box CSS properties. Covered by existing tests.

css/themeChromiumAndroid.css:

(select[size][multiple]):

10:38 AM Changeset in webkit [146083] by reni@webkit.org

3 edits
2 adds in trunk

Source/WebCore: Assertion faulire in SVGAnimatedPath.
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

The asserts are too restricted. The size must be greater or equal to 1.

Test: svg/animations/animated-path-via-use-debug-crash.svg

svg/SVGAnimatedPath.cpp:

(WebCore::SVGAnimatedPathAnimator::startAnimValAnimation):
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):

LayoutTests: Assertion faulire in SVGAnimatedPath
https://bugs.webkit.org/show_bug.cgi?id=106428

Reviewed by Allan Sandfeld Jensen.

svg/animations/animated-path-via-use-debug-crash.svg: Added.

10:34 AM Changeset in webkit [146082] by Simon Fraser

4 edits in trunk

[Mac] Some tests intermittently asserts in SharedBuffer::releasePurgeableBuffer()
https://bugs.webkit.org/show_bug.cgi?id=105986

Source/WebCore:

Reviewed by Brady Eidson.

A ResourceBuffer's SharedBuffer can be vended out to other clients,
for example Images, so there's no guarantee that when the
ResourceBuffer only has one ref its SharedBuffer will also have just one.
When this assumption was broken, SharedBuffer::releasePurgeableBuffer()
would assert.

Ideally SharedBuffer would be entirely encapsulated by ResourceBuffer to
avoid this problem, but ResourceBuffer can't be used by code in platform/.

Fix by having ResourceBuffer::createPurgeableBuffer() refuse to make
a purgeable buffer if the sharedBuffer has more than one ref.

Tested by existing tests.

loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::createPurgeableBuffer):

LayoutTests:

Reviewed by Brady Eidson.

Remove expected Crashes for tests which should be fixed by this change.

platform/mac/TestExpectations:

10:28 AM Changeset in webkit [146081] by Simon Fraser

5 edits in trunk/Tools

Disable accessibility notifications after each test
https://bugs.webkit.org/show_bug.cgi?id=112579

Reviewed by Tim Horton.

In WebKitTestRunner, if any tests triggered accessibility notifications,
the global notification handler would thereafter be active, and fire
notifications for all subsequent tests.

Fix by implementing AccessibilityController::resetToConsistentState() for
Mac, and using it to clear the global notification handler.

WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
(WTR::AccessibilityController::removeNotificationListener): Explicitly call
-stopObserving so that unregistering the observer doesn't rely on object lifetimes
(e.g. because of -autorelease).
(WTR::AccessibilityController::logAccessibilityEvents): Stub.
(WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
if there is one.

WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:

Add -stopObserving

WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:

(-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
(-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
center.

10:28 AM Changeset in webkit [146080] by kbr@google.com

5 edits in trunk/LayoutTests

Unreviewed. Added new test expectations after r146072.
https://bugs.webkit.org/show_bug.cgi?id=112562

platform/chromium-mac-lion/tables/mozilla/bugs/bug73321-expected.png:
platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug73321-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
platform/chromium-win/tables/mozilla/bugs/bug73321-expected.png:

10:16 AM Changeset in webkit [146079] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid.
https://bugs.webkit.org/show_bug.cgi?id=112584

Reviewed by Pavel Feldman.

It is the first path in the set.
The end goal is to extract OverviewGrid with window selectors
into a separate class in separate file and reuse it in CPU FlameChart.

inspector/front-end/TimelineOverviewPane.js:

10:14 AM Changeset in webkit [146078] by danakj@chromium.org

2 edits in trunk/Tools

[chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
https://bugs.webkit.org/show_bug.cgi?id=112392

Reviewed by James Robinson.

Removes the command line flag option from DRT.

DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

10:03 AM Changeset in webkit [146077] by antonm@chromium.org

2 edits in trunk/LayoutTests

Update test expectations.

Unreviewed gardening.

platform/chromium/TestExpectations:

10:03 AM Changeset in webkit [146076] by dgrogan@chromium.org

1 edit in branches/chromium/1410/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp

Merge 145824 "IndexedDB: Histogram leveldb open errors."

IndexedDB: Histogram leveldb open errors.
https://bugs.webkit.org/show_bug.cgi?id=112307

Reviewed by Tony Chang.

No new tests, I don't know if there's a good way to test histograms.

platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::open):

TBR=dgrogan@chromium.org
Review URL: https://codereview.chromium.org/12779020

10:01 AM Changeset in webkit [146075] by mikhail.pozdnyakov@intel.com

7 edits in trunk/Source/WebKit2

[WK2][EFL] Fix code wrapping WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=112364

Reviewed by Alexey Proskuryakov.

The patch fixes following problems in EWK2 WKPageGroupRef wrapping
code: firstly it makes sure that there is only one EwkPageGroup
instance per WKPageGroup instance, secondly it allows web page to
to use the default page group (which is implicitly created inside
web context).

UIProcess/API/C/efl/WKView.cpp:

(createWKView):

Now may pass '0' page group as a WebView creation argument so
that the default page group is used.

UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::createEvasObject):

UIProcess/API/efl/EwkView.h:

(EwkView):

Web view should be created before page group, so they are rearranged
inside class declaration.

UIProcess/API/efl/ewk_page_group.cpp:

(pageGroupMap):

A map to track corresponding EwkPageGroup and WKPageGroup
instances.

(EwkPageGroup::findOrCreateWrapper):

Returns the same EwkPageGroup instance for the same WKPageGroup
instance.

(EwkPageGroup::create):
(EwkPageGroup::EwkPageGroup):

Now there is only one constructor accepting WKPageGroupRef.

(EwkPageGroup::~EwkPageGroup):

UIProcess/API/efl/ewk_page_group_private.h:

(EwkPageGroup):

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

9:56 AM Changeset in webkit [146074] by abarth@webkit.org

3 edits
3 adds in trunk

[V8] Crash when accessing onclick attribute of document from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=112585

Reviewed by Eric Seidel.

Source/WebCore:

This ASSERT was bogus. The frame can be 0 for frameless documents, like
those created by XMLHttpRequest. When there is no frame, we act as if
JavaScript was disabled, which it is.

Test: fast/events/xhr-onclick-crash.html

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

LayoutTests:

fast/events/resources/onclick.html: Added.
fast/events/xhr-onclick-crash-expected.txt: Added.
fast/events/xhr-onclick-crash.html: Added.

9:54 AM Changeset in webkit [146073] by hmuller@adobe.com

3 edits
4 adds in trunk

[CSS Exclusions] Specifying polygonal -webkit-shape-inside value can crash browser (debug mode)
https://bugs.webkit.org/show_bug.cgi?id=112157

Reviewed by David Hyatt.

Source/WebCore:

Corrected the code which maps exclusion segments to pairs of InlineIterators. We now handle the
cases where the end of the line occurs within an exclusion segment or when it occurs before
the last exclusion segment has been reached. This can occur when a non-convex polygonal shape-inside
breaks a line up into two segments, but the shape-inside element's content only fills (or partially
fills) the first exclusion shape segment.

Tests: fast/exclusions/shape-inside/shape-inside-partial-fill-001.html

fast/exclusions/shape-inside/shape-inside-partial-fill-002.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextLineBreak):

LayoutTests:

Added tests with a polygonal shape-inside exclusion shape, where multiple shape
segments exist on one line, but the line's text either partially or completely
fills only the first exclusion shape segment.

fast/exclusions/shape-inside/shape-inside-partial-fill-001-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-partial-fill-001.html: Added.
fast/exclusions/shape-inside/shape-inside-partial-fill-002-expected.html: Added.
fast/exclusions/shape-inside/shape-inside-partial-fill-002.html: Added.

9:16 AM Changeset in webkit [146072] by eae@chromium.org

4 edits
2 adds in trunk

Change RenderTableCell to use pixelSnappedSize when painting
https://bugs.webkit.org/show_bug.cgi?id=112562

Reviewed by Eric Seidel.

Source/WebCore:

Change the paining code in RenderTableCell to use the pixel snapped size
to ensure consistent rounding given that the location was rounded during
layout.

It is currently constructing a paint rect by taking the rounded location
and the precise size and then pixel snapping it. This causes the size to
be rounded incorrectly. By instead using the pixel snapped size the
rounding problem can be avoided.

Test: fast/sub-pixel/table-cell-background.html

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::paintBackgroundsBehindCell):
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):

LayoutTests:

Add test for painting of cell backgrounds on a sub-pixel boundary.

fast/sub-pixel/table-cell-background-expected.html: Added.
fast/sub-pixel/table-cell-background.html: Added.
platform/chromium-linux/tables/mozilla/bugs/bug73321-expected.png:

9:16 AM Changeset in webkit [146071] by fpizlo@apple.com

14 edits in trunk/Source/JavaScriptCore

ObjectPrototype properties should be eagerly created rather than lazily via static tables
https://bugs.webkit.org/show_bug.cgi?id=112539

Reviewed by Oliver Hunt.

This is the first part of https://bugs.webkit.org/show_bug.cgi?id=112233. Rolling this
in first since it's the less-likely-to-be-broken part.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

runtime/CommonIdentifiers.h:
runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):
(JSC):

runtime/JSObject.h:

(JSObject):
(JSC):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):

runtime/ObjectPrototype.h:

(ObjectPrototype):

9:13 AM Changeset in webkit [146070] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

Access settings.defaultVideoPosterURL
https://bugs.webkit.org/show_bug.cgi?id=112378

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Dimitri Glazkov.

The defaultVideoPosterURL setting has been added in
https://bugs.webkit.org/show_bug.cgi?id=110263,
this added methods to access it in Chromium.
The settings will be used by Android WebView API
WebChromeClient.getDefaultVideoPoster()

public/WebSettings.h: add setDefaultVideoPosterURL
src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setDefaultVideoPosterURL): set defaultVideoPosterURL

src/WebSettingsImpl.h: add setDefaultVideoPosterURL

9:12 AM Changeset in webkit [146069] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-18
Reviewed by Andreas Kling.

No behavioral changes.

This is the followup of https://bugs.webkit.org/show_bug.cgi?id=110263
Need to use String instead of const AtomicString& which means we will do an extra hash lookup

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::posterImageURL): Change to use String for url

8:49 AM Changeset in webkit [146068] by rakuco@webkit.org

2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

platform/efl/TestExpectations: Remove

editing/pasteboard/paste-4035648-fix.html from the skipped list after
r144999.

8:33 AM Changeset in webkit [146067] by zandobersek@gmail.com

4 edits
3 adds in trunk

[GTK] plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112570

Reviewed by Martin Robinson.

Tools:

GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.

LayoutTests:

platform/gtk-wk2/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.
platform/gtk/TestExpectations: Removing the failure expectation.
platform/gtk/plugins/plugin-clip-subframe-expected.txt: Added the required baseline.

8:11 AM Changeset in webkit [146066] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Settings] Register "?" shortcut.
https://bugs.webkit.org/show_bug.cgi?id=112545

Reviewed by Vsevolod Vlasov.

F1 and "?" (show shortcuts page) are not mentioned on shortcuts page.

English.lproj/localizedStrings.js: Added string.
inspector/front-end/inspector.js: Registered F1 / "?" shortcut.

8:09 AM CoordinatedGraphicsSystem edited by Csaba Osztrogonác

update broken URLs (diff)

7:27 AM Changeset in webkit [146065] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add USE(PLATFORM_STRATEGIES) ifdefs to StorageNamespace.cpp
https://bugs.webkit.org/show_bug.cgi?id=112004

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

Check if platform strategies is enabled before using it, falling
back to StorageNamespaceImpl if it isn't.

storage/StorageNamespace.cpp:

(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):

7:23 AM WebKitGTK/2.0.x edited by Philippe Normand

(diff)

7:18 AM Changeset in webkit [146064] by Philippe Normand

4 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145831 - [GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=112358

Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

7:15 AM Changeset in webkit [146063] by Philippe Normand

13 edits
2 adds in releases/WebKitGTK/webkit-2.0

Merge r145811 - [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Source/WebCore:

React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.

A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Test: media/media-higher-prio-audio-stream.html

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayer.cpp:

(WebCore):
(MediaPlayer):
(WebCore::MediaPlayer::simulateAudioInterruption): New method
delegating an audio interruption to the private backend to
simulate the use-case where an external application needs
exclusive access to the audio device.

platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink):
(WebCore::setAudioStreamPropertiesCallback): Hooked to child-added
signal on the audio sink, delegates on setAudioStreamProperties.
(WebCore::MediaPlayerPrivateGStreamer::setAudioStreamProperties):
Sets the audio stream properties.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initializes the new attribute.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Disconnects autoaudiosink signal.
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
Changed logging.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Reacting to
the REQUEST_STATE message.
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
Added. Injects the REQUEST_STATE message to the pipeline.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Updating the
playback state if REQUEST_STATE.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Added new method and attribute.

testing/Internals.h:
testing/Internals.idl:
testing/Internals.cpp:

(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.

LayoutTests:

Created test, expected result and updated other ports
expectations.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

media/media-higher-prio-audio-stream-expected.txt: Added.
media/media-higher-prio-audio-stream.html: Added.
platform/chromium/TestExpectations: Skipped the new test.
platform/mac/TestExpectations: Skipped the new test.
platform/qt/TestExpectations: Skipped the new test for Mac and

Win.

7:13 AM Changeset in webkit [146062] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer does not restore last shown file on reload sometimes.
https://bugs.webkit.org/show_bug.cgi?id=112561

Reviewed by Alexander Pavlov.

inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype.addUISourceCode):

6:56 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

6:43 AM Changeset in webkit [146061] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] EditorClientBlackBerry: fix access to WebPage attribute
https://bugs.webkit.org/show_bug.cgi?id=112556

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Rob Buis.

This changed in r145849 and broke the BlackBerry build.

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

6:24 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

6:22 AM Changeset in webkit [146060] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0

Merge 146059 - [GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

Source/autotools/symbols.filter: make leveldb symbols local.

6:19 AM Changeset in webkit [146059] by kov@webkit.org

2 edits in trunk

[GTK] Exports leveldb symbols
https://bugs.webkit.org/show_bug.cgi?id=112526

Reviewed by Carlos Garcia Campos.

Source/autotools/symbols.filter: make leveldb symbols local.

6:05 AM Changeset in webkit [146058] by anilsson@rim.com

7 edits in trunk/Source

[BlackBerry] Detach overlays from page when compositor is detached
https://bugs.webkit.org/show_bug.cgi?id=112424

Reviewed by Rob Buis.

PR 309160

Source/WebCore:

Expose a method to retrieve a compositing thread layer's client.

No change in behavior, no new tests.

platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::client):

Source/WebKit/blackberry:

If not detached properly, the overlays would have a dangling pointer to
the page.

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):

Api/WebOverlay_p.h:

(BlackBerry::WebKit::WebOverlayPrivate::setClient):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlay):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::overlayDestroyed):
(WebOverlayPrivateCompositingThread):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::detach):
(BlackBerry::WebKit::WebPageCompositorPrivate::setPage):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):

Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::detachOverlays):
(WebPageCompositorPrivate):

5:52 AM Changeset in webkit [146057] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Resources] Local Storage: duplicate keys are processed inappropriately.
https://bugs.webkit.org/show_bug.cgi?id=112402

Reviewed by Alexander Pavlov.

When user creates new items or renames existing one some existing item
may be overriden. If value is changed, then frontend will receive
notification and update record appropriately.

If item value hasn't been changed, then no notification comes.
But UI still expect / rely on this notification.

With this patch the "no notification" scenario is fixed:
duplicate items are removed.

Another scenario is when update notification comes when we started
editing value (after entering / renaming key). In this case
selected node should not be changed to leave user in editing mode.

inspector/front-end/DOMStorageItemsView.js:

Added workarounds for "no notification" and "useless notification".

5:25 AM Companies and Organizations that have contributed to WebKit edited by allan.jensen@digia.com

(diff)

4:59 AM Changeset in webkit [146056] by allan.jensen@digia.com

3 edits in trunk/Source/WebCore

Clean up RenderFrameSet::nodeAtPoint
https://bugs.webkit.org/show_bug.cgi?id=112450

Reviewed by Eric Seidel.

Remove handling of resizing framesets from RenderFrameSet::nodeAtPoint.
The code has been incorrect since a mistake in r18333 (December 2006),
but has been dead code since r17770 (November 2006) where the then new
EventHandler started taking care of routing events to resizing FrameSets.

Since this was the only special feature of RenderFrameSet::nodeAtPoint,
the method has been removed.

rendering/RenderFrameSet.cpp:
rendering/RenderFrameSet.h:

(RenderFrameSet):

4:48 AM Changeset in webkit [146055] by commit-queue@webkit.org

3 edits
2 adds in trunk

The 'formnovalidate' attribute doesn't work correctly on button elements with child elements
https://bugs.webkit.org/show_bug.cgi?id=112541

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Fix a bug where formnovalidate attribute of <button> is not honored
if the target of the click event is an element nested within the button.

Test: fast/forms/interactive-validation-formnovalidate-child.html

html/HTMLFormElement.cpp:

(WebCore::submitElementFromEvent): Looks for the nearest FormControlElement ancestor of the event target.

LayoutTests:

fast/forms/interactive-validation-formnovalidate-child-expected.txt: Added.
fast/forms/interactive-validation-formnovalidate-child.html: Added.

4:45 AM Changeset in webkit [146054] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r145951 - [GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

GNUmakefile.am:
UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.

UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): Ditto.

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorFilesBasePath): Ditto.

4:36 AM Changeset in webkit [146053] by gyuyoung.kim@samsung.com

14 edits in trunk/LayoutTests

Unreviewed EFL rebaseline after r146050.

platform/efl/fast/css/input-search-padding-expected.txt:
platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/efl/fast/css/text-overflow-input-expected.txt:
platform/efl/fast/forms/box-shadow-override-expected.txt:
platform/efl/fast/forms/control-restrict-line-height-expected.txt:
platform/efl/fast/forms/input-appearance-height-expected.txt:
platform/efl/fast/forms/placeholder-position-expected.txt:
platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
platform/efl/fast/forms/search-styled-expected.txt:
platform/efl/fast/forms/search-vertical-alignment-expected.txt:
platform/efl/fast/forms/searchfield-heights-expected.txt:
platform/efl/fast/repaint/search-field-cancel-expected.txt:
platform/efl/fast/replaced/width100percent-searchfield-expected.txt:

4:02 AM Changeset in webkit [146052] by keishi@webkit.org

4 edits
6 adds in trunk

Add touch support to the calendar picker
https://bugs.webkit.org/show_bug.cgi?id=112256

Reviewed by Kent Tamura.

Source/WebCore:

This patch increases the hit target sizes for touch and adds touch event
support to the scroll view, scroll bar and navigation button.

Tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html

platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html
platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html

Resources/pagepopups/calendarPicker.js:

(hasInaccuratePointingDevice):
(Animator): Super class for TransitionAnimator and FlingGestureAnimator.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame):
(TransitionAnimator): Same as the old Animator. Transition from one value to another.
(TransitionAnimator.prototype.setFrom):
(TransitionAnimator.prototype.start):
(TransitionAnimator.prototype.stop):
(TransitionAnimator.prototype.setTo):
(TransitionAnimator.prototype.onAnimationFrame):
(FlingGestureAnimator):Animates the fling scroll.
(FlingGestureAnimator.prototype._valueAtTime): Returns the value at the given time.
(FlingGestureAnimator.prototype._velocityAtTime): Returns the value change velocity at the given time.
(FlingGestureAnimator.prototype._timeAtVelocity): Returns the time when the value is changing at the given velocity.
(FlingGestureAnimator.prototype.start):
(FlingGestureAnimator.prototype.onAnimationFrame):
(ScrollView): Added support for touch gesture scrolling.
(ScrollView.prototype.onTouchStart):
(ScrollView.prototype.onWindowTouchMove):
(ScrollView.prototype.onWindowTouchEnd):
(ScrollView.prototype.onFlingGestureAnimatorStep):
(ScrollView.prototype.scrollTo):
(ScrubbyScrollBar): Added support for touch.
(ScrubbyScrollBar.prototype.onTouchStart):
(ScrubbyScrollBar.prototype.onWindowTouchMove):
(ScrubbyScrollBar.prototype.onWindowTouchEnd):
(ScrubbyScrollBar.prototype._setThumbPositionFromEventPosition): Accept MouseEvent or Touch.
(ScrubbyScrollBar.prototype.onMouseDown):
(ScrubbyScrollBar.prototype.onWindowMouseMove):
(ScrubbyScrollBar.prototype.onWindowMouseUp):
(YearListCell):
(YearListView):
(YearListView.prototype.onTouchStart):
(YearListView.prototype._animateRow):
(CalendarNavigationButton): Add touch support for long press.
(CalendarNavigationButton.prototype.onTouchStart):
(CalendarNavigationButton.prototype.onWindowTouchEnd):
(CalendarNavigationButton.prototype.onMouseDown):
(CalendarNavigationButton.prototype.onWindowMouseUp):
(CalendarTableView): Disable touch gesture scrolling in the calendar table.

LayoutTests:

platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/calendar-picker-touch-operations.html: Added.
platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/month-picker-touch-operations.html: Added.
platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:

(hoverOverMonthPopupButton):
(clickMonthPopupButton): Use hoverOverMonthPopupButton.

platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations-expected.txt: Added.
platform/chromium/fast/forms/calendar-picker/week-picker-touch-operations.html: Added.

3:52 AM Changeset in webkit [146051] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BackingStoreClient: remove unnecessary call to toElement()
https://bugs.webkit.org/show_bug.cgi?id=112547

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

3:13 AM Changeset in webkit [146050] by gyuyoung.kim@samsung.com

9 edits in trunk

[EFL] Cancel mark on search field is not displayed
https://bugs.webkit.org/show_bug.cgi?id=94880

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

adjustSearchFieldCancelButtonStyle() doesn't set style width and height for search cancel button.
So, the button isn't showing up in search input field. Besides the button size should be scaled based
on the font size as chromium, qt, and blackberry ports.

Tests: fast/forms/search-cancel-button-style-sharing.html

fast/forms/search-rtl.html

platform/efl/RenderThemeEfl.cpp:

(WebCore):
(WebCore::RenderThemeEfl::adjustSearchFieldCancelButtonStyle):

LayoutTests:

Rebaseline expected results related to search cancel button.

platform/efl-wk1/TestExpectations: These tests don't work with WK1 pixel test yet.
platform/efl/TestExpectations:
platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/efl/fast/forms/search-rtl-expected.png:
platform/efl/fast/forms/search-rtl-expected.txt:

2:57 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:47 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:46 AM Changeset in webkit [146049] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99081

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-18
Reviewed by Carlos Garcia Campos.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.

UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.

(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

2:40 AM Changeset in webkit [146048] by yurys@chromium.org

11 edits in trunk

Web Inspector: Native Memory Timeline affects the performace even if was switched off.
https://bugs.webkit.org/show_bug.cgi?id=112428

Reviewed by Pavel Feldman.

Source/WebCore:

Whether to include DOM counters and native memory statistics is now
configured using Timeline.start parameters instead of sending separate
commands Timeline.setIncludeDomCounters and Timeline.setIncludeNativeMemoryStatistics.

inspector/Inspector.json:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::restore):
(WebCore::InspectorTimelineAgent::start):

inspector/InspectorTimelineAgent.h:

(InspectorTimelineAgent):

inspector/front-end/DOMCountersGraph.js:

(WebInspector.DOMCountersGraph):

inspector/front-end/NativeMemoryGraph.js:

(WebInspector.NativeMemoryGraph):

inspector/front-end/TimelineManager.js:

(WebInspector.TimelineManager.prototype.start):

inspector/front-end/TimelineModel.js:

(WebInspector.TimelineModel.prototype.startRecord):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

LayoutTests:

http/tests/inspector/timeline-test.js: chaned Timeline.start parameters

to match previous behavior.

2:32 AM Changeset in webkit [146047] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Exception in timeline DOMCounters
https://bugs.webkit.org/show_bug.cgi?id=112427

Reviewed by Pavel Feldman.

Do not update marker on DOM counters graph if the graphs haven't been
drawn yet.

inspector/front-end/MemoryStatistics.js:

(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):

2:28 AM Changeset in webkit [146046] by li.yin@intel.com

5 edits in trunk

Mediastream.ended should return true when all tracks were removed.
https://bugs.webkit.org/show_bug.cgi?id=112528

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#widl-MediaStream-ended
When all tracks have been removed, it should return true as well as all the tracks
were ended.

Test: fast/mediastream/MediaStream-add-remove-tracks.html

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::removeTrack):

LayoutTests:

fast/mediastream/MediaStream-add-remove-tracks-expected.txt:
fast/mediastream/MediaStream-add-remove-tracks.html:

2:21 AM Changeset in webkit [146045] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: make number of stack frames to capture in Timeline a setting
https://bugs.webkit.org/show_bug.cgi?id=110619

Reviewed by Pavel Feldman.

factor out creation of input type="text" control for better reuse;
add timelineLimitStackFramesFlag & timelineStackFramesToCapture settings;

English.lproj/localizedStrings.js: add "Frames to capture" and "Limit number of captured JS stack frames"
inspector/front-end/Settings.js: add 2 settings;

(WebInspector.Settings):

inspector/front-end/SettingsScreen.js: UI for the setting;

(WebInspector.GenericSettingsTab):
(WebInspector.GenericSettingsTab.prototype.get _createCSSAutoReloadControls.validateReloadTimeout):

inspector/front-end/TimelineModel.js: pass the setting value to back-end.

2:07 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:06 AM Changeset in webkit [146044] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[WebKit2][GTK] Initialize gettext also in the UIProcess side
https://bugs.webkit.org/show_bug.cgi?id=112489

Patch by Gustavo Noronha Silva <Gustavo Noronha Silva> on 2013-03-18
Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/WebKitPrivate.cpp:

(wkInitialize): set text domain and codeset for the library on
process startup, the first one is required for translations to be
found when not installed on the main system directories searched
by gettext, the second one is to please glib and GTK+

2:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:04 AM Changeset in webkit [146043] by Carlos Garcia Campos

41 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

Merge r145936 - Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

POTFILES.in: added WebKit2GTK+ files that have translatable strings.
ar.po: regenerated.
as.po: ditto.
bg.po: ditto.
cs.po: ditto.
de.po: ditto.
el.po: ditto.
en_CA.po: ditto.
en_GB.po: ditto.
eo.po: ditto.
es.po: ditto.
et.po: ditto.
eu.po: ditto.
fr.po: ditto.
gl.po: ditto.
gu.po: ditto.
he.po: ditto.
hi.po: ditto.
hu.po: ditto.
id.po: ditto.
it.po: ditto.
ko.po: ditto.
lt.po: ditto.
lv.po: ditto.
mr.po: ditto.
nb.po: ditto.
nl.po: ditto.
pa.po: ditto.
pl.po: ditto.
pt.po: ditto.
pt_BR.po: ditto.
ro.po: ditto.
ru.po: ditto.
sl.po: ditto.
sr.po: ditto.
sr@latin.po: ditto.
sv.po: ditto.
uk.po: ditto.
vi.po: ditto.
zh_CN.po: ditto.

1:52 AM Changeset in webkit [146042] by zarvai@inf.u-szeged.hu

3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-5.0-wk1/TestExpectations:
platform/qt/TestExpectations:

1:37 AM Changeset in webkit [146041] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Unreviewed, rolling out r146035.
http://trac.webkit.org/changeset/146035
https://bugs.webkit.org/show_bug.cgi?id=112540

fails to build on Windows: singned/unsigned mismatch at ln. 53
of html\HTMLSelectElementWin.cpp (Requested by antonm on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-18

WebCore.gypi:
html/HTMLSelectElement.cpp:

(WebCore):

html/HTMLSelectElementWin.cpp:

1:33 AM Changeset in webkit [146040] by haraken@chromium.org

8 edits in trunk

Unreviewed, rolling out r146033.
http://trac.webkit.org/changeset/146033
https://bugs.webkit.org/show_bug.cgi?id=112521

web audio tests are broken

Source/WebCore:

Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):

Modules/webaudio/AudioNode.h:
Modules/webaudio/AudioScheduledSourceNode.h:
Modules/webaudio/ScriptProcessorNode.idl:

LayoutTests:

webaudio/javascriptaudionode-expected.txt:
webaudio/javascriptaudionode.html:

1:17 AM Changeset in webkit [146039] by antonm@chromium.org

3 edits in trunk/LayoutTests

Update test expectations.

Unreviewed gardening.

platform/chromium-win/fast/forms/color/input-appearance-color-expected.png:
platform/chromium/TestExpectations:

1:01 AM Changeset in webkit [146038] by dominicc@chromium.org

6 edits in trunk

A placeholder renderer should not be taken to imply the existence of a text renderer in single line text controls
https://bugs.webkit.org/show_bug.cgi?id=112410

Reviewed by Tony Chang.

Source/WebCore:

The assumption that if a text control had a placeholder renderer
then it also had a text renderer is not valid. If
::-webkit-textfield-decoration-controller is set to display: none;
a single line text control's decoration container renderer and
hence text renderer are not created. This change handles this
corner case where a text control has a placeholder renderer but
not a text renderer.

Tests: fast/forms/search/search-hide-decoration-container-crash.html (Updated)

html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::fixPlaceholderRenderer):

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

Update search-hide-decoration-container-crash.html to exercise
non-null placeholder renderers and null text renderers.

Cases where neither are rendered already get coverage in
search-scroll-hidden-decoration-container-crash.html and
search-autoscroll-hidden-decoration-container-crash.html.

fast/forms/search/search-hide-decoration-container-crash.html:
fast/forms/search/search-hide-decoration-container-crash-expected.txt:

12:55 AM Changeset in webkit [146037] by dominicc@chromium.org

5 edits
2 adds in trunk

[Shadow] offsetParent should never return nodes in user agent Shadow DOM to script
https://bugs.webkit.org/show_bug.cgi?id=112530

Reviewed by Elliott Sprehn.

Source/WebCore:

Test: fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html

dom/Element.cpp:

(WebCore::Element::bindingsOffsetParent): Filter nodes in UA shadows.

dom/Element.h:

(Element): Add bindingsOffsetParent.

dom/Element.idl: bindingsOffsetParent is the implementation of offsetParent.

LayoutTests:

fast/dom/shadow/offset-parent-does-not-leak-ua-shadow-expected.txt: Added.
fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html: Added.

12:17 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas

Add new change on track (diff)

Mar 17, 2013:

11:40 PM Changeset in webkit [146036] by vsevik@chromium.org

1 edit in branches/chromium/1410/Source/WebCore/inspector/front-end/inspector.css

Merge (partial, css only) 143224 "Web Inspector: hide vertical-sidebar-split in dock..."

Web Inspector: hide vertical-sidebar-split in dock-to-right mode behind single experimental flag.
https://bugs.webkit.org/show_bug.cgi?id=110119

Reviewed by Vsevolod Vlasov.

Removed context menus, made it toggle automatically upon dock orientation change.

inspector/front-end/inspector.css:

TBR=pfeldman@chromium.org
BUG=196537
Review URL: https://codereview.chromium.org/12895003

11:25 PM Changeset in webkit [146035] by dmazzoni@google.com

4 edits in trunk/Source/WebCore

Support Windows HTMLSelectElement keystrokes on Chromium win
https://bugs.webkit.org/show_bug.cgi?id=112460

Reviewed by Kent Tamura.

Compile in the windows-specific variant of
HTMLSelectElement::platformHandleKeydownEvent
on Chromium win, in addition to PLATFORM(WIN).

WebCore.gypi:

Add html/HTMLSelectElementWin.cpp.

html/HTMLSelectElement.cpp:

Don't compile generic platformHandleKeydownEvent on
Chromium win.

html/HTMLSelectElementWin.cpp:

Only compile platformHandleKeydownEvent on Windows.

(WebCore):

10:54 PM Changeset in webkit [146034] by Simon Fraser

3 edits in trunk/LayoutTests

Mark some more tests as flakey, or asserting in debug.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

10:51 PM Changeset in webkit [146033] by commit-queue@webkit.org

8 edits in trunk

ScriptProcessorNode is garbage collected while still active if unreachable
https://bugs.webkit.org/show_bug.cgi?id=112521

Patch by Russell McClellan <russell.mcclellan@gmail.com> on 2013-03-17
Reviewed by Kentaro Hara.

Source/WebCore:

Fix for issue where ScriptProcessorNodes (and AudioNode js wrappers generally)
would be garbage collected before their time. Made AudioNode an ActiveDOMElement
marked pending if there are any open audio connections.

Test: webaudio/javascriptaudionode.html

Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::hasPendingActivity): it's pending (and thus not GCed)
if it has open audio connections.

Modules/webaudio/AudioNode.h: AudioNode is now an ActiveDOMElement
Modules/webaudio/AudioScheduledSourceNode.h: added a using declaration

to avoid function name hiding.

Modules/webaudio/ScriptProcessorNode.idl: AudioNode is an ActiveDOMElement

LayoutTests:

webaudio/javascriptaudionode-expected.txt:
webaudio/javascriptaudionode.html:

10:26 PM Changeset in webkit [146032] by commit-queue@webkit.org

11 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Step-up/-down of minute/second/millisecond fields should respect min/max attributes
https://bugs.webkit.org/show_bug.cgi?id=112527

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-17
Reviewed by Kent Tamura.

Source/WebCore:

Make step-up/-down of the minute, second, and millisecond field
respect the min/max attributes of the element.
Note that it still accepts any keyboard inputs (the element
becomes 'invalid' state when out-of-range values entered).
Also, disable these fields when there is only single possible value.

Tests: fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html

fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html

html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder): Add fields for min/max of minute/second/millisecond.
(WebCore::DateTimeEditBuilder::DateTimeEditBuilder): Set min/max for the fields.
(WebCore::DateTimeEditBuilder::visitField): Pass min/max parameters to the field constructors.
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled): Does not disable if minute, second, millisecond fields are all disabled, because we need at least one editable field.
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled): Disables if min, max, and value are equal.
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled): Ditto.
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled): Ditto.

html/shadow/DateTimeFieldElements.cpp:

(WebCore::DateTimeDayFieldElement::DateTimeDayFieldElement):
(WebCore::DateTimeHourFieldElementBase::DateTimeHourFieldElementBase):
(WebCore::DateTimeHour11FieldElement::DateTimeHour11FieldElement):
(WebCore::DateTimeHour12FieldElement::DateTimeHour12FieldElement):
(WebCore::DateTimeHour23FieldElement::DateTimeHour23FieldElement):
(WebCore::DateTimeHour24FieldElement::DateTimeHour24FieldElement):
(WebCore::DateTimeMillisecondFieldElement::DateTimeMillisecondFieldElement):
(WebCore::DateTimeMillisecondFieldElement::create):
(WebCore::DateTimeMinuteFieldElement::DateTimeMinuteFieldElement):
(WebCore::DateTimeMinuteFieldElement::create):
(WebCore::DateTimeMonthFieldElement::DateTimeMonthFieldElement):
(WebCore::DateTimeSecondFieldElement::DateTimeSecondFieldElement):
(WebCore::DateTimeSecondFieldElement::create):
(WebCore::DateTimeWeekFieldElement::DateTimeWeekFieldElement):
(WebCore::DateTimeYearFieldElement::DateTimeYearFieldElement):

html/shadow/DateTimeFieldElements.h:

(DateTimeDayFieldElement):
(DateTimeHourFieldElementBase):
(DateTimeHour11FieldElement):
(DateTimeHour12FieldElement):
(DateTimeHour23FieldElement):
(DateTimeHour24FieldElement):
(DateTimeMillisecondFieldElement): Add minimum/maximum parameters.
(DateTimeMinuteFieldElement): Add minimum/maximum parameters.
(DateTimeMonthFieldElement):
(DateTimeSecondFieldElement): Add minimum/maximum parameters.
(DateTimeWeekFieldElement):
(DateTimeYearFieldElement):

html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
(WebCore::DateTimeNumericFieldElement::formatValue): Use hard-limit value instead of m_range.maximum, because millisecond field with max<100 will be displayed in two digits otherwise.
(WebCore::DateTimeNumericFieldElement::setValueAsInteger):

html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement): Changed to have hard limits as a data member.

LayoutTests:

fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt:
fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html:

8:28 PM Changeset in webkit [146031] by abarth@webkit.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove unused WebNode::hasEventListeners API
https://bugs.webkit.org/show_bug.cgi?id=112529

Reviewed by James Robinson.

This API no longer has any callers and can be removed.

public/WebNode.h:
src/WebNode.cpp:

7:21 PM Changeset in webkit [146030] by ap@apple.com

3 edits in trunk/Source/WebCore

Encapsulate PlatformMessagePortChannel a little better yet
https://bugs.webkit.org/show_bug.cgi?id=112479

Reviewed by Sam Weinig.

dom/MessagePortChannel.h: We no longer expose PlatformMessagePortChannel in

public functions in cross-platform code.

dom/default/PlatformMessagePortChannel.cpp:

(WebCore::MessagePortChannel::createChannel): Tweaked the factory method to avoid
using the old create() function.
(WebCore::MessagePortChannel::~MessagePortChannel): Removed an unhelpful comment.

6:15 PM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

5:38 PM Changeset in webkit [146029] by tkent@chromium.org

10 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Don't update shadow tree by updating any attribute
https://bugs.webkit.org/show_bug.cgi?id=111990

Reviewed by Hajime Morrita.

Source/WebCore:

Bug detail:
Typing '1' then '1' into an hour field doesn't set the field to
'11' if an attribute is updated during these two keyboard inputs
because we always re-construct a shadow DOM tree by updating any
attributes and a shadow node records keyboard input state.

How to fix:
We should not re-construct a shadow DOM tree by updating
unaffected attributes. For example, we should re-construct it by
updating 'min' attribute, but we should not by updating 'class'
attribute.
We have InputType::updateInnerTextValue call in parseAttribute for
text field input types. The multiple fields input types
re-construct shadow DOM tree in updateInnerTextValue. The
updateInnerTextValue call is unnecessary for the multiple fields
input types, and we should call it when it is necessary. So, we
add InputType::attributeChange and text field input types call
updateInnerTextValue in it, and other input types don't.
Also, multiple fields input types need to call
updateInnerTextValue by 'value' attribute change. We add
InputType::valueAttributeChanged.

Tests: Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html. The
value attribute change behavior is covered by
time-multiple-fields-change-layout-by-value.html and
time-multiple-fields-spinbutton-change-and-input-events.html.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseAttribute):

Add a valueAttributeChanged call.
Calls InputType::attributeChanged
html/InputType.cpp:

(WebCore::InputType::attributeChanged): Added an empty implementation.
(WebCore::InputType::valueAttributeChanged): Ditto.

html/InputType.h:

(InputType): Declare attributeChanged and valueAttributeChanged.

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::attributeChanged):
Added. Always call updateInnerTextValue.

html/TextFieldInputType.h:

(TextFieldInputType): Declare attributeChanged.

html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::valueAttributeChanged):
Added. Re-construct shadow DOM tree if the input has no dirty value.

html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Declare valueAttributeChanged.

LayoutTests:

fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:

4:58 PM Changeset in webkit [146028] by rafaelw@chromium.org

6 edits in trunk

[HTMLTemplateElement] prevent </template> from matching "template" in a non-HTML tags on the stack of open elements
https://bugs.webkit.org/show_bug.cgi?id=112487

Reviewed by Adam Barth.

Source/WebCore:

When processing an end template tag, the parser now pops until a "template" tag is parsed, but now ensures that
the "template" it pops is in the HTML namespace.

Tests added to the html5lib test suite.

html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::popUntil):
(WebCore):
(WebCore::HTMLElementStack::popUntilPopped):

html/parser/HTMLElementStack.h:

(HTMLElementStack):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

html5lib/resources/template.dat:

4:06 PM Changeset in webkit [146027] by Simon Fraser

2 edits in trunk/LayoutTests

fast/frames/flattening/frameset-flattening-subframesets.html is flakey

platform/mac/TestExpectations:

2:40 PM Changeset in webkit [146026] by keishi@webkit.org

14 edits in trunk/LayoutTests

Add tests for calendar picker month popup
https://bugs.webkit.org/show_bug.cgi?id=112107

Adding tests to check if mouse and keyboard operations work on the month popup.

Reviewed by Kent Tamura.

platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/calendar-picker-mouse-operations.html:
platform/chromium/fast/forms/calendar-picker/month-picker-key-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/month-picker-key-operations.html:
platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/month-picker-mouse-operations.html:
platform/chromium/fast/forms/calendar-picker/resources/calendar-picker-common.js:

(clickMonthPopupButton): Clicks the month popup button to open the month popup.
(clickYearListCell): Clicks the year list cell for the given year to reveal the month buttons.
(hoverOverMonthButton): Moves the mouse over to the month button for the given month.
(clickMonthButton): Clicks the month button for the given month.
(checkYearListViewScrollOffset): Checks the year list view scroll offset and returns the difference from the last time it was called.

platform/chromium/fast/forms/calendar-picker/week-picker-key-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/week-picker-key-operations.html:
platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations-expected.txt:
platform/chromium/fast/forms/calendar-picker/week-picker-mouse-operations.html:

2:39 PM Changeset in webkit [146025] by abarth@webkit.org

16 edits
15 deletes in trunk

Legacy CSS vendor prefixes should only work for Dashboard
https://bugs.webkit.org/show_bug.cgi?id=111890

Reviewed by Eric Seidel.

Source/WebCore:

Our experience with the Chromium port is that these legacy CSS vendor
prefixes (-apple- and -khtml-) are not needed for web compatibility.
There is reason to believe, however, that they are needed for
compatibility with Mac OS X Dashboard widgets.

This patch makes the code for these legacy CSS vendor prefixes
enabled at runtime and only enables them when running in Dashboard
compatibility mode. This is the first step towards the plan outlined in
https://lists.webkit.org/pipermail/webkit-dev/2013-March/024085.html.

This patch also removes support for ENABLE(LEGACY_CSS_VENDOR_PREFIXES)
from the V8 bindings because V8 is never used with Dashboard.

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):

bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::getCSSPropertyNamePrefix):
(WebCore::cssPropertyIDForJSCSSPropertyName):

bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:

(WebCore::cssPropertyInfo):

css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiers):

Source/WebKit/mac:

Enable legacy CSS vendor prefixes when we've been asked to turn on
Dashboard compatibility mode.

WebView/WebView.mm:

(-[WebView _setDashboardBehavior:to:]):

LayoutTests:

inspector/styles/vendor-prefixes-expected.txt:
- Update results to show our new behavior now that -apple- and -khtml- are not supported.
platform/mac/TestExpectations:
- Skip a test that is testing that we support -apple- prefixes.
platform/mac/fast/css/dashboard-region-parser.html:
- Update test to use -webkit- rather than -apple-.

1:54 PM Changeset in webkit [146024] by Simon Fraser

2 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-navigation-allowed.html sometimes
asserts in debug.

platform/mac/TestExpectations:

1:09 PM Changeset in webkit [146023] by ddkilzer@apple.com

2 edits in trunk/Source/WebCore

BUILD FIX (r145592): AutodrainedPool.h moved to WTF
<http://webkit.org/b/112171>

Fixes the following build failure:

Source/WebCore/platform/audio/mac/AudioBusMac.mm:32:9: fatal error: 'AutodrainedPool.h' file not found
#import "AutodrainedPool.h"

1 error generated.

platform/audio/mac/AudioBusMac.mm: Fix include.

11:40 AM Changeset in webkit [146022] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding failure expectations for the two reftests added in r145982, failing due to disabled subpixel layout.
Triaging/enhancing failure expectations for spellcheck tests after r145940.

platform/gtk/TestExpectations:

11:15 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

11:13 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

11:13 AM Changeset in webkit [146021] by kov@webkit.org

6 edits in releases/WebKitGTK/webkit-2.0/Source

Merge 146017 - [GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

GNUmakefile.am: move translation-related rules and lists to the po directory's

GNUmakefile.am.

Source/WebCore/platform/gtk/po:

GNUmakefile.am: move dist-related rules here; also move translation-related files

to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

GNUmakefile.am: removed left-over translation files from EXTRA_DIST

11:12 AM Changeset in webkit [146020] by kov@webkit.org

2 edits in releases/WebKitGTK/webkit-2.0

Merge 144990 - Build fix. Fixes problems building code that uses deprecated functions from GTK+ 2,
such as RenderThemeGtk2.cpp, in debug mode. RenderThemeGtk2.cpp tries to allow usage
of deprecated functions by undefining GTK_DISABLE_DEPRECATED, but it ended up being
redefined because autotoolsconfig.h was included again by headers that came after
config.h.

Reviewed by Martin Robinson.

Source/autotools/SetupWebKitFeatures.m4: add checks to ensure the

autotoolsconfig.h header is only included once.

11:11 AM Changeset in webkit [146019] by commit-queue@webkit.org

2 edits in trunk/Tools

Add reload button (and F5 accelerator) to the GtkLauncher toolbar
https://bugs.webkit.org/show_bug.cgi?id=112442

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

GtkLauncher/main.c:

(reloadCb):
(createToolbar):
(createWindow):

11:11 AM Changeset in webkit [146018] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r146011 - [GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.

The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.

UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.

11:10 AM Changeset in webkit [146017] by kov@webkit.org

6 edits in trunk/Source

[GTK] Fix and improve dist hooks for translations
https://bugs.webkit.org/show_bug.cgi?id=112519

Reviewed by Carlos Garcia Campos.

Source/WebCore:

GNUmakefile.am: move translation-related rules and lists to the po directory's

GNUmakefile.am.

Source/WebCore/platform/gtk/po:

GNUmakefile.am: move dist-related rules here; also move translation-related files

to this file's EXTRA_DIST, making sure to only list the files we actually want
shipped, so junk such as .orig, .rej and backup files do not end up in the tarball.

Source/WebKit/gtk:

GNUmakefile.am: removed left-over translation files from EXTRA_DIST

11:06 AM Changeset in webkit [146016] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r146010 - [ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.

platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().

10:22 AM Changeset in webkit [146015] by Simon Fraser

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=97124
Mark a couple of WK2 tests as possibly asserting in debug.

platform/mac-wk2/TestExpectations:

10:14 AM Changeset in webkit [146014] by eae@chromium.org

3 edits in trunk/Source/WebCore

Move font-family applying code to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=112441

Reviewed by Allan Sandfeld Jensen.

Many of the font related properties were moved to StyleBuilder in r87362
two years ago. Move font-family as well so that all font properties are
handled the same way.

No new tests, no change in functionality.

css/StyleBuilder.cpp:

(ApplyPropertyFontFamily):
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontFamily::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
Add ApplyPropertyFontFamily for CSSPropertyFontFamily.

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Remove CSSPropertyFontFamily from the giant switch statement.

10:12 AM Changeset in webkit [146013] by danakj@chromium.org

2 edits in trunk/Source/Platform

[chromium] Remove the zoom filter operation ifdef
https://bugs.webkit.org/show_bug.cgi?id=112390

Reviewed by Darin Fisher.

This ifdef is not needed once the change that introduced it is
rolled into chromium, and the chromium side guards on the ifdef
are removed. Then it just does nothing and should be deleted.

chromium/public/WebFilterOperation.h:

10:12 AM Changeset in webkit [146012] by abarth@webkit.org

1 edit in branches/chromium/1441/Source/WebCore/rendering/RenderLayer.cpp

Revert 143825 "RenderLayer::scrollTo() should call FrameLoaderCl..."

RenderLayer::scrollTo() should call FrameLoaderClient::didChangeScrollOffset()
https://bugs.webkit.org/show_bug.cgi?id=110673
-and corresponding-
<rdar://problem/13258596>

Reviewed by Sam Weinig.

FrameLoaderClient::didChangeScrollOffset() doesn't get called for web pages that
have overflow on the body. We can easily address this by calling it at the
end of RenderLayer::scrollTo().

rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollTo):

TBR=Beth Dakin
Review URL: https://codereview.chromium.org/12851007

9:49 AM Changeset in webkit [146011] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Invalid charset encoding using when substituting a misspelled word in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112517

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Alexey Proskuryakov.

The problem is that we are creating the WebContextMenuItemData
with the GtkAction label as UTF-8.

UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::contextMenuItemActivatedCallback): Use String::fromUTF8()
to convert the GtkAction label to UTF-16.

9:25 AM Changeset in webkit [146010] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[ENCHANT] Invalid charset encoding used for spelling guess context menu items
https://bugs.webkit.org/show_bug.cgi?id=112516

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-17
Reviewed by Gustavo Noronha Silva.

Convert spelling guesses returned by enchant to UTF-16 before
passing them to WebCore.

platform/text/enchant/TextCheckerEnchant.cpp:

(WebCore::TextCheckerEnchant::getGuessesForWord): Use
String::fromUTF8().

9:21 AM Changeset in webkit [146009] by Simon Fraser

2 edits in trunk/LayoutTests

Mark some more tests as asserting in debug, because of
https://bugs.webkit.org/show_bug.cgi?id=105986

platform/mac/TestExpectations:

9:11 AM Changeset in webkit [146008] by Simon Fraser

2 edits in trunk/LayoutTests

Occasional assertion in JSNPObject::invalidate() running plugins/object-embed-plugin-scripting.html
https://bugs.webkit.org/show_bug.cgi?id=112518

Mark this test as [ Crash Pass ] in debug.

platform/mac/TestExpectations:

9:09 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

9:09 AM WebKitGTK/2.0.x edited by kov@webkit.org

(diff)

7:35 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:44 AM Changeset in webkit [146007] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebCore

[EFL] Provide default cursor groups as cursor.edc
https://bugs.webkit.org/show_bug.cgi?id=112403

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-17
Reviewed by Gyuyoung Kim.

This patch provides a cursor.edc to use the CSS cursor images files in the
WebCore/Resources directory. cursor.edc is included in the default.edc
so that views can use it by default.

platform/efl/DefaultTheme/CMakeLists.txt:
platform/efl/DefaultTheme/default.edc:
platform/efl/DefaultTheme/widget/cursor/cursor.edc: Added.

2:17 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

Mar 16, 2013:

11:46 PM Changeset in webkit [146006] by psolanki@apple.com

8 edits in trunk/Source

Disable High DPI Canvas on iOS
https://bugs.webkit.org/show_bug.cgi?id=112511

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

10:26 PM Changeset in webkit [146005] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r145898.
http://trac.webkit.org/changeset/145898
https://bugs.webkit.org/show_bug.cgi?id=112512

Causing flakiness on webkit_unit_tests on android bots on
chromium.webkit and chromium.linux (Requested by jochen on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-16

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:

(WebViewImpl):

tests/WebFrameTest.cpp:
tests/WebViewTest.cpp:

2:26 PM Changeset in webkit [146004] by Simon Fraser

2 edits in trunk/LayoutTests

http/tests/notifications/legacy/window-show-on-click.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

platform/mac/TestExpectations:

1:47 PM Changeset in webkit [146003] by hans@chromium.org

2 edits in trunk/Source/WebKit/chromium

Remove redundant checks from WebInputEvent::isGestureEventType
https://bugs.webkit.org/show_bug.cgi?id=112503

Reviewed by Darin Fisher.

GesturePinchBegin, GesturePinchEnd and GesturePinchUpdate were checked
for twice.

This was found by experimenting with a potential new Clang warning.

public/WebInputEvent.h:

(WebKit::WebInputEvent::isGestureEventType):

12:43 PM Changeset in webkit [146002] by Simon Fraser

2 edits in trunk/LayoutTests

inspector/elements/highlight-node-scaled.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=112502

Mark this test as flakey.

platform/mac/TestExpectations:

12:32 PM Changeset in webkit [146001] by Simon Fraser

2 edits in trunk/Source/WebCore

Reflected video elements hit assertion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable reflections on video again, since there's some bad behavior
caused by an underlying system framework.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

12:20 PM Changeset in webkit [146000] by Simon Fraser

2 edits in trunk/LayoutTests

svg/batik/paints/gradientLimit.svg is flakey. Also fix
a couple of recent typos in TestExpectations.

platform/mac/TestExpectations:

12:10 PM Changeset in webkit [145999] by Simon Fraser

2 edits in trunk/LayoutTests

Notification test is flakey
https://bugs.webkit.org/show_bug.cgi?id=112499

platform/mac/TestExpectations:

12:10 PM Changeset in webkit [145998] by Simon Fraser

2 edits in trunk/LayoutTests

Another slow sputnik test.

platform/mac/TestExpectations:

11:19 AM Changeset in webkit [145997] by Simon Fraser

2 edits in trunk/LayoutTests

Fix typos. Also mark fast/frames/flattening/frameset-flattening-advanced.html
as flakey.

platform/mac/TestExpectations:

11:00 AM Changeset in webkit [145996] by Simon Fraser

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=93560

These WebGL tests are flakey on Lion too.

platform/mac-lion/TestExpectations:

10:56 AM Changeset in webkit [145995] by Simon Fraser

2 edits in trunk/LayoutTests

Change fast/events/controlclick-no-onclick.html to be a skip rather than a fail,
since it times out.

platform/mac-wk2/TestExpectations:

10:08 AM Changeset in webkit [145994] by tsepez@chromium.org

3 edits
2 adds in trunk

[v8] Disable binding integrity check for WebCore::Text
https://bugs.webkit.org/show_bug.cgi?id=112462

Reviewed by Kentaro Hara.

Source/WebCore:

Test: fast/dom/split-cdata.xml

dom/Text.idl:

LayoutTests:

fast/dom/split-cdata-expected.txt: Added.
fast/dom/split-cdata.xml: Added.

9:43 AM Changeset in webkit [145993] by mkwst@chromium.org

2 edits
10 adds
2 deletes in trunk/LayoutTests

fast/frames/sandboxed-iframe-scripting is flakey
https://bugs.webkit.org/show_bug.cgi?id=112482

Reviewed by Simon Fraser.

Tests that rely on multiple 'iframe' elements loading in a specific
order are a Bad Idea™. This patch splits
'fast/frames/sandboxed-iframe-scripting.html' out into five tests, and
changes two of them (#2 and #4) to use message passing in order to
test in a way that 'js-test-{pre,post}' can cleanly report.

fast/frames/sandboxed-iframe-scripting-01-expected.txt: Added.
fast/frames/sandboxed-iframe-scripting-01.html: Added.
fast/frames/sandboxed-iframe-scripting-02-expected.txt: Added.
fast/frames/sandboxed-iframe-scripting-02.html: Added.
fast/frames/sandboxed-iframe-scripting-03-expected.txt: Added.
fast/frames/sandboxed-iframe-scripting-03.html: Added.
fast/frames/sandboxed-iframe-scripting-04-expected.txt: Added.
fast/frames/sandboxed-iframe-scripting-04.html: Added.
fast/frames/sandboxed-iframe-scripting-05-expected.txt: Added.
fast/frames/sandboxed-iframe-scripting-05.html: Added.
fast/frames/sandboxed-iframe-scripting-expected.txt: Removed.
fast/frames/sandboxed-iframe-scripting.html: Removed.
platform/mac/TestExpectations:

Remove the skipped test, since it no longer exists.

9:41 AM Changeset in webkit [145992] by jochen@chromium.org

2 edits in trunk/LayoutTests

Update test expectations for content shell.

Unreviewed gardening.

platform/chromium/ContentShellTestExpectations:

8:50 AM Changeset in webkit [145991] by Simon Fraser

2 edits in trunk/LayoutTests

Mark some ref tests as failing on Lion.

platform/mac-lion/TestExpectations:

8:45 AM Changeset in webkit [145990] by Simon Fraser

2 edits in trunk/LayoutTests

Mark some more sputnik tests as slow in debug.

platform/mac/TestExpectations:

7:26 AM BadContent edited by zandobersek@gmail.com

Blacklist a spamming account. (diff)

4:21 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:18 AM Changeset in webkit [145989] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145808 - [GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::stop):

1:51 AM Changeset in webkit [145988] by Chris Fleizach

27 edits
2 adds in trunk

AX: aria-hidden on container does not hide descendant popup buttons
https://bugs.webkit.org/show_bug.cgi?id=112373

Reviewed by Ryosuke Niwa.

Source/WebCore:

There are a number of subclass AX objects that implement accessibilityIsIgnored()
to always return false. This means that even if their parent is aria-hidden=true
they still show up in the tree.

This re-organizes this base case of aria-hidden into AccessibilityObject so that
it can be re-used by these special subclasses where appropriate.

Test: accessibility/aria-hidden-hides-all-elements.html

accessibility/AccessibilityImageMapLink.h:

(WebCore::AccessibilityImageMapLink::isImageMapLink):

accessibility/AccessibilityList.cpp:

(WebCore::AccessibilityList::computeAccessibilityIsIgnored):

accessibility/AccessibilityListBox.cpp:

(WebCore):

accessibility/AccessibilityListBox.h:

(AccessibilityListBox):

accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):

accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):

accessibility/AccessibilityMediaControls.h:

(AccessibilityMediaControlsContainer):

accessibility/AccessibilityMenuList.h:

(WebCore::AccessibilityMenuList::roleValue):

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):

accessibility/AccessibilityMockObject.cpp:

(WebCore::AccessibilityMockObject::computeAccessibilityIsIgnored):
(WebCore):

accessibility/AccessibilityMockObject.h:

(AccessibilityMockObject):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibilityIsIgnoredDefaultForObject):
(WebCore):
(WebCore::AccessibilityObject::ariaIsHidden):
(WebCore::AccessibilityObject::accessibilityIsIgnoredBase):

accessibility/AccessibilityObject.h:

(AccessibilityObject):

accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):

accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnoredBase):
(WebCore::AccessibilityRenderObject::addImageMapChildren):

accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

accessibility/AccessibilityScrollbar.h:

(AccessibilityScrollbar):

accessibility/AccessibilitySlider.cpp:

(WebCore):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):

accessibility/AccessibilitySlider.h:

(AccessibilitySlider):

accessibility/AccessibilitySpinButton.h:

(WebCore::AccessibilitySpinButton::roleValue):
(AccessibilitySpinButtonPart):

LayoutTests:

accessibility/aria-hidden-hides-all-elements-expected.txt: Added.
accessibility/aria-hidden-hides-all-elements.html: Added.

12:43 AM Changeset in webkit [145987] by rniwa@webkit.org

1 edit
4 adds
1 delete in trunk/LayoutTests

Mac rebaseline after r145977.

platform/chromium-mac/platform/mac/fast: Added.
platform/chromium-mac/platform/mac/fast/forms: Added.
platform/chromium-mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.
platform/chromium/platform/mac/fast/forms: Removed.
platform/chromium/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.
platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Added.

Mar 15, 2013:

11:16 PM Changeset in webkit [145986] by Simon Fraser

2 edits in trunk/LayoutTests

Mark two media/track tests as flakey. Tracked by webkit.org/b/112492

platform/mac/TestExpectations:

10:58 PM Changeset in webkit [145985] by Simon Fraser

1 edit
1 delete in trunk/LayoutTests

Remove result in platform/mac/platform/mac

platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt: Removed.

10:06 PM Changeset in webkit [145984] by Simon Fraser

2 edits in trunk/LayoutTests

Fix typo in TestExpectations file.

platform/mac/TestExpectations:

9:56 PM Changeset in webkit [145983] by Simon Fraser

2 edits in trunk/Source/WebCore

Reflected video elements hit assertion on Lion
https://bugs.webkit.org/show_bug.cgi?id=112490

Disable the new reflected video functionality added in r145915
on Lion because of a nasty re-entrancy problem. Tracked by bug 112490.

platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::clone):

9:40 PM Changeset in webkit [145982] by commit-queue@webkit.org

4 edits
4 adds in trunk

[CSS Exclusions] shape-outside on floats for circle and ellipse shapes
https://bugs.webkit.org/show_bug.cgi?id=98673

Source/WebCore:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Enable circles and ellipses for shape-outside on floats. Most of the
code already supports them, just needed to turn them on and add tests.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html

rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable circles and

ellipses. Also add a check for if the RenderBox is floating, since
that test should have been there all along, as shape outside is
only supported on floats for now.

LayoutTests:

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-15
Reviewed by Dirk Schulze.

Tests for circles and ellipses on floats.

fast/exclusions/resources/rounded-rectangle.js:

(defined): Helper function to test and see if a js value is defined.
(convertToRoundedRect): Convert a circle or ellipse dimensions to a rounded rect.
(generateShapeOutsideOnFloat): Add ability to generate circles and

ellipses, since they are just special cases of rounded rectangles.

(generateSimulatedShapeOutsideOnFloat): Add ability to simulate

circles and ellipses, by treating them as rounded rectangles. Also
fix minor style issue with an if statement.

(xOutset): Remove unneeded condition in if statement.

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle-expected.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-circle.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse-expected.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-ellipse.html: Added.

9:37 PM Changeset in webkit [145981] by Simon Fraser

2 edits in trunk/Tools

REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
https://bugs.webkit.org/show_bug.cgi?id=112205

Disable this API test until Geoff can fix it.

TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:

(TestWebKitAPI::TEST):

8:49 PM Changeset in webkit [145980] by Simon Fraser

2 edits in trunk/LayoutTests

Rebaseline after r145977.

platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:

8:47 PM Changeset in webkit [145979] by Simon Fraser

2 edits in trunk/LayoutTests

Rebaseline after r145977.

platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:

8:25 PM Changeset in webkit [145978] by kbr@google.com

13 edits in trunk/LayoutTests

Unreviewed new baselines after r145977.
https://bugs.webkit.org/show_bug.cgi?id=110837

platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:

7:27 PM Changeset in webkit [145977] by commit-queue@webkit.org

159 edits in trunk

Convert old flexbox uses in html.css to new flexbox (non-<select>)
https://bugs.webkit.org/show_bug.cgi?id=110837

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Source/WebCore:

Covered by existing tests.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
After we set our descendants' heights, we need to mark them for
layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox style setters.

css/html.css:

(input::-webkit-textfield-decoration-container):
(input[type="search"]::-webkit-search-cancel-button):
(input[type="search"]::-webkit-search-decoration):
(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
(input::-webkit-inner-spin-button):
(input::-webkit-input-speech-button):
(textarea):
(input[type="file"]):
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-text-block):

css/themeWin.css:

(input[type="search"]::-webkit-search-results-decoration):
(input[type="search"]::-webkit-search-results-button):
Convert -webkit-box to -webkit-flex and adjust related properties.
Notably switch to auto margins for centering the speech button as well
as the search result and cancel buttons to stay compatible with the
previous centering behaviour. This does not produce visible
differences but eliminates the render tree dump changes.

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):

html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::TextControlInnerContainer):
(WebCore):
(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerContainer::createRenderer):

html/shadow/TextControlInnerElements.h:

(TextControlInnerContainer):
(WebCore):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControlInnerContainer::RenderTextControlInnerContainer):
(WebCore):
(WebCore::RenderTextControlInnerContainer::~RenderTextControlInnerContainer):

rendering/RenderTextControl.h:

(WebCore):
(RenderTextControlInnerContainer):
Create a new DOM element & renderer type for the textfield-decoration
div (the direct child of the <input> in the shadow dom if we have a
special input field). This is necessary because new-flexbox uses a
different algorithm for calculating the baseline, which would
otherwise cause an <input> and an <input type=search> to not be
aligned with each other.
The new renderer just calls back to RenderBlock for calculating the
baseline.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):
Make sure to mark renderers as needing layout when we change their
style. This didn't use to be necessary because old-flexbox relayouts
children even when they are not marked for needing layout.
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
Use new-flexbox CSS properties.

html/shadow/TextFieldDecorationElement.cpp:

(WebCore::TextFieldDecorationElement::decorate):
Use new-flexbox CSS properties.

LayoutTests:

fast/forms/placeholder-position-expected.txt:
platform/chromium-linux/fast/css/input-search-padding-expected.txt:
platform/chromium-linux/fast/forms/box-shadow-override-expected.txt:
platform/chromium-linux/fast/forms/control-restrict-line-height-expected.txt:
platform/chromium-linux/fast/forms/input-appearance-height-expected.txt:
platform/chromium-linux/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/chromium-linux/fast/forms/search-styled-expected.txt:
platform/chromium-linux/fast/forms/searchfield-heights-expected.txt:
platform/chromium-linux/fast/forms/validation-message-appearance-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium-mac-lion/fast/forms/search-rtl-expected.txt:
platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.txt:
platform/chromium-mac-snowleopard/fast/repaint/search-field-cancel-expected.txt:
platform/chromium-mac/fast/css/text-overflow-input-expected.txt:
platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
platform/chromium-mac/fast/forms/control-restrict-line-height-expected.txt:
platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
platform/chromium-mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
platform/chromium-mac/fast/forms/search-rtl-expected.txt:
platform/chromium-mac/fast/forms/search-vertical-alignment-expected.txt:
platform/chromium-mac/fast/forms/searchfield-heights-expected.txt:
platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium-win-xp/fast/forms/search-styled-expected.txt:
platform/chromium-win/fast/css/input-search-padding-expected.txt:
platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/chromium-win/fast/css/text-overflow-input-expected.txt:
platform/chromium-win/fast/forms/box-shadow-override-expected.txt:
platform/chromium-win/fast/forms/control-restrict-line-height-expected.txt:
platform/chromium-win/fast/forms/input-appearance-height-expected.txt:
platform/chromium-win/fast/forms/number/number-appearance-rtl-expected.txt:
platform/chromium-win/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/chromium-win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/chromium-win/fast/forms/placeholder-position-expected.txt:
platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.txt:
platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.txt:
platform/chromium-win/fast/forms/search-rtl-expected.txt:
platform/chromium-win/fast/forms/search-styled-expected.txt:
platform/chromium-win/fast/forms/search-vertical-alignment-expected.txt:
platform/chromium-win/fast/forms/searchfield-heights-expected.txt:
platform/chromium-win/fast/forms/validation-message-appearance-expected.txt:
platform/chromium-win/fast/repaint/search-field-cancel-expected.txt:
platform/chromium-win/fast/replaced/width100percent-searchfield-expected.txt:
platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt:
platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt:
platform/chromium-win/fast/speech/speech-bidi-rendering-expected.txt:
platform/chromium/fast/css/input-search-padding-expected.txt:
platform/chromium/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/chromium/fast/forms/number/number-appearance-rtl-expected.txt:
platform/chromium/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/chromium/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/chromium/fast/forms/search-display-none-cancel-button-expected.txt:
platform/chromium/fast/forms/search-rtl-expected.txt:
platform/chromium/fast/forms/search-styled-expected.txt:
platform/chromium/fast/repaint/search-field-cancel-expected.txt:
platform/chromium/fast/replaced/width100percent-searchfield-expected.txt:
platform/chromium/fast/speech/speech-bidi-rendering-expected.txt:
platform/efl/fast/css/input-search-padding-expected.txt:
platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/efl/fast/css/text-overflow-input-expected.txt:
platform/efl/fast/forms/box-shadow-override-expected.txt:
platform/efl/fast/forms/control-restrict-line-height-expected.txt:
platform/efl/fast/forms/input-appearance-height-expected.txt:
platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/efl/fast/forms/placeholder-position-expected.txt:
platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/efl/fast/forms/search-display-none-cancel-button-expected.txt:
platform/efl/fast/forms/search-rtl-expected.txt:
platform/efl/fast/forms/search-styled-expected.txt:
platform/efl/fast/forms/search-vertical-alignment-expected.txt:
platform/efl/fast/forms/searchfield-heights-expected.txt:
platform/efl/fast/forms/validation-message-appearance-expected.txt:
platform/efl/fast/repaint/search-field-cancel-expected.txt:
platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
platform/gtk/fast/css/input-search-padding-expected.txt:
platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/gtk/fast/css/text-overflow-input-expected.txt:
platform/gtk/fast/forms/box-shadow-override-expected.txt:
platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
platform/gtk/fast/forms/input-appearance-height-expected.txt:
platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/gtk/fast/forms/placeholder-position-expected.txt:
platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
platform/gtk/fast/forms/search-rtl-expected.txt:
platform/gtk/fast/forms/search-styled-expected.txt:
platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
platform/gtk/fast/forms/searchfield-heights-expected.txt:
platform/gtk/fast/forms/validation-message-appearance-expected.txt:
platform/gtk/fast/repaint/search-field-cancel-expected.txt:
platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
platform/gtk/fast/speech/input-appearance-searchandspeech-expected.txt:
platform/mac/fast/css/input-search-padding-expected.txt:
platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/mac/fast/css/text-overflow-input-expected.txt:
platform/mac/fast/forms/box-shadow-override-expected.txt:
platform/mac/fast/forms/control-restrict-line-height-expected.txt:
platform/mac/fast/forms/input-appearance-height-expected.txt:
platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
platform/mac/fast/forms/search-rtl-expected.txt:
platform/mac/fast/forms/search-styled-expected.txt:
platform/mac/fast/forms/search-vertical-alignment-expected.txt:
platform/mac/fast/forms/searchfield-heights-expected.txt:
platform/mac/fast/forms/validation-message-appearance-expected.txt:
platform/mac/fast/repaint/search-field-cancel-expected.txt:
platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
platform/qt-5.0/fast/forms/placeholder-pseudo-style-expected.txt:
platform/qt/fast/css/input-search-padding-expected.txt:
platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
platform/qt/fast/css/text-overflow-input-expected.txt:
platform/qt/fast/forms/box-shadow-override-expected.txt:
platform/qt/fast/forms/control-restrict-line-height-expected.txt:
platform/qt/fast/forms/number/number-appearance-rtl-expected.txt:
platform/qt/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
platform/qt/fast/forms/placeholder-position-expected.txt:
platform/qt/fast/forms/placeholder-pseudo-style-expected.txt:
platform/qt/fast/forms/search-cancel-button-style-sharing-expected.txt:
platform/qt/fast/forms/search-display-none-cancel-button-expected.txt:
platform/qt/fast/forms/search-rtl-expected.txt:
platform/qt/fast/forms/search-styled-expected.txt:
platform/qt/fast/forms/search-vertical-alignment-expected.txt:
platform/qt/fast/repaint/search-field-cancel-expected.txt:
platform/qt/fast/replaced/width100percent-searchfield-expected.txt:
platform/qt/fast/speech/input-appearance-searchandspeech-expected.txt:

Automated search & replace of RenderDeprecatedFlexibleBox ->
RenderFlexibleBox

platform/mac/fast/forms/color/input-appearance-color-expected.txt:
platform/chromium-mac/fast/forms/color/input-appearance-color-expected.txt:
platform/chromium-win/fast/forms/color/input-appearance-color-expected.txt:
platform/chromium-linux/fast/forms/color/input-appearance-color-expected.png:

This test shows a minor layout difference (less spacing between
paragraphs with an <input type=color>). The underlying reason is
alignment/baseline-differences with the new flexbox code, and the new
behaviour makes more sense in general (this becomes obvious when
putting text or a <input type=text> next to an <input type=color>).

platform/chromium/TestExpectations:

Mark input-appearance-color as needing rebaseline on Mac/Win. All
non-Chromium ports ignore fast/forms/color because the feature isn't
enabled, so their TestExpectations need no update.

7:22 PM Changeset in webkit [145976] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188504. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

DEPS:

7:13 PM Changeset in webkit [145975] by kbr@google.com

2 edits in trunk/Source/WebCore

Unreviewed attempted build fix for Chromium Windows after r145929.
Verified this fix builds and works on Linux.
https://bugs.webkit.org/show_bug.cgi?id=96798

bindings/v8/V8Binding.cpp:

(WebCore):

6:22 PM Changeset in webkit [145974] by Simon Fraser

3 edits
2 adds in trunk/LayoutTests

Added some expected results that should be the same across platforms.
Removed some tests needing rebaseline from Mac TestExpectations.

compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.txt: Added.
compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer-expected.txt: Added.
platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

6:20 PM Changeset in webkit [145973] by Nate Chapin

5 edits in trunk/Source/WebCore

Merge MainResourceLoader::willSendRequest into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109757

This is one of the steps to merging MainResourceLoader entirely into
DocumentLoader, given the lack of clear division of responsibility
between the two.

Reviewed by Antti Koivisto.

No new tests, refactor only.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceData):
(WebCore::DocumentLoader::isPostOrRedirectAfterPost):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::callContinueAfterNavigationPolicy):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):

loader/DocumentLoader.h:
loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData):
(WebCore::MainResourceLoader::redirectReceived):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::reportMemoryUsage):
(WebCore::MainResourceLoader::handleSubstituteDataLoadNow):
(WebCore::MainResourceLoader::load):

loader/MainResourceLoader.h:

(WebCore::MainResourceLoader::takeIdentifierFromResourceLoader): Temporarily

exposed for moving from a normal load to SubstituteData load on redirect.

6:11 PM Changeset in webkit [145972] by zmo@google.com

2 edits in trunk/Source/WebCore

Disable EXT_draw_buffers WebGL extension on Mac
https://bugs.webkit.org/show_bug.cgi?id=112486

Reviewed by Kenneth Russell.

html/canvas/EXTDrawBuffers.cpp:

(WebCore::EXTDrawBuffers::supported):

5:54 PM Changeset in webkit [145971] by kbr@google.com

1 edit
6 adds in trunk/LayoutTests

Unreviewed addition of expectations for test added in r145915.

platform/chromium-mac-lion/compositing/video/video-reflection-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
platform/chromium-mac/compositing/video/video-reflection-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.
platform/chromium-win/compositing/video/video-reflection-expected.png: Added.
platform/chromium-win/platform/chromium/virtual/softwarecompositing/video/video-reflection-expected.png: Added.

5:43 PM Changeset in webkit [145970] by danakj@chromium.org

5 edits
9 deletes in trunk

[chromium] Remove the background filter blur layout tests
https://bugs.webkit.org/show_bug.cgi?id=112372

Reviewed by James Robinson.

Source/WebCore:

Remove the now-unused hacks to regression test the background
filter blur compositor feature.

testing/Internals.cpp:
testing/Internals.h:

(Internals):

testing/Internals.idl:

LayoutTests:

Given that we now have the ability to write pixel tests directly against
the compositor, these tests are no longer needed to guard against
regressions, and have been duplicated for the compositor as pixel tests
in https://codereview.chromium.org/12518026/ and
https://codereview.chromium.org/12518026/.

platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
platform/chromium/compositing/filters/background-filter-blur.html: Removed.

5:37 PM Changeset in webkit [145969] by Simon Fraser

2 edits in trunk/LayoutTests

Mark fast/frames/sandboxed-iframe-scripting as flakey.

webkit.org/b/104848 supposedly fixed fast/frames/sandboxed-iframe-parsing-space-characters.html,
so remove it.

platform/mac/TestExpectations:

5:36 PM Changeset in webkit [145968] by anilsson@rim.com

16 edits in trunk/Source/WebKit/blackberry

[BlackBerry] BlackBerry::Platform::Graphics::GraphicsContext integration related changes in Source/WebKit/blackberry
https://bugs.webkit.org/show_bug.cgi?id=112467

Reviewed by Rob Buis.

PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Mike Lattanzio
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Filip Spacek

Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
(BlackBerry::WebKit::BackingStorePrivate::tileSize):

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayPrivate::drawContents):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::paintContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToImage):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::clearUploadedContents):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::setContentsToColor):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::removeFromParent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):

Api/WebOverlay.h:
Api/WebOverlayClient.h:
Api/WebOverlay_p.h:

(WebOverlayPrivate):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showDebugBorders):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::showRepaintCounter):
(WebOverlayLayerCompositingThreadClient):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::image):
(WebOverlayPrivateCompositingThread):

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):

WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::~TileBuffer):
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
(BlackBerry::WebKit::TileBuffer::paintBackground):

WebKitSupport/DefaultTapHighlight.cpp:

(BlackBerry::WebKit::DefaultTapHighlight::paintContents):
(BlackBerry::WebKit::DefaultTapHighlight::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::showRepaintCounter):

WebKitSupport/DefaultTapHighlight.h:

(DefaultTapHighlight):

WebKitSupport/InspectorOverlayBlackBerry.cpp:

(BlackBerry::WebKit::InspectorOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::InspectorOverlay::showRepaintCounter):

WebKitSupport/InspectorOverlayBlackBerry.h:

(InspectorOverlay):

WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::draw):
(BlackBerry::WebKit::SelectionOverlay::hide):
(BlackBerry::WebKit::SelectionOverlay::paintContents):
(BlackBerry::WebKit::SelectionOverlay::showDebugBorders):
(WebKit):
(BlackBerry::WebKit::SelectionOverlay::showRepaintCounter):

WebKitSupport/SelectionOverlay.h:

(SelectionOverlay):

WebKitSupport/SurfacePool.cpp:

(BlackBerry::WebKit::SurfacePool::createPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::destroyPlatformGraphicsContext):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
(BlackBerry::WebKit::SurfacePool::destroyPlatformSync):

WebKitSupport/SurfacePool.h:

5:20 PM Changeset in webkit [145967] by jochen@chromium.org

7 edits
1 delete in trunk

plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
https://bugs.webkit.org/show_bug.cgi?id=112478

Reviewed by Tony Chang.

There is nothing that ensures that the log messages from the plugin
come in before the layout test finished loading.

Tools:

DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:

(PassDifferentNPPStruct::NPP_SetWindow):

DumpRenderTree/TestNetscapePlugIn/main.cpp:

(NPP_SetWindow):

LayoutTests:

platform/mac-wk2/plugins/netscape-plugin-setwindow-size-2-expected.txt: Removed.
plugins/netscape-plugin-setwindow-size-2.html:
plugins/netscape-plugin-setwindow-size.html:
plugins/pass-different-npp-struct.html:

4:52 PM Changeset in webkit [145966] by Simon Fraser

2 edits in trunk/LayoutTests

Mark some more sputnik tests as slow in debug.

platform/mac/TestExpectations:

4:40 PM Changeset in webkit [145965] by ap@apple.com

4 edits in trunk/Source/WebCore

Reduce amount of platform specific code in MessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=112469

Reviewed by Sam Weinig.

dom/MessagePortChannel.h: Ifdefed out an unused channel() function, except for Chromium, where it is used. We certainly don't want to expose this implementation detail as a public function.

dom/default/PlatformMessagePortChannel.h: Removed functions that are no longer delegated. Made class contents all public, as it's now basically a data storage for MessagePortChannel.

dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::~MessagePortChannel): (WebCore::MessagePortChannel::entangleIfOpen): (WebCore::MessagePortChannel::disentangle): (WebCore::MessagePortChannel::postMessageToRemote): (WebCore::MessagePortChannel::tryGetMessageFromRemote): (WebCore::MessagePortChannel::close): (WebCore::MessagePortChannel::isConnectedTo): (WebCore::MessagePortChannel::hasPendingActivity): (WebCore::MessagePortChannel::locallyEntangledPort): (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel): (WebCore::PlatformMessagePortChannel::entangledChannel): Moved code from PlatformMessagePortChannel to MessagePortChannel. Added some FIXMEs.

4:36 PM Changeset in webkit [145964] by Simon Fraser

2 edits in trunk/LayoutTests

New baseline for this test on Lion.

platform/mac-lion/platform/mac/fast/text/vertical-no-sideways-expected.txt:

4:30 PM Changeset in webkit [145963] by timothy@apple.com

4 edits in trunk/Source

Disable suppressesIncrementalRendering for the Web Inspector.

This ends up causing the Inspector to show blank for a couple seconds before
it does its first paint. During that time the bare window chrome is showing
when the Inspector's background and other simple elements count be painting.
This causes the Inspector to look like it is loading slower than reality.

Source/WebKit/mac:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController init]): Disable suppressesIncrementalRendering.

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

UIProcess/WebInspectorProxy.cpp:

(WebKit::createInspectorPageGroup): Disable suppressesIncrementalRendering.

4:30 PM Changeset in webkit [145962] by anilsson@rim.com

6 edits in trunk/Source

[BlackBerry] Expose the compositing thread layer's draw rectangle to aid hit testing
https://bugs.webkit.org/show_bug.cgi?id=112255

Reviewed by Rob Buis.

PR 308284.
Reviewed internally by Yongxin Dai.

Source/WebCore:

Add a getter for the layer renderer of a compositing thread layer.

No change in behavior, no new tests.

platform/graphics/blackberry/LayerCompositingThread.h:

(WebCore::LayerCompositingThread::layerRenderer):

Source/WebKit/blackberry:

The cached draw rectangle is useful for hit testing. Add a getter for
this compositing thread layer property to the public WebOverlay API.
We name this getter using terminology familiar from the
ViewportAccessor interface, to clarify which coordinate system the
getter uses (pixel coordinates relative to the viewport).

Note that WebKit-thread flavor of WebOverlay is not currently used by
any API client and is marked obsolete. It is used internally in WebKit,
but for that case using GraphicsLayer directly works well. This will
allow the complexity of WebOverlay to be significantly reduced in the
future, by removing the WebKit-thread flavor entirely.

Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlay::pixelViewportRect):
(WebKit):
(BlackBerry::WebKit::WebOverlayPrivateWebKitThread::pixelViewportRect):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):

Api/WebOverlay.h:

(WebKit):

Api/WebOverlay_p.h:

(WebOverlayPrivate):
(WebOverlayPrivateWebKitThread):
(WebOverlayPrivateCompositingThread):

4:29 PM Changeset in webkit [145961] by timothy@apple.com

6 edits in trunk/Source/WebKit2

Delay creating the Inspector window so we don't cause a CoreIPC deadlock.

Other changes include:

Create the Inspector WKView at the correct size so it does not need to resize later when added to the window.
Update the minimum and initial window sizes to better match the new UI.
Store the Inspector window frame in WebKit preferences so each page group can have different saved window frames. Handy for inspecting the Inspector.

https://bugs.webkit.org/show_bug.cgi?id=112300
rdar://problem/13412219

Reviewed by Geoff Garen.

Shared/WebPreferencesStore.cpp:

(WebKit::defaultValueForKey):
Added FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE.

Shared/WebPreferencesStore.h:

(FOR_EACH_WEBKIT_STRING_PREFERENCE_NOT_IN_WEBCORE):
Added. Needed to keep WebPage::updatePreferences for trying to set WebCore::Settings.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::minimumWindowWidth):
(WebKit::WebInspectorProxy::initialWindowWidth):
Bumped the values to work better with the new UI.

UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added.

UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter windowDidMove:]):
(-[WKWebInspectorProxyObjCAdapter windowDidResize:]):
Call WebInspectorProxy::windowFrameDidChange.

(WebKit::WebInspectorProxy::createInspectorWindow):
Use the preferences for the page group to get the window frame.

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Stop calling platformAttach or createInspectorWindow, do it in platformOpen.

(WebKit::WebInspectorProxy::platformOpen):
Call platformAttach or createInspectorWindow here instead.

(WebKit::WebInspectorProxy::windowFrameDidChange):
Added. Store the frame in the page group's preferences.

(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
Remove code that called setHidden:. We don't need to do that anymore.

4:18 PM Changeset in webkit [145960] by Lucas Forschler

2 edits in tags/Safari-537.34/Source/WebCore

Merged r145958. <rdar://problem/13434350>

4:14 PM Changeset in webkit [145959] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

Convert <select> to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112395

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

Covered by existing tests.

css/html.css:

(select):
(select[size][multiple]):
(select[size="1"]):
Use new-style flexbox properties.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::createInnerBlock):
(WebCore::RenderMenuList::adjustInnerStyle):
(WebCore::RenderMenuList::removeChild):
RenderDeprecatedFlexibleBox -> RenderFlexibleBox, and use the
new-style flexbox properties. Use margin:auto for centering to get
the old safe-centering behavior.

rendering/RenderMenuList.h:

(RenderMenuList):
Inherit from RenderFlexibleBox. Override baseline methods to call the
RenderBlock methods

4:11 PM Changeset in webkit [145958] by aestes@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r145820): Stop over-retaining CFDataRefs in SharedBuffer::maybeTransferPlatformData()
https://bugs.webkit.org/show_bug.cgi?id=112474

Reviewed by Simon Fraser.

Transfer ownership of m_cfData to the local variable rather than leaking a reference.

platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

4:01 PM Changeset in webkit [145957] by fsamuel@chromium.org

3 edits in trunk/Source/WebKit/chromium

[Chromium] Focus Plugin on TouchStart
https://bugs.webkit.org/show_bug.cgi?id=112385

Reviewed by Adam Barth.

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleMouseEvent):

src/WebPluginContainerImpl.h:

(WebPluginContainerImpl):

4:00 PM Changeset in webkit [145956] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r136062. <rdar://problem/13334906>

3:54 PM Changeset in webkit [145955] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

New context extensions restored improperly
https://bugs.webkit.org/show_bug.cgi?id=112156

Patch by Rajeev Sarvaria <rsarvaria@blackberry.com> on 2013-03-15
Reviewed by Rob Buis.

Sets up extensions after new context is created for restoration.
Previous extensions set up is lost when context is initially lost.

Cannot create a test as change is not visible from the web. When a context
is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
object is created without available extensions initialized. Calling isEnabled
within setupFlags leads to the eventual initialization of extensions for the
new context.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):

3:22 PM Changeset in webkit [145954] by commit-queue@webkit.org

7 edits
2 adds in trunk

TextIterator emits LF for a br element inside an empty input element
https://bugs.webkit.org/show_bug.cgi?id=112275

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-03-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

Adding a check to avoid emiting LF for br elements inside a shadow tree
of an input element.

Test: editing/text-iterator/basic-iteration.html

editing/text-iterator/basic-iteration-shadowdom.html

editing/TextIterator.cpp:

(WebCore::shouldEmitNewlineForNode):
(WebCore::TextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
(WebCore::SimplifiedBackwardsTextIterator::exitNode):

editing/TextIterator.h:

(SimplifiedBackwardsTextIterator):

LayoutTests:

editing/text-iterator/basic-iteration-expected.txt: Extended to add two more cases.
editing/text-iterator/basic-iteration-shadowdom-expected.txt: Added.
editing/text-iterator/basic-iteration-shadowdom.html: Added.
editing/text-iterator/script-tests/basic-iteration.js: Extended to add two mroe cases.
platform/mac/TestExpectations:

3:19 PM Changeset in webkit [145953] by anilsson@rim.com

8 edits
1 add in trunk/Source

[BlackBerry] Allow an embedder to position child windows using window coordinates
https://bugs.webkit.org/show_bug.cgi?id=112236

Reviewed by Rob Buis.

PR 232752

Source/WebCore:

The LayerCompositingThread can now position the video window using
either document or window coordinates.

The LayerRenderer class gets a new client interface. This allows us to
avoid state duplication by delegating decisions directly to the client,
which can then be in charge of the (one and only) state.

The context is moved over to the client, as well as delegation of the
decision on whether to clear the surface every frame.

Also, the decision on which coordinate system to use for positioning
child windows is delegated to the client interface.

No new tests, not testable using DRT.

platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawTextures):

platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::create):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::toWebKitWindowCoordinates):
(WebCore::LayerRenderer::makeContextCurrent):

platform/graphics/blackberry/LayerRenderer.h:

(WebCore):
(LayerRenderer):
(WebCore::LayerRenderer::client):

platform/graphics/blackberry/LayerRendererClient.h: Added.

(Graphics):
(WebCore):
(LayerRendererClient):
(WebCore::LayerRendererClient::~LayerRendererClient):

Source/WebKit/blackberry:

Child windows used to always be positioned in document coordinates,
which requires the
BlackBerry::Platform::Graphics::Window::virtualRect() of the parent
window to be kept in sync with the document visible content rect.
This is easy if there's a one-to-one correspondence between windows
and scrollable frames.

However, for an embedder that can display an entire scene graph (where
the web page is just one of the nodes) in one window, several
scrollable nodes may be present in that window, and it's difficult to
know which scrollable node to sync the virtualRect with. It could also
lead to conflicts, if two scrollable nodes have child windows.

For the latter scenario, it makes more sense to use window coordinates
to place child windows.

The internal default is to use document coordinates, for legacy
reasons.

When an external WebPageCompositor is attached, we switch to using
window coordinates instead of document coordinates by default. The
behavior is still configurable using the new public
setChildWindowPlacement method.

Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::setContext):
(BlackBerry::WebKit::WebPageCompositorPrivate::prepareFrame):
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldClearSurfaceBeforeCompositing):
(WebKit):
(BlackBerry::WebKit::WebPageCompositorPrivate::shouldChildWindowsUseDocumentCoordinates):
(BlackBerry::WebKit::WebPageCompositor::WebPageCompositor):
(BlackBerry::WebKit::WebPageCompositor::setChildWindowPlacement):

Api/WebPageCompositor.h:
Api/WebPageCompositor_p.h:

(BlackBerry::WebKit::WebPageCompositorPrivate::setChildWindowPlacement):
(WebPageCompositorPrivate):

3:13 PM Changeset in webkit [145952] by pdr@google.com

2 edits
2 copies in branches/chromium/1410

Merge 145726 "Fix body background image geometry calculation"

Fix body background image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

This change introduces clientForBackgroundImage in the background geometry calculation.
This is very similar to how the client is looked up in paintFillLayerExtended.

rendering/RenderBoxModelObject.h:

The new signature for calculateBackgroundImageGeometry now mirrors
paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

svg/as-background-image/svg-as-background-body-expected.html: Added.
svg/as-background-image/svg-as-background-body.html: Added.

TBR=pdr@google.com
Review URL: https://codereview.chromium.org/12712011

3:12 PM Changeset in webkit [145951] by zandobersek@gmail.com

5 edits in trunk/Source/WebKit2

[GTK] Enforce the C++11 standard when compiling WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112169

Reviewed by Gustavo Noronha Silva.

With a limited set of supported compilers the WebKit2 source code can now
be built with the C++11 language standard enforced.

GNUmakefile.am:
UIProcess/API/gtk/WebKitWebContext.cpp:

(injectedBundleDirectory): Adjust the string literals concatenation, moving away from empty strings
(which C++11 refuses to handle as concatenation operators) and using whitespace instead.

UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:

(WebKit::WebInspectorServer::platformResourceForPath): Ditto.

UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::inspectorFilesBasePath): Ditto.

3:11 PM Changeset in webkit [145950] by Lucas Forschler

3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r132970. <rdar://problem/13335073>

3:09 PM Changeset in webkit [145949] by benjamin@webkit.org

2 edits in trunk/Source/WTF

[iOS] Update StringImpl's equal to have a single version on all supported Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112400

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Michael Saboff.

wtf/text/StringImpl.h:

(WTF::equal):
Tweak the code to make it work on older Apple CPUs:
-Use external "ouput" variable instead of the registers R9 and R12. This gets rid

of some register pressure previously imposed on the compiler. (Clang nicely
choose R9 and R12 when needed, following iOS ABI).

-Instead of using "R3" for storing the length / 4, update the length by -4 on

each iteration and work in the negative space for the tail. This frees one register
which is then used for isEqual.

-Get rid of the unconditional branch from the loop. By using subs and working in the

negative space, we can test for the Carry flag to jump back to the next LDR.

3:05 PM Changeset in webkit [145948] by Simon Fraser

2 edits in trunk/Tools

Have the mac port support per_test_timeout in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=112466

Reviewed by Dirk Pranke.

Both WTR and DRT handle --timeout arguments, so we can
have the scripts pass the timeout values down to the tools.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.supports_per_test_timeout):

2:57 PM Changeset in webkit [145947] by akling@apple.com

4 edits in trunk/Source/JavaScriptCore

Don't also clone StructureRareData when cloning Structure.
<http://webkit.org/b/111672>

Reviewed by Mark Hahnenberg.

We were cloning a lot of StructureRareData with only the previousID pointer set since
the enumerationCache is not shared between clones.

Let the Structure copy constructor decide whether it wants to clone the rare data.
The decision is made by StructureRareData::needsCloning() and will currently always
return false, since StructureRareData only holds on to caches at present.
This may change in the future as more members are added to StructureRareData.

runtime/Structure.cpp:

(JSC::Structure::Structure):
(JSC::Structure::cloneRareDataFrom):

runtime/StructureInlines.h:

(JSC::Structure::create):

2:55 PM Changeset in webkit [145946] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for IDB tests that regressed with r145929.

2:52 PM Changeset in webkit [145945] by mhahnenberg@apple.com

24 edits
9 deletes in trunk

Roll out r145838
https://bugs.webkit.org/show_bug.cgi?id=112458

Unreviewed. Requested by Filip Pizlo.

Source/JavaScriptCore:

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
dfg/DFGOperations.cpp:
interpreter/CallFrame.h:

(JSC::ExecState::objectPrototypeTable):

jit/JITStubs.cpp:

(JSC::getByVal):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

runtime/CommonIdentifiers.h:
runtime/JSCell.cpp:

(JSC):

runtime/JSCell.h:

(JSCell):

runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::fastGetOwnProperty):

runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSObject.cpp:

(JSC):

runtime/JSObject.h:

(JSObject):
(JSC):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::getOwnPropertySlot):
(JSC::ObjectPrototype::getOwnPropertyDescriptor):

runtime/ObjectPrototype.h:

(JSC::ObjectPrototype::create):
(ObjectPrototype):

runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

runtime/Structure.h:

(Structure):

runtime/StructureInlines.h:

(JSC::Structure::get):

LayoutTests:

fast/js/regress/script-tests/string-lookup-hit-identifier.js: Removed.
fast/js/regress/script-tests/string-lookup-hit.js: Removed.
fast/js/regress/script-tests/string-lookup-miss.js: Removed.
fast/js/regress/string-lookup-hit-expected.txt: Removed.
fast/js/regress/string-lookup-hit-identifier-expected.txt: Removed.
fast/js/regress/string-lookup-hit-identifier.html: Removed.
fast/js/regress/string-lookup-hit.html: Removed.
fast/js/regress/string-lookup-miss-expected.txt: Removed.
fast/js/regress/string-lookup-miss.html: Removed.

2:52 PM Changeset in webkit [145944] by jochen@chromium.org

7 edits in trunk/Source

Expose whether a UserGestureToken still has gestures via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112342

Reviewed by Adam Barth.

Source/WebCore:

dom/UserGestureIndicator.cpp:
dom/UserGestureIndicator.h:

(UserGestureToken):

Source/WebKit/chromium:

public/WebUserGestureToken.h:

(WebUserGestureToken):

src/WebUserGestureToken.cpp:

(WebKit::WebUserGestureToken::hasGestures):
(WebKit):

tests/WebUserGestureTokenTest.cpp:

(WebCore::TEST):

2:50 PM Changeset in webkit [145943] by commit-queue@webkit.org

12 edits in trunk/Source/WebCore

Convert inspector to new-flexbox
https://bugs.webkit.org/show_bug.cgi?id=112399

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-15
Reviewed by Ojan Vafai.

No new tests, refactoring.

inspector/front-end/auditsPanel.css:

(.audit-launcher-view .audit-launcher-view-content):
(.audit-launcher-view div.button-container):
(.audit-launcher-view div.button-container > button):

inspector/front-end/dialog.css:

(.dialog):

inspector/front-end/elementsPanel.css:

(.sidebar-pane.composite .metrics):

inspector/front-end/helpScreen.css:

(.help-window-main):
(.help-content):

inspector/front-end/inspector.css:

(#toolbar):
(#toolbar-controls):
(#toolbar-dropdown .scrollable-content):
(#toolbar-dropdown .toolbar-item):
(.toolbar-item.close-left, .toolbar-item.close-right):

inspector/front-end/nativeMemoryProfiler.css:

(.memory-pie-chart-container):
(.memory-pie-chart):

inspector/front-end/networkPanel.css:

(.network-item-view.visible):

inspector/front-end/panelEnablerView.css:

(.panel-enabler-view .flexible-space):

inspector/front-end/profilesPanel.css:

(.profile-launcher-view-content):
(.control-profiling):

inspector/front-end/splitView.css:

(.sidebar-overlay):

inspector/front-end/tabbedPane.css:

(.tabbed-pane):
(.tabbed-pane-content):
Replace -webkit-box with -webkit-flex, -webkit-box-orient with
-webkit-flex-direction, etc.

2:37 PM Changeset in webkit [145942] by Lucas Forschler

5 edits
2 copies in branches/safari-536.30-branch

Merged r132724. <rdar://problem/13335007>

2:30 PM Changeset in webkit [145941] by Lucas Forschler

6 edits in branches/safari-536.30-branch

Merged r132511. <rdar://problem/13334997>

2:28 PM Changeset in webkit [145940] by commit-queue@webkit.org

30 edits in trunk

Source/WebCore: Remove unused unified textchecker variable
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

The variable m_originalUnifiedSpellCheckerEnabled is never used. The generated
code from Settings.in already backs up and restores unified textchecker setting.

testing/InternalSettings.h: Remove unusued m_originalUnifiedSpellCheckerEnabled variable.

Tools: Remove setAsynchronousSpellCheckingEnabled from test runners
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
in internals.settings, so all ports can share it.

DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.

LayoutTests: Move setAsynchronousSpellCheckingEnabled to internals.settings
https://bugs.webkit.org/show_bug.cgi?id=112362

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-03-15
Reviewed by Tony Chang.

Changed the tests from using testRunner.setAsynchronousSpellCheckingEnabled(bool)
with port-specific implementations to use internals.settings.setAsynchronousSpellCheckingEnabled(bool)
with one common implementation, similar to internals.settings.setUnifiedTextCheckerEnabled(bool).
Changed the tests to not reset these settings when they finish, because the test harness resets
the settings automatically.

editing/spelling/grammar-markers-hidpi.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/grammar-markers.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/grammar-paste.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/resources/util.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/script-tests/spellcheck-paste.js: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-async-mutation.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-async-remove-frame.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-async.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-paste-disabled.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-queue.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spellcheck-sequencenum.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
editing/spelling/spelling-marker-description.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
platform/chromium/editing/spelling/delete-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).
platform/chromium/editing/spelling/move-cursor-to-misspelled-word.html: Use internals.settings.setAsynchronousSpellCheckingEnabled(bool) instead of testRunner.setAsynchronousSpellCheckingEnabled(bool).

2:26 PM Changeset in webkit [145939] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merge 132287. <rdar://problem/13335000>

2:16 PM Changeset in webkit [145938] by Lucas Forschler

3 edits
3 adds in branches/safari-536.30-branch

Merge 131709. <rdar://problem/13334885>

2:13 PM Changeset in webkit [145937] by ojan@chromium.org

4 edits
2 adds in trunk

Auto height column flexboxes with border and padding are too short
https://bugs.webkit.org/show_bug.cgi?id=112398

Reviewed by Tony Chang.

Source/WebCore:

Test: css3/flexbox/auto-height-column-with-border-and-padding.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):
computeLogicalHeight expects that you pass in the border-box logicalHeight, not
the contentLogicalHeight. Since we subtract the border, padding and scrollbar height from
the returned m_extent, if we pass in the contentLogicalHeight and the flexbox is auto-sized
then we end up incorrectly subtracting border, padding and scrollbar height from the
contentLogicalHeight.

LayoutTests:

css3/flexbox/auto-height-column-with-border-and-padding-expected.html: Added.
css3/flexbox/auto-height-column-with-border-and-padding.html: Added.
css3/flexbox/resources/flexbox.css:

(.flex-one-one-auto):

2:06 PM Changeset in webkit [145936] by kov@webkit.org

41 edits in trunk/Source/WebCore/platform/gtk/po

Unreviewed, build fix. Also gather translatable strings from WebKit2 files.

POTFILES.in: added WebKit2GTK+ files that have translatable strings.
ar.po: regenerated.
as.po: ditto.
bg.po: ditto.
cs.po: ditto.
de.po: ditto.
el.po: ditto.
en_CA.po: ditto.
en_GB.po: ditto.
eo.po: ditto.
es.po: ditto.
et.po: ditto.
eu.po: ditto.
fr.po: ditto.
gl.po: ditto.
gu.po: ditto.
he.po: ditto.
hi.po: ditto.
hu.po: ditto.
id.po: ditto.
it.po: ditto.
ko.po: ditto.
lt.po: ditto.
lv.po: ditto.
mr.po: ditto.
nb.po: ditto.
nl.po: ditto.
pa.po: ditto.
pl.po: ditto.
pt.po: ditto.
pt_BR.po: ditto.
ro.po: ditto.
ru.po: ditto.
sl.po: ditto.
sr.po: ditto.
sr@latin.po: ditto.
sv.po: ditto.
uk.po: ditto.
vi.po: ditto.
zh_CN.po: ditto.

1:34 PM Changeset in webkit [145935] by benjamin@webkit.org

2 edits in trunk/Source/WTF

[iOS] Fix the length pass to memcmp in the fallback versions of String's equal
https://bugs.webkit.org/show_bug.cgi?id=112463

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-15
Reviewed by Ryosuke Niwa.

wtf/text/StringImpl.h:

(WTF::equal): It might be a good idea to compare the full UChar strings...

1:33 PM Changeset in webkit [145934] by timothy_horton@apple.com

7 edits in trunk/Source/WebCore

RenderSnapshottedPlugIn can't be a RenderBlock (what if it's display: inline?)
https://bugs.webkit.org/show_bug.cgi?id=112432
<rdar://problem/13187211>

Reviewed by Simon Fraser and Dean Jackson.

Re-use code from PLUGIN_PROXY_FOR_VIDEO to allow RenderEmbeddedObject to lay out its children,
and make RenderSnapshottedPlugIn a RenderEmbeddedObject subclass once again. This will ensure that
RenderSnapshottedPlugIn lays itself out in the page the same as the RenderEmbeddedObject it replaces did,
preventing snapshotted plug-ins from breaking the layout when they are display: inline.

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler):
RenderSnapshottedPlugIn is a RenderEmbeddedObject subclass again, so we need to check
for it when we have a RenderEmbeddedObject, instead of when we don't.

page/FrameView.cpp:

(WebCore::FrameView::updateWidget):
Ditto.

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::canHaveChildren):
Allow RenderEmbeddedObject to have and lay out children if it is a RenderSnapshottedPlugIn.
Also, preserve the code that allows children if it is a media element and PLUGIN_PROXY_FOR_VIDEO is enabled.
Don't call addWidgetToUpdate for instances which will never have a widget, like RenderSnapshottedPlugIn.

rendering/RenderEmbeddedObject.h:

(RenderEmbeddedObject):
We need canHaveChildren() and children() and m_children now.
Add canHaveWidget(), which returns true. Subclasses can override if need be.

rendering/RenderSnapshottedPlugIn.h: Add canHaveWidget(), which is false for RenderSnapshottedPlugIn.
rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):
(WebCore::RenderSnapshottedPlugIn::layout):
(WebCore::RenderSnapshottedPlugIn::getCursor):
Make RenderSnapshottedPlugIn a RenderEmbeddedObject.

(WebCore::RenderSnapshottedPlugIn::paint):
Paint our children.

1:24 PM Changeset in webkit [145933] by msaboff@apple.com

7 edits in trunk/Source/JavaScriptCore

Cleanup of DFG and Baseline JIT debugging code
https://bugs.webkit.org/show_bug.cgi?id=111871

Reviewed by Geoffrey Garen.

Fixed various debug related issue in baseline and DFG JITs. See below.

dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

dfg/DFGScratchRegisterAllocator.h: Now use ScratchBuffer::activeLengthPtr() to get

pointer to scratch register length.
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkConsistency): Added missing case labels for DataFormatOSRMarker,
DataFormatDead, and DataFormatArguments and made them RELEASE_ASSERT_NOT_REACHED();

jit/JITCall.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

jit/JITCall32_64.cpp:

(JSC::JIT::privateCompileClosureCall): Used pointerDump() to handle when calleeCodeBlock is NULL.

runtime/JSGlobalData.h:

(JSC::ScratchBuffer::ScratchBuffer): Fixed buffer allocation alignment to
be on a double boundary.
(JSC::ScratchBuffer::setActiveLength):
(JSC::ScratchBuffer::activeLength):
(JSC::ScratchBuffer::activeLengthPtr):

1:12 PM Changeset in webkit [145932] by morrita@google.com

34 edits
2 adds in trunk

[Custom Elements] Any HTMLElement subclass should become a superclass of custom element
https://bugs.webkit.org/show_bug.cgi?id=110436

Reviewed by Dimitri Glazkov.

Source/WebCore:

This change introduces "type extension" concept of custom elements.
With the type extension, each custom elements are able to inherit
from not only HTMLElement, but also any HTML element. To make it work,
this change extends the plumbing.

This change does following changes:

Data structure:

Let CustomElementConstructor objects being keyed by pair of (element name, local name) as the standard requries, instead of just using single name. See CustomElementRegistry::ConstructorMap and CustomElementRegistry::find().

Creates mapping from WrapperTypeInfo to element name. This map can be looked-up by generated functions like findHTMLTagNameOfV8Type(). With this table, WebKit can determine the custom element local name of given prototype object. See make_names.pl. Note that V8 prototype object knows associated WrapperTypeInfo. See r144865.

Hooking up element lifecyle:

Create appropriate C++ instance for each custom element. Before this change, the C++ backend of custom elements were always HTMLUnknownElements or HTMLElement. See CustomElementConstructor::createElement() and ElementFactories in make_names.pl.

Hooks up element construction and element wrapper creation for custom element "before" non-custom case instead of "after" that. We do this because custom element needs to override non-custom case when @is attribute is given for otherwise-non-custom elements like <div is=x-bar>. See make_names.pl.

Gives @is attributes to elements if needed. See setTypeExtension() call sites like Document::createElement(), Document::createElementtNS() and CustomElementConstructor::createElementt()

Test: fast/dom/custom/document-register-type-extensions.html

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

bindings/scripts/test/V8/V8Float64Array.h:
bindings/scripts/test/V8/V8TestActiveDOMObject.h:
bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
bindings/scripts/test/V8/V8TestEventConstructor.h:
bindings/scripts/test/V8/V8TestEventTarget.h:
bindings/scripts/test/V8/V8TestException.h:
bindings/scripts/test/V8/V8TestInterface.h:
bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
bindings/scripts/test/V8/V8TestNamedConstructor.h:
bindings/scripts/test/V8/V8TestNode.h:
bindings/scripts/test/V8/V8TestObj.h:
bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
bindings/scripts/test/V8/V8TestTypedefs.h:
bindings/v8/CustomElementHelpers.cpp:

(WebCore::hasValidPrototypeChain):
(WebCore::CustomElementHelpers::isValidPrototypeParameter):
(WebCore::CustomElementHelpers::findLocalName):
(WebCore):
(WebCore::CustomElementHelpers::findWrapperType):

bindings/v8/CustomElementHelpers.h:

(CustomElementHelpers):

bindings/v8/V8CustomElement.cpp:

(WebCore::V8CustomElement::createWrapper):

bindings/v8/V8CustomElement.h:

(V8CustomElement):
(WebCore::V8CustomElement::wrap):
(WebCore::V8CustomElement::constructorOf):

bindings/v8/WrapperTypeInfo.h:

(WrapperTypeTraits): Added.

bindings/v8/custom/V8CustomElementConstructorCustom.cpp:

(WebCore::V8CustomElementConstructor::callAsFunctionCallback):

dom/CustomElementConstructor.cpp:

(WebCore::CustomElementConstructor::create):
(WebCore::CustomElementConstructor::CustomElementConstructor):
(WebCore::CustomElementConstructor::createElement):
(WebCore::setTypeExtension):

dom/CustomElementConstructor.h:

(CustomElementConstructor):
(WebCore::CustomElementConstructor::document):
(WebCore::CustomElementConstructor::typeName):
(WebCore::CustomElementConstructor::localName):

dom/CustomElementRegistry.cpp:

(WebCore::nameIncludesHyphen):
(WebCore::CustomElementRegistry::isValidName):
(WebCore::CustomElementRegistry::registerElement):
(WebCore::CustomElementRegistry::findFor):
(WebCore::CustomElementRegistry::find):
(WebCore::CustomElementRegistry::createElement):

dom/CustomElementRegistry.h:

(CustomElementRegistry):

dom/Document.cpp:

(WebCore::Document::createElement):
(WebCore::Document::createElementNS):
(WebCore::Document::registerElement):

dom/Document.h:

(Document):
(WebCore::Document::registry): Moved from Document.cpp to be inlined.

dom/Document.idl:
dom/make_names.pl:

(printFactoryCppFile):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

html/HTMLAttributeNames.in: Added @is attribute

LayoutTests:

fast/dom/custom/document-register-basic-expected.txt:
fast/dom/custom/document-register-basic.html:
fast/dom/custom/document-register-type-extensions-expected.txt: Added.
fast/dom/custom/document-register-type-extensions.html: Added.

12:33 PM Changeset in webkit [145931] by msaboff@apple.com

7 edits in trunk/Source

Add runtime check for improper register allocations in DFG
https://bugs.webkit.org/show_bug.cgi?id=112380

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added framework to check for register allocation within a branch source - target range. All register allocations
are saved using the offset in the code stream where the allocation occurred. Later when a jump is linked, the
currently saved register allocations are checked to make sure that they didn't occur in the range of code that was
jumped over. This protects against the case where an allocation could have spilled register contents to free up
a register and that spill only occurs on one path of a many through the code. A subsequent fill of the spilled
register may load garbage. See https://bugs.webkit.org/show_bug.cgi?id=111777 for one such bug.
This code is protected by the compile time check of #if ENABLE(DFG_REGISTER_ALLOCATION_VALIDATION).
The check is only done during the processing of SpeculativeJIT::compile(Node* node) and its callees.

assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link): Invoke register allocation checks using source and target of link.
(JSC::AbstractMacroAssembler::Jump::linkTo): Invoke register allocation checks using source and target of link.
(AbstractMacroAssembler):
(RegisterAllocationOffset): New helper class to store the instruction stream offset and compare against a
jump range.
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::RegisterAllocationOffset):
(JSC::AbstractMacroAssembler::RegisterAllocationOffset::check):
(JSC::AbstractMacroAssembler::addRegisterAllocationAtOffset):
(JSC::AbstractMacroAssembler::clearRegisterAllocationOffsets):
(JSC::AbstractMacroAssembler::checkRegisterAllocationAgainstBranchRange):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::allocate):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Source/WTF:

wtf/Platform.h: Added new ENABLE_DFG_REGISTER_ALLOCATION_VALIDATION compilation flag to

enable generation of register allocation checking. This is on for debug builds.

12:03 PM Changeset in webkit [145930] by ap@apple.com

20 edits in trunk/Source/WebCore

Minor cleanup in worker code
https://bugs.webkit.org/show_bug.cgi?id=112455

Reviewed by Anders Carlsson.

Added OVERRIDE keywords.
Toned down FIXMEs about single MessagePort versions of functions. It's not a given that we'll want to get rid of them even when implementing array versions.
Explicitly marked virtual destructors as virtual.

dom/MessageEvent.cpp:
dom/MessageEvent.h:
workers/Worker.cpp:
workers/Worker.h: Removed an unused version of postMessage() that took no MessagePorts. This makes it less confusing why MessagePortArray is passed by pointer, and not by reference.

workers/DedicatedWorkerContext.cpp: (WebCore::DedicatedWorkerContext::~DedicatedWorkerContext):
workers/DedicatedWorkerContext.h: Added a destructor instead of an implicit one. Removed an unused version of postMessage() that took no MessagePorts.

workers/SharedWorker.h: Removed an unused virtual function (thank you OVERRIDE!)

dom/MessagePort.cpp:
dom/MessagePort.h:
loader/WorkerThreadableLoader.h:
page/DOMWindow.h:
workers/AbstractWorker.h:
workers/DedicatedWorkerThread.h:
workers/SharedWorkerContext.h:
workers/SharedWorkerThread.h:
workers/WorkerContext.h:
workers/WorkerMessagingProxy.h:
workers/WorkerObjectProxy.h:
workers/WorkerScriptLoader.h:

11:58 AM Changeset in webkit [145929] by jsbell@chromium.org

27 edits
2 copies
1 add in trunk

[V8] Binding: Implement EnforceRange IDL Attribute for long long conversions
https://bugs.webkit.org/show_bug.cgi?id=96798

Reviewed by Kentaro Hara.

Source/WebCore:

Implement [EnforceRange] attribute for V8 bindings, which specifies throwing behavior
on conversions outside int/uint 32/64 ranges and edge cases like NaNs and Infinities.
Conversely, conversions without this attribute should *not* throw.

Tests: fast/js/webidl-type-mapping.html:

fast/dom/non-numeric-values-numeric-parameters.html
fast/js/script-tests/select-options-add.html
storage/indexeddb/intversion-bad-parameters.html

Modules/indexeddb/IDBCursor.cpp: Remove custom range enforcement for advance()
Modules/indexeddb/IDBCursor.h: Adjust type to match WebIDL.
Modules/indexeddb/IDBCursor.idl: Specify [EnforceRange] and type matches spec WebIDL.
Modules/indexeddb/IDBFactory.cpp: Remove custom range enforcement for open()
Modules/indexeddb/IDBFactory.h: Adjust type to match WebIDL.
Modules/indexeddb/IDBFactory.idl: Specify [EnforceRange] and type matches spec WebIDL.
bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative): Add FIXME to support [EnforceRange]

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter): Handle [EnforceRange] in attribute setters
(GenerateParametersCheck): Handle [EnforceRange] in parameters.
(JSValueToNative): Pass EnforceRange to toInt() functions as appropriate.

bindings/scripts/IDLAttributes.txt:
bindings/scripts/test/TestObj.idl: Tests w/ [EnforceRange]
bindings/scripts/test/V8/V8TestObj.cpp: Updated expectations
bindings/scripts/test/V8/V8TestTypedefs.cpp: Updated expectations.
bindings/v8/V8Binding.cpp: Overloads for toInt() variants that handle constraints.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

bindings/v8/V8Binding.h: Ditto, plus helpers for callers not expecting errors.

(WebCore::toInt32):
(WebCore::toUInt32):
(WebCore::toInt64):
(WebCore::toUInt64):

bindings/v8/V8BindingMacros.h: Helper macros for type conversions that may throw.
testing/TypeConversions.h: Added new members with EnforceRange constraint.
testing/TypeConversions.idl: Ditto.

LayoutTests:

Some of the tests for HTMLOptionsCollection.add() assumed it should throw for
Infinities and NaNs, but this is not what the DOM+WebIDL specs say. (Firefox doesn't throw
so this does not appear to be a web-compat issue.) This updates the tests/expectations so
that V8 passes. JSC expectations are FAIL in a few places since it still incorrectly throws
on Infinity/NaN -> int32 conversion (existing tests) and does not implement EnforceRange
(new tests).

Tne non-numeric-values-numeric-parameters test was also broken for NaN testing, reporting
incorrect results which hid some of this behavior.

fast/dom/non-numeric-values-numeric-parameters-expected.txt: Failing behavior for JSC.
fast/dom/script-tests/non-numeric-values-numeric-parameters.js: HTMLOptionsCollection.add()

should not throw on NaNs/Infinities.

fast/js/script-tests/select-options-add.js: Ditto.
fast/js/select-options-add-expected.txt: Failing behavior for JSC.
fast/js/webidl-type-mapping-expected.txt: Ditto.
fast/js/webidl-type-mapping.html: Added test cases for [EnforceRange]
platform/chromium/fast/dom/non-numeric-values-numeric-parameters-expected.txt: Added - passing behavior for V8.
platform/chromium/fast/js/select-options-add-expected.txt: Ditto.
platform/chromium/fast/js/webidl-type-mapping-expected.txt: Added.
storage/indexeddb/intversion-bad-parameters-expected.txt: Added non-finite test cases.
storage/indexeddb/resources/intversion-bad-parameters.js: Ditto.

11:58 AM Changeset in webkit [145928] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r130999. <rdar://problem/13334880>

11:52 AM Changeset in webkit [145927] by Simon Fraser

2 edits in trunk/LayoutTests

Marking sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.8_Arguments_Object/S10.1.8_A3_T2.html
as a Slow test.

platform/mac/TestExpectations:

11:47 AM Changeset in webkit [145926] by eustas@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Network] Refine JSDocs in NetworkRequest.js
https://bugs.webkit.org/show_bug.cgi?id=112412

Reviewed by Vsevolod Vlasov.

Return types for some members are confusing (Object).

inspector/front-end/NetworkManager.js: Fixed JSDocs.
inspector/front-end/NetworkRequest.js: Ditto. Plus minor refactorings.

11:43 AM Changeset in webkit [145925] by Simon Fraser

2 edits in trunk/Tools

Fix the stupid unit tests.

Scripts/webkitpy/layout_tests/port/mac_unittest.py:

(test_sample_process):

11:26 AM Changeset in webkit [145924] by aestes@apple.com

4 edits
2 adds in trunk

REGRESSION (r127277): CSS URIs with multi-byte Unicode escape sequences fail to parse
https://bugs.webkit.org/show_bug.cgi?id=112436

Reviewed by Michael Saboff.

Source/WebCore:

r127277 modified the CSS parser to use 8-bit strings when possible.
However, it failed to handle URIs that contain Unicode escape sequences
that expand to multi-byte characters. Not only would the URI fail to
parse, but so would the remainder of the input string.

Fix this by producing a 16-bit result when we detect a URI with a
multi-byte Unicode escape, like we do for identifiers and other strings.

Test: fast/css/url-with-multi-byte-unicode-escape.html

css/CSSParser.cpp:

(WebCore::checkAndSkipString): Changed to be a free function since it
doesn't access CSSParser's internal state.
(WebCore::CSSParser::findURI): Added a function that consolidates the
logic of finding the start and end pointers of the URI and the quote
character (if encountered), starting at the current character.
(WebCore::CSSParser::parseURIInternal): Removed duplicated logic for
finding the URI bounds (this now lives in findURI()) and logic for
setting the token type and updating the current character (this now
lives in parseURI()).
(WebCore::CSSParser::parseURI): Find the URI and parse it. If a
multi-byte Unicode escape is encountered, rewind to the beginning of
the URI and re-parse with a 16-bit string as the destination.

css/CSSParser.h:

LayoutTests:

fast/css/url-with-multi-byte-unicode-escape-expected.txt: Added.
fast/css/url-with-multi-byte-unicode-escape.html: Added.

11:16 AM Changeset in webkit [145923] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188418. Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

DEPS:

11:10 AM Changeset in webkit [145922] by akling@apple.com

8 edits
1 delete in trunk/Source/WebCore

[JSC] Remove custom WebAudio mark functions that we can generate instead.
<http://webkit.org/b/110976>

Reviewed by Eric Carlson.

Remove custom JSC mark functions for AudioContext and ScriptProcessorNode since they
are trivial to generate.

Modules/webaudio/AudioContext.idl:
Modules/webaudio/ScriptProcessorNode.idl:
GNUmakefile.list.am:
UseJSC.cmake:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSAudioContextCustom.cpp:
bindings/js/JSScriptProcessorNodeCustom.cpp: Removed.

11:08 AM Changeset in webkit [145921] by kareng@chromium.org

62 edits in branches/chromium/1441/Source

Revert 145802 "[V8] Store main world and non-main world template..."

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:
(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:
(V8TestTypedefs):

bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):

bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::visitNodeWrappers):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8AdaptorFunction.cpp:
(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8Binding.cpp:
(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

bindings/v8/V8Binding.h:
(WebCore):
(WebCore::toRefPtrNativeArray):

bindings/v8/V8Collection.cpp:
(WebCore::toOptionsCollectionSetter):

bindings/v8/V8GCController.cpp:
bindings/v8/V8NPObject.cpp:
(WebCore::npObjectInvokeImpl):

bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

bindings/v8/V8PerIsolateData.h:
(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):

bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

bindings/v8/custom/V8BlobCustom.cpp:
(WebCore::V8Blob::constructorCustom):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toCanvasStyle):

bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8CryptoCustom.cpp:
(WebCore::V8Crypto::getRandomValuesMethodCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:
(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCustom):

bindings/v8/custom/V8DocumentCustom.cpp:
(WebCore::V8Document::evaluateMethodCustom):

bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
(WebCore::V8HTMLOptionsCollection::addMethodCustom):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
(WebCore::removeElement):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

bindings/v8/custom/V8NodeCustom.cpp:
(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

bindings/v8/custom/V8NodeListCustom.cpp:
(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::createFromV8Value):

src/WebArrayBufferView.cpp:
(WebKit::WebArrayBufferView::createFromV8Value):

src/WebBindings.cpp:
(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

TBR=commit-queue@webkit.org

11:05 AM Changeset in webkit [145920] by kareng@chromium.org

1 add in branches/chromium/1441/codereview.settings

for drovering

11:04 AM Changeset in webkit [145919] by kareng@chromium.org

1 copy in branches/chromium/1441

branching for 1441 to revert top crasher.

11:03 AM Changeset in webkit [145918] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreviewed build fix. Rename local variable which was colliding with class method.

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone):

11:00 AM Changeset in webkit [145917] by jsbell@chromium.org

4 edits in trunk/Source

IndexedDB: Handle success events arriving after context stopped
https://bugs.webkit.org/show_bug.cgi?id=112451

Reviewed by Tony Chang.

Source/WebCore:

In multiprocess ports, events from the back-end can arrive in the form of
onXXX() calls after the script execution context has stopped. These need to
be ignored. This was already done in most cases, but missing for two overloads
of IDBRequest::onSuccess() - void and int64_t.

Test: webkit_unit_test IDBRequestTest.EventsAfterStopping

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::onSuccess): Early return if context has stopped.
(WebCore::IDBRequest::onSuccessInternal): ASSERT() that callers have checked context.

Source/WebKit/chromium:

tests/IDBRequestTest.cpp:

(WebKit::TEST_F): Add cases for onSuccess() and onSuccess(int64_t)

10:59 AM Changeset in webkit [145916] by Simon Fraser

8 edits in trunk

Collect samples for unresponsive web processes
https://bugs.webkit.org/show_bug.cgi?id=112409

Tools:

Reviewed by Tim Horton.

When we detect that a subprocess was unresponsive, run the 'sample'
tool on that process, for the Mac port.

The sample will be linked to from the results.html page, next
to the crash log link.

Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._look_for_new_crash_logs): Before looking for crash logs,
look for samples on disk.

Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter):
(TestResultWriter.copy_sample_file): Teach TestResultWriter about
-sample.txt files, and have it copy their contents to a new file
next to the test that spawned them (as we do for crash logs).

Scripts/webkitpy/layout_tests/port/base.py:

(Port.look_for_new_samples): Base class does nothing for sampling.

Scripts/webkitpy/layout_tests/port/driver.py:

(Driver._check_for_driver_crash): Kick off a sample if we detected
that the subprocess was unresponsive.

Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.sample_file_path): Utility to generate the file path
to the generated sample files at the top level of layout-test-results.
(MacPort.look_for_new_crash_logs): Fix typo
(MacPort.look_for_new_samples): New function to find sample files.
(MacPort.sample_process): Use the utility function to get the file path.

LayoutTests:

Reviewed by Tim Horton.

Add links for samples, which some platforms will show for unresponsive WebProcess timeouts.

fast/harness/results.html:

10:58 AM Changeset in webkit [145915] by jer.noble@apple.com

6 edits
3 adds in trunk

REGRESSION: -webkit-box-reflect does not show on video elements
https://bugs.webkit.org/show_bug.cgi?id=112397

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/video/video-reflection.html

Support cloning specific CALayer subtypes in PlatformCALayer,
which allows reflections to work correctly for those layer types.
Specifically, add support for cloning AVPlayerLayer layers.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::cloneLayer): Moved most of the

implementation to PlatformCALayer::clone().

platform/graphics/ca/PlatformCALayer.h:
platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer): Set the layerType to

LayerTypeAVPlayerLayer if the PlatformLayer parameter is an
AVPlayerLayer.

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

Copy the player value to the new layer, if the current layer is
a LayerTypeAVPlayerLayer.

(PlatformCALayer::playerLayer):

platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayer::clone): Moved from GraphicsLayerCA::cloneLayer().

May want to add support for AVCFPlayerLayers in the future.

LayoutTests:

compositing/video/video-reflection-expected.png: Added.
compositing/video/video-reflection-expected.txt: Added.
compositing/video/video-reflection.html: Added.

10:45 AM Changeset in webkit [145914] by Nate Chapin

46 edits in trunk/Source

Hide MainResourceLoader from the outside world
https://bugs.webkit.org/show_bug.cgi?id=109971

Reviewed by Adam Barth.

Source/WebCore:

No new tests, refactor only.

WebCore.exp.in:
dom/Document.cpp:
html/HTMLEmbedElement.cpp:
html/MediaDocument.cpp:
html/PluginDocument.cpp:
loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainResourceLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::setMainResourceDataBufferingPolicy):

loader/DocumentLoader.h:
loader/EmptyClients.h:
loader/FrameLoader.cpp:
loader/FrameLoaderClient.h:
loader/MainResourceLoader.cpp:
loader/appcache/ApplicationCacheGroup.cpp:
loader/appcache/ApplicationCacheHost.cpp:

Source/WebKit/blackberry:

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

WebCoreSupport/FrameLoaderClientBlackBerry.h:

(FrameLoaderClientBlackBerry):

Source/WebKit/chromium:

src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::convertMainResourceLoadToDownload):

src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::convertMainResourceLoadToDownload):

WebCoreSupport/FrameLoaderClientEfl.h:

(FrameLoaderClientEfl):

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::convertMainResourceLoadToDownload):

WebCoreSupport/FrameLoaderClientGtk.h:

(FrameLoaderClient):

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

Source/WebKit/qt:

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):

WebCoreSupport/FrameLoaderClientQt.h:

(FrameLoaderClientQt):

Source/WebKit/win:

WebFrame.cpp:

(WebFrame::convertMainResourceLoadToDownload):

WebFrame.h:

Source/WebKit/wince:

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::convertMainResourceLoadToDownload):

WebCoreSupport/FrameLoaderClientWinCE.h:

(FrameLoaderClientWinCE):

Source/WebKit/wx:

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::convertMainResourceLoadToDownload):

WebKitSupport/FrameLoaderClientWx.h:

(FrameLoaderClientWx):

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):

WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

(WebFrameLoaderClient):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):

WebProcess/WebPage/WebFrame.h:

(WebFrame):

10:31 AM Changeset in webkit [145913] by inferno@chromium.org

77 edits in trunk/Source

Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112401

Reviewed by Stephen Chenney.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

accessibility/AccessibilityObject.cpp:

(WebCore::appendAccessibilityObject):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForPoint):

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::webAreaObject):
(WebCore::AccessibilityScrollView::documentFrameView):
(WebCore::AccessibilityScrollView::parentObject):
(WebCore::AccessibilityScrollView::parentObjectIfExists):

accessibility/chromium/AXObjectCacheChromium.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::pluginScriptObjectFromPluginViewBase):

bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused):

bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

bindings/js/ScriptControllerQt.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::createScriptInstanceForWidget):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::appendFormData):

page/EventHandler.cpp:

(WebCore::EventHandler::subframeForTargetNode):
(WebCore::EventHandler::passGestureEventToWidget):

page/Frame.cpp:

(WebCore::Frame::frameForWidget):

page/FrameView.cpp:

(WebCore::collectFrameViewChildren):
(WebCore::FrameView::hasCustomScrollbars):
(WebCore::FrameView::convertToContainingView):
(WebCore::FrameView::convertFromContainingView):
(WebCore::FrameView::removeChild):

page/FrameView.h:

(WebCore::toFrameView):
(WebCore):

page/Page.cpp:

(WebCore::Page::collectPluginViews):

page/chromium/EventHandlerChromium.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::passWheelEventToWidget):

page/qt/EventHandlerQt.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

page/wx/EventHandlerWx.cpp:

(WebCore::EventHandler::passWheelEventToWidget):

platform/ScrollView.h:

(WebCore::toScrollView):
(WebCore):

platform/Scrollbar.cpp:

(WebCore::Scrollbar::isScrollViewScrollbar):
(WebCore::Scrollbar::mouseUp):
(WebCore::Scrollbar::axObjectCache):

platform/Widget.h:

(WebCore::Widget::isScrollView):

platform/blackberry/PlatformScreenBlackBerry.cpp:

(WebCore::toUserSpace):

platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::setParent):

platform/qt/PlatformSupportQt.cpp:

(WebCore::PlatformSupport::popupsAllowed):
(WebCore::PlatformSupport::pluginScriptableObject):

plugins/IFrameShimSupport.cpp:

(WebCore::getPluginOcclusions):

plugins/PluginView.h:

(WebCore::toPluginView):
(WebCore):

plugins/PluginViewBase.h:

(WebCore::PluginViewBase::isPluginViewBase):
(PluginViewBase):
(WebCore::toPluginViewBase):
(WebCore):

plugins/blackberry/PluginViewBlackBerry.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::updateBuffer):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleScrollEvent):
(WebCore::PluginView::calculateClipRect):
(WebCore::PluginView::handleFullScreenAllowedEvent):
(WebCore::PluginView::handleFullScreenExitEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::platformGetValue):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setBackgroundPlay):

plugins/blackberry/PluginViewPrivateBlackBerry.cpp:

(WebCore::PluginViewPrivate::setVisibleRects):
(WebCore::PluginViewPrivate::showKeyboard):
(WebCore::PluginViewPrivate::requestFullScreen):
(WebCore::PluginViewPrivate::requestCenterFitZoom):
(WebCore::PluginViewPrivate::lockOrientation):
(WebCore::PluginViewPrivate::unlockOrientation):
(WebCore::PluginViewPrivate::preventIdle):

plugins/gtk/PluginViewGtk.cpp:

(WebCore::PluginView::updatePluginWidget):

plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):

plugins/qt/PluginViewQt.cpp:

(WebCore::PluginView::updatePluginWidget):

plugins/win/PluginViewWin.cpp:

(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paintWindowedPluginIntoContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::snapshot):

rendering/RenderBox.cpp:

(WebCore::RenderBox::addLayoutOverflow):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::allowsAcceleratedCompositing):
(WebCore::RenderEmbeddedObject::viewCleared):
(WebCore::RenderEmbeddedObject::nodeAtPoint):
(WebCore::RenderEmbeddedObject::scroll):

rendering/RenderFlexibleBox.h:

(WebCore::toRenderFlexibleBox):
(WebCore):

rendering/RenderFrame.cpp:

(WebCore::RenderFrame::viewCleared):

rendering/RenderFrameBase.cpp:

(WebCore::RenderFrameBase::layoutWithFlattening):

rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::contentRootRenderer):
(WebCore::RenderIFrame::layoutSeamlessly):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingFrame):

rendering/RenderPart.cpp:

(WebCore::RenderPart::requiresAcceleratedCompositing):
(WebCore::RenderPart::embeddedContentBox):
(WebCore::RenderPart::nodeAtPoint):

rendering/RenderRuby.cpp:

(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
(WebCore::findRubyRunParent):

rendering/RenderTreeAsText.cpp:

(WebCore::write):

rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):
(WebCore::RenderWidget::setOverlapTestResult):
(WebCore::RenderWidget::updateWidgetPosition):

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::frameForNode):
(BlackBerry::WebKit::needsLayoutRecursive):

WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::redirectDataToPlugin):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):

Source/WebKit/chromium:

src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::scrollRect):
(WebKit::WebPluginContainerImpl::setWantsWheelEvents):
(WebKit::WebPluginContainerImpl::handleMouseEvent):

tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::TEST_F):

Source/WebKit/efl:

WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::redirectDataToPlugin):

Source/WebKit/gtk:

WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::redirectDataToPlugin):

Source/WebKit/mac:

WebView/WebRenderNode.mm:

(copyRenderNode):

WebView/WebView.mm:

(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):

Source/WebKit/qt:

WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::redirectDataToPlugin):

Source/WebKit/win:

WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::frameRectsChanged):

WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::redirectDataToPlugin):

Source/WebKit/wince:

WebCoreSupport/FrameLoaderClientWinCE.cpp:

(WebKit::FrameLoaderClientWinCE::redirectDataToPlugin):

Source/WebKit/wx:

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::FrameLoaderClientWx::redirectDataToPlugin):

Source/WebKit2:

Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

10:11 AM Changeset in webkit [145912] by commit-queue@webkit.org

2 edits in trunk

[GTK] acceleration_backend_description does not concatenate "(gles2"
https://bugs.webkit.org/show_bug.cgi?id=112405

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-03-15
Reviewed by Martin Robinson.

In FindDependencies.m4, acceleration_backend_description string does not
concatenate if there is a space between the operator and the operand.

Source/autotools/FindDependencies.m4:

10:07 AM Changeset in webkit [145911] by commit-queue@webkit.org

3 edits
2 adds in trunk

Source/WebCore: [Texmap] REGRESSION (r144190): Failure at style with preserve-3d and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

According to spec, we avoid masking and clipping when preserves-3d is enabled.
However, opacity should still work.
Allowing opacity when preserves-3d is on.

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

Test: compositing/overlap-blending/preserves3d-opacity.html

platform/graphics/texmap/TextureMapperGL.cpp:
platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintRecursive):

LayoutTests: [Texmap] REGRESSION (r144190): Failure at style with webkit-transform and opacity
https://bugs.webkit.org/show_bug.cgi?id=112370

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Caio Marcelo de Oliveira Filho.

New ref-test for opacity+preserves-3d.

compositing/overlap-blending/preserves3d-opacity-expected.html: Added.
compositing/overlap-blending/preserves3d-opacity.html: Added.

9:56 AM Changeset in webkit [145910] by Lucas Forschler

4 edits in tags/Safari-537.34/Source

Versioning

9:51 AM Changeset in webkit [145909] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Get rid of useless forward declaration.
https://bugs.webkit.org/show_bug.cgi?id=112449

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-03-15
Reviewed by Stephen Chenney.

No behavioural change

svg/SVGRectElement.cpp:

9:26 AM Changeset in webkit [145908] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: make CPU profiler show timings using the same time unit [ms]
https://bugs.webkit.org/show_bug.cgi?id=112356

That makes it much easier to compare values when looking at the data.

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-15
Reviewed by Yury Semikhatsky.

inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):

9:24 AM Changeset in webkit [145907] by peter@chromium.org

17 edits in trunk/Source/WebCore

Implement support for nullable types in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=111728

Reviewed by Kentaro Hara.

This patch adds support for nullable types in the bindings
generator, as described in section 3.10.22 of WebIDL:

http://dev.w3.org/2006/webapi/WebIDL/#idl-nullable-type

interface MyInterface {

readonly attribute boolean? value; true, false or null.

};

The IDL Parser has been modified to record whether attributes are
nullable. Question marks from the type will always be stripped
from the domAttribute->signature->type field. Once support for
this has been completely implemented, we'll be able to remove a
bunch of custom bindings, i.e. those of Device Orientation.

Any getter for an attribute which returns a nullable type will be
called with an additional attribute (passed by reference) named
"isNull". This will be the last argument passed to the method,
unless an exception code (ec) argument will be passed as well.

The CPP, GObject and ObjC bindings will not change behavior following
this patch, although they have been modified to call the WebCore
methods for nullable attributes with the correct signature. The
V8 and JS binding generators do have modified behavior, in that they
will actually return v8Null/jsNull when isNull == true.

Tested by existing binding tests and the new nullable attribute
tests in the bindings/scripts/test/ directory.

bindings/scripts/CodeGeneratorCPP.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorGObject.pm:

(GenerateProperty):
(GenerateFunction):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

bindings/scripts/IDLParser.pm:

(typeHasNullableSuffix):
(typeRemoveNullableSuffix):
(parseAttributeRest):
(parseOptionalOrRequiredArgument):
(parseAttributeRestOld):

bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::nullableDoubleAttribute):
(WebDOMTestObj::nullableLongAttribute):
(WebDOMTestObj::nullableBooleanAttribute):
(WebDOMTestObj::nullableStringAttribute):
(WebDOMTestObj::nullableLongSettableAttribute):
(WebDOMTestObj::setNullableLongSettableAttribute):
(WebDOMTestObj::nullableStringValue):
(WebDOMTestObj::setNullableStringValue):

bindings/scripts/test/CPP/WebDOMTestObj.h:
bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
(webkit_dom_test_obj_get_nullable_double_attribute):
(webkit_dom_test_obj_get_nullable_long_attribute):
(webkit_dom_test_obj_get_nullable_boolean_attribute):
(webkit_dom_test_obj_get_nullable_string_attribute):
(webkit_dom_test_obj_get_nullable_long_settable_attribute):
(webkit_dom_test_obj_set_nullable_long_settable_attribute):
(webkit_dom_test_obj_get_nullable_string_value):
(webkit_dom_test_obj_set_nullable_string_value):

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::setJSTestObjNullableLongSettableAttribute):
(WebCore::setJSTestObjNullableStringValue):

bindings/scripts/test/JS/JSTestObj.h:

(WebCore):

bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj nullableDoubleAttribute]):
(-[DOMTestObj nullableLongAttribute]):
(-[DOMTestObj nullableBooleanAttribute]):
(-[DOMTestObj nullableStringAttribute]):
(-[DOMTestObj nullableLongSettableAttribute]):
(-[DOMTestObj setNullableLongSettableAttribute:]):
(-[DOMTestObj nullableStringValue]):
(-[DOMTestObj setNullableStringValue:]):

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetter):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::nullableDoubleAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableBooleanAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableStringAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrGetterCallback):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetterCallback):
(WebCore):

8:37 AM Changeset in webkit [145906] by commit-queue@webkit.org

64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
(JSValueToNative):
(CreateCustomSignature):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):
(WebCore):
(WebCore::V8Float64Array::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionMethod):
(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):
(WebCore):
(WebCore::V8TestActiveDOMObject::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):
(WebCore):
(WebCore::V8TestCustomNamedGetter::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):
(WebCore):
(WebCore::V8TestEventConstructor::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):
(WebCore):
(WebCore::V8TestEventTarget::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore):
(WebCore::V8TestException::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Method):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):
(WebCore):
(WebCore::V8TestInterface::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):
(WebCore):
(WebCore::V8TestMediaQueryListListener::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):
(WebCore):
(WebCore::V8TestNamedConstructor::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):
(WebCore):
(WebCore::V8TestNode::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsMethod):
(WebCore::TestObjV8Internal::longMethodWithArgsMethod):
(WebCore::TestObjV8Internal::objMethodWithArgsMethod):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsMethod):
(WebCore::TestObjV8Internal::overloadedMethod1Method):
(WebCore::TestObjV8Internal::overloadedMethod2Method):
(WebCore::TestObjV8Internal::overloadedMethod8Method):
(WebCore::TestObjV8Internal::overloadedMethodMethod):
(WebCore::TestObjV8Internal::convert1Method):
(WebCore::TestObjV8Internal::convert2Method):
(WebCore::TestObjV8Internal::convert4Method):
(WebCore::TestObjV8Internal::convert5Method):
(WebCore::TestObjV8Internal::variadicNodeMethodMethod):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):
(WebCore):
(WebCore::V8TestObj::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::TestOverloadedConstructorsV8Internal::constructor1):
(WebCore::TestOverloadedConstructorsV8Internal::constructor2):
(WebCore::TestOverloadedConstructorsV8Internal::constructor3):
(WebCore::TestOverloadedConstructorsV8Internal::constructor):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):
(WebCore):
(WebCore::V8TestOverloadedConstructors::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
(WebCore):
(WebCore::V8TestSerializedScriptValueInterface::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):
(WebCore):
(WebCore::V8TestTypedefs::HasInstanceInAnyWorld):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

bindings/v8/V8GCController.cpp:
bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersMethodCustom):
(WebCore::V8WebGLRenderingContext::getProgramParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getShaderParameterMethodCustom):
(WebCore::V8WebGLRenderingContext::getUniformMethodCustom):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:14 AM Changeset in webkit [145905] by commit-queue@webkit.org

64 edits in trunk/Source

Unreviewed, rolling out r145802.
http://trac.webkit.org/changeset/145802
https://bugs.webkit.org/show_bug.cgi?id=112444

This broke Chrome. (Requested by marja on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

bindings/v8/V8Binding.h:

(WebCore::toRefPtrNativeArray):
(WebCore):

bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

bindings/v8/V8GCController.cpp:
bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

bindings/v8/V8PerIsolateData.cpp:

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):

bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

7:05 AM Changeset in webkit [145904] by commit-queue@webkit.org

38 edits in trunk/Source/WebCore

Unreviewed, rolling out r145896.
http://trac.webkit.org/changeset/145896
https://bugs.webkit.org/show_bug.cgi?id=112443

Chrome broken by r145802 and this builds on top of it.
(Requested by marja on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-15

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(WebCore):

bindings/scripts/test/V8/V8TestInterface.cpp:

(TestInterfaceV8Internal):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(WebCore):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(WebCore):

bindings/scripts/test/V8/V8TestObj.cpp:

(TestObjV8Internal):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:

(WebCore):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore):

bindings/v8/DOMDataStore.h:

(DOMDataStore):

bindings/v8/V8DOMConfiguration.cpp:
bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

bindings/v8/custom/V8DOMWindowCustom.cpp:
bindings/v8/custom/V8EventTargetCustom.cpp:
bindings/v8/custom/V8IDBAnyCustom.cpp:
bindings/v8/custom/V8MicroDataItemValueCustom.cpp:
bindings/v8/custom/V8WorkerContextCustom.cpp:

6:52 AM Changeset in webkit [145903] by commit-queue@webkit.org

3 edits
2 deletes in trunk/Source/WebCore

[BlackBerry] Remove PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=112438

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

This class only contains getFontFamilyForCharacters(), which was
moved from PlatformSupport to FontCache in r129257.

This patch does the same for the BlackBerry port.

platform/graphics/FontCache.h:

(FontCache):

platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getFontFamilyForCharacters):
(WebCore):
(WebCore::FontCache::getFontDataForCharacters):

platform/graphics/blackberry/PlatformSupport.cpp: Removed.
platform/graphics/blackberry/PlatformSupport.h: Removed.

6:50 AM Changeset in webkit [145902] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] FontPlatformData: remove TextOrientation parameter
https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-15
Reviewed by Rob Buis.

I forgot to remove the #include "TextOrientation.h" line as
well. This file no longer exists.

platform/graphics/blackberry/FontCustomPlatformData.h:

6:35 AM Changeset in webkit [145901] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

DataGrid should reveal and select next/previous DataGridNode upon deletion of selected node
https://bugs.webkit.org/show_bug.cgi?id=112404

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2013-03-15
Reviewed by Vsevolod Vlasov.

No new tests as this is a UI related change.

While deleting the entries of the data grid by clicking on 'Delete'
status bar button, deletion of selected node should trigger selection of
next possible (backward/forward) DataGridNode.

inspector/front-end/DOMStorageItemsView.js:

(WebInspector.DOMStorageItemsView.prototype._deleteButtonClicked):

inspector/front-end/DataGrid.js:

(WebInspector.DataGrid.prototype._keyDown):
(WebInspector.DataGrid.prototype.changeNodeAfterDeletion):

6:29 AM Changeset in webkit [145900] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Draw timeline grid over flame chart items.
https://bugs.webkit.org/show_bug.cgi?id=112439

Reviewed by Pavel Feldman.

I've used WebInspector.TimelineGrid

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.Calculator):
(WebInspector.FlameChart.Calculator.prototype._updateBoundaries):
(WebInspector.FlameChart.Calculator.prototype.computePosition):
(WebInspector.FlameChart.Calculator.prototype.formatTime):
(WebInspector.FlameChart.Calculator.prototype.maximumBoundary):
(WebInspector.FlameChart.Calculator.prototype.minimumBoundary):
(WebInspector.FlameChart.Calculator.prototype.boundarySpan):
(WebInspector.FlameChart.prototype.update):

5:48 AM Changeset in webkit [145899] by allan.jensen@digia.com

4 edits in trunk

[Qt] Build error with building with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=112435

Reviewed by Noam Rosenthal.

QAccessibleWidget has moved to private.

Source/widgetsapi.pri:

Source/WebKit/qt:

WidgetApi/qwebviewaccessible_p.h:

5:32 AM Changeset in webkit [145898] by jknotten@chromium.org

5 edits in trunk/Source/WebKit/chromium

[Chromium] Compositor is applying scroll offset using 'programmatic' API
https://bugs.webkit.org/show_bug.cgi?id=109712

Reviewed by James Robinson.

Ensure that the compositor uses non-programmatic APIs to scroll and
scale.

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::updateMainFrameScrollPosition):
(WebKit):
(WebKit::WebViewImpl::applyScrollAndScale):

src/WebViewImpl.h:

(WebViewImpl):

tests/WebFrameTest.cpp:
tests/WebViewTest.cpp:

5:21 AM Changeset in webkit [145897] by caseq@chromium.org

3 edits in trunk/LayoutTests

Unreviewed -- remove test expectations for timeline-receive-response-event and remove
another source of flakiness in the test.

inspector/timeline/timeline-receive-response-event.html:
platform/chromium/TestExpectations:

4:45 AM WebKitGTK/2.0.x edited by Philippe Normand

(diff)

4:14 AM Changeset in webkit [145896] by commit-queue@webkit.org

38 edits in trunk/Source/WebCore

[V8] Add machinery for generating specialized bindings for the main world
https://bugs.webkit.org/show_bug.cgi?id=111417

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-15
Reviewed by Kentaro Hara.

The new specialized bindings will be faster, because they don't need to
do the "main world, isolated world or a worker" check, but can right
away assume that we're in the main world.

This patch generates main world bindings for getters and setters.

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetterCallback):
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetterCallback):
(GenerateNormalAttrSetter):
(GenerateNamedConstructor):
(GenerateBatchedAttributeData):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(GenerateCallbackImplementation):
(GenerateFunctionCallString):
(CreateCustomSignature):
(NativeToJSValue):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterForMainWorld):
(TestActiveDOMObjectV8Internal):
(WebCore::TestActiveDOMObjectV8Internal::excitingAttrAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::TestEventConstructorV8Internal::attr1AttrGetterForMainWorld):
(TestEventConstructorV8Internal):
(WebCore::TestEventConstructorV8Internal::attr1AttrGetterCallbackForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterForMainWorld):
(WebCore::TestEventConstructorV8Internal::attr2AttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::TestExceptionV8Internal::nameAttrGetterForMainWorld):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::nameAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterForMainWorld):
(TestInterfaceV8Internal):
(WebCore::TestInterfaceV8Internal::supplementalStaticReadOnlyAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStaticAttrAttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr1AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr2AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalStr3AttrSetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrGetterCallbackForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterForMainWorld):
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterForMainWorld):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::readOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticReadOnlyLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::staticStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enumAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::shortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::longLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::testObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::createAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedStringAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::reflectedCustomURLAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::customAttrAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::cachedAttribute2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::anyAttributeAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterForMainWorld):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::floatArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::doubleArrayAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::contentDocumentAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::mutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::immutablePointAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strawberryAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::strictFloatAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::descriptionAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterForMainWorld):
(WebCore::TestObjV8Internal::idAttrSetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::hashAttrGetterCallbackForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterForMainWorld):
(WebCore::TestObjV8Internal::replaceableAttributeAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterForMainWorld):
(TestSerializedScriptValueInterfaceV8Internal):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::readonlyValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::portsAttrGetterCallbackForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterForMainWorld):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedReadonlyValueAttrGetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterForMainWorld):
(TestTypedefsV8Internal):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithGetterExceptionAttrSetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrGetterCallbackForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterForMainWorld):
(WebCore::TestTypedefsV8Internal::stringAttrWithSetterExceptionAttrSetterCallbackForMainWorld):
(WebCore):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(WebCore::toV8ForMainWorld):
(WebCore):
(WebCore::toV8FastForMainWorld):

bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::getWrapperForMainWorld):
(DOMDataStore):

bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::addToTemplate):
(WebCore):

bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):

bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8EventTargetCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8IDBAnyCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

bindings/v8/custom/V8WorkerContextCustom.cpp:

(WebCore::toV8ForMainWorld):
(WebCore):

4:07 AM Changeset in webkit [145895] by Simon Hausmann

2 edits in trunk/Source/WebKit/qt

[Qt] Unreviewed trivial DRT ASSERT fix

r145805 erroneously added setController calls for device orientation/motion
mock clients. Those ASSERT, the controller ctor already calls setController
on the client.

WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

3:46 AM Changeset in webkit [145894] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. xOffset calculates incorrectly when chart width less that canvas.width.
https://bugs.webkit.org/show_bug.cgi?id=112423

Reviewed by Yury Semikhatsky.

I extracted xOffset assigment procedure into a separate function.

Drive by fix: size and posion of anchor element was adjusted.
Drive by fix: we will not paint item if it is not visible.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._maxXOffset):
(WebInspector.FlameChart.prototype._setXOffset):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype.draw):

3:40 AM Changeset in webkit [145893] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] Change brightness filter to match new spec
https://bugs.webkit.org/show_bug.cgi?id=112422

New filters spec specifies an intercept of 0 instead of 1.
This is already done for the software version in http://trac.webkit.org/changeset/139770.
This patch adjusts the value for the accelerated version.

Patch by Noam Rosenthal <Noam Rosenthal> on 2013-03-15
Reviewed by Allan Sandfeld Jensen.

Filter tests are currently disabled on Qt/GTK/EFL, but they would need to be rebaselined once enabled.

platform/graphics/texmap/TextureMapperShaderProgram.cpp:

3:22 AM Changeset in webkit [145892] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Call release() when a RefPtr is returned.
https://bugs.webkit.org/show_bug.cgi?id=112420

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-15
Reviewed by Eric Seidel.

release() should be called on a RefPtr to convert it to a PassRefPtr.

No new tests needed, no behavior changes.

css/CSSParser.cpp:

(WebCore::CSSParser::parseImageResolution):
(WebCore::CSSParser::parseImageSet):

3:18 AM Changeset in webkit [145891] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Network] InitiatorComparator is not reflexive/antisymmetric.
https://bugs.webkit.org/show_bug.cgi?id=112341

Reviewed by Vsevolod Vlasov.

When both objects do not have initiator: f(a, b) = f(b, a) = -1
Furthermore: redirected responses are mixed with "other".

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
Remember "displayed" initiator type.
(WebInspector.NetworkDataGridNode.InitiatorComparator):
Recall "diaplayed" initiator type for more precise comparison.

3:17 AM Changeset in webkit [145890] by zeno.albisser@digia.com

4 edits in trunk/Tools

[Qt] Remove simple getters and setters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112343

Reviewed by Benjamin Poulain.

The removed functions and boolean members
are being replaced by the implementations in the
generic TestRunner.h.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dumpFrameScrollPosition):
(DumpRenderTree::dumpFramesAsText):
(DumpRenderTree::dump):
(DumpRenderTree::titleChanged):
(DumpRenderTree::dumpDatabaseQuota):
(DumpRenderTree::dumpApplicationCacheQuota):
(DumpRenderTree::statusBarMessage):
(DumpRenderTree::createWindow):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

3:08 AM Changeset in webkit [145889] by caseq@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: show image decode performed off main thread on timeline
https://bugs.webkit.org/show_bug.cgi?id=111159

Reviewed by Pavel Feldman.

add handling of Decode Image event to TimelineTraceEventProcessorr;
only log platform events for the main thread;
extract constants for trace events produced by platform instrumentation.

inspector/InspectorTimelineAgent.cpp:

(TimelineRecordType):

inspector/InspectorTimelineAgent.h:

(TimelineRecordType):

inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onImageDecodeBegin):
(WebCore):
(WebCore::TimelineTraceEventProcessor::onImageDecodeEnd):

inspector/TimelineTraceEventProcessor.h:

(TimelineTraceEventProcessor):

platform/PlatformInstrumentation.cpp:

(WebCore):

platform/PlatformInstrumentation.h:

(PlatformInstrumentation):
(WebCore):
(WebCore::PlatformInstrumentation::willDecodeImage):
(WebCore::PlatformInstrumentation::didDecodeImage):
(WebCore::PlatformInstrumentation::willResizeImage):
(WebCore::PlatformInstrumentation::didResizeImage):

1:38 AM Changeset in webkit [145888] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. When user zooms the chart, the point under cursor has to be the zooming center.
https://bugs.webkit.org/show_bug.cgi?id=112417

Reviewed by Yury Semikhatsky.

It converts the cursor position into time,
changes the scale factor and calculates the new offset for the canvas.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):

1:33 AM Changeset in webkit [145887] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding a failure expectation for the reftest added in r145847

that is failing due to disabled subpixel layout on the GTK port.

1:28 AM Changeset in webkit [145886] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: [Network] Sort columns context menu items alphabetically.
https://bugs.webkit.org/show_bug.cgi?id=112321

Reviewed by Pavel Feldman.

Problem: columns are presented in "natural" order,
so it is hard to find specific item.

inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._getConfigurableColumnIDs):
Generate list of column IDs sorted alphabetically.
(WebInspector.NetworkLogView.prototype._contextMenu):
Use alphabetically sorted list of column IDs.

1:24 AM Changeset in webkit [145885] by tasak@google.com

4 edits
2 adds in trunk

Crash at RenderStyle::inheritFrom reported by fuzzer
https://bugs.webkit.org/show_bug.cgi?id=112322

Reviewed by Hajime Morrita.

Source/WebCore:

pseudoStyleForElement should check whether a parent style of a given
element is available or not. If a given element's parent is
an insertion point whose reset-style-inheritance is true, the parent
style is not available. Need to use defaultStyleForElement.

Test: fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
Removed cloneForParent. Instead, made m_state own parentStyle, i.e.
changed m_parentStyle in class State from RenderStyle* to
RefPtr<RenderStyle>.
(WebCore::StyleResolver::pseudoStyleForElement):
If an actual parent style of a given element is not available, use
defaultStyleForElement. This is the same logic as styleForElement.

css/StyleResolver.h:

(WebCore::StyleResolver::State::setParentStyle):
Modified the parameter to use PassRefPtr<RenderStyle>.
(WebCore::StyleResolver::State::parentStyle):
(State):

LayoutTests:

fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash-expected.txt: Added.
fast/dom/shadow/insertion-point-resetStyleInheritance-with-pseudo-element-crash.html: Added.

1:08 AM Changeset in webkit [145884] by mihnea@adobe.com

3 edits
2 adds in trunk

[CSS Regions] Selecting text inside an empty region causes selection outside the region area
https://bugs.webkit.org/show_bug.cgi?id=107752

Reviewed by David Hyatt.

Source/WebCore:

When performing hit testing inside a flow thread, we need to make sure that
we actually hit some node from the flow thread content and not the flow thread
itself (which would set the hit test result node to the document node, allowing
wrong selection of content outside the empty region).

Test: fast/regions/selecting-text-in-empty-region.html

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):

LayoutTests:

Add test showing that you cannot select content outside a empty region (without flow thread content).

fast/regions/selecting-text-in-empty-region-expected.txt: Added.
fast/regions/selecting-text-in-empty-region.html: Added.

1:06 AM Changeset in webkit [145883] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Texmap] layerRect should be used instead of contents rect for scrollable layer hit tests.
https://bugs.webkit.org/show_bug.cgi?id=112413

Patch by Luiz Agostini <luiz.agostini@nokia.com> on 2013-03-15
Reviewed by Noam Rosenthal.

Using layerRect() instead of m_state.contentsRect for scrollable layer hit test.

platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::scrollableLayerHitTestCondition):

1:04 AM Changeset in webkit [145882] by rniwa@webkit.org

2 edits in trunk/Tools

Update the link on build.webkit.org to refer to perf.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=112416

Reviewed by Philip Rogers.

Updated the link. Also updated the template to use HTML5 DOCTYPE.

BuildSlaveSupport/build.webkit.org-config/templates/root.html:

12:13 AM Changeset in webkit [145881] by commit-queue@webkit.org

2 edits in trunk/Tools

Build fix for Tools/GtkLauncher/Programs_GtkLauncher-main.o if gstreamer is not installed
https://bugs.webkit.org/show_bug.cgi?id=112394

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-15
Reviewed by Philippe Normand.

GtkLauncher/main.c:

(main): Guard using the gstreamer function with #ifdef WTF_USE_GSTREAMER

12:13 AM Changeset in webkit [145880] by mikhail.pozdnyakov@intel.com

7 edits in trunk/Source/WebKit2

[WK2][EFL] Get rid of WebPageProxy::viewWidget() method
https://bugs.webkit.org/show_bug.cgi?id=112289

Reviewed by Alexey Proskuryakov.

Web page should not be aware of platform-specific view.

UIProcess/API/efl/EwkView.cpp:

(wkPageToEvasObjectMap):
(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::toEvasObject):

EwkView::toEvasObject() relies on static map rather than on
removed WebPageProxy::viewWidget() method.

UIProcess/API/efl/EwkView.h:
UIProcess/API/efl/ewk_text_checker.cpp:

(uniqueSpellDocumentTag):

UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::incorporateUpdate):

Now uses EwkView::toEvasObject().

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/efl/WebPageProxyEfl.cpp:

Removed WebPageProxy::viewWidget() method.

Mar 14, 2013:

11:28 PM Changeset in webkit [145879] by Lucas Forschler

4 edits in trunk/Source

Versioning.

11:26 PM Changeset in webkit [145878] by Lucas Forschler

1 copy in tags/Safari-537.34

New Tag.

11:22 PM Changeset in webkit [145877] by dominicc@chromium.org

2 edits in trunk/Source/WebCore

Redundant if statement in RenderTextControlSingleLine::layout should be removed
https://bugs.webkit.org/show_bug.cgi?id=112406

Reviewed by Andreas Kling.

Covered by existing tests added in r145239.

rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::layout):

11:01 PM Changeset in webkit [145876] by commit-queue@webkit.org

3 edits
2 deletes in trunk

Unreviewed, rolling out r145864.
http://trac.webkit.org/changeset/145864
https://bugs.webkit.org/show_bug.cgi?id=112408

should fix XMLDocumentParser instead of CSSDefaultStyleSheet
(Requested by tasak on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-14

Source/WebCore:

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

fast/css/ensure-default-style-sheets-crash-expected.txt: Removed.
fast/css/ensure-default-style-sheets-crash.xhtml: Removed.

10:29 PM Changeset in webkit [145875] by eustas@chromium.org

16 edits in trunk/Source/WebCore

Web Inspector: [DataGrid] Specify columns with array of descriptors.
https://bugs.webkit.org/show_bug.cgi?id=112338

Reviewed by Pavel Feldman.

Currently columns are specified by Object that maps
column identifiers to column descriptors. Iteration order over
Object keys is not guaranteed.

Array should be used to specify column order.

inspector/front-end/DataGrid.js: Change consrtructor parameter type.
inspector/front-end/ApplicationCacheItemsView.js: Adopt changes.
inspector/front-end/CPUProfileView.js: Ditto.
inspector/front-end/CSSSelectorProfileView.js: Ditto.
inspector/front-end/CanvasProfileView.js: Ditto.
inspector/front-end/CookieItemsView.js: Ditto.
inspector/front-end/CookiesTable.js: Ditto.
inspector/front-end/DOMStorageItemsView.js: Ditto.
inspector/front-end/DirectoryContentView.js: Ditto.
inspector/front-end/HeapSnapshot.js: Ditto.
inspector/front-end/HeapSnapshotDataGrids.js: Ditto.
inspector/front-end/IndexedDBViews.js: Ditto.
inspector/front-end/NativeMemorySnapshotView.js: Ditto.
inspector/front-end/NetworkPanel.js: Ditto.
inspector/front-end/ResourceWebSocketFrameView.js: Ditto.

10:26 PM Changeset in webkit [145874] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scrolling by dragging.
https://bugs.webkit.org/show_bug.cgi?id=112346

Reviewed by Yury Semikhatsky.

Drag hander was added. It seems that simple repaint works well.
When the user starts dragging we hide the popover, change offset
and do update for the new canvas image.
Drive by change: Due to new way of scrolling the canvas I changed
the behaiviour of the wheel events. Now wheel scrolls if Shift key pressed
and zooms if not.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._startCanvasDragging):
(WebInspector.FlameChart.prototype._canvasDragging):
(WebInspector.FlameChart.prototype._endCanvasDragging):
(WebInspector.FlameChart.prototype._onMouseWheel):

10:14 PM Changeset in webkit [145873] by hayato@chromium.org

12 edits in trunk

[Shadow Dom]: Non Bubbling events in ShadowDOM dispatch in an incorrect order
https://bugs.webkit.org/show_bug.cgi?id=112214

Reviewed by Dimitri Glazkov.

Source/WebCore:

Fix the order of event dispatching for Shadow DOM.

So far, an event whose event phase should be set to AT_TARGET,
e.g. event at shadow hosts, is dispatched in bubbling phase in the
whole event path. This patch fixed the order of event dispatching
so that an event whose event phase must be set to AT_TARGET phase
is dispatched in capturing phase rather than bubbling phase.

The spec is here:
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/shadow/index.html#event-dispatch

5.5 Event Dispatch says:

When capturing, which entails processing step 3 of the event

dispatch algorithm, the Event eventPhase attribute must return
AT_TARGET if the relative target is same as the node on which
event listeners are invoked

When bubbling, which entails

processing step 6 of the event dispatch algorithm, the event
listeners must not be invoked on a node if it is the same as its
relative target

No new tests. Update existing layout tests.

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEventAtCapturing):
(WebCore::EventDispatcher::dispatchEventAtBubbling):

LayoutTests:

fast/dom/shadow/cppevent-in-shadow-expected.txt:
fast/dom/shadow/cppevent-input-in-shadow-expected.txt:
fast/dom/shadow/events-stopped-at-shadow-boundary-expected.txt:
fast/dom/shadow/shadow-boundary-events-expected.txt:
fast/dom/shadow/shadow-boundary-events.html:
fast/dom/shadow/shadow-dom-event-dispatching-distributed-text-node-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-fallback-nodes-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-non-distributed-nodes-expected.txt:
fast/dom/shadow/shadow-dom-event-dispatching-text-node-in-shadow-root-expected.txt:

9:47 PM Changeset in webkit [145872] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: Chromium TestExpectations cleanup prepared by kbr@

platform/chromium/TestExpectations:

9:25 PM Changeset in webkit [145871] by commit-queue@webkit.org

3 edits
4 adds in trunk

Backspace/delete at start of table cell shouldn't step out of cell
https://bugs.webkit.org/show_bug.cgi?id=35372

Patch by Shezan Baig <Shezan Baig> on 2013-03-14
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make Delete and ForwardDelete commands be no-ops if we are at the first
position or last position of a table cell respectively.

Tests: editing/deleting/backspace-at-table-cell-beginning.html

editing/deleting/forward-delete-at-table-cell-ending.html

editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):

LayoutTests:

editing/deleting/backspace-at-table-cell-beginning-expected.txt: Added.
editing/deleting/backspace-at-table-cell-beginning.html: Added.
editing/deleting/forward-delete-at-table-cell-ending-expected.txt: Added.
editing/deleting/forward-delete-at-table-cell-ending.html: Added.

8:37 PM Changeset in webkit [145870] by commit-queue@webkit.org

9 edits
2 adds in trunk

Clickable area is incorrect for elements with border-radius
https://bugs.webkit.org/show_bug.cgi?id=95373

Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-03-14
Reviewed by Simon Fraser.

Source/WebCore:

As RenderBlock doesn't see rounded rect which comes from border-radius
in nodeAtPoint, the rounded corner seems to have an 'invisible' square
box which catches hits. So we added check on whether hitTestPoint also
intersects the rounded rect when hasBorderRadius is set.

This patch is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

Test: fast/borders/border-radius-position.html

platform/graphics/FloatQuad.cpp:

(WebCore):
(WebCore::lineIntersectsCircle):
(WebCore::FloatQuad::intersectsCircle):
(WebCore::FloatQuad::intersectsEllipse):

platform/graphics/FloatQuad.h:

(FloatQuad):

platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::intersectsQuad):
(WebCore):

platform/graphics/RoundedRect.h:

(RoundedRect):

rendering/HitTestLocation.cpp:

(WebCore::HitTestLocation::intersects):
(WebCore):

rendering/HitTestLocation.h:

(HitTestLocation):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

This test is based on Takashi Sakamoto's work in
https://bugs.webkit.org/show_bug.cgi?id=95373

fast/borders/border-radius-position-expected.txt: Added.
fast/borders/border-radius-position.html: Added.

8:30 PM Changeset in webkit [145869] by akling@apple.com

12 edits in trunk

REGRESSION(r145169): [Mac][WK2] http/tests/security/cross-frame-access-put.html fails.
<http://webkit.org/b/111815>
<rdar://problem/13380145>

Reviewed by Anders Carlsson.

Source/WebKit2:

Call getWindowFrame() to see if the UI client wants to override the window frame before sending
a WindowAndViewFramesChanged message to the web process.
This fixes a glitch in WTR and the Web Inspector where incorrect window frames were being used.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

Tools:

Add PlatformWebView::didInitializeClients() and call it after setting up all the clients
after creating a PlatformWebView. Otherwise, the initial WindowAndViewFramesChanged message
will be sent before there's a UI client set up to adjust the frame with WTR's fake origin.

WebKitTestRunner/PlatformWebView.h:

(PlatformWebView):

WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::didInitializeClients):

LayoutTests:

platform/mac-wk2/TestExpectations:

7:41 PM Changeset in webkit [145868] by commit-queue@webkit.org

8 edits in trunk/LayoutTests

plugins/plugin-clip-subframe.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=112324

Patch by John Bauman <jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Ignore duplicate SetWindow calls with identical arguments. Plugins
will ignore these so they're not a problem, and they can cause
flakiness on mac-wk2.

platform/chromium-linux/plugins/plugin-clip-subframe-expected.txt:
platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
platform/chromium-win/plugins/plugin-clip-subframe-expected.txt:
platform/mac-wk2/plugins/plugin-clip-subframe-expected.txt:
platform/mac/plugins/plugin-clip-subframe-expected.txt:
plugins/plugin-clip-subframe-expected.txt:
plugins/resources/plugin-clip-subframe-iframe.html:

7:18 PM Changeset in webkit [145867] by dominicc@chromium.org

1 edit
6 copies in branches/chromium/1410

[Chromium] Unreviewed, merge r145239.

7:08 PM Changeset in webkit [145866] by Chris Fleizach

3 edits
2 adds in trunk

AX: Crash when removing aria-menu item from DOM
https://bugs.webkit.org/show_bug.cgi?id=112396

Reviewed by Tim Horton.

Source/WebCore:

Prevent nil access to items in the ARIA menu flow when deleting
objects from the DOM.

Test: accessibility/menu-item-crash.html

accessibility/AccessibilityNodeObject.cpp:

(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::menuButtonForMenu):

LayoutTests:

accessibility/menu-item-crash-expected.txt: Added.
accessibility/menu-item-crash.html: Added.

7:02 PM Changeset in webkit [145865] by hayato@chromium.org

6 edits
2 adds in trunk

[Shadow]: left side of ::-webkit-distributed selector not working as expected
https://bugs.webkit.org/show_bug.cgi?id=110825

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make functional pseudo distributed elements work even when a left side element has specifiers.

Test: fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html

css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
Make it call rewriteSpecifiersForShadowDistributed() if required.

(WebCore::CSSParser::rewriteSpecifiersWithElementName):
Updated so that it can generate a correct chain of
CSSParserSelectors even when '::distributed()' is used with an
element, which might be empty, with specifiers.

e.g. When parsing a selector of 'content.content-class::-webkit-distributed(div)', the following happens:

rewriteSpecifiersWithElementName(...) is called with:

elementName is: "content"
specifiers is: [.content-class] -> [::-webkit-distributed]

Looking for a distributed pseudo element in the specifiers and found it at the end of tagHistory chain of the specifiers.

The result of calling specifiers->prependTagSelector(tag) is:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]

rewriteSpecifiersForShadowDistributed() is called with:

specifiers is: [content] -> [.content-class] -> [::-webkit-distributed]
distributedPseudoElementSelector is: [::-webkit-distributed]

An argumentSelector of the distributedPseudoElementSelector is:

argumentSelector is: [div]

Remove the distributed pseudo element selector from the specifiers.

specifiers is: [content] -> [.content-class]

Note that one pseudo-element may appear per complex selector
and the pseudo-element may appear only if the subject of the
selector is the last compound selector in the selector.

Append specifiers to the end of the argument selector with a relation of ShadowDistributed:

argumentSelector is: [div] -(ShadowDistributed)-> [content] -> [.content-class]

Returns the argument selector as a return value.

(WebCore::CSSParser::rewriteSpecifiersForShadowDistributed): As explained.

css/CSSParserValues.cpp:

(WebCore):
(WebCore::CSSParserSelector::findDistributedPseudoElementSelector):

css/CSSParserValues.h:

(CSSParserSelector):
(WebCore::CSSParserSelector::clearTagHistory):

LayoutTests:

fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side-expected.html: Added.
fast/dom/shadow/distributed-pseudo-element-specifiers-in-left-side.html: Added.

6:50 PM Changeset in webkit [145864] by tasak@google.com

3 edits
2 adds in trunk

Crash at CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement reported by fuzzer
https://bugs.webkit.org/show_bug.cgi?id=112328

Reviewed by Dimitri Glazkov.

Source/WebCore:

ensureDefaultStyleSheets should check whether page() is null or not.

Test: fast/css/ensure-default-style-sheets-crash.xhtml

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

LayoutTests:

fast/css/ensure-default-style-sheets-crash-expected.txt: Added.
fast/css/ensure-default-style-sheets-crash.xhtml: Added.

5:52 PM Changeset in webkit [145863] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL][MiniBrowser] Add a search field to the MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=112122

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Kenneth Rohde Christiansen.

Implement a search field to test API ewk_view_text_find() and add a shortcut 'ctrl' + f.

MiniBrowser/efl/main.c:

(_Browser_Window):
(search_box_show):
(search_box_hide):
(on_key_down):
(on_url_changed):
(on_search_field_aborted):
(on_search_field_activated):
(on_search_field_clicked):
(on_search_backward_button_clicked):
(on_search_forward_button_clicked):
(window_create):

5:51 PM Changeset in webkit [145862] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed test expectations update. Expanded suppression.

platform/chromium/TestExpectations:

5:48 PM Changeset in webkit [145861] by jparent@chromium.org

8 edits in trunk/Tools

Cleanup: Remove g_resourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=112305

Reviewed by Dirk Pranke.

Removing another global.

Now, each dashboard creates its own loader, rather than having
a general global one.

Remove usage of g_resourceLoader.isLoadingComplete from
handleLocationChange by ensuring that handleLocationChange is
never called before the loader is done. It was called in two
places before: 1 was from the callback when the loader is done,
so that was obviously true, and the other was from onhashchange,
where it would just return rather than running. Instead, lets
only register the onhashchange handler once the loader is
setup, so the check is no longer necessary.

Remove isLoadingComplete since it is now unused.

Callback for loader is now initializeHistory, rather than just
handleLocationChange which will set up the hashchange handler now.
This will all eventually be moving to a new History object.

TestResultServer/static-dashboards/aggregate_results.html:
TestResultServer/static-dashboards/dashboard_base.js:

(handleLocationChange):
(intializeHistory):
(decompressResults):

TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):

TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/loader_unittests.js:
TestResultServer/static-dashboards/timeline_explorer.html:
TestResultServer/static-dashboards/treemap.html:

5:45 PM Changeset in webkit [145860] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

REGRESSION(r145000): Crash loading arstechnica.com when Safari Web Inspector is open
https://bugs.webkit.org/show_bug.cgi?id=111868

Reviewed by Antti Koivisto.

Don't allow non-local property lookup when the debugger is enabled.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::resolve):

5:10 PM Changeset in webkit [145859] by commit-queue@webkit.org

4 edits in trunk

Build: Remove XSLT option and depend hard on XSLT.
You will now not be able to give --disable-xslt or --enable-xslt
because it is not optional anymore.
https://bugs.webkit.org/show_bug.cgi?id=112368

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-14
Reviewed by Martin Robinson.

Source/autotools/FindDependencies.m4:

Always check for libxslt

Source/autotools/PrintBuildConfiguration.m4:

Removed printing out the value of XSLT

Source/autotools/ReadCommandLineArguments.m4:

Removed reading XSLT options

5:07 PM Changeset in webkit [145858] by kbr@google.com

1 edit
8 adds in trunk/LayoutTests

Unreviewed gardening. Added images for new test.

platform/chromium-mac-lion/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
platform/chromium-mac/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
platform/chromium-win/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.

5:02 PM Changeset in webkit [145857] by jamesr@google.com

20 edits in trunk/LayoutTests

Fix flaky layout tests that rely on setTimeout()s firing after <body> is parsed
https://bugs.webkit.org/show_bug.cgi?id=112306

Reviewed by Eric Seidel.

These tests all rely in one way or another on the body of a setTimeout set in an inline <script> in the <head>
firing after the <body> element is generated by the HTML parser. This is a flaky pattern since the HTML parser
may yield when parsing a </script> or when runnnig out of bytes from the network. In practice, this pattern used
to be not terribly flaky for layout tests loaded from disk unless there was a large GC pause. However, since the
threaded HTML parser yields more frequently when hitting a </script> this flakes more.

These tests were found by identifying layout tests that call setTimeout before the document's body exists by
modifying the code, then intersecting that set with tests that are flaky on the chromium flakiness dashboard.

editing/inserting/insert-text-into-empty-frameset-crash.html:
editing/style/apply-style-crash.html:
fast/block/float/float-originating-line-deleted-crash.html:
fast/block/float/floats-not-cleared-crash.html:
fast/block/line-layout/inline-box-wrapper-crash.html:
fast/css/positioned-in-relative-position-inline-crash.html:
fast/css/user-stylesheet-crash.html:
fast/encoding/script-in-head.html:
fast/forms/textarea-placeholder-relayout-assertion.html:
fast/frames/seamless/seamless-form-get.html:
fast/frames/seamless/seamless-form-post-named.html:
fast/frames/seamless/seamless-window-location-href.html:
fast/frames/seamless/seamless-window-location-replace.html:
fast/inline/update-always-create-line-boxes-full-layout-crash.html:
fast/innerHTML/innerHTML-iframe.html:
fast/js/same-origin-subframe-about-blank.html:
fast/multicol/span/removal-of-multicol-span-crash.html:
fast/text/international/bidi-neutral-in-mixed-direction-run-crash.html:
fast/writing-mode/overhanging-float-legend-crash.html:

4:40 PM May 2013 Meeting edited by benjamin@webkit.org

(diff)

4:33 PM Changeset in webkit [145856] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Check to ensure MultisampleRenderbuffer creation succeeds
https://bugs.webkit.org/show_bug.cgi?id=111780

Patch by Brandon Jones <bajones@google.com> on 2013-03-14
Reviewed by Kenneth Russell.

On OSX systems using AMD graphics chips the allocation of large
Multisample Renderbuffers in Chromium would fail without any indication
of failure. Attempting to draw to the buffer resulted in garbage being
rendered onscreen. This could be reproduced by opening a full-page
WebGL app and pressing (Command + "-") several times. This patch adds an
additional check during DrawingBuffer resize to verify that the resized
buffer is valid.

platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore):
(WebCore::DrawingBuffer::checkBufferIntegrity):
(WebCore::DrawingBuffer::reset):

platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

4:29 PM Changeset in webkit [145855] by danakj@chromium.org

4 edits in trunk/Source

[chromium] Make zoom filter independent of the layer size.
https://bugs.webkit.org/show_bug.cgi?id=112221

Reviewed by Stephen White.

Source/Platform:

Make the zoom filter hold a zoom amount and an inset.

chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::zoomInset):
(WebFilterOperation):
(WebKit::WebFilterOperation::createZoomFilter):
(WebKit::WebFilterOperation::setZoomInset):
(WebKit::WebFilterOperation::WebFilterOperation):

Source/WebKit/chromium:

tests/FilterOperationsTest.cpp:

(WebKit):
(WebKit::TEST):

4:22 PM May 2013 Meeting edited by rniwa@webkit.org

Add "improving wiki pages" as a hackathon (diff)

3:43 PM Changeset in webkit [145854] by enrica@apple.com

6 edits
1 add in trunk

Character orientation should follow UTR50 specs for vertical layout.
https://bugs.webkit.org/show_bug.cgi?id=112213
<rdar://problem/12880943>

Reviewed by Ryosuke Niwa.

Source/WebCore:

platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples
of the additional character ranges that should not be rotated in vertical layout.
Added pixel results.

This patch modifies shouldIgnoreRotation to include all the characters that
should not be rotated sideways in vertical layout according to the UTR50 draft 6
specifications. It also fixes rotation for Emojii.

platform/graphics/FontFastPath.cpp:

(WebCore::shouldIgnoreRotation):
(WebCore::isInRange): Added.

platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Adds the proper transforms to ensure
Emojii also are drawn correctly upright.

LayoutTests:

platform/mac/fast/text/vertical-no-sideways.html: Modified to cover samples

of the additional character ranges that should not be rotated in vertical layout.

platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.png: Added.

3:30 PM Changeset in webkit [145853] by Lucas Forschler

5 edits in branches/safari-534.59-branch/Source

Versioning.

3:30 PM Changeset in webkit [145852] by Lucas Forschler

1 copy in tags/Safari-534.59.6

New Tag.

3:16 PM Changeset in webkit [145851] by Lucas Forschler

16 edits in branches/safari-534.59-branch

Merged r138606. <rdar://problem/13424275>

3:10 PM Changeset in webkit [145850] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed test expectations updates. Suppressed a couple of
failures and adjusted a couple of existing expectations.

platform/chromium/TestExpectations:

3:07 PM HackingGtk edited by Martin Robinson

Cleaned up old information, conglomerated links at the top (diff)

2:54 PM Changeset in webkit [145849] by commit-queue@webkit.org

76 edits in trunk

Add selectTrailingWhitespaceEnabled setting to WebCore::Page
https://bugs.webkit.org/show_bug.cgi?id=109404

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-14
Reviewed by Tony Chang.

Source/WebCore:

Covered by
editing/selection/doubleclick-inline-first-last-contenteditable.html.

page/Settings.cpp:

(WebCore): Configure default value for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled seetings as they are different in
Chromium port depending on the OS.

page/Settings.in: Add new setting.

Source/WebKit/blackberry:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

Api/DumpRenderTreeClient.h:
WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::smartInsertDeleteEnabled):
(WebCore::EditorClientBlackBerry::isSelectTrailingWhitespaceEnabled):

Source/WebKit/chromium:

Use new Page settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled and update API accordingly.

WebSettings API is required by DRT in order to set the proper default
values which are different from browser defaults.

public/WebSettings.h: Add new API to manage smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled settings.

public/WebViewClient.h: Remove API related to smartInsertDeleteEnabled

and selectTrailingWhitespaceEnabled as they will be managed from page
settings from now on.

src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::smartInsertDeleteEnabled):
(WebKit::EditorClientImpl::isSelectTrailingWhitespaceEnabled): Use new
settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

src/WebSettingsImpl.cpp: Implement methods establishing the page

settings.
(WebKit::WebSettingsImpl::setSelectTrailingWhitespaceEnabled):
(WebKit):
(WebKit::WebSettingsImpl::setSmartInsertDeleteEnabled):

src/WebSettingsImpl.h:

(WebSettingsImpl): Implement new API to manage the new settings.

Source/WebKit/efl:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
WebCoreSupport/DumpRenderTreeSupportEfl.h:
WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::smartInsertDeleteEnabled):
(WebCore::EditorClientEfl::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientEfl::EditorClientEfl):

WebCoreSupport/EditorClientEfl.h:

(EditorClientEfl):

Source/WebKit/gtk:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::smartInsertDeleteEnabled):
(WebKit::EditorClient::isSelectTrailingWhitespaceEnabled):
(WebKit::EditorClient::EditorClient):

WebCoreSupport/EditorClientGtk.h:

(EditorClient):

Source/WebKit/mac:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Initialize
settings from NSUserDefaults.
(-[WebView setSelectTrailingWhitespaceEnabled:]):
(-[WebView isSelectTrailingWhitespaceEnabled]):
(-[WebView setSmartInsertDeleteEnabled:]):
(-[WebView smartInsertDeleteEnabled]):

WebView/WebViewData.h:
WebView/WebViewData.mm:

(-[WebViewPrivate init]):

Source/WebKit/qt:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

Remove code related to DRT as it is not needed anymore.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::smartInsertDeleteEnabled):
(WebCore::EditorClientQt::toggleSmartInsertDelete):
(WebCore::EditorClientQt::isSelectTrailingWhitespaceEnabled):
(WebCore::EditorClientQt::EditorClientQt):

WebCoreSupport/EditorClientQt.h:

(EditorClientQt):

Source/WebKit/win:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::smartInsertDeleteEnabled):
(WebEditorClient::isSelectTrailingWhitespaceEnabled):

WebView.cpp:

(WebView::WebView):
(WebView::setSmartInsertDeleteEnabled):
(WebView::smartInsertDeleteEnabled):
(WebView::setSelectTrailingWhitespaceEnabled):
(WebView::isSelectTrailingWhitespaceEnabled):

WebView.h:

(WebView):

Source/WebKit/wince:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::smartInsertDeleteEnabled):
(WebKit::EditorClientWinCE::isSelectTrailingWhitespaceEnabled):

Source/WebKit/wx:

Use new settings for smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled.

WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::smartInsertDeleteEnabled):
(WebCore::EditorClientWx::isSelectTrailingWhitespaceEnabled):

Tools:

Removes all the code related to smartInsertDeleteEnabled and
selectTrailingWhitespaceEnabled settings as they will be managed from
internals from now on.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:

(TestRunner):

DumpRenderTree/blackberry/DumpRenderTree.cpp:

(WebKit):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner::WebTestProxy::didStopLoading):

DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):

DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::applyTo): Set default values for
smartInsertDeleteEnabled and selectTrailingWhitespaceEnabled settings as
Chromium DRT default values are different from Chromium browser.

DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
DumpRenderTree/chromium/WebViewHost.cpp:
DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::resetDefaultsToConsistentValues):

DumpRenderTree/efl/TestRunnerEfl.cpp:
DumpRenderTree/gtk/DumpRenderTree.cpp:

(resetDefaultsToConsistentValues):

DumpRenderTree/gtk/TestRunnerGtk.cpp:
DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/mac/TestRunnerMac.mm:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::WebPage::resetSettings):

DumpRenderTree/qt/TestRunnerQt.cpp:
DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/win/TestRunnerWin.cpp:
DumpRenderTree/wx/TestRunnerWx.cpp:

LayoutTests:

Replace testRunner.setSelectTrailingWhitespaceEnabled by
internals.settings.setSelectTrailingWhitespaceEnabled in tests.

Be sure that trailingWhitespaceEnabled and
selectTrailingWhitespaceEnabled are set to opposite values as they are
mutually exclusive.

editing/deleting/smart-editing-disabled.html:
editing/selection/doubleclick-beside-cr-span.html:
editing/selection/doubleclick-whitespace-crash.html:
editing/selection/doubleclick-whitespace-img-crash.html:
editing/selection/doubleclick-whitespace.html:
editing/selection/script-tests/doubleclick-inline-first-last-contenteditable.js:
editing/spelling/resources/util.js:

(initSpellTest):

editing/spelling/spelling-double-clicked-word-with-underscores.html:
editing/spelling/spelling-double-clicked-word.html:
platform/wk2/TestExpectations: Unflag

editing/selection/doubleclick-inline-first-last-contenteditable.html
as it passes now.

2:14 PM Changeset in webkit [145848] by mhahnenberg@apple.com

11 edits in trunk/Source/JavaScriptCore

Objective-C API: Objective-C functions exposed to JavaScript have the wrong type (object instead of function)
https://bugs.webkit.org/show_bug.cgi?id=105892

Reviewed by Geoffrey Garen.

Changed ObjCCallbackFunction to subclass JSCallbackFunction which already has all of the machinery to call
functions using the C API. Since ObjCCallbackFunction is now a JSCell, we changed the old implementation of
ObjCCallbackFunction to be the internal implementation and keep track of all the proper data so that we
don't have to put all of that in the header, which will now be included from C++ files (e.g. JSGlobalObject.cpp).

API/JSCallbackFunction.cpp: Change JSCallbackFunction to allow subclassing. Originally it was internally

passing its own Structure up the chain of constructors, but we now want to be able to pass other Structures as well.
(JSC::JSCallbackFunction::JSCallbackFunction):
(JSC::JSCallbackFunction::create):

API/JSCallbackFunction.h:

(JSCallbackFunction):

API/JSWrapperMap.mm: Changed interface to tryUnwrapBlock.

(tryUnwrapObjcObject):

API/ObjCCallbackFunction.h:

(ObjCCallbackFunction): Moved into the JSC namespace, just like JSCallbackFunction.
(JSC::ObjCCallbackFunction::createStructure): Overridden so that the correct ClassInfo gets used since we have
a destructor.
(JSC::ObjCCallbackFunction::impl): Getter for the internal impl.

API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::ObjCCallbackFunctionImpl): What used to be ObjCCallbackFunction is now
ObjCCallbackFunctionImpl. It handles the Objective-C specific parts of managing callback functions.
(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::objCCallbackFunctionCallAsFunction): Same as the old one, but now it casts to ObjCCallbackFunction and grabs the impl
rather than using JSObjectGetPrivate.
(JSC::ObjCCallbackFunction::ObjCCallbackFunction): New bits to allow being part of the JSCell hierarchy.
(JSC::ObjCCallbackFunction::create):
(JSC::ObjCCallbackFunction::destroy):
(JSC::ObjCCallbackFunctionImpl::call): Handles the actual invocation, just like it used to.
(objCCallbackFunctionForInvocation):
(tryUnwrapBlock): Changed to check the ClassInfo for inheritance directly, rather than going through the C API call.

API/tests/testapi.mm: Added new test to make sure that doing Function.prototype.toString.call(f) won't result in

an error when f is an Objective-C method or block underneath the covers.

runtime/JSGlobalObject.cpp: Added new Structure for ObjCCallbackFunction.

(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSGlobalObject):
(JSC::JSGlobalObject::objcCallbackFunctionStructure):

2:10 PM Changeset in webkit [145847] by commit-queue@webkit.org

2 edits
2 adds in trunk/LayoutTests

[CSS Exclusions] shape-outside on floats for rounded rectangle shapes
https://bugs.webkit.org/show_bug.cgi?id=100299

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-03-14
Reviewed by Dirk Schulze.

Adding tests for rounded rectangles. The code already supports them,
but that was more of a happy accident. These tests makes it more
likely to stay that way.

fast/exclusions/resources/rounded-rectangle.js:

(xOutset): Function to determine the offset for the outside shape.
(generateShapeOutsideOnFloat): Generate a shape outside on a float.
(generateSimulatedShapeOutsideOnFloat): Simulate a shape outside on a

float using a large number of smaller floats.

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle-expected.html: Added.
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-rectangle.html: Added.

2:05 PM Changeset in webkit [145846] by aestes@apple.com

2 edits in trunk/Source/WebKit2

[WebKit2] Only preprocess sandbox profiles if we're building for the OS X SDK
https://bugs.webkit.org/show_bug.cgi?id=112330

Reviewed by David Kilzer.

We shouldn't preprocess sandbox profiles just because the computer
we're building on is a Mac. We should only do it if we're actually
building for the OS X SDK.

DerivedSources.make: Check if $PLATFORM_NAME is macosx rather than if

$OS is MACOS.

1:56 PM Changeset in webkit [145845] by weinig@apple.com

10 edits in trunk/Source/WebKit2

Support private browsing on a per-page basis
<rdar://problem/11969491>

Reviewed by Timothy Horton.

Adds WKPageSetOverridePrivateBrowsingEnabled and WKPageGetOverridePrivateBrowsingEnabled.

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

UIProcess/API/C/WKPage.cpp:

(WKPageSetOverridePrivateBrowsingEnabled):
(WKPageGetOverridePrivateBrowsingEnabled):

UIProcess/API/C/WKPagePrivate.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setOverridePrivateBrowsingEnabled):

UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::overridePrivateBrowsingEnabled):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::setOverridePrivateBrowsingEnabled):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Pipe through.

1:49 PM Changeset in webkit [145844] by commit-queue@webkit.org

8 edits
4 adds in trunk

[chromium] Short scrollbar has empty track rect even when buttons have no size.
https://bugs.webkit.org/show_bug.cgi?id=102580

Patch by Robert Flack <flackr@chromium.org> on 2013-03-14
Reviewed by James Robinson.

When computing the scrollbar track rect, don't assume the button's height is the track width.

Source/WebCore:

Test: platform/chromium/scrollbars/short-scrollbar.html
Note however that this doesn't expose the bug on any tested platforms and mock scrollbars
don't use ScrollbarThemeChromium.cpp. Manually running this test on linux chromiumos will
show the now present scrollbar track and thumb.

platform/chromium/ScrollbarThemeChromium.cpp:

(WebCore::ScrollbarThemeChromium::trackRect):

LayoutTests:

platform/chromium-linux/fast/forms/basic-textareas-expected.png:
platform/chromium-linux/fast/forms/basic-textareas-quirks-expected.png:
platform/chromium-linux/fast/overflow/overflow-x-y-expected.png:
platform/chromium-linux/fast/parser/open-comment-in-textarea-expected.png:
platform/chromium-linux/fast/replaced/width100percent-textarea-expected.png:
platform/chromium-linux/platform/chromium/scrollbars/short-scrollbar-expected.png: Added.
platform/chromium/scrollbars/short-scrollbar-expected.txt: Added.
platform/chromium/scrollbars/short-scrollbar.html: Added.

1:29 PM Changeset in webkit [145843] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: Show syntax highlight for application/javascript in Resource Preview tab
https://bugs.webkit.org/show_bug.cgi?id=112355

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

No new tests.

Return canonical mimeType in requestContent method of
NetworkRequest.js

inspector/front-end/NetworkRequest.js:

(WebInspector.NetworkRequest.prototype.requestContent):

1:14 PM Changeset in webkit [145842] by mhahnenberg@apple.com

3 edits in trunk/Source/JavaScriptCore

Objective-C API: Nested dictionaries are not converted properly in the Objective-C binding
https://bugs.webkit.org/show_bug.cgi?id=112377

Reviewed by Oliver Hunt.

Accidental reassignment of the root task in the container conversion logic was causing the last
array or dictionary processed to be returned in the case of nested containers.

API/JSValue.mm:

(containerValueToObject):

API/tests/testapi.mm:

1:08 PM Changeset in webkit [145841] by commit-queue@webkit.org

12 edits in trunk

[EFL] Use CROSS_PLATFORM_CONTEXT_MENU
https://bugs.webkit.org/show_bug.cgi?id=111877

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

Source/cmake/OptionsEfl.cmake: add -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebCore:

Now EFL uses the CROSS_PLATFORM_CONTEXT_MENUS
USE flag. This flag provides a full cross-platform
representation of a ContextMenu and a ContextMenuItem.
The embedder can then decide how to show this and neither
WebCore nor WebCore/platform need to know any platform
specific code about the menus, even though they could.

No new tests needed, no behavior changes.

platform/ContextMenu.h:

(ContextMenu):

platform/ContextMenuItem.h:

(WebCore):

platform/PlatformMenuDescription.h:

(WebCore):

platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

Source/WebKit/efl:

Adjust ContextMenuClient to use the CROSS_PLATFORM_CONTEXT_MENUS USE flag
by implementing customizeMenu() instead of getCustomMenuFromDefaultItems()
and by calling coreMenu->items() instead of coreMenu->platformDescription().

WebCoreSupport/ContextMenuClientEfl.cpp:

(WebCore::ContextMenuClientEfl::customizeMenu):

WebCoreSupport/ContextMenuClientEfl.h:

(ContextMenuClientEfl):

ewk/ewk_contextmenu.cpp:

(ewk_context_menu_new):

1:04 PM Changeset in webkit [145840] by jchaffraix@webkit.org

4 edits in trunk/Source/WebCore

[CSS Grid Layout] resolveContentBasedTrackSizingFunctions should iterate over the grid items not the grid tracks
https://bugs.webkit.org/show_bug.cgi?id=112299

Reviewed by Tony Chang.

Our initial implementation would iterate over the grid tracks. This was equivalent as no items were spanning but
once grid items spans, they start to contribute to several grid tracks differently. This change aligns our code
with what the specification does.

One upside of doing a grid items' iteration is that the complexity should be better in all cases as we don't do
a full grid walking (which is potentially quadratic), only some extra grid tracks' iteration (which are linear).

Refactoring, there should be no change in behavior.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Moved the |availableLogicalSpace| update into resolveContentBasedTrackSizingFunctions. This simplifies and consolidate our handling.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
Updated the core loop to iterator over grid items and not grid tracks. This idea is that now resolveContentBasedTrackSizingFunctionsForItems
uses a filtering function to only process the appropriate grid tracks.

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
Updated to filter the grid tracks here (this matches the |TracksForGrowth| spec logic that is merely a filtering function).

rendering/RenderGrid.h:

Added a new typedef and updated resolveContentBasedTrackSizingFunctionsForItems to use it.

rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::hasMinOrMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMinTrackBreadth):
(WebCore::GridTrackSize::hasMinOrMaxContentMaxTrackBreadth):
(WebCore::GridTrackSize::hasMaxContentMaxTrackBreadth):
Added the following filtering function, which matches the values from |TracksForGrowth| in the specification.

12:55 PM Changeset in webkit [145839] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0

Unreviewed. Pre-release version bump.

Source/autotools/Versions.m4: Bump version to 1.11.92 for people

already using the webkit-2.0 branch.

12:42 PM Changeset in webkit [145838] by fpizlo@apple.com

24 edits
9 adds in trunk

JSObject fast by-string access optimizations should work even on the prototype chain, and even when the result is undefined
https://bugs.webkit.org/show_bug.cgi?id=112233

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

Extended the existing fast access path for String keys to work over the entire prototype chain,
not just the self access case. This will fail as soon as it sees an object that intercepts
getOwnPropertySlot, so this patch also ensures that ObjectPrototype does not fall into that
category. This is accomplished by making ObjectPrototype eagerly reify all of its properties.
This is safe for ObjectPrototype because it's so common and we expect all of its properties to
be reified for any interesting programs anyway. A new idiom for adding native functions to
prototypes is introduced, which ought to work well for any other prototypes that we wish to do
this conversion for.

This is a >60% speed-up in the case that you frequently do by-string lookups that "miss", i.e.
they don't turn up anything.

CMakeLists.txt:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
dfg/DFGOperations.cpp:
interpreter/CallFrame.h:

(JSC::ExecState::objectConstructorTable):

jit/JITStubs.cpp:

(JSC::getByVal):

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):

runtime/CommonIdentifiers.h:
runtime/JSCell.cpp:

(JSC::JSCell::getByStringSlow):
(JSC):

runtime/JSCell.h:

(JSCell):

runtime/JSCellInlines.h:

(JSC):
(JSC::JSCell::getByStringAndKey):
(JSC::JSCell::getByString):

runtime/JSGlobalData.cpp:

(JSC):
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

runtime/JSGlobalData.h:

(JSGlobalData):

runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunction):
(JSC):

runtime/JSObject.h:

(JSObject):
(JSC):

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

runtime/ObjectPrototype.cpp:

(JSC):
(JSC::ObjectPrototype::finishCreation):
(JSC::ObjectPrototype::create):

runtime/ObjectPrototype.h:

(ObjectPrototype):

runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::findWithString):

runtime/Structure.h:

(Structure):

runtime/StructureInlines.h:

(JSC::Structure::get):
(JSC):

LayoutTests:

Reviewed by Oliver Hunt.

fast/js/regress/script-tests/string-lookup-hit-identifier.js: Added.

(result):

fast/js/regress/script-tests/string-lookup-hit.js: Added.

(result):

fast/js/regress/script-tests/string-lookup-miss.js: Added.

(result):

fast/js/regress/string-lookup-hit-expected.txt: Added.
fast/js/regress/string-lookup-hit-identifier-expected.txt: Added.
fast/js/regress/string-lookup-hit-identifier.html: Added.
fast/js/regress/string-lookup-hit.html: Added.
fast/js/regress/string-lookup-miss-expected.txt: Added.
fast/js/regress/string-lookup-miss.html: Added.

12:35 PM Changeset in webkit [145837] by Carlos Garcia Campos

1 edit
1 add in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Unreviewed build fix. Add missing file.

UIProcess/API/gtk/WebKitForwardDeclarations.h: Added.

12:18 PM Changeset in webkit [145836] by Carlos Garcia Campos

12 edits
1 delete in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Split WebKitDefines.h in two files.

Reviewed by Gustavo Noronha Silva.

The WebKitDefines.h header has been split moving the forward
declarations specific to the UI process API to a new file
WebKitForwardDeclarations.h. This way we can share the
WebKitDefines.h header and remove the WebKitWebExtensionDefines.h
header used in the web extensions API.

GNUmakefile.list.am:
UIProcess/API/gtk/WebKitContextMenu.h:
UIProcess/API/gtk/WebKitContextMenuItem.h:
UIProcess/API/gtk/WebKitDefines.h:
UIProcess/API/gtk/WebKitDownload.h:
UIProcess/API/gtk/WebKitFindController.h:
UIProcess/API/gtk/WebKitPrintOperation.h:
UIProcess/API/gtk/WebKitURISchemeRequest.h:
UIProcess/API/gtk/WebKitWebView.h:
WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.h:
WebProcess/InjectedBundle/API/gtk/WebKitWebExtensionDefines.h: Removed.
WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:

12:13 PM Changeset in webkit [145835] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r188004. Requested by
"Dana Jansens" <danakj@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-14

DEPS:

12:06 PM Changeset in webkit [145834] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] Gradient: don't use the default setPlatformGradientSpaceTransform()
https://bugs.webkit.org/show_bug.cgi?id=112246

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Xan Lopez.

BlackBerry has its own implementation.

platform/graphics/Gradient.cpp:

(WebCore):

11:52 AM Changeset in webkit [145833] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/qt

[Qt][WK1] REGRESSION(r145784): Blend tests are failing
https://bugs.webkit.org/show_bug.cgi?id=112333

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-03-14
Reviewed by Ryosuke Niwa.

Added code to passed compositing prefence to WebCore.

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):

Api/qwebsettings.h:

11:38 AM Changeset in webkit [145832] by kbr@google.com

2 edits in trunk/LayoutTests

Unreviewed expectations updates for a couple of failing tests.

platform/chromium/TestExpectations:

11:37 AM Changeset in webkit [145831] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[GStreamer] simulateAudioInterruption needs to be guarded by ENABLE(VIDEO)"
https://bugs.webkit.org/show_bug.cgi?id=112358

Guarded with ENABLE(VIDEO) to prevent problems when it is not
enabled.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

11:32 AM Changeset in webkit [145830] by fmalita@chromium.org

15 edits in trunk/Source/WebCore

Tighten up the type bounds for SVGPropertyInfo callback parameters
https://bugs.webkit.org/show_bug.cgi?id=111786

Reviewed by Philip Rogers.

Update SVGPropertyInfo's callbacks to pass SVGElement* parameters instead of void*. This
allows us to perform some ASSERT-based type checking before downcasting in implementors.

To avoid adding virtual methods unused in release builds to the base class (and overrides
in descendants), for subtypes lacking polymorphic type markers (isXXX()) the check is
performed using hasTagName() instead.

The patch is also removing the lookupOrCreateWrapperForAnimatedProperty() SVGPropertyInfo
callback for SVGViewSpec properties, because

a) it doesn't appear to be reachable (SVGViewSpec doesn't have a backing element and
thus cannot have an associated animator)

b) it interferes with the parameter specialization described above (SVGViewSpec does not
inherit from SVGElement)

No new tests, refactoring only.

svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeRequiredFeatures):
(WebCore::SVGElement::synchronizeRequiredExtensions):
(WebCore::SVGElement::synchronizeSystemLanguage):

svg/SVGElement.h:

(SVGElement):

svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

svg/SVGMarkerElement.h:

(SVGMarkerElement):
(WebCore::toSVGMarkerElement):
(WebCore):

svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

svg/SVGPathElement.h:

(SVGPathElement):
(WebCore::toSVGPathElement):
(WebCore):

svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

svg/SVGPolyElement.h:

(SVGPolyElement):
(WebCore::toSVGPolyElement):
(WebCore):

svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):

svg/SVGTextContentElement.h:

(SVGTextContentElement):
(WebCore::toSVGTextContentElement):
(WebCore):
Change SVGPropertyInfo callback params to SVGElement* and replace static casts with
conversion wrappers. Implement conversion wrappers where needed.

svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewBoxPropertyInfo):
(WebCore::SVGViewSpec::preserveAspectRatioPropertyInfo):
(WebCore::SVGViewSpec::transformPropertyInfo):
(WebCore::SVGViewSpec::lookupOrCreateViewBoxWrapper):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::lookupOrCreateTransformWrapper):

svg/SVGViewSpec.h:

(SVGViewSpec):
Remove SVGPropertyInfo-based lookupOrCreate* callbacks and updated the methods' parameters
to SVGViewSpec*. Remove now-unneeded casts.

svg/properties/SVGAnimatedPropertyMacros.h:

(WebCore):

svg/properties/SVGPropertyInfo.h:

(WebCore):
(SVGPropertyInfo):
Update callback declarations.

11:20 AM Changeset in webkit [145829] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Add tools/protoc_wrapper to directories pulled in Chromium-in-WebKit configuration
https://bugs.webkit.org/show_bug.cgi?id=112363

Patch by James Robinson <jamesr@chromium.org> on 2013-03-14
Reviewed by Kenneth Russell.

Chromium r187704 added a reference to this script to src/gpu/gpu.gyp, which we pull in the Chromium-in-WebKit
configuration. This adds the script to DEPS so we can roll past that rev.

DEPS:

10:40 AM Changeset in webkit [145828] by fpizlo@apple.com

5 edits
3 adds in trunk

DFG bytecode parser is too aggressive about getting rid of GetLocals on captured variables
https://bugs.webkit.org/show_bug.cgi?id=112287
<rdar://problem/13342340>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finalizeUnconditionally):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getLocal):

LayoutTests:

fast/js/dfg-captured-var-get-local-expected.txt: Added.
fast/js/dfg-captured-var-get-local.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/dfg-captured-var-get-local.js: Added.

(foo):

10:38 AM Changeset in webkit [145827] by commit-queue@webkit.org

11 edits in trunk/Source

Move platform-specific typedefs to PlatformMenuDescription.h
https://bugs.webkit.org/show_bug.cgi?id=111876

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-03-14
Reviewed by Caio Marcelo de Oliveira Filho.

Source/WebCore:

Cross platform Context Menu platform-specific typedefs fit better
in PlatformMenuDescription.h and should not be part of the classes
ContextMenu and ContextMenuItem. We have also renamed them to
PlatformContextMenu and PlatformContextMenuItem instead of NativeMenu
and NativeMenuItem respectively.

No new tests needed since no behavior has changed.

platform/ContextMenu.h:

(ContextMenu):

platform/ContextMenuItem.h:

(ContextMenuItem):

platform/PlatformMenuDescription.h:

(WebCore):

platform/efl/ContextMenuEfl.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

platform/efl/ContextMenuItemEfl.cpp:

(WebCore::ContextMenuItem::platformContextMenuItem):

platform/win/ContextMenuItemWin.cpp:

(WebCore):
(WebCore::ContextMenuItem::platformContextMenuItem):

platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):

Source/WebKit/win:

Rename NativeMenuItem to PlatformContextMenuItem and the getter
function call.

WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::customizeMenu):
(WebContextMenuClient::contextMenuItemSelected):

WebView.cpp:

(WebView::handleContextMenuEvent):

10:27 AM Changeset in webkit [145826] by jer.noble@apple.com

18 edits in trunk/Source/WebCore

Crash in DumpRenderTree at com.apple.WebCore: WebCore::CaptionUserPreferences::captionPreferencesChanged + 185
https://bugs.webkit.org/show_bug.cgi?id=112051

Reviewed by Eric Carlson.

No new tests; fixes a crash during media/video-controls-captions-trackmenu.html.

Instead of relying on a registration system which can fail when an element's document does not have a page,
Elements will register for captionPreferencesChanged() notifications directly with their owning Document.
CaptionUserPreferences, in turn, will notify all Documents in its PageGroup, rather than only directly
registered listeners.

dom/Document.cpp:

(WebCore::Document::registerForCaptionPreferencesChangedCallbacks): Added. Notify the CaptionUserPreferences that someone

is interested in captionPreferencesChanged notfications.

(WebCore::Document::unregisterForCaptionPreferencesChangedCallbacks): Added.
(WebCore::Document::captionPreferencesChanged): Added. Pass to all registered elements.

dom/Document.h:
dom/Element.h:

(WebCore::Element::captionPreferencesChanged): Added. Empty; intended

to be overridden by subclasses.

history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage): Initialize m_needsCaptionPreferenceChanged member.
(WebCore::CachedPage::restore): Call captionPreferencesChanged() if necessary.

history/CachedPage.h:

(WebCore::CachedPage::markForCaptionPreferencesChanged): Set the m_needsCaptionPreferenceChanged member.

history/PageCache.cpp:

(WebCore::PageCache::markPagesForCaptionPreferencesChanged): Pass to every CachedPage.

history/PageCache.h:
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Register with the Document.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Unregister with same.
(WebCore::HTMLMediaElement::attach): Remove previous registration call.

html/HTMLMediaElement.h:
page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the

PageGroup.

page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setInterestedInCaptionPreferenceChanges):

Empty; intended to be overridden by subclasses.

page/CaptionUserPreferencesMac.h:
page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::setInterestedInCaptionPreferenceChanges):

Renamed from registerForPreferencesChangedCallbacks().

(WebCore::CaptionUserPreferencesMac::captionPreferencesChanged):

Replace call to havePreferenceChangeListeners() with m_listeningForPreferenceChanges.

page/Page.cpp:

(WebCore::Page::captionPreferencesChanged):

Pass to every contained Document.

page/Page.h:
page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::captionPreferencesChanged): Pass to the PageGroup.

page/CaptionUserPreferences.h:
page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferencesChanged): Pass to every page, as well as pages in the PageCache.

page/PageGroup.h:

10:11 AM Changeset in webkit [145825] by tdanderson@chromium.org

1 edit in branches/chromium/1410/LayoutTests/platform/chromium/TestExpectations

Merge 144700 "Unreviewed gardening."

Just merged https://codereview.chromium.org/12817006/ into the 26 milestone. I am also
merging this in order to suppress two test failures on chromium-mac. These tests are
no cause for concern (since chromium-mac does not use the scrolling code I have
changed) and these will be given new baselines in a future milestone. See
https://code.google.com/p/chromium/issues/detail?id=174255

Unreviewed gardening.

platform/chromium/TestExpectations: touch-gesture-noscroll-body-* are failing on mac.

TBR=tdanderson@chromium.org
Review URL: https://codereview.chromium.org/12870005

10:08 AM Changeset in webkit [145824] by dgrogan@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Histogram leveldb open errors.
https://bugs.webkit.org/show_bug.cgi?id=112307

Reviewed by Tony Chang.

No new tests, I don't know if there's a good way to test histograms.

platform/leveldb/LevelDBDatabase.cpp:

(WebCore::LevelDBDatabase::open):

10:06 AM Changeset in webkit [145823] by caseq@chromium.org

2 edits in trunk/LayoutTests

Unreviewed flakiness fix following r145727: filter out coalescing records while dumping timeline record structure.

inspector/timeline/timeline-receive-response-event.html:

10:01 AM Changeset in webkit [145822] by robert@webkit.org

2 edits in trunk/Source/WebCore

REGRESSION(r145305) Performance: 1.3% mac-release-10.6-webkit-latest/intl2/times/t change after rev 145300
https://bugs.webkit.org/show_bug.cgi?id=112125

Reviewed by Julien Chaffraix.

When detecting cases where a loaded image may need to move up into the padding created by the row's baseline
we don't need to do anything if the row doesn't have a baseline yet.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::layout):

9:55 AM Changeset in webkit [145821] by tdanderson@chromium.org

12 edits
12 copies in branches/chromium/1410

Merge 144519 "EventHandler::handleGestureScrollUpdate() should i..."

EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html

fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
fast/events/touch/gesture/touch-gesture-noscroll-body.html

page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):

By calling this function at the start of handleGestureScrollUpdate() in the case
where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
can still scroll the page itself, if possible.

(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):

page/EventHandler.h:
(EventHandler):

platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
fast/events/touch/gesture/touch-gesture-scroll-page.html:

I modified this layout test in order to add test coverage for another bug
which is fixed by this patch: if the hit test performed on a GestureScrollBegin
does not target a specific node, the subsequent GestureScrollUpdate events should
still attempt to scroll the page itself. This is consistent with how mousewheel
events behave.

platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.

These four new layout tests verify that a non-scrollable body will not scroll,
as reported in https://bugs.webkit.org/show_bug.cgi?id=109316.

TBR=tdanderson@chromium.org
Review URL: https://codereview.chromium.org/12817006

9:28 AM Changeset in webkit [145820] by beidson@apple.com

12 edits in trunk/Source/WebCore

Add a mode to ResourceLoader that takes SharedBuffers instead of raw pointers and lengths.
<rdar://problem/13416953> and https://bugs.webkit.org/show_bug.cgi?id=112310

Reviewed by Andy Estes.

No new tests (No independently testable change in behavior).

Many of the tested platforms deliver data buffers to their ResourceHandles from objects
that encapsulate a data buffer such as NSData (Mac), CFDataRef (CF), or QByteArray (qt).

If those platforms also augmented SharedBuffer to wrap their native object (which Mac/CF do)
and there existed ResourceLoader callbacks to take that SharedBuffer instead of char* + length,
then many resource loads could avoid a useless copy.

At least on Mac, there are some extremely important behind-the-scenes optimizations for NS/CFData
that will be a more important win than simply avoiding a copy.

This patch adds that SharedBuffer-based callback with the hope that all platforms could find a
way to use a buffer-encapsulating object going forward, and we could therefore deprecate the
char* + length version of didReceiveData.

platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didReceiveBuffer): Add a didReceiveBuffer callback that takes

a SharedBuffer object. The default implementation passes raw bytes + length to didReceiveData.

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::addDataOrBuffer): Replacing addData(), optionally adding the data from

either a data+length or SharedBuffer

(WebCore::ResourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::ResourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

loader/ResourceLoader.h: Add OVERRIDE to all of the ResourceHandleClient methods to help catch future mistakes. Remove "virtual" from methods that didn't need it. Make "addData" into "addDataOrBuffer" and make it private.

loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::NetscapePlugInStreamLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data.

loader/NetscapePlugInStreamLoader.h:

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveBuffer): Pipe to didReceiveDataOrBuffer.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Single chokepoint for receiving data. Also,

rely on ResourceLoader's base implementation for notifying the ResourceLoadNotifier.

loader/SubresourceLoader.h:

loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::append): Add a mode that appends a SharedBuffer.

loader/ResourceBuffer.h:

platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData): Fix a bug where appending data to a CFData-backed

SharedBuffer would re-enter maybeTransferPlatformData and blow out the stack.

platform/network/mac/ResourceHandleMac.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): Send a wrapped NSData

to didReceiveBuffer() instead of sending its char* and length to didReceiveData()

9:14 AM Changeset in webkit [145819] by yurys@chromium.org

7 edits in trunk/Source/WebCore

Web Inspector: nuke bottom up CPU profile calculation on backend
https://bugs.webkit.org/show_bug.cgi?id=112351

Reviewed by Pavel Feldman.

Removed code that builds bottom-up CPU profile on the inspector
backend. Bottom-up view is already built on the front-end from
the top-down profile data.

bindings/js/ScriptProfile.cpp:
bindings/js/ScriptProfile.h:

(ScriptProfile):

bindings/v8/ScriptProfile.cpp:

(WebCore::ScriptProfile::buildInspectorObjectForHead):

bindings/v8/ScriptProfile.h:

(ScriptProfile):

inspector/Inspector.json:
inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::getCPUProfile):

9:08 AM Changeset in webkit [145818] by inferno@chromium.org

88 edits in trunk/Source

Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112296

Reviewed by Kentaro Hara.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttribute):
(WebCore::AccessibilityObject::getAttribute):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
(WebCore::AccessibilityRenderObject::titleUIElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::accessKey):
(WebCore::AccessibilityRenderObject::setElementAttributeValue):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::activeDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::correspondingLabelForControlElement):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
(WebCore::AccessibilityRenderObject::setAccessibleName):
(WebCore::AccessibilityRenderObject::stringRoleForMSAA):

bindings/gobject/WebKitDOMBinding.cpp:

(WebKit::createWrapper):

bindings/js/JSClipboardCustom.cpp:

(WebCore::JSClipboard::setDragImage):

bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8ElementCustom.cpp:

(WebCore::wrap):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::wrap):

dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::recalcStyle):
(WebCore::Document::setFocusedNode):
(WebCore::Document::updateFocusAppearanceTimerFired):

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

dom/Element.cpp:

(WebCore::Element::offsetParent):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::recalcStyle):
(WebCore::Element::computeInheritedLanguage):
(WebCore::Element::lastElementChild):

dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::normalize):
(WebCore::Node::rootEditableElement):
(WebCore::Node::isDefaultNamespace):
(WebCore::Node::ancestorElement):
(WebCore::appendAttributeDesc):

dom/Position.cpp:

(WebCore::Position::element):

dom/Range.cpp:

(WebCore::Range::getBorderAndTextQuads):

dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::queryFirst):
(WebCore::SelectorDataList::execute):

dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):

dom/StaticHashSetNodeList.cpp:

(WebCore::StaticHashSetNodeList::namedItem):

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
(WebCore::ApplyStyleCommand::surroundNodeRangeWithElement):

editing/Editor.cpp:

(WebCore::Editor::applyEditingStyleToBodyElement):

editing/FrameSelection.cpp:

(WebCore::removingNodeRemovesPosition):

editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentParagraph):

editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::entityMaskForText):
(WebCore::MarkupAccumulator::appendStartMarkup):
(WebCore::MarkupAccumulator::appendEndMarkup):

editing/ModifySelectionListLevel.cpp:

(WebCore::IncreaseSelectionListLevelCommand::doApply):

editing/ReplaceSelectionCommand.cpp:

(WebCore::haveSameTagName):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::doApply):

editing/SplitTextNodeContainingElementCommand.cpp:

(WebCore::SplitTextNodeContainingElementCommand::doApply):

editing/TextIterator.cpp:

(WebCore::TextIterator::advance):

editing/htmlediting.cpp:

(WebCore::unsplittableElementForPosition):
(WebCore::enclosingTableCell):

editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::wrapWithNode):
(WebCore::createMarkupInternal):
(WebCore::createFragmentFromMarkupWithContext):
(WebCore::isPlainTextMarkup):
(WebCore::createFragmentFromText):

html/HTMLElement.cpp:

(WebCore::HTMLElement::insertAdjacentElement):
(WebCore::contextElementForInsertion):

html/HTMLFormControlElement.cpp:

(WebCore::focusPostAttach):
(WebCore::updateFromElementCallback):

html/HTMLFormElement.cpp:

(WebCore::submitElementFromEvent):

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshotInfo):

html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::addRange):

html/parser/HTMLTreeBuilder.cpp:

(WebCore::closestFormAncestor):

html/shadow/MediaControlElementTypes.cpp:

(WebCore::toParentMediaElement):

html/shadow/TextFieldDecorationElement.h:

(WebCore::toTextFieldDecorationElement):

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::createDigest):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::didInvalidateStyleAttr):

inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

mathml/MathMLElement.h:

(WebCore::toMathMLElement):

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

page/DragController.cpp:

(WebCore::elementUnderMouse):
(WebCore::DragController::startDrag):

page/FocusController.cpp:

(WebCore::FocusController::advanceFocusInDocumentOrder):

page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

page/FrameView.cpp:

(WebCore::FrameView::updateWidget):

page/SpatialNavigation.cpp:

(WebCore::rectToAbsoluteCoordinates):

page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::sendTransitionEvent):

page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::sendAnimationEvent):

platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaFullscreenButton):
(WebCore::RenderThemeEfl::paintMediaMuteButton):

rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):

svg/SVGUseElement.cpp:

(WebCore::isDisallowedElement):

svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

xml/XPathStep.cpp:

(WebCore::XPath::nodeMatchesBasicTest):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parseEndElement):

Source/WebKit/blackberry:

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setNodeFocus):
(BlackBerry::WebKit::WebPagePrivate::adjustFullScreenElementDimensionsIfNeeded):

WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):

WebKitSupport/BackingStoreClient.cpp:

(BlackBerry::WebKit::BackingStoreClient::absoluteRect):

WebKitSupport/DOMSupport.cpp:

(BlackBerry::WebKit::DOMSupport::toTextControlElement):
(BlackBerry::WebKit::DOMSupport::selectionContainerElement):

WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getRelevantInfoFromCachedHitTest):
(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::willOpenPopupForNode):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):

WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::elementForTapHighlight):

Source/WebKit/chromium:

src/WebDocument.cpp:

(WebKit::WebDocument::images):

src/WebElement.cpp:

(WebKit::WebElement::operator PassRefPtr<Element>):

src/WebPageSerializer.cpp:

(WebCore::retrieveResourcesForFrame):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setFocus):
(WebKit::WebViewImpl::clearFocusedNode):
(WebKit::WebViewImpl::scrollFocusedNodeIntoView):
(WebKit::WebViewImpl::scrollFocusedNodeIntoRect):

Source/WebKit/gtk:

webkit/webkitwebview.cpp:

(webkit_web_view_query_tooltip):

Source/WebKit/mac:

WebCoreSupport/WebFrameLoaderClient.mm:

(applyAppleDictionaryApplicationQuirkNonInlinePart):

WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/qt:

Api/qwebelement.cpp:

(QWebElement::firstChild):
(QWebElement::lastChild):
(QWebElement::nextSibling):
(QWebElement::previousSibling):
(QWebElementCollection::at):
(QWebElementCollection::toList):

WebCoreSupport/QWebFrameAdapter.cpp:

(QWebHitTestResultPrivate::elementForInnerNode):

Source/WebKit/win:

WebView.cpp:

(WebView::enterFullscreenForNode):

Source/WebKit2:

WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::elementBounds):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

9:02 AM Changeset in webkit [145817] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: chromium expectations updated.

platform/chromium/TestExpectations:

8:50 AM Changeset in webkit [145816] by pfeldman@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: keep deprecated function stubs in InspectorFrontendHost.
https://bugs.webkit.org/show_bug.cgi?id=112347

Reviewed by Vsevolod Vlasov.

In order to open older front-ends in newer hosts, we need to keep stubs
for deprecated functions. Longer term, we need to wrap all calls to InspectorFrontendHost in the front-end.

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::canInspectWorkers):
(WebCore):
(WebCore::InspectorFrontendHost::hiddenPanels):

inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:

8:31 AM Changeset in webkit [145815] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Fixed styles pane visibility when docked to right.
https://bugs.webkit.org/show_bug.cgi?id=112348

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-14
Reviewed by Pavel Feldman.

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype._splitVertically):

inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarTabbedPane.prototype.addPane):

8:25 AM Changeset in webkit [145814] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] GraphicsContext3D: implement ImageExtractor::extractImage()
https://bugs.webkit.org/show_bug.cgi?id=112242

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

In r136282 GraphicsContext3D::getImageData() was refactored in a
new class called ImageExtractor.

This patch implements the necessary changes for the BlackBerry
port, which is still using the old API.

platform/graphics/GraphicsContext3D.h:

(ImageExtractor):

platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

8:18 AM Changeset in webkit [145813] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Disable DRT on Windows

Reviewed by Jocelyn Turcotte.

We don't run and maintain DRT on Windows, so let's not try to maintain the build of it.

qmake/mkspecs/features/configure.prf:

8:15 AM Changeset in webkit [145812] by commit-queue@webkit.org

14 edits
6 adds in trunk

[EFL][WK2] Add an API for adding and removing user style sheets from a page group
https://bugs.webkit.org/show_bug.cgi?id=110728

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-03-14
Reviewed by Gyuyoung Kim.

Source/WebKit2:

This patch implements EwkPageGroup API to provide the interface of WKPageGroup. Using the EwkPageGroup,
applications may create the views with a page group for the specific identifier. Also, this patch
encapsulates the APIs WKPageGroupAddUserStyleSheet and WKPageGroupRemoveAllUserStyleSheets behind
the EwkPageGroup class for adding and removing user style sheets from a page group. WKArrayCreateWithEinaList()
is added as a generic WKArray creation API from Eina_List.

PlatformEfl.cmake:
UIProcess/API/C/efl/WKView.cpp:

(createWKView):

UIProcess/API/efl/EWebKit2.h:
UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::createEvasObject):

UIProcess/API/efl/EwkView.h:

(EwkView::ewkPageGroup):
(EwkView):

UIProcess/API/efl/ewk_view.cpp:

(ewk_view_smart_add):
(ewk_view_page_group_get):

UIProcess/API/efl/ewk_view.h:
UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:

(EWK2UnitTest::EWK2UnitTestBase::SetUp):

UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:

(EWK2UnitTest::EWK2UnitTestBase::setWebView):

UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Tools:

Use the page group to create the view object.

MiniBrowser/efl/main.c:

(window_create):

7:39 AM Changeset in webkit [145811] by commit-queue@webkit.org

13 edits
2 adds in trunk

[GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Source/WebCore:

React to REQUEST_STATE GStreamer message to stop the pipeline when
a higher priority stream is played. When this happens, states are
updated accordingly.

A method was added in the MediaPlayer class and internals to allow
the the test runner to simulate an audio interruption.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Test: media/media-higher-prio-audio-stream.html

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayer.cpp:

platform/graphics/MediaPlayerPrivate.h:

(MediaPlayerPrivateInterface):
(WebCore::MediaPlayerPrivateInterface::simulateAudioInterruption):
Added default empty method in the common private header.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer): Added new method and attribute.

testing/Internals.h:
testing/Internals.idl:
testing/Internals.cpp:

(WebCore):
(WebCore::Internals::simulateAudioInterruption): Added to call the
method to stop the element because of a higher prio stream at the
tests.

LayoutTests:

Created test, expected result and updated other ports
expectations.

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

media/media-higher-prio-audio-stream-expected.txt: Added.
media/media-higher-prio-audio-stream.html: Added.
platform/chromium/TestExpectations: Skipped the new test.
platform/mac/TestExpectations: Skipped the new test.
platform/qt/TestExpectations: Skipped the new test for Mac and

Win.

7:28 AM WebKitGTK/2.0.x edited by Philippe Normand

(diff)

7:04 AM Changeset in webkit [145810] by allan.jensen@digia.com

3 edits in trunk/Source/WebCore

[Qt] Add support for tiled shadow blur
https://bugs.webkit.org/show_bug.cgi?id=90082

Reviewed by Noam Rosenthal.

Use the optimized ShadowBlur::drawRectShadow as long as we do not
have a rotating transform. Such a transform would go through the
slow path in ShadowBlur anyway, and would end up using a transformed
TransparencyLayer with an alphaMap which causes scaling artifacts
for us.

Tested by fast/canvas/canvas-scale-fillRect-shadow.html
and fast/canvas/canvas-transforms-fillRect-shadow.html

platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawInsetShadowWithTiling):

Handle scaling transforms when shadows ignore transforms.

(WebCore::ShadowBlur::drawRectShadowWithTiling):

Ditto.

platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::fillRect):

6:59 AM Changeset in webkit [145809] by caseq@chromium.org

8 edits in trunk/Source/WebCore

Web Inspector: do not aggregate non-main thread timeline events, handle them in a generic fashion
https://bugs.webkit.org/show_bug.cgi?id=112172

Reviewed by Vsevolod Vlasov.

build nested event trees for non-main thread events similar to how it's done on the main thread;
drop aggregation logic for Rasterize events;
extract time conversion logic so that it may be reused in TimelineTraceEventProcessor.

English.lproj/localizedStrings.js: drive-by: drop duplicate line.
inspector/InspectorTimelineAgent.cpp:

(WebCore::TimelineTimeConverter::reset):
(WebCore):
(WebCore::InspectorTimelineAgent::pushGCEventRecords):
(WebCore::InspectorTimelineAgent::start):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::appendRecord):
(WebCore::InspectorTimelineAgent::sendEvent):
(WebCore::InspectorTimelineAgent::timestamp):

inspector/InspectorTimelineAgent.h:

(TimelineTimeConverter):
(WebCore::TimelineTimeConverter::TimelineTimeConverter):
(WebCore::TimelineTimeConverter::fromMonotonicallyIncreasingTime):
(WebCore):
(InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::timeConverter):

inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createBackgroundRecord):
(WebCore):

inspector/TimelineRecordFactory.h:

(TimelineRecordFactory):

inspector/TimelineTraceEventProcessor.cpp:

(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineRecordStack::addScopedRecord):
(WebCore::TimelineRecordStack::closeScopedRecord):
(WebCore::TimelineRecordStack::addInstantRecord):
(WebCore::TimelineRecordStack::isOpenRecordOfType):
(WebCore::TimelineRecordStack::send):
(WebCore::TimelineTraceEventProcessor::TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::onBeginFrame):
(WebCore::TimelineTraceEventProcessor::onRasterTaskBegin):
(WebCore::TimelineTraceEventProcessor::onRasterTaskEnd):
(WebCore::TimelineTraceEventProcessor::createRecord):

inspector/TimelineTraceEventProcessor.h:

(TimelineRecordStack):
(WebCore::TimelineRecordStack::Entry::Entry):
(Entry):
(WebCore::TimelineRecordStack::TimelineRecordStack):
(WebCore):
(WebCore::TimelineTraceEventProcessor::TimelineThreadState::TimelineThreadState):
(TimelineThreadState):
(TimelineTraceEventProcessor):
(WebCore::TimelineTraceEventProcessor::TraceEvent::TraceEvent):
(WebCore::TimelineTraceEventProcessor::TraceEvent::isNull):
(WebCore::TimelineTraceEventProcessor::threadState):

6:56 AM Changeset in webkit [145808] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Wrong ASSERT in AudioDestinationGstreamer::stop
https://bugs.webkit.org/show_bug.cgi?id=112344

Patch by Xan Lopez <xlopez@igalia.com> on 2013-03-14
Reviewed by Philippe Normand.

Correct erroneous ASSERT, we want both member variables to exist.

platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::AudioDestinationGStreamer::stop):

6:36 AM Changeset in webkit [145807] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Support scroll and zoom with help of mouse wheel.
https://bugs.webkit.org/show_bug.cgi?id=112337

Reviewed by Yury Semikhatsky.

New member variable _xOffset were introduced.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._adjustXOffset):
(WebInspector.FlameChart.prototype._adjustXScale):
(WebInspector.FlameChart.prototype._onMouseWheel):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):
(WebInspector.FlameChart.prototype._scheduleUpdate):
(WebInspector.FlameChart.prototype.update):

5:58 AM BadContent edited by zandobersek@gmail.com

Blacklist a spamming account. (diff)

5:29 AM Changeset in webkit [145806] by kbalazs@webkit.org

3 edits in trunk/Source/WebCore

[Texmap] Synchronize layers only if the layer has been changed.
https://bugs.webkit.org/show_bug.cgi?id=112095

Patch by No'am Rosenthal <Noam Rosenthal> on 2013-03-14
Reviewed by Allan Sandfeld Jensen.

A regression was introduced in r144787, causing an infinite IPC commitState/renderNextFrame
loop.
This patch fixes this by making sure we only commit layer states that have actual pending
changes.

No new tests, this is an optimization.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(CoordinatedGraphicsLayerState):
(WebCore::CoordinatedGraphicsLayerState::hasPendingChanges):

4:52 AM Changeset in webkit [145805] by Simon Hausmann

23 edits in trunk

[Qt] Improve the handling of mock geolocation, device orientation and motion clients

Reviewed by Tor Arne Vestbø.

The mock versions of these web facing features should be instantiated when
running in DumpRenderTree only. In order for them to work, no extra Qt modules
such as QtLocation are actually needed.

This patch decouples enabling device orientation/motion and geolocation from
the underlying Qt modules and makes them available in developer builds
(!production_build) and backed by mock backends when running in drt.

So if the Qt 5 modules are available, they'll be used (unless drtRun). For
developers the web facing features are always enabled (although requests will
time out) and the mock backends are enabled inside DRT, allowing for the layout
tests to run with less dependencies.

In addition this also enables the mock device motion client, which was
previously never instantiated.

Source/widgetsapi.pri:

Source/WebCore:

Target.pri:
WebCore.pri:

Source/WebKit:

WebKit1.pri:
WebKit1.pro:

Source/WebKit/qt:

WebCoreSupport/QWebFrameAdapter.cpp:

(QWebFrameAdapter::_q_orientationChanged):

WebCoreSupport/QWebFrameAdapter.h:
WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::initializeWebCorePage):

WebCoreSupport/QWebPageAdapter.h:
WidgetApi/qwebframe.cpp:

(QWebFrame::QWebFrame):

WidgetApi/qwebpage.cpp:

(QWebPage::setFeaturePermission):

Source/WebKit2:

Target.pri:
UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

UIProcess/qt/WebGeolocationProviderQt.cpp:
WebKit2.pri:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

Tools:

qmake/mkspecs/features/features.prf:

4:46 AM Changeset in webkit [145804] by zeno.albisser@digia.com

4 edits in trunk/Tools

[Qt] Removing no-ops and simple setters/getters from TestRunnerQt
https://bugs.webkit.org/show_bug.cgi?id=112340

Reviewed by Simon Hausmann.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::dump):

Replace shouldDumpBackForwardList() with TestController:dumpBackForwardList().

(DumpRenderTree::dumpApplicationCacheQuota):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

4:26 AM Changeset in webkit [145803] by allan.jensen@digia.com

2 edits in trunk/Source/WebCore

[TexMap] Painting into area of composited tile not cleared
https://bugs.webkit.org/show_bug.cgi?id=112268

Reviewed by Kenneth Rohde Christiansen.

Clip painting to the area that has been cleared, so we
do not accidentally overpaint other areas.

Can be observed in ManualTests/scrollbars/scrollbars-in-composited-layers.html.

platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::updateContents):

4:12 AM Changeset in webkit [145802] by commit-queue@webkit.org

64 edits in trunk/Source

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-14
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

Source/WebCore:

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooMethod):
(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventMethod):
(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::TestTypedefsV8Internal::funcMethod):
(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

bindings/v8/SerializedScriptValue.cpp:
bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

bindings/v8/V8Binding.h:

(WebCore):
(WebCore::toRefPtrNativeArray):

bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

bindings/v8/V8GCController.cpp:
bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

bindings/v8/V8PerIsolateData.cpp:

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAttrSetterCustom):

bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCustom):

bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):

bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageMethodCustom):

bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesMethodCustom):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCustom):
(WebCore::V8DOMFormData::appendMethodCustom):

bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCustom):

bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateMethodCustom):

bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAttrSetterCustom):

bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addMethodCustom):

bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionMethodCustom):
(WebCore::V8InjectedScriptHost::typeMethodCustom):
(WebCore::V8InjectedScriptHost::getEventListenersMethodCustom):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeMethodCustom):
(WebCore::V8Node::replaceChildMethodCustom):
(WebCore::V8Node::removeChildMethodCustom):
(WebCore::V8Node::appendChildMethodCustom):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendMethodCustom):

Source/WebKit/chromium:

src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):

3:51 AM Changeset in webkit [145801] by mkwst@chromium.org

3 edits in trunk/Source/WebCore

Explicitly send only one report via XSSAuditorDelegate.
https://bugs.webkit.org/show_bug.cgi?id=111964

Reviewed by Adam Barth.

This patch pulls the XSSAuditor report generation out into a separate
function in XSSAuditorDelegate::generateViolationReport, and moves the
call to that function into the "have we already notified folks about
violations on this page?" block. This both clarifies the flow in
XSSAuditorDelegate::didBlockScript, and ensures that only one violation
report will be sent per page, which regressed in r145695.

Existing tests verify that reports are generated and sent correctly.

We have no tests for the latter condition: the XSSAuditor tests
currently verify that a report showed up, but they can't verify that
no report appeared without sitting around for a few more than a few
seconds on every run.

html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::generateViolationReport):

Pull the report generation logic out to this new function.

(WebCore::XSSAuditorDelegate::didBlockScript):

Move the report generation call into the block that ensures it only
executes for the first violation.

3:07 AM Changeset in webkit [145800] by zeno.albisser@digia.com

4 edits in trunk/Tools

[Qt] Port DRT to use TestRunner::dumpAsText()
https://bugs.webkit.org/show_bug.cgi?id=112260

Reviewed by Benjamin Poulain.

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::open):
(WebCore::methodNameStringForFailedTest):

Change parameter from type TestRunnerQt* to TestRunner*.

(WebCore::DumpRenderTree::dump):

TestRunnerQt::shouldDumpPixels() always returned true in our case.
Instead we should rely on TestRunner::generatePixelResults().

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::reset):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

2:49 AM Changeset in webkit [145799] by zarvai@inf.u-szeged.hu

3 edits
1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-5.0-wk1/TestExpectations: Skip failing tests after r145784.
platform/qt-5.0-wk2/fast/repaint/focus-ring-expected.txt: Removed.
platform/qt/fast/repaint/focus-ring-expected.txt: Rebaselining after r145708.

2:43 AM Changeset in webkit [145798] by sergio@webkit.org

15 edits
1 move
4 adds
1 delete in trunk

Empty list items after drag&drop in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=110610

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a cleanup after moving operations. This will mainly prune
extra placeholders left by the editing algorithms. Also do not
leave empty <li> when moving them around inside a list element.

Tests: editing/pasteboard/cleanup-on-move.html

editing/pasteboard/drag-list-item.html

editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply): perform
cleanupAfterDeletion().

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems): do not
insert an empty list item.

editing/MoveSelectionCommand.cpp:

(WebCore::MoveSelectionCommand::doApply):

editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::insertAsListItems):

LayoutTests:

Some placeholders should not be left after performing a cleanup in
move operations, this includes the empty list items generated when
moving around list items inside a list.

I'm also moving drag-list-item.html to editing/pasteboard because
it fits much better there than under editing/selection.

editing/pasteboard/cleanup-on-move-expected.txt: Added.
editing/pasteboard/cleanup-on-move.html: Added.
editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
editing/pasteboard/resources/select-and-drag.js: Added.

(selectAndDragToTarget): Selects nodes and drops them after a target node.

editing/pasteboard/drag-drop-list-expected.txt: Removed an empty <li>.
editing/pasteboard/paste-list-004-expected.txt: Removed 2 empty <li>.
editing/pasteboard/paste-list-004.html: Ditto.
editing/selection/4895428-1-expected.txt: Removed a <br>.
editing/selection/4895428-4-expected.txt: Ditto.
fast/events/ondragenter-expected.txt: Removed a blank line.
platform/chromium/fast/events/ondragenter-expected.txt: Ditto.
platform/efl/TestExpectations: Added cleanup-on-move.html to the skipped list.
platform/mac-wk2/TestExpectations: Ditto.
platform/qt/TestExpectations: Ditto.
platform/win/fast/events/ondragenter-expected.txt: Removed a blank line.

2:25 AM Changeset in webkit [145797] by eric@webkit.org

11 edits
5 adds in trunk

Threaded HTML Parser should limit speculation to avoid using too much memory
https://bugs.webkit.org/show_bug.cgi?id=112069

Reviewed by Adam Barth.

Source/WebCore:

This is a speculative fix for memory issues seen in:
https://code.google.com/p/chromium/issues/detail?id=180819

This also fixed https://bugs.webkit.org/show_bug.cgi?id=110546
as a side-effect of simplifying the m_currentChunk handling.

We now tell the background html parser every time we start
a chunk on the main thread (instead of end), which greatly
simplified the checkpoint cleanup code from:
https://trac.webkit.org/changeset/145277

The cost for this is now we have more messages going to the
background thread (and postTask acquires a lock to write to the
message queue). Chromium has more advanced (lock-less) primatives
for message posting, which we'll hopefully add to WebKit in
furture patches.

The outstanding chunks limit has not been tuned. But it makes sense that
we should not keeping infinite speculative tokens around for
large documents with slow-to-load scripts.

html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::invalidateCheckpointsBefore):
(WebCore):
(WebCore::BackgroundHTMLInputStream::rewindTo):

html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):
(WebCore::BackgroundHTMLInputStream::outstandingCheckpointCount):
(Checkpoint):
(WebCore::BackgroundHTMLInputStream::Checkpoint::isNull):
(WebCore::BackgroundHTMLInputStream::Checkpoint::clear):

html/parser/BackgroundHTMLParser.cpp:

(WebCore):
(WebCore::BackgroundHTMLParser::startedChunkWithCheckpoint):
(WebCore::BackgroundHTMLParser::pumpTokenizer):

html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::validateSpeculations):
(WebCore::HTMLDocumentParser::discardSpeculationsAndResumeFrom):
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpPendingSpeculations):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

html/parser/HTMLDocumentParser.h:

(HTMLDocumentParser):

LayoutTests:

Test that this fixes https://bugs.webkit.org/show_bug.cgi?id=110546 for the threaded parser.
Ports using the main-thread parser are expected to fail (ASSERT in Debug).

fast/parser/document-write-partial-entity-before-load-expected.txt: Added.
fast/parser/document-write-partial-entity-before-load.html: Added.
fast/parser/external-script-document-write-expected.txt: Added.
fast/parser/external-script-document-write.html: Added.
fast/parser/resources/external-script-document-write.js: Added.
platform/gtk/TestExpectations:
platform/mac/TestExpectations:
platform/qt/TestExpectations:

2:00 AM Changeset in webkit [145796] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Minor changes for the popover.
https://bugs.webkit.org/show_bug.cgi?id=112331

Reviewed by Yury Semikhatsky.

popover timeout needs to be decreased a bit.
hidePopover call in onMouseMove doesn't necessary.
We have to keep anchor element unmodified if the hovered item didn't changed.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._onMouseMove):

1:57 AM Changeset in webkit [145795] by commit-queue@webkit.org

6 edits in trunk/Source

Fix detection of Intel Mac OS X platform on Intel Mac 64-bit
https://bugs.webkit.org/show_bug.cgi?id=112312

Patch by Jonathan Liu <net147@gmail.com> on 2013-03-14
Reviewed by Simon Hausmann.

Source/WebCore:

platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):

Source/WebKit/efl:

ewk/ewk_settings.cpp:

(_ewk_settings_webkit_os_version_get):

Source/WebKit/wx:

WebKitSupport/FrameLoaderClientWx.cpp:

(WebCore::agentOS):

1:38 AM Changeset in webkit [145794] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

Layout Test plugins/plugin-clip-subframe.html is failing
https://bugs.webkit.org/show_bug.cgi?id=111514

Patch by John Bauman <jbauman@chromium.org> on 2013-03-14
Reviewed by Ryosuke Niwa.

Rebaseline test result due to chromium r185729. Also try to force
layout in test to prevent flakiness on win-dbg.

platform/chromium-mac/plugins/plugin-clip-subframe-expected.txt:
platform/chromium/TestExpectations:
plugins/plugin-clip-subframe.html:

1:37 AM Changeset in webkit [145793] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Adding a couple of failure expectations for flaky
tests on the debug builder.

platform/gtk/TestExpectations:

1:18 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

1:16 AM Changeset in webkit [145792] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InRegionScrollableArea: fix call to visibleContentRect()
https://bugs.webkit.org/show_bug.cgi?id=112244

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-14
Reviewed by Rob Buis.

Since r143295 visibleContentRect() receives an enum, not a boolean.

WebKitSupport/InRegionScrollableArea.cpp:

(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):

12:50 AM Changeset in webkit [145791] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Martin Robinson.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

12:38 AM Changeset in webkit [145790] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Flame Chart. Rewrite drawing procedure for better performance.
https://bugs.webkit.org/show_bug.cgi?id=112264

Reviewed by Yury Semikhatsky.

I traverses the profile tree in calculateTimelineData and calculates all the sizes and colors.
Later in draw code we lineary pass the array and draw items.
Also we could easily swap to another format of the profile.

inspector/front-end/FlameChart.js:

(WebInspector.FlameChart):
(WebInspector.FlameChart.prototype._nodeCount):
(WebInspector.FlameChart.prototype._calculateTimelineData.appendReversedArray):
(WebInspector.FlameChart.prototype._calculateTimelineData):
(WebInspector.FlameChart.prototype._getPopoverAnchor):
(WebInspector.FlameChart.prototype._showPopover):
(WebInspector.FlameChart.prototype._hidePopover):
(WebInspector.FlameChart.prototype._onClick):
(WebInspector.FlameChart.prototype._onMouseMove):
(WebInspector.FlameChart.prototype._coordinatesToNodeIndex):
(WebInspector.FlameChart.prototype.onResize):
(WebInspector.FlameChart.prototype.draw):

12:30 AM Changeset in webkit [145789] by alice.liu@apple.com

17 edits in trunk/Source

Add to HistoryItem a way to know if its underlying CachedPage has expired.
https://bugs.webkit.org/show_bug.cgi?id=110652

Reviewed by Brady Eidson.

Source/WebCore:

WebCore.exp.in: Added WebCore::HistoryItem::isInPageCache and hasCachedPageExpired.
history/CachedPage.cpp: Add a data member, m_expirationTime, and a function, hasExpired().
history/CachedPage.h:
history/HistoryItem.cpp:

(WebCore::HistoryItem::hasCachedPageExpired): Added. returns m_cachedPage's expiration state.

history/HistoryItem.h:
history/PageCache.cpp:

(WebCore::PageCache::get): Address the fixme about not using WebKitBackForwardCacheExpirationIntervalKey.

page/Settings.in: Add backForwardCacheExpirationInterval to the automatically generated setters for Settings.

Source/WebKit/mac:

History/WebHistoryItem.mm:

(-[WebHistoryItem _isInPageCache]): Added. Just calls and returns core imple's function.
(-[WebHistoryItem _hasCachedPageExpired]): Same thing.

History/WebHistoryItemPrivate.h:
WebView/WebPreferences.mm:

(-[WebPreferences _backForwardCacheExpirationInterval]): Address fixme, now that WebCore::Settings
has getters and setters with default value.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]): call setBackForwardCacheExpirationInterval similar to other settings.

Source/WebKit2:

Hook up hasCachedPageExpired in InjectedBundle's BackForwardListItem.

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp:

(WKBundleBackForwardListItemHasCachedPageExpired):

WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.h:
WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::hasCachedPageExpired):

Mar 13, 2013:

11:52 PM Changeset in webkit [145788] by rniwa@webkit.org

3 edits
2 adds in trunk

Cannot select a canvas element at the beginning or the end of a document
https://bugs.webkit.org/show_bug.cgi?id=112319

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by the editing code treating canvas element as if an empty inline element.
Treat it as an "atomic" element for the purpose of determining whether selection can have
an end point in it or not.

Test: editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html

html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::canContainRangeEndPoint): Added.

LayoutTests:

Add a regression test to copy and paste a content with canvas elements.

editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html: Added.

10:59 PM Changeset in webkit [145787] by commit-queue@webkit.org

35 edits
28 adds in trunk

Implement FontLoader interface
https://bugs.webkit.org/show_bug.cgi?id=98395

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2013-03-13
Reviewed by Eric Seidel.

Source/WebCore:

This patch implements the FontLoader interface defined in CSS Font
Load Events Module Level 3.[1] It adds fontloader attribute to
Document, and adds two interfaces, FontLoader and
CSSFontFaceLoadEvent to WebCore.

[1]: http://dev.w3.org/csswg/css-font-load-events-3/

This feature is guarded by FONT_LOAD_EVENTS compiler flag and
RuntimeEnabledFeatures::fontLoadEventsEnabled() runtime flag.

Tests: fast/css/fontloader-download-error.html

fast/css/fontloader-events.html
fast/css/fontloader-loadingdone.html
fast/css/fontloader-multiple-faces-download-error.html
fast/css/fontloader-multiple-faces.html
fast/css/fontloader-multiple-families.html
http/tests/webfont/fontloader-loading-attribute.html

CMakeLists.txt: Adding FontLoader/CSSFontFaceLoadEvent files.
DerivedSources.cpp: Ditto.
DerivedSources.make: Ditto.
DerivedSources.pri: Ditto.
GNUmakefile.list.am: Ditto.
Target.pri: Ditto.
WebCore.gypi: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add convertValue() for CSSFontFaceRule, DOMError, and VoidCallback.

bindings/js/JSDictionary.h: Ditto.
bindings/v8/Dictionary.cpp: Add get() for CSSFontFaceRule, DOMError, and VoidCallback.

(WebCore::Dictionary::get):

bindings/v8/Dictionary.h: Ditto.

(Dictionary):

css/CSSFontFace.cpp: Notifies FontLoader as load progresses.

(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::getFontData):
(WebCore::CSSFontFace::notifyFontLoader):
(WebCore::CSSFontFace::notifyLoadingDone):

css/CSSFontFace.h: Add two member variables. m_rule stores CSSFontFaceRule for the fontface. m_loadState holds current state of the fontface in terms of FontLoader.

(WebCore::CSSFontFace::create): Takes additional parameter of type CSSFontFaceRule.
(WebCore::CSSFontFace::loadState):
(WebCore::CSSFontFace::CSSFontFace):

css/CSSFontFaceLoadEvent.cpp: Added.

(WebCore::CSSFontFaceLoadEvent::CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::~CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::interfaceName):

css/CSSFontFaceLoadEvent.h: Added.

(CSSFontFaceLoadEventInit):
(CSSFontFaceLoadEvent):
(WebCore::CSSFontFaceLoadEvent::create):
(WebCore::CSSFontFaceLoadEvent::createForFontFaceRule):
(WebCore::CSSFontFaceLoadEvent::createForError):
(WebCore::CSSFontFaceLoadEvent::fontface):
(WebCore::CSSFontFaceLoadEvent::error):

css/CSSFontFaceLoadEvent.idl: Added.
css/CSSFontFaceRule.idl: Add JSGenerateToJSObject and JSGenerateToNativeObject as JSC binding needs them.
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::isDecodeError): Added.
(WebCore::CSSFontFaceSource::ensureFontData): Added.

css/CSSFontFaceSource.h:

(CSSFontFaceSource):

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Pass a CSSFontFaceRule to CSSFontFace::create().
(WebCore::CSSFontSelector::getFontData): Moved logic for creating a CSSSegmentedFontFace to a helper function getFontFace().
(WebCore::CSSFontSelector::getFontFace): Added.

css/CSSFontSelector.h:
css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::fontLoaded): Fires callbacks when load is completed.
(WebCore::CSSSegmentedFontFace::isLoading): Returns true if any fonts are still loading.
(WebCore::CSSSegmentedFontFace::checkFont): Returns true if all fonts are loaded.
(WebCore::CSSSegmentedFontFace::loadFont): Starts load by calling getFontData().

css/CSSSegmentedFontFace.h:

(CSSSegmentedFontFace): Declares new functions and a vector to store callbacks.
(LoadFontCallback):
(WebCore::CSSSegmentedFontFace::LoadFontCallback::~LoadFontCallback):

css/FontLoader.cpp: Added.

(LoadFontCallback): Holds callback functions of FontLoader.loadFont().
(WebCore::LoadFontCallback::create):
(WebCore::LoadFontCallback::createFromParams):
(WebCore::LoadFontCallback::LoadFontCallback):
(WebCore::LoadFontCallback::notifyLoaded):
(WebCore::LoadFontCallback::notifyError):
(WebCore::FontLoader::FontLoader):
(WebCore::FontLoader::~FontLoader):
(WebCore::FontLoader::eventTargetData):
(WebCore::FontLoader::ensureEventTargetData):
(WebCore::FontLoader::interfaceName):
(WebCore::FontLoader::scriptExecutionContext):
(WebCore::FontLoader::didLayout): Fires pending events and callbacks. This is called when layout have completed.
(WebCore::FontLoader::scheduleEvent): Defers event dispatching until layout completes.
(WebCore::FontLoader::firePendingEvents): Dispatches pending events.
(WebCore::FontLoader::beginFontLoading): Schedules loading/loadstart events. This is called from CSSFontFace.
(WebCore::FontLoader::fontLoaded): Schedules load/loadingdone events. This is called from CSSFontFace.
(WebCore::FontLoader::loadError): Schedules error/loadingdone events. This is called from CSSFontFace.
(WebCore::FontLoader::notifyWhenFontsReady): Implements fontloader.notifyWhenFontsReady().
(WebCore::FontLoader::loadingDone): Fires callbacks of notifyWhenFontsReady.
(WebCore::FontLoader::loadFont): Implements fontloader.loadFont().
(WebCore::FontLoader::checkFont): Implements fontloader.checkFont().
(WebCore::FontLoader::resolveFontStyle): Parses the given font parameter using the syntax of CSS 'font' property and creates Font object. The logic is taken from CanvasRenderingContext2D::setFont().

css/FontLoader.h: Added.

(FontLoader):
(WebCore::FontLoader::create):
(WebCore::FontLoader::loading):
(WebCore::FontLoader::document):
(WebCore::FontLoader::refEventTarget):
(WebCore::FontLoader::derefEventTarget):

css/FontLoader.idl: Added.
dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::fontloader): Added.

dom/Document.h:

(Document): Add m_fontloader and fontloader().

dom/Document.idl: Add fontloader attribute.
dom/EventNames.h: Add loading and loadingdone events.
dom/EventNames.in: Add CSSFontFaceLoadEvent.
dom/EventTargetFactory.in: Add FontLoader.
page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks): Calls FontLoader::didLayout().

Tools:

Enable FontLoadEvents runtime flag for TestShell.

DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):

LayoutTests:

Add tests for document.fontloader. Since the feature is currently enabled
only for chromium, the tests are expected to fail on the other ports.

fast/css/fontloader-download-error-expected.txt: Added.
fast/css/fontloader-download-error.html: Added.
fast/css/fontloader-events-expected.txt: Added.
fast/css/fontloader-events.html: Added.
fast/css/fontloader-loadingdone-expected.txt: Added.
fast/css/fontloader-loadingdone.html: Added.
fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
fast/css/fontloader-multiple-faces-download-error.html: Added.
fast/css/fontloader-multiple-faces-expected.txt: Added.
fast/css/fontloader-multiple-faces.html: Added.
fast/css/fontloader-multiple-families-expected.txt: Added.
fast/css/fontloader-multiple-families.html: Added.
http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.
http/tests/webfont/fontloader-loading-attribute.html: Added.
platform/chromium/fast/css/fontloader-download-error-expected.txt: Added.
platform/chromium/fast/css/fontloader-events-expected.txt: Added.
platform/chromium/fast/css/fontloader-loadingdone-expected.txt: Added.
platform/chromium/fast/css/fontloader-multiple-faces-download-error-expected.txt: Added.
platform/chromium/fast/css/fontloader-multiple-faces-expected.txt: Added.
platform/chromium/fast/css/fontloader-multiple-families-expected.txt: Added.
platform/chromium/http/tests/webfont/fontloader-loading-attribute-expected.txt: Added.

10:11 PM Changeset in webkit [145786] by Antti Koivisto

7 edits in trunk

Compute image background size when testing for background visibility
https://bugs.webkit.org/show_bug.cgi?id=112313

Reviewed by Simon Fraser.

Source/WebCore:

We can catch more cases where background is fully obscured.

rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBackground):

Use early returns.

(WebCore::RenderBox::backgroundPaintedExtent):

Compute the bounds for image backgrounds.

(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):
(WebCore::RenderBox::backgroundIsKnownToBeObscured):

Rename to make clear that the answers are certain to one direction only.

rendering/RenderBox.h:
rendering/RenderImage.cpp:

(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::backgroundIsKnownToBeObscured):

rendering/RenderImage.h:

LayoutTests:

fast/repaint/obscured-background-no-repaint.html:

9:06 PM Changeset in webkit [145785] by Bruno de Oliveira Abinader

13 edits
8 adds in trunk

[css3-text] Add support for text-decoration-color
https://bugs.webkit.org/show_bug.cgi?id=91638

Reviewed by Julien Chaffraix.

Source/WebCore:

This patch implements the CSS3's 'text-decoration-color' property, with
'-webkit' vendor prefix.

More info about "text-decoration-color" property can be found here:
http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-color-property

Mozilla implementation (using -moz prefix) is described here:
https://developer.mozilla.org/en/CSS/text-decoration-color

Tests: fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html

fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html
fast/css3-text/css3-text-decoration/text-decoration-color.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::isColorPropertyID):
(WebCore::CSSParser::parseValue):

css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
Added parsing checks for '-webkit-text-decoration-color' property.

css/CSSPropertyNames.in:

Added '-webkit-text-decoration-color' property name.

css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):
Set property handler for '-webkit-text-decoration-color'.

css/StyleResolver.cpp:

(WebCore::isValidVisitedLinkProperty):
(WebCore::StyleResolver::applyProperty):
Added switch case checks for text-decoration-color property on visited
link checks and property appliance.

rendering/RenderObject.cpp:

(WebCore::decorationColor):
The newly added property needs to checked here when selecting the text
decoration color.

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff):
(WebCore::RenderStyle::colorIncludingFallback):
(WebCore::RenderStyle::visitedDependentColor):
There is no proper way to check if a property has been set or not, so if
text decoration color fallbacks to default color, it would override the
check for 'text-fill-color' and 'text-stroke-color' properties on
WebCore::decorationColor() static function, changing current behavior,
which can be verified by new failing layout tests (ie.
fast/text/stroking-decorations.html).

rendering/style/RenderStyle.h:

Added {non-}visited text decoration color getters and setters.

rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
Added {non-}visited text decoration color variables initialization to
copy constructor and operator assignment functions.

rendering/style/StyleRareNonInheritedData.h:

(StyleRareNonInheritedData):
Added here as this property is not used regularly.

LayoutTests:

Added layout tests (paint,repaint and getComputedStyle) for
'text-decoration-color' property, with '-webkit' vendor prefix.

fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color-expected.txt: Added.
fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-color.html: Added.
fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-color.js: Added.

Added getComputedStyle-based layout test covering a bunch of valid/invalid values.

fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color-expected.png: Added.
fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color-expected.txt: Added.
fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-color.html: Added.

Added cross-platform repaint layout test using 'Ahem' font.

fast/css3-text/css3-text-decoration/text-decoration-color-expected.html: Added.
fast/css3-text/css3-text-decoration/text-decoration-color.html: Added.

Added cross-platform reference test.

8:52 PM Changeset in webkit [145784] by commit-queue@webkit.org

22 edits in trunk/Source

create runtime flags for CSS Compositing
https://bugs.webkit.org/show_bug.cgi?id=111818

Patch by Rik Cabanier <cabanier@adobe.com> on 2013-03-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests, no change in functionality.

Added a runtime flags that enables CSS compositing

WebCore.exp.in:
bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):

css/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::cssCompositingEnabled):
(WebCore):

css/CSSParser.h:
css/CSSParserMode.h:

(CSSParserContext):

dom/Document.cpp:

(WebCore::Document::cssCompositingEnabled):
(WebCore):

dom/Document.h:

(Document):

Source/WebKit/chromium:

Added a runtime flags to enable CSS compositing for chromium.

public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableCSSCompositing):
(WebKit):
(WebKit::WebRuntimeFeatures::isCSSCompositingEnabled):

Source/WebKit/mac:

Added a preference to enable CSS compositing.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences cssCompositingEnabled]):
(-[WebPreferences setCSSCompositingEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Added a preference to enable CSS compositing.

Shared/WebPreferencesStore.h:

(WebKit):

WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit):

WebProcess/InjectedBundle/InjectedBundle.h:

(InjectedBundle):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

8:33 PM Changeset in webkit [145783] by jparent@chromium.org

2 edits in trunk/Tools

CLeanup: remove unnecessary call to parseParameters.
https://bugs.webkit.org/show_bug.cgi?id=112309

Reviewed by Ojan Vafai.

We call parseCrossDashboardParameters when the dashboard initially
loads to set the state required for loadBuildersList, and then we
call it again once we are fully done with loading, so there is no
reason to call it in the middle of the loading process here.

TestResultServer/static-dashboards/loader.js:

(.):

7:48 PM Changeset in webkit [145782] by kinuko@chromium.org

34 edits
6 copies
7 moves
9 adds in trunk

Quota API: Update IDL to make it match the latest WD
https://bugs.webkit.org/show_bug.cgi?id=88396

Reviewed by Adam Barth.

Source/WebCore:

Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
to make the code match with the latest Quota API WD:
http://www.w3.org/TR/quota-api/

Tests: storage/storagequota-query-usage.html

storage/storagequota-request-quota.html

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
DerivedSources.pri:
GNUmakefile.list.am:
Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::webkitStorageInfo): Added a deprecate warning message for the old interface.

Modules/quota/NavigatorStorageQuota.cpp: Added for the new interface.
Modules/quota/NavigatorStorageQuota.h: Added for the new interface.
Modules/quota/NavigatorStorageQuota.idl: Added for the new interface.
Modules/quota/StorageErrorCallback.cpp:

(WebCore::StorageErrorCallback::CallbackTask::CallbackTask):
(WebCore::StorageErrorCallback::CallbackTask::performTask):

Modules/quota/StorageErrorCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.h.

(WebCore):
(StorageErrorCallback):
(WebCore::StorageErrorCallback::~StorageErrorCallback):
(WebCore::StorageErrorCallback::CallbackTask::create):

Modules/quota/StorageErrorCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoErrorCallback.idl.
Modules/quota/StorageInfo.cpp: Added code to relay requests to the new StorageQuota implementation.
Modules/quota/StorageInfo.h:
Modules/quota/StorageInfo.idl:
Modules/quota/StorageQuota.cpp: Added for the new interface.
Modules/quota/StorageQuota.h:

(WebCore::StorageQuota::create):

Modules/quota/StorageQuota.idl: Copied from Source/WebCore/Modules/quota/StorageInfo.idl.
Modules/quota/StorageQuotaCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.h.
Modules/quota/StorageQuotaCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoQuotaCallback.idl.
Modules/quota/StorageUsageCallback.h: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.h.
Modules/quota/StorageUsageCallback.idl: Renamed from Source/WebCore/Modules/quota/StorageInfoUsageCallback.idl.
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
page/FeatureObserver.h:

Source/WebKit/chromium:

Add a new interface object (navigator.StorageQuota) and deprecate the old one (window.StorageInfo)
to make the code match with the latest Quota API WD:
http://www.w3.org/TR/quota-api/

WebKit.gyp:
src/AssertMatchingEnums.cpp:
src/StorageQuotaChromium.cpp: Renamed from Source/WebKit/chromium/src/StorageInfoChromium.cpp.

(WebCore):
(WebCore::StorageQuota::queryUsageAndQuota):
(WebCore::StorageQuota::requestQuota):

src/WebStorageQuotaCallbacksImpl.cpp:

(WebKit::WebStorageQuotaCallbacksImpl::WebStorageQuotaCallbacksImpl):

src/WebStorageQuotaCallbacksImpl.h:

(WebCore):
(WebStorageQuotaCallbacksImpl):

LayoutTests:

platform/chromium/TestExpectations:
storage/storagequota-query-usage-expected.txt: Added.
storage/storagequota-query-usage.html: Added.
storage/storagequota-request-quota-expected.txt: Added.
storage/storagequota-request-quota.html: Added.

Rebaselines:

platform/chromium/fast/dom/everything-to-string-expected.txt: Added.
platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
platform/chromium/fast/js/global-constructors-expected.txt:
platform/chromium/http/tests/security/isolatedWorld/all-window-properties-expected.txt: Added.
platform/chromium/http/tests/security/isolatedWorld/all-window-prototypes-expected.txt: Added.

7:36 PM Changeset in webkit [145781] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed. Sort the Xcode project file.

WebCore.xcodeproj/project.pbxproj:

7:15 PM Changeset in webkit [145780] by dino@apple.com

2 edits in trunk/LayoutTests

[WebGL] array-bounds-clamping should use less dramatic numbers
https://bugs.webkit.org/show_bug.cgi?id=112298
<rdar://problem/13415829>

Reviewed by Ken Russell.

Replace Number.MAX_VALUE with a non-infinite number.

fast/canvas/webgl/array-bounds-clamping.html:

6:54 PM Changeset in webkit [145779] by Lucas Forschler

2 edits in tags/Safari-537.33.3/Source/WebKit2

Merged r145042. <rdar://problem/13363917>

6:51 PM Changeset in webkit [145778] by Lucas Forschler

4 edits in tags/Safari-537.33.3/Source

Versioning.

6:48 PM Changeset in webkit [145777] by Lucas Forschler

1 copy in tags/Safari-537.33.3

New Tag.

6:47 PM Changeset in webkit [145776] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Make lint-test-expectations happy with the Apple-Windows TestExpectations files

Unreviewed.

platform/win/TestExpectations:

5:44 PM Changeset in webkit [145775] by Michael Nordman

1 edit in trunk/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp

Unreviewed build fix.

5:27 PM Changeset in webkit [145774] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Enable V8 binding integriy on Android.
https://bugs.webkit.org/show_bug.cgi?id=112297

Patch by Chris Palmer <palmer@google.com> on 2013-03-13
Reviewed by Adam Barth.

features.gypi:

5:23 PM Changeset in webkit [145773] by Michael Nordman

1 edit in trunk/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp

Unreviewd build fix.

5:03 PM Changeset in webkit [145772] by rafaelw@chromium.org

3 edits in trunk/Source/WebCore

[HTMLTemplateElement] EOF should unwind the stack of template insertion modes iteratively
https://bugs.webkit.org/show_bug.cgi?id=111907

Reviewed by Adam Barth.

No behavioral changes. This patch only aligns our parser implementation with the present spec.

html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processTemplateEndTag):
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents):
(WebCore::HTMLTreeBuilder::processEndOfFile):

html/parser/HTMLTreeBuilder.h:

(HTMLTreeBuilder):

5:01 PM Changeset in webkit [145771] by Michael Nordman

16 edits in trunk/Source

Source/WebCore: FileSystem mods: Changes to snapshot file creation to reduce dependencies on blob URLs.
Adding a new minimal BlobDataHandle class which will be reimplemented/built upon in later CLs. In this
patch, it's just enough to refactor the FileSystem code to not function in terms of blobURLs.
https://bugs.webkit.org/show_bug.cgi?id=108851

Reviewed by Adam Barth.

No new tests. This is strictly a refactoring of the existing code.

Modules/filesystem/DOMFileSystem.cpp:

(WebCore):
(WebCore::DOMFileSystem::createFile):

Modules/filesystem/DOMFileSystemSync.cpp:

(WebCore):

platform/AsyncFileSystemCallbacks.h:

(AsyncFileSystemCallbacks):
(WebCore::AsyncFileSystemCallbacks::didCreateSnapshotFile):

platform/gtk/AsyncFileSystemGtk.cpp:

(WebCore::AsyncFileSystemGtk::createSnapshotFileAndReadMetadata):
(WebCore):

platform/network/BlobData.cpp:

(WebCore):
(WebCore::BlobDataHandle::BlobDataHandle):
(WebCore::BlobDataHandle::~BlobDataHandle):

platform/network/BlobData.h:

(WebCore):
(BlobDataHandle):
(WebCore::BlobDataHandle::create):

Source/WebKit/chromium: [Chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
No longer send a |blobURL| to the browser process, no longer expect the browser process
to have registered a blob with that url.
https://bugs.webkit.org/show_bug.cgi?id=108851

Reviewed by Adam Barth.

src/AsyncFileSystemChromium.cpp:

(WebCore):
(WebCore::FileWriterHelperCallbacks::didCreateSnapshotFile):
(WebCore::AsyncFileSystemChromium::createSnapshotFileAndReadMetadata):

src/AsyncFileSystemChromium.h:

(AsyncFileSystemChromium):

src/LocalFileSystemChromium.cpp:

(WebCore):

src/WebFileSystemCallbacksImpl.cpp:

(WebKit::WebFileSystemCallbacksImpl::didCreateSnapshotFile):
(WebKit):

src/WebFileSystemCallbacksImpl.h:

(WebCore):
(WebFileSystemCallbacksImpl):

src/WorkerAsyncFileSystemChromium.cpp:

(WebCore::WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata):
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):

src/WorkerFileSystemCallbacksBridge.cpp:

(WebKit::MainThreadFileSystemCallbacks::didCreateSnapshotFile):
(MainThreadFileSystemCallbacks):
(WebKit::WorkerFileSystemCallbacksBridge::postCreateSnapshotFileToMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::createSnapshotFileOnMainThread):
(WebKit::WorkerFileSystemCallbacksBridge::didCreateSnapshotFileOnMainThread):
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::WorkerFileSystemCallbacksBridge):
(WebKit::WorkerFileSystemCallbacksBridge::didCreateSnapshotFileOnWorkerThread):

src/WorkerFileSystemCallbacksBridge.h:

(WebCore):
(WebKit):
(WebKit::WorkerFileSystemCallbacksBridge::create):
(WorkerFileSystemCallbacksBridge):

4:16 PM Changeset in webkit [145770] by abarth@webkit.org

4 edits
1 delete in trunk/Source/WebKit/chromium

[Chromium] Restrict WebNode::addEventListener and friends to a whitelist of event types
https://bugs.webkit.org/show_bug.cgi?id=112195

Reviewed by Eric Seidel.

Chromium only uses these APIs in extremely narrow ways. In order to
discourage Chromium from using these APIs in broader ways, this patch
restricts the APIs to a small whitelist of event types.

We might want to add some sort of flag to let CEF use expose these APIs
more broadly.

WebKit.gypi:
public/WebNode.h:
src/WebNode.cpp:

(WebKit::WebNode::hasEventListeners):
(WebKit::WebNode::addEventListener):

tests/EventListenerTest.cpp: Removed.
- These tests of DOM mutation events are no longer needed because we don't support listening for DOM mutation events via the API anymore.

4:00 PM Changeset in webkit [145769] by esprehn@chromium.org

2 edits in trunk/Tools

Unreviewed. Now I'm a reviewer :)

Scripts/webkitpy/common/config/committers.py:

3:57 PM Changeset in webkit [145768] by rniwa@webkit.org

18 edits in trunk

Threaded HTML Parser is missing feature define flags in all but Chromium port's build files
https://bugs.webkit.org/show_bug.cgi?id=112277

Reviewed by Adam Barth.

Source/autotools/SetupWebKitFeatures.m4:
Source/cmake/WebKitFeatures.cmake:
Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/webkitperl/FeatureList.pm:
qmake/mkspecs/features/features.pri:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

3:56 PM Changeset in webkit [145767] by tony@chromium.org

3 edits in trunk/LayoutTests

Add a test case for flexbox with negative overflow having an out of flow flex item
https://bugs.webkit.org/show_bug.cgi?id=112294

Reviewed by Ojan Vafai.

css3/flexbox/negative-overflow-expected.txt:
css3/flexbox/negative-overflow.html:

3:55 PM Changeset in webkit [145766] by jberlin@webkit.org

2 edits in trunk/Source/WTF

Remove svn:executable from a file that isn't supposed to be executable.

Rubber-stamped by Geoff Garen.

wtf/MediaTime.h:

3:50 PM Changeset in webkit [145765] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[V8] Get rid of more function-level static FunctionTemplates and ObjectTemplates in bindings
https://bugs.webkit.org/show_bug.cgi?id=112262

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-13
Reviewed by Jochen Eisinger.

In the future we'll create and store function templates for main world
and non-main worlds separately (see bug 111724), having function
templates and object templates as static variables inside functions will
break the functionality.

No new tests (no changes in functionality yet; existing bindings
tests still pass).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::createContext):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::hasPrivateTemplate):
(WebCore):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

3:34 PM Changeset in webkit [145764] by abarth@webkit.org

3 edits in trunk/Tools

run-perf-tests should support content_shell
https://bugs.webkit.org/show_bug.cgi?id=112291

Reviewed by Eric Seidel.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

3:30 PM Changeset in webkit [145763] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not do scroll position adjustment if selecting in a subframe
https://bugs.webkit.org/show_bug.cgi?id=112290

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.

PR 267394

In SelectionHandler::ensureSelectedTextVisible(), scroll position
animation is based on main frame. If selecting in a subframe, don't
do animation.

Internally Reviewed By Genevieve Mak.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):

3:28 PM Changeset in webkit [145762] by jchaffraix@webkit.org

3 edits in trunk/Source/WebCore

[CSS Grid Layout] Refactor GridCoordinate to hold GridSpans
https://bugs.webkit.org/show_bug.cgi?id=112211

Reviewed by Tony Chang.

In order to bring more spanning knowledge to RenderGrid without having
duplicated GridSpan resolution, it became needed to store them into
GridCoordinate. Note that this change is needed as we can only resolve
all the positions with enough context in one place: when we place the
item in the grid.

Refactoring, no change in behavior expected.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Updated to create 2 GridSpans. Also fixed a style violation (PassOwnPtr
as local member, not sure why it wasn't caught earlier).

(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
Updated the original function after GridCoordinate internal representation change.

(WebCore::RenderGrid::insertItemIntoGrid):
Ditto. Also added a new overloaded function that does resolution after auto-placement.

(WebCore::RenderGrid::resolveGridPositionsFromAutoPlacementPosition):
Removed the extra GridSpan computation, which was wrong.

rendering/RenderGrid.h:

(WebCore::RenderGrid::GridCoordinate::GridCoordinate):
Updated GridCoordinate to hold 2 GridSpan. Also removed the 2 position
constructor (it would have been a hazard), replaced by a 2 GridSpan constructor.

3:24 PM Changeset in webkit [145761] by jochen@chromium.org

2 edits in trunk/Source/WebCore

Also don't log error messages from the GraphicsContext3D if webGLErrorsToConsoleEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=112284

Reviewed by Adam Barth.

When running layout tests in content_shell, we end up logging more information.
Since webGLErrorsToConsoleEnabled is false during layout tests, this change makes
sure we match the baselines.

html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContextErrorMessageCallback::onErrorMessage):

3:15 PM CreatingLayoutTests edited by pdr@google.com

(diff)

2:59 PM Changeset in webkit [145760] by dgrogan@chromium.org

2 edits in trunk/Source/WebCore

IndexedDB: Record attemps to open a path with non-ascii characters
https://bugs.webkit.org/show_bug.cgi?id=112224

Reviewed by Tony Chang.

We want to see if that's correlated with errors on open.

No new tests, there's no way to test histogramming that I know of. I
ran chrome locally with a non ascii path though.

Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::open):

2:51 PM Changeset in webkit [145759] by oliver@apple.com

4 edits in trunk

Simplify Checked<> multiplication
https://bugs.webkit.org/show_bug.cgi?id=112286

Reviewed by James Robinson.

Source/WTF:

Trying to correctly identify multiplication by zero complicated the
unsigned * unsigned multiply, and still didn't handle all cases correctly.
Now we just do the normal division based approach to overflow detection
leading to much simpler reasoning.

Would be nice if we could have a jo style intrinsic one day.

wtf/CheckedArithmetic.h:

Tools:

Add tests for multiplication by zero and max to ensure we don't
mess them up should we ever make changes to Checked<> in future.

TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI):

2:50 PM Changeset in webkit [145758] by jchaffraix@webkit.org

4 edits
2 adds in trunk

[CSS Grid Layout] Handle min-width / max-width on the grid element
https://bugs.webkit.org/show_bug.cgi?id=112269

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-element-min-max-width.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):
Added some sanity checks that the starting indexes are in the grid.

(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
Updated the code to use m_grid to iterate: this is the correct way to
go as it will handle implicit rows / columns properly. Added a comment
about the current way being inefficient and incorrect with spanning grid
items.

(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated the comments.

(WebCore::RenderGrid::gridTrackSize):

rendering/RenderGrid.h:

Constified gridTrackSize.

LayoutTests:

fast/css-grid-layout/grid-element-min-max-width-expected.txt: Added.
fast/css-grid-layout/grid-element-min-max-width.html: Added.

2:49 PM Changeset in webkit [145757] by commit-queue@webkit.org

3 edits
2 adds in trunk/Source/WebKit

[BlackBerry] Add Proximity Detector.
https://bugs.webkit.org/show_bug.cgi?id=112278

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-13
Reviewed by Rob Buis.

Internally Reviewed by Mike Lattanzio.
PR #243385

Source/WebKit:

PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

WebKitSupport/ProximityDetector.cpp: Added.

(WebKit):
(BlackBerry::WebKit::getPriorityLevel):
(BlackBerry::WebKit::ProximityDetector::ProximityDetector):
(BlackBerry::WebKit::ProximityDetector::~ProximityDetector):
(BlackBerry::WebKit::ProximityDetector::findBestPoint):

WebKitSupport/ProximityDetector.h: Added.

(WebCore):
(WebKit):
(ProximityDetector):

2:43 PM Changeset in webkit [145756] by Simon Hausmann

2 edits in trunk/Source/WebCore

[Qt] Prospective trivial build fix after r145744

Add missing closing parentheses.

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseDtd):

2:41 PM Changeset in webkit [145755] by beidson@apple.com

2 edits in trunk/Source/WebCore

Account for review feedback in https://bugs.webkit.org/show_bug.cgi?id=112279
that I'd mistakenly left out of my commit.

loader/ResourceLoaderTypes.h:

2:38 PM Changeset in webkit [145754] by inferno@chromium.org

2 edits in trunk/Source/WebCore

Crash in CompositeEditCommand::insertNodeAt.
https://bugs.webkit.org/show_bug.cgi?id=112280

Reviewed by Ryosuke Niwa.

editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
Subsitute with toContainerNode.

2:36 PM Changeset in webkit [145753] by beidson@apple.com

18 edits
1 add in trunk/Source

Small ResourceLoader cleanups.
https://bugs.webkit.org/show_bug.cgi?id=112279

Reviewed by Geoff Garen.

Source/WebCore:

No new tests (Refactor with no behavior change).

1 - Add "OVERRIDE" to virtual methods in subclasses of ResourceLoader to catch future mistakes.
2 - Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.

GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didReceiveData):

loader/NetscapePlugInStreamLoader.h:

loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::addData):
(WebCore::ResourceLoader::didReceiveData):

loader/ResourceLoader.h:
loader/ResourceLoaderTypes.h: Added.

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveData):

loader/SubresourceLoader.h:

Source/WebKit2:

Replace the "bool allAtOnce" flag with a descriptive enum to make reading code easier.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveData):

WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didReceiveResource):

WebProcess/Network/WebResourceLoader.h:
WebProcess/Network/WebResourceLoader.messages.in: Get rid of the "allAtOnce" flag since it was always false.

2:27 PM Changeset in webkit [145752] by Nate Chapin

2 edits in trunk/Source/WebCore

chromium's WebFrameTest.ReplaceNavigationAfterHistoryNavigation failing after r145734
https://bugs.webkit.org/show_bug.cgi?id=112281

Reviewed by Adam Barth.

Fixes the aforementioned chromiun webkit_unit_test

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent): FrameLoader::isReplacing() is not quite

synonymous with loading multipart content. Check that it's actually loading multipart before doing
multipart-specific things.

2:26 PM Changeset in webkit [145751] by dino@apple.com

4 edits in trunk/Source/WTF

Unreviewed attempted build fix for Windows. SchedulePair.cpp -> SchedulePairCF.cpp

WTF.vcproj/WTF.vcproj:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:

2:16 PM Changeset in webkit [145750] by commit-queue@webkit.org

24 edits
4 adds in trunk

Add the default video poster if it doesn't exist in video tag
https://bugs.webkit.org/show_bug.cgi?id=110263

Patch by Tao Bai <michaelbai@chromium.org> on 2013-03-13
Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/video-default-poster.html

media/video-no-default-poster.html

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an

Element::imageSourceURL function that returns the imageSourceURL as a
const AtomicString&. The body will be the same as before, it will just also
include a call to getAttribute. Also will need to revise the four classes
that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the

default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster

loading and display to call posterImageURL.

1) HTMLVideoElement::imageSourceURL.
2) HTMLVideoElement::setDisplayMode.
3) HTMLVideoElement::updateDisplayState.
4) HTMLMediaElement::getPluginProxyParams. Will need to cast to

HTMLVideoElement after checking isVideo.

dom/Element.cpp:

(WebCore::Element::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()

dom/Element.h: Replace imageSourceAttributeName() with imageSourceURL()
html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()

html/HTMLEmbedElement.h: Replace imageSourceAttributeName() with imageSourceURL()
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getPluginProxyParams): Change to use posterImageURL

html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()

html/HTMLObjectElement.h: Replace imageSourceAttributeName with imageSourceURL
html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::HTMLVideoElement): set m_defaultPosterURL if there is such settings
(WebCore::HTMLVideoElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()
(WebCore::HTMLVideoElement::setDisplayMode): Use imageSourceURL()
(WebCore::HTMLVideoElement::updateDisplayState): Use imageSourceURL()
(WebCore::HTMLVideoElement::posterImageURL): Return image source's KURL

html/HTMLVideoElement.h: Replace imageSourceAttributeName() with imageSourceURL() and add m_defaultPosterURL
loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Use imageSourceURL()

page/Settings.in: Add defaultVideoPosterURL setting.
platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeImage): use imageSourceURL()

platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode): use imageSourceURL()

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteImageURL): use imageSourceURL()

svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::imageSourceURL): Replace imageSourceAttributeName() with imageSourceURL()

svg/SVGImageElement.h: Replace imageSourceAttributeName() with imageSourceURL()
testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup): support backup defaultVideoPosterURL.
(WebCore::InternalSettings::Backup::restoreTo): support restore defaultVideoPosterURL.
(WebCore::InternalSettings::setDefaultVideoPosterURL): set defaultVideoPosterURL.

testing/InternalSettings.h:

(Backup): support backup defaultVideoPosterURL.
(InternalSettings): Add setDefaultVidoePosterURL method.

testing/InternalSettings.idl: Add setDefaultVideoPosterURL for test purpose.
testing/Internals.cpp:

(WebCore::Internals::getImageSourceURL): Add getImageSourceURL method.

testing/Internals.h: Add getImageSourceURL method.
testing/Internals.idl: Add getImageSourceURL method.

LayoutTests:

The Android web view application could provide the default poster
for a video that doesn't have the poster attribute.

To provide the default poster, the application must set defaultVideoPosterURL
setting and return the image in the response of that URL.

The way to do this would be:

A) Replace the Element::imageSourceAttributeName function with an

Element::imageSourceURL function that returns the imageSourceURL as a
const AtomicString&. The body will be the same as before, it will just also
include a call to getAttribute. Also will need to revise the four classes
that override that function.

B) Add a new HTMLVideoElement::posterImageURL function that implements the

default poster URL logic.

C) Update the four functions that get the poster attribute to handle poster

loading and display to call posterImageURL.

1) HTMLVideoElement::imageSourceURL.
2) HTMLVideoElement::setDisplayMode.
3) HTMLVideoElement::updateDisplayState.
4) HTMLMediaElement::getPluginProxyParams. Will need to cast to

HTMLVideoElement after checking isVideo.

media/video-default-poster-expected.txt: Added.
media/video-default-poster.html: Added.
media/video-no-default-poster-expected.txt: Added.
media/video-no-default-poster.html: Added.

1:55 PM Changeset in webkit [145749] by jamesr@google.com

2 edits in trunk/LayoutTests

Force clip in fast/regions/autoheight-break-after-expected.html to match test
https://bugs.webkit.org/show_bug.cgi?id=112283

Reviewed by David Hyatt.

Regions always set a clip rect when rendering their contents. On Mountain Lion, the Ahem glyphs very slightly
visually overflow their bounds if there's no clip set. This sets a clip in the reference file so we get the same
rendering.

fast/regions/autoheight-break-after-expected.html:

1:44 PM Changeset in webkit [145748] by benjamin@webkit.org

3 edits in trunk/Source/WTF

[iOS] Add optimized version of StringImpl's equal(LChar*,LChar*) for Apple CPUs
https://bugs.webkit.org/show_bug.cgi?id=112202

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-13
Reviewed by Gavin Barraclough.

Source/WTF/wtf/Platform.h:

Make the macro WTF_ARM_ARCH_VERSION valid on any architecture.

wtf/text/StringImpl.h:

(WTF::equal):
On ARMv7S, the new version is about 11% percent faster than the simple loop.
On ARMv7 classic, memcmp is a little faster than the simple loop on Apple A5.

1:42 PM Changeset in webkit [145747] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Unreviewed prospective Windows build fix

Do the usual thing, include the moc generated code in the .cpp file instead
of compiling it standalone, to ensure that config.h is included, too, and
NOMINMAX is defined to avoid the min/max conflict when also including qdatetime.h.

DumpRenderTree/qt/EventSenderQt.cpp:

1:38 PM Changeset in webkit [145746] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Make lint-test-expectations happy with the Apple-Windows TestExpectations files

Unreviewed.

accessibility/radio-button-checkbox-size.html was moved to platform/mac in http://trac.webkit.org/changeset/138124
fast/css/ignore-text-zoom.html was removed in http://trac.webkit.org/changeset/145168
inspector-protocol/layer-tree.html was removed in http://trac.webkit.org/changeset/144624
Remove a bunch of duplicate entries.

platform/win/TestExpectations:

1:29 PM Changeset in webkit [145745] by inferno@chromium.org

88 edits in trunk/Source

Replace static_casts with to* functions for document types.
https://bugs.webkit.org/show_bug.cgi?id=112225

Reviewed by Ryosuke Niwa.

Source/WebCore:

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::document):
....lot of files.

Source/WebKit2:

WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm: Remove the redundant helper.

1:24 PM Changeset in webkit [145744] by commit-queue@webkit.org

4 edits
4 adds in trunk

Source/WebCore: Handle XHTML entities in XHTML Mobile Profile 1.1 and 1.2. We previously only handled them in XHTML Mobile Profile 1.0.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

Check for the 1.1 and 1.2 doctypes alongside the 1.0 doctype.

Tests: fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml

fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::externalSubsetHandler):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::parseDtd):

LayoutTests: New tests to check that XHTML entities are supported in XHTML Mobile Profile 1.1 and 1.2.
https://bugs.webkit.org/show_bug.cgi?id=112174
RIM PR 309038

Patch by Liam Quinn <lquinn@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.
Internally reviewed by Leo Yang.

fast/doctypes/xhtml-with-xhtmlmp11-doctype-expected.txt: Added.
fast/doctypes/xhtml-with-xhtmlmp11-doctype.xhtml: Added.
fast/doctypes/xhtml-with-xhtmlmp12-doctype-expected.txt: Added.
fast/doctypes/xhtml-with-xhtmlmp12-doctype.xhtml: Added.

1:23 PM Changeset in webkit [145743] by commit-queue@webkit.org

4 edits
1 move in trunk/Source/WTF

SchedulePair.cpp is CF-specific
https://bugs.webkit.org/show_bug.cgi?id=112204

Patch by James Robinson <jamesr@chromium.org> on 2013-03-13
Reviewed by Oliver Hunt.

This renames SchedulePair.cpp SchedulePairCF.cpp, since it depends on CF, and excludes it from chromium's gyp
files.

WTF.gyp/WTF.gyp: Add CF to the exclusion filter for the Chromium port.
WTF.gypi: Add SchedulePairCF.cpp
WTF.xcodeproj/project.pbxproj: Update project file to point to new .cpp location
wtf/SchedulePairCF.cpp: Renamed from Source/WTF/wtf/SchedulePair.cpp.

1:23 PM Changeset in webkit [145742] by timothy_horton@apple.com

2 edits in trunk/LayoutTests

Unreviewed, fix a path in TestExpectations.

platform/mac/TestExpectations:

1:10 PM Changeset in webkit [145741] by Christophe Dumez

3 edits in trunk/Source/WebCore

[EFL] Better error handling in NetworkStateNotifierEfl
https://bugs.webkit.org/show_bug.cgi?id=112184

Reviewed by Kenneth Rohde Christiansen.

Improve error handling in for system calls in NetworkStateNotifierEfl.

EINTR errors are now properly handled for close() and recv() syscalls
recv() errors are now correctly detected, for e.g. if the socket was

closed unexpectedly.

Make sure m_fdHandler is reset when the callback returns

ECORE_CALLBACK_CANCEL to avoid double free in destructor. m_fdHandler
gets destroyed when the callback returns ECORE_CALLBACK_CANCEL.

Keep netlink socket file descriptor as a class member so that we can

close() it in the class destructor, even if m_fdHandler has already
been destroyed.

No new tests, no behavior change for layout tests.

platform/network/NetworkStateNotifier.h:

(NetworkStateNotifier):

platform/network/efl/NetworkStateNotifierEfl.cpp:

(WebCore::NetworkStateNotifier::readSocketCallback):
(WebCore::NetworkStateNotifier::~NetworkStateNotifier):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

12:59 PM WebKitGtkLayoutTests edited by Martin Robinson

(diff)

12:58 PM Changeset in webkit [145740] by tommyw@google.com

3 edits in trunk/Source/Platform

[chromium] MediaStream API: Cleaning away deprecated and unused states
https://bugs.webkit.org/show_bug.cgi?id=112258

Reviewed by Adam Barth.

chromium/public/WebRTCPeerConnectionHandler.h:

(WebRTCPeerConnectionHandler):

chromium/public/WebRTCPeerConnectionHandlerClient.h:

(WebRTCPeerConnectionHandlerClient):

12:57 PM BuildingGtk edited by Martin Robinson

(diff)

12:55 PM Changeset in webkit [145739] by schenney@chromium.org

2 edits in trunk/Source/WebKit/chromium

Add new Skia code suppression flags

Unreviewed build update.

skia_webkit.gyp: Add 'SK_DISABLE_BLUR_ROUNDING', 'SK_IGNORE_SUBPIXEL_AXIS_ALIGN_FIX',

'SK_IGNORE_PICTURE_RECORD_SAVE_LAYER_OPT', 'SK_IGNORE_FAST_RECT_BLUR', 'SK_IGNORE_CUBIC_STROKE_FIX'

12:46 PM Changeset in webkit [145738] by commit-queue@webkit.org

4 edits in trunk/Source

[GTK] Build fixes after 145552
https://bugs.webkit.org/show_bug.cgi?id=112267

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-03-13
Reviewed by Gustavo Noronha Silva.

Source/Platform:

GNUmakefile.am: Include the same-level GNUmakefile.list.am.

Fix a typo in the inline visibility compiler flag.

Source/WebKit2:

GNUmakefile.am: Narrow down the dependency CFLAGS list to only ones that are actually needed

to build the platformgtk_sources into libPlatformGtk2.la. At the moment this means only
GTK+-2.0 CFLAGS are used.

12:32 PM Changeset in webkit [145737] by jamesr@google.com

2 edits in trunk/LayoutTests

Clean out some stale chromium TestExpectations entries.

platform/chromium/TestExpectations:

12:28 PM Changeset in webkit [145736] by tony@chromium.org

5 edits
2 adds in trunk

Regression(r143542): -webkit-align-items: center with overflow: auto/scroll has extra bottom padding
https://bugs.webkit.org/show_bug.cgi?id=112047

Reviewed by Ojan Vafai.

Source/WebCore:

Add a new pass for computing the client bottom edge that runs after we've repositioned children
due to wrap-reverse, flex-end or vertical centering.

Test: css3/flexbox/negative-overflow.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock): Remove the code to use clientLogicalBottom() that was computed before
repositioning. The repositioning can change the edge.
(WebCore::RenderFlexibleBox::clientLogicalBottomAfterRepositioning): Compute the new bottom based on the final position
of flex items.

rendering/RenderFlexibleBox.h:

(RenderFlexibleBox):

LayoutTests:

css3/flexbox/negative-overflow-expected.txt: Added.
css3/flexbox/negative-overflow.html: Added.
resources/check-layout.js: Add attributes for checking scroll width and scroll height.

12:14 PM Changeset in webkit [145735] by Nate Chapin

10 edits
2 adds in trunk

.: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Source/autotools/symbols.filter:

Source/WebCore: REGRESSION(r137607): Redirecting a post to a get then reloading triggers resubmit warning
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

Test: http/tests/navigation/post-redirect-get-reload.php

loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequest): Matching urls aren't a reliable way of checking whether

we are in a redirect. Check redirectResponse.isNull() instead.

testing/Internals.cpp:

(WebCore::Internals::forceReload): Expose a means of forcing a reload like one a user generates for testing.

Note that testRunner.queueReload() does this, but is not supported after the initial load completes,
which makes it unsuitable for this case.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/win: Expose symbols for internals
https://bugs.webkit.org/show_bug.cgi?id=112194

Reviewed by Alexey Proskuryakov.

WebKit.vcproj/WebKitExports.def.in:

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=112194.

Reviewed by Alexey Proskuryakov.

http/tests/navigation/post-redirect-get-reload-expected.txt: Added.
http/tests/navigation/post-redirect-get-reload.php: Added.

12:11 PM Changeset in webkit [145734] by Nate Chapin

5 edits in trunk/Source/WebCore

Merge MainResourceLoader's didFinishLoading and dataReceived into DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=109952

Reviewed by Antti Koivisto.

No new tests, refactor only.

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::receivedData):
(WebCore::DocumentLoader::maybeLoadEmpty):

loader/DocumentLoader.h:
loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::responseReceived): Move content filtering to

DocumentLoader.

(WebCore::MainResourceLoader::dataReceived): Mostly moved to DocumentLoader.
(WebCore::MainResourceLoader::didFinishLoading): Mostly moved to DocumentLoader.

loader/MainResourceLoader.h: Expose some variables that haven't been moved

to DocumentLoader yet.

11:52 AM Changeset in webkit [145733] by Lucas Forschler

5 edits in branches/safari-534.59-branch/Source

Versioning.

11:51 AM Changeset in webkit [145732] by Lucas Forschler

1 copy in tags/Safari-534.59.5

New Tag.

11:47 AM Changeset in webkit [145731] by Antoine Quint

4 edits in trunk/Source/WebKit2

Calling WebInspectorClient::highlight() during a fade-out animation of the PageOverlay won't stop its animation
https://bugs.webkit.org/show_bug.cgi?id=112271

Reviewed by Tim Horton.

Add a new stopFadeOutAnimation() on PageOverlay that we call when
WebInspectorClient::highlight() is called and a page overlay
is already available. This ensures that any fade-out animation
is cleared before proceeding with showing the page overlay
for the new highlight.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):

WebProcess/WebPage/PageOverlay.cpp:

(WebKit::PageOverlay::stopFadeOutAnimation):
(WebKit):

WebProcess/WebPage/PageOverlay.h:

(PageOverlay):

11:42 AM Changeset in webkit [145730] by Lucas Forschler

4 edits in branches/safari-536.29-branch/Source

Versioning

11:39 AM Changeset in webkit [145729] by Lucas Forschler

1 copy in tags/Safari-536.29.9

New Tag.

11:32 AM Changeset in webkit [145728] by abucur@adobe.com

3 edits
2 adds in trunk

[CSS Regions] Break after doesn't work correctly with auto-height regions
https://bugs.webkit.org/show_bug.cgi?id=112241

Reviewed by David Hyatt.

Source/WebCore:

The change correctly returns the break position during the normal layout phase for
auto-height regions. The problem doesn't exist during the constrained layout phase
so it only affects the size of the auto-height regions by incorrectly positioning
the content inside the flow.

Test: fast/regions/autoheight-break-after.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::applyAfterBreak): Include the margin offset in the returned break position.

LayoutTests:

This reference test verifies the correct break positioned is computed when there are auto-height regions during
the normal layout phase.
The test includes an auto-height region, a region with a specified size and an auto-height region. The first
region ends with a paragraph with a forced break after. During the normal layout phase, if the paragraph margin
is not included in the break offset, the next paragraph is incorrectly positioned and it will result in an
incorrectly sized last region.
In the constrained layout phase, the break position is returned correctly, the paragraph is positioned further down
causing overflow in the auto-height region.

fast/regions/autoheight-break-after-expected.html: Added.
fast/regions/autoheight-break-after.html: Added.

11:14 AM Changeset in webkit [145727] by caseq@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: coalesce repeating timeline records
https://bugs.webkit.org/show_bug.cgi?id=112168

Reviewed by Vsevolod Vlasov.

coalesce repeating top-level timeline events;
drive-by: only show categories that actually took time in aggregated stats;

English.lproj/localizedStrings.js:
inspector/front-end/TimelineFrameController.js:

(WebInspector.TimelineFrameController.prototype._innerAddRecord):

inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._highlightRect):
(WebInspector.TimelineCalculator.prototype.computeBarGraphPercentages):

inspector/front-end/TimelinePresentationModel.js:

(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype._updateAncestorStats):
(WebInspector.TimelinePresentationModel.prototype._findCoalescedParent):
(WebInspector.TimelinePresentationModel.prototype._replaceWithCoalescedRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.adoptRecord):
(WebInspector.TimelinePresentationModel.insertRetrospectiveRecord):
(WebInspector.TimelinePresentationModel.Record.prototype.get selfTime):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.Record.prototype.calculateAggregatedStats):

10:01 AM Changeset in webkit [145726] by pdr@google.com

4 edits
2 adds in trunk

Fix body background image geometry calculation
https://bugs.webkit.org/show_bug.cgi?id=112226

Reviewed by Stephen Chenney.

Source/WebCore:

Images that depend on a container size require a call to set the container size before
rendering, and a call to look up the correct image during painting.

The body's renderer is special in that it may not be the renderer that actually paints its
background. This patch fixes a bug where the correct RenderObject was used for looking up
the image, but not for setting the container size. This fixes SVG background images on body.

Test: svg/as-background-image/svg-as-background-body.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

This change introduces clientForBackgroundImage in the background geometry calculation.
This is very similar to how the client is looked up in paintFillLayerExtended.

rendering/RenderBoxModelObject.h:

The new signature for calculateBackgroundImageGeometry now mirrors
paintFillLayerExtended, containing a parameter for the correct background renderer.

(RenderBoxModelObject):

LayoutTests:

This test is required to have a repeating background, as we optimize non-repeating
backgrounds so the bug is not hit. A light green color is used so the text is still
readable, and gridlines are present to prove the correct container size is being used.

svg/as-background-image/svg-as-background-body-expected.html: Added.
svg/as-background-image/svg-as-background-body.html: Added.

9:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

9:27 AM Changeset in webkit [145725] by Carlos Garcia Campos

16 edits in releases/WebKitGTK/webkit-2.0

[GTK] Add webkit_uri_request_get_http_headers to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=112160

Reviewed by Martin Robinson.

Source/WebCore:

platform/network/soup/GOwnPtrSoup.cpp:

(WTF::SoupMessageHeaders): Add freeOwnedGPtr implementation for
SoupMessageHeaders.
(WTF):

platform/network/soup/GOwnPtrSoup.h:

(WTF):

platform/network/soup/ResourceRequest.h:

(ResourceRequest):

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessageHeaders): New function
to update the given SoupMessageHeaders with the ResourceRequest
headers.
(WebCore::ResourceRequest::updateFromSoupMessageHeaders): New
function to update the ResourceRequest headers with the given
SoupMessageHeaders.
(WebCore::ResourceRequest::updateSoupMessage): Use
updateSoupMessageHeaders() to update the headers.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage): Use
updateFromSoupMessageHeaders to update the headers.

Source/WebKit2:

It allows to load requests with custom headers, or to update the
headers of a request before being sent to the server in the
WebKitWebPage::send-request callback.

UIProcess/API/gtk/WebKitURIRequest.cpp:

(_WebKitURIRequestPrivate): Add SoupMessageHeaders.
(webkit_uri_request_get_http_headers): Return the HTTP headers of
the request as a SoupMessageHeaders if the request is HTTP. A new
SoupMessageHeaders is created on demand using the existing headers
of the request.
(webkitURIRequestGetResourceRequest): Instead of returning a const
reference of the internal ResourceRequest, set a request passed as
a reference and update its HTTP headers using the
SoupMessageHeaders if present.

UIProcess/API/gtk/WebKitURIRequest.h:
UIProcess/API/gtk/WebKitURIRequestPrivate.h:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_load_request): Update to the new
webkitURIRequestGetResourceRequest API.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add

webkit_uri_request_get_http_headers symbol.

UIProcess/API/gtk/tests/TestLoaderClient.cpp:

(testWebPageURI):
(testURIRequestHTTPHeaders):
(serverCallback):
(beforeAll):

WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(willSendRequestForFrame): Update to the new
webkitURIRequestGetResourceRequest API.

Tools:

MiniBrowser/gtk/GNUmakefile.am: Add missing libsoup flags to

CPPFLAGS.

9:23 AM Changeset in webkit [145724] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] Handle "enter" key in {|} situation
https://bugs.webkit.org/show_bug.cgi?id=112153

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Add a keymap to handle "Enter" key and override it in case of {|}
situation.

No new tests.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.BlockIndentController):
(WebInspector.CodeMirrorTextEditor.BlockIndentController.prototype.Enter):

8:47 AM Changeset in webkit [145723] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] bug with LineWidgets
https://bugs.webkit.org/show_bug.cgi?id=111978

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Implement CodeMirrorTextEditor.beginUpdates and
CodeMirrorTextEditor.endUpdates and surround decoration creation
with the beginUpdates/endUpdates calls.

No new tests.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype.beginUpdates):
(WebInspector.CodeMirrorTextEditor.prototype.endUpdates):

inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype.addMessageToSource):

8:38 AM Changeset in webkit [145722] by commit-queue@webkit.org

23 edits in trunk/Source/WebKit/gtk

[GTK][Introspection] Fix of gtk doc annotation warnings
https://bugs.webkit.org/show_bug.cgi?id=109182

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-13
Reviewed by Martin Robinson.

Fixed some gtk doc annotation warnings that appears during
compiling. Also some white characters were removed and some restyling
was done - all the g_signal_new in webkit directory have now the same
style.

webkit/webkitdownload.cpp:

(webkit_download_class_init):

webkit/webkitfavicondatabase.cpp:

(webkit_favicon_database_class_init):

webkit/webkitgeolocationpolicydecision.cpp:
webkit/webkitglobals.cpp:
webkit/webkithittestresult.h:
webkit/webkiticondatabase.cpp:

(webkit_icon_database_class_init):

webkit/webkitsecurityorigin.cpp:
webkit/webkitsecurityorigin.h:
webkit/webkitsoupauthdialog.cpp:
webkit/webkitspellchecker.cpp:
webkit/webkitviewportattributes.cpp:

(webkit_viewport_attributes_class_init):

webkit/webkitwebdatabase.cpp:
webkit/webkitwebframe.cpp:

(webkit_web_frame_class_init):

webkit/webkitwebframe.h:
webkit/webkitwebinspector.cpp:

(webkit_web_inspector_class_init):

webkit/webkitwebnavigationaction.cpp:

(webkit_web_navigation_action_class_init):

webkit/webkitwebplugindatabase.cpp:
webkit/webkitwebpolicydecision.cpp:
webkit/webkitwebresource.cpp:

(webkit_web_resource_class_init):

webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):

webkit/webkitwebview.cpp:

(webkit_web_view_class_init):
(webkit_web_view_apply_zoom_level):

webkit/webkitwebwindowfeatures.cpp:

(webkit_web_window_features_equal):

8:37 AM Changeset in webkit [145721] by acolwell@chromium.org

5 edits in trunk/Source/WebKit/chromium

Cleanup dead MediaSource code now that the Chromium-side refactor is complete.
https://bugs.webkit.org/show_bug.cgi?id=110371

Reviewed by Adam Barth.

public/WebMediaPlayer.h:

(WebKit):
(WebMediaPlayer): Remove old MediaSource methods and default MediaSource load() implementation.

public/WebMediaPlayerClient.h: Remove old MediaSource methods.
src/WebMediaPlayerClientImpl.cpp: Remove WebMediaSourceClientImpl & WebSourceBufferImpl classes that

are no longer needed.

src/WebMediaPlayerClientImpl.h: Remove old MediaSource methods.

(WebMediaPlayerClientImpl):

8:34 AM Changeset in webkit [145720] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Touch Hold selection does not scroll text area or other subframe until selection reaches bottom of the page.
https://bugs.webkit.org/show_bug.cgi?id=112259

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-13
Reviewed by Rob Buis.

PR 267394

While selecting in a subframe, check that the selection reaches
the bottom of the current subframe instead of the page.

Internally Reviewed by Genevieve Mak.

Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::selectionViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):

WebKitSupport/SelectionHandler.h:

(BlackBerry::WebKit::SelectionHandler::setSelectionViewportRect):
(SelectionHandler):

8:24 AM Changeset in webkit [145719] by Simon Hausmann

15 edits in trunk

[Qt] Port TestRunner::findString to shared interface
https://bugs.webkit.org/show_bug.cgi?id=112147

Reviewed by Jocelyn Turcotte.

Source/WebKit/qt:

Add new find options used by the DRT.

WebCoreSupport/DumpRenderTreeSupportQt.cpp:
WebCoreSupport/DumpRenderTreeSupportQt.h:
WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::findText):

WebCoreSupport/QWebPageAdapter.h:
WidgetApi/qwebpage.cpp:
WidgetApi/qwebpage.h:

Tools:

This patch also removes DumpRenderTree and some other helper classes from
the WebCore namespace, to which they do not really belong.

DumpRenderTree/qt/DumpRenderTreeMain.cpp:

(main):

DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::~DumpRenderTree):
(DumpRenderTree::instance):
(DumpRenderTree::setShouldTimeout):

DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

DumpRenderTree/qt/EventSenderQt.cpp:

(EventSender::contextClick):
(EventSender::sendEvent):
(EventSender::postEvent):

DumpRenderTree/qt/EventSenderQt.h:

(EventSender::isGraphicsBased):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::TestRunnerQt):
(TestRunner::findString):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):

DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

7:25 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

7:22 AM Changeset in webkit [145718] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145561 - [GTK] Remove HILDON_CPPFLAGS and HILDON_CFLAGS references from GNUmakefiles
https://bugs.webkit.org/show_bug.cgi?id=112163

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - no new functionality, merely a cleanup.

GNUmakefile.am: The Hildon dependency doesn't exist anymore so there's no need for

references to HILDON_CPPFLAGS and HILDON_CFLAGS.

7:17 AM Changeset in webkit [145717] by pfeldman@chromium.org

33 edits in trunk/Source

Web Inspector: get rid of hiddenPanels filter
https://bugs.webkit.org/show_bug.cgi?id=112252

Reviewed by Vsevolod Vlasov.

Source/WebCore:

WebCore.order:
inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

inspector/InspectorFrontendHost.cpp:
inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/externs.js:
inspector/front-end/inspector.js:

(WebInspector._panelDescriptors):

testing/Internals.cpp:

Source/WebKit/chromium:

src/InspectorFrontendClientImpl.cpp:
src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

Source/WebKit/efl:

WebCoreSupport/InspectorClientEfl.cpp:
WebCoreSupport/InspectorClientEfl.h:

(InspectorFrontendClientEfl):

Source/WebKit/gtk:

WebCoreSupport/InspectorClientGtk.cpp:
WebCoreSupport/InspectorClientGtk.h:

(InspectorFrontendClient):

Source/WebKit/mac:

WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

WebCoreSupport/WebInspectorClient.mm:
WebKit.order:

Source/WebKit/qt:

WebCoreSupport/InspectorClientQt.cpp:

(WebCore):

WebCoreSupport/InspectorClientQt.h:

(InspectorFrontendClientQt):

Source/WebKit/win:

WebCoreSupport/WebInspectorClient.cpp:
WebCoreSupport/WebInspectorClient.h:

(WebInspectorFrontendClient):

Source/WebKit2:

WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:

(WebInspectorFrontendClient):

7:14 AM Changeset in webkit [145716] by pfeldman@chromium.org

12 edits
2 deletes in trunk/LayoutTests

Not reviewed: chromium baselines.

platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt: Removed.
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:

7:13 AM Changeset in webkit [145715] by Philippe Normand

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

[GTK] POTFILES.in references a removed file
https://bugs.webkit.org/show_bug.cgi?id=112248

Unreviewed, follow-up build fix after r145713.

POTFILES.in: WebKitAuthenticationWidget.cpp contains

translatable strings to be processed by gettext.

7:13 AM Changeset in webkit [145714] by mnaganov@chromium.org

4 edits in trunk

[Chromium] Rename android_build_type to android_webview_build in .gyp files.
https://bugs.webkit.org/show_bug.cgi?id=112129

Reviewed by Adam Barth.

Following Chromium
http://src.chromium.org/viewvc/chrome?view=rev&revision=187556
this is being renamed to better explain what it does.

Source/WebKit/chromium:

WebKitUnitTests.gyp:

Tools:

DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

6:52 AM Changeset in webkit [145713] by Philippe Normand

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore/platform/gtk/po

[GTK] POTFILES.in references a removed file
https://bugs.webkit.org/show_bug.cgi?id=112248

Unreviewed, build fix.

POTFILES.in: Remove reference to non-existant file.

6:38 AM Changeset in webkit [145712] by pfeldman@chromium.org

17 edits in trunk/Source

Web Inspector: convert workers inspection into capability
https://bugs.webkit.org/show_bug.cgi?id=112251

Reviewed by Vsevolod Vlasov.

Source/WebCore:

It should be up to backend

inspector/Inspector.json:
inspector/InspectorFrontendClient.h:

(InspectorFrontendClient):

inspector/InspectorFrontendClientLocal.h:
inspector/InspectorFrontendHost.cpp:
inspector/InspectorFrontendHost.h:

(InspectorFrontendHost):

inspector/InspectorFrontendHost.idl:
inspector/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::canInspectWorkers):
(WebCore):

inspector/InspectorWorkerAgent.h:

(InspectorWorkerAgent):

inspector/front-end/InspectorFrontendHostStub.js:
inspector/front-end/Settings.js:
inspector/front-end/externs.js:
inspector/front-end/inspector.js:

(WebInspector.doLoadedDone):

Source/WebKit/chromium:

src/InspectorFrontendClientImpl.cpp:
src/InspectorFrontendClientImpl.h:

(InspectorFrontendClientImpl):

6:38 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

6:36 AM Changeset in webkit [145711] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.0

Merge r145395 - [GTK] WebKit2-only build fails
https://bugs.webkit.org/show_bug.cgi?id=112033

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

GNUmakefile.am: Introduce the artifical dependency of libwebkit2gtk on libwebkitgtk only

if building WebKit1 as well. Similarly with the WebKitPluginProcess, depend on libwebkitgtk
only if building WebKit1, the dependency is otherwise not necessary.

Tools:

GNUmakefile.am: Split the list of files the docs-build.stamp target depends on into the

generic part, WebKit1-specific part and WebKit2-specific part.

TestWebKitAPI/GNUmakefile.am: The TestGtk executable should not link agains libwebkitgtk

as it is not WebKit1-specific, but should rather link to libWebCore.la and libWebCoreGtk.la
directly.

6:34 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

6:33 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

6:30 AM Changeset in webkit [145710] by mikhail.pozdnyakov@intel.com

7 edits in trunk/Source/WebCore

[EFL] Start using evas object directly in Widget class
https://bugs.webkit.org/show_bug.cgi?id=111858

Reviewed by Antonio Gomes.

Based on a patch by Kenneth Rohde Christiansen.

EFL Widget class should use evas object pointer directly rather
than WidgetPrivate* m_data as platformWidget() is a Mac specific
implementation detail that they are moving away from with WebKit2.

This patch brings: firstly better compliance with other ports,
secondly it makes code cleaner.

Besides, the evasObject is only directly used in the ScrollbarEfl
subclass of Widget and not in Widget or ScrollView or any other subclass,
thus the evas_object code has now been concentrated in ScrollbarEfl.

No new tests as there are no behavioral changes.

page/efl/EventHandlerEfl.cpp:
platform/Widget.h:

(Widget):
(WebCore::Widget::evasObject):

platform/efl/ScrollbarEfl.cpp:

(ScrollbarEfl::~ScrollbarEfl):
(scrollbarEflEdjeMessage):
(ScrollbarEfl::show):
(ScrollbarEfl::hide):
(ScrollbarEfl::setParent):
(ScrollbarEfl::updateThumbPositionAndProportion):
(ScrollbarEfl::frameRectsChanged):

platform/efl/ScrollbarEfl.h:

(ScrollbarEfl):

platform/efl/WidgetEfl.cpp:

(WebCore::Widget::Widget):
(WebCore::Widget::~Widget):
(WebCore::Widget::frameRectsChanged):
(WebCore::Widget::show):
(WebCore::Widget::hide):
(WebCore::Widget::setEvasObject):

plugins/efl/PluginViewEfl.cpp:

(WebCore::PluginView::platformGetValue):

6:01 AM Changeset in webkit [145709] by Simon Hausmann

2 edits in trunk/Tools

[Qt] Unreviewed trivial typo fix

DumpRenderTree/qt/DumpRenderTree.pro: It's TestRunner.h, not

TextRunner.h. Thanks Zeno :)

5:48 AM Changeset in webkit [145708] by Simon Hausmann

6 edits in trunk/Tools

[Qt] Prepare DRT for transition to shared TestRunner interface
https://bugs.webkit.org/show_bug.cgi?id=112144

Reviewed by Benjamin Poulain.

Prepare Qt's DRT for a transition from the QObject based TestRunner to
the JSC C API based one.

This is impplemented by instantiating the QObject based testRunner in
the global object, then instantiating the JSC C based TestRunner
separately and placing it "behind" the QObject based testRunner through
injection of the individual functions through proxies. (prototype
chaining doesn't work due to the this object and Function.prototype.bind
doesn't work due to the native function)

This allows for porting over method by method by removing the method
from the QObject TestRunnerQt and implementing it in the JSC C based
TestRunner.

In order for this to link and run dummy implementations of all the
necessary TestRunner functions are provided.

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/DumpRenderTreeMain.cpp:
DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::initJSObjects):

DumpRenderTree/qt/DumpRenderTreeQt.h:

(DumpRenderTree):

DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunner::~TestRunner):
(TestRunner::addDisallowedURL):
(TestRunner::queueLoad):
(TestRunner::removeAllVisitedLinks):
(TestRunner::setAcceptsEditing):
(TestRunner::simulateLegacyWebNotificationClick):
(TestRunner::setWindowIsKey):
(TestRunner::setAlwaysAcceptCookies):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::setWebViewEditable):
(TestRunner::clearAllApplicationCaches):
(TestRunner::setTextDirection):
(TestRunner::notifyDone):
(TestRunner::numberOfPendingGeolocationPermissionRequests):
(TestRunner::overridePreference):
(TestRunner::pathToLocalResource):
(TestRunner::removeAllWebNotificationPermissions):
(TestRunner::simulateWebNotificationClick):
(TestRunner::closeIdleLocalStorageDatabases):
(TestRunner::focusWebView):
(TestRunner::setBackingScaleFactor):
(TestRunner::removeChromeInputField):
(TestRunner::addChromeInputField):
(TestRunner::originsWithLocalStorage):
(TestRunner::deleteAllLocalStorage):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::observeStorageTrackerNotifications):
(TestRunner::syncLocalStorage):
(TestRunner::windowCount):
(TestRunner::setWaitToDump):
(TestRunner::waitForPolicyDelegate):
(TestRunner::webHistoryItemCount):
(TestRunner::showWebInspector):
(TestRunner::closeWebInspector):
(TestRunner::evaluateInWebInspector):
(TestRunner::setSerializeHTTPLoads):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(TestRunner::setCustomPolicyDelegate):
(TestRunner::setDatabaseQuota):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::resetPageVisibility):
(TestRunner::keepWebHistory):
(TestRunner::goBack):
(TestRunner::originsWithApplicationCache):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::display):
(TestRunner::dispatchPendingLoadRequests):
(TestRunner::clearPersistentUserStyleSheet):
(TestRunner::callShouldCloseOnWebView):
(TestRunner::copyDecodedHostName):
(TestRunner::clearBackForwardList):
(TestRunner::clearAllDatabases):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::apiTestGoToCurrentBackForwardItem):
(TestRunner::authenticateSession):
(TestRunner::abortModal):
(TestRunner::setStorageDatabaseIdleInterval):
(TestRunner::setAsynchronousSpellCheckingEnabled):
(TestRunner::setXSSAuditorEnabled):
(TestRunner::setSpatialNavigationEnabled):
(TestRunner::setScrollbarPolicy):
(TestRunner::setJavaScriptCanAccessClipboard):
(TestRunner::setAutomaticLinkDetectionEnabled):
(TestRunner::setUserStyleSheetEnabled):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setUseDashboardCompatibilityMode):
(TestRunner::setTabKeyCyclesThroughElements):
(TestRunner::setSmartInsertDeleteEnabled):
(TestRunner::setSelectTrailingWhitespaceEnabled):
(TestRunner::setPrivateBrowsingEnabled):
(TestRunner::setPluginsEnabled):
(TestRunner::setPopupBlockingEnabled):
(TestRunner::setMockSpeechInputDumpRect):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setMockDeviceOrientation):
(TestRunner::setMainFrameIsFirstResponder):
(TestRunner::setIconDatabaseEnabled):
(TestRunner::setGeolocationPermission):
(TestRunner::setDefersLoading):
(TestRunner::setCacheModel):
(TestRunner::setAuthorAndUserStylesEnabled):
(TestRunner::setAllowFileAccessFromFileURLs):
(TestRunner::setAppCacheMaximumSize):
(TestRunner::setAllowUniversalAccessFromFileURLs):
(TestRunner::setApplicationCacheOriginQuota):
(TestRunner::denyWebNotificationPermission):
(TestRunner::grantWebNotificationPermission):
(TestRunner::setValueForUser):
(TestRunner::setViewModeMediaFeature):
(TestRunner::setPageVisibility):
(TestRunner::addMockSpeechInputResult):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::isCommandEnabled):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunner::copyEncodedHostName):
(TestRunner::addUserStyleSheet):
(TestRunner::findString):
(TestRunner::execCommand):
(TestRunner::localStorageDiskUsageForOrigin):

5:48 AM Changeset in webkit [145707] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] token highlight still has some problems
https://bugs.webkit.org/show_bug.cgi?id=112173

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Use pseudo elements with borders to draw token highlight.

No new tests.

inspector/front-end/cm/cmdevtools.css:

(.cm-token-highlight):
(.cm-token-highlight:before):
(.cm-line-with-selection .cm-column-with-selection:before):

5:42 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com

(diff)

5:38 AM Changeset in webkit [145706] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] SimpleFontData: remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=112149

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-13
Reviewed by Carlos Garcia Campos.

smallCapsFontData() and emphasisMarkFontData() were moved from
platform specific files into platform/graphics/SimpleFontData.cpp
in r133362, so the BlackBerry port no longer needs its own
implementation.

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

5:20 AM Changeset in webkit [145705] by pfeldman@chromium.org

1 edit
2 deletes in trunk/LayoutTests

Not reviewed: chromium baselines.

platform/chromium-linux/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.
platform/chromium-win/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt: Removed.

5:18 AM Changeset in webkit [145704] by loislo@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: throw an exception if the requested lazy loaded script does not exist.
https://bugs.webkit.org/show_bug.cgi?id=112237

Reviewed by Pavel Feldman.

inspector/front-end/utilities.js:

5:13 AM Changeset in webkit [145703] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

LLINT C loop warning fix for GCC
https://bugs.webkit.org/show_bug.cgi?id=112145

Reviewed by Filip Pizlo.

llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

4:27 AM Changeset in webkit [145702] by jocelyn.turcotte@digia.com

2 edits in trunk/Source/WebKit2

[WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner start
https://bugs.webkit.org/show_bug.cgi?id=112223

Reviewed by Simon Hausmann.

We need to only enable the cookie jar and the disk cache conditionally
in the web process since we removed default paths and WKTR doesn't provide
them.

WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

4:22 AM Changeset in webkit [145701] by allan.jensen@digia.com

2 edits in trunk/Source/WTF

Support C++11 features in GCC <4.6
https://bugs.webkit.org/show_bug.cgi?id=111553

Reviewed by Simon Hausmann.

Enable support for rvalue references from gcc 4.3, deleted functions
from gcc 4.4, explicit conversion from gcc 4.5, and strongly typed
enums from gcc 4.6.

wtf/Compiler.h:

3:14 AM Changeset in webkit [145700] by Simon Hausmann

3 edits
2 adds in trunk/Source/JavaScriptCore

Add support for convenient conversion from JSStringRef to QString
https://bugs.webkit.org/show_bug.cgi?id=109694

Reviewed by Allan Sandfeld Jensen.

Add JSStringCopyQString helper function that allows for the convenient
extraction of a QString out of a JSStringRef.

API/JSStringRefQt.cpp: Added.

(JSStringCopyQString):

API/JSStringRefQt.h: Added.
API/OpaqueJSString.h:

(OpaqueJSString):
(OpaqueJSString::qString):
(OpaqueJSString::OpaqueJSString):

Target.pri:

3:13 AM Changeset in webkit [145699] by apavlov@chromium.org

3 edits in branches/chromium/1410

Merge 144608 "Web Inspector: touchmove not emulated inside iframe"

Web Inspector: touchmove not emulated inside iframe
https://bugs.webkit.org/show_bug.cgi?id=111292

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Move fake touch event dispatching from mouseMoved() into handleMouseMoveEvent()
and bail out earlier from dispatchSyntheticTouchEventIfEnabled() when the event
should be dispatched on a subframe.

page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

LayoutTests:

fast/events/touch/emulated-touch-iframe.html:
fast/events/touch/resources/emulated-touch-iframe2.html:

TBR=apavlov@chromium.org
Review URL: https://codereview.chromium.org/12561004

2:58 AM Changeset in webkit [145698] by kadam@inf.u-szeged.hu

4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing compositing tests.

platform/qt-5.0-wk1/TestExpectations:
platform/qt-5.0-wk2/TestExpectations:
platform/qt/TestExpectations:

2:46 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:45 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:44 AM Changeset in webkit [145697] by Carlos Garcia Campos

16 edits
6 adds
4 deletes in releases/WebKitGTK/webkit-2.0

[GTK] Split GtkAuthenticationDialog in two widgets
https://bugs.webkit.org/show_bug.cgi?id=103644

Reviewed by Xan Lopez.

Source/autotools/Versions.m4: Bump GTK+ 2 requirements to 2.16

for GtkOrientable.

Source/WebCore:

The current GtkAuthenticationDialog implements both the common
logic and widgets to implement a real GtkDialog and a widget to be
embedded in any container. WebKit1 uses a GtkDialog while WebKit2
embeds the dialog in the WebView. This patch splits the code to
leave in Platform only the code that is actually common, leaving
the widget implementation to the WebKit layer, using a dialog in
WebKit1 and embedding auth widget in the WebView in WebKit2.

GNUmakefile.list.am: Add new files to compilation.
platform/gtk/GtkAuthenticationDialog.cpp: Removed.
platform/gtk/GtkAuthenticationDialog.h: Removed.
platform/gtk/WebKitAuthenticationWidget.cpp: Added.

(_WebKitAuthenticationWidgetPrivate):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationWidgetInitialize):
(webkitAuthenticationWidgetFinalize):
(webkit_authentication_widget_init):
(webkit_authentication_widget_class_init):
(webkitAuthenticationWidgetNew):
(webkitAuthenticationWidgetCreateCredential):
(webkitAuthenticationWidgetGetChallenge):

platform/gtk/WebKitAuthenticationWidget.h: Added.

(_WebKitAuthenticationWidget):
(_WebKitAuthenticationWidgetClass):

Source/WebKit/gtk:

GNUmakefile.am: Add new files to compilation.
WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Use helper createAuthenticationDialog() to create and show the
auth dialog.

webkit/webkitauthenticationdialog.cpp: Added.

(authenticationDialogResponseCallback):
(createAuthenticationDialog):

webkit/webkitauthenticationdialog.h: Added.
webkit/webkitsoupauthdialog.cpp:

(sessionAuthenticate): Ditto.

Source/WebKit2:

GNUmakefile.list.am: Add new files to compilation.
UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.

(webkitAuthenticationDialogAuthenticate): Use the
AuthenticationChallengeProxy to authenticate and destroy the dialog.
(okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
with the credential.
(cancelButtonClicked): Call
webkitAuthenticationDialogAuthenticate() with a NULL credential to
continue without credential.
(webkitAuthenticationDialogInitialize): Build the UI.
(webkitAuthenticationDialogDraw): Draw a background.
(webkitAuthenticationDialogMap): Grab default button.
(webkitAuthenticationDialogConstructed): Create a GtkStyleContext
with the GtkWindow path to draw the widget background like a real
dialog.
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew): Create a new
WebKitAuthenticationDialog widget.

UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
UIProcess/API/gtk/WebKitLoaderClient.cpp:
UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewHandleAuthenticationChallenge): Create a
WebKitAuthenticationDialog widget and pass add it to the
container.

UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Updated to use the widget directly.
(webkitWebViewChildIsInternalWidget): Ditto.
(webkitWebViewBaseAddAuthenticationDialog): Ditto.
(webkitWebViewBaseCancelAuthenticationDialog): Ditto.
(webkitWebViewBaseContainerRemove): Ditto.
(webkitWebViewBaseContainerForall): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseFocus): Ditto.
(webkitWebViewBaseDestroy): Destroy the auth widget is present.
(webkit_web_view_base_class_init): Add implementation for
GtkWidgetClass::destroy.

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Tools:

gtk/generate-gtkdoc:

(get_webkit2_options): Do not generate api docs for
WebKitAuthenticationDialog which is private in WebKit2.
(get_webkit1_options): Do not generate api docs for
webkitauthenticationdialog which is private in WebKit1.

2:38 AM Changeset in webkit [145696] by mihnea@adobe.com

10 edits
5 adds
2 deletes in trunk/LayoutTests

[chromium] Layout Test fast/repaint/japanese-rl-selection-repaint-in-regions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106097

Reviewed by Tony Chang.

After http://trac.webkit.org/changeset/138785, the content overflowing the last region in chain is
displayed properly in vertical-rl writing mode. This determined the failure of japanese-rl-selection-repaint-in-regions.html
test due to the overflowing content that now appears when rendered.

I modified the original test by decreasing the font size so that the content is not overflowing, because the purpose
of the original test was not to check the overflowed content anyway. I have generated new expected results for mac and chromium
and unskipped the test on chromium and mac.

fast/repaint/japanese-rl-selection-repaint-in-regions.html:
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/chromium-mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Removed.
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/chromium/TestExpectations:
platform/chromium/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Removed.
platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
platform/mac-lion/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
platform/mac/TestExpectations:
platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png:
platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:

2:32 AM Changeset in webkit [145695] by mkwst@chromium.org

7 edits in trunk/Source/WebCore

Pass the XSSAuditor's report URL to the XSSAuditorDelegate on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=112179

Reviewed by Adam Barth.

Rather than relying on XSSInfo objects to move the XSSAuditor's report
URL into the XSSAuditorDelegate for reporting, we should be able to grab
the URL directly from XSSAuditor before it moves off the main thread,
and store it on the delegate.

This will enable us to drop the report URL properties from both
XSSAuditor and XSSInfo. Oh, happy day!

html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::sendTokensToMainThread):

We no longer need to check whether XSSInfo objects are thread safe,
as we've dropped the only problematic bit.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::startBackgroundParser):

html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):

When initializing the XSSAuditor, pass in an XSSAuditorDelegate*
and assign the report URL directly onto that object.

(WebCore::XSSAuditor::filterToken):

Drop the report URL parameter from XSSInfo objects we create in the
Auditor, as they're now handled directly from the delegate.

(WebCore::XSSAuditor::isSafeToSendToAnotherThread):

Drop the report URL property from XSSAuditor's threadsafeness check,
as properties that do not exist are automatically thread-safe.

html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

Use the delegate's own report URL rather than the XSSInfo objects'.

html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):

Drop the report URL property from XSSInfo.

(WebCore::XSSAuditorDelegate::setReportURL):
(XSSAuditorDelegate):

Provide a public API for setting a delegate's report URL.

2:26 AM Changeset in webkit [145694] by Christophe Dumez

2 edits in trunk/LayoutTests

[EFL] http/tests/websocket/tests/hybi/close-on-navigate-new-location.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112231

Reviewed by Kentaro Hara.

close-on-navigate-new-location.html tests that the websocket is closed when navigating
to a new location (handler_map.txt). However, handler_map.txt does not exist so we get
an HTTP 404 error and we end up not navigating. This patch fixes the navigation path
to "../handler_map.txt" since the file is actually in the parent folder.

http/tests/websocket/tests/hybi/close-on-navigate-new-location.html:

2:17 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:15 AM Changeset in webkit [145693] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145542 - [Gtk] NBSP are not replaced when using X clipboard
https://bugs.webkit.org/show_bug.cgi?id=112118

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-12
Reviewed by Martin Robinson.

We're not replacing nbsp with spaces when using X clipboard
(Shift+Insert or middle mouse button).

platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::text):

2:13 AM Changeset in webkit [145692] by mkwst@chromium.org

127 edits
1 delete in trunk

Unsafe JavaScript attempt errors are ludicrously verbose and annoying
https://bugs.webkit.org/show_bug.cgi?id=112042

Reviewed by Timothy Hatcher.

Source/WebCore:

This patch attempts to make the most common case of error message less
ludicrous by adjusting it to include only an origin as opposed to full
URLs for the active and target frames. It now reads: "Blocked a frame
with origin 'http://127.0.0.1:8000' from accessing a frame with origin
'http://localhost:8000'. Protocols, domains, and ports must match."

In the interest of keeping the patch size down, I'll follow up on the
other cases (sandboxed access, 'document.domain' mismatches, etc) in
future patches.

page/DOMWindow.cpp:

(WebCore::DOMWindow::crossDomainAccessErrorMessage):

LayoutTests:

fast/xmlhttprequest/xmlhttprequest-no-file-access-expected.txt:
http/tests/history/cross-origin-replace-history-object-child-expected.txt:
http/tests/history/cross-origin-replace-history-object-expected.txt:
http/tests/inspector-protocol/access-inspected-object-expected.txt:
http/tests/plugins/cross-frame-object-access-expected.txt:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
http/tests/security/cross-frame-access-call-expected.txt:
http/tests/security/cross-frame-access-custom-expected.txt:
http/tests/security/cross-frame-access-delete-expected.txt:
http/tests/security/cross-frame-access-enumeration-expected.txt:
http/tests/security/cross-frame-access-first-time-expected.txt:
http/tests/security/cross-frame-access-frameelement-expected.txt:
http/tests/security/cross-frame-access-get-custom-property-cached-expected.txt:
http/tests/security/cross-frame-access-get-expected.txt:
http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
http/tests/security/cross-frame-access-history-get-expected.txt:
http/tests/security/cross-frame-access-history-put-expected.txt:
http/tests/security/cross-frame-access-location-get-expected.txt:
http/tests/security/cross-frame-access-location-put-expected.txt:
http/tests/security/cross-frame-access-name-getter-expected.txt:
http/tests/security/cross-frame-access-object-getPrototypeOf-expected.txt:
http/tests/security/cross-frame-access-object-prototype-expected.txt:
http/tests/security/cross-frame-access-port-expected.txt:
http/tests/security/cross-frame-access-put-expected.txt:
http/tests/security/cross-frame-access-selection-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-from-javascript-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-subframe-expected.txt:
http/tests/security/javascriptURL/xss-DENIED-to-javascript-url-in-foreign-domain-window-open-expected.txt:
http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame-expected.txt:
http/tests/security/xss-DENIED-assign-location-hash-expected.txt:
http/tests/security/xss-DENIED-assign-location-host-expected.txt:
http/tests/security/xss-DENIED-assign-location-hostname-expected.txt:
http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
http/tests/security/xss-DENIED-assign-location-nonstandardProperty-expected.txt:
http/tests/security/xss-DENIED-assign-location-pathname-expected.txt:
http/tests/security/xss-DENIED-assign-location-protocol-expected.txt:
http/tests/security/xss-DENIED-assign-location-reload-expected.txt:
http/tests/security/xss-DENIED-assign-location-search-expected.txt:
http/tests/security/xss-DENIED-defineProperty-expected.txt:
http/tests/security/xss-DENIED-frame-name-expected.txt:
http/tests/security/xss-DENIED-getSVGDocument-iframe-expected.txt:
http/tests/security/xss-DENIED-getSVGDocument-object-expected.txt:
http/tests/security/xss-DENIED-htmlelelment-with-iframe-proto-expected.txt:
http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
http/tests/security/xss-DENIED-javascript-with-spaces-expected.txt:
http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
http/tests/security/xss-DENIED-synchronous-form-expected.txt:
http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt:
http/tests/security/xss-DENIED-window-open-javascript-url-expected.txt:
http/tests/security/xss-DENIED-window-open-javascript-url-with-spaces-expected.txt:
http/tests/security/xss-DENIED-window-open-parent-expected.txt:
http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt:
http/tests/security/xss-eval-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt:
platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
platform/chromium/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
platform/chromium/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-document-direct-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-enumeration-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-history-get-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-history-put-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-location-put-expected.txt:
platform/chromium/http/tests/security/cross-frame-access-put-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-from-data-url-to-data-url-expected.txt:
platform/chromium/http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-location-htmldom-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-getAttribute-value-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-htmldom-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttribute-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNS-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNode-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-frame-src-setAttributeNodeNS-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-getAttribute-value-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-htmldom-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttribute-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNS-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNode-expected.txt:
platform/chromium/http/tests/security/javascriptURL/javascriptURL-execution-context-iframe-src-setAttributeNodeNS-expected.txt:
platform/chromium/http/tests/security/listener/xss-inactive-closure-expected.txt:
platform/chromium/http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
platform/chromium/http/tests/security/xss-DENIED-defineProperty-expected.txt:
platform/chromium/http/tests/security/xss-DENIED-frame-name-expected.txt:

2:09 AM Changeset in webkit [145691] by tasak@google.com

8 edits
2 adds in trunk

Implement :scope for element.querySelector[All]()
https://bugs.webkit.org/show_bug.cgi?id=81069

Reviewed by Dimitri Glazkov.

Source/WebCore:

Implemented :scope for element.querySelector[All]().
Reuse scope in SelectorCheckingContext and added a new value to
enum BehaviorAtBoundary.
:scope spec is http://dev.w3.org/csswg/selectors4/#scope-pseudo.

Test: fast/selectors/querySelector-scope.html

css/CSSSelector.cpp:

(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
Added :scope pseudo type.

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::checkOne):
Added PseudoScope case and modified "scope" meaning when
behaviorAtBoundary is equal to StaysWithinTreeScope.
If so, "scope" is just a contextual reference node.

css/SelectorChecker.h:
dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::selectorMatches):
(WebCore::SelectorDataList::matches):
(WebCore::SelectorDataList::execute):
Use rootNode as a contextual reference node.

dom/SelectorQuery.h:

(SelectorDataList):

LayoutTests:

fast/selectors/querySelector-scope-expected.txt: Added.
fast/selectors/querySelector-scope.html: Added.

2:09 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

2:07 AM Changeset in webkit [145690] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0

Merge r145560 - [GTK] 'unrecognized command line option "-Wno-c++11-extensions"' warning reported when using gcc
https://bugs.webkit.org/show_bug.cgi?id=111936

Reviewed by Martin Robinson.

Source/autotools/SetupCompilerFlags.m4: Only use the -Wno-c++11-extensions warning when building

with Clang as GCC does not support the warning just yet. Also enhance the comment about using libstdc++
as the standard C++ library when compiling with Clang.

2:07 AM Changeset in webkit [145689] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Token 'not' is ignored in the offlineasm.
https://bugs.webkit.org/show_bug.cgi?id=111568

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-03-13
Reviewed by Filip Pizlo.

offlineasm/parser.rb: Build the Not AST node if the 'not' token is found.

2:06 AM Changeset in webkit [145688] by zarvai@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/TestExpectations:

2:06 AM Changeset in webkit [145687] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[BlackBerry] FontPlatformData: remove TextOrientation parameter
https://bugs.webkit.org/show_bug.cgi?id=112135

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-13
Reviewed by Rob Buis.

This doesn't exist since r136520.

platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::createFontPlatformData):

platform/graphics/blackberry/FontCustomPlatformData.h:

(FontCustomPlatformData):

platform/graphics/blackberry/FontCustomPlatformDataBlackBerry.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData):

platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::applyState):

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::createScaledFontData):

1:58 AM Changeset in webkit [145686] by mikhail.pozdnyakov@intel.com

11 edits in trunk/LayoutTests

[EFL] Unreviewed rebaseline.

platform/efl/compositing/overflow/composited-scrolling-paint-phases-expected.txt:

Rebaseline after r145422.

platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
platform/efl/css3/flexbox/flexbox-baseline-expected.txt:
platform/efl/fast/css-generated-content/015-expected.txt:
platform/efl/fast/css/h1-in-section-elements-expected.txt:
platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
platform/efl/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
platform/efl/tables/mozilla/bugs/bug126742-expected.txt:
platform/efl/tables/mozilla/bugs/bug69187-expected.txt:

Rebaseline after r145242.

1:13 AM Changeset in webkit [145685] by mikhail.pozdnyakov@intel.com

12 edits in trunk/LayoutTests

EFL rebaseline after r145242.

platform/efl/css1/basic/inheritance-expected.txt:
platform/efl/css1/box_properties/clear_float-expected.txt:
platform/efl/css1/box_properties/margin-expected.txt:
platform/efl/css1/box_properties/margin_bottom-expected.txt:
platform/efl/css1/box_properties/margin_top-expected.txt:
platform/efl/css1/box_properties/padding-expected.txt:
platform/efl/css1/box_properties/padding_bottom-expected.txt:
platform/efl/css1/box_properties/padding_top-expected.txt:
platform/efl/css1/color_and_background/background_attachment-expected.txt:
platform/efl/css1/font_properties/font_weight-expected.txt:
platform/efl/css1/formatting_model/vertical_formatting-expected.txt:

12:52 AM Changeset in webkit [145684] by kadam@inf.u-szeged.hu

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/TestExpectations: Adding failure expectation for the SVG test after r145541.

12:43 AM Changeset in webkit [145683] by kadam@inf.u-szeged.hu

2 edits
50 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskipp some passing compositing tests.

platform/qt-5.0-wk1/TestExpectations:
platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.png: Added.
platform/qt-5.0-wk1/compositing/direct-image-compositing-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.png: Added.
platform/qt-5.0-wk1/compositing/geometry/fixed-in-composited-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/layer-due-to-layer-children-switch-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt: Added.
platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.png: Added.
platform/qt-5.0-wk1/compositing/geometry/video-fixed-scrolling-expected.txt: Added.
platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.png: Added.
platform/qt-5.0-wk1/compositing/iframes/iframe-copy-on-scroll-expected.txt: Added.
platform/qt-5.0-wk1/compositing/iframes/iframe-size-from-zero-expected.txt: Added.
platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt: Added.
platform/qt-5.0-wk1/compositing/layer-creation/scroll-partial-update-expected.txt: Added.
platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.png: Added.
platform/qt-5.0-wk1/compositing/layer-creation/spanOverlapsCanvas-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/overflow-overlay-with-touch-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.png: Added.
platform/qt-5.0-wk1/compositing/overflow/scroll-ancestor-update-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/scrolling-without-painting-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
platform/qt-5.0-wk1/compositing/overflow/updating-scrolling-content-expected.txt: Added.
platform/qt-5.0-wk1/compositing/plugins/no-backing-store-expected.txt: Added.
platform/qt-5.0-wk1/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
platform/qt-5.0-wk1/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.png: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.png: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.png: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.png: Added.
platform/qt-5.0-wk1/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Added.
platform/qt-5.0-wk1/compositing/self-painting-layers-expected.png: Added.
platform/qt-5.0-wk1/compositing/self-painting-layers-expected.txt: Added.
platform/qt-5.0-wk1/compositing/video/video-poster-expected.txt: Added.

12:12 AM Changeset in webkit [145682] by zandobersek@gmail.com

2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding expectations for a couple of flaky crashers on the debug builder.
Adding flaky failure expectations for a couple of SVG animations tests.
Adding failure expectation for the SVG test introduced in 145541, failing due to disabled subpixel layout.

platform/gtk/TestExpectations:

Mar 12, 2013:

10:44 PM Changeset in webkit [145681] by vsevik@chromium.org

4 edits in trunk/LayoutTests

Unreviewed inspector test fix.

http/tests/inspector/resource-tree/resource-request-content-after-loading-and-clearing-cache.html:
inspector/datagrid-autosize.html:
inspector/debugger/breakpoint-manager-listeners-count.html:

9:55 PM Changeset in webkit [145680] by Antti Koivisto

5 edits
3 adds in trunk

Basic child obscuration test for backgrounds
https://bugs.webkit.org/show_bug.cgi?id=111701

Source/WebCore:

Reviewed by Simon Fraser.

Test: fast/repaint/obscured-background-no-repaint.html

We can easily detect some simple cases where a background image is fully obscured by an opaque child.

This avoids unncessary painting and image decoding. It is especially helpful for cases like about.com home
page where a fully obscured 'loading' spinner keeps triggering frequent complex repaints (gif animations
progress by getting painted and stop if they are not).

This could be made way more sophisticated. The checking could also be done per-layout rather per-paint.
Even this simple approach gets hit surprisingly often in real world sites.

rendering/RenderBox.cpp:

(WebCore::RenderBox::backgroundIsObscured):

Before painting background test if any single child renderer fully obscures it.

(WebCore::RenderBox::backgroundIsOpaqueInRect):

rendering/RenderBox.h:

LayoutTests:

Reviewed by Simon Fraser.

fast/repaint/obscured-background-no-repaint-expected.txt: Added.
fast/repaint/obscured-background-no-repaint.html: Added.
fast/repaint/resources/animated.gif: Added.

9:14 PM Changeset in webkit [145679] by jparent@chromium.org

5 edits in trunk/Tools

Cleanup: Move flatten-trie to loader.
https://bugs.webkit.org/show_bug.cgi?id=112196

Reviewed by Dirk Pranke.

flatten-trie is used only by the loader, so move it there and make it
private, rather than global in dashbaord_base. Moved the corresponding
unit test from flakiness_dashboard_unittests to loader_unittests.

TestResultServer/static-dashboards/dashboard_base.js:
TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/loader_unittests.js:

8:59 PM Changeset in webkit [145678] by ggaren@apple.com

3 edits in trunk/Source/WTF

Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.

wtf/SchedulePair.cpp:
wtf/SchedulePair.h:

(WTF::SchedulePair::SchedulePair): Since linking is failing,
try inlining this function.

8:51 PM Changeset in webkit [145677] by hayato@chromium.org

3 edits in trunk/Source/WebCore

[Crash] Touch Events retargeting causes crashes on chrome on android.
https://bugs.webkit.org/show_bug.cgi?id=112210

Reviewed by Dimitri Glazkov.

Added null-check for TouchEvent's touches(), targetTouches() and changedTouches().

No new tests - no new functionality.

dom/EventRetargeter.cpp:

(WebCore::EventRetargeter::adjustForTouchEvent):
(WebCore::EventRetargeter::adjustTouchList):

dom/EventRetargeter.h:

8:46 PM Changeset in webkit [145676] by Christophe Dumez

2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_popup_menu_close() does not work as intended
https://bugs.webkit.org/show_bug.cgi?id=110209

Reviewed by Laszlo Gombos.

ewk_popup_menu_close() is called by the browser to notify WebKit that
the popup menu was closed. However, the implementation was calling
EwkView::closePopupMenu() which was asking the browser to close the
popup menu via an Evas smart function. This patch fixes the behavior
and ewk_popup_menu_close() now calls WKPopupMenuListenerSetSelection()
C API so that the WebProcess is notified that the popup menu was
hidden.

UIProcess/API/efl/ewk_popup_menu.cpp:

(EwkPopupMenu::close):

8:07 PM Changeset in webkit [145675] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r187688. Requested by
"James Robinson" <jamesr@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

DEPS:

7:59 PM Changeset in webkit [145674] by ggaren@apple.com

1 edit
1 delete in trunk/Source/WebCore

2013-03-12 Geoffrey Garen <ggaren@apple.com>

Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.

platform/RunLoopTimer.h: Removed.

7:29 PM Changeset in webkit [145673] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r142657. <rdar://problem/13334856>

7:26 PM Changeset in webkit [145672] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140558. <rdar://problem/13334992>

7:14 PM Changeset in webkit [145671] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Update test expectation for the bug 111521.

platform/mac/TestExpectations:

6:51 PM Changeset in webkit [145670] by commit-queue@webkit.org

7 edits in trunk/Source

Coordinated Graphics: Remove CoordinatedGraphicsLayer::setRootLayer().
https://bugs.webkit.org/show_bug.cgi?id=111835

Patch by Huang Dongsung <luxtella@company100.net> on 2013-03-12
Reviewed by Luiz Agostini.

Source/WebCore:

This patch removes CoordinatedGraphicsLayer::setRootLayer() because
CoordinatedGraphicsScene already knows which layer is root.

No new tests, no behavior change.

platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp:

(WebCore::CoordinatedGraphicsScene::setLayerState):

platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):

Source/WebKit2:

Amend CoordinatedLayerTreeHost because
CoordinatedGraphicsLayer::setRootLayer() is removed.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

6:47 PM Changeset in webkit [145669] by commit-queue@webkit.org

13 edits in trunk/Source

Enable GPU-GPU texture copy in texImage2D() for HTMLVideoElement if hardware accelerated video decode is in use
https://bugs.webkit.org/show_bug.cgi?id=111126

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

In texImage2D() for HTMLVideoElement in WebGL, it is possible to do a GPU-GPU texture copy instead of CPU readback
and upload when videoFrame is in the form of textures. Each platform port needs to implement the interface
copyVideoTextureToPlatformTexture() defined in MediaPlayer.h to make it work.

Already covered by current tests.

html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::copyVideoTextureToPlatformTexture):

html/HTMLVideoElement.h:

(HTMLVideoElement):

html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::videoFrameToImage): Move some security check to upper level.
(WebCore::WebGLRenderingContext::texImage2D): Add the fast GPU-GPU textures copy path for HTMLVideoElement and some security check.
(WebCore::WebGLRenderingContext::texSubImage2D): Add some security check.

html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::isValid): Added to check if the texture is defined at the given level.

html/canvas/WebGLTexture.h:

(WebGLTexture):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::copyVideoTextureToPlatformTexture): Added to do the GPU-GPU textures copy.

platform/graphics/MediaPlayer.h:

(MediaPlayer):

platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::copyVideoTextureToPlatformTexture):

Source/WebKit/chromium:

public/WebMediaPlayer.h:

(WebKit::WebMediaPlayer::copyVideoTextureToPlatformTexture):

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::copyVideoTextureToPlatformTexture): do a GPU-GPU textures copy if possible.

src/WebMediaPlayerClientImpl.h:

(WebMediaPlayerClientImpl):

6:47 PM Changeset in webkit [145668] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r142539. <rdar://problem/13334864>

6:46 PM Changeset in webkit [145667] by jamesr@google.com

2 edits in trunk/LayoutTests

Update a few chromium test expectations.

platform/chromium/TestExpectations:

6:45 PM Changeset in webkit [145666] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r142365. <rdar://problem/13334965>

6:43 PM Changeset in webkit [145665] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r142358. <rdar://problem/13334971>

6:39 PM Changeset in webkit [145664] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r141858. <rdar://problem/13334961>

6:37 PM Changeset in webkit [145663] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r141851. <rdar://problem/13334974>

6:35 PM Changeset in webkit [145662] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140879. <rdar://problem/13334945>

6:33 PM Changeset in webkit [145661] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r140520. <rdar://problem/13335020>

6:31 PM Changeset in webkit [145660] by Lucas Forschler

3 edits
4 copies in branches/safari-536.30-branch

Merged r140101. <rdar://problem/13334995>

6:28 PM Changeset in webkit [145659] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r140069. <rdar://problem/13334849>

6:26 PM Changeset in webkit [145658] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r139788. <rdar://problem/13334937>

6:25 PM Changeset in webkit [145657] by timothy_horton@apple.com

2 edits in trunk/Source/WTF

Typo in earlier Windows build fix. Unreviewed.

WTF.vcproj/WTF.vcproj:

6:24 PM Changeset in webkit [145656] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r139551. <rdar://problem/13334836>

6:23 PM Changeset in webkit [145655] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r139457. <rdar://problem/13335016>

6:21 PM Changeset in webkit [145654] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r138994. <rdar://problem/13334924>

6:20 PM Changeset in webkit [145653] by timothy_horton@apple.com

3 edits in trunk/Source/JavaScriptCore

WTF uses macros for exports. Try to fix the Windows build. Unreviewed.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

6:19 PM Changeset in webkit [145652] by Lucas Forschler

4 edits
2 copies in branches/safari-536.30-branch

Merged r138926. <rdar://problem/13334936>

6:19 PM Changeset in webkit [145651] by abarth@webkit.org

4 edits in trunk/Source/WebKit/chromium

[Chromium] WebFrame event listener APIs are unused and can be removed
https://bugs.webkit.org/show_bug.cgi?id=112189

Reviewed by Darin Fisher.

As far as I can tell, there are no callers for these APIs. They appear
to have been added for out-of-process postMessages, but those are now
implemented using a different mechanism.

public/WebFrame.h:

(WebFrame):

src/WebFrameImpl.cpp:
src/WebFrameImpl.h:

(WebFrameImpl):

6:17 PM Changeset in webkit [145650] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r138918. <rdar://problem/13334933>

6:14 PM Changeset in webkit [145649] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r145280.
http://trac.webkit.org/changeset/145280
https://bugs.webkit.org/show_bug.cgi?id=112217

This patch broke chromium WebGL conformance tests (Requested
by shawnsingh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

platform/graphics/gpu/DrawingBuffer.cpp:

(WebCore::DrawingBuffer::reset):

platform/graphics/gpu/DrawingBuffer.h:

(DrawingBuffer):

6:12 PM Changeset in webkit [145648] by Lucas Forschler

5 edits in branches/safari-536.30-branch/Source/WebCore

Merged r138863. <rdar://problem/13335068>

6:06 PM Changeset in webkit [145647] by oliver@apple.com

2 edits in trunk/Tools

Unbreak api tests

6:02 PM Changeset in webkit [145646] by scherkus@chromium.org

5 edits in branches/chromium/1410/Source/WebKit/chromium/src

Merge 145319

[chromium] Set the Helper Plugin's URL to that of the host document.
https://bugs.webkit.org/show_bug.cgi?id=111913

This allows content settings, etc. to be based on the document hosting
the element that requested the Helper Plugin.

Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-09
Reviewed by Adam Barth.

src/WebHelperPluginImpl.cpp:
(WebKit::writeDocument):
(WebKit::WebHelperPluginImpl::initialize):
(WebKit::WebHelperPluginImpl::initializePage):

src/WebHelperPluginImpl.h:
(WebKit):
(WebHelperPluginImpl):

src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::createHelperPlugin):

src/WebViewImpl.cpp:
(WebKit::WebViewImpl::createHelperPlugin):

src/WebViewImpl.h:
(WebViewImpl):

TBR=commit-queue@webkit.org
Review URL: https://codereview.chromium.org/12575006

5:56 PM Changeset in webkit [145645] by dino@apple.com

2 edits in trunk/Source/WebCore

Don't send events to plugins that are being snapshotted
https://bugs.webkit.org/show_bug.cgi?id=112215
<rdar://problem/13386224>

Reviewed by Tim Horton.

If a plugin is in the process of being snapshotted, do not forward it
any events. This avoids the case where we can accidentally capture some
custom mouse pointers, as well as trigger a plugin menu.

The next step will be to detect if the event should stop the snapshotting
(restart the plugin).

html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::defaultEventHandler): Return early if the plugin is snapshotting.

5:56 PM Changeset in webkit [145644] by dino@apple.com

3 edits in trunk/Source/WebKit2

Primary plugin hit detection needs to run after plugin creation
https://bugs.webkit.org/show_bug.cgi?id=112206

Reviewed by Tim Horton.

On some pages, the plugins are created after the page has loaded, and
thus our heuristic to determine the primary plugin fails. Run this
heuristic more often: after each PluginView is created. It already exits
early if it has found a primary. But we also need to make sure that it
doesn't run before load.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addPluginView): Run detection when view is added.
(WebKit::WebPage::didFinishLoad): Remember that we have loaded.
(WebKit::WebPage::determinePrimarySnapshottedPlugIn): Look at the PluginViews to see if we have a plugin.
(WebKit::WebPage::resetPrimarySnapshottedPlugIn): Reset both flags.

WebProcess/WebPage/WebPage.h:

(WebPage): New member variable, m_readyToFindPrimarySnapshottedPlugin.

5:53 PM Changeset in webkit [145643] by Lucas Forschler

7 edits
2 copies in branches/safari-536.30-branch

Merged r138850. <rdar://problem/13334979>

5:51 PM Changeset in webkit [145642] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r138812. <rdar://problem/13335055>

5:50 PM Changeset in webkit [145641] by Lucas Forschler

3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r138657. <rdar://problem/13335057>

5:47 PM Changeset in webkit [145640] by Lucas Forschler

5 edits
2 copies in branches/safari-536.30-branch

Merged r138316. <rdar://problem/13335014>

5:45 PM Changeset in webkit [145639] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r137464. <rdar://problem/13334917>

5:43 PM Changeset in webkit [145638] by Lucas Forschler

4 edits
2 copies in branches/safari-536.30-branch

Merged r136560. <rdar://problem/13334987>

5:43 PM Changeset in webkit [145637] by timothy_horton@apple.com

8 edits in trunk/Source

Unreviewed attempted Windows build fix after http://trac.webkit.org/changeset/145592.

WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:

WTF.vcproj/WTF.vcproj:
WTF.vcxproj/WTF.vcxproj:
WTF.vcxproj/WTF.vcxproj.filters:

5:41 PM Changeset in webkit [145636] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r136558. <rdar://problem/13334868>

5:39 PM Changeset in webkit [145635] by Lucas Forschler

4 edits
2 copies in branches/safari-536.30-branch

Merged r136541. <rdar://problem/13334913>

5:36 PM Changeset in webkit [145634] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r136253. <rdar://problem/13334990>

5:29 PM Changeset in webkit [145633] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r136074. <rdar://problem/13334908>

5:27 PM Changeset in webkit [145632] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r136061. <rdar://problem/13335034>

5:25 PM Changeset in webkit [145631] by commit-queue@webkit.org

4 edits in trunk

Fix Gamepad::axes and Gamepad::buttons to avoid calling std::copy(..., ..., 0)
https://bugs.webkit.org/show_bug.cgi?id=89510

Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
Reviewed by Kenneth Russell.

Source/WebCore:

WTF::Vector::begin() returns 0 when the vector has length zero. On windows, the debug implementation of
std::copy() is unhappy with 0 as a third parameter even when the first and second parameters are equal.

Covered by gamepad/gamepad-polling-access.html

Modules/gamepad/Gamepad.cpp:

(WebCore::Gamepad::axes):
(WebCore::Gamepad::buttons):

LayoutTests:

Remove expectation now that test passes.

platform/chromium/TestExpectations:

5:25 PM Changeset in webkit [145630] by Lucas Forschler

5 edits
2 copies in branches/safari-536.30-branch

Merged r136060. <rdar://problem/13334905>

5:18 PM Changeset in webkit [145629] by Lucas Forschler

3 edits
3 copies in branches/safari-536.30-branch

Merged r135794. <rdar://problem/13335026>

5:17 PM Changeset in webkit [145628] by fpizlo@apple.com

4 edits
3 adds in trunk

Array.prototype.sort should at least try to be PTIME even when the array is in some bizarre mode
https://bugs.webkit.org/show_bug.cgi?id=112187
<rdar://problem/13393550>

Source/JavaScriptCore:

Reviewed by Michael Saboff and Gavin Barraclough.

If we have an array-like object in crazy mode passed into Array.prototype.sort, and its length is large,
then first copy all elements into a separate, compact, un-holy array and sort that. Then copy back.
This means that sorting will be at works O(n^{2) in the actual number of things in the array, rather than

O(n}2) in the array's length.

runtime/ArrayPrototype.cpp:

(JSC::attemptFastSort):
(JSC::performSlowSort):
(JSC):
(JSC::arrayProtoFuncSort):

LayoutTests:

Reviewed by Michael Saboff and Gavin Barraclough.

If your Array.prototype.sort is not sufficiently smart, this test will never complete.
But if it is, it'll complete instantly.

fast/js/array-sort-small-sparse-array-with-large-length-expected.txt: Added.
fast/js/array-sort-small-sparse-array-with-large-length.html: Added.
fast/js/jsc-test-list:
fast/js/script-tests/array-sort-small-sparse-array-with-large-length.js: Added.

5:16 PM Changeset in webkit [145627] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r135719. <rdar://problem/13334904>

5:14 PM Changeset in webkit [145626] by Lucas Forschler

7 edits
4 copies in branches/safari-536.30-branch

Merged r135478. <rdar://problem/13334903>

5:09 PM Changeset in webkit [145625] by Beth Dakin

2 edits in trunk/Source/WebKit2

WKView -printOperationWithPrintInfo:forFrame: doesn’t use the print info that is
passed in
https://bugs.webkit.org/show_bug.cgi?id=112212
-and corresponding-
<rdar://problem/12994883>

Reviewed by Anders Carlsson.

We should call [NSPrintOperation printOperationWithView: printInfo:] to use the
printInfo parameter instead of [NSPrintOperation printOperationWithView:] which
will just use the sharedPrintInfo.

UIProcess/API/mac/WKView.mm:

(-[WKView printOperationWithPrintInfo:forFrame:]):

5:06 PM Changeset in webkit [145624] by Lucas Forschler

3 edits
4 copies in branches/safari-536.30-branch

Merged r135454. <rdar://problem/13335031>

5:03 PM Changeset in webkit [145623] by abarth@webkit.org

2 edits in trunk/Source/Platform

[Chromium] Remove last vestigates of WEBKIT_USING_V8
https://bugs.webkit.org/show_bug.cgi?id=112203

Reviewed by James Robinson.

These macros are no longer referenced anywhere and can be removed.

chromium/public/WebCommon.h:

5:03 PM Changeset in webkit [145622] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r135303. <rdar://problem/13334898>

5:02 PM Changeset in webkit [145621] by jamesr@google.com

137 edits
2 copies
1 move
19 adds
19 deletes in trunk/LayoutTests

Update chromium pixel baselines for mesa blend fix in chromium r187688

platform/chromium-linux/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-linux/compositing/culling/filter-occlusion-blur-expected.png: Removed.
platform/chromium-linux/compositing/culling/filter-occlusion-blur-large-expected.png: Removed.
platform/chromium-linux/compositing/direct-image-compositing-expected.png:
platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-linux/compositing/geometry/layer-due-to-layer-children-expected.png:
platform/chromium-linux/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium-linux/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-linux/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-linux/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-linux/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-linux/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-linux/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-linux/compositing/reflections/transform-inside-reflection-expected.png:
platform/chromium-linux/compositing/self-painting-layers-expected.png:
platform/chromium-linux/compositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-linux/compositing/visibility/visibility-image-layers-expected.png: Removed.
platform/chromium-linux/compositing/visibility/visibility-simple-video-layer-expected.png: Removed.
platform/chromium-linux/css3/filters/custom/custom-filter-shader-cache-expected.png:
platform/chromium-linux/css3/filters/custom/effect-color-check-expected.png: Added.
platform/chromium-linux/css3/filters/custom/effect-custom-combined-missing-expected.png:
platform/chromium-linux/css3/filters/custom/effect-custom-expected.png:
platform/chromium-linux/css3/filters/custom/effect-custom-parameters-expected.png:
platform/chromium-linux/css3/filters/effect-blur-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-brightness-clamping-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-brightness-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-combined-hw-expected.png:
platform/chromium-linux/css3/filters/effect-contrast-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-drop-shadow-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-reference-ordering-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: Removed.
platform/chromium-linux/css3/filters/filter-change-repaint-composited-expected.png: Removed.
platform/chromium-linux/css3/filters/filter-change-repaint-expected.png: Removed.
platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
platform/chromium-linux/css3/filters/filter-repaint-composited-fallback-expected.png:
platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
platform/chromium-linux/platform/chromium/compositing/3d-corners-expected.png:
platform/chromium-linux/platform/chromium/compositing/huge-layer-rotated-expected.png:
platform/chromium-linux/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png:
platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-expected.png:
platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
platform/chromium-linux/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
platform/chromium-mac-lion/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-mac-lion/compositing/direct-image-compositing-expected.png:
platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac-lion/compositing/geometry/layer-due-to-layer-children-expected.png:
platform/chromium-mac-lion/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac-lion/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-mac-lion/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-mac-lion/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-mac-lion/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-lion/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-mac-lion/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-mac-lion/compositing/reflections/transform-inside-reflection-expected.png:
platform/chromium-mac-lion/compositing/self-painting-layers-expected.png:
platform/chromium-mac-lion/compositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-mac-lion/platform/chromium/compositing/video-frame-size-change-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-mac-lion/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Copied from LayoutTests/platform/chromium-mac-lion/compositing/overflow/scroll-ancestor-update-expected.png.
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/canvas-text-baseline-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac-lion/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-expected.png:
platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
platform/chromium-mac-lion/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
platform/chromium-mac-snowleopard/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-mac-snowleopard/compositing/direct-image-compositing-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/layer-due-to-layer-children-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-mac-snowleopard/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-mac-snowleopard/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-mac-snowleopard/compositing/reflections/transform-inside-reflection-expected.png:
platform/chromium-mac-snowleopard/compositing/self-painting-layers-expected.png:
platform/chromium-mac-snowleopard/compositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/overflow/overflow-compositing-descendant-expected.png.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-expected.png:
platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
platform/chromium-mac-snowleopard/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
platform/chromium-mac/compositing/color-matching/image-color-matching-expected.png:
platform/chromium-mac/compositing/culling/filter-occlusion-blur-expected.png:
platform/chromium-mac/compositing/culling/filter-occlusion-blur-large-expected.png:
platform/chromium-mac/compositing/direct-image-compositing-expected.png:
platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
platform/chromium-mac/compositing/geometry/layer-due-to-layer-children-expected.png:
platform/chromium-mac/compositing/geometry/vertical-scroll-composited-expected.png:
platform/chromium-mac/compositing/geometry/video-fixed-scrolling-expected.png:
platform/chromium-mac/compositing/geometry/video-opacity-overlay-expected.png:
platform/chromium-mac/compositing/layers-inside-overflow-scroll-expected.png:
platform/chromium-mac/compositing/overflow/overflow-compositing-descendant-expected.png:
platform/chromium-mac/compositing/overflow/scroll-ancestor-update-expected.png:
platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
platform/chromium-mac/compositing/reflections/load-video-in-reflection-expected.png:
platform/chromium-mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
platform/chromium-mac/compositing/reflections/transform-inside-reflection-expected.png:
platform/chromium-mac/compositing/self-painting-layers-expected.png:
platform/chromium-mac/compositing/transitions/scale-transition-no-start-expected.png:
platform/chromium-mac/compositing/visibility/visibility-image-layers-expected.png:
platform/chromium-mac/compositing/visibility/visibility-simple-video-layer-expected.png:
platform/chromium-mac/css3/filters/custom/custom-filter-shader-cache-expected.png:
platform/chromium-mac/css3/filters/custom/effect-color-check-expected.png:
platform/chromium-mac/css3/filters/custom/effect-custom-combined-missing-expected.png:
platform/chromium-mac/css3/filters/custom/effect-custom-parameters-expected.png:
platform/chromium-mac/css3/filters/effect-blur-hw-expected.png:
platform/chromium-mac/css3/filters/effect-brightness-clamping-hw-expected.png:
platform/chromium-mac/css3/filters/effect-brightness-hw-expected.png:
platform/chromium-mac/css3/filters/effect-combined-hw-expected.png:
platform/chromium-mac/css3/filters/effect-contrast-hw-expected.png:
platform/chromium-mac/css3/filters/effect-drop-shadow-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
platform/chromium-mac/css3/filters/effect-reference-ordering-hw-expected.png:
platform/chromium-mac/css3/filters/filter-change-repaint-composited-expected.png: Added.
platform/chromium-mac/css3/filters/filter-change-repaint-expected.png: Added.
platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-crash-expected.png:
platform/chromium-mac/css3/filters/filter-repaint-composited-fallback-expected.png:
platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
platform/chromium-mac/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
platform/chromium-mac/platform/chromium/compositing/3d-corners-expected.png:
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-expected.png: Added.
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png:
platform/chromium-mac/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png:
platform/chromium-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
platform/chromium-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png:
platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-compositing-descendant-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scroll-ancestor-update-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png:
platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-expected.png:
platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
platform/chromium-mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
platform/chromium/TestExpectations:
platform/chromium/fast/canvas/webgl/css-webkit-canvas-expected.png: Removed.
platform/chromium/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Removed.
platform/efl-wk2/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.

5:00 PM Changeset in webkit [145620] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r135299. <rdar://problem/13335033>

4:58 PM Changeset in webkit [145619] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r135193. <rdar://problem/13335071>

4:56 PM Changeset in webkit [145618] by Lucas Forschler

4 edits
2 copies in branches/safari-536.30-branch

Merged r133717. <rdar://problem/13334891>

4:52 PM Changeset in webkit [145617] by Lucas Forschler

4 edits
12 copies in branches/safari-536.30-branch

Merged r133686. <rdar://problem/13334976>

4:50 PM Changeset in webkit [145616] by Lucas Forschler

3 edits
3 copies in branches/safari-536.30-branch

Merged r133155. <rdar://problem/13335008>

4:49 PM Changeset in webkit [145615] by timothy_horton@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Not reviewed.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:

4:45 PM Changeset in webkit [145614] by Lucas Forschler

5 edits
2 copies in branches/safari-536.30-branch

Merged r132983. <rdar://problem/13334897>

4:43 PM Changeset in webkit [145613] by esprehn@chromium.org

2 edits in trunk/Source/WebCore

Remove TextIterator.cpp's isAllCollapsibleWhitespace
https://bugs.webkit.org/show_bug.cgi?id=112200

Reviewed by Ryosuke Niwa.

Remove isAllCollapsibleWhitespace since nothing uses it.

editing/TextIterator.cpp: Remove isAllCollapsibleWhitespace.

4:43 PM Changeset in webkit [145612] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r132462. <rdar://problem/13335022>

4:40 PM Changeset in webkit [145611] by Lucas Forschler

5 edits in branches/safari-536.30-branch/Source/WebCore

Merged r132398. <rdar://problem/13334911>

4:27 PM Changeset in webkit [145610] by betravis@adobe.com

6 edits in trunk/Source/WebCore

[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

rendering/ExclusionShapeInsideInfo.cpp:

(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.

rendering/ExclusionShapeInsideInfo.h:

(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.

rendering/RenderBlock.h:

(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member. Move the struct
declaration to be public, so that the OwnPtr reference can properly delete it.

rendering/RenderBlockLineLayout.cpp:

(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

4:25 PM Changeset in webkit [145609] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r131578. <rdar://problem/13334886>

4:19 PM Changeset in webkit [145608] by Lucas Forschler

1 copy
1 add in branches/safari-536.30-branch/Source/WebCore

4:15 PM Changeset in webkit [145607] by timothy_horton@apple.com

2 edits in trunk/Tools

Unreviewed, disabling tests for Win EWS.

win-ews obviously cannot keep up with running tests, it's >300 behind.
Probably doesn't help that its (likely) running tests serially.

Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

4:14 PM Changeset in webkit [145606] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

Not reviewed.

JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

Export a thing.

4:10 PM Changeset in webkit [145605] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r131315. <rdar://problem/13334884>

4:04 PM Changeset in webkit [145604] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r131110. <rdar://problem/13334883>

3:49 PM Changeset in webkit [145603] by jamesr@google.com

4 edits in trunk/Source

Build fix for r145592 - update gyp files to refer to new file locations.

Source/WebCore:

WebCore.gypi:

Source/WTF:

WTF.gypi:

3:49 PM Changeset in webkit [145602] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r129583. <rdar://problem/13335073>

3:39 PM Changeset in webkit [145601] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Add a single character cache to WidthCache
https://bugs.webkit.org/show_bug.cgi?id=112084

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-03-12
Reviewed by Geoffrey Garen.

More than half of the values stored in WidthCache are values
for a single character.

Previously, we were creating a new SmallStringKey for each one of
them, causing a lot of extra memory operations even for the simple
cases.

This patch adds a second map, m_singleCharMap, to simplify the
computation for the common case of a single char TextRun.

platform/graphics/WidthCache.h:

(WebCore::WidthCache::clear):
(WidthCache):
(WebCore::WidthCache::addSlowCase):

3:38 PM Changeset in webkit [145600] by timothy_horton@apple.com

2 edits in trunk/Tools

Add a --build-directory argument to delete-stale-build-files
https://bugs.webkit.org/show_bug.cgi?id=112198

Reviewed by Ryosuke Niwa.

BuildSlaveSupport/delete-stale-build-files:

(main): Add --build-directory argument.

3:35 PM Changeset in webkit [145599] by Lucas Forschler

6 edits in branches/safari-536.30-branch/Source/WebCore

Merged r129186. <rdar://problem/13334978>

3:26 PM Changeset in webkit [145598] by pdr@google.com

12 edits in trunk/Source/WebCore

Replace static_casts for SVG transformable and locatable elements
https://bugs.webkit.org/show_bug.cgi?id=111651

Reviewed by Abhishek Arya.

toSVGStyledTransformableElement and toSVGStyledLocatableElement are preferred over
static_casts because bad casts can be caught on our testing infrastructure. This patch
replaces all static_casts for SVGStyledTransformableElement and SVGStyledLocatableElement
with toSVGStyledTransformableElement and toSVGStyledLocatableElement, respectively.

No new tests as this is covered with existing tests.

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::updateShapeFromElement):
(WebCore::RenderSVGShape::layout):
(WebCore::RenderSVGShape::nonScalingStrokeTransform):
(WebCore::RenderSVGShape::shouldGenerateMarkerPositions):

rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

svg/SVGAnimatedLength.cpp:

(WebCore::SVGAnimatedLengthAnimator::calculateDistance):

This was an unnecessary cast and has been removed.

svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):

svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

svg/SVGStyledLocatableElement.h:

(WebCore):
(WebCore::toSVGStyledLocatableElement):

svg/SVGStyledTransformableElement.h:

(WebCore):
(WebCore::toSVGStyledTransformableElement):

It makes the code cleaner to pass Node* in here, rather than converting the Node*
to an SVGElement* before calling this function. The same was not necessary for
SVGStyledLocatable.

svg/SVGSVGElement.h:

(WebCore):
(WebCore::toSVGSVGElement):

This code has been cleaned up. During the review of this patch, a similar cleanup
was done in toSVGStyledTransformableElement.

svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):

3:21 PM Changeset in webkit [145597] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r187660. Requested by
"Adam Barth" <abarth@webkit.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

DEPS:

3:21 PM Changeset in webkit [145596] by inferno@chromium.org

18 edits in trunk/Source

Replace static_casts with to* helper functions.
https://bugs.webkit.org/show_bug.cgi?id=112164

Reviewed by Philip Rogers.

to* helper functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):

platform/gtk/PasteboardGtk.cpp:

(WebCore::getURLForImageNode):
(WebCore::Pasteboard::writeImage):

platform/gtk/RenderThemeGtk.cpp:

(WebCore::getMediaElementFromRenderObject):

platform/qt/RenderThemeQtMobile.cpp:

(WebCore::RenderThemeQtMobile::checkMultiple):

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::title):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):
(WebCore::RenderLayer::hitTest):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::valueChanged):

rendering/RenderObject.cpp:

(WebCore::RenderObject::addPDFURLRect):

rendering/RenderPart.cpp:

(WebCore::RenderPart::requiresAcceleratedCompositing):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::checkRegionStyle):

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isEnabled):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
(WebCore::RenderTheme::isHovered):
(WebCore::RenderTheme::isSpinUpButtonPartHovered):
(WebCore::RenderTheme::paintSliderTicks):

rendering/RenderThemeWinCE.cpp:

(WebCore::mediaElementParent):

rendering/RenderTreeAsText.cpp:

(WebCore::isEmptyOrUnstyledAppleStyleSpan):
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):

rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

Source/WebKit/win:

DOMHTMLClasses.cpp:

(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):

3:17 PM Changeset in webkit [145595] by oliver@apple.com

2 edits in trunk/Tools

Appease MSVC

3:15 PM Changeset in webkit [145594] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

Harden JSStringJoiner
https://bugs.webkit.org/show_bug.cgi?id=112093

Reviewed by Filip Pizlo.

Harden JSStringJoiner, make it use our CheckedArithmetic
class to simplify everything.

runtime/JSStringJoiner.cpp:

(JSC::JSStringJoiner::build):

runtime/JSStringJoiner.h:

(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

3:04 PM Changeset in webkit [145593] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Add one more test expectation per bug 112176.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

3:04 PM Changeset in webkit [145592] by ggaren@apple.com

25 edits
1 copy
6 moves in trunk/Source

Moved RunLoopTimer and SchedulePair to WTF
https://bugs.webkit.org/show_bug.cgi?id=112171

Reviewed by Oliver Hunt.

This will allow us to use timers in lower level primitives without
duplicating all the code.

../WebCore:

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
loader/DocumentLoader.h:

(WTF):
(WebCore):
(DocumentLoader):

loader/MainResourceLoader.h:
page/Page.h:
platform/AutodrainedPool.h: Removed.
platform/cf/RunLoopTimerCF.cpp: Removed.
platform/cf/SchedulePair.cpp: Removed.
platform/cf/SchedulePair.h: Removed.
platform/mac/AutodrainedPool.mm: Removed.
platform/mac/SchedulePairMac.mm: Removed.
platform/network/NetworkingContext.h:
platform/network/ResourceHandle.h:

(WTF):
(WebCore):
(ResourceHandle):

platform/network/cf/FormDataStreamCFNet.cpp:
platform/network/mac/ResourceHandleMac.mm:

../WebKit/mac:

WebCoreSupport/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

../WebKit2:

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

../WTF:

WTF.xcodeproj/project.pbxproj:
wtf/AutodrainedPool.h: Copied from Source/WebCore/platform/AutodrainedPool.h.

(AutodrainedPool):

wtf/AutodrainedPoolMac.mm: Copied from Source/WebCore/platform/mac/AutodrainedPool.mm.
wtf/RunLoopTimer.h: Copied from Source/WebCore/platform/RunLoopTimer.h.
wtf/RunLoopTimerCF.cpp: Copied from Source/WebCore/platform/cf/RunLoopTimerCF.cpp.
wtf/SchedulePair.cpp: Copied from Source/WebCore/platform/cf/SchedulePair.cpp.
wtf/SchedulePair.h: Copied from Source/WebCore/platform/cf/SchedulePair.h.

(SchedulePair):

wtf/SchedulePairMac.mm: Copied from Source/WebCore/platform/mac/SchedulePairMac.mm.

2:58 PM Changeset in webkit [145591] by abarth@webkit.org

1 edit
2 deletes in trunk/LayoutTests

Remove stray .gitmodules file
https://bugs.webkit.org/show_bug.cgi?id=112186

Reviewed by Tony Chang.

Apparently I imported this together with the jquery tests by mistake.

jquery/resources/src/sizzle/.gitmodules: Removed.

2:55 PM Changeset in webkit [145590] by Lucas Forschler

4 edits in branches/safari-536.30-branch/Source/WebCore

Rollout 145585, not needed.

2:54 PM Changeset in webkit [145589] by abarth@webkit.org

16 edits in trunk/Source/WebKit/chromium

[Chromium] Remove WEBKIT_USING_V8 from the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112120

Reviewed by Tony Chang.

Chromium always uses V8. This macro has outlived it's usefulness. It's
now just noise.

README:
public/WebArrayBuffer.h:

(WebArrayBuffer):

public/WebArrayBufferView.h:

(WebArrayBufferView):

public/WebBindings.h:

(WebBindings):

public/WebBlob.h:

(WebBlob):

public/WebFrame.h:

(WebFrame):

public/WebFrameClient.h:
public/WebSerializedScriptValue.h:

(WebSerializedScriptValue):

src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

src/WebBlob.cpp:

(WebKit::WebBlob::toV8Value):

src/WebFrameImpl.cpp:

(WebKit::WebFrame::frameForContext):

src/WebFrameImpl.h:

(WebFrameImpl):

src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):
(WebKit::WebSerializedScriptValue::deserialize):

2:53 PM Changeset in webkit [145588] by commit-queue@webkit.org

13 edits in trunk

Mac: Incorrect rendering of <audio> controls
https://bugs.webkit.org/show_bug.cgi?id=110913

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-03-12
Reviewed by Tony Chang.

Source/WebCore:

Covered by existing tests under media/.

css/mediaControls.css:

(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
The timeline container and the timeline need min-width: 0 so that they can shrink if needed.

css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
The timeline container also needs flex-start to ensure that it never overlaps
the play/rewind buttons. The current-time and remaining-time displays need min-width: 0 so that the hack
in RenderMediaControls.cpp works correctly - otherwise, RenderFlexibleBox tries to use the preferred width
of the time displays, which is wrong when they try to hide themselves.

LayoutTests:

platform/mac/media/audio-controls-rendering-expected.txt:
platform/mac/media/controls-after-reload-expected.txt:
platform/mac/media/controls-strict-expected.txt:
platform/mac/media/controls-styling-strict-expected.txt:
platform/mac/media/controls-without-preload-expected.txt:
platform/mac/media/video-controls-rendering-expected.txt:
platform/mac/media/video-display-toggle-expected.txt:
platform/mac/media/video-no-audio-expected.txt:
platform/mac/media/video-playing-and-pause-expected.txt:

2:51 PM Changeset in webkit [145587] by oliver@apple.com

4 edits in trunk

Add more Checked<> tests
https://bugs.webkit.org/show_bug.cgi?id=112190

Reviewed by Geoffrey Garen.

Source/WTF:

Export the CheckedState enum type

wtf/CheckedArithmetic.h:

Tools:

Tests!

TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI):

2:47 PM Changeset in webkit [145586] by jparent@chromium.org

4 edits in trunk/Tools

Cleanup: Move loading complete function into callback, rather than global.
https://bugs.webkit.org/show_bug.cgi?id=112167

Reviewed by Dirk Pranke.

Stop calling global functions, pass in proper handler to Loader
constructor. Note that the callback is optional, as tests, and
some potential dashboards, do not need one.

TestResultServer/static-dashboards/dashboard_base.js:
TestResultServer/static-dashboards/loader.js:

(.):

TestResultServer/static-dashboards/loader_unittests.js:

2:39 PM Changeset in webkit [145585] by Lucas Forschler

4 edits in branches/safari-536.30-branch/Source/WebCore

Merged r129144. <rdar://problem/13334978>

2:29 PM Changeset in webkit [145584] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r128524. <rdar://problem/13334872>

2:19 PM Changeset in webkit [145583] by Lucas Forschler

3 edits
2 copies in branches/safari-536.30-branch

Merged r126063. <rdar://problem/13334852>

2:11 PM Changeset in webkit [145582] by Lucas Forschler

2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r124229. <rdar://problem/13334842>

2:10 PM Changeset in webkit [145581] by ap@apple.com

3 edits in trunk/Source/WebCore

Improve logging in ResourceHandleMac.mm
https://bugs.webkit.org/show_bug.cgi?id=112185

Reviewed by Brady Eidson.

platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Removed an obsolete #if. (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Added a FIXME. (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]):

platform/network/mac/ResourceResponseMac.mm: Removed an unneeded include.

2:05 PM Changeset in webkit [145580] by oliver@apple.com

2 edits in trunk/Source/WTF

Make CheckedArithmetic slightly more sane
https://bugs.webkit.org/show_bug.cgi?id=112178

Reviewed by Geoffrey Garen.

Add an enum type for safeGet rather than using a bool,
and correctly handle unsigned * unsigned, when one value
is 0.

wtf/CheckedArithmetic.h:

(WTF::ENUM_CLASS):
(WTF):
(WTF::operator+):
(WTF::operator-):
(WTF::operator*):

2:04 PM Changeset in webkit [145579] by Lucas Forschler

7 edits
2 deletes in branches/safari-536.30-branch

Merged r123145. <rdar://problem/13266379>

1:38 PM Changeset in webkit [145578] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG generic array access cases should not be guarded by CheckStructure even of the profiling tells us that it could be
https://bugs.webkit.org/show_bug.cgi?id=112183

Reviewed by Oliver Hunt.

Slight speed-up on string-unpack-code.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::findAndRemoveUnnecessaryStructureCheck):
(FixupPhase):
(JSC::DFG::FixupPhase::checkArray):
(JSC::DFG::FixupPhase::blessArrayOperation):

1:27 PM Changeset in webkit [145577] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Some canvas tests only fail on Mac EWS
https://bugs.webkit.org/show_bug.cgi?id=112176

Reviewed by Simon Fraser.

Add Failure / Pass test expectations on tests that only fail on Mac EWS bots.

Ideally, we can figure out the root cause of this failure and fix that problem but we haven't been able
to do so. We also don't have a way of adding test expectations only on EWS bots we're out of luck here.

platform/mac/TestExpectations:

1:20 PM Changeset in webkit [145576] by jchaffraix@webkit.org

3 edits
8 copies in branches/chromium/1410

Merge 145305 "REGRESSION(r140907): Incorrect baseline for cells ..."

REGRESSION(r140907): Incorrect baseline for cells with media content during load
https://bugs.webkit.org/show_bug.cgi?id=108357

Reviewed by Julien Chaffraix.

Source/WebCore:

If a cell has replaced content, the intrinsic height of its content can change between layouts. If that's the case then the intrinsic padding we used
for layout (the padding required to push the contents of the cell down to the row's baseline) is included in the new height and baseline and makes both
of them wrong. So if a cell's content's intrinsic height has changed push the new content up into the intrinsic padding and relayout so that the rest of
table and row layout can use the correct baseline and height for this cell.

Tests: fast/css/vertical-align-baseline-rowspan-012.html

http/tests/css/vertical-align-baseline-after-image-load-2.html
http/tests/css/vertical-align-baseline-after-image-load-3.html
http/tests/css/vertical-align-baseline-after-image-load.html

rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout):

rendering/RenderTableCell.h:
(WebCore::RenderTableCell::isBaselineAligned):

rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):

LayoutTests:

fast/css/vertical-align-baseline-rowspan-012-expected.html: Added.
fast/css/vertical-align-baseline-rowspan-012.html: Added.
http/tests/css/vertical-align-baseline-after-image-load-2-expected.html: Added.
http/tests/css/vertical-align-baseline-after-image-load-2.html: Added.
http/tests/css/vertical-align-baseline-after-image-load-3-expected.html: Added.
http/tests/css/vertical-align-baseline-after-image-load-3.html: Added.
http/tests/css/vertical-align-baseline-after-image-load-expected.html: Added.
http/tests/css/vertical-align-baseline-after-image-load.html: Added.

TBR=robert@webkit.org

1:11 PM Changeset in webkit [145575] by commit-queue@webkit.org

37 edits in trunk/Source/WebCore

Unreviewed, rolling out r145554.
http://trac.webkit.org/changeset/145554
https://bugs.webkit.org/show_bug.cgi?id=112182

Breaks several extension browser tests (see bug for details)
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):
(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::GetTemplate):
(WebCore::V8TestActiveDOMObject::HasInstance):

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8GCController.cpp:
bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(WebCore::V8PerIsolateData::templateMap):
(V8PerIsolateData):

bindings/v8/WrapperTypeInfo.h:
bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

12:43 PM Changeset in webkit [145574] by gavinp@chromium.org

2 edits in trunk/Source/WebCore

[chromium] Use lipo(1) rather than file(1) to list library architectures.
https://bugs.webkit.org/show_bug.cgi?id=111147

Parsing file(1) output can be fragile; this patch replaces a use of file(1) to get
the architecture list of a library with an invocation of lipo(1), which should be more
stable.

Reviewed by Nico Weber.

No new tests, since adjust_visibility.sh doesn't have a test.

WebCore.gyp/mac/adjust_visibility.sh:

12:07 PM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

11:45 AM Changeset in webkit [145573] by kerz@chromium.org

6 edits in branches/chromium/1438/Source/WebCore

Rolling out 145277

11:41 AM Changeset in webkit [145572] by kerz@chromium.org

1 copy in branches/chromium/1438

Quick branch for Chromium

11:38 AM Changeset in webkit [145571] by mifenton@rim.com

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Prevent text selection inside Colour and Date/Time input fields
https://bugs.webkit.org/show_bug.cgi?id=111733

Reviewed by Rob Buis.

PR 305194.

Skip rendering of selection if it is in a popup driven
input field. This covers situations where EditorClientBlackBerry::shouldChangeSelectedRange
is either not called or focus is not complete when called.

Informally reviewed by Gen Mak.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
(WebKit):

11:28 AM Changeset in webkit [145570] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Mac rebaseline.

Rubber-stamped by Simon Fraser.

platform/mac/compositing/overflow/composited-scrolling-paint-phases-expected.txt:

11:27 AM Changeset in webkit [145569] by commit-queue@webkit.org

3 edits
4 adds in trunk

Webkit unable to show gifs with applcation extension string shorter than 11 bytes
https://bugs.webkit.org/show_bug.cgi?id=110620

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-03-12
Reviewed by Laszlo Gombos.

Source/WebCore:

Use actual block size for gifs application extension string even if it is below 11 bytes
to be able to decode this kind of gifs.

Test: fast/images/gif-short-app-extension-string.html

platform/image-decoders/gif/GIFImageReader.cpp:

(GIFImageReader::decodeInternal):

LayoutTests:

Test that webkit is able to decode gifs with short application extension string.

fast/images/gif-short-app-extension-string-expected.png: Added.
fast/images/gif-short-app-extension-string-expected.txt: Added.
fast/images/gif-short-app-extension-string.html: Added.
fast/images/resources/short-app-extension-string.gif: Added.

11:26 AM Changeset in webkit [145568] by commit-queue@webkit.org

3 edits
1 delete in trunk/Source/Platform

[chromium] Remove unused WebIOSurfaceLayer type
https://bugs.webkit.org/show_bug.cgi?id=111796

Patch by James Robinson <jamesr@chromium.org> on 2013-03-12
Reviewed by Adrienne Walker.

This has been dead code since http://trac.webkit.org/changeset/138223

Platform.gypi:
chromium/public/WebCompositorSupport.h:

(WebKit):

chromium/public/WebIOSurfaceLayer.h: Removed.

11:20 AM Changeset in webkit [145567] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Unreviewed, rolling out r145277.
http://trac.webkit.org/changeset/145277
https://bugs.webkit.org/show_bug.cgi?id=112170

chromium-gpu and android testers are seeing failures/crashes
relating to this code (Requested by eseidel on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

html/parser/BackgroundHTMLInputStream.cpp:

(WebCore::BackgroundHTMLInputStream::rewindTo):

html/parser/BackgroundHTMLInputStream.h:

(BackgroundHTMLInputStream):
(Checkpoint):

html/parser/BackgroundHTMLParser.cpp:
html/parser/BackgroundHTMLParser.h:

(BackgroundHTMLParser):

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpPendingSpeculations):

11:18 AM Changeset in webkit [145566] by rafaelw@chromium.org

2 edits in branches/chromium/1410

Merge 145293 "[HTMLTemplateElement] processTemplateEndTag() need..."

[HTMLTemplateElement] processTemplateEndTag() needs to check for template in html scope
https://bugs.webkit.org/show_bug.cgi?id=111880

Reviewed by Eric Seidel.

Source/WebCore:

Currently, </template> handling exits with an error if there is not a template tag "in scope"
which will be true if there is a table (for instance) below a template. This makes it so that
the search (correctly) examines the entire element stack.

Tests added to html5lib testing library.

html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processTemplateEndTag):

LayoutTests:

html5lib/resources/template.dat:

TBR=rafaelw@chromium.org
Review URL: https://codereview.chromium.org/12623014

11:13 AM Changeset in webkit [145565] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Clean up WebPageURITest

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-12
Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/tests/TestLoaderClient.cpp:
UIProcess/API/gtk/tests/WebKitTestBus.cpp:

(WebKitTestBus::getOrCreateConnection):
(WebKitTestBus::createProxy):

UIProcess/API/gtk/tests/WebKitTestBus.h:

(WebKitTestBus::connection):
(WebKitTestBus):

11:02 AM Changeset in webkit [145564] by Christophe Dumez

2 edits in trunk/Tools

[EFL][WK2] Add popup menu support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108934

Reviewed by Kenneth Rohde Christiansen.

Implement popup menu support in MiniBrowser by handling popup_menu_show
and popup_menu_hide smart functions on the view and using the Ewk popup
menu API.

MiniBrowser/efl/main.c:

(_Browser_Window):
(on_popup_menu_discarded):
(on_popup_menu_item_clicked):
(popup_menu_populate):
(on_popup_menu_show):
(on_popup_menu_hide):
(window_create): Use calloc() instead of malloc() to allocate memory for
Browser_Window. This makes sure all the structs members are initialized
to 0 (such as the new elm_popup_menu pointer).

10:54 AM Changeset in webkit [145563] by Simon Fraser

9 edits in trunk/Source/WebCore

Keep track of the number of GraphicsLayers with tiled backing in RenderLayerCompositor
https://bugs.webkit.org/show_bug.cgi?id=112083

Reviewed by Dean Jackson.

Have RenderLayerCompositor keep track of how many of its GraphicsLayers use TiledBacking.
This is useful for platforms to decide whether it's necessary to force GraphicsLayer flushes
to update the visibleRect of those TiledBackings.

GraphicsLayers are always created without TiledBacking. There are two
ways the count can change:

A GraphicsLayerCA toggles into or out of tiled mode. It notifies its client via a new tiledBackingUsageChanged() callback on GraphicsLayerClient.
A tiled GraphicsLayerCA is destroyed. Added a new bottleneck function to RenderLayerBacking::willDestroyLayer() that is called everywhere we destroy layers.

The main page TiledBacking is not counted as part of this.

Also renamed uses of "tiledLayer" to "tiledBacking" in GraphicsLayer[CA].

platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::getDebugBorderInfo):
(WebCore::GraphicsLayer::dumpProperties):

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::usingTiledBacking):

platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::tiledBackingUsageChanged):

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::willDestroyLayer):
(WebCore::RenderLayerBacking::tiledBackingUsageChanged):
(WebCore::RenderLayerBacking::destroyGraphicsLayers):
(WebCore::RenderLayerBacking::updateClippingLayers):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateBackgroundLayer):
(WebCore::RenderLayerBacking::updateMaskLayer):
(WebCore::RenderLayerBacking::updateScrollingLayers):
(WebCore::RenderLayerBacking::compositingLayerType):

rendering/RenderLayerBacking.h:
rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::layerTiledBackingUsageChanged):

rendering/RenderLayerCompositor.h:

(WebCore::RenderLayerCompositor::haveNonMainLayersWithTiledBacking):

10:44 AM Changeset in webkit [145562] by inferno@chromium.org

29 edits in trunk/Source

Replace static_casts with to* functions.
https://bugs.webkit.org/show_bug.cgi?id=112072

Reviewed by Philip Rogers.

to* functions are preferred over static_cast calls since they
help to catch bad casts easily on the testing infrastructure.

Source/WebCore:

accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::canSetFocusAttribute):

bindings/objc/DOM.mm:

(kitClass):

bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):

editing/FormatBlockCommand.cpp:

(WebCore::isElementForFormatBlock):

editing/ReplaceSelectionCommand.cpp:

(WebCore::isMailPasteAsQuotationNode):
(WebCore::haveSameTagName):
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):

history/CachedPage.cpp:

(WebCore::CachedPage::restore):

html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestions):

html/HTMLTableRowsCollection.cpp:

(WebCore::isInHead):
(WebCore::isInBody):
(WebCore::isInFoot):

inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::innerPatchNode):

page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):

plugins/PluginView.cpp:

(WebCore::PluginView::getValue):

rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::name):

rendering/RenderMedia.cpp:

(WebCore::RenderMedia::mediaElement):

rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::autosaveName):

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):
(WebCore::updateUserModifyProperty):

rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::endElementNs):

Source/WebKit/chromium:

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::focusedNodeChanged):

src/ContextMenuClientImpl.cpp:

(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

src/DOMUtilitiesPrivate.cpp:

(WebCore::toHTMLElement):

src/WebSearchableFormData.cpp:

(HTMLNames::IsSelectInDefaultState):

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _enterFullscreenForNode:WebCore::]):

10:42 AM Changeset in webkit [145561] by zandobersek@gmail.com

4 edits in trunk/Source

[GTK] Remove HILDON_CPPFLAGS and HILDON_CFLAGS references from GNUmakefiles
https://bugs.webkit.org/show_bug.cgi?id=112163

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - no new functionality, merely a cleanup.

GNUmakefile.am: The Hildon dependency doesn't exist anymore so there's no need for

references to HILDON_CPPFLAGS and HILDON_CFLAGS.

Source/WebKit2:

GNUmakefile.am: The Hildon dependency doesn't exist anymore so there's no need for

references to HILDON_CPPFLAGS and HILDON_CFLAGS.

10:40 AM Changeset in webkit [145560] by zandobersek@gmail.com

2 edits in trunk

[GTK] 'unrecognized command line option "-Wno-c++11-extensions"' warning reported when using gcc
https://bugs.webkit.org/show_bug.cgi?id=111936

Reviewed by Martin Robinson.

Source/autotools/SetupCompilerFlags.m4: Only use the -Wno-c++11-extensions warning when building

with Clang as GCC does not support the warning just yet. Also enhance the comment about using libstdc++
as the standard C++ library when compiling with Clang.

10:38 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

10:37 AM Changeset in webkit [145559] by Lucas Forschler

4 edits in branches/safari-536.30-branch/Source

Versioning.

10:34 AM Changeset in webkit [145558] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145376 - [SOUP] ResourceRequest::updateSoupMessage doesn't update the URI of the soup message
https://bugs.webkit.org/show_bug.cgi?id=112040

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-03-11
Reviewed by Gustavo Noronha Silva.

platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateSoupMessage): Update the soup
message URI with the ResourceRequest URL.

10:26 AM Changeset in webkit [145557] by pfeldman@chromium.org

2 edits in trunk/Source/WebCore

Not reviewed: removing GtkVersioning from chromium targets.

WebCore.gypi:

10:04 AM Changeset in webkit [145556] by Lucas Forschler

1 copy in branches/safari-536.30-branch

New Branch.

10:00 AM Changeset in webkit [145555] by zandobersek@gmail.com

3 edits
3 adds in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for two crashers and a flaky test.
platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145526.
platform/gtk/http/tests/security/xssAuditor: Added. Adding baselines for tests introduced in r145503.
platform/gtk/http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt: Added.
platform/gtk/http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt: Added.

9:44 AM Changeset in webkit [145554] by commit-queue@webkit.org

37 edits in trunk/Source/WebCore

[V8] Store main world and non-main world templates separately.
https://bugs.webkit.org/show_bug.cgi?id=111724

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Jochen Eisinger.

This is needed for generating specialized bindings for the main
world (bug 110874).

No new tests (updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/V8AdaptorFunction.cpp:

(WebCore::V8AdaptorFunction::getTemplate):

bindings/v8/V8GCController.cpp:
bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore::V8PerIsolateData::rawTemplate):
(WebCore::V8PerIsolateData::hasInstance):

bindings/v8/V8PerIsolateData.h:

(WebCore::V8PerIsolateData::rawTemplateMap):
(V8PerIsolateData):
(WebCore::V8PerIsolateData::templateMap):

bindings/v8/WrapperTypeInfo.h:
bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

8:57 AM Changeset in webkit [145553] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Notify client if the selection is in a subframe when started.
https://bugs.webkit.org/show_bug.cgi?id=112065

Patch by Genevieve Mak <gmak@rim.com> on 2013-03-12
Reviewed by Rob Buis.

PR #278490
Internally Reviewed by Mike Fenton.

Api/InRegionScroller.cpp:

(BlackBerry::WebKit::InRegionScrollerPrivate::updateSelectionScrollView):
(WebKit):

Api/InRegionScroller_p.h:

(InRegionScrollerPrivate):

Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::updateSelectionScrollView):
(WebKit):

Api/WebPageClient.h:
Api/WebPage_p.h:

(WebPagePrivate):

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):

8:54 AM Changeset in webkit [145552] by zandobersek@gmail.com

19 edits
5 adds
2 deletes in trunk

[GTK] Set up the libPlatformGtk.la library
https://bugs.webkit.org/show_bug.cgi?id=111738

Reviewed by Martin Robinson.

GNUmakefile.am: Define the two variables that will hold sources list and cppflags as required for the new library.

Include the new GNUmakefile.am that's now available under Source/Platform.

Source/Platform:

GNUmakefile.am: Added. Set up the rules for building the new libPlatformGtk.la. For now it will be built in

the same way as libWebCoreGtk.la and in parallel with it while the sources are moved from Source/WebCore/platform
to Source/Platform/gtk and each migrated source file moves to be built in libPlatformGtk.la instead of libWebCoreGtk.la.

GNUmakefile.list.am: Added. Lists the build targets for the libPlatformGtk.la.
gtk/GtkVersioning.c: Renamed from Source/WebCore/platform/gtk/GtkVersioning.c. This file is independent of WebCore and can be moved

and changed to be built into libPlatformGtk.la right away.

gtk/GtkVersioning.h: Renamed from Source/WebCore/platform/gtk/GtkVersioning.h. Ditto.

Source/WebCore:

No new tests - no new functionality.

GNUmakefile.am: Reference platformgtk_cppflags, platformgtk_sources variables along with webcoregtk_cppflags, webcoregtk_sources variables.
GNUmakefile.list.am: Removing GtkVersioning.c and GtkVersioning.h from the sources list, these files have been moved under Source/Platform.
bindings/gobject/GNUmakefile.am: Ditto on the platformgtk_* variables.

Source/WebKit/gtk:

GNUmakefile.am: Reference platformgtk_cppflags variable, libPlatformGtk.la along with webcoregtk_cppflags variable, libWebCoreGtk.la.

Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.

Source/WebKit2:

GNUmakefile.am: Reference platformgtk_cppflags variable, libPlatformGtk.la along with webcoregtk_cppflags variable, libWebCoreGtk.la.

Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.

Tools:

GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.

Adjust the path to GtkVersioning.c, the file has moved under Source/Platform.

TestWebKitAPI/GNUmakefile.am: Reference platformgtk_cppflags variable along with webcoregtk_cppflags variable.

8:28 AM Changeset in webkit [145551] by rgabor@webkit.org

3 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=112141
LLInt CLoop backend misses Double2Ints() on 32bit architectures

Reviewed by Filip Pizlo.

Implement Double2Ints() in CLoop backend of LLInt on 32bit architectures.

llint/LowLevelInterpreter.cpp:

(LLInt):
(JSC::LLInt::Double2Ints):

offlineasm/cloop.rb:

8:23 AM Changeset in webkit [145550] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] Image,ImageBuffer: add missing parameters to methods
https://bugs.webkit.org/show_bug.cgi?id=112148

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

BitmapImage::draw(), Image::drawPattern() and ImageBuffer::draw()
have a BlendMode parameter since r137011.

ImageBuffer::copyImage() has a ScaleBehavior parameter since r134100.

platform/graphics/blackberry/ImageBlackBerry.cpp:

(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):

platform/graphics/blackberry/ImageBufferBlackBerry.cpp:

(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):

8:21 AM Changeset in webkit [145549] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] MediaPlayerPrivate: fix call to MediaStreamDescriptor::label()
https://bugs.webkit.org/show_bug.cgi?id=112140

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

MediaStreamDescriptor::id() was renamed to MediaStreamDescriptor::label() in r139352.

platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::toWebMediaStreamDescriptor):

8:19 AM Changeset in webkit [145548] by eustas@chromium.org

6 edits in trunk/Source/WebCore

Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state
https://bugs.webkit.org/show_bug.cgi?id=112113

Reviewed by Alexander Pavlov.

Updated handlers missed in first patch. Added JSDocs to all handlers.

inspector/front-end/Panel.js: Fixed JSDocs.
inspector/front-end/CallStackSidebarPane.js:

Added return values. Added JSDocs.

inspector/front-end/ScriptsPanel.js: Ditto.
inspector/front-end/GoToLineDialog.js: Added JSDocs.
inspector/front-end/TimelinePanel.js: Ditto.

8:17 AM Changeset in webkit [145547] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] DisplayRefreshMonitor: rename m_timestamp back to m_monotonicAnimationStartTime
https://bugs.webkit.org/show_bug.cgi?id=112139

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

This changed in r131131, but it was accidentally renamed back in r144465.

platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:

(WebCore::DisplayRefreshMonitor::displayLinkFired):

8:16 AM Changeset in webkit [145546] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[BlackBerry] FontPlatformData: HarfBuzz renaming
https://bugs.webkit.org/show_bug.cgi?id=112142

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

When the old HarfBuzz code was removed in r141291,
HarfBuzzNGFace.h was renamed to HarfBuzzFace.h and m_harfbuzzFace
was renamed to m_harfBuzzFace.

These changes need to be reflected in the BlackBerry port.

platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::harfBuzzFace):

8:06 AM Changeset in webkit [145545] by kadam@inf.u-szeged.hu

8 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-5.0-wk2/TestExpectations: Skipped two fullscreen tests after r144837 and r145214.
platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Updated after r145422.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt: Updated after r145422.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt: Updated after r145422.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt: Updated after r145422.
platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt: Updated after r145422.
platform/qt/compositing/overflow/composited-scrolling-paint-phases-expected.txt: Updated after r145422.

8:00 AM Changeset in webkit [145544] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[BlackBerry] FontCacheBlackBerry: return PassRefPtr<SimpleFontData>
https://bugs.webkit.org/show_bug.cgi?id=112022

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Rob Buis.

FontData functions return PassRefPtr since r130160.

platform/graphics/blackberry/FontCacheBlackBerry.cpp:

(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::getSimilarFontPlatformData):
(WebCore::FontCache::getLastResortFallbackFont):

platform/graphics/blackberry/SimpleFontDataBlackBerry.cpp:

(WebCore::SimpleFontData::createScaledFontData):

7:53 AM Changeset in webkit [145543] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Fix checkContentUpdated behavior in UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=112037

Reviewed by Alexander Pavlov.

UISourceCode.checkContentUpdated now saves last updated content that was loaded and rejected
by user on the per-file basis (only the last one was saved currently).

inspector/front-end/FileSystemProjectDelegate.js:

(WebInspector.FileSystemProjectDelegate.prototype.innerCallback):
(WebInspector.FileSystemProjectDelegate.prototype.requestFileContent):
(WebInspector.FileSystemProjectDelegate.prototype.canSetFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype._fileSystemAdded):

inspector/front-end/SimpleWorkspaceProvider.js:

(WebInspector.SimpleProjectDelegate.prototype.canSetFileContent):

inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.checkContentUpdated.contentLoaded):
(WebInspector.UISourceCode.prototype.checkContentUpdated):
(WebInspector.UISourceCode.prototype._commitContent):
(WebInspector.UISourceCode.prototype.addRevision):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

inspector/front-end/Workspace.js:

(WebInspector.ProjectDelegate.prototype.canSetFileContent):
(WebInspector.Project.prototype.canSetFileContent):

7:51 AM Changeset in webkit [145542] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Gtk] NBSP are not replaced when using X clipboard
https://bugs.webkit.org/show_bug.cgi?id=112118

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-12
Reviewed by Martin Robinson.

We're not replacing nbsp with spaces when using X clipboard
(Shift+Insert or middle mouse button).

platform/gtk/DataObjectGtk.cpp:

(WebCore::DataObjectGtk::text):

7:48 AM WebKitGTK/2.0.x edited by Martin Robinson

(diff)

7:38 AM Changeset in webkit [145541] by fmalita@chromium.org

9 edits
2 adds in trunk

SVG Pattern pixelated on inline SVG with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=111587

Reviewed by Dirk Schulze.

Source/WebCore:

When calculating the resolution for resource image buffers, we need to also consider CSS
transforms. This patch updates calculateTransformationToOutermostSVGCoordinateSystem()
(renamed to calculateTransformationToOutermostCoordinateSystem) to include the affine
component from CSS transforms by walking the parent layer tree.

Test: svg/custom/resources-css-scaled.html

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):

rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::calculateScreenFontSizeScalingFactor):
(WebCore::SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem):

rendering/svg/SVGRenderingContext.h:

(SVGRenderingContext):

LayoutTests:

svg/custom/resources-css-scaled-expected.html: Added.
svg/custom/resources-css-scaled.html: Added.

7:35 AM Changeset in webkit [145540] by yurys@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: add html canvas memory details to the native memory overview
https://bugs.webkit.org/show_bug.cgi?id=112123

Reviewed by Alexander Pavlov.

Show memory occupied vby HTMLCanvasElements under Image category
in the native memory overview.

inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshot.prototype.images.getImageName):
(WebInspector.NativeHeapSnapshot.prototype.images.getCanvasName):
(WebInspector.NativeHeapSnapshot.prototype.images):
(WebInspector.NativeHeapSnapshot.prototype._addNodes):

6:10 AM Changeset in webkit [145539] by vsevik@chromium.org

5 edits in trunk

Web Inspector: ResourceScriptFile diverged state should be correctly reset after debugger reset.
https://bugs.webkit.org/show_bug.cgi?id=112036

Reviewed by Alexander Pavlov.

Source/WebCore:

inspector/front-end/ResourceScriptMapping.js:

(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._maybeDirtyChanged):

LayoutTests:

inspector/debugger/file-system-project-mapping-expected.txt:
inspector/debugger/file-system-project-mapping.html:

6:02 AM Changeset in webkit [145538] by commit-queue@webkit.org

33 edits in trunk/Source/WebCore

[V8] Move the GetRawTemplate and HasInstance logic from generated bindings to V8PerIsolateData
https://bugs.webkit.org/show_bug.cgi?id=112136

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Kentaro Hara.

When templates for main world and non-main worlds will be separated (bug
111724), HasInstance logic will be a bit ugly: We cannot determine the
world type on the fly, because during GC there is no entered context,
and HasInstance is called during GC. So we need to check against
templates from all the worlds. It's cleaner if that logic is in
V8PerIsolateData.

No new tests (Updated existing bindings tests).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateDomainSafeFunctionGetter):
(GenerateImplementation):
(CreateCustomSignature):

bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::GetTemplate):
(WebCore::V8Float64Array::HasInstance):

bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::GetTemplate):
(WebCore::V8TestCustomNamedGetter::HasInstance):

bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::GetTemplate):
(WebCore::V8TestEventConstructor::HasInstance):

bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::GetTemplate):
(WebCore::V8TestEventTarget::HasInstance):

bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):

bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::GetTemplate):
(WebCore::V8TestInterface::HasInstance):

bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::GetTemplate):
(WebCore::V8TestMediaQueryListListener::HasInstance):

bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::GetTemplate):
(WebCore::V8TestNamedConstructor::HasInstance):

bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::GetTemplate):
(WebCore::V8TestNode::HasInstance):

bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::GetTemplate):
(WebCore::V8TestObj::HasInstance):

bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::GetTemplate):
(WebCore::V8TestOverloadedConstructors::HasInstance):

bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::GetTemplate):
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

bindings/scripts/test/V8/V8TestTypedefs.cpp:

(WebCore::ConfigureV8TestTypedefsTemplate):
(WebCore::V8TestTypedefs::GetTemplate):
(WebCore::V8TestTypedefs::HasInstance):

bindings/scripts/test/V8/V8TestTypedefs.h:

(V8TestTypedefs):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::rawTemplate):
(WebCore):
(WebCore::V8PerIsolateData::hasInstance):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

5:45 AM Changeset in webkit [145537] by eustas@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Fix JSDocs in TimelinePanel.js
https://bugs.webkit.org/show_bug.cgi?id=112137

Reviewed by Vsevolod Vlasov.

Fix parameter type annotation of _loadFromFile.

inspector/front-end/TimelinePanel.js: Fixed JSDoc.

5:42 AM Changeset in webkit [145536] by vsevik@chromium.org

6 edits
3 adds in trunk

Web Inspector: Add a test for Workspace add/removeMapping methods.
https://bugs.webkit.org/show_bug.cgi?id=112035

Reviewed by Alexander Pavlov.

Source/WebCore:

Test: inspector/debugger/file-system-project-mapping.html

inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork.mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapFileSystemToNetwork):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem.mapNetworkToFileSystem):
(WebInspector.ScriptsPanel.prototype._mapNetworkToFileSystem):

inspector/front-end/Workspace.js:

(WebInspector.Project.prototype._fileAdded):
(WebInspector.Workspace.prototype.addMapping):

LayoutTests:

http/tests/inspector/isolated-filesystem-test.js: Added.

(initialize_IsolatedFileSystemTest.InspectorTest.createIsolatedFileSystemManager):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.path):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.requestFileContent):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.setFileContent):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystem.prototype.requestFilesRecursive):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager.prototype.addMockFileSystem):
(initialize_IsolatedFileSystemTest.MockIsolatedFileSystemManager.prototype.removeMockFileSystem):
(initialize_IsolatedFileSystemTest):

inspector/debugger/file-system-project-mapping-expected.txt: Added.
inspector/debugger/file-system-project-mapping.html: Added.
inspector/debugger/resource-script-mapping.html:
inspector/file-system-project.html:

5:32 AM Changeset in webkit [145535] by mikhail.pozdnyakov@intel.com

5 edits in trunk/Source/WebKit2

[WK2][EFL] Fix EwkContext class API
https://bugs.webkit.org/show_bug.cgi?id=111706

Reviewed by Alexey Proskuryakov.

UIProcess/API/C/efl/WKView.cpp:

(createWKView):

UIProcess/API/efl/ewk_context.cpp:

(EwkContext::findOrCreateWrapper):

Renamed from create() as it returns the same instance of EwkContext
for the given WKContextRef if present.

(EwkContext::create):
(EwkContext::defaultContext):

Returns raw pointer rather than PassRefPtr<EwkContext> as ownership
is not transferred.

(ewk_context_default_get):

UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

5:29 AM Changeset in webkit [145534] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] SelectionHandler: fix truncated line
https://bugs.webkit.org/show_bug.cgi?id=112133

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Carlos Garcia Campos.

One of the calls to fatFingersResult.nodeAsElementIfApplicable()
was somehow truncated when the selection start animation was
upstreamed in r144640.

WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectAtPoint):

5:29 AM Changeset in webkit [145533] by vsevik@chromium.org

6 edits
2 adds in trunk

Web Inspector: SourceFrames are leaking on reload.
https://bugs.webkit.org/show_bug.cgi?id=111961

Reviewed by Alexander Pavlov.

Source/WebCore:

Added dispose method on UISourceCodeFrame.
Scripts panel now calls dispose when SourceFrame is removed and JavaScriptSourceFrame
could remove breakpoint manager listeners in it.
TabbedEditorContainer does not call viewForFile other than in appendFileTab methods to
avoid recreating SourceFrame for uiSourceCode when it was already removed.

Test: inspector/debugger/breakpoint-manager-listeners-count.html

inspector/front-end/JavaScriptSourceFrame.js:

(WebInspector.JavaScriptSourceFrame.prototype.dispose):

inspector/front-end/ScriptsPanel.js:
inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._addScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._removeScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):

inspector/front-end/UISourceCodeFrame.js:

(WebInspector.UISourceCodeFrame.prototype.dispose):

LayoutTests:

inspector/debugger/breakpoint-manager-listeners-count-expected.txt: Added.
inspector/debugger/breakpoint-manager-listeners-count.html: Added.

5:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

5:27 AM Changeset in webkit [145532] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0

Merge r145427 - [Autotools] Set ENABLE_GTK_DOC to false if gtk-doc is not installed
https://bugs.webkit.org/show_bug.cgi?id=111980

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-03-11
Reviewed by Martin Robinson.

WebKit did not configure if gtk-doc-am was not installed with the error:
Tools/GNUmakefile.am:419: ENABLE_GTK_DOC does not appear in AM_CONDITIONAL

Source/autotools/FindDependencies.m4:

5:23 AM Changeset in webkit [145531] by apavlov@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: [Elements] Unable to undo "Edit as HTML" changes in the editor
https://bugs.webkit.org/show_bug.cgi?id=112119

Reviewed by Vsevolod Vlasov.

No new tests, a UI change.

inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel.prototype.handleShortcut): Do not undo/redo DOM/CSS changes if editing DOM text.

inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.editing): Added.

5:15 AM Changeset in webkit [145530] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Web Inspector: [CodeMirror] there are bugs in TokenHighlight feature
https://bugs.webkit.org/show_bug.cgi?id=112039

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-12
Reviewed by Vsevolod Vlasov.

Fix token highlight in codeMirror experiment

rewrite token highlight overlay mode to highlight words, not

substrings

add workaround to avoid selection of already selected word

No new tests.

inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._cursorChange):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._removeHighlight):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype.nextToken):
(WebInspector.CodeMirrorTextEditor.TokenHighlighter.prototype._addHighlight):

inspector/front-end/cm/cmdevtools.css:

(.line-with-selection .cm-column-with-selection):

5:11 AM Changeset in webkit [145529] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Fix visible_units.h includes
https://bugs.webkit.org/show_bug.cgi?id=112131

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-03-12
Reviewed by Carlos Garcia Campos.

This file was renamed to VisibleUnits.h in r144911.

WebKitSupport/DOMSupport.cpp:
WebKitSupport/InputHandler.cpp:
WebKitSupport/SelectionHandler.cpp:
WebKitSupport/SpellingHandler.cpp:

5:11 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

5:09 AM Changeset in webkit [145528] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Add webkit_web_context_set_disk_cache_directory to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111848

Reviewed by Gustavo Noronha Silva.

This allow applications to set a custom directory for the disk
cache.

UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_disk_cache_directory):

UIProcess/API/gtk/WebKitWebContext.h:
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
UIProcess/API/gtk/tests/TestMain.cpp:

(removeNonEmptyDirectory):
(main): Use a different temporary disk cache directory for every
test.

5:01 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

5:00 AM Changeset in webkit [145527] by Carlos Garcia Campos

6 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[SOUP] Soup disk cache should respect the diskCacheDirectory from the process initial parameters
https://bugs.webkit.org/show_bug.cgi?id=111845

Reviewed by Xan Lopez.

Move the cache initialization to platformInitializeWebProcess() to
create the cache using the directory received from the UI
process. This allows to add public API to set a different disk
cache directory from the UI process.

UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformDefaultDiskCacheDirectory): Return
default disk cache directory.

UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformDefaultDiskCacheDirectory): Ditto.

WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl): Remove soup cache initialization.

WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk): Ditto.

WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess): Initialize
soup cache.

4:56 AM Changeset in webkit [145526] by zandobersek@gmail.com

4 edits in trunk

[GTK] Enable Web Audio in development builds
https://bugs.webkit.org/show_bug.cgi?id=111831

Reviewed by Philippe Normand.

Source/WebKit2:

GNUmakefile.am: Link the plugin process against libWebCoreModules.la as well.

Tools:

Web Audio is already quite well supported on the GTK port but still has a few issues
that must be addressed before it is enabled by default. Despite that it should be enabled
in development builds just so we are up-to-date with future feature infrastructure changes.
The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
that's an obvious goal before enabling the feature in release builds.

Scripts/webkitperl/FeatureList.pm:

4:44 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:43 AM Changeset in webkit [145525] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

[GTK] Add webkit_web_page_get_id() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111938

Reviewed by Xan Lopez.

Add API to the web extensions API to get the identifier of a web
page.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(methodCallCallback): Check the page ID matches the one returned
by webkit_web_page_get_id().

WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_get_id):

WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:

4:38 AM Changeset in webkit [145524] by falken@chromium.org

8 edits in trunk/Source/WebCore

Unreviewed, rolling out r145514.
http://trac.webkit.org/changeset/145514
https://bugs.webkit.org/show_bug.cgi?id=112134

breaks Mac build (Requested by falken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

dom/Element.cpp:
dom/Element.h:
dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:

(WebCore):
(WebCore::Node::isInert):
(WebCore::Node::handleLocalEvents):
(WebCore::Node::disabled):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:

(Node):

4:32 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:31 AM Changeset in webkit [145523] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit/gtk

Merge r145070 - [GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings
https://bugs.webkit.org/show_bug.cgi?id=111414

Patch by Tomas Popela <tpopela@redhat.com> on 2013-03-07
Reviewed by Carlos Garcia Campos.

We should expose ShouldRespectImageOrientation setting into
WebKitWebSettings. When it is enabled, the images are shown with right
orientation regarding to images EXIF data.

webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

webkit/webkitwebsettingsprivate.h:
webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

4:28 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:26 AM Changeset in webkit [145522] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Unreviewed EFL gardening.
https://bugs.webkit.org/show_bug.cgi?id=112130

Gardening; assigning bug numbers to failure accessibility tests.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-12

platform/efl-wk1/TestExpectations:
platform/efl-wk2/TestExpectations:

4:26 AM Changeset in webkit [145521] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebCore

Merge r145318 - Fix offset handling in GStreamer WebKitWebSource.
https://bugs.webkit.org/show_bug.cgi?id=111888

Patch by Sebastian Dröge <sebastian.droege@collabora.co.uk> on 2013-03-09
Reviewed by Philippe Normand.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcSeekDataCb):
(StreamingClient::didReceiveData):
The offset handling in WebKitWebSource was completely wrong
before and caused wrong offsets to be set on the GStreamer buffers
after a seek.

Apart from that there was also a race condition that happens
when a downstream element causes seeks in very short succession
and is switching between two different parts of the stream.

4:18 AM Changeset in webkit [145520] by commit-queue@webkit.org

8 edits
1 add in trunk/Source/WebCore

Web Inspector: [CodeMirror] highlight matching braces
https://bugs.webkit.org/show_bug.cgi?id=112041

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-12
Reviewed by Vsevolod Vlasov.

Add "matchbrackets" add-on to CodeMirror text editor add override
default styles for matched and unmatched braces.

No new tests.

WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
inspector/front-end/CodeMirrorTextEditor.js:

(WebInspector.CodeMirrorTextEditor):

inspector/front-end/WebKit.qrc:
inspector/front-end/cm/cmdevtools.css:

(.CodeMirror-matchingbracket):
(.CodeMirror-nonmatchingbracket):

inspector/front-end/cm/matchbrackets.js: Added.

(.):

4:18 AM Changeset in webkit [145519] by jocelyn.turcotte@digia.com

8 edits in trunk/Source/WebKit2

[Qt][WK2] Layer QtDownloadManager on the C API
https://bugs.webkit.org/show_bug.cgi?id=109562

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

UIProcess/API/cpp/qt/WKURLQt.cpp:

(WebKit::adoptToQString):
(WebKit):
(WebKit::adoptToQUrl):

UIProcess/API/cpp/qt/WKURLQt.h:

(WebKit):

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::handleDownloadRequest):

UIProcess/qt/QtDownloadManager.cpp:

(WebKit::toQtDownloadManager):
(WebKit):
(WebKit::QtDownloadManager::QtDownloadManager):
(WebKit::QtDownloadManager::addDownload):
(WebKit::QtDownloadManager::didReceiveResponse):
(WebKit::QtDownloadManager::didCreateDestination):
(WebKit::QtDownloadManager::didFinishDownload):
(WebKit::QtDownloadManager::didFailDownload):
(WebKit::QtDownloadManager::didReceiveDataForDownload):

UIProcess/qt/QtDownloadManager.h:

(WebKit):
(QtDownloadManager):

UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::QtWebContext):

UIProcess/qt/QtWebError.cpp:

(WebKit::QtWebError::url):
(WebKit::QtWebError::description):

4:17 AM Changeset in webkit [145518] by jocelyn.turcotte@digia.com

11 edits
2 adds in trunk/Source/WebKit2

[Qt][WK2] Layer QtWebIconDatabaseClient on the C API
https://bugs.webkit.org/show_bug.cgi?id=109564

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

Target.pri:
UIProcess/API/C/qt/WKIconDatabaseQt.cpp: Added.

(WKIconDatabaseTryGetQImageForURL):

New API added to get a QImage from the IconDatabase. Based on WKIconDatabaseCG.h/cpp

UIProcess/API/C/qt/WKIconDatabaseQt.h: Added.
UIProcess/API/cpp/qt/WKURLQt.cpp:

(WKURLCreateWithQString):
(WKURLCopyQString):
(WKURLCreateWithQUrl):
(WKURLCopyQUrl):

The WKUrlRef behind the scene is a WTF::String and encoding it back and forth to a QUrl can slightly change its string representation. Allow converting a WKUrlRef to and from a QString to ensure this.

UIProcess/API/cpp/qt/WKURLQt.h:
UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::iconURLForPageURLInContext):

The icon URL isn't accessible form the C API and shouldn't need to be. Use an ID incremented on each update to trigger an update of the QML Image component.

(QWebIconImageProvider::requestImage):

The IconDatabase was previously assumed to resize the image to the requested size, but this parameter is ignored, as stated in a comment in WebIconDatabase::imageForPageURL. Explicitely do the resize after fetching the original icon to also be able to report the original size properly to QtQuick.

UIProcess/API/qt/qwebiconimageprovider_p.h:
UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:
- Set the image to load asynchronously to further test the possibility of threading issues in QtWebIconDatabaseClient::iconImageForPageURL
- Add a few barriers to fix some issues where the load succeeded signal would be wrongly catched by init() before the next test.
UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::QtWebContext):

UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit):
(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):
(WebKit::QtWebIconDatabaseClient::~QtWebIconDatabaseClient):
(WebKit::QtWebIconDatabaseClient::updateID):
(WebKit::QtWebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):

Remove the Mutex. This mutex was useless given that it would only be locked from a single thread. Since the IconDatabase runs in its own thread, it already is thread-safe to access.

(WebKit::QtWebIconDatabaseClient::retainIconForPageURL):
(WebKit::QtWebIconDatabaseClient::releaseIconForPageURL):

UIProcess/qt/QtWebIconDatabaseClient.h:

(QtWebIconDatabaseClient):

WebKit2.pri:

4:16 AM Changeset in webkit [145517] by jocelyn.turcotte@digia.com

7 edits
2 deletes in trunk/Source/WebKit2

[Qt][WK2] Specify storage paths through the C API
https://bugs.webkit.org/show_bug.cgi?id=111435

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

The WKIconDatabase should be opened through a call to
WKContextSetIconDatabasePath. To avoid having some paths
returned through WebContext::platformDefault* and some others
through the C API, make sure that all those paths are set
through the C API.

Shared/qt/QtDefaultDataLocation.cpp: Removed.
Shared/qt/QtDefaultDataLocation.h: Removed.
Target.pri:
UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:

(WebKit::cacheFile):

This part is left alone behind the C API. Since PluginProcessProxy have no knowledge of the WebContext it is rather difficult to fetch a configured directory that could be used for this purpose (like the disk cache storage). Hard-code a compatible logic to keep the current behavior.

(WebKit::removeCacheFile):
(WebKit):
(WebKit::readMetaDataFromCacheFile):
(WebKit::writeToCacheFile):
(WebKit::tryReadPluginMetaDataFromCacheFile):

Update the code to better handle an empty cache file path.

UIProcess/qt/QtWebContext.cpp:

(WebKit::QtWebContext::defaultContext):
(WebKit::defaultLocation):
(WebKit):
(WebKit::QtWebContext::preparedStoragePath):

UIProcess/qt/QtWebContext.h:
UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::QtWebIconDatabaseClient):

UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):
(WebKit::WebContext::platformDefaultDiskCacheDirectory):
(WebKit::WebContext::platformDefaultCookieStorageDirectory):

4:14 AM Changeset in webkit [145516] by jocelyn.turcotte@digia.com

4 edits in trunk/Source/WebKit2

[Qt] Properly layer QtWebContext on top of the C API
https://bugs.webkit.org/show_bug.cgi?id=108475

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):

UIProcess/qt/QtWebContext.cpp:

(WebKit::initializeContextInjectedBundleClient):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):

UIProcess/qt/QtWebContext.h:

(WebKit):
(QtWebContext):
(WebKit::QtWebContext::context):

4:13 AM Changeset in webkit [145515] by jocelyn.turcotte@digia.com

11 edits in trunk/Source/WebKit2

[Qt][WK2] Allow QtWebContext to call directly to QQuickWebView with a WKPageRef
https://bugs.webkit.org/show_bug.cgi?id=109829

Reviewed by Allan Sandfeld Jensen.
Signed off for WebKit2 by Benjamin Poulain.

Instead of going through WebPageProxy and PageClient to forward
injected bundle messages received by the context, maintain a static map
of WKPageRef to QQuickWebViewPrivate.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::get):
(QQuickWebViewPrivate::~QQuickWebViewPrivate):
(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::didReceiveMessageFromNavigatorQtObject):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/API/qt/raw/qrawwebview.cpp:
UIProcess/API/qt/raw/qrawwebview_p_p.h:
UIProcess/PageClient.h:

(PageClient):

UIProcess/WebPageProxy.h:

(WebPageProxy):

UIProcess/qt/QtPageClient.cpp:
UIProcess/qt/QtPageClient.h:

(QtPageClient):

UIProcess/qt/QtWebContext.cpp:

(WebKit::didReceiveMessageFromInjectedBundle):

UIProcess/qt/WebPageProxyQt.cpp:

4:13 AM Changeset in webkit [145514] by falken@chromium.org

8 edits in trunk/Source/WebCore

Refactoring: Pull Node::disabled() and Node::isInert() down to Element.
https://bugs.webkit.org/show_bug.cgi?id=112085

Reviewed by Hajime Morrita.

Node is too low a level for these methods.

No new tests, just refactoring.

dom/Element.cpp:

(WebCore::Element::disabled):
(WebCore):
(WebCore::Element::isInert):

dom/Element.h:

(Element):

dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick):

dom/GestureEvent.cpp:

(WebCore::GestureEventDispatchMediator::dispatchEvent):

dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::dispatchEvent):

dom/Node.cpp:

(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):

dom/Node.h:

(Node):

4:12 AM Changeset in webkit [145513] by jocelyn.turcotte@digia.com

7 edits in trunk/Source/WebKit2

[Qt][WK2] Keep the WebContext alive during the whole application's lifetime
https://bugs.webkit.org/show_bug.cgi?id=109827

Reviewed by Simon Hausmann.
Signed off for WebKit2 by Benjamin Poulain.

The lifetime of the WebContext is difficult to manage because of a circular
reference kept with the WebProcessProxy until it shuts itself down, 60
seconds after the last page is closed. There was some notification
in place to handle this in the upper layer, but having to go through the
C API (done in a following patch) makes this quite awkward.

Keeping the WebContext alive also includes the icon database which is
quite heavy, in the future we should only enable it once the
QQuickWebView::icon property is read.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::handleDownloadRequest):
(QQuickWebViewPrivate::updateIcon):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::requestImage):

UIProcess/qt/QtWebContext.cpp:

(WebKit):
(WebKit::QtWebContext::QtWebContext):
(WebKit::QtWebContext::~QtWebContext):
(WebKit::QtWebContext::create):
(WebKit::QtWebContext::defaultContext):

UIProcess/qt/QtWebContext.h:

(QtWebContext):
(WebKit::QtWebContext::downloadManager):
(WebKit::QtWebContext::iconDatabase):

UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInvalidateContext):

4:11 AM Changeset in webkit [145512] by jocelyn.turcotte@digia.com

7 edits in trunk/Source/WebKit2

[Qt][WK2] Favor QUrl and QString over WTF::String in the Qt API layer
https://bugs.webkit.org/show_bug.cgi?id=109468

Reviewed by Allan Sandfeld Jensen.
Signed off for WebKit2 by Benjamin Poulain.

In preparation for patches using the C API types in some areas, remove the
usage of WTF::String on the affected line.

Use a QUrl for icon URL to avoid unnecessary conversion.
Use a QString for the page URL to keep it compatible with WebPageProxy and
WebIconDatabase and avoid QUrl parsing.

UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::_q_onIconChangedForPageURL):
(QQuickWebViewPrivate::updateIcon):
(QQuickWebView::emitUrlChangeIfNeeded):
(QQuickWebView::icon):

UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

UIProcess/API/qt/qwebiconimageprovider.cpp:

(QWebIconImageProvider::iconURLForPageURLInContext):

UIProcess/API/qt/qwebiconimageprovider_p.h:
UIProcess/qt/QtWebIconDatabaseClient.cpp:

(WebKit::QtWebIconDatabaseClient::iconForPageURL):
(WebKit::QtWebIconDatabaseClient::iconImageForPageURL):
(WebKit::QtWebIconDatabaseClient::retainIconForPageURL):
(WebKit::QtWebIconDatabaseClient::releaseIconForPageURL):

UIProcess/qt/QtWebIconDatabaseClient.h:

(QtWebIconDatabaseClient):

4:07 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

4:05 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:47 AM Changeset in webkit [145511] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[V8] Get rid of function-level static FunctionTemplates in generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=111971

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Jochen Eisinger.

In the future we'll create and store function templates for main world
and non-main worlds separately (see bug 111724), having function
templates as static variables inside functions will break the
functionality.

No new tests (updated the bindings test expectations).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

3:14 AM Changeset in webkit [145510] by tasak@google.com

15 edits
4 copies in trunk/Source/WebCore

[Refactoring] Implement RuleCollector
https://bugs.webkit.org/show_bug.cgi?id=109916

Reviewed by Antti Koivisto.

Implemented rule collector for an element and collector for a page.
Not all members in class State are required entire while resolving
a style.

No new tests, because just refactoring.

CMakeLists.txt:
GNUmakefile.list.am:
Target.pri:
WebCore.gypi:
WebCore.xcodeproj/project.pbxproj:
css/CSSAllInOne.cpp:

Added ElementRuleCollector and PageRuleCollector.

css/DocumentRuleSets.cpp:

(WebCore::ShadowDistributedRules::collectMatchRequests):
Since behaviorAtBoundary is a state owned by ElementRuleCollector,
removed from here.

css/DocumentRuleSets.h:

(WebCore::ShadowDistributedRules::isEmpty):
Added to quickly check whether there exist any ShadowDistributedRules
or not.

css/ElementRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.

(WebCore):
(WebCore::ElementRuleCollector::matchedResult):
(WebCore::ElementRuleCollector::matchedRuleList):
(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::ensureRuleList):
(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::matchScopedAuthorRules):
(WebCore::ElementRuleCollector::matchHostRules):
(WebCore::ElementRuleCollector::matchShadowDistributedRules):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):
(WebCore::ElementRuleCollector::ruleMatches):
(WebCore::ElementRuleCollector::collectMatchingRulesForList):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::matchAllRules):
Moved these methods from StyleResolver to this class.
(WebCore::ElementRuleCollector::hasAnyMatchingRules):
This method is used for checking whether a given element can share
a cache.

css/ElementRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.

(WebCore):
(WebCore::ElementRuleCollector::ElementRuleCollector):
Use styleResolver instance to initialize its member variables, i.e.
SelectorFilter, RuleSets, InspectorCSSOMWrappers, and
StyleScopedResolver.
(ElementRuleCollector):
(WebCore::ElementRuleCollector::setMode):
(WebCore::ElementRuleCollector::setPseudoStyleRequest):
(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling):
Mode, SameOriginOnly, RegionForStyling are only used while collecting
matched rules.
(WebCore::ElementRuleCollector::setMedium):
Need to know which default stylesheet should be looked up.
(WebCore::ElementRuleCollector::document):

css/PageRuleCollector.cpp: Copied from Source/WebCore/css/StyleResolver.cpp.

(WebCore::comparePageRules):
(WebCore::PageRuleCollector::isLeftPage):
(WebCore::PageRuleCollector::isFirstPage):
(WebCore::PageRuleCollector::pageName):
(WebCore::PageRuleCollector::matchAllPageRules):
(WebCore::PageRuleCollector::matchPageRules):
(WebCore::checkPageSelectorComponents):
(WebCore::PageRuleCollector::matchPageRulesForList):
Moved from StyleResolver.

css/PageRuleCollector.h: Copied from Source/WebCore/css/StyleResolver.h.

(WebCore):
(WebCore::PageRuleCollector::PageRuleCollector):
(PageRuleCollector):
(WebCore::PageRuleCollector::matchedResult):

css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::applyMatchedProperties):

css/StyleResolver.h:

(WebCore::MatchRequest::MatchRequest):
Removed behaviorAtBoundary. Instead, ElementRuleCollector have the
state.
(MatchRequest):
(WebCore::StyleResolver::selectorFilter):
Added to obtain SelectorFilter in ElementRuleCollector's constructor.
(StyleResolver):
(MatchResult):
(WebCore::StyleResolver::State::State):
To pass ASSERT in StyleResolver::applyProperties, need to keep
m_regionForStyling.
(State):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::useSVGZoomRules):
(WebCore::StyleResolver::hasSelectorForId):
(WebCore):
(WebCore::checkRegionSelector):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::willMatchRule):
Removed StyleResolver from its parameter list. Instead, added
InspectorCSSOMWrappers and DocumentStyleSheetCollection.

inspector/InspectorCSSAgent.h:

(WebCore):
(InspectorCSSAgent):

inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):

inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):

3:14 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos

(diff)

3:12 AM Changeset in webkit [145509] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.0/Source/WebKit2

Merge r145508 - [GTK][WK2] REGRESSION(r145081): Unit tests not working if locale is not English
https://bugs.webkit.org/show_bug.cgi?id=111973

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-12
Reviewed by Carlos Garcia Campos.

The problem is that the UIProcess locale is reseted to C in
gtk_test_init, however the WebProcess does not inherit the locale set in
the UIProcess and it uses the system one (that could be different to
English). So, there were problems in some tests that are comparing
strings from both processes like WebKit2APITests/TestPrinting and
WebKit2APITests/TestWebKitWebContext. The solution is to set the locale
environment variable LC_ALL to C in order to reset WebProcess locale
too.

UIProcess/API/gtk/tests/TestMain.cpp:

(main): Set environment variable LC_ALL to C.

3:07 AM Changeset in webkit [145508] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK][WK2] REGRESSION(r145081): Unit tests not working if locale is not English
https://bugs.webkit.org/show_bug.cgi?id=111973

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-03-12
Reviewed by Carlos Garcia Campos.

UIProcess/API/gtk/tests/TestMain.cpp:

(main): Set environment variable LC_ALL to C.

2:52 AM Changeset in webkit [145507] by pfeldman@chromium.org

2 edits in trunk/LayoutTests

Not reviewed: chromium gardening.

platform/chromium/TestExpectations:

2:41 AM Changeset in webkit [145506] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[Qt] WebKit fails to compile if EGL headers are not in default INCLUDEPATH
https://bugs.webkit.org/show_bug.cgi?id=111859

Patch by Floris Bos <bos@je-eigen-domein.nl> on 2013-03-12
Reviewed by Jocelyn Turcotte.

The 3D graphics code wants to include EGL header files.
But on some platforms such as the Raspberry Pi those are not in /usr/include
but in another folder.
Fix adds "egl" to CONFIG when OpenGL ES2 is used, so the right include
paths are added.

WebCore.pri:

2:41 AM Changeset in webkit [145505] by rgabor@webkit.org

3 edits in trunk/Source/JavaScriptCore

Making more sophisticated cache flush on ARM Linux platform
https://bugs.webkit.org/show_bug.cgi?id=111854

Reviewed by Zoltan Herczeg.

The cache flush on ARM Linux invalidates whole pages
instead of just the required area.

assembler/ARMAssembler.h:

(ARMAssembler):
(JSC::ARMAssembler::linuxPageFlush):
(JSC::ARMAssembler::cacheFlush):

assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::linuxPageFlush):
(JSC::ARMv7Assembler::cacheFlush):

2:30 AM Changeset in webkit [145504] by rgabor@webkit.org

7 edits
1 move in trunk/Source/JavaScriptCore

Renaming the armv7.rb LLINT backend to arm.rb
https://bugs.webkit.org/show_bug.cgi?id=110565

Reviewed by Zoltan Herczeg.

This is the first step of a unified ARM backend for
all ARM 32 bit architectures in LLInt.

CMakeLists.txt:
GNUmakefile.list.am:
JavaScriptCore.gypi:
LLIntOffsetsExtractor.pro:
offlineasm/arm.rb: Copied from Source/JavaScriptCore/offlineasm/armv7.rb.
offlineasm/armv7.rb: Removed.
offlineasm/backends.rb:
offlineasm/risc.rb:

2:28 AM Changeset in webkit [145503] by mkwst@chromium.org

208 edits in trunk

XSSAuditor should send only one console error when blocking a page.
https://bugs.webkit.org/show_bug.cgi?id=110733

Reviewed by Daniel Bates.

Source/WebCore:

Currently, we send two console errors when XSSAuditor blocks a page:
"Refused to execute a JavaScript script. Source code of script found
within request.\n", and "Entire page will be blocked.".

We should only send one message, tuning it properly for the context, and
including the URL of the page effected by the XSSAuditor's work.

Covered by rebaselines of all the XSSAuditor and 'reflected-xss' tests.

html/parser/XSSAuditor.cpp:
html/parser/XSSAuditor.h:

(WebCore::XSSAuditor::XSSAuditor):

Add two booleans to track the headers used to set the XSSAuditor state.

(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

Add detail about the header status to the constructed XSSInfo object.

html/parser/XSSAuditorDelegate.cpp:

(WebCore::buildConsoleError):

Move message construction out into a separate inlined function, as
it's becoming complex.

(WebCore::XSSAuditorDelegate::didBlockScript):

Fold the "Entire page will be blocked" message into the main console
error.

html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):
(WebCore::XSSInfo::XSSInfo):

Add detail about header status to XSSInfo in order to correctly
construct the console error.

LayoutTests:

fast/frames/xss-auditor-handles-file-urls-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-allow-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-allow-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-block-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-allow-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-filter-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-allow-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-invalid-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-invalid-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-and-xss-protection-unset-unset-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter-expected.txt:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
http/tests/security/xssAuditor/base-href-control-char-expected.txt:
http/tests/security/xssAuditor/base-href-expected.txt:
http/tests/security/xssAuditor/base-href-null-char-expected.txt:
http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt:
http/tests/security/xssAuditor/cached-frame-expected.txt:
http/tests/security/xssAuditor/cookie-injection-expected.txt:
http/tests/security/xssAuditor/dom-write-URL-expected.txt:
http/tests/security/xssAuditor/dom-write-location-expected.txt:
http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
http/tests/security/xssAuditor/dom-write-location-javascript-URL-expected.txt:
http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/embed-tag-expected.txt:
http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/formaction-on-button-expected.txt:
http/tests/security/xssAuditor/formaction-on-input-expected.txt:
http/tests/security/xssAuditor/form-action-expected.txt:
http/tests/security/xssAuditor/full-block-base-href-expected.txt:
http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/get-from-iframe-expected.txt:
http/tests/security/xssAuditor/iframe-injection-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
http/tests/security/xssAuditor/javascript-link-expected.txt:
http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
http/tests/security/xssAuditor/link-onclick-expected.txt:
http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
http/tests/security/xssAuditor/malformed-HTML-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/object-tag-expected.txt:
http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/open-attribute-body-expected.txt:
http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
http/tests/security/xssAuditor/open-iframe-src-01-expected.txt:
http/tests/security/xssAuditor/open-iframe-src-02-expected.txt:
http/tests/security/xssAuditor/open-script-src-01-expected.txt:
http/tests/security/xssAuditor/open-script-src-02-expected.txt:
http/tests/security/xssAuditor/open-script-src-03-expected.txt:
http/tests/security/xssAuditor/open-script-src-04-expected.txt:
http/tests/security/xssAuditor/post-from-iframe-expected.txt:
http/tests/security/xssAuditor/property-escape-comment-01-expected.txt:
http/tests/security/xssAuditor/property-escape-comment-02-expected.txt:
http/tests/security/xssAuditor/property-escape-comment-03-expected.txt:
http/tests/security/xssAuditor/property-escape-entity-01-expected.txt:
http/tests/security/xssAuditor/property-escape-entity-02-expected.txt:
http/tests/security/xssAuditor/property-escape-entity-03-expected.txt:
http/tests/security/xssAuditor/property-escape-expected.txt:
http/tests/security/xssAuditor/property-escape-long-expected.txt:
http/tests/security/xssAuditor/property-escape-quote-01-expected.txt:
http/tests/security/xssAuditor/property-escape-quote-02-expected.txt:
http/tests/security/xssAuditor/property-escape-quote-03-expected.txt:
http/tests/security/xssAuditor/report-script-tag-expected.txt:
http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
http/tests/security/xssAuditor/script-tag-entities-expected.txt:
http/tests/security/xssAuditor/script-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-post-expected.txt:
http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
http/tests/security/xssAuditor/svg-script-tag-expected.txt:
http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:

2:11 AM Changeset in webkit [145502] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Unreviewed, rolling out r145494.
http://trac.webkit.org/changeset/145494
https://bugs.webkit.org/show_bug.cgi?id=112117

Breaks Chromium Mac (Requested by pfeldman on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-12

bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

2:00 AM Changeset in webkit [145501] by yurys@chromium.org

3 edits in trunk/Source/WebCore

Web Inspector: add memory instrumentation for ImageLoader
https://bugs.webkit.org/show_bug.cgi?id=112115

Reviewed by Alexander Pavlov.

Added memory instrumentation to ImageLoader. CachedImage referenced
by the loader is reported as having retaining reference. This allows
to see in the native memory graph CachedImages that are not reachable
from MemoryCache but referenced by HTMLImageElement.

loader/ImageLoader.cpp:

(WebCore::ImageLoader::reportMemoryUsage):
(WebCore):

loader/ImageLoader.h:

(ImageLoader):

1:53 AM Changeset in webkit [145500] by Csaba Osztrogonác

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r145482): It broke 33 jsc tests and zillion layout tests on all platform
https://bugs.webkit.org/show_bug.cgi?id=112112

Reviewed by Oliver Hunt.

Rolling out https://trac.webkit.org/changeset/145482 to unbreak the bots.

runtime/JSStringJoiner.cpp:

(JSC::JSStringJoiner::build):

runtime/JSStringJoiner.h:

(JSStringJoiner):
(JSC::JSStringJoiner::JSStringJoiner):
(JSC::JSStringJoiner::append):

1:43 AM Changeset in webkit [145499] by vsevik@chromium.org

2 edits in trunk/Source/WebCore

Web Inspector: Broken shortcuts in Snippets SourceFrame
https://bugs.webkit.org/show_bug.cgi?id=112038

Reviewed by Pavel Feldman.

inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame):
(WebInspector.SnippetJavaScriptSourceFrame.prototype._onKeyDown):

1:25 AM Changeset in webkit [145498] by vsevik@chromium.org

3 edits in trunk/LayoutTests

Web Inspector: Several inspector tests are flaky beacuse of beforeonload event handler.
https://bugs.webkit.org/show_bug.cgi?id=112111

Reviewed by Alexander Pavlov.

Added removeEventListener call.
Beforeunload message was updated so that it is possible to find it's source from it.

inspector-protocol/page/javascriptDialogEvents-expected.txt:
inspector-protocol/page/javascriptDialogEvents.html:

1:07 AM Changeset in webkit [145497] by zandobersek@gmail.com

3 edits in trunk/LayoutTests

Unreviewed GTK gardening.

platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r145397 and r145474.
platform/gtk/fast/js/global-constructors-expected.txt: Rebaselining after r145400.

12:59 AM Changeset in webkit [145496] by eustas@chromium.org

4 edits in trunk/Source/WebCore

Web Inspector: [Timeline] File selector control becomes visible on "tab" navigation.
https://bugs.webkit.org/show_bug.cgi?id=111710

Reviewed by Pavel Feldman.

Solution: Exclude file selector control from tab-navigation flow.

inspector/front-end/FileUtils.js: Set tab-index to control.
inspector/front-end/TimelinePanel.js: Remove duplicating code.
inspector/front-end/inspector.css:

(.status-bar-item): Make scroll height equal to offset height.

12:52 AM Changeset in webkit [145495] by eustas@chromium.org

6 edits in branches/chromium/1410/Source/WebCore

Revert 142161 "Web Inspector: CPU pegged when inspecting LocalSt..."

Web Inspector: CPU pegged when inspecting LocalStorage that mutates.
https://bugs.webkit.org/show_bug.cgi?id=107937

Reviewed by Yury Semikhatsky.

The DOM storage agent will fire an event to the frontend based on the action
performed on the storage. Based on this action, the front-end will just add/update/remove
the entry in the view. This enhances the front-end responsiveness as the round trip
for fetching the storage entries has been eliminated.

Existing test: LayoutTests/inspector/storage-panel-dom-storage-update.html should verify the change

inspector/Inspector.json:
inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):

inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemsCleared):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemRemoved):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemAdded):
(WebInspector.DOMStorageDispatcher.prototype.domStorageItemUpdated):

inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView):
(WebInspector.DOMStorageItemsView.prototype.wasShown):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemAdded):
(WebInspector.DOMStorageItemsView.prototype._domStorageItemUpdated):
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._refreshButtonClicked):
(WebInspector.DOMStorageItemsView.prototype._editingCallback):
(WebInspector.DOMStorageItemsView.prototype._deleteCallback):

inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._showDOMStorage.get if):
(WebInspector.ResourcesPanel.prototype._showDOMStorage):

TBR=vivek.vg@samsung.com
Review URL: https://codereview.chromium.org/12700007

12:52 AM Changeset in webkit [145494] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[V8] Get rid of function-level static FunctionTemplates in generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=111971

Patch by Marja Hölttä <marja@chromium.org> on 2013-03-12
Reviewed by Kentaro Hara.

No new tests (updated the bindings test expectations).

bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):

bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::postMessageAttrGetter):

bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):
(WebCore::V8PerIsolateData::privateTemplate):
(WebCore):

bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAttrGetterCustom):
(WebCore::V8Location::replaceAttrGetterCustom):
(WebCore::V8Location::assignAttrGetterCustom):

12:46 AM Changeset in webkit [145493] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Need to notify ScrollingCoordinator when frame scrollbars are destroyed
https://bugs.webkit.org/show_bug.cgi?id=112104

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-12
Reviewed by James Robinson.

Need to notify ScrollingCoordinatorChromium whenever m_layerForHorizontalScrollbar /
m_layerForVerticalScrollbar changes, for correct lifetime management.

No new tests. Difficult to test lifetime management internal to ScrollingCoordinatorChromium.

rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::destroyRootLayer):

12:34 AM Changeset in webkit [145492] by vsevik@chromium.org

2 edits in trunk/LayoutTests

Unreviewed test flakiness fix.

inspector/debugger/event-listener-breakpoints.html:

12:02 AM Changeset in webkit [145491] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG prediction propagation phase should not rerun forward propagation if double voting has already converged
https://bugs.webkit.org/show_bug.cgi?id=111920

Reviewed by Oliver Hunt.

I don't know why we weren't exiting early after double voting if !m_changed.

This change also removes backwards propagation from the voting fixpoint, since at that
point short-circuiting loops is probably not particularly profitable. Profiling shows
that this reduces the time spent in prediction propagation even further.

This change appears to be a 1% SunSpider speed-up.

dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::run):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed