Timeline
Jun 3, 2013:
- 11:27 PM Changeset in webkit [151157] by
-
- 3 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148820 | mark.lam@apple.com | 2013-04-21 02:04:09 -0700 (Sun, 21 Apr 2013) | 11 lines
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.
https://bugs.webkit.org/show_bug.cgi?id=114910.
------------------------------------------------------------------------
- 11:03 PM Changeset in webkit [151156] by
-
- 2 edits in trunk/Source/WebKit2
Unable to play videos in Safari using QuickTime plug-in until I've played those videos in Chrome first
https://bugs.webkit.org/show_bug.cgi?id=117174
<rdar://problem/13711687>
Patch by Simon Cooper <scooper@apple.com> on 2013-06-03
Reviewed by Alexey Proskuryakov.
Pull in fixes that allow https connections within the plugin
environment.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- 10:37 PM Changeset in webkit [151155] by
-
- 53 edits4 copies1 delete in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148641 | mark.lam@apple.com | 2013-04-17 15:57:33 -0700 (Wed, 17 Apr 2013) | 10 lines
Fix broken build. Replaced a static const with a #define.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148655 | mark.lam@apple.com | 2013-04-17 20:17:44 -0700 (Wed, 17 Apr 2013) | 10 lines
Avoid using a branch range that is too far for some CPU architectures.
https://bugs.webkit.org/show_bug.cgi?id=114782.
------------------------------------------------------------------------
r148709 | mark.lam@apple.com | 2013-04-18 15:45:25 -0700 (Thu, 18 Apr 2013) | 11 lines
Interpreter entry points should throw the TerminatedExecutionException from the caller frame.
https://bugs.webkit.org/show_bug.cgi?id=114816.
------------------------------------------------------------------------
r148893 | mark.lam@apple.com | 2013-04-22 10:37:29 -0700 (Mon, 22 Apr 2013) | 30 lines
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.
https://bugs.webkit.org/show_bug.cgi?id=114963.
------------------------------------------------------------------------
r148899 | mark.lam@apple.com | 2013-04-22 11:40:58 -0700 (Mon, 22 Apr 2013) | 20 lines
Fix broken 32-bit build to green the bots.
https://bugs.webkit.org/show_bug.cgi?id=114968.
------------------------------------------------------------------------
r148942 | mark.lam@apple.com | 2013-04-22 21:47:08 -0700 (Mon, 22 Apr 2013) | 11 lines
Fix a typo in MacroAssemblerARMv7.h.
https://bugs.webkit.org/show_bug.cgi?id=115011.
------------------------------------------------------------------------
r148989 | mark.lam@apple.com | 2013-04-23 13:54:34 -0700 (Tue, 23 Apr 2013) | 21 lines
Simplify the baseline JIT loop hint call site.
https://bugs.webkit.org/show_bug.cgi?id=115052.
------------------------------------------------------------------------
r149089 | mark.lam@apple.com | 2013-04-24 19:59:51 -0700 (Wed, 24 Apr 2013) | 40 lines
Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.
------------------------------------------------------------------------
r149420 | mark.lam@apple.com | 2013-04-30 19:38:19 -0700 (Tue, 30 Apr 2013) | 17 lines
JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
VM watchdog if its client did not pass one in.
https://bugs.webkit.org/show_bug.cgi?id=115461.
------------------------------------------------------------------------
r150449 | mark.lam@apple.com | 2013-05-21 09:44:01 -0700 (Tue, 21 May 2013) | 8 lines
Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.
------------------------------------------------------------------------
Source/WebCore: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Added currentCPUTime() and currentCPUTimeMS().
https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
- 10:09 PM Changeset in webkit [151154] by
-
- 2 edits in trunk/Source/WebCore
Remove unused arithmetic operation in RenderListItem
https://bugs.webkit.org/show_bug.cgi?id=117175
Reviewed by Brent Fulgham.
Variable 'markerLogicalLeft' is reassigned a value before the old one has been used.
- rendering/RenderListItem.cpp:
(WebCore::RenderListItem::positionListMarker):
- 10:01 PM Changeset in webkit [151153] by
-
- 2 edits in trunk/Tools
validate-committer-lists script is now outdated and does not work
https://bugs.webkit.org/show_bug.cgi?id=115860
Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-03
Reviewed by Brent Fulgham.
The script validate-committer-lists was outdated, still using the deprecated log
system and having the old addresses for the mailing lists, as well as still referring
to committers.py, after this was renamed to contributors.json. This patch fixes that
so it can be used again.
- Scripts/validate-committer-lists: Replace calls to log and error with the
new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
to committers.py, which should be contributors.json.
(CommitterListFromMailingList):
(CommitterListFromMailingList.check_for_emails_missing_from_list):
(CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
(CommitterListFromGit._fill_in_emails_for_old_logins):
(CommitterListFromGit.print_committers_missing_from_committer_list):
- 9:51 PM Changeset in webkit [151152] by
-
- 1 edit1 add in trunk/Tools
add a script to dump the tests run most recently by a given worker
https://bugs.webkit.org/show_bug.cgi?id=116571
Reviewed by Brent Fulgham.
The tests_run*.txt results files in layout-test-results/ were removed
in r137356, in favor of collecting more data about how the tests were
run and compressing it and storing it in stats.json. However, it was
nice to just be able to look at a flat text file.
This script will extract the tests run by a given worker from a
given stats.json file, and should help to address that.
- Scripts/dump-webkit-tests-run: Added.
(main):
(convert_trie_to_flat_paths):
- 9:02 PM Changeset in webkit [151151] by
-
- 10 edits in trunk/Tools
[Windows] NRWT is not putting crash logs in proper place
https://bugs.webkit.org/show_bug.cgi?id=117098
Reviewed by Ryosuke Niwa.
Provide windows-specific overloads for various Port features needed to create and capture
crash logs. This change makes it possible to view crash logs (when created) as part of the
summary report at the end of the NRWT run.
- Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs.find_newest_log): Add support for win32 crash logs
(CrashLogs._find_newest_log_win): Added
- Scripts/webkitpy/common/system/crashlogs_unittest.py:
(make_mock_crash_report_win): Added
(CrashLogsTest.test_find_log_win): Added.
- Scripts/webkitpy/common/system/executive.py:
(Executive.running_pids): Add support for Cygwin win32 crash logs
- Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.init):
- Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_file): Add tests for
malformed ascii/utf8 handling (i.e., Windows log files)
- Scripts/webkitpy/port/base.py:
(Port.find_system_pid): Added
- Scripts/webkitpy/port/server_process.py:
(ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
- Scripts/webkitpy/port/win.py:
(WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
for user to hit enter.
(WinPort._get_crash_log): Added
(WinPort.look_for_new_crash_logs): Added
(WinPort.find_system_pid): Added
- Scripts/webkitpy/port/win_unittest.py:
(WinPortTest.test_get_crash_log): Added test
- 9:00 PM Changeset in webkit [151150] by
-
- 44 edits2 deletes in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
------------------------------------------------------------------------
r148119 | ggaren@apple.com | 2013-04-10 11:51:47 -0700 (Wed, 10 Apr 2013) | 106 lines
Removed bitrotted TimeoutChecker code
Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/blackberry:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/mac:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit/qt:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
Source/WebKit2:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------
- 8:20 PM Changeset in webkit [151149] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
[EFL] Implement GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=95923
Patch by Hojong Han <hojong.han@samsung.com> on 2013-06-03
Reviewed by Geoffrey Garen.
Implements the activity triggered garbage collector.
Additional GCs can be triggered by platfrom timer.
It has sort of compaction effect not to make JSC heap grow fast
so that memory usage becomes lower than usual.
- PlatformEfl.cmake: Added.
- heap/HeapTimer.cpp:
(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::add):
(JSC::HeapTimer::stop):
(JSC::HeapTimer::timerEvent):
- heap/HeapTimer.h:
(HeapTimer):
- jsc.cpp:
(main):
- runtime/GCActivityCallback.cpp:
(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):
- runtime/GCActivityCallback.h:
(GCActivityCallback):
(JSC::GCActivityCallback::GCActivityCallback):
(DefaultGCActivityCallback):
- 7:57 PM Changeset in webkit [151148] by
-
- 20 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r147858 | oliver@apple.com | 2013-04-06 15:47:56 -0700 (Sat, 06 Apr 2013) | 62 lines
Unify the many and varied stack trace mechanisms, and make the result sane.
Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=114072
Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=114072
Tools:
https://bugs.webkit.org/show_bug.cgi?id=114072
- 6:44 PM Changeset in webkit [151147] by
-
- 6 edits2 moves in trunk
Unreviewed. Some AppleWin VS2010 house cleaning.
- WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
- WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
- win/tools32/scripts/auto-version.sh: Replaced with win/tools32/scripts/auto-version2010.sh.
- win/tools32/scripts/auto-version2010.sh: Removed.
- win/tools32/scripts/feature-defines.sh: Replaced with win/tools32/scripts/feature-defines2010.sh.
- win/tools32/scripts/feature-defines2010.sh: Removed.
- WebCore.vcxproj/build-generated-files.sh:
- 6:16 PM Changeset in webkit [151146] by
-
- 9 edits1 add in trunk
clearLayoutOverflow should never be called before calling layer()->updateScrollInfoAfterLayout().
https://bugs.webkit.org/show_bug.cgi?id=116689.
Reviewed by Ojan Vafai.
Make sure that clearLayoutOverflow only gets called after layer()->updateScrollInfoAfterLayout().
Also move clearLayoutOverflow to RenderBlock so we can keep all the delayed scroll update logic together.
Test: fast/flexbox/clear-overflow-before-scroll-update.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layout): Remove call to clearLayoutOverflow.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo): Add call to clearLayoutOverflow.
(WebCore::RenderBlock::updateScrollInfoAfterLayout): Ditto.
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderBox.cpp:
- rendering/RenderBox.h:
(WebCore::RenderBox::layoutOverflowRect): Remove from layoutOverflowRect.
(RenderBox):
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock): This should call updateScrollInfoAfterLayout() intead of directly calling layer()->updateScrollInfoAfterLayout().
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Ditto.
- 6:09 PM Changeset in webkit [151145] by
-
- 5 edits in trunk
[EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=116726
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
.:
Bump required version of ATK to 2.8.0 in EFL CMake's build.
- Source/cmake/FindATK.cmake: Adds macro to check required version
- Source/cmake/OptionsEfl.cmake: Specifies required version of ATK to be 2.8.0
Tools:
Current version of ATK in efl-ews environment is 2.4.0 and is taken from
the platform (it is not listed in jhbuild moduleset). That version is
old-ish and contain deprecated symbols and missing API, that are blocking
patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
moduleset, which is the same version the gtk port uses.
See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
why this is needed.
- efl/jhbuild.modules: Adds ATK module as dependency
- 5:11 PM Changeset in webkit [151144] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: all cached put_by_id transitions, even ones that weren't inlined by the DFG, should be propagated by the GC
https://bugs.webkit.org/show_bug.cgi?id=117170
Reviewed by Mark Hahnenberg.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::propagateTransitions):
(JSC):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/CodeBlock.h:
(CodeBlock):
- bytecode/PolymorphicPutByIdList.h:
(JSC):
(PutByIdAccess):
(PolymorphicPutByIdList):
- bytecode/StructureStubInfo.h:
(StructureStubInfo):
- jit/JITCode.h:
(JSC::JITCode::couldBeInterpreted):
(JITCode):
- 4:42 PM Changeset in webkit [151143] by
-
- 15 edits in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
r146505 | mark.lam@apple.com | 2013-03-21 13:06:26 -0700 (Thu, 21 Mar 2013) | 21 lines
Fix lexer charPosition computation when "rewind"ing the lexer.
https://bugs.webkit.org/show_bug.cgi?id=112952.
r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Fix O(n2) op_debug bytecode charPosition to column computation.
https://bugs.webkit.org/show_bug.cgi?id=112957.
Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk
r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Introducing String::findNextLineStart().
https://bugs.webkit.org/show_bug.cgi?id=112957.
- 3:52 PM Changeset in webkit [151142] by
-
- 2 edits in tags/Safari-537.43.57/Source/WebKit2
Merged r151035. <rdar://problem/14050413>
- 3:47 PM Changeset in webkit [151141] by
-
- 2 edits in trunk/Source/WebCore
[harfbuzz] WebKit fails to build with MinGW compiler because of invalid cast in HarfBuzzShaper.cpp
https://bugs.webkit.org/show_bug.cgi?id=108373
Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-06-03
Reviewed by Darin Adler.
Fix building on platforms where UChar is defined as wchar_t.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):
- 3:45 PM Changeset in webkit [151140] by
-
- 33 edits2 adds in trunk
REGRESSION: Undoing autocorrection doesn't prevent a future autocorrection
https://bugs.webkit.org/show_bug.cgi?id=117165
Reviewed by Darin Adler.
Source/WebCore:
The bug was caused by SpellingCorrectionCommand returning true in callsAppliedEditingInDoApply, which prevented
the command from being registered to the undo manager. This behavior was introduced in r148306 because TypingCommand
registeres itself to the undo manager in appliedEditing.
Fixed the bug by reverting both r122176 and r148306 and implementing a better fix for the bug 90487.
Instead of using InsertTextCommand, simply don't specify ReplaceSelectionCommand::PreventNesting so that the command
doesn't try to break out of a blockquote.
Also fix a bug in ReplaceSelectionCommand::completeHTMLReplacement uncovered by this change. We were only merging
text nodes at the beginning of the replaced content but not at the end. Call mergeTextNodesAroundPosition for the
second time to fix whitespace at the end of the replaced content.
Test: platform/mac/editing/spelling/autocorrection-respets-undo.html
- editing/CompositeEditCommand.cpp: Explictily check isTypingCommand now that callsAppliedEditingInDoApply has been
removed from SpellingCorrectionCommand and TypingCommand and SpellingCorrectionCommand were only classes that
returned true in callsAppliedEditingInDoApply. See r148306 that introduced this function.
(WebCore::CompositeEditCommand::apply):
- editing/CompositeEditCommand.h: Removed callsAppliedEditingInDoApply.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
- editing/SpellingCorrectionCommand.cpp: Removed callsAppliedEditingInDoApply, which was the culprit of this bug,
so that CompositeEditCommand::apply correctly registers this command with the undo manager.
(WebCore::SpellingCorrectionCommand::doApply): Use ReplaceSelectionCommand instead of TypingCommand as noted above.
- editing/SpellingCorrectionCommand.h:
- editing/TypingCommand.cpp: Deleted callsAppliedEditingInDoApply.
- editing/TypingCommand.h:
LayoutTests:
Add a regression test and rebaseline other tests as ReplaceSelectionCommand now merges text nodes at
the end of replaced text.
- editing/deleting/merge-paragraph-from-address-expected.txt:
- editing/deleting/merge-paragraph-from-h6-expected.txt:
- editing/deleting/merge-paragraph-from-listing-expected.txt:
- editing/deleting/paste-with-transparent-background-color-expected.txt:
- editing/inserting/insert-3907422-fix-expected.txt:
- editing/pasteboard/copy-image-with-alt-text-expected.txt:
- editing/pasteboard/merge-end-4-expected.txt:
- editing/pasteboard/nested-blocks-with-text-area-expected.txt:
- editing/pasteboard/nested-blocks-with-text-field-expected.txt:
- editing/pasteboard/paste-text-001-expected.txt:
- editing/pasteboard/paste-unrendered-select-expected.txt:
- editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
- platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
- platform/mac/editing/pasteboard/4944770-2-expected.txt:
- platform/mac/editing/pasteboard/8145-2-expected.txt:
- platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
- platform/mac/editing/pasteboard/paste-text-008-expected.txt:
- platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
- platform/mac/editing/pasteboard/paste-xml-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
- platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added more asssertions to ensure that
the autocorrected text is in the blockquote. r122176 modified the test description saying that this test
already checks this condition but it never did so explicitly; it assumed that the autocorrected text was
inside a blockquote as long as it started at a certain offset in the text node.
- platform/mac/editing/spelling/autocorrection-respets-undo-expected.txt: Added.
- platform/mac/editing/spelling/autocorrection-respets-undo.html: Added.
- platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt:
- 3:32 PM Changeset in webkit [151139] by
-
- 4 edits in tags/Safari-537.43.57/Source
Versioning.
- 3:29 PM Changeset in webkit [151138] by
-
- 2 edits in trunk/Source/WebCore
Reduce indentation in Widget::paint in WidgetMac.mm
https://bugs.webkit.org/show_bug.cgi?id=117171
Reviewed by Darin Adler.
Use an early return for the common case to reduce indentation in the complex case.
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 3:29 PM Changeset in webkit [151137] by
-
- 1 copy in tags/Safari-537.43.57
New Tag.
- 3:28 PM Changeset in webkit [151136] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/migrate-scripts.sh:
- 3:25 PM Changeset in webkit [151135] by
-
- 3 edits in trunk/Tools
[GTK] Respect PKG_CONFIG env variable when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=117168
Patch by Erik van Pienbroek <epienbro@fedoraproject.org> on 2013-06-03
Reviewed by Martin Robinson.
The tool generate-gtkdoc internally calls pkg-config.
When cross-compiling it shouldn't use pkg-config, but
it should use the pkg-config which was detected by
the ./configure script (for example this can be
i686-w64-mingw32-pkg-config when cross-compiling)
- GNUmakefile.am:
- gtk/gtkdoc.py:
(PkgConfigGTKDoc.init):
- 3:23 PM Changeset in webkit [151134] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix.
- TestWebKitAPI/win/main.cpp: Embed proper manifest information to
allow VS2010 builds to use VS2005 runtime libraries as needed.
- 3:13 PM Changeset in webkit [151133] by
-
- 7 edits98 deletes in trunk
Nuke VS2005 files from the tree.
<rdar://problem/14042021>.
Rubberstamped by Brent Fulgham.
- 3:06 PM Changeset in webkit [151132] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] REGRESSION(r150798): scrolling coordinator is not being enabled when WebPage is set to use fixed layout
https://bugs.webkit.org/show_bug.cgi?id=117163
Reviewed by Darin Adler.
Moved call to WebPage::settings()->setScrollingCoordinatorEnabled()
from CoordinatedLayerTreeHost constructor to WebPage::setUseFixedLayout().
The scrolling coordinator must be enabled or disabled following the
WebPage's use of fixed layout.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUseFixedLayout):
- 2:51 PM Changeset in webkit [151131] by
-
- 7 edits in trunk
AX: WebKit should join substrings on single space when concatenating the accessible name of an element
https://bugs.webkit.org/show_bug.cgi?id=117100
Reviewed by Darin Adler.
Source/WebCore:
When concatenating text from underneath an element append spaces between objects and trim whitespace.
Modified existing tests reflect the new behavior.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement):
LayoutTests:
- accessibility/text-role-with-aria-hidden-inside-expected.txt:
- accessibility/text-role-with-aria-hidden-inside.html:
- platform/mac/accessibility/internal-link-anchors2-expected.txt:
- platform/mac/accessibility/table-with-aria-role-expected.txt:
- 2:49 PM Changeset in webkit [151130] by
-
- 2 edits in branches/dfgFourthTier/LayoutTests
Unreviewed, unbreak all of the tests.
Printing "Some tests failed" is great for the silentTestPass mode, but breaks all previous
expected-to-fail tests. Changed it so we only print this helpful message if we're in
silentTestPass mode.
- fast/js/resources/js-test-pre.js:
(isSuccessfullyParsed):
- 2:47 PM Changeset in webkit [151129] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
https://bugs.webkit.org/show_bug.cgi?id=117167
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.
Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):
- Api/WebPage.h:
- 2:41 PM Changeset in webkit [151128] by
-
- 5 edits in branches/dfgFourthTier
Merged from http://svn.webkit.org/repository/webkit/trunk
r147798 | fpizlo@apple.com | 2013-04-05 14:34:15 -0700 (Fri, 05 Apr 2013) | 14 lines
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid
CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should
be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062
- 2:23 PM Changeset in webkit [151127] by
-
- 5 edits3 copies in branches/dfgFourthTier
Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk
r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
r147690 | Christophe Dumez | 2013-04-04 17:44:28 -0700 (Thu, 04 Apr 2013) | 7 lines
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
LayoutTests: Merged from http://svn.webkit.org/repository/webkit/trunk
r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952
- 2:03 PM Changeset in webkit [151126] by
-
- 5 edits in trunk/Source/WebCore
Remove XMLMIMETypeRegExp
https://bugs.webkit.org/show_bug.cgi?id=116861
Reviewed by Alexey Proskuryakov.
Remove the XMLMIMETypeRegExp class. It contained a regular expression that was used
for checking for valid XML MIME types in DOMImplementation::isXMLMIMEType. The thread-global
instance was stored in ThreadGlobalData.
The class is removed, with DOMImplementation::isXMLMIMEType now testing that the given MIME type
is of proper form and contains only valid characters.
No new tests - no change in functionality.
- dom/DOMImplementation.cpp:
(WebCore::isValidXMLMIMETypeChar): A helper method that returns true only for characters that
are acceptable in a valid XML MIME type (apart from the forward slash).
(WebCore::DOMImplementation::isXMLMIMEType): Instead of using a regular expression, determine
whether the given string is a valid non-standard XML mime type by checking for the '+xml' ending,
proper forward slash position, and that no invalid characters are used in the string.
- dom/DOMImplementation.h:
- platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData): The OwnPtr<XMLMIMETypeRegExp> member variable is being removed.
(WebCore::ThreadGlobalData::destroy): Ditto.
- platform/ThreadGlobalData.h:
(WebCore): No need for the XMLMIMETypeRegExp forward declaration.
(ThreadGlobalData): Remove the OwnPtr<XMLMIMETypeRegExp> member variable.
- 1:52 PM Changeset in webkit [151125] by
-
- 7 edits in trunk
[GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Martin Robinson.
Source/WebCore:
Replace pango API for drawing underline error on misspelled words, in favor of
drawErrorUnderline() method, removing the platform #ifdef check. As this was the
only usage of Pango in GraphicsContextCairo, it no longer includes pango.h.
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLineForDocumentMarker): Removes
pango_cairo_show_error_underline() in favor of drawErrorUnderline().
- platform/graphics/cairo/DrawErrorUnderline.h:
(drawErrorUnderline): Fills the cairo path at the end of the drawing.
LayoutTests:
Update PNG expectations for some spell checking tests to pass pixel hash comparison.
The images are not visually modified.
- platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Rebaseline
image to pass pixel hash
- platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Rebasline
image to pass pixel hash
- platform/gtk/editing/spelling/spelling-expected.png: Rebasline
image to pass pixel hash
- 12:41 PM Changeset in webkit [151124] by
-
- 8 edits in trunk/Tools
AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069
Reviewed by Tim Horton.
Add methods to help output components of math multiscripts for accessibility.
- DumpRenderTree/AccessibilityUIElement.cpp:
(mathPostscriptsDescriptionCallback):
(mathPrescriptsDescriptionCallback):
(AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h:
(AccessibilityUIElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(convertMathMultiscriptPairsToString):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(AccessibilityUIElement):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
(WTR::_convertMathMultiscriptPairsToString):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
- 12:35 PM Changeset in webkit [151123] by
-
- 10 edits2 adds in trunk
AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069
Reviewed by Tim Horton.
Source/WebCore:
Math multiscript tags allow for an arbitrary number of prescripts and postscripts
around a base object.
This MathML tag currently is not supported in the render tree, but that doesn't need to
stop it from being exposed through accessibility, as a base object with an array of postscripts
and an array of prescripts.
Test: platform/mac/accessibility/mathml-multiscript.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isMathMultiscript):
(AccessibilityObject):
(WebCore::AccessibilityObject::mathPrescripts):
(WebCore::AccessibilityObject::mathPostscripts):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isMathMultiscript):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathPrescripts):
(WebCore::AccessibilityRenderObject::mathPostscripts):
- accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityMathPostscripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathPrescripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):
- accessibility/mac/WebAccessibilityObjectWrapperBase.h:
- accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPostscriptPairs]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPrescriptPairs]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
- mathml/mathtags.in:
LayoutTests:
- platform/mac/accessibility/mathml-multiscript-expected.txt: Added.
- platform/mac/accessibility/mathml-multiscript.html: Added.
- 12:19 PM Changeset in webkit [151122] by
-
- 5 edits2 adds in trunk/LayoutTests
[Layout Tests] Update testharness scripts, add WebIDLParser.js and idlharness.js
https://bugs.webkit.org/show_bug.cgi?id=116983
Reviewed by Sam Weinig.
Update the testharness scripts that are used by the W3C tests that are located under LayoutTests/http/tests/w3c. Also add the
WebIDLParser.js and idlharness.js scripts that will be used by tests imported in the future. The files are being updated or impoted
off the 06cab30bcee2 changeset in the http://w3c-test.org/resources repository.
No test is affected by this update, though some tests will require rebaselining due to the baselines containing stack traces of which
line numbers will change due to the updated scripts.
- http/tests/w3c/README: List the currently-imported directories, noting from where they originate, at which changeset were
they imported and what files can or should be modified. Also note what script should be used to import/update the files, if available.
- http/tests/w3c/resources/WebIDLParser.js: Added. Will be used by future tests imported from the W3C test suites.
- http/tests/w3c/resources/idlharness.js: Ditto.
- http/tests/w3c/resources/testharness.css: Updated.
- http/tests/w3c/resources/testharness.js: Updated.
- http/tests/w3c/resources/testharnessreport.js: Updated. Removed the default completion callback and readded
the completion callback that was in use until now.
- 11:33 AM Changeset in webkit [151121] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035
Forced relayout to ensure the hover event has propagated before checking the results.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Alexandru Chiculita.
- fast/regions/hover-on-child-parent-different-regions.html:
- 11:31 AM Changeset in webkit [151120] by
-
- 1 edit in trunk/Source/WebKit2/ChangeLog
Add radar number to ChangeLog.
- 11:30 AM Changeset in webkit [151119] by
-
- 3 edits in trunk/Source/WebKit2
Send mouse events to the banner for as long as the mouse button is down
https://bugs.webkit.org/show_bug.cgi?id=117161
Reviewed by Beth Dakin.
Keep track of whether the mouse was pressed in a banner and keep sending mouse events to it,
even if they are outside the banner's bounds for as long as the mouse is down.
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::mouseEvent):
- 10:57 AM Changeset in webkit [151118] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Selection handles are not cleared when displaying error pages.
https://bugs.webkit.org/show_bug.cgi?id=117158
Reviewed by Carlos Garcia Campos.
PR 342159.
Add explicit cancel of selection state when loading an error page
as it is not always cleared.
Internally Reviewed by Nima Ghanavatian.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
- 10:31 AM Changeset in webkit [151117] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: node->parentNode(), Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
https://bugs.webkit.org/show_bug.cgi?id=117155
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by David Hyatt.
Source/WebCore:
Ported from a Blink patch by kenrb@chromium.org:
Clear floats on RenderBlocks that haven't had layout
WebKit revision 150084 creates a condition where a RenderBlock
can have a populated floating object list even when it has not
previously had layout. Since clearing of floats is optimized
to not search through parts of the tree that have not had layout,
references to floating objects were not being cleared in some cases.
This patch causes markAllDescendantsWithFloatsForLayout() to proceed
in the above case, in order to clear floats for a RenderBlock that has
not had layout.
Test: fast/block/float/float-list-changed-before-layout-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
LayoutTests:
Test for crash. Note that this will only crash when run under a memory
checking tool like ASAN.
- fast/block/float/float-list-changed-before-layout-crash-expected.txt: Added.
- fast/block/float/float-list-changed-before-layout-crash.html: Added.
- 10:21 AM Changeset in webkit [151116] by
-
- 4 edits6 adds in trunk
[CSS Shapes] inset-rectangle support for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=116641
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by Alexandru Chiculita.
Source/WebCore:
Implement support for using inset-rectangles in a shape-outside.
Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html
fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape): An inset-rectangle is
simply a rectangle with the dimensions calculated differently. So
just use ExclusionRectangle after converting the dimensions.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable inset
rectangles for shape-outside.
LayoutTests:
Add tests for inset-rectangles.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
- fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
- 10:17 AM Changeset in webkit [151115] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] ROI details are not always cleared when using back navigation.
https://bugs.webkit.org/show_bug.cgi?id=117159
Reviewed by Carlos Garcia Campos.
PR 328557.
Secondary change to ensure when restoreViewState is triggered
ROI is reset.
Internally Reviewed by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
- 8:45 AM Changeset in webkit [151114] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Slider UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117148
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-03
Reviewed by Rob Buis.
BlackBerry PR 342328
Internally Reviewed by Jeff Rogers.
Change image and reduce handle size when it is disabled.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- 7:45 AM Changeset in webkit [151113] by
-
- 2 edits17 adds in trunk/LayoutTests
[Qt] [WK2] Unreviewed gardening. Unskipping passing tests and generate new test expectations where needed.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-03
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.png: Added.
- platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.txt: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.png: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.txt: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.png: Added.
- platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
- platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
- 7:26 AM Changeset in webkit [151112] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112031
Unreviewed EFL gardening.
accessibility/placeholder.html passes after r151103.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
- platform/efl-wk2/TestExpectations:
- 6:58 AM Changeset in webkit [151111] by
-
- 11 edits in trunk
Unreviewed, rolling out r151109.
http://trac.webkit.org/changeset/151109
https://bugs.webkit.org/show_bug.cgi?id=117145
"Plugins in WK2 aren't implemented yet." (Requested by
jturcotte on #webkit).
Source/WebCore:
- platform/FileSystem.h:
- platform/qt/FileSystemQt.cpp:
(WebCore::unloadModule):
- plugins/mac/PluginPackageMac.cpp:
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/mac/PluginViewMac.mm:
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowResizerRect):
Tools:
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 6:37 AM Changeset in webkit [151110] by
-
- 3 edits4 adds in trunk
REGRESSION (r143070): Overflow:scroll content does not get clipped properly when the parent box has CSS3 filter on.
https://bugs.webkit.org/show_bug.cgi?id=116859
Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-03
Reviewed by Simon Fraser.
Apply proper clipping for overflow:scroll, when parent dictates
full repaint to ensure correct CSS3 filter effect.
When a particular layer has 'pixel moving' CSS3 filter(drop shadow, blur), it sets clipToDirtyRect
to false to force no clipping on itself and on the child layers too.
No clipping makes overflow:scroll behave like overflow:display, because
overflow::scroll gets clipped at RenderLayer level (as opposed to overflow::hidden).
This patch makes sure that both full repaint and clipping are ensured.
Source/WebCore:
Tests: css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html
css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
LayoutTests:
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-expected.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent-expected.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html: Added.
- css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html: Added.
- 6:13 AM Changeset in webkit [151109] by
-
- 11 edits in trunk
[Qt] Re-enable plugins on Mac.
https://bugs.webkit.org/show_bug.cgi?id=116622
Reviewed by Tor Arne Vestbø.
Source/WebCore:
- platform/FileSystem.h:
- platform/qt/FileSystemQt.cpp:
(WebCore::unloadModule):
- Q_WS_* aren't defined since Qt5, use Q_OS_MACX instead.
- plugins/mac/PluginPackageMac.cpp:
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- createCFString now does the adoption itself.
- plugins/mac/PluginViewMac.mm:
- Add missing include.
Source/WebKit/qt:
- WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::windowResizerRect):
- Add missing parenthese.
Tools:
Plugins on Mac were only enabled if !embedded but the later was set if
QPA is enabled, which is the default since Qt 5.0.
Remove references to 'embedded' and fix various build issues,
PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
months.
- DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
- qmake/mkspecs/features/features.prf:
- qmake/mkspecs/features/unix/default_pre.prf:
- 6:12 AM Changeset in webkit [151108] by
-
- 2 edits in trunk/LayoutTests
[EFL] Remove obsolete test case from TestExpectations
Unreviewed EFL gardening.
xmlviewer/extensions-api.html case has been removed since r151080.
- platform/efl/TestExpectations:
- 6:12 AM Changeset in webkit [151107] by
-
- 4 edits in trunk/Source/WebCore
[Qt][Mac] Allow drawing plugins with QWindow by always using an intermediate bitmap.
https://bugs.webkit.org/show_bug.cgi?id=116620
Reviewed by Tor Arne Vestbø.
The isolation of QWidget along with QPA in Qt5 is abstracting away the native CGContext
of a QWidget and we would need to create a non-public API to be able to achieve it.
Instead of adding complexity to this rarely touched code, always draw into an
intermediate bitmap that we then paint into our QPainter afterward.
- Use CGBitmapContextCreate to allocate a buffer directly instead of creating a QPixmap and extract an CGContextRef out of it.
- Get rid of the "if (platformPluginWidget())" code path since we don't paint directly into the QWidget's backing store anymore.
- Always use m_contextRef to draw the plugin instead of alternating between direct and indirect drawing.
- plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.mm:
(WebCore::createBitmapContext):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):
- 6:12 AM Changeset in webkit [151106] by
-
- 4 edits in trunk/Source/WebCore
[Qt][Mac] Remove Carbon and QuickDraw support for plugins.
https://bugs.webkit.org/show_bug.cgi?id=116619
Reviewed by Tor Arne Vestbø.
They are only enabled for 32bit builds of QtWebKit and are rarely tested.
Other browsers support them through a 32bit host process.
PluginViewMac.mm is only used by Qt since the Wx port was removed.
- Only support the Cocoa event model
- Only support the CoreGraphics drawing model
- Remove all NP_NO_CARBON and NP_NO_QUICKDRAW blocks in PluginViewMac.mm
- plugins/PluginView.cpp:
(WebCore::PluginView::setValue):
(WebCore::PluginView::PluginView):
- plugins/PluginView.h:
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleKeyboardEvent):
- 6:07 AM Changeset in webkit [151105] by
-
- 4 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Unskip after r151104.
- platform/qt-5.0-wk2/TestExpectations:
- platform/qt/TestExpectations: Skip crashing test.
- 5:52 AM Changeset in webkit [151104] by
-
- 3 edits in trunk/LayoutTests
[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035
Used waitUntilDone() to ensure correct results.
Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Antti Koivisto.
- fast/regions/hover-on-child-parent-different-regions-expected.txt:
- fast/regions/hover-on-child-parent-different-regions.html:
- 5:40 AM Changeset in webkit [151103] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106344
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
Tools:
Adds support for retrieving attribute value.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::stringAttributeValue):
LayoutTests:
Unskipping failing test. It's been fixed.
- platform/gtk-wk2/TestExpectations:
- 5:38 AM Changeset in webkit [151102] by
-
- 2 edits in trunk/Source/WTF
Unreviewed WinCE build fix after r150833.
- wtf/DateMath.cpp:
(WTF::calculateDSTOffset):
- 4:47 AM Changeset in webkit [151101] by
-
- 4 edits in trunk
'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=117132.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-03
Reviewed by Christophe Dumez.
Source/WebCore:
The listener argument is a PassRefPtr which becomes NULL after the call to
setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener
boolean to be incorrectly initialized. This patch reverses the two statements so
that the m_hasEndedListener is updated before the call to setAttributeEventListener().
No new tests, already covered by existing tests.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::setOnended):
LayoutTests:
Unskip webaudio test cases that were failing due to the 'onended' event not being fired.
- platform/efl/TestExpectations:
- 3:30 AM Changeset in webkit [151100] by
-
- 5 edits in trunk
[EFL]<select> element's text is clipped when a height is specified along with CSS line-height.
https://bugs.webkit.org/show_bug.cgi?id=114862
Patch by Rashmi Kulakarni <rashmi.vijay@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.
Source/WebCore:
Fix <select> element getting clipped when element height becomes less than the line-height.
Set minimum height for <select> element.
No new tests, no behavior change.
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
LayoutTests:
Rebaselined the test case fast/forms/001.html.
- platform/efl/fast/forms/001-expected.png:
- platform/efl/fast/forms/001-expected.txt:
- 1:58 AM Changeset in webkit [151099] by
-
- 5 edits4 adds in trunk
Source/WebCore: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814
Reviewed by Darin Adler.
With the refacor for 112722, which removes MainResourceLoader and moves the functionality to DocumentLoader,
the processing of appcache for main resource error (because of network error) was moved DocumentLoader::
mainReceivedError(), which was trigged by ResourceHandle::didFail->SubResourceLoader::didFail, which already
in a Finishing state after notifying the DocumentLoader of the load failure.
Before patch for 112722, the appcache for main resource error was in MainResourceLoader::didFail(),
which will start processing the potential fallback before notifying DocumentLoader and moving the the state
of the resource loader to finishing state.
So we should move maybeLoadFallbackForMainError out of DocumentLoader::mainReceivedError, and move it to
ApplicationCacheHost::maybeLoadFallbackForError, if the resource that has error is the main resource.
Test: http/tests/appcache/main-resource-fallback-for-network-error-crash.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError):
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):
- loader/appcache/ApplicationCacheHost.h:
LayoutTests: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814
Reviewed by Darin Adler.
- http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt: Added.
- http/tests/appcache/main-resource-fallback-for-network-error-crash.html: Added.
- http/tests/appcache/resources/main-resource-fallback-for-network-error-crash.manifest: Added.
- http/tests/appcache/resources/success-and-notify-done.html: Added.
- 1:34 AM Changeset in webkit [151098] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156
Patch by Sergio Correia <Sergio Correia> on 2013-06-03
Reviewed by Christophe Dumez.
When using WEB_PROCESS_CMD_PREFIX - which allows us for instance to analyze
WebProcess under tools like valgrind or gdb -, the ProcessLauncher would
spawn the new process using system(), which would, among other things, keep
an extra UIProcess waiting and executing the shell.
This patch handles the normal case and the case where we have something to
prefix WebProcess (i.e., by using WEB_PROCESS_CMD_PREFIX in a debug build)
the same way, through a call to execvp().
To achieve this a function was introduced to create an array with the given
arguments to the full command to be executed, to be used by execvp(). We use
a Vector<OwnArrayPtr<char>>, so that we can take advantage of the destructor
of OwnArrayPtr to handle the memory deallocation when it goes out of scope.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
(WebKit::createArgsArray): This function creates the array to be used by
execvp(), out of the Strings given as arguments.
(WebKit::ProcessLauncher::launchProcess): Rework the logic to accomodate
both the cases with and without WEB_PROCESS_CMD_PREFIX. The execl() call
was replaced with an execvp() call, since now we should deal with having
a variable number of arguments (WEB_PROCESS_CMD_PREFIX) as well.
- 1:02 AM Changeset in webkit [151097] by
-
- 5 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline 2 printing test cases on EFL port.
- platform/efl/printing/compositing-layer-printing-expected.png:
- platform/efl/printing/compositing-layer-printing-expected.txt:
- platform/efl/printing/page-rule-in-media-query-expected.png:
- platform/efl/printing/page-rule-in-media-query-expected.txt:
- 12:48 AM Changeset in webkit [151096] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip 2 webaudio tests that are failing due to the onended event not getting
fired.
- platform/efl/TestExpectations:
- 12:44 AM Changeset in webkit [151095] by
-
- 11 edits2 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several test cases on EFL.
- platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
- platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
- platform/efl-wk2/fast/dynamic/002-expected.txt:
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.png:
- platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
- platform/efl/fast/dynamic/002-expected.png:
- platform/efl/fast/table/007-expected.png:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.png:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.png:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- 12:14 AM Changeset in webkit [151094] by
-
- 37 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline several mozilla tables layout tests for EFL port.
- platform/efl/tables/mozilla/bugs/bug13169-expected.png:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.png:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.png:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.png:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug73321-expected.png:
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8858-expected.png:
- platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.png:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.png:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- 12:09 AM Changeset in webkit [151093] by
-
- 2 edits in trunk/Source/WTF
[WTF] Add OwnArrayPtr vectortraits template
https://bugs.webkit.org/show_bug.cgi?id=117131
Reviewed by Darin Adler.
To support Vector<OwnArrayPtr<P>>, which will be used by EFL port.
- wtf/VectorTraits.h:
Jun 2, 2013:
- 10:32 PM Changeset in webkit [151092] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL Gardening.
- platform/efl-wk2/TestExpectations: Unskipping some of webgl passing tests.
- 9:53 PM Changeset in webkit [151091] by
-
- 11 edits2 deletes in trunk/Source
[Qt] Move Qt port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116416
Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-06-02
Reviewed by Darin Adler.
Source/WebCore:
No change in behavior, no new tests added.
- Target.pri: Removed ClipboardQt.h and EditorQt.cpp from compilation.
- dom/Clipboard.h:
- editing/qt/EditorQt.cpp: Removed.
- page/qt/EventHandlerQt.cpp: Use Clipboard::createForDragAndDrop().
(WebCore::EventHandler::createDraggingClipboard):
- platform/Pasteboard.h:
(WebCore::Pasteboard::clipboardData): Expose writable QMimeData* to outside, so that it is accessible
from DragClientQt.cpp and WebDragClientQt.cpp.
(WebCore::Pasteboard::invalidateWritableData):
(WebCore::Pasteboard::isForDragAndDrop):
(WebCore::Pasteboard::isForCopyAndPaste):
- platform/qt/ClipboardQt.cpp:
(WebCore::Clipboard::createDragImage):
(WebCore::Clipboard::declareAndWriteDragImage):
- platform/qt/ClipboardQt.h: Removed.
- platform/qt/PasteboardQt.cpp: Moved required methods from ClipboardQt.cpp.
(WebCore::isTextMimeType):
(WebCore::isHtmlMimeType):
(WebCore::Pasteboard::create):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):
(WebCore::Pasteboard::readData):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readFilenames):
(WebCore::Pasteboard::setDragImage):
(WebCore::Pasteboard::writePasteboard):
Source/WebKit/qt:
- WebCoreSupport/DragClientQt.cpp:
(WebCore::DragClientQt::startDrag):
Source/WebKit2:
- WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:
(WebKit::WebDragClient::startDrag):
- 9:14 PM Changeset in webkit [151090] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 9:13 PM Changeset in webkit [151089] by
-
- 1 copy in tags/Safari-537.43.7
New Tag.
- 6:43 PM Changeset in webkit [151088] by
-
- 3 edits3 adds in trunk
Going "back" to a cached page from a page with a main resource error breaks scrolling, amongst other issues.
<rdar://problem/13751844> and https://bugs.webkit.org/show_bug.cgi?id=117112
Reviewed by Alexey Proskuryakov.
Source/WebCore:
If a main resource load ends in error, the Document's parser is never cleared out.
If you then return to a CachedPage, we run the Document->clearParser() step for the
old page and that incorrectly dispatches didFinishLoad for the previous page load
in the middle of the load for the cached page.
The parser should never be needed after a load completes (even if it fails) and
holding on to the parser after the page load failed but before a new navigation is
actually using unnecessary resources.
So we should just clear the parser right when the main resource fails.
Test: http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading): After canceling the main resource load, also clear the parser.
LayoutTests:
- http/tests/loading/resources/resource-that-goes-back-while-still-loading.php: Added.
- http/tests/loading/unfinished-load-back-to-cached-page-callbacks-expected.txt: Added.
- http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html: Added.
- 4:34 PM Changeset in webkit [151087] by
-
- 1 edit in branches/safari-537.43-branch/Source/WebCore/ChangeLog
Fix typo in ChangeLog
- 4:33 PM Changeset in webkit [151086] by
-
- 6 edits in branches/safari-537.43-branch/Source/WebCore
Rollout r151084
- 2:32 PM Changeset in webkit [151085] by
-
- 6 edits in branches/safari-537.43-branch/Source/WebCore
Merged r151076. <rdar://problem/14042030>
- 1:37 PM Changeset in webkit [151084] by
-
- 1 edit1 delete in trunk/LayoutTests
The empty directory did not get deleted by commit queue, deleting manually.
- xmlviewer: Removed.
- xmlviewer/resources: Removed.
- 12:08 PM Changeset in webkit [151083] by
-
- 2 edits in trunk/Source/WebCore
[CMake] Unreviewed buildfix after r148896 and r150940.
- CMakeLists.txt:
- 10:29 AM Changeset in webkit [151082] by
-
- 6 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Get rid of StructureStubInfo::bytecodeIndex
https://bugs.webkit.org/show_bug.cgi?id=117127
Reviewed by Mark Hahnenberg.
StructureStubInfo already has a CodeOrigin field, which also has a bytecodeIndex.
It makes sense to just always use the CodeOrigin.
- bytecode/StructureStubInfo.h:
(StructureStubInfo):
(JSC::getStructureStubInfoBytecodeIndex):
- jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- 1:33 AM Changeset in webkit [151081] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient
https://bugs.webkit.org/show_bug.cgi?id=117116
Patch by Sergio Correia <Sergio Correia> on 2013-06-02
Reviewed by Tim Horton.
Valgrind reported a "conditional jump or move depends on uninitialised value"
at WebPageProxy constructor, when checking the m_isVisible variable inside
the ENABLE(PAGE_VISIBILITY_API) guard.
The issue was tracked down to the WebView constructor, which was creating a
WebKit::PageClient* making use of `this' before having initialized all of its
attributes.
The solution was to move the initialization of the `page' member to inside the
constructor itself - out of the initialization list -, where we can guarantee
all the relevant stuff has already been properly initialized.
Here's the relevant valgrind trace for reference:
Conditional jump or move depends on uninitialised value(s)
at 0x65A35A4: WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*,
WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:322)
by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*,
WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:233)
by 0x65E94BB: WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*,
WebKit::WebContext*, WebKit::WebPageGroup*)
(WebProcessProxy.cpp:172)
by 0x6570957: WebKit::WebContext::createWebPage(WebKit::PageClient*,
WebKit::WebPageGroup*, WebKit::WebPageProxy*)
(WebContext.cpp:735)
by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*,
WebKit::WebPageGroup*) (WebView.cpp:52)
by 0x6775F18: WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*,
WebKit::WebPageGroup*) (WebViewEfl.cpp:54)
by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*,
WebKit::WebPageGroup*) (WebViewEfl.cpp:49)
by 0x673E13D: WKViewCreate (WKView.cpp:33)
by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92)
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::WebView):
- 1:14 AM Changeset in webkit [151080] by
-
- 4 edits2 adds3 deletes in trunk
Unstyled XML viewer crashes when XML contains an element with id="tree"
https://bugs.webkit.org/show_bug.cgi?id=117117
<rdar://problem/13727267>
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml
- xml/XMLViewer.css: Removed the rule to hide source document, as we no longer
keep it in the tree.
- xml/XMLViewer.js:
(prepareWebKitXMLViewer): Make sourceXML a detached tree, as otherwise it can
have ID conflicts with elements we add.
(sourceXMLLoaded): Removed some commented out code. Removed code that was checking
whether an extension took over XML display, as it makes no sense to duplicate this
functionality in an extension.
LayoutTests:
- http/tests/xmlviewer/dumpAsText/existing-tree-element-crash-expected.txt: Added.
- http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml: Added.
- xmlviewer: Removed.
- xmlviewer/extensions-api-expected.txt: Removed.
- xmlviewer/extensions-api.html: Removed.
- xmlviewer/resources: Removed.
- xmlviewer/resources/sample.xml: Removed.
The "API" no longer exists.
Jun 1, 2013:
- 9:42 PM Changeset in webkit [151079] by
-
- 3 edits2 adds in trunk
WebKit ignores aria-hidden when traversing nodes for name calculation
https://bugs.webkit.org/show_bug.cgi?id=117101
Reviewed by Tim Horton.
Source/WebCore:
When calculating the inner text, aria-hidden should be considered.
Test: accessibility/text-role-with-aria-hidden-inside.html
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::shouldUseAccessiblityObjectInnerText):
LayoutTests:
- accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
- accessibility/text-role-with-aria-hidden-inside.html: Added.
- 4:41 PM Changeset in webkit [151078] by
-
- 8 edits in branches/safari-537.43-branch/Source/WebKit2
Merge r151054.
- 4:31 PM Changeset in webkit [151077] by
-
- 17 edits in branches/safari-537.43-branch/Source/WebKit2
Merge r151043.
- 4:26 PM Changeset in webkit [151076] by
-
- 6 edits in trunk/Source/WebCore
window.speechSynthesis needs to be cheap
https://bugs.webkit.org/show_bug.cgi?id=117111
rdar://problem/14042030
Reviewed by Dean Jackson.
Add the traditional laziness to all of the speech synthesis code, wherever
it was omitted.
- Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
(WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
platform speech synthesizer. Since this code is only used to set up a mock in the
test runner, the fact that it was wrong before was harmless, but still not good.
(WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
so we can get the voice list from it.
(WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
synthesizer here.
(WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
null and do nothing if it's not present.
(WebCore::SpeechSynthesis::pause): Ditto.
(WebCore::SpeechSynthesis::resume): Ditto.
- platform/PlatformSpeechSynthesizer.cpp:
(WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
when asked for a voice list.
- platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.
The unused setVoiceList function has been removed. The initializeVoiceList is now
private rather than protected. Added a new m_voiceListIsInitialized boolean.
- platform/mac/PlatformSpeechSynthesizerMac.mm:
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
m_voiceListIsInitialized to false.
- platform/mock/PlatformSpeechSynthesizerMock.cpp:
(WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
stop when you destroy them.
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
call to m_voiceList.clear(), since the caller only calls this once when the
voice list is already clear.
- 4:09 PM Changeset in webkit [151075] by
-
- 2 edits in trunk/Tools
Add a preferred email address and "expertise" for me.
- Scripts/webkitpy/common/config/contributors.json:
- 4:09 PM Changeset in webkit [151074] by
-
- 2 edits in branches/safari-537.43-branch/Tools
Merge r150636.
- 3:24 PM Changeset in webkit [151073] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010
Reviewed by Goeffrey Garen.
Carefully merge r146669 from trunk. This required some fiddling since it
wasn't a clean apply.
Original changelog:
1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.
2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).
3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.
4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.
5) Treat all exits that were counted as being frequent.
81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGOSRExitBase.cpp:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
- dfg/DFGOSRExitBase.h:
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
(OSRExitBase):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- runtime/Options.h:
(JSC):
- 11:02 AM Changeset in webkit [151072] by
-
- 2 edits in trunk/Source/WebCore
Fix typo in r151071.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
- 3:20 AM Changeset in webkit [151071] by
-
- 4 edits in trunk/Source/WebCore
Move Node::hasName() to Element.
<http://webkit.org/b/117107>
Reviewed by Antti Koivisto.
A Node can't have attributes, and thus can't have a name.
Use a bit on ElementData instead of (half) a Node flag to track whether we have a name.
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore::ElementData::ElementData):
- dom/Element.h:
(WebCore::ElementData::hasName):
(WebCore::Element::hasName):
- dom/Node.h:
(WebCore::Node::isEditingText):
- 2:48 AM Changeset in webkit [151070] by
-
- 2 edits in trunk/Source/WebKit/mac
Remove unnused WebDOMNodeOperationsInternal category.
<http://webkit.org/b/117105>
Reviewed by Ryosuke Niwa.
_subresourceURLs had no clients.
- DOM/WebDOMOperations.mm:
- 2:39 AM Changeset in webkit [151069] by
-
- 8 edits in trunk/Source
Move Node::hasID() and hasClass() to Element.
<http://webkit.org/b/117104>
Reviewed by Ryosuke Niwa.
Source/WebCore:
A Node can't have attributes, and thus can't have an ID or a class.
Move these to Element instead, and fix up a few call sites that called through on a Node*.
- dom/Element.h:
- dom/LiveNodeList.cpp:
(WebCore::LiveNodeList::namedItem):
- dom/Node.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::name):
- rendering/RenderTreeAsText.cpp:
(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):
Source/WebKit/mac:
- WebView/WebRenderLayer.mm:
(+[WebRenderLayer nameForLayer:]):
May 31, 2013:
- 11:00 PM Changeset in webkit [151068] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Remove passed accessibility test from EFL WK1.
- platform/efl-wk1/TestExpectations:
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 10:41 PM Changeset in webkit [151067] by
-
- 7 edits2 adds in trunk/Source
[Curl] Unable to download files.
https://bugs.webkit.org/show_bug.cgi?id=116150
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-31
Reviewed by Brent Fulgham.
Implemented basic download functionality for Curl.
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj: Added file.
- WebCore.vcxproj/WebCore.vcxproj: Added file.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added file.
- platform/network/curl/CurlDownload.h: Added.
- platform/network/curl/CurlDownload.cpp: Added.
Source/WebKit/win:
- WebDownload.h:
- WebDownloadCurl.cpp:
(WebDownload::init):
(WebDownload::start):
(WebDownload::cancel):
(WebDownload::deletesFileUponFailure):
(WebDownload::setDeletesFileUponFailure):
(WebDownload::setDestination):
(WebDownload::useCredential):
(WebDownload::didReceiveResponse):
(WebDownload::didReceiveDataOfLength):
(WebDownload::didFinish):
(WebDownload::didFail):
- 9:21 PM Changeset in webkit [151066] by
-
- 3 edits in trunk/Tools
Unreviewed. Make windows test bots search in the correct directory for build output.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start):
- Scripts/webkitdirs.pm:
(determineConfigurationProductDir):
- 8:54 PM Changeset in webkit [151065] by
-
- 2 edits in trunk/Tools
Unreviewed. Windows build fix...
- BuildSlaveSupport/built-product-archive:
(createZip):
- 8:34 PM Changeset in webkit [151064] by
-
- 2 edits in trunk/Tools
Unreviewed. Windows build fix. One more time!
- BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):
(extractBuiltProduct):
- 8:04 PM Changeset in webkit [151063] by
-
- 2 edits in trunk/Tools
Unreviewed. Windows build fix.
- Scripts/build-webkit:
- 7:59 PM Changeset in webkit [151062] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu
https://bugs.webkit.org/show_bug.cgi?id=117014
Reviewed by Christophe Dumez.
m_viewImpl is able to be null. So, we need to protect this function against such case.
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::hide):
(ewk_context_menu_hide):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu):
- 6:43 PM Changeset in webkit [151061] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 6:39 PM Changeset in webkit [151060] by
-
- 4 edits in trunk/Source/WebKit2
Fix bug in active page tracking that lead to plugins hanging during destruction
https://bugs.webkit.org/show_bug.cgi?id=117099
Reviewed by Anders Carlsson.
NPRuntimeObjectMap no longer keeps its own reference to the
throttler, and no longer reports activity during destruction.
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
- 6:07 PM Changeset in webkit [151059] by
-
- 2 edits in trunk/Tools
Unreviewed. Windows build fix.
- Scripts/build-webkit:
- 5:45 PM Changeset in webkit [151058] by
-
- 1 copy in tags/Safari-537.43.6
New Tag.
- 5:18 PM EfficientStrings edited by
- This is a summary of what was discussed on "[webkit-dev] When should I … (diff)
- 5:01 PM Changeset in webkit [151057] by
-
- 6 edits in trunk/Source/WebKit2
[wk2] All intrinsic content size changes should go through the 0-delay timer
https://bugs.webkit.org/show_bug.cgi?id=117058
<rdar://problem/13935042>
Reviewed by Anders Carlsson.
In r146913, I added a 0-delay timer so that we'd coalesce intrinsic
content size changes. However, didUpdateGeometry was still immediately
invalidating the intrinsic content size without coalescing.
Move that update to the WebProcess to share the timer.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didUpdateGeometry):
- UIProcess/DrawingAreaProxy.messages.in:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
- UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Remove the newIntrinsicContentSize argument, and don't invalidate intrinsic
content size inside didUpdateGeometry.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Start the intrinsic content size update timer when we finish updateGeometry.
- 4:47 PM Changeset in webkit [151056] by
-
- 2 edits2 deletes in trunk/Tools
Make build-webkit output VCExpress 2010 build logs properly.
https://bugs.webkit.org/show_bug.cgi?id=117096
Reviewed by Brent Fulgham.
Make it so that output from VCExpress is always printed to console.
Get build log results from AssembleBuildLogs project output.
We don't need those old VCExpress scripts anymore either.
- Scripts/build-webkit:
- Scripts/print-msvc-project-dependencies: Removed.
- Scripts/print-vse-failure-logs: Removed.
- 4:40 PM Changeset in webkit [151055] by
-
- 5 edits1 add in trunk/Source/WebKit2
Sandbox violations when trying to access fonts in non-standard locations
https://bugs.webkit.org/show_bug.cgi?id=117097
<rdar://problem/9264746>
Reviewed by Anders Carlsson.
The issue was that lack of a main xib was resulting in font machinery being
initialized too early, before we entered sandbox.
- Resources/WebContentProcess.xib: Added.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
- 4:32 PM Changeset in webkit [151054] by
-
- 8 edits in trunk/Source/WebKit2
Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090
Rubber-stamped by Anders Carlsson.
Follow-up to r151043 incorprating some feedback I got from Darin after I had already
committed the patch.
- UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(callGetPlugInInformationBlockAndDispose):
Renamed to be less wordy.
(WKPageGetPlugInInformation):
Ditto.
- UIProcess/API/C/mac/WKPagePrivateMac.h:
Ditto.
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::findPlugInProcessByID):
Renamed to not use "Cocoa method style" in non-Cocoa functions.
(WebKit::PluginProcessManager::findPlugInProcessByToken):
Ditto.
- UIProcess/WebPageProxy.h:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getPlugInInformation):
Reduce ref count churn and fix a variable name.
Updated for the change to findPlugInProcessByID.
(WebKit::WebPageProxy::containsPlugInCallback):
Updated for the change to findPlugInProcessByToken.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
Move the override of a virtual function to the private section.
- 4:32 PM Changeset in webkit [151053] by
-
- 14 edits in branches/dfgFourthTier/LayoutTests
fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT
Rubber stamped by Mark Hahnenberg.
- fast/js/dfg-arguments-alias-one-block-overwrite-expected.txt:
- fast/js/dfg-arguments-out-of-bounds-expected.txt:
- fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt:
- fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt:
- fast/js/dfg-array-length-dead-expected.txt:
- fast/js/dfg-array-pop-side-effects-expected.txt:
- fast/js/resources/js-test-pre.js:
(testFailed):
(dfgIncrement):
(isSuccessfullyParsed):
- fast/js/script-tests/dfg-arguments-alias-one-block-overwrite.js:
- fast/js/script-tests/dfg-arguments-out-of-bounds.js:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js:
- fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js:
- fast/js/script-tests/dfg-array-length-dead.js:
- fast/js/script-tests/dfg-array-pop-side-effects.js:
- 4:13 PM Changeset in webkit [151052] by
-
- 1 edit in branches/dfgFourthTier/Source/JavaScriptCore/ChangeLog
Fix ChangeLog. That revision was no longer a work in progress.
- 3:49 PM Changeset in webkit [151051] by
-
- 9 edits in branches/safari-537.43-branch/Source
Merged r151040. <rdar://problem/14027095>
- 3:47 PM Changeset in webkit [151050] by
-
- 9 edits in branches/safari-537.43-branch/Source
Rollout of r151048.
- 3:32 PM Changeset in webkit [151049] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14036464> Sandbox violation when using Web SpeechSynthesis
Reviewed by Anders Carlsson
- WebProcess/com.apple.WebProcess.sb.in: Allow com.apple.speech.synthesis.console.
- 3:23 PM Changeset in webkit [151048] by
-
- 9 edits in branches/safari-537.43-branch/Source
Merged r51945. <rdar://problem/14027095>
- 3:14 PM Changeset in webkit [151047] by
-
- 3 edits in trunk/Tools
[Windows] Use WinLauncher to display LayoutTest results
https://bugs.webkit.org/show_bug.cgi?id=117085
Reviewed by Oliver Hunt.
- Scripts/webkitdirs.pm:
(runSafari): Use WinLauncher to display content
- WinLauncher/WinLauncher.cpp:
(dllLauncherEntryPoint): Check for URL argument.
- 3:13 PM Changeset in webkit [151046] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r151042. <rdar://problem/13812355>
- 3:08 PM Changeset in webkit [151045] by
-
- 2 edits in trunk/Source/JavaScriptCore
Incorrect assertion in DFG::Graph::uncheckedActivationRegisterFor()
<rdar://problem/13989324>
Rubber stamped by Mark Hahnenberg.
This has a bogus assertion that checks that the passed CodeOrigin doesn't have
an inline call frame. This was well intentioned in the sense that it is true
that inlined call frames wouldn't have an activation register. But that doesn't
mean that people won't ask. Removing the assertion fixes a debug-only crash and
has no impact on production code. This change adds a comment to that effect.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::uncheckedActivationRegisterFor):
- 3:01 PM Changeset in webkit [151044] by
-
- 4 edits in trunk
Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
Add it to the WebKit solution as well.
- win/AssembleBuildLogs/AssembleLogs.cmd:
- 2:59 PM Changeset in webkit [151043] by
-
- 17 edits in trunk/Source/WebKit2
Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090
Reviewed by Anders Carlsson.
- UIProcess/API/C/mac/WKPagePrivateMac.cpp:
(callGetInformationForPlugInWithProcessIDBlockAndDispose):
Get the block from the context, invoke it with the result, and dispose of it.
(WKPageGetInformationForPlugInWithProcessID):
Ask the WebPageProxy and provide it with a dictionary callback that uses the
above function to invoke the passed in block.
- UIProcess/API/C/mac/WKPagePrivateMac.h:
Add WKPageGetInformationForPlugInWithProcessID and a typedef for the callback block.
- UIProcess/Plugins/PluginProcessManager.h:
Add ways to get the PluginProcessProxy associated with a process id or process token.
- UIProcess/Plugins/mac/PluginProcessManagerMac.mm:
(WebKit::PluginProcessManager::plugInProcessWithProcessID):
Return the first PluginProcessProxy with the passed in process ID.
(WebKit::PluginProcessManager::plugInProcessWithToken):
Return the first PluginProcessProxy with the passed in process token.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
Invalidate any outstanding requests for plug-in information.
- UIProcess/WebPageProxy.h:
Keep track of the callbacks for the requests for plug-in information.
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::getInformationForPlugInWithProcessID):
If there are no known plug-ins with the provided process ID, invoke the callback with a null
dictionary of plug-in information.
Otherwise, keep track of the callback and send a message to the web process asking for the
information.
(WebKit::WebPageProxy::containsPlugInCallback):
If the page did not contain the plug-in, invoke the callback with a null dictionary of
plug-in information.
Invoke the callback with a dictionary containing the PlugInModuleInfo.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Return 0 for the plugInProcessToken.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
Ditto.
- WebProcess/Plugins/Plugin.h:
Add a pure virtual method for plugInProcessToken so it can be accessed from from the Plugin
on the PluginView.
- WebProcess/Plugins/PluginProxy.h:
Return the actual plug-in process token.
- WebProcess/Plugins/PluginView.h:
(WebKit::PluginView::plugIn):
Make it possible to get at the plug-in process token through the Plugin.
- WebProcess/WebPage/WebPageMac.mm:
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
If there is an instance of the plug-in with that token, send a confirmation to the ui
process.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:55 PM Changeset in webkit [151042] by
-
- 2 edits in trunk/Source/WebCore
Take the normal NSView code path when drawing into an inclusive layer
https://bugs.webkit.org/show_bug.cgi?id=117094
<rdar://problem/13812355>
Reviewed by Sam Weinig.
For now, take the normal code path when drawing into an inclusive layer.
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 2:48 PM Changeset in webkit [151041] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
Remove CodeOrigin::valueProfileOffset since it was only needed for op_call_put_result.
Rubber stamped by Mark Hahnenberg.
- bytecode/CodeOrigin.h:
(CodeOrigin):
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::valueProfileFor):
- 2:44 PM Changeset in webkit [151040] by
-
- 9 edits in trunk/Source
Source/WebCore: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>
Reviewed by Mark Rowe.
No change in functionality.
- WebCore.exp.in:
- platform/mac/MemoryPressureHandlerMac.mm:
(WebCore::MemoryPressureHandler::install): Call new API
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
Source/WebKit/mac: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>
Reviewed by Mark Rowe.
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
Source/WebKit2: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>
Reviewed by Mark Rowe.
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- 2:40 PM Changeset in webkit [151039] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Remove finalDestinationOrIgnored since it isn't called anymore.
Rubber stamped by Mark Hahnenberg.
- bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
- 2:37 PM Changeset in webkit [151038] by
-
- 20 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: get rid of op_call_put_result
https://bugs.webkit.org/show_bug.cgi?id=117047
Reviewed by Gavin Barraclough.
Work in progress. This still makes like 20 tests crash.
op_call_put_result is an oddball. Its semantics are that it takes the return
value of a call instruction, which is set aside in regT0/regT1, and places them
into some stack slot. This is weird since there is an implicit contract with the
preceding bytecode instruction, and it's even weirder since it means that it
doesn't make sense to jump to it; for example OSR exit from the preceding call
instruction must make sure to jump over the op_call_put_result.
So this patch gets rid of op_call_put_result:
- In bytecode, all calls return a value and we always allocate a temporary for that value even if it isn't used.
- The LLInt does the return value saving as part of dispatchAfterCall().
- The JIT and DFG do the return value saving as part of normal code generation. The DFG already did the right thing.
- DFG->JIT OSR exit in the case of inlining will make the return PC's point at the CallLinkInfo::callReturnLocation, rather than the machine PC associated with the op_call_put_result instruction.
- Tons of code gets removed. The DFG had to track whether or not a call had a return value in a bunch of places. It had to track the fact that we would exit to after the op_call_put_result. It was a mess. That mess is now gone.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFromLLInt):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
- bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
- bytecompiler/NodesCodegen.cpp:
(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
(JIT):
- jit/JITCall.cpp:
(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):
- jit/JITCall32_64.cpp:
(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
- jit/JITOpcodes.cpp:
(JSC):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::genericCall):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 1:44 PM Changeset in webkit [151037] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Update Button UX.
https://bugs.webkit.org/show_bug.cgi?id=116992
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.
BlackBerry PR 342298.
Internally Review by Jeff Rogers.
- css/themeBlackBerry.css:
- 1:27 PM Changeset in webkit [151036] by
-
- 2 edits in trunk/Source/WebCore
DerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when FeatureDefines.xcconfig changes
<http://webkit.org/b/117081>
Reviewed by Mark Rowe.
- DerivedSources.make: Add $(PLATFORM_FEATURE_DEFINES)
dependency for all rules that use $(FEATURE_DEFINES) to generate
files.
(PLATFORM_FEATURE_DEFINES): Set this variable to
Configurations/FeatureDefines.xcconfig if not already set on
Mac OS X.
- 1:16 PM Changeset in webkit [151035] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r141445): MPEG-4 videos do not play on certain hardware configurations
https://bugs.webkit.org/show_bug.cgi?id=117089
<rdar://problem/13839717>
Reviewed by Mark Rowe.
- Configurations/WebContentProcess.xcconfig: Statically link to a framework that uses an XPC service to work around a libxpc limitation on Lion.
- 12:08 PM Changeset in webkit [151034] by
-
- 2 edits in trunk/Source/WebCore
Text Field UX updates.
https://bugs.webkit.org/show_bug.cgi?id=116996
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.
BlackBerry PR 342333.
Internally Reviewed by Jeff Rogers.
Update disabled text field font color.
- css/themeBlackBerry.css:
- 11:22 AM Changeset in webkit [151033] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix Overflow case of branchMul32 in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117057
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.
Current implementation of Overflow case in branchMul32 performs an
unsigned multiplication whereas a signed multiplication is expected.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchMul32):
- 11:22 AM Changeset in webkit [151032] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Fix floating point comparisons in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117066.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.
Current implementation of branchDouble function in baseline JIT is wrong
for some conditions and overkill for others. For instance:
- With DoubleGreaterThanOrEqual condition, branch will be taken if either operand is NaN with current implementation whereras it should not.
- With DoubleNotEqualOrUnordered condition, performed NaN checks are useless (because comparison result is false if either operand is NaN).
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchDouble):
- 11:21 AM Changeset in webkit [151031] by
-
- 3 edits in trunk/Source/JavaScriptCore
[sh4] Fix double floating point transfer in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117054
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.
In current implementation, dmovRegReg function transfers only one single
FPRegister as PR=1 and SZ=0 in floating point status/control register.
Double transfers must be performed with two fmov.s opcodes.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::moveDouble):
(JSC::MacroAssemblerSH4::addDouble): Handle (op2==dest) case properly.
(JSC::MacroAssemblerSH4::sqrtDouble):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::fmovsRegReg):
- 11:19 AM Changeset in webkit [151030] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Handle branchType properly in branchTruncateDoubleToInt32.
https://bugs.webkit.org/show_bug.cgi?id=117062
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.
Current implementation of branchTruncateDoubleToInt32 is incorrect
when branchType == BranchIfTruncateSuccessful in sh4 baseline JIT.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):
- 10:45 AM Changeset in webkit [151029] by
-
- 2 edits in trunk/Source/WebCore
Update CheckedInt.h to latest version from Mozilla
https://bugs.webkit.org/show_bug.cgi?id=117009
Reviewed by Darin Adler.
Mozilla have updated their version of CheckedInt and suggested
we sync. Here are the improvements:
- CheckedInt now consistently rejects unsupported types. Before, you
could sometimes construct a CheckedInt from an unsupported type (like,
float) or multiply a CheckedInt by a float, and have it not caught! See
https://bugzilla.mozilla.org/show_bug.cgi?id=869194
- Fixed a possibility of undefined behavior in unary operator-. See bug
https://bugzilla.mozilla.org/show_bug.cgi?id=849666
- CheckedInt now supports the "long long" and "unsigned long long"
types. We don't like "long long" (and neither does the Google C++ style
guide!) but we had to do that because libogg exposes typedefs to those
types. See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=869685
- CheckedInt also now supports "signed char" in addition to "char" ---
they are not the same type! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=847521
- Fixed and simplified usage of CheckedInt outside of Mozilla. You'll
like this one! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=849667
- Fixed compilation with the Intel C++ compiler. See bug https://bugzilla.mozilla.org/show_bug.cgi?id=784309
- html/canvas/CheckedInt.h: Updated.
- 10:29 AM Changeset in webkit [151028] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r151026. <rdar://problem/14030364>
- 10:27 AM Changeset in webkit [151027] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150836. <rdar://problem/13925131>
- 10:04 AM Changeset in webkit [151026] by
-
- 2 edits in trunk/Source/WebKit2
Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117076
<rdar://problem/14030364>
Reviewed by Beth Dakin and Anders Carlsson.
If a plug-in can support software snapshotting, then don't create an
accelerated compositing layer for it while in snapshot mode. This is a
better user experience -- otherwise the page/plug-in looks like it broke.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isAcceleratedCompositingEnabled): If we are in snapshotting mode
and we are a Flash plugin (the only one that supports software snapshots at the moment)
then do not create an accelerated compositing layer.
- 10:02 AM Changeset in webkit [151025] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build fix for VS2005 builders.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def: Add
missing export for WTF::SHA1::computeHexDigest
- 9:57 AM Changeset in webkit [151024] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r151022.
http://trac.webkit.org/changeset/151022
https://bugs.webkit.org/show_bug.cgi?id=117084
Also breaks build by introducing duplicate symbols (Requested
by bfulgham on #webkit).
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
- 9:54 AM WebKitGTK/2.0.x edited by
- Link to changesets instead of bugzilla, for two issues where fixes … (diff)
- 9:45 AM Changeset in webkit [151023] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix to NRWT
- Scripts/webkitpy/port/win.py:
(WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
- 9:31 AM Changeset in webkit [151022] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix after r151012
- TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
WTF library to support SHA tests
- 9:17 AM Changeset in webkit [151021] by
-
- 2 edits in trunk/Source/WebCore
Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352
Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-05-31
Reviewed by Philippe Normand.
GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(_WebKitWebSrcPrivate):
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):
- 9:16 AM Changeset in webkit [151020] by
-
- 2 edits in trunk/Source/WTF
Fix double hash lookup in PageMapMemoryUsageRecorder::visit
https://bugs.webkit.org/show_bug.cgi?id=117071
Reviewed by Andreas Kling.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 9:14 AM Changeset in webkit [151019] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build fix after r151012
- TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
snprintf definition for Windows.
- 9:01 AM Changeset in webkit [151018] by
-
- 2 edits in trunk/Source/WTF
[Windows] Speculative build fix for pre-VS2010 compilers
- wtf/Platform.h: Only treat WTF as DLL for VS2010 builds
- 8:53 AM Changeset in webkit [151017] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Update test-expectations after r151000.
- fast/js/date-DST-time-cusps-expected.txt:
- 8:52 AM Changeset in webkit [151016] by
-
- 2 edits in trunk/Source/WebCore
Build fix when CSSParser debugging is enabled
https://bugs.webkit.org/show_bug.cgi?id=117075
Reviewed by Andreas Kling.
Build fails when enabling parser debugging by setting YYDEBUG to
1 because of a missing include.
- css/CSSGrammar.y.includes:
- 8:21 AM Changeset in webkit [151015] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
https://bugs.webkit.org/show_bug.cgi?id=117070
Unreviewed test expectations update.
WebKitTestRunner needs a more-complete implementation of eventSender.
Until then caret-after-keypress test is disabled
See https://bugs.webkit.org/show_bug.cgi?id=42194
- platform/qt-5.0-wk2/TestExpectations:
- 6:29 AM Changeset in webkit [151014] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Skip flaky test.
- platform/qt-5.0-wk2/TestExpectations: Skip crashing test.
- platform/qt/fast/js/date-DST-time-cusps-expected.txt: Rebaselining after r151000.
- 3:25 AM Changeset in webkit [151013] by
-
- 2 edits in trunk/Source/WebCore
[Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
https://bugs.webkit.org/show_bug.cgi?id=116686
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-31
Reviewed by Carlos Garcia Campos.
We were using g_input_stream_read_async() to handle redirections
because of Gnome bug #691489.
This produces an unexpected read attempt which triggers an assert
in StreamingClient::getOrCreateReadBuffer().
Now that the Gnome bug is fixed we can replace read_async() with
skip_async().
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):
- 3:06 AM Changeset in webkit [151012] by
-
- 11 edits2 adds in trunk
Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=116445
Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-05-31
Reviewed by Benjamin Poulain.
Source/WTF:
Remove the MD5 and SHA1 test cases from the WTF code. The same cases are now built and run under TestWebKitAPI.
- wtf/MD5.cpp:
(WTF::MD5::MD5):
- wtf/SHA1.cpp:
(WTF::SHA1::SHA1):
Tools:
Add the MD5 and SHA1 unit tests that were previously located inside WTF.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::expectMD5):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::expectSHA1):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/WTF.pro:
- TestWebKitAPI/win/TestWebKitAPI.vcproj:
- 1:58 AM Changeset in webkit [151011] by
-
- 2 edits in trunk/LayoutTests
[EFL] Update EFL TextExpectation for WebAudio cases.
https://bugs.webkit.org/show_bug.cgi?id=117061.
Unreviewed EFL Gardening.
WebAudio test cases delaynode-max-nondefault-delay.html, delaynode-scheduling.html
and javascriptaudionode.html pass with latest updates in efl port. Updating
TestExpectation accordingly.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-31
- platform/efl/TestExpectations:
- 12:15 AM Changeset in webkit [151010] by
-
- 2 edits in trunk/LayoutTests
[Mac] Should pass http/tests/images/png-partial-load-no-alpha.html
https://bugs.webkit.org/show_bug.cgi?id=97170
Unreviewed test expectations update.
- platform/mac/TestExpectations: Passing after r150340: remove the
Mac-specfic [ImageOnlyFailure] for this test.
May 30, 2013:
- 10:14 PM Changeset in webkit [151009] by
-
- 4 edits2 adds in trunk
selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=110742
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch defers firing "webkitEditableContentChanged" until new
selection is applied to control. This makes selection during "input"
more consistent and reliable.
Background: "input" event is fired by "webkitEditableContentChanged"
dispatcher. But "input" is scoped event, so under some conditions its
dispatching may be deferred. When "input" dispatching is deferred,
dispatcher observes updated selectionStart and selectionEnd.
Otherwise values repersent state before applying editing command.
So, to make selectionStart/End to be more predictable and useful, we
need either always dispatch "input" before selection is updated, or
always dispatch "input" after selection is updated.
As it was mentioned, dispatching could be deferred by scoping. So
dispatching before updating selection couldn't be guaranteed.
Moreover, it will be hard to calculate updated selection in user
code. On the other side - old selection could be easily tracked.
So, it looks logically that we should guarantee dispatching "input"
after updating selection. There are no execution paths in
"webkitEditableContentChanged" dispatched that depends on current
selection. So it is safe to fire this event after selection is updated.
Test: editing/selection/caret-after-keypress.html
- editing/Editor.cpp:
Dispatch "input" event after new selection in applied.
LayoutTests:
Test that cursor is up-to-date during "input" event.
- editing/selection/caret-after-keypress-expected.txt: Added.
- editing/selection/caret-after-keypress.html: Added.
- platform/mac-wk2/TestExpectations: Exclude new test.
- 9:53 PM Changeset in webkit [151008] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 9:51 PM Changeset in webkit [151007] by
-
- 1 copy in tags/Safari-537.43.5
New Tag.
- 9:32 PM Changeset in webkit [151006] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, EFL gardening.
Some of tests in printing are passing on EFL WK2. But, they are still failing on EFL WK1.
- platform/efl/TestExpectations:
- 8:59 PM Changeset in webkit [151005] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed build correction.
- Scripts/webkitpy/port/win.py:
(WinPort.create_debugger_command_file): The directory needs to be
a string, not a temporary directory object.
- 8:31 PM Changeset in webkit [151004] by
-
- 2 edits in trunk/Tools
[Windows] NRWT doesn't save crash logs on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76935
Reviewed by Ryosuke Niwa.
Extend the WinPort class with commands to set and clean up various registry
values needed to invoke the correct debugger to get crash files.
- Scripts/webkitpy/port/win.py:
(WinPort): Added global caches for registry keys and settings
(WinPort._ntsd_location): Added
(WinPort.create_debugger_command_file): Added
(WinPort.read_registry_string): Added
(WinPort.write_registry_string): Added
(WinPort.setup_crash_log_saving): Added
(WinPort.restore_crash_log_saving): Added
(WinPort.setup_test_run): Added overload to add registry settings.
(WinPort.clean_up_test_run): Added overload to clean up registry settings.
- 7:32 PM Changeset in webkit [151003] by
-
- 2 edits in trunk/Source/WebCore
WebKit's Enter Full Screen for <video> elements isn't working
https://bugs.webkit.org/show_bug.cgi?id=117001
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-05-30
Reviewed by Jer Noble.
Fix workflow to allow a video to enter into full screen
mode from a kWKContextMenuItemTagEnterVideoFullscreen
context menu item by denoting the enterFullscreenForVideo
call as a user gesture, so Document::requestFullScreenForElement
will execute correctly.
No new tests. Covered by media/context-menu-actions.html,
which is disabled due to bug #116651.
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::enterFullscreenForVideo):
- 7:30 PM Changeset in webkit [151002] by
-
- 24 edits2 deletes in branches/safari-537.43-branch/Source
Rollout of r150981. <rdar://problem/13785764>
- 7:05 PM Changeset in webkit [151001] by
-
- 2 edits in trunk/Source/WebKit2
It's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051
Reviewed by Anders Carlsson.
Re-add the ASSERT_NOT_REACHED, and return [WKDOMNode class] in the case
where we don't have a specific subclass.
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass):
- 6:52 PM Changeset in webkit [151000] by
-
- 3 edits in trunk/LayoutTests
fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895
<rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
https://bugs.webkit.org/show_bug.cgi?id=11157
Reviewed by Alexey Proskuryakov.
Accidental progression, updating results to expect success.
- TestExpectations:
- Remove expectations of failure.
- fast/js/script-tests/date-DST-time-cusps.js:
- Prefer the latter option for non-existent time (due to clock rolling forward).
- 6:52 PM Changeset in webkit [150999] by
-
- 2 edits in trunk/Source/WTF
Another unreviewed speculative build fix for Mac.
- wtf/text/WTFString.h:
(WTF::String::fromUTF8WithLatin1Fallback):
- 6:46 PM Changeset in webkit [150998] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix jscore-test when not using --sdk option with jsDriver.pl
https://bugs.webkit.org/show_bug.cgi?id=116339
Reviewed by Joe Pecoraro.
- tests/mozilla/jsDriver.pl:
(execute_tests):
With each test, the shell_command needs to be started from scratch.
This fix will clear the shell_command and start over as before with
the opt_arch option when not using --sdk with jsDriver.pl.
- 6:09 PM WebKitEFLLayoutTest edited by
- (diff)
- 6:07 PM Changeset in webkit [150997] by
-
- 3 edits in trunk/Source/WTF
Unreviewed build fix for Mac.
- wtf/OSAllocator.h:
- wtf/text/WTFString.h:
(WTF::String::fromUTF8):
- 5:53 PM Changeset in webkit [150996] by
-
- 2 edits in trunk/Source/WebCore
Fix double hash lookup in RenderTableSection::paintObject loop
https://bugs.webkit.org/show_bug.cgi?id=117055
Reviewed by Antonio Gomes.
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintObject):
- 5:38 PM Changeset in webkit [150995] by
-
- 35 edits1 delete in trunk
Get rid of JavaScript exports file on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=117050.
Reviewed by Darin Adler.
This requires turning WTF into a shared library and adding the WTF_EXPORT_PRIVATE to some methods where it was missed.
Start linking in WTF.lib now that it's a shared library.
Also, delete the JavaScriptCoreExportGenerator folder and remove dependencies.
- JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Removed.
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Removed.
- JavaScriptCore.vcxproj/jsc/jscCommon.props:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
- JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
- JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
- JavaScriptCore.vcxproj/testapi/testapiCommon.props:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTFCommon.props:
- wtf/DateMath.h:
- wtf/ExportMacros.h:
- wtf/FilePrintStream.h:
- wtf/OSAllocator.h:
- wtf/PageAllocationAligned.h:
- wtf/Platform.h:
- wtf/PrintStream.h:
- wtf/StackBounds.h:
- wtf/StringPrintStream.h:
- wtf/ThreadSpecific.h:
- wtf/WTFThreadData.h:
- wtf/dtoa/cached-powers.h:
- wtf/dtoa/double-conversion.h:
- wtf/text/WTFString.h:
- wtf/unicode/Collator.h:
- wtf/unicode/UTF8.h:
- WebKit.vcxproj/WebKit.sln:
- WebKit.vcxproj/WebKit/WebKitCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
- TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
- 5:16 PM Changeset in webkit [150994] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add --sdk option to jsDriver.pl to run with iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=116339
Reviewed by David Kilzer.
- tests/mozilla/jsDriver.pl:
(execute_tests):
Prefix shell command with the path to the "sim" tool.
(parse_args):
Add -d / --sdk option.
(usage):
Help message for -d / --sdk option.
- 4:29 PM Changeset in webkit [150993] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: LLInt shouldn't store an offset call PC during op_call-like calls
https://bugs.webkit.org/show_bug.cgi?id=117048
Reviewed by Mark Hahnenberg.
This just makes everything consistent in the LLInt: anytime any op calls out,
it stores its PC and never the next op's PC.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):
- bytecode/CodeBlock.h:
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCallVarargs):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
(JSC::CLoop::execute):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 4:21 PM Changeset in webkit [150992] by
-
- 2 edits in trunk/Source/JavaScriptCore
[sh4] Optimize NaN checks in LLINT for floating point comparisons.
https://bugs.webkit.org/show_bug.cgi?id=117049
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-30
Reviewed by Oliver Hunt.
Use the fcmp/eq opcode in sh4 LLINT to test if a double is NaN.
This is more efficient, doesn't require two tmp registers and requires
less code than current implementation (which converts double to float,
then checks 'E = Emax + 1' and 'f != 0').
- offlineasm/sh4.rb:
- 4:15 PM WebKitGTK/2.0.x edited by
- as translation update (diff)
- 4:15 PM Changeset in webkit [150991] by
-
- 2 edits in trunk/Source/WebCore
Fix double hash lookup in WebSocket::connect loop
https://bugs.webkit.org/show_bug.cgi?id=117052
Reviewed by Anders Carlsson.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- 3:58 PM Changeset in webkit [150990] by
-
- 3 edits in trunk/Source/JavaScriptCore
JSCallbackObject does not correctly initialise the PropertySlot for getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=117053
Reviewed by Mark Hahnenberg.
Set appropriate thisValue on the PropertySlot
- API/JSCallbackObjectFunctions.h:
(JSC::::getOwnPropertyDescriptor):
- API/tests/testapi.mm:
- 3:55 PM Changeset in webkit [150989] by
-
- 2 edits in trunk/Source/WebKit2
Remove ASSERT_NOT_REACHED from WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051
Reviewed by Anders Carlsson.
It's easy to fail this assertion in seemingly-legitimate cases.
- WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:
(WebKit::WKDOMNodeClass):
- 3:47 PM Changeset in webkit [150988] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] Updated as-IN translations
https://bugs.webkit.org/show_bug.cgi?id=116953
Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-05-30
Reviewed by Gustavo Noronha Silva (kov).
- as.po: Updated.
- 2:31 PM Changeset in webkit [150987] by
-
- 2 edits in trunk/LayoutTests
fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=117037
Reviewed by Alexey Proskuryakov.
Close the window on a zero-delay timer, working around a bug where WKTR
will hang if a window is closed while a load is in progress.
Doesn't affect the test in an important way.
- fast/dom/script-tests/location-new-window-no-crash.js:
- 2:18 PM Changeset in webkit [150986] by
-
- 5 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150977. <rdar://problem/13916291>
- 2:15 PM Changeset in webkit [150985] by
-
- 3 edits in trunk/Source/WebCore
Remove some 16bits conversion.
https://bugs.webkit.org/show_bug.cgi?id=116935
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-30
Reviewed by Darin Adler.
Merge chromium ce35a544d09e6cb907457535340eb0e9984e57b8.
https://chromium.googlesource.com/chromium/blink/+/ce35a544d09e6cb907457535340eb0e9984e57b8
- html/parser/InputStreamPreprocessor.h:
- platform/FileSystem.cpp:
(WebCore::encodeForFileName):
- 2:11 PM Changeset in webkit [150984] by
-
- 4 edits in branches/safari-537.43-branch/Source
Rollout of r150819. <rdar://problem/14025590>
- 2:08 PM Changeset in webkit [150983] by
-
- 12 edits in branches/safari-537.43-branch/Source
Merged r150950. <rdar://problem/13992853>
- 2:03 PM Changeset in webkit [150982] by
-
- 6 edits in branches/safari-537.43-branch/Source
Merged r150948. <rdar://problem/13886753>
- 2:00 PM Changeset in webkit [150981] by
-
- 24 edits2 copies in branches/safari-537.43-branch/Source
Merged r150935. <rdar://problem/13785764>
- 1:55 PM Changeset in webkit [150980] by
-
- 3 edits in branches/safari-537.43-branch/Source/JavaScriptCore
Merged r150831. <rdar://problem/14004998>
- 1:53 PM Changeset in webkit [150979] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150925. <rdar://problem/13976781>
- 1:51 PM Changeset in webkit [150978] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150648. <rdar://problem/13976781>
- 1:50 PM Changeset in webkit [150977] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
https://bugs.webkit.org/show_bug.cgi?id=117042
<rdar://problem/13916291>
Reviewed by Mark Rowe.
Ignore HTTP errors for scripts requested from within the installer. Instead of just checking for the
Adobe Flash installer, we use the "com.solidstatenetworks.awkhost" bundle identifier to determine
whether to apply the workaround. This could in theory fix other installers that use the same mechanism.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::shouldIgnoreHTTPStatusCodeErrors):
- loader/cache/CachedScript.h:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsSolidStateNetworksDownloader):
- platform/RuntimeApplicationChecks.h:
- 1:39 PM Changeset in webkit [150976] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Fix pass_by_value coverity warning in ChromeClientGtk
https://bugs.webkit.org/show_bug.cgi?id=117021
Patch by Enrique Ocana Gonzalez <eocanha@igalia.com> on 2013-05-30
Reviewed by Anders Carlsson.
Pass dirtyRegion parameter in paintWebView() by reference to avoid object copying.
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::paintWebView):
- 12:21 PM Changeset in webkit [150975] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 12:18 PM Changeset in webkit [150974] by
-
- 1 copy in tags/Safari-537.43.4
New Tag.
- 11:34 AM Changeset in webkit [150973] by
-
- 14 edits12 adds in trunk/LayoutTests
Update XMLHttpRequest timeout tests to a newer version from W3C
https://bugs.webkit.org/show_bug.cgi?id=117023
Reviewed by Alexey Proskuryakov.
The XMLHttpRequest Timeout tests have gone through a bit of restructuring and should
be updated. This is being primarily done because of the intention of updating the
testharness scripts which would break these tests if they were left not updated.
These tests were updated from the W3C web-platform-tests GitHub repository.
https://github.com/w3c/web-platform-tests
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides-expected.txt: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconworker.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.js: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides-expected.txt: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Added.
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html:
- http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js:
(RequestTracker.prototype.startXHR):
(AbortedRequest.prototype.startXHR.handleEvent):
(runTestRequests):
- 11:20 AM Changeset in webkit [150972] by
-
- 6 edits in trunk
Allow no space between "background-position:" dimensions
https://bugs.webkit.org/show_bug.cgi?id=116870
Reviewed by Darin Adler.
From Blink r149314 by <ericwilligers@chromium.org>
Source/WebCore:
Specs allow no spaces between the dimensions of a
"background-position:" like "1px+1px", we should support
that.
Whitespaces are no longer early consumed, dramatically dropping
the shift/reduce conflicts to half. The productions unary_term,
calc_func_term, calc_func_expr and calc_func_paren_expr no longer
consume whitespaces.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::realLex):
LayoutTests:
- fast/backgrounds/background-position-parsing-2-expected.txt:
- fast/backgrounds/background-position-parsing-2.html:
- 11:19 AM Changeset in webkit [150971] by
-
- 14 edits2 copies in trunk/Source/WebCore
HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
https://bugs.webkit.org/show_bug.cgi?id=117016
Reviewed by Oliver Hunt.
Add a new class PageActivityAssertionToken to allow HTMLMediaElement to decouple
knowledge of and control over the lifetime of PageThrottler. The new class will
have weak references to and from the PageThrottler so that holders of the token
will not need to care if the Page or PageThrottler has been destroyed.
HTMLMediaElement will create one of these PageActivityAssertionTokens when playback
begins and destroy it when playback stops for any reason, or when the element is
destroyed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::updatePlayState):
- html/HTMLMediaElement.h:
- page/Page.cpp:
(WebCore::createActivityToken): Added simple factory method.
- page/Page.h:
- page/PageActivityAssertionToken.cpp:
(WebCore::PageActivityAssertionToken::PageActivityAssertionToken): Call addActivityToken();
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken): Call removeActivityToken();
(WebCore::PageActivityAssertionToken::invalidate): Clear m_throttler.
- page/PageActivityAssertionToken.h:
- page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler): Invalidate all outstanding tokens.
(WebCore::PageThrottler::addActivityToken): Bump the activity count.
(WebCore::PageThrottler::removeActivityToken): Lower the activity count.
- page/PageThrottler.h:
Add the new files to the various build systems:
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- 10:52 AM Changeset in webkit [150970] by
-
- 12 edits in trunk
[Mac] Enable cache partitioning and the public suffix list on 10.8
<rdar://problem/13679019>
Rubber-stamped by David Kilzer.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 10:09 AM Changeset in webkit [150969] by
-
- 2 edits in trunk/Source/WebCore
Fix double hash lookup in DocumentEventQueue::cancelEvent().
<http://webkit.org/b/117031>
Reviewed by Anders Carlsson.
- dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::cancelEvent):
- 10:06 AM Changeset in webkit [150968] by
-
- 2 edits in trunk/Source/WebKit2
Fix double hash lookup in WebPage::determinePrimarySnapshottedPlugIn() loop.
<http://webkit.org/b/117032>
Reviewed by Anders Carlsson.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- 10:05 AM Changeset in webkit [150967] by
-
- 2 edits in trunk/Source/WebCore
Fix double hash lookup in DocumentLoader::removeSubresourceLoader().
<http://webkit.org/b/117030>
Reviewed by Anders Carlsson.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::removeSubresourceLoader):
- 10:03 AM Changeset in webkit [150966] by
-
- 2 edits in trunk/Source/WebCore
Fix double hash lookup in RenderView::repaintSelection() loop.
<http://webkit.org/b/117029>
Reviewed by Anders Carlsson.
- rendering/RenderView.cpp:
(WebCore::RenderView::repaintSelection):
- 9:44 AM Changeset in webkit [150965] by
-
- 4 edits5 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Skip new failures after r150868.
- platform/qt-5.0-wk2/TestExpectations: re-skip still failing tests after r150892.
- platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Rebaselining after r150798.
- platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
- platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
- platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
- platform/qt/TestExpectations: Skip new failre after r150853.
- 8:12 AM Changeset in webkit [150964] by
-
- 2 edits in trunk/Source/WebCore
CURL: Incorrect stripping of query from file URL
https://bugs.webkit.org/show_bug.cgi?id=104307
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-30
Reviewed by Darin Adler.
Clear the query part of the file URL if there is any.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::initializeHandle):
- 7:55 AM Changeset in webkit [150963] by
-
- 2 edits in trunk
[GTK] Needs to check for harfbuzz-icu
https://bugs.webkit.org/show_bug.cgi?id=116978
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-30
Reviewed by Xan Lopez.
HarfBuzz 0.9.18 splits harbuzz-icu into a separate library so we
also need to check for it in order to get the necessary flags for
the compiler and the linker.
We keep this conditional for now since we still want to support
earlier versions of HarfBuzz.
- Source/autotools/FindDependencies.m4:
- 7:26 AM Changeset in webkit [150962] by
-
- 10 edits2 adds in trunk/Source/WebCore
Separate generic font family settings to a class
https://bugs.webkit.org/show_bug.cgi?id=117027
Reviewed by Andreas Kling.
The new class is under platform/ and can be accessed by the font code directly without platform violations.
- WebCore.xcodeproj/project.pbxproj:
- page/Settings.cpp:
(WebCore::invalidateAfterGenericFamilyChange):
(WebCore::Settings::Settings):
(WebCore::Settings::~Settings):
(WebCore::Settings::create):
(WebCore::Settings::standardFontFamily):
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::fixedFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::serifFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::sansSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::cursiveFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::fantasyFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::pictographFontFamily):
(WebCore::Settings::setPictographFontFamily):
- page/Settings.h:
- platform/graphics/FontGenericFamilies.cpp: Added.
(WebCore::setGenericFontFamilyForScript):
(WebCore::genericFontFamilyForScript):
(WebCore::FontGenericFamilies::FontGenericFamilies):
(WebCore::FontGenericFamilies::standardFontFamily):
(WebCore::FontGenericFamilies::fixedFontFamily):
(WebCore::FontGenericFamilies::serifFontFamily):
(WebCore::FontGenericFamilies::sansSerifFontFamily):
(WebCore::FontGenericFamilies::cursiveFontFamily):
(WebCore::FontGenericFamilies::fantasyFontFamily):
(WebCore::FontGenericFamilies::pictographFontFamily):
(WebCore::FontGenericFamilies::setStandardFontFamily):
(WebCore::FontGenericFamilies::setFixedFontFamily):
(WebCore::FontGenericFamilies::setSerifFontFamily):
(WebCore::FontGenericFamilies::setSansSerifFontFamily):
(WebCore::FontGenericFamilies::setCursiveFontFamily):
(WebCore::FontGenericFamilies::setFantasyFontFamily):
(WebCore::FontGenericFamilies::setPictographFontFamily):
- platform/graphics/FontGenericFamilies.h: Added.
(WebCore::UScriptCodeHashTraits::emptyValue):
(WebCore::UScriptCodeHashTraits::constructDeletedValue):
(WebCore::UScriptCodeHashTraits::isDeletedValue):
(WebCore::FontGenericFamilies::create):
- 7:15 AM Changeset in webkit [150961] by
-
- 91 edits43 copies483 adds in trunk/LayoutTests
[Qt][WK2] Unreviewed expected pixel result rebaselining after r150798.
- platform/qt-5.0-wk2/compositing/checkerboard-expected.png:
- platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
- platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
- platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
- platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
- platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
- platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
- platform/qt-5.0-wk2/compositing/overflow/nested-scrolling-expected.png: Added.
- platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
- platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.png: Added.
- platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png:
- platform/qt-5.0-wk2/compositing/repaint/page-scale-repaint-expected.png:
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.png:
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png:
- platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
- platform/qt-5.0-wk2/css1/basic/containment-expected.png: Added.
- platform/qt-5.0-wk2/css1/basic/id_as_selector-expected.png: Added.
- platform/qt-5.0-wk2/css1/basic/inheritance-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_bottom-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_bottom_width-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_left-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_left_width-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_right_inline-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_right_width-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_style-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_top-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_top_width-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/border_width-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/clear-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/clear_float-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/float_elements_in_series-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/float_margin-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/height-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin_bottom-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin_inline-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin_left-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin_right-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/margin_top-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding_bottom-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding_inline-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding_left-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding_right-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/padding_top-expected.png: Added.
- platform/qt-5.0-wk2/css1/box_properties/width-expected.png: Added.
- platform/qt-5.0-wk2/css1/cascade/cascade_order-expected.png: Added.
- platform/qt-5.0-wk2/css1/classification/display-expected.png: Added.
- platform/qt-5.0-wk2/css1/classification/list_style_type-expected.png: Added.
- platform/qt-5.0-wk2/css1/classification/white_space-expected.png: Added.
- platform/qt-5.0-wk2/css1/color_and_background/background-expected.png: Added.
- platform/qt-5.0-wk2/css1/color_and_background/background_attachment-expected.png: Added.
- platform/qt-5.0-wk2/css1/color_and_background/background_position-expected.png: Added.
- platform/qt-5.0-wk2/css1/color_and_background/background_repeat-expected.png: Added.
- platform/qt-5.0-wk2/css1/conformance/forward_compatible_parsing-expected.png: Added.
- platform/qt-5.0-wk2/css1/font_properties/font-expected.png: Added.
- platform/qt-5.0-wk2/css1/font_properties/font_family-expected.png: Added.
- platform/qt-5.0-wk2/css1/font_properties/font_size-expected.png: Added.
- platform/qt-5.0-wk2/css1/font_properties/font_weight-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/floating_elements-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/height_of_lines-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/horizontal_formatting-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/inline_elements-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/replaced_elements-expected.png: Added.
- platform/qt-5.0-wk2/css1/formatting_model/vertical_formatting-expected.png: Added.
- platform/qt-5.0-wk2/css1/pseudo/anchor-expected.png: Added.
- platform/qt-5.0-wk2/css1/pseudo/firstletter-expected.png: Added.
- platform/qt-5.0-wk2/css1/pseudo/firstline-expected.png: Added.
- platform/qt-5.0-wk2/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/letter_spacing-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/line_height-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/text_decoration-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/text_indent-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/text_transform-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/vertical_align-expected.png: Added.
- platform/qt-5.0-wk2/css1/text_properties/word_spacing-expected.png: Added.
- platform/qt-5.0-wk2/css1/units/color_units-expected.png: Added.
- platform/qt-5.0-wk2/css1/units/length_units-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
- platform/qt-5.0-wk2/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
- platform/qt-5.0-wk2/css2.1/t1508-c527-font-07-b-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-001-expected.png:
- platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-002-expected.png:
- platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-003-expected.png:
- platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/insert-div-023-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-by-character-004-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/focus_editable_html-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-all-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-all-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-all-003-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/select-all-004-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
- platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png:
- platform/qt-5.0-wk2/editing/selection/unrendered-002-expected.png:
- platform/qt-5.0-wk2/editing/selection/unrendered-003-expected.png:
- platform/qt-5.0-wk2/editing/selection/unrendered-004-expected.png:
- platform/qt-5.0-wk2/editing/selection/unrendered-005-expected.png:
- platform/qt-5.0-wk2/fast/backgrounds/background-inherit-color-bug-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/background-leakage-transforms-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
- platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/basic/016-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/basic/truncation-rtl-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
- platform/qt-5.0-wk2/fast/block/float/013-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/019-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
- platform/qt-5.0-wk2/fast/block/float/021-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/025-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/027-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/032-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/033-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/block/float/035-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
- platform/qt-5.0-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/br-with-clear-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
- platform/qt-5.0-wk2/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/float-avoidance-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/float/nested-clearance-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/block/float/relative-painted-twice-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png.
- platform/qt-5.0-wk2/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/margin-collapse/103-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/margin-collapse/104-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/047-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/051-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/055-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/auto/007-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/negative-rel-position-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-expected.png: Added.
- platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
- platform/qt-5.0-wk2/fast/body-propagation/overflow/001-expected.png: Added.
- platform/qt-5.0-wk2/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
- platform/qt-5.0-wk2/fast/body-propagation/overflow/005-declarative-expected.png: Added.
- platform/qt-5.0-wk2/fast/body-propagation/overflow/005-expected.png: Added.
- platform/qt-5.0-wk2/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/border-image-massive-scale-expected.png:
- platform/qt-5.0-wk2/fast/borders/border-image-rotate-transform-expected.png:
- platform/qt-5.0-wk2/fast/borders/border-image-scale-transform-expected.png:
- platform/qt-5.0-wk2/fast/borders/border-image-scaled-expected.png:
- platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png:
- platform/qt-5.0-wk2/fast/borders/rtl-border-01-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/rtl-border-02-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/rtl-border-03-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-sizing/box-sizing-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
- platform/qt-5.0-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
- platform/qt-5.0-wk2/fast/css-generated-content/014-expected.png:
- platform/qt-5.0-wk2/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/005-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
- platform/qt-5.0-wk2/fast/css/border-height-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/clip-text-in-scaled-div-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/empty-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/first-child-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/first-of-type-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/font_property_normal-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/hsl-color-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/last-child-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/last-of-type-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/line-height-overflow-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/only-child-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/only-of-type-pseudo-class-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/shadow-multiple-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
- platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
- platform/qt-5.0-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
- platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png.
- platform/qt-5.0-wk2/fast/dynamic/anchor-lock-expected.png: Added.
- platform/qt-5.0-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
- platform/qt-5.0-wk2/fast/encoding/utf-16-big-endian-expected.png: Added.
- platform/qt-5.0-wk2/fast/encoding/utf-16-little-endian-expected.png: Added.
- platform/qt-5.0-wk2/fast/events/pointer-events-2-expected.png:
- platform/qt-5.0-wk2/fast/events/resize-events-expected.png: Added.
- platform/qt-5.0-wk2/fast/flexbox/016-expected.png: Added.
- platform/qt-5.0-wk2/fast/flexbox/flex-hang-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/button-default-title-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/button-table-styles-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/disabled-select-change-index-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/file/file-input-direction-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/form-hides-table-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/input-placeholder-paint-order-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-simple-expected.png:
- platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/iframe-scrolling-attribute-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png:
- platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png:
- platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png:
- platform/qt-5.0-wk2/fast/html/details-position-expected.png: Added.
- platform/qt-5.0-wk2/fast/html/details-writing-mode-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/gif-large-checkerboard-expected.png: Added.
- platform/qt-5.0-wk2/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-continuation-borders-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/long-wrapped-line-expected.png: Added.
- platform/qt-5.0-wk2/fast/layers/layer-content-visibility-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png:
- platform/qt-5.0-wk2/fast/line-grid/line-grid-inside-columns-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/001-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/001-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/008-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/008-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/li-br-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/lists/ol-start-parsing-expected.png: Added.
- platform/qt-5.0-wk2/fast/lists/olstart-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/client-rects-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/column-rules-stacking-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/columns-shorthand-parsing-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/float-multicol-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/float-paginate-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/layers-in-multicol-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
- platform/qt-5.0-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/progression-reverse-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/table-vertical-align-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
- platform/qt-5.0-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/006-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/overflow-auto-table-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/overflow-stacking-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/paged-x-on-root-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/paged-y-on-root-expected.png: Added.
- platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png:
- platform/qt-5.0-wk2/fast/reflections/reflection-direction-expected.png: Added.
- platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
- platform/qt-5.0-wk2/fast/regions/region-style-inline-background-color-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
- platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
- platform/qt-5.0-wk2/fast/repaint/float-new-in-block-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png:
- platform/qt-5.0-wk2/fast/repaint/overflow-scroll-body-appear-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
- platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
- platform/qt-5.0-wk2/fast/repaint/transform-absolute-in-positioned-container-expected.png:
- platform/qt-5.0-wk2/fast/replaced/005-expected.png: Added.
- platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
- platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png:
- platform/qt-5.0-wk2/fast/selectors/166-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/023-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/027-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/034-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/038-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/040-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/040-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/002-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/empty-cells-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/frame-and-rules-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/height-percent-test-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/fast/table/height-percent-test-vertical-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/table/overflowHidden-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/prepend-in-anonymous-table-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/table-display-types-vertical-expected.png: Added.
- platform/qt-5.0-wk2/fast/table/wide-colspan-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
- platform/qt-5.0-wk2/fast/table/wide-column-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/hyphenate-limit-lines-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/softHyphen-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/text-letter-spacing-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/wbr-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/word-break-expected.png: Added.
- platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
- platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
- platform/qt-5.0-wk2/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png: Added.
- platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png:
- platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-rl-expected.png: Added.
- platform/qt-5.0-wk2/fast/writing-mode/fieldsets-expected.png: Added.
- platform/qt-5.0-wk2/fonts/cursive-expected.png: Added.
- platform/qt-5.0-wk2/fonts/default-expected.png: Added.
- platform/qt-5.0-wk2/fonts/fantasy-expected.png: Added.
- platform/qt-5.0-wk2/fonts/monospace-expected.png: Added.
- platform/qt-5.0-wk2/fonts/sans-serif-expected.png: Added.
- platform/qt-5.0-wk2/fonts/serif-expected.png: Added.
- platform/qt-5.0-wk2/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
- platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
- platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
- platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
- platform/qt-5.0-wk2/printing/return-from-printing-mode-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/qt-5.0-wk2/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png:
- platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
- platform/qt-5.0-wk2/svg/custom/js-late-pattern-creation-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/junk-data-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
- platform/qt-5.0-wk2/svg/custom/missing-xlink-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/object-sizing-no-width-height-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/path-bad-data-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/pattern-scaling-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
- platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png:
- platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png: Added.
- platform/qt-5.0-wk2/svg/dom/css-transforms-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
- platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-multiple-targets-id-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
- platform/qt-5.0-wk2/svg/hixie/error/012-expected.png: Added.
- platform/qt-5.0-wk2/svg/in-html/circle-expected.png: Added.
- platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
- platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
- platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
- platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
- platform/qt-5.0-wk2/svg/wicd/rightsizing-grid-expected.png: Added.
- platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
- platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image1-expected.png: Added.
- platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
- platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
- platform/qt-5.0-wk2/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug101674-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug10269-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug10296-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1055-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug11944-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug120364-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug12384-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug1302-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020_iframe-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug137388-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug16252-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug194024-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug22019-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug23151-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-4-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug27038-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug29314-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug2947-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug32205-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug38916-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug3977-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug43039-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug43854-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug44505-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug50695-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug56405-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug5797-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug5835-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug650-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug67915-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug73321-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug92143-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/bugs/bug96343-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/core/captions-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/cell_heights-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/col_span-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/nested1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/one_row-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/core/row_span-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_name-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_name-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_height-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_name-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_height-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_nowrap-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/cell_widths-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/nestedTables-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/test3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/test6-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug19526-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug7243-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/col_span2-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/columns-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/conflicts-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/standards1-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
- platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/test4-expected.png: Added.
- platform/qt-5.0-wk2/transforms/2d/transform-fixed-container-expected.png:
- 5:53 AM Changeset in webkit [150960] by
-
- 11 edits in trunk/Source/WebCore
Avoid using CSSOM style declarations in HTML editing.
<http://webkit.org/b/117019>
Reviewed by Antti Koivisto.
Convert the editing code to use ComputedStyleExtractor instead of instantiating CSSOM wrappers.
- css/CSSComputedStyleDeclaration.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::getFontSizeCSSValuePreferringKeyword):
(WebCore::ComputedStyleExtractor::useFixedFontDefaultSize):
(WebCore::ComputedStyleExtractor::propertyMatches):
(WebCore::ComputedStyleExtractor::copyProperties):
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
Moved here from CSSComputedStyleDeclaration. These methods are used by HTML editing.
(WebCore::CSSComputedStyleDeclaration::copyProperties):
Reimplemented to call ComputedStyleExtractor.
- css/CSSStyleDeclaration.h:
- css/PropertySetCSSStyleDeclaration.h:
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::copyProperties):
Removed CSSStyleDeclaration::cssPropertyMatches(), the remaining code lives in
ComputedStyleExtractor::propertyMatches() and is only used by HTML editing.
- css/StylePropertySet.h:
- css/StylePropertySet.cpp:
(WebCore::MutableStylePropertySet::removeEquivalentProperties):
Added an overload that takes a ComputedStyleExtractor.
This code should move into EditingStyle.cpp, material for a follow-up patch.
- editing/ApplyStyleCommand.cpp:
(WebCore::toIdentifier):
Add a file-local helper for yanking the identifier value (if any) out of a CSSPrimitiveValue.
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
- editing/EditingStyle.h:
- editing/EditingStyle.cpp:
(WebCore::editingStyleFromComputedStyle):
(WebCore::extractPropertyValue):
(WebCore::identifierForStyleProperty):
(WebCore::textColorFromStyle):
(WebCore::backgroundColorFromStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::StyleChange::StyleChange):
(WebCore::fontWeightIsBold):
(WebCore::extractPropertiesNotIn):
(WebCore::getPropertiesNotIn):
Use ComputedStyleExtractor instead of CSSComputedStyleDeclaration in all of this code.
Templatized a bunch of the code so we don't have to repeat ourselves for both StylePropertySet
and ComputedStyleExtractor inputs.
- 5:41 AM Changeset in webkit [150959] by
-
- 2 edits in trunk/Source/WebCore
Remove "hidden"=true from Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=114116
Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-30
Reviewed by Timothy Hatcher.
Remove "hidden"=true because it's a Chromium concept.
Patch created by Timothy Hatcher.
- inspector/Inspector.json:
- 5:28 AM Changeset in webkit [150958] by
-
- 9 edits in trunk/Source/WebCore
[EFL][EGL] Implement TransportSurface client.
https://bugs.webkit.org/show_bug.cgi?id=114122
Reviewed by Kenneth Rohde Christiansen.
Covered by existing WebGL tests.
This patch implements the client support for Transport
Surface with EGL backend using GLES2.
- platform/graphics/surfaces/efl/GLTransportSurface.cpp:
(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):
- platform/graphics/surfaces/efl/GLTransportSurface.h:
(GLTransportSurfaceClient):
- platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:
(WebCore::GraphicsSurfacePrivate::initializeClient):
- platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore):
(WebCore::EGLConfigSelector::surfaceClientConfig):
(WebCore::EGLConfigSelector::findMatchingConfigWithVisualId):
- platform/graphics/surfaces/egl/EGLConfigSelector.h:
(WebCore):
(EGLConfigSelector):
Support for retrieving valid EGLConfig on client side.
- platform/graphics/surfaces/egl/EGLHelper.cpp:
(WebCore):
(WebCore::resolveDisplay):
(WebCore::EGLHelper::resolveEGLBindings):
(WebCore::EGLHelper::createEGLImage):
(WebCore::EGLHelper::destroyEGLImage):
(WebCore::EGLHelper::imageTargetTexture2DOES):
- platform/graphics/surfaces/egl/EGLHelper.h:
Helper functions to create and destroy EGLImage.
- platform/graphics/surfaces/egl/EGLXSurface.cpp:
(WebCore::EGLXTransportSurfaceClient::EGLXTransportSurfaceClient):
(WebCore):
(WebCore::EGLXTransportSurfaceClient::~EGLXTransportSurfaceClient):
(WebCore::EGLXTransportSurfaceClient::destroy):
(WebCore::EGLXTransportSurfaceClient::prepareTexture):
(WebCore::EGLTextureFromPixmap::EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::~EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::destroy):
(WebCore::EGLTextureFromPixmap::isValid):
(WebCore::EGLTextureFromPixmap::bindTexImage):
(WebCore::EGLTextureFromPixmap::reBindTexImage):
- platform/graphics/surfaces/egl/EGLXSurface.h:
(EGLXTransportSurfaceClient):
TransportSurfaceClient implementation.
(WebCore):
- platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):
- platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurfaceClient):
- platform/graphics/surfaces/glx/X11Helper.cpp:
(WebCore::X11Helper::createOffScreenWindow):
(WebCore):
(WebCore::X11Helper::createPixmap):
- platform/graphics/surfaces/glx/X11Helper.h:
(X11Helper):
- 5:08 AM Changeset in webkit [150957] by
-
- 22 edits in trunk/Source/WebCore
Rename 'KURL::elidedString' and inspector's 'String.prototype.trimMiddle' for clarity.
https://bugs.webkit.org/show_bug.cgi?id=111700
Reviewed by Darin Adler.
Darin suggested that 'KURL::elidedString' is inaccurately named[1], this
patch is an attempt to do better. It additionally brings the Inspector's
'String.prototype.trimMiddle' method into line, as the two methods do
more or less the same thing.
After a bit of discussion with Maciej and Daniel Bates on IRC, I've
settled on 'KURL::stringCenterEllipsizedToLength(unsigned)' and
'String.prototype.centerEllipsizedToLength(number)' respectively.
No new tests are added, as this patch shouldn't have any visible effect
on the web. It's strictly an internal refactoring.
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):
- bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::canExecuteScripts):
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeScript):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):
- loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):
- loader/MixedContentChecker.cpp:
(WebCore::MixedContentChecker::logWarning):
- loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):
- page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):
- platform/KURL.cpp:
(WebCore::KURL::stringCenterEllipsizedToLength):
- platform/KURL.h:
Rename 'KURL::elidedString' to 'KURL::stringCenterEllipsizedToLength',
and adjust callsites accordingly.
- inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
- inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
- inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
- inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
- inspector/front-end/ResourceUtils.js:
(WebInspector.linkifyURLAsNode):
- inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
- inspector/front-end/utilities.js:
Rename 'String.prototype.trimMiddle' to 'String.prototype.centerEllipsizedToLength'
and adjust callsites accordingly.
- 3:44 AM Changeset in webkit [150956] by
-
- 15 edits2 moves in trunk/Source/WebCore
Rename FontFallbackList.cpp/h to FontGlyphs.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=117022
Reviewed by Andreas Kling.
Rename to match the class name.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp:
- platform/graphics/FontFallbackList.cpp: Removed.
- platform/graphics/FontFallbackList.h: Removed.
- platform/graphics/FontFastPath.cpp:
- platform/graphics/FontGlyphs.cpp: Copied from Source/WebCore/platform/graphics/FontFallbackList.cpp.
- platform/graphics/FontGlyphs.h: Copied from Source/WebCore/platform/graphics/FontFallbackList.h.
- platform/graphics/mac/FontComplexTextMac.cpp:
- 3:43 AM Changeset in webkit [150955] by
-
- 6 edits11 deletes in trunk
Web Inspector: tests in PerformanceTests/inspector/ are timing out
https://bugs.webkit.org/show_bug.cgi?id=77024
Reviewed by Andreas Kling.
PerformanceTests:
These tests have been disabled for ages and don't conform to the standard format.
- Skipped:
- inspector: Removed.
- inspector/console-300-lines.html: Removed.
- inspector/first-open-elements.html: Removed.
- inspector/first-open-resources.html: Removed.
- inspector/first-open-scripts.html.broken: Removed.
- inspector/heap-snapshot-advanced.html: Removed.
- inspector/heap-snapshot-performance-test.js: Removed.
- inspector/heap-snapshot.html: Removed.
- inspector/inspector-startup-time.html: Removed.
- inspector/network-append-30-requests.html.broken: Removed.
- inspector/performance-test.js: Removed.
- inspector/show-panel.html.broken: Removed.
Tools:
Remove inspector performance tests since they have been disabled for ages,
and they don't use the standard parser-style performance output.
It's adding a lot of code complexity to our infrastructure.
- Scripts/webkitpy/performance_tests/perftest.py:
(SingleProcessPerfTest.init):
(PerfTestFactory):
- Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestFactory.test_regular_test):
- Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(TestDriver.run_test):
(MainTest.run_test):
(MainTest._tests_for_runner):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest._test_run_with_json_output):
(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
- 3:42 AM Changeset in webkit [150954] by
-
- 5 edits in trunk/Source/WebCore
Get rid of Position::computedStyle
https://bugs.webkit.org/show_bug.cgi?id=117024
Reviewed by Andreas Kling.
Removed the function.
- dom/Position.cpp:
- dom/Position.h:
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::positionToComputeInlineStyleChange): We need a position
inside the dummy element since we'll get the containing element's style instead
if we had the position before the dummy element.
- editing/EditingStyle.cpp:
(WebCore::StyleChange::StyleChange):
- 1:14 AM Changeset in webkit [150953] by
-
- 2 edits in trunk/Source/WebCore
Remove obsolete forward declaration from InspectorFrontendHost.h
https://bugs.webkit.org/show_bug.cgi?id=117017
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30
Reviewed by Joseph Pecoraro.
Remove obsolete forward declaration and fix style issue as well.
No change in behavior, no new tests.
- inspector/InspectorFrontendHost.h:
(WebCore):
(InspectorFrontendHost):
- 12:34 AM Changeset in webkit [150952] by
-
- 2 edits in trunk/LayoutTests
[GTK] Cleanup TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=117005
Unreviewed GTK gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30
- platform/gtk/TestExpectations: Get rid of duplicate entry line.
- 12:32 AM Changeset in webkit [150951] by
-
- 6 edits in trunk/Tools
Remove requires_http_server as Chromium Android was the only port that needed this
https://bugs.webkit.org/show_bug.cgi?id=117018
Reviewed by Benjamin Poulain.
Removed the unused code that existed for Chromium Android port.
- Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests):
(LayoutTestRunner._handle_finished_test_list):
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._run_tests):
- Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):
- Scripts/webkitpy/port/base.py:
(Port.to.start_helper):
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_build_path):
May 29, 2013:
- 11:24 PM Changeset in webkit [150950] by
-
- 12 edits in trunk/Source
Expose incrementalRenderingSuppressionTimeout via WK2
https://bugs.webkit.org/show_bug.cgi?id=117015
<rdar://problem/13992853>
Reviewed by Darin Adler.
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
Inform the FrameLoader that we're ready to transition the page, if
nothing else already has. This will be forwarded to the FrameLoaderClient,
and WebKit2's implementation will go ahead and un-freeze the layer tree,
so that the incremental rendering suppression watchdog timer actually works.
(WebCore::Document::setVisualUpdatesAllowedByClient):
Make incremental rendering suppression extension tokens play nice with the
watchdog timer; allow setVisualUpdatesAllowedByClient=true to re-enable updates
if either the page is in the "completed" state or the watchdog has already fired.
- loader/FrameLoader.cpp:
- loader/FrameLoader.h:
(WebCore::FrameLoader::forcePageTransitionIfNeeded): Added.
Forward to the client.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::forcePageTransitionIfNeeded): Added.
- Shared/WebPreferencesStore.h:
- UIProcess/API/C/WKPreferencesPrivate.h:
Add IncrementalRenderingSuppressionTimeout preference.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIncrementalRenderingSuppressionTimeout): Added.
(WKPreferencesGetIncrementalRenderingSuppressionTimeout): Added.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebKit::WebFrameLoaderClient::forcePageTransitionIfNeeded): Added.
Call didCompletePageTransition, which un-freezes the layer tree.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCompletePageTransition):
Fix some indentation.
(WebKit::WebPage::updatePreferences):
Forward the timeout value through to WebCore.
- 11:04 PM Changeset in webkit [150949] by
-
- 8 edits in trunk
ProgressEvent should not be cancelable
https://bugs.webkit.org/show_bug.cgi?id=114444
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-29
Reviewed by Darin Adler.
Source/WebCore:
Parameter "cancelable" in ProgressEvent is set to false, by default, as mentioned in the specification. The spec link is given below.
No new tests. file-reader-event-listener.html and infoOnProgressEvent-expected.txt are updated.
- dom/ProgressEvent.cpp:
(WebCore::ProgressEvent::ProgressEvent):
(WebCore):
LayoutTests:
file-reader-event-listener.html, xmlhttprequest-get-expected.txt and infoOnProgressEvent-expected.txt are updated.
- fast/files/file-reader-event-listener-expected.txt:
- fast/files/file-reader-event-listener.html:
- fast/xmlhttprequest/xmlhttprequest-get-expected.txt:
- http/tests/xmlhttprequest/infoOnProgressEvent-expected.txt:
- platform/efl/TestExpectations:
- 9:34 PM Changeset in webkit [150948] by
-
- 6 edits in trunk/Source
Fix paint-related milestones to not fire when the layer tree is frozen
https://bugs.webkit.org/show_bug.cgi?id=117012
Source/WebCore:
Reviewed by Tim Horton.
In the previous code, it was possible to paint some layer and schedule
the m_paintRelatedMilestonesTimer, but then the layer tree was put into
a frozen state because the page redirected. However, the paint-related
milestones timer would still fire. This caused woes with header/footer
banners.
Fix by not firing paint-related milestones if the layer tree is frozen,
which we know via a new ChromeClient callback. When unfrozen, we'll
paint again, and fire the timer later.
- page/ChromeClient.h:
(WebCore::ChromeClient::layerTreeStateIsFrozen):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
Source/WebKit2:
Reviewed by Tim Horton.
Implement ChromeClient::layerTreeStateIsFrozen() to return
the frozen state of the drawing area.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::layerTreeStateIsFrozen):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 9:30 PM Changeset in webkit [150947] by
-
- 4 edits in trunk/Source
Web Inspector: get rid of obsolete InspectorFrontendHost.hiddenPanels()
https://bugs.webkit.org/show_bug.cgi?id=60152
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-29
Reviewed by Andreas Kling.
- WebCoreSupport/WebInspectorClient.mm:
- 9:17 PM Changeset in webkit [150946] by
-
- 7 edits in trunk/Source/WebCore
Store form control list with RefPtr
https://bugs.webkit.org/show_bug.cgi?id=116910
Reviewed by Kent Tamura.
Merge https://chromium.googlesource.com/chromium/blink/+/582132773280455ead1d42b0073be37efdeaf989.
Unfortunately, the Blink change doesn't provide much insight as to what kind of crashes are fixed
by this code change but it cleans up the way form elements with state are registered to the form
controller so it seems benefitial to merge it anyway.
- dom/Document.cpp:
(WebCore::Document::dispose):
- html/FormController.cpp:
(WebCore::FormController::createSavedFormStateMap):
(WebCore::FormController::registerFormElementWithState):
(WebCore::FormController::unregisterFormElementWithState):
(WebCore):
- html/FormController.h:
(FormController):
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::insertedInto):
(WebCore):
(WebCore::HTMLFormControlElementWithState::removedFrom):
- html/HTMLFormControlElementWithState.h:
(HTMLFormControlElementWithState):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto):
- 9:11 PM Changeset in webkit [150945] by
-
- 5 edits in trunk/Source/WebCore
Take ComputedStyleExtractor for a spin.
<http://webkit.org/b/116968>
Reviewed by Antti Koivisto.
Convert some editing and SVG code to use ComputedStyleExtractor instead of creating full
blown CSSComputedStyleDeclaration objects.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::getIdentifierValue):
(WebCore::backgroundColorInEffect):
- editing/EditingStyle.h:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::computeCSSPropertyValue):
- 8:26 PM WebKitEFLLayoutTest edited by
- Update Known issues (diff)
- 8:02 PM Changeset in webkit [150944] by
-
- 2 edits in trunk/Source/WebCore
Add a special case for SelectorDataList::execute when there is only one selector
https://bugs.webkit.org/show_bug.cgi?id=116891
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-29
Reviewed by Andreas Kling.
In the vast majority of cases, querySelector is called with a single selector.
This patch takes that input into account to improve the performance of
SelectorDataList::execute(). For the case of a single selector, we avoid three
branches executed for every node of the traversal.
This improves QuerySelector's time by 2.3%.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
- 7:34 PM Changeset in webkit [150943] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 7:31 PM Changeset in webkit [150942] by
-
- 1 copy in tags/Safari-537.43.3
New Tag.
- 6:21 PM Changeset in webkit [150941] by
-
- 10 edits in trunk
-webkit-text-underline-position should not be inherited
https://bugs.webkit.org/show_bug.cgi?id=116363
Reverting http://trac.webkit.org/changeset/150366
It was an incorrect fix referring to an old specification.
Source/WebCore:
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
- fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js:
- 6:19 PM Changeset in webkit [150940] by
-
- 2 edits in trunk/Source/WebCore
[CMAKE] cmake errors when CMAKE_BUILD_TYPE is not specified.
https://bugs.webkit.org/show_bug.cgi?id=116899
Reviewed by Laszlo Gombos.
- CMakeLists.txt: Fixed if statement to escape when find command fails.
- 6:07 PM Changeset in webkit [150939] by
-
- 3 edits in trunk/Tools
prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
https://bugs.webkit.org/show_bug.cgi?id=113221
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-05-29
Reviewed by Ryosuke Niwa.
Teach prepare-Changelog to not list the names of modified namespaces,
classes, or structs in C++ files. Thus, if a change is made
within a namespace/class/struct yet outside a function, it will
not be reflected in the ChangeLog entry.
See https://bugs.webkit.org/show_bug.cgi?id=113221#c8
for more details on how ChangeLog entries are affected.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp):
(delete_namespaces_from_ranges_for_cpp): Added.
(is_function_in_namespace): Added.
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
- 5:10 PM Changeset in webkit [150938] by
-
- 7 edits in trunk/Source/WebKit2
WebKit should expose HSTS APIs to determine whether a host is in the HSTS cache and to reset HSTS policies
https://bugs.webkit.org/show_bug.cgi?id=117010
<rdar://problem/13689666>
Reviewed by Tim Horton.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
- UIProcess/API/C/mac/WKPagePrivateMac.cpp:
- UIProcess/API/C/mac/WKPagePrivateMac.h:
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/mac/WebContextMac.mm:
(WebKit):
(WebKit::privateBrowsingSession):
(WebKit::WebContext::isURLKnownHSTSHost):
(WebKit::WebContext::resetHSTSHosts):
- 4:57 PM Changeset in webkit [150937] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150936. <rdar://problem/14007440>
- 4:52 PM Changeset in webkit [150936] by
-
- 2 edits in trunk/Source/WebKit2
WKViews using shouldClipToVisibleRect=YES should respect prepareContentInRect: if called
https://bugs.webkit.org/show_bug.cgi?id=116989
<rdar://problem/14007440>
Reviewed by Anders Carlsson.
- UIProcess/API/mac/WKView.mm:
(-[WKView prepareContentInRect:]):
If prepareContentInRect: is called, save the rect and set a flag so we know we should use it.
(-[WKView _updateViewExposedRect]):
Give the WebPage (and later the DrawingArea) the union of the rect handed to prepareContentInRect:
and the WKView's visibleRect, if we're in that mode, so that applications that do their own scrolling
can cause tiles to be created in currently offscreen views (for overdraw).
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setShouldClipToVisibleRect:]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Use [_updateViewExposedRect].
- 4:17 PM Changeset in webkit [150935] by
-
- 24 edits2 adds in trunk/Source
Add more accurate activity state tracking
https://bugs.webkit.org/show_bug.cgi?id=116893
Reviewed by Gavin Barraclough.
Source/WebCore:
Add a hysteresis to Page activity throttling. We do this
through a PageThrottler class that now handles entering and
exiting throttling state, and adds a hysteresis to we can
limit the amount of on/off bouncing on the throttle.
Media elements now make use of this to disable timer throttling
while they are playing, and plugins use it to momentarily bounce
from throttled to unthrottled state.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::pageThrottlerIfPossible):
(WebCore):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
- html/HTMLMediaElement.h:
(WebCore):
- html/MediaController.cpp:
(MediaController::unpause):
- page/ChromeClient.h:
(WebCore::ChromeClient::incrementActivePageCount):
(WebCore::ChromeClient::decrementActivePageCount):
(ChromeClient):
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::~Page):
(WebCore::Page::setThrottled):
- page/Page.h:
(WebCore):
(Page):
(WebCore::Page::pageThrottler):
- page/PageThrottleState.h: Added.
- page/PageThrottler.cpp: Added.
(WebCore):
(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::clearPage):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::setThrottled):
(WebCore::PageThrottler::preventThrottling):
(WebCore::PageThrottler::allowThrottling):
(WebCore::PageThrottler::stopThrottleHysteresisTimer):
(WebCore::PageThrottler::reportInterestingEvent):
(WebCore::PageThrottler::startThrottleHysteresisTimer):
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- page/PageThrottler.h: Added.
(WebCore):
(PageThrottler):
(WebCore::PageThrottler::create):
(WebCore::PageThrottler::shouldThrottleAnimations):
(WebCore::PageThrottler::shouldThrottleTimers):
Source/WebKit2:
This extends the logic in WebCore from a Page to Process
granularity, so we will avoid lowering the child process
priority if there is active content. This also plumbs in
the logic to allow plugins to report that they have done
something "interesting". Currently this is somewhat conservative
but even this is sufficient to fix some stuttering issues
that we've seen.
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::ChildProcess):
- Shared/ChildProcess.h:
(ChildProcess):
(WebKit::ChildProcess::processSuppressionEnabled):
(WebKit::ChildProcess::incrementActiveTaskCount):
(WebKit::ChildProcess::decrementActiveTaskCount):
- Shared/mac/ChildProcessMac.mm:
(WebKit):
(WebKit::ChildProcess::setProcessSuppressionEnabledInternal):
(WebKit::ChildProcess::setProcessSuppressionEnabled):
(WebKit::ChildProcess::incrementActiveTaskCount):
(WebKit::ChildProcess::decrementActiveTaskCount):
(WebKit::ChildProcess::suspensionHysteresisTimerFired):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
(WebCore):
(NPRuntimeObjectMap):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::PluginView):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::incrementActivePageCount):
(WebKit):
(WebKit::WebChromeClient::decrementActivePageCount):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
- 3:16 PM Changeset in webkit [150934] by
-
- 2 edits10 deletes in trunk
Remove leftover files for ENABLE_PAGE_POPUP and ENABLE_CALENDAR_PICKER
https://bugs.webkit.org/show_bug.cgi?id=116999
Reviewed by Anders Carlsson.
.:
- ManualTests/forms/calendar-picker-crash-by-type-change.html: Removed.
- ManualTests/forms/calendar-picker.html: Removed.
- ManualTests/forms/color-suggestion-picker.html: Removed.
- ManualTests/forms/date-suggestion-picker.html: Removed.
Source/WebCore:
- Resources/pagepopups/colorSuggestionPicker.css: Removed.
- Resources/pagepopups/colorSuggestionPicker.js: Removed.
- Resources/pagepopups/pickerCommon.css: Removed.
- Resources/pagepopups/pickerCommon.js: Removed.
- Resources/pagepopups/suggestionPicker.css: Removed.
- Resources/pagepopups/suggestionPicker.js: Removed.
- 2:59 PM Changeset in webkit [150933] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; remove unintentional semicolon.
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::finish):
- 2:53 PM Changeset in webkit [150932] by
-
- 3 edits in trunk/Source/WebCore
Merge PODArea::Chunk into PODFreeListArena::FreeListChunk
https://bugs.webkit.org/show_bug.cgi?id=117000
Reviewed by Oliver Hunt.
- platform/PODArena.h:
(WebCore::PODArena::roundUp):
- platform/PODFreeListArena.h:
(PODFreeListArena):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
(FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::~FreeListChunk):
(WebCore::PODFreeListArena::FreeListChunk::allocate):
- 2:41 PM EnableFormFeatures edited by
- (diff)
- 2:37 PM FeatureFlags edited by
- Remove CALENDAR_PICKER, INPUT_MULTIPLE_FIELDS_UI, and PAGE_POPUP (diff)
- 2:28 PM Changeset in webkit [150931] by
-
- 3 edits in trunk/Source/WebCore
Move some PODArena members to PODFreeListArena
https://bugs.webkit.org/show_bug.cgi?id=116993
Reviewed by Sam Weinig.
This is more work towards merging the two classes.
- platform/PODArena.h:
(PODArena):
- platform/PODFreeListArena.h:
(PODFreeListArena):
(WebCore::PODFreeListArena::PODFreeListArena):
- 2:28 PM Changeset in webkit [150930] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Be consistent with allocation/deallocation behavior
https://bugs.webkit.org/show_bug.cgi?id=116998
Reviewed by Anders Carlsson.
- WebPreferences.cpp:
(WebPreferences::setStringValue): Switch from using _wcsdup and
CFStringCreateWithCharactersNoCopy to just use the standard
CFStringCreateWithCharacters call.
- 2:20 PM Changeset in webkit [150929] by
-
- 4 edits2 adds in trunk
[Mac] Scrubbing long movie files results in timeline snapping back to 0 during scrub.
https://bugs.webkit.org/show_bug.cgi?id=116986
Reviewed by Eric Carlson.
Source/WebCore:
Keep a count of the number of in-flight seek requests, and only issue a timeupdate
(which triggers a "seeked" event) when the final seek completes.
Test: media/video-seek-multiple.html
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
LayoutTests:
- media/video-seek-multiple-expected.txt: Added.
- media/video-seek-multiple.html: Added.
- 1:55 PM Changeset in webkit [150928] by
-
- 2 edits in trunk/LayoutTests
media/video-pause-immediately.html test failing on some platforms.
https://bugs.webkit.org/show_bug.cgi?id=116985
video-pause-immediately.html will fail on some platforms if the <video> element issues a
timeupdate event at currentTime=0. Fix the test by only removing the timeupdate listener
inside the currentTime>0 conditional.
Reviewed by Eric Carlson.
- media/video-pause-immediately.html:
- 1:43 PM Changeset in webkit [150927] by
-
- 2 edits in trunk/Source/WebCore
Remove unused code from PODArena
https://bugs.webkit.org/show_bug.cgi?id=116990
Reviewed by Sam Weinig.
PODArena is only used as a base class of PODFreeListArena so remove unused member functions and make all
members protected to make it impossible to use it without subclassing.
PODArena is a risky class to use since it doesn't return memory to the system unless the arena object is destroyed.
This was the reason why PODFreeListArea was added. An upcoming patch will merge PODArena with PODFreeListArena and
this is a small step towards that goal.
- platform/PODArena.h:
- 12:48 PM Changeset in webkit [150926] by
-
- 6 edits in trunk/Source/WebCore
Remove custom binding for Clipboard setDragImage function
https://bugs.webkit.org/show_bug.cgi?id=116422
Reviewed by Sam Weinig.
- bindings/js/JSClipboardCustom.cpp: Removed setDragImage binding.
- dom/Clipboard.cpp:
(WebCore::Clipboard::canSetDragImage): Added a condition that this is a drag
and drop clipboard. That used to be checked in the setDragImage binding.
(WebCore::Clipboard::setDragImage): Added a version that takes an Element
and calls through to the existing functions (in the legacy code path), or handles
both the Element and HTMLImageElement not-in-document cases (in the new code path).
- dom/Clipboard.h: Updated for changes above.
- dom/Clipboard.idl: Removed [Custom] from setDragImage.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleDrag): Call the new setDragImage instead of the
old setDragImageElement.
- 12:43 PM Changeset in webkit [150925] by
-
- 2 edits in trunk/Source/WebKit2
Return earlier if there's no session storage namespace
https://bugs.webkit.org/show_bug.cgi?id=116984
<rdar://problem/13976781>
Reviewed by Tim Horton.
If we can't find a session storage namespace, return before creating an entry in the m_storageAreasByConnection
hash map since then we'll crash trying to remove it later.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
- 12:41 PM Changeset in webkit [150924] by
-
- 22 edits2 deletes in trunk
Cleanup AudioSourceNode.idl from WebKit build.
https://bugs.webkit.org/show_bug.cgi?id=116905.
Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-29
Reviewed by Darin Adler.
AudioSourceNode.idl is not part of WebAudio Specifications anymore.
AudioNode is inherited directly in all the audio source nodes.
Source/WebCore:
No new tests. Current test cases will cover all the scenarios.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.list.am:
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/AudioSourceNode.h: Removed.
- Modules/webaudio/AudioSourceNode.idl: Removed.
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
- Modules/webaudio/MediaElementAudioSourceNode.h:
(MediaElementAudioSourceNode):
- Modules/webaudio/MediaElementAudioSourceNode.idl:
- Modules/webaudio/MediaStreamAudioDestinationNode.idl:
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
- Modules/webaudio/MediaStreamAudioSourceNode.h:
(MediaStreamAudioSourceNode):
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/OscillatorNode.idl:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
Tools:
- Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
- 12:32 PM Changeset in webkit [150923] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Add more cellular technologies into the NetworkInfo enum
https://bugs.webkit.org/show_bug.cgi?id=116982
PR 340189
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.
Provide more specific bandwidth speeds on different network
services our devices provide.
- WebCoreSupport/NetworkInfoClientBlackBerry.cpp:
(WebCore):
(WebCore::NetworkInfoClientBlackBerry::bandwidth):
- 12:26 PM Changeset in webkit [150922] by
-
- 3 edits2 adds in trunk
Optimize RenderText::offsetNext for 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=116877
Reviewed by Darin Adler.
Source/WebCore:
Previously, this function was always upconverting strings to 16 bits in
order to create a cursorMovementIterator. This patch adds a fast path
for ASCII and Latin-1 strings, which don't need this complicated cursor
movement logic.
I ran into this code because nextOffset showed up as a memory pig on a
memory profile of Mobile Gmail.
Test: editing/selection/move-by-character-brute-force.html
- rendering/RenderText.cpp:
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::nextOffset):
LayoutTests:
Test that caret movement works correctly for many code points.
- editing/selection/move-by-character-brute-force-expected.txt: Added.
- editing/selection/move-by-character-brute-force.html: Added.
- 12:24 PM Changeset in webkit [150921] by
-
- 5 edits in trunk
Fix more CMake GTK+ build issues after r150336
.:
- Source/cmake/OptionsGTK.cmake: Actually set the new output name variable
and be sure to set WTF_USE_EGL when EGL is enabled.
Source/WebKit2:
- CMakeLists.txt: We need to allow for setting the WebProcess output name, since
WebKitGTK+ expects it to be called WebKitWebProcess.
- PlatformGTK.cmake: No longer set WebProcess_EXECUTABLE_NAME as it's been replaced
by WebKit2_WebProcess_OUTPUT_NAME.
- 12:23 PM Changeset in webkit [150920] by
-
- 2 edits in trunk/Tools
Add Andrew Lo to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=116981
Reviewed by Rob Buis.
Adding Andrew Lo to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 11:57 AM Changeset in webkit [150919] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Correct copy command (form versus forms)
- WebCore.vcproj/copyForwardingHeaders.cmd:
- WebCore.vcxproj/copyForwardingHeaders.cmd:
- 11:57 AM Changeset in webkit [150918] by
-
- 2 edits in trunk/Tools
Adding myself as a committer.
Signed-off-by: Adenilson Cavalcanti <cavalcantii@gmail.com>
- 11:49 AM Changeset in webkit [150917] by
-
- 9 edits in trunk/Source/WebCore
[CSS Shapes] Fix style issues in BasicShapes
https://bugs.webkit.org/show_bug.cgi?id=116734
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-29
Reviewed by Alexandru Chiculita.
Fix indentation in BasicShapes.cpp, and change enums to respect the
style rules CamelCase instead of HAVING_UNDERSCORES.
No new tests, only style changes.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
- css/CSSBasicShapes.cpp:
(WebCore::buildRectangleString):
(WebCore::CSSBasicShapeRectangle::equals):
(WebCore::CSSBasicShapeCircle::equals):
(WebCore::CSSBasicShapeEllipse::equals):
(WebCore::CSSBasicShapePolygon::equals):
(WebCore::CSSBasicShapeInsetRectangle::equals):
- css/CSSBasicShapes.h:
(WebCore::CSSBasicShapeRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeCircle::type):
(WebCore::CSSBasicShapeEllipse::type):
(WebCore::CSSBasicShapePolygon::type):
- rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor):
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor):
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::canBlend):
(WebCore::BasicShapeRectangle::path):
(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapeInsetRectangle::path):
- rendering/style/BasicShapes.h:
(WebCore::BasicShapeRectangle::type):
(WebCore::BasicShapeCircle::type):
(WebCore::BasicShapeEllipse::type):
(WebCore::BasicShapePolygon::type):
(WebCore::BasicShapeInsetRectangle::type):
- 11:46 AM Changeset in webkit [150916] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] Handle Host-Only cookies
https://bugs.webkit.org/show_bug.cgi?id=116969
PR 338809
Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-05-29
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.
Adding support for host-only cookies (cookies with no
specified domains). These cookies should only be returned
when the host matches the cookie domain exactly.
Tested using Opera and Browser cookie test suite. Tested
that host cookies are being stored in it's own map using
Web Inspector.
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::checkAndTreatCookie):
(WebCore::CookieManager::findOrCreateCookieMap):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/ParsedCookie.h:
(WebCore::ParsedCookie::isHostOnly):
(ParsedCookie):
- 11:43 AM Changeset in webkit [150915] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] about:memory should use malloc_stats instead of mallinfo
https://bugs.webkit.org/show_bug.cgi?id=96420
Reviewed by Rob Buis.
PR 206297
Use mallopt to get malloc_stats.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::MemoryTracker::updateMemoryPeaks):
- 11:39 AM Changeset in webkit [150914] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Notify client of selection deletion
https://bugs.webkit.org/show_bug.cgi?id=116843
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-29
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR342106
Our change guard was preventing caret change notification to be sent to IMF.
This put us out of state when a selection was deleted because it is not a simple
single character deletion. Ensure that selection deletions always send a caret
update.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::deleteSelection):
(BlackBerry::WebKit::InputHandler::deleteTextRelativeToCursor):
(BlackBerry::WebKit::InputHandler::deleteText):
- 11:37 AM Changeset in webkit [150913] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use StringBuilder instead of + operator to build strings in AboutData
https://bugs.webkit.org/show_bug.cgi?id=116954
Patch by Rob Buis <rbuis@rim.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.
PR 206152
Internally reviewed by Konrad Piascik
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
(BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML):
(BlackBerry::WebKit::mallocStats):
(BlackBerry::WebKit::memoryPage):
(BlackBerry::WebKit::memoryPeaksToHtmlTable):
(BlackBerry::WebKit::memoryLivePage):
- 11:37 AM Changeset in webkit [150912] by
-
- 2 edits in trunk/Source/WebCore
Remove the size of DataVector in HTMLToken
https://bugs.webkit.org/show_bug.cgi?id=116931
Reviewed by Sam Weinig.
Merge https://chromium.googlesource.com/chromium/blink/+/7977721e62c471bfa17b84d82cd5d8243a4eb9a9.
Shink HTMLToken by 1.5 kB
HTMLToken has an inline vector for buffering characters during tokenization. We
originally picked the inline capacity of this buffer somewhat arbitrarily. This
CL tunes the number based on a somewhat non-scientific browse of a number of
popular web sites.
I (abarth) instrumented content_shell to log the length of each complete DataVector. I
then browsed around a variety of web sites to collect data. The 99% percentile
of DataVector lengths was just shy of 250 characters. I rounded that up to 256
because powers of two are pretty. That means we'll malloc an external buffer
less than 1% of the time, which seems fine.
- html/parser/HTMLToken.h:
(HTMLToken):
- 11:28 AM Changeset in webkit [150911] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening, managing media layout tests failures on GTK WK2.
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 11:15 AM Changeset in webkit [150910] by
-
- 4 edits in trunk/Source/WebCore
[Windows] Build correction after r150837
New 'forms' sub-folder of html needs to be included in
copy operations.
- WebCore.vcproj/copyForwardingHeaders.cmd: copy html/forms.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Use correct
'obj32' folder for build output.
- WebCore.vcxproj/copyForwardingHeaders.cmd: copy html/forms.
- 10:47 AM Changeset in webkit [150909] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Radio Button UX updates.
https://bugs.webkit.org/show_bug.cgi?id=116881
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.
BlackBerry PR 342322.
Internally Reviewed by Jeff Rogers.
Change images.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintRadio):
- 10:41 AM Changeset in webkit [150908] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Datetime string is not centred in form controls.
https://bugs.webkit.org/show_bug.cgi?id=100760
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-29
Reviewed by Rob Buis.
BlackBerry PR 343512
Internally Reviewed by Jeff Rogers.
Adjust margin for inner text node of datetime form controls.
- css/themeBlackBerry.css:
(input::-webkit-date-and-time-value):
- 10:23 AM Changeset in webkit [150907] by
-
- 3 edits in trunk/Source/WebCore
[Windows] Build correction after r150876
A clean build will now fail because the BaseMultipleFieldsDateAndTimeInputType sources have
been removed, but are still referenced in the project file.
- WebCore.vcxproj/WebCore.vcxproj: Remove reference to BaseMultipleFieldsDateAndTimeInputType
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto
- 10:22 AM Changeset in webkit [150906] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening, managing accessibility layout tests failures on GTK WK2.
- platform/gtk-wk2/TestExpectations:
- 10:11 AM Changeset in webkit [150905] by
-
- 6 edits4 adds in trunk
Support the 'onended' EventListener property for AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=116798
Reviewed by Eric Carlson.
Source/WebCore:
Tests: webaudio/audiobuffersource-ended.html
webaudio/oscillator-ended.html
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::setOnended): Set m_hasEndedListener.
(WebCore::AudioScheduledSourceNode::finish): Call notifyEndedDispatch on the main thread.
(WebCore::AudioScheduledSourceNode::notifyEndedDispatch): Call notifyEnded().
(WebCore::AudioScheduledSourceNode::notifyEnded): Call the onended event listener.
- Modules/webaudio/AudioScheduledSourceNode.h:
(WebCore::AudioScheduledSourceNode::onended): Added boilerplate.
- Modules/webaudio/AudioBufferSourceNode.idl: Added the onerror attribute.
- Modules/webaudio/OscillatorNode.idl: Ditto.
LayoutTests:
- webaudio/audiobuffersource-ended-expected.txt: Added.
- webaudio/audiobuffersource-ended.html: Added.
- webaudio/oscillator-ended-expected.txt: Added.
- webaudio/oscillator-ended.html: Added.
- 9:54 AM Changeset in webkit [150904] by
-
- 16 edits in trunk
[CSS Shapes] Support parsing inset-rectangle shapes
https://bugs.webkit.org/show_bug.cgi?id=116638
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-29
Reviewed by Dean Jackson.
Source/WebCore:
Add parsing for inset-rectangle. It's very similar to parsing for
rectangle.
No new tests, updated existing tests to cover this.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Add support for inset rectangles.
(WebCore::basicShapeForValue): Add support for inset rectangles.
- css/CSSBasicShapes.cpp:
(WebCore::buildInsetRectangleString): Create an inset-rectangle css
string.
(WebCore::CSSBasicShapeInsetRectangle::cssText): Convert inset
rectangle shape to a CSS string.
(WebCore::CSSBasicShapeInsetRectangle::equals): Compare two inset
rectangles.
(WebCore::CSSBasicShapeInsetRectangle::serializeResolvingVariables):
Create an inset rectangle string, with CSS variables resolved.
(WebCore::CSSBasicShapeInsetRectangle::hasVariableReference):
Determine if this inset rectangle has any CSS Variable references.
- css/CSSBasicShapes.h:
(CSSBasicShapeInsetRectangle): Add inset rectangle class. This is a
direct representation of the CSS property. All the methods below
are just simple getters and setters, along with a construtor and a
factory method.
(WebCore::CSSBasicShapeInsetRectangle::create):
(WebCore::CSSBasicShapeInsetRectangle::top):
(WebCore::CSSBasicShapeInsetRectangle::right):
(WebCore::CSSBasicShapeInsetRectangle::bottom):
(WebCore::CSSBasicShapeInsetRectangle::left):
(WebCore::CSSBasicShapeInsetRectangle::radiusX):
(WebCore::CSSBasicShapeInsetRectangle::radiusY):
(WebCore::CSSBasicShapeInsetRectangle::setTop):
(WebCore::CSSBasicShapeInsetRectangle::setRight):
(WebCore::CSSBasicShapeInsetRectangle::setBottom):
(WebCore::CSSBasicShapeInsetRectangle::setLeft):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusX):
(WebCore::CSSBasicShapeInsetRectangle::setRadiusY):
(WebCore::CSSBasicShapeInsetRectangle::type):
(WebCore::CSSBasicShapeInsetRectangle::CSSBasicShapeInsetRectangle):
(WebCore):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBasicShapeInsetRectangle): Parse the
inset-rectangle CSS property and create a
CSSBasicShapeInsetRectangle.
(WebCore::CSSParser::parseBasicShape): Add a call to parse
inset-rectangle.
- rendering/ExclusionShapeInsideInfo.cpp:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Disable
inset-rectangles, since only the parsing has been implemented so
far.
- rendering/ExclusionShapeOutsideInfo.cpp:
(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Disable
inset-rectangles, since only the parsing has been implemented so
far.
- rendering/style/BasicShapes.cpp:
(WebCore::BasicShapeInsetRectangle::path): Calculate the Path for an
inset-rectangle.
(WebCore::BasicShapeInsetRectangle::blend): Blend two inset rectangles
together at a point depending on the "progress" and return the
blended rectangle.
- rendering/style/BasicShapes.h:
(BasicShapeInsetRectangle): Add higher level inset rectangle class.
This is used outside of the CSS representation. The methods below
are just simple getters and setters, along with a constructor and
a factory method.
(WebCore::BasicShapeInsetRectangle::create):
(WebCore::BasicShapeInsetRectangle::top):
(WebCore::BasicShapeInsetRectangle::right):
(WebCore::BasicShapeInsetRectangle::bottom):
(WebCore::BasicShapeInsetRectangle::left):
(WebCore::BasicShapeInsetRectangle::cornerRadiusX):
(WebCore::BasicShapeInsetRectangle::cornerRadiusY):
(WebCore::BasicShapeInsetRectangle::setTop):
(WebCore::BasicShapeInsetRectangle::setRight):
(WebCore::BasicShapeInsetRectangle::setBottom):
(WebCore::BasicShapeInsetRectangle::setLeft):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX):
(WebCore::BasicShapeInsetRectangle::setCornerRadiusY):
(WebCore::BasicShapeInsetRectangle::type):
(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle):
LayoutTests:
Updated to test for inset-rectangle cases.
- fast/exclusions/parsing/parsing-shape-inside-expected.txt:
- fast/exclusions/parsing/parsing-shape-lengths-expected.txt:
- fast/exclusions/parsing/script-tests/parsing-shape-lengths.js:
- fast/exclusions/parsing/script-tests/parsing-test-utils.js:
- 9:38 AM Changeset in webkit [150903] by
-
- 4 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150898. <rdar://problem/14007430>
- 9:34 AM Changeset in webkit [150902] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150863. <rdar://problem/13991927>
- 9:30 AM Changeset in webkit [150901] by
-
- 6 edits in trunk/Source/WebCore
Move computed style extraction out of CSSComputedStyleDeclaration.
<http://webkit.org/b/116965>
Reviewed by Antti Koivisto.
Make it possible to get computed CSSValues from a Node without creating a CSSOM
style declaration object.
The bulk of the logic moves to a new class; ComputedStyleExtractor, which can be created
on the stack, and takes the same setup variables as CSSComputedStyleDeclaration.
This is prep to enable futuristic optimizations in editing and elsewhere.
- css/CSSComputedStyleDeclaration.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Create a ComputedStyleExtractor to do the work!
(WebCore::ComputedStyleExtractor::currentColorOrValidColor):
(WebCore::ComputedStyleExtractor::valueForFilter):
(WebCore::ComputedStyleExtractor::ComputedStyleExtractor):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::styledNode):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForSidesShorthand):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):
- css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
(WebCore::ComputedStyleExtractor::svgPropertyValue):
Moved all of these from CSSComputedStyleDeclaration to the new class.
- rendering/style/RenderStyle.h:
- svg/SVGPaint.h:
Have these two befriend ComputedStyleExtractor.
- 9:22 AM Changeset in webkit [150900] by
-
- 2 edits in trunk/Source/WebCore
Another attempt to fix windows build.
Not reviewed.
- css/CSSFontSelector.h:
- 9:09 AM Changeset in webkit [150899] by
-
- 2 edits in trunk/Source/WebCore
Try to fix window build.
Not reviewed.
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionFontDataCacheKey::computeHash):
- 9:04 AM Changeset in webkit [150898] by
-
- 4 edits in trunk/Source/WebCore
Fix the firing of m_paintRelatedMilestonesTimer
https://bugs.webkit.org/show_bug.cgi?id=116919
Reviewed by Tim Horton.
r150671 intended to change things so that paint-related milestones
only fire when painting has actually happened, so that WebKit clients
are notified when we actually have bits to present.
However, it made an incorrect assumption that painting would happen
inside of flushCompositingState(). This is not the case; flushCompositingState()
will just dirty CALayers, and later on Core Animation will ask us to paint them.
This incorrect assumption meant that we would never start the
m_paintRelatedMilestonesTimer, so never fire the milestones.
Fix by starting the m_paintRelatedMilestonesTimer via the RenderLayerBacking
paintContents call back. At this time we know we're painting, so we can both
set the FrameView's last paint time, and start up the timer. We also only
want to start the timer if there are pending milestones.
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
(WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::didPaintBacking):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 8:49 AM Changeset in webkit [150897] by
-
- 11 edits in trunk/Source/WebCore
Share FontGlyphs
https://bugs.webkit.org/show_bug.cgi?id=116863
Reviewed by Anreas Kling.
Style system generates many Font objects that are identical or similar enough to have identical FontGlyphs.
We can figure out that the FontGlyphs are going to be the same and share them. This reduces memory usage.
It also improves performance as the glyph cache and the width cache hang from FontGlyphs and their hit rate
increases.
On PLT3 this takes the number of live FontGlyphs at the end from 40k+ to <1k. Width cache hit rate improves
from ~42% to ~55%.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::CSSFontSelector):
Add unique id we can use in cache key.
(WebCore::CSSFontSelector::dispatchInvalidationCallbacks):
Bump the version number on invalidation so we don't reuse cache entries after web font is loaded.
(WebCore::CSSFontSelector::resolvesFamilyFor):
Test if FontSelector is needed for resolving a particular FontDescription.
- css/CSSFontSelector.h:
- page/Settings.cpp:
(WebCore::setGenericFontFamilyMap):
Invalidate the cache if standard font settings change.
- platform/graphics/Font.cpp:
(FontGlyphsCacheKey):
(FontGlyphsCacheEntry):
(WebCore::operator==):
(WebCore::fontGlyphsCache):
(WebCore::invalidateFontGlyphsCache):
(WebCore::makeFontSelectorFlags):
(WebCore::makeFontGlyphsCacheKey):
The cache key consists of
- all families.
- shared key with the lower level FontData cache (FontCache), guaranteeing FontDatas would be identical.
- font selector specific keys.
These guarantee the FontData will be identical.
(WebCore::computeFontGlyphsCacheHash):
(WebCore::pruneUnreferencedFromFontGlyphsCache):
Don't accumulate unused entries.
(WebCore::retrieveOrAddCachedFontGlyphs):
(WebCore::Font::update):
- platform/graphics/Font.h:
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
(WebCore::FontPlatformDataCacheKey::isHashTableDeletedValue):
(WebCore::FontPlatformDataCacheKey::operator==):
(FontPlatformDataCacheKey):
(WebCore::computeHash):
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionFontDataCacheKey::FontDescriptionFontDataCacheKey):
(WebCore::FontDescriptionFontDataCacheKey::makeFlagKey):
(WebCore::FontDescriptionFontDataCacheKey::operator==):
(WebCore::FontDescriptionFontDataCacheKey::operator!=):
(WebCore::FontDescriptionFontDataCacheKey::computeHash):
Separate part of the key for sharing.
(FontDescriptionFontDataCacheKey):
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::releaseFontData):
- platform/graphics/FontFallbackList.h:
(WebCore::FontGlyphs::create):
(WebCore::FontGlyphs::~FontGlyphs):
Remove invalidate(). If FontGlyphs needs invalidation it is reconstructed.
- platform/graphics/FontSelector.h:
- 8:37 AM Changeset in webkit [150896] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Use lazily-backed backingstore tiles
https://bugs.webkit.org/show_bug.cgi?id=116879
Internal PR 344523
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-29
Reviewed by Carlos Garcia Campos.
Informally reviewed by Arvid Nilsson and Mike Lattanzio.
As a consequence, also don't use fixed-size
shared pixmap buffers for these tiles anymore.
- WebKitSupport/AboutData.cpp:
(BlackBerry::WebKit::configPage):
- WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::nativeBuffer):
- WebKitSupport/SurfacePool.cpp:
(BlackBerry::WebKit::SurfacePool::initialize):
- WebKitSupport/SurfacePool.h:
(SurfacePool):
- 8:24 AM Changeset in webkit [150895] by
-
- 2 edits1 add in trunk/Source/WebKit/qt
[Qt] Add all plugins.qmltypes files and update qmldir files
Patch by Liang Qi <liang.qi@digia.com> on 2013-05-29
Reviewed by Simon Hausmann.
These are required for code completion in Qt Creator.
- declarative/plugins.qmltypes: Added.
- declarative/qmldir:
- 8:23 AM Changeset in webkit [150894] by
-
- 1 edit1 delete in trunk/Source/WebCore
Remove unused file PlatformGestureEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=116894
Reviewed by Darin Adler.
This was added in https://bugs.webkit.org/show_bug.cgi?id=49345 but
not removed in https://bugs.webkit.org/show_bug.cgi?id=77492 which
removed most of that code again.
- platform/PlatformGestureRecognizer.cpp: Removed.
- 7:34 AM Changeset in webkit [150893] by
-
- 8 edits2 adds in trunk
[WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
https://bugs.webkit.org/show_bug.cgi?id=116683
Reviewed by Noam Rosenthal.
Source/WebKit2:
WKViewUserViewportToContents now converts WebView coordinates to
page contents coordinates, taking into account factors as content
scale and scroll, and also device scale.
The function WKViewUserViewportToScene was added to convert WebView
coordinates to the coordinates of the canvas/scene where the view
is drawn, and EwkView was fixed to use it, instead of
WKViewUserViewportToContents.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
(WKViewUserViewportToScene):
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/efl/EwkView.cpp:
(EwkView::createGLSurface):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::userViewportToContents):
(WebKit):
(WebKit::WebView::userViewportToScene):
(WebKit::WebView::transformToScene):
- UIProcess/CoordinatedGraphics/WebView.h:
(WebView):
Tools:
A coordinates conversion test for WKViewUserViewportToContents was
added to WebKit2 API tests.
- TestWebKitAPI/PlatformEfl.cmake:
- TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- 7:21 AM Changeset in webkit [150892] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Unskipping passing test.
https://bugs.webkit.org/show_bug.cgi?id=70907
https://bugs.webkit.org/show_bug.cgi?id=93231
https://bugs.webkit.org/show_bug.cgi?id=89645
https://bugs.webkit.org/show_bug.cgi?id=109291
https://bugs.webkit.org/show_bug.cgi?id=92543
https://bugs.webkit.org/show_bug.cgi?id=82895
https://bugs.webkit.org/show_bug.cgi?id=87395
https://bugs.webkit.org/show_bug.cgi?id=87631
https://bugs.webkit.org/show_bug.cgi?id=89473
https://bugs.webkit.org/show_bug.cgi?id=92490
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-29
- platform/qt-5.0-wk2/TestExpectations:
- 7:18 AM Changeset in webkit [150891] by
-
- 2 edits in trunk/Tools
Unreviewed. Update my info.
Patch by Yong Li <yong.li.webkit@outlook.com> on 2013-05-29
- Scripts/webkitpy/common/config/contributors.json:
- 6:24 AM Changeset in webkit [150890] by
-
- 3 edits in trunk/Source/WebCore
[texmap][GStreamer][GTK] Composited Video support
https://bugs.webkit.org/show_bug.cgi?id=86410
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-05-29
Reviewed by Noam Rosenthal.
Enable the video accelerated compositing using the WebKit's
TextureMapper.
This patch does not use hardware accelerated video decoding. It
provides a generic path for system memory buffers.
This new functionality is only available when the coordinated graphics
system is not used.
No new tests, already covered by existing tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): update the
texture content with the new received video buffer.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): choose to
use the accelerated compositing or the normal code path
(WebCore::MediaPlayerPrivateGStreamerBase::paint): if accelerated
compositing is used this method is halted.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper): get
a texture from the pool and draws it if it is already available.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformLayer): returns itself
(WebCore::MediaPlayerPrivateGStreamerBase::supportsAcceleratedRendering):
returns true
- 6:19 AM Changeset in webkit [150889] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding flaky failure expectations for two perf/ layout tests.
- platform/gtk/TestExpectations:
- 6:05 AM Changeset in webkit [150888] by
-
- 1 copy in releases/WebKitGTK/webkit-2.1.1
Tagging the WebKitGTK+ 2.1.1 release
- 5:53 AM Changeset in webkit [150887] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk-wk1/TestExpectations: Remove an unnecessary expectation.
- platform/gtk/TestExpectations: Add timeout expectations for tests that are currently timing out.
- 5:43 AM Changeset in webkit [150886] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as committer in contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 5:19 AM Changeset in webkit [150885] by
-
- 4 edits in trunk
Unreviewed. Update NEWS and Versions.m4 for 2.1.1 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.1.1.
- 5:15 AM Changeset in webkit [150884] by
-
- 6 edits in trunk
Unreviewed. Fix make distcheck.
.:
- GNUmakefile.am: Add WebKitFeatures.h and WebKitFeatures.txt to
DISTCLEANFILES.
Source/WebKit2:
- GNUmakefile.am: Add WebCoreLayerGtk2.a to DISTCLEANFILES.
Tools:
- TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
DISTCLEANFILES.
- 4:51 AM Changeset in webkit [150883] by
-
- 2 edits in trunk/Tools
Unreviewed: update my email address in contributors.json.
Patch by Mary Wu <mawu@blackberry.com> on 2013-05-29
- Scripts/webkitpy/common/config/contributors.json:
- 4:01 AM Changeset in webkit [150882] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.
- Target.pri: Added missing include path.
- 3:57 AM Changeset in webkit [150881] by
-
- 4 edits4 adds in trunk
[CSS Regions] Content that has overflow: scroll cannot be scrolled by dragging the scroll thumbs with the mouse
https://bugs.webkit.org/show_bug.cgi?id=113703
Patch by Mihai Maerean <Mihai Maerean> on 2013-05-29
Reviewed by Darin Adler.
Source/WebCore:
The point inside a box that's inside a region has its coordinates relative to the region, not the FlowThread
that is its container in the RenderObject tree.
Previously, the coordinates were computed relatively to the FlowThread which doesn't really have a location in
the page.
Tests: fast/regions/drag-scrollbars-of-content.html
fast/regions/hover-in-second-region.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::offsetFromContainer):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):
LayoutTests:
- fast/regions/drag-scrollbars-of-content-expected.html: Added.
- fast/regions/drag-scrollbars-of-content.html: Added.
- fast/regions/hover-in-second-region-expected.html: Added.
- fast/regions/hover-in-second-region.html: Added.
- 3:20 AM Changeset in webkit [150880] by
-
- 2 edits in trunk/Source/WebCore
Fix dumb typo in r150879.
- editing/htmlediting.cpp:
(WebCore::nextLeafNode):
- 1:57 AM Changeset in webkit [150879] by
-
- 7 edits in trunk/Source/WebCore
Move leaf Node traversal helpers to htmlediting.cpp
<http://webkit.org/b/116940>
Reviewed by Antti Koivisto.
Move Node::previousLeafNode() and Node::nextLeafNode() to htmlediting.cpp along with their helpers.
Fixes an 8-year old FIXME. \o/
- dom/Node.h:
- dom/Node.cpp:
- dom/Position.cpp:
(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):
- editing/VisibleUnits.cpp:
(WebCore::previousLeafWithSameEditability):
(WebCore::nextLeafWithSameEditability):
- editing/htmlediting.h:
- editing/htmlediting.cpp:
(WebCore::previousNodeConsideringAtomicNodes):
(WebCore::nextNodeConsideringAtomicNodes):
(WebCore::previousLeafNode):
(WebCore::nextLeafNode):
- 1:56 AM Changeset in webkit [150878] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Missing files from build after r150853
https://bugs.webkit.org/show_bug.cgi?id=116932
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-29
Reviewed by Csaba Osztrogonác.
- Target.pri: Added the CFURLExtras.{cpp,h} files to the projectfile.
- 1:53 AM Changeset in webkit [150877] by
-
- 2 edits in trunk/Source/WebCore
PresentationAttributeCacheCleaner::m_hitCount is never initialized
https://bugs.webkit.org/show_bug.cgi?id=116946
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/70be7ddc41141ef6dec7795d37842c27dab2e194.
- dom/StyledElement.cpp:
(WebCore::PresentationAttributeCacheCleaner::PresentationAttributeCacheCleaner):
- 1:47 AM Changeset in webkit [150876] by
-
- 47 edits228 deletes in trunk
Remove ENABLE_INPUT_MULTIPLE_FIELDS_UI.
https://bugs.webkit.org/show_bug.cgi?id=116796
Reviewed by Ryosuke Niwa.
Source/WebCore:
This feature was used only by Chromium port.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/html.css:
(input::-webkit-date-and-time-value):
- dom/Element.cpp:
- dom/Element.h:
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
- html/BaseChooserOnlyDateAndTimeInputType.h:
- html/BaseMultipleFieldsDateAndTimeInputType.cpp: Removed.
- html/BaseMultipleFieldsDateAndTimeInputType.h: Removed.
- html/DateInputType.cpp:
- html/DateInputType.h:
(DateInputType):
- html/DateTimeFieldsState.cpp: Removed.
- html/DateTimeFieldsState.h: Removed.
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
(DateTimeInputType):
- html/DateTimeLocalInputType.cpp:
- html/DateTimeLocalInputType.h:
(DateTimeLocalInputType):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::HTMLInputElement):
(WebCore):
- html/HTMLInputElement.h:
(HTMLInputElement):
- html/InputType.cpp:
- html/InputType.h:
(InputType):
- html/MonthInputType.cpp:
- html/MonthInputType.h:
(MonthInputType):
- html/TimeInputType.cpp:
- html/TimeInputType.h:
(TimeInputType):
- html/WeekInputType.cpp:
- html/WeekInputType.h:
(WeekInputType):
- html/shadow/ClearButtonElement.cpp: Removed.
- html/shadow/ClearButtonElement.h: Removed.
- html/shadow/DateTimeEditElement.cpp: Removed.
- html/shadow/DateTimeEditElement.h: Removed.
- html/shadow/DateTimeFieldElement.cpp: Removed.
- html/shadow/DateTimeFieldElement.h: Removed.
- html/shadow/DateTimeFieldElements.cpp: Removed.
- html/shadow/DateTimeFieldElements.h: Removed.
- html/shadow/DateTimeNumericFieldElement.cpp: Removed.
- html/shadow/DateTimeNumericFieldElement.h: Removed.
- html/shadow/DateTimeSymbolicFieldElement.cpp: Removed.
- html/shadow/DateTimeSymbolicFieldElement.h: Removed.
- html/shadow/PickerIndicatorElement.cpp: Removed.
- html/shadow/PickerIndicatorElement.h: Removed.
- page/ChromeClient.h:
(ChromeClient):
- platform/LocalizedStrings.h:
(WebCore):
- platform/text/PlatformLocale.cpp:
- platform/text/PlatformLocale.h:
(Locale):
- rendering/RenderDetailsMarker.cpp:
- rendering/RenderDetailsMarker.h:
- rendering/RenderObject.h:
(RenderObject):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WTF:
- wtf/FeatureDefines.h:
LayoutTests:
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-ax-aria-attributes.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-ax-value-changed-notification.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-blur-and-focus-events.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-change-layout-by-value.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-change-and-input-events.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-fallback-format.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-reset-value-after-reloads.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-spinbutton-change-and-input-events.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-validity-badinput.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-value-set-empty.html: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-wheel-event-expected.txt: Removed.
- fast/forms/date-multiple-fields/date-multiple-fields-wheel-event.html: Removed.
- fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-fallback-format.html: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-validity-badinput.html: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/datetime-multiple-fields/datetime-multiple-fields-value-set-empty.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-aria-attributes.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-ax-value-changed-notification.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-blur-and-focus-events.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-change-layout-by-value.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-change-and-input-events.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-fallback-format.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-reset-value-after-reloads.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-spinbutton-change-and-input-events.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-validity-badinput.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-value-set-empty.html: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event-expected.txt: Removed.
- fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-wheel-event.html: Removed.
- fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-aria-attributes.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-ax-value-changed-notification.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-blur-and-focus-events.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-change-layout-by-value.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-change-and-input-events.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-fallback-format.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-keyboard-events.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-reset-value-after-reloads.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-spinbutton-change-and-input-events.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-validity-badinput.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-value-set-empty.html: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-wheel-event-expected.txt: Removed.
- fast/forms/month-multiple-fields/month-multiple-fields-wheel-event.html: Removed.
- fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
- fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-blur-and-focus-events.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-layout-by-value.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-2.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type-on-focus.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-change-type.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-change-and-input-events.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-fallback-format.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-style-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-focus-style.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-localization.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-losing-renderer-on-click.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-mouse-events.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-narrow-width-scroll.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-reset-value-after-reload.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-change-and-input-events.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-static-relayout-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-static-relayout.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-step-attribute.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-validity-badinput.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-wheel-event-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-wheel-event.html: Removed.
- fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-ax-aria-attributes.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-ax-value-changed-notification.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-blur-and-focus-events.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-change-layout-by-value.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-change-and-input-events.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore-expected.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-clearbutton-visibility-after-restore.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-fallback-format-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-fallback-format.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-keyboard-events.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-mouse-events.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-reset-value-after-reloads.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-spinbutton-change-and-input-events.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-stepup-stepdown-from-renderer.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-validity-badinput.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-value-set-empty.html: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-wheel-event-expected.txt: Removed.
- fast/forms/week-multiple-fields/week-multiple-fields-wheel-event.html: Removed.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 1:36 AM Changeset in webkit [150875] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove SnowLeopard expected results.
Rubber-stamped by Andreas Kling.
- platform/mac-snowleopard: Removed.
- platform/mac-snowleopard/animations: Removed.
- platform/mac-snowleopard/canvas: Removed.
- platform/mac-snowleopard/canvas/philip: Removed.
- platform/mac-snowleopard/canvas/philip/tests: Removed.
- platform/mac-snowleopard/compositing: Removed.
- platform/mac-snowleopard/compositing/color-matching: Removed.
- platform/mac-snowleopard/compositing/framesets: Removed.
- platform/mac-snowleopard/compositing/geometry: Removed.
- platform/mac-snowleopard/compositing/iframes: Removed.
- platform/mac-snowleopard/compositing/images: Removed.
- platform/mac-snowleopard/compositing/layer-creation: Removed.
- platform/mac-snowleopard/compositing/masks: Removed.
- platform/mac-snowleopard/compositing/overflow: Removed.
- platform/mac-snowleopard/compositing/reflections: Removed.
- platform/mac-snowleopard/compositing/repaint: Removed.
- platform/mac-snowleopard/compositing/scaling: Removed.
- platform/mac-snowleopard/compositing/shadows: Removed.
- platform/mac-snowleopard/compositing/tiling: Removed.
- platform/mac-snowleopard/compositing/transitions: Removed.
- platform/mac-snowleopard/compositing/video: Removed.
- platform/mac-snowleopard/compositing/visibility: Removed.
- platform/mac-snowleopard/compositing/webgl: Removed.
- platform/mac-snowleopard/css1: Removed.
- platform/mac-snowleopard/css1/box_properties: Removed.
- platform/mac-snowleopard/css1/cascade: Removed.
- platform/mac-snowleopard/css1/classification: Removed.
- platform/mac-snowleopard/css1/color_and_background: Removed.
- platform/mac-snowleopard/css1/font_properties: Removed.
- platform/mac-snowleopard/css1/formatting_model: Removed.
- platform/mac-snowleopard/css1/pseudo: Removed.
- platform/mac-snowleopard/css1/text_properties: Removed.
- platform/mac-snowleopard/css1/units: Removed.
- platform/mac-snowleopard/css2.1: Removed.
- platform/mac-snowleopard/css2.1/20110323: Removed.
- platform/mac-snowleopard/css3: Removed.
- platform/mac-snowleopard/css3/filters: Removed.
- platform/mac-snowleopard/css3/flexbox: Removed.
- platform/mac-snowleopard/css3/images: Removed.
- platform/mac-snowleopard/css3/selectors3: Removed.
- platform/mac-snowleopard/css3/selectors3/html: Removed.
- platform/mac-snowleopard/css3/selectors3/xhtml: Removed.
- platform/mac-snowleopard/css3/selectors3/xml: Removed.
- platform/mac-snowleopard/editing: Removed.
- platform/mac-snowleopard/editing/input: Removed.
- platform/mac-snowleopard/editing/inserting: Removed.
- platform/mac-snowleopard/editing/pasteboard: Removed.
- platform/mac-snowleopard/editing/selection: Removed.
- platform/mac-snowleopard/editing/unsupported-content: Removed.
- platform/mac-snowleopard/fast: Removed.
- platform/mac-snowleopard/fast/backgrounds: Removed.
- platform/mac-snowleopard/fast/backgrounds/repeat: Removed.
- platform/mac-snowleopard/fast/backgrounds/size: Removed.
- platform/mac-snowleopard/fast/block: Removed.
- platform/mac-snowleopard/fast/block/basic: Removed.
- platform/mac-snowleopard/fast/block/float: Removed.
- platform/mac-snowleopard/fast/block/margin-collapse: Removed.
- platform/mac-snowleopard/fast/block/positioning: Removed.
- platform/mac-snowleopard/fast/borders: Removed.
- platform/mac-snowleopard/fast/canvas: Removed.
- platform/mac-snowleopard/fast/css: Removed.
- platform/mac-snowleopard/fast/dom: Removed.
- platform/mac-snowleopard/fast/encoding: Removed.
- platform/mac-snowleopard/fast/forms: Removed.
- platform/mac-snowleopard/fast/forms/file: Removed.
- platform/mac-snowleopard/fast/forms/range: Removed.
- platform/mac-snowleopard/fast/gradients: Removed.
- platform/mac-snowleopard/fast/images: Removed.
- platform/mac-snowleopard/fast/inline: Removed.
- platform/mac-snowleopard/fast/layers: Removed.
- platform/mac-snowleopard/fast/lists: Removed.
- platform/mac-snowleopard/fast/multicol: Removed.
- platform/mac-snowleopard/fast/multicol/span: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-lr: Removed.
- platform/mac-snowleopard/fast/multicol/vertical-rl: Removed.
- platform/mac-snowleopard/fast/overflow: Removed.
- platform/mac-snowleopard/fast/parser: Removed.
- platform/mac-snowleopard/fast/preloader: Removed.
- platform/mac-snowleopard/fast/reflections: Removed.
- platform/mac-snowleopard/fast/repaint: Removed.
- platform/mac-snowleopard/fast/replaced: Removed.
- platform/mac-snowleopard/fast/ruby: Removed.
- platform/mac-snowleopard/fast/selectors: Removed.
- platform/mac-snowleopard/fast/table: Removed.
- platform/mac-snowleopard/fast/text: Removed.
- platform/mac-snowleopard/fast/text/international: Removed.
- platform/mac-snowleopard/fast/text/whitespace: Removed.
- platform/mac-snowleopard/fast/writing-mode: Removed.
- platform/mac-snowleopard/fast/xsl: Removed.
- platform/mac-snowleopard/fonts: Removed.
- platform/mac-snowleopard/fullscreen: Removed.
- platform/mac-snowleopard/http: Removed.
- platform/mac-snowleopard/http/tests: Removed.
- platform/mac-snowleopard/http/tests/inspector: Removed.
- platform/mac-snowleopard/http/tests/security: Removed.
- platform/mac-snowleopard/http/tests/security/contentSecurityPolicy: Removed.
- platform/mac-snowleopard/http/tests/xmlhttprequest: Removed.
- platform/mac-snowleopard/http/tests/xmlhttprequest/web-apps: Removed.
- platform/mac-snowleopard/mathml: Removed.
- platform/mac-snowleopard/media: Removed.
- platform/mac-snowleopard/platform: Removed.
- platform/mac-snowleopard/platform/mac: Removed.
- platform/mac-snowleopard/platform/mac/compositing: Removed.
- platform/mac-snowleopard/platform/mac/compositing/canvas: Removed.
- platform/mac-snowleopard/platform/mac/editing: Removed.
- platform/mac-snowleopard/platform/mac/editing/selection: Removed.
- platform/mac-snowleopard/platform/mac/fast: Removed.
- platform/mac-snowleopard/platform/mac/fast/loader: Removed.
- platform/mac-snowleopard/platform/mac/fast/text: Removed.
- platform/mac-snowleopard/platform/mac/fast/text/international: Removed.
- platform/mac-snowleopard/platform/mac/scrollbars: Removed.
- platform/mac-snowleopard/plugins: Removed.
- platform/mac-snowleopard/printing: Removed.
- platform/mac-snowleopard/scrollbars: Removed.
- platform/mac-snowleopard/sputnik: Removed.
- platform/mac-snowleopard/sputnik/Unicode: Removed.
- platform/mac-snowleopard/svg: Removed.
- platform/mac-snowleopard/svg/W3C-I18N: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1: Removed.
- platform/mac-snowleopard/svg/W3C-SVG-1.1-SE: Removed.
- platform/mac-snowleopard/svg/as-background-image: Removed.
- platform/mac-snowleopard/svg/as-border-image: Removed.
- platform/mac-snowleopard/svg/as-image: Removed.
- platform/mac-snowleopard/svg/as-object: Removed.
- platform/mac-snowleopard/svg/batik: Removed.
- platform/mac-snowleopard/svg/batik/paints: Removed.
- platform/mac-snowleopard/svg/carto.net: Removed.
- platform/mac-snowleopard/svg/clip-path: Removed.
- platform/mac-snowleopard/svg/css: Removed.
- platform/mac-snowleopard/svg/custom: Removed.
- platform/mac-snowleopard/svg/dom: Removed.
- platform/mac-snowleopard/svg/dynamic-updates: Removed.
- platform/mac-snowleopard/svg/filters: Removed.
- platform/mac-snowleopard/svg/foreignObject: Removed.
- platform/mac-snowleopard/svg/hixie: Removed.
- platform/mac-snowleopard/svg/hixie/data-types: Removed.
- platform/mac-snowleopard/svg/hixie/error: Removed.
- platform/mac-snowleopard/svg/hixie/intrinsic: Removed.
- platform/mac-snowleopard/svg/hixie/mixed: Removed.
- platform/mac-snowleopard/svg/hixie/perf: Removed.
- platform/mac-snowleopard/svg/hixie/processing-model: Removed.
- platform/mac-snowleopard/svg/hixie/rendering-model: Removed.
- platform/mac-snowleopard/svg/hixie/text: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox: Removed.
- platform/mac-snowleopard/svg/hixie/viewbox/preserveAspectRatio: Removed.
- platform/mac-snowleopard/svg/in-html: Removed.
- platform/mac-snowleopard/svg/overflow: Removed.
- platform/mac-snowleopard/svg/repaint: Removed.
- platform/mac-snowleopard/svg/text: Removed.
- platform/mac-snowleopard/svg/transforms: Removed.
- platform/mac-snowleopard/svg/webarchive: Removed.
- platform/mac-snowleopard/svg/wicd: Removed.
- platform/mac-snowleopard/svg/zoom: Removed.
- platform/mac-snowleopard/svg/zoom/page: Removed.
- platform/mac-snowleopard/tables: Removed.
- platform/mac-snowleopard/tables/mozilla: Removed.
- platform/mac-snowleopard/tables/mozilla/bugs: Removed.
- platform/mac-snowleopard/tables/mozilla/collapsing_borders: Removed.
- platform/mac-snowleopard/tables/mozilla/core: Removed.
- platform/mac-snowleopard/tables/mozilla/marvin: Removed.
- platform/mac-snowleopard/tables/mozilla/other: Removed.
- platform/mac-snowleopard/transforms: Removed.
- platform/mac-snowleopard/transforms/2d: Removed.
- platform/mac-snowleopard/transforms/3d: Removed.
- platform/mac-snowleopard/transforms/3d/general: Removed.
- platform/mac-snowleopard/transforms/3d/point-mapping: Removed.
- platform/mac-snowleopard/webarchive: Removed.
- 1:23 AM Changeset in webkit [150874] by
-
- 2 edits in trunk/Tools
adding myself to committers list
- 12:49 AM Changeset in webkit [150873] by
-
- 4 edits in trunk/Source/WebCore
Remove setFullScreenRendererSize and setFullScreenRendererBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=116914
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/508eb21a07f69ed38b9be9ff92fe75dcb907861f
- dom/Document.cpp:
- dom/Document.h:
- 12:46 AM Changeset in webkit [150872] by
-
- 2 edits in trunk/Source/WebCore
Make WidgetHierarchyUpdatesSuspensionScope use swap instead of copy
https://bugs.webkit.org/show_bug.cgi?id=116927
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/1d577e1fd5c5716a06e4007e04fc3d9d0a88f5e4
This is equivalent behavior code that is unambiguously better performance. swap is O(1) time and memory,
copying a hash table is at least linear with the number of elements.
- rendering/RenderWidget.cpp:
(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets):
- 12:43 AM Changeset in webkit [150871] by
-
- 3 edits in trunk/Source/WebCore
Remove Document::nodeAbsIndex() and Document::nodeWithAbsIndex().
Rubber-stamped by Antti "Lucky" Koivisto.
- dom/Document.h:
- dom/Document.cpp:
- 12:39 AM Changeset in webkit [150870] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Clean up WebKit2 GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=116907
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-29
Reviewed by Martin Robinson.
Removed WebNotificationManagerProxy.messages.in after r150785.
- GNUmakefile.am:
- 12:36 AM Changeset in webkit [150869] by
-
- 3 edits in trunk/Source/WebCore
FocusController should operate on Elements internally.
<http://webkit.org/b/116781>
Reviewed by Antti Koivisto.
Switch from Node* to Element* as much as possible inside FocusController.
Mostly mechanical, gets rid of some unnecessary isElementNode() checks and casts.
- page/FocusController.h:
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedElement):
(WebCore::isNonFocusableShadowHost):
(WebCore::adjustedTabIndex):
(WebCore::shouldVisit):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::findFocusableElementAcrossFocusScope):
(WebCore::FocusController::findFocusableElementRecursively):
(WebCore::FocusController::findFocusableElement):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):
(WebCore::FocusController::setActive):
- 12:18 AM Changeset in webkit [150868] by
-
- 4 edits10 adds in trunk
[CSS Regions] Mouse over an element does not trigger :hover state for parent when the element is flowed in a region
https://bugs.webkit.org/show_bug.cgi?id=111749
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-29
Reviewed by Antti Koivisto.
Source/WebCore:
When searching for the hover ancestor and encountering a named flow thread,
the search will continue with the DOM ancestor of the top-most element
in the named flow thread.
Tests: fast/regions/hover-in-region-grandparent.html
fast/regions/hover-in-region-parent-skip.html
fast/regions/hover-in-region-parent-skip-inlines-anonymous.html
fast/regions/hover-on-child-in-region.html
fast/regions/hover-on-child-in-region-in-region.html
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hoverAncestor):
- rendering/RenderObject.h:
LayoutTests:
- fast/regions/hover-in-region-grandparent-expected.txt: Added.
- fast/regions/hover-in-region-grandparent.html: Added.
- fast/regions/hover-in-region-parent-skip-expected.txt: Added.
- fast/regions/hover-in-region-parent-skip.html: Added.
- fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt: Added.
- fast/regions/hover-in-region-parent-skip-inlines-anonymous.html: Added.
- fast/regions/hover-on-child-in-region-expected.txt: Added.
- fast/regions/hover-on-child-in-region.html: Added.
- fast/regions/hover-on-child-in-region-in-region-expected.txt: Added.
- fast/regions/hover-on-child-in-region-in-region.html: Added.
May 28, 2013:
- 10:29 PM Changeset in webkit [150867] by
-
- 7 edits in trunk/Source/WebCore
Crash in WebCore::SubresourceLoader::releaseResources when connection fails
https://bugs.webkit.org/show_bug.cgi?id=87743
Don't do anything complicated in SubresourceLoader::releaseResources(),
just clear variables. With this patch, releaseResources() will still
assert in debug builds if it is called twice, but it will safely execute
in release.
Reviewed by Darin Adler.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::cleanupForError): Pull shared cleanup code out of didFail()
and cancel() into a helper.
(WebCore::ResourceLoader::cancel): Merge a couple variables into an enum, check for
reentrancy from within didCancel().
- loader/ResourceLoader.h: Replace m_calledWillCancel and m_cancelled with an enum.
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading): Don't call ResourceLoader::didFinishLoading(),
put finish() in the middle of the process.
(WebCore::SubresourceLoader::didFail): Don't call ResourceLoader::didFail(), put finish()
in the middle of the process.
(WebCore::SubresourceLoader::didCancel):
(WebCore::SubresourceLoader::notifyDone): Do the non-trivial work previous done in releaseResources(),
most importantly calling loadDone().
(WebCore::SubresourceLoader::releaseResources): Only do simple variable clearing here.
- loader/SubresourceLoader.h:
(SubresourceLoader):
- loader/cache/CachedResource.cpp: Split stopLoading() into cancelLoad() (which notifies clients)
and clearLoader() (which just nulls m_loader).
- loader/cache/CachedResource.h:
- loader/chromium/ResourceLoaderChromium.cpp:
- 10:29 PM Changeset in webkit [150866] by
-
- 2 edits in trunk/Tools
Unreviewed: Adding myself to committers list.
- 10:21 PM Changeset in webkit [150865] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build fix after r150837
https://bugs.webkit.org/show_bug.cgi?id=116904
Unreviewed build fix.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-28
- GNUmakefile.am:
- 10:04 PM Changeset in webkit [150864] by
-
- 2 edits in tags/Safari-537.43.2a/Source/WebCore
Merged r150863. <rdar://problem/13991927>
- 9:56 PM Changeset in webkit [150863] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r150169): Images from file: URLs display after a delay even though they were preloaded by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=116906
<rdar://problem/13991927>
Reviewed by Andreas Kling.
Writing a test for this is blocked on https://webkit.org/b/116199.
Some WebKit clients use JavaScript to preload images from disk so that
subsequent loads will display immediately from the memory cache. By not
caching non-HTTP sub-resources in memory, we break this common pattern.
This change restricts r150169 to only apply to cached main resources.
Sub-resources will again be cached indefinitely as they were prior to
r150169.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime): If this is a non-HTTP
main resource from a scheme that should not be cached indefinitely,
return 0 for the freshness lifetime. For other non-HTTP cached
resources, return an indefinite freshness lifetime.
- 8:14 PM Changeset in webkit [150862] by
-
- 3 edits3 adds in trunk
Animations do not restart after exiting page cache
https://bugs.webkit.org/show_bug.cgi?id=116900
Reviewed by Tim Horton.
Source/WebCore:
Animations are suspended as they enter the page cache, but
were not getting correctly resumed when exiting. The cause
was an error in r149576 which was checking a global flag for suspension
on the AnimationController and thus not trying to resume anything.
Test: animations/resume-after-page-cache.html
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
LayoutTests:
New test to make sure an animation will resume if it
enters and leaves the page cache.
- animations/resources/page-cache-helper.html: Added.
- animations/resume-after-page-cache-expected.txt: Added.
- animations/resume-after-page-cache.html: Added.
- 7:23 PM Changeset in webkit [150861] by
-
- 2 edits in trunk/Source/WebKit/mac
Drag to move DOM nodes does not work
https://bugs.webkit.org/show_bug.cgi?id=116865
Do not block drag events on the WebKit 1 Web Inspector WebView.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-28
Reviewed by Timothy Hatcher.
- WebCoreSupport/WebInspectorClient.mm:
- 6:39 PM Changeset in webkit [150860] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithAbs
https://bugs.webkit.org/show_bug.cgi?id=116890
Reviewed by Oliver Hunt.
Implements ArithAbs in the FTL, and cleans up the DFG implementation. The
DFG implementation was previously doing zero extensions manually when it
is probably better to just use StrictInt32Operand instead.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::doubleAbs):
- 5:38 PM Changeset in webkit [150859] by
-
- 3 edits in tags/Safari-537.43.2a/Source/WebKit2
Merged r150532. <rdar://problem/13962816>
- 5:35 PM Changeset in webkit [150858] by
-
- 1 copy in tags/Safari-537.43.2a
New Tag.
- 5:19 PM Changeset in webkit [150857] by
-
- 2 edits in trunk/LayoutTests
[Windows] Silence last crash to get bots green.
- platform/win/TestExpectations:
- 4:42 PM Changeset in webkit [150856] by
-
- 11 edits in trunk/Source/WebCore
Support multiple HRTFDatabases for different sample-rates
https://bugs.webkit.org/show_bug.cgi?id=116183
Reviewed by Kenneth Russell.
Adapted from Blink:
https://codereview.chromium.org/14636011/
This removes the limitation which required OfflineAudioContexts to be created at native sample-rate
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContext::hrtfDatabaseLoader):
(AudioContext):
- Modules/webaudio/OfflineAudioContext.cpp:
(WebCore::OfflineAudioContext::create):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::offlineRender):
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):
- platform/audio/HRTFDatabaseLoader.cpp:
(WebCore):
(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):
(WebCore::HRTFDatabaseLoader::~HRTFDatabaseLoader):
- platform/audio/HRTFDatabaseLoader.h:
(HRTFDatabaseLoader):
(WebCore::HRTFDatabaseLoader::loaderMap):
- platform/audio/HRTFPanner.cpp:
(WebCore::HRTFPanner::HRTFPanner):
(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):
(WebCore::HRTFPanner::pan):
- platform/audio/HRTFPanner.h:
(HRTFPanner):
- platform/audio/Panner.cpp:
(WebCore::Panner::create):
- platform/audio/Panner.h:
(WebCore):
- 4:35 PM Changeset in webkit [150855] by
-
- 2 edits in trunk/Source/WebCore
Windows build fix.
- platform/cf/KURLCFNet.cpp: (WebCore::KURL::createCFURL):
- 4:27 PM Changeset in webkit [150854] by
-
- 3 edits in trunk/Source/WebKit
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707
Reviewed by Darin Adler.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Export the WebCore::directoryName method for use by DRT.
- 4:26 PM Changeset in webkit [150853] by
-
- 14 edits5 adds in trunk
Freeze when loading a particular page on washingtonpost.com with NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=116887
<rdar://problem/12965959>
Reviewed by Darin Adler.
- Shared/cf/ArgumentCodersCF.cpp: (CoreIPC::encode): (CoreIPC::decode): Fix for the bug: use good shared WebCore code to manipulate CFURLs. Also, added a FIXME about empty URLs.
- Shared/API/c/cf/WKURLCF.cpp: (WKURLCreateWithCFURL): Fixed to not use CFURLGetString, as that could prevent loading certain resources, like ones with curly braces in resource specifiers. We want KURL normalization, not CFURL one.
- 4:26 PM Changeset in webkit [150852] by
-
- 1 edit in trunk/Source/WebKit/win/ChangeLog
[Windows] Many css2.1 tests fail on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=75707
Reviewed by Darin Adler.
- WebKit.vcproj/WebKitExports.def.in: Export the
WebCore::directoryName method for DRT use.
- 4:18 PM Changeset in webkit [150851] by
-
- 2 edits in trunk/Tools
[Windows] Many CSS2.1 tests fail under NRWT.
https://bugs.webkit.org/show_bug.cgi?id=75707
Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-28
Reviewed by Darin Adler.
- DumpRenderTree/win/DumpRenderTree.cpp:
(findFontFallback): Added
(addFontFallbackIfPresent): Added
(removeFontFallbackIfPresent): Added
(runTest): Set up/remove font fallbacks when needed.
- 3:59 PM Changeset in webkit [150850] by
-
- 3 edits in trunk/Tools
[Windows] NRWT reports failure for 'mac' test cases.
https://bugs.webkit.org/show_bug.cgi?id=116698
Reviewed by Ryosuke Niwa.
The Windows port falls back to the Mac port for many test results,
and so adds the mac and mac-wk2 to its set of fallbacks.
Unfortunately, NRWT thinks that this means that tests in these
folders should be executed, resulting in many failures on
Windows.
This change overloads the '_tests_for_other_platforms' method
to return a subset of the result fallback list so that we do
not attempt to execute Mac tests on Windows.
- Scripts/webkitpy/port/base.py:
(Port.test_search_path): Added. Defaults to just calling the
baseline_search_path method, which is how most ports behave.
(Port._test_for_other_platforms): Modified to call the new
test_search_path method.
- Scripts/webkitpy/port/win.py:
(WinPort.test_search_path): Added custom overload. Strips
out mac-specific test paths.
- 3:57 PM Changeset in webkit [150849] by
-
- 2 edits in trunk/LayoutTests
[Windows] More attempts to make the bot green.
- platform/win/TestExpectations: Exclude another two flaky tests.
- 3:40 PM Changeset in webkit [150848] by
-
- 2 edits in trunk/LayoutTests
fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895
Unreviewed, add failing test expectation.
- 3:33 PM Changeset in webkit [150847] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150774. <rdar://problem/13458534>
- 3:32 PM Changeset in webkit [150846] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150773. <rdar://problem/13458534>
- 3:31 PM Changeset in webkit [150845] by
-
- 13 edits in branches/safari-537.43-branch/Source
Merged r150771. <rdar://problem/13458534>
- 3:26 PM Changeset in webkit [150844] by
-
- 16 edits1 add in branches/dfgFourthTier/Source/JavaScriptCore
Misc JIT probe enhacements.
https://bugs.webkit.org/show_bug.cgi?id=116586.
Reviewed by Michael Saboff.
- Added JIT probe support for ARMv7 and traditional ARM. Built and tested on ARMv7. ARM version not tested nor built.
- Fix the following bugs in the X86 and X86_64 probes:
- Cannot assume that the stack pointer is already aligned when we push args for the probe. Instead, we ensure the stack alignment at runtime when we set up the probe call. This is now done in the ctiMasmProbeTrampoline.
- On return, the user probe function may have altered the stack pointer value to be restored. Previously, if the sp restore value points to some of the other register restore values in the ProbeContext record, we will fail to return from the probe having those user specified value as we're expected to do. This is now fixed.
- Rearranged the X86/X86_64 registers order to organize them like gdb expects on X86_64.
- We also now preserve the condition code registers.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/ARMAssembler.h:
- assembler/ARMv7Assembler.h:
(ARMRegisters):
- assembler/MacroAssemblerARM.cpp:
(JSC::isVFPPresent):
(JSC::MacroAssemblerARM::ProbeContext::dumpCPURegisters):
(JSC::MacroAssemblerARM::ProbeContext::dump):
(JSC::MacroAssemblerARM::probe):
- assembler/MacroAssemblerARM.h:
(MacroAssemblerARM):
(CPUState):
(ProbeContext):
(JSC::MacroAssemblerARM::trustedImm32FromPtr):
- assembler/MacroAssemblerARMv7.h:
(MacroAssemblerARMv7):
(CPUState):
(ProbeContext):
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):
- assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::probe):
- assembler/MacroAssemblerX86Common.cpp:
(JSC::MacroAssemblerX86Common::ProbeContext::dumpCPURegisters):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::probe):
- assembler/X86Assembler.h:
- config.h:
- jit/JITStubsARM.h:
- jit/JITStubsARMv7.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86Common.h:
- jit/JITStubsX86_64.h:
- 3:24 PM Changeset in webkit [150843] by
-
- 13 edits in branches/dfgFourthTier/LayoutTests
fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT
Rubber stamped by Oliver Hunt.
- fast/js/dfg-arguments-alias-one-block-expected.txt:
- fast/js/dfg-arguments-cross-code-origin-expected.txt:
- fast/js/dfg-arguments-mixed-alias-expected.txt:
- fast/js/dfg-arguments-osr-exit-expected.txt:
- fast/js/dfg-arguments-osr-exit-multiple-blocks-before-exit-expected.txt:
- fast/js/dfg-arguments-unexpected-escape-expected.txt:
- fast/js/script-tests/dfg-arguments-alias-one-block.js:
- fast/js/script-tests/dfg-arguments-cross-code-origin.js:
- fast/js/script-tests/dfg-arguments-mixed-alias.js:
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks-before-exit.js:
- fast/js/script-tests/dfg-arguments-osr-exit.js:
- fast/js/script-tests/dfg-arguments-unexpected-escape.js:
- 3:22 PM Changeset in webkit [150842] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Windows] Put correct byteCompile symbol in file. Previous version
had an extra 'i' appended to the end.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 3:07 PM Changeset in webkit [150841] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build fix. Remove ?byteCompile symbol that
is no longer accessible during link.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 3:01 PM Changeset in webkit [150840] by
-
- 12 edits2 adds in branches/safari-537.43-branch
Disable some feature flags.
<rdar://problem/12952646>.
Rubberstamped by Jon Lee.
Disabled flags:
ENABLE_CSS_COMPOSITING
ENABLE_CSS_EXCLUSIONS
ENABLE_CSS_SHADERS
ENABLE_IFRAME_SEAMLESS
ENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED
ENABLE_SHARED_WORKERS
- Configurations/FeatureDefines.xcconfig:
- rendering/RenderBlock.cpp:
(WebCore::exclusionInfoRequiresRelayout):
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
- platform/mac/TestExpectations:
- platform/mac/fast/dom/call-a-constructor-as-a-function-expected.txt: Added.
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/mac/fast/js/global-constructors-attributes-expected.txt: Added.
- 2:53 PM Changeset in webkit [150839] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should call masqueradesAsUndefinedWatchpointIfIsStillValid() in all of the places where it currently calls masqueradesAsUndefinedWatchpointIsStillValid()
https://bugs.webkit.org/show_bug.cgi?id=116892
Reviewed by Oliver Hunt.
All of those places mean to plant the watchpoint if it's still valid.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
- 2:52 PM Changeset in webkit [150838] by
-
- 2 edits in trunk/Source/WebKit2
Rendering suppression extension tokens shouldn't be 0, should handle overflow
https://bugs.webkit.org/show_bug.cgi?id=116886
<rdar://problem/14004474>
Reviewed by Darin Adler.
Don't use invalid HashSet values as tokens, and ensure that
we're not already using a token before returning it.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendIncrementalRenderingSuppression):
- 2:50 PM Changeset in webkit [150837] by
-
- 12 edits2 moves1 add in trunk/Source
Create a html/forms subdirectory and move FileIconLoader there
https://bugs.webkit.org/show_bug.cgi?id=116880
Reviewed by Jessie Berlin.
A lot (if not the majority) of files in html/ are forms related, so it makes sense to begin splitting
them out into a separate subdirectory, html/forms.
Begin my moving FileIconLoader from platform to html/forms. It is related to HTML forms (it's only used by
the file upload element), and is not really a platform abstraction so it doesn't belong in platform.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/forms/FileIconLoader.cpp: Renamed from Source/WebCore/platform/FileIconLoader.cpp.
- html/forms/FileIconLoader.h: Renamed from Source/WebCore/platform/FileIconLoader.h.
- 2:47 PM Changeset in webkit [150836] by
-
- 2 edits in trunk/Source/WebCore
AX: WKView is unable to set AXFocused to YES and does not handle keyboard events as expected
https://bugs.webkit.org/show_bug.cgi?id=116756
Reviewed by Tim Horton.
If AXFocused is set to true, but the WebView is not the first responder, then the call will
not do anything. This change asks the Chrome to make the WebView the first responder before
trying to set focus within the page.
Was not able to make a test, it requires on interplay between areas outside the web view.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
- 2:45 PM Changeset in webkit [150835] by
-
- 2 edits in trunk/Source/JavaScriptCore
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750
Reviewed by Darin Adler.
- runtime/JSDateMath.cpp:
(JSC::msToGregorianDateTime):
- Additional review comment fix.
- 2:45 PM Changeset in webkit [150834] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build fix after r150833
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
A CR/LF combination was lost in the file, combining two symbols.
- 2:33 PM Changeset in webkit [150833] by
-
- 11 edits in trunk/Source
String(new Date(2010,10,1)) is wrong in KRAT, YAKT
https://bugs.webkit.org/show_bug.cgi?id=106750
Reviewed by Darin Adler.
First part of a fix, simplfy date handling code, instead of operating separately
on the UTC-standard and standard-DST offsets, just generate a combined UTC-local
offset (this is what we actually need, and what the OS gives us).
- runtime/JSDateMath.cpp:
(JSC::getLocalTimeOffset):
- removed getUTCOffset, converted getDSTOffset -> getLocalTimeOffset
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):
- call getLocalTimeOffset instead of getUTCOffset/getDSTOffset
- runtime/VM.cpp:
(JSC::VM::resetDateCache):
- removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
- runtime/VM.h:
(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
(JSC::LocalTimeOffsetCache::reset):
(LocalTimeOffsetCache):
- removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
../WTF:
- wtf/DateMath.cpp:
(WTF::calculateUTCOffset):
(WTF::calculateDSTOffset):
- made static, now not called from outside of this file.
(WTF::calculateLocalTimeOffset):
- This combines the 2038 related adjustment from calculateDSTOffset with the maxUnixTime adjustment from calculateDSTOffsetSimple. Then, if HAVE(TM_GMTOFF) just call getLocalTime, if not use calculateUTCOffset/calculateDSTOffset.
(WTF::parseDateFromNullTerminatedCharacters):
- call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
- wtf/DateMath.h:
(WTF::LocalTimeOffset::LocalTimeOffset):
(LocalTimeOffset):
(WTF::LocalTimeOffset::operator==):
- new struct type, a tuple of UTC-local offset & isDST flag.
- replaced calculateUTCOffset/calculateDSTOffset with calculateLocalTimeOffset
- wtf/GregorianDateTime.cpp:
(WTF::GregorianDateTime::setToCurrentLocalTime):
- call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
- 2:33 PM Changeset in webkit [150832] by
-
- 3 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150618. <rdar://problem/13984706>
- 2:18 PM Changeset in webkit [150831] by
-
- 3 edits in trunk/Source/JavaScriptCore
r150199 is very wrong
https://bugs.webkit.org/show_bug.cgi?id=116876
JSValue needs to protect its internal JSValueRef.
Reviewed by Darin Adler.
- API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
- API/tests/testapi.mm: Added a simple test to make sure that we protect the
underlying JavaScript value across garbage collections.
- 2:04 PM Changeset in webkit [150830] by
-
- 2 edits in trunk/LayoutTests
[Windows] Silence a few failures to get bot green.
https://bugs.webkit.org/show_bug.cgi?id=116564
- platform/win/TestExpectations: Disable some tests.
- 1:55 PM Changeset in webkit [150829] by
-
- 5 edits in branches/dfgFourthTier/LayoutTests
fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT
Rubber stamped by Oliver Hunt.
- fast/js/dfg-arguments-alias-activation-expected.txt:
- fast/js/dfg-arguments-alias-activation.html:
- fast/js/dfg-arguments-alias-expected.txt:
- fast/js/script-tests/dfg-arguments-alias.js:
- 1:50 PM Changeset in webkit [150828] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithMin/ArithMax
https://bugs.webkit.org/show_bug.cgi?id=116885
Reviewed by Oliver Hunt.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
- 1:17 PM Changeset in webkit [150827] by
-
- 2 edits in trunk/Source/WebCore
Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
https://bugs.webkit.org/show_bug.cgi?id=116882
Reviewed by Eric Carlson.
Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::repositionGenericCue):
- 1:05 PM Changeset in webkit [150826] by
-
- 10 edits in branches/dfgFourthTier/LayoutTests
fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT
Rubber stamped by Oliver Hunt.
- fast/js/dfg-abs-backwards-propagation-expected.txt:
- fast/js/dfg-add-not-number-expected.txt:
- fast/js/dfg-arguments-alias-escape-expected.txt:
- fast/js/resources/js-test-pre.js:
(dfgCompiled):
(dfgIncrement):
- fast/js/script-tests/dfg-abs-backwards-propagation.js:
- fast/js/script-tests/dfg-add-not-number.js:
- fast/js/script-tests/dfg-arguments-alias-escape.js:
- fast/js/script-tests/dfg-arguments-alias-one-block-osr-exit.js:
- fast/js/script-tests/dfg-arguments-alias-one-block-overwrite-arguments.js:
- 12:36 PM Changeset in webkit [150825] by
-
- 4 edits in branches/dfgFourthTier/LayoutTests
fourthTier: fast/js should have a way of running tests long enough to wait for the concurrent JIT to tier up
https://bugs.webkit.org/show_bug.cgi?id=116878
Reviewed by Oliver Hunt.
This adds three things to js-test-pre and uses them in one representative test:
silentTestPass: If you set this to true, then testPassed() won't print anything, and will instead just have
isSuccessfullyParsed() print a message saying that some tests passed silently. This allows tests to call
shouldBe() and friends in a loop whose running time is dependent on concurrent JIT behavior, and still
be sure that the resulting test will be deterministic.
noInline(): If testRunner is present, disable inlining of the relevant function.
dfgIncrement({f:function, i:index, n:limit}): Returns index either if index < limit, or if the function is
DFG compiled. Otherwise, if index >= limit and the function isn't DFG compiled, return 0. This means
that the 'i++' in the fast/js/dfg-* warm-up loops can be replaced with:
i = dfgIncrement({f:<function you're interested in>, i:i + 1, n:<some number smaller than the loop condition>)
This has the effect of having the loop repeat the first 'n' iterations until the function is DFG
compiled. See the modified test, where we do n:100 and the loop condition is i < 200. So the loop will
repeat the first 100 iterations until the function is DFG compiled and will only do the last 100
iterations once DFG compilation kicks in.
- fast/js/dfg-arguments-osr-exit-multiple-blocks-expected.txt:
- fast/js/resources/js-test-pre.js:
(testPassed):
(dfgIncrement):
(noInline):
(isSuccessfullyParsed):
- fast/js/script-tests/dfg-arguments-osr-exit-multiple-blocks.js:
- 12:04 PM Changeset in webkit [150824] by
-
- 3 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150731. <rdar://problem/13695911>
- 12:01 PM Changeset in webkit [150823] by
-
- 35 edits in branches/safari-537.43-branch
Merged r150695. <rdar://problem/13743484>
- 11:55 AM Changeset in webkit [150822] by
-
- 2 edits in trunk/LayoutTests
Fix line endings in test added in r150602
Unreviewed.
- fast/css/text-overflow-ellipsis-behind-floats.html:
- 11:50 AM Changeset in webkit [150821] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150671. <rdar://problem/13886753>
- 11:46 AM Changeset in webkit [150820] by
-
- 3 edits in trunk/Source/WebCore
[BlackBerry] GraphicsContext: add missing definitions.
https://bugs.webkit.org/show_bug.cgi?id=115515
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-28
Reviewed by Rob Buis.
- platform/graphics/GraphicsContext.h:
(Graphics):
Add definition for PlatformGraphicsContext.
- platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
Include RoundedRect.h
- 11:45 AM Changeset in webkit [150819] by
-
- 4 edits in branches/safari-537.43-branch/Source
Merged r150653. <rdar://problem/13747883>
- 11:43 AM Changeset in webkit [150818] by
-
- 13 edits4 copies in branches/safari-537.43-branch/Source
Merged r150651. <rdar://problem/13885606>
- 11:40 AM Changeset in webkit [150817] by
-
- 14 edits in trunk/Source
[BlackBerry] Fix style issues in BlackBerry accelerated compositing backend
https://bugs.webkit.org/show_bug.cgi?id=116604
Reviewed by Carlos Garcia Campos.
Source/WebCore:
PR 273550, 99638
Remove the "get" prefix from getters in the WebKit- and compositing-
thread layer classes, as well as LayerRendererSurface. Clarify which
geometry-related getters return normalized device coordinates by adding
a comment.
Also remove dead code related to LayerData::m_holePunchClipRect, which
was part of an eventually disabled fix for video clipping in iframes,
PR 99638. Since we now use AC layers for iframes, the bug is no longer
reproducible, and the dead code will never need to be enabled again.
No change in behavior, no new tests.
- platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::LayerCompositingThread::transformedHolePunchRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerCompositingThread.h:
(WebCore::LayerCompositingThread::sublayers): Removed "get" prefix
(LayerCompositingThread):
(WebCore::LayerCompositingThread::boundingBox): Renamed from "getDrawRect"
(WebCore::LayerCompositingThread::transformedBounds): Removed "get" prefix
(WebCore::LayerCompositingThread::transformedHolePunchRect): Removed "get" prefix
- platform/graphics/blackberry/LayerData.h:
(LayerData): Removed unused data member "m_holePunchClipRect"
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::prepareFrameRecursive):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::collect3DPreservingLayers):
(WebCore::LayerRenderer::compositeLayersRecursive):
- platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::boundingBox):
- platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::boundingBox): Renamed from "drawRect" because that sounds like a verb, and this is a getter
- platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::sublayers): Removed "get" prefix
- platform/graphics/blackberry/VideoLayerWebKitThread.cpp:
(WebCore::VideoLayerWebKitThread::setHolePunchRect):
(WebCore::VideoLayerWebKitThread::boundsChanged):
Source/WebKit/blackberry:
Adapt to the removal of "get" prefix from getters in the WebKit- and
compositing-thread layer classes.
- Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
(BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
- 11:33 AM Changeset in webkit [150816] by
-
- 10 edits in branches/dfgFourthTier
testRunner should have a way of disabling inlining of functions
https://bugs.webkit.org/show_bug.cgi?id=116875
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- API/JSCTestRunnerUtils.cpp:
(JSC::getExecutable):
(JSC):
(JSC::numberOfDFGCompiles):
(JSC::setNeverInline):
- API/JSCTestRunnerUtils.h:
(JSC):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):
- runtime/Executable.h:
(JSC::ScriptExecutable::ScriptExecutable):
(ScriptExecutable):
(JSC::ScriptExecutable::setNeverInline):
(JSC::ScriptExecutable::neverInline):
(JSC::ScriptExecutable::isInliningCandidate):
Tools:
- DumpRenderTree/TestRunner.cpp:
(neverInlineFunction):
(TestRunner::staticFunctions):
LayoutTests:
- fast/js/script-tests/dfg-min-max.js:
- 11:32 AM Changeset in webkit [150815] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150547. <rdar://problem/13946443>
- 11:31 AM Changeset in webkit [150814] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithMod
https://bugs.webkit.org/show_bug.cgi?id=116792
Reviewed by Oliver Hunt.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildFRem):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::doubleRem):
- 11:30 AM Changeset in webkit [150813] by
-
- 3 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150532. <rdar://problem/13962816>
- 11:27 AM Changeset in webkit [150812] by
-
- 3 edits6 copies in branches/safari-537.43-branch
Merged r150529. <rdar://problem/13946443>
- 11:18 AM Changeset in webkit [150811] by
-
- 24 edits in branches/dfgFourthTier/Source
It should be possible to record heap operations (both FastMalloc and JSC GC)
https://bugs.webkit.org/show_bug.cgi?id=116848
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Record GC heap operations if ENABLE(ALLOCATION_LOGGING).
- API/JSManagedValue.mm:
- dfg/DFGOperations.cpp:
- heap/Heap.cpp:
(JSC::Heap::collect):
- heap/Heap.h:
(Heap):
(JSC::Heap::allocateWithNormalDestructor):
(JSC::Heap::allocateWithImmortalStructureDestructor):
(JSC::Heap::allocateWithoutDestructor):
(JSC::Heap::tryAllocateStorage):
(JSC::Heap::tryReallocateStorage):
(JSC):
(JSC::Heap::ascribeOwner):
- heap/SlotVisitor.cpp:
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::internalAppend):
- heap/SlotVisitor.h:
(SlotVisitor):
- heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendUnbarrieredPointer):
(JSC::SlotVisitor::appendUnbarrieredValue):
(JSC::SlotVisitor::appendUnbarrieredWeak):
(JSC::SlotVisitor::internalAppend):
(JSC):
(JSC::SlotVisitor::appendValues):
- jit/JITWriteBarrier.h:
(JSC::SlotVisitor::append):
- llint/LLIntCommon.h:
- runtime/Butterfly.h:
(Butterfly):
- runtime/ButterflyInlines.h:
(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::create):
(JSC::Butterfly::growPropertyStorage):
(JSC::Butterfly::createOrGrowArrayRight):
(JSC):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::resizeArray):
- runtime/JSArray.cpp:
(JSC::createArrayButterflyInDictionaryIndexingMode):
(JSC::JSArray::unshiftCountSlowCase):
- runtime/JSArray.h:
(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):
- runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):
- runtime/JSObject.h:
(JSC::JSObject::JSObject):
- runtime/Operations.h:
- runtime/RegExpMatchesArray.cpp:
(JSC::RegExpMatchesArray::create):
- runtime/StructureInlines.h:
(JSC):
- runtime/WriteBarrier.h:
(JSC):
Source/WTF:
Reviewed by Mark Hahnenberg.
- WTF.xcodeproj/project.pbxproj:
- wtf/DataLog.cpp:
(WTF):
(WTF::initializeLogFileOnce):
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- wtf/Platform.h:
- 10:54 AM Changeset in webkit [150810] by
-
- 12 edits in trunk
Made AudioNode an EventTarget
https://bugs.webkit.org/show_bug.cgi?id=116871
Source/WebCore:
Merge: https://chromium.googlesource.com/chromium/blink/+/ef37484162ddb95d677dcfdcdd778ec60590928b
Reviewed by Darin Adler.
Tests: webaudio/audionode-expected.txt:
webaudio/audionode.html:
Add the requisite boilerplate to allow AudioNode to become an EventTarget. Remove
all that same boilerplate from ScriptProcessorNode now that it's base class
is an EventTarget.
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::interfaceName): Added boilerplate.
(WebCore::AudioNode::scriptExecutionContext): Return the AudioContext's context.
(WebCore::AudioNode::processIfNecessary): Whitespace.
- Modules/webaudio/AudioNode.h:
- Modules/webaudio/AudioNode.idl: Make AudioNode an EventTarget.
- Modules/webaudio/ScriptProcessorNode.cpp: Remove EventTarget boilerplate.
- Modules/webaudio/ScriptProcessorNode.h: Ditto.
- Modules/webaudio/ScriptProcessorNode.idl: Ditto.
- dom/EventTarget.h: Mark AudioNode as an EventTarget.
- dom/EventTargetFactory.in: Ditto.
LayoutTests:
Reviewed by Darin Adler.
- webaudio/audionode-expected.txt:
- webaudio/audionode.html:
- 10:28 AM Changeset in webkit [150809] by
-
- 9 edits in trunk/Source/WebCore
[BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters
https://bugs.webkit.org/show_bug.cgi?id=116616
Reviewed by Carlos Garcia Campos.
The BlackBerry::Platform::Graphics::GraphicsContext generates geometry
with a different winding order than the accelerated compositing backend
of the BlackBerry port. So, when we switched from Skia to this new
rendering engine, we switched from glFrontFace(GL_CCW) to
glFrontFace(GL_CW), and all was well when drawing display lists.
However, we forgot to update the winding order of geometry generated
within the accelerated compositing backend, which is used for masks and
filters, so they were getting erroneously culled out when
backface-visibility: hidden was applied to them. Fixed by switching the
winding order of all geometry generated up here, which has the added
benefit of enabling us to use TransformationMatrix::mapQuad instead of
transforming point-by-point.
To further complicate matters, a right-side up transform is used when
drawing layers into surfaces, reversing the winding order and requiring
us to switch back to glFrontFace(GL_CCW) temporarily, when drawing
layers to surfaces, or the layers will get culled out inside the
surface.
Also fix spelling error, "drawed" should be "drawn".
No new tests, this is only detectable by pixel tests, which the
BlackBerry port currently doesn't support.
PR 341945.
- platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
- platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::setDrawTransform):
(WebCore::getTransformedRect):
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
- platform/graphics/blackberry/LayerCompositingThread.h:
(LayerCompositingThread):
(WebCore::LayerCompositingThread::origin):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayers):
(WebCore):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
- platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds):
- platform/graphics/blackberry/LayerRendererSurface.h:
(WebCore::LayerRendererSurface::origin):
(LayerRendererSurface):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
- 10:12 AM Changeset in webkit [150808] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Connection issues in repeated WebProcess crash/reloads.
https://bugs.webkit.org/show_bug.cgi?id=115880
Reviewed by Anders Carlsson.
When stressing the WebProcess creation/destruction, WebKitGTK can
often run into socket issues like bad file descriptor errors or
polling a socket indefinitely.
Currently WebKitGTK has three places where a socket can be
closed.
- childFinishedFunction (in ProcessLauncherGtk.cpp)
- Connection::platformInvalidate (in ConnectionUnix.cpp)
- WorkQueue EventSource destruction (in WorkQueueGtk.cpp)
To avoid these race conditions, socket closing will be handled
by the event source callback in WorkQueueGtk.cpp.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate): Do not close the socket
when the connection is invalidated, the socket event source is
unregistered in this method and the socket is closed when the
GSocket associated to the event source is destroyed.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Do not monitor child
process to close the connection on termination. This was needed in
the past when we used DGRAM sockets, we currently use always
connection oriented sockets, so that when the other end closes
the connection we are notified and the connection is invalidated.
- 10:08 AM Changeset in webkit [150807] by
-
- 13 edits3 adds in branches/dfgFourthTier
testRunner should be able to tell you if a function is DFG compiled
https://bugs.webkit.org/show_bug.cgi?id=116847
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- API/JSCTestRunnerUtils.cpp: Added.
(JSC):
(JSC::numberOfDFGCompiles):
- API/JSCTestRunnerUtils.h: Added.
(JSC):
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::numberOfDFGCompiles):
(JSC):
- bytecode/CodeBlock.h:
(CodeBlock):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::runThread):
- runtime/Executable.h:
(JSC):
- runtime/JSFunctionInlines.h: Added.
(JSC):
(JSC::JSFunction::JSFunction):
(JSC::JSFunction::jsExecutable):
(JSC::JSFunction::isHostFunction):
(JSC::JSFunction::nativeFunction):
(JSC::JSFunction::nativeConstructor):
- runtime/Operations.h:
Source/WebCore:
Bail early if we're in the compilation thread. This is only relevant for
debug dumps.
No new tests becase no new behavior.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script):
Tools:
- DumpRenderTree/TestRunner.cpp:
(numberOfDFGCompiles):
(TestRunner::staticFunctions):
LayoutTests:
- fast/js/script-tests/dfg-min-max.js:
- 9:03 AM Changeset in webkit [150806] by
-
- 4 edits in trunk
Fix GTK+ CMake build
Source/WebKit2:
- PlatformGTK.cmake: After r150336, the name of the WebKit2
library target is simply "WebKit2."
Tools:
- MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
library target is simply "WebKit2."
- 7:41 AM Changeset in webkit [150805] by
-
- 7 edits in trunk/Source/WebCore
Move Node::dispatchChangeEvent() to HTMLFormControlElement.
<http://webkit.org/b/116866>
Reviewed by Anders Carlsson.
...and devirtualize it, since it had no overrides.
- dom/Node.h:
- dom/Node.cpp:
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchChangeEvent):
(WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
- html/FileInputType.cpp:
(WebCore::FileInputType::setFiles):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
- 7:37 AM Changeset in webkit [150804] by
-
- 2 edits in trunk/Source/WebCore
Refactoring CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=116679
Reviewed by Andreas Kling.
From Blink r149948 by <serya@chromium.org>
Added "closing_parenthesis:" and "error_recovery:" to avoid code
duplication in a couple of error recovery rules. Some other rules
were also refactored which allows to reduce the the number of
shift/reduce conflicts by 2.
No new tests required as this is just a refactoring, no new
functionality added.
- css/CSSGrammar.y.in:
- 7:31 AM Changeset in webkit [150803] by
-
- 4 edits in trunk
Invalid block doesn't make declaration invalid
https://bugs.webkit.org/show_bug.cgi?id=115709
Reviewed by Andreas Kling.
From Blink r149446 by <serya@chromium.org>
Source/WebCore:
Added a new rule "declaration_recovery:" which covers any kind of
"invalid_block_list maybe_space" sequence. By appending this new
rule to every rule reductable to "declaration:" we can remove some
redundant rules and improve error recovery of some others that
were only accepting exactly one error.
One of the rules being removed was preventing invalid blocks in a
declaration to invalidate the whole declaration. The rule was
reporting the syntax error but at the same time accepting the
invalid block as part of a valid declaration.
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-error-recovery.html: Added 2 new test cases.
- 7:08 AM Changeset in webkit [150802] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated when contents size changes
https://bugs.webkit.org/show_bug.cgi?id=116845
Reviewed by Noam Rosenthal.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):
- 7:01 AM Changeset in webkit [150801] by
-
- 11 edits in trunk/Source/WebCore
Move dispatching of focus-related events from Node to Element.
<http://webkit.org/b/116864>
Reviewed by Antti Koivisto.
...and pass around pointers to Element instead of Node.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::dispatchFocusInEvent):
(WebCore::Element::dispatchFocusOutEvent):
(WebCore::Element::dispatchFocusEvent):
(WebCore::Element::dispatchBlurEvent):
Moved here from Node.
- html/HTMLFormControlElement.h:
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::dispatchBlurEvent):
- html/HTMLSelectElement.h:
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
- html/HTMLTextFormControlElement.h:
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
(WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
Update subclass overrides and sprinkle OVERRIDE/FINAL.
- 6:34 AM Changeset in webkit [150800] by
-
- 3 edits in trunk/Tools
[webkitpy] Explicitly specify the reference file extensions
https://bugs.webkit.org/show_bug.cgi?id=116333
Reviewed by Benjamin Poulain.
Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
between valid reference files required by reftests and text baselines that have the same extension as
potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
that were until this change recognized as reference files).
Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
- Scripts/webkitpy/port/base.py:
(Port.reference_files): Iterate through the _supported_reference_extensions set.
(Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
_supported_reference_extensions set, containing the extensions allowed for reference files.
(Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
(Port._has_supported_extension): Use _supported_test_extensions.
- Scripts/webkitpy/port/base_unittest.py:
(PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
Port.is_reference_html_file method.
- 6:22 AM Changeset in webkit [150799] by
-
- 3 edits in trunk/Source/WebCore
Remove CachedResourceRequest::initiatorElement
https://bugs.webkit.org/show_bug.cgi?id=116862
Reviewed by Andreas Kling.
The CachedResourceRequest::initiatorElement method is not used anywhere and should be removed.
- loader/cache/CachedResourceRequest.cpp: Remove the initiatorElement method definition.
- loader/cache/CachedResourceRequest.h:
(CachedResourceRequest): Remove the initiatorElement method declaration.
- 6:07 AM Changeset in webkit [150798] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode
https://bugs.webkit.org/show_bug.cgi?id=116597
ScrollingCoordinatorCoordinatedGraphics is tailored specifically for
fixedLayout mode. When fixedLayout is not set, it should be turned off.
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-28
Reviewed by Allan Sandfeld Jensen.
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
- 6:01 AM Changeset in webkit [150797] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskip now passing tests.
- platform/qt/TestExpectations:
- 5:54 AM QtWebKitGardening edited by
- Add a hint for x86 users (diff)
- 5:46 AM Changeset in webkit [150796] by
-
- 55 edits in trunk/Source
Document::setFocusedNode() should be setFocusedElement().
<http://webkit.org/b/116857>
Reviewed by Antti Koivisto.
Source/WebCore:
Only Elements can be focused, so tighten Document's idea of what's focused.
Most of this patch is just updating call sites for the new names and removing
now-unnecessary isElementNode() checks and casts.
- WebCore.exp.in:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFocused):
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
- bindings/objc/DOM.mm:
(-[DOMElement isFocused]):
- dom/Document.cpp:
(WebCore::Document::dispose):
(WebCore::Document::detach):
(WebCore::Document::focusedNodeRemoved):
(WebCore::Document::removeFocusedNodeOfSubtree):
(WebCore::Document::setFocusedElement):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::eventTargetNodeForDocument):
- dom/Document.h:
(Document):
(WebCore::Document::focusedElement):
- dom/Element.cpp:
(WebCore::Element::attach):
(WebCore::Element::focus):
(WebCore::Element::blur):
(WebCore::Element::cancelFocusAppearanceUpdate):
- dom/Node.cpp:
(WebCore::Node::rendererIsEditable):
- dom/TreeScope.cpp:
(WebCore::TreeScope::focusedElement):
- dom/UserTypingGestureIndicator.cpp:
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::guessesForMisspelledOrUngrammatical):
- editing/EditorCommand.cpp:
(WebCore::verticalScrollDistance):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::setFocusedElementIfNeeded):
(WebCore::FrameSelection::currentForm):
- history/CachedPage.cpp:
(WebCore::CachedPage::restore):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::attach):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::setValueCommon):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
(WebCore::HTMLTextFormControlElement::selectionStart):
(WebCore::HTMLTextFormControlElement::selectionEnd):
(WebCore::HTMLTextFormControlElement::selectionDirection):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
- html/shadow/DateTimeEditElement.cpp:
(WebCore::DateTimeEditElement::focusedFieldIndex):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
- page/EventHandler.cpp:
(WebCore::EventHandler::scrollOverflow):
(WebCore::EventHandler::logicalScrollOverflow):
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::capsLockStateMayHaveChanged):
- page/FocusController.cpp:
(WebCore::dispatchEventsOnWindowAndFocusedNode):
(WebCore::FocusController::advanceFocusInDocumentOrder):
(WebCore::FocusController::setFocusedElement):
(WebCore::FocusController::findFocusCandidateInContainer):
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
(WebCore::FocusController::advanceFocusDirectionally):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement):
- plugins/efl/PluginViewEfl.cpp:
(WebCore::PluginView::setFocus):
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
(WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isFocused):
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
Source/WebKit/efl:
- ewk/ewk_frame.cpp:
(ewk_frame_focused_element_geometry_get):
- ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):
Source/WebKit/gtk:
- webkit/webkitwebview.cpp:
(getFocusedNode):
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebHTMLView clearFocus]):
(-[WebHTMLView becomeFirstResponder]):
Source/WebKit/qt:
- Api/qwebelement.cpp:
(QWebElement::hasFocus):
(QWebElement::setFocus):
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::mousePressEvent):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::inputMethodQuery):
(QWebPageAdapter::hasFocusedNode):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::isFocused):
- WebView.cpp:
(WebView::setInitialFocus):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::focusPluginElement):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedPluginViewForFrame):
(WebKit::WebPage::setInitialFocus):
- 3:43 AM Changeset in webkit [150795] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Unreviewed. Fix BlackBerry debug build after r150756.
- WebKitSupport/PagePopup.cpp:
(BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
assert.
- 3:22 AM Changeset in webkit [150794] by
-
- 2 edits in trunk/LayoutTests
Unskip now passing tests.
- platform/qt-arm/TestExpectations:
- 2:37 AM Changeset in webkit [150793] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after parallel gc is enabled.
- platform/qt/TestExpectations:
- 2:29 AM Changeset in webkit [150792] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Clean up duplicated include files.
https://bugs.webkit.org/show_bug.cgi?id=116851
Reviewed by Christophe Dumez.
Remove some of duplicated include file in ewk files.
- UIProcess/API/efl/EwkView.h:
- UIProcess/API/efl/ewk_color_picker.cpp:
- UIProcess/API/efl/ewk_context_menu.cpp:
- UIProcess/API/efl/ewk_security_origin_private.h:
- 12:21 AM Changeset in webkit [150791] by
-
- 6 edits in trunk
Web Inspector: Enable CSS logging
https://bugs.webkit.org/show_bug.cgi?id=113401
Reviewed by Benjamin Poulain.
From Blink r149265 by <serya@chromium.org>
Source/WebCore:
CSS logging was disabled in r147028 to prevent message overflow in
the inspector console. This change restores it by modifying the
CSS grammar in order to reduce as much consecutive errors as
possible in 'declaration_list' and 'decl_list' rules.
This way, for rules like 'x { color: ### }' only the first '#'
will be reported as error (instead of 3 identical errors).
The rule 'declaration' still produces multiple errors, because it
does not eat as much errors as possible. So in order not to create
a complex risky patch we just disable logging in the parser for
that rule.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSParser.h:
(CSSParser):
LayoutTests:
Unskipped console-css-warnings.html now that it's working.
- 12:18 AM Changeset in webkit [150790] by
-
- 4 edits in trunk/Source
[EFL] pc files should have harfbuzz dependency.
https://bugs.webkit.org/show_bug.cgi?id=116852
Reviewed by Gyuyoung Kim.
Source/WebKit/efl:
- ewebkit.pc.in: Added harfbuzz as Required package.
Source/WebKit2:
- efl/ewebkit2.pc.in: Added harfbuzz as Required package.
- 12:02 AM Changeset in webkit [150789] by
-
- 2 edits in trunk/Source/WebCore
Build fix for WinCE after r150730.
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
May 27, 2013:
- 11:57 PM Changeset in webkit [150788] by
-
- 3 edits in trunk/Source/WebCore
Build fix for WinCE after r150772.
- platform/win/ClipboardWin.cpp:
(WebCore):
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::readFilenames):
(WebCore):
- 11:48 PM Changeset in webkit [150787] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Remove unneeded WebCore namespace use in ewk
https://bugs.webkit.org/show_bug.cgi?id=116707
Reviewed by Christophe Dumez.
- UIProcess/API/efl/ewk_security_origin.cpp: Remove "using namespace WebCore".
- UIProcess/API/efl/ewk_text_checker.cpp: ditto.
- 11:31 PM Changeset in webkit [150786] by
-
- 2 edits in trunk/Source/WTF
Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978
Recommit after wrong rollout in r150621.
- wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):
- 5:02 PM Changeset in webkit [150785] by
-
- 14 edits1 add1 delete in trunk
[WK2] Notifications clobber each other with multiple processes
https://bugs.webkit.org/show_bug.cgi?id=116428
<rdar://problem/13935191>
Reviewed by Darin Adler.
.:
- ManualTests/notification-in-multiple-windows.html: Added.
Source/WebKit2:
With multiple processes, the notification IDs, when passed up to the UI process, can clobber
each other. To fix this, we need to maintain a global map of notification IDs. This map is
keyed by its own unique notification ID, and maps to a pair containing the web page ID and that
web page's ID for the notification.
Now that we maintain groups of notifications based on the web page, we no longer send IPC messages
from WebNotificationManager to WebNotificationManagerProxy; instead we send messages to the
WebPageProxy. This removes the need for WebNotificationManagerProxy to be a message receiver.
When a page closes, all of the web notifications are cleared out. However, by the time the
WebPage::close() is called, the connection between WebPage and WebPageProxy is destroyed. Since
the WebPage is told to close from the UI process anyway, we clear out the notifications separately,
instead of waiting for a message from the WebPage.
- UIProcess/Notifications/WebNotificationManagerProxy.h: Update to take into account the
notification's web page. Remove inheritance of CoreIPC::MessageReceiver. Expose the original message
handlers as public functions, since they will be called from WebPageProxy. Add a new map that
associates a global ID with a notification ID that came from a web page.
There are now two flavors of clearNotifications(). One clears out all notifications associated
with a web page. This is called when the page is closed. The other clears out a subset of
notifications associated with a web page. This is called when notifications associated with a sub-frame
is closed.
- UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Removed. All messages from
the web process go to WebPageProxy now.
- UIProcess/Notifications/WebNotificationManagerProxy.cpp: Update to take into account the
notification's web page.
(WebKit::generateGlobalNotificationID): The manager proxy now maintains its own global notification
ID generator.
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy): The proxy is no longer a
message receiver. Remove code that registers it as such.
(WebKit::WebNotificationManagerProxy::show): Refactor to differentiate between the notification ID
that came from the web process, and the global notification ID the proxy maintains. Add the mapping
from the global ID to the (web page ID, notification ID) pair.
(WebKit::WebNotificationManagerProxy::cancel): Refactor to take into consideration the web page.
(WebKit::WebNotificationManagerProxy::didDestroyNotification): Refactor to take into consideration
the web page. Fixes a leak where we did not remove the item from the maps. This function is called
from the web process, when the ScriptExecutionContext is destroyed, so we remove it from our maps
before we pass the message along to the provider.
Helper functions that evaluate when a given notification in the map matches the desired parameters.
(WebKit::pageIDsMatch): The notification is associated with the provided page.
(WebKit::pageAndNotificationIDsMatch): The notification is associated with the provided page and is
contained within the list of provided notifications.
(WebKit::WebNotificationManagerProxy::clearNotifications): Changed to only remove notifications
associated with the provided web page, and could include a specific list of notifications. This latter
situation occurs if notifications were associated with an iframe, and that iframe was removed.
There is an O(n) walk that could be make more efficient using another hash map, but that's overhead
for a map that should be small in size anyway.
(WebKit::WebNotificationManagerProxy::providerDidShowNotification): Refactor to take into
consideration the web page.
(WebKit::WebNotificationManagerProxy::providerDidClickNotification): Refactor to take into
consideration the web page.
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Now we need to comb through
the list of global IDs and put them in buckets based on the notification's web pages. After that
is done we can send the DidCloseNotifications() to those pages' processes. There is a possible
extra optimization here where we group based on the page's process instead, to reduce the number
of messages sent to processes.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): When a web page is closed, we clear the notifications associated
with the page.
(WebKit::WebPageProxy::cancelNotification): Forward call to WebNotificationManagerProxy.
(WebKit::WebPageProxy::clearNotifications): Ditto.
(WebKit::WebPageProxy::didDestroyNotification): Ditto.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
- WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Remove extraneous include.
- CMakeLists.txt: Remove WebNotificationManagerProxy.messages.in and related files.
- DerivedSources.pri: Ditto.
- DerivedSources.make: Ditto.
- GNUmakefile.list.am: Ditto.
- WebKit2.xcodeproj/project.pbxproj: Ditto.
- 4:55 PM Changeset in webkit [150784] by
-
- 2 edits in trunk/Source/WebCore
Fix typo that broke the build.
- 4:53 PM Changeset in webkit [150783] by
-
- 4 edits in trunk/Source/WebCore
Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement
https://bugs.webkit.org/show_bug.cgi?id=116842
Reviewed by Antti Koivisto.
- dom/Node.cpp: Removed hasNonEmptyBoundingBox.
- dom/Node.h: Ditto.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::isMouseFocusable): Fixed #if to be more readable and
added more-explicit clearer comments. No behavior change.
(WebCore::hasNonEmptyBox): Added. Has the same code that was in
Node::hasNonEmptyBoundingBox with some additional comments.
(WebCore::HTMLAnchorElement::isKeyboardFocusable): Call hasNonEmptyBox.
- 4:40 PM Changeset in webkit [150782] by
-
- 11 edits in trunk/Source/WebCore
Move isBlockFlowElement and related functions out of the Node class into editing code
https://bugs.webkit.org/show_bug.cgi?id=116846
Reviewed by Antti Koivisto.
- dom/Node.cpp: Removed isBlockFlowElement, enclosingBlockFlowElement, and
inSameContainingBlockFlowElement. These are all editing functions that don't
belong in the Node class, and mostly-deprecated ones to boot.
- dom/Node.h: Ditto.
- dom/Position.cpp:
(WebCore::inSameEnclosingBlockFlowElement): Added. This editing-specific function
is used only here, so put it here.
(WebCore::Position::rendersInDifferentPosition): Updated to call new function above.
(WebCore::Position::leadingWhitespacePosition): Ditto.
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use
deprecatedEnclosingBlockFlowElement at its new location.
(WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph): use
isBlockFlowElement at its new location.
- editing/ReplaceSelectionCommand.cpp:
(WebCore::enclosingInline): Ditto.
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::canonicalPosition): Use deprecatedEnclosingBlockFlowElement
at its new location.
(WebCore::enclosingBlockFlowElement): Ditto. Also added FIXME.
- editing/VisibleSelection.cpp:
(WebCore::makeSearchRange): Ditto.
- editing/htmlediting.cpp:
(WebCore::isBlockFlowElement): Added. Same as the Node::isBlockFlowElement
function, but here because this is an editing function, not suitable as a Node member.
(WebCore::deprecatedEnclosingBlockFlowElement): Ditto. Added "deprecated" to the name
since the Node member function had a comment saying it was deprecated. Also changed so
it tolerates a 0 for an argument, which made it easier for one caller.
- editing/htmlediting.h: Added the two new functions.
- 3:31 PM Changeset in webkit [150781] by
-
- 1 edit3 adds in trunk/PerformanceTests
Add a balanced benchmark for QuerySelector
https://bugs.webkit.org/show_bug.cgi?id=116811
Reviewed by Sam Weinig.
The goal of this benchmark is to have an overview of querySelector as typically used
by webpages.
It uses queries similar to what is used by popular websites and applies somewhat
similar weighting for each type of query.
The tree used for the queries is intentionally kept simple to ensure we measure QuerySelector
a not purely the overhead of traversal.
- CSS/QuerySelector.html: Added.
- CSS/resources/query-selector.html: Added.
- 3:09 PM Changeset in webkit [150780] by
-
- 4 edits9 adds in branches/dfgFourthTier
fourthTier: DFG ArithMod should have the !nodeUsedAsNumber optimizations that ArithDiv has
https://bugs.webkit.org/show_bug.cgi?id=116841
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithMod):
LayoutTests:
- fast/js/dfg-mod-by-neg1-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-mod-by-neg1-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-mod-by-zero-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-mod-by-zero-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-mod-by-neg1-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-mod-by-zero-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js: Added.
(foo):
- 2:59 PM Changeset in webkit [150779] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Clear supression flag when caret changes aren't propogated through
https://bugs.webkit.org/show_bug.cgi?id=116840
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-27
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR339965
We set and clear the flag upon every use. This leaves us vulnerable if
- midway through processing the selection change event is dismissed and
- we don't receive a TouchRelease event
One example of this is while dragging the FCC handle we start typing. To
safeguard against this, if the process change guard is set during a
selection change event, we send out to clear the flag status before returning.
- Api/WebPageClient.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::selectionChanged):
- 2:11 PM Changeset in webkit [150778] by
-
- 2 edits in trunk/Source/WebCore
Add guard around paintForFixedRootBackground
https://bugs.webkit.org/show_bug.cgi?id=116754
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-27
Reviewed by Simon Fraser.
paintForFixedRootBackground is only used when ACCELERATED_COMPOSITING is enabled.
No new tests, no behavior change.
- rendering/RenderLayer.cpp:
(WebCore):
- 2:00 PM Changeset in webkit [150777] by
-
- 2 edits in trunk/Source/WebCore
Remove a leftover Pagepoup from PickerIndicatorElement.h
https://bugs.webkit.org/show_bug.cgi?id=116801
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-27
Reviewed by Anders Carlsson.
No new tests, no behavior change.
- html/shadow/PickerIndicatorElement.h:
(WebCore):
- 1:58 PM Changeset in webkit [150776] by
-
- 5 edits in trunk
[CSS] -webkit-var prefix is case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116829
Reviewed by Darin Adler.
Source/WebCore:
Tests: Added case to fast/css/variables/case-sensitive.html
- css/CSSParser.cpp:
(WebCore::isEqualToCSSCaseSensitiveIdentifier): Add variant to
IsEqualToCSSIdentifier that respects case-sensitivity.
(WebCore::CSSParser::realLex): Use the above method for CSS
variable declarations.
LayoutTests:
- fast/css/variables/case-sensitive.html: Add a
check for case-sensitiveness of the prefix of
variable declarations.
- fast/css/variables/case-sensitive-expected.html: Update.
- 1:39 PM WebKitGTK/2.0.x edited by
- (diff)
- 1:07 PM Changeset in webkit [150775] by
-
- 3 edits in trunk/Source/WebCore
drop-shadow filter with overflow:hidden child misbehaves.
https://bugs.webkit.org/show_bug.cgi?id=109783
Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-27
Reviewed by Simon Fraser.
Applying CSS filters only to the scrollbar rect leaves rendering
artefacts. Filters should skip such partial repaints.
Tests: Test framework uses mock theme for scrollbars. Such scrollbars do not
initiate partial repaints.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintLayerContents):
- rendering/RenderLayer.h:
(RenderLayer):
- 1:04 PM Changeset in webkit [150774] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix take 2.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- 12:58 PM Changeset in webkit [150773] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
- 12:51 PM Changeset in webkit [150772] by
-
- 9 edits1 delete in trunk/Source
Move Windows port off legacy clipboard.
https://bugs.webkit.org/show_bug.cgi?id=116258
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-05-27
Reviewed by Darin Adler.
Source/WebCore:
Clipboard refactor, no new tests.
- dom/Clipboard.h:
- page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingClipboard): Create Clipboard instead of ClipboardWin.
- platform/Pasteboard.h:
(WebCore::Pasteboard::dataObject): Get IDataObject by Clipborad.
(WebCore::Pasteboard::writableDataObject): Get WCDataObject by Clipborad.
- platform/win/ClipboardWin.cpp:
(WebCore::Clipboard::createDragImage): Change parameter name loc to dragLocation.
(WebCore::Clipboard::declareAndWriteDragImage): Implement declareAndWriteDragImage use WCDataObject exposed by Pasteboard.
- platform/win/ClipboardWin.h: Removed.
- platform/win/EditorWin.cpp:
(WebCore::Editor::newGeneralClipboard): Create Clipboard instead of ClipboardWin.
- platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::createForCopyAndPaste): Create a Pasteboard.
(WebCore::Pasteboard::createPrivate): Ditto.
(WebCore::Pasteboard::createForDragAndDrop): Ditto.
(WebCore::Pasteboard::finishCreatingPasteboard): Create Pasteboard use Windows API.
(WebCore::Pasteboard::Pasteboard):
(WebCore::clipboardTypeFromMIMEType): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::clear): Ditto.
(WebCore::Pasteboard::hasData): Ditto.
(WebCore::addMimeTypesForFormat): Ditto.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.
(WebCore::writeURL): Ditto.
(WebCore::Pasteboard::writeString): Ditto.
(WebCore::Pasteboard::setDragImage): Ditto.
(WebCore::Pasteboard::writeRangeToDataObject): Write range to WCDataObject.
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainTextToDataObject): Write PlainText to WCDataObject.
(WebCore::Pasteboard::writePlainText):
(WebCore::pathRemoveBadFSCharacters): Copied from ClipboardWin.cpp.
(WebCore::filesystemPathFromUrlOrTitle): Ditto.
(WebCore::writeFileToDataObject): Ditto.
(WebCore::Pasteboard::writeURLToDataObject): Write URL to WCDataObject.
(WebCore::Pasteboard::writeURL): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::writePasteboard): Copied from Pasteboard::writeClipboard.
(WebCore::Pasteboard::documentFragment): Copied from ClipboardWin.cpp.
(WebCore::Pasteboard::setExternalDataObject): Clipboard can set new IDataObject.
(WebCore::getCachedImage): Copied from ClipboardWin.cpp.
(WebCore::createGlobalImageFileDescriptor): Ditto.
(WebCore::createGlobalImageFileContent): Ditto.
(WebCore::createGlobalHDropContent): Ditto.
(WebCore::Pasteboard::writeImageToDataObject): Expose to make Clipboard implement declareAndWriteDragImage.
(WebCore::Pasteboard::writeURLToWritableDataObject): Ditto.
Source/WebKit/win:
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::willPerformDragSourceAction): Get IDataObject from Pasteboard instead of Clipboard.
(WebDragClient::startDrag): Ditto.
- 12:50 PM Changeset in webkit [150771] by
-
- 13 edits in trunk/Source
PDFPlugin: Main-frame PDFPlugin Accessibility
https://bugs.webkit.org/show_bug.cgi?id=116563
<rdar://problem/13458534>
Reviewed by Sam Weinig.
- WebProcess/Plugins/PDF/PDFLayerControllerDetails.h:
Forward-declare a variety of accessibility methods.
- WebProcess/Plugins/PDF/PDFPlugin.h:
Add convertFromPDFViewToScreen, boundsOnScreen, accessibilityObject, and
storage for our accessibility wrapper.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
Add WKPDFPluginAccessibilityObject.
(-[WKPDFPluginAccessibilityObject accessibilityIsIgnored]):
We want to be included in the accessibility tree.
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:]):
(-[WKPDFPluginAccessibilityObject accessibilityAttributeValue:forParameter:]):
Grab values for accessibility attributes from the relevant sources
(mostly from PDFLayerController).
(-[WKPDFPluginAccessibilityObject readingModel]): Ditto.
(-[WKPDFPluginAccessibilityObject accessibilityAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityParameterizedAttributeNames]):
(-[WKPDFPluginAccessibilityObject accessibilityActionNames]):
Return the set of accessibility attributes, actions, and parameterized
attributes that we support.
(-[WKPDFPluginAccessibilityObject accessibilityIsAttributeSettable:]):
(-[WKPDFPluginAccessibilityObject accessibilitySetValue:forAttribute:]):
Forward some other accessibility methods to PDFLayerController.
(-[WKPDFPluginAccessibilityObject accessibilityFocusedUIElement]):
(-[WKPDFPluginAccessibilityObject accessibilityHitTest:]):
We have no children, so if a hit test makes it to us, it's ours.
(WebKit::PDFPlugin::PDFPlugin):
Make a WKPDFPluginAccessibilityObject and hook it up.
[FIXME: this could use some de-crapifying]
(WebKit::PDFPlugin::convertFromPluginToPDFView):
Transform a point from plugin space to PDFLayerController space.
(WebKit::PDFPlugin::convertFromPDFViewToRootView):
(WebKit::PDFPlugin::convertFromPDFViewToScreen): Added.
(WebKit::PDFPlugin::boundsOnScreen):
Return the PDFPlugin's frame in screen coordinates.
(WebKit::PDFPlugin::accessibilityObject):
Return our accessibility wrapper.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h:
- WebProcess/Plugins/Plugin.h:
(WebKit::Plugin::accessibilityObject):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::accessibilityObject):
- WebProcess/Plugins/PluginView.h:
Add accessibilityObject(), to acquire accessibility wrappers from plugins.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add accessibilityObjectForMainFramePlugin();
- WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm:
(-[WKAccessibilityWebPageObject accessibilityRootObjectWrapper]):
If the main frame has a PluginDocument that has an accessibilityObject,
use that one instead of the WebPage's.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
Return the accessibilityObject from the main-frame PluginDocument, if
there is one.
- WebCore.exp.in: Export AffineTransform::mapRect.
- 12:27 PM Changeset in webkit [150770] by
-
- 6 edits in trunk
[BlackBerry] Find-on-page should be able to convert the active match to selection when clearing all matches
https://bugs.webkit.org/show_bug.cgi?id=116837
Patch by Andy Chen <andchen@blackberry.com> on 2013-05-27
Reviewed by Rob Buis.
PR 291903
Internally reviewed by Mike Fenton.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::findNextString):
- Api/WebPage.h:
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findNextString):
(BlackBerry::WebKit::InPageSearchManager::clearTextMatches):
- WebKitSupport/InPageSearchManager.h:
(InPageSearchManager):
- 11:39 AM Changeset in webkit [150769] by
-
- 2 edits in trunk/Source/WebCore
Checkbox UX update.
https://bugs.webkit.org/show_bug.cgi?id=116838.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-27
Reviewed by Rob Buis.
BlackBerry PR 342302.
Internally Reviewed by Jeff Rogers.
Remove old background and change pressed checkmark image.
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintCheckbox):
- 11:25 AM Changeset in webkit [150768] by
-
- 2 edits in trunk/Source/WebCore
When the background is completely transparent we should be conservative and use the default scrollbar style, not the light one
https://bugs.webkit.org/show_bug.cgi?id=116836
<rdar://problem/13949905>
Reviewed by Simon Fraser.
- page/FrameView.cpp:
(WebCore::FrameView::recalculateScrollbarOverlayStyle):
Don't use the light style when the background is completely transparent.
- 11:09 AM Changeset in webkit [150767] by
-
- 10 edits in trunk
Use ICU_INCLUDE_DIRS in BlackBerry CMake files
https://bugs.webkit.org/show_bug.cgi?id=116210
Reviewed by Rob Buis.
Set and use the ICU_INCLUDE_DIRS variable to avoid
duplicated adding of the ICU include directory.
.:
- Source/cmake/OptionsBlackBerry.cmake:
Source/JavaScriptCore:
- PlatformBlackBerry.cmake:
Source/WebCore:
- PlatformBlackBerry.cmake:
Source/WebKit:
- PlatformBlackBerry.cmake:
Source/WTF:
- wtf/PlatformBlackBerry.cmake:
- 11:04 AM Changeset in webkit [150766] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix subframe target added to new requests
https://bugs.webkit.org/show_bug.cgi?id=116602
Reviewed by Rob Buis.
In some cases we might be adding TargetIsMainFrame to a subframe
request causing an isMainFrame assert.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
Check we are actually loading the main frame before setting
ResourceRequest::TargetIsMainFrame target.
- 10:39 AM Changeset in webkit [150765] by
-
- 10 edits in branches/dfgFourthTier
fourthTier: clean up ArithDiv/ArithMod in the DFG
https://bugs.webkit.org/show_bug.cgi?id=116793
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
This makes ArithDiv and ArithMod behave similarly, and moves both of their
implementations entirely into DFGSpeculativeJIT.cpp into methods named like
the ones for ArithSub/ArithMul.
Specifically, ArithMod now uses the wrap-in-conversion-nodes idiom that
ArithDiv used for platforms that don't support integer division. Previously
ArithMod had its own int-to-double and double-to-int conversions for this
purpose.
As well, this gets rid of confusing methods like compileSoftModulo() (which
did no such thing, there wasn't anything "soft" about it) and
compileIntegerArithDivForX86() (which is accurately named but we don't use
the platform-specific method convention anywhere else).
Finally, this takes the optimized power-of-two modulo operation that was
previously only for ARMv7s, and makes it available for all platforms. Well,
sort of: I actually rewrote it to do what latest LLVM appears to do, which
is a crazy straight-line power-of-2 modulo based on a combination of shifts,
ands, additions, and subtractions. I can kind of understand it well enough
to see that it complies with both C and JS power-of-2 modulo semantics. I've
also confirmed that it does by testing (hence the corresponding improvements
to one of the division tests). But, I don't claim to know exactly how this
code works other than to observe that it is super leet.
Overall, this patch has the effect of killing some code (no more hackish
int-to-double conversions in ArithMod), making some optimization work on
more platforms, and making the compiler less confusing by doing more things
with the same idiom.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGSpeculativeJIT.cpp:
(DFG):
(JSC::DFG::SpeculativeJIT::compileArithDiv):
(JSC::DFG::SpeculativeJIT::compileArithMod):
- dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
LayoutTests:
Reviewed by Mark Hahnenberg.
- fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js:
(myModBy2):
(myModBy1073741824):
- 9:52 AM Changeset in webkit [150764] by
-
- 3 edits in trunk/Source/WebKit2
[WK2][CoordinatedGraphics] Misuse of DrawingAreaProxy::setVisibleContentsRect() in WebView::updateViewportSize()
https://bugs.webkit.org/show_bug.cgi?id=116688
Reviewed by Noam Rosenthal.
Visible contents area passed to DrawingAreaProxy::setVisibleContentsRect()
must be calculated including the page scale factor and avoid crossing the
boundaries of the page contents size. In other words the DrawingArea
must know the actual dimensions of what it being drawn. If the
DrawingArea thinks the visible rectangle is bigger than it is, the
contents will be drawn pixelated and blurry.
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::visibleContentsSize):
(WebKit):
- UIProcess/CoordinatedGraphics/WebView.h:
(WebKit::WebView::contentsSize):
(WebView):
- 9:10 AM Changeset in webkit [150763] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] WebKitWebView child widgets are not rendered with recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=116794
Reviewed by Xan Lopez.
Since rev d22fd7223c75f4720ddb982c659efb0d8d7543c4 of GTK+ expose
events are not propagated to child GdkWindows anymore, and child
widgets are rendered via gtk_container_propagate_draw(). Since all
our children have its own GdkWindow (auth widget, inspector view
and windowed plugins) we don't propagate the draw signal making
them invisible with current GTK+.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseDraw): Chain up to the parent draw(), so it's
propagated to the children. This shouldn't have any effect in
previous versions of GTK+ because gtk_container_propagate_draw()
returned early when the child widget had its own GdkWindow.
- 9:01 AM Changeset in webkit [150762] by
-
- 12 edits in trunk/Source/WebCore
Tighten FontGlyphs::glyphDataAndPageForCharacter to take FontDescription
https://bugs.webkit.org/show_bug.cgi?id=116823
Reviewed by Andreas Kling.
FontGlyphs does not need to know about Font anymore.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
- platform/graphics/Font.h:
(WebCore::Font::isPlatformFont):
(WebCore::Font::glyphDataAndPageForCharacter):
(Font):
- platform/graphics/FontCache.h:
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
- platform/graphics/FontFallbackList.h:
(WebCore):
(WebCore::FontGlyphs::createForPlatformFont):
Tweaked the name.
(WebCore::FontGlyphs::isForPlatformFont):
Move knowledge about platform font to FontGlyphs as it is needed for resolving system fallback on Mac.
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
More descriptive name and tighter interface.
- 8:52 AM Changeset in webkit [150761] by
-
- 5 edits in trunk/Source/WebCore
[CSSRegions] Prevent unnecessary copy of LayoutRect objects
https://bugs.webkit.org/show_bug.cgi?id=116828
Reviewed by Andreas Kling.
Use const references for parameter passing.
No functional change, no new tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintFlowThreadPortionInRegion):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
- rendering/RenderRegion.h:
- 8:51 AM Changeset in webkit [150760] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] REGRESSION(r150071): Animation performance issues in some websites with CSS transforms
https://bugs.webkit.org/show_bug.cgi?id=116724
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-27
Reviewed by Rob Buis.
Add another bool variable m_previousFrameDone to make sure we
don't start a new frame until the previous one has been done. Also
make sure we pass the animation start time to
serviceScriptedAnimations().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_previousFrameDone and m_monotonicAnimationStartTime.
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
Return early if previous frame is not done. Otherwise set
m_previousFrameDone to false and save the animation start time.
(BlackBerry::WebKit::WebPagePrivate::serviceAnimations): Call
serviceScriptedAnimations() passing the saved animation start time
and reset m_animationScheduled and m_previousFrameDone.
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
Call WebPagePrivate::serviceAnimations().
- Api/WebPage_p.h:
(WebPagePrivate):
- 8:45 AM Changeset in webkit [150759] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Reveal HTTP error code for XHR even if there is no response body
https://bugs.webkit.org/show_bug.cgi?id=116543
Reviewed by Rob Buis.
Reviewed internally by Joe Mason.
It's a regression introduced by r132556.
BlackBerry is doing friendly HTTP error handling: if there is no response body
for an HTTP error it will display an error message made by the port. But for a
XHR request, which usually does not result in displaying error messages to the
end user, HTTP error code should be revealed to let the JavaScript know what
the actual server error code is.
Covered by existing tests:
ManualTests/blackberry/head-xhr-nonexistant-file.html
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::shouldNotifyClientFailed):
- 8:43 AM Changeset in webkit [150758] by
-
- 2 edits in trunk/Source/WebKit2
Reset all clients on WebPage close
https://bugs.webkit.org/show_bug.cgi?id=112334
Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-27
Reviewed by Anders Carlsson.
We do not reset the clients on WebPage::close(), so there's a
small chance that someone will try to access them after that. This
won't work and will generally cause runtime warnings, crashes or
other issues. Reset them all to null to prevent this situation.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
- 8:37 AM Changeset in webkit [150757] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove encoding parameter from FrameLoaderClientBlackBerry::receivedData()
https://bugs.webkit.org/show_bug.cgi?id=116598
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-27
Reviewed by Rob Buis.
It's no longer needed since the encoder now checks the override encoding.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::committedLoad): Call
receivedData() passing the DocumentLoader instead of the text
encoding.
(WebCore::FrameLoaderClientBlackBerry::receivedData): Call
DocumentLoader::commitData() directly.
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
- 8:35 AM Changeset in webkit [150756] by
-
- 6 edits10 moves in trunk/Source/WebKit
[BlackBerry] Move PagePopup implementation to WebKitSupport
https://bugs.webkit.org/show_bug.cgi?id=116824
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-27
Reviewed by Rob Buis.
Source/WebKit:
- PlatformBlackBerry.cmake: Update new file paths and names.
Source/WebKit/blackberry:
After r150434 PagePopup implementation in BlackBerry port is
independent from WebCore. The classes are now in the
BlackBerry::WebKit namespace so they can be moved from
WebCoresupport to WebKitSupport and renamed to remove the
BlackBerry suffix which is now redundant. Also, now that the
implementation is not shared, it can be simplified a bit more.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Update to
API changes.
(BlackBerry::WebKit::WebPage::initPopupWebView): Ditto.
(BlackBerry::WebKit::WebPagePrivate::openPagePopup): Ditto.
(BlackBerry::WebKit::WebPagePrivate::closePagePopup): Ditto.
(BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Ditto.
- Api/WebPage.h:
(WebKit): Ditto.
- Api/WebPage_p.h:
(WebKit): Ditto.
(WebPagePrivate): Rename m_selectPopup as m_pagePopup, since it
can also point to a color picker or date picker page popup. Also
use RefPtr instead of raw pointer.
- WebKitSupport/ColorPickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.cpp.
(BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
(BlackBerry::WebKit::ColorPickerClient::generateHTML):
(BlackBerry::WebKit::ColorPickerClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::ColorPickerClient::didClosePopup):
- WebKitSupport/ColorPickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/ColorPickerClient.h.
- WebKitSupport/DatePickerClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.cpp.
(BlackBerry::WebKit::DatePickerClient::DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::~DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::generateHTML):
(BlackBerry::WebKit::DatePickerClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::DatePickerClient::didClosePopup):
(BlackBerry::WebKit::DatePickerClient::generateDateLabels):
- WebKitSupport/DatePickerClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/DatePickerClient.h.
- WebKitSupport/PagePopup.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.cpp.
(BlackBerry::WebKit::PagePopup::PagePopup):
(BlackBerry::WebKit::PagePopup::~PagePopup):
(BlackBerry::WebKit::PagePopup::initialize): Renamed as initialize
and made void, since it always returned true and the callers
ignored the return value.
(BlackBerry::WebKit::PagePopup::writeDocument): Renamed from
generateHTML for consistency with PagePopupClient::writeDocument()
and to avoid confusion with generateHTML method in the clients
that create the HTML contents but they don't write the document.
(BlackBerry::WebKit::PagePopup::setValueAndClosePopupCallback):
Make it static member of PagePopup since the JS object now holds a
reference of PagePopup instance as private data.
(BlackBerry::WebKit::popUpExtensionInitialize): Take a reference
of the PagePopup instance saved as private data of the JS object.
(BlackBerry::WebKit::popUpExtensionFinalize): Unref the PagePopup
instance saved as private data of the JS object.
(BlackBerry::WebKit::PagePopup::installDOMFunction): Instead of
saving the client as private data of the JS object using a wrapper
refcounted object, save the PagePopup instance that is now
refcounted and access the client from the PagePopup instance in
the callback.
(BlackBerry::WebKit::PagePopup::close): Renamed from closePagePopup
since PagePopup::closePagePopup was a bit redundant.
- WebKitSupport/PagePopup.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerry.h.
(BlackBerry::WebKit::PagePopup::create): Static member to create
instances of PagePopup now that it's refcounted.
- WebKitSupport/PagePopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp.
(BlackBerry::WebKit::PagePopupClient::PagePopupClient):
(BlackBerry::WebKit::PagePopupClient::closePopup):
(BlackBerry::WebKit::PagePopupClient::didClosePopup):
(BlackBerry::WebKit::PagePopupClient::contentSize):
(BlackBerry::WebKit::PagePopupClient::writeDocument):
- WebKitSupport/PagePopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/PagePopupBlackBerryClient.h.
- WebKitSupport/SelectPopupClient.cpp: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp.
(BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::~SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::generateHTML):
(BlackBerry::WebKit::SelectPopupClient::setValueAndClosePopup):
Return early if popup has been closed already.
(BlackBerry::WebKit::SelectPopupClient::didClosePopup):
(BlackBerry::WebKit::SelectPopupClient::notifySelectionChange):
- WebKitSupport/SelectPopupClient.h: Renamed from Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.h.
- 8:21 AM Changeset in webkit [150755] by
-
- 3 edits in trunk/LayoutTests
[EFL][GTK] fast/regions/offsetLeft-offsetTop-in-multiple-regions.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116808
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-27
Reviewed by Anders Carlsson.
The test was failing because of differences between different fonts.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt:
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
- 8:03 AM Changeset in webkit [150754] by
-
- 2 edits in trunk/Source/WebCore
Adjust date input width.
https://bugs.webkit.org/show_bug.cgi?id=100760.
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-27
Reviewed by Rob Buis.
BlackBerry PR 343497.
Internally Reviewed by Jeff Rogers.
Set width to auto to fit the string length.
- css/themeBlackBerry.css:
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
- 6:51 AM BadContent edited by
- Add a spamming email that was creating irrelevant attachments. (diff)
- 6:32 AM Changeset in webkit [150753] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Notify WebProcess in WebKitURISchemeRequest when we fail to read the user InputStream
https://bugs.webkit.org/show_bug.cgi?id=114347
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-27
Reviewed by Carlos Garcia Campos.
While processing a WebKitURISchemeRequest if there is any error reading
the InputStream provided by the user (for example the stream is already
closed) we have to notify the WebProcess that the request has failed.
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
(webkitURISchemeRequestReadCallback): Get the error from
g_input_stream_read_finish() and use it to call
webkit_uri_scheme_request_finish_error() in order to finish the failing
WebKitURISchemeRequest properly.
- UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextURIScheme): Modify test to check the new situation using
an already closed InputStream.
- 6:25 AM Changeset in webkit [150752] by
-
- 4 edits in trunk/Source/WebCore
Document::setHoveredNode() should be setHoveredElement().
<http://webkit.org/b/116819>
Reviewed by Antti Koivisto.
Only Elements can be hovered, teach Document about this.
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::dispose):
(WebCore::Document::detach):
m_hoverNode => m_hoveredElement.
Removed hoverNode() and setHoverNode() since those were only used internally.
(WebCore::Document::updateHoverActiveState):
Updated for hovered things always being Elements.
(WebCore::Document::hoveredElementDidDetach):
- dom/Element.cpp:
(WebCore::Element::detach):
Renamed Document::hoveredNodeDetached() to hoveredElementDidDetach() and fix it up
following the same pattern as elementInActiveChainDidDetach().
- 6:00 AM Changeset in webkit [150751] by
-
- 2 edits in trunk/Source/WTF
[Qt] Enable parallel GC. Probably it has been fixed in r131791.
https://bugs.webkit.org/show_bug.cgi?id=90957
Reviewed by Csaba Osztrogonác.
- wtf/Platform.h:
- 5:48 AM Changeset in webkit [150750] by
-
- 2 edits in trunk/Source/WebCore
[Qt] REGRESSION(r150716): It made 15 inspector and 1 mozilla test to assert
https://bugs.webkit.org/show_bug.cgi?id=116822
Reviewed by Andreas Kling.
The input fontDescription may have more than one family defined.
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
- 5:33 AM Changeset in webkit [150749] by
-
- 6 edits in trunk/Source
[Qt][Win] Input events aren't mapped properly with windowless plugins.
https://bugs.webkit.org/show_bug.cgi?id=116094
Reviewed by Tor Arne Vestbø.
Source/WebCore:
The events are first sent properly but Flash then immediately repaints
and this causes flickering painting.
The issue is that Flash seems to be doing some input event tracking of
its own internally, using the HWND returned through NPN_GetValue(NPNVnetscapeWindow).
We are currently using two coordinate systems for windowless plugins on Windows with Qt:
- FrameView coordinates: Used for input events and ajusted with the WM_WINDOWPOSCHANGED message
- Drawable coordinates: Used by WM_PAINT and adjusted with NPP_SetWindow
This patch fixes the bug by mapping input events to the native window returned
as NPNVnetscapeWindow instead of the FrameView to ensure that those coordinates will match
the ones used by Flash internally.
With this we shouldn't be using FrameView coordinates anywhere for windowless plugins
on Windows with Qt.
- platform/qt/QWebPageClient.h:
(QWebPageClient):
Added mapToOwnerWindow to the interface, mapping from the FrameView up to the wrapping nativeParentWidget.
- plugins/win/PluginViewWin.cpp:
(WebCore::contentsToNativeWindow):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::handleMouseEvent):
Source/WebKit/qt:
- WidgetSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::mapToOwnerWindow):
(WebCore::PageClientQGraphicsWidget::makeOpenGLContextCurrentIfAvailable):
(WebCore::PageClientQGraphicsWidget::screenNumber):
(WebCore::PageClientQGraphicsWidget::geometryRelativeToOwnerWidget):
(WebCore::PageClientQGraphicsWidget::mapToOwnerWindow):
(WebCore::PageClientQGraphicsWidget::graphicsItemVisibleRect):
(WebCore::PageClientQGraphicsWidget::firstGraphicsView):
Extracted this common logic from makeOpenGLContextCurrentIfAvailable,
screenNumber, geometryRelativeToOwnerWidget and graphicsItemVisibleRect
to be able to use it in mapToOwnerWindow.
- WidgetSupport/PageClientQt.h:
(PageClientQWidget):
(PageClientQGraphicsWidget):
- 5:23 AM Changeset in webkit [150748] by
-
- 2 edits in trunk/Source/JavaScriptCore
MacroAssemblerARM should use xor to swap registers instead of move
https://bugs.webkit.org/show_bug.cgi?id=116306
Reviewed by Zoltan Herczeg.
Change register swapping to xor from move and this way we don't need
temporary register anymore.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::swap):
- 4:05 AM Changeset in webkit [150747] by
-
- 13 edits in trunk/Source/WebCore
Tighten FontGlyphs interfaces to take FontDescription instead of Font
https://bugs.webkit.org/show_bug.cgi?id=116818
Reviewed by Andreas Kling.
This gives better understanding of what the actual inputs are.
- WebCore.exp.in:
- platform/graphics/Font.h:
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::isFixedPitch):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData):
- platform/graphics/FontCache.h:
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::determinePitch):
(WebCore::FontGlyphs::realizeFontDataAt):
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
- platform/graphics/FontFallbackList.h:
(WebCore::FontGlyphs::primaryFontData):
(WebCore::FontGlyphs::isFixedPitch):
(WebCore::FontGlyphs::primarySimpleFontData):
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
- platform/graphics/freetype/FontCacheFreeType.cpp:
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::similarFontPlatformData):
Drop get* naming and make this Mac only as no other platform has it.
- platform/graphics/qt/FontCacheQt.cpp:
- platform/graphics/win/FontCacheWin.cpp:
- platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore):
- 3:27 AM Changeset in webkit [150746] by
-
- 2 edits in trunk/LayoutTests
New test direct-pattern-compositing-contain-no-repeat.html fails on Mac
https://bugs.webkit.org/show_bug.cgi?id=116816
Modified the layer in the reference to still be composited, but have invisible painted content.
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-27
Reviewed by Andreas Kling.
- compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.html:
- 3:23 AM Changeset in webkit [150745] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 2:45 AM Changeset in webkit [150744] by
-
- 5 edits in trunk/Source/WebCore
Strengthen typing of detaching an Element from Document's :active chain.
<http://webkit.org/b/116815>
Reviewed by Antti Koivisto.
Tiny cleanup now that the :active chain can only contain elements.
Rename Document::activeChainNodeDetached() to elementInActiveChainDidDetach().
- dom/Element.cpp:
(WebCore::Element::detach):
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::elementInActiveChainDidDetach):
Rename, take Element*, remove silly condition that was always true.
- 2:41 AM Changeset in webkit [150743] by
-
- 11 edits in trunk/Source/WebCore
[CSS Regions] Remove the offsetFromLogicalTopOfFirstPage parameter from layout functions
https://bugs.webkit.org/show_bug.cgi?id=116441
Reviewed by David Hyatt.
The patch changes the following things:
- exposes offsetFromLogicalTopOfFirstPage() to all the RenderBoxes;
- offsetFromLogicalTopOfFirstPage() is now safe to call from any box inside a flow thread, not only the
currently being laid out;
- removes the offsetFromLogicalTopOfFirstPage parameter from all the layout functions
that didn't actually required it; when the value is necessary, the offsetFromLogicalTopOfFirstPage
function is called instead;
- RenderFlowThread now handles its own logic for obtaining the offset from logical top of the first
region for a box, based on the layout states pushed on RenderView; it provides a better caching mechanism
that can be used for all the ancestor containing blocks of the current box being laid out.
The RenderBoxRegionInfo structures are cached only based on the box and the region. This means that
passing around a value for offsetFromLogicalTopOfFirstPage different in some cases than others was
risky. If there is a possibility of having a different box info result for a different offset
then the cache is not working correctly.
Tests: No function change, no tests.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::getClearDelta):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
(WebCore::RenderBlock::logicalWidthChangedInRegions):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::availableLogicalWidthForContent):
(WebCore::RenderBlock::startOffsetForContent):
(WebCore::RenderBlock::endOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::offsetFromLogicalTopOfFirstPage):
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::hasCachedOffsetFromLogicalTopOfFirstRegion):
(WebCore::RenderFlowThread::cachedOffsetFromLogicalTopOfFirstRegion):
(WebCore::RenderFlowThread::setOffsetFromLogicalTopOfFirstRegion):
(WebCore::RenderFlowThread::clearOffsetFromLogicalTopOfFirstRegion):
(WebCore::RenderFlowThread::currentActiveRenderBox):
(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
- rendering/RenderFlowThread.h:
- rendering/RenderTable.cpp:
(WebCore::RenderTable::updateLogicalWidth):
- rendering/RenderView.cpp:
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
(WebCore::RenderView::popLayoutStateForCurrentFlowThread):
- rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
- 2:21 AM Changeset in webkit [150742] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Greening bots.
- platform/qt-5.0-wk1/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- 2:13 AM Changeset in webkit [150741] by
-
- 2 edits in trunk/Source/WebCore
Active DOM objects stopped twice
https://bugs.webkit.org/show_bug.cgi?id=116524
Reviewed by Alexey Proskuryakov.
Only iterate over all active DOM object to stop them once.
To ensure later created active DOM objects are stopped,
suspendActiveDOMObjectIfNeeded now also stops active DOM objects
if needed. This also fixes an existing bug when active DOM
objects were created after stopActiveDOMObjects had been called.
Two existing tests creates new active DOM objects after stopActiveDOMObjects
has been called:
fast/dom/xmlhttprequest-constructor-in-detached-document.html
fast/dom/Window/timer-null-script-execution-context.html
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjectIfNeeded):
- 1:34 AM Changeset in webkit [150740] by
-
- 1 edit1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/plugins/mouse-events-expected.txt: Added. Rebaselining after r150558.
- 1:22 AM Changeset in webkit [150739] by
-
- 3 edits in trunk/LayoutTests
Unreviewed GTK gardening.
Adding failure expectations for the current test failures.
- platform/gtk-wk1/TestExpectations:
- platform/gtk/TestExpectations:
- 1:20 AM Changeset in webkit [150738] by
-
- 3 edits in trunk/Source/WebCore
Remove redundant CachedRawResource::loader()
https://bugs.webkit.org/show_bug.cgi?id=116805
Reviewed by Andreas Kling.
Just remove redundant code, no test case needed.
- loader/cache/CachedRawResource.cpp:
- loader/cache/CachedRawResource.h:
- 1:02 AM WebKitGTK/2.0.x edited by
- (diff)
- 12:50 AM Changeset in webkit [150737] by
-
- 2 edits1 add in trunk/LayoutTests
Unreviewed GTK gardening.
- 12:20 AM Changeset in webkit [150736] by
-
- 2 edits in trunk/Source/WebCore
WinCE build TLC: Node::active() moved to Element.
- rendering/RenderThemeWinCE.cpp:
(WebCore::RenderThemeWinCE::paintSearchFieldCancelButton):
May 26, 2013:
- 11:55 PM Changeset in webkit [150735] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Make screen updates dependent on the existence of a drawing buffer.
https://bugs.webkit.org/show_bug.cgi?id=116539
Internal PR 330917
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-26
Reviewed by Carlos Garcia Campos.
Internally reviewed by Xiaobo Wang and Arvid Nilsson.
This reduces complexity by relying on the current state,
rather than the suspend counter, which in turn makes it
possible to simplify the code in setCompositor().
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateSuspendScreenUpdateState):
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):
- 7:33 PM Changeset in webkit [150734] by
-
- 3 edits in trunk/Source/WebCore
CSSParser::parseImageResolution doesn't need a parameter.
https://bugs.webkit.org/show_bug.cgi?id=116755
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-05-26
Reviewed by Darin Adler.
parseImageResolution() can get CSSPraserValueList from m_valueList directly.
No new tests, no behavior change.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseImageResolution):
- css/CSSParser.h:
- 7:07 PM Changeset in webkit [150733] by
-
- 7 edits in trunk/Source/WebCore
Turn TreeScope::focusedNode() into focusedElement().
<http://webkit.org/b/116802>
Reviewed by Darin Adler.
For the hundredth time, only Elements can be focused!
This change mostly reverts r121079 since that made things unnecessarily complicated
just to tweak the behavior of ShadowRoot.activeElement, an API that we don't expose.
Finding a TreeScope's focused element now does a simple walk up the parent chain instead
of running the full Shadow DOM re-targeting algorithm.
(WebCore::TreeScope::focusedElement):
Simplify and return Element* instead of Node*.
- dom/TreeScope.h:
- dom/TreeScope.cpp:
(WebCore::focusedFrameOwnerElement):
Make this return Element* as the name already suggested.
- dom/Document.cpp:
(WebCore::Document::removeFocusedNodeOfSubtree):
- dom/Element.cpp:
(WebCore::Element::blur):
- dom/ShadowRoot.h:
(WebCore::ShadowRoot::activeElement):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::activeElement):
Simplified call sites that were paranoid about getting a non-Element focused node.
- 6:57 PM Changeset in webkit [150732] by
-
- 3 edits in trunk/Source/WebKit2
The public WK header file should not include WKAPICast.h
https://bugs.webkit.org/show_bug.cgi?id=115230
Patch by Changhun Kang <temoochin@company100.net> on 2013-05-26
Reviewed by Darin Adler.
Otherwise, WebKit internal headers are exposed.
No new tests. No change in behavior.
- UIProcess/API/C/soup/WKSoupRequestManager.h:
- UIProcess/soup/WebSoupRequestManagerClient.h:
- 6:44 PM Changeset in webkit [150731] by
-
- 3 edits in trunk/Source/WebCore
Plugins with no src but valid type should not snapshot
https://bugs.webkit.org/show_bug.cgi?id=116799
<rdar://problem/13695911>
Reviewed by Simon Fraser.
There are a few plug-ins around that don't take any source content
via the src attribute, but rather just load the binary based on the
mime-type. In those cases we shouldn't snapshot until we have a
mechanism to do so.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn):
Add MIMEType logging, and detect the case of no src but valid type.
- html/HTMLPlugInImageElement.h: Add another SnapshotReason enum for
this special case.
- 6:41 PM Changeset in webkit [150730] by
-
- 8 edits in trunk/Source/WebCore
Encapsulate FontGlyphs
https://bugs.webkit.org/show_bug.cgi?id=116803
Reviewed by Andreas Kling.
FontGlyphs is unfriending Font. Give it a real class interface and some actual code.
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
- platform/graphics/Font.h:
(WebCore::Font::glyphDataForCharacter):
(WebCore::Font::glyphDataAndPageForCharacter):
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::isInRange):
(WebCore::shouldIgnoreRotation):
(WebCore::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation):
Helpers from FontFastPath.cpp.
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
This is the primary interface. The code moves here from FontFastPath.cpp.
- platform/graphics/FontFallbackList.h:
(WebCore::FontGlyphs::createForPlatformData):
Remove setPlatformData in favor of constructor.
(WebCore::FontGlyphs::primarySimpleFontData):
- platform/graphics/FontFastPath.cpp:
- platform/graphics/GraphicsContext.h:
Remove a stray function definition also called setPlatformFont().
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- 6:25 PM Changeset in webkit [150729] by
-
- 2 edits in trunk/Source/WTF
[WINCE] Add wtf_bsearch()
https://bugs.webkit.org/show_bug.cgi?id=116528
Reviewed by Darin Adler.
r149833 introduced usage of ::bsearch(), which does not exist on Windwos CE.
Add our own implementation of this function as wtf_bsearch and define
bsearch as wtf_bsearch to fix compilation on Windwos CE.
- wtf/StdLibExtras.h:
(wtf_bsearch):
- 5:00 PM Changeset in webkit [150728] by
-
- 2 edits in trunk/Source/WebCore
Remove a leftover CALENDAR_PICKER from LocaleNone.cpp
https://bugs.webkit.org/show_bug.cgi?id=116800
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-26
Reviewed by Kent Tamura.
No new tests, no behavior change.
- platform/text/LocaleNone.cpp:
(LocaleNone):
- 4:39 PM Changeset in webkit [150727] by
-
- 9 edits in trunk/Source/WebCore
Rename FontFallbackList to FontGlyphs
https://bugs.webkit.org/show_bug.cgi?id=116797
Reviewed by Andreas Kling.
Maybe it was a fallback list once. Nowadays its purpose is to cache realized glyphs and related data.
File renaming will be done separately.
- WebCore.exp.in:
- platform/graphics/Font.cpp:
(WebCore::Font::Font):
(WebCore::Font::operator=):
(WebCore::Font::operator==):
Refactored to early return style.
(WebCore::Font::update):
(WebCore::Font::width):
- platform/graphics/Font.h:
(Font):
(WebCore::Font::glyphs):
(WebCore::Font::loadingCustomFonts):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
- platform/graphics/FontCache.h:
(FontCache):
- platform/graphics/FontFallbackList.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::FontGlyphs::invalidate):
(WebCore::FontGlyphs::releaseFontData):
(WebCore::FontGlyphs::determinePitch):
(WebCore::FontGlyphs::realizeFontDataAt):
Renamed for clarity along with m_fontList -> m_realizedFontData.
(WebCore::FontGlyphs::setPlatformFont):
- platform/graphics/FontFallbackList.h:
(FontGlyphs):
(WebCore::FontGlyphs::GlyphPagesStateSaver::GlyphPagesStateSaver):
(WebCore::FontGlyphs::GlyphPagesStateSaver::~GlyphPagesStateSaver):
(GlyphPagesStateSaver):
(WebCore::FontGlyphs::create):
(WebCore::FontGlyphs::~FontGlyphs):
(WebCore::FontGlyphs::primaryFontData):
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::glyphDataAndPageForCharacter):
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter):
- 4:23 PM Changeset in webkit [150726] by
-
- 2 edits in trunk/Tools
Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 3:44 PM Changeset in webkit [150725] by
-
- 3 edits in trunk/Tools
WKR and webkitbot build fixes.
- Scripts/webkitpy/tool/bot/irc_command.py:
(RollChromiumDEPS.execute):
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 3:35 PM Changeset in webkit [150724] by
-
- 13 edits2 deletes in trunk/Source
Remove ENABLE_CALENDAR_PICKER
https://bugs.webkit.org/show_bug.cgi?id=116795
Reviewed by Ryosuke Niwa.
Source/WebCore:
This feature was used only by Chromium port.
- Resources/pagepopups/calendarPicker.css: Removed.
- Resources/pagepopups/calendarPicker.js: Removed.
- css/html.css:
- platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::LocaleICU):
(WebCore):
- platform/text/LocaleICU.h:
(LocaleICU):
- platform/text/PlatformLocale.h:
(Locale):
- platform/text/mac/LocaleMac.h:
(LocaleMac):
- platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::monthLabels):
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::LocaleWin):
(WebCore::LocaleWin::monthLabels):
- platform/text/win/LocaleWin.h:
(LocaleWin):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
The list was wrong. Blackberry port doesn't use CALENDAR_PICKER code.
Source/WTF:
- wtf/FeatureDefines.h:
- 3:32 PM Changeset in webkit [150723] by
-
- 2 edits in trunk/Tools
roll-chromium-deps doesn't repeat the full name.
Rubber-stamped by Andreas Kling.
- Scripts/webkitpy/tool/bot/irc_command.py:
(RollChromiumDEPS.execute):
- 3:23 PM Changeset in webkit [150722] by
-
- 8 edits in trunk/Source/WebCore
Move :active chain participation state from Node to Element.
<http://webkit.org/b/116786>
Reviewed by Antti Koivisto.
Only Elements can be in the :active chain so move the logic there from Node.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
Add isElementNode() type checks when updating the :active chain.
- dom/Node.h:
- dom/Node.cpp:
(WebCore::Node::detach):
- dom/Element.cpp:
(WebCore::Element::detach):
Move the remaining logic for detaching from the UserActionElementSet to Element.
(WebCore::Element::isUserActionElementInActiveChain):
- dom/Element.h:
(WebCore::Element::inActiveChain):
Move all the :active chain stuff from Node to Element.
- dom/UserActionElementSet.cpp:
(WebCore::UserActionElementSet::didDetach):
- dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::isInActiveChain):
(WebCore::UserActionElementSet::setInActiveChain):
UserActionElementSet now only takes Element* in its API.
- 11:44 AM Changeset in webkit [150721] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: cti_optimize shouldn't allow GCs to get in the way of it seeing the state of its CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=116748
Reviewed by Geoffrey Garen.
This fixes the following race: an optimized version of our code block could be installed
by the GC just as we return from completeAllReadyPlansForVM(), leading us to believe
that the code block isn't ready yet even though it is. Currently this triggers a
RELEASE_ASSERT. We could remove that assertion, but then this case would lead to the
code in question entering into optimizeAfterWarmUp mode. That seems pretty wasteful.
Fix the bug, and hopefully close the door on these bugs for a while, by wrapping
cti_optimize in a DeferGC. There is little downside to doing so since the only
"allocations" in cti_optimize are the ones where we inform the GC about extra memory
usage.
I had a more comprehensive solution (see the bug, "work in progress" patch) but that
one involved adding *more* raciness to cti_optimize. I decided that was a less good
approach once I came to appreciate the simplicity of just using DeferGC.
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- 10:42 AM Changeset in webkit [150720] by
-
- 4 edits9 adds in branches/dfgFourthTier
Merge trunk r150694.
Source/JavaScriptCore:
2013-05-25 Filip Pizlo <fpizlo@apple.com>
We broke (-231/-1)|0 in the DFG
https://bugs.webkit.org/show_bug.cgi?id=116767
Reviewed by Andreas Kling.
The bug is that we were assuming that in the -231 case, we already had -231
in the result register. This was a wrong assumption.
- dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
LayoutTests:
2013-05-25 Filip Pizlo <fpizlo@apple.com>
We broke (-231/-1)|0 in the DFG
https://bugs.webkit.org/show_bug.cgi?id=116767
Reviewed by Andreas Kling.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.js: Added. (foo):
- fast/js/script-tests/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.js: Added. (foo):
- fast/js/script-tests/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js: Added. (foo):
- 9:20 AM Changeset in webkit [150719] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove FontFamily.h/.cpp
https://bugs.webkit.org/show_bug.cgi?id=116788
Reviewed by Anders Carlsson.
Empty files.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FontDescription.h:
- platform/graphics/FontFamily.cpp: Removed.
- platform/graphics/FontFamily.h: Removed.
- 8:15 AM Changeset in webkit [150718] by
-
- 3 edits in trunk/Source/WebKit/win
Another build fix.
Not reviewed.
- DOMCoreClasses.cpp:
(DOMElement::font):
- FullscreenVideoController.cpp:
(FullscreenVideoController::draw):
- 8:11 AM Changeset in webkit [150717] by
-
- 2 edits in trunk/Source/WebKit/win
Build fix
Not reviewed.
- WebKitGraphics.cpp:
(makeFont):
- 7:50 AM Changeset in webkit [150716] by
-
- 29 edits in trunk/Source/WebCore
Use Vector instead of custom linked list for font families
https://bugs.webkit.org/show_bug.cgi?id=116783
Reviewed by Andreas Kling.
Get rid of FontFamily and SharedFontFamily.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasSameFont):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontFamilyFromStyle):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyFontFamily::applyInheritValue):
(WebCore::ApplyPropertyFontFamily::applyInitialValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::styleForDocument):
(WebCore::StyleResolver::initializeFontStyle):
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::font):
(WebCore::CanvasRenderingContext2D::setFont):
- page/PrintContext.cpp:
(WebCore::PrintContext::pageProperty):
- platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::systemFont):
- platform/graphics/Font.h:
(WebCore::Font::firstFamily):
(WebCore::Font::familyCount):
(WebCore::Font::familyAt):
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::getFontData):
- platform/graphics/FontDescription.cpp:
(SameSizeAsFontDescription):
- platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::familyCount):
(WebCore::FontDescription::firstFamily):
(WebCore::FontDescription::familyAt):
(WebCore::FontDescription::families):
(WebCore::FontDescription::useFixedDefaultSize):
(WebCore::FontDescription::setOneFamily):
(WebCore::FontDescription::setFamilies):
(WebCore::FontDescription::adoptFamilies):
(WebCore::FontDescription::operator==):
- platform/graphics/FontFamily.cpp:
- platform/graphics/FontFamily.h:
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getSimilarFontPlatformData):
- platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getLastResortFallbackFont):
- platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::systemFont):
- platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::controlFont):
- platform/qt/RenderThemeQStyle.cpp:
(WebCore::RenderThemeQStyle::adjustButtonStyle):
- platform/text/transcoder/FontTranscoder.cpp:
(WebCore::FontTranscoder::converterType):
- platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
- rendering/RenderText.cpp:
(WebCore::RenderText::styleDidChange):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::computeIntrinsicLogicalWidths):
- rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentLogicalWidth):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::systemFont):
(WebCore::RenderThemeSafari::setFontFromControlSize):
- rendering/RenderThemeWin.cpp:
(WebCore::fillFontDescription):
- 7:29 AM Changeset in webkit [150715] by
-
- 17 edits in trunk/Source/WebCore
Move "active" state logic from Node to Element.
<http://webkit.org/b/116785>
Reviewed by Antti Koivisto.
Resolve another 7 year old FIXME by merging the "active" state logic from Node and ContainerNode
and moving it all to Element instead.
- dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::isActive):
(WebCore::UserActionElementSet::setActive):
- dom/ContainerNode.cpp:
- dom/ContainerNode.h:
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
(WebCore::Element::active):
- dom/Element.cpp:
(WebCore::Element::isUserActionElementActive):
(WebCore::Element::setActive):
Moved here from Node/ContainerNode.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isPressed):
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
(WebCore::Document::updateHoverActiveState):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isPressed):
(WebCore::RenderTheme::isSpinUpButtonPartPressed):
- rendering/RenderThemeMac.mm:
(WebCore::getMediaUIPartStateFlags):
(WebCore::RenderThemeMac::updatePressedState):
- platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::getMediaControlForegroundColor):
Check that the inspected Node is an Element before asking if it's active.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setActive):
Call the right superclass.
- html/HTMLAnchorElement.h:
- html/HTMLLabelElement.h:
- html/shadow/MediaControlElementTypes.h:
Sprinkle OVERRIDE>
- 6:32 AM Changeset in webkit [150714] by
-
- 7 edits in trunk/Source/WebCore
Move Node::dispatchSimulatedClick() to Element.
<http://webkit.org/b/116784>
Reviewed by Antti Koivisto.
Only Elements use the dispatchSimulatedClick() functionality, so move it there.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::dispatchSimulatedClick):
- dom/EventDispatcher.h:
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
- 5:10 AM Changeset in webkit [150713] by
-
- 8 edits in trunk/Source/WebCore
TreeScope::rootNode() should return a ContainerNode.
<http://webkit.org/b/116782>
Reviewed by Antti Koivisto.
The rootNode() of a TreeScope is always a ContainerNode, so update pointer types to reflect that.
This lets us take advantage of Antti's optimized traversal functions.
- dom/ContainerNode.h:
(WebCore::Node::isTreeScope):
- dom/Document.cpp:
(WebCore::Document::buildAccessKeyMap):
- dom/Node.cpp:
(WebCore::Node::containingShadowRoot):
- dom/Node.h:
- dom/TreeScope.h:
(WebCore::TreeScope::rootNode):
(TreeScope):
- page/FocusController.cpp:
(WebCore::FocusNavigationScope::rootNode):
(WebCore::FocusNavigationScope::owner):
- page/FocusController.h:
(FocusNavigationScope):
- 4:39 AM Changeset in webkit [150712] by
-
- 18 edits in trunk/Source
FocusController::setFocusedNode() should be setFocusedElement().
<http://webkit.org/b/116780>
Reviewed by Antti Koivisto.
Source/WebCore:
Only Elements can have focus, so make the public API of FocusController take Element*.
- WebCore.exp.in:
- page/FocusController.h:
- page/FocusController.cpp:
(WebCore::FocusController::setFocusedElement):
Out with the setFocusedNode(), in with the setFocusedElement().
- dom/Element.cpp:
(WebCore::Element::focus):
(WebCore::Element::blur):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
- plugins/PluginView.cpp:
(WebCore::PluginView::focusPluginElement):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setFocusedNodeIfNeeded):
Tweak for FocusController taking Element* instead of Node*.
(WebCore::FrameSelection::setFocusedElementIfNeeded):
Renamed from setFocusedNodeIfNeeded().
- editing/htmlediting.h:
- editing/htmlediting.cpp:
(WebCore::enclosingAnchorElement):
Cleaned up the loop for readability and made it return an Element.
Source/WebKit/blackberry:
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
(BlackBerry::WebKit::WebPage::setNodeFocus):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectObject):
Source/WebKit/win:
- WebView.cpp:
(WebView::clearFocusNode):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::focusPluginElement):
- 2:43 AM Changeset in webkit [150711] by
-
- 7 edits in trunk/Source/WebCore
Move some form control things from Element to HTMLFormControlElement.
<http://webkit.org/b/116779>
Reviewed by Antti Koivisto.
The following methods sit better on HTMLFormControlElement than on Element:
- formControlType()
- wasChangedSinceLastFormControlChangeEvent()
- setChangedSinceLastFormControlChangeEvent()
- dispatchFormControlChangeEvent()
Moved them, and devirtualized as much as possible.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
Check if the old focus target is an Element before (possibly) dispatching a change event.
- dom/Element.cpp:
- dom/Element.h:
Removed some stub methods that were only used by HTMLFormControlElement subclasses.
- html/HTMLFormControlElement.cpp:
- html/HTMLFormControlElement.h:
(WebCore::isHTMLFormControlElement):
(WebCore::toHTMLFormControlElement):
Add toHTMLFormControlElement() helper with ASSERT_WITH_SECURITY_IMPLICATION.
- html/HTMLTextFormControlElement.h:
Sprinkle OVERRIDE.
- 2:39 AM Changeset in webkit [150710] by
-
- 30 edits in trunk/Source/WebCore
Move Node::supportsFocus() to Element.
<http://webkit.org/b/116778>
Reviewed by Antti Koivisto.
Node never supports focus, so move supportsFocus() to Element instead.
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
Removed Node::supportsFocus(), it always returned false anyway.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
Check that the underlying Node is an Element before asking if it supports focus.
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLBodyElement.h:
- html/HTMLElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFrameElementBase.h:
- html/HTMLMediaElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLOutputElement.h:
- svg/SVGAElement.h:
- svg/SVGCircleElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGGElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGPathElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTextElement.h:
- svg/SVGUseElement.h:
OVERRIDE ALL THE THINGS!
May 25, 2013:
- 10:05 PM Changeset in webkit [150709] by
-
- 14 edits in trunk/Source/WebCore
Move Node::isFocusable() to Element.
<http://webkit.org/b/116777>
Reviewed by Anders Carlsson.
Nodes cannot be focusable, so move isFocusable() from Node to Element.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isFocusable):
Moved here from Node.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
Check that the underlying node is an Element before asking if it's focusable.
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
Renamed the 'anchorNode' variable to 'anchorElement' because reasons.
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLLabelElement.h:
- html/HTMLOptionElement.h:
- svg/SVGAElement.h:
Sprinkle OVERRIDE.
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessage):
Update a comment to refer to Element::isFocusable() instead of Node.
- 9:42 PM Changeset in webkit [150708] by
-
- 2 edits in trunk/Websites/webkit.org
Broken link to committers list on contributing web page
https://bugs.webkit.org/show_bug.cgi?id=116722
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-25
Reviewed by Andreas Kling.
- coding/contributing.html:
Changed broken link to point to the team page instead.
- 9:33 PM Changeset in webkit [150707] by
-
- 9 edits in trunk/Source/WebCore
Move Node::tabIndex() to Element.
<http://webkit.org/b/116772>
Reviewed by Ryosuke Niwa.
Since only Elements are keyboard-focusable, it doesn't make sense for Node to have a tabIndex().
- dom/Element.h:
- dom/Node.cpp:
- dom/Node.h:
A Node can't have a tab index, so move tabIndex() to Element.
- page/FocusController.h:
- page/FocusController.cpp:
(WebCore::adjustedTabIndex):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::previousElementWithLowerTabIndex):
(WebCore::FocusController::nextFocusableNode):
(WebCore::FocusController::previousFocusableNode):
Make this code deal in Element* when doing tab index stuff. FocusController needs
more Node->Element cleanup, but let's do that separately.
- html/HTMLAnchorElement.h:
- html/HTMLElement.h:
- html/HTMLFormControlElement.h:
Sprinkle OVERRIDE.
- 9:31 PM Changeset in webkit [150706] by
-
- 2 edits in trunk/Tools
Revert another erroneous change.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(NewCommitBot.next_work_item):
- 9:13 PM Changeset in webkit [150705] by
-
- 2 edits in trunk/Tools
Revert an erroneous change.
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
- 8:39 PM Changeset in webkit [150704] by
-
- 4 edits in trunk/Tools
Some build fixes for WKR and webkitbot.
- Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):
- Scripts/webkitpy/tool/commands/newcommitbot.py:
(Agent):
(Agent.init):
(Agent.name):
(NewCommitBot):
(NewCommitBot.begin_work_queue):
(NewCommitBot.next_work_item):
- Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
- 8:35 PM Changeset in webkit [150703] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support ArithDiv
https://bugs.webkit.org/show_bug.cgi?id=116771
Reviewed by Oliver Hunt.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildDiv):
(JSC::FTL::buildRem):
(JSC::FTL::buildFDiv):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::div):
(JSC::FTL::Output::rem):
(JSC::FTL::Output::doubleDiv):
- 8:29 PM Changeset in webkit [150702] by
-
- 2 edits in trunk/Source/WebCore
Don't instantiate ChildNodeLists just to get a child count.
<http://webkit.org/b/116776>
Reviewed by Ryosuke Niwa.
Use ContainerNode::childNodeCount() instead of Node::childNodes()->length().
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
- 7:57 PM Changeset in webkit [150701] by
-
- 3 edits in trunk/Tools
Teach webkitbot and WKR how to respond to yt?
https://bugs.webkit.org/show_bug.cgi?id=116775
Reviewed by Andreas Kling.
- Scripts/webkitpy/tool/bot/irc_command.py:
(Hi): Fixed the usage string.
(Hi.execute): Made it more generic so that it works in WKR.
(YouThere): Added.
(YouThere.execute): Added.
- Scripts/webkitpy/tool/commands/newcommitbot.py:
- 7:48 PM Changeset in webkit [150700] by
-
- 7 edits in trunk/Source
PluginDocument::pluginNode() should be pluginElement() instead.
<http://webkit.org/b/116774>
Reviewed by Anders Carlsson.
Source/WebCore:
Make PluginDocument hand out a HTMLPlugInElement* instead of a Node*.
- dom/Document.cpp:
(WebCore::eventTargetNodeForDocument):
- html/PluginDocument.h:
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
(WebCore::PluginDocument::pluginWidget):
(WebCore::PluginDocument::setPluginElement):
(WebCore::PluginDocument::detach):
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::focusedPluginViewForFrame):
- 7:27 PM Changeset in webkit [150699] by
-
- 7 edits in trunk/Source
Remove Document::getFocusableNodes().
<http://webkit.org/b/116773>
Reviewed by Joseph Pecoraro.
Source/WebCore:
This was added in r42191 and there are no remaining clients of the API.
- dom/Document.cpp:
- dom/Document.h:
- WebCore.exp.in:
Source/WebKit/mac:
Remove the private _focusableNodes API on DOMDocument, it has no clients.
- DOM/WebDOMOperations.mm:
- DOM/WebDOMOperationsPrivate.h:
- 7:22 PM Changeset in webkit [150698] by
-
- 2 edits in trunk/Tools
Try to fix the EFL build.
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setPageVisibility):
- 7:22 PM Changeset in webkit [150697] by
-
- 9 edits in trunk/Source/WebCore
Move Node::focusDelegate() to Element.
<http://webkit.org/b/116768>
Reviewed by Anders Carlsson.
Only Element can be a focus delegate (it's currently only ever HTMLInputElement actually)
so move Node::focusDelegate() to Element. Sprinkled isElementNode() checks as needed.
- dom/Node.cpp:
- dom/Node.h:
- dom/Element.h:
- dom/Element.cpp:
- html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::focusDelegate):
- html/shadow/SliderThumbElement.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isFocused):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
- 5:51 PM Changeset in webkit [150696] by
-
- 2 edits in trunk/Source/WebCore
Path: clean up addPathForRoundedRect()
https://bugs.webkit.org/show_bug.cgi?id=116765
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-25
Reviewed by Andreas Kling.
Reorganize code that is a bit redundant.
No new tests, no behavior change.
- platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
- 4:56 PM Changeset in webkit [150695] by
-
- 35 edits in trunk
Unprefix Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=102340
Source/WebCore:
Reviewed by Tim Horton.
Remove prefixes from the document properties, and the visibilitychanged event.
Rename the "preview" state to "unloaded". The "unloaded" state is never
reached yet (see https://bugs.webkit.org/show_bug.cgi?id=116769).
Add some comments to places where we should update the visibility state
when going in and out of the page cache, but cannot safely do so yet.
Tested by existing Page Visibility tests.
- dom/Document.cpp:
(WebCore::Document::pageVisibilityState):
(WebCore::Document::visibilityState):
(WebCore::Document::hidden):
(WebCore::Document::dispatchVisibilityStateChangeEvent):
- dom/Document.h:
- dom/Document.idl:
- dom/EventNames.h:
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
- page/Page.cpp:
(WebCore::Page::setVisibilityState):
- page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
- page/PageVisibilityState.h:
Source/WebKit/efl:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state.
- WebCoreSupport/AssertMatchingEnums.cpp:
- ewk/ewk_view.h:
Source/WebKit/mac:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
- WebView/WebView.mm:
- WebView/WebViewPrivate.h:
Source/WebKit2:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
- Shared/API/c/WKPageVisibilityTypes.h:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
Tools:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state, and adjust the tests
to test for it.
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageVisibility):
- TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
(TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
(TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
(TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
(TestWebKitAPI::didRunStep4InStateUnloaded):
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
LayoutTests:
Reviewed by Tim Horton.
Remove prefixes, adjust to state name changes.
- fast/events/page-visibility-iframe-delete-test.html:
- fast/events/page-visibility-iframe-move-test-expected.txt:
- fast/events/page-visibility-iframe-move-test.html:
- fast/events/page-visibility-iframe-propagation-test-expected.txt:
- fast/events/page-visibility-iframe-propagation-test.html:
- fast/events/page-visibility-null-view-expected.txt:
- fast/events/page-visibility-null-view.html:
- fast/events/page-visibility-transition-test-expected.txt:
- fast/events/page-visibility-transition-test.html:
- 4:31 PM Changeset in webkit [150694] by
-
- 4 edits9 adds in trunk
We broke (-231/-1)|0 in the DFG
https://bugs.webkit.org/show_bug.cgi?id=116767
Source/JavaScriptCore:
Reviewed by Andreas Kling.
The bug is that we were assuming that in the -231 case, we already had -231
in the result register. This was a wrong assumption.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):
LayoutTests:
Reviewed by Andreas Kling.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.html: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc-expected.txt: Added.
- fast/js/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.html: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/dfg-div-by-neg1-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-div-by-zero-and-then-or-zero-interesting-reg-alloc.js: Added.
(foo):
- fast/js/script-tests/dfg-div-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js: Added.
(foo):
- 4:13 PM Changeset in webkit [150693] by
-
- 2 edits in trunk/LayoutTests
Updated expected results after r150688.
Reviewed by Andreas Kling.
- http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Now shows
the URL that performed the client redirect, as expected.
- 4:09 PM Changeset in webkit [150692] by
-
- 21 edits in trunk/Source
Move Node::isMouseFocusable() to Element.
<http://webkit.org/b/116762>
Reviewed by Anders Carlsson.
Source/WebCore:
Node::isMouseFocusable() would just return isFocusable(), which is never true for a non-Element
since Node::supportsFocus() always returns false. So move it to Element!
- dom/Node.h:
- dom/Node.cpp:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isMouseFocusable):
Moved here from Node.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setFocusedNodeIfNeeded):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Walk up the parent chain with parentOrShadowHostElement() instead of parentOrShadowHostNode().
Removed a misleading no-op hunk about mouse-focusable ShadowRoots, since ShadowRoots are not
Elements and thus cannot be mouse-focusable.
- page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
Check that the Node is an Element before asking if it's mouse-focusable.
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLInputElement.h:
- html/HTMLMediaElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.h:
- html/shadow/ClearButtonElement.h:
- html/shadow/TextControlInnerElements.h:
- svg/SVGAElement.h:
- svg/SVGStyledElement.h:
Sprinkle OVERRIDE.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
Check that the potentially activated Node is an Element before asking if it's mouse-focusable.
- 2:34 PM Changeset in webkit [150691] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: WebProcess is terminated when all Safari windows are closed.
<rdar://problem/13990901>
<http://webkit.org/b/116766>
Reviewed by Alexey Proskuryakov.
When closing the last page, only disconnect the web process if we're using a network process.
Otherwise there might be session state in the web process getting lost.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):
- 1:17 PM Changeset in webkit [150690] by
-
- 10 edits in branches/dfgFourthTier/Source
Remove Interpreter::retrieveLastCaller().
https://bugs.webkit.org/show_bug.cgi?id=116753.
Reviewed by Geoffrey Garen.
This is part of the refactoring effort to get rid of functions walking
the JS stack in their own way.
- API/JSContextRef.cpp:
(JSContextCreateBacktrace):
- interpreter/CallFrame.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
- interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::StackFrame):
(Interpreter):
- jsc.cpp:
(functionJSCStack):
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
../WebCore:
No new tests.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::send):
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
- 11:35 AM Changeset in webkit [150689] by
-
- 2 edits in trunk/Source/WebKit2
WebFrameProxy::didFailLoad clears frame title for no apparent reason
https://bugs.webkit.org/show_bug.cgi?id=116655
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-05-25
Reviewed by Alexey Proskuryakov.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::didFailLoad):
- 10:57 AM Changeset in webkit [150688] by
-
- 3 edits in trunk/Source/WebKit/mac
<rdar://problem/13924889> -webView:didPerformClientRedirectFromURL:toURL:inFrame: should be given the redirecting URL as the “from” URL
https://bugs.webkit.org/show_bug.cgi?id=116733
Reviewed by Adele Peterson.
By the time the history controller calls updateGlobalHistoryRedirectLinks(), the document
loader already reflects the destination URL. In order to be able to provide the immediate
source URL to the delegate, we make WebFrame track a URL and provisional URL, updating them
in response to FrameLoader callbacks in exactly the same way WebFrameProxy maintains its
m_url and m_provisionalURL member variables.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): Update
provisionalURL.
(WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): Update url.
(WebFrameLoaderClient::dispatchDidPushStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidPopStateWithinPage): Ditto.
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad): Update provisionalURL.
(WebFrameLoaderClient::dispatchDidCommitLoad): Update URL and provisionalURL.
(WebFrameLoaderClient::dispatchDidFailProvisionalLoad): Clear provisionalURL.
(WebFrameLoaderClient::dispatchDidFailLoad): Added an assertion.
(WebFrameLoaderClient::dispatchDidFinishLoad): Ditto.
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Pass the last committed URL as the
source, rather than clientRedirectSourceForHistory().
- WebView/WebFrameInternal.h: Added url and provisionalURL ivars to WebFramePrivate.
- 5:02 AM Changeset in webkit [150687] by
-
- 16 edits in trunk/Source/WebCore
Move Node::isKeyboardFocusable() to Element.
<http://webkit.org/b/116761>
Reviewed by Antti Koivisto.
Only Elements can be keyboard-focusable. Move the base isKeyboardFocusable() implementation to Element
and sprinkle OVERRIDE on subclass overrides.
FocusController gets some temporary type checks that will go away as that code moves to dealing in
Elements instead of Node.
- dom/Node.h:
- dom/Node.cpp:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::isKeyboardFocusable):
Move isKeyboardFocusable() from Node to Element.
- page/FocusController.cpp:
(WebCore::isNonFocusableShadowHost):
(WebCore::isFocusableShadowHost):
(WebCore::shouldVisit):
(WebCore::FocusController::advanceFocusInDocumentOrder):
Check that the inspected Node is an Element before querying isKeyboardFocusable().
- html/HTMLAnchorElement.h:
- html/HTMLAreaElement.h:
- html/HTMLFormControlElement.h:
- html/HTMLFrameOwnerElement.h:
- html/HTMLInputElement.h:
- html/HTMLPlugInElement.h:
- html/HTMLSelectElement.h:
- html/HTMLTextAreaElement.h:
- svg/SVGAElement.h:
- svg/SVGStyledElement.h:
Sprinkle OVERRIDE.
- 3:27 AM Changeset in webkit [150686] by
-
- 10 edits in trunk/Source/WebCore
Begin moving "focus" state logic from Node to Element.
<http://webkit.org/b/116760>
Reviewed by Antti Koivisto.
Only Elements can be focused, so merge the "focus" state logic from Node and ContainerNode
and move it into Element. There's a lot more iceberg under this tip, but we'll be starting
with setFocus(bool) and focused().
- dom/Node.h:
- dom/ContainerNode.cpp:
- dom/ContainerNode.h:
- dom/Element.cpp:
(WebCore::Element::isUserActionElementFocused):
(WebCore::Element::setFocus):
- dom/Element.h:
(WebCore::Element::focused):
- dom/Node.cpp:
Move focused() and setFocus(bool) from Node/ContainerNode to Element.
- dom/Document.cpp:
(WebCore::Document::setFocusedNode):
- page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
Check if the inspected Node is an Element before asking if it's focused.
- 2:51 AM Changeset in webkit [150685] by
-
- 3 edits2 adds in trunk
Direct pattern compositing breaks when no-repeat is set on a large layer
https://bugs.webkit.org/show_bug.cgi?id=116140
Source/WebCore:
Reviewed by Antti Koivisto.
In some cases the directly composited background color logic overrides the layer's
contentsRect, which results in wrong rendering of tiled images.
This patch makes sure that the background image is applied after the solid color,
which ensures the correct contentsRect.
Test: compositing/patterns/direct-pattern-compositing-contain-no-repeat.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
LayoutTests:
Added a ref-test to make sure that direct pattern compositing works well with no-repeat
in a particular geometry.
Reviewed by Antti Koivisto.
- compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-contain-no-repeat.html: Added.
- 2:16 AM Changeset in webkit [150684] by
-
- 14 edits in trunk/Source/WebCore
Move "hover" state logic from Node to Element.
<http://webkit.org/b/116757>
Reviewed by Antti Koivisto.
Resolve a 7 year old FIXME by merging the "hover" state logic from Node and ContainerNode
and moving it all to Element instead.
- dom/Node.cpp:
(WebCore::Node::detach):
- dom/Element.cpp:
(WebCore::Element::detach):
Move Document::hoveredNodeDetached() call from Node::detach() to Element::detach().
(WebCore::Element::isUserActionElementHovered):
(WebCore::Element::setHovered):
- dom/Element.h:
(WebCore::Element::hovered):
Moved here from Node/ContainerNode.
- dom/UserActionElementSet.h:
(WebCore::UserActionElementSet::setHovered):
(WebCore::UserActionElementSet::setFlags):
Make setHovered() take an Element* instead of a Node*. I'd like to do this will all
of these methods eventually, so added a setFlags() helper with the tighter type.
- html/HTMLLabelElement.h:
- html/shadow/SpinButtonElement.h:
Sprinkle OVERRIDE on setHovered() overrides.
- dom/Document.cpp:
(WebCore::Document::updateHoverActiveState):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isHovered):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isHovered):
Check if the inspected Node is an element before asking if it's hovered.
- 2:08 AM Changeset in webkit [150683] by
-
- 6 edits in trunk/Source/WebCore
Document::formController() should return a reference.
<http://webkit.org/b/116758>
Reviewed by Antti Koivisto.
The formController() is created on demand, so return a reference instead.
- dom/Document.h:
- dom/Document.cpp:
(WebCore::Document::formController):
(WebCore::Document::setStateForNewFormElements):
- html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::~HTMLFormElement):
(WebCore::HTMLFormElement::finishParsingChildren):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::checkedRadioButtons):
- 1:29 AM Changeset in webkit [150682] by
-
- 2 edits in trunk/Source/WebCore
Reducing CSS code duplication in declaration list error recovery
https://bugs.webkit.org/show_bug.cgi?id=115157
Reviewed by Andreas Kling.
From Blink r148974 by <serya@chromium.org>
Refactor "invalid_block_list error | /* empty */" in a new
decl_list_recovery rule that allows to remove 4 redundant rules.
No new test required as we're just refactoring code, no new behaviour.
- css/CSSGrammar.y.in:
May 24, 2013:
- 9:20 PM Changeset in webkit [150681] by
-
- 4 edits in trunk/Source/WebKit2
[Qt][GTK] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116751
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.
- GNUmakefile.list.am:
- Target.pri:
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::getEditorCommandsForKeyEvent):
- 9:01 PM Changeset in webkit [150680] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove obsolete Page forward declaration from InspectorClientEfl.h
https://bugs.webkit.org/show_bug.cgi?id=116752
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Christophe Dumez.
- WebCoreSupport/InspectorClientEfl.h:
- 7:44 PM CommitterTips edited by
- It is generated automatically from contributors.json after r150662. (diff)
- 7:19 PM Changeset in webkit [150679] by
-
- 6 edits in trunk/Source/WebKit2
[EFL] Build fix after r150669
https://bugs.webkit.org/show_bug.cgi?id=116750
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Anders Carlsson.
- CMakeLists.txt:
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
- WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::registerWebPage):
(WebKit::WebNetworkInfoManager::unregisterWebPage):
(WebKit::WebNetworkInfoManager::bandwidth):
(WebKit::WebNetworkInfoManager::metered):
- WebProcess/WebCoreSupport/WebVibrationClient.cpp:
(WebKit::WebVibrationClient::vibrate):
(WebKit::WebVibrationClient::cancelVibration):
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::didReceiveURIRequestData):
(WebKit::WebSoupRequestManager::send):
- 6:28 PM Changeset in webkit [150678] by
-
- 2 edits in trunk/LayoutTests
Unreviewed change to get Windows bots green. Disable a number
of crashes and failures. Crashes are tracked under
https://bugs.webkit.org/show_bug.cgi?id=116562, failures under
https://bugs.webkit.org/show_bug.cgi?id=116564.
- platform/win/TestExpectations:
- 6:18 PM Changeset in webkit [150677] by
-
- 2 edits in trunk/Tools
Unreviewed build fix. Don't use new NRWT logic needed
by Windows yet. Activate (and fix test) when we cut over.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver):
(Driver._start):
- 6:12 PM Changeset in webkit [150676] by
-
- 2 edits in trunk/Source/WTF
Inline TCMalloc_Central_FreeList's RemoveRange and FetchFromSpansSafe
https://bugs.webkit.org/show_bug.cgi?id=116700
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-24
Reviewed by Darin Adler.
The two functions only have one call site each.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_Central_FreeList::RemoveRange):
(WTF::TCMalloc_Central_FreeList::FetchFromSpansSafe):
- 6:02 PM Changeset in webkit [150675] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r150664.
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
- 5:59 PM Changeset in webkit [150674] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 5:56 PM Changeset in webkit [150673] by
-
- 1 copy in tags/Safari-537.43.2
New Tag.
- 5:49 PM Changeset in webkit [150672] by
-
- 3 edits2 adds in trunk
Fixing invalid block recovery in some declaration list.
https://bugs.webkit.org/show_bug.cgi?id=115159
Patch by Sergio Villar Senin <svillar@igalia.com> on 2013-05-24
Reviewed by Darin Adler.
From Blink r148889 by <serya@chromium.org>
Source/WebCore:
Improves the detection of some invalid block declarations inside a
declaration list. This allows the parser not to completely discard
a whole declaration list that contains an invalid block. In
particular grammar failed in tests 8, 12, 13, 15, 16 and 17 in the
new test added by this change.
Test: fast/css/parsing-invalid-block-recovery.html
- css/CSSGrammar.y.in:
LayoutTests:
- fast/css/parsing-invalid-block-recovery-expected.txt: Added.
- fast/css/parsing-invalid-block-recovery.html: Added.
- 5:48 PM Changeset in webkit [150671] by
-
- 2 edits in trunk/Source/WebCore
DidFirstFlushForHeaderLayer can be called too soon on pages that redirect
https://bugs.webkit.org/show_bug.cgi?id=116749
-and corresponding-
<rdar://problem/13886753>
Reviewed by Simon Fraser.
Only start m_paintRelatedMilestonesTimer if we have actually painted.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
- 5:19 PM Changeset in webkit [150670] by
-
- 11 edits in trunk
[Windows] Expose database storage and cache locations via preferences.
https://bugs.webkit.org/show_bug.cgi?id=116729
Reviewed by Tim Horton.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export
three symbols needed to implement the feature.
Source/WebKit/win:
- WebDatabaseManager.cpp: Update to check preferences for the
desired location of the database store.
(databasesDirectory): Added.
(WebKitInitializeWebDatabasesIfNecessary): Use new databasesDirectory
method to determine what system path to use for file storage.
- WebKit.vcproj/WebKitExports.def.in: Export three symbols
needed to implement the feature.
- WebView.cpp: Update to check preferences for the desired location
of the various caches used by WebKit.
(WebView::setCacheModel): Update to check preferences for URL cache
storage.
(WebKitSetApplicationCachePathIfNecessary): Update to check
preferences for ccache storage.
Tools:
Update DumpRenderTree to use CFPreferences to control where WebKit
stores its local databases, URL caches, etc.
- DumpRenderTree/win/DumpRenderTree.cpp:
(libraryPathForDumpRenderTree): Added.
(dllLauncherEntryPoint): Set up DRT-specific cache locations.
- Scripts/webkitpy/port/base.py:
(Port._driver_tempdir): Added (to allow port-specific overload).
(Port._driver_tempdir_for_environment): Ditto
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Use new overload to set
environment variable.
(Driver._start): Use new overload for temp directory location.
- Scripts/webkitpy/port/win.py:
(WinPort._driver_tempdir_for_environment): New overload to supply
Windows path to DumpRenderTree environment (while still using
cygwin paths for internal operations.
- 5:17 PM Changeset in webkit [150669] by
-
- 40 edits1 copy in trunk/Source/WebKit2
MessageSender shouldn't be a class template
https://bugs.webkit.org/show_bug.cgi?id=116743
Reviewed by Andreas Kling.
Change MessageSender to be a proper abstract base class. Subclasses of MessageSender must
implement messageSenderConnection() as well as messageSenderDestinationID().
This reduces code size and will allow us to be more flexible with MessageSender in the future.
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):
(WebKit::NetworkResourceLoader::messageSenderConnection):
(WebKit):
(WebKit::NetworkResourceLoader::messageSenderDestinationID):
- NetworkProcess/NetworkResourceLoader.h:
(NetworkResourceLoader):
- NetworkProcess/mac/DiskCacheMonitor.h:
(DiskCacheMonitor):
- NetworkProcess/mac/DiskCacheMonitor.mm:
(WebKit::DiskCacheMonitor::messageSenderConnection):
(WebKit::DiskCacheMonitor::messageSenderDestinationID):
(WebKit):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC):
(MessageSender):
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcess.cpp:
(WebKit::ChildProcess::messageSenderConnection):
(WebKit):
(WebKit::ChildProcess::messageSenderDestinationID):
- Shared/ChildProcess.h:
(ChildProcess):
- Shared/Downloads/Download.cpp:
(WebKit::Download::messageSenderConnection):
(WebKit):
(WebKit::Download::messageSenderDestinationID):
- Shared/Downloads/Download.h:
(Download):
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::initialize):
- Shared/WebConnection.h:
(WebConnection):
- Shared/mac/SecItemShim.cpp:
(WebKit::sendSecItemRequest):
- UIProcess/WebConnectionToWebProcess.cpp:
(WebKit::WebConnectionToWebProcess::hasValidConnection):
(WebKit::WebConnectionToWebProcess::messageSenderConnection):
(WebKit::WebConnectionToWebProcess::messageSenderDestinationID):
- UIProcess/WebConnectionToWebProcess.h:
(WebConnectionToWebProcess):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
- WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:
(WebKit::WebIconDatabaseProxy::retainIconForPageURL):
(WebKit::WebIconDatabaseProxy::releaseIconForPageURL):
(WebKit::WebIconDatabaseProxy::synchronousIconForPageURL):
(WebKit::WebIconDatabaseProxy::loadDecisionForIconURL):
(WebKit::WebIconDatabaseProxy::setIconURLForPageURL):
(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::messageSenderConnection):
(WebKit::WebResourceLoader::messageSenderDestinationID):
- WebProcess/Network/WebResourceLoader.h:
(WebResourceLoader):
- WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::writeItemsToPasteboard):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::removeItem):
(WebKit::StorageAreaMap::clear):
(WebKit::StorageAreaMap::loadValuesIfNeeded):
- WebProcess/WebConnectionToUIProcess.cpp:
(WebKit::WebConnectionToUIProcess::hasValidConnection):
(WebKit::WebConnectionToUIProcess::messageSenderConnection):
(WebKit::WebConnectionToUIProcess::messageSenderDestinationID):
- WebProcess/WebConnectionToUIProcess.h:
(WebConnectionToUIProcess):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::windowRect):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::createWindow):
(WebKit::WebChromeClient::toolbarsVisible):
(WebKit::WebChromeClient::statusbarVisible):
(WebKit::WebChromeClient::menubarVisible):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::shouldInterruptJavaScript):
(WebKit::WebChromeClient::exceededDatabaseQuota):
- WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::setSelectedColor):
(WebKit::WebColorChooser::endChooser):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidReceiveIcon):
(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::populatePluginCache):
(WebKit::WebPlatformStrategies::getTypes):
(WebKit::WebPlatformStrategies::bufferForType):
(WebKit::WebPlatformStrategies::getPathnamesForType):
(WebKit::WebPlatformStrategies::stringForType):
(WebKit::WebPlatformStrategies::copy):
(WebKit::WebPlatformStrategies::changeCount):
(WebKit::WebPlatformStrategies::uniqueName):
(WebKit::WebPlatformStrategies::color):
(WebKit::WebPlatformStrategies::url):
(WebKit::WebPlatformStrategies::addTypes):
(WebKit::WebPlatformStrategies::setTypes):
(WebKit::WebPlatformStrategies::setBufferForType):
(WebKit::WebPlatformStrategies::setPathnamesForType):
(WebKit::WebPlatformStrategies::setStringForType):
- WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::show):
(WebKit::WebPopupMenu::hide):
- WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:
(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::sendDidReceiveEvent):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
(WebKit::WebBackForwardListProxy::itemAtIndex):
(WebKit::WebBackForwardListProxy::backListCount):
(WebKit::WebBackForwardListProxy::forwardListCount):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::didClose):
(WebKit::WebInspector::bringToFront):
(WebKit::WebInspector::inspectedURLChanged):
(WebKit::WebInspector::save):
(WebKit::WebInspector::append):
(WebKit::WebInspector::attachBottom):
(WebKit::WebInspector::attachRight):
(WebKit::WebInspector::detach):
(WebKit::WebInspector::setAttachedWindowHeight):
(WebKit::WebInspector::setAttachedWindowWidth):
(WebKit::WebInspector::setToolbarHeight):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToRemoteFrontend):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::messageSenderConnection):
(WebKit):
(WebKit::WebPage::messageSenderDestinationID):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureNetworkProcessConnection):
(WebKit::WebProcess::shouldTerminate):
- 4:52 PM Changeset in webkit [150668] by
-
- 15 edits in trunk/Source/WebKit/mac
Remove using namespace std from Mac WebKit1
https://bugs.webkit.org/show_bug.cgi?id=116747
Reviewed by Sam Weinig.
Use explicit std:: qualifiers instead.
- History/BinaryPropertyList.cpp:
(IntegerArray::deletedValueSize):
(BinaryPropertyListPlan::invalidObjectReference):
(bytesNeeded):
- History/WebHistory.mm:
(-[WebHistoryPrivate orderedLastVisitedDays]):
(WebHistoryWriter::WebHistoryWriter):
- History/WebHistoryItem.mm:
(-[WebHistoryItem initFromDictionaryRepresentation:]):
- Plugins/Hosted/NetscapePluginHostManager.mm:
(WebKit::NetscapePluginHostManager::instantiatePlugin):
- Plugins/Hosted/NetscapePluginHostProxy.mm:
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject):
(WebKit::NetscapePluginInstanceProxy::wheelEvent):
(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):
- Plugins/Hosted/ProxyInstance.mm:
(WebKit::ProxyInstance::invoke):
(WebKit::ProxyInstance::supportsInvokeDefaultMethod):
(WebKit::ProxyInstance::supportsConstruct):
(WebKit::ProxyInstance::getPropertyNames):
(WebKit::ProxyInstance::methodNamed):
(WebKit::ProxyInstance::fieldNamed):
(WebKit::ProxyInstance::fieldValue):
(WebKit::ProxyInstance::setFieldValue):
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage supportsExtension:]):
(-[WebBasePluginPackage MIMETypeForExtension:]):
- Plugins/WebNetscapePluginStream.mm:
(WebNetscapePluginStream::deliverData):
- Plugins/WebNetscapePluginView.mm:
(PluginTimer::start):
(-[WebNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]):
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebFrame.mm:
- WebView/WebHTMLView.mm:
(-[WebHTMLView _adjustedBottomOfPageWithTop:bottom:limit:]):
- WebView/WebTextCompletionController.mm:
(-[WebTextCompletionController _placePopupWindow:]):
- 4:46 PM Changeset in webkit [150667] by
-
- 4 edits in trunk/Source/WebCore
Fix Windows build.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 4:37 PM Changeset in webkit [150666] by
-
- 6 edits in trunk/Source
Animated GIFs don't repaint after TiledCoreAnimationDrawingArea un-suspends painting
https://bugs.webkit.org/show_bug.cgi?id=116744
<rdar://problem/13973514>
Reviewed by Simon Fraser.
- WebCore.exp.in: Export FrameView::resumeAnimatingImages.
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
(WebCore::FrameView::resumeAnimatingImages):
Factor the code to restart animated images out of frameView::setIsInWindow.
- page/FrameView.h:
(FrameView):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):
Force WebCore to repaint animated images when painting is resumed.
- 4:30 PM Changeset in webkit [150665] by
-
- 7 edits4 moves in trunk/Source
Move history property list writer to WebKit
https://bugs.webkit.org/show_bug.cgi?id=116746
Reviewed by Tim Horton.
Source/WebCore:
Remove files from the Xcode project and remove symbols that now live in WebKit.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit:
Add files to the Xcode project.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Move WebCore history files to WebKit since they're only used by WebKit now.
- History/BinaryPropertyList.cpp: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.cpp.
- History/BinaryPropertyList.h: Renamed from Source/WebCore/platform/cf/BinaryPropertyList.h.
- History/HistoryPropertyList.cpp: Renamed from Source/WebCore/history/cf/HistoryPropertyList.cpp.
- History/HistoryPropertyList.h: Renamed from Source/WebCore/history/cf/HistoryPropertyList.h.
- History/WebHistory.mm:
- 4:15 PM Changeset in webkit [150664] by
-
- 10 edits3 adds in trunk
Global constructors exposed in worker environment have wrong attributes
https://bugs.webkit.org/show_bug.cgi?id=116708
Reviewed by Geoffrey Garen.
Source/WebCore:
Fix JSC bindings generator so that Global constructors exposed in worker environment
have the following attributes:
{ Writable: true, Enumerable: false, Configurable: true }
This is now consistent with global constructors on DOMWindow and with the Web IDL
specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
Test: fast/js/global-constructors-attributes-worker.html
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributesHashTable):
LayoutTests:
Add fast/js/global-constructors-attributes-worker.html test case to check the
global constructors attributers in the worker environment.
- fast/js/global-constructors-attributes-expected.txt:
- fast/js/global-constructors-attributes-worker-expected.txt: Added.
- fast/js/global-constructors-attributes-worker.html: Added.
- fast/js/global-constructors-attributes.html:
- fast/js/script-tests/global-constructors-attributes.js: Make sure script usable
in a Worker and stop reporting the "constructor" property as a global constructor.
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-worker-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 3:57 PM Changeset in webkit [150663] by
-
- 34 edits1 delete in trunk
Remove custom code for webkitAudioContext global constructor getter
https://bugs.webkit.org/show_bug.cgi?id=116530
Reviewed by Geoffrey Garen.
Source/WebCore:
Get rid of custom code for webkitAudioContext global constructor getter. The
global DOMWindow attribute is now automatically generated by leveraging support
for [EnabledAtRuntime] extended attribute and the existing methods in
RuntimeEnabledFeatures class.
No new tests, no behavior change.
- GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
- Modules/webaudio/AudioContext.idl:
Remove [NoInterfaceObject] extended attribute so that the global constructor is
automatically generated instead of automatically added. Add [EnabledAtRuntime]
extended attribute since this global constructor can be disabled at runtime and
so that we can getter rid of the [CustomGetter] for the corresponding global
constructor. Use [InterfaceName] extended attribute so that the interface name
matches the global constructor on DOMWindow (webkitAudioContext).
- Target.pri: Remove JSDOMWindowWebAudioCustom.*.
- UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.exp.in: Export additional symbol.
- WebCore.order: Export additional symbol.
- WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
- WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
- bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):
- bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
- bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for
the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
bindings generator now.
- page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically
generated.
- page/Settings.in: Remove webAudioEnabled setting as we use the existing setting
in RuntimeEnabledFeatures now.
Source/WebKit/efl:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setWebAudioEnabled):
- WebCoreSupport/DumpRenderTreeSupportEfl.h:
- ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
- ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer
a view specific feature.
Source/WebKit/gtk:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):
Source/WebKit/mac:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/qt:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
Source/WebKit/win:
Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
WebAudio feature instead of public ewk_view API since that API was
removed.
- DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
- DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::overridePreference):
- 3:49 PM WebKit Team edited by
- Update to point to new location. (diff)
- 3:34 PM Changeset in webkit [150662] by
-
- 4 edits in trunk
Make team.html have each contributor's area of expertise
https://bugs.webkit.org/show_bug.cgi?id=116737
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-24
Reviewed by Benjamin Poulain.
Tools:
- Scripts/webkitpy/common/config/contributors.json:
Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
Changed formatting of the file because the lines are getting way to
long, and I generated this, so it's easier if the formatting of the
file is regular.
Websites/webkit.org:
- team.html:
Update to use the new expertise field in contributors.json.
- 3:27 PM Changeset in webkit [150661] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL boolify should support ObjectOrOtherUse
https://bugs.webkit.org/show_bug.cgi?id=116741
Reviewed by Geoffrey Garen.
Just reusing what was already there in equalNullOrUndefined(). Note that we will
sometimes generate some redundant IR - like having some spurious bitNot's in
places - but it's safe to assume that LLVM will simplify those, and that it won't
be the longest pole in the tent for compile times.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
- 3:05 PM Changeset in webkit [150660] by
-
- 5 edits in trunk/Source/WebKit/win
Remove unused code to read/write history
https://bugs.webkit.org/show_bug.cgi?id=116738
Reviewed by Brent Fulgham.
- Interfaces/IWebHistory.idl:
Replace loadFromURL and saveToURL with unused1/unused2.
- Interfaces/IWebHistoryPrivate.idl:
Replace data with unused1.
- WebHistory.cpp:
Remove history loading/saving code.
(WebHistory::unused1):
(WebHistory::unused2):
Add implementations.
- WebHistory.h:
(WebHistory):
- 3:00 PM Changeset in webkit [150659] by
-
- 7 edits3 adds in trunk
We broke !(0/0)
https://bugs.webkit.org/show_bug.cgi?id=116736
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createLogicalNot):
- runtime/JSCJSValueInlines.h:
(JSC::JSValue::pureToBoolean):
Source/WTF:
- wtf/MathExtras.h:
(isNotZeroAndOrdered):
(isZeroOrUnordered):
LayoutTests:
- fast/js/constant-fold-not-nan.html: Added.
- fast/js/constant-fold-not-nan-expected.txt: Added.
- fast/js/jsc-test-list:
- fast/js/script-tests/constant-fold-not-nan.js: Added.
- 2:45 PM Changeset in webkit [150658] by
-
- 4 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support LogicalNot and Branch on Int32 and Number
https://bugs.webkit.org/show_bug.cgi?id=116739
Reviewed by Gavin Barraclough.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::boolify):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):
- 2:06 PM Changeset in webkit [150657] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: add heuristics to reduce the likelihood of a trivially inlineable function being independently compiled by the concurrent JIT
https://bugs.webkit.org/show_bug.cgi?id=116557
Reviewed by Geoffrey Garen.
This introduces a fairly comprehensive mechanism for preventing trivially inlineable
functions from being compiled independently of all of the things into which they end
up being inlined.
The trick is CodeBlock::m_shouldAlwaysBeInlined, or SABI for short (that's what the
debug logging calls it). A SABI function is one that we currently believe should
never be DFG optimized because it should always be inlined into the functions that
call it. SABI follows "innocent until proven guilty": all functions start out SABI
and have SABI set to false if we see proof that that function may be called in some
possibly non-inlineable way. So long as a function is SABI, it will not tier up to
the DFG: cti_optimize will perpetually postpone its optimization. Because SABI has
such a severe effect, we make the burden of proof of guilt quite low. SABI gets
cleared if any of the following happen:
- You get called from native code (either through CallData or CachedCall).
- You get called from an eval, since eval code takes a long time to get DFG optimized.
- You get called from global code, since often global code doesn't tier-up since it's run-once.
- You get called recursively, where recursion is detected by a stack walk of depth Options::maximumInliningDepth().
- You get called through an unlinked virtual call.
- You get called from DFG code, since if the caller was already DFG optimized and didn't inline you then obviously, you might not get inlined.
- You've tiered up to the baseline JIT and you get called from the interpreter. The idea here is that this kind of ensures that you stay SABI only if you're called no more frequently than any of your callers.
- You get called from a code block that isn't a DFG candidate.
- You aren't an inlining candidate.
Most of the heuristics for SABI are in CodeBlock::noticeIncomingCall().
This is neutral on SunSpider and V8Spider, and appears to be a slight speed-up on
V8v7, which was previously adversely affected by concurrent compilation. I also
confirmed that for example on V8/richards, it dramatically reduces the number of
code blocks that get DFG compiled. It is a speed-up on those V8v7 benchmarks that
saw regressions from concurrent compilation.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::linkIncomingCall):
(JSC):
(JSC::CodeBlock::noticeIncomingCall):
- bytecode/CodeBlock.h:
(CodeBlock):
- dfg/DFGCapabilities.h:
(JSC::DFG::mightInlineFunction):
(DFG):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
- dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
- jit/JIT.h:
(JIT):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
- 1:26 PM Changeset in webkit [150656] by
-
- 2 edits in trunk/Source/WebCore
[AC] Needs to be guarded by USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=116712
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-24
Reviewed by Andreas Kling.
renderView is used when ACCELERATED_COMPOSITING is enabled.
So, this patch allows it to be guarded by USE(ACCELERATED_COMPOSITING).
No new tests, no behavior change.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
- 1:07 PM Changeset in webkit [150655] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
https://bugs.webkit.org/show_bug.cgi?id=116731
Reviewed by Ryosuke Niwa.
The mentioned revision removed a layering violation added just to
support some IE7 hack. That was removed but the test case
supporting it was left untouched, remove it.
- inspector/console/console-css-warnings-expected.txt:
- inspector/console/console-css-warnings.html:
- 12:43 PM Changeset in webkit [150654] by
-
- 6 edits in trunk/LayoutTests
[WK2] Spelling tests gardening
https://bugs.webkit.org/show_bug.cgi?id=116718
Unreviewed gardening.
The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
the core spellchecking implementation is delivered for wk2.
This change will allow to run spelling tests easier and using [ Pass ] keyword
in TestExpectations won't be needed.
- platform/efl-wk2/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/qt-5.0-wk2/TestExpectations:
- platform/wk2/TestExpectations:
- 12:41 PM Changeset in webkit [150653] by
-
- 4 edits in trunk/Source
Add more lines to the context during Dictionary lookups
https://bugs.webkit.org/show_bug.cgi?id=115256
Patch by Thomas Deniau <deniau@apple.com> on 2013-05-24
Reviewed by Ryosuke Niwa.
Source/WebCore:
No new tests - no new functionality.
- WebCore.exp.in: Export a few methods in VisibleUnits needed to be able
to call previousLinePosition(), nextLinePosition(), startOfLine() and
endOfLine() in WebPageMac.mm when determining the context while looking
up a dictionary definition. These symbols used to be exported for iOS
only, export them on the desktop too.
Source/WebKit2:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
Instead of using the current paragraph as the context (which stops at
line breaks), get a few lines before and after the point, so that the
context contains at least four lines in each direction.
This way the Dictionary will be able to look up things that extend past
the current line.
- 12:07 PM Changeset in webkit [150652] by
-
- 18 edits17 deletes in trunk
Remove PagePopup code
https://bugs.webkit.org/show_bug.cgi?id=116732
Reviewed by Andreas Kling.
.:
- Source/cmakeconfig.h.cmake:
Remove ENABLE_PAGE_POPUP.
Source/WebCore:
Remove all page popup code.
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- dom/ContextFeatures.cpp:
- dom/ContextFeatures.h:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/DOMWindowPagePopup.cpp: Removed.
- page/DOMWindowPagePopup.h: Removed.
- page/DOMWindowPagePopup.idl: Removed.
- page/PagePopup.h: Removed.
- page/PagePopupClient.cpp: Removed.
- page/PagePopupClient.h: Removed.
- page/PagePopupController.cpp: Removed.
- page/PagePopupController.h: Removed.
- page/PagePopupController.idl: Removed.
- page/PagePopupDriver.h: Removed.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore):
- testing/Internals.h:
(WebCore):
(Internals):
- testing/Internals.idl:
- testing/MockPagePopupDriver.cpp: Removed.
- testing/MockPagePopupDriver.h: Removed.
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataEnableFeatures.in:
Remove PAGE_POPUP.
Source/WTF:
Remove ENABLE_PAGE_POPUP.
- wtf/FeatureDefines.h:
LayoutTests:
Remove tests that relied on the mock page popup driver.
- fast/forms/date/no-page-popup-controller-expected.txt: Removed.
- fast/forms/date/no-page-popup-controller.html: Removed.
- fast/forms/resources/picker-common.js: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings-expected.txt: Removed.
- fast/forms/time-multiple-fields/time-multiple-fields-open-picker-key-bindings.html: Removed.
- 11:54 AM Changeset in webkit [150651] by
-
- 13 edits3 copies1 add in trunk/Source
Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342
Source/WebCore:
Reviewed by Eric Carlson.
Roll-in rubber stamped by Eric Carlson.
To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.
Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.
This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.
Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.
However, since the original version of this patch caused media test
failures on the Mac ML and Lion bots, only enable the buffer size
change for OS X > ML.
- html/HTMLMediaElement.h: Add a AudioSessionManagerToken member.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionManager.cpp:
(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.
- platform/audio/AudioSessionManager.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/AudioSessionMac.cpp: Added.
(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.
- WebCore.xcodeproj/project.pbxproj: Add the new files to the project.
Source/WTF:
Reviewed by Eric Carlson.
- wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.
- 11:46 AM Changeset in webkit [150650] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebCore
Merged r150631. <rdar://problem/13963712>
- 11:42 AM Changeset in webkit [150649] by
-
- 7 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150620. <rdar://problem/13938510>
- 11:09 AM Changeset in webkit [150648] by
-
- 2 edits in trunk/Source/WebKit2
Intermittent crash when typing in Address Bar
https://bugs.webkit.org/show_bug.cgi?id=116728
<rdar://problem/13976781>
Reviewed by Sam Weinig.
If a web process connection has been removed from the storage manager because we disconnected it
since there were no more active pages associated with the web process, we'll fail to find it here
so just return early instead of crashing.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::destroyStorageMap):
- 11:01 AM Changeset in webkit [150647] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 10:28 AM Changeset in webkit [150646] by
-
- 3 edits in trunk/Source/WebCore
Path: upstream the missing bits from the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=116658
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-24
Reviewed by Xan Lopez.
PathBlackBerry was upstreamed a while ago (r144612) but a few bits
were missing from the cross-platform code.
- platform/graphics/Path.cpp:
(WebCore::Path::addPathForRoundedRect):
- platform/graphics/Path.h:
(Graphics):
(Path):
- 10:16 AM Changeset in webkit [150645] by
-
- 3 edits in trunk/LayoutTests
Improve loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116709
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-24
Reviewed by Alexey Proskuryakov.
It is only needed to register the listeners on the initial load as they
are already present when restoring from page cache. Modified the test to
use event.persisted property to know if we are handling the first load
in order to register the listeners only once.
- loader/resources/first-page.html: Rename registerListeners() function
to a more accurate name didShowPage() and use event.persisted to
register the listeners only in the first load.
- loader/resources/other-page.html: Ditto.
- 9:50 AM WebKit Team edited by
- (diff)
- 9:46 AM Changeset in webkit [150644] by
-
- 4 edits in trunk/Source/JavaScriptCore
[sh4] Optimize LLINT generated code and fix few bugs in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=116716
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-24
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::mul32): Cosmetic changes.
(JSC::MacroAssemblerSH4::convertInt32ToDouble): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::branch32): Absolute address was not dereferenced.
(JSC::MacroAssemblerSH4::revertJumpReplacementToBranchPtrWithPatch): Use all 32 bits of pointer for revertJump call.
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::revertJump): Use changePCrelativeAddress to patch the whole pointer.
(JSC::SH4Assembler::linkJump): Cosmetic change.
- offlineasm/sh4.rb: Optimize LLINT generated code.
- 9:34 AM Changeset in webkit [150643] by
-
- 3 edits2 adds in trunk
WebProcess is crashing on http://achicu.github.io/css-presentation when direct pattern compositing is enabled
https://bugs.webkit.org/show_bug.cgi?id=115135
Patch by Noam Rosenthal <Noam Rosenthal> on 2013-05-24
Reviewed by Antti Koivisto.
Source/WebCore:
Issue is invoked when there is a visibility:hidden layer with a non-compositable
background image (e.g. a radial gradient).
The layer is treated as a no-contents layer because of its visibility, however
updateDirectlyCompositedBackgroundImage() later mistakenly treats it as a layer
with direct background-image compositing.
Fixed by returning early from updating directly composited contents for layers
with hidden contents.
Test: compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintsChildren):
(WebCore::RenderLayerBacking::isDirectlyCompositedImage):
LayoutTests:
Added a ref-test that makes sure that a layer with a hidden radial gradient does not
cause the web process to crash.
- compositing/patterns/direct-pattern-compositing-hidden-radial-gradient-expected.html: Added.
- compositing/patterns/direct-pattern-compositing-hidden-radial-gradient.html: Added.
- 9:18 AM Changeset in webkit [150642] by
-
- 2 edits in trunk/Source/WebCore
Refactor shouldAddBorderPaddingMargin()
https://bugs.webkit.org/show_bug.cgi?id=98803
Reviewed by Ryosuke Niwa.
Make this helper function less clever-stupid in its misguided sacrifice of intelligibility
for the sake of concision.
No new tests, refactoring.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::shouldAddBorderPaddingMargin):
(WebCore::inlineLogicalWidth):
- 8:51 AM Changeset in webkit [150641] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Fix bad type warning in InputHandler log.
https://bugs.webkit.org/show_bug.cgi?id=116720
Reviewed by Carlos Garcia Campos.
Fix warning in inputLog string.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
- 7:48 AM Changeset in webkit [150640] by
-
- 2 edits in trunk/Tools
Update WTF::Vector pretty printers
https://bugs.webkit.org/show_bug.cgi?id=116719
Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-24
Reviewed by Anders Carlsson.
After r148891, WTF::Vector pretty printers were left outdated, as
the WTF::Vector was made to extend a VectorBuffer, instead of keeping
one as a member. This patch updates the pretty printers so they work
again.
- gdb/webkit.py:
(WTFVectorPrinter.children):
(WTFVectorPrinter.to_string):
- 7:20 AM Changeset in webkit [150639] by
-
- 14 edits13 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Update qt-5.0-wk2 expected pictures after r150506.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-24
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
- platform/qt-5.0-wk2/svg/filters/feImage-animated-transform-on-target-rect-expected.png:
- platform/qt-5.0-wk2/svg/filters/feImage-late-indirect-update-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-reference-invalidation-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-add-to-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-changes-id-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-id-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-inline-style-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-property-change-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-reappend-to-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-remove-from-document-expected.png: Added.
- platform/qt-5.0-wk2/svg/filters/feImage-target-style-change-expected.png: Added.
- 6:25 AM Changeset in webkit [150638] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests.
- platform/qt-5.0-wk2/TestExpectations: Move http/tests/security/cross-frame-access-put.html to qt/TestExpectations.
- platform/qt/TestExpectations: Skip fast/frames/detach-frame-during-focus.html after r146523.
- 5:47 AM Changeset in webkit [150637] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Respect tabindex when using form controls.
https://bugs.webkit.org/show_bug.cgi?id=116676
Reviewed by Xan Lopez.
PR 337419.
Update form control navigation tracking to take tabindex
order into account when calculating next and previous nodes.
The order to follow is tab index 1 - N, followed by all items
without a tab index or tab index 0 in rendering order to match
with standard desktop behavior.
Internally Reviewed by Genevieve Mak and Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::updateFormState):
- 5:23 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 1:41 AM Changeset in webkit [150636] by
-
- 2 edits in trunk/Tools
Update prepareConsistentTestingEnvironment to use a non-deprecated API.
https://bugs.webkit.org/show_bug.cgi?id=116710
Reviewed by Mark Rowe.
- DumpRenderTree/mac/DumpRenderTree.mm:
(prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
- 1:05 AM Changeset in webkit [150635] by
-
- 4 edits in trunk/Source/WebCore
[BlackBerry] DRT - crashed on GraphicsContext3D::makeContextCurrent
https://bugs.webkit.org/show_bug.cgi?id=116654
Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-24
Reviewed by Carlos Garcia Campos.
PR 331552.
Internally reviewed and amended by Arvid Nilsson.
No new tests, this patch is to fix DRT crashes in fast/canvas/webgl.
The instance of GraphicsContext3D has already been destroyed but
WebGLLayerWebKitThread is not aware of that. This is because compositor
layer of the WebGL graphics context was referenced outside the context.
So when destructing GraphicsContext3D the compositing layer was not
destructed.
Fix by setting m_webGLContext to 0 when destructing GrapthicsContext3D
after releasing the compositor layer, so that it won't be de-referenced
again later.
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
- platform/graphics/blackberry/WebGLLayerWebKitThread.cpp:
(WebCore::WebGLLayerWebKitThread::~WebGLLayerWebKitThread):
(WebCore::WebGLLayerWebKitThread::webGLContextDestroyed):
(WebCore):
- platform/graphics/blackberry/WebGLLayerWebKitThread.h:
(WebGLLayerWebKitThread):
- 12:32 AM Changeset in webkit [150634] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove SKIA leftovers from WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=116656
Patch by Jeff Rogers <jrogers@rim.com> on 2013-05-24
Reviewed by Rob Buis.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
- 12:12 AM Changeset in webkit [150633] by
-
- 6 edits in trunk/Source
Typing in Safari's unified field causes unnecessary web content repaints.
<http://webkit.org/b/116703>
Reviewed by Andy Estes.
Source/WebCore:
Break out an alternate version of Page::markAllMatchesForText() that only counts the number of times
a string occurs in the page, but doesn't try to mark the occurrences.
This allows Safari to count matches for the 'Find "foo" on This Page' functionality in the unified
location bar without causing tile repaints.
- WebCore.exp.in:
- page/Page.h:
- page/Page.cpp:
(WebCore::Page::findMatchesForText):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::countFindMatches):
Renamed markAllMatchesForText() to findMatchesForText() and gave it a boolean parameter to control whether
matches should be marked or not. countFindMatches() is the new helper that doesn't mark.
Source/WebKit2:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
Call WebCore::Page::countMatchesForText() instead of markAllMatchesForText(). If the search string
is found inside the page content, the renderer containing that text will no longer be repainted.
- 12:05 AM Changeset in webkit [150632] by
-
- 3 edits in trunk/LayoutTests
Add back a failing test expectation on fast/canvas/webgl/object-deletion-behaviour.html
after r150558 on Lion Debug WK1.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 12:02 AM Changeset in webkit [150631] by
-
- 2 edits in trunk/Source/WebCore
https://bugs.webkit.org/show_bug.cgi?id=116702
REGRESSION (r150399): Scrollbar missing for all overflow scroll
-and corresponding-
<rdar://problem/13963712>
Reviewed by Simon Fraser.
This was a silly copy-paste error.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
May 23, 2013:
- 11:56 PM Changeset in webkit [150630] by
-
- 2 edits in trunk/Source/JavaScriptCore
CLoop llint backend should not use the d8 register as scratch register
https://bugs.webkit.org/show_bug.cgi?id=116019
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-23
Reviewed by Csaba Osztrogonác.
- offlineasm/cloop.rb:
- 11:26 PM Changeset in webkit [150629] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to suspend/resume RootLayerCommit when the application becomes inactive/active
https://bugs.webkit.org/show_bug.cgi?id=115245
Patch by Xiaobo Wang <xiaobwang@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
PR 330917.
Internally reviewed by Arvid Nilsson.
- Suspend/resumeRootLayerCommit when notified app activation state
change.
- Schedule root layer commit in resumeRootLayerCommit() to explicitly
start root layer commit timer, so that there's a commit even if
BackingStore got disabled/removed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyAppActivationStateChange):
(BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit):
- 11:23 PM Changeset in webkit [150628] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Need to forward the opener frame url to client when creating a new window
https://bugs.webkit.org/show_bug.cgi?id=116566
Patch by Andy Chen <andchen@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
PR 337935
Internally reviewed by Arvid Nilsson.
When creating a new window, forward the opener frame url to client.
- Api/WebPageClient.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::createWindow):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):
- 11:20 PM Changeset in webkit [150627] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=116671
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-23
Reviewed by Brent Fulgham.
- page/FrameView.h: Added guard for ACCELERATED_COMPOSITING.
- 11:15 PM Changeset in webkit [150626] by
-
- 2 edits in trunk/Tools
Add missing dependencies to deps script.
[GTK] Missing packages in install-dependencies script.
https://bugs.webkit.org/show_bug.cgi?id=116632
Reviewed by Martin Robinson.
- gtk/install-dependencies:
- 11:07 PM Changeset in webkit [150625] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Compositor API change: Don't pass the unused "viewport" parameter.
https://bugs.webkit.org/show_bug.cgi?id=116545
Internal PR 189775
Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-05-23
Reviewed by Rob Buis.
Also change the name of the "documentContents" parameter
to the more descriptive "documentSrcRect".
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
- Api/WebPageCompositor.h:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- 10:14 PM Changeset in webkit [150624] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][EFL][QT] Build break after r150610
https://bugs.webkit.org/show_bug.cgi?id=116699
Patch by Ryuan Choi <ryuan.choi@samsung.com> on 2013-05-23
Reviewed by Csaba Osztrogonác.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin): Initialized pluginProcessSandboxPolicy.
- 7:59 PM Changeset in webkit [150623] by
-
- 1 copy in tags/Safari-537.43.1
New Tag.
- 6:35 PM Changeset in webkit [150622] by
-
- 11 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: rationalize DFG::CapabilityLevel and DFGCapabilities.[h|cpp]
https://bugs.webkit.org/show_bug.cgi?id=116696
Reviewed by Sam Weinig.
Make it so that all capability calculation is funneled through one function, which tells
you everything you wanted to know: can it be inlined, and can it be compiled.
This work will help with https://bugs.webkit.org/show_bug.cgi?id=116557, since now the
JIT has a fairly authoritative answer to the "can it be inlined" question.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::ProgramCodeBlock::capabilityLevelInternal):
(JSC::EvalCodeBlock::capabilityLevelInternal):
(JSC::FunctionCodeBlock::capabilityLevelInternal):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::capabilityLevel):
(JSC::CodeBlock::capabilityLevelState):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::debugFail):
(DFG):
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::capabilityLevel):
- dfg/DFGCapabilities.h:
(DFG):
(JSC::DFG::capabilityLevel):
(JSC::DFG::evalCapabilityLevel):
(JSC::DFG::programCapabilityLevel):
(JSC::DFG::functionForCallCapabilityLevel):
(JSC::DFG::functionForConstructCapabilityLevel):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForClosureCall):
(JSC::DFG::canInlineFunctionForConstruct):
- dfg/DFGCommon.h:
(JSC::DFG::canCompile):
(DFG):
(JSC::DFG::canInline):
(JSC::DFG::leastUpperBound):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- 6:33 PM Changeset in webkit [150621] by
-
- 2 edits in trunk/Source/WTF
[Windows] Rolling back r150600 as it breaks the VS2010 builds.
- wtf/StackBounds.cpp: Rollback.
- 5:43 PM Changeset in webkit [150620] by
-
- 7 edits in trunk/Source/WebKit2
Shim Flash plug-in to allow its updater to run
https://bugs.webkit.org/show_bug.cgi?id=116692
<rdar://problem/13938510>
Reviewed by Sam Weinig.
- PluginProcess/PluginProcess.h:
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::replacedNSConcreteTask_launch):
(WebKit::initializeCocoaOverrides):
Patch -[NSConcreteTask launch] to call PluginProcess::launchProcess.
(WebKit::PluginProcess::launchProcess):
Send a LaunchProcess message to the UI process.
- UIProcess/Plugins/PluginProcessProxy.cpp:
- UIProcess/Plugins/PluginProcessProxy.h:
Remove PluginProcessProxy::didReceiveMessage.
(PluginProcessProxy):
- UIProcess/Plugins/PluginProcessProxy.messages.in:
Add LaunchProcess message and remove LegacyReceiver attribute.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::isFlashUpdater):
Helper function to determine whether the process is the flash updater.
(WebKit::shouldLaunchProcess):
Return whether we should launch this process.
(WebKit::PluginProcessProxy::launchProcess):
Determine if we should launch this process and then do so.
- 5:41 PM Changeset in webkit [150619] by
-
- 2 edits in trunk/Tools
[Windows] Unreviewed change for NRWT support.
- Scripts/webkitpy/port/win.py:
(WinPort.default_child_processes): Added a default implementation
that limits NRWT to a single instance.
- 5:03 PM Changeset in webkit [150618] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. Modify WebCore for AppleWin 2010 production build.
- WebCore.vcxproj/WebCoreGenerated.make:
(WebCore::AXObjectCache::frameLoadingEventPlatformNotification):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
- 4:44 PM Changeset in webkit [150617] by
-
- 2 edits in trunk/LayoutTests
[EFL] Rebaseline after r150593
https://bugs.webkit.org/show_bug.cgi?id=116695
Unreviewed gardening.
Moved some editing tests from execCommand into pasteboard.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-23
- platform/efl/TestExpectations:
- 4:22 PM Changeset in webkit [150616] by
-
- 6 edits in trunk/LayoutTests
Make Math.imul tests run quicker, and fix some other bugs.
Rubber stampted by Oliver Hunt.
Also make tests not call print().
- fast/js/regress/script-tests/cell-argument.js:
- fast/js/regress/script-tests/imul-double-only.js:
(f):
- fast/js/regress/script-tests/imul-int-only.js:
(f):
- fast/js/regress/script-tests/imul-mixed.js:
(f):
- fast/js/regress/script-tests/object-closure-call.js:
- 4:00 PM Changeset in webkit [150615] by
-
- 2 edits in trunk/Tools
Remove meaningless "test_uses_apache" from Python test cases.
https://bugs.webkit.org/show_bug.cgi?id=38756
Patch by Brent Fulgham <Brent Fulgham> on 2013-05-23
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_driver_cmd_line): Remove the meaningless
"test_uses_apache" test case from the Python test infrastructure.
It was hard-coded to true, even though not all ports use
Apache.
- 2:44 PM Changeset in webkit [150614] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150610. <rdar://problem/13975569>
- 2:17 PM Changeset in webkit [150613] by
-
- 3 edits in trunk/Source/WebCore
We need to clear main resource when detaching DocumentLoader from the frame.
https://bugs.webkit.org/show_bug.cgi?id=116680
Normally, when we detach the documentLoader in DocumentLoader::detachFromFrame, main resource is also cleared
in stopLoading(). There is possibility that main resource not being cleared, and this could cause crash later
since docLoader could still receive resource callbacks. To avoid that, we can remove docLoader from main resource's
client set in detachFromFrame.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-05-23
Reviewed by Brady Eidson.
No new tests, this doesn't happen on OS X.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::clearMainResource):
- loader/cache/CachedResource.h: make hasClient accessible publicly.
(WebCore::CachedResource::hasClient):
(CachedResource):
- 1:59 PM Changeset in webkit [150612] by
-
- 3 edits in trunk/Tools
[Windows] Update new-run-webkit-tests for Windows port.
https://bugs.webkit.org/show_bug.cgi?id=38756
Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-23
Reviewed by Ryosuke Niwa.
- Scripts/new-run-webkit-httpd:
(run): Switch from 'chromium' to 'win'
- Scripts/webkitpy/port/win.py:
(WinPort): Add support methods for lighttpd server.
(WinPort._uses_apache):
(WinPort._path_to_lighttpd):
(WinPort._path_to_lighttpd_modules):
(WinPort._path_to_lighttpd_php):
- 1:56 PM Changeset in webkit [150611] by
-
- 3 edits2 adds in trunk
assertion failed: !node node->isElementNode() in WebCore::RenderBlock::clone https://bugs.webkit.org/show_bug.cgi?id=116614
Patch by Mihai Maerean <Mihai Maerean> on 2013-05-23
Reviewed by David Hyatt.
Source/WebCore:
Add a test for flow threads so they don't end up being cloned in region based multi columns with columns:1 where
the only child has column-span:all.
Test: fast/multicol/newmulticol/direct-child-column-span-all.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
LayoutTests:
- fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Added.
- fast/multicol/newmulticol/direct-child-column-span-all.html: Added.
- 1:48 PM Changeset in webkit [150610] by
-
- 2 edits in trunk/Source/WebKit2
Don't run all plug-ins unsandboxed
https://bugs.webkit.org/show_bug.cgi?id=116690
<rdar://problem/13975569>
Reviewed by Jessie Berlin.
Remove debugging code.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
- 1:08 PM Changeset in webkit [150609] by
-
- 7 edits in trunk/Source
Crash in convertMainResourceLoadToDownload when downloading file by option-return
https://bugs.webkit.org/show_bug.cgi?id=116451
Reviewed by Andreas Kling.
Source/WebCore:
Handle MainResourceLoader being null here which will happen when loading a cached main resource.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::continueAfterContentPolicy):
Source/WebKit/mac:
If the main resource loader is null, create a new download instead since there's no existing loader to convert.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
Source/WebKit2:
If the main resource loader is null, create a new download instead since there's no existing loader to convert.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertMainResourceLoadToDownload):
- 12:56 PM Changeset in webkit [150608] by
-
- 2 edits in trunk/LayoutTests
Remove a stale test expectation.
- platform/wk2/TestExpectations:
- 12:49 PM Changeset in webkit [150607] by
-
- 2 edits in trunk/LayoutTests
Update Mac test expectations for the bug 85408 as bugs 116398 and 116477 have been merged into it.
- platform/mac/TestExpectations:
- 12:46 PM Changeset in webkit [150606] by
-
- 12 edits in trunk/Source/WebCore
KURL::createCFURL() should return a RetainPtr<CFURLRef>
https://bugs.webkit.org/show_bug.cgi?id=116644
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-23
Reviewed by Andreas Kling.
For consistency with the other createCFType() APIs in WebKit, KURL should
return a RetainPtr<> instead of raw +1 CFURLRef.
No leak were discovered while making this change.
- platform/KURL.h:
- platform/cf/KURLCFNet.cpp:
(WebCore):
(WebCore::createCFURLFromBuffer):
(WebCore::KURL::createCFURL):
(WebCore::KURL::fileSystemPath):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::createAssetForURL):
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::setURLForRect):
- platform/mac/KURLMac.mm:
(WebCore):
(WebCore::KURL::operator NSURL *):
(WebCore::KURL::createCFURL):
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
- platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::addProxyServersForURL):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
- platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- 12:42 PM Changeset in webkit [150605] by
-
- 2 edits in trunk/LayoutTests
Add back failing test expectations for the bugs 88672 and 89528 after r150558 and r150559 on Lion.
- platform/mac/TestExpectations:
- 12:37 PM Changeset in webkit [150604] by
-
- 2 edits in trunk/LayoutTests
fast/workers/storage/use-same-database-in-page-and-workers.html times out on the lion bots
https://bugs.webkit.org/show_bug.cgi?id=81618
Add back the flaky test failure on Mac.
- platform/mac/TestExpectations:
- 12:19 PM Changeset in webkit [150603] by
-
- 3 edits in trunk/Source/WTF
Use correct stack size on Solaris and OpenBSD
https://bugs.webkit.org/show_bug.cgi?id=114978
Reviewed by Oliver Hunt.
Original patch by David Hill <david@wmol.com>.
Use stack_t.ss_size for getting the size of the stack.
- wtf/Platform.h:
- wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):
- 11:55 AM Changeset in webkit [150602] by
-
- 5 edits2 adds in trunk
The ellipsis in a text overflow should not avoid floats
https://bugs.webkit.org/show_bug.cgi?id=115746
Reviewed by David Hyatt.
Source/WebCore:
When placing an ellipsis for text overflow we shouldn't avoid any floats on the line.
That is to say, if there is a float in the box we overflow we should let our no-wrap text,
including the ellipsis, render inside the float just as we would if overflow was hidden but
a text-overflow rendering had not been specified.
Test: fast/css/text-overflow-ellipsis-behind-floats.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkLinesForTextOverflow):
LayoutTests:
- fast/css/text-overflow-ellipsis-behind-floats-expected.html: Added.
- fast/css/text-overflow-ellipsis-behind-floats.html: Added.
- fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html:
- fast/css/text-overflow-ellipsis-full-truncate-rtl.html: Change this test to expect the text to cross into the floating input element and render the ellipsis at the left extreme of the element. The previous expected rendering relied on the incorrect premise that an overflow ellipsis should avoid floated elements.
- 11:51 AM Changeset in webkit [150601] by
-
- 15 edits in branches/safari-537.43-branch/Source
Merged r150556. <rdar://problem/13918391>
- 11:51 AM Changeset in webkit [150600] by
-
- 2 edits in trunk/Source/WTF
[WIN] Implement correct detection of stack size
https://bugs.webkit.org/show_bug.cgi?id=116661
Reviewed by Oliver Hunt.
- wtf/StackBounds.cpp:
(WTF):
(WTF::StackBounds::initialize):
- 11:49 AM Changeset in webkit [150599] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13849260> Sandbox violations reading .CFUserTextEncoding
Reviewed by Dan Bernstein.
- WebProcess/com.apple.WebProcess.sb.in: Allow this.
- 11:48 AM Changeset in webkit [150598] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150543. <rdar://problem/13904054>
- 11:44 AM Changeset in webkit [150597] by
-
- 6 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150537. <rdar://problem/13964515>
- 11:30 AM Changeset in webkit [150596] by
-
- 3 edits in trunk/LayoutTests
[Lion] [WK2] compositing/overflow/overflow-compositing-descendant.html
https://bugs.webkit.org/show_bug.cgi?id=116684
Add a timeout/failure test expectation. Also update the expected result since the first frame
of the video must be shown in this test.
- platform/mac-wk2/TestExpectations:
- platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
- 11:03 AM Changeset in webkit [150595] by
-
- 2 edits in trunk/Source/WebKit2
Move posix_spawn onto a zero delay timer
https://bugs.webkit.org/show_bug.cgi?id=116682
Reviewed by Anders Carlson.
<rdar://problem/13973468>
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(ReexecInfo):
- struct to hold info from the XPC message.
(WebKit::reexec):
- moved call to posix_spawn out to this helper.
(WebKit::reexecCallBack):
- calls reexec.
(WebKit::XPCServiceEventHandler):
- removed call to posix_spawn; schedule a call to reexecCallBack.
- 10:52 AM Changeset in webkit [150594] by
-
- 4 edits in trunk/LayoutTests
Fix loader/go-back-cached-main-resource.html test
https://bugs.webkit.org/show_bug.cgi?id=116670
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-23
Reviewed by Alexey Proskuryakov.
The page does not get an onload when being restored from page cache. The
test case case is modified to handle pageshow event instead.
- loader/go-back-cached-main-resource.html: Wait for the third
'first-page' message to finish the test.
- loader/resources/first-page.html: Use onpageshow instead of onload.
- loader/resources/other-page.html: Ditto.
- 10:50 AM Changeset in webkit [150593] by
-
- 1 edit13 moves in trunk/LayoutTests
Several editing tests that copy & paste slow down Mac WK2 EWS
https://bugs.webkit.org/show_bug.cgi?id=116681
Reviewed by Anders Carlsson.
Move editing tests that trigger copy and paste from execCommand into pasteboard.
Since NWRT uses a single instance of WebKitTestRunner to run tests in single directory,
this should mitigate the issue for now.
In the long term, we should really mock out the clipboard in WebKitTestRunner.
- editing/execCommand/4128080-2-expected.txt: Removed.
- editing/execCommand/4128080-2.html: Removed.
- editing/execCommand/5939887-expected.txt: Removed.
- editing/execCommand/5939887.html: Removed.
- editing/execCommand/copy-without-selection-expected.txt: Removed.
- editing/execCommand/copy-without-selection.html: Removed.
- editing/execCommand/paste-2.html: Removed.
- editing/pasteboard/copy-cut-paste-events-fired-when-disabled-expected.txt: Copied from LayoutTests/editing/execCommand/5939887-expected.txt.
- editing/pasteboard/copy-cut-paste-events-fired-when-disabled.html: Copied from LayoutTests/editing/execCommand/5939887.html.
- editing/pasteboard/copy-inside-h1-preserves-h1-expected.txt: Copied from LayoutTests/editing/execCommand/4128080-2-expected.txt.
- editing/pasteboard/copy-inside-h1-preserves-h1.html: Copied from LayoutTests/editing/execCommand/4128080-2.html.
- editing/pasteboard/copy-without-selection-expected.txt: Copied from LayoutTests/editing/execCommand/copy-without-selection-expected.txt.
- editing/pasteboard/copy-without-selection.html: Copied from LayoutTests/editing/execCommand/copy-without-selection.html.
- editing/pasteboard/paste-2.html: Copied from LayoutTests/editing/execCommand/paste-2.html.
- platform/gtk/editing/execCommand/paste-2-expected.png: Removed.
- platform/gtk/editing/execCommand/paste-2-expected.txt: Removed.
- platform/gtk/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.png.
- platform/gtk/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/gtk/editing/execCommand/paste-2-expected.txt.
- platform/mac/editing/execCommand/paste-2-expected.png: Removed.
- platform/mac/editing/execCommand/paste-2-expected.txt: Removed.
- platform/mac/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.png.
- platform/mac/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/mac/editing/execCommand/paste-2-expected.txt.
- platform/qt/editing/execCommand/paste-2-expected.png: Removed.
- platform/qt/editing/execCommand/paste-2-expected.txt: Removed.
- platform/qt/editing/pasteboard/paste-2-expected.png: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.png.
- platform/qt/editing/pasteboard/paste-2-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/paste-2-expected.txt.
- 10:49 AM Changeset in webkit [150592] by
-
- 2 edits in trunk/Tools
Make default bug links in buildbot clickable
https://bugs.webkit.org/show_bug.cgi?id=116673
Reviewed by Ryosuke Niwa.
Use changecommentlink of html.WebStatus to make the links clickable.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- 10:39 AM WebKit Team edited by
- (diff)
- 10:17 AM Changeset in webkit [150591] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
EWS bubbles need more space
https://bugs.webkit.org/show_bug.cgi?id=116675
Reviewed by Andreas Kling.
- template/en/custom/attachment/list.html.tmpl:
- 9:45 AM Changeset in webkit [150590] by
-
- 13 edits in trunk
Unreviewed, rolling out r150586.
http://trac.webkit.org/changeset/150586
https://bugs.webkit.org/show_bug.cgi?id=116660
Those constructors should be exposed on the WorkerContext, not
the DOMWindow
Source/WebCore:
- fileapi/FileReaderSync.idl:
- workers/WorkerLocation.idl:
LayoutTests:
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/constructor-length-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 9:13 AM Changeset in webkit [150589] by
-
- 2 edits in trunk/LayoutTests
[CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders
https://bugs.webkit.org/show_bug.cgi?id=114571
Tests seems to be passing now, removed from TestExpectations.
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-23
Reviewed by Anders Carlsson.
- platform/mac-wk2/TestExpectations:
- 9:11 AM Changeset in webkit [150588] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] The web context does not contain any link properties if the context node is an image enclosed by a link node
https://bugs.webkit.org/show_bug.cgi?id=116627
Patch by Ed Baker <edbaker@blackberry.com> on 2013-05-23
Reviewed by Xan Lopez.
PR #341084
If the context node has an image tag and an enclosing link node was detected then add the link properties to the context.
Internally Reviewed by Gen Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
- 8:55 AM Changeset in webkit [150587] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Validate form data before doing direct submission.
https://bugs.webkit.org/show_bug.cgi?id=116674
Reviewed by Xan Lopez.
PR 314202.
Check validation of the input form before triggering direct submission.
Internally Reviewed by Nima Ghanavatian.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::submitForm):
- 8:20 AM Changeset in webkit [150586] by
-
- 13 edits in trunk
Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
https://bugs.webkit.org/show_bug.cgi?id=116660
Reviewed by Kentaro Hara.
Source/WebCore:
Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation to match their
respective specifications:
- http://dev.w3.org/2006/webapi/FileAPI/#FileReaderSync
- http://dev.w3.org/html5/workers/#workerlocation
No new tests, covered by existing tests.
- fileapi/FileReaderSync.idl:
- workers/WorkerLocation.idl:
LayoutTests:
Rebaseline a couple of test cases now that FileReaderSync and WorkerLocation
attributes are exposed on the global Window object.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/constructor-length-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- platform/gtk/fast/js/constructor-length-expected.txt:
- platform/gtk/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/constructor-length-expected.txt:
- platform/qt/fast/js/global-constructors-attributes-expected.txt:
- 7:14 AM Changeset in webkit [150585] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Properly fill the ResourceError in FrameLoaderClientBlackBerry::cannotShowURLError
https://bugs.webkit.org/show_bug.cgi?id=116603
Patch by Rob Buis <rbuis@rim.com> on 2013-05-23
Reviewed by Xan Lopez.
PR 119789
Internally reviewed by Yong Li.
Provide a domain value for this ResourceError instance. Note that
this does not change behavior.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
- 7:00 AM Changeset in webkit [150584] by
-
- 3 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Skip some failing test.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png: Rebaselined after r148594.
- platform/qt-5.0-wk2/fast/forms/select-baseline-expected.txt:
- platform/qt-5.0-wk2/fast/images/repaint-subrect-grid-expected.txt: Rebaselined after r149292.
- 6:42 AM TestExpectations edited by
- Link to "Writing Reftests" to explain more on reference tests (diff)
- 6:17 AM Changeset in webkit [150583] by
-
- 2 edits in trunk/Source/WebKit2
[cmake] Fix generating-forwarding-headers rule after r150460
https://bugs.webkit.org/show_bug.cgi?id=116659
Reviewed by Christophe Dumez.
- CMakeLists.txt: Typo fix.
- 5:45 AM Changeset in webkit [150582] by
-
- 3 edits in trunk/Source/WebKit2
[GTK] Remote Web Inspector sometimes won't serve any content
https://bugs.webkit.org/show_bug.cgi?id=116225
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-05-23
Reviewed by Gustavo Noronha Silva.
Added an option to use environment variable to set up path to
inspector server files. Implementation is similar to InspectorClientGtk
implementation.
- UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::inspectorServerFilesPath):
(WebKit):
- 5:30 AM Changeset in webkit [150581] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Use WK2 C API in ewk_view_pagination_mode_set|get
https://bugs.webkit.org/show_bug.cgi?id=116657
Reviewed by Christophe Dumez.
WKPageGet|SetPaginationMode APIs is present in WK2 C APIs. So, we need to use them for
ewk_view_pagination_mode_set|get.
Besides we don't need to use WebCore namespace anymore.
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):
- 5:22 AM Changeset in webkit [150580] by
-
- 13 edits in trunk/Source/WebCore
Remove special case for MessagePortArray from bindings generator
https://bugs.webkit.org/show_bug.cgi?id=116653
Reviewed by Kentaro Hara.
Use MessagePort[] instead of MessagePortArray type in the IDL as MessagePortArray
is not defined on IDL side. This allows us to remove the special case for
MessagePortArray from the bindings generator.
No new tests, no behavior change.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Remove special case for MessagePortArray.
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
(webkit_dom_test_serialized_script_value_interface_class_init):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::jsTestSerializedScriptValueInterfacePorts):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
- bindings/scripts/test/TestSerializedScriptValueInterface.idl: Replace MessagePortArray
by MessagePort[].
- dom/MessageEvent.h:
(WebCore::MessageEvent::ports): The method should return a Vector, not a Vector*
as the array on JavaScript side is not nullable.
- dom/MessageEvent.idl: Replace MessagePortArray by MessagePort[].
- 3:32 AM Changeset in webkit [150579] by
-
- 3 edits in trunk/LayoutTests
media/W3C/video/networkState/networkState_during_progress.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=76280
Unreviewed gardening.
Change expectation to the correct output and mark as flaky.
- TestExpectations:
- media/W3C/video/networkState/networkState_during_progress-expected.txt:
- 2:26 AM Changeset in webkit [150578] by
-
- 4 edits in trunk/Source/WebKit2
Support frame instrumentation for coordinated graphics
https://bugs.webkit.org/show_bug.cgi?id=115260
Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-23
Reviewed by Andreas Kling.
Enabled supportsFrameInstrumentation on ports that use coordinated graphics
by calling didBeginFrame().
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::supportsFrameInstrumentation):
(WebKit):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::syncDisplayState):
- 2:20 AM Changeset in webkit [150577] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk1/TestExpectations: Remove a test failure that skipped in qt.
- platform/qt/TestExpectations: Unskip now passing test.
- 1:39 AM Changeset in webkit [150576] by
-
- 3 edits1 add in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt-5.0-wk2/TestExpectations: Unskip after rebaseline.
- platform/qt/TestExpectations: Skip flaky test.
- platform/qt/plugins/mouse-events-expected.txt: Rebaselining after r150558.
- 12:06 AM Changeset in webkit [150575] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Back, Forward and Stop should be hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=116615
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-23
Reviewed by Christophe Dumez.
Context menu items: Back, Forward, Stop, Reload, should be shown only when
they are able to perform action.
No new tests - no new functionality.
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
May 22, 2013:
- 11:32 PM Changeset in webkit [150574] by
-
- 2 edits in trunk/LayoutTests
Updated the bug associated with the failure of media/context-menu-actions.html
from the bug 45021 to the bug 116651 since the former is the bug for which this test was added.
Also skip this test it has been timing out intermittently.
- platform/mac/TestExpectations:
- 11:22 PM Changeset in webkit [150573] by
-
- 2 edits in trunk/LayoutTests
Update Mac test expectation for the bug 82980.
The test is consistently timing out instead of being flaky now.
- platform/mac/TestExpectations:
- 11:20 PM Changeset in webkit [150572] by
-
- 2 edits in trunk/LayoutTests
Add back two Lion test expectations after r150558 and r150559.
- platform/mac/TestExpectations:
- 11:03 PM Changeset in webkit [150571] by
-
- 3 edits in trunk/LayoutTests
Make the test expectation for the bug 116649 specific to WK2
as the test is passing on WK1.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- 11:01 PM Changeset in webkit [150570] by
-
- 3 edits in trunk/LayoutTests
Mark media/audio-repaint.html as always failing on Mac.
Also add back a failing test expectation to compositing/rtl/rtl-fixed-overflow-scrolled.html on Mac WK2.
Also add failing test expectation for the bug 116649.
- platform/mac/TestExpectations:
- 10:18 PM Changeset in webkit [150569] by
-
- 3 edits3 adds in trunk
Use uninitialized register in "JIT::emit_op_neq_null" and "emit_op_eq_null"
https://bugs.webkit.org/show_bug.cgi?id=116593
Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2013-05-22
Reviewed by Filip Pizlo.
Generated instructions using uninitialized register. It's caused by a mistake of r126494.
Source/JavaScriptCore:
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
LayoutTests:
- fast/js/neq-null-crash-expected.txt: Added.
- fast/js/neq-null-crash.html: Added.
- fast/js/script-tests/neq-null-crash.js: Added.
- 10:07 PM Changeset in webkit [150568] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
Merge http://trac.webkit.org/changeset/149162, since we need it after
we merged some bytecode refactorings.
2013-04-25 Filip Pizlo <fpizlo@apple.com>
DFG doesn't support to_jsnumber
https://bugs.webkit.org/show_bug.cgi?id=115129
Reviewed by Geoffrey Garen.
Based on Oliver's patch. Implements to_jsnumber as Identity(Number:@thingy), and then does
an optimization in Fixup to turn Identity(Number:) into Identity(Int32:) if the predictions
tell us to. Identity is later turned into Phantom.
Also fixed BackPropMask, which appeared to have NodeDoesNotExit included in it. That's
wrong; NodeDoesNotExit is not a backward propagation property.
Also fixed Identity to be marked as CanExit (i.e. not NodeDoesNotExit).
This more than doubles the FPS on ammo.
- dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.h: (JSC::DFG::canCompileOpcode):
- dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (FixupPhase): (JSC::DFG::FixupPhase::observeUseKindOnNode): (JSC::DFG::FixupPhase::observeUseKindOnEdge):
- dfg/DFGNodeFlags.h: (DFG):
- dfg/DFGNodeType.h: (DFG):
- dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate):
- 10:00 PM Changeset in webkit [150567] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Fix indentation of CodeBlock.h
Rubber stamped by Mark Hahnenberg.
- bytecode/CodeBlock.h:
- 10:00 PM Changeset in webkit [150566] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix indentation of CodeBlock.h
Rubber stampted by Mark Hahnenberg.
- bytecode/CodeBlock.h:
- 9:53 PM Changeset in webkit [150565] by
-
- 22 edits in branches/dfgFourthTier/Source/JavaScriptCore
Rename getJITCode and getJITType to jitCode and jitType.
Rubber stampted by Mark Hahnenberg.
- assembler/RepatchBuffer.h:
(JSC::RepatchBuffer::RepatchBuffer):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::stronglyVisitWeakReferences):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::codeOriginForReturn):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::ProgramCodeBlock::jettison):
(JSC::EvalCodeBlock::jettison):
(JSC::FunctionCodeBlock::jettison):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
(JSC::CodeBlock::adjustedExitCountThreshold):
(JSC::CodeBlock::tallyFrequentExitSites):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::jitCode):
(JSC::CodeBlock::jitCodeWithArityCheck):
(JSC::CodeBlock::jitType):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::jitCompile):
(JSC::CodeBlock::addFrequentExitSite):
(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan):
(JSC::ExecState::isInlineCallFrame):
- dfg/DFGAssemblyHelpers.cpp:
(JSC::DFG::AssemblyHelpers::decodedCodeMapFor):
- dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::AssemblyHelpers):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::codeLocationForRepatch):
- dfg/DFGOSRExitCompiler.cpp:
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
- dfg/DFGOperations.cpp:
- dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExit::codeLocationForRepatch):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::clearMarks):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
(JSC::DFGCodeBlocks::traceMarkedCodeBlocks):
- interpreter/Interpreter.cpp:
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriateImpl):
(JSC::jitCompileFunctionIfAppropriateImpl):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::jettisonOptimizedCode):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::jettisonOptimizedCode):
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::jettisonOptimizedCodeForCall):
(JSC::FunctionExecutable::jettisonOptimizedCodeForConstruct):
- tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
- 9:26 PM Changeset in webkit [150564] by
-
- 2 edits in trunk/Tools
REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
https://bugs.webkit.org/show_bug.cgi?id=116595
Temporarily skip this test.
- TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
(TestWebKitAPI::TEST):
- 9:15 PM Changeset in webkit [150563] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Race between LLInt->Baseline tier-up and DFG reading Baseline profiling data
https://bugs.webkit.org/show_bug.cgi?id=116633
Reviewed by Mark Hahnenberg.
Previously we would check if we had Baseline JIT profiling data by seeing if the
appropriate vector was non-empty. This is horrible if we're doing LLInt->Baseline
tier-up at the same time. This will happen for code we are inlining, if we're
deciding to inline it before the LLInt->Baseline tier-up happened for that code.
This changes things to take advantage of the fact that the very last thing that
LLInt->Baseline tier-up will do (in JITDriver.h) is setJITCode(). We now precede
the actual work in setJITCode() with a store-store fence to ensure that all
stores to modify the CodeBlock happen before setting the JITCode, and we modify
CodeBlock::getJITType() to use load-load fences to ensure that if you see
JITCode::BaselineJIT then you will also see all of those vectors. Then this
changes all of the code that scrapes Baseline JIT profiles to check if
getJITType() returns JITCode::BaselineJIT instead of checking vector sizes.
The outcome is that for the non-racy cases we behave as we did before (we fall
back on LLInt profiling if the tier-up hasn't happened) and for racy cases we
use LLInt profiling conservatively.
Note that for some (but not all!) of the cases where we scrape Baseline JIT
profiling, we would have anyway been holding the CodeBlock::m_lock so we can also
fix those cases by just having setJITCode graph that lock. This patch does that
also, mainly because although we only call setJITCode() from the main thread, in
general it's dangerous to have a pointer to a ref-counted object being modified
in a racy way. So, this patch just does the most conservative thing possible that
does we can afford to do.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::getJITType):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- 8:41 PM Changeset in webkit [150562] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip 3 more tests which has problem related to ecore library.
- platform/efl/TestExpectations:
- 8:36 PM Changeset in webkit [150561] by
-
- 13 edits4 deletes in trunk/Source
Rolling out r150555. It borked about 30 media tests.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
- html/HTMLMediaElement.h:
- platform/audio/AudioSession.cpp:
(WebCore):
(WebCore::AudioSession::AudioSession):
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionListener.h:
(AudioSessionListener):
- platform/audio/AudioSessionManager.cpp: Removed.
- platform/audio/AudioSessionManager.h: Removed.
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure):
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferDuration):
(WebCore::AudioSession::setPreferredBufferDuration):
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate):
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::configure):
- platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
- platform/audio/mac/AudioSessionMac.cpp: Removed.
- platform/audio/mac/AudioSessionManagerMac.cpp: Removed.
Source/WTF:
- wtf/Platform.h:
- 6:11 PM Changeset in webkit [150560] by
-
- 9 edits in trunk/Source/WebCore
Active DOM object resumption should match reason for suspending
https://bugs.webkit.org/show_bug.cgi?id=116476
Add a reason to the arguments for resuming active DOM object and
scheduled tasks and ensure that it matches the suspend reason before
actually resuming the objects.
Reviewed by Joseph Pecoraro.
No new tests, no change in functionality.
- bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::setJavaScriptPaused): Add matching resume reason
- dom/Document.cpp:
(WebCore::Document::resumeActiveDOMObjects): Check for matching resume reason
(WebCore::Document::resumeScheduledTasks): Check for matching resume reason
- dom/Document.h:
(Document):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects): Check for matching resume reason
- dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
(WebCore::ScriptExecutionContext::reasonForSuspendingActiveDOMObjects): Expose suspend reason to subclasses
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore): Add matching resume reason
- page/Frame.cpp:
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations): Add matching resume reason
- page/PageGroupLoadDeferrer.cpp:
(WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): Add matching resume reason
- 6:07 PM Changeset in webkit [150559] by
-
- 2 edits in trunk/LayoutTests
Remove even more stale Mac test expectations. These tests are passing now!
- platform/mac/TestExpectations:
- 5:46 PM Changeset in webkit [150558] by
-
- 5 edits in trunk/LayoutTests
Even more Mac test expectation updates.
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/wk2/TestExpectations:
- plugins/mouse-events-expected.txt:
- 5:05 PM Changeset in webkit [150557] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix; cast OSStatus to an int before passing it to printf.
- platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::setPreferredBufferSize):
- 5:02 PM Changeset in webkit [150556] by
-
- 15 edits in trunk/Source
Don't snapshot plugins that can't be snapshotted
https://bugs.webkit.org/show_bug.cgi?id=116490
Reviewed by Tim Horton.
Some plugins, such as QuickTime, don't support snapshotting. We're
planning on another way to capture snapshots, but in the meantime make
sure that they don't fail to initialise because they were told to
not use accelerated rendering.
Source/WebCore:
- WebCore.exp.in: Export restartSnapshottedPlugin so that it can be used from WK2.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::restartSimilarPlugIns): Don't set the play state before restarting.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Make sure we indicated that this snapshotted plugin was clicked.
- html/HTMLPlugInImageElement.h: Move restartSnapshottedPlugin from protected to public.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Don't set play state here. Let the restart functions do it.
Source/WebKit2:
Expose a new message on the plugins so that they can tell the PluginView
if they support snapshotting or not.
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::supportsSnapshotting): New method.
- PluginProcess/PluginControllerProxy.h: Ditto.
- PluginProcess/PluginControllerProxy.messages.in: Message signature.
- WebProcess/Plugins/Netscape/NetscapePlugin.h: Add supportsSnapshotting.
- WebProcess/Plugins/PDF/SimplePDFPlugin.h: Ditto.
- WebProcess/Plugins/Plugin.h: Ditto - pure virtual here.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::supportsSnapshotting): Send the message to the plugin process and return the results.
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::didInitializePlugin): If the snapshotting plugin has a layer, make
sure to add it to the tree.
(WebKit::PluginView::isAcceleratedCompositingEnabled): Snapshotting plugins can use
accelerated compositing, just like normal plugins.
(WebKit::PluginView::pluginSnapshotTimerFired): If the plugin doesn't allow snapshotting,
immediately restart it.
- 4:43 PM Changeset in webkit [150555] by
-
- 13 edits3 copies1 add in trunk/Source
Mac: Set the default audio buffer size to a large value for <video> elements.
https://bugs.webkit.org/show_bug.cgi?id=116342
Reviewed by Eric Carlson.
Source/WebCore:
To enable power savings by waking up the audio hardware less often, set the
requested buffer frame size to a large value, such as 4096. Since this results
in approximately 100ms worth of buffer, set the buffer size to a much lower
value when playing WebAudio, which is much more sensitive to latency than video
or audio elements.
Introduce a new class, AudioSessionManager, as well as a helper class,
AudioSessionManagerToken. Audio elements, video elements, and WebAudio destination
nodes will create and retain a token, and release the token in their destructor.
This allows the AudioSessionManager to track how many of what type of audio-
generating objects are in existence.
This requires implementing AudioSession for Mac platforms. Move the implementation
for retrieving the hardware sample rate and setting the buffer duration into
AudioSessionMac from AudioDestinationMac, to be shared with AudioSessionManagerMac.
Change the AudioSession method preferredBufferLength() into preferredBufferSize(),
as the callers really want to specify a buffer size, not a buffer duration. On iOS,
where the available API requires a duration, perform the conversion from duration to
size on behalf of the caller.
- html/HTMLMediaElement.h: Add a AudioSessionManagerToken member.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize the token.
- platform/audio/AudioSession.cpp:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength.
- platform/audio/AudioSession.h:
- platform/audio/AudioSessionManager.cpp:
(AudioSessionManagerToken::create): Simple factory method.
(AudioSessionManagerToken::AudioSessionManagerToken): Call AudioSessionManager::incrementCount().
(AudioSessionManagerToken::~AudioSessionManagerToken): Call AudioSessionManager::decrementCount().
(AudioSessionManager::sharedManager): Simple singleton method.
(AudioSessionManager::AudioSessionManager): Simple constructor.
(AudioSessionManager::has): Return whether the type is present.
(AudioSessionManager::incrementCount): Increment, then call updateSessionState()
(AudioSessionManager::decrementCount): Decrement, then call updateSessionState()
(AudioSessionManager::updateSessionState): Stub, does nothing.
- platform/audio/AudioSessionManager.h:
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::configure): Call setPreferredBufferSize() instead of setPreferredBufferLength()
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::preferredBufferSize): Renamed from preferredBufferLength.
(WebCore::AudioSession::setPreferredBufferSize): Renamed from setPreferredBufferLength
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestination::hardwareSampleRate): Call AudioSession::sampleRate().
(WebCore::AudioDestinationMac::AudioDestinationMac): Create the AudioSessionManagerToken.
(WebCore::AudioDestinationMac::configure): Do not set the buffer size (this is done in AudioSessionManagerMac).
- platform/audio/mac/AudioDestinationMac.h:
- platform/audio/mac/AudioSessionMac.cpp: Added.
(WebCore::defaultDevice): Added, returns the default audio device.
(WebCore::AudioSession::AudioSession): Simple constructor.
(WebCore::AudioSession::~AudioSession): Simple destructor.
(WebCore::AudioSession::category): Stub, unimplemented.
(WebCore::AudioSession::setCategory): Ditto.
(WebCore::AudioSession::categoryOverride): Ditto.
(WebCore::AudioSession::setCategoryOverride): Ditto.
(WebCore::AudioSession::numberOfOutputChannels): Ditto.
(WebCore::AudioSession::setActive): Ditto.
(WebCore::AudioSession::sampleRate): Use the HAL to return the default audio device sample rate.
(WebCore::AudioSession::preferredBufferSize): Return the current HAL setting.
(WebCore::AudioSession::setPreferredBufferSize): Set the buffer size.
- platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState): Set the buffer size depending on what audio outputs are present.
- WebCore.xcodeproj/project.pbxproj: Add the new files to the project.
Source/WTF:
- wtf/Platform.h: Add a WTF_USE_AUDIO_SESSION setting.
- 4:42 PM Changeset in webkit [150554] by
-
- 3 edits2 adds in trunk
[CSS Shaders] valueForCustomFilterTransformParameter should check that renderer is a RenderBox
https://bugs.webkit.org/show_bug.cgi?id=116464
Reviewed by Alexandru Chiculita.
Source/WebCore:
If the renderer is not a RenderBox, we just use a zero size to compute the transform,
like in CSSComputedStyleDeclaration::computedTransform.
Test: css3/filters/custom/custom-filter-crash-inline-computed-style.html
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForCustomFilterTransformParameter):
LayoutTests:
- css3/filters/custom/custom-filter-crash-inline-computed-style-expected.txt: Added.
- css3/filters/custom/custom-filter-crash-inline-computed-style.html: Added.
- 4:27 PM Changeset in webkit [150553] by
-
- 1 edit1 add in trunk/LayoutTests
Add a missing result after r150551.
- http/tests/inspector/network/network-size-chunked-expected.txt: Added.
- 4:24 PM Changeset in webkit [150552] by
-
- 2 edits1 add in trunk/LayoutTests
Mac test expectation corrections after r150545.
- platform/mac-lion/http/tests/multipart/policy-ignore-crash-expected.txt: Added.
- platform/mac/TestExpectations:
- 3:53 PM Changeset in webkit [150551] by
-
- 4 edits in trunk/LayoutTests
More Mac test expectation cleanups.
- http/tests/inspector/network/network-size-sync-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/webarchive/loading/mainresource-null-mimetype-crash-expected.txt:
- 3:27 PM Changeset in webkit [150550] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150495. <rdar://problem/13915556>
- 3:24 PM Changeset in webkit [150549] by
-
- 1 edit2 copies in branches/safari-537.43-branch/LayoutTests
Merged r150492. <rdar://problem/13921879>
- 3:23 PM Changeset in webkit [150548] by
-
- 6 edits2 deletes in branches/safari-537.43-branch
Merged r150490. <rdar://problem/13921879>
- 3:19 PM Changeset in webkit [150547] by
-
- 2 edits in trunk/Source/WebCore
Fix assertion in the getComputedStyle-background-shorthand.html test
https://bugs.webkit.org/show_bug.cgi?id=116639
Reviewed by Ryosuke Niwa.
getComputedStyle-background-shorthand.html was asserting under the newly added
code in willBeRemovedFromTree(). The assertion was caused by too many calls to
FrameView::removeSlowRepaintObject(), which happened because we called it for
RenderTexts, which share style with their parent renderer.
RenderText overrides styleWillChange() to do nothing, so we never
call add/removeSlowRepaintObject() for them. Thus we should also skip this
work in willBeRemovedFromTree() for RenderTexts.
- rendering/RenderObject.cpp:
(WebCore::RenderObject::willBeRemovedFromTree):
- 3:18 PM Changeset in webkit [150546] by
-
- 4 edits in trunk/LayoutTests
REGRESSION: fast/files/workers tests crash
https://bugs.webkit.org/show_bug.cgi?id=45575
Unskip the test since they no longer crash. Also rebaseline two tests as needed.
- fast/files/workers/worker-read-blob-async-expected.txt:
- fast/files/workers/worker-read-blob-sync-expected.txt:
- platform/mac/TestExpectations:
- 3:11 PM Changeset in webkit [150545] by
-
- 4 edits1 copy3 adds in trunk/LayoutTests
Mac test expectation cleanups. Unskip a bunch of tests and rebaseline them as needed.
- accessibility/aria-menubar-menuitems-expected.txt: Added.
- fast/replaced/border-radius-clip-expected.png:
- platform/mac/TestExpectations:
- platform/mac/fast/replaced/border-radius-clip-expected.txt:
- platform/mac/http/tests/multipart/policy-ignore-crash-expected.txt: Copied from LayoutTests/http/tests/multipart/policy-ignore-crash-expected.txt.
- platform/mac/media/video-volume-slider-expected.png: Added.
- platform/mac/media/video-volume-slider-expected.txt: Added.
- 3:08 PM Changeset in webkit [150544] by
-
- 3 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::RenderLayerModelObject::hasSelfPaintingLayer
https://bugs.webkit.org/show_bug.cgi?id=116626
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-22
Reviewed by David Hyatt.
This is a port of a Blink bug fix by Emil Eklund.
Account for saturated estimated position in RenderBlock::layoutBlockChild.
If the estimated top position is saturated the comparison with oldLogicalTop
might yield a false negative as adding and removing margins, borders etc from
a saturated number might yield incorrect results. If this is the case always
mark for layout.
Minimal test case impractical. See bug for raw fuzzer test case.
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::mightBeSaturated): Add helper method for checking whether
a number might be saturated.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlockChild): Check if logicalTopEstimate is likely
to be saturated and if so mark for layout.
- 2:25 PM Changeset in webkit [150543] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when closing a page that's trying to access session storage
https://bugs.webkit.org/show_bug.cgi?id=116634
<rdar://problem/13904054>
Reviewed by Geoffrey Garen.
It is possible for the StorageManager to get messages from a web page that has already been closed by the UI process.
If that happens, just ignore the messages.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::getValues):
(WebKit::StorageManager::setItem):
(WebKit::StorageManager::removeItem):
(WebKit::StorageManager::clear):
(WebKit::StorageManager::destroySessionStorageNamespaceInternal):
- 2:22 PM Changeset in webkit [150542] by
-
- 1 edit24 adds20 deletes in trunk/LayoutTests
[CSS Exclusions] property parsing tests should be revised
https://bugs.webkit.org/show_bug.cgi?id=116446
Reviewed by Alexandru Chiculita.
This is just a cleanup of the existing parsing tests. None of the tests have effectively
changed. The cleaned-up version should be simpler, more regular, and shorter:
- Moved all of parsing tests into a fast/exclusions/parsing subdirectory.
- Remove the obsolete "wrap-" prefix from file names.
- Eiminated excessive and needless stringification in many of the test functions.
- Moved common code into parsing-test-utils.js and refactored redundant code.
- fast/exclusions/parsing-wrap-shape-inside-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-inside.html: Removed.
- fast/exclusions/parsing-wrap-shape-lengths-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-lengths.html: Removed.
- fast/exclusions/parsing-wrap-shape-outside-expected.txt: Removed.
- fast/exclusions/parsing-wrap-shape-outside.html: Removed.
- fast/exclusions/parsing/parsing-shape-inside-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-inside.html: Added.
- fast/exclusions/parsing/parsing-shape-lengths-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-lengths.html: Added.
- fast/exclusions/parsing/parsing-shape-margin-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-margin.html: Added.
- fast/exclusions/parsing/parsing-shape-outside-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-outside.html: Added.
- fast/exclusions/parsing/parsing-shape-padding-expected.txt: Added.
- fast/exclusions/parsing/parsing-shape-padding.html: Added.
- fast/exclusions/parsing/parsing-wrap-flow-expected.txt: Added.
- fast/exclusions/parsing/parsing-wrap-flow.html: Added.
- fast/exclusions/parsing/parsing-wrap-through-expected.txt: Added.
- fast/exclusions/parsing/parsing-wrap-through.html: Added.
- fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Added.
(string_appeared_here):
- fast/exclusions/parsing/script-tests/parsing-shape-lengths.js: Added.
(getStyleValue):
(testStyleValue):
(testComputedStyleValue):
(testInvalidValue):
- fast/exclusions/parsing/script-tests/parsing-shape-margin.js: Added.
(testShapeSpecifiedProperty):
- fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Added.
(testShapePropertyParsingFailure):
- fast/exclusions/parsing/script-tests/parsing-shape-padding.js: Added.
(testShapeSpecifiedProperty):
- fast/exclusions/parsing/script-tests/parsing-test-utils.js: Added.
(getCSSText):
(getComputedStyleValue):
(getParentAndChildComputedStyles):
(getParentAndChildComputedStylesString):
(getChildComputedStyle):
(testShapeSpecifiedProperty):
(testShapeComputedProperty):
(testNotInheritedShapeChildProperty):
- fast/exclusions/parsing/script-tests/parsing-wrap-flow.js: Added.
- fast/exclusions/parsing/script-tests/parsing-wrap-through.js: Added.
- fast/exclusions/shape-margin-parsing-expected.txt: Removed.
- fast/exclusions/shape-margin-parsing.html: Removed.
- fast/exclusions/shape-padding-parsing-expected.txt: Removed.
- fast/exclusions/shape-padding-parsing.html: Removed.
- fast/exclusions/wrap-flow-parsing-expected.txt: Removed.
- fast/exclusions/wrap-flow-parsing.html: Removed.
- fast/exclusions/wrap-through-parsing-expected.txt: Removed.
- fast/exclusions/wrap-through-parsing.html: Removed.
- 1:58 PM Changeset in webkit [150541] by
-
- 2 edits in branches/safari-537.43-branch/Source/WebKit2
Merged r150486. <rdar://problem/13822856>
- 1:55 PM Changeset in webkit [150540] by
-
- 33 edits1 copy in branches/safari-537.43-branch/Source/WebKit2
Merged r150484. <rdar://problem/13822856>
- 1:52 PM Changeset in webkit [150539] by
-
- 4 edits in trunk/Source/WebCore
Remove CSSPropertySourceData emptyCSSPropertySourceData
https://bugs.webkit.org/show_bug.cgi?id=116517
Reviewed by Darin Adler.
This was added for chromium and does not seem to be used
anywhere anymore.
- css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
- css/CSSPropertySourceData.cpp:
- css/CSSPropertySourceData.h:
- 1:52 PM Changeset in webkit [150538] by
-
- 4 edits in branches/safari-537.43-branch/Source
Versioning.
- 1:50 PM Changeset in webkit [150537] by
-
- 6 edits in trunk/Source/WebKit2
Crashes in NetworkProcess due to incorrect private browsing session tracking
https://bugs.webkit.org/show_bug.cgi?id=116628
Reviewed by Brady Eidson.
The current API for private browsing makes it extremely difficult to track sessions.
Private browsing is enabled via WKPreferences, but the session is shared, so it
has to be maintained while there is any chance that any page group anywhere still
needs it.
This patch fixes some of the issues, but ultimately, I think that we'll just need
to deprecate and replace the API.
- NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::storageSession): There are valid scenarios where privateBrowsingEnabled is true, but there is no private browsing session. Handle that without crashing, although this unfortunately means that it will be harder to spot logic errors when using a wrong session. (WebKit::NetworkConnectionToWebProcess::registerBlobURL): Removed an obsolete FIXME.
- NetworkProcess/mac/RemoteNetworkingContext.h: Changed privateBrowsingSession() to return a pointer, as no caller could know when it was safe to call it.
- NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::RemoteNetworkingContext::storageSession): Handle the case where private browsing session is unexpectedly missing without crashing. (WebKit::RemoteNetworkingContext::privateBrowsingSession): Changed to return a pointer.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess): Actually initialize privateBrowsingEnabled creation parameter. It would be very difficult to figure out 100% reliably whether NetworkProcess needs a private browsing session with the current API, but for existing clients, looking at m_privateBrowsingEnterCount is good enough. Certainly better than not initializing.
- WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::InjectedBundle::setPrivateBrowsingEnabled): Added a FIXME.
- 1:42 PM Changeset in webkit [150536] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: It should be possible to use more than one compiler thread
https://bugs.webkit.org/show_bug.cgi?id=116630
Reviewed by Mark Hahnenberg.
This gives us the ability to use more compiler threads, but doesn't actually
enable the functionality because it isn't a speed-up on any benchmark. It can
even be a slow-down. This also adds the ability to disable concurrent
compilation if we're on a uniprocessor machine, and adds more logging to the
worklist code to allow us to investigate how many threads are active. It
appears that even on the most compiler-heavy benchmarks, we never have enough
work for more than 4 threads, and even then the 4 threads are all active for
a short time.
Something that having more threads does accomplish is that it shakes out bugs.
This patch fixes a bug with Watchpoint not being thread-safe ref-counted,
which enabling 7 compilation threads did catch.
As it stands, this patch is performance-neutral and just fixes bugs and adds
some options.
- bytecode/Watchpoint.h:
- dfg/DFGCommon.h:
(JSC::DFG::enableConcurrentJIT):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::Worklist):
(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::create):
(JSC::DFG::Worklist::enqueue):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::dump):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::initializeGlobalWorklistOnce):
- dfg/DFGWorklist.h:
- runtime/Options.cpp:
(JSC::computeNumberOfWorkerThreads):
(JSC):
(JSC::computeNumberOfGCMarkers):
- runtime/Options.h:
(JSC):
- 1:30 PM Changeset in webkit [150535] by
-
- 2 edits in trunk/Source/WebCore
Buildfix for !ENABLE(FULLSCREEN_API) platforms.
Rubber-stamped by Ryosuke Niwa.
- rendering/RenderInline.cpp: Missing #if guard added.
(WebCore::RenderInline::splitInlines):
- 1:11 PM Changeset in webkit [150534] by
-
- 2 edits in trunk/Source/WebCore
Fix a typo in 150469.
- editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
- 1:09 PM Changeset in webkit [150533] by
-
- 20 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL shouldn't use the LLVM global context, and should instead create its own context for each compilation
https://bugs.webkit.org/show_bug.cgi?id=116631
Reviewed by Mark Hahnenberg.
In the future we might want to share contexts for multiple compilations, but for
now using one context per compilation is a progression over just constantly using
the global context.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(DFG):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
- ftl/FTLAbbreviatedTypes.h:
(FTL):
- ftl/FTLAbbreviations.h:
(JSC::FTL::voidType):
(JSC::FTL::int1Type):
(JSC::FTL::int8Type):
(JSC::FTL::int32Type):
(JSC::FTL::int64Type):
(JSC::FTL::intPtrType):
(JSC::FTL::doubleType):
(JSC::FTL::structType):
(JSC::FTL::mdKindID):
(JSC::FTL::mdString):
(JSC::FTL::mdNode):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::AbstractHeap::tbaaMetadataSlow):
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
(JSC::FTL::NumberedAbstractHeap::NumberedAbstractHeap):
(JSC::FTL::AbsoluteAbstractHeap::AbsoluteAbstractHeap):
- ftl/FTLAbstractHeap.h:
(IndexedAbstractHeap):
(NumberedAbstractHeap):
(AbsoluteAbstractHeap):
- ftl/FTLAbstractHeapRepository.cpp:
(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):
- ftl/FTLAbstractHeapRepository.h:
(AbstractHeapRepository):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
- ftl/FTLIntrinsicRepository.cpp:
(JSC::FTL::IntrinsicRepository::IntrinsicRepository):
- ftl/FTLIntrinsicRepository.h:
(FTL):
(IntrinsicRepository):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::Output):
- ftl/FTLOutput.h:
(Output):
(JSC::FTL::Output::newBlock):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
(JSC::FTL::State::~State):
(FTL):
- ftl/FTLState.h:
(State):
- runtime/Options.h:
(JSC):
- 12:48 PM Changeset in webkit [150532] by
-
- 3 edits in trunk/Source/WebKit2
[wk2] Should be able to make tiled WKViews clip to the view's exposed rect without using autolayout
https://bugs.webkit.org/show_bug.cgi?id=116625
<rdar://problem/13962816>
Reviewed by Anders Carlsson.
The two modes are not dependent; it should be possible to enable
clips-to-exposed-rect without using autolayout. This enables apps to
make very large tiled WKViews that don't create tiles for the whole
area of the view (and also disables scrolling, since that is currently
incompatible with clipping to the exposed rect).
- UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView forceAsyncDrawingAreaSizeUpdate:]):
Rename _expandsToFitContentViaAutoLayout to _clipsToVisibleRect for accuracy.
(-[WKView setMinimumWidthForAutoLayout:]):
Factor clips-to-sisible-rect toggle out into setShouldClipToVisibleRect.
(-[WKView shouldClipToVisibleRect]):
(-[WKView setShouldClipToVisibleRect:]):
Allow setting clips-to-visible-rect without autolayout.
- UIProcess/API/mac/WKViewPrivate.h:
Add shouldClipToVisibleRect property.
- 12:21 PM Changeset in webkit [150531] by
-
- 3 edits2 adds in trunk
REGRESSION: ASSERTION FAILED: obj->isRenderInline() obj == this, Bad cast in WebCore::RenderBlock::createLineBoxes https://bugs.webkit.org/show_bug.cgi?id=110622
Reviewed by David Hyatt.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/998ad358eed702b873dd54697b3fa3f952e0feb7
Inserting an element before the fullscreened element could crash if it caused a containing inline to be split,
since the splitting logic doesn't expect the fullscreened element to be wrapped in a RenderFullScreen. This patch changes
inline splitting to be aware of RenderFullScreen.
Test: fullscreen/full-screen-inline-split-crash.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):
LayoutTests:
Add a regression test.
- fullscreen/full-screen-inline-split-crash-expected.txt: Added.
- fullscreen/full-screen-inline-split-crash.html: Added.
- 12:06 PM Changeset in webkit [150530] by
-
- 5 edits in trunk/Source
Fix issues with focus rings on search fields
https://bugs.webkit.org/show_bug.cgi?id=116591
Source/WebCore:
Reviewed by Darin Adler.
On a future OS, the rect returned by _focusRingVisibleRect should
be in the coordinate system of the that NSView, not the base
coordinate system, so fix the code that sets and reads the global
focusRingClipRect variable accordingly.
- platform/graphics/mac/WebLayer.mm:
(drawLayerContents):
- platform/mac/ThemeMac.mm:
(-[WebCoreFlippedView _focusRingVisibleRect]):
Source/WebKit/mac:
Reviewed by Darin Adler.
In WebKit1, focus rings didn't render correctly on some OSes until
some other control drew a focus ring, which changes internal AppKit state
on the focused view. Fix by overriding an internal AppKit method to always
disable AppKit's "automatic" focus ring drawing.
- WebView/WebHTMLView.mm:
(-[WebHTMLView _automaticFocusRingDisabled]):
- 12:06 PM Changeset in webkit [150529] by
-
- 3 edits6 adds in trunk
New Flickr doesn't get fast scrolling but should
https://bugs.webkit.org/show_bug.cgi?id=116514
Source/WebCore:
Reviewed by Darin Adler.
RenderObject increments and decrements a counter of slow repaint objects on
FrameView when it sees style changes related to background-attachment:fixed.
However, it omitted to decrement the count when a renderer with a fixed background
was destroyed.
This caused Flickr to never fall into fast scrolling mode, since it toggled
display:none on an element with a fixed background during loading, then removed
the fixed background.
Did some minor cleanup of #ENABLE(FAST_MOBILE_SCROLLING) crap.
Tests: platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html
platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html
platform/mac-wk2/tiled-drawing/slow-scrolling.html
- rendering/RenderObject.cpp:
(WebCore::shouldRepaintFixedBackgroundsOnScroll):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::willBeRemovedFromTree):
LayoutTests:
Reviewed by Darin Adler.
slow-scrolling-hidden-background-toggle.html actually tests this patch. The other
two tests were added because there appear to be no tests for basic internals.mainThreadScrollingReasons()
functionality.
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-background-toggle.html: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling-hidden-background-toggle.html: Added.
- platform/mac-wk2/tiled-drawing/slow-scrolling.html: Added.
- 12:01 PM Changeset in webkit [150528] by
-
- 1 copy in branches/safari-537.43-branch
New Branch.
- 11:59 AM Changeset in webkit [150527] by
-
- 9 edits2 adds in trunk
Need to Remove Anonymous Wrappers When All Children Become Inline
https://bugs.webkit.org/show_bug.cgi?id=115687
Reviewed by David Hyatt.
Source/WebCore:
Remove a simple subset of anonymous wrappers, i.e. anonymous blocks without continuations,
when a block becoming float or positioned removes the need for them.
Test: fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html
- rendering/RenderBlock.h:
(RenderBlock):
- rendering/RenderObject.cpp:
(WebCore):
(WebCore::RenderObject::removeAnonymousWrappersFromLineIfNecessary):
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::styleDidChange):
- rendering/RenderObject.h:
(RenderObject):
LayoutTests:
- fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned-expected.txt: Added.
- fast/block/remove-anonymous-wrappers-when-element-changes-to-float-or-positioned.html: Added.
- platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
- platform/qt/fast/dynamic/002-expected.txt:
- 11:47 AM Changeset in webkit [150526] by
-
- 3 edits in branches/dfgFourthTier/WebKitLibraries
Updated LLVM drops to include MCJIT memory management APIs.
Rubber stamped by Mark Hahnenberg.
- LLVMIncludesMountainLion.tar.bz2:
- LLVMLibrariesMountainLion.tar.bz2:
- 11:38 AM Changeset in webkit [150525] by
-
- 18 edits in trunk/Source/WebCore
[css] Update ETextDecorations enum to TextDecorations
https://bugs.webkit.org/show_bug.cgi?id=116581
Reviewed by Andreas Kling.
Currently, ETextDecorations enum uses a C-like coding style for its
enumeration values, as well as a 'E' prefix that surely had some meaning
in the past, but not nowadays.
No behavior changes, covered by existing tests.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::hasPlainText):
(WebCore::AccessibilityRenderObject::hasUnderline):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(AXAttributeStringSetStyle):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetStyle):
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::renderTextDecorationFlagsToCSSValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator TextDecoration):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyTextDecoration::createHandler):
- editing/mac/EditorMac.mm:
(WebCore::Editor::fontAttributesForSelectionStart):
- platform/mac/HTMLConverter.mm:
(+[WebHTMLConverter editingAttributedStringFromRange:]):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
- rendering/InlineTextBox.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
(WebCore::operator|):
(WebCore::operator|=):
- rendering/style/StyleVisualData.h:
(StyleVisualData):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paint):
(WebCore::positionOffsetForDecoration):
(WebCore::thicknessForDecoration):
(WebCore::findRenderObjectDefininingTextDecoration):
(WebCore::SVGInlineTextBox::paintDecoration):
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
- rendering/svg/SVGInlineTextBox.h:
- 11:30 AM Changeset in webkit [150524] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Allow multiple log levels in media player
https://bugs.webkit.org/show_bug.cgi?id=116618
Patch by Lori Anderson <lori@rkymtnhi.com> on 2013-05-22
Reviewed by Philippe Normand.
No new tests, just changing logging.
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- 11:23 AM WebKit Team edited by
- added self (diff)
- 11:13 AM Changeset in webkit [150523] by
-
- 2 edits in trunk/Tools
Unreviewed. Added myself to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
Added myself.
- 11:06 AM Changeset in webkit [150522] by
-
- 2 edits in trunk/Source/WebCore
The LayoutMilestones didLayout callback sometimes fires with a milestone value of 0
https://bugs.webkit.org/show_bug.cgi?id=116623
Reviewed by Geoffrey Garen.
Make sure we have actually achieved some milestones before calling didLayout().
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- 10:09 AM Changeset in webkit [150521] by
-
- 10 edits in trunk/Source/WebKit2
Remove unused private browsing override support
<rdar://problem/11969491>
Rubber-stamped by Sam Weinig.
Private browsing override is unused, and it complicates tracking of private
browsing sessions in UI process (in fact, it doesn't plug into this tracking at all,
so we would just assert if we used the API).
- 10:01 AM Changeset in webkit [150520] by
-
- 9 edits in branches/dfgFourthTier/Source/JavaScriptCore
FTL should force LLVM to use our own JIT memory allocator, and we shouldn't have to keep around an LLVMExecutionEngineRef to keep code alive
https://bugs.webkit.org/show_bug.cgi?id=113619
Reviewed by Geoffrey Garen.
This uses new API that I've exposed, which allows for memory manager callbacks
from within LLVM. LLVM may allocate multiple independent chunks of memory for
a module, and we track all of those in a Vector in FTL::JITCode.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateCodeSection):
(FTL):
(JSC::FTL::mmAllocateDataSection):
(JSC::FTL::mmApplyPermissions):
(JSC::FTL::mmDestroy):
(JSC::FTL::compile):
- ftl/FTLJITCode.cpp:
(JSC::FTL::JITCode::JITCode):
(JSC::FTL::JITCode::~JITCode):
(JSC::FTL::JITCode::addHandle):
(FTL):
(JSC::FTL::JITCode::initializeCode):
- ftl/FTLJITCode.h:
(JITCode):
(JSC::FTL::JITCode::handles):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::~JITFinalizer):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h:
(JSC::FTL::JITFinalizer::initializeEntrypointLinkBuffer):
(JITFinalizer):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
(State):
- 9:42 AM Changeset in webkit [150519] by
-
- 5 edits1 delete in trunk/Source/JavaScriptCore
[sh4] Remove MacroAssemblerSH4.cpp file.
https://bugs.webkit.org/show_bug.cgi?id=116596.
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-22
Reviewed by Geoffrey Garen.
Move linkCall and repatchCall implementations from MacroAssemblerSH4.cpp
to MacroAssemblerSH4.h and remove MacroAssemblerSH4.cpp, as it is done
for other architectures.
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/MacroAssemblerSH4.cpp: Removed.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::linkCall):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::repatchCall):
- 9:22 AM Changeset in webkit [150518] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Reimplement atk_text_get_text_*_offset for CHAR boundary
https://bugs.webkit.org/show_bug.cgi?id=114870
Reviewed by Martin Robinson.
Re-implement this functions without using GailTextUtil nor Pango.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): New function.
(webkitAccessibleTextGetTextForOffset): Call the new function for CHAR.
- 9:18 AM Changeset in webkit [150517] by
-
- 2 edits in trunk/LayoutTests
[Qt][WK2] Unreviewed gardening. Skipping failing printing tests after r150046.
https://bugs.webkit.org/show_bug.cgi?id=116617
- platform/qt-5.0-wk2/TestExpectations:
- 9:11 AM Changeset in webkit [150516] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Captions menu isn't internationalized, doesn't use rtl layout for rtl languages
https://bugs.webkit.org/show_bug.cgi?id=116605
Reviewed by Eric Carlson.
Ensure that rtl languages are properly recognized by the captions menu such that text
layout and alignment is natural.
- css/mediaControls.css:
(::-webkit-media-controls):
Remove the forced "direction: ltr" property which was forcing all layout to be
left-to-right.
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-closed-captions-track-list):
Remove the forced "text-align: left" property which was forcing all caption
titles to be left-aligned.
(video::-webkit-media-controls-closed-captions-track-list h3):
Use "-webkit-margin-start" instead of "padding-left" to position the heading
such that it adds the margin on the left for ltr languages and on the right
for rtl languages.
(video::-webkit-media-controls-closed-captions-track-list li):
Set "position: relative" such that the ::before pseudo-class can use "position: absolute"
to position itself relative to the caption title rather than the list element.
(video::-webkit-media-controls-closed-captions-track-list li.selected::before):
(video::-webkit-media-controls-closed-captions-track-list li.selected:hover::before):
Make the checkmarks a ::before pseudo-class rather than a background-image such that
we may control its positioning using the internationlization-friendly "-webkit-margin-start"
property.
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsContainerElement::create):
Set the "dir" attribute to "auto" such that rtl languages are correctly handled. This
means that the first string displayed within the captions container, currently the
"Subtitles" <h3> element, defines the direction for the whole container. It is therefore
crucial that this string is properly localized in rtl languages as falling back to
english would mean the entire caption container is using ltr.
- 7:16 AM Changeset in webkit [150515] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Add sub menus to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114728
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-22
Reviewed by Christophe Dumez.
Elementary Ctxpopup widget API does not provide support for submenu item.
To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
Elementary Menu widget.
- MiniBrowser/efl/main.c:
(_Browser_Window):
(on_window_resize):
(window_free):
(context_menu_item_selected_cb):
(context_menu_populate):
(on_context_menu_show):
(on_context_menu_hide):
(window_create):
- 7:15 AM Changeset in webkit [150514] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skip failing tests after r150065 and r150498.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt/TestExpectations:
- 6:45 AM Changeset in webkit [150513] by
-
- 2 edits in trunk/Source/WebCore
WebCore fails to compile with -Werror=maybe-uninitialized on GCC 4.8.0
https://bugs.webkit.org/show_bug.cgi?id=116340
Reviewed by Christophe Dumez.
No new tests, just a simple build fix.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem): Init frame variable.
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem): Init frame variable.
- 6:36 AM Changeset in webkit [150512] by
-
- 5 edits in trunk/LayoutTests
[CSSRegions] Remove platform-specific differences from offsetLeft/offsetTop tests
https://bugs.webkit.org/show_bug.cgi?id=116607
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-22
Reviewed by Antti Koivisto.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt:
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html:
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html:
- 5:49 AM Changeset in webkit [150511] by
-
- 2 edits in trunk/Tools
[EFL] Add command line option to MiniBrowser to set cookies policy.
https://bugs.webkit.org/show_bug.cgi?id=115028
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2013-05-22
Reviewed by Christophe Dumez.
Add command line option to MiniBrowser EFL to set cookies policy:
-p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
- MiniBrowser/efl/main.c:
(elm_main):
- 5:47 AM WebKitGTK/2.0.x edited by
- Proposed changes for 2.0.3 (diff)
- 5:20 AM Changeset in webkit [150510] by
-
- 1 edit1 add1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening, updating expected files after r150508.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt-5.0-wk2/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Removed.
- 5:04 AM Changeset in webkit [150509] by
-
- 15 edits in trunk/Source/WebCore
Have IDL interface names match their global constructor
https://bugs.webkit.org/show_bug.cgi?id=116520
Reviewed by Kentaro Hara.
Have IDL interface names match their global constructor name on DOMWindow.idl
using [InterfaceName] extended attribute. This affects in particular webkit
prefixed constructors. This is mandated by Web IDL specification:
http://dev.w3.org/2006/webapi/WebIDL/#es-interfaces
As a consequence, we can now get rid of [NoInterfaceObject] extended attribute
for those interfaces and have their global constructors automatically generated
by the bindings generator.
No new tests, no behavior change for layout tests.
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/speech/SpeechGrammar.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionError.idl:
- Modules/speech/SpeechRecognitionEvent.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/PannerNode.idl:
- dom/ShadowRoot.idl:
- page/DOMWindow.idl:
- 4:42 AM Changeset in webkit [150508] by
-
- 15 edits10 adds1 delete in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=26830
https://bugs.webkit.org/show_bug.cgi?id=99870
https://bugs.webkit.org/show_bug.cgi?id=108429
https://bugs.webkit.org/show_bug.cgi?id=23166
https://bugs.webkit.org/show_bug.cgi?id=98523
https://bugs.webkit.org/show_bug.cgi?id=110654
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Removed.
- platform/qt/TestExpectations:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.png:
- platform/qt/css2.1/20110323/replaced-elements-001-expected.txt:
- platform/qt/css3/flexbox/button-expected.png: Added.
- platform/qt/css3/flexbox/button-expected.txt: Added.
- platform/qt/fast/css/background-clip-radius-values-expected.png: Added.
- platform/qt/fast/css/background-clip-radius-values-expected.txt: Added.
- platform/qt/fast/images/repaint-subrect-grid-expected.txt: Added.
- platform/qt/fast/multicol/single-line-expected.png: Added.
- platform/qt/fast/multicol/single-line-expected.txt: Added.
- platform/qt/ietestcenter/css3/bordersbackgrounds/border-radius-clip-002-expected.png:
- platform/qt/svg/custom/foreign-object-skew-expected.txt:
- platform/qt/svg/custom/js-late-pattern-creation-expected.png:
- platform/qt/svg/custom/pattern-scaling-expected.png: Added.
- platform/qt/svg/custom/pattern-scaling-expected.txt: Added.
- platform/qt/svg/custom/pattern-skew-transformed-expected.png:
- platform/qt/svg/custom/pattern-skew-transformed-expected.txt: Added.
- platform/qt/svg/custom/pattern-with-transformation-expected.png:
- platform/qt/svg/custom/text-ctm-expected.png:
- platform/qt/svg/custom/text-ctm-expected.txt:
- platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
- platform/qt/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.png:
- platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
- 2:37 AM Changeset in webkit [150507] by
-
- 3 edits in trunk/Source/WebKit2
[EFL][WK2] Change Ewk_Context_Menu_Item's parent menu to raw pointer
https://bugs.webkit.org/show_bug.cgi?id=116549
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-22
Reviewed by Christophe Dumez.
A context menu item should have only a pointer to parent menu instead
of owning parent menu.
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem):
- 2:25 AM Changeset in webkit [150506] by
-
- 27 edits1 copy40 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Unskipping some tests.
https://bugs.webkit.org/show_bug.cgi?id=105437
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-22
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
- platform/qt/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-in2-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-scale-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-xChannelSelector-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-dom-yChannelSelector-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-in2-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-scale-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-xChannelSelector-prop-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEDisplacementMapElement-svgdom-yChannelSelector-prop-expected.txt: Added.
- platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.png: Copied from LayoutTests/platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png.
- platform/qt/svg/filters/feImage-animated-transform-on-target-rect-expected.txt: Added.
- platform/qt/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
- platform/qt/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
- platform/qt/svg/filters/feImage-late-indirect-update-expected.png:
- platform/qt/svg/filters/feImage-late-indirect-update-expected.txt: Added.
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.png:
- platform/qt/svg/filters/feImage-multiple-targets-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-position-expected.png:
- platform/qt/svg/filters/feImage-position-expected.txt: Added.
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.png:
- platform/qt/svg/filters/feImage-preserveAspectratio-expected.txt: Added.
- platform/qt/svg/filters/feImage-reference-invalidation-expected.png:
- platform/qt/svg/filters/feImage-reference-invalidation-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-expected.png:
- platform/qt/svg/filters/feImage-subregions-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.png:
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-expected.txt: Added.
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.png:
- platform/qt/svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-add-to-document-expected.png:
- platform/qt/svg/filters/feImage-target-add-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-2-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.png:
- platform/qt/svg/filters/feImage-target-attribute-change-with-use-indirection-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-changes-id-expected.png:
- platform/qt/svg/filters/feImage-target-changes-id-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-id-change-expected.png:
- platform/qt/svg/filters/feImage-target-id-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.png:
- platform/qt/svg/filters/feImage-target-inline-style-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-property-change-expected.png:
- platform/qt/svg/filters/feImage-target-property-change-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.png:
- platform/qt/svg/filters/feImage-target-reappend-to-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.png:
- platform/qt/svg/filters/feImage-target-remove-from-document-expected.txt: Added.
- platform/qt/svg/filters/feImage-target-style-change-expected.png:
- platform/qt/svg/filters/feImage-target-style-change-expected.txt: Added.
- 12:24 AM Changeset in webkit [150505] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112029
Unreviewed EFL gardening.
accessibility/label-for-control-hittest.html passes after r150439.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-22
- platform/efl-wk2/TestExpectations:
- 12:07 AM Changeset in webkit [150504] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed buildfix after r150484.
- UIProcess/Plugins/qt/PluginProcessProxyQt.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
May 21, 2013:
- 11:26 PM Changeset in webkit [150503] by
-
- 7 edits7 deletes in trunk
Source/WebCore: Update the background blending implementation to match the changes done
in the spec. This implies that background color blending is removed and
the background layers won't blend with the content behind the element
any more.
https://bugs.webkit.org/show_bug.cgi?id=116212
Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintFillLayers):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
LayoutTests: Updating element background blending to conform to the changes in the spec.
This implies that the background layers won't longer blend with the content
behind the element.
Removing the background color tests, as background color blending is no longer
a valid use case, also modified the current background image tests.
https://bugs.webkit.org/show_bug.cgi?id=116212
Patch by Mihai Tica <mitica@adobe.com> on 2013-05-21
Reviewed by Dean Jackson.
- css3/compositing/effect-background-blend-mode-color-expected.txt: Removed.
- css3/compositing/effect-background-blend-mode-color.html: Removed.
- css3/compositing/effect-background-blend-mode-color2-expected.txt: Removed.
- css3/compositing/effect-background-blend-mode-color2.html: Removed.
- css3/compositing/effect-background-blend-mode-stacking-expected.png: Removed.
- css3/compositing/effect-background-blend-mode-stacking.html:
- platform/mac/css3/compositing/effect-background-blend-mode-color-expected.png: Removed.
- platform/mac/css3/compositing/effect-background-blend-mode-color2-expected.png: Removed.
- platform/mac/css3/compositing/effect-background-blend-mode-expected.png:
- platform/mac/css3/compositing/effect-background-blend-mode-stacking-expected.png:
- 11:18 PM Changeset in webkit [150502] by
-
- 2 edits in trunk/LayoutTests
[EFL] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=116590
Unreviewed EFL gardening.
http/tests/websocket/tests/hybi/close-on-navigate-new-location.html was skipped in r150497.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-21
- platform/efl/TestExpectations: Remove duplicate entry.
- 11:09 PM Changeset in webkit [150501] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: [Mac] inspector/geolocation-error.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116592
Add a flaky test expectation.
- platform/mac/TestExpectations:
- 10:49 PM Changeset in webkit [150500] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r150491): WebKit2.CloseThenTerminate asserting below WebContext::disconnectProcess().
<http://webkit.org/b/116588>
Reviewed by Sam Weinig.
Do an early return from WebProcessProxy::requestTermination() if there is no child process
connection to terminate.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
- 8:07 PM Changeset in webkit [150499] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows, curl] WebDownloadCurl.cpp should not include SystemTime.h
https://bugs.webkit.org/show_bug.cgi?id=116584
Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-05-21
Reviewed by Brent Fulgham.
SystemTime header and implementation are no longer used and were removed
recently - http://trac.webkit.org/changeset/150216.
- WebDownloadCurl.cpp:
- 7:36 PM Changeset in webkit [150498] by
-
- 4 edits2 adds in trunk
Use-after-free in DOMSelection::containsNode
https://bugs.webkit.org/show_bug.cgi?id=116468
Reviewed by Andreas Kling.
Source/WebCore:
Retain the node pointer. Also bail out early if the node was not in the document
since Range::compareBoundaryPoints sets ec to WRONG_DOCUMENT_ERR otherwise.
Test: editing/selection/contains-node-crash.html
- page/DOMSelection.cpp:
(WebCore::DOMSelection::containsNode):
- page/DOMSelection.h:
(DOMSelection):
LayoutTests:
Add a regression test from https://chromium.googlesource.com/chromium/blink/+/40bb8089352b15dd034641b4c131111cd79b44f1.
- editing/selection/contains-node-crash-expected.txt: Added.
- editing/selection/contains-node-crash.html: Added.
- 7:35 PM Changeset in webkit [150497] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip a test which has problem related to ecore library.
- platform/efl/TestExpectations:
- 7:13 PM Changeset in webkit [150496] by
-
- 3 edits2 adds in trunk
Web Inspector: InspectorFrontendHost::loadResourceSynchronously() builds ASCII-only results
https://bugs.webkit.org/show_bug.cgi?id=116569
Merge: https://chromium.googlesource.com/chromium/blink/+/7f1cfecfe34f4dbc6ce1ef0250b13f2058128eeb
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-21
Reviewed by Timothy Hatcher.
Source/WebCore:
Test: inspector/load-resource-synchronously-utf8.html
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::loadResourceSynchronously):
LayoutTests:
- inspector/load-resource-synchronously-utf8-expected.txt: Added.
- inspector/load-resource-synchronously-utf8.html: Added.
- 7:13 PM Changeset in webkit [150495] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13915556> Sluggish scrolling in web content
Reviewed by Gavin Barraclough.
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::setProcessSuppressionEnabled): When process suppression is disabled, low latency is important.
- 6:47 PM Changeset in webkit [150494] by
-
- 3 edits in trunk/Source/WebKit2
Fix build break after r150484
Unreviewed, fix build break on EFL, GTK.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
- 5:25 PM Changeset in webkit [150493] by
-
- 2 edits in trunk/Tools
REGRESSION(r150369): WebKit2WillLoadTest tests are failing
https://bugs.webkit.org/show_bug.cgi?id=116585
Reviewed by Alexey Proskuryakov.
willLoadURLRequest and willLoadDataRequest require the API version 6.
- TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
- 5:07 PM Changeset in webkit [150492] by
-
- 1 edit2 adds in trunk/LayoutTests
Check in the test and result I forgot to 'git add' before committing r150490.
- http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Added.
- http/tests/security/cross-origin-session-storage-third-party-blocked.html: Added.
- 5:07 PM Changeset in webkit [150491] by
-
- 5 edits in trunk/Source/WebKit2
PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
<http://webkit.org/b/116464>
<rdar://problem/10103795>
Reviewed by Anders Carlsson.
Simplify the web process sacrifice ritual. Instead of murderizing the process when its last tab closes,
just shut down the CoreIPC connection from the UI process. The web process, upon noticing this,
will start a 10 second watchdog timer, and if it hasn't shut down by the time it fires, well, it'll shut down.
(WebKit::WebProcessProxy::removeWebPage):
When the last page is removed from a WebProcessProxy, disconnect the process so that it'll die off
eventually, even if the WebPage::Close message never gets properly handled.
- Shared/ChildProcessProxy.h:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::abortProcessLaunchIfNeeded):
Added a helper to abort any in-progress launch of a new web process. Otherwise we'll have a race
where the exiting web process may get re-used for a new tab.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::enableSuddenTermination):
(WebKit::WebProcessProxy::disableSuddenTermination):
Remove WebProcessProxy's sudden termination counter. The web process will do what it needs in
response to the WebPage::Close message. We still forward these calls to NSProcessInfo on Mac though.
- 5:03 PM Changeset in webkit [150490] by
-
- 6 edits2 deletes in trunk
Allow session storage for third-party origins even if third-party data access is blocked.
https://bugs.webkit.org/show_bug.cgi?id=116532
Reviewed by Anders Carlsson.
Source/WebCore:
In http://trac.webkit.org/changeset/149326 we relaxed our policy for
localStorage when third-party data blocking is enabled to create a
transient, session-scoped storage area for the third-party origin
instead of throwing an exception. Since this gives essentially the same
behavior as sessionStorage, we might as well also allow sessionStorage
for third-party origins.
Test: http/tests/security/cross-origin-session-storage-third-party-blocked.html
- WebCore.exp.in: Updated the symbol for
SecurityOrigin::canAccessStorage.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage): Called canAccessSessionStorage()
rather than canAccessLocalStorage().
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): Passed in an enum
indicating if access should be allowed from third-party origins.
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::canAccessSessionStorage): Called
canAccessStorage() with AlwaysAllowFromThirdParty.
(SecurityOrigin):
LayoutTests:
- http/tests/security/cross-origin-session-storage-third-party-blocked-expected.txt: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage-expected.txt.
- http/tests/security/cross-origin-session-storage-third-party-blocked.html: Renamed from LayoutTests/http/tests/security/cross-origin-session-storage.html.
- 4:53 PM Changeset in webkit [150489] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed speculative fix for test-bots.
Add export declaration for WTFInvokeCrashHook to avoid runtime
load error on test bots.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
- 4:34 PM Changeset in webkit [150488] by
-
- 2 edits in trunk/LayoutTests
Web Inspector: inspector/styles/import-pseudoclass-crash.html intermittently hits an assertion in HTMLLinkElement::startLoadingDynamicSheet
https://bugs.webkit.org/show_bug.cgi?id=116582
Add a flaky crash expectation.
- platform/mac/TestExpectations:
- 4:09 PM Changeset in webkit [150487] by
-
- 2 edits in trunk/LayoutTests
Update Mountain Lion test expectations per bug 116477.
- platform/mac/TestExpectations:
- 4:02 PM Changeset in webkit [150486] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Stop using lambdas :(
- 4:01 PM Changeset in webkit [150485] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Add missing #if guards on drag support methods
https://bugs.webkit.org/show_bug.cgi?id=116574
Reviewed by Christophe Dumez.
- platform/efl/PasteboardEfl.cpp:
(WebCore):
- 3:54 PM Changeset in webkit [150484] by
-
- 33 edits1 copy in trunk/Source/WebKit2
Provide an API to run sandboxed plug-ins outside of their sandbox
https://bugs.webkit.org/show_bug.cgi?id=116578
Reviewed by Andreas Kling.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add new overload.
- PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
(WebKit::PluginProcessMainDelegate::getExtraInitializationData):
Handle "disable-sandbox".
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::getExtraInitializationData):
Handle "disable-sandbox".
- PluginProcess/PluginProcess.h:
Move Type to PluginProcessAttributes and remove hash traits for type.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializePluginProcess):
Update for new type name.
(WebKit::PluginProcess::initializeSandbox):
Return early if the sandbox is disabled.
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
PluginInfoStore::policyForPlugin has been renamed to PluginInfoStore::defaultLoadPolicyForPlugin.
- Shared/Plugins/PluginModuleInfo.h:
Add PluginModuleLoadUnsandboxed.
- Shared/Plugins/PluginProcessAttributes.h: Added.
Add new header with various plug-in process attributes.
- Shared/Plugins/PluginProcessCreationParameters.h:
Change type enum.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
(WebKit::toPluginModuleLoadPolicy):
Handle the unsandboxed enum.
- UIProcess/API/C/WKPage.h:
Add kWKPluginLoadPolicyLoadUnsandboxed.
- UIProcess/Plugins/PluginInfoStore.h:
Rename policyForPlugin to defaultLoadPolicyForPlugin.
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::pluginProcessToken):
Add new helper function for getting a token given plug-in attributes.
(WebKit::PluginProcessManager::getPluginProcessConnection):
This now takes a pluginProcessToken.
(WebKit::PluginProcessManager::getSitesWithData):
Make sure to call pluginProcessToken.
(WebKit::PluginProcessManager::clearSiteData):
Ditto.
(WebKit::PluginProcessManager::getOrCreatePluginProcess):
This now takes a token.
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::create):
(WebKit::PluginProcessProxy::PluginProcessProxy):
Pass the PluginProcessAttributes as well as the plug-in process token.
(WebKit::PluginProcessProxy::getLaunchOptions):
Pass the plug-in process attributes to platformGetLaunchOptions.
(WebKit::PluginProcessProxy::didClose):
Pass the token to PluginProcessCrashed.
(WebKit::PluginProcessProxy::didFinishLaunching):
Update for type change.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
Rename policyForPlugin to defaultLoadPolicyForPlugin.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptions):
Set the "disable-sandbox" data if needed.
(WebKit::PluginProcessProxy::platformInitializePluginProcess):
(WebKit::PluginProcessProxy::openPluginPreferencePane):
Get the module info from m_pluginProcessAttributes.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
This now returns a token.
- UIProcess/WebPageProxy.messages.in:
FindPlugin now returns a token instead of the path.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getPluginProcessConnection):
Pass the token to the plug-in process manager.
- UIProcess/WebProcessProxy.messages.in:
This now takes a token.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::PluginProcessConnection):
This now takes a token.
- WebProcess/Plugins/PluginProcessConnection.h:
(WebKit::PluginProcessConnection::create):
(WebKit::PluginProcessConnection::pluginProcessToken):
Create this with a token instead of a path and process type.
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
This now takes a token.
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
Ditto.
- WebProcess/Plugins/PluginProcessConnectionManager.messages.in:
PluginProcessCrashed now takes a token.
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::create):
(WebKit::PluginProxy::PluginProxy):
These now take tokens.
(WebKit::PluginProxy::initialize):
Pass the token when getting the connection.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Get the token from the UI process and pass it to the PluginProxy.
(WebKit::WebPage::canPluginHandleResponse):
Update now that FindPlugin returns a token.
- 3:48 PM Changeset in webkit [150483] by
-
- 7 edits in trunk/Source/WebCore
Remove stub HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=116580
Reviewed by Andreas Kling.
Inherit DetailsContentElement and DetailsSummaryElement directly from InsertionPoint instead.
- html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
- html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
- html/shadow/HTMLContentElement.cpp:
(WebCore::HTMLContentElement::contentTagName):
- html/shadow/HTMLContentElement.h:
(WebCore::isHTMLContentElement):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::setResetStyleInheritance):
- html/shadow/InsertionPoint.h:
Also remove some leftover selector code.
(WebCore::InsertionPoint::insertionPointType):
- 3:20 PM Changeset in webkit [150482] by
-
- 2 edits in trunk/Source/WebCore
Robustify repaint of previous caret node when moving FrameSelection.
<http://webkit.org/b/116558>
Reviewed by Ryosuke Niwa.
As a follow-up to r150396, also repaint the caret rects if the previous node is contenteditable.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):
- 3:06 PM Changeset in webkit [150481] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r150469. We need to bail out here when DOM is mutated by an event listener such that
the split text nodes no longer exist right next to each other.
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- 2:38 PM Changeset in webkit [150480] by
-
- 7 edits in trunk/Source/WebCore
Remove ScopeContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=116576
Reviewed by Andreas Kling.
With maximum one ShadowRoot per Element this can be smashed into ContentDistributor.
- dom/ShadowRoot.cpp:
(WebCore):
- dom/ShadowRoot.h:
(WebCore):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore):
(WebCore::ContentDistributor::~ContentDistributor):
(WebCore::ContentDistributor::invalidateInsertionPointList):
(WebCore::ContentDistributor::ensureInsertionPointList):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
- html/shadow/ContentDistributor.h:
(WebCore):
(ContentDistributor):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
Simplify insertion point list invalidation.
- html/shadow/InsertionPoint.h:
- 2:28 PM Changeset in webkit [150479] by
-
- 2 edits in trunk/Tools
REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
https://bugs.webkit.org/show_bug.cgi?id=116516
Reviewed by Alexey Proskuryakov.
Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow): Match the ordering.
(resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
- 2:04 PM Changeset in webkit [150478] by
-
- 3 edits4 adds in trunk
[CSS Regions][CSS Exclusions] Multiple regions with shape-insides should respect positioned shapes and overflow
https://bugs.webkit.org/show_bug.cgi?id=115001
Reviewed by David Hyatt.
In r150375 I implemented the new overflow behavior for shape-inside on regions, but it covered only the simple cases
when you had only one region. This patch adds support for the new overflow behavior for multiple regions with multiple
positioned shape-insides and overflow.
Source/WebCore:
Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Cover cases when content flows into the next region, update the
line segments for the overflow.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): In flow thread case we don't want to adjust the height
in two places.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-multiple-shapes.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-multiple-shapes.html: Added.
- 2:00 PM Changeset in webkit [150477] by
-
- 2 edits in trunk/LayoutTests
[Windows] Reenable storage tests
https://bugs.webkit.org/show_bug.cgi?id=116559
Unreviewed update to TestExpectations:
- Storage features are present on Windows, so test them.
- Disable (for now) the four websql tests that fail.
- platform/win/TestExpectations:
- 1:52 PM Changeset in webkit [150476] by
-
- 3 edits1 delete in trunk/LayoutTests
Unreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap-to-lines-not-set.html
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Removed.
- 1:42 PM Changeset in webkit [150475] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r150425.
http://trac.webkit.org/changeset/150425
https://bugs.webkit.org/show_bug.cgi?id=116573
Not the right fix for WebKit2 (Requested by rniwa on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-21
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
- 1:38 PM Changeset in webkit [150474] by
-
- 6 edits in trunk/Tools
<rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
https://bugs.webkit.org/show_bug.cgi?id=116568
Reviewed by Anders Carlsson.
- WebKitTestRunner/WebNotificationProvider.cpp: (WTR::WebNotificationProvider::~WebNotificationProvider):
- WebKitTestRunner/WebNotificationProvider.h: When the provider is destroyed, it should no longer be registered with the manager.
- WebKitTestRunner/GeolocationProviderMock.cpp: (WTR::GeolocationProviderMock::~GeolocationProviderMock):
- WebKitTestRunner/GeolocationProviderMock.h: I wasn't seeing a crash here, but this code has the same issue as notification provider, so applying the same fix.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController): Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase destructor having fixed the above.
- 1:32 PM Changeset in webkit [150473] by
-
- 2 edits in trunk/LayoutTests
Update test expectations after r150472 for the bug 116125.
- platform/wk2/TestExpectations:
- 1:25 PM WebKitGTK/2.0.x edited by
- (diff)
- 1:21 PM Changeset in webkit [150472] by
-
- 5 edits in trunk
Unreviewed, rolling out r150386 and r150397.
http://trac.webkit.org/changeset/150386
http://trac.webkit.org/changeset/150397
https://bugs.webkit.org/show_bug.cgi?id=116572
Broke a test; Alex is going to try again later. (Requested by
thorton on #webkit).
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::pathSuitableForTestResult):
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
LayoutTests:
- platform/wk2/TestExpectations:
- 1:02 PM Changeset in webkit [150471] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Unreviewed gardening; rebaseline and re-enable media/track/track-cue-rendering-snap-to-lines-not-set.html
https://bugs.webkit.org/show_bug.cgi?id=116567
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Removed.
- 12:43 PM Changeset in webkit [150470] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL shouldn't use FastISel and Small code model should be turned off for now
https://bugs.webkit.org/show_bug.cgi?id=115998
Reviewed by Oliver Hunt.
This switches off FastISel and makes it possible to turn off Small code model.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
(JSC):
- 12:34 PM Changeset in webkit [150469] by
-
- 3 edits2 adds in trunk
dispatchEvent call can execute javascript and blow away endRoot from underneath
https://bugs.webkit.org/show_bug.cgi?id=116483
Source/WebCore:
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/798cba0af9b2aff21e475e2e08ea3ca5e97dfc2c.
Test: editing/undo/undo-after-event-edited.html
- editing/Editor.cpp:
(WebCore::dispatchEditableContentChangedEvents):
LayoutTests:
Reviewed by Andreas Kling.
Add a regression test.
- editing/undo/undo-after-event-edited-expected.txt: Added.
- editing/undo/undo-after-event-edited.html: Added.
- 12:32 PM Changeset in webkit [150468] by
-
- 2 edits in trunk/LayoutTests
media/track/track-cue-rendering-snap-to-lines-not-set.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116567
Add a failing test expectation to the test added in r150452.
Patch by Ryosuke Niwa <rniwa@webkit.org> on 2013-05-21
- platform/mac/TestExpectations:
- platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
- 12:28 PM Changeset in webkit [150467] by
-
- 2 edits1 add in trunk/LayoutTests
media/track/track-cue-rendering-snap-to-lines-not-set.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116567
Add a failing test expectation to the test added in r150452.
- platform/mac/TestExpectations:
- platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt: Added.
- 12:26 PM Changeset in webkit [150466] by
-
- 34 edits1 delete in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: should use ConcurrentJITLock[er] directly and not through typedef
https://bugs.webkit.org/show_bug.cgi?id=116561
Rubber stamped by Geoffrey Garen.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
- bytecode/ArrayProfile.h:
(ArrayProfile):
(JSC::ArrayProfile::expectedStructure):
(JSC::ArrayProfile::structureIsPolymorphic):
(JSC::ArrayProfile::hasDefiniteStructure):
(JSC::ArrayProfile::observedArrayModes):
(JSC::ArrayProfile::mayInterceptIndexedAccesses):
(JSC::ArrayProfile::mayStoreToHole):
(JSC::ArrayProfile::outOfBounds):
(JSC::ArrayProfile::usesOriginalArrayStructures):
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpValueProfiling):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(CodeBlock):
- bytecode/CodeBlockLock.h: Removed.
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
- bytecode/LazyOperandValueProfile.cpp:
(JSC::CompressedLazyOperandValueProfileHolder::computeUpdatedPredictions):
(JSC::CompressedLazyOperandValueProfileHolder::add):
(JSC::LazyOperandValueProfileParser::initialize):
(JSC::LazyOperandValueProfileParser::prediction):
- bytecode/LazyOperandValueProfile.h:
(CompressedLazyOperandValueProfileHolder):
(LazyOperandValueProfileParser):
- bytecode/MethodOfGettingAValueProfile.cpp:
(JSC::MethodOfGettingAValueProfile::getSpecFailBucket):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFor):
- bytecode/ResolveGlobalStatus.cpp:
(JSC::ResolveGlobalStatus::computeFor):
- bytecode/ValueProfile.h:
(JSC::ValueProfileBase::briefDescription):
(JSC::ValueProfileBase::computeUpdatedPrediction):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addVar):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
- dfg/DFGArrayMode.h:
(ArrayMode):
(JSC::DFG::ArrayMode::withProfile):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- jit/JITInlines.h:
(JSC::JIT::chooseArrayMode):
- jit/JITStubs.cpp:
(JSC::tryCachePutByID):
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::lazyLinkFor):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):
- profiler/ProfilerBytecodeSequence.cpp:
(JSC::Profiler::BytecodeSequence::BytecodeSequence):
- runtime/Executable.cpp:
(JSC::ProgramExecutable::addGlobalVar):
- runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):
- runtime/JSScope.cpp:
(JSC::JSScope::resolveContainingScopeInternal):
(JSC::JSScope::resolvePut):
- runtime/JSSegmentedVariableObject.cpp:
(JSC::JSSegmentedVariableObject::findRegisterIndex):
(JSC::JSSegmentedVariableObject::addRegisters):
- runtime/JSSegmentedVariableObject.h:
(JSSegmentedVariableObject):
- runtime/JSSymbolTableObject.cpp:
(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):
- runtime/JSSymbolTableObject.h:
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
- runtime/Structure.cpp:
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::takePropertyTableOrCloneIfPinned):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::putSpecificValue):
(JSC::Structure::remove):
(JSC::Structure::createPropertyMap):
- runtime/Structure.h:
(Structure):
- runtime/SymbolTable.h:
(SymbolTable):
(JSC::SymbolTable::find):
(JSC::SymbolTable::get):
(JSC::SymbolTable::inlineGet):
(JSC::SymbolTable::begin):
(JSC::SymbolTable::end):
(JSC::SymbolTable::size):
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
(JSC::SymbolTable::contains):
- 12:10 PM Changeset in webkit [150465] by
-
- 39 edits4 adds in branches/dfgFourthTier/Source
fourthTier: DFG should be able to run on a separate thread
https://bugs.webkit.org/show_bug.cgi?id=112839
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
This is the final bit of concurrent JITing. The idea is that there is a
single global worklist, and a single global thread, that does all
optimizing compilation. This is the DFG::Worklist. It contains a queue of
DFG::Plans, and a map from CodeBlock* (the baseline code block we're
trying to optimize) to DFG::Plan. If the DFGDriver tries to concurrently
compile something, it puts the Plan on the Worklist. The Worklist's
thread will compile that Plan eventually, and when it's done, it will
signal its completion by (1) notifying anyone waiting for the Worklist to
be done, and (2) forcing the CodeBlock::m_jitExecuteCounter to take slow
path. The next Baseline JIT cti_optimize call will then install all ready
(i.e. compiled) Plans for that VM. Note that (1) is only for the GC and
VM shutdown, which will want to ensure that there aren't any outstanding
async compilations before proceeding. They do so by simply waiting for
all of the plans for the current VM to complete. (2) is the actual way
that code typically gets installed.
This is all very racy by design. For example, just as we try to force the
execute counter to take slow path, the main thread may be setting the
execute counter to some other value. The main thread must set it to
another value because (a) JIT code is constantly incrementing the counter
in a racy way, (b) the cti_optimize slow path will set it to some
large-ish negative value to ensure that cti_optimize isn't called
repeatedly, and (c) OSR exits from previously jettisoned code blocks may
still want to reset the counter values. This "race" is made benign, by
ensuring that while there is an asynchronous compilation, we at worse set
the counter to optimizeAfterWarmUp and never to deferIndefinitely. Hence
if the race happens then the worst case is that we wait another ~1000
counts before installing the optimized code. Another defense is that if
any CodeBlock calls into cti_optimize, then it will check for all ready
plans for the VM - so even if a code block has to wait another ~1000
executions before it calls cti_optimize to do the installation, it may
actually end up being installed sooner because a different code block had
called cti_optimize, potentially for an unrelated reason.
Special care is taken to ensure that installing plans informs the GC
about the increased memory usage, but also ensures that we don't recurse
infinitely - since at start of GC we try to install outstanding plans.
This is done by introducing a new GC deferral mechanism (the DeferGC
block-scoped thingy), which will ensure that GCs don't happen in the
scope but are allowed to happen after. This still leaves the strange
corner case that cti_optimize may install outstanding plans, then GC, and
that GC may jettison the code block that was installed. This, and the
fact that the plan that we took slow path to install could have been a
failed or invalid compile, mean that we have to take special precautions
in cti_optimize.
This patch also fixes a number of small concurrency bugs that I found
when things started running. There are probably more of those bugs still
left to fix. This patch just fixes the ones I know about.
Concurrent compilation is right now only enabled on X86_64 Mac. We need
platforms that are sufficiently CAStastic so that we can do the various
memory fence and CAS tricks that make this safe. We also need a platform
that uses JSVALUE64. And we need pthread_once. So, that pretty much means
just X64_64 for now. Enabling Linux-64_64 should be a breeze, but I'll
leave that up to the Qt and GTK+ ports to do at their discretion.
This is a solid speed-up on SunSpider (8-9%) and V8Spider (16%), our two
main compile-time benchmarks. Most peculiarly, this also appears to
reduce measurement noise, rather than increasing it as you would have
expected. I don't understand that result but I like it anyway. On the
other hand, this is a slight (1%) slow-down on V8v7. I will continue to
investigate this but I think that the results are already good enough
that we should land this as-is. So far, it appears that the slow-down is
due to this breaking the don't-compile-inlineables heuristics. See
investigation in https://bugs.webkit.org/show_bug.cgi?id=116556 and the
bug https://bugs.webkit.org/show_bug.cgi?id=116557.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::finalizeUnconditionally):
(JSC::CodeBlock::resetStubInternal):
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::hasOptimizedReplacement):
(JSC::CodeBlock::optimizationThresholdScalingFactor):
(JSC::CodeBlock::checkIfOptimizationThresholdReached):
(JSC::CodeBlock::optimizeNextInvocation):
(JSC::CodeBlock::dontOptimizeAnytimeSoon):
(JSC::CodeBlock::optimizeAfterWarmUp):
(JSC::CodeBlock::optimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::forceOptimizationSlowPathConcurrently):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::updateAllArrayPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::jitCompile):
- bytecode/CodeBlockLock.h:
(JSC):
- bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::forceSlowPathConcurrently):
(JSC):
(JSC::ExecutionCounter::setThreshold):
- bytecode/ExecutionCounter.h:
(ExecutionCounter):
- debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getArrayMode):
(JSC::DFG::ByteCodeParser::getArrayModeAndEmitChecks):
- dfg/DFGCommon.h:
(JSC::DFG::enableConcurrentJIT):
(DFG):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOperations.cpp:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::key):
(DFG):
- dfg/DFGPlan.h:
(DFG):
(Plan):
- dfg/DFGWorklist.cpp: Added.
(DFG):
(JSC::DFG::Worklist::Worklist):
(JSC::DFG::Worklist::~Worklist):
(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::create):
(JSC::DFG::Worklist::enqueue):
(JSC::DFG::Worklist::compilationState):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::queueLength):
(JSC::DFG::Worklist::dump):
(JSC::DFG::Worklist::runThread):
(JSC::DFG::Worklist::threadFunction):
(JSC::DFG::initializeGlobalWorklistOnce):
(JSC::DFG::globalWorklist):
- dfg/DFGWorklist.h: Added.
(DFG):
(Worklist):
- heap/CopiedSpaceInlines.h:
(JSC::CopiedSpace::allocateBlock):
- heap/DeferGC.h: Added.
(JSC):
(DeferGC):
(JSC::DeferGC::DeferGC):
(JSC::DeferGC::~DeferGC):
- heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reportExtraMemoryCostSlowCase):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectIfNecessaryOrDefer):
(JSC):
(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
- heap/Heap.h:
(Heap):
(JSC::Heap::isCollecting):
(JSC):
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::allocateSlowCase):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- profiler/ProfilerBytecodes.h:
- runtime/ConcurrentJITLock.h: Added.
(JSC):
- runtime/ExecutionHarness.h:
(JSC::replaceWithDeferredOptimizedCode):
- runtime/JSSegmentedVariableObject.cpp:
(JSC::JSSegmentedVariableObject::findRegisterIndex):
(JSC::JSSegmentedVariableObject::addRegisters):
- runtime/JSSegmentedVariableObject.h:
(JSSegmentedVariableObject):
- runtime/Options.h:
(JSC):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::propertyTable):
- runtime/SymbolTable.h:
(SymbolTable):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::prepareToDiscardCode):
(JSC):
(JSC::VM::discardAllCode):
(JSC::VM::releaseExecutableMemory):
- runtime/VM.h:
(DFG):
(VM):
Source/WTF:
Reviewed by Geoffrey Garen.
- wtf/ByteSpinLock.h:
Make it non-copyable. We previously had bugs where we used ByteSpinLock as a locker.
Clearly that's bad.
- wtf/MetaAllocatorHandle.h:
Make it thread-safe ref-counted, since we may now be passing them between the
concurrent JIT thread and the main thread.
- wtf/Vector.h:
(WTF::Vector::takeLast):
I've wanted this method for ages, and now I finally added.
- 12:09 PM Changeset in webkit [150464] by
-
- 9 edits in trunk/Source/WebCore
Remove ContentDistribution
https://bugs.webkit.org/show_bug.cgi?id=116527
Reviewed by Andreas Kling.
Resolving distribution on traversal is simpler.
- WebCore.exp.in:
- dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseNode):
(WebCore::ComposedShadowTreeWalker::traverseDistributedNodes):
(WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
- html/HTMLDetailsElement.cpp:
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::distributeSelectionsTo):
- html/shadow/ContentDistributor.h:
- html/shadow/HTMLContentElement.idl:
Remove getDistributedNodes().
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::InsertionPoint):
(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore):
(WebCore::InsertionPoint::firstDistributed):
(WebCore::InsertionPoint::lastDistributed):
(WebCore::InsertionPoint::nextDistributedTo):
(WebCore::InsertionPoint::previousDistributedTo):
Rename for clarity.
- html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::hasDistribution):
(WebCore::InsertionPoint::setHasDistribution):
(WebCore::InsertionPoint::clearDistribution):
(WebCore::InsertionPoint::matchTypeFor):
(InsertionPoint):
- 12:03 PM Changeset in webkit [150463] by
-
- 2 edits in trunk/LayoutTests
[Windows] Workers are crashing tests.
https://bugs.webkit.org/show_bug.cgi?id=116560.
Unreviewed change to TestExpectations while investigating.
- platform/win/TestExpectations: Disable worker tests under Windows.
- 12:02 PM Changeset in webkit [150462] by
-
- 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json
Unreviewed. Add myself as committer in contributors.json.
- 11:59 AM Changeset in webkit [150461] by
-
- 2 edits in trunk/Tools
Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
- Scripts/webkitpy/tool/commands/suggestnominations.py:
(AbstractCommitLogCommand._recent_commit_messages):
- 11:49 AM Changeset in webkit [150460] by
-
- 10 edits3 adds in trunk
[GTK] [CMake] Add support for building WebKit2
https://bugs.webkit.org/show_bug.cgi?id=116372
Reviewed by Gustavo Noronha Silva.
.:
- Source/cmake/FindWebP.cmake: Added.
- Source/cmake/OptionsGTK.cmake: Turn on WebKit2 and the plugin process and also look
for WebP. These missing symbols were hidden up until now. ENABLE_TEXTURE_MAPPER was
also incorrect specified.
Source/WebCore:
- PlatformGTK.cmake: Add missing source files, include directories, and WebP properties.
Source/WebKit2:
- CMakeLists.txt: Add common directories to the common include list and remove UIProcess/PageViewportController.cpp
from the source list since it should only be compiled for WebKitEFL. Instead of taking explicit forwarding-header
dependencies accept a list of "tacked-on" dependencies for WebKit2. This allows GTK+ to specify its extra fake
installed header step.
- PlatformEfl.cmake: Remove common include directories and add UIProcess/PageViewportController.cpp to the source
list. Fix up forwarding header dependencies now.
- PlatformGTK.cmake: Added.
- config.h: First check whether this is a CMake build and then fall back to the autotools header.
Tools:
- CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
- MiniBrowser/gtk/CMakeLists.txt: Added.
- 11:41 AM Changeset in webkit [150459] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed test expectation change - skip failing tests.
https://bugs.webkit.org/show_bug.cgi?id=116564
- Skip a number of failing tests, and investigate the sources of the
problems. Progress will be tracked on the above bug.
- Correct a typo I made in r150382
- Remove skip entries from https://webkit.org/b/113908; these were
replaced with new tests added in https://webkit.org/b/113946.
- platform/win/TestExpectations:
- 11:21 AM Changeset in webkit [150458] by
-
- 3 edits in trunk/LayoutTests
[CSSRegions] Remove percentages from offsetLeft/offsetTop tests to avoid sub-pixel errors
https://bugs.webkit.org/show_bug.cgi?id=116544
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-21
Reviewed by Andreas Kling.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html:
- fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html:
- 11:15 AM Changeset in webkit [150457] by
-
- 3 edits in trunk/Tools
Revert r149635, it was too optimistic.
Rubber-stamped by Andreas Kling.
We are not at the point where we can always use more descriptive macros instead of PLATFORM()
- Scripts/webkitpy/style/checkers/cpp.py:
(check_invalid_increment):
(process_line):
(CppChecker):
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_plain_integral_bitfields):
- 11:07 AM WebKitGTK/2.0.x edited by
- (diff)
- 11:04 AM Changeset in webkit [150456] by
-
- 2 edits in branches/dfgFourthTier/Tools
fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
https://bugs.webkit.org/show_bug.cgi?id=116556
Reviewed by Oliver Hunt.
This adds three new capabilities:
- 'display' now accepts negative compilation indices, and allows specifying wildcard hashes combined with combination indices. Previously you could say 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The latter would display every compilation. This improves this so that you can say 'display *-<index>-<engine>'. It also makes it so that you can give a negative index, which allows you to say things like 'display blah--1-dfg', which displays just the last DFG compilation. Also you can say 'display *--1-dfg', which displays the last DFG compilation for each code block. I realize that this is kind of ugly, but gosh is it practical.
- You can now say 'sort hash', which will henceforth sort all of the output by code hash rather than by the time when it was compiled. This means that if you're doing 'dispay *--1-dfg' and then want to diff the results against something else, you can ensure that this doesn't get confused just by changes in compilation order.
- You can now say 'counts off', which will henceforth disable the display of execution counts from 'bytecode' and 'display'. This is also useful for diffs, since if you're trying to figure out why two compilations are different, they probably have radically different counts. 'counts off' gets this out of the output so that it doesn't confuse your diff.
Note that to use this effectively you should also have a script that scrubs
pointers from text so that the diff doesn't get confused by pointers. I'll
post my elimptr script to the bug. Maybe at some point I'll integrate that
into display-profiler-output.
Put together this is pretty awesome. I was able to do the following:
(echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
(echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
diff -u richards-serial.asm richards-concurrent.asm
And this immediately told me that the reason why richards is slower in the
concurrent compilation case is just that we end up compiling *tons* more
functions, most of which are trivially inlineable. Basically, concurrent
compilation breaks our previous heuristics for delaying compilation of
inlineables just enough that they never trigger compilation. We should fix
that in a separate bug.
- Scripts/display-profiler-output:
- 10:26 AM Changeset in webkit [150455] by
-
- 2 edits in trunk/Tools
Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
- lldb/lldb_webkit.py:
(WTFVectorProvider.num_children):
(WTFVectorProvider.get_child_index):
(WTFVectorProvider.get_child_at_index):
(WTFVectorProvider.update):
- 10:20 AM Changeset in webkit [150454] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r101810): Media controls status text missing for live-stream videos.
https://bugs.webkit.org/show_bug.cgi?id=116547
Reviewed by Eric Carlson.
Un-reverse the logic in loadedMetadata() so that the status text isn't
hidden (when it should be shown) for live-stream videos.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::loadedMetadata):
- 10:16 AM Changeset in webkit [150453] by
-
- 8 edits in trunk/Source/WebCore
Implement overlap-avoidance for in-band text track cues.
https://bugs.webkit.org/show_bug.cgi?id=116540
Reviewed by Eric Carlson.
In-band (or Generic) cues need special casing for certain features
present in in-band tracks, like paint-on and roll-up modes. To avoid
the problem of overlap avoidance forcing a caption meant to appear
below a cue to appear above it when a larger font size is selected,
impose an additional sort ordering for "generic cues". Instead of
cues being ordered by the order they appear in the track, "generic
cues" further sorted by their position within the video area, such
that cues at the bottom of the video area appear first, and later
cues are pushed up to avoid them, preserving the desired apparent
ordering.
- html/HTMLMediaElement.cpp:
(WebCore::compareCueInterval): Added; wrapper around
TextTrackCue::isOrderedBefore.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues):
After creating the list of current cues, sort them.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::isOrderedBefore): Added; implementation moved
from TextTrackCueList::add().
- html/track/TextTrackCue.h:
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGeneric::isOrderedBefore): Added override;
impose additional oredring on generic cues.
- html/track/TextTrackCueGeneric.h:
- html/track/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::add): Moved ordering test into
isOrderedBefore().
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::repositionGenericCue):
Call repositionCueSnapToLinesNotSet() after positioning the cue.
- 10:14 AM Changeset in webkit [150452] by
-
- 4 edits2 adds in trunk
Implement overlap avoidance for cues with snap-to-lines flag not set
https://bugs.webkit.org/show_bug.cgi?id=84296
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/track/track-cue-overlap-snap-to-lines-not-set.html
Support overlap avoidance for the non-snap-to-lines part of the WebVTT spec.
- rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): Split implementation into rectIsWithinContainer().
(WebCore::RenderTextTrackCue::rectIsWithinContainer): Ditto.
(WebCore::RenderTextTrackCue::isOverlapping): Split into overlappingObject() and overlappingObjectForRect().
(WebCore::RenderTextTrackCue::overlappingObject): Ditto.
(WebCore::RenderTextTrackCue::overlappingObjectForRect): Ditto.
(WebCore::RenderTextTrackCue::moveIfNecessaryToKeepWithinContainer): Added.
(WebCore::RenderTextTrackCue::findNonOverlappingPosition): When an overlapping object is found, move the
cue to just above or below that object and try again.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Move implementation into moveIfNecessaryToKeepWithinContainer().
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesNotSet): Add implementanton based on above.
- rendering/RenderTextTrackCue.h:
LayoutTests:
- media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt: Added.
- media/track/track-cue-overlap-snap-to-lines-not-set.html: Added.
- 9:57 AM Changeset in webkit [150451] by
-
- 2 edits in trunk/Source/WTF
Build fix.
- wtf/NeverDestroyed.h:
(NeverDestroyed):
- 9:56 AM Changeset in webkit [150450] by
-
- 10 edits1 add in trunk/Source/WTF
Add WTF::NeverDestroyed and start using it in WTF
https://bugs.webkit.org/show_bug.cgi?id=116472
Reviewed by Benjamin Poulain.
NeverDestroyed is a class template that can be used for singletons and other objects that we never
want to destroy. It's intended as a replacement for WTF_STATIC_LOCAL with the advantage that it doesn't
fragment the heap.
- GNUmakefile.list.am:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
Add NeverDestroyed.h
- wtf/Compiler.h:
Add a helper macro, WTF_DELETED_FUNCTION.
- wtf/CryptographicallyRandomNumber.cpp:
Use NeverDestroyed.
- wtf/NeverDestroyed.h: Added.
- wtf/Noncopyable.h:
Use WTF_DELETED_FUNCTION.
- wtf/text/WTFString.cpp:
(WTF::emptyString):
Use
- 9:44 AM Changeset in webkit [150449] by
-
- 2 edits in trunk/Source/JavaScriptCore
Added missing assert condition for PositiveOrZero in ARM branch32().
https://bugs.webkit.org/show_bug.cgi?id=116538.
Reviewed by Geoffrey Garen.
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchAdd32):
- 9:39 AM Changeset in webkit [150448] by
-
- 8 edits3 copies in tags/Safari-537.43
2013-05-21 Lucas Forschler <Lucas Forschler>
Merge r150441
2013-05-21 Jessie Berlin <jberlin@apple.com>
Expose a way to know when forms are added to a page or when form controls are added to a form
in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h: Add the new callbacks as part of version 2 of the WKBundlePageFormClient.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp: (WebKit::InjectedBundlePageFormClient::didAssociateFormControls): Pass the message along to the client if the client has a handler. (WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges): Ditto.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::didAssociateFormControls): Tell the injected bundle form client for the page. (WebKit::WebChromeClient::shouldNotifyOnFormChanges): Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
Add tests for the new callbacks.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added. (TestWebKitAPI::nullJavaScriptCallback): A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null being passed in for the callback. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): After receiving the message that didAssociateFormControls callback was invoked from adding the form in the onload handler, tell the page to add a password field to the form, which should also invoke didAssociateFormControls callback. (TestWebKitAPI::setInjectedBundleClient): Register to receive messages. (TestWebKitAPI::TEST): Load associate-form-controls.html and wait until the didAssociateFormControls callback has been invoked for both adding the form and for adding a password field to the form.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added. (TestWebKitAPI::shouldNotifyOnFormChanges): Return true so the didAssociateFormControls callback is invoked. (TestWebKitAPI::didAssociateFormControls): Tell the UI process. (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest): (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage): Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added. Add a form in response to the onload event. Add a button that will add the password field for manual testing.
- 9:21 AM Changeset in webkit [150447] by
-
- 4 edits in tags/Safari-537.43/Source
Versioning.
- 9:09 AM Changeset in webkit [150446] by
-
- 3 edits in trunk/Source/WebCore
Remove GraphicsLayerClient::contentsVisible()
https://bugs.webkit.org/show_bug.cgi?id=116523
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Darin Adler.
This is dead code from the BlackBerry port.
- platform/graphics/GraphicsLayerClient.h:
- rendering/RenderLayerBacking.cpp:
- 9:05 AM Changeset in webkit [150445] by
-
- 4 edits in trunk
[GTK] Compile everything in C++11 mode
https://bugs.webkit.org/show_bug.cgi?id=116452
Reviewed by Anders Carlsson.
.:
- Source/autotools/SetupCompilerFlags.m4: Use the C++11 standard by default when compiling C++ source code.
Perform some minor cleanup around the comments and the order of specifying additional CXXFLAGS entries.
Source/WebKit2:
- GNUmakefile.am: Remove the -std=c++11 flags from the various CPPFLAGS lists, the mode is now specified
by default for all the C++ source code in SetupCompilerFlags.m4.
- 9:03 AM Changeset in webkit [150444] by
-
- 2 edits in trunk/Source/WebCore
PLATFORM(*) macros used in Source/WebCore/loader/archive/ArchiveFactory.cpp
https://bugs.webkit.org/show_bug.cgi?id=116453
Reviewed by Alexey Proskuryakov.
- loader/archive/ArchiveFactory.cpp: Remove a redundant PLATFORM(QT) macro when checking whether
to include the LegacyWebArchive.h header that's specific to the WebArchive support. The Qt port
does not enable the WebArchive feature at all (which is enabled only on AppleMac, AppleWin and iOS
platforms) so there's no reason to additionally condition the header include with building on
non-Qt platforms.
- 8:58 AM Changeset in webkit [150443] by
-
- 2 edits in trunk/Source/WebCore
Add BlackBerry definition of NativeImagePtr
https://bugs.webkit.org/show_bug.cgi?id=116526
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Darin Adler.
- platform/graphics/NativeImagePtr.h:
(Graphics):
(WebCore):
- 8:50 AM Changeset in webkit [150442] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] FontCache::getFontDataForCharacters() returns nullptr
https://bugs.webkit.org/show_bug.cgi?id=116529
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Andreas Kling.
This cannot be converted to a PassRefPtr and breaks the build.
- platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::getFontDataForCharacters):
- 8:12 AM WebKitGTK/2.0.x edited by
- (diff)
- 6:44 AM Changeset in webkit [150441] by
-
- 8 edits3 adds in trunk
Expose a way to know when forms are added to a page or when form controls are added to a form
in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add the new callbacks as part of version 2 of the WKBundlePageFormClient.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
Pass the message along to the client if the client has a handler.
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAssociateFormControls):
Tell the injected bundle form client for the page.
(WebKit::WebChromeClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
Add tests for the new callbacks.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
(TestWebKitAPI::nullJavaScriptCallback):
A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
being passed in for the callback.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
After receiving the message that didAssociateFormControls callback was invoked from adding
the form in the onload handler, tell the page to add a password field to the form, which
should also invoke didAssociateFormControls callback.
(TestWebKitAPI::setInjectedBundleClient):
Register to receive messages.
(TestWebKitAPI::TEST):
Load associate-form-controls.html and wait until the didAssociateFormControls callback has
been invoked for both adding the form and for adding a password field to the form.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
(TestWebKitAPI::shouldNotifyOnFormChanges):
Return true so the didAssociateFormControls callback is invoked.
(TestWebKitAPI::didAssociateFormControls):
Tell the UI process.
(TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
(TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
Add a form in response to the onload event. Add a button that will add the password field
for manual testing.
- 6:37 AM Changeset in webkit [150440] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Always use EGL to create the GL context when running on Wayland
https://bugs.webkit.org/show_bug.cgi?id=115721
Patch by Iago Toral Quiroga <itoral@igalia.com> on 2013-05-21
Reviewed by Martin Robinson.
- platform/graphics/cairo/GLContext.cpp:
(WebCore::GLContext::createContextForWindow):
(WebCore::GLContext::createOffscreenContext): Always use EGL to create the GL context
instead of GLX when running on Wayland and make createOffScreenContext reuse the code
in createContextWindow.
- 6:16 AM Changeset in webkit [150439] by
-
- 4 edits in trunk
[GTK][WK2] accessibility/label-for-control-hittest.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106341
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21
Reviewed by Martin Robinson.
Tools:
Adds support for retrieving accessibility element at exact point.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::elementAtPoint):
LayoutTests:
Fixing failing test. The reason of failure is missing
possibility of getting accessibility object at exact position.
- platform/gtk-wk2/TestExpectations:
- 6:14 AM Changeset in webkit [150438] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/accessibility-node-reparent.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112026
Unreviewed EFL gardening.
accessibility/accessibility-node-reparent.html passes after r150431.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21
- platform/efl-wk2/TestExpectations:
- 5:50 AM Changeset in webkit [150437] by
-
- 2 edits in trunk/Source/WebCore
Add FloatRect::normalized() for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=116531
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-21
Reviewed by Carlos Garcia Campos.
This was added to FloatRectBlackBerry.cpp in r111072 when the
graphics platform code was upstreamed, but this change was
missing.
- platform/graphics/FloatRect.h:
(FloatRect):
- 5:21 AM Changeset in webkit [150436] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/accessibility-node-memory-management.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112025
Unreviewed EFL gardening
accessibility/accessibility-node-memory-management.html passes after r150431.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21
- platform/efl-wk2/TestExpectations:
- 4:35 AM Changeset in webkit [150435] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] cleanup duration query
https://bugs.webkit.org/show_bug.cgi?id=116228
Reviewed by Philippe Normand.
Covered by existing tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::duration):
We can also cache the duration here if the query succeeds.
(MediaPlayerPrivateGStreamer::updateStates):
Don't query when we are in GST_STATE_READY state because it never succeeds.
Do it instead when we reached a stable state.
(MediaPlayerPrivateGStreamer::cacheDuration): Return early if it is already
cached. Recaching is not necessary and now we call it a lot of times.
Only look into the state if the query failed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer): Made m_mediaDuration mutable to be
able to cache it in duration(). Internal cached values is one of
the sensible uses of mutable.
- 3:55 AM Changeset in webkit [150434] by
-
- 19 edits2 adds in trunk
[BlackBerry] Make PagePopup implementation independent from WebCore
https://bugs.webkit.org/show_bug.cgi?id=116448
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-21
Reviewed by Anders Carlsson.
.:
- Source/cmake/OptionsBlackBerry.cmake: Do not enable PAGE_POPUP
feature.
Source/WebKit:
- PlatformBlackBerry.cmake: Add
blackberry/WebCoreSupport/PagePopupBlackBerryClient.cpp to
compilation.
Source/WebKit/blackberry:
Add our own implementation of PagePopupClient and make all the
pickers inherit from it. Unused methods have been removed and
common implementation have been moved from the pickers to the
parent class.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate): Destroy the
popup if there's one active.
(BlackBerry::WebKit::WebPagePrivate::setVisible): Call
closePagePopup() directly.
(BlackBerry::WebKit::WebPagePrivate::openPagePopup): Create a new
PagePopupBlackBerry for the given client.
(BlackBerry::WebKit::WebPagePrivate::closePagePopup): Close the
active popup if there's one.
(BlackBerry::WebKit::WebPagePrivate::hasOpenedPopup): Return
whether there's an active popup.
- Api/WebPage.h:
- Api/WebPage_p.h:
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::chromeDestroyed): Remove
closePagePopup() call since this is now handled by
WebPagePrivate.
(WebCore::ChromeClientBlackBerry::hasOpenedPopup): Call
WebPagePrivate::hasOpenedPopup().
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/ColorPickerClient.cpp:
(BlackBerry::WebKit::ColorPickerClient::ColorPickerClient):
(BlackBerry::WebKit::ColorPickerClient::didClosePopup):
- WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
- WebCoreSupport/DatePickerClient.cpp:
(BlackBerry::WebKit::DatePickerClient::DatePickerClient):
(BlackBerry::WebKit::DatePickerClient::didClosePopup):
- WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
- WebCoreSupport/PagePopupBlackBerry.cpp:
(BlackBerry::WebKit::PagePopupBlackBerry::PagePopupBlackBerry):
(BlackBerry::WebKit::PagePopupBlackBerry::closePopup):
- WebCoreSupport/PagePopupBlackBerry.h:
(PagePopupBlackBerry):
(BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::SharedClientPointer):
(BlackBerry::WebKit::PagePopupBlackBerry::SharedClientPointer::get):
(SharedClientPointer):
- WebCoreSupport/PagePopupBlackBerryClient.cpp: Added.
(BlackBerry::WebKit::PagePopupBlackBerryClient::PagePopupBlackBerryClient):
(BlackBerry::WebKit::PagePopupBlackBerryClient::closePopup):
(BlackBerry::WebKit::PagePopupBlackBerryClient::didClosePopup):
(BlackBerry::WebKit::PagePopupBlackBerryClient::contentSize):
(BlackBerry::WebKit::PagePopupBlackBerryClient::writeDocument):
- WebCoreSupport/PagePopupBlackBerryClient.h: Added.
(PagePopupBlackBerryClient):
(BlackBerry::WebKit::PagePopupBlackBerryClient::~PagePopupBlackBerryClient):
- WebCoreSupport/SelectPopupClient.cpp:
(BlackBerry::WebKit::SelectPopupClient::SelectPopupClient):
(BlackBerry::WebKit::SelectPopupClient::didClosePopup):
- WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openDatePopup): Do not call
closePagePopup() since this is already done by openPagePopup() and
use openPagePopup() from WebPagePrivate directly.
(BlackBerry::WebKit::InputHandler::openColorPopup): Ditto.
(BlackBerry::WebKit::InputHandler::openSelectPopup): Ditto.
- 2:31 AM Changeset in webkit [150433] by
-
- 2 edits in trunk/Source/WebCore
Build fix for !USE(ACCELERATED_COMPOSITING) after r150307.
- rendering/RenderLayerCompositor.h: Added missing #if USE(ACCELERATED_COMPOSITING).
- 2:04 AM Changeset in webkit [150432] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][WK2] Fix Mountain Lion builds after r150277.
https://bugs.webkit.org/show_bug.cgi?id=116467
Reviewed by Jocelyn Turcotte.
- Shared/API/c/WKBase.h:
- 1:43 AM Changeset in webkit [150431] by
-
- 5 edits in trunk/Tools
[ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
https://bugs.webkit.org/show_bug.cgi?id=112913
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-05-21
Reviewed by Martin Robinson.
AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
so the leak appears.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
(WTR):
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::rootElement):
(WTR):
(WTR::AccessibilityController::focusedElement):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::checkElementState):
(WTR::indexRangeInTable):
(WTR::alterCurrentValue):
(WTR::AccessibilityUIElement::getChildren):
(WTR::AccessibilityUIElement::getChildrenWithRange):
(WTR::AccessibilityUIElement::childrenCount):
(WTR::AccessibilityUIElement::indexOfChild):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::x):
(WTR::AccessibilityUIElement::y):
(WTR::AccessibilityUIElement::width):
(WTR::AccessibilityUIElement::height):
(WTR::AccessibilityUIElement::intValue):
(WTR::AccessibilityUIElement::minValue):
(WTR::AccessibilityUIElement::maxValue):
(WTR::AccessibilityUIElement::isEnabled):
(WTR::AccessibilityUIElement::isFocused):
(WTR::AccessibilityUIElement::isSelected):
(WTR::AccessibilityUIElement::isExpanded):
(WTR::AccessibilityUIElement::isChecked):
(WTR::AccessibilityUIElement::rowCount):
(WTR::AccessibilityUIElement::columnCount):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::increment):
(WTR::AccessibilityUIElement::decrement):
(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::documentEncoding):
(WTR::AccessibilityUIElement::documentURI):
(WTR::AccessibilityUIElement::isFocusable):
(WTR::AccessibilityUIElement::isSelectable):
(WTR::AccessibilityUIElement::isMultiSelectable):
(WTR::AccessibilityUIElement::isVisible):
- 1:40 AM Changeset in webkit [150430] by
-
- 5 edits in trunk/Source/WebCore
Simplify Shadow DOM distribution code
https://bugs.webkit.org/show_bug.cgi?id=116454
Reviewed by Andreas Kling.
Remove code supporting nested insertion points and distributing to multiple insertion points.
- html/HTMLDetailsElement.cpp:
(DetailsContentElement):
Make distribution to <details> and <summary> mutually exclusive.
- html/shadow/ContentDistributor.cpp:
(WebCore):
(WebCore::ContentDistributor::distribute):
(WebCore::ContentDistributor::invalidate):
(WebCore::ContentDistributor::distributeSelectionsTo):
- html/shadow/ContentDistributor.h:
- html/shadow/InsertionPoint.cpp:
(WebCore::resolveReprojection):
- 1:07 AM Changeset in webkit [150429] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 1:06 AM Changeset in webkit [150428] by
-
- 1 delete in tags/Safari-537.43
- 1:02 AM Changeset in webkit [150427] by
-
- 2 edits in trunk/Source/WebCore
[CSSRegions] Constrain auto-height region computation in a different way
https://bugs.webkit.org/show_bug.cgi?id=116310
Reviewed by Alexandru Chiculita.
After https://bugs.webkit.org/show_bug.cgi?id=74132, the region is a render block. We can use RenderBox::constrainContentBoxLogicalHeightByMinMax
instead of RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight to better reflect the fact that the region is not a replaced element.
Covered by existing regions tests, since when replaced-based the region had an intrinsic height of 0 and now, block-based, it does not have any children.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addForcedRegionBreak):
- 12:48 AM Changeset in webkit [150426] by
-
- 2 edits in trunk/LayoutTests
[Mac] svg/batik/paints/patternRegions-positioned-objects.svg is flaky
https://bugs.webkit.org/show_bug.cgi?id=116519
Add a flaky test expectation.
- platform/mac/TestExpectations:
- 12:39 AM Changeset in webkit [150425] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
https://bugs.webkit.org/show_bug.cgi?id=116516
Reviewed by Antti Koivisto.
The bug was caused by DRT not resetting various auto correction states.
Do that in Internals::resetToConsistentState.
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
- 12:00 AM Changeset in webkit [150424] by
-
- 8 edits3 deletes in trunk
Source/WebKit2: Rollout r150398.
Tools: Rollout 150398.
May 20, 2013:
- 11:39 PM Changeset in webkit [150423] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 11:39 PM Changeset in webkit [150422] by
-
- 1 delete in tags/Safari-537.43
- 11:16 PM Changeset in webkit [150421] by
-
- 8 edits in trunk
[GTK] Fix concatenations of string literals that are not C++11-compliant
https://bugs.webkit.org/show_bug.cgi?id=116449
Reviewed by Martin Robinson.
Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
is simply a matter of separating the string and the string literal that are being concatenated with a space.
Source/WebCore:
- platform/graphics/gtk/FullscreenVideoControllerGtk.cpp:
- platform/gtk/FileSystemGtk.cpp:
(WebCore::sharedResourcesPath):
Source/WebKit2:
- UIProcess/API/gtk/tests/TestPrinting.cpp:
(testPrintOperationPrint):
- UIProcess/API/gtk/tests/WebExtensionTest.cpp:
(methodCallCallback):
Tools:
- ImageDiff/gtk/ImageDiff.cpp:
(printImage):
- 11:13 PM Changeset in webkit [150420] by
-
- 2 edits in trunk/Tools
[GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
https://bugs.webkit.org/show_bug.cgi?id=116450
Reviewed by Martin Robinson.
The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
TestWebKitAPI programs when compiling them.
- TestWebKitAPI/GNUmakefile.am:
- 11:11 PM Changeset in webkit [150419] by
-
- 2 edits in trunk/Source/WTF
Use 'typeof' keyword to avoid problems when compiling in C++11 standard compliance
https://bugs.webkit.org/show_bug.cgi?id=116447
Reviewed by Darin Adler.
The 'typeof' keyword is a GNU C extension which becomes unavailable when compiling in ANSI or specific standard mode
(such as -std=c++11). The 'typeof' keyword should be used instead as it's available in all modes both under GCC and Clang.
- wtf/FastMalloc.cpp:
(WTF): Replace the 'typeof' keyword with 'typeof'.
- 11:08 PM Changeset in webkit [150418] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Support application/x-mimearchive mimetype for MHTML archives instead of message/rfc822
https://bugs.webkit.org/show_bug.cgi?id=116442
Reviewed by Martin Robinson.
- loader/archive/ArchiveFactory.cpp:
(WebCore::archiveMIMETypes): Like EFL and Qt, register the application/x-mimearchive mime type as a MHTML archive type
and stop propagating the message/rfc822 mime type as such. This also removes a couple of PLATFORM ifdefs.
- 10:57 PM Changeset in webkit [150417] by
-
- 18 edits in trunk/Source/WebCore
Minor String fixes in CSS
https://bugs.webkit.org/show_bug.cgi?id=116291
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-20
Reviewed by Darin Adler.
Some trival changes to make up for a bad day :)
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::customCssText):
- css/CSSImageValue.cpp:
(WebCore::CSSImageValue::customCssText):
- css/CSSImportRule.cpp:
(WebCore::CSSImportRule::cssText):
- css/CSSInheritedValue.cpp:
(WebCore::CSSInheritedValue::customCssText):
- css/CSSInitialValue.cpp:
(WebCore::CSSInitialValue::customCssText):
- css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::customCssText):
- css/CSSPropertySourceData.cpp:
(WebCore::CSSPropertySourceData::toString):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
- css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::generateSelectorText):
- css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::type):
- css/CSSTimingFunctionValue.cpp:
(WebCore::CSSLinearTimingFunctionValue::customCssText):
(WebCore::CSSCubicBezierTimingFunctionValue::customCssText):
- css/CSSValueList.cpp:
(WebCore::CSSValueList::customCssText):
(WebCore::CSSValueList::customSerializeResolvingVariables):
- css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::serialize):
- css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::customCssText):
- css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::findKeyframeIndex):
(WebCore::WebKitCSSKeyframesRule::cssText):
- css/WebKitCSSMatFunctionValue.cpp:
(WebCore::WebKitCSSMatFunctionValue::customCssText):
- css/WebKitCSSMixFunctionValue.cpp:
(WebCore::WebKitCSSMixFunctionValue::customCssText):
- 10:50 PM Changeset in webkit [150416] by
-
- 2 edits in trunk/Tools
Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
https://bugs.webkit.org/show_bug.cgi?id=116492
Reviewed by Dirk Pranke.
Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
to memory pressure on the machine.
This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
for a subsequent patch just to make things easier to follow.
- Scripts/webkitpy/port/driver.py:
(DriverProxy.init):
(DriverProxy.run_test):
(DriverProxy.has_crashed):
(DriverProxy.stop):
- 10:33 PM Changeset in webkit [150415] by
-
- 2 edits in trunk/Tools
Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
https://bugs.webkit.org/show_bug.cgi?id=116423
Reviewed by Ryosuke Niwa.
EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 9:55 PM Changeset in webkit [150414] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 9:52 PM Changeset in webkit [150413] by
-
- 9 edits7 deletes in trunk
Remove remaining link-prerender code
https://bugs.webkit.org/show_bug.cgi?id=116429
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-20
Reviewed by Darin Adler.
Tools:
Link prerendering code was removed in r150356.
- Scripts/webkitperl/FeatureList.pm:
- qmake/mkspecs/features/features.pri:
LayoutTests:
Remove test cases related to link-prerender.
- fast/dom/HTMLLinkElement/prerender-insert-after-stop-expected.txt: Removed.
- fast/dom/HTMLLinkElement/prerender-insert-after-stop.html: Removed.
- fast/dom/HTMLLinkElement/prerender-remove-after-stop-expected.txt: Removed.
- fast/dom/HTMLLinkElement/prerender-remove-after-stop.html: Removed.
- fast/dom/HTMLLinkElement/resources/empty.html: Removed.
- fast/dom/HTMLLinkElement/resources/empty2.html: Removed.
- fast/dom/HTMLLinkElement/resources/simple-prerender.html: Removed.
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- 9:51 PM Changeset in webkit [150412] by
-
- 1 delete in tags/Safari-537.43
- 9:50 PM Changeset in webkit [150411] by
-
- 1 copy in tags/Safari-537.43/trunk
New Tag.
- 9:50 PM Changeset in webkit [150410] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 9:49 PM Changeset in webkit [150409] by
-
- 1 delete in tags/Safari-537.43
- 9:42 PM Changeset in webkit [150408] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed, rolling out r150384.
http://trac.webkit.org/changeset/150384
https://bugs.webkit.org/show_bug.cgi?id=116513
Not ready for primetime. (Requested by kling on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-20
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 9:35 PM Changeset in webkit [150407] by
-
- 4 edits in trunk/Source
Versioning.
- 9:34 PM Changeset in webkit [150406] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening. Below tests don't come to crash anymore after r150368.
But, pending-activity.html still comes to crash on wk2.
storage/indexeddb/pending-activity.html
storage/indexeddb/transaction-coordination-across-databases.html
- platform/efl-wk2/TestExpectations:
- platform/efl/TestExpectations:
- 9:30 PM Changeset in webkit [150405] by
-
- 1 copy in tags/Safari-537.43
New Tag.
- 8:58 PM Changeset in webkit [150404] by
-
- 6 edits in trunk/Tools
commit-queue should check for oops in changelog entries
https://bugs.webkit.org/show_bug.cgi?id=116395
Reviewed by Martin Robinson.
Make changelog validation fail when it contains oops!.
- Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask._validate_changelog):
- Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
- Scripts/webkitpy/tool/steps/validatechangelogs.py:
(ValidateChangeLogs.options):
(ValidateChangeLogs._check_changelog_diff):
(ValidateChangeLogs._changelog_contains_oops):
(ValidateChangeLogs.run):
- Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
(ValidateChangeLogsTest._assert_start_line_produces_output):
(ValidateChangeLogsTest.test_check_changelog_diff):
(ValidateChangeLogsTest):
(ValidateChangeLogsTest.test_changelog_contains_oops):
- 8:43 PM Changeset in webkit [150403] by
-
- 1 edit4 adds in trunk/LayoutTests
Add tests for named access checks on DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=116512
Reviewed by Geoffrey Garen.
Merge https://chromium.googlesource.com/chromium/blink/+/9207625a100abe9b72333ac5dba02b38ca5f4466
- http/tests/security/xss-DENIED-window-name-alert-expected.txt: Added.
- http/tests/security/xss-DENIED-window-name-alert.html: Added.
- http/tests/security/xss-DENIED-window-name-navigator-expected.txt: Added.
- http/tests/security/xss-DENIED-window-name-navigator.html: Added.
- 8:18 PM Changeset in webkit [150402] by
-
- 3 edits2 adds in trunk
Null pointer deference in WebCore::AppendNodeCommand::create
https://bugs.webkit.org/show_bug.cgi?id=116479
Source/WebCore:
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/5cb43002a44f67a60ecf5a7ed76de2d0bcf89eb2
DeleteSelection::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss() make style and link elements
to be the direct children of the editable root. However, these style and link elements are not necessary editable
and WebKit crashes when they are not.
Test: editing/deleting/delete-uneditable-style.html
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):
LayoutTests:
Reviewed by Andreas Kling.
Add a regression test.
- editing/deleting/delete-uneditable-style-expected.txt: Added.
- editing/deleting/delete-uneditable-style.html: Added.
- 8:13 PM Changeset in webkit [150401] by
-
- 2 edits in trunk/Source/JavaScriptCore
Disable SuperRegion
https://bugs.webkit.org/show_bug.cgi?id=116362
Rubber stamped by Geoff Garen.
- heap/Region.h:
- 7:39 PM Changeset in webkit [150400] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove SharedMemoryGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=116457
Reviewed by Andreas Kling.
- Platform/gtk/SharedMemoryGtk.cpp: Removed.
- 7:29 PM Changeset in webkit [150399] by
-
- 9 edits in trunk/Source/WebCore
Scrollbars still show sometimes even when WKPageSetSuppressScrollbarAnimations()
is set
https://bugs.webkit.org/show_bug.cgi?id=116493
-and corresponding-
<rdar://problem/13912871>
Reviewed by Dean Jackson.
We need to be more aggressive with our approach since AppKit may still ask the
scrollbars to paint here.
scrollbarAnimationsAreSuppressed() will allow us to find out if the setting has
been set.
- page/FrameView.cpp:
(WebCore::FrameView::scrollbarAnimationsAreSuppressed):
- page/FrameView.h:
- platform/ScrollableArea.h:
(WebCore::ScrollableArea::scrollbarAnimationsAreSuppressed):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollbarAnimationsAreSuppressed):
- rendering/RenderLayer.h:
(RenderLayer):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollbarAnimationsAreSuppressed):
- rendering/RenderListBox.h:
Don’t allow animations if scrollbars are suppressed.
- platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate scrollerImp:animateKnobAlphaTo:duration:]):
Call cancelAnimations() to prevent a just-started animation from continuing.
(WebCore::ScrollAnimatorMac::finishCurrentScrollAnimations):
- 7:07 PM Changeset in webkit [150398] by
-
- 8 edits3 adds in trunk
Expose a way to know when forms are added to a page or when form controls are added to a form
in the injected bundle
https://bugs.webkit.org/show_bug.cgi?id=116334
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
Add shouldNotifyOnFormChanges and didAssociateFormControls to the WKBundlePageFormClient.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
Add the new callbacks as part of version 2 of the WKBundlePageFormClient.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):
Pass the message along to the client if the client has a handler.
(WebKit::InjectedBundlePageFormClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAssociateFormControls):
Tell the injected bundle form client for the page.
(WebKit::WebChromeClient::shouldNotifyOnFormChanges):
Ditto.
- WebProcess/WebCoreSupport/WebChromeClient.h:
Tools:
Add tests for the new callbacks.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
(TestWebKitAPI::nullJavaScriptCallback):
A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
being passed in for the callback.
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
After receiving the message that didAssociateFormControls callback was invoked from adding
the form in the onload handler, tell the page to add a password field to the form, which
should also invoke didAssociateFormControls callback.
(TestWebKitAPI::setInjectedBundleClient):
Register to receive messages.
(TestWebKitAPI::TEST):
Load associate-form-controls.html and wait until the didAssociateFormControls callback has
been invoked for both adding the form and for adding a password field to the form.
- TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
(TestWebKitAPI::shouldNotifyOnFormChanges):
Return true so the didAssociateFormControls callback is invoked.
(TestWebKitAPI::didAssociateFormControls):
Tell the UI process.
(TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
(TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
- TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
Add a form in response to the onload event. Add a button that will add the password field
for manual testing.
- 7:04 PM Changeset in webkit [150397] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r150386): [WK2] loader/go-back-cached-main-resource.html fails
https://bugs.webkit.org/show_bug.cgi?id=116491
Add a test expectation.
- platform/wk2/TestExpectations:
- 6:53 PM Changeset in webkit [150396] by
-
- 2 edits in trunk/Source/WebCore
Avoid caret repaints if we're not showing carets anyway.
<http://webkit.org/b/116489>
Reviewed by Simon Fraser.
When moving the selection, check if we're inside a contenteditable element (or in caret browsing mode)
before repainting the caret's previous location.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::recomputeCaretRect):
- 6:43 PM Changeset in webkit [150395] by
-
- 6 edits2 adds in trunk
position:sticky should stick for the enclosing overflow ancestor
https://bugs.webkit.org/show_bug.cgi?id=100054
Source/WebCore:
Reviewed by Beth Dakin.
Make position: -webkit-sticky be constrained by an enclosing ancestor
with non-visible overflow if there is one, rather than being constained
always by the viewport.
Test: fast/css/sticky/sticky-top-overflow.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::computeStickyPositionConstraints): Rename
viewportRect to constrainingRect, since it isn't just about the viewport any more.
Fix an issue where just adding stickyLocation to absContainerFrame.location() was
incorrect when the container is scrolled; we also have to take the scroll offset
into account, and that offset is stored in the layer tree.
(WebCore::RenderBoxModelObject::stickyPositionOffset):
Look for an enclosing layer with overflow clipping, and, if found, use it to
compute the sticky constraint rect.
- rendering/RenderLayer.h: Add a helpful IncludeSelfOrNot, and fix several member functions
to use it place of hard-to-read boolean arguments.
Add enclosingOverflowClipLayer(IncludeSelfOrNot).
(WebCore::RenderLayer::ancestorCompositingLayer):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::enclosingOverflowClipLayer): New function, finds the enclosing
layer with overflow clip.
(WebCore::RenderLayer::enclosingCompositingLayer): Use IncludeSelfOrNot.
(WebCore::RenderLayer::enclosingCompositingLayerForRepaint): Ditto.
(WebCore::RenderLayer::enclosingFilterLayer): Ditto.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintInCompositedAncestor): Use IncludeSelfOrNot.
(WebCore::isViewportConstrainedFixedOrStickyLayer): Renamed from isRootmostFixedOrStickyLayer
and moved up so we can use it in requiresCompositingForPosition().
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Only make sticky composited if
it's viewport-constrained.
(WebCore::RenderLayerCompositor::updateViewportConstraintStatus):
(WebCore::RenderLayerCompositor::computeStickyViewportConstraints): Declare StickyPositionViewportConstraints
one line down to just before it gets used.
LayoutTests:
Reviewed by Beth Dakin.
Reference test for sticky behavior inside overflow:.
- fast/css/sticky/sticky-top-overflow-expected.html: Added.
- fast/css/sticky/sticky-top-overflow.html: Added.
- 6:25 PM Changeset in webkit [150394] by
-
- 2 edits in trunk/Source/WebCore
Remove DISABLE_ROUNDED_CORNER_CLIPPING
https://bugs.webkit.org/show_bug.cgi?id=115531
Patch by Jeff Rogers <jrogers@blackberry.com> on 2013-05-20
Reviewed by Andreas Kling.
BlackBerry port is no longer using this.
- rendering/RenderLayer.cpp:
(WebCore::inContainingBlockChain):
(WebCore::RenderLayer::clipToRect):
- 5:57 PM Changeset in webkit [150393] by
-
- 6 edits2 adds in trunk/LayoutTests
Add a test that inserting a character inside a URL doesn't move caret per auto correction
https://bugs.webkit.org/show_bug.cgi?id=116458
Reviewed by Darin Adler.
Add a test. This is broken on Safari 6 but fixed on ToT.
- editing/inserting/inserting-slash-inside-url-with-smart-link-expected.txt: Added.
- editing/inserting/inserting-slash-inside-url-with-smart-link.html: Added.
- platform/mac-wk2/TestExpectations:
- 5:49 PM Changeset in webkit [150392] by
-
- 2 edits in trunk/LayoutTests
[GTK][WK2] Unflag tests related to layoutTestController.setSmartInsertDeleteEnabled
https://bugs.webkit.org/show_bug.cgi?id=116433
Unreviewed gardening.
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-20
- platform/gtk-wk2/TestExpectations: Unflag tests as they are passing
since r150289.
- 5:24 PM Changeset in webkit [150391] by
-
- 2 edits in trunk/Tools
[EFL][JHBUILD] Make sure eet is built before evas
https://bugs.webkit.org/show_bug.cgi?id=116440
Reviewed by Gyuyoung Kim.
Mark eet as a dependency of evas since evas requires eet to enable some of its
functionality.
- efl/jhbuild.modules:
- 5:10 PM Changeset in webkit [150390] by
-
- 2 edits in trunk/LayoutTests
[Mac] [WK2] storage/websql/open-database-creation-callback-isolated-world.html, statement-error-callback-isolated-world.html,
and transaction-success-callback-isolated-world.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=116478
Add flaky test expectations.
- platform/mac-wk2/TestExpectations:
- 5:07 PM Changeset in webkit [150389] by
-
- 2 edits in trunk/LayoutTests
svg/batik/text/textEffect.svg is flaky on Mountain Lion builders
https://bugs.webkit.org/show_bug.cgi?id=116477
Add a failing test expectation.
- platform/mac/TestExpectations:
- 4:43 PM Changeset in webkit [150388] by
-
- 12 edits in trunk/Source
Clients should have a way to extend rendering suppression
https://bugs.webkit.org/show_bug.cgi?id=116463
<rdar://problem/13738496>
Reviewed by Andy Estes.
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageExtendIncrementalRenderingSuppression): Added.
(WKBundlePageStopExtendingIncrementalRenderingSuppression): Added.
- WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
These only have any effect if SuppressesIncrementalRendering is also enabled.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Inform the FrameView if there are any outstanding rendering suppression tokens.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::extendIncrementalRenderingSuppression):
Return the next available rendering suppression token.
Add it to the list of active tokens.
Inform the FrameView that we want to suppress rendering.
(WebKit::WebPage::stopExtendingIncrementalRenderingSuppression):
Remove the given token from the list of active tokens.
Un-suppress rendering if appropriate.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::shouldExtendIncrementalRenderingSuppression):
Return if there are any active rendering suppression tokens.
- WebCore.exp.in:
Export FrameView::setVisualUpdatesAllowedByClient.
- dom/Document.cpp:
(WebCore::Document::setVisualUpdatesAllowed):
Move rendering-suppression watchdog into setVisualUpdatesAllowed(bool).
setVisualUpdatesAllowed(ReadyState) should not re-enable visual updates
if the client is itself disabling visual updates.
(WebCore::Document::visualUpdatesSuppressionTimerFired):
If the watchdog fires and the client is still disabling visual
updates, we should not re-enable visual updates, but instead
wait for the client.
(WebCore::Document::setVisualUpdatesAllowedByClient):
Actually re-enable visual updates if we deferred the re-enabling above
(when the page finishes loading, but the client had them disabled).
- dom/Document.h:
(Document): Add setVisualUpdatesAllowedByClient.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView): Visual updates are allowed by default.
(WebCore::FrameView::setVisualUpdatesAllowedByClient):
Forward through to the document, but we also need to persist the state
here in FrameView so that it survives through navigation.
- page/FrameView.h:
(WebCore::FrameView::setVisualUpdatesAllowedByClient): Added.
(WebCore::FrameView::visualUpdatesAllowedByClient): Added.
Added storage for m_visualUpdatesAllowedByClient.
- 4:30 PM Changeset in webkit [150387] by
-
- 16 edits in trunk
[CSS Exclusions] Add CSS parsing support for image URI shape-inside and shape-outside values
https://bugs.webkit.org/show_bug.cgi?id=116349
Reviewed by Alexandru Chiculita.
Source/WebCore:
Add support for parsing image URI values for the shape-inside and shape-outside CSS properties.
Extended the ExclusionShapeValue class to support tracking the property's StyleImage value.
The ExclusionShapeValue::type enums were changed from all upper case to "Intercase" by order
of the style bot.
The existing CSS parsing tests were extended to check URI values.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyExclusionShape::applyValue):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImages):
- rendering/style/ExclusionShapeValue.h:
(WebCore::ExclusionShapeValue::createImageValue):
(ExclusionShapeValue):
(WebCore::ExclusionShapeValue::image):
(WebCore::ExclusionShapeValue::setImage):
(WebCore::ExclusionShapeValue::ExclusionShapeValue):
LayoutTests:
Check that shape values specified with a URI are parsed correctly.
- fast/exclusions/parsing-wrap-shape-inside-expected.txt:
- fast/exclusions/parsing-wrap-shape-outside-expected.txt:
- fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
- fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
- 4:28 PM Changeset in webkit [150386] by
-
- 5 edits in trunk
WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
https://bugs.webkit.org/show_bug.cgi?id=116125
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-20
Reviewed by Tim Horton.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::pathSuitableForTestResult):
Changed string operations to match _drt_descriptionSuitableForTestResult.
(WTR::dumpRequestDescriptionSuitableForTestResult):
(WTR::dumpResponseDescriptionSuitableForTestResult):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didInitiateLoadForResource):
(WTR::InjectedBundlePage::willSendRequestForFrame):
(WTR::InjectedBundlePage::didReceiveResponseForResource):
Pass the main frame's URL to pathSuitableForTestResult.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
Added WKBundlePageRef to willPerformClientRedirectForFrame.
LayoutTests:
- platform/wk2/TestExpectations:
Unskipped working tests.
- 4:05 PM Changeset in webkit [150385] by
-
- 2 edits in trunk/LayoutTests
Add a failing test expectation to editing/selection/user-drag-element-and-user-select-none.html
after r150354. The failure is tracked by the bug 116473.
- 3:55 PM Changeset in webkit [150384] by
-
- 3 edits in trunk/Source/WebKit2
PPT: Closing tab that is hung or chewing 100% CPU leaves abandoned WebProcess.
<http://webkit.org/b/116464>
<rdar://problem/10103795>
Reviewed by Anders Carlsson.
Give the web process a 10 second chance to exit nicely after closing the last tab belonging to it.
This code only runs if there was something on the page (e.g an unload/beforeunload event handler)
preventing the UI process from killing it right away.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::forcefulTerminationTimerFired):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- 2:38 PM Changeset in webkit [150383] by
-
- 5 edits10 adds in trunk
[CSSRegions] Fix offsetLeft / offsetTop for elements inside named flow
https://bugs.webkit.org/show_bug.cgi?id=115899
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-20
Reviewed by David Hyatt.
Source/WebCore:
Elements in named flows that have the body as their offsetParent, need to compute their
offsetLeft and offsetTop values relative to the body.
Tests: fast/regions/offsetLeft-offsetTop-in-multiple-regions.html
fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html
fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html
fast/regions/offsetLeft-offsetTop-in-region-float.html
fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
- rendering/RenderFlowThread.cpp:
(WebCore):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent):
- rendering/RenderFlowThread.h:
LayoutTests:
Added tests for the implementation of offsetLeft and offsetTop for objects inside named flows
for which the offsetParent is the body.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-multiple-regions.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html: Added.
- fast/regions/offsetLeft-offsetTop-in-region-float.html: Added.
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Added.
- fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html: Added.
- 2:17 PM Changeset in webkit [150382] by
-
- 2 edits in trunk/LayoutTests
[Windows] Unreviewed TestExpectation cleanup. Reordered lines
to match Mac version to make it easier to understand what features
are uniquely missing in Windows port.
- platform/win/TestExpectations: Reordering of lines, adds some
bug ID's to existing skipped tests.
- 2:10 PM Changeset in webkit [150381] by
-
- 6 edits in trunk/Source/JavaScriptCore
Make C API more robust against null contexts
https://bugs.webkit.org/show_bug.cgi?id=116462
Reviewed by Anders Carlsson.
Handle null contexts in a non-crashy way. It's a bug to ever call the
API with a null context, and the absence of a context means we can't
produce a meaningful result, so we still assert in debug builds.
Now where possible we detect and early return, returning null for any
pointer type, NaN for doubles, and false for any boolean result.
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSReportExtraMemoryCost):
- API/JSContextRef.cpp:
(JSContextGetGlobalObject):
(JSContextGetGroup):
(JSContextGetGlobalContext):
(JSContextCreateBacktrace):
- API/JSObjectRef.cpp:
(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectCopyPropertyNames):
- API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueMakeFromJSONString):
(JSValueCreateJSONString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
- API/JSWeakObjectMapRefPrivate.cpp:
- 1:42 PM Changeset in webkit [150380] by
-
- 3 edits in trunk/Tools
fix w3c test importer unit tests after r150324
https://bugs.webkit.org/show_bug.cgi?id=116459
Reviewed by Ryosuke Niwa.
This patch fixes the unit tests to not actually call out to
'hg' (by using a mock executive) and also changes the real
directory we crawl from Source/WebCore/css to
Tools/Scripts/webkitpy/w3c to run much more quickly. We should
still change this to a mock filesystem, but that's a separate change.
- Scripts/webkitpy/w3c/test_importer.py:
(main):
(TestImporter.init):
(TestImporter.load_changeset):
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
(TestImporterTest.test_import_dir_with_no_tests):
- 1:34 PM Changeset in webkit [150379] by
-
- 2 edits2 adds in trunk/Source/WebKit2
Add helper function for converting a KeyedCodingValue to a CFTypeRef
https://bugs.webkit.org/show_bug.cgi?id=116461
Reviewed by Tim Horton.
- Shared/cf/KeyedCodingValueCF.cpp: Added.
- Shared/cf/KeyedCodingValueCF.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 1:00 PM Changeset in webkit [150378] by
-
- 2 edits in trunk/LayoutTests
[Qt] REGRESSION(r149457): some fast/exclusions tests are failing
https://bugs.webkit.org/show_bug.cgi?id=115511
Reviewed by Andreas Kling.
Unskipping the exclusions tests on Qt. They were fixed by https://bugs.webkit.org/show_bug.cgi?id=116115.
- platform/qt/TestExpectations:
- 12:55 PM Changeset in webkit [150377] by
-
- 2 edits3 adds in trunk/Source/WebKit2
Begin stubbing out a new KeyedEncoder class
https://bugs.webkit.org/show_bug.cgi?id=116456
Reviewed by Sam Weinig.
This class (and it's coming counterpart, KeyedDecoder) will be used for serializing
object graphs to a tree-like structure of dictionaries. It is up to individual ports to
serialize them further (for example, on Mac they could be serialized to CFPropertyList objects).
This will be used for serializing session storage state but I hope that it can be used for serializing
back forward state in the future as our current implementation of back forward state serialization
is fragile and depends on our IPC layer's binary encoding(!).
- Shared/KeyedCodingValue.h: Added.
- Shared/KeyedEncoder.cpp: Added.
- Shared/KeyedEncoder.h: Added.
- WebKit2.xcodeproj/project.pbxproj:
- 12:13 PM Changeset in webkit [150376] by
-
- 4 edits in trunk/Tools
Unreviewed EFL build fix.
Fix linking errors due to undefined symbols on Ubuntu 13.04.
- DumpRenderTree/efl/CMakeLists.txt:
- EWebLauncher/CMakeLists.txt:
- MiniBrowser/efl/CMakeLists.txt:
- 12:00 PM Changeset in webkit [150375] by
-
- 3 edits4 adds in trunk
[CSS Regions][CSS Exclusions] shape-inside on regions should respect positioned shapes and overflow
https://bugs.webkit.org/show_bug.cgi?id=116252
Reviewed by David Hyatt.
Regions should respect shape-inside properties which have specified top offset. Since the content which overflows from the
shape should be pushed after the content box (for details check out r148975), I implemented overflowthe behavior for simple
cases when you have only one region. I'm going to implement it for additional regions in a follow up patch.
Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html
fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html
Source/WebCore:
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLineBoundariesForExclusions): Handle the flow thread case, push the overflowing content after the
content box. Respect existing shape-inside on region tests.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Set the correct logical top position for the shape-inside in
the case of regions. Respect the region's margins and paddings.
LayoutTests:
- fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-block-content-basic-overflow-shape-top-offset.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset-expected.html: Added.
- fast/regions/shape-inside/shape-inside-on-regions-inline-content-basic-overflow-shape-top-offset.html: Added.
- 11:45 AM Changeset in webkit [150374] by
-
- 2 edits in trunk/LayoutTests
[GTK] Cleanup TestExpectations to pass --lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=116419
Unreviewed GTK gardening.
Remove one of two http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-20
- platform/gtk/TestExpectations:
- 11:10 AM Changeset in webkit [150373] by
-
- 11 edits in trunk/Source/WebCore
Remove custom binding for the Clipboard clearData function
https://bugs.webkit.org/show_bug.cgi?id=116421
Reviewed by Andreas Kling.
- bindings/js/JSClipboardCustom.cpp: Removed the clearData binding.
- dom/Clipboard.idl: Removed [Custom].
- dom/Clipboard.cpp:
(WebCore::Clipboard::clearData): Renamed from clearAllData.
- dom/Clipboard.h: Rename clearAllData to clearData so we just use
overloading for the one with and without a MIME type.
- platform/ios/ClipboardIOS.h: Rename clearAllData to clearData.
- platform/ios/ClipboardIOS.mm:
(WebCore::ClipboardIOS::clearData): Ditto.
- platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::clearData). Ditto.
- platform/qt/ClipboardQt.h: Ditto.
- platform/win/ClipboardWin.cpp:
(WebCore::ClipboardWin::clearData): Ditto.
- platform/win/ClipboardWin.h: Ditto.
- 10:21 AM Changeset in webkit [150372] by
-
- 2 edits in trunk/Source/WebCore
[iOS] media/event-queue-crash.html ASSERTs in notifyChildInserted
https://bugs.webkit.org/show_bug.cgi?id=116444
Reviewed by Jer Noble.
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureMediaControls): Only create media controls when the
element is in a Document.
- 9:47 AM Changeset in webkit [150371] by
-
- 9 edits2 adds in trunk
[Mac] captions menu should behave more like a menu
https://bugs.webkit.org/show_bug.cgi?id=116436
Reviewed by Eric Carlson.
Let the captions menu behave more like a native Mac menu by hiding it when
clicking anywhere on the page and preventing the page from scrolling when
attempting to scroll the captions menu when it cannot scroll in the requested
direction.
Test: media/video-controls-captions-trackmenu-hide-on-click-outside.html
- dom/EventListener.h:
Add the new MediaControlsAppleEventListenerType.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::defaultEventHandler):
(WebCore::MediaControlsApple::hide):
(WebCore::MediaControlsApple::makeTransparent):
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility):
(WebCore::MediaControlsApple::reportedError):
(WebCore::MediaControlsApple::toggleClosedCaptionTrackList):
Use the hideClosedCaptionTrackList() and showClosedCaptionTrackList()
methods to hide and show the captions menu instead of calling hide()
and show() directly on m_closedCaptionsContainer.
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
Show the m_closedCaptionsContainer and register a "mousewheel" event
listener on it as well as a "click" event listener on the entire document.
(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
Hide the m_closedCaptionsContainer and remove the "mousewheel" event
listener on it as well as the "click" event listener on the entire document.
(WebCore::MediaControlsApple::shouldClosedCaptionsContainerPreventPageScrolling):
New private utility to determine whether the m_closedCaptionsContainer can scroll
in the provided scroll direction.
(WebCore::MediaControlsApple::eventListener):
Obtain the event listener used for "mousewheel" and "click" event handlers.
(WebCore::MediaControlsAppleEventListener::handleEvent):
Event handler for the "mousewheel" and "click" events. If we get a "click" event, we
toggle the captions menu visibility and if we get a "mousewheel" event, we call into
shouldClosedCaptionsContainerPreventPageScrolling() to see if we can scroll in the
current scroll direction, and if not prevent the event from resulting in a scroll by
calling preventDefault().
(WebCore::MediaControlsAppleEventListener::operator==):
Required for the successful subclassing of EventListener.
- html/shadow/MediaControlsApple.h:
(MediaControlsAppleEventListener):
(WebCore::MediaControlsAppleEventListener::create):
(WebCore::MediaControlsAppleEventListener::cast):
(WebCore::MediaControlsAppleEventListener::MediaControlsAppleEventListener):
New subclass of EventListener required to provide a custom event listener for the
"mousewheel" and "click" events registered in showClosedCaptionTrackList() and
hideClosedCaptionTrackList().
- 9:39 AM Changeset in webkit [150370] by
-
- 3 edits3 adds in trunk
[Cairo] Canvas-shadow behavior is not being as expected
https://bugs.webkit.org/show_bug.cgi?id=108897
Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-05-18
Reviewed by Martin Robinson.
Source/WebCore:
ShadowBlur::endShadowLayer copies the image from shadowContext to cairoContext.
CairoContext-path should be empty for doing this copy. Otherwise, the
original-image area will also get filled with the shadow.
Test: fast/canvas/canvas-image-shadow.html
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::drawPathShadow):
LayoutTests:
Test to verify the shadow of an image drawn on canvas.
This test uses an image whose size is smaller than,
the size of the rectangle which should be filled with the image.
- fast/canvas/canvas-image-shadow-expected.txt: Added.
- fast/canvas/canvas-image-shadow.html: Added.
- fast/canvas/script-tests/canvas-image-shadow.js: Added.
(draw):
- 9:21 AM Changeset in webkit [150369] by
-
- 4 edits in trunk/Source/WebKit2
Bump WKBundlePageLoaderClient version number so as not to break some clients
https://bugs.webkit.org/show_bug.cgi?id=116426
Reviewed by Anders Carlsson.
- Shared/APIClientTraits.cpp:
(WebKit):
- Shared/APIClientTraits.h:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- 9:00 AM Changeset in webkit [150368] by
-
- 6 edits in trunk
[EFL] Reenabled INDEXED_DATABASE after r150344
https://bugs.webkit.org/show_bug.cgi?id=116430
Reviewed by Gyuyoung Kim.
.:
Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
build was fixed in r150344.
- Source/cmake/OptionsEfl.cmake:
Tools:
Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
build was fixed in r150344.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Unskip indexeddb layout tests for EFL port now that the functionality
is reenabled at compile time.
- platform/efl/TestExpectations:
- 7:44 AM Changeset in webkit [150367] by
-
- 4 edits in trunk/Source
Synchronize FeatureDefines.xcconfig
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig: Remove
ENABLE_LINK_PRERENDER. This was missed in r150356.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig: Add a newline to the
end of the file.
- 6:44 AM Changeset in webkit [150366] by
-
- 10 edits in trunk
-webkit-text-underline-position should not be inherited
https://bugs.webkit.org/show_bug.cgi?id=116363
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-20
Reviewed by Dean Jackson.
Source/WebCore:
Specification says text-underline-position should not be inherited.
No new tests, this updates existing tests.
- css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty): Make
CSSPropertyWebkitTextUnderlinePosition return false.
- rendering/style/RenderStyle.h: Treat TextUnderlinePosition as
non-inherited.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==): Remove m_textUnderlinePosition.
- rendering/style/StyleRareInheritedData.h:
(StyleRareInheritedData):
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==): Add m_textUnderlinePosition.
- rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):
LayoutTests:
Update expected results.
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-underline-position-expected.txt:
- fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-underline-position.js:
- 6:36 AM Changeset in webkit [150365] by
-
- 3 edits in trunk/Source/WebCore
Add compile asserts for the size of RootInlineBox and InlineTextbox
https://bugs.webkit.org/show_bug.cgi?id=116337
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-20
Reviewed by Darin Adler.
Add compile asserts to ensure RootInlineBox and InlineTextbox stay small.
- rendering/InlineTextBox.cpp:
(SameSizeAsInlineTextBox):
(WebCore):
- rendering/RootInlineBox.cpp:
(SameSizeAsRootInlineBox):
(WebCore):
- 5:03 AM Changeset in webkit [150364] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Adding failure expectations for spelling tests.
- platform/efl-wk2/TestExpectations:
- 3:45 AM WebKit Team edited by
- (diff)
- 3:11 AM Changeset in webkit [150363] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
spelling-double-clicked-word.html passes after r150289.
- platform/efl-wk2/TestExpectations:
- 2:37 AM Changeset in webkit [150362] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] LocalizedStringsBlackBerry: add dummy text track strings
https://bugs.webkit.org/show_bug.cgi?id=116300
Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-20
Reviewed by Rob Buis.
These are dummy implementations necessary to make WebKit link.
- platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::weekFormatInLDML):
(WebCore):
(WebCore::textTrackClosedCaptionsText):
(WebCore::textTrackSubtitlesText):
(WebCore::textTrackOffText):
(WebCore::textTrackNoLabelText):
- 1:30 AM Changeset in webkit [150361] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Do not use skia in FrameLoaderClientBlackBerry::dispatchDidReceiveIcon()
https://bugs.webkit.org/show_bug.cgi?id=116302
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-20
Reviewed by Rob Buis.
TiledImage is now the NativeImage of the BlackBerry port.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- 1:02 AM EFLWebKit edited by
- buildbots (diff)
- 1:01 AM EFLWebKitBuildBots edited by
- (diff)
- 1:00 AM EFLWebKitBuildBots edited by
- removing cq requestees. (diff)
- 1:00 AM EFLWebKitBuildBots edited by
- removing intel gardeners (diff)
- 12:24 AM WebKitGTK/2.0.x edited by
- (diff)
May 19, 2013:
- 11:48 PM Changeset in webkit [150360] by
-
- 2 edits in trunk/Tools
[EFL] init/shutdown should be paired in EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=116427
Reviewed by Christophe Dumez.
Added ecore_file_shutdown() for cleanup of ecore_file.
Removed edje_init and ecore_evas_init because it was in ewk_init().
- EWebLauncher/main.c:
(main):
- 5:50 PM Changeset in webkit [150359] by
-
- 18 edits in branches/dfgFourthTier
CheckArrays should be hoisted
https://bugs.webkit.org/show_bug.cgi?id=116353
Source/JavaScriptCore:
Performance neutral. This will be more important when we start depending on CheckArray for flat arrays.
Reviewed by Filip Pizlo.
- dfg/DFGAbstractState.cpp: Add ForwardCheckArray to wherever we had a CheckArray before.
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::isContravenedByStructure): Checks if the ArrayMode derived from a specific Structure
would contradict the ArrayModes that would be filtered by the current ArrayMode. This is used to detect
if any specific CheckStructures would contradict our CheckArray so that we can defer to the CheckStructure's
judgment.
- dfg/DFGByteCodeParser.cpp: Fill in checkArrayHoistingFailed where we previously exited due to a BadIndexingType.
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkArrayElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h: New ForwardCheckArray node type.
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp: Refactored most of TypeCheckHoistingPhase into separate functions, some
of which are now generic to both CheckStructure and CheckArray hoisting while others are specific to one or the
other. Both of the non-zero CheckBallot values must be 1 because we use them as an index into an array of
length 2 inside the VariableAccessData.
(CheckData): Moved structure outside of TypeCheckHoistingPhase so that ArrayTypeCheck and StructureTypeCheck
can access it. Also added new fields for tracking ArrayModes. We need the m_arrayModeIsValid because there
isn't a good sentinel value for "this ArrayMode is invalid and meaningless" like there is for m_structure.
We need m_arrayModeHoistingOkay for when we want to permanently disable hoisting for that particular variable.
(JSC::DFG::CheckData::CheckData):
(JSC::DFG::CheckData::disableCheckArrayHoisting): Helper function for disabling CheckArray hoisting for a
specific CheckData.
(JSC::DFG::TypeCheckHoistingPhase::run): We now do both CheckStructure and CheckArray hoisting, although we prefer
CheckStructure hoisting when given the possibility to do both.
(TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::clearVariableVotes): Clears all of the VariableAccessData votes since they
can only have two types of votes at any particular time.
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks): Very similar to identifyRedundantStructureChecks,
but with a few different nodes that are important, namely CheckArray (instead of CheckStructure) and the Arrayify-like
nodes always disable hoisting since they always change the IndexingType.
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingForVariablesWithInsufficientVotes):
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):
(JSC::DFG::TypeCheckHoistingPhase::disableCheckArrayHoisting): Helper that looks up the CheckData for the
specified variable and disables CheckArray hoisting on it.
(JSC::DFG::TypeCheckHoistingPhase::shouldConsiderForHoisting):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheck):
(JSC::DFG::TypeCheckHoistingPhase::noticeCheckArray):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode): We want to take CheckStructure nodes
into account when hoisting CheckArrays, so we make sure that if we contradict what a CheckStructure says then we
give up on hoisting the CheckArray.
(JSC::DFG::ArrayTypeCheck::isValidToHoist):
(ArrayTypeCheck): Structure that houses some of the specifics on how to hoist CheckArrays. This structure
is used a template argument to allow some of the very similar code to statically parameterized and reused
for both CheckStructure and CheckArray hoisting.
(JSC::DFG::ArrayTypeCheck::disableHoisting):
(JSC::DFG::ArrayTypeCheck::isContravenedByValue):
(JSC::DFG::ArrayTypeCheck::hasEnoughVotesToHoist):
(JSC::DFG::ArrayTypeCheck::hoistingPreviouslyFailed):
(JSC::DFG::StructureTypeCheck::isValidToHoist):
(StructureTypeCheck): Same as ArrayTypeCheck, but specific to CheckStructure hoisting.
(JSC::DFG::StructureTypeCheck::disableHoisting):
(JSC::DFG::StructureTypeCheck::isContravenedByValue):
(JSC::DFG::StructureTypeCheck::hasEnoughVotesToHoist):
(JSC::DFG::StructureTypeCheck::hoistingPreviouslyFailed):
- dfg/DFGUnificationPhase.cpp: Added merging of whether or not CheckArray hoisting failed.
(JSC::DFG::UnificationPhase::run):
- dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::mergeCheckArrayHoistingFailed):
(VariableAccessData):
(JSC::DFG::VariableAccessData::checkArrayHoistingFailed):
- runtime/Options.h:
LayoutTests:
Added a microbenchmark to JSRegress that specifically targets CheckArray hoisting.
We get a 25% improvement on it.
Reviewed by Filip Pizlo.
- fast/js/regress/check-array-hoisting-expected.txt: Added.
- fast/js/regress/check-array-hoisting.html: Added.
- fast/js/regress/script-tests/check-array-hoisting.js: Added.
(f):
- 5:04 PM Changeset in webkit [150358] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Improve string use in PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116418
Reviewed by Sam Weinig.
Did a Ben Poulain all over this file.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText): Add the newline separately to the string builder.
Prepending it to the string first just does more allocations for no good reason.
(WebCore::Pasteboard::documentFragment): Use emptyString() instead of "" and use
ASCIILiteral where appropriate.
(WebCore::cocoaTypeFromHTMLClipboardType): More ASCIILiteral.
(WebCore::Pasteboard::clear): Use early return instead of a nested if here.
Use emptyString() instead of "".
(WebCore::addHTMLClipboardTypesForCocoaType): More ASCIILiteral.
- 4:56 PM Changeset in webkit [150357] by
-
- 2 edits in trunk/Tools
[EFL] Add command line option to MiniBrowser to set user agent
https://bugs.webkit.org/show_bug.cgi?id=116387
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-19
Reviewed by Christophe Dumez.
We need this option to compare the rendering differences according to different user agents.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 3:57 PM Changeset in webkit [150356] by
-
- 32 edits6 deletes in trunk
Remove link prerendering code
https://bugs.webkit.org/show_bug.cgi?id=116415
Reviewed by Darin Adler.
.:
This code was only used by Chromium and is dead now.
- Source/autotools/SetupWebKitFeatures.m4:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::Document::Document):
- dom/Document.h:
(WebCore):
(Document):
- dom/EventNames.h:
(WebCore):
- html/HTMLLinkElement.cpp:
- html/HTMLLinkElement.h:
- html/LinkRelAttribute.cpp:
(WebCore::LinkRelAttribute::LinkRelAttribute):
- html/LinkRelAttribute.h:
(LinkRelAttribute):
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::~LinkLoader):
(WebCore::LinkLoader::loadLink):
(WebCore::LinkLoader::released):
- loader/LinkLoader.h:
(WebCore):
(LinkLoader):
- loader/LinkLoaderClient.h:
(LinkLoaderClient):
- loader/Prerenderer.cpp: Removed.
- loader/Prerenderer.h: Removed.
- loader/PrerendererClient.cpp: Removed.
- loader/PrerendererClient.h: Removed.
- platform/PrerenderClient.h: Removed.
- platform/PrerenderHandle.h: Removed.
Source/WebKit/blackberry:
This code was only used by Chromium and is dead now.
- WebCoreSupport/AboutDataEnableFeatures.in:
Source/WebKit/mac:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
This code was only used by Chromium and is dead now.
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
This code was only used by Chromium and is dead now.
- wtf/FeatureDefines.h:
- 3:52 PM Changeset in webkit [150355] by
-
- 12 edits in trunk/Source/WebCore
Change the terminology used by rendering code when painting a given node and its children from "paintingRoot" to "subtreePaintRoot"
https://bugs.webkit.org/show_bug.cgi?id=116417
Reviewed by Sam Weinig.
PaintInfo and RenderLayer code referred to a "paintingRoot". This is only set when
FrameView::setNodeToDraw() has been called and is used to restrict painting to
some part of the subtree, but it could easily be misinterpreted, and confused with
the "rootLayer" used by RenderLayer (which is usually not the layer associated with
the paintingRoot).
Change the terminology from "paintingRoot" to "subtreePaintRoot" root to make the
purpose of this variable more obvious.
No behavior change.
- page/FrameView.cpp: Add a comment for setNodeToDraw(); in future this should
be called setSubtreePaintRoot() or something. Not done in this patch to avoid
risk; this function is exported from WebCore.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
- rendering/PaintInfo.h:
(WebCore::PaintInfo::PaintInfo):
(WebCore::PaintInfo::updateSubtreePaintRootForChildren):
(WebCore::PaintInfo::shouldPaintWithinRoot):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintContents):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paint):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintLayerByApplyingTransform):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
- rendering/RenderLayer.h:
(WebCore::RenderLayer::LayerPaintingInfo::LayerPaintingInfo):
- rendering/RenderObject.cpp: Add a comment to recommend changing the name of
paintingRootRect() to refer to a subtree paint. Not done in this patch to avoid
risk; this function is exported from WebCore.
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::paint):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::paintObject):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
- 2:51 PM Changeset in webkit [150354] by
-
- 5 edits in trunk/Source/WebCore
Use Element instead of Node in DragState, also redo DragState struct
https://bugs.webkit.org/show_bug.cgi?id=116411
Reviewed by Sam Weinig.
The drag source is an element, so use RefPtr<Element> instead of RefPtr<Node>.
Also, the entire drag state is about dragging, so no need for the word "drag" in the
name of its members. Also, it's a struct, so the members don't need m_ prefixes.
- page/DragController.cpp: Removed unneeded include of Node.h since it's included by
Element.h, which is also included.
(WebCore::DragController::draggableElement): Renamed from Node to Element and changed
the types and names of arguments accordingly. Also made this function handle a
startElement of 0 so callers don't need to. Also updated for changes to DragState members.
(WebCore::DragController::startDrag): Updated for changes to DragState members.
Since dragSource can only be an element, was able to get rid of isElementNode checks.
- page/DragController.h: Fixed style of forward declarations of structs. Updated for
change of draggableNode to draggableElement. Also removed declarations of nonexistent
selectionDraggingRect and doDrag functions.
- page/DragState.h: Rewrote practically this whole header. Added an include of Element
instead of Node since that's what we use now. Removed includes that are redundant.
There's no problem copying a DragState, so removed WTF_MAKE_NONCOPYABLE. There's no need
to allocate a DragState on the heap, so removed WTF_MAKE_FAST_ALLOCATED. The event dispatch
boolean is never set to a constant, so there's no need for a policy enum; it can just be
a boolean. Removed the "m_" prefixes from the struct members, since this is a struct with
public members and we don't use the prefix in those cases. Removed the word "drag" from the
struct member names since this entire struct is about dragging and has drag in its name.
Left the comments mostly intact, even though I'm not certain of their value.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent): Updated for changes to DragState.
(WebCore::EventHandler::eventMayStartDrag):
Use innerElement instead of innerNode to call draggableElement instead of draggableNode.
(WebCore::EventHandler::updateDragAndDrop): Updated for changes to DragState.
(WebCore::EventHandler::cancelDragAndDrop): Ditto.
(WebCore::EventHandler::handleWheelEvent): Added FIXME.
(WebCore::EventHandler::dragHysteresisExceeded): Updated for changes to DragState.
(WebCore::EventHandler::freeClipboard): Updated for changes to DragState. Also re-added
code to release the clipboard object, which is needed here to avoid keeping it around in
memory until the next drag.
(WebCore::EventHandler::dragSourceEndedAt): Updated for changes to DragState.
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Ditto.
(WebCore::EventHandler::dispatchDragSrcEvent): Ditto.
(WebCore::EventHandler::handleDrag): Updated for changes to DragState. Use innerElement
instead of innerNode to call draggableElement instead of draggableNode. No longer need to
null check innerElement because draggableElement does that. Removed unneeded else that was
setting m_dragSrc to zero since it's guaranteed to already be zero.
- 1:38 PM Changeset in webkit [150353] by
-
- 20 edits in trunk/Source
Remove ChromeClient::webView()
https://bugs.webkit.org/show_bug.cgi?id=116054
Source/WebCore:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- loader/EmptyClients.h:
- page/ChromeClient.h:
(ChromeClient):
Source/WebKit/blackberry:
Reviewed by Andreas Kling.
This blatantly horrible layer violation was only used by the Chromium port; get rid of it.
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Source/WebKit/efl:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientEfl.h:
(ChromeClientEfl):
Source/WebKit/gtk:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
Source/WebKit/mac:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit/qt:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientQt.h:
(ChromeClientQt):
Source/WebKit/win:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
Source/WebKit/wince:
Reviewed by Darin Adler.
This blatantly horrible layer violation was only used to know if a ChromeClient is an empty
client or not. We already have a (slightly less horrible) way to do that.
- WebCoreSupport/ChromeClientWinCE.h:
(ChromeClientWinCE):
- 11:40 AM Changeset in webkit [150352] by
-
- 2 edits in trunk/Tools
Unreviewed, addressing test-webkitpy failures after r150317.
- Scripts/webkitpy/w3c/test_converter.py:
(W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
- 8:40 AM Changeset in webkit [150351] by
-
- 6 edits1 delete in trunk/Source/WebCore
Eliminate the Editor::newGeneralClipboard function
https://bugs.webkit.org/show_bug.cgi?id=116410
Reviewed by Andreas Kling.
This is one of the clean-ups made possible by the changes to the DOM clipboard class.
I had been waiting until all the platforms were moved over to it, but it turns out to be
easy to do this now, just with #ifdefs.
- PlatformBlackBerry.cmake: Deleted EditorBlackBerry.cpp.
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent): Call Clipboard::createForCopyAndPaste directly when
using the new version of the Clipboard class. Also some small style cleanup nearby.
- editing/blackberry/EditorBlackBerry.cpp: Removed. The only function in this file was
newGeneralClipboard.
- editing/mac/EditorMac.mm: Deleted newGeneralClipboard.
- platform/efl/ClipboardEfl.cpp: Ditto.
- platform/gtk/ClipboardGtk.cpp: Ditto.
- 7:56 AM Changeset in webkit [150350] by
-
- 2 edits in trunk/Source/WebCore
GtkSelectionData length is off by one
https://bugs.webkit.org/show_bug.cgi?id=113962
Reviewed by Anders Carlsson.
No new tests. Since drag data is interpreted as a null-terminated string
this is difficult to test with a C program and we have no infrastructure
built for using GIR tests.
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData): Instead of including the null
character in the paste data length, just include the string. This matches the behavior
of Firefox.
May 18, 2013:
- 8:01 PM Changeset in webkit [150349] by
-
- 5 edits in trunk/Source/WebCore
Hoist several chunks of code at the top of RenderLayer::paintLayerContents() onto new functions
https://bugs.webkit.org/show_bug.cgi?id=116406
Reviewed by Andreas Kling.
RenderLayer::paintLayerContents() was getting polluted with code related to filters,
clipping and font subpixel quantization, and hard to follow.
Move three hunks of code into new functions:
setupFontSubpixelQuantization() now contains the code related to whether we disable
font subpixel quantization on the context.
setupClipPath() now contains code related to clipping to shapes and references.
setupFilters() and applyFilters() contain code related to CSS filters.
As part of this, the interaction with FilterEffectRendererHelper was simplified.
It was convenient for setupFilters() to return a FilterEffectRendererHelper object
if successful, so we use an OwnPtr<FilterEffectRendererHelper> now. In addition,
the GraphicsContext swapping was moved from FilterEffectRendererHelper code into RenderLayer
to make it easier to follow. FilterEffectRendererHelper no longer holds on to
the old GraphicsContext.
No behavior change.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRendererHelper::filterContext):
(WebCore::FilterEffectRendererHelper::beginFilterEffect):
(WebCore::FilterEffectRendererHelper::applyFilterEffect):
- rendering/FilterEffectRenderer.h:
(WebCore::FilterEffectRendererHelper::FilterEffectRendererHelper):
(WebCore::FilterEffectRendererHelper::hasStartedFilterEffect):
(FilterEffectRendererHelper):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFontSubpixelQuantization):
(WebCore::RenderLayer::setupClipPath):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::applyFilters):
(WebCore::RenderLayer::paintLayerContents):
- rendering/RenderLayer.h:
- 8:00 PM Changeset in webkit [150348] by
-
- 3 edits in trunk/Source/WebCore
Refactor RenderStyle::diff()
https://bugs.webkit.org/show_bug.cgi?id=116397
Reviewed by Andreas Kling.
RenderStyle::diff() was prone to being changed incorrectly, since there was
a poorly documented ordering requirement: style changes that cause layout
have to be detected before those that cause only repainting.
In addition, the existing code made it impossible to separately ask whether
a given style change requires a repaint, if we've already detected that it
requires a positioned-movement-only layout.
Fix by factoring the code into member functions that check for each type
of style change.
No behavior change.
- rendering/style/RenderStyle.cpp:
(WebCore::positionChangeIsMovementOnly):
(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresPositionedLayoutOnly):
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::changeRequiresRepaint):
(WebCore::RenderStyle::changeRequiresRepaintIfText):
(WebCore::RenderStyle::changeRequiresRecompositeLayer):
(WebCore::RenderStyle::diff):
- rendering/style/RenderStyle.h:
- 7:40 PM Changeset in webkit [150347] by
-
- 2 edits in trunk/LayoutTests
svg/batik tests are flakey.
webkit.org/b/116398
- platform/mac/TestExpectations:
- 5:06 PM Changeset in webkit [150346] by
-
- 9 edits in trunk/Source
Simplify the StorageArea setter functions
https://bugs.webkit.org/show_bug.cgi?id=116402
Reviewed by Sam Weinig.
Source/WebCore:
Move more security checking code to Storage so more code can be shared between WebKit1 and WebKit2.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
- storage/Storage.cpp:
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
- storage/StorageArea.h:
(StorageArea):
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::setItem):
(WebCore::StorageAreaImpl::removeItem):
(WebCore::StorageAreaImpl::clear):
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
Source/WebKit2:
Remove security checking code that lives in Storage now.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
- WebProcess/Storage/StorageAreaImpl.h:
- 4:40 PM Changeset in webkit [150345] by
-
- 2 edits in trunk/Source/WebKit2
Fix some builds.
- UIProcess/API/mac/WKTypeRefWrapper.mm:
- 4:15 PM Changeset in webkit [150344] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r150305): WebKit2 build broken with INDEXED_DATABASE enabled
https://bugs.webkit.org/show_bug.cgi?id=116389
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-18
Reviewed by Martin Robinson.
There's no longer WebKeyValueStorageManager in the web process
after r150305.
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
- 3:41 PM Changeset in webkit [150343] by
-
- 3 edits2 adds in trunk/Source/WebKit2
Add a way to pass WebKit2 WKTypeRefs in Objective-C style user data messages
https://bugs.webkit.org/show_bug.cgi?id=116345
Reviewed by Anders Carlsson.
In order to efficiently send a WKImageRef to another process when using the
Objective-C WKConnection (or other user data messages), we need a way to encode
WKTypeRefs in the objective-c object graph. Thus was born WKTypeRefWrapper.
- Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::typeFromObject):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
- UIProcess/API/mac/WKTypeRefWrapper.h: Added.
- UIProcess/API/mac/WKTypeRefWrapper.mm: Added.
(-[WKTypeRefWrapper initWithObject:]):
(-[WKTypeRefWrapper object]):
- WebKit2.xcodeproj/project.pbxproj:
- 3:11 PM Changeset in webkit [150342] by
-
- 9 edits in trunk/Source
Simplify StorageArea getter functions
https://bugs.webkit.org/show_bug.cgi?id=116399
Reviewed by Sam Weinig.
Source/WebCore:
Move the security and private browsing checks from StorageArea to Storage so we can share
more code between WebKit1 and WebKit2.
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
Update to new StorageArea interface. The security checks are unnecessary here anyway because
InspectorDOMStorageAgent::findStorageArea will only return a StorageArea that can be accessed
by the frame's security origin.
- storage/Storage.cpp:
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::contains):
- storage/StorageArea.h:
(StorageArea):
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::item):
(WebCore::StorageAreaImpl::contains):
- storage/StorageAreaImpl.h:
(StorageAreaImpl):
Source/WebKit2:
Remove security and private browsing checks.
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::item):
(WebKit::StorageAreaImpl::contains):
- WebProcess/Storage/StorageAreaImpl.h:
- 12:27 PM Changeset in webkit [150341] by
-
- 2 edits1 add in trunk/PerformanceTests
Add a performance test for copying
https://bugs.webkit.org/show_bug.cgi?id=116394
Reviewed by Andreas Kling.
Added. We're going to skip this test by default since it's such a microbenchmark, and also because
it currently takes 30 minutes to run. As insane as it sounds, each copy takes rouhgly 57 seconds.
Running Interactive/CopyAll.html (1 of 1)
RESULT Interactive: CopyAll: Time= 57618.05 ms
median= 57135.0 ms, stdev= 1542.07271571 ms, min= 55095.0 ms, max= 60913.0 ms
RESULT Interactive: CopyAll: JSHeap= 102811.2 bytes
median= 103272.0 bytes, stdev= 1115.28148913 bytes, min= 100648.0 bytes, max= 103504.0 bytes
RESULT Interactive: CopyAll: Malloc= 446408712.0 bytes
median= 459156772.0 bytes, stdev= 20007346.3266 bytes, min= 415564040.0 bytes, max= 462011928.0 bytes
Finished: 1766.883236 s
- Interactive/CopyAll.html: Added.
- Skipped:
- 12:09 PM Changeset in webkit [150340] by
-
- 2 edits in trunk/Source/WebCore
Garbage on page background while http://canberraballoons.com.au is loading
https://bugs.webkit.org/show_bug.cgi?id=116384
<rdar://problem/13930328>
Reviewed by Dan Bernstein.
This page loads a large JPEG image as the body background.
ImageSource::frameHasAlphaAtIndex() always claims that JPEG images
are opaque, but this isn't true if the frame is only partially loaded.
However, this would cause FillLayer::hasOpaqueImage() to report that the
background image is opaque, so we'd skip painting the background color.
Unpainted content in an opaque layer results in garbage.
Fix by having ImageSource::frameHasAlphaAtIndex() always return true
for frames that are not complete. When the image load completes, we
recompute metadata and correctly determine that the frame is opaque.
- platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameHasAlphaAtIndex):
- 9:06 AM Changeset in webkit [150339] by
-
- 2 edits in trunk/Source/WebCore
Simplify EventLoop::cycle() on Mac.
Reviewed by Anders Carlsson.
- platform/mac/EventLoopMac.mm:
(WebCore::EventLoop::cycle): Use CFRunLoopRunInMode instead.
- 9:06 AM Changeset in webkit [150338] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: getCTIStub should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=116126
Reviewed by Dan Bernstein.
It's called from the compilation thread. Give it locks.
- jit/JITThunks.cpp:
(JSC::JITThunks::ctiStub):
(JSC::JITThunks::hostFunctionStub):
- jit/JITThunks.h:
(JITThunks):
- 8:02 AM Changeset in webkit [150337] by
-
- 2 edits in trunk/Source/WebCore
Use CSSParserSelector::appendTagHistory() from CSS grammar.
<http://webkit.org/b/116382>
Reviewed by Antti Koivisto.
CSSParserSelector already knows how to append another component to itself,
no need to duplicate that logic in the grammar.
- css/CSSGrammar.y.in:
- 4:36 AM Changeset in webkit [150336] by
-
- 36 edits in trunk
[CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
https://bugs.webkit.org/show_bug.cgi?id=114554
Reviewed by Gyuyoung Kim.
Using variables as target names is very uncommon in CMake.
The usual way to specify the name of the resulting binary
is to set the OUTPUT_NAME target property.
.:
- CMakeLists.txt:
- Source/CMakeLists.txt:
- Source/PlatformEfl.cmake:
- Source/PlatformGTK.cmake:
- Source/cmake/OptionsBlackBerry.cmake:
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/WebKitHelpers.cmake:
- Source/cmake/gtest/CMakeLists.txt:
Source/JavaScriptCore:
- CMakeLists.txt:
- shell/CMakeLists.txt:
Source/WebCore:
- CMakeLists.txt:
Source/WebKit:
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
Source/WebKit/efl:
- ewebkit.pc.in:
Source/WebKit2:
- CMakeLists.txt:
- PlatformEfl.cmake:
- efl/ewebkit2.pc.in:
Source/WTF:
- wtf/CMakeLists.txt:
Tools:
- DumpRenderTree/efl/CMakeLists.txt:
- EWebLauncher/CMakeLists.txt:
- ImageDiff/CMakeLists.txt:
- MiniBrowser/efl/CMakeLists.txt:
- TestWebKitAPI/CMakeLists.txt:
- WebKitTestRunner/CMakeLists.txt:
- WebKitTestRunner/PlatformEfl.cmake:
- WinCELauncher/CMakeLists.txt:
- 2:14 AM Changeset in webkit [150335] by
-
- 6 edits in trunk
Unreviewed EFL build fix.
.:
Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
WK2 build after r150305.
- Source/cmake/OptionsEfl.cmake:
Tools:
Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
WK2 build after r150305.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
Skip indexeddb test cases as the feature is temporarily disabled due to
r150305.
- platform/efl/TestExpectations:
- 2:12 AM Changeset in webkit [150334] by
-
- 13 edits1 delete in trunk/Source
[GTK] Move GTK port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116221
Reviewed by Martin Robinson.
Source/WebCore:
Merge clipboard methods into PasteboardGtk that now wraps a
DataObjectGtk.
- GNUmakefile.list.am: Remove ClipboardGtk.h.
- dom/Clipboard.h: Remove GTK from the list of ports using legacy
clipboard.
- page/gtk/EventHandlerGtk.cpp:
(WebCore::EventHandler::createDraggingClipboard): Use
Clipboard::createForDragAndDrop().
- platform/Pasteboard.h:
(Pasteboard):
- platform/gtk/ClipboardGtk.cpp:
(WebCore::Editor::newGeneralClipboard): Use
Clipboard::createForCopyAndPaste().
(WebCore::Clipboard::createDragImage):
(WebCore::Clipboard::declareAndWriteDragImage):
- platform/gtk/ClipboardGtk.h: Removed.
- platform/gtk/DragDataGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::create): Create a new Pasteboard for a given
GtkClipboard or DataObjectGtk.
(WebCore::Pasteboard::createForCopyAndPaste): Create a Pasteboard
for the GDK_SELECTION_CLIPBOARD clipboard.
(WebCore::Pasteboard::createPrivate): Create a Pasteboard without
a GtkClipboard associated.
(WebCore::Pasteboard::createForDragAndDrop): Create a Pasteboard
for drag and drop operations.
(WebCore::selectionClipboard): Return a static Pasteboard for the
GDK_SELECTION_CLIPBOARD clipboard.
(WebCore::primaryClipboard): Return a static Pasteboard for the
GDK_SELECTION_PRIMARY clipboard.
(WebCore::Pasteboard::generalPasteboard): Return
selectionClipboard() or primaryClipboard() depending on whether
primary selection clipboard is the active one or not.
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::dataObject): Return the wrapped DataObjectGtk.
(WebCore::dataObjectTypeFromHTMLClipboardType): Copied from
ClipboardGtk.cpp.
(WebCore::Pasteboard::writeString): Adapted to upate the wrapped
DataObjectGtk and the GtkClipboard if needed.
(WebCore::Pasteboard::writeSelection): Ditto.
(WebCore::Pasteboard::writePlainText): Ditto.
(WebCore::Pasteboard::writeURL): Ditto.
(WebCore::Pasteboard::writeImage): Ditto.
(WebCore::Pasteboard::writePasteboard): Copy the wrapped
DataObjectGtk from the DataObjectGtk of the given Pasteboard and
upsate the GtkClipboard if needed.
(WebCore::Pasteboard::clear): Copied from ClipboardGtk.cpp.
(WebCore::Pasteboard::canSmartReplace): Check if current
GtkClipboard supports smart replace.
(WebCore::Pasteboard::setDragImage):
(WebCore::Pasteboard::documentFragment): Adapted to use the
wrapped DataObjectGtk reading from the current GtkClipboard if
present.
(WebCore::Pasteboard::plainText): Ditto.
(WebCore::Pasteboard::hasData): Copied from ClipboardGtk.cpp.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag): Get the DataObjectGtk from the
Pasteboard associated to the given Clipboard.
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp: Remove ClipboardGtk.h
include.
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag): Get the DataObjectGtk from the
Pasteboard associated to the given Clipboard.
- 1:51 AM Changeset in webkit [150333] by
-
- 20 edits in trunk/LayoutTests
Mac rebaseline after r148944.
- platform/mac/TestExpectations:
- platform/mac/fast/table/giantRowspan-expected.txt:
- platform/mac/fast/table/giantRowspan2-expected.png:
- platform/mac/fast/table/giantRowspan2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug220536-expected.png:
- platform/mac/tables/mozilla/bugs/bug220536-expected.txt:
- platform/mac/tables/mozilla/bugs/bug8858-expected.txt:
- platform/mac/tables/mozilla/core/bloomberg-expected.png:
- platform/mac/tables/mozilla/core/bloomberg-expected.txt:
- platform/mac/tables/mozilla/core/row_span-expected.png:
- platform/mac/tables/mozilla/core/row_span-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- 1:48 AM Changeset in webkit [150332] by
-
- 5 edits in trunk/Source/WebKit2
[EFL][WK2] Refactor ewk_view_custom_encoding_set/get API
https://bugs.webkit.org/show_bug.cgi?id=116386
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-18
Reviewed by Christophe Dumez.
Refactor the API to handle 'const char*' parameter in right way and
enable the unit test which was disabled in r136230 as there is no assertion now.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setCustomTextEncodingName):
- UIProcess/API/efl/EwkView.h:
(EwkView::customTextEncodingName):
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_custom_encoding_set):
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 1:39 AM Changeset in webkit [150331] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: [Mac] fast/js/post-message-numeric-property.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116388
Add a flaky test expectation.
- platform/mac/TestExpectations:
- 1:34 AM Changeset in webkit [150330] by
-
- 2 edits2 adds in trunk/LayoutTests
Mac Lion rebaselines after r149999 and r150260.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- platform/mac-lion/media/track: Added.
- platform/mac-lion/media/track/track-cue-rendering-vertical-expected.txt: Added.
- 1:17 AM Changeset in webkit [150329] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Unreviewed speculative build fix after r150305 and r150306.
- CMakeLists.txt:
- 1:11 AM Changeset in webkit [150328] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] REGRESSION(r150227): It made zillion tests crash under PlatformStrategiesQt::getPluginInfo
https://bugs.webkit.org/show_bug.cgi?id=116289
Patch by Tim Horton <timothy_horton@apple.com> on 2013-05-18
Reviewed by Csaba Osztrogonác.
Don't try to static cast something that isn't a ChromeClientQt to ChromeClientQt.
It's actually SVGImage's EmptyChromeClient-derived client (or other such things).
- WebCoreSupport/PlatformStrategiesQt.cpp:
(PlatformStrategiesQt::getPluginInfo):
- 12:33 AM Changeset in webkit [150327] by
-
- 3 edits in trunk/Source/WebKit2
[Qt][WK2] Unreviewed build fix after r150305 and r150306.
- DerivedSources.pri:
- Target.pri:
- 12:19 AM Changeset in webkit [150326] by
-
- 6 edits in trunk
[GTK] Parallel build fails if gtk-doc is enabled
https://bugs.webkit.org/show_bug.cgi?id=116227
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-18
Reviewed by Martin Robinson.
.:
- GNUmakefile.am:
Define an empty noinst_DATA variable where other automake files
can add additional objects to be built.
Source/WebCore:
- GNUmakefile.am:
Don't overwrite noinst_DATA, modify its existing value instead.
Tools:
- GNUmakefile.am:
Don't use the 'all' target to generate the documentation.
The prerequisites of this target must be files that need to be
built _before_ the actual compilation of WebKit starts. Since the
documentation depends on WebKit being built first, this means in
practice that the code will be built in parallel with the
generation of its dependencies, potentially making the build fail.
- 12:12 AM Changeset in webkit [150325] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK port after r150305 and r150306.
- GNUmakefile.list.am:
May 17, 2013:
- 9:50 PM Changeset in webkit [150324] by
-
- 2 edits in trunk/Tools
Don't run hg.
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest):
- 9:24 PM Changeset in webkit [150323] by
-
- 19 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Executable and CodeBlock should be aware of DFG::Plans that complete asynchronously
https://bugs.webkit.org/show_bug.cgi?id=116350
Reviewed by Oliver Hunt.
This refactors compilation so that:
- JITStubs knows exactly what the result of compilation was. For example, if compilation was deferred, it will now know this.
- The set of things that has to happen to install compiled code is now factored out into JSC::installOptimizedCode().
- A bunch of the code in Executable.cpp is now made more common to reduce code duplication. For example, the heap heuristics stuff is now in one place.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::ProgramCodeBlock::replaceWithDeferredOptimizedCode):
(JSC):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::replaceWithDeferredOptimizedCode):
(JSC::FunctionCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::replaceWithDeferredOptimizedCode):
(JSC::ProgramCodeBlock::jitCompileImpl):
(JSC::EvalCodeBlock::jitCompileImpl):
(JSC::FunctionCodeBlock::jitCompileImpl):
- bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::jitCompile):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):
- dfg/DFGDesiredIdentifiers.cpp:
(JSC::DFG::DesiredIdentifiers::numberOfIdentifiers):
(DFG):
(JSC::DFG::DesiredIdentifiers::at):
- dfg/DFGDesiredIdentifiers.h:
(JSC):
(DesiredIdentifiers):
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
(JSC::DFG::tryFinalizePlan):
(DFG):
- dfg/DFGDriver.h:
(DFG):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
(JSC::DFG::tryFinalizePlan):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::reallyAdd):
- dfg/DFGPlan.h:
(JSC):
(Plan):
(DFG):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeFunction):
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriateImpl):
(JSC::jitCompileFunctionIfAppropriateImpl):
(JSC):
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
- runtime/CompilationResult.cpp: Added.
(WTF):
(WTF::printInternal):
- runtime/CompilationResult.h: Added.
(JSC):
(WTF):
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::EvalExecutable::replaceWithDeferredOptimizedCode):
(JSC):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::ProgramExecutable::replaceWithDeferredOptimizedCode):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::replaceWithDeferredOptimizedCodeForCall):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::replaceWithDeferredOptimizedCodeForConstruct):
- runtime/Executable.h:
(ScriptExecutable):
(EvalExecutable):
(ProgramExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::compileOptimizedFor):
(JSC::FunctionExecutable::replaceWithDeferredOptimizedCodeFor):
(JSC::FunctionExecutable::jitCompileFor):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecutionImpl):
(JSC::prepareFunctionForExecutionImpl):
(JSC):
(JSC::installOptimizedCode):
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
(JSC::replaceWithDeferredOptimizedCode):
- 9:23 PM Changeset in webkit [150322] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13819878> Disable SharedWorker when in multiple web process model
https://bugs.webkit.org/show_bug.cgi?id=116359
The condition was accidentally negated, fixing.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::isAvailable):
- 9:11 PM Changeset in webkit [150321] by
-
- 2 edits in trunk/Source/WebCore
CSSParser parsing of CSSPropertyFontStretch falls into CSSPropertyGeometry
https://bugs.webkit.org/show_bug.cgi?id=116370
CSSPropertyFontStretch mistakenly fell through the shader parsing logic.
Reviewed by Alexandru Chiculita.
No new test possible, the feature is not implemented nor exposed.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- 8:12 PM Changeset in webkit [150320] by
-
- 2 edits in trunk/Source/WebCore
Force the script debug server to continue when disabling the debugger.
There might be some cases where the debugger will stay in the nested run loop
which cause weird issues.
Speculative fix for: https://webkit.org/b/111438
Reviewed by Joseph Pecoraro.
- inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::disable):
- 7:58 PM Changeset in webkit [150319] by
-
- 6 edits2 deletes in trunk/Source/WebCore
[BlackBerry] Get BlackBerry port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116287
Reviewed by Rob Buis.
- PlatformBlackBerry.cmake: Removed ClipboardBlackBerry.cpp.
- dom/Clipboard.h: Removed BLACKBERRY from the list of platforms that
use the legacy clipboard.
- editing/blackberry/EditorBlackBerry.cpp:
(WebCore::Editor::newGeneralClipboard): Changed to just create a copy
and paste clipboard.
- page/blackberry/EventHandlerBlackBerry.cpp: Removed a drag-related
function that wasn't doing any good.
- platform/blackberry/ClipboardBlackBerry.cpp: Removed.
- platform/blackberry/ClipboardBlackBerry.h: Removed.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::createForCopyAndPaste): Added.
(WebCore::Pasteboard::createPrivate): Added.
(WebCore::Pasteboard::hasData): Added. Moved code here from ClipboardBlackBerry.cpp.
(WebCore::Pasteboard::clear): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::writeString): Ditto.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.
- 7:56 PM Changeset in webkit [150318] by
-
- 4 edits in trunk/Source/WebCore
Ads on theverge.com cause repaints when hovered, even though content doesn't visibly change.
<http://webkit.org/b/116344>
Reviewed by Darin Adler.
Teach RenderStyle::diff() to ignore differences in the outline value if both styles have non-visible outlines.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
- rendering/style/StyleBackgroundData.cpp:
(WebCore::StyleBackgroundData::isEquivalentForPainting):
- rendering/style/StyleBackgroundData.h:
(StyleBackgroundData):
- 7:40 PM Changeset in webkit [150317] by
-
- 1 edit8 adds in trunk/Tools
Create a script to import W3C tests
https://bugs.webkit.org/show_bug.cgi?id=111513
Reviewed by Ryosuke Niwa.
This patch attempts to re-land the 'import-w3c-tests'
script and accompanying modules. The tests and code have
been cleaned up so that we do not log anything to stdout/stderr
while running the tests (thanks to outputcapture) and do not
write into the source tree while running the tests, and much
but not all of the code has been converted over to using the webkitpy
- Scripts/import-w3c-tests: Added.
- Scripts/webkitpy/w3c/init.py: Added.
- Scripts/webkitpy/w3c/test_converter.py: Added.
(W3CTestConverter):
(W3CTestConverter.init):
(W3CTestConverter.path_from_webkit_root):
(W3CTestConverter.read_webkit_prefixed_css_property_list):
(W3CTestConverter.convert_for_webkit):
(W3CTestConverter.convert_css):
(W3CTestConverter.convert_html):
(W3CTestConverter.convert_testharness_paths):
(W3CTestConverter.convert_prefixed_properties):
(W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
(W3CTestConverter.replace_tag):
- Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
(W3CTestConverterTest):
(W3CTestConverterTest.fake_dir_path):
(W3CTestConverterTest.test_read_prefixed_property_list):
(W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
(test_convert_for_webkit_harness_only):
(test_convert_for_webkit_properties_only):
(test_convert_for_webkit_harness_and_properties):
(test_convert_test_harness_paths):
(test_convert_prefixed_properties):
(verify_conversion_happened):
(verify_no_conversion_happened):
(verify_test_harness_paths):
(verify_prefixed_properties):
(generate_test_content):
- Scripts/webkitpy/w3c/test_importer.py: Added.
(main):
(parse_args):
(validate_import_directory):
(TestImporter):
(TestImporter.init):
(TestImporter.path_from_webkit_root):
(TestImporter.do_import):
(TestImporter.load_changeset):
(TestImporter.find_importable_tests):
(TestImporter.import_tests):
(TestImporter.setup_destination_directory):
(TestImporter.update_test_status):
(TestImporter.remove_deleted_files):
(TestImporter.write_import_log):
- Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
(TestImporterTest):
(TestImporterTest.test_import_dir_with_no_tests):
- Scripts/webkitpy/w3c/test_parser.py: Added.
(TestParser):
(TestParser.init):
(TestParser.load_file):
(TestParser.analyze_test):
(TestParser.reference_links_of_type):
(TestParser.is_jstest):
(TestParser.support_files):
- Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
(TestParserTest):
(TestParserTest.test_analyze_test_reftest_one_match):
(test_analyze_test_reftest_multiple_matches):
(test_analyze_test_reftest_match_and_mismatch):
(test_analyze_test_reftest_with_ref_support_Files):
(test_analyze_jstest):
(test_analyze_pixel_test_all_true):
(test_analyze_pixel_test_all_false):
(test_analyze_non_html_file):
- 7:28 PM Changeset in webkit [150316] by
-
- 2 edits in trunk/Source/WebCore
Plug leak in CSSSelectorList::deleteSelectors().
<http://webkit.org/b/116371>
<rdar://problem/13930698>
Reviewed by Ryosuke Niwa.
Don't forget to destroy the very last selector in the list.
- css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::deleteSelectors):
- 7:21 PM Changeset in webkit [150315] by
-
- 3 edits in trunk/LayoutTests
One more Mac rebaseline.
- platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
- platform/mac/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
- 6:13 PM Changeset in webkit [150314] by
-
- 12 edits in trunk/Source/WebKit2
Only allow 1 WebProcess to hold a PageCache
https://bugs.webkit.org/show_bug.cgi?id=116368
<rdar://problem/13392600>
Reviewed by Geoff Garen & Anders Carlson.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
(WebKit::WebContext::processDidSaveToPageCache):
(WebKit):
(WebKit::WebContext::disconnectProcess):
- UIProcess/WebContext.h:
- Added m_processWithPageCache, only allow one process to keep a PageCache.
(WebContext):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didSaveToPageCache):
(WebKit):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- Forward didSaveToPageCache to the WebProcessProxy.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::didSaveToPageCache):
(WebKit):
(WebKit::WebProcessProxy::releasePageCache):
- Forward releasePageCache to the WebProcess.
- Forward didSaveToPageCache to the WebContext.
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::didSaveToPageCache):
- Forward didSaveToPageCache to the WebPageProxy.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::releasePageCache):
(WebKit):
- WebProcess/WebProcess.h:
(WebProcess):
- WebProcess/WebProcess.messages.in:
- Added 'ReleasePageCache' to instruct a web process to drop any cached pages.
- 6:04 PM Changeset in webkit [150313] by
-
- 13 edits in trunk/Source
Share code between WebKit1 and WebKit2 StorageArea subclasses
https://bugs.webkit.org/show_bug.cgi?id=116367
Reviewed by Andreas Kling.
Source/WebCore:
- inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
Remove ec parameter.
- inspector/InspectorDOMStorageAgent.h:
Add forward declaration.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
Storage::StorageArea returns a reference now.
- storage/Storage.cpp:
(WebCore::Storage::length):
Check that the storage area can be accessed by the frame, and that it's not disabled by private browsing.
Then call down to the (now simplified) StorageArea::length().
(WebCore::Storage::isDisabledByPrivateBrowsing):
New helper function that's based on StorageAreaImpl::disabledByPrivateBrowsingInFrame, but reordered
to make it easier to follow.
- storage/Storage.h:
(WebCore::Storage::area):
Return a reference.
- storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::storageType):
Add this new virtual member funciton that's needed by Storage::isDisabledByPrivateBrowsing.
(WebCore::StorageAreaImpl::length):
Remove unneeded code.
Source/WebKit2:
- WebProcess/Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::length):
Remove code that's now in Storage::length.
(WebKit::StorageAreaImpl::storageType):
Make this a virtual member function.
- WebProcess/Storage/StorageAreaImpl.h:
- 5:51 PM Changeset in webkit [150312] by
-
- 101 edits in trunk/Source/WebCore
Unreviewed, rolling out r150294.
http://trac.webkit.org/changeset/150294
https://bugs.webkit.org/show_bug.cgi?id=116369
Caused 31 tests to fail (Requested by rniwa on #webkit).
- WebCore.exp.in:
- rendering/InlineFlowBox.h:
- rendering/InlineTextBox.h:
(InlineTextBox):
- rendering/RenderApplet.h:
- rendering/RenderBR.h:
- rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::virtualContinuation):
- rendering/RenderBox.h:
(WebCore::RenderBox::borderBoundingBox):
(RenderBox):
(WebCore::RenderBox::marginLogicalLeft):
(WebCore::RenderBox::marginLogicalRight):
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::isBoxModelObject):
- rendering/RenderButton.h:
- rendering/RenderCombineText.h:
- rendering/RenderCounter.h:
- rendering/RenderDeprecatedFlexibleBox.h:
- rendering/RenderDetailsMarker.h:
- rendering/RenderEmbeddedObject.h:
(RenderEmbeddedObject):
(WebCore::RenderEmbeddedObject::isEmbeddedObject):
(WebCore::RenderEmbeddedObject::virtualChildren):
- rendering/RenderFieldset.h:
- rendering/RenderFileUploadControl.h:
- rendering/RenderFlexibleBox.h:
- rendering/RenderFlowThread.h:
- rendering/RenderFrame.h:
- rendering/RenderFrameSet.h:
- rendering/RenderFullScreen.cpp:
- rendering/RenderFullScreen.h:
- rendering/RenderGrid.h:
- rendering/RenderHTMLCanvas.h:
- rendering/RenderIFrame.h:
- rendering/RenderImage.h:
(RenderImage):
(WebCore::RenderImage::isRenderImage):
- rendering/RenderInline.h:
(RenderInline):
(WebCore::RenderInline::virtualContinuation):
(WebCore::RenderInline::virtualChildren):
(WebCore::RenderInline::isRenderInline):
(WebCore::RenderInline::layout):
(WebCore::RenderInline::requiresLayer):
(WebCore::RenderInline::offsetWidth):
(WebCore::RenderInline::offsetHeight):
(WebCore::RenderInline::borderBoundingBox):
(WebCore::RenderInline::dirtyLinesFromChangedChild):
- rendering/RenderLayerModelObject.h:
- rendering/RenderListBox.h:
- rendering/RenderListItem.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.h:
(WebCore::RenderMedia::virtualChildren):
(WebCore::RenderMedia::canHaveChildren):
(WebCore::RenderMedia::isMedia):
(WebCore::RenderMedia::isImage):
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
- rendering/RenderMediaControlElements.h:
- rendering/RenderMenuList.h:
- rendering/RenderMeter.h:
- rendering/RenderMultiColumnBlock.h:
- rendering/RenderMultiColumnFlowThread.h:
- rendering/RenderMultiColumnSet.h:
- rendering/RenderNamedFlowThread.h:
- rendering/RenderPart.h:
(RenderPart):
(WebCore::RenderPart::isRenderPart):
(WebCore::RenderPart::renderName):
- rendering/RenderProgress.h:
- rendering/RenderRegion.h:
(WebCore::RenderRegion::isRenderRegion):
- rendering/RenderRegionSet.h:
- rendering/RenderReplaced.h:
(RenderReplaced):
(WebCore::RenderReplaced::renderName):
- rendering/RenderReplica.h:
- rendering/RenderRuby.h:
- rendering/RenderRubyBase.h:
- rendering/RenderRubyRun.h:
- rendering/RenderRubyText.h:
- rendering/RenderScrollbarPart.h:
- rendering/RenderSearchField.h:
- rendering/RenderSlider.h:
- rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn):
- rendering/RenderTable.h:
(RenderTable):
(WebCore::RenderTable::renderName):
(WebCore::RenderTable::isTable):
(WebCore::RenderTable::avoidsFloats):
- rendering/RenderTableCaption.h:
- rendering/RenderTableCell.h:
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
(RenderText):
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
(WebCore::RenderText::styleWillChange):
(WebCore::RenderText::length):
(WebCore::RenderText::paint):
(WebCore::RenderText::layout):
- rendering/RenderTextControl.h:
(RenderTextControl):
(WebCore::RenderTextControl::renderName):
(WebCore::RenderTextControl::isTextControl):
(WebCore::RenderTextControl::avoidsFloats):
- rendering/RenderTextControlMultiLine.h:
- rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine):
(WebCore::RenderTextControlSingleLine::isTextField):
- rendering/RenderTextFragment.h:
- rendering/RenderTextTrackCue.h:
- rendering/RenderVideo.h:
- rendering/RenderView.h:
- rendering/RenderWidget.h:
(RenderWidget):
(WebCore::RenderWidget::isWidget):
- rendering/RenderWordBreak.h:
- rendering/RootInlineBox.h:
(RootInlineBox):
- rendering/mathml/RenderMathMLBlock.h:
- rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
- rendering/svg/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::setNeedsBoundariesUpdate):
(WebCore::RenderSVGContainer::virtualChildren):
(WebCore::RenderSVGContainer::isSVGContainer):
(WebCore::RenderSVGContainer::renderName):
(RenderSVGContainer):
(WebCore::RenderSVGContainer::objectBoundingBox):
(WebCore::RenderSVGContainer::strokeBoundingBox):
(WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
- rendering/svg/RenderSVGEllipse.h:
- rendering/svg/RenderSVGForeignObject.h:
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGHiddenContainer.h:
(WebCore::RenderSVGHiddenContainer::renderName):
(RenderSVGHiddenContainer):
(WebCore::RenderSVGHiddenContainer::isSVGHiddenContainer):
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGInline.h:
(WebCore::RenderSVGInline::renderName):
(WebCore::RenderSVGInline::requiresLayer):
(WebCore::RenderSVGInline::isSVGInline):
(RenderSVGInline):
- rendering/svg/RenderSVGInlineText.h:
- rendering/svg/RenderSVGModelObject.h:
(WebCore::RenderSVGModelObject::requiresLayer):
(RenderSVGModelObject):
- rendering/svg/RenderSVGPath.h:
- rendering/svg/RenderSVGRect.h:
- rendering/svg/RenderSVGResourceClipper.h:
- rendering/svg/RenderSVGResourceContainer.h:
(RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::isSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::toRenderSVGResourceContainer):
- rendering/svg/RenderSVGResourceFilter.h:
- rendering/svg/RenderSVGResourceFilterPrimitive.h:
- rendering/svg/RenderSVGResourceGradient.h:
(RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::resourceBoundingBox):
- rendering/svg/RenderSVGResourceLinearGradient.h:
- rendering/svg/RenderSVGResourceMarker.h:
- rendering/svg/RenderSVGResourceMasker.h:
- rendering/svg/RenderSVGResourcePattern.h:
- rendering/svg/RenderSVGResourceRadialGradient.h:
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::setNeedsBoundariesUpdate):
(WebCore::RenderSVGShape::setNeedsTransformUpdate):
(WebCore::RenderSVGShape::repaintRectInLocalCoordinates):
(WebCore::RenderSVGShape::localToParentTransform):
(WebCore::RenderSVGShape::localTransform):
(WebCore::RenderSVGShape::isSVGShape):
(RenderSVGShape):
(WebCore::RenderSVGShape::objectBoundingBox):
(WebCore::RenderSVGShape::strokeBoundingBox):
- rendering/svg/RenderSVGTSpan.h:
- rendering/svg/RenderSVGText.h:
- rendering/svg/RenderSVGTextPath.h:
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/RenderSVGViewportContainer.h:
- 5:16 PM Changeset in webkit [150311] by
-
- 4 edits in trunk/Source/WebCore
Get rid of Custom code for Audio global constructor
https://bugs.webkit.org/show_bug.cgi?id=116343
Reviewed by Geoffrey Garen.
Remove custom code for Audio global constructor. It is no longer needed
now that the the bindings generator no longer require custom code for
named constructors and now that [EnabledAtRuntime] extended attribute is
supported for global constructors.
HTMLAudioElement global constructors are now automatically generated.
No new tests, no behavior change for layout tests.
- bindings/js/JSDOMWindowCustom.cpp:
- html/HTMLAudioElement.idl:
- page/DOMWindow.idl:
- 5:05 PM Changeset in webkit [150310] by
-
- 8 edits in trunk/Source
<rdar://problem/13819878> Disable SharedWorker when in multiple web process model
https://bugs.webkit.org/show_bug.cgi?id=116359
Reviewed by Anders Carlsson.
This feature was already RuntimeEnabled. Call through layers to get the answer from
a platform strategy.
- workers/DefaultSharedWorkerRepository.cpp: (WebCore::DefaultSharedWorkerRepository::isAvailable):
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorkerRepository.cpp: (WebCore::SharedWorkerRepository::isAvailable):
- workers/SharedWorkerStrategy.h: (WebCore::SharedWorkerStrategy::isAvailable):
- 4:45 PM Changeset in webkit [150309] by
-
- 3 edits in trunk/Source/WebCore
Move Storage member functions out of line
https://bugs.webkit.org/show_bug.cgi?id=116364
Reviewed by Andreas Kling.
This is preparation for sharing more code between the WebKit1 and WebKit2 storage area subclasses.
Also remove unnecessary null checks and make m_storageArea const.
- storage/Storage.cpp:
(WebCore::Storage::length):
(WebCore::Storage::key):
(WebCore::Storage::getItem):
(WebCore::Storage::setItem):
(WebCore::Storage::removeItem):
(WebCore::Storage::clear):
(WebCore::Storage::contains):
- storage/Storage.h:
(WebCore::Storage::area):
- 4:35 PM Changeset in webkit [150308] by
-
- 2 edits in trunk/Source/WTF
Re-align the OS(AIX) macro...
...in the hopes that the resulting world rebuild will fix failures after r150294.
- wtf/Platform.h:
- 4:13 PM Changeset in webkit [150307] by
-
- 14 edits in trunk/Source
Headers and footers will sometimes disappear and re-appear during page loads
https://bugs.webkit.org/show_bug.cgi?id=116336
-and corresponding-
<rdar://problem/13886753>
Reviewed by Simon Fraser.
This patch changes the WebCore-level API that WebKit uses to create a banner.
Specifically this patch removes FrameView::setWantsLayerForHeader(), which created
and returned a layer. Instead, WK2 will call Page::addHeaderWithHeight(). When the
layer has been created, it will call back into WK2 via ChromeClient. This will
allow WebCore to re-create the header/footer layers as needed whenever the
FrameView/RenderLayerCompositor have been destroyed and recreated.
Source/WebCore:
Remove references to old FrameView functions. Add references to new Page
functions.
- WebCore.exp.in:
New ChromeClient functions will pass the new layers up to WK2.
- page/ChromeClient.h:
(WebCore::ChromeClient::didAddHeaderLayer):
(WebCore::ChromeClient::didAddFooterLayer):
(ChromeClient):
Remove setWantsLayerForHeader/Footer.
- page/FrameView.cpp:
- page/FrameView.h:
(FrameView):
Page now caches the header and footer height. When the FrameView/RLC have been
destroyed, and the cached layer/height information on those classes has been lost,
this data on Page will persist so that we can build the layers back up.
- page/Page.cpp:
(WebCore::Page::Page):
(WebCore::Page::addHeaderWithHeight):
(WebCore::Page::addFooterWithHeight):
- page/Page.h:
(WebCore::Page::headerHeight):
(WebCore::Page::footerHeight):
As soon as the root gets a backing, recreate the header and footer layers if
needed.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateBacking):
Call into ChromeClient.
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
Source/WebKit2:
Send the layers over to PageBanner.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::didAddHeaderLayer):
(WebKit::WebChromeClient::didAddFooterLayer):
- WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
PageBanner::addToPage() now does much less work since it can’t get the parent
layer right away. The work that is used to do once it had the parent layer is now
performed in didAddParentLayer()
- WebProcess/WebPage/PageBanner.cpp:
(WebKit::PageBanner::didAddParentLayer):
- WebProcess/WebPage/PageBanner.h:
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::addToPage):
(WebKit::PageBanner::didAddParentLayer):
- 4:13 PM Changeset in webkit [150306] by
-
- 6 edits2 moves in trunk/Source/WebKit2
Rename WebKeyValueStorageManagerProxy to WebKeyValueStorageManager
https://bugs.webkit.org/show_bug.cgi?id=116361
Reviewed by Andreas Kling.
There's nothing proxy about this class anymore!
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKKeyValueStorageManager.cpp:
- UIProcess/WebKeyValueStorageManager.cpp: Renamed from Source/WebKit2/UIProcess/WebKeyValueStorageManagerProxy.cpp.
- UIProcess/WebKeyValueStorageManager.h: Renamed from Source/WebKit2/UIProcess/WebKeyValueStorageManagerProxy.h.
- WebKit2.xcodeproj/project.pbxproj:
- 4:06 PM Changeset in webkit [150305] by
-
- 7 edits4 deletes in trunk/Source/WebKit2
Remove dead local storage code
https://bugs.webkit.org/show_bug.cgi?id=116360
Reviewed by Beth Dakin.
Storage is all handled in the UI process now so we no longer need a WebKeyValueStorageManager in the web process.
- DerivedSources.make:
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit):
(WebKit::didGetKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebKeyValueStorageManagerProxy.messages.in: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/Storage/WebKeyValueStorageManager.cpp: Removed.
- WebProcess/Storage/WebKeyValueStorageManager.h: Removed.
- WebProcess/Storage/WebKeyValueStorageManager.messages.in: Removed.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
- 3:59 PM Changeset in webkit [150304] by
-
- 11 edits in trunk/Source/WebKit2
Use the UI process storage manager for deleting local storage data
https://bugs.webkit.org/show_bug.cgi?id=116358
<rdar://problem/13852829>
Reviewed by Andreas Kling.
- Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::protocol):
(WebKit::WebSecurityOrigin::host):
(WebKit::WebSecurityOrigin::databaseIdentifier):
(WebKit::WebSecurityOrigin::toString):
Remove unneeded consts.
(WebKit::WebSecurityOrigin::securityOrigin):
Add getter.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::close):
deleteEmptyDatabaseWithOrigin has been renamed to deleteDatabaseWithOrigin.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::deleteDatabaseWithOrigin):
Rename since this is no longer used only for empty databases.
(WebKit::LocalStorageDatabaseTracker::deleteAllDatabases):
Loop over the tracker database and delete all database files.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::clear):
Clear the map, close the database and tell all event listeners to reset their caches.
(WebKit::StorageManager::LocalStorageNamespace::clearStorageAreasMatchingOrigin):
Loop over all storage areas and call clear on those matching the security origin.
(WebKit::StorageManager::LocalStorageNamespace::clearAllStorageAreas):
Loop over all storage areas and call clear on them.
(WebKit::StorageManager::deleteEntriesForOrigin):
Dispatch deleteEntriesForOriginInternal on the work queue.
(WebKit::StorageManager::deleteAllEntries):
Dispatch deleteAllEntriesInternal on the work queue.
(WebKit::StorageManager::deleteEntriesForOriginInternal):
Call clearStorageAreasMatchingOrigin on all local storage namespaces and then delete the database.
(WebKit::StorageManager::deleteAllEntriesInternal):
Call clearAllStorageAreas on all local storage namespaces and then delete all databases.
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
Call out to the storage manager.
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):
Ditto.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::clearCache):
Call resetValues which will null out the storage map.
- WebProcess/Storage/StorageAreaMap.messages.in:
Add ClearCache message.
- 3:06 PM Changeset in webkit [150303] by
-
- 3 edits in trunk/Tools
Leaks builders exit early frequently
https://bugs.webkit.org/show_bug.cgi?id=116355
Reviewed by Stephanie Lewis.
Throttle the number of processes to use, and also bump up the number of crashes/timeouts
we tolerate from 20 to 50.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start):
- Scripts/webkitpy/port/mac.py:
(MacPort.default_child_processes):
- 3:02 PM WebKitIDL edited by
- Add link to RuntimeEnabledFeatures header. (diff)
- 2:54 PM WebKitIDL edited by
- Add documentation for [EnabledAtRuntime] introduced in r150276 (diff)
- 2:53 PM Changeset in webkit [150302] by
-
- 2 edits in trunk/Source/WebCore
[CSS] Minor cleanups in CSS variables handling
https://bugs.webkit.org/show_bug.cgi?id=116318
Reviewed by Ryosuke Niwa.
No new tests, only a cleanup.
- css/CSSParser.cpp:
(WebCore::CSSParserString::substring): Optimize.
(WebCore::CSSParser::createPrimitiveVariableNameValue):
Remove intermediate variable.
- 2:51 PM Changeset in webkit [150301] by
-
- 2 edits in trunk/Source/WebKit2
Only import local storage items from the database once
https://bugs.webkit.org/show_bug.cgi?id=116354
Reviewed by Andreas Kling.
We import items from the database over and over, when we only want to do it once. Use a
boolean flag to guard against doing it more than once.
Also, rename importItemsFromDatabase to openDatabaseAndImportItemsIfNeeded since it now
also opens the database (even if it doesn't need to import anything). This is preparation for an
upcoming patch where the database will be closed when it's cleared.
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
(WebKit::StorageManager::StorageArea::removeItem):
(WebKit::StorageManager::StorageArea::clear):
(WebKit::StorageManager::StorageArea::items):
(WebKit::StorageManager::StorageArea::openDatabaseAndImportItemsIfNeeded):
- 2:41 PM WebKitIDL edited by
- Remove [ConstructorParameters] due to r150292 (diff)
- 2:41 PM Changeset in webkit [150300] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Add DOMWindowConstructors.idl to Xcode project file
https://bugs.webkit.org/show_bug.cgi?id=116351
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj: Added the file, so that Xcode includes it in searches.
- 2:26 PM Changeset in webkit [150299] by
-
- 4 edits in tags/Safari-537.42.1/Source
Versioning.
- 2:23 PM Changeset in webkit [150298] by
-
- 1 copy in tags/Safari-537.42.1
New Tag.
- 2:17 PM Changeset in webkit [150297] by
-
- 2 edits in trunk/Source/WebCore
Remove the declaration of Element::detachAttrNodeAtIndex erroneously added in r150072.
- dom/Element.h:
(Element):
- 1:51 PM Changeset in webkit [150296] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13869765> Lion: Crashes in islcCanLoadInputMethodFromBundleID.
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in: Allow text input directories.
- 1:41 PM Changeset in webkit [150295] by
-
- 10 edits in trunk/Source
WKKeyValueStorageManagerGetKeyValueStorageOrigins should get origins from the UI process
https://bugs.webkit.org/show_bug.cgi?id=116346
<rdar://problem/13852829>
Reviewed by Andreas Kling.
Source/WebCore:
Export the UTF8Encoding symbol.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::origins):
New helper function to return all the tracked origins.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageManager):
Initialize the UTF-8 encoding.
(WebKit::StorageManager::getOrigins):
Call getOriginsInternal on our queue.
(WebKit::callCallbackFunction):
Helper function for calling the callback function.
(WebKit::StorageManager::getOriginsInternal):
Get the origins and make sure we call the callback with the given function dispatcher.
- UIProcess/WebKeyValueStorageManagerProxy.cpp:
(WebKit::didGetKeyValueStorageOriginsCallback):
Construct the array of WebSecurityOrigin objects and call the callback.
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
Call StorageManager::getOrigins.
Source/WTF:
Add forward declaration for Function.
- wtf/Forward.h:
- 1:32 PM Changeset in webkit [150294] by
-
- 101 edits in trunk/Source/WebCore
Apply FINAL to the RenderObject hierarchy.
<http://webkit.org/b/115977>
Mostly from Blink r148795 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=148795>
Re-landing without devirtualization tweaks.
- rendering/: Beat things with the FINAL stick.
- WebCore.exp.in: Export a now-needed symbol.
- 1:17 PM Changeset in webkit [150293] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::willTransitionToCommitted): Frame:editor() now returns a reference.
- 1:05 PM Changeset in webkit [150292] by
-
- 17 edits in trunk/Source/WebCore
Get rid of [ConstructorParameters] extended attributes
https://bugs.webkit.org/show_bug.cgi?id=116308
Reviewed by Kentaro Hara.
Get rid of WebKit-specific [ConstructorParameters] IDL extended attribute. Instead,
[CustomConstructor] arguments are now explicitly specified, similarly to [Constructor]
arguments and the constructor object's "length" property is now automatically
computed for custom constructors as well.
This is less error-prone as the value is not hardcoded, more consistent with
[Constructor] extended attribute and gives more information about the custom constructor
in the IDL file. We also get rid of a WebKit-specific IDL attribute which is always
nice.
No new tests, already covered by fast/js/constructor-length.html.
- Modules/mediastream/MediaStream.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/websockets/WebSocket.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorHelperMethods):
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/IDLParser.pm:
(applyTypedefs):
(parseAttributeRest):
(copyExtendedAttributes):
(parseExtendedAttributeRest):
(applyExtendedAttributeList):
- bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64ArrayConstructor::finishCreation):
- bindings/scripts/test/TestTypedArray.idl:
- dom/MutationObserver.idl:
- fileapi/Blob.idl:
- html/DOMFormData.idl:
- html/canvas/ArrayBuffer.idl:
- html/canvas/DataView.idl:
- page/WebKitPoint.idl:
- workers/SharedWorker.idl:
- workers/Worker.idl:
- 1:04 PM Changeset in webkit [150291] by
-
- 13 edits5 adds in trunk
Text input is largely broken when there are subframes loading
http://bugs.webkit.org/show_bug.cgi?id=59121
<rdar://problem/9320468>
Reviewed by Darin Adler.
- UIProcess/PageClient.h:
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::updateSecureInputState): Separated secure input state updating into a separate function. Removed updateTextInputState, we don't need to go through PageClient to implement its behavior at all. (WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added a FIXME.
- UIProcess/API/mac/WKView.mm:
- UIProcess/API/mac/WKViewInternal.h: Removed _updateTextInputStateIncludingSecureInputState.
- UIProcess/WebPageProxy.h: Added m_temporarilyClosedComposition, which helps to figure out that WebCore decided to close a composition. The issue is that WebCore would first send an EditorState with hasComposition set to false, and with shouldIgnoreCompositionSelectionChange set to true, at which time we forget the previous m_editorState, but can't make any decisions based on this transient state. We should find a way to simplify this (maybe not send these updates with shouldIgnoreCompositionSelectionChange at all?)
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Initialize m_temporarilyClosedComposition. (WebKit::WebPageProxy::didCommitLoadForFrame): Removed the code to kill a composition when any frame commits a load, which made no sense (along with surrounding code, which will unfortunately survive longer). (WebKit::WebPageProxy::editorStateChanged): Implemented state updating here, we don't need to go to WKView.mm to implement this logic. Figure out when WebCore discards a composition, and notify input methods about this. (WebKit::WebPageProxy::resetStateAfterProcessExited): Reset m_temporarilyClosedComposition. Added some FIXMEs.
- 12:54 PM Changeset in webkit [150290] by
-
- 15 edits in trunk/LayoutTests
Mac rebaselines; also remove some entries.
Seriously, I've had it enough. Why are people adding these entires never to rebaseline them later?
- platform/mac/TestExpectations:
- platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt:
- platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
- platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
- platform/mac/fast/encoding/utf-16-big-endian-expected.png:
- platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
- platform/mac/fast/encoding/utf-16-little-endian-expected.png:
- platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
- platform/mac/fast/forms/input-value-expected.png:
- platform/mac/fast/forms/input-value-expected.txt:
- platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png:
- platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
- platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
- 12:50 PM Changeset in webkit [150289] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Add support for selectTrailingWhitespaceEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=112426
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-17
Reviewed by Ryosuke Niwa.
- Shared/WebPreferencesStore.h:
(WebKit): Add macro for selectTrailingWhitespaceEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSelectTrailingWhitespaceEnabled):
(WKPreferencesGetSelectTrailingWhitespaceEnabled): Implement methods
using the new setting.
- UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::isSelectTrailingWhitespaceEnabled): Implement
method delegating in WebPage.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set
selectTrailingWhitespaceEnabled setting.
(WebKit::WebPage::setSmartInsertDeleteEnabled): Set
selectTrailingWhitespaceEnabled as they are mutually exclusive.
(WebKit):
(WebKit::WebPage::isSelectTrailingWhitespaceEnabled): Implement method
using settings.
(WebKit::WebPage::setSelectTrailingWhitespaceEnabled): Implement method
using settings and set smartInsertDeleteEnabled as they are mutually
exclusive.
- WebProcess/WebPage/WebPage.h:
(WebPage): Add new methods headers.
- 12:49 PM Changeset in webkit [150288] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash introduced by http://trac.webkit.org/changeset/150282
Followup to https://bugs.webkit.org/show_bug.cgi?id=116253
Reviewed by Andreas Kling.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedFrameChanged): Frame might be null.
- 12:47 PM Changeset in webkit [150287] by
-
- 3 edits4 deletes in trunk/Tools
Remove chrome-channels command from the webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=116303
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-17
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
- Scripts/webkitpy/common/net/omahaproxy.py: Removed.
- Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
- Scripts/webkitpy/tool/commands/init.py: Removed chromechannels import.
- Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
- Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
- 12:33 PM Changeset in webkit [150286] by
-
- 3 edits in trunk/Tools
filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
Part 3 of 3: <http://webkit.org/b/116247>
Reviewed by Benjamin Poulain.
- Scripts/filter-build-webkit: Change while() loop to for() loop
to track $previousLine, then pass $previousLine into
shouldIgnoreLine().
(shouldIgnoreLine): Add $previousLine argument. Do not skip a
line that begins with four spaces if the previous line is a
linker error message.
- Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
- Add "Ignored: " to test descriptions to document expected behavior.
- Add comment blocks for various groups of tests.
- Expand "Build settings" tests since we're changing the code in shouldIgnoreLine() that ignores those lines.
- Add tests for undefined symbols error message.
(description): Add. Extract from global code.
- 12:33 PM Changeset in webkit [150285] by
-
- 2 edits2 adds in trunk/Tools
Add tests for shouldIgnoreLine() in filter-build-webkit
Part 2 of 3: <http://webkit.org/b/116247>
Reviewed by Benjamin Poulain.
- Scripts/filter-build-webkit:
(shouldIgnoreLine): Add. Extract code from global scope into
subroutine to make it testable.
- Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
Tests shouldIgnoreLine() using output from a real build
transcript.
- 12:24 PM Changeset in webkit [150284] by
-
- 2 edits in trunk/Tools
Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=116341
Reviewed by Brady Eidson.
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 12:17 PM Changeset in webkit [150283] by
-
- 8 edits in trunk/Source/WebCore
Get rid of [CustomGetter] for global named constructors
https://bugs.webkit.org/show_bug.cgi?id=116116
Reviewed by Geoffrey Garen.
Improve the JSC bindings generator so that global named constructors no longer
require a [CustomGetter] IDL extended attribute. As a consequence, attributes
on the global window object can now be automatically generated for interfaces
that have a [NamedConstructor], namely HTMLOptionElement.
The HTMLAudioElement global constructors are still manually defined because it
requires custom code at the moment to check if the media player is available.
No new tests, no behavior change.
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/scripts/preprocess-idls.pl:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
- html/HTMLOptionElement.idl:
- page/DOMWindow.idl:
- 12:15 PM Changeset in webkit [150282] by
-
- 14 edits in trunk/Source/WebKit2
Replace WebFrameLoaderClient static_casts with a function that might return null.
https://bugs.webkit.org/show_bug.cgi?id=116253
The general approach here is:
1 - Introduce a toWebFrameLoaderClient() function to convert FrameLoaderClients, and that may return null.
2 - Adopt toWebFrameLoaderClient() everywhere we used to do a direct static_cast<WebFrameLoaderClient*>
3 - In functions that already support a "return 0" scenario, a failed cast results in a return 0.
4 - In other functions that assume no failure to get the WebFrameLoaderClient, add an ASSERT.
Reviewed by Alexey Proskuryakov.
Add the utility function to cast:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebKit::toWebFrameLoaderClient):
Adopt it everywhere:
- WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::documentFrame):
(WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
(WebKit::InjectedBundleDOMWindowExtension::frame):
- WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::frame):
(WebKit::InjectedBundleHitTestResult::targetFrame):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::webPage):
(WebKit::PluginView::performFrameLoadURLRequest):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedNodeChanged):
(WebKit::WebChromeClient::focusedFrameChanged):
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::runOpenPanel):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::contentsAsString):
(WebKit::WebFrame::parentFrame):
(WebKit::WebFrame::childFrames):
(WebKit::WebFrame::frameForContext):
(WebKit::WebFrameFilter::shouldIncludeSubframe):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mainFrameHasCustomRepresentation):
- 12:06 PM Changeset in webkit [150281] by
-
- 2 edits in trunk/Tools
[Windows] Don't use pdevenv when building with VS2010.
https://bugs.webkit.org/show_bug.cgi?id=116338.
Reviewed by Adam Roben.
- Scripts/webkitdirs.pm:
(setupCygwinEnv): Check if we are using VS2005, and only use
the 'pdevenv' hack if we are. Otherwise, just build with
our standard project since it uses VS2010+'s native
parallel building features.
- 11:49 AM Changeset in webkit [150280] by
-
- 3 edits2 adds in trunk
Web Inspector: SyntaxError evaluating "1+1; @ sourceURL=test" in console
https://bugs.webkit.org/show_bug.cgi?id=116292
Source/WebCore:
Add a newline after the expression so a single line comment doesn't
erroneously comment out the closing brace of the with block.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-17
Reviewed by Timothy Hatcher.
Test: inspector/console/console-eval-comment.html
- inspector/InjectedScriptSource.js:
LayoutTests:
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-17
Reviewed by Timothy Hatcher.
- inspector/console/console-eval-comment-expected.txt: Added.
- inspector/console/console-eval-comment.html: Added.
- 11:42 AM Changeset in webkit [150279] by
-
- 1 edit in trunk/LayoutTests/platform/mac/TestExpectations
- 11:41 AM Changeset in webkit [150278] by
-
- 2 edits in trunk/Source/WebCore
fast/flexbox/auto-height-with-flex.html failing only on release builds.
https://bugs.webkit.org/show_bug.cgi?id=116240
Reviewed by Darin Adler.
Fix the mainAxisContentExtent method so no overflow occurs, since it
doesn't work right on release builds.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
- 11:28 AM Changeset in webkit [150277] by
-
- 6 edits3 adds in trunk/Source/WebKit2
Expose new load-with-userData API to Objective-C
https://bugs.webkit.org/show_bug.cgi?id=116335
Reviewed by Anders Carlsson.
- Adds loadRequest:userData:, loadFileURL:restrictToFilesWithin:userData:, loadHTMLString:baseURL:userData: loadData:MIMEType:textEncodingName:baseURL:, and loadData:MIMEType:textEncodingName:baseURL:userData.
- Adds a WKObjCTypeWrapperRef (which is a ObjCObjectGraph under the covers) to allow the userData to be unwrapped in the injected bundles willLoadURLRequest and willLoadDataRequest C-SPI callbacks.
- Shared/API/c/WKBase.h:
- Shared/API/c/WKSharedAPICast.h:
- Shared/API/c/mac/WKBaseMac.h: Added.
- Shared/API/c/mac/WKObjCTypeWrapperRef.h: Added.
- Shared/API/c/mac/WKObjCTypeWrapperRef.mm: Added.
(WKObjCTypeWrapperGetTypeID):
(WKObjCTypeWrapperCreate):
(WKObjCTypeWrapperGetObject):
- UIProcess/API/mac/WKBrowsingContextController.h:
- UIProcess/API/mac/WKBrowsingContextController.mm:
(+[WKBrowsingContextController registerSchemeForCustomProtocol:]):
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]):
(-[WKBrowsingContextController loadRequest:]):
(-[WKBrowsingContextController loadRequest:userData:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:]):
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:]):
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
- WebKit2.xcodeproj/project.pbxproj:
- 11:16 AM Changeset in webkit [150276] by
-
- 16 edits1 delete in trunk/Source/WebCore
Add [EnabledAtRuntime] extended attribute support for global constructors
https://bugs.webkit.org/show_bug.cgi?id=116147
Reviewed by Geoffrey Garen.
Add [EnabledAtRuntime] extended attribute support for global constructors.
This patch adds [EnabledAtRuntime] extended attribute to SharedWorker and
WebSocket IDL interfaces so that their global constructors on the global
Window object can now be automatically generated.
The behavior on JavaScript side is unchanged. We simply leverage
RuntimeEnabledFeatures class and the new [EnabledAtRuntime] IDL extended
attribute to generate the code for global constructors getters instead
of using custom code.
No new tests, no behavior change for layout tests.
- GNUmakefile.list.am:
- Modules/websockets/WebSocket.cpp: Enable WebSockets at runtime by default.
- Modules/websockets/WebSocket.idl:
- Target.pri:
- UseJSC.cmake:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore):
- bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed.
- bindings/scripts/CodeGeneratorJS.pm:
(ToMethodName):
(GetRuntimeEnableFunctionName):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.idl:
- workers/SharedWorker.idl:
- 11:02 AM Changeset in webkit [150275] by
-
- 4 edits in trunk
Unreviewed. Skip webgl and transforms/3d tests again, until we find out why they do
not run in the release bot.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-17
- platform/gtk/TestExpectations:
Tools
- Tools/DumpRenderTree/gtk/DumpRenderTree.cpp: Disable accelerated compositing until we figure
out why it does not work properly in the 64 bits release bot.
- 10:43 AM Changeset in webkit [150274] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents
https://bugs.webkit.org/show_bug.cgi?id=116305
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-17
Reviewed by Rob Buis.
PR 340537.
Internally reviewed by Arvid Nilsson.
Use updateLayoutAndStyleIfNeededRecursive() instead of
layoutIfNeeded() since we are about to draw in
rootLayerCommitTimerFired().
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- 10:40 AM Changeset in webkit [150273] by
-
- 2 edits in trunk/Source/WebKit/mac
Accessing null function pointers is bad.
- WebCoreSupport/WebFrameLoaderClient.mm:
- 10:34 AM Changeset in webkit [150272] by
-
- 2 edits in trunk/Tools
Make filter-build-webkit testable using LoadAsModule
Part 1 of 3: <http://webkit.org/b/116247>
Reviewed by Benjamin Poulain.
- Scripts/filter-build-webkit: Change global variables that are
used in subroutines from 'my' to 'our' to make it possible to
evaluate the script in a package context in LoadAsModule.pm.
- 10:30 AM Changeset in webkit [150271] by
-
- 8 edits in trunk/Source/WebKit2
Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbitrary data blobs
https://bugs.webkit.org/show_bug.cgi?id=116325
Reviewed by Simon Fraser.
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadData):
(WKPageLoadDataWithUserData):
Add new SPI.
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
- UIProcess/WebPageProxy.h:
Pipe through to the WebProcess.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::loadData):
(WebKit::WebPage::loadHTMLString):
(WebKit::WebPage::loadAlternateHTMLString):
(WebKit::WebPage::loadPlainTextString):
(WebKit::WebPage::loadWebArchiveData):
Rename existing loadData function to loadDataImpl (I hate it) to avoid overload conflict
from IPC magic.
- 10:25 AM Changeset in webkit [150270] by
-
- 1 edit in trunk/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm
Fix Release builds.
- 9:57 AM Changeset in webkit [150269] by
-
- 2 edits in trunk/Source/WebKit/mac
Make kit(Frame*) more robust
https://bugs.webkit.org/show_bug.cgi?id=116324
Reviewed by Darin Adler.
Check that the frame loader's client isn't the EmptyFrameLoaderClient (or a subclass thereof)
before casting to WebFrameLoaderClient.
- WebView/WebFrame.mm:
(kit):
- 9:57 AM Changeset in webkit [150268] by
-
- 5 edits1 delete in trunk/Source/WebCore
[EFL] Move EFL port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116181
Reviewed by Anders Carlsson.
- dom/Clipboard.h: Switched EFL away from "legacy" mode for Clipboard.
- page/efl/EventHandlerEfl.cpp:
(WebCore::EventHandler::createDraggingClipboard): Changed to call Clipboard member function.
- platform/efl/ClipboardEfl.cpp: Deleted most of the functions.
(WebCore::Editor::newGeneralClipboard): Changed to call Clipboard member function.
(WebCore::Clipboard::createDragImage): Moved from ClipboardEfl to Clipboard.
(WebCore::Clipboard::declareAndWriteDragImage): Moved from ClipboardEfl to Clipboard.
(WebCore::Clipboard::items): Ditto.
- platform/efl/PasteboardEfl.cpp: A lot of copyright notices for a file that
has no code in it other than notImplemented lines! I didn't add a new one.
(WebCore::Pasteboard::createForCopyAndPaste): Added.
(WebCore::Pasteboard::createPrivate): Added.
(WebCore::Pasteboard::createForDragAndDrop): Added.
(WebCore::Pasteboard::hasData): Added.
(WebCore::Pasteboard::readString): Added.
(WebCore::Pasteboard::writeString): Added.
(WebCore::Pasteboard::types): Added.
(WebCore::Pasteboard::readFilenames): Added.
(WebCore::Pasteboard::setDragImage): Added.
(WebCore::Pasteboard::writePasteboard): Added.
- 9:53 AM Changeset in webkit [150267] by
-
- 2 edits in trunk/Source/WebKit2
[EFL][WK2] Fix sub menu initialization in ewk_context_menu_item
https://bugs.webkit.org/show_bug.cgi?id=116321
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-17
Reviewed by Christophe Dumez.
During sub menu creation, after initializing m_parentMenu, parentMenu
pointer became null which may cause segfaults. This patch fixes it by
using m_parentMenu.
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
- 9:47 AM Changeset in webkit [150266] by
-
- 3 edits in trunk/Source/WebKit/mac
Move the policy function to WebFramePolicyListener
https://bugs.webkit.org/show_bug.cgi?id=116323
Reviewed by Darin Adler.
There's no need for the WebFrameLoaaderClient to hold on to the policy function,
so move it to WebFramePolicyListener. This gets rid of another WebFrameLoaderClient cast.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setUpPolicyListener):
Pass the policy function when creating the WebFramePolicyListener object.
- 9:34 AM Changeset in webkit [150265] by
-
- 3 edits in trunk/Source/WebKit/mac
WebFramePolicyListener should keep its Frame in a RefPtr
https://bugs.webkit.org/show_bug.cgi?id=116322
Reviewed by Darin Adler.
- WebCoreSupport/WebFrameLoaderClient.mm:
(-[WebFramePolicyListener initWithWebCoreFrame:]):
No need to ref the frame, the RefPtr does that for us.
(-[WebFramePolicyListener invalidate]):
Just set the frame to null.
(-[WebFramePolicyListener dealloc]):
Remove call to deref, that's done automatically now.
(-[WebFramePolicyListener finalize]):
Remove this method. (We could have kept it just for the assertion but I didn't think that was necessary).
(-[WebFramePolicyListener receivedPolicyDecision:):
Use release() to transfer ownership.
- 9:26 AM Changeset in webkit [150264] by
-
- 3 edits2 adds in trunk
Bad spacing inside MathML formulas when text-indent is specified
https://bugs.webkit.org/show_bug.cgi?id=106600
Patch by Frédéric Wang <fred.wang@free.fr> on 2013-05-17
Reviewed by Martin Robinson.
Source/WebCore:
When MathML is used in a HTML page that modifies the CSS text-indent,
large gaps appear inside the mathematical expressions. Resetting it to
0 on the math root (as Gecko does) fixes the issue.
Tests: mathml/presentation/text-indent.html
mathml/presentation/text-indent-expected.html
- css/mathml.css:
(math): reset text-indent to its default value.
LayoutTests:
New test to verify that the text-indent property is reset to 0 on
the MathML root.
- mathml/presentation/text-indent-expected.html: Added.
- mathml/presentation/text-indent.html: Added.
- 9:07 AM Changeset in webkit [150263] by
-
- 4 edits in trunk/Source/WebCore
Fix code that expects Page::chrome() to return a pointer
https://bugs.webkit.org/show_bug.cgi?id=116313
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-17
Reviewed by Darin Adler.
Page::chrome() returns a reference after r150214.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setEnableMockPagePopup):
- 9:00 AM Changeset in webkit [150262] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] ImageBlackBerry: add missing BlendMode parameter
https://bugs.webkit.org/show_bug.cgi?id=116316
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-17
Reviewed by Carlos Garcia Campos.
When the new BitmapImage::draw() method was added in r147110 it
didn't include the BlendMode parameter, which has been there since
r137011.
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
- 8:55 AM Changeset in webkit [150261] by
-
- 3 edits in trunk/Source/WebKit/mac
Reduce number of WebFrameLoaderClient static casts in WebKit
https://bugs.webkit.org/show_bug.cgi?id=116320
Reviewed by Antti Koivisto.
We already have a function to return a WebFrame from a WebCore::Frame, use it.
- DOM/WebDOMOperations.mm:
(WebFrameFilter::shouldIncludeSubframe):
- WebView/WebDataSource.mm:
(-[WebDataSource webFrame]):
- 8:29 AM Changeset in webkit [150260] by
-
- 17 edits in trunk
Some media/track tests fail or assert on Mac
https://bugs.webkit.org/show_bug.cgi?id=97132
Reviewed by Simon Fraser.
Source/WebCore:
Rationalize the font and padding behavior of cues and cue boxes; ::cue pseudo elements cannot have padding
values applied via CSS (due to padding not being included in the whitelist of applicable CSS properties).
Also, the font values were being applied to the box at one level and the cue at another, leading to incorrect
layout in the snapToLines case. Padding has been removed from the cue, and the font settings are now applied
to the box exclusively.
Additionally, a few drive-by changes were made in TextTrackCue to the return values of displayTreeInternal() &
element(), which previously returned a PassRefPtr<> instead of a plain pointer.
- css/mediaControls.css:
(video::-webkit-media-text-track-container): Move the font size to the display selector.
(video::cue): Remove the display:inline and padding:2px declarations.
(video::-webkit-media-text-track-display): Remove the -webkit-line-content now that the ::cue has no padding.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::TextTrackCue): The background box is now a span, rather than a forced-inline div.
(WebCore::TextTrackCue::displayTreeInternal): Return a plain pointer.
(WebCore::TextTrackCue::getDisplayTree): Ditto.
(WebCore::TextTrackCue::setFontSize): Set the font on the box, not the cue.
- html/track/TextTrackCue.h:
(WebCore::TextTrackCue::element): Return a plain pointer.
- html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): The cue element is now a span, not a div.
- page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Whitespace.
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Do not set padding on the cue.
LayoutTests:
- media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt:
- media/track/track-cue-rendering-horizontal.html:
- media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
- media/track/track-cue-rendering-snap-to-lines-not-set.html:
- media/track/track-cue-rendering-vertical.html:
- platform/mac/TestExpectations:
- platform/mac/media/track/track-cue-rendering-horizontal-expected.png:
- platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
- platform/mac/media/track/track-cue-rendering-vertical-expected.png:
- platform/mac/media/track/track-cue-rendering-vertical-expected.txt:
- 8:26 AM Changeset in webkit [150259] by
-
- 9 edits in trunk/Source/WebCore
Changes in text-only properties shouldn't cause repaints unless there is actually text.
<http://webkit.org/b/116250>
Reviewed by Antti Koivisto.
Add a new StyleDifferenceRepaintIfText value to the repertoire of RenderStyle::diff().
This result means that the renderer only needs to repaint if one of its immediate children contains text.
This lets us avoid repainting the same pixels when hovering over constructs like:
<style>
a { text-decoration: none; }
a:hover { text-decoration: underline; }
</style>
<a href="http://is.gd/andersca">
<img src="cool-hat.jpg">
</a>
Since the change in text-decoration has no effect on the rendering of the <img> element,
we'll now be smart enough to avoid repainting it.
- rendering/style/RenderStyleConstants.h:
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
Move checking of text-only properties until the very end, and return StyleDifferenceRepaintIfText
in case a difference is found, giving precedence to StyleDifferenceRepaint.
- rendering/RenderObject.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::hasImmediateNonWhitespaceTextChild):
Helper to check if a RenderObject has at least one RenderText child containing more than just
collapsible whitespace.
(WebCore::RenderObject::shouldRepaintForStyleDifference):
Helper to check if a StyleDifference is either ...Repaint or ...RepaintIfText and the renderer
has an immediate text child.
(WebCore::RenderObject::styleWillChange):
(WebCore::RenderObject::setStyle):
Don't repaint for StyleDifferenceRepaintIfText unless hasImmediateNonWhitespaceTextChild().
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::clientStyleChanged):
Tweak for new StyleDifference enum value.
- rendering/RenderText.h:
- rendering/RenderText.cpp:
(WebCore::RenderText::isAllCollapsibleWhitespace):
Made this const.
- 8:11 AM Changeset in webkit [150258] by
-
- 5 edits in trunk/Source/WebCore
Improve -webkit-text-underline-position memory usage.
https://bugs.webkit.org/show_bug.cgi?id=116108
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-17
Reviewed by Benjamin Poulain.
Remove m_maxLogicalTop private variable from RootInlineBox to reduce
the overall memory used to render RootInlineBoxes (eight bytes per RootInlineBox
instance in a 64-bit machine). RootInline::maxLogicalTop() now computes
the maxLogicalTop value everytime it is called. In a typical page
computeMaxLogicalTop is called less than 10 times for each
InlineTextBox that uses -webkit-text-underline-position. That is a small
price users of -webkit-text-underline-position will pay so that
everybody can benefit from the memory reduction in RootInlineBox.
No new tests, no change in behavior.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeMaxLogicalTop): Make it const.
- rendering/InlineFlowBox.h:
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox): Remove m_maxLogicalTop.
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Remove
computeMaxLogicalTop call and obsolete comment.
(WebCore):
(WebCore::RootInlineBox::maxLogicalTop): Compute maxLogicalTop before
returning its value.
- rendering/RootInlineBox.h:
(RootInlineBox):
- 8:08 AM Changeset in webkit [150257] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Remove stale comment for select mouse handling.
https://bugs.webkit.org/show_bug.cgi?id=116309
Reviewed by Rob Buis.
PR 135935.
Remove a FIXME that has been invalidated by a change
to our touch -> mouse model.
Internally Rubberstamped by Genevieve Mak.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
- 7:33 AM Changeset in webkit [150256] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed build fix. Remove assertion that doesn't make sense anymore since the
page does not give us access to the Chrome pointer directly anymore.
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-17
- webkit/webkitwebview.cpp:
(WebKit::kit):
- 7:05 AM Changeset in webkit [150255] by
-
- 4 edits in trunk/Source/WebCore
Make sure to call release() on our smart pointers when we should.
https://bugs.webkit.org/show_bug.cgi?id=116307
Reviewed by Andreas Kling.
Call release() when we should call it. There is probably more occurence
of this problem on the codebase but this is a first bunch of fixes.
No new tests : existing ones should cover.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::valueForNinePieceImage):
(WebCore::getBorderRadiusShorthandValue):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
(WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForGridShorthand):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseBorderImage):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):
- 6:46 AM Changeset in webkit [150254] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Support sub menu in ewk context menus
https://bugs.webkit.org/show_bug.cgi?id=114729
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-17
Reviewed by Christophe Dumez.
Added submenu support in EwkContextMenu and an API function to receive
Ewk_Context_Menu from submenu context menu item. A test case was added
for new API function.
EwkContextMenu is now an EwkObject allowing multiple instances of submenu
to be used in different submenu type context menu items.
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new):
(ewk_context_menu_item_parent_menu_get):
(ewk_context_menu_item_submenu_get):
- UIProcess/API/efl/ewk_context_menu_item.h:
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem::create):
(EwkContextMenuItem::parentMenu):
(EwkContextMenuItem::subMenu):
(EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu::ewkView):
(EwkContextMenu):
- UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
(showContextMenu):
- 6:00 AM Changeset in webkit [150253] by
-
- 4 edits2 deletes in trunk/Source
[CMake] Remove invalid include paths
https://bugs.webkit.org/show_bug.cgi?id=116213
Reviewed by Gyuyoung Kim.
Since "${JAVASCRIPTCORE_DIR}/wtf" does not exist, it is safe
to remove them from the list of include directories.
Source/JavaScriptCore:
- PlatformEfl.cmake: Removed.
- PlatformGTK.cmake: Removed.
Source/WTF:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- 5:41 AM Changeset in webkit [150252] by
-
- 5 edits in trunk/Source/WebCore
Make PNGImageDecoder::rowAvailable auto-vectorizable
https://bugs.webkit.org/show_bug.cgi?id=116151
Reviewed by Benjamin Poulain.
Changed the main loops under PNGImageDecoder::rowAvailable so that they
avoid branches and non-sequential table look ups.
Together with automatic vectorization by the compiler this provides around
4x speed-up with AVX or 2x speed-up on generic x64. Shaving off 12-40% on
PNG decoding in general.
- platform/graphics/Color.cpp:
(WebCore::premultipliedARGBFromColor):
- platform/graphics/Color.h:
(WebCore::fastDivideBy255):
- platform/graphics/filters/FEBlend.cpp:
- platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::setPixelRGB):
(WebCore::setPixelRGBA):
(WebCore::setPixelRGBA_Premultiplied):
(WebCore::PNGImageDecoder::rowAvailable):
- 5:30 AM Changeset in webkit [150251] by
-
- 8 edits in trunk
Web Inspector: Allow "# sourceMappingURL" syntax alongside "@"
https://bugs.webkit.org/show_bug.cgi?id=116290
Source/WebCore:
Follow an update to the spec and support the new and old syntax.
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-17
Reviewed by Timothy Hatcher.
- inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::scriptCommentPattern):
(WebCore::ContentSearchUtils::stylesheetCommentPattern):
- inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._loadAndProcessSourceMap):
LayoutTests:
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-05-17
Reviewed by Timothy Hatcher.
- http/tests/inspector/network/resources/source-map-test-style.css:
- http/tests/inspector/stylesheet-source-mapping.html:
- inspector/debugger/source-url-comment-expected.txt:
- inspector/debugger/source-url-comment.html:
- 5:30 AM Changeset in webkit [150250] by
-
- 6 edits in trunk/LayoutTests
2 math sputnik test fail on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=88519
Reviewed by Jocelyn Turcotte.
Update the expected values to match recent changes in test262.
The old tested values are considered outside the validation range.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/qt/TestExpectations:
- sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.16_sin/S15.8.2.16_A7.html:
- sputnik/Conformance/15_Native_Objects/15.8_Math/15.8.2/15.8.2.18_tan/S15.8.2.18_A7.html:
- 5:24 AM Changeset in webkit [150249] by
-
- 5 edits in trunk/Source/WebCore
Remove custom code for MessageEvent.ports getter
https://bugs.webkit.org/show_bug.cgi?id=116304
Reviewed by Kentaro Hara.
Remove Custom code for the "ports" attribute getter in MessageEvent
IDL interface. The JSC bindings generator already supports attributes
of type MessagePortArray.
No new tests, already covered by existing layout tests and bindings
tests.
- bindings/js/JSMessageEventCustom.cpp: Remove Custom code for ports getter.
- bindings/scripts/CodeGeneratorJS.pm:
(NativeToJSValue): Small tweak to correctly handle the case where impl->ports()
returns NULL and avoid crashing in this case.
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Rebaseline due
to bindings generator tweak.
- dom/MessageEvent.idl: Remove [CustomGetter] extended attribute for 'ports' attribute
and switch to MessagePortArray type.
- 5:22 AM Changeset in webkit [150248] by
-
- 2 edits8 adds in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expected after r143389.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-05-17
- platform/qt/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
- platform/qt/svg/as-image/image-preserveAspectRatio-all-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.txt: Added.
- platform/qt/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
- platform/qt/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.txt: Added.
- platform/qt/svg/filters/feImage-preserveAspectRatio-all-expected.png: Added.
- platform/qt/svg/filters/feImage-preserveAspectRatio-all-expected.txt: Added.
- 4:09 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 3:42 AM Changeset in webkit [150247] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] DumpRenderTreeSupport: fix build in setMockDeviceOrientation()
https://bugs.webkit.org/show_bug.cgi?id=116298
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-17
Reviewed by Carlos Garcia Campos.
Pass the correct parameter to toDeviceOrientationClientMock()
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setMockDeviceOrientation):
- 3:18 AM Changeset in webkit [150246] by
-
- 2 edits in trunk/LayoutTests
[GTK] Rebaseline after r150169
https://bugs.webkit.org/show_bug.cgi?id=116256
Unreviewed GTK gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-17
- platform/gtk/TestExpectations: Renamed from fast/loader/willsendrequest-returns-null-for-memory-cache-load.html.
- 3:00 AM Changeset in webkit [150245] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Unreviewed build fix.
Add missing Qt specific initializer for willLoadURLRequest and willLoadDataRequest.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu>, Ádám Kallai <kadam@inf.u-szeged.hu> on 2013-05-17
- WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):
- 12:07 AM Changeset in webkit [150244] by
-
- 2 edits in trunk/LayoutTests
media/video-seek-after-end.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116293
Add a flaky test expectation on all platforms.
May 16, 2013:
- 10:22 PM Changeset in webkit [150243] by
-
- 4 edits2 deletes in trunk/Source/WebKit2
Remove WKBundlePageGetHeaderLayer/Footer SPI
https://bugs.webkit.org/show_bug.cgi?id=116254
Reviewed by Benjamin Poulain.
We should remove the Remove WKBundlePageGetHeaderLayer/Footer SPI. It was only
recently added and have been replaced by WKBundlePageSetHeaderBanner/Footer.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.h: Removed.
- WebProcess/InjectedBundle/API/c/mac/WKBundlePagePrivateMac.mm: Removed.
- WebProcess/WebPage/WebPage.h:
(WebPage):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit):
(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):
- 9:34 PM Changeset in webkit [150242] by
-
- 15 edits2 adds in trunk
Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
https://bugs.webkit.org/show_bug.cgi?id=116132
Reviewed by Anders Carlsson.
Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
willLoadURLRequest and willLoadDataRequest to let the bundle access them.
Source/WebKit2:
Adds WebKit2WillLoadTest.* API tests.
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadURLWithUserData):
(WKPageLoadURLRequestWithUserData):
(WKPageLoadFile):
(WKPageLoadFileWithUserData):
(WKPageLoadHTMLStringWithUserData):
(WKPageLoadAlternateHTMLStringWithUserData):
(WKPageLoadPlainTextStringWithUserData):
(WKPageLoadWebArchiveDataWithUserData):
- UIProcess/API/C/WKPage.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(WebCore):
(InjectedBundlePageLoaderClient):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
- TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
- 8:39 PM Changeset in webkit [150241] by
-
- 9 edits in trunk
[EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114781
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-16
Reviewed by Christophe Dumez.
Source/WebKit/efl:
We need to make a distinction between runBeforeUnloadConfirmPanel and confirm.
- WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::runBeforeUnloadConfirmPanel):
- ewk/ewk_view.cpp: Add ewk_view_run_before_unload_confirm API.
(_ewk_view_smart_run_before_unload_confirm):
(ewk_view_base_smart_set):
(ewk_view_run_before_unload_confirm):
- ewk/ewk_view.h: Add smart class member function for runBeforeUnloadConfirmPanel.
- ewk/ewk_view_private.h:
Tools:
Add run_before_unload_confirm and
Print the log message with "CONFIRM NAVIGATION: " in console.
- DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onBeforeUnloadConfirm):
(drtViewAdd):
LayoutTests:
Unskip fast/loader/form-submission-after-beforeunload-cancel.html as well.
- platform/efl-wk1/TestExpectations:
- 8:28 PM Changeset in webkit [150240] by
-
- 3 edits2 moves2 deletes in trunk/Source/WebCore
Add stubs for ContextMenu and ContextMenuItem
https://bugs.webkit.org/show_bug.cgi?id=116235
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-16
Reviewed by Antonio Gomes.
No new tests needed, only a refactor.
Add ContextMenuNone.cpp and ContextMenuItemNone.cpp
so ports using ENABLE(CROSS_PLATFORM_CONTEXT_MENU) don't
need to replicate these stubs.
- PlatformEfl.cmake:
- Target.pri:
- platform/ContextMenuNone.cpp: Added.
(WebCore):
(WebCore::ContextMenu::ContextMenu):
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
(WebCore::ContextMenu::platformContextMenu):
- platform/ContextMenuItemNone.cpp: Added.
(WebCore):
(WebCore::ContextMenuItem::platformContextMenuItem):
- platform/efl/ContextMenuEfl.cpp: Removed.
- platform/efl/ContextMenuItemEfl.cpp: Removed.
- platform/qt/ContextMenuQt.cpp: Removed.
- platform/qt/ContextMenuItemQt.cpp: Removed.
- 8:26 PM Changeset in webkit [150239] by
-
- 4 edits6 adds in trunk
Regression: Event#stopPropagation() does not halt bubbling for webkitTransitionEnd
https://bugs.webkit.org/show_bug.cgi?id=115656
Reviewed by Darin Adler.
Source/WebCore:
If we create a prefixed event to dispatch it (in the case we have only
prefixed event listeners in client's code) then we need to make sure to
keep it in sync with the original unprefixed event after it has been
dispatched. While being dispatched the event can be modified by
client's code and when propagated back to outer elements, attributes were
not updated. This patch changes the old design of creating a separate event
for the prefixed case and now change the type of the event (so the name) before
dispatching it, keeping the attributes if changed and then rename it
back to unprefixed when the dispatching is finished.
Tests: transitions/transition-end-event-prefixed-01.html
transitions/transition-end-event-prefixed-02.html
transitions/transition-end-event-prefixed-03.html
- dom/Event.h:
(WebCore::Event::setType):
- dom/EventTarget.cpp:
(WebCore::EventTarget::fireEventListeners):
LayoutTests:
Added new tests to cover the bug.
- transitions/transition-end-event-prefixed-03-expected.txt: Added.
- transitions/transition-end-event-prefixed-03.html: Added.
- transitions/transition-end-event-prefixed-02-expected.txt: Added.
- transitions/transition-end-event-prefixed-02.html: Added.
- transitions/transition-end-event-prefixed-01-expected.txt: Added.
- transitions/transition-end-event-prefixed-01.html: Added.
- 8:20 PM Changeset in webkit [150238] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Strip invoke URLs when writing to the clipboard.
https://bugs.webkit.org/show_bug.cgi?id=116226
Reviewed by Rob Buis.
PR 333516.
Invoke URLs should not be included in the paste data.
Internally Reviewed by Gen Mak.
- platform/blackberry/PasteboardBlackBerry.cpp:
(WebCore::Pasteboard::writeSelection):
- 8:18 PM Changeset in webkit [150237] by
-
- 2 edits in trunk/Tools
Fix Analyze ChangeLog's entry processing
https://bugs.webkit.org/show_bug.cgi?id=116219
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-16
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/tool/commands/analyzechangelog.py:
(ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
- 8:17 PM Changeset in webkit [150236] by
-
- 2 edits in trunk/Source/WebCore
Missing UNUSED_PARAM macro for textPosition argument in WebKitAccessibleInterfaceText
https://bugs.webkit.org/show_bug.cgi?id=116230
Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-05-16
Reviewed by Chris Fleizach.
No new functionality, no new tests.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): List textPosition argument as
unused parameter for all platforms except GTK.
- 8:15 PM Changeset in webkit [150235] by
-
- 5 edits in trunk/LayoutTests
Add failing test expectations to http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html per bug 116259.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/qt/TestExpectations:
- 8:14 PM Changeset in webkit [150234] by
-
- 3 edits2 adds in trunk
Source/WebCore: Frame flattening prevents <HTML> in <OBJECT> from having scrollbars
https://bugs.webkit.org/show_bug.cgi?id=115884
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-05-16
Reviewed by Antonio Gomes.
Frame flattening should be applied when the frame owner is frame or iframe. But when
the frame owner is object element, frame flattening prevents it from having scrollbars.
In this situation, we can't scroll the html document in object element.
This patch adds two helper functions to verify flattening conditions.
Test: fast/frames/flattening/scrolling-in-object.html
- page/FrameView.cpp:
(WebCore::frameFlatteningEnabled): Added. Helper to check whether flattening is enabled or not.
(WebCore::supportsFrameFlattening): Added. Helper to check whether the frame owner is <frame> or <iframe>.
(WebCore::FrameView::avoidScrollbarCreation):
(WebCore::FrameView::calculateScrollbarModesForLayout): Use frameFlatteningEnabled().
(WebCore::FrameView::layout): Use frameFlatteningEnabled().
(WebCore::FrameView::isInChildFrameWithFrameFlattening): Use frameFlatteningEnabled().
LayoutTests: Frame flattening prevents <HTML> in <OBJECT> from having scrollbars
https://bugs.webkit.org/show_bug.cgi?id=115884
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-05-16
Reviewed by Antonio Gomes.
Frame flattening should be applied when the frame owner is frame or iframe. But when
the frame owner is object element, frame flattening prevents it from having scrollbars.
In this situation, we can't scroll the html document in object element.
This patch adds two helper functions to verify flattening conditions.
- fast/frames/flattening/scrolling-in-object-expected.html: Added.
- fast/frames/flattening/scrolling-in-object.html: Added.
- 7:53 PM Changeset in webkit [150233] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Optimize caret bounds calculation when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=116224
Reviewed by Rob Buis.
PR 340132.
If the caret is no longer active in the field, do not allow it
to go into the single line input logic and calculate the node
bounding box.
Internally Reviewed By Gen Mak
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
- 7:50 PM Changeset in webkit [150232] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Fix memory leak in WebKitBackForwardList
https://bugs.webkit.org/show_bug.cgi?id=116222
Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-05-16
Reviewed by Carlos Garcia Campos.
Due to the use of leakRef() the ImmutableArray is not being released
automatically. Adding a local variable in the methods to make sure that
the ImmutableArray is freed.
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
(webkit_back_forward_list_get_back_list_with_limit): Add local variable
RefPtr and pass the ImmutableArray to
WebKitBackForwardList::webkitBackForwardListCreateList() using
RefPtr::get().
(webkit_back_forward_list_get_forward_list_with_limit): Ditto.
- 7:47 PM Changeset in webkit [150231] by
-
- 2 edits in trunk/Source/WebCore
Port functions for pathhandling to Windows CE in FileSystemWin
https://bugs.webkit.org/show_bug.cgi?id=116208
Reviewed by Darin Adler.
This will allow us to remove FileSystemWinCE in a next step.
- platform/win/FileSystemWin.cpp:
(WebCore::pathByAppendingComponent):
(WebCore::pathGetFileName):
- 7:46 PM Changeset in webkit [150230] by
-
- 4 edits in trunk/Source
Unreviewed, rolling out r150034.
http://trac.webkit.org/changeset/150034
https://bugs.webkit.org/show_bug.cgi?id=116257
This work around doesn't work due to another bug NSUndoManager
has (Requested by rniwa on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-16
Source/WebKit/mac:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::registerUndoOrRedoStep):
Source/WebKit2:
- UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::registerEditCommand):
- 7:44 PM Changeset in webkit [150229] by
-
- 3 edits in trunk/Tools
[Qt] UrlLoader::loadNext is broken in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=116099
Patch by Hyungchan Kim <hyungchan2.kim@lge.com> on 2013-05-16
Reviewed by Jocelyn Turcotte.
QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
are not available any more. So, UrlLoader::loadNext was broken
because it failed to connect to those signals.
- MiniBrowser/qt/UrlLoader.cpp:
(UrlLoader::UrlLoader):
(UrlLoader::loadingChanged):
- MiniBrowser/qt/UrlLoader.h:
(UrlLoader):
- 6:10 PM Changeset in webkit [150228] by
-
- 3 edits in trunk/Source/WTF
Add the symbol WTFInvokeCrashHook back for binary compatibility.
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-16
Reviewed by Ryosuke Niwa.
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 5:42 PM Changeset in webkit [150227] by
-
- 29 edits in trunk/Source
PDFPlugins don't load when plugins are disabled, but they should
https://bugs.webkit.org/show_bug.cgi?id=75790
<rdar://problem/11650197>
Reviewed by Anders Carlsson.
Make it possible to load "application" plug-ins even if settings or the FrameLoaderClient
say that plug-ins should be disabled, providing a mechanism for WebKit* to offer built-in
functionality which happens to use the plug-in infrastructure, and which also doesn't
unexpectedly disappear for users with plug-ins off.
- WebCore.exp.in:
Export SubframeLoader::allowPlugins().
Update signature for PluginData::supportsMimeType to include the AllowedPluginTypes argument.
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Load PluginData even if plug-ins are disabled, but if that is the case, only
create a PluginDocument for application plug-ins.
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::appendBytes):
Don't bail if plug-ins are disabled, because we could still be a PluginDocument
for an application plug-in.
- page/Page.cpp:
(WebCore::Page::pluginData):
Allow PluginData to be constructed even if plug-ins are disabled, as there might
be application plug-ins that we want to load anyway.
- platform/mac/MIMETypeRegistryMac.mm:
(WebCore::MIMETypeRegistry::isApplicationPluginMIMEType):
On Mac, if we have PDFPlugin, we can support PDF and PostScript with a native application plug-in.
- plugins/PluginData.cpp:
(WebCore::PluginData::supportsMimeType):
Add an AllowedPluginTypes argument to supportsMimeType, allowing callers to specify
whether they are looking for any plug-in, or are looking only for application plug-ins.
- plugins/PluginData.h:
(PluginInfo): Added an isApplicationPlugin field, to specify whether this is a "built-in" plug-in.
(PluginData): Add the aforementioned AllowedPluginTypes enum and the argument to supportsMimeType.
Support loading "application" plug-ins even if plug-ins are explicitly disabled.
Make PDFPlugin and SimplePDFPlugin "application" plug-ins, so they can
be loaded even if plug-ins are disabled.
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
Add a 5-argument, 3-reply version of callMemberFunction.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
NPAPI plug-ins are not application plug-ins.
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):
(CoreIPC::::decode):
Encode/decode the new isApplicationPlugin field on PluginInfo.
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::findPluginForMIMEType):
(WebKit::PluginInfoStore::findPluginForExtension):
(WebKit::PluginInfoStore::findPlugin):
- UIProcess/Plugins/PluginInfoStore.h:
(PluginInfoStore):
Give PluginInfoStore's findPlugin method and its private helper
methods an argument allowing them to only match application plug-ins.
(WebKit::WebPageProxy::findPlugin):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
Add an argument allowing findPlugin to restrict its search to only application plug-ins.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::objectContentType):
Previously, this caller depended on pluginData() returning null if
plug-ins were disabled. Since that is no longer the case, we have to
check if we can use plug-ins, and otherwise ignore non-application-plug-ins.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
When going to search for a plug-in, ask subframeLoader whether or not
it's OK to use ordinary non-application plug-ins, and pass that information
on to the UIProcess when performing the search.
(WebKit::WebPage::canPluginHandleResponse): Ditto.
(WebKit::WebPage::canShowMIMEType):
Ensure that canShowMIMEType returns true if we have an application plug-in
that can display a particular MIME type, even if we're not allowed to load plug-ins.
- Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage getPluginInfoFromPLists]):
- Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage getPluginInfoFromResources]):
Nothing loaded via WebBasePluginPackage or WebNetscapePluginPackage
is an application plugin.
- WebView/WebFrame.mm:
(-[WebFrame _canProvideDocumentSource]):
Previously, this caller depended on pluginData() returning null if
plug-ins were disabled. Since that is no longer the case, we have to
check if we can use plug-ins, and otherwise ignore non-application-plug-ins.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::objectContentType):
Previously, this caller depended on pluginData() returning null if
plug-ins were disabled. Since that is no longer the case, we have to
check if we can use plug-ins, and otherwise ignore non-application-plug-ins.
- WebView.cpp:
(WebView::canShowMIMEType):
Previously, this caller depended on pluginData() returning null if
plug-ins were disabled. Since that is no longer the case, we have to
check if we can use plug-ins, and otherwise ignore non-application-plug-ins.
- 5:36 PM Changeset in webkit [150226] by
-
- 8 edits in trunk/Source/WebKit2
[EFL][WK2] Make Ewk_Context_Menu Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=116097
Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-05-16
Reviewed by Gyuyoung Kim.
Changed Ewk_Context_Menu to be an Ewk_Object so pointer to menu
object can be shared between different modules.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::showContextMenu):
- UIProcess/API/efl/EwkView.h:
(EwkView):
- UIProcess/API/efl/ewk_context_menu.cpp:
(EwkContextMenu::appendItem):
(EwkContextMenu::removeItem):
(ewk_context_menu_new):
(ewk_context_menu_new_with_items):
(ewk_context_menu_item_append):
(ewk_context_menu_item_remove):
(ewk_context_menu_hide):
(ewk_context_menu_items_get):
(ewk_context_menu_item_select):
- UIProcess/API/efl/ewk_context_menu_item.cpp:
(EwkContextMenuItem::EwkContextMenuItem):
(ewk_context_menu_item_new_with_submenu):
- UIProcess/API/efl/ewk_context_menu_item_private.h:
(EwkContextMenuItem):
- UIProcess/API/efl/ewk_context_menu_private.h:
(EwkContextMenu):
(EwkContextMenu::create):
- UIProcess/API/efl/ewk_defines.h:
- 5:33 PM Changeset in webkit [150225] by
-
- 23 edits1 copy1 move in trunk
[WebSocket] Update pywebsocket to r760
https://bugs.webkit.org/show_bug.cgi?id=115863
Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-16
Reviewed by Alexey Proskuryakov.
Tools:
Version r760 supports a newer draft of message compression.
We need this update to finish the permessage compression patch in
bug 98840. This patch also fixes failing unit tests after the update.
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
(StreamBase._read):
(StreamBase._read.of):
(StreamBase._write):
(StreamBase.receive_bytes):
(StreamBase._read_until):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
(parse_frame):
(StreamOptions.init):
(Stream.init):
(Stream._receive_frame_as_frame_object):
(Stream._get_message_from_frame):
(Stream._process_close_message):
(Stream.close_connection):
(Stream.get_last_received_opcode):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
- Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
(Dispatcher.do_extra_handshake):
(Dispatcher.transfer_data):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
(ExtensionProcessorInterface.init):
(ExtensionProcessorInterface.request):
(ExtensionProcessorInterface):
(ExtensionProcessorInterface.name):
(ExtensionProcessorInterface.check_consistency_with_other_processors):
(ExtensionProcessorInterface.set_active):
(ExtensionProcessorInterface.is_active):
(ExtensionProcessorInterface._get_extension_response_internal):
(ExtensionProcessorInterface.get_extension_response):
(ExtensionProcessorInterface._setup_stream_options_internal):
(ExtensionProcessorInterface.setup_stream_options):
(_log_outgoing_compression_ratio):
(_log_incoming_compression_ratio):
(_parse_window_bits):
(_AverageRatioCalculator):
(_AverageRatioCalculator.init):
(_AverageRatioCalculator.add_original_bytes):
(_AverageRatioCalculator.add_result_bytes):
(_AverageRatioCalculator.get_average_ratio):
(DeflateFrameExtensionProcessor):
(DeflateFrameExtensionProcessor.init):
(DeflateFrameExtensionProcessor._get_extension_response_internal):
(DeflateFrameExtensionProcessor._setup_stream_options_internal):
(DeflateFrameExtensionProcessor._outgoing_filter):
(DeflateFrameExtensionProcessor._incoming_filter):
(CompressionExtensionProcessorBase.for):
(CompressionExtensionProcessorBase.init):
(CompressionExtensionProcessorBase._get_extension_response_internal):
(CompressionExtensionProcessorBase._setup_stream_options_internal):
(PerFrameCompressExtensionProcessor):
(PerMessageDeflateExtensionProcessor):
(PerMessageDeflateExtensionProcessor.init):
(PerMessageDeflateExtensionProcessor._get_extension_response_internal):
(PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
(PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
(PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
(PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
(PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
(PerMessageDeflateExtensionProcessor.set_bfinal):
(PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
(PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
(_PerMessageDeflateFramer):
(_PerMessageDeflateFramer.init):
(_PerMessageDeflateFramer.set_compress_outgoing_enabled):
(_PerMessageDeflateFramer._process_incoming_message):
(_PerMessageDeflateFramer._process_outgoing_message):
(_PerMessageDeflateFramer.setup_stream_options):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.init):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
(_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
(_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.init):
(_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
(_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.init):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
(_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
(_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
(_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.init):
(_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
(PerMessageCompressExtensionProcessor):
(PerMessageCompressExtensionProcessor._lookup_compression_processor):
(MuxExtensionProcessor.init):
(MuxExtensionProcessor.check_consistency_with_other_processors):
(MuxExtensionProcessor):
(MuxExtensionProcessor._get_extension_response_internal):
(MuxExtensionProcessor._setup_stream_options_internal):
(MuxExtensionProcessor.set_quota):
(MuxExtensionProcessor.quota):
(MuxExtensionProcessor.set_extensions):
(MuxExtensionProcessor.extensions):
(is_compression_extension):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
(validate_subprotocol):
(parse_host_header):
(format_header):
(check_request_line):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
(Handshaker.do_handshake):
(Handshaker._create_handshake_response):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
(_validate_subprotocol):
(_check_header_lines):
(_build_location):
(Handshaker.do_handshake):
(Handshaker._set_subprotocol):
(Handshaker._set_location):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
(_create_dispatcher):
(headerparserhandler):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
(_create_add_channel_response):
(_create_drop_channel):
(_create_flow_control):
(_create_new_channel_slot):
(_create_fallback_new_channel_slot):
(_MuxFramePayloadParser._read_number):
(_MuxFramePayloadParser._read_size_and_contents):
(_MuxFramePayloadParser._read_flow_control):
(_MuxFramePayloadParser._read_new_channel_slot):
(_LogicalConnection.init):
(_LogicalConnection.write):
(_LogicalConnection.on_write_data_done):
(_LogicalConnection):
(_LogicalConnection.on_writer_done):
(_InnerMessage):
(_InnerMessage.init):
(_InnerMessageBuilder):
(_InnerMessageBuilder.that):
(_InnerMessageBuilder.init):
(_InnerMessageBuilder._handle_first):
(_InnerMessageBuilder._process_first_fragmented_control):
(_InnerMessageBuilder._process_first_fragmented_message):
(_InnerMessageBuilder._handle_fragmented_control):
(_InnerMessageBuilder._reassemble_fragmented_control):
(_InnerMessageBuilder._handle_fragmented_message):
(_InnerMessageBuilder._reassemble_fragmented_message):
(_InnerMessageBuilder.build):
(_LogicalStream.init):
(_LogicalStream._create_inner_frame):
(_LogicalStream._write_inner_frame):
(_LogicalStream.replenish_send_quota):
(_LogicalStream.send_message):
(_LogicalStream._receive_frame):
(_LogicalStream._get_message_from_frame):
(_LogicalStream.stop_sending):
(_PhysicalConnectionWriter.init):
(_PhysicalConnectionWriter._write_data):
(_PhysicalConnectionWriter.run):
(_PhysicalConnectionWriter.stop):
(_Worker.run):
(_MuxHandshaker.init):
(_MuxHandshaker._create_stream):
(_MuxHandshaker._create_handshake_response):
(_HandshakeDeltaBase.create_headers):
(_MuxHandler.start):
(_MuxHandler.wait_until_done):
(_MuxHandler.notify_write_data_done):
(_MuxHandler._process_drop_channel):
(_MuxHandler._process_logical_frame):
(_MuxHandler.notify_reader_done):
(_MuxHandler):
(_MuxHandler.notify_writer_done):
(_MuxHandler.fail_physical_connection):
(_MuxHandler.fail_logical_channel):
(use_mux):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
(_StandaloneRequest.get_uri):
(_StandaloneRequest.get_unparsed_uri):
(_StandaloneRequest):
(_StandaloneRequest.is_https):
(_import_ssl):
(_import_pyopenssl):
(_StandaloneSSLConnection.for):
(_StandaloneSSLConnection):
(_StandaloneSSLConnection.getattribute):
(_StandaloneSSLConnection.setattr):
(_StandaloneSSLConnection.makefile):
(_StandaloneSSLConnection.shutdown):
(_StandaloneSSLConnection.recv):
(WebSocketServer.init):
(WebSocketServer._create_sockets):
(WebSocketServer.handle_error):
(WebSocketServer.get_request):
(WebSocketServer.get_request.default_callback):
(WebSocketRequestHandler.parse_request):
(_build_option_parser):
(_main):
(_main.if):
- Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
(RepeatedXorMasker.init):
(RepeatedXorMasker._mask_using_swig):
(RepeatedXorMasker):
(RepeatedXorMasker._mask_using_array):
(_Deflater.compress_and_finish):
(_RFC1979Deflater.filter):
(DeflateSocket.send):
LayoutTests:
Fix failing tests.
- http/tests/websocket/tests/handler_map.txt:
- http/tests/websocket/tests/hybi/echo-host_wsh.py: Copied from LayoutTests/http/tests/websocket/tests/hybi/echo-location_wsh.py.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/echo-path_wsh.py: Renamed from LayoutTests/http/tests/websocket/tests/hybi/echo-location_wsh.py.
(web_socket_do_extra_handshake):
(web_socket_transfer_data):
- http/tests/websocket/tests/hybi/url-no-trailing-slash-expected.txt:
- http/tests/websocket/tests/hybi/url-no-trailing-slash.html:
- http/tests/websocket/tests/hybi/url-with-credential-expected.txt:
- http/tests/websocket/tests/hybi/url-with-credential.html:
- http/tests/websocket/tests/hybi/url-with-empty-query-expected.txt:
- http/tests/websocket/tests/hybi/url-with-empty-query.html:
- http/tests/websocket/tests/hybi/url-with-query-expected.txt:
- http/tests/websocket/tests/hybi/url-with-query.html:
- 5:30 PM Changeset in webkit [150224] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] Crash due to an assert running test editing/execCommand/indent-paragraphs.html
https://bugs.webkit.org/show_bug.cgi?id=114944
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-16
Reviewed by Rob Buis.
It crashes in network platform code when trying to save an
invalid URL in the disk cache. That test contains references to
empty URLs like http://. Those empty URLs, are parsed as http:/ by
KURL and considered valid. BlackBerry network platform uses GURL
which considers those URLs invalid. We needed to check that the
URLs are valid for our platform before starting the network
operation.
Fixes a crash running test
editing/execCommand/indent-paragraphs.html.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Check if the request URL is
valid from the platform point of view right after creating the
platform network request and return early if the URL is invalid
with StatusErrorInvalidUrl error.
- 5:20 PM Changeset in webkit [150223] by
-
- 2 edits in trunk/Tools
Fix testing if program exists in PATH
https://bugs.webkit.org/show_bug.cgi?id=116216
Patch by Jonathan Liu <net147@gmail.com> on 2013-05-16
Reviewed by Jocelyn Turcotte.
functions.prf incorrectly uses win_cmd_shell to test whether to
add .exe to the executable name when checking if it exists in
the PATH environment variable. This works correctly when
building using Windows Command Prompt but not under MSYS shell.
To resolve this, check the win32 platform scope instead of
win_cmd_shell so that it correctly adds .exe to the executable
name on Windows regardless of the shell used when testing if
it exists in PATH.
- qmake/mkspecs/features/functions.prf:
- 5:19 PM Changeset in webkit [150222] by
-
- 3 edits in trunk/Source/WebCore
Remove unused function safeCreateFile() from WebCore
https://bugs.webkit.org/show_bug.cgi?id=116211
Reviewed by Anders Carlsson.
- platform/FileSystem.h:
- platform/win/FileSystemWin.cpp:
- 5:17 PM Changeset in webkit [150221] by
-
- 2 edits in trunk/Source/WebCore
[curl] MIME type should be in lowercase
https://bugs.webkit.org/show_bug.cgi?id=116218
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-16
Reviewed by Benjamin Poulain.
Existing testcase: http/tests/mime/uppercase-mime-type.html
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::headerCallback): Convert the MIME type to lowercase.
- 5:14 PM Changeset in webkit [150220] by
-
- 7 edits in trunk/Source/JavaScriptCore
Consolidate lists in JavaScriptCore CMake files
https://bugs.webkit.org/show_bug.cgi?id=115992
Reviewed by Gyuyoung Kim.
Move common files into the CMakeLists.txt to avoid duplicating the list of files.
Also rebase the recently added GTK files to match the other CMake ports, since
the submitted patch was based on an older version of the source tree.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- shell/CMakeLists.txt:
- shell/PlatformEfl.cmake:
- shell/PlatformGTK.cmake:
- 5:14 PM Changeset in webkit [150219] by
-
- 2 edits in trunk/Source/WTF
[CMAKE] Need to set WTF_LIBRARIES in wtf/CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=116209
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-16
Reviewed by Gyuyoung Kim.
- wtf/CMakeLists.txt: Replace list with set.
- 5:12 PM Changeset in webkit [150218] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix optional value of promptText in Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=116203
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-16
Reviewed by Joseph Pecoraro.
Merge from https://chromiumcodereview.appspot.com/14672031.
No new tests needed.
- inspector/Inspector.json:
- 5:11 PM Changeset in webkit [150217] by
-
- 4 edits2 adds in trunk/Source
[BlackBerry] Unable to download blob resource
https://bugs.webkit.org/show_bug.cgi?id=115888
Reviewed by Benjamin Poulain.
Source/WebCore:
Add BlobStream to handle over blob data from BlobResourceHandle to download stream.
RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
- PlatformBlackBerry.cmake:
- platform/network/blackberry/BlobStream.cpp: Added.
(WebCore):
(WebCore::BlobStream::BlobStream):
(WebCore::BlobStream::~BlobStream):
(WebCore::BlobStream::didReceiveData):
(WebCore::BlobStream::didFinishLoading):
(WebCore::BlobStream::didFail):
(WebCore::BlobStream::url):
(WebCore::BlobStream::mimeType):
- platform/network/blackberry/BlobStream.h: Added.
(WebCore):
(BlobStream):
Source/WebKit/blackberry:
For blob resource (blob:http....), it's not suitable to go to NetworkStream
which don't handle "blob" protocol at all. since blob data already handled
in BlobResourceHandle, simply get the data out to download stream.
RIM bug 331086, internally reviewed by Charles Wei and Leo Yang.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):
- 5:06 PM Changeset in webkit [150216] by
-
- 13 edits5 deletes in trunk/Source/WebCore
Remove SystemTime header and implementations
https://bugs.webkit.org/show_bug.cgi?id=116200
Reviewed by Alexey Proskuryakov.
SystemTim just had a single function that's not called anymore. Remove it.
- GNUmakefile.list.am:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- history/PageCache.cpp:
- platform/SystemTime.h: Removed.
- platform/blackberry/SystemTimeBlackBerry.cpp: Removed.
- platform/efl/SystemTimeEfl.cpp: Removed.
- platform/graphics/ca/GraphicsLayerCA.cpp:
- platform/mac/SystemTimeMac.cpp: Removed.
- platform/qt/TemporaryLinkStubsQt.cpp:
- platform/win/SystemTimeWin.cpp: Removed.
- 5:04 PM Changeset in webkit [150215] by
-
- 2 edits in trunk/Source/WebCore
[Inspector] Don't filter syntax error caused by asterisk in CSS Property name.
https://bugs.webkit.org/show_bug.cgi?id=116196
Reviewed by Benjamin Poulain.
- inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
- Remove questionable IE7 related error filtering
- 5:03 PM Changeset in webkit [150214] by
-
- 90 edits in trunk/Source
Page::chrome() should return a reference.
<http://webkit.org/b/116185>
Source/WebCore:
Reviewed by Anders Carlsson.
A Page's chrome() can never be null. Change Page::chrome() to return a reference to reflect this.
Also, make Page::m_chrome a const member variable so nobody will accidentally set it to null.
Source/WebKit/blackberry:
Reviewed by Anders Carlsson.
Source/WebKit/efl:
Reviewed by Anders Carlsson.
Source/WebKit/gtk:
Reviewed by Anders Carlsson.
Source/WebKit/mac:
Reviewed by Anders Carlsson.
Source/WebKit/qt:
Reviewed by Anders Carlsson.
Source/WebKit/win:
Reviewed by Anders Carlsson.
Source/WebKit2:
Reviewed by Anders Carlsson.
- 4:57 PM Changeset in webkit [150213] by
-
- 3 edits2 adds in trunk
Source/WebCore: Content disappears when scrolling http://www.childrenscancer.org/zach/
https://bugs.webkit.org/show_bug.cgi?id=116206
Reviewed by Darin Adler.
When a RenderLayerBacking gains or loses a foregroundLayer or backgroundLayer,
we need to repaint the primary layer, since what paints into that primary
layer will change.
On the page in question, we gained/lost a foreground layer when scrolling because
the page popped an element into position:fixed.
Test: compositing/repaint/foreground-layer-change.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateForegroundLayer):
(WebCore::RenderLayerBacking::updateBackgroundLayer):
LayoutTests: Content disappears when scrolling http://www.childrenscancer.org/zach/
https://bugs.webkit.org/show_bug.cgi?id=116206
Reviewed by Darin Adler.
Ref test for foreground layer removal.
- compositing/repaint/foreground-layer-change-expected.html: Added.
- compositing/repaint/foreground-layer-change.html: Added.
- 4:48 PM Changeset in webkit [150212] by
-
- 2 edits in trunk/Source/WebKit2
[wk2] didGetImageForFindMatch can return a null image
https://bugs.webkit.org/show_bug.cgi?id=116251
<rdar://problem/13277246>
Reviewed by Simon Fraser.
Don't send didGetImageForFindMatch if we didn't get an image for
the find match, which can happen if the selection is not visible.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::getImageForFindMatch):
- 4:38 PM Changeset in webkit [150211] by
-
- 2 edits in trunk/Tools
Fix the hard-coded names of EWS bots that run tests.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.did_pass_testing_ews):
- 2:32 PM Changeset in webkit [150210] by
-
- 2 edits in trunk/Source/WebCore
Do not indefinitely cache resources from blob URLs.
Reviewed by Alexey Proskuryakov.
Alexey pointed out after I landed r150169 that blob URLs backed by
files should return an error if the file changed after the URL was
created. By indefinitely caching them in memory, we don't give the
loader a chance to check for modification. Remove "blob" from the list
of schemes that should be indefinitely cached.
- platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):
- 2:23 PM Changeset in webkit [150209] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: canvas/philip/tests/2d.text.draw.fontface.notinpage.html fails
https://bugs.webkit.org/show_bug.cgi?id=116245
Add a passing/failing test expectation.
- platform/mac/TestExpectations:
- 2:18 PM Changeset in webkit [150208] by
-
- 2 edits in trunk/LayoutTests
[Mac] fast/events/mouse-cursor-image-set.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=116244
Add a flaky test expectation on Mac.
- platform/mac/TestExpectations:
- 2:04 PM Changeset in webkit [150207] by
-
- 4 edits1 move1 add1 delete in trunk
[CSS] CSS Variables are case-sensitive
https://bugs.webkit.org/show_bug.cgi?id=116239
Reviewed by Ryosuke Niwa.
Source/WebCore:
The CSS Variables specification states that variables are
case-sensitive, unlike other CSS properties.
Test: fast/css/variables/case-sensitive.html
- css/CSSParser.cpp:
(WebCore::CSSParserString::substring): Replace
the now unnecessary lowerSubstring() with this method.
Also, since the method is only used by the CSS variables
implementation, #ifdef it.
(WebCore::CSSParser::createPrimitiveVariableNameValue):
(WebCore::CSSParser::storeVariableDeclaration):
Do not normalize variable declarations to lowercase.
- css/CSSParserValues.h:
(CSSParserString): Replace the lowerSubstring() declaration
and wrap with #if/#endif.
LayoutTests:
- fast/css/variables/case-sensitive-expected.html: Renamed from
fast/css/variables/case-insensitive-expected.html.
- fast/css/variables/case-sensitive.html: Renamed from
LayoutTests/fast/css/variables/case-insensitive.html.
- 2:02 PM Changeset in webkit [150206] by
-
- 6 edits in trunk/Source
svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled.
<rdar://problem/13837408> and https://bugs.webkit.org/show_bug.cgi?id=115917
Reviewed by Sam Weinig.
Source/WebCore:
Give WebKit2 the ability to not mis-cast.
- loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::isEmptyFrameLoaderClient): Defaults to false, and include a FIXME
to remove it once https://bugs.webkit.org/show_bug.cgi?id=116233 is resolved.
- loader/EmptyClients.h: Make isEmptyFrameLoaderClient() return true, and add a FIXME to remove it.
Source/WebKit2:
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader): ASSERT that either there’s a frame and page ID, or
that the client cannot be asked for credentials.
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleLoad): Only cast the FrameLoaderClient and get WebFrame/WebPage
if that is actually possible. Set the clientCredentialPolicy based on whether or not WebFrame/WebPage are
available since they are needed to ask the UIProcess for credentials. ASSERT that either there’s both
a frame and page ID or that the client won’t be asked for credentials.
- 1:50 PM Changeset in webkit [150205] by
-
- 5 edits in trunk/Source/WebKit/mac
-webView:updateHistoryTitle:forURL: does not pass a frame to the delegate
https://bugs.webkit.org/show_bug.cgi?id=116243
Reviewed by Anders Carlsson.
Added a WebFrame parameter to the delegate method.
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::setTitle): Pass the frame to the delegate. Maintain
compatibility with clients that implement the old delegate method that
doesn’t take a frame.
- WebView/WebDelegateImplementationCaching.h:
(WebHistoryDelegateImplementationCache): Added a field to cache the
implementation of the old delegate method.
- WebView/WebHistoryDelegate.h: Changed the signature of the delegate method.
- WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]): Cache the implementation
of the new delegate method, but also check for the old one.
- 1:23 PM Changeset in webkit [150204] by
-
- 6 edits18 adds in trunk
[GTK] Build Xvfb with jhbuild
https://bugs.webkit.org/show_bug.cgi?id=115907
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-16
Reviewed by Martin Robinson.
Tools:
Build our own Xvfb so that we can avoid problems with the system Xvfb
relying on symbols not present in our jhbuilt libraries such as pixman,
and also to ensure we have the fix for a GLX module crasher.
- DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues): enable accelerated compositing.
- gtk/install-dependencies: list packages required for building Xvfb.
- gtk/jhbuild.modules: add xserver as a jhbuild module.
- gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
- gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
initializing the GLX module for Xvfb.
LayoutTests:
Unskip and create baselines for transforms/3d and some webgl tests. We can unskip
more, but I prefer to only dip the toe in the waters first, to see how the bots
react.
- platform/gtk/TestExpectations:
- platform/gtk/transforms/3d/general/perspective-non-layer-expected.txt: Added.
- platform/gtk/transforms/3d/general/perspective-units-expected.txt: Added.
- platform/gtk/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
- platform/gtk/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-origins-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
- platform/gtk/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
- 12:37 PM Changeset in webkit [150203] by
-
- 2 edits in tags/Safari-537.42/Source/WebKit/mac
Merged r150194.
- 12:33 PM Changeset in webkit [150202] by
-
- 2 edits in tags/Safari-537.42/Source/WebKit/mac
Merge r150180.
- 12:19 PM Changeset in webkit [150201] by
-
- 2 edits in trunk/LayoutTests
Add more Mac test expectations.
- platform/mac/TestExpectations:
- 12:13 PM Changeset in webkit [150200] by
-
- 2 edits in trunk/Source/WebKit2
Make the Find Banner in Safari work again with the docked Web Inspector.
https://webkit.org/b/116182
rdar://problem/13857423
Reviewed by Benjamin Poulain.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
(WebKit::WebInspectorProxy::platformDetach):
Preserve the top position of the inspected view so banners in Safari still work.
- 12:11 PM Changeset in webkit [150199] by
-
- 2 edits in trunk/Source/JavaScriptCore
JSValue shouldn't protect/unprotect its context
https://bugs.webkit.org/show_bug.cgi?id=116234
Reviewed by Mark Hahnenberg.
Our retain on _context is sufficient.
- API/JSValue.mm:
(-[JSValue initWithValue:inContext:]):
(-[JSValue dealloc]):
- 12:09 PM Changeset in webkit [150198] by
-
- 2 edits in trunk/Tools
[jhbuild] Should remove the sources directory as well when cleaning
https://bugs.webkit.org/show_bug.cgi?id=116229
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-16
Reviewed by Martin Robinson.
- Scripts/update-webkit-libs-jhbuild:
(cleanJhbuild): remove the Source directory as well when cleaning.
- 12:08 PM Changeset in webkit [150197] by
-
- 5 edits in trunk/Source/WebKit2
[wk2] Minimum layout width is lost if the WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=116202
<rdar://problem/13202320>
Reviewed by Darin Adler.
Send the minimum layout width to the WebProcess upon initialization,
so that crashed-and-restarted WebProcesses have the correct width.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
Add minimumLayoutWidth WebPage creation parameter.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
Send the current minimumLayoutWidth to the WebPage when it's created.
(WebKit::WebPageProxy::setMinimumLayoutWidth):
Store minimumLayoutWidth changes that come in while the WebProcess is
not valid, so that the correct width is sent once it is restarted.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set minimumLayoutWidth to the value provided by our creation parameters.
- 12:03 PM Changeset in webkit [150196] by
-
- 5 edits in trunk/Source
Crash properly on iOS
https://bugs.webkit.org/show_bug.cgi?id=115782
Reviewed by Darin Adler.
Improve crash handling. <rdar://problem/13842771>
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- 12:00 PM Changeset in webkit [150195] by
-
- 2 edits in trunk/LayoutTests
Add a test expectation per bug 116238 and remove lines erroneously added in r150090.
- platform/mac/TestExpectations:
- 11:40 AM Changeset in webkit [150194] by
-
- 2 edits in trunk/Source/WebKit/mac
Re-land r150168 with some OS version guards.
- WebView/WebFrameView.mm:
(-[WebFrameView drawRect:]):
(-[WebFrameView wantsUpdateLayer]):
(-[WebFrameView updateLayer]):
- 11:30 AM Changeset in webkit [150193] by
-
- 1 edit2 adds in trunk/LayoutTests
Mac rebaseline. The flakiness dashboard tells us that it started at r150101
but reverting the change locally didn't fix the problem as far as Beth and I checked.
- platform/mac/platform/mac/fast/text/thai-combining-mark-positioning-expected.txt: Added.
- platform/mac/platform/mac/fast/text/webfont-after-tiny-monospace-text-expected.txt: Added.
- 11:30 AM Changeset in webkit [150192] by
-
- 2 edits in trunk
[GTK] [CMake] Disable the shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=116237
Reviewed by Gustavo Noronha Silva.
- Source/cmake/OptionsGTK.cmake: Disable shadow DOM by default.
- 11:22 AM Changeset in webkit [150191] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Documentation for WEBKIT_DEBUG logging channels is out of date
https://bugs.webkit.org/show_bug.cgi?id=114764
Reviewed by Gustavo Noronha Silva.
- docs/webkitenvironment.xml: Update documentation to reflect current list of
logging channels.
- 11:19 AM Changeset in webkit [150190] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
observeUseKindOnNode doesn't contain a case for KnownCellUse
https://bugs.webkit.org/show_bug.cgi?id=116130
This would just lead to us being overly conservative when deciding
whether we should unbox GetLocals with KnownCellUse UseKinds.
Reviewed by Filip Pizlo.
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::observeUseKindOnNode):
- 11:16 AM Changeset in webkit [150189] by
-
- 5 edits2 adds in trunk
[GTK] Add support for building WebCore to the cmake build
https://bugs.webkit.org/show_bug.cgi?id=116128
Reviewed by Gustavo Noronha Silva.
.:
- Source/PlatformGTK.cmake: Added.
- Source/cmake/OptionsGTK.cmake: Added more logic and variables to support WebCore and properly
defined some existing variables.
Source/WebCore:
- PlatformGTK.cmake: Added.
- platform/gtk/GtkVersioning.c: Include "config.h" because we removed
the autotoolsconfig.h include from the header.
- platform/gtk/GtkVersioning.h: Remove autotoolsconfig.h include to support for
non-autotools build systems.
- 11:12 AM Changeset in webkit [150188] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: infrequent segfault in DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks()
https://bugs.webkit.org/show_bug.cgi?id=116134
CodeBlock and JITCode should be ThreadSafeRefCounted. We're going to
start using them on more threads very soon (with concurrent
compilation). This patch also fixes the specific place where we were
superfluously creating a RefPtr.
Reviewed by Oliver Hunt.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::getJITType):
- jit/JITCode.h:
- 11:04 AM Changeset in webkit [150187] by
-
- 9 edits in trunk/Source/WebCore
DocumentOrderedMap doesn't need to have two HashMaps
https://bugs.webkit.org/show_bug.cgi?id=116167
Reviewed by Geoffrey Garen.
Previously, we had two hash maps: m_map and m_duplicateCounts in DocumentOrderedMap to keep track
of the first element and the number of duplicates for a given name. This patch simplifies this structure
by having a single hash map that contains both the pointer and the number of duplicates.
In addition, this patch fixes a regression introduced in r149652 that window and document name maps
were not updated for some elements inside a SVG use element, and makes use of the newly added list of
the matching elements in SelectorQuery.
- dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::clear): Updated to use the new hash map.
(WebCore::DocumentOrderedMap::add): Ditto.
(WebCore::DocumentOrderedMap::remove): Ditto.
(WebCore::DocumentOrderedMap::get): Ditto.
(WebCore::DocumentOrderedMap::getAllElementsById): Added.
- dom/DocumentOrderedMap.h:
(WebCore::DocumentOrderedMap::MapEntry::MapEntry): Added.
(WebCore::DocumentOrderedMap::containsSingle): Updated to use new hash map.
(WebCore::DocumentOrderedMap::contains): Ditto.
(WebCore::DocumentOrderedMap::containsMultiple): Ditto.
- dom/Element.cpp:
(WebCore::Element::insertedInto): This function didn't add this element to window and document's name maps
if the element had already been inserted into a tree scope, and the current call was inserting an ancestor
of the tree scope into the document. We were exiting early per scope != treeScope().
Fixed the bug by splitting updateId into two functions updateIdForTreeScope and updateIdForDocument.
The former is called when this element is inserted into a new tree scope, and the latter is called when
this element is inserted into a HTML document even if it had already been inside some tree scope.
(WebCore::Element::removedFrom): This function didn't remove this element from tree scope's id maps if
the tree scope wasn't a document. Fixed the bug by simply checking that the removal happens beneath the
current tree scope.
(WebCore::Element::updateName):
(WebCore::Element::updateNameForTreeScope): Renamed from updateName.
(WebCore::Element::updateNameForDocument): Extracted from updateName.
(WebCore::Element::updateId):
(WebCore::Element::updateIdForTreeScope): Renamed from updateId.
(WebCore::Element::updateIdForDocument): Extracted from updateId.
- dom/Element.h:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::canUseIdLookup): Refactored to return the id subselector instead of checking if
the first subselector happens to be matching an id.
(WebCore::SelectorDataList::execute): Use the subselector canUseIdLookup returned. Also make use of newly
added getAllElementsById when there are multiple matching elements for a given id.
- dom/SelectorQuery.h:
- dom/TreeScope.cpp:
(WebCore::TreeScope::getAllElementsById): Added.
- dom/TreeScope.h:
- 10:54 AM Changeset in webkit [150186] by
-
- 18 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
Implement a probe mechanism for JIT generated code.
https://bugs.webkit.org/show_bug.cgi?id=115705.
Reviewed by Geoffrey Garen.
The probe is in the form of a MacroAssembler pseudo instruction.
It takes 3 arguments: a ProbeFunction, and 2 void* args.
When inserted into the JIT at some code generation site, the probe
pseudo "instruction" will emit a minimal amount of code to save the
stack pointer, 1 (or more) scratch register(s), and the probe
arguments into a ProbeContext record on the stack. The emitted code
will then call a probe trampoline to do the rest of the work, which
consists of:
- saving the remaining registers into the ProbeContext.
- calling the ProbeFunction, and passing it the ProbeContext pointer.
- restoring the registers from the ProbeContext after the ProbeFunction returns, and then returning to the JIT generated code.
The ProbeContext is stack allocated and is only valid for the duration
that the ProbeFunction is executing.
If the user supplied ProbeFunction alters the register values in the
ProbeContext, the new values will be installed into the registers upon
returning from the probe. This can be useful for some debugging or
testing purposes.
The probe mechanism is built conditional on USE(MASM_PROBE) which is
defined in config.h. USE(MASM_PROBE) will off by default.
This changeset only implements the probe mechanism for X86 and X86_64.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- assembler/MacroAssembler.h:
(MacroAssembler):
(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
- assembler/MacroAssemblerX86.h:
(MacroAssemblerX86):
(JSC::MacroAssemblerX86::trustedImm32FromPtr):
(JSC::MacroAssemblerX86::probe):
- assembler/MacroAssemblerX86Common.cpp: Added.
(JSC::MacroAssemblerX86Common::ProbeContext::dumpCPURegisters):
- CPU specific register dumper called by ProbeContext::dump().
(JSC::MacroAssemblerX86Common::ProbeContext::dump):
- Prints the ProbeContext to the DataLog.
- assembler/MacroAssemblerX86Common.h:
(MacroAssemblerX86Common):
(CPUState): Added.
(ProbeContext): Added.
- assembler/MacroAssemblerX86_64.h:
(MacroAssemblerX86_64):
(JSC::MacroAssemblerX86_64::trustedImm64FromPtr):
(JSC::MacroAssemblerX86_64::probe):
- assembler/X86Assembler.h:
- config.h: Added WTF_USE_MASM_PROBE flag.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
- jit/JITStubsX86.h:
- jit/JITStubsX86Common.h: Added.
- jit/JITStubsX86_64.h:
- 10:23 AM Changeset in webkit [150185] by
-
- 2 edits in releases/WebKitGTK/webkit-2.0
[GTK] WebAudio doesn't build in WebKitGTK+ 2.0.2
https://bugs.webkit.org/show_bug.cgi?id=116154
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-16
Reviewed by Gustavo Noronha Silva.
Don't override the value of ENABLE_WEB_AUDIO selected in the
configure script.
- Source/autotools/SetupWebKitFeatures.m4:
- 10:06 AM Changeset in webkit [150184] by
-
- 3 edits in trunk/LayoutTests
Enable the CSSVariables setting in css-variable-definition.html test
https://bugs.webkit.org/show_bug.cgi?id=116231
Reviewed by Andreas Kling.
CSSVariablesEnabled setting must be set to true to allow
CSSVariables at runtime.
Modified also the indent size to 4 spaces.
- css3/css-variable-definition-expected.html:
- css3/css-variable-definition.html:
- 8:44 AM Changeset in webkit [150183] by
-
- 6 edits in trunk/Source/WebCore
[Mac] Make Clipboard::create functions for Mac platform independent by moving Pasteboard creation to Pasteboard functions
https://bugs.webkit.org/show_bug.cgi?id=116179
Reviewed by Andreas Kling.
- dom/Clipboard.cpp:
(WebCore::Clipboard::createForCopyAndPaste): Moved the function here from
ClipboardMac, and have it use Pasteboard functions that are not Mac-specific.
(WebCore::Clipboard::create): Ditto.
(WebCore::Clipboard::createForDragAndDrop): Ditto.
- platform/DragData.h:
(WebCore::DragData::pasteboardName): Made this const.
- platform/Pasteboard.h: Added new create functions, used by the clipboard
create functions above.
- platform/mac/ClipboardMac.mm: Removed the functions that were moved to the
Clipboard.cpp file.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::createForCopyAndPaste): Added.
(WebCore::Pasteboard::createPrivate): Added.
(WebCore::Pasteboard::createForDragAndDrop): Added.
- 8:19 AM Changeset in webkit [150182] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] TargetFrame and innerNodeFrame confused
https://bugs.webkit.org/show_bug.cgi?id=102907
Reviewed by Martin Robinson.
- webkit/webkithittestresult.cpp:
(WebKit::kit):
- 7:38 AM WebKitGTK/TrackingMemoryErrors edited by
- (diff)
- 5:49 AM Changeset in webkit [150181] by
-
- 2 edits in trunk/Tools
[EFL] Remove Intel Wk2 Buildbots from Master
https://bugs.webkit.org/show_bug.cgi?id=116149
Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
since Gyuyoung Kim from Samsung plans to take over and maintain it.
Reviewed by Benjamin Poulain.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 3:07 AM Changeset in webkit [150180] by
-
- 2 edits in trunk/Source/WebKit/mac
Unreviewed, rolling out r150168.
http://trac.webkit.org/changeset/150168
https://bugs.webkit.org/show_bug.cgi?id=116214
broke the world on Mountain Lion (Requested by thorton on
#webkit).
- WebView/WebFrameView.mm:
(-[WebFrameView drawRect:]):
- 2:47 AM Changeset in webkit [150179] by
-
- 2 edits in trunk/Source/WebKit2
[Win] Unreviewed buildfix after r150161.
'Unknown' in HTTPRequest.cpp is ambiguous symbol with MSVC,
because it is also defined in MS SDK 7.1 winioctl.h.
- UIProcess/InspectorServer/HTTPRequest.cpp:
(WebKit::HTTPRequest::HTTPRequest):
- 1:46 AM Changeset in webkit [150178] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] PluginInformation.cpp fails to build because of missing ENABLE(NETSCAPE_PLUGIN_API) guard
https://bugs.webkit.org/show_bug.cgi?id=116018
Rubber-stamped by Jocelyn Turcotte.
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::getPluginModuleInformation):
May 15, 2013:
- 10:56 PM Changeset in webkit [150177] by
-
- 2 edits in trunk/Source/WebCore
Fix a thinko.
We want to invalidate the file icon loader if it exists, not create it!
- html/FileInputType.cpp:
(WebCore::FileInputType::requestIcon):
- 9:37 PM Changeset in webkit [150176] by
-
- 2 edits in trunk/Source/WebCore
Move drag-specific Clipboard functions inside ENABLE(DRAG_SUPPORT)
https://bugs.webkit.org/show_bug.cgi?id=116176
Reviewed by Andreas Kling.
- dom/Clipboard.cpp:
(WebCore::Clipboard::writeRange):
(WebCore::Clipboard::writePlainText):
(WebCore::Clipboard::writeURL):
Move these three functions inside ENABLE(DRAG_SUPPORT). Even though their names do
not make it obvious, these are here only for use by dragging code. Later we may
refactor them away entirely, but for now it's good not to compile them in on any
platform that does not support dragging.
- 9:34 PM Changeset in webkit [150175] by
-
- 6 edits in trunk/Source/WebKit2
Enable printing in plugins
https://bugs.webkit.org/show_bug.cgi?id=116201
<rdar://problem/12347902>
Reviewed by Alexey Proskuryakov.
Add the printing entitlement so that legacy printing drivers can
customize the print panel. Update the printing rules and enable them
for the plugins.
- Configurations/PluginService.entitlements:
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
- Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
- Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
- 9:20 PM Changeset in webkit [150174] by
-
- 4 edits in trunk/Source
Versioning.
- 9:18 PM Changeset in webkit [150173] by
-
- 1 copy in tags/Safari-537.42
New Tag.
- 8:21 PM Changeset in webkit [150172] by
-
- 7 edits in trunk/Source
Source/JavaScriptCore: Another Windows build fix attempt after r150160.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
- JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
Source/WebKit: Revert the previous commit.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win: Revert the previous commit.
- WebKit.vcproj/WebKitExports.def.in:
- 8:15 PM Changeset in webkit [150171] by
-
- 4 edits in trunk/Source/WebKit
Windows build fix attempt after r150160.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 8:10 PM Changeset in webkit [150170] by
-
- 4 edits in trunk/Source/WebKit
Windows build fix attempt after r150156.
Source/WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Source/WebKit/win:
- WebKit.vcproj/WebKitExports.def.in:
- 7:54 PM Changeset in webkit [150169] by
-
- 5 edits4 moves3 adds4 deletes in trunk
Resources from non-HTTP schemes should not be cached indefinitely
https://bugs.webkit.org/show_bug.cgi?id=113626
Reviewed by Ryosuke Niwa.
Source/WebCore:
With the exception of schemes that we know will always return the same
result for a given URL, we should not indefinitely cache non-HTTP
resources when their freshness cannot be verified.
Writing a test for this is blocked on https://webkit.org/b/116199.
The following two existing tests of memory cache behavior were
converted to HTTP tests so that they continue to function as expected:
Tests: http/tests/cache/display-image-unset-allows-cached-image-load.html
http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::freshnessLifetime): Returned a freshness
lifetime of 0 for non-HTTP schemes that can't be indefinitely cached.
- platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldCacheResponsesFromURLSchemeIndefinitely):
Checked whether the scheme is blob:, data:, or applewebdata:.
- platform/SchemeRegistry.h:
LayoutTests:
Convert existing memory cache tests to HTTP tests.
- fast/loader/resources/compass.jpg: Removed.
- fast/loader/resources/image1.html: Removed.
- fast/loader/resources/image2.html: Removed.
- fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Removed.
- http/tests/cache/display-image-unset-allows-cached-image-load-expected.txt: Renamed from LayoutTests/fast/loader/display-image-unset-allows-cached-image-load-expected.txt.
- http/tests/cache/display-image-unset-allows-cached-image-load.html: Renamed from LayoutTests/fast/loader/display-image-unset-allows-cached-image-load.html.
- http/tests/cache/resources/cached-image.html: Renamed from LayoutTests/fast/loader/resources/cached-image.html.
- http/tests/cache/resources/image1.html: Added.
- http/tests/cache/resources/image2.html: Added.
- http/tests/cache/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
- http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html: Renamed from LayoutTests/fast/loader/willsendrequest-returns-null-for-memory-cache-load.html.
- 7:05 PM Changeset in webkit [150168] by
-
- 2 edits in trunk/Source/WebKit/mac
Avoid backing store for the WebFrameView's layer when the WebView is layer-backed
https://bugs.webkit.org/show_bug.cgi?id=116172
Reviewed by Tim Horton.
When the WebView is layer-backed, AppKit will create a layer with backing store for
the WebFrameView because it implements drawRect:. However, this method only paints
when there is no documentView, so this layer’s backing store is wasteful.
We can avoid allocation of this backing store by implementing -wantsUpdateLayer
and -updateLayer, and setting the view’s backgroundColor.
- WebView/WebFrameView.mm:
(-[WebFrameView wantsUpdateLayer]):
(-[WebFrameView updateLayer]):
- 6:35 PM Changeset in webkit [150167] by
-
- 2 edits in trunk/Source/WebCore
makeRGBAFromNSColor throws an exception if given a color in a greyscale colorspace
https://bugs.webkit.org/show_bug.cgi?id=116198
<rdar://problem/13904395>
Reviewed by Simon Fraser.
Block Objective-C exceptions in makeRGBAFromNSColor.
Remove a comment saying that they're impossible.
Convert the incoming color to the DeviceRGB colorspace to match
existing color sources. Some rare cases (attributed strings that come
from PDFKit) can have DeviceGrayscale color spaces, which would
previously throw an exception here.
- platform/graphics/mac/ColorMac.mm:
(WebCore::makeRGBAFromNSColor):
- 6:24 PM Changeset in webkit [150166] by
-
- 3 edits in trunk/Source/WebCore
BUILD FIX (r150140): Frame::editor() should return a reference for iOS, too
- platform/ios/ClipboardIOS.mm:
(WebCore::ClipboardIOS::ClipboardIOS):
(WebCore::ClipboardIOS::hasData):
(WebCore::ClipboardIOS::clearData):
(WebCore::ClipboardIOS::clearAllData):
(WebCore::ClipboardIOS::getData):
(WebCore::ClipboardIOS::setData):
(WebCore::ClipboardIOS::types):
(WebCore::ClipboardIOS::writeRange):
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::getStringSelection):
(WebCore::Pasteboard::writeSelection):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::writeImage):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
(WebCore::Pasteboard::documentFragment):
- 6:17 PM Changeset in webkit [150165] by
-
- 5 edits in trunk/Source/WebCore
Stop using the factory pattern in FileIconLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=116197
Reviewed by Andreas Kling.
Move the FileIconLoader member out of FileIconLoaderClient and into FileInputType and remove the factory gunk.
- html/FileInputType.cpp:
(WebCore::FileInputType::~FileInputType):
(WebCore::FileInputType::requestIcon):
- html/FileInputType.h:
(FileInputType):
- platform/FileIconLoader.cpp:
(WebCore::FileIconLoader::invalidate):
- platform/FileIconLoader.h:
(WebCore::FileIconLoaderClient::~FileIconLoaderClient):
(FileIconLoader):
- 6:06 PM Changeset in webkit [150164] by
-
- 2 edits in trunk/Source/WTF
Unreviewed build fix after r150123
- wtf/CMakeLists.txt:
- 5:48 PM Changeset in webkit [150163] by
-
- 5 edits in trunk/Source/WebCore
Fix FileChooserClient design
https://bugs.webkit.org/show_bug.cgi?id=116195
Reviewed by Andreas Kling.
FileChooserClient doesn't match the standard WebCore client idiom of only having virtual member functions.
Instead it holds on to its FileChooser and it's even a factory for creating new file choosers(!).
Fix this by making it an abstract class, and moving FileChooser into FileInputType.
- html/FileInputType.cpp:
(WebCore::FileInputType::~FileInputType):
Invalidate the file chooser.
(WebCore::FileInputType::handleDOMActivateEvent):
Apply the file chooser settings.
(WebCore::FileInputType::applyFileChooserSettings):
Recreate the file chooser with new settings.
(WebCore::FileInputType::receiveDropForDirectoryUpload):
Apply the settings.
- platform/FileChooser.cpp:
(WebCore::FileChooser::invalidate):
Set m_client to null.
(WebCore::FileChooser::chooseFiles):
Early return.
- platform/FileChooser.h:
- 5:42 PM Changeset in webkit [150162] by
-
- 3 edits in trunk/Source/WebCore
ScriptedAnimationController::setThrottled should extend MinimumAnimationInterval
https://bugs.webkit.org/show_bug.cgi?id=116193
Reviewed by Darin Adler
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::setThrottled):
(WebCore::ScriptedAnimationController::scheduleAnimation):
- dom/ScriptedAnimationController.h:
(ScriptedAnimationController):
- Fixes for review comments.
- 5:36 PM Changeset in webkit [150161] by
-
- 17 edits2 moves in trunk/Source
Move HTTPRequest class to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=116192
Reviewed by Darin Adler.
Source/WebCore:
HTTPRequest is only used by the "remote inspector" feature in WebKit2,
so there's no need to have it in WebCore.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit2:
Move HTTPRequest to WebKit2 and put it in the WebKit namespace.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- UIProcess/InspectorServer/HTTPRequest.cpp: Renamed from Source/WebCore/platform/network/HTTPRequest.cpp.
- UIProcess/InspectorServer/HTTPRequest.h: Renamed from Source/WebCore/platform/network/HTTPRequest.h.
- UIProcess/InspectorServer/WebInspectorServer.cpp:
- UIProcess/InspectorServer/WebInspectorServer.h:
(WebInspectorServer):
- UIProcess/InspectorServer/WebSocketServerClient.h:
(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):
- UIProcess/InspectorServer/WebSocketServerConnection.cpp:
- UIProcess/InspectorServer/WebSocketServerConnection.h:
(WebKit):
(WebSocketServerConnection):
- 5:29 PM Changeset in webkit [150160] by
-
- 11 edits in trunk/Source
RefCountedArray needs to use vector initialisers for its backing store
https://bugs.webkit.org/show_bug.cgi?id=116194
Reviewed by Gavin Barraclough.
Source/JavaScriptCore:
Use an out of line function to clear the exception stack to avoid
needing to include otherwise unnecessary headers all over the place.
Everything else is just being updated to use that.
- bytecompiler/BytecodeGenerator.cpp:
- interpreter/CallFrame.h:
(JSC::ExecState::clearSupplementaryExceptionInfo):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::throwException):
- runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
- runtime/VM.cpp:
(JSC):
(JSC::VM::clearExceptionStack):
- runtime/VM.h:
(VM):
(JSC::VM::exceptionStack):
Source/WebCore:
Update to use new functions for operating on the exception stack.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStackFromException):
Source/WTF:
Use VectorOperations to operate on the backing store
- wtf/RefCountedArray.h:
(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::operator=):
(WTF::RefCountedArray::~RefCountedArray):
- 5:28 PM Changeset in webkit [150159] by
-
- 3 edits in trunk/Source/WebCore
ScriptedAnimationController::setThrottled should extend MinimumAnimationInterval
https://bugs.webkit.org/show_bug.cgi?id=116193
Reviewed by Simon Fraser.
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::ScriptedAnimationController):
- initialize m_throttled
(WebCore::ScriptedAnimationController::setThrottled):
- sets m_throttled, reschedule when this changes.
(WebCore::ScriptedAnimationController::scheduleAnimation):
- if throtled don't use a display link, and extend the timeout.
- dom/ScriptedAnimationController.h:
(ScriptedAnimationController):
- Added m_throttled
- 5:12 PM Changeset in webkit [150158] by
-
- 5 edits in trunk/Source/WebKit2
[GTK] [WebKit2] enable displaying console.log messages to system console
https://bugs.webkit.org/show_bug.cgi?id=115578
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-05-15
Reviewed by Martin Robinson.
Add a setting to enable/disable displaying of page messages to system
console. Property is called enable-write-console-messages-to-stdout.
Getter API function is
webkit_settings_get_enable_write_console_messages_to_stdout
Setter API function is
webkit_settings_set_enable_write_console_messages_to_stdout
- UIProcess/API/gtk/WebKitSettings.cpp:
(webKitSettingsSetProperty):
(webKitSettingsGetProperty):
(webkit_settings_class_init):
(webkit_settings_get_enable_write_console_messages_to_stdout):
(webkit_settings_set_enable_write_console_messages_to_stdout):
- UIProcess/API/gtk/WebKitSettings.h:
- UIProcess/API/gtk/docs/webkit2gtk-sections.txt:
- UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
(testWebKitSettings):
- 4:43 PM Changeset in webkit [150157] by
-
- 2 edits in trunk/Source/WebKit/gtk
Fix build.
- webkit/webkitwebview.cpp:
(webkitWebViewDirectionChanged):
- 4:00 PM Changeset in webkit [150156] by
-
- 13 edits in trunk/Source
Process suppression should throttle scripted animations
https://bugs.webkit.org/show_bug.cgi?id=115812
Reviewed by Simon Fraser.
<rdar://problem/13799726>
Source/WebCore:
- WebCore.exp.in:
- Expose Page::setThrottled
- dom/Document.cpp:
(WebCore::Document::scriptedAnimationControllerSetThrottled):
(WebCore):
- dom/Document.h:
(Document):
- Forwards to ScriptedAnimationController::setThrottled
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::setThrottled):
(WebCore):
- dom/ScriptedAnimationController.h:
- Force use of a timer.
(ScriptedAnimationController):
- page/Page.cpp:
(WebCore::Page::setThrottled):
(WebCore):
- page/Page.h:
(Page):
- When under throttling force the ScriptedAnimationController to use a timer.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setThrottled):
(WebKit):
- WebProcess/WebPage/WebPage.h:
(WebPage):
- Added setThrottled, forwards to WebCore::Page.
- WebProcess/WebProcess.cpp:
(WebKit):
(WebKit::WebProcess::setProcessSuppressionEnabled):
- WebProcess/WebProcess.h:
(WebProcess):
- Intercept calls to setProcessSuppressionEnabled, also mark all pages as being throttled.
- 3:59 PM Changeset in webkit [150155] by
-
- 3 edits4 adds in trunk
Implement run-in remove child cases.
https://bugs.webkit.org/show_bug.cgi?id=86520
Move runin to original position when sibling element is destroyed.
Reviewed by David Hyatt.
Source/WebCore:
Tests: fast/runin/runin-remove-child-simple.html
fast/runin/runin-sibling-inline.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded):
If moveRunInUnderSiblingBlockIfNeeded is called when the sibling run-in block
is being destroyed, it means that the run-in is moving to original position and
we do not need to do nothing.
LayoutTests:
- fast/runin/runin-remove-child-simple-expected.txt: Added.
- fast/runin/runin-remove-child-simple.html: Added.
- fast/runin/runin-sibling-inline-expected.txt: Added.
- fast/runin/runin-sibling-inline.html: Added.
- 3:43 PM Changeset in webkit [150154] by
-
- 14 edits2 deletes in trunk/Source/WebCore
Remove WebSocketHandshakeResponse class
https://bugs.webkit.org/show_bug.cgi?id=116190
Reviewed by Andreas Kling.
Just use ResourceResponse instead of WebSocketHandshakeResponse.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::readServerHandshake):
(WebCore::WebSocketHandshake::serverWebSocketProtocol):
(WebCore::WebSocketHandshake::serverSetCookie):
(WebCore::WebSocketHandshake::serverSetCookie2):
(WebCore::WebSocketHandshake::serverUpgrade):
(WebCore::WebSocketHandshake::serverConnection):
(WebCore::WebSocketHandshake::serverWebSocketAccept):
(WebCore::WebSocketHandshake::serverHandshakeResponse):
(WebCore::WebSocketHandshake::readHTTPHeaders):
- Modules/websockets/WebSocketHandshake.h:
- Modules/websockets/WebSocketHandshakeResponse.cpp: Removed.
- Modules/websockets/WebSocketHandshakeResponse.h: Removed.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
- inspector/InspectorResourceAgent.h:
(WebCore):
(InspectorResourceAgent):
- 3:38 PM Changeset in webkit [150153] by
-
- 2 edits in trunk/Source/WebCore
[Mac] media engine may deliver NULL in-band "cue"
https://bugs.webkit.org/show_bug.cgi?id=116180
Reviewed by Jer Noble.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): NULL check before logging cue count.
- 3:01 PM Changeset in webkit [150152] by
-
- 2 edits in trunk/Source/WebCore
List platforms that still use the legacy clipboard instead of just saying "not Mac"
https://bugs.webkit.org/show_bug.cgi?id=116177
Reviewed by Andreas Kling.
dom/Clipboard.h: Replaced the "!MAC IOS" with a list of platforms still on the legacy model.
- 2:53 PM Changeset in webkit [150151] by
-
- 2 edits in trunk/Source/WebKit2
WKPageGetPluginInformationDisplayNameKey doesn't return the right key
https://bugs.webkit.org/show_bug.cgi?id=116188
Reviewed by Andreas Kling.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetPluginInformationDisplayNameKey):
- 2:51 PM Changeset in webkit [150150] by
-
- 3 edits in trunk/Source/WebCore
We should clear mainResource in DocumentLoader::cancelMainResourceLoad.
https://bugs.webkit.org/show_bug.cgi?id=116119
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-05-15
Reviewed by Oliver Hunt.
MainResourceLoader::clearResource() was left out in r146239 when moving MainResourceLoader::cancel()
to DocumentLoader::cancelMainResourceLoad(), we need to add it back to make sure m_mainResource is
cleared when we cancel the loader.
No new tests needed.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::continueAfterNavigationPolicy):
(WebCore::DocumentLoader::cancelMainResourceLoad):
(WebCore::DocumentLoader::clearMainResource):
(WebCore):
- loader/DocumentLoader.h: add helper method clearMainResource()
(DocumentLoader):
- 2:42 PM Changeset in webkit [150149] by
-
- 4 edits in trunk
More fixing after WebProcessShim renaming in r149074.
- Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm: (WebContentServiceInitializer): Updated a comment to mention the shim by its new name.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme: Updated to insert the right shim.
- 2:25 PM Changeset in webkit [150148] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r150051.
http://trac.webkit.org/changeset/150051
https://bugs.webkit.org/show_bug.cgi?id=116186
Broke all JSC tests on Mac and the author is unresponsive
(Requested by rniwa on #webkit).
- JavaScriptCore.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [150147] by
-
- 2 edits in trunk/Source/WebCore
[BlackBerry] When HTTP auth fails, only purge credentials that match the failed credentials
https://bugs.webkit.org/show_bug.cgi?id=116164
Patch by Joe Mason <jmason@blackberry.com> on 2013-05-15
Reviewed by Rob Buis.
Internal PR: 338490
Internally Reviewed By: Lyon Chen
When there are multiple HTTP requests in flight with the same bad credentials (common with
proxy auth if the user mistyped their password), the first 407 that's received will cause
the credentials to be purged and the password dialog to open for new credentials. This means
that all 407's received after this should only purge the credentials if they have not
already been updated from the dialog; otherwise they will be wiping out credentials that
haven't failed yet.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendRequestWithCredentials):
(WebCore::NetworkJob::purgeCredentials):
- 2:17 PM Changeset in webkit [150146] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove savedTimeoutReg from JITStackFrame for sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=116143
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-15
Reviewed by Geoffrey Garen.
Since r148119, timeoutCheckRegister is removed from baseline JIT.
So we don't need to save r8 register in JITStackFrame anymore for sh4.
- jit/JITStubs.cpp:
- jit/JITStubs.h:
(JITStackFrame):
- 1:51 PM Changeset in webkit [150145] by
-
- 4 edits in trunk/Source/WebCore
AX: Use caching when requesting children object on iOS
https://bugs.webkit.org/show_bug.cgi?id=116112
Reviewed by David Kilzer.
Building up the children list in the AX hierarchy can be time consuming. On iOS, this
is now much more noticeable (I believe due to the way tables calculate their AX ignored flag).
We can speed everything up if we just cache the isIgnored() attribute while building up children.
- accessibility/AXObjectCache.cpp:
(WebCore::AXAttributeCacheEnabler::AXAttributeCacheEnabler):
(WebCore):
(WebCore::AXAttributeCacheEnabler::~AXAttributeCacheEnabler):
- accessibility/AXObjectCache.h:
(AXAttributeCacheEnabler):
(WebCore):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityHitTest:]):
(-[WebAccessibilityObjectWrapper accessibilityElementCount]):
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper accessibilityContainer]):
- 1:43 PM Changeset in webkit [150144] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Fix for broken 32-bit build in SpeculativeJIT::checkArray().
https://bugs.webkit.org/show_bug.cgi?id=116184.
Rubber stamped by Mark Hahnenberg.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
- 1:30 PM Changeset in webkit [150143] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13902706> Lion: com.apple.tsm.uiserver sandbox error in Console when
launching Safari
Reviewed by Anders Carlsson.
- WebProcess/com.apple.WebProcess.sb.in: Silence the violation.
- 1:22 PM Changeset in webkit [150142] by
-
- 15 edits2 deletes in trunk/Source/WebCore
Remove WebSocketHandshakeRequest class
https://bugs.webkit.org/show_bug.cgi?id=116178
Reviewed by Andreas Kling.
Turns out WebSocketHandshakeRequest is just used by the web inspector, and there's no reason
why we can't just use a ResourceRequest instead.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::didOpenSocketStream):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::clientHandshakeRequest):
- Modules/websockets/WebSocketHandshake.h:
(WebCore):
- Modules/websockets/WebSocketHandshakeRequest.cpp: Removed.
- Modules/websockets/WebSocketHandshakeRequest.h: Removed.
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl):
- inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
- inspector/InspectorResourceAgent.h:
(WebCore):
(InspectorResourceAgent):
- platform/network/HTTPRequest.cpp:
(WebCore):
- 1:20 PM Changeset in webkit [150141] by
-
- 2 edits in trunk/Source/WebCore
Try to fix iOS build.
- platform/Pasteboard.h: Fix #if so that we don't try to compile pasteboard name code on iOS.
- 12:47 PM Changeset in webkit [150140] by
-
- 93 edits in trunk/Source
Frame::editor() should return a reference
https://bugs.webkit.org/show_bug.cgi?id=116037
Reviewed by Darin Adler.
Source/WebCore:
A frame's editor can never be null. Change Frame::editor() to return a reference to reflect this.
Also, make Frame::m_editor a const member variable so nobody will accidentally set it to null.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::hasMisspelling):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(AXAttributeStringSetSpelling):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::cloneChildNodes):
- dom/Document.cpp:
(WebCore::acceptsEditingFocus):
(WebCore::Document::setFocusedNode):
(WebCore::command):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::timerFired):
(WebCore::AlternativeTextController::applyDictationAlternative):
- editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::moveParagraphs):
- editing/DeleteButton.cpp:
(WebCore::DeleteButton::defaultEventHandler):
- editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::show):
- editing/DeleteButtonController.h:
(WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::mergeParagraphs):
(WebCore::DeleteSelectionCommand::doApply):
- editing/EditCommand.cpp:
(WebCore::EditCommand::EditCommand):
- editing/EditingStyle.cpp:
(WebCore::StyleChange::StyleChange):
- editing/Editor.cpp:
(WebCore::Editor::markMisspellingsAfterTypingToWord):
- editing/EditorCommand.cpp:
(WebCore::applyCommandToFrame):
(WebCore::executeToggleStyle):
(WebCore::executeApplyParagraphStyle):
(WebCore::expandSelectionToGranularity):
(WebCore::stateStyle):
(WebCore::valueStyle):
(WebCore::executeCopy):
(WebCore::executeCut):
(WebCore::executeDefaultParagraphSeparator):
(WebCore::executeDelete):
(WebCore::executeDeleteBackward):
(WebCore::executeDeleteBackwardByDecomposingPreviousCharacter):
(WebCore::executeDeleteForward):
(WebCore::executeDeleteToBeginningOfLine):
(WebCore::executeDeleteToBeginningOfParagraph):
(WebCore::executeDeleteToEndOfLine):
(WebCore::executeDeleteToEndOfParagraph):
(WebCore::executeDeleteToMark):
(WebCore::executeDeleteWordBackward):
(WebCore::executeDeleteWordForward):
(WebCore::executeFindString):
(WebCore::executeForwardDelete):
(WebCore::executeIgnoreSpelling):
(WebCore::executeInsertNewline):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):
(WebCore::executeToggleOverwrite):
(WebCore::executePaste):
(WebCore::executePasteGlobalSelection):
(WebCore::executePasteAndMatchStyle):
(WebCore::executePasteAsPlainText):
(WebCore::executeRedo):
(WebCore::executeRemoveFormat):
(WebCore::executeSelectToMark):
(WebCore::executeSetMark):
(WebCore::executeStyleWithCSS):
(WebCore::executeUseCSS):
(WebCore::executeSwapWithMark):
(WebCore::executeTakeFindStringFromSelection):
(WebCore::executeTranspose):
(WebCore::executeUndo):
(WebCore::executeYank):
(WebCore::executeYankAndSelect):
(WebCore::supportedCopyCut):
(WebCore::supportedPaste):
(WebCore::enabledVisibleSelection):
(WebCore::enabledVisibleSelectionAndMark):
(WebCore::enableCaretInEditableText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledInEditableText):
(WebCore::enabledDelete):
(WebCore::enabledPaste):
(WebCore::enabledRedo):
(WebCore::enabledTakeFindStringFromSelection):
(WebCore::enabledUndo):
(WebCore::stateOrderedList):
(WebCore::stateStyleWithCSS):
(WebCore::stateUnorderedList):
(WebCore::valueDefaultParagraphSeparator):
- editing/FrameSelection.cpp:
(WebCore::shouldAlwaysUseDirectionalSelection):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::nextWordPositionForPlatform):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modify):
(WebCore::shouldStopBlinkingDueToTypingCommand):
(WebCore::FrameSelection::shouldDeleteSelection):
(WebCore::FrameSelection::shouldChangeSelection):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::doApply):
- editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheck):
- editing/SpellingCorrectionCommand.cpp:
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::lastTypingCommandIfStillOpenForTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::typingAddedToOpenCommand):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
- editing/htmlediting.cpp:
(WebCore::createDefaultParagraphElement):
- editing/mac/EditorMac.mm:
(WebCore::Editor::pasteWithPasteboard):
- editing/markup.cpp:
(WebCore::createMarkup):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::endEditing):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleKeydownEvent):
(WebCore::TextFieldInputType::didSetValueByUserEdit):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::closeURL):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::clear):
- page/ContextMenuController.cpp:
(WebCore::insertUnicodeCharacter):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::checkOrEnableIfNeeded):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::find):
- page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
(WebCore::DragController::concludeEditDrag):
(WebCore::DragController::startDrag):
- page/EventHandler.cpp:
(WebCore::EventHandler::selectClosestWordFromMouseEvent):
(WebCore::EventHandler::handleMousePressEventSingleClick):
(WebCore::EventHandler::handlePasteGlobalSelection):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::defaultKeyboardEventHandler):
(WebCore::EventHandler::defaultTextInputEventHandler):
(WebCore::EventHandler::defaultBackspaceEventHandler):
- page/FocusController.cpp:
(WebCore::relinquishesEditingFocus):
- page/Frame.cpp:
(WebCore::Frame::rangeForPoint):
- page/Frame.h:
(Frame):
(WebCore::Frame::editor):
- page/Page.cpp:
(WebCore::Page::findString):
(WebCore::Page::findStringMatchingRanges):
(WebCore::Page::rangeOfString):
(WebCore::Page::markAllMatchesForText):
(WebCore::Page::setDeviceScaleFactor):
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::writeRange):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::asURL):
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::getStringSelection):
(WebCore::Pasteboard::getDataSelection):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::writeURLForTypes):
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):
(WebCore::Pasteboard::documentFragment):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::dictationAlternatives):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintTextMatchMarker):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
- testing/Internals.cpp:
(WebCore::spellchecker):
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::hasSpellingMarker):
(WebCore::Internals::hasAutocorrectedMarker):
(WebCore::Internals::setContinuousSpellCheckingEnabled):
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled):
(WebCore::Internals::setAutomaticLinkDetectionEnabled):
(WebCore::Internals::setAutomaticDashSubstitutionEnabled):
(WebCore::Internals::setAutomaticTextReplacementEnabled):
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled):
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore::Internals::toggleOverwriteModeEnabled):
(WebCore::Internals::hasGrammarMarker):
Source/WebKit/blackberry:
- WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
(WebCore::EditorClientBlackBerry::handleKeyboardEvent):
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementHasContinuousSpellCheckingEnabled):
- WebKitSupport/InPageSearchManager.cpp:
(BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
(BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectedText):
Source/WebKit/efl:
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::executeCoreCommandByName):
(DumpRenderTreeSupportEfl::isCommandEnabled):
- WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
(WebCore::EditorClientEfl::handleEditingKeyboardEvent):
- ewk/ewk_frame.cpp:
(ewk_frame_editable_set):
(ewk_frame_selection_get):
(ewk_frame_text_search):
(ewk_frame_text_matches_mark):
(ewk_frame_text_matches_highlight_set):
(ewk_frame_text_matches_highlight_get):
- ewk/ewk_view.cpp:
(ewk_view_selection_get):
(ewk_view_editor_command_execute):
Source/WebKit/gtk:
- WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::paint):
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::executeCoreCommandByName):
(DumpRenderTreeSupportGtk::isCommandEnabled):
- WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
(WebKit::EditorClient::executePendingEditorCommands):
(WebKit::EditorClient::handleKeyboardEvent):
- WebCoreSupport/WebViewInputMethodFilter.cpp:
(WebKit::WebViewInputMethodFilter::canEdit):
(WebKit::WebViewInputMethodFilter::confirmCompositionText):
(WebKit::WebViewInputMethodFilter::confirmCurrentComposition):
(WebKit::WebViewInputMethodFilter::cancelCurrentComposition):
(WebKit::WebViewInputMethodFilter::setPreedit):
- webkit/webkitwebframe.cpp:
(webkit_web_frame_replace_selection):
- webkit/webkitwebview.cpp:
(getLocationForKeyboardGeneratedContextMenu):
(webkit_web_view_focus_in_event):
(webkit_web_view_real_select_all):
(webkit_web_view_real_cut_clipboard):
(webkit_web_view_real_copy_clipboard):
(webkit_web_view_real_undo):
(webkit_web_view_real_redo):
(webkit_web_view_real_paste_clipboard):
(webkit_web_view_set_highlight_text_matches):
(webkit_web_view_can_cut_clipboard):
(webkit_web_view_can_copy_clipboard):
(webkit_web_view_can_paste_clipboard):
(webkit_web_view_delete_selection):
(webkit_web_view_set_editable):
(webkit_web_view_can_undo):
(webkit_web_view_can_redo):
Source/WebKit/mac:
- WebView/WebFrame.mm:
(-[WebFrame _selectedString]):
(-[WebFrame _firstRectForDOMRange:]):
(-[WebFrame _markDOMRange]):
(-[WebFrame _insertParagraphSeparatorInQuotedContent]):
(-[WebFrame _setTypingStyle:withUndoAction:]):
(-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
- WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
- WebView/WebHTMLView.mm:
(-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
(-[WebHTMLView _shouldDeleteRange:]):
(-[WebHTMLView _canEdit]):
(-[WebHTMLView _canEditRichly]):
(-[WebHTMLView _insertOrderedList]):
(-[WebHTMLView _insertUnorderedList]):
(-[WebHTMLView _canIncreaseSelectionListLevel]):
(-[WebHTMLView _canDecreaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevel]):
(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):
(-[WebHTMLView _decreaseSelectionListLevel]):
(-[WebHTMLView Editor::coreCommandBySelector:]):
(-[WebHTMLView Editor::coreCommandByName:]):
(-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
(-[WebHTMLView becomeFirstResponder]):
(-[WebHTMLView _selectionStartFontAttributesAsRTF]):
(-[WebHTMLView _applyStyleToSelection:withUndoAction:]):
(-[WebHTMLView _changeCSSColorUsingSelector:inRange:]):
(-[WebHTMLView checkSpelling:]):
(-[WebHTMLView showGuessPanel:]):
(-[WebHTMLView toggleBaseWritingDirection:]):
(-[WebHTMLView changeBaseWritingDirection:]):
(-[WebHTMLView _changeBaseWritingDirectionTo:]):
(-[WebHTMLView _updateFontPanel]):
(-[WebHTMLView markedRange]):
(-[WebHTMLView hasMarkedText]):
(-[WebHTMLView unmarkText]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView doCommandBySelector:]):
(-[WebHTMLView insertText:]):
(-[WebHTMLView _updateSelectionForInputManager]):
(-[WebHTMLView countMatchesForText:inDOMRange:options:limit:markMatches:]):
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
(-[WebHTMLView markedTextMatchesAreHighlighted]):
(-[WebHTMLView _findString:options:]):
- WebView/WebView.mm:
(-[WebView _executeCoreCommandByName:value:]):
(-[WebView editableDOMRangeForPoint:]):
(-[WebView setEditable:]):
(-[WebView deleteSelection]):
(-[WebView applyStyle:]):
(-[WebView typingAttributes]):
(-[WebView _simplifyMarkup:endNode:]):
(-[WebView handleAcceptedAlternativeText:]):
Source/WebKit/qt:
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::executeCoreCommandByName):
(DumpRenderTreeSupportQt::isCommandEnabled):
(DumpRenderTreeSupportQt::firstRectForCharacterRange):
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::respondToChangedSelection):
(WebCore::EditorClientQt::registerUndoStep):
(WebCore::EditorClientQt::handleKeyboardEvent):
- WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::selectedText):
(QWebPageAdapter::selectedHtml):
(QWebPageAdapter::setContentEditable):
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
- WebFrame.cpp:
(WebFrame::hasSpellingMarker):
(WebFrame::setTextDirection):
(WebFrame::selectedString):
(WebFrame::selectAll):
- WebView.cpp:
(WebView::execCommand):
(WebView::handleEditingKeyboardEvent):
(WebView::executeCoreCommandByName):
(WebView::selectedText):
(WebView::deleteEnabled):
(WebView::editingEnabled):
(WebView::replaceSelectionWithText):
(WebView::copy):
(WebView::cut):
(WebView::paste):
(WebView::copyURL):
(WebView::delete_):
(WebView::checkSpelling):
(WebView::showGuessPanel):
(WebView::clearUndoRedoOperations):
(WebView::prepareCandidateWindow):
(WebView::resetIME):
(WebView::updateSelectionForIME):
(WebView::onIMEComposition):
(WebView::onIMEEndComposition):
(WebView::onIMERequestCharPosition):
(WebView::onIMERequest):
(WebView::setCompositionForTesting):
(WebView::hasCompositionForTesting):
(WebView::confirmCompositionForTesting):
(WebView::compositionRangeForTesting):
(WebView::firstRectForCharacterRangeForTesting):
(WebView::selectedRangeForTesting):
Source/WebKit/wince:
- WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::updateGlobalSelection):
- WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
(WebKit::WebEditorClient::handleInputMethodKeydown):
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::WebEditorClient::executePendingEditorCommands):
(WebKit::WebEditorClient::handleKeyboardEvent):
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithGoogle):
(WebKit::WebContextMenuClient::searchWithSpotlight):
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::changeWordCase):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::selectionAsString):
(WebKit::WebFrame::setTextDirection):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::editorState):
(WebKit::WebPage::executeEditingCommand):
(WebKit::WebPage::isEditingCommandEnabled):
(WebKit::WebPage::validateCommand):
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::advanceToNextMisspelling):
(WebKit::WebPage::uppercaseWord):
(WebKit::WebPage::lowercaseWord):
(WebKit::WebPage::capitalizeWord):
(WebKit::WebPage::replaceSelectionWithText):
(WebKit::WebPage::handleAlternativeTextUIResult):
(WebKit::WebPage::setCompositionForTesting):
(WebKit::WebPage::hasCompositionForTesting):
(WebKit::WebPage::confirmCompositionForTesting):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::cancelComposition):
- WebProcess/WebPage/efl/WebPageEfl.cpp:
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::cancelComposition):
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::executeKeypressCommandsInternal):
(WebKit::WebPage::handleEditingKeyboardEvent):
(WebKit::WebPage::setComposition):
(WebKit::WebPage::confirmComposition):
(WebKit::WebPage::cancelComposition):
(WebKit::WebPage::insertText):
(WebKit::WebPage::insertDictatedText):
(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::firstRectForCharacterRange):
(WebKit::WebPage::readSelectionFromPasteboard):
(WebKit::WebPage::getStringSelectionForPasteboard):
(WebKit::WebPage::getDataSelectionForPasteboard):
- 12:39 PM Changeset in webkit [150139] by
-
- 22 edits11 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should separate link phase into things that must be done concurrently and things that must be done synchronously, and have a way of passing data from one to the other
https://bugs.webkit.org/show_bug.cgi?id=116060
Reviewed by Gavin Barraclough.
This introduces the concept of a DFG::Plan, which corresponds to:
- The data that the concurrent DFG or FTL need to start compiling a CodeBlock. This mostly includes basic things like CodeBlock*, but also a list of must-handle values for OSR entry.
- The data that the synchronous linker need to link in code compiled by a concurrent compilation thread. This is further encapsulated by DFG::Finalizer, since the data, and the actions that need to be taken, are different in DFG versus FTL. This patch also institutes the policy that the concurrent compilation thread shall not use LinkBuffer::performFinalization(), since that code assumes that it's running on the same thread that will actually run the code.
- The actions that need to be taken to compile code. In other words, most of the code that previously lived in DFGDriver.cpp now lives in DFG::Plan::compileInThread().
- The actions that need to be taken when synchronously linking the code. This includes "really" adding watchpoints and identifiers, checking watchpoint and chain validity, and running the DFG::Finalizer.
Currently, DFGDriver just creates a Plan and runs it synchronously. But in the
future, we will be able to malloc some Plans and enqueue them, and have the
concurrent thread dequeue them and call Plan::compileInThread().
For now, this has no behavior or performance change.
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::performFinalization):
- assembler/LinkBuffer.h:
(LinkBuffer):
(JSC::LinkBuffer::LinkBuffer):
(JSC::LinkBuffer::~LinkBuffer):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
- dfg/DFGDriver.cpp:
(DFG):
(JSC::DFG::compile):
- dfg/DFGFailedFinalizer.cpp: Added.
(DFG):
(JSC::DFG::FailedFinalizer::FailedFinalizer):
(JSC::DFG::FailedFinalizer::~FailedFinalizer):
(JSC::DFG::FailedFinalizer::finalize):
(JSC::DFG::FailedFinalizer::finalizeFunction):
- dfg/DFGFailedFinalizer.h: Added.
(DFG):
(FailedFinalizer):
- dfg/DFGFinalizer.cpp: Added.
(DFG):
(JSC::DFG::Finalizer::Finalizer):
(JSC::DFG::Finalizer::~Finalizer):
- dfg/DFGFinalizer.h: Added.
(DFG):
(Finalizer):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(DFG):
- dfg/DFGGraph.h:
(Graph):
(JSC::DFG::Graph::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::Graph::compilation):
(JSC::DFG::Graph::identifiers):
(JSC::DFG::Graph::watchpoints):
(JSC::DFG::Graph::chains):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::linkFunction):
(DFG):
(JSC::DFG::JITCompiler::disassemble):
- dfg/DFGJITCompiler.h:
(JITCompiler):
(JSC::DFG::JITCompiler::addLazily):
- dfg/DFGJITFinalizer.cpp: Added.
(DFG):
(JSC::DFG::JITFinalizer::JITFinalizer):
(JSC::DFG::JITFinalizer::~JITFinalizer):
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGJITFinalizer.h: Added.
(DFG):
(JITFinalizer):
- dfg/DFGPlan.cpp: Added.
(DFG):
(JSC::DFG::dumpAndVerifyGraph):
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::~Plan):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::isStillValid):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::finalize):
- dfg/DFGPlan.h: Added.
(DFG):
(Plan):
(JSC::DFG::Plan::vm):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::identifierUID):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
- ftl/FTLGeneratedFunction.h: Added.
(FTL):
- ftl/FTLJITFinalizer.cpp: Added.
(FTL):
(JSC::FTL::JITFinalizer::JITFinalizer):
(JSC::FTL::JITFinalizer::~JITFinalizer):
(JSC::FTL::JITFinalizer::finalize):
(JSC::FTL::JITFinalizer::finalizeFunction):
- ftl/FTLJITFinalizer.h: Added.
(FTL):
(JITFinalizer):
(JSC::FTL::JITFinalizer::initializeExitThunksLinkBuffer):
(JSC::FTL::JITFinalizer::initializeEntrypointLinkBuffer):
(JSC::FTL::JITFinalizer::initializeCode):
(JSC::FTL::JITFinalizer::initializeFunction):
(JSC::FTL::JITFinalizer::initializeArityCheck):
(JSC::FTL::JITFinalizer::initializeJITCode):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLink.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
(FTL):
(State):
- 12:37 PM Changeset in webkit [150138] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Make Clipboard class no longer polymorphic by removing the last virtual functions
https://bugs.webkit.org/show_bug.cgi?id=116166
Reviewed by Anders Carlsson.
- WebCore.exp.in: Add ~Clipboard since it's no longer a virtual function, but to the
non-iOS section, since iOS is still using the legacy version of Clipboard.
- dom/Clipboard.h: Mark items non-virtual, too. It's not implemented on Mac yet.
- 12:37 PM Changeset in webkit [150137] by
-
- 6 edits3 deletes in trunk
Remove an overloaded strokeRect in <canvas>
https://bugs.webkit.org/show_bug.cgi?id=116017
Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-15
Reviewed by Benjamin Poulain.
Source/WebCore:
The canvas spec [1] does not define strokeRect with 5 arguments, so this issue
remains only strokeRect with 4 arguments.
[1] http://www.w3.org/TR/2dcontext2/
Covered by existing tests: canvas/philip/tests/2d.missingargs.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::strokeRect):
- html/canvas/CanvasRenderingContext2D.h:
(CanvasRenderingContext2D):
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
canvas/philip/tests/2d.missingargs.html can cover
fast/canvas/canvas-overloads-strokeRect.html, so this patch removed it.
- fast/canvas/canvas-overloads-strokeRect-expected.txt: Removed.
- fast/canvas/canvas-overloads-strokeRect.html: Removed.
- fast/canvas/script-tests/canvas-overloads-strokeRect.js: Removed.
- fast/canvas/script-tests/canvas-strokeRect.js:
- 12:15 PM Changeset in webkit [150136] by
-
- 7 edits in trunk
[css3-text] text-decoration-line now accepts "blink" as valid value
https://bugs.webkit.org/show_bug.cgi?id=116104
Reviewed by Andreas Kling.
Source/WebCore:
As of November 13th 2012, the W3C specification has been updated to
accept "blink" as a valid property value in text-decoration-line. Though
accepting the value as valid, it is ignored as CSS Level 1
text-decoration property currently does.
Updated related layout tests to reflect changes in specification.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextDecoration):
LayoutTests:
Updated layout test results to reflect changes in specification.
- fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line-expected.txt:
- fast/css3-text/css3-text-decoration/getComputedStyle/script-tests/getComputedStyle-text-decoration-line.js:
- fast/css3-text/css3-text-decoration/text-decoration-line-expected.html:
- fast/css3-text/css3-text-decoration/text-decoration-line.html:
- 12:12 PM Changeset in webkit [150135] by
-
- 2 edits in trunk/Source/WebCore
Revert http://trac.webkit.org/changeset/150047
It introduced unwanted behavioral differences between
Retina and non-Retina Mac hardware.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::requiresTiledLayer):
(WebCore::GraphicsLayerCA::computePixelAlignment):
- 12:12 PM Changeset in webkit [150134] by
-
- 10 edits in trunk/Source
WebKit doesn't support MSVS2003 any more, remove preprocessor checks for older versions.
https://bugs.webkit.org/show_bug.cgi?id=116157
Reviewed by Anders Carlsson.
Also remove a gcc3.2 workaround.
Merges parts of these two commits by the talented Nico Weber:
https://chromium.googlesource.com/chromium/blink/+/3677e2f47348daeff405a40b6f90fbdf0654c2f5
https://chromium.googlesource.com/chromium/blink/+/0fcd96c448dc30be1416dcc15713c53710c1a312
Source/JavaScriptCore:
- os-win32/inttypes.h:
Source/WTF:
- wtf/Alignment.h:
(WTF):
- wtf/Assertions.h:
- wtf/Atomics.h:
(WTF):
- wtf/Compiler.h:
- wtf/DateMath.cpp:
(WTF::getLocalTime):
- wtf/MathExtras.h:
- wtf/RefCountedLeakCounter.h:
(RefCountedLeakCounter):
- wtf/StaticConstructors.h:
- 11:55 AM Changeset in webkit [150133] by
-
- 16 edits3 copies in trunk/Source/WebKit2
Need a way for NPAPI plug-ins to open preference panes
https://bugs.webkit.org/show_bug.cgi?id=116173
<rdar://problem/13503848>
Reviewed by Sam Weinig.
- PluginProcess/PluginControllerProxy.h:
Add openPluginPreferencePane().
- PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::openPluginPreferencePane):
Send OpenPluginPreferencePane to the UI process.
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
Get the preference pane path.
- Shared/Plugins/PluginModuleInfo.h:
Add preferencePanePath member variable.
- UIProcess/Plugins/PluginProcessProxy.h:
Add openPluginPreferencePane message handler.
- UIProcess/Plugins/PluginProcessProxy.messages.in:
ADd OpenPluginPreferencePane message.
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::openPluginPreferencePane):
Get the path to the preference pane and use LS to open it.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle WKNVPlugInContainer.
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add WKNVPlugInContainer member variable.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::openPluginPreferencePane):
Call through to the plug-in controller.
(WebKit::NetscapePlugin::plugInContainer):
Create a WKNPAPIPlugInContainer object if necessary.
(WebKit::NetscapePlugin::platformDestroy):
Invalidate the WKNPAPIPlugInContainer object.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.h:
New file with the protocol definition.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm:
(-[WKNPAPIPlugInContainer dealloc]):
Assert that the plug-in is null (that we've been invalidated).
(-[WKNPAPIPlugInContainer _invalidate]):
Set the plug-in to null.
(-[WKNPAPIPlugInContainer openPlugInPreferencePane]):
Call through to the plug-in.
- WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainerInternal.h:
New file with the interface declaration for the object that implements the protocol.
- WebProcess/Plugins/PluginController.h:
Add openPluginPreferencePane member function.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::openPluginPreferencePane):
Add stub; this should never be called since we always go through the UI process.
- 11:50 AM Changeset in webkit [150132] by
-
- 7 edits in trunk/Source/WebKit2
[WK2][Mac] Split resetTextInputState into two functions
https://bugs.webkit.org/show_bug.cgi?id=116174
Reviewed by Anders Carlsson.
Splitting resetTextInputState into resetSecureInputState and
notifyInputContextAboutDiscardedComposition, paving the way for a fix where these
won't be happening simultaneously.
- UIProcess/API/mac/PageClientImpl.h:
- UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::resetSecureInputState): (WebKit::PageClientImpl::notifyInputContextAboutDiscardedComposition):
- UIProcess/API/mac/WKView.mm: (-[WKView resignFirstResponder]): (-[WKView _resetSecureInputState]): (-[WKView _notifyInputContextAboutDiscardedComposition]):
- UIProcess/API/mac/WKViewInternal.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didCommitLoadForFrame):
- 11:36 AM Changeset in webkit [150131] by
-
- 5 edits in trunk/Tools
[Windows] Update various build tools to understand VS2010 environment.
https://bugs.webkit.org/show_bug.cgi?id=116169.
Reviewed by Anders Carlsson.
- Scripts/build-api-tests: Identify VS2010 environment.
- Scripts/build-dumprendertree: Ditto.
- Scripts/build-webkit: Ditto.
- Scripts/webkitdirs.pm:
(dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
range of acceptable SDK's.
- 11:11 AM Changeset in webkit [150130] by
-
- 30 edits in trunk/Source/WebKit2
[GTK] Add padding to all public class structs for future expansion without breaking ABI
https://bugs.webkit.org/show_bug.cgi?id=112565
Reviewed by Anders Carlsson.
Use 4 pointers for most of the classes that are unlikely to grow
and 8 for WebKitWebView and WebKitWebContext.
- UIProcess/API/gtk/WebKitBackForwardList.h:
(_WebKitBackForwardListClass):
- UIProcess/API/gtk/WebKitBackForwardListItem.h:
(_WebKitBackForwardListItemClass):
- UIProcess/API/gtk/WebKitContextMenu.h:
(_WebKitContextMenuClass):
- UIProcess/API/gtk/WebKitContextMenuItem.h:
(_WebKitContextMenuItemClass):
- UIProcess/API/gtk/WebKitCookieManager.h:
(_WebKitCookieManagerClass):
- UIProcess/API/gtk/WebKitDownload.h:
(_WebKitDownloadClass):
- UIProcess/API/gtk/WebKitFaviconDatabase.h:
(_WebKitFaviconDatabaseClass):
- UIProcess/API/gtk/WebKitFileChooserRequest.h:
(_WebKitFileChooserRequestClass):
- UIProcess/API/gtk/WebKitFindController.h:
(_WebKitFindControllerClass):
- UIProcess/API/gtk/WebKitFormSubmissionRequest.h:
(_WebKitFormSubmissionRequestClass):
- UIProcess/API/gtk/WebKitGeolocationPermissionRequest.h:
(_WebKitGeolocationPermissionRequestClass):
- UIProcess/API/gtk/WebKitHitTestResult.h:
(_WebKitHitTestResultClass):
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.h:
(_WebKitNavigationPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPlugin.h:
(_WebKitPluginClass):
- UIProcess/API/gtk/WebKitPolicyDecision.h:
(_WebKitPolicyDecisionClass):
- UIProcess/API/gtk/WebKitPrintOperation.h:
(_WebKitPrintOperationClass):
- UIProcess/API/gtk/WebKitResponsePolicyDecision.h:
(_WebKitResponsePolicyDecisionClass):
- UIProcess/API/gtk/WebKitSecurityManager.h:
(_WebKitSecurityManagerClass):
- UIProcess/API/gtk/WebKitSettings.h:
(_WebKitSettingsClass):
- UIProcess/API/gtk/WebKitURIRequest.h:
(_WebKitURIRequestClass):
- UIProcess/API/gtk/WebKitURIResponse.h:
(_WebKitURIResponseClass):
- UIProcess/API/gtk/WebKitURISchemeRequest.h:
(_WebKitURISchemeRequestClass):
- UIProcess/API/gtk/WebKitWebContext.h:
(_WebKitWebContextClass):
- UIProcess/API/gtk/WebKitWebInspector.h:
(_WebKitWebInspectorClass):
- UIProcess/API/gtk/WebKitWebResource.h:
(_WebKitWebResourceClass):
- UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass):
- UIProcess/API/gtk/WebKitWebViewBase.h:
(_WebKitWebViewBaseClass):
- UIProcess/API/gtk/WebKitWebViewGroup.h:
(_WebKitWebViewGroupClass):
- UIProcess/API/gtk/WebKitWindowProperties.h:
(_WebKitWindowPropertiesClass):
- 10:24 AM Changeset in webkit [150129] by
-
- 7 edits1 delete in trunk/Source
[Mac] Remove the ClipboardMac class and header file
https://bugs.webkit.org/show_bug.cgi?id=116165
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj: Remove ClipboardMac.h.
- editing/mac/EditorMac.mm: Import Clipboard.h rather than ClipboardMac.h.
- page/mac/EventHandlerMac.mm: Ditto.
- platform/mac/ClipboardMac.h: Removed.
- platform/mac/ClipboardMac.mm: Import Clipboard.h rather than ClipboardMac.h.
Deleted ClipboardMac constructor.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.mm: Import Clipboard.h instead of ClipboardMac.h.
- 10:23 AM Changeset in webkit [150128] by
-
- 4 edits1 add in trunk
Allow http tests on Arch Linux
https://bugs.webkit.org/show_bug.cgi?id=116155
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-15
Reviewed by Ryosuke Niwa.
Tools:
- Scripts/webkitpy/port/base.py:
(Port._is_arch_based): Added check for /etc/arch-release file.
(Port._apache_config_file_name_for_platform): Call the check.
- Scripts/webkitpy/port/port_testcase.py:
(test_linux_distro_detection): Testcase added.
LayoutTests:
- http/conf/archlinux-httpd.conf: Added.
- 10:14 AM Changeset in webkit [150127] by
-
- 3 edits in trunk/Source/WebCore
[Mac] Change Clipboard::create functions so they don't use ClipboardMac::create any more
https://bugs.webkit.org/show_bug.cgi?id=116163
Reviewed by Anders Carlsson.
- dom/Clipboard.h: Made the file drag boolean default to false, better for most callers.
- platform/mac/ClipboardMac.mm: Remove #if ENABLE(DRAG_SUPPORT); that's always on for Mac
and it's not helpful to have the conditionals in here. It's helpful in cross-platform
source files.
(WebCore::Clipboard::create): Create a Pasteboard and then create a Clipboard with new.
Later could refactor to have the Pasteboard creation be platform-specific, and make these
functions platform-independent.
(WebCore::Clipboard::createForDragAndDrop): Ditto.
(WebCore::Clipboard::createForCopyAndPaste): Ditto.
- 10:04 AM Changeset in webkit [150126] by
-
- 2 edits in trunk/Tools
Remove a leftover v8 file from the watchlist
https://bugs.webkit.org/show_bug.cgi?id=116158
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-15
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
- 10:02 AM Changeset in webkit [150125] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Remove call to ClipboardMac::create from Editor::newGeneralClipboard
https://bugs.webkit.org/show_bug.cgi?id=116162
Reviewed by Andreas Kling.
- dom/Clipboard.h: Add createForCopyAndPaste function.
- editing/mac/EditorMac.mm:
(WebCore::Editor::newGeneralClipboard): Call createForCopyAndPaste.
- platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::createForCopyAndPaste): Added. Moved code here from
Editor::newGeneralClipboard.
- 9:53 AM Changeset in webkit [150124] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Remove call to ClipboardMac::create from EventHandler::createDraggingClipboard
https://bugs.webkit.org/show_bug.cgi?id=116161
Reviewed by Andreas Kling.
- dom/Clipboard.h: Added createForDragAndDrop function.
- page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::createDraggingClipboard): Changed to use new Clipboard function
instead of ClipboardMac::create.
- platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::createForDragAndDrop): Added. For now it does exactly what the
EventHandler::createDraggingClipboard function did, soon to be refactored better.
- 9:48 AM Changeset in webkit [150123] by
-
- 8 edits in trunk
Consolidate lists in WTF CMake files
https://bugs.webkit.org/show_bug.cgi?id=116142
Reviewed by Martin Robinson.
Move common files into the CMakeLists.txt to avoid duplicating the list of files.
Also rebase the recently added GTK files to match the other CMake ports, since
the submitted patch was based on an older version of the source tree.
.:
- Source/cmake/OptionsGTK.cmake:
Source/WTF:
- wtf/CMakeLists.txt:
- wtf/PlatformBlackBerry.cmake:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- wtf/PlatformWinCE.cmake:
- 9:44 AM Changeset in webkit [150122] by
-
- 9 edits in trunk/Source
[Mac] Thin out the ClipboardMac class and header file to prepare for deleting them
https://bugs.webkit.org/show_bug.cgi?id=116159
Reviewed by Andreas Kling.
Source/WebCore:
- dom/Clipboard.h:
(WebCore::Clipboard::pasteboard): Added. For clients that have a DOM clipboard
object and need to get to the Pasteboard platform abstraction.
- editing/Editor.cpp:
(WebCore::Editor::dispatchCPPEvent): Call writePasteboard instead of writeClipboard.
Our long term plan is to delete writeClipboard.
- platform/Pasteboard.h: Added writePasteboard function.
(WebCore::Pasteboard::name): Made this const.
- platform/mac/ClipboardMac.h: Deleted unneeded includes and forward declarations.
Deleted all the data members and the virtual destructor.
- platform/mac/ClipboardMac.mm: Deleted the many includes that are no longer needed.
Deleted the destructor, since it's now automatically generated. Deleted the comment
on an #endif since it's only a few source lines away from the #if.
(WebCore::ClipboardMac::ClipboardMac): Deleted the code to set the data members,
since they are no longer used.
- platform/mac/PasteboardMac.mm: Changed include to Clipboard.h instead of ClipboardMac.h.
(WebCore::Pasteboard::writePasteboard): Replaced writeClipboard with this.
Source/WebKit/mac:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::willPerformDragSourceAction): Changed to get the pasteboard name
without going through the ClipboardMac class.
(WebDragClient::startDrag): Ditto.
- 9:40 AM Changeset in webkit [150121] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Get rid of addNativeSnapshotChunk and HeapSnapshotChunk from Memory domain
https://bugs.webkit.org/show_bug.cgi?id=116144
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-15
Reviewed by Timothy Hatcher.
No new tests, no behavior change.
- inspector/Inspector.json:
- 9:31 AM Changeset in webkit [150120] by
-
- 5 edits in trunk/Source
[Qt] Fix a crash under ~PingLoader when the QNAM on the page has been destroyed.
https://bugs.webkit.org/show_bug.cgi?id=116035
Reviewed by Allan Sandfeld Jensen.
Source/WebCore:
The previous fix only moved the crash location from WebKit down to QNetworkReplyHttpImpl
which expects its QNetworkAccessManager to still be alive.
Fix it by watching the QNetworkReply's destroyed() signal and avoid the dangling pointer
instead. The QNetworkReply doesn't need to be aborted in this case anyway.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
(WebCore::QNetworkReplyWrapper::release):
(WebCore::QNetworkReplyWrapper::stopForwarding):
Rename resetConnections to stopForwarding since not all connections are related
to data forwarding to the client anymore.
(WebCore::QNetworkReplyWrapper::receiveMetaData):
(WebCore::QNetworkReplyWrapper::replyDestroyed):
(WebCore::QNetworkReplyWrapper::didReceiveFinished):
- platform/network/qt/QNetworkReplyHandler.h:
(QNetworkReplyWrapper):
Source/WebKit/qt:
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::networkReplyParentDidntChange): Change test to match the new expectation.
(tst_QWebPage::destroyQNAMBeforeAbortDoesntCrash):
- 9:27 AM Changeset in webkit [150119] by
-
- 5 edits in trunk/Source/WebCore
[Mac] Make Clipboard::declareAndWriteDragImage non-virtual
https://bugs.webkit.org/show_bug.cgi?id=116156
Reviewed by Anders Carlsson.
- dom/Clipboard.h: Make declareAndWriteDragImage non-virtual for non-legacy.
- platform/Pasteboard.h:
(WebCore::Pasteboard::name): Added. Can be used in Mac platform code to do
pasteboard operations directly instead of through the Pasteboard class
functions. Not sure if we'll need it long term or not.
- platform/mac/ClipboardMac.h: Removed declareAndWriteDragImage function.
- platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::declareAndWriteDragImage): Made this function a Clipboard
member instead of ClipboardMac.
- 9:22 AM Changeset in webkit [150118] by
-
- 3 edits in trunk/Source/WebCore
[curl] Remove version #if guards
https://bugs.webkit.org/show_bug.cgi?id=116152
Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-15
Reviewed by Brent Fulgham.
No tests required.
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::platformSetDefersLoading): Removed version guard.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::writeCallback): Ditto.
(WebCore::headerCallback): Ditto.
(WebCore::readCallback): Ditto.
(WebCore::ResourceHandleManager::dispatchSynchronousJob): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Ditto.
- 9:13 AM Changeset in webkit [150117] by
-
- 2 edits in trunk/Tools
[GTK] Fails to build while generating gtkdoc
https://bugs.webkit.org/show_bug.cgi?id=115612
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-15
Reviewed by Philippe Normand.
Fix typo in the prerequisites of docs-build.stamp.
- GNUmakefile.am:
- 9:11 AM Changeset in webkit [150116] by
-
- 2 edits in trunk/Tools
Unreviewed, fixing the current test-webkitpy failure.
- Scripts/webkitpy/port/mac_unittest.py:
(test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
- 9:03 AM Changeset in webkit [150115] by
-
- 2 edits in trunk/Source/WebKit/win
Remove unnecessary dependecy on CoreFoundation from WebDatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=115993
Reviewed by Anders Carlsson.
Using COMPropertyBag instead of CFDictionaryPropertyBag also reduces
the total lines of code needed for the same functionality.
- WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
- 8:51 AM Changeset in webkit [150114] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r150089): Make WebCoreTestShim build for iOS
- Configurations/WebCoreTestShim.xcconfig: Exclude
WebCoreTestShimLibrary.cpp when building for iOS.
- 8:35 AM Changeset in webkit [150113] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Removing two redundant flaky crasher expectations. Adjusting one expectation,
assigning it a mock bug modifier so the TestExpectations linting passes.
- 8:28 AM Changeset in webkit [150112] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Removing failure expectations for 7 CSS Regions and CSS Exclusions reftests.
- 8:15 AM Changeset in webkit [150111] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt: Rebaselining after r149845.
- 8:09 AM Changeset in webkit [150110] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding faillure expectations for two reftests that
- 8:05 AM Changeset in webkit [150109] by
-
- 6 edits6 adds in branches/dfgFourthTier/Source/JavaScriptCore
Refactor JITStubs.cpp to move CPU specific parts out into their own files.
https://bugs.webkit.org/show_bug.cgi?id=116135.
Reviewed by Michael Saboff.
This mod only moves the CPU specific parts out. There is no code change.
Tested on debug builds of X86, X86_64, ARM and ARMv7. The SH4 and MIPS
ports are untested. Windows port also not tested.
- GNUmakefile.list.am:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITStubs.cpp:
(JSC::performPlatformSpecificJITAssertions):
- jit/JITStubsARM.h: Added.
(JSC::ctiTrampoline):
(JSC::ctiTrampolineEnd):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::performARMJITAssertions):
- jit/JITStubsARMv7.h: Added.
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
(JSC::performARMv7JITAssertions):
- jit/JITStubsMIPS.h: Added.
(JSC::performMIPSJITAssertions):
- jit/JITStubsSH4.h: Added.
- jit/JITStubsX86.h: Added.
- jit/JITStubsX86_64.h: Added.
- 3:54 AM Changeset in webkit [150108] by
-
- 6 edits1 copy1 add in trunk
[CSSRegions] Implement offsetParent for elements inside named flow
https://bugs.webkit.org/show_bug.cgi?id=113276
Source/WebCore:
In the offsetParent algorithm, the nearest ancestor search skips from the topmost named flow elements directly to the body element.
http://dev.w3.org/csswg/css-regions/#cssomview-offset-attributes
As a result of this change, the DumpRenderTree tool would crash in
WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent when running the selecting-text-through-different-region-flows.html
test. The RenderObjects inside a flow are attached to the RenderFlowThread. However, the RenderFlowThread is attached to the
RenderView directly, meaning that we are going to bypass the <body>'s RenderObject while iterating the parents.
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-15
Reviewed by Darin Adler.
Tests: fast/regions/offsetParent-body-in-flow-thread.html
fast/regions/offsetParent-in-flow-thread.html
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
LayoutTests:
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-15
Reviewed by Darin Adler.
In the offsetParent algorithm, the nearest ancestor search skips from the topmost named flow elements directly to the body element.
Added new test for offsetParent when body is flowed into a region.
Updated existing offsetParent test.
- fast/regions/offsetParent-body-in-flow-thread-expected.txt: Added.
- fast/regions/offsetParent-body-in-flow-thread.html: Added.
- fast/regions/offsetParent-in-flow-thread-expected.txt:
- fast/regions/offsetParent-in-flow-thread.html:
- 2:43 AM Changeset in webkit [150107] by
-
- 4 edits in trunk/Source/WebCore
[Mac] Make Clipboard::createDragImage non-virtual
https://bugs.webkit.org/show_bug.cgi?id=116136
Reviewed by Benjamin Poulain.
- dom/Clipboard.h: Made createDragImage non-virtual for non-legacy.
- platform/mac/ClipboardMac.h: Removed frame argument from create function
and constructor. Removed createDragImage and dragNSImage. Removed m_frame
data member.
- platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::ClipboardMac): Removed frame argument and code
to initialize m_frame.
(WebCore::Clipboard::createDragImage): Merged the createDragImage and
dragNSImage functions, since they were the same thing. Changed code to get
the frame from the drag image element. Made the createDragImage function
a Clipboard member instead of ClipboardMac.
- 2:03 AM Changeset in webkit [150106] by
-
- 2 edits in trunk/Source/WebCore
[WINCE] Fix calls to GlyphPage::setGlyphDataForIndex()
https://bugs.webkit.org/show_bug.cgi?id=116137
Reviewed by Andreas Kling.
Use zero for the glyp when the fontData pointer is null.
This aligns GlyphPageTreeNodeWinCE with the other implementations
and makes all ASSERT() pass in setGlyphDataForIndex().
- platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp:
(WebCore::GlyphPage::fill):
- 1:28 AM Changeset in webkit [150105] by
-
- 2 edits in trunk/Source/WebCore
Do not bloat HTMLTokenizer with a giant inline InputStreamPreprocessor::peek
https://bugs.webkit.org/show_bug.cgi?id=116066
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-15
Reviewed by Ryosuke Niwa.
Merge https://chromium.googlesource.com/chromium/blink/+/45e0337b2f2db535ab08365f6e763a5015e4d990.
On x86_64, this removes 40kb from the binary. On my machine it is completely neutral on performance.
- html/parser/InputStreamPreprocessor.h:
(WebCore::InputStreamPreprocessor::peek):
(InputStreamPreprocessor):
(WebCore::InputStreamPreprocessor::advance):
(WebCore::InputStreamPreprocessor::skipNextNewLine):
(WebCore::InputStreamPreprocessor::reset):
(WebCore::InputStreamPreprocessor::processNextInputCharacter):
- 1:07 AM Changeset in webkit [150104] by
-
- 36 edits in trunk/Source
Remove WTF_USE_PLATFORM_STRATEGIES
https://bugs.webkit.org/show_bug.cgi?id=114431
Reviewed by Darin Adler.
Source/WebCore:
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::DatabaseManager):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::suspendPostAttachCallbacks):
(WebCore::ContainerNode::resumePostAttachCallbacks):
- dom/VisitedLinkState.cpp:
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- loader/CookieJar.cpp:
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadResourceSynchronously):
- loader/HistoryController.cpp:
(WebCore::addVisitedLink):
- loader/LoaderStrategy.cpp:
- loader/LoaderStrategy.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::resourceLoadScheduler):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::releaseResources):
(WebCore::ResourceLoader::willSendRequest):
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::performPostLoadActions):
- platform/CookiesStrategy.h:
- platform/DatabaseStrategy.cpp:
- platform/DatabaseStrategy.h:
- platform/PasteboardStrategy.h:
- platform/PlatformStrategies.cpp:
- platform/PlatformStrategies.h:
- platform/VisitedLinkStrategy.h:
- platform/mac/PasteboardMac.mm:
- platform/network/BlobRegistry.cpp:
(WebCore::blobRegistry):
- plugins/PluginData.cpp:
(WebCore::PluginData::initPlugins):
- plugins/PluginStrategy.h:
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::localStorageNamespace):
(WebCore::StorageNamespace::transientLocalStorageNamespace):
(WebCore::StorageNamespace::sessionStorageNamespace):
- storage/StorageStrategy.cpp:
- storage/StorageStrategy.h:
- workers/SharedWorkerStrategy.h:
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
Source/WTF:
- wtf/Platform.h:
- 12:37 AM Changeset in webkit [150103] by
-
- 2 edits in trunk/Source/WebCore
[curl] Add support for HttpOnly cookies
https://bugs.webkit.org/show_bug.cgi?id=116102
Patch by Dávid Szabolcs <David.Szabolcs@stud.u-szeged.hu> on 2013-05-15
Reviewed by Brent Fulgham.
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::addMatchingCurlCookie):
(WebCore::cookiesForSession):
(WebCore::cookiesForDOM):
(WebCore):
(WebCore::cookieRequestHeaderFieldValue):
May 14, 2013:
- 11:42 PM Changeset in webkit [150102] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r147548): Broken comboboxes
https://bugs.webkit.org/show_bug.cgi?id=115475
Reviewed by Gustavo Noronha Silva.
The problem is that r147548 made the popup to be closed when a
blur event is received. Right before showing the popup the input
element is focused, so that after the the popup is shown the focus
event is emitted and the event handler is called again hiding the
popup.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Check
element has lost the focus before closing the popup menu.
- 9:35 PM Changeset in webkit [150101] by
-
- 5 edits in trunk
Printing in 1Password app is broken with screen fonts disabled
https://bugs.webkit.org/show_bug.cgi?id=116133
-and corresponding-
<rdar://problem/13162981>
Reviewed by Anders Carlsson.
Source/WebKit/mac:
Return YES from [WebPreferences screenFontSubstitutionEnabled] for versions of the
1Password app that were linked on or before MountainLion.
- WebView/WebPreferences.mm:
(needsScreenFontsEnabledQuirk):
(-[WebPreferences screenFontSubstitutionEnabled]):
WebKitLibraries:
Need WKExecutableWasLinkedOnOrBeforeMountainLion() for this quirk.
- libWebKitSystemInterfaceLion.a:
- libWebKitSystemInterfaceMountainLion.a:
- 9:27 PM Changeset in webkit [150100] by
-
- 7 edits in trunk/Source/WebCore
[Mac] Move setDragImage from ClipboardMac to PasteboardMac
https://bugs.webkit.org/show_bug.cgi?id=116036
Reviewed by Anders Carlsson.
- dom/Clipboard.cpp:
(WebCore::Clipboard::~Clipboard): Stop loading the drag image when
the clipboard object is deallocated. It would be better if there was
a more-well-defined time to stop the load.
(WebCore::Clipboard::setDragImage): Added. Sets up a drag image
based on a CachedImage. This tells the image loader to load the image
and updates the drag image when the image arrives. Copied from the
code in ClipboardMac, but refactored to use a separate loader object.
(WebCore::Clipboard::setDragImageElement): Added. Sets up a drag image
based on an element.
(WebCore::Clipboard::updateDragImage): Added. Common code to update
drag image when a new one is set or when a drag image load completes.
(WebCore::DragImageLoader::create): Added.
(WebCore::DragImageLoader::DragImageLoader): Ditto.
(WebCore::DragImageLoader::startLoading): Ditto.
(WebCore::DragImageLoader::stopLoading): Ditto.
(WebCore::DragImageLoader::imageChanged): Ditto.
- dom/Clipboard.h: Made setDragImage and setDragImageElement non-virtual
for non-legacy. Added updateDragImage and m_dragImageLoader.
- platform/Pasteboard.h: Added setDragImage function.
- platform/mac/ClipboardMac.h: Removed CachedImageClient as a base class
for ClipboardMac. Removed setDragImage and setDragImageElement.
- platform/mac/ClipboardMac.mm: Removed setDragImage and setDragImageElement.
(WebCore::ClipboardMac::~ClipboardMac): Removed code to remove self as
client loading the drag image. This is now in the Clipboard base class.
- platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::setDragImage): Added. Contains code moved here
from ClipboardMac.
- 8:17 PM Changeset in webkit [150099] by
-
- 2 edits in trunk/Source/WebCore
Use ElementTraversal in SelectorDataList::execute
https://bugs.webkit.org/show_bug.cgi?id=116131
Reviewed by Darin Adler.
Use ElementTraversal::firstWithin and ElementTraversal::next to simplify the code.
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::execute):
- 7:18 PM Changeset in webkit [150098] by
-
- 2 edits in trunk/Tools
Fix build after r150090.
https://bugs.webkit.org/show_bug.cgi?id=116129
Unreviewed build fix after r150090.
Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-05-14
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
- 7:17 PM Changeset in webkit [150097] by
-
- 6 edits in trunk/LayoutTests
[CSS Exclusions] Some layout tests fail to account for inline pixel snapping
https://bugs.webkit.org/show_bug.cgi?id=116115
Reviewed by Dirk Schulze.
Adjust the expected locations of spans to account for the fact that inline layout snaps boxes' logical top
and bottom to pixels, and the fact that line segment layout rounds the logical left and floors the logical
right of segments.
- fast/exclusions/shape-inside/shape-inside-polygon-layout.html: Use the quiet variable!
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt:
- fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-left.html:
- fast/exclusions/shape-outside-floats/shape-outside-floats-ellipse-margin-right.html:
- 6:20 PM Changeset in webkit [150096] by
-
- 2 edits in trunk/Tools
[Windows, others] Unreviewed build fix after r150090.
- DumpRenderTree/TestRunner.cpp:
(getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
doesn't exist on other platforms.
- 6:00 PM Changeset in webkit [150095] by
-
- 3 edits in trunk/Tools
[Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
https://bugs.webkit.org/show_bug.cgi?id=115889
Patch by Brent Fulgham <bfulgham@webkit.org> on 2013-05-14
Reviewed by Benjamin Poulain.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
- DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
- 5:27 PM Changeset in webkit [150094] by
-
- 2 edits in trunk/Source/WebKit2
Add a preference that can disable the fake SYSV SHM shim
https://bugs.webkit.org/show_bug.cgi?id=116127
<rdar://problem/13810524>
Patch by Simon Cooper <scooper@apple.com> on 2013-05-14
Reviewed by Alexey Proskuryakov.
- PluginProcess/mac/PluginProcessShim.mm:
(WebKit::shim_disabled):
(WebKit::shim_shmdt):
(WebKit::shim_shmat):
(WebKit::shim_shmget):
(WebKit::shim_shmctl):
- 5:18 PM Changeset in webkit [150093] by
-
- 5 edits in trunk/Source
[wk2] Not updating tiled backing coverage when main frame scrollability changes
https://bugs.webkit.org/show_bug.cgi?id=116123
<rdar://problem/13836559>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
Add updateMainFrameClipsToExposedRect.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
Remove m_clipsToExposedRect. We don't actually need it.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
Call updateMainFrameClipsToExposedRect so that we can always update
tiled backing coverage and can factor out our calls to setClipsToExposedRect.
(WebKit::TiledCoreAnimationDrawingArea::updateMainFrameClipsToExposedRect):
Factor out setClipsToExposedRect calls to here, and also call
FrameView::adjustTiledBackingCoverage so that the FrameView's tiled
backing is informed to allow overdraw in the UI-process-scrolling case.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
Use updateMainFrameClipsToExposedRect.
Export FrameView::adjustTiledBackingCoverage.
- WebCore.exp.in:
- 5:15 PM Changeset in webkit [150092] by
-
- 2 edits in trunk/Tools
[Windows] Identify proper run environment for scripts.
https://bugs.webkit.org/show_bug.cgi?id=116114
Reviewed by David Kilzer.
Determine (based on Visual Studio version) which path to use for
executables (bin versus bin32).
- Scripts/webkitdirs.pm:
(determineVisualStudioInstallDir): Added.
(determineVisualStudioVersion): Added.
(determineConfigurationProductDir): Modified to choose proper bin
or bin32 directory.
(visualStudioVersion): Added
(setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
- 3:40 PM Changeset in webkit [150091] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Improve Fatfinger phase.
https://bugs.webkit.org/show_bug.cgi?id=107403
Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-14
Reviewed by Rob Buis.
Internally reviewed by Genevieve Mak.
BlackBerry PR 324965.
Cache and reuse intersected nodes as long as hit position has not been
changed.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
(BlackBerry::WebKit::FatFingers::findIntersectingRegions):
(BlackBerry::WebKit::FatFingers::getNodesFromRect):
- WebKitSupport/FatFingers.h:
- 3:20 PM Changeset in webkit [150090] by
-
- 15 edits13 adds in trunk
[Mac] Add tests for secure event input
https://bugs.webkit.org/show_bug.cgi?id=116121
Reviewed by Mark Rowe.
- editing/secure-input: Added.
- editing/secure-input/password-input-changed-type-expected.txt: Added.
- editing/secure-input/password-input-changed-type.html: Added.
- editing/secure-input/password-input-focusing-expected.txt: Added.
- editing/secure-input/password-input-focusing-to-different-frame-expected.txt: Added.
- editing/secure-input/password-input-focusing-to-different-frame.html: Added.
- editing/secure-input/password-input-focusing.html: Added.
- editing/secure-input/removed-password-input-expected.txt: Added.
- editing/secure-input/removed-password-input.html: Added.
- editing/secure-input/reset-state-on-navigation-expected.txt: Added.
- editing/secure-input/reset-state-on-navigation.html: Added.
- editing/secure-input/resources: Added.
- editing/secure-input/resources/reset-state-on-navigation-target.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- 3:08 PM Changeset in webkit [150089] by
-
- 9 edits1 move2 adds in trunk
[Mac] Add a testing shim for secure event input functions
https://bugs.webkit.org/show_bug.cgi?id=116122
Reviewed by Mark Rowe.
Added a new target with a dynamic library that interposes secure event input functions.
We need this to avoid interfering with user session state.
- Configurations/WebCoreTestShim.xcconfig: Added.
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/DynamicLinkerInterposing.h: Moved from Source/WebKit2/Shared/mac/DyldInterpose.h.
- testing/WebCoreTestShimLibrary.cpp: Added. (shimEnableSecureEventInput): (shimDisableSecureEventInput): (shimIsSecureEventInputEnabled):
- 2:14 PM Changeset in webkit [150088] by
-
- 4 edits in trunk/Source/WebCore
Get rid of Gradient::getColor()
https://bugs.webkit.org/show_bug.cgi?id=116089
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-14
Reviewed by Andreas Kling.
This code is now useless, remove it.
- html/canvas/CanvasGradient.h:
(CanvasGradient):
- platform/graphics/Gradient.cpp:
(WebCore::Gradient::Gradient):
(WebCore::Gradient::hash):
- platform/graphics/Gradient.h:
(Gradient):
- 1:37 PM Changeset in webkit [150087] by
-
- 5 edits2 adds in trunk
Source/WebCore: REGRESSION: united.com has overlapping elements and is broken by flex box changes.
https://bugs.webkit.org/show_bug.cgi?id=115329
<rdar://problem/13690610>
The new flexbox spec says that flex-basis omitted in the flex shorthand defaults to
0 when flex-grow/shrink are set. This has undesirable behavior when objects don't
end up flexing at all, and it's something the spec is going to eventually address.
For now, though, to fix the regression, I'm making a targeted "hack" to deliberately
violate the spec, but to do so as minimally as possible. This hack detects if there
is infinite available space on a line, and if so, it treats a flex-basis of 0 like
auto.
This means that when height is constrained and set by a container, flexing will do
the right thing. Basically any time you end up actually flexing, the spec behavior
should happen. If you're just laying out at intrinsic sizes, though, and no flexing
is going to occur, we ignore a flex-basis of 0 and just use the child's normal size.
Note that widths don't have to be patched because the preferred logical widths
algorithm is broken right now and not checking flex-basis. If it did, we'd have seen
the same bug in the width direction.
This width issue is covered by https://bugs.webkit.org/show_bug.cgi?id=116117
Reviewed by Simon Fraser.
Added fast/flexbox/auto-height-with-flex.html
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::mainAxisContentExtent):
Make sure we return LayoutUnit::max when you have infinite free space and not
max - borderPadding.
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
Only clear override size if it was set. Only mark for relayout if we did
an override size clear (i.e., if we were actually flexed). Add a new parameter,
hasInfiniteLineLength, that - if set - causes us to special case flex-basis:0
and treat it like flex-basis:auto.
(WebCore::RenderFlexibleBox::layoutFlexItems):
Define hasInfiniteLineLength and pass it to all the functions that need it.
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
Remove the code that marks for layout and does a layout so early. This code
is moving (and changing) to preferredMainAxisContentExtentForChild.
(WebCore::RenderFlexibleBox::computeNextFlexLine):
Computes whether or not we have infinite line length now.
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
Propagate hasInfiniteLineLength through to preferredMainAxisContentExtentForChild.
- rendering/RenderFlexibleBox.h:
(RenderFlexibleBox):
Add hasInfiniteLineLength parameter to a bunch of functions.
LayoutTests: REGRESSION (r147261): Many overlaid elements on united.com's account page
https://bugs.webkit.org/show_bug.cgi?id=116107
<rdar://problem/13690610>
Reviewed by Simon Fraser.
- fast/flexbox/auto-height-with-flex-expected.html: Added.
- fast/flexbox/auto-height-with-flex.html: Added.
- 1:37 PM Changeset in webkit [150086] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Segfault in jsc with simple test program when running with profile dumping enabled
https://bugs.webkit.org/show_bug.cgi?id=116082
It's crashing because CodeBlock::baselineVersion() doesn't know how to handle the case where 'this' is the
baseline version but it hasn't been assigned to the m_blahCodeBlock field in BlahExecutable. The fix is to
check if we're the baseline version in baselineVersion() and return this if so.
Reviewed by Filip Pizlo.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::baselineVersion):
- 1:22 PM Changeset in webkit [150085] by
-
- 4 edits in trunk/Source/WebCore
Assertion failure in GlyphPage::setGlyphDataForIndex: (!glyph fontData == m_fontDataForAllGlyphs) <http://webkit.org/b/116113>
<rdar://problem/13833790>
Reviewed by Dan Bernstein.
If we're filling a full GlyphPage with a SimpleFontData that is actually a composite font reference,
we need to make sure we have per-glyph font data pointers, since it may end up using them.
Added GlyphPage::mayUseMixedFontDataWhenFilling() which can be implemented by the platform to let
GlyphPageTreeNode know that it should allocate a full-sized GlyphPage for mixed font data pointers
in case the font is a composite font reference, or if there are CJK ideographs in the text.
This code can be made smarter, but that's outside the scope of this change.
Fixes heavy asserting on bots running unreleased software.
- platform/graphics/GlyphPage.h:
(GlyphPage):
(WebCore::GlyphPage::mayUseMixedFontDataWhenFilling):
- platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::mayUseMixedFontDataWhenFilling):
- 1:09 PM Changeset in webkit [150084] by
-
- 4 edits2 adds in trunk
Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
https://bugs.webkit.org/show_bug.cgi?id=115566
Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-05-14
Reviewed by David Hyatt.
Source/WebCore:
When a portion of the render tree is being detached, anonymous blocks
will be combined as their children are deleted. In this process, the
anonymous block later in the tree is merged into the one preceeding it.
It can happen that the later block contains floats that the previous
block did not contain, and thus are not in the floating objects list for
the new block. This can result in the new block containing floats that
are not in it's floating objects list, but are in the floating objects
lists of siblings and parents. This can cause problems when the float
itself is deleted, since the deletion code assumes that if a float is not
in it's containing block's floating objects list, it isn't in any
floating objects list, causing dangling pointers in the floating objects
lists of the siblings and parents. In order to preserve this condition
(removing it has serious performance implications), we need to copy the
floating objects from the old block to the new block. The float's
metrics will likely all be wrong, but since the new block is already
marked for layout, this will get fixed before anything gets displayed.
Test: fast/block/float/float-append-child-crash.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo): Copy
floating objects list in addition to children.
(WebCore::RenderBlock::FloatingObject::clone): Added.
(WebCore::RenderBlock::removeChild): Use new method to copy children.
- rendering/RenderBlock.h:
(RenderBlock): Add method.
LayoutTests:
Cleaned up test from the fuzzer. Will only crash if run under a memory
checking tool like ASAN.
- fast/block/float/float-append-child-crash-expected.txt: Added.
- fast/block/float/float-append-child-crash.html: Added.
- 12:57 PM Changeset in webkit [150083] by
-
- 29 edits3 deletes in trunk
Unreviewed, rolling out r150023.
http://trac.webkit.org/changeset/150023
https://bugs.webkit.org/show_bug.cgi?id=116120
Causes table layout issues (Bug 116118) and crashes on
buildbot waterfall pages. (Requested by ddkilzer on #webkit).
Source/WebCore:
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
- rendering/RenderTableSection.h:
(RenderTableSection):
LayoutTests:
- fast/css/vertical-align-baseline-rowspan-007-expected.html:
- fast/css/vertical-align-baseline-rowspan-007.htm:
- fast/css/vertical-align-baseline-rowspan-008-expected.html:
- fast/table/table-rowspan-height-distribution-in-rows.html: Removed.
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/qt/TestExpectations:
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.png: Removed.
- platform/qt/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Removed.
- platform/qt/tables/mozilla/bugs/bug17548-expected.png:
- platform/qt/tables/mozilla/bugs/bug17548-expected.txt:
- platform/qt/tables/mozilla/bugs/bug220536-expected.png:
- platform/qt/tables/mozilla/bugs/bug220536-expected.txt:
- platform/qt/tables/mozilla/bugs/bug7714-expected.png:
- platform/qt/tables/mozilla/bugs/bug7714-expected.txt:
- platform/qt/tables/mozilla/core/bloomberg-expected.png:
- platform/qt/tables/mozilla/core/bloomberg-expected.txt:
- platform/qt/tables/mozilla/other/test6-expected.png:
- platform/qt/tables/mozilla/other/test6-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.png:
- platform/qt/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- tables/mozilla/core/bloomberg-expected.txt:
- tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- 12:39 PM Changeset in webkit [150082] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Hook up frame render begin/end in PerformanceMonitor
https://bugs.webkit.org/show_bug.cgi?id=116110
Patch by Andrew Lo <anlo@rim.com> on 2013-05-14
Reviewed by Rob Buis.
Internally reviewed by Jeff Rogers, Jonathan Jiang.
Internal PR 299155.
Mark frame render begin & end for BlackBerry performance monitoring
in blitVisibleContents.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):
- 11:39 AM WebKit Team edited by
- (diff)
- 11:03 AM Changeset in webkit [150081] by
-
- 2 edits in trunk/Source/WebCore
Snapshotted plug-ins shadow tree should reset style inheritance
https://bugs.webkit.org/show_bug.cgi?id=116098
Reset the styles such that only injected user-agent stylesheets affect
the rendering of snapshotted plug-ins' shadow content.
Reviewed by Darin Adler.
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):
- 10:57 AM Changeset in webkit [150080] by
-
- 4 edits in trunk/Tools
[Windows] Switch to embedded manifest commands for launcher executables.
https://bugs.webkit.org/show_bug.cgi?id=116109
Reviewed by Darin Adler.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
now-unused WinLauncher.exe.manifest file.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
- win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
when building with VS2010 or newer.
- 10:55 AM Changeset in webkit [150079] by
-
- 2 edits in trunk/Source/WebKit2
[Win] REGRESSION(r149944): mmap is not available on Windows
https://bugs.webkit.org/show_bug.cgi?id=116015
Reviewed by Anders Carlsson.
Use fastAlloc/fastFree for platforms other than OS(DARWIN) where
using mmap is not necessary and maybe not available.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::allocBuffer):
(CoreIPC::freeBuffer):
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
(CoreIPC::ArgumentEncoder::grow):
- 10:55 AM Changeset in webkit [150078] by
-
- 3 edits in trunk/Source/WebCore
[CSSRegions] Improve hit testing for empty regions
https://bugs.webkit.org/show_bug.cgi?id=115534
Reviewed by David Hyatt.
As a better follow up after WebKit bug https://bugs.webkit.org/show_bug.cgi?id=107752,
we can improve the code by not doing hit testing on the render flow thread object when
we are trying to hit test the render flow thread background. In this case, we should just bail out.
No new tests, covered by existing regions tests.
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::nodeAtPoint):
(WebCore):
(WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion):
- rendering/RenderFlowThread.h:
- 10:54 AM Changeset in webkit [150077] by
-
- 2 edits in trunk/Tools
[Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
https://bugs.webkit.org/show_bug.cgi?id=116079
Reviewed by David Kilzer.
- Scripts/old-run-webkit-tests:
(setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
- 10:53 AM Changeset in webkit [150076] by
-
- 6 edits in trunk/Source/WebCore
[BlackBerry] Handle network errors when starting a new job
https://bugs.webkit.org/show_bug.cgi?id=116101
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Make startJob() return a network status that can be used by the
caller to create a network error.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize): createNetworkStream() should
always return a valid pointer so use an ASSERT instead of an early
return to make sure we have a valid stream.
(WebCore::NetworkJob::startNewJobWithRequest): Only return true if
the network job was started successfully.
- platform/network/blackberry/NetworkJob.h:
(NetworkJob): Make initialize method void instead of bool since it
can't fail.
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Return a network error or
StatusSuccess.
- platform/network/blackberry/NetworkManager.h:
(NetworkManager):
- platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start): Return true if job was started
successfully.
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
Check return value of startJob and fill the ResourceError with the
network status returned to finish the load.
- 10:44 AM Changeset in webkit [150075] by
-
- 2 edits in trunk/Source/WebCore
[Mac] captions menu is not positioned correctly in full-screen
https://bugs.webkit.org/show_bug.cgi?id=116103
Update the positioning properties of the captions menu in full-screen
following the fix for https://webkit.org/b/115968.
Reviewed by Darin Adler.
- css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-closed-captions-container):
Add 50px to the bottom position since we're now positioned relative to the
media element, and use a calc() command to be right-aligned to the captions
icon in the media controller. The max-width and max-height properties follow
the same technique used for the non-full-screen mode.
- 10:40 AM Changeset in webkit [150074] by
-
- 15 edits in trunk
[GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115921
Reviewed by Gustavo Noronha Silva.
.:
- GNUmakefile.am: Add GENSOURCES_PLATFORM, platform_built_sources variables.
Source/Platform:
- GNUmakefile.am: Move the ANGLE include directories under the new platform_cppflags variable,
adding the DerivedSources/Platform directory. Add the generated sources' build targets to libPlatform
under nodist_libPlatform_la_SOURCES. Add platform_cppflags to the list of libPlatformGtk CPPFLAGS.
Add generation rules for the ColorData.cpp and WebKitFontFamilyNames.(cpp|h) source files, now generated
into the DerivedSources/Platform directory.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreSVG, libWebCore,
libWebCorePlatform, libWebCoreGtk. Remove generation rules for ColorData.cpp and WebKitFontFamilyNames.(cpp|h).
- GNUmakefile.list.am: Include the ColorData.cpp and WebKitFontFamilyNames.(cpp|h) build targers under
platform_built_sources.
- bindings/gobject/GNUmakefile.am: Add platform_cppflags to the list of libWebCoreDOM CPPFLAGS.
Source/WebKit/gtk:
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libwebkit2gtk, libWebCoreGtk2,
libPlatformGtk2 and WebKitPluginProcess.
Source/WebKit2:
- GNUmakefile.am: Add platform_cppflags to the list of libwebkit2gtk CPPFLAGS.
Tools:
- GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
- TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
- 10:31 AM Changeset in webkit [150073] by
-
- 4 edits in trunk/Source
[GTK] libPlatform, libPlatformGtk must depend on the related GNUmakefiles
https://bugs.webkit.org/show_bug.cgi?id=115937
Reviewed by Martin Robinson.
Source/Platform:
- GNUmakefile.am: Set up an artifical dependency so that libPlatform and libPlatformGtk
libraries take into account any changes in this GNUmakefile.am and the GNUmakefile.list.am
located under Source/WebCore. The latter is included due to all the build targets for the
two libraries being listed there.
Source/WebCore:
No new tests - no new functionality.
- GNUmakefile.am: Fix typos in two libraries' names - Webcore -> WebCore.
- 9:52 AM Changeset in webkit [150072] by
-
- 4 edits2 adds in trunk
Removing Attr can delete a wrong Attribute in ElementData
https://bugs.webkit.org/show_bug.cgi?id=116077
Source/WebCore:
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/e861452a292e185501e48940305947aa6a4e23c2
after simplifying and renaming functions to be more WebKit style.
The XML parser can produce elements with attributes whose names have
distinct prefixes, but the same expanded name. When one of these
attributes is put up for adoption, it may be its similarly named
sibling that is removed from its owner element. As a result the
original owner hangs onto the adopted attribute, despite the fact that
it is now in a different document. Sometimes it's just hard to let go.
Test: fast/dom/adopt-attribute-crash.svg
- dom/Element.cpp:
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::ElementData::getAttributeItemIndex):
- dom/Element.h:
(ElementData):
(Element):
LayoutTests:
Reviewed by Benjamin Poulain.
Add a regression test by importing
https://chromium.googlesource.com/chromium/blink/+/e861452a292e185501e48940305947aa6a4e23c2
- fast/dom/adopt-attribute-crash-expected.txt: Added.
- fast/dom/adopt-attribute-crash.svg: Added.
- 9:17 AM Changeset in webkit [150071] by
-
- 7 edits in trunk/Source
[BlackBerry] Use requestAnimationFrame for animations
https://bugs.webkit.org/show_bug.cgi?id=115896
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Make WebPagePrivate a
BlackBerry::Platform::AnimationFrameRateClient and use it to
schedule animations.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::animationFrameChanged):
(BlackBerry::WebKit::WebPagePrivate::scheduleAnimation):
(BlackBerry::WebKit::WebPagePrivate::startRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::stopRefreshAnimationClient):
(BlackBerry::WebKit::WebPagePrivate::handleServiceScriptedAnimationsOnMainThread):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::scheduleAnimation):
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
Source/WTF:
- wtf/Platform.h: Disable REQUEST_ANIMATION_FRAME_TIMER and
WTF_USE_REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for BlackBerry
port.
- 8:59 AM Changeset in webkit [150070] by
-
- 19 edits in trunk/Source/WebCore
Remove ::-webkit-distributed()
https://bugs.webkit.org/show_bug.cgi?id=116106
Reviewed by Andreas Kling.
This experimental Shadow DOM selector code is unused and has no owner.
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
(WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded):
(WebCore::CSSParser::rewriteSpecifiersWithElementName):
- css/CSSParser.h:
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::CSSParserSelector):
- css/CSSParserValues.h:
(CSSParserSelector):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
- css/CSSSelectorList.cpp:
- css/CSSSelectorList.h:
(CSSSelectorList):
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::resetAuthorStyle):
- css/DocumentRuleSets.h:
(DocumentRuleSets):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAuthorRules):
- css/ElementRuleCollector.h:
(ElementRuleCollector):
- css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
- css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectIdentifierHashes):
- html/shadow/InsertionPoint.cpp:
- html/shadow/InsertionPoint.h:
- 7:29 AM Changeset in webkit [150069] by
-
- 5 edits in trunk/Source/WebCore
Remove RenderTheme::supportsCalendarPicker
https://bugs.webkit.org/show_bug.cgi?id=116068
Patch by Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> on 2013-05-14
Reviewed by Benjamin Poulain.
No new tests needed because it doesn't affect behaviour.
This method was never overrided by any platform
and always leaded to the same behaviour.
The code which depended on it was also removed.
- html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
- html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
- page/ChromeClient.h:
(ChromeClient):
- rendering/RenderTheme.h:
- 5:54 AM Changeset in webkit [150068] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][Win] Fix ASSERT(DeleteTimerQueueTimer...)
https://bugs.webkit.org/show_bug.cgi?id=116039
Reviewed by Benjamin Poulain.
According to the documentation, DeleteTimerQueueTimer can be expected to return
false with an ERROR_IO_PENDING error when called from the timer's callback.
- Platform/win/WorkQueueWin.cpp:
(WorkQueue::timerCallback):
- 5:51 AM Changeset in webkit [150067] by
-
- 2 edits in trunk/LayoutTests
Modify checkLayout to receive the log container as an optional parameter
https://bugs.webkit.org/show_bug.cgi?id=112793
Reviewed by Darin Adler.
Add a way to specify the container manually for checkLayout. This is helpful to measure regions for nested
named flows (and probably other cases as well).
- resources/check-layout.js: Added an optional parameter to window.checkLayout.
- 5:49 AM Changeset in webkit [150066] by
-
- 4 edits2 adds in trunk
[GStreamer] cannot seek after video finished
https://bugs.webkit.org/show_bug.cgi?id=114044
Patch by Balazs Kelemen <b.kelemen@sisa.samsung.com> on 2013-04-30
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-seek-after-end.html
Reland without wrong assertion. If seek is called after didEnd the pipeline
state will not be in GST_STATE_NULL yet but it is not a problem because we handle that.
Rework the seeking logic to be able to seek after reseting the pipeline.
In addition to solve the actual problem this patch supposed to make seeking
more robust and correct.
The previous implementation tried to hide the complexity of asynchronous operations
on the pipeline. It did not handle the GST_MESSAGE_ASYNC_DONE message from the bus
but instead reported the seek as finished when it saw an asynchronous pending state
(GST_STATE_CHANGE_ASYNC) which could happen way before the seek is really done.
Now we pay attention to the GST_MESSAGE_ASYNC_DONE message to track the status of seeks.
Seeks are not the only operations executed asynchronously, changing the pipeling state is
similar. It means a seek can overlap with onother ongoing asynchronous operation.
This change address this by introducing an invariant for seeks, which is that we only request
a seek if there are no other ongoing asynchronous operations and the pipeline state is either
paused or playing (which is recommended anyway according to GStreamer's documentation).
This way we can be sure that the time when we get the next GST_MESSAGE_ASYNC_DONE message the
seek has been completed.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::toGstClockTime): Factored time conversation into a helper.
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition): The position might not be available
if the pipeline still has a pending state. As a workaround, if we are right after a seek we can
use the seek time. Avoiding this situation would be possible by not allowing any asynchronous
operation to overlap. I believe it would add a lot more complexity so I decided to rather introduce
this workaround. Otherwise those overlapping operations are handled fine by GStreamer.
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Do not reset internal state variables.
This function called when there is an intent to restart playback but it does not actually restart it.
(WebCore::MediaPlayerPrivateGStreamer::currentTime): Just removed a staling newline.
(WebCore::MediaPlayerPrivateGStreamer::seek): Take a look to the pipeline state and act upon that.
If there is an ongoing asynchronous operation make the seek pending, otherwise do it now.
Now we handle overlapping seeks as well because I saw that it can happen in some tests.
Added an early return for live streams as it doesn't makes sense to try seeking in them.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Handle GST_MESSAGE_ASYNC_DONE and some refactoring.
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Only handle seeks in the pending case, the rest is
now handled in asyncStateChangeDone.
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration): Do not reset the m_mediaDurationKnown if the pipeline
has an asynchronous pending state because it would fail. It does actually happen when we get a duration message
after restarting the pipeline and it would result in restarting playback from the start. It seems to be a bug
in GStreamer that it sends the duration message too early. Also sanitized this function by merging redundant branches.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
LayoutTests:
- media/video-seek-after-end-expected.txt: Added.
- media/video-seek-after-end.html: Added.
- 5:27 AM Changeset in webkit [150065] by
-
- 3 edits2 adds in trunk
Ellipsis text is placed to wrong position, when the truncated text is fully cut off in RTL direction.
https://bugs.webkit.org/show_bug.cgi?id=115858
Patch by Zalan Bujtas <Alan Bujtas> on 2013-05-14
Reviewed by Darin Adler.
Source/WebCore:
Take text direction into account to calculate ellipsis position in case of
full truncation.
Test: fast/css/text-overflow-ellipsis-full-truncate-rtl.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::placeEllipsisBox):
LayoutTests:
- fast/css/text-overflow-ellipsis-full-truncate-rtl-expected.html: Added.
- fast/css/text-overflow-ellipsis-full-truncate-rtl.html: Added.
- 4:37 AM Changeset in webkit [150064] by
-
- 7 edits in trunk/Source/WebKit2
Remove unused "type" field from DictionaryPopupInfo
https://bugs.webkit.org/show_bug.cgi?id=116011
Reviewed by Darin Adler.
It is unused, and furthermore, PDFPlugin sets it incorrectly anyway.
- Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
- Shared/DictionaryPopupInfo.h:
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::showDefinitionForAttributedString):
- WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::lookUpInDictionary):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
- 4:32 AM Changeset in webkit [150063] by
-
- 4 edits in trunk/Source/WebKit2
[WK2] Make WebPageProxy use deviceScaleFactor() in creationParameters().
https://bugs.webkit.org/show_bug.cgi?id=110218
Reviewed by Darin Adler.
Make the WebPageProxy::creationParameters use the accessor
deviceScaleFactor() instead of using m_intrinsicDeviceScaleFactor
directly. This will restore the custom device scale factor when
reattaching to the WebProcess after a crash.
Moreover, it will enable the Qt and ELF ports to use the
existing C API for overriding the device scale factor instead
of using the WebPageProxy directly or adding new C API to set
the intrinsic device scale factor.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
- UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- 3:12 AM Changeset in webkit [150062] by
-
- 12 edits3 adds2 deletes in trunk/Source
[BlackBerry] Implement platform strategies
https://bugs.webkit.org/show_bug.cgi?id=112162
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
Source/WebCore:
This is just a refactoring, covered by existing tests.
- CMakeLists.txt: Move PlatformStrategies.cpp from platform
specific makefiles to the global one now that all platforms using
cmake implement platform strategies.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- loader/CookieJar.cpp: Remove the preprocessor error that is not
needed anymore.
- loader/blackberry/CookieJarBlackBerry.cpp: Removed.
- platform/network/blackberry/CookieJarBlackBerry.cpp: Added.
(WebCore):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
(WebCore::deleteAllCookies):
- plugins/blackberry/PluginDataBlackBerry.cpp: Removed.
Source/WebKit:
- PlatformBlackBerry.cmake: Add new files to compilation.
Source/WebKit/blackberry:
- Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize): Initialize platform
strategies.
- WebCoreSupport/PlatformStrategiesBlackBerry.cpp: Added.
(PlatformStrategiesBlackBerry::initialize):
(PlatformStrategiesBlackBerry::PlatformStrategiesBlackBerry):
(PlatformStrategiesBlackBerry::createCookiesStrategy):
(PlatformStrategiesBlackBerry::createDatabaseStrategy):
(PlatformStrategiesBlackBerry::createLoaderStrategy):
(PlatformStrategiesBlackBerry::createPasteboardStrategy):
(PlatformStrategiesBlackBerry::createPluginStrategy):
(PlatformStrategiesBlackBerry::createSharedWorkerStrategy):
(PlatformStrategiesBlackBerry::createStorageStrategy):
(PlatformStrategiesBlackBerry::createVisitedLinkStrategy):
(PlatformStrategiesBlackBerry::cookiesForDOM):
(PlatformStrategiesBlackBerry::setCookiesFromDOM):
(PlatformStrategiesBlackBerry::cookiesEnabled):
(PlatformStrategiesBlackBerry::cookieRequestHeaderFieldValue):
(PlatformStrategiesBlackBerry::getRawCookies):
(PlatformStrategiesBlackBerry::deleteCookie):
(PlatformStrategiesBlackBerry::refreshPlugins):
(PlatformStrategiesBlackBerry::getPluginInfo):
(PlatformStrategiesBlackBerry::isLinkVisited):
(PlatformStrategiesBlackBerry::addVisitedLink):
- WebCoreSupport/PlatformStrategiesBlackBerry.h: Added.
(PlatformStrategiesBlackBerry):
Source/WTF:
- wtf/Platform.h: Add BlackBerry platform to the list of platforms
using platform strategies.
- 2:23 AM Changeset in webkit [150061] by
-
- 3 edits in trunk/LayoutTests
[Qt] Unreviewed gardening.
- platform/qt/TestExpectations: Skip test using disabled feature.
- platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Rebaselining after r149869.
- 1:52 AM Changeset in webkit [150060] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Crash due to an assert in FrameView::doDeferredRepaints
https://bugs.webkit.org/show_bug.cgi?id=115412
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-14
Reviewed by Rob Buis.
PR 115412
The problem is that we are calling
updateLayoutAndStyleIfNeededRecursive() (because of
zoomToInitialScaleOnLoad) from ChomeClient::layoutUpdated()
callback which is not expected. It's expected to be called right
before painting, and not right after painting. Even if a new
layout is not done, updateLayoutAndStyleIfNeededRecursive() calls
flushDeferredRepaints() and it's possible that this is called in
the middle of a beginDeferredRepaints() and endDeferredRepaints()
apparently.
In general only BackingStore should call
updateLayoutAndStyleIfNeededRecursive before painting, and a simple
layout is enough in all other cases like resizing. This patch renames
requestLayoutIfNeeded as updateLayoutAndStyleIfNeededRecursive to
make more obvious what it does, and adds layoutIfNeeded that calls
layout. The former is used by the BackingStore and the latter by
WebPage.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resumeScreenUpdates):
(BlackBerry::WebKit::BackingStorePrivate::requestLayoutIfNeeded):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::updateLayoutAndStyleIfNeededRecursive):
(BlackBerry::WebKit::WebPagePrivate::layoutIfNeeded):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::zoomAnimationFinished):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
- Api/WebPage_p.h:
(WebPagePrivate):
- 1:49 AM Changeset in webkit [150059] by
-
- 37 edits1 move2 adds in trunk/LayoutTests
[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=116090
Unreviewed EFL gardening.
Rebaseline after r155023.
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-14
- platform/efl/TestExpectations:
- platform/efl/fast/table/007-expected.png:
- platform/efl/fast/table/007-expected.txt:
- platform/efl/fast/table/colspanMinWidth-expected.png:
- platform/efl/fast/table/colspanMinWidth-expected.txt:
- platform/efl/fast/table/spanOverlapRepaint-expected.png:
- platform/efl/fast/table/spanOverlapRepaint-expected.txt:
- platform/efl/fast/table/table-rowspan-height-distribution-in-rows-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug13169-expected.png:
- platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Added.
- platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
- platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17138-expected.png:
- platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
- platform/efl/tables/mozilla/bugs/bug17548-expected.png:
- platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
- platform/efl/tables/mozilla/bugs/bug220536-expected.png:
- platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
- platform/efl/tables/mozilla/bugs/bug6304-expected.png:
- platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
- platform/efl/tables/mozilla/bugs/bug73321-expected.txt: Renamed from LayoutTests/platform/efl-wk2/tables/mozilla/bugs/bug73321-expected.txt.
- platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
- platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
- platform/efl/tables/mozilla/core/bloomberg-expected.png:
- platform/efl/tables/mozilla/core/bloomberg-expected.txt:
- platform/efl/tables/mozilla/core/cell_heights-expected.txt:
- platform/efl/tables/mozilla/other/test6-expected.png:
- platform/efl/tables/mozilla/other/test6-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
- platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
- 1:40 AM Changeset in webkit [150058] by
-
- 2 edits in trunk/LayoutTests
The tests marked with the comment "WebKitTestRunner needs to sanitize file urls in the output"
run successfully with WebKitTestRunner. They should not be skipped.
https://bugs.webkit.org/show_bug.cgi?id=116083
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-14
Reviewed by Darin Adler.
- platform/wk2/TestExpectations:
Unskip tests.
- 1:31 AM Changeset in webkit [150057] by
-
- 4 edits in trunk/Source
[Qt] Fix a crash under ~PingLoader when the QNAM on the page has been destroyed.
https://bugs.webkit.org/show_bug.cgi?id=116035
Reviewed by Simon Hausmann.
Source/WebCore:
Reproduced with arora which does destroy the QNetworkAccessManager in some situations.
The problem is that PingLoader can still be pending meanwhile, holding a ResourceHandle
with a dangling pointer to a QNetworkReply destroyed with the QNetworkAccessManager.
- platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper):
Set the parent to 0 like we did before the introduction of QNetworkReplyWrapper.
(WebCore::QNetworkReplyWrapper::release):
Source/WebKit/qt:
- tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::networkReplyParentChanged):
